]> code.delx.au - gnu-emacs/blob - src/ChangeLog
* src/xterm.c (x_term_init): Move call to gdk_window_add_filter before
[gnu-emacs] / src / ChangeLog
1 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2
3 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
4 gtk_init (Bug#10100).
5
6 2011-12-10 Eli Zaretskii <eliz@gnu.org>
7
8 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
9 IT->string is nil. (Bug#10263)
10
11 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
12
13 * nsterm.h (x_free_frame_resources): Declare.
14
15 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
16 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
17
18 * nsterm.h (ns_get_defaults_value): Declare.
19
20 * nsterm.m (ns_default): Call ns_get_defaults_value.
21
22 2011-12-09 Eli Zaretskii <eliz@gnu.org>
23
24 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
25 (Bug#10170)
26
27 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
28
29 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
30 that where the value of an _OBJC_* symbol points to is in the .bss
31 section (Bug#10240).
32
33 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
34
35 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
36 after the loop to call ccl_driver at least once (Bug#8619).
37
38 2011-12-08 Kenichi Handa <handa@m17n.org>
39
40 * ftfont.c (get_adstyle_property): Fix previous change
41 (Bug#10233).
42
43 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
44
45 * w32.c (init_environment): If no_site_lisp, remove site-lisp
46 dirs from the default value of EMACSLOADPATH (bug#10208).
47
48 2011-12-07 Glenn Morris <rgm@gnu.org>
49
50 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
51 installation and source directories as well. (Bug#10208)
52
53 2011-12-06 Chong Yidong <cyd@gnu.org>
54
55 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
56
57 2011-12-06 Glenn Morris <rgm@gnu.org>
58
59 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
60 as an error, not just -1. (Bug#10217)
61
62 2011-12-05 Chong Yidong <cyd@gnu.org>
63
64 * keyboard.c (process_special_events): New function.
65 (swallow_events, Finput_pending_p): Use it (Bug#10195).
66
67 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
68
69 * coding.c (encode_designation_at_bol): Don't use uninitialized
70 local variable (Bug#9318).
71
72 2011-12-05 Kenichi Handa <handa@m17n.org>
73
74 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
75 return Qnil (Bug#8046, Bug#10193).
76
77 2011-12-05 Kenichi Handa <handa@m17n.org>
78
79 * coding.c (encode_designation_at_bol): New args charbuf_end and
80 dst. Return the number of produced bytes. Callers changed.
81 (coding_set_source): Return how many bytes coding->source was
82 relocated.
83 (coding_set_destination): Return how many bytes
84 coding->destination was relocated.
85 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
86 (CODING_CHAR_CHARSET_P): Adjusted for the avove changes.
87
88 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
89
90 * coding.c (CODING_CHAR_CHARSET_P): New macro.
91 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
92 macro (Bug#9318).
93
94 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
95
96 The following changes are to fix Bug#9318.
97
98 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
99 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
100 (encode_coding_iso_2022, encode_coding_sjis)
101 (encode_coding_big5, encode_coding_charset): Use the above macros.
102
103 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
104
105 * lisp.h (process_quit_flag): Fix external declaration.
106
107 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
108
109 Don't macro-inline non-performance-critical code.
110 * eval.c (process_quit_flag): New function.
111 * lisp.h (QUIT): Use it.
112
113 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
114
115 * nsfns.m (get_geometry_from_preferences): New function.
116 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
117
118 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
119
120 * emacs.c (Qkill_emacs): Define.
121 (syms_of_emacs): Initialize it.
122 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
123 Qquit_flag to `kill-emacs' instead.
124 (quit_throw_to_read_char): Add parameter `from_signal'.
125 All callers changed. Call Fkill_emacs if requested and safe.
126 * lisp.h (QUIT): Call Fkill_emacs if requested.
127
128 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
129
130 * widget.c (update_wm_hints): Return if wmshell is null.
131 (widget_update_wm_size_hints): New function.
132
133 * widget.h (widget_update_wm_size_hints): Declare.
134
135 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
136 widget_update_wm_size_hints (Bug#10104).
137
138 2011-12-03 Eli Zaretskii <eliz@gnu.org>
139
140 * xdisp.c (handle_invisible_prop): If the invisible text ends just
141 before a newline, prepare the bidi iterator for consuming the
142 newline, and keep the current paragraph direction. (Bug#10183)
143 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
144
145 2011-12-02 Juri Linkov <juri@jurta.org>
146
147 * search.c (Fword_search_regexp): New Lisp function created from
148 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
149 (Fword_search_backward, Fword_search_forward)
150 (Fword_search_backward_lax, Fword_search_forward_lax):
151 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
152 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
153
154 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
155
156 * fileio.c (Finsert_file_contents): Move after-change-function call
157 to before the "handled:" label, since all "goto handled" appear in
158 cases where the *-change-functions have already been properly called
159 (bug#10117).
160
161 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
162
163 * keyboard.c (interrupt_signal): Don't call kill-emacs when
164 waiting for input. (Bug#10169)
165
166 2011-11-30 Eli Zaretskii <eliz@gnu.org>
167
168 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
169 verifies glyph row's hash code--we have just reallocated the
170 glyphs, so their contents can be complete garbage. (Bug#10164)
171
172 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
173
174 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
175
176 2011-11-30 Eli Zaretskii <eliz@gnu.org>
177
178 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
179 attributes are tested _before_ calling verify_row_hash, to protect
180 against GCC re-ordering of the tests. (Bug#10164)
181
182 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
183
184 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
185
186 * xterm.c (handle_one_xevent): Only set async_visible and friends
187 if net_wm_state_hidden_seen is non-zero (Bug#10002)
188 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
189 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
190
191 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
192
193 Remove GCPRO-related macros that exist only to avoid shadowing locals.
194 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
195 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
196 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
197 All uses changed to use GCPRO1 etc.
198 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
199 Revert to old implementation (i.e., before 2011-03-11).
200
201 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
202
203 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
204 of scroll runs so as to avoid assigning disabled bogus rows and
205 unnecessary graphics copy operations.
206
207 2011-11-27 Eli Zaretskii <eliz@gnu.org>
208
209 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
210 (snprintf) [_MSC_VER]: Redirect to _snprintf.
211 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
212 (malloc, free, realloc, calloc): Redirect to e_* only when
213 compiling Emacs.
214
215 * lisp.h (GCTYPEBITS): Move before first use.
216 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
217 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
218 this macro definition.
219
220 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
221 _MSC_VER.
222
223 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
224
225 * gtkutil.c (xg_create_frame_widgets):
226 Call gtk_window_set_has_resize_grip (FALSE) if that function is
227 present with Gtk+ 2.0.
228
229 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
230
231 * fileio.c (Finsert_file_contents): Undo previous change; see
232 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
233
234 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
235
236 Rename locals to avoid shadowing.
237 * fileio.c (Finsert_file_contents):
238 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
239 * process.c (wait_reading_process_output):
240 Rename inner 'proc' to 'p' to avoid shadowing.
241 Indent for consistency with usual Emacs style.
242
243 2011-11-25 Eli Zaretskii <eliz@gnu.org>
244
245 * xdisp.c (redisplay_window): If cursor row is not fully visible
246 after recentering, and scroll-conservatively is set to a large
247 number, scroll window by a few more lines to make the cursor fully
248 visible and out of scroll-margin. (Bug#10105)
249 (start_display): Don't move to the next line if the display should
250 start at a newline that is part of a display vector or an overlay
251 string. (Bug#10119)
252
253 2011-11-24 Juri Linkov <juri@jurta.org>
254
255 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
256 after the `MagickPingImage' call. (Bug#10112)
257
258 2011-11-23 Chong Yidong <cyd@gnu.org>
259
260 * window.c (Fcoordinates_in_window_p): Accept only live windows.
261
262 2011-11-23 Martin Rudalics <rudalics@gmx.at>
263
264 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
265 making another buffer current. (Bug#10114)
266
267 2011-11-23 Glenn Morris <rgm@gnu.org>
268
269 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
270
271 2011-11-23 Chong Yidong <cyd@gnu.org>
272
273 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
274 using it (Bug#5984).
275
276 2011-11-22 Eli Zaretskii <eliz@gnu.org>
277
278 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
279 and header-lines, as they don't have one computed for them.
280 (Bug#10098)
281
282 * .gdbinit (prow): Make displayed values more self-explaining.
283 Add row's hash code.
284
285 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
286
287 * process.c (wait_reading_process_output): Fix asynchrounous
288 GnuTLS socket handling on some versions of the GnuTLS library.
289 (wait_reading_process_output): Add comment and URL.
290
291 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
292
293 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
294
295 2011-11-21 Chong Yidong <cyd@gnu.org>
296
297 * window.c (Fnext_window, Fprevious_window): Doc fix.
298
299 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
300
301 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
302
303 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
304
305 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
306
307 2011-11-20 Martin Rudalics <rudalics@gmx.at>
308
309 * window.c (Fset_window_combination_limit): Rename argument
310 STATUS to LIMIT.
311 (Vwindow_combination_limit): Remove "status" from doc-string.
312
313 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
314
315 * m/ibms390.h: Remove.
316 * m/ibms390x.h: Don't include "ibms390.h".
317
318 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
319
320 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
321 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
322
323 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
324
325 * casetab.c (Fset_case_table):
326 * charset.c (Fcharset_after): Fix typos.
327
328 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
329
330 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
331 Otherwise, valgrind does not work on some platforms.
332 Problem reported by Andreas Schwab in
333 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
334 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
335 is set, removing the need for VIRT_ADDRESS_VARIES.
336 (PURE_P): Use a more-efficient implementation that needs just one
337 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
338 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
339 to 4 (xorl, subq, cmpq, setbe).
340 * alloc.c (pure): Always extern now, since that's the
341 VIRT_ADDR_VARIES behavior.
342 (PURE_POINTER_P): Use a single comparison, not two, for
343 consistency with the new puresize.h.
344 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
345 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
346 Remove VIRT_ADDR_VARIES no longer needed.
347
348 2011-11-19 Eli Zaretskii <eliz@gnu.org>
349
350 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
351 (erase_phys_cursor, update_window_cursor, show_mouse_face)
352 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
353 behave as if the cursor position were at the window margin.
354
355 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
356 and the cursor position is out of bounds, behave as if the cursor
357 position were at the window margin. (Bug#10075)
358
359 2011-11-18 Chong Yidong <cyd@gnu.org>
360
361 * window.c (Fwindow_combination_limit): Make first argument
362 non-optional, since it is meaningless for live windows like the
363 selected window.
364
365 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
366
367 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
368
369 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
370
371 * intervals.c: Fix grafting over the whole buffer (bug#10071).
372 (graft_intervals_into_buffer): Simplify.
373
374 2011-11-18 Eli Zaretskii <eliz@gnu.org>
375
376 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
377 hash values of the two rows.
378 (copy_row_except_pointers): Preserve the used[] arrays and the
379 hash values of the two rows. (Bug#10035)
380 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
381
382 * xdisp.c (row_hash): New function, body extracted from
383 compute_line_metrics.
384 (compute_line_metrics): Call row_hash, instead of computing the
385 hash code inline.
386
387 * dispnew.c (verify_row_hash): Call row_hash for computing the
388 hash code of a row, instead of duplicating code from xdisp.c.
389
390 * dispextern.h (row_hash): Add prototype.
391
392 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
393
394 * frame.c (delete_frame): Don't delete the terminal when the last
395 X frame is closed if emacs is built with GTK toolkit.
396
397 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
398
399 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
400
401 2011-11-17 Martin Rudalics <rudalics@gmx.at>
402
403 * window.c (Vwindow_splits): Rename to
404 Vwindow_combination_resize. Suggested by Juri Linkov.
405 (Fsplit_window_internal): Use Vwindow_combination_resize instead
406 of Vwindow_splits.
407
408 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
409
410 * nsfns.m (Fns_font_name):
411 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
412
413 2011-11-16 Martin Rudalics <rudalics@gmx.at>
414
415 * window.h (window): Rename slot "nest" to "combination_limit".
416 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
417 (Fset_window_nest): Rename to Fset_window_combination_limit.
418 (Vwindow_nest): Rename to Vwindow_combination_limit.
419 (recombine_windows, make_parent_window, make_window)
420 (Fsplit_window_internal, saved_window)
421 (Fset_window_configuration, save_window_save): Rename all
422 occurrences of window_nest to window_combination_limit.
423
424 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
425
426 * image.c (imagemagick_load_image): Fix typo.
427
428 2011-11-14 Eli Zaretskii <eliz@gnu.org>
429
430 * xdisp.c (display_line): Move the call to
431 highlight_trailing_whitespace before the call to
432 compute_line_metrics, since the latter needs to see the final
433 faces of all the glyphs to compute ROW's hash value.
434 Fixes assertion violations in row_equal_p. (Bug#10035)
435
436 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
437
438 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
439 just return (bug#10044).
440
441 2011-11-12 Eli Zaretskii <eliz@gnu.org>
442
443 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
444 with user-defined heap size. Bump the default size of the temacs
445 heap to 27MB, to avoid memory warning when running temacs.
446 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
447
448 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
449 current_matrix and desired_matrix. (Bug#9990)
450 (verify_row_hash) [XASSERTS]: New function.
451 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
452 that the hash value of glyph rows is correct.
453
454 2011-11-12 Martin Rudalics <rudalics@gmx.at>
455
456 * window.h (window): Remove splits slot.
457 * window.c (Fwindow_splits, Fset_window_splits): Remove.
458 (Fdelete_other_windows_internal, make_parent_window)
459 (make_window, Fsplit_window_internal, Fdelete_window_internal)
460 (Fset_window_configuration, save_window_save): Don't deal with
461 split status of windows.
462 (saved_window): Remove splits slot.
463 (Vwindow_splits): Rewrite doc-string.
464
465 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
466
467 * xfns.c (unwind_create_frame):
468 * nsfns.m (unwind_create_frame):
469 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
470 Vframe_list (Bug#9999).
471
472 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
473
474 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
475
476 2011-11-11 Kenichi Handa <handa@m17n.org>
477
478 * callproc.c (Fcall_process): Set the member dst_multibyte of
479 process_coding.
480
481 2011-11-11 Johan Bockgård <bojohan@gnu.org>
482
483 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
484 avoid a crash (bug#9496).
485
486 2011-11-09 Chong Yidong <cyd@gnu.org>
487
488 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
489 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
490
491 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
492
493 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
494
495 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
496
497 Avoid some portability problems by eschewing 'extern inline' functions.
498 The trivial performance wins aren't worth the portability hassles; see
499 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
500 et seq.
501 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
502 (window_box_width, window_box_left, window_box_left_offset)
503 (window_box_right, window_box_right_offset): Undo previous change,
504 by removing the "extern"s.
505 * intervals.c (adjust_intervals_for_insertion)
506 (adjust_intervals_for_deletion): Undo previous change,
507 making these static again.
508 (offset_intervals, temp_set_point_both, temp_set_point)
509 (copy_intervals_to_string): No longer inline.
510 * xdisp.c (window_text_bottom_y, window_box_width)
511 (window_box_height, window_box_left_offset)
512 (window_box_right_offset, window_box_left, window_box_right)
513 (window_box): No longer inline.
514
515 2011-11-08 Chong Yidong <cyd@gnu.org>
516
517 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
518 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
519 Signal an error if not a live window.
520 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
521 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
522
523 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
524
525 * lisp.h (syms_of_abbrev): Remove declaration.
526 Reported by CHENG Gao <chenggao@royau.me>.
527
528 2011-11-07 Eli Zaretskii <eliz@gnu.org>
529
530 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
531 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
532 of temacs in GUI mode.
533
534 2011-11-07 Martin Rudalics <rudalics@gmx.at>
535
536 * window.h: Declare delete_all_child_windows instead of
537 delete_all_subwindows.
538 * window.c (Fwindow_nest, Fset_window_nest)
539 (Fset_window_new_total, Fset_window_new_normal)
540 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
541 (delete_all_subwindows): Rename to delete_all_child_windows.
542 (Fdelete_other_windows_internal, Fset_window_configuration):
543 Call delete_all_child_windows instead of delete_all_subwindows.
544 * frame.c (delete_frame): Call delete_all_child_windows instead
545 of delete_all_subwindows.
546
547 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
548
549 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
550 This is also needed for porting to any host where GC_MARK_STACK is
551 not GC_MAKE_GCPROS_NOOPS.
552 (which_symbols): Use it.
553
554 2011-11-07 Kenichi Handa <handa@m17n.org>
555
556 * coding.c (coding_set_destination): Check coding->src_pos only
557 when coding->src_object is a buffer (bug#9910).
558
559 * process.c (send_process): Set the member src_multibyte of coding
560 to 0 (bug#9911) when sending a unibyte text.
561
562 * callproc.c (Fcall_process): Set the member src_multibyte of
563 process_coding to 0 (bug#9912).
564
565 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
566
567 * xmenu.c (cleanup_widget_value_tree): New function.
568 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
569 calling free_menubar_widget_value_tree directly (Bug#9830).
570
571 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
572
573 Fix some portability problems with 'inline'.
574 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
575 (window_box_width, window_box_left, window_box_left_offset)
576 (window_box_right, window_box_right_offset): Declare extern.
577 Otherwise, these inline functions do not conform to C99 and
578 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
579 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
580 * intervals.c (adjust_intervals_for_insertion)
581 (adjust_intervals_for_deletion): Now extern, because otherwise the
582 extern inline functions 'offset_intervals' couldn't refer to it.
583 (static_offset_intervals): Remove.
584 (offset_intervals): Rewrite using the old contents of
585 static_offset_intervals. The old version didn't conform to C99
586 because an extern inline function contained a reference to an
587 identifier with static linkage.
588
589 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
590
591 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
592 GC.
593
594 2011-11-06 Eli Zaretskii <eliz@gnu.org>
595
596 * xdisp.c (init_iterator, reseat_to_string): Don't set the
597 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
598 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
599 return Qleft_to_right.
600
601 2011-11-06 Chong Yidong <cyd@gnu.org>
602
603 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
604 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
605 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
606 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
607 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
608 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
609 (Fwindow_vscroll): Doc fix.
610 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
611 argument, since it makes no sense to pass a live window and for
612 consistency with window-child.
613
614 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
615
616 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
617 support MSVC.
618
619 2011-11-05 Jason Rumney <jasonr@gnu.org>
620
621 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
622 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
623 fonts (Bug#6029).
624 (add_font_entity_to_list): Fix logic errors in mixed boolean and
625 bitwise arithmetic preventing use of unicode-sip and non-truetype
626 opentype fonts.
627
628 2011-11-05 Eli Zaretskii <eliz@gnu.org>
629
630 * s/ms-w32.h (fstat, stat, utime): Move redirections to
631 "emacs"-only part.
632
633 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
634 initialization code to keep similarity to xfns.c after changes
635 from 2011-11-05.
636
637 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
638
639 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
640 (unwind_create_frame): New function (Bug#9943).
641 (Fx_create_frame): Restructure code to be more similar to the one in
642 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
643 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
644 Move terminal->reference_count++ just before making the frame official
645 (Bug#9943).
646
647 * nsterm.m (x_free_frame_resources): New function.
648 (x_destroy_window): Move code to x_free_frame_resources.
649
650 * xfns.c (unwind_create_frame): Fix comment.
651 (Fx_create_frame, x_create_tip_frame):
652 Move terminal->reference_count++ just before making the frame
653 official. Move initialization of image_cache_refcount and
654 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
655
656 2011-11-05 Eli Zaretskii <eliz@gnu.org>
657
658 Support MSVC build with newer versions of Visual Studio.
659 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
660 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
661 nt/gmake.defs.
662
663 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
664 which are not supported by MSVC.
665 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
666 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
667 bitfields.
668 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
669 types in bitfields.
670 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
671
672 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
673
674 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
675
676 Support MSVC build with newer versions of Visual Studio.
677 * w32.c: Don't include w32api.h for MSVC.
678 (init_environment) [_MSC_VER]: Call sys_access, not _access.
679
680 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
681 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
682 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
683 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
684 e_* cousins.
685 (alloca) [_MSC_VER]: Define to _alloca.
686
687 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
688
689 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
690
691 2011-11-04 Eli Zaretskii <eliz@gnu.org>
692
693 * xdisp.c (note_mouse_highlight): If either of
694 previous/next-single-property-change returns nil, treat that as
695 the beginning or the end of the buffer. (Bug#9955)
696
697 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
698
699 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
700 label is not null (Bug#9951).
701 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
702 may be NULL.
703
704 2011-11-04 Eli Zaretskii <eliz@gnu.org>
705
706 * window.c (Fwindow_body_size): Mention in the doc string that the
707 return value is in frame's canonical units. (Bug#9949)
708
709 2011-11-03 Eli Zaretskii <eliz@gnu.org>
710
711 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
712
713 * w32fns.c (unwind_create_frame): If needed, free the glyph
714 matrices of the partially constructed frame. (Bug#9943)
715 * xfns.c (unwind_create_frame): Likewise.
716
717 2011-11-01 Eli Zaretskii <eliz@gnu.org>
718
719 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
720 Don't stop backward scan on the continuation glyph, even though
721 its CHARPOS is positive.
722 (mouse_face_from_buffer_pos, note_mouse_highlight):
723 Rename cover_string to disp_string.
724
725 2011-11-01 Martin Rudalics <rudalics@gmx.at>
726
727 * window.c (temp_output_buffer_show): Don't use
728 Vtemp_buffer_show_specifiers.
729 (Vtemp_buffer_show_specifiers): Remove unused variable.
730
731 2011-10-30 Eli Zaretskii <eliz@gnu.org>
732
733 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
734 past the beginning of the current glyph matrix.
735
736 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
737
738 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
739 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
740 HAVE_GTK3 (Bug#9869).
741
742 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
743 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
744
745 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
746
747 * xterm.c: Declare x_handle_net_wm_state to return int.
748 (handle_one_xevent): Check if we are iconified but don't have
749 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
750 (get_current_wm_state): Return non-zero if not hidden,
751 check for _NET_WM_STATE_HIDDEN (Bug#9893).
752 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
753 (x_handle_net_wm_state): Return what get_current_wm_state returns.
754 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
755
756 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
757
758 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
759 so that this new function doesn't get optimized away by a
760 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
761
762 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
763
764 * frame.h (MOUSE_HL_INFO): Remove excess parens.
765
766 2011-10-29 Eli Zaretskii <eliz@gnu.org>
767
768 Fix the `xbytecode' command.
769 * .gdbinit (xprintbytestr): New command.
770 (xwhichsymbols): Rename from `which'; all callers changed.
771 (xbytecode): Print the byte-code string as well.
772
773 2011-10-29 Kim Storm <storm@cua.dk>
774
775 * alloc.c (which_symbols): New function.
776
777 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
778
779 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
780 line. (Bug#9903)
781
782 2011-10-29 Glenn Morris <rgm@gnu.org>
783
784 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
785 Not clear what it was for, and it causes various bugs. (Bug#9839)
786
787 2011-10-28 Eli Zaretskii <eliz@gnu.org>
788
789 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
790 possible random value that matches one of those tested as
791 condition to clear the mouse face.
792
793 2011-10-28 Chong Yidong <cyd@gnu.org>
794
795 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
796
797 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
798
799 * window.c (make_window): Initialize phys_cursor_on_p.
800
801 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
802
803 * lisp.h (struct Lisp_Symbol): Update comments.
804
805 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
806
807 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
808
809 2011-10-28 Eli Zaretskii <eliz@gnu.org>
810
811 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
812 <oslsachem@gmail.com> for helping to debug this.
813
814 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
815 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
816 (g_b_init_get_glyph_outline_w): New static variables.
817 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
818 (GetGlyphOutlineW_Proc): New typedefs.
819 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
820 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
821 New functions.
822 (w32font_open_internal, compute_metrics):
823 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
824 instead of calling the "wide" APIs directly.
825
826 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
827
828 * w32.h (syms_of_w32font): Add prototype.
829
830 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
831
832 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
833 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
834 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
835 (Fmove_to_window_line): Doc fix.
836
837 2011-10-27 Chong Yidong <cyd@gnu.org>
838
839 * process.c (make_process): Set gnutls_state to NULL.
840
841 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
842 non-NULL, regardless of GNUTLS_INITSTAGE.
843 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
844 an error. Set process slots as soon as we allocate them.
845
846 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
847
848 2011-10-27 Chong Yidong <cyd@gnu.org>
849
850 * gnutls.c (emacs_gnutls_deinit): New function.
851 Deallocate credentials structures as well as calling gnutls_deinit.
852 (Fgnutls_deinit, Fgnutls_boot): Use it.
853
854 * process.c (make_process): Initialize GnuTLS credentials to NULL.
855 (deactivate_process): Call emacs_gnutls_deinit.
856
857 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
858
859 * image.c (x_create_x_image_and_pixmap):
860 * w32.c (sys_rename, w32_delayed_load):
861 * w32font.c (fill_in_logfont):
862 * w32reg.c (x_get_string_resource): Silence compiler warnings.
863
864 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
865
866 * w32fns.c (w32_default_color_map): New function,
867 extracted from Fw32_default_color_map.
868 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
869
870 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
871
872 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
873
874 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
875
876 * keyboard.c (test_undefined): New function (bug#9751).
877 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
878
879 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
880
881 * sysdep.c (init_sys_modes): Fix the check for the controlling
882 terminal (Bug#6649).
883
884 2011-10-20 Eli Zaretskii <eliz@gnu.org>
885
886 * dispextern.h (struct bidi_it): New member next_en_type.
887
888 * bidi.c (bidi_line_init): Initialize the next_en_type member.
889 (bidi_resolve_explicit_1): When next_en_pos is valid for the
890 current character, check also for next_en_type being WEAK_EN.
891 (bidi_resolve_weak): Don't enter the expensive loop if the current
892 position is before next_en_pos. Record the bidi type of the first
893 non-ET, non-BN character we find, in addition to its position.
894 (bidi_level_of_next_char): Invalidate next_en_type when
895 next_en_pos is over-stepped.
896
897 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
898
899 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
900 * editfns.c: Rewrite current-time-zone so that it invokes
901 the equivalent of (format-time-string "%Z") to get the time zone name.
902 This fixes a bug when the time zone name contains characters that
903 need converting from the system time locale to Emacs internal format.
904 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
905 that patch fixed format-time-string to do the conversion, but
906 I forgot to fix current-time-zone.
907 (format_time_string): New function, containing most of
908 what Fformat_time_string used to contain.
909 (Fformat_time_string): Rewrite in terms of format_time_string.
910 This doesn't change this function's behavior.
911 (current-time-zone): Rewrite to use format_time_string.
912 This fixes the bug reported by Michael Schierl in
913 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
914 Jason Rumney's 2007-06-07 change worked around this bug, but
915 didn't fix it.
916 * systime.h (tzname, timezone): Remove no-longer-used declarations.
917
918 2011-10-19 Eli Zaretskii <eliz@gnu.org>
919
920 * xdisp.c (start_display): If the character at POS is displayed
921 via a display vector, reset IT->current.dpvec_index to zero.
922 (try_window_reusing_current_matrix): If a line ends in a display
923 vector or the next line starts in a display vector, continue
924 redrawing the window even though the character position of
925 start_row was reached.
926 (Bug#9771, part 2)
927
928 2011-10-18 Chong Yidong <cyd@gnu.org>
929
930 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
931 with nobreak-char-display too.
932
933 2011-10-18 Eli Zaretskii <eliz@gnu.org>
934
935 Fix part 3 of bug#9771.
936 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
937 (bidi_resolve_neutral): Don't enter the expensive loop looking for
938 non-neutral characters if the current character is a paragraph
939 separator (a.k.a. Newline). This avoids running the same
940 expensive loop twice, once when we consume the preceding newline
941 and the other time when the line actually needs to be displayed.
942 Avoid the loop when we see neutrals on the base embedding level
943 following a character whose directionality is the same as the
944 paragraph's. This avoids running the expensive loop when a line
945 ends in a long sequence of neutrals, like control characters.
946 Add assertion against STRONG_AL type. Slightly rearrange code
947 that determines the type of a neutral given the first non-neutral
948 that follows it.
949 (bidi_level_of_next_char): Set next_en_pos to zero when
950 invalidating its info.
951
952 2011-10-17 Eli Zaretskii <eliz@gnu.org>
953
954 * xdisp.c (push_display_prop): Determine whether to record string
955 or buffer position by IT->string, not by IT->method. Allow
956 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
957 (move_it_vertically_backward): Don't look for character position
958 immediately after the newline when in a continuation line.
959 (Bug#9771, part 1)
960
961 2011-10-15 Martin Rudalics <rudalics@gmx.at>
962
963 * window.c (coordinates_in_window): Rewrite and delabelize
964 vertical border check. (Bug#5357) (Bug#9618)
965
966 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
967
968 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
969 errors in XSetWindowBorder (bug#9310).
970
971 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
972
973 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
974 avoid crash when xmalloc overrun checking is enabled.
975
976 2011-10-13 Eli Zaretskii <eliz@gnu.org>
977
978 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
979 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
980 cursor motion with <left> and <right> arrow keys.
981
982 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
983 some callers set that themselves.
984
985 2011-10-12 Eli Zaretskii <eliz@gnu.org>
986
987 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
988 display string and the previous row comes from the same string and
989 is empty. (Bug#9739) (Bug#9738)
990
991 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
992
993 * doc.c (get_doc_string): Encode file name (bug#9735).
994
995 2011-10-12 Eli Zaretskii <eliz@gnu.org>
996
997 * bidi.c (bidi_level_of_next_char):
998 * xdisp.c (get_visually_first_element): Remove old incorrect
999 comments regarding the Unicode Line Separator character.
1000
1001 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1002
1003 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1004
1005 * alloc.c (Fgc_status): Do not access beyond zombies array
1006 boundary if nzombies > MAX_ZOMBIES.
1007 * alloc.c (dump_zombies): Add missing format specifier.
1008
1009 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1010
1011 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1012 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1013
1014 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1015 Some packages use them to denote characters with modifiers.
1016
1017 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1018
1019 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1020 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1021 matching a pp-number. Rename parameter var to var1.
1022
1023 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1024
1025 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1026
1027 2011-10-08 Glenn Morris <rgm@gnu.org>
1028
1029 * callint.c (Fcall_interactively): Give a more explicit error for the
1030 'c' case with a non-character input. (Bug#8479)
1031
1032 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1033
1034 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1035 lines.
1036 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1037 lines that are hscrolled on the left.
1038
1039 * dispnew.c (buffer_posn_from_coords): Account for a possible
1040 presence of header-line. (Bug#4426)
1041
1042 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1043
1044 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1045 Don't advertise functionality which we discourage or doesn't work.
1046
1047 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1048
1049 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1050 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1051 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1052 this makes Emacs dump core during garbage collection on rare
1053 occasions. sizeof is obviously inferior to offsetof here, so
1054 stick with offsetof.
1055 (GC_POINTER_ALIGNMENT): New macro.
1056 (mark_memory): Omit 3rd (offset) arg; caller changed.
1057 Don't assume EMACS_INT alignment is the same as pointer alignment.
1058
1059 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1060
1061 * keyboard.c (read_key_sequence_remapped): New var.
1062 (read_key_sequence): Compute remapping in the right buffer.
1063 (command_loop_1): Use read_key_sequence's remapping directly.
1064
1065 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1066
1067 * dired.c (file_name_completion): Don't expand file name.
1068 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1069 before checking file name handler.
1070
1071 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1072 they've been requested explicitly (bug#9591).
1073
1074 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
1075
1076 * keymap.c (Fsingle_key_description): Use make_specified_string
1077 instead of build_string to build string from push_key_description.
1078 (Bug#5193)
1079
1080 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1081
1082 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1083 This fixes a Y2038 bug on 64-bit hosts.
1084 * buffer.c (reset_buffer):
1085 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1086 (Fclear_buffer_auto_save_failure):
1087 Use 0, not -1, to represent an unset failure time, since time_t
1088 might not be signed.
1089
1090 Remove dependency on glibc malloc internals.
1091 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1092 Move back here from lisp.h, but with their new implementations.
1093 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1094 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1095 * charset.c (charset_table_init): New static var.
1096 (syms_of_charset): Use it instead of xmalloc. This removes a
1097 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1098 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1099 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1100 Move back to alloc.c.
1101 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1102 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1103
1104 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1105
1106 * nsterm.m (windowDidResize): Call x_set_window_size only when
1107 ns_in_resize is true. Otherwise set pixelwidth/height and
1108 call change_frame_size (Bug#9628).
1109
1110 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1111
1112 Port --enable-checking=all to Fedora 14 x86-64.
1113 * charset.c (syms_of_charset): Also account for glibc malloc's
1114 internal overhead when calculating the initial malloc maximum.
1115
1116 Port --enable-checking=all to Fedora 14 x86.
1117 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1118 Move to lisp.h.
1119 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1120 (overrun_check_realloc, overrun_check_free):
1121 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1122 That way, xmalloc returns a properly-aligned pointer even if
1123 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1124 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1125 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1126 into account when calculating the initial malloc maximum.
1127 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1128 Move here from alloc.c, so that charset.c can use it too.
1129 Properly align; the old code wasn't right for common 32-bit hosts
1130 when configured with --enable-checking=all.
1131 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1132 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1133
1134 2011-09-29 Eli Zaretskii <eliz@gnu.org>
1135
1136 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
1137 use EDOM.
1138
1139 2011-09-28 Eli Zaretskii <eliz@gnu.org>
1140
1141 * xdisp.c (compute_display_string_end): If there's no display
1142 string at CHARPOS, return -1.
1143
1144 * bidi.c (bidi_fetch_char): When compute_display_string_end
1145 returns a negative value, treat the character as a normal
1146 character not covered by a display string. (Bug#9624)
1147
1148 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
1149
1150 * lread.c (Fread_from_string): Fix typo in docstring.
1151
1152 2011-09-27 Eli Zaretskii <eliz@gnu.org>
1153
1154 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1155 newline, reseat the iterator instead of bidi-iterating there one
1156 character at a time. (Bug#9610)
1157 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1158 TO_CHARPOS if the bidi iterator is at base embedding level.
1159
1160 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1161
1162 * lread.c (readevalloop): Use correct code for NBSP.
1163 (read1): Likewise. (Bug#9608)
1164
1165 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
1166
1167 * dbusbind.c (Fdbus_register_signal): When service is not
1168 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1169
1170 2011-09-25 Glenn Morris <rgm@gnu.org>
1171
1172 * buffer.c (truncate-lines): Doc fix.
1173
1174 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
1175
1176 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1177 (Fset_window_next_buffers): Doc fix.
1178
1179 2011-09-24 Glenn Morris <rgm@gnu.org>
1180
1181 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1182
1183 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1184
1185 Fix minor problems found by static checking.
1186 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1187 * indent.c (Fvertical_motion): Fix == vs = typo.
1188
1189 2011-09-24 Eli Zaretskii <eliz@gnu.org>
1190
1191 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1192 Default value is now t. Doc fix.
1193
1194 * indent.c (Fvertical_motion): Compute and apply the overshoot
1195 logic when moving up, not only when moving down. Fix the
1196 confusing name and values of the it_overshoot_expected variable;
1197 logic changes accordingly. (Bug#9254) (Bug#9549)
1198
1199 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1200 CHARPOS is covered by a display string which includes newlines.
1201 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1202 is covered by a display string with embedded newlines.
1203
1204 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
1205
1206 * dbusbind.c (Fdbus_register_signal): Add match rule to
1207 Vdbus_registered_objects_table. (Bug#9581)
1208 (Fdbus_register_method, Vdbus_registered_objects_table):
1209 Fix docstring.
1210
1211 2011-09-24 Jim Meyering <meyering@redhat.com>
1212
1213 do not ignore write error for any output size
1214 The previous change was incomplete.
1215 While it makes emacs --batch detect the vast majority of stdout
1216 write failures, errors were still ignored whenever the output size is
1217 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1218 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1219 && echo FAIL: ignored write error
1220 FAIL: ignored write error
1221 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1222 && echo FAIL: ignored write error
1223 FAIL: ignored write error
1224 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1225
1226 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1227
1228 * emacs.c (Fkill_emacs): In noninteractive mode exit
1229 non-successfully if a write error occurred on stdout. (Bug#9574)
1230
1231 2011-09-21 Eli Zaretskii <eliz@gnu.org>
1232
1233 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1234 the xassert test.
1235
1236 * dispextern.h (struct it): Update the comment documenting what
1237 can it->OBJECT be.
1238
1239 2011-09-20 Eli Zaretskii <eliz@gnu.org>
1240
1241 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1242 a display string, extend search for cursor position to end of row.
1243 (find_row_edges): If the row ends in a newline from a display
1244 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1245 Handle the case of a display string with multiple newlines.
1246 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1247 non-empty line. Fixes confusing cursor motion with arrow keys at
1248 the beginning of a line that starts with whitespace.
1249
1250 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1251
1252 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1253 (bug#9493).
1254
1255 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
1256
1257 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1258 boolean (Bug#9154).
1259
1260 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1261
1262 * xdisp.c (display_line): Record maximum and minimum buffer
1263 positions even if no glyphs were produced (e.g., by a zero-width
1264 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1265 buffer positions that will be removed from the glyph row because
1266 they don't fit.
1267 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1268 column is beyond frame width: don't subtract 1 "pixel" when
1269 computing width of the stretch.
1270 (reseat_at_next_visible_line_start): Undo the change made on
1271 2011-09-17 that saved paragraph information and restored it after
1272 the call to `reseat'. (Bug#9545)
1273
1274 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1275
1276 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1277 and turn window cursor on if cleared (Bug#9415).
1278
1279 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
1280
1281 * search.c (boyer_moore): Take unibyte characters from pattern
1282 literally. (Bug#9458)
1283
1284 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1285
1286 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1287
1288 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1289
1290 Fix minor problem found by static checking.
1291 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1292 initialized, to pacify gcc -Wuninitialized.
1293
1294 * fileio.c: Report proper errno when syscall falls.
1295 (Finsert_file_contents): Save and restore errno,
1296 so that report_file_error outputs the correct diagnostic.
1297 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1298
1299 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1300
1301 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1302
1303 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1304
1305 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1306 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1307
1308 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1309
1310 * xdisp.c (reseat_at_next_visible_line_start): Keep information
1311 about the current paragraph and restore it after the call to reseat.
1312
1313 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1314 (bidi_find_paragraph_start): Search back for paragraph beginning
1315 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1316 (bidi_move_to_visually_next): Only trigger paragraph-related
1317 computations when the last character is a newline or at EOB, not
1318 just any NEUTRAL_B. (Bug#9470)
1319
1320 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1321 truncated lines if point is covered by a display string. (Bug#9524)
1322
1323 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1324
1325 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1326 (cons_to_x_long): New function.
1327 (lisp_data_to_selection_data): Use it. Correct the test for
1328 short-versus-long data; it was negated. Break out of vector
1329 loop, for efficiency, when a long datum is discovered.
1330
1331 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1332
1333 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1334
1335 2011-09-16 Eli Zaretskii <eliz@gnu.org>
1336
1337 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1338 GCC PR/17406) by declaring this function with external scope.
1339
1340 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1341
1342 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1343 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1344
1345 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1346
1347 * editfns.c (Fformat): Correctly handle text properties on "%%".
1348
1349 2011-09-15 Eli Zaretskii <eliz@gnu.org>
1350
1351 * xterm.c (x_draw_composite_glyph_string_foreground):
1352 * w32term.c (x_draw_composite_glyph_string_foreground):
1353 * term.c (encode_terminal_code):
1354 * composite.c (composition_update_it, get_composition_id):
1355 * xdisp.c (get_next_display_element)
1356 (fill_composite_glyph_string): Add comments about special meaning
1357 of TAB characters in a composition.
1358
1359 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1360
1361 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
1362 This occurs when processing a multibyte format.
1363 Problem reported by Wolfgang Jenker.
1364
1365 2011-09-15 Johan Bockgård <bojohan@gnu.org>
1366
1367 * xdisp.c (try_cursor_movement): Only check for exact match if
1368 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1369
1370 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1371
1372 Remove unused external symbols.
1373 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1374 * xdisp.c (calc_pixel_width_or_height): Now static.
1375 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1376 * indent.c (check_display_width):
1377 * w32term.c: Fix comment to match code.
1378 * xterm.c, xterm.h (x_catching_errors): Remove.
1379
1380 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1381
1382 * xselect.c: Use signed conversions more consistently (Bug#9498).
1383 (selection_data_to_lisp_data): Assume incoming selection data are
1384 signed integers, not unsigned. This is to be consistent with
1385 outgoing selection data, which was modified to use signed integers
1386 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1387 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1388 expects long, not unsigned long.
1389
1390 2011-09-14 Eli Zaretskii <eliz@gnu.org>
1391
1392 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1393 computation of loop end. Reported by Johan Bockgård
1394 <bojohan@gnu.org>.
1395
1396 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
1397
1398 * frame.c (Fother_visible_frames_p): Function deleted.
1399
1400 2011-09-12 Eli Zaretskii <eliz@gnu.org>
1401
1402 * indent.c (compute_motion): Process display vector front to back
1403 rather than the other way around. (Bug#2496)
1404
1405 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1406
1407 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1408
1409 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
1410
1411 * minibuf.c (Fread_from_minibuffer): Doc fix.
1412
1413 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1414
1415 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1416 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1417
1418 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1419
1420 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1421 value for non-existent files.
1422
1423 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1424
1425 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1426 set its "size" to -1. This will set the modtime_size field of
1427 the corresponding buffer to -1, which is what
1428 verify-visited-file-modtime expects for files that do not exist.
1429 (Bug#9139)
1430
1431 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1432
1433 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1434 here ...
1435 * lisp.h: ... from here. push_key_description is no longer
1436 defined in keyboard.c, so its declaration should not be in
1437 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1438 logically belongs with push_key_description.
1439
1440 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1441
1442 * buffer.h: Include <sys/types.h> instead of <time.h>.
1443 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1444 Problem reported by Herbert J. Skuhra.
1445
1446 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1447
1448 * xml.c (parse_region): Make the parsing work for
1449 non-comment-starting XML files again (bug#9144).
1450
1451 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1452
1453 * image.c (gif_load): Fix calculation of bottom and right corner.
1454 (Bug#9468)
1455
1456 2011-09-10 Eli Zaretskii <eliz@gnu.org>
1457
1458 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1459 redisplay in small windows.
1460
1461 2011-09-09 Eli Zaretskii <eliz@gnu.org>
1462
1463 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1464
1465 2011-09-08 Martin Rudalics <rudalics@gmx.at>
1466
1467 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1468 Operate on live windows only.
1469
1470 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
1471
1472 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1473
1474 2011-09-07 Eli Zaretskii <eliz@gnu.org>
1475
1476 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1477 only under bidi iteration.
1478
1479 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1480
1481 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1482
1483 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1484
1485 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1486 Without this fix, the command to link temacs failed due to an
1487 undefined symbol __builtin_isnan. This is because
1488 /usr/include/iso/math_c99.h #defines isnan(x) to
1489 __builtin_isnan(x), but the bundled gcc, which identifies itself
1490 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1491 a __builtin_isnan.
1492 * floatfns.c (isnan): #undef, and then #define to a clone of
1493 what's in data.c.
1494 (Fisnan): Always define, since it's always available now.
1495 (syms_of_floatfns): Always define isnan at the Lisp level.
1496
1497 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1498
1499 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1500
1501 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1502
1503 * fileio.c: Fix bugs with large file offsets (Bug#9428).
1504 The previous code assumed that file offsets (off_t values) fit in
1505 EMACS_INT variables, which is not true on typical 32-bit hosts.
1506 The code messed up by falsely reporting buffer overflow in cases
1507 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1508 when "big" contains more than 2**29 bytes, even though this
1509 inserts just one byte and does not overflow the buffer.
1510 (Finsert_file_contents): Store file offsets as off_t
1511 values, not as EMACS_INT values. Check for overflow when
1512 converting between EMACS_INT and off_t. When checking for
1513 buffer overflow or for overlap, take the offsets into account.
1514 Don't use EMACS_INT for small values where int suffices.
1515 When checking for overlap, fix a typo: ZV was used where
1516 ZV_BYTE was intended.
1517 (Fwrite_region): Don't assume off_t fits into 'long'.
1518 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1519
1520 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
1521
1522 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1523
1524 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1525
1526 sprintf-related integer and memory overflow issues (Bug#9412).
1527
1528 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
1529 (esprintf, exprintf, evxprintf): New functions.
1530 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
1531 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
1532 (modify_event_symbol): Do not assume that the length of
1533 name_alist_or_stem is safe to alloca and fits in int.
1534 (Fexecute_extended_command): Likewise for function name and binding.
1535 (Frecursion_depth): Wrap around reliably on integer overflow.
1536 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1537 since some callers pass EMACS_INT values.
1538 (Fsingle_key_description): Don't crash if symbol name contains more
1539 than MAX_ALLOCA bytes.
1540 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1541 (get_minibuffer): Arg is now EMACS_INT, not int.
1542 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
1543 (esprintf, exprintf, evxprintf): New decls.
1544 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1545
1546 * dbusbind.c (signature_cat): New function.
1547 (xd_signature, Fdbus_register_signal):
1548 Do not overrun buffer; instead, report string overflow.
1549
1550 * dispnew.c (add_window_display_history): Don't overrun buffer.
1551 Truncate instead; this is OK since it's just a log.
1552
1553 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1554 even if the time zone offset is outlandishly large.
1555 Don't mishandle offset == INT_MIN.
1556
1557 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1558 when creating daemon; the previous buffer-overflow check was incorrect.
1559
1560 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1561 which has the guts of the old verror function.
1562
1563 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1564 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1565
1566 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1567 (font_unparse_xlfd): Don't blindly alloca long strings.
1568 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
1569 fits in int, when using sprintf. Use single snprintf to count
1570 length of string rather than counting it via multiple sprintfs;
1571 that's simpler and more reliable.
1572 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1573 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1574 sprintf, in case result does not fit in int.
1575
1576 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1577 (fontset_from_font): Print it.
1578
1579 * frame.c (tty_frame_count): Now printmax_t, not int.
1580 (make_terminal_frame, set_term_frame_name): Print it.
1581 (x_report_frame_params): In X, window IDs are unsigned long,
1582 not signed long, so print them as unsigned.
1583 (validate_x_resource_name): Check for implausibly long names,
1584 and don't assume name length fits in 'int'.
1585 (x_get_resource_string): Don't blindly alloca invocation name;
1586 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1587 not fit in int.
1588
1589 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1590 (xg_check_special_colors, xg_set_geometry):
1591 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1592
1593 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1594 Use esprintf, not sprintf, in case result does not fit in int.
1595
1596 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1597 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1598 it as a large positive number.
1599 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1600 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1601
1602 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1603 in case result does not fit in int.
1604
1605 * print.c (float_to_string): Detect width overflow more reliably.
1606 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1607 buffer overrun. Don't assume list length fits in 'int'. Treat
1608 print length of 0 as 0, not as infinity; to be consistent with other
1609 uses of print length in this function. Don't overflow print length
1610 index. Don't assume hash table size fits in 'long', or that
1611 vectorlike size fits in 'unsigned long'.
1612
1613 * process.c (make_process): Use printmax_t, not int, to format
1614 process-name gensyms.
1615
1616 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1617
1618 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1619 to avoid potential buffer overrun.
1620
1621 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1622 if X resource line is longer than 512 bytes.
1623
1624 * xfns.c (x_window): Make sprintf buffer a bit bigger
1625 to avoid potential buffer overrun.
1626
1627 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1628
1629 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1630
1631 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1632
1633 Integer overflow fixes for scrolling, etc.
1634 Without these, Emacs silently mishandles large integers sometimes.
1635 For example, "C-u 4294967297 M-x recenter" was treated as if
1636 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1637
1638 * xdisp.c (try_window_id): Check Emacs fixnum range before
1639 converting to 'int'.
1640
1641 * window.c (window_scroll_line_based, Frecenter):
1642 Check that an Emacs fixnum is in range before assigning it to 'int'.
1643 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1644 values converted from Emacs fixnums.
1645 (Frecenter): Don't wrap around a line count if it is out of 'int'
1646 range; instead, treat it as an extreme value.
1647 (Fset_window_configuration, compare_window_configurations):
1648 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1649
1650 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1651 that can exceed INT_MAX. Check that EMACS_INT value is in range
1652 before assigning it to the (possibly-narrower) index.
1653 (match_limit): Don't assume that a fixnum can fit in 'int'.
1654
1655 * print.c (print_object): Use ptrdiff_t, not int, for index that can
1656 exceed INT_MAX.
1657
1658 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
1659 (Fvertical_motion): Don't wrap around LINES values that don't fit
1660 in 'int'. Instead, treat them as extreme values. This is good
1661 enough for windows, which can't have more than INT_MAX lines anyway.
1662
1663 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1664
1665 * Require libxml/parser.h to avoid compilation warning.
1666
1667 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1668
1669 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1670 since this reportedly can destroy thread storage.
1671
1672 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
1673
1674 * syntax.c (find_defun_start): Update all cache variables if
1675 exiting early (Bug#9401).
1676
1677 2011-08-30 Eli Zaretskii <eliz@gnu.org>
1678
1679 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1680
1681 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1682 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1683 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1684
1685 * term.c (tty_append_glyph): New function.
1686 (produce_stretch_glyph): Static function and its prototype deleted.
1687
1688 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1689 Add prototypes.
1690
1691 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1692
1693 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1694 when checking :margin (Bug#9390).
1695 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
1696 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
1697 so that the name doesn't mislead. All uses changed.
1698
1699 2011-08-28 Johan Bockgård <bojohan@gnu.org>
1700
1701 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1702 set_tty_hooks.
1703
1704 2011-08-27 Eli Zaretskii <eliz@gnu.org>
1705
1706 * xdisp.c (move_it_to): Don't bail out early when reaching
1707 position beyond to_charpos, if we are scanning backwards.
1708 (move_it_vertically_backward): When DY == 0, make sure we get to
1709 the first character in the line after the newline.
1710
1711 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1712
1713 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1714 (ccl_driver): Do not generate an out-of-range pointer.
1715 (Fccl_execute_on_string): Remove unnecessary check for
1716 integer overflow, noted by Stefan Monnier in
1717 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1718 Remove a FIXME that didn't need fixing.
1719 Simplify the newly-introduced buffer reallocation code.
1720
1721 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
1722
1723 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1724
1725 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
1726
1727 Integer and memory overflow issues (Bug#9196).
1728
1729 * doc.c (get_doc_string): Rework so that
1730 get_doc_string_buffer_size is the actual buffer size, rather than
1731 being 1 less than the actual buffer size; this makes xpalloc more
1732 convenient.
1733
1734 * image.c (x_allocate_bitmap_record, cache_image):
1735 * xselect.c (Fx_register_dnd_atom):
1736 Simplify previous changes by using xpalloc.
1737
1738 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1739 since either will do and ptrdiff_t is convenient with xpalloc.
1740
1741 * charset.c (charset_table_size)
1742 (struct charset_sort_data.priority): Now ptrdiff_t.
1743 (charset_compare): Don't overflow if priorities differ greatly.
1744 (Fsort_charsets): Don't assume list length fits in int.
1745 Check for size-calculation overflow when allocating sort data.
1746 (syms_of_charset): Allocate an initial charset table that is
1747 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1748
1749 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1750
1751 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1752 The actual value is always <= INT_MAX, and leaving it unsigned made
1753 overflow checking harder.
1754
1755 * dispextern.h (struct glyph_matrix.rows_allocated)
1756 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1757 with xpalloc. The values are still always <= INT_MAX.
1758
1759 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1760
1761 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1762 (SAFE_NALLOCA): New macro.
1763
1764 * region-cache.c (struct boundary.pos, find_cache_boundary)
1765 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1766 (set_cache_region, invalidate_region_cache)
1767 (revalidate_region_cache, know_region_cache, region_cache_forward)
1768 (region_cache_backward, pp_cache):
1769 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1770 so that ptrdiff_t * can be passed to xpalloc.
1771 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1772 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1773 (pp_cache): Don't assume cache_len fits in int.
1774 * region-cache.h: Adjust extern decls to match.
1775
1776 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1777 EMACS_INT, since either will do, for xpalloc.
1778
1779 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1780 (xnmalloc, xnrealloc, xpalloc): New functions.
1781
1782 * bidi.c (bidi_shelve_header_size): New constant.
1783 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1784 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1785
1786 * bidi.c (bidi_cache_shrink):
1787 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1788 (overlay_strings):
1789 Don't update size of array until after memory allocation succeeds,
1790 because xmalloc/xrealloc may not return.
1791 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1792 now that we have proper integer overflow checking.
1793 (record_overlay_string, overlay_strings): Catch overflows when
1794 calculating size of overlay_str_buf.
1795
1796 * callproc.c (Fcall_process): Check for size overflow when
1797 calculating size of args2.
1798 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1799 Normally we prefer signed values, but sticking with ptrdiff_t would
1800 require adding more-complicated checks.
1801
1802 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1803 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1804 Redo buffer-overflow calculations to avoid integer overflow.
1805 Add a FIXME comment where memory seems to be over-allocated.
1806
1807 * character.c (Fstring): Check for size-calculation overflow.
1808
1809 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1810 unnecessary integer overflow. Check for size overflow.
1811 (encode_coding_object): Don't update size until xmalloc succeeds.
1812
1813 * composite.c (get_composition_id): Check for overflow in glyph
1814 length calculations.
1815
1816 Integer and memory overflow fixes for display code.
1817 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1818 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1819 (scrolling_window): Check for overflow in size calculations.
1820 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1821 Don't assume glyph table len fits in int.
1822 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1823 (row_table_size): Now ptrdiff_t, not int.
1824 (scrolling_window): Avoid overflow in size calculations.
1825 Don't update size until allocation succeeds.
1826 * fns.c (concat): Check for overflow in size calculations.
1827 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1828 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1829 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1830
1831 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1832 (get_doc_string): Check for size calculation overflow.
1833 Don't update size until allocation succeeds.
1834 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1835 EMACS_INT, where ptrdiff_t will do.
1836 (Fsubstitute_command_keys): Check for string overflow.
1837
1838 * editfns.c (set_time_zone_rule): Don't assume environment length
1839 fits in int.
1840 (message_length): Now ptrdiff_t, not int.
1841 (Fmessage_box): Don't update size until allocation succeeds.
1842 Don't assume message length fits in int.
1843 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1844
1845 * emacs.c (main): Do not reallocate argv, since there is a null at
1846 the end that can be overwritten, and this way there's no need to
1847 worry about size-calculation overflow.
1848 (sort_args): Check for size-calculation overflow.
1849
1850 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1851 alloc succeeds.
1852 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1853
1854 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1855 (x_set_scroll_bar_width, x_figure_window_size):
1856 Check for integer overflow.
1857 (x_set_alpha): Do not assume XINT fits in int.
1858
1859 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1860 This is for the members text_lines, text_cols, total_lines, total_cols,
1861 where the system imposes an 'int' limit.
1862
1863 * fringe.c (Fdefine_fringe_bitmap):
1864 Don't update size until alloc works.
1865
1866 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1867 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1868
1869 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1870 Check for size-calculation overflow.
1871 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1872 do, as we prefer signed integers.
1873 (id_to_widget.max_size, id_to_widget.used)
1874 (xg_store_widget_in_map, xg_remove_widget_from_map)
1875 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1876 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1877 Use and return ptrdiff_t, not int.
1878 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1879 * gtkutil.h: Change prototypes to match the above.
1880
1881 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1882 are duplicate now that they've been promoted to lisp.h.
1883 (x_allocate_bitmap_record, x_alloc_image_color)
1884 (make_image_cache, cache_image, xpm_load):
1885 Don't update size until alloc is done.
1886 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1887 (x_detect_edges):
1888 Check for size calculation overflow.
1889 (ct_colors_allocated_max): New constant.
1890 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1891 overflow.
1892
1893 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1894 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1895 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1896 Use ptrdiff_t, not int, to count maps.
1897 (read_char_minibuf_menu_prompt): Check for overflow in size
1898 calculations. Don't update size until allocation succeeds.
1899 Redo calculations to avoid overflow.
1900 * keyboard.h: Change prototypes to match the above.
1901
1902 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1903 to count maps.
1904 (current_minor_maps): Check for size calculation overflow.
1905 * keymap.h: Change prototypes to match the above.
1906
1907 * lread.c (read1, init_obarray): Don't update size until alloc done.
1908
1909 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1910 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1911
1912 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1913 Now ptrdiff_t, not int.
1914 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1915 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1916
1917 * process.c (Fnetwork_interface_list): Check for overflow
1918 in size calculation.
1919
1920 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1921
1922 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1923 overflow. Don't bother calling xmalloc when xrealloc will do.
1924
1925 * search.c (Freplace_match): Check for size calculation overflow.
1926 (Fset_match_data): Don't assume list lengths fit in 'int'.
1927
1928 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1929 for command line length. Do not attempt to address one before the
1930 beginning of an array, as that's not portable.
1931
1932 * term.c (max_frame_lines): Remove; unused.
1933 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1934 not int.
1935 (encode_terminal_code, calculate_costs): Check for size
1936 calculation overflow.
1937 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1938 table lengths and related sizes. Don't update size until alloc
1939 done. Redo calculations to avoid overflow.
1940 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1941
1942 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1943 subtracting pointers.
1944 (gobble_line): Check for overflow more carefully. Don't update size
1945 until alloc done.
1946
1947 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1948 Don't update size until alloc done.
1949 Redo size calculations to avoid overflow.
1950 Check for size calculation overflow.
1951 (main) [DEBUG]: Fix typo in invoking tparam1.
1952
1953 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1954 Use ptrdiff_t, not int, for sizes.
1955 (store_mode_line_noprop_char): Don't update size until alloc done.
1956
1957 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1958 Use ptrdiff_t, not int, for sizes.
1959 (Finternal_make_lisp_face, cache_face):
1960 Check for size calculation overflow.
1961 (cache_face): Treat size calculation overflows as if they were
1962 memory exhaustion (the usual treatment), rather than aborting.
1963
1964 * xfns.c (x_encode_text, x_set_name_internal)
1965 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1966 sizes, since they can exceed INT_MAX in size. Check for size
1967 calculation overflow.
1968
1969 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1970 (xg_select): Check for size calculation overflow.
1971 Don't update size until alloc done.
1972
1973 * xrdb.c (get_environ_db): Don't assume path length fits in int,
1974 as sprintf is limited to int lengths.
1975
1976 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1977 (X_LONG_MIN): New macros.
1978 Use them to make the following changes clearer.
1979 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1980 This change doesn't affect the value now, but it may help remind
1981 future maintainers not to raise the value too much later.
1982 (SELECTION_QUANTUM): Remove, replacing with ...
1983 (selection_quantum): ... new function, which avoids overflow.
1984 All uses changed.
1985 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1986 assumption that selection length fits in 'int'.
1987 (x_reply_selection_request, x_handle_selection_request)
1988 (x_get_window_property, receive_incremental_selection)
1989 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1990 (lisp_data_to_selection_data, clean_local_selection_data):
1991 Use ptrdiff_t, not int, to record length of selection.
1992 (x_reply_selection_request, x_get_window_property)
1993 (receive_incremental_selection, x_property_data_to_lisp):
1994 Redo calculations to avoid overflow.
1995 (x_reply_selection_request): When sending hint, ceiling it at
1996 X_LONG_MAX rather than relying on wraparound overflow to send
1997 something.
1998 (x_get_window_property, receive_incremental_selection)
1999 (lisp_data_to_selection_data, x_property_data_to_lisp):
2000 Check for size-calculation overflow.
2001 (x_get_window_property, receive_incremental_selection)
2002 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2003 Don't store size until memory allocation succeeds.
2004 (x_get_window_property): Plug memory leak on memory exhaustion.
2005 Don't double-block input; malloc is safe here. Don't assume 2**34
2006 - 4 fits in unsigned long. Add an xassert to check
2007 XGetWindowProperty overflow. Be more careful about overflow
2008 calculations, and distinguish size from memory overflow better.
2009 (receive_incremental_selection): When tracing, don't assume
2010 unsigned int is less than INT_MAX.
2011 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2012 harmful) conversions of unsigned short to int.
2013 (lisp_data_to_selection_data): Don't assume that integers
2014 in the range -65535 through -1 fit in an X unsigned short.
2015 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2016 result parameters unless successful. Rely on cons_to_unsigned
2017 to report problems with elements; the old code wasn't right anyway.
2018 (x_check_property_data): Check for int overflow; we cannot use
2019 a wider type due to X limits.
2020 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2021
2022 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2023
2024 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2025 (x_term_init): Check for size calculation overflow.
2026 (x_color_cells): Don't store size until memory allocation succeeds.
2027 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2028 Don't assume alloca size is less than MAX_ALLOCA.
2029 (x_term_init): Don't assume length fits in int (sprintf is limited
2030 to int size).
2031
2032 Use ptrdiff_t for composition IDs.
2033 * character.c (lisp_string_width):
2034 * composite.c (composition_table_size, n_compositions)
2035 (get_composition_id, composition_gstring_from_id):
2036 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2037 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2038 * window.c (Frecenter):
2039 Use ptrdiff_t, not int, for composition IDs.
2040 * composite.c (get_composition_id): Check for integer overflow.
2041 * composite.h: Adjust prototypes to match the above changes.
2042
2043 Use ptrdiff_t for hash table indexes.
2044 * category.c (hash_get_category_set):
2045 * ccl.c (ccl_driver):
2046 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2047 * coding.c (coding_system_charset_list, detect_coding_system):
2048 * coding.h (struct coding_system.id):
2049 * composite.c (get_composition_id, gstring_lookup_cache):
2050 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2051 * image.c (xpm_get_color_table_h):
2052 * lisp.h (hash_lookup, hash_put):
2053 * minibuf.c (Ftest_completion):
2054 Use ptrdiff_t for hash table indexes, not int (which is too
2055 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2056 32-bit --with-wide-int hosts).
2057
2058 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2059 Add a FIXME comment about memory leaks.
2060 (syms_of_charset): Don't assume xmalloc returns.
2061
2062 Don't assume that stated character widths fit in int.
2063 * character.c (Fchar_width, c_string_width, lisp_string_width):
2064 * character.h (CHAR_WIDTH):
2065 * indent.c (MULTIBYTE_BYTES_WIDTH):
2066 Use sanitize_char_width to avoid undefined and/or bad behavior
2067 with outlandish widths.
2068 * character.h (sanitize_tab_width): Rename from sanitize_width,
2069 now that we have two such functions. All uses changed.
2070 (sanitize_char_width): New inline function.
2071
2072 Don't assume that tab-width fits in int.
2073 * character.h (sanitize_width): New inline function.
2074 (SANE_TAB_WIDTH): New macro.
2075 (ASCII_CHAR_WIDTH): Use it.
2076 * indent.c (sane_tab_width): Remove. All uses replaced by
2077 SANE_TAB_WIDTH (current_buffer).
2078 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2079
2080 * fileio.c: Integer overflow issues with file modes.
2081 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2082
2083 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2084 Remove unreachable code.
2085 (read_hex, load_charset_map_from_file): Check for integer overflow.
2086
2087 * xterm.c: don't go over XClientMessageEvent limit
2088 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2089 (x_send_scroll_bar_event): Likewise. Check that the size does not
2090 exceed limits imposed by XClientMessageEvent, as well as the usual
2091 ptrdiff_t and size_t limits.
2092
2093 * keyboard.c: Overflow, signedness and related fixes.
2094 (make_lispy_movement): Use same integer type in forward decl
2095 that is used in the definition.
2096 (read_key_sequence, keyremap_step):
2097 Change bufsize argument back to int, undoing my 2011-03-30 change.
2098 We prefer signed types, and int is wide enough here.
2099 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2100 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2101 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2102 length, not size_t. Use ptrdiff_t for index, not int.
2103 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2104 possibility of integer overflow.
2105
2106 Overflow, signedness and related fixes for images.
2107
2108 * dispextern.h (struct it.stack[0].u.image.image_id)
2109 (struct_it.image_id, struct image.id, struct image_cache.size)
2110 (struct image_cache.used, struct image_cache.ref_count):
2111 * gtkutil.c (update_frame_tool_bar):
2112 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2113 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2114 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2115 * nsmenu.m (update_frame_tool_bar):
2116 * xdisp.c (calc_pixel_width_or_height):
2117 * xfns.c (image_cache_refcount):
2118 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2119 on typical 64-bit hosts.
2120
2121 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2122 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2123 Omit unnecessary casts to int.
2124 (parse_image_spec): Check that integers fall into 'int' range
2125 when the callers expect that.
2126 (image_ascent): Redo ascent calculation to avoid int overflow.
2127 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2128 (lookup_image): Remove unnecessary tests.
2129 (xbm_image_p): Locals are now of int, not EMACS_INT,
2130 since parse_image_check makes sure they fit into int.
2131 (png_load, gif_load, svg_load_image):
2132 Prefer int to unsigned where either will do.
2133 (tiff_handler): New function, combining the cores of the
2134 old tiff_error_handler and tiff_warning_handler.
2135 This function is rewritten to use vsnprintf and thereby avoid
2136 stack buffer overflows. It uses only the features of vsnprintf
2137 that are common to both POSIX and native Microsoft.
2138 (tiff_error_handler, tiff_warning_handler): Use it.
2139 (tiff_load, gif_load, imagemagick_load_image):
2140 Don't assume :index value fits in 'int'.
2141 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2142 (imagemagick_load_image): Check that crop parameters fit into
2143 the integer types that MagickCropImage accepts. Don't assume
2144 Vimagemagick_render_type has a nonnegative value. Don't assume
2145 size_t fits in 'long'.
2146 (gs_load): Use printmax_t to print the widest integers possible.
2147 Check for integer overflow when computing image height and width.
2148
2149 2011-08-26 Eli Zaretskii <eliz@gnu.org>
2150
2151 * xdisp.c (redisplay_window): Don't force window start if point
2152 will be invisible in the resulting window. (Bug#9324)
2153
2154 2011-08-25 Eli Zaretskii <eliz@gnu.org>
2155
2156 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2157 the display spec is of the form `(space ...)'.
2158 (handle_display_spec): Return the value returned by
2159 handle_single_display_spec, not just 1 or zero.
2160 (handle_single_display_spec): If the display spec is of the form
2161 `(space ...)', and specifies display in the text area, return 2
2162 rather than 1.
2163 (try_cursor_movement): Check for the need to scroll more
2164 accurately, and prefer exact match for point under bidi.
2165 Don't advance `row' beyond the last row of the window.
2166
2167 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2168 into disp_prop; all users changed.
2169
2170 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2171 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2172 for the text covered by the display property.
2173
2174 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
2175
2176 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2177 Change return value to nil.
2178 (Frecord_buffer): Delete unused function.
2179
2180 2011-08-24 Eli Zaretskii <eliz@gnu.org>
2181
2182 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2183 buffers, return left-to-right.
2184 (set_cursor_from_row): Consider candidate row a win if its glyph
2185 represents a newline and point is on that newline. Fixes cursor
2186 positioning on the newline at EOL of R2L text within L2R
2187 paragraph, and vice versa.
2188 (try_cursor_movement): Check continued rows, in addition to
2189 continuation rows. Fixes unwarranted scroll when point enters a
2190 continued line of R2L text within an L2R paragraph, or vice versa.
2191 (cursor_row_p): Consider the case of point being equal to
2192 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2193 from the end of a short line to the beginning of a continued line
2194 of R2L text within L2R paragraph.
2195 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2196 composed characters.
2197
2198 * bidi.c (bidi_check_type): Use xassert.
2199 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2200 members.
2201
2202 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2203
2204 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2205 a character.
2206
2207 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
2208
2209 * nsfont.m (ns_otf_to_script): Fix typo.
2210
2211 2011-08-22 Kenichi Handa <handa@m17n.org>
2212
2213 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2214 extra slot even if the purpose is char-code-property-table.
2215
2216 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2217
2218 * xdisp.c (redisplay_window): When computing centering_position,
2219 account for the height of the header line. (Bug#8874)
2220
2221 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2222 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2223 candidate is selected by the mouse, and that candidate has a
2224 composed character under the mouse.
2225
2226 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2227 coordinates reported by pos-visible-in-window-p for a composed
2228 character in column zero.
2229
2230 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2231
2232 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2233
2234 2011-08-22 Eli Zaretskii <eliz@gnu.org>
2235
2236 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2237 consider it a hit if to_charpos is anywhere in the range of the
2238 composed buffer positions.
2239
2240 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
2241
2242 * image.c (gif_load): Don't assume that each subimage has the same
2243 dimensions as the base image. Handle disposal method that is
2244 "undefined" by the gif spec (Bug#9335).
2245
2246 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
2247
2248 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
2249 (Fcondition_case): Document `debug' symbol in error handler.
2250
2251 2011-08-19 Eli Zaretskii <eliz@gnu.org>
2252
2253 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2254 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2255 from an Org mode buffer to a Speedbar frame.
2256
2257 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2258 a composition, take its buffer position from IT->cmp_it.charpos.
2259 Fixes cursor positioning at the beginning of a line that begins
2260 with a composed character.
2261
2262 2011-08-18 Eli Zaretskii <eliz@gnu.org>
2263
2264 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2265 character bidirectional type, use STRONG_L instead. Fixes crashes
2266 in a buffer produced by `describe-categories'.
2267
2268 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2269 members before the level stack, so they would be saved and
2270 restored when copying iterator state. Fixes incorrect reordering
2271 around TABs covered by display properties.
2272
2273 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2274
2275 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
2276
2277 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
2278
2279 * eval.c (internal_condition_case, internal_condition_case_1)
2280 (internal_condition_case_2, internal_condition_case_n):
2281 Remove unnecessary aborts (Bug#9081).
2282
2283 2011-08-17 Eli Zaretskii <eliz@gnu.org>
2284
2285 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2286 has no `load' handler, try opening the file locally. (Bug#9311)
2287
2288 2011-08-16 Ken Brown <kbrown@cornell.edu>
2289
2290 * gmalloc.c: Expand comment.
2291
2292 2011-08-16 Eli Zaretskii <eliz@gnu.org>
2293
2294 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2295 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2296
2297 2011-08-16 Ken Brown <kbrown@cornell.edu>
2298
2299 Fix memory allocation problems in Cygwin build (Bug#9273).
2300
2301 * unexcw.c ( __malloc_initialized): Declare external variable.
2302 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2303
2304 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2305 New variables.
2306 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2307 dumped emacs.
2308 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2309 in the static heap.
2310 [CYGWIN] (special_realloc): New function.
2311 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2312 requests to realloc storage in the static heap.
2313
2314 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2315
2316 * bidi.c (bidi_initialize): Remove unused local.
2317
2318 2011-08-15 Eli Zaretskii <eliz@gnu.org>
2319
2320 * bidimirror.h:
2321 * biditype.h: Remove file.
2322 * makefile.w32-in ($(BLD)/bidi.$(O)):
2323 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
2324
2325 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2326
2327 * chartab.c: Improve commentary for the uniprop_table API.
2328
2329 * bidi.c (bidi_paragraph_init): Support zero value of
2330 bidi_ignore_explicit_marks_for_paragraph_level.
2331 (bidi_initialize): Use uniprop_table instead of including
2332 biditype.h and bidimirror.h.
2333
2334 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2335 coordinates of the iterator when restoring from ppos_it.
2336 (Bug#9296)
2337
2338 2011-08-14 Kenichi Handa <handa@m17n.org>
2339
2340 * process.c (create_process): Call setup_process_coding_systems
2341 after the pid of the process is set to -1 (Bug#8162).
2342
2343 2011-08-14 Eli Zaretskii <eliz@gnu.org>
2344
2345 * xdisp.c (move_it_in_display_line_to): Don't invoke
2346 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2347 ppos_it. Fixes vertical cursor motion when line beginning is
2348 covered by an image. (Bug#9296)
2349
2350 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2351
2352 * nsterm.h (ns_run_ascript): Declare.
2353 (NSAPP_DATA2_RUNASSCRIPT): Define.
2354
2355 * nsfns.m (as_script, as_result, as_status): New static variables.
2356 (ns_run_ascript): New function.
2357 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
2358 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2359 the event loop. Get status from as_status (Bug#7276).
2360
2361 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2362 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2363 the event loop (Bug#7276).
2364
2365 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2366
2367 * gnutls.c (QCgnutls_bootprop_priority)
2368 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2369 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2370 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2371 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2372 (QCgnutls_bootprop_verify_hostname_error)
2373 (QCgnutls_bootprop_callbacks_verify): Rename from
2374 Qgnutls_bootprop_..., all uses changed.
2375
2376 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2377 uses changed.
2378
2379 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2380
2381 * xfaces.c (Qframe_set_background_mode): Now static.
2382 * dispextern.h (Qframe_set_background_mode): Remove decl.
2383
2384 * process.c (Fnetwork_interface_info): Declare local only if needed.
2385
2386 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2387
2388 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2389 (Fnetwork_interface_list): Allocate in increments of bytes instead
2390 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2391 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2392 sockaddr.
2393 (struct ifflag_def): notrailers is smart on OSX.
2394 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2395 Get hardware address with getifaddrs if available.
2396
2397 2011-08-12 Eli Zaretskii <eliz@gnu.org>
2398
2399 * xdisp.c (iterate_out_of_display_property): xassert that
2400 IT->position is set to within IT->object's boundaries. Break from
2401 the loop as soon as EOB is reached; avoids infloops in redisplay
2402 when IT->position is set up wrongly due to some bug.
2403 Set IT->current to match the bidi iterator unconditionally.
2404 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2405 entry. Force push_it to save on the stack the current
2406 buffer/string position, to be restored by pop_it. Fix flags in
2407 the iterator structure wrt the object coming from a display
2408 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2409 properties. (Bug#9284)
2410
2411 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
2412
2413 * fontset.c (fontset_get_font_group): Add proper type checks.
2414 (Bug#9172)
2415
2416 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2417
2418 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2419 and LC_VERSION_MIN_MACOSX.
2420 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2421 (dump_it) [LC_FUNCTION_STARTS]: Use it.
2422
2423 2011-08-08 Eli Zaretskii <eliz@gnu.org>
2424
2425 * xdisp.c (forward_to_next_line_start): Allow to use the
2426 no-display-properties-and-no-overlays under bidi display.
2427 Set disp_pos in the bidi iterator to avoid searches for display
2428 properties and overlays.
2429
2430 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
2431
2432 * editfns.c (Fset_time_zone_rule): Document relationship with the
2433 setenv function.
2434
2435 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2436 the font entity extracted from the cache (Bug#8109).
2437
2438 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
2439
2440 * composite.c (autocmp_chars): Don't reset point. That is done by
2441 restore_point_unwind (Bug#5984).
2442
2443 2011-08-07 Juri Linkov <juri@jurta.org>
2444
2445 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2446 to show the arg `TIME' instead of `TIMEVAL'.
2447
2448 2011-08-06 Eli Zaretskii <eliz@gnu.org>
2449
2450 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2451 display property strides EOL and includes a newline, as in
2452 longlines-mode. (Bug#9254)
2453 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2454 word-wrap under bidirectional display. (Bug#9224)
2455
2456 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2457 is non-zero, even if the data buffer is NULL. Fixes a crash in
2458 vertical-motion with longlines-mode. (Bug#9254)
2459
2460 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2461
2462 * bidi.c <bidi_cache_total_alloc>: Now static.
2463 (bidi_initialize): Initialize bidi_cache_total_alloc.
2464
2465 * xdisp.c (display_line): Release buffer allocated for shelved bidi
2466 cache. (Bug#9221)
2467
2468 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2469 amount allocated this far in `bidi_cache_total_alloc'.
2470 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2471 non-zero, only free the data buffer without restoring the cache
2472 contents. All callers changed.
2473
2474 * dispextern.h (bidi_unshelve_cache): Update prototype.
2475
2476 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2477 (move_it_in_display_line, move_it_to)
2478 (move_it_vertically_backward, move_it_by_lines): Replace the call
2479 to xfree to an equivalent call to bidi_unshelve_cache.
2480 (move_it_in_display_line_to): Fix logic of returning
2481 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
2482
2483 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2484
2485 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2486 came from a string character with a `cursor' property. (Bug#9229)
2487
2488 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2489
2490 * Makefile.in (LIB_PTHREAD): New variable.
2491 (LIBES): Add LIB_PTHREAD (Bug#9216).
2492
2493 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2494 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2495
2496 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2497
2498 * regex.c (re_iswctype): Remove some redundant boolean conversions.
2499
2500 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2501
2502 * xterm.c (x_find_topmost_parent): New function.
2503 (x_set_frame_alpha): Find topmost parent window with
2504 x_find_topmost_parent and set the property there also (bug#9181).
2505 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2506
2507 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2508
2509 * callproc.c (Fcall_process): Avoid vfork clobbering
2510 the local vars buffer, coding_systems, current_dir.
2511
2512 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2513
2514 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2515
2516 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2517
2518 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2519 so that it is not optimized away.
2520
2521 * xdisp.c (compute_display_string_pos): Remove unused local.
2522
2523 2011-08-02 Eli Zaretskii <eliz@gnu.org>
2524
2525 Fix slow cursor motion and scrolling in large buffers with
2526 selective display, like Org Mode buffers. (Bug#9218)
2527
2528 * dispextern.h (struct bidi_it): New member disp_prop_p.
2529
2530 * xdisp.c: Remove one-slot cache of display string positions.
2531 (compute_display_string_pos): Accept an additional argument
2532 DISP_PROP_P; callers changed. Scan at most 5K characters forward
2533 for a display string or property. If found, set DISP_PROP_P
2534 non-zero.
2535
2536 * bidi.c (bidi_fetch_char): Accept an additional argument
2537 DISP_PROP_P, and pass it to compute_display_string_pos.
2538 Only handle text covered by a display string if DISP_PROP_P is returned
2539 non-zero. All callers of bidi_fetch_char changed.
2540
2541 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2542
2543 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2544
2545 2010-12-03 Don March <don@ohspite.net>
2546
2547 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2548 last character M-[char] is translated to ESC [char] (bug#7541).
2549
2550 2011-08-02 Kenichi Handa <handa@m17n.org>
2551
2552 * lisp.h (uniprop_table): Extern it.
2553
2554 * chartab.c (uniprop_table): Make it non-static.
2555
2556 2011-08-01 Eli Zaretskii <eliz@gnu.org>
2557
2558 * xdisp.c (forward_to_next_line_start): Accept additional argument
2559 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2560 on the newline.
2561 (reseat_at_next_visible_line_start): Use the bidi iterator state
2562 returned by forward_to_next_line_start to restore the state of
2563 it->bidi_it after backing up to previous newline. (Bug#9212)
2564
2565 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2566
2567 * regex.c (re_comp): Protoize.
2568 (re_exec): Fix return type.
2569 (regexec): Fix type of `ret'. (Bug#9203)
2570
2571 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2572
2573 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2574 This is needed if max-image-size is a floating-point number.
2575
2576 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2577
2578 * print.c (print_object): Print empty symbol as ##.
2579
2580 * lread.c (read1): Read ## as empty symbol.
2581
2582 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2583
2584 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2585 setting frame foreground color (Bug#9175).
2586 (x_set_background_color): Likewise.
2587
2588 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2589 contents (Bug#9176).
2590 (EmacsTooltip -init): Remove bezels and add shadows to
2591 tooltip windows.
2592
2593 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2594 or scroll bar (Bug#8470).
2595
2596 * nsfont.m (nsfont_open): Remove assignment to voffset and
2597 unnecessary vars hshink, expand, hd, full_height, min_height.
2598 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2599
2600 * nsterm.h (nsfont_info): Remove voffset field.
2601
2602 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2603
2604 Implement strike-through and overline on NextStep (Bug#8863).
2605
2606 * nsfont.m (nsfont_open): Use underline position provided by font,
2607 instead of hard-coded value of 2.
2608 (nsfont_draw): Call ns_draw_text_decoration instead.
2609
2610 * nsterm.h: Add declaration for ns_draw_text_decoration.
2611
2612 * nsterm.m (ns_draw_text_decoration): New function for drawing
2613 underline, overline, and strike-through.
2614 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2615 ns_draw_text_decoration. Change treatment of cursor drawing to
2616 accommodate underlining, etc.
2617
2618 2011-07-28 Eli Zaretskii <eliz@gnu.org>
2619
2620 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2621 default.
2622
2623 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2624
2625 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2626 Without this fix, if a signal arrives just after memory fills up,
2627 'malloc' might be invoked reentrantly.
2628
2629 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2630 In other words, assume that every image size is allowed, on non-X
2631 hosts. This assumption is probably wrong, but it lets Emacs compile.
2632
2633 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2634
2635 * regex.c (re_iswctype): Convert return values to boolean.
2636
2637 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2638
2639 * xdisp.c (compute_display_string_pos): Don't use cached display
2640 string position if the buffer had its restriction changed.
2641 (Bug#9184)
2642
2643 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2644
2645 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2646
2647 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2648
2649 Integer signedness and overflow and related fixes. (Bug#9079)
2650
2651 * bidi.c: Integer size and overflow fixes.
2652 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2653 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2654 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2655 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2656 (bidi_find_other_level_edge):
2657 Use ptrdiff_t instead of EMACS_INT where either will do.
2658 This works better on 32-bit hosts configured --with-wide-int.
2659 (bidi_cache_ensure_space): Check for size-calculation overflow.
2660 Use % rather than repeated addition, for better worst-case speed.
2661 Don't set bidi_cache_size until after xrealloc returns, because it
2662 might not return.
2663 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
2664 (bidi_cache_ensure_space): Also check that the bidi cache size
2665 does not exceed that of the largest Lisp string or buffer. See Eli
2666 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
2667
2668 * alloc.c (__malloc_size_t): Remove.
2669 All uses replaced by size_t. See Andreas Schwab's note
2670 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2671
2672 * image.c: Improve checking for integer overflow.
2673 (check_image_size): Assume that f is nonnull, since
2674 it is always nonnull in practice. This is one less thing to
2675 worry about when checking for integer overflow later.
2676 (x_check_image_size): New function, which checks for integer
2677 overflow issues inside X.
2678 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2679 This removes the need for a memory_full check.
2680 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2681 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2682 (xbm_read_bitmap_data): Change locals back to 'int', since
2683 their values must fit in 'int'.
2684 (xpm_load_image, png_load, tiff_load):
2685 Invoke x_create_x_image_and_pixmap earlier,
2686 to avoid much needless work if the image is too large.
2687 (tiff_load): Treat overly large images as if
2688 x_create_x_image_and_pixmap failed, not as malloc failures.
2689 (gs_load): Use x_check_image_size.
2690
2691 * gtkutil.c: Omit integer casts.
2692 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2693 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2694
2695 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2696
2697 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2698 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2699 would wrongly return t on a 64-bit host.
2700
2701 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2702 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2703 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2704 and therefore cause GCC to emit a bogus diagnostic in some cases.
2705
2706 * image.c: Integer signedness and overflow and related fixes.
2707 This is not an exhaustive set of fixes, but it's time to
2708 record what I've got.
2709 (lookup_pixel_color, check_image_size): Remove redundant decls.
2710 (check_image_size): Don't assume that arbitrary EMACS_INT values
2711 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2712 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2713 (tiff_load, imagemagick_load_image):
2714 Check for overflow in size calculations.
2715 (x_create_x_image_and_pixmap): Remove unnecessary test for
2716 xmalloc returning NULL; that can't happen.
2717 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2718 (xpm_color_bucket): Use better integer hashing function.
2719 (xpm_cache_color): Don't possibly over-allocate memory.
2720 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2721 (gif_memory_source):
2722 Use ptrdiff_t, not int or size_t, to record sizes.
2723 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2724 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2725 either works, as we prefer signed integers.
2726 (tiff_read_from_memory, tiff_write_from_memory):
2727 Return tsize_t, not size_t, since that's what the TIFF API wants.
2728 (tiff_read_from_memory): Don't fail simply because the read would
2729 go past EOF; instead, return a short read.
2730 (tiff_load): Omit no-longer-needed casts.
2731 (Fimagemagick_types): Don't assume size fits into 'int'.
2732
2733 Improve hashing quality when configured --with-wide-int.
2734 * fns.c (hash_string): New function, taken from sxhash_string.
2735 Do not discard information about ASCII character case; this
2736 discarding is no longer needed.
2737 (sxhash-string): Use it. Change sig to match it. Caller changed.
2738 * lisp.h: Declare it.
2739 * lread.c (hash_string): Remove, since we now use fns.c's version.
2740 The fns.c version returns a wider integer if --with-wide-int is
2741 specified, so this should help the quality of the hashing a bit.
2742
2743 * emacs.c: Integer overflow minor fix.
2744 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2745 Define only if GNU_LINUX.
2746 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2747
2748 * dispnew.c: Integer signedness and overflow fixes.
2749 Remove unnecessary forward decls, that were a maintenance hassle.
2750 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2751 All uses changed.
2752 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2753 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2754 (prepare_desired_row, line_draw_cost):
2755 Use int, not unsigned, where either works.
2756 (save_current_matrix, restore_current_matrix):
2757 Use ptrdiff_t, not size_t, where either works.
2758 (init_display): Check for overflow more accurately, and without
2759 relying on undefined behavior.
2760
2761 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2762 Remove, replacing with the new symbols in lisp.h. All uses changed.
2763 * fileio.c (make_temp_name):
2764 * filelock.c (lock_file_1, lock_file):
2765 * xdisp.c (message_dolog):
2766 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2767 Use pMd etc. instead.
2768 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2769 replacing the pWIDE etc. symbols removed from editfns.c.
2770
2771 * keyboard.h (num_input_events): Now uintmax_t.
2772 This is (very slightly) less likely to mess up due to wraparound.
2773 All uses changed.
2774
2775 * buffer.c: Integer signedness fixes.
2776 (alloc_buffer_text, enlarge_buffer_text):
2777 Use ptrdiff_t rather than size_t when either will do, as we prefer
2778 signed integers.
2779
2780 * alloc.c: Integer signedness and overflow fixes.
2781 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2782 (__malloc_size_t): Default to size_t, not to int.
2783 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2784 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2785 Prefer ptrdiff_t to size_t when either would do, as we prefer
2786 signed integers.
2787 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2788 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2789 Now const. Initialize with values that are in range even if char
2790 is signed.
2791 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2792 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2793 These functions do the right thing with sizes > 2**32.
2794 (check_depth): Now ptrdiff_t, not int.
2795 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2796 Adjust to new way of storing sizes. Check for size overflow bugs
2797 in rest of code.
2798 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2799 slightly wrong anyway, as it missed one instance of
2800 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2801 (refill_memory_reserve): Omit needless cast to size_t.
2802 (mark_object_loop_halt): Mark as externally visible.
2803
2804 * xselect.c: Integer signedness and overflow fixes.
2805 (Fx_register_dnd_atom, x_handle_dnd_message):
2806 Use ptrdiff_t, not size_t, since we prefer signed.
2807 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2808 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2809 x_dnd_atoms_size and x_dnd_atoms_length.
2810
2811 * doprnt.c: Prefer signed to unsigned when either works.
2812 * eval.c (verror):
2813 * doprnt.c (doprnt):
2814 * lisp.h (doprnt):
2815 * xdisp.c (vmessage):
2816 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2817 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2818 prefer signed arithmetic to avoid comparison confusion.
2819 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2820 but is a bit tricky.
2821
2822 Assume freestanding C89 headers, string.h, stdlib.h.
2823 * data.c, doprnt.c, floatfns.c, print.c:
2824 Include float.h unconditionally.
2825 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2826 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2827 * regex.c: Likewise for stddef.h, string.h.
2828 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2829 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2830 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2831 (STDC_HEADERS): Remove obsolete defines.
2832 * sysdep.c: Include limits.h unconditionally.
2833
2834 Assume support for memcmp, memcpy, memmove, memset.
2835 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2836 * regex.c (memcmp, memcpy):
2837 Remove; we assume C89 now.
2838
2839 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2840 (__malloc_safe_bcopy): Remove; no longer needed.
2841
2842 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
2843 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2844 well either way, and we prefer signed to unsigned.
2845
2846 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2847
2848 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2849 closes the connection while we're reading (bug#9182).
2850
2851 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
2852
2853 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2854 are specified (Bug#9168).
2855
2856 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2857
2858 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2859 Found by GCC static checking and --with-wide-int on a 32-bit host.
2860
2861 2011-07-25 Eli Zaretskii <eliz@gnu.org>
2862
2863 * xdisp.c (compute_display_string_pos): Fix logic of caching
2864 previous display string position. Initialize cached_prev_pos to
2865 -1. Fixes slow-down at the beginning of a buffer.
2866
2867 2011-07-24 Eli Zaretskii <eliz@gnu.org>
2868
2869 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2870 for attrs[LFACE_FONTSET_INDEX].
2871
2872 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2873
2874 * xml.c (parse_region): Remove unused local
2875 that was recently introduced.
2876
2877 2011-07-23 Eli Zaretskii <eliz@gnu.org>
2878
2879 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2880 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2881
2882 * xdisp.c (move_it_in_display_line_to): Record the best matching
2883 position for TO_CHARPOS while scanning the line, and restore it on
2884 exit if none of the characters scanned was an exact match.
2885 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
2886 when exact match is impossible due to invisible text, and the
2887 lines are truncated.
2888
2889 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2890
2891 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2892 for OSX >= 10.7.
2893
2894 2011-07-22 Eli Zaretskii <eliz@gnu.org>
2895
2896 Fix a significant slow-down of cursor motion with C-n, C-p,
2897 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2898 auto-repeat under bidi redisplay in fontified buffers.
2899 * xdisp.c (compute_stop_pos_backwards): New function.
2900 (next_element_from_buffer): Call compute_stop_pos_backwards to
2901 find a suitable prev_stop when we find ourselves before
2902 base_level_stop.
2903 (reseat): Don't look for prev_stop, as that could mean a very long
2904 run.
2905 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2906 <cached_disp_overlay_modiff>: Cache for last found display string
2907 position.
2908 (compute_display_string_pos): Return the cached position if asked
2909 about the same buffer in the same area of character positions, and
2910 the buffer wasn't changed since the time the display string
2911 position was cached.
2912
2913 2011-07-22 Eli Zaretskii <eliz@gnu.org>
2914
2915 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2916 is an integer, which is important for empty lines. (Bug#9149)
2917
2918 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
2919
2920 * frame.c (Fmodify_frame_parameters): In tty case, update the
2921 default face if necessary (Bug#4238).
2922
2923 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
2924
2925 * editfns.c (Fstring_to_char): No need to explain what a character
2926 is in the docstring (Bug#6576).
2927
2928 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2929
2930 * xml.c (parse_region): Make sure we always return a tree.
2931
2932 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2933
2934 * xml.c (parse_region): If a document contains only comments,
2935 return that, too.
2936
2937 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2938
2939 * xml.c (make_dom): Return comments, too.
2940
2941 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2942
2943 Port to OpenBSD.
2944 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2945 and the surrounding thread.
2946 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2947 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2948 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2949 timer goes off.
2950 * s/openbsd.h (BROKEN_SIGIO): Define.
2951 * unexelf.c (unexec) [__OpenBSD__]:
2952 Don't update the .mdebug section of the Alpha COFF symbol table.
2953
2954 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2955
2956 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2957 (bug#8460).
2958
2959 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2960
2961 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2962 This fixes some race conditions on the permissions of any newly
2963 created file.
2964
2965 * alloc.c (valid_pointer_p): Use pipe, not open.
2966 This fixes some permissions issues when debugging.
2967
2968 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2969 If fchown fails to set both uid and gid, try to set just gid,
2970 as that is sometimes allowed. Adjust the file's mode to eliminate
2971 setuid or setgid bits that are inappropriate if fchown fails.
2972
2973 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2974
2975 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2976 to compare Lisp_Objects.
2977 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2978 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2979 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2980
2981 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2982
2983 * lread.c (read_integer): Unread even EOF character.
2984 (read1): Likewise. Properly record start position of symbol.
2985
2986 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2987 symbol character follows.
2988
2989 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2990
2991 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2992 This works around a problem with the previous change to Fcopy_file.
2993 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2994 and without this change, GCC might complain about discarding
2995 fchown's return value.
2996
2997 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
2998
2999 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3000
3001 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3002
3003 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3004
3005 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3006
3007 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3008 it's used from the C level.
3009
3010 * process.c: Use the same condition for POLL_FOR_INPUT in both
3011 keyboard.c and process.c (bug#1858).
3012
3013 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3014
3015 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3016 (Fgnutls_boot): Use it.
3017
3018 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3019
3020 * doc.c (Fsubstitute_command_keys): Revert last change.
3021
3022 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3023
3024 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3025 quotes the next character, and doesn't affect other longer
3026 sequences (bug#8935).
3027
3028 * lread.c (syms_of_lread): Clarify that is isn't only
3029 `eval-buffer' and `eval-defun' that's affected by
3030 `lexical-binding' (bug#8460).
3031
3032 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3033
3034 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3035 bidi redisplay when a line includes both an image and is truncated.
3036
3037 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3038
3039 Fix minor problems found by static checking.
3040 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3041 (elsz): Now a signed constant, not a size_t var. We prefer signed
3042 types to unsigned, to avoid integer comparison confusion. Without
3043 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3044 "cannot optimize loop, the loop counter may overflow", a symptom
3045 of the confusion.
3046 * indent.c (Fvertical_motion): Mark locals as initialized.
3047 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3048
3049 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3050
3051 * search.c (Fre_search_backward): Mention `case-fold-search' in
3052 all the re_search_* functions (bug#8138).
3053
3054 * keyboard.c (Fopen_dribble_file): Document when the file is
3055 closed (bug#8056).
3056
3057 2011-07-14 Eli Zaretskii <eliz@gnu.org>
3058
3059 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3060 bidi_cache_idx.
3061
3062 Support bidi reordering of display and overlay strings.
3063 * xdisp.c (compute_display_string_pos)
3064 (compute_display_string_end): Accept additional argument STRING.
3065 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3066 (reseat_to_string): Initialize bidi_it->string.s and
3067 bidi_it->string.schars.
3068 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3069 NULL (avoids a crash in bidi_paragraph_init).
3070 Initialize itb.string.lstring.
3071 (init_iterator): Call bidi_init_it only of a valid
3072 buffer position was specified. Initialize paragraph_embedding to
3073 L2R.
3074 (reseat_to_string): Initialize the bidi iterator.
3075 (display_string): If we need to ignore text properties of
3076 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3077 original value of -1 will not work with bidi.)
3078 (compute_display_string_pos): First arg is now struct
3079 `text_pos *'; all callers changed. Support display properties on
3080 Lisp strings.
3081 (compute_display_string_end): Support display properties on Lisp
3082 strings.
3083 (init_iterator, reseat_1, reseat_to_string): Initialize the
3084 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3085 when iterating on a string not from display properties).
3086 (compute_display_string_pos, compute_display_string_end):
3087 Fix calculation of the object to scan. Fixes an error when using
3088 arrow keys.
3089 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
3090 base_level_stop; instead, set base_level_stop to BEGV.
3091 Fixes crashes in vertical-motion.
3092 (next_element_from_buffer): Improve commentary for when
3093 the iterator is before prev_stop.
3094 (init_iterator): Initialize bidi_p from the default value of
3095 bidi-display-reordering, not from buffer-local value. Use the
3096 buffer-local value only if initializing for buffer iteration.
3097 (handle_invisible_prop): Support invisible properties on strings
3098 that are being bidi-reordered.
3099 (set_iterator_to_next): Support bidi reordering of C strings and
3100 Lisp strings.
3101 (next_element_from_string): Support bidi reordering of Lisp
3102 strings.
3103 (handle_stop_backwards): Support Lisp strings as well.
3104 (display_string): Support display of R2L glyph rows.
3105 Use IT_STRING_CHARPOS when displaying from a Lisp string.
3106 (init_iterator): Don't initialize it->bidi_p for strings
3107 here.
3108 (reseat_to_string): Initialize it->bidi_p for strings here.
3109 (next_element_from_string, next_element_from_c_string)
3110 (next_element_from_buffer): Add xassert's for correspondence
3111 between IT's object being iterated and it->bidi_it.string
3112 structure.
3113 (face_before_or_after_it_pos): Support bidi iteration.
3114 (next_element_from_c_string): Handle the case of the first string
3115 character that is not the first one in the visual order.
3116 (get_visually_first_element): New function, refactored from common
3117 parts of next_element_from_buffer, next_element_from_string, and
3118 next_element_from_c_string.
3119 (tool_bar_lines_needed, redisplay_tool_bar)
3120 (display_menu_bar): Force left-to-right direction. Add a FIXME
3121 comment for making that be controlled by a user option.
3122 (push_it, pop_it): Save and restore the state of the
3123 bidi iterator. Save and restore the bidi_p flag.
3124 (pop_it): Iterate out of display property for string iteration as
3125 well.
3126 (iterate_out_of_display_property): Support iteration over strings.
3127 (handle_single_display_spec): Set up it->bidi_it for iteration
3128 over a display string, and call bidi_init_it.
3129 (handle_single_display_spec, next_overlay_string)
3130 (get_overlay_strings_1, push_display_prop): Set up the bidi
3131 iterator for displaying display or overlay strings.
3132 (forward_to_next_line_start): Don't use the shortcut if
3133 bidi-iterating.
3134 (back_to_previous_visible_line_start): If handle_display_prop
3135 pushed the iterator stack, restore the internal state of the bidi
3136 iterator by calling bidi_pop_it same number of times.
3137 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3138 and we are bidi-iterating, don't decrement the iterator position;
3139 instead, set the first_elt flag in the bidi iterator, to produce
3140 the same effect.
3141 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3142 (push_display_prop): xassert that we are iterating a buffer.
3143 (push_it, pop_it): Save and restore paragraph_embedding member.
3144 (handle_single_display_spec, next_overlay_string)
3145 (get_overlay_strings_1, reseat_1, reseat_to_string)
3146 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3147 correctly. Don't assume unibyte strings are not bidi-reordered.
3148 (compute_display_string_pos)
3149 (compute_display_string_end): Fix handling the case of C string.
3150 (push_it, pop_it): Save and restore from_disp_prop_p.
3151 (handle_single_display_spec, push_display_prop): Set the
3152 from_disp_prop_p flag.
3153 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3154 (pop_it): Call iterate_out_of_display_property only if we are
3155 popping after iteration over a string that came from a display
3156 property. Fix a typo in popping stretch info. Add an assertion
3157 for verifying that the iterator position is in sync with the bidi
3158 iterator.
3159 (handle_single_display_spec, get_overlay_strings_1)
3160 (push_display_prop): Fix initialization of paragraph direction for
3161 string when that of the parent object is not yet determined.
3162 (reseat_1): Call bidi_init_it to resync the bidi
3163 iterator with IT's position. (Bug#7616)
3164 (find_row_edges): If ROW->start.pos gives position
3165 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3166 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3167 Reset the from_disp_prop_p flag.
3168 (SAVE_IT, RESTORE_IT): New macros.
3169 (pos_visible_p, face_before_or_after_it_pos)
3170 (back_to_previous_visible_line_start)
3171 (move_it_in_display_line_to, move_it_in_display_line)
3172 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3173 (try_scrolling, redisplay_window, display_line): Use them when
3174 saving a temporary copy of the iterator and restoring it back.
3175 (back_to_previous_visible_line_start, reseat_1)
3176 (init_iterator): Empty the bidi cache "stack".
3177 (move_it_in_display_line_to): If iterator ended up at
3178 EOL, but we never saw any buffer positions smaller than
3179 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3180 motion in bidi-reordered lines.
3181 (move_it_in_display_line_to): Record prev_method and prev_pos
3182 immediately before the call to set_iterator_to_next. Fixes cursor
3183 motion in bidi-reordered lines with stretch glyphs and strings
3184 displayed in margins. (Bug#8133) (Bug#8867)
3185 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3186 TO_CHARPOS.
3187 (pos_visible_p): Support positions in bidi-reordered lines.
3188 Save and restore bidi cache.
3189
3190 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3191 (bidi_paragraph_info): Delete unused struct.
3192 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3193 (bidi_cache_start): New variable.
3194 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3195 to zero.
3196 (bidi_cache_fetch_state, bidi_cache_search)
3197 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3198 (bidi_cache_find, bidi_peek_at_next_level)
3199 (bidi_level_of_next_char, bidi_find_other_level_edge)
3200 (bidi_move_to_visually_next): Compare cache index with
3201 bidi_cache_start rather than with zero.
3202 (bidi_fetch_char): Accept new argument STRING; all callers
3203 changed. Support iteration over a string. Support strings with
3204 display properties. Support unibyte strings. Fix the type of
3205 `len' according to what STRING_CHAR_AND_LENGTH expects.
3206 (bidi_paragraph_init, bidi_resolve_explicit_1)
3207 (bidi_resolve_explicit, bidi_resolve_weak)
3208 (bidi_level_of_next_char, bidi_move_to_visually_next):
3209 Support iteration over a string.
3210 (bidi_set_sor_type, bidi_resolve_explicit_1)
3211 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3212 can now be zero (for strings); special values 0 and -1 were
3213 changed to -1 and -2, respectively.
3214 (bidi_char_at_pos): New function.
3215 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3216 Call it instead of FETCH_MULTIBYTE_CHAR.
3217 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3218 initialized to valid values.
3219 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3220 values.
3221 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3222 the test for valid cached positions. Fix the logic for looking up
3223 the sentinel state in the cache. GCPRO the Lisp string we are
3224 iterating.
3225 (bidi_push_it, bidi_pop_it): New functions.
3226 (bidi_initialize): Initialize the bidi cache start stack pointer.
3227 (bidi_cache_ensure_space): New function, refactored from part of
3228 bidi_cache_iterator_state. Don't assume the required size is just
3229 one BIDI_CACHE_CHUNK away.
3230 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3231 (bidi_count_bytes, bidi_char_at_pos): New functions.
3232 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3233 always valid if bidi_cache_idx is valid.
3234 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3235 is valid if it's going to be used.
3236 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3237 (bidi_cache_fetch_state, bidi_cache_search)
3238 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3239 (bidi_cache_iterator_state, bidi_cache_find)
3240 (bidi_find_other_level_edge, bidi_cache_start_stack):
3241 All variables related to cache indices are now EMACS_INT.
3242
3243 * dispextern.h (struct bidi_string_data): New structure.
3244 (struct bidi_it): New member `string'. Make flag members be 1-bit
3245 fields, and put them last in the struct.
3246 (compute_display_string_pos, compute_display_string_end):
3247 Update prototypes.
3248 (bidi_push_it, bidi_pop_it): Add prototypes.
3249 (struct iterator_stack_entry): New members bidi_p,
3250 paragraph_embedding, and from_disp_prop_p.
3251 (struct it): Member bidi_p is now a bit field 1 bit wide.
3252 (bidi_shelve_cache, bidi_unshelve_cache):
3253 Declare prototypes.
3254
3255 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3256 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3257 and vector-like objects.
3258
3259 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3260 cache around display iteration.
3261
3262 * window.c (Fwindow_end, window_scroll_pixel_based)
3263 (displayed_window_lines, Frecenter): Save and restore the bidi
3264 cache around display iteration.
3265
3266 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3267
3268 * editfns.c (Fdelete_region): Clarify the use of the named
3269 parameters (bug#6788).
3270
3271 2011-07-14 Martin Rudalics <rudalics@gmx.at>
3272
3273 * indent.c (Fvertical_motion): Set and restore w->pointm when
3274 saving and restoring the window's buffer (Bug#9006).
3275
3276 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3277
3278 * editfns.c (Fstring_to_char): Clarify just what is returned
3279 (bug#6576). Text by Eli Zaretskii.
3280
3281 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
3282
3283 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3284
3285 2011-07-13 Eli Zaretskii <eliz@gnu.org>
3286
3287 * buffer.c (mmap_find): Fix a typo.
3288
3289 2011-07-13 Johan Bockgård <bojohan@gnu.org>
3290
3291 Fix execution of x selection hooks.
3292 * xselect.c (Qx_lost_selection_functions)
3293 (Qx_sent_selection_functions): New vars.
3294 (syms_of_xselect): DEFSYM them.
3295 (x_handle_selection_request): Pass Qx_sent_selection_functions
3296 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3297 (x_handle_selection_clear,x_clear_frame_selections):
3298 Pass Qx_lost_selection_functions rather than
3299 Vx_lost_selection_functions to Frun_hook_with_args.
3300
3301 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3302
3303 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
3304 The old code sometimes used this field without initializing it.
3305
3306 * alloc.c (gc_sweep): Don't read past end of array.
3307 In theory, the old code could also have corrupted Emacs internals,
3308 though it'd be very unlikely.
3309
3310 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3311
3312 * character.c (Fcharacterp): Don't advertise optional ignored
3313 argument. (Bug#4026)
3314
3315 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3316
3317 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3318 key" (bug#4257).
3319
3320 * window.c (Fset_window_start): Doc fix (bug#4199).
3321 (Fset_window_hscroll): Ditto.
3322
3323 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3324
3325 Fix minor new problems caught by GCC 4.6.1.
3326 * term.c (init_tty): Remove unused local.
3327 * xsettings.c (store_monospaced_changed): Define this function only
3328 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
3329 not used otherwise.
3330
3331 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
3332
3333 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3334
3335 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3336
3337 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3338 are the mini-buffer and the echo area (bug#3320).
3339
3340 * term.c (init_tty): Remove support for supdup, c10 and perq
3341 terminals, which are no longer supported (bug#1482).
3342
3343 2011-07-10 Johan Bockgård <bojohan@gnu.org>
3344
3345 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3346
3347 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3348
3349 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3350 for non-popups (Bug#3642).
3351
3352 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3353
3354 * alloc.c (reset_malloc_hooks): Protoize.
3355 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
3356 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3357 * cm.c (losecursor): Likewise.
3358 * data.c (fmod): Likewise.
3359 * dispnew.c (swap_glyphs_in_rows): Likewise.
3360 * emacs.c (memory_warning_signal): Likewise.
3361 * floatfns.c (float_error): Likewise.
3362 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3363 (otf_open, font_otf_capability, generate_otf_features)
3364 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3365 Likewise.
3366 * image.c (pbm_read_file): Likewise.
3367 * indent.c (string_display_width): Likewise.
3368 * intervals.c (check_for_interval, search_for_interval)
3369 (inc_interval_count, count_intervals, root_interval)
3370 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3371 * lread.c (defalias): Likewise.
3372 * ralloc.c (r_alloc_check): Likewise.
3373 * regex.c (set_image_of_range_1, set_image_of_range)
3374 (regex_grow_registers): Likewise.
3375 * sysdep.c (strerror): Likewise.
3376 * termcap.c (valid_filename_p, tprint, main): Likewise.
3377 * tparam.c (main): Likewise.
3378 * unexhp9k800.c (run_time_remap, save_data_space)
3379 (update_file_ptrs, read_header, write_header, calculate_checksum)
3380 (copy_file, copy_rest, display_header): Likewise.
3381 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3382 Likewise.
3383 * xdisp.c (check_it): Likewise.
3384 * xfaces.c (register_color, unregister_color, unregister_colors):
3385 Likewise.
3386 * xfns.c (print_fontset_result): Likewise.
3387 * xrdb.c (member, fatal, main): Likewise.
3388
3389 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3390
3391 Fix minor problems found by static checking (Bug#9031).
3392 * chartab.c (char_table_set_range, map_sub_char_table):
3393 Remove unused locals.
3394 (uniprop_table): Now static.
3395 * composite.c (_work_char): Remove unused static var.
3396
3397 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
3398
3399 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3400
3401 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3402
3403 * gtkutil.c (qttip_cb): Remove code without function.
3404
3405 2011-07-09 Eli Zaretskii <eliz@gnu.org>
3406
3407 * w32.c (pthread_sigmask): New stub.
3408
3409 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
3410
3411 Use pthread_sigmask, not sigprocmask (Bug#9010).
3412 sigprocmask is portable only for single-threaded applications, and
3413 Emacs can be multi-threaded when it uses GTK.
3414 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3415 (LIBES): Use it.
3416 * callproc.c (Fcall_process):
3417 * process.c (create_process):
3418 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3419 Use pthread_sigmask, not sigprocmask.
3420
3421 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3422
3423 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3424 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3425 wrong (Bug#8591).
3426
3427 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3428
3429 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3430 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3431 (xg_hide_tooltip): Fix comment.
3432
3433 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3434 in registerServicesMenuSendTypes.
3435 (validRequestorForSendType): Don't check ns_return_types.
3436
3437 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3438 ns_return_type.
3439
3440 2011-07-08 Jason Rumney <jasonr@gnu.org>
3441
3442 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3443 SH_SHOW for hidden windows (Bug#5482).
3444
3445 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3446 frame struct members of non-existent frames (Bug#6284).
3447
3448 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3449
3450 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3451 variable firstTime not needed on OSX >= 10.6.
3452 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3453 >= 10.5. Use setKnobProportion, setDoubleValue.
3454
3455 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3456 (MAC_OS_X_VERSION_10_5): Define if not defined.
3457 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3458 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3459 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3460
3461 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3462 cString and lossyCString on OSX >= 10.4
3463
3464 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
3465 sizeToFit on OSX >= 10.2.
3466
3467 * nsimage.m (allocInitFromFile): Don't use deprecated method
3468 bestRepresentationForDevice on OSX >= 10.6.
3469
3470 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3471 to avoid warning.
3472
3473 * emacs.c: Declare unexec_init_emacs_zone.
3474
3475 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3476
3477 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3478
3479 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3480 on svcsMenu (Bug#8842).
3481
3482 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3483 ns_return_types.
3484 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3485
3486 * nsterm.m (QUTF8_STRING): Declare.
3487 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3488 (validRequestorForSendType): Return type is (id).
3489 Change indexOfObjectIdenticalTo to indexOfObject.
3490 Check if we have local selection before returning self (Bug#8842).
3491 (writeSelectionToPasteboard): Put local selection into paste board
3492 if we have a local selection (Bug#8842).
3493 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3494
3495 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3496 (ns_get_local_selection): Declare.
3497
3498 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3499
3500 * keymap.c (describe_map_tree): Don't insert a double newline at
3501 the end of the buffer (bug#1169) and return whether we inserted
3502 something.
3503
3504 * callint.c (Fcall_interactively): Change "reading args" to
3505 "providing args" to try to clarify what it does (bug#1010).
3506
3507 2011-07-07 Kenichi Handa <handa@m17n.org>
3508
3509 * composite.c (composition_compute_stop_pos): Ignore a static
3510 composition starting before CHARPOS (Bug#8915).
3511
3512 * xdisp.c (handle_composition_prop): Likewise.
3513
3514 2011-07-07 Eli Zaretskii <eliz@gnu.org>
3515
3516 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3517 (Bug#9015)
3518
3519 2011-07-07 Kenichi Handa <handa@m17n.org>
3520
3521 * character.h (unicode_category_t): New enum type.
3522
3523 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3524 (Qchar_code_property_table): New variable.
3525 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3526 (UNIPROP_COMPRESSED_FORM_P): New macros.
3527 (char_table_ascii): Uncompress the compressed values.
3528 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3529 Uncompress the compressed values.
3530 (sub_char_table_ref_and_range): Likewise.
3531 (char_table_ref_and_range): Uncompress the compressed values.
3532 (sub_char_table_set): New arg is_uniprop. Callers changed.
3533 Uncompress the compressed values.
3534 (sub_char_table_set_range): Args changed. Callers changed.
3535 (char_table_set_range): Adjuted for the above change.
3536 (map_sub_char_table): Delete args default_val and parent. Add arg
3537 top. Give decoded values to a Lisp function.
3538 (map_char_table): Adjust for the above change. Give decoded
3539 values to a Lisp function. Gcpro more variables.
3540 (uniprop_table_uncompress)
3541 (uniprop_decode_value_run_length): New functions.
3542 (uniprop_decoder, uniprop_decoder_count): New variables.
3543 (uniprop_get_decoder, uniprop_encode_value_character)
3544 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3545 New functions.
3546 (uniprop_encoder, uniprop_encoder_count): New variables.
3547 (uniprop_get_encoder, uniprop_table)
3548 (Funicode_property_table_internal, Fget_unicode_property_internal)
3549 (Fput_unicode_property_internal): New functions.
3550 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3551 Sunicode_property_table_internal, Sget_unicode_property_internal,
3552 and Sput_unicode_property_internal. Defvar_lisp
3553 char-code-property-alist.
3554
3555 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
3556 Vunicode_category_table.
3557
3558 * font.c (font_range): Adjust for the change of
3559 Vunicode_category_table.
3560
3561 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3562
3563 * m/iris4d.h: Remove file, move contents ...
3564 * s/irix6-5.h: ... here.
3565
3566 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3567
3568 Remove unportable assumption about struct layout (Bug#8884).
3569 * alloc.c (mark_buffer):
3570 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3571 (clone_per_buffer_values): Don't assume that
3572 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3573 This isn't true in general, and it's particularly not true
3574 if Emacs is configured with --with-wide-int.
3575 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3576 New macros, used in the buffer.c change.
3577
3578 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3579
3580 * xsettings.c: Use both GConf and GSettings if both are available.
3581 (store_config_changed_event): Add comment.
3582 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3583 (store_tool_bar_style_changed): New functions.
3584 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
3585 (struct xsettings): Move font inside HAVE_XFT.
3586 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
3587 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
3588 Move inside HAVE_XFT.
3589 (something_changed_gsettingsCB): Rename from something_changedCB.
3590 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3591 also.
3592 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
3593 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
3594 (something_changed_gconfCB): Rename from something_changedCB.
3595 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3596 (parse_settings): Move check for font inside HAVE_XFT.
3597 (read_settings, apply_xft_settings): Add comment.
3598 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3599 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3600 call store_font_name_changed.
3601 (xft_settings_event): Add comment.
3602 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3603 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3604 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3605 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3606 (xsettings_initialize): Call init_gsettings last.
3607 (xsettings_get_system_font, xsettings_get_system_normal_font):
3608 Add comment.
3609
3610 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3611
3612 Random fixes. E.g., (random) never returned negative values.
3613 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3614 subseconds part to the entropy, as that's a bit more random.
3615 Prefer signed to unsigned, since the signedness doesn't matter and
3616 in general we prefer signed. When given a limit, use a
3617 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3618 latter isn't right if USE_2_TAGS_FOR_INTS.
3619 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3620 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3621
3622 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3623
3624 * textprop.c (text_property_stickiness):
3625 Obey Vtext_property_default_nonsticky.
3626 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3627 * w32fns.c (syms_of_w32fns):
3628 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3629
3630 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3631
3632 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3633 This is more efficient than Ffile_directory_p and avoids a minor race.
3634
3635 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3636
3637 * buffer.c (Foverlay_put): Say what the return value is
3638 (bug#7835).
3639
3640 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3641 is a directory before asking whether to use the file name
3642 (bug#7564).
3643 (barf_or_query_if_file_exists): Make the "File is a directory"
3644 error be more correct.
3645
3646 * fns.c (Frequire): Remove the mention of the .gz files, since
3647 that's installation-specific, but keep the mention of
3648 `get-load-suffixes'.
3649
3650 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3651
3652 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3653 Report string overflow if the output is too long.
3654
3655 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
3656
3657 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3658 (syms_of_gnutls): Remove duplicate DEFSYM for
3659 Qgnutls_bootprop_verify_hostname_error, an error for
3660 Qgnutls_bootprop_verify_error (which is no longer used).
3661
3662 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3663 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3664 Also (re)move comments that are misplaced or no longer relevant.
3665
3666 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3667
3668 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3669
3670 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
3671
3672 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3673 and background color parameters if they have been changed.
3674
3675 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3676
3677 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3678
3679 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3680
3681 * xsettings.c (SYSTEM_FONT): Define only when used.
3682 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3683
3684 * keymap.c (access_keymap_1): Now static.
3685
3686 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
3687
3688 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3689 leave any prefix arg for the up event (Bug#1586).
3690
3691 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3692
3693 * lread.c (syms_of_lread): Mention single symbols defined by
3694 `defvar' or `defconst' (bug#7154).
3695
3696 * fns.c (Frequire): Mention .el.gz files (bug#7314).
3697 (Frequire): Mention get-load-suffixes.
3698
3699 2011-07-02 Martin Rudalics <rudalics@gmx.at>
3700
3701 * window.h (window): Remove clone_number slot.
3702 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3703 Remove.
3704 (make_parent_window, make_window, saved_window)
3705 (Fset_window_configuration, save_window_save): Don't deal with
3706 clone numbers.
3707 * buffer.c (Qclone_number): Remove declaration.
3708 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3709
3710 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3711
3712 Add multiple inheritance to keymaps.
3713 * keymap.c (Fmake_composed_keymap): New function.
3714 (Fset_keymap_parent): Simplify.
3715 (fix_submap_inheritance): Remove.
3716 (access_keymap_1): New function extracted from access_keymap to handle
3717 embedded parents and handle lists of maps.
3718 (access_keymap): Use it.
3719 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3720 (Fcopy_keymap): Handle embedded parents.
3721 (Fcommand_remapping, define_as_prefix): Simplify.
3722 (Fkey_binding): Simplify.
3723 (syms_of_keymap): Move minibuffer-local-completion-map,
3724 minibuffer-local-filename-completion-map,
3725 minibuffer-local-must-match-map, and
3726 minibuffer-local-filename-must-match-map to Elisp.
3727 (syms_of_keymap): Defsubr make-composed-keymap.
3728 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3729 (parse_menu_item): Trivial simplification.
3730
3731 2011-07-01 Glenn Morris <rgm@gnu.org>
3732
3733 * Makefile.in (SETTINGS_LIBS): Fix typo.
3734
3735 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3736
3737 * coding.c (Fencode_coding_string): Record the last coding system
3738 used, as the function doc string says (bug#8738).
3739
3740 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3741
3742 * xsettings.c (store_monospaced_changed): Take new font as arg and
3743 check for change against current_mono_font.
3744 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3745 (emacs_settings_constructor, emacs_settings_get_property)
3746 (emacs_settings_set_property, emacs_settings_class_init)
3747 (emacs_settings_init, gsettings_obj): Remove.
3748 (something_changedCB): New function for HAVE_GSETTINGS.
3749 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3750 with value as argument.
3751 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3752 g_settings_new (Bug#8967). Do not create gsettings_obj.
3753 Remove calls to g_settings_bind. Connect something_changedCB to
3754 "changed".
3755
3756 * xgselect.c: Add defined (HAVE_GSETTINGS).
3757 (xgselect_initialize): Ditto.
3758
3759 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3760 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3761 xg_select.
3762
3763 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3764
3765 * eval.c (struct backtrace): Simplify and port the data structure.
3766 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3767 signed bit field, as this assumption is not portable and it makes
3768 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3769 "char debug_on_exit : 1" as this is not portable either; instead,
3770 use the portable "unsigned int debug_on_exit : 1". Remove unused
3771 member evalargs. Remove obsolete comments about cc bombing out.
3772
3773 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3774
3775 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
3776 Let HAVE_GSETTINGS override HAVE_GCONF.
3777 (store_monospaced_changed): New function.
3778 (EMACS_SETTINGS): A new type derived from GObject to handle
3779 GSettings notifications.
3780 (emacs_settings_constructor, emacs_settings_get_property)
3781 (emacs_settings_set_property, emacs_settings_class_init):
3782 New functions.
3783 (gsettings_client, gsettings_obj): New variables.
3784 (GSETTINGS_SCHEMA): New define.
3785 (something_changedCB): Call store_monospaced_changed.
3786 (init_gsettings): New function.
3787 (xsettings_initialize): Call init_gsettings.
3788 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3789 to NULL.
3790
3791 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
3792 GCONF_CFLAGS/LIBS.
3793
3794 2011-06-29 Martin Rudalics <rudalics@gmx.at>
3795
3796 * window.c (resize_root_window, grow_mini_window)
3797 (shrink_mini_window): Rename Qresize_root_window to
3798 Qwindow_resize_root_window and Qresize_root_window_vertically to
3799 Qwindow_resize_root_window_vertically.
3800
3801 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3802
3803 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3804
3805 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
3806
3807 * makefile.w32-in: Redesign dependencies so they reflect more
3808 clearly which files are directly included by each source file,
3809 and not through other includes.
3810
3811 2011-06-27 Martin Rudalics <rudalics@gmx.at>
3812
3813 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3814 (sort_overlays, overlay_strings): When an overlay's clone number
3815 matches the window's clone number process the overlay even if
3816 the overlay's window property doesn't match the current window.
3817
3818 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3819 (Fwindow_hchild): Rename to Fwindow_left_child.
3820 (Fwindow_next): Rename to Fwindow_next_sibling.
3821 (Fwindow_prev): Rename to Fwindow_prev_sibling.
3822 (resize_window_check): Rename to window_resize_check.
3823 (resize_window_apply): Rename to window_resize_apply.
3824 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3825 (Fdelete_other_windows_internal, resize_frame_windows)
3826 (Fsplit_window_internal, Fdelete_window_internal)
3827 (grow_mini_window, shrink_mini_window)
3828 (Fresize_mini_window_internal): Fix callers accordingly.
3829
3830 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3831
3832 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3833 (emacs_fixed_set_min_size): Remove.
3834 (emacs_fixed_new): Take frame as argument.
3835
3836 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3837 (_EmacsFixedPrivate): Remove minwidth/height.
3838 Add struct frame *f.
3839 (emacs_fixed_init): Initialize priv->f.
3840 (get_parent_class, emacs_fixed_set_min_size): Remove.
3841 (emacs_fixed_new): Set priv->f to argument.
3842 (emacs_fixed_get_preferred_width)
3843 (emacs_fixed_get_preferred_height): Use min_width/height from
3844 frames size_hint to set minimum and natural (Bug#8919).
3845 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3846 and use min_width/height from frames size_hint to set
3847 min_width/height (Bug#8919).
3848
3849 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
3850 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3851 Fix indentation.
3852
3853 2011-06-26 Eli Zaretskii <eliz@gnu.org>
3854
3855 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3856 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3857 called at ZV.
3858
3859 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
3860
3861 * process.c (wait_reading_process_output): Bypass select if
3862 waiting for a cell while ignoring keyboard input, and input is
3863 pending. Suggested by Jan Djärv (Bug#8869).
3864
3865 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3866
3867 Use gnulib's dup2 module instead of rolling our own.
3868 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3869
3870 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3871
3872 * dispnew.c (scrolling_window): Before scrolling, turn off a
3873 mouse-highlight in the window being scrolled.
3874
3875 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
3876
3877 Move DEFSYM to lisp.h and use everywhere.
3878
3879 * character.h (DEFSYM): Move declaration...
3880 * lisp.h (DEFSYM): ...here.
3881
3882 * gnutls.c:
3883 * minibuf.c:
3884 * w32menu.c:
3885 * w32proc.c:
3886 * w32select.c: Don't include character.h.
3887
3888 * alloc.c (syms_of_alloc):
3889 * buffer.c (syms_of_buffer):
3890 * bytecode.c (syms_of_bytecode):
3891 * callint.c (syms_of_callint):
3892 * casefiddle.c (syms_of_casefiddle):
3893 * casetab.c (init_casetab_once):
3894 * category.c (init_category_once, syms_of_category):
3895 * ccl.c (syms_of_ccl):
3896 * cmds.c (syms_of_cmds):
3897 * composite.c (syms_of_composite):
3898 * dbusbind.c (syms_of_dbusbind):
3899 * dired.c (syms_of_dired):
3900 * dispnew.c (syms_of_display):
3901 * doc.c (syms_of_doc):
3902 * editfns.c (syms_of_editfns):
3903 * emacs.c (syms_of_emacs):
3904 * eval.c (syms_of_eval):
3905 * fileio.c (syms_of_fileio):
3906 * fns.c (syms_of_fns):
3907 * frame.c (syms_of_frame):
3908 * fringe.c (syms_of_fringe):
3909 * insdel.c (syms_of_insdel):
3910 * keymap.c (syms_of_keymap):
3911 * lread.c (init_obarray, syms_of_lread):
3912 * macros.c (syms_of_macros):
3913 * msdos.c (syms_of_msdos):
3914 * print.c (syms_of_print):
3915 * process.c (syms_of_process):
3916 * search.c (syms_of_search):
3917 * sound.c (syms_of_sound):
3918 * syntax.c (init_syntax_once, syms_of_syntax):
3919 * terminal.c (syms_of_terminal):
3920 * textprop.c (syms_of_textprop):
3921 * undo.c (syms_of_undo):
3922 * w32.c (globals_of_w32):
3923 * window.c (syms_of_window):
3924 * xdisp.c (syms_of_xdisp):
3925 * xfaces.c (syms_of_xfaces):
3926 * xfns.c (syms_of_xfns):
3927 * xmenu.c (syms_of_xmenu):
3928 * xsettings.c (syms_of_xsettings):
3929 * xterm.c (syms_of_xterm): Use DEFSYM.
3930
3931 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3932
3933 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
3934
3935 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3936
3937 Integer and buffer overflow fixes (Bug#8873).
3938
3939 * print.c (printchar, strout): Check for string overflow.
3940 (PRINTPREPARE, printchar, strout):
3941 Don't set size unless allocation succeeds.
3942
3943 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3944 for sizes. Check for string overflow more accurately.
3945 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3946
3947 * macros.c: Integer and buffer overflow fixes.
3948 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3949 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3950 Use ptrdiff_t, not int, for sizes.
3951 Don't increment bufsize until after realloc succeeds.
3952 Check for size-calculation overflow.
3953 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3954
3955 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3956
3957 * lread.c: Integer overflow fixes.
3958 (read_integer): Radix is now EMACS_INT, not int,
3959 to improve quality of diagnostics for out-of-range radices.
3960 Calculate buffer size correctly for out-of-range radices.
3961 (read1): Check for integer overflow in radices, and in
3962 read-circle numbers.
3963 (read_escape): Avoid int overflow.
3964 (Fload, openp, read_buffer_size, read1)
3965 (substitute_object_recurse, read_vector, read_list, map_obarray):
3966 Use ptrdiff_t, not int, for sizes.
3967 (read1): Use EMACS_INT, not int, for sizes.
3968 Check for size overflow.
3969
3970 * image.c (cache_image): Check for size arithmetic overflow.
3971
3972 * lread.c: Integer overflow issues.
3973 (saved_doc_string_size, saved_doc_string_length)
3974 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3975 Now ptrdiff_t, not int.
3976 (read1): Don't assume doc string length fits in int. Check for
3977 out-of-range doc string lengths.
3978 (read_list): Don't assume file position fits in int.
3979 (read_escape): Check for hex character overflow.
3980
3981 2011-06-22 Leo Liu <sdl.web@gmail.com>
3982
3983 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3984 Move to minibuffer.el.
3985
3986 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3987
3988 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
3989 The following patches are for when GLYPH_DEBUG && !XASSERT.
3990 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3991 * dispnew.c (flush_stdout):
3992 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3993 Mark as externally visible.
3994 * dispnew.c (check_window_matrix_pointers): Now static.
3995 * dispnew.c (window_to_frame_vpos):
3996 * xfns.c (unwind_create_frame):
3997 * xterm.c (x_check_font): Remove unused local.
3998 * scroll.c (CHECK_BOUNDS):
3999 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4000 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4001 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4002 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4003 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4004 Now static.
4005 (debug_method_add): Use va_list and vsprintf rather than relying
4006 on undefined behavior with wrong number of arguments.
4007 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4008 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4009 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4010 since we're not interested in debugging glyphs with old libraries.
4011 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4012 GCC 4.6.0's static checking.
4013
4014 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4015
4016 Integer overflow and signedness fixes (Bug#8873).
4017 A few related buffer overrun fixes, too.
4018
4019 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4020
4021 * dispextern.h (struct face.stipple):
4022 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4023 (x_bitmap_mask, x_allocate_bitmap_record)
4024 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4025 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4026 (x_create_bitmap_from_xpm_data):
4027 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4028 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4029 (.bitmaps_last):
4030 * xfaces.c (load_pixmap):
4031 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4032 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4033 (.bitmaps_last, struct x_output.icon_bitmap):
4034 Use ptrdiff_t, not int, for bitmap indexes.
4035 (x_allocate_bitmap_record): Check for size overflow.
4036 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4037
4038 Use ptrdiff_t, not int, for overlay counts.
4039 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4040 * editfns.c (overlays_around, get_pos_property):
4041 * textprop.c (get_char_property_and_overlay):
4042 * xdisp.c (next_overlay_change, note_mouse_highlight):
4043 * xfaces.c (face_at_buffer_position):
4044 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4045 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4046 (Fnext_overlay_change, Fprevious_overlay_change)
4047 (mouse_face_overlay_overlaps, Foverlays_in):
4048 Use ptrdiff_t, not int, for sizes.
4049 (overlays_at, overlays_in): Check for size-calculation overflow.
4050
4051 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4052
4053 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4054 (x_session_initialize): Do not assume string length fits in int.
4055
4056 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4057 This is unlikely, but can occur if DPI is outlandish.
4058
4059 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
4060 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4061
4062 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4063 * xrdb.c (magic_file_p, search_magic_path):
4064 Omit last arg SUFFIX; it was always 0. All callers changed.
4065 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4066
4067 * xfont.c (xfont_match): Avoid need for strlen.
4068
4069 * xfns.c: Don't assume strlen fits in int.
4070 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4071
4072 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4073 not unsigned long, as we prefer signed integers. All callers changed.
4074 Detect integer overflow in repeat count.
4075 (message_dolog): Don't assume print length fits in 39 bytes.
4076 (display_mode_element): Don't assume strlen fits in int.
4077
4078 * termcap.c: Don't assume sizes fit in int and never overflow.
4079 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4080 (gobble_line): Check for size-calculation overflow.
4081
4082 * minibuf.c (Fread_buffer):
4083 * lread.c (intern, intern_c_string):
4084 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4085 Don't assume string length fits in int.
4086
4087 * keyboard.c (parse_tool_bar_item):
4088 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4089
4090 * font.c: Don't assume string length fits in int.
4091 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4092 Use ptrdiff_t, not int.
4093 (font_intern_prop): Don't assume string length fits in int.
4094 Don't assume integer property fits in fixnum.
4095 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
4096
4097 * filelock.c: Fix some buffer overrun and integer overflow issues.
4098 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
4099 Reformulate so as not to need the command string.
4100 Invoke gzip -cd rather than gunzip, as it's more portable.
4101 (lock_info_type, lock_file_1, lock_file):
4102 Don't assume pid_t and time_t fit in unsigned long.
4103 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4104 (current_lock_owner): Prefer signed type for sizes.
4105 Use memcpy, not strncpy, where memcpy is what is really wanted.
4106 Don't assume (via atoi) that time_t and pid_t fit in int.
4107 Check for time_t and/or pid_t out of range, e.g., via a network share.
4108 Don't alloca where an auto var works fine.
4109
4110 * fileio.c: Fix some integer overflow issues.
4111 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4112 Don't assume string length fits in int.
4113 (directory_file_name): Don't assume string length fits in long.
4114 (make_temp_name): Don't assume pid fits in int, or that its print
4115 length is less than 20.
4116
4117 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4118
4119 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4120
4121 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4122
4123 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4124 We prefer signed integers, even for size calculations.
4125
4126 * emacs.c: Don't assume string length fits in 'int'.
4127 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4128 (main): Don't invoke strlen when not needed.
4129
4130 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4131 (XD_DEBUG_MESSAGE): Don't waste a byte.
4132
4133 * callproc.c (getenv_internal_1, getenv_internal)
4134 (Fgetenv_internal):
4135 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4136
4137 * lread.c (invalid_syntax): Omit length argument.
4138 All uses changed. This doesn't fix a bug, but it simplifies the
4139 code away from its former Hollerith-constant appearance, and it's
4140 one less 'int' to worry about when looking at integer-overflow issues.
4141 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
4142
4143 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4144 This didn't break anything, but it didn't help either.
4145 It's confusing to put a bogus integer in a place where the actual
4146 value does not matter.
4147 (LIST_END_P): Remove unused macro and its bogus comment.
4148 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
4149
4150 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4151 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4152 implementation.
4153 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4154 We prefer signed types, and the value cannot exceed the EMACS_INT
4155 range anyway (because otherwise the length would not be representable).
4156 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4157 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4158 This avoids a GCC warning when WIDE_EMACS_INT.
4159
4160 * indent.c (sane_tab_width): New function.
4161 (current_column, scan_for_column, Findent_to, position_indentation)
4162 (compute_motion): Use it. This is just for clarity.
4163 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
4164
4165 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
4166
4167 * lisp.h (lint_assume): New macro.
4168 * composite.c (composition_gstring_put_cache):
4169 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4170
4171 * editfns.c, insdel.c:
4172 Omit unnecessary forward decls, to simplify future changes.
4173
4174 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4175
4176 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4177
4178 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
4179 Use much-faster test for byte-length change.
4180 Don't assume string byte-length fits in 'int'.
4181 Check that character arg fits in 'int'.
4182 (mapcar1): Declare byte as byte, for clarity.
4183
4184 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4185
4186 * fns.c (concat): Catch string overflow earlier.
4187 Do not rely on integer wraparound.
4188
4189 * dispextern.h (struct it.overlay_strings_charpos)
4190 (struct it.selective): Now EMACS_INT, not int.
4191 * xdisp.c (forward_to_next_line_start)
4192 (back_to_previous_visible_line_start)
4193 (reseat_at_next_visible_line_start, next_element_from_buffer):
4194 Don't arbitrarily truncate the value of 'selective' to int.
4195
4196 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4197
4198 * composite.c: Don't truncate sizes to 'int'.
4199 (composition_gstring_p, composition_reseat_it)
4200 (composition_adjust_point): Use EMACS_INT, not int.
4201 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4202 not EMACS_UINT, for indexes.
4203
4204 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4205
4206 * buffer.c: Include <verify.h>.
4207 (struct sortvec.priority, struct sortstr.priority):
4208 Now EMACS_INT, not int.
4209 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
4210 (struct sortstr.size, record_overlay_string)
4211 (struct sortstrlist.size, struct sortlist.used):
4212 Don't truncate size to int.
4213 (record_overlay_string): Check for size-calculation overflow.
4214 (init_buffer_once): Check at compile-time, not run-time.
4215
4216 2011-06-22 Jim Meyering <meyering@redhat.com>
4217
4218 Don't leak an XBM-image-sized buffer
4219 * image.c (xbm_load): Free the image buffer after using it.
4220
4221 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4222
4223 Port to Sun C.
4224 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4225 that Sun C diagnosed.
4226 * fns.c (secure_hash): Fix pointer signedness issue.
4227 * intervals.c (static_offset_intervals): New function.
4228 (offset_intervals): Use it.
4229
4230 2011-06-21 Leo Liu <sdl.web@gmail.com>
4231
4232 * deps.mk (fns.o):
4233 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4234 sha512.h.
4235
4236 * fns.c (secure_hash): Rename from crypto_hash_function and change
4237 the first arg to accept symbols.
4238 (Fsecure_hash): New primitive.
4239 (syms_of_fns): New symbols.
4240
4241 2011-06-20 Deniz Dogan <deniz@dogan.se>
4242
4243 * process.c (Fset_process_buffer): Clarify return value in
4244 docstring.
4245
4246 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
4247
4248 * dispnew.c (add_window_display_history): Use BVAR.
4249
4250 * xdisp.c (debug_method_add): Use BVAR.
4251 (check_window_end, dump_glyph_matrix, dump_glyph)
4252 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4253
4254 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4255 Likewise.
4256
4257 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4258 check till after the cache is created in init_frame_faces.
4259
4260 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4261
4262 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4263
4264 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4265
4266 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4267 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4268 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4269
4270 Improve buffer-overflow checking (Bug#8873).
4271 * fileio.c (Finsert_file_contents):
4272 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4273 Remove the old (too-loose) buffer overflow checks.
4274 They weren't needed, since make_gap checks for buffer overflow.
4275 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4276 The old code merely checked for Emacs fixnum overflow, and relied
4277 on undefined (wraparound) behavior. The new code avoids undefined
4278 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4279
4280 * editfns.c (Finsert_char): Don't dump core with very negative counts.
4281 Tune. Don't use wider integers than needed. Don't use alloca.
4282 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
4283
4284 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4285
4286 * insdel.c, lisp.h (buffer_overflow): New function.
4287 (insert_from_buffer_1, replace_range, replace_range_2):
4288 * insdel.c (make_gap_larger):
4289 * editfns.c (Finsert_char):
4290 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4291
4292 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4293
4294 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4295
4296 Integer overflow and signedness fixes (Bug#8873).
4297
4298 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4299 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4300
4301 * fileio.c: Don't assume EMACS_INT fits in off_t.
4302 (emacs_lseek): New static function.
4303 (Finsert_file_contents, Fwrite_region): Use it.
4304 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4305
4306 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4307
4308 * fns.c: Don't overflow int when computing a list length.
4309 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4310 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4311 truncation on 64-bit hosts. Check for QUIT every
4312 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4313 faster and is responsive enough.
4314 (Flength): Report an error instead of overflowing an integer.
4315 (Fsafe_length): Return a float if the value is not representable
4316 as a fixnum. This shouldn't happen except in contrived situations.
4317 (Fnthcdr, Fsort): Don't assume list length fits in int.
4318 (Fcopy_sequence): Don't assume vector length fits in int.
4319
4320 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4321 (header_size, word_size): New constants.
4322 (allocate_vectorlike): Don't check size overflow here.
4323 (allocate_vector): Check it here instead, since this is the only
4324 caller of allocate_vectorlike that could cause overflow.
4325 Check that the new vector's length is representable as a fixnum.
4326
4327 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4328 The previous code was bogus. For example, next_almost_prime (32)
4329 returned 39, which is undesirable as it is a multiple of 3; and
4330 next_almost_prime (24) returned 25, which is a multiple of 5 so
4331 why was the code bothering to check for multiples of 7?
4332
4333 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4334
4335 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4336
4337 Variadic C functions now count arguments with ptrdiff_t.
4338 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4339 Back then I didn't know that the Emacs coding style prefers signed int.
4340 Also, in the meantime I found a few more instances where arguments
4341 were being counted with int, which may truncate counts on 64-bit
4342 machines, or EMACS_INT, which may be unnecessarily wide.
4343 * lisp.h (struct Lisp_Subr.function.aMANY)
4344 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4345 Arg counts are now ptrdiff_t, not size_t.
4346 All variadic functions and their callers changed accordingly.
4347 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4348 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4349 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4350 * callint.c (Fcall_interactively): Check arg count for overflow,
4351 to avoid potential buffer overrun. Use signed char, not 'int',
4352 for 'varies' array, so that we needn't bother to check its size
4353 calculation for overflow.
4354 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4355 * eval.c (apply_lambda):
4356 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4357 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4358 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4359
4360 * callint.c (Fcall_interactively): Don't use index var as event count.
4361
4362 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4363 * mem-limits.h (SIZE): Remove; no longer used.
4364
4365 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
4366
4367 Remove unnecessary casts.
4368 * xterm.c (x_term_init):
4369 * xfns.c (x_set_border_pixel):
4370 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4371 These aren't needed now that we assume ANSI C.
4372
4373 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4374 It's more likely to cause problems (due to unsigned overflow)
4375 than to cure them.
4376
4377 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4378
4379 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4380
4381 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4382
4383 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4384
4385 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4386
4387 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4388
4389 GLYPH_CODE_FACE returns EMACS_INT, not int.
4390 * dispextern.h (merge_faces):
4391 * xfaces.c (merge_faces):
4392 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4393 Don't assume EMACS_INT fits in int.
4394
4395 * character.h (CHAR_VALID_P): Remove unused parameter.
4396 * fontset.c, lisp.h, xdisp.c: All uses changed.
4397
4398 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4399
4400 * fns.c (concat): Minor tuning based on overflow analysis.
4401 This doesn't fix any bugs. Use int to hold character, instead
4402 of constantly refetching from Emacs object. Use XFASTINT, not
4403 XINT, for value known to be a character. Don't bother comparing
4404 a single byte to 0400, as it's always less.
4405
4406 * floatfns.c (Fexpt):
4407 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4408
4409 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4410 for characters.
4411
4412 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4413
4414 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4415 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4416 incorrectly succeed when S was a string, because 4294967386 was
4417 truncated before it was used.
4418
4419 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4420 Otherwise, an out-of-range integer could cause undefined behavior
4421 on a 64-bit host.
4422
4423 * composite.c: Use int, not EMACS_INT, for characters.
4424 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4425 EMACS_INT, for values that are known to be in character range.
4426 This doesn't fix any bugs but is the usual style inside Emacs and
4427 may generate better code on 32-bit machines.
4428
4429 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4430 This is for reasons similar to the recent CHAR_STRING fix.
4431 * charset.c (Fencode_char): Check that character arg is actually
4432 a character. Pass an int to ENCODE_CHAR.
4433 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4434 wider than 'int', as a compile-time check to prevent future regressions
4435 in this area.
4436
4437 * character.c (char_string): Remove unnecessary casts.
4438
4439 Make sure a 64-bit char is never passed to CHAR_STRING.
4440 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4441 by silently ignoring the top 32 bits, allowing some values
4442 that were far too large to be valid characters.
4443 * character.h: Include <verify.h>.
4444 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4445 arguments are no wider than unsigned, as a compile-time check
4446 to prevent future regressions in this area.
4447 * data.c (Faset):
4448 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
4449 (Fsubst_char_in_region):
4450 * fns.c (concat):
4451 * xdisp.c (decode_mode_spec_coding):
4452 Adjust to CHAR_STRING's new requirement.
4453 * editfns.c (Finsert_char, Fsubst_char_in_region):
4454 * fns.c (concat): Check that character args are actually
4455 characters. Without this test, these functions did the wrong
4456 thing with wildly out-of-range values on 64-bit hosts.
4457
4458 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4459 These casts should not be needed on 32-bit hosts, either.
4460 * keyboard.c (read_char):
4461 * lread.c (Fload): Remove casts to unsigned.
4462
4463 * lisp.h (UNSIGNED_CMP): New macro.
4464 This fixes comparison bugs on 64-bit hosts.
4465 (ASCII_CHAR_P): Use it.
4466 * casefiddle.c (casify_object):
4467 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
4468 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4469 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4470 * dispextern.h (FACE_FROM_ID):
4471 * keyboard.c (read_char): Use UNSIGNED_CMP.
4472
4473 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4474 not to EMACS_INT, to avoid GCC warning.
4475
4476 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4477
4478 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4479 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4480 isn't needed on 32-bit machines.
4481
4482 * buffer.c (Fgenerate_new_buffer_name):
4483 Use EMACS_INT for count, not int.
4484 (advance_to_char_boundary): Return EMACS_INT, not int.
4485
4486 * data.c (Qcompiled_function): Now static.
4487
4488 * window.c (window_body_lines): Now static.
4489
4490 * image.c (gif_load): Rename local to avoid shadowing.
4491
4492 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4493 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4494 * alloc.c (make_save_value): Integer argument is now of type
4495 ptrdiff_t, not int.
4496 (mark_object): Use ptrdiff_t, not int.
4497 * lisp.h (pD): New macro.
4498 * print.c (print_object): Use it.
4499
4500 * alloc.c: Use EMACS_INT, not int, to count objects.
4501 (total_conses, total_markers, total_symbols, total_vector_size)
4502 (total_free_conses, total_free_markers, total_free_symbols)
4503 (total_free_floats, total_floats, total_free_intervals)
4504 (total_intervals, total_strings, total_free_strings):
4505 Now EMACS_INT, not int. All uses changed.
4506 (Fgarbage_collect): Compute overall total using a double, so that
4507 integer overflow is less likely to be a problem. Check for overflow
4508 when converting back to an integer.
4509 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4510 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4511 These were 'int' variables that could overflow on 64-bit hosts;
4512 they were never used, so remove them instead of repairing them.
4513 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
4514 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4515 Previously, this ceilinged at INT_MAX, but that doesn't work on
4516 64-bit machines.
4517 (allocate_pseudovector): Don't use EMACS_INT when int would do.
4518
4519 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
4520 (allocate_vectorlike): Check for ptrdiff_t overflow.
4521 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4522 when a (possibly-narrower) signed value would do just as well.
4523 We prefer using signed arithmetic, to avoid comparison confusion.
4524
4525 * alloc.c: Catch some string size overflows that we were missing.
4526 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4527 for convenience in STRING_BYTES_MAX.
4528 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4529 The definition here is exact; the one in lisp.h was approximate.
4530 (allocate_string_data): Check for string overflow. This catches
4531 some instances we weren't catching before. Also, it catches
4532 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4533 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4534 and ptrdiff_t and EMACS_INT are both 64 bits.
4535
4536 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4537 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
4538 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
4539
4540 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4541
4542 * alloc.c (Fmake_string): Check for out-of-range init.
4543
4544 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4545
4546 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4547
4548 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4549
4550 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4551 xg_get_default_scrollbar_width.
4552
4553 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4554 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4555 (style_changed_cb): Call update_theme_scrollbar_width and call
4556 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4557 all frames (Bug#8505).
4558 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4559 Call gtk_window_set_resizable if HAVE_GTK3.
4560 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4561 and height if HAVE_GTK3 (Bug#8505).
4562 (scroll_bar_width_for_theme): New variable.
4563 (update_theme_scrollbar_width): New function.
4564 (xg_get_default_scrollbar_width): Move code to
4565 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4566 (xg_initialize): Call update_theme_scrollbar_width.
4567
4568 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4569
4570 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4571
4572 2011-06-12 Martin Rudalics <rudalics@gmx.at>
4573
4574 * frame.c (make_frame): Call other_buffer_safely instead of
4575 other_buffer.
4576
4577 * window.c (temp_output_buffer_show): Call display_buffer with
4578 second argument Vtemp_buffer_show_specifiers and reset latter
4579 immediately after the call.
4580 (Vtemp_buffer_show_specifiers): New variable.
4581 (auto_window_vscroll_p, next_screen_context_lines)
4582 (Vscroll_preserve_screen_position): Remove leading asterisks from
4583 doc-strings.
4584
4585 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4586
4587 Fix minor problems found by GCC 4.6.0 static checking.
4588 * buffer.c (Qclone_number): Remove for now, as it's unused.
4589 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4590 (record_buffer): Remove unused local.
4591 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4592 (set_frame_buffer_list): Remove; unused.
4593 * frame.h (other_visible_frames): Remove decl.
4594 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4595 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4596 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4597 if HAVE_GPM.
4598 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4599 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4600 Define only if HAVE_GPM.
4601 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4602 (update_hints_inhibit): Remove; never set. All uses removed.
4603 * widgetprv.h (emacsFrameClassRec): Remove decl.
4604 * window.c (delete_deletable_window): Now returns void, since it
4605 wasn't returning anything.
4606 (compare_window_configurations): Remove unused locals.
4607 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4608 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4609 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4610 the same widths as pointers. This follows up on the 2011-05-06 patch.
4611 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4612 * xterm.h: Likewise.
4613 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4614
4615 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
4616
4617 * makefile.w32-in: Update dependencies.
4618 (LISP_H): Add lib/intprops.h.
4619
4620 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4621
4622 * image.c (gif_load): Add animation frame delay to the metadata.
4623 (syms_of_image): Use DEFSYM. New symbol `delay'.
4624
4625 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4626
4627 * window.c (delete_deletable_window): Re-add.
4628 (Fset_window_configuration): Rewrite to handle dead buffers and
4629 consequently deletable windows.
4630 (window_tree, Fwindow_tree): Remove. Supply functionality in
4631 window.el.
4632 (compare_window_configurations): Simplify code.
4633
4634 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4635
4636 * image.c (imagemagick_load_image): Fix type mismatch.
4637 (Fimagemagick_types): Likewise.
4638
4639 * window.h (replace_buffer_in_windows): Declare.
4640
4641 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4642
4643 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4644 Qclone_number. Remove external declaration of Qdelete_window.
4645 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4646 code.
4647 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4648 Run Qbuffer_list_update_hook if allowed.
4649 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4650 buffer list implementation.
4651 (other_buffer_safely): New function.
4652 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4653 calls to replace_buffer_in_windows and
4654 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4655 if allowed.
4656 (record_buffer): Inhibit quitting and rewrite using quittable
4657 functions. Run Qbuffer_list_update_hook if allowed.
4658 (Frecord_buffer, Funrecord_buffer): New functions.
4659 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4660 Move switch-to-buffer to window.el.
4661 (bury-buffer): Move to window.el.
4662 (Vbuffer_list_update_hook): New variable.
4663
4664 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4665 section.
4666
4667 * window.h (resize_frame_windows): Move up in code.
4668 (Fwindow_frame): Remove EXFUN.
4669 (replace_buffer_in_all_windows): Remove prototype.
4670 (replace_buffer_in_windows_safely): Add prototype.
4671
4672 * window.c: Declare Qdelete_window static again. Move down
4673 declaration of select_count.
4674 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4675 (Fother_window): Move to window.el.
4676 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4677 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4678 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4679 window.el.
4680 (replace_buffer_in_windows): Implement by calling
4681 Qreplace_buffer_in_windows.
4682 (replace_buffer_in_all_windows): Remove with some functionality
4683 moved into replace_buffer_in_windows_safely.
4684 (replace_buffer_in_windows_safely): New function.
4685 (select_window_norecord, select_frame_norecord): Move in front
4686 of run_window_configuration_change_hook. Remove now obsolete
4687 declarations.
4688 (Fset_window_buffer): Rewrite doc-string.
4689 Call Qrecord_window_buffer.
4690 (keys_of_window): Move binding for other-window to window.el.
4691
4692 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4693
4694 * dispextern.h (struct image): Replace data member, whose int_val
4695 and ptr_val fields were not used by anything, with a single
4696 lisp_val object.
4697
4698 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4699 (gif_clear_image, gif_load, imagemagick_load_image)
4700 (gs_clear_image, gs_load): Callers changed.
4701
4702 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4703
4704 * buffer.h: Include <time.h>, for time_t.
4705 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4706
4707 Fix minor problems found by static checking.
4708
4709 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4710
4711 Make identifiers static if they are not used in other modules.
4712 * data.c (Qcompiled_function, Qframe, Qvector):
4713 * image.c (QimageMagick, Qsvg):
4714 * minibuf.c (Qmetadata):
4715 * window.c (resize_window_check, resize_root_window): Now static.
4716 * window.h (resize_window_check, resize_root_window): Remove decls.
4717
4718 * window.c (window_deletion_count, delete_deletable_window):
4719 Remove; unused.
4720 (window_body_lines): Now static.
4721 (Fdelete_other_windows_internal): Mark vars as initialized.
4722 Make sure 'resize_failed' is initialized.
4723 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4724 (resize_window_apply): Remove unused local.
4725 * window.h (delete_deletable_window): Remove decl.
4726
4727 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
4728 (imagemagick_load_image): Fix pointer signedness problem by changing
4729 last arg from unsigned char * to char *. All uses changed.
4730 Also, fix a local for similar reasons.
4731 Remove unused locals. Remove locals to avoid shadowing.
4732 (fn_rsvg_handle_free): Remove; unused.
4733 (svg_load, svg_load_image): Fix pointer signedness problem.
4734 (imagemagick_load_image): Don't use garbage pointer image_wand.
4735
4736 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4737
4738 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
4739
4740 * image.c (gif_load): Fix omitted cast error introduced by
4741 2011-06-06 change.
4742
4743 2011-06-10 Martin Rudalics <rudalics@gmx.at>
4744
4745 * window.h (resize_proportionally, orig_total_lines)
4746 (orig_top_line): Remove from window structure.
4747 (set_window_height, set_window_width, change_window_heights)
4748 (Fdelete_window): Remove prototypes.
4749 (resize_frame_windows): Remove duplicate declaration.
4750
4751 2011-06-10 Eli Zaretskii <eliz@gnu.org>
4752
4753 * window.h (resize_frame_windows, resize_window_check)
4754 (delete_deletable_window, resize_root_window)
4755 (resize_frame_windows): Declare prototypes.
4756
4757 * window.c (resize_window_apply): Make definition be "static" to
4758 match the prototype.
4759
4760 2011-06-10 Martin Rudalics <rudalics@gmx.at>
4761
4762 * window.c: Remove declarations of Qwindow_size_fixed,
4763 window_min_size_1, window_min_size_2, window_min_size,
4764 size_window, window_fixed_size_p, enlarge_window, delete_window.
4765 Remove static from declaration of Qdelete_window, it's
4766 temporarily needed by Fbury_buffer.
4767 (replace_window): Don't assign orig_top_line and
4768 orig_total_lines.
4769 (Fdelete_window, delete_window): Remove. Window deletion is
4770 handled by window.el.
4771 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4772 Replace Fdelete_window calls with calls to Qdelete_window.
4773 (Fdelete_other_windows): Remove. Deleting other windows is
4774 handled by window.el.
4775 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4776 handled in window.el.
4777 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4778 Window minimum sizes are handled in window.el.
4779 (shrink_windows, size_window, set_window_height)
4780 (set_window_width, change_window_heights, window_height)
4781 (window_width, CURBEG, CURSIZE, enlarge_window)
4782 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4783 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4784 handled in window.el.
4785 (make_dummy_parent): Rename to make_parent_window and give it a
4786 second argument horflag.
4787 (make_window): Don't set resize_proportionally any more.
4788 (Fsplit_window): Remove. Windows are split in window.el.
4789 (save_restore_action, save_restore_orig_size)
4790 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4791 Resize mini windows in window.el.
4792 (grow_mini_window, shrink_mini_window): Implement by calling
4793 Qresize_root_window_vertically, resize_window_check and
4794 resize_window_apply.
4795 (saved_window, Fset_window_configuration, save_window_save):
4796 Do not handle orig_top_line, orig_total_lines, and
4797 resize_proportionally.
4798 (window_min_height, window_min_width): Move to window.el.
4799 (keys_of_window): Move bindings for delete-other-windows,
4800 split-window, delete-window and enlarge-window to window.el.
4801
4802 * buffer.c: Temporarily extern Qdelete_window.
4803 (Fbury_buffer): Temporarily call Qdelete_window instead of
4804 Fdelete_window (Fbury_buffer will move to window.el soon).
4805
4806 * frame.c (set_menu_bar_lines_1): Remove code handling
4807 orig_top_line and orig_total_lines.
4808
4809 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4810 set_window_height but set heights directly.
4811 (change_frame_size_1): Use resize_frame_windows.
4812
4813 * xdisp.c (init_xdisp): Don't use set_window_height but set
4814 heights directly.
4815
4816 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4817 Use resize_frame_windows instead of change_window_heights and run
4818 run_window_configuration_change_hook.
4819
4820 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4821 instead of change_window_heights and run
4822 run_window_configuration_change_hook.
4823
4824 2011-06-09 Martin Rudalics <rudalics@gmx.at>
4825
4826 * window.c (replace_window): Rename second argument REPLACEMENT to
4827 NEW. New third argument SETFLAG. Rewrite.
4828 (delete_window, make_dummy_parent): Call replace_window with
4829 third argument 1.
4830 (window_list_1): Move down in code.
4831 (run_window_configuration_change_hook): Move set_buffer part
4832 before select_frame_norecord part in order to unwind correctly.
4833 Rename count1 to count.
4834 (recombine_windows, delete_deletable_window, resize_root_window)
4835 (Fdelete_other_windows_internal)
4836 (Frun_window_configuration_change_hook, make_parent_window)
4837 (resize_window_check, resize_window_apply, Fresize_window_apply)
4838 (resize_frame_windows, Fsplit_window_internal)
4839 (Fdelete_window_internal, Fresize_mini_window_internal):
4840 New functions.
4841 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4842
4843 2011-06-08 Martin Rudalics <rudalics@gmx.at>
4844
4845 * window.h (window): Add some new members to window structure -
4846 normal_lines, normal_cols, new_total, new_normal, clone_number,
4847 splits, nest, prev_buffers, next_buffers.
4848 (WINDOW_TOTAL_SIZE): Move here from window.c.
4849 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
4850
4851 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4852 Remove.
4853 (make_dummy_parent): Set new members of windows structure.
4854 (make_window): Move down in code. Handle new members of window
4855 structure.
4856 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4857 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4858 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4859 (Fset_window_prev_buffers, Fwindow_next_buffers)
4860 (Fset_window_next_buffers, Fset_window_clone_number):
4861 New functions.
4862 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4863 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4864 Doc-string fixes.
4865 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4866 Argument WINDOW can be now internal window too.
4867 (Fwindow_use_time): Move up in code.
4868 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4869 Rewrite doc-string.
4870 (Fset_window_configuration, saved_window)
4871 (Fcurrent_window_configuration, save_window_save): Handle new
4872 members of window structure.
4873 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4874 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4875 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4876 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4877 Qget_mru_window, Qresize_root_window,
4878 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4879 Qauto_buffer_name; staticpro them.
4880
4881 2011-06-07 Martin Rudalics <rudalics@gmx.at>
4882
4883 * window.c (Fwindow_total_size, Fwindow_left_column)
4884 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4885 (Fwindow_list_1): New functions.
4886 (window_box_text_cols): Replace with window_body_cols.
4887 (Fwindow_width, Fscroll_left, Fscroll_right):
4888 Use window_body_cols instead of window_box_text_cols.
4889 (delete_window, Fset_window_configuration):
4890 Call delete_all_subwindows with window as argument.
4891 (delete_all_subwindows): Take a window as argument and not a
4892 structure. Rewrite.
4893 (window_loop): Remove handling of GET_LRU_WINDOW and
4894 GET_LARGEST_WINDOW.
4895 (Fget_lru_window, Fget_largest_window): Move to window.el.
4896
4897 * window.h: Extern window_body_cols instead of
4898 window_box_text_cols. delete_all_subwindows now takes a
4899 Lisp_Object as argument.
4900
4901 * indent.c (compute_motion, Fcompute_motion):
4902 Use window_body_cols instead of window_box_text_cols.
4903
4904 * frame.c (delete_frame): Call delete_all_subwindows with root
4905 window as argument.
4906
4907 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4908
4909 * fns.c (Fputhash): Document return value.
4910
4911 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
4912
4913 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4914
4915 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4916
4917 Cons<->int and similar integer overflow fixes (Bug#8794).
4918
4919 Check for overflow when converting integer to cons and back.
4920 * charset.c (Fdefine_charset_internal, Fdecode_char):
4921 Use cons_to_unsigned to catch overflow.
4922 (Fencode_char): Use INTEGER_TO_CONS.
4923 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4924 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4925 * data.c (long_to_cons, cons_to_long): Remove.
4926 (cons_to_unsigned, cons_to_signed): New functions.
4927 These signal an error for invalid or out-of-range values.
4928 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4929 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4930 * font.c (Ffont_variation_glyphs):
4931 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4932 * lisp.h: Include <intprops.h>.
4933 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4934 (cons_to_signed, cons_to_unsigned): New decls.
4935 (long_to_cons, cons_to_long): Remove decls.
4936 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4937 (Fprimitive_undo): Use CONS_TO_INTEGER.
4938 * xfns.c (Fx_window_property): Likewise.
4939 * xselect.c: Include <limits.h>.
4940 (x_own_selection, selection_data_to_lisp_data):
4941 Use INTEGER_TO_CONS.
4942 (x_handle_selection_request, x_handle_selection_clear)
4943 (x_get_foreign_selection, Fx_disown_selection_internal)
4944 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4945 (lisp_data_to_selection_data): Use cons_to_unsigned.
4946 (x_fill_property_data): Use cons_to_signed.
4947 Report values out of range.
4948
4949 Check for buffer and string overflow more precisely.
4950 * buffer.h (BUF_BYTES_MAX): New macro.
4951 * lisp.h (STRING_BYTES_MAX): New macro.
4952 * alloc.c (Fmake_string):
4953 * character.c (string_escape_byte8):
4954 * coding.c (coding_alloc_by_realloc):
4955 * doprnt.c (doprnt):
4956 * editfns.c (Fformat):
4957 * eval.c (verror):
4958 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4959 since they may not be the same number.
4960 * editfns.c (Finsert_char):
4961 * fileio.c (Finsert_file_contents):
4962 Likewise for BUF_BYTES_MAX.
4963
4964 * image.c: Use ptrdiff_t, not int, for sizes.
4965 (slurp_file): Switch from int to ptrdiff_t.
4966 All uses changed.
4967 (slurp_file): Check that file size fits in both size_t (for
4968 malloc) and ptrdiff_t (for sanity and safety).
4969
4970 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4971 if b->modtime has its maximal value.
4972
4973 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4974
4975 Don't assume time_t can fit into int.
4976 * buffer.h (struct buffer.modtime): Now time_t, not int.
4977 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4978 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4979
4980 Minor fixes for signed vs unsigned integers.
4981 * character.h (MAYBE_UNIFY_CHAR):
4982 * charset.c (maybe_unify_char):
4983 * keyboard.c (read_char, reorder_modifiers):
4984 XINT -> XFASTINT, since the integer must be nonnegative.
4985 * ftfont.c (ftfont_spec_pattern):
4986 * keymap.c (access_keymap, silly_event_symbol_error):
4987 XUINT -> XFASTINT, since the integer must be nonnegative.
4988 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4989 since it makes no difference and we prefer signed.
4990 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4991 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4992 nonnegative.
4993
4994 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4995
4996 * window.h (Fwindow_frame): Declare.
4997
4998 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4999
5000 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5001 (SPARE_MEMORY): Always define.
5002 (LARGE_REQUEST): Remove.
5003 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5004
5005 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5006
5007 * lisp.h: Move EXFUNS for Fframe_root_window,
5008 Fframe_first_window and Fset_frame_selected_window to window.h.
5009
5010 * window.h: Move EXFUNS for Fframe_root_window,
5011 Fframe_first_window and Fset_frame_selected_window here from
5012 lisp.h.
5013
5014 * frame.c (Fwindow_frame, Fframe_first_window)
5015 (Fframe_root_window, Fframe_selected_window)
5016 (Fset_frame_selected_window): Move to window.c.
5017 (Factive_minibuffer_window): Move to minibuf.c.
5018 (Fother_visible_frames_p): New function.
5019
5020 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5021
5022 * window.c (decode_window, decode_any_window): Move up in code.
5023 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5024 (inhibit_frame_unsplittable): Remove unused variable.
5025 (Fwindow_buffer): Move up and rewrite doc-string.
5026 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5027 (Fwindow_prev): New functions.
5028 (Fwindow_frame): Move here from frame.c. Accept any window as
5029 argument.
5030 (Fframe_root_window, Fframe_first_window)
5031 (Fframe_selected_window): Move here from frame.c. Accept frame
5032 or arbitrary window as argument. Update doc-strings.
5033 (Fminibuffer_window): Move up in code.
5034 (Fwindow_minibuffer_p): Move up in code and simplify.
5035 (Fset_frame_selected_window): Move here from frame.c.
5036 Marginal rewrite.
5037 (Fselected_window, select_window, Fselect_window): Move up in
5038 code. Minor doc-string fixes.
5039
5040 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5041
5042 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5043 Do not assume that spare memory exists; that assumption is valid
5044 only if SYSTEM_MALLOC.
5045 (LARGE_REQUEST): New macro, so that the issue of large requests
5046 is separated from the issue of spare memory.
5047
5048 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5049
5050 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5051 format. (Bug#8806)
5052
5053 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5054
5055 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5056 before statements.
5057
5058 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5059
5060 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5061
5062 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5063
5064 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5065 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5066
5067 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5068
5069 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5070
5071 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
5072
5073 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5074 (x_clipboard_manager_save): Add return value.
5075 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5076 New error handlers.
5077 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5078 Obey Vx_select_enable_clipboard_manager. Catch errors in
5079 x_clipboard_manager_save (Bug#8779).
5080 (Vx_select_enable_clipboard_manager): New variable.
5081 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
5082
5083 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
5084
5085 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5086
5087 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5088
5089 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5090 in the current matrix if keep_current_p is non-zero.
5091
5092 2011-06-04 Eli Zaretskii <eliz@gnu.org>
5093
5094 * bidi.c (bidi_level_of_next_char): Fix last change.
5095
5096 2011-06-03 Eli Zaretskii <eliz@gnu.org>
5097
5098 Support bidi reordering of text covered by display properties.
5099
5100 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5101 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5102 (bidi_cache_search, bidi_cache_iterator_state)
5103 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5104 (bidi_level_of_next_char, bidi_move_to_visually_next):
5105 Support character positions inside a run of characters covered by a
5106 display string.
5107 (bidi_paragraph_init, bidi_resolve_explicit_1)
5108 (bidi_level_of_next_char): Call bidi_fetch_char and
5109 bidi_fetch_char_advance instead of FETCH_CHAR and
5110 FETCH_CHAR_ADVANCE.
5111 (bidi_init_it): Initialize new members.
5112 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5113 definitions.
5114 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5115 instead of using explicit *_CHAR codes.
5116 (bidi_resolve_explicit, bidi_resolve_weak):
5117 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
5118 bidirectional text is supported only in multibyte buffers.
5119 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5120 it to initialize the frame_window_p member of struct bidi_it.
5121 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5122 (bidi_resolve_explicit, bidi_resolve_weak)
5123 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5124 bidi_it->nchars is non-positive.
5125 (bidi_level_of_next_char): Don't try to lookup the cache for the
5126 next/previous character if nothing is cached there yet, or if we
5127 were just reseat()'ed to a new position.
5128
5129 * xdisp.c (set_cursor_from_row): Set start and stop points
5130 according to the row's direction when priming the loop that looks
5131 for the glyph on which to display cursor.
5132 (single_display_spec_intangible_p): Function deleted.
5133 (display_prop_intangible_p): Reimplement to call
5134 handle_display_spec instead of single_display_spec_intangible_p.
5135 Accept 3 additional arguments needed by handle_display_spec.
5136 This fixes incorrect cursor motion across display property with complex
5137 values: lists, `(when COND...)' forms, etc.
5138 (single_display_spec_string_p): Support property values that are
5139 lists with the argument STRING its top-level element.
5140 (display_prop_string_p): Fix the condition for processing a
5141 property that is a list to be consistent with handle_display_spec.
5142 (handle_display_spec): New function, refactored from the
5143 last portion of handle_display_prop.
5144 (compute_display_string_pos): Accept additional argument
5145 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5146 value of a `display' property is a "replacing spec".
5147 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5148 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5149 the display property, but just return a value indicating whether
5150 the display property will replace the characters it covers.
5151 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5152 frame_window_p members of struct bidi_it.
5153 (compute_display_string_pos, compute_display_string_end):
5154 New functions.
5155 (push_it): Accept second argument POSITION, where pop_it should
5156 jump to continue iteration.
5157 (reseat_1): Initialize bidi_it.disp_pos.
5158
5159 * keyboard.c (adjust_point_for_property): Adjust the call to
5160 display_prop_intangible_p to its new signature.
5161
5162 * dispextern.h (struct bidi_it): New member frame_window_p.
5163 (bidi_init_it): Update prototypes.
5164 (display_prop_intangible_p): Update prototype.
5165 (compute_display_string_pos, compute_display_string_end):
5166 Declare prototypes.
5167 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5168 EMACS_INT.
5169
5170 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
5171
5172 Malloc failure behavior now depends on size of allocation.
5173 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5174 * lisp.h: Change signatures accordingly.
5175 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5176 All callers changed. (Bug#8762)
5177
5178 * gnutls.c: Use Emacs's memory allocators.
5179 Without this change, the gnutls library would invoke malloc etc.
5180 directly, which causes problems on non-SYNC_INPUT hosts, and which
5181 runs afoul of improving memory_full behavior. (Bug#8761)
5182 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5183 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5184 xfree instead of the default malloc, realloc, free.
5185 (Fgnutls_boot): No need to check for memory allocation failure,
5186 since xmalloc does that for us.
5187
5188 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
5189 * category.c (hash_get_category_set):
5190 * ccl.c (ccl_driver):
5191 * charset.c (Fdefine_charset_internal):
5192 * charset.h (struct charset.hash_index):
5193 * composite.c (get_composition_id, gstring_lookup_cache)
5194 (composition_gstring_put_cache):
5195 * composite.h (struct composition.hash_index):
5196 * dispextern.h (struct image.hash):
5197 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5198 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5199 (hashfn_equal, hashfn_user_defined, make_hash_table)
5200 (maybe_resize_hash_table, hash_lookup, hash_put)
5201 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5202 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5203 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5204 * image.c (make_image, search_image_cache, lookup_image)
5205 (xpm_put_color_table_h):
5206 * lisp.h (struct Lisp_Hash_Table):
5207 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
5208 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
5209 for hashes and hash indexes, instead of 'unsigned' and 'int'.
5210 * alloc.c (allocate_vectorlike):
5211 Check for overflow in vector size calculations.
5212 * ccl.c (ccl_driver):
5213 Check for overflow when converting EMACS_INT to int.
5214 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5215 need to be updated by these changes.
5216 * fns.c (make_hash_table, maybe_resize_hash_table):
5217 Check for integer overflow with large hash tables.
5218 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5219 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5220 (SXHASH_REDUCE): New macro.
5221 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5222 Use it instead of discarding useful hash info with large hash values.
5223 (sxhash_float): New function.
5224 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5225 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
5226 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5227 Rewrite to use FIXNUM_BITS, as this simplifies things.
5228 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5229 Adjust signatures to match updated version of code.
5230 (consing_since_gc): Now EMACS_INT, since a single hash table can
5231 use more than INT_MAX bytes.
5232
5233 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5234
5235 Make it possible to build with GCC-4.6+ -O2 -flto.
5236
5237 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5238
5239 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5240
5241 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5242 Call minibuffer-inactive-mode.
5243
5244 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
5245
5246 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5247 Update dependencies.
5248
5249 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5250
5251 * data.c (init_data): Remove code for UTS, this system is not
5252 supported anymore.
5253
5254 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5255
5256 Don't force ./temacs to start in terminal mode.
5257
5258 * frame.c (make_initial_frame): Initialize faces in all cases, not
5259 only when CANNOT_DUMP is defined.
5260 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5261
5262 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5263
5264 * dispnew.c (add_window_display_history): Use const for the string
5265 pointer. Remove declaration, not needed.
5266
5267 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5268
5269 Use 'inline', not 'INLINE'.
5270 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
5271 * alloc.c, fontset.c (INLINE): Remove.
5272 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5273 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5274 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5275 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5276 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5277
5278 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5279
5280 Make it possible to run ./temacs.
5281
5282 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5283 syms_of_callproc does the same thing. Remove test for
5284 "initialized", do it in the caller.
5285 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5286
5287 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5288
5289 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5290 (read_minibuf): Use get_minibuffer.
5291 (syms_of_minibuf): Use DEFSYM.
5292 (Qmetadata): New var.
5293 * data.c (Qbuffer): Don't make it static.
5294 (syms_of_data): Use DEFSYM.
5295
5296 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5297
5298 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5299 (CCL_CODE_MIN): New macro.
5300
5301 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5302
5303 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5304
5305 * eval.c (Qdebug): Now static.
5306 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5307 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5308 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5309
5310 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5311
5312 * image.c: Various fixes to ImageMagick code comments.
5313 (Fimagemagick_types): Doc fix.
5314
5315 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5316
5317 Minor fixes prompted by GCC 4.6.0 warnings.
5318
5319 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5320
5321 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5322 (x_clipboard_manager_save_all): Move extern decl to ...
5323 * xterm.h: ... here, so that it can be checked for consistency.
5324
5325 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5326
5327 * xselect.c (x_clipboard_manager_save_frame)
5328 (x_clipboard_manager_save_all): New functions.
5329 (Fx_clipboard_manager_save): Lisp function deleted.
5330
5331 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5332 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5333
5334 * xterm.h: Update prototype.
5335
5336 2011-05-28 William Xu <william.xwl@gmail.com>
5337
5338 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5339 exiting (Bug#8239).
5340
5341 2011-05-28 Jim Meyering <meyering@redhat.com>
5342
5343 Avoid a sign-extension bug in crypto_hash_function.
5344 * fns.c (to_uchar): Define.
5345 (crypto_hash_function): Use it to convert some newly-signed
5346 variables to unsigned, to avoid sign-extension bugs. For example,
5347 without this change, (md5 "truc") would evaluate to
5348 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5349 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
5350 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
5351
5352 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5353
5354 Integer overflow fixes.
5355
5356 * dbusbind.c: Serial number integer overflow fixes.
5357 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
5358 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5359 to hold a serial number that is too large for a fixnum.
5360 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5361 Check for serial numbers out of range. Decode any serial number
5362 that was so large that it became a float. (Bug#8722)
5363
5364 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5365 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5366 Use XFASTINT rather than XUINT when numbers are nonnegative.
5367 (xd_append_arg, Fdbus_method_return_internal):
5368 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5369 arguments, check that Lisp number is nonnegative, rather than
5370 silently wrapping negative numbers around. (Bug#8722)
5371 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
5372 (Bug#8722)
5373
5374 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5375
5376 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5377
5378 ccl: add integer overflow checks
5379 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5380 (IN_INT_RANGE): New macros.
5381 (ccl_driver): Use them to check for integer overflow when
5382 decoding a CCL program. Many of the new checks are whether XINT (x)
5383 fits in int; it doesn't always, on 64-bit hosts. The new version
5384 doesn't catch all possible integer overflows, but it's an
5385 improvement. (Bug#8719)
5386
5387 * alloc.c (make_event_array): Use XINT, not XUINT.
5388 There's no need for unsigned here.
5389
5390 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5391 This follows up to the 2011-05-06 change that substituted uintptr_t
5392 for EMACS_INT. This case wasn't caught back then.
5393
5394 Rework Fformat to avoid integer overflow issues.
5395 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5396 now (part of C89). Include <verify.h>.
5397 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5398 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5399 (Fformat): Avoid the prepass trying to compute sizes; it was only
5400 approximate and thus did not catch overflow reliably. Instead, walk
5401 through the format just once, formatting and computing sizes as we go,
5402 checking for integer overflow at every step, and allocating a larger
5403 buffer as needed. Keep track separately whether the format is
5404 multibyte. Keep only the most-recently calculated precision, rather
5405 than them all. Record whether each argument has been converted to
5406 string. Use EMACS_INT, not int, for byte and char and arg counts.
5407 Support field widths and precisions larger than INT_MAX. Avoid
5408 sprintf's undefined behavior with conversion specifications such as %#d
5409 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5410 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5411 formatting out-of-range floating point numbers with int
5412 formats. (Bug#8668)
5413
5414 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5415
5416 * data.c: Avoid integer truncation in expressions involving floats.
5417 * data.c: Include <intprops.h>.
5418 (arith_driver): When there's an integer overflow in an expression
5419 involving floating point, convert the integers to floating point
5420 so that the resulting value does not suffer from catastrophic
5421 integer truncation. For example, on a 64-bit host (* 4
5422 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5423 Do not rely on undefined behavior after integer overflow.
5424
5425 merge count_size_as_multibyte, parse_str_to_multibyte
5426 * character.c, character.h (count_size_as_multibyte):
5427 Rename from parse_str_to_multibyte; all uses changed.
5428 Check for integer overflow.
5429 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5430 since it's now a duplicate of the other. This is more of
5431 a character than a buffer op, so better that it's in character.c.
5432 * fns.c, print.c: Adjust to above changes.
5433
5434 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5435
5436 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5437
5438 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5439
5440 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5441 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5442 (x_clipboard_manager_save): Now static.
5443 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5444
5445 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5446 (crypto_hash_function): Now static.
5447 Fix pointer signedness problems. Avoid unnecessary initializations.
5448
5449 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
5450
5451 * termhooks.h (Vselection_alist): Make it terminal-local.
5452
5453 * terminal.c (create_terminal): Initialize it.
5454
5455 * xselect.c: Support for clipboard managers.
5456 (Vselection_alist): Move to termhooks.h as terminal-local var.
5457 (LOCAL_SELECTION): New macro.
5458 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5459 (symbol_to_x_atom): Remove gratuitous arg.
5460 (x_handle_selection_request, lisp_data_to_selection_data)
5461 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
5462 (x_own_selection, x_get_local_selection, x_convert_selection):
5463 New arg, specifying work frame. Use terminal-local Vselection_alist.
5464 (some_frame_on_display): Delete unused function.
5465 (Fx_own_selection_internal, Fx_get_selection_internal)
5466 (Fx_disown_selection_internal, Fx_selection_owner_p)
5467 (Fx_selection_exists_p): New optional frame arg.
5468 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5469 (x_handle_selection_clear): Don't treat other terminals with the
5470 same keyboard specially. Use the terminal-local Vselection_alist.
5471 (x_clear_frame_selections): Use Frun_hook_with_args.
5472
5473 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5474
5475 * xterm.h: Add support for those atoms.
5476
5477 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
5478
5479 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5480 (converted_selections, conversion_fail_tag): New global variables.
5481 (x_selection_request_lisp_error): Free the above.
5482 (x_get_local_selection): Remove unnecessary code.
5483 (x_reply_selection_request): Args changed; handle arbitrary array
5484 of converted selections stored in converted_selections.
5485 Separate the XChangeProperty and SelectionNotify steps.
5486 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5487 (x_convert_selection): New function.
5488 (x_handle_selection_event): Simplify.
5489 (x_get_foreign_selection): Don't ignore incoming requests while
5490 waiting for an answer; this will fail when we implement
5491 SAVE_TARGETS, and seems unnecessary anyway.
5492 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5493 (Vx_sent_selection_functions): Doc fix.
5494
5495 2011-05-26 Leo Liu <sdl.web@gmail.com>
5496
5497 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5498
5499 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5500
5501 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5502
5503 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5504 for fringe update if it has periodic bitmap.
5505 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
5506 and fringe_bitmap_periodic_p.
5507
5508 * fringe.c (get_fringe_bitmap_data): New function.
5509 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5510 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5511 row. Mark glyph row for fringe update if periodicity changed.
5512
5513 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5514 for fringe update unless it has periodic bitmap.
5515
5516 2011-05-25 Kenichi Handa <handa@m17n.org>
5517
5518 * xdisp.c (get_next_display_element): Set correct it->face_id for
5519 a static composition.
5520
5521 2011-05-24 Leo Liu <sdl.web@gmail.com>
5522
5523 * deps.mk (fns.o):
5524 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5525
5526 * fns.c (crypto_hash_function, Fsha1): New function.
5527 (Fmd5): Use crypto_hash_function.
5528 (syms_of_fns): Add Ssha1.
5529
5530 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5531
5532 * gnutls.c: Remove unused macros.
5533 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5534 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5535 Remove macros that are defined and never used.
5536 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5537
5538 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5539
5540 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5541 (Fx_get_selection_internal): Minor cleanup.
5542 (Fx_own_selection_internal): Rename arguments for consistency with
5543 select.el.
5544
5545 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5546
5547 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5548
5549 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5550
5551 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5552
5553 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5554
5555 * dispnew.c (scrolling_window): Don't exclude the case that the
5556 last enabled row in the desired matrix touches the bottom boundary.
5557
5558 2011-05-21 Glenn Morris <rgm@gnu.org>
5559
5560 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
5561 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5562 and add some more files.
5563
5564 2011-05-20 Eli Zaretskii <eliz@gnu.org>
5565
5566 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5567 report_file_error introduced by the change from 2011-05-07.
5568
5569 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5570
5571 * systime.h (Time): Define only if emacs is defined.
5572 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5573 where the include path doesn't have X11/X.h by default. See
5574 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5575
5576 2011-05-20 Kenichi Handa <handa@m17n.org>
5577
5578 * composite.c (find_automatic_composition): Fix previous change.
5579
5580 2011-05-20 Glenn Morris <rgm@gnu.org>
5581
5582 * lisp.mk: New file, split from Makefile.in.
5583 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5584 (shortlisp): Remove.
5585 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5586
5587 2011-05-19 Glenn Morris <rgm@gnu.org>
5588
5589 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5590 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5591 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5592 (lisp): Set the order to that of loadup.el.
5593 (shortlisp): Make it a copy of $lisp.
5594 (SOME_MACHINE_LISP): Remove.
5595 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5596 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5597
5598 2011-05-18 Kenichi Handa <handa@m17n.org>
5599
5600 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5601 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5602 (find_automatic_composition): Mostly rewrite for efficiency.
5603
5604 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
5605
5606 * makefile.w32-in: Update dependencies.
5607
5608 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5609
5610 * menu.c: Include limits.h (fixes the MS-Windows build broken by
5611 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
5612
5613 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
5614
5615 Fix some integer overflow issues, such as string length overflow.
5616
5617 * insdel.c (count_size_as_multibyte): Check for string overflow.
5618
5619 * character.c (lisp_string_width): Check for string overflow.
5620 Use EMACS_INT, not int, for string indexes and lengths; in
5621 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5622 the resulting string length overflows an EMACS_INT; instead,
5623 report a string overflow if no precision given. When checking for
5624 precision exhaustion, use a check that cannot possibly have
5625 integer overflow. (Bug#8675)
5626 * character.h (lisp_string_width): Adjust to new signature.
5627
5628 * alloc.c (string_overflow): New function.
5629 (Fmake_string): Use it. This doesn't change behavior, but saves
5630 a few bytes and will simplify future changes.
5631 * character.c (string_escape_byte8): Likewise.
5632 * lisp.h (string_overflow): New decl.
5633
5634 Fixups, following up to the user-interface timestamp change.
5635 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5636 for UI timestamps, instead of unsigned long.
5637 * msdos.c (mouse_get_pos): Likewise.
5638 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
5639 * w32gui.h (Time): Define by including "systime.h" rather than by
5640 declaring it ourselves. (Bug#8664)
5641
5642 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5643 * image.c (clear_image_cache): Likewise.
5644
5645 * term.c (term_mouse_position): Don't assume time_t wraparound.
5646
5647 Be more systematic about user-interface timestamps.
5648 Before, the code sometimes used 'Time', sometimes 'unsigned long',
5649 and sometimes 'EMACS_UINT', to represent these timestamps.
5650 This change causes it to use 'Time' uniformly, as that's what X uses.
5651 This makes the code easier to follow, and makes it easier to catch
5652 integer overflow bugs such as Bug#8664.
5653 * frame.c (Fmouse_position, Fmouse_pixel_position):
5654 Use Time, not unsigned long, for user-interface timestamps.
5655 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5656 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5657 * keyboard.h (last_event_timestamp): Likewise.
5658 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5659 * menu.h (xmenu_show): Likewise.
5660 * term.c (term_mouse_position): Likewise.
5661 * termhooks.h (struct input_event.timestamp): Likewise.
5662 (struct terminal.mouse_position_hook): Likewise.
5663 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5664 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5665 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5666 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5667 what it was before.
5668 * menu.h, termhooks.h: Include "systime.h", for Time.
5669
5670 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5671 Don't assume that the difference between two unsigned long values
5672 can fit into an integer. At this point, we know button_down_time
5673 <= event->timestamp, so the difference must be nonnegative, so
5674 there's no need to cast the result if double-click-time is
5675 nonnegative, as it should be; check that it's nonnegative, just in
5676 case. This bug is triggered when events are more than 2**31 ms
5677 apart (about 25 days). (Bug#8664)
5678
5679 * xselect.c (last_event_timestamp): Remove duplicate decl.
5680 (x_own_selection): Remove needless cast to unsigned long.
5681
5682 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5683 that always fit in int. Use a sentinel instead of a counter, to
5684 avoid a temp and to allay GCC's concerns about possible int overflow.
5685 * frame.h (struct frame): Use int for menu_bar_items_used
5686 instead of EMACS_INT, since it always fits in int.
5687
5688 * menu.c (grow_menu_items): Check for int overflow.
5689
5690 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5691
5692 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5693 Before, the code was not consistent. These values cannot exceed
5694 2**31 - 1 so there's no need to make them unsigned.
5695 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5696 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5697 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5698 as modifiers.
5699 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5700
5701 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5702 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5703 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5704 presumably because the widths might not match.
5705
5706 * window.c (size_window): Avoid needless test at loop start.
5707
5708 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5709
5710 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5711
5712 2011-05-12 Drew Adams <drew.adams@oracle.com>
5713
5714 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5715
5716 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5717
5718 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5719 `width' to `bar_area_x' and `bar_area_width', respectively.
5720 (x_scroll_run): Take account of fringe background extension.
5721
5722 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5723 Rename local vars `left' and `width' to `bar_area_x' and
5724 `bar_area_width', respectively.
5725 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5726 background extension.
5727
5728 2011-05-10 Jim Meyering <meyering@redhat.com>
5729
5730 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5731
5732 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
5733
5734 * image.c (Finit_image_library): Return t for built-in image types,
5735 like pbm and xbm. (Bug#8640)
5736
5737 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5738
5739 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5740
5741 2011-05-07 Eli Zaretskii <eliz@gnu.org>
5742
5743 * w32console.c (Fset_screen_color): Doc fix.
5744 (Fget_screen_color): New function.
5745 (syms_of_ntterm): Defsubr it.
5746
5747 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5748 unlink the temporary file if Fcall_process didn't create it in the
5749 first place.
5750 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5751 child process will be redirected to a file specified with `:file'.
5752 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5753 cue to call_process_cleanup not to close that handle.
5754
5755 2011-05-07 Ben Key <bkey76@gmail.com>
5756
5757 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5758 one of two shell specific rules, either bootstrap-temacs-CMD or
5759 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5760 to the previous implementation of the bootstrap-temacs rule.
5761 The bootstrap-temacs-CMD rule is similar to the previous
5762 implementation of the bootstrap-temacs rule except that it
5763 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5764 variable.
5765
5766 These changes, along with some changes to nt/configure.bat,
5767 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5768 earlier fix to add support for --cflags and --ldflags options
5769 that include quotes so that it works whether make uses cmd or
5770 sh as the shell.
5771
5772 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
5773
5774 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5775 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5776 is a constant.
5777 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5778 a string. Handle both cases.
5779 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5780 (Fdbus_register_method): Use Qinvalid_function.
5781
5782 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
5783
5784 * makefile.w32-in: Update dependencies.
5785 (LISP_H): Add inttypes.h and stdin.h.
5786 (PROCESS_H): Add unistd.h.
5787
5788 2011-05-06 Eli Zaretskii <eliz@gnu.org>
5789
5790 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5791 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5792
5793 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
5794
5795 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5796
5797 * term.c (vfatal): Remove stray call to va_end.
5798 It's not needed and the C Standard doesn't allow it here anyway.
5799
5800 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5801 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5802
5803 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5804 bytes.
5805
5806 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5807
5808 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5809
5810 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5811
5812 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5813
5814 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5815
5816 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5817 * charset.c (Fdefine_charset_internal): Don't initialize
5818 charset.code_space[15]. The value was garbage, on hosts with
5819 32-bit int (Bug#8600).
5820
5821 * lread.c (read_integer): Be more consistent with string-to-number.
5822 Use string_to_number to do the actual conversion; this avoids
5823 rounding errors and fixes some other screwups. Without this fix,
5824 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5825 (digit_to_number): Move earlier, for benefit of read_integer.
5826 Return -1 if the digit is out of range for the base, -2 if it is
5827 not a digit in any supported base. (Bug#8602)
5828
5829 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5830
5831 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5832 to match comment at start of function. This also removes a
5833 GCC warning about overflow in a 32+64-bit port.
5834
5835 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5836
5837 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5838 Reported by Stefan Monnier in
5839 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
5840 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5841 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
5842
5843 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5844 (EMACS_UINTPTR): Likewise, with uintptr_t.
5845
5846 * lisp.h: Prefer 64-bit EMACS_INT if available.
5847 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5848 on 32-bit hosts that have 64-bit int, so that they can access
5849 large files.
5850 However, temporarily disable this change unless the temporary
5851 symbol WIDE_EMACS_INT is defined.
5852
5853 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5854
5855 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5856 This removes an assumption that EMACS_INT and long are the same
5857 width as pointers. The assumption is true for Emacs porting targets
5858 now, but we want to make other targets possible.
5859 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5860 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5861 In the rest of the code, change types of integers that hold casted
5862 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5863 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5864 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5865 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5866 No need to cast type when ORing.
5867 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5868 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5869 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5870 assume EMACS_INT is the same width as char *.
5871 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5872 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5873 Remove no-longer-needed casts.
5874 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5875 (xg_tool_bar_help_callback, xg_make_tool_item):
5876 Use EMACS_INTPTR to hold an integer
5877 that will be cast to void *; this can avoid a GCC warning
5878 if EMACS_INT is not the same width as void *.
5879 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5880 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5881 (current_message_1, set_message_1):
5882 Use a local to convert to proper width without a cast.
5883 * xmenu.c (dialog_selection_callback): Likewise.
5884
5885 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5886 Also, don't assume VALBITS / RAND_BITS is less than 5,
5887 and don't rely on undefined behavior when shifting a 1 left into
5888 the sign bit.
5889 * lisp.h (get_random): Change signature to match.
5890
5891 * lread.c (hash_string): Use size_t, not int, for hash computation.
5892 Normally we prefer signed values; but hashing is special, because
5893 it's better to use unsigned division on hash table sizes so that
5894 the remainder is nonnegative. Also, size_t is the natural width
5895 for hashing into memory. The previous code used 'int', which doesn't
5896 retain enough info to hash well into very large tables.
5897 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5898
5899 * dbusbind.c: Don't possibly lose pointer info when converting.
5900 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5901 Use XPNTR rather than XHASH, so that the high-order bits of
5902 the pointer aren't lost when converting through void *.
5903
5904 * eval.c (Fautoload): Don't double-shift a pointer.
5905
5906 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5907
5908 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
5909
5910 * gnutls.c (DEF_GNUTLS_FN):
5911 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5912
5913 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5914
5915 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5916 marker. (Bug#8610)
5917
5918 2011-05-05 Eli Zaretskii <eliz@gnu.org>
5919
5920 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5921 New version that can reserve upto 2GB of heap space.
5922
5923 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
5924
5925 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5926
5927 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5928
5929 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5930 `gnutls_certificate_set_x509_key_file'.
5931
5932 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
5933
5934 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5935 Update dependencies.
5936
5937 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5938
5939 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5940 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5941 Remove unused parameter `fildes'.
5942 * process.c (read_process_output, send_process): Don't pass it.
5943
5944 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5945
5946 Fix previous change: the library cache is defined in w32.c.
5947 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5948 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5949
5950 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5951
5952 Implement dynamic loading of GnuTLS on Windows.
5953
5954 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5955 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5956 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5957 Declare.
5958
5959 * gnutls.c (Qgnutls_dll): Define.
5960 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5961 (gnutls_*): Declare function pointers.
5962 (init_gnutls_functions): New function to initialize function pointers.
5963 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5964 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5965 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5966 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5967 (emacs_gnutls_write, emacs_gnutls_read)
5968 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5969 (Fgnutls_available_p): New function.
5970 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5971 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5972 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5973
5974 * image.c: Include w32.h.
5975 (Vimage_type_cache): Delete.
5976 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5977 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5978 (w32_delayed_load): Move to w32.c.
5979
5980 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5981
5982 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5983 (w32_delayed_load): Move from image.c. When loading a library, record
5984 its filename in the :loaded-from property of the library id.
5985 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5986 Initialize and staticpro them.
5987 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5988
5989 * process.c: Include lisp.h before w32.h, not after.
5990 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5991 instead of gnutls_record_check_pending.
5992
5993 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5994
5995 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5996
5997 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5998 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5999 as passed in.
6000
6001 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6002
6003 * xterm.c (x_set_frame_alpha): Do not set property on anything
6004 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6005
6006 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6007
6008 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6009
6010 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6011
6012 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6013 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6014 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6015 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6016 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6017 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6018 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6019 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6020 (Qgnutls_bootprop_callbacks_verify): Make static.
6021
6022 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6023
6024 * callproc.c: Indentation fixup.
6025
6026 * sysdep.c (wait_for_termination_1): Make static.
6027 (wait_for_termination, interruptible_wait_for_termination):
6028 Move after wait_for_termination_1.
6029
6030 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6031
6032 * sysdep.c (interruptible_wait_for_termination): New function
6033 which is like wait_for_termination, but allows keyboard
6034 interruptions.
6035
6036 * callproc.c (Fcall_process): Add (:file "file") as an option for
6037 the STDOUT buffer.
6038 (Fcall_process_region): Ditto.
6039
6040 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6041
6042 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6043 rather than `XVECTOR (FOO)->size'.
6044
6045 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6046 inttypes.h, as a gnulib replacement is used if it not available in
6047 system headers.
6048
6049 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6050
6051 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6052 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6053 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6054
6055 * coding.c (coding_alloc_by_realloc): Error out if destination
6056 will grow beyond MOST_POSITIVE_FIXNUM.
6057 (decode_coding_emacs_mule): Abort if there isn't enough place in
6058 charbuf for the composition carryover bytes. Reserve an extra
6059 space for up to 2 characters produced in a loop.
6060 (decode_coding_iso_2022): Abort if there isn't enough place in
6061 charbuf for the composition carryover bytes.
6062
6063 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6064
6065 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6066 aborting when %lld or %lll format is passed.
6067 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6068 %llo or %llx format is passed. (Bug#8545)
6069
6070 * window.c (window_scroll_line_based): Use a marker instead of
6071 simple variables to record original value of point. (Bug#7952)
6072
6073 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6074 produced by %s or %c overflows available buffer space. (Bug#8545)
6075
6076 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6077
6078 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
6079 (SIZE_MAX): Move defn after all includes, as they might #define it.
6080
6081 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6082
6083 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6084
6085 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6086
6087 * keyboard.c (Qdelayed_warnings_hook): Define.
6088 (command_loop_1): Run `delayed-warnings-hook'
6089 if Vdelayed_warnings_list is non-nil.
6090 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6091 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6092
6093 2011-04-28 Eli Zaretskii <eliz@gnu.org>
6094
6095 * doprnt.c (doprnt): Don't return value smaller than the buffer
6096 size if the message was truncated. (Bug#8545).
6097
6098 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6099
6100 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6101 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6102
6103 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6104
6105 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6106
6107 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
6108
6109 * makefile.w32-in: Update dependencies.
6110
6111 2011-04-27 Eli Zaretskii <eliz@gnu.org>
6112
6113 Improve `doprnt' and its usage. (Bug#8545)
6114 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6115 `format_end'. Remove support for %l as a conversion specifier.
6116 Don't use xrealloc. Improve diagnostics when the %l size modifier
6117 is used. Update the commentary.
6118
6119 * eval.c (verror): Simplify calculation of size_t.
6120
6121 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6122 messages.
6123
6124 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6125
6126 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6127 change.
6128
6129 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6130
6131 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6132 This makes this file independent of the recent pseudovector change.
6133
6134 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
6135
6136 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6137
6138 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
6139 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
6140 Remove unused local.
6141 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
6142
6143 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
6144 GCC 4.6.0 optimizes based on type-based alias analysis.
6145 For example, if b is of type struct buffer * and v of type struct
6146 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6147 != &v->size, and therefore "v->size = 1; b->size = 2; return
6148 v->size;" must therefore return 1. This assumption is incorrect
6149 for Emacs, since it type-puns struct Lisp_Vector * with many other
6150 types. To fix this problem, this patch adds a new type struct
6151 vectorlike_header that documents the constraints on layout of vectors
6152 and pseudovectors, and helps optimizing compilers not get fooled
6153 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6154 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
6155 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6156 the size member.
6157 (XSETPVECTYPE): Rewrite in terms of new macro.
6158 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6159 This is a bit clearer, and further avoids the possibility of
6160 undesirable aliasing.
6161 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
6162 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
6163 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6164 since Lisp_Subr is a special case (no "next" field).
6165 (ASIZE): Now uses header.size rather than size.
6166 All previous uses of XVECTOR (foo)->size replaced to use this macro,
6167 to avoid the hassle of writing XVECTOR (foo)->header.size.
6168 (struct vectorlike_header): New type.
6169 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6170 object, to help avoid aliasing.
6171 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6172 (SUBRP): Likewise, since Lisp_Subr is a special case.
6173 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6174 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6175 (struct Lisp_Hash_Table): Combine first two members into a single
6176 struct vectorlike_header member. All uses of "size" and "next" members
6177 changed to be "header.size" and "header.next".
6178 * buffer.h (struct buffer): Likewise.
6179 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6180 * frame.h (struct frame): Likewise.
6181 * process.h (struct Lisp_Process): Likewise.
6182 * termhooks.h (struct terminal): Likewise.
6183 * window.c (struct save_window_data, struct saved_window): Likewise.
6184 * window.h (struct window): Likewise.
6185 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6186 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6187 * buffer.c (init_buffer_once): Likewise.
6188 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6189 special case.
6190 * process.c (Fformat_network_address): Use local var for size,
6191 for brevity.
6192
6193 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6194
6195 Make the Lisp reader and string-to-float more consistent (Bug#8525)
6196 * data.c (atof): Remove decl; no longer used or needed.
6197 (digit_to_number): Move to lread.c.
6198 (Fstring_to_number): Use new string_to_number function, to be
6199 consistent with how the Lisp reader treats infinities and NaNs.
6200 Do not assume that floating-point numbers represent EMACS_INT
6201 without losing information; this is not true on most 64-bit hosts.
6202 Avoid double-rounding errors, by insisting on integers when
6203 parsing non-base-10 numbers, as the documentation specifies.
6204 * lisp.h (string_to_number): New decl, replacing ...
6205 (isfloat_string): Remove.
6206 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
6207 (read1): Do not accept +. and -. as integers; this
6208 appears to have been a coding error. Similarly, do not accept
6209 strings like +-1e0 as floating point numbers. Do not report
6210 overflow for integer overflows unless the base is not 10 which
6211 means we have no simple and reliable way to continue.
6212 Break out the floating-point parsing into a new
6213 function string_to_number, so that Fstring_to_number parses
6214 floating point numbers consistently with the Lisp reader.
6215 (digit_to_number): Move here from data.c. Make it static inline.
6216 (E_CHAR, EXP_INT): Remove, replacing with ...
6217 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6218 (string_to_number): New function, replacing isfloat_string.
6219 This function checks for valid syntax and produces the resulting
6220 Lisp float number too. Rework it so that string-to-number
6221 no longer mishandles examples like "1.0e+". Use strtoumax,
6222 so that overflow for non-base-10 numbers is reported only when
6223 there's no portable and simple way to convert to floating point.
6224
6225 * textprop.c (set_text_properties_1): Rewrite for clarity,
6226 and to avoid GCC warning about integer overflow.
6227
6228 * intervals.h (struct interval): Use EMACS_INT for members
6229 where EMACS_UINT might cause problems. See
6230 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6231 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6232 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6233 All uses changed.
6234 (offset_intervals): Tell GCC not to worry about length overflow
6235 when negating a negative length.
6236
6237 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6238 (overrun_check_free): Likewise.
6239
6240 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6241 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6242 word size.
6243
6244 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6245 (gnutls_make_error): Rename local to avoid shadowing.
6246 (gnutls_emacs_global_deinit): ifdef out; not used.
6247 (Fgnutls_boot): Use const for pointer to readonly storage.
6248 Comment out unused local. Fix pointer signedness problems.
6249
6250 * lread.c (openp): Don't stuff size_t into an 'int'.
6251 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6252 about possible signed overflow.
6253
6254 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6255 (GDK_KEY_g): Don't define if already defined.
6256 (xg_prepare_tooltip): Avoid pointer signedness problem.
6257 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6258
6259 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6260 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6261
6262 * xfns.c (Fx_window_property): Simplify a bit,
6263 to make a bit faster and to avoid GCC 4.6.0 warning.
6264 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6265
6266 * fns.c (internal_equal): Don't assume size_t fits in int.
6267
6268 * alloc.c (compact_small_strings): Tighten assertion a little.
6269
6270 Replace pEd with more-general pI, and fix some printf arg casts.
6271 * lisp.h (pI): New macro, generalizing old pEd macro to other
6272 conversion specifiers. For example, use "...%"pI"d..." rather
6273 than "...%"pEd"...".
6274 (pEd): Remove. All uses replaced with similar uses of pI.
6275 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6276 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6277 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6278 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6279 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6280 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6281 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6282 64-bit hosts.
6283 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6284 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6285 * print.c (safe_debug_print, print_object): Likewise.
6286 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6287 to int.
6288 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6289 avoiding the 0 flag, which is not portable.
6290 * process.c (Fmake_network_process): Use pI to avoid cast.
6291 * region-cache.c (pp_cache): Likewise.
6292 * xdisp.c (decode_mode_spec): Likewise.
6293 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6294 behavior on 64-bit hosts with printf arg.
6295 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
6296 (x_stop_queuing_selection_requests): Likewise.
6297 (x_get_window_property): Don't truncate byte count to an 'int'
6298 when tracing.
6299
6300 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6301 here, since it parses constructs like leading '-' and spaces,
6302 which are not wanted; and it overflows with large numbers.
6303 Instead, simply match F[0-9]+, which is what is wanted anyway.
6304
6305 * alloc.c: Remove unportable assumptions about struct layout.
6306 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6307 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6308 (allocate_vectorlike, make_pure_vector): Use the new macros,
6309 plus offsetof, to remove unportable assumptions about struct layout.
6310 These assumptions hold on all porting targets that I know of, but
6311 they are not guaranteed, they're easy to remove, and removing them
6312 makes further changes easier.
6313
6314 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6315 This doesn't fix a bug but makes the code clearer.
6316 (string_overrun_cookie): Now const. Use initializers that
6317 don't formally overflow signed char, to avoid warnings.
6318 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6319 can cause Emacs to crash when string overrun checking is enabled.
6320 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6321 multiple of sizeof (EMACS_INT); it need not be, if
6322 alignof(EMACS_INT) < sizeof (EMACS_INT).
6323 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
6324
6325 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
6326
6327 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6328
6329 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6330
6331 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
6332 supposed to be handshaking. (Bug#8556)
6333 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6334
6335 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
6336
6337 * lisp.h (Qdebug): List symbol.
6338 * eval.c (Qdebug): Restore global linkage.
6339 * keyboard.c (debug-on-event): New variable.
6340 (handle_user_signal): Break into debugger when debug-on-event
6341 matches the current signal symbol.
6342
6343 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6344
6345 * alloc.c (check_sblock, check_string_bytes)
6346 (check_string_free_list): Convert to standard C.
6347
6348 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6349
6350 * w32.c (emacs_gnutls_push): Fix typo.
6351
6352 2011-04-25 Eli Zaretskii <eliz@gnu.org>
6353
6354 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6355 "cast to pointer from integer of different size".
6356
6357 Improve doprnt and its use in verror. (Bug#8545)
6358 * doprnt.c (doprnt): Document the set of format control sequences
6359 supported by the function. Use SAFE_ALLOCA instead of always
6360 using `alloca'.
6361
6362 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6363 is one byte too soon. Don't use xrealloc; instead xfree and
6364 xmalloc anew.
6365
6366 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6367
6368 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6369 callbacks stage.
6370
6371 * gnutls.c: Renamed global_initialized to
6372 gnutls_global_initialized. Added internals for the
6373 :verify-hostname-error, :verify-error, and :verify-flags
6374 parameters of `gnutls-boot' and documented those parameters in the
6375 docstring. Start callback support.
6376 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6377 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6378 on error. Return error code.
6379 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6380 (emacs_gnutls_read): Likewise.
6381 (Fgnutls_boot): Return handshake error code.
6382 (emacs_gnutls_handle_error): New function.
6383 (wsaerror_to_errno): Likewise.
6384
6385 * w32.h (emacs_gnutls_pull): Add prototype.
6386 (emacs_gnutls_push): Likewise.
6387
6388 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6389 (emacs_gnutls_push): Likewise.
6390
6391 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6392
6393 * process.c (wait_reading_process_output): Check if GnuTLS
6394 buffered some data internally if no FDs are set for TLS
6395 connections.
6396
6397 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6398 (LIBS): Link to USER_LIBS.
6399 ($(BLD)/gnutls.$(0)): New target.
6400
6401 2011-04-24 Eli Zaretskii <eliz@gnu.org>
6402
6403 * xdisp.c (handle_single_display_spec): Rename the
6404 display_replaced_before_p argument into display_replaced_p, to
6405 make it consistent with the commentary. Fix typos in the
6406 commentary.
6407
6408 * textprop.c (syms_of_textprop): Remove dead code.
6409 (copy_text_properties): Delete obsolete commentary about an
6410 interface that was deleted long ago. Fix typos in the description
6411 of arguments.
6412
6413 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6414 to changes in oldXMenu/XMenu.h from 2011-04-16.
6415 <menu_help_message, prev_menu_help_message>: Constify.
6416 (IT_menu_make_room): menu->help_text is now `const char **';
6417 adjust.
6418
6419 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6420 to changes in oldXMenu/XMenu.h from 2011-04-16.
6421 (struct XMenu): Declare `help_text' `const char **'.
6422
6423 * xfaces.c <Qunspecified>: Make extern again.
6424
6425 * syntax.c: Include sys/types.h before including regex.h, as
6426 required by Posix.
6427
6428 * doc.c (get_doc_string): Improve the format passed to `error'.
6429
6430 * doprnt.c (doprnt): Improve commentary.
6431
6432 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6433
6434 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6435 them with etags.
6436
6437 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6438 changes in globals.h immediately force recompilation.
6439 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6440 $(CURDIR)/s/ms-w32.h.
6441 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
6442
6443 * character.c (Fchar_direction): Function deleted.
6444 (syms_of_character): Don't defsubr it.
6445 <char-direction-table>: Deleted.
6446
6447 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6448
6449 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6450 * doprnt.c: Include limits.h.
6451 (SIZE_MAX): New macro.
6452 (doprnt): Return a size_t value. 2nd arg is now size_t.
6453 Many local variables are now size_t instead of int or unsigned.
6454 Improve overflow protection. Support `l' modifier for integer
6455 conversions. Support %l conversion. Don't assume an EMACS_INT
6456 argument for integer conversions and for %c.
6457
6458 * lisp.h (doprnt): Restore prototype.
6459
6460 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6461 $(SRC)/character.h.
6462
6463 * Makefile.in (base_obj): Add back doprnt.o.
6464
6465 * deps.mk (doprnt.o): Add back prerequisites.
6466 (callint.o): Depend on character.h.
6467
6468 * eval.c (internal_lisp_condition_case): Include the handler
6469 representation in the error message.
6470 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6471 when breaking from the loop.
6472
6473 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6474
6475 * callint.c (Fcall_interactively): When displaying error message
6476 about invalid control letter, pass the character's codepoint, not
6477 a pointer to its multibyte form. Improve display of the character
6478 in octal and display also its hex code.
6479
6480 * character.c (char_string): Use %x to display the (unsigned)
6481 codepoint of an invalid character, to avoid displaying a bogus
6482 negative value.
6483
6484 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6485 `error', not SYMBOL_NAME itself.
6486
6487 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6488 character arguments to `error'.
6489
6490 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6491 to `error' in error message about FINAL_CHAR argument. Make sure
6492 FINAL_CHAR is a character, and use %c when it is passed as
6493 argument to `error'.
6494
6495 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6496
6497 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6498
6499 * w32.c: Include <time.h>.
6500 (sys_localtime): New function.
6501
6502 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
6503
6504 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6505
6506 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
6507
6508 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
6509
6510 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6511 zombies (Bug#8467).
6512
6513 2011-04-19 Eli Zaretskii <eliz@gnu.org>
6514
6515 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6516 gl_state.e_property when gl_state.object is Qt.
6517
6518 * insdel.c (make_gap_larger): Remove limitation of buffer size
6519 to <= INT_MAX.
6520
6521 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
6522
6523 * xdisp.c (lookup_glyphless_char_display)
6524 (produce_glyphless_glyph): Handle cons cell entry in
6525 glyphless-char-display.
6526 (Vglyphless_char_display): Document it.
6527
6528 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6529 glyphless-char-display.
6530
6531 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
6532
6533 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6534
6535 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6536
6537 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6538 definition for no-X builds.
6539
6540 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
6541
6542 Static checks with GCC 4.6.0 and non-default toolkits.
6543
6544 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6545
6546 * process.c (keyboard_bit_set): Define only if SIGIO.
6547 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6548 (send_process): Repair possible setjmp clobbering.
6549
6550 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6551
6552 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6553
6554 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6555
6556 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6557 Define only if needed.
6558
6559 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6560 by pacifying GCC about it. Maybe it's time to retire it?
6561 * xfaces.c (USG, __TIMEVAL__): Likewise.
6562
6563 * dispextern.h (struct redisplay_interface): Rename param
6564 to avoid shadowing.
6565 * termhooks.h (struct terminal): Likewise.
6566 * xterm.c (xembed_send_message): Likewise.
6567
6568 * insdel.c (make_gap_smaller): Define only if
6569 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6570
6571 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6572 it.
6573
6574 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6575 so that we aren't warned about unused symbols.
6576
6577 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6578
6579 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
6580
6581 * xfns.c (x_real_positions): Mark locals as initialized.
6582
6583 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6584
6585 * xterm.c: Fix problems found by static analysis with other toolkits.
6586 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
6587 (x_dispatch_event): Declare static if USE_GTK, and
6588 define if USE_GTK || USE_X_TOOLKIT.
6589 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
6590 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
6591 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6592 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
6593
6594 * xmenu.c (menu_help_callback): Pointer type fixes.
6595 Use const pointers when pointing at readonly data. Avoid pointer
6596 signedness clashes.
6597 (FALSE): Remove unused macro.
6598 (update_frame_menubar): Remove unused decl.
6599
6600 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6601
6602 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6603 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6604 (single_menu_item): Rename local to avoid shadowing.
6605
6606 * keyboard.c (make_lispy_event): Remove unused local var.
6607
6608 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6609 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6610
6611 * bitmaps: Change bitmaps from unsigned char back to the X11
6612 compatible char. Avoid the old compiler warnings about
6613 out-of-range initializers by using, for example, '\xab' rather
6614 than 0xab.
6615
6616 * xgselect.c (xgselect_initialize): Check vs interface
6617 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6618
6619 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6620
6621 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6622 to read-only memory.
6623
6624 * fns.c (vector): Remove; this old hack is no longer needed.
6625
6626 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
6627 Remove unused var.
6628 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
6629
6630 * xrdb.c (x_load_resources): Omit unused local.
6631
6632 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
6633 (x_window): Rename locals to avoid shadowing.
6634 (USG): Use the kludged USG macro, to pacify gcc.
6635
6636 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
6637 (x_term_init): Remove local to avoid shadowing.
6638
6639 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
6640
6641 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6642 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6643
6644 2011-04-16 Eli Zaretskii <eliz@gnu.org>
6645
6646 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6647
6648 Fix regex.c, syntax.c and friends for buffers > 2GB.
6649 * syntax.h (struct gl_state_s): Declare character position members
6650 EMACS_INT.
6651
6652 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6653
6654 * textprop.c (verify_interval_modification, interval_of):
6655 Declare arguments EMACS_INT.
6656
6657 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6658 EMACS_INT.
6659
6660 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6661
6662 * indent.c (Fvertical_motion): Local variable it_start is now
6663 EMACS_INT.
6664
6665 * regex.c (re_match, re_match_2, re_match_2_internal)
6666 (bcmp_translate, regcomp, regexec, print_double_string)
6667 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6668 (re_compile_pattern, re_exec): Declare arguments and local
6669 variables `size_t' and `ssize_t' and return values `regoff_t', as
6670 appropriate.
6671 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6672 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6673 <compile_stack_type>: `size' and `avail' are now `size_t'.
6674
6675 * regex.h <regoff_t>: Use ssize_t, not int.
6676 (re_search, re_search_2, re_match, re_match_2): Arguments that
6677 specify buffer/string position and length are now ssize_t and
6678 size_t. Return type is regoff_t.
6679
6680 2011-04-16 Ben Key <bkey76@gmail.com>
6681
6682 * nsfont.m: Fixed bugs in ns_get_family and
6683 ns_descriptor_to_entity that were caused by using free to
6684 deallocate memory blocks that were allocated by xmalloc (via
6685 xstrdup). This caused Emacs to crash when compiled with
6686 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6687 --enable-checking=xmallocoverrun). xfree is now used to
6688 deallocate these memory blocks.
6689
6690 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
6691
6692 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6693
6694 emacs_write: Accept and return EMACS_INT for sizes.
6695 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6696 et seq.
6697 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6698 Accept and return EMACS_INT.
6699 (emacs_gnutls_write): Return the number of bytes written on
6700 partial writes.
6701 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
6702 (emacs_read, emacs_write): Remove check for negative size, as the
6703 Emacs source code has been audited now.
6704 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6705 (emacs_read, emacs_write): Use it.
6706 * process.c (send_process): Adjust to the new signatures of
6707 emacs_write and emacs_gnutls_write. Do not attempt to store
6708 a byte offset into an 'int'; it might overflow.
6709 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
6710
6711 * sound.c: Don't assume sizes fit in 'int'.
6712 (struct sound_device.period_size, alsa_period_size):
6713 Return EMACS_INT, not int.
6714 (struct sound_device.write, vox_write, alsa_write):
6715 Accept EMACS_INT, not int.
6716 (wav_play, au_play): Use EMACS_INT to store sizes and to
6717 record read return values.
6718
6719 2011-04-15 Ben Key <bkey76@gmail.com>
6720
6721 * keyboard.c (Qundefined): Don't declare static since it is used
6722 in nsfns.m.
6723 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6724 static since they are used in nsfont.m.
6725
6726 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6727
6728 * process.c (Qprocessp): Don't declare static.
6729 * lisp.h (Qprocessp): Declare again.
6730
6731 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
6732
6733 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6734
6735 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6736
6737 Improve C-level modularity by making more things 'static'.
6738
6739 Don't publish debugger-only interfaces to other modules.
6740 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6741 (verify_bytepos, count_markers): Move decls to the only modules
6742 that need them.
6743 * region-cache.h (pp_cache): Likewise.
6744 * window.h (check_all_windows): Likewise.
6745 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6746
6747 * sysdep.c (croak): Now static, if
6748 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6749 * syssignal.h (croak): Declare only if not static.
6750
6751 * alloc.c (refill_memory_reserve): Now static if
6752 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6753 * lisp.h (refill_memory_reserve): Declare only if not static.
6754
6755 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6756 Define only if USE_LUCID.
6757
6758 * xrdb.c (x_customization_string, x_rm_string): Now static.
6759
6760 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6761 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6762
6763 * xdisp.c (draw_row_with_mouse_face): Now static.
6764 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6765
6766 * window.h (check_all_windows): Mark externally visible.
6767
6768 * window.c (window_deletion_count): Now static.
6769
6770 * undo.c: Make symbols static if they're not exported.
6771 (last_undo_buffer, last_boundary_position, pending_boundary):
6772 Now static.
6773
6774 * textprop.c (interval_insert_behind_hooks): Now static.
6775 (interval_insert_in_front_hooks): Likewise.
6776
6777 * term.c: Make symbols static if they're not exported.
6778 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6779 (max_frame_lines, tty_set_terminal_modes):
6780 (tty_reset_terminal_modes, tty_turn_off_highlight):
6781 (get_tty_terminal): Now static.
6782 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6783 * termhooks.h (term_mouse_moveto): Do not declare if
6784 HAVE_WINDOW_SYSTEM.
6785 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6786 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6787
6788 * sysdep.c: Make symbols static if they're not exported.
6789 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6790 Now static.
6791 (sigprocmask_set, full_mask): Remove; unused.
6792 (wait_debugging): Mark as visible.
6793 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6794 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6795
6796 * syntax.c (syntax_temp): Define only if !__GNUC__.
6797
6798 * sound.c (current_sound_device, current_sound): Now static.
6799
6800 * search.c (searchbufs, searchbuf_head): Now static.
6801
6802 * scroll.c (scroll_cost): Remove; unused.
6803 * dispextern.h (scroll_cost): Remove decl.
6804
6805 * region-cache.h (pp_cache): Mark as externally visible.
6806
6807 * process.c: Make symbols static if they're not exported.
6808 (process_tick, update_tick, create_process, chan_process):
6809 (Vprocess_alist, proc_buffered_char, datagram_access):
6810 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6811 (deactivate_process): Mark defn as static, as well as decl.
6812 * lisp.h (create_process): Remove decl.
6813 * process.h (chan_process, Vprocess_alist): Remove decls.
6814
6815 * print.c: Make symbols static if they're not exported.
6816 (print_depth, new_backquote_output, being_printed, print_buffer):
6817 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6818 (print_interval, print_number_index, initial_stderr_stream):
6819 Now static.
6820 * lisp.h (Fprinc): Remove decl.
6821 (debug_output_compilation_hack): Mark as externally visible.
6822
6823 * sysdep.c (croak): Move decl from here to syssignal.h.
6824 * syssignal.h (croak): Put it here, so the API can be checked when
6825 'croak' is called from dissociate_if_controlling_tty.
6826
6827 * minibuf.c: Make symbols static if they're not exported.
6828 (minibuf_save_list, choose_minibuf_frame): Now static.
6829 * lisp.h (choose_minibuf_frame): Remove decl.
6830
6831 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6832
6833 * lread.c: Make symbols static if they're not exported.
6834 (read_objects, initial_obarray, oblookup_last_bucket_number):
6835 Now static.
6836 (make_symbol): Remove; unused.
6837 * lisp.h (initial_obarray, make_symbol): Remove decls.
6838
6839 * keyboard.c: Make symbols static if they're not exported.
6840 (single_kboard, recent_keys_index, total_keys, recent_keys):
6841 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6842 (this_single_command_key_start, echoing, last_auto_save):
6843 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6844 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6845 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6846 (Vlispy_mouse_stem, double_click_count):
6847 Now static.
6848 (force_auto_save_soon): Define only if SIGDANGER.
6849 (ignore_mouse_drag_p): Now static if
6850 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6851 (print_help): Remove; unused.
6852 (stop_character, last_timer_event): Mark as externally visible.
6853 * keyboard.h (ignore_mouse_drag_p): Declare only if
6854 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6855 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6856 * lisp.h (echoing): Remove decl.
6857 (force_auto_save_soon): Declare only if SIGDANGER.
6858 * xdisp.c (redisplay_window): Simplify code, to make it more
6859 obvious that ignore_mouse_drag_p is not accessed if !defined
6860 USE_GTK && !defined HAVE_NS.
6861
6862 * intervals.c: Make symbols static if they're not exported.
6863 (merge_properties_sticky, merge_interval_right, delete_interval):
6864 Now static.
6865 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6866
6867 * insdel.c: Make symbols static if they're not exported.
6868 However, leave prepare_to_modify_buffer alone. It's never
6869 called from outside this function, but that appears to be a bug.
6870 (combine_after_change_list, combine_after_change_buffer):
6871 (adjust_after_replace, signal_before_change): Now static.
6872 (adjust_after_replace_noundo): Remove; unused.
6873 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
6874 (signal_before_change): Remove decls.
6875
6876 * indent.c (val_compute_motion, val_vmotion): Now static.
6877
6878 * image.c: Make symbols static if they're not exported.
6879 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6880 if USE_GTK.
6881 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6882 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6883
6884 * fringe.c (standard_bitmaps): Now static.
6885 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6886
6887 * frame.c: Make symbols static if they're not exported.
6888 (x_report_frame_params, make_terminal_frame): Now static.
6889 (get_frame_param): Now static, unless HAVE_NS.
6890 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6891 (x_get_resource_string): Remove; not used.
6892 * frame.h (make_terminal_frame, x_report_frame_params):
6893 (x_get_resource_string); Remove decls.
6894 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6895 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6896
6897 * font.c, fontset.c: Make symbols static if they're not exported.
6898 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6899 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6900 * font.c (font_close_object): Now static.
6901 * font.h (font_close_object): Remove.
6902 * fontset.c (FONTSET_OBJLIST): Remove.
6903 (free_realized_fontset) #if-0 the body, which does nothing.
6904 (face_suitable_for_char_p): #if-0, as it's never called.
6905 * fontset.h (face_suitable_for_char_p): Remove decl.
6906 * xfaces.c (face_at_string_position):
6907 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
6908 since 0 is always ASCII.
6909
6910 * fns.c (weak_hash_tables): Now static.
6911
6912 * fileio.c: Make symbols static if they're not exported.
6913 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6914 (Vwrite_region_annotation_buffers): Now static.
6915
6916 * eval.c: Make symbols static if they're not exported.
6917 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6918 * lisp.h (backtrace_list): Remove decl.
6919
6920 * emacs.c: Make symbols static if they're not exported.
6921 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6922 (fatal_error_code, fatal_error_signal_hook, standard_args):
6923 Now static.
6924 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6925 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6926 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6927 * lisp.h (fatal_error_signal_hook): Remove decl.
6928 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6929
6930 * editfns.c: Move a (normally-unused) function to its only use.
6931 * editfns.c, lisp.h (get_operating_system_release): Remove.
6932 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6933 worth the hassle of breaking this out.
6934
6935 * xterm.c: Make symbols static if they're not exported.
6936 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6937 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6938 (x_destroy_window, x_delete_display):
6939 Now static.
6940 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6941 (x_mouse_leave): Remove; unused.
6942 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6943 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6944 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6945 Remove decls.
6946 (x_mouse_leave): Declare only if WINDOWSNT.
6947 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6948 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6949 USE_X_TOOLKIT.
6950
6951 * ftxfont.c: Make symbols static if they're not exported.
6952 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6953 HAVE_FREETYPE.
6954 * font.h (ftxfont_driver): Likewise.
6955
6956 * xfns.c: Make symbols static if they're not exported.
6957 (x_last_font_name, x_display_info_for_name):
6958 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6959 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6960 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6961 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6962 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6963 (last_show_tip_args): Now static.
6964 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6965 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6966 (x_screen_planes): Remove; unused.
6967 * dispextern.h (x_screen_planes): Remove decl.
6968
6969 * dispnew.c: Make symbols static if they're not exported.
6970 * dispextern.h (redraw_garbaged_frames, scrolling):
6971 (increment_row_positions): Remove.
6972 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6973 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6974 Now static.
6975 (redraw_garbaged_frames): Remove; unused.
6976
6977 * xfaces.c: Make symbols static if they're not exported.
6978 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6979 Remove decls.
6980 * xterm.h (defined_color): Remove decls.
6981 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6982 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6983 (menu_face_changed_default, defined_color, free_realized_face):
6984 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6985 (ascii_face_of_lisp_face): Remove; unused.
6986
6987 * xdisp.c: Make symbols static if they're not exported.
6988 * dispextern.h (scratch_glyph_row, window_box_edges):
6989 (glyph_to_pixel_coords, set_cursor_from_row):
6990 (get_next_display_element, set_iterator_to_next):
6991 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6992 (show_mouse_face): Remove decls
6993 * frame.h (message_buf_print): Likewise.
6994 * lisp.h (pop_message, set_message, check_point_in_composition):
6995 Likewise.
6996 * xterm.h (set_vertical_scroll_bar): Likewise.
6997 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6998 (message_buf_print, scratch_glyph_row, displayed_buffer):
6999 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7000 (get_next_display_element, show_mouse_face, window_box_edges):
7001 (frame_to_window_pixel_xy, check_point_in_composition):
7002 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7003 (glyph_to_pixel_coords): Remove; unused.
7004
7005 * dired.c (file_name_completion): Now static.
7006
7007 * dbusbind.c (xd_in_read_queued_messages): Now static.
7008
7009 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7010 * data.c (circular_list_error): Remove.
7011
7012 * commands.h (last_point_position, last_point_position_buffer):
7013 (last_point_position_window): Remove decls.
7014 * keyboard.c: Make these variables static.
7015
7016 * coding.h (coding, code_convert_region, encode_coding_gap):
7017 Remove decls.
7018 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7019 (iso_code_class, detect_coding, code_convert_region): Now static.
7020 (encode_coding_gap): Remove; unused.
7021
7022 * chartab.c (chartab_chars, chartab_bits): Now static.
7023
7024 * charset.h (charset_iso_8859_1): Remove decl.
7025 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7026 Now static.
7027
7028 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7029 * ccl.c (Vccl_program_table): Now static.
7030 (check_ccl_update): Remove; unused.
7031
7032 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7033 * category.h: ... from here.
7034 * category.c (check_category_table, set_category_set): Now static.
7035
7036 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7037 * lisp.h: Remove these decls.
7038
7039 * buffer.c (buffer_count): Remove unused var.
7040
7041 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7042 so that it's not optimized away.
7043 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7044 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7045 exported only to the debugger.
7046
7047 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7048 * atimer.h (run_all_atimers): Remove; not exported.
7049
7050 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7051 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7052 was inaccessible from Lisp.
7053 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7054 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7055
7056 alloc.c: Import and export fewer symbols, and remove unused items.
7057 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7058 is defined.
7059 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7060 it's not optimized away by whole-program optimization.
7061 (message_enable_multibyte, free_misc): Remove.
7062 (catchlist, handlerlist, mark_backtrace):
7063 Declare only if BYTE_MARK_STACK.
7064 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7065 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7066 (message_enable_multibyte): Remove decl.
7067 (free_misc, interval_free_list, float_block, float_block_index):
7068 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7069 (cons_free_list, last_marked_index):
7070 Now static.
7071 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7072 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7073 (mark_backtrace): Define only if BYTE_MARK_STACK.
7074 * xdisp.c (message_enable_multibyte): Now static.
7075
7076 Declare Lisp_Object Q* variables to be 'static' if not exported.
7077 This makes it easier for human readers (and static analyzers)
7078 to see whether these variables are used from other modules.
7079 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7080 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7081 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7082 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7083 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7084 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7085 * xmenu.c, xselect.c:
7086 Declare Q* vars static if they are not used in other modules.
7087 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7088 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7089 Remove decls of unexported vars.
7090 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7091
7092 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7093
7094 Make Emacs functions such as Fatom 'static' by default.
7095 This makes it easier for human readers (and static analyzers)
7096 to see whether these functions can be called from other modules.
7097 DEFUN now defines a static function. To make the function external
7098 so that it can be used in other C modules, use the new macro DEFUE.
7099 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7100 (Finit_image_library):
7101 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7102 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7103 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7104 Remove decls, since these functions are now static.
7105 (Funintern, Fget_internal_run_time): New decls, since these functions
7106 were already external.
7107
7108 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7109 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7110 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7111 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7112 * keyboard.c, keymap.c, lread.c:
7113 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7114 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7115 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7116 Mark functions with DEFUE instead of DEFUN,
7117 if they are used in other modules.
7118 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7119 decls for now-static functions.
7120 * buffer.h (Fdelete_overlay): Remove decl.
7121 * callproc.c (Fgetenv_internal): Mark as internal.
7122 * composite.c (Fremove_list_of_text_properties): Remove decl.
7123 (Fcomposition_get_gstring): New forward static decl.
7124 * composite.h (Fcomposite_get_gstring): Remove decl.
7125 * dired.c (Ffile_attributes): New forward static decl.
7126 * doc.c (Fdocumntation_property): New forward static decl.
7127 * eval.c (Ffetch_bytecode): New forward static decl.
7128 (Funintern): Remove extern decl; now in .h file where it belongs.
7129 * fileio.c (Fmake_symbolic_link): New forward static decl.
7130 * image.c (Finit_image_library): New forward static decl.
7131 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7132 * intervals.h (Fprevious_property_change):
7133 (Fremove_list_of_text_properties): Remove decls.
7134 * keyboard.c (Fthis_command_keys): Remove decl.
7135 (Fcommand_execute): New forward static decl.
7136 * keymap.c (Flookup_key): New forward static decl.
7137 (Fcopy_keymap): Now static.
7138 * keymap.h (Flookup_key): Remove decl.
7139 * process.c (Fget_process): New forward static decl.
7140 (Fprocess_datagram_address): Mark as internal.
7141 * syntax.c (Fsyntax_table_p): New forward static decl.
7142 (skip_chars): Remove duplicate decl.
7143 * textprop.c (Fprevious_property_change): New forward static decl.
7144 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7145 Now internal.
7146 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7147 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7148
7149 * editfns.c (Fformat): Remove unreachable code.
7150
7151 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7152
7153 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7154 change. (Bug#8496)
7155
7156 2011-04-13 Eli Zaretskii <eliz@gnu.org>
7157
7158 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7159 when at ZV. (Bug#8487)
7160
7161 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7162
7163 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7164 (Bug#8437)
7165 * keyboard.c (parse_tool_bar_item): Likewise.
7166 * sound.c (sound_cleanup, alsa_close): Likewise.
7167 * termcap.c (tgetent): Likewise.
7168 * xfns.c (x_default_font_parameter): Likewise.
7169 * xsettings.c (read_and_apply_settings): Likewise.
7170
7171 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7172 (overrun_check_free): Protoize.
7173
7174 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7175
7176 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7177 since callers should never pass a negative size.
7178 Change the signature to match that of plain 'read' and 'write'; see
7179 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7180 * lisp.h: Update prototypes of emacs_write and emacs_read.
7181
7182 2011-04-11 Eli Zaretskii <eliz@gnu.org>
7183
7184 * xdisp.c (redisplay_window): Don't try to determine the character
7185 position of the scroll margin if the window start point w->startp
7186 is outside the buffer's accessible region. (Bug#8468)
7187
7188 2011-04-10 Eli Zaretskii <eliz@gnu.org>
7189
7190 Fix write-region and its subroutines for buffers > 2GB.
7191 * fileio.c (a_write, e_write): Modify declaration of arguments and
7192 local variables to support buffers larger than 2GB.
7193 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7194
7195 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7196 argument, local variables, and return value.
7197
7198 * lisp.h: Update prototypes of emacs_write and emacs_read.
7199
7200 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7201
7202 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
7203
7204 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7205
7206 Fix more problems found by GCC 4.6.0's static checks.
7207
7208 * xdisp.c (vmessage): Use a better test for character truncation.
7209
7210 * charset.c (load_charset_map): <, not <=, for optimization,
7211 and to avoid potential problems with integer overflow.
7212 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
7213 * casetab.c (set_identity, shuffle): Likewise.
7214 * editfns.c (Fformat): Likewise.
7215 * syntax.c (skip_chars): Likewise.
7216
7217 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7218 This also lets GCC 4.6.0 generate slightly better loop code.
7219
7220 * callint.c (Fcall_interactively): <, not <=, for optimization.
7221 (Fcall_interactively): Count the number of arguments produced,
7222 not the number of arguments given. This is simpler and lets GCC
7223 4.6.0 generate slightly better code.
7224
7225 * ftfont.c: Distingish more carefully between FcChar8 and char.
7226 The previous code passed unsigned char * to a functions like
7227 strlen and xstrcasecmp that expect char *, which does not
7228 conform to the C standard.
7229 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7230 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7231 char * when the C standard requires it.
7232
7233 * keyboard.c (read_char): Remove unused var.
7234
7235 * eval.c: Port to Windows vsnprintf (Bug#8435).
7236 Include <limits.h>.
7237 (SIZE_MAX): Define if the headers do not.
7238 (verror): Do not give up if vsnprintf returns a negative count.
7239 Instead, grow the buffer. This ports to Windows vsnprintf, which
7240 does not conform to C99. Problem reported by Eli Zaretskii.
7241 Also, simplify the allocation scheme, by avoiding the need for
7242 calling realloc, and removing the ALLOCATED variable.
7243
7244 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7245
7246 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7247 But keep the doprint source code for now, as we might revamp it
7248 and use it again (Bug#8435).
7249 * lisp.h (doprnt): Remove.
7250 * Makefile.in (base_obj): Remove doprnt.o.
7251 * deps.mk (doprnt.o): Remove.
7252
7253 error: Print 32- and 64-bit integers portably (Bug#8435).
7254 Without this change, on typical 64-bit hosts error ("...%d...", N)
7255 was used to print both 32- and 64-bit integers N, which relied on
7256 undefined behavior.
7257 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7258 New macro.
7259 * lisp.h (error, verror): Mark as printf-like functions.
7260 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7261 Report overflow in size calculations when allocating printf buffer.
7262 Do not truncate output string at its first null byte.
7263 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7264 Truncate the output at a character boundary, since vsnprintf does not
7265 do that.
7266 * charset.c (check_iso_charset_parameter): Convert internal
7267 character to string before calling 'error', since %c now has the
7268 printf meaning.
7269 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7270 overflow when computing char to be passed to 'error'. Do not
7271 pass Lisp_Object to 'error'; pass the integer instead.
7272 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7273 formatted with plain %d.
7274
7275 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7276
7277 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7278
7279 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7280
7281 * xterm.c (x_catch_errors): Remove duplicate declaration.
7282
7283 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7284
7285 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7286
7287 2011-04-10 Jim Meyering <meyering@redhat.com>
7288
7289 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7290 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7291 return ssize_t not "int", and use size_t as the buffer length.
7292 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7293 * gnutls.h: Update declarations.
7294 * process.c (read_process_output): Use ssize_t, to match.
7295 (send_process): Likewise.
7296
7297 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7298
7299 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7300
7301 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7302
7303 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7304 Use unsigned char, to match FcChar8 type definition.
7305
7306 * xterm.c (handle_one_xevent):
7307 * xmenu.c (create_and_show_popup_menu):
7308 * xselect.c (x_decline_selection_request)
7309 (x_reply_selection_request): Avoid type-punned deref of X events.
7310
7311 2011-04-09 Eli Zaretskii <eliz@gnu.org>
7312
7313 Fix some uses of `int' instead of EMACS_INT.
7314 * search.c (string_match_1, fast_string_match)
7315 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7316 (scan_buffer, find_next_newline_no_quit)
7317 (find_before_next_newline, search_command, Freplace_match)
7318 (Fmatch_data): Make some `int' variables be EMACS_INT.
7319
7320 * xdisp.c (display_count_lines): 3rd argument and return value now
7321 EMACS_INT. All callers changed.
7322 (pint2hrstr): Last argument is now EMACS_INT.
7323
7324 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7325 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7326 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7327 (decode_coding_utf_16, decode_coding_emacs_mule)
7328 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7329 (decode_coding_ccl, decode_coding_charset)
7330 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7331 (decode_coding_iso_2022, decode_coding_emacs_mule)
7332 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7333 <char_offset, last_offset>: Declare EMACS_INT.
7334 (encode_coding_utf_8, encode_coding_utf_16)
7335 (encode_coding_emacs_mule, encode_invocation_designation)
7336 (encode_designation_at_bol, encode_coding_iso_2022)
7337 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7338 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7339 Declare EMACS_INT.
7340 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7341 (encode_invocation_designation): Last argument P_NCHARS is now
7342 EMACS_INT.
7343 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7344 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7345
7346 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7347 All users changed.
7348
7349 * ccl.c (Fccl_execute_on_string): Declare some variables
7350 EMACS_INT.
7351
7352 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
7353
7354 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7355
7356 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7357
7358 * process.c (Fformat_network_address): Doc fix.
7359
7360 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7361
7362 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
7363
7364 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
7365
7366 * keyboard.c (read_char): Call Lisp function help-form-show,
7367 instead of using internal_with_output_to_temp_buffer.
7368 (Qhelp_form_show): New var.
7369 (syms_of_keyboard): Use DEFSYM macro.
7370
7371 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7372
7373 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7374
7375 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
7376
7377 * process.c (Flist_processes): Remove to Lisp.
7378 (list_processes_1): Delete.
7379
7380 2011-04-06 Eli Zaretskii <eliz@gnu.org>
7381
7382 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7383
7384 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7385
7386 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
7387
7388 Fix more problems found by GCC 4.6.0's static checks.
7389
7390 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7391
7392 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7393
7394 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
7395
7396 * xdisp.c (vmessage): Mark as a printf-like function.
7397
7398 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7399
7400 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7401
7402 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7403 printf-like functions.
7404 (tiff_load): Add casts to remove these marks before passing them
7405 to system-supplied API.
7406
7407 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7408
7409 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7410 This avoids several warnings with gcc -Wstrict-overflow.
7411 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7412 directly, rather than having caller test rule sign. This avoids
7413 some unnecessary tests.
7414 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7415 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7416 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
7417
7418 * xfont.c (xfont_text_extents): Remove var that was set but not used.
7419 (xfont_open): Avoid unnecessary tests.
7420
7421 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7422
7423 * composite.h, composite.c (composition_gstring_put_cache):
7424 Use EMACS_INT, not int, for length.
7425
7426 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7427 breaking out part of COMPOSITION_DECODE_RULE.
7428 (COMPOSITION_DECODE_RULE): Use it.
7429 * composite.c (get_composition_id): Remove unused local vars,
7430 by using the new macro.
7431
7432 * textprop.c (set_text_properties_1): Change while to do-while,
7433 since the condition is always true at first.
7434
7435 * intervals.c (graft_intervals_into_buffer): Mark var as used.
7436 (interval_deletion_adjustment): Return unsigned value.
7437 All uses changed.
7438
7439 * process.c (list_processes_1, create_pty, read_process_output):
7440 (exec_sentinel): Remove vars that were set but not used.
7441 (create_pty): Remove unnecessary "volatile"s.
7442 (Fnetwork_interface_info): Avoid possibility of int overflow.
7443 (read_process_output): Do adaptive read buffering even if carryover.
7444 (read_process_output): Simplify nbytes computation if buffered.
7445
7446 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7447
7448 * syntax.c (scan_words): Remove var that was set but not used.
7449 (update_syntax_table): Use unsigned instead of int.
7450
7451 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
7452 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
7453 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
7454
7455 * print.c (print_error_message): Avoid int overflow.
7456
7457 * font.c (font_list_entities): Redo for clarity,
7458 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7459
7460 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
7461 (font_score): Avoid potential overflow in diff calculation.
7462
7463 * fns.c (substring_both): Remove var that is set but not used.
7464 (sxhash): Redo loop for clarity and to avoid wraparound warning.
7465
7466 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7467
7468 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7469 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7470 can always succeed if overflow has undefined behavior.
7471
7472 * search.c (boyer_moore, wordify): Remove vars set but not used.
7473 (wordify): Omit three unnecessary tests.
7474
7475 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7476 All callers changed. This avoids the need for an unused var.
7477
7478 * casefiddle.c (casify_region): Remove var that is set but not used.
7479
7480 * dired.c (file_name_completion): Remove var that is set but not used.
7481
7482 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7483
7484 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
7485 (Finsert_file_contents): Remove unnecessary code checking fd.
7486
7487 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7488 Check for integer overflow on size calculations.
7489
7490 * buffer.c (Fprevious_overlay_change): Remove var that is set
7491 but not used.
7492
7493 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7494 Remove vars that are set but not used.
7495 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
7496 (timer_check_2): Mark vars as initialized.
7497
7498 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7499
7500 * image.c (lookup_image): Remove var that is set but not used.
7501 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
7502
7503 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7504 that are set but not used.
7505
7506 * xfns.c (make_invisible_cursor): Don't return garbage
7507 if XCreateBitmapFromData fails (Bug#8410).
7508
7509 * xselect.c (x_get_local_selection, x_handle_property_notify):
7510 Remove vars that are set but not used.
7511
7512 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
7513 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
7514
7515 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7516 Remove var that is set but not used.
7517 (scroll_bar_windows_size): Now size_t, not int.
7518 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7519 Check for overflow.
7520
7521 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7522 (map_tty_color) [!defined MSDOS]: Likewise.
7523
7524 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7525
7526 * coding.c: Remove vars that are set but not used.
7527 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7528 All callers changed.
7529 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7530 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7531 (decode_coding_charset): Remove vars that are set but not used.
7532
7533 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7534 that is set but not used.
7535
7536 * print.c (print_object): Remove var that is set but not used.
7537
7538 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
7539 The gnulib version avoids calling malloc in the usual case,
7540 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7541 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7542 * filelock.c (current_lock_owner): Likewise.
7543 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7544 * sysdep.c: Include allocator.h, careadlinkat.h.
7545 (emacs_no_realloc_allocator): New static constant.
7546 (emacs_readlink): New function.
7547 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7548 ../lib/careadlinkat.h.
7549
7550 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7551
7552 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7553 first non-nil return value).
7554
7555 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7556
7557 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7558 if not defined (Bug#8403).
7559
7560 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7561
7562 * xdisp.c (display_count_lines): Remove parameter `start',
7563 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7564 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7565 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7566 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7567 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7568 and thereabouts. All callers changed.
7569 (get_per_char_metric): Remove parameter `f', unused since
7570 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7571
7572 2011-04-02 Jim Meyering <meyering@redhat.com>
7573
7574 do not dereference NULL upon failed strdup
7575 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7576 (ns_get_family): Likewise.
7577
7578 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7579
7580 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7581
7582 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7583
7584 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7585 later (Bug#8403).
7586
7587 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7588
7589 Add lexical binding.
7590
7591 * window.c (Ftemp_output_buffer_show): New fun.
7592 (Fsave_window_excursion):
7593 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7594
7595 * lread.c (lisp_file_lexically_bound_p): New function.
7596 (Fload): Bind Qlexical_binding.
7597 (readevalloop): Remove `evalfun' arg.
7598 Bind Qinternal_interpreter_environment.
7599 (Feval_buffer): Bind Qlexical_binding.
7600 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7601 Mark as dynamic.
7602 (syms_of_lread): Declare `lexical-binding'.
7603
7604 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7605
7606 * keyboard.c (eval_dyn): New fun.
7607 (menu_item_eval_property): Use it.
7608
7609 * image.c (parse_image_spec): Use Ffunctionp.
7610
7611 * fns.c (concat, mapcar1): Accept byte-code-functions.
7612
7613 * eval.c (Fsetq): Handle lexical vars.
7614 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7615 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7616 (FletX, Flet): Obey lexical binding.
7617 (Fcommandp): Handle closures.
7618 (Feval): New `lexical' arg.
7619 (eval_sub): New function extracted from Feval. Use it almost
7620 everywhere where Feval was used. Look up vars in lexical env.
7621 Handle closures.
7622 (Ffunctionp): Move from subr.el.
7623 (Ffuncall): Handle closures.
7624 (apply_lambda): Remove `eval_flags'.
7625 (funcall_lambda): Handle closures and new byte-code-functions.
7626 (Fspecial_variable_p): New function.
7627 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7628 but without exporting it to Lisp.
7629
7630 * doc.c (Fdocumentation, store_function_docstring):
7631 * data.c (Finteractive_form): Handle closures.
7632
7633 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7634 interactive spec.
7635
7636 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7637 New byte-codes.
7638 (exec_byte_code): New function extracted from Fbyte_code to handle new
7639 calling convention for byte-code-functions. Add new byte-codes.
7640
7641 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
7642
7643 * alloc.c (Fmake_symbol): Init new `declared_special' field.
7644
7645 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7646
7647 * xdisp.c (redisplay_internal): Fix prototype.
7648
7649 2011-03-31 Eli Zaretskii <eliz@gnu.org>
7650
7651 * xdisp.c (SCROLL_LIMIT): New macro.
7652 (try_scrolling): Use it when setting scroll_limit.
7653 Limit scrolling to 100 screen lines.
7654 (redisplay_window): Even when falling back on "recentering",
7655 position point in the window according to scroll-conservatively,
7656 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7657
7658 (try_scrolling): When point is above the window, allow searching
7659 as far as scroll_max, or one screenful, to compute vertical
7660 distance from PT to the scroll margin position. This prevents
7661 try_scrolling from unnecessarily failing when
7662 scroll-conservatively is set to a value slightly larger than the
7663 window height. Clean up the case of PT below the margin at bottom
7664 of window: scroll_max can no longer be INT_MAX. When aggressive
7665 scrolling is in use, don't let point enter the opposite scroll
7666 margin as result of the scroll.
7667 (syms_of_xdisp) <scroll-conservatively>: Document the
7668 threshold of 100 lines for never-recentering scrolling.
7669
7670 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7671
7672 * dispextern.h (move_it_by_lines):
7673 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7674 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7675 (message_log_check_duplicate): Remove parameters `prev_bol' and
7676 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7677 (redisplay_internal): Remove parameter `preserve_echo_area',
7678 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7679
7680 * indent.c (Fvertical_motion):
7681 * window.c (window_scroll_pixel_based, Frecenter):
7682 Don't pass `need_y_p' to `move_it_by_lines'.
7683
7684 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7685
7686 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7687 steal a few bits to be more compact.
7688 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7689 Remove unneeded casts.
7690
7691 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7692
7693 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7694
7695 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7696 binding" message (bug#7967).
7697
7698 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7699
7700 Fix more problems found by GCC 4.6.0's static checks.
7701
7702 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7703 Remove unused local var.
7704
7705 * editfns.c (Fmessage_box): Remove unused local var.
7706
7707 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7708 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7709 Omit unused local vars.
7710 * window.c (shrink_windows): Omit unused local var.
7711 * menu.c (digest_single_submenu): Omit unused local var.
7712 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7713 Omit unused local var.
7714
7715 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7716 Don't assume string length fits in int.
7717 (keyremap_step, read_key_sequence): Use size_t for sizes.
7718 (read_key_sequence): Don't check last_real_key_start redundantly.
7719
7720 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7721 instead of alloca (Bug#8344).
7722
7723 * eval.c (Fbacktrace): Don't assume nargs fits in int.
7724 (Fbacktrace_frame): Don't assume nframes fits in int.
7725
7726 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7727
7728 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7729 concerns.
7730
7731 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7732
7733 * cm.c (calccost): Turn while-do into do-while, for clarity.
7734
7735 * keyboard.c (syms_of_keyboard): Use the same style as later
7736 in this function when indexing through an array. This also
7737 works around GCC bug 48267.
7738
7739 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7740
7741 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7742
7743 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7744 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7745
7746 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7747 This avoids undefined behavior on integer overflow, and is a bit
7748 more convenient anyway since it is compared to a size_t variable.
7749
7750 Variadic C functions now count arguments with size_t, not int.
7751 This avoids an unnecessary limitation on 64-bit machines, which
7752 caused (substring ...) to crash on large vectors (Bug#8344).
7753 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7754 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
7755 All variadic functions and their callers changed accordingly.
7756 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7757 * data.c (arith_driver, float_arith_driver): Likewise.
7758 * editfns.c (general_insert_function): Likewise.
7759 * eval.c (struct backtrace.nargs, interactive_p)
7760 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7761 (funcall_lambda, mark_backtrace): Likewise.
7762 * fns.c (concat): Likewise.
7763 * frame.c (x_set_frame_parameters): Likewise.
7764 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7765 0 if not found, not -1. All callers changed.
7766
7767 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7768 (stack_copy_size): Now size_t, not int.
7769 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7770
7771 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
7772
7773 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7774 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7775 All callers changed.
7776
7777 * lisp.h (multibyte_char_to_unibyte):
7778 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7779 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7780 * character.h (CHAR_TO_BYTE8):
7781 * cmds.c (internal_self_insert):
7782 * editfns.c (general_insert_function):
7783 * keymap.c (push_key_description):
7784 * search.c (Freplace_match):
7785 * xdisp.c (message_dolog, set_message_1): All callers changed.
7786
7787 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7788
7789 * keyboard.c (safe_run_hook_funcall): New function.
7790 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7791 don't set the hook to nil, but remove the offending function instead.
7792 (Qcommand_hook_internal): Remove, unused.
7793 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7794 Vcommand_hook_internal.
7795
7796 * eval.c (enum run_hooks_condition): Remove.
7797 (funcall_nil, funcall_not): New functions.
7798 (run_hook_with_args): Call each function through a `funcall' argument.
7799 Remove `cond' argument, now redundant.
7800 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7801 (Frun_hook_with_args_until_failure): Adjust accordingly.
7802 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7803
7804 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
7805
7806 * dispextern.h (string_buffer_position): Remove declaration.
7807
7808 * print.c (strout): Remove parameter `multibyte', unused since
7809 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7810
7811 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7812 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7813 All callers changed.
7814
7815 * w32.c (_wsa_errlist): Use braces for struct initializers.
7816
7817 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7818 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7819 All callers changed.
7820 (string_buffer_position): Likewise. Also, make static (it's never
7821 used outside xdisp.c).
7822 (cursor_row_p): Remove parameter `w', unused since
7823 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7824 (decode_mode_spec): Remove parameter `precision', introduced during
7825 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7826 All callers changed.
7827
7828 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7829
7830 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7831
7832 2011-03-27 Anders Lindgren <andlind@gmail.com>
7833
7834 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7835 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7836 (ns_update_auto_hide_menu_bar): New functions.
7837 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7838 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7839 ns_constrain_all_frames.
7840 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7841 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7842
7843 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7844
7845 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7846
7847 2011-03-27 Glenn Morris <rgm@gnu.org>
7848
7849 * syssignal.h: Replace RETSIGTYPE with void.
7850 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7851 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7852 Replace SIGTYPE with void everywhere.
7853 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7854 * s/template.h (SIGTYPE): Remove commented out definition.
7855
7856 2011-03-26 Eli Zaretskii <eliz@gnu.org>
7857
7858 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7859 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7860
7861 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
7862
7863 * w32.c (read_unc_volume): Use parameter `henum', instead of
7864 global variable `wget_enum_handle'.
7865
7866 * keymap.c (describe_vector): Remove parameters `indices' and
7867 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7868 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7869
7870 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7871
7872 * keyboard.c (timer_check): Remove parameter `do_it_now',
7873 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7874 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7875 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7876
7877 * keyboard.c (read_char):
7878 * w32menu.c (w32_menu_display_help):
7879 * xmenu.c (show_help_event, menu_help_callback):
7880 Adjust calls to `show_help_echo'.
7881
7882 * gtkutil.c (xg_maybe_add_timer):
7883 * keyboard.c (readable_events):
7884 * process.c (wait_reading_process_output):
7885 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7886
7887 * insdel.c (adjust_markers_gap_motion):
7888 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7889 (gap_left, gap_right): Don't call it.
7890
7891 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
7892
7893 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7894 incurred during fontification.
7895
7896 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
7897
7898 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7899 (DEFVAR_PER_BUFFER): Don't pass it.
7900
7901 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7902 (scrolling_window): Don't pass it.
7903
7904 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
7905
7906 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7907
7908 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7909 and `suffix'.
7910 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7911 of variables specific to SELinux and computation of `encoded_absname'.
7912
7913 * image.c (XPutPixel): Remove unused variable `height'.
7914
7915 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7916
7917 * unexw32.c (get_section_info): Remove unused variable `section'.
7918
7919 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7920 (system_process_attributes): Remove unused variable `sess'.
7921 (sys_read): Remove unused variable `err'.
7922
7923 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7924 (w32_wnd_proc): Remove unused variable `isdead'.
7925 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7926 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7927 (x_create_tip_frame): Remove unused variable `tem'.
7928
7929 * w32inevt.c (w32_console_read_socket):
7930 Remove unused variable `no_events'.
7931
7932 * w32term.c (x_draw_composite_glyph_string_foreground):
7933 Remove unused variable `width'.
7934
7935 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
7936
7937 * w32term.c (x_set_glyph_string_clipping):
7938 Don't pass uninitialized region to CombineRgn.
7939
7940 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
7941
7942 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7943 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7944 (Fx_close_connection): Remove unused variable `i'.
7945
7946 * w32font.c (w32font_draw): Return number of glyphs.
7947 (w32font_open_internal): Remove unused variable `i'.
7948 (w32font_driver): Add missing initializer.
7949
7950 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7951 (fill_in_menu): Remove unused variable `items_added'.
7952
7953 * w32term.c (last_mouse_press_frame): Remove static global variable.
7954 (w32_clip_to_row): Remove unused variable `f'.
7955 (x_delete_terminal): Remove unused variable `i'.
7956
7957 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7958 (NOTHING): Remove unused static global variable.
7959 (uniscribe_check_otf): Remove unused variable `table'.
7960 (uniscribe_font_driver): Add missing initializers.
7961
7962 2011-03-23 Julien Danjou <julien@danjou.info>
7963
7964 * term.c (Fsuspend_tty, Fresume_tty):
7965 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7966 * window.c (temp_output_buffer_show):
7967 * insdel.c (signal_before_change):
7968 * frame.c (Fhandle_switch_frame):
7969 * fileio.c (Fdo_auto_save):
7970 * emacs.c (Fkill_emacs):
7971 * editfns.c (save_excursion_restore):
7972 * cmds.c (internal_self_insert):
7973 * callint.c (Fcall_interactively):
7974 * buffer.c (Fkill_all_local_variables):
7975 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7976 Use Frun_hooks.
7977 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
7978 unconditionally since it does the check itself.
7979
7980 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
7981
7982 Fix more problems found by GCC 4.5.2's static checks.
7983
7984 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7985 the first time through the loop, since we know p0 < p1 then.
7986 This also avoids a gcc -Wstrict-overflow warning.
7987
7988 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7989 leading to a memory leak, possible in functions like
7990 load_charset_map_from_file that can allocate an unbounded number
7991 of objects (Bug#8318).
7992
7993 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7994 that could (at least in theory) be that large.
7995
7996 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7997 This is less likely to overflow, and avoids undefined behavior if
7998 overflow does occur. All callers changed. Use strtoul to scan
7999 for the unsigned long integer.
8000 (pint2hrstr): Simplify and tune code slightly.
8001 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8002
8003 * scroll.c (do_scrolling): Work around GCC bug 48228.
8004 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8005
8006 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8007 This also avoids a warning with gcc -Wstrict-overflow.
8008 (validate_x_resource_name): Simplify count usage.
8009 This also avoids a warning with gcc -Wstrict-overflow.
8010
8011 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8012 fail (Bug#8306).
8013
8014 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8015
8016 * process.c (Fmake_network_process): Use socklen_t, not int,
8017 where POSIX says socklen_t is required in portable programs.
8018 This fixes a porting bug on hosts like 64-bit HP-UX, where
8019 socklen_t is wider than int (Bug#8277).
8020 (Fmake_network_process, server_accept_connection):
8021 (wait_reading_process_output, read_process_output):
8022 Likewise.
8023
8024 * process.c: Rename or move locals to avoid shadowing.
8025 (list_processes_1, Fmake_network_process):
8026 (read_process_output_error_handler, exec_sentinel_error_handler):
8027 Rename or move locals.
8028 (Fmake_network_process): Define label "retry_connect" only if needed.
8029 (Fnetwork_interface_info): Fix pointer signedness.
8030 (process_send_signal): Add cast to avoid pointer signedness problem.
8031 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8032 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8033
8034 Make tparam.h and terminfo.c consistent.
8035 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8036 Include tparam.h instead, since it declares them.
8037 * cm.h (PC): Remove extern decl; tparam.h now does this.
8038 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8039 * terminfo.c: Include tparam.h, to check interfaces.
8040 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8041 (tparam): Adjust signature to match interface in tparam.h;
8042 this removes some undefined behavior. Check that outstring and len
8043 are zero, which they always are with Emacs.
8044 * tparam.h (PC, BC, UP): New extern decls.
8045
8046 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8047 (xftfont_open): Rename locals to avoid shadowing.
8048
8049 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8050 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8051 (OTF_TAG_SYM): Omit macro if not needed.
8052 (ftfont_list): Remove unused local.
8053 (get_adstyle_property, ftfont_pattern_entity):
8054 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8055 Rename locals to avoid shadowing.
8056
8057 * xfont.c (xfont_list_family): Mark var as initialized.
8058
8059 * xml.c (make_dom): Now static.
8060
8061 * composite.c (composition_compute_stop_pos): Rename local to
8062 avoid shadowing.
8063 (composition_reseat_it): Remove unused locals.
8064 (find_automatic_composition, composition_adjust_point): Likewise.
8065 (composition_update_it): Mark var as initialized.
8066 (find_automatic_composition): Mark vars as initialized,
8067 with a FIXME (Bug#8290).
8068
8069 character.h: Rename locals to avoid shadowing.
8070 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8071 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8072 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8073 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8074 to avoid shadowing.
8075
8076 * textprop.c (property_change_between_p): Remove; unused.
8077
8078 * intervals.c (interval_start_pos): Now static.
8079
8080 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8081
8082 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8083 Rename locals to avoid shadowing.
8084
8085 * sound.c (wav_play, au_play, Fplay_sound_internal):
8086 Fix pointer signedness.
8087 (alsa_choose_format): Remove unused local var.
8088 (wav_play): Initialize a variable to 0, to prevent undefined
8089 behavior (Bug#8278).
8090
8091 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8092
8093 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8094
8095 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8096 clobbering (Bug#8298).
8097 * sysdep.c (sys_subshell): Likewise.
8098 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
8099
8100 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8101 This should get cleaned up, so that child_setup has the
8102 same signature on all platforms.
8103
8104 * callproc.c (call_process_cleanup): Now static.
8105 (relocate_fd): Rename locals to avoid shadowing.
8106
8107 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
8108
8109 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8110 not to be necessary, and produces flickering.
8111
8112 2011-03-20 Glenn Morris <rgm@gnu.org>
8113
8114 * config.in: Remove file.
8115
8116 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
8117
8118 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8119 are now in src/globals.h.
8120 (syms_of_minibuf): Remove spurious & from previous change.
8121
8122 2011-03-20 Leo <sdl.web@gmail.com>
8123
8124 * minibuf.c (completing-read-function): New variable.
8125 (completing-read-default): Rename from completing-read.
8126 (completing-read): Call completing-read-function.
8127
8128 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8129
8130 * xfaces.c (Fx_load_color_file):
8131 Read color file from absolute filename (bug#8250).
8132
8133 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8134
8135 * makefile.w32-in: Update dependencies.
8136
8137 2011-03-17 Eli Zaretskii <eliz@gnu.org>
8138
8139 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8140
8141 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8142
8143 Fix more problems found by GCC 4.5.2's static checks.
8144
8145 * process.c (make_serial_process_unwind, send_process_trap):
8146 (sigchld_handler): Now static.
8147
8148 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8149 That way, the code declares only the vars that it needs.
8150 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8151 * s/cygwin.h (PTY_ITERATION): Likewise.
8152 * s/darwin.h (PTY_ITERATION): Likewise.
8153 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8154
8155 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8156 * process.c (allocate_pty): Don't declare stb unless it's needed.
8157
8158 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
8159 (CONSTANTLIM): Remove; unused.
8160 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8161 Define only if needed.
8162
8163 * unexelf.c (unexec): Name an expression,
8164 to avoid gcc -Wbad-function-cast warning.
8165 Use a different way to cause a compilation error if anyone uses
8166 n rather than nn, a way that does not involve shadowing.
8167 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
8168
8169 * deps.mk (unexalpha.o): Remove; unused.
8170
8171 New file unexec.h, the (simple) interface for unexec (Bug#8267).
8172 * unexec.h: New file.
8173 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8174 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8175 Depend on unexec.h.
8176 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8177 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8178 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
8179 Change as necessary to match prototype in unexec.h.
8180
8181 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8182 shadowing.
8183 (back_comment, skip_chars): Mark vars as initialized.
8184
8185 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8186 Rename locals to avoid shadowing.
8187
8188 * lread.c (read1): Rewrite so as not to use empty "else".
8189 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
8190
8191 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8192
8193 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8194 warning when compiling print.c.
8195
8196 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8197 instead of using an uninitialized var.
8198 (font_sort_entities): Mark var as initialized.
8199
8200 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8201
8202 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8203 pointers to constants.
8204 (font_parse_fcname): Remove unused vars.
8205 (font_delete_unmatched): Now static.
8206 (font_get_spec): Remove; unused.
8207 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8208 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8209 Rename or move locals to avoid shadowing.
8210
8211 * fns.c (require_nesting_list, require_unwind): Now static.
8212 (Ffillarray): Rename locals to avoid shadowing.
8213
8214 * floatfns.c (domain_error2): Define only if needed.
8215 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
8216
8217 * alloc.c (mark_backtrace): Move decl from here ...
8218 * lisp.h: ... to here, so that it can be checked.
8219
8220 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
8221 (Fdefvar): Rewrite so as not to use empty "else".
8222 (lisp_indirect_variable): Name an expression,
8223 to avoid gcc -Wbad-function-cast warning.
8224 (Fdefvar): Rename locals to avoid shadowing.
8225
8226 * callint.c (quotify_arg, quotify_args): Now static.
8227 (Fcall_interactively): Rename locals to avoid shadowing.
8228 Use const pointer when appropriate.
8229
8230 * lisp.h (get_system_name, get_operating_system_release):
8231 Move decls here, to check interfaces.
8232 * process.c (get_operating_system_release): Move decl to lisp.h.
8233 * xrdb.c (get_system_name): Likewise.
8234 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8235 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8236 some of which prompt warnings from gcc -Wbad-function-cast.
8237 (Fformat_time_string, Fencode_time, Finsert_char):
8238 (Ftranslate_region_internal, Fformat):
8239 Rename or remove local vars to avoid shadowing.
8240 (Ftranslate_region_internal): Mark var as initialized.
8241
8242 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8243 avoid shadowing.
8244
8245 * lisp.h (eassert): Check that the argument compiles, even if
8246 ENABLE_CHECKING is not defined.
8247
8248 * data.c (Findirect_variable): Name an expression, to avoid
8249 gcc -Wbad-function-cast warning.
8250 (default_value, arithcompare, arith_driver, arith_error): Now static.
8251 (store_symval_forwarding): Rename local to avoid shadowing.
8252 (Fmake_variable_buffer_local, Fmake_local_variable):
8253 Mark variables as initialized.
8254 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
8255
8256 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
8257 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8258 Rename locals to avoid shadowing.
8259 (mark_stack): Move local variables into the #ifdef region where
8260 they're used.
8261 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8262 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8263 needed otherwise.
8264 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8265 (GC_STRING_CHARS): Remove; not used.
8266 (Fmemory_limit): Cast sbrk's returned value to char *.
8267
8268 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8269 avoids undefined behavior in theory.
8270
8271 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8272
8273 Use functions, not macros, for up- and down-casing (Bug#8254).
8274 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8275 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8276 to use the following functions instead of these macros.
8277 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8278 EMACS_INT, since callers assume the returned value fits in int.
8279 (upcase1): Likewise, for UPCASE_TABLE.
8280 (uppercasep, lowercasep, upcase): New static inline functions.
8281 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
8282 the race-condition problem in the old DOWNCASE.
8283
8284 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8285 Rename locals to avoid shadowing.
8286 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
8287 (regex_compile, re_search_2, re_match_2_internal):
8288 Remove unused local vars.
8289 (FREE_VAR): Rewrite so as not to use empty "else",
8290 which gcc can warn about.
8291 (regex_compile, re_match_2_internal): Mark locals as initialized.
8292 (RETALLOC_IF): Define only if needed.
8293 (WORDCHAR_P): Likewise. This one is never needed, but is used
8294 only in a comment talking about a compiler bug, so put inside
8295 the #if 0 of that comment.
8296 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8297 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8298 Remove; unused.
8299
8300 * search.c (boyer_moore): Rename locals to avoid shadowing.
8301 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8302 (PREV_CHAR_BOUNDARY): Likewise.
8303
8304 * search.c (simple_search): Remove unused var.
8305
8306 * dired.c (compile_pattern): Move decl from here ...
8307 * lisp.h: ... to here, so that it can be checked.
8308 (struct re_registers): New forward decl.
8309
8310 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8311
8312 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8313 All uses changed.
8314 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8315 Rename locals to avoid shadowing.
8316 (Fvertical_motion): Mark locals as initialized.
8317
8318 * casefiddle.c (casify_object, casify_region): Now static.
8319 (casify_region): Mark local as initialized.
8320
8321 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8322
8323 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8324 New macros, so that the caller can use some names other than
8325 gcpro1, gcpro2, etc.
8326 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8327 of the new macros.
8328 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8329 argument, for consistency with GCPRO2_VAR, etc: it is now the
8330 prefix of the variable, not the variable itself. All uses
8331 changed.
8332 * dired.c (directory_files_internal, file_name_completion):
8333 Rename locals to avoid shadowing.
8334
8335 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8336 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8337 dired.c's scmp function, had undefined behavior.
8338 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8339 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8340 * buffer.h: ... to here, because these macros use current_buffer,
8341 and the new implementation with inline functions needs to have
8342 current_buffer in scope now, rather than later when the macros
8343 are used.
8344 (downcase, upcase1): New static inline functions.
8345 (DOWNCASE, UPCASE1): Reimplement using these functions.
8346 This avoids undefined behavior in expressions like
8347 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8348 from race conditions in accessing the global variables
8349 case_temp1 and case_temp2.
8350 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8351 * lisp.h (case_temp1, case_temp2): Remove their decls.
8352 * character.h (ASCII_CHAR_P): Move from here ...
8353 * lisp.h: ... to here, so that the inline functions mentioned
8354 above can use them.
8355
8356 * dired.c (directory_files_internal_unwind): Now static.
8357
8358 * fileio.c (file_name_as_directory, directory_file_name):
8359 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8360 Now static.
8361 (file_name_as_directory): Use const pointers when appropriate.
8362 (Fexpand_file_name): Likewise. In particular, newdir might
8363 point at constant storage, so make it a const pointer.
8364 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
8365 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8366 signedness issues.
8367 (Fset_file_times, Finsert_file_contents, auto_save_error):
8368 Rename locals to avoid shadowing.
8369
8370 * minibuf.c (choose_minibuf_frame_1): Now static.
8371 (Ftry_completion, Fall_completions): Rename or remove locals
8372 to avoid shadowing.
8373
8374 * marker.c (bytepos_to_charpos): Remove; unused.
8375
8376 * lisp.h (verify_bytepos, count_markers): New decls,
8377 so that gcc does not warn that these functions aren't declared.
8378
8379 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8380 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
8381 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
8382 (copy_text): Remove unused local var.
8383
8384 * filelock.c (within_one_second): Now static.
8385 (lock_file_1): Rename local to avoid shadowing.
8386
8387 * buffer.c (fix_overlays_before): Mark locals as initialized.
8388 (fix_start_end_in_overlays): Likewise. This function should be
8389 simplified by using pointers-to-pointers, but that's a different
8390 matter.
8391 (switch_to_buffer_1): Now static.
8392 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8393 (report_overlay_modification): Rename locals to avoid shadowing.
8394
8395 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
8396 Fix pointer signedness issue.
8397 (sys_subshell): Mark local as volatile if checking for lint,
8398 to suppress a gcc -Wclobbered warning that does not seem to be right.
8399 (MAXPATHLEN): Define only if needed.
8400
8401 * process.c (serial_open, serial_configure): Move decls from here ...
8402 * systty.h: ... to here, so that they can be checked.
8403
8404 * fns.c (get_random, seed_random): Move extern decls from here ...
8405 * lisp.h: ... to here, so that they can be checked.
8406
8407 * sysdep.c (reset_io): Now static.
8408 (wait_for_termination_signal): Remove; unused.
8409
8410 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8411 (copy_keymap_item, append_key, push_text_char_description):
8412 Now static.
8413 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
8414 (DENSE_TABLE_SIZE): Remove; unused.
8415 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8416 (describe_map_tree):
8417 Rename locals to avoid shadowing.
8418
8419 * keyboard.c: Declare functions static if they are not used elsewhere.
8420 (echo_char, echo_dash, cmd_error, top_level_2):
8421 (poll_for_input, handle_async_input): Now static.
8422 (read_char, kbd_buffer_get_event, make_lispy_position):
8423 (make_lispy_event, make_lispy_movement, apply_modifiers):
8424 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8425 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8426 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
8427 (read_key_sequence, read_char): Mark locals as initialized.
8428 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
8429
8430 * keyboard.h (make_ctrl_char): New decl.
8431 (mark_kboards): Move decl here ...
8432 * alloc.c (mark_kboards): ... from here.
8433
8434 * lisp.h (force_auto_save_soon): New decl.
8435
8436 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
8437 (DEFINE_DUMMY_FUNCTION): New macro.
8438 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8439 Use it.
8440 (main): Add casts to avoid warnings
8441 if GCC considers string literals to be constants.
8442
8443 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8444
8445 * dbusbind.c: Pointer signedness fixes.
8446 (xd_signature, xd_append_arg, xd_initialize):
8447 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8448 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8449 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8450 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8451
8452 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8453 if GCC considers string literals to be constants.
8454 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
8455
8456 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8457
8458 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8459 (print_preprocess, print_object): New macro to fix last change.
8460
8461 * print.c (print_preprocess): Don't forget font objects.
8462
8463 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
8464
8465 * emacs.c (USAGE3): Doc fixes.
8466
8467 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8468
8469 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8470 structure.
8471
8472 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
8473
8474 * lisp.h (VWindow_system, Qfile_name_history):
8475 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8476 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8477 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8478
8479 * w32select.c: Don't #include "keyboard.h".
8480 (run_protected): Add extern declaration for waiting_for_input.
8481
8482 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8483 * w32console.c (detect_input_pending, read_input_pending)
8484 (encode_terminal_code):
8485 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8486 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8487 (w32_system_caret_y, Qfile_name_history):
8488 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8489 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8490 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8491 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8492 * w32proc.c (Qlocal, report_file_error):
8493 * w32term.c (Vwindow_system, updating_frame):
8494 * w32uniscribe.c (initialized, uniscribe_font_driver):
8495 Remove unneeded extern declarations.
8496
8497 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
8498
8499 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
8500
8501 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
8502
8503 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8504 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8505 These macros can no longer be used for assignment.
8506
8507 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8508 Assign struct members directly, instead of using BUF_BEGV etc.
8509 (record_buffer_markers, fetch_buffer_markers): New functions for
8510 recording and fetching special buffer markers.
8511 (set_buffer_internal_1, set_buffer_temp): Use them.
8512
8513 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8514
8515 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8516
8517 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8518 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8519
8520 * xdisp.c (hscroll_window_tree):
8521 (reconsider_clip_changes): Use PT instead of BUF_PT.
8522
8523 2011-03-13 Eli Zaretskii <eliz@gnu.org>
8524
8525 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8526 $(EMACS_ROOT)/lib/intprops.h.
8527
8528 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8529
8530 Fix more problems found by GCC 4.5.2's static checks.
8531
8532 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8533 to unsigned char * to avoid compiler diagnostic.
8534 (xg_free_frame_widgets): Make it clear that a local variable is
8535 needed only if USE_GTK_TOOLTIP.
8536 (gdk_window_get_screen): Make it clear that this macro is needed
8537 only if USE_GTK_TOOLTIP.
8538 (int_gtk_range_get_value): New function, which avoids a diagnostic
8539 from gcc -Wbad-function-cast.
8540 (xg_set_toolkit_scroll_bar_thumb): Use it.
8541 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8542 diagnostic from gcc -Wbad-function-cast.
8543 (get_utf8_string, xg_get_file_with_chooser):
8544 Rename locals to avoid shadowing.
8545 (create_dialog): Move locals to avoid shadowing.
8546
8547 * xgselect.c (xg_select): Remove unused var.
8548
8549 * image.c (four_corners_best): Mark locals as initialized.
8550 (gif_load): Initialize transparent_p to zero (Bug#8238).
8551 Mark another local as initialized.
8552 (my_png_error, my_error_exit): Mark with NO_RETURN.
8553
8554 * image.c (clear_image_cache): Now static.
8555 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
8556 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
8557 (x_edge_detection): Remove unnecessary cast that
8558 gcc -Wbad-function-cast diagnoses.
8559 (gif_load): Fix pointer signedness.
8560 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8561 (jpeg_load, gif_load): Rename locals to avoid shadowing.
8562
8563 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
8564
8565 Improve quality of tests for time stamp overflow.
8566 For example, without this patch (encode-time 0 0 0 1 1
8567 1152921504606846976) returns the obviously-bogus value (-948597
8568 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8569 reports time overflow. See
8570 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
8571 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8572 * editfns.c: Include limits.h and intprops.h.
8573 (TIME_T_MIN, TIME_T_MAX): New macros.
8574 (time_overflow): Move earlier, to before first use.
8575 (hi_time, lo_time): New functions, for an accurate test for
8576 out-of-range times.
8577 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8578 (Fget_internal_run_time): Don't assume time_t fits in int.
8579 (make_time): Use list2 instead of Fcons twice.
8580 (Fdecode_time): More accurate test for out-of-range times.
8581 (check_tm_member): New function.
8582 (Fencode_time): Use it, to test for out-of-range times.
8583 (lisp_time_argument): Don't rely on undefined left-shift and
8584 right-shift behavior when checking for time stamp overflow.
8585
8586 * editfns.c (time_overflow): New function, refactoring common code.
8587 (Fformat_time_string, Fdecode_time, Fencode_time):
8588 (Fcurrent_time_string): Use it.
8589
8590 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8591 * dired.c (make_time): Move to ...
8592 * editfns.c (make_time): ... here.
8593 * systime.h: Note the move.
8594
8595 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8596
8597 * fringe.c (update_window_fringes): Remove unused variables.
8598
8599 * unexmacosx.c (copy_data_segment): Also copy __got section.
8600 (Bug#8223)
8601
8602 2011-03-12 Eli Zaretskii <eliz@gnu.org>
8603
8604 * termcap.c [MSDOS]: Include "msdos.h".
8605 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8606 Constify `char *' arguments and their references according to
8607 prototypes in tparam.h.
8608
8609 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
8610
8611 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8612 Adapt all references accordingly.
8613
8614 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8615
8616 2011-03-11 Tom Tromey <tromey@redhat.com>
8617
8618 * buffer.c (syms_of_buffer): Remove obsolete comment.
8619
8620 2011-03-11 Eli Zaretskii <eliz@gnu.org>
8621
8622 * termhooks.h (encode_terminal_code): Declare prototype.
8623
8624 * msdos.c (encode_terminal_code): Don't declare prototype.
8625
8626 * term.c (encode_terminal_code): Now external again, used by
8627 w32console.c and msdos.c.
8628
8629 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8630 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
8631
8632 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
8633
8634 Fix some minor problems found by GCC 4.5.2's static checks.
8635
8636 * fringe.c (update_window_fringes): Mark locals as initialized
8637 (Bug#8227).
8638 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
8639
8640 * alloc.c (mark_fringe_data): Move decl from here ...
8641 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8642 to check its interface.
8643 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8644
8645 * fontset.c (free_realized_fontset): Now static.
8646 (Fset_fontset_font): Rename local to avoid shadowing.
8647 (fontset_font): Mark local as initialized.
8648 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
8649
8650 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8651
8652 * xselect.c (x_disown_buffer_selections): Remove; not used.
8653 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
8654 (x_own_selection, Fx_disown_selection_internal): Rename locals
8655 to avoid shadowing.
8656 (x_handle_dnd_message): Remove local to avoid shadowing.
8657
8658 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8659 so that the caller can use some name other than gcpro1.
8660 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
8661 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8662 (Fx_backspace_delete_keys_p):
8663 Use them to avoid shadowing, and rename vars to avoid shadowing.
8664 (x_decode_color, x_set_name, x_window): Now static.
8665 (Fx_create_frame): Add braces to silence GCC warning.
8666 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
8667 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8668 Remove unused locals.
8669 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8670 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8671 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8672 macros.
8673
8674 * xterm.h (x_mouse_leave): New decl.
8675
8676 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8677 Remove unused functions.
8678 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8679 (x_calc_absolute_position): Now static.
8680 (XTread_socket): Don't define label "out" unless it's used.
8681 Don't declare local "event" unless it's used.
8682 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8683 unless they are used.
8684 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8685 (x_fatal_error_signal): Remove; not used.
8686 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8687 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8688 (x_error_catcher, x_connection_closed, x_error_handler):
8689 (x_error_quitter, xembed_send_message, x_iconify_frame):
8690 (my_log_handler): Rename locals to avoid shadowing.
8691 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
8692 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
8693
8694 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8695 Rename or move locals to avoid shadowing.
8696 (tty_defined_color, merge_face_heights): Now static.
8697 (free_realized_faces_for_fontset): Remove; not used.
8698 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8699 does not deduce is never used uninitialized.
8700 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8701 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
8702
8703 * terminal.c (store_terminal_param): Now static.
8704
8705 * xmenu.c (menu_highlight_callback): Now static.
8706 (set_frame_menubar): Remove unused local.
8707 (xmenu_show): Rename parameter to avoid shadowing.
8708 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8709 since they might point to immutable storage.
8710 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8711 since it's unused otherwise.
8712
8713 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
8714 Add a FIXME, since the code still doesn't look right. (Bug#8215)
8715 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8716 avoids a gcc -Wuninitialized diagnostic.
8717 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
8718 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8719 does not deduce are never used uninitialized.
8720
8721 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8722
8723 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
8724 * window.c (window_loop, size_window):
8725 (run_window_configuration_change_hook, enlarge_window): Likewise.
8726
8727 * window.c (display_buffer): Now static.
8728 (size_window): Mark variables that gcc -Wuninitialized
8729 does not deduce are never used uninitialized.
8730 * window.h (check_all_windows): New decl, to forestall
8731 gcc -Wmissing-prototypes diagnostic.
8732 * dispextern.h (bidi_dump_cached_states): Likewise.
8733
8734 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8735 shadowing.
8736 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
8737 Include <limits.h>.
8738 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8739 and to avoid gcc -Wuninitialized warning.
8740 (load_charset_map): Mark variables that gcc -Wuninitialized
8741 does not deduce are never used uninitialized.
8742 (load_charset): Abort instead of using uninitialized var (Bug#8229).
8743
8744 * coding.c (coding_set_source, coding_set_destination):
8745 Use "else { /* comment */ }" rather than "else /* comment */;"
8746 for clarity, and to avoid gcc -Wempty-body warning.
8747 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8748 a block, when the outer 'i' will do.
8749 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8750 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8751 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8752 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8753 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8754 Rename locals to avoid shadowing.
8755 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
8756 * coding.c (emacs_mule_char, encode_invocation_designation):
8757 Now static, since they're not used elsewhere.
8758 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
8759 (decode_coding_object, encode_coding_object, detect_coding_system):
8760 (decode_coding_emacs_mule): Mark variables that gcc
8761 -Wuninitialized does not deduce are never used uninitialized.
8762 (detect_coding_iso_2022): Initialize a local variable that might
8763 be used uninitialized. Leave a FIXME because it's not clear that
8764 this initialization is needed. (Bug#8211)
8765 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8766 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8767 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8768 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8769 Remove unused macros.
8770
8771 * category.c (hash_get_category_set): Remove unused local var.
8772 (copy_category_table): Now static, since it's not used elsewhere.
8773 * character.c (string_count_byte8): Likewise.
8774
8775 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8776 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8777
8778 * chartab.c (copy_sub_char_table): Now static, since it's not used
8779 elsewhere.
8780 (sub_char_table_ref_and_range, char_table_ref_and_range):
8781 Rename locals to avoid shadowing.
8782 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
8783
8784 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
8785 (BIDI_BOB): Remove unused macro.
8786
8787 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8788 deduce are never used uninitialized.
8789 * term.c (encode_terminal_code): Likewise.
8790
8791 * term.c (encode_terminal_code): Now static. Remove unused local.
8792
8793 * tparam.h: New file.
8794 * term.c, tparam.h: Include it.
8795 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8796 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8797 Move these decls to tparam.h, and make them agree with what
8798 is actually in tparam.c. The previous trick of using incompatible
8799 decls in different modules does not conform to the C standard.
8800 All callers of tparam changed to use tparam's actual API.
8801 * tparam.c (tparam1, tparam, tgoto):
8802 Use const pointers where appropriate.
8803
8804 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8805 * cm.h (struct cm): Likewise.
8806 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8807 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8808 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8809 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8810 (turn_on_face, init_tty): Likewise.
8811 * termchar.h (struct tty_display_info): Likewise.
8812
8813 * term.c (term_mouse_position): Rename local to avoid shadowing.
8814
8815 * alloc.c (mark_ttys): Move decl from here ...
8816 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8817
8818 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8819
8820 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8821
8822 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
8823
8824 * search.c (compile_pattern_1): Remove argument regp, unused since
8825 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8826 (compile_pattern): Don't pass it.
8827
8828 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8829
8830 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8831 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8832 for ! HAVE_GTK3.
8833 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8834
8835 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8836
8837 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8838 gdk_window_get_screen, gdk_window_get_geometry,
8839 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8840 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8841 (xg_get_pixbuf_from_pixmap): New function.
8842 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8843 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8844 Call xg_get_pixbuf_from_pixmap instead of
8845 gdk_pixbuf_get_from_drawable.
8846 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8847 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8848 (xg_check_special_colors): Use GtkStyleContext and its functions
8849 for HAVE_GTK3.
8850 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8851 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8852 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
8853 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8854 Call gtk_widget_get_preferred_size.
8855 (xg_frame_resized): gdk_window_get_geometry only takes 5
8856 parameters.
8857 (xg_win_to_widget, xg_event_is_for_menubar):
8858 Call gdk_x11_window_lookup_for_display.
8859 (xg_set_widget_bg): New function.
8860 (delete_cb): New function.
8861 (xg_create_frame_widgets): Connect delete-event to delete_cb.
8862 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
8863 (xg_set_background_color): Call xg_set_widget_bg.
8864 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8865 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8866 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8867 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8868 if ! HAVE_GTK3.
8869 (update_frame_tool_bar): Call gtk_widget_hide.
8870 (xg_initialize): Use GDK_KEY_g.
8871
8872 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8873 if ! HAVE_GTK3
8874 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8875
8876 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8877 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8878 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8879
8880 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
8881
8882 * w32xfns.c (select_palette): Check success of RealizePalette against
8883 GDI_ERROR, not zero.
8884
8885 See ChangeLog.11 for earlier changes.
8886
8887 ;; Local Variables:
8888 ;; coding: utf-8
8889 ;; End:
8890
8891 Copyright (C) 2011 Free Software Foundation, Inc.
8892
8893 This file is part of GNU Emacs.
8894
8895 GNU Emacs is free software: you can redistribute it and/or modify
8896 it under the terms of the GNU General Public License as published by
8897 the Free Software Foundation, either version 3 of the License, or
8898 (at your option) any later version.
8899
8900 GNU Emacs is distributed in the hope that it will be useful,
8901 but WITHOUT ANY WARRANTY; without even the implied warranty of
8902 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8903 GNU General Public License for more details.
8904
8905 You should have received a copy of the GNU General Public License
8906 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.