1 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3 * minibuf.c (Fassoc_string): Remove duplicate declaration.
5 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
6 Convert pctcpu and pctmem to Lisp float properly.
7 Let the compiler fold better, as 100.0/0x8000 is exact.
9 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
11 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
14 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
16 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
18 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
20 For a 'struct window', replace some Lisp_Object fields to
21 bitfields where appropriate, remove unused fields.
22 * window.h (struct window): Remove unused 'last_mark_x' and
23 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
24 change it's type from Lisp_Object to bitfield.
25 Change type of 'force_start', 'optional_new_start',
26 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
27 fields from Lisp_Object to bitfield. Adjust users accordingly.
29 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
31 Pacify gcc -Wdouble-precision when using Xaw.
32 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
33 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
34 Use 'float' consistently, rather than 'float' in most places
35 and 'double' in a couple of places.
37 2012-05-31 Eli Zaretskii <eliz@gnu.org>
39 * xdisp.c (handle_stop): Detect whether we have overlay strings
40 loaded by testing it->current.overlay_string_index to be
41 non-negative, instead of checking whether n_overlay_strings is
44 2012-05-31 Chong Yidong <cyd@gnu.org>
46 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
48 * doc.c (Fsubstitute_command_keys): Doc fix.
50 2012-05-31 Eli Zaretskii <eliz@gnu.org>
52 * search.c (search_buffer): Remove calls to
53 r_alloc_inhibit_buffer_relocation, as it is now called by
54 maybe_unify_char, which was the cause of relocation of buffer text
57 2012-05-31 Eli Zaretskii <eliz@gnu.org>
59 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
60 for the duration of call to load_charset, to avoid problems with
61 callers of maybe_unify_char that access buffer text through C
64 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
65 decrement the inhibition flag, instead of just setting or
68 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
70 Remove obsolete '#define static' cruft.
71 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
72 This #undef was "temporary" in 2000; it is no longer needed
73 now that '#define static' has gone away.
74 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
75 (gray_bitmap_bits): Remove; no longer needed.
76 All uses replaced with definiens.
77 * xterm.c: Include "bitmaps/gray.xbm".
79 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
81 Clean up __executable_start, monstartup when --enable-profiling.
82 The following changes affect the code only when profiling.
83 * dispnew.c (__executable_start): Rename from safe_bcopy.
84 Define only on platforms that need it.
85 * emacs.c: Include <sys/gmon.h> when profiling.
86 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
87 (__executable_start): Remove decl, since lisp.h does it now.
88 (safe_bcopy): Remove decl; no longer has that name.
89 (main): Coalesce #if into single bit of code, for simplicity.
90 Cast pointers to uintptr_t, since standard libraries want integers
92 * lisp.h (__executable_start): New decl.
94 2012-05-31 Glenn Morris <rgm@gnu.org>
96 * image.c (Fimagemagick_types): Doc fix.
98 2012-05-30 Jim Meyering <meyering@redhat.com>
100 * callproc.c (Fcall_process_region): Include directory component
101 in mkstemp error message (Bug#11586).
103 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
105 * alloc.c, lisp.h (make_pure_vector): Now static.
107 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
109 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
111 (Fautoload): Do the hash-doc more carefully.
112 * data.c (Fdefalias): Purify definition, except for keymaps.
113 (Qdefun): Move from eval.c.
114 * lisp.h (Qdefun): Remove.
115 * lread.c (read1): Tiny simplification.
117 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
119 Do not create empty overlays with the evaporate property (Bug#9642).
120 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
121 Bug#9642, but explicitly check that the buffer the overlay would
122 be moved to is live and rearrange lines to make sure that errors
123 will not put the overlay in an inconsistent state.
124 (Fdelete_overlay): Cosmetics.
126 2012-05-28 Eli Zaretskii <eliz@gnu.org>
128 * w32term.c (my_bring_window_to_top): New function.
129 (x_raise_frame): Use handle returned by DeferWindowPos, which
130 could be different from the original one.
131 Call my_bring_window_to_top instead of my_set_foreground_window.
134 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
135 by calling BringWindowToTop.
137 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
138 (WM_EMACS_END): Increase by one.
140 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
142 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
143 This avoids undefined behavior that might cause the eassert
144 to not catch an out-of-range value.
146 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
148 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
151 2012-05-27 Eli Zaretskii <eliz@gnu.org>
153 * bidi.c (bidi_mirror_char): Fix last change.
155 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
157 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
158 when referring to sectname field in printf format.
160 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
162 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
163 Only r_alloc_inhibit_buffer_relocation needed to be added;
164 the others were already declared.
166 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
167 before checking whether it's out of range. Put the check inside
169 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
171 2012-05-27 Ken Brown <kbrown@cornell.edu>
173 * callproc.c (Fcall_process): Restore a line that was accidentally
174 commented out in the 2011-02-13 change (bug#11547).
176 2012-05-27 Eli Zaretskii <eliz@gnu.org>
178 * lisp.h [REL_ALLOC]: Add prototypes for external functions
181 * buffer.c [REL_ALLOC]: Remove prototypes of
182 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
183 they are now on lisp.h.
185 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
187 * search.c (search_buffer): Use it to inhibit relocation of buffer
188 text while re_search_2 is doing its job, because re_search_2 is
189 passed C pointers to buffer text. (Bug#11519)
191 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
194 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
195 state after an additional call to move_it_in_display_line_to, keep
196 the values of it->max_ascent and it->max_descent found for the
198 (pos_visible_p): Revert the comparison against bottom_y to what it
199 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
202 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
204 Fix coding-related core dumps with gcc -ftrapv.
205 The code was computing A - B, where A and B are pointers, and B is
206 random garbage. This can lead to core dumps on platforms that
207 have special pointer registers, and it also leads to core dumps on
208 x86-64 when compiled with gcc -ftrapv. The fix is to compute
209 A - B only when B is initialized properly.
210 * coding.c (coding_set_source, coding_set_destination): Return void.
211 (coding_change_source, coding_change_destinations): New functions,
212 with the old behaviors of coding_set_source and coding_set_destination.
213 All callers that need an offset changed to use these new functions.
215 2012-05-26 Glenn Morris <rgm@gnu.org>
217 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
219 2012-05-26 Eli Zaretskii <eliz@gnu.org>
221 Extend mouse support on W32 text-mode console.
222 * xdisp.c (draw_row_with_mouse_face):
223 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
225 * w32console.c: Include window.h.
226 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
228 (initialize_w32_display): Initialize mouse-highlight data.
230 * w32inevt.c: Include termchar.h and window.h.
231 (do_mouse_event): Support mouse-autoselect-window. When the mouse
232 moves, call note_mouse_highlight. If help_echo changed, call
233 gen_help_event to produce help-echo message in the echo area.
234 Call clear_mouse_face if mouse_face_hidden is set in the mouse
237 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
239 * lread.c (read1): Simplify slightly to avoid an overflow warning
240 with GCC 4.7.0 on x86-64.
242 2012-05-26 Eli Zaretskii <eliz@gnu.org>
244 * bidi.c (bidi_mirror_char): Revert last change: an int is
245 definitely wide enough here.
247 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
249 Fix integer width and related bugs (Bug#9874).
250 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
251 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
252 (string_bytes, check_sblock, allocate_string_data):
253 (compact_small_strings, Fmake_bool_vector, make_string)
254 (make_unibyte_string, make_multibyte_string)
255 (make_string_from_bytes, make_specified_string)
256 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
257 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
259 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
260 (allocate_pseudovector):
261 Use int, not EMACS_INT, where int is wide enough.
262 (inhibit_garbage_collection, Fgarbage_collect):
263 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
264 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
265 int might not be wide enough.
266 (bidi_cache_search, bidi_cache_find, bidi_init_it)
267 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
268 (bidi_at_paragraph_end, bidi_find_paragraph_start)
269 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
270 (bidi_level_of_next_char, bidi_move_to_visually_next):
271 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
272 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
273 (Fkill_buffer, Fset_buffer_major_mode)
274 (advance_to_char_boundary, Fbuffer_swap_text)
275 (Fset_buffer_multibyte, overlays_at, overlays_in)
276 (overlay_touches_p, struct sortvec, record_overlay_string)
277 (overlay_strings, recenter_overlay_lists)
278 (adjust_overlays_for_insert, adjust_overlays_for_delete)
279 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
280 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
281 (Foverlay_recenter, last_overlay_modification_hooks_used)
282 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
283 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
284 (validate_region): Omit unnecessary test for b <= e,
285 since that's guaranteed by the previous test.
286 (adjust_overlays_for_delete): Avoid pos + length overflow.
287 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
288 (report_overlay_modification):
289 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
290 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
291 Omit pointer cast, which isn't needed anyway, and doesn't work
292 after the EMACS_INT -> ptrdiff_t change.
293 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
294 * buffer.h: Adjust decls to match defn changes elsewhere.
295 (struct buffer_text, struct buffer):
296 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
297 Use EMACS_INT, not int, where int might not be wide enough.
298 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
299 not int, to avoid needless 32-bit limit on 64-bit hosts.
300 (exec_byte_code): Use tighter memory-full test, one that checks
301 for alloca overflow. Don't compute the address of the object just
302 before an array, as that's not portable. Use EMACS_INT, not
303 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
304 * callint.c (Fcall_interactively):
305 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
306 * callproc.c (call_process_kill, Fcall_process):
307 Don't assume pid_t fits into an Emacs fixnum.
308 (call_process_cleanup, Fcall_process, child_setup):
309 Don't assume pid_t fits into int.
310 (call_process_cleanup, Fcall_process, delete_temp_file)
311 (Fcall_process_region):
312 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
313 (Fcall_process): Simplify handling of volatile integers.
314 Use int, not EMACS_INT, where int will do.
315 * casefiddle.c (casify_object, casify_region, operate_on_word)
316 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
317 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
318 (casify_object): Avoid integer overflow when overallocating buffer.
319 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
320 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
321 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
322 * category.h (CATEGORYP): Don't assume arg is nonnegative.
323 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
324 integers are now checked earlier. All uses replaced with XINT.
326 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
327 For CCL_MapSingle, check that content and value are in int range.
328 (ccl_driver, Fregister_code_conversion_map):
329 Check that Vcode_version_map_vector is a vector.
330 (resolve_symbol_ccl_program): Check that vector header is in range.
331 Always copy the vector, so that we can check its contents reliably
332 now rather than having to recheck each instruction as it's being
333 executed. Check that vector words fit in 'int'.
334 (ccl_get_compiled_code, Fregister_ccl_program)
335 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
336 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
337 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
338 contents are in range.
339 (Fccl_execute_on_string): Check that status is in range.
340 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
341 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
342 Accept and return EMACS_INT, not int, because callers can pass values
344 (c_string_width, strwidth, lisp_string_width, chars_in_text)
345 (multibyte_chars_in_text, parse_str_as_multibyte)
346 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
347 (str_as_unibyte, str_to_unibyte, string_count_byte8)
348 (string_escape_byte8, Fget_byte):
349 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
350 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
351 avoid mishandling large integers.
352 * character.h: Adjust decls to match defn changes elsewhere.
353 * charset.c (load_charset_map_from_file, find_charsets_in_text)
354 (Ffind_charset_region):
355 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
356 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
357 (load_charset_map_from_vector, Fdefine_charset_internal):
358 Don't assume fixnum fits in int.
359 (load_charset_map_from_vector, Fmap_charset_chars):
360 Remove now-unnecessary CHECK_NATNUMs.
361 (Fdefine_charset_internal): Check ranges here, more carefully.
362 Don't rely on undefined behavior with signed left shift overflow.
363 Don't assume unsigned int fits into fixnum, or that fixnum fits
364 into unsigned int. Don't require max_code to be a valid fixnum;
365 that's not true for gb10830 4-byte on a 32-bit host. Allow
366 invalid_code to be a cons, for the same reason. Require code_offset
367 to be a character. Avoid int overflow if max_char is close
369 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
370 this is intended anyway and avoids some undefined behavior.
371 (load_charset_map): Pass unsigned, not int, as 2nd arg of
372 INDEX_TO_CODE_POINT, as that's what it expects.
373 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
374 * charset.h (DECODE_CHAR): Return int, not unsigned;
375 this is what was intended anyway, and it avoids undefined behavior.
376 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
377 integer-overflow issues.
378 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
379 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
380 where the argument is EMACS_INT, and this behavior is not intended.
381 * chartab.c (Fmake_char_table, Fset_char_table_range)
382 (uniprop_get_decoder, uniprop_get_encoder):
383 Don't assume fixnum fits in int.
384 * cmds.c (move_point): New function, that does the gist of
385 Fforward_char and Fbackward_char, but does so while checking
386 for integer overflow more accurately.
387 (Fforward_char, Fbackward_char): Use it.
388 (Fforward_line, Fend_of_line, internal_self_insert)
389 (internal_self_insert):
390 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
391 Fix a FIXME, by checking for integer overflow when calculating
392 target_clm and actual_clm.
393 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
394 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
395 (ASSURE_DESTINATION, coding_alloc_by_realloc)
396 (coding_alloc_by_making_gap, alloc_destination)
397 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
398 (encode_coding_utf_16, detect_coding_emacs_mule)
399 (decode_coding_emacs_mule, encode_coding_emacs_mule)
400 (detect_coding_iso_2022, decode_coding_iso_2022)
401 (encode_invocation_designation, encode_designation_at_bol)
402 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
403 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
404 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
405 (encode_coding_ccl, encode_coding_raw_text)
406 (detect_coding_charset, decode_coding_charset)
407 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
408 (produce_composition, produce_charset, produce_annotation)
409 (decode_coding, handle_composition_annotation)
410 (handle_charset_annotation, consume_chars, decode_coding_gap)
411 (decode_coding_object, encode_coding_object, detect_coding_system)
412 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
413 (code_convert_region, code_convert_string)
414 (Fdefine_coding_system_internal)
415 (coding_set_source, coding_set_destination):
416 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
417 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
418 (Fdefine_coding_system_internal):
419 Don't assume fixnums fit in int.
420 (decode_coding_gap, decode_coding_object, encode_coding_object)
421 (Fread_coding_system, Fdetect_coding_region)
422 (Funencodable_char_position, Fcheck_coding_systems_region)
423 (get_translation, handle_composition_annotation, consume_chars):
424 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
425 (consume_chars): Rewrite to not calculate an address outside buffer.
426 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
427 Don't access memory outside of the args array.
428 (Fdefine_coding_system_internal): Check for charset-id overflow.
429 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
430 result of ENCODE_CHAR.
431 * coding.h: Adjust decls to match defn changes elsewhere.
432 (struct coding_system):
433 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
434 * composite.c (get_composition_id, find_composition)
435 (run_composition_function, update_compositions)
436 (compose_text, composition_gstring_put_cache)
437 (composition_gstring_p, composition_gstring_width)
438 (fill_gstring_header, fill_gstring_body, autocmp_chars)
439 (composition_compute_stop_pos, composition_reseat_it)
440 (composition_update_it, struct position_record)
441 (find_automatic_composition, composition_adjust_point)
442 (Fcomposition_get_gstring, Ffind_composition_internal):
443 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
444 (update_compositions):
445 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
446 * composite.h: Adjust decls to match defn changes elsewhere.
447 (struct composition):
448 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
449 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
450 Do not attempt to compute the address of the object just before a
451 buffer; this is not portable.
453 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
454 (Faset): Use int, not EMACS_INT, where int is wide enough.
455 (Fstring_to_number): Don't assume fixnums fit in int.
456 (Frem): Don't assume arg is nonnegative.
457 * dbusbind.c (xd_append_arg): Check for integers out of range.
458 (Fdbus_call_method): Don't overflow the timeout int.
459 (extract_signed, extract_unsigned): New functions.
460 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
461 (xd_get_connection_references): Return ptrdiff_t, not int.
463 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
465 Use int, not unsigned, where the dbus API uses int.
466 (Fdbus_message_internal): Don't overflow mtype.
467 (syms_of_dbusbind): Allocate right-sized buffer for integers.
468 * dired.c (directory_files_internal, file_name_completion, scmp)
469 (file_name_completion_stat):
470 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
471 (file_name_completion): Don't overflow matchcount.
472 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
473 * dispextern.h: Adjust decls to match defn changes elsewhere.
474 (struct text_pos, struct glyph, struct bidi_saved_info)
475 (struct bidi_string_data, struct bidi_it, struct composition_it)
477 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
478 (struct display_pos, struct composition_it, struct it):
479 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
480 * dispnew.c (increment_matrix_positions)
481 (increment_row_positions, mode_line_string)
482 (marginal_area_string):
483 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
484 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
485 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
486 (duration_to_sec_usec): New function, to check for overflow better.
487 (Fsleep_for, sit_for): Use it.
488 * doc.c (get_doc_string, store_function_docstring):
489 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
490 (get_doc_string, Fsnarf_documentation):
491 Use int, not EMACS_INT, where int is wide enough.
493 Use SAFE_ALLOCA, not alloca.
494 Check for overflow when converting EMACS_INT to off_t.
496 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
497 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
498 Don't assume uid_t fits into fixnum.
499 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
500 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
501 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
502 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
503 (general_insert_function)
504 (Finsert_char, make_buffer_string, make_buffer_string_both)
505 (update_buffer_properties, Fbuffer_substring)
506 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
507 (Fsubst_char_in_region, check_translation)
508 (Ftranslate_region_internal, save_restriction_restore, Fformat)
509 (transpose_markers, Ftranspose_regions):
510 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
511 (clip_to_bounds): Move to lisp.h as an inline function).
512 (Fconstrain_to_field): Don't assume integers are nonnegative.
513 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
514 (Fsubst_char_in_region, Fsave_restriction):
515 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
516 (Femacs_pid): Don't assume pid_t fits into fixnum.
517 (lo_time): Use int, not EMACS_INT, when int suffices.
518 (lisp_time_argument): Check for usec out of range.
519 (Fencode_time): Don't assume fixnum fits in int.
520 (Fuser_login_name, Fuser_full_name): Signal an error
521 if a uid argument is out of range, rather than relying on
523 (Fformat_time_string): Remove now-unnecessary check.
524 lisp_time_argument checks for out-of-range usec now.
525 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
526 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
527 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
528 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
529 (init_cmdargs, Fdump_emacs):
530 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
531 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
532 the bottom (typically) 32 bits of the fixnum.
533 * eval.c (specpdl_size, call_debugger):
534 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
535 (when_entered_debugger, Fbacktrace_debug):
536 Don't assume fixnum can fit in int.
537 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
538 the object just before a buffer; this is not portable.
539 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
540 (grow_specpdl, unbind_to):
541 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
542 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
543 (grow_specpdl): Simplify allocation by using xpalloc.
544 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
545 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
546 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
547 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
548 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
550 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
551 (Fcopy_file, non_regular_nbytes, read_non_regular)
552 (Finsert_file_contents):
553 Use int, not EMACS_INT, where int is wide enough.
554 (READ_BUF_SIZE): Verify that it fits in int.
555 (Finsert_file_contents): Check that counts are in proper range,
556 rather than assuming fixnums fit into ptrdiff_t etc.
557 Don't assume fixnums fit into int.
558 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
559 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
560 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
561 (string_char_to_byte, string_byte_to_char)
562 (string_make_multibyte, string_to_multibyte)
563 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
564 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
565 (substring_both, Fdelete, internal_equal, Ffillarray)
566 (Fclear_string, mapcar1)
567 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
568 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
569 (larger_vector, make_hash_table, maybe_resize_hash_table)
570 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
571 (Fmaphash, secure_hash):
572 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
573 (concat): Check for string index and length overflow.
574 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
576 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
577 (larger_vector): New API (vec, incr_min, size_max) replaces old
578 one (vec, new_size, init). This catches size overflow.
579 INIT was removed because it was always Qnil.
581 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
582 the upper bound on a hash table index size.
583 (make_hash_table, maybe_resize_hash_table): Use it.
584 (secure_hash): Computer start_byte and end_byte only after
585 they're known to be in ptrdiff_t range.
586 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
587 (Ffont_get_glyphs, Ffont_at):
588 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
589 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
590 (Flist_fonts, Fopen_font):
591 Don't assume fixnum can fit in int.
592 (check_gstring): Don't assume index can fit in int.
593 (font_match_p): Check that fixnum is a character, not a nonnegative
594 fixnum, since the later code needs to stuff it into an int.
595 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
596 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
597 conversion overflow issues.
598 (Fopen_font): Check for integer out of range.
599 (Ffont_get_glyphs): Don't assume index can fit in int.
600 * font.h: Adjust decls to match defn changes elsewhere.
601 * fontset.c (reorder_font_vector): Redo score calculation to avoid
603 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
604 printmax_t, where ptrdiff_t is wide enough.
605 (Finternal_char_font):
606 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
607 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
608 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
609 (Fset_frame_position, x_set_frame_parameters)
610 (x_set_line_spacing, x_set_border_width)
611 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
612 Check that fixnums are in proper range for system types.
613 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
614 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
615 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
616 Use SAFE_ALLOCA_LISP, not alloca.
617 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
618 intptr_t is wide enough.
619 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
620 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
621 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
622 Check for fixnum out of range.
623 * ftfont.c (ftfont_list): Don't assume index fits in int.
624 Check that fixnums are in proper range for system types.
625 (ftfont_shape_by_flt):
626 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
627 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
628 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
629 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
630 Check that fixnums are in proper range for system types.
631 * gnutls.h: Adjust decls to match defn changes elsewhere.
632 * gtkutil.c (xg_dialog_run):
633 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
634 (update_frame_tool_bar):
635 Check that fixnums are in proper range for system types.
636 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
637 (lookup_image): Check that fixnums are in range for system types.
638 * indent.c (last_known_column, last_known_column_point):
639 (current_column_bol_cache):
640 (skip_invisible, current_column, check_display_width):
641 (check_display_width, scan_for_column, current_column_1)
642 (Findent_to, Fcurrent_indentation, position_indentation)
643 (indented_beyond_p, Fmove_to_column, compute_motion):
644 (Fcompute_motion, Fvertical_motion):
645 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
646 (last_known_column_modified): Use EMACS_INT, not int.
647 (check_display_width):
649 Check that fixnums and floats are in proper range for system types.
650 (compute_motion): Don't assume index or fixnum fits in int.
651 (compute_motion, Fcompute_motion):
652 Use int, not EMACS_INT, when it is wide enough.
653 (vmotion): Omit local var start_hpos that is always 0; that way
654 we don't need to worry about overflow in expressions involving it.
655 * indent.h: Adjust decls to match defn changes elsewhere.
657 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
658 Use int, not EMACS_INT, where int is wide enough.
659 Remove unused members ovstring_chars_done and tab_offset;
661 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
662 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
663 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
664 (make_gap, copy_text, insert, insert_and_inherit)
665 (insert_before_markers, insert_before_markers_and_inherit)
666 (insert_1, count_combining_before, count_combining_after)
667 (insert_1_both, insert_from_string)
668 (insert_from_string_before_markers, insert_from_string_1)
669 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
670 (adjust_after_replace, adjust_after_insert, replace_range)
671 (replace_range_2, del_range, del_range_1, del_range_byte)
672 (del_range_both, del_range_2, modify_region)
673 (prepare_to_modify_buffer, signal_before_change)
674 (signal_after_change, Fcombine_after_change_execute):
675 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
676 * intervals.c (traverse_intervals, rotate_right, rotate_left)
677 (balance_an_interval, split_interval_right, split_interval_left)
678 (find_interval, next_interval, update_interval)
679 (adjust_intervals_for_insertion, delete_node, delete_interval)
680 (interval_deletion_adjustment, adjust_intervals_for_deletion)
681 (static_offset_intervals, offset_intervals)
682 (merge_interval_right, merge_interval_left, make_new_interval)
683 (graft_intervals_into_buffer, temp_set_point_both)
684 (temp_set_point, set_point, adjust_for_invis_intang)
685 (set_point_both, move_if_not_intangible, get_property_and_range)
686 (get_local_map, copy_intervals, copy_intervals_to_string)
687 (compare_string_intervals, set_intervals_multibyte_1):
688 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
689 * intervals.h: Adjust decls to match defn changes elsewhere.
691 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
692 * keyboard.c (this_command_key_count, this_single_command_key_start)
693 (before_command_key_count, before_command_echo_length, echo_now)
694 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
695 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
696 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
697 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
698 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
699 (last_non_minibuf_size, last_point_position, echo_truncate)
700 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
701 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
702 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
703 (stuff_buffered_input):
704 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
705 (last_auto_save, command_loop_1, read_char):
706 Use EMACS_INT, not int, to avoid integer overflow.
707 (record_char): Avoid overflow in total_keys computation.
708 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
709 * keyboard.h: Adjust decls to match defn changes elsewhere.
710 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
711 (Fkey_description, Fdescribe_vector, Flookup_key):
712 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
713 (click_position): New function, to check that positions are in range.
714 (Fcurrent_active_maps):
716 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
717 (Faccessible_keymaps, Fkey_description):
718 (preferred_sequence_p):
719 Don't assume fixnum can fit into int.
720 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
721 Check for integer overflow in size calculations.
722 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
723 avoid mishandling large integers.
724 * lisp.h: Adjust decls to match defn changes elsewhere.
725 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
726 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
727 (struct Lisp_Marker):
728 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
729 (clip_to_bounds): Now an inline function, moved here from editfns.c.
730 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
731 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
733 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
734 Assume the arg has valid form, since it always does.
735 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
736 unsigned integer system type.
737 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
738 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
739 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
740 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
741 (duration_to_sec_usec): New decl.
742 * lread.c (read_from_string_index, read_from_string_index_byte)
743 (read_from_string_limit, readchar, unreadchar, openp)
744 (read_internal_start, read1, oblookup):
745 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
746 (Fload, readevalloop, Feval_buffer, Feval_region):
747 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
748 (openp): Check for out-of-range argument to 'access'.
749 (read1): Use int, not EMACS_INT, where int is wide enough.
750 Don't assume fixnum fits into int.
751 Fix off-by-one error that can read outside a buffer.
752 (read_filtered_event): Use duration_to_sec_usec
753 to do proper overflow checking on durations.
754 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
756 (Fexecute_kbd_macro):
757 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
758 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
759 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
760 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
761 (set_marker_both, set_marker_restricted_both, marker_position)
762 (marker_byte_position, Fbuffer_has_markers_at):
763 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
764 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
765 * menu.c (ensure_menu_items): Rename from grow_menu_items.
766 It now merely ensures that the menu is large enough, without
767 necessarily growing it, as this avoids some integer overflow issues.
769 (keymap_panes, parse_single_submenu, Fx_popup_menu):
770 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
771 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
772 Use SAFE_ALLOCA_LISP, not alloca.
773 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
774 to EMACS_INT. Check that fixnums are in proper range for system types.
775 * minibuf.c (minibuf_prompt_width, string_to_object)
776 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
777 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
778 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
779 (get_minibuffer, read_minibuf_unwind):
780 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
781 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
782 this simplifies overflow checking. All callers changed.
783 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
785 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
786 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
787 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
788 Check that fixnums are in proper range for system types.
789 (Fx_create_frame, Fx_show_tip):
790 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
791 * nsfont.m (ns_findfonts, nsfont_list_family):
792 Don't assume fixnum fits in long.
793 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
794 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
795 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
797 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
798 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
799 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
800 (PRINTDECLARE, PRINTPREPARE):
801 (strout, print_string):
802 (print, print_preprocess, print_check_string_charset_prop)
804 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
806 (temp_output_buffer_setup, Fprin1_to_string, print_object):
807 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
808 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
809 (printchar, strout): Use xpalloc to catch size calculation overflow.
810 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
811 (print_error_message): Use SAFE_ALLOCA, not alloca.
812 (print_object): Use int, not EMACS_INT, where int is wide enough.
813 (print_depth, new_backquote_output, print_number_index):
814 Use ptrdiff_t, not int, where int might not be wide enough.
815 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
816 (Fset_process_window_size, Fformat_network_address)
817 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
819 Check that fixnums are in proper range for system types.
820 (Fsignal_process): Simplify by avoiding a goto.
821 Check for process-ids out of pid_t range rather than relying on
823 (process_tick, update_tick): Use EMACS_INT, not int.
824 (Fformat_network_address, read_process_output, send_process)
825 (Fprocess_send_region, status_notify):
826 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
827 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
828 (wait_reading_process_output, read_process_output, exec_sentinel):
829 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
830 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
831 (Faccept_process_output): Use duration_to_sec_usec to do proper
832 overflow checking on durations.
833 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
834 Don't assume pid_t fits in int.
835 * process.h (struct Lisp_Process): Members tick and update_tick
836 are now of type EMACS_INT, not int.
837 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
838 configured --with-wide-int.
839 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
840 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
841 * search.c (looking_at_1, string_match_1):
842 (fast_string_match, fast_c_string_match_ignore_case)
843 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
844 (scan_newline, find_before_next_newline, search_command)
845 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
846 (set_search_regs, wordify):
849 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
850 (string_match_1, search_buffer, set_search_regs):
852 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
853 (wordify): Check for overflow in size calculation.
854 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
855 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
856 Check that fixnums are in proper range for system types.
857 * sound.c (struct sound_device)
858 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
859 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
860 (Fplay_sound_internal):
861 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
862 * syntax.c (struct lisp_parse_state, find_start_modiff)
863 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
864 (Fparse_partial_sexp):
865 Don't assume fixnums can fit in int.
866 (struct lisp_parse_state, find_start_pos, find_start_value)
867 (find_start_value_byte, find_start_begv)
868 (update_syntax_table, char_quoted, dec_bytepos)
869 (find_defun_start, prev_char_comend_first, back_comment):
870 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
871 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
872 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
873 (Finternal_describe_syntax_value): Check that match_lisp is a
874 character, not an integer, since the code stuffs it into int.
875 (scan_words, scan_sexps_forward):
876 Check that fixnums are in proper range for system types.
878 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
879 (scan_sexps_forward):
880 Use CHARACTERP, not INTEGERP, since the value must fit into int.
881 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
882 * syntax.h: Adjust decls to match defn changes elsewhere.
884 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
885 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
886 MOST_POSITIVE_FIXNUM.
887 * sysdep.c (wait_for_termination_1, wait_for_termination)
888 (interruptible_wait_for_termination, mkdir):
889 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
890 (emacs_read, emacs_write):
891 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
892 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
893 and double all fit in int.
894 * term.c (set_tty_color_mode):
895 Check that fixnums are in proper range for system types.
896 * termhooks.h (struct input_event):
897 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
898 * textprop.c (validate_interval_range, interval_of)
899 (Fadd_text_properties, set_text_properties_1)
900 (Fremove_text_properties, Fremove_list_of_text_properties)
901 (Ftext_property_any, Ftext_property_not_all)
902 (copy_text_properties, text_property_list, extend_property_ranges)
903 (verify_interval_modification):
904 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
905 (Fnext_single_char_property_change)
906 (Fprevious_single_char_property_change):
907 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
908 (copy_text_properties):
909 Check for integer overflow in index calculation.
910 * undo.c (last_boundary_position, record_point, record_insert)
911 (record_delete, record_marker_adjustment, record_change)
912 (record_property_change):
913 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
914 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
915 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
916 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
917 (Fx_hide_tip, Fx_file_dialog):
918 * w32menu.c (set_frame_menubar):
919 Use ptrdiff_t, not int, for consistency with rest of code.
920 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
921 (select_window, Fdelete_other_windows_internal)
922 (window_scroll_pixel_based, window_scroll_line_based)
923 (Frecenter, Fset_window_configuration):
924 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
925 (Fset_window_hscroll, run_window_configuration_change_hook)
926 (set_window_buffer, temp_output_buffer_show, scroll_command)
927 (Fscroll_other_window, Frecenter):
928 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
929 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
930 Don't assume fixnum fits in int.
931 (Fset_window_scroll_bars):
932 Check that fixnums are in proper range for system types.
933 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
934 (string_pos, c_string_pos, number_of_chars, init_iterator)
935 (in_ellipses_for_invisible_text_p, init_from_display_pos)
936 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
937 (compute_display_string_end, handle_face_prop)
938 (face_before_or_after_it_pos, handle_invisible_prop)
939 (handle_display_prop, handle_display_spec, handle_single_display_spec)
940 (display_prop_intangible_p, string_buffer_position_lim)
941 (string_buffer_position, handle_composition_prop, load_overlay_strings)
942 (get_overlay_strings_1, get_overlay_strings)
943 (iterate_out_of_display_property, forward_to_next_line_start)
944 (back_to_previous_visible_line_start, reseat, reseat_to_string)
945 (get_next_display_element, set_iterator_to_next)
946 (get_visually_first_element, compute_stop_pos_backwards)
947 (handle_stop_backwards, next_element_from_buffer)
948 (move_it_in_display_line_to, move_it_in_display_line)
949 (move_it_to, move_it_vertically_backward, move_it_by_lines)
950 (add_to_log, message_dolog, message_log_check_duplicate)
951 (message2, message2_nolog, message3, message3_nolog
952 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
953 (current_message_1, truncate_echo_area, truncate_message_1)
954 (set_message, set_message_1, store_mode_line_noprop)
955 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
956 (text_outside_line_unchanged_p, check_point_in_composition)
957 (reconsider_clip_changes)
958 (redisplay_internal, set_cursor_from_row, try_scrolling)
959 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
960 (redisplay_window, find_last_unchanged_at_beg_row)
961 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
962 (trailing_whitespace_p, find_row_edges, display_line)
963 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
964 (display_mode_element, store_mode_line_string)
965 (pint2str, pint2hrstr, decode_mode_spec)
966 (display_count_lines, display_string, draw_glyphs)
967 (x_produce_glyphs, x_insert_glyphs)
968 (rows_from_pos_range, mouse_face_from_buffer_pos)
969 (fast_find_string_pos, mouse_face_from_string_pos)
970 (note_mode_line_or_margin_highlight, note_mouse_highlight):
971 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
972 (safe_call, init_from_display_pos, handle_fontified_prop)
973 (handle_single_display_spec, load_overlay_strings)
974 (with_echo_area_buffer, setup_echo_area_for_printing)
975 (display_echo_area, echo_area_display)
976 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
977 (update_tool_bar, hscroll_window_tree, redisplay_internal)
978 (redisplay_window, dump_glyph_row, display_mode_line)
979 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
980 (handle_display_spec, display_prop_string_p):
981 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
982 (handle_single_display_spec, build_desired_tool_bar_string)
983 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
984 (get_specified_cursor_type):
985 Check that fixnums are in proper range for system types.
986 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
988 Don't assume fixnums fit in int.
989 (compare_overlay_entries):
990 Avoid mishandling comparisons due to subtraction overflow.
991 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
992 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
993 (handle_tool_bar_click):
994 Use int, not unsigned, since we prefer signed and the signedness
996 (get_next_display_element, next_element_from_display_vector):
997 Use int, not EMACS_INT, when int is wide enough.
998 (start_hourglass): Use duration_to_sec_usec to do proper
999 overflow checking on durations.
1000 * xfaces.c (Fbitmap_spec_p):
1001 Check that fixnums are in proper range for system types.
1002 (compare_fonts_by_sort_order):
1003 Avoid mishandling comparisons due to subtraction overflow.
1004 (Fx_family_fonts, realize_basic_faces):
1005 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1007 Don't assume fixnum fits in int.
1008 Use SAFE_ALLOCA_LISP, not alloca.
1009 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
1010 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
1011 (face_at_buffer_position, face_for_overlay_string)
1012 (face_at_string_position):
1013 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1014 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
1015 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
1017 Check that fixnums are in proper range for system types.
1018 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1019 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
1020 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1021 (Fx_change_window_property): Don't assume fixnums fit in int.
1022 * xfont.c (xfont_chars_supported):
1023 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1024 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
1025 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
1026 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1027 * xml.c (parse_region):
1028 * xrdb.c (magic_file_p):
1029 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1030 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
1031 (x_get_local_selection, x_reply_selection_request)
1032 (x_handle_selection_request, wait_for_property_change):
1033 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1034 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
1035 short is wide enough.
1036 (x_send_client_event): Don't assume fixnum fits in int.
1037 * xterm.c (x_x_to_emacs_modifiers):
1038 Don't assume EMACS_INT overflows nicely into int.
1039 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
1041 (handle_one_xevent): NATNUMP can eval its arg twice.
1042 (x_connection_closed):
1043 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1044 * xterm.h: Adjust decls to match defn changes elsewhere.
1045 (struct scroll_bar): Use struct vectorlike_header
1046 rather than rolling our own approximation.
1047 (SCROLL_BAR_VEC_SIZE): Remove; not used.
1049 2012-05-25 Glenn Morris <rgm@gnu.org>
1051 * lisp.mk (lisp): Update for more files being compiled now.
1053 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
1055 * lread.c: Remove `read_pure' which makes no difference.
1056 (read_pure): Remove var.
1057 (unreadpure): Remove function.
1058 (readevalloop): Don't call read_list with -1 flag.
1059 (read1, read_vector): Don't test read_pure any more.
1060 (read_list): Simplify.
1062 * fileio.c, character.h: Minor style tweaks.
1064 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
1066 * window.h (clip_changed): Remove useless declaration.
1068 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
1070 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
1071 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
1073 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
1076 This directory predates autoconf and is no longer needed nowadays.
1077 Move its few remaining bits of functionality to where they're needed.
1078 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
1079 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
1080 * m/template.h: Remove.
1081 * Makefile.in (M_FILE): Remove. All uses removed.
1082 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
1083 * lisp.h (USE_LSB_TAG):
1084 * mem-limits.h (EXCEEDS_LISP_PTR):
1085 Use VAL_MAX, not VALBITS, in #if.
1086 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
1087 (EMACS_UINT): Define unconditionally now.
1088 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
1089 (BITS_PER_EMACS_INT): New constants, replacing
1090 what used to be in config.h, but not useful in #if.
1091 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
1092 define them any more.
1093 (VAL_MAX): New macro.
1095 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
1096 BITS_PER_EMACS_INT, in #if.
1097 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
1098 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
1099 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
1100 * s/ms-w32.h (DATA_START):
1101 Move here from removed file m/intel386.h.
1102 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
1103 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
1105 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
1107 Assume C89 or later.
1108 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
1109 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
1111 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
1112 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
1113 * textprop.c, tparam.c (NULL): Remove.
1114 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
1115 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
1116 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
1117 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
1118 * xterm.c (input_signal_count): Assume volatile works.
1120 2012-05-21 Ken Brown <kbrown@cornell.edu>
1122 * xgselect.c (xg_select): Fix first argument in call to 'select'
1125 2012-05-20 Ken Brown <kbrown@cornell.edu>
1127 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
1128 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1130 2012-05-19 Ken Brown <kbrown@cornell.edu>
1132 * xfns.c (x_in_use): Remove `static' qualifier.
1133 * xterm.h (x_in_use): Declare.
1134 * xgselect.c: Include xterm.h.
1135 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
1136 and `display_arg' (bug#9754).
1138 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
1140 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
1142 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
1143 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
1145 2012-05-18 Eli Zaretskii <eliz@gnu.org>
1147 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
1149 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
1150 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
1152 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
1153 reference to image_cache->refcount.
1154 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
1156 2012-05-17 Juri Linkov <juri@jurta.org>
1158 * search.c (Fword_search_regexp, Fword_search_backward)
1159 (Fword_search_forward, Fword_search_backward_lax)
1160 (Fword_search_forward_lax): Move functions to isearch.el
1161 (bug#10145, bug#11381).
1163 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
1165 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
1167 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
1169 * lread.c (init_obarray): Declare Qt and Qnil as special.
1171 2012-05-14 Glenn Morris <rgm@gnu.org>
1173 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
1174 Put "libexec" before "bin", for the sake of init_callproc_1.
1176 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1178 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
1180 * unexaix.c: Port to more-recent AIX compilers.
1181 (report_error, report_error_1, make_hdr, copy_sym)
1182 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
1183 Make arguments const char *, not char *, to avoid violations of C
1184 standard and to fix some AIX warnings reported by Gilles Pion.
1186 2012-05-14 Eli Zaretskii <eliz@gnu.org>
1188 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
1189 already have overlays loaded.
1190 (handle_single_display_spec): Before returning without displaying
1191 fringe bitmap, synchronize the bidi iterator with the main display
1192 iterator, by calling iterate_out_of_display_property.
1193 (iterate_out_of_display_property): Detect buffer iteration by
1194 testing that it->string is a Lisp string.
1195 (get_next_display_element): When the current object is exhausted,
1196 and there's something on it->stack, call set_iterator_to_next to
1197 proceed with what's on the stack, instead of returning zero.
1198 (set_iterator_to_next): If called at the end of a Lisp string,
1199 proceed to consider_string_end without incrementing string
1200 position. Don't increment display vector index past the end of
1201 the display vector. (Bug#11417)
1202 (pos_visible_p): Don't report a position visible when move_it_to
1203 stopped at the last line of window, which happens to be scanned
1204 backwards by the bidi iteration. (Bug#11464)
1206 2012-05-14 Eli Zaretskii <eliz@gnu.org>
1208 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
1209 and right-margin display specs even if the spec is invalid or we
1210 are on a TTY, and thus unable to display on the fringes.
1211 That's because the text with the property will not be displayed anyway,
1212 so we need to signal to the caller that this is a "replacing"
1213 display spec. This fixes display when the spec is invalid or we
1216 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1218 * unexaix.c (make_hdr): Fix typo in prototype.
1219 This bug broke the build on AIX. Problem reported by Gilles Pion.
1221 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
1223 * keyboard.c (kbd_buffer_get_event): Read special events also in
1224 batch mode. (Bug#11415)
1226 2012-05-12 Glenn Morris <rgm@gnu.org>
1228 * ns.mk: Update for ns_appbindir no longer having trailing "/".
1230 2012-05-12 Eli Zaretskii <eliz@gnu.org>
1232 * lisp.mk (lisp): Add newcomment.elc.
1234 2012-05-12 Glenn Morris <rgm@gnu.org>
1236 * Makefile.in (MKDIR_P): New, set by configure.
1237 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
1239 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
1241 Remove unused function hourglass_started.
1242 * dispextern.h (hourglass_started):
1243 * w32fns.c (hourglass_started):
1244 * xdisp.c (hourglass_started): Remove.
1246 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
1248 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
1249 Update dependencies.
1251 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
1253 * xgselect.c (xg_select): Put maxfds+1 into a var.
1254 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
1256 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
1258 2012-05-10 Dave Abrahams <dave@boostpro.com>
1260 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
1261 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
1263 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
1265 * dbusbind.c (xd_registered_buses): New internal Lisp object.
1266 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
1267 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
1268 Initialize xd_registered_buses.
1270 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
1272 Untag more efficiently if USE_LSB_TAG.
1273 This is based on a proposal by YAMAMOTO Mitsuharu in
1274 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
1275 For an admittedly artificial (nth 8000 longlist) benchmark on
1276 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
1277 Emacs's overall text size by 1%.
1278 * lisp.h (XUNTAG): New macro.
1279 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
1280 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
1281 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
1282 * eval.c (Fautoload):
1283 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
1284 * frame.h (XFRAME): Use XUNTAG.
1286 Port recent dbusbind.c changes to 32-bit --with-wide-int.
1287 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
1288 Remove unportable assumptions about print widths of types like
1290 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
1291 intptr_t when converting between pointer and integer, to avoid GCC
1292 warnings about wrong width.
1294 2012-05-09 Eli Zaretskii <eliz@gnu.org>
1296 * w32proc.c (new_child): Force Windows to reserve only 64KB of
1297 stack for each reader_thread, instead of defaulting to 8MB
1298 determined by the linker. This avoids failures in creating
1299 subprocesses on Windows 7, see the discussion in this thread:
1300 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
1302 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
1304 Fix up display of the *Minibuf-0* buffer in the mini window.
1305 * keyboard.c (read_char): Don't clear the echo area if there's no
1307 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
1308 contents of *Minibuf-0*) if there's no message displayed in its stead.
1310 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
1312 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
1315 2012-05-06 Chong Yidong <cyd@gnu.org>
1317 * lisp.mk (lisp): Update.
1319 2012-05-05 Jim Meyering <meyering@redhat.com>
1321 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
1323 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
1325 * data.c (PUT_ERROR): New macro.
1326 (syms_of_data): Use it. Add new error type `user-error'.
1327 * undo.c (user_error): New function.
1328 (Fprimitive_undo): Use it.
1329 * print.c (print_error_message): Adjust print style for `user-error'.
1330 * keyboard.c (user_error): New function.
1331 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
1333 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
1335 Do not limit current-time-string to years 1000..9999.
1336 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
1337 (Fcurrent_time_string): Support any year that is supported by the
1338 underlying localtime representation. Don't use asctime, as it
1339 has undefined behavior for years outside the range -999..9999.
1341 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
1343 Fix race conditions involving setenv, gmtime, localtime, asctime.
1344 Without this fix, interrupts could mess up code that uses these
1345 nonreentrant functions, since setting TZ invalidates existing
1346 tm_zone or tzname values, and since most of these functions return
1347 pointers to static storage.
1348 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
1349 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
1350 Grow the critical sections to include not just invoking
1351 localtime/gmtime, but also accessing these functions' results
1352 including their tm_zone values if any, and any related TZ setting.
1353 (format_time_string): Last arg is now struct tm *, not struct tm **,
1354 so that the struct tm is saved in the critical section.
1355 All callers changed. Simplify allocation of initial buffer, partly
1356 motivated by the fact that memory allocation needs to be outside
1357 the critical section.
1359 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
1361 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
1362 with RESET_INTERVAL.
1364 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1365 Remove duplicated buffer name initialization.
1367 2012-05-02 Jim Meyering <jim@meyering.net>
1369 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
1371 * xfns.c (x_window): Use xstrdup (Bug#11375).
1373 2012-05-02 Eli Zaretskii <eliz@gnu.org>
1375 * xdisp.c (pos_visible_p): If already at a newline from the
1376 display string before the 'while' loop, don't walk back the glyphs
1377 from it3.glyph_row. Solves assertion violation when the display
1378 string begins with a newline (egg.el). (Bug#11367)
1380 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
1382 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
1385 2012-05-01 Glenn Morris <rgm@gnu.org>
1387 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
1388 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
1389 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
1390 All were removed before 23.1.
1392 * dispnew.c: Remove HAVE_LIBNCURSES test;
1393 it is always true on relevant platforms.
1395 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
1396 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
1398 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
1400 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
1402 * .gdbinit (xpr): Remove checks for no longer existing misc types.
1403 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
1406 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
1408 Do not avoid creating empty evaporating overlays (Bug#9642).
1409 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
1410 That is, do not delete an evaporating overlay if it becomes
1411 empty after its bounds are adjusted to fit within its buffer.
1412 This fix caused other problems, and I'm reverting it until we get
1413 to the bottom of them.
1415 2012-04-27 Chong Yidong <cyd@gnu.org>
1417 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
1419 2012-04-27 Eli Zaretskii <eliz@gnu.org>
1421 * xdisp.c (pos_visible_p): If the window start position is beyond
1422 ZV, start the display from buffer beginning. Prevents assertion
1423 violation in init_iterator when the minibuffer window is scrolled
1426 * window.c (window_scroll_pixel_based): Likewise.
1428 2012-04-27 Chong Yidong <cyd@gnu.org>
1430 * keymap.c (where_is_internal): Doc fix (Bug#10872).
1432 2012-04-27 Glenn Morris <rgm@gnu.org>
1434 * fileio.c (Fcopy_file, Fset_file_selinux_context):
1435 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
1437 2012-04-27 Eli Zaretskii <eliz@gnu.org>
1439 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
1440 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
1442 2012-04-26 Eli Zaretskii <eliz@gnu.org>
1444 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
1445 display element, check also the underlying string or buffer
1446 character. (Bug#11341)
1448 * w32menu.c: Include w32heap.h.
1449 (add_menu_item): If the call to AppendMenuW (via
1450 unicode_append_menu) fails, disable Unicode menus only if we are
1451 running on Windows 9X/Me.
1453 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
1455 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
1456 (xgetint): Add missing shift for LSB tags.
1458 2012-04-24 Martin Rudalics <rudalics@gmx.at>
1460 * keyboard.c (read_char): Don't wipe echo area for select window
1461 events: These might get delayed via `mouse-autoselect-window'
1464 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
1466 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
1467 manipulation of :loaded-from data.
1469 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
1471 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
1472 now a cons (bug#11311).
1474 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
1476 Do not create empty overlays with the evaporate property (Bug#9642).
1477 * buffer.c (Fmove_overlay): Delete an evaporating overlay
1478 if it becomes empty after its bounds are adjusted to fit within
1479 its buffer. Without this fix, in a nonempty buffer (let ((o
1480 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
1481 yields an empty overlay that has the evaporate property, which is
1482 not supposed to happen.
1484 Fix minor GTK3 problems found by static checking.
1485 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1486 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1487 (struct _EmacsFixedClass, emacs_fixed_get_type):
1488 Move decls here from emacsgtkfixed.h, since they needn't be public.
1489 (emacs_fixed_get_type): Now static.
1490 (emacs_fixed_class_init): Omit unused local.
1491 (emacs_fixed_child_type): Remove; unused.
1492 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1493 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1494 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
1495 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
1496 (EMACS_FIXED_GET_CLASS): Remove; unused.
1497 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
1499 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
1500 Problem reported by Juanma Barranquero for Windows -Wunused-function.
1502 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1504 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
1505 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
1506 (__malloc_size_t, __malloc_ptrdiff_t):
1507 Remove. All uses removed, replaced by the definiens if needed,
1508 since we can assume C89 or better now.
1509 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
1510 (protect_malloc_state, align, get_contiguous_space)
1511 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
1512 (malloc_atfork_handler_child, malloc_enable_thread)
1513 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
1514 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
1515 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
1516 (special_realloc, _realloc_internal_nolock, _realloc_internal)
1517 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
1518 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
1519 Define using prototypes, not old style.
1520 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
1521 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
1522 (align): Don't assume that signed integer overflow wraps around.
1523 Omit unused local var.
1524 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
1525 (_free_internal_nolock, memalign, mallochook, reallochook):
1526 Omit no-longer-needed casts.
1527 (valloc): Use getpagesize, not __getpagesize.
1528 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
1529 (struct hdr): The 'magic' member is now size_t, not unsigned long.
1531 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
1533 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
1535 Move functions from C to Lisp. Make non-blocking method calls
1536 the default. Implement further D-Bus standard interfaces.
1538 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
1539 (QCdbus_request_name_allow_replacement)
1540 (QCdbus_request_name_replace_existing)
1541 (QCdbus_request_name_do_not_queue)
1542 (QCdbus_request_name_reply_primary_owner)
1543 (QCdbus_request_name_reply_in_queue)
1544 (QCdbus_request_name_reply_exists)
1545 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
1546 (QCdbus_registered_serial, QCdbus_registered_method)
1547 (QCdbus_registered_signal): New Lisp objects.
1548 (XD_DEBUG_MESSAGE): Use sizeof.
1549 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
1550 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
1551 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
1552 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
1553 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
1554 (xd_signature, xd_append_arg): Allow float for integer types.
1555 (xd_get_connection_references): New function.
1556 (xd_get_connection_address): Rename from xd_initialize.
1557 Return cached address.
1558 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
1559 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
1561 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
1562 Return number of refcounts.
1563 (Fdbus_get_unique_name): Make stronger parameter check.
1564 (Fdbus_message_internal): New defun.
1565 (Fdbus_call_method, Fdbus_call_method_asynchronously)
1566 (Fdbus_method_return_internal, Fdbus_method_error_internal)
1567 (Fdbus_send_signal, Fdbus_register_service)
1568 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
1569 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
1570 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
1571 (Vdbus_compiled_version, Vdbus_runtime_version)
1572 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
1573 (Vdbus_message_type_method_return, Vdbus_message_type_error)
1574 (Vdbus_message_type_signal): New defvars.
1575 (Vdbus_registered_buses, Vdbus_registered_objects_table):
1578 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1580 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
1581 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
1582 Do not assume ptrdiff_t is the same width as 'int'.
1584 * alloc.c: Handle unusual debugging option combinations.
1585 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
1586 since the two debugging options are incompatible.
1587 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
1589 (mem_init, mem_insert, mem_insert_fixup):
1590 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
1591 (NEED_MEM_INSERT): Remove; no longer needed.
1593 2012-04-22 Leo Liu <sdl.web@gmail.com>
1595 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
1597 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1599 * sysdep.c [__FreeBSD__]: Minor cleanups.
1600 (list_system_processes, system_process_attributes) [__FreeBSD__]:
1601 Use Emacs indenting style more consistently. Avoid some casts.
1602 Use 'double' consistently rather than mixing 'float' and 'double'.
1604 2012-04-21 Eduard Wiebe <usenet@pusto.de>
1606 * sysdep.c (list_system_processes, system_process_attributes):
1607 Add implementation for FreeBSD (Bug#5243).
1609 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
1611 * lisp.mk (lisp): Update.
1613 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
1615 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
1616 It is never used otherwise.
1618 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
1620 * print.c (print_preprocess): Only check print_depth if print-circle
1622 (print_object): Check for cycles even when print-circle is nil and
1623 print-gensym is t, but only check print_depth if print-circle is nil.
1625 2012-04-20 Chong Yidong <cyd@gnu.org>
1627 * process.c (wait_reading_process_output): If EIO occurs on a pty,
1628 set the status to "failed" and ensure that sentinel is run.
1630 2012-04-20 Glenn Morris <rgm@gnu.org>
1632 * process.c (Fset_process_inherit_coding_system_flag)
1633 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
1634 (Fmake_network_process, Fmake_serial_process): Doc fix.
1636 2012-04-20 Eli Zaretskii <eliz@gnu.org>
1638 * xdisp.c (string_buffer_position_lim): Limit starting position to
1640 (set_cursor_from_row): If called for a mode-line or header-line
1641 row, return zero immediately.
1642 (try_cursor_movement): If inside continuation line, don't back up
1643 farther than the first row after the header line, if any.
1644 Don't consider the header-line row as "partially visible", even if
1645 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
1647 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
1649 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
1652 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
1653 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
1655 configure: new option --enable-gcc-warnings (Bug#11207)
1656 * Makefile.in (C_WARNINGS_SWITCH): Remove.
1657 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
1658 (ALL_CFLAGS): Use new macros rather than old.
1659 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
1660 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
1661 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
1662 -Wunused-result, -Wunused-variable. This should go away once
1663 the Emacs and Gnulib regex code is merged.
1664 (xmalloc, xrealloc): Now static.
1666 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
1668 * dired.c (Fsystem_groups): Remove unused local.
1670 2012-04-17 Glenn Morris <rgm@gnu.org>
1672 * dired.c (Fsystem_users): Doc fix.
1674 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
1676 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
1677 (syms_of_dired): Add them.
1679 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
1681 Fix minor alloc.c problems found by static checking.
1682 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
1683 New extern decls, to avoid calling undeclared functions.
1684 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
1685 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
1686 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
1687 (NEED_MEM_INSERT): New macro.
1688 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
1689 Remove one incorrect comment and fix another.
1691 Fix minor ralloc.c problems found by static checking.
1692 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1693 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
1694 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
1695 (r_alloc_sbrk): Now static.
1697 Improve ralloc.c interface checking.
1698 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1699 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
1700 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
1701 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
1702 [REL_ALLOC]: ... to here, to check interface.
1703 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
1704 Remove decls. This fixes an "It stinks!".
1706 * alloc.c (which_symbols): Fix alignment issue / type clash.
1708 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
1710 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
1711 (struct Lisp_Misc_Any): Likewise.
1712 (struct Lisp_Free): Likewise.
1713 * alloc.c (union aligned_Lisp_Symbol): Define.
1714 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
1715 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
1716 (union aligned_Lisp_Misc): Define.
1717 (MARKER_BLOCK_SIZE, struct marker_block): Use union
1718 aligned_Lisp_Misc instead of union Lisp_Misc.
1719 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
1721 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
1723 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
1724 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
1725 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
1726 * s/netbsd.h, s/sol2-6.h:
1727 Remove definition of GC_MARK_STACK, since the default now works.
1728 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
1729 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
1730 no longer the default.
1731 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
1733 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
1735 * lread.c (lisp_file_lexically_bound_p):
1736 Fix hang at ";-*-\n" (bug#11238).
1738 2012-04-14 Eli Zaretskii <eliz@gnu.org>
1740 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
1741 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
1743 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
1745 * nsterm.m (constrainFrameRect): Always constrain when there is only
1746 one screen (Bug#10962).
1748 2012-04-13 Ken Brown <kbrown@cornell.edu>
1750 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
1752 2012-04-13 Reuben Thomas <rrt@sc3d.org>
1754 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
1756 2012-04-11 Daniel Colascione <dancol@dancol.org>
1758 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
1759 against is gone. It's better to use vfork now so that when Cygwin
1760 gains a new, working vfork, we use it automatically (bug#10398).
1762 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1764 * window.c (save_window_save): Obey window-point-insertion-type.
1766 2012-04-11 Glenn Morris <rgm@gnu.org>
1768 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
1770 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1772 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
1774 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
1776 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
1777 (force_quit_count): New var.
1778 (handle_interrupt): Use it.
1780 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
1782 * w32.c (w32_delayed_load): Record the full path of the library
1783 being loaded (bug#10424).
1785 2012-04-09 Glenn Morris <rgm@gnu.org>
1787 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
1788 not just in the obarray, before snarfing them. (Bug#11036)
1790 * Makefile.in ($(leimdir)/leim-list.el):
1791 Pass EMACS rather than BUILT_EMACS.
1793 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
1795 * process.c (make_process):
1796 * process.h: Add integer `gnutls_handshakes_tried' member to
1799 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
1800 Add convenience `GNUTLS_LOG2i' macro.
1802 * gnutls.c (gnutls_log_function2i): Convenience log function.
1803 (emacs_gnutls_read): Use new log functions,
1804 `gnutls_handshakes_tried' process member, and
1805 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
1806 attempts per process (connection).
1808 2012-04-09 Chong Yidong <cyd@gnu.org>
1810 * eval.c (Fuser_variable_p, user_variable_p_eh)
1811 (lisp_indirect_variable): Functions deleted.
1812 (Fdefvar): Caller changed.
1814 * callint.c (Finteractive, Fcall_interactively):
1815 * minibuf.c (Fread_variable): Callers changed.
1817 2012-04-09 Eli Zaretskii <eliz@gnu.org>
1819 * xdisp.c (set_cursor_from_row): If the display string appears in
1820 the buffer at position that is closer to point than the position
1821 after the display string, display the cursor on the first glyph of
1822 the display string. Fixes cursor display when a 'display' text
1823 property immediately follows invisible text. (Bug#11094)
1825 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
1827 composite.c: use 'double' consistently
1828 * composite.c (get_composition_id): Use 'double' consistently
1829 instead of converting 'float' to 'double' and vice versa; this is
1830 easier to understand and avoids a GCC warning.
1832 2012-04-09 Glenn Morris <rgm@gnu.org>
1834 * Makefile.in: Generate leim-list with bootstrap-emacs, in
1835 preparation for dumping it with emacs. (Bug#4789)
1836 (leimdir): New variable.
1837 ($(leimdir)/leim-list.el): New rule.
1838 (emacs$(EXEEXT)): Depend on leim-list.el.
1840 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
1841 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
1842 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
1844 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
1846 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
1849 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
1851 * xml.c (init_libxml2_functions) [WINDOWSNT]:
1852 Remove unused local variable.
1854 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
1856 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
1857 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
1858 (mark_memory): Mark Lisp_Objects only if pointers might hide in
1859 objects, as mark_maybe_pointer will catch them otherwise.
1860 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
1861 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
1863 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
1865 Fix typo that broke non-Windows builds.
1866 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
1868 2012-04-07 Eli Zaretskii <eliz@gnu.org>
1870 Support building on MS-Windows with libxml2.
1872 * makefile.w32-in (OBJ2): Add xml.$(O).
1873 (GLOBAL_SOURCES): Add xml.c.
1874 ($(BLD)/xml.$(O)): New dependency list.
1876 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
1877 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
1878 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
1879 [!WINDOWSNT]: New macros.
1880 (init_libxml2_functions, libxml2_loaded_p): New functions.
1881 (parse_region): Call fn_xmlCheckVersion instead of using the macro
1882 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
1883 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
1884 Calls xmlCleanupParser only if libxml2 was loaded (or statically
1886 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
1887 Call init_libxml2_functions before calling libxml2 functions.
1888 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
1890 * emacs.c: Don't include libxml/parser.h.
1891 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
1892 xmlCleanupParser directly.
1894 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
1896 2012-04-07 Eli Zaretskii <eliz@gnu.org>
1898 * indent.c (Fvertical_motion): If there is a display string at
1899 point, use it.vpos to compute how many lines to backtrack after
1900 move_it_to point. (Bug#11133)
1902 2012-04-06 Eli Zaretskii <eliz@gnu.org>
1904 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
1905 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
1906 about subtle differences between FETCH_CHAR* and STRING_CHAR*
1907 macros related to unification of CJK characters. For the details,
1908 see the discussion following the message here:
1909 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
1911 2012-04-04 Chong Yidong <cyd@gnu.org>
1913 * keyboard.c (Vdelayed_warnings_list): Doc fix.
1915 2012-04-01 Eli Zaretskii <eliz@gnu.org>
1917 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
1918 instead of alloca. (Bug#11138)
1920 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
1922 * w32menu.c (is_simple_dialog): Properly check lisp types.
1925 2012-03-31 Eli Zaretskii <eliz@gnu.org>
1927 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
1928 position we get to after a call to move_it_to fails the
1929 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
1930 only if we wind up in a string from display property. (Bug#11063)
1932 * window.c (Fdelete_other_windows_internal): Invalidate the row
1933 and column information about mouse highlight, so that redisplay
1934 restores it after reallocating the glyph matrices. (Bug#7464)
1936 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
1937 string comes from a `display' text property, use the buffer
1938 position of that property as if we actually saw that position in
1940 (move_it_by_lines): Remove the assertion that
1941 "it->current_x == 0 && it->hpos == 0" which can be legitimately
1942 violated when there's a before-string at the beginning of a line.
1945 2012-03-30 Eli Zaretskii <eliz@gnu.org>
1947 * xdisp.c (append_space_for_newline): If the default face was
1948 remapped, use the remapped face for the appended newline.
1949 (extend_face_to_end_of_line): Use the remapped default face for
1950 extending the face to the end of the line.
1951 (display_line): Call extend_face_to_end_of_line when the default
1952 face was remapped. (Bug#11068)
1954 2012-03-29 Eli Zaretskii <eliz@gnu.org>
1956 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
1958 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1960 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
1962 2012-03-27 Glenn Morris <rgm@gnu.org>
1964 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
1967 2012-03-26 Kenichi Handa <handa@m17n.org>
1969 * dispextern.h (struct glyph): Fix previous change. Change the
1970 bit length of glyphless.ch to 25 (Bug#11082).
1972 2012-03-26 Chong Yidong <cyd@gnu.org>
1974 * keyboard.c (Vselection_inhibit_update_commands): New variable.
1975 (command_loop_1): Use it; inhibit selection update for
1976 handle-select-window too (Bug#8996).
1978 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
1980 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
1982 2012-03-25 Kenichi Handa <handa@m17n.org>
1984 * dispextern.h (struct glyph): Change the bit length of
1985 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
1987 2012-03-24 Eli Zaretskii <eliz@gnu.org>
1989 * s/ms-w32.h (tzname): Include time.h before redirecting to
1990 _tzname. Fixes the MSVC build. (Bug#9960)
1992 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
1994 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
1997 * xterm.c (XTread_socket): Only modify handling_signal if
1998 !SYNC_INPUT. (Bug#11080)
2000 2012-03-23 Eli Zaretskii <eliz@gnu.org>
2002 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
2003 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
2004 when fetching a multibyte character consumes more bytes than
2005 CHAR_BYTES returns, due to unification of CJK characters in
2006 string_char. (Bug#11073)
2008 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
2010 * process.c (wait_reading_process_output): Handle pty disconnect
2011 by refraining from sending oneself a SIGCHLD (bug#10933).
2013 2012-03-22 Chong Yidong <cyd@gnu.org>
2015 * dispextern.h (struct it): New member string_from_prefix_prop_p.
2017 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
2018 Mark string as coming from a prefix property.
2019 (handle_face_prop): Use default face for prefix strings (Bug#4281).
2020 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
2022 2012-03-21 Chong Yidong <cyd@gnu.org>
2024 * xfaces.c (Vface_remapping_alist): Doc fix.
2026 2012-03-20 Eli Zaretskii <eliz@gnu.org>
2028 * w32proc.c (Fw32_set_console_codepage)
2029 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
2032 2012-03-20 Chong Yidong <cyd@gnu.org>
2034 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
2035 to reflect default non-nil value of redisplay-dont-pause.
2037 2012-03-19 Kenichi Handa <handa@m17n.org>
2039 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
2040 it fit in a valid range (Bug#11003).
2042 2012-03-18 Eli Zaretskii <eliz@gnu.org>
2044 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
2045 that is not from display property, accept the row as a "cursor
2046 row" if one of the string's character has a non-nil `cursor'
2047 property. Fixes cursor positioning when there are newlines in
2048 overlay strings, e.g. in icomplete.el. (Bug#11035)
2050 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
2052 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
2054 2012-03-12 Chong Yidong <cyd@gnu.org>
2056 * eval.c (inhibit_lisp_code): Rename from
2057 inhibit_window_configuration_change_hook; move from window.c.
2059 * xfns.c (unwind_create_frame_1, Fx_create_frame):
2060 * window.c (run_window_configuration_change_hook)
2061 (syms_of_window): Callers changed.
2063 2012-03-11 Chong Yidong <cyd@gnu.org>
2065 * keymap.c (Fkey_description): Doc fix (Bug#9700).
2067 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
2069 2012-03-10 Chong Yidong <cyd@gnu.org>
2071 * frame.c (other_visible_frames): Don't assume the selected frame
2072 is visible (Bug#10955).
2074 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
2076 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
2078 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
2080 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
2081 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
2084 2012-03-03 Glenn Morris <rgm@gnu.org>
2086 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
2088 2012-03-02 Eli Zaretskii <eliz@gnu.org>
2090 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
2091 position past the first glyph_row that ends at ZV. (Bug#10902)
2092 (redisplay_window, next_element_from_string): Fix typos in
2094 (redisplay_window): Pass to move_it_vertically the margin in
2095 pixels, not in screen lines.
2097 2012-03-02 Glenn Morris <rgm@gnu.org>
2099 * buffer.c (buffer-list-update-hook): Doc fix.
2101 2012-02-29 Eli Zaretskii <eliz@gnu.org>
2103 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
2104 push_it before setting up the iterator for the first overlay
2105 string, even if we have an empty string loaded.
2106 (next_overlay_string): If there's an empty string on the iterator
2107 stack, pop the stack. (Bug#10903)
2109 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
2111 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
2112 Suggested by Stefan Monnier in
2113 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
2114 * alloc.c (widen_to_Lisp_Object): New static function.
2115 (mark_memory): Also mark Lisp_Objects by fetching pointer words
2116 and widening them to Lisp_Objects. This would work even if
2117 USE_LSB_TAG is defined and wide integers are used, which might
2118 happen in a future version of Emacs.
2120 2012-02-25 Chong Yidong <cyd@gnu.org>
2122 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
2125 * xselect.c (Fx_selection_exists_p): Doc fix.
2126 (x_clipboard_manager_save_all): Print an informative message
2127 before saving to clipboard manager.
2129 2012-02-24 Chong Yidong <cyd@gnu.org>
2131 * keyboard.c (process_special_events): Handle all X selection
2132 requests in kbd_buffer, not just the next one (Bug#8869).
2134 2012-02-23 Chong Yidong <cyd@gnu.org>
2136 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
2137 call when setting menu-bar-lines and tool-bar-lines parameters.
2138 (unwind_create_frame_1): New helper function.
2140 * window.c (inhibit_window_configuration_change_hook): New var.
2141 (run_window_configuration_change_hook): Obey it.
2142 (syms_of_window): Initialize it.
2144 2012-02-22 Chong Yidong <cyd@gnu.org>
2146 * xterm.c (x_draw_image_relief): Add missing type check for
2147 Vtool_bar_button_margin (Bug#10743).
2149 2012-02-21 Chong Yidong <cyd@gnu.org>
2151 * fileio.c (Vfile_name_handler_alist): Doc fix.
2153 * buffer.c (Fget_file_buffer): Protect against invalid file
2154 handler return value.
2156 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
2158 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
2159 when computing $valmask.
2161 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
2162 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
2163 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
2164 It's useless in that case, and it can cause problems on hosts
2165 that allocate halves of EMACS_INT values separately.
2166 Reported by Dan Horák. Diagnosed by Andreas Schwab in
2167 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
2168 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
2169 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
2170 it avoids undefined behavior on hosts where shifting right by more
2171 than the word width has undefined behavior.
2173 2012-02-19 Chong Yidong <cyd@gnu.org>
2175 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
2176 (Funhandled_file_name_directory, Ffile_name_as_directory)
2177 (Fdirectory_file_name, Fexpand_file_name)
2178 (Fsubstitute_in_file_name): Protect against invalid file handler
2179 return values (Bug#10845).
2181 2012-02-18 Eli Zaretskii <eliz@gnu.org>
2183 * .gdbinit (pitx): Fix incorrect references to fields of the
2186 2012-02-17 Chong Yidong <cyd@gnu.org>
2188 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
2190 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
2192 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
2193 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
2195 2012-02-15 Chong Yidong <cyd@gnu.org>
2197 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
2198 marked as special. Also, starting docstrings with * is obsolete.
2200 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
2202 * gnutls.c (emacs_gnutls_write): Fix last change.
2204 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
2206 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
2209 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
2211 * keymap.c (Fsingle_key_description): Handle char ranges.
2213 2012-02-12 Chong Yidong <cyd@gnu.org>
2215 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
2216 as that creates a dangerous corner case.
2218 * window.c (Fdelete_window_internal): Invalidate the mouse
2219 highlight (Bug#9904).
2221 2012-02-12 Glenn Morris <rgm@gnu.org>
2223 * xselect.c (Fx_own_selection_internal)
2224 (Fx_get_selection_internal, Fx_disown_selection_internal)
2225 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
2226 * nsselect.m (Fx_own_selection_internal)
2227 (Fx_disown_selection_internal, Fx_selection_exists_p)
2228 (Fx_selection_owner_p, Fx_get_selection_internal):
2229 Sync docs and argument specs with the xselect.c versions.
2231 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
2233 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
2235 2012-02-11 Eli Zaretskii <eliz@gnu.org>
2237 * w32select.c (Fx_selection_exists_p): Sync doc string and
2238 argument list with xselect.c. (Bug#10783)
2240 * w16select.c (Fx_selection_exists_p): Sync doc string and
2241 argument list with xselect.c. (Bug#10783)
2243 2012-02-10 Glenn Morris <rgm@gnu.org>
2245 * fns.c (Fsecure_hash): Doc fix.
2247 2012-02-09 Kenichi Handa <handa@m17n.org>
2249 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
2251 2012-02-07 Chong Yidong <cyd@gnu.org>
2253 * buffer.c (Fbuffer_local_variables)
2254 (buffer_lisp_local_variables): Handle unbound vars correctly;
2255 don't let Qunbound leak into Lisp.
2257 2012-02-07 Glenn Morris <rgm@gnu.org>
2259 * image.c (Fimagemagick_types): Doc fix.
2261 * image.c (imagemagick-render-type): Change it from a lisp object
2262 to an integer. Move the doc here from the lisp manual.
2263 Treat all values not equal to 0 the same.
2265 2012-02-06 Chong Yidong <cyd@gnu.org>
2267 * doc.c (store_function_docstring): Avoid applying docstring of
2268 alias to base function (Bug#2603).
2270 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
2272 * .gdbinit (pp1, pv1): Remove redundant defines.
2275 2012-02-04 Chong Yidong <cyd@gnu.org>
2277 * nsterm.m: Declare a global (Bug#10694).
2279 2012-02-04 Eli Zaretskii <eliz@gnu.org>
2281 * w32.c (get_emacs_configuration_options):
2282 Include --enable-checking, if specified, in the return value.
2284 2012-02-04 Martin Rudalics <rudalics@gmx.at>
2286 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
2287 after rounding frame sizes. (Bug#9723)
2289 2012-02-04 Eli Zaretskii <eliz@gnu.org>
2291 * keyboard.c (adjust_point_for_property): Don't position point
2292 before BEGV. (Bug#10696)
2294 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
2296 Handle overflow when computing char display width (Bug#9496).
2297 * character.c (char_width): Return EMACS_INT, not int.
2298 (char_width, c_string_width): Check for overflow when
2299 computing the width; this is possible now that individual
2300 characters can have unbounded width. Problem introduced
2301 by merge from Emacs 23 on 2012-01-19.
2303 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
2305 * dbusbind.c (Fdbus_register_method): Mention the return value
2306 :ignore in the docstring.
2308 2012-02-02 Glenn Morris <rgm@gnu.org>
2310 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
2312 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2313 Unconditionally set to t. (Bug#10673)
2314 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2315 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2316 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
2318 2012-02-02 Kenichi Handa <handa@m17n.org>
2320 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
2321 0, do not call append_composite_glyph.
2323 2012-02-02 Kenichi Handa <handa@m17n.org>
2325 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
2327 (x_produce_glyphs): If the component of a composition is a null
2328 string, set it->pixel_width to 1 to avoid zero-width glyph.
2330 2012-02-01 Eli Zaretskii <eliz@gnu.org>
2332 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
2333 first 2 arguments are identical. This makes inserting large
2334 output from a subprocess an order of magnitude faster on
2335 MS-Windows, where all sbrk'ed memory is always contiguous.
2337 2012-01-31 Glenn Morris <rgm@gnu.org>
2339 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2340 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2341 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
2343 2012-01-29 Glenn Morris <rgm@gnu.org>
2345 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
2347 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
2349 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
2351 2012-01-28 Chong Yidong <cyd@gnu.org>
2353 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
2355 2012-01-26 Chong Yidong <cyd@gnu.org>
2357 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
2359 * search.c (Fsearch_forward, Fsearch_backward): Document negative
2360 repeat counts (Bug#10507).
2362 2012-01-26 Glenn Morris <rgm@gnu.org>
2364 * lread.c (syms_of_lread): Doc fix.
2366 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
2368 * coding.c (encode_designation_at_bol): Change return value to
2371 2012-01-25 Chong Yidong <cyd@gnu.org>
2373 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
2375 2012-01-21 Chong Yidong <cyd@gnu.org>
2377 * floatfns.c (Fcopysign): Make the second argument non-optional,
2378 since nil is not allowed anyway.
2380 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
2382 * process.c (read_process_output): Use p instead of XPROCESS (proc).
2383 (send_process): Likewise.
2385 2012-01-19 Martin Rudalics <rudalics@gmx.at>
2387 * window.c (save_window_save, Fcurrent_window_configuration)
2388 (Vwindow_persistent_parameters): Do not use Qstate.
2389 Rewrite doc-strings.
2391 2012-01-19 Kenichi Handa <handa@m17n.org>
2393 * character.c (char_width): New function.
2394 (Fchar_width, c_string_width, lisp_string_width):
2395 Use char_width (Bug#9496).
2397 2012-01-16 Martin Rudalics <rudalics@gmx.at>
2399 * window.c (Vwindow_persistent_parameters): New variable.
2400 (Fset_window_configuration, save_window_save): Handle persistent
2403 2012-01-14 Eli Zaretskii <eliz@gnu.org>
2405 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
2406 thrashing the stack of the thread. (Bug#9087)
2408 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
2410 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
2412 2012-01-11 Eli Zaretskii <eliz@gnu.org>
2414 * xdisp.c (rows_from_pos_range): Handle the case where the
2415 highlight ends on a newline. (Bug#10464)
2416 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
2417 he end column for display of highlight that ends on a newline
2420 2012-01-11 Glenn Morris <rgm@gnu.org>
2422 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
2423 from load-path also when installation-directory is nil. (Bug#10208)
2425 2012-01-10 Glenn Morris <rgm@gnu.org>
2427 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
2429 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
2430 Update template values to be closer to their typical values these days.
2432 2012-01-09 Eli Zaretskii <eliz@gnu.org>
2434 * xdisp.c (rows_from_pos_range): Accept additional argument
2435 DISP_STRING, and accept any glyph in a row whose object is that
2436 string as eligible for mouse highlight. Fixes mouse highlight of
2437 display strings from overlays. (Bug#10464)
2439 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
2441 emacs: fix an auto-save permissions race condition (Bug#10400)
2442 * fileio.c (auto_saving_dir_umask): New static var.
2443 (Fmake_directory_internal): Use it.
2444 (do_auto_save_make_dir): Set it, instead of invoking chmod after
2445 creating the directory. The old code temporarily assigns
2446 too-generous permissions to the directory.
2447 (do_auto_save_eh): Clear it.
2448 (Fdo_auto_save): Catch all errors, not just file errors, so
2449 that the var is always cleared.
2451 2012-01-07 Eli Zaretskii <eliz@gnu.org>
2453 * search.c (scan_buffer): Pass character positions to
2454 know_region_cache, not byte positions. (Bug#6540)
2456 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
2458 * w32.c (sys_rename): Report EXDEV when rename of a directory
2459 fails because the target is on another logical disk. (Bug#10284)
2461 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
2463 * xterm.c (x_embed_request_focus): New function.
2465 * xterm.h: Add prototype.
2467 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
2469 2012-01-05 Glenn Morris <rgm@gnu.org>
2471 * emacs.c (emacs_copyright): Update short copyright year to 2012.
2473 2012-01-01 Eli Zaretskii <eliz@gnu.org>
2475 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
2476 Load gnutls_transport_set_lowat only if GnuTLS version is below
2478 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
2479 GnuTLS versions below 2.11.1.
2481 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
2483 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
2484 to the doc string advising against its use for altering the way
2485 windows are scrolled.
2487 2011-12-28 Kenichi Handa <handa@m17n.org>
2489 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
2490 coding-system ASCII compatible only when it does not produce BOM
2491 on encoding (Bug#10383).
2493 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
2495 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
2497 (create_and_show_popup_menu): Always use menu_position_func for
2500 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
2502 * callint.c (Fcall_interactively): Don't truncate prompt string.
2504 2011-12-23 Eli Zaretskii <eliz@gnu.org>
2506 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
2507 property that ends at ZV, so that the bidi iteration could be
2508 resumed from there (after widening). (Bug#10360)
2510 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
2512 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
2514 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
2516 * nsterm.m (x_free_frame_resources):
2517 Release f->output_data.ns->miniimage.
2518 (ns_index_color): Fix indentation. Do not retain
2519 color_table->colors[i].
2521 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
2524 * nsfns.m (x_set_background_color): Assign return value from
2525 ns_index_color to face-background instead of NSColor*.
2526 (ns_implicitly_set_icon_type): Fix indentation.
2527 Change assignment in for loop to comparison.
2529 * emacs.c (ns_pool): New variable.
2530 (main): Assign ns_pool.
2531 (Fkill_emacs): Call ns_release_autorelease_pool.
2533 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
2534 autorelease fdesc, release fdAttrs and tdict.
2535 (ns_get_covering_families): Release charset.
2536 (ns_findfonts): Release NSFontDescriptor created with new.
2537 (ns_uni_to_glyphs): Fix indentation.
2538 (setString): Release attrStr before assigning new value.
2540 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2542 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
2544 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
2545 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
2547 2011-12-18 David Reitter <reitter@cmu.edu>
2549 * nsterm.m (ns_term_init): Subscribe for notifications
2550 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
2551 to method trackingNotification in EmacsMenu.
2553 * nsmenu.m (trackingMenu): New variable.
2554 (trackingNotification): New method (from Aquamacs).
2555 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
2556 from Aquamacs (Bug#7030).
2558 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2560 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
2561 (symbol_to_nsstring): Fix indentation.
2562 (ns_symbol_to_pb): New function.
2563 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
2564 (Fns_rotate_cut_buffers_internal): Remove.
2565 (Fns_store_selection_internal): Rename from
2566 Fns_store_cut_buffer_internal.
2567 (ns_get_foreign_selection, Fx_own_selection_internal)
2568 (Fx_disown_selection_internal, Fx_selection_exists_p)
2569 (Fns_get_selection_internal, Fns_store_selection_internal):
2570 Use ns_symbol_to_pb and check if return value is nil.
2571 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
2572 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
2573 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
2574 renamed to Sns_store_selection_internal.
2575 (ns_handle_selection_request): Move code to Fx_own_selection_internal
2576 and remove this function.
2577 (ns_handle_selection_clear): Remove, never used.
2578 (Fx_own_selection_internal): Move code from ns_handle_selection_request
2581 2011-12-17 Ken Brown <kbrown@cornell.edu>
2583 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
2584 GID is unknown (Bug#10257).
2586 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
2588 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
2589 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
2590 which caused a build failure on GNU/Linux IA-64. This problem was
2591 introduced by my 2011-10-07 patch.
2593 2011-12-15 Juri Linkov <juri@jurta.org>
2595 * image.c (imagemagick_error): New function. (Bug#10112)
2596 (imagemagick_load_image): Comment out `MagickSetResolution' call.
2597 Use `imagemagick_error' where ImageMagick functions return
2599 (Fimagemagick_types): Add `Fnreverse' to return the list in the
2602 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2604 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
2605 fill background (Bug#8992).
2607 2011-12-13 Martin Rudalics <rudalics@gmx.at>
2609 * window.c (Vwindow_combination_resize)
2610 (Vwindow_combination_limit): Use t instead of non-nil in
2612 (Vrecenter_redisplay): Add first sentence of doc-string on
2614 (Frecenter): Fix doc-string typo.
2616 2011-12-11 Kenichi Handa <handa@m17n.org>
2618 * coding.c (Funencodable_char_position): Pay attention to the
2619 buffer text relocation (Bug#9389).
2621 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2623 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
2624 gtk_init (Bug#10100).
2626 2011-12-10 Eli Zaretskii <eliz@gnu.org>
2628 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
2629 IT->string is nil. (Bug#10263)
2631 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2633 * nsterm.h (x_free_frame_resources): Declare.
2635 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
2636 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
2638 * nsterm.h (ns_get_defaults_value): Declare.
2640 * nsterm.m (ns_default): Call ns_get_defaults_value.
2642 2011-12-09 Eli Zaretskii <eliz@gnu.org>
2644 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
2647 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2649 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
2650 that where the value of an _OBJC_* symbol points to is in the .bss
2651 section (Bug#10240).
2653 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2655 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2656 after the loop to call ccl_driver at least once (Bug#8619).
2658 2011-12-08 Kenichi Handa <handa@m17n.org>
2660 * ftfont.c (get_adstyle_property): Fix previous change
2663 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
2665 * w32.c (init_environment): If no_site_lisp, remove site-lisp
2666 dirs from the default value of EMACSLOADPATH (bug#10208).
2668 2011-12-07 Glenn Morris <rgm@gnu.org>
2670 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
2671 installation and source directories as well. (Bug#10208)
2673 2011-12-06 Chong Yidong <cyd@gnu.org>
2675 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
2677 2011-12-06 Glenn Morris <rgm@gnu.org>
2679 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
2680 as an error, not just -1. (Bug#10217)
2682 2011-12-05 Chong Yidong <cyd@gnu.org>
2684 * keyboard.c (process_special_events): New function.
2685 (swallow_events, Finput_pending_p): Use it (Bug#10195).
2687 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
2689 * coding.c (encode_designation_at_bol): Don't use uninitialized
2690 local variable (Bug#9318).
2692 2011-12-05 Kenichi Handa <handa@m17n.org>
2694 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
2695 return Qnil (Bug#8046, Bug#10193).
2697 2011-12-05 Kenichi Handa <handa@m17n.org>
2699 * coding.c (encode_designation_at_bol): New args charbuf_end and
2700 dst. Return the number of produced bytes. Callers changed.
2701 (coding_set_source): Return how many bytes coding->source was
2703 (coding_set_destination): Return how many bytes
2704 coding->destination was relocated.
2705 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
2706 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
2708 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2710 * coding.c (CODING_CHAR_CHARSET_P): New macro.
2711 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
2714 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
2716 The following changes are to fix Bug#9318.
2718 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
2719 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
2720 (encode_coding_iso_2022, encode_coding_sjis)
2721 (encode_coding_big5, encode_coding_charset): Use the above macros.
2723 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
2725 * lisp.h (process_quit_flag): Fix external declaration.
2727 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
2729 Don't macro-inline non-performance-critical code.
2730 * eval.c (process_quit_flag): New function.
2731 * lisp.h (QUIT): Use it.
2733 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
2735 * nsfns.m (get_geometry_from_preferences): New function.
2736 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
2738 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
2740 * emacs.c (Qkill_emacs): Define.
2741 (syms_of_emacs): Initialize it.
2742 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
2743 Qquit_flag to `kill-emacs' instead.
2744 (quit_throw_to_read_char): Add parameter `from_signal'.
2745 All callers changed. Call Fkill_emacs if requested and safe.
2746 * lisp.h (QUIT): Call Fkill_emacs if requested.
2748 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
2750 * widget.c (update_wm_hints): Return if wmshell is null.
2751 (widget_update_wm_size_hints): New function.
2753 * widget.h (widget_update_wm_size_hints): Declare.
2755 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
2756 widget_update_wm_size_hints (Bug#10104).
2758 2011-12-03 Eli Zaretskii <eliz@gnu.org>
2760 * xdisp.c (handle_invisible_prop): If the invisible text ends just
2761 before a newline, prepare the bidi iterator for consuming the
2762 newline, and keep the current paragraph direction. (Bug#10183)
2763 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
2765 2011-12-02 Juri Linkov <juri@jurta.org>
2767 * search.c (Fword_search_regexp): New Lisp function created from
2768 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
2769 (Fword_search_backward, Fword_search_forward)
2770 (Fword_search_backward_lax, Fword_search_forward_lax):
2771 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
2772 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
2774 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
2776 * fileio.c (Finsert_file_contents): Move after-change-function call
2777 to before the "handled:" label, since all "goto handled" appear in
2778 cases where the *-change-functions have already been properly called
2781 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
2783 * keyboard.c (interrupt_signal): Don't call kill-emacs when
2784 waiting for input. (Bug#10169)
2786 2011-11-30 Eli Zaretskii <eliz@gnu.org>
2788 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
2789 verifies glyph row's hash code--we have just reallocated the
2790 glyphs, so their contents can be complete garbage. (Bug#10164)
2792 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
2794 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
2796 2011-11-30 Eli Zaretskii <eliz@gnu.org>
2798 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
2799 attributes are tested _before_ calling verify_row_hash, to protect
2800 against GCC re-ordering of the tests. (Bug#10164)
2802 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
2804 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
2806 * xterm.c (handle_one_xevent): Only set async_visible and friends
2807 if net_wm_state_hidden_seen is non-zero (Bug#10002)
2808 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2809 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
2811 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
2813 Remove GCPRO-related macros that exist only to avoid shadowing locals.
2814 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
2815 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
2816 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
2817 All uses changed to use GCPRO1 etc.
2818 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
2819 Revert to old implementation (i.e., before 2011-03-11).
2821 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2823 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
2824 of scroll runs so as to avoid assigning disabled bogus rows and
2825 unnecessary graphics copy operations.
2827 2011-11-27 Eli Zaretskii <eliz@gnu.org>
2829 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
2830 (snprintf) [_MSC_VER]: Redirect to _snprintf.
2831 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
2832 (malloc, free, realloc, calloc): Redirect to e_* only when
2835 * lisp.h (GCTYPEBITS): Move before first use.
2836 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
2837 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
2838 this macro definition.
2840 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
2843 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
2845 * gtkutil.c (xg_create_frame_widgets):
2846 Call gtk_window_set_has_resize_grip (FALSE) if that function is
2847 present with Gtk+ 2.0.
2849 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
2851 * fileio.c (Finsert_file_contents): Undo previous change; see
2852 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
2854 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
2856 Rename locals to avoid shadowing.
2857 * fileio.c (Finsert_file_contents):
2858 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
2859 * process.c (wait_reading_process_output):
2860 Rename inner 'proc' to 'p' to avoid shadowing.
2861 Indent for consistency with usual Emacs style.
2863 2011-11-25 Eli Zaretskii <eliz@gnu.org>
2865 * xdisp.c (redisplay_window): If cursor row is not fully visible
2866 after recentering, and scroll-conservatively is set to a large
2867 number, scroll window by a few more lines to make the cursor fully
2868 visible and out of scroll-margin. (Bug#10105)
2869 (start_display): Don't move to the next line if the display should
2870 start at a newline that is part of a display vector or an overlay
2873 2011-11-24 Juri Linkov <juri@jurta.org>
2875 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
2876 after the `MagickPingImage' call. (Bug#10112)
2878 2011-11-23 Chong Yidong <cyd@gnu.org>
2880 * window.c (Fcoordinates_in_window_p): Accept only live windows.
2882 2011-11-23 Martin Rudalics <rudalics@gmx.at>
2884 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
2885 making another buffer current. (Bug#10114)
2887 2011-11-23 Glenn Morris <rgm@gnu.org>
2889 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
2891 2011-11-23 Chong Yidong <cyd@gnu.org>
2893 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
2894 using it (Bug#5984).
2896 2011-11-22 Eli Zaretskii <eliz@gnu.org>
2898 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
2899 and header-lines, as they don't have one computed for them.
2902 * .gdbinit (prow): Make displayed values more self-explaining.
2903 Add row's hash code.
2905 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
2907 * process.c (wait_reading_process_output): Fix asynchrounous
2908 GnuTLS socket handling on some versions of the GnuTLS library.
2909 (wait_reading_process_output): Add comment and URL.
2911 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
2913 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
2915 2011-11-21 Chong Yidong <cyd@gnu.org>
2917 * window.c (Fnext_window, Fprevious_window): Doc fix.
2919 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
2921 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
2923 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
2925 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
2927 2011-11-20 Martin Rudalics <rudalics@gmx.at>
2929 * window.c (Fset_window_combination_limit): Rename argument
2931 (Vwindow_combination_limit): Remove "status" from doc-string.
2933 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
2935 * m/ibms390.h: Remove.
2936 * m/ibms390x.h: Don't include "ibms390.h".
2938 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
2940 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
2941 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
2943 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
2945 * casetab.c (Fset_case_table):
2946 * charset.c (Fcharset_after): Fix typos.
2948 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
2950 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
2951 Otherwise, valgrind does not work on some platforms.
2952 Problem reported by Andreas Schwab in
2953 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
2954 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
2955 is set, removing the need for VIRT_ADDRESS_VARIES.
2956 (PURE_P): Use a more-efficient implementation that needs just one
2957 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
2958 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
2959 to 4 (xorl, subq, cmpq, setbe).
2960 * alloc.c (pure): Always extern now, since that's the
2961 VIRT_ADDR_VARIES behavior.
2962 (PURE_POINTER_P): Use a single comparison, not two, for
2963 consistency with the new puresize.h.
2964 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
2965 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
2966 Remove VIRT_ADDR_VARIES no longer needed.
2968 2011-11-19 Eli Zaretskii <eliz@gnu.org>
2970 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
2971 (erase_phys_cursor, update_window_cursor, show_mouse_face)
2972 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
2973 behave as if the cursor position were at the window margin.
2975 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
2976 and the cursor position is out of bounds, behave as if the cursor
2977 position were at the window margin. (Bug#10075)
2979 2011-11-18 Chong Yidong <cyd@gnu.org>
2981 * window.c (Fwindow_combination_limit): Make first argument
2982 non-optional, since it is meaningless for live windows like the
2985 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
2987 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
2989 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
2991 * intervals.c: Fix grafting over the whole buffer (bug#10071).
2992 (graft_intervals_into_buffer): Simplify.
2994 2011-11-18 Eli Zaretskii <eliz@gnu.org>
2996 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
2997 hash values of the two rows.
2998 (copy_row_except_pointers): Preserve the used[] arrays and the
2999 hash values of the two rows. (Bug#10035)
3000 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
3002 * xdisp.c (row_hash): New function, body extracted from
3003 compute_line_metrics.
3004 (compute_line_metrics): Call row_hash, instead of computing the
3007 * dispnew.c (verify_row_hash): Call row_hash for computing the
3008 hash code of a row, instead of duplicating code from xdisp.c.
3010 * dispextern.h (row_hash): Add prototype.
3012 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
3014 * frame.c (delete_frame): Don't delete the terminal when the last
3015 X frame is closed if emacs is built with GTK toolkit.
3017 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
3019 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
3021 2011-11-17 Martin Rudalics <rudalics@gmx.at>
3023 * window.c (Vwindow_splits): Rename to
3024 Vwindow_combination_resize. Suggested by Juri Linkov.
3025 (Fsplit_window_internal): Use Vwindow_combination_resize instead
3028 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
3030 * nsfns.m (Fns_font_name):
3031 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
3033 2011-11-16 Martin Rudalics <rudalics@gmx.at>
3035 * window.h (window): Rename slot "nest" to "combination_limit".
3036 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
3037 (Fset_window_nest): Rename to Fset_window_combination_limit.
3038 (Vwindow_nest): Rename to Vwindow_combination_limit.
3039 (recombine_windows, make_parent_window, make_window)
3040 (Fsplit_window_internal, saved_window)
3041 (Fset_window_configuration, save_window_save): Rename all
3042 occurrences of window_nest to window_combination_limit.
3044 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
3046 * image.c (imagemagick_load_image): Fix typo.
3048 2011-11-14 Eli Zaretskii <eliz@gnu.org>
3050 * xdisp.c (display_line): Move the call to
3051 highlight_trailing_whitespace before the call to
3052 compute_line_metrics, since the latter needs to see the final
3053 faces of all the glyphs to compute ROW's hash value.
3054 Fixes assertion violations in row_equal_p. (Bug#10035)
3056 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
3058 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
3059 just return (bug#10044).
3061 2011-11-12 Eli Zaretskii <eliz@gnu.org>
3063 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
3064 with user-defined heap size. Bump the default size of the temacs
3065 heap to 27MB, to avoid memory warning when running temacs.
3066 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
3068 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
3069 current_matrix and desired_matrix. (Bug#9990)
3070 (verify_row_hash) [XASSERTS]: New function.
3071 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
3072 that the hash value of glyph rows is correct.
3074 2011-11-12 Martin Rudalics <rudalics@gmx.at>
3076 * window.h (window): Remove splits slot.
3077 * window.c (Fwindow_splits, Fset_window_splits): Remove.
3078 (Fdelete_other_windows_internal, make_parent_window)
3079 (make_window, Fsplit_window_internal, Fdelete_window_internal)
3080 (Fset_window_configuration, save_window_save): Don't deal with
3081 split status of windows.
3082 (saved_window): Remove splits slot.
3083 (Vwindow_splits): Rewrite doc-string.
3085 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
3087 * xfns.c (unwind_create_frame):
3088 * nsfns.m (unwind_create_frame):
3089 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
3090 Vframe_list (Bug#9999).
3092 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
3094 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
3096 2011-11-11 Kenichi Handa <handa@m17n.org>
3098 * callproc.c (Fcall_process): Set the member dst_multibyte of
3101 2011-11-11 Johan Bockgård <bojohan@gnu.org>
3103 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
3104 avoid a crash (bug#9496).
3106 2011-11-09 Chong Yidong <cyd@gnu.org>
3108 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
3109 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
3111 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3113 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
3115 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3117 Avoid some portability problems by eschewing 'extern inline' functions.
3118 The trivial performance wins aren't worth the portability hassles; see
3119 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
3121 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3122 (window_box_width, window_box_left, window_box_left_offset)
3123 (window_box_right, window_box_right_offset): Undo previous change,
3124 by removing the "extern"s.
3125 * intervals.c (adjust_intervals_for_insertion)
3126 (adjust_intervals_for_deletion): Undo previous change,
3127 making these static again.
3128 (offset_intervals, temp_set_point_both, temp_set_point)
3129 (copy_intervals_to_string): No longer inline.
3130 * xdisp.c (window_text_bottom_y, window_box_width)
3131 (window_box_height, window_box_left_offset)
3132 (window_box_right_offset, window_box_left, window_box_right)
3133 (window_box): No longer inline.
3135 2011-11-08 Chong Yidong <cyd@gnu.org>
3137 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
3138 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
3139 Signal an error if not a live window.
3140 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
3141 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
3143 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
3145 * lisp.h (syms_of_abbrev): Remove declaration.
3146 Reported by CHENG Gao <chenggao@royau.me>.
3148 2011-11-07 Eli Zaretskii <eliz@gnu.org>
3150 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
3151 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
3152 of temacs in GUI mode.
3154 2011-11-07 Martin Rudalics <rudalics@gmx.at>
3156 * window.h: Declare delete_all_child_windows instead of
3157 delete_all_subwindows.
3158 * window.c (Fwindow_nest, Fset_window_nest)
3159 (Fset_window_new_total, Fset_window_new_normal)
3160 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
3161 (delete_all_subwindows): Rename to delete_all_child_windows.
3162 (Fdelete_other_windows_internal, Fset_window_configuration):
3163 Call delete_all_child_windows instead of delete_all_subwindows.
3164 * frame.c (delete_frame): Call delete_all_child_windows instead
3165 of delete_all_subwindows.
3167 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
3169 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
3170 This is also needed for porting to any host where GC_MARK_STACK is
3171 not GC_MAKE_GCPROS_NOOPS.
3172 (which_symbols): Use it.
3174 2011-11-07 Kenichi Handa <handa@m17n.org>
3176 * coding.c (coding_set_destination): Check coding->src_pos only
3177 when coding->src_object is a buffer (bug#9910).
3179 * process.c (send_process): Set the member src_multibyte of coding
3180 to 0 (bug#9911) when sending a unibyte text.
3182 * callproc.c (Fcall_process): Set the member src_multibyte of
3183 process_coding to 0 (bug#9912).
3185 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3187 * xmenu.c (cleanup_widget_value_tree): New function.
3188 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
3189 calling free_menubar_widget_value_tree directly (Bug#9830).
3191 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
3193 Fix some portability problems with 'inline'.
3194 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3195 (window_box_width, window_box_left, window_box_left_offset)
3196 (window_box_right, window_box_right_offset): Declare extern.
3197 Otherwise, these inline functions do not conform to C99 and
3198 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
3199 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
3200 * intervals.c (adjust_intervals_for_insertion)
3201 (adjust_intervals_for_deletion): Now extern, because otherwise the
3202 extern inline functions 'offset_intervals' couldn't refer to it.
3203 (static_offset_intervals): Remove.
3204 (offset_intervals): Rewrite using the old contents of
3205 static_offset_intervals. The old version didn't conform to C99
3206 because an extern inline function contained a reference to an
3207 identifier with static linkage.
3209 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
3211 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
3214 2011-11-06 Eli Zaretskii <eliz@gnu.org>
3216 * xdisp.c (init_iterator, reseat_to_string): Don't set the
3217 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
3218 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
3219 return Qleft_to_right.
3221 2011-11-06 Chong Yidong <cyd@gnu.org>
3223 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
3224 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
3225 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
3226 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
3227 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
3228 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
3229 (Fwindow_vscroll): Doc fix.
3230 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
3231 argument, since it makes no sense to pass a live window and for
3232 consistency with window-child.
3234 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
3236 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
3239 2011-11-05 Jason Rumney <jasonr@gnu.org>
3241 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
3242 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
3244 (add_font_entity_to_list): Fix logic errors in mixed boolean and
3245 bitwise arithmetic preventing use of unicode-sip and non-truetype
3248 2011-11-05 Eli Zaretskii <eliz@gnu.org>
3250 * s/ms-w32.h (fstat, stat, utime): Move redirections to
3253 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
3254 initialization code to keep similarity to xfns.c after changes
3257 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
3259 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
3260 (unwind_create_frame): New function (Bug#9943).
3261 (Fx_create_frame): Restructure code to be more similar to the one in
3262 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
3263 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
3264 Move terminal->reference_count++ just before making the frame official
3267 * nsterm.m (x_free_frame_resources): New function.
3268 (x_destroy_window): Move code to x_free_frame_resources.
3270 * xfns.c (unwind_create_frame): Fix comment.
3271 (Fx_create_frame, x_create_tip_frame):
3272 Move terminal->reference_count++ just before making the frame
3273 official. Move initialization of image_cache_refcount and
3274 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
3276 2011-11-05 Eli Zaretskii <eliz@gnu.org>
3278 Support MSVC build with newer versions of Visual Studio.
3279 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
3280 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
3283 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
3284 which are not supported by MSVC.
3285 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
3286 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
3288 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
3290 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
3292 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
3294 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
3296 Support MSVC build with newer versions of Visual Studio.
3297 * w32.c: Don't include w32api.h for MSVC.
3298 (init_environment) [_MSC_VER]: Call sys_access, not _access.
3300 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
3301 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
3302 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
3303 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
3305 (alloca) [_MSC_VER]: Define to _alloca.
3307 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
3309 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
3311 2011-11-04 Eli Zaretskii <eliz@gnu.org>
3313 * xdisp.c (note_mouse_highlight): If either of
3314 previous/next-single-property-change returns nil, treat that as
3315 the beginning or the end of the buffer. (Bug#9955)
3317 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
3319 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
3320 label is not null (Bug#9951).
3321 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
3324 2011-11-04 Eli Zaretskii <eliz@gnu.org>
3326 * window.c (Fwindow_body_size): Mention in the doc string that the
3327 return value is in frame's canonical units. (Bug#9949)
3329 2011-11-03 Eli Zaretskii <eliz@gnu.org>
3331 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
3333 * w32fns.c (unwind_create_frame): If needed, free the glyph
3334 matrices of the partially constructed frame. (Bug#9943)
3335 * xfns.c (unwind_create_frame): Likewise.
3337 2011-11-01 Eli Zaretskii <eliz@gnu.org>
3339 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
3340 Don't stop backward scan on the continuation glyph, even though
3341 its CHARPOS is positive.
3342 (mouse_face_from_buffer_pos, note_mouse_highlight):
3343 Rename cover_string to disp_string.
3345 2011-11-01 Martin Rudalics <rudalics@gmx.at>
3347 * window.c (temp_output_buffer_show): Don't use
3348 Vtemp_buffer_show_specifiers.
3349 (Vtemp_buffer_show_specifiers): Remove unused variable.
3351 2011-10-30 Eli Zaretskii <eliz@gnu.org>
3353 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
3354 past the beginning of the current glyph matrix.
3356 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
3358 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
3359 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
3360 HAVE_GTK3 (Bug#9869).
3362 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
3363 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
3365 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
3367 * xterm.c: Declare x_handle_net_wm_state to return int.
3368 (handle_one_xevent): Check if we are iconified but don't have
3369 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
3370 (get_current_wm_state): Return non-zero if not hidden,
3371 check for _NET_WM_STATE_HIDDEN (Bug#9893).
3372 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
3373 (x_handle_net_wm_state): Return what get_current_wm_state returns.
3374 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
3376 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
3378 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
3379 so that this new function doesn't get optimized away by a
3380 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
3382 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3384 * frame.h (MOUSE_HL_INFO): Remove excess parens.
3386 2011-10-29 Eli Zaretskii <eliz@gnu.org>
3388 Fix the `xbytecode' command.
3389 * .gdbinit (xprintbytestr): New command.
3390 (xwhichsymbols): Rename from `which'; all callers changed.
3391 (xbytecode): Print the byte-code string as well.
3393 2011-10-29 Kim Storm <storm@cua.dk>
3395 * alloc.c (which_symbols): New function.
3397 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3399 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
3402 2011-10-29 Glenn Morris <rgm@gnu.org>
3404 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
3405 Not clear what it was for, and it causes various bugs. (Bug#9839)
3407 2011-10-28 Eli Zaretskii <eliz@gnu.org>
3409 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
3410 possible random value that matches one of those tested as
3411 condition to clear the mouse face.
3413 2011-10-28 Chong Yidong <cyd@gnu.org>
3415 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
3417 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
3419 * window.c (make_window): Initialize phys_cursor_on_p.
3421 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
3423 * lisp.h (struct Lisp_Symbol): Update comments.
3425 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
3427 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
3429 2011-10-28 Eli Zaretskii <eliz@gnu.org>
3431 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
3432 <oslsachem@gmail.com> for helping to debug this.
3434 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
3435 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
3436 (g_b_init_get_glyph_outline_w): New static variables.
3437 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
3438 (GetGlyphOutlineW_Proc): New typedefs.
3439 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
3440 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
3442 (w32font_open_internal, compute_metrics):
3443 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
3444 instead of calling the "wide" APIs directly.
3446 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
3448 * w32.h (syms_of_w32font): Add prototype.
3450 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
3452 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
3453 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
3454 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
3455 (Fmove_to_window_line): Doc fix.
3457 2011-10-27 Chong Yidong <cyd@gnu.org>
3459 * process.c (make_process): Set gnutls_state to NULL.
3461 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
3462 non-NULL, regardless of GNUTLS_INITSTAGE.
3463 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
3464 an error. Set process slots as soon as we allocate them.
3466 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
3468 2011-10-27 Chong Yidong <cyd@gnu.org>
3470 * gnutls.c (emacs_gnutls_deinit): New function.
3471 Deallocate credentials structures as well as calling gnutls_deinit.
3472 (Fgnutls_deinit, Fgnutls_boot): Use it.
3474 * process.c (make_process): Initialize GnuTLS credentials to NULL.
3475 (deactivate_process): Call emacs_gnutls_deinit.
3477 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
3479 * image.c (x_create_x_image_and_pixmap):
3480 * w32.c (sys_rename, w32_delayed_load):
3481 * w32font.c (fill_in_logfont):
3482 * w32reg.c (x_get_string_resource): Silence compiler warnings.
3484 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
3486 * w32fns.c (w32_default_color_map): New function,
3487 extracted from Fw32_default_color_map.
3488 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
3490 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
3492 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
3494 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
3496 * keyboard.c (test_undefined): New function (bug#9751).
3497 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
3499 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
3501 * sysdep.c (init_sys_modes): Fix the check for the controlling
3502 terminal (Bug#6649).
3504 2011-10-20 Eli Zaretskii <eliz@gnu.org>
3506 * dispextern.h (struct bidi_it): New member next_en_type.
3508 * bidi.c (bidi_line_init): Initialize the next_en_type member.
3509 (bidi_resolve_explicit_1): When next_en_pos is valid for the
3510 current character, check also for next_en_type being WEAK_EN.
3511 (bidi_resolve_weak): Don't enter the expensive loop if the current
3512 position is before next_en_pos. Record the bidi type of the first
3513 non-ET, non-BN character we find, in addition to its position.
3514 (bidi_level_of_next_char): Invalidate next_en_type when
3515 next_en_pos is over-stepped.
3517 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
3519 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
3520 * editfns.c: Rewrite current-time-zone so that it invokes
3521 the equivalent of (format-time-string "%Z") to get the time zone name.
3522 This fixes a bug when the time zone name contains characters that
3523 need converting from the system time locale to Emacs internal format.
3524 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
3525 that patch fixed format-time-string to do the conversion, but
3526 I forgot to fix current-time-zone.
3527 (format_time_string): New function, containing most of
3528 what Fformat_time_string used to contain.
3529 (Fformat_time_string): Rewrite in terms of format_time_string.
3530 This doesn't change this function's behavior.
3531 (current-time-zone): Rewrite to use format_time_string.
3532 This fixes the bug reported by Michael Schierl in
3533 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
3534 Jason Rumney's 2007-06-07 change worked around this bug, but
3536 * systime.h (tzname, timezone): Remove no-longer-used declarations.
3538 2011-10-19 Eli Zaretskii <eliz@gnu.org>
3540 * xdisp.c (start_display): If the character at POS is displayed
3541 via a display vector, reset IT->current.dpvec_index to zero.
3542 (try_window_reusing_current_matrix): If a line ends in a display
3543 vector or the next line starts in a display vector, continue
3544 redrawing the window even though the character position of
3545 start_row was reached.
3548 2011-10-18 Chong Yidong <cyd@gnu.org>
3550 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
3551 with nobreak-char-display too.
3553 2011-10-18 Eli Zaretskii <eliz@gnu.org>
3555 Fix part 3 of bug#9771.
3556 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
3557 (bidi_resolve_neutral): Don't enter the expensive loop looking for
3558 non-neutral characters if the current character is a paragraph
3559 separator (a.k.a. Newline). This avoids running the same
3560 expensive loop twice, once when we consume the preceding newline
3561 and the other time when the line actually needs to be displayed.
3562 Avoid the loop when we see neutrals on the base embedding level
3563 following a character whose directionality is the same as the
3564 paragraph's. This avoids running the expensive loop when a line
3565 ends in a long sequence of neutrals, like control characters.
3566 Add assertion against STRONG_AL type. Slightly rearrange code
3567 that determines the type of a neutral given the first non-neutral
3569 (bidi_level_of_next_char): Set next_en_pos to zero when
3570 invalidating its info.
3572 2011-10-17 Eli Zaretskii <eliz@gnu.org>
3574 * xdisp.c (push_display_prop): Determine whether to record string
3575 or buffer position by IT->string, not by IT->method. Allow
3576 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
3577 (move_it_vertically_backward): Don't look for character position
3578 immediately after the newline when in a continuation line.
3581 2011-10-15 Martin Rudalics <rudalics@gmx.at>
3583 * window.c (coordinates_in_window): Rewrite and delabelize
3584 vertical border check. (Bug#5357) (Bug#9618)
3586 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
3588 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
3589 errors in XSetWindowBorder (bug#9310).
3591 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
3593 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
3594 avoid crash when xmalloc overrun checking is enabled.
3596 2011-10-13 Eli Zaretskii <eliz@gnu.org>
3598 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
3599 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
3600 cursor motion with <left> and <right> arrow keys.
3602 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
3603 some callers set that themselves.
3605 2011-10-12 Eli Zaretskii <eliz@gnu.org>
3607 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
3608 display string and the previous row comes from the same string and
3609 is empty. (Bug#9739) (Bug#9738)
3611 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
3613 * doc.c (get_doc_string): Encode file name (bug#9735).
3615 2011-10-12 Eli Zaretskii <eliz@gnu.org>
3617 * bidi.c (bidi_level_of_next_char):
3618 * xdisp.c (get_visually_first_element): Remove old incorrect
3619 comments regarding the Unicode Line Separator character.
3621 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
3623 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
3625 * alloc.c (Fgc_status): Do not access beyond zombies array
3626 boundary if nzombies > MAX_ZOMBIES.
3627 * alloc.c (dump_zombies): Add missing format specifier.
3629 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
3631 * xdisp.c (set_cursor_from_row): Simplify conditionals,
3632 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
3634 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
3635 Some packages use them to denote characters with modifiers.
3637 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
3639 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
3640 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
3641 matching a pp-number. Rename parameter var to var1.
3643 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
3645 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
3647 2011-10-08 Glenn Morris <rgm@gnu.org>
3649 * callint.c (Fcall_interactively): Give a more explicit error for the
3650 'c' case with a non-character input. (Bug#8479)
3652 2011-10-08 Eli Zaretskii <eliz@gnu.org>
3654 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
3656 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
3657 lines that are hscrolled on the left.
3659 * dispnew.c (buffer_posn_from_coords): Account for a possible
3660 presence of header-line. (Bug#4426)
3662 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
3664 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
3665 Don't advertise functionality which we discourage or doesn't work.
3667 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
3669 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
3670 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
3671 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
3672 this makes Emacs dump core during garbage collection on rare
3673 occasions. sizeof is obviously inferior to offsetof here, so
3674 stick with offsetof.
3675 (GC_POINTER_ALIGNMENT): New macro.
3676 (mark_memory): Omit 3rd (offset) arg; caller changed.
3677 Don't assume EMACS_INT alignment is the same as pointer alignment.
3679 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
3681 * keyboard.c (read_key_sequence_remapped): New var.
3682 (read_key_sequence): Compute remapping in the right buffer.
3683 (command_loop_1): Use read_key_sequence's remapping directly.
3685 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
3687 * dired.c (file_name_completion): Don't expand file name.
3688 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
3689 before checking file name handler.
3691 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
3692 they've been requested explicitly (bug#9591).
3694 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
3696 * keymap.c (Fsingle_key_description): Use make_specified_string
3697 instead of build_string to build string from push_key_description.
3700 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3702 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
3703 This fixes a Y2038 bug on 64-bit hosts.
3704 * buffer.c (reset_buffer):
3705 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
3706 (Fclear_buffer_auto_save_failure):
3707 Use 0, not -1, to represent an unset failure time, since time_t
3708 might not be signed.
3710 Remove dependency on glibc malloc internals.
3711 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3712 Move back here from lisp.h, but with their new implementations.
3713 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3714 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
3715 * charset.c (charset_table_init): New static var.
3716 (syms_of_charset): Use it instead of xmalloc. This removes a
3717 dependency on glibc malloc internals. See Eli Zaretskii's comment in
3718 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
3719 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3720 Move back to alloc.c.
3721 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3722 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
3724 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
3726 * nsterm.m (windowDidResize): Call x_set_window_size only when
3727 ns_in_resize is true. Otherwise set pixelwidth/height and
3728 call change_frame_size (Bug#9628).
3730 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3732 Port --enable-checking=all to Fedora 14 x86-64.
3733 * charset.c (syms_of_charset): Also account for glibc malloc's
3734 internal overhead when calculating the initial malloc maximum.
3736 Port --enable-checking=all to Fedora 14 x86.
3737 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3739 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
3740 (overrun_check_realloc, overrun_check_free):
3741 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
3742 That way, xmalloc returns a properly-aligned pointer even if
3743 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
3744 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
3745 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
3746 into account when calculating the initial malloc maximum.
3747 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3748 Move here from alloc.c, so that charset.c can use it too.
3749 Properly align; the old code wasn't right for common 32-bit hosts
3750 when configured with --enable-checking=all.
3751 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3752 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
3754 2011-09-29 Eli Zaretskii <eliz@gnu.org>
3756 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
3759 2011-09-28 Eli Zaretskii <eliz@gnu.org>
3761 * xdisp.c (compute_display_string_end): If there's no display
3762 string at CHARPOS, return -1.
3764 * bidi.c (bidi_fetch_char): When compute_display_string_end
3765 returns a negative value, treat the character as a normal
3766 character not covered by a display string. (Bug#9624)
3768 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
3770 * lread.c (Fread_from_string): Fix typo in docstring.
3772 2011-09-27 Eli Zaretskii <eliz@gnu.org>
3774 * xdisp.c (handle_invisible_prop): If invisible text ends on a
3775 newline, reseat the iterator instead of bidi-iterating there one
3776 character at a time. (Bug#9610)
3777 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
3778 TO_CHARPOS if the bidi iterator is at base embedding level.
3780 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
3782 * lread.c (readevalloop): Use correct code for NBSP.
3783 (read1): Likewise. (Bug#9608)
3785 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
3787 * dbusbind.c (Fdbus_register_signal): When service is not
3788 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
3790 2011-09-25 Glenn Morris <rgm@gnu.org>
3792 * buffer.c (truncate-lines): Doc fix.
3794 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
3796 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
3797 (Fset_window_next_buffers): Doc fix.
3799 2011-09-24 Glenn Morris <rgm@gnu.org>
3801 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
3803 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
3805 Fix minor problems found by static checking.
3806 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
3807 * indent.c (Fvertical_motion): Fix == vs = typo.
3809 2011-09-24 Eli Zaretskii <eliz@gnu.org>
3811 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
3812 Default value is now t. Doc fix.
3814 * indent.c (Fvertical_motion): Compute and apply the overshoot
3815 logic when moving up, not only when moving down. Fix the
3816 confusing name and values of the it_overshoot_expected variable;
3817 logic changes accordingly. (Bug#9254) (Bug#9549)
3819 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
3820 CHARPOS is covered by a display string which includes newlines.
3821 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
3822 is covered by a display string with embedded newlines.
3824 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
3826 * dbusbind.c (Fdbus_register_signal): Add match rule to
3827 Vdbus_registered_objects_table. (Bug#9581)
3828 (Fdbus_register_method, Vdbus_registered_objects_table):
3831 2011-09-24 Jim Meyering <meyering@redhat.com>
3833 do not ignore write error for any output size
3834 The previous change was incomplete.
3835 While it makes emacs --batch detect the vast majority of stdout
3836 write failures, errors were still ignored whenever the output size is
3837 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
3838 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
3839 && echo FAIL: ignored write error
3840 FAIL: ignored write error
3841 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
3842 && echo FAIL: ignored write error
3843 FAIL: ignored write error
3844 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
3846 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
3848 * emacs.c (Fkill_emacs): In noninteractive mode exit
3849 non-successfully if a write error occurred on stdout. (Bug#9574)
3851 2011-09-21 Eli Zaretskii <eliz@gnu.org>
3853 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
3856 * dispextern.h (struct it): Update the comment documenting what
3859 2011-09-20 Eli Zaretskii <eliz@gnu.org>
3861 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
3862 a display string, extend search for cursor position to end of row.
3863 (find_row_edges): If the row ends in a newline from a display
3864 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
3865 Handle the case of a display string with multiple newlines.
3866 (Fcurrent_bidi_paragraph_direction): Fix search for previous
3867 non-empty line. Fixes confusing cursor motion with arrow keys at
3868 the beginning of a line that starts with whitespace.
3870 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3872 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
3875 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
3877 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
3880 2011-09-18 Eli Zaretskii <eliz@gnu.org>
3882 * xdisp.c (display_line): Record maximum and minimum buffer
3883 positions even if no glyphs were produced (e.g., by a zero-width
3884 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
3885 buffer positions that will be removed from the glyph row because
3887 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
3888 column is beyond frame width: don't subtract 1 "pixel" when
3889 computing width of the stretch.
3890 (reseat_at_next_visible_line_start): Undo the change made on
3891 2011-09-17 that saved paragraph information and restored it after
3892 the call to `reseat'. (Bug#9545)
3894 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3896 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
3897 and turn window cursor on if cleared (Bug#9415).
3899 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
3901 * search.c (boyer_moore): Take unibyte characters from pattern
3902 literally. (Bug#9458)
3904 2011-09-18 Eli Zaretskii <eliz@gnu.org>
3906 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
3908 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
3910 Fix minor problem found by static checking.
3911 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
3912 initialized, to pacify gcc -Wuninitialized.
3914 * fileio.c: Report proper errno when syscall falls.
3915 (Finsert_file_contents): Save and restore errno,
3916 so that report_file_error outputs the correct diagnostic.
3917 (Fwrite_region) [CLASH_DETECTION]: Likewise.
3919 2011-09-18 Eli Zaretskii <eliz@gnu.org>
3921 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
3923 2011-09-17 Eli Zaretskii <eliz@gnu.org>
3925 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
3926 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
3928 2011-09-17 Eli Zaretskii <eliz@gnu.org>
3930 * xdisp.c (reseat_at_next_visible_line_start): Keep information
3931 about the current paragraph and restore it after the call to reseat.
3933 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
3934 (bidi_find_paragraph_start): Search back for paragraph beginning
3935 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
3936 (bidi_move_to_visually_next): Only trigger paragraph-related
3937 computations when the last character is a newline or at EOB, not
3938 just any NEUTRAL_B. (Bug#9470)
3940 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
3941 truncated lines if point is covered by a display string. (Bug#9524)
3943 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
3945 * xselect.c: Relax test for outgoing X longs (Bug#9498).
3946 (cons_to_x_long): New function.
3947 (lisp_data_to_selection_data): Use it. Correct the test for
3948 short-versus-long data; it was negated. Break out of vector
3949 loop, for efficiency, when a long datum is discovered.
3951 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
3953 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
3955 2011-09-16 Eli Zaretskii <eliz@gnu.org>
3957 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
3958 GCC PR/17406) by declaring this function with external scope.
3960 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
3962 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
3963 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
3965 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
3967 * editfns.c (Fformat): Correctly handle text properties on "%%".
3969 2011-09-15 Eli Zaretskii <eliz@gnu.org>
3971 * xterm.c (x_draw_composite_glyph_string_foreground):
3972 * w32term.c (x_draw_composite_glyph_string_foreground):
3973 * term.c (encode_terminal_code):
3974 * composite.c (composition_update_it, get_composition_id):
3975 * xdisp.c (get_next_display_element)
3976 (fill_composite_glyph_string): Add comments about special meaning
3977 of TAB characters in a composition.
3979 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
3981 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
3982 This occurs when processing a multibyte format.
3983 Problem reported by Wolfgang Jenker.
3985 2011-09-15 Johan Bockgård <bojohan@gnu.org>
3987 * xdisp.c (try_cursor_movement): Only check for exact match if
3988 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
3990 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
3992 Remove unused external symbols.
3993 * dispextern.h (calc_pixel_width_or_height): Remove decl.
3994 * xdisp.c (calc_pixel_width_or_height): Now static.
3995 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
3996 * indent.c (check_display_width):
3997 * w32term.c: Fix comment to match code.
3998 * xterm.c, xterm.h (x_catching_errors): Remove.
4000 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4002 * xselect.c: Use signed conversions more consistently (Bug#9498).
4003 (selection_data_to_lisp_data): Assume incoming selection data are
4004 signed integers, not unsigned. This is to be consistent with
4005 outgoing selection data, which was modified to use signed integers
4006 in as part of the fix to Bug#9196 in response to Jan D.'s comment
4007 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
4008 expects long, not unsigned long.
4010 2011-09-14 Eli Zaretskii <eliz@gnu.org>
4012 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
4013 computation of loop end. Reported by Johan Bockgård
4016 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
4018 * frame.c (Fother_visible_frames_p): Function deleted.
4020 2011-09-12 Eli Zaretskii <eliz@gnu.org>
4022 * indent.c (compute_motion): Process display vector front to back
4023 rather than the other way around. (Bug#2496)
4025 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
4027 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
4029 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
4031 * minibuf.c (Fread_from_minibuffer): Doc fix.
4033 2011-09-11 Eli Zaretskii <eliz@gnu.org>
4035 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
4036 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
4038 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4040 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
4041 value for non-existent files.
4043 2011-09-11 Eli Zaretskii <eliz@gnu.org>
4045 * fileio.c (Finsert_file_contents): If the file cannot be opened,
4046 set its "size" to -1. This will set the modtime_size field of
4047 the corresponding buffer to -1, which is what
4048 verify-visited-file-modtime expects for files that do not exist.
4051 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
4053 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
4055 * lisp.h: ... from here. push_key_description is no longer
4056 defined in keyboard.c, so its declaration should not be in
4057 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
4058 logically belongs with push_key_description.
4060 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
4062 * buffer.h: Include <sys/types.h> instead of <time.h>.
4063 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
4064 Problem reported by Herbert J. Skuhra.
4066 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
4068 * xml.c (parse_region): Make the parsing work for
4069 non-comment-starting XML files again (bug#9144).
4071 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
4073 * image.c (gif_load): Fix calculation of bottom and right corner.
4076 2011-09-10 Eli Zaretskii <eliz@gnu.org>
4078 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
4079 redisplay in small windows.
4081 2011-09-09 Eli Zaretskii <eliz@gnu.org>
4083 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
4085 2011-09-08 Martin Rudalics <rudalics@gmx.at>
4087 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
4088 Operate on live windows only.
4090 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
4092 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
4094 2011-09-07 Eli Zaretskii <eliz@gnu.org>
4096 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
4097 only under bidi iteration.
4099 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
4101 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
4103 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4105 isnan: Fix porting problem to Solaris 10 with bundled gcc.
4106 Without this fix, the command to link temacs failed due to an
4107 undefined symbol __builtin_isnan. This is because
4108 /usr/include/iso/math_c99.h #defines isnan(x) to
4109 __builtin_isnan(x), but the bundled gcc, which identifies itself
4110 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
4112 * floatfns.c (isnan): #undef, and then #define to a clone of
4114 (Fisnan): Always define, since it's always available now.
4115 (syms_of_floatfns): Always define isnan at the Lisp level.
4117 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4119 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
4121 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4123 * fileio.c: Fix bugs with large file offsets (Bug#9428).
4124 The previous code assumed that file offsets (off_t values) fit in
4125 EMACS_INT variables, which is not true on typical 32-bit hosts.
4126 The code messed up by falsely reporting buffer overflow in cases
4127 such as (insert-file-contents "big" nil 1 2) into an empty buffer
4128 when "big" contains more than 2**29 bytes, even though this
4129 inserts just one byte and does not overflow the buffer.
4130 (Finsert_file_contents): Store file offsets as off_t
4131 values, not as EMACS_INT values. Check for overflow when
4132 converting between EMACS_INT and off_t. When checking for
4133 buffer overflow or for overlap, take the offsets into account.
4134 Don't use EMACS_INT for small values where int suffices.
4135 When checking for overlap, fix a typo: ZV was used where
4136 ZV_BYTE was intended.
4137 (Fwrite_region): Don't assume off_t fits into 'long'.
4138 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
4140 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
4142 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
4144 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4146 sprintf-related integer and memory overflow issues (Bug#9412).
4148 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
4149 (esprintf, exprintf, evxprintf): New functions.
4150 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
4151 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
4152 (modify_event_symbol): Do not assume that the length of
4153 name_alist_or_stem is safe to alloca and fits in int.
4154 (Fexecute_extended_command): Likewise for function name and binding.
4155 (Frecursion_depth): Wrap around reliably on integer overflow.
4156 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
4157 since some callers pass EMACS_INT values.
4158 (Fsingle_key_description): Don't crash if symbol name contains more
4159 than MAX_ALLOCA bytes.
4160 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
4161 (get_minibuffer): Arg is now EMACS_INT, not int.
4162 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
4163 (esprintf, exprintf, evxprintf): New decls.
4164 * window.h (command_loop_level, minibuf_level): Reflect API changes.
4166 * dbusbind.c (signature_cat): New function.
4167 (xd_signature, Fdbus_register_signal):
4168 Do not overrun buffer; instead, report string overflow.
4170 * dispnew.c (add_window_display_history): Don't overrun buffer.
4171 Truncate instead; this is OK since it's just a log.
4173 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
4174 even if the time zone offset is outlandishly large.
4175 Don't mishandle offset == INT_MIN.
4177 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
4178 when creating daemon; the previous buffer-overflow check was incorrect.
4180 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
4181 which has the guts of the old verror function.
4183 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
4184 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
4186 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
4187 (font_unparse_xlfd): Don't blindly alloca long strings.
4188 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
4189 fits in int, when using sprintf. Use single snprintf to count
4190 length of string rather than counting it via multiple sprintfs;
4191 that's simpler and more reliable.
4192 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
4193 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
4194 sprintf, in case result does not fit in int.
4196 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
4197 (fontset_from_font): Print it.
4199 * frame.c (tty_frame_count): Now printmax_t, not int.
4200 (make_terminal_frame, set_term_frame_name): Print it.
4201 (x_report_frame_params): In X, window IDs are unsigned long,
4202 not signed long, so print them as unsigned.
4203 (validate_x_resource_name): Check for implausibly long names,
4204 and don't assume name length fits in 'int'.
4205 (x_get_resource_string): Don't blindly alloca invocation name;
4206 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
4209 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
4210 (xg_check_special_colors, xg_set_geometry):
4211 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
4213 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
4214 Use esprintf, not sprintf, in case result does not fit in int.
4216 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4217 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
4218 it as a large positive number.
4219 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
4220 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4222 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
4223 in case result does not fit in int.
4225 * print.c (float_to_string): Detect width overflow more reliably.
4226 (print_object): Make sprintf buffer a bit bigger, to avoid potential
4227 buffer overrun. Don't assume list length fits in 'int'. Treat
4228 print length of 0 as 0, not as infinity; to be consistent with other
4229 uses of print length in this function. Don't overflow print length
4230 index. Don't assume hash table size fits in 'long', or that
4231 vectorlike size fits in 'unsigned long'.
4233 * process.c (make_process): Use printmax_t, not int, to format
4234 process-name gensyms.
4236 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
4238 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
4239 to avoid potential buffer overrun.
4241 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
4242 if X resource line is longer than 512 bytes.
4244 * xfns.c (x_window): Make sprintf buffer a bit bigger
4245 to avoid potential buffer overrun.
4247 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
4249 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
4251 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4253 Integer overflow fixes for scrolling, etc.
4254 Without these, Emacs silently mishandles large integers sometimes.
4255 For example, "C-u 4294967297 M-x recenter" was treated as if
4256 it were "C-u 1 M-x recenter" on a typical 64-bit host.
4258 * xdisp.c (try_window_id): Check Emacs fixnum range before
4259 converting to 'int'.
4261 * window.c (window_scroll_line_based, Frecenter):
4262 Check that an Emacs fixnum is in range before assigning it to 'int'.
4263 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
4264 values converted from Emacs fixnums.
4265 (Frecenter): Don't wrap around a line count if it is out of 'int'
4266 range; instead, treat it as an extreme value.
4267 (Fset_window_configuration, compare_window_configurations):
4268 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
4270 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
4271 that can exceed INT_MAX. Check that EMACS_INT value is in range
4272 before assigning it to the (possibly-narrower) index.
4273 (match_limit): Don't assume that a fixnum can fit in 'int'.
4275 * print.c (print_object): Use ptrdiff_t, not int, for index that can
4278 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
4279 (Fvertical_motion): Don't wrap around LINES values that don't fit
4280 in 'int'. Instead, treat them as extreme values. This is good
4281 enough for windows, which can't have more than INT_MAX lines anyway.
4283 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4285 * Require libxml/parser.h to avoid compilation warning.
4287 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
4289 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
4290 since this reportedly can destroy thread storage.
4292 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
4294 * syntax.c (find_defun_start): Update all cache variables if
4295 exiting early (Bug#9401).
4297 2011-08-30 Eli Zaretskii <eliz@gnu.org>
4299 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
4301 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
4302 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
4303 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
4305 * term.c (tty_append_glyph): New function.
4306 (produce_stretch_glyph): Static function and its prototype deleted.
4308 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
4311 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
4313 * image.c (parse_image_spec): Check for nonnegative, not for positive,
4314 when checking :margin (Bug#9390).
4315 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
4316 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
4317 so that the name doesn't mislead. All uses changed.
4319 2011-08-28 Johan Bockgård <bojohan@gnu.org>
4321 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
4324 2011-08-27 Eli Zaretskii <eliz@gnu.org>
4326 * xdisp.c (move_it_to): Don't bail out early when reaching
4327 position beyond to_charpos, if we are scanning backwards.
4328 (move_it_vertically_backward): When DY == 0, make sure we get to
4329 the first character in the line after the newline.
4331 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
4333 * ccl.c: Improve and simplify overflow checking (Bug#9196).
4334 (ccl_driver): Do not generate an out-of-range pointer.
4335 (Fccl_execute_on_string): Remove unnecessary check for
4336 integer overflow, noted by Stefan Monnier in
4337 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
4338 Remove a FIXME that didn't need fixing.
4339 Simplify the newly-introduced buffer reallocation code.
4341 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
4343 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
4345 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
4347 Integer and memory overflow issues (Bug#9196).
4349 * doc.c (get_doc_string): Rework so that
4350 get_doc_string_buffer_size is the actual buffer size, rather than
4351 being 1 less than the actual buffer size; this makes xpalloc more
4354 * image.c (x_allocate_bitmap_record, cache_image):
4355 * xselect.c (Fx_register_dnd_atom):
4356 Simplify previous changes by using xpalloc.
4358 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
4359 since either will do and ptrdiff_t is convenient with xpalloc.
4361 * charset.c (charset_table_size)
4362 (struct charset_sort_data.priority): Now ptrdiff_t.
4363 (charset_compare): Don't overflow if priorities differ greatly.
4364 (Fsort_charsets): Don't assume list length fits in int.
4365 Check for size-calculation overflow when allocating sort data.
4366 (syms_of_charset): Allocate an initial charset table that is
4367 just under 64 KiB, to avoid problems with glibc malloc and mmap.
4369 * cmds.c (internal_self_insert): Check for size-calculation overflow.
4371 * composite.h (struct composition.glyph_len): Now int, not unsigned.
4372 The actual value is always <= INT_MAX, and leaving it unsigned made
4373 overflow checking harder.
4375 * dispextern.h (struct glyph_matrix.rows_allocated)
4376 (struct face_cache.size): Now ptrdiff_t, for convenience in use
4377 with xpalloc. The values are still always <= INT_MAX.
4379 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
4381 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
4382 (SAFE_NALLOCA): New macro.
4384 * region-cache.c (struct boundary.pos, find_cache_boundary)
4385 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
4386 (set_cache_region, invalidate_region_cache)
4387 (revalidate_region_cache, know_region_cache, region_cache_forward)
4388 (region_cache_backward, pp_cache):
4389 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
4390 so that ptrdiff_t * can be passed to xpalloc.
4391 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
4392 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
4393 (pp_cache): Don't assume cache_len fits in int.
4394 * region-cache.h: Adjust extern decls to match.
4396 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
4397 EMACS_INT, since either will do, for xpalloc.
4399 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
4400 (xnmalloc, xnrealloc, xpalloc): New functions.
4402 * bidi.c (bidi_shelve_header_size): New constant.
4403 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
4404 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
4406 * bidi.c (bidi_cache_shrink):
4407 * buffer.c (overlays_at, overlays_in, record_overlay_string)
4409 Don't update size of array until after memory allocation succeeds,
4410 because xmalloc/xrealloc may not return.
4411 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
4412 now that we have proper integer overflow checking.
4413 (record_overlay_string, overlay_strings): Catch overflows when
4414 calculating size of overlay_str_buf.
4416 * callproc.c (Fcall_process): Check for size overflow when
4417 calculating size of args2.
4418 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
4419 Normally we prefer signed values, but sticking with ptrdiff_t would
4420 require adding more-complicated checks.
4422 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
4423 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
4424 Redo buffer-overflow calculations to avoid integer overflow.
4425 Add a FIXME comment where memory seems to be over-allocated.
4427 * character.c (Fstring): Check for size-calculation overflow.
4429 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
4430 unnecessary integer overflow. Check for size overflow.
4431 (encode_coding_object): Don't update size until xmalloc succeeds.
4433 * composite.c (get_composition_id): Check for overflow in glyph
4434 length calculations.
4436 Integer and memory overflow fixes for display code.
4437 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
4438 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
4439 (scrolling_window): Check for overflow in size calculations.
4440 (line_draw_cost, realloc_glyph_pool, add_row_entry):
4441 Don't assume glyph table len fits in int.
4442 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
4443 (row_table_size): Now ptrdiff_t, not int.
4444 (scrolling_window): Avoid overflow in size calculations.
4445 Don't update size until allocation succeeds.
4446 * fns.c (concat): Check for overflow in size calculations.
4447 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
4448 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4449 (NEXT_ALMOST_PRIME_LIMIT): New constant.
4451 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
4452 (get_doc_string): Check for size calculation overflow.
4453 Don't update size until allocation succeeds.
4454 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
4455 EMACS_INT, where ptrdiff_t will do.
4456 (Fsubstitute_command_keys): Check for string overflow.
4458 * editfns.c (set_time_zone_rule): Don't assume environment length
4460 (message_length): Now ptrdiff_t, not int.
4461 (Fmessage_box): Don't update size until allocation succeeds.
4462 Don't assume message length fits in int.
4463 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
4465 * emacs.c (main): Do not reallocate argv, since there is a null at
4466 the end that can be overwritten, and this way there's no need to
4467 worry about size-calculation overflow.
4468 (sort_args): Check for size-calculation overflow.
4470 * eval.c (init_eval_once, grow_specpdl): Don't update size until
4472 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
4474 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
4475 (x_set_scroll_bar_width, x_figure_window_size):
4476 Check for integer overflow.
4477 (x_set_alpha): Do not assume XINT fits in int.
4479 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
4480 This is for the members text_lines, text_cols, total_lines, total_cols,
4481 where the system imposes an 'int' limit.
4483 * fringe.c (Fdefine_fringe_bitmap):
4484 Don't update size until alloc works.
4486 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
4487 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
4489 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
4490 Check for size-calculation overflow.
4491 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
4492 do, as we prefer signed integers.
4493 (id_to_widget.max_size, id_to_widget.used)
4494 (xg_store_widget_in_map, xg_remove_widget_from_map)
4495 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
4496 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
4497 Use and return ptrdiff_t, not int.
4498 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
4499 * gtkutil.h: Change prototypes to match the above.
4501 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
4502 are duplicate now that they've been promoted to lisp.h.
4503 (x_allocate_bitmap_record, x_alloc_image_color)
4504 (make_image_cache, cache_image, xpm_load):
4505 Don't update size until alloc is done.
4506 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
4508 Check for size calculation overflow.
4509 (ct_colors_allocated_max): New constant.
4510 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
4513 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
4514 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
4515 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
4516 Use ptrdiff_t, not int, to count maps.
4517 (read_char_minibuf_menu_prompt): Check for overflow in size
4518 calculations. Don't update size until allocation succeeds.
4519 Redo calculations to avoid overflow.
4520 * keyboard.h: Change prototypes to match the above.
4522 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
4524 (current_minor_maps): Check for size calculation overflow.
4525 * keymap.h: Change prototypes to match the above.
4527 * lread.c (read1, init_obarray): Don't update size until alloc done.
4529 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
4530 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
4532 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
4533 Now ptrdiff_t, not int.
4534 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
4535 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
4537 * process.c (Fnetwork_interface_list): Check for overflow
4538 in size calculation.
4540 * region-cache.c (move_cache_gap): Check for size calculation overflow.
4542 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
4543 overflow. Don't bother calling xmalloc when xrealloc will do.
4545 * search.c (Freplace_match): Check for size calculation overflow.
4546 (Fset_match_data): Don't assume list lengths fit in 'int'.
4548 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
4549 for command line length. Do not attempt to address one before the
4550 beginning of an array, as that's not portable.
4552 * term.c (max_frame_lines): Remove; unused.
4553 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
4555 (encode_terminal_code, calculate_costs): Check for size
4556 calculation overflow.
4557 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
4558 table lengths and related sizes. Don't update size until alloc
4559 done. Redo calculations to avoid overflow.
4560 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
4562 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
4563 subtracting pointers.
4564 (gobble_line): Check for overflow more carefully. Don't update size
4567 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
4568 Don't update size until alloc done.
4569 Redo size calculations to avoid overflow.
4570 Check for size calculation overflow.
4571 (main) [DEBUG]: Fix typo in invoking tparam1.
4573 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
4574 Use ptrdiff_t, not int, for sizes.
4575 (store_mode_line_noprop_char): Don't update size until alloc done.
4577 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
4578 Use ptrdiff_t, not int, for sizes.
4579 (Finternal_make_lisp_face, cache_face):
4580 Check for size calculation overflow.
4581 (cache_face): Treat size calculation overflows as if they were
4582 memory exhaustion (the usual treatment), rather than aborting.
4584 * xfns.c (x_encode_text, x_set_name_internal)
4585 (Fx_change_window_property): Use ptrdiff_t, not int, to count
4586 sizes, since they can exceed INT_MAX in size. Check for size
4587 calculation overflow.
4589 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
4590 (xg_select): Check for size calculation overflow.
4591 Don't update size until alloc done.
4593 * xrdb.c (get_environ_db): Don't assume path length fits in int,
4594 as sprintf is limited to int lengths.
4596 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
4597 (X_LONG_MIN): New macros.
4598 Use them to make the following changes clearer.
4599 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
4600 This change doesn't affect the value now, but it may help remind
4601 future maintainers not to raise the value too much later.
4602 (SELECTION_QUANTUM): Remove, replacing with ...
4603 (selection_quantum): ... new function, which avoids overflow.
4605 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
4606 assumption that selection length fits in 'int'.
4607 (x_reply_selection_request, x_handle_selection_request)
4608 (x_get_window_property, receive_incremental_selection)
4609 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
4610 (lisp_data_to_selection_data, clean_local_selection_data):
4611 Use ptrdiff_t, not int, to record length of selection.
4612 (x_reply_selection_request, x_get_window_property)
4613 (receive_incremental_selection, x_property_data_to_lisp):
4614 Redo calculations to avoid overflow.
4615 (x_reply_selection_request): When sending hint, ceiling it at
4616 X_LONG_MAX rather than relying on wraparound overflow to send
4618 (x_get_window_property, receive_incremental_selection)
4619 (lisp_data_to_selection_data, x_property_data_to_lisp):
4620 Check for size-calculation overflow.
4621 (x_get_window_property, receive_incremental_selection)
4622 (lisp_data_to_selection_data, Fx_register_dnd_atom):
4623 Don't store size until memory allocation succeeds.
4624 (x_get_window_property): Plug memory leak on memory exhaustion.
4625 Don't double-block input; malloc is safe here. Don't assume 2**34
4626 - 4 fits in unsigned long. Add an xassert to check
4627 XGetWindowProperty overflow. Be more careful about overflow
4628 calculations, and distinguish size from memory overflow better.
4629 (receive_incremental_selection): When tracing, don't assume
4630 unsigned int is less than INT_MAX.
4631 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
4632 harmful) conversions of unsigned short to int.
4633 (lisp_data_to_selection_data): Don't assume that integers
4634 in the range -65535 through -1 fit in an X unsigned short.
4635 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
4636 result parameters unless successful. Rely on cons_to_unsigned
4637 to report problems with elements; the old code wasn't right anyway.
4638 (x_check_property_data): Check for int overflow; we cannot use
4639 a wider type due to X limits.
4640 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
4642 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
4644 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
4645 (x_term_init): Check for size calculation overflow.
4646 (x_color_cells): Don't store size until memory allocation succeeds.
4647 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
4648 Don't assume alloca size is less than MAX_ALLOCA.
4649 (x_term_init): Don't assume length fits in int (sprintf is limited
4652 Use ptrdiff_t for composition IDs.
4653 * character.c (lisp_string_width):
4654 * composite.c (composition_table_size, n_compositions)
4655 (get_composition_id, composition_gstring_from_id):
4656 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
4657 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
4658 * window.c (Frecenter):
4659 Use ptrdiff_t, not int, for composition IDs.
4660 * composite.c (get_composition_id): Check for integer overflow.
4661 * composite.h: Adjust prototypes to match the above changes.
4663 Use ptrdiff_t for hash table indexes.
4664 * category.c (hash_get_category_set):
4665 * ccl.c (ccl_driver):
4666 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
4667 * coding.c (coding_system_charset_list, detect_coding_system):
4668 * coding.h (struct coding_system.id):
4669 * composite.c (get_composition_id, gstring_lookup_cache):
4670 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
4671 * image.c (xpm_get_color_table_h):
4672 * lisp.h (hash_lookup, hash_put):
4673 * minibuf.c (Ftest_completion):
4674 Use ptrdiff_t for hash table indexes, not int (which is too
4675 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
4676 32-bit --with-wide-int hosts).
4678 * charset.c (Fdefine_charset_internal): Check for integer overflow.
4679 Add a FIXME comment about memory leaks.
4680 (syms_of_charset): Don't assume xmalloc returns.
4682 Don't assume that stated character widths fit in int.
4683 * character.c (Fchar_width, c_string_width, lisp_string_width):
4684 * character.h (CHAR_WIDTH):
4685 * indent.c (MULTIBYTE_BYTES_WIDTH):
4686 Use sanitize_char_width to avoid undefined and/or bad behavior
4687 with outlandish widths.
4688 * character.h (sanitize_tab_width): Rename from sanitize_width,
4689 now that we have two such functions. All uses changed.
4690 (sanitize_char_width): New inline function.
4692 Don't assume that tab-width fits in int.
4693 * character.h (sanitize_width): New inline function.
4694 (SANE_TAB_WIDTH): New macro.
4695 (ASCII_CHAR_WIDTH): Use it.
4696 * indent.c (sane_tab_width): Remove. All uses replaced by
4697 SANE_TAB_WIDTH (current_buffer).
4698 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
4700 * fileio.c: Integer overflow issues with file modes.
4701 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
4703 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
4704 Remove unreachable code.
4705 (read_hex, load_charset_map_from_file): Check for integer overflow.
4707 * xterm.c: Don't go over XClientMessageEvent limit.
4708 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
4709 (x_send_scroll_bar_event): Likewise. Check that the size does not
4710 exceed limits imposed by XClientMessageEvent, as well as the usual
4711 ptrdiff_t and size_t limits.
4713 * keyboard.c: Overflow, signedness and related fixes.
4714 (make_lispy_movement): Use same integer type in forward decl
4715 that is used in the definition.
4716 (read_key_sequence, keyremap_step):
4717 Change bufsize argument back to int, undoing my 2011-03-30 change.
4718 We prefer signed types, and int is wide enough here.
4719 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
4720 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
4721 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
4722 length, not size_t. Use ptrdiff_t for index, not int.
4723 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
4724 possibility of integer overflow.
4726 Overflow, signedness and related fixes for images.
4728 * dispextern.h (struct it.stack[0].u.image.image_id)
4729 (struct_it.image_id, struct image.id, struct image_cache.size)
4730 (struct image_cache.used, struct image_cache.ref_count):
4731 * gtkutil.c (update_frame_tool_bar):
4732 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
4733 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
4734 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
4735 * nsmenu.m (update_frame_tool_bar):
4736 * xdisp.c (calc_pixel_width_or_height):
4737 * xfns.c (image_cache_refcount):
4738 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
4739 on typical 64-bit hosts.
4741 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4742 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
4743 Omit unnecessary casts to int.
4744 (parse_image_spec): Check that integers fall into 'int' range
4745 when the callers expect that.
4746 (image_ascent): Redo ascent calculation to avoid int overflow.
4747 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
4748 (lookup_image): Remove unnecessary tests.
4749 (xbm_image_p): Locals are now of int, not EMACS_INT,
4750 since parse_image_check makes sure they fit into int.
4751 (png_load, gif_load, svg_load_image):
4752 Prefer int to unsigned where either will do.
4753 (tiff_handler): New function, combining the cores of the
4754 old tiff_error_handler and tiff_warning_handler.
4755 This function is rewritten to use vsnprintf and thereby avoid
4756 stack buffer overflows. It uses only the features of vsnprintf
4757 that are common to both POSIX and native Microsoft.
4758 (tiff_error_handler, tiff_warning_handler): Use it.
4759 (tiff_load, gif_load, imagemagick_load_image):
4760 Don't assume :index value fits in 'int'.
4761 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
4762 (imagemagick_load_image): Check that crop parameters fit into
4763 the integer types that MagickCropImage accepts. Don't assume
4764 Vimagemagick_render_type has a nonnegative value. Don't assume
4765 size_t fits in 'long'.
4766 (gs_load): Use printmax_t to print the widest integers possible.
4767 Check for integer overflow when computing image height and width.
4769 2011-08-26 Eli Zaretskii <eliz@gnu.org>
4771 * xdisp.c (redisplay_window): Don't force window start if point
4772 will be invisible in the resulting window. (Bug#9324)
4774 2011-08-25 Eli Zaretskii <eliz@gnu.org>
4776 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
4777 the display spec is of the form `(space ...)'.
4778 (handle_display_spec): Return the value returned by
4779 handle_single_display_spec, not just 1 or zero.
4780 (handle_single_display_spec): If the display spec is of the form
4781 `(space ...)', and specifies display in the text area, return 2
4783 (try_cursor_movement): Check for the need to scroll more
4784 accurately, and prefer exact match for point under bidi.
4785 Don't advance `row' beyond the last row of the window.
4787 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
4788 into disp_prop; all users changed.
4790 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
4791 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
4792 for the text covered by the display property.
4794 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
4796 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
4797 Change return value to nil.
4798 (Frecord_buffer): Delete unused function.
4800 2011-08-24 Eli Zaretskii <eliz@gnu.org>
4802 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
4803 buffers, return left-to-right.
4804 (set_cursor_from_row): Consider candidate row a win if its glyph
4805 represents a newline and point is on that newline. Fixes cursor
4806 positioning on the newline at EOL of R2L text within L2R
4807 paragraph, and vice versa.
4808 (try_cursor_movement): Check continued rows, in addition to
4809 continuation rows. Fixes unwarranted scroll when point enters a
4810 continued line of R2L text within an L2R paragraph, or vice versa.
4811 (cursor_row_p): Consider the case of point being equal to
4812 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
4813 from the end of a short line to the beginning of a continued line
4814 of R2L text within L2R paragraph.
4815 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
4816 composed characters.
4818 * bidi.c (bidi_check_type): Use xassert.
4819 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
4822 2011-08-23 Eli Zaretskii <eliz@gnu.org>
4824 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
4827 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
4829 * nsfont.m (ns_otf_to_script): Fix typo.
4831 2011-08-22 Kenichi Handa <handa@m17n.org>
4833 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
4834 extra slot even if the purpose is char-code-property-table.
4836 2011-08-23 Eli Zaretskii <eliz@gnu.org>
4838 * xdisp.c (redisplay_window): When computing centering_position,
4839 account for the height of the header line. (Bug#8874)
4841 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
4842 instead of CHAR_TO_BYTE. Fixes a crash when a completion
4843 candidate is selected by the mouse, and that candidate has a
4844 composed character under the mouse.
4846 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
4847 coordinates reported by pos-visible-in-window-p for a composed
4848 character in column zero.
4850 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
4852 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
4854 2011-08-22 Eli Zaretskii <eliz@gnu.org>
4856 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
4857 consider it a hit if to_charpos is anywhere in the range of the
4858 composed buffer positions.
4860 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
4862 * image.c (gif_load): Don't assume that each subimage has the same
4863 dimensions as the base image. Handle disposal method that is
4864 "undefined" by the gif spec (Bug#9335).
4866 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
4868 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
4869 (Fcondition_case): Document `debug' symbol in error handler.
4871 2011-08-19 Eli Zaretskii <eliz@gnu.org>
4873 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
4874 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
4875 from an Org mode buffer to a Speedbar frame.
4877 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
4878 a composition, take its buffer position from IT->cmp_it.charpos.
4879 Fixes cursor positioning at the beginning of a line that begins
4880 with a composed character.
4882 2011-08-18 Eli Zaretskii <eliz@gnu.org>
4884 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
4885 character bidirectional type, use STRONG_L instead. Fixes crashes
4886 in a buffer produced by `describe-categories'.
4888 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
4889 members before the level stack, so they would be saved and
4890 restored when copying iterator state. Fixes incorrect reordering
4891 around TABs covered by display properties.
4893 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
4895 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
4897 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
4899 * eval.c (internal_condition_case, internal_condition_case_1)
4900 (internal_condition_case_2, internal_condition_case_n):
4901 Remove unnecessary aborts (Bug#9081).
4903 2011-08-17 Eli Zaretskii <eliz@gnu.org>
4905 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
4906 has no `load' handler, try opening the file locally. (Bug#9311)
4908 2011-08-16 Ken Brown <kbrown@cornell.edu>
4910 * gmalloc.c: Expand comment.
4912 2011-08-16 Eli Zaretskii <eliz@gnu.org>
4914 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
4915 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
4917 2011-08-16 Ken Brown <kbrown@cornell.edu>
4919 Fix memory allocation problems in Cygwin build (Bug#9273).
4921 * unexcw.c ( __malloc_initialized): Declare external variable.
4922 (fixup_executable): Force the dumped emacs to reinitialize malloc.
4924 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
4926 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
4928 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
4930 [CYGWIN] (special_realloc): New function.
4931 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
4932 requests to realloc storage in the static heap.
4934 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
4936 * bidi.c (bidi_initialize): Remove unused local.
4938 2011-08-15 Eli Zaretskii <eliz@gnu.org>
4941 * biditype.h: Remove file.
4942 * makefile.w32-in ($(BLD)/bidi.$(O)):
4943 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
4945 * dispextern.h: Fix a typo in the comment to bidi_type_t.
4947 * chartab.c: Improve commentary for the uniprop_table API.
4949 * bidi.c (bidi_paragraph_init): Support zero value of
4950 bidi_ignore_explicit_marks_for_paragraph_level.
4951 (bidi_initialize): Use uniprop_table instead of including
4952 biditype.h and bidimirror.h.
4954 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
4955 coordinates of the iterator when restoring from ppos_it.
4958 2011-08-14 Kenichi Handa <handa@m17n.org>
4960 * process.c (create_process): Call setup_process_coding_systems
4961 after the pid of the process is set to -1 (Bug#8162).
4963 2011-08-14 Eli Zaretskii <eliz@gnu.org>
4965 * xdisp.c (move_it_in_display_line_to): Don't invoke
4966 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
4967 ppos_it. Fixes vertical cursor motion when line beginning is
4968 covered by an image. (Bug#9296)
4970 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
4972 * nsterm.h (ns_run_ascript): Declare.
4973 (NSAPP_DATA2_RUNASSCRIPT): Define.
4975 * nsfns.m (as_script, as_result, as_status): New static variables.
4976 (ns_run_ascript): New function.
4977 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
4978 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
4979 the event loop. Get status from as_status (Bug#7276).
4981 * nsterm.m (sendEvent): If event is NSApplicationDefined and
4982 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
4983 the event loop (Bug#7276).
4985 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
4987 * gnutls.c (QCgnutls_bootprop_priority)
4988 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
4989 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
4990 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
4991 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
4992 (QCgnutls_bootprop_verify_hostname_error)
4993 (QCgnutls_bootprop_callbacks_verify): Rename from
4994 Qgnutls_bootprop_..., all uses changed.
4996 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
4999 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
5001 * xfaces.c (Qframe_set_background_mode): Now static.
5002 * dispextern.h (Qframe_set_background_mode): Remove decl.
5004 * process.c (Fnetwork_interface_info): Declare local only if needed.
5006 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
5008 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
5009 (Fnetwork_interface_list): Allocate in increments of bytes instead
5010 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
5011 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
5013 (struct ifflag_def): notrailers is smart on OSX.
5014 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
5015 Get hardware address with getifaddrs if available.
5017 2011-08-12 Eli Zaretskii <eliz@gnu.org>
5019 * xdisp.c (iterate_out_of_display_property): xassert that
5020 IT->position is set to within IT->object's boundaries. Break from
5021 the loop as soon as EOB is reached; avoids infloops in redisplay
5022 when IT->position is set up wrongly due to some bug.
5023 Set IT->current to match the bidi iterator unconditionally.
5024 (push_display_prop): Allow GET_FROM_STRING as IT->method on
5025 entry. Force push_it to save on the stack the current
5026 buffer/string position, to be restored by pop_it. Fix flags in
5027 the iterator structure wrt the object coming from a display
5028 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
5029 properties. (Bug#9284)
5031 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
5033 * fontset.c (fontset_get_font_group): Add proper type checks.
5036 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5038 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
5039 and LC_VERSION_MIN_MACOSX.
5040 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
5041 (dump_it) [LC_FUNCTION_STARTS]: Use it.
5043 2011-08-08 Eli Zaretskii <eliz@gnu.org>
5045 * xdisp.c (forward_to_next_line_start): Allow to use the
5046 no-display-properties-and-no-overlays under bidi display.
5047 Set disp_pos in the bidi iterator to avoid searches for display
5048 properties and overlays.
5050 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
5052 * editfns.c (Fset_time_zone_rule): Document relationship with the
5055 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
5056 the font entity extracted from the cache (Bug#8109).
5058 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
5060 * composite.c (autocmp_chars): Don't reset point. That is done by
5061 restore_point_unwind (Bug#5984).
5063 2011-08-07 Juri Linkov <juri@jurta.org>
5065 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
5066 to show the arg `TIME' instead of `TIMEVAL'.
5068 2011-08-06 Eli Zaretskii <eliz@gnu.org>
5070 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
5071 display property strides EOL and includes a newline, as in
5072 longlines-mode. (Bug#9254)
5073 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
5074 word-wrap under bidirectional display. (Bug#9224)
5076 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
5077 is non-zero, even if the data buffer is NULL. Fixes a crash in
5078 vertical-motion with longlines-mode. (Bug#9254)
5080 2011-08-05 Eli Zaretskii <eliz@gnu.org>
5082 * bidi.c <bidi_cache_total_alloc>: Now static.
5083 (bidi_initialize): Initialize bidi_cache_total_alloc.
5085 * xdisp.c (display_line): Release buffer allocated for shelved bidi
5088 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
5089 amount allocated this far in `bidi_cache_total_alloc'.
5090 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
5091 non-zero, only free the data buffer without restoring the cache
5092 contents. All callers changed.
5094 * dispextern.h (bidi_unshelve_cache): Update prototype.
5096 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
5097 (move_it_in_display_line, move_it_to)
5098 (move_it_vertically_backward, move_it_by_lines): Replace the call
5099 to xfree to an equivalent call to bidi_unshelve_cache.
5100 (move_it_in_display_line_to): Fix logic of returning
5101 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
5103 2011-08-05 Eli Zaretskii <eliz@gnu.org>
5105 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
5106 came from a string character with a `cursor' property. (Bug#9229)
5108 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5110 * Makefile.in (LIB_PTHREAD): New variable.
5111 (LIBES): Add LIB_PTHREAD (Bug#9216).
5113 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
5114 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
5116 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
5118 * regex.c (re_iswctype): Remove some redundant boolean conversions.
5120 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5122 * xterm.c (x_find_topmost_parent): New function.
5123 (x_set_frame_alpha): Find topmost parent window with
5124 x_find_topmost_parent and set the property there also (bug#9181).
5125 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
5127 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
5129 * callproc.c (Fcall_process): Avoid vfork clobbering
5130 the local vars buffer, coding_systems, current_dir.
5132 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
5134 * keymap.c (Fmake_composed_keymap): Move to subr.el.
5136 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
5138 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
5139 so that it is not optimized away.
5141 * xdisp.c (compute_display_string_pos): Remove unused local.
5143 2011-08-02 Eli Zaretskii <eliz@gnu.org>
5145 Fix slow cursor motion and scrolling in large buffers with
5146 selective display, like Org Mode buffers. (Bug#9218)
5148 * dispextern.h (struct bidi_it): New member disp_prop_p.
5150 * xdisp.c: Remove one-slot cache of display string positions.
5151 (compute_display_string_pos): Accept an additional argument
5152 DISP_PROP_P; callers changed. Scan at most 5K characters forward
5153 for a display string or property. If found, set DISP_PROP_P
5156 * bidi.c (bidi_fetch_char): Accept an additional argument
5157 DISP_PROP_P, and pass it to compute_display_string_pos.
5158 Only handle text covered by a display string if DISP_PROP_P is returned
5159 non-zero. All callers of bidi_fetch_char changed.
5161 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
5163 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
5165 2010-12-03 Don March <don@ohspite.net>
5167 * keymap.c (Fdefine_key): Fix non-prefix key error message when
5168 last character M-[char] is translated to ESC [char] (bug#7541).
5170 2011-08-02 Kenichi Handa <handa@m17n.org>
5172 * lisp.h (uniprop_table): Extern it.
5174 * chartab.c (uniprop_table): Make it non-static.
5176 2011-08-01 Eli Zaretskii <eliz@gnu.org>
5178 * xdisp.c (forward_to_next_line_start): Accept additional argument
5179 BIDI_IT_PREV, and store into it the state of the bidi iterator had
5181 (reseat_at_next_visible_line_start): Use the bidi iterator state
5182 returned by forward_to_next_line_start to restore the state of
5183 it->bidi_it after backing up to previous newline. (Bug#9212)
5185 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
5187 * regex.c (re_comp): Protoize.
5188 (re_exec): Fix return type.
5189 (regexec): Fix type of `ret'. (Bug#9203)
5191 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5193 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
5194 This is needed if max-image-size is a floating-point number.
5196 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5198 * print.c (print_object): Print empty symbol as ##.
5200 * lread.c (read1): Read ## as empty symbol.
5202 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5204 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
5205 setting frame foreground color (Bug#9175).
5206 (x_set_background_color): Likewise.
5208 * nsmenu.m (-setText): Size tooltip dimensions precisely to
5209 contents (Bug#9176).
5210 (EmacsTooltip -init): Remove bezels and add shadows to
5213 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
5214 or scroll bar (Bug#8470).
5216 * nsfont.m (nsfont_open): Remove assignment to voffset and
5217 unnecessary vars hshink, expand, hd, full_height, min_height.
5218 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
5220 * nsterm.h (nsfont_info): Remove voffset field.
5222 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5224 Implement strike-through and overline on NextStep (Bug#8863).
5226 * nsfont.m (nsfont_open): Use underline position provided by font,
5227 instead of hard-coded value of 2.
5228 (nsfont_draw): Call ns_draw_text_decoration instead.
5230 * nsterm.h: Add declaration for ns_draw_text_decoration.
5232 * nsterm.m (ns_draw_text_decoration): New function for drawing
5233 underline, overline, and strike-through.
5234 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
5235 ns_draw_text_decoration. Change treatment of cursor drawing to
5236 accommodate underlining, etc.
5238 2011-07-28 Eli Zaretskii <eliz@gnu.org>
5240 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
5243 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5245 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
5246 Without this fix, if a signal arrives just after memory fills up,
5247 'malloc' might be invoked reentrantly.
5249 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
5250 In other words, assume that every image size is allowed, on non-X
5251 hosts. This assumption is probably wrong, but it lets Emacs compile.
5253 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5255 * regex.c (re_iswctype): Convert return values to boolean.
5257 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
5259 * xdisp.c (compute_display_string_pos): Don't use cached display
5260 string position if the buffer had its restriction changed.
5263 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5265 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5267 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5269 Integer signedness and overflow and related fixes. (Bug#9079)
5271 * bidi.c: Integer size and overflow fixes.
5272 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
5273 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
5274 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5275 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
5276 (bidi_find_other_level_edge):
5277 Use ptrdiff_t instead of EMACS_INT where either will do.
5278 This works better on 32-bit hosts configured --with-wide-int.
5279 (bidi_cache_ensure_space): Check for size-calculation overflow.
5280 Use % rather than repeated addition, for better worst-case speed.
5281 Don't set bidi_cache_size until after xrealloc returns, because it
5283 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
5284 (bidi_cache_ensure_space): Also check that the bidi cache size
5285 does not exceed that of the largest Lisp string or buffer. See Eli
5286 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
5288 * alloc.c (__malloc_size_t): Remove.
5289 All uses replaced by size_t. See Andreas Schwab's note
5290 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
5292 * image.c: Improve checking for integer overflow.
5293 (check_image_size): Assume that f is nonnull, since
5294 it is always nonnull in practice. This is one less thing to
5295 worry about when checking for integer overflow later.
5296 (x_check_image_size): New function, which checks for integer
5297 overflow issues inside X.
5298 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
5299 This removes the need for a memory_full check.
5300 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
5301 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
5302 (xbm_read_bitmap_data): Change locals back to 'int', since
5303 their values must fit in 'int'.
5304 (xpm_load_image, png_load, tiff_load):
5305 Invoke x_create_x_image_and_pixmap earlier,
5306 to avoid much needless work if the image is too large.
5307 (tiff_load): Treat overly large images as if
5308 x_create_x_image_and_pixmap failed, not as malloc failures.
5309 (gs_load): Use x_check_image_size.
5311 * gtkutil.c: Omit integer casts.
5312 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
5313 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
5315 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
5317 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
5318 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
5319 would wrongly return t on a 64-bit host.
5321 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
5322 The plain *_OVERFLOW macros run afoul of GCC bug 49705
5323 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
5324 and therefore cause GCC to emit a bogus diagnostic in some cases.
5326 * image.c: Integer signedness and overflow and related fixes.
5327 This is not an exhaustive set of fixes, but it's time to
5328 record what I've got.
5329 (lookup_pixel_color, check_image_size): Remove redundant decls.
5330 (check_image_size): Don't assume that arbitrary EMACS_INT values
5331 fit in 'int', or that arbitrary 'double' values fit in 'int'.
5332 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
5333 (tiff_load, imagemagick_load_image):
5334 Check for overflow in size calculations.
5335 (x_create_x_image_and_pixmap): Remove unnecessary test for
5336 xmalloc returning NULL; that can't happen.
5337 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
5338 (xpm_color_bucket): Use better integer hashing function.
5339 (xpm_cache_color): Don't possibly over-allocate memory.
5340 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
5341 (gif_memory_source):
5342 Use ptrdiff_t, not int or size_t, to record sizes.
5343 (png_load): Don't assume values greater than 2**31 fit in 'int'.
5344 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
5345 either works, as we prefer signed integers.
5346 (tiff_read_from_memory, tiff_write_from_memory):
5347 Return tsize_t, not size_t, since that's what the TIFF API wants.
5348 (tiff_read_from_memory): Don't fail simply because the read would
5349 go past EOF; instead, return a short read.
5350 (tiff_load): Omit no-longer-needed casts.
5351 (Fimagemagick_types): Don't assume size fits into 'int'.
5353 Improve hashing quality when configured --with-wide-int.
5354 * fns.c (hash_string): New function, taken from sxhash_string.
5355 Do not discard information about ASCII character case; this
5356 discarding is no longer needed.
5357 (sxhash-string): Use it. Change sig to match it. Caller changed.
5358 * lisp.h: Declare it.
5359 * lread.c (hash_string): Remove, since we now use fns.c's version.
5360 The fns.c version returns a wider integer if --with-wide-int is
5361 specified, so this should help the quality of the hashing a bit.
5363 * emacs.c: Integer overflow minor fix.
5364 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
5365 Define only if GNU_LINUX.
5366 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
5368 * dispnew.c: Integer signedness and overflow fixes.
5369 Remove unnecessary forward decls, that were a maintenance hassle.
5370 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
5372 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
5373 (scrolling_window): Use ptrdiff_t, not int, for byte count.
5374 (prepare_desired_row, line_draw_cost):
5375 Use int, not unsigned, where either works.
5376 (save_current_matrix, restore_current_matrix):
5377 Use ptrdiff_t, not size_t, where either works.
5378 (init_display): Check for overflow more accurately, and without
5379 relying on undefined behavior.
5381 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
5382 Remove, replacing with the new symbols in lisp.h. All uses changed.
5383 * fileio.c (make_temp_name):
5384 * filelock.c (lock_file_1, lock_file):
5385 * xdisp.c (message_dolog):
5386 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
5387 Use pMd etc. instead.
5388 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
5389 replacing the pWIDE etc. symbols removed from editfns.c.
5391 * keyboard.h (num_input_events): Now uintmax_t.
5392 This is (very slightly) less likely to mess up due to wraparound.
5395 * buffer.c: Integer signedness fixes.
5396 (alloc_buffer_text, enlarge_buffer_text):
5397 Use ptrdiff_t rather than size_t when either will do, as we prefer
5400 * alloc.c: Integer signedness and overflow fixes.
5401 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
5402 (__malloc_size_t): Default to size_t, not to int.
5403 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
5404 (Fgarbage_collect, mark_object_loop_halt, mark_object):
5405 Prefer ptrdiff_t to size_t when either would do, as we prefer
5407 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
5408 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
5409 Now const. Initialize with values that are in range even if char
5411 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
5412 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
5413 These functions do the right thing with sizes > 2**32.
5414 (check_depth): Now ptrdiff_t, not int.
5415 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
5416 Adjust to new way of storing sizes. Check for size overflow bugs
5418 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
5419 slightly wrong anyway, as it missed one instance of
5420 XMALLOC_OVERRUN_CHECK_OVERHEAD.
5421 (refill_memory_reserve): Omit needless cast to size_t.
5422 (mark_object_loop_halt): Mark as externally visible.
5424 * xselect.c: Integer signedness and overflow fixes.
5425 (Fx_register_dnd_atom, x_handle_dnd_message):
5426 Use ptrdiff_t, not size_t, since we prefer signed.
5427 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
5428 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
5429 x_dnd_atoms_size and x_dnd_atoms_length.
5431 * doprnt.c: Prefer signed to unsigned when either works.
5433 * doprnt.c (doprnt):
5435 * xdisp.c (vmessage):
5436 Use ptrdiff_t, not size_t, when using or implementing doprnt,
5437 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
5438 prefer signed arithmetic to avoid comparison confusion.
5439 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
5440 but is a bit tricky.
5442 Assume freestanding C89 headers, string.h, stdlib.h.
5443 * data.c, doprnt.c, floatfns.c, print.c:
5444 Include float.h unconditionally.
5445 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
5446 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
5447 * regex.c: Likewise for stddef.h, string.h.
5448 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
5449 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
5450 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
5451 (STDC_HEADERS): Remove obsolete defines.
5452 * sysdep.c: Include limits.h unconditionally.
5454 Assume support for memcmp, memcpy, memmove, memset.
5455 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
5456 * regex.c (memcmp, memcpy):
5457 Remove; we assume C89 now.
5459 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
5460 (__malloc_safe_bcopy): Remove; no longer needed.
5462 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
5463 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
5464 well either way, and we prefer signed to unsigned.
5466 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
5468 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
5469 closes the connection while we're reading (bug#9182).
5471 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
5473 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
5474 are specified (Bug#9168).
5476 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
5478 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
5479 Found by GCC static checking and --with-wide-int on a 32-bit host.
5481 2011-07-25 Eli Zaretskii <eliz@gnu.org>
5483 * xdisp.c (compute_display_string_pos): Fix logic of caching
5484 previous display string position. Initialize cached_prev_pos to
5485 -1. Fixes slow-down at the beginning of a buffer.
5487 2011-07-24 Eli Zaretskii <eliz@gnu.org>
5489 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
5490 for attrs[LFACE_FONTSET_INDEX].
5492 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
5494 * xml.c (parse_region): Remove unused local
5495 that was recently introduced.
5497 2011-07-23 Eli Zaretskii <eliz@gnu.org>
5499 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
5500 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
5502 * xdisp.c (move_it_in_display_line_to): Record the best matching
5503 position for TO_CHARPOS while scanning the line, and restore it on
5504 exit if none of the characters scanned was an exact match.
5505 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
5506 when exact match is impossible due to invisible text, and the
5507 lines are truncated.
5509 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
5511 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
5514 2011-07-22 Eli Zaretskii <eliz@gnu.org>
5516 Fix a significant slow-down of cursor motion with C-n, C-p,
5517 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
5518 auto-repeat under bidi redisplay in fontified buffers.
5519 * xdisp.c (compute_stop_pos_backwards): New function.
5520 (next_element_from_buffer): Call compute_stop_pos_backwards to
5521 find a suitable prev_stop when we find ourselves before
5523 (reseat): Don't look for prev_stop, as that could mean a very long
5525 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
5526 <cached_disp_overlay_modiff>: Cache for last found display string
5528 (compute_display_string_pos): Return the cached position if asked
5529 about the same buffer in the same area of character positions, and
5530 the buffer wasn't changed since the time the display string
5531 position was cached.
5533 2011-07-22 Eli Zaretskii <eliz@gnu.org>
5535 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
5536 is an integer, which is important for empty lines. (Bug#9149)
5538 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
5540 * frame.c (Fmodify_frame_parameters): In tty case, update the
5541 default face if necessary (Bug#4238).
5543 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
5545 * editfns.c (Fstring_to_char): No need to explain what a character
5546 is in the docstring (Bug#6576).
5548 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5550 * xml.c (parse_region): Make sure we always return a tree.
5552 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
5554 * xml.c (parse_region): If a document contains only comments,
5557 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5559 * xml.c (make_dom): Return comments, too.
5561 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
5564 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
5565 and the surrounding thread.
5566 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
5567 rather than fgets, and retry after EINTR. Otherwise, 'emacs
5568 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
5570 * s/openbsd.h (BROKEN_SIGIO): Define.
5571 * unexelf.c (unexec) [__OpenBSD__]:
5572 Don't update the .mdebug section of the Alpha COFF symbol table.
5574 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5576 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
5579 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
5581 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
5582 This fixes some race conditions on the permissions of any newly
5585 * alloc.c (valid_pointer_p): Use pipe, not open.
5586 This fixes some permissions issues when debugging.
5588 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
5589 If fchown fails to set both uid and gid, try to set just gid,
5590 as that is sometimes allowed. Adjust the file's mode to eliminate
5591 setuid or setgid bits that are inappropriate if fchown fails.
5593 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
5595 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
5596 to compare Lisp_Objects.
5597 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
5598 global_gnutls_log_level, don't mistake it for a Lisp_Object.
5599 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
5601 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
5603 * lread.c (read_integer): Unread even EOF character.
5604 (read1): Likewise. Properly record start position of symbol.
5606 * lread.c (read1): Read `#:' as empty uninterned symbol if no
5607 symbol character follows.
5609 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
5611 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
5612 This works around a problem with the previous change to Fcopy_file.
5613 Recent glibc declares fchown with __attribute__((warn_unused_result)),
5614 and without this change, GCC might complain about discarding
5615 fchown's return value.
5617 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
5619 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
5621 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
5623 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
5625 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
5627 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
5628 it's used from the C level.
5630 * process.c: Use the same condition for POLL_FOR_INPUT in both
5631 keyboard.c and process.c (bug#1858).
5633 2011-07-09 Lawrence Mitchell <wence@gmx.li>
5635 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
5636 (Fgnutls_boot): Use it.
5638 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
5640 * doc.c (Fsubstitute_command_keys): Revert last change.
5642 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
5644 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
5645 quotes the next character, and doesn't affect other longer
5646 sequences (bug#8935).
5648 * lread.c (syms_of_lread): Clarify that is isn't only
5649 `eval-buffer' and `eval-defun' that's affected by
5650 `lexical-binding' (bug#8460).
5652 2011-07-15 Eli Zaretskii <eliz@gnu.org>
5654 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
5655 bidi redisplay when a line includes both an image and is truncated.
5657 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
5659 Fix minor problems found by static checking.
5660 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
5661 (elsz): Now a signed constant, not a size_t var. We prefer signed
5662 types to unsigned, to avoid integer comparison confusion. Without
5663 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
5664 "cannot optimize loop, the loop counter may overflow", a symptom
5666 * indent.c (Fvertical_motion): Mark locals as initialized.
5667 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
5669 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
5671 * search.c (Fre_search_backward): Mention `case-fold-search' in
5672 all the re_search_* functions (bug#8138).
5674 * keyboard.c (Fopen_dribble_file): Document when the file is
5677 2011-07-14 Eli Zaretskii <eliz@gnu.org>
5679 * bidi.c (bidi_dump_cached_states): Fix format of displaying
5682 Support bidi reordering of display and overlay strings.
5683 * xdisp.c (compute_display_string_pos)
5684 (compute_display_string_end): Accept additional argument STRING.
5685 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
5686 (reseat_to_string): Initialize bidi_it->string.s and
5687 bidi_it->string.schars.
5688 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
5689 NULL (avoids a crash in bidi_paragraph_init).
5690 Initialize itb.string.lstring.
5691 (init_iterator): Call bidi_init_it only of a valid
5692 buffer position was specified. Initialize paragraph_embedding to
5694 (reseat_to_string): Initialize the bidi iterator.
5695 (display_string): If we need to ignore text properties of
5696 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
5697 original value of -1 will not work with bidi.)
5698 (compute_display_string_pos): First arg is now struct
5699 `text_pos *'; all callers changed. Support display properties on
5701 (compute_display_string_end): Support display properties on Lisp
5703 (init_iterator, reseat_1, reseat_to_string): Initialize the
5704 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
5705 when iterating on a string not from display properties).
5706 (compute_display_string_pos, compute_display_string_end):
5707 Fix calculation of the object to scan. Fixes an error when using
5709 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
5710 base_level_stop; instead, set base_level_stop to BEGV.
5711 Fixes crashes in vertical-motion.
5712 (next_element_from_buffer): Improve commentary for when
5713 the iterator is before prev_stop.
5714 (init_iterator): Initialize bidi_p from the default value of
5715 bidi-display-reordering, not from buffer-local value. Use the
5716 buffer-local value only if initializing for buffer iteration.
5717 (handle_invisible_prop): Support invisible properties on strings
5718 that are being bidi-reordered.
5719 (set_iterator_to_next): Support bidi reordering of C strings and
5721 (next_element_from_string): Support bidi reordering of Lisp
5723 (handle_stop_backwards): Support Lisp strings as well.
5724 (display_string): Support display of R2L glyph rows.
5725 Use IT_STRING_CHARPOS when displaying from a Lisp string.
5726 (init_iterator): Don't initialize it->bidi_p for strings
5728 (reseat_to_string): Initialize it->bidi_p for strings here.
5729 (next_element_from_string, next_element_from_c_string)
5730 (next_element_from_buffer): Add xassert's for correspondence
5731 between IT's object being iterated and it->bidi_it.string
5733 (face_before_or_after_it_pos): Support bidi iteration.
5734 (next_element_from_c_string): Handle the case of the first string
5735 character that is not the first one in the visual order.
5736 (get_visually_first_element): New function, refactored from common
5737 parts of next_element_from_buffer, next_element_from_string, and
5738 next_element_from_c_string.
5739 (tool_bar_lines_needed, redisplay_tool_bar)
5740 (display_menu_bar): Force left-to-right direction. Add a FIXME
5741 comment for making that be controlled by a user option.
5742 (push_it, pop_it): Save and restore the state of the
5743 bidi iterator. Save and restore the bidi_p flag.
5744 (pop_it): Iterate out of display property for string iteration as
5746 (iterate_out_of_display_property): Support iteration over strings.
5747 (handle_single_display_spec): Set up it->bidi_it for iteration
5748 over a display string, and call bidi_init_it.
5749 (handle_single_display_spec, next_overlay_string)
5750 (get_overlay_strings_1, push_display_prop): Set up the bidi
5751 iterator for displaying display or overlay strings.
5752 (forward_to_next_line_start): Don't use the shortcut if
5754 (back_to_previous_visible_line_start): If handle_display_prop
5755 pushed the iterator stack, restore the internal state of the bidi
5756 iterator by calling bidi_pop_it same number of times.
5757 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
5758 and we are bidi-iterating, don't decrement the iterator position;
5759 instead, set the first_elt flag in the bidi iterator, to produce
5761 (reseat_1): Remove redundant setting of string_from_display_prop_p.
5762 (push_display_prop): xassert that we are iterating a buffer.
5763 (push_it, pop_it): Save and restore paragraph_embedding member.
5764 (handle_single_display_spec, next_overlay_string)
5765 (get_overlay_strings_1, reseat_1, reseat_to_string)
5766 (push_display_prop): Set up the `unibyte' member of bidi_it.string
5767 correctly. Don't assume unibyte strings are not bidi-reordered.
5768 (compute_display_string_pos)
5769 (compute_display_string_end): Fix handling the case of C string.
5770 (push_it, pop_it): Save and restore from_disp_prop_p.
5771 (handle_single_display_spec, push_display_prop): Set the
5772 from_disp_prop_p flag.
5773 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
5774 (pop_it): Call iterate_out_of_display_property only if we are
5775 popping after iteration over a string that came from a display
5776 property. Fix a typo in popping stretch info. Add an assertion
5777 for verifying that the iterator position is in sync with the bidi
5779 (handle_single_display_spec, get_overlay_strings_1)
5780 (push_display_prop): Fix initialization of paragraph direction for
5781 string when that of the parent object is not yet determined.
5782 (reseat_1): Call bidi_init_it to resync the bidi
5783 iterator with IT's position. (Bug#7616)
5784 (find_row_edges): If ROW->start.pos gives position
5785 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
5786 (handle_stop, back_to_previous_visible_line_start, reseat_1):
5787 Reset the from_disp_prop_p flag.
5788 (SAVE_IT, RESTORE_IT): New macros.
5789 (pos_visible_p, face_before_or_after_it_pos)
5790 (back_to_previous_visible_line_start)
5791 (move_it_in_display_line_to, move_it_in_display_line)
5792 (move_it_to, move_it_vertically_backward, move_it_by_lines)
5793 (try_scrolling, redisplay_window, display_line): Use them when
5794 saving a temporary copy of the iterator and restoring it back.
5795 (back_to_previous_visible_line_start, reseat_1)
5796 (init_iterator): Empty the bidi cache "stack".
5797 (move_it_in_display_line_to): If iterator ended up at
5798 EOL, but we never saw any buffer positions smaller than
5799 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
5800 motion in bidi-reordered lines.
5801 (move_it_in_display_line_to): Record prev_method and prev_pos
5802 immediately before the call to set_iterator_to_next. Fixes cursor
5803 motion in bidi-reordered lines with stretch glyphs and strings
5804 displayed in margins. (Bug#8133) (Bug#8867)
5805 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
5807 (pos_visible_p): Support positions in bidi-reordered lines.
5808 Save and restore bidi cache.
5810 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
5811 (bidi_paragraph_info): Delete unused struct.
5812 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
5813 (bidi_cache_start): New variable.
5814 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
5816 (bidi_cache_fetch_state, bidi_cache_search)
5817 (bidi_cache_find_level_change, bidi_cache_iterator_state)
5818 (bidi_cache_find, bidi_peek_at_next_level)
5819 (bidi_level_of_next_char, bidi_find_other_level_edge)
5820 (bidi_move_to_visually_next): Compare cache index with
5821 bidi_cache_start rather than with zero.
5822 (bidi_fetch_char): Accept new argument STRING; all callers
5823 changed. Support iteration over a string. Support strings with
5824 display properties. Support unibyte strings. Fix the type of
5825 `len' according to what STRING_CHAR_AND_LENGTH expects.
5826 (bidi_paragraph_init, bidi_resolve_explicit_1)
5827 (bidi_resolve_explicit, bidi_resolve_weak)
5828 (bidi_level_of_next_char, bidi_move_to_visually_next):
5829 Support iteration over a string.
5830 (bidi_set_sor_type, bidi_resolve_explicit_1)
5831 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
5832 can now be zero (for strings); special values 0 and -1 were
5833 changed to -1 and -2, respectively.
5834 (bidi_char_at_pos): New function.
5835 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
5836 Call it instead of FETCH_MULTIBYTE_CHAR.
5837 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
5838 initialized to valid values.
5839 (bidi_init_it): Don't initialize charpos and bytepos with invalid
5841 (bidi_level_of_next_char): Allow the sentinel "position" to pass
5842 the test for valid cached positions. Fix the logic for looking up
5843 the sentinel state in the cache. GCPRO the Lisp string we are
5845 (bidi_push_it, bidi_pop_it): New functions.
5846 (bidi_initialize): Initialize the bidi cache start stack pointer.
5847 (bidi_cache_ensure_space): New function, refactored from part of
5848 bidi_cache_iterator_state. Don't assume the required size is just
5849 one BIDI_CACHE_CHUNK away.
5850 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
5851 (bidi_count_bytes, bidi_char_at_pos): New functions.
5852 (bidi_cache_search): Don't assume bidi_cache_last_idx is
5853 always valid if bidi_cache_idx is valid.
5854 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
5855 is valid if it's going to be used.
5856 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
5857 (bidi_cache_fetch_state, bidi_cache_search)
5858 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5859 (bidi_cache_iterator_state, bidi_cache_find)
5860 (bidi_find_other_level_edge, bidi_cache_start_stack):
5861 All variables related to cache indices are now EMACS_INT.
5863 * dispextern.h (struct bidi_string_data): New structure.
5864 (struct bidi_it): New member `string'. Make flag members be 1-bit
5865 fields, and put them last in the struct.
5866 (compute_display_string_pos, compute_display_string_end):
5868 (bidi_push_it, bidi_pop_it): Add prototypes.
5869 (struct iterator_stack_entry): New members bidi_p,
5870 paragraph_embedding, and from_disp_prop_p.
5871 (struct it): Member bidi_p is now a bit field 1 bit wide.
5872 (bidi_shelve_cache, bidi_unshelve_cache):
5875 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
5876 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
5877 and vector-like objects.
5879 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
5880 cache around display iteration.
5882 * window.c (Fwindow_end, window_scroll_pixel_based)
5883 (displayed_window_lines, Frecenter): Save and restore the bidi
5884 cache around display iteration.
5886 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
5888 * editfns.c (Fdelete_region): Clarify the use of the named
5889 parameters (bug#6788).
5891 2011-07-14 Martin Rudalics <rudalics@gmx.at>
5893 * indent.c (Fvertical_motion): Set and restore w->pointm when
5894 saving and restoring the window's buffer (Bug#9006).
5896 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
5898 * editfns.c (Fstring_to_char): Clarify just what is returned
5899 (bug#6576). Text by Eli Zaretskii.
5901 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
5903 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
5905 2011-07-13 Eli Zaretskii <eliz@gnu.org>
5907 * buffer.c (mmap_find): Fix a typo.
5909 2011-07-13 Johan Bockgård <bojohan@gnu.org>
5911 Fix execution of x selection hooks.
5912 * xselect.c (Qx_lost_selection_functions)
5913 (Qx_sent_selection_functions): New vars.
5914 (syms_of_xselect): DEFSYM them.
5915 (x_handle_selection_request): Pass Qx_sent_selection_functions
5916 rather than Vx_sent_selection_functions to Frun_hook_with_args.
5917 (x_handle_selection_clear,x_clear_frame_selections):
5918 Pass Qx_lost_selection_functions rather than
5919 Vx_lost_selection_functions to Frun_hook_with_args.
5921 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
5923 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
5924 The old code sometimes used this field without initializing it.
5926 * alloc.c (gc_sweep): Don't read past end of array.
5927 In theory, the old code could also have corrupted Emacs internals,
5928 though it'd be very unlikely.
5930 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
5932 * character.c (Fcharacterp): Don't advertise optional ignored
5933 argument. (Bug#4026)
5935 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
5937 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
5940 * window.c (Fset_window_start): Doc fix (bug#4199).
5941 (Fset_window_hscroll): Ditto.
5943 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
5945 Fix minor new problems caught by GCC 4.6.1.
5946 * term.c (init_tty): Remove unused local.
5947 * xsettings.c (store_monospaced_changed): Define this function only
5948 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
5951 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
5953 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
5955 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5957 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
5958 are the mini-buffer and the echo area (bug#3320).
5960 * term.c (init_tty): Remove support for supdup, c10 and perq
5961 terminals, which are no longer supported (bug#1482).
5963 2011-07-10 Johan Bockgård <bojohan@gnu.org>
5965 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
5967 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
5969 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
5970 for non-popups (Bug#3642).
5972 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
5974 * alloc.c (reset_malloc_hooks): Protoize.
5975 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
5976 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
5977 * cm.c (losecursor): Likewise.
5978 * data.c (fmod): Likewise.
5979 * dispnew.c (swap_glyphs_in_rows): Likewise.
5980 * emacs.c (memory_warning_signal): Likewise.
5981 * floatfns.c (float_error): Likewise.
5982 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
5983 (otf_open, font_otf_capability, generate_otf_features)
5984 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
5986 * image.c (pbm_read_file): Likewise.
5987 * indent.c (string_display_width): Likewise.
5988 * intervals.c (check_for_interval, search_for_interval)
5989 (inc_interval_count, count_intervals, root_interval)
5990 (adjust_intervals_for_insertion, make_new_interval): Likewise.
5991 * lread.c (defalias): Likewise.
5992 * ralloc.c (r_alloc_check): Likewise.
5993 * regex.c (set_image_of_range_1, set_image_of_range)
5994 (regex_grow_registers): Likewise.
5995 * sysdep.c (strerror): Likewise.
5996 * termcap.c (valid_filename_p, tprint, main): Likewise.
5997 * tparam.c (main): Likewise.
5998 * unexhp9k800.c (run_time_remap, save_data_space)
5999 (update_file_ptrs, read_header, write_header, calculate_checksum)
6000 (copy_file, copy_rest, display_header): Likewise.
6001 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
6003 * xdisp.c (check_it): Likewise.
6004 * xfaces.c (register_color, unregister_color, unregister_colors):
6006 * xfns.c (print_fontset_result): Likewise.
6007 * xrdb.c (member, fatal, main): Likewise.
6009 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
6011 Fix minor problems found by static checking (Bug#9031).
6012 * chartab.c (char_table_set_range, map_sub_char_table):
6013 Remove unused locals.
6014 (uniprop_table): Now static.
6015 * composite.c (_work_char): Remove unused static var.
6017 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
6019 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
6021 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
6023 * gtkutil.c (qttip_cb): Remove code without function.
6025 2011-07-09 Eli Zaretskii <eliz@gnu.org>
6027 * w32.c (pthread_sigmask): New stub.
6029 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
6031 Use pthread_sigmask, not sigprocmask (Bug#9010).
6032 sigprocmask is portable only for single-threaded applications, and
6033 Emacs can be multi-threaded when it uses GTK.
6034 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
6036 * callproc.c (Fcall_process):
6037 * process.c (create_process):
6038 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
6039 Use pthread_sigmask, not sigprocmask.
6041 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6043 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
6044 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
6047 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6049 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
6050 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
6051 (xg_hide_tooltip): Fix comment.
6053 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
6054 in registerServicesMenuSendTypes.
6055 (validRequestorForSendType): Don't check ns_return_types.
6057 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
6060 2011-07-08 Jason Rumney <jasonr@gnu.org>
6062 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
6063 SH_SHOW for hidden windows (Bug#5482).
6065 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
6066 frame struct members of non-existent frames (Bug#6284).
6068 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6070 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
6071 variable firstTime not needed on OSX >= 10.6.
6072 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
6073 >= 10.5. Use setKnobProportion, setDoubleValue.
6075 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
6076 (MAC_OS_X_VERSION_10_5): Define if not defined.
6077 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
6078 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
6079 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
6081 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
6082 cString and lossyCString on OSX >= 10.4
6084 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
6085 sizeToFit on OSX >= 10.2.
6087 * nsimage.m (allocInitFromFile): Don't use deprecated method
6088 bestRepresentationForDevice on OSX >= 10.6.
6090 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
6093 * emacs.c: Declare unexec_init_emacs_zone.
6095 * nsgui.h: Fix compiler warning about gnulib redefining verify.
6097 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
6099 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
6100 on svcsMenu (Bug#8842).
6102 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
6104 (Fns_list_services): Just return Qnil on 10.6, code not working there.
6106 * nsterm.m (QUTF8_STRING): Declare.
6107 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
6108 (validRequestorForSendType): Return type is (id).
6109 Change indexOfObjectIdenticalTo to indexOfObject.
6110 Check if we have local selection before returning self (Bug#8842).
6111 (writeSelectionToPasteboard): Put local selection into paste board
6112 if we have a local selection (Bug#8842).
6113 (syms_of_nsterm): DEFSYM QUTF8_STRING.
6115 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
6116 (ns_get_local_selection): Declare.
6118 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
6120 * keymap.c (describe_map_tree): Don't insert a double newline at
6121 the end of the buffer (bug#1169) and return whether we inserted
6124 * callint.c (Fcall_interactively): Change "reading args" to
6125 "providing args" to try to clarify what it does (bug#1010).
6127 2011-07-07 Kenichi Handa <handa@m17n.org>
6129 * composite.c (composition_compute_stop_pos): Ignore a static
6130 composition starting before CHARPOS (Bug#8915).
6132 * xdisp.c (handle_composition_prop): Likewise.
6134 2011-07-07 Eli Zaretskii <eliz@gnu.org>
6136 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
6139 2011-07-07 Kenichi Handa <handa@m17n.org>
6141 * character.h (unicode_category_t): New enum type.
6143 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
6144 (Qchar_code_property_table): New variable.
6145 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
6146 (UNIPROP_COMPRESSED_FORM_P): New macros.
6147 (char_table_ascii): Uncompress the compressed values.
6148 (sub_char_table_ref): New arg is_uniprop. Callers changed.
6149 Uncompress the compressed values.
6150 (sub_char_table_ref_and_range): Likewise.
6151 (char_table_ref_and_range): Uncompress the compressed values.
6152 (sub_char_table_set): New arg is_uniprop. Callers changed.
6153 Uncompress the compressed values.
6154 (sub_char_table_set_range): Args changed. Callers changed.
6155 (char_table_set_range): Adjuted for the above change.
6156 (map_sub_char_table): Delete args default_val and parent. Add arg
6157 top. Give decoded values to a Lisp function.
6158 (map_char_table): Adjust for the above change. Give decoded
6159 values to a Lisp function. Gcpro more variables.
6160 (uniprop_table_uncompress)
6161 (uniprop_decode_value_run_length): New functions.
6162 (uniprop_decoder, uniprop_decoder_count): New variables.
6163 (uniprop_get_decoder, uniprop_encode_value_character)
6164 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
6166 (uniprop_encoder, uniprop_encoder_count): New variables.
6167 (uniprop_get_encoder, uniprop_table)
6168 (Funicode_property_table_internal, Fget_unicode_property_internal)
6169 (Fput_unicode_property_internal): New functions.
6170 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
6171 Sunicode_property_table_internal, Sget_unicode_property_internal,
6172 and Sput_unicode_property_internal. Defvar_lisp
6173 char-code-property-alist.
6175 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
6176 Vunicode_category_table.
6178 * font.c (font_range): Adjust for the change of
6179 Vunicode_category_table.
6181 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
6183 * m/iris4d.h: Remove file, move contents ...
6184 * s/irix6-5.h: ... here.
6186 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
6188 Remove unportable assumption about struct layout (Bug#8884).
6189 * alloc.c (mark_buffer):
6190 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
6191 (clone_per_buffer_values): Don't assume that
6192 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
6193 This isn't true in general, and it's particularly not true
6194 if Emacs is configured with --with-wide-int.
6195 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
6196 New macros, used in the buffer.c change.
6198 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
6200 * xsettings.c: Use both GConf and GSettings if both are available.
6201 (store_config_changed_event): Add comment.
6202 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
6203 (store_tool_bar_style_changed): New functions.
6204 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
6205 (struct xsettings): Move font inside HAVE_XFT.
6206 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
6207 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
6208 Move inside HAVE_XFT.
6209 (something_changed_gsettingsCB): Rename from something_changedCB.
6210 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
6212 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
6213 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
6214 (something_changed_gconfCB): Rename from something_changedCB.
6215 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
6216 (parse_settings): Move check for font inside HAVE_XFT.
6217 (read_settings, apply_xft_settings): Add comment.
6218 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
6219 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
6220 call store_font_name_changed.
6221 (xft_settings_event): Add comment.
6222 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
6223 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
6224 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
6225 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
6226 (xsettings_initialize): Call init_gsettings last.
6227 (xsettings_get_system_font, xsettings_get_system_normal_font):
6230 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
6232 Random fixes. E.g., (random) never returned negative values.
6233 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
6234 subseconds part to the entropy, as that's a bit more random.
6235 Prefer signed to unsigned, since the signedness doesn't matter and
6236 in general we prefer signed. When given a limit, use a
6237 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
6238 latter isn't right if USE_2_TAGS_FOR_INTS.
6239 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
6240 not 0..VALMASK. Don't discard "excess" bits that random () returns.
6242 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
6244 * textprop.c (text_property_stickiness):
6245 Obey Vtext_property_default_nonsticky.
6246 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
6247 * w32fns.c (syms_of_w32fns):
6248 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
6250 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6252 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
6253 This is more efficient than Ffile_directory_p and avoids a minor race.
6255 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
6257 * buffer.c (Foverlay_put): Say what the return value is
6260 * fileio.c (barf_or_query_if_file_exists): Check first if the file
6261 is a directory before asking whether to use the file name
6263 (barf_or_query_if_file_exists): Make the "File is a directory"
6264 error be more correct.
6266 * fns.c (Frequire): Remove the mention of the .gz files, since
6267 that's installation-specific, but keep the mention of
6268 `get-load-suffixes'.
6270 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6272 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
6273 Report string overflow if the output is too long.
6275 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
6277 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
6278 (syms_of_gnutls): Remove duplicate DEFSYM for
6279 Qgnutls_bootprop_verify_hostname_error, an error for
6280 Qgnutls_bootprop_verify_error (which is no longer used).
6282 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
6283 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
6284 Also (re)move comments that are misplaced or no longer relevant.
6286 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6288 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
6290 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
6292 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
6293 and background color parameters if they have been changed.
6295 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6297 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
6299 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
6301 * xsettings.c (SYSTEM_FONT): Define only when used.
6302 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
6304 * keymap.c (access_keymap_1): Now static.
6306 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
6308 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
6309 leave any prefix arg for the up event (Bug#1586).
6311 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
6313 * lread.c (syms_of_lread): Mention single symbols defined by
6314 `defvar' or `defconst' (bug#7154).
6316 * fns.c (Frequire): Mention .el.gz files (bug#7314).
6317 (Frequire): Mention get-load-suffixes.
6319 2011-07-02 Martin Rudalics <rudalics@gmx.at>
6321 * window.h (window): Remove clone_number slot.
6322 * window.c (Fwindow_clone_number, Fset_window_clone_number):
6324 (make_parent_window, make_window, saved_window)
6325 (Fset_window_configuration, save_window_save): Don't deal with
6327 * buffer.c (Qclone_number): Remove declaration.
6328 (sort_overlays, overlay_strings): Don't deal with clone numbers.
6330 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
6332 Add multiple inheritance to keymaps.
6333 * keymap.c (Fmake_composed_keymap): New function.
6334 (Fset_keymap_parent): Simplify.
6335 (fix_submap_inheritance): Remove.
6336 (access_keymap_1): New function extracted from access_keymap to handle
6337 embedded parents and handle lists of maps.
6338 (access_keymap): Use it.
6339 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
6340 (Fcopy_keymap): Handle embedded parents.
6341 (Fcommand_remapping, define_as_prefix): Simplify.
6342 (Fkey_binding): Simplify.
6343 (syms_of_keymap): Move minibuffer-local-completion-map,
6344 minibuffer-local-filename-completion-map,
6345 minibuffer-local-must-match-map, and
6346 minibuffer-local-filename-must-match-map to Elisp.
6347 (syms_of_keymap): Defsubr make-composed-keymap.
6348 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
6349 (parse_menu_item): Trivial simplification.
6351 2011-07-01 Glenn Morris <rgm@gnu.org>
6353 * Makefile.in (SETTINGS_LIBS): Fix typo.
6355 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
6357 * coding.c (Fencode_coding_string): Record the last coding system
6358 used, as the function doc string says (bug#8738).
6360 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
6362 * xsettings.c (store_monospaced_changed): Take new font as arg and
6363 check for change against current_mono_font.
6364 (EMACS_TYPE_SETTINGS): Remove this and related defines.
6365 (emacs_settings_constructor, emacs_settings_get_property)
6366 (emacs_settings_set_property, emacs_settings_class_init)
6367 (emacs_settings_init, gsettings_obj): Remove.
6368 (something_changedCB): New function for HAVE_GSETTINGS.
6369 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
6370 with value as argument.
6371 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
6372 g_settings_new (Bug#8967). Do not create gsettings_obj.
6373 Remove calls to g_settings_bind. Connect something_changedCB to
6376 * xgselect.c: Add defined (HAVE_GSETTINGS).
6377 (xgselect_initialize): Ditto.
6379 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
6380 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
6383 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
6385 * eval.c (struct backtrace): Simplify and port the data structure.
6386 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
6387 signed bit field, as this assumption is not portable and it makes
6388 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
6389 "char debug_on_exit : 1" as this is not portable either; instead,
6390 use the portable "unsigned int debug_on_exit : 1". Remove unused
6391 member evalargs. Remove obsolete comments about cc bombing out.
6393 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
6395 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
6396 Let HAVE_GSETTINGS override HAVE_GCONF.
6397 (store_monospaced_changed): New function.
6398 (EMACS_SETTINGS): A new type derived from GObject to handle
6399 GSettings notifications.
6400 (emacs_settings_constructor, emacs_settings_get_property)
6401 (emacs_settings_set_property, emacs_settings_class_init):
6403 (gsettings_client, gsettings_obj): New variables.
6404 (GSETTINGS_SCHEMA): New define.
6405 (something_changedCB): Call store_monospaced_changed.
6406 (init_gsettings): New function.
6407 (xsettings_initialize): Call init_gsettings.
6408 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
6411 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
6414 2011-06-29 Martin Rudalics <rudalics@gmx.at>
6416 * window.c (resize_root_window, grow_mini_window)
6417 (shrink_mini_window): Rename Qresize_root_window to
6418 Qwindow_resize_root_window and Qresize_root_window_vertically to
6419 Qwindow_resize_root_window_vertically.
6421 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
6423 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
6425 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
6427 * makefile.w32-in: Redesign dependencies so they reflect more
6428 clearly which files are directly included by each source file,
6429 and not through other includes.
6431 2011-06-27 Martin Rudalics <rudalics@gmx.at>
6433 * buffer.c (Qclone_number): Declare static and DEFSYM it.
6434 (sort_overlays, overlay_strings): When an overlay's clone number
6435 matches the window's clone number process the overlay even if
6436 the overlay's window property doesn't match the current window.
6438 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
6439 (Fwindow_hchild): Rename to Fwindow_left_child.
6440 (Fwindow_next): Rename to Fwindow_next_sibling.
6441 (Fwindow_prev): Rename to Fwindow_prev_sibling.
6442 (resize_window_check): Rename to window_resize_check.
6443 (resize_window_apply): Rename to window_resize_apply.
6444 (Fresize_window_apply): Rename to Fwindow_resize_apply.
6445 (Fdelete_other_windows_internal, resize_frame_windows)
6446 (Fsplit_window_internal, Fdelete_window_internal)
6447 (grow_mini_window, shrink_mini_window)
6448 (Fresize_mini_window_internal): Fix callers accordingly.
6450 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
6452 * emacsgtkfixed.h: State that this is only used with Gtk+3.
6453 (emacs_fixed_set_min_size): Remove.
6454 (emacs_fixed_new): Take frame as argument.
6456 * emacsgtkfixed.c: State that this is only used with Gtk+3.
6457 (_EmacsFixedPrivate): Remove minwidth/height.
6458 Add struct frame *f.
6459 (emacs_fixed_init): Initialize priv->f.
6460 (get_parent_class, emacs_fixed_set_min_size): Remove.
6461 (emacs_fixed_new): Set priv->f to argument.
6462 (emacs_fixed_get_preferred_width)
6463 (emacs_fixed_get_preferred_height): Use min_width/height from
6464 frames size_hint to set minimum and natural (Bug#8919).
6465 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
6466 and use min_width/height from frames size_hint to set
6467 min_width/height (Bug#8919).
6469 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
6470 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
6473 2011-06-26 Eli Zaretskii <eliz@gnu.org>
6475 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
6476 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
6479 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
6481 * process.c (wait_reading_process_output): Bypass select if
6482 waiting for a cell while ignoring keyboard input, and input is
6483 pending. Suggested by Jan Djärv (Bug#8869).
6485 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
6487 Use gnulib's dup2 module instead of rolling our own.
6488 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
6490 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6492 * dispnew.c (scrolling_window): Before scrolling, turn off a
6493 mouse-highlight in the window being scrolled.
6495 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
6497 Move DEFSYM to lisp.h and use everywhere.
6499 * character.h (DEFSYM): Move declaration...
6500 * lisp.h (DEFSYM): ...here.
6506 * w32select.c: Don't include character.h.
6508 * alloc.c (syms_of_alloc):
6509 * buffer.c (syms_of_buffer):
6510 * bytecode.c (syms_of_bytecode):
6511 * callint.c (syms_of_callint):
6512 * casefiddle.c (syms_of_casefiddle):
6513 * casetab.c (init_casetab_once):
6514 * category.c (init_category_once, syms_of_category):
6515 * ccl.c (syms_of_ccl):
6516 * cmds.c (syms_of_cmds):
6517 * composite.c (syms_of_composite):
6518 * dbusbind.c (syms_of_dbusbind):
6519 * dired.c (syms_of_dired):
6520 * dispnew.c (syms_of_display):
6521 * doc.c (syms_of_doc):
6522 * editfns.c (syms_of_editfns):
6523 * emacs.c (syms_of_emacs):
6524 * eval.c (syms_of_eval):
6525 * fileio.c (syms_of_fileio):
6526 * fns.c (syms_of_fns):
6527 * frame.c (syms_of_frame):
6528 * fringe.c (syms_of_fringe):
6529 * insdel.c (syms_of_insdel):
6530 * keymap.c (syms_of_keymap):
6531 * lread.c (init_obarray, syms_of_lread):
6532 * macros.c (syms_of_macros):
6533 * msdos.c (syms_of_msdos):
6534 * print.c (syms_of_print):
6535 * process.c (syms_of_process):
6536 * search.c (syms_of_search):
6537 * sound.c (syms_of_sound):
6538 * syntax.c (init_syntax_once, syms_of_syntax):
6539 * terminal.c (syms_of_terminal):
6540 * textprop.c (syms_of_textprop):
6541 * undo.c (syms_of_undo):
6542 * w32.c (globals_of_w32):
6543 * window.c (syms_of_window):
6544 * xdisp.c (syms_of_xdisp):
6545 * xfaces.c (syms_of_xfaces):
6546 * xfns.c (syms_of_xfns):
6547 * xmenu.c (syms_of_xmenu):
6548 * xsettings.c (syms_of_xsettings):
6549 * xterm.c (syms_of_xterm): Use DEFSYM.
6551 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
6553 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
6555 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
6557 Integer and buffer overflow fixes (Bug#8873).
6559 * print.c (printchar, strout): Check for string overflow.
6560 (PRINTPREPARE, printchar, strout):
6561 Don't set size unless allocation succeeds.
6563 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
6564 for sizes. Check for string overflow more accurately.
6565 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
6567 * macros.c: Integer and buffer overflow fixes.
6568 * keyboard.h (struct keyboard.kbd_macro_bufsize):
6569 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
6570 Use ptrdiff_t, not int, for sizes.
6571 Don't increment bufsize until after realloc succeeds.
6572 Check for size-calculation overflow.
6573 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
6575 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
6577 * lread.c: Integer overflow fixes.
6578 (read_integer): Radix is now EMACS_INT, not int,
6579 to improve quality of diagnostics for out-of-range radices.
6580 Calculate buffer size correctly for out-of-range radices.
6581 (read1): Check for integer overflow in radices, and in
6582 read-circle numbers.
6583 (read_escape): Avoid int overflow.
6584 (Fload, openp, read_buffer_size, read1)
6585 (substitute_object_recurse, read_vector, read_list, map_obarray):
6586 Use ptrdiff_t, not int, for sizes.
6587 (read1): Use EMACS_INT, not int, for sizes.
6588 Check for size overflow.
6590 * image.c (cache_image): Check for size arithmetic overflow.
6592 * lread.c: Integer overflow issues.
6593 (saved_doc_string_size, saved_doc_string_length)
6594 (prev_saved_doc_string_size, prev_saved_doc_string_length):
6595 Now ptrdiff_t, not int.
6596 (read1): Don't assume doc string length fits in int. Check for
6597 out-of-range doc string lengths.
6598 (read_list): Don't assume file position fits in int.
6599 (read_escape): Check for hex character overflow.
6601 2011-06-22 Leo Liu <sdl.web@gmail.com>
6603 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
6604 Move to minibuffer.el.
6606 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6608 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
6609 The following patches are for when GLYPH_DEBUG && !XASSERT.
6610 * dispextern.h (trace_redisplay_p, dump_glyph_string):
6611 * dispnew.c (flush_stdout):
6612 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
6613 Mark as externally visible.
6614 * dispnew.c (check_window_matrix_pointers): Now static.
6615 * dispnew.c (window_to_frame_vpos):
6616 * xfns.c (unwind_create_frame):
6617 * xterm.c (x_check_font): Remove unused local.
6618 * scroll.c (CHECK_BOUNDS):
6619 * xfaces.c (cache_fache): Rename local to avoid shadowing.
6620 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
6621 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
6622 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
6623 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
6625 (debug_method_add): Use va_list and vsprintf rather than relying
6626 on undefined behavior with wrong number of arguments.
6627 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
6628 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
6629 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
6630 since we're not interested in debugging glyphs with old libraries.
6631 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
6632 GCC 4.6.0's static checking.
6634 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6636 Integer overflow and signedness fixes (Bug#8873).
6637 A few related buffer overrun fixes, too.
6639 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
6641 * dispextern.h (struct face.stipple):
6642 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
6643 (x_bitmap_mask, x_allocate_bitmap_record)
6644 (x_create_bitmap_from_data, x_create_bitmap_from_file)
6645 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
6646 (x_create_bitmap_from_xpm_data):
6647 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
6648 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
6650 * xfaces.c (load_pixmap):
6651 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
6652 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
6653 (.bitmaps_last, struct x_output.icon_bitmap):
6654 Use ptrdiff_t, not int, for bitmap indexes.
6655 (x_allocate_bitmap_record): Check for size overflow.
6656 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
6658 Use ptrdiff_t, not int, for overlay counts.
6659 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
6660 * editfns.c (overlays_around, get_pos_property):
6661 * textprop.c (get_char_property_and_overlay):
6662 * xdisp.c (next_overlay_change, note_mouse_highlight):
6663 * xfaces.c (face_at_buffer_position):
6664 * buffer.c (OVERLAY_COUNT_MAX): New macro.
6665 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
6666 (Fnext_overlay_change, Fprevious_overlay_change)
6667 (mouse_face_overlay_overlaps, Foverlays_in):
6668 Use ptrdiff_t, not int, for sizes.
6669 (overlays_at, overlays_in): Check for size-calculation overflow.
6671 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
6673 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
6674 (x_session_initialize): Do not assume string length fits in int.
6676 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
6677 This is unlikely, but can occur if DPI is outlandish.
6679 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
6680 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
6682 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
6683 * xrdb.c (magic_file_p, search_magic_path):
6684 Omit last arg SUFFIX; it was always 0. All callers changed.
6685 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
6687 * xfont.c (xfont_match): Avoid need for strlen.
6689 * xfns.c: Don't assume strlen fits in int.
6690 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
6692 * xdisp.c (message_log_check_duplicate): Return intmax_t,
6693 not unsigned long, as we prefer signed integers. All callers changed.
6694 Detect integer overflow in repeat count.
6695 (message_dolog): Don't assume print length fits in 39 bytes.
6696 (display_mode_element): Don't assume strlen fits in int.
6698 * termcap.c: Don't assume sizes fit in int and never overflow.
6699 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
6700 (gobble_line): Check for size-calculation overflow.
6702 * minibuf.c (Fread_buffer):
6703 * lread.c (intern, intern_c_string):
6704 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
6705 Don't assume string length fits in int.
6707 * keyboard.c (parse_tool_bar_item):
6708 * gtkutil.c (style_changed_cb): Avoid need for strlen.
6710 * font.c: Don't assume string length fits in int.
6711 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
6712 Use ptrdiff_t, not int.
6713 (font_intern_prop): Don't assume string length fits in int.
6714 Don't assume integer property fits in fixnum.
6715 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
6717 * filelock.c: Fix some buffer overrun and integer overflow issues.
6718 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
6719 Reformulate so as not to need the command string.
6720 Invoke gzip -cd rather than gunzip, as it's more portable.
6721 (lock_info_type, lock_file_1, lock_file):
6722 Don't assume pid_t and time_t fit in unsigned long.
6723 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
6724 (current_lock_owner): Prefer signed type for sizes.
6725 Use memcpy, not strncpy, where memcpy is what is really wanted.
6726 Don't assume (via atoi) that time_t and pid_t fit in int.
6727 Check for time_t and/or pid_t out of range, e.g., via a network share.
6728 Don't alloca where an auto var works fine.
6730 * fileio.c: Fix some integer overflow issues.
6731 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
6732 Don't assume string length fits in int.
6733 (directory_file_name): Don't assume string length fits in long.
6734 (make_temp_name): Don't assume pid fits in int, or that its print
6735 length is less than 20.
6737 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
6739 * coding.c (make_subsidiaries): Don't assume string length fits in int.
6741 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
6743 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
6744 We prefer signed integers, even for size calculations.
6746 * emacs.c: Don't assume string length fits in 'int'.
6747 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
6748 (main): Don't invoke strlen when not needed.
6750 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
6751 (XD_DEBUG_MESSAGE): Don't waste a byte.
6753 * callproc.c (getenv_internal_1, getenv_internal)
6755 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
6757 * lread.c (invalid_syntax): Omit length argument.
6758 All uses changed. This doesn't fix a bug, but it simplifies the
6759 code away from its former Hollerith-constant appearance, and it's
6760 one less 'int' to worry about when looking at integer-overflow issues.
6761 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
6763 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
6764 This didn't break anything, but it didn't help either.
6765 It's confusing to put a bogus integer in a place where the actual
6766 value does not matter.
6767 (LIST_END_P): Remove unused macro and its bogus comment.
6768 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
6770 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
6771 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
6773 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
6774 We prefer signed types, and the value cannot exceed the EMACS_INT
6775 range anyway (because otherwise the length would not be representable).
6776 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
6777 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
6778 This avoids a GCC warning when WIDE_EMACS_INT.
6780 * indent.c (sane_tab_width): New function.
6781 (current_column, scan_for_column, Findent_to, position_indentation)
6782 (compute_motion): Use it. This is just for clarity.
6783 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
6785 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
6787 * lisp.h (lint_assume): New macro.
6788 * composite.c (composition_gstring_put_cache):
6789 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
6791 * editfns.c, insdel.c:
6792 Omit unnecessary forward decls, to simplify future changes.
6794 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
6796 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
6798 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
6799 Use much-faster test for byte-length change.
6800 Don't assume string byte-length fits in 'int'.
6801 Check that character arg fits in 'int'.
6802 (mapcar1): Declare byte as byte, for clarity.
6804 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
6806 * fns.c (concat): Catch string overflow earlier.
6807 Do not rely on integer wraparound.
6809 * dispextern.h (struct it.overlay_strings_charpos)
6810 (struct it.selective): Now EMACS_INT, not int.
6811 * xdisp.c (forward_to_next_line_start)
6812 (back_to_previous_visible_line_start)
6813 (reseat_at_next_visible_line_start, next_element_from_buffer):
6814 Don't arbitrarily truncate the value of 'selective' to int.
6816 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
6818 * composite.c: Don't truncate sizes to 'int'.
6819 (composition_gstring_p, composition_reseat_it)
6820 (composition_adjust_point): Use EMACS_INT, not int.
6821 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
6822 not EMACS_UINT, for indexes.
6824 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
6826 * buffer.c: Include <verify.h>.
6827 (struct sortvec.priority, struct sortstr.priority):
6828 Now EMACS_INT, not int.
6829 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
6830 (struct sortstr.size, record_overlay_string)
6831 (struct sortstrlist.size, struct sortlist.used):
6832 Don't truncate size to int.
6833 (record_overlay_string): Check for size-calculation overflow.
6834 (init_buffer_once): Check at compile-time, not run-time.
6836 2011-06-22 Jim Meyering <meyering@redhat.com>
6838 Don't leak an XBM-image-sized buffer
6839 * image.c (xbm_load): Free the image buffer after using it.
6841 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
6844 * composite.c (find_automatic_composition): Omit needless 'return 0;'
6845 that Sun C diagnosed.
6846 * fns.c (secure_hash): Fix pointer signedness issue.
6847 * intervals.c (static_offset_intervals): New function.
6848 (offset_intervals): Use it.
6850 2011-06-21 Leo Liu <sdl.web@gmail.com>
6853 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
6856 * fns.c (secure_hash): Rename from crypto_hash_function and change
6857 the first arg to accept symbols.
6858 (Fsecure_hash): New primitive.
6859 (syms_of_fns): New symbols.
6861 2011-06-20 Deniz Dogan <deniz@dogan.se>
6863 * process.c (Fset_process_buffer): Clarify return value in
6866 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
6868 * dispnew.c (add_window_display_history): Use BVAR.
6870 * xdisp.c (debug_method_add): Use BVAR.
6871 (check_window_end, dump_glyph_matrix, dump_glyph)
6872 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
6874 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
6877 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
6878 check till after the cache is created in init_frame_faces.
6880 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
6882 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
6884 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
6886 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
6887 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
6888 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
6890 Improve buffer-overflow checking (Bug#8873).
6891 * fileio.c (Finsert_file_contents):
6892 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
6893 Remove the old (too-loose) buffer overflow checks.
6894 They weren't needed, since make_gap checks for buffer overflow.
6895 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
6896 The old code merely checked for Emacs fixnum overflow, and relied
6897 on undefined (wraparound) behavior. The new code avoids undefined
6898 behavior, and also checks for ptrdiff_t and/or size_t overflow.
6900 * editfns.c (Finsert_char): Don't dump core with very negative counts.
6901 Tune. Don't use wider integers than needed. Don't use alloca.
6902 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
6904 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
6906 * insdel.c, lisp.h (buffer_overflow): New function.
6907 (insert_from_buffer_1, replace_range, replace_range_2):
6908 * insdel.c (make_gap_larger):
6909 * editfns.c (Finsert_char):
6910 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
6912 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
6914 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
6916 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
6918 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
6919 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
6921 * fileio.c: Don't assume EMACS_INT fits in off_t.
6922 (emacs_lseek): New static function.
6923 (Finsert_file_contents, Fwrite_region): Use it.
6924 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
6926 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
6928 * fns.c: Don't overflow int when computing a list length.
6929 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
6930 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
6931 truncation on 64-bit hosts. Check for QUIT every
6932 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
6933 faster and is responsive enough.
6934 (Flength): Report an error instead of overflowing an integer.
6935 (Fsafe_length): Return a float if the value is not representable
6936 as a fixnum. This shouldn't happen except in contrived situations.
6937 (Fnthcdr, Fsort): Don't assume list length fits in int.
6938 (Fcopy_sequence): Don't assume vector length fits in int.
6940 * alloc.c: Check that resized vectors' lengths fit in fixnums.
6941 (header_size, word_size): New constants.
6942 (allocate_vectorlike): Don't check size overflow here.
6943 (allocate_vector): Check it here instead, since this is the only
6944 caller of allocate_vectorlike that could cause overflow.
6945 Check that the new vector's length is representable as a fixnum.
6947 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
6948 The previous code was bogus. For example, next_almost_prime (32)
6949 returned 39, which is undesirable as it is a multiple of 3; and
6950 next_almost_prime (24) returned 25, which is a multiple of 5 so
6951 why was the code bothering to check for multiples of 7?
6953 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
6955 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
6957 Variadic C functions now count arguments with ptrdiff_t.
6958 This partly undoes my 2011-03-30 change, which replaced int with size_t.
6959 Back then I didn't know that the Emacs coding style prefers signed int.
6960 Also, in the meantime I found a few more instances where arguments
6961 were being counted with int, which may truncate counts on 64-bit
6962 machines, or EMACS_INT, which may be unnecessarily wide.
6963 * lisp.h (struct Lisp_Subr.function.aMANY)
6964 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
6965 Arg counts are now ptrdiff_t, not size_t.
6966 All variadic functions and their callers changed accordingly.
6967 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
6968 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
6969 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
6970 * callint.c (Fcall_interactively): Check arg count for overflow,
6971 to avoid potential buffer overrun. Use signed char, not 'int',
6972 for 'varies' array, so that we needn't bother to check its size
6973 calculation for overflow.
6974 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
6975 * eval.c (apply_lambda):
6976 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
6977 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
6978 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
6980 * callint.c (Fcall_interactively): Don't use index var as event count.
6982 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
6983 * mem-limits.h (SIZE): Remove; no longer used.
6985 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
6987 Remove unnecessary casts.
6988 * xterm.c (x_term_init):
6989 * xfns.c (x_set_border_pixel):
6990 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
6991 These aren't needed now that we assume ANSI C.
6993 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
6994 It's more likely to cause problems (due to unsigned overflow)
6997 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
6999 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
7001 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
7003 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
7005 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
7007 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
7009 GLYPH_CODE_FACE returns EMACS_INT, not int.
7010 * dispextern.h (merge_faces):
7011 * xfaces.c (merge_faces):
7012 * xdisp.c (get_next_display_element, next_element_from_display_vector):
7013 Don't assume EMACS_INT fits in int.
7015 * character.h (CHAR_VALID_P): Remove unused parameter.
7016 * fontset.c, lisp.h, xdisp.c: All uses changed.
7018 * editfns.c (Ftranslate_region_internal): Omit redundant test.
7020 * fns.c (concat): Minor tuning based on overflow analysis.
7021 This doesn't fix any bugs. Use int to hold character, instead
7022 of constantly refetching from Emacs object. Use XFASTINT, not
7023 XINT, for value known to be a character. Don't bother comparing
7024 a single byte to 0400, as it's always less.
7026 * floatfns.c (Fexpt):
7027 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
7029 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
7032 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
7034 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
7035 Without this fix, on a 64-bit host (aset S 0 4294967386) would
7036 incorrectly succeed when S was a string, because 4294967386 was
7037 truncated before it was used.
7039 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
7040 Otherwise, an out-of-range integer could cause undefined behavior
7043 * composite.c: Use int, not EMACS_INT, for characters.
7044 (fill_gstring_body, composition_compute_stop_pos): Use int, not
7045 EMACS_INT, for values that are known to be in character range.
7046 This doesn't fix any bugs but is the usual style inside Emacs and
7047 may generate better code on 32-bit machines.
7049 Make sure a 64-bit char is never passed to ENCODE_CHAR.
7050 This is for reasons similar to the recent CHAR_STRING fix.
7051 * charset.c (Fencode_char): Check that character arg is actually
7052 a character. Pass an int to ENCODE_CHAR.
7053 * charset.h (ENCODE_CHAR): Verify that the character argument is no
7054 wider than 'int', as a compile-time check to prevent future regressions
7057 * character.c (char_string): Remove unnecessary casts.
7059 Make sure a 64-bit char is never passed to CHAR_STRING.
7060 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
7061 by silently ignoring the top 32 bits, allowing some values
7062 that were far too large to be valid characters.
7063 * character.h: Include <verify.h>.
7064 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
7065 arguments are no wider than unsigned, as a compile-time check
7066 to prevent future regressions in this area.
7068 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
7069 (Fsubst_char_in_region):
7071 * xdisp.c (decode_mode_spec_coding):
7072 Adjust to CHAR_STRING's new requirement.
7073 * editfns.c (Finsert_char, Fsubst_char_in_region):
7074 * fns.c (concat): Check that character args are actually
7075 characters. Without this test, these functions did the wrong
7076 thing with wildly out-of-range values on 64-bit hosts.
7078 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
7079 These casts should not be needed on 32-bit hosts, either.
7080 * keyboard.c (read_char):
7081 * lread.c (Fload): Remove casts to unsigned.
7083 * lisp.h (UNSIGNED_CMP): New macro.
7084 This fixes comparison bugs on 64-bit hosts.
7085 (ASCII_CHAR_P): Use it.
7086 * casefiddle.c (casify_object):
7087 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
7088 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
7089 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
7090 * dispextern.h (FACE_FROM_ID):
7091 * keyboard.c (read_char): Use UNSIGNED_CMP.
7093 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
7094 not to EMACS_INT, to avoid GCC warning.
7096 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
7098 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
7099 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
7100 isn't needed on 32-bit machines.
7102 * buffer.c (Fgenerate_new_buffer_name):
7103 Use EMACS_INT for count, not int.
7104 (advance_to_char_boundary): Return EMACS_INT, not int.
7106 * data.c (Qcompiled_function): Now static.
7108 * window.c (window_body_lines): Now static.
7110 * image.c (gif_load): Rename local to avoid shadowing.
7112 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
7113 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
7114 * alloc.c (make_save_value): Integer argument is now of type
7116 (mark_object): Use ptrdiff_t, not int.
7117 * lisp.h (pD): New macro.
7118 * print.c (print_object): Use it.
7120 * alloc.c: Use EMACS_INT, not int, to count objects.
7121 (total_conses, total_markers, total_symbols, total_vector_size)
7122 (total_free_conses, total_free_markers, total_free_symbols)
7123 (total_free_floats, total_floats, total_free_intervals)
7124 (total_intervals, total_strings, total_free_strings):
7125 Now EMACS_INT, not int. All uses changed.
7126 (Fgarbage_collect): Compute overall total using a double, so that
7127 integer overflow is less likely to be a problem. Check for overflow
7128 when converting back to an integer.
7129 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
7130 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
7131 These were 'int' variables that could overflow on 64-bit hosts;
7132 they were never used, so remove them instead of repairing them.
7133 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
7134 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
7135 Previously, this ceilinged at INT_MAX, but that doesn't work on
7137 (allocate_pseudovector): Don't use EMACS_INT when int would do.
7139 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
7140 (allocate_vectorlike): Check for ptrdiff_t overflow.
7141 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
7142 when a (possibly-narrower) signed value would do just as well.
7143 We prefer using signed arithmetic, to avoid comparison confusion.
7145 * alloc.c: Catch some string size overflows that we were missing.
7146 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
7147 for convenience in STRING_BYTES_MAX.
7148 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
7149 The definition here is exact; the one in lisp.h was approximate.
7150 (allocate_string_data): Check for string overflow. This catches
7151 some instances we weren't catching before. Also, it catches
7152 size_t overflow on (unusual) hosts where SIZE_MAX <= min
7153 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
7154 and ptrdiff_t and EMACS_INT are both 64 bits.
7156 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
7157 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
7158 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
7160 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
7162 * alloc.c (Fmake_string): Check for out-of-range init.
7164 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
7166 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
7168 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
7170 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
7171 xg_get_default_scrollbar_width.
7173 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
7174 (int_gtk_range_get_value): Move to the scroll bar part of the file.
7175 (style_changed_cb): Call update_theme_scrollbar_width and call
7176 x_set_scroll_bar_default_width and xg_frame_set_char_size for
7177 all frames (Bug#8505).
7178 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
7179 Call gtk_window_set_resizable if HAVE_GTK3.
7180 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
7181 and height if HAVE_GTK3 (Bug#8505).
7182 (scroll_bar_width_for_theme): New variable.
7183 (update_theme_scrollbar_width): New function.
7184 (xg_get_default_scrollbar_width): Move code to
7185 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
7186 (xg_initialize): Call update_theme_scrollbar_width.
7188 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
7190 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
7192 2011-06-12 Martin Rudalics <rudalics@gmx.at>
7194 * frame.c (make_frame): Call other_buffer_safely instead of
7197 * window.c (temp_output_buffer_show): Call display_buffer with
7198 second argument Vtemp_buffer_show_specifiers and reset latter
7199 immediately after the call.
7200 (Vtemp_buffer_show_specifiers): New variable.
7201 (auto_window_vscroll_p, next_screen_context_lines)
7202 (Vscroll_preserve_screen_position): Remove leading asterisks from
7205 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
7207 Fix minor problems found by GCC 4.6.0 static checking.
7208 * buffer.c (Qclone_number): Remove for now, as it's unused.
7209 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
7210 (record_buffer): Remove unused local.
7211 * frame.c (other_visible_frames, frame_buffer_list): Now static.
7212 (set_frame_buffer_list): Remove; unused.
7213 * frame.h (other_visible_frames): Remove decl.
7214 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
7215 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
7216 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
7218 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
7219 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
7220 Define only if HAVE_GPM.
7221 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
7222 (update_hints_inhibit): Remove; never set. All uses removed.
7223 * widgetprv.h (emacsFrameClassRec): Remove decl.
7224 * window.c (delete_deletable_window): Now returns void, since it
7225 wasn't returning anything.
7226 (compare_window_configurations): Remove unused locals.
7227 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
7228 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
7229 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
7230 the same widths as pointers. This follows up on the 2011-05-06 patch.
7231 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
7232 * xterm.h: Likewise.
7233 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
7235 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
7237 * makefile.w32-in: Update dependencies.
7238 (LISP_H): Add lib/intprops.h.
7240 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
7242 * image.c (gif_load): Add animation frame delay to the metadata.
7243 (syms_of_image): Use DEFSYM. New symbol `delay'.
7245 2011-06-11 Martin Rudalics <rudalics@gmx.at>
7247 * window.c (delete_deletable_window): Re-add.
7248 (Fset_window_configuration): Rewrite to handle dead buffers and
7249 consequently deletable windows.
7250 (window_tree, Fwindow_tree): Remove. Supply functionality in
7252 (compare_window_configurations): Simplify code.
7254 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
7256 * image.c (imagemagick_load_image): Fix type mismatch.
7257 (Fimagemagick_types): Likewise.
7259 * window.h (replace_buffer_in_windows): Declare.
7261 2011-06-11 Martin Rudalics <rudalics@gmx.at>
7263 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
7264 Qclone_number. Remove external declaration of Qdelete_window.
7265 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
7267 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
7268 Run Qbuffer_list_update_hook if allowed.
7269 (Fother_buffer): Rewrite doc-string. Major rewrite for new
7270 buffer list implementation.
7271 (other_buffer_safely): New function.
7272 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
7273 calls to replace_buffer_in_windows and
7274 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
7276 (record_buffer): Inhibit quitting and rewrite using quittable
7277 functions. Run Qbuffer_list_update_hook if allowed.
7278 (Frecord_buffer, Funrecord_buffer): New functions.
7279 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
7280 Move switch-to-buffer to window.el.
7281 (bury-buffer): Move to window.el.
7282 (Vbuffer_list_update_hook): New variable.
7284 * lisp.h (other_buffer_safely): Add prototype in buffer.c
7287 * window.h (resize_frame_windows): Move up in code.
7288 (Fwindow_frame): Remove EXFUN.
7289 (replace_buffer_in_all_windows): Remove prototype.
7290 (replace_buffer_in_windows_safely): Add prototype.
7292 * window.c: Declare Qdelete_window static again. Move down
7293 declaration of select_count.
7294 (Fnext_window, Fprevious_window): Rewrite doc-strings.
7295 (Fother_window): Move to window.el.
7296 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
7297 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
7298 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
7300 (replace_buffer_in_windows): Implement by calling
7301 Qreplace_buffer_in_windows.
7302 (replace_buffer_in_all_windows): Remove with some functionality
7303 moved into replace_buffer_in_windows_safely.
7304 (replace_buffer_in_windows_safely): New function.
7305 (select_window_norecord, select_frame_norecord): Move in front
7306 of run_window_configuration_change_hook. Remove now obsolete
7308 (Fset_window_buffer): Rewrite doc-string.
7309 Call Qrecord_window_buffer.
7310 (keys_of_window): Move binding for other-window to window.el.
7312 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
7314 * dispextern.h (struct image): Replace data member, whose int_val
7315 and ptr_val fields were not used by anything, with a single
7318 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
7319 (gif_clear_image, gif_load, imagemagick_load_image)
7320 (gs_clear_image, gs_load): Callers changed.
7322 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
7324 * buffer.h: Include <time.h>, for time_t.
7325 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
7327 Fix minor problems found by static checking.
7329 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
7331 Make identifiers static if they are not used in other modules.
7332 * data.c (Qcompiled_function, Qframe, Qvector):
7333 * image.c (QimageMagick, Qsvg):
7334 * minibuf.c (Qmetadata):
7335 * window.c (resize_window_check, resize_root_window): Now static.
7336 * window.h (resize_window_check, resize_root_window): Remove decls.
7338 * window.c (window_deletion_count, delete_deletable_window):
7340 (window_body_lines): Now static.
7341 (Fdelete_other_windows_internal): Mark vars as initialized.
7342 Make sure 'resize_failed' is initialized.
7343 (run_window_configuration_change_hook): Rename local to avoid shadowing.
7344 (resize_window_apply): Remove unused local.
7345 * window.h (delete_deletable_window): Remove decl.
7347 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
7348 (imagemagick_load_image): Fix pointer signedness problem by changing
7349 last arg from unsigned char * to char *. All uses changed.
7350 Also, fix a local for similar reasons.
7351 Remove unused locals. Remove locals to avoid shadowing.
7352 (fn_rsvg_handle_free): Remove; unused.
7353 (svg_load, svg_load_image): Fix pointer signedness problem.
7354 (imagemagick_load_image): Don't use garbage pointer image_wand.
7356 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
7358 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
7360 * image.c (gif_load): Fix omitted cast error introduced by
7363 2011-06-10 Martin Rudalics <rudalics@gmx.at>
7365 * window.h (resize_proportionally, orig_total_lines)
7366 (orig_top_line): Remove from window structure.
7367 (set_window_height, set_window_width, change_window_heights)
7368 (Fdelete_window): Remove prototypes.
7369 (resize_frame_windows): Remove duplicate declaration.
7371 2011-06-10 Eli Zaretskii <eliz@gnu.org>
7373 * window.h (resize_frame_windows, resize_window_check)
7374 (delete_deletable_window, resize_root_window)
7375 (resize_frame_windows): Declare prototypes.
7377 * window.c (resize_window_apply): Make definition be "static" to
7378 match the prototype.
7380 2011-06-10 Martin Rudalics <rudalics@gmx.at>
7382 * window.c: Remove declarations of Qwindow_size_fixed,
7383 window_min_size_1, window_min_size_2, window_min_size,
7384 size_window, window_fixed_size_p, enlarge_window, delete_window.
7385 Remove static from declaration of Qdelete_window, it's
7386 temporarily needed by Fbury_buffer.
7387 (replace_window): Don't assign orig_top_line and
7389 (Fdelete_window, delete_window): Remove. Window deletion is
7390 handled by window.el.
7391 (window_loop): Remove DELETE_OTHER_WINDOWS case.
7392 Replace Fdelete_window calls with calls to Qdelete_window.
7393 (Fdelete_other_windows): Remove. Deleting other windows is
7394 handled by window.el.
7395 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
7396 handled in window.el.
7397 (window_min_size_2, window_min_size_1, window_min_size): Remove.
7398 Window minimum sizes are handled in window.el.
7399 (shrink_windows, size_window, set_window_height)
7400 (set_window_width, change_window_heights, window_height)
7401 (window_width, CURBEG, CURSIZE, enlarge_window)
7402 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
7403 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
7404 handled in window.el.
7405 (make_dummy_parent): Rename to make_parent_window and give it a
7406 second argument horflag.
7407 (make_window): Don't set resize_proportionally any more.
7408 (Fsplit_window): Remove. Windows are split in window.el.
7409 (save_restore_action, save_restore_orig_size)
7410 (shrink_window_lowest_first, save_restore_orig_size): Remove.
7411 Resize mini windows in window.el.
7412 (grow_mini_window, shrink_mini_window): Implement by calling
7413 Qresize_root_window_vertically, resize_window_check and
7414 resize_window_apply.
7415 (saved_window, Fset_window_configuration, save_window_save):
7416 Do not handle orig_top_line, orig_total_lines, and
7417 resize_proportionally.
7418 (window_min_height, window_min_width): Move to window.el.
7419 (keys_of_window): Move bindings for delete-other-windows,
7420 split-window, delete-window and enlarge-window to window.el.
7422 * buffer.c: Temporarily extern Qdelete_window.
7423 (Fbury_buffer): Temporarily call Qdelete_window instead of
7424 Fdelete_window (Fbury_buffer will move to window.el soon).
7426 * frame.c (set_menu_bar_lines_1): Remove code handling
7427 orig_top_line and orig_total_lines.
7429 * dispnew.c (adjust_frame_glyphs_initially): Don't use
7430 set_window_height but set heights directly.
7431 (change_frame_size_1): Use resize_frame_windows.
7433 * xdisp.c (init_xdisp): Don't use set_window_height but set
7436 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
7437 Use resize_frame_windows instead of change_window_heights and run
7438 run_window_configuration_change_hook.
7440 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
7441 instead of change_window_heights and run
7442 run_window_configuration_change_hook.
7444 2011-06-09 Martin Rudalics <rudalics@gmx.at>
7446 * window.c (replace_window): Rename second argument REPLACEMENT to
7447 NEW. New third argument SETFLAG. Rewrite.
7448 (delete_window, make_dummy_parent): Call replace_window with
7450 (window_list_1): Move down in code.
7451 (run_window_configuration_change_hook): Move set_buffer part
7452 before select_frame_norecord part in order to unwind correctly.
7453 Rename count1 to count.
7454 (recombine_windows, delete_deletable_window, resize_root_window)
7455 (Fdelete_other_windows_internal)
7456 (Frun_window_configuration_change_hook, make_parent_window)
7457 (resize_window_check, resize_window_apply, Fresize_window_apply)
7458 (resize_frame_windows, Fsplit_window_internal)
7459 (Fdelete_window_internal, Fresize_mini_window_internal):
7461 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
7463 2011-06-08 Martin Rudalics <rudalics@gmx.at>
7465 * window.h (window): Add some new members to window structure -
7466 normal_lines, normal_cols, new_total, new_normal, clone_number,
7467 splits, nest, prev_buffers, next_buffers.
7468 (WINDOW_TOTAL_SIZE): Move here from window.c.
7469 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
7471 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
7473 (make_dummy_parent): Set new members of windows structure.
7474 (make_window): Move down in code. Handle new members of window
7476 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
7477 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
7478 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
7479 (Fset_window_prev_buffers, Fwindow_next_buffers)
7480 (Fset_window_next_buffers, Fset_window_clone_number):
7482 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
7483 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
7485 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
7486 Argument WINDOW can be now internal window too.
7487 (Fwindow_use_time): Move up in code.
7488 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
7490 (Fset_window_configuration, saved_window)
7491 (Fcurrent_window_configuration, save_window_save): Handle new
7492 members of window structure.
7493 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
7494 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
7495 (syms_of_window): New Lisp objects Qrecord_window_buffer,
7496 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
7497 Qget_mru_window, Qresize_root_window,
7498 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
7499 Qauto_buffer_name; staticpro them.
7501 2011-06-07 Martin Rudalics <rudalics@gmx.at>
7503 * window.c (Fwindow_total_size, Fwindow_left_column)
7504 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
7505 (Fwindow_list_1): New functions.
7506 (window_box_text_cols): Replace with window_body_cols.
7507 (Fwindow_width, Fscroll_left, Fscroll_right):
7508 Use window_body_cols instead of window_box_text_cols.
7509 (delete_window, Fset_window_configuration):
7510 Call delete_all_subwindows with window as argument.
7511 (delete_all_subwindows): Take a window as argument and not a
7513 (window_loop): Remove handling of GET_LRU_WINDOW and
7515 (Fget_lru_window, Fget_largest_window): Move to window.el.
7517 * window.h: Extern window_body_cols instead of
7518 window_box_text_cols. delete_all_subwindows now takes a
7519 Lisp_Object as argument.
7521 * indent.c (compute_motion, Fcompute_motion):
7522 Use window_body_cols instead of window_box_text_cols.
7524 * frame.c (delete_frame): Call delete_all_subwindows with root
7527 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
7529 * fns.c (Fputhash): Document return value.
7531 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
7533 * image.c (gif_load): Implement gif89a spec "no disposal" method.
7535 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7537 Cons<->int and similar integer overflow fixes (Bug#8794).
7539 Check for overflow when converting integer to cons and back.
7540 * charset.c (Fdefine_charset_internal, Fdecode_char):
7541 Use cons_to_unsigned to catch overflow.
7542 (Fencode_char): Use INTEGER_TO_CONS.
7543 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
7544 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
7545 * data.c (long_to_cons, cons_to_long): Remove.
7546 (cons_to_unsigned, cons_to_signed): New functions.
7547 These signal an error for invalid or out-of-range values.
7548 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
7549 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
7550 * font.c (Ffont_variation_glyphs):
7551 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
7552 * lisp.h: Include <intprops.h>.
7553 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
7554 (cons_to_signed, cons_to_unsigned): New decls.
7555 (long_to_cons, cons_to_long): Remove decls.
7556 * undo.c (record_first_change): Use INTEGER_TO_CONS.
7557 (Fprimitive_undo): Use CONS_TO_INTEGER.
7558 * xfns.c (Fx_window_property): Likewise.
7559 * xselect.c: Include <limits.h>.
7560 (x_own_selection, selection_data_to_lisp_data):
7561 Use INTEGER_TO_CONS.
7562 (x_handle_selection_request, x_handle_selection_clear)
7563 (x_get_foreign_selection, Fx_disown_selection_internal)
7564 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
7565 (lisp_data_to_selection_data): Use cons_to_unsigned.
7566 (x_fill_property_data): Use cons_to_signed.
7567 Report values out of range.
7569 Check for buffer and string overflow more precisely.
7570 * buffer.h (BUF_BYTES_MAX): New macro.
7571 * lisp.h (STRING_BYTES_MAX): New macro.
7572 * alloc.c (Fmake_string):
7573 * character.c (string_escape_byte8):
7574 * coding.c (coding_alloc_by_realloc):
7575 * doprnt.c (doprnt):
7576 * editfns.c (Fformat):
7578 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
7579 since they may not be the same number.
7580 * editfns.c (Finsert_char):
7581 * fileio.c (Finsert_file_contents):
7582 Likewise for BUF_BYTES_MAX.
7584 * image.c: Use ptrdiff_t, not int, for sizes.
7585 (slurp_file): Switch from int to ptrdiff_t.
7587 (slurp_file): Check that file size fits in both size_t (for
7588 malloc) and ptrdiff_t (for sanity and safety).
7590 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
7591 if b->modtime has its maximal value.
7593 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
7595 Don't assume time_t can fit into int.
7596 * buffer.h (struct buffer.modtime): Now time_t, not int.
7597 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
7598 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
7600 Minor fixes for signed vs unsigned integers.
7601 * character.h (MAYBE_UNIFY_CHAR):
7602 * charset.c (maybe_unify_char):
7603 * keyboard.c (read_char, reorder_modifiers):
7604 XINT -> XFASTINT, since the integer must be nonnegative.
7605 * ftfont.c (ftfont_spec_pattern):
7606 * keymap.c (access_keymap, silly_event_symbol_error):
7607 XUINT -> XFASTINT, since the integer must be nonnegative.
7608 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
7609 since it makes no difference and we prefer signed.
7610 * keyboard.c (record_char): Use XUINT when all the neighbors do.
7611 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
7614 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
7616 * window.h (Fwindow_frame): Declare.
7618 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7620 * alloc.c: Simplify handling of large-request failures (Bug#8800).
7621 (SPARE_MEMORY): Always define.
7622 (LARGE_REQUEST): Remove.
7623 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
7625 2011-06-06 Martin Rudalics <rudalics@gmx.at>
7627 * lisp.h: Move EXFUNS for Fframe_root_window,
7628 Fframe_first_window and Fset_frame_selected_window to window.h.
7630 * window.h: Move EXFUNS for Fframe_root_window,
7631 Fframe_first_window and Fset_frame_selected_window here from
7634 * frame.c (Fwindow_frame, Fframe_first_window)
7635 (Fframe_root_window, Fframe_selected_window)
7636 (Fset_frame_selected_window): Move to window.c.
7637 (Factive_minibuffer_window): Move to minibuf.c.
7638 (Fother_visible_frames_p): New function.
7640 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
7642 * window.c (decode_window, decode_any_window): Move up in code.
7643 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
7644 (inhibit_frame_unsplittable): Remove unused variable.
7645 (Fwindow_buffer): Move up and rewrite doc-string.
7646 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
7647 (Fwindow_prev): New functions.
7648 (Fwindow_frame): Move here from frame.c. Accept any window as
7650 (Fframe_root_window, Fframe_first_window)
7651 (Fframe_selected_window): Move here from frame.c. Accept frame
7652 or arbitrary window as argument. Update doc-strings.
7653 (Fminibuffer_window): Move up in code.
7654 (Fwindow_minibuffer_p): Move up in code and simplify.
7655 (Fset_frame_selected_window): Move here from frame.c.
7657 (Fselected_window, select_window, Fselect_window): Move up in
7658 code. Minor doc-string fixes.
7660 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7662 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
7663 Do not assume that spare memory exists; that assumption is valid
7664 only if SYSTEM_MALLOC.
7665 (LARGE_REQUEST): New macro, so that the issue of large requests
7666 is separated from the issue of spare memory.
7668 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
7670 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
7673 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
7675 * xfns.c (x_set_scroll_bar_default_width): Move declarations
7678 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
7680 * gtkutil.c (xg_get_default_scrollbar_width): New function.
7682 * gtkutil.h: Declare xg_get_default_scrollbar_width.
7684 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
7685 min width by calling x_set_scroll_bar_default_width (Bug#8505).
7687 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
7689 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
7691 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
7693 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
7694 (x_clipboard_manager_save): Add return value.
7695 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
7697 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
7698 Obey Vx_select_enable_clipboard_manager. Catch errors in
7699 x_clipboard_manager_save (Bug#8779).
7700 (Vx_select_enable_clipboard_manager): New variable.
7701 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
7703 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
7705 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
7707 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7709 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
7710 in the current matrix if keep_current_p is non-zero.
7712 2011-06-04 Eli Zaretskii <eliz@gnu.org>
7714 * bidi.c (bidi_level_of_next_char): Fix last change.
7716 2011-06-03 Eli Zaretskii <eliz@gnu.org>
7718 Support bidi reordering of text covered by display properties.
7720 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
7721 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
7722 (bidi_cache_search, bidi_cache_iterator_state)
7723 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
7724 (bidi_level_of_next_char, bidi_move_to_visually_next):
7725 Support character positions inside a run of characters covered by a
7727 (bidi_paragraph_init, bidi_resolve_explicit_1)
7728 (bidi_level_of_next_char): Call bidi_fetch_char and
7729 bidi_fetch_char_advance instead of FETCH_CHAR and
7731 (bidi_init_it): Initialize new members.
7732 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
7734 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
7735 instead of using explicit *_CHAR codes.
7736 (bidi_resolve_explicit, bidi_resolve_weak):
7737 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
7738 bidirectional text is supported only in multibyte buffers.
7739 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
7740 it to initialize the frame_window_p member of struct bidi_it.
7741 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
7742 (bidi_resolve_explicit, bidi_resolve_weak)
7743 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
7744 bidi_it->nchars is non-positive.
7745 (bidi_level_of_next_char): Don't try to lookup the cache for the
7746 next/previous character if nothing is cached there yet, or if we
7747 were just reseat()'ed to a new position.
7749 * xdisp.c (set_cursor_from_row): Set start and stop points
7750 according to the row's direction when priming the loop that looks
7751 for the glyph on which to display cursor.
7752 (single_display_spec_intangible_p): Function deleted.
7753 (display_prop_intangible_p): Reimplement to call
7754 handle_display_spec instead of single_display_spec_intangible_p.
7755 Accept 3 additional arguments needed by handle_display_spec.
7756 This fixes incorrect cursor motion across display property with complex
7757 values: lists, `(when COND...)' forms, etc.
7758 (single_display_spec_string_p): Support property values that are
7759 lists with the argument STRING its top-level element.
7760 (display_prop_string_p): Fix the condition for processing a
7761 property that is a list to be consistent with handle_display_spec.
7762 (handle_display_spec): New function, refactored from the
7763 last portion of handle_display_prop.
7764 (compute_display_string_pos): Accept additional argument
7765 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
7766 value of a `display' property is a "replacing spec".
7767 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
7768 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
7769 the display property, but just return a value indicating whether
7770 the display property will replace the characters it covers.
7771 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
7772 frame_window_p members of struct bidi_it.
7773 (compute_display_string_pos, compute_display_string_end):
7775 (push_it): Accept second argument POSITION, where pop_it should
7776 jump to continue iteration.
7777 (reseat_1): Initialize bidi_it.disp_pos.
7779 * keyboard.c (adjust_point_for_property): Adjust the call to
7780 display_prop_intangible_p to its new signature.
7782 * dispextern.h (struct bidi_it): New member frame_window_p.
7783 (bidi_init_it): Update prototypes.
7784 (display_prop_intangible_p): Update prototype.
7785 (compute_display_string_pos, compute_display_string_end):
7787 (struct bidi_it): New members nchars and disp_pos. ch_len is now
7790 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
7792 Malloc failure behavior now depends on size of allocation.
7793 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
7794 * lisp.h: Change signatures accordingly.
7795 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
7796 All callers changed. (Bug#8762)
7798 * gnutls.c: Use Emacs's memory allocators.
7799 Without this change, the gnutls library would invoke malloc etc.
7800 directly, which causes problems on non-SYNC_INPUT hosts, and which
7801 runs afoul of improving memory_full behavior. (Bug#8761)
7802 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
7803 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
7804 xfree instead of the default malloc, realloc, free.
7805 (Fgnutls_boot): No need to check for memory allocation failure,
7806 since xmalloc does that for us.
7808 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
7809 * category.c (hash_get_category_set):
7810 * ccl.c (ccl_driver):
7811 * charset.c (Fdefine_charset_internal):
7812 * charset.h (struct charset.hash_index):
7813 * composite.c (get_composition_id, gstring_lookup_cache)
7814 (composition_gstring_put_cache):
7815 * composite.h (struct composition.hash_index):
7816 * dispextern.h (struct image.hash):
7817 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
7818 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
7819 (hashfn_equal, hashfn_user_defined, make_hash_table)
7820 (maybe_resize_hash_table, hash_lookup, hash_put)
7821 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
7822 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
7823 (Fsxhash, Fgethash, Fputhash, Fmaphash):
7824 * image.c (make_image, search_image_cache, lookup_image)
7825 (xpm_put_color_table_h):
7826 * lisp.h (struct Lisp_Hash_Table):
7827 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
7828 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
7829 for hashes and hash indexes, instead of 'unsigned' and 'int'.
7830 * alloc.c (allocate_vectorlike):
7831 Check for overflow in vector size calculations.
7832 * ccl.c (ccl_driver):
7833 Check for overflow when converting EMACS_INT to int.
7834 * fns.c, image.c: Remove unnecessary static decls that would otherwise
7835 need to be updated by these changes.
7836 * fns.c (make_hash_table, maybe_resize_hash_table):
7837 Check for integer overflow with large hash tables.
7838 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
7839 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
7840 (SXHASH_REDUCE): New macro.
7841 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
7842 Use it instead of discarding useful hash info with large hash values.
7843 (sxhash_float): New function.
7844 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
7845 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
7846 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
7847 Rewrite to use FIXNUM_BITS, as this simplifies things.
7848 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
7849 Adjust signatures to match updated version of code.
7850 (consing_since_gc): Now EMACS_INT, since a single hash table can
7851 use more than INT_MAX bytes.
7853 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
7855 Make it possible to build with GCC-4.6+ -O2 -flto.
7857 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
7859 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
7861 * minibuf.c (get_minibuffer, read_minibuf_unwind):
7862 Call minibuffer-inactive-mode.
7864 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
7866 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
7867 Update dependencies.
7869 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7871 * data.c (init_data): Remove code for UTS, this system is not
7874 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7876 Don't force ./temacs to start in terminal mode.
7878 * frame.c (make_initial_frame): Initialize faces in all cases, not
7879 only when CANNOT_DUMP is defined.
7880 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
7882 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7884 * dispnew.c (add_window_display_history): Use const for the string
7885 pointer. Remove declaration, not needed.
7887 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
7889 Use 'inline', not 'INLINE'.
7890 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
7891 * alloc.c, fontset.c (INLINE): Remove.
7892 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
7893 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
7894 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
7895 * gmalloc.c (register_heapinfo): Use inline unconditionally.
7896 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
7898 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7900 Make it possible to run ./temacs.
7902 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
7903 syms_of_callproc does the same thing. Remove test for
7904 "initialized", do it in the caller.
7905 * emacs.c (main): Avoid calling set_initial_environment when dumping.
7907 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
7909 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
7910 (read_minibuf): Use get_minibuffer.
7911 (syms_of_minibuf): Use DEFSYM.
7912 (Qmetadata): New var.
7913 * data.c (Qbuffer): Don't make it static.
7914 (syms_of_data): Use DEFSYM.
7916 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
7918 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
7919 (CCL_CODE_MIN): New macro.
7921 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
7923 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
7925 * eval.c (Qdebug): Now static.
7926 * lisp.h (Qdebug): Remove decl. This reverts a part of the
7927 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
7928 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
7930 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
7932 * image.c: Various fixes to ImageMagick code comments.
7933 (Fimagemagick_types): Doc fix.
7935 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
7937 Minor fixes prompted by GCC 4.6.0 warnings.
7939 * xselect.c (converted_selections, conversion_fail_tag): Now static.
7941 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
7942 (x_clipboard_manager_save_all): Move extern decl to ...
7943 * xterm.h: ... here, so that it can be checked for consistency.
7945 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
7947 * xselect.c (x_clipboard_manager_save_frame)
7948 (x_clipboard_manager_save_all): New functions.
7949 (Fx_clipboard_manager_save): Lisp function deleted.
7951 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
7952 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
7954 * xterm.h: Update prototype.
7956 2011-05-28 William Xu <william.xwl@gmail.com>
7958 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
7961 2011-05-28 Jim Meyering <meyering@redhat.com>
7963 Avoid a sign-extension bug in crypto_hash_function.
7964 * fns.c (to_uchar): Define.
7965 (crypto_hash_function): Use it to convert some newly-signed
7966 variables to unsigned, to avoid sign-extension bugs. For example,
7967 without this change, (md5 "truc") would evaluate to
7968 45723a2aff78ff4fff7fff1114760e62 rather than the expected
7969 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
7970 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
7972 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
7974 Integer overflow fixes.
7976 * dbusbind.c: Serial number integer overflow fixes.
7977 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
7978 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
7979 to hold a serial number that is too large for a fixnum.
7980 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7981 Check for serial numbers out of range. Decode any serial number
7982 that was so large that it became a float. (Bug#8722)
7984 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
7985 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7986 Use XFASTINT rather than XUINT when numbers are nonnegative.
7987 (xd_append_arg, Fdbus_method_return_internal):
7988 (Fdbus_method_error_internal): Likewise. Also, for unsigned
7989 arguments, check that Lisp number is nonnegative, rather than
7990 silently wrapping negative numbers around. (Bug#8722)
7991 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
7994 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
7996 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
7998 ccl: Add integer overflow checks.
7999 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
8000 (IN_INT_RANGE): New macros.
8001 (ccl_driver): Use them to check for integer overflow when
8002 decoding a CCL program. Many of the new checks are whether XINT (x)
8003 fits in int; it doesn't always, on 64-bit hosts. The new version
8004 doesn't catch all possible integer overflows, but it's an
8005 improvement. (Bug#8719)
8007 * alloc.c (make_event_array): Use XINT, not XUINT.
8008 There's no need for unsigned here.
8010 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
8011 This follows up to the 2011-05-06 change that substituted uintptr_t
8012 for EMACS_INT. This case wasn't caught back then.
8014 Rework Fformat to avoid integer overflow issues.
8015 * editfns.c: Include <float.h> unconditionally, as it's everywhere
8016 now (part of C89). Include <verify.h>.
8017 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
8018 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
8019 (Fformat): Avoid the prepass trying to compute sizes; it was only
8020 approximate and thus did not catch overflow reliably. Instead, walk
8021 through the format just once, formatting and computing sizes as we go,
8022 checking for integer overflow at every step, and allocating a larger
8023 buffer as needed. Keep track separately whether the format is
8024 multibyte. Keep only the most-recently calculated precision, rather
8025 than them all. Record whether each argument has been converted to
8026 string. Use EMACS_INT, not int, for byte and char and arg counts.
8027 Support field widths and precisions larger than INT_MAX. Avoid
8028 sprintf's undefined behavior with conversion specifications such as %#d
8029 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
8030 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
8031 formatting out-of-range floating point numbers with int
8034 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
8036 * data.c: Avoid integer truncation in expressions involving floats.
8037 * data.c: Include <intprops.h>.
8038 (arith_driver): When there's an integer overflow in an expression
8039 involving floating point, convert the integers to floating point
8040 so that the resulting value does not suffer from catastrophic
8041 integer truncation. For example, on a 64-bit host (* 4
8042 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
8043 Do not rely on undefined behavior after integer overflow.
8045 merge count_size_as_multibyte, parse_str_to_multibyte
8046 * character.c, character.h (count_size_as_multibyte):
8047 Rename from parse_str_to_multibyte; all uses changed.
8048 Check for integer overflow.
8049 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
8050 since it's now a duplicate of the other. This is more of
8051 a character than a buffer op, so better that it's in character.c.
8052 * fns.c, print.c: Adjust to above changes.
8054 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
8056 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
8058 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8060 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8061 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
8062 (x_clipboard_manager_save): Now static.
8063 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
8065 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8066 (crypto_hash_function): Now static.
8067 Fix pointer signedness problems. Avoid unnecessary initializations.
8069 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
8071 * termhooks.h (Vselection_alist): Make it terminal-local.
8073 * terminal.c (create_terminal): Initialize it.
8075 * xselect.c: Support for clipboard managers.
8076 (Vselection_alist): Move to termhooks.h as terminal-local var.
8077 (LOCAL_SELECTION): New macro.
8078 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
8079 (symbol_to_x_atom): Remove gratuitous arg.
8080 (x_handle_selection_request, lisp_data_to_selection_data)
8081 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
8082 (x_own_selection, x_get_local_selection, x_convert_selection):
8083 New arg, specifying work frame. Use terminal-local Vselection_alist.
8084 (some_frame_on_display): Delete unused function.
8085 (Fx_own_selection_internal, Fx_get_selection_internal)
8086 (Fx_disown_selection_internal, Fx_selection_owner_p)
8087 (Fx_selection_exists_p): New optional frame arg.
8088 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
8089 (x_handle_selection_clear): Don't treat other terminals with the
8090 same keyboard specially. Use the terminal-local Vselection_alist.
8091 (x_clear_frame_selections): Use Frun_hook_with_args.
8093 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
8095 * xterm.h: Add support for those atoms.
8097 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
8099 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
8100 (converted_selections, conversion_fail_tag): New global variables.
8101 (x_selection_request_lisp_error): Free the above.
8102 (x_get_local_selection): Remove unnecessary code.
8103 (x_reply_selection_request): Args changed; handle arbitrary array
8104 of converted selections stored in converted_selections.
8105 Separate the XChangeProperty and SelectionNotify steps.
8106 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
8107 (x_convert_selection): New function.
8108 (x_handle_selection_event): Simplify.
8109 (x_get_foreign_selection): Don't ignore incoming requests while
8110 waiting for an answer; this will fail when we implement
8111 SAVE_TARGETS, and seems unnecessary anyway.
8112 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
8113 (Vx_sent_selection_functions): Doc fix.
8115 2011-05-26 Leo Liu <sdl.web@gmail.com>
8117 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
8119 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8121 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
8123 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
8124 for fringe update if it has periodic bitmap.
8125 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
8126 and fringe_bitmap_periodic_p.
8128 * fringe.c (get_fringe_bitmap_data): New function.
8129 (draw_fringe_bitmap_1, update_window_fringes): Use it.
8130 (update_window_fringes): Record periodicity of fringe bitmap in glyph
8131 row. Mark glyph row for fringe update if periodicity changed.
8133 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
8134 for fringe update unless it has periodic bitmap.
8136 2011-05-25 Kenichi Handa <handa@m17n.org>
8138 * xdisp.c (get_next_display_element): Set correct it->face_id for
8139 a static composition.
8141 2011-05-24 Leo Liu <sdl.web@gmail.com>
8144 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
8146 * fns.c (crypto_hash_function, Fsha1): New function.
8147 (Fmd5): Use crypto_hash_function.
8148 (syms_of_fns): Add Ssha1.
8150 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8152 * gnutls.c: Remove unused macros.
8153 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
8154 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
8155 Remove macros that are defined and never used.
8156 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
8158 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
8160 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
8161 (Fx_get_selection_internal): Minor cleanup.
8162 (Fx_own_selection_internal): Rename arguments for consistency with
8165 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8167 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
8169 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
8171 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
8173 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8175 * dispnew.c (scrolling_window): Don't exclude the case that the
8176 last enabled row in the desired matrix touches the bottom boundary.
8178 2011-05-21 Glenn Morris <rgm@gnu.org>
8180 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
8181 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
8182 and add some more files.
8184 2011-05-20 Eli Zaretskii <eliz@gnu.org>
8186 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
8187 report_file_error introduced by the change from 2011-05-07.
8189 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
8191 * systime.h (Time): Define only if emacs is defined.
8192 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
8193 where the include path doesn't have X11/X.h by default. See
8194 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
8196 2011-05-20 Kenichi Handa <handa@m17n.org>
8198 * composite.c (find_automatic_composition): Fix previous change.
8200 2011-05-20 Glenn Morris <rgm@gnu.org>
8202 * lisp.mk: New file, split from Makefile.in.
8203 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
8204 (shortlisp): Remove.
8205 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
8207 2011-05-19 Glenn Morris <rgm@gnu.org>
8209 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
8210 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
8211 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
8212 (lisp): Set the order to that of loadup.el.
8213 (shortlisp): Make it a copy of $lisp.
8214 (SOME_MACHINE_LISP): Remove.
8215 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
8216 Use just $shortlisp, not $SOME_MACHINE_LISP too.
8218 2011-05-18 Kenichi Handa <handa@m17n.org>
8220 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
8221 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
8222 (find_automatic_composition): Mostly rewrite for efficiency.
8224 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
8226 * makefile.w32-in: Update dependencies.
8228 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
8230 * menu.c: Include limits.h (fixes the MS-Windows build broken by
8231 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8233 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
8235 Fix some integer overflow issues, such as string length overflow.
8237 * insdel.c (count_size_as_multibyte): Check for string overflow.
8239 * character.c (lisp_string_width): Check for string overflow.
8240 Use EMACS_INT, not int, for string indexes and lengths; in
8241 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
8242 the resulting string length overflows an EMACS_INT; instead,
8243 report a string overflow if no precision given. When checking for
8244 precision exhaustion, use a check that cannot possibly have
8245 integer overflow. (Bug#8675)
8246 * character.h (lisp_string_width): Adjust to new signature.
8248 * alloc.c (string_overflow): New function.
8249 (Fmake_string): Use it. This doesn't change behavior, but saves
8250 a few bytes and will simplify future changes.
8251 * character.c (string_escape_byte8): Likewise.
8252 * lisp.h (string_overflow): New decl.
8254 Fixups, following up to the user-interface timestamp change.
8255 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
8256 for UI timestamps, instead of unsigned long.
8257 * msdos.c (mouse_get_pos): Likewise.
8258 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
8259 * w32gui.h (Time): Define by including "systime.h" rather than by
8260 declaring it ourselves. (Bug#8664)
8262 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
8263 * image.c (clear_image_cache): Likewise.
8265 * term.c (term_mouse_position): Don't assume time_t wraparound.
8267 Be more systematic about user-interface timestamps.
8268 Before, the code sometimes used 'Time', sometimes 'unsigned long',
8269 and sometimes 'EMACS_UINT', to represent these timestamps.
8270 This change causes it to use 'Time' uniformly, as that's what X uses.
8271 This makes the code easier to follow, and makes it easier to catch
8272 integer overflow bugs such as Bug#8664.
8273 * frame.c (Fmouse_position, Fmouse_pixel_position):
8274 Use Time, not unsigned long, for user-interface timestamps.
8275 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
8276 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
8277 * keyboard.h (last_event_timestamp): Likewise.
8278 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
8279 * menu.h (xmenu_show): Likewise.
8280 * term.c (term_mouse_position): Likewise.
8281 * termhooks.h (struct input_event.timestamp): Likewise.
8282 (struct terminal.mouse_position_hook): Likewise.
8283 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
8284 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
8285 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
8286 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
8288 * menu.h, termhooks.h: Include "systime.h", for Time.
8290 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
8291 Don't assume that the difference between two unsigned long values
8292 can fit into an integer. At this point, we know button_down_time
8293 <= event->timestamp, so the difference must be nonnegative, so
8294 there's no need to cast the result if double-click-time is
8295 nonnegative, as it should be; check that it's nonnegative, just in
8296 case. This bug is triggered when events are more than 2**31 ms
8297 apart (about 25 days). (Bug#8664)
8299 * xselect.c (last_event_timestamp): Remove duplicate decl.
8300 (x_own_selection): Remove needless cast to unsigned long.
8302 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
8303 that always fit in int. Use a sentinel instead of a counter, to
8304 avoid a temp and to allay GCC's concerns about possible int overflow.
8305 * frame.h (struct frame): Use int for menu_bar_items_used
8306 instead of EMACS_INT, since it always fits in int.
8308 * menu.c (grow_menu_items): Check for int overflow.
8310 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
8312 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
8313 Before, the code was not consistent. These values cannot exceed
8314 2**31 - 1 so there's no need to make them unsigned.
8315 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
8316 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
8317 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
8319 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
8321 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
8322 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
8323 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
8324 presumably because the widths might not match.
8326 * window.c (size_window): Avoid needless test at loop start.
8328 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
8330 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
8332 2011-05-12 Drew Adams <drew.adams@oracle.com>
8334 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
8336 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8338 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
8339 `width' to `bar_area_x' and `bar_area_width', respectively.
8340 (x_scroll_run): Take account of fringe background extension.
8342 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
8343 Rename local vars `left' and `width' to `bar_area_x' and
8344 `bar_area_width', respectively.
8345 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
8346 background extension.
8348 2011-05-10 Jim Meyering <meyering@redhat.com>
8350 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
8352 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
8354 * image.c (Finit_image_library): Return t for built-in image types,
8355 like pbm and xbm. (Bug#8640)
8357 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
8359 * w32menu.c (set_frame_menubar): Fix submenu allocation.
8361 2011-05-07 Eli Zaretskii <eliz@gnu.org>
8363 * w32console.c (Fset_screen_color): Doc fix.
8364 (Fget_screen_color): New function.
8365 (syms_of_ntterm): Defsubr it.
8367 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
8368 unlink the temporary file if Fcall_process didn't create it in the
8370 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
8371 child process will be redirected to a file specified with `:file'.
8372 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
8373 cue to call_process_cleanup not to close that handle.
8375 2011-05-07 Ben Key <bkey76@gmail.com>
8377 * makefile.w32-in: The bootstrap-temacs rule now makes use of
8378 one of two shell specific rules, either bootstrap-temacs-CMD or
8379 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
8380 to the previous implementation of the bootstrap-temacs rule.
8381 The bootstrap-temacs-CMD rule is similar to the previous
8382 implementation of the bootstrap-temacs rule except that it
8383 makes use of the ESC_CFLAGS variable instead of the CFLAGS
8386 These changes, along with some changes to nt/configure.bat,
8387 nt/gmake.defs, and nt/nmake.defs, are required to extend my
8388 earlier fix to add support for --cflags and --ldflags options
8389 that include quotes so that it works whether make uses cmd or
8392 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
8394 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
8395 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
8397 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
8398 a string. Handle both cases.
8399 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
8400 (Fdbus_register_method): Use Qinvalid_function.
8402 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
8404 * makefile.w32-in: Update dependencies.
8405 (LISP_H): Add inttypes.h and stdin.h.
8406 (PROCESS_H): Add unistd.h.
8408 2011-05-06 Eli Zaretskii <eliz@gnu.org>
8410 * lread.c: Include limits.h (fixes the MS-Windows build broken by
8411 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
8413 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
8415 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
8417 * term.c (vfatal): Remove stray call to va_end.
8418 It's not needed and the C Standard doesn't allow it here anyway.
8420 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
8421 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
8423 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
8426 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
8428 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8430 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
8432 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
8434 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
8436 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
8437 * charset.c (Fdefine_charset_internal): Don't initialize
8438 charset.code_space[15]. The value was garbage, on hosts with
8439 32-bit int (Bug#8600).
8441 * lread.c (read_integer): Be more consistent with string-to-number.
8442 Use string_to_number to do the actual conversion; this avoids
8443 rounding errors and fixes some other screwups. Without this fix,
8444 for example, #x1fffffffffffffff was misread as -2305843009213693952.
8445 (digit_to_number): Move earlier, for benefit of read_integer.
8446 Return -1 if the digit is out of range for the base, -2 if it is
8447 not a digit in any supported base. (Bug#8602)
8449 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
8451 * dispnew.c (scrolling_window): Return 1 if we scrolled,
8452 to match comment at start of function. This also removes a
8453 GCC warning about overflow in a 32+64-bit port.
8455 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
8457 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
8458 Reported by Stefan Monnier in
8459 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
8460 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8461 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
8463 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
8464 (EMACS_UINTPTR): Likewise, with uintptr_t.
8466 * lisp.h: Prefer 64-bit EMACS_INT if available.
8467 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
8468 on 32-bit hosts that have 64-bit int, so that they can access
8470 However, temporarily disable this change unless the temporary
8471 symbol WIDE_EMACS_INT is defined.
8473 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
8475 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
8476 This removes an assumption that EMACS_INT and long are the same
8477 width as pointers. The assumption is true for Emacs porting targets
8478 now, but we want to make other targets possible.
8479 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
8480 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
8481 In the rest of the code, change types of integers that hold casted
8482 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
8483 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
8484 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
8485 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
8486 No need to cast type when ORing.
8487 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
8488 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
8489 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
8490 assume EMACS_INT is the same width as char *.
8491 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
8492 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
8493 Remove no-longer-needed casts.
8494 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
8495 (xg_tool_bar_help_callback, xg_make_tool_item):
8496 Use EMACS_INTPTR to hold an integer
8497 that will be cast to void *; this can avoid a GCC warning
8498 if EMACS_INT is not the same width as void *.
8499 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
8500 * xdisp.c (display_echo_area_1, resize_mini_window_1):
8501 (current_message_1, set_message_1):
8502 Use a local to convert to proper width without a cast.
8503 * xmenu.c (dialog_selection_callback): Likewise.
8505 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
8506 Also, don't assume VALBITS / RAND_BITS is less than 5,
8507 and don't rely on undefined behavior when shifting a 1 left into
8509 * lisp.h (get_random): Change signature to match.
8511 * lread.c (hash_string): Use size_t, not int, for hash computation.
8512 Normally we prefer signed values; but hashing is special, because
8513 it's better to use unsigned division on hash table sizes so that
8514 the remainder is nonnegative. Also, size_t is the natural width
8515 for hashing into memory. The previous code used 'int', which doesn't
8516 retain enough info to hash well into very large tables.
8517 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
8519 * dbusbind.c: Don't possibly lose pointer info when converting.
8520 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8521 Use XPNTR rather than XHASH, so that the high-order bits of
8522 the pointer aren't lost when converting through void *.
8524 * eval.c (Fautoload): Don't double-shift a pointer.
8526 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
8528 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
8530 * gnutls.c (DEF_GNUTLS_FN):
8531 * image.c (DEF_IMGLIB_FN): Make function pointers static.
8533 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
8535 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
8538 2011-05-05 Eli Zaretskii <eliz@gnu.org>
8540 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
8541 New version that can reserve upto 2GB of heap space.
8543 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
8545 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
8547 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
8549 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
8550 `gnutls_certificate_set_x509_key_file'.
8552 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
8554 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
8555 Update dependencies.
8557 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8559 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
8560 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
8561 Remove unused parameter `fildes'.
8562 * process.c (read_process_output, send_process): Don't pass it.
8564 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8566 Fix previous change: the library cache is defined in w32.c.
8567 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
8568 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
8570 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8572 Implement dynamic loading of GnuTLS on Windows.
8574 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
8575 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
8576 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8579 * gnutls.c (Qgnutls_dll): Define.
8580 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
8581 (gnutls_*): Declare function pointers.
8582 (init_gnutls_functions): New function to initialize function pointers.
8583 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
8584 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
8585 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8586 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
8587 (emacs_gnutls_write, emacs_gnutls_read)
8588 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
8589 (Fgnutls_available_p): New function.
8590 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
8591 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
8592 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
8594 * image.c: Include w32.h.
8595 (Vimage_type_cache): Delete.
8596 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
8597 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
8598 (w32_delayed_load): Move to w32.c.
8600 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
8602 * w32.c (QCloaded_from, Vlibrary_cache): Define.
8603 (w32_delayed_load): Move from image.c. When loading a library, record
8604 its filename in the :loaded-from property of the library id.
8605 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
8606 Initialize and staticpro them.
8607 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
8609 * process.c: Include lisp.h before w32.h, not after.
8610 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
8611 instead of gnutls_record_check_pending.
8613 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
8615 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
8617 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
8618 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
8621 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
8623 * xterm.c (x_set_frame_alpha): Do not set property on anything
8624 else than FRAME_X_OUTER_WINDOW (Bug#8608).
8626 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
8628 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
8630 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
8632 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
8633 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
8634 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
8635 (gnutls_global_initialized, Qgnutls_bootprop_priority)
8636 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
8637 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
8638 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
8639 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
8640 (Qgnutls_bootprop_callbacks_verify): Make static.
8642 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
8644 * callproc.c: Indentation fixup.
8646 * sysdep.c (wait_for_termination_1): Make static.
8647 (wait_for_termination, interruptible_wait_for_termination):
8648 Move after wait_for_termination_1.
8650 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
8652 * sysdep.c (interruptible_wait_for_termination): New function
8653 which is like wait_for_termination, but allows keyboard
8656 * callproc.c (Fcall_process): Add (:file "file") as an option for
8658 (Fcall_process_region): Ditto.
8660 2011-04-30 Eli Zaretskii <eliz@gnu.org>
8662 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
8663 rather than `XVECTOR (FOO)->size'.
8665 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
8666 inttypes.h, as a gnulib replacement is used if it not available in
8669 2011-04-21 Eli Zaretskii <eliz@gnu.org>
8671 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
8672 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
8673 of MOST_POSITIVE_FIXNUM. (Bug#8528)
8675 * coding.c (coding_alloc_by_realloc): Error out if destination
8676 will grow beyond MOST_POSITIVE_FIXNUM.
8677 (decode_coding_emacs_mule): Abort if there isn't enough place in
8678 charbuf for the composition carryover bytes. Reserve an extra
8679 space for up to 2 characters produced in a loop.
8680 (decode_coding_iso_2022): Abort if there isn't enough place in
8681 charbuf for the composition carryover bytes.
8683 2011-04-21 Eli Zaretskii <eliz@gnu.org>
8685 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
8686 aborting when %lld or %lll format is passed.
8687 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
8688 %llo or %llx format is passed. (Bug#8545)
8690 * window.c (window_scroll_line_based): Use a marker instead of
8691 simple variables to record original value of point. (Bug#7952)
8693 * doprnt.c (doprnt): Fix the case where a multibyte sequence
8694 produced by %s or %c overflows available buffer space. (Bug#8545)
8696 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
8698 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
8699 (SIZE_MAX): Move defn after all includes, as they might #define it.
8701 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8703 * w32.c (init_environment): Warn about defaulting HOME to C:\.
8705 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8707 * keyboard.c (Qdelayed_warnings_hook): Define.
8708 (command_loop_1): Run `delayed-warnings-hook'
8709 if Vdelayed_warnings_list is non-nil.
8710 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
8711 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
8713 2011-04-28 Eli Zaretskii <eliz@gnu.org>
8715 * doprnt.c (doprnt): Don't return value smaller than the buffer
8716 size if the message was truncated. (Bug#8545).
8718 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8720 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
8721 (Fx_window_property): #if-0 the whole functions, not just the bodies.
8723 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8725 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
8727 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
8729 * makefile.w32-in: Update dependencies.
8731 2011-04-27 Eli Zaretskii <eliz@gnu.org>
8733 Improve `doprnt' and its usage. (Bug#8545)
8734 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
8735 `format_end'. Remove support for %l as a conversion specifier.
8736 Don't use xrealloc. Improve diagnostics when the %l size modifier
8737 is used. Update the commentary.
8739 * eval.c (verror): Simplify calculation of size_t.
8741 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
8744 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
8746 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
8749 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8751 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
8752 This makes this file independent of the recent pseudovector change.
8754 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
8756 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
8758 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
8759 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8760 Remove unused local.
8761 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
8763 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
8764 GCC 4.6.0 optimizes based on type-based alias analysis.
8765 For example, if b is of type struct buffer * and v of type struct
8766 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
8767 != &v->size, and therefore "v->size = 1; b->size = 2; return
8768 v->size;" must therefore return 1. This assumption is incorrect
8769 for Emacs, since it type-puns struct Lisp_Vector * with many other
8770 types. To fix this problem, this patch adds a new type struct
8771 vectorlike_header that documents the constraints on layout of vectors
8772 and pseudovectors, and helps optimizing compilers not get fooled
8773 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
8774 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
8775 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
8777 (XSETPVECTYPE): Rewrite in terms of new macro.
8778 (XSETPVECTYPESIZE): New macro, specifying both type and size.
8779 This is a bit clearer, and further avoids the possibility of
8780 undesirable aliasing.
8781 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
8782 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
8783 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
8784 since Lisp_Subr is a special case (no "next" field).
8785 (ASIZE): Now uses header.size rather than size.
8786 All previous uses of XVECTOR (foo)->size replaced to use this macro,
8787 to avoid the hassle of writing XVECTOR (foo)->header.size.
8788 (struct vectorlike_header): New type.
8789 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
8790 object, to help avoid aliasing.
8791 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
8792 (SUBRP): Likewise, since Lisp_Subr is a special case.
8793 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
8794 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
8795 (struct Lisp_Hash_Table): Combine first two members into a single
8796 struct vectorlike_header member. All uses of "size" and "next" members
8797 changed to be "header.size" and "header.next".
8798 * buffer.h (struct buffer): Likewise.
8799 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
8800 * frame.h (struct frame): Likewise.
8801 * process.h (struct Lisp_Process): Likewise.
8802 * termhooks.h (struct terminal): Likewise.
8803 * window.c (struct save_window_data, struct saved_window): Likewise.
8804 * window.h (struct window): Likewise.
8805 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
8806 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
8807 * buffer.c (init_buffer_once): Likewise.
8808 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
8810 * process.c (Fformat_network_address): Use local var for size,
8813 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
8815 Make the Lisp reader and string-to-float more consistent (Bug#8525)
8816 * data.c (atof): Remove decl; no longer used or needed.
8817 (digit_to_number): Move to lread.c.
8818 (Fstring_to_number): Use new string_to_number function, to be
8819 consistent with how the Lisp reader treats infinities and NaNs.
8820 Do not assume that floating-point numbers represent EMACS_INT
8821 without losing information; this is not true on most 64-bit hosts.
8822 Avoid double-rounding errors, by insisting on integers when
8823 parsing non-base-10 numbers, as the documentation specifies.
8824 * lisp.h (string_to_number): New decl, replacing ...
8825 (isfloat_string): Remove.
8826 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
8827 (read1): Do not accept +. and -. as integers; this
8828 appears to have been a coding error. Similarly, do not accept
8829 strings like +-1e0 as floating point numbers. Do not report
8830 overflow for integer overflows unless the base is not 10 which
8831 means we have no simple and reliable way to continue.
8832 Break out the floating-point parsing into a new
8833 function string_to_number, so that Fstring_to_number parses
8834 floating point numbers consistently with the Lisp reader.
8835 (digit_to_number): Move here from data.c. Make it static inline.
8836 (E_CHAR, EXP_INT): Remove, replacing with ...
8837 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
8838 (string_to_number): New function, replacing isfloat_string.
8839 This function checks for valid syntax and produces the resulting
8840 Lisp float number too. Rework it so that string-to-number
8841 no longer mishandles examples like "1.0e+". Use strtoumax,
8842 so that overflow for non-base-10 numbers is reported only when
8843 there's no portable and simple way to convert to floating point.
8845 * textprop.c (set_text_properties_1): Rewrite for clarity,
8846 and to avoid GCC warning about integer overflow.
8848 * intervals.h (struct interval): Use EMACS_INT for members
8849 where EMACS_UINT might cause problems. See
8850 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
8851 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
8852 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
8854 (offset_intervals): Tell GCC not to worry about length overflow
8855 when negating a negative length.
8857 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
8858 (overrun_check_free): Likewise.
8860 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
8861 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
8864 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
8865 (gnutls_make_error): Rename local to avoid shadowing.
8866 (gnutls_emacs_global_deinit): ifdef out; not used.
8867 (Fgnutls_boot): Use const for pointer to readonly storage.
8868 Comment out unused local. Fix pointer signedness problems.
8870 * lread.c (openp): Don't stuff size_t into an 'int'.
8871 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
8872 about possible signed overflow.
8874 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
8875 (GDK_KEY_g): Don't define if already defined.
8876 (xg_prepare_tooltip): Avoid pointer signedness problem.
8877 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
8879 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
8880 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
8882 * xfns.c (Fx_window_property): Simplify a bit,
8883 to make a bit faster and to avoid GCC 4.6.0 warning.
8884 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
8886 * fns.c (internal_equal): Don't assume size_t fits in int.
8888 * alloc.c (compact_small_strings): Tighten assertion a little.
8890 Replace pEd with more-general pI, and fix some printf arg casts.
8891 * lisp.h (pI): New macro, generalizing old pEd macro to other
8892 conversion specifiers. For example, use "...%"pI"d..." rather
8893 than "...%"pEd"...".
8894 (pEd): Remove. All uses replaced with similar uses of pI.
8895 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
8896 * alloc.c (check_pure_size): Don't overflow by converting size to int.
8897 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
8898 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
8899 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
8900 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
8901 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
8903 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
8904 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
8905 * print.c (safe_debug_print, print_object): Likewise.
8906 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
8908 Use pI instead of if-then-else-abort. Use %p to avoid casts,
8909 avoiding the 0 flag, which is not portable.
8910 * process.c (Fmake_network_process): Use pI to avoid cast.
8911 * region-cache.c (pp_cache): Likewise.
8912 * xdisp.c (decode_mode_spec): Likewise.
8913 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
8914 behavior on 64-bit hosts with printf arg.
8915 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
8916 (x_stop_queuing_selection_requests): Likewise.
8917 (x_get_window_property): Don't truncate byte count to an 'int'
8920 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
8921 here, since it parses constructs like leading '-' and spaces,
8922 which are not wanted; and it overflows with large numbers.
8923 Instead, simply match F[0-9]+, which is what is wanted anyway.
8925 * alloc.c: Remove unportable assumptions about struct layout.
8926 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
8927 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
8928 (allocate_vectorlike, make_pure_vector): Use the new macros,
8929 plus offsetof, to remove unportable assumptions about struct layout.
8930 These assumptions hold on all porting targets that I know of, but
8931 they are not guaranteed, they're easy to remove, and removing them
8932 makes further changes easier.
8934 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
8935 This doesn't fix a bug but makes the code clearer.
8936 (string_overrun_cookie): Now const. Use initializers that
8937 don't formally overflow signed char, to avoid warnings.
8938 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
8939 can cause Emacs to crash when string overrun checking is enabled.
8940 (allocate_buffer): Don't assume sizeof (struct buffer) is a
8941 multiple of sizeof (EMACS_INT); it need not be, if
8942 alignof(EMACS_INT) < sizeof (EMACS_INT).
8943 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
8945 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
8947 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
8949 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
8951 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
8952 supposed to be handshaking. (Bug#8556)
8953 Reported by Paul Eggert <eggert@cs.ucla.edu>.
8955 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
8957 * lisp.h (Qdebug): List symbol.
8958 * eval.c (Qdebug): Restore global linkage.
8959 * keyboard.c (debug-on-event): New variable.
8960 (handle_user_signal): Break into debugger when debug-on-event
8961 matches the current signal symbol.
8963 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
8965 * alloc.c (check_sblock, check_string_bytes)
8966 (check_string_free_list): Convert to standard C.
8968 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
8970 * w32.c (emacs_gnutls_push): Fix typo.
8972 2011-04-25 Eli Zaretskii <eliz@gnu.org>
8974 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
8975 "cast to pointer from integer of different size".
8977 Improve doprnt and its use in verror. (Bug#8545)
8978 * doprnt.c (doprnt): Document the set of format control sequences
8979 supported by the function. Use SAFE_ALLOCA instead of always
8982 * eval.c (verror): Don't limit the buffer size at size_max-1, that
8983 is one byte too soon. Don't use xrealloc; instead xfree and
8986 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
8988 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
8991 * gnutls.c: Renamed global_initialized to
8992 gnutls_global_initialized. Added internals for the
8993 :verify-hostname-error, :verify-error, and :verify-flags
8994 parameters of `gnutls-boot' and documented those parameters in the
8995 docstring. Start callback support.
8996 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
8997 unless a fatal error occurred. Call gnutls_alert_send_appropriate
8998 on error. Return error code.
8999 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
9000 (emacs_gnutls_read): Likewise.
9001 (Fgnutls_boot): Return handshake error code.
9002 (emacs_gnutls_handle_error): New function.
9003 (wsaerror_to_errno): Likewise.
9005 * w32.h (emacs_gnutls_pull): Add prototype.
9006 (emacs_gnutls_push): Likewise.
9008 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
9009 (emacs_gnutls_push): Likewise.
9011 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
9013 * process.c (wait_reading_process_output): Check if GnuTLS
9014 buffered some data internally if no FDs are set for TLS
9017 * makefile.w32-in (OBJ2): Add gnutls.$(O).
9018 (LIBS): Link to USER_LIBS.
9019 ($(BLD)/gnutls.$(0)): New target.
9021 2011-04-24 Eli Zaretskii <eliz@gnu.org>
9023 * xdisp.c (handle_single_display_spec): Rename the
9024 display_replaced_before_p argument into display_replaced_p, to
9025 make it consistent with the commentary. Fix typos in the
9028 * textprop.c (syms_of_textprop): Remove dead code.
9029 (copy_text_properties): Delete obsolete commentary about an
9030 interface that was deleted long ago. Fix typos in the description
9033 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
9034 to changes in oldXMenu/XMenu.h from 2011-04-16.
9035 <menu_help_message, prev_menu_help_message>: Constify.
9036 (IT_menu_make_room): menu->help_text is now `const char **';
9039 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
9040 to changes in oldXMenu/XMenu.h from 2011-04-16.
9041 (struct XMenu): Declare `help_text' `const char **'.
9043 * xfaces.c <Qunspecified>: Make extern again.
9045 * syntax.c: Include sys/types.h before including regex.h, as
9048 * doc.c (get_doc_string): Improve the format passed to `error'.
9050 * doprnt.c (doprnt): Improve commentary.
9052 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
9054 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
9057 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
9058 changes in globals.h immediately force recompilation.
9059 (TAGS): Depend on $(CURDIR)/m/intel386.h and
9060 $(CURDIR)/s/ms-w32.h.
9061 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
9063 * character.c (Fchar_direction): Function deleted.
9064 (syms_of_character): Don't defsubr it.
9065 <char-direction-table>: Deleted.
9067 2011-04-23 Eli Zaretskii <eliz@gnu.org>
9069 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
9070 * doprnt.c: Include limits.h.
9071 (SIZE_MAX): New macro.
9072 (doprnt): Return a size_t value. 2nd arg is now size_t.
9073 Many local variables are now size_t instead of int or unsigned.
9074 Improve overflow protection. Support `l' modifier for integer
9075 conversions. Support %l conversion. Don't assume an EMACS_INT
9076 argument for integer conversions and for %c.
9078 * lisp.h (doprnt): Restore prototype.
9080 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
9083 * Makefile.in (base_obj): Add back doprnt.o.
9085 * deps.mk (doprnt.o): Add back prerequisites.
9086 (callint.o): Depend on character.h.
9088 * eval.c (internal_lisp_condition_case): Include the handler
9089 representation in the error message.
9090 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
9091 when breaking from the loop.
9093 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
9095 * callint.c (Fcall_interactively): When displaying error message
9096 about invalid control letter, pass the character's codepoint, not
9097 a pointer to its multibyte form. Improve display of the character
9098 in octal and display also its hex code.
9100 * character.c (char_string): Use %x to display the (unsigned)
9101 codepoint of an invalid character, to avoid displaying a bogus
9104 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
9105 `error', not SYMBOL_NAME itself.
9107 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
9108 character arguments to `error'.
9110 * charset.c (check_iso_charset_parameter): Fix incorrect argument
9111 to `error' in error message about FINAL_CHAR argument. Make sure
9112 FINAL_CHAR is a character, and use %c when it is passed as
9113 argument to `error'.
9115 2011-04-23 Eli Zaretskii <eliz@gnu.org>
9117 * s/ms-w32.h (localtime): Redirect to sys_localtime.
9119 * w32.c: Include <time.h>.
9120 (sys_localtime): New function.
9122 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
9124 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
9126 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
9128 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
9130 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
9133 2011-04-19 Eli Zaretskii <eliz@gnu.org>
9135 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
9136 gl_state.e_property when gl_state.object is Qt.
9138 * insdel.c (make_gap_larger): Remove limitation of buffer size
9141 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
9143 * xdisp.c (lookup_glyphless_char_display)
9144 (produce_glyphless_glyph): Handle cons cell entry in
9145 glyphless-char-display.
9146 (Vglyphless_char_display): Document it.
9148 * term.c (produce_glyphless_glyph): Handle cons cell entry in
9149 glyphless-char-display.
9151 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
9153 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
9155 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
9157 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
9158 definition for no-X builds.
9160 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
9162 Static checks with GCC 4.6.0 and non-default toolkits.
9164 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
9166 * process.c (keyboard_bit_set): Define only if SIGIO.
9167 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
9168 (send_process): Repair possible setjmp clobbering.
9170 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
9172 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
9174 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
9176 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
9177 Define only if needed.
9179 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
9180 by pacifying GCC about it. Maybe it's time to retire it?
9181 * xfaces.c (USG, __TIMEVAL__): Likewise.
9183 * dispextern.h (struct redisplay_interface): Rename param
9185 * termhooks.h (struct terminal): Likewise.
9186 * xterm.c (xembed_send_message): Likewise.
9188 * insdel.c (make_gap_smaller): Define only if
9189 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
9191 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
9194 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
9195 so that we aren't warned about unused symbols.
9197 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
9199 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
9201 * xfns.c (x_real_positions): Mark locals as initialized.
9203 * xmenu.c (xmenu_show): Don't use uninitialized vars.
9205 * xterm.c: Fix problems found by static analysis with other toolkits.
9206 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
9207 (x_dispatch_event): Declare static if USE_GTK, and
9208 define if USE_GTK || USE_X_TOOLKIT.
9209 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
9210 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
9211 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
9212 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
9214 * xmenu.c (menu_help_callback): Pointer type fixes.
9215 Use const pointers when pointing at readonly data. Avoid pointer
9217 (FALSE): Remove unused macro.
9218 (update_frame_menubar): Remove unused decl.
9220 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
9222 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
9223 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
9224 (single_menu_item): Rename local to avoid shadowing.
9226 * keyboard.c (make_lispy_event): Remove unused local var.
9228 * frame.c, frame.h (x_get_resource_string): Bring this back, but
9229 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
9231 * bitmaps: Change bitmaps from unsigned char back to the X11
9232 compatible char. Avoid the old compiler warnings about
9233 out-of-range initializers by using, for example, '\xab' rather
9236 * xgselect.c (xgselect_initialize): Check vs interface
9237 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
9239 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
9241 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
9242 to read-only memory.
9244 * fns.c (vector): Remove; this old hack is no longer needed.
9246 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
9248 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
9250 * xrdb.c (x_load_resources): Omit unused local.
9252 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
9253 (x_window): Rename locals to avoid shadowing.
9254 (USG): Use the kludged USG macro, to pacify gcc.
9256 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
9257 (x_term_init): Remove local to avoid shadowing.
9259 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
9261 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
9262 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
9264 2011-04-16 Eli Zaretskii <eliz@gnu.org>
9266 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
9268 Fix regex.c, syntax.c and friends for buffers > 2GB.
9269 * syntax.h (struct gl_state_s): Declare character position members
9272 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
9274 * textprop.c (verify_interval_modification, interval_of):
9275 Declare arguments EMACS_INT.
9277 * intervals.c (adjust_intervals_for_insertion): Declare arguments
9280 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
9282 * indent.c (Fvertical_motion): Local variable it_start is now
9285 * regex.c (re_match, re_match_2, re_match_2_internal)
9286 (bcmp_translate, regcomp, regexec, print_double_string)
9287 (group_in_compile_stack, re_search, re_search_2, regex_compile)
9288 (re_compile_pattern, re_exec): Declare arguments and local
9289 variables `size_t' and `ssize_t' and return values `regoff_t', as
9291 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
9292 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
9293 <compile_stack_type>: `size' and `avail' are now `size_t'.
9295 * regex.h <regoff_t>: Use ssize_t, not int.
9296 (re_search, re_search_2, re_match, re_match_2): Arguments that
9297 specify buffer/string position and length are now ssize_t and
9298 size_t. Return type is regoff_t.
9300 2011-04-16 Ben Key <bkey76@gmail.com>
9302 * nsfont.m: Fixed bugs in ns_get_family and
9303 ns_descriptor_to_entity that were caused by using free to
9304 deallocate memory blocks that were allocated by xmalloc (via
9305 xstrdup). This caused Emacs to crash when compiled with
9306 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
9307 --enable-checking=xmallocoverrun). xfree is now used to
9308 deallocate these memory blocks.
9310 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
9312 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
9314 emacs_write: Accept and return EMACS_INT for sizes.
9315 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
9317 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
9318 Accept and return EMACS_INT.
9319 (emacs_gnutls_write): Return the number of bytes written on
9321 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
9322 (emacs_read, emacs_write): Remove check for negative size, as the
9323 Emacs source code has been audited now.
9324 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
9325 (emacs_read, emacs_write): Use it.
9326 * process.c (send_process): Adjust to the new signatures of
9327 emacs_write and emacs_gnutls_write. Do not attempt to store
9328 a byte offset into an 'int'; it might overflow.
9329 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
9331 * sound.c: Don't assume sizes fit in 'int'.
9332 (struct sound_device.period_size, alsa_period_size):
9333 Return EMACS_INT, not int.
9334 (struct sound_device.write, vox_write, alsa_write):
9335 Accept EMACS_INT, not int.
9336 (wav_play, au_play): Use EMACS_INT to store sizes and to
9337 record read return values.
9339 2011-04-15 Ben Key <bkey76@gmail.com>
9341 * keyboard.c (Qundefined): Don't declare static since it is used
9343 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
9344 static since they are used in nsfont.m.
9346 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
9348 * process.c (Qprocessp): Don't declare static.
9349 * lisp.h (Qprocessp): Declare again.
9351 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
9353 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
9355 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
9357 Improve C-level modularity by making more things 'static'.
9359 Don't publish debugger-only interfaces to other modules.
9360 * lisp.h (safe_debug_print, debug_output_compilation_hack):
9361 (verify_bytepos, count_markers): Move decls to the only modules
9363 * region-cache.h (pp_cache): Likewise.
9364 * window.h (check_all_windows): Likewise.
9365 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
9367 * sysdep.c (croak): Now static, if
9368 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
9369 * syssignal.h (croak): Declare only if not static.
9371 * alloc.c (refill_memory_reserve): Now static if
9372 !defined REL_ALLOC || defined SYSTEM_MALLOC.
9373 * lisp.h (refill_memory_reserve): Declare only if not static.
9375 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
9376 Define only if USE_LUCID.
9378 * xrdb.c (x_customization_string, x_rm_string): Now static.
9380 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
9381 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
9383 * xdisp.c (draw_row_with_mouse_face): Now static.
9384 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
9386 * window.h (check_all_windows): Mark externally visible.
9388 * window.c (window_deletion_count): Now static.
9390 * undo.c: Make symbols static if they're not exported.
9391 (last_undo_buffer, last_boundary_position, pending_boundary):
9394 * textprop.c (interval_insert_behind_hooks): Now static.
9395 (interval_insert_in_front_hooks): Likewise.
9397 * term.c: Make symbols static if they're not exported.
9398 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
9399 (max_frame_lines, tty_set_terminal_modes):
9400 (tty_reset_terminal_modes, tty_turn_off_highlight):
9401 (get_tty_terminal): Now static.
9402 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
9403 * termhooks.h (term_mouse_moveto): Do not declare if
9405 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
9406 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
9408 * sysdep.c: Make symbols static if they're not exported.
9409 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
9411 (sigprocmask_set, full_mask): Remove; unused.
9412 (wait_debugging): Mark as visible.
9413 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
9414 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
9416 * syntax.c (syntax_temp): Define only if !__GNUC__.
9418 * sound.c (current_sound_device, current_sound): Now static.
9420 * search.c (searchbufs, searchbuf_head): Now static.
9422 * scroll.c (scroll_cost): Remove; unused.
9423 * dispextern.h (scroll_cost): Remove decl.
9425 * region-cache.h (pp_cache): Mark as externally visible.
9427 * process.c: Make symbols static if they're not exported.
9428 (process_tick, update_tick, create_process, chan_process):
9429 (Vprocess_alist, proc_buffered_char, datagram_access):
9430 (fd_callback_data, send_process_frame, process_sent_to): Now static.
9431 (deactivate_process): Mark defn as static, as well as decl.
9432 * lisp.h (create_process): Remove decl.
9433 * process.h (chan_process, Vprocess_alist): Remove decls.
9435 * print.c: Make symbols static if they're not exported.
9436 (print_depth, new_backquote_output, being_printed, print_buffer):
9437 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
9438 (print_interval, print_number_index, initial_stderr_stream):
9440 * lisp.h (Fprinc): Remove decl.
9441 (debug_output_compilation_hack): Mark as externally visible.
9443 * sysdep.c (croak): Move decl from here to syssignal.h.
9444 * syssignal.h (croak): Put it here, so the API can be checked when
9445 'croak' is called from dissociate_if_controlling_tty.
9447 * minibuf.c: Make symbols static if they're not exported.
9448 (minibuf_save_list, choose_minibuf_frame): Now static.
9449 * lisp.h (choose_minibuf_frame): Remove decl.
9451 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
9453 * lread.c: Make symbols static if they're not exported.
9454 (read_objects, initial_obarray, oblookup_last_bucket_number):
9456 (make_symbol): Remove; unused.
9457 * lisp.h (initial_obarray, make_symbol): Remove decls.
9459 * keyboard.c: Make symbols static if they're not exported.
9460 (single_kboard, recent_keys_index, total_keys, recent_keys):
9461 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
9462 (this_single_command_key_start, echoing, last_auto_save):
9463 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
9464 (command_loop, echo_now, keyboard_init_hook, help_char_p):
9465 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
9466 (Vlispy_mouse_stem, double_click_count):
9468 (force_auto_save_soon): Define only if SIGDANGER.
9469 (ignore_mouse_drag_p): Now static if
9470 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
9471 (print_help): Remove; unused.
9472 (stop_character, last_timer_event): Mark as externally visible.
9473 * keyboard.h (ignore_mouse_drag_p): Declare only if
9474 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
9475 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
9476 * lisp.h (echoing): Remove decl.
9477 (force_auto_save_soon): Declare only if SIGDANGER.
9478 * xdisp.c (redisplay_window): Simplify code, to make it more
9479 obvious that ignore_mouse_drag_p is not accessed if !defined
9480 USE_GTK && !defined HAVE_NS.
9482 * intervals.c: Make symbols static if they're not exported.
9483 (merge_properties_sticky, merge_interval_right, delete_interval):
9485 * intervals.h (merge_interval_right, delete_interval): Remove decls.
9487 * insdel.c: Make symbols static if they're not exported.
9488 However, leave prepare_to_modify_buffer alone. It's never
9489 called from outside this function, but that appears to be a bug.
9490 (combine_after_change_list, combine_after_change_buffer):
9491 (adjust_after_replace, signal_before_change): Now static.
9492 (adjust_after_replace_noundo): Remove; unused.
9493 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
9494 (signal_before_change): Remove decls.
9496 * indent.c (val_compute_motion, val_vmotion): Now static.
9498 * image.c: Make symbols static if they're not exported.
9499 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
9501 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
9502 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
9504 * fringe.c (standard_bitmaps): Now static.
9505 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
9507 * frame.c: Make symbols static if they're not exported.
9508 (x_report_frame_params, make_terminal_frame): Now static.
9509 (get_frame_param): Now static, unless HAVE_NS.
9510 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
9511 (x_get_resource_string): Remove; not used.
9512 * frame.h (make_terminal_frame, x_report_frame_params):
9513 (x_get_resource_string); Remove decls.
9514 (x_fullscreen_adjust): Declare only if WINDOWSNT.
9515 * lisp.h (get_frame_param): Declare only if HAVE_NS.
9517 * font.c, fontset.c: Make symbols static if they're not exported.
9518 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
9519 (FACE_SUITABLE_FOR_CHAR_P): Use it.
9520 * font.c (font_close_object): Now static.
9521 * font.h (font_close_object): Remove.
9522 * fontset.c (FONTSET_OBJLIST): Remove.
9523 (free_realized_fontset) #if-0 the body, which does nothing.
9524 (face_suitable_for_char_p): #if-0, as it's never called.
9525 * fontset.h (face_suitable_for_char_p): Remove decl.
9526 * xfaces.c (face_at_string_position):
9527 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
9528 since 0 is always ASCII.
9530 * fns.c (weak_hash_tables): Now static.
9532 * fileio.c: Make symbols static if they're not exported.
9533 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
9534 (Vwrite_region_annotation_buffers): Now static.
9536 * eval.c: Make symbols static if they're not exported.
9537 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
9538 * lisp.h (backtrace_list): Remove decl.
9540 * emacs.c: Make symbols static if they're not exported.
9541 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
9542 (fatal_error_code, fatal_error_signal_hook, standard_args):
9544 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
9545 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
9546 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
9547 * lisp.h (fatal_error_signal_hook): Remove decl.
9548 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
9550 * editfns.c: Move a (normally-unused) function to its only use.
9551 * editfns.c, lisp.h (get_operating_system_release): Remove.
9552 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
9553 worth the hassle of breaking this out.
9555 * xterm.c: Make symbols static if they're not exported.
9556 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
9557 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
9558 (x_destroy_window, x_delete_display):
9560 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
9561 (x_mouse_leave): Remove; unused.
9562 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
9563 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
9564 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
9566 (x_mouse_leave): Declare only if WINDOWSNT.
9567 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
9568 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
9571 * ftxfont.c: Make symbols static if they're not exported.
9572 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
9574 * font.h (ftxfont_driver): Likewise.
9576 * xfns.c: Make symbols static if they're not exported.
9577 (x_last_font_name, x_display_info_for_name):
9578 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
9579 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
9580 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
9581 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
9582 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
9583 (last_show_tip_args): Now static.
9584 (xic_defaut_fontset, xic_create_fontsetname): Define only if
9585 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
9586 (x_screen_planes): Remove; unused.
9587 * dispextern.h (x_screen_planes): Remove decl.
9589 * dispnew.c: Make symbols static if they're not exported.
9590 * dispextern.h (redraw_garbaged_frames, scrolling):
9591 (increment_row_positions): Remove.
9592 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
9593 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
9595 (redraw_garbaged_frames): Remove; unused.
9597 * xfaces.c: Make symbols static if they're not exported.
9598 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
9600 * xterm.h (defined_color): Remove decls.
9601 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
9602 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
9603 (menu_face_changed_default, defined_color, free_realized_face):
9604 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
9605 (ascii_face_of_lisp_face): Remove; unused.
9607 * xdisp.c: Make symbols static if they're not exported.
9608 * dispextern.h (scratch_glyph_row, window_box_edges):
9609 (glyph_to_pixel_coords, set_cursor_from_row):
9610 (get_next_display_element, set_iterator_to_next):
9611 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
9612 (show_mouse_face): Remove decls
9613 * frame.h (message_buf_print): Likewise.
9614 * lisp.h (pop_message, set_message, check_point_in_composition):
9616 * xterm.h (set_vertical_scroll_bar): Likewise.
9617 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
9618 (message_buf_print, scratch_glyph_row, displayed_buffer):
9619 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
9620 (get_next_display_element, show_mouse_face, window_box_edges):
9621 (frame_to_window_pixel_xy, check_point_in_composition):
9622 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
9623 (glyph_to_pixel_coords): Remove; unused.
9625 * dired.c (file_name_completion): Now static.
9627 * dbusbind.c (xd_in_read_queued_messages): Now static.
9629 * lisp.h (circular_list_error, FOREACH): Remove; unused.
9630 * data.c (circular_list_error): Remove.
9632 * commands.h (last_point_position, last_point_position_buffer):
9633 (last_point_position_window): Remove decls.
9634 * keyboard.c: Make these variables static.
9636 * coding.h (coding, code_convert_region, encode_coding_gap):
9638 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
9639 (iso_code_class, detect_coding, code_convert_region): Now static.
9640 (encode_coding_gap): Remove; unused.
9642 * chartab.c (chartab_chars, chartab_bits): Now static.
9644 * charset.h (charset_iso_8859_1): Remove decl.
9645 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
9648 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
9649 * ccl.c (Vccl_program_table): Now static.
9650 (check_ccl_update): Remove; unused.
9652 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
9653 * category.h: ... from here.
9654 * category.c (check_category_table, set_category_set): Now static.
9656 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
9657 * lisp.h: Remove these decls.
9659 * buffer.c (buffer_count): Remove unused var.
9661 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
9662 so that it's not optimized away.
9663 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
9664 * dispextern.h (bidi_dump_cached_states): Remove, since it's
9665 exported only to the debugger.
9667 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
9668 * atimer.h (run_all_atimers): Remove; not exported.
9670 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
9671 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
9672 was inaccessible from Lisp.
9673 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
9674 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
9676 alloc.c: Import and export fewer symbols, and remove unused items.
9677 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
9679 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
9680 it's not optimized away by whole-program optimization.
9681 (message_enable_multibyte, free_misc): Remove.
9682 (catchlist, handlerlist, mark_backtrace):
9683 Declare only if BYTE_MARK_STACK.
9684 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
9685 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
9686 (message_enable_multibyte): Remove decl.
9687 (free_misc, interval_free_list, float_block, float_block_index):
9688 (n_float_blocks, float_free_list, cons_block, cons_block_index):
9689 (cons_free_list, last_marked_index):
9691 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
9692 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
9693 (mark_backtrace): Define only if BYTE_MARK_STACK.
9694 * xdisp.c (message_enable_multibyte): Now static.
9696 Declare Lisp_Object Q* variables to be 'static' if not exported.
9697 This makes it easier for human readers (and static analyzers)
9698 to see whether these variables are used from other modules.
9699 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
9700 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
9701 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
9702 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
9703 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
9704 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
9705 * xmenu.c, xselect.c:
9706 Declare Q* vars static if they are not used in other modules.
9707 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
9708 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
9709 Remove decls of unexported vars.
9710 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
9712 * lisp.h (DEFINE_FUNC): Make sname 'static'.
9714 Make Emacs functions such as Fatom 'static' by default.
9715 This makes it easier for human readers (and static analyzers)
9716 to see whether these functions can be called from other modules.
9717 DEFUN now defines a static function. To make the function external
9718 so that it can be used in other C modules, use the new macro DEFUE.
9719 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
9720 (Finit_image_library):
9721 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
9722 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
9723 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
9724 Remove decls, since these functions are now static.
9725 (Funintern, Fget_internal_run_time): New decls, since these functions
9726 were already external.
9728 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
9729 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
9730 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
9731 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
9732 * keyboard.c, keymap.c, lread.c:
9733 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
9734 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
9735 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
9736 Mark functions with DEFUE instead of DEFUN,
9737 if they are used in other modules.
9738 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
9739 decls for now-static functions.
9740 * buffer.h (Fdelete_overlay): Remove decl.
9741 * callproc.c (Fgetenv_internal): Mark as internal.
9742 * composite.c (Fremove_list_of_text_properties): Remove decl.
9743 (Fcomposition_get_gstring): New forward static decl.
9744 * composite.h (Fcomposite_get_gstring): Remove decl.
9745 * dired.c (Ffile_attributes): New forward static decl.
9746 * doc.c (Fdocumntation_property): New forward static decl.
9747 * eval.c (Ffetch_bytecode): New forward static decl.
9748 (Funintern): Remove extern decl; now in .h file where it belongs.
9749 * fileio.c (Fmake_symbolic_link): New forward static decl.
9750 * image.c (Finit_image_library): New forward static decl.
9751 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
9752 * intervals.h (Fprevious_property_change):
9753 (Fremove_list_of_text_properties): Remove decls.
9754 * keyboard.c (Fthis_command_keys): Remove decl.
9755 (Fcommand_execute): New forward static decl.
9756 * keymap.c (Flookup_key): New forward static decl.
9757 (Fcopy_keymap): Now static.
9758 * keymap.h (Flookup_key): Remove decl.
9759 * process.c (Fget_process): New forward static decl.
9760 (Fprocess_datagram_address): Mark as internal.
9761 * syntax.c (Fsyntax_table_p): New forward static decl.
9762 (skip_chars): Remove duplicate decl.
9763 * textprop.c (Fprevious_property_change): New forward static decl.
9764 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
9766 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
9767 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
9769 * editfns.c (Fformat): Remove unreachable code.
9771 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
9773 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
9776 2011-04-13 Eli Zaretskii <eliz@gnu.org>
9778 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
9779 when at ZV. (Bug#8487)
9781 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
9783 * charset.c (Fclear_charset_maps): Use xfree instead of free.
9785 * keyboard.c (parse_tool_bar_item): Likewise.
9786 * sound.c (sound_cleanup, alsa_close): Likewise.
9787 * termcap.c (tgetent): Likewise.
9788 * xfns.c (x_default_font_parameter): Likewise.
9789 * xsettings.c (read_and_apply_settings): Likewise.
9791 * alloc.c (overrun_check_malloc, overrun_check_realloc)
9792 (overrun_check_free): Protoize.
9794 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
9796 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
9797 since callers should never pass a negative size.
9798 Change the signature to match that of plain 'read' and 'write'; see
9799 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
9800 * lisp.h: Update prototypes of emacs_write and emacs_read.
9802 2011-04-11 Eli Zaretskii <eliz@gnu.org>
9804 * xdisp.c (redisplay_window): Don't try to determine the character
9805 position of the scroll margin if the window start point w->startp
9806 is outside the buffer's accessible region. (Bug#8468)
9808 2011-04-10 Eli Zaretskii <eliz@gnu.org>
9810 Fix write-region and its subroutines for buffers > 2GB.
9811 * fileio.c (a_write, e_write): Modify declaration of arguments and
9812 local variables to support buffers larger than 2GB.
9813 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
9815 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
9816 argument, local variables, and return value.
9818 * lisp.h: Update prototypes of emacs_write and emacs_read.
9820 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
9822 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
9824 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
9826 Fix more problems found by GCC 4.6.0's static checks.
9828 * xdisp.c (vmessage): Use a better test for character truncation.
9830 * charset.c (load_charset_map): <, not <=, for optimization,
9831 and to avoid potential problems with integer overflow.
9832 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
9833 * casetab.c (set_identity, shuffle): Likewise.
9834 * editfns.c (Fformat): Likewise.
9835 * syntax.c (skip_chars): Likewise.
9837 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
9838 This also lets GCC 4.6.0 generate slightly better loop code.
9840 * callint.c (Fcall_interactively): <, not <=, for optimization.
9841 (Fcall_interactively): Count the number of arguments produced,
9842 not the number of arguments given. This is simpler and lets GCC
9843 4.6.0 generate slightly better code.
9845 * ftfont.c: Distingish more carefully between FcChar8 and char.
9846 The previous code passed unsigned char * to a functions like
9847 strlen and xstrcasecmp that expect char *, which does not
9848 conform to the C standard.
9849 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
9850 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
9851 char * when the C standard requires it.
9853 * keyboard.c (read_char): Remove unused var.
9855 * eval.c: Port to Windows vsnprintf (Bug#8435).
9857 (SIZE_MAX): Define if the headers do not.
9858 (verror): Do not give up if vsnprintf returns a negative count.
9859 Instead, grow the buffer. This ports to Windows vsnprintf, which
9860 does not conform to C99. Problem reported by Eli Zaretskii.
9861 Also, simplify the allocation scheme, by avoiding the need for
9862 calling realloc, and removing the ALLOCATED variable.
9864 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
9866 Remove invocations of doprnt, as Emacs now uses vsnprintf.
9867 But keep the doprint source code for now, as we might revamp it
9868 and use it again (Bug#8435).
9869 * lisp.h (doprnt): Remove.
9870 * Makefile.in (base_obj): Remove doprnt.o.
9871 * deps.mk (doprnt.o): Remove.
9873 error: Print 32- and 64-bit integers portably (Bug#8435).
9874 Without this change, on typical 64-bit hosts error ("...%d...", N)
9875 was used to print both 32- and 64-bit integers N, which relied on
9877 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
9878 * lisp.h (error, verror): Mark as printf-like functions.
9879 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
9880 Report overflow in size calculations when allocating printf buffer.
9881 Do not truncate output string at its first null byte.
9882 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
9883 Truncate the output at a character boundary, since vsnprintf does not
9885 * charset.c (check_iso_charset_parameter): Convert internal
9886 character to string before calling 'error', since %c now has the
9888 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
9889 overflow when computing char to be passed to 'error'. Do not
9890 pass Lisp_Object to 'error'; pass the integer instead.
9891 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
9892 formatted with plain %d.
9894 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
9896 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
9898 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
9900 * xterm.c (x_catch_errors): Remove duplicate declaration.
9902 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
9904 * xdisp.c, lisp.h (message_nolog): Remove; unused.
9906 2011-04-10 Jim Meyering <meyering@redhat.com>
9908 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
9909 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
9910 return ssize_t not "int", and use size_t as the buffer length.
9911 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
9912 * gnutls.h: Update declarations.
9913 * process.c (read_process_output): Use ssize_t, to match.
9914 (send_process): Likewise.
9916 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
9918 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
9920 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
9922 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
9923 Use unsigned char, to match FcChar8 type definition.
9925 * xterm.c (handle_one_xevent):
9926 * xmenu.c (create_and_show_popup_menu):
9927 * xselect.c (x_decline_selection_request)
9928 (x_reply_selection_request): Avoid type-punned deref of X events.
9930 2011-04-09 Eli Zaretskii <eliz@gnu.org>
9932 Fix some uses of `int' instead of EMACS_INT.
9933 * search.c (string_match_1, fast_string_match)
9934 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
9935 (scan_buffer, find_next_newline_no_quit)
9936 (find_before_next_newline, search_command, Freplace_match)
9937 (Fmatch_data): Make some `int' variables be EMACS_INT.
9939 * xdisp.c (display_count_lines): 3rd argument and return value now
9940 EMACS_INT. All callers changed.
9941 (pint2hrstr): Last argument is now EMACS_INT.
9943 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
9944 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
9945 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
9946 (decode_coding_utf_16, decode_coding_emacs_mule)
9947 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
9948 (decode_coding_ccl, decode_coding_charset)
9949 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
9950 (decode_coding_iso_2022, decode_coding_emacs_mule)
9951 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
9952 <char_offset, last_offset>: Declare EMACS_INT.
9953 (encode_coding_utf_8, encode_coding_utf_16)
9954 (encode_coding_emacs_mule, encode_invocation_designation)
9955 (encode_designation_at_bol, encode_coding_iso_2022)
9956 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
9957 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
9959 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
9960 (encode_invocation_designation): Last argument P_NCHARS is now
9962 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
9963 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
9965 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
9968 * ccl.c (Fccl_execute_on_string): Declare some variables
9971 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
9973 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
9975 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
9977 * process.c (Fformat_network_address): Doc fix.
9979 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
9981 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
9983 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
9985 * keyboard.c (read_char): Call Lisp function help-form-show,
9986 instead of using internal_with_output_to_temp_buffer.
9987 (Qhelp_form_show): New var.
9988 (syms_of_keyboard): Use DEFSYM macro.
9990 * print.c (internal_with_output_to_temp_buffer): Function deleted.
9992 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
9994 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
9996 * process.c (Flist_processes): Remove to Lisp.
9997 (list_processes_1): Delete.
9999 2011-04-06 Eli Zaretskii <eliz@gnu.org>
10001 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
10003 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
10005 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
10007 Fix more problems found by GCC 4.6.0's static checks.
10009 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
10011 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
10013 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
10015 * xdisp.c (vmessage): Mark as a printf-like function.
10017 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
10019 * sound.c (sound_warning): Don't crash if arg contains a printf format.
10021 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
10022 printf-like functions.
10023 (tiff_load): Add casts to remove these marks before passing them
10024 to system-supplied API.
10026 * eval.c (Fsignal): Remove excess argument to 'fatal'.
10028 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
10029 This avoids several warnings with gcc -Wstrict-overflow.
10030 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
10031 directly, rather than having caller test rule sign. This avoids
10032 some unnecessary tests.
10033 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
10034 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
10035 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
10037 * xfont.c (xfont_text_extents): Remove var that was set but not used.
10038 (xfont_open): Avoid unnecessary tests.
10040 * composite.c (composition_gstring_put_cache): Use unsigned integer.
10042 * composite.h, composite.c (composition_gstring_put_cache):
10043 Use EMACS_INT, not int, for length.
10045 * composite.h (COMPOSITION_DECODE_REFS): New macro,
10046 breaking out part of COMPOSITION_DECODE_RULE.
10047 (COMPOSITION_DECODE_RULE): Use it.
10048 * composite.c (get_composition_id): Remove unused local vars,
10049 by using the new macro.
10051 * textprop.c (set_text_properties_1): Change while to do-while,
10052 since the condition is always true at first.
10054 * intervals.c (graft_intervals_into_buffer): Mark var as used.
10055 (interval_deletion_adjustment): Return unsigned value.
10058 * process.c (list_processes_1, create_pty, read_process_output):
10059 (exec_sentinel): Remove vars that were set but not used.
10060 (create_pty): Remove unnecessary "volatile"s.
10061 (Fnetwork_interface_info): Avoid possibility of int overflow.
10062 (read_process_output): Do adaptive read buffering even if carryover.
10063 (read_process_output): Simplify nbytes computation if buffered.
10065 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
10067 * syntax.c (scan_words): Remove var that was set but not used.
10068 (update_syntax_table): Use unsigned instead of int.
10070 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
10071 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
10072 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
10074 * print.c (print_error_message): Avoid int overflow.
10076 * font.c (font_list_entities): Redo for clarity,
10077 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
10079 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
10080 (font_score): Avoid potential overflow in diff calculation.
10082 * fns.c (substring_both): Remove var that is set but not used.
10083 (sxhash): Redo loop for clarity and to avoid wraparound warning.
10085 * eval.c (funcall_lambda): Rename local to avoid shadowing.
10087 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
10088 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
10089 can always succeed if overflow has undefined behavior.
10091 * search.c (boyer_moore, wordify): Remove vars set but not used.
10092 (wordify): Omit three unnecessary tests.
10094 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
10095 All callers changed. This avoids the need for an unused var.
10097 * casefiddle.c (casify_region): Remove var that is set but not used.
10099 * dired.c (file_name_completion): Remove var that is set but not used.
10101 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
10103 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
10104 (Finsert_file_contents): Remove unnecessary code checking fd.
10106 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
10107 Check for integer overflow on size calculations.
10109 * buffer.c (Fprevious_overlay_change): Remove var that is set
10112 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
10113 Remove vars that are set but not used.
10114 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
10115 (timer_check_2): Mark vars as initialized.
10117 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
10119 * image.c (lookup_image): Remove var that is set but not used.
10120 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
10122 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
10123 that are set but not used.
10125 * xfns.c (make_invisible_cursor): Don't return garbage
10126 if XCreateBitmapFromData fails (Bug#8410).
10128 * xselect.c (x_get_local_selection, x_handle_property_notify):
10129 Remove vars that are set but not used.
10131 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
10132 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
10134 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
10135 Remove var that is set but not used.
10136 (scroll_bar_windows_size): Now size_t, not int.
10137 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
10138 Check for overflow.
10140 * xfaces.c (realize_named_face): Remove vars that are set but not used.
10141 (map_tty_color) [!defined MSDOS]: Likewise.
10143 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
10145 * coding.c: Remove vars that are set but not used.
10146 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
10147 All callers changed.
10148 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
10149 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
10150 (decode_coding_charset): Remove vars that are set but not used.
10152 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
10153 that is set but not used.
10155 * print.c (print_object): Remove var that is set but not used.
10157 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
10158 The gnulib version avoids calling malloc in the usual case,
10159 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
10160 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
10161 * filelock.c (current_lock_owner): Likewise.
10162 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
10163 * sysdep.c: Include allocator.h, careadlinkat.h.
10164 (emacs_no_realloc_allocator): New static constant.
10165 (emacs_readlink): New function.
10166 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
10167 ../lib/careadlinkat.h.
10169 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
10171 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
10172 first non-nil return value).
10174 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
10176 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
10177 if not defined (Bug#8403).
10179 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
10181 * xdisp.c (display_count_lines): Remove parameter `start',
10182 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10183 (get_char_face_and_encoding): Remove parameter `multibyte_p',
10184 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10185 (fill_stretch_glyph_string): Remove parameters `row' and `area',
10186 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
10187 and thereabouts. All callers changed.
10188 (get_per_char_metric): Remove parameter `f', unused since
10189 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10191 2011-04-02 Jim Meyering <meyering@redhat.com>
10193 do not dereference NULL upon failed strdup
10194 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
10195 (ns_get_family): Likewise.
10197 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
10199 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
10201 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
10203 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
10206 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
10208 Add lexical binding.
10210 * window.c (Ftemp_output_buffer_show): New fun.
10211 (Fsave_window_excursion):
10212 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
10214 * lread.c (lisp_file_lexically_bound_p): New function.
10215 (Fload): Bind Qlexical_binding.
10216 (readevalloop): Remove `evalfun' arg.
10217 Bind Qinternal_interpreter_environment.
10218 (Feval_buffer): Bind Qlexical_binding.
10219 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
10221 (syms_of_lread): Declare `lexical-binding'.
10223 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
10225 * keyboard.c (eval_dyn): New fun.
10226 (menu_item_eval_property): Use it.
10228 * image.c (parse_image_spec): Use Ffunctionp.
10230 * fns.c (concat, mapcar1): Accept byte-code-functions.
10232 * eval.c (Fsetq): Handle lexical vars.
10233 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
10234 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
10235 (FletX, Flet): Obey lexical binding.
10236 (Fcommandp): Handle closures.
10237 (Feval): New `lexical' arg.
10238 (eval_sub): New function extracted from Feval. Use it almost
10239 everywhere where Feval was used. Look up vars in lexical env.
10241 (Ffunctionp): Move from subr.el.
10242 (Ffuncall): Handle closures.
10243 (apply_lambda): Remove `eval_flags'.
10244 (funcall_lambda): Handle closures and new byte-code-functions.
10245 (Fspecial_variable_p): New function.
10246 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
10247 but without exporting it to Lisp.
10249 * doc.c (Fdocumentation, store_function_docstring):
10250 * data.c (Finteractive_form): Handle closures.
10252 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
10255 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
10257 (exec_byte_code): New function extracted from Fbyte_code to handle new
10258 calling convention for byte-code-functions. Add new byte-codes.
10260 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
10262 * alloc.c (Fmake_symbol): Init new `declared_special' field.
10264 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
10266 * xdisp.c (redisplay_internal): Fix prototype.
10268 2011-03-31 Eli Zaretskii <eliz@gnu.org>
10270 * xdisp.c (SCROLL_LIMIT): New macro.
10271 (try_scrolling): Use it when setting scroll_limit.
10272 Limit scrolling to 100 screen lines.
10273 (redisplay_window): Even when falling back on "recentering",
10274 position point in the window according to scroll-conservatively,
10275 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
10277 (try_scrolling): When point is above the window, allow searching
10278 as far as scroll_max, or one screenful, to compute vertical
10279 distance from PT to the scroll margin position. This prevents
10280 try_scrolling from unnecessarily failing when
10281 scroll-conservatively is set to a value slightly larger than the
10282 window height. Clean up the case of PT below the margin at bottom
10283 of window: scroll_max can no longer be INT_MAX. When aggressive
10284 scrolling is in use, don't let point enter the opposite scroll
10285 margin as result of the scroll.
10286 (syms_of_xdisp) <scroll-conservatively>: Document the
10287 threshold of 100 lines for never-recentering scrolling.
10289 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
10291 * dispextern.h (move_it_by_lines):
10292 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
10293 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
10294 (message_log_check_duplicate): Remove parameters `prev_bol' and
10295 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10296 (redisplay_internal): Remove parameter `preserve_echo_area',
10297 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
10299 * indent.c (Fvertical_motion):
10300 * window.c (window_scroll_pixel_based, Frecenter):
10301 Don't pass `need_y_p' to `move_it_by_lines'.
10303 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
10305 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
10306 steal a few bits to be more compact.
10307 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
10308 Remove unneeded casts.
10310 * bytecode.c (Fbyte_code): CAR and CDR can GC.
10312 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
10314 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
10315 binding" message (bug#7967).
10317 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
10319 Fix more problems found by GCC 4.6.0's static checks.
10321 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
10322 Remove unused local var.
10324 * editfns.c (Fmessage_box): Remove unused local var.
10326 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
10327 (note_mode_line_or_margin_highlight, note_mouse_highlight):
10328 Omit unused local vars.
10329 * window.c (shrink_windows): Omit unused local var.
10330 * menu.c (digest_single_submenu): Omit unused local var.
10331 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
10332 Omit unused local var.
10334 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
10335 Don't assume string length fits in int.
10336 (keyremap_step, read_key_sequence): Use size_t for sizes.
10337 (read_key_sequence): Don't check last_real_key_start redundantly.
10339 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
10340 instead of alloca (Bug#8344).
10342 * eval.c (Fbacktrace): Don't assume nargs fits in int.
10343 (Fbacktrace_frame): Don't assume nframes fits in int.
10345 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
10347 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
10350 * term.c (produce_glyphless_glyph): Remove unnecessary test.
10352 * cm.c (calccost): Turn while-do into do-while, for clarity.
10354 * keyboard.c (syms_of_keyboard): Use the same style as later
10355 in this function when indexing through an array. This also
10356 works around GCC bug 48267.
10358 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
10360 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
10362 * chartab.c (sub_char_table_ref_and_range): Redo for slight
10363 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
10365 * keyboard.c, keyboard.h (num_input_events): Now size_t.
10366 This avoids undefined behavior on integer overflow, and is a bit
10367 more convenient anyway since it is compared to a size_t variable.
10369 Variadic C functions now count arguments with size_t, not int.
10370 This avoids an unnecessary limitation on 64-bit machines, which
10371 caused (substring ...) to crash on large vectors (Bug#8344).
10372 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
10373 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
10374 All variadic functions and their callers changed accordingly.
10375 (struct gcpro.nvars): Now size_t, not int. All uses changed.
10376 * data.c (arith_driver, float_arith_driver): Likewise.
10377 * editfns.c (general_insert_function): Likewise.
10378 * eval.c (struct backtrace.nargs, interactive_p)
10379 (internal_condition_case_n, run_hook_with_args, apply_lambda)
10380 (funcall_lambda, mark_backtrace): Likewise.
10381 * fns.c (concat): Likewise.
10382 * frame.c (x_set_frame_parameters): Likewise.
10383 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
10384 0 if not found, not -1. All callers changed.
10386 * alloc.c (garbage_collect): Don't assume stack size fits in int.
10387 (stack_copy_size): Now size_t, not int.
10388 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
10390 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
10392 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
10393 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10394 All callers changed.
10396 * lisp.h (multibyte_char_to_unibyte):
10397 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
10398 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10399 * character.h (CHAR_TO_BYTE8):
10400 * cmds.c (internal_self_insert):
10401 * editfns.c (general_insert_function):
10402 * keymap.c (push_key_description):
10403 * search.c (Freplace_match):
10404 * xdisp.c (message_dolog, set_message_1): All callers changed.
10406 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
10408 * keyboard.c (safe_run_hook_funcall): New function.
10409 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
10410 don't set the hook to nil, but remove the offending function instead.
10411 (Qcommand_hook_internal): Remove, unused.
10412 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
10413 Vcommand_hook_internal.
10415 * eval.c (enum run_hooks_condition): Remove.
10416 (funcall_nil, funcall_not): New functions.
10417 (run_hook_with_args): Call each function through a `funcall' argument.
10418 Remove `cond' argument, now redundant.
10419 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
10420 (Frun_hook_with_args_until_failure): Adjust accordingly.
10421 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
10423 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
10425 * dispextern.h (string_buffer_position): Remove declaration.
10427 * print.c (strout): Remove parameter `multibyte', unused since
10428 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
10430 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
10431 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
10432 All callers changed.
10434 * w32.c (_wsa_errlist): Use braces for struct initializers.
10436 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
10437 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
10438 All callers changed.
10439 (string_buffer_position): Likewise. Also, make static (it's never
10440 used outside xdisp.c).
10441 (cursor_row_p): Remove parameter `w', unused since
10442 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
10443 (decode_mode_spec): Remove parameter `precision', introduced during
10444 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
10445 All callers changed.
10447 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10449 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
10451 2011-03-27 Anders Lindgren <andlind@gmail.com>
10453 * nsterm.m (ns_menu_bar_is_hidden): New variable.
10454 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
10455 (ns_update_auto_hide_menu_bar): New functions.
10456 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
10457 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
10458 ns_constrain_all_frames.
10459 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
10460 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
10462 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10464 * nsmenu.m (runDialogAt): Remove argument to timer_check.
10466 2011-03-27 Glenn Morris <rgm@gnu.org>
10468 * syssignal.h: Replace RETSIGTYPE with void.
10469 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
10470 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
10471 Replace SIGTYPE with void everywhere.
10472 * s/usg5-4-common.h (SIGTYPE): Remove definition.
10473 * s/template.h (SIGTYPE): Remove commented out definition.
10475 2011-03-26 Eli Zaretskii <eliz@gnu.org>
10477 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
10478 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
10480 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
10482 * w32.c (read_unc_volume): Use parameter `henum', instead of
10483 global variable `wget_enum_handle'.
10485 * keymap.c (describe_vector): Remove parameters `indices' and
10486 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
10487 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
10489 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
10491 * keyboard.c (timer_check): Remove parameter `do_it_now',
10492 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
10493 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
10494 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
10496 * keyboard.c (read_char):
10497 * w32menu.c (w32_menu_display_help):
10498 * xmenu.c (show_help_event, menu_help_callback):
10499 Adjust calls to `show_help_echo'.
10501 * gtkutil.c (xg_maybe_add_timer):
10502 * keyboard.c (readable_events):
10503 * process.c (wait_reading_process_output):
10504 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
10506 * insdel.c (adjust_markers_gap_motion):
10507 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
10508 (gap_left, gap_right): Don't call it.
10510 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
10512 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
10513 incurred during fontification.
10515 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
10517 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
10518 (DEFVAR_PER_BUFFER): Don't pass it.
10520 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
10521 (scrolling_window): Don't pass it.
10523 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
10525 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
10527 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
10529 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
10530 of variables specific to SELinux and computation of `encoded_absname'.
10532 * image.c (XPutPixel): Remove unused variable `height'.
10534 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
10536 * unexw32.c (get_section_info): Remove unused variable `section'.
10538 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
10539 (system_process_attributes): Remove unused variable `sess'.
10540 (sys_read): Remove unused variable `err'.
10542 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
10543 (w32_wnd_proc): Remove unused variable `isdead'.
10544 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
10545 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
10546 (x_create_tip_frame): Remove unused variable `tem'.
10548 * w32inevt.c (w32_console_read_socket):
10549 Remove unused variable `no_events'.
10551 * w32term.c (x_draw_composite_glyph_string_foreground):
10552 Remove unused variable `width'.
10554 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
10556 * w32term.c (x_set_glyph_string_clipping):
10557 Don't pass uninitialized region to CombineRgn.
10559 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
10561 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
10562 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
10563 (Fx_close_connection): Remove unused variable `i'.
10565 * w32font.c (w32font_draw): Return number of glyphs.
10566 (w32font_open_internal): Remove unused variable `i'.
10567 (w32font_driver): Add missing initializer.
10569 * w32menu.c (utf8to16): Remove unused variable `utf16'.
10570 (fill_in_menu): Remove unused variable `items_added'.
10572 * w32term.c (last_mouse_press_frame): Remove static global variable.
10573 (w32_clip_to_row): Remove unused variable `f'.
10574 (x_delete_terminal): Remove unused variable `i'.
10576 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
10577 (NOTHING): Remove unused static global variable.
10578 (uniscribe_check_otf): Remove unused variable `table'.
10579 (uniscribe_font_driver): Add missing initializers.
10581 2011-03-23 Julien Danjou <julien@danjou.info>
10583 * term.c (Fsuspend_tty, Fresume_tty):
10584 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
10585 * window.c (temp_output_buffer_show):
10586 * insdel.c (signal_before_change):
10587 * frame.c (Fhandle_switch_frame):
10588 * fileio.c (Fdo_auto_save):
10589 * emacs.c (Fkill_emacs):
10590 * editfns.c (save_excursion_restore):
10591 * cmds.c (internal_self_insert):
10592 * callint.c (Fcall_interactively):
10593 * buffer.c (Fkill_all_local_variables):
10594 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
10596 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
10597 unconditionally since it does the check itself.
10599 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
10601 Fix more problems found by GCC 4.5.2's static checks.
10603 * coding.c (encode_coding_raw_text): Avoid unnecessary test
10604 the first time through the loop, since we know p0 < p1 then.
10605 This also avoids a gcc -Wstrict-overflow warning.
10607 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
10608 leading to a memory leak, possible in functions like
10609 load_charset_map_from_file that can allocate an unbounded number
10610 of objects (Bug#8318).
10612 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
10613 that could (at least in theory) be that large.
10615 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
10616 This is less likely to overflow, and avoids undefined behavior if
10617 overflow does occur. All callers changed. Use strtoul to scan
10618 for the unsigned long integer.
10619 (pint2hrstr): Simplify and tune code slightly.
10620 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
10622 * scroll.c (do_scrolling): Work around GCC bug 48228.
10623 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
10625 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
10626 This also avoids a warning with gcc -Wstrict-overflow.
10627 (validate_x_resource_name): Simplify count usage.
10628 This also avoids a warning with gcc -Wstrict-overflow.
10630 * fileio.c (Fcopy_file): Report error if fchown or fchmod
10633 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
10635 * process.c (Fmake_network_process): Use socklen_t, not int,
10636 where POSIX says socklen_t is required in portable programs.
10637 This fixes a porting bug on hosts like 64-bit HP-UX, where
10638 socklen_t is wider than int (Bug#8277).
10639 (Fmake_network_process, server_accept_connection):
10640 (wait_reading_process_output, read_process_output):
10643 * process.c: Rename or move locals to avoid shadowing.
10644 (list_processes_1, Fmake_network_process):
10645 (read_process_output_error_handler, exec_sentinel_error_handler):
10646 Rename or move locals.
10647 (Fmake_network_process): Define label "retry_connect" only if needed.
10648 (Fnetwork_interface_info): Fix pointer signedness.
10649 (process_send_signal): Add cast to avoid pointer signedness problem.
10650 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
10651 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
10653 Make tparam.h and terminfo.c consistent.
10654 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
10655 Include tparam.h instead, since it declares them.
10656 * cm.h (PC): Remove extern decl; tparam.h now does this.
10657 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
10658 * terminfo.c: Include tparam.h, to check interfaces.
10659 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
10660 (tparam): Adjust signature to match interface in tparam.h;
10661 this removes some undefined behavior. Check that outstring and len
10662 are zero, which they always are with Emacs.
10663 * tparam.h (PC, BC, UP): New extern decls.
10665 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
10666 (xftfont_open): Rename locals to avoid shadowing.
10668 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
10669 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
10670 (OTF_TAG_SYM): Omit macro if not needed.
10671 (ftfont_list): Remove unused local.
10672 (get_adstyle_property, ftfont_pattern_entity):
10673 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
10674 Rename locals to avoid shadowing.
10676 * xfont.c (xfont_list_family): Mark var as initialized.
10678 * xml.c (make_dom): Now static.
10680 * composite.c (composition_compute_stop_pos): Rename local to
10682 (composition_reseat_it): Remove unused locals.
10683 (find_automatic_composition, composition_adjust_point): Likewise.
10684 (composition_update_it): Mark var as initialized.
10685 (find_automatic_composition): Mark vars as initialized,
10686 with a FIXME (Bug#8290).
10688 character.h: Rename locals to avoid shadowing.
10689 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
10690 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
10691 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
10692 (BUF_DEC_POS): Be more systematic about renaming local temporaries
10693 to avoid shadowing.
10695 * textprop.c (property_change_between_p): Remove; unused.
10697 * intervals.c (interval_start_pos): Now static.
10699 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
10701 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
10702 Rename locals to avoid shadowing.
10704 * sound.c (wav_play, au_play, Fplay_sound_internal):
10705 Fix pointer signedness.
10706 (alsa_choose_format): Remove unused local var.
10707 (wav_play): Initialize a variable to 0, to prevent undefined
10708 behavior (Bug#8278).
10710 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
10712 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
10714 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
10715 clobbering (Bug#8298).
10716 * sysdep.c (sys_subshell): Likewise.
10717 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
10719 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
10720 This should get cleaned up, so that child_setup has the
10721 same signature on all platforms.
10723 * callproc.c (call_process_cleanup): Now static.
10724 (relocate_fd): Rename locals to avoid shadowing.
10726 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
10728 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
10729 not to be necessary, and produces flickering.
10731 2011-03-20 Glenn Morris <rgm@gnu.org>
10733 * config.in: Remove file.
10735 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
10737 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
10738 are now in src/globals.h.
10739 (syms_of_minibuf): Remove spurious & from previous change.
10741 2011-03-20 Leo Liu <sdl.web@gmail.com>
10743 * minibuf.c (completing-read-function): New variable.
10744 (completing-read-default): Rename from completing-read.
10745 (completing-read): Call completing-read-function.
10747 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
10749 * xfaces.c (Fx_load_color_file):
10750 Read color file from absolute filename (bug#8250).
10752 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
10754 * makefile.w32-in: Update dependencies.
10756 2011-03-17 Eli Zaretskii <eliz@gnu.org>
10758 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
10760 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
10762 Fix more problems found by GCC 4.5.2's static checks.
10764 * process.c (make_serial_process_unwind, send_process_trap):
10765 (sigchld_handler): Now static.
10767 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
10768 That way, the code declares only the vars that it needs.
10769 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
10770 * s/cygwin.h (PTY_ITERATION): Likewise.
10771 * s/darwin.h (PTY_ITERATION): Likewise.
10772 * s/gnu-linux.h (PTY_ITERATION): Likewise.
10774 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
10775 * process.c (allocate_pty): Don't declare stb unless it's needed.
10777 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
10778 (CONSTANTLIM): Remove; unused.
10779 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
10780 Define only if needed.
10782 * unexelf.c (unexec): Name an expression,
10783 to avoid gcc -Wbad-function-cast warning.
10784 Use a different way to cause a compilation error if anyone uses
10785 n rather than nn, a way that does not involve shadowing.
10786 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
10788 * deps.mk (unexalpha.o): Remove; unused.
10790 New file unexec.h, the (simple) interface for unexec (Bug#8267).
10791 * unexec.h: New file.
10792 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
10793 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
10794 Depend on unexec.h.
10795 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
10796 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
10797 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
10798 Change as necessary to match prototype in unexec.h.
10800 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
10802 (back_comment, skip_chars): Mark vars as initialized.
10804 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
10805 Rename locals to avoid shadowing.
10807 * lread.c (read1): Rewrite so as not to use empty "else".
10808 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
10810 * print.c (Fredirect_debugging_output): Fix pointer signedess.
10812 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
10813 warning when compiling print.c.
10815 * font.c (font_unparse_fcname): Abort in an "impossible" situation
10816 instead of using an uninitialized var.
10817 (font_sort_entities): Mark var as initialized.
10819 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
10821 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
10822 pointers to constants.
10823 (font_parse_fcname): Remove unused vars.
10824 (font_delete_unmatched): Now static.
10825 (font_get_spec): Remove; unused.
10826 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
10827 (font_update_drivers, Ffont_get_glyphs, font_add_log):
10828 Rename or move locals to avoid shadowing.
10830 * fns.c (require_nesting_list, require_unwind): Now static.
10831 (Ffillarray): Rename locals to avoid shadowing.
10833 * floatfns.c (domain_error2): Define only if needed.
10834 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
10836 * alloc.c (mark_backtrace): Move decl from here ...
10837 * lisp.h: ... to here, so that it can be checked.
10839 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
10840 (Fdefvar): Rewrite so as not to use empty "else".
10841 (lisp_indirect_variable): Name an expression,
10842 to avoid gcc -Wbad-function-cast warning.
10843 (Fdefvar): Rename locals to avoid shadowing.
10845 * callint.c (quotify_arg, quotify_args): Now static.
10846 (Fcall_interactively): Rename locals to avoid shadowing.
10847 Use const pointer when appropriate.
10849 * lisp.h (get_system_name, get_operating_system_release):
10850 Move decls here, to check interfaces.
10851 * process.c (get_operating_system_release): Move decl to lisp.h.
10852 * xrdb.c (get_system_name): Likewise.
10853 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
10854 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
10855 some of which prompt warnings from gcc -Wbad-function-cast.
10856 (Fformat_time_string, Fencode_time, Finsert_char):
10857 (Ftranslate_region_internal, Fformat):
10858 Rename or remove local vars to avoid shadowing.
10859 (Ftranslate_region_internal): Mark var as initialized.
10861 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
10864 * lisp.h (eassert): Check that the argument compiles, even if
10865 ENABLE_CHECKING is not defined.
10867 * data.c (Findirect_variable): Name an expression, to avoid
10868 gcc -Wbad-function-cast warning.
10869 (default_value, arithcompare, arith_driver, arith_error): Now static.
10870 (store_symval_forwarding): Rename local to avoid shadowing.
10871 (Fmake_variable_buffer_local, Fmake_local_variable):
10872 Mark variables as initialized.
10873 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
10875 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
10876 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
10877 Rename locals to avoid shadowing.
10878 (mark_stack): Move local variables into the #ifdef region where
10880 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
10881 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
10883 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
10884 (GC_STRING_CHARS): Remove; not used.
10885 (Fmemory_limit): Cast sbrk's returned value to char *.
10887 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
10888 avoids undefined behavior in theory.
10890 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
10892 Use functions, not macros, for up- and down-casing (Bug#8254).
10893 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
10894 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
10895 to use the following functions instead of these macros.
10896 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
10897 EMACS_INT, since callers assume the returned value fits in int.
10898 (upcase1): Likewise, for UPCASE_TABLE.
10899 (uppercasep, lowercasep, upcase): New static inline functions.
10900 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
10901 the race-condition problem in the old DOWNCASE.
10903 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
10904 Rename locals to avoid shadowing.
10905 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
10906 (regex_compile, re_search_2, re_match_2_internal):
10907 Remove unused local vars.
10908 (FREE_VAR): Rewrite so as not to use empty "else",
10909 which gcc can warn about.
10910 (regex_compile, re_match_2_internal): Mark locals as initialized.
10911 (RETALLOC_IF): Define only if needed.
10912 (WORDCHAR_P): Likewise. This one is never needed, but is used
10913 only in a comment talking about a compiler bug, so put inside
10914 the #if 0 of that comment.
10915 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
10916 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
10919 * search.c (boyer_moore): Rename locals to avoid shadowing.
10920 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
10921 (PREV_CHAR_BOUNDARY): Likewise.
10923 * search.c (simple_search): Remove unused var.
10925 * dired.c (compile_pattern): Move decl from here ...
10926 * lisp.h: ... to here, so that it can be checked.
10927 (struct re_registers): New forward decl.
10929 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
10931 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
10933 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
10934 Rename locals to avoid shadowing.
10935 (Fvertical_motion): Mark locals as initialized.
10937 * casefiddle.c (casify_object, casify_region): Now static.
10938 (casify_region): Mark local as initialized.
10940 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
10942 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
10943 New macros, so that the caller can use some names other than
10944 gcpro1, gcpro2, etc.
10945 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
10947 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
10948 argument, for consistency with GCPRO2_VAR, etc: it is now the
10949 prefix of the variable, not the variable itself. All uses
10951 * dired.c (directory_files_internal, file_name_completion):
10952 Rename locals to avoid shadowing.
10954 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
10955 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
10956 dired.c's scmp function, had undefined behavior.
10957 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
10958 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
10959 * buffer.h: ... to here, because these macros use current_buffer,
10960 and the new implementation with inline functions needs to have
10961 current_buffer in scope now, rather than later when the macros
10963 (downcase, upcase1): New static inline functions.
10964 (DOWNCASE, UPCASE1): Reimplement using these functions.
10965 This avoids undefined behavior in expressions like
10966 DOWNCASE (x) == DOWNCASE (y), which previously suffered
10967 from race conditions in accessing the global variables
10968 case_temp1 and case_temp2.
10969 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
10970 * lisp.h (case_temp1, case_temp2): Remove their decls.
10971 * character.h (ASCII_CHAR_P): Move from here ...
10972 * lisp.h: ... to here, so that the inline functions mentioned
10973 above can use them.
10975 * dired.c (directory_files_internal_unwind): Now static.
10977 * fileio.c (file_name_as_directory, directory_file_name):
10978 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
10980 (file_name_as_directory): Use const pointers when appropriate.
10981 (Fexpand_file_name): Likewise. In particular, newdir might
10982 point at constant storage, so make it a const pointer.
10983 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
10984 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
10986 (Fset_file_times, Finsert_file_contents, auto_save_error):
10987 Rename locals to avoid shadowing.
10989 * minibuf.c (choose_minibuf_frame_1): Now static.
10990 (Ftry_completion, Fall_completions): Rename or remove locals
10991 to avoid shadowing.
10993 * marker.c (bytepos_to_charpos): Remove; unused.
10995 * lisp.h (verify_bytepos, count_markers): New decls,
10996 so that gcc does not warn that these functions aren't declared.
10998 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
10999 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
11000 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
11001 (copy_text): Remove unused local var.
11003 * filelock.c (within_one_second): Now static.
11004 (lock_file_1): Rename local to avoid shadowing.
11006 * buffer.c (fix_overlays_before): Mark locals as initialized.
11007 (fix_start_end_in_overlays): Likewise. This function should be
11008 simplified by using pointers-to-pointers, but that's a different
11010 (switch_to_buffer_1): Now static.
11011 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
11012 (report_overlay_modification): Rename locals to avoid shadowing.
11014 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
11015 Fix pointer signedness issue.
11016 (sys_subshell): Mark local as volatile if checking for lint,
11017 to suppress a gcc -Wclobbered warning that does not seem to be right.
11018 (MAXPATHLEN): Define only if needed.
11020 * process.c (serial_open, serial_configure): Move decls from here ...
11021 * systty.h: ... to here, so that they can be checked.
11023 * fns.c (get_random, seed_random): Move extern decls from here ...
11024 * lisp.h: ... to here, so that they can be checked.
11026 * sysdep.c (reset_io): Now static.
11027 (wait_for_termination_signal): Remove; unused.
11029 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
11030 (copy_keymap_item, append_key, push_text_char_description):
11032 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
11033 (DENSE_TABLE_SIZE): Remove; unused.
11034 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
11035 (describe_map_tree):
11036 Rename locals to avoid shadowing.
11038 * keyboard.c: Declare functions static if they are not used elsewhere.
11039 (echo_char, echo_dash, cmd_error, top_level_2):
11040 (poll_for_input, handle_async_input): Now static.
11041 (read_char, kbd_buffer_get_event, make_lispy_position):
11042 (make_lispy_event, make_lispy_movement, apply_modifiers):
11043 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
11044 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
11045 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
11046 (read_key_sequence, read_char): Mark locals as initialized.
11047 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
11049 * keyboard.h (make_ctrl_char): New decl.
11050 (mark_kboards): Move decl here ...
11051 * alloc.c (mark_kboards): ... from here.
11053 * lisp.h (force_auto_save_soon): New decl.
11055 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
11056 (DEFINE_DUMMY_FUNCTION): New macro.
11057 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
11059 (main): Add casts to avoid warnings
11060 if GCC considers string literals to be constants.
11062 * lisp.h (fatal_error_signal): Add decl, since it's exported.
11064 * dbusbind.c: Pointer signedness fixes.
11065 (xd_signature, xd_append_arg, xd_initialize):
11066 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11067 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11068 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
11069 (Fdbus_register_signal): Use SSDATA when the context wants char *.
11071 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
11072 if GCC considers string literals to be constants.
11073 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
11075 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
11077 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
11078 (print_preprocess, print_object): New macro to fix last change.
11080 * print.c (print_preprocess): Don't forget font objects.
11082 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
11084 * emacs.c (USAGE3): Doc fixes.
11086 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
11088 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
11091 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
11093 * lisp.h (VWindow_system, Qfile_name_history):
11094 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
11095 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
11096 (w32_system_caret_x, w32_system_caret_y): Declare extern.
11098 * w32select.c: Don't #include "keyboard.h".
11099 (run_protected): Add extern declaration for waiting_for_input.
11101 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
11102 * w32console.c (detect_input_pending, read_input_pending)
11103 (encode_terminal_code):
11104 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
11105 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
11106 (w32_system_caret_y, Qfile_name_history):
11107 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
11108 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
11109 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
11110 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
11111 * w32proc.c (Qlocal, report_file_error):
11112 * w32term.c (Vwindow_system, updating_frame):
11113 * w32uniscribe.c (initialized, uniscribe_font_driver):
11114 Remove unneeded extern declarations.
11116 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
11118 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
11120 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
11122 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
11123 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
11124 These macros can no longer be used for assignment.
11126 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
11127 Assign struct members directly, instead of using BUF_BEGV etc.
11128 (record_buffer_markers, fetch_buffer_markers): New functions for
11129 recording and fetching special buffer markers.
11130 (set_buffer_internal_1, set_buffer_temp): Use them.
11132 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
11134 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
11136 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
11137 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
11139 * xdisp.c (hscroll_window_tree):
11140 (reconsider_clip_changes): Use PT instead of BUF_PT.
11142 2011-03-13 Eli Zaretskii <eliz@gnu.org>
11144 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
11145 $(EMACS_ROOT)/lib/intprops.h.
11147 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
11149 Fix more problems found by GCC 4.5.2's static checks.
11151 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
11152 to unsigned char * to avoid compiler diagnostic.
11153 (xg_free_frame_widgets): Make it clear that a local variable is
11154 needed only if USE_GTK_TOOLTIP.
11155 (gdk_window_get_screen): Make it clear that this macro is needed
11156 only if USE_GTK_TOOLTIP.
11157 (int_gtk_range_get_value): New function, which avoids a diagnostic
11158 from gcc -Wbad-function-cast.
11159 (xg_set_toolkit_scroll_bar_thumb): Use it.
11160 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
11161 diagnostic from gcc -Wbad-function-cast.
11162 (get_utf8_string, xg_get_file_with_chooser):
11163 Rename locals to avoid shadowing.
11164 (create_dialog): Move locals to avoid shadowing.
11166 * xgselect.c (xg_select): Remove unused var.
11168 * image.c (four_corners_best): Mark locals as initialized.
11169 (gif_load): Initialize transparent_p to zero (Bug#8238).
11170 Mark another local as initialized.
11171 (my_png_error, my_error_exit): Mark with NO_RETURN.
11173 * image.c (clear_image_cache): Now static.
11174 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
11175 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
11176 (x_edge_detection): Remove unnecessary cast that
11177 gcc -Wbad-function-cast diagnoses.
11178 (gif_load): Fix pointer signedness.
11179 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
11180 (jpeg_load, gif_load): Rename locals to avoid shadowing.
11182 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
11184 Improve quality of tests for time stamp overflow.
11185 For example, without this patch (encode-time 0 0 0 1 1
11186 1152921504606846976) returns the obviously-bogus value (-948597
11187 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
11188 reports time overflow. See
11189 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
11190 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
11191 * editfns.c: Include limits.h and intprops.h.
11192 (TIME_T_MIN, TIME_T_MAX): New macros.
11193 (time_overflow): Move earlier, to before first use.
11194 (hi_time, lo_time): New functions, for an accurate test for
11195 out-of-range times.
11196 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
11197 (Fget_internal_run_time): Don't assume time_t fits in int.
11198 (make_time): Use list2 instead of Fcons twice.
11199 (Fdecode_time): More accurate test for out-of-range times.
11200 (check_tm_member): New function.
11201 (Fencode_time): Use it, to test for out-of-range times.
11202 (lisp_time_argument): Don't rely on undefined left-shift and
11203 right-shift behavior when checking for time stamp overflow.
11205 * editfns.c (time_overflow): New function, refactoring common code.
11206 (Fformat_time_string, Fdecode_time, Fencode_time):
11207 (Fcurrent_time_string): Use it.
11209 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
11210 * dired.c (make_time): Move to ...
11211 * editfns.c (make_time): ... here.
11212 * systime.h: Note the move.
11214 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11216 * fringe.c (update_window_fringes): Remove unused variables.
11218 * unexmacosx.c (copy_data_segment): Also copy __got section.
11221 2011-03-12 Eli Zaretskii <eliz@gnu.org>
11223 * termcap.c [MSDOS]: Include "msdos.h".
11224 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
11225 Constify `char *' arguments and their references according to
11226 prototypes in tparam.h.
11228 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
11230 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
11231 Adapt all references accordingly.
11233 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
11235 2011-03-11 Tom Tromey <tromey@redhat.com>
11237 * buffer.c (syms_of_buffer): Remove obsolete comment.
11239 2011-03-11 Eli Zaretskii <eliz@gnu.org>
11241 * termhooks.h (encode_terminal_code): Declare prototype.
11243 * msdos.c (encode_terminal_code): Don't declare prototype.
11245 * term.c (encode_terminal_code): Now external again, used by
11246 w32console.c and msdos.c.
11248 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
11249 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
11251 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
11253 Fix some minor problems found by GCC 4.5.2's static checks.
11255 * fringe.c (update_window_fringes): Mark locals as initialized
11257 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
11259 * alloc.c (mark_fringe_data): Move decl from here ...
11260 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
11261 to check its interface.
11262 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
11264 * fontset.c (free_realized_fontset): Now static.
11265 (Fset_fontset_font): Rename local to avoid shadowing.
11266 (fontset_font): Mark local as initialized.
11267 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
11269 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
11271 * xselect.c (x_disown_buffer_selections): Remove; not used.
11272 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
11273 (x_own_selection, Fx_disown_selection_internal): Rename locals
11274 to avoid shadowing.
11275 (x_handle_dnd_message): Remove local to avoid shadowing.
11277 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
11278 so that the caller can use some name other than gcpro1.
11279 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
11280 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11281 (Fx_backspace_delete_keys_p):
11282 Use them to avoid shadowing, and rename vars to avoid shadowing.
11283 (x_decode_color, x_set_name, x_window): Now static.
11284 (Fx_create_frame): Add braces to silence GCC warning.
11285 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
11286 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
11287 Remove unused locals.
11288 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11289 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
11290 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
11293 * xterm.h (x_mouse_leave): New decl.
11295 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
11296 Remove unused functions.
11297 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
11298 (x_calc_absolute_position): Now static.
11299 (XTread_socket): Don't define label "out" unless it's used.
11300 Don't declare local "event" unless it's used.
11301 (x_iconify_frame, x_free_frame_resources): Don't declare locals
11302 unless they are used.
11303 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
11304 (x_fatal_error_signal): Remove; not used.
11305 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
11306 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
11307 (x_error_catcher, x_connection_closed, x_error_handler):
11308 (x_error_quitter, xembed_send_message, x_iconify_frame):
11309 (my_log_handler): Rename locals to avoid shadowing.
11310 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
11311 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
11313 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
11314 Rename or move locals to avoid shadowing.
11315 (tty_defined_color, merge_face_heights): Now static.
11316 (free_realized_faces_for_fontset): Remove; not used.
11317 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
11318 does not deduce is never used uninitialized.
11319 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
11320 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
11322 * terminal.c (store_terminal_param): Now static.
11324 * xmenu.c (menu_highlight_callback): Now static.
11325 (set_frame_menubar): Remove unused local.
11326 (xmenu_show): Rename parameter to avoid shadowing.
11327 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
11328 since they might point to immutable storage.
11329 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
11330 since it's unused otherwise.
11332 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
11333 Add a FIXME, since the code still doesn't look right. (Bug#8215)
11334 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
11335 avoids a gcc -Wuninitialized diagnostic.
11336 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
11337 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
11338 does not deduce are never used uninitialized.
11340 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
11342 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
11343 * window.c (window_loop, size_window):
11344 (run_window_configuration_change_hook, enlarge_window): Likewise.
11346 * window.c (display_buffer): Now static.
11347 (size_window): Mark variables that gcc -Wuninitialized
11348 does not deduce are never used uninitialized.
11349 * window.h (check_all_windows): New decl, to forestall
11350 gcc -Wmissing-prototypes diagnostic.
11351 * dispextern.h (bidi_dump_cached_states): Likewise.
11353 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
11355 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
11356 Include <limits.h>.
11357 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
11358 and to avoid gcc -Wuninitialized warning.
11359 (load_charset_map): Mark variables that gcc -Wuninitialized
11360 does not deduce are never used uninitialized.
11361 (load_charset): Abort instead of using uninitialized var (Bug#8229).
11363 * coding.c (coding_set_source, coding_set_destination):
11364 Use "else { /* comment */ }" rather than "else /* comment */;"
11365 for clarity, and to avoid gcc -Wempty-body warning.
11366 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
11367 a block, when the outer 'i' will do.
11368 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
11369 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
11370 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
11371 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
11372 (Fdecode_sjis_char, Fdefine_coding_system_internal):
11373 Rename locals to avoid shadowing.
11374 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
11375 * coding.c (emacs_mule_char, encode_invocation_designation):
11376 Now static, since they're not used elsewhere.
11377 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
11378 (decode_coding_object, encode_coding_object, detect_coding_system):
11379 (decode_coding_emacs_mule): Mark variables that gcc
11380 -Wuninitialized does not deduce are never used uninitialized.
11381 (detect_coding_iso_2022): Initialize a local variable that might
11382 be used uninitialized. Leave a FIXME because it's not clear that
11383 this initialization is needed. (Bug#8211)
11384 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
11385 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
11386 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
11387 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
11388 Remove unused macros.
11390 * category.c (hash_get_category_set): Remove unused local var.
11391 (copy_category_table): Now static, since it's not used elsewhere.
11392 * character.c (string_count_byte8): Likewise.
11394 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
11395 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
11397 * chartab.c (copy_sub_char_table): Now static, since it's not used
11399 (sub_char_table_ref_and_range, char_table_ref_and_range):
11400 Rename locals to avoid shadowing.
11401 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
11403 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
11404 (BIDI_BOB): Remove unused macro.
11406 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
11407 deduce are never used uninitialized.
11408 * term.c (encode_terminal_code): Likewise.
11410 * term.c (encode_terminal_code): Now static. Remove unused local.
11412 * tparam.h: New file.
11413 * term.c, tparam.h: Include it.
11414 * deps.mk (term.o, tparam.o): Depend on tparam.h.
11415 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
11416 Move these decls to tparam.h, and make them agree with what
11417 is actually in tparam.c. The previous trick of using incompatible
11418 decls in different modules does not conform to the C standard.
11419 All callers of tparam changed to use tparam's actual API.
11420 * tparam.c (tparam1, tparam, tgoto):
11421 Use const pointers where appropriate.
11423 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
11424 * cm.h (struct cm): Likewise.
11425 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
11426 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
11427 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
11428 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
11429 (turn_on_face, init_tty): Likewise.
11430 * termchar.h (struct tty_display_info): Likewise.
11432 * term.c (term_mouse_position): Rename local to avoid shadowing.
11434 * alloc.c (mark_ttys): Move decl from here ...
11435 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
11437 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
11439 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
11441 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
11443 * search.c (compile_pattern_1): Remove argument regp, unused since
11444 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
11445 (compile_pattern): Don't pass it.
11447 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
11449 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
11450 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
11452 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
11454 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
11456 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
11457 gdk_window_get_screen, gdk_window_get_geometry,
11458 gdk_x11_window_lookup_for_display and GDK_KEY_g.
11459 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
11460 (xg_get_pixbuf_from_pixmap): New function.
11461 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
11462 to Pixmap, take frame as parameter, remove GdkColormap parameter.
11463 Call xg_get_pixbuf_from_pixmap instead of
11464 gdk_pixbuf_get_from_drawable.
11465 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
11466 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
11467 (xg_check_special_colors): Use GtkStyleContext and its functions
11469 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
11470 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
11471 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
11472 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
11473 Call gtk_widget_get_preferred_size.
11474 (xg_frame_resized): gdk_window_get_geometry only takes 5
11476 (xg_win_to_widget, xg_event_is_for_menubar):
11477 Call gdk_x11_window_lookup_for_display.
11478 (xg_set_widget_bg): New function.
11479 (delete_cb): New function.
11480 (xg_create_frame_widgets): Connect delete-event to delete_cb.
11481 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
11482 (xg_set_background_color): Call xg_set_widget_bg.
11483 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
11484 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
11485 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
11486 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
11488 (update_frame_tool_bar): Call gtk_widget_hide.
11489 (xg_initialize): Use GDK_KEY_g.
11491 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
11493 (x_session_initialize): Call gdk_x11_set_sm_client_id.
11495 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
11496 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
11497 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
11499 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
11501 * w32xfns.c (select_palette): Check success of RealizePalette against
11502 GDI_ERROR, not zero.
11504 See ChangeLog.11 for earlier changes.
11506 ;; Local Variables:
11510 Copyright (C) 2011-2012 Free Software Foundation, Inc.
11512 This file is part of GNU Emacs.
11514 GNU Emacs is free software: you can redistribute it and/or modify
11515 it under the terms of the GNU General Public License as published by
11516 the Free Software Foundation, either version 3 of the License, or
11517 (at your option) any later version.
11519 GNU Emacs is distributed in the hope that it will be useful,
11520 but WITHOUT ANY WARRANTY; without even the implied warranty of
11521 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11522 GNU General Public License for more details.
11524 You should have received a copy of the GNU General Public License
11525 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.