1 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
3 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
4 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
5 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
6 this makes Emacs dump core during garbage collection on rare
7 occasions. sizeof is obviously inferior to offsetof here, so
9 (GC_POINTER_ALIGNMENT): New macro.
10 (mark_memory): Omit 3rd (offset) arg; caller changed.
11 Don't assume EMACS_INT alignment is the same as pointer alignment.
13 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
15 * keyboard.c (read_key_sequence_remapped): New var.
16 (read_key_sequence): Compute remapping in the right buffer.
17 (command_loop_1): Use read_key_sequence's remapping directly.
19 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
21 * dired.c (file_name_completion): Don't expand file name.
22 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
23 before checking file name handler.
25 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
26 they've been requested explicitly (bug#9591).
28 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
30 * keymap.c (Fsingle_key_description): Use make_specified_string
31 instead of build_string to build string from push_key_description.
34 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
36 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
37 This fixes a Y2038 bug on 64-bit hosts.
38 * buffer.c (reset_buffer):
39 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
40 (Fclear_buffer_auto_save_failure):
41 Use 0, not -1, to represent an unset failure time, since time_t
44 Remove dependency on glibc malloc internals.
45 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
46 Move back here from lisp.h, but with their new implementations.
47 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
48 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
49 * charset.c (charset_table_init): New static var.
50 (syms_of_charset): Use it instead of xmalloc. This removes a
51 dependency on glibc malloc internals. See Eli Zaretskii's comment in
52 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
53 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
55 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
56 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
58 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
60 * nsterm.m (windowDidResize): Call x_set_window_size only when
61 ns_in_resize is true. Otherwise set pixelwidth/height and
62 call change_frame_size (Bug#9628).
64 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
66 Port --enable-checking=all to Fedora 14 x86-64.
67 * charset.c (syms_of_charset): Also account for glibc malloc's
68 internal overhead when calculating the initial malloc maximum.
70 Port --enable-checking=all to Fedora 14 x86.
71 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
73 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
74 (overrun_check_realloc, overrun_check_free):
75 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
76 That way, xmalloc returns a properly-aligned pointer even if
77 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
78 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
79 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
80 into account when calculating the initial malloc maximum.
81 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
82 Move here from alloc.c, so that charset.c can use it too.
83 Properly align; the old code wasn't right for common 32-bit hosts
84 when configured with --enable-checking=all.
85 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
86 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
88 2011-09-29 Eli Zaretskii <eliz@gnu.org>
90 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
93 2011-09-28 Eli Zaretskii <eliz@gnu.org>
95 * xdisp.c (compute_display_string_end): If there's no display
96 string at CHARPOS, return -1.
98 * bidi.c (bidi_fetch_char): When compute_display_string_end
99 returns a negative value, treat the character as a normal
100 character not covered by a display string. (Bug#9624)
102 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
104 * lread.c (Fread_from_string): Fix typo in docstring.
106 2011-09-27 Eli Zaretskii <eliz@gnu.org>
108 * xdisp.c (handle_invisible_prop): If invisible text ends on a
109 newline, reseat the iterator instead of bidi-iterating there one
110 character at a time. (Bug#9610)
111 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
112 TO_CHARPOS if the bidi iterator is at base embedding level.
114 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
116 * lread.c (readevalloop): Use correct code for NBSP.
117 (read1): Likewise. (Bug#9608)
119 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
121 * dbusbind.c (Fdbus_register_signal): When service is not
122 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
124 2011-09-25 Glenn Morris <rgm@gnu.org>
126 * buffer.c (truncate-lines): Doc fix.
128 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
130 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
131 (Fset_window_next_buffers): Doc fix.
133 2011-09-24 Glenn Morris <rgm@gnu.org>
135 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
137 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
139 Fix minor problems found by static checking.
140 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
141 * indent.c (Fvertical_motion): Fix == vs = typo.
143 2011-09-24 Eli Zaretskii <eliz@gnu.org>
145 * dispnew.c (syms_of_display) <redisplay-dont-pause>: Default
146 value is now t. Doc fix.
148 * indent.c (Fvertical_motion): Compute and apply the overshoot
149 logic when moving up, not only when moving down. Fix the
150 confusing name and values of the it_overshoot_expected variable;
151 logic changes accordingly. (Bug#9254) (Bug#9549)
153 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
154 CHARPOS is covered by a display string which includes newlines.
155 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
156 is covered by a display string with embedded newlines.
158 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
160 * dbusbind.c (Fdbus_register_signal): Add match rule to
161 Vdbus_registered_objects_table. (Bug#9581)
162 (Fdbus_register_method, Vdbus_registered_objects_table): Fix
165 2011-09-24 Jim Meyering <meyering@redhat.com>
167 do not ignore write error for any output size
168 The previous change was incomplete.
169 While it makes emacs --batch detect the vast majority of stdout
170 write failures, errors were still ignored whenever the output size is
171 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
172 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
173 && echo FAIL: ignored write error
174 FAIL: ignored write error
175 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
176 && echo FAIL: ignored write error
177 FAIL: ignored write error
178 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
180 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
182 * emacs.c (Fkill_emacs): In noninteractive mode exit
183 non-successfully if a write error occurred on stdout. (Bug#9574)
185 2011-09-21 Eli Zaretskii <eliz@gnu.org>
187 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
190 * dispextern.h (struct it): Update the comment documenting what
193 2011-09-20 Eli Zaretskii <eliz@gnu.org>
195 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
196 a display string, extend search for cursor position to end of row.
197 (find_row_edges): If the row ends in a newline from a display
198 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
199 Handle the case of a display string with multiple newlines.
200 (Fcurrent_bidi_paragraph_direction): Fix search for previous
201 non-empty line. Fixes confusing cursor motion with arrow keys at
202 the beginning of a line that starts with whitespace.
204 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
206 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
209 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
211 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
214 2011-09-18 Eli Zaretskii <eliz@gnu.org>
216 * xdisp.c (display_line): Record maximum and minimum buffer
217 positions even if no glyphs were produced (e.g., by a zero-width
218 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
219 buffer positions that will be removed from the glyph row because
221 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
222 column is beyond frame width: don't subtract 1 "pixel" when
223 computing width of the stretch.
224 (reseat_at_next_visible_line_start): Undo the change made on
225 2011-09-17 that saved paragraph information and restored it after
226 the call to `reseat'. (Bug#9545)
228 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
230 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
231 and turn window cursor on if cleared (Bug#9415).
233 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
235 * search.c (boyer_moore): Take unibyte characters from pattern
236 literally. (Bug#9458)
238 2011-09-18 Eli Zaretskii <eliz@gnu.org>
240 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
242 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
244 Fix minor problem found by static checking.
245 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
246 initialized, to pacify gcc -Wuninitialized.
248 * fileio.c: Report proper errno when syscall falls.
249 (Finsert_file_contents): Save and restore errno,
250 so that report_file_error outputs the correct diagnostic.
251 (Fwrite_region) [CLASH_DETECTION]: Likewise.
253 2011-09-18 Eli Zaretskii <eliz@gnu.org>
255 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
257 2011-09-17 Eli Zaretskii <eliz@gnu.org>
259 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
260 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
262 2011-09-17 Eli Zaretskii <eliz@gnu.org>
264 * xdisp.c (reseat_at_next_visible_line_start): Keep information
265 about the current paragraph and restore it after the call to
268 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
269 (bidi_find_paragraph_start): Search back for paragraph beginning
270 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
271 (bidi_move_to_visually_next): Only trigger paragraph-related
272 computations when the last character is a newline or at EOB, not
273 just any NEUTRAL_B. (Bug#9470)
275 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
276 truncated lines if point is covered by a display string. (Bug#9524)
278 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
280 * xselect.c: Relax test for outgoing X longs (Bug#9498).
281 (cons_to_x_long): New function.
282 (lisp_data_to_selection_data): Use it. Correct the test for
283 short-versus-long data; it was negated. Break out of vector
284 loop, for efficiency, when a long datum is discovered.
286 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
288 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
290 2011-09-16 Eli Zaretskii <eliz@gnu.org>
292 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
293 GCC PR/17406) by declaring this function with external scope.
295 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
297 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
298 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
300 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
302 * editfns.c (Fformat): Correctly handle text properties on "%%".
304 2011-09-15 Eli Zaretskii <eliz@gnu.org>
306 * xterm.c (x_draw_composite_glyph_string_foreground):
307 * w32term.c (x_draw_composite_glyph_string_foreground):
308 * term.c (encode_terminal_code):
309 * composite.c (composition_update_it, get_composition_id):
310 * xdisp.c (get_next_display_element)
311 (fill_composite_glyph_string): Add comments about special meaning
312 of TAB characters in a composition.
314 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
316 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
317 This occurs when processing a multibyte format.
318 Problem reported by Wolfgang Jenker.
320 2011-09-15 Johan Bockgård <bojohan@gnu.org>
322 * xdisp.c (try_cursor_movement): Only check for exact match if
323 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
325 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
327 Remove unused external symbols.
328 * dispextern.h (calc_pixel_width_or_height): Remove decl.
329 * xdisp.c (calc_pixel_width_or_height): Now static.
330 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
331 * indent.c (check_display_width):
332 * w32term.c: Fix comment to match code.
333 * xterm.c, xterm.h (x_catching_errors): Remove.
335 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
337 * xselect.c: Use signed conversions more consistently (Bug#9498).
338 (selection_data_to_lisp_data): Assume incoming selection data are
339 signed integers, not unsigned. This is to be consistent with
340 outgoing selection data, which was modified to use signed integers
341 in as part of the fix to Bug#9196 in response to Jan D.'s comment
342 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
343 expects long, not unsigned long.
345 2011-09-14 Eli Zaretskii <eliz@gnu.org>
347 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
348 computation of loop end. Reported by Johan Bockgård
351 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
353 * frame.c (Fother_visible_frames_p): Function deleted.
355 2011-09-12 Eli Zaretskii <eliz@gnu.org>
357 * indent.c (compute_motion): Process display vector front to back
358 rather than the other way around. (Bug#2496)
360 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
362 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
364 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
366 * minibuf.c (Fread_from_minibuffer): Doc fix.
368 2011-09-11 Eli Zaretskii <eliz@gnu.org>
370 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
371 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
373 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
375 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
376 value for non-existent files.
378 2011-09-11 Eli Zaretskii <eliz@gnu.org>
380 * fileio.c (Finsert_file_contents): If the file cannot be opened,
381 set its "size" to -1. This will set the modtime_size field of
382 the corresponding buffer to -1, which is what
383 verify-visited-file-modtime expects for files that do not exist.
386 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
388 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
390 * lisp.h: ... from here. push_key_description is no longer
391 defined in keyboard.c, so its declaration should not be in
392 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
393 logically belongs with push_key_description.
395 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
397 * buffer.h: Include <sys/types.h> instead of <time.h>.
398 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
399 Problem reported by Herbert J. Skuhra.
401 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
403 * xml.c (parse_region): Make the parsing work for
404 non-comment-starting XML files again (bug#9144).
406 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
408 * image.c (gif_load): Fix calculation of bottom and right corner.
411 2011-09-10 Eli Zaretskii <eliz@gnu.org>
413 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
414 redisplay in small windows.
416 2011-09-09 Eli Zaretskii <eliz@gnu.org>
418 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
420 2011-09-08 Martin Rudalics <rudalics@gmx.at>
422 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
423 Operate on live windows only.
425 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
427 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
429 2011-09-07 Eli Zaretskii <eliz@gnu.org>
431 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
432 only under bidi iteration.
434 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
436 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
438 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
440 isnan: Fix porting problem to Solaris 10 with bundled gcc.
441 Without this fix, the command to link temacs failed due to an
442 undefined symbol __builtin_isnan. This is because
443 /usr/include/iso/math_c99.h #defines isnan(x) to
444 __builtin_isnan(x), but the bundled gcc, which identifies itself
445 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
447 * floatfns.c (isnan): #undef, and then #define to a clone of
449 (Fisnan): Always define, since it's always available now.
450 (syms_of_floatfns): Always define isnan at the Lisp level.
452 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
454 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
456 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
458 * fileio.c: Fix bugs with large file offsets (Bug#9428).
459 The previous code assumed that file offsets (off_t values) fit in
460 EMACS_INT variables, which is not true on typical 32-bit hosts.
461 The code messed up by falsely reporting buffer overflow in cases
462 such as (insert-file-contents "big" nil 1 2) into an empty buffer
463 when "big" contains more than 2**29 bytes, even though this
464 inserts just one byte and does not overflow the buffer.
465 (Finsert_file_contents): Store file offsets as off_t
466 values, not as EMACS_INT values. Check for overflow when
467 converting between EMACS_INT and off_t. When checking for
468 buffer overflow or for overlap, take the offsets into account.
469 Don't use EMACS_INT for small values where int suffices.
470 When checking for overlap, fix a typo: ZV was used where
471 ZV_BYTE was intended.
472 (Fwrite_region): Don't assume off_t fits into 'long'.
473 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
475 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
477 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
479 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
481 sprintf-related integer and memory overflow issues (Bug#9412).
483 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
484 (esprintf, exprintf, evxprintf): New functions.
485 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
486 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
487 (modify_event_symbol): Do not assume that the length of
488 name_alist_or_stem is safe to alloca and fits in int.
489 (Fexecute_extended_command): Likewise for function name and binding.
490 (Frecursion_depth): Wrap around reliably on integer overflow.
491 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
492 since some callers pass EMACS_INT values.
493 (Fsingle_key_description): Don't crash if symbol name contains more
494 than MAX_ALLOCA bytes.
495 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
496 (get_minibuffer): Arg is now EMACS_INT, not int.
497 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
498 (esprintf, exprintf, evxprintf): New decls.
499 * window.h (command_loop_level, minibuf_level): Reflect API changes.
501 * dbusbind.c (signature_cat): New function.
502 (xd_signature, Fdbus_register_signal):
503 Do not overrun buffer; instead, report string overflow.
505 * dispnew.c (add_window_display_history): Don't overrun buffer.
506 Truncate instead; this is OK since it's just a log.
508 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
509 even if the time zone offset is outlandishly large.
510 Don't mishandle offset == INT_MIN.
512 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
513 when creating daemon; the previous buffer-overflow check was incorrect.
515 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
516 which has the guts of the old verror function.
518 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
519 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
521 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
522 (font_unparse_xlfd): Don't blindly alloca long strings.
523 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
524 fits in int, when using sprintf. Use single snprintf to count
525 length of string rather than counting it via multiple sprintfs;
526 that's simpler and more reliable.
527 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
528 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
529 sprintf, in case result does not fit in int.
531 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
532 (fontset_from_font): Print it.
534 * frame.c (tty_frame_count): Now printmax_t, not int.
535 (make_terminal_frame, set_term_frame_name): Print it.
536 (x_report_frame_params): In X, window IDs are unsigned long,
537 not signed long, so print them as unsigned.
538 (validate_x_resource_name): Check for implausibly long names,
539 and don't assume name length fits in 'int'.
540 (x_get_resource_string): Don't blindly alloca invocation name;
541 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
544 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
545 (xg_check_special_colors, xg_set_geometry):
546 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
548 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
549 Use esprintf, not sprintf, in case result does not fit in int.
551 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
552 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
553 it as a large positive number.
554 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
555 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
557 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
558 in case result does not fit in int.
560 * print.c (float_to_string): Detect width overflow more reliably.
561 (print_object): Make sprintf buffer a bit bigger, to avoid potential
562 buffer overrun. Don't assume list length fits in 'int'. Treat
563 print length of 0 as 0, not as infinity; to be consistent with other
564 uses of print length in this function. Don't overflow print length
565 index. Don't assume hash table size fits in 'long', or that
566 vectorlike size fits in 'unsigned long'.
568 * process.c (make_process): Use printmax_t, not int, to format
569 process-name gensyms.
571 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
573 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
574 to avoid potential buffer overrun.
576 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
577 if X resource line is longer than 512 bytes.
579 * xfns.c (x_window): Make sprintf buffer a bit bigger
580 to avoid potential buffer overrun.
582 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
584 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
586 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
588 Integer overflow fixes for scrolling, etc.
589 Without these, Emacs silently mishandles large integers sometimes.
590 For example, "C-u 4294967297 M-x recenter" was treated as if
591 it were "C-u 1 M-x recenter" on a typical 64-bit host.
593 * xdisp.c (try_window_id): Check Emacs fixnum range before
596 * window.c (window_scroll_line_based, Frecenter):
597 Check that an Emacs fixnum is in range before assigning it to 'int'.
598 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
599 values converted from Emacs fixnums.
600 (Frecenter): Don't wrap around a line count if it is out of 'int'
601 range; instead, treat it as an extreme value.
602 (Fset_window_configuration, compare_window_configurations):
603 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
605 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
606 that can exceed INT_MAX. Check that EMACS_INT value is in range
607 before assigning it to the (possibly-narrower) index.
608 (match_limit): Don't assume that a fixnum can fit in 'int'.
610 * print.c (print_object): Use ptrdiff_t, not int, for index that can
613 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
614 (Fvertical_motion): Don't wrap around LINES values that don't fit
615 in 'int'. Instead, treat them as extreme values. This is good
616 enough for windows, which can't have more than INT_MAX lines anyway.
618 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
620 * Require libxml/parser.h to avoid compilation warning.
622 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
624 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
625 since this reportedly can destroy thread storage.
627 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
629 * syntax.c (find_defun_start): Update all cache variables if
630 exiting early (Bug#9401).
632 2011-08-30 Eli Zaretskii <eliz@gnu.org>
634 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
636 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
637 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
638 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
640 * term.c (tty_append_glyph): New function.
641 (produce_stretch_glyph): Static function and its prototype deleted.
643 * dispextern.h (produce_stretch_glyph, tty_append_glyph): Add
646 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
648 * image.c (parse_image_spec): Check for nonnegative, not for positive,
649 when checking :margin (Bug#9390).
650 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
651 Renamed from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
652 so that the name doesn't mislead. All uses changed.
654 2011-08-28 Johan Bockgård <bojohan@gnu.org>
656 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
659 2011-08-27 Eli Zaretskii <eliz@gnu.org>
661 * xdisp.c (move_it_to): Don't bail out early when reaching
662 position beyond to_charpos, if we are scanning backwards.
663 (move_it_vertically_backward): When DY == 0, make sure we get to
664 the first character in the line after the newline.
666 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
668 * ccl.c: Improve and simplify overflow checking (Bug#9196).
669 (ccl_driver): Do not generate an out-of-range pointer.
670 (Fccl_execute_on_string): Remove unnecessary check for
671 integer overflow, noted by Stefan Monnier in
672 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
673 Remove a FIXME that didn't need fixing.
674 Simplify the newly-introduced buffer reallocation code.
676 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
678 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
680 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
682 Integer and memory overflow issues (Bug#9196).
684 * doc.c (get_doc_string): Rework so that
685 get_doc_string_buffer_size is the actual buffer size, rather than
686 being 1 less than the actual buffer size; this makes xpalloc more
689 * image.c (x_allocate_bitmap_record, cache_image):
690 * xselect.c (Fx_register_dnd_atom):
691 Simplify previous changes by using xpalloc.
693 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
694 since either will do and ptrdiff_t is convenient with xpalloc.
696 * charset.c (charset_table_size)
697 (struct charset_sort_data.priority): Now ptrdiff_t.
698 (charset_compare): Don't overflow if priorities differ greatly.
699 (Fsort_charsets): Don't assume list length fits in int.
700 Check for size-calculation overflow when allocating sort data.
701 (syms_of_charset): Allocate an initial charset table that is
702 just under 64 KiB, to avoid problems with glibc malloc and mmap.
704 * cmds.c (internal_self_insert): Check for size-calculation overflow.
706 * composite.h (struct composition.glyph_len): Now int, not unsigned.
707 The actual value is always <= INT_MAX, and leaving it unsigned made
708 overflow checking harder.
710 * dispextern.h (struct glyph_matrix.rows_allocated)
711 (struct face_cache.size): Now ptrdiff_t, for convenience in use
712 with xpalloc. The values are still always <= INT_MAX.
714 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
716 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
717 (SAFE_NALLOCA): New macro.
719 * region-cache.c (struct boundary.pos, find_cache_boundary)
720 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
721 (set_cache_region, invalidate_region_cache)
722 (revalidate_region_cache, know_region_cache, region_cache_forward)
723 (region_cache_backward, pp_cache):
724 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
725 so that ptrdiff_t * can be passed to xpalloc.
726 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
727 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
728 (pp_cache): Don't assume cache_len fits in int.
729 * region-cache.h: Adjust extern decls to match.
731 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
732 EMACS_INT, since either will do, for xpalloc.
734 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
735 (xnmalloc, xnrealloc, xpalloc): New functions.
737 * bidi.c (bidi_shelve_header_size): New constant.
738 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
739 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
741 * bidi.c (bidi_cache_shrink):
742 * buffer.c (overlays_at, overlays_in, record_overlay_string)
744 Don't update size of array until after memory allocation succeeds,
745 because xmalloc/xrealloc may not return.
746 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
747 now that we have proper integer overflow checking.
748 (record_overlay_string, overlay_strings): Catch overflows when
749 calculating size of overlay_str_buf.
751 * callproc.c (Fcall_process): Check for size overflow when
752 calculating size of args2.
753 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
754 Normally we prefer signed values, but sticking with ptrdiff_t would
755 require adding more-complicated checks.
757 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
758 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
759 Redo buffer-overflow calculations to avoid integer overflow.
760 Add a FIXME comment where memory seems to be over-allocated.
762 * character.c (Fstring): Check for size-calculation overflow.
764 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
765 unnecessary integer overflow. Check for size overflow.
766 (encode_coding_object): Don't update size until xmalloc succeeds.
768 * composite.c (get_composition_id): Check for overflow in glyph
771 Integer and memory overflow fixes for display code.
772 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
773 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
774 (scrolling_window): Check for overflow in size calculations.
775 (line_draw_cost, realloc_glyph_pool, add_row_entry):
776 Don't assume glyph table len fits in int.
777 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
778 (row_table_size): Now ptrdiff_t, not int.
779 (scrolling_window): Avoid overflow in size calculations.
780 Don't update size until allocation succeeds.
781 * fns.c (concat): Check for overflow in size calculations.
782 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
783 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
784 (NEXT_ALMOST_PRIME_LIMIT): New constant.
786 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
787 (get_doc_string): Check for size calculation overflow.
788 Don't update size until allocation succeeds.
789 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
790 EMACS_INT, where ptrdiff_t will do.
791 (Fsubstitute_command_keys): Check for string overflow.
793 * editfns.c (set_time_zone_rule): Don't assume environment length
795 (message_length): Now ptrdiff_t, not int.
796 (Fmessage_box): Don't update size until allocation succeeds.
797 Don't assume message length fits in int.
798 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
800 * emacs.c (main): Do not reallocate argv, since there is a null at
801 the end that can be overwritten, and this way there's no need to
802 worry about size-calculation overflow.
803 (sort_args): Check for size-calculation overflow.
805 * eval.c (init_eval_once, grow_specpdl): Don't update size until
807 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
809 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
810 (x_set_scroll_bar_width, x_figure_window_size):
811 Check for integer overflow.
812 (x_set_alpha): Do not assume XINT fits in int.
814 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
815 This is for the members text_lines, text_cols, total_lines, total_cols,
816 where the system imposes an 'int' limit.
818 * fringe.c (Fdefine_fringe_bitmap):
819 Don't update size until alloc works.
821 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
822 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
824 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
825 Check for size-calculation overflow.
826 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
827 do, as we prefer signed integers.
828 (id_to_widget.max_size, id_to_widget.used)
829 (xg_store_widget_in_map, xg_remove_widget_from_map)
830 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
831 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
832 Use and return ptrdiff_t, not int.
833 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
834 * gtkutil.h: Change prototypes to match the above.
836 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
837 are duplicate now that they've been promoted to lisp.h.
838 (x_allocate_bitmap_record, x_alloc_image_color)
839 (make_image_cache, cache_image, xpm_load):
840 Don't update size until alloc is done.
841 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
843 Check for size calculation overflow.
844 (ct_colors_allocated_max): New constant.
845 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
848 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
849 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
850 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
851 Use ptrdiff_t, not int, to count maps.
852 (read_char_minibuf_menu_prompt): Check for overflow in size
853 calculations. Don't update size until allocation succeeds. Redo
854 calculations to avoid overflow.
855 * keyboard.h: Change prototypes to match the above.
857 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
859 (current_minor_maps): Check for size calculation overflow.
860 * keymap.h: Change prototypes to match the above.
862 * lread.c (read1, init_obarray): Don't update size until alloc done.
864 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
865 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
867 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
868 Now ptrdiff_t, not int.
869 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
870 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
872 * process.c (Fnetwork_interface_list): Check for overflow
875 * region-cache.c (move_cache_gap): Check for size calculation overflow.
877 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
878 overflow. Don't bother calling xmalloc when xrealloc will do.
880 * search.c (Freplace_match): Check for size calculation overflow.
881 (Fset_match_data): Don't assume list lengths fit in 'int'.
883 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
884 for command line length. Do not attempt to address one before the
885 beginning of an array, as that's not portable.
887 * term.c (max_frame_lines): Remove; unused.
888 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
890 (encode_terminal_code, calculate_costs): Check for size
891 calculation overflow.
892 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
893 table lengths and related sizes. Don't update size until alloc
894 done. Redo calculations to avoid overflow.
895 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
897 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
898 subtracting pointers.
899 (gobble_line): Check for overflow more carefully. Don't update size
902 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
903 Don't update size until alloc done.
904 Redo size calculations to avoid overflow.
905 Check for size calculation overflow.
906 (main) [DEBUG]: Fix typo in invoking tparam1.
908 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
909 Use ptrdiff_t, not int, for sizes.
910 (store_mode_line_noprop_char): Don't update size until alloc done.
912 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
913 Use ptrdiff_t, not int, for sizes.
914 (Finternal_make_lisp_face, cache_face):
915 Check for size calculation overflow.
916 (cache_face): Treat size calculation overflows as if they were
917 memory exhaustion (the usual treatment), rather than aborting.
919 * xfns.c (x_encode_text, x_set_name_internal)
920 (Fx_change_window_property): Use ptrdiff_t, not int, to count
921 sizes, since they can exceed INT_MAX in size. Check for size
922 calculation overflow.
924 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
925 (xg_select): Check for size calculation overflow.
926 Don't update size until alloc done.
928 * xrdb.c (get_environ_db): Don't assume path length fits in int,
929 as sprintf is limited to int lengths.
931 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
932 (X_LONG_MIN): New macros.
933 Use them to make the following changes clearer.
934 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
935 This change doesn't affect the value now, but it may help remind
936 future maintainers not to raise the value too much later.
937 (SELECTION_QUANTUM): Remove, replacing with ...
938 (selection_quantum): ... new function, which avoids overflow.
940 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
941 assumption that selection length fits in 'int'.
942 (x_reply_selection_request, x_handle_selection_request)
943 (x_get_window_property, receive_incremental_selection)
944 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
945 (lisp_data_to_selection_data, clean_local_selection_data):
946 Use ptrdiff_t, not int, to record length of selection.
947 (x_reply_selection_request, x_get_window_property)
948 (receive_incremental_selection, x_property_data_to_lisp):
949 Redo calculations to avoid overflow.
950 (x_reply_selection_request): When sending hint, ceiling it at
951 X_LONG_MAX rather than relying on wraparound overflow to send
953 (x_get_window_property, receive_incremental_selection)
954 (lisp_data_to_selection_data, x_property_data_to_lisp):
955 Check for size-calculation overflow.
956 (x_get_window_property, receive_incremental_selection)
957 (lisp_data_to_selection_data, Fx_register_dnd_atom):
958 Don't store size until memory allocation succeeds.
959 (x_get_window_property): Plug memory leak on memory exhaustion.
960 Don't double-block input; malloc is safe here. Don't assume 2**34
961 - 4 fits in unsigned long. Add an xassert to check
962 XGetWindowProperty overflow. Be more careful about overflow
963 calculations, and distinguish size from memory overflow better.
964 (receive_incremental_selection): When tracing, don't assume
965 unsigned int is less than INT_MAX.
966 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
967 harmful) conversions of unsigned short to int.
968 (lisp_data_to_selection_data): Don't assume that integers
969 in the range -65535 through -1 fit in an X unsigned short.
970 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
971 result parameters unless successful. Rely on cons_to_unsigned
972 to report problems with elements; the old code wasn't right anyway.
973 (x_check_property_data): Check for int overflow; we cannot use
974 a wider type due to X limits.
975 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
977 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
979 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
980 (x_term_init): Check for size calculation overflow.
981 (x_color_cells): Don't store size until memory allocation succeeds.
982 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
983 Don't assume alloca size is less than MAX_ALLOCA.
984 (x_term_init): Don't assume length fits in int (sprintf is limited
987 Use ptrdiff_t for composition IDs.
988 * character.c (lisp_string_width):
989 * composite.c (composition_table_size, n_compositions)
990 (get_composition_id, composition_gstring_from_id):
991 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
992 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
993 * window.c (Frecenter):
994 Use ptrdiff_t, not int, for composition IDs.
995 * composite.c (get_composition_id): Check for integer overflow.
996 * composite.h: Adjust prototypes to match the above changes.
998 Use ptrdiff_t for hash table indexes.
999 * category.c (hash_get_category_set):
1000 * ccl.c (ccl_driver):
1001 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1002 * coding.c (coding_system_charset_list, detect_coding_system):
1003 * coding.h (struct coding_system.id):
1004 * composite.c (get_composition_id, gstring_lookup_cache):
1005 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1006 * image.c (xpm_get_color_table_h):
1007 * lisp.h (hash_lookup, hash_put):
1008 * minibuf.c (Ftest_completion):
1009 Use ptrdiff_t for hash table indexes, not int (which is too
1010 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1011 32-bit --with-wide-int hosts).
1013 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1014 Add a FIXME comment about memory leaks.
1015 (syms_of_charset): Don't assume xmalloc returns.
1017 Don't assume that stated character widths fit in int.
1018 * character.c (Fchar_width, c_string_width, lisp_string_width):
1019 * character.h (CHAR_WIDTH):
1020 * indent.c (MULTIBYTE_BYTES_WIDTH):
1021 Use sanitize_char_width to avoid undefined and/or bad behavior
1022 with outlandish widths.
1023 * character.h (sanitize_tab_width): Renamed from sanitize_width,
1024 now that we have two such functions. All uses changed.
1025 (sanitize_char_width): New inline function.
1027 Don't assume that tab-width fits in int.
1028 * character.h (sanitize_width): New inline function.
1029 (SANE_TAB_WIDTH): New macro.
1030 (ASCII_CHAR_WIDTH): Use it.
1031 * indent.c (sane_tab_width): Remove. All uses replaced by
1032 SANE_TAB_WIDTH (current_buffer).
1033 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1035 * fileio.c: Integer overflow issues with file modes.
1036 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1038 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1039 Remove unreachable code.
1040 (read_hex, load_charset_map_from_file): Check for integer overflow.
1042 * xterm.c: don't go over XClientMessageEvent limit
1043 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1044 (x_send_scroll_bar_event): Likewise. Check that the size does not
1045 exceed limits imposed by XClientMessageEvent, as well as the usual
1046 ptrdiff_t and size_t limits.
1048 * keyboard.c: Overflow, signedness and related fixes.
1049 (make_lispy_movement): Use same integer type in forward decl
1050 that is used in the definition.
1051 (read_key_sequence, keyremap_step):
1052 Change bufsize argument back to int, undoing my 2011-03-30 change.
1053 We prefer signed types, and int is wide enough here.
1054 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1055 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1056 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1057 length, not size_t. Use ptrdiff_t for index, not int.
1058 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1059 possibility of integer overflow.
1061 Overflow, signedness and related fixes for images.
1063 * dispextern.h (struct it.stack[0].u.image.image_id)
1064 (struct_it.image_id, struct image.id, struct image_cache.size)
1065 (struct image_cache.used, struct image_cache.ref_count):
1066 * gtkutil.c (update_frame_tool_bar):
1067 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1068 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1069 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1070 * nsmenu.m (update_frame_tool_bar):
1071 * xdisp.c (calc_pixel_width_or_height):
1072 * xfns.c (image_cache_refcount):
1073 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1074 on typical 64-bit hosts.
1076 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1077 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1078 Omit unnecessary casts to int.
1079 (parse_image_spec): Check that integers fall into 'int' range
1080 when the callers expect that.
1081 (image_ascent): Redo ascent calculation to avoid int overflow.
1082 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1083 (lookup_image): Remove unnecessary tests.
1084 (xbm_image_p): Locals are now of int, not EMACS_INT,
1085 since parse_image_check makes sure they fit into int.
1086 (png_load, gif_load, svg_load_image):
1087 Prefer int to unsigned where either will do.
1088 (tiff_handler): New function, combining the cores of the
1089 old tiff_error_handler and tiff_warning_handler. This
1090 function is rewritten to use vsnprintf and thereby avoid
1091 stack buffer overflows. It uses only the features of vsnprintf
1092 that are common to both POSIX and native Microsoft.
1093 (tiff_error_handler, tiff_warning_handler): Use it.
1094 (tiff_load, gif_load, imagemagick_load_image):
1095 Don't assume :index value fits in 'int'.
1096 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1097 (imagemagick_load_image): Check that crop parameters fit into
1098 the integer types that MagickCropImage accepts. Don't assume
1099 Vimagemagick_render_type has a nonnegative value. Don't assume
1100 size_t fits in 'long'.
1101 (gs_load): Use printmax_t to print the widest integers possible.
1102 Check for integer overflow when computing image height and width.
1104 2011-08-26 Eli Zaretskii <eliz@gnu.org>
1106 * xdisp.c (redisplay_window): Don't force window start if point
1107 will be invisible in the resulting window. (Bug#9324)
1109 2011-08-25 Eli Zaretskii <eliz@gnu.org>
1111 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1112 the display spec is of the form `(space ...)'.
1113 (handle_display_spec): Return the value returned by
1114 handle_single_display_spec, not just 1 or zero.
1115 (handle_single_display_spec): If the display spec is of the form
1116 `(space ...)', and specifies display in the text area, return 2
1118 (try_cursor_movement): Check for the need to scroll more
1119 accurately, and prefer exact match for point under bidi. Don't
1120 advance `row' beyond the last row of the window.
1122 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1123 into disp_prop; all users changed.
1125 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1126 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1127 for the text covered by the display property.
1129 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
1131 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1132 Change return value to nil.
1133 (Frecord_buffer): Delete unused function.
1135 2011-08-24 Eli Zaretskii <eliz@gnu.org>
1137 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1138 buffers, return left-to-right.
1139 (set_cursor_from_row): Consider candidate row a win if its glyph
1140 represents a newline and point is on that newline. Fixes cursor
1141 positioning on the newline at EOL of R2L text within L2R
1142 paragraph, and vice versa.
1143 (try_cursor_movement): Check continued rows, in addition to
1144 continuation rows. Fixes unwarranted scroll when point enters a
1145 continued line of R2L text within an L2R paragraph, or vice versa.
1146 (cursor_row_p): Consider the case of point being equal to
1147 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1148 from the end of a short line to the beginning of a continued line
1149 of R2L text within L2R paragraph.
1150 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1151 composed characters.
1153 * bidi.c (bidi_check_type): Use xassert.
1154 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1157 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1159 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1162 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
1164 * nsfont.m (ns_otf_to_script): Fix typo.
1166 2011-08-22 Kenichi Handa <handa@m17n.org>
1168 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1169 extra slot even if the purpose is char-code-property-table.
1171 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1173 * xdisp.c (redisplay_window): When computing centering_position,
1174 account for the height of the header line. (Bug#8874)
1176 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1177 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1178 candidate is selected by the mouse, and that candidate has a
1179 composed character under the mouse.
1181 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1182 coordinates reported by pos-visible-in-window-p for a composed
1183 character in column zero.
1185 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1187 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1189 2011-08-22 Eli Zaretskii <eliz@gnu.org>
1191 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1192 consider it a hit if to_charpos is anywhere in the range of the
1193 composed buffer positions.
1195 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
1197 * image.c (gif_load): Don't assume that each subimage has the same
1198 dimensions as the base image. Handle disposal method that is
1199 "undefined" by the gif spec (Bug#9335).
1201 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
1203 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
1204 (Fcondition_case): Document `debug' symbol in error handler.
1206 2011-08-19 Eli Zaretskii <eliz@gnu.org>
1208 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1209 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1210 from an Org mode buffer to a Speedbar frame.
1212 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1213 a composition, take its buffer position from IT->cmp_it.charpos.
1214 Fixes cursor positioning at the beginning of a line that begins
1215 with a composed character.
1217 2011-08-18 Eli Zaretskii <eliz@gnu.org>
1219 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1220 character bidirectional type, use STRONG_L instead. Fixes crashes
1221 in a buffer produced by `describe-categories'.
1223 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1224 members before the level stack, so they would be saved and
1225 restored when copying iterator state. Fixes incorrect reordering
1226 around TABs covered by display properties.
1228 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1230 * process.c (Fnetwork_interface_list): Correctly determine buffer
1233 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
1235 * eval.c (internal_condition_case, internal_condition_case_1)
1236 (internal_condition_case_2, internal_condition_case_n):
1237 Remove unnecessary aborts (Bug#9081).
1239 2011-08-17 Eli Zaretskii <eliz@gnu.org>
1241 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1242 has no `load' handler, try opening the file locally. (Bug#9311)
1244 2011-08-16 Ken Brown <kbrown@cornell.edu>
1246 * gmalloc.c: Expand comment.
1248 2011-08-16 Eli Zaretskii <eliz@gnu.org>
1250 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1251 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1253 2011-08-16 Ken Brown <kbrown@cornell.edu>
1255 Fix memory allocation problems in Cygwin build (Bug#9273).
1257 * unexcw.c ( __malloc_initialized): Declare external variable.
1258 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1260 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1262 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1264 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1266 [CYGWIN] (special_realloc): New function.
1267 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1268 requests to realloc storage in the static heap.
1270 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1272 * bidi.c (bidi_initialize): Remove unused local.
1274 2011-08-15 Eli Zaretskii <eliz@gnu.org>
1276 * biditype.h: File removed.
1278 * bidimirror.h: File removed.
1280 * deps.mk (bidi.o): Remove biditype.h and
1283 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
1286 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1288 * chartab.c: Improve commentary for the uniprop_table API.
1290 * bidi.c (bidi_paragraph_init): Support zero value of
1291 bidi_ignore_explicit_marks_for_paragraph_level.
1292 (bidi_initialize): Use uniprop_table instead of including
1293 biditype.h and bidimirror.h.
1295 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1296 coordinates of the iterator when restoring from ppos_it.
1299 2011-08-14 Kenichi Handa <handa@m17n.org>
1301 * process.c (create_process): Call setup_process_coding_systems
1302 after the pid of the process is set to -1 (Bug#8162).
1304 2011-08-14 Eli Zaretskii <eliz@gnu.org>
1306 * xdisp.c (move_it_in_display_line_to): Don't invoke
1307 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1308 ppos_it. Fixes vertical cursor motion when line beginning is
1309 covered by an image. (Bug#9296)
1311 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1313 * nsterm.h (ns_run_ascript): Declare.
1314 (NSAPP_DATA2_RUNASSCRIPT): Define.
1316 * nsfns.m (as_script, as_result, as_status): New static variables.
1317 (ns_run_ascript): New function.
1318 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
1319 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1320 the event loop. Get status from as_status (Bug#7276).
1322 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1323 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1324 the event loop (Bug#7276).
1326 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1328 * gnutls.c (QCgnutls_bootprop_priority)
1329 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1330 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1331 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1332 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1333 (QCgnutls_bootprop_verify_hostname_error)
1334 (QCgnutls_bootprop_callbacks_verify): Rename from
1335 Qgnutls_bootprop_..., all uses changed.
1337 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1340 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1342 * xfaces.c (Qframe_set_background_mode): Now static.
1343 * dispextern.h (Qframe_set_background_mode): Remove decl.
1345 * process.c (Fnetwork_interface_info): Declare local only if needed.
1347 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1349 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1350 (Fnetwork_interface_list): Allocate in increments of bytes instead
1351 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1352 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1354 (struct ifflag_def): notrailers is smart on OSX.
1355 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1356 Get hardware address with getifaddrs if available.
1358 2011-08-12 Eli Zaretskii <eliz@gnu.org>
1360 * xdisp.c (iterate_out_of_display_property): xassert that
1361 IT->position is set to within IT->object's boundaries. Break from
1362 the loop as soon as EOB is reached; avoids infloops in redisplay
1363 when IT->position is set up wrongly due to some bug.
1364 Set IT->current to match the bidi iterator unconditionally.
1365 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1366 entry. Force push_it to save on the stack the current
1367 buffer/string position, to be restored by pop_it. Fix flags in
1368 the iterator structure wrt the object coming from a display
1369 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1370 properties. (Bug#9284)
1372 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
1374 * fontset.c (fontset_get_font_group): Add proper type checks.
1377 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1379 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1380 and LC_VERSION_MIN_MACOSX.
1381 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1382 (dump_it) [LC_FUNCTION_STARTS]: Use it.
1384 2011-08-08 Eli Zaretskii <eliz@gnu.org>
1386 * xdisp.c (forward_to_next_line_start): Allow to use the
1387 no-display-properties-and-no-overlays under bidi display.
1388 Set disp_pos in the bidi iterator to avoid searches for display
1389 properties and overlays.
1391 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
1393 * editfns.c (Fset_time_zone_rule): Document relationship with the
1396 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1397 the font entity extracted from the cache (Bug#8109).
1399 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
1401 * composite.c (autocmp_chars): Don't reset point. That is done by
1402 restore_point_unwind (Bug#5984).
1404 2011-08-07 Juri Linkov <juri@jurta.org>
1406 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1407 to show the arg `TIME' instead of `TIMEVAL'.
1409 2011-08-06 Eli Zaretskii <eliz@gnu.org>
1411 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1412 display property strides EOL and includes a newline, as in
1413 longlines-mode. (Bug#9254)
1414 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1415 word-wrap under bidirectional display. (Bug#9224)
1417 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1418 is non-zero, even if the data buffer is NULL. Fixes a crash in
1419 vertical-motion with longlines-mode. (Bug#9254)
1421 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1423 * bidi.c <bidi_cache_total_alloc>: Now static.
1424 (bidi_initialize): Initialize bidi_cache_total_alloc.
1426 * xdisp.c (display_line): Release buffer allocated for shelved bidi
1429 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1430 amount allocated this far in `bidi_cache_total_alloc'.
1431 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1432 non-zero, only free the data buffer without restoring the cache
1433 contents. All callers changed.
1435 * dispextern.h (bidi_unshelve_cache): Update prototype.
1437 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1438 (move_it_in_display_line, move_it_to)
1439 (move_it_vertically_backward, move_it_by_lines): Replace the call
1440 to xfree to an equivalent call to bidi_unshelve_cache.
1441 (move_it_in_display_line_to): Fix logic of returning
1442 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
1444 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1446 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1447 came from a string character with a `cursor' property. (Bug#9229)
1449 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1451 * Makefile.in (LIB_PTHREAD): New variable.
1452 (LIBES): Add LIB_PTHREAD (Bug#9216).
1454 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1455 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1457 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1459 * regex.c (re_iswctype): Remove some redundant boolean
1462 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1464 * xterm.c (x_find_topmost_parent): New function.
1465 (x_set_frame_alpha): Find topmost parent window with
1466 x_find_topmost_parent and set the property there also (bug#9181).
1467 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1469 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1471 * callproc.c (Fcall_process): Avoid vfork clobbering
1472 the local vars buffer, coding_systems, current_dir.
1474 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1476 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1478 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1480 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1481 so that it is not optimized away.
1483 * xdisp.c (compute_display_string_pos): Remove unused local.
1485 2011-08-02 Eli Zaretskii <eliz@gnu.org>
1487 Fix slow cursor motion and scrolling in large buffers with
1488 selective display, like Org Mode buffers. (Bug#9218)
1490 * dispextern.h (struct bidi_it): New member disp_prop_p.
1492 * xdisp.c: Remove one-slot cache of display string positions.
1493 (compute_display_string_pos): Accept an additional argument
1494 DISP_PROP_P; callers changed. Scan at most 5K characters forward
1495 for a display string or property. If found, set DISP_PROP_P
1498 * bidi.c (bidi_fetch_char): Accept an additional argument
1499 DISP_PROP_P, and pass it to compute_display_string_pos.
1500 Only handle text covered by a display string if DISP_PROP_P is returned
1501 non-zero. All callers of bidi_fetch_char changed.
1503 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1505 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1507 2010-12-03 Don March <don@ohspite.net>
1509 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1510 last character M-[char] is translated to ESC [char] (bug#7541).
1512 2011-08-02 Kenichi Handa <handa@m17n.org>
1514 * lisp.h (uniprop_table): Extern it.
1516 * chartab.c (uniprop_table): Make it non-static.
1518 2011-08-01 Eli Zaretskii <eliz@gnu.org>
1520 * xdisp.c (forward_to_next_line_start): Accept additional argument
1521 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1523 (reseat_at_next_visible_line_start): Use the bidi iterator state
1524 returned by forward_to_next_line_start to restore the state of
1525 it->bidi_it after backing up to previous newline. (Bug#9212)
1527 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1529 * regex.c (re_comp): Protoize.
1530 (re_exec): Fix return type.
1531 (regexec): Fix type of `ret'. (Bug#9203)
1533 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1535 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1536 This is needed if max-image-size is a floating-point number.
1538 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1540 * print.c (print_object): Print empty symbol as ##.
1542 * lread.c (read1): Read ## as empty symbol.
1544 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1546 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1547 setting frame foreground color (Bug#9175).
1548 (x_set_background_color): Likewise.
1550 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1551 contents (Bug#9176).
1552 (EmacsTooltip -init): Remove bezels and add shadows to
1555 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1556 or scroll bar (Bug#8470).
1558 * nsfont.m (nsfont_open): Remove assignment to voffset and
1559 unnecessary vars hshink, expand, hd, full_height, min_height.
1560 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1562 * nsterm.h (nsfont_info): Remove voffset field.
1564 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1566 Implement strike-through and overline on NextStep (Bug#8863).
1568 * nsfont.m (nsfont_open): Use underline position provided by font,
1569 instead of hard-coded value of 2.
1570 (nsfont_draw): Call ns_draw_text_decoration instead.
1572 * nsterm.h: Add declaration for ns_draw_text_decoration.
1574 * nsterm.m (ns_draw_text_decoration): New function for drawing
1575 underline, overline, and strike-through.
1576 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1577 ns_draw_text_decoration. Change treatment of cursor drawing to
1578 accommodate underlining, etc.
1580 2011-07-28 Eli Zaretskii <eliz@gnu.org>
1582 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1585 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1587 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1588 Without this fix, if a signal arrives just after memory fills up,
1589 'malloc' might be invoked reentrantly.
1591 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1592 In other words, assume that every image size is allowed, on non-X
1593 hosts. This assumption is probably wrong, but it lets Emacs compile.
1595 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1597 * regex.c (re_iswctype): Convert return values to boolean.
1599 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1601 * xdisp.c (compute_display_string_pos): Don't use cached display
1602 string position if the buffer had its restriction changed.
1605 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1607 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1609 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1611 Integer signedness and overflow and related fixes. (Bug#9079)
1613 * bidi.c: Integer size and overflow fixes.
1614 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1615 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1616 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1617 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1618 (bidi_find_other_level_edge):
1619 Use ptrdiff_t instead of EMACS_INT where either will do.
1620 This works better on 32-bit hosts configured --with-wide-int.
1621 (bidi_cache_ensure_space): Check for size-calculation overflow.
1622 Use % rather than repeated addition, for better worst-case speed.
1623 Don't set bidi_cache_size until after xrealloc returns, because it
1625 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
1626 (bidi_cache_ensure_space): Also check that the bidi cache size
1627 does not exceed that of the largest Lisp string or buffer. See Eli
1628 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
1630 * alloc.c (__malloc_size_t): Remove.
1631 All uses replaced by size_t. See Andreas Schwab's note
1632 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1634 * image.c: Improve checking for integer overflow.
1635 (check_image_size): Assume that f is nonnull, since
1636 it is always nonnull in practice. This is one less thing to
1637 worry about when checking for integer overflow later.
1638 (x_check_image_size): New function, which checks for integer
1639 overflow issues inside X.
1640 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1641 This removes the need for a memory_full check.
1642 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1643 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1644 (xbm_read_bitmap_data): Change locals back to 'int', since
1645 their values must fit in 'int'.
1646 (xpm_load_image, png_load, tiff_load):
1647 Invoke x_create_x_image_and_pixmap earlier,
1648 to avoid much needless work if the image is too large.
1649 (tiff_load): Treat overly large images as if
1650 x_create_x_image_and_pixmap failed, not as malloc failures.
1651 (gs_load): Use x_check_image_size.
1653 * gtkutil.c: Omit integer casts.
1654 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1655 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1657 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1659 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1660 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1661 would wrongly return t on a 64-bit host.
1663 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1664 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1665 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1666 and therefore cause GCC to emit a bogus diagnostic in some cases.
1668 * image.c: Integer signedness and overflow and related fixes.
1669 This is not an exhaustive set of fixes, but it's time to
1670 record what I've got.
1671 (lookup_pixel_color, check_image_size): Remove redundant decls.
1672 (check_image_size): Don't assume that arbitrary EMACS_INT values
1673 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1674 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1675 (tiff_load, imagemagick_load_image):
1676 Check for overflow in size calculations.
1677 (x_create_x_image_and_pixmap): Remove unnecessary test for
1678 xmalloc returning NULL; that can't happen.
1679 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1680 (xpm_color_bucket): Use better integer hashing function.
1681 (xpm_cache_color): Don't possibly over-allocate memory.
1682 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1683 (gif_memory_source):
1684 Use ptrdiff_t, not int or size_t, to record sizes.
1685 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1686 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1687 either works, as we prefer signed integers.
1688 (tiff_read_from_memory, tiff_write_from_memory):
1689 Return tsize_t, not size_t, since that's what the TIFF API wants.
1690 (tiff_read_from_memory): Don't fail simply because the read would
1691 go past EOF; instead, return a short read.
1692 (tiff_load): Omit no-longer-needed casts.
1693 (Fimagemagick_types): Don't assume size fits into 'int'.
1695 Improve hashing quality when configured --with-wide-int.
1696 * fns.c (hash_string): New function, taken from sxhash_string.
1697 Do not discard information about ASCII character case; this
1698 discarding is no longer needed.
1699 (sxhash-string): Use it. Change sig to match it. Caller changed.
1700 * lisp.h: Declare it.
1701 * lread.c (hash_string): Remove, since we now use fns.c's version.
1702 The fns.c version returns a wider integer if --with-wide-int is
1703 specified, so this should help the quality of the hashing a bit.
1705 * emacs.c: Integer overflow minor fix.
1706 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1707 Define only if GNU_LINUX.
1708 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1710 * dispnew.c: Integer signedness and overflow fixes.
1711 Remove unnecessary forward decls, that were a maintenance hassle.
1712 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1714 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1715 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1716 (prepare_desired_row, line_draw_cost):
1717 Use int, not unsigned, where either works.
1718 (save_current_matrix, restore_current_matrix):
1719 Use ptrdiff_t, not size_t, where either works.
1720 (init_display): Check for overflow more accurately, and without
1721 relying on undefined behavior.
1723 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1724 Remove, replacing with the new symbols in lisp.h. All uses changed.
1725 * fileio.c (make_temp_name):
1726 * filelock.c (lock_file_1, lock_file):
1727 * xdisp.c (message_dolog):
1728 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1729 Use pMd etc. instead.
1730 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1731 replacing the pWIDE etc. symbols removed from editfns.c.
1733 * keyboard.h (num_input_events): Now uintmax_t.
1734 This is (very slightly) less likely to mess up due to wraparound.
1737 * buffer.c: Integer signedness fixes.
1738 (alloc_buffer_text, enlarge_buffer_text):
1739 Use ptrdiff_t rather than size_t when either will do, as we prefer
1742 * alloc.c: Integer signedness and overflow fixes.
1743 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1744 (__malloc_size_t): Default to size_t, not to int.
1745 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1746 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1747 Prefer ptrdiff_t to size_t when either would do, as we prefer
1749 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1750 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1751 Now const. Initialize with values that are in range even if char
1753 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1754 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1755 These functions do the right thing with sizes > 2**32.
1756 (check_depth): Now ptrdiff_t, not int.
1757 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1758 Adjust to new way of storing sizes. Check for size overflow bugs
1760 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1761 slightly wrong anyway, as it missed one instance of
1762 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1763 (refill_memory_reserve): Omit needless cast to size_t.
1764 (mark_object_loop_halt): Mark as externally visible.
1766 * xselect.c: Integer signedness and overflow fixes.
1767 (Fx_register_dnd_atom, x_handle_dnd_message):
1768 Use ptrdiff_t, not size_t, since we prefer signed.
1769 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1770 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1771 x_dnd_atoms_size and x_dnd_atoms_length.
1773 * doprnt.c: Prefer signed to unsigned when either works.
1775 * doprnt.c (doprnt):
1777 * xdisp.c (vmessage):
1778 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1779 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1780 prefer signed arithmetic to avoid comparison confusion.
1781 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1782 but is a bit tricky.
1784 Assume freestanding C89 headers, string.h, stdlib.h.
1785 * data.c, doprnt.c, floatfns.c, print.c:
1786 Include float.h unconditionally.
1787 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1788 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1789 * regex.c: Likewise for stddef.h, string.h.
1790 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1791 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1792 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1793 (STDC_HEADERS): Remove obsolete defines.
1794 * sysdep.c: Include limits.h unconditionally.
1796 Assume support for memcmp, memcpy, memmove, memset.
1797 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1798 * regex.c (memcmp, memcpy):
1799 Remove; we assume C89 now.
1801 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1802 (__malloc_safe_bcopy): Remove; no longer needed.
1804 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
1805 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1806 well either way, and we prefer signed to unsigned.
1808 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1810 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1811 closes the connection while we're reading (bug#9182).
1813 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
1815 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1816 are specified (Bug#9168).
1818 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1820 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1821 Found by GCC static checking and --with-wide-int on a 32-bit host.
1823 2011-07-25 Eli Zaretskii <eliz@gnu.org>
1825 * xdisp.c (compute_display_string_pos): Fix logic of caching
1826 previous display string position. Initialize cached_prev_pos to
1827 -1. Fixes slow-down at the beginning of a buffer.
1829 2011-07-24 Eli Zaretskii <eliz@gnu.org>
1831 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1832 for attrs[LFACE_FONTSET_INDEX].
1834 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1836 * xml.c (parse_region): Remove unused local
1837 that was recently introduced.
1839 2011-07-23 Eli Zaretskii <eliz@gnu.org>
1841 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1842 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1844 * xdisp.c (move_it_in_display_line_to): Record the best matching
1845 position for TO_CHARPOS while scanning the line, and restore it on
1846 exit if none of the characters scanned was an exact match.
1847 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
1848 when exact match is impossible due to invisible text, and the
1849 lines are truncated.
1851 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1853 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1856 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1858 Fix a significant slow-down of cursor motion with C-n, C-p,
1859 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1860 auto-repeat under bidi redisplay in fontified buffers.
1861 * xdisp.c (compute_stop_pos_backwards): New function.
1862 (next_element_from_buffer): Call compute_stop_pos_backwards to
1863 find a suitable prev_stop when we find ourselves before
1865 (reseat): Don't look for prev_stop, as that could mean a very long
1867 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1868 <cached_disp_overlay_modiff>: Cache for last found display string
1870 (compute_display_string_pos): Return the cached position if asked
1871 about the same buffer in the same area of character positions, and
1872 the buffer wasn't changed since the time the display string
1873 position was cached.
1875 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1877 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1878 is an integer, which is important for empty lines. (Bug#9149)
1880 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
1882 * frame.c (Fmodify_frame_parameters): In tty case, update the
1883 default face if necessary (Bug#4238).
1885 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
1887 * editfns.c (Fstring_to_char): No need to explain what a character
1888 is in the docstring (Bug#6576).
1890 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1892 * xml.c (parse_region): Make sure we always return a tree.
1894 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1896 * xml.c (parse_region): If a document contains only comments,
1899 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1901 * xml.c (make_dom): Return comments, too.
1903 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1906 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1907 and the surrounding thread.
1908 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1909 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1910 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1912 * s/openbsd.h (BROKEN_SIGIO): Define.
1913 * unexelf.c (unexec) [__OpenBSD__]:
1914 Don't update the .mdebug section of the Alpha COFF symbol table.
1916 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1918 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1921 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1923 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1924 This fixes some race conditions on the permissions of any newly
1927 * alloc.c (valid_pointer_p): Use pipe, not open.
1928 This fixes some permissions issues when debugging.
1930 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1931 If fchown fails to set both uid and gid, try to set just gid,
1932 as that is sometimes allowed. Adjust the file's mode to eliminate
1933 setuid or setgid bits that are inappropriate if fchown fails.
1935 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1937 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1938 to compare Lisp_Objects.
1939 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1940 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1941 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1943 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1945 * lread.c (read_integer): Unread even EOF character.
1946 (read1): Likewise. Properly record start position of symbol.
1948 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1949 symbol character follows.
1951 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1953 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1954 This works around a problem with the previous change to Fcopy_file.
1955 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1956 and without this change, GCC might complain about discarding
1957 fchown's return value.
1959 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
1961 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1963 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1965 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1967 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1969 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1970 it's used from the C level.
1972 * process.c: Use the same condition for POLL_FOR_INPUT in both
1973 keyboard.c and process.c (bug#1858).
1975 2011-07-09 Lawrence Mitchell <wence@gmx.li>
1977 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1978 (Fgnutls_boot): Use it.
1980 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1982 * doc.c (Fsubstitute_command_keys): Revert last change.
1984 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1986 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1987 quotes the next character, and doesn't affect other longer
1988 sequences (bug#8935).
1990 * lread.c (syms_of_lread): Clarify that is isn't only
1991 `eval-buffer' and `eval-defun' that's affected by
1992 `lexical-binding' (bug#8460).
1994 2011-07-15 Eli Zaretskii <eliz@gnu.org>
1996 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1997 bidi redisplay when a line includes both an image and is
2000 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2002 Fix minor problems found by static checking.
2003 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2004 (elsz): Now a signed constant, not a size_t var. We prefer signed
2005 types to unsigned, to avoid integer comparison confusion. Without
2006 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2007 "cannot optimize loop, the loop counter may overflow", a symptom
2009 * indent.c (Fvertical_motion): Mark locals as initialized.
2010 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2012 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2014 * search.c (Fre_search_backward): Mention `case-fold-search' in
2015 all the re_search_* functions (bug#8138).
2017 * keyboard.c (Fopen_dribble_file): Document when the file is
2020 2011-07-14 Eli Zaretskii <eliz@gnu.org>
2022 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2025 Support bidi reordering of display and overlay strings.
2026 * xdisp.c (compute_display_string_pos)
2027 (compute_display_string_end): Accept additional argument STRING.
2028 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2029 (reseat_to_string): Initialize bidi_it->string.s and
2030 bidi_it->string.schars.
2031 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
2032 NULL (avoids a crash in bidi_paragraph_init).
2033 Initialize itb.string.lstring.
2034 (init_iterator): Call bidi_init_it only of a valid
2035 buffer position was specified. Initialize paragraph_embedding to
2037 (reseat_to_string): Initialize the bidi iterator.
2038 (display_string): If we need to ignore text properties of
2039 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2040 original value of -1 will not work with bidi.)
2041 (compute_display_string_pos): First arg is now struct
2042 `text_pos *'; all callers changed. Support display properties on
2044 (compute_display_string_end): Support display properties on Lisp
2046 (init_iterator, reseat_1, reseat_to_string): Initialize the
2047 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2048 when iterating on a string not from display properties).
2049 (compute_display_string_pos, compute_display_string_end):
2050 Fix calculation of the object to scan. Fixes an error when using
2052 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
2053 base_level_stop; instead, set base_level_stop to BEGV.
2054 Fixes crashes in vertical-motion.
2055 (next_element_from_buffer): Improve commentary for when
2056 the iterator is before prev_stop.
2057 (init_iterator): Initialize bidi_p from the default value of
2058 bidi-display-reordering, not from buffer-local value. Use the
2059 buffer-local value only if initializing for buffer iteration.
2060 (handle_invisible_prop): Support invisible properties on strings
2061 that are being bidi-reordered.
2062 (set_iterator_to_next): Support bidi reordering of C strings and
2064 (next_element_from_string): Support bidi reordering of Lisp
2066 (handle_stop_backwards): Support Lisp strings as well.
2067 (display_string): Support display of R2L glyph rows.
2068 Use IT_STRING_CHARPOS when displaying from a Lisp string.
2069 (init_iterator): Don't initialize it->bidi_p for strings
2071 (reseat_to_string): Initialize it->bidi_p for strings here.
2072 (next_element_from_string, next_element_from_c_string)
2073 (next_element_from_buffer): Add xassert's for correspondence
2074 between IT's object being iterated and it->bidi_it.string
2076 (face_before_or_after_it_pos): Support bidi iteration.
2077 (next_element_from_c_string): Handle the case of the first string
2078 character that is not the first one in the visual order.
2079 (get_visually_first_element): New function, refactored from common
2080 parts of next_element_from_buffer, next_element_from_string, and
2081 next_element_from_c_string.
2082 (tool_bar_lines_needed, redisplay_tool_bar)
2083 (display_menu_bar): Force left-to-right direction. Add a FIXME
2084 comment for making that be controlled by a user option.
2085 (push_it, pop_it): Save and restore the state of the
2086 bidi iterator. Save and restore the bidi_p flag.
2087 (pop_it): Iterate out of display property for string iteration as
2089 (iterate_out_of_display_property): Support iteration over strings.
2090 (handle_single_display_spec): Set up it->bidi_it for iteration
2091 over a display string, and call bidi_init_it.
2092 (handle_single_display_spec, next_overlay_string)
2093 (get_overlay_strings_1, push_display_prop): Set up the bidi
2094 iterator for displaying display or overlay strings.
2095 (forward_to_next_line_start): Don't use the shortcut if
2097 (back_to_previous_visible_line_start): If handle_display_prop
2098 pushed the iterator stack, restore the internal state of the bidi
2099 iterator by calling bidi_pop_it same number of times.
2100 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2101 and we are bidi-iterating, don't decrement the iterator position;
2102 instead, set the first_elt flag in the bidi iterator, to produce
2104 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2105 (push_display_prop): xassert that we are iterating a buffer.
2106 (push_it, pop_it): Save and restore paragraph_embedding member.
2107 (handle_single_display_spec, next_overlay_string)
2108 (get_overlay_strings_1, reseat_1, reseat_to_string)
2109 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2110 correctly. Don't assume unibyte strings are not bidi-reordered.
2111 (compute_display_string_pos)
2112 (compute_display_string_end): Fix handling the case of C string.
2113 (push_it, pop_it): Save and restore from_disp_prop_p.
2114 (handle_single_display_spec, push_display_prop): Set the
2115 from_disp_prop_p flag.
2116 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2117 (pop_it): Call iterate_out_of_display_property only if we are
2118 popping after iteration over a string that came from a display
2119 property. Fix a typo in popping stretch info. Add an assertion
2120 for verifying that the iterator position is in sync with the bidi
2122 (handle_single_display_spec, get_overlay_strings_1)
2123 (push_display_prop): Fix initialization of paragraph direction for
2124 string when that of the parent object is not yet determined.
2125 (reseat_1): Call bidi_init_it to resync the bidi
2126 iterator with IT's position. (Bug#7616)
2127 (find_row_edges): If ROW->start.pos gives position
2128 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2129 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2130 Reset the from_disp_prop_p flag.
2131 (SAVE_IT, RESTORE_IT): New macros.
2132 (pos_visible_p, face_before_or_after_it_pos)
2133 (back_to_previous_visible_line_start)
2134 (move_it_in_display_line_to, move_it_in_display_line)
2135 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2136 (try_scrolling, redisplay_window, display_line): Use them when
2137 saving a temporary copy of the iterator and restoring it back.
2138 (back_to_previous_visible_line_start, reseat_1)
2139 (init_iterator): Empty the bidi cache "stack".
2140 (move_it_in_display_line_to): If iterator ended up at
2141 EOL, but we never saw any buffer positions smaller than
2142 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2143 motion in bidi-reordered lines.
2144 (move_it_in_display_line_to): Record prev_method and prev_pos
2145 immediately before the call to set_iterator_to_next. Fixes cursor
2146 motion in bidi-reordered lines with stretch glyphs and strings
2147 displayed in margins. (Bug#8133) (Bug#8867)
2148 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2150 (pos_visible_p): Support positions in bidi-reordered lines.
2151 Save and restore bidi cache.
2153 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2154 (bidi_paragraph_info): Delete unused struct.
2155 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2156 (bidi_cache_start): New variable.
2157 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2159 (bidi_cache_fetch_state, bidi_cache_search)
2160 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2161 (bidi_cache_find, bidi_peek_at_next_level)
2162 (bidi_level_of_next_char, bidi_find_other_level_edge)
2163 (bidi_move_to_visually_next): Compare cache index with
2164 bidi_cache_start rather than with zero.
2165 (bidi_fetch_char): Accept new argument STRING; all callers
2166 changed. Support iteration over a string. Support strings with
2167 display properties. Support unibyte strings. Fix the type of
2168 `len' according to what STRING_CHAR_AND_LENGTH expects.
2169 (bidi_paragraph_init, bidi_resolve_explicit_1)
2170 (bidi_resolve_explicit, bidi_resolve_weak)
2171 (bidi_level_of_next_char, bidi_move_to_visually_next):
2172 Support iteration over a string.
2173 (bidi_set_sor_type, bidi_resolve_explicit_1)
2174 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2175 can now be zero (for strings); special values 0 and -1 were
2176 changed to -1 and -2, respectively.
2177 (bidi_char_at_pos): New function.
2178 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2179 Call it instead of FETCH_MULTIBYTE_CHAR.
2180 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2181 initialized to valid values.
2182 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2184 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2185 the test for valid cached positions. Fix the logic for looking up
2186 the sentinel state in the cache. GCPRO the Lisp string we are
2188 (bidi_push_it, bidi_pop_it): New functions.
2189 (bidi_initialize): Initialize the bidi cache start stack pointer.
2190 (bidi_cache_ensure_space): New function, refactored from part of
2191 bidi_cache_iterator_state. Don't assume the required size is just
2192 one BIDI_CACHE_CHUNK away.
2193 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2194 (bidi_count_bytes, bidi_char_at_pos): New functions.
2195 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2196 always valid if bidi_cache_idx is valid.
2197 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2198 is valid if it's going to be used.
2199 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2200 (bidi_cache_fetch_state, bidi_cache_search)
2201 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2202 (bidi_cache_iterator_state, bidi_cache_find)
2203 (bidi_find_other_level_edge, bidi_cache_start_stack):
2204 All variables related to cache indices are now EMACS_INT.
2206 * dispextern.h (struct bidi_string_data): New structure.
2207 (struct bidi_it): New member `string'. Make flag members be 1-bit
2208 fields, and put them last in the struct.
2209 (compute_display_string_pos, compute_display_string_end):
2211 (bidi_push_it, bidi_pop_it): Add prototypes.
2212 (struct iterator_stack_entry): New members bidi_p,
2213 paragraph_embedding, and from_disp_prop_p.
2214 (struct it): Member bidi_p is now a bit field 1 bit wide.
2215 (bidi_shelve_cache, bidi_unshelve_cache):
2218 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2219 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2220 and vector-like objects.
2222 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2223 cache around display iteration.
2225 * window.c (Fwindow_end, window_scroll_pixel_based)
2226 (displayed_window_lines, Frecenter): Save and restore the bidi
2227 cache around display iteration.
2229 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2231 * editfns.c (Fdelete_region): Clarify the use of the named
2232 parameters (bug#6788).
2234 2011-07-14 Martin Rudalics <rudalics@gmx.at>
2236 * indent.c (Fvertical_motion): Set and restore w->pointm when
2237 saving and restoring the window's buffer (Bug#9006).
2239 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2241 * editfns.c (Fstring_to_char): Clarify just what is returned
2242 (bug#6576). Text by Eli Zaretskii.
2244 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
2246 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2248 2011-07-13 Eli Zaretskii <eliz@gnu.org>
2250 * buffer.c (mmap_find): Fix a typo.
2252 2011-07-13 Johan Bockgård <bojohan@gnu.org>
2254 Fix execution of x selection hooks.
2255 * xselect.c (Qx_lost_selection_functions)
2256 (Qx_sent_selection_functions): New vars.
2257 (syms_of_xselect): DEFSYM them.
2258 (x_handle_selection_request): Pass Qx_sent_selection_functions
2259 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2260 (x_handle_selection_clear,x_clear_frame_selections):
2261 Pass Qx_lost_selection_functions rather than
2262 Vx_lost_selection_functions to Frun_hook_with_args.
2264 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2266 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2267 The old code sometimes used this field without initializing it.
2269 * alloc.c (gc_sweep): Don't read past end of array.
2270 In theory, the old code could also have corrupted Emacs internals,
2271 though it'd be very unlikely.
2273 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2275 * character.c (Fcharacterp): Don't advertise optional ignored
2276 argument. (Bug#4026)
2278 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2280 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2283 * window.c (Fset_window_start): Doc fix (bug#4199).
2284 (Fset_window_hscroll): Ditto.
2286 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2288 Fix minor new problems caught by GCC 4.6.1.
2289 * term.c (init_tty): Remove unused local.
2290 * xsettings.c (store_monospaced_changed): Define this function only
2291 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
2294 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
2296 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2298 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2300 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2301 are the mini-buffer and the echo area (bug#3320).
2303 * term.c (init_tty): Remove support for supdup, c10 and perq
2304 terminals, which are no longer supported (bug#1482).
2306 2011-07-10 Johan Bockgård <bojohan@gnu.org>
2308 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2310 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2312 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2313 for non-popups (Bug#3642).
2315 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2317 * alloc.c (reset_malloc_hooks): Protoize.
2318 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
2319 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2320 * cm.c (losecursor): Likewise.
2321 * data.c (fmod): Likewise.
2322 * dispnew.c (swap_glyphs_in_rows): Likewise.
2323 * emacs.c (memory_warning_signal): Likewise.
2324 * floatfns.c (float_error): Likewise.
2325 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2326 (otf_open, font_otf_capability, generate_otf_features)
2327 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2329 * image.c (pbm_read_file): Likewise.
2330 * indent.c (string_display_width): Likewise.
2331 * intervals.c (check_for_interval, search_for_interval)
2332 (inc_interval_count, count_intervals, root_interval)
2333 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2334 * lread.c (defalias): Likewise.
2335 * ralloc.c (r_alloc_check): Likewise.
2336 * regex.c (set_image_of_range_1, set_image_of_range)
2337 (regex_grow_registers): Likewise.
2338 * sysdep.c (strerror): Likewise.
2339 * termcap.c (valid_filename_p, tprint, main): Likewise.
2340 * tparam.c (main): Likewise.
2341 * unexhp9k800.c (run_time_remap, save_data_space)
2342 (update_file_ptrs, read_header, write_header, calculate_checksum)
2343 (copy_file, copy_rest, display_header): Likewise.
2344 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2346 * xdisp.c (check_it): Likewise.
2347 * xfaces.c (register_color, unregister_color, unregister_colors):
2349 * xfns.c (print_fontset_result): Likewise.
2350 * xrdb.c (member, fatal, main): Likewise.
2352 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2354 Fix minor problems found by static checking (Bug#9031).
2355 * chartab.c (char_table_set_range, map_sub_char_table):
2356 Remove unused locals.
2357 (uniprop_table): Now static.
2358 * composite.c (_work_char): Remove unused static var.
2360 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
2362 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2364 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2366 * gtkutil.c (qttip_cb): Remove code without function.
2368 2011-07-09 Eli Zaretskii <eliz@gnu.org>
2370 * w32.c (pthread_sigmask): New stub.
2372 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
2374 Use pthread_sigmask, not sigprocmask (Bug#9010).
2375 sigprocmask is portable only for single-threaded applications, and
2376 Emacs can be multi-threaded when it uses GTK.
2377 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2379 * callproc.c (Fcall_process):
2380 * process.c (create_process):
2381 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2382 Use pthread_sigmask, not sigprocmask.
2384 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2386 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2387 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2390 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2392 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2393 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2394 (xg_hide_tooltip): Fix comment.
2396 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2397 in registerServicesMenuSendTypes.
2398 (validRequestorForSendType): Don't check ns_return_types.
2400 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2403 2011-07-08 Jason Rumney <jasonr@gnu.org>
2405 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2406 frame struct members of non-existent frames (Bug#6284).
2408 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2410 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2411 variable firstTime not needed on OSX >= 10.6.
2412 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2413 >= 10.5. Use setKnobProportion, setDoubleValue.
2415 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2416 (MAC_OS_X_VERSION_10_5): Define if not defined.
2417 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2418 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2419 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2421 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2422 cString and lossyCString on OSX >= 10.4
2424 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2425 sizeToFit on OSX >= 10.2.
2427 * nsimage.m (allocInitFromFile): Don't use deprecated method
2428 bestRepresentationForDevice on OSX >= 10.6.
2430 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2433 * emacs.c: Declare unexec_init_emacs_zone.
2435 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2437 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2439 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2440 on svcsMenu (Bug#8842).
2442 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2444 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2446 * nsterm.m (QUTF8_STRING): Declare.
2447 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2448 (validRequestorForSendType): Return type is (id).
2449 Change indexOfObjectIdenticalTo to indexOfObject.
2450 Check if we have local selection before returning self (Bug#8842).
2451 (writeSelectionToPasteboard): Put local selection into paste board
2452 if we have a local selection (Bug#8842).
2453 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2455 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2456 (ns_get_local_selection): Declare.
2458 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2460 * keymap.c (describe_map_tree): Don't insert a double newline at
2461 the end of the buffer (bug#1169) and return whether we inserted
2464 * callint.c (Fcall_interactively): Change "reading args" to
2465 "providing args" to try to clarify what it does (bug#1010).
2467 2011-07-07 Kenichi Handa <handa@m17n.org>
2469 * composite.c (composition_compute_stop_pos): Ignore a static
2470 composition starting before CHARPOS (Bug#8915).
2472 * xdisp.c (handle_composition_prop): Likewise.
2474 2011-07-07 Eli Zaretskii <eliz@gnu.org>
2476 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2479 2011-07-07 Kenichi Handa <handa@m17n.org>
2481 * character.h (unicode_category_t): New enum type.
2483 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2484 (Qchar_code_property_table): New variable.
2485 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2486 (UNIPROP_COMPRESSED_FORM_P): New macros.
2487 (char_table_ascii): Uncompress the compressed values.
2488 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2489 Uncompress the compressed values.
2490 (sub_char_table_ref_and_range): Likewise.
2491 (char_table_ref_and_range): Uncompress the compressed values.
2492 (sub_char_table_set): New arg is_uniprop. Callers changed.
2493 Uncompress the compressed values.
2494 (sub_char_table_set_range): Args changed. Callers changed.
2495 (char_table_set_range): Adjuted for the above change.
2496 (map_sub_char_table): Delete args default_val and parent. Add arg
2497 top. Give decoded values to a Lisp function.
2498 (map_char_table): Adjust for the above change. Give decoded
2499 values to a Lisp function. Gcpro more variables.
2500 (uniprop_table_uncompress)
2501 (uniprop_decode_value_run_length): New functions.
2502 (uniprop_decoder, uniprop_decoder_count): New variables.
2503 (uniprop_get_decoder, uniprop_encode_value_character)
2504 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2506 (uniprop_encoder, uniprop_encoder_count): New variables.
2507 (uniprop_get_encoder, uniprop_table)
2508 (Funicode_property_table_internal, Fget_unicode_property_internal)
2509 (Fput_unicode_property_internal): New functions.
2510 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2511 Sunicode_property_table_internal, Sget_unicode_property_internal,
2512 and Sput_unicode_property_internal. Defvar_lisp
2513 char-code-property-alist.
2515 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
2516 Vunicode_category_table.
2518 * font.c (font_range): Adjust for the change of
2519 Vunicode_category_table.
2521 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2523 * m/iris4d.h: Remove file, move contents ...
2524 * s/irix6-5.h: ... here.
2526 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2528 Remove unportable assumption about struct layout (Bug#8884).
2529 * alloc.c (mark_buffer):
2530 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2531 (clone_per_buffer_values): Don't assume that
2532 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2533 This isn't true in general, and it's particularly not true
2534 if Emacs is configured with --with-wide-int.
2535 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2536 New macros, used in the buffer.c change.
2538 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2540 * xsettings.c: Use both GConf and GSettings if both are available.
2541 (store_config_changed_event): Add comment.
2542 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2543 (store_tool_bar_style_changed): New functions.
2544 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
2545 (struct xsettings): Move font inside HAVE_XFT.
2546 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
2547 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
2548 Move inside HAVE_XFT.
2549 (something_changed_gsettingsCB): Rename from something_changedCB.
2550 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2552 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
2553 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
2554 (something_changed_gconfCB): Rename from something_changedCB.
2555 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2556 (parse_settings): Move check for font inside HAVE_XFT.
2557 (read_settings, apply_xft_settings): Add comment.
2558 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2559 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2560 call store_font_name_changed.
2561 (xft_settings_event): Add comment.
2562 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2563 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2564 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2565 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2566 (xsettings_initialize): Call init_gsettings last.
2567 (xsettings_get_system_font, xsettings_get_system_normal_font):
2570 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2572 Random fixes. E.g., (random) never returned negative values.
2573 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2574 subseconds part to the entropy, as that's a bit more random.
2575 Prefer signed to unsigned, since the signedness doesn't matter and
2576 in general we prefer signed. When given a limit, use a
2577 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2578 latter isn't right if USE_2_TAGS_FOR_INTS.
2579 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2580 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2582 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2584 * textprop.c (text_property_stickiness):
2585 Obey Vtext_property_default_nonsticky.
2586 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2587 * w32fns.c (syms_of_w32fns):
2588 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2590 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2592 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2593 This is more efficient than Ffile_directory_p and avoids a minor race.
2595 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2597 * buffer.c (Foverlay_put): Say what the return value is
2600 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2601 is a directory before asking whether to use the file name
2603 (barf_or_query_if_file_exists): Make the "File is a directory"
2604 error be more correct.
2606 * fns.c (Frequire): Remove the mention of the .gz files, since
2607 that's installation-specific, but keep the mention of
2608 `get-load-suffixes'.
2610 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2612 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2613 Report string overflow if the output is too long.
2615 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
2617 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2618 (syms_of_gnutls): Remove duplicate DEFSYM for
2619 Qgnutls_bootprop_verify_hostname_error, an error for
2620 Qgnutls_bootprop_verify_error (which is no longer used).
2622 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2623 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2624 Also (re)move comments that are misplaced or no longer relevant.
2626 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2628 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2630 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
2632 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2633 and background color parameters if they have been changed.
2635 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2637 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2639 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2641 * xsettings.c (SYSTEM_FONT): Define only when used.
2642 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2644 * keymap.c (access_keymap_1): Now static.
2646 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
2648 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2649 leave any prefix arg for the up event (Bug#1586).
2651 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2653 * lread.c (syms_of_lread): Mention single symbols defined by
2654 `defvar' or `defconst' (bug#7154).
2656 * fns.c (Frequire): Mention .el.gz files (bug#7314).
2657 (Frequire): Mention get-load-suffixes.
2659 2011-07-02 Martin Rudalics <rudalics@gmx.at>
2661 * window.h (window): Remove clone_number slot.
2662 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2664 (make_parent_window, make_window, saved_window)
2665 (Fset_window_configuration, save_window_save): Don't deal with
2667 * buffer.c (Qclone_number): Remove declaration.
2668 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2670 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2672 Add multiple inheritance to keymaps.
2673 * keymap.c (Fmake_composed_keymap): New function.
2674 (Fset_keymap_parent): Simplify.
2675 (fix_submap_inheritance): Remove.
2676 (access_keymap_1): New function extracted from access_keymap to handle
2677 embedded parents and handle lists of maps.
2678 (access_keymap): Use it.
2679 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2680 (Fcopy_keymap): Handle embedded parents.
2681 (Fcommand_remapping, define_as_prefix): Simplify.
2682 (Fkey_binding): Simplify.
2683 (syms_of_keymap): Move minibuffer-local-completion-map,
2684 minibuffer-local-filename-completion-map,
2685 minibuffer-local-must-match-map, and
2686 minibuffer-local-filename-must-match-map to Elisp.
2687 (syms_of_keymap): Defsubr make-composed-keymap.
2688 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2689 (parse_menu_item): Trivial simplification.
2691 2011-07-01 Glenn Morris <rgm@gnu.org>
2693 * Makefile.in (SETTINGS_LIBS): Fix typo.
2695 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2697 * coding.c (Fencode_coding_string): Record the last coding system
2698 used, as the function doc string says (bug#8738).
2700 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2702 * xsettings.c (store_monospaced_changed): Take new font as arg and
2703 check for change against current_mono_font.
2704 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2705 (emacs_settings_constructor, emacs_settings_get_property)
2706 (emacs_settings_set_property, emacs_settings_class_init)
2707 (emacs_settings_init, gsettings_obj): Remove.
2708 (something_changedCB): New function for HAVE_GSETTINGS.
2709 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2710 with value as argument.
2711 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2712 g_settings_new (Bug#8967). Do not create gsettings_obj.
2713 Remove calls to g_settings_bind. Connect something_changedCB to
2716 * xgselect.c: Add defined (HAVE_GSETTINGS).
2717 (xgselect_initialize): Ditto.
2719 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2720 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2723 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2725 * eval.c (struct backtrace): Simplify and port the data structure.
2726 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2727 signed bit field, as this assumption is not portable and it makes
2728 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2729 "char debug_on_exit : 1" as this is not portable either; instead,
2730 use the portable "unsigned int debug_on_exit : 1". Remove unused
2731 member evalargs. Remove obsolete comments about cc bombing out.
2733 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2735 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
2736 Let HAVE_GSETTINGS override HAVE_GCONF.
2737 (store_monospaced_changed): New function.
2738 (EMACS_SETTINGS): A new type derived from GObject to handle
2739 GSettings notifications.
2740 (emacs_settings_constructor, emacs_settings_get_property)
2741 (emacs_settings_set_property, emacs_settings_class_init):
2743 (gsettings_client, gsettings_obj): New variables.
2744 (GSETTINGS_SCHEMA): New define.
2745 (something_changedCB): Call store_monospaced_changed.
2746 (init_gsettings): New function.
2747 (xsettings_initialize): Call init_gsettings.
2748 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2751 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
2754 2011-06-29 Martin Rudalics <rudalics@gmx.at>
2756 * window.c (resize_root_window, grow_mini_window)
2757 (shrink_mini_window): Rename Qresize_root_window to
2758 Qwindow_resize_root_window and Qresize_root_window_vertically to
2759 Qwindow_resize_root_window_vertically.
2761 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2763 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2765 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
2767 * makefile.w32-in: Redesign dependencies so they reflect more
2768 clearly which files are directly included by each source file,
2769 and not through other includes.
2771 2011-06-27 Martin Rudalics <rudalics@gmx.at>
2773 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2774 (sort_overlays, overlay_strings): When an overlay's clone number
2775 matches the window's clone number process the overlay even if
2776 the overlay's window property doesn't match the current window.
2778 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2779 (Fwindow_hchild): Rename to Fwindow_left_child.
2780 (Fwindow_next): Rename to Fwindow_next_sibling.
2781 (Fwindow_prev): Rename to Fwindow_prev_sibling.
2782 (resize_window_check): Rename to window_resize_check.
2783 (resize_window_apply): Rename to window_resize_apply.
2784 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2785 (Fdelete_other_windows_internal, resize_frame_windows)
2786 (Fsplit_window_internal, Fdelete_window_internal)
2787 (grow_mini_window, shrink_mini_window)
2788 (Fresize_mini_window_internal): Fix callers accordingly.
2790 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2792 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2793 (emacs_fixed_set_min_size): Remove.
2794 (emacs_fixed_new): Take frame as argument.
2796 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2797 (_EmacsFixedPrivate): Remove minwidth/height.
2798 Add struct frame *f.
2799 (emacs_fixed_init): Initialize priv->f.
2800 (get_parent_class, emacs_fixed_set_min_size): Remove.
2801 (emacs_fixed_new): Set priv->f to argument.
2802 (emacs_fixed_get_preferred_width)
2803 (emacs_fixed_get_preferred_height): Use min_width/height from
2804 frames size_hint to set minimum and natural (Bug#8919).
2805 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2806 and use min_width/height from frames size_hint to set
2807 min_width/height (Bug#8919).
2809 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
2810 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2813 2011-06-26 Eli Zaretskii <eliz@gnu.org>
2815 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2816 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2819 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
2821 * process.c (wait_reading_process_output): Bypass select if
2822 waiting for a cell while ignoring keyboard input, and input is
2823 pending. Suggested by Jan Djärv (Bug#8869).
2825 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2827 Use gnulib's dup2 module instead of rolling our own.
2828 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2830 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2832 * dispnew.c (scrolling_window): Before scrolling, turn off a
2833 mouse-highlight in the window being scrolled.
2835 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
2837 Move DEFSYM to lisp.h and use everywhere.
2839 * character.h (DEFSYM): Move declaration...
2840 * lisp.h (DEFSYM): ...here.
2846 * w32select.c: Don't include character.h.
2848 * alloc.c (syms_of_alloc):
2849 * buffer.c (syms_of_buffer):
2850 * bytecode.c (syms_of_bytecode):
2851 * callint.c (syms_of_callint):
2852 * casefiddle.c (syms_of_casefiddle):
2853 * casetab.c (init_casetab_once):
2854 * category.c (init_category_once, syms_of_category):
2855 * ccl.c (syms_of_ccl):
2856 * cmds.c (syms_of_cmds):
2857 * composite.c (syms_of_composite):
2858 * dbusbind.c (syms_of_dbusbind):
2859 * dired.c (syms_of_dired):
2860 * dispnew.c (syms_of_display):
2861 * doc.c (syms_of_doc):
2862 * editfns.c (syms_of_editfns):
2863 * emacs.c (syms_of_emacs):
2864 * eval.c (syms_of_eval):
2865 * fileio.c (syms_of_fileio):
2866 * fns.c (syms_of_fns):
2867 * frame.c (syms_of_frame):
2868 * fringe.c (syms_of_fringe):
2869 * insdel.c (syms_of_insdel):
2870 * keymap.c (syms_of_keymap):
2871 * lread.c (init_obarray, syms_of_lread):
2872 * macros.c (syms_of_macros):
2873 * msdos.c (syms_of_msdos):
2874 * print.c (syms_of_print):
2875 * process.c (syms_of_process):
2876 * search.c (syms_of_search):
2877 * sound.c (syms_of_sound):
2878 * syntax.c (init_syntax_once, syms_of_syntax):
2879 * terminal.c (syms_of_terminal):
2880 * textprop.c (syms_of_textprop):
2881 * undo.c (syms_of_undo):
2882 * w32.c (globals_of_w32):
2883 * window.c (syms_of_window):
2884 * xdisp.c (syms_of_xdisp):
2885 * xfaces.c (syms_of_xfaces):
2886 * xfns.c (syms_of_xfns):
2887 * xmenu.c (syms_of_xmenu):
2888 * xsettings.c (syms_of_xsettings):
2889 * xterm.c (syms_of_xterm): Use DEFSYM.
2891 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2893 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
2895 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2897 Integer and buffer overflow fixes (Bug#8873).
2899 * print.c (printchar, strout): Check for string overflow.
2900 (PRINTPREPARE, printchar, strout):
2901 Don't set size unless allocation succeeds.
2903 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2904 for sizes. Check for string overflow more accurately.
2905 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2907 * macros.c: Integer and buffer overflow fixes.
2908 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2909 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2910 Use ptrdiff_t, not int, for sizes.
2911 Don't increment bufsize until after realloc succeeds.
2912 Check for size-calculation overflow.
2913 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2915 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2917 * lread.c: Integer overflow fixes.
2918 (read_integer): Radix is now EMACS_INT, not int,
2919 to improve quality of diagnostics for out-of-range radices.
2920 Calculate buffer size correctly for out-of-range radices.
2921 (read1): Check for integer overflow in radices, and in
2922 read-circle numbers.
2923 (read_escape): Avoid int overflow.
2924 (Fload, openp, read_buffer_size, read1)
2925 (substitute_object_recurse, read_vector, read_list, map_obarray):
2926 Use ptrdiff_t, not int, for sizes.
2927 (read1): Use EMACS_INT, not int, for sizes.
2928 Check for size overflow.
2930 * image.c (cache_image): Check for size arithmetic overflow.
2932 * lread.c: Integer overflow issues.
2933 (saved_doc_string_size, saved_doc_string_length)
2934 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2935 Now ptrdiff_t, not int.
2936 (read1): Don't assume doc string length fits in int. Check for
2937 out-of-range doc string lengths.
2938 (read_list): Don't assume file position fits in int.
2939 (read_escape): Check for hex character overflow.
2941 2011-06-22 Leo Liu <sdl.web@gmail.com>
2943 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2944 Move to minibuffer.el.
2946 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2948 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
2949 The following patches are for when GLYPH_DEBUG && !XASSERT.
2950 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2951 * dispnew.c (flush_stdout):
2952 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2953 Mark as externally visible.
2954 * dispnew.c (check_window_matrix_pointers): Now static.
2955 * dispnew.c (window_to_frame_vpos):
2956 * xfns.c (unwind_create_frame):
2957 * xterm.c (x_check_font): Remove unused local.
2958 * scroll.c (CHECK_BOUNDS):
2959 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2960 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2961 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2962 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2963 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2965 (debug_method_add): Use va_list and vsprintf rather than relying
2966 on undefined behavior with wrong number of arguments.
2967 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2968 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2969 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2970 since we're not interested in debugging glyphs with old libraries.
2971 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2972 GCC 4.6.0's static checking.
2974 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2976 Integer overflow and signedness fixes (Bug#8873).
2977 A few related buffer overrun fixes, too.
2979 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2981 * dispextern.h (struct face.stipple):
2982 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2983 (x_bitmap_mask, x_allocate_bitmap_record)
2984 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2985 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2986 (x_create_bitmap_from_xpm_data):
2987 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2988 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2990 * xfaces.c (load_pixmap):
2991 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2992 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2993 (.bitmaps_last, struct x_output.icon_bitmap):
2994 Use ptrdiff_t, not int, for bitmap indexes.
2995 (x_allocate_bitmap_record): Check for size overflow.
2996 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2998 Use ptrdiff_t, not int, for overlay counts.
2999 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3000 * editfns.c (overlays_around, get_pos_property):
3001 * textprop.c (get_char_property_and_overlay):
3002 * xdisp.c (next_overlay_change, note_mouse_highlight):
3003 * xfaces.c (face_at_buffer_position):
3004 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3005 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3006 (Fnext_overlay_change, Fprevious_overlay_change)
3007 (mouse_face_overlay_overlaps, Foverlays_in):
3008 Use ptrdiff_t, not int, for sizes.
3009 (overlays_at, overlays_in): Check for size-calculation overflow.
3011 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3013 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3014 (x_session_initialize): Do not assume string length fits in int.
3016 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3017 This is unlikely, but can occur if DPI is outlandish.
3019 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3020 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3022 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3023 * xrdb.c (magic_file_p, search_magic_path):
3024 Omit last arg SUFFIX; it was always 0. All callers changed.
3025 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3027 * xfont.c (xfont_match): Avoid need for strlen.
3029 * xfns.c: Don't assume strlen fits in int.
3030 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3032 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3033 not unsigned long, as we prefer signed integers. All callers changed.
3034 Detect integer overflow in repeat count.
3035 (message_dolog): Don't assume print length fits in 39 bytes.
3036 (display_mode_element): Don't assume strlen fits in int.
3038 * termcap.c: Don't assume sizes fit in int and never overflow.
3039 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3040 (gobble_line): Check for size-calculation overflow.
3042 * minibuf.c (Fread_buffer):
3043 * lread.c (intern, intern_c_string):
3044 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3045 Don't assume string length fits in int.
3047 * keyboard.c (parse_tool_bar_item):
3048 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3050 * font.c: Don't assume string length fits in int.
3051 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3052 Use ptrdiff_t, not int.
3053 (font_intern_prop): Don't assume string length fits in int.
3054 Don't assume integer property fits in fixnum.
3055 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
3057 * filelock.c: Fix some buffer overrun and integer overflow issues.
3058 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
3059 Reformulate so as not to need the command string.
3060 Invoke gzip -cd rather than gunzip, as it's more portable.
3061 (lock_info_type, lock_file_1, lock_file):
3062 Don't assume pid_t and time_t fit in unsigned long.
3063 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3064 (current_lock_owner): Prefer signed type for sizes.
3065 Use memcpy, not strncpy, where memcpy is what is really wanted.
3066 Don't assume (via atoi) that time_t and pid_t fit in int.
3067 Check for time_t and/or pid_t out of range, e.g., via a network share.
3068 Don't alloca where an auto var works fine.
3070 * fileio.c: Fix some integer overflow issues.
3071 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3072 Don't assume string length fits in int.
3073 (directory_file_name): Don't assume string length fits in long.
3074 (make_temp_name): Don't assume pid fits in int, or that its print
3075 length is less than 20.
3077 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3079 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3081 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3083 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3084 We prefer signed integers, even for size calculations.
3086 * emacs.c: Don't assume string length fits in 'int'.
3087 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3088 (main): Don't invoke strlen when not needed.
3090 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3091 (XD_DEBUG_MESSAGE): Don't waste a byte.
3093 * callproc.c (getenv_internal_1, getenv_internal)
3095 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3097 * lread.c (invalid_syntax): Omit length argument.
3098 All uses changed. This doesn't fix a bug, but it simplifies the
3099 code away from its former Hollerith-constant appearance, and it's
3100 one less 'int' to worry about when looking at integer-overflow issues.
3101 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
3103 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3104 This didn't break anything, but it didn't help either.
3105 It's confusing to put a bogus integer in a place where the actual
3106 value does not matter.
3107 (LIST_END_P): Remove unused macro and its bogus comment.
3108 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
3110 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3111 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3113 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3114 We prefer signed types, and the value cannot exceed the EMACS_INT
3115 range anyway (because otherwise the length would not be representable).
3116 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3117 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3118 This avoids a GCC warning when WIDE_EMACS_INT.
3120 * indent.c (sane_tab_width): New function.
3121 (current_column, scan_for_column, Findent_to, position_indentation)
3122 (compute_motion): Use it. This is just for clarity.
3123 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
3125 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
3127 * lisp.h (lint_assume): New macro.
3128 * composite.c (composition_gstring_put_cache):
3129 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3131 * editfns.c, insdel.c:
3132 Omit unnecessary forward decls, to simplify future changes.
3134 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3136 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3138 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
3139 Use much-faster test for byte-length change.
3140 Don't assume string byte-length fits in 'int'.
3141 Check that character arg fits in 'int'.
3142 (mapcar1): Declare byte as byte, for clarity.
3144 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3146 * fns.c (concat): Catch string overflow earlier.
3147 Do not rely on integer wraparound.
3149 * dispextern.h (struct it.overlay_strings_charpos)
3150 (struct it.selective): Now EMACS_INT, not int.
3151 * xdisp.c (forward_to_next_line_start)
3152 (back_to_previous_visible_line_start)
3153 (reseat_at_next_visible_line_start, next_element_from_buffer):
3154 Don't arbitrarily truncate the value of 'selective' to int.
3156 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3158 * composite.c: Don't truncate sizes to 'int'.
3159 (composition_gstring_p, composition_reseat_it)
3160 (composition_adjust_point): Use EMACS_INT, not int.
3161 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3162 not EMACS_UINT, for indexes.
3164 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3166 * buffer.c: Include <verify.h>.
3167 (struct sortvec.priority, struct sortstr.priority):
3168 Now EMACS_INT, not int.
3169 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
3170 (struct sortstr.size, record_overlay_string)
3171 (struct sortstrlist.size, struct sortlist.used):
3172 Don't truncate size to int.
3173 (record_overlay_string): Check for size-calculation overflow.
3174 (init_buffer_once): Check at compile-time, not run-time.
3176 2011-06-22 Jim Meyering <meyering@redhat.com>
3178 Don't leak an XBM-image-sized buffer
3179 * image.c (xbm_load): Free the image buffer after using it.
3181 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3184 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3185 that Sun C diagnosed.
3186 * fns.c (secure_hash): Fix pointer signedness issue.
3187 * intervals.c (static_offset_intervals): New function.
3188 (offset_intervals): Use it.
3190 2011-06-21 Leo Liu <sdl.web@gmail.com>
3193 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3196 * fns.c (secure_hash): Rename from crypto_hash_function and change
3197 the first arg to accept symbols.
3198 (Fsecure_hash): New primitive.
3199 (syms_of_fns): New symbols.
3201 2011-06-20 Deniz Dogan <deniz@dogan.se>
3203 * process.c (Fset_process_buffer): Clarify return value in
3206 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
3208 * dispnew.c (add_window_display_history): Use BVAR.
3210 * xdisp.c (debug_method_add): Use BVAR.
3211 (check_window_end, dump_glyph_matrix, dump_glyph)
3212 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3214 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3217 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3218 check till after the cache is created in init_frame_faces.
3220 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3222 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3224 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3226 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3227 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3228 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3230 Improve buffer-overflow checking (Bug#8873).
3231 * fileio.c (Finsert_file_contents):
3232 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3233 Remove the old (too-loose) buffer overflow checks.
3234 They weren't needed, since make_gap checks for buffer overflow.
3235 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3236 The old code merely checked for Emacs fixnum overflow, and relied
3237 on undefined (wraparound) behavior. The new code avoids undefined
3238 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3240 * editfns.c (Finsert_char): Don't dump core with very negative counts.
3241 Tune. Don't use wider integers than needed. Don't use alloca.
3242 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
3244 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3246 * insdel.c, lisp.h (buffer_overflow): New function.
3247 (insert_from_buffer_1, replace_range, replace_range_2):
3248 * insdel.c (make_gap_larger):
3249 * editfns.c (Finsert_char):
3250 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3252 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3254 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3256 Integer overflow and signedness fixes (Bug#8873).
3258 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3259 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3261 * fileio.c: Don't assume EMACS_INT fits in off_t.
3262 (emacs_lseek): New static function.
3263 (Finsert_file_contents, Fwrite_region): Use it.
3264 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3266 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3268 * fns.c: Don't overflow int when computing a list length.
3269 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3270 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3271 truncation on 64-bit hosts. Check for QUIT every
3272 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3273 faster and is responsive enough.
3274 (Flength): Report an error instead of overflowing an integer.
3275 (Fsafe_length): Return a float if the value is not representable
3276 as a fixnum. This shouldn't happen except in contrived situations.
3277 (Fnthcdr, Fsort): Don't assume list length fits in int.
3278 (Fcopy_sequence): Don't assume vector length fits in int.
3280 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3281 (header_size, word_size): New constants.
3282 (allocate_vectorlike): Don't check size overflow here.
3283 (allocate_vector): Check it here instead, since this is the only
3284 caller of allocate_vectorlike that could cause overflow.
3285 Check that the new vector's length is representable as a fixnum.
3287 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3288 The previous code was bogus. For example, next_almost_prime (32)
3289 returned 39, which is undesirable as it is a multiple of 3; and
3290 next_almost_prime (24) returned 25, which is a multiple of 5 so
3291 why was the code bothering to check for multiples of 7?
3293 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3295 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3297 Variadic C functions now count arguments with ptrdiff_t.
3298 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3299 Back then I didn't know that the Emacs coding style prefers signed int.
3300 Also, in the meantime I found a few more instances where arguments
3301 were being counted with int, which may truncate counts on 64-bit
3302 machines, or EMACS_INT, which may be unnecessarily wide.
3303 * lisp.h (struct Lisp_Subr.function.aMANY)
3304 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3305 Arg counts are now ptrdiff_t, not size_t.
3306 All variadic functions and their callers changed accordingly.
3307 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3308 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3309 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3310 * callint.c (Fcall_interactively): Check arg count for overflow,
3311 to avoid potential buffer overrun. Use signed char, not 'int',
3312 for 'varies' array, so that we needn't bother to check its size
3313 calculation for overflow.
3314 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3315 * eval.c (apply_lambda):
3316 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3317 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3318 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3320 * callint.c (Fcall_interactively): Don't use index var as event count.
3322 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3323 * mem-limits.h (SIZE): Remove; no longer used.
3325 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
3327 Remove unnecessary casts.
3328 * xterm.c (x_term_init):
3329 * xfns.c (x_set_border_pixel):
3330 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3331 These aren't needed now that we assume ANSI C.
3333 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3334 It's more likely to cause problems (due to unsigned overflow)
3337 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3339 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3341 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3343 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3345 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3347 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3349 GLYPH_CODE_FACE returns EMACS_INT, not int.
3350 * dispextern.h (merge_faces):
3351 * xfaces.c (merge_faces):
3352 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3353 Don't assume EMACS_INT fits in int.
3355 * character.h (CHAR_VALID_P): Remove unused parameter.
3356 * fontset.c, lisp.h, xdisp.c: All uses changed.
3358 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3360 * fns.c (concat): Minor tuning based on overflow analysis.
3361 This doesn't fix any bugs. Use int to hold character, instead
3362 of constantly refetching from Emacs object. Use XFASTINT, not
3363 XINT, for value known to be a character. Don't bother comparing
3364 a single byte to 0400, as it's always less.
3366 * floatfns.c (Fexpt):
3367 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3369 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3372 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3374 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3375 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3376 incorrectly succeed when S was a string, because 4294967386 was
3377 truncated before it was used.
3379 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3380 Otherwise, an out-of-range integer could cause undefined behavior
3383 * composite.c: Use int, not EMACS_INT, for characters.
3384 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3385 EMACS_INT, for values that are known to be in character range.
3386 This doesn't fix any bugs but is the usual style inside Emacs and
3387 may generate better code on 32-bit machines.
3389 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3390 This is for reasons similar to the recent CHAR_STRING fix.
3391 * charset.c (Fencode_char): Check that character arg is actually
3392 a character. Pass an int to ENCODE_CHAR.
3393 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3394 wider than 'int', as a compile-time check to prevent future regressions
3397 * character.c (char_string): Remove unnecessary casts.
3399 Make sure a 64-bit char is never passed to CHAR_STRING.
3400 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3401 by silently ignoring the top 32 bits, allowing some values
3402 that were far too large to be valid characters.
3403 * character.h: Include <verify.h>.
3404 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3405 arguments are no wider than unsigned, as a compile-time check
3406 to prevent future regressions in this area.
3408 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
3409 (Fsubst_char_in_region):
3411 * xdisp.c (decode_mode_spec_coding):
3412 Adjust to CHAR_STRING's new requirement.
3413 * editfns.c (Finsert_char, Fsubst_char_in_region):
3414 * fns.c (concat): Check that character args are actually
3415 characters. Without this test, these functions did the wrong
3416 thing with wildly out-of-range values on 64-bit hosts.
3418 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3419 These casts should not be needed on 32-bit hosts, either.
3420 * keyboard.c (read_char):
3421 * lread.c (Fload): Remove casts to unsigned.
3423 * lisp.h (UNSIGNED_CMP): New macro.
3424 This fixes comparison bugs on 64-bit hosts.
3425 (ASCII_CHAR_P): Use it.
3426 * casefiddle.c (casify_object):
3427 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
3428 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3429 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3430 * dispextern.h (FACE_FROM_ID):
3431 * keyboard.c (read_char): Use UNSIGNED_CMP.
3433 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3434 not to EMACS_INT, to avoid GCC warning.
3436 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3438 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3439 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3440 isn't needed on 32-bit machines.
3442 * buffer.c (Fgenerate_new_buffer_name):
3443 Use EMACS_INT for count, not int.
3444 (advance_to_char_boundary): Return EMACS_INT, not int.
3446 * data.c (Qcompiled_function): Now static.
3448 * window.c (window_body_lines): Now static.
3450 * image.c (gif_load): Rename local to avoid shadowing.
3452 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3453 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3454 * alloc.c (make_save_value): Integer argument is now of type
3456 (mark_object): Use ptrdiff_t, not int.
3457 * lisp.h (pD): New macro.
3458 * print.c (print_object): Use it.
3460 * alloc.c: Use EMACS_INT, not int, to count objects.
3461 (total_conses, total_markers, total_symbols, total_vector_size)
3462 (total_free_conses, total_free_markers, total_free_symbols)
3463 (total_free_floats, total_floats, total_free_intervals)
3464 (total_intervals, total_strings, total_free_strings):
3465 Now EMACS_INT, not int. All uses changed.
3466 (Fgarbage_collect): Compute overall total using a double, so that
3467 integer overflow is less likely to be a problem. Check for overflow
3468 when converting back to an integer.
3469 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3470 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3471 These were 'int' variables that could overflow on 64-bit hosts;
3472 they were never used, so remove them instead of repairing them.
3473 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
3474 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3475 Previously, this ceilinged at INT_MAX, but that doesn't work on
3477 (allocate_pseudovector): Don't use EMACS_INT when int would do.
3479 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
3480 (allocate_vectorlike): Check for ptrdiff_t overflow.
3481 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3482 when a (possibly-narrower) signed value would do just as well.
3483 We prefer using signed arithmetic, to avoid comparison confusion.
3485 * alloc.c: Catch some string size overflows that we were missing.
3486 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3487 for convenience in STRING_BYTES_MAX.
3488 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3489 The definition here is exact; the one in lisp.h was approximate.
3490 (allocate_string_data): Check for string overflow. This catches
3491 some instances we weren't catching before. Also, it catches
3492 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3493 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3494 and ptrdiff_t and EMACS_INT are both 64 bits.
3496 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3497 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
3498 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
3500 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3502 * alloc.c (Fmake_string): Check for out-of-range init.
3504 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3506 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3508 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3510 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3511 xg_get_default_scrollbar_width.
3513 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3514 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3515 (style_changed_cb): Call update_theme_scrollbar_width and call
3516 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3517 all frames (Bug#8505).
3518 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3519 Call gtk_window_set_resizable if HAVE_GTK3.
3520 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3521 and height if HAVE_GTK3 (Bug#8505).
3522 (scroll_bar_width_for_theme): New variable.
3523 (update_theme_scrollbar_width): New function.
3524 (xg_get_default_scrollbar_width): Move code to
3525 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3526 (xg_initialize): Call update_theme_scrollbar_width.
3528 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3530 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3532 2011-06-12 Martin Rudalics <rudalics@gmx.at>
3534 * frame.c (make_frame): Call other_buffer_safely instead of
3537 * window.c (temp_output_buffer_show): Call display_buffer with
3538 second argument Vtemp_buffer_show_specifiers and reset latter
3539 immediately after the call.
3540 (Vtemp_buffer_show_specifiers): New variable.
3541 (auto_window_vscroll_p, next_screen_context_lines)
3542 (Vscroll_preserve_screen_position): Remove leading asterisks from
3545 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
3547 Fix minor problems found by GCC 4.6.0 static checking.
3548 * buffer.c (Qclone_number): Remove for now, as it's unused.
3549 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3550 (record_buffer): Remove unused local.
3551 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3552 (set_frame_buffer_list): Remove; unused.
3553 * frame.h (other_visible_frames): Remove decl.
3554 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3555 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3556 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3558 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3559 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3560 Define only if HAVE_GPM.
3561 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3562 (update_hints_inhibit): Remove; never set. All uses removed.
3563 * widgetprv.h (emacsFrameClassRec): Remove decl.
3564 * window.c (delete_deletable_window): Now returns void, since it
3565 wasn't returning anything.
3566 (compare_window_configurations): Remove unused locals.
3567 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3568 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
3569 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3570 the same widths as pointers. This follows up on the 2011-05-06 patch.
3571 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3572 * xterm.h: Likewise.
3573 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3575 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
3577 * makefile.w32-in: Update dependencies.
3578 (LISP_H): Add lib/intprops.h.
3580 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3582 * image.c (gif_load): Add animation frame delay to the metadata.
3583 (syms_of_image): Use DEFSYM. New symbol `delay'.
3585 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3587 * window.c (delete_deletable_window): Re-add.
3588 (Fset_window_configuration): Rewrite to handle dead buffers and
3589 consequently deletable windows.
3590 (window_tree, Fwindow_tree): Remove. Supply functionality in
3592 (compare_window_configurations): Simplify code.
3594 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3596 * image.c (imagemagick_load_image): Fix type mismatch.
3597 (Fimagemagick_types): Likewise.
3599 * window.h (replace_buffer_in_windows): Declare.
3601 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3603 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3604 Qclone_number. Remove external declaration of Qdelete_window.
3605 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3607 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3608 Run Qbuffer_list_update_hook if allowed.
3609 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3610 buffer list implementation.
3611 (other_buffer_safely): New function.
3612 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3613 calls to replace_buffer_in_windows and
3614 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3616 (record_buffer): Inhibit quitting and rewrite using quittable
3617 functions. Run Qbuffer_list_update_hook if allowed.
3618 (Frecord_buffer, Funrecord_buffer): New functions.
3619 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3620 Move switch-to-buffer to window.el.
3621 (bury-buffer): Move to window.el.
3622 (Vbuffer_list_update_hook): New variable.
3624 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3627 * window.h (resize_frame_windows): Move up in code.
3628 (Fwindow_frame): Remove EXFUN.
3629 (replace_buffer_in_all_windows): Remove prototype.
3630 (replace_buffer_in_windows_safely): Add prototype.
3632 * window.c: Declare Qdelete_window static again. Move down
3633 declaration of select_count.
3634 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3635 (Fother_window): Move to window.el.
3636 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3637 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3638 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3640 (replace_buffer_in_windows): Implement by calling
3641 Qreplace_buffer_in_windows.
3642 (replace_buffer_in_all_windows): Remove with some functionality
3643 moved into replace_buffer_in_windows_safely.
3644 (replace_buffer_in_windows_safely): New function.
3645 (select_window_norecord, select_frame_norecord): Move in front
3646 of run_window_configuration_change_hook. Remove now obsolete
3648 (Fset_window_buffer): Rewrite doc-string.
3649 Call Qrecord_window_buffer.
3650 (keys_of_window): Move binding for other-window to window.el.
3652 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3654 * dispextern.h (struct image): Replace data member, whose int_val
3655 and ptr_val fields were not used by anything, with a single
3658 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3659 (gif_clear_image, gif_load, imagemagick_load_image)
3660 (gs_clear_image, gs_load): Callers changed.
3662 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3664 * buffer.h: Include <time.h>, for time_t.
3665 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3667 Fix minor problems found by static checking.
3669 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3671 Make identifiers static if they are not used in other modules.
3672 * data.c (Qcompiled_function, Qframe, Qvector):
3673 * image.c (QimageMagick, Qsvg):
3674 * minibuf.c (Qmetadata):
3675 * window.c (resize_window_check, resize_root_window): Now static.
3676 * window.h (resize_window_check, resize_root_window): Remove decls.
3678 * window.c (window_deletion_count, delete_deletable_window):
3680 (window_body_lines): Now static.
3681 (Fdelete_other_windows_internal): Mark vars as initialized.
3682 Make sure 'resize_failed' is initialized.
3683 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3684 (resize_window_apply): Remove unused local.
3685 * window.h (delete_deletable_window): Remove decl.
3687 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
3688 (imagemagick_load_image): Fix pointer signedness problem by changing
3689 last arg from unsigned char * to char *. All uses changed.
3690 Also, fix a local for similar reasons.
3691 Remove unused locals. Remove locals to avoid shadowing.
3692 (fn_rsvg_handle_free): Remove; unused.
3693 (svg_load, svg_load_image): Fix pointer signedness problem.
3694 (imagemagick_load_image): Don't use garbage pointer image_wand.
3696 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3698 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
3700 * image.c (gif_load): Fix omitted cast error introduced by
3703 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3705 * window.h (resize_proportionally, orig_total_lines)
3706 (orig_top_line): Remove from window structure.
3707 (set_window_height, set_window_width, change_window_heights)
3708 (Fdelete_window): Remove prototypes.
3709 (resize_frame_windows): Remove duplicate declaration.
3711 2011-06-10 Eli Zaretskii <eliz@gnu.org>
3713 * window.h (resize_frame_windows, resize_window_check)
3714 (delete_deletable_window, resize_root_window)
3715 (resize_frame_windows): Declare prototypes.
3717 * window.c (resize_window_apply): Make definition be "static" to
3718 match the prototype.
3720 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3722 * window.c: Remove declarations of Qwindow_size_fixed,
3723 window_min_size_1, window_min_size_2, window_min_size,
3724 size_window, window_fixed_size_p, enlarge_window, delete_window.
3725 Remove static from declaration of Qdelete_window, it's
3726 temporarily needed by Fbury_buffer.
3727 (replace_window): Don't assign orig_top_line and
3729 (Fdelete_window, delete_window): Remove. Window deletion is
3730 handled by window.el.
3731 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3732 Replace Fdelete_window calls with calls to Qdelete_window.
3733 (Fdelete_other_windows): Remove. Deleting other windows is
3734 handled by window.el.
3735 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3736 handled in window.el.
3737 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3738 Window minimum sizes are handled in window.el.
3739 (shrink_windows, size_window, set_window_height)
3740 (set_window_width, change_window_heights, window_height)
3741 (window_width, CURBEG, CURSIZE, enlarge_window)
3742 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3743 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3744 handled in window.el.
3745 (make_dummy_parent): Rename to make_parent_window and give it a
3746 second argument horflag.
3747 (make_window): Don't set resize_proportionally any more.
3748 (Fsplit_window): Remove. Windows are split in window.el.
3749 (save_restore_action, save_restore_orig_size)
3750 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3751 Resize mini windows in window.el.
3752 (grow_mini_window, shrink_mini_window): Implement by calling
3753 Qresize_root_window_vertically, resize_window_check and
3754 resize_window_apply.
3755 (saved_window, Fset_window_configuration, save_window_save):
3756 Do not handle orig_top_line, orig_total_lines, and
3757 resize_proportionally.
3758 (window_min_height, window_min_width): Move to window.el.
3759 (keys_of_window): Move bindings for delete-other-windows,
3760 split-window, delete-window and enlarge-window to window.el.
3762 * buffer.c: Temporarily extern Qdelete_window.
3763 (Fbury_buffer): Temporarily call Qdelete_window instead of
3764 Fdelete_window (Fbury_buffer will move to window.el soon).
3766 * frame.c (set_menu_bar_lines_1): Remove code handling
3767 orig_top_line and orig_total_lines.
3769 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3770 set_window_height but set heights directly.
3771 (change_frame_size_1): Use resize_frame_windows.
3773 * xdisp.c (init_xdisp): Don't use set_window_height but set
3776 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3777 Use resize_frame_windows instead of change_window_heights and run
3778 run_window_configuration_change_hook.
3780 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3781 instead of change_window_heights and run
3782 run_window_configuration_change_hook.
3784 2011-06-09 Martin Rudalics <rudalics@gmx.at>
3786 * window.c (replace_window): Rename second argument REPLACEMENT to
3787 NEW. New third argument SETFLAG. Rewrite.
3788 (delete_window, make_dummy_parent): Call replace_window with
3790 (window_list_1): Move down in code.
3791 (run_window_configuration_change_hook): Move set_buffer part
3792 before select_frame_norecord part in order to unwind correctly.
3793 Rename count1 to count.
3794 (recombine_windows, delete_deletable_window, resize_root_window)
3795 (Fdelete_other_windows_internal)
3796 (Frun_window_configuration_change_hook, make_parent_window)
3797 (resize_window_check, resize_window_apply, Fresize_window_apply)
3798 (resize_frame_windows, Fsplit_window_internal)
3799 (Fdelete_window_internal, Fresize_mini_window_internal):
3801 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3803 2011-06-08 Martin Rudalics <rudalics@gmx.at>
3805 * window.h (window): Add some new members to window structure -
3806 normal_lines, normal_cols, new_total, new_normal, clone_number,
3807 splits, nest, prev_buffers, next_buffers.
3808 (WINDOW_TOTAL_SIZE): Move here from window.c.
3809 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
3811 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3813 (make_dummy_parent): Set new members of windows structure.
3814 (make_window): Move down in code. Handle new members of window
3816 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3817 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3818 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3819 (Fset_window_prev_buffers, Fwindow_next_buffers)
3820 (Fset_window_next_buffers, Fset_window_clone_number):
3822 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3823 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3825 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3826 Argument WINDOW can be now internal window too.
3827 (Fwindow_use_time): Move up in code.
3828 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3830 (Fset_window_configuration, saved_window)
3831 (Fcurrent_window_configuration, save_window_save): Handle new
3832 members of window structure.
3833 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3834 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3835 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3836 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3837 Qget_mru_window, Qresize_root_window,
3838 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3839 Qauto_buffer_name; staticpro them.
3841 2011-06-07 Martin Rudalics <rudalics@gmx.at>
3843 * window.c (Fwindow_total_size, Fwindow_left_column)
3844 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3845 (Fwindow_list_1): New functions.
3846 (window_box_text_cols): Replace with window_body_cols.
3847 (Fwindow_width, Fscroll_left, Fscroll_right):
3848 Use window_body_cols instead of window_box_text_cols.
3849 (delete_window, Fset_window_configuration):
3850 Call delete_all_subwindows with window as argument.
3851 (delete_all_subwindows): Take a window as argument and not a
3853 (window_loop): Remove handling of GET_LRU_WINDOW and
3855 (Fget_lru_window, Fget_largest_window): Move to window.el.
3857 * window.h: Extern window_body_cols instead of
3858 window_box_text_cols. delete_all_subwindows now takes a
3859 Lisp_Object as argument.
3861 * indent.c (compute_motion, Fcompute_motion):
3862 Use window_body_cols instead of window_box_text_cols.
3864 * frame.c (delete_frame): Call delete_all_subwindows with root
3867 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3869 * fns.c (Fputhash): Document return value.
3871 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
3873 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3875 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3877 Cons<->int and similar integer overflow fixes (Bug#8794).
3879 Check for overflow when converting integer to cons and back.
3880 * charset.c (Fdefine_charset_internal, Fdecode_char):
3881 Use cons_to_unsigned to catch overflow.
3882 (Fencode_char): Use INTEGER_TO_CONS.
3883 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3884 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3885 * data.c (long_to_cons, cons_to_long): Remove.
3886 (cons_to_unsigned, cons_to_signed): New functions.
3887 These signal an error for invalid or out-of-range values.
3888 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3889 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3890 * font.c (Ffont_variation_glyphs):
3891 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3892 * lisp.h: Include <intprops.h>.
3893 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3894 (cons_to_signed, cons_to_unsigned): New decls.
3895 (long_to_cons, cons_to_long): Remove decls.
3896 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3897 (Fprimitive_undo): Use CONS_TO_INTEGER.
3898 * xfns.c (Fx_window_property): Likewise.
3899 * xselect.c: Include <limits.h>.
3900 (x_own_selection, selection_data_to_lisp_data):
3901 Use INTEGER_TO_CONS.
3902 (x_handle_selection_request, x_handle_selection_clear)
3903 (x_get_foreign_selection, Fx_disown_selection_internal)
3904 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3905 (lisp_data_to_selection_data): Use cons_to_unsigned.
3906 (x_fill_property_data): Use cons_to_signed.
3907 Report values out of range.
3909 Check for buffer and string overflow more precisely.
3910 * buffer.h (BUF_BYTES_MAX): New macro.
3911 * lisp.h (STRING_BYTES_MAX): New macro.
3912 * alloc.c (Fmake_string):
3913 * character.c (string_escape_byte8):
3914 * coding.c (coding_alloc_by_realloc):
3915 * doprnt.c (doprnt):
3916 * editfns.c (Fformat):
3918 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3919 since they may not be the same number.
3920 * editfns.c (Finsert_char):
3921 * fileio.c (Finsert_file_contents):
3922 Likewise for BUF_BYTES_MAX.
3924 * image.c: Use ptrdiff_t, not int, for sizes.
3925 (slurp_file): Switch from int to ptrdiff_t.
3927 (slurp_file): Check that file size fits in both size_t (for
3928 malloc) and ptrdiff_t (for sanity and safety).
3930 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3931 if b->modtime has its maximal value.
3933 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3935 Don't assume time_t can fit into int.
3936 * buffer.h (struct buffer.modtime): Now time_t, not int.
3937 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3938 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3940 Minor fixes for signed vs unsigned integers.
3941 * character.h (MAYBE_UNIFY_CHAR):
3942 * charset.c (maybe_unify_char):
3943 * keyboard.c (read_char, reorder_modifiers):
3944 XINT -> XFASTINT, since the integer must be nonnegative.
3945 * ftfont.c (ftfont_spec_pattern):
3946 * keymap.c (access_keymap, silly_event_symbol_error):
3947 XUINT -> XFASTINT, since the integer must be nonnegative.
3948 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3949 since it makes no difference and we prefer signed.
3950 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3951 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3954 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3956 * window.h (Fwindow_frame): Declare.
3958 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3960 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3961 (SPARE_MEMORY): Always define.
3962 (LARGE_REQUEST): Remove.
3963 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3965 2011-06-06 Martin Rudalics <rudalics@gmx.at>
3967 * lisp.h: Move EXFUNS for Fframe_root_window,
3968 Fframe_first_window and Fset_frame_selected_window to window.h.
3970 * window.h: Move EXFUNS for Fframe_root_window,
3971 Fframe_first_window and Fset_frame_selected_window here from
3974 * frame.c (Fwindow_frame, Fframe_first_window)
3975 (Fframe_root_window, Fframe_selected_window)
3976 (Fset_frame_selected_window): Move to window.c.
3977 (Factive_minibuffer_window): Move to minibuf.c.
3978 (Fother_visible_frames_p): New function.
3980 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3982 * window.c (decode_window, decode_any_window): Move up in code.
3983 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3984 (inhibit_frame_unsplittable): Remove unused variable.
3985 (Fwindow_buffer): Move up and rewrite doc-string.
3986 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3987 (Fwindow_prev): New functions.
3988 (Fwindow_frame): Move here from frame.c. Accept any window as
3990 (Fframe_root_window, Fframe_first_window)
3991 (Fframe_selected_window): Move here from frame.c. Accept frame
3992 or arbitrary window as argument. Update doc-strings.
3993 (Fminibuffer_window): Move up in code.
3994 (Fwindow_minibuffer_p): Move up in code and simplify.
3995 (Fset_frame_selected_window): Move here from frame.c.
3997 (Fselected_window, select_window, Fselect_window): Move up in
3998 code. Minor doc-string fixes.
4000 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4002 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4003 Do not assume that spare memory exists; that assumption is valid
4004 only if SYSTEM_MALLOC.
4005 (LARGE_REQUEST): New macro, so that the issue of large requests
4006 is separated from the issue of spare memory.
4008 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4010 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4013 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4015 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4018 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4020 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4022 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4024 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4025 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4027 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
4029 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4031 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
4033 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4034 (x_clipboard_manager_save): Add return value.
4035 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4037 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4038 Obey Vx_select_enable_clipboard_manager. Catch errors in
4039 x_clipboard_manager_save (Bug#8779).
4040 (Vx_select_enable_clipboard_manager): New variable.
4041 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4043 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
4045 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4047 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4049 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4050 in the current matrix if keep_current_p is non-zero.
4052 2011-06-04 Eli Zaretskii <eliz@gnu.org>
4054 * bidi.c (bidi_level_of_next_char): Fix last change.
4056 2011-06-03 Eli Zaretskii <eliz@gnu.org>
4058 Support bidi reordering of text covered by display properties.
4060 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4061 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4062 (bidi_cache_search, bidi_cache_iterator_state)
4063 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
4064 (bidi_level_of_next_char, bidi_move_to_visually_next):
4065 Support character positions inside a run of characters covered by a
4067 (bidi_paragraph_init, bidi_resolve_explicit_1)
4068 (bidi_level_of_next_char): Call bidi_fetch_char and
4069 bidi_fetch_char_advance instead of FETCH_CHAR and
4071 (bidi_init_it): Initialize new members.
4072 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4074 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4075 instead of using explicit *_CHAR codes.
4076 (bidi_resolve_explicit, bidi_resolve_weak):
4077 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
4078 bidirectional text is supported only in multibyte buffers.
4079 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4080 it to initialize the frame_window_p member of struct bidi_it.
4081 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4082 (bidi_resolve_explicit, bidi_resolve_weak)
4083 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4084 bidi_it->nchars is non-positive.
4085 (bidi_level_of_next_char): Don't try to lookup the cache for the
4086 next/previous character if nothing is cached there yet, or if we
4087 were just reseat()'ed to a new position.
4089 * xdisp.c (set_cursor_from_row): Set start and stop points
4090 according to the row's direction when priming the loop that looks
4091 for the glyph on which to display cursor.
4092 (single_display_spec_intangible_p): Function deleted.
4093 (display_prop_intangible_p): Reimplement to call
4094 handle_display_spec instead of single_display_spec_intangible_p.
4095 Accept 3 additional arguments needed by handle_display_spec.
4096 This fixes incorrect cursor motion across display property with complex
4097 values: lists, `(when COND...)' forms, etc.
4098 (single_display_spec_string_p): Support property values that are
4099 lists with the argument STRING its top-level element.
4100 (display_prop_string_p): Fix the condition for processing a
4101 property that is a list to be consistent with handle_display_spec.
4102 (handle_display_spec): New function, refactored from the
4103 last portion of handle_display_prop.
4104 (compute_display_string_pos): Accept additional argument
4105 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4106 value of a `display' property is a "replacing spec".
4107 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4108 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4109 the display property, but just return a value indicating whether
4110 the display property will replace the characters it covers.
4111 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4112 frame_window_p members of struct bidi_it.
4113 (compute_display_string_pos, compute_display_string_end):
4115 (push_it): Accept second argument POSITION, where pop_it should
4116 jump to continue iteration.
4117 (reseat_1): Initialize bidi_it.disp_pos.
4119 * keyboard.c (adjust_point_for_property): Adjust the call to
4120 display_prop_intangible_p to its new signature.
4122 * dispextern.h (struct bidi_it): New member frame_window_p.
4123 (bidi_init_it): Update prototypes.
4124 (display_prop_intangible_p): Update prototype.
4125 (compute_display_string_pos, compute_display_string_end):
4127 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4130 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
4132 Malloc failure behavior now depends on size of allocation.
4133 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4134 * lisp.h: Change signatures accordingly.
4135 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4136 All callers changed. (Bug#8762)
4138 * gnutls.c: Use Emacs's memory allocators.
4139 Without this change, the gnutls library would invoke malloc etc.
4140 directly, which causes problems on non-SYNC_INPUT hosts, and which
4141 runs afoul of improving memory_full behavior. (Bug#8761)
4142 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4143 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4144 xfree instead of the default malloc, realloc, free.
4145 (Fgnutls_boot): No need to check for memory allocation failure,
4146 since xmalloc does that for us.
4148 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
4149 * category.c (hash_get_category_set):
4150 * ccl.c (ccl_driver):
4151 * charset.c (Fdefine_charset_internal):
4152 * charset.h (struct charset.hash_index):
4153 * composite.c (get_composition_id, gstring_lookup_cache)
4154 (composition_gstring_put_cache):
4155 * composite.h (struct composition.hash_index):
4156 * dispextern.h (struct image.hash):
4157 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4158 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4159 (hashfn_equal, hashfn_user_defined, make_hash_table)
4160 (maybe_resize_hash_table, hash_lookup, hash_put)
4161 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4162 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4163 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4164 * image.c (make_image, search_image_cache, lookup_image)
4165 (xpm_put_color_table_h):
4166 * lisp.h (struct Lisp_Hash_Table):
4167 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
4168 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
4169 for hashes and hash indexes, instead of 'unsigned' and 'int'.
4170 * alloc.c (allocate_vectorlike):
4171 Check for overflow in vector size calculations.
4172 * ccl.c (ccl_driver):
4173 Check for overflow when converting EMACS_INT to int.
4174 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4175 need to be updated by these changes.
4176 * fns.c (make_hash_table, maybe_resize_hash_table):
4177 Check for integer overflow with large hash tables.
4178 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4179 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4180 (SXHASH_REDUCE): New macro.
4181 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4182 Use it instead of discarding useful hash info with large hash values.
4183 (sxhash_float): New function.
4184 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4185 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
4186 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4187 Rewrite to use FIXNUM_BITS, as this simplifies things.
4188 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4189 Adjust signatures to match updated version of code.
4190 (consing_since_gc): Now EMACS_INT, since a single hash table can
4191 use more than INT_MAX bytes.
4193 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4195 Make it possible to build with GCC-4.6+ -O2 -flto.
4197 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4199 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4201 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4202 Call minibuffer-inactive-mode.
4204 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
4206 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4207 Update dependencies.
4209 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4211 * data.c (init_data): Remove code for UTS, this system is not
4214 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4216 Don't force ./temacs to start in terminal mode.
4218 * frame.c (make_initial_frame): Initialize faces in all cases, not
4219 only when CANNOT_DUMP is defined.
4220 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4222 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4224 * dispnew.c (add_window_display_history): Use const for the string
4225 pointer. Remove declaration, not needed.
4227 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4229 Use 'inline', not 'INLINE'.
4230 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
4231 * alloc.c, fontset.c (INLINE): Remove.
4232 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4233 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4234 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4235 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4236 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4238 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4240 Make it possible to run ./temacs.
4242 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4243 syms_of_callproc does the same thing. Remove test for
4244 "initialized", do it in the caller.
4245 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4247 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4249 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4250 (read_minibuf): Use get_minibuffer.
4251 (syms_of_minibuf): Use DEFSYM.
4252 (Qmetadata): New var.
4253 * data.c (Qbuffer): Don't make it static.
4254 (syms_of_data): Use DEFSYM.
4256 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4258 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4259 (CCL_CODE_MIN): New macro.
4261 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4263 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4265 * eval.c (Qdebug): Now static.
4266 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4267 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4268 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4270 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4272 * image.c: Various fixes to ImageMagick code comments.
4273 (Fimagemagick_types): Doc fix.
4275 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4277 Minor fixes prompted by GCC 4.6.0 warnings.
4279 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4281 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4282 (x_clipboard_manager_save_all): Move extern decl to ...
4283 * xterm.h: ... here, so that it can be checked for consistency.
4285 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4287 * xselect.c (x_clipboard_manager_save_frame)
4288 (x_clipboard_manager_save_all): New functions.
4289 (Fx_clipboard_manager_save): Lisp function deleted.
4291 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4292 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4294 * xterm.h: Update prototype.
4296 2011-05-28 William Xu <william.xwl@gmail.com>
4298 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4301 2011-05-28 Jim Meyering <meyering@redhat.com>
4303 Avoid a sign-extension bug in crypto_hash_function.
4304 * fns.c (to_uchar): Define.
4305 (crypto_hash_function): Use it to convert some newly-signed
4306 variables to unsigned, to avoid sign-extension bugs. For example,
4307 without this change, (md5 "truc") would evaluate to
4308 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4309 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
4310 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
4312 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4314 Integer overflow fixes.
4316 * dbusbind.c: Serial number integer overflow fixes.
4317 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
4318 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4319 to hold a serial number that is too large for a fixnum.
4320 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4321 Check for serial numbers out of range. Decode any serial number
4322 that was so large that it became a float. (Bug#8722)
4324 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4325 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4326 Use XFASTINT rather than XUINT when numbers are nonnegative.
4327 (xd_append_arg, Fdbus_method_return_internal):
4328 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4329 arguments, check that Lisp number is nonnegative, rather than
4330 silently wrapping negative numbers around. (Bug#8722)
4331 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
4334 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4336 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4338 ccl: add integer overflow checks
4339 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4340 (IN_INT_RANGE): New macros.
4341 (ccl_driver): Use them to check for integer overflow when
4342 decoding a CCL program. Many of the new checks are whether XINT (x)
4343 fits in int; it doesn't always, on 64-bit hosts. The new version
4344 doesn't catch all possible integer overflows, but it's an
4345 improvement. (Bug#8719)
4347 * alloc.c (make_event_array): Use XINT, not XUINT.
4348 There's no need for unsigned here.
4350 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4351 This follows up to the 2011-05-06 change that substituted uintptr_t
4352 for EMACS_INT. This case wasn't caught back then.
4354 Rework Fformat to avoid integer overflow issues.
4355 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4356 now (part of C89). Include <verify.h>.
4357 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4358 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4359 (Fformat): Avoid the prepass trying to compute sizes; it was only
4360 approximate and thus did not catch overflow reliably. Instead, walk
4361 through the format just once, formatting and computing sizes as we go,
4362 checking for integer overflow at every step, and allocating a larger
4363 buffer as needed. Keep track separately whether the format is
4364 multibyte. Keep only the most-recently calculated precision, rather
4365 than them all. Record whether each argument has been converted to
4366 string. Use EMACS_INT, not int, for byte and char and arg counts.
4367 Support field widths and precisions larger than INT_MAX. Avoid
4368 sprintf's undefined behavior with conversion specifications such as %#d
4369 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4370 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4371 formatting out-of-range floating point numbers with int
4374 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4376 * data.c: Avoid integer truncation in expressions involving floats.
4377 * data.c: Include <intprops.h>.
4378 (arith_driver): When there's an integer overflow in an expression
4379 involving floating point, convert the integers to floating point
4380 so that the resulting value does not suffer from catastrophic
4381 integer truncation. For example, on a 64-bit host (* 4
4382 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4383 Do not rely on undefined behavior after integer overflow.
4385 merge count_size_as_multibyte, parse_str_to_multibyte
4386 * character.c, character.h (count_size_as_multibyte):
4387 Rename from parse_str_to_multibyte; all uses changed.
4388 Check for integer overflow.
4389 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4390 since it's now a duplicate of the other. This is more of
4391 a character than a buffer op, so better that it's in character.c.
4392 * fns.c, print.c: Adjust to above changes.
4394 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4396 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4398 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4400 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4401 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4402 (x_clipboard_manager_save): Now static.
4403 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4405 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4406 (crypto_hash_function): Now static.
4407 Fix pointer signedness problems. Avoid unnecessary initializations.
4409 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
4411 * termhooks.h (Vselection_alist): Make it terminal-local.
4413 * terminal.c (create_terminal): Initialize it.
4415 * xselect.c: Support for clipboard managers.
4416 (Vselection_alist): Move to termhooks.h as terminal-local var.
4417 (LOCAL_SELECTION): New macro.
4418 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4419 (symbol_to_x_atom): Remove gratuitous arg.
4420 (x_handle_selection_request, lisp_data_to_selection_data)
4421 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
4422 (x_own_selection, x_get_local_selection, x_convert_selection):
4423 New arg, specifying work frame. Use terminal-local Vselection_alist.
4424 (some_frame_on_display): Delete unused function.
4425 (Fx_own_selection_internal, Fx_get_selection_internal)
4426 (Fx_disown_selection_internal, Fx_selection_owner_p)
4427 (Fx_selection_exists_p): New optional frame arg.
4428 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4429 (x_handle_selection_clear): Don't treat other terminals with the
4430 same keyboard specially. Use the terminal-local Vselection_alist.
4431 (x_clear_frame_selections): Use Frun_hook_with_args.
4433 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4435 * xterm.h: Add support for those atoms.
4437 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
4439 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4440 (converted_selections, conversion_fail_tag): New global variables.
4441 (x_selection_request_lisp_error): Free the above.
4442 (x_get_local_selection): Remove unnecessary code.
4443 (x_reply_selection_request): Args changed; handle arbitrary array
4444 of converted selections stored in converted_selections.
4445 Separate the XChangeProperty and SelectionNotify steps.
4446 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4447 (x_convert_selection): New function.
4448 (x_handle_selection_event): Simplify.
4449 (x_get_foreign_selection): Don't ignore incoming requests while
4450 waiting for an answer; this will fail when we implement
4451 SAVE_TARGETS, and seems unnecessary anyway.
4452 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4453 (Vx_sent_selection_functions): Doc fix.
4455 2011-05-26 Leo Liu <sdl.web@gmail.com>
4457 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4459 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4461 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4463 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4464 for fringe update if it has periodic bitmap.
4465 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
4466 and fringe_bitmap_periodic_p.
4468 * fringe.c (get_fringe_bitmap_data): New function.
4469 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4470 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4471 row. Mark glyph row for fringe update if periodicity changed.
4473 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4474 for fringe update unless it has periodic bitmap.
4476 2011-05-25 Kenichi Handa <handa@m17n.org>
4478 * xdisp.c (get_next_display_element): Set correct it->face_id for
4479 a static composition.
4481 2011-05-24 Leo Liu <sdl.web@gmail.com>
4484 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4486 * fns.c (crypto_hash_function, Fsha1): New function.
4487 (Fmd5): Use crypto_hash_function.
4488 (syms_of_fns): Add Ssha1.
4490 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4492 * gnutls.c: Remove unused macros.
4493 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4494 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4495 Remove macros that are defined and never used.
4496 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4498 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4500 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4501 (Fx_get_selection_internal): Minor cleanup.
4502 (Fx_own_selection_internal): Rename arguments for consistency with
4505 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4507 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4509 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4511 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4513 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4515 * dispnew.c (scrolling_window): Don't exclude the case that the
4516 last enabled row in the desired matrix touches the bottom boundary.
4518 2011-05-21 Glenn Morris <rgm@gnu.org>
4520 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
4521 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4522 and add some more files.
4524 2011-05-20 Eli Zaretskii <eliz@gnu.org>
4526 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4527 report_file_error introduced by the change from 2011-05-07.
4529 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4531 * systime.h (Time): Define only if emacs is defined.
4532 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4533 where the include path doesn't have X11/X.h by default. See
4534 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4536 2011-05-20 Kenichi Handa <handa@m17n.org>
4538 * composite.c (find_automatic_composition): Fix previous change.
4540 2011-05-20 Glenn Morris <rgm@gnu.org>
4542 * lisp.mk: New file, split from Makefile.in.
4543 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4544 (shortlisp): Remove.
4545 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4547 2011-05-19 Glenn Morris <rgm@gnu.org>
4549 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4550 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4551 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4552 (lisp): Set the order to that of loadup.el.
4553 (shortlisp): Make it a copy of $lisp.
4554 (SOME_MACHINE_LISP): Remove.
4555 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4556 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4558 2011-05-18 Kenichi Handa <handa@m17n.org>
4560 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4561 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4562 (find_automatic_composition): Mostly rewrite for efficiency.
4564 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
4566 * makefile.w32-in: Update dependencies.
4568 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4570 * menu.c: Include limits.h (fixes the MS-Windows build broken by
4571 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
4573 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
4575 Fix some integer overflow issues, such as string length overflow.
4577 * insdel.c (count_size_as_multibyte): Check for string overflow.
4579 * character.c (lisp_string_width): Check for string overflow.
4580 Use EMACS_INT, not int, for string indexes and lengths; in
4581 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4582 the resulting string length overflows an EMACS_INT; instead,
4583 report a string overflow if no precision given. When checking for
4584 precision exhaustion, use a check that cannot possibly have
4585 integer overflow. (Bug#8675)
4586 * character.h (lisp_string_width): Adjust to new signature.
4588 * alloc.c (string_overflow): New function.
4589 (Fmake_string): Use it. This doesn't change behavior, but saves
4590 a few bytes and will simplify future changes.
4591 * character.c (string_escape_byte8): Likewise.
4592 * lisp.h (string_overflow): New decl.
4594 Fixups, following up to the user-interface timestamp change.
4595 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4596 for UI timestamps, instead of unsigned long.
4597 * msdos.c (mouse_get_pos): Likewise.
4598 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
4599 * w32gui.h (Time): Define by including "systime.h" rather than by
4600 declaring it ourselves. (Bug#8664)
4602 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4603 * image.c (clear_image_cache): Likewise.
4605 * term.c (term_mouse_position): Don't assume time_t wraparound.
4607 Be more systematic about user-interface timestamps.
4608 Before, the code sometimes used 'Time', sometimes 'unsigned long',
4609 and sometimes 'EMACS_UINT', to represent these timestamps.
4610 This change causes it to use 'Time' uniformly, as that's what X uses.
4611 This makes the code easier to follow, and makes it easier to catch
4612 integer overflow bugs such as Bug#8664.
4613 * frame.c (Fmouse_position, Fmouse_pixel_position):
4614 Use Time, not unsigned long, for user-interface timestamps.
4615 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4616 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4617 * keyboard.h (last_event_timestamp): Likewise.
4618 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4619 * menu.h (xmenu_show): Likewise.
4620 * term.c (term_mouse_position): Likewise.
4621 * termhooks.h (struct input_event.timestamp): Likewise.
4622 (struct terminal.mouse_position_hook): Likewise.
4623 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4624 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4625 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4626 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4628 * menu.h, termhooks.h: Include "systime.h", for Time.
4630 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4631 Don't assume that the difference between two unsigned long values
4632 can fit into an integer. At this point, we know button_down_time
4633 <= event->timestamp, so the difference must be nonnegative, so
4634 there's no need to cast the result if double-click-time is
4635 nonnegative, as it should be; check that it's nonnegative, just in
4636 case. This bug is triggered when events are more than 2**31 ms
4637 apart (about 25 days). (Bug#8664)
4639 * xselect.c (last_event_timestamp): Remove duplicate decl.
4640 (x_own_selection): Remove needless cast to unsigned long.
4642 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4643 that always fit in int. Use a sentinel instead of a counter, to
4644 avoid a temp and to allay GCC's concerns about possible int overflow.
4645 * frame.h (struct frame): Use int for menu_bar_items_used
4646 instead of EMACS_INT, since it always fits in int.
4648 * menu.c (grow_menu_items): Check for int overflow.
4650 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4652 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4653 Before, the code was not consistent. These values cannot exceed
4654 2**31 - 1 so there's no need to make them unsigned.
4655 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4656 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4657 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4659 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4661 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4662 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4663 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4664 presumably because the widths might not match.
4666 * window.c (size_window): Avoid needless test at loop start.
4668 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4670 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4672 2011-05-12 Drew Adams <drew.adams@oracle.com>
4674 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4676 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4678 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4679 `width' to `bar_area_x' and `bar_area_width', respectively.
4680 (x_scroll_run): Take account of fringe background extension.
4682 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4683 Rename local vars `left' and `width' to `bar_area_x' and
4684 `bar_area_width', respectively.
4685 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4686 background extension.
4688 2011-05-10 Jim Meyering <meyering@redhat.com>
4690 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4692 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
4694 * image.c (Finit_image_library): Return t for built-in image types,
4695 like pbm and xbm. (Bug#8640)
4697 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4699 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4701 2011-05-07 Eli Zaretskii <eliz@gnu.org>
4703 * w32console.c (Fset_screen_color): Doc fix.
4704 (Fget_screen_color): New function.
4705 (syms_of_ntterm): Defsubr it.
4707 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4708 unlink the temporary file if Fcall_process didn't create it in the
4710 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4711 child process will be redirected to a file specified with `:file'.
4712 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4713 cue to call_process_cleanup not to close that handle.
4715 2011-05-07 Ben Key <bkey76@gmail.com>
4717 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4718 one of two shell specific rules, either bootstrap-temacs-CMD or
4719 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4720 to the previous implementation of the bootstrap-temacs rule.
4721 The bootstrap-temacs-CMD rule is similar to the previous
4722 implementation of the bootstrap-temacs rule except that it
4723 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4726 These changes, along with some changes to nt/configure.bat,
4727 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4728 earlier fix to add support for --cflags and --ldflags options
4729 that include quotes so that it works whether make uses cmd or
4732 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
4734 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4735 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4737 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4738 a string. Handle both cases.
4739 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4740 (Fdbus_register_method): Use Qinvalid_function.
4742 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4744 * makefile.w32-in: Update dependencies.
4745 (LISP_H): Add inttypes.h and stdin.h.
4746 (PROCESS_H): Add unistd.h.
4748 2011-05-06 Eli Zaretskii <eliz@gnu.org>
4750 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4751 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4753 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
4755 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4757 * term.c (vfatal): Remove stray call to va_end.
4758 It's not needed and the C Standard doesn't allow it here anyway.
4760 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4761 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4763 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4766 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4768 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4770 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4772 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4774 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4776 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4777 * charset.c (Fdefine_charset_internal): Don't initialize
4778 charset.code_space[15]. The value was garbage, on hosts with
4779 32-bit int (Bug#8600).
4781 * lread.c (read_integer): Be more consistent with string-to-number.
4782 Use string_to_number to do the actual conversion; this avoids
4783 rounding errors and fixes some other screwups. Without this fix,
4784 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4785 (digit_to_number): Move earlier, for benefit of read_integer.
4786 Return -1 if the digit is out of range for the base, -2 if it is
4787 not a digit in any supported base. (Bug#8602)
4789 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4791 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4792 to match comment at start of function. This also removes a
4793 GCC warning about overflow in a 32+64-bit port.
4795 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4797 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4798 Reported by Stefan Monnier in
4799 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
4800 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4801 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
4803 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4804 (EMACS_UINTPTR): Likewise, with uintptr_t.
4806 * lisp.h: Prefer 64-bit EMACS_INT if available.
4807 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4808 on 32-bit hosts that have 64-bit int, so that they can access
4810 However, temporarily disable this change unless the temporary
4811 symbol WIDE_EMACS_INT is defined.
4813 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4815 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4816 This removes an assumption that EMACS_INT and long are the same
4817 width as pointers. The assumption is true for Emacs porting targets
4818 now, but we want to make other targets possible.
4819 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4820 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4821 In the rest of the code, change types of integers that hold casted
4822 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4823 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4824 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4825 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4826 No need to cast type when ORing.
4827 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4828 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4829 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4830 assume EMACS_INT is the same width as char *.
4831 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4832 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4833 Remove no-longer-needed casts.
4834 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4835 (xg_tool_bar_help_callback, xg_make_tool_item):
4836 Use EMACS_INTPTR to hold an integer
4837 that will be cast to void *; this can avoid a GCC warning
4838 if EMACS_INT is not the same width as void *.
4839 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4840 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4841 (current_message_1, set_message_1):
4842 Use a local to convert to proper width without a cast.
4843 * xmenu.c (dialog_selection_callback): Likewise.
4845 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4846 Also, don't assume VALBITS / RAND_BITS is less than 5,
4847 and don't rely on undefined behavior when shifting a 1 left into
4849 * lisp.h (get_random): Change signature to match.
4851 * lread.c (hash_string): Use size_t, not int, for hash computation.
4852 Normally we prefer signed values; but hashing is special, because
4853 it's better to use unsigned division on hash table sizes so that
4854 the remainder is nonnegative. Also, size_t is the natural width
4855 for hashing into memory. The previous code used 'int', which doesn't
4856 retain enough info to hash well into very large tables.
4857 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4859 * dbusbind.c: Don't possibly lose pointer info when converting.
4860 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4861 Use XPNTR rather than XHASH, so that the high-order bits of
4862 the pointer aren't lost when converting through void *.
4864 * eval.c (Fautoload): Don't double-shift a pointer.
4866 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4868 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4870 * gnutls.c (DEF_GNUTLS_FN):
4871 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4873 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4875 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4878 2011-05-05 Eli Zaretskii <eliz@gnu.org>
4880 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4881 New version that can reserve upto 2GB of heap space.
4883 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
4885 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4887 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4889 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4890 `gnutls_certificate_set_x509_key_file'.
4892 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
4894 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4895 Update dependencies.
4897 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4899 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4900 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4901 Remove unused parameter `fildes'.
4902 * process.c (read_process_output, send_process): Don't pass it.
4904 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4906 Fix previous change: the library cache is defined in w32.c.
4907 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4908 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4910 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4912 Implement dynamic loading of GnuTLS on Windows.
4914 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4915 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4916 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4919 * gnutls.c (Qgnutls_dll): Define.
4920 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4921 (gnutls_*): Declare function pointers.
4922 (init_gnutls_functions): New function to initialize function pointers.
4923 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4924 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4925 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4926 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4927 (emacs_gnutls_write, emacs_gnutls_read)
4928 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4929 (Fgnutls_available_p): New function.
4930 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4931 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4932 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4934 * image.c: Include w32.h.
4935 (Vimage_type_cache): Delete.
4936 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4937 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4938 (w32_delayed_load): Move to w32.c.
4940 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4942 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4943 (w32_delayed_load): Move from image.c. When loading a library, record
4944 its filename in the :loaded-from property of the library id.
4945 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4946 Initialize and staticpro them.
4947 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4949 * process.c: Include lisp.h before w32.h, not after.
4950 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4951 instead of gnutls_record_check_pending.
4953 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4955 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4957 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4958 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4961 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4963 * xterm.c (x_set_frame_alpha): Do not set property on anything
4964 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4966 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4968 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4970 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4972 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4973 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4974 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4975 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4976 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4977 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4978 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4979 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4980 (Qgnutls_bootprop_callbacks_verify): Make static.
4982 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4984 * callproc.c: Indentation fixup.
4986 * sysdep.c (wait_for_termination_1): Make static.
4987 (wait_for_termination, interruptible_wait_for_termination):
4988 Move after wait_for_termination_1.
4990 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4992 * sysdep.c (interruptible_wait_for_termination): New function
4993 which is like wait_for_termination, but allows keyboard
4996 * callproc.c (Fcall_process): Add (:file "file") as an option for
4998 (Fcall_process_region): Ditto.
5000 2011-04-30 Eli Zaretskii <eliz@gnu.org>
5002 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5003 rather than `XVECTOR (FOO)->size'.
5005 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5006 inttypes.h, as a gnulib replacement is used if it not available in
5009 2011-04-21 Eli Zaretskii <eliz@gnu.org>
5011 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5012 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5013 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5015 * coding.c (coding_alloc_by_realloc): Error out if destination
5016 will grow beyond MOST_POSITIVE_FIXNUM.
5017 (decode_coding_emacs_mule): Abort if there isn't enough place in
5018 charbuf for the composition carryover bytes. Reserve an extra
5019 space for up to 2 characters produced in a loop.
5020 (decode_coding_iso_2022): Abort if there isn't enough place in
5021 charbuf for the composition carryover bytes.
5023 2011-04-21 Eli Zaretskii <eliz@gnu.org>
5025 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5026 aborting when %lld or %lll format is passed.
5027 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5028 %llo or %llx format is passed. (Bug#8545)
5030 * window.c (window_scroll_line_based): Use a marker instead of
5031 simple variables to record original value of point. (Bug#7952)
5033 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5034 produced by %s or %c overflows available buffer space. (Bug#8545)
5036 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5038 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
5039 (SIZE_MAX): Move defn after all includes, as they might #define it.
5041 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5043 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5045 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5047 * keyboard.c (Qdelayed_warnings_hook): Define.
5048 (command_loop_1): Run `delayed-warnings-hook'
5049 if Vdelayed_warnings_list is non-nil.
5050 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5051 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5053 2011-04-28 Eli Zaretskii <eliz@gnu.org>
5055 * doprnt.c (doprnt): Don't return value smaller than the buffer
5056 size if the message was truncated. (Bug#8545).
5058 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5060 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5061 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5063 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5065 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5067 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
5069 * makefile.w32-in: Update dependencies.
5071 2011-04-27 Eli Zaretskii <eliz@gnu.org>
5073 Improve `doprnt' and its usage. (Bug#8545)
5074 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5075 `format_end'. Remove support for %l as a conversion specifier.
5076 Don't use xrealloc. Improve diagnostics when the %l size modifier
5077 is used. Update the commentary.
5079 * eval.c (verror): Simplify calculation of size_t.
5081 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5084 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5086 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5089 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5091 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5092 This makes this file independent of the recent pseudovector change.
5094 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
5096 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5098 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
5099 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
5100 Remove unused local.
5101 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
5103 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
5104 GCC 4.6.0 optimizes based on type-based alias analysis.
5105 For example, if b is of type struct buffer * and v of type struct
5106 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5107 != &v->size, and therefore "v->size = 1; b->size = 2; return
5108 v->size;" must therefore return 1. This assumption is incorrect
5109 for Emacs, since it type-puns struct Lisp_Vector * with many other
5110 types. To fix this problem, this patch adds a new type struct
5111 vectorlike_header that documents the constraints on layout of vectors
5112 and pseudovectors, and helps optimizing compilers not get fooled
5113 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5114 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
5115 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5117 (XSETPVECTYPE): Rewrite in terms of new macro.
5118 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5119 This is a bit clearer, and further avoids the possibility of
5120 undesirable aliasing.
5121 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
5122 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
5123 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5124 since Lisp_Subr is a special case (no "next" field).
5125 (ASIZE): Now uses header.size rather than size.
5126 All previous uses of XVECTOR (foo)->size replaced to use this macro,
5127 to avoid the hassle of writing XVECTOR (foo)->header.size.
5128 (struct vectorlike_header): New type.
5129 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5130 object, to help avoid aliasing.
5131 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5132 (SUBRP): Likewise, since Lisp_Subr is a special case.
5133 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5134 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5135 (struct Lisp_Hash_Table): Combine first two members into a single
5136 struct vectorlike_header member. All uses of "size" and "next" members
5137 changed to be "header.size" and "header.next".
5138 * buffer.h (struct buffer): Likewise.
5139 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5140 * frame.h (struct frame): Likewise.
5141 * process.h (struct Lisp_Process): Likewise.
5142 * termhooks.h (struct terminal): Likewise.
5143 * window.c (struct save_window_data, struct saved_window): Likewise.
5144 * window.h (struct window): Likewise.
5145 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5146 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5147 * buffer.c (init_buffer_once): Likewise.
5148 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5150 * process.c (Fformat_network_address): Use local var for size,
5153 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5155 Make the Lisp reader and string-to-float more consistent (Bug#8525)
5156 * data.c (atof): Remove decl; no longer used or needed.
5157 (digit_to_number): Move to lread.c.
5158 (Fstring_to_number): Use new string_to_number function, to be
5159 consistent with how the Lisp reader treats infinities and NaNs.
5160 Do not assume that floating-point numbers represent EMACS_INT
5161 without losing information; this is not true on most 64-bit hosts.
5162 Avoid double-rounding errors, by insisting on integers when
5163 parsing non-base-10 numbers, as the documentation specifies.
5164 * lisp.h (string_to_number): New decl, replacing ...
5165 (isfloat_string): Remove.
5166 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
5167 (read1): Do not accept +. and -. as integers; this
5168 appears to have been a coding error. Similarly, do not accept
5169 strings like +-1e0 as floating point numbers. Do not report
5170 overflow for integer overflows unless the base is not 10 which
5171 means we have no simple and reliable way to continue.
5172 Break out the floating-point parsing into a new
5173 function string_to_number, so that Fstring_to_number parses
5174 floating point numbers consistently with the Lisp reader.
5175 (digit_to_number): Move here from data.c. Make it static inline.
5176 (E_CHAR, EXP_INT): Remove, replacing with ...
5177 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5178 (string_to_number): New function, replacing isfloat_string.
5179 This function checks for valid syntax and produces the resulting
5180 Lisp float number too. Rework it so that string-to-number
5181 no longer mishandles examples like "1.0e+". Use strtoumax,
5182 so that overflow for non-base-10 numbers is reported only when
5183 there's no portable and simple way to convert to floating point.
5185 * textprop.c (set_text_properties_1): Rewrite for clarity,
5186 and to avoid GCC warning about integer overflow.
5188 * intervals.h (struct interval): Use EMACS_INT for members
5189 where EMACS_UINT might cause problems. See
5190 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5191 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5192 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5194 (offset_intervals): Tell GCC not to worry about length overflow
5195 when negating a negative length.
5197 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5198 (overrun_check_free): Likewise.
5200 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5201 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5204 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5205 (gnutls_make_error): Rename local to avoid shadowing.
5206 (gnutls_emacs_global_deinit): ifdef out; not used.
5207 (Fgnutls_boot): Use const for pointer to readonly storage.
5208 Comment out unused local. Fix pointer signedness problems.
5210 * lread.c (openp): Don't stuff size_t into an 'int'.
5211 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5212 about possible signed overflow.
5214 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5215 (GDK_KEY_g): Don't define if already defined.
5216 (xg_prepare_tooltip): Avoid pointer signedness problem.
5217 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5219 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5220 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5222 * xfns.c (Fx_window_property): Simplify a bit,
5223 to make a bit faster and to avoid GCC 4.6.0 warning.
5224 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5226 * fns.c (internal_equal): Don't assume size_t fits in int.
5228 * alloc.c (compact_small_strings): Tighten assertion a little.
5230 Replace pEd with more-general pI, and fix some printf arg casts.
5231 * lisp.h (pI): New macro, generalizing old pEd macro to other
5232 conversion specifiers. For example, use "...%"pI"d..." rather
5233 than "...%"pEd"...".
5234 (pEd): Remove. All uses replaced with similar uses of pI.
5235 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5236 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5237 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5238 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5239 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5240 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5241 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5243 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5244 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5245 * print.c (safe_debug_print, print_object): Likewise.
5246 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5248 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5249 avoiding the 0 flag, which is not portable.
5250 * process.c (Fmake_network_process): Use pI to avoid cast.
5251 * region-cache.c (pp_cache): Likewise.
5252 * xdisp.c (decode_mode_spec): Likewise.
5253 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5254 behavior on 64-bit hosts with printf arg.
5255 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
5256 (x_stop_queuing_selection_requests): Likewise.
5257 (x_get_window_property): Don't truncate byte count to an 'int'
5260 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5261 here, since it parses constructs like leading '-' and spaces,
5262 which are not wanted; and it overflows with large numbers.
5263 Instead, simply match F[0-9]+, which is what is wanted anyway.
5265 * alloc.c: Remove unportable assumptions about struct layout.
5266 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5267 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5268 (allocate_vectorlike, make_pure_vector): Use the new macros,
5269 plus offsetof, to remove unportable assumptions about struct layout.
5270 These assumptions hold on all porting targets that I know of, but
5271 they are not guaranteed, they're easy to remove, and removing them
5272 makes further changes easier.
5274 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5275 This doesn't fix a bug but makes the code clearer.
5276 (string_overrun_cookie): Now const. Use initializers that
5277 don't formally overflow signed char, to avoid warnings.
5278 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5279 can cause Emacs to crash when string overrun checking is enabled.
5280 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5281 multiple of sizeof (EMACS_INT); it need not be, if
5282 alignof(EMACS_INT) < sizeof (EMACS_INT).
5283 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
5285 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
5287 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5289 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5291 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
5292 supposed to be handshaking. (Bug#8556)
5293 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5295 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
5297 * lisp.h (Qdebug): List symbol.
5298 * eval.c (Qdebug): Restore global linkage.
5299 * keyboard.c (debug-on-event): New variable.
5300 (handle_user_signal): Break into debugger when debug-on-event
5301 matches the current signal symbol.
5303 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5305 * alloc.c (check_sblock, check_string_bytes)
5306 (check_string_free_list): Convert to standard C.
5308 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5310 * w32.c (emacs_gnutls_push): Fix typo.
5312 2011-04-25 Eli Zaretskii <eliz@gnu.org>
5314 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5315 "cast to pointer from integer of different size".
5317 Improve doprnt and its use in verror. (Bug#8545)
5318 * doprnt.c (doprnt): Document the set of format control sequences
5319 supported by the function. Use SAFE_ALLOCA instead of always
5322 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5323 is one byte too soon. Don't use xrealloc; instead xfree and
5326 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5328 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5331 * gnutls.c: Renamed global_initialized to
5332 gnutls_global_initialized. Added internals for the
5333 :verify-hostname-error, :verify-error, and :verify-flags
5334 parameters of `gnutls-boot' and documented those parameters in the
5335 docstring. Start callback support.
5336 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5337 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5338 on error. Return error code.
5339 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5340 (emacs_gnutls_read): Likewise.
5341 (Fgnutls_boot): Return handshake error code.
5342 (emacs_gnutls_handle_error): New function.
5343 (wsaerror_to_errno): Likewise.
5345 * w32.h (emacs_gnutls_pull): Add prototype.
5346 (emacs_gnutls_push): Likewise.
5348 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5349 (emacs_gnutls_push): Likewise.
5351 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5353 * process.c (wait_reading_process_output): Check if GnuTLS
5354 buffered some data internally if no FDs are set for TLS
5357 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5358 (LIBS): Link to USER_LIBS.
5359 ($(BLD)/gnutls.$(0)): New target.
5361 2011-04-24 Eli Zaretskii <eliz@gnu.org>
5363 * xdisp.c (handle_single_display_spec): Rename the
5364 display_replaced_before_p argument into display_replaced_p, to
5365 make it consistent with the commentary. Fix typos in the
5368 * textprop.c (syms_of_textprop): Remove dead code.
5369 (copy_text_properties): Delete obsolete commentary about an
5370 interface that was deleted long ago. Fix typos in the description
5373 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5374 to changes in oldXMenu/XMenu.h from 2011-04-16.
5375 <menu_help_message, prev_menu_help_message>: Constify.
5376 (IT_menu_make_room): menu->help_text is now `const char **';
5379 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5380 to changes in oldXMenu/XMenu.h from 2011-04-16.
5381 (struct XMenu): Declare `help_text' `const char **'.
5383 * xfaces.c <Qunspecified>: Make extern again.
5385 * syntax.c: Include sys/types.h before including regex.h, as
5388 * doc.c (get_doc_string): Improve the format passed to `error'.
5390 * doprnt.c (doprnt): Improve commentary.
5392 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5394 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5397 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5398 changes in globals.h immediately force recompilation.
5399 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5400 $(CURDIR)/s/ms-w32.h.
5401 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
5403 * character.c (Fchar_direction): Function deleted.
5404 (syms_of_character): Don't defsubr it.
5405 <char-direction-table>: Deleted.
5407 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5409 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5410 * doprnt.c: Include limits.h.
5411 (SIZE_MAX): New macro.
5412 (doprnt): Return a size_t value. 2nd arg is now size_t.
5413 Many local variables are now size_t instead of int or unsigned.
5414 Improve overflow protection. Support `l' modifier for integer
5415 conversions. Support %l conversion. Don't assume an EMACS_INT
5416 argument for integer conversions and for %c.
5418 * lisp.h (doprnt): Restore prototype.
5420 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5423 * Makefile.in (base_obj): Add back doprnt.o.
5425 * deps.mk (doprnt.o): Add back prerequisites.
5426 (callint.o): Depend on character.h.
5428 * eval.c (internal_lisp_condition_case): Include the handler
5429 representation in the error message.
5430 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5431 when breaking from the loop.
5433 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5435 * callint.c (Fcall_interactively): When displaying error message
5436 about invalid control letter, pass the character's codepoint, not
5437 a pointer to its multibyte form. Improve display of the character
5438 in octal and display also its hex code.
5440 * character.c (char_string): Use %x to display the (unsigned)
5441 codepoint of an invalid character, to avoid displaying a bogus
5444 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5445 `error', not SYMBOL_NAME itself.
5447 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5448 character arguments to `error'.
5450 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5451 to `error' in error message about FINAL_CHAR argument. Make sure
5452 FINAL_CHAR is a character, and use %c when it is passed as
5453 argument to `error'.
5455 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5457 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5459 * w32.c: Include <time.h>.
5460 (sys_localtime): New function.
5462 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
5464 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5466 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
5468 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
5470 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5473 2011-04-19 Eli Zaretskii <eliz@gnu.org>
5475 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5476 gl_state.e_property when gl_state.object is Qt.
5478 * insdel.c (make_gap_larger): Remove limitation of buffer size
5481 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
5483 * xdisp.c (lookup_glyphless_char_display)
5484 (produce_glyphless_glyph): Handle cons cell entry in
5485 glyphless-char-display.
5486 (Vglyphless_char_display): Document it.
5488 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5489 glyphless-char-display.
5491 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
5493 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5495 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5497 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5498 definition for no-X builds.
5500 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
5502 Static checks with GCC 4.6.0 and non-default toolkits.
5504 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5506 * process.c (keyboard_bit_set): Define only if SIGIO.
5507 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5508 (send_process): Repair possible setjmp clobbering.
5510 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5512 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5514 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5516 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5517 Define only if needed.
5519 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5520 by pacifying GCC about it. Maybe it's time to retire it?
5521 * xfaces.c (USG, __TIMEVAL__): Likewise.
5523 * dispextern.h (struct redisplay_interface): Rename param
5525 * termhooks.h (struct terminal): Likewise.
5526 * xterm.c (xembed_send_message): Likewise.
5528 * insdel.c (make_gap_smaller): Define only if
5529 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5531 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5534 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5535 so that we aren't warned about unused symbols.
5537 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5539 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
5541 * xfns.c (x_real_positions): Mark locals as initialized.
5543 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5545 * xterm.c: Fix problems found by static analysis with other toolkits.
5546 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
5547 (x_dispatch_event): Declare static if USE_GTK, and
5548 define if USE_GTK || USE_X_TOOLKIT.
5549 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
5550 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
5551 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5552 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
5554 * xmenu.c (menu_help_callback): Pointer type fixes.
5555 Use const pointers when pointing at readonly data. Avoid pointer
5557 (FALSE): Remove unused macro.
5558 (update_frame_menubar): Remove unused decl.
5560 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5562 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5563 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5564 (single_menu_item): Rename local to avoid shadowing.
5566 * keyboard.c (make_lispy_event): Remove unused local var.
5568 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5569 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5571 * bitmaps: Change bitmaps from unsigned char back to the X11
5572 compatible char. Avoid the old compiler warnings about
5573 out-of-range initializers by using, for example, '\xab' rather
5576 * xgselect.c (xgselect_initialize): Check vs interface
5577 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5579 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5581 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5582 to read-only memory.
5584 * fns.c (vector): Remove; this old hack is no longer needed.
5586 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
5588 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
5590 * xrdb.c (x_load_resources): Omit unused local.
5592 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
5593 (x_window): Rename locals to avoid shadowing.
5594 (USG): Use the kludged USG macro, to pacify gcc.
5596 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
5597 (x_term_init): Remove local to avoid shadowing.
5599 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
5601 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5602 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5604 2011-04-16 Eli Zaretskii <eliz@gnu.org>
5606 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5608 Fix regex.c, syntax.c and friends for buffers > 2GB.
5609 * syntax.h (struct gl_state_s): Declare character position members
5612 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5614 * textprop.c (verify_interval_modification, interval_of):
5615 Declare arguments EMACS_INT.
5617 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5620 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5622 * indent.c (Fvertical_motion): Local variable it_start is now
5625 * regex.c (re_match, re_match_2, re_match_2_internal)
5626 (bcmp_translate, regcomp, regexec, print_double_string)
5627 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5628 (re_compile_pattern, re_exec): Declare arguments and local
5629 variables `size_t' and `ssize_t' and return values `regoff_t', as
5631 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5632 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5633 <compile_stack_type>: `size' and `avail' are now `size_t'.
5635 * regex.h <regoff_t>: Use ssize_t, not int.
5636 (re_search, re_search_2, re_match, re_match_2): Arguments that
5637 specify buffer/string position and length are now ssize_t and
5638 size_t. Return type is regoff_t.
5640 2011-04-16 Ben Key <bkey76@gmail.com>
5642 * nsfont.m: Fixed bugs in ns_get_family and
5643 ns_descriptor_to_entity that were caused by using free to
5644 deallocate memory blocks that were allocated by xmalloc (via
5645 xstrdup). This caused Emacs to crash when compiled with
5646 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5647 --enable-checking=xmallocoverrun). xfree is now used to
5648 deallocate these memory blocks.
5650 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
5652 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5654 emacs_write: Accept and return EMACS_INT for sizes.
5655 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5657 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5658 Accept and return EMACS_INT.
5659 (emacs_gnutls_write): Return the number of bytes written on
5661 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
5662 (emacs_read, emacs_write): Remove check for negative size, as the
5663 Emacs source code has been audited now.
5664 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5665 (emacs_read, emacs_write): Use it.
5666 * process.c (send_process): Adjust to the new signatures of
5667 emacs_write and emacs_gnutls_write. Do not attempt to store
5668 a byte offset into an 'int'; it might overflow.
5669 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
5671 * sound.c: Don't assume sizes fit in 'int'.
5672 (struct sound_device.period_size, alsa_period_size):
5673 Return EMACS_INT, not int.
5674 (struct sound_device.write, vox_write, alsa_write):
5675 Accept EMACS_INT, not int.
5676 (wav_play, au_play): Use EMACS_INT to store sizes and to
5677 record read return values.
5679 2011-04-15 Ben Key <bkey76@gmail.com>
5681 * keyboard.c (Qundefined): Don't declare static since it is used
5683 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5684 static since they are used in nsfont.m.
5686 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5688 * process.c (Qprocessp): Don't declare static.
5689 * lisp.h (Qprocessp): Declare again.
5691 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
5693 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5695 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5697 Improve C-level modularity by making more things 'static'.
5699 Don't publish debugger-only interfaces to other modules.
5700 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5701 (verify_bytepos, count_markers): Move decls to the only modules
5703 * region-cache.h (pp_cache): Likewise.
5704 * window.h (check_all_windows): Likewise.
5705 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5707 * sysdep.c (croak): Now static, if
5708 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5709 * syssignal.h (croak): Declare only if not static.
5711 * alloc.c (refill_memory_reserve): Now static if
5712 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5713 * lisp.h (refill_memory_reserve): Declare only if not static.
5715 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5716 Define only if USE_LUCID.
5718 * xrdb.c (x_customization_string, x_rm_string): Now static.
5720 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5721 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5723 * xdisp.c (draw_row_with_mouse_face): Now static.
5724 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5726 * window.h (check_all_windows): Mark externally visible.
5728 * window.c (window_deletion_count): Now static.
5730 * undo.c: Make symbols static if they're not exported.
5731 (last_undo_buffer, last_boundary_position, pending_boundary):
5734 * textprop.c (interval_insert_behind_hooks): Now static.
5735 (interval_insert_in_front_hooks): Likewise.
5737 * term.c: Make symbols static if they're not exported.
5738 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5739 (max_frame_lines, tty_set_terminal_modes):
5740 (tty_reset_terminal_modes, tty_turn_off_highlight):
5741 (get_tty_terminal): Now static.
5742 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5743 * termhooks.h (term_mouse_moveto): Do not declare if
5745 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5746 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5748 * sysdep.c: Make symbols static if they're not exported.
5749 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5751 (sigprocmask_set, full_mask): Remove; unused.
5752 (wait_debugging): Mark as visible.
5753 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5754 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5756 * syntax.c (syntax_temp): Define only if !__GNUC__.
5758 * sound.c (current_sound_device, current_sound): Now static.
5760 * search.c (searchbufs, searchbuf_head): Now static.
5762 * scroll.c (scroll_cost): Remove; unused.
5763 * dispextern.h (scroll_cost): Remove decl.
5765 * region-cache.h (pp_cache): Mark as externally visible.
5767 * process.c: Make symbols static if they're not exported.
5768 (process_tick, update_tick, create_process, chan_process):
5769 (Vprocess_alist, proc_buffered_char, datagram_access):
5770 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5771 (deactivate_process): Mark defn as static, as well as decl.
5772 * lisp.h (create_process): Remove decl.
5773 * process.h (chan_process, Vprocess_alist): Remove decls.
5775 * print.c: Make symbols static if they're not exported.
5776 (print_depth, new_backquote_output, being_printed, print_buffer):
5777 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5778 (print_interval, print_number_index, initial_stderr_stream):
5780 * lisp.h (Fprinc): Remove decl.
5781 (debug_output_compilation_hack): Mark as externally visible.
5783 * sysdep.c (croak): Move decl from here to syssignal.h.
5784 * syssignal.h (croak): Put it here, so the API can be checked when
5785 'croak' is called from dissociate_if_controlling_tty.
5787 * minibuf.c: Make symbols static if they're not exported.
5788 (minibuf_save_list, choose_minibuf_frame): Now static.
5789 * lisp.h (choose_minibuf_frame): Remove decl.
5791 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5793 * lread.c: Make symbols static if they're not exported.
5794 (read_objects, initial_obarray, oblookup_last_bucket_number):
5796 (make_symbol): Remove; unused.
5797 * lisp.h (initial_obarray, make_symbol): Remove decls.
5799 * keyboard.c: Make symbols static if they're not exported.
5800 (single_kboard, recent_keys_index, total_keys, recent_keys):
5801 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5802 (this_single_command_key_start, echoing, last_auto_save):
5803 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5804 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5805 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5806 (Vlispy_mouse_stem, double_click_count):
5808 (force_auto_save_soon): Define only if SIGDANGER.
5809 (ignore_mouse_drag_p): Now static if
5810 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5811 (print_help): Remove; unused.
5812 (stop_character, last_timer_event): Mark as externally visible.
5813 * keyboard.h (ignore_mouse_drag_p): Declare only if
5814 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5815 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5816 * lisp.h (echoing): Remove decl.
5817 (force_auto_save_soon): Declare only if SIGDANGER.
5818 * xdisp.c (redisplay_window): Simplify code, to make it more
5819 obvious that ignore_mouse_drag_p is not accessed if !defined
5820 USE_GTK && !defined HAVE_NS.
5822 * intervals.c: Make symbols static if they're not exported.
5823 (merge_properties_sticky, merge_interval_right, delete_interval):
5825 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5827 * insdel.c: Make symbols static if they're not exported.
5828 However, leave prepare_to_modify_buffer alone. It's never
5829 called from outside this function, but that appears to be a bug.
5830 (combine_after_change_list, combine_after_change_buffer):
5831 (adjust_after_replace, signal_before_change): Now static.
5832 (adjust_after_replace_noundo): Remove; unused.
5833 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
5834 (signal_before_change): Remove decls.
5836 * indent.c (val_compute_motion, val_vmotion): Now static.
5838 * image.c: Make symbols static if they're not exported.
5839 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5841 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5842 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5844 * fringe.c (standard_bitmaps): Now static.
5845 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5847 * frame.c: Make symbols static if they're not exported.
5848 (x_report_frame_params, make_terminal_frame): Now static.
5849 (get_frame_param): Now static, unless HAVE_NS.
5850 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5851 (x_get_resource_string): Remove; not used.
5852 * frame.h (make_terminal_frame, x_report_frame_params):
5853 (x_get_resource_string); Remove decls.
5854 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5855 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5857 * font.c, fontset.c: Make symbols static if they're not exported.
5858 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5859 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5860 * font.c (font_close_object): Now static.
5861 * font.h (font_close_object): Remove.
5862 * fontset.c (FONTSET_OBJLIST): Remove.
5863 (free_realized_fontset) #if-0 the body, which does nothing.
5864 (face_suitable_for_char_p): #if-0, as it's never called.
5865 * fontset.h (face_suitable_for_char_p): Remove decl.
5866 * xfaces.c (face_at_string_position):
5867 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
5868 since 0 is always ASCII.
5870 * fns.c (weak_hash_tables): Now static.
5872 * fileio.c: Make symbols static if they're not exported.
5873 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5874 (Vwrite_region_annotation_buffers): Now static.
5876 * eval.c: Make symbols static if they're not exported.
5877 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5878 * lisp.h (backtrace_list): Remove decl.
5880 * emacs.c: Make symbols static if they're not exported.
5881 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5882 (fatal_error_code, fatal_error_signal_hook, standard_args):
5884 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5885 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5886 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5887 * lisp.h (fatal_error_signal_hook): Remove decl.
5888 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5890 * editfns.c: Move a (normally-unused) function to its only use.
5891 * editfns.c, lisp.h (get_operating_system_release): Remove.
5892 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5893 worth the hassle of breaking this out.
5895 * xterm.c: Make symbols static if they're not exported.
5896 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5897 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5898 (x_destroy_window, x_delete_display):
5900 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5901 (x_mouse_leave): Remove; unused.
5902 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5903 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5904 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5906 (x_mouse_leave): Declare only if WINDOWSNT.
5907 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5908 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5911 * ftxfont.c: Make symbols static if they're not exported.
5912 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5914 * font.h (ftxfont_driver): Likewise.
5916 * xfns.c: Make symbols static if they're not exported.
5917 (x_last_font_name, x_display_info_for_name):
5918 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5919 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5920 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5921 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5922 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5923 (last_show_tip_args): Now static.
5924 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5925 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5926 (x_screen_planes): Remove; unused.
5927 * dispextern.h (x_screen_planes): Remove decl.
5929 * dispnew.c: Make symbols static if they're not exported.
5930 * dispextern.h (redraw_garbaged_frames, scrolling):
5931 (increment_row_positions): Remove.
5932 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5933 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5935 (redraw_garbaged_frames): Remove; unused.
5937 * xfaces.c: Make symbols static if they're not exported.
5938 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5940 * xterm.h (defined_color): Remove decls.
5941 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5942 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5943 (menu_face_changed_default, defined_color, free_realized_face):
5944 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5945 (ascii_face_of_lisp_face): Remove; unused.
5947 * xdisp.c: Make symbols static if they're not exported.
5948 * dispextern.h (scratch_glyph_row, window_box_edges):
5949 (glyph_to_pixel_coords, set_cursor_from_row):
5950 (get_next_display_element, set_iterator_to_next):
5951 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5952 (show_mouse_face): Remove decls
5953 * frame.h (message_buf_print): Likewise.
5954 * lisp.h (pop_message, set_message, check_point_in_composition):
5956 * xterm.h (set_vertical_scroll_bar): Likewise.
5957 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5958 (message_buf_print, scratch_glyph_row, displayed_buffer):
5959 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5960 (get_next_display_element, show_mouse_face, window_box_edges):
5961 (frame_to_window_pixel_xy, check_point_in_composition):
5962 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5963 (glyph_to_pixel_coords): Remove; unused.
5965 * dired.c (file_name_completion): Now static.
5967 * dbusbind.c (xd_in_read_queued_messages): Now static.
5969 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5970 * data.c (circular_list_error): Remove.
5972 * commands.h (last_point_position, last_point_position_buffer):
5973 (last_point_position_window): Remove decls.
5974 * keyboard.c: Make these variables static.
5976 * coding.h (coding, code_convert_region, encode_coding_gap):
5978 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5979 (iso_code_class, detect_coding, code_convert_region): Now static.
5980 (encode_coding_gap): Remove; unused.
5982 * chartab.c (chartab_chars, chartab_bits): Now static.
5984 * charset.h (charset_iso_8859_1): Remove decl.
5985 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5988 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5989 * ccl.c (Vccl_program_table): Now static.
5990 (check_ccl_update): Remove; unused.
5992 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5993 * category.h: ... from here.
5994 * category.c (check_category_table, set_category_set): Now static.
5996 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5997 * lisp.h: Remove these decls.
5999 * buffer.c (buffer_count): Remove unused var.
6001 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6002 so that it's not optimized away.
6003 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6004 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6005 exported only to the debugger.
6007 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
6008 * atimer.h (run_all_atimers): Remove; not exported.
6010 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6011 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6012 was inaccessible from Lisp.
6013 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6014 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6016 alloc.c: Import and export fewer symbols, and remove unused items.
6017 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6019 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6020 it's not optimized away by whole-program optimization.
6021 (message_enable_multibyte, free_misc): Remove.
6022 (catchlist, handlerlist, mark_backtrace):
6023 Declare only if BYTE_MARK_STACK.
6024 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6025 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6026 (message_enable_multibyte): Remove decl.
6027 (free_misc, interval_free_list, float_block, float_block_index):
6028 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6029 (cons_free_list, last_marked_index):
6031 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6032 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6033 (mark_backtrace): Define only if BYTE_MARK_STACK.
6034 * xdisp.c (message_enable_multibyte): Now static.
6036 Declare Lisp_Object Q* variables to be 'static' if not exported.
6037 This makes it easier for human readers (and static analyzers)
6038 to see whether these variables are used from other modules.
6039 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6040 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6041 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6042 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6043 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6044 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6045 * xmenu.c, xselect.c:
6046 Declare Q* vars static if they are not used in other modules.
6047 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6048 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6049 Remove decls of unexported vars.
6050 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6052 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6054 Make Emacs functions such as Fatom 'static' by default.
6055 This makes it easier for human readers (and static analyzers)
6056 to see whether these functions can be called from other modules.
6057 DEFUN now defines a static function. To make the function external
6058 so that it can be used in other C modules, use the new macro DEFUE.
6059 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6060 (Finit_image_library):
6061 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6062 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6063 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6064 Remove decls, since these functions are now static.
6065 (Funintern, Fget_internal_run_time): New decls, since these functions
6066 were already external.
6068 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6069 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6070 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6071 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6072 * keyboard.c, keymap.c, lread.c:
6073 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6074 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6075 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6076 Mark functions with DEFUE instead of DEFUN,
6077 if they are used in other modules.
6078 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6079 decls for now-static functions.
6080 * buffer.h (Fdelete_overlay): Remove decl.
6081 * callproc.c (Fgetenv_internal): Mark as internal.
6082 * composite.c (Fremove_list_of_text_properties): Remove decl.
6083 (Fcomposition_get_gstring): New forward static decl.
6084 * composite.h (Fcomposite_get_gstring): Remove decl.
6085 * dired.c (Ffile_attributes): New forward static decl.
6086 * doc.c (Fdocumntation_property): New forward static decl.
6087 * eval.c (Ffetch_bytecode): New forward static decl.
6088 (Funintern): Remove extern decl; now in .h file where it belongs.
6089 * fileio.c (Fmake_symbolic_link): New forward static decl.
6090 * image.c (Finit_image_library): New forward static decl.
6091 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6092 * intervals.h (Fprevious_property_change):
6093 (Fremove_list_of_text_properties): Remove decls.
6094 * keyboard.c (Fthis_command_keys): Remove decl.
6095 (Fcommand_execute): New forward static decl.
6096 * keymap.c (Flookup_key): New forward static decl.
6097 (Fcopy_keymap): Now static.
6098 * keymap.h (Flookup_key): Remove decl.
6099 * process.c (Fget_process): New forward static decl.
6100 (Fprocess_datagram_address): Mark as internal.
6101 * syntax.c (Fsyntax_table_p): New forward static decl.
6102 (skip_chars): Remove duplicate decl.
6103 * textprop.c (Fprevious_property_change): New forward static decl.
6104 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6106 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6107 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6109 * editfns.c (Fformat): Remove unreachable code.
6111 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6113 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6116 2011-04-13 Eli Zaretskii <eliz@gnu.org>
6118 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6119 when at ZV. (Bug#8487)
6121 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6123 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6125 * keyboard.c (parse_tool_bar_item): Likewise.
6126 * sound.c (sound_cleanup, alsa_close): Likewise.
6127 * termcap.c (tgetent): Likewise.
6128 * xfns.c (x_default_font_parameter): Likewise.
6129 * xsettings.c (read_and_apply_settings): Likewise.
6131 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6132 (overrun_check_free): Protoize.
6134 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6136 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6137 since callers should never pass a negative size.
6138 Change the signature to match that of plain 'read' and 'write'; see
6139 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6140 * lisp.h: Update prototypes of emacs_write and emacs_read.
6142 2011-04-11 Eli Zaretskii <eliz@gnu.org>
6144 * xdisp.c (redisplay_window): Don't try to determine the character
6145 position of the scroll margin if the window start point w->startp
6146 is outside the buffer's accessible region. (Bug#8468)
6148 2011-04-10 Eli Zaretskii <eliz@gnu.org>
6150 Fix write-region and its subroutines for buffers > 2GB.
6151 * fileio.c (a_write, e_write): Modify declaration of arguments and
6152 local variables to support buffers larger than 2GB.
6153 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6155 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6156 argument, local variables, and return value.
6158 * lisp.h: Update prototypes of emacs_write and emacs_read.
6160 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6162 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
6164 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6166 Fix more problems found by GCC 4.6.0's static checks.
6168 * xdisp.c (vmessage): Use a better test for character truncation.
6170 * charset.c (load_charset_map): <, not <=, for optimization,
6171 and to avoid potential problems with integer overflow.
6172 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
6173 * casetab.c (set_identity, shuffle): Likewise.
6174 * editfns.c (Fformat): Likewise.
6175 * syntax.c (skip_chars): Likewise.
6177 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6178 This also lets GCC 4.6.0 generate slightly better loop code.
6180 * callint.c (Fcall_interactively): <, not <=, for optimization.
6181 (Fcall_interactively): Count the number of arguments produced,
6182 not the number of arguments given. This is simpler and lets GCC
6183 4.6.0 generate slightly better code.
6185 * ftfont.c: Distingish more carefully between FcChar8 and char.
6186 The previous code passed unsigned char * to a functions like
6187 strlen and xstrcasecmp that expect char *, which does not
6188 conform to the C standard.
6189 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6190 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6191 char * when the C standard requires it.
6193 * keyboard.c (read_char): Remove unused var.
6195 * eval.c: Port to Windows vsnprintf (Bug#8435).
6197 (SIZE_MAX): Define if the headers do not.
6198 (verror): Do not give up if vsnprintf returns a negative count.
6199 Instead, grow the buffer. This ports to Windows vsnprintf, which
6200 does not conform to C99. Problem reported by Eli Zaretskii.
6201 Also, simplify the allocation scheme, by avoiding the need for
6202 calling realloc, and removing the ALLOCATED variable.
6204 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6206 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6207 But keep the doprint source code for now, as we might revamp it
6208 and use it again (Bug#8435).
6209 * lisp.h (doprnt): Remove.
6210 * Makefile.in (base_obj): Remove doprnt.o.
6211 * deps.mk (doprnt.o): Remove.
6213 error: Print 32- and 64-bit integers portably (Bug#8435).
6214 Without this change, on typical 64-bit hosts error ("...%d...", N)
6215 was used to print both 32- and 64-bit integers N, which relied on
6217 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6219 * lisp.h (error, verror): Mark as printf-like functions.
6220 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6221 Report overflow in size calculations when allocating printf buffer.
6222 Do not truncate output string at its first null byte.
6223 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6224 Truncate the output at a character boundary, since vsnprintf does not
6226 * charset.c (check_iso_charset_parameter): Convert internal
6227 character to string before calling 'error', since %c now has the
6229 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6230 overflow when computing char to be passed to 'error'. Do not
6231 pass Lisp_Object to 'error'; pass the integer instead.
6232 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6233 formatted with plain %d.
6235 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6237 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6239 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6241 * xterm.c (x_catch_errors): Remove duplicate declaration.
6243 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6245 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6247 2011-04-10 Jim Meyering <meyering@redhat.com>
6249 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6250 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6251 return ssize_t not "int", and use size_t as the buffer length.
6252 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6253 * gnutls.h: Update declarations.
6254 * process.c (read_process_output): Use ssize_t, to match.
6255 (send_process): Likewise.
6257 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6259 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6261 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6263 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6264 Use unsigned char, to match FcChar8 type definition.
6266 * xterm.c (handle_one_xevent):
6267 * xmenu.c (create_and_show_popup_menu):
6268 * xselect.c (x_decline_selection_request)
6269 (x_reply_selection_request): Avoid type-punned deref of X events.
6271 2011-04-09 Eli Zaretskii <eliz@gnu.org>
6273 Fix some uses of `int' instead of EMACS_INT.
6274 * search.c (string_match_1, fast_string_match)
6275 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6276 (scan_buffer, find_next_newline_no_quit)
6277 (find_before_next_newline, search_command, Freplace_match)
6278 (Fmatch_data): Make some `int' variables be EMACS_INT.
6280 * xdisp.c (display_count_lines): 3rd argument and return value now
6281 EMACS_INT. All callers changed.
6282 (pint2hrstr): Last argument is now EMACS_INT.
6284 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6285 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6286 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6287 (decode_coding_utf_16, decode_coding_emacs_mule)
6288 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6289 (decode_coding_ccl, decode_coding_charset)
6290 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6291 (decode_coding_iso_2022, decode_coding_emacs_mule)
6292 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6293 <char_offset, last_offset>: Declare EMACS_INT.
6294 (encode_coding_utf_8, encode_coding_utf_16)
6295 (encode_coding_emacs_mule, encode_invocation_designation)
6296 (encode_designation_at_bol, encode_coding_iso_2022)
6297 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6298 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6300 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6301 (encode_invocation_designation): Last argument P_NCHARS is now
6303 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6304 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6306 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6309 * ccl.c (Fccl_execute_on_string): Declare some variables
6312 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
6314 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6316 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6318 * process.c (Fformat_network_address): Doc fix.
6320 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6322 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6324 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
6326 * keyboard.c (read_char): Call Lisp function help-form-show,
6327 instead of using internal_with_output_to_temp_buffer.
6328 (Qhelp_form_show): New var.
6329 (syms_of_keyboard): Use DEFSYM macro.
6331 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6333 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6335 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
6337 * process.c (Flist_processes): Remove to Lisp.
6338 (list_processes_1): Delete.
6340 2011-04-06 Eli Zaretskii <eliz@gnu.org>
6342 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6344 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6346 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
6348 Fix more problems found by GCC 4.6.0's static checks.
6350 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6352 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6354 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
6356 * xdisp.c (vmessage): Mark as a printf-like function.
6358 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6360 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6362 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6363 printf-like functions.
6364 (tiff_load): Add casts to remove these marks before passing them
6365 to system-supplied API.
6367 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6369 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6370 This avoids several warnings with gcc -Wstrict-overflow.
6371 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6372 directly, rather than having caller test rule sign. This avoids
6373 some unnecessary tests.
6374 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6375 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6376 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
6378 * xfont.c (xfont_text_extents): Remove var that was set but not used.
6379 (xfont_open): Avoid unnecessary tests.
6381 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6383 * composite.h, composite.c (composition_gstring_put_cache):
6384 Use EMACS_INT, not int, for length.
6386 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6387 breaking out part of COMPOSITION_DECODE_RULE.
6388 (COMPOSITION_DECODE_RULE): Use it.
6389 * composite.c (get_composition_id): Remove unused local vars,
6390 by using the new macro.
6392 * textprop.c (set_text_properties_1): Change while to do-while,
6393 since the condition is always true at first.
6395 * intervals.c (graft_intervals_into_buffer): Mark var as used.
6396 (interval_deletion_adjustment): Return unsigned value.
6399 * process.c (list_processes_1, create_pty, read_process_output):
6400 (exec_sentinel): Remove vars that were set but not used.
6401 (create_pty): Remove unnecessary "volatile"s.
6402 (Fnetwork_interface_info): Avoid possibility of int overflow.
6403 (read_process_output): Do adaptive read buffering even if carryover.
6404 (read_process_output): Simplify nbytes computation if buffered.
6406 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6408 * syntax.c (scan_words): Remove var that was set but not used.
6409 (update_syntax_table): Use unsigned instead of int.
6411 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
6412 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
6413 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
6415 * print.c (print_error_message): Avoid int overflow.
6417 * font.c (font_list_entities): Redo for clarity,
6418 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6420 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
6421 (font_score): Avoid potential overflow in diff calculation.
6423 * fns.c (substring_both): Remove var that is set but not used.
6424 (sxhash): Redo loop for clarity and to avoid wraparound warning.
6426 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6428 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6429 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6430 can always succeed if overflow has undefined behavior.
6432 * search.c (boyer_moore, wordify): Remove vars set but not used.
6433 (wordify): Omit three unnecessary tests.
6435 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6436 All callers changed. This avoids the need for an unused var.
6438 * casefiddle.c (casify_region): Remove var that is set but not used.
6440 * dired.c (file_name_completion): Remove var that is set but not used.
6442 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6444 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
6445 (Finsert_file_contents): Remove unnecessary code checking fd.
6447 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6448 Check for integer overflow on size calculations.
6450 * buffer.c (Fprevious_overlay_change): Remove var that is set
6453 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6454 Remove vars that are set but not used.
6455 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6456 (timer_check_2): Mark vars as initialized.
6458 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6460 * image.c (lookup_image): Remove var that is set but not used.
6461 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
6463 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6464 that are set but not used.
6466 * xfns.c (make_invisible_cursor): Don't return garbage
6467 if XCreateBitmapFromData fails (Bug#8410).
6469 * xselect.c (x_get_local_selection, x_handle_property_notify):
6470 Remove vars that are set but not used.
6472 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6473 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
6475 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6476 Remove var that is set but not used.
6477 (scroll_bar_windows_size): Now size_t, not int.
6478 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6481 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6482 (map_tty_color) [!defined MSDOS]: Likewise.
6484 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6486 * coding.c: Remove vars that are set but not used.
6487 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6488 All callers changed.
6489 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6490 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6491 (decode_coding_charset): Remove vars that are set but not used.
6493 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6494 that is set but not used.
6496 * print.c (print_object): Remove var that is set but not used.
6498 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
6499 The gnulib version avoids calling malloc in the usual case,
6500 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6501 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6502 * filelock.c (current_lock_owner): Likewise.
6503 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6504 * sysdep.c: Include allocator.h, careadlinkat.h.
6505 (emacs_no_realloc_allocator): New static constant.
6506 (emacs_readlink): New function.
6507 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6508 ../lib/careadlinkat.h.
6510 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6512 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6513 first non-nil return value).
6515 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6517 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6518 if not defined (Bug#8403).
6520 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6522 * xdisp.c (display_count_lines): Remove parameter `start',
6523 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6524 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6525 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6526 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6527 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6528 and thereabouts. All callers changed.
6529 (get_per_char_metric): Remove parameter `f', unused since
6530 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6532 2011-04-02 Jim Meyering <meyering@redhat.com>
6534 do not dereference NULL upon failed strdup
6535 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6536 (ns_get_family): Likewise.
6538 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6540 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6542 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6544 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6547 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6549 Add lexical binding.
6551 * window.c (Ftemp_output_buffer_show): New fun.
6552 (Fsave_window_excursion):
6553 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6555 * lread.c (lisp_file_lexically_bound_p): New function.
6556 (Fload): Bind Qlexical_binding.
6557 (readevalloop): Remove `evalfun' arg.
6558 Bind Qinternal_interpreter_environment.
6559 (Feval_buffer): Bind Qlexical_binding.
6560 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6562 (syms_of_lread): Declare `lexical-binding'.
6564 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6566 * keyboard.c (eval_dyn): New fun.
6567 (menu_item_eval_property): Use it.
6569 * image.c (parse_image_spec): Use Ffunctionp.
6571 * fns.c (concat, mapcar1): Accept byte-code-functions.
6573 * eval.c (Fsetq): Handle lexical vars.
6574 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6575 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6576 (FletX, Flet): Obey lexical binding.
6577 (Fcommandp): Handle closures.
6578 (Feval): New `lexical' arg.
6579 (eval_sub): New function extracted from Feval. Use it almost
6580 everywhere where Feval was used. Look up vars in lexical env.
6582 (Ffunctionp): Move from subr.el.
6583 (Ffuncall): Handle closures.
6584 (apply_lambda): Remove `eval_flags'.
6585 (funcall_lambda): Handle closures and new byte-code-functions.
6586 (Fspecial_variable_p): New function.
6587 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6588 but without exporting it to Lisp.
6590 * doc.c (Fdocumentation, store_function_docstring):
6591 * data.c (Finteractive_form): Handle closures.
6593 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6596 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6598 (exec_byte_code): New function extracted from Fbyte_code to handle new
6599 calling convention for byte-code-functions. Add new byte-codes.
6601 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
6603 * alloc.c (Fmake_symbol): Init new `declared_special' field.
6605 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6607 * xdisp.c (redisplay_internal): Fix prototype.
6609 2011-03-31 Eli Zaretskii <eliz@gnu.org>
6611 * xdisp.c (SCROLL_LIMIT): New macro.
6612 (try_scrolling): Use it when setting scroll_limit.
6613 Limit scrolling to 100 screen lines.
6614 (redisplay_window): Even when falling back on "recentering",
6615 position point in the window according to scroll-conservatively,
6616 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6618 (try_scrolling): When point is above the window, allow searching
6619 as far as scroll_max, or one screenful, to compute vertical
6620 distance from PT to the scroll margin position. This prevents
6621 try_scrolling from unnecessarily failing when
6622 scroll-conservatively is set to a value slightly larger than the
6623 window height. Clean up the case of PT below the margin at bottom
6624 of window: scroll_max can no longer be INT_MAX. When aggressive
6625 scrolling is in use, don't let point enter the opposite scroll
6626 margin as result of the scroll.
6627 (syms_of_xdisp) <scroll-conservatively>: Document the
6628 threshold of 100 lines for never-recentering scrolling.
6630 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6632 * dispextern.h (move_it_by_lines):
6633 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6634 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6635 (message_log_check_duplicate): Remove parameters `prev_bol' and
6636 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6637 (redisplay_internal): Remove parameter `preserve_echo_area',
6638 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6640 * indent.c (Fvertical_motion):
6641 * window.c (window_scroll_pixel_based, Frecenter):
6642 Don't pass `need_y_p' to `move_it_by_lines'.
6644 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6646 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6647 steal a few bits to be more compact.
6648 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6649 Remove unneeded casts.
6651 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6653 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6655 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6656 binding" message (bug#7967).
6658 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6660 Fix more problems found by GCC 4.6.0's static checks.
6662 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6663 Remove unused local var.
6665 * editfns.c (Fmessage_box): Remove unused local var.
6667 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6668 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6669 Omit unused local vars.
6670 * window.c (shrink_windows): Omit unused local var.
6671 * menu.c (digest_single_submenu): Omit unused local var.
6672 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6673 Omit unused local var.
6675 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6676 Don't assume string length fits in int.
6677 (keyremap_step, read_key_sequence): Use size_t for sizes.
6678 (read_key_sequence): Don't check last_real_key_start redundantly.
6680 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6681 instead of alloca (Bug#8344).
6683 * eval.c (Fbacktrace): Don't assume nargs fits in int.
6684 (Fbacktrace_frame): Don't assume nframes fits in int.
6686 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6688 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6691 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6693 * cm.c (calccost): Turn while-do into do-while, for clarity.
6695 * keyboard.c (syms_of_keyboard): Use the same style as later
6696 in this function when indexing through an array. This also
6697 works around GCC bug 48267.
6699 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6701 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6703 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6704 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6706 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6707 This avoids undefined behavior on integer overflow, and is a bit
6708 more convenient anyway since it is compared to a size_t variable.
6710 Variadic C functions now count arguments with size_t, not int.
6711 This avoids an unnecessary limitation on 64-bit machines, which
6712 caused (substring ...) to crash on large vectors (Bug#8344).
6713 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6714 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
6715 All variadic functions and their callers changed accordingly.
6716 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6717 * data.c (arith_driver, float_arith_driver): Likewise.
6718 * editfns.c (general_insert_function): Likewise.
6719 * eval.c (struct backtrace.nargs, interactive_p)
6720 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6721 (funcall_lambda, mark_backtrace): Likewise.
6722 * fns.c (concat): Likewise.
6723 * frame.c (x_set_frame_parameters): Likewise.
6724 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6725 0 if not found, not -1. All callers changed.
6727 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6728 (stack_copy_size): Now size_t, not int.
6729 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6731 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6733 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6734 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6735 All callers changed.
6737 * lisp.h (multibyte_char_to_unibyte):
6738 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6739 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6740 * character.h (CHAR_TO_BYTE8):
6741 * cmds.c (internal_self_insert):
6742 * editfns.c (general_insert_function):
6743 * keymap.c (push_key_description):
6744 * search.c (Freplace_match):
6745 * xdisp.c (message_dolog, set_message_1): All callers changed.
6747 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6749 * keyboard.c (safe_run_hook_funcall): New function.
6750 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6751 don't set the hook to nil, but remove the offending function instead.
6752 (Qcommand_hook_internal): Remove, unused.
6753 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6754 Vcommand_hook_internal.
6756 * eval.c (enum run_hooks_condition): Remove.
6757 (funcall_nil, funcall_not): New functions.
6758 (run_hook_with_args): Call each function through a `funcall' argument.
6759 Remove `cond' argument, now redundant.
6760 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6761 (Frun_hook_with_args_until_failure): Adjust accordingly.
6762 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6764 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6766 * dispextern.h (string_buffer_position): Remove declaration.
6768 * print.c (strout): Remove parameter `multibyte', unused since
6769 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6771 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6772 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6773 All callers changed.
6775 * w32.c (_wsa_errlist): Use braces for struct initializers.
6777 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6778 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6779 All callers changed.
6780 (string_buffer_position): Likewise. Also, make static (it's never
6781 used outside xdisp.c).
6782 (cursor_row_p): Remove parameter `w', unused since
6783 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6784 (decode_mode_spec): Remove parameter `precision', introduced during
6785 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6786 All callers changed.
6788 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6790 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6792 2011-03-27 Anders Lindgren <andlind@gmail.com>
6794 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6795 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6796 (ns_update_auto_hide_menu_bar): New functions.
6797 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6798 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6799 ns_constrain_all_frames.
6800 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6801 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6803 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6805 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6807 2011-03-27 Glenn Morris <rgm@gnu.org>
6809 * syssignal.h: Replace RETSIGTYPE with void.
6810 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6811 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6812 Replace SIGTYPE with void everywhere.
6813 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6814 * s/template.h (SIGTYPE): Remove commented out definition.
6816 2011-03-26 Eli Zaretskii <eliz@gnu.org>
6818 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6819 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6821 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
6823 * w32.c (read_unc_volume): Use parameter `henum', instead of
6824 global variable `wget_enum_handle'.
6826 * keymap.c (describe_vector): Remove parameters `indices' and
6827 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6828 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6830 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6832 * keyboard.c (timer_check): Remove parameter `do_it_now',
6833 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6834 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6835 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6837 * keyboard.c (read_char):
6838 * w32menu.c (w32_menu_display_help):
6839 * xmenu.c (show_help_event, menu_help_callback):
6840 Adjust calls to `show_help_echo'.
6842 * gtkutil.c (xg_maybe_add_timer):
6843 * keyboard.c (readable_events):
6844 * process.c (wait_reading_process_output):
6845 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6847 * insdel.c (adjust_markers_gap_motion):
6848 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6849 (gap_left, gap_right): Don't call it.
6851 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
6853 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6854 incurred during fontification.
6856 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6858 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6859 (DEFVAR_PER_BUFFER): Don't pass it.
6861 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6862 (scrolling_window): Don't pass it.
6864 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6866 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6868 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6870 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6871 of variables specific to SELinux and computation of `encoded_absname'.
6873 * image.c (XPutPixel): Remove unused variable `height'.
6875 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6877 * unexw32.c (get_section_info): Remove unused variable `section'.
6879 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6880 (system_process_attributes): Remove unused variable `sess'.
6881 (sys_read): Remove unused variable `err'.
6883 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6884 (w32_wnd_proc): Remove unused variable `isdead'.
6885 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6886 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6887 (x_create_tip_frame): Remove unused variable `tem'.
6889 * w32inevt.c (w32_console_read_socket):
6890 Remove unused variable `no_events'.
6892 * w32term.c (x_draw_composite_glyph_string_foreground):
6893 Remove unused variable `width'.
6895 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
6897 * w32term.c (x_set_glyph_string_clipping):
6898 Don't pass uninitialized region to CombineRgn.
6900 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
6902 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6903 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6904 (Fx_close_connection): Remove unused variable `i'.
6906 * w32font.c (w32font_draw): Return number of glyphs.
6907 (w32font_open_internal): Remove unused variable `i'.
6908 (w32font_driver): Add missing initializer.
6910 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6911 (fill_in_menu): Remove unused variable `items_added'.
6913 * w32term.c (last_mouse_press_frame): Remove static global variable.
6914 (w32_clip_to_row): Remove unused variable `f'.
6915 (x_delete_terminal): Remove unused variable `i'.
6917 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6918 (NOTHING): Remove unused static global variable.
6919 (uniscribe_check_otf): Remove unused variable `table'.
6920 (uniscribe_font_driver): Add missing initializers.
6922 2011-03-23 Julien Danjou <julien@danjou.info>
6924 * term.c (Fsuspend_tty, Fresume_tty):
6925 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6926 * window.c (temp_output_buffer_show):
6927 * insdel.c (signal_before_change):
6928 * frame.c (Fhandle_switch_frame):
6929 * fileio.c (Fdo_auto_save):
6930 * emacs.c (Fkill_emacs):
6931 * editfns.c (save_excursion_restore):
6932 * cmds.c (internal_self_insert):
6933 * callint.c (Fcall_interactively):
6934 * buffer.c (Fkill_all_local_variables):
6935 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6937 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
6938 unconditionnaly since it does the check itself.
6940 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
6942 Fix more problems found by GCC 4.5.2's static checks.
6944 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6945 the first time through the loop, since we know p0 < p1 then.
6946 This also avoids a gcc -Wstrict-overflow warning.
6948 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6949 leading to a memory leak, possible in functions like
6950 load_charset_map_from_file that can allocate an unbounded number
6951 of objects (Bug#8318).
6953 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6954 that could (at least in theory) be that large.
6956 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6957 This is less likely to overflow, and avoids undefined behavior if
6958 overflow does occur. All callers changed. Use strtoul to scan
6959 for the unsigned long integer.
6960 (pint2hrstr): Simplify and tune code slightly.
6961 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
6963 * scroll.c (do_scrolling): Work around GCC bug 48228.
6964 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6966 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6967 This also avoids a warning with gcc -Wstrict-overflow.
6968 (validate_x_resource_name): Simplify count usage.
6969 This also avoids a warning with gcc -Wstrict-overflow.
6971 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6974 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
6976 * process.c (Fmake_network_process): Use socklen_t, not int,
6977 where POSIX says socklen_t is required in portable programs.
6978 This fixes a porting bug on hosts like 64-bit HP-UX, where
6979 socklen_t is wider than int (Bug#8277).
6980 (Fmake_network_process, server_accept_connection):
6981 (wait_reading_process_output, read_process_output):
6984 * process.c: Rename or move locals to avoid shadowing.
6985 (list_processes_1, Fmake_network_process):
6986 (read_process_output_error_handler, exec_sentinel_error_handler):
6987 Rename or move locals.
6988 (Fmake_network_process): Define label "retry_connect" only if needed.
6989 (Fnetwork_interface_info): Fix pointer signedness.
6990 (process_send_signal): Add cast to avoid pointer signedness problem.
6991 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
6992 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
6994 Make tparam.h and terminfo.c consistent.
6995 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6996 Include tparam.h instead, since it declares them.
6997 * cm.h (PC): Remove extern decl; tparam.h now does this.
6998 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6999 * terminfo.c: Include tparam.h, to check interfaces.
7000 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7001 (tparam): Adjust signature to match interface in tparam.h;
7002 this removes some undefined behavior. Check that outstring and len
7003 are zero, which they always are with Emacs.
7004 * tparam.h (PC, BC, UP): New extern decls.
7006 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
7007 (xftfont_open): Rename locals to avoid shadowing.
7009 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
7010 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7011 (OTF_TAG_SYM): Omit macro if not needed.
7012 (ftfont_list): Remove unused local.
7013 (get_adstyle_property, ftfont_pattern_entity):
7014 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7015 Rename locals to avoid shadowing.
7017 * xfont.c (xfont_list_family): Mark var as initialized.
7019 * xml.c (make_dom): Now static.
7021 * composite.c (composition_compute_stop_pos): Rename local to
7023 (composition_reseat_it): Remove unused locals.
7024 (find_automatic_composition, composition_adjust_point): Likewise.
7025 (composition_update_it): Mark var as initialized.
7026 (find_automatic_composition): Mark vars as initialized,
7027 with a FIXME (Bug#8290).
7029 character.h: Rename locals to avoid shadowing.
7030 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7031 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7032 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7033 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7036 * textprop.c (property_change_between_p): Remove; unused.
7038 * intervals.c (interval_start_pos): Now static.
7040 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7042 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7043 Rename locals to avoid shadowing.
7045 * sound.c (wav_play, au_play, Fplay_sound_internal):
7046 Fix pointer signedness.
7047 (alsa_choose_format): Remove unused local var.
7048 (wav_play): Initialize a variable to 0, to prevent undefined
7049 behavior (Bug#8278).
7051 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7053 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7055 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7056 clobbering (Bug#8298).
7057 * sysdep.c (sys_subshell): Likewise.
7058 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7060 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7061 This should get cleaned up, so that child_setup has the
7062 same signature on all platforms.
7064 * callproc.c (call_process_cleanup): Now static.
7065 (relocate_fd): Rename locals to avoid shadowing.
7067 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
7069 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7070 not to be necessary, and produces flickering.
7072 2011-03-20 Glenn Morris <rgm@gnu.org>
7074 * config.in: Remove file.
7076 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
7078 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7079 are now in src/globals.h.
7080 (syms_of_minibuf): Remove spurious & from previous change.
7082 2011-03-20 Leo <sdl.web@gmail.com>
7084 * minibuf.c (completing-read-function): New variable.
7085 (completing-read-default): Rename from completing-read.
7086 (completing-read): Call completing-read-function.
7088 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7090 * xfaces.c (Fx_load_color_file):
7091 Read color file from absolute filename (bug#8250).
7093 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7095 * makefile.w32-in: Update dependencies.
7097 2011-03-17 Eli Zaretskii <eliz@gnu.org>
7099 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7101 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7103 Fix more problems found by GCC 4.5.2's static checks.
7105 * process.c (make_serial_process_unwind, send_process_trap):
7106 (sigchld_handler): Now static.
7108 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7109 That way, the code declares only the vars that it needs.
7110 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7111 * s/cygwin.h (PTY_ITERATION): Likewise.
7112 * s/darwin.h (PTY_ITERATION): Likewise.
7113 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7115 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7116 * process.c (allocate_pty): Don't declare stb unless it's needed.
7118 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
7119 (CONSTANTLIM): Remove; unused.
7120 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7121 Define only if needed.
7123 * unexelf.c (unexec): Name an expression,
7124 to avoid gcc -Wbad-function-cast warning.
7125 Use a different way to cause a compilation error if anyone uses
7126 n rather than nn, a way that does not involve shadowing.
7127 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
7129 * deps.mk (unexalpha.o): Remove; unused.
7131 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7132 * unexec.h: New file.
7133 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7134 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7136 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7137 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7138 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
7139 Change as necessary to match prototype in unexec.h.
7141 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7143 (back_comment, skip_chars): Mark vars as initialized.
7145 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7146 Rename locals to avoid shadowing.
7148 * lread.c (read1): Rewrite so as not to use empty "else".
7149 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
7151 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7153 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7154 warning when compiling print.c.
7156 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7157 instead of using an uninitialized var.
7158 (font_sort_entities): Mark var as initialized.
7160 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7162 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7163 pointers to constants.
7164 (font_parse_fcname): Remove unused vars.
7165 (font_delete_unmatched): Now static.
7166 (font_get_spec): Remove; unused.
7167 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7168 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7169 Rename or move locals to avoid shadowing.
7171 * fns.c (require_nesting_list, require_unwind): Now static.
7172 (Ffillarray): Rename locals to avoid shadowing.
7174 * floatfns.c (domain_error2): Define only if needed.
7175 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
7177 * alloc.c (mark_backtrace): Move decl from here ...
7178 * lisp.h: ... to here, so that it can be checked.
7180 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
7181 (Fdefvar): Rewrite so as not to use empty "else".
7182 (lisp_indirect_variable): Name an expression,
7183 to avoid gcc -Wbad-function-cast warning.
7184 (Fdefvar): Rename locals to avoid shadowing.
7186 * callint.c (quotify_arg, quotify_args): Now static.
7187 (Fcall_interactively): Rename locals to avoid shadowing.
7188 Use const pointer when appropriate.
7190 * lisp.h (get_system_name, get_operating_system_release):
7191 Move decls here, to check interfaces.
7192 * process.c (get_operating_system_release): Move decl to lisp.h.
7193 * xrdb.c (get_system_name): Likewise.
7194 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7195 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7196 some of which prompt warnings from gcc -Wbad-function-cast.
7197 (Fformat_time_string, Fencode_time, Finsert_char):
7198 (Ftranslate_region_internal, Fformat):
7199 Rename or remove local vars to avoid shadowing.
7200 (Ftranslate_region_internal): Mark var as initialized.
7202 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7205 * lisp.h (eassert): Check that the argument compiles, even if
7206 ENABLE_CHECKING is not defined.
7208 * data.c (Findirect_variable): Name an expression, to avoid
7209 gcc -Wbad-function-cast warning.
7210 (default_value, arithcompare, arith_driver, arith_error): Now static.
7211 (store_symval_forwarding): Rename local to avoid shadowing.
7212 (Fmake_variable_buffer_local, Fmake_local_variable):
7213 Mark variables as initialized.
7214 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
7216 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
7217 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7218 Rename locals to avoid shadowing.
7219 (mark_stack): Move local variables into the #ifdef region where
7221 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7222 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7224 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7225 (GC_STRING_CHARS): Remove; not used.
7226 (Fmemory_limit): Cast sbrk's returned value to char *.
7228 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7229 avoids undefined behavior in theory.
7231 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7233 Use functions, not macros, for up- and down-casing (Bug#8254).
7234 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7235 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7236 to use the following functions instead of these macros.
7237 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7238 EMACS_INT, since callers assume the returned value fits in int.
7239 (upcase1): Likewise, for UPCASE_TABLE.
7240 (uppercasep, lowercasep, upcase): New static inline functions.
7241 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
7242 the race-condition problem in the old DOWNCASE.
7244 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7245 Rename locals to avoid shadowing.
7246 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
7247 (regex_compile, re_search_2, re_match_2_internal):
7248 Remove unused local vars.
7249 (FREE_VAR): Rewrite so as not to use empty "else",
7250 which gcc can warn about.
7251 (regex_compile, re_match_2_internal): Mark locals as initialized.
7252 (RETALLOC_IF): Define only if needed.
7253 (WORDCHAR_P): Likewise. This one is never needed, but is used
7254 only in a comment talking about a compiler bug, so put inside
7255 the #if 0 of that comment.
7256 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7257 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7260 * search.c (boyer_moore): Rename locals to avoid shadowing.
7261 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7262 (PREV_CHAR_BOUNDARY): Likewise.
7264 * search.c (simple_search): Remove unused var.
7266 * dired.c (compile_pattern): Move decl from here ...
7267 * lisp.h: ... to here, so that it can be checked.
7268 (struct re_registers): New forward decl.
7270 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7272 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7274 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7275 Rename locals to avoid shadowing.
7276 (Fvertical_motion): Mark locals as initialized.
7278 * casefiddle.c (casify_object, casify_region): Now static.
7279 (casify_region): Mark local as initialized.
7281 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7283 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7284 New macros, so that the caller can use some names other than
7285 gcpro1, gcpro2, etc.
7286 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7288 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7289 argument, for consistency with GCPRO2_VAR, etc: it is now the
7290 prefix of the variable, not the variable itself. All uses
7292 * dired.c (directory_files_internal, file_name_completion):
7293 Rename locals to avoid shadowing.
7295 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7296 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7297 dired.c's scmp function, had undefined behavior.
7298 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7299 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7300 * buffer.h: ... to here, because these macros use current_buffer,
7301 and the new implementation with inline functions needs to have
7302 current_buffer in scope now, rather than later when the macros
7304 (downcase, upcase1): New static inline functions.
7305 (DOWNCASE, UPCASE1): Reimplement using these functions.
7306 This avoids undefined behavior in expressions like
7307 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7308 from race conditions in accessing the global variables
7309 case_temp1 and case_temp2.
7310 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7311 * lisp.h (case_temp1, case_temp2): Remove their decls.
7312 * character.h (ASCII_CHAR_P): Move from here ...
7313 * lisp.h: ... to here, so that the inline functions mentioned
7316 * dired.c (directory_files_internal_unwind): Now static.
7318 * fileio.c (file_name_as_directory, directory_file_name):
7319 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7321 (file_name_as_directory): Use const pointers when appropriate.
7322 (Fexpand_file_name): Likewise. In particular, newdir might
7323 point at constant storage, so make it a const pointer.
7324 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
7325 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7327 (Fset_file_times, Finsert_file_contents, auto_save_error):
7328 Rename locals to avoid shadowing.
7330 * minibuf.c (choose_minibuf_frame_1): Now static.
7331 (Ftry_completion, Fall_completions): Rename or remove locals
7334 * marker.c (bytepos_to_charpos): Remove; unused.
7336 * lisp.h (verify_bytepos, count_markers): New decls,
7337 so that gcc does not warn that these functions aren't declared.
7339 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7340 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
7341 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
7342 (copy_text): Remove unused local var.
7344 * filelock.c (within_one_second): Now static.
7345 (lock_file_1): Rename local to avoid shadowing.
7347 * buffer.c (fix_overlays_before): Mark locals as initialized.
7348 (fix_start_end_in_overlays): Likewise. This function should be
7349 simplified by using pointers-to-pointers, but that's a different
7351 (switch_to_buffer_1): Now static.
7352 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7353 (report_overlay_modification): Rename locals to avoid shadowing.
7355 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
7356 Fix pointer signedness issue.
7357 (sys_subshell): Mark local as volatile if checking for lint,
7358 to suppress a gcc -Wclobbered warning that does not seem to be right.
7359 (MAXPATHLEN): Define only if needed.
7361 * process.c (serial_open, serial_configure): Move decls from here ...
7362 * systty.h: ... to here, so that they can be checked.
7364 * fns.c (get_random, seed_random): Move extern decls from here ...
7365 * lisp.h: ... to here, so that they can be checked.
7367 * sysdep.c (reset_io): Now static.
7368 (wait_for_termination_signal): Remove; unused.
7370 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7371 (copy_keymap_item, append_key, push_text_char_description):
7373 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
7374 (DENSE_TABLE_SIZE): Remove; unused.
7375 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7376 (describe_map_tree):
7377 Rename locals to avoid shadowing.
7379 * keyboard.c: Declare functions static if they are not used elsewhere.
7380 (echo_char, echo_dash, cmd_error, top_level_2):
7381 (poll_for_input, handle_async_input): Now static.
7382 (read_char, kbd_buffer_get_event, make_lispy_position):
7383 (make_lispy_event, make_lispy_movement, apply_modifiers):
7384 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7385 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7386 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
7387 (read_key_sequence, read_char): Mark locals as initialized.
7388 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
7390 * keyboard.h (make_ctrl_char): New decl.
7391 (mark_kboards): Move decl here ...
7392 * alloc.c (mark_kboards): ... from here.
7394 * lisp.h (force_auto_save_soon): New decl.
7396 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
7397 (DEFINE_DUMMY_FUNCTION): New macro.
7398 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7400 (main): Add casts to avoid warnings
7401 if GCC considers string literals to be constants.
7403 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7405 * dbusbind.c: Pointer signedness fixes.
7406 (xd_signature, xd_append_arg, xd_initialize):
7407 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7408 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7409 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7410 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7412 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7413 if GCC considers string literals to be constants.
7414 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
7416 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7418 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7419 (print_preprocess, print_object): New macro to fix last change.
7421 * print.c (print_preprocess): Don't forget font objects.
7423 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
7425 * emacs.c (USAGE3): Doc fixes.
7427 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7429 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7432 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
7434 * lisp.h (VWindow_system, Qfile_name_history):
7435 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7436 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7437 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7439 * w32select.c: Don't #include "keyboard.h".
7440 (run_protected): Add extern declaration for waiting_for_input.
7442 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7443 * w32console.c (detect_input_pending, read_input_pending)
7444 (encode_terminal_code):
7445 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7446 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7447 (w32_system_caret_y, Qfile_name_history):
7448 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7449 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7450 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7451 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7452 * w32proc.c (Qlocal, report_file_error):
7453 * w32term.c (Vwindow_system, updating_frame):
7454 * w32uniscribe.c (initialized, uniscribe_font_driver):
7455 Remove unneeded extern declarations.
7457 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
7459 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
7461 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
7463 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7464 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7465 These macros can no longer be used for assignment.
7467 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7468 Assign struct members directly, instead of using BUF_BEGV etc.
7469 (record_buffer_markers, fetch_buffer_markers): New functions for
7470 recording and fetching special buffer markers.
7471 (set_buffer_internal_1, set_buffer_temp): Use them.
7473 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7475 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7477 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7478 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7480 * xdisp.c (hscroll_window_tree):
7481 (reconsider_clip_changes): Use PT instead of BUF_PT.
7483 2011-03-13 Eli Zaretskii <eliz@gnu.org>
7485 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7486 $(EMACS_ROOT)/lib/intprops.h.
7488 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7490 Fix more problems found by GCC 4.5.2's static checks.
7492 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7493 to unsigned char * to avoid compiler diagnostic.
7494 (xg_free_frame_widgets): Make it clear that a local variable is
7495 needed only if USE_GTK_TOOLTIP.
7496 (gdk_window_get_screen): Make it clear that this macro is needed
7497 only if USE_GTK_TOOLTIP.
7498 (int_gtk_range_get_value): New function, which avoids a diagnostic
7499 from gcc -Wbad-function-cast.
7500 (xg_set_toolkit_scroll_bar_thumb): Use it.
7501 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7502 diagnostic from gcc -Wbad-function-cast.
7503 (get_utf8_string, xg_get_file_with_chooser):
7504 Rename locals to avoid shadowing.
7505 (create_dialog): Move locals to avoid shadowing.
7507 * xgselect.c (xg_select): Remove unused var.
7509 * image.c (four_corners_best): Mark locals as initialized.
7510 (gif_load): Initialize transparent_p to zero (Bug#8238).
7511 Mark another local as initialized.
7512 (my_png_error, my_error_exit): Mark with NO_RETURN.
7514 * image.c (clear_image_cache): Now static.
7515 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
7516 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
7517 (x_edge_detection): Remove unnecessary cast that
7518 gcc -Wbad-function-cast diagnoses.
7519 (gif_load): Fix pointer signedness.
7520 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7521 (jpeg_load, gif_load): Rename locals to avoid shadowing.
7523 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
7525 Improve quality of tests for time stamp overflow.
7526 For example, without this patch (encode-time 0 0 0 1 1
7527 1152921504606846976) returns the obviously-bogus value (-948597
7528 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7529 reports time overflow. See
7530 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
7531 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7532 * editfns.c: Include limits.h and intprops.h.
7533 (TIME_T_MIN, TIME_T_MAX): New macros.
7534 (time_overflow): Move earlier, to before first use.
7535 (hi_time, lo_time): New functions, for an accurate test for
7537 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7538 (Fget_internal_run_time): Don't assume time_t fits in int.
7539 (make_time): Use list2 instead of Fcons twice.
7540 (Fdecode_time): More accurate test for out-of-range times.
7541 (check_tm_member): New function.
7542 (Fencode_time): Use it, to test for out-of-range times.
7543 (lisp_time_argument): Don't rely on undefined left-shift and
7544 right-shift behavior when checking for time stamp overflow.
7546 * editfns.c (time_overflow): New function, refactoring common code.
7547 (Fformat_time_string, Fdecode_time, Fencode_time):
7548 (Fcurrent_time_string): Use it.
7550 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7551 * dired.c (make_time): Move to ...
7552 * editfns.c (make_time): ... here.
7553 * systime.h: Note the move.
7555 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7557 * fringe.c (update_window_fringes): Remove unused variables.
7559 * unexmacosx.c (copy_data_segment): Also copy __got section.
7562 2011-03-12 Eli Zaretskii <eliz@gnu.org>
7564 * termcap.c [MSDOS]: Include "msdos.h".
7565 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7566 Constify `char *' arguments and their references according to
7567 prototypes in tparam.h.
7569 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
7571 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7572 Adapt all references accordingly.
7574 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7576 2011-03-11 Tom Tromey <tromey@redhat.com>
7578 * buffer.c (syms_of_buffer): Remove obsolete comment.
7580 2011-03-11 Eli Zaretskii <eliz@gnu.org>
7582 * termhooks.h (encode_terminal_code): Declare prototype.
7584 * msdos.c (encode_terminal_code): Don't declare prototype.
7586 * term.c (encode_terminal_code): Now external again, used by
7587 w32console.c and msdos.c.
7589 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7590 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7592 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
7594 Fix some minor problems found by GCC 4.5.2's static checks.
7596 * fringe.c (update_window_fringes): Mark locals as initialized
7598 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
7600 * alloc.c (mark_fringe_data): Move decl from here ...
7601 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7602 to check its interface.
7603 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7605 * fontset.c (free_realized_fontset): Now static.
7606 (Fset_fontset_font): Rename local to avoid shadowing.
7607 (fontset_font): Mark local as initialized.
7608 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
7610 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7612 * xselect.c (x_disown_buffer_selections): Remove; not used.
7613 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
7614 (x_own_selection, Fx_disown_selection_internal): Rename locals
7616 (x_handle_dnd_message): Remove local to avoid shadowing.
7618 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7619 so that the caller can use some name other than gcpro1.
7620 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
7621 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7622 (Fx_backspace_delete_keys_p):
7623 Use them to avoid shadowing, and rename vars to avoid shadowing.
7624 (x_decode_color, x_set_name, x_window): Now static.
7625 (Fx_create_frame): Add braces to silence GCC warning.
7626 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
7627 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7628 Remove unused locals.
7629 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7630 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7631 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7634 * xterm.h (x_mouse_leave): New decl.
7636 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7637 Remove unused functions.
7638 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7639 (x_calc_absolute_position): Now static.
7640 (XTread_socket): Don't define label "out" unless it's used.
7641 Don't declare local "event" unless it's used.
7642 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7643 unless they are used.
7644 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7645 (x_fatal_error_signal): Remove; not used.
7646 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7647 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7648 (x_error_catcher, x_connection_closed, x_error_handler):
7649 (x_error_quitter, xembed_send_message, x_iconify_frame):
7650 (my_log_handler): Rename locals to avoid shadowing.
7651 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
7652 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
7654 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7655 Rename or move locals to avoid shadowing.
7656 (tty_defined_color, merge_face_heights): Now static.
7657 (free_realized_faces_for_fontset): Remove; not used.
7658 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7659 does not deduce is never used uninitialized.
7660 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7661 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
7663 * terminal.c (store_terminal_param): Now static.
7665 * xmenu.c (menu_highlight_callback): Now static.
7666 (set_frame_menubar): Remove unused local.
7667 (xmenu_show): Rename parameter to avoid shadowing.
7668 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7669 since they might point to immutable storage.
7670 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7671 since it's unused otherwise.
7673 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
7674 Add a FIXME, since the code still doesn't look right. (Bug#8215)
7675 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7676 avoids a gcc -Wuninitialized diagnostic.
7677 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
7678 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7679 does not deduce are never used uninitialized.
7681 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7683 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
7684 * window.c (window_loop, size_window):
7685 (run_window_configuration_change_hook, enlarge_window): Likewise.
7687 * window.c (display_buffer): Now static.
7688 (size_window): Mark variables that gcc -Wuninitialized
7689 does not deduce are never used uninitialized.
7690 * window.h (check_all_windows): New decl, to forestall
7691 gcc -Wmissing-prototypes diagnostic.
7692 * dispextern.h (bidi_dump_cached_states): Likewise.
7694 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7696 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
7698 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7699 and to avoid gcc -Wuninitialized warning.
7700 (load_charset_map): Mark variables that gcc -Wuninitialized
7701 does not deduce are never used uninitialized.
7702 (load_charset): Abort instead of using uninitialized var (Bug#8229).
7704 * coding.c (coding_set_source, coding_set_destination):
7705 Use "else { /* comment */ }" rather than "else /* comment */;"
7706 for clarity, and to avoid gcc -Wempty-body warning.
7707 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7708 a block, when the outer 'i' will do.
7709 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7710 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7711 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7712 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7713 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7714 Rename locals to avoid shadowing.
7715 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
7716 * coding.c (emacs_mule_char, encode_invocation_designation):
7717 Now static, since they're not used elsewhere.
7718 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
7719 (decode_coding_object, encode_coding_object, detect_coding_system):
7720 (decode_coding_emacs_mule): Mark variables that gcc
7721 -Wuninitialized does not deduce are never used uninitialized.
7722 (detect_coding_iso_2022): Initialize a local variable that might
7723 be used uninitialized. Leave a FIXME because it's not clear that
7724 this initialization is needed. (Bug#8211)
7725 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7726 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7727 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7728 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7729 Remove unused macros.
7731 * category.c (hash_get_category_set): Remove unused local var.
7732 (copy_category_table): Now static, since it's not used elsewhere.
7733 * character.c (string_count_byte8): Likewise.
7735 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7736 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7738 * chartab.c (copy_sub_char_table): Now static, since it's not used
7740 (sub_char_table_ref_and_range, char_table_ref_and_range):
7741 Rename locals to avoid shadowing.
7742 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
7744 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
7745 (BIDI_BOB): Remove unused macro.
7747 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7748 deduce are never used uninitialized.
7749 * term.c (encode_terminal_code): Likewise.
7751 * term.c (encode_terminal_code): Now static. Remove unused local.
7753 * tparam.h: New file.
7754 * term.c, tparam.h: Include it.
7755 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7756 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7757 Move these decls to tparam.h, and make them agree with what
7758 is actually in tparam.c. The previous trick of using incompatible
7759 decls in different modules does not conform to the C standard.
7760 All callers of tparam changed to use tparam's actual API.
7761 * tparam.c (tparam1, tparam, tgoto):
7762 Use const pointers where appropriate.
7764 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7765 * cm.h (struct cm): Likewise.
7766 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7767 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7768 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7769 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7770 (turn_on_face, init_tty): Likewise.
7771 * termchar.h (struct tty_display_info): Likewise.
7773 * term.c (term_mouse_position): Rename local to avoid shadowing.
7775 * alloc.c (mark_ttys): Move decl from here ...
7776 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7778 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7780 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7782 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
7784 * search.c (compile_pattern_1): Remove argument regp, unused since
7785 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7786 (compile_pattern): Don't pass it.
7788 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7790 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7791 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7793 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7795 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7797 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7798 gdk_window_get_screen, gdk_window_get_geometry,
7799 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7800 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7801 (xg_get_pixbuf_from_pixmap): New function.
7802 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7803 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7804 Call xg_get_pixbuf_from_pixmap instead of
7805 gdk_pixbuf_get_from_drawable.
7806 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7807 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7808 (xg_check_special_colors): Use GtkStyleContext and its functions
7810 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7811 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7812 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
7813 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7814 Call gtk_widget_get_preferred_size.
7815 (xg_frame_resized): gdk_window_get_geometry only takes 5
7817 (xg_win_to_widget, xg_event_is_for_menubar):
7818 Call gdk_x11_window_lookup_for_display.
7819 (xg_set_widget_bg): New function.
7820 (delete_cb): New function.
7821 (xg_create_frame_widgets): Connect delete-event to delete_cb.
7822 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7823 (xg_set_background_color): Call xg_set_widget_bg.
7824 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7825 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7826 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7827 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7829 (update_frame_tool_bar): Call gtk_widget_hide.
7830 (xg_initialize): Use GDK_KEY_g.
7832 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7834 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7836 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7837 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7838 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7840 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
7842 * w32xfns.c (select_palette): Check success of RealizePalette against
7843 GDI_ERROR, not zero.
7845 See ChangeLog.11 for earlier changes.
7851 Copyright (C) 2011 Free Software Foundation, Inc.
7853 This file is part of GNU Emacs.
7855 GNU Emacs is free software: you can redistribute it and/or modify
7856 it under the terms of the GNU General Public License as published by
7857 the Free Software Foundation, either version 3 of the License, or
7858 (at your option) any later version.
7860 GNU Emacs is distributed in the hope that it will be useful,
7861 but WITHOUT ANY WARRANTY; without even the implied warranty of
7862 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7863 GNU General Public License for more details.
7865 You should have received a copy of the GNU General Public License
7866 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.