1 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
3 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
4 before checking whether it's out of range. Put the check inside
6 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
8 2012-05-27 Ken Brown <kbrown@cornell.edu>
10 * callproc.c (Fcall_process): Restore a line that was accidentally
11 commented out in the 2011-02-13 change (bug#11547).
13 2012-05-27 Eli Zaretskii <eliz@gnu.org>
15 * lisp.h [REL_ALLOC]: Add prototypes for external functions
18 * buffer.c [REL_ALLOC]: Remove prototypes of
19 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
20 they are now on lisp.h.
22 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
24 * search.c (search_buffer): Use it to inhibit relocation of buffer
25 text while re_search_2 is doing its job, because re_search_2 is
26 passed C pointers to buffer text. (Bug#11519)
28 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
31 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
32 state after an additional call to move_it_in_display_line_to, keep
33 the values of it->max_ascent and it->max_descent found for the
35 (pos_visible_p): Revert the comparison against bottom_y to what it
36 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
39 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
41 Fix coding-related core dumps with gcc -ftrapv.
42 The code was computing A - B, where A and B are pointers, and B is
43 random garbage. This can lead to core dumps on platforms that
44 have special pointer registers, and it also leads to core dumps on
45 x86-64 when compiled with gcc -ftrapv. The fix is to compute
46 A - B only when B is initialized properly.
47 * coding.c (coding_set_source, coding_set_destination): Return void.
48 (coding_change_source, coding_change_destinations): New functions,
49 with the old behaviors of coding_set_source and coding_set_destination.
50 All callers that need an offset changed to use these new functions.
52 2012-05-26 Glenn Morris <rgm@gnu.org>
54 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
56 2012-05-26 Eli Zaretskii <eliz@gnu.org>
58 Extend mouse support on W32 text-mode console.
59 * xdisp.c (draw_row_with_mouse_face): Call
60 tty_draw_row_with_mouse_face for WINDOWSNT as well.
62 * w32console.c: Include window.h.
63 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face): New
65 (initialize_w32_display): Initialize mouse-highlight data.
67 * w32inevt.c: Include termchar.h and window.h.
68 (do_mouse_event): Support mouse-autoselect-window. When the mouse
69 moves, call note_mouse_highlight. If help_echo changed, call
70 gen_help_event to produce help-echo message in the echo area.
71 Call clear_mouse_face if mouse_face_hidden is set in the mouse
74 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
76 * lread.c (read1): Simplify slightly to avoid an overflow warning
77 with GCC 4.7.0 on x86-64.
79 2012-05-26 Eli Zaretskii <eliz@gnu.org>
81 * bidi.c (bidi_mirror_char): Revert last change: an int is
82 definitely wide enough here.
84 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
86 Fix integer width and related bugs (Bug#9874).
87 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
88 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
89 (string_bytes, check_sblock, allocate_string_data):
90 (compact_small_strings, Fmake_bool_vector, make_string)
91 (make_unibyte_string, make_multibyte_string)
92 (make_string_from_bytes, make_specified_string)
93 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
94 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
96 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
97 (allocate_pseudovector):
98 Use int, not EMACS_INT, where int is wide enough.
99 (inhibit_garbage_collection, Fgarbage_collect):
100 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
101 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
102 int might not be wide enough.
103 (bidi_cache_search, bidi_cache_find, bidi_init_it)
104 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
105 (bidi_at_paragraph_end, bidi_find_paragraph_start)
106 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
107 (bidi_level_of_next_char, bidi_move_to_visually_next):
108 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
109 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
110 (Fkill_buffer, Fset_buffer_major_mode)
111 (advance_to_char_boundary, Fbuffer_swap_text)
112 (Fset_buffer_multibyte, overlays_at, overlays_in)
113 (overlay_touches_p, struct sortvec, record_overlay_string)
114 (overlay_strings, recenter_overlay_lists)
115 (adjust_overlays_for_insert, adjust_overlays_for_delete)
116 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
117 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
118 (Foverlay_recenter, last_overlay_modification_hooks_used)
119 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
120 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
121 (validate_region): Omit unnecessary test for b <= e,
122 since that's guaranteed by the previous test.
123 (adjust_overlays_for_delete): Avoid pos + length overflow.
124 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
125 (report_overlay_modification):
126 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
127 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
128 Omit pointer cast, which isn't needed anyway, and doesn't work
129 after the EMACS_INT -> ptrdiff_t change.
130 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
131 * buffer.h: Adjust decls to match defn changes elsewhere.
132 (struct buffer_text, struct buffer):
133 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
134 Use EMACS_INT, not int, where int might not be wide enough.
135 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
136 not int, to avoid needless 32-bit limit on 64-bit hosts.
137 (exec_byte_code): Use tighter memory-full test, one that checks
138 for alloca overflow. Don't compute the address of the object just
139 before an array, as that's not portable. Use EMACS_INT, not
140 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
141 * callint.c (Fcall_interactively):
142 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
143 * callproc.c (call_process_kill, Fcall_process):
144 Don't assume pid_t fits into an Emacs fixnum.
145 (call_process_cleanup, Fcall_process, child_setup):
146 Don't assume pid_t fits into int.
147 (call_process_cleanup, Fcall_process, delete_temp_file)
148 (Fcall_process_region):
149 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
150 (Fcall_process): Simplify handling of volatile integers.
151 Use int, not EMACS_INT, where int will do.
152 * casefiddle.c (casify_object, casify_region, operate_on_word)
153 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
154 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
155 (casify_object): Avoid integer overflow when overallocating buffer.
156 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
157 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
158 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
159 * category.h (CATEGORYP): Don't assume arg is nonnegative.
160 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
161 integers are now checked earlier. All uses replaced with XINT.
163 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
164 For CCL_MapSingle, check that content and value are in int range.
165 (ccl_driver, Fregister_code_conversion_map):
166 Check that Vcode_version_map_vector is a vector.
167 (resolve_symbol_ccl_program): Check that vector header is in range.
168 Always copy the vector, so that we can check its contents reliably
169 now rather than having to recheck each instruction as it's being
170 executed. Check that vector words fit in 'int'.
171 (ccl_get_compiled_code, Fregister_ccl_program)
172 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
173 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
174 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
175 contents are in range.
176 (Fccl_execute_on_string): Check that status is in range.
177 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
178 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
179 Accept and return EMACS_INT, not int, because callers can pass values
181 (c_string_width, strwidth, lisp_string_width, chars_in_text)
182 (multibyte_chars_in_text, parse_str_as_multibyte)
183 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
184 (str_as_unibyte, str_to_unibyte, string_count_byte8)
185 (string_escape_byte8, Fget_byte):
186 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
187 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
188 avoid mishandling large integers.
189 * character.h: Adjust decls to match defn changes elsewhere.
190 * charset.c (load_charset_map_from_file, find_charsets_in_text)
191 (Ffind_charset_region):
192 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
193 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
194 (load_charset_map_from_vector, Fdefine_charset_internal):
195 Don't assume fixnum fits in int.
196 (load_charset_map_from_vector, Fmap_charset_chars):
197 Remove now-unnecessary CHECK_NATNUMs.
198 (Fdefine_charset_internal): Check ranges here, more carefully.
199 Don't rely on undefined behavior with signed left shift overflow.
200 Don't assume unsigned int fits into fixnum, or that fixnum fits
201 into unsigned int. Don't require max_code to be a valid fixnum;
202 that's not true for gb10830 4-byte on a 32-bit host. Allow
203 invalid_code to be a cons, for the same reason. Require code_offset
204 to be a character. Avoid int overflow if max_char is close
206 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
207 this is intended anyway and avoids some undefined behavior.
208 (load_charset_map): Pass unsigned, not int, as 2nd arg of
209 INDEX_TO_CODE_POINT, as that's what it expects.
210 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
211 * charset.h (DECODE_CHAR): Return int, not unsigned;
212 this is what was intended anyway, and it avoids undefined behavior.
213 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
214 integer-overflow issues.
215 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
216 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
217 where the argument is EMACS_INT, and this behavior is not intended.
218 * chartab.c (Fmake_char_table, Fset_char_table_range)
219 (uniprop_get_decoder, uniprop_get_encoder):
220 Don't assume fixnum fits in int.
221 * cmds.c (move_point): New function, that does the gist of
222 Fforward_char and Fbackward_char, but does so while checking
223 for integer overflow more accurately.
224 (Fforward_char, Fbackward_char): Use it.
225 (Fforward_line, Fend_of_line, internal_self_insert)
226 (internal_self_insert):
227 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
228 Fix a FIXME, by checking for integer overflow when calculating
229 target_clm and actual_clm.
230 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
231 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
232 (ASSURE_DESTINATION, coding_alloc_by_realloc)
233 (coding_alloc_by_making_gap, alloc_destination)
234 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
235 (encode_coding_utf_16, detect_coding_emacs_mule)
236 (decode_coding_emacs_mule, encode_coding_emacs_mule)
237 (detect_coding_iso_2022, decode_coding_iso_2022)
238 (encode_invocation_designation, encode_designation_at_bol)
239 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
240 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
241 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
242 (encode_coding_ccl, encode_coding_raw_text)
243 (detect_coding_charset, decode_coding_charset)
244 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
245 (produce_composition, produce_charset, produce_annotation)
246 (decode_coding, handle_composition_annotation)
247 (handle_charset_annotation, consume_chars, decode_coding_gap)
248 (decode_coding_object, encode_coding_object, detect_coding_system)
249 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
250 (code_convert_region, code_convert_string)
251 (Fdefine_coding_system_internal)
252 (coding_set_source, coding_set_destination):
253 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
254 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
255 (Fdefine_coding_system_internal):
256 Don't assume fixnums fit in int.
257 (decode_coding_gap, decode_coding_object, encode_coding_object)
258 (Fread_coding_system, Fdetect_coding_region)
259 (Funencodable_char_position, Fcheck_coding_systems_region)
260 (get_translation, handle_composition_annotation, consume_chars):
261 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
262 (consume_chars): Rewrite to not calculate an address outside buffer.
263 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
264 Don't access memory outside of the args array.
265 (Fdefine_coding_system_internal): Check for charset-id overflow.
266 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
267 result of ENCODE_CHAR.
268 * coding.h: Adjust decls to match defn changes elsewhere.
269 (struct coding_system):
270 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
271 * composite.c (get_composition_id, find_composition)
272 (run_composition_function, update_compositions)
273 (compose_text, composition_gstring_put_cache)
274 (composition_gstring_p, composition_gstring_width)
275 (fill_gstring_header, fill_gstring_body, autocmp_chars)
276 (composition_compute_stop_pos, composition_reseat_it)
277 (composition_update_it, struct position_record)
278 (find_automatic_composition, composition_adjust_point)
279 (Fcomposition_get_gstring, Ffind_composition_internal):
280 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
281 (update_compositions):
282 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
283 * composite.h: Adjust decls to match defn changes elsewhere.
284 (struct composition):
285 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
286 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
287 Do not attempt to compute the address of the object just before a
288 buffer; this is not portable.
290 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
291 (Faset): Use int, not EMACS_INT, where int is wide enough.
292 (Fstring_to_number): Don't assume fixnums fit in int.
293 (Frem): Don't assume arg is nonnegative.
294 * dbusbind.c (xd_append_arg): Check for integers out of range.
295 (Fdbus_call_method): Don't overflow the timeout int.
296 (extract_signed, extract_unsigned): New functions.
297 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
298 (xd_get_connection_references): Return ptrdiff_t, not int.
300 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
302 Use int, not unsigned, where the dbus API uses int.
303 (Fdbus_message_internal): Don't overflow mtype.
304 (syms_of_dbusbind): Allocate right-sized buffer for integers.
305 * dired.c (directory_files_internal, file_name_completion, scmp)
306 (file_name_completion_stat):
307 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
308 (file_name_completion): Don't overflow matchcount.
309 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
310 * dispextern.h: Adjust decls to match defn changes elsewhere.
311 (struct text_pos, struct glyph, struct bidi_saved_info)
312 (struct bidi_string_data, struct bidi_it, struct composition_it)
314 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
315 (struct display_pos, struct composition_it, struct it):
316 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
317 * dispnew.c (increment_matrix_positions)
318 (increment_row_positions, mode_line_string)
319 (marginal_area_string):
320 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
321 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
322 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
323 (duration_to_sec_usec): New function, to check for overflow better.
324 (Fsleep_for, sit_for): Use it.
325 * doc.c (get_doc_string, store_function_docstring):
326 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
327 (get_doc_string, Fsnarf_documentation):
328 Use int, not EMACS_INT, where int is wide enough.
330 Use SAFE_ALLOCA, not alloca.
331 Check for overflow when converting EMACS_INT to off_t.
333 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
334 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
335 Don't assume uid_t fits into fixnum.
336 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
337 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
338 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
339 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
340 (general_insert_function)
341 (Finsert_char, make_buffer_string, make_buffer_string_both)
342 (update_buffer_properties, Fbuffer_substring)
343 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
344 (Fsubst_char_in_region, check_translation)
345 (Ftranslate_region_internal, save_restriction_restore, Fformat)
346 (transpose_markers, Ftranspose_regions):
347 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
348 (clip_to_bounds): Move to lisp.h as an inline function).
349 (Fconstrain_to_field): Don't assume integers are nonnegative.
350 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
351 (Fsubst_char_in_region, Fsave_restriction):
352 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
353 (Femacs_pid): Don't assume pid_t fits into fixnum.
354 (lo_time): Use int, not EMACS_INT, when int suffices.
355 (lisp_time_argument): Check for usec out of range.
356 (Fencode_time): Don't assume fixnum fits in int.
357 (Fuser_login_name, Fuser_full_name): Signal an error
358 if a uid argument is out of range, rather than relying on
360 (Fformat_time_string): Remove now-unnecessary check.
361 lisp_time_argument checks for out-of-range usec now.
362 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
363 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
364 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
365 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
366 (init_cmdargs, Fdump_emacs):
367 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
368 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
369 the bottom (typically) 32 bits of the fixnum.
370 * eval.c (specpdl_size, call_debugger):
371 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
372 (when_entered_debugger, Fbacktrace_debug):
373 Don't assume fixnum can fit in int.
374 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
375 the object just before a buffer; this is not portable.
376 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
377 (grow_specpdl, unbind_to):
378 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
379 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
380 (grow_specpdl): Simplify allocation by using xpalloc.
381 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
382 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
383 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
384 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
385 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
387 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
388 (Fcopy_file, non_regular_nbytes, read_non_regular)
389 (Finsert_file_contents):
390 Use int, not EMACS_INT, where int is wide enough.
391 (READ_BUF_SIZE): Verify that it fits in int.
392 (Finsert_file_contents): Check that counts are in proper range,
393 rather than assuming fixnums fit into ptrdiff_t etc.
394 Don't assume fixnums fit into int.
395 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
396 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
397 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
398 (string_char_to_byte, string_byte_to_char)
399 (string_make_multibyte, string_to_multibyte)
400 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
401 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
402 (substring_both, Fdelete, internal_equal, Ffillarray)
403 (Fclear_string, mapcar1)
404 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
405 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
406 (larger_vector, make_hash_table, maybe_resize_hash_table)
407 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
408 (Fmaphash, secure_hash):
409 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
410 (concat): Check for string index and length overflow.
411 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
413 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
414 (larger_vector): New API (vec, incr_min, size_max) replaces old
415 one (vec, new_size, init). This catches size overflow.
416 INIT was removed because it was always Qnil.
418 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
419 the upper bound on a hash table index size.
420 (make_hash_table, maybe_resize_hash_table): Use it.
421 (secure_hash): Computer start_byte and end_byte only after
422 they're known to be in ptrdiff_t range.
423 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
424 (Ffont_get_glyphs, Ffont_at):
425 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
426 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
427 (Flist_fonts, Fopen_font):
428 Don't assume fixnum can fit in int.
429 (check_gstring): Don't assume index can fit in int.
430 (font_match_p): Check that fixnum is a character, not a nonnegative
431 fixnum, since the later code needs to stuff it into an int.
432 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
433 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
434 conversion overflow issues.
435 (Fopen_font): Check for integer out of range.
436 (Ffont_get_glyphs): Don't assume index can fit in int.
437 * font.h: Adjust decls to match defn changes elsewhere.
438 * fontset.c (reorder_font_vector): Redo score calculation to avoid
440 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
441 printmax_t, where ptrdiff_t is wide enough.
442 (Finternal_char_font):
443 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
444 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
445 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
446 (Fset_frame_position, x_set_frame_parameters)
447 (x_set_line_spacing, x_set_border_width)
448 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
449 Check that fixnums are in proper range for system types.
450 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
451 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
452 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
453 Use SAFE_ALLOCA_LISP, not alloca.
454 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
455 intptr_t is wide enough.
456 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
457 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
458 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
459 Check for fixnum out of range.
460 * ftfont.c (ftfont_list): Don't assume index fits in int.
461 Check that fixnums are in proper range for system types.
462 (ftfont_shape_by_flt):
463 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
464 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
465 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
466 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
467 Check that fixnums are in proper range for system types.
468 * gnutls.h: Adjust decls to match defn changes elsewhere.
469 * gtkutil.c (xg_dialog_run):
470 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
471 (update_frame_tool_bar):
472 Check that fixnums are in proper range for system types.
473 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
474 (lookup_image): Check that fixnums are in range for system types.
475 * indent.c (last_known_column, last_known_column_point):
476 (current_column_bol_cache):
477 (skip_invisible, current_column, check_display_width):
478 (check_display_width, scan_for_column, current_column_1)
479 (Findent_to, Fcurrent_indentation, position_indentation)
480 (indented_beyond_p, Fmove_to_column, compute_motion):
481 (Fcompute_motion, Fvertical_motion):
482 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
483 (last_known_column_modified): Use EMACS_INT, not int.
484 (check_display_width):
486 Check that fixnums and floats are in proper range for system types.
487 (compute_motion): Don't assume index or fixnum fits in int.
488 (compute_motion, Fcompute_motion):
489 Use int, not EMACS_INT, when it is wide enough.
490 (vmotion): Omit local var start_hpos that is always 0; that way
491 we don't need to worry about overflow in expressions involving it.
492 * indent.h: Adjust decls to match defn changes elsewhere.
494 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
495 Use int, not EMACS_INT, where int is wide enough.
496 Remove unused members ovstring_chars_done and tab_offset;
498 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
499 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
500 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
501 (make_gap, copy_text, insert, insert_and_inherit)
502 (insert_before_markers, insert_before_markers_and_inherit)
503 (insert_1, count_combining_before, count_combining_after)
504 (insert_1_both, insert_from_string)
505 (insert_from_string_before_markers, insert_from_string_1)
506 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
507 (adjust_after_replace, adjust_after_insert, replace_range)
508 (replace_range_2, del_range, del_range_1, del_range_byte)
509 (del_range_both, del_range_2, modify_region)
510 (prepare_to_modify_buffer, signal_before_change)
511 (signal_after_change, Fcombine_after_change_execute):
512 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
513 * intervals.c (traverse_intervals, rotate_right, rotate_left)
514 (balance_an_interval, split_interval_right, split_interval_left)
515 (find_interval, next_interval, update_interval)
516 (adjust_intervals_for_insertion, delete_node, delete_interval)
517 (interval_deletion_adjustment, adjust_intervals_for_deletion)
518 (static_offset_intervals, offset_intervals)
519 (merge_interval_right, merge_interval_left, make_new_interval)
520 (graft_intervals_into_buffer, temp_set_point_both)
521 (temp_set_point, set_point, adjust_for_invis_intang)
522 (set_point_both, move_if_not_intangible, get_property_and_range)
523 (get_local_map, copy_intervals, copy_intervals_to_string)
524 (compare_string_intervals, set_intervals_multibyte_1):
525 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
526 * intervals.h: Adjust decls to match defn changes elsewhere.
528 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
529 * keyboard.c (this_command_key_count, this_single_command_key_start)
530 (before_command_key_count, before_command_echo_length, echo_now)
531 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
532 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
533 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
534 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
535 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
536 (last_non_minibuf_size, last_point_position, echo_truncate)
537 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
538 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
539 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
540 (stuff_buffered_input):
541 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
542 (last_auto_save, command_loop_1, read_char):
543 Use EMACS_INT, not int, to avoid integer overflow.
544 (record_char): Avoid overflow in total_keys computation.
545 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
546 * keyboard.h: Adjust decls to match defn changes elsewhere.
547 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
548 (Fkey_description, Fdescribe_vector, Flookup_key):
549 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
550 (click_position): New function, to check that positions are in range.
551 (Fcurrent_active_maps):
553 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
554 (Faccessible_keymaps, Fkey_description):
555 (preferred_sequence_p):
556 Don't assume fixnum can fit into int.
557 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
558 Check for integer overflow in size calculations.
559 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
560 avoid mishandling large integers.
561 * lisp.h: Adjust decls to match defn changes elsewhere.
562 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
563 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
564 (struct Lisp_Marker):
565 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
566 (clip_to_bounds): Now an inline function, moved here from editfns.c.
567 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
568 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
570 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
571 Assume the arg has valid form, since it always does.
572 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
573 unsigned integer system type.
574 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
575 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
576 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
577 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
578 (duration_to_sec_usec): New decl.
579 * lread.c (read_from_string_index, read_from_string_index_byte)
580 (read_from_string_limit, readchar, unreadchar, openp)
581 (read_internal_start, read1, oblookup):
582 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
583 (Fload, readevalloop, Feval_buffer, Feval_region):
584 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
585 (openp): Check for out-of-range argument to 'access'.
586 (read1): Use int, not EMACS_INT, where int is wide enough.
587 Don't assume fixnum fits into int.
588 Fix off-by-one error that can read outside a buffer.
589 (read_filtered_event): Use duration_to_sec_usec
590 to do proper overflow checking on durations.
591 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
593 (Fexecute_kbd_macro):
594 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
595 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
596 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
597 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
598 (set_marker_both, set_marker_restricted_both, marker_position)
599 (marker_byte_position, Fbuffer_has_markers_at):
600 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
601 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
602 * menu.c (ensure_menu_items): Renamed from grow_menu_items.
603 It now merely ensures that the menu is large enough, without
604 necessarily growing it, as this avoids some integer overflow issues.
606 (keymap_panes, parse_single_submenu, Fx_popup_menu):
607 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
608 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
609 Use SAFE_ALLOCA_LISP, not alloca.
610 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
611 to EMACS_INT. Check that fixnums are in proper range for system types.
612 * minibuf.c (minibuf_prompt_width, string_to_object)
613 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
614 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
615 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
616 (get_minibuffer, read_minibuf_unwind):
617 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
618 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
619 this simplifies overflow checking. All callers changed.
620 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
622 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
623 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
624 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
625 Check that fixnums are in proper range for system types.
626 (Fx_create_frame, Fx_show_tip):
627 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
628 * nsfont.m (ns_findfonts, nsfont_list_family):
629 Don't assume fixnum fits in long.
630 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
631 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
632 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
634 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
635 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
636 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
637 (PRINTDECLARE, PRINTPREPARE):
638 (strout, print_string):
639 (print, print_preprocess, print_check_string_charset_prop)
641 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
643 (temp_output_buffer_setup, Fprin1_to_string, print_object):
644 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
645 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
646 (printchar, strout): Use xpalloc to catch size calculation overflow.
647 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
648 (print_error_message): Use SAFE_ALLOCA, not alloca.
649 (print_object): Use int, not EMACS_INT, where int is wide enough.
650 (print_depth, new_backquote_output, print_number_index):
651 Use ptrdiff_t, not int, where int might not be wide enough.
652 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
653 (Fset_process_window_size, Fformat_network_address)
654 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
656 Check that fixnums are in proper range for system types.
657 (Fsignal_process): Simplify by avoiding a goto.
658 Check for process-ids out of pid_t range rather than relying on
660 (process_tick, update_tick): Use EMACS_INT, not int.
661 (Fformat_network_address, read_process_output, send_process)
662 (Fprocess_send_region, status_notify):
663 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
664 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
665 (wait_reading_process_output, read_process_output, exec_sentinel):
666 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
667 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
668 (Faccept_process_output): Use duration_to_sec_usec to do proper
669 overflow checking on durations.
670 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
671 Don't assume pid_t fits in int.
672 * process.h (struct Lisp_Process): Members tick and update_tick
673 are now of type EMACS_INT, not int.
674 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
675 configured --with-wide-int.
676 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
677 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
678 * search.c (looking_at_1, string_match_1):
679 (fast_string_match, fast_c_string_match_ignore_case)
680 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
681 (scan_newline, find_before_next_newline, search_command)
682 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
683 (set_search_regs, wordify):
686 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
687 (string_match_1, search_buffer, set_search_regs):
689 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
690 (wordify): Check for overflow in size calculation.
691 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
692 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
693 Check that fixnums are in proper range for system types.
694 * sound.c (struct sound_device)
695 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
696 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
697 (Fplay_sound_internal):
698 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
699 * syntax.c (struct lisp_parse_state, find_start_modiff)
700 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
701 (Fparse_partial_sexp):
702 Don't assume fixnums can fit in int.
703 (struct lisp_parse_state, find_start_pos, find_start_value)
704 (find_start_value_byte, find_start_begv)
705 (update_syntax_table, char_quoted, dec_bytepos)
706 (find_defun_start, prev_char_comend_first, back_comment):
707 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
708 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
709 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
710 (Finternal_describe_syntax_value): Check that match_lisp is a
711 character, not an integer, since the code stuffs it into int.
712 (scan_words, scan_sexps_forward):
713 Check that fixnums are in proper range for system types.
715 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
716 (scan_sexps_forward):
717 Use CHARACTERP, not INTEGERP, since the value must fit into int.
718 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
719 * syntax.h: Adjust decls to match defn changes elsewhere.
721 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
722 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
723 MOST_POSITIVE_FIXNUM.
724 * sysdep.c (wait_for_termination_1, wait_for_termination)
725 (interruptible_wait_for_termination, mkdir):
726 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
727 (emacs_read, emacs_write):
728 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
729 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
730 and double all fit in int.
731 * term.c (set_tty_color_mode):
732 Check that fixnums are in proper range for system types.
733 * termhooks.h (struct input_event):
734 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
735 * textprop.c (validate_interval_range, interval_of)
736 (Fadd_text_properties, set_text_properties_1)
737 (Fremove_text_properties, Fremove_list_of_text_properties)
738 (Ftext_property_any, Ftext_property_not_all)
739 (copy_text_properties, text_property_list, extend_property_ranges)
740 (verify_interval_modification):
741 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
742 (Fnext_single_char_property_change)
743 (Fprevious_single_char_property_change):
744 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
745 (copy_text_properties):
746 Check for integer overflow in index calculation.
747 * undo.c (last_boundary_position, record_point, record_insert)
748 (record_delete, record_marker_adjustment, record_change)
749 (record_property_change):
750 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
751 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
752 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
753 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
754 (Fx_hide_tip, Fx_file_dialog):
755 * w32menu.c (set_frame_menubar):
756 Use ptrdiff_t, not int, for consistency with rest of code.
757 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
758 (select_window, Fdelete_other_windows_internal)
759 (window_scroll_pixel_based, window_scroll_line_based)
760 (Frecenter, Fset_window_configuration):
761 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
762 (Fset_window_hscroll, run_window_configuration_change_hook)
763 (set_window_buffer, temp_output_buffer_show, scroll_command)
764 (Fscroll_other_window, Frecenter):
765 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
766 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
767 Don't assume fixnum fits in int.
768 (Fset_window_scroll_bars):
769 Check that fixnums are in proper range for system types.
770 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
771 (string_pos, c_string_pos, number_of_chars, init_iterator)
772 (in_ellipses_for_invisible_text_p, init_from_display_pos)
773 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
774 (compute_display_string_end, handle_face_prop)
775 (face_before_or_after_it_pos, handle_invisible_prop)
776 (handle_display_prop, handle_display_spec, handle_single_display_spec)
777 (display_prop_intangible_p, string_buffer_position_lim)
778 (string_buffer_position, handle_composition_prop, load_overlay_strings)
779 (get_overlay_strings_1, get_overlay_strings)
780 (iterate_out_of_display_property, forward_to_next_line_start)
781 (back_to_previous_visible_line_start, reseat, reseat_to_string)
782 (get_next_display_element, set_iterator_to_next)
783 (get_visually_first_element, compute_stop_pos_backwards)
784 (handle_stop_backwards, next_element_from_buffer)
785 (move_it_in_display_line_to, move_it_in_display_line)
786 (move_it_to, move_it_vertically_backward, move_it_by_lines)
787 (add_to_log, message_dolog, message_log_check_duplicate)
788 (message2, message2_nolog, message3, message3_nolog
789 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
790 (current_message_1, truncate_echo_area, truncate_message_1)
791 (set_message, set_message_1, store_mode_line_noprop)
792 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
793 (text_outside_line_unchanged_p, check_point_in_composition)
794 (reconsider_clip_changes)
795 (redisplay_internal, set_cursor_from_row, try_scrolling)
796 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
797 (redisplay_window, find_last_unchanged_at_beg_row)
798 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
799 (trailing_whitespace_p, find_row_edges, display_line)
800 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
801 (display_mode_element, store_mode_line_string)
802 (pint2str, pint2hrstr, decode_mode_spec)
803 (display_count_lines, display_string, draw_glyphs)
804 (x_produce_glyphs, x_insert_glyphs)
805 (rows_from_pos_range, mouse_face_from_buffer_pos)
806 (fast_find_string_pos, mouse_face_from_string_pos)
807 (note_mode_line_or_margin_highlight, note_mouse_highlight):
808 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
809 (safe_call, init_from_display_pos, handle_fontified_prop)
810 (handle_single_display_spec, load_overlay_strings)
811 (with_echo_area_buffer, setup_echo_area_for_printing)
812 (display_echo_area, echo_area_display)
813 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
814 (update_tool_bar, hscroll_window_tree, redisplay_internal)
815 (redisplay_window, dump_glyph_row, display_mode_line)
816 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
817 (handle_display_spec, display_prop_string_p):
818 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
819 (handle_single_display_spec, build_desired_tool_bar_string)
820 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
821 (get_specified_cursor_type):
822 Check that fixnums are in proper range for system types.
823 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
825 Don't assume fixnums fit in int.
826 (compare_overlay_entries):
827 Avoid mishandling comparisons due to subtraction overflow.
828 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
829 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
830 (handle_tool_bar_click):
831 Use int, not unsigned, since we prefer signed and the signedness
833 (get_next_display_element, next_element_from_display_vector):
834 Use int, not EMACS_INT, when int is wide enough.
835 (start_hourglass): Use duration_to_sec_usec to do proper
836 overflow checking on durations.
837 * xfaces.c (Fbitmap_spec_p):
838 Check that fixnums are in proper range for system types.
839 (compare_fonts_by_sort_order):
840 Avoid mishandling comparisons due to subtraction overflow.
841 (Fx_family_fonts, realize_basic_faces):
842 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
844 Don't assume fixnum fits in int.
845 Use SAFE_ALLOCA_LISP, not alloca.
846 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
847 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
848 (face_at_buffer_position, face_for_overlay_string)
849 (face_at_string_position):
850 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
851 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
852 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
854 Check that fixnums are in proper range for system types.
855 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
856 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
857 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
858 (Fx_change_window_property): Don't assume fixnums fit in int.
859 * xfont.c (xfont_chars_supported):
860 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
861 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
862 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
863 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
864 * xml.c (parse_region):
865 * xrdb.c (magic_file_p):
866 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
867 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
868 (x_get_local_selection, x_reply_selection_request)
869 (x_handle_selection_request, wait_for_property_change):
870 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
871 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
872 short is wide enough.
873 (x_send_client_event): Don't assume fixnum fits in int.
874 * xterm.c (x_x_to_emacs_modifiers):
875 Don't assume EMACS_INT overflows nicely into int.
876 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
878 (handle_one_xevent): NATNUMP can eval its arg twice.
879 (x_connection_closed):
880 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
881 * xterm.h: Adjust decls to match defn changes elsewhere.
882 (struct scroll_bar): Use struct vectorlike_header
883 rather than rolling our own approximation.
884 (SCROLL_BAR_VEC_SIZE): Remove; not used.
886 2012-05-25 Glenn Morris <rgm@gnu.org>
888 * lisp.mk (lisp): Update for more files being compiled now.
890 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
892 * lread.c: Remove `read_pure' which makes no difference.
893 (read_pure): Remove var.
894 (unreadpure): Remove function.
895 (readevalloop): Don't call read_list with -1 flag.
896 (read1, read_vector): Don't test read_pure any more.
897 (read_list): Simplify.
899 * fileio.c, character.h: Minor style tweaks.
901 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
903 * window.h (clip_changed): Remove useless declaration.
905 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
907 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
908 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
910 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
913 This directory predates autoconf and is no longer needed nowadays.
914 Move its few remaining bits of functionality to where they're needed.
915 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
916 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
917 * m/template.h: Remove.
918 * Makefile.in (M_FILE): Remove. All uses removed.
919 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
920 * lisp.h (USE_LSB_TAG):
921 * mem-limits.h (EXCEEDS_LISP_PTR):
922 Use VAL_MAX, not VALBITS, in #if.
923 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
924 (EMACS_UINT): Define unconditionally now.
925 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
926 (BITS_PER_EMACS_INT): New constants, replacing
927 what used to be in config.h, but not useful in #if.
928 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
929 define them any more.
930 (VAL_MAX): New macro.
932 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
933 BITS_PER_EMACS_INT, in #if.
934 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
935 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
936 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
937 * s/ms-w32.h (DATA_START):
938 Move here from removed file m/intel386.h.
939 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
940 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
942 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
945 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
946 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
948 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
949 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
950 * textprop.c, tparam.c (NULL): Remove.
951 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
952 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
953 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
954 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
955 * xterm.c (input_signal_count): Assume volatile works.
957 2012-05-21 Ken Brown <kbrown@cornell.edu>
959 * xgselect.c (xg_select): Fix first argument in call to 'select'
962 2012-05-20 Ken Brown <kbrown@cornell.edu>
964 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
965 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
967 2012-05-19 Ken Brown <kbrown@cornell.edu>
969 * xfns.c (x_in_use): Remove `static' qualifier.
970 * xterm.h (x_in_use): Declare.
971 * xgselect.c: Include xterm.h.
972 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
973 and `display_arg' (bug#9754).
975 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
977 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
979 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
980 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
982 2012-05-18 Eli Zaretskii <eliz@gnu.org>
984 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
986 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
987 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
989 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
990 reference to image_cache->refcount.
991 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
993 2012-05-17 Juri Linkov <juri@jurta.org>
995 * search.c (Fword_search_regexp, Fword_search_backward)
996 (Fword_search_forward, Fword_search_backward_lax)
997 (Fword_search_forward_lax): Move functions to isearch.el
998 (bug#10145, bug#11381).
1000 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
1002 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
1004 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
1006 * lread.c (init_obarray): Declare Qt and Qnil as special.
1008 2012-05-14 Glenn Morris <rgm@gnu.org>
1010 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
1011 Put "libexec" before "bin", for the sake of init_callproc_1.
1013 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1015 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
1017 * unexaix.c: Port to more-recent AIX compilers.
1018 (report_error, report_error_1, make_hdr, copy_sym)
1019 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
1020 Make arguments const char *, not char *, to avoid violations of C
1021 standard and to fix some AIX warnings reported by Gilles Pion.
1023 2012-05-14 Eli Zaretskii <eliz@gnu.org>
1025 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
1026 already have overlays loaded.
1027 (handle_single_display_spec): Before returning without displaying
1028 fringe bitmap, synchronize the bidi iterator with the main display
1029 iterator, by calling iterate_out_of_display_property.
1030 (iterate_out_of_display_property): Detect buffer iteration by
1031 testing that it->string is a Lisp string.
1032 (get_next_display_element): When the current object is exhausted,
1033 and there's something on it->stack, call set_iterator_to_next to
1034 proceed with what's on the stack, instead of returning zero.
1035 (set_iterator_to_next): If called at the end of a Lisp string,
1036 proceed to consider_string_end without incrementing string
1037 position. Don't increment display vector index past the end of
1038 the display vector. (Bug#11417)
1039 (pos_visible_p): Don't report a position visible when move_it_to
1040 stopped at the last line of window, which happens to be scanned
1041 backwards by the bidi iteration. (Bug#11464)
1043 2012-05-14 Eli Zaretskii <eliz@gnu.org>
1045 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
1046 and right-margin display specs even if the spec is invalid or we
1047 are on a TTY, and thus unable to display on the fringes. That's
1048 because the text with the property will not be displayed anyway,
1049 so we need to signal to the caller that this is a "replacing"
1050 display spec. This fixes display when the spec is invalid or we
1053 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1055 * unexaix.c (make_hdr): Fix typo in prototype.
1056 This bug broke the build on AIX. Problem reported by Gilles Pion.
1058 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
1060 * keyboard.c (kbd_buffer_get_event): Read special events also in
1061 batch mode. (Bug#11415)
1063 2012-05-12 Glenn Morris <rgm@gnu.org>
1065 * ns.mk: Update for ns_appbindir no longer having trailing "/".
1067 2012-05-12 Eli Zaretskii <eliz@gnu.org>
1069 * lisp.mk (lisp): Add newcomment.elc.
1071 2012-05-12 Glenn Morris <rgm@gnu.org>
1073 * Makefile.in (MKDIR_P): New, set by configure.
1074 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
1076 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
1078 Remove unused function hourglass_started.
1079 * dispextern.h (hourglass_started):
1080 * w32fns.c (hourglass_started):
1081 * xdisp.c (hourglass_started): Remove.
1083 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
1085 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
1086 Update dependencies.
1088 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
1090 * xgselect.c (xg_select): Put maxfds+1 into a var.
1091 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
1093 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
1095 2012-05-10 Dave Abrahams <dave@boostpro.com>
1097 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
1098 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
1100 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
1102 * dbusbind.c (xd_registered_buses): New internal Lisp object.
1103 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
1104 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
1105 Initialize xd_registered_buses.
1107 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
1109 Untag more efficiently if USE_LSB_TAG.
1110 This is based on a proposal by YAMAMOTO Mitsuharu in
1111 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
1112 For an admittedly artificial (nth 8000 longlist) benchmark on
1113 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
1114 Emacs's overall text size by 1%.
1115 * lisp.h (XUNTAG): New macro.
1116 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
1117 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
1118 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
1119 * eval.c (Fautoload):
1120 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
1121 * frame.h (XFRAME): Use XUNTAG.
1123 Port recent dbusbind.c changes to 32-bit --with-wide-int.
1124 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
1125 Remove unportable assumptions about print widths of types like
1127 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
1128 intptr_t when converting between pointer and integer, to avoid GCC
1129 warnings about wrong width.
1131 2012-05-09 Eli Zaretskii <eliz@gnu.org>
1133 * w32proc.c (new_child): Force Windows to reserve only 64KB of
1134 stack for each reader_thread, instead of defaulting to 8MB
1135 determined by the linker. This avoids failures in creating
1136 subprocesses on Windows 7, see the discussion in this thread:
1137 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
1139 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
1141 Fix up display of the *Minibuf-0* buffer in the mini window.
1142 * keyboard.c (read_char): Don't clear the echo area if there's no
1144 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
1145 contents of *Minibuf-0*) if there's no message displayed in its stead.
1147 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
1149 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
1152 2012-05-06 Chong Yidong <cyd@gnu.org>
1154 * lisp.mk (lisp): Update.
1156 2012-05-05 Jim Meyering <meyering@redhat.com>
1158 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
1160 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
1162 * data.c (PUT_ERROR): New macro.
1163 (syms_of_data): Use it. Add new error type `user-error'.
1164 * undo.c (user_error): New function.
1165 (Fprimitive_undo): Use it.
1166 * print.c (print_error_message): Adjust print style for `user-error'.
1167 * keyboard.c (user_error): New function.
1168 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
1170 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
1172 Do not limit current-time-string to years 1000..9999.
1173 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
1174 (Fcurrent_time_string): Support any year that is supported by the
1175 underlying localtime representation. Don't use asctime, as it
1176 has undefined behavior for years outside the range -999..9999.
1178 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
1180 Fix race conditions involving setenv, gmtime, localtime, asctime.
1181 Without this fix, interrupts could mess up code that uses these
1182 nonreentrant functions, since setting TZ invalidates existing
1183 tm_zone or tzname values, and since most of these functions return
1184 pointers to static storage.
1185 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
1186 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
1187 Grow the critical sections to include not just invoking
1188 localtime/gmtime, but also accessing these functions' results
1189 including their tm_zone values if any, and any related TZ setting.
1190 (format_time_string): Last arg is now struct tm *, not struct tm **,
1191 so that the struct tm is saved in the critical section.
1192 All callers changed. Simplify allocation of initial buffer, partly
1193 motivated by the fact that memory allocation needs to be outside
1194 the critical section.
1196 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
1198 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
1199 with RESET_INTERVAL.
1201 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1202 Remove duplicated buffer name initialization.
1204 2012-05-02 Jim Meyering <jim@meyering.net>
1206 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
1208 * xfns.c (x_window): Use xstrdup (Bug#11375).
1210 2012-05-02 Eli Zaretskii <eliz@gnu.org>
1212 * xdisp.c (pos_visible_p): If already at a newline from the
1213 display string before the 'while' loop, don't walk back the glyphs
1214 from it3.glyph_row. Solves assertion violation when the display
1215 string begins with a newline (egg.el). (Bug#11367)
1217 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
1219 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
1222 2012-05-01 Glenn Morris <rgm@gnu.org>
1224 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
1225 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
1226 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
1227 All were removed before 23.1.
1229 * dispnew.c: Remove HAVE_LIBNCURSES test;
1230 it is always true on relevant platforms.
1232 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
1233 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
1235 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
1237 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
1239 * .gdbinit (xpr): Remove checks for no longer existing misc types.
1240 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
1243 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
1245 Do not avoid creating empty evaporating overlays (Bug#9642).
1246 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
1247 That is, do not delete an evaporating overlay if it becomes
1248 empty after its bounds are adjusted to fit within its buffer.
1249 This fix caused other problems, and I'm reverting it until we get
1250 to the bottom of them.
1252 2012-04-27 Chong Yidong <cyd@gnu.org>
1254 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
1256 2012-04-27 Eli Zaretskii <eliz@gnu.org>
1258 * xdisp.c (pos_visible_p): If the window start position is beyond
1259 ZV, start the display from buffer beginning. Prevents assertion
1260 violation in init_iterator when the minibuffer window is scrolled
1263 * window.c (window_scroll_pixel_based): Likewise.
1265 2012-04-27 Chong Yidong <cyd@gnu.org>
1267 * keymap.c (where_is_internal): Doc fix (Bug#10872).
1269 2012-04-27 Glenn Morris <rgm@gnu.org>
1271 * fileio.c (Fcopy_file, Fset_file_selinux_context):
1272 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
1274 2012-04-27 Eli Zaretskii <eliz@gnu.org>
1276 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
1277 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
1279 2012-04-26 Eli Zaretskii <eliz@gnu.org>
1281 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
1282 display element, check also the underlying string or buffer
1283 character. (Bug#11341)
1285 * w32menu.c: Include w32heap.h.
1286 (add_menu_item): If the call to AppendMenuW (via
1287 unicode_append_menu) fails, disable Unicode menus only if we are
1288 running on Windows 9X/Me.
1290 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
1292 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
1293 (xgetint): Add missing shift for LSB tags.
1295 2012-04-24 Martin Rudalics <rudalics@gmx.at>
1297 * keyboard.c (read_char): Don't wipe echo area for select window
1298 events: These might get delayed via `mouse-autoselect-window'
1301 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
1303 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
1304 manipulation of :loaded-from data.
1306 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
1308 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
1309 now a cons (bug#11311).
1311 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
1313 Do not create empty overlays with the evaporate property (Bug#9642).
1314 * buffer.c (Fmove_overlay): Delete an evaporating overlay
1315 if it becomes empty after its bounds are adjusted to fit within
1316 its buffer. Without this fix, in a nonempty buffer (let ((o
1317 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
1318 yields an empty overlay that has the evaporate property, which is
1319 not supposed to happen.
1321 Fix minor GTK3 problems found by static checking.
1322 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1323 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1324 (struct _EmacsFixedClass, emacs_fixed_get_type):
1325 Move decls here from emacsgtkfixed.h, since they needn't be public.
1326 (emacs_fixed_get_type): Now static.
1327 (emacs_fixed_class_init): Omit unused local.
1328 (emacs_fixed_child_type): Remove; unused.
1329 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1330 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1331 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
1332 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
1333 (EMACS_FIXED_GET_CLASS): Remove; unused.
1334 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
1336 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
1337 Problem reported by Juanma Barranquero for Windows -Wunused-function.
1339 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1341 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
1342 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
1343 (__malloc_size_t, __malloc_ptrdiff_t):
1344 Remove. All uses removed, replaced by the definiens if needed,
1345 since we can assume C89 or better now.
1346 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
1347 (protect_malloc_state, align, get_contiguous_space)
1348 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
1349 (malloc_atfork_handler_child, malloc_enable_thread)
1350 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
1351 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
1352 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
1353 (special_realloc, _realloc_internal_nolock, _realloc_internal)
1354 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
1355 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
1356 Define using prototypes, not old style.
1357 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
1358 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
1359 (align): Don't assume that signed integer overflow wraps around.
1360 Omit unused local var.
1361 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
1362 (_free_internal_nolock, memalign, mallochook, reallochook):
1363 Omit no-longer-needed casts.
1364 (valloc): Use getpagesize, not __getpagesize.
1365 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
1366 (struct hdr): The 'magic' member is now size_t, not unsigned long.
1368 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
1370 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
1372 Move functions from C to Lisp. Make non-blocking method calls
1373 the default. Implement further D-Bus standard interfaces.
1375 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
1376 (QCdbus_request_name_allow_replacement)
1377 (QCdbus_request_name_replace_existing)
1378 (QCdbus_request_name_do_not_queue)
1379 (QCdbus_request_name_reply_primary_owner)
1380 (QCdbus_request_name_reply_in_queue)
1381 (QCdbus_request_name_reply_exists)
1382 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
1383 (QCdbus_registered_serial, QCdbus_registered_method)
1384 (QCdbus_registered_signal): New Lisp objects.
1385 (XD_DEBUG_MESSAGE): Use sizeof.
1386 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
1387 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
1388 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
1389 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
1390 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
1391 (xd_signature, xd_append_arg): Allow float for integer types.
1392 (xd_get_connection_references): New function.
1393 (xd_get_connection_address): Rename from xd_initialize.
1394 Return cached address.
1395 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
1396 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
1398 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
1399 Return number of refcounts.
1400 (Fdbus_get_unique_name): Make stronger parameter check.
1401 (Fdbus_message_internal): New defun.
1402 (Fdbus_call_method, Fdbus_call_method_asynchronously)
1403 (Fdbus_method_return_internal, Fdbus_method_error_internal)
1404 (Fdbus_send_signal, Fdbus_register_service)
1405 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
1406 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
1407 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
1408 (Vdbus_compiled_version, Vdbus_runtime_version)
1409 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
1410 (Vdbus_message_type_method_return, Vdbus_message_type_error)
1411 (Vdbus_message_type_signal): New defvars.
1412 (Vdbus_registered_buses, Vdbus_registered_objects_table):
1415 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1417 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
1418 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
1419 Do not assume ptrdiff_t is the same width as 'int'.
1421 * alloc.c: Handle unusual debugging option combinations.
1422 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
1423 since the two debugging options are incompatible.
1424 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
1426 (mem_init, mem_insert, mem_insert_fixup):
1427 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
1428 (NEED_MEM_INSERT): Remove; no longer needed.
1430 2012-04-22 Leo Liu <sdl.web@gmail.com>
1432 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
1434 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1436 * sysdep.c [__FreeBSD__]: Minor cleanups.
1437 (list_system_processes, system_process_attributes) [__FreeBSD__]:
1438 Use Emacs indenting style more consistently. Avoid some casts.
1439 Use 'double' consistently rather than mixing 'float' and 'double'.
1441 2012-04-21 Eduard Wiebe <usenet@pusto.de>
1443 * sysdep.c (list_system_processes, system_process_attributes):
1444 Add implementation for FreeBSD (Bug#5243).
1446 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
1448 * lisp.mk (lisp): Update.
1450 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
1452 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
1453 It is never used otherwise.
1455 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
1457 * print.c (print_preprocess): Only check print_depth if print-circle
1459 (print_object): Check for cycles even when print-circle is nil and
1460 print-gensym is t, but only check print_depth if print-circle is nil.
1462 2012-04-20 Chong Yidong <cyd@gnu.org>
1464 * process.c (wait_reading_process_output): If EIO occurs on a pty,
1465 set the status to "failed" and ensure that sentinel is run.
1467 2012-04-20 Glenn Morris <rgm@gnu.org>
1469 * process.c (Fset_process_inherit_coding_system_flag)
1470 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
1471 (Fmake_network_process, Fmake_serial_process): Doc fix.
1473 2012-04-20 Eli Zaretskii <eliz@gnu.org>
1475 * xdisp.c (string_buffer_position_lim): Limit starting position to
1477 (set_cursor_from_row): If called for a mode-line or header-line
1478 row, return zero immediately.
1479 (try_cursor_movement): If inside continuation line, don't back up
1480 farther than the first row after the header line, if any.
1481 Don't consider the header-line row as "partially visible", even if
1482 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
1484 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
1486 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
1489 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
1490 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
1492 configure: new option --enable-gcc-warnings (Bug#11207)
1493 * Makefile.in (C_WARNINGS_SWITCH): Remove.
1494 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
1495 (ALL_CFLAGS): Use new macros rather than old.
1496 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
1497 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
1498 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
1499 -Wunused-result, -Wunused-variable. This should go away once
1500 the Emacs and Gnulib regex code is merged.
1501 (xmalloc, xrealloc): Now static.
1503 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
1505 * dired.c (Fsystem_groups): Remove unused local.
1507 2012-04-17 Glenn Morris <rgm@gnu.org>
1509 * dired.c (Fsystem_users): Doc fix.
1511 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
1513 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
1514 (syms_of_dired): Add them.
1516 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
1518 Fix minor alloc.c problems found by static checking.
1519 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
1520 New extern decls, to avoid calling undeclared functions.
1521 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
1522 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
1523 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
1524 (NEED_MEM_INSERT): New macro.
1525 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
1526 Remove one incorrect comment and fix another.
1528 Fix minor ralloc.c problems found by static checking.
1529 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1530 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
1531 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
1532 (r_alloc_sbrk): Now static.
1534 Improve ralloc.c interface checking.
1535 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1536 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
1537 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
1538 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
1539 [REL_ALLOC]: ... to here, to check interface.
1540 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
1541 Remove decls. This fixes an "It stinks!".
1543 * alloc.c (which_symbols): Fix alignment issue / type clash.
1545 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
1547 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
1548 (struct Lisp_Misc_Any): Likewise.
1549 (struct Lisp_Free): Likewise.
1550 * alloc.c (union aligned_Lisp_Symbol): Define.
1551 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
1552 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
1553 (union aligned_Lisp_Misc): Define.
1554 (MARKER_BLOCK_SIZE, struct marker_block): Use union
1555 aligned_Lisp_Misc instead of union Lisp_Misc.
1556 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
1558 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
1560 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
1561 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
1562 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
1563 * s/netbsd.h, s/sol2-6.h:
1564 Remove definition of GC_MARK_STACK, since the default now works.
1565 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
1566 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
1567 no longer the default.
1568 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
1570 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
1572 * lread.c (lisp_file_lexically_bound_p):
1573 Fix hang at ";-*-\n" (bug#11238).
1575 2012-04-14 Eli Zaretskii <eliz@gnu.org>
1577 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
1578 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
1580 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
1582 * nsterm.m (constrainFrameRect): Always constrain when there is only
1583 one screen (Bug#10962).
1585 2012-04-13 Ken Brown <kbrown@cornell.edu>
1587 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
1589 2012-04-13 Reuben Thomas <rrt@sc3d.org>
1591 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
1593 2012-04-11 Daniel Colascione <dancol@dancol.org>
1595 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
1596 against is gone. It's better to use vfork now so that when Cygwin
1597 gains a new, working vfork, we use it automatically (bug#10398).
1599 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1601 * window.c (save_window_save): Obey window-point-insertion-type.
1603 2012-04-11 Glenn Morris <rgm@gnu.org>
1605 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
1607 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
1609 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
1611 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
1613 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
1614 (force_quit_count): New var.
1615 (handle_interrupt): Use it.
1617 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
1619 * w32.c (w32_delayed_load): Record the full path of the library
1620 being loaded (bug#10424).
1622 2012-04-09 Glenn Morris <rgm@gnu.org>
1624 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
1625 not just in the obarray, before snarfing them. (Bug#11036)
1627 * Makefile.in ($(leimdir)/leim-list.el):
1628 Pass EMACS rather than BUILT_EMACS.
1630 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
1632 * process.c (make_process):
1633 * process.h: Add integer `gnutls_handshakes_tried' member to
1636 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
1637 Add convenience `GNUTLS_LOG2i' macro.
1639 * gnutls.c (gnutls_log_function2i): Convenience log function.
1640 (emacs_gnutls_read): Use new log functions,
1641 `gnutls_handshakes_tried' process member, and
1642 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
1643 attempts per process (connection).
1645 2012-04-09 Chong Yidong <cyd@gnu.org>
1647 * eval.c (Fuser_variable_p, user_variable_p_eh)
1648 (lisp_indirect_variable): Functions deleted.
1649 (Fdefvar): Caller changed.
1651 * callint.c (Finteractive, Fcall_interactively):
1652 * minibuf.c (Fread_variable): Callers changed.
1654 2012-04-09 Eli Zaretskii <eliz@gnu.org>
1656 * xdisp.c (set_cursor_from_row): If the display string appears in
1657 the buffer at position that is closer to point than the position
1658 after the display string, display the cursor on the first glyph of
1659 the display string. Fixes cursor display when a 'display' text
1660 property immediately follows invisible text. (Bug#11094)
1662 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
1664 composite.c: use 'double' consistently
1665 * composite.c (get_composition_id): Use 'double' consistently
1666 instead of converting 'float' to 'double' and vice versa; this is
1667 easier to understand and avoids a GCC warning.
1669 2012-04-09 Glenn Morris <rgm@gnu.org>
1671 * Makefile.in: Generate leim-list with bootstrap-emacs, in
1672 preparation for dumping it with emacs. (Bug#4789)
1673 (leimdir): New variable.
1674 ($(leimdir)/leim-list.el): New rule.
1675 (emacs$(EXEEXT)): Depend on leim-list.el.
1677 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
1678 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
1679 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
1681 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
1683 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
1686 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
1688 * xml.c (init_libxml2_functions) [WINDOWSNT]:
1689 Remove unused local variable.
1691 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
1693 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
1694 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
1695 (mark_memory): Mark Lisp_Objects only if pointers might hide in
1696 objects, as mark_maybe_pointer will catch them otherwise.
1697 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
1698 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
1700 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
1702 Fix typo that broke non-Windows builds.
1703 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
1705 2012-04-07 Eli Zaretskii <eliz@gnu.org>
1707 Support building on MS-Windows with libxml2.
1709 * makefile.w32-in (OBJ2): Add xml.$(O).
1710 (GLOBAL_SOURCES): Add xml.c.
1711 ($(BLD)/xml.$(O)): New dependency list.
1713 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
1714 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
1715 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
1716 [!WINDOWSNT]: New macros.
1717 (init_libxml2_functions, libxml2_loaded_p): New functions.
1718 (parse_region): Call fn_xmlCheckVersion instead of using the macro
1719 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
1720 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
1721 Calls xmlCleanupParser only if libxml2 was loaded (or statically
1723 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
1724 Call init_libxml2_functions before calling libxml2 functions.
1725 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
1727 * emacs.c: Don't include libxml/parser.h.
1728 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
1729 xmlCleanupParser directly.
1731 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
1733 2012-04-07 Eli Zaretskii <eliz@gnu.org>
1735 * indent.c (Fvertical_motion): If there is a display string at
1736 point, use it.vpos to compute how many lines to backtrack after
1737 move_it_to point. (Bug#11133)
1739 2012-04-06 Eli Zaretskii <eliz@gnu.org>
1741 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
1742 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
1743 about subtle differences between FETCH_CHAR* and STRING_CHAR*
1744 macros related to unification of CJK characters. For the details,
1745 see the discussion following the message here:
1746 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
1748 2012-04-04 Chong Yidong <cyd@gnu.org>
1750 * keyboard.c (Vdelayed_warnings_list): Doc fix.
1752 2012-04-01 Eli Zaretskii <eliz@gnu.org>
1754 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
1755 instead of alloca. (Bug#11138)
1757 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
1759 * w32menu.c (is_simple_dialog): Properly check lisp types.
1762 2012-03-31 Eli Zaretskii <eliz@gnu.org>
1764 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
1765 position we get to after a call to move_it_to fails the
1766 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
1767 only if we wind up in a string from display property. (Bug#11063)
1769 * window.c (Fdelete_other_windows_internal): Invalidate the row
1770 and column information about mouse highlight, so that redisplay
1771 restores it after reallocating the glyph matrices. (Bug#7464)
1773 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
1774 string comes from a `display' text property, use the buffer
1775 position of that property as if we actually saw that position in
1777 (move_it_by_lines): Remove the assertion that
1778 "it->current_x == 0 && it->hpos == 0" which can be legitimately
1779 violated when there's a before-string at the beginning of a line.
1782 2012-03-30 Eli Zaretskii <eliz@gnu.org>
1784 * xdisp.c (append_space_for_newline): If the default face was
1785 remapped, use the remapped face for the appended newline.
1786 (extend_face_to_end_of_line): Use the remapped default face for
1787 extending the face to the end of the line.
1788 (display_line): Call extend_face_to_end_of_line when the default
1789 face was remapped. (Bug#11068)
1791 2012-03-29 Eli Zaretskii <eliz@gnu.org>
1793 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
1795 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1797 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
1799 2012-03-27 Glenn Morris <rgm@gnu.org>
1801 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
1804 2012-03-26 Kenichi Handa <handa@m17n.org>
1806 * dispextern.h (struct glyph): Fix previous change. Change the
1807 bit length of glyphless.ch to 25 (Bug#11082).
1809 2012-03-26 Chong Yidong <cyd@gnu.org>
1811 * keyboard.c (Vselection_inhibit_update_commands): New variable.
1812 (command_loop_1): Use it; inhibit selection update for
1813 handle-select-window too (Bug#8996).
1815 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
1817 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
1819 2012-03-25 Kenichi Handa <handa@m17n.org>
1821 * dispextern.h (struct glyph): Change the bit length of
1822 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
1824 2012-03-24 Eli Zaretskii <eliz@gnu.org>
1826 * s/ms-w32.h (tzname): Include time.h before redirecting to
1827 _tzname. Fixes the MSVC build. (Bug#9960)
1829 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
1831 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
1834 * xterm.c (XTread_socket): Only modify handling_signal if
1835 !SYNC_INPUT. (Bug#11080)
1837 2012-03-23 Eli Zaretskii <eliz@gnu.org>
1839 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
1840 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
1841 when fetching a multibyte character consumes more bytes than
1842 CHAR_BYTES returns, due to unification of CJK characters in
1843 string_char. (Bug#11073)
1845 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
1847 * process.c (wait_reading_process_output): Handle pty disconnect
1848 by refraining from sending oneself a SIGCHLD (bug#10933).
1850 2012-03-22 Chong Yidong <cyd@gnu.org>
1852 * dispextern.h (struct it): New member string_from_prefix_prop_p.
1854 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
1855 Mark string as coming from a prefix property.
1856 (handle_face_prop): Use default face for prefix strings (Bug#4281).
1857 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
1859 2012-03-21 Chong Yidong <cyd@gnu.org>
1861 * xfaces.c (Vface_remapping_alist): Doc fix.
1863 2012-03-20 Eli Zaretskii <eliz@gnu.org>
1865 * w32proc.c (Fw32_set_console_codepage)
1866 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
1869 2012-03-20 Chong Yidong <cyd@gnu.org>
1871 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
1872 to reflect default non-nil value of redisplay-dont-pause.
1874 2012-03-19 Kenichi Handa <handa@m17n.org>
1876 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
1877 it fit in a valid range (Bug#11003).
1879 2012-03-18 Eli Zaretskii <eliz@gnu.org>
1881 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
1882 that is not from display property, accept the row as a "cursor
1883 row" if one of the string's character has a non-nil `cursor'
1884 property. Fixes cursor positioning when there are newlines in
1885 overlay strings, e.g. in icomplete.el. (Bug#11035)
1887 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
1889 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
1891 2012-03-12 Chong Yidong <cyd@gnu.org>
1893 * eval.c (inhibit_lisp_code): Rename from
1894 inhibit_window_configuration_change_hook; move from window.c.
1896 * xfns.c (unwind_create_frame_1, Fx_create_frame):
1897 * window.c (run_window_configuration_change_hook)
1898 (syms_of_window): Callers changed.
1900 2012-03-11 Chong Yidong <cyd@gnu.org>
1902 * keymap.c (Fkey_description): Doc fix (Bug#9700).
1904 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
1906 2012-03-10 Chong Yidong <cyd@gnu.org>
1908 * frame.c (other_visible_frames): Don't assume the selected frame
1909 is visible (Bug#10955).
1911 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
1913 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
1915 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
1917 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
1918 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
1921 2012-03-03 Glenn Morris <rgm@gnu.org>
1923 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
1925 2012-03-02 Eli Zaretskii <eliz@gnu.org>
1927 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
1928 position past the first glyph_row that ends at ZV. (Bug#10902)
1929 (redisplay_window, next_element_from_string): Fix typos in
1931 (redisplay_window): Pass to move_it_vertically the margin in
1932 pixels, not in screen lines.
1934 2012-03-02 Glenn Morris <rgm@gnu.org>
1936 * buffer.c (buffer-list-update-hook): Doc fix.
1938 2012-02-29 Eli Zaretskii <eliz@gnu.org>
1940 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
1941 push_it before setting up the iterator for the first overlay
1942 string, even if we have an empty string loaded.
1943 (next_overlay_string): If there's an empty string on the iterator
1944 stack, pop the stack. (Bug#10903)
1946 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
1948 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
1949 Suggested by Stefan Monnier in
1950 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
1951 * alloc.c (widen_to_Lisp_Object): New static function.
1952 (mark_memory): Also mark Lisp_Objects by fetching pointer words
1953 and widening them to Lisp_Objects. This would work even if
1954 USE_LSB_TAG is defined and wide integers are used, which might
1955 happen in a future version of Emacs.
1957 2012-02-25 Chong Yidong <cyd@gnu.org>
1959 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
1962 * xselect.c (Fx_selection_exists_p): Doc fix.
1963 (x_clipboard_manager_save_all): Print an informative message
1964 before saving to clipboard manager.
1966 2012-02-24 Chong Yidong <cyd@gnu.org>
1968 * keyboard.c (process_special_events): Handle all X selection
1969 requests in kbd_buffer, not just the next one (Bug#8869).
1971 2012-02-23 Chong Yidong <cyd@gnu.org>
1973 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
1974 call when setting menu-bar-lines and tool-bar-lines parameters.
1975 (unwind_create_frame_1): New helper function.
1977 * window.c (inhibit_window_configuration_change_hook): New var.
1978 (run_window_configuration_change_hook): Obey it.
1979 (syms_of_window): Initialize it.
1981 2012-02-22 Chong Yidong <cyd@gnu.org>
1983 * xterm.c (x_draw_image_relief): Add missing type check for
1984 Vtool_bar_button_margin (Bug#10743).
1986 2012-02-21 Chong Yidong <cyd@gnu.org>
1988 * fileio.c (Vfile_name_handler_alist): Doc fix.
1990 * buffer.c (Fget_file_buffer): Protect against invalid file
1991 handler return value.
1993 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
1995 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
1996 when computing $valmask.
1998 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
1999 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
2000 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
2001 It's useless in that case, and it can cause problems on hosts
2002 that allocate halves of EMACS_INT values separately.
2003 Reported by Dan Horák. Diagnosed by Andreas Schwab in
2004 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
2005 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
2006 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
2007 it avoids undefined behavior on hosts where shifting right by more
2008 than the word width has undefined behavior.
2010 2012-02-19 Chong Yidong <cyd@gnu.org>
2012 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
2013 (Funhandled_file_name_directory, Ffile_name_as_directory)
2014 (Fdirectory_file_name, Fexpand_file_name)
2015 (Fsubstitute_in_file_name): Protect against invalid file handler
2016 return values (Bug#10845).
2018 2012-02-18 Eli Zaretskii <eliz@gnu.org>
2020 * .gdbinit (pitx): Fix incorrect references to fields of the
2023 2012-02-17 Chong Yidong <cyd@gnu.org>
2025 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
2027 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
2029 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
2030 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
2032 2012-02-15 Chong Yidong <cyd@gnu.org>
2034 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
2035 marked as special. Also, starting docstrings with * is obsolete.
2037 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
2039 * gnutls.c (emacs_gnutls_write): Fix last change.
2041 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
2043 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
2046 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
2048 * keymap.c (Fsingle_key_description): Handle char ranges.
2050 2012-02-12 Chong Yidong <cyd@gnu.org>
2052 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
2053 as that creates a dangerous corner case.
2055 * window.c (Fdelete_window_internal): Invalidate the mouse
2056 highlight (Bug#9904).
2058 2012-02-12 Glenn Morris <rgm@gnu.org>
2060 * xselect.c (Fx_own_selection_internal)
2061 (Fx_get_selection_internal, Fx_disown_selection_internal)
2062 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
2063 * nsselect.m (Fx_own_selection_internal)
2064 (Fx_disown_selection_internal, Fx_selection_exists_p)
2065 (Fx_selection_owner_p, Fx_get_selection_internal):
2066 Sync docs and argument specs with the xselect.c versions.
2068 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
2070 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
2072 2012-02-11 Eli Zaretskii <eliz@gnu.org>
2074 * w32select.c (Fx_selection_exists_p): Sync doc string and
2075 argument list with xselect.c. (Bug#10783)
2077 * w16select.c (Fx_selection_exists_p): Sync doc string and
2078 argument list with xselect.c. (Bug#10783)
2080 2012-02-10 Glenn Morris <rgm@gnu.org>
2082 * fns.c (Fsecure_hash): Doc fix.
2084 2012-02-09 Kenichi Handa <handa@m17n.org>
2086 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
2088 2012-02-07 Chong Yidong <cyd@gnu.org>
2090 * buffer.c (Fbuffer_local_variables)
2091 (buffer_lisp_local_variables): Handle unbound vars correctly;
2092 don't let Qunbound leak into Lisp.
2094 2012-02-07 Glenn Morris <rgm@gnu.org>
2096 * image.c (Fimagemagick_types): Doc fix.
2098 * image.c (imagemagick-render-type): Change it from a lisp object
2099 to an integer. Move the doc here from the lisp manual.
2100 Treat all values not equal to 0 the same.
2102 2012-02-06 Chong Yidong <cyd@gnu.org>
2104 * doc.c (store_function_docstring): Avoid applying docstring of
2105 alias to base function (Bug#2603).
2107 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
2109 * .gdbinit (pp1, pv1): Remove redundant defines.
2112 2012-02-04 Chong Yidong <cyd@gnu.org>
2114 * nsterm.m: Declare a global (Bug#10694).
2116 2012-02-04 Eli Zaretskii <eliz@gnu.org>
2118 * w32.c (get_emacs_configuration_options):
2119 Include --enable-checking, if specified, in the return value.
2121 2012-02-04 Martin Rudalics <rudalics@gmx.at>
2123 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
2124 after rounding frame sizes. (Bug#9723)
2126 2012-02-04 Eli Zaretskii <eliz@gnu.org>
2128 * keyboard.c (adjust_point_for_property): Don't position point
2129 before BEGV. (Bug#10696)
2131 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
2133 Handle overflow when computing char display width (Bug#9496).
2134 * character.c (char_width): Return EMACS_INT, not int.
2135 (char_width, c_string_width): Check for overflow when
2136 computing the width; this is possible now that individual
2137 characters can have unbounded width. Problem introduced
2138 by merge from Emacs 23 on 2012-01-19.
2140 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
2142 * dbusbind.c (Fdbus_register_method): Mention the return value
2143 :ignore in the docstring.
2145 2012-02-02 Glenn Morris <rgm@gnu.org>
2147 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
2149 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2150 Unconditionally set to t. (Bug#10673)
2151 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2152 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2153 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
2155 2012-02-02 Kenichi Handa <handa@m17n.org>
2157 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
2158 0, do not call append_composite_glyph.
2160 2012-02-02 Kenichi Handa <handa@m17n.org>
2162 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
2164 (x_produce_glyphs): If the component of a composition is a null
2165 string, set it->pixel_width to 1 to avoid zero-width glyph.
2167 2012-02-01 Eli Zaretskii <eliz@gnu.org>
2169 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
2170 first 2 arguments are identical. This makes inserting large
2171 output from a subprocess an order of magnitude faster on
2172 MS-Windows, where all sbrk'ed memory is always contiguous.
2174 2012-01-31 Glenn Morris <rgm@gnu.org>
2176 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2177 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2178 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
2180 2012-01-29 Glenn Morris <rgm@gnu.org>
2182 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
2184 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
2186 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
2188 2012-01-28 Chong Yidong <cyd@gnu.org>
2190 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
2192 2012-01-26 Chong Yidong <cyd@gnu.org>
2194 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
2196 * search.c (Fsearch_forward, Fsearch_backward): Document negative
2197 repeat counts (Bug#10507).
2199 2012-01-26 Glenn Morris <rgm@gnu.org>
2201 * lread.c (syms_of_lread): Doc fix.
2203 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
2205 * coding.c (encode_designation_at_bol): Change return value to
2208 2012-01-25 Chong Yidong <cyd@gnu.org>
2210 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
2212 2012-01-21 Chong Yidong <cyd@gnu.org>
2214 * floatfns.c (Fcopysign): Make the second argument non-optional,
2215 since nil is not allowed anyway.
2217 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
2219 * process.c (read_process_output): Use p instead of XPROCESS (proc).
2220 (send_process): Likewise.
2222 2012-01-19 Martin Rudalics <rudalics@gmx.at>
2224 * window.c (save_window_save, Fcurrent_window_configuration)
2225 (Vwindow_persistent_parameters): Do not use Qstate.
2226 Rewrite doc-strings.
2228 2012-01-19 Kenichi Handa <handa@m17n.org>
2230 * character.c (char_width): New function.
2231 (Fchar_width, c_string_width, lisp_string_width):
2232 Use char_width (Bug#9496).
2234 2012-01-16 Martin Rudalics <rudalics@gmx.at>
2236 * window.c (Vwindow_persistent_parameters): New variable.
2237 (Fset_window_configuration, save_window_save): Handle persistent
2240 2012-01-14 Eli Zaretskii <eliz@gnu.org>
2242 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
2243 thrashing the stack of the thread. (Bug#9087)
2245 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
2247 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
2249 2012-01-11 Eli Zaretskii <eliz@gnu.org>
2251 * xdisp.c (rows_from_pos_range): Handle the case where the
2252 highlight ends on a newline. (Bug#10464)
2253 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
2254 he end column for display of highlight that ends on a newline
2257 2012-01-11 Glenn Morris <rgm@gnu.org>
2259 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
2260 from load-path also when installation-directory is nil. (Bug#10208)
2262 2012-01-10 Glenn Morris <rgm@gnu.org>
2264 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
2266 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
2267 Update template values to be closer to their typical values these days.
2269 2012-01-09 Eli Zaretskii <eliz@gnu.org>
2271 * xdisp.c (rows_from_pos_range): Accept additional argument
2272 DISP_STRING, and accept any glyph in a row whose object is that
2273 string as eligible for mouse highlight. Fixes mouse highlight of
2274 display strings from overlays. (Bug#10464)
2276 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
2278 emacs: fix an auto-save permissions race condition (Bug#10400)
2279 * fileio.c (auto_saving_dir_umask): New static var.
2280 (Fmake_directory_internal): Use it.
2281 (do_auto_save_make_dir): Set it, instead of invoking chmod after
2282 creating the directory. The old code temporarily assigns
2283 too-generous permissions to the directory.
2284 (do_auto_save_eh): Clear it.
2285 (Fdo_auto_save): Catch all errors, not just file errors, so
2286 that the var is always cleared.
2288 2012-01-07 Eli Zaretskii <eliz@gnu.org>
2290 * search.c (scan_buffer): Pass character positions to
2291 know_region_cache, not byte positions. (Bug#6540)
2293 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
2295 * w32.c (sys_rename): Report EXDEV when rename of a directory
2296 fails because the target is on another logical disk. (Bug#10284)
2298 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
2300 * xterm.c (x_embed_request_focus): New function.
2302 * xterm.h: Add prototype.
2304 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
2306 2012-01-05 Glenn Morris <rgm@gnu.org>
2308 * emacs.c (emacs_copyright): Update short copyright year to 2012.
2310 2012-01-01 Eli Zaretskii <eliz@gnu.org>
2312 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
2313 Load gnutls_transport_set_lowat only if GnuTLS version is below
2315 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
2316 GnuTLS versions below 2.11.1.
2318 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
2320 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
2321 to the doc string advising against its use for altering the way
2322 windows are scrolled.
2324 2011-12-28 Kenichi Handa <handa@m17n.org>
2326 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
2327 coding-system ASCII compatible only when it does not produce BOM
2328 on encoding (Bug#10383).
2330 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
2332 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
2334 (create_and_show_popup_menu): Always use menu_position_func for
2337 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
2339 * callint.c (Fcall_interactively): Don't truncate prompt string.
2341 2011-12-23 Eli Zaretskii <eliz@gnu.org>
2343 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
2344 property that ends at ZV, so that the bidi iteration could be
2345 resumed from there (after widening). (Bug#10360)
2347 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
2349 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
2351 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
2353 * nsterm.m (x_free_frame_resources):
2354 Release f->output_data.ns->miniimage.
2355 (ns_index_color): Fix indentation. Do not retain
2356 color_table->colors[i].
2358 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
2361 * nsfns.m (x_set_background_color): Assign return value from
2362 ns_index_color to face-background instead of NSColor*.
2363 (ns_implicitly_set_icon_type): Fix indentation.
2364 Change assignment in for loop to comparison.
2366 * emacs.c (ns_pool): New variable.
2367 (main): Assign ns_pool.
2368 (Fkill_emacs): Call ns_release_autorelease_pool.
2370 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
2371 autorelease fdesc, release fdAttrs and tdict.
2372 (ns_get_covering_families): Release charset.
2373 (ns_findfonts): Release NSFontDescriptor created with new.
2374 (ns_uni_to_glyphs): Fix indentation.
2375 (setString): Release attrStr before assigning new value.
2377 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2379 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
2381 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
2382 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
2384 2011-12-18 David Reitter <reitter@cmu.edu>
2386 * nsterm.m (ns_term_init): Subscribe for notifications
2387 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
2388 to method trackingNotification in EmacsMenu.
2390 * nsmenu.m (trackingMenu): New variable.
2391 (trackingNotification): New method (from Aquamacs).
2392 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
2393 from Aquamacs (Bug#7030).
2395 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2397 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
2398 (symbol_to_nsstring): Fix indentation.
2399 (ns_symbol_to_pb): New function.
2400 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
2401 (Fns_rotate_cut_buffers_internal): Remove.
2402 (Fns_store_selection_internal): Rename from
2403 Fns_store_cut_buffer_internal.
2404 (ns_get_foreign_selection, Fx_own_selection_internal)
2405 (Fx_disown_selection_internal, Fx_selection_exists_p)
2406 (Fns_get_selection_internal, Fns_store_selection_internal):
2407 Use ns_symbol_to_pb and check if return value is nil.
2408 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
2409 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
2410 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
2411 renamed to Sns_store_selection_internal.
2412 (ns_handle_selection_request): Move code to Fx_own_selection_internal
2413 and remove this function.
2414 (ns_handle_selection_clear): Remove, never used.
2415 (Fx_own_selection_internal): Move code from ns_handle_selection_request
2418 2011-12-17 Ken Brown <kbrown@cornell.edu>
2420 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
2421 GID is unknown (Bug#10257).
2423 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
2425 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
2426 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
2427 which caused a build failure on GNU/Linux IA-64. This problem was
2428 introduced by my 2011-10-07 patch.
2430 2011-12-15 Juri Linkov <juri@jurta.org>
2432 * image.c (imagemagick_error): New function. (Bug#10112)
2433 (imagemagick_load_image): Comment out `MagickSetResolution' call.
2434 Use `imagemagick_error' where ImageMagick functions return
2436 (Fimagemagick_types): Add `Fnreverse' to return the list in the
2439 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2441 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
2442 fill background (Bug#8992).
2444 2011-12-13 Martin Rudalics <rudalics@gmx.at>
2446 * window.c (Vwindow_combination_resize)
2447 (Vwindow_combination_limit): Use t instead of non-nil in
2449 (Vrecenter_redisplay): Add first sentence of doc-string on
2451 (Frecenter): Fix doc-string typo.
2453 2011-12-11 Kenichi Handa <handa@m17n.org>
2455 * coding.c (Funencodable_char_position): Pay attention to the
2456 buffer text relocation (Bug#9389).
2458 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2460 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
2461 gtk_init (Bug#10100).
2463 2011-12-10 Eli Zaretskii <eliz@gnu.org>
2465 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
2466 IT->string is nil. (Bug#10263)
2468 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2470 * nsterm.h (x_free_frame_resources): Declare.
2472 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
2473 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
2475 * nsterm.h (ns_get_defaults_value): Declare.
2477 * nsterm.m (ns_default): Call ns_get_defaults_value.
2479 2011-12-09 Eli Zaretskii <eliz@gnu.org>
2481 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
2484 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2486 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
2487 that where the value of an _OBJC_* symbol points to is in the .bss
2488 section (Bug#10240).
2490 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2492 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2493 after the loop to call ccl_driver at least once (Bug#8619).
2495 2011-12-08 Kenichi Handa <handa@m17n.org>
2497 * ftfont.c (get_adstyle_property): Fix previous change
2500 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
2502 * w32.c (init_environment): If no_site_lisp, remove site-lisp
2503 dirs from the default value of EMACSLOADPATH (bug#10208).
2505 2011-12-07 Glenn Morris <rgm@gnu.org>
2507 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
2508 installation and source directories as well. (Bug#10208)
2510 2011-12-06 Chong Yidong <cyd@gnu.org>
2512 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
2514 2011-12-06 Glenn Morris <rgm@gnu.org>
2516 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
2517 as an error, not just -1. (Bug#10217)
2519 2011-12-05 Chong Yidong <cyd@gnu.org>
2521 * keyboard.c (process_special_events): New function.
2522 (swallow_events, Finput_pending_p): Use it (Bug#10195).
2524 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
2526 * coding.c (encode_designation_at_bol): Don't use uninitialized
2527 local variable (Bug#9318).
2529 2011-12-05 Kenichi Handa <handa@m17n.org>
2531 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
2532 return Qnil (Bug#8046, Bug#10193).
2534 2011-12-05 Kenichi Handa <handa@m17n.org>
2536 * coding.c (encode_designation_at_bol): New args charbuf_end and
2537 dst. Return the number of produced bytes. Callers changed.
2538 (coding_set_source): Return how many bytes coding->source was
2540 (coding_set_destination): Return how many bytes
2541 coding->destination was relocated.
2542 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
2543 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
2545 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2547 * coding.c (CODING_CHAR_CHARSET_P): New macro.
2548 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
2551 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
2553 The following changes are to fix Bug#9318.
2555 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
2556 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
2557 (encode_coding_iso_2022, encode_coding_sjis)
2558 (encode_coding_big5, encode_coding_charset): Use the above macros.
2560 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
2562 * lisp.h (process_quit_flag): Fix external declaration.
2564 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
2566 Don't macro-inline non-performance-critical code.
2567 * eval.c (process_quit_flag): New function.
2568 * lisp.h (QUIT): Use it.
2570 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
2572 * nsfns.m (get_geometry_from_preferences): New function.
2573 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
2575 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
2577 * emacs.c (Qkill_emacs): Define.
2578 (syms_of_emacs): Initialize it.
2579 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
2580 Qquit_flag to `kill-emacs' instead.
2581 (quit_throw_to_read_char): Add parameter `from_signal'.
2582 All callers changed. Call Fkill_emacs if requested and safe.
2583 * lisp.h (QUIT): Call Fkill_emacs if requested.
2585 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
2587 * widget.c (update_wm_hints): Return if wmshell is null.
2588 (widget_update_wm_size_hints): New function.
2590 * widget.h (widget_update_wm_size_hints): Declare.
2592 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
2593 widget_update_wm_size_hints (Bug#10104).
2595 2011-12-03 Eli Zaretskii <eliz@gnu.org>
2597 * xdisp.c (handle_invisible_prop): If the invisible text ends just
2598 before a newline, prepare the bidi iterator for consuming the
2599 newline, and keep the current paragraph direction. (Bug#10183)
2600 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
2602 2011-12-02 Juri Linkov <juri@jurta.org>
2604 * search.c (Fword_search_regexp): New Lisp function created from
2605 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
2606 (Fword_search_backward, Fword_search_forward)
2607 (Fword_search_backward_lax, Fword_search_forward_lax):
2608 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
2609 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
2611 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
2613 * fileio.c (Finsert_file_contents): Move after-change-function call
2614 to before the "handled:" label, since all "goto handled" appear in
2615 cases where the *-change-functions have already been properly called
2618 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
2620 * keyboard.c (interrupt_signal): Don't call kill-emacs when
2621 waiting for input. (Bug#10169)
2623 2011-11-30 Eli Zaretskii <eliz@gnu.org>
2625 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
2626 verifies glyph row's hash code--we have just reallocated the
2627 glyphs, so their contents can be complete garbage. (Bug#10164)
2629 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
2631 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
2633 2011-11-30 Eli Zaretskii <eliz@gnu.org>
2635 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
2636 attributes are tested _before_ calling verify_row_hash, to protect
2637 against GCC re-ordering of the tests. (Bug#10164)
2639 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
2641 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
2643 * xterm.c (handle_one_xevent): Only set async_visible and friends
2644 if net_wm_state_hidden_seen is non-zero (Bug#10002)
2645 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2646 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
2648 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
2650 Remove GCPRO-related macros that exist only to avoid shadowing locals.
2651 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
2652 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
2653 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
2654 All uses changed to use GCPRO1 etc.
2655 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
2656 Revert to old implementation (i.e., before 2011-03-11).
2658 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2660 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
2661 of scroll runs so as to avoid assigning disabled bogus rows and
2662 unnecessary graphics copy operations.
2664 2011-11-27 Eli Zaretskii <eliz@gnu.org>
2666 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
2667 (snprintf) [_MSC_VER]: Redirect to _snprintf.
2668 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
2669 (malloc, free, realloc, calloc): Redirect to e_* only when
2672 * lisp.h (GCTYPEBITS): Move before first use.
2673 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
2674 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
2675 this macro definition.
2677 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
2680 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
2682 * gtkutil.c (xg_create_frame_widgets):
2683 Call gtk_window_set_has_resize_grip (FALSE) if that function is
2684 present with Gtk+ 2.0.
2686 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
2688 * fileio.c (Finsert_file_contents): Undo previous change; see
2689 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
2691 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
2693 Rename locals to avoid shadowing.
2694 * fileio.c (Finsert_file_contents):
2695 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
2696 * process.c (wait_reading_process_output):
2697 Rename inner 'proc' to 'p' to avoid shadowing.
2698 Indent for consistency with usual Emacs style.
2700 2011-11-25 Eli Zaretskii <eliz@gnu.org>
2702 * xdisp.c (redisplay_window): If cursor row is not fully visible
2703 after recentering, and scroll-conservatively is set to a large
2704 number, scroll window by a few more lines to make the cursor fully
2705 visible and out of scroll-margin. (Bug#10105)
2706 (start_display): Don't move to the next line if the display should
2707 start at a newline that is part of a display vector or an overlay
2710 2011-11-24 Juri Linkov <juri@jurta.org>
2712 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
2713 after the `MagickPingImage' call. (Bug#10112)
2715 2011-11-23 Chong Yidong <cyd@gnu.org>
2717 * window.c (Fcoordinates_in_window_p): Accept only live windows.
2719 2011-11-23 Martin Rudalics <rudalics@gmx.at>
2721 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
2722 making another buffer current. (Bug#10114)
2724 2011-11-23 Glenn Morris <rgm@gnu.org>
2726 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
2728 2011-11-23 Chong Yidong <cyd@gnu.org>
2730 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
2731 using it (Bug#5984).
2733 2011-11-22 Eli Zaretskii <eliz@gnu.org>
2735 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
2736 and header-lines, as they don't have one computed for them.
2739 * .gdbinit (prow): Make displayed values more self-explaining.
2740 Add row's hash code.
2742 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
2744 * process.c (wait_reading_process_output): Fix asynchrounous
2745 GnuTLS socket handling on some versions of the GnuTLS library.
2746 (wait_reading_process_output): Add comment and URL.
2748 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
2750 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
2752 2011-11-21 Chong Yidong <cyd@gnu.org>
2754 * window.c (Fnext_window, Fprevious_window): Doc fix.
2756 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
2758 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
2760 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
2762 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
2764 2011-11-20 Martin Rudalics <rudalics@gmx.at>
2766 * window.c (Fset_window_combination_limit): Rename argument
2768 (Vwindow_combination_limit): Remove "status" from doc-string.
2770 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
2772 * m/ibms390.h: Remove.
2773 * m/ibms390x.h: Don't include "ibms390.h".
2775 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
2777 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
2778 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
2780 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
2782 * casetab.c (Fset_case_table):
2783 * charset.c (Fcharset_after): Fix typos.
2785 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
2787 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
2788 Otherwise, valgrind does not work on some platforms.
2789 Problem reported by Andreas Schwab in
2790 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
2791 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
2792 is set, removing the need for VIRT_ADDRESS_VARIES.
2793 (PURE_P): Use a more-efficient implementation that needs just one
2794 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
2795 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
2796 to 4 (xorl, subq, cmpq, setbe).
2797 * alloc.c (pure): Always extern now, since that's the
2798 VIRT_ADDR_VARIES behavior.
2799 (PURE_POINTER_P): Use a single comparison, not two, for
2800 consistency with the new puresize.h.
2801 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
2802 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
2803 Remove VIRT_ADDR_VARIES no longer needed.
2805 2011-11-19 Eli Zaretskii <eliz@gnu.org>
2807 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
2808 (erase_phys_cursor, update_window_cursor, show_mouse_face)
2809 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
2810 behave as if the cursor position were at the window margin.
2812 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
2813 and the cursor position is out of bounds, behave as if the cursor
2814 position were at the window margin. (Bug#10075)
2816 2011-11-18 Chong Yidong <cyd@gnu.org>
2818 * window.c (Fwindow_combination_limit): Make first argument
2819 non-optional, since it is meaningless for live windows like the
2822 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
2824 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
2826 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
2828 * intervals.c: Fix grafting over the whole buffer (bug#10071).
2829 (graft_intervals_into_buffer): Simplify.
2831 2011-11-18 Eli Zaretskii <eliz@gnu.org>
2833 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
2834 hash values of the two rows.
2835 (copy_row_except_pointers): Preserve the used[] arrays and the
2836 hash values of the two rows. (Bug#10035)
2837 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
2839 * xdisp.c (row_hash): New function, body extracted from
2840 compute_line_metrics.
2841 (compute_line_metrics): Call row_hash, instead of computing the
2844 * dispnew.c (verify_row_hash): Call row_hash for computing the
2845 hash code of a row, instead of duplicating code from xdisp.c.
2847 * dispextern.h (row_hash): Add prototype.
2849 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
2851 * frame.c (delete_frame): Don't delete the terminal when the last
2852 X frame is closed if emacs is built with GTK toolkit.
2854 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
2856 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
2858 2011-11-17 Martin Rudalics <rudalics@gmx.at>
2860 * window.c (Vwindow_splits): Rename to
2861 Vwindow_combination_resize. Suggested by Juri Linkov.
2862 (Fsplit_window_internal): Use Vwindow_combination_resize instead
2865 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
2867 * nsfns.m (Fns_font_name):
2868 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
2870 2011-11-16 Martin Rudalics <rudalics@gmx.at>
2872 * window.h (window): Rename slot "nest" to "combination_limit".
2873 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
2874 (Fset_window_nest): Rename to Fset_window_combination_limit.
2875 (Vwindow_nest): Rename to Vwindow_combination_limit.
2876 (recombine_windows, make_parent_window, make_window)
2877 (Fsplit_window_internal, saved_window)
2878 (Fset_window_configuration, save_window_save): Rename all
2879 occurrences of window_nest to window_combination_limit.
2881 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
2883 * image.c (imagemagick_load_image): Fix typo.
2885 2011-11-14 Eli Zaretskii <eliz@gnu.org>
2887 * xdisp.c (display_line): Move the call to
2888 highlight_trailing_whitespace before the call to
2889 compute_line_metrics, since the latter needs to see the final
2890 faces of all the glyphs to compute ROW's hash value.
2891 Fixes assertion violations in row_equal_p. (Bug#10035)
2893 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
2895 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
2896 just return (bug#10044).
2898 2011-11-12 Eli Zaretskii <eliz@gnu.org>
2900 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
2901 with user-defined heap size. Bump the default size of the temacs
2902 heap to 27MB, to avoid memory warning when running temacs.
2903 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
2905 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
2906 current_matrix and desired_matrix. (Bug#9990)
2907 (verify_row_hash) [XASSERTS]: New function.
2908 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
2909 that the hash value of glyph rows is correct.
2911 2011-11-12 Martin Rudalics <rudalics@gmx.at>
2913 * window.h (window): Remove splits slot.
2914 * window.c (Fwindow_splits, Fset_window_splits): Remove.
2915 (Fdelete_other_windows_internal, make_parent_window)
2916 (make_window, Fsplit_window_internal, Fdelete_window_internal)
2917 (Fset_window_configuration, save_window_save): Don't deal with
2918 split status of windows.
2919 (saved_window): Remove splits slot.
2920 (Vwindow_splits): Rewrite doc-string.
2922 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
2924 * xfns.c (unwind_create_frame):
2925 * nsfns.m (unwind_create_frame):
2926 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
2927 Vframe_list (Bug#9999).
2929 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
2931 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
2933 2011-11-11 Kenichi Handa <handa@m17n.org>
2935 * callproc.c (Fcall_process): Set the member dst_multibyte of
2938 2011-11-11 Johan Bockgård <bojohan@gnu.org>
2940 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
2941 avoid a crash (bug#9496).
2943 2011-11-09 Chong Yidong <cyd@gnu.org>
2945 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
2946 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
2948 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
2950 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
2952 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
2954 Avoid some portability problems by eschewing 'extern inline' functions.
2955 The trivial performance wins aren't worth the portability hassles; see
2956 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
2958 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
2959 (window_box_width, window_box_left, window_box_left_offset)
2960 (window_box_right, window_box_right_offset): Undo previous change,
2961 by removing the "extern"s.
2962 * intervals.c (adjust_intervals_for_insertion)
2963 (adjust_intervals_for_deletion): Undo previous change,
2964 making these static again.
2965 (offset_intervals, temp_set_point_both, temp_set_point)
2966 (copy_intervals_to_string): No longer inline.
2967 * xdisp.c (window_text_bottom_y, window_box_width)
2968 (window_box_height, window_box_left_offset)
2969 (window_box_right_offset, window_box_left, window_box_right)
2970 (window_box): No longer inline.
2972 2011-11-08 Chong Yidong <cyd@gnu.org>
2974 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
2975 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
2976 Signal an error if not a live window.
2977 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
2978 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
2980 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
2982 * lisp.h (syms_of_abbrev): Remove declaration.
2983 Reported by CHENG Gao <chenggao@royau.me>.
2985 2011-11-07 Eli Zaretskii <eliz@gnu.org>
2987 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
2988 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
2989 of temacs in GUI mode.
2991 2011-11-07 Martin Rudalics <rudalics@gmx.at>
2993 * window.h: Declare delete_all_child_windows instead of
2994 delete_all_subwindows.
2995 * window.c (Fwindow_nest, Fset_window_nest)
2996 (Fset_window_new_total, Fset_window_new_normal)
2997 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
2998 (delete_all_subwindows): Rename to delete_all_child_windows.
2999 (Fdelete_other_windows_internal, Fset_window_configuration):
3000 Call delete_all_child_windows instead of delete_all_subwindows.
3001 * frame.c (delete_frame): Call delete_all_child_windows instead
3002 of delete_all_subwindows.
3004 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
3006 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
3007 This is also needed for porting to any host where GC_MARK_STACK is
3008 not GC_MAKE_GCPROS_NOOPS.
3009 (which_symbols): Use it.
3011 2011-11-07 Kenichi Handa <handa@m17n.org>
3013 * coding.c (coding_set_destination): Check coding->src_pos only
3014 when coding->src_object is a buffer (bug#9910).
3016 * process.c (send_process): Set the member src_multibyte of coding
3017 to 0 (bug#9911) when sending a unibyte text.
3019 * callproc.c (Fcall_process): Set the member src_multibyte of
3020 process_coding to 0 (bug#9912).
3022 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3024 * xmenu.c (cleanup_widget_value_tree): New function.
3025 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
3026 calling free_menubar_widget_value_tree directly (Bug#9830).
3028 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
3030 Fix some portability problems with 'inline'.
3031 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3032 (window_box_width, window_box_left, window_box_left_offset)
3033 (window_box_right, window_box_right_offset): Declare extern.
3034 Otherwise, these inline functions do not conform to C99 and
3035 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
3036 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
3037 * intervals.c (adjust_intervals_for_insertion)
3038 (adjust_intervals_for_deletion): Now extern, because otherwise the
3039 extern inline functions 'offset_intervals' couldn't refer to it.
3040 (static_offset_intervals): Remove.
3041 (offset_intervals): Rewrite using the old contents of
3042 static_offset_intervals. The old version didn't conform to C99
3043 because an extern inline function contained a reference to an
3044 identifier with static linkage.
3046 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
3048 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
3051 2011-11-06 Eli Zaretskii <eliz@gnu.org>
3053 * xdisp.c (init_iterator, reseat_to_string): Don't set the
3054 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
3055 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
3056 return Qleft_to_right.
3058 2011-11-06 Chong Yidong <cyd@gnu.org>
3060 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
3061 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
3062 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
3063 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
3064 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
3065 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
3066 (Fwindow_vscroll): Doc fix.
3067 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
3068 argument, since it makes no sense to pass a live window and for
3069 consistency with window-child.
3071 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
3073 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
3076 2011-11-05 Jason Rumney <jasonr@gnu.org>
3078 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
3079 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
3081 (add_font_entity_to_list): Fix logic errors in mixed boolean and
3082 bitwise arithmetic preventing use of unicode-sip and non-truetype
3085 2011-11-05 Eli Zaretskii <eliz@gnu.org>
3087 * s/ms-w32.h (fstat, stat, utime): Move redirections to
3090 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
3091 initialization code to keep similarity to xfns.c after changes
3094 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
3096 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
3097 (unwind_create_frame): New function (Bug#9943).
3098 (Fx_create_frame): Restructure code to be more similar to the one in
3099 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
3100 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
3101 Move terminal->reference_count++ just before making the frame official
3104 * nsterm.m (x_free_frame_resources): New function.
3105 (x_destroy_window): Move code to x_free_frame_resources.
3107 * xfns.c (unwind_create_frame): Fix comment.
3108 (Fx_create_frame, x_create_tip_frame):
3109 Move terminal->reference_count++ just before making the frame
3110 official. Move initialization of image_cache_refcount and
3111 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
3113 2011-11-05 Eli Zaretskii <eliz@gnu.org>
3115 Support MSVC build with newer versions of Visual Studio.
3116 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
3117 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
3120 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
3121 which are not supported by MSVC.
3122 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
3123 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
3125 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
3127 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
3129 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
3131 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
3133 Support MSVC build with newer versions of Visual Studio.
3134 * w32.c: Don't include w32api.h for MSVC.
3135 (init_environment) [_MSC_VER]: Call sys_access, not _access.
3137 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
3138 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
3139 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
3140 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
3142 (alloca) [_MSC_VER]: Define to _alloca.
3144 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
3146 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
3148 2011-11-04 Eli Zaretskii <eliz@gnu.org>
3150 * xdisp.c (note_mouse_highlight): If either of
3151 previous/next-single-property-change returns nil, treat that as
3152 the beginning or the end of the buffer. (Bug#9955)
3154 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
3156 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
3157 label is not null (Bug#9951).
3158 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
3161 2011-11-04 Eli Zaretskii <eliz@gnu.org>
3163 * window.c (Fwindow_body_size): Mention in the doc string that the
3164 return value is in frame's canonical units. (Bug#9949)
3166 2011-11-03 Eli Zaretskii <eliz@gnu.org>
3168 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
3170 * w32fns.c (unwind_create_frame): If needed, free the glyph
3171 matrices of the partially constructed frame. (Bug#9943)
3172 * xfns.c (unwind_create_frame): Likewise.
3174 2011-11-01 Eli Zaretskii <eliz@gnu.org>
3176 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
3177 Don't stop backward scan on the continuation glyph, even though
3178 its CHARPOS is positive.
3179 (mouse_face_from_buffer_pos, note_mouse_highlight):
3180 Rename cover_string to disp_string.
3182 2011-11-01 Martin Rudalics <rudalics@gmx.at>
3184 * window.c (temp_output_buffer_show): Don't use
3185 Vtemp_buffer_show_specifiers.
3186 (Vtemp_buffer_show_specifiers): Remove unused variable.
3188 2011-10-30 Eli Zaretskii <eliz@gnu.org>
3190 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
3191 past the beginning of the current glyph matrix.
3193 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
3195 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
3196 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
3197 HAVE_GTK3 (Bug#9869).
3199 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
3200 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
3202 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
3204 * xterm.c: Declare x_handle_net_wm_state to return int.
3205 (handle_one_xevent): Check if we are iconified but don't have
3206 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
3207 (get_current_wm_state): Return non-zero if not hidden,
3208 check for _NET_WM_STATE_HIDDEN (Bug#9893).
3209 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
3210 (x_handle_net_wm_state): Return what get_current_wm_state returns.
3211 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
3213 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
3215 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
3216 so that this new function doesn't get optimized away by a
3217 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
3219 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3221 * frame.h (MOUSE_HL_INFO): Remove excess parens.
3223 2011-10-29 Eli Zaretskii <eliz@gnu.org>
3225 Fix the `xbytecode' command.
3226 * .gdbinit (xprintbytestr): New command.
3227 (xwhichsymbols): Rename from `which'; all callers changed.
3228 (xbytecode): Print the byte-code string as well.
3230 2011-10-29 Kim Storm <storm@cua.dk>
3232 * alloc.c (which_symbols): New function.
3234 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3236 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
3239 2011-10-29 Glenn Morris <rgm@gnu.org>
3241 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
3242 Not clear what it was for, and it causes various bugs. (Bug#9839)
3244 2011-10-28 Eli Zaretskii <eliz@gnu.org>
3246 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
3247 possible random value that matches one of those tested as
3248 condition to clear the mouse face.
3250 2011-10-28 Chong Yidong <cyd@gnu.org>
3252 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
3254 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
3256 * window.c (make_window): Initialize phys_cursor_on_p.
3258 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
3260 * lisp.h (struct Lisp_Symbol): Update comments.
3262 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
3264 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
3266 2011-10-28 Eli Zaretskii <eliz@gnu.org>
3268 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
3269 <oslsachem@gmail.com> for helping to debug this.
3271 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
3272 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
3273 (g_b_init_get_glyph_outline_w): New static variables.
3274 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
3275 (GetGlyphOutlineW_Proc): New typedefs.
3276 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
3277 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
3279 (w32font_open_internal, compute_metrics):
3280 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
3281 instead of calling the "wide" APIs directly.
3283 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
3285 * w32.h (syms_of_w32font): Add prototype.
3287 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
3289 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
3290 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
3291 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
3292 (Fmove_to_window_line): Doc fix.
3294 2011-10-27 Chong Yidong <cyd@gnu.org>
3296 * process.c (make_process): Set gnutls_state to NULL.
3298 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
3299 non-NULL, regardless of GNUTLS_INITSTAGE.
3300 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
3301 an error. Set process slots as soon as we allocate them.
3303 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
3305 2011-10-27 Chong Yidong <cyd@gnu.org>
3307 * gnutls.c (emacs_gnutls_deinit): New function.
3308 Deallocate credentials structures as well as calling gnutls_deinit.
3309 (Fgnutls_deinit, Fgnutls_boot): Use it.
3311 * process.c (make_process): Initialize GnuTLS credentials to NULL.
3312 (deactivate_process): Call emacs_gnutls_deinit.
3314 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
3316 * image.c (x_create_x_image_and_pixmap):
3317 * w32.c (sys_rename, w32_delayed_load):
3318 * w32font.c (fill_in_logfont):
3319 * w32reg.c (x_get_string_resource): Silence compiler warnings.
3321 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
3323 * w32fns.c (w32_default_color_map): New function,
3324 extracted from Fw32_default_color_map.
3325 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
3327 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
3329 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
3331 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
3333 * keyboard.c (test_undefined): New function (bug#9751).
3334 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
3336 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
3338 * sysdep.c (init_sys_modes): Fix the check for the controlling
3339 terminal (Bug#6649).
3341 2011-10-20 Eli Zaretskii <eliz@gnu.org>
3343 * dispextern.h (struct bidi_it): New member next_en_type.
3345 * bidi.c (bidi_line_init): Initialize the next_en_type member.
3346 (bidi_resolve_explicit_1): When next_en_pos is valid for the
3347 current character, check also for next_en_type being WEAK_EN.
3348 (bidi_resolve_weak): Don't enter the expensive loop if the current
3349 position is before next_en_pos. Record the bidi type of the first
3350 non-ET, non-BN character we find, in addition to its position.
3351 (bidi_level_of_next_char): Invalidate next_en_type when
3352 next_en_pos is over-stepped.
3354 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
3356 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
3357 * editfns.c: Rewrite current-time-zone so that it invokes
3358 the equivalent of (format-time-string "%Z") to get the time zone name.
3359 This fixes a bug when the time zone name contains characters that
3360 need converting from the system time locale to Emacs internal format.
3361 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
3362 that patch fixed format-time-string to do the conversion, but
3363 I forgot to fix current-time-zone.
3364 (format_time_string): New function, containing most of
3365 what Fformat_time_string used to contain.
3366 (Fformat_time_string): Rewrite in terms of format_time_string.
3367 This doesn't change this function's behavior.
3368 (current-time-zone): Rewrite to use format_time_string.
3369 This fixes the bug reported by Michael Schierl in
3370 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
3371 Jason Rumney's 2007-06-07 change worked around this bug, but
3373 * systime.h (tzname, timezone): Remove no-longer-used declarations.
3375 2011-10-19 Eli Zaretskii <eliz@gnu.org>
3377 * xdisp.c (start_display): If the character at POS is displayed
3378 via a display vector, reset IT->current.dpvec_index to zero.
3379 (try_window_reusing_current_matrix): If a line ends in a display
3380 vector or the next line starts in a display vector, continue
3381 redrawing the window even though the character position of
3382 start_row was reached.
3385 2011-10-18 Chong Yidong <cyd@gnu.org>
3387 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
3388 with nobreak-char-display too.
3390 2011-10-18 Eli Zaretskii <eliz@gnu.org>
3392 Fix part 3 of bug#9771.
3393 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
3394 (bidi_resolve_neutral): Don't enter the expensive loop looking for
3395 non-neutral characters if the current character is a paragraph
3396 separator (a.k.a. Newline). This avoids running the same
3397 expensive loop twice, once when we consume the preceding newline
3398 and the other time when the line actually needs to be displayed.
3399 Avoid the loop when we see neutrals on the base embedding level
3400 following a character whose directionality is the same as the
3401 paragraph's. This avoids running the expensive loop when a line
3402 ends in a long sequence of neutrals, like control characters.
3403 Add assertion against STRONG_AL type. Slightly rearrange code
3404 that determines the type of a neutral given the first non-neutral
3406 (bidi_level_of_next_char): Set next_en_pos to zero when
3407 invalidating its info.
3409 2011-10-17 Eli Zaretskii <eliz@gnu.org>
3411 * xdisp.c (push_display_prop): Determine whether to record string
3412 or buffer position by IT->string, not by IT->method. Allow
3413 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
3414 (move_it_vertically_backward): Don't look for character position
3415 immediately after the newline when in a continuation line.
3418 2011-10-15 Martin Rudalics <rudalics@gmx.at>
3420 * window.c (coordinates_in_window): Rewrite and delabelize
3421 vertical border check. (Bug#5357) (Bug#9618)
3423 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
3425 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
3426 errors in XSetWindowBorder (bug#9310).
3428 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
3430 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
3431 avoid crash when xmalloc overrun checking is enabled.
3433 2011-10-13 Eli Zaretskii <eliz@gnu.org>
3435 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
3436 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
3437 cursor motion with <left> and <right> arrow keys.
3439 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
3440 some callers set that themselves.
3442 2011-10-12 Eli Zaretskii <eliz@gnu.org>
3444 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
3445 display string and the previous row comes from the same string and
3446 is empty. (Bug#9739) (Bug#9738)
3448 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
3450 * doc.c (get_doc_string): Encode file name (bug#9735).
3452 2011-10-12 Eli Zaretskii <eliz@gnu.org>
3454 * bidi.c (bidi_level_of_next_char):
3455 * xdisp.c (get_visually_first_element): Remove old incorrect
3456 comments regarding the Unicode Line Separator character.
3458 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
3460 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
3462 * alloc.c (Fgc_status): Do not access beyond zombies array
3463 boundary if nzombies > MAX_ZOMBIES.
3464 * alloc.c (dump_zombies): Add missing format specifier.
3466 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
3468 * xdisp.c (set_cursor_from_row): Simplify conditionals,
3469 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
3471 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
3472 Some packages use them to denote characters with modifiers.
3474 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
3476 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
3477 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
3478 matching a pp-number. Rename parameter var to var1.
3480 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
3482 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
3484 2011-10-08 Glenn Morris <rgm@gnu.org>
3486 * callint.c (Fcall_interactively): Give a more explicit error for the
3487 'c' case with a non-character input. (Bug#8479)
3489 2011-10-08 Eli Zaretskii <eliz@gnu.org>
3491 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
3493 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
3494 lines that are hscrolled on the left.
3496 * dispnew.c (buffer_posn_from_coords): Account for a possible
3497 presence of header-line. (Bug#4426)
3499 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
3501 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
3502 Don't advertise functionality which we discourage or doesn't work.
3504 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
3506 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
3507 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
3508 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
3509 this makes Emacs dump core during garbage collection on rare
3510 occasions. sizeof is obviously inferior to offsetof here, so
3511 stick with offsetof.
3512 (GC_POINTER_ALIGNMENT): New macro.
3513 (mark_memory): Omit 3rd (offset) arg; caller changed.
3514 Don't assume EMACS_INT alignment is the same as pointer alignment.
3516 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
3518 * keyboard.c (read_key_sequence_remapped): New var.
3519 (read_key_sequence): Compute remapping in the right buffer.
3520 (command_loop_1): Use read_key_sequence's remapping directly.
3522 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
3524 * dired.c (file_name_completion): Don't expand file name.
3525 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
3526 before checking file name handler.
3528 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
3529 they've been requested explicitly (bug#9591).
3531 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
3533 * keymap.c (Fsingle_key_description): Use make_specified_string
3534 instead of build_string to build string from push_key_description.
3537 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3539 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
3540 This fixes a Y2038 bug on 64-bit hosts.
3541 * buffer.c (reset_buffer):
3542 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
3543 (Fclear_buffer_auto_save_failure):
3544 Use 0, not -1, to represent an unset failure time, since time_t
3545 might not be signed.
3547 Remove dependency on glibc malloc internals.
3548 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3549 Move back here from lisp.h, but with their new implementations.
3550 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3551 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
3552 * charset.c (charset_table_init): New static var.
3553 (syms_of_charset): Use it instead of xmalloc. This removes a
3554 dependency on glibc malloc internals. See Eli Zaretskii's comment in
3555 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
3556 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3557 Move back to alloc.c.
3558 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3559 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
3561 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
3563 * nsterm.m (windowDidResize): Call x_set_window_size only when
3564 ns_in_resize is true. Otherwise set pixelwidth/height and
3565 call change_frame_size (Bug#9628).
3567 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3569 Port --enable-checking=all to Fedora 14 x86-64.
3570 * charset.c (syms_of_charset): Also account for glibc malloc's
3571 internal overhead when calculating the initial malloc maximum.
3573 Port --enable-checking=all to Fedora 14 x86.
3574 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3576 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
3577 (overrun_check_realloc, overrun_check_free):
3578 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
3579 That way, xmalloc returns a properly-aligned pointer even if
3580 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
3581 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
3582 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
3583 into account when calculating the initial malloc maximum.
3584 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3585 Move here from alloc.c, so that charset.c can use it too.
3586 Properly align; the old code wasn't right for common 32-bit hosts
3587 when configured with --enable-checking=all.
3588 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3589 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
3591 2011-09-29 Eli Zaretskii <eliz@gnu.org>
3593 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
3596 2011-09-28 Eli Zaretskii <eliz@gnu.org>
3598 * xdisp.c (compute_display_string_end): If there's no display
3599 string at CHARPOS, return -1.
3601 * bidi.c (bidi_fetch_char): When compute_display_string_end
3602 returns a negative value, treat the character as a normal
3603 character not covered by a display string. (Bug#9624)
3605 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
3607 * lread.c (Fread_from_string): Fix typo in docstring.
3609 2011-09-27 Eli Zaretskii <eliz@gnu.org>
3611 * xdisp.c (handle_invisible_prop): If invisible text ends on a
3612 newline, reseat the iterator instead of bidi-iterating there one
3613 character at a time. (Bug#9610)
3614 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
3615 TO_CHARPOS if the bidi iterator is at base embedding level.
3617 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
3619 * lread.c (readevalloop): Use correct code for NBSP.
3620 (read1): Likewise. (Bug#9608)
3622 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
3624 * dbusbind.c (Fdbus_register_signal): When service is not
3625 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
3627 2011-09-25 Glenn Morris <rgm@gnu.org>
3629 * buffer.c (truncate-lines): Doc fix.
3631 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
3633 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
3634 (Fset_window_next_buffers): Doc fix.
3636 2011-09-24 Glenn Morris <rgm@gnu.org>
3638 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
3640 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
3642 Fix minor problems found by static checking.
3643 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
3644 * indent.c (Fvertical_motion): Fix == vs = typo.
3646 2011-09-24 Eli Zaretskii <eliz@gnu.org>
3648 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
3649 Default value is now t. Doc fix.
3651 * indent.c (Fvertical_motion): Compute and apply the overshoot
3652 logic when moving up, not only when moving down. Fix the
3653 confusing name and values of the it_overshoot_expected variable;
3654 logic changes accordingly. (Bug#9254) (Bug#9549)
3656 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
3657 CHARPOS is covered by a display string which includes newlines.
3658 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
3659 is covered by a display string with embedded newlines.
3661 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
3663 * dbusbind.c (Fdbus_register_signal): Add match rule to
3664 Vdbus_registered_objects_table. (Bug#9581)
3665 (Fdbus_register_method, Vdbus_registered_objects_table):
3668 2011-09-24 Jim Meyering <meyering@redhat.com>
3670 do not ignore write error for any output size
3671 The previous change was incomplete.
3672 While it makes emacs --batch detect the vast majority of stdout
3673 write failures, errors were still ignored whenever the output size is
3674 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
3675 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
3676 && echo FAIL: ignored write error
3677 FAIL: ignored write error
3678 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
3679 && echo FAIL: ignored write error
3680 FAIL: ignored write error
3681 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
3683 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
3685 * emacs.c (Fkill_emacs): In noninteractive mode exit
3686 non-successfully if a write error occurred on stdout. (Bug#9574)
3688 2011-09-21 Eli Zaretskii <eliz@gnu.org>
3690 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
3693 * dispextern.h (struct it): Update the comment documenting what
3696 2011-09-20 Eli Zaretskii <eliz@gnu.org>
3698 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
3699 a display string, extend search for cursor position to end of row.
3700 (find_row_edges): If the row ends in a newline from a display
3701 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
3702 Handle the case of a display string with multiple newlines.
3703 (Fcurrent_bidi_paragraph_direction): Fix search for previous
3704 non-empty line. Fixes confusing cursor motion with arrow keys at
3705 the beginning of a line that starts with whitespace.
3707 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3709 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
3712 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
3714 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
3717 2011-09-18 Eli Zaretskii <eliz@gnu.org>
3719 * xdisp.c (display_line): Record maximum and minimum buffer
3720 positions even if no glyphs were produced (e.g., by a zero-width
3721 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
3722 buffer positions that will be removed from the glyph row because
3724 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
3725 column is beyond frame width: don't subtract 1 "pixel" when
3726 computing width of the stretch.
3727 (reseat_at_next_visible_line_start): Undo the change made on
3728 2011-09-17 that saved paragraph information and restored it after
3729 the call to `reseat'. (Bug#9545)
3731 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3733 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
3734 and turn window cursor on if cleared (Bug#9415).
3736 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
3738 * search.c (boyer_moore): Take unibyte characters from pattern
3739 literally. (Bug#9458)
3741 2011-09-18 Eli Zaretskii <eliz@gnu.org>
3743 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
3745 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
3747 Fix minor problem found by static checking.
3748 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
3749 initialized, to pacify gcc -Wuninitialized.
3751 * fileio.c: Report proper errno when syscall falls.
3752 (Finsert_file_contents): Save and restore errno,
3753 so that report_file_error outputs the correct diagnostic.
3754 (Fwrite_region) [CLASH_DETECTION]: Likewise.
3756 2011-09-18 Eli Zaretskii <eliz@gnu.org>
3758 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
3760 2011-09-17 Eli Zaretskii <eliz@gnu.org>
3762 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
3763 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
3765 2011-09-17 Eli Zaretskii <eliz@gnu.org>
3767 * xdisp.c (reseat_at_next_visible_line_start): Keep information
3768 about the current paragraph and restore it after the call to reseat.
3770 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
3771 (bidi_find_paragraph_start): Search back for paragraph beginning
3772 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
3773 (bidi_move_to_visually_next): Only trigger paragraph-related
3774 computations when the last character is a newline or at EOB, not
3775 just any NEUTRAL_B. (Bug#9470)
3777 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
3778 truncated lines if point is covered by a display string. (Bug#9524)
3780 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
3782 * xselect.c: Relax test for outgoing X longs (Bug#9498).
3783 (cons_to_x_long): New function.
3784 (lisp_data_to_selection_data): Use it. Correct the test for
3785 short-versus-long data; it was negated. Break out of vector
3786 loop, for efficiency, when a long datum is discovered.
3788 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
3790 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
3792 2011-09-16 Eli Zaretskii <eliz@gnu.org>
3794 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
3795 GCC PR/17406) by declaring this function with external scope.
3797 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
3799 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
3800 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
3802 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
3804 * editfns.c (Fformat): Correctly handle text properties on "%%".
3806 2011-09-15 Eli Zaretskii <eliz@gnu.org>
3808 * xterm.c (x_draw_composite_glyph_string_foreground):
3809 * w32term.c (x_draw_composite_glyph_string_foreground):
3810 * term.c (encode_terminal_code):
3811 * composite.c (composition_update_it, get_composition_id):
3812 * xdisp.c (get_next_display_element)
3813 (fill_composite_glyph_string): Add comments about special meaning
3814 of TAB characters in a composition.
3816 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
3818 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
3819 This occurs when processing a multibyte format.
3820 Problem reported by Wolfgang Jenker.
3822 2011-09-15 Johan Bockgård <bojohan@gnu.org>
3824 * xdisp.c (try_cursor_movement): Only check for exact match if
3825 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
3827 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
3829 Remove unused external symbols.
3830 * dispextern.h (calc_pixel_width_or_height): Remove decl.
3831 * xdisp.c (calc_pixel_width_or_height): Now static.
3832 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
3833 * indent.c (check_display_width):
3834 * w32term.c: Fix comment to match code.
3835 * xterm.c, xterm.h (x_catching_errors): Remove.
3837 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
3839 * xselect.c: Use signed conversions more consistently (Bug#9498).
3840 (selection_data_to_lisp_data): Assume incoming selection data are
3841 signed integers, not unsigned. This is to be consistent with
3842 outgoing selection data, which was modified to use signed integers
3843 in as part of the fix to Bug#9196 in response to Jan D.'s comment
3844 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
3845 expects long, not unsigned long.
3847 2011-09-14 Eli Zaretskii <eliz@gnu.org>
3849 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
3850 computation of loop end. Reported by Johan Bockgård
3853 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
3855 * frame.c (Fother_visible_frames_p): Function deleted.
3857 2011-09-12 Eli Zaretskii <eliz@gnu.org>
3859 * indent.c (compute_motion): Process display vector front to back
3860 rather than the other way around. (Bug#2496)
3862 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
3864 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
3866 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
3868 * minibuf.c (Fread_from_minibuffer): Doc fix.
3870 2011-09-11 Eli Zaretskii <eliz@gnu.org>
3872 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
3873 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
3875 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3877 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
3878 value for non-existent files.
3880 2011-09-11 Eli Zaretskii <eliz@gnu.org>
3882 * fileio.c (Finsert_file_contents): If the file cannot be opened,
3883 set its "size" to -1. This will set the modtime_size field of
3884 the corresponding buffer to -1, which is what
3885 verify-visited-file-modtime expects for files that do not exist.
3888 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
3890 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
3892 * lisp.h: ... from here. push_key_description is no longer
3893 defined in keyboard.c, so its declaration should not be in
3894 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
3895 logically belongs with push_key_description.
3897 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
3899 * buffer.h: Include <sys/types.h> instead of <time.h>.
3900 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
3901 Problem reported by Herbert J. Skuhra.
3903 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
3905 * xml.c (parse_region): Make the parsing work for
3906 non-comment-starting XML files again (bug#9144).
3908 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
3910 * image.c (gif_load): Fix calculation of bottom and right corner.
3913 2011-09-10 Eli Zaretskii <eliz@gnu.org>
3915 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
3916 redisplay in small windows.
3918 2011-09-09 Eli Zaretskii <eliz@gnu.org>
3920 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
3922 2011-09-08 Martin Rudalics <rudalics@gmx.at>
3924 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
3925 Operate on live windows only.
3927 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
3929 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
3931 2011-09-07 Eli Zaretskii <eliz@gnu.org>
3933 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
3934 only under bidi iteration.
3936 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
3938 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
3940 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
3942 isnan: Fix porting problem to Solaris 10 with bundled gcc.
3943 Without this fix, the command to link temacs failed due to an
3944 undefined symbol __builtin_isnan. This is because
3945 /usr/include/iso/math_c99.h #defines isnan(x) to
3946 __builtin_isnan(x), but the bundled gcc, which identifies itself
3947 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
3949 * floatfns.c (isnan): #undef, and then #define to a clone of
3951 (Fisnan): Always define, since it's always available now.
3952 (syms_of_floatfns): Always define isnan at the Lisp level.
3954 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
3956 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
3958 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
3960 * fileio.c: Fix bugs with large file offsets (Bug#9428).
3961 The previous code assumed that file offsets (off_t values) fit in
3962 EMACS_INT variables, which is not true on typical 32-bit hosts.
3963 The code messed up by falsely reporting buffer overflow in cases
3964 such as (insert-file-contents "big" nil 1 2) into an empty buffer
3965 when "big" contains more than 2**29 bytes, even though this
3966 inserts just one byte and does not overflow the buffer.
3967 (Finsert_file_contents): Store file offsets as off_t
3968 values, not as EMACS_INT values. Check for overflow when
3969 converting between EMACS_INT and off_t. When checking for
3970 buffer overflow or for overlap, take the offsets into account.
3971 Don't use EMACS_INT for small values where int suffices.
3972 When checking for overlap, fix a typo: ZV was used where
3973 ZV_BYTE was intended.
3974 (Fwrite_region): Don't assume off_t fits into 'long'.
3975 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
3977 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
3979 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
3981 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
3983 sprintf-related integer and memory overflow issues (Bug#9412).
3985 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
3986 (esprintf, exprintf, evxprintf): New functions.
3987 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
3988 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
3989 (modify_event_symbol): Do not assume that the length of
3990 name_alist_or_stem is safe to alloca and fits in int.
3991 (Fexecute_extended_command): Likewise for function name and binding.
3992 (Frecursion_depth): Wrap around reliably on integer overflow.
3993 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
3994 since some callers pass EMACS_INT values.
3995 (Fsingle_key_description): Don't crash if symbol name contains more
3996 than MAX_ALLOCA bytes.
3997 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
3998 (get_minibuffer): Arg is now EMACS_INT, not int.
3999 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
4000 (esprintf, exprintf, evxprintf): New decls.
4001 * window.h (command_loop_level, minibuf_level): Reflect API changes.
4003 * dbusbind.c (signature_cat): New function.
4004 (xd_signature, Fdbus_register_signal):
4005 Do not overrun buffer; instead, report string overflow.
4007 * dispnew.c (add_window_display_history): Don't overrun buffer.
4008 Truncate instead; this is OK since it's just a log.
4010 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
4011 even if the time zone offset is outlandishly large.
4012 Don't mishandle offset == INT_MIN.
4014 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
4015 when creating daemon; the previous buffer-overflow check was incorrect.
4017 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
4018 which has the guts of the old verror function.
4020 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
4021 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
4023 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
4024 (font_unparse_xlfd): Don't blindly alloca long strings.
4025 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
4026 fits in int, when using sprintf. Use single snprintf to count
4027 length of string rather than counting it via multiple sprintfs;
4028 that's simpler and more reliable.
4029 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
4030 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
4031 sprintf, in case result does not fit in int.
4033 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
4034 (fontset_from_font): Print it.
4036 * frame.c (tty_frame_count): Now printmax_t, not int.
4037 (make_terminal_frame, set_term_frame_name): Print it.
4038 (x_report_frame_params): In X, window IDs are unsigned long,
4039 not signed long, so print them as unsigned.
4040 (validate_x_resource_name): Check for implausibly long names,
4041 and don't assume name length fits in 'int'.
4042 (x_get_resource_string): Don't blindly alloca invocation name;
4043 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
4046 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
4047 (xg_check_special_colors, xg_set_geometry):
4048 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
4050 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
4051 Use esprintf, not sprintf, in case result does not fit in int.
4053 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4054 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
4055 it as a large positive number.
4056 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
4057 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4059 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
4060 in case result does not fit in int.
4062 * print.c (float_to_string): Detect width overflow more reliably.
4063 (print_object): Make sprintf buffer a bit bigger, to avoid potential
4064 buffer overrun. Don't assume list length fits in 'int'. Treat
4065 print length of 0 as 0, not as infinity; to be consistent with other
4066 uses of print length in this function. Don't overflow print length
4067 index. Don't assume hash table size fits in 'long', or that
4068 vectorlike size fits in 'unsigned long'.
4070 * process.c (make_process): Use printmax_t, not int, to format
4071 process-name gensyms.
4073 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
4075 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
4076 to avoid potential buffer overrun.
4078 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
4079 if X resource line is longer than 512 bytes.
4081 * xfns.c (x_window): Make sprintf buffer a bit bigger
4082 to avoid potential buffer overrun.
4084 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
4086 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
4088 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4090 Integer overflow fixes for scrolling, etc.
4091 Without these, Emacs silently mishandles large integers sometimes.
4092 For example, "C-u 4294967297 M-x recenter" was treated as if
4093 it were "C-u 1 M-x recenter" on a typical 64-bit host.
4095 * xdisp.c (try_window_id): Check Emacs fixnum range before
4096 converting to 'int'.
4098 * window.c (window_scroll_line_based, Frecenter):
4099 Check that an Emacs fixnum is in range before assigning it to 'int'.
4100 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
4101 values converted from Emacs fixnums.
4102 (Frecenter): Don't wrap around a line count if it is out of 'int'
4103 range; instead, treat it as an extreme value.
4104 (Fset_window_configuration, compare_window_configurations):
4105 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
4107 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
4108 that can exceed INT_MAX. Check that EMACS_INT value is in range
4109 before assigning it to the (possibly-narrower) index.
4110 (match_limit): Don't assume that a fixnum can fit in 'int'.
4112 * print.c (print_object): Use ptrdiff_t, not int, for index that can
4115 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
4116 (Fvertical_motion): Don't wrap around LINES values that don't fit
4117 in 'int'. Instead, treat them as extreme values. This is good
4118 enough for windows, which can't have more than INT_MAX lines anyway.
4120 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4122 * Require libxml/parser.h to avoid compilation warning.
4124 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
4126 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
4127 since this reportedly can destroy thread storage.
4129 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
4131 * syntax.c (find_defun_start): Update all cache variables if
4132 exiting early (Bug#9401).
4134 2011-08-30 Eli Zaretskii <eliz@gnu.org>
4136 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
4138 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
4139 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
4140 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
4142 * term.c (tty_append_glyph): New function.
4143 (produce_stretch_glyph): Static function and its prototype deleted.
4145 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
4148 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
4150 * image.c (parse_image_spec): Check for nonnegative, not for positive,
4151 when checking :margin (Bug#9390).
4152 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
4153 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
4154 so that the name doesn't mislead. All uses changed.
4156 2011-08-28 Johan Bockgård <bojohan@gnu.org>
4158 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
4161 2011-08-27 Eli Zaretskii <eliz@gnu.org>
4163 * xdisp.c (move_it_to): Don't bail out early when reaching
4164 position beyond to_charpos, if we are scanning backwards.
4165 (move_it_vertically_backward): When DY == 0, make sure we get to
4166 the first character in the line after the newline.
4168 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
4170 * ccl.c: Improve and simplify overflow checking (Bug#9196).
4171 (ccl_driver): Do not generate an out-of-range pointer.
4172 (Fccl_execute_on_string): Remove unnecessary check for
4173 integer overflow, noted by Stefan Monnier in
4174 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
4175 Remove a FIXME that didn't need fixing.
4176 Simplify the newly-introduced buffer reallocation code.
4178 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
4180 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
4182 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
4184 Integer and memory overflow issues (Bug#9196).
4186 * doc.c (get_doc_string): Rework so that
4187 get_doc_string_buffer_size is the actual buffer size, rather than
4188 being 1 less than the actual buffer size; this makes xpalloc more
4191 * image.c (x_allocate_bitmap_record, cache_image):
4192 * xselect.c (Fx_register_dnd_atom):
4193 Simplify previous changes by using xpalloc.
4195 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
4196 since either will do and ptrdiff_t is convenient with xpalloc.
4198 * charset.c (charset_table_size)
4199 (struct charset_sort_data.priority): Now ptrdiff_t.
4200 (charset_compare): Don't overflow if priorities differ greatly.
4201 (Fsort_charsets): Don't assume list length fits in int.
4202 Check for size-calculation overflow when allocating sort data.
4203 (syms_of_charset): Allocate an initial charset table that is
4204 just under 64 KiB, to avoid problems with glibc malloc and mmap.
4206 * cmds.c (internal_self_insert): Check for size-calculation overflow.
4208 * composite.h (struct composition.glyph_len): Now int, not unsigned.
4209 The actual value is always <= INT_MAX, and leaving it unsigned made
4210 overflow checking harder.
4212 * dispextern.h (struct glyph_matrix.rows_allocated)
4213 (struct face_cache.size): Now ptrdiff_t, for convenience in use
4214 with xpalloc. The values are still always <= INT_MAX.
4216 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
4218 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
4219 (SAFE_NALLOCA): New macro.
4221 * region-cache.c (struct boundary.pos, find_cache_boundary)
4222 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
4223 (set_cache_region, invalidate_region_cache)
4224 (revalidate_region_cache, know_region_cache, region_cache_forward)
4225 (region_cache_backward, pp_cache):
4226 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
4227 so that ptrdiff_t * can be passed to xpalloc.
4228 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
4229 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
4230 (pp_cache): Don't assume cache_len fits in int.
4231 * region-cache.h: Adjust extern decls to match.
4233 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
4234 EMACS_INT, since either will do, for xpalloc.
4236 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
4237 (xnmalloc, xnrealloc, xpalloc): New functions.
4239 * bidi.c (bidi_shelve_header_size): New constant.
4240 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
4241 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
4243 * bidi.c (bidi_cache_shrink):
4244 * buffer.c (overlays_at, overlays_in, record_overlay_string)
4246 Don't update size of array until after memory allocation succeeds,
4247 because xmalloc/xrealloc may not return.
4248 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
4249 now that we have proper integer overflow checking.
4250 (record_overlay_string, overlay_strings): Catch overflows when
4251 calculating size of overlay_str_buf.
4253 * callproc.c (Fcall_process): Check for size overflow when
4254 calculating size of args2.
4255 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
4256 Normally we prefer signed values, but sticking with ptrdiff_t would
4257 require adding more-complicated checks.
4259 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
4260 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
4261 Redo buffer-overflow calculations to avoid integer overflow.
4262 Add a FIXME comment where memory seems to be over-allocated.
4264 * character.c (Fstring): Check for size-calculation overflow.
4266 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
4267 unnecessary integer overflow. Check for size overflow.
4268 (encode_coding_object): Don't update size until xmalloc succeeds.
4270 * composite.c (get_composition_id): Check for overflow in glyph
4271 length calculations.
4273 Integer and memory overflow fixes for display code.
4274 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
4275 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
4276 (scrolling_window): Check for overflow in size calculations.
4277 (line_draw_cost, realloc_glyph_pool, add_row_entry):
4278 Don't assume glyph table len fits in int.
4279 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
4280 (row_table_size): Now ptrdiff_t, not int.
4281 (scrolling_window): Avoid overflow in size calculations.
4282 Don't update size until allocation succeeds.
4283 * fns.c (concat): Check for overflow in size calculations.
4284 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
4285 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4286 (NEXT_ALMOST_PRIME_LIMIT): New constant.
4288 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
4289 (get_doc_string): Check for size calculation overflow.
4290 Don't update size until allocation succeeds.
4291 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
4292 EMACS_INT, where ptrdiff_t will do.
4293 (Fsubstitute_command_keys): Check for string overflow.
4295 * editfns.c (set_time_zone_rule): Don't assume environment length
4297 (message_length): Now ptrdiff_t, not int.
4298 (Fmessage_box): Don't update size until allocation succeeds.
4299 Don't assume message length fits in int.
4300 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
4302 * emacs.c (main): Do not reallocate argv, since there is a null at
4303 the end that can be overwritten, and this way there's no need to
4304 worry about size-calculation overflow.
4305 (sort_args): Check for size-calculation overflow.
4307 * eval.c (init_eval_once, grow_specpdl): Don't update size until
4309 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
4311 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
4312 (x_set_scroll_bar_width, x_figure_window_size):
4313 Check for integer overflow.
4314 (x_set_alpha): Do not assume XINT fits in int.
4316 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
4317 This is for the members text_lines, text_cols, total_lines, total_cols,
4318 where the system imposes an 'int' limit.
4320 * fringe.c (Fdefine_fringe_bitmap):
4321 Don't update size until alloc works.
4323 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
4324 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
4326 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
4327 Check for size-calculation overflow.
4328 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
4329 do, as we prefer signed integers.
4330 (id_to_widget.max_size, id_to_widget.used)
4331 (xg_store_widget_in_map, xg_remove_widget_from_map)
4332 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
4333 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
4334 Use and return ptrdiff_t, not int.
4335 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
4336 * gtkutil.h: Change prototypes to match the above.
4338 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
4339 are duplicate now that they've been promoted to lisp.h.
4340 (x_allocate_bitmap_record, x_alloc_image_color)
4341 (make_image_cache, cache_image, xpm_load):
4342 Don't update size until alloc is done.
4343 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
4345 Check for size calculation overflow.
4346 (ct_colors_allocated_max): New constant.
4347 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
4350 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
4351 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
4352 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
4353 Use ptrdiff_t, not int, to count maps.
4354 (read_char_minibuf_menu_prompt): Check for overflow in size
4355 calculations. Don't update size until allocation succeeds.
4356 Redo calculations to avoid overflow.
4357 * keyboard.h: Change prototypes to match the above.
4359 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
4361 (current_minor_maps): Check for size calculation overflow.
4362 * keymap.h: Change prototypes to match the above.
4364 * lread.c (read1, init_obarray): Don't update size until alloc done.
4366 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
4367 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
4369 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
4370 Now ptrdiff_t, not int.
4371 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
4372 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
4374 * process.c (Fnetwork_interface_list): Check for overflow
4375 in size calculation.
4377 * region-cache.c (move_cache_gap): Check for size calculation overflow.
4379 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
4380 overflow. Don't bother calling xmalloc when xrealloc will do.
4382 * search.c (Freplace_match): Check for size calculation overflow.
4383 (Fset_match_data): Don't assume list lengths fit in 'int'.
4385 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
4386 for command line length. Do not attempt to address one before the
4387 beginning of an array, as that's not portable.
4389 * term.c (max_frame_lines): Remove; unused.
4390 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
4392 (encode_terminal_code, calculate_costs): Check for size
4393 calculation overflow.
4394 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
4395 table lengths and related sizes. Don't update size until alloc
4396 done. Redo calculations to avoid overflow.
4397 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
4399 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
4400 subtracting pointers.
4401 (gobble_line): Check for overflow more carefully. Don't update size
4404 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
4405 Don't update size until alloc done.
4406 Redo size calculations to avoid overflow.
4407 Check for size calculation overflow.
4408 (main) [DEBUG]: Fix typo in invoking tparam1.
4410 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
4411 Use ptrdiff_t, not int, for sizes.
4412 (store_mode_line_noprop_char): Don't update size until alloc done.
4414 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
4415 Use ptrdiff_t, not int, for sizes.
4416 (Finternal_make_lisp_face, cache_face):
4417 Check for size calculation overflow.
4418 (cache_face): Treat size calculation overflows as if they were
4419 memory exhaustion (the usual treatment), rather than aborting.
4421 * xfns.c (x_encode_text, x_set_name_internal)
4422 (Fx_change_window_property): Use ptrdiff_t, not int, to count
4423 sizes, since they can exceed INT_MAX in size. Check for size
4424 calculation overflow.
4426 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
4427 (xg_select): Check for size calculation overflow.
4428 Don't update size until alloc done.
4430 * xrdb.c (get_environ_db): Don't assume path length fits in int,
4431 as sprintf is limited to int lengths.
4433 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
4434 (X_LONG_MIN): New macros.
4435 Use them to make the following changes clearer.
4436 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
4437 This change doesn't affect the value now, but it may help remind
4438 future maintainers not to raise the value too much later.
4439 (SELECTION_QUANTUM): Remove, replacing with ...
4440 (selection_quantum): ... new function, which avoids overflow.
4442 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
4443 assumption that selection length fits in 'int'.
4444 (x_reply_selection_request, x_handle_selection_request)
4445 (x_get_window_property, receive_incremental_selection)
4446 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
4447 (lisp_data_to_selection_data, clean_local_selection_data):
4448 Use ptrdiff_t, not int, to record length of selection.
4449 (x_reply_selection_request, x_get_window_property)
4450 (receive_incremental_selection, x_property_data_to_lisp):
4451 Redo calculations to avoid overflow.
4452 (x_reply_selection_request): When sending hint, ceiling it at
4453 X_LONG_MAX rather than relying on wraparound overflow to send
4455 (x_get_window_property, receive_incremental_selection)
4456 (lisp_data_to_selection_data, x_property_data_to_lisp):
4457 Check for size-calculation overflow.
4458 (x_get_window_property, receive_incremental_selection)
4459 (lisp_data_to_selection_data, Fx_register_dnd_atom):
4460 Don't store size until memory allocation succeeds.
4461 (x_get_window_property): Plug memory leak on memory exhaustion.
4462 Don't double-block input; malloc is safe here. Don't assume 2**34
4463 - 4 fits in unsigned long. Add an xassert to check
4464 XGetWindowProperty overflow. Be more careful about overflow
4465 calculations, and distinguish size from memory overflow better.
4466 (receive_incremental_selection): When tracing, don't assume
4467 unsigned int is less than INT_MAX.
4468 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
4469 harmful) conversions of unsigned short to int.
4470 (lisp_data_to_selection_data): Don't assume that integers
4471 in the range -65535 through -1 fit in an X unsigned short.
4472 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
4473 result parameters unless successful. Rely on cons_to_unsigned
4474 to report problems with elements; the old code wasn't right anyway.
4475 (x_check_property_data): Check for int overflow; we cannot use
4476 a wider type due to X limits.
4477 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
4479 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
4481 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
4482 (x_term_init): Check for size calculation overflow.
4483 (x_color_cells): Don't store size until memory allocation succeeds.
4484 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
4485 Don't assume alloca size is less than MAX_ALLOCA.
4486 (x_term_init): Don't assume length fits in int (sprintf is limited
4489 Use ptrdiff_t for composition IDs.
4490 * character.c (lisp_string_width):
4491 * composite.c (composition_table_size, n_compositions)
4492 (get_composition_id, composition_gstring_from_id):
4493 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
4494 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
4495 * window.c (Frecenter):
4496 Use ptrdiff_t, not int, for composition IDs.
4497 * composite.c (get_composition_id): Check for integer overflow.
4498 * composite.h: Adjust prototypes to match the above changes.
4500 Use ptrdiff_t for hash table indexes.
4501 * category.c (hash_get_category_set):
4502 * ccl.c (ccl_driver):
4503 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
4504 * coding.c (coding_system_charset_list, detect_coding_system):
4505 * coding.h (struct coding_system.id):
4506 * composite.c (get_composition_id, gstring_lookup_cache):
4507 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
4508 * image.c (xpm_get_color_table_h):
4509 * lisp.h (hash_lookup, hash_put):
4510 * minibuf.c (Ftest_completion):
4511 Use ptrdiff_t for hash table indexes, not int (which is too
4512 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
4513 32-bit --with-wide-int hosts).
4515 * charset.c (Fdefine_charset_internal): Check for integer overflow.
4516 Add a FIXME comment about memory leaks.
4517 (syms_of_charset): Don't assume xmalloc returns.
4519 Don't assume that stated character widths fit in int.
4520 * character.c (Fchar_width, c_string_width, lisp_string_width):
4521 * character.h (CHAR_WIDTH):
4522 * indent.c (MULTIBYTE_BYTES_WIDTH):
4523 Use sanitize_char_width to avoid undefined and/or bad behavior
4524 with outlandish widths.
4525 * character.h (sanitize_tab_width): Rename from sanitize_width,
4526 now that we have two such functions. All uses changed.
4527 (sanitize_char_width): New inline function.
4529 Don't assume that tab-width fits in int.
4530 * character.h (sanitize_width): New inline function.
4531 (SANE_TAB_WIDTH): New macro.
4532 (ASCII_CHAR_WIDTH): Use it.
4533 * indent.c (sane_tab_width): Remove. All uses replaced by
4534 SANE_TAB_WIDTH (current_buffer).
4535 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
4537 * fileio.c: Integer overflow issues with file modes.
4538 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
4540 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
4541 Remove unreachable code.
4542 (read_hex, load_charset_map_from_file): Check for integer overflow.
4544 * xterm.c: Don't go over XClientMessageEvent limit.
4545 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
4546 (x_send_scroll_bar_event): Likewise. Check that the size does not
4547 exceed limits imposed by XClientMessageEvent, as well as the usual
4548 ptrdiff_t and size_t limits.
4550 * keyboard.c: Overflow, signedness and related fixes.
4551 (make_lispy_movement): Use same integer type in forward decl
4552 that is used in the definition.
4553 (read_key_sequence, keyremap_step):
4554 Change bufsize argument back to int, undoing my 2011-03-30 change.
4555 We prefer signed types, and int is wide enough here.
4556 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
4557 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
4558 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
4559 length, not size_t. Use ptrdiff_t for index, not int.
4560 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
4561 possibility of integer overflow.
4563 Overflow, signedness and related fixes for images.
4565 * dispextern.h (struct it.stack[0].u.image.image_id)
4566 (struct_it.image_id, struct image.id, struct image_cache.size)
4567 (struct image_cache.used, struct image_cache.ref_count):
4568 * gtkutil.c (update_frame_tool_bar):
4569 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
4570 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
4571 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
4572 * nsmenu.m (update_frame_tool_bar):
4573 * xdisp.c (calc_pixel_width_or_height):
4574 * xfns.c (image_cache_refcount):
4575 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
4576 on typical 64-bit hosts.
4578 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4579 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
4580 Omit unnecessary casts to int.
4581 (parse_image_spec): Check that integers fall into 'int' range
4582 when the callers expect that.
4583 (image_ascent): Redo ascent calculation to avoid int overflow.
4584 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
4585 (lookup_image): Remove unnecessary tests.
4586 (xbm_image_p): Locals are now of int, not EMACS_INT,
4587 since parse_image_check makes sure they fit into int.
4588 (png_load, gif_load, svg_load_image):
4589 Prefer int to unsigned where either will do.
4590 (tiff_handler): New function, combining the cores of the
4591 old tiff_error_handler and tiff_warning_handler.
4592 This function is rewritten to use vsnprintf and thereby avoid
4593 stack buffer overflows. It uses only the features of vsnprintf
4594 that are common to both POSIX and native Microsoft.
4595 (tiff_error_handler, tiff_warning_handler): Use it.
4596 (tiff_load, gif_load, imagemagick_load_image):
4597 Don't assume :index value fits in 'int'.
4598 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
4599 (imagemagick_load_image): Check that crop parameters fit into
4600 the integer types that MagickCropImage accepts. Don't assume
4601 Vimagemagick_render_type has a nonnegative value. Don't assume
4602 size_t fits in 'long'.
4603 (gs_load): Use printmax_t to print the widest integers possible.
4604 Check for integer overflow when computing image height and width.
4606 2011-08-26 Eli Zaretskii <eliz@gnu.org>
4608 * xdisp.c (redisplay_window): Don't force window start if point
4609 will be invisible in the resulting window. (Bug#9324)
4611 2011-08-25 Eli Zaretskii <eliz@gnu.org>
4613 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
4614 the display spec is of the form `(space ...)'.
4615 (handle_display_spec): Return the value returned by
4616 handle_single_display_spec, not just 1 or zero.
4617 (handle_single_display_spec): If the display spec is of the form
4618 `(space ...)', and specifies display in the text area, return 2
4620 (try_cursor_movement): Check for the need to scroll more
4621 accurately, and prefer exact match for point under bidi.
4622 Don't advance `row' beyond the last row of the window.
4624 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
4625 into disp_prop; all users changed.
4627 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
4628 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
4629 for the text covered by the display property.
4631 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
4633 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
4634 Change return value to nil.
4635 (Frecord_buffer): Delete unused function.
4637 2011-08-24 Eli Zaretskii <eliz@gnu.org>
4639 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
4640 buffers, return left-to-right.
4641 (set_cursor_from_row): Consider candidate row a win if its glyph
4642 represents a newline and point is on that newline. Fixes cursor
4643 positioning on the newline at EOL of R2L text within L2R
4644 paragraph, and vice versa.
4645 (try_cursor_movement): Check continued rows, in addition to
4646 continuation rows. Fixes unwarranted scroll when point enters a
4647 continued line of R2L text within an L2R paragraph, or vice versa.
4648 (cursor_row_p): Consider the case of point being equal to
4649 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
4650 from the end of a short line to the beginning of a continued line
4651 of R2L text within L2R paragraph.
4652 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
4653 composed characters.
4655 * bidi.c (bidi_check_type): Use xassert.
4656 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
4659 2011-08-23 Eli Zaretskii <eliz@gnu.org>
4661 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
4664 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
4666 * nsfont.m (ns_otf_to_script): Fix typo.
4668 2011-08-22 Kenichi Handa <handa@m17n.org>
4670 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
4671 extra slot even if the purpose is char-code-property-table.
4673 2011-08-23 Eli Zaretskii <eliz@gnu.org>
4675 * xdisp.c (redisplay_window): When computing centering_position,
4676 account for the height of the header line. (Bug#8874)
4678 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
4679 instead of CHAR_TO_BYTE. Fixes a crash when a completion
4680 candidate is selected by the mouse, and that candidate has a
4681 composed character under the mouse.
4683 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
4684 coordinates reported by pos-visible-in-window-p for a composed
4685 character in column zero.
4687 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
4689 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
4691 2011-08-22 Eli Zaretskii <eliz@gnu.org>
4693 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
4694 consider it a hit if to_charpos is anywhere in the range of the
4695 composed buffer positions.
4697 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
4699 * image.c (gif_load): Don't assume that each subimage has the same
4700 dimensions as the base image. Handle disposal method that is
4701 "undefined" by the gif spec (Bug#9335).
4703 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
4705 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
4706 (Fcondition_case): Document `debug' symbol in error handler.
4708 2011-08-19 Eli Zaretskii <eliz@gnu.org>
4710 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
4711 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
4712 from an Org mode buffer to a Speedbar frame.
4714 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
4715 a composition, take its buffer position from IT->cmp_it.charpos.
4716 Fixes cursor positioning at the beginning of a line that begins
4717 with a composed character.
4719 2011-08-18 Eli Zaretskii <eliz@gnu.org>
4721 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
4722 character bidirectional type, use STRONG_L instead. Fixes crashes
4723 in a buffer produced by `describe-categories'.
4725 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
4726 members before the level stack, so they would be saved and
4727 restored when copying iterator state. Fixes incorrect reordering
4728 around TABs covered by display properties.
4730 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
4732 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
4734 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
4736 * eval.c (internal_condition_case, internal_condition_case_1)
4737 (internal_condition_case_2, internal_condition_case_n):
4738 Remove unnecessary aborts (Bug#9081).
4740 2011-08-17 Eli Zaretskii <eliz@gnu.org>
4742 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
4743 has no `load' handler, try opening the file locally. (Bug#9311)
4745 2011-08-16 Ken Brown <kbrown@cornell.edu>
4747 * gmalloc.c: Expand comment.
4749 2011-08-16 Eli Zaretskii <eliz@gnu.org>
4751 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
4752 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
4754 2011-08-16 Ken Brown <kbrown@cornell.edu>
4756 Fix memory allocation problems in Cygwin build (Bug#9273).
4758 * unexcw.c ( __malloc_initialized): Declare external variable.
4759 (fixup_executable): Force the dumped emacs to reinitialize malloc.
4761 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
4763 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
4765 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
4767 [CYGWIN] (special_realloc): New function.
4768 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
4769 requests to realloc storage in the static heap.
4771 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
4773 * bidi.c (bidi_initialize): Remove unused local.
4775 2011-08-15 Eli Zaretskii <eliz@gnu.org>
4778 * biditype.h: Remove file.
4779 * makefile.w32-in ($(BLD)/bidi.$(O)):
4780 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
4782 * dispextern.h: Fix a typo in the comment to bidi_type_t.
4784 * chartab.c: Improve commentary for the uniprop_table API.
4786 * bidi.c (bidi_paragraph_init): Support zero value of
4787 bidi_ignore_explicit_marks_for_paragraph_level.
4788 (bidi_initialize): Use uniprop_table instead of including
4789 biditype.h and bidimirror.h.
4791 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
4792 coordinates of the iterator when restoring from ppos_it.
4795 2011-08-14 Kenichi Handa <handa@m17n.org>
4797 * process.c (create_process): Call setup_process_coding_systems
4798 after the pid of the process is set to -1 (Bug#8162).
4800 2011-08-14 Eli Zaretskii <eliz@gnu.org>
4802 * xdisp.c (move_it_in_display_line_to): Don't invoke
4803 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
4804 ppos_it. Fixes vertical cursor motion when line beginning is
4805 covered by an image. (Bug#9296)
4807 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
4809 * nsterm.h (ns_run_ascript): Declare.
4810 (NSAPP_DATA2_RUNASSCRIPT): Define.
4812 * nsfns.m (as_script, as_result, as_status): New static variables.
4813 (ns_run_ascript): New function.
4814 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
4815 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
4816 the event loop. Get status from as_status (Bug#7276).
4818 * nsterm.m (sendEvent): If event is NSApplicationDefined and
4819 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
4820 the event loop (Bug#7276).
4822 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
4824 * gnutls.c (QCgnutls_bootprop_priority)
4825 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
4826 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
4827 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
4828 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
4829 (QCgnutls_bootprop_verify_hostname_error)
4830 (QCgnutls_bootprop_callbacks_verify): Rename from
4831 Qgnutls_bootprop_..., all uses changed.
4833 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
4836 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
4838 * xfaces.c (Qframe_set_background_mode): Now static.
4839 * dispextern.h (Qframe_set_background_mode): Remove decl.
4841 * process.c (Fnetwork_interface_info): Declare local only if needed.
4843 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
4845 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
4846 (Fnetwork_interface_list): Allocate in increments of bytes instead
4847 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
4848 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
4850 (struct ifflag_def): notrailers is smart on OSX.
4851 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
4852 Get hardware address with getifaddrs if available.
4854 2011-08-12 Eli Zaretskii <eliz@gnu.org>
4856 * xdisp.c (iterate_out_of_display_property): xassert that
4857 IT->position is set to within IT->object's boundaries. Break from
4858 the loop as soon as EOB is reached; avoids infloops in redisplay
4859 when IT->position is set up wrongly due to some bug.
4860 Set IT->current to match the bidi iterator unconditionally.
4861 (push_display_prop): Allow GET_FROM_STRING as IT->method on
4862 entry. Force push_it to save on the stack the current
4863 buffer/string position, to be restored by pop_it. Fix flags in
4864 the iterator structure wrt the object coming from a display
4865 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
4866 properties. (Bug#9284)
4868 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
4870 * fontset.c (fontset_get_font_group): Add proper type checks.
4873 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4875 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
4876 and LC_VERSION_MIN_MACOSX.
4877 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
4878 (dump_it) [LC_FUNCTION_STARTS]: Use it.
4880 2011-08-08 Eli Zaretskii <eliz@gnu.org>
4882 * xdisp.c (forward_to_next_line_start): Allow to use the
4883 no-display-properties-and-no-overlays under bidi display.
4884 Set disp_pos in the bidi iterator to avoid searches for display
4885 properties and overlays.
4887 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
4889 * editfns.c (Fset_time_zone_rule): Document relationship with the
4892 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
4893 the font entity extracted from the cache (Bug#8109).
4895 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
4897 * composite.c (autocmp_chars): Don't reset point. That is done by
4898 restore_point_unwind (Bug#5984).
4900 2011-08-07 Juri Linkov <juri@jurta.org>
4902 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
4903 to show the arg `TIME' instead of `TIMEVAL'.
4905 2011-08-06 Eli Zaretskii <eliz@gnu.org>
4907 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
4908 display property strides EOL and includes a newline, as in
4909 longlines-mode. (Bug#9254)
4910 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
4911 word-wrap under bidirectional display. (Bug#9224)
4913 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
4914 is non-zero, even if the data buffer is NULL. Fixes a crash in
4915 vertical-motion with longlines-mode. (Bug#9254)
4917 2011-08-05 Eli Zaretskii <eliz@gnu.org>
4919 * bidi.c <bidi_cache_total_alloc>: Now static.
4920 (bidi_initialize): Initialize bidi_cache_total_alloc.
4922 * xdisp.c (display_line): Release buffer allocated for shelved bidi
4925 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
4926 amount allocated this far in `bidi_cache_total_alloc'.
4927 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
4928 non-zero, only free the data buffer without restoring the cache
4929 contents. All callers changed.
4931 * dispextern.h (bidi_unshelve_cache): Update prototype.
4933 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
4934 (move_it_in_display_line, move_it_to)
4935 (move_it_vertically_backward, move_it_by_lines): Replace the call
4936 to xfree to an equivalent call to bidi_unshelve_cache.
4937 (move_it_in_display_line_to): Fix logic of returning
4938 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
4940 2011-08-05 Eli Zaretskii <eliz@gnu.org>
4942 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
4943 came from a string character with a `cursor' property. (Bug#9229)
4945 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
4947 * Makefile.in (LIB_PTHREAD): New variable.
4948 (LIBES): Add LIB_PTHREAD (Bug#9216).
4950 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
4951 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
4953 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
4955 * regex.c (re_iswctype): Remove some redundant boolean conversions.
4957 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
4959 * xterm.c (x_find_topmost_parent): New function.
4960 (x_set_frame_alpha): Find topmost parent window with
4961 x_find_topmost_parent and set the property there also (bug#9181).
4962 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
4964 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
4966 * callproc.c (Fcall_process): Avoid vfork clobbering
4967 the local vars buffer, coding_systems, current_dir.
4969 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
4971 * keymap.c (Fmake_composed_keymap): Move to subr.el.
4973 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
4975 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
4976 so that it is not optimized away.
4978 * xdisp.c (compute_display_string_pos): Remove unused local.
4980 2011-08-02 Eli Zaretskii <eliz@gnu.org>
4982 Fix slow cursor motion and scrolling in large buffers with
4983 selective display, like Org Mode buffers. (Bug#9218)
4985 * dispextern.h (struct bidi_it): New member disp_prop_p.
4987 * xdisp.c: Remove one-slot cache of display string positions.
4988 (compute_display_string_pos): Accept an additional argument
4989 DISP_PROP_P; callers changed. Scan at most 5K characters forward
4990 for a display string or property. If found, set DISP_PROP_P
4993 * bidi.c (bidi_fetch_char): Accept an additional argument
4994 DISP_PROP_P, and pass it to compute_display_string_pos.
4995 Only handle text covered by a display string if DISP_PROP_P is returned
4996 non-zero. All callers of bidi_fetch_char changed.
4998 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
5000 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
5002 2010-12-03 Don March <don@ohspite.net>
5004 * keymap.c (Fdefine_key): Fix non-prefix key error message when
5005 last character M-[char] is translated to ESC [char] (bug#7541).
5007 2011-08-02 Kenichi Handa <handa@m17n.org>
5009 * lisp.h (uniprop_table): Extern it.
5011 * chartab.c (uniprop_table): Make it non-static.
5013 2011-08-01 Eli Zaretskii <eliz@gnu.org>
5015 * xdisp.c (forward_to_next_line_start): Accept additional argument
5016 BIDI_IT_PREV, and store into it the state of the bidi iterator had
5018 (reseat_at_next_visible_line_start): Use the bidi iterator state
5019 returned by forward_to_next_line_start to restore the state of
5020 it->bidi_it after backing up to previous newline. (Bug#9212)
5022 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
5024 * regex.c (re_comp): Protoize.
5025 (re_exec): Fix return type.
5026 (regexec): Fix type of `ret'. (Bug#9203)
5028 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5030 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
5031 This is needed if max-image-size is a floating-point number.
5033 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5035 * print.c (print_object): Print empty symbol as ##.
5037 * lread.c (read1): Read ## as empty symbol.
5039 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5041 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
5042 setting frame foreground color (Bug#9175).
5043 (x_set_background_color): Likewise.
5045 * nsmenu.m (-setText): Size tooltip dimensions precisely to
5046 contents (Bug#9176).
5047 (EmacsTooltip -init): Remove bezels and add shadows to
5050 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
5051 or scroll bar (Bug#8470).
5053 * nsfont.m (nsfont_open): Remove assignment to voffset and
5054 unnecessary vars hshink, expand, hd, full_height, min_height.
5055 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
5057 * nsterm.h (nsfont_info): Remove voffset field.
5059 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5061 Implement strike-through and overline on NextStep (Bug#8863).
5063 * nsfont.m (nsfont_open): Use underline position provided by font,
5064 instead of hard-coded value of 2.
5065 (nsfont_draw): Call ns_draw_text_decoration instead.
5067 * nsterm.h: Add declaration for ns_draw_text_decoration.
5069 * nsterm.m (ns_draw_text_decoration): New function for drawing
5070 underline, overline, and strike-through.
5071 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
5072 ns_draw_text_decoration. Change treatment of cursor drawing to
5073 accommodate underlining, etc.
5075 2011-07-28 Eli Zaretskii <eliz@gnu.org>
5077 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
5080 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5082 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
5083 Without this fix, if a signal arrives just after memory fills up,
5084 'malloc' might be invoked reentrantly.
5086 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
5087 In other words, assume that every image size is allowed, on non-X
5088 hosts. This assumption is probably wrong, but it lets Emacs compile.
5090 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5092 * regex.c (re_iswctype): Convert return values to boolean.
5094 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
5096 * xdisp.c (compute_display_string_pos): Don't use cached display
5097 string position if the buffer had its restriction changed.
5100 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5102 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5104 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5106 Integer signedness and overflow and related fixes. (Bug#9079)
5108 * bidi.c: Integer size and overflow fixes.
5109 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
5110 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
5111 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5112 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
5113 (bidi_find_other_level_edge):
5114 Use ptrdiff_t instead of EMACS_INT where either will do.
5115 This works better on 32-bit hosts configured --with-wide-int.
5116 (bidi_cache_ensure_space): Check for size-calculation overflow.
5117 Use % rather than repeated addition, for better worst-case speed.
5118 Don't set bidi_cache_size until after xrealloc returns, because it
5120 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
5121 (bidi_cache_ensure_space): Also check that the bidi cache size
5122 does not exceed that of the largest Lisp string or buffer. See Eli
5123 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
5125 * alloc.c (__malloc_size_t): Remove.
5126 All uses replaced by size_t. See Andreas Schwab's note
5127 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
5129 * image.c: Improve checking for integer overflow.
5130 (check_image_size): Assume that f is nonnull, since
5131 it is always nonnull in practice. This is one less thing to
5132 worry about when checking for integer overflow later.
5133 (x_check_image_size): New function, which checks for integer
5134 overflow issues inside X.
5135 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
5136 This removes the need for a memory_full check.
5137 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
5138 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
5139 (xbm_read_bitmap_data): Change locals back to 'int', since
5140 their values must fit in 'int'.
5141 (xpm_load_image, png_load, tiff_load):
5142 Invoke x_create_x_image_and_pixmap earlier,
5143 to avoid much needless work if the image is too large.
5144 (tiff_load): Treat overly large images as if
5145 x_create_x_image_and_pixmap failed, not as malloc failures.
5146 (gs_load): Use x_check_image_size.
5148 * gtkutil.c: Omit integer casts.
5149 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
5150 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
5152 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
5154 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
5155 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
5156 would wrongly return t on a 64-bit host.
5158 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
5159 The plain *_OVERFLOW macros run afoul of GCC bug 49705
5160 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
5161 and therefore cause GCC to emit a bogus diagnostic in some cases.
5163 * image.c: Integer signedness and overflow and related fixes.
5164 This is not an exhaustive set of fixes, but it's time to
5165 record what I've got.
5166 (lookup_pixel_color, check_image_size): Remove redundant decls.
5167 (check_image_size): Don't assume that arbitrary EMACS_INT values
5168 fit in 'int', or that arbitrary 'double' values fit in 'int'.
5169 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
5170 (tiff_load, imagemagick_load_image):
5171 Check for overflow in size calculations.
5172 (x_create_x_image_and_pixmap): Remove unnecessary test for
5173 xmalloc returning NULL; that can't happen.
5174 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
5175 (xpm_color_bucket): Use better integer hashing function.
5176 (xpm_cache_color): Don't possibly over-allocate memory.
5177 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
5178 (gif_memory_source):
5179 Use ptrdiff_t, not int or size_t, to record sizes.
5180 (png_load): Don't assume values greater than 2**31 fit in 'int'.
5181 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
5182 either works, as we prefer signed integers.
5183 (tiff_read_from_memory, tiff_write_from_memory):
5184 Return tsize_t, not size_t, since that's what the TIFF API wants.
5185 (tiff_read_from_memory): Don't fail simply because the read would
5186 go past EOF; instead, return a short read.
5187 (tiff_load): Omit no-longer-needed casts.
5188 (Fimagemagick_types): Don't assume size fits into 'int'.
5190 Improve hashing quality when configured --with-wide-int.
5191 * fns.c (hash_string): New function, taken from sxhash_string.
5192 Do not discard information about ASCII character case; this
5193 discarding is no longer needed.
5194 (sxhash-string): Use it. Change sig to match it. Caller changed.
5195 * lisp.h: Declare it.
5196 * lread.c (hash_string): Remove, since we now use fns.c's version.
5197 The fns.c version returns a wider integer if --with-wide-int is
5198 specified, so this should help the quality of the hashing a bit.
5200 * emacs.c: Integer overflow minor fix.
5201 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
5202 Define only if GNU_LINUX.
5203 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
5205 * dispnew.c: Integer signedness and overflow fixes.
5206 Remove unnecessary forward decls, that were a maintenance hassle.
5207 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
5209 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
5210 (scrolling_window): Use ptrdiff_t, not int, for byte count.
5211 (prepare_desired_row, line_draw_cost):
5212 Use int, not unsigned, where either works.
5213 (save_current_matrix, restore_current_matrix):
5214 Use ptrdiff_t, not size_t, where either works.
5215 (init_display): Check for overflow more accurately, and without
5216 relying on undefined behavior.
5218 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
5219 Remove, replacing with the new symbols in lisp.h. All uses changed.
5220 * fileio.c (make_temp_name):
5221 * filelock.c (lock_file_1, lock_file):
5222 * xdisp.c (message_dolog):
5223 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
5224 Use pMd etc. instead.
5225 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
5226 replacing the pWIDE etc. symbols removed from editfns.c.
5228 * keyboard.h (num_input_events): Now uintmax_t.
5229 This is (very slightly) less likely to mess up due to wraparound.
5232 * buffer.c: Integer signedness fixes.
5233 (alloc_buffer_text, enlarge_buffer_text):
5234 Use ptrdiff_t rather than size_t when either will do, as we prefer
5237 * alloc.c: Integer signedness and overflow fixes.
5238 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
5239 (__malloc_size_t): Default to size_t, not to int.
5240 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
5241 (Fgarbage_collect, mark_object_loop_halt, mark_object):
5242 Prefer ptrdiff_t to size_t when either would do, as we prefer
5244 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
5245 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
5246 Now const. Initialize with values that are in range even if char
5248 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
5249 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
5250 These functions do the right thing with sizes > 2**32.
5251 (check_depth): Now ptrdiff_t, not int.
5252 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
5253 Adjust to new way of storing sizes. Check for size overflow bugs
5255 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
5256 slightly wrong anyway, as it missed one instance of
5257 XMALLOC_OVERRUN_CHECK_OVERHEAD.
5258 (refill_memory_reserve): Omit needless cast to size_t.
5259 (mark_object_loop_halt): Mark as externally visible.
5261 * xselect.c: Integer signedness and overflow fixes.
5262 (Fx_register_dnd_atom, x_handle_dnd_message):
5263 Use ptrdiff_t, not size_t, since we prefer signed.
5264 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
5265 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
5266 x_dnd_atoms_size and x_dnd_atoms_length.
5268 * doprnt.c: Prefer signed to unsigned when either works.
5270 * doprnt.c (doprnt):
5272 * xdisp.c (vmessage):
5273 Use ptrdiff_t, not size_t, when using or implementing doprnt,
5274 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
5275 prefer signed arithmetic to avoid comparison confusion.
5276 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
5277 but is a bit tricky.
5279 Assume freestanding C89 headers, string.h, stdlib.h.
5280 * data.c, doprnt.c, floatfns.c, print.c:
5281 Include float.h unconditionally.
5282 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
5283 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
5284 * regex.c: Likewise for stddef.h, string.h.
5285 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
5286 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
5287 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
5288 (STDC_HEADERS): Remove obsolete defines.
5289 * sysdep.c: Include limits.h unconditionally.
5291 Assume support for memcmp, memcpy, memmove, memset.
5292 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
5293 * regex.c (memcmp, memcpy):
5294 Remove; we assume C89 now.
5296 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
5297 (__malloc_safe_bcopy): Remove; no longer needed.
5299 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
5300 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
5301 well either way, and we prefer signed to unsigned.
5303 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
5305 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
5306 closes the connection while we're reading (bug#9182).
5308 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
5310 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
5311 are specified (Bug#9168).
5313 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
5315 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
5316 Found by GCC static checking and --with-wide-int on a 32-bit host.
5318 2011-07-25 Eli Zaretskii <eliz@gnu.org>
5320 * xdisp.c (compute_display_string_pos): Fix logic of caching
5321 previous display string position. Initialize cached_prev_pos to
5322 -1. Fixes slow-down at the beginning of a buffer.
5324 2011-07-24 Eli Zaretskii <eliz@gnu.org>
5326 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
5327 for attrs[LFACE_FONTSET_INDEX].
5329 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
5331 * xml.c (parse_region): Remove unused local
5332 that was recently introduced.
5334 2011-07-23 Eli Zaretskii <eliz@gnu.org>
5336 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
5337 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
5339 * xdisp.c (move_it_in_display_line_to): Record the best matching
5340 position for TO_CHARPOS while scanning the line, and restore it on
5341 exit if none of the characters scanned was an exact match.
5342 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
5343 when exact match is impossible due to invisible text, and the
5344 lines are truncated.
5346 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
5348 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
5351 2011-07-22 Eli Zaretskii <eliz@gnu.org>
5353 Fix a significant slow-down of cursor motion with C-n, C-p,
5354 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
5355 auto-repeat under bidi redisplay in fontified buffers.
5356 * xdisp.c (compute_stop_pos_backwards): New function.
5357 (next_element_from_buffer): Call compute_stop_pos_backwards to
5358 find a suitable prev_stop when we find ourselves before
5360 (reseat): Don't look for prev_stop, as that could mean a very long
5362 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
5363 <cached_disp_overlay_modiff>: Cache for last found display string
5365 (compute_display_string_pos): Return the cached position if asked
5366 about the same buffer in the same area of character positions, and
5367 the buffer wasn't changed since the time the display string
5368 position was cached.
5370 2011-07-22 Eli Zaretskii <eliz@gnu.org>
5372 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
5373 is an integer, which is important for empty lines. (Bug#9149)
5375 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
5377 * frame.c (Fmodify_frame_parameters): In tty case, update the
5378 default face if necessary (Bug#4238).
5380 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
5382 * editfns.c (Fstring_to_char): No need to explain what a character
5383 is in the docstring (Bug#6576).
5385 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5387 * xml.c (parse_region): Make sure we always return a tree.
5389 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
5391 * xml.c (parse_region): If a document contains only comments,
5394 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5396 * xml.c (make_dom): Return comments, too.
5398 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
5401 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
5402 and the surrounding thread.
5403 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
5404 rather than fgets, and retry after EINTR. Otherwise, 'emacs
5405 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
5407 * s/openbsd.h (BROKEN_SIGIO): Define.
5408 * unexelf.c (unexec) [__OpenBSD__]:
5409 Don't update the .mdebug section of the Alpha COFF symbol table.
5411 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5413 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
5416 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
5418 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
5419 This fixes some race conditions on the permissions of any newly
5422 * alloc.c (valid_pointer_p): Use pipe, not open.
5423 This fixes some permissions issues when debugging.
5425 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
5426 If fchown fails to set both uid and gid, try to set just gid,
5427 as that is sometimes allowed. Adjust the file's mode to eliminate
5428 setuid or setgid bits that are inappropriate if fchown fails.
5430 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
5432 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
5433 to compare Lisp_Objects.
5434 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
5435 global_gnutls_log_level, don't mistake it for a Lisp_Object.
5436 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
5438 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
5440 * lread.c (read_integer): Unread even EOF character.
5441 (read1): Likewise. Properly record start position of symbol.
5443 * lread.c (read1): Read `#:' as empty uninterned symbol if no
5444 symbol character follows.
5446 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
5448 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
5449 This works around a problem with the previous change to Fcopy_file.
5450 Recent glibc declares fchown with __attribute__((warn_unused_result)),
5451 and without this change, GCC might complain about discarding
5452 fchown's return value.
5454 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
5456 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
5458 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
5460 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
5462 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
5464 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
5465 it's used from the C level.
5467 * process.c: Use the same condition for POLL_FOR_INPUT in both
5468 keyboard.c and process.c (bug#1858).
5470 2011-07-09 Lawrence Mitchell <wence@gmx.li>
5472 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
5473 (Fgnutls_boot): Use it.
5475 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
5477 * doc.c (Fsubstitute_command_keys): Revert last change.
5479 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
5481 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
5482 quotes the next character, and doesn't affect other longer
5483 sequences (bug#8935).
5485 * lread.c (syms_of_lread): Clarify that is isn't only
5486 `eval-buffer' and `eval-defun' that's affected by
5487 `lexical-binding' (bug#8460).
5489 2011-07-15 Eli Zaretskii <eliz@gnu.org>
5491 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
5492 bidi redisplay when a line includes both an image and is truncated.
5494 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
5496 Fix minor problems found by static checking.
5497 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
5498 (elsz): Now a signed constant, not a size_t var. We prefer signed
5499 types to unsigned, to avoid integer comparison confusion. Without
5500 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
5501 "cannot optimize loop, the loop counter may overflow", a symptom
5503 * indent.c (Fvertical_motion): Mark locals as initialized.
5504 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
5506 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
5508 * search.c (Fre_search_backward): Mention `case-fold-search' in
5509 all the re_search_* functions (bug#8138).
5511 * keyboard.c (Fopen_dribble_file): Document when the file is
5514 2011-07-14 Eli Zaretskii <eliz@gnu.org>
5516 * bidi.c (bidi_dump_cached_states): Fix format of displaying
5519 Support bidi reordering of display and overlay strings.
5520 * xdisp.c (compute_display_string_pos)
5521 (compute_display_string_end): Accept additional argument STRING.
5522 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
5523 (reseat_to_string): Initialize bidi_it->string.s and
5524 bidi_it->string.schars.
5525 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
5526 NULL (avoids a crash in bidi_paragraph_init).
5527 Initialize itb.string.lstring.
5528 (init_iterator): Call bidi_init_it only of a valid
5529 buffer position was specified. Initialize paragraph_embedding to
5531 (reseat_to_string): Initialize the bidi iterator.
5532 (display_string): If we need to ignore text properties of
5533 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
5534 original value of -1 will not work with bidi.)
5535 (compute_display_string_pos): First arg is now struct
5536 `text_pos *'; all callers changed. Support display properties on
5538 (compute_display_string_end): Support display properties on Lisp
5540 (init_iterator, reseat_1, reseat_to_string): Initialize the
5541 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
5542 when iterating on a string not from display properties).
5543 (compute_display_string_pos, compute_display_string_end):
5544 Fix calculation of the object to scan. Fixes an error when using
5546 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
5547 base_level_stop; instead, set base_level_stop to BEGV.
5548 Fixes crashes in vertical-motion.
5549 (next_element_from_buffer): Improve commentary for when
5550 the iterator is before prev_stop.
5551 (init_iterator): Initialize bidi_p from the default value of
5552 bidi-display-reordering, not from buffer-local value. Use the
5553 buffer-local value only if initializing for buffer iteration.
5554 (handle_invisible_prop): Support invisible properties on strings
5555 that are being bidi-reordered.
5556 (set_iterator_to_next): Support bidi reordering of C strings and
5558 (next_element_from_string): Support bidi reordering of Lisp
5560 (handle_stop_backwards): Support Lisp strings as well.
5561 (display_string): Support display of R2L glyph rows.
5562 Use IT_STRING_CHARPOS when displaying from a Lisp string.
5563 (init_iterator): Don't initialize it->bidi_p for strings
5565 (reseat_to_string): Initialize it->bidi_p for strings here.
5566 (next_element_from_string, next_element_from_c_string)
5567 (next_element_from_buffer): Add xassert's for correspondence
5568 between IT's object being iterated and it->bidi_it.string
5570 (face_before_or_after_it_pos): Support bidi iteration.
5571 (next_element_from_c_string): Handle the case of the first string
5572 character that is not the first one in the visual order.
5573 (get_visually_first_element): New function, refactored from common
5574 parts of next_element_from_buffer, next_element_from_string, and
5575 next_element_from_c_string.
5576 (tool_bar_lines_needed, redisplay_tool_bar)
5577 (display_menu_bar): Force left-to-right direction. Add a FIXME
5578 comment for making that be controlled by a user option.
5579 (push_it, pop_it): Save and restore the state of the
5580 bidi iterator. Save and restore the bidi_p flag.
5581 (pop_it): Iterate out of display property for string iteration as
5583 (iterate_out_of_display_property): Support iteration over strings.
5584 (handle_single_display_spec): Set up it->bidi_it for iteration
5585 over a display string, and call bidi_init_it.
5586 (handle_single_display_spec, next_overlay_string)
5587 (get_overlay_strings_1, push_display_prop): Set up the bidi
5588 iterator for displaying display or overlay strings.
5589 (forward_to_next_line_start): Don't use the shortcut if
5591 (back_to_previous_visible_line_start): If handle_display_prop
5592 pushed the iterator stack, restore the internal state of the bidi
5593 iterator by calling bidi_pop_it same number of times.
5594 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
5595 and we are bidi-iterating, don't decrement the iterator position;
5596 instead, set the first_elt flag in the bidi iterator, to produce
5598 (reseat_1): Remove redundant setting of string_from_display_prop_p.
5599 (push_display_prop): xassert that we are iterating a buffer.
5600 (push_it, pop_it): Save and restore paragraph_embedding member.
5601 (handle_single_display_spec, next_overlay_string)
5602 (get_overlay_strings_1, reseat_1, reseat_to_string)
5603 (push_display_prop): Set up the `unibyte' member of bidi_it.string
5604 correctly. Don't assume unibyte strings are not bidi-reordered.
5605 (compute_display_string_pos)
5606 (compute_display_string_end): Fix handling the case of C string.
5607 (push_it, pop_it): Save and restore from_disp_prop_p.
5608 (handle_single_display_spec, push_display_prop): Set the
5609 from_disp_prop_p flag.
5610 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
5611 (pop_it): Call iterate_out_of_display_property only if we are
5612 popping after iteration over a string that came from a display
5613 property. Fix a typo in popping stretch info. Add an assertion
5614 for verifying that the iterator position is in sync with the bidi
5616 (handle_single_display_spec, get_overlay_strings_1)
5617 (push_display_prop): Fix initialization of paragraph direction for
5618 string when that of the parent object is not yet determined.
5619 (reseat_1): Call bidi_init_it to resync the bidi
5620 iterator with IT's position. (Bug#7616)
5621 (find_row_edges): If ROW->start.pos gives position
5622 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
5623 (handle_stop, back_to_previous_visible_line_start, reseat_1):
5624 Reset the from_disp_prop_p flag.
5625 (SAVE_IT, RESTORE_IT): New macros.
5626 (pos_visible_p, face_before_or_after_it_pos)
5627 (back_to_previous_visible_line_start)
5628 (move_it_in_display_line_to, move_it_in_display_line)
5629 (move_it_to, move_it_vertically_backward, move_it_by_lines)
5630 (try_scrolling, redisplay_window, display_line): Use them when
5631 saving a temporary copy of the iterator and restoring it back.
5632 (back_to_previous_visible_line_start, reseat_1)
5633 (init_iterator): Empty the bidi cache "stack".
5634 (move_it_in_display_line_to): If iterator ended up at
5635 EOL, but we never saw any buffer positions smaller than
5636 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
5637 motion in bidi-reordered lines.
5638 (move_it_in_display_line_to): Record prev_method and prev_pos
5639 immediately before the call to set_iterator_to_next. Fixes cursor
5640 motion in bidi-reordered lines with stretch glyphs and strings
5641 displayed in margins. (Bug#8133) (Bug#8867)
5642 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
5644 (pos_visible_p): Support positions in bidi-reordered lines.
5645 Save and restore bidi cache.
5647 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
5648 (bidi_paragraph_info): Delete unused struct.
5649 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
5650 (bidi_cache_start): New variable.
5651 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
5653 (bidi_cache_fetch_state, bidi_cache_search)
5654 (bidi_cache_find_level_change, bidi_cache_iterator_state)
5655 (bidi_cache_find, bidi_peek_at_next_level)
5656 (bidi_level_of_next_char, bidi_find_other_level_edge)
5657 (bidi_move_to_visually_next): Compare cache index with
5658 bidi_cache_start rather than with zero.
5659 (bidi_fetch_char): Accept new argument STRING; all callers
5660 changed. Support iteration over a string. Support strings with
5661 display properties. Support unibyte strings. Fix the type of
5662 `len' according to what STRING_CHAR_AND_LENGTH expects.
5663 (bidi_paragraph_init, bidi_resolve_explicit_1)
5664 (bidi_resolve_explicit, bidi_resolve_weak)
5665 (bidi_level_of_next_char, bidi_move_to_visually_next):
5666 Support iteration over a string.
5667 (bidi_set_sor_type, bidi_resolve_explicit_1)
5668 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
5669 can now be zero (for strings); special values 0 and -1 were
5670 changed to -1 and -2, respectively.
5671 (bidi_char_at_pos): New function.
5672 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
5673 Call it instead of FETCH_MULTIBYTE_CHAR.
5674 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
5675 initialized to valid values.
5676 (bidi_init_it): Don't initialize charpos and bytepos with invalid
5678 (bidi_level_of_next_char): Allow the sentinel "position" to pass
5679 the test for valid cached positions. Fix the logic for looking up
5680 the sentinel state in the cache. GCPRO the Lisp string we are
5682 (bidi_push_it, bidi_pop_it): New functions.
5683 (bidi_initialize): Initialize the bidi cache start stack pointer.
5684 (bidi_cache_ensure_space): New function, refactored from part of
5685 bidi_cache_iterator_state. Don't assume the required size is just
5686 one BIDI_CACHE_CHUNK away.
5687 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
5688 (bidi_count_bytes, bidi_char_at_pos): New functions.
5689 (bidi_cache_search): Don't assume bidi_cache_last_idx is
5690 always valid if bidi_cache_idx is valid.
5691 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
5692 is valid if it's going to be used.
5693 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
5694 (bidi_cache_fetch_state, bidi_cache_search)
5695 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5696 (bidi_cache_iterator_state, bidi_cache_find)
5697 (bidi_find_other_level_edge, bidi_cache_start_stack):
5698 All variables related to cache indices are now EMACS_INT.
5700 * dispextern.h (struct bidi_string_data): New structure.
5701 (struct bidi_it): New member `string'. Make flag members be 1-bit
5702 fields, and put them last in the struct.
5703 (compute_display_string_pos, compute_display_string_end):
5705 (bidi_push_it, bidi_pop_it): Add prototypes.
5706 (struct iterator_stack_entry): New members bidi_p,
5707 paragraph_embedding, and from_disp_prop_p.
5708 (struct it): Member bidi_p is now a bit field 1 bit wide.
5709 (bidi_shelve_cache, bidi_unshelve_cache):
5712 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
5713 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
5714 and vector-like objects.
5716 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
5717 cache around display iteration.
5719 * window.c (Fwindow_end, window_scroll_pixel_based)
5720 (displayed_window_lines, Frecenter): Save and restore the bidi
5721 cache around display iteration.
5723 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
5725 * editfns.c (Fdelete_region): Clarify the use of the named
5726 parameters (bug#6788).
5728 2011-07-14 Martin Rudalics <rudalics@gmx.at>
5730 * indent.c (Fvertical_motion): Set and restore w->pointm when
5731 saving and restoring the window's buffer (Bug#9006).
5733 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
5735 * editfns.c (Fstring_to_char): Clarify just what is returned
5736 (bug#6576). Text by Eli Zaretskii.
5738 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
5740 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
5742 2011-07-13 Eli Zaretskii <eliz@gnu.org>
5744 * buffer.c (mmap_find): Fix a typo.
5746 2011-07-13 Johan Bockgård <bojohan@gnu.org>
5748 Fix execution of x selection hooks.
5749 * xselect.c (Qx_lost_selection_functions)
5750 (Qx_sent_selection_functions): New vars.
5751 (syms_of_xselect): DEFSYM them.
5752 (x_handle_selection_request): Pass Qx_sent_selection_functions
5753 rather than Vx_sent_selection_functions to Frun_hook_with_args.
5754 (x_handle_selection_clear,x_clear_frame_selections):
5755 Pass Qx_lost_selection_functions rather than
5756 Vx_lost_selection_functions to Frun_hook_with_args.
5758 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
5760 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
5761 The old code sometimes used this field without initializing it.
5763 * alloc.c (gc_sweep): Don't read past end of array.
5764 In theory, the old code could also have corrupted Emacs internals,
5765 though it'd be very unlikely.
5767 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
5769 * character.c (Fcharacterp): Don't advertise optional ignored
5770 argument. (Bug#4026)
5772 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
5774 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
5777 * window.c (Fset_window_start): Doc fix (bug#4199).
5778 (Fset_window_hscroll): Ditto.
5780 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
5782 Fix minor new problems caught by GCC 4.6.1.
5783 * term.c (init_tty): Remove unused local.
5784 * xsettings.c (store_monospaced_changed): Define this function only
5785 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
5788 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
5790 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
5792 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5794 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
5795 are the mini-buffer and the echo area (bug#3320).
5797 * term.c (init_tty): Remove support for supdup, c10 and perq
5798 terminals, which are no longer supported (bug#1482).
5800 2011-07-10 Johan Bockgård <bojohan@gnu.org>
5802 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
5804 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
5806 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
5807 for non-popups (Bug#3642).
5809 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
5811 * alloc.c (reset_malloc_hooks): Protoize.
5812 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
5813 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
5814 * cm.c (losecursor): Likewise.
5815 * data.c (fmod): Likewise.
5816 * dispnew.c (swap_glyphs_in_rows): Likewise.
5817 * emacs.c (memory_warning_signal): Likewise.
5818 * floatfns.c (float_error): Likewise.
5819 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
5820 (otf_open, font_otf_capability, generate_otf_features)
5821 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
5823 * image.c (pbm_read_file): Likewise.
5824 * indent.c (string_display_width): Likewise.
5825 * intervals.c (check_for_interval, search_for_interval)
5826 (inc_interval_count, count_intervals, root_interval)
5827 (adjust_intervals_for_insertion, make_new_interval): Likewise.
5828 * lread.c (defalias): Likewise.
5829 * ralloc.c (r_alloc_check): Likewise.
5830 * regex.c (set_image_of_range_1, set_image_of_range)
5831 (regex_grow_registers): Likewise.
5832 * sysdep.c (strerror): Likewise.
5833 * termcap.c (valid_filename_p, tprint, main): Likewise.
5834 * tparam.c (main): Likewise.
5835 * unexhp9k800.c (run_time_remap, save_data_space)
5836 (update_file_ptrs, read_header, write_header, calculate_checksum)
5837 (copy_file, copy_rest, display_header): Likewise.
5838 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
5840 * xdisp.c (check_it): Likewise.
5841 * xfaces.c (register_color, unregister_color, unregister_colors):
5843 * xfns.c (print_fontset_result): Likewise.
5844 * xrdb.c (member, fatal, main): Likewise.
5846 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
5848 Fix minor problems found by static checking (Bug#9031).
5849 * chartab.c (char_table_set_range, map_sub_char_table):
5850 Remove unused locals.
5851 (uniprop_table): Now static.
5852 * composite.c (_work_char): Remove unused static var.
5854 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
5856 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
5858 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
5860 * gtkutil.c (qttip_cb): Remove code without function.
5862 2011-07-09 Eli Zaretskii <eliz@gnu.org>
5864 * w32.c (pthread_sigmask): New stub.
5866 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
5868 Use pthread_sigmask, not sigprocmask (Bug#9010).
5869 sigprocmask is portable only for single-threaded applications, and
5870 Emacs can be multi-threaded when it uses GTK.
5871 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
5873 * callproc.c (Fcall_process):
5874 * process.c (create_process):
5875 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
5876 Use pthread_sigmask, not sigprocmask.
5878 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
5880 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
5881 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
5884 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
5886 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
5887 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
5888 (xg_hide_tooltip): Fix comment.
5890 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
5891 in registerServicesMenuSendTypes.
5892 (validRequestorForSendType): Don't check ns_return_types.
5894 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
5897 2011-07-08 Jason Rumney <jasonr@gnu.org>
5899 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
5900 SH_SHOW for hidden windows (Bug#5482).
5902 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
5903 frame struct members of non-existent frames (Bug#6284).
5905 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
5907 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
5908 variable firstTime not needed on OSX >= 10.6.
5909 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
5910 >= 10.5. Use setKnobProportion, setDoubleValue.
5912 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
5913 (MAC_OS_X_VERSION_10_5): Define if not defined.
5914 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
5915 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
5916 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
5918 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
5919 cString and lossyCString on OSX >= 10.4
5921 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
5922 sizeToFit on OSX >= 10.2.
5924 * nsimage.m (allocInitFromFile): Don't use deprecated method
5925 bestRepresentationForDevice on OSX >= 10.6.
5927 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
5930 * emacs.c: Declare unexec_init_emacs_zone.
5932 * nsgui.h: Fix compiler warning about gnulib redefining verify.
5934 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
5936 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
5937 on svcsMenu (Bug#8842).
5939 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
5941 (Fns_list_services): Just return Qnil on 10.6, code not working there.
5943 * nsterm.m (QUTF8_STRING): Declare.
5944 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
5945 (validRequestorForSendType): Return type is (id).
5946 Change indexOfObjectIdenticalTo to indexOfObject.
5947 Check if we have local selection before returning self (Bug#8842).
5948 (writeSelectionToPasteboard): Put local selection into paste board
5949 if we have a local selection (Bug#8842).
5950 (syms_of_nsterm): DEFSYM QUTF8_STRING.
5952 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
5953 (ns_get_local_selection): Declare.
5955 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
5957 * keymap.c (describe_map_tree): Don't insert a double newline at
5958 the end of the buffer (bug#1169) and return whether we inserted
5961 * callint.c (Fcall_interactively): Change "reading args" to
5962 "providing args" to try to clarify what it does (bug#1010).
5964 2011-07-07 Kenichi Handa <handa@m17n.org>
5966 * composite.c (composition_compute_stop_pos): Ignore a static
5967 composition starting before CHARPOS (Bug#8915).
5969 * xdisp.c (handle_composition_prop): Likewise.
5971 2011-07-07 Eli Zaretskii <eliz@gnu.org>
5973 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
5976 2011-07-07 Kenichi Handa <handa@m17n.org>
5978 * character.h (unicode_category_t): New enum type.
5980 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
5981 (Qchar_code_property_table): New variable.
5982 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
5983 (UNIPROP_COMPRESSED_FORM_P): New macros.
5984 (char_table_ascii): Uncompress the compressed values.
5985 (sub_char_table_ref): New arg is_uniprop. Callers changed.
5986 Uncompress the compressed values.
5987 (sub_char_table_ref_and_range): Likewise.
5988 (char_table_ref_and_range): Uncompress the compressed values.
5989 (sub_char_table_set): New arg is_uniprop. Callers changed.
5990 Uncompress the compressed values.
5991 (sub_char_table_set_range): Args changed. Callers changed.
5992 (char_table_set_range): Adjuted for the above change.
5993 (map_sub_char_table): Delete args default_val and parent. Add arg
5994 top. Give decoded values to a Lisp function.
5995 (map_char_table): Adjust for the above change. Give decoded
5996 values to a Lisp function. Gcpro more variables.
5997 (uniprop_table_uncompress)
5998 (uniprop_decode_value_run_length): New functions.
5999 (uniprop_decoder, uniprop_decoder_count): New variables.
6000 (uniprop_get_decoder, uniprop_encode_value_character)
6001 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
6003 (uniprop_encoder, uniprop_encoder_count): New variables.
6004 (uniprop_get_encoder, uniprop_table)
6005 (Funicode_property_table_internal, Fget_unicode_property_internal)
6006 (Fput_unicode_property_internal): New functions.
6007 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
6008 Sunicode_property_table_internal, Sget_unicode_property_internal,
6009 and Sput_unicode_property_internal. Defvar_lisp
6010 char-code-property-alist.
6012 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
6013 Vunicode_category_table.
6015 * font.c (font_range): Adjust for the change of
6016 Vunicode_category_table.
6018 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
6020 * m/iris4d.h: Remove file, move contents ...
6021 * s/irix6-5.h: ... here.
6023 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
6025 Remove unportable assumption about struct layout (Bug#8884).
6026 * alloc.c (mark_buffer):
6027 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
6028 (clone_per_buffer_values): Don't assume that
6029 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
6030 This isn't true in general, and it's particularly not true
6031 if Emacs is configured with --with-wide-int.
6032 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
6033 New macros, used in the buffer.c change.
6035 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
6037 * xsettings.c: Use both GConf and GSettings if both are available.
6038 (store_config_changed_event): Add comment.
6039 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
6040 (store_tool_bar_style_changed): New functions.
6041 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
6042 (struct xsettings): Move font inside HAVE_XFT.
6043 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
6044 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
6045 Move inside HAVE_XFT.
6046 (something_changed_gsettingsCB): Rename from something_changedCB.
6047 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
6049 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
6050 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
6051 (something_changed_gconfCB): Rename from something_changedCB.
6052 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
6053 (parse_settings): Move check for font inside HAVE_XFT.
6054 (read_settings, apply_xft_settings): Add comment.
6055 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
6056 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
6057 call store_font_name_changed.
6058 (xft_settings_event): Add comment.
6059 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
6060 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
6061 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
6062 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
6063 (xsettings_initialize): Call init_gsettings last.
6064 (xsettings_get_system_font, xsettings_get_system_normal_font):
6067 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
6069 Random fixes. E.g., (random) never returned negative values.
6070 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
6071 subseconds part to the entropy, as that's a bit more random.
6072 Prefer signed to unsigned, since the signedness doesn't matter and
6073 in general we prefer signed. When given a limit, use a
6074 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
6075 latter isn't right if USE_2_TAGS_FOR_INTS.
6076 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
6077 not 0..VALMASK. Don't discard "excess" bits that random () returns.
6079 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
6081 * textprop.c (text_property_stickiness):
6082 Obey Vtext_property_default_nonsticky.
6083 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
6084 * w32fns.c (syms_of_w32fns):
6085 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
6087 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6089 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
6090 This is more efficient than Ffile_directory_p and avoids a minor race.
6092 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
6094 * buffer.c (Foverlay_put): Say what the return value is
6097 * fileio.c (barf_or_query_if_file_exists): Check first if the file
6098 is a directory before asking whether to use the file name
6100 (barf_or_query_if_file_exists): Make the "File is a directory"
6101 error be more correct.
6103 * fns.c (Frequire): Remove the mention of the .gz files, since
6104 that's installation-specific, but keep the mention of
6105 `get-load-suffixes'.
6107 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6109 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
6110 Report string overflow if the output is too long.
6112 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
6114 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
6115 (syms_of_gnutls): Remove duplicate DEFSYM for
6116 Qgnutls_bootprop_verify_hostname_error, an error for
6117 Qgnutls_bootprop_verify_error (which is no longer used).
6119 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
6120 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
6121 Also (re)move comments that are misplaced or no longer relevant.
6123 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6125 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
6127 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
6129 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
6130 and background color parameters if they have been changed.
6132 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6134 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
6136 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
6138 * xsettings.c (SYSTEM_FONT): Define only when used.
6139 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
6141 * keymap.c (access_keymap_1): Now static.
6143 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
6145 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
6146 leave any prefix arg for the up event (Bug#1586).
6148 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
6150 * lread.c (syms_of_lread): Mention single symbols defined by
6151 `defvar' or `defconst' (bug#7154).
6153 * fns.c (Frequire): Mention .el.gz files (bug#7314).
6154 (Frequire): Mention get-load-suffixes.
6156 2011-07-02 Martin Rudalics <rudalics@gmx.at>
6158 * window.h (window): Remove clone_number slot.
6159 * window.c (Fwindow_clone_number, Fset_window_clone_number):
6161 (make_parent_window, make_window, saved_window)
6162 (Fset_window_configuration, save_window_save): Don't deal with
6164 * buffer.c (Qclone_number): Remove declaration.
6165 (sort_overlays, overlay_strings): Don't deal with clone numbers.
6167 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
6169 Add multiple inheritance to keymaps.
6170 * keymap.c (Fmake_composed_keymap): New function.
6171 (Fset_keymap_parent): Simplify.
6172 (fix_submap_inheritance): Remove.
6173 (access_keymap_1): New function extracted from access_keymap to handle
6174 embedded parents and handle lists of maps.
6175 (access_keymap): Use it.
6176 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
6177 (Fcopy_keymap): Handle embedded parents.
6178 (Fcommand_remapping, define_as_prefix): Simplify.
6179 (Fkey_binding): Simplify.
6180 (syms_of_keymap): Move minibuffer-local-completion-map,
6181 minibuffer-local-filename-completion-map,
6182 minibuffer-local-must-match-map, and
6183 minibuffer-local-filename-must-match-map to Elisp.
6184 (syms_of_keymap): Defsubr make-composed-keymap.
6185 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
6186 (parse_menu_item): Trivial simplification.
6188 2011-07-01 Glenn Morris <rgm@gnu.org>
6190 * Makefile.in (SETTINGS_LIBS): Fix typo.
6192 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
6194 * coding.c (Fencode_coding_string): Record the last coding system
6195 used, as the function doc string says (bug#8738).
6197 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
6199 * xsettings.c (store_monospaced_changed): Take new font as arg and
6200 check for change against current_mono_font.
6201 (EMACS_TYPE_SETTINGS): Remove this and related defines.
6202 (emacs_settings_constructor, emacs_settings_get_property)
6203 (emacs_settings_set_property, emacs_settings_class_init)
6204 (emacs_settings_init, gsettings_obj): Remove.
6205 (something_changedCB): New function for HAVE_GSETTINGS.
6206 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
6207 with value as argument.
6208 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
6209 g_settings_new (Bug#8967). Do not create gsettings_obj.
6210 Remove calls to g_settings_bind. Connect something_changedCB to
6213 * xgselect.c: Add defined (HAVE_GSETTINGS).
6214 (xgselect_initialize): Ditto.
6216 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
6217 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
6220 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
6222 * eval.c (struct backtrace): Simplify and port the data structure.
6223 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
6224 signed bit field, as this assumption is not portable and it makes
6225 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
6226 "char debug_on_exit : 1" as this is not portable either; instead,
6227 use the portable "unsigned int debug_on_exit : 1". Remove unused
6228 member evalargs. Remove obsolete comments about cc bombing out.
6230 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
6232 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
6233 Let HAVE_GSETTINGS override HAVE_GCONF.
6234 (store_monospaced_changed): New function.
6235 (EMACS_SETTINGS): A new type derived from GObject to handle
6236 GSettings notifications.
6237 (emacs_settings_constructor, emacs_settings_get_property)
6238 (emacs_settings_set_property, emacs_settings_class_init):
6240 (gsettings_client, gsettings_obj): New variables.
6241 (GSETTINGS_SCHEMA): New define.
6242 (something_changedCB): Call store_monospaced_changed.
6243 (init_gsettings): New function.
6244 (xsettings_initialize): Call init_gsettings.
6245 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
6248 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
6251 2011-06-29 Martin Rudalics <rudalics@gmx.at>
6253 * window.c (resize_root_window, grow_mini_window)
6254 (shrink_mini_window): Rename Qresize_root_window to
6255 Qwindow_resize_root_window and Qresize_root_window_vertically to
6256 Qwindow_resize_root_window_vertically.
6258 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
6260 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
6262 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
6264 * makefile.w32-in: Redesign dependencies so they reflect more
6265 clearly which files are directly included by each source file,
6266 and not through other includes.
6268 2011-06-27 Martin Rudalics <rudalics@gmx.at>
6270 * buffer.c (Qclone_number): Declare static and DEFSYM it.
6271 (sort_overlays, overlay_strings): When an overlay's clone number
6272 matches the window's clone number process the overlay even if
6273 the overlay's window property doesn't match the current window.
6275 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
6276 (Fwindow_hchild): Rename to Fwindow_left_child.
6277 (Fwindow_next): Rename to Fwindow_next_sibling.
6278 (Fwindow_prev): Rename to Fwindow_prev_sibling.
6279 (resize_window_check): Rename to window_resize_check.
6280 (resize_window_apply): Rename to window_resize_apply.
6281 (Fresize_window_apply): Rename to Fwindow_resize_apply.
6282 (Fdelete_other_windows_internal, resize_frame_windows)
6283 (Fsplit_window_internal, Fdelete_window_internal)
6284 (grow_mini_window, shrink_mini_window)
6285 (Fresize_mini_window_internal): Fix callers accordingly.
6287 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
6289 * emacsgtkfixed.h: State that this is only used with Gtk+3.
6290 (emacs_fixed_set_min_size): Remove.
6291 (emacs_fixed_new): Take frame as argument.
6293 * emacsgtkfixed.c: State that this is only used with Gtk+3.
6294 (_EmacsFixedPrivate): Remove minwidth/height.
6295 Add struct frame *f.
6296 (emacs_fixed_init): Initialize priv->f.
6297 (get_parent_class, emacs_fixed_set_min_size): Remove.
6298 (emacs_fixed_new): Set priv->f to argument.
6299 (emacs_fixed_get_preferred_width)
6300 (emacs_fixed_get_preferred_height): Use min_width/height from
6301 frames size_hint to set minimum and natural (Bug#8919).
6302 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
6303 and use min_width/height from frames size_hint to set
6304 min_width/height (Bug#8919).
6306 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
6307 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
6310 2011-06-26 Eli Zaretskii <eliz@gnu.org>
6312 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
6313 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
6316 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
6318 * process.c (wait_reading_process_output): Bypass select if
6319 waiting for a cell while ignoring keyboard input, and input is
6320 pending. Suggested by Jan Djärv (Bug#8869).
6322 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
6324 Use gnulib's dup2 module instead of rolling our own.
6325 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
6327 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6329 * dispnew.c (scrolling_window): Before scrolling, turn off a
6330 mouse-highlight in the window being scrolled.
6332 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
6334 Move DEFSYM to lisp.h and use everywhere.
6336 * character.h (DEFSYM): Move declaration...
6337 * lisp.h (DEFSYM): ...here.
6343 * w32select.c: Don't include character.h.
6345 * alloc.c (syms_of_alloc):
6346 * buffer.c (syms_of_buffer):
6347 * bytecode.c (syms_of_bytecode):
6348 * callint.c (syms_of_callint):
6349 * casefiddle.c (syms_of_casefiddle):
6350 * casetab.c (init_casetab_once):
6351 * category.c (init_category_once, syms_of_category):
6352 * ccl.c (syms_of_ccl):
6353 * cmds.c (syms_of_cmds):
6354 * composite.c (syms_of_composite):
6355 * dbusbind.c (syms_of_dbusbind):
6356 * dired.c (syms_of_dired):
6357 * dispnew.c (syms_of_display):
6358 * doc.c (syms_of_doc):
6359 * editfns.c (syms_of_editfns):
6360 * emacs.c (syms_of_emacs):
6361 * eval.c (syms_of_eval):
6362 * fileio.c (syms_of_fileio):
6363 * fns.c (syms_of_fns):
6364 * frame.c (syms_of_frame):
6365 * fringe.c (syms_of_fringe):
6366 * insdel.c (syms_of_insdel):
6367 * keymap.c (syms_of_keymap):
6368 * lread.c (init_obarray, syms_of_lread):
6369 * macros.c (syms_of_macros):
6370 * msdos.c (syms_of_msdos):
6371 * print.c (syms_of_print):
6372 * process.c (syms_of_process):
6373 * search.c (syms_of_search):
6374 * sound.c (syms_of_sound):
6375 * syntax.c (init_syntax_once, syms_of_syntax):
6376 * terminal.c (syms_of_terminal):
6377 * textprop.c (syms_of_textprop):
6378 * undo.c (syms_of_undo):
6379 * w32.c (globals_of_w32):
6380 * window.c (syms_of_window):
6381 * xdisp.c (syms_of_xdisp):
6382 * xfaces.c (syms_of_xfaces):
6383 * xfns.c (syms_of_xfns):
6384 * xmenu.c (syms_of_xmenu):
6385 * xsettings.c (syms_of_xsettings):
6386 * xterm.c (syms_of_xterm): Use DEFSYM.
6388 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
6390 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
6392 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
6394 Integer and buffer overflow fixes (Bug#8873).
6396 * print.c (printchar, strout): Check for string overflow.
6397 (PRINTPREPARE, printchar, strout):
6398 Don't set size unless allocation succeeds.
6400 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
6401 for sizes. Check for string overflow more accurately.
6402 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
6404 * macros.c: Integer and buffer overflow fixes.
6405 * keyboard.h (struct keyboard.kbd_macro_bufsize):
6406 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
6407 Use ptrdiff_t, not int, for sizes.
6408 Don't increment bufsize until after realloc succeeds.
6409 Check for size-calculation overflow.
6410 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
6412 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
6414 * lread.c: Integer overflow fixes.
6415 (read_integer): Radix is now EMACS_INT, not int,
6416 to improve quality of diagnostics for out-of-range radices.
6417 Calculate buffer size correctly for out-of-range radices.
6418 (read1): Check for integer overflow in radices, and in
6419 read-circle numbers.
6420 (read_escape): Avoid int overflow.
6421 (Fload, openp, read_buffer_size, read1)
6422 (substitute_object_recurse, read_vector, read_list, map_obarray):
6423 Use ptrdiff_t, not int, for sizes.
6424 (read1): Use EMACS_INT, not int, for sizes.
6425 Check for size overflow.
6427 * image.c (cache_image): Check for size arithmetic overflow.
6429 * lread.c: Integer overflow issues.
6430 (saved_doc_string_size, saved_doc_string_length)
6431 (prev_saved_doc_string_size, prev_saved_doc_string_length):
6432 Now ptrdiff_t, not int.
6433 (read1): Don't assume doc string length fits in int. Check for
6434 out-of-range doc string lengths.
6435 (read_list): Don't assume file position fits in int.
6436 (read_escape): Check for hex character overflow.
6438 2011-06-22 Leo Liu <sdl.web@gmail.com>
6440 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
6441 Move to minibuffer.el.
6443 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6445 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
6446 The following patches are for when GLYPH_DEBUG && !XASSERT.
6447 * dispextern.h (trace_redisplay_p, dump_glyph_string):
6448 * dispnew.c (flush_stdout):
6449 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
6450 Mark as externally visible.
6451 * dispnew.c (check_window_matrix_pointers): Now static.
6452 * dispnew.c (window_to_frame_vpos):
6453 * xfns.c (unwind_create_frame):
6454 * xterm.c (x_check_font): Remove unused local.
6455 * scroll.c (CHECK_BOUNDS):
6456 * xfaces.c (cache_fache): Rename local to avoid shadowing.
6457 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
6458 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
6459 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
6460 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
6462 (debug_method_add): Use va_list and vsprintf rather than relying
6463 on undefined behavior with wrong number of arguments.
6464 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
6465 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
6466 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
6467 since we're not interested in debugging glyphs with old libraries.
6468 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
6469 GCC 4.6.0's static checking.
6471 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6473 Integer overflow and signedness fixes (Bug#8873).
6474 A few related buffer overrun fixes, too.
6476 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
6478 * dispextern.h (struct face.stipple):
6479 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
6480 (x_bitmap_mask, x_allocate_bitmap_record)
6481 (x_create_bitmap_from_data, x_create_bitmap_from_file)
6482 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
6483 (x_create_bitmap_from_xpm_data):
6484 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
6485 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
6487 * xfaces.c (load_pixmap):
6488 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
6489 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
6490 (.bitmaps_last, struct x_output.icon_bitmap):
6491 Use ptrdiff_t, not int, for bitmap indexes.
6492 (x_allocate_bitmap_record): Check for size overflow.
6493 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
6495 Use ptrdiff_t, not int, for overlay counts.
6496 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
6497 * editfns.c (overlays_around, get_pos_property):
6498 * textprop.c (get_char_property_and_overlay):
6499 * xdisp.c (next_overlay_change, note_mouse_highlight):
6500 * xfaces.c (face_at_buffer_position):
6501 * buffer.c (OVERLAY_COUNT_MAX): New macro.
6502 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
6503 (Fnext_overlay_change, Fprevious_overlay_change)
6504 (mouse_face_overlay_overlaps, Foverlays_in):
6505 Use ptrdiff_t, not int, for sizes.
6506 (overlays_at, overlays_in): Check for size-calculation overflow.
6508 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
6510 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
6511 (x_session_initialize): Do not assume string length fits in int.
6513 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
6514 This is unlikely, but can occur if DPI is outlandish.
6516 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
6517 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
6519 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
6520 * xrdb.c (magic_file_p, search_magic_path):
6521 Omit last arg SUFFIX; it was always 0. All callers changed.
6522 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
6524 * xfont.c (xfont_match): Avoid need for strlen.
6526 * xfns.c: Don't assume strlen fits in int.
6527 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
6529 * xdisp.c (message_log_check_duplicate): Return intmax_t,
6530 not unsigned long, as we prefer signed integers. All callers changed.
6531 Detect integer overflow in repeat count.
6532 (message_dolog): Don't assume print length fits in 39 bytes.
6533 (display_mode_element): Don't assume strlen fits in int.
6535 * termcap.c: Don't assume sizes fit in int and never overflow.
6536 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
6537 (gobble_line): Check for size-calculation overflow.
6539 * minibuf.c (Fread_buffer):
6540 * lread.c (intern, intern_c_string):
6541 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
6542 Don't assume string length fits in int.
6544 * keyboard.c (parse_tool_bar_item):
6545 * gtkutil.c (style_changed_cb): Avoid need for strlen.
6547 * font.c: Don't assume string length fits in int.
6548 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
6549 Use ptrdiff_t, not int.
6550 (font_intern_prop): Don't assume string length fits in int.
6551 Don't assume integer property fits in fixnum.
6552 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
6554 * filelock.c: Fix some buffer overrun and integer overflow issues.
6555 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
6556 Reformulate so as not to need the command string.
6557 Invoke gzip -cd rather than gunzip, as it's more portable.
6558 (lock_info_type, lock_file_1, lock_file):
6559 Don't assume pid_t and time_t fit in unsigned long.
6560 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
6561 (current_lock_owner): Prefer signed type for sizes.
6562 Use memcpy, not strncpy, where memcpy is what is really wanted.
6563 Don't assume (via atoi) that time_t and pid_t fit in int.
6564 Check for time_t and/or pid_t out of range, e.g., via a network share.
6565 Don't alloca where an auto var works fine.
6567 * fileio.c: Fix some integer overflow issues.
6568 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
6569 Don't assume string length fits in int.
6570 (directory_file_name): Don't assume string length fits in long.
6571 (make_temp_name): Don't assume pid fits in int, or that its print
6572 length is less than 20.
6574 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
6576 * coding.c (make_subsidiaries): Don't assume string length fits in int.
6578 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
6580 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
6581 We prefer signed integers, even for size calculations.
6583 * emacs.c: Don't assume string length fits in 'int'.
6584 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
6585 (main): Don't invoke strlen when not needed.
6587 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
6588 (XD_DEBUG_MESSAGE): Don't waste a byte.
6590 * callproc.c (getenv_internal_1, getenv_internal)
6592 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
6594 * lread.c (invalid_syntax): Omit length argument.
6595 All uses changed. This doesn't fix a bug, but it simplifies the
6596 code away from its former Hollerith-constant appearance, and it's
6597 one less 'int' to worry about when looking at integer-overflow issues.
6598 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
6600 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
6601 This didn't break anything, but it didn't help either.
6602 It's confusing to put a bogus integer in a place where the actual
6603 value does not matter.
6604 (LIST_END_P): Remove unused macro and its bogus comment.
6605 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
6607 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
6608 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
6610 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
6611 We prefer signed types, and the value cannot exceed the EMACS_INT
6612 range anyway (because otherwise the length would not be representable).
6613 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
6614 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
6615 This avoids a GCC warning when WIDE_EMACS_INT.
6617 * indent.c (sane_tab_width): New function.
6618 (current_column, scan_for_column, Findent_to, position_indentation)
6619 (compute_motion): Use it. This is just for clarity.
6620 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
6622 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
6624 * lisp.h (lint_assume): New macro.
6625 * composite.c (composition_gstring_put_cache):
6626 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
6628 * editfns.c, insdel.c:
6629 Omit unnecessary forward decls, to simplify future changes.
6631 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
6633 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
6635 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
6636 Use much-faster test for byte-length change.
6637 Don't assume string byte-length fits in 'int'.
6638 Check that character arg fits in 'int'.
6639 (mapcar1): Declare byte as byte, for clarity.
6641 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
6643 * fns.c (concat): Catch string overflow earlier.
6644 Do not rely on integer wraparound.
6646 * dispextern.h (struct it.overlay_strings_charpos)
6647 (struct it.selective): Now EMACS_INT, not int.
6648 * xdisp.c (forward_to_next_line_start)
6649 (back_to_previous_visible_line_start)
6650 (reseat_at_next_visible_line_start, next_element_from_buffer):
6651 Don't arbitrarily truncate the value of 'selective' to int.
6653 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
6655 * composite.c: Don't truncate sizes to 'int'.
6656 (composition_gstring_p, composition_reseat_it)
6657 (composition_adjust_point): Use EMACS_INT, not int.
6658 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
6659 not EMACS_UINT, for indexes.
6661 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
6663 * buffer.c: Include <verify.h>.
6664 (struct sortvec.priority, struct sortstr.priority):
6665 Now EMACS_INT, not int.
6666 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
6667 (struct sortstr.size, record_overlay_string)
6668 (struct sortstrlist.size, struct sortlist.used):
6669 Don't truncate size to int.
6670 (record_overlay_string): Check for size-calculation overflow.
6671 (init_buffer_once): Check at compile-time, not run-time.
6673 2011-06-22 Jim Meyering <meyering@redhat.com>
6675 Don't leak an XBM-image-sized buffer
6676 * image.c (xbm_load): Free the image buffer after using it.
6678 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
6681 * composite.c (find_automatic_composition): Omit needless 'return 0;'
6682 that Sun C diagnosed.
6683 * fns.c (secure_hash): Fix pointer signedness issue.
6684 * intervals.c (static_offset_intervals): New function.
6685 (offset_intervals): Use it.
6687 2011-06-21 Leo Liu <sdl.web@gmail.com>
6690 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
6693 * fns.c (secure_hash): Rename from crypto_hash_function and change
6694 the first arg to accept symbols.
6695 (Fsecure_hash): New primitive.
6696 (syms_of_fns): New symbols.
6698 2011-06-20 Deniz Dogan <deniz@dogan.se>
6700 * process.c (Fset_process_buffer): Clarify return value in
6703 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
6705 * dispnew.c (add_window_display_history): Use BVAR.
6707 * xdisp.c (debug_method_add): Use BVAR.
6708 (check_window_end, dump_glyph_matrix, dump_glyph)
6709 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
6711 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
6714 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
6715 check till after the cache is created in init_frame_faces.
6717 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
6719 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
6721 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
6723 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
6724 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
6725 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
6727 Improve buffer-overflow checking (Bug#8873).
6728 * fileio.c (Finsert_file_contents):
6729 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
6730 Remove the old (too-loose) buffer overflow checks.
6731 They weren't needed, since make_gap checks for buffer overflow.
6732 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
6733 The old code merely checked for Emacs fixnum overflow, and relied
6734 on undefined (wraparound) behavior. The new code avoids undefined
6735 behavior, and also checks for ptrdiff_t and/or size_t overflow.
6737 * editfns.c (Finsert_char): Don't dump core with very negative counts.
6738 Tune. Don't use wider integers than needed. Don't use alloca.
6739 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
6741 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
6743 * insdel.c, lisp.h (buffer_overflow): New function.
6744 (insert_from_buffer_1, replace_range, replace_range_2):
6745 * insdel.c (make_gap_larger):
6746 * editfns.c (Finsert_char):
6747 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
6749 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
6751 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
6753 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
6755 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
6756 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
6758 * fileio.c: Don't assume EMACS_INT fits in off_t.
6759 (emacs_lseek): New static function.
6760 (Finsert_file_contents, Fwrite_region): Use it.
6761 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
6763 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
6765 * fns.c: Don't overflow int when computing a list length.
6766 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
6767 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
6768 truncation on 64-bit hosts. Check for QUIT every
6769 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
6770 faster and is responsive enough.
6771 (Flength): Report an error instead of overflowing an integer.
6772 (Fsafe_length): Return a float if the value is not representable
6773 as a fixnum. This shouldn't happen except in contrived situations.
6774 (Fnthcdr, Fsort): Don't assume list length fits in int.
6775 (Fcopy_sequence): Don't assume vector length fits in int.
6777 * alloc.c: Check that resized vectors' lengths fit in fixnums.
6778 (header_size, word_size): New constants.
6779 (allocate_vectorlike): Don't check size overflow here.
6780 (allocate_vector): Check it here instead, since this is the only
6781 caller of allocate_vectorlike that could cause overflow.
6782 Check that the new vector's length is representable as a fixnum.
6784 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
6785 The previous code was bogus. For example, next_almost_prime (32)
6786 returned 39, which is undesirable as it is a multiple of 3; and
6787 next_almost_prime (24) returned 25, which is a multiple of 5 so
6788 why was the code bothering to check for multiples of 7?
6790 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
6792 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
6794 Variadic C functions now count arguments with ptrdiff_t.
6795 This partly undoes my 2011-03-30 change, which replaced int with size_t.
6796 Back then I didn't know that the Emacs coding style prefers signed int.
6797 Also, in the meantime I found a few more instances where arguments
6798 were being counted with int, which may truncate counts on 64-bit
6799 machines, or EMACS_INT, which may be unnecessarily wide.
6800 * lisp.h (struct Lisp_Subr.function.aMANY)
6801 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
6802 Arg counts are now ptrdiff_t, not size_t.
6803 All variadic functions and their callers changed accordingly.
6804 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
6805 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
6806 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
6807 * callint.c (Fcall_interactively): Check arg count for overflow,
6808 to avoid potential buffer overrun. Use signed char, not 'int',
6809 for 'varies' array, so that we needn't bother to check its size
6810 calculation for overflow.
6811 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
6812 * eval.c (apply_lambda):
6813 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
6814 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
6815 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
6817 * callint.c (Fcall_interactively): Don't use index var as event count.
6819 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
6820 * mem-limits.h (SIZE): Remove; no longer used.
6822 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
6824 Remove unnecessary casts.
6825 * xterm.c (x_term_init):
6826 * xfns.c (x_set_border_pixel):
6827 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
6828 These aren't needed now that we assume ANSI C.
6830 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
6831 It's more likely to cause problems (due to unsigned overflow)
6834 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
6836 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
6838 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
6840 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
6842 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
6844 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
6846 GLYPH_CODE_FACE returns EMACS_INT, not int.
6847 * dispextern.h (merge_faces):
6848 * xfaces.c (merge_faces):
6849 * xdisp.c (get_next_display_element, next_element_from_display_vector):
6850 Don't assume EMACS_INT fits in int.
6852 * character.h (CHAR_VALID_P): Remove unused parameter.
6853 * fontset.c, lisp.h, xdisp.c: All uses changed.
6855 * editfns.c (Ftranslate_region_internal): Omit redundant test.
6857 * fns.c (concat): Minor tuning based on overflow analysis.
6858 This doesn't fix any bugs. Use int to hold character, instead
6859 of constantly refetching from Emacs object. Use XFASTINT, not
6860 XINT, for value known to be a character. Don't bother comparing
6861 a single byte to 0400, as it's always less.
6863 * floatfns.c (Fexpt):
6864 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
6866 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
6869 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
6871 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
6872 Without this fix, on a 64-bit host (aset S 0 4294967386) would
6873 incorrectly succeed when S was a string, because 4294967386 was
6874 truncated before it was used.
6876 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
6877 Otherwise, an out-of-range integer could cause undefined behavior
6880 * composite.c: Use int, not EMACS_INT, for characters.
6881 (fill_gstring_body, composition_compute_stop_pos): Use int, not
6882 EMACS_INT, for values that are known to be in character range.
6883 This doesn't fix any bugs but is the usual style inside Emacs and
6884 may generate better code on 32-bit machines.
6886 Make sure a 64-bit char is never passed to ENCODE_CHAR.
6887 This is for reasons similar to the recent CHAR_STRING fix.
6888 * charset.c (Fencode_char): Check that character arg is actually
6889 a character. Pass an int to ENCODE_CHAR.
6890 * charset.h (ENCODE_CHAR): Verify that the character argument is no
6891 wider than 'int', as a compile-time check to prevent future regressions
6894 * character.c (char_string): Remove unnecessary casts.
6896 Make sure a 64-bit char is never passed to CHAR_STRING.
6897 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
6898 by silently ignoring the top 32 bits, allowing some values
6899 that were far too large to be valid characters.
6900 * character.h: Include <verify.h>.
6901 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
6902 arguments are no wider than unsigned, as a compile-time check
6903 to prevent future regressions in this area.
6905 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
6906 (Fsubst_char_in_region):
6908 * xdisp.c (decode_mode_spec_coding):
6909 Adjust to CHAR_STRING's new requirement.
6910 * editfns.c (Finsert_char, Fsubst_char_in_region):
6911 * fns.c (concat): Check that character args are actually
6912 characters. Without this test, these functions did the wrong
6913 thing with wildly out-of-range values on 64-bit hosts.
6915 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
6916 These casts should not be needed on 32-bit hosts, either.
6917 * keyboard.c (read_char):
6918 * lread.c (Fload): Remove casts to unsigned.
6920 * lisp.h (UNSIGNED_CMP): New macro.
6921 This fixes comparison bugs on 64-bit hosts.
6922 (ASCII_CHAR_P): Use it.
6923 * casefiddle.c (casify_object):
6924 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
6925 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
6926 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
6927 * dispextern.h (FACE_FROM_ID):
6928 * keyboard.c (read_char): Use UNSIGNED_CMP.
6930 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
6931 not to EMACS_INT, to avoid GCC warning.
6933 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
6935 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
6936 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
6937 isn't needed on 32-bit machines.
6939 * buffer.c (Fgenerate_new_buffer_name):
6940 Use EMACS_INT for count, not int.
6941 (advance_to_char_boundary): Return EMACS_INT, not int.
6943 * data.c (Qcompiled_function): Now static.
6945 * window.c (window_body_lines): Now static.
6947 * image.c (gif_load): Rename local to avoid shadowing.
6949 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
6950 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
6951 * alloc.c (make_save_value): Integer argument is now of type
6953 (mark_object): Use ptrdiff_t, not int.
6954 * lisp.h (pD): New macro.
6955 * print.c (print_object): Use it.
6957 * alloc.c: Use EMACS_INT, not int, to count objects.
6958 (total_conses, total_markers, total_symbols, total_vector_size)
6959 (total_free_conses, total_free_markers, total_free_symbols)
6960 (total_free_floats, total_floats, total_free_intervals)
6961 (total_intervals, total_strings, total_free_strings):
6962 Now EMACS_INT, not int. All uses changed.
6963 (Fgarbage_collect): Compute overall total using a double, so that
6964 integer overflow is less likely to be a problem. Check for overflow
6965 when converting back to an integer.
6966 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
6967 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
6968 These were 'int' variables that could overflow on 64-bit hosts;
6969 they were never used, so remove them instead of repairing them.
6970 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6971 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
6972 Previously, this ceilinged at INT_MAX, but that doesn't work on
6974 (allocate_pseudovector): Don't use EMACS_INT when int would do.
6976 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
6977 (allocate_vectorlike): Check for ptrdiff_t overflow.
6978 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
6979 when a (possibly-narrower) signed value would do just as well.
6980 We prefer using signed arithmetic, to avoid comparison confusion.
6982 * alloc.c: Catch some string size overflows that we were missing.
6983 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
6984 for convenience in STRING_BYTES_MAX.
6985 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
6986 The definition here is exact; the one in lisp.h was approximate.
6987 (allocate_string_data): Check for string overflow. This catches
6988 some instances we weren't catching before. Also, it catches
6989 size_t overflow on (unusual) hosts where SIZE_MAX <= min
6990 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
6991 and ptrdiff_t and EMACS_INT are both 64 bits.
6993 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
6994 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
6995 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
6997 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
6999 * alloc.c (Fmake_string): Check for out-of-range init.
7001 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
7003 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
7005 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
7007 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
7008 xg_get_default_scrollbar_width.
7010 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
7011 (int_gtk_range_get_value): Move to the scroll bar part of the file.
7012 (style_changed_cb): Call update_theme_scrollbar_width and call
7013 x_set_scroll_bar_default_width and xg_frame_set_char_size for
7014 all frames (Bug#8505).
7015 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
7016 Call gtk_window_set_resizable if HAVE_GTK3.
7017 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
7018 and height if HAVE_GTK3 (Bug#8505).
7019 (scroll_bar_width_for_theme): New variable.
7020 (update_theme_scrollbar_width): New function.
7021 (xg_get_default_scrollbar_width): Move code to
7022 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
7023 (xg_initialize): Call update_theme_scrollbar_width.
7025 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
7027 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
7029 2011-06-12 Martin Rudalics <rudalics@gmx.at>
7031 * frame.c (make_frame): Call other_buffer_safely instead of
7034 * window.c (temp_output_buffer_show): Call display_buffer with
7035 second argument Vtemp_buffer_show_specifiers and reset latter
7036 immediately after the call.
7037 (Vtemp_buffer_show_specifiers): New variable.
7038 (auto_window_vscroll_p, next_screen_context_lines)
7039 (Vscroll_preserve_screen_position): Remove leading asterisks from
7042 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
7044 Fix minor problems found by GCC 4.6.0 static checking.
7045 * buffer.c (Qclone_number): Remove for now, as it's unused.
7046 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
7047 (record_buffer): Remove unused local.
7048 * frame.c (other_visible_frames, frame_buffer_list): Now static.
7049 (set_frame_buffer_list): Remove; unused.
7050 * frame.h (other_visible_frames): Remove decl.
7051 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
7052 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
7053 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
7055 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
7056 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
7057 Define only if HAVE_GPM.
7058 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
7059 (update_hints_inhibit): Remove; never set. All uses removed.
7060 * widgetprv.h (emacsFrameClassRec): Remove decl.
7061 * window.c (delete_deletable_window): Now returns void, since it
7062 wasn't returning anything.
7063 (compare_window_configurations): Remove unused locals.
7064 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
7065 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
7066 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
7067 the same widths as pointers. This follows up on the 2011-05-06 patch.
7068 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
7069 * xterm.h: Likewise.
7070 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
7072 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
7074 * makefile.w32-in: Update dependencies.
7075 (LISP_H): Add lib/intprops.h.
7077 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
7079 * image.c (gif_load): Add animation frame delay to the metadata.
7080 (syms_of_image): Use DEFSYM. New symbol `delay'.
7082 2011-06-11 Martin Rudalics <rudalics@gmx.at>
7084 * window.c (delete_deletable_window): Re-add.
7085 (Fset_window_configuration): Rewrite to handle dead buffers and
7086 consequently deletable windows.
7087 (window_tree, Fwindow_tree): Remove. Supply functionality in
7089 (compare_window_configurations): Simplify code.
7091 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
7093 * image.c (imagemagick_load_image): Fix type mismatch.
7094 (Fimagemagick_types): Likewise.
7096 * window.h (replace_buffer_in_windows): Declare.
7098 2011-06-11 Martin Rudalics <rudalics@gmx.at>
7100 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
7101 Qclone_number. Remove external declaration of Qdelete_window.
7102 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
7104 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
7105 Run Qbuffer_list_update_hook if allowed.
7106 (Fother_buffer): Rewrite doc-string. Major rewrite for new
7107 buffer list implementation.
7108 (other_buffer_safely): New function.
7109 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
7110 calls to replace_buffer_in_windows and
7111 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
7113 (record_buffer): Inhibit quitting and rewrite using quittable
7114 functions. Run Qbuffer_list_update_hook if allowed.
7115 (Frecord_buffer, Funrecord_buffer): New functions.
7116 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
7117 Move switch-to-buffer to window.el.
7118 (bury-buffer): Move to window.el.
7119 (Vbuffer_list_update_hook): New variable.
7121 * lisp.h (other_buffer_safely): Add prototype in buffer.c
7124 * window.h (resize_frame_windows): Move up in code.
7125 (Fwindow_frame): Remove EXFUN.
7126 (replace_buffer_in_all_windows): Remove prototype.
7127 (replace_buffer_in_windows_safely): Add prototype.
7129 * window.c: Declare Qdelete_window static again. Move down
7130 declaration of select_count.
7131 (Fnext_window, Fprevious_window): Rewrite doc-strings.
7132 (Fother_window): Move to window.el.
7133 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
7134 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
7135 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
7137 (replace_buffer_in_windows): Implement by calling
7138 Qreplace_buffer_in_windows.
7139 (replace_buffer_in_all_windows): Remove with some functionality
7140 moved into replace_buffer_in_windows_safely.
7141 (replace_buffer_in_windows_safely): New function.
7142 (select_window_norecord, select_frame_norecord): Move in front
7143 of run_window_configuration_change_hook. Remove now obsolete
7145 (Fset_window_buffer): Rewrite doc-string.
7146 Call Qrecord_window_buffer.
7147 (keys_of_window): Move binding for other-window to window.el.
7149 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
7151 * dispextern.h (struct image): Replace data member, whose int_val
7152 and ptr_val fields were not used by anything, with a single
7155 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
7156 (gif_clear_image, gif_load, imagemagick_load_image)
7157 (gs_clear_image, gs_load): Callers changed.
7159 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
7161 * buffer.h: Include <time.h>, for time_t.
7162 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
7164 Fix minor problems found by static checking.
7166 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
7168 Make identifiers static if they are not used in other modules.
7169 * data.c (Qcompiled_function, Qframe, Qvector):
7170 * image.c (QimageMagick, Qsvg):
7171 * minibuf.c (Qmetadata):
7172 * window.c (resize_window_check, resize_root_window): Now static.
7173 * window.h (resize_window_check, resize_root_window): Remove decls.
7175 * window.c (window_deletion_count, delete_deletable_window):
7177 (window_body_lines): Now static.
7178 (Fdelete_other_windows_internal): Mark vars as initialized.
7179 Make sure 'resize_failed' is initialized.
7180 (run_window_configuration_change_hook): Rename local to avoid shadowing.
7181 (resize_window_apply): Remove unused local.
7182 * window.h (delete_deletable_window): Remove decl.
7184 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
7185 (imagemagick_load_image): Fix pointer signedness problem by changing
7186 last arg from unsigned char * to char *. All uses changed.
7187 Also, fix a local for similar reasons.
7188 Remove unused locals. Remove locals to avoid shadowing.
7189 (fn_rsvg_handle_free): Remove; unused.
7190 (svg_load, svg_load_image): Fix pointer signedness problem.
7191 (imagemagick_load_image): Don't use garbage pointer image_wand.
7193 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
7195 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
7197 * image.c (gif_load): Fix omitted cast error introduced by
7200 2011-06-10 Martin Rudalics <rudalics@gmx.at>
7202 * window.h (resize_proportionally, orig_total_lines)
7203 (orig_top_line): Remove from window structure.
7204 (set_window_height, set_window_width, change_window_heights)
7205 (Fdelete_window): Remove prototypes.
7206 (resize_frame_windows): Remove duplicate declaration.
7208 2011-06-10 Eli Zaretskii <eliz@gnu.org>
7210 * window.h (resize_frame_windows, resize_window_check)
7211 (delete_deletable_window, resize_root_window)
7212 (resize_frame_windows): Declare prototypes.
7214 * window.c (resize_window_apply): Make definition be "static" to
7215 match the prototype.
7217 2011-06-10 Martin Rudalics <rudalics@gmx.at>
7219 * window.c: Remove declarations of Qwindow_size_fixed,
7220 window_min_size_1, window_min_size_2, window_min_size,
7221 size_window, window_fixed_size_p, enlarge_window, delete_window.
7222 Remove static from declaration of Qdelete_window, it's
7223 temporarily needed by Fbury_buffer.
7224 (replace_window): Don't assign orig_top_line and
7226 (Fdelete_window, delete_window): Remove. Window deletion is
7227 handled by window.el.
7228 (window_loop): Remove DELETE_OTHER_WINDOWS case.
7229 Replace Fdelete_window calls with calls to Qdelete_window.
7230 (Fdelete_other_windows): Remove. Deleting other windows is
7231 handled by window.el.
7232 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
7233 handled in window.el.
7234 (window_min_size_2, window_min_size_1, window_min_size): Remove.
7235 Window minimum sizes are handled in window.el.
7236 (shrink_windows, size_window, set_window_height)
7237 (set_window_width, change_window_heights, window_height)
7238 (window_width, CURBEG, CURSIZE, enlarge_window)
7239 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
7240 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
7241 handled in window.el.
7242 (make_dummy_parent): Rename to make_parent_window and give it a
7243 second argument horflag.
7244 (make_window): Don't set resize_proportionally any more.
7245 (Fsplit_window): Remove. Windows are split in window.el.
7246 (save_restore_action, save_restore_orig_size)
7247 (shrink_window_lowest_first, save_restore_orig_size): Remove.
7248 Resize mini windows in window.el.
7249 (grow_mini_window, shrink_mini_window): Implement by calling
7250 Qresize_root_window_vertically, resize_window_check and
7251 resize_window_apply.
7252 (saved_window, Fset_window_configuration, save_window_save):
7253 Do not handle orig_top_line, orig_total_lines, and
7254 resize_proportionally.
7255 (window_min_height, window_min_width): Move to window.el.
7256 (keys_of_window): Move bindings for delete-other-windows,
7257 split-window, delete-window and enlarge-window to window.el.
7259 * buffer.c: Temporarily extern Qdelete_window.
7260 (Fbury_buffer): Temporarily call Qdelete_window instead of
7261 Fdelete_window (Fbury_buffer will move to window.el soon).
7263 * frame.c (set_menu_bar_lines_1): Remove code handling
7264 orig_top_line and orig_total_lines.
7266 * dispnew.c (adjust_frame_glyphs_initially): Don't use
7267 set_window_height but set heights directly.
7268 (change_frame_size_1): Use resize_frame_windows.
7270 * xdisp.c (init_xdisp): Don't use set_window_height but set
7273 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
7274 Use resize_frame_windows instead of change_window_heights and run
7275 run_window_configuration_change_hook.
7277 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
7278 instead of change_window_heights and run
7279 run_window_configuration_change_hook.
7281 2011-06-09 Martin Rudalics <rudalics@gmx.at>
7283 * window.c (replace_window): Rename second argument REPLACEMENT to
7284 NEW. New third argument SETFLAG. Rewrite.
7285 (delete_window, make_dummy_parent): Call replace_window with
7287 (window_list_1): Move down in code.
7288 (run_window_configuration_change_hook): Move set_buffer part
7289 before select_frame_norecord part in order to unwind correctly.
7290 Rename count1 to count.
7291 (recombine_windows, delete_deletable_window, resize_root_window)
7292 (Fdelete_other_windows_internal)
7293 (Frun_window_configuration_change_hook, make_parent_window)
7294 (resize_window_check, resize_window_apply, Fresize_window_apply)
7295 (resize_frame_windows, Fsplit_window_internal)
7296 (Fdelete_window_internal, Fresize_mini_window_internal):
7298 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
7300 2011-06-08 Martin Rudalics <rudalics@gmx.at>
7302 * window.h (window): Add some new members to window structure -
7303 normal_lines, normal_cols, new_total, new_normal, clone_number,
7304 splits, nest, prev_buffers, next_buffers.
7305 (WINDOW_TOTAL_SIZE): Move here from window.c.
7306 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
7308 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
7310 (make_dummy_parent): Set new members of windows structure.
7311 (make_window): Move down in code. Handle new members of window
7313 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
7314 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
7315 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
7316 (Fset_window_prev_buffers, Fwindow_next_buffers)
7317 (Fset_window_next_buffers, Fset_window_clone_number):
7319 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
7320 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
7322 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
7323 Argument WINDOW can be now internal window too.
7324 (Fwindow_use_time): Move up in code.
7325 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
7327 (Fset_window_configuration, saved_window)
7328 (Fcurrent_window_configuration, save_window_save): Handle new
7329 members of window structure.
7330 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
7331 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
7332 (syms_of_window): New Lisp objects Qrecord_window_buffer,
7333 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
7334 Qget_mru_window, Qresize_root_window,
7335 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
7336 Qauto_buffer_name; staticpro them.
7338 2011-06-07 Martin Rudalics <rudalics@gmx.at>
7340 * window.c (Fwindow_total_size, Fwindow_left_column)
7341 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
7342 (Fwindow_list_1): New functions.
7343 (window_box_text_cols): Replace with window_body_cols.
7344 (Fwindow_width, Fscroll_left, Fscroll_right):
7345 Use window_body_cols instead of window_box_text_cols.
7346 (delete_window, Fset_window_configuration):
7347 Call delete_all_subwindows with window as argument.
7348 (delete_all_subwindows): Take a window as argument and not a
7350 (window_loop): Remove handling of GET_LRU_WINDOW and
7352 (Fget_lru_window, Fget_largest_window): Move to window.el.
7354 * window.h: Extern window_body_cols instead of
7355 window_box_text_cols. delete_all_subwindows now takes a
7356 Lisp_Object as argument.
7358 * indent.c (compute_motion, Fcompute_motion):
7359 Use window_body_cols instead of window_box_text_cols.
7361 * frame.c (delete_frame): Call delete_all_subwindows with root
7364 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
7366 * fns.c (Fputhash): Document return value.
7368 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
7370 * image.c (gif_load): Implement gif89a spec "no disposal" method.
7372 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7374 Cons<->int and similar integer overflow fixes (Bug#8794).
7376 Check for overflow when converting integer to cons and back.
7377 * charset.c (Fdefine_charset_internal, Fdecode_char):
7378 Use cons_to_unsigned to catch overflow.
7379 (Fencode_char): Use INTEGER_TO_CONS.
7380 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
7381 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
7382 * data.c (long_to_cons, cons_to_long): Remove.
7383 (cons_to_unsigned, cons_to_signed): New functions.
7384 These signal an error for invalid or out-of-range values.
7385 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
7386 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
7387 * font.c (Ffont_variation_glyphs):
7388 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
7389 * lisp.h: Include <intprops.h>.
7390 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
7391 (cons_to_signed, cons_to_unsigned): New decls.
7392 (long_to_cons, cons_to_long): Remove decls.
7393 * undo.c (record_first_change): Use INTEGER_TO_CONS.
7394 (Fprimitive_undo): Use CONS_TO_INTEGER.
7395 * xfns.c (Fx_window_property): Likewise.
7396 * xselect.c: Include <limits.h>.
7397 (x_own_selection, selection_data_to_lisp_data):
7398 Use INTEGER_TO_CONS.
7399 (x_handle_selection_request, x_handle_selection_clear)
7400 (x_get_foreign_selection, Fx_disown_selection_internal)
7401 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
7402 (lisp_data_to_selection_data): Use cons_to_unsigned.
7403 (x_fill_property_data): Use cons_to_signed.
7404 Report values out of range.
7406 Check for buffer and string overflow more precisely.
7407 * buffer.h (BUF_BYTES_MAX): New macro.
7408 * lisp.h (STRING_BYTES_MAX): New macro.
7409 * alloc.c (Fmake_string):
7410 * character.c (string_escape_byte8):
7411 * coding.c (coding_alloc_by_realloc):
7412 * doprnt.c (doprnt):
7413 * editfns.c (Fformat):
7415 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
7416 since they may not be the same number.
7417 * editfns.c (Finsert_char):
7418 * fileio.c (Finsert_file_contents):
7419 Likewise for BUF_BYTES_MAX.
7421 * image.c: Use ptrdiff_t, not int, for sizes.
7422 (slurp_file): Switch from int to ptrdiff_t.
7424 (slurp_file): Check that file size fits in both size_t (for
7425 malloc) and ptrdiff_t (for sanity and safety).
7427 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
7428 if b->modtime has its maximal value.
7430 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
7432 Don't assume time_t can fit into int.
7433 * buffer.h (struct buffer.modtime): Now time_t, not int.
7434 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
7435 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
7437 Minor fixes for signed vs unsigned integers.
7438 * character.h (MAYBE_UNIFY_CHAR):
7439 * charset.c (maybe_unify_char):
7440 * keyboard.c (read_char, reorder_modifiers):
7441 XINT -> XFASTINT, since the integer must be nonnegative.
7442 * ftfont.c (ftfont_spec_pattern):
7443 * keymap.c (access_keymap, silly_event_symbol_error):
7444 XUINT -> XFASTINT, since the integer must be nonnegative.
7445 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
7446 since it makes no difference and we prefer signed.
7447 * keyboard.c (record_char): Use XUINT when all the neighbors do.
7448 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
7451 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
7453 * window.h (Fwindow_frame): Declare.
7455 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7457 * alloc.c: Simplify handling of large-request failures (Bug#8800).
7458 (SPARE_MEMORY): Always define.
7459 (LARGE_REQUEST): Remove.
7460 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
7462 2011-06-06 Martin Rudalics <rudalics@gmx.at>
7464 * lisp.h: Move EXFUNS for Fframe_root_window,
7465 Fframe_first_window and Fset_frame_selected_window to window.h.
7467 * window.h: Move EXFUNS for Fframe_root_window,
7468 Fframe_first_window and Fset_frame_selected_window here from
7471 * frame.c (Fwindow_frame, Fframe_first_window)
7472 (Fframe_root_window, Fframe_selected_window)
7473 (Fset_frame_selected_window): Move to window.c.
7474 (Factive_minibuffer_window): Move to minibuf.c.
7475 (Fother_visible_frames_p): New function.
7477 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
7479 * window.c (decode_window, decode_any_window): Move up in code.
7480 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
7481 (inhibit_frame_unsplittable): Remove unused variable.
7482 (Fwindow_buffer): Move up and rewrite doc-string.
7483 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
7484 (Fwindow_prev): New functions.
7485 (Fwindow_frame): Move here from frame.c. Accept any window as
7487 (Fframe_root_window, Fframe_first_window)
7488 (Fframe_selected_window): Move here from frame.c. Accept frame
7489 or arbitrary window as argument. Update doc-strings.
7490 (Fminibuffer_window): Move up in code.
7491 (Fwindow_minibuffer_p): Move up in code and simplify.
7492 (Fset_frame_selected_window): Move here from frame.c.
7494 (Fselected_window, select_window, Fselect_window): Move up in
7495 code. Minor doc-string fixes.
7497 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7499 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
7500 Do not assume that spare memory exists; that assumption is valid
7501 only if SYSTEM_MALLOC.
7502 (LARGE_REQUEST): New macro, so that the issue of large requests
7503 is separated from the issue of spare memory.
7505 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
7507 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
7510 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
7512 * xfns.c (x_set_scroll_bar_default_width): Move declarations
7515 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
7517 * gtkutil.c (xg_get_default_scrollbar_width): New function.
7519 * gtkutil.h: Declare xg_get_default_scrollbar_width.
7521 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
7522 min width by calling x_set_scroll_bar_default_width (Bug#8505).
7524 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
7526 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
7528 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
7530 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
7531 (x_clipboard_manager_save): Add return value.
7532 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
7534 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
7535 Obey Vx_select_enable_clipboard_manager. Catch errors in
7536 x_clipboard_manager_save (Bug#8779).
7537 (Vx_select_enable_clipboard_manager): New variable.
7538 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
7540 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
7542 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
7544 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7546 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
7547 in the current matrix if keep_current_p is non-zero.
7549 2011-06-04 Eli Zaretskii <eliz@gnu.org>
7551 * bidi.c (bidi_level_of_next_char): Fix last change.
7553 2011-06-03 Eli Zaretskii <eliz@gnu.org>
7555 Support bidi reordering of text covered by display properties.
7557 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
7558 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
7559 (bidi_cache_search, bidi_cache_iterator_state)
7560 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
7561 (bidi_level_of_next_char, bidi_move_to_visually_next):
7562 Support character positions inside a run of characters covered by a
7564 (bidi_paragraph_init, bidi_resolve_explicit_1)
7565 (bidi_level_of_next_char): Call bidi_fetch_char and
7566 bidi_fetch_char_advance instead of FETCH_CHAR and
7568 (bidi_init_it): Initialize new members.
7569 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
7571 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
7572 instead of using explicit *_CHAR codes.
7573 (bidi_resolve_explicit, bidi_resolve_weak):
7574 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
7575 bidirectional text is supported only in multibyte buffers.
7576 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
7577 it to initialize the frame_window_p member of struct bidi_it.
7578 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
7579 (bidi_resolve_explicit, bidi_resolve_weak)
7580 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
7581 bidi_it->nchars is non-positive.
7582 (bidi_level_of_next_char): Don't try to lookup the cache for the
7583 next/previous character if nothing is cached there yet, or if we
7584 were just reseat()'ed to a new position.
7586 * xdisp.c (set_cursor_from_row): Set start and stop points
7587 according to the row's direction when priming the loop that looks
7588 for the glyph on which to display cursor.
7589 (single_display_spec_intangible_p): Function deleted.
7590 (display_prop_intangible_p): Reimplement to call
7591 handle_display_spec instead of single_display_spec_intangible_p.
7592 Accept 3 additional arguments needed by handle_display_spec.
7593 This fixes incorrect cursor motion across display property with complex
7594 values: lists, `(when COND...)' forms, etc.
7595 (single_display_spec_string_p): Support property values that are
7596 lists with the argument STRING its top-level element.
7597 (display_prop_string_p): Fix the condition for processing a
7598 property that is a list to be consistent with handle_display_spec.
7599 (handle_display_spec): New function, refactored from the
7600 last portion of handle_display_prop.
7601 (compute_display_string_pos): Accept additional argument
7602 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
7603 value of a `display' property is a "replacing spec".
7604 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
7605 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
7606 the display property, but just return a value indicating whether
7607 the display property will replace the characters it covers.
7608 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
7609 frame_window_p members of struct bidi_it.
7610 (compute_display_string_pos, compute_display_string_end):
7612 (push_it): Accept second argument POSITION, where pop_it should
7613 jump to continue iteration.
7614 (reseat_1): Initialize bidi_it.disp_pos.
7616 * keyboard.c (adjust_point_for_property): Adjust the call to
7617 display_prop_intangible_p to its new signature.
7619 * dispextern.h (struct bidi_it): New member frame_window_p.
7620 (bidi_init_it): Update prototypes.
7621 (display_prop_intangible_p): Update prototype.
7622 (compute_display_string_pos, compute_display_string_end):
7624 (struct bidi_it): New members nchars and disp_pos. ch_len is now
7627 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
7629 Malloc failure behavior now depends on size of allocation.
7630 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
7631 * lisp.h: Change signatures accordingly.
7632 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
7633 All callers changed. (Bug#8762)
7635 * gnutls.c: Use Emacs's memory allocators.
7636 Without this change, the gnutls library would invoke malloc etc.
7637 directly, which causes problems on non-SYNC_INPUT hosts, and which
7638 runs afoul of improving memory_full behavior. (Bug#8761)
7639 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
7640 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
7641 xfree instead of the default malloc, realloc, free.
7642 (Fgnutls_boot): No need to check for memory allocation failure,
7643 since xmalloc does that for us.
7645 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
7646 * category.c (hash_get_category_set):
7647 * ccl.c (ccl_driver):
7648 * charset.c (Fdefine_charset_internal):
7649 * charset.h (struct charset.hash_index):
7650 * composite.c (get_composition_id, gstring_lookup_cache)
7651 (composition_gstring_put_cache):
7652 * composite.h (struct composition.hash_index):
7653 * dispextern.h (struct image.hash):
7654 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
7655 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
7656 (hashfn_equal, hashfn_user_defined, make_hash_table)
7657 (maybe_resize_hash_table, hash_lookup, hash_put)
7658 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
7659 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
7660 (Fsxhash, Fgethash, Fputhash, Fmaphash):
7661 * image.c (make_image, search_image_cache, lookup_image)
7662 (xpm_put_color_table_h):
7663 * lisp.h (struct Lisp_Hash_Table):
7664 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
7665 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
7666 for hashes and hash indexes, instead of 'unsigned' and 'int'.
7667 * alloc.c (allocate_vectorlike):
7668 Check for overflow in vector size calculations.
7669 * ccl.c (ccl_driver):
7670 Check for overflow when converting EMACS_INT to int.
7671 * fns.c, image.c: Remove unnecessary static decls that would otherwise
7672 need to be updated by these changes.
7673 * fns.c (make_hash_table, maybe_resize_hash_table):
7674 Check for integer overflow with large hash tables.
7675 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
7676 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
7677 (SXHASH_REDUCE): New macro.
7678 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
7679 Use it instead of discarding useful hash info with large hash values.
7680 (sxhash_float): New function.
7681 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
7682 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
7683 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
7684 Rewrite to use FIXNUM_BITS, as this simplifies things.
7685 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
7686 Adjust signatures to match updated version of code.
7687 (consing_since_gc): Now EMACS_INT, since a single hash table can
7688 use more than INT_MAX bytes.
7690 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
7692 Make it possible to build with GCC-4.6+ -O2 -flto.
7694 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
7696 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
7698 * minibuf.c (get_minibuffer, read_minibuf_unwind):
7699 Call minibuffer-inactive-mode.
7701 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
7703 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
7704 Update dependencies.
7706 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7708 * data.c (init_data): Remove code for UTS, this system is not
7711 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7713 Don't force ./temacs to start in terminal mode.
7715 * frame.c (make_initial_frame): Initialize faces in all cases, not
7716 only when CANNOT_DUMP is defined.
7717 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
7719 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7721 * dispnew.c (add_window_display_history): Use const for the string
7722 pointer. Remove declaration, not needed.
7724 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
7726 Use 'inline', not 'INLINE'.
7727 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
7728 * alloc.c, fontset.c (INLINE): Remove.
7729 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
7730 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
7731 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
7732 * gmalloc.c (register_heapinfo): Use inline unconditionally.
7733 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
7735 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
7737 Make it possible to run ./temacs.
7739 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
7740 syms_of_callproc does the same thing. Remove test for
7741 "initialized", do it in the caller.
7742 * emacs.c (main): Avoid calling set_initial_environment when dumping.
7744 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
7746 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
7747 (read_minibuf): Use get_minibuffer.
7748 (syms_of_minibuf): Use DEFSYM.
7749 (Qmetadata): New var.
7750 * data.c (Qbuffer): Don't make it static.
7751 (syms_of_data): Use DEFSYM.
7753 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
7755 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
7756 (CCL_CODE_MIN): New macro.
7758 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
7760 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
7762 * eval.c (Qdebug): Now static.
7763 * lisp.h (Qdebug): Remove decl. This reverts a part of the
7764 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
7765 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
7767 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
7769 * image.c: Various fixes to ImageMagick code comments.
7770 (Fimagemagick_types): Doc fix.
7772 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
7774 Minor fixes prompted by GCC 4.6.0 warnings.
7776 * xselect.c (converted_selections, conversion_fail_tag): Now static.
7778 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
7779 (x_clipboard_manager_save_all): Move extern decl to ...
7780 * xterm.h: ... here, so that it can be checked for consistency.
7782 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
7784 * xselect.c (x_clipboard_manager_save_frame)
7785 (x_clipboard_manager_save_all): New functions.
7786 (Fx_clipboard_manager_save): Lisp function deleted.
7788 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
7789 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
7791 * xterm.h: Update prototype.
7793 2011-05-28 William Xu <william.xwl@gmail.com>
7795 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
7798 2011-05-28 Jim Meyering <meyering@redhat.com>
7800 Avoid a sign-extension bug in crypto_hash_function.
7801 * fns.c (to_uchar): Define.
7802 (crypto_hash_function): Use it to convert some newly-signed
7803 variables to unsigned, to avoid sign-extension bugs. For example,
7804 without this change, (md5 "truc") would evaluate to
7805 45723a2aff78ff4fff7fff1114760e62 rather than the expected
7806 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
7807 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
7809 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
7811 Integer overflow fixes.
7813 * dbusbind.c: Serial number integer overflow fixes.
7814 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
7815 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
7816 to hold a serial number that is too large for a fixnum.
7817 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7818 Check for serial numbers out of range. Decode any serial number
7819 that was so large that it became a float. (Bug#8722)
7821 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
7822 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7823 Use XFASTINT rather than XUINT when numbers are nonnegative.
7824 (xd_append_arg, Fdbus_method_return_internal):
7825 (Fdbus_method_error_internal): Likewise. Also, for unsigned
7826 arguments, check that Lisp number is nonnegative, rather than
7827 silently wrapping negative numbers around. (Bug#8722)
7828 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
7831 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
7833 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
7835 ccl: Add integer overflow checks.
7836 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
7837 (IN_INT_RANGE): New macros.
7838 (ccl_driver): Use them to check for integer overflow when
7839 decoding a CCL program. Many of the new checks are whether XINT (x)
7840 fits in int; it doesn't always, on 64-bit hosts. The new version
7841 doesn't catch all possible integer overflows, but it's an
7842 improvement. (Bug#8719)
7844 * alloc.c (make_event_array): Use XINT, not XUINT.
7845 There's no need for unsigned here.
7847 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
7848 This follows up to the 2011-05-06 change that substituted uintptr_t
7849 for EMACS_INT. This case wasn't caught back then.
7851 Rework Fformat to avoid integer overflow issues.
7852 * editfns.c: Include <float.h> unconditionally, as it's everywhere
7853 now (part of C89). Include <verify.h>.
7854 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
7855 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
7856 (Fformat): Avoid the prepass trying to compute sizes; it was only
7857 approximate and thus did not catch overflow reliably. Instead, walk
7858 through the format just once, formatting and computing sizes as we go,
7859 checking for integer overflow at every step, and allocating a larger
7860 buffer as needed. Keep track separately whether the format is
7861 multibyte. Keep only the most-recently calculated precision, rather
7862 than them all. Record whether each argument has been converted to
7863 string. Use EMACS_INT, not int, for byte and char and arg counts.
7864 Support field widths and precisions larger than INT_MAX. Avoid
7865 sprintf's undefined behavior with conversion specifications such as %#d
7866 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
7867 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
7868 formatting out-of-range floating point numbers with int
7871 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
7873 * data.c: Avoid integer truncation in expressions involving floats.
7874 * data.c: Include <intprops.h>.
7875 (arith_driver): When there's an integer overflow in an expression
7876 involving floating point, convert the integers to floating point
7877 so that the resulting value does not suffer from catastrophic
7878 integer truncation. For example, on a 64-bit host (* 4
7879 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
7880 Do not rely on undefined behavior after integer overflow.
7882 merge count_size_as_multibyte, parse_str_to_multibyte
7883 * character.c, character.h (count_size_as_multibyte):
7884 Rename from parse_str_to_multibyte; all uses changed.
7885 Check for integer overflow.
7886 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
7887 since it's now a duplicate of the other. This is more of
7888 a character than a buffer op, so better that it's in character.c.
7889 * fns.c, print.c: Adjust to above changes.
7891 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
7893 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
7895 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
7897 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
7898 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
7899 (x_clipboard_manager_save): Now static.
7900 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
7902 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
7903 (crypto_hash_function): Now static.
7904 Fix pointer signedness problems. Avoid unnecessary initializations.
7906 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
7908 * termhooks.h (Vselection_alist): Make it terminal-local.
7910 * terminal.c (create_terminal): Initialize it.
7912 * xselect.c: Support for clipboard managers.
7913 (Vselection_alist): Move to termhooks.h as terminal-local var.
7914 (LOCAL_SELECTION): New macro.
7915 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
7916 (symbol_to_x_atom): Remove gratuitous arg.
7917 (x_handle_selection_request, lisp_data_to_selection_data)
7918 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
7919 (x_own_selection, x_get_local_selection, x_convert_selection):
7920 New arg, specifying work frame. Use terminal-local Vselection_alist.
7921 (some_frame_on_display): Delete unused function.
7922 (Fx_own_selection_internal, Fx_get_selection_internal)
7923 (Fx_disown_selection_internal, Fx_selection_owner_p)
7924 (Fx_selection_exists_p): New optional frame arg.
7925 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
7926 (x_handle_selection_clear): Don't treat other terminals with the
7927 same keyboard specially. Use the terminal-local Vselection_alist.
7928 (x_clear_frame_selections): Use Frun_hook_with_args.
7930 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
7932 * xterm.h: Add support for those atoms.
7934 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
7936 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
7937 (converted_selections, conversion_fail_tag): New global variables.
7938 (x_selection_request_lisp_error): Free the above.
7939 (x_get_local_selection): Remove unnecessary code.
7940 (x_reply_selection_request): Args changed; handle arbitrary array
7941 of converted selections stored in converted_selections.
7942 Separate the XChangeProperty and SelectionNotify steps.
7943 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
7944 (x_convert_selection): New function.
7945 (x_handle_selection_event): Simplify.
7946 (x_get_foreign_selection): Don't ignore incoming requests while
7947 waiting for an answer; this will fail when we implement
7948 SAVE_TARGETS, and seems unnecessary anyway.
7949 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
7950 (Vx_sent_selection_functions): Doc fix.
7952 2011-05-26 Leo Liu <sdl.web@gmail.com>
7954 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
7956 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7958 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
7960 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
7961 for fringe update if it has periodic bitmap.
7962 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
7963 and fringe_bitmap_periodic_p.
7965 * fringe.c (get_fringe_bitmap_data): New function.
7966 (draw_fringe_bitmap_1, update_window_fringes): Use it.
7967 (update_window_fringes): Record periodicity of fringe bitmap in glyph
7968 row. Mark glyph row for fringe update if periodicity changed.
7970 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
7971 for fringe update unless it has periodic bitmap.
7973 2011-05-25 Kenichi Handa <handa@m17n.org>
7975 * xdisp.c (get_next_display_element): Set correct it->face_id for
7976 a static composition.
7978 2011-05-24 Leo Liu <sdl.web@gmail.com>
7981 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
7983 * fns.c (crypto_hash_function, Fsha1): New function.
7984 (Fmd5): Use crypto_hash_function.
7985 (syms_of_fns): Add Ssha1.
7987 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
7989 * gnutls.c: Remove unused macros.
7990 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
7991 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
7992 Remove macros that are defined and never used.
7993 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
7995 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
7997 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
7998 (Fx_get_selection_internal): Minor cleanup.
7999 (Fx_own_selection_internal): Rename arguments for consistency with
8002 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8004 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
8006 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
8008 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
8010 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8012 * dispnew.c (scrolling_window): Don't exclude the case that the
8013 last enabled row in the desired matrix touches the bottom boundary.
8015 2011-05-21 Glenn Morris <rgm@gnu.org>
8017 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
8018 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
8019 and add some more files.
8021 2011-05-20 Eli Zaretskii <eliz@gnu.org>
8023 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
8024 report_file_error introduced by the change from 2011-05-07.
8026 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
8028 * systime.h (Time): Define only if emacs is defined.
8029 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
8030 where the include path doesn't have X11/X.h by default. See
8031 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
8033 2011-05-20 Kenichi Handa <handa@m17n.org>
8035 * composite.c (find_automatic_composition): Fix previous change.
8037 2011-05-20 Glenn Morris <rgm@gnu.org>
8039 * lisp.mk: New file, split from Makefile.in.
8040 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
8041 (shortlisp): Remove.
8042 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
8044 2011-05-19 Glenn Morris <rgm@gnu.org>
8046 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
8047 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
8048 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
8049 (lisp): Set the order to that of loadup.el.
8050 (shortlisp): Make it a copy of $lisp.
8051 (SOME_MACHINE_LISP): Remove.
8052 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
8053 Use just $shortlisp, not $SOME_MACHINE_LISP too.
8055 2011-05-18 Kenichi Handa <handa@m17n.org>
8057 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
8058 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
8059 (find_automatic_composition): Mostly rewrite for efficiency.
8061 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
8063 * makefile.w32-in: Update dependencies.
8065 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
8067 * menu.c: Include limits.h (fixes the MS-Windows build broken by
8068 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8070 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
8072 Fix some integer overflow issues, such as string length overflow.
8074 * insdel.c (count_size_as_multibyte): Check for string overflow.
8076 * character.c (lisp_string_width): Check for string overflow.
8077 Use EMACS_INT, not int, for string indexes and lengths; in
8078 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
8079 the resulting string length overflows an EMACS_INT; instead,
8080 report a string overflow if no precision given. When checking for
8081 precision exhaustion, use a check that cannot possibly have
8082 integer overflow. (Bug#8675)
8083 * character.h (lisp_string_width): Adjust to new signature.
8085 * alloc.c (string_overflow): New function.
8086 (Fmake_string): Use it. This doesn't change behavior, but saves
8087 a few bytes and will simplify future changes.
8088 * character.c (string_escape_byte8): Likewise.
8089 * lisp.h (string_overflow): New decl.
8091 Fixups, following up to the user-interface timestamp change.
8092 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
8093 for UI timestamps, instead of unsigned long.
8094 * msdos.c (mouse_get_pos): Likewise.
8095 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
8096 * w32gui.h (Time): Define by including "systime.h" rather than by
8097 declaring it ourselves. (Bug#8664)
8099 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
8100 * image.c (clear_image_cache): Likewise.
8102 * term.c (term_mouse_position): Don't assume time_t wraparound.
8104 Be more systematic about user-interface timestamps.
8105 Before, the code sometimes used 'Time', sometimes 'unsigned long',
8106 and sometimes 'EMACS_UINT', to represent these timestamps.
8107 This change causes it to use 'Time' uniformly, as that's what X uses.
8108 This makes the code easier to follow, and makes it easier to catch
8109 integer overflow bugs such as Bug#8664.
8110 * frame.c (Fmouse_position, Fmouse_pixel_position):
8111 Use Time, not unsigned long, for user-interface timestamps.
8112 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
8113 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
8114 * keyboard.h (last_event_timestamp): Likewise.
8115 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
8116 * menu.h (xmenu_show): Likewise.
8117 * term.c (term_mouse_position): Likewise.
8118 * termhooks.h (struct input_event.timestamp): Likewise.
8119 (struct terminal.mouse_position_hook): Likewise.
8120 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
8121 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
8122 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
8123 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
8125 * menu.h, termhooks.h: Include "systime.h", for Time.
8127 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
8128 Don't assume that the difference between two unsigned long values
8129 can fit into an integer. At this point, we know button_down_time
8130 <= event->timestamp, so the difference must be nonnegative, so
8131 there's no need to cast the result if double-click-time is
8132 nonnegative, as it should be; check that it's nonnegative, just in
8133 case. This bug is triggered when events are more than 2**31 ms
8134 apart (about 25 days). (Bug#8664)
8136 * xselect.c (last_event_timestamp): Remove duplicate decl.
8137 (x_own_selection): Remove needless cast to unsigned long.
8139 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
8140 that always fit in int. Use a sentinel instead of a counter, to
8141 avoid a temp and to allay GCC's concerns about possible int overflow.
8142 * frame.h (struct frame): Use int for menu_bar_items_used
8143 instead of EMACS_INT, since it always fits in int.
8145 * menu.c (grow_menu_items): Check for int overflow.
8147 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
8149 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
8150 Before, the code was not consistent. These values cannot exceed
8151 2**31 - 1 so there's no need to make them unsigned.
8152 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
8153 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
8154 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
8156 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
8158 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
8159 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
8160 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
8161 presumably because the widths might not match.
8163 * window.c (size_window): Avoid needless test at loop start.
8165 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
8167 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
8169 2011-05-12 Drew Adams <drew.adams@oracle.com>
8171 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
8173 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8175 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
8176 `width' to `bar_area_x' and `bar_area_width', respectively.
8177 (x_scroll_run): Take account of fringe background extension.
8179 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
8180 Rename local vars `left' and `width' to `bar_area_x' and
8181 `bar_area_width', respectively.
8182 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
8183 background extension.
8185 2011-05-10 Jim Meyering <meyering@redhat.com>
8187 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
8189 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
8191 * image.c (Finit_image_library): Return t for built-in image types,
8192 like pbm and xbm. (Bug#8640)
8194 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
8196 * w32menu.c (set_frame_menubar): Fix submenu allocation.
8198 2011-05-07 Eli Zaretskii <eliz@gnu.org>
8200 * w32console.c (Fset_screen_color): Doc fix.
8201 (Fget_screen_color): New function.
8202 (syms_of_ntterm): Defsubr it.
8204 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
8205 unlink the temporary file if Fcall_process didn't create it in the
8207 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
8208 child process will be redirected to a file specified with `:file'.
8209 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
8210 cue to call_process_cleanup not to close that handle.
8212 2011-05-07 Ben Key <bkey76@gmail.com>
8214 * makefile.w32-in: The bootstrap-temacs rule now makes use of
8215 one of two shell specific rules, either bootstrap-temacs-CMD or
8216 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
8217 to the previous implementation of the bootstrap-temacs rule.
8218 The bootstrap-temacs-CMD rule is similar to the previous
8219 implementation of the bootstrap-temacs rule except that it
8220 makes use of the ESC_CFLAGS variable instead of the CFLAGS
8223 These changes, along with some changes to nt/configure.bat,
8224 nt/gmake.defs, and nt/nmake.defs, are required to extend my
8225 earlier fix to add support for --cflags and --ldflags options
8226 that include quotes so that it works whether make uses cmd or
8229 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
8231 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
8232 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
8234 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
8235 a string. Handle both cases.
8236 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
8237 (Fdbus_register_method): Use Qinvalid_function.
8239 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
8241 * makefile.w32-in: Update dependencies.
8242 (LISP_H): Add inttypes.h and stdin.h.
8243 (PROCESS_H): Add unistd.h.
8245 2011-05-06 Eli Zaretskii <eliz@gnu.org>
8247 * lread.c: Include limits.h (fixes the MS-Windows build broken by
8248 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
8250 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
8252 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
8254 * term.c (vfatal): Remove stray call to va_end.
8255 It's not needed and the C Standard doesn't allow it here anyway.
8257 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
8258 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
8260 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
8263 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
8265 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8267 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
8269 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
8271 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
8273 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
8274 * charset.c (Fdefine_charset_internal): Don't initialize
8275 charset.code_space[15]. The value was garbage, on hosts with
8276 32-bit int (Bug#8600).
8278 * lread.c (read_integer): Be more consistent with string-to-number.
8279 Use string_to_number to do the actual conversion; this avoids
8280 rounding errors and fixes some other screwups. Without this fix,
8281 for example, #x1fffffffffffffff was misread as -2305843009213693952.
8282 (digit_to_number): Move earlier, for benefit of read_integer.
8283 Return -1 if the digit is out of range for the base, -2 if it is
8284 not a digit in any supported base. (Bug#8602)
8286 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
8288 * dispnew.c (scrolling_window): Return 1 if we scrolled,
8289 to match comment at start of function. This also removes a
8290 GCC warning about overflow in a 32+64-bit port.
8292 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
8294 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
8295 Reported by Stefan Monnier in
8296 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
8297 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8298 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
8300 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
8301 (EMACS_UINTPTR): Likewise, with uintptr_t.
8303 * lisp.h: Prefer 64-bit EMACS_INT if available.
8304 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
8305 on 32-bit hosts that have 64-bit int, so that they can access
8307 However, temporarily disable this change unless the temporary
8308 symbol WIDE_EMACS_INT is defined.
8310 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
8312 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
8313 This removes an assumption that EMACS_INT and long are the same
8314 width as pointers. The assumption is true for Emacs porting targets
8315 now, but we want to make other targets possible.
8316 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
8317 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
8318 In the rest of the code, change types of integers that hold casted
8319 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
8320 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
8321 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
8322 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
8323 No need to cast type when ORing.
8324 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
8325 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
8326 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
8327 assume EMACS_INT is the same width as char *.
8328 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
8329 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
8330 Remove no-longer-needed casts.
8331 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
8332 (xg_tool_bar_help_callback, xg_make_tool_item):
8333 Use EMACS_INTPTR to hold an integer
8334 that will be cast to void *; this can avoid a GCC warning
8335 if EMACS_INT is not the same width as void *.
8336 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
8337 * xdisp.c (display_echo_area_1, resize_mini_window_1):
8338 (current_message_1, set_message_1):
8339 Use a local to convert to proper width without a cast.
8340 * xmenu.c (dialog_selection_callback): Likewise.
8342 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
8343 Also, don't assume VALBITS / RAND_BITS is less than 5,
8344 and don't rely on undefined behavior when shifting a 1 left into
8346 * lisp.h (get_random): Change signature to match.
8348 * lread.c (hash_string): Use size_t, not int, for hash computation.
8349 Normally we prefer signed values; but hashing is special, because
8350 it's better to use unsigned division on hash table sizes so that
8351 the remainder is nonnegative. Also, size_t is the natural width
8352 for hashing into memory. The previous code used 'int', which doesn't
8353 retain enough info to hash well into very large tables.
8354 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
8356 * dbusbind.c: Don't possibly lose pointer info when converting.
8357 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8358 Use XPNTR rather than XHASH, so that the high-order bits of
8359 the pointer aren't lost when converting through void *.
8361 * eval.c (Fautoload): Don't double-shift a pointer.
8363 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
8365 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
8367 * gnutls.c (DEF_GNUTLS_FN):
8368 * image.c (DEF_IMGLIB_FN): Make function pointers static.
8370 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
8372 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
8375 2011-05-05 Eli Zaretskii <eliz@gnu.org>
8377 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
8378 New version that can reserve upto 2GB of heap space.
8380 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
8382 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
8384 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
8386 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
8387 `gnutls_certificate_set_x509_key_file'.
8389 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
8391 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
8392 Update dependencies.
8394 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8396 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
8397 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
8398 Remove unused parameter `fildes'.
8399 * process.c (read_process_output, send_process): Don't pass it.
8401 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8403 Fix previous change: the library cache is defined in w32.c.
8404 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
8405 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
8407 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
8409 Implement dynamic loading of GnuTLS on Windows.
8411 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
8412 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
8413 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8416 * gnutls.c (Qgnutls_dll): Define.
8417 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
8418 (gnutls_*): Declare function pointers.
8419 (init_gnutls_functions): New function to initialize function pointers.
8420 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
8421 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
8422 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8423 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
8424 (emacs_gnutls_write, emacs_gnutls_read)
8425 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
8426 (Fgnutls_available_p): New function.
8427 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
8428 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
8429 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
8431 * image.c: Include w32.h.
8432 (Vimage_type_cache): Delete.
8433 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
8434 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
8435 (w32_delayed_load): Move to w32.c.
8437 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
8439 * w32.c (QCloaded_from, Vlibrary_cache): Define.
8440 (w32_delayed_load): Move from image.c. When loading a library, record
8441 its filename in the :loaded-from property of the library id.
8442 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
8443 Initialize and staticpro them.
8444 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
8446 * process.c: Include lisp.h before w32.h, not after.
8447 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
8448 instead of gnutls_record_check_pending.
8450 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
8452 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
8454 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
8455 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
8458 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
8460 * xterm.c (x_set_frame_alpha): Do not set property on anything
8461 else than FRAME_X_OUTER_WINDOW (Bug#8608).
8463 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
8465 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
8467 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
8469 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
8470 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
8471 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
8472 (gnutls_global_initialized, Qgnutls_bootprop_priority)
8473 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
8474 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
8475 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
8476 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
8477 (Qgnutls_bootprop_callbacks_verify): Make static.
8479 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
8481 * callproc.c: Indentation fixup.
8483 * sysdep.c (wait_for_termination_1): Make static.
8484 (wait_for_termination, interruptible_wait_for_termination):
8485 Move after wait_for_termination_1.
8487 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
8489 * sysdep.c (interruptible_wait_for_termination): New function
8490 which is like wait_for_termination, but allows keyboard
8493 * callproc.c (Fcall_process): Add (:file "file") as an option for
8495 (Fcall_process_region): Ditto.
8497 2011-04-30 Eli Zaretskii <eliz@gnu.org>
8499 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
8500 rather than `XVECTOR (FOO)->size'.
8502 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
8503 inttypes.h, as a gnulib replacement is used if it not available in
8506 2011-04-21 Eli Zaretskii <eliz@gnu.org>
8508 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
8509 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
8510 of MOST_POSITIVE_FIXNUM. (Bug#8528)
8512 * coding.c (coding_alloc_by_realloc): Error out if destination
8513 will grow beyond MOST_POSITIVE_FIXNUM.
8514 (decode_coding_emacs_mule): Abort if there isn't enough place in
8515 charbuf for the composition carryover bytes. Reserve an extra
8516 space for up to 2 characters produced in a loop.
8517 (decode_coding_iso_2022): Abort if there isn't enough place in
8518 charbuf for the composition carryover bytes.
8520 2011-04-21 Eli Zaretskii <eliz@gnu.org>
8522 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
8523 aborting when %lld or %lll format is passed.
8524 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
8525 %llo or %llx format is passed. (Bug#8545)
8527 * window.c (window_scroll_line_based): Use a marker instead of
8528 simple variables to record original value of point. (Bug#7952)
8530 * doprnt.c (doprnt): Fix the case where a multibyte sequence
8531 produced by %s or %c overflows available buffer space. (Bug#8545)
8533 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
8535 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
8536 (SIZE_MAX): Move defn after all includes, as they might #define it.
8538 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8540 * w32.c (init_environment): Warn about defaulting HOME to C:\.
8542 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8544 * keyboard.c (Qdelayed_warnings_hook): Define.
8545 (command_loop_1): Run `delayed-warnings-hook'
8546 if Vdelayed_warnings_list is non-nil.
8547 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
8548 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
8550 2011-04-28 Eli Zaretskii <eliz@gnu.org>
8552 * doprnt.c (doprnt): Don't return value smaller than the buffer
8553 size if the message was truncated. (Bug#8545).
8555 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
8557 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
8558 (Fx_window_property): #if-0 the whole functions, not just the bodies.
8560 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8562 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
8564 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
8566 * makefile.w32-in: Update dependencies.
8568 2011-04-27 Eli Zaretskii <eliz@gnu.org>
8570 Improve `doprnt' and its usage. (Bug#8545)
8571 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
8572 `format_end'. Remove support for %l as a conversion specifier.
8573 Don't use xrealloc. Improve diagnostics when the %l size modifier
8574 is used. Update the commentary.
8576 * eval.c (verror): Simplify calculation of size_t.
8578 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
8581 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
8583 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
8586 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8588 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
8589 This makes this file independent of the recent pseudovector change.
8591 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
8593 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
8595 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
8596 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8597 Remove unused local.
8598 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
8600 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
8601 GCC 4.6.0 optimizes based on type-based alias analysis.
8602 For example, if b is of type struct buffer * and v of type struct
8603 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
8604 != &v->size, and therefore "v->size = 1; b->size = 2; return
8605 v->size;" must therefore return 1. This assumption is incorrect
8606 for Emacs, since it type-puns struct Lisp_Vector * with many other
8607 types. To fix this problem, this patch adds a new type struct
8608 vectorlike_header that documents the constraints on layout of vectors
8609 and pseudovectors, and helps optimizing compilers not get fooled
8610 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
8611 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
8612 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
8614 (XSETPVECTYPE): Rewrite in terms of new macro.
8615 (XSETPVECTYPESIZE): New macro, specifying both type and size.
8616 This is a bit clearer, and further avoids the possibility of
8617 undesirable aliasing.
8618 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
8619 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
8620 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
8621 since Lisp_Subr is a special case (no "next" field).
8622 (ASIZE): Now uses header.size rather than size.
8623 All previous uses of XVECTOR (foo)->size replaced to use this macro,
8624 to avoid the hassle of writing XVECTOR (foo)->header.size.
8625 (struct vectorlike_header): New type.
8626 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
8627 object, to help avoid aliasing.
8628 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
8629 (SUBRP): Likewise, since Lisp_Subr is a special case.
8630 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
8631 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
8632 (struct Lisp_Hash_Table): Combine first two members into a single
8633 struct vectorlike_header member. All uses of "size" and "next" members
8634 changed to be "header.size" and "header.next".
8635 * buffer.h (struct buffer): Likewise.
8636 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
8637 * frame.h (struct frame): Likewise.
8638 * process.h (struct Lisp_Process): Likewise.
8639 * termhooks.h (struct terminal): Likewise.
8640 * window.c (struct save_window_data, struct saved_window): Likewise.
8641 * window.h (struct window): Likewise.
8642 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
8643 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
8644 * buffer.c (init_buffer_once): Likewise.
8645 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
8647 * process.c (Fformat_network_address): Use local var for size,
8650 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
8652 Make the Lisp reader and string-to-float more consistent (Bug#8525)
8653 * data.c (atof): Remove decl; no longer used or needed.
8654 (digit_to_number): Move to lread.c.
8655 (Fstring_to_number): Use new string_to_number function, to be
8656 consistent with how the Lisp reader treats infinities and NaNs.
8657 Do not assume that floating-point numbers represent EMACS_INT
8658 without losing information; this is not true on most 64-bit hosts.
8659 Avoid double-rounding errors, by insisting on integers when
8660 parsing non-base-10 numbers, as the documentation specifies.
8661 * lisp.h (string_to_number): New decl, replacing ...
8662 (isfloat_string): Remove.
8663 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
8664 (read1): Do not accept +. and -. as integers; this
8665 appears to have been a coding error. Similarly, do not accept
8666 strings like +-1e0 as floating point numbers. Do not report
8667 overflow for integer overflows unless the base is not 10 which
8668 means we have no simple and reliable way to continue.
8669 Break out the floating-point parsing into a new
8670 function string_to_number, so that Fstring_to_number parses
8671 floating point numbers consistently with the Lisp reader.
8672 (digit_to_number): Move here from data.c. Make it static inline.
8673 (E_CHAR, EXP_INT): Remove, replacing with ...
8674 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
8675 (string_to_number): New function, replacing isfloat_string.
8676 This function checks for valid syntax and produces the resulting
8677 Lisp float number too. Rework it so that string-to-number
8678 no longer mishandles examples like "1.0e+". Use strtoumax,
8679 so that overflow for non-base-10 numbers is reported only when
8680 there's no portable and simple way to convert to floating point.
8682 * textprop.c (set_text_properties_1): Rewrite for clarity,
8683 and to avoid GCC warning about integer overflow.
8685 * intervals.h (struct interval): Use EMACS_INT for members
8686 where EMACS_UINT might cause problems. See
8687 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
8688 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
8689 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
8691 (offset_intervals): Tell GCC not to worry about length overflow
8692 when negating a negative length.
8694 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
8695 (overrun_check_free): Likewise.
8697 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
8698 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
8701 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
8702 (gnutls_make_error): Rename local to avoid shadowing.
8703 (gnutls_emacs_global_deinit): ifdef out; not used.
8704 (Fgnutls_boot): Use const for pointer to readonly storage.
8705 Comment out unused local. Fix pointer signedness problems.
8707 * lread.c (openp): Don't stuff size_t into an 'int'.
8708 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
8709 about possible signed overflow.
8711 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
8712 (GDK_KEY_g): Don't define if already defined.
8713 (xg_prepare_tooltip): Avoid pointer signedness problem.
8714 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
8716 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
8717 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
8719 * xfns.c (Fx_window_property): Simplify a bit,
8720 to make a bit faster and to avoid GCC 4.6.0 warning.
8721 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
8723 * fns.c (internal_equal): Don't assume size_t fits in int.
8725 * alloc.c (compact_small_strings): Tighten assertion a little.
8727 Replace pEd with more-general pI, and fix some printf arg casts.
8728 * lisp.h (pI): New macro, generalizing old pEd macro to other
8729 conversion specifiers. For example, use "...%"pI"d..." rather
8730 than "...%"pEd"...".
8731 (pEd): Remove. All uses replaced with similar uses of pI.
8732 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
8733 * alloc.c (check_pure_size): Don't overflow by converting size to int.
8734 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
8735 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
8736 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
8737 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
8738 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
8740 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
8741 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
8742 * print.c (safe_debug_print, print_object): Likewise.
8743 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
8745 Use pI instead of if-then-else-abort. Use %p to avoid casts,
8746 avoiding the 0 flag, which is not portable.
8747 * process.c (Fmake_network_process): Use pI to avoid cast.
8748 * region-cache.c (pp_cache): Likewise.
8749 * xdisp.c (decode_mode_spec): Likewise.
8750 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
8751 behavior on 64-bit hosts with printf arg.
8752 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
8753 (x_stop_queuing_selection_requests): Likewise.
8754 (x_get_window_property): Don't truncate byte count to an 'int'
8757 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
8758 here, since it parses constructs like leading '-' and spaces,
8759 which are not wanted; and it overflows with large numbers.
8760 Instead, simply match F[0-9]+, which is what is wanted anyway.
8762 * alloc.c: Remove unportable assumptions about struct layout.
8763 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
8764 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
8765 (allocate_vectorlike, make_pure_vector): Use the new macros,
8766 plus offsetof, to remove unportable assumptions about struct layout.
8767 These assumptions hold on all porting targets that I know of, but
8768 they are not guaranteed, they're easy to remove, and removing them
8769 makes further changes easier.
8771 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
8772 This doesn't fix a bug but makes the code clearer.
8773 (string_overrun_cookie): Now const. Use initializers that
8774 don't formally overflow signed char, to avoid warnings.
8775 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
8776 can cause Emacs to crash when string overrun checking is enabled.
8777 (allocate_buffer): Don't assume sizeof (struct buffer) is a
8778 multiple of sizeof (EMACS_INT); it need not be, if
8779 alignof(EMACS_INT) < sizeof (EMACS_INT).
8780 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
8782 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
8784 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
8786 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
8788 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
8789 supposed to be handshaking. (Bug#8556)
8790 Reported by Paul Eggert <eggert@cs.ucla.edu>.
8792 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
8794 * lisp.h (Qdebug): List symbol.
8795 * eval.c (Qdebug): Restore global linkage.
8796 * keyboard.c (debug-on-event): New variable.
8797 (handle_user_signal): Break into debugger when debug-on-event
8798 matches the current signal symbol.
8800 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
8802 * alloc.c (check_sblock, check_string_bytes)
8803 (check_string_free_list): Convert to standard C.
8805 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
8807 * w32.c (emacs_gnutls_push): Fix typo.
8809 2011-04-25 Eli Zaretskii <eliz@gnu.org>
8811 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
8812 "cast to pointer from integer of different size".
8814 Improve doprnt and its use in verror. (Bug#8545)
8815 * doprnt.c (doprnt): Document the set of format control sequences
8816 supported by the function. Use SAFE_ALLOCA instead of always
8819 * eval.c (verror): Don't limit the buffer size at size_max-1, that
8820 is one byte too soon. Don't use xrealloc; instead xfree and
8823 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
8825 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
8828 * gnutls.c: Renamed global_initialized to
8829 gnutls_global_initialized. Added internals for the
8830 :verify-hostname-error, :verify-error, and :verify-flags
8831 parameters of `gnutls-boot' and documented those parameters in the
8832 docstring. Start callback support.
8833 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
8834 unless a fatal error occurred. Call gnutls_alert_send_appropriate
8835 on error. Return error code.
8836 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
8837 (emacs_gnutls_read): Likewise.
8838 (Fgnutls_boot): Return handshake error code.
8839 (emacs_gnutls_handle_error): New function.
8840 (wsaerror_to_errno): Likewise.
8842 * w32.h (emacs_gnutls_pull): Add prototype.
8843 (emacs_gnutls_push): Likewise.
8845 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
8846 (emacs_gnutls_push): Likewise.
8848 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
8850 * process.c (wait_reading_process_output): Check if GnuTLS
8851 buffered some data internally if no FDs are set for TLS
8854 * makefile.w32-in (OBJ2): Add gnutls.$(O).
8855 (LIBS): Link to USER_LIBS.
8856 ($(BLD)/gnutls.$(0)): New target.
8858 2011-04-24 Eli Zaretskii <eliz@gnu.org>
8860 * xdisp.c (handle_single_display_spec): Rename the
8861 display_replaced_before_p argument into display_replaced_p, to
8862 make it consistent with the commentary. Fix typos in the
8865 * textprop.c (syms_of_textprop): Remove dead code.
8866 (copy_text_properties): Delete obsolete commentary about an
8867 interface that was deleted long ago. Fix typos in the description
8870 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
8871 to changes in oldXMenu/XMenu.h from 2011-04-16.
8872 <menu_help_message, prev_menu_help_message>: Constify.
8873 (IT_menu_make_room): menu->help_text is now `const char **';
8876 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
8877 to changes in oldXMenu/XMenu.h from 2011-04-16.
8878 (struct XMenu): Declare `help_text' `const char **'.
8880 * xfaces.c <Qunspecified>: Make extern again.
8882 * syntax.c: Include sys/types.h before including regex.h, as
8885 * doc.c (get_doc_string): Improve the format passed to `error'.
8887 * doprnt.c (doprnt): Improve commentary.
8889 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
8891 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
8894 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
8895 changes in globals.h immediately force recompilation.
8896 (TAGS): Depend on $(CURDIR)/m/intel386.h and
8897 $(CURDIR)/s/ms-w32.h.
8898 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
8900 * character.c (Fchar_direction): Function deleted.
8901 (syms_of_character): Don't defsubr it.
8902 <char-direction-table>: Deleted.
8904 2011-04-23 Eli Zaretskii <eliz@gnu.org>
8906 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
8907 * doprnt.c: Include limits.h.
8908 (SIZE_MAX): New macro.
8909 (doprnt): Return a size_t value. 2nd arg is now size_t.
8910 Many local variables are now size_t instead of int or unsigned.
8911 Improve overflow protection. Support `l' modifier for integer
8912 conversions. Support %l conversion. Don't assume an EMACS_INT
8913 argument for integer conversions and for %c.
8915 * lisp.h (doprnt): Restore prototype.
8917 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
8920 * Makefile.in (base_obj): Add back doprnt.o.
8922 * deps.mk (doprnt.o): Add back prerequisites.
8923 (callint.o): Depend on character.h.
8925 * eval.c (internal_lisp_condition_case): Include the handler
8926 representation in the error message.
8927 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
8928 when breaking from the loop.
8930 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
8932 * callint.c (Fcall_interactively): When displaying error message
8933 about invalid control letter, pass the character's codepoint, not
8934 a pointer to its multibyte form. Improve display of the character
8935 in octal and display also its hex code.
8937 * character.c (char_string): Use %x to display the (unsigned)
8938 codepoint of an invalid character, to avoid displaying a bogus
8941 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
8942 `error', not SYMBOL_NAME itself.
8944 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
8945 character arguments to `error'.
8947 * charset.c (check_iso_charset_parameter): Fix incorrect argument
8948 to `error' in error message about FINAL_CHAR argument. Make sure
8949 FINAL_CHAR is a character, and use %c when it is passed as
8950 argument to `error'.
8952 2011-04-23 Eli Zaretskii <eliz@gnu.org>
8954 * s/ms-w32.h (localtime): Redirect to sys_localtime.
8956 * w32.c: Include <time.h>.
8957 (sys_localtime): New function.
8959 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
8961 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
8963 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
8965 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
8967 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
8970 2011-04-19 Eli Zaretskii <eliz@gnu.org>
8972 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
8973 gl_state.e_property when gl_state.object is Qt.
8975 * insdel.c (make_gap_larger): Remove limitation of buffer size
8978 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
8980 * xdisp.c (lookup_glyphless_char_display)
8981 (produce_glyphless_glyph): Handle cons cell entry in
8982 glyphless-char-display.
8983 (Vglyphless_char_display): Document it.
8985 * term.c (produce_glyphless_glyph): Handle cons cell entry in
8986 glyphless-char-display.
8988 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
8990 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
8992 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
8994 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
8995 definition for no-X builds.
8997 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
8999 Static checks with GCC 4.6.0 and non-default toolkits.
9001 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
9003 * process.c (keyboard_bit_set): Define only if SIGIO.
9004 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
9005 (send_process): Repair possible setjmp clobbering.
9007 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
9009 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
9011 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
9013 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
9014 Define only if needed.
9016 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
9017 by pacifying GCC about it. Maybe it's time to retire it?
9018 * xfaces.c (USG, __TIMEVAL__): Likewise.
9020 * dispextern.h (struct redisplay_interface): Rename param
9022 * termhooks.h (struct terminal): Likewise.
9023 * xterm.c (xembed_send_message): Likewise.
9025 * insdel.c (make_gap_smaller): Define only if
9026 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
9028 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
9031 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
9032 so that we aren't warned about unused symbols.
9034 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
9036 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
9038 * xfns.c (x_real_positions): Mark locals as initialized.
9040 * xmenu.c (xmenu_show): Don't use uninitialized vars.
9042 * xterm.c: Fix problems found by static analysis with other toolkits.
9043 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
9044 (x_dispatch_event): Declare static if USE_GTK, and
9045 define if USE_GTK || USE_X_TOOLKIT.
9046 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
9047 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
9048 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
9049 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
9051 * xmenu.c (menu_help_callback): Pointer type fixes.
9052 Use const pointers when pointing at readonly data. Avoid pointer
9054 (FALSE): Remove unused macro.
9055 (update_frame_menubar): Remove unused decl.
9057 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
9059 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
9060 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
9061 (single_menu_item): Rename local to avoid shadowing.
9063 * keyboard.c (make_lispy_event): Remove unused local var.
9065 * frame.c, frame.h (x_get_resource_string): Bring this back, but
9066 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
9068 * bitmaps: Change bitmaps from unsigned char back to the X11
9069 compatible char. Avoid the old compiler warnings about
9070 out-of-range initializers by using, for example, '\xab' rather
9073 * xgselect.c (xgselect_initialize): Check vs interface
9074 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
9076 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
9078 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
9079 to read-only memory.
9081 * fns.c (vector): Remove; this old hack is no longer needed.
9083 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
9085 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
9087 * xrdb.c (x_load_resources): Omit unused local.
9089 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
9090 (x_window): Rename locals to avoid shadowing.
9091 (USG): Use the kludged USG macro, to pacify gcc.
9093 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
9094 (x_term_init): Remove local to avoid shadowing.
9096 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
9098 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
9099 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
9101 2011-04-16 Eli Zaretskii <eliz@gnu.org>
9103 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
9105 Fix regex.c, syntax.c and friends for buffers > 2GB.
9106 * syntax.h (struct gl_state_s): Declare character position members
9109 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
9111 * textprop.c (verify_interval_modification, interval_of):
9112 Declare arguments EMACS_INT.
9114 * intervals.c (adjust_intervals_for_insertion): Declare arguments
9117 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
9119 * indent.c (Fvertical_motion): Local variable it_start is now
9122 * regex.c (re_match, re_match_2, re_match_2_internal)
9123 (bcmp_translate, regcomp, regexec, print_double_string)
9124 (group_in_compile_stack, re_search, re_search_2, regex_compile)
9125 (re_compile_pattern, re_exec): Declare arguments and local
9126 variables `size_t' and `ssize_t' and return values `regoff_t', as
9128 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
9129 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
9130 <compile_stack_type>: `size' and `avail' are now `size_t'.
9132 * regex.h <regoff_t>: Use ssize_t, not int.
9133 (re_search, re_search_2, re_match, re_match_2): Arguments that
9134 specify buffer/string position and length are now ssize_t and
9135 size_t. Return type is regoff_t.
9137 2011-04-16 Ben Key <bkey76@gmail.com>
9139 * nsfont.m: Fixed bugs in ns_get_family and
9140 ns_descriptor_to_entity that were caused by using free to
9141 deallocate memory blocks that were allocated by xmalloc (via
9142 xstrdup). This caused Emacs to crash when compiled with
9143 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
9144 --enable-checking=xmallocoverrun). xfree is now used to
9145 deallocate these memory blocks.
9147 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
9149 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
9151 emacs_write: Accept and return EMACS_INT for sizes.
9152 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
9154 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
9155 Accept and return EMACS_INT.
9156 (emacs_gnutls_write): Return the number of bytes written on
9158 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
9159 (emacs_read, emacs_write): Remove check for negative size, as the
9160 Emacs source code has been audited now.
9161 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
9162 (emacs_read, emacs_write): Use it.
9163 * process.c (send_process): Adjust to the new signatures of
9164 emacs_write and emacs_gnutls_write. Do not attempt to store
9165 a byte offset into an 'int'; it might overflow.
9166 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
9168 * sound.c: Don't assume sizes fit in 'int'.
9169 (struct sound_device.period_size, alsa_period_size):
9170 Return EMACS_INT, not int.
9171 (struct sound_device.write, vox_write, alsa_write):
9172 Accept EMACS_INT, not int.
9173 (wav_play, au_play): Use EMACS_INT to store sizes and to
9174 record read return values.
9176 2011-04-15 Ben Key <bkey76@gmail.com>
9178 * keyboard.c (Qundefined): Don't declare static since it is used
9180 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
9181 static since they are used in nsfont.m.
9183 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
9185 * process.c (Qprocessp): Don't declare static.
9186 * lisp.h (Qprocessp): Declare again.
9188 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
9190 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
9192 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
9194 Improve C-level modularity by making more things 'static'.
9196 Don't publish debugger-only interfaces to other modules.
9197 * lisp.h (safe_debug_print, debug_output_compilation_hack):
9198 (verify_bytepos, count_markers): Move decls to the only modules
9200 * region-cache.h (pp_cache): Likewise.
9201 * window.h (check_all_windows): Likewise.
9202 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
9204 * sysdep.c (croak): Now static, if
9205 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
9206 * syssignal.h (croak): Declare only if not static.
9208 * alloc.c (refill_memory_reserve): Now static if
9209 !defined REL_ALLOC || defined SYSTEM_MALLOC.
9210 * lisp.h (refill_memory_reserve): Declare only if not static.
9212 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
9213 Define only if USE_LUCID.
9215 * xrdb.c (x_customization_string, x_rm_string): Now static.
9217 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
9218 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
9220 * xdisp.c (draw_row_with_mouse_face): Now static.
9221 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
9223 * window.h (check_all_windows): Mark externally visible.
9225 * window.c (window_deletion_count): Now static.
9227 * undo.c: Make symbols static if they're not exported.
9228 (last_undo_buffer, last_boundary_position, pending_boundary):
9231 * textprop.c (interval_insert_behind_hooks): Now static.
9232 (interval_insert_in_front_hooks): Likewise.
9234 * term.c: Make symbols static if they're not exported.
9235 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
9236 (max_frame_lines, tty_set_terminal_modes):
9237 (tty_reset_terminal_modes, tty_turn_off_highlight):
9238 (get_tty_terminal): Now static.
9239 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
9240 * termhooks.h (term_mouse_moveto): Do not declare if
9242 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
9243 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
9245 * sysdep.c: Make symbols static if they're not exported.
9246 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
9248 (sigprocmask_set, full_mask): Remove; unused.
9249 (wait_debugging): Mark as visible.
9250 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
9251 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
9253 * syntax.c (syntax_temp): Define only if !__GNUC__.
9255 * sound.c (current_sound_device, current_sound): Now static.
9257 * search.c (searchbufs, searchbuf_head): Now static.
9259 * scroll.c (scroll_cost): Remove; unused.
9260 * dispextern.h (scroll_cost): Remove decl.
9262 * region-cache.h (pp_cache): Mark as externally visible.
9264 * process.c: Make symbols static if they're not exported.
9265 (process_tick, update_tick, create_process, chan_process):
9266 (Vprocess_alist, proc_buffered_char, datagram_access):
9267 (fd_callback_data, send_process_frame, process_sent_to): Now static.
9268 (deactivate_process): Mark defn as static, as well as decl.
9269 * lisp.h (create_process): Remove decl.
9270 * process.h (chan_process, Vprocess_alist): Remove decls.
9272 * print.c: Make symbols static if they're not exported.
9273 (print_depth, new_backquote_output, being_printed, print_buffer):
9274 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
9275 (print_interval, print_number_index, initial_stderr_stream):
9277 * lisp.h (Fprinc): Remove decl.
9278 (debug_output_compilation_hack): Mark as externally visible.
9280 * sysdep.c (croak): Move decl from here to syssignal.h.
9281 * syssignal.h (croak): Put it here, so the API can be checked when
9282 'croak' is called from dissociate_if_controlling_tty.
9284 * minibuf.c: Make symbols static if they're not exported.
9285 (minibuf_save_list, choose_minibuf_frame): Now static.
9286 * lisp.h (choose_minibuf_frame): Remove decl.
9288 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
9290 * lread.c: Make symbols static if they're not exported.
9291 (read_objects, initial_obarray, oblookup_last_bucket_number):
9293 (make_symbol): Remove; unused.
9294 * lisp.h (initial_obarray, make_symbol): Remove decls.
9296 * keyboard.c: Make symbols static if they're not exported.
9297 (single_kboard, recent_keys_index, total_keys, recent_keys):
9298 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
9299 (this_single_command_key_start, echoing, last_auto_save):
9300 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
9301 (command_loop, echo_now, keyboard_init_hook, help_char_p):
9302 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
9303 (Vlispy_mouse_stem, double_click_count):
9305 (force_auto_save_soon): Define only if SIGDANGER.
9306 (ignore_mouse_drag_p): Now static if
9307 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
9308 (print_help): Remove; unused.
9309 (stop_character, last_timer_event): Mark as externally visible.
9310 * keyboard.h (ignore_mouse_drag_p): Declare only if
9311 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
9312 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
9313 * lisp.h (echoing): Remove decl.
9314 (force_auto_save_soon): Declare only if SIGDANGER.
9315 * xdisp.c (redisplay_window): Simplify code, to make it more
9316 obvious that ignore_mouse_drag_p is not accessed if !defined
9317 USE_GTK && !defined HAVE_NS.
9319 * intervals.c: Make symbols static if they're not exported.
9320 (merge_properties_sticky, merge_interval_right, delete_interval):
9322 * intervals.h (merge_interval_right, delete_interval): Remove decls.
9324 * insdel.c: Make symbols static if they're not exported.
9325 However, leave prepare_to_modify_buffer alone. It's never
9326 called from outside this function, but that appears to be a bug.
9327 (combine_after_change_list, combine_after_change_buffer):
9328 (adjust_after_replace, signal_before_change): Now static.
9329 (adjust_after_replace_noundo): Remove; unused.
9330 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
9331 (signal_before_change): Remove decls.
9333 * indent.c (val_compute_motion, val_vmotion): Now static.
9335 * image.c: Make symbols static if they're not exported.
9336 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
9338 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
9339 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
9341 * fringe.c (standard_bitmaps): Now static.
9342 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
9344 * frame.c: Make symbols static if they're not exported.
9345 (x_report_frame_params, make_terminal_frame): Now static.
9346 (get_frame_param): Now static, unless HAVE_NS.
9347 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
9348 (x_get_resource_string): Remove; not used.
9349 * frame.h (make_terminal_frame, x_report_frame_params):
9350 (x_get_resource_string); Remove decls.
9351 (x_fullscreen_adjust): Declare only if WINDOWSNT.
9352 * lisp.h (get_frame_param): Declare only if HAVE_NS.
9354 * font.c, fontset.c: Make symbols static if they're not exported.
9355 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
9356 (FACE_SUITABLE_FOR_CHAR_P): Use it.
9357 * font.c (font_close_object): Now static.
9358 * font.h (font_close_object): Remove.
9359 * fontset.c (FONTSET_OBJLIST): Remove.
9360 (free_realized_fontset) #if-0 the body, which does nothing.
9361 (face_suitable_for_char_p): #if-0, as it's never called.
9362 * fontset.h (face_suitable_for_char_p): Remove decl.
9363 * xfaces.c (face_at_string_position):
9364 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
9365 since 0 is always ASCII.
9367 * fns.c (weak_hash_tables): Now static.
9369 * fileio.c: Make symbols static if they're not exported.
9370 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
9371 (Vwrite_region_annotation_buffers): Now static.
9373 * eval.c: Make symbols static if they're not exported.
9374 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
9375 * lisp.h (backtrace_list): Remove decl.
9377 * emacs.c: Make symbols static if they're not exported.
9378 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
9379 (fatal_error_code, fatal_error_signal_hook, standard_args):
9381 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
9382 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
9383 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
9384 * lisp.h (fatal_error_signal_hook): Remove decl.
9385 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
9387 * editfns.c: Move a (normally-unused) function to its only use.
9388 * editfns.c, lisp.h (get_operating_system_release): Remove.
9389 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
9390 worth the hassle of breaking this out.
9392 * xterm.c: Make symbols static if they're not exported.
9393 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
9394 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
9395 (x_destroy_window, x_delete_display):
9397 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
9398 (x_mouse_leave): Remove; unused.
9399 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
9400 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
9401 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
9403 (x_mouse_leave): Declare only if WINDOWSNT.
9404 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
9405 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
9408 * ftxfont.c: Make symbols static if they're not exported.
9409 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
9411 * font.h (ftxfont_driver): Likewise.
9413 * xfns.c: Make symbols static if they're not exported.
9414 (x_last_font_name, x_display_info_for_name):
9415 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
9416 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
9417 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
9418 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
9419 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
9420 (last_show_tip_args): Now static.
9421 (xic_defaut_fontset, xic_create_fontsetname): Define only if
9422 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
9423 (x_screen_planes): Remove; unused.
9424 * dispextern.h (x_screen_planes): Remove decl.
9426 * dispnew.c: Make symbols static if they're not exported.
9427 * dispextern.h (redraw_garbaged_frames, scrolling):
9428 (increment_row_positions): Remove.
9429 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
9430 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
9432 (redraw_garbaged_frames): Remove; unused.
9434 * xfaces.c: Make symbols static if they're not exported.
9435 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
9437 * xterm.h (defined_color): Remove decls.
9438 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
9439 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
9440 (menu_face_changed_default, defined_color, free_realized_face):
9441 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
9442 (ascii_face_of_lisp_face): Remove; unused.
9444 * xdisp.c: Make symbols static if they're not exported.
9445 * dispextern.h (scratch_glyph_row, window_box_edges):
9446 (glyph_to_pixel_coords, set_cursor_from_row):
9447 (get_next_display_element, set_iterator_to_next):
9448 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
9449 (show_mouse_face): Remove decls
9450 * frame.h (message_buf_print): Likewise.
9451 * lisp.h (pop_message, set_message, check_point_in_composition):
9453 * xterm.h (set_vertical_scroll_bar): Likewise.
9454 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
9455 (message_buf_print, scratch_glyph_row, displayed_buffer):
9456 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
9457 (get_next_display_element, show_mouse_face, window_box_edges):
9458 (frame_to_window_pixel_xy, check_point_in_composition):
9459 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
9460 (glyph_to_pixel_coords): Remove; unused.
9462 * dired.c (file_name_completion): Now static.
9464 * dbusbind.c (xd_in_read_queued_messages): Now static.
9466 * lisp.h (circular_list_error, FOREACH): Remove; unused.
9467 * data.c (circular_list_error): Remove.
9469 * commands.h (last_point_position, last_point_position_buffer):
9470 (last_point_position_window): Remove decls.
9471 * keyboard.c: Make these variables static.
9473 * coding.h (coding, code_convert_region, encode_coding_gap):
9475 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
9476 (iso_code_class, detect_coding, code_convert_region): Now static.
9477 (encode_coding_gap): Remove; unused.
9479 * chartab.c (chartab_chars, chartab_bits): Now static.
9481 * charset.h (charset_iso_8859_1): Remove decl.
9482 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
9485 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
9486 * ccl.c (Vccl_program_table): Now static.
9487 (check_ccl_update): Remove; unused.
9489 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
9490 * category.h: ... from here.
9491 * category.c (check_category_table, set_category_set): Now static.
9493 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
9494 * lisp.h: Remove these decls.
9496 * buffer.c (buffer_count): Remove unused var.
9498 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
9499 so that it's not optimized away.
9500 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
9501 * dispextern.h (bidi_dump_cached_states): Remove, since it's
9502 exported only to the debugger.
9504 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
9505 * atimer.h (run_all_atimers): Remove; not exported.
9507 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
9508 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
9509 was inaccessible from Lisp.
9510 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
9511 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
9513 alloc.c: Import and export fewer symbols, and remove unused items.
9514 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
9516 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
9517 it's not optimized away by whole-program optimization.
9518 (message_enable_multibyte, free_misc): Remove.
9519 (catchlist, handlerlist, mark_backtrace):
9520 Declare only if BYTE_MARK_STACK.
9521 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
9522 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
9523 (message_enable_multibyte): Remove decl.
9524 (free_misc, interval_free_list, float_block, float_block_index):
9525 (n_float_blocks, float_free_list, cons_block, cons_block_index):
9526 (cons_free_list, last_marked_index):
9528 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
9529 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
9530 (mark_backtrace): Define only if BYTE_MARK_STACK.
9531 * xdisp.c (message_enable_multibyte): Now static.
9533 Declare Lisp_Object Q* variables to be 'static' if not exported.
9534 This makes it easier for human readers (and static analyzers)
9535 to see whether these variables are used from other modules.
9536 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
9537 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
9538 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
9539 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
9540 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
9541 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
9542 * xmenu.c, xselect.c:
9543 Declare Q* vars static if they are not used in other modules.
9544 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
9545 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
9546 Remove decls of unexported vars.
9547 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
9549 * lisp.h (DEFINE_FUNC): Make sname 'static'.
9551 Make Emacs functions such as Fatom 'static' by default.
9552 This makes it easier for human readers (and static analyzers)
9553 to see whether these functions can be called from other modules.
9554 DEFUN now defines a static function. To make the function external
9555 so that it can be used in other C modules, use the new macro DEFUE.
9556 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
9557 (Finit_image_library):
9558 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
9559 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
9560 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
9561 Remove decls, since these functions are now static.
9562 (Funintern, Fget_internal_run_time): New decls, since these functions
9563 were already external.
9565 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
9566 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
9567 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
9568 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
9569 * keyboard.c, keymap.c, lread.c:
9570 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
9571 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
9572 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
9573 Mark functions with DEFUE instead of DEFUN,
9574 if they are used in other modules.
9575 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
9576 decls for now-static functions.
9577 * buffer.h (Fdelete_overlay): Remove decl.
9578 * callproc.c (Fgetenv_internal): Mark as internal.
9579 * composite.c (Fremove_list_of_text_properties): Remove decl.
9580 (Fcomposition_get_gstring): New forward static decl.
9581 * composite.h (Fcomposite_get_gstring): Remove decl.
9582 * dired.c (Ffile_attributes): New forward static decl.
9583 * doc.c (Fdocumntation_property): New forward static decl.
9584 * eval.c (Ffetch_bytecode): New forward static decl.
9585 (Funintern): Remove extern decl; now in .h file where it belongs.
9586 * fileio.c (Fmake_symbolic_link): New forward static decl.
9587 * image.c (Finit_image_library): New forward static decl.
9588 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
9589 * intervals.h (Fprevious_property_change):
9590 (Fremove_list_of_text_properties): Remove decls.
9591 * keyboard.c (Fthis_command_keys): Remove decl.
9592 (Fcommand_execute): New forward static decl.
9593 * keymap.c (Flookup_key): New forward static decl.
9594 (Fcopy_keymap): Now static.
9595 * keymap.h (Flookup_key): Remove decl.
9596 * process.c (Fget_process): New forward static decl.
9597 (Fprocess_datagram_address): Mark as internal.
9598 * syntax.c (Fsyntax_table_p): New forward static decl.
9599 (skip_chars): Remove duplicate decl.
9600 * textprop.c (Fprevious_property_change): New forward static decl.
9601 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
9603 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
9604 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
9606 * editfns.c (Fformat): Remove unreachable code.
9608 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
9610 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
9613 2011-04-13 Eli Zaretskii <eliz@gnu.org>
9615 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
9616 when at ZV. (Bug#8487)
9618 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
9620 * charset.c (Fclear_charset_maps): Use xfree instead of free.
9622 * keyboard.c (parse_tool_bar_item): Likewise.
9623 * sound.c (sound_cleanup, alsa_close): Likewise.
9624 * termcap.c (tgetent): Likewise.
9625 * xfns.c (x_default_font_parameter): Likewise.
9626 * xsettings.c (read_and_apply_settings): Likewise.
9628 * alloc.c (overrun_check_malloc, overrun_check_realloc)
9629 (overrun_check_free): Protoize.
9631 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
9633 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
9634 since callers should never pass a negative size.
9635 Change the signature to match that of plain 'read' and 'write'; see
9636 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
9637 * lisp.h: Update prototypes of emacs_write and emacs_read.
9639 2011-04-11 Eli Zaretskii <eliz@gnu.org>
9641 * xdisp.c (redisplay_window): Don't try to determine the character
9642 position of the scroll margin if the window start point w->startp
9643 is outside the buffer's accessible region. (Bug#8468)
9645 2011-04-10 Eli Zaretskii <eliz@gnu.org>
9647 Fix write-region and its subroutines for buffers > 2GB.
9648 * fileio.c (a_write, e_write): Modify declaration of arguments and
9649 local variables to support buffers larger than 2GB.
9650 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
9652 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
9653 argument, local variables, and return value.
9655 * lisp.h: Update prototypes of emacs_write and emacs_read.
9657 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
9659 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
9661 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
9663 Fix more problems found by GCC 4.6.0's static checks.
9665 * xdisp.c (vmessage): Use a better test for character truncation.
9667 * charset.c (load_charset_map): <, not <=, for optimization,
9668 and to avoid potential problems with integer overflow.
9669 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
9670 * casetab.c (set_identity, shuffle): Likewise.
9671 * editfns.c (Fformat): Likewise.
9672 * syntax.c (skip_chars): Likewise.
9674 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
9675 This also lets GCC 4.6.0 generate slightly better loop code.
9677 * callint.c (Fcall_interactively): <, not <=, for optimization.
9678 (Fcall_interactively): Count the number of arguments produced,
9679 not the number of arguments given. This is simpler and lets GCC
9680 4.6.0 generate slightly better code.
9682 * ftfont.c: Distingish more carefully between FcChar8 and char.
9683 The previous code passed unsigned char * to a functions like
9684 strlen and xstrcasecmp that expect char *, which does not
9685 conform to the C standard.
9686 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
9687 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
9688 char * when the C standard requires it.
9690 * keyboard.c (read_char): Remove unused var.
9692 * eval.c: Port to Windows vsnprintf (Bug#8435).
9694 (SIZE_MAX): Define if the headers do not.
9695 (verror): Do not give up if vsnprintf returns a negative count.
9696 Instead, grow the buffer. This ports to Windows vsnprintf, which
9697 does not conform to C99. Problem reported by Eli Zaretskii.
9698 Also, simplify the allocation scheme, by avoiding the need for
9699 calling realloc, and removing the ALLOCATED variable.
9701 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
9703 Remove invocations of doprnt, as Emacs now uses vsnprintf.
9704 But keep the doprint source code for now, as we might revamp it
9705 and use it again (Bug#8435).
9706 * lisp.h (doprnt): Remove.
9707 * Makefile.in (base_obj): Remove doprnt.o.
9708 * deps.mk (doprnt.o): Remove.
9710 error: Print 32- and 64-bit integers portably (Bug#8435).
9711 Without this change, on typical 64-bit hosts error ("...%d...", N)
9712 was used to print both 32- and 64-bit integers N, which relied on
9714 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
9715 * lisp.h (error, verror): Mark as printf-like functions.
9716 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
9717 Report overflow in size calculations when allocating printf buffer.
9718 Do not truncate output string at its first null byte.
9719 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
9720 Truncate the output at a character boundary, since vsnprintf does not
9722 * charset.c (check_iso_charset_parameter): Convert internal
9723 character to string before calling 'error', since %c now has the
9725 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
9726 overflow when computing char to be passed to 'error'. Do not
9727 pass Lisp_Object to 'error'; pass the integer instead.
9728 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
9729 formatted with plain %d.
9731 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
9733 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
9735 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
9737 * xterm.c (x_catch_errors): Remove duplicate declaration.
9739 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
9741 * xdisp.c, lisp.h (message_nolog): Remove; unused.
9743 2011-04-10 Jim Meyering <meyering@redhat.com>
9745 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
9746 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
9747 return ssize_t not "int", and use size_t as the buffer length.
9748 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
9749 * gnutls.h: Update declarations.
9750 * process.c (read_process_output): Use ssize_t, to match.
9751 (send_process): Likewise.
9753 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
9755 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
9757 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
9759 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
9760 Use unsigned char, to match FcChar8 type definition.
9762 * xterm.c (handle_one_xevent):
9763 * xmenu.c (create_and_show_popup_menu):
9764 * xselect.c (x_decline_selection_request)
9765 (x_reply_selection_request): Avoid type-punned deref of X events.
9767 2011-04-09 Eli Zaretskii <eliz@gnu.org>
9769 Fix some uses of `int' instead of EMACS_INT.
9770 * search.c (string_match_1, fast_string_match)
9771 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
9772 (scan_buffer, find_next_newline_no_quit)
9773 (find_before_next_newline, search_command, Freplace_match)
9774 (Fmatch_data): Make some `int' variables be EMACS_INT.
9776 * xdisp.c (display_count_lines): 3rd argument and return value now
9777 EMACS_INT. All callers changed.
9778 (pint2hrstr): Last argument is now EMACS_INT.
9780 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
9781 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
9782 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
9783 (decode_coding_utf_16, decode_coding_emacs_mule)
9784 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
9785 (decode_coding_ccl, decode_coding_charset)
9786 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
9787 (decode_coding_iso_2022, decode_coding_emacs_mule)
9788 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
9789 <char_offset, last_offset>: Declare EMACS_INT.
9790 (encode_coding_utf_8, encode_coding_utf_16)
9791 (encode_coding_emacs_mule, encode_invocation_designation)
9792 (encode_designation_at_bol, encode_coding_iso_2022)
9793 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
9794 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
9796 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
9797 (encode_invocation_designation): Last argument P_NCHARS is now
9799 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
9800 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
9802 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
9805 * ccl.c (Fccl_execute_on_string): Declare some variables
9808 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
9810 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
9812 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
9814 * process.c (Fformat_network_address): Doc fix.
9816 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
9818 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
9820 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
9822 * keyboard.c (read_char): Call Lisp function help-form-show,
9823 instead of using internal_with_output_to_temp_buffer.
9824 (Qhelp_form_show): New var.
9825 (syms_of_keyboard): Use DEFSYM macro.
9827 * print.c (internal_with_output_to_temp_buffer): Function deleted.
9829 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
9831 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
9833 * process.c (Flist_processes): Remove to Lisp.
9834 (list_processes_1): Delete.
9836 2011-04-06 Eli Zaretskii <eliz@gnu.org>
9838 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
9840 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
9842 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
9844 Fix more problems found by GCC 4.6.0's static checks.
9846 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
9848 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
9850 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
9852 * xdisp.c (vmessage): Mark as a printf-like function.
9854 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
9856 * sound.c (sound_warning): Don't crash if arg contains a printf format.
9858 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
9859 printf-like functions.
9860 (tiff_load): Add casts to remove these marks before passing them
9861 to system-supplied API.
9863 * eval.c (Fsignal): Remove excess argument to 'fatal'.
9865 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
9866 This avoids several warnings with gcc -Wstrict-overflow.
9867 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
9868 directly, rather than having caller test rule sign. This avoids
9869 some unnecessary tests.
9870 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
9871 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
9872 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
9874 * xfont.c (xfont_text_extents): Remove var that was set but not used.
9875 (xfont_open): Avoid unnecessary tests.
9877 * composite.c (composition_gstring_put_cache): Use unsigned integer.
9879 * composite.h, composite.c (composition_gstring_put_cache):
9880 Use EMACS_INT, not int, for length.
9882 * composite.h (COMPOSITION_DECODE_REFS): New macro,
9883 breaking out part of COMPOSITION_DECODE_RULE.
9884 (COMPOSITION_DECODE_RULE): Use it.
9885 * composite.c (get_composition_id): Remove unused local vars,
9886 by using the new macro.
9888 * textprop.c (set_text_properties_1): Change while to do-while,
9889 since the condition is always true at first.
9891 * intervals.c (graft_intervals_into_buffer): Mark var as used.
9892 (interval_deletion_adjustment): Return unsigned value.
9895 * process.c (list_processes_1, create_pty, read_process_output):
9896 (exec_sentinel): Remove vars that were set but not used.
9897 (create_pty): Remove unnecessary "volatile"s.
9898 (Fnetwork_interface_info): Avoid possibility of int overflow.
9899 (read_process_output): Do adaptive read buffering even if carryover.
9900 (read_process_output): Simplify nbytes computation if buffered.
9902 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
9904 * syntax.c (scan_words): Remove var that was set but not used.
9905 (update_syntax_table): Use unsigned instead of int.
9907 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
9908 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
9909 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
9911 * print.c (print_error_message): Avoid int overflow.
9913 * font.c (font_list_entities): Redo for clarity,
9914 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
9916 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
9917 (font_score): Avoid potential overflow in diff calculation.
9919 * fns.c (substring_both): Remove var that is set but not used.
9920 (sxhash): Redo loop for clarity and to avoid wraparound warning.
9922 * eval.c (funcall_lambda): Rename local to avoid shadowing.
9924 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
9925 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
9926 can always succeed if overflow has undefined behavior.
9928 * search.c (boyer_moore, wordify): Remove vars set but not used.
9929 (wordify): Omit three unnecessary tests.
9931 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
9932 All callers changed. This avoids the need for an unused var.
9934 * casefiddle.c (casify_region): Remove var that is set but not used.
9936 * dired.c (file_name_completion): Remove var that is set but not used.
9938 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
9940 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
9941 (Finsert_file_contents): Remove unnecessary code checking fd.
9943 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
9944 Check for integer overflow on size calculations.
9946 * buffer.c (Fprevious_overlay_change): Remove var that is set
9949 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
9950 Remove vars that are set but not used.
9951 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
9952 (timer_check_2): Mark vars as initialized.
9954 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
9956 * image.c (lookup_image): Remove var that is set but not used.
9957 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
9959 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
9960 that are set but not used.
9962 * xfns.c (make_invisible_cursor): Don't return garbage
9963 if XCreateBitmapFromData fails (Bug#8410).
9965 * xselect.c (x_get_local_selection, x_handle_property_notify):
9966 Remove vars that are set but not used.
9968 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
9969 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
9971 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
9972 Remove var that is set but not used.
9973 (scroll_bar_windows_size): Now size_t, not int.
9974 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
9977 * xfaces.c (realize_named_face): Remove vars that are set but not used.
9978 (map_tty_color) [!defined MSDOS]: Likewise.
9980 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
9982 * coding.c: Remove vars that are set but not used.
9983 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
9984 All callers changed.
9985 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
9986 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
9987 (decode_coding_charset): Remove vars that are set but not used.
9989 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
9990 that is set but not used.
9992 * print.c (print_object): Remove var that is set but not used.
9994 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
9995 The gnulib version avoids calling malloc in the usual case,
9996 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
9997 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
9998 * filelock.c (current_lock_owner): Likewise.
9999 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
10000 * sysdep.c: Include allocator.h, careadlinkat.h.
10001 (emacs_no_realloc_allocator): New static constant.
10002 (emacs_readlink): New function.
10003 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
10004 ../lib/careadlinkat.h.
10006 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
10008 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
10009 first non-nil return value).
10011 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
10013 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
10014 if not defined (Bug#8403).
10016 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
10018 * xdisp.c (display_count_lines): Remove parameter `start',
10019 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10020 (get_char_face_and_encoding): Remove parameter `multibyte_p',
10021 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10022 (fill_stretch_glyph_string): Remove parameters `row' and `area',
10023 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
10024 and thereabouts. All callers changed.
10025 (get_per_char_metric): Remove parameter `f', unused since
10026 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10028 2011-04-02 Jim Meyering <meyering@redhat.com>
10030 do not dereference NULL upon failed strdup
10031 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
10032 (ns_get_family): Likewise.
10034 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
10036 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
10038 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
10040 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
10043 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
10045 Add lexical binding.
10047 * window.c (Ftemp_output_buffer_show): New fun.
10048 (Fsave_window_excursion):
10049 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
10051 * lread.c (lisp_file_lexically_bound_p): New function.
10052 (Fload): Bind Qlexical_binding.
10053 (readevalloop): Remove `evalfun' arg.
10054 Bind Qinternal_interpreter_environment.
10055 (Feval_buffer): Bind Qlexical_binding.
10056 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
10058 (syms_of_lread): Declare `lexical-binding'.
10060 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
10062 * keyboard.c (eval_dyn): New fun.
10063 (menu_item_eval_property): Use it.
10065 * image.c (parse_image_spec): Use Ffunctionp.
10067 * fns.c (concat, mapcar1): Accept byte-code-functions.
10069 * eval.c (Fsetq): Handle lexical vars.
10070 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
10071 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
10072 (FletX, Flet): Obey lexical binding.
10073 (Fcommandp): Handle closures.
10074 (Feval): New `lexical' arg.
10075 (eval_sub): New function extracted from Feval. Use it almost
10076 everywhere where Feval was used. Look up vars in lexical env.
10078 (Ffunctionp): Move from subr.el.
10079 (Ffuncall): Handle closures.
10080 (apply_lambda): Remove `eval_flags'.
10081 (funcall_lambda): Handle closures and new byte-code-functions.
10082 (Fspecial_variable_p): New function.
10083 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
10084 but without exporting it to Lisp.
10086 * doc.c (Fdocumentation, store_function_docstring):
10087 * data.c (Finteractive_form): Handle closures.
10089 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
10092 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
10094 (exec_byte_code): New function extracted from Fbyte_code to handle new
10095 calling convention for byte-code-functions. Add new byte-codes.
10097 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
10099 * alloc.c (Fmake_symbol): Init new `declared_special' field.
10101 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
10103 * xdisp.c (redisplay_internal): Fix prototype.
10105 2011-03-31 Eli Zaretskii <eliz@gnu.org>
10107 * xdisp.c (SCROLL_LIMIT): New macro.
10108 (try_scrolling): Use it when setting scroll_limit.
10109 Limit scrolling to 100 screen lines.
10110 (redisplay_window): Even when falling back on "recentering",
10111 position point in the window according to scroll-conservatively,
10112 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
10114 (try_scrolling): When point is above the window, allow searching
10115 as far as scroll_max, or one screenful, to compute vertical
10116 distance from PT to the scroll margin position. This prevents
10117 try_scrolling from unnecessarily failing when
10118 scroll-conservatively is set to a value slightly larger than the
10119 window height. Clean up the case of PT below the margin at bottom
10120 of window: scroll_max can no longer be INT_MAX. When aggressive
10121 scrolling is in use, don't let point enter the opposite scroll
10122 margin as result of the scroll.
10123 (syms_of_xdisp) <scroll-conservatively>: Document the
10124 threshold of 100 lines for never-recentering scrolling.
10126 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
10128 * dispextern.h (move_it_by_lines):
10129 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
10130 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
10131 (message_log_check_duplicate): Remove parameters `prev_bol' and
10132 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10133 (redisplay_internal): Remove parameter `preserve_echo_area',
10134 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
10136 * indent.c (Fvertical_motion):
10137 * window.c (window_scroll_pixel_based, Frecenter):
10138 Don't pass `need_y_p' to `move_it_by_lines'.
10140 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
10142 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
10143 steal a few bits to be more compact.
10144 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
10145 Remove unneeded casts.
10147 * bytecode.c (Fbyte_code): CAR and CDR can GC.
10149 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
10151 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
10152 binding" message (bug#7967).
10154 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
10156 Fix more problems found by GCC 4.6.0's static checks.
10158 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
10159 Remove unused local var.
10161 * editfns.c (Fmessage_box): Remove unused local var.
10163 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
10164 (note_mode_line_or_margin_highlight, note_mouse_highlight):
10165 Omit unused local vars.
10166 * window.c (shrink_windows): Omit unused local var.
10167 * menu.c (digest_single_submenu): Omit unused local var.
10168 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
10169 Omit unused local var.
10171 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
10172 Don't assume string length fits in int.
10173 (keyremap_step, read_key_sequence): Use size_t for sizes.
10174 (read_key_sequence): Don't check last_real_key_start redundantly.
10176 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
10177 instead of alloca (Bug#8344).
10179 * eval.c (Fbacktrace): Don't assume nargs fits in int.
10180 (Fbacktrace_frame): Don't assume nframes fits in int.
10182 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
10184 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
10187 * term.c (produce_glyphless_glyph): Remove unnecessary test.
10189 * cm.c (calccost): Turn while-do into do-while, for clarity.
10191 * keyboard.c (syms_of_keyboard): Use the same style as later
10192 in this function when indexing through an array. This also
10193 works around GCC bug 48267.
10195 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
10197 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
10199 * chartab.c (sub_char_table_ref_and_range): Redo for slight
10200 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
10202 * keyboard.c, keyboard.h (num_input_events): Now size_t.
10203 This avoids undefined behavior on integer overflow, and is a bit
10204 more convenient anyway since it is compared to a size_t variable.
10206 Variadic C functions now count arguments with size_t, not int.
10207 This avoids an unnecessary limitation on 64-bit machines, which
10208 caused (substring ...) to crash on large vectors (Bug#8344).
10209 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
10210 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
10211 All variadic functions and their callers changed accordingly.
10212 (struct gcpro.nvars): Now size_t, not int. All uses changed.
10213 * data.c (arith_driver, float_arith_driver): Likewise.
10214 * editfns.c (general_insert_function): Likewise.
10215 * eval.c (struct backtrace.nargs, interactive_p)
10216 (internal_condition_case_n, run_hook_with_args, apply_lambda)
10217 (funcall_lambda, mark_backtrace): Likewise.
10218 * fns.c (concat): Likewise.
10219 * frame.c (x_set_frame_parameters): Likewise.
10220 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
10221 0 if not found, not -1. All callers changed.
10223 * alloc.c (garbage_collect): Don't assume stack size fits in int.
10224 (stack_copy_size): Now size_t, not int.
10225 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
10227 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
10229 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
10230 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10231 All callers changed.
10233 * lisp.h (multibyte_char_to_unibyte):
10234 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
10235 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10236 * character.h (CHAR_TO_BYTE8):
10237 * cmds.c (internal_self_insert):
10238 * editfns.c (general_insert_function):
10239 * keymap.c (push_key_description):
10240 * search.c (Freplace_match):
10241 * xdisp.c (message_dolog, set_message_1): All callers changed.
10243 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
10245 * keyboard.c (safe_run_hook_funcall): New function.
10246 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
10247 don't set the hook to nil, but remove the offending function instead.
10248 (Qcommand_hook_internal): Remove, unused.
10249 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
10250 Vcommand_hook_internal.
10252 * eval.c (enum run_hooks_condition): Remove.
10253 (funcall_nil, funcall_not): New functions.
10254 (run_hook_with_args): Call each function through a `funcall' argument.
10255 Remove `cond' argument, now redundant.
10256 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
10257 (Frun_hook_with_args_until_failure): Adjust accordingly.
10258 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
10260 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
10262 * dispextern.h (string_buffer_position): Remove declaration.
10264 * print.c (strout): Remove parameter `multibyte', unused since
10265 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
10267 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
10268 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
10269 All callers changed.
10271 * w32.c (_wsa_errlist): Use braces for struct initializers.
10273 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
10274 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
10275 All callers changed.
10276 (string_buffer_position): Likewise. Also, make static (it's never
10277 used outside xdisp.c).
10278 (cursor_row_p): Remove parameter `w', unused since
10279 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
10280 (decode_mode_spec): Remove parameter `precision', introduced during
10281 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
10282 All callers changed.
10284 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10286 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
10288 2011-03-27 Anders Lindgren <andlind@gmail.com>
10290 * nsterm.m (ns_menu_bar_is_hidden): New variable.
10291 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
10292 (ns_update_auto_hide_menu_bar): New functions.
10293 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
10294 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
10295 ns_constrain_all_frames.
10296 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
10297 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
10299 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10301 * nsmenu.m (runDialogAt): Remove argument to timer_check.
10303 2011-03-27 Glenn Morris <rgm@gnu.org>
10305 * syssignal.h: Replace RETSIGTYPE with void.
10306 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
10307 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
10308 Replace SIGTYPE with void everywhere.
10309 * s/usg5-4-common.h (SIGTYPE): Remove definition.
10310 * s/template.h (SIGTYPE): Remove commented out definition.
10312 2011-03-26 Eli Zaretskii <eliz@gnu.org>
10314 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
10315 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
10317 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
10319 * w32.c (read_unc_volume): Use parameter `henum', instead of
10320 global variable `wget_enum_handle'.
10322 * keymap.c (describe_vector): Remove parameters `indices' and
10323 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
10324 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
10326 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
10328 * keyboard.c (timer_check): Remove parameter `do_it_now',
10329 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
10330 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
10331 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
10333 * keyboard.c (read_char):
10334 * w32menu.c (w32_menu_display_help):
10335 * xmenu.c (show_help_event, menu_help_callback):
10336 Adjust calls to `show_help_echo'.
10338 * gtkutil.c (xg_maybe_add_timer):
10339 * keyboard.c (readable_events):
10340 * process.c (wait_reading_process_output):
10341 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
10343 * insdel.c (adjust_markers_gap_motion):
10344 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
10345 (gap_left, gap_right): Don't call it.
10347 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
10349 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
10350 incurred during fontification.
10352 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
10354 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
10355 (DEFVAR_PER_BUFFER): Don't pass it.
10357 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
10358 (scrolling_window): Don't pass it.
10360 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
10362 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
10364 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
10366 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
10367 of variables specific to SELinux and computation of `encoded_absname'.
10369 * image.c (XPutPixel): Remove unused variable `height'.
10371 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
10373 * unexw32.c (get_section_info): Remove unused variable `section'.
10375 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
10376 (system_process_attributes): Remove unused variable `sess'.
10377 (sys_read): Remove unused variable `err'.
10379 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
10380 (w32_wnd_proc): Remove unused variable `isdead'.
10381 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
10382 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
10383 (x_create_tip_frame): Remove unused variable `tem'.
10385 * w32inevt.c (w32_console_read_socket):
10386 Remove unused variable `no_events'.
10388 * w32term.c (x_draw_composite_glyph_string_foreground):
10389 Remove unused variable `width'.
10391 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
10393 * w32term.c (x_set_glyph_string_clipping):
10394 Don't pass uninitialized region to CombineRgn.
10396 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
10398 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
10399 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
10400 (Fx_close_connection): Remove unused variable `i'.
10402 * w32font.c (w32font_draw): Return number of glyphs.
10403 (w32font_open_internal): Remove unused variable `i'.
10404 (w32font_driver): Add missing initializer.
10406 * w32menu.c (utf8to16): Remove unused variable `utf16'.
10407 (fill_in_menu): Remove unused variable `items_added'.
10409 * w32term.c (last_mouse_press_frame): Remove static global variable.
10410 (w32_clip_to_row): Remove unused variable `f'.
10411 (x_delete_terminal): Remove unused variable `i'.
10413 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
10414 (NOTHING): Remove unused static global variable.
10415 (uniscribe_check_otf): Remove unused variable `table'.
10416 (uniscribe_font_driver): Add missing initializers.
10418 2011-03-23 Julien Danjou <julien@danjou.info>
10420 * term.c (Fsuspend_tty, Fresume_tty):
10421 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
10422 * window.c (temp_output_buffer_show):
10423 * insdel.c (signal_before_change):
10424 * frame.c (Fhandle_switch_frame):
10425 * fileio.c (Fdo_auto_save):
10426 * emacs.c (Fkill_emacs):
10427 * editfns.c (save_excursion_restore):
10428 * cmds.c (internal_self_insert):
10429 * callint.c (Fcall_interactively):
10430 * buffer.c (Fkill_all_local_variables):
10431 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
10433 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
10434 unconditionally since it does the check itself.
10436 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
10438 Fix more problems found by GCC 4.5.2's static checks.
10440 * coding.c (encode_coding_raw_text): Avoid unnecessary test
10441 the first time through the loop, since we know p0 < p1 then.
10442 This also avoids a gcc -Wstrict-overflow warning.
10444 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
10445 leading to a memory leak, possible in functions like
10446 load_charset_map_from_file that can allocate an unbounded number
10447 of objects (Bug#8318).
10449 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
10450 that could (at least in theory) be that large.
10452 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
10453 This is less likely to overflow, and avoids undefined behavior if
10454 overflow does occur. All callers changed. Use strtoul to scan
10455 for the unsigned long integer.
10456 (pint2hrstr): Simplify and tune code slightly.
10457 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
10459 * scroll.c (do_scrolling): Work around GCC bug 48228.
10460 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
10462 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
10463 This also avoids a warning with gcc -Wstrict-overflow.
10464 (validate_x_resource_name): Simplify count usage.
10465 This also avoids a warning with gcc -Wstrict-overflow.
10467 * fileio.c (Fcopy_file): Report error if fchown or fchmod
10470 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
10472 * process.c (Fmake_network_process): Use socklen_t, not int,
10473 where POSIX says socklen_t is required in portable programs.
10474 This fixes a porting bug on hosts like 64-bit HP-UX, where
10475 socklen_t is wider than int (Bug#8277).
10476 (Fmake_network_process, server_accept_connection):
10477 (wait_reading_process_output, read_process_output):
10480 * process.c: Rename or move locals to avoid shadowing.
10481 (list_processes_1, Fmake_network_process):
10482 (read_process_output_error_handler, exec_sentinel_error_handler):
10483 Rename or move locals.
10484 (Fmake_network_process): Define label "retry_connect" only if needed.
10485 (Fnetwork_interface_info): Fix pointer signedness.
10486 (process_send_signal): Add cast to avoid pointer signedness problem.
10487 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
10488 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
10490 Make tparam.h and terminfo.c consistent.
10491 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
10492 Include tparam.h instead, since it declares them.
10493 * cm.h (PC): Remove extern decl; tparam.h now does this.
10494 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
10495 * terminfo.c: Include tparam.h, to check interfaces.
10496 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
10497 (tparam): Adjust signature to match interface in tparam.h;
10498 this removes some undefined behavior. Check that outstring and len
10499 are zero, which they always are with Emacs.
10500 * tparam.h (PC, BC, UP): New extern decls.
10502 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
10503 (xftfont_open): Rename locals to avoid shadowing.
10505 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
10506 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
10507 (OTF_TAG_SYM): Omit macro if not needed.
10508 (ftfont_list): Remove unused local.
10509 (get_adstyle_property, ftfont_pattern_entity):
10510 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
10511 Rename locals to avoid shadowing.
10513 * xfont.c (xfont_list_family): Mark var as initialized.
10515 * xml.c (make_dom): Now static.
10517 * composite.c (composition_compute_stop_pos): Rename local to
10519 (composition_reseat_it): Remove unused locals.
10520 (find_automatic_composition, composition_adjust_point): Likewise.
10521 (composition_update_it): Mark var as initialized.
10522 (find_automatic_composition): Mark vars as initialized,
10523 with a FIXME (Bug#8290).
10525 character.h: Rename locals to avoid shadowing.
10526 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
10527 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
10528 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
10529 (BUF_DEC_POS): Be more systematic about renaming local temporaries
10530 to avoid shadowing.
10532 * textprop.c (property_change_between_p): Remove; unused.
10534 * intervals.c (interval_start_pos): Now static.
10536 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
10538 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
10539 Rename locals to avoid shadowing.
10541 * sound.c (wav_play, au_play, Fplay_sound_internal):
10542 Fix pointer signedness.
10543 (alsa_choose_format): Remove unused local var.
10544 (wav_play): Initialize a variable to 0, to prevent undefined
10545 behavior (Bug#8278).
10547 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
10549 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
10551 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
10552 clobbering (Bug#8298).
10553 * sysdep.c (sys_subshell): Likewise.
10554 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
10556 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
10557 This should get cleaned up, so that child_setup has the
10558 same signature on all platforms.
10560 * callproc.c (call_process_cleanup): Now static.
10561 (relocate_fd): Rename locals to avoid shadowing.
10563 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
10565 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
10566 not to be necessary, and produces flickering.
10568 2011-03-20 Glenn Morris <rgm@gnu.org>
10570 * config.in: Remove file.
10572 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
10574 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
10575 are now in src/globals.h.
10576 (syms_of_minibuf): Remove spurious & from previous change.
10578 2011-03-20 Leo Liu <sdl.web@gmail.com>
10580 * minibuf.c (completing-read-function): New variable.
10581 (completing-read-default): Rename from completing-read.
10582 (completing-read): Call completing-read-function.
10584 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
10586 * xfaces.c (Fx_load_color_file):
10587 Read color file from absolute filename (bug#8250).
10589 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
10591 * makefile.w32-in: Update dependencies.
10593 2011-03-17 Eli Zaretskii <eliz@gnu.org>
10595 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
10597 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
10599 Fix more problems found by GCC 4.5.2's static checks.
10601 * process.c (make_serial_process_unwind, send_process_trap):
10602 (sigchld_handler): Now static.
10604 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
10605 That way, the code declares only the vars that it needs.
10606 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
10607 * s/cygwin.h (PTY_ITERATION): Likewise.
10608 * s/darwin.h (PTY_ITERATION): Likewise.
10609 * s/gnu-linux.h (PTY_ITERATION): Likewise.
10611 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
10612 * process.c (allocate_pty): Don't declare stb unless it's needed.
10614 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
10615 (CONSTANTLIM): Remove; unused.
10616 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
10617 Define only if needed.
10619 * unexelf.c (unexec): Name an expression,
10620 to avoid gcc -Wbad-function-cast warning.
10621 Use a different way to cause a compilation error if anyone uses
10622 n rather than nn, a way that does not involve shadowing.
10623 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
10625 * deps.mk (unexalpha.o): Remove; unused.
10627 New file unexec.h, the (simple) interface for unexec (Bug#8267).
10628 * unexec.h: New file.
10629 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
10630 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
10631 Depend on unexec.h.
10632 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
10633 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
10634 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
10635 Change as necessary to match prototype in unexec.h.
10637 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
10639 (back_comment, skip_chars): Mark vars as initialized.
10641 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
10642 Rename locals to avoid shadowing.
10644 * lread.c (read1): Rewrite so as not to use empty "else".
10645 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
10647 * print.c (Fredirect_debugging_output): Fix pointer signedess.
10649 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
10650 warning when compiling print.c.
10652 * font.c (font_unparse_fcname): Abort in an "impossible" situation
10653 instead of using an uninitialized var.
10654 (font_sort_entities): Mark var as initialized.
10656 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
10658 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
10659 pointers to constants.
10660 (font_parse_fcname): Remove unused vars.
10661 (font_delete_unmatched): Now static.
10662 (font_get_spec): Remove; unused.
10663 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
10664 (font_update_drivers, Ffont_get_glyphs, font_add_log):
10665 Rename or move locals to avoid shadowing.
10667 * fns.c (require_nesting_list, require_unwind): Now static.
10668 (Ffillarray): Rename locals to avoid shadowing.
10670 * floatfns.c (domain_error2): Define only if needed.
10671 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
10673 * alloc.c (mark_backtrace): Move decl from here ...
10674 * lisp.h: ... to here, so that it can be checked.
10676 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
10677 (Fdefvar): Rewrite so as not to use empty "else".
10678 (lisp_indirect_variable): Name an expression,
10679 to avoid gcc -Wbad-function-cast warning.
10680 (Fdefvar): Rename locals to avoid shadowing.
10682 * callint.c (quotify_arg, quotify_args): Now static.
10683 (Fcall_interactively): Rename locals to avoid shadowing.
10684 Use const pointer when appropriate.
10686 * lisp.h (get_system_name, get_operating_system_release):
10687 Move decls here, to check interfaces.
10688 * process.c (get_operating_system_release): Move decl to lisp.h.
10689 * xrdb.c (get_system_name): Likewise.
10690 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
10691 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
10692 some of which prompt warnings from gcc -Wbad-function-cast.
10693 (Fformat_time_string, Fencode_time, Finsert_char):
10694 (Ftranslate_region_internal, Fformat):
10695 Rename or remove local vars to avoid shadowing.
10696 (Ftranslate_region_internal): Mark var as initialized.
10698 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
10701 * lisp.h (eassert): Check that the argument compiles, even if
10702 ENABLE_CHECKING is not defined.
10704 * data.c (Findirect_variable): Name an expression, to avoid
10705 gcc -Wbad-function-cast warning.
10706 (default_value, arithcompare, arith_driver, arith_error): Now static.
10707 (store_symval_forwarding): Rename local to avoid shadowing.
10708 (Fmake_variable_buffer_local, Fmake_local_variable):
10709 Mark variables as initialized.
10710 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
10712 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
10713 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
10714 Rename locals to avoid shadowing.
10715 (mark_stack): Move local variables into the #ifdef region where
10717 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
10718 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
10720 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
10721 (GC_STRING_CHARS): Remove; not used.
10722 (Fmemory_limit): Cast sbrk's returned value to char *.
10724 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
10725 avoids undefined behavior in theory.
10727 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
10729 Use functions, not macros, for up- and down-casing (Bug#8254).
10730 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
10731 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
10732 to use the following functions instead of these macros.
10733 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
10734 EMACS_INT, since callers assume the returned value fits in int.
10735 (upcase1): Likewise, for UPCASE_TABLE.
10736 (uppercasep, lowercasep, upcase): New static inline functions.
10737 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
10738 the race-condition problem in the old DOWNCASE.
10740 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
10741 Rename locals to avoid shadowing.
10742 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
10743 (regex_compile, re_search_2, re_match_2_internal):
10744 Remove unused local vars.
10745 (FREE_VAR): Rewrite so as not to use empty "else",
10746 which gcc can warn about.
10747 (regex_compile, re_match_2_internal): Mark locals as initialized.
10748 (RETALLOC_IF): Define only if needed.
10749 (WORDCHAR_P): Likewise. This one is never needed, but is used
10750 only in a comment talking about a compiler bug, so put inside
10751 the #if 0 of that comment.
10752 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
10753 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
10756 * search.c (boyer_moore): Rename locals to avoid shadowing.
10757 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
10758 (PREV_CHAR_BOUNDARY): Likewise.
10760 * search.c (simple_search): Remove unused var.
10762 * dired.c (compile_pattern): Move decl from here ...
10763 * lisp.h: ... to here, so that it can be checked.
10764 (struct re_registers): New forward decl.
10766 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
10768 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
10770 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
10771 Rename locals to avoid shadowing.
10772 (Fvertical_motion): Mark locals as initialized.
10774 * casefiddle.c (casify_object, casify_region): Now static.
10775 (casify_region): Mark local as initialized.
10777 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
10779 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
10780 New macros, so that the caller can use some names other than
10781 gcpro1, gcpro2, etc.
10782 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
10784 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
10785 argument, for consistency with GCPRO2_VAR, etc: it is now the
10786 prefix of the variable, not the variable itself. All uses
10788 * dired.c (directory_files_internal, file_name_completion):
10789 Rename locals to avoid shadowing.
10791 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
10792 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
10793 dired.c's scmp function, had undefined behavior.
10794 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
10795 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
10796 * buffer.h: ... to here, because these macros use current_buffer,
10797 and the new implementation with inline functions needs to have
10798 current_buffer in scope now, rather than later when the macros
10800 (downcase, upcase1): New static inline functions.
10801 (DOWNCASE, UPCASE1): Reimplement using these functions.
10802 This avoids undefined behavior in expressions like
10803 DOWNCASE (x) == DOWNCASE (y), which previously suffered
10804 from race conditions in accessing the global variables
10805 case_temp1 and case_temp2.
10806 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
10807 * lisp.h (case_temp1, case_temp2): Remove their decls.
10808 * character.h (ASCII_CHAR_P): Move from here ...
10809 * lisp.h: ... to here, so that the inline functions mentioned
10810 above can use them.
10812 * dired.c (directory_files_internal_unwind): Now static.
10814 * fileio.c (file_name_as_directory, directory_file_name):
10815 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
10817 (file_name_as_directory): Use const pointers when appropriate.
10818 (Fexpand_file_name): Likewise. In particular, newdir might
10819 point at constant storage, so make it a const pointer.
10820 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
10821 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
10823 (Fset_file_times, Finsert_file_contents, auto_save_error):
10824 Rename locals to avoid shadowing.
10826 * minibuf.c (choose_minibuf_frame_1): Now static.
10827 (Ftry_completion, Fall_completions): Rename or remove locals
10828 to avoid shadowing.
10830 * marker.c (bytepos_to_charpos): Remove; unused.
10832 * lisp.h (verify_bytepos, count_markers): New decls,
10833 so that gcc does not warn that these functions aren't declared.
10835 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
10836 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
10837 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
10838 (copy_text): Remove unused local var.
10840 * filelock.c (within_one_second): Now static.
10841 (lock_file_1): Rename local to avoid shadowing.
10843 * buffer.c (fix_overlays_before): Mark locals as initialized.
10844 (fix_start_end_in_overlays): Likewise. This function should be
10845 simplified by using pointers-to-pointers, but that's a different
10847 (switch_to_buffer_1): Now static.
10848 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
10849 (report_overlay_modification): Rename locals to avoid shadowing.
10851 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
10852 Fix pointer signedness issue.
10853 (sys_subshell): Mark local as volatile if checking for lint,
10854 to suppress a gcc -Wclobbered warning that does not seem to be right.
10855 (MAXPATHLEN): Define only if needed.
10857 * process.c (serial_open, serial_configure): Move decls from here ...
10858 * systty.h: ... to here, so that they can be checked.
10860 * fns.c (get_random, seed_random): Move extern decls from here ...
10861 * lisp.h: ... to here, so that they can be checked.
10863 * sysdep.c (reset_io): Now static.
10864 (wait_for_termination_signal): Remove; unused.
10866 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
10867 (copy_keymap_item, append_key, push_text_char_description):
10869 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
10870 (DENSE_TABLE_SIZE): Remove; unused.
10871 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
10872 (describe_map_tree):
10873 Rename locals to avoid shadowing.
10875 * keyboard.c: Declare functions static if they are not used elsewhere.
10876 (echo_char, echo_dash, cmd_error, top_level_2):
10877 (poll_for_input, handle_async_input): Now static.
10878 (read_char, kbd_buffer_get_event, make_lispy_position):
10879 (make_lispy_event, make_lispy_movement, apply_modifiers):
10880 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
10881 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
10882 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
10883 (read_key_sequence, read_char): Mark locals as initialized.
10884 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
10886 * keyboard.h (make_ctrl_char): New decl.
10887 (mark_kboards): Move decl here ...
10888 * alloc.c (mark_kboards): ... from here.
10890 * lisp.h (force_auto_save_soon): New decl.
10892 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
10893 (DEFINE_DUMMY_FUNCTION): New macro.
10894 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
10896 (main): Add casts to avoid warnings
10897 if GCC considers string literals to be constants.
10899 * lisp.h (fatal_error_signal): Add decl, since it's exported.
10901 * dbusbind.c: Pointer signedness fixes.
10902 (xd_signature, xd_append_arg, xd_initialize):
10903 (Fdbus_call_method, Fdbus_call_method_asynchronously):
10904 (Fdbus_method_return_internal, Fdbus_method_error_internal):
10905 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
10906 (Fdbus_register_signal): Use SSDATA when the context wants char *.
10908 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
10909 if GCC considers string literals to be constants.
10910 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
10912 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
10914 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
10915 (print_preprocess, print_object): New macro to fix last change.
10917 * print.c (print_preprocess): Don't forget font objects.
10919 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
10921 * emacs.c (USAGE3): Doc fixes.
10923 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
10925 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
10928 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
10930 * lisp.h (VWindow_system, Qfile_name_history):
10931 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
10932 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
10933 (w32_system_caret_x, w32_system_caret_y): Declare extern.
10935 * w32select.c: Don't #include "keyboard.h".
10936 (run_protected): Add extern declaration for waiting_for_input.
10938 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
10939 * w32console.c (detect_input_pending, read_input_pending)
10940 (encode_terminal_code):
10941 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
10942 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
10943 (w32_system_caret_y, Qfile_name_history):
10944 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
10945 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
10946 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
10947 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
10948 * w32proc.c (Qlocal, report_file_error):
10949 * w32term.c (Vwindow_system, updating_frame):
10950 * w32uniscribe.c (initialized, uniscribe_font_driver):
10951 Remove unneeded extern declarations.
10953 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
10955 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
10957 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
10959 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
10960 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
10961 These macros can no longer be used for assignment.
10963 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
10964 Assign struct members directly, instead of using BUF_BEGV etc.
10965 (record_buffer_markers, fetch_buffer_markers): New functions for
10966 recording and fetching special buffer markers.
10967 (set_buffer_internal_1, set_buffer_temp): Use them.
10969 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
10971 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
10973 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
10974 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
10976 * xdisp.c (hscroll_window_tree):
10977 (reconsider_clip_changes): Use PT instead of BUF_PT.
10979 2011-03-13 Eli Zaretskii <eliz@gnu.org>
10981 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
10982 $(EMACS_ROOT)/lib/intprops.h.
10984 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
10986 Fix more problems found by GCC 4.5.2's static checks.
10988 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
10989 to unsigned char * to avoid compiler diagnostic.
10990 (xg_free_frame_widgets): Make it clear that a local variable is
10991 needed only if USE_GTK_TOOLTIP.
10992 (gdk_window_get_screen): Make it clear that this macro is needed
10993 only if USE_GTK_TOOLTIP.
10994 (int_gtk_range_get_value): New function, which avoids a diagnostic
10995 from gcc -Wbad-function-cast.
10996 (xg_set_toolkit_scroll_bar_thumb): Use it.
10997 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
10998 diagnostic from gcc -Wbad-function-cast.
10999 (get_utf8_string, xg_get_file_with_chooser):
11000 Rename locals to avoid shadowing.
11001 (create_dialog): Move locals to avoid shadowing.
11003 * xgselect.c (xg_select): Remove unused var.
11005 * image.c (four_corners_best): Mark locals as initialized.
11006 (gif_load): Initialize transparent_p to zero (Bug#8238).
11007 Mark another local as initialized.
11008 (my_png_error, my_error_exit): Mark with NO_RETURN.
11010 * image.c (clear_image_cache): Now static.
11011 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
11012 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
11013 (x_edge_detection): Remove unnecessary cast that
11014 gcc -Wbad-function-cast diagnoses.
11015 (gif_load): Fix pointer signedness.
11016 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
11017 (jpeg_load, gif_load): Rename locals to avoid shadowing.
11019 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
11021 Improve quality of tests for time stamp overflow.
11022 For example, without this patch (encode-time 0 0 0 1 1
11023 1152921504606846976) returns the obviously-bogus value (-948597
11024 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
11025 reports time overflow. See
11026 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
11027 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
11028 * editfns.c: Include limits.h and intprops.h.
11029 (TIME_T_MIN, TIME_T_MAX): New macros.
11030 (time_overflow): Move earlier, to before first use.
11031 (hi_time, lo_time): New functions, for an accurate test for
11032 out-of-range times.
11033 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
11034 (Fget_internal_run_time): Don't assume time_t fits in int.
11035 (make_time): Use list2 instead of Fcons twice.
11036 (Fdecode_time): More accurate test for out-of-range times.
11037 (check_tm_member): New function.
11038 (Fencode_time): Use it, to test for out-of-range times.
11039 (lisp_time_argument): Don't rely on undefined left-shift and
11040 right-shift behavior when checking for time stamp overflow.
11042 * editfns.c (time_overflow): New function, refactoring common code.
11043 (Fformat_time_string, Fdecode_time, Fencode_time):
11044 (Fcurrent_time_string): Use it.
11046 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
11047 * dired.c (make_time): Move to ...
11048 * editfns.c (make_time): ... here.
11049 * systime.h: Note the move.
11051 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11053 * fringe.c (update_window_fringes): Remove unused variables.
11055 * unexmacosx.c (copy_data_segment): Also copy __got section.
11058 2011-03-12 Eli Zaretskii <eliz@gnu.org>
11060 * termcap.c [MSDOS]: Include "msdos.h".
11061 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
11062 Constify `char *' arguments and their references according to
11063 prototypes in tparam.h.
11065 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
11067 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
11068 Adapt all references accordingly.
11070 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
11072 2011-03-11 Tom Tromey <tromey@redhat.com>
11074 * buffer.c (syms_of_buffer): Remove obsolete comment.
11076 2011-03-11 Eli Zaretskii <eliz@gnu.org>
11078 * termhooks.h (encode_terminal_code): Declare prototype.
11080 * msdos.c (encode_terminal_code): Don't declare prototype.
11082 * term.c (encode_terminal_code): Now external again, used by
11083 w32console.c and msdos.c.
11085 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
11086 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
11088 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
11090 Fix some minor problems found by GCC 4.5.2's static checks.
11092 * fringe.c (update_window_fringes): Mark locals as initialized
11094 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
11096 * alloc.c (mark_fringe_data): Move decl from here ...
11097 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
11098 to check its interface.
11099 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
11101 * fontset.c (free_realized_fontset): Now static.
11102 (Fset_fontset_font): Rename local to avoid shadowing.
11103 (fontset_font): Mark local as initialized.
11104 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
11106 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
11108 * xselect.c (x_disown_buffer_selections): Remove; not used.
11109 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
11110 (x_own_selection, Fx_disown_selection_internal): Rename locals
11111 to avoid shadowing.
11112 (x_handle_dnd_message): Remove local to avoid shadowing.
11114 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
11115 so that the caller can use some name other than gcpro1.
11116 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
11117 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11118 (Fx_backspace_delete_keys_p):
11119 Use them to avoid shadowing, and rename vars to avoid shadowing.
11120 (x_decode_color, x_set_name, x_window): Now static.
11121 (Fx_create_frame): Add braces to silence GCC warning.
11122 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
11123 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
11124 Remove unused locals.
11125 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11126 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
11127 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
11130 * xterm.h (x_mouse_leave): New decl.
11132 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
11133 Remove unused functions.
11134 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
11135 (x_calc_absolute_position): Now static.
11136 (XTread_socket): Don't define label "out" unless it's used.
11137 Don't declare local "event" unless it's used.
11138 (x_iconify_frame, x_free_frame_resources): Don't declare locals
11139 unless they are used.
11140 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
11141 (x_fatal_error_signal): Remove; not used.
11142 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
11143 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
11144 (x_error_catcher, x_connection_closed, x_error_handler):
11145 (x_error_quitter, xembed_send_message, x_iconify_frame):
11146 (my_log_handler): Rename locals to avoid shadowing.
11147 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
11148 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
11150 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
11151 Rename or move locals to avoid shadowing.
11152 (tty_defined_color, merge_face_heights): Now static.
11153 (free_realized_faces_for_fontset): Remove; not used.
11154 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
11155 does not deduce is never used uninitialized.
11156 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
11157 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
11159 * terminal.c (store_terminal_param): Now static.
11161 * xmenu.c (menu_highlight_callback): Now static.
11162 (set_frame_menubar): Remove unused local.
11163 (xmenu_show): Rename parameter to avoid shadowing.
11164 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
11165 since they might point to immutable storage.
11166 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
11167 since it's unused otherwise.
11169 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
11170 Add a FIXME, since the code still doesn't look right. (Bug#8215)
11171 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
11172 avoids a gcc -Wuninitialized diagnostic.
11173 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
11174 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
11175 does not deduce are never used uninitialized.
11177 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
11179 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
11180 * window.c (window_loop, size_window):
11181 (run_window_configuration_change_hook, enlarge_window): Likewise.
11183 * window.c (display_buffer): Now static.
11184 (size_window): Mark variables that gcc -Wuninitialized
11185 does not deduce are never used uninitialized.
11186 * window.h (check_all_windows): New decl, to forestall
11187 gcc -Wmissing-prototypes diagnostic.
11188 * dispextern.h (bidi_dump_cached_states): Likewise.
11190 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
11192 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
11193 Include <limits.h>.
11194 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
11195 and to avoid gcc -Wuninitialized warning.
11196 (load_charset_map): Mark variables that gcc -Wuninitialized
11197 does not deduce are never used uninitialized.
11198 (load_charset): Abort instead of using uninitialized var (Bug#8229).
11200 * coding.c (coding_set_source, coding_set_destination):
11201 Use "else { /* comment */ }" rather than "else /* comment */;"
11202 for clarity, and to avoid gcc -Wempty-body warning.
11203 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
11204 a block, when the outer 'i' will do.
11205 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
11206 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
11207 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
11208 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
11209 (Fdecode_sjis_char, Fdefine_coding_system_internal):
11210 Rename locals to avoid shadowing.
11211 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
11212 * coding.c (emacs_mule_char, encode_invocation_designation):
11213 Now static, since they're not used elsewhere.
11214 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
11215 (decode_coding_object, encode_coding_object, detect_coding_system):
11216 (decode_coding_emacs_mule): Mark variables that gcc
11217 -Wuninitialized does not deduce are never used uninitialized.
11218 (detect_coding_iso_2022): Initialize a local variable that might
11219 be used uninitialized. Leave a FIXME because it's not clear that
11220 this initialization is needed. (Bug#8211)
11221 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
11222 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
11223 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
11224 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
11225 Remove unused macros.
11227 * category.c (hash_get_category_set): Remove unused local var.
11228 (copy_category_table): Now static, since it's not used elsewhere.
11229 * character.c (string_count_byte8): Likewise.
11231 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
11232 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
11234 * chartab.c (copy_sub_char_table): Now static, since it's not used
11236 (sub_char_table_ref_and_range, char_table_ref_and_range):
11237 Rename locals to avoid shadowing.
11238 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
11240 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
11241 (BIDI_BOB): Remove unused macro.
11243 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
11244 deduce are never used uninitialized.
11245 * term.c (encode_terminal_code): Likewise.
11247 * term.c (encode_terminal_code): Now static. Remove unused local.
11249 * tparam.h: New file.
11250 * term.c, tparam.h: Include it.
11251 * deps.mk (term.o, tparam.o): Depend on tparam.h.
11252 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
11253 Move these decls to tparam.h, and make them agree with what
11254 is actually in tparam.c. The previous trick of using incompatible
11255 decls in different modules does not conform to the C standard.
11256 All callers of tparam changed to use tparam's actual API.
11257 * tparam.c (tparam1, tparam, tgoto):
11258 Use const pointers where appropriate.
11260 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
11261 * cm.h (struct cm): Likewise.
11262 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
11263 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
11264 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
11265 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
11266 (turn_on_face, init_tty): Likewise.
11267 * termchar.h (struct tty_display_info): Likewise.
11269 * term.c (term_mouse_position): Rename local to avoid shadowing.
11271 * alloc.c (mark_ttys): Move decl from here ...
11272 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
11274 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
11276 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
11278 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
11280 * search.c (compile_pattern_1): Remove argument regp, unused since
11281 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
11282 (compile_pattern): Don't pass it.
11284 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
11286 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
11287 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
11289 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
11291 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
11293 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
11294 gdk_window_get_screen, gdk_window_get_geometry,
11295 gdk_x11_window_lookup_for_display and GDK_KEY_g.
11296 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
11297 (xg_get_pixbuf_from_pixmap): New function.
11298 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
11299 to Pixmap, take frame as parameter, remove GdkColormap parameter.
11300 Call xg_get_pixbuf_from_pixmap instead of
11301 gdk_pixbuf_get_from_drawable.
11302 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
11303 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
11304 (xg_check_special_colors): Use GtkStyleContext and its functions
11306 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
11307 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
11308 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
11309 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
11310 Call gtk_widget_get_preferred_size.
11311 (xg_frame_resized): gdk_window_get_geometry only takes 5
11313 (xg_win_to_widget, xg_event_is_for_menubar):
11314 Call gdk_x11_window_lookup_for_display.
11315 (xg_set_widget_bg): New function.
11316 (delete_cb): New function.
11317 (xg_create_frame_widgets): Connect delete-event to delete_cb.
11318 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
11319 (xg_set_background_color): Call xg_set_widget_bg.
11320 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
11321 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
11322 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
11323 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
11325 (update_frame_tool_bar): Call gtk_widget_hide.
11326 (xg_initialize): Use GDK_KEY_g.
11328 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
11330 (x_session_initialize): Call gdk_x11_set_sm_client_id.
11332 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
11333 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
11334 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
11336 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
11338 * w32xfns.c (select_palette): Check success of RealizePalette against
11339 GDI_ERROR, not zero.
11341 See ChangeLog.11 for earlier changes.
11343 ;; Local Variables:
11347 Copyright (C) 2011-2012 Free Software Foundation, Inc.
11349 This file is part of GNU Emacs.
11351 GNU Emacs is free software: you can redistribute it and/or modify
11352 it under the terms of the GNU General Public License as published by
11353 the Free Software Foundation, either version 3 of the License, or
11354 (at your option) any later version.
11356 GNU Emacs is distributed in the hope that it will be useful,
11357 but WITHOUT ANY WARRANTY; without even the implied warranty of
11358 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11359 GNU General Public License for more details.
11361 You should have received a copy of the GNU General Public License
11362 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.