]> code.delx.au - gnu-emacs/blob - src/ChangeLog
Fix botched merge.
[gnu-emacs] / src / ChangeLog
1 2011-11-18 Paul Eggert <eggert@cs.ucla.edu>
2
3 Fix integer width and related bugs (Bug#9874).
4 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
5 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
6 (string_bytes, check_sblock, allocate_string_data):
7 (compact_small_strings, Fmake_bool_vector, make_string)
8 (make_unibyte_string, make_multibyte_string)
9 (make_string_from_bytes, make_specified_string)
10 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
11 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
12 (mark_vectorlike):
13 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
14 (allocate_pseudovector):
15 Use int, not EMACS_INT, where int is wide enough.
16 (inhibit_garbage_collection, Fgarbage_collect):
17 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
18 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
19 int might not be wide enough.
20 (bidi_cache_search, bidi_cache_find, bidi_init_it)
21 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
22 (bidi_at_paragraph_end, bidi_find_paragraph_start)
23 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
24 (bidi_level_of_next_char, bidi_move_to_visually_next):
25 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
26 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
27 (Fkill_buffer, Fset_buffer_major_mode)
28 (advance_to_char_boundary, Fbuffer_swap_text)
29 (Fset_buffer_multibyte, overlays_at, overlays_in)
30 (overlay_touches_p, struct sortvec, record_overlay_string)
31 (overlay_strings, recenter_overlay_lists)
32 (adjust_overlays_for_insert, adjust_overlays_for_delete)
33 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
34 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
35 (Foverlay_recenter, last_overlay_modification_hooks_used)
36 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
37 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
38 (validate_region): Omit unnecessary test for b <= e,
39 since that's guaranteed by the previous test.
40 (adjust_overlays_for_delete): Avoid pos + length overflow.
41 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
42 (report_overlay_modification):
43 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
44 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
45 Omit pointer cast, which isn't needed anyway, and doesn't work
46 after the EMACS_INT -> ptrdiff_t change.
47 (Fmove_overlay): Delete an evaporating overlay
48 if it becomes empty after its bounds are adjusted to fit within
49 its buffer. Without this fix, in a nonempty buffer (let ((o
50 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
51 yields an empty overlay that has the evaporate property, which is
52 not supposed to happen. (Bug#9642)
53 * buffer.h: Adjust decls to match defn changes elsewhere.
54 (struct buffer_text, struct buffer):
55 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
56 Use EMACS_INT, not int, where int might not be wide enough.
57 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
58 not int, to avoid needless 32-bit limit on 64-bit hosts.
59 (exec_byte_code): Use tighter memory-full test, one that checks
60 for alloca overflow. Don't compute the address of the object just
61 before an array, as that's not portable. Use EMACS_INT, not
62 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
63 * callint.c (Fcall_interactively):
64 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
65 * callproc.c (call_process_kill, Fcall_process):
66 Don't assume pid_t fits into an Emacs fixnum.
67 (call_process_cleanup, Fcall_process, child_setup):
68 Don't assume pid_t fits into int.
69 (call_process_cleanup, Fcall_process, delete_temp_file)
70 (Fcall_process_region):
71 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
72 (Fcall_process): Simplify handling of volatile integers.
73 Use int, not EMACS_INT, where int will do.
74 * casefiddle.c (casify_object, casify_region, operate_on_word)
75 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
76 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
77 (casify_object): Avoid integer overflow when overallocating buffer.
78 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
79 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
80 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
81 * category.h (CATEGORYP): Don't assume arg is nonnegative.
82 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
83 integers are now checked earlier. All uses replaced with XINT.
84 (ccl_driver):
85 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
86 For CCL_MapSingle, check that content and value are in int range.
87 (ccl_driver, Fregister_code_conversion_map):
88 Check that Vcode_version_map_vector is a vector.
89 (resolve_symbol_ccl_program): Check that vector header is in range.
90 Always copy the vector, so that we can check its contents reliably
91 now rather than having to recheck each instruction as it's being
92 executed. Check that vector words fit in 'int'.
93 (ccl_get_compiled_code, Fregister_ccl_program)
94 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
95 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
96 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
97 contents are in range.
98 (Fccl_execute_on_string): Check that status is in range.
99 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
100 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
101 Accept and return EMACS_INT, not int, because callers can pass values
102 out of 'int' range.
103 (c_string_width, strwidth, lisp_string_width, chars_in_text)
104 (multibyte_chars_in_text, parse_str_as_multibyte)
105 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
106 (str_as_unibyte, str_to_unibyte, string_count_byte8)
107 (string_escape_byte8, Fget_byte):
108 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
109 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
110 avoid mishandling large integers.
111 * character.h: Adjust decls to match defn changes elsewhere.
112 * charset.c (load_charset_map_from_file, find_charsets_in_text)
113 (Ffind_charset_region):
114 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
115 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
116 (load_charset_map_from_vector, Fdefine_charset_internal):
117 Don't assume fixnum fits in int.
118 (load_charset_map_from_vector, Fmap_charset_chars):
119 Remove now-unnecessary CHECK_NATNUMs.
120 (Fdefine_charset_internal): Check ranges here, more carefully.
121 Don't rely on undefined behavior with signed left shift overflow.
122 Don't assume unsigned int fits into fixnum, or that fixnum fits
123 into unsigned int. Don't require max_code to be a valid fixnum;
124 that's not true for gb10830 4-byte on a 32-bit host. Allow
125 invalid_code to be a cons, for the same reason. Require code_offset
126 to be a character. Avoid int overflow if max_char is close
127 to INT_MAX.
128 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
129 this is intended anyway and avoids some undefined behavior.
130 (load_charset_map): Pass unsigned, not int, as 2nd arg of
131 INDEX_TO_CODE_POINT, as that's what it expects.
132 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
133 * charset.h (DECODE_CHAR): Return int, not unsigned;
134 this is what was intended anyway, and it avoids undefined behavior.
135 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
136 integer-overflow issues.
137 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
138 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
139 where the argument is EMACS_INT, and this behavior is not intended.
140 * chartab.c (Fmake_char_table, Fset_char_table_range)
141 (uniprop_get_decoder, uniprop_get_encoder):
142 Don't assume fixnum fits in int.
143 * cmds.c (move_point): New function, that does the gist of
144 Fforward_char and Fbackward_char, but does so while checking
145 for integer overflow more accurately.
146 (Fforward_char, Fbackward_char): Use it.
147 (Fforward_line, Fend_of_line, internal_self_insert)
148 (internal_self_insert):
149 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
150 Fix a FIXME, by checking for integer overflow when calculating
151 target_clm and actual_clm.
152 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
153 (ASSURE_DESTINATION, coding_alloc_by_realloc)
154 (coding_alloc_by_making_gap, alloc_destination)
155 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
156 (encode_coding_utf_16, detect_coding_emacs_mule)
157 (decode_coding_emacs_mule, encode_coding_emacs_mule)
158 (detect_coding_iso_2022, decode_coding_iso_2022)
159 (encode_invocation_designation, encode_designation_at_bol)
160 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
161 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
162 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
163 (encode_coding_ccl, encode_coding_raw_text)
164 (detect_coding_charset, decode_coding_charset)
165 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
166 (produce_composition, produce_charset, produce_annotation)
167 (decode_coding, handle_composition_annotation)
168 (handle_charset_annotation, consume_chars, decode_coding_gap)
169 (decode_coding_object, encode_coding_object, detect_coding_system)
170 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
171 (code_convert_region, code_convert_string)
172 (Fdefine_coding_system_internal):
173 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
174 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
175 (Fdefine_coding_system_internal):
176 Don't assume fixnums fit in int.
177 (decode_coding_gap, decode_coding_object, encode_coding_object)
178 (Fread_coding_system, Fdetect_coding_region)
179 (Funencodable_char_position, Fcheck_coding_systems_region)
180 (get_translation, handle_composition_annotation, consume_chars):
181 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
182 (consume_chars): Rewrite to not calculate an address outside buffer.
183 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
184 Don't access memory outside of the args array.
185 (Fdefine_coding_system_internal): Check for charset-id overflow.
186 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
187 result of ENCODE_CHAR.
188 * coding.h: Adjust decls to match defn changes elsewhere.
189 (struct coding_system):
190 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
191 * composite.c (get_composition_id, find_composition)
192 (run_composition_function, update_compositions)
193 (compose_text, composition_gstring_put_cache)
194 (composition_gstring_p, composition_gstring_width)
195 (fill_gstring_header, fill_gstring_body, autocmp_chars)
196 (composition_compute_stop_pos, composition_reseat_it)
197 (composition_update_it, struct position_record)
198 (find_automatic_composition, composition_adjust_point)
199 (Fcomposition_get_gstring, Ffind_composition_internal):
200 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
201 (update_compositions):
202 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
203 * composite.h: Adjust decls to match defn changes elsewhere.
204 (struct composition):
205 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
206 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
207 Do not attempt to compute the address of the object just before a
208 buffer; this is not portable.
209 (Faref, Faset):
210 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
211 (Faset): Use int, not EMACS_INT, where int is wide enough.
212 (Fstring_to_number): Don't assume fixnums fit in int.
213 (Frem): Don't assume arg is nonnegative.
214 * dbusbind.c (xd_append_arg): Check for integers out of range.
215 (Fdbus_call_method): Don't overflow the timeout int.
216 * dired.c (directory_files_internal, file_name_completion, scmp)
217 (file_name_completion_stat):
218 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
219 (file_name_completion): Don't overflow matchcount.
220 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
221 * dispextern.h: Adjust decls to match defn changes elsewhere.
222 (struct text_pos, struct glyph, struct bidi_saved_info)
223 (struct bidi_string_data, struct bidi_it, struct composition_it)
224 (struct it):
225 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
226 (struct display_pos, struct composition_it, struct it):
227 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
228 * dispnew.c (increment_matrix_positions)
229 (increment_row_positions, mode_line_string)
230 (marginal_area_string):
231 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
232 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
233 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
234 (duration_to_sec_usec): New function, to check for overflow better.
235 (Fsleep_for, sit_for): Use it.
236 * doc.c (get_doc_string, store_function_docstring):
237 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
238 (get_doc_string, Fsnarf_documentation):
239 Use int, not EMACS_INT, where int is wide enough.
240 (get_doc_string):
241 Use SAFE_ALLOCA, not alloca.
242 Check for overflow when converting EMACS_INT to off_t.
243 * doprnt.c (doprnt):
244 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
245 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
246 Don't assume uid_t fits into fixnum.
247 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
248 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
249 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
250 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
251 (general_insert_function)
252 (Finsert_char, make_buffer_string, make_buffer_string_both)
253 (update_buffer_properties, Fbuffer_substring)
254 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
255 (Fsubst_char_in_region, check_translation)
256 (Ftranslate_region_internal, save_restriction_restore, Fformat)
257 (transpose_markers, Ftranspose_regions):
258 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
259 (clip_to_bounds): Move to lisp.h as an inline function).
260 (Fconstrain_to_field): Don't assume integers are nonnegative.
261 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
262 (Fsubst_char_in_region, Fsave_restriction):
263 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
264 (Femacs_pid): Don't assume pid_t fits into fixnum.
265 (lo_time): Use int, not EMACS_INT, when int suffices.
266 (lisp_time_argument): Check for usec out of range.
267 (Fencode_time): Don't assume fixnum fits in int.
268 (Fuser_login_name, Fuser_full_name): Signal an error
269 if a uid argument is out of range, rather than relying on
270 undefined behavior.
271 (Fformat_time_string): Remove now-unnecessary check.
272 lisp_time_argument checks for out-of-range usec now.
273 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
274 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
275 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
276 (init_cmdargs, Fdump_emacs):
277 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
278 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
279 the bottom (typically) 32 bits of the fixnum.
280 * eval.c (specpdl_size, call_debugger):
281 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
282 (when_entered_debugger, Fbacktrace_debug):
283 Don't assume fixnum can fit in int.
284 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
285 the object just before a buffer; this is not portable.
286 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
287 (grow_specpdl, unbind_to):
288 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
289 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
290 (grow_specpdl): Simplify allocation by using xpalloc.
291 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
292 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
293 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
294 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
295 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
296 (a_write, e_write):
297 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
298 (Fcopy_file, non_regular_nbytes, read_non_regular)
299 (Finsert_file_contents):
300 Use int, not EMACS_INT, where int is wide enough.
301 (READ_BUF_SIZE): Verify that it fits in int.
302 (Finsert_file_contents): Check that counts are in proper range,
303 rather than assuming fixnums fit into ptrdiff_t etc.
304 Don't assume fixnums fit into int.
305 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
306 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
307 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
308 (string_char_to_byte, string_byte_to_char)
309 (string_make_multibyte, string_to_multibyte)
310 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
311 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
312 (substring_both, Fdelete, internal_equal, Ffillarray)
313 (Fclear_string, mapcar1)
314 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
315 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
316 (larger_vector, make_hash_table, maybe_resize_hash_table)
317 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
318 (Fmaphash, secure_hash):
319 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
320 (concat): Check for string index and length overflow.
321 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
322 (Frequire):
323 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
324 (larger_vector): New API (vec, incr_min, size_max) replaces old
325 one (vec, new_size, init). This catches size overflow.
326 INIT was removed because it was always Qnil.
327 All callers changed.
328 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
329 the upper bound on a hash table index size.
330 (make_hash_table, maybe_resize_hash_table): Use it.
331 (secure_hash): Computer start_byte and end_byte only after
332 they're known to be in ptrdiff_t range.
333 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
334 (Ffont_get_glyphs, Ffont_at):
335 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
336 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
337 (Flist_fonts, Fopen_font):
338 Don't assume fixnum can fit in int.
339 (check_gstring): Don't assume index can fit in int.
340 (font_match_p): Check that fixnum is a character, not a nonnegative
341 fixnum, since the later code needs to stuff it into an int.
342 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
343 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
344 conversion overflow issues.
345 (Fopen_font): Check for integer out of range.
346 (Ffont_get_glyphs): Don't assume index can fit in int.
347 * font.h: Adjust decls to match defn changes elsewhere.
348 * fontset.c (reorder_font_vector): Redo score calculation to avoid
349 integer overflow.
350 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
351 printmax_t, where ptrdiff_t is wide enough.
352 (Finternal_char_font):
353 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
354 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
355 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
356 (Fset_frame_position, x_set_frame_parameters)
357 (x_set_line_spacing, x_set_border_width)
358 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
359 Check that fixnums are in proper range for system types.
360 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
361 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
362 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
363 Use SAFE_ALLOCA_LISP, not alloca.
364 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
365 intptr_t is wide enough.
366 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
367 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
368 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
369 Check for fixnum out of range.
370 * ftfont.c (ftfont_list): Don't assume index fits in int.
371 Check that fixnums are in proper range for system types.
372 (ftfont_shape_by_flt):
373 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
374 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
375 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
376 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
377 Check that fixnums are in proper range for system types.
378 * gnutls.h: Adjust decls to match defn changes elsewhere.
379 * gtkutil.c (xg_dialog_run):
380 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
381 (update_frame_tool_bar):
382 Check that fixnums are in proper range for system types.
383 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
384 (lookup_image): Check that fixnums are in range for system types.
385 * indent.c (last_known_column, last_known_column_point):
386 (current_column_bol_cache):
387 (skip_invisible, current_column, check_display_width):
388 (check_display_width, scan_for_column, current_column_1)
389 (Findent_to, Fcurrent_indentation, position_indentation)
390 (indented_beyond_p, Fmove_to_column, compute_motion):
391 (Fcompute_motion, Fvertical_motion):
392 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
393 (last_known_column_modified): Use EMACS_INT, not int.
394 (check_display_width):
395 (Fcompute_motion):
396 Check that fixnums and floats are in proper range for system types.
397 (compute_motion): Don't assume index or fixnum fits in int.
398 (compute_motion, Fcompute_motion):
399 Use int, not EMACS_INT, when it is wide enough.
400 (vmotion): Omit local var start_hpos that is always 0; that way
401 we don't need to worry about overflow in expressions involving it.
402 * indent.h: Adjust decls to match defn changes elsewhere.
403 (struct position):
404 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
405 Use int, not EMACS_INT, where int is wide enough.
406 Remove unused members ovstring_chars_done and tab_offset;
407 all uses removed.
408 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
409 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
410 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
411 (make_gap, copy_text, insert, insert_and_inherit)
412 (insert_before_markers, insert_before_markers_and_inherit)
413 (insert_1, count_combining_before, count_combining_after)
414 (insert_1_both, insert_from_string)
415 (insert_from_string_before_markers, insert_from_string_1)
416 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
417 (adjust_after_replace, adjust_after_insert, replace_range)
418 (replace_range_2, del_range, del_range_1, del_range_byte)
419 (del_range_both, del_range_2, modify_region)
420 (prepare_to_modify_buffer, signal_before_change)
421 (signal_after_change, Fcombine_after_change_execute):
422 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
423 * intervals.c (traverse_intervals, rotate_right, rotate_left)
424 (balance_an_interval, split_interval_right, split_interval_left)
425 (find_interval, next_interval, update_interval)
426 (adjust_intervals_for_insertion, delete_node, delete_interval)
427 (interval_deletion_adjustment, adjust_intervals_for_deletion)
428 (static_offset_intervals, offset_intervals)
429 (merge_interval_right, merge_interval_left, make_new_interval)
430 (graft_intervals_into_buffer, temp_set_point_both)
431 (temp_set_point, set_point, adjust_for_invis_intang)
432 (set_point_both, move_if_not_intangible, get_property_and_range)
433 (get_local_map, copy_intervals, copy_intervals_to_string)
434 (compare_string_intervals, set_intervals_multibyte_1):
435 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
436 * intervals.h: Adjust decls to match defn changes elsewhere.
437 (struct interval):
438 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
439 * keyboard.c (this_command_key_count, this_single_command_key_start)
440 (before_command_key_count, before_command_echo_length, echo_now)
441 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
442 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
443 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
444 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
445 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
446 (last_non_minibuf_size, last_point_position, echo_truncate)
447 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
448 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
449 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
450 (stuff_buffered_input):
451 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
452 (last_auto_save, command_loop_1, read_char):
453 Use EMACS_INT, not int, to avoid integer overflow.
454 (record_char): Avoid overflow in total_keys computation.
455 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
456 * keyboard.h: Adjust decls to match defn changes elsewhere.
457 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
458 (Fkey_description, Fdescribe_vector, Flookup_key):
459 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
460 (click_position): New function, to check that positions are in range.
461 (Fcurrent_active_maps):
462 (describe_command):
463 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
464 (Faccessible_keymaps, Fkey_description):
465 (preferred_sequence_p):
466 Don't assume fixnum can fit into int.
467 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
468 Check for integer overflow in size calculations.
469 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
470 avoid mishandling large integers.
471 * lisp.h: Adjust decls to match defn changes elsewhere.
472 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
473 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
474 (struct Lisp_Marker):
475 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
476 (clip_to_bounds): Now an inline function, moved here from editfns.c.
477 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
478 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
479 All callers changed.
480 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
481 Assume the arg has valid form, since it always does.
482 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
483 unsigned integer system type.
484 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
485 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
486 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
487 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
488 (duration_to_sec_usec): New decl.
489 * lread.c (read_from_string_index, read_from_string_index_byte)
490 (read_from_string_limit, readchar, unreadchar, openp)
491 (read_internal_start, read1, oblookup):
492 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
493 (Fload, readevalloop, Feval_buffer, Feval_region):
494 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
495 (openp): Check for out-of-range argument to 'access'.
496 (read1): Use int, not EMACS_INT, where int is wide enough.
497 Don't assume fixnum fits into int.
498 Fix off-by-one error that can read outside a buffer.
499 (read_filtered_event): Use duration_to_sec_usec
500 to do proper overflow checking on durations.
501 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
502 in size calculation.
503 (Fexecute_kbd_macro):
504 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
505 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
506 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
507 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
508 (set_marker_both, set_marker_restricted_both, marker_position)
509 (marker_byte_position, Fbuffer_has_markers_at):
510 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
511 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
512 * menu.c (ensure_menu_items): Renamed from grow_menu_items.
513 It now merely ensures that the menu is large enough, without
514 necessarily growing it, as this avoids some integer overflow issues.
515 All callers changed.
516 (keymap_panes, parse_single_submenu, Fx_popup_menu):
517 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
518 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
519 Use SAFE_ALLOCA_LISP, not alloca.
520 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
521 to EMACS_INT. Check that fixnums are in proper range for system types.
522 * minibuf.c (minibuf_prompt_width, string_to_object)
523 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
524 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
525 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
526 (get_minibuffer, read_minibuf_unwind):
527 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
528 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
529 this simplifies overflow checking. All callers changed.
530 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
531 (Ftest_completion):
532 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
533 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
534 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
535 Check that fixnums are in proper range for system types.
536 (Fx_create_frame, Fx_show_tip):
537 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
538 * nsfont.m (ns_findfonts, nsfont_list_family):
539 Don't assume fixnum fits in long.
540 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
541 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
542 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
543 wide enough.
544 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
545 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
546 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
547 (PRINTDECLARE, PRINTPREPARE):
548 (strout, print_string):
549 (print, print_preprocess, print_check_string_charset_prop)
550 (print_object):
551 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
552 (PRINTDECLARE):
553 (temp_output_buffer_setup, Fprin1_to_string, print_object):
554 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
555 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
556 (printchar, strout): Use xpalloc to catch size calculation overflow.
557 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
558 (print_error_message): Use SAFE_ALLOCA, not alloca.
559 (print_object): Use int, not EMACS_INT, where int is wide enough.
560 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
561 (Fset_process_window_size, Fformat_network_address)
562 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
563 (sigchld_handler):
564 Check that fixnums are in proper range for system types.
565 (Fsignal_process): Simplify by avoiding a goto.
566 Check for process-ids out of pid_t range rather than relying on
567 undefined behavior.
568 (Fformat_network_address, read_process_output, send_process)
569 (Fprocess_send_region, status_notify):
570 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
571 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
572 (wait_reading_process_output, read_process_output, exec_sentinel):
573 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
574 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
575 (Faccept_process_output): Use duration_to_sec_usec to do proper
576 overflow checking on durations.
577 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
578 Don't assume pid_t fits in int.
579 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
580 configured --with-wide-int.
581 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
582 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
583 * search.c (looking_at_1, string_match_1):
584 (fast_string_match, fast_c_string_match_ignore_case)
585 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
586 (scan_newline, find_before_next_newline, search_command)
587 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
588 (set_search_regs, wordify):
589 (Freplace_match):
590 (Fmatch_data):
591 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
592 (string_match_1, search_buffer, set_search_regs):
593 (Fmatch_data):
594 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
595 (wordify): Check for overflow in size calculation.
596 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
597 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
598 Check that fixnums are in proper range for system types.
599 * sound.c (struct sound_device)
600 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
601 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
602 (Fplay_sound_internal):
603 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
604 * syntax.c (struct lisp_parse_state, find_start_modiff)
605 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
606 (Fparse_partial_sexp):
607 Don't assume fixnums can fit in int.
608 (struct lisp_parse_state, find_start_pos, find_start_value)
609 (find_start_value_byte, find_start_begv)
610 (update_syntax_table, char_quoted, dec_bytepos)
611 (find_defun_start, prev_char_comend_first, back_comment):
612 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
613 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
614 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
615 (Finternal_describe_syntax_value): Check that match_lisp is a
616 character, not an integer, since the code stuffs it into int.
617 (scan_words, scan_sexps_forward):
618 Check that fixnums are in proper range for system types.
619 (Fforward_word):
620 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
621 (scan_sexps_forward):
622 Use CHARACTERP, not INTEGERP, since the value must fit into int.
623 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
624 * syntax.h: Adjust decls to match defn changes elsewhere.
625 (struct gl_state_s):
626 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
627 * sysdep.c (wait_for_termination_1, wait_for_termination)
628 (interruptible_wait_for_termination, mkdir):
629 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
630 (emacs_read, emacs_write):
631 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
632 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
633 and double all fit in int.
634 * term.c (set_tty_color_mode):
635 Check that fixnums are in proper range for system types.
636 * termhooks.h (struct input_event):
637 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
638 * textprop.c (validate_interval_range, interval_of)
639 (Fadd_text_properties, set_text_properties_1)
640 (Fremove_text_properties, Fremove_list_of_text_properties)
641 (Ftext_property_any, Ftext_property_not_all)
642 (copy_text_properties, text_property_list, extend_property_ranges)
643 (verify_interval_modification):
644 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
645 (Fnext_single_char_property_change)
646 (Fprevious_single_char_property_change):
647 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
648 (copy_text_properties):
649 Check for integer overflow in index calculation.
650 * undo.c (last_boundary_position, record_point, record_insert)
651 (record_delete, record_marker_adjustment, record_change)
652 (record_property_change):
653 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
654 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
655 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
656 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
657 (Fx_hide_tip, Fx_file_dialog):
658 * w32menu.c (set_frame_menubar):
659 Use ptrdiff_t, not int, for consistency with rest of code.
660 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
661 (select_window, Fdelete_other_windows_internal)
662 (window_scroll_pixel_based, window_scroll_line_based)
663 (Frecenter, Fset_window_configuration):
664 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
665 (Fset_window_hscroll, run_window_configuration_change_hook)
666 (set_window_buffer, temp_output_buffer_show, scroll_command)
667 (Fscroll_other_window, Frecenter):
668 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
669 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
670 Don't assume fixnum fits in int.
671 (Fset_window_scroll_bars):
672 Check that fixnums are in proper range for system types.
673 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
674 (string_pos, c_string_pos, number_of_chars, init_iterator)
675 (in_ellipses_for_invisible_text_p, init_from_display_pos)
676 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
677 (compute_display_string_end, handle_face_prop)
678 (face_before_or_after_it_pos, handle_invisible_prop)
679 (handle_display_prop, handle_display_spec, handle_single_display_spec)
680 (display_prop_intangible_p, string_buffer_position_lim)
681 (string_buffer_position, handle_composition_prop, load_overlay_strings)
682 (get_overlay_strings_1, get_overlay_strings)
683 (iterate_out_of_display_property, forward_to_next_line_start)
684 (back_to_previous_visible_line_start, reseat, reseat_to_string)
685 (get_next_display_element, set_iterator_to_next)
686 (get_visually_first_element, compute_stop_pos_backwards)
687 (handle_stop_backwards, next_element_from_buffer)
688 (move_it_in_display_line_to, move_it_in_display_line)
689 (move_it_to, move_it_vertically_backward, move_it_by_lines)
690 (add_to_log, message_dolog, message_log_check_duplicate)
691 (message2, message2_nolog, message3, message3_nolog
692 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
693 (current_message_1, truncate_echo_area, truncate_message_1)
694 (set_message, set_message_1, store_mode_line_noprop)
695 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
696 (text_outside_line_unchanged_p, check_point_in_composition)
697 (reconsider_clip_changes)
698 (redisplay_internal, set_cursor_from_row, try_scrolling)
699 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
700 (redisplay_window, find_last_unchanged_at_beg_row)
701 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
702 (trailing_whitespace_p, find_row_edges, display_line)
703 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
704 (display_mode_element, store_mode_line_string)
705 (pint2str, pint2hrstr, decode_mode_spec)
706 (display_count_lines, display_string, draw_glyphs)
707 (x_produce_glyphs, x_insert_glyphs)
708 (rows_from_pos_range, mouse_face_from_buffer_pos)
709 (fast_find_string_pos, mouse_face_from_string_pos)
710 (note_mode_line_or_margin_highlight, note_mouse_highlight):
711 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
712 (safe_call, init_from_display_pos, handle_fontified_prop)
713 (handle_single_display_spec, load_overlay_strings)
714 (with_echo_area_buffer, setup_echo_area_for_printing)
715 (display_echo_area, echo_area_display)
716 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
717 (update_tool_bar, hscroll_window_tree, redisplay_internal)
718 (redisplay_window, dump_glyph_row, display_mode_line)
719 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
720 (handle_display_spec, display_prop_string_p):
721 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
722 (handle_single_display_spec, build_desired_tool_bar_string)
723 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
724 (get_specified_cursor_type):
725 Check that fixnums are in proper range for system types.
726 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
727 (Flookup_image_map):
728 Don't assume fixnums fit in int.
729 (compare_overlay_entries):
730 Avoid mishandling comparisons due to subtraction overflow.
731 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
732 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
733 (handle_tool_bar_click):
734 Use int, not unsigned, since we prefer signed and the signedness
735 doesn't matter here.
736 (get_next_display_element, next_element_from_display_vector):
737 Use int, not EMACS_INT, when int is wide enough.
738 (start_hourglass): Use duration_to_sec_usec to do proper
739 overflow checking on durations.
740 * xfaces.c (Fbitmap_spec_p):
741 Check that fixnums are in proper range for system types.
742 (compare_fonts_by_sort_order):
743 Avoid mishandling comparisons due to subtraction overflow.
744 (Fx_family_fonts, realize_basic_faces):
745 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
746 (Fx_family_fonts):
747 Don't assume fixnum fits in int.
748 Use SAFE_ALLOCA_LISP, not alloca.
749 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
750 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
751 (face_at_buffer_position, face_for_overlay_string)
752 (face_at_string_position):
753 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
754 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
755 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
756 (Fx_show_tip):
757 Check that fixnums are in proper range for system types.
758 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
759 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
760 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
761 (Fx_change_window_property): Don't assume fixnums fit in int.
762 * xfont.c (xfont_chars_supported):
763 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
764 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
765 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
766 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
767 * xml.c (parse_region):
768 * xrdb.c (magic_file_p):
769 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
770 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
771 (x_get_local_selection, x_reply_selection_request)
772 (x_handle_selection_request, wait_for_property_change):
773 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
774 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
775 short is wide enough.
776 (x_send_client_event): Don't assume fixnum fits in int.
777 * xterm.c (x_x_to_emacs_modifiers):
778 Don't assume EMACS_INT overflows nicely into int.
779 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
780 may come from Lisp.
781 (handle_one_xevent): NATNUMP can eval its arg twice.
782 (x_connection_closed):
783 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
784 * xterm.h: Adjust decls to match defn changes elsewhere.
785 (struct scroll_bar): Use struct vectorlike_header
786 rather than rolling our own approximation.
787 (SCROLL_BAR_VEC_SIZE): Remove; not used.
788
789 2011-11-18 Paul Eggert <eggert@cs.ucla.edu>
790
791 Fix minor problems found by static checking.
792 * dispextern.h, xdisp.c (row_hash): Declare extern only if XASSERTS.
793 * dispnew.c (verify_row_hash): Now static.
794
795 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
796
797 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
798
799 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
800
801 * intervals.c: Fix grafting over the whole buffer (bug#10071).
802 (graft_intervals_into_buffer): Simplify.
803
804 2011-11-18 Eli Zaretskii <eliz@gnu.org>
805
806 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
807 hash values of the two rows.
808 (copy_row_except_pointers): Preserve the used[] arrays and the
809 hash values of the two rows. (Bug#10035)
810 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
811
812 * xdisp.c (row_hash): New function, body extracted from
813 compute_line_metrics.
814 (compute_line_metrics): Call row_hash, instead of computing the
815 hash code inline.
816
817 * dispnew.c (verify_row_hash): Call row_hash for computing the
818 hash code of a row, instead of duplicating code from xdisp.c.
819
820 * dispextern.h (row_hash): Add prototype.
821
822 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
823
824 * frame.c (delete_frame): Don't delete the terminal when the last
825 X frame is closed if emacs is built with GTK toolkit.
826
827 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
828
829 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
830
831 2011-11-17 Martin Rudalics <rudalics@gmx.at>
832
833 * window.c (Vwindow_splits): Rename to
834 Vwindow_combination_resize. Suggested by Juri Linkov.
835 (Fsplit_window_internal): Use Vwindow_combination_resize instead
836 of Vwindow_splits.
837
838 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
839
840 * nsfns.m (Fns_font_name):
841 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
842
843 2011-11-16 Martin Rudalics <rudalics@gmx.at>
844
845 * window.h (window): Rename slot "nest" to "combination_limit".
846 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
847 (Fset_window_nest): Rename to Fset_window_combination_limit.
848 (Vwindow_nest): Rename to Vwindow_combination_limit.
849 (recombine_windows, make_parent_window, make_window)
850 (Fsplit_window_internal, saved_window)
851 (Fset_window_configuration, save_window_save): Rename all
852 occurrences of window_nest to window_combination_limit.
853
854 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
855
856 * image.c (imagemagick_load_image): Fix typo.
857
858 2011-11-14 Eli Zaretskii <eliz@gnu.org>
859
860 * xdisp.c (display_line): Move the call to
861 highlight_trailing_whitespace before the call to
862 compute_line_metrics, since the latter needs to see the final
863 faces of all the glyphs to compute ROW's hash value. Fixes
864 assertion violations in row_equal_p. (Bug#10035)
865
866 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
867
868 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
869 just return (bug#10044).
870
871 2011-11-12 Eli Zaretskii <eliz@gnu.org>
872
873 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
874 with user-defined heap size. Bump the default size of the temacs
875 heap to 27MB, to avoid memory warning when running temacs.
876 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
877
878 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
879 current_matrix and desired_matrix. (Bug#9990)
880 (verify_row_hash) [XASSERTS]: New function.
881 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
882 that the hash value of glyph rows is correct.
883
884 2011-11-12 Martin Rudalics <rudalics@gmx.at>
885
886 * window.h (window): Remove splits slot.
887 * window.c (Fwindow_splits, Fset_window_splits): Remove.
888 (Fdelete_other_windows_internal, make_parent_window)
889 (make_window, Fsplit_window_internal, Fdelete_window_internal)
890 (Fset_window_configuration, save_window_save): Don't deal with
891 split status of windows.
892 (saved_window): Remove splits slot.
893 (Vwindow_splits): Rewrite doc-string.
894
895 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
896
897 * xfns.c (unwind_create_frame):
898 * nsfns.m (unwind_create_frame):
899 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
900 Vframe_list (Bug#9999).
901
902 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
903
904 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
905
906 2011-11-11 Kenichi Handa <handa@m17n.org>
907
908 * callproc.c (Fcall_process): Set the member dst_multibyte of
909 process_coding.
910
911 2011-11-11 Johan Bockgård <bojohan@gnu.org>
912
913 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
914 avoid a crash (bug#9496).
915
916 2011-11-09 Chong Yidong <cyd@gnu.org>
917
918 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
919 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
920
921 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
922
923 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
924
925 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
926
927 Avoid some portability problems by eschewing 'extern inline' functions.
928 The trivial performance wins aren't worth the portability hassles; see
929 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
930 et seq.
931 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
932 (window_box_width, window_box_left, window_box_left_offset)
933 (window_box_right, window_box_right_offset): Undo previous change,
934 by removing the "extern"s.
935 * intervals.c (adjust_intervals_for_insertion)
936 (adjust_intervals_for_deletion): Undo previous change,
937 making these static again.
938 (offset_intervals, temp_set_point_both, temp_set_point)
939 (copy_intervals_to_string): No longer inline.
940 * xdisp.c (window_text_bottom_y, window_box_width)
941 (window_box_height, window_box_left_offset)
942 (window_box_right_offset, window_box_left, window_box_right)
943 (window_box): No longer inline.
944
945 2011-11-08 Chong Yidong <cyd@gnu.org>
946
947 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
948 (Fwindow_body_height, Fwindow_body_width): Move from Lisp. Signal
949 an error if not a live window.
950 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
951 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
952
953 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
954
955 * lisp.h (syms_of_abbrev): Remove declaration.
956 Reported by CHENG Gao <chenggao@royau.me>.
957
958 2011-11-07 Eli Zaretskii <eliz@gnu.org>
959
960 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
961 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
962 of temacs in GUI mode.
963
964 2011-11-07 Martin Rudalics <rudalics@gmx.at>
965
966 * window.h: Declare delete_all_child_windows instead of
967 delete_all_subwindows.
968 * window.c (Fwindow_nest, Fset_window_nest)
969 (Fset_window_new_total, Fset_window_new_normal)
970 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
971 (delete_all_subwindows): Rename to delete_all_child_windows.
972 (Fdelete_other_windows_internal, Fset_window_configuration):
973 Call delete_all_child_windows instead of delete_all_subwindows.
974 * frame.c (delete_frame): Call delete_all_child_windows instead
975 of delete_all_subwindows.
976
977 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
978
979 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
980 This is also needed for porting to any host where GC_MARK_STACK is
981 not GC_MAKE_GCPROS_NOOPS.
982 (which_symbols): Use it.
983
984 2011-11-07 Kenichi Handa <handa@m17n.org>
985
986 * coding.c (coding_set_destination): Check coding->src_pos only
987 when coding->src_object is a buffer (bug#9910).
988
989 * process.c (send_process): Set the member src_multibyte of coding
990 to 0 (bug#9911) when sending a unibyte text.
991
992 * callproc.c (Fcall_process): Set the member src_multibyte of
993 process_coding to 0 (bug#9912).
994
995 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
996
997 * xmenu.c (cleanup_widget_value_tree): New function.
998 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
999 calling free_menubar_widget_value_tree directly (Bug#9830).
1000
1001 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1002
1003 Fix some portability problems with 'inline'.
1004 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1005 (window_box_width, window_box_left, window_box_left_offset)
1006 (window_box_right, window_box_right_offset): Declare extern.
1007 Otherwise, these inline functions do not conform to C99 and
1008 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1009 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1010 * intervals.c (adjust_intervals_for_insertion)
1011 (adjust_intervals_for_deletion): Now extern, because otherwise the
1012 extern inline functions 'offset_intervals' couldn't refer to it.
1013 (static_offset_intervals): Remove.
1014 (offset_intervals): Rewrite using the old contents of
1015 static_offset_intervals. The old version didn't conform to C99
1016 because an extern inline function contained a reference to an
1017 identifier with static linkage.
1018
1019 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1020
1021 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1022 GC.
1023
1024 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1025
1026 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1027 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1028 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1029 return Qleft_to_right.
1030
1031 2011-11-06 Chong Yidong <cyd@gnu.org>
1032
1033 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1034 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1035 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1036 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1037 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1038 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1039 (Fwindow_vscroll): Doc fix.
1040 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1041 argument, since it makes no sense to pass a live window and for
1042 consistency with window-child.
1043
1044 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1045
1046 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1047 support MSVC.
1048
1049 2011-11-05 Jason Rumney <jasonr@gnu.org>
1050
1051 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1052 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1053 fonts (Bug#6029).
1054 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1055 bitwise arithmetic preventing use of unicode-sip and non-truetype
1056 opentype fonts.
1057
1058 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1059
1060 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1061 "emacs"-only part.
1062
1063 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1064 initialization code to keep similarity to xfns.c after changes
1065 from 2011-11-05.
1066
1067 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1068
1069 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1070 (unwind_create_frame): New function (Bug#9943).
1071 (Fx_create_frame): Restructure code to be more similar to the one in
1072 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1073 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1074 Move terminal->reference_count++ just before making the frame official
1075 (Bug#9943).
1076
1077 * nsterm.m (x_free_frame_resources): New function.
1078 (x_destroy_window): Move code to x_free_frame_resources.
1079
1080 * xfns.c (unwind_create_frame): Fix comment.
1081 (Fx_create_frame, x_create_tip_frame): Move
1082 terminal->reference_count++ just before making the frame
1083 official. Move initialization of image_cache_refcount and
1084 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1085
1086 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1087
1088 Support MSVC build with newer versions of Visual Studio.
1089 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1090 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1091 nt/gmake.defs.
1092
1093 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1094 which are not supported by MSVC.
1095 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1096 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1097 bitfields.
1098 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1099 types in bitfields.
1100 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1101
1102 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1103
1104 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1105
1106 Support MSVC build with newer versions of Visual Studio.
1107 * w32.c: Don't include w32api.h for MSVC.
1108 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1109
1110 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1111 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1112 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1113 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1114 e_* cousins.
1115 (alloca) [_MSC_VER]: Define to _alloca.
1116
1117 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1118
1119 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1120
1121 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1122
1123 * xdisp.c (note_mouse_highlight): If either of
1124 previous/next-single-property-change returns nil, treat that as
1125 the beginning or the end of the buffer. (Bug#9955)
1126
1127 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1128
1129 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1130 label is not null (Bug#9951).
1131 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1132 may be NULL.
1133
1134 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1135
1136 * window.c (Fwindow_body_size): Mention in the doc string that the
1137 return value is in frame's canonical units. (Bug#9949)
1138
1139 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1140
1141 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1142
1143 * w32fns.c (unwind_create_frame): If needed, free the glyph
1144 matrices of the partially constructed frame. (Bug#9943)
1145 * xfns.c (unwind_create_frame): Likewise.
1146
1147 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1148
1149 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1150 Don't stop backward scan on the continuation glyph, even though
1151 its CHARPOS is positive.
1152 (mouse_face_from_buffer_pos, note_mouse_highlight): Rename
1153 cover_string to disp_string.
1154
1155 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1156
1157 * window.c (temp_output_buffer_show): Don't use
1158 Vtemp_buffer_show_specifiers.
1159 (Vtemp_buffer_show_specifiers): Remove unused variable.
1160
1161 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1162
1163 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1164 past the beginning of the current glyph matrix.
1165
1166 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1167
1168 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1169 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1170 HAVE_GTK3 (Bug#9869).
1171
1172 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1173 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1174
1175 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1176
1177 * xterm.c: Declare x_handle_net_wm_state to return int.
1178 (handle_one_xevent): Check if we are iconified but don't have
1179 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1180 (get_current_wm_state): Return non-zero if not hidden,
1181 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1182 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1183 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1184 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1185
1186 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1187
1188 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1189 so that this new function doesn't get optimized away by a
1190 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1191
1192 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1193
1194 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1195
1196 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1197
1198 Fix the `xbytecode' command.
1199 * .gdbinit (xprintbytestr): New command.
1200 (xwhichsymbols): Rename from `which'; all callers changed.
1201 (xbytecode): Print the byte-code string as well.
1202
1203 2011-10-29 Kim Storm <storm@cua.dk>
1204
1205 * alloc.c (which_symbols): New function.
1206
1207 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1208
1209 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1210 line. (Bug#9903)
1211
1212 2011-10-29 Glenn Morris <rgm@gnu.org>
1213
1214 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1215 Not clear what it was for, and it causes various bugs. (Bug#9839)
1216
1217 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1218
1219 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1220 possible random value that matches one of those tested as
1221 condition to clear the mouse face.
1222
1223 2011-10-28 Chong Yidong <cyd@gnu.org>
1224
1225 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1226
1227 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1228
1229 * window.c (make_window): Initialize phys_cursor_on_p.
1230
1231 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1232
1233 * lisp.h (struct Lisp_Symbol): Update comments.
1234
1235 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1236
1237 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1238
1239 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1240
1241 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1242 <oslsachem@gmail.com> for helping to debug this.
1243
1244 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1245 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1246 (g_b_init_get_glyph_outline_w): New static variables.
1247 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1248 (GetGlyphOutlineW_Proc): New typedefs.
1249 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1250 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1251 New functions.
1252 (w32font_open_internal, compute_metrics):
1253 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1254 instead of calling the "wide" APIs directly.
1255
1256 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1257
1258 * w32.h (syms_of_w32font): Add prototype.
1259
1260 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1261
1262 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1263 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1264 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1265 (Fmove_to_window_line): Doc fix.
1266
1267 2011-10-27 Chong Yidong <cyd@gnu.org>
1268
1269 * process.c (make_process): Set gnutls_state to NULL.
1270
1271 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1272 non-NULL, regardless of GNUTLS_INITSTAGE.
1273 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1274 an error. Set process slots as soon as we allocate them.
1275
1276 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1277
1278 2011-10-27 Chong Yidong <cyd@gnu.org>
1279
1280 * gnutls.c (emacs_gnutls_deinit): New function.
1281 Deallocate credentials structures as well as calling gnutls_deinit.
1282 (Fgnutls_deinit, Fgnutls_boot): Use it.
1283
1284 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1285 (deactivate_process): Call emacs_gnutls_deinit.
1286
1287 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1288
1289 * image.c (x_create_x_image_and_pixmap):
1290 * w32.c (sys_rename, w32_delayed_load):
1291 * w32font.c (fill_in_logfont):
1292 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1293
1294 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1295
1296 * w32fns.c (w32_default_color_map): New function,
1297 extracted from Fw32_default_color_map.
1298 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1299
1300 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1301
1302 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1303
1304 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1305
1306 * keyboard.c (test_undefined): New function (bug#9751).
1307 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1308
1309 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1310
1311 * sysdep.c (init_sys_modes): Fix the check for the controlling
1312 terminal (Bug#6649).
1313
1314 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1315
1316 * dispextern.h (struct bidi_it): New member next_en_type.
1317
1318 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1319 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1320 current character, check also for next_en_type being WEAK_EN.
1321 (bidi_resolve_weak): Don't enter the expensive loop if the current
1322 position is before next_en_pos. Record the bidi type of the first
1323 non-ET, non-BN character we find, in addition to its position.
1324 (bidi_level_of_next_char): Invalidate next_en_type when
1325 next_en_pos is over-stepped.
1326
1327 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1328
1329 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1330 * editfns.c: Rewrite current-time-zone so that it invokes
1331 the equivalent of (format-time-string "%Z") to get the time zone name.
1332 This fixes a bug when the time zone name contains characters that
1333 need converting from the system time locale to Emacs internal format.
1334 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1335 that patch fixed format-time-string to do the conversion, but
1336 I forgot to fix current-time-zone.
1337 (format_time_string): New function, containing most of
1338 what Fformat_time_string used to contain.
1339 (Fformat_time_string): Rewrite in terms of format_time_string.
1340 This doesn't change this function's behavior.
1341 (current-time-zone): Rewrite to use format_time_string.
1342 This fixes the bug reported by Michael Schierl in
1343 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1344 Jason Rumney's 2007-06-07 change worked around this bug, but
1345 didn't fix it.
1346 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1347
1348 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1349
1350 * xdisp.c (start_display): If the character at POS is displayed
1351 via a display vector, reset IT->current.dpvec_index to zero.
1352 (try_window_reusing_current_matrix): If a line ends in a display
1353 vector or the next line starts in a display vector, continue
1354 redrawing the window even though the character position of
1355 start_row was reached.
1356 (Bug#9771, part 2)
1357
1358 2011-10-18 Chong Yidong <cyd@gnu.org>
1359
1360 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1361 with nobreak-char-display too.
1362
1363 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1364
1365 Fix part 3 of bug#9771.
1366 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1367 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1368 non-neutral characters if the current character is a paragraph
1369 separator (a.k.a. Newline). This avoids running the same
1370 expensive loop twice, once when we consume the preceding newline
1371 and the other time when the line actually needs to be displayed.
1372 Avoid the loop when we see neutrals on the base embedding level
1373 following a character whose directionality is the same as the
1374 paragraph's. This avoids running the expensive loop when a line
1375 ends in a long sequence of neutrals, like control characters.
1376 Add assertion against STRONG_AL type. Slightly rearrange code
1377 that determines the type of a neutral given the first non-neutral
1378 that follows it.
1379 (bidi_level_of_next_char): Set next_en_pos to zero when
1380 invalidating its info.
1381
1382 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1383
1384 * xdisp.c (push_display_prop): Determine whether to record string
1385 or buffer position by IT->string, not by IT->method. Allow
1386 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1387 (move_it_vertically_backward): Don't look for character position
1388 immediately after the newline when in a continuation line.
1389 (Bug#9771, part 1)
1390
1391 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1392
1393 * window.c (coordinates_in_window): Rewrite and delabelize
1394 vertical border check. (Bug#5357) (Bug#9618)
1395
1396 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1397
1398 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1399 errors in XSetWindowBorder (bug#9310).
1400
1401 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1402
1403 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1404 avoid crash when xmalloc overrun checking is enabled.
1405
1406 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1407
1408 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1409 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1410 cursor motion with <left> and <right> arrow keys.
1411
1412 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1413 some callers set that themselves.
1414
1415 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1416
1417 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1418 display string and the previous row comes from the same string and
1419 is empty. (Bug#9739) (Bug#9738)
1420
1421 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1422
1423 * doc.c (get_doc_string): Encode file name (bug#9735).
1424
1425 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1426
1427 * bidi.c (bidi_level_of_next_char):
1428 * xdisp.c (get_visually_first_element): Remove old incorrect
1429 comments regarding the Unicode Line Separator character.
1430
1431 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1432
1433 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1434
1435 * alloc.c (Fgc_status): Do not access beyond zombies array
1436 boundary if nzombies > MAX_ZOMBIES.
1437 * alloc.c (dump_zombies): Add missing format specifier.
1438
1439 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1440
1441 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1442 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1443
1444 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1445 Some packages use them to denote characters with modifiers.
1446
1447 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1448
1449 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1450 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1451 matching a pp-number. Rename parameter var to var1.
1452
1453 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1454
1455 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1456
1457 2011-10-08 Glenn Morris <rgm@gnu.org>
1458
1459 * callint.c (Fcall_interactively): Give a more explicit error for the
1460 'c' case with a non-character input. (Bug#8479)
1461
1462 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1463
1464 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1465 lines.
1466 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1467 lines that are hscrolled on the left.
1468
1469 * dispnew.c (buffer_posn_from_coords): Account for a possible
1470 presence of header-line. (Bug#4426)
1471
1472 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1473
1474 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1475 Don't advertise functionality which we discourage or doesn't work.
1476
1477 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1478
1479 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1480 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1481 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1482 this makes Emacs dump core during garbage collection on rare
1483 occasions. sizeof is obviously inferior to offsetof here, so
1484 stick with offsetof.
1485 (GC_POINTER_ALIGNMENT): New macro.
1486 (mark_memory): Omit 3rd (offset) arg; caller changed.
1487 Don't assume EMACS_INT alignment is the same as pointer alignment.
1488
1489 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1490
1491 * keyboard.c (read_key_sequence_remapped): New var.
1492 (read_key_sequence): Compute remapping in the right buffer.
1493 (command_loop_1): Use read_key_sequence's remapping directly.
1494
1495 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1496
1497 * dired.c (file_name_completion): Don't expand file name.
1498 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1499 before checking file name handler.
1500
1501 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1502 they've been requested explicitly (bug#9591).
1503
1504 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
1505
1506 * keymap.c (Fsingle_key_description): Use make_specified_string
1507 instead of build_string to build string from push_key_description.
1508 (Bug#5193)
1509
1510 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1511
1512 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1513 This fixes a Y2038 bug on 64-bit hosts.
1514 * buffer.c (reset_buffer):
1515 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1516 (Fclear_buffer_auto_save_failure):
1517 Use 0, not -1, to represent an unset failure time, since time_t
1518 might not be signed.
1519
1520 Remove dependency on glibc malloc internals.
1521 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1522 Move back here from lisp.h, but with their new implementations.
1523 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1524 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1525 * charset.c (charset_table_init): New static var.
1526 (syms_of_charset): Use it instead of xmalloc. This removes a
1527 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1528 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1529 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1530 Move back to alloc.c.
1531 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1532 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1533
1534 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1535
1536 * nsterm.m (windowDidResize): Call x_set_window_size only when
1537 ns_in_resize is true. Otherwise set pixelwidth/height and
1538 call change_frame_size (Bug#9628).
1539
1540 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1541
1542 Port --enable-checking=all to Fedora 14 x86-64.
1543 * charset.c (syms_of_charset): Also account for glibc malloc's
1544 internal overhead when calculating the initial malloc maximum.
1545
1546 Port --enable-checking=all to Fedora 14 x86.
1547 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1548 Move to lisp.h.
1549 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1550 (overrun_check_realloc, overrun_check_free):
1551 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1552 That way, xmalloc returns a properly-aligned pointer even if
1553 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1554 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1555 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1556 into account when calculating the initial malloc maximum.
1557 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1558 Move here from alloc.c, so that charset.c can use it too.
1559 Properly align; the old code wasn't right for common 32-bit hosts
1560 when configured with --enable-checking=all.
1561 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1562 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1563
1564 2011-09-29 Eli Zaretskii <eliz@gnu.org>
1565
1566 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
1567 use EDOM.
1568
1569 2011-09-28 Eli Zaretskii <eliz@gnu.org>
1570
1571 * xdisp.c (compute_display_string_end): If there's no display
1572 string at CHARPOS, return -1.
1573
1574 * bidi.c (bidi_fetch_char): When compute_display_string_end
1575 returns a negative value, treat the character as a normal
1576 character not covered by a display string. (Bug#9624)
1577
1578 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
1579
1580 * lread.c (Fread_from_string): Fix typo in docstring.
1581
1582 2011-09-27 Eli Zaretskii <eliz@gnu.org>
1583
1584 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1585 newline, reseat the iterator instead of bidi-iterating there one
1586 character at a time. (Bug#9610)
1587 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1588 TO_CHARPOS if the bidi iterator is at base embedding level.
1589
1590 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1591
1592 * lread.c (readevalloop): Use correct code for NBSP.
1593 (read1): Likewise. (Bug#9608)
1594
1595 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
1596
1597 * dbusbind.c (Fdbus_register_signal): When service is not
1598 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1599
1600 2011-09-25 Glenn Morris <rgm@gnu.org>
1601
1602 * buffer.c (truncate-lines): Doc fix.
1603
1604 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
1605
1606 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1607 (Fset_window_next_buffers): Doc fix.
1608
1609 2011-09-24 Glenn Morris <rgm@gnu.org>
1610
1611 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1612
1613 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1614
1615 Fix minor problems found by static checking.
1616 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1617 * indent.c (Fvertical_motion): Fix == vs = typo.
1618
1619 2011-09-24 Eli Zaretskii <eliz@gnu.org>
1620
1621 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1622 Default value is now t. Doc fix.
1623
1624 * indent.c (Fvertical_motion): Compute and apply the overshoot
1625 logic when moving up, not only when moving down. Fix the
1626 confusing name and values of the it_overshoot_expected variable;
1627 logic changes accordingly. (Bug#9254) (Bug#9549)
1628
1629 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1630 CHARPOS is covered by a display string which includes newlines.
1631 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1632 is covered by a display string with embedded newlines.
1633
1634 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
1635
1636 * dbusbind.c (Fdbus_register_signal): Add match rule to
1637 Vdbus_registered_objects_table. (Bug#9581)
1638 (Fdbus_register_method, Vdbus_registered_objects_table):
1639 Fix docstring.
1640
1641 2011-09-24 Jim Meyering <meyering@redhat.com>
1642
1643 do not ignore write error for any output size
1644 The previous change was incomplete.
1645 While it makes emacs --batch detect the vast majority of stdout
1646 write failures, errors were still ignored whenever the output size is
1647 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1648 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1649 && echo FAIL: ignored write error
1650 FAIL: ignored write error
1651 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1652 && echo FAIL: ignored write error
1653 FAIL: ignored write error
1654 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1655
1656 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1657
1658 * emacs.c (Fkill_emacs): In noninteractive mode exit
1659 non-successfully if a write error occurred on stdout. (Bug#9574)
1660
1661 2011-09-21 Eli Zaretskii <eliz@gnu.org>
1662
1663 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1664 the xassert test.
1665
1666 * dispextern.h (struct it): Update the comment documenting what
1667 can it->OBJECT be.
1668
1669 2011-09-20 Eli Zaretskii <eliz@gnu.org>
1670
1671 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1672 a display string, extend search for cursor position to end of row.
1673 (find_row_edges): If the row ends in a newline from a display
1674 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1675 Handle the case of a display string with multiple newlines.
1676 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1677 non-empty line. Fixes confusing cursor motion with arrow keys at
1678 the beginning of a line that starts with whitespace.
1679
1680 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1681
1682 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1683 (bug#9493).
1684
1685 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
1686
1687 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1688 boolean (Bug#9154).
1689
1690 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1691
1692 * xdisp.c (display_line): Record maximum and minimum buffer
1693 positions even if no glyphs were produced (e.g., by a zero-width
1694 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1695 buffer positions that will be removed from the glyph row because
1696 they don't fit.
1697 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1698 column is beyond frame width: don't subtract 1 "pixel" when
1699 computing width of the stretch.
1700 (reseat_at_next_visible_line_start): Undo the change made on
1701 2011-09-17 that saved paragraph information and restored it after
1702 the call to `reseat'. (Bug#9545)
1703
1704 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1705
1706 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1707 and turn window cursor on if cleared (Bug#9415).
1708
1709 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
1710
1711 * search.c (boyer_moore): Take unibyte characters from pattern
1712 literally. (Bug#9458)
1713
1714 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1715
1716 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1717
1718 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1719
1720 Fix minor problem found by static checking.
1721 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1722 initialized, to pacify gcc -Wuninitialized.
1723
1724 * fileio.c: Report proper errno when syscall falls.
1725 (Finsert_file_contents): Save and restore errno,
1726 so that report_file_error outputs the correct diagnostic.
1727 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1728
1729 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1730
1731 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1732
1733 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1734
1735 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1736 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1737
1738 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1739
1740 * xdisp.c (reseat_at_next_visible_line_start): Keep information
1741 about the current paragraph and restore it after the call to reseat.
1742
1743 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1744 (bidi_find_paragraph_start): Search back for paragraph beginning
1745 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1746 (bidi_move_to_visually_next): Only trigger paragraph-related
1747 computations when the last character is a newline or at EOB, not
1748 just any NEUTRAL_B. (Bug#9470)
1749
1750 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1751 truncated lines if point is covered by a display string. (Bug#9524)
1752
1753 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1754
1755 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1756 (cons_to_x_long): New function.
1757 (lisp_data_to_selection_data): Use it. Correct the test for
1758 short-versus-long data; it was negated. Break out of vector
1759 loop, for efficiency, when a long datum is discovered.
1760
1761 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1762
1763 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1764
1765 2011-09-16 Eli Zaretskii <eliz@gnu.org>
1766
1767 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1768 GCC PR/17406) by declaring this function with external scope.
1769
1770 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1771
1772 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1773 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1774
1775 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1776
1777 * editfns.c (Fformat): Correctly handle text properties on "%%".
1778
1779 2011-09-15 Eli Zaretskii <eliz@gnu.org>
1780
1781 * xterm.c (x_draw_composite_glyph_string_foreground):
1782 * w32term.c (x_draw_composite_glyph_string_foreground):
1783 * term.c (encode_terminal_code):
1784 * composite.c (composition_update_it, get_composition_id):
1785 * xdisp.c (get_next_display_element)
1786 (fill_composite_glyph_string): Add comments about special meaning
1787 of TAB characters in a composition.
1788
1789 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1790
1791 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
1792 This occurs when processing a multibyte format.
1793 Problem reported by Wolfgang Jenker.
1794
1795 2011-09-15 Johan Bockgård <bojohan@gnu.org>
1796
1797 * xdisp.c (try_cursor_movement): Only check for exact match if
1798 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1799
1800 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1801
1802 Remove unused external symbols.
1803 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1804 * xdisp.c (calc_pixel_width_or_height): Now static.
1805 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1806 * indent.c (check_display_width):
1807 * w32term.c: Fix comment to match code.
1808 * xterm.c, xterm.h (x_catching_errors): Remove.
1809
1810 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1811
1812 * xselect.c: Use signed conversions more consistently (Bug#9498).
1813 (selection_data_to_lisp_data): Assume incoming selection data are
1814 signed integers, not unsigned. This is to be consistent with
1815 outgoing selection data, which was modified to use signed integers
1816 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1817 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1818 expects long, not unsigned long.
1819
1820 2011-09-14 Eli Zaretskii <eliz@gnu.org>
1821
1822 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1823 computation of loop end. Reported by Johan Bockgård
1824 <bojohan@gnu.org>.
1825
1826 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
1827
1828 * frame.c (Fother_visible_frames_p): Function deleted.
1829
1830 2011-09-12 Eli Zaretskii <eliz@gnu.org>
1831
1832 * indent.c (compute_motion): Process display vector front to back
1833 rather than the other way around. (Bug#2496)
1834
1835 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1836
1837 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1838
1839 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
1840
1841 * minibuf.c (Fread_from_minibuffer): Doc fix.
1842
1843 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1844
1845 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1846 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1847
1848 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1849
1850 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1851 value for non-existent files.
1852
1853 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1854
1855 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1856 set its "size" to -1. This will set the modtime_size field of
1857 the corresponding buffer to -1, which is what
1858 verify-visited-file-modtime expects for files that do not exist.
1859 (Bug#9139)
1860
1861 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1862
1863 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1864 here ...
1865 * lisp.h: ... from here. push_key_description is no longer
1866 defined in keyboard.c, so its declaration should not be in
1867 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1868 logically belongs with push_key_description.
1869
1870 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1871
1872 * buffer.h: Include <sys/types.h> instead of <time.h>.
1873 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1874 Problem reported by Herbert J. Skuhra.
1875
1876 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1877
1878 * xml.c (parse_region): Make the parsing work for
1879 non-comment-starting XML files again (bug#9144).
1880
1881 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1882
1883 * image.c (gif_load): Fix calculation of bottom and right corner.
1884 (Bug#9468)
1885
1886 2011-09-10 Eli Zaretskii <eliz@gnu.org>
1887
1888 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1889 redisplay in small windows.
1890
1891 2011-09-09 Eli Zaretskii <eliz@gnu.org>
1892
1893 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1894
1895 2011-09-08 Martin Rudalics <rudalics@gmx.at>
1896
1897 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1898 Operate on live windows only.
1899
1900 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
1901
1902 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1903
1904 2011-09-07 Eli Zaretskii <eliz@gnu.org>
1905
1906 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1907 only under bidi iteration.
1908
1909 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1910
1911 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1912
1913 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1914
1915 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1916 Without this fix, the command to link temacs failed due to an
1917 undefined symbol __builtin_isnan. This is because
1918 /usr/include/iso/math_c99.h #defines isnan(x) to
1919 __builtin_isnan(x), but the bundled gcc, which identifies itself
1920 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1921 a __builtin_isnan.
1922 * floatfns.c (isnan): #undef, and then #define to a clone of
1923 what's in data.c.
1924 (Fisnan): Always define, since it's always available now.
1925 (syms_of_floatfns): Always define isnan at the Lisp level.
1926
1927 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1928
1929 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1930
1931 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1932
1933 * fileio.c: Fix bugs with large file offsets (Bug#9428).
1934 The previous code assumed that file offsets (off_t values) fit in
1935 EMACS_INT variables, which is not true on typical 32-bit hosts.
1936 The code messed up by falsely reporting buffer overflow in cases
1937 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1938 when "big" contains more than 2**29 bytes, even though this
1939 inserts just one byte and does not overflow the buffer.
1940 (Finsert_file_contents): Store file offsets as off_t
1941 values, not as EMACS_INT values. Check for overflow when
1942 converting between EMACS_INT and off_t. When checking for
1943 buffer overflow or for overlap, take the offsets into account.
1944 Don't use EMACS_INT for small values where int suffices.
1945 When checking for overlap, fix a typo: ZV was used where
1946 ZV_BYTE was intended.
1947 (Fwrite_region): Don't assume off_t fits into 'long'.
1948 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1949
1950 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
1951
1952 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1953
1954 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1955
1956 sprintf-related integer and memory overflow issues (Bug#9412).
1957
1958 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
1959 (esprintf, exprintf, evxprintf): New functions.
1960 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
1961 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
1962 (modify_event_symbol): Do not assume that the length of
1963 name_alist_or_stem is safe to alloca and fits in int.
1964 (Fexecute_extended_command): Likewise for function name and binding.
1965 (Frecursion_depth): Wrap around reliably on integer overflow.
1966 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1967 since some callers pass EMACS_INT values.
1968 (Fsingle_key_description): Don't crash if symbol name contains more
1969 than MAX_ALLOCA bytes.
1970 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1971 (get_minibuffer): Arg is now EMACS_INT, not int.
1972 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
1973 (esprintf, exprintf, evxprintf): New decls.
1974 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1975
1976 * dbusbind.c (signature_cat): New function.
1977 (xd_signature, Fdbus_register_signal):
1978 Do not overrun buffer; instead, report string overflow.
1979
1980 * dispnew.c (add_window_display_history): Don't overrun buffer.
1981 Truncate instead; this is OK since it's just a log.
1982
1983 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1984 even if the time zone offset is outlandishly large.
1985 Don't mishandle offset == INT_MIN.
1986
1987 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1988 when creating daemon; the previous buffer-overflow check was incorrect.
1989
1990 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1991 which has the guts of the old verror function.
1992
1993 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1994 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1995
1996 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1997 (font_unparse_xlfd): Don't blindly alloca long strings.
1998 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
1999 fits in int, when using sprintf. Use single snprintf to count
2000 length of string rather than counting it via multiple sprintfs;
2001 that's simpler and more reliable.
2002 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2003 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2004 sprintf, in case result does not fit in int.
2005
2006 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2007 (fontset_from_font): Print it.
2008
2009 * frame.c (tty_frame_count): Now printmax_t, not int.
2010 (make_terminal_frame, set_term_frame_name): Print it.
2011 (x_report_frame_params): In X, window IDs are unsigned long,
2012 not signed long, so print them as unsigned.
2013 (validate_x_resource_name): Check for implausibly long names,
2014 and don't assume name length fits in 'int'.
2015 (x_get_resource_string): Don't blindly alloca invocation name;
2016 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2017 not fit in int.
2018
2019 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2020 (xg_check_special_colors, xg_set_geometry):
2021 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2022
2023 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2024 Use esprintf, not sprintf, in case result does not fit in int.
2025
2026 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2027 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2028 it as a large positive number.
2029 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2030 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2031
2032 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2033 in case result does not fit in int.
2034
2035 * print.c (float_to_string): Detect width overflow more reliably.
2036 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2037 buffer overrun. Don't assume list length fits in 'int'. Treat
2038 print length of 0 as 0, not as infinity; to be consistent with other
2039 uses of print length in this function. Don't overflow print length
2040 index. Don't assume hash table size fits in 'long', or that
2041 vectorlike size fits in 'unsigned long'.
2042
2043 * process.c (make_process): Use printmax_t, not int, to format
2044 process-name gensyms.
2045
2046 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2047
2048 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2049 to avoid potential buffer overrun.
2050
2051 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2052 if X resource line is longer than 512 bytes.
2053
2054 * xfns.c (x_window): Make sprintf buffer a bit bigger
2055 to avoid potential buffer overrun.
2056
2057 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2058
2059 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2060
2061 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2062
2063 Integer overflow fixes for scrolling, etc.
2064 Without these, Emacs silently mishandles large integers sometimes.
2065 For example, "C-u 4294967297 M-x recenter" was treated as if
2066 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2067
2068 * xdisp.c (try_window_id): Check Emacs fixnum range before
2069 converting to 'int'.
2070
2071 * window.c (window_scroll_line_based, Frecenter):
2072 Check that an Emacs fixnum is in range before assigning it to 'int'.
2073 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2074 values converted from Emacs fixnums.
2075 (Frecenter): Don't wrap around a line count if it is out of 'int'
2076 range; instead, treat it as an extreme value.
2077 (Fset_window_configuration, compare_window_configurations):
2078 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2079
2080 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2081 that can exceed INT_MAX. Check that EMACS_INT value is in range
2082 before assigning it to the (possibly-narrower) index.
2083 (match_limit): Don't assume that a fixnum can fit in 'int'.
2084
2085 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2086 exceed INT_MAX.
2087
2088 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2089 (Fvertical_motion): Don't wrap around LINES values that don't fit
2090 in 'int'. Instead, treat them as extreme values. This is good
2091 enough for windows, which can't have more than INT_MAX lines anyway.
2092
2093 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2094
2095 * Require libxml/parser.h to avoid compilation warning.
2096
2097 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2098
2099 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2100 since this reportedly can destroy thread storage.
2101
2102 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2103
2104 * syntax.c (find_defun_start): Update all cache variables if
2105 exiting early (Bug#9401).
2106
2107 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2108
2109 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2110
2111 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2112 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2113 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2114
2115 * term.c (tty_append_glyph): New function.
2116 (produce_stretch_glyph): Static function and its prototype deleted.
2117
2118 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2119 Add prototypes.
2120
2121 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2122
2123 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2124 when checking :margin (Bug#9390).
2125 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2126 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2127 so that the name doesn't mislead. All uses changed.
2128
2129 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2130
2131 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2132 set_tty_hooks.
2133
2134 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2135
2136 * xdisp.c (move_it_to): Don't bail out early when reaching
2137 position beyond to_charpos, if we are scanning backwards.
2138 (move_it_vertically_backward): When DY == 0, make sure we get to
2139 the first character in the line after the newline.
2140
2141 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2142
2143 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2144 (ccl_driver): Do not generate an out-of-range pointer.
2145 (Fccl_execute_on_string): Remove unnecessary check for
2146 integer overflow, noted by Stefan Monnier in
2147 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2148 Remove a FIXME that didn't need fixing.
2149 Simplify the newly-introduced buffer reallocation code.
2150
2151 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2152
2153 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2154
2155 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2156
2157 Integer and memory overflow issues (Bug#9196).
2158
2159 * doc.c (get_doc_string): Rework so that
2160 get_doc_string_buffer_size is the actual buffer size, rather than
2161 being 1 less than the actual buffer size; this makes xpalloc more
2162 convenient.
2163
2164 * image.c (x_allocate_bitmap_record, cache_image):
2165 * xselect.c (Fx_register_dnd_atom):
2166 Simplify previous changes by using xpalloc.
2167
2168 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2169 since either will do and ptrdiff_t is convenient with xpalloc.
2170
2171 * charset.c (charset_table_size)
2172 (struct charset_sort_data.priority): Now ptrdiff_t.
2173 (charset_compare): Don't overflow if priorities differ greatly.
2174 (Fsort_charsets): Don't assume list length fits in int.
2175 Check for size-calculation overflow when allocating sort data.
2176 (syms_of_charset): Allocate an initial charset table that is
2177 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2178
2179 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2180
2181 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2182 The actual value is always <= INT_MAX, and leaving it unsigned made
2183 overflow checking harder.
2184
2185 * dispextern.h (struct glyph_matrix.rows_allocated)
2186 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2187 with xpalloc. The values are still always <= INT_MAX.
2188
2189 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2190
2191 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2192 (SAFE_NALLOCA): New macro.
2193
2194 * region-cache.c (struct boundary.pos, find_cache_boundary)
2195 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2196 (set_cache_region, invalidate_region_cache)
2197 (revalidate_region_cache, know_region_cache, region_cache_forward)
2198 (region_cache_backward, pp_cache):
2199 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2200 so that ptrdiff_t * can be passed to xpalloc.
2201 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2202 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2203 (pp_cache): Don't assume cache_len fits in int.
2204 * region-cache.h: Adjust extern decls to match.
2205
2206 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2207 EMACS_INT, since either will do, for xpalloc.
2208
2209 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2210 (xnmalloc, xnrealloc, xpalloc): New functions.
2211
2212 * bidi.c (bidi_shelve_header_size): New constant.
2213 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2214 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2215
2216 * bidi.c (bidi_cache_shrink):
2217 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2218 (overlay_strings):
2219 Don't update size of array until after memory allocation succeeds,
2220 because xmalloc/xrealloc may not return.
2221 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2222 now that we have proper integer overflow checking.
2223 (record_overlay_string, overlay_strings): Catch overflows when
2224 calculating size of overlay_str_buf.
2225
2226 * callproc.c (Fcall_process): Check for size overflow when
2227 calculating size of args2.
2228 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2229 Normally we prefer signed values, but sticking with ptrdiff_t would
2230 require adding more-complicated checks.
2231
2232 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2233 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2234 Redo buffer-overflow calculations to avoid integer overflow.
2235 Add a FIXME comment where memory seems to be over-allocated.
2236
2237 * character.c (Fstring): Check for size-calculation overflow.
2238
2239 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2240 unnecessary integer overflow. Check for size overflow.
2241 (encode_coding_object): Don't update size until xmalloc succeeds.
2242
2243 * composite.c (get_composition_id): Check for overflow in glyph
2244 length calculations.
2245
2246 Integer and memory overflow fixes for display code.
2247 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2248 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2249 (scrolling_window): Check for overflow in size calculations.
2250 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2251 Don't assume glyph table len fits in int.
2252 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2253 (row_table_size): Now ptrdiff_t, not int.
2254 (scrolling_window): Avoid overflow in size calculations.
2255 Don't update size until allocation succeeds.
2256 * fns.c (concat): Check for overflow in size calculations.
2257 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2258 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2259 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2260
2261 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2262 (get_doc_string): Check for size calculation overflow.
2263 Don't update size until allocation succeeds.
2264 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2265 EMACS_INT, where ptrdiff_t will do.
2266 (Fsubstitute_command_keys): Check for string overflow.
2267
2268 * editfns.c (set_time_zone_rule): Don't assume environment length
2269 fits in int.
2270 (message_length): Now ptrdiff_t, not int.
2271 (Fmessage_box): Don't update size until allocation succeeds.
2272 Don't assume message length fits in int.
2273 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2274
2275 * emacs.c (main): Do not reallocate argv, since there is a null at
2276 the end that can be overwritten, and this way there's no need to
2277 worry about size-calculation overflow.
2278 (sort_args): Check for size-calculation overflow.
2279
2280 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2281 alloc succeeds.
2282 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2283
2284 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2285 (x_set_scroll_bar_width, x_figure_window_size):
2286 Check for integer overflow.
2287 (x_set_alpha): Do not assume XINT fits in int.
2288
2289 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2290 This is for the members text_lines, text_cols, total_lines, total_cols,
2291 where the system imposes an 'int' limit.
2292
2293 * fringe.c (Fdefine_fringe_bitmap):
2294 Don't update size until alloc works.
2295
2296 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2297 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2298
2299 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2300 Check for size-calculation overflow.
2301 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2302 do, as we prefer signed integers.
2303 (id_to_widget.max_size, id_to_widget.used)
2304 (xg_store_widget_in_map, xg_remove_widget_from_map)
2305 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2306 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2307 Use and return ptrdiff_t, not int.
2308 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2309 * gtkutil.h: Change prototypes to match the above.
2310
2311 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2312 are duplicate now that they've been promoted to lisp.h.
2313 (x_allocate_bitmap_record, x_alloc_image_color)
2314 (make_image_cache, cache_image, xpm_load):
2315 Don't update size until alloc is done.
2316 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2317 (x_detect_edges):
2318 Check for size calculation overflow.
2319 (ct_colors_allocated_max): New constant.
2320 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2321 overflow.
2322
2323 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2324 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2325 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2326 Use ptrdiff_t, not int, to count maps.
2327 (read_char_minibuf_menu_prompt): Check for overflow in size
2328 calculations. Don't update size until allocation succeeds.
2329 Redo calculations to avoid overflow.
2330 * keyboard.h: Change prototypes to match the above.
2331
2332 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2333 to count maps.
2334 (current_minor_maps): Check for size calculation overflow.
2335 * keymap.h: Change prototypes to match the above.
2336
2337 * lread.c (read1, init_obarray): Don't update size until alloc done.
2338
2339 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2340 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2341
2342 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2343 Now ptrdiff_t, not int.
2344 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2345 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2346
2347 * process.c (Fnetwork_interface_list): Check for overflow
2348 in size calculation.
2349
2350 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2351
2352 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2353 overflow. Don't bother calling xmalloc when xrealloc will do.
2354
2355 * search.c (Freplace_match): Check for size calculation overflow.
2356 (Fset_match_data): Don't assume list lengths fit in 'int'.
2357
2358 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2359 for command line length. Do not attempt to address one before the
2360 beginning of an array, as that's not portable.
2361
2362 * term.c (max_frame_lines): Remove; unused.
2363 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2364 not int.
2365 (encode_terminal_code, calculate_costs): Check for size
2366 calculation overflow.
2367 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2368 table lengths and related sizes. Don't update size until alloc
2369 done. Redo calculations to avoid overflow.
2370 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2371
2372 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2373 subtracting pointers.
2374 (gobble_line): Check for overflow more carefully. Don't update size
2375 until alloc done.
2376
2377 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2378 Don't update size until alloc done.
2379 Redo size calculations to avoid overflow.
2380 Check for size calculation overflow.
2381 (main) [DEBUG]: Fix typo in invoking tparam1.
2382
2383 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2384 Use ptrdiff_t, not int, for sizes.
2385 (store_mode_line_noprop_char): Don't update size until alloc done.
2386
2387 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2388 Use ptrdiff_t, not int, for sizes.
2389 (Finternal_make_lisp_face, cache_face):
2390 Check for size calculation overflow.
2391 (cache_face): Treat size calculation overflows as if they were
2392 memory exhaustion (the usual treatment), rather than aborting.
2393
2394 * xfns.c (x_encode_text, x_set_name_internal)
2395 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2396 sizes, since they can exceed INT_MAX in size. Check for size
2397 calculation overflow.
2398
2399 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2400 (xg_select): Check for size calculation overflow.
2401 Don't update size until alloc done.
2402
2403 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2404 as sprintf is limited to int lengths.
2405
2406 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2407 (X_LONG_MIN): New macros.
2408 Use them to make the following changes clearer.
2409 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2410 This change doesn't affect the value now, but it may help remind
2411 future maintainers not to raise the value too much later.
2412 (SELECTION_QUANTUM): Remove, replacing with ...
2413 (selection_quantum): ... new function, which avoids overflow.
2414 All uses changed.
2415 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2416 assumption that selection length fits in 'int'.
2417 (x_reply_selection_request, x_handle_selection_request)
2418 (x_get_window_property, receive_incremental_selection)
2419 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2420 (lisp_data_to_selection_data, clean_local_selection_data):
2421 Use ptrdiff_t, not int, to record length of selection.
2422 (x_reply_selection_request, x_get_window_property)
2423 (receive_incremental_selection, x_property_data_to_lisp):
2424 Redo calculations to avoid overflow.
2425 (x_reply_selection_request): When sending hint, ceiling it at
2426 X_LONG_MAX rather than relying on wraparound overflow to send
2427 something.
2428 (x_get_window_property, receive_incremental_selection)
2429 (lisp_data_to_selection_data, x_property_data_to_lisp):
2430 Check for size-calculation overflow.
2431 (x_get_window_property, receive_incremental_selection)
2432 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2433 Don't store size until memory allocation succeeds.
2434 (x_get_window_property): Plug memory leak on memory exhaustion.
2435 Don't double-block input; malloc is safe here. Don't assume 2**34
2436 - 4 fits in unsigned long. Add an xassert to check
2437 XGetWindowProperty overflow. Be more careful about overflow
2438 calculations, and distinguish size from memory overflow better.
2439 (receive_incremental_selection): When tracing, don't assume
2440 unsigned int is less than INT_MAX.
2441 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2442 harmful) conversions of unsigned short to int.
2443 (lisp_data_to_selection_data): Don't assume that integers
2444 in the range -65535 through -1 fit in an X unsigned short.
2445 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2446 result parameters unless successful. Rely on cons_to_unsigned
2447 to report problems with elements; the old code wasn't right anyway.
2448 (x_check_property_data): Check for int overflow; we cannot use
2449 a wider type due to X limits.
2450 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2451
2452 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2453
2454 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2455 (x_term_init): Check for size calculation overflow.
2456 (x_color_cells): Don't store size until memory allocation succeeds.
2457 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2458 Don't assume alloca size is less than MAX_ALLOCA.
2459 (x_term_init): Don't assume length fits in int (sprintf is limited
2460 to int size).
2461
2462 Use ptrdiff_t for composition IDs.
2463 * character.c (lisp_string_width):
2464 * composite.c (composition_table_size, n_compositions)
2465 (get_composition_id, composition_gstring_from_id):
2466 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2467 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2468 * window.c (Frecenter):
2469 Use ptrdiff_t, not int, for composition IDs.
2470 * composite.c (get_composition_id): Check for integer overflow.
2471 * composite.h: Adjust prototypes to match the above changes.
2472
2473 Use ptrdiff_t for hash table indexes.
2474 * category.c (hash_get_category_set):
2475 * ccl.c (ccl_driver):
2476 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2477 * coding.c (coding_system_charset_list, detect_coding_system):
2478 * coding.h (struct coding_system.id):
2479 * composite.c (get_composition_id, gstring_lookup_cache):
2480 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2481 * image.c (xpm_get_color_table_h):
2482 * lisp.h (hash_lookup, hash_put):
2483 * minibuf.c (Ftest_completion):
2484 Use ptrdiff_t for hash table indexes, not int (which is too
2485 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2486 32-bit --with-wide-int hosts).
2487
2488 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2489 Add a FIXME comment about memory leaks.
2490 (syms_of_charset): Don't assume xmalloc returns.
2491
2492 Don't assume that stated character widths fit in int.
2493 * character.c (Fchar_width, c_string_width, lisp_string_width):
2494 * character.h (CHAR_WIDTH):
2495 * indent.c (MULTIBYTE_BYTES_WIDTH):
2496 Use sanitize_char_width to avoid undefined and/or bad behavior
2497 with outlandish widths.
2498 * character.h (sanitize_tab_width): Rename from sanitize_width,
2499 now that we have two such functions. All uses changed.
2500 (sanitize_char_width): New inline function.
2501
2502 Don't assume that tab-width fits in int.
2503 * character.h (sanitize_width): New inline function.
2504 (SANE_TAB_WIDTH): New macro.
2505 (ASCII_CHAR_WIDTH): Use it.
2506 * indent.c (sane_tab_width): Remove. All uses replaced by
2507 SANE_TAB_WIDTH (current_buffer).
2508 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2509
2510 * fileio.c: Integer overflow issues with file modes.
2511 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2512
2513 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2514 Remove unreachable code.
2515 (read_hex, load_charset_map_from_file): Check for integer overflow.
2516
2517 * xterm.c: don't go over XClientMessageEvent limit
2518 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2519 (x_send_scroll_bar_event): Likewise. Check that the size does not
2520 exceed limits imposed by XClientMessageEvent, as well as the usual
2521 ptrdiff_t and size_t limits.
2522
2523 * keyboard.c: Overflow, signedness and related fixes.
2524 (make_lispy_movement): Use same integer type in forward decl
2525 that is used in the definition.
2526 (read_key_sequence, keyremap_step):
2527 Change bufsize argument back to int, undoing my 2011-03-30 change.
2528 We prefer signed types, and int is wide enough here.
2529 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2530 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2531 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2532 length, not size_t. Use ptrdiff_t for index, not int.
2533 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2534 possibility of integer overflow.
2535
2536 Overflow, signedness and related fixes for images.
2537
2538 * dispextern.h (struct it.stack[0].u.image.image_id)
2539 (struct_it.image_id, struct image.id, struct image_cache.size)
2540 (struct image_cache.used, struct image_cache.ref_count):
2541 * gtkutil.c (update_frame_tool_bar):
2542 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2543 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2544 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2545 * nsmenu.m (update_frame_tool_bar):
2546 * xdisp.c (calc_pixel_width_or_height):
2547 * xfns.c (image_cache_refcount):
2548 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2549 on typical 64-bit hosts.
2550
2551 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2552 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2553 Omit unnecessary casts to int.
2554 (parse_image_spec): Check that integers fall into 'int' range
2555 when the callers expect that.
2556 (image_ascent): Redo ascent calculation to avoid int overflow.
2557 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2558 (lookup_image): Remove unnecessary tests.
2559 (xbm_image_p): Locals are now of int, not EMACS_INT,
2560 since parse_image_check makes sure they fit into int.
2561 (png_load, gif_load, svg_load_image):
2562 Prefer int to unsigned where either will do.
2563 (tiff_handler): New function, combining the cores of the
2564 old tiff_error_handler and tiff_warning_handler.
2565 This function is rewritten to use vsnprintf and thereby avoid
2566 stack buffer overflows. It uses only the features of vsnprintf
2567 that are common to both POSIX and native Microsoft.
2568 (tiff_error_handler, tiff_warning_handler): Use it.
2569 (tiff_load, gif_load, imagemagick_load_image):
2570 Don't assume :index value fits in 'int'.
2571 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2572 (imagemagick_load_image): Check that crop parameters fit into
2573 the integer types that MagickCropImage accepts. Don't assume
2574 Vimagemagick_render_type has a nonnegative value. Don't assume
2575 size_t fits in 'long'.
2576 (gs_load): Use printmax_t to print the widest integers possible.
2577 Check for integer overflow when computing image height and width.
2578
2579 2011-08-26 Eli Zaretskii <eliz@gnu.org>
2580
2581 * xdisp.c (redisplay_window): Don't force window start if point
2582 will be invisible in the resulting window. (Bug#9324)
2583
2584 2011-08-25 Eli Zaretskii <eliz@gnu.org>
2585
2586 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2587 the display spec is of the form `(space ...)'.
2588 (handle_display_spec): Return the value returned by
2589 handle_single_display_spec, not just 1 or zero.
2590 (handle_single_display_spec): If the display spec is of the form
2591 `(space ...)', and specifies display in the text area, return 2
2592 rather than 1.
2593 (try_cursor_movement): Check for the need to scroll more
2594 accurately, and prefer exact match for point under bidi.
2595 Don't advance `row' beyond the last row of the window.
2596
2597 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2598 into disp_prop; all users changed.
2599
2600 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2601 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2602 for the text covered by the display property.
2603
2604 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
2605
2606 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2607 Change return value to nil.
2608 (Frecord_buffer): Delete unused function.
2609
2610 2011-08-24 Eli Zaretskii <eliz@gnu.org>
2611
2612 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2613 buffers, return left-to-right.
2614 (set_cursor_from_row): Consider candidate row a win if its glyph
2615 represents a newline and point is on that newline. Fixes cursor
2616 positioning on the newline at EOL of R2L text within L2R
2617 paragraph, and vice versa.
2618 (try_cursor_movement): Check continued rows, in addition to
2619 continuation rows. Fixes unwarranted scroll when point enters a
2620 continued line of R2L text within an L2R paragraph, or vice versa.
2621 (cursor_row_p): Consider the case of point being equal to
2622 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2623 from the end of a short line to the beginning of a continued line
2624 of R2L text within L2R paragraph.
2625 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2626 composed characters.
2627
2628 * bidi.c (bidi_check_type): Use xassert.
2629 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2630 members.
2631
2632 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2633
2634 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2635 a character.
2636
2637 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
2638
2639 * nsfont.m (ns_otf_to_script): Fix typo.
2640
2641 2011-08-22 Kenichi Handa <handa@m17n.org>
2642
2643 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2644 extra slot even if the purpose is char-code-property-table.
2645
2646 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2647
2648 * xdisp.c (redisplay_window): When computing centering_position,
2649 account for the height of the header line. (Bug#8874)
2650
2651 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2652 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2653 candidate is selected by the mouse, and that candidate has a
2654 composed character under the mouse.
2655
2656 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2657 coordinates reported by pos-visible-in-window-p for a composed
2658 character in column zero.
2659
2660 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2661
2662 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2663
2664 2011-08-22 Eli Zaretskii <eliz@gnu.org>
2665
2666 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2667 consider it a hit if to_charpos is anywhere in the range of the
2668 composed buffer positions.
2669
2670 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
2671
2672 * image.c (gif_load): Don't assume that each subimage has the same
2673 dimensions as the base image. Handle disposal method that is
2674 "undefined" by the gif spec (Bug#9335).
2675
2676 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
2677
2678 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
2679 (Fcondition_case): Document `debug' symbol in error handler.
2680
2681 2011-08-19 Eli Zaretskii <eliz@gnu.org>
2682
2683 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2684 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2685 from an Org mode buffer to a Speedbar frame.
2686
2687 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2688 a composition, take its buffer position from IT->cmp_it.charpos.
2689 Fixes cursor positioning at the beginning of a line that begins
2690 with a composed character.
2691
2692 2011-08-18 Eli Zaretskii <eliz@gnu.org>
2693
2694 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2695 character bidirectional type, use STRONG_L instead. Fixes crashes
2696 in a buffer produced by `describe-categories'.
2697
2698 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2699 members before the level stack, so they would be saved and
2700 restored when copying iterator state. Fixes incorrect reordering
2701 around TABs covered by display properties.
2702
2703 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2704
2705 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
2706
2707 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
2708
2709 * eval.c (internal_condition_case, internal_condition_case_1)
2710 (internal_condition_case_2, internal_condition_case_n):
2711 Remove unnecessary aborts (Bug#9081).
2712
2713 2011-08-17 Eli Zaretskii <eliz@gnu.org>
2714
2715 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2716 has no `load' handler, try opening the file locally. (Bug#9311)
2717
2718 2011-08-16 Ken Brown <kbrown@cornell.edu>
2719
2720 * gmalloc.c: Expand comment.
2721
2722 2011-08-16 Eli Zaretskii <eliz@gnu.org>
2723
2724 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2725 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2726
2727 2011-08-16 Ken Brown <kbrown@cornell.edu>
2728
2729 Fix memory allocation problems in Cygwin build (Bug#9273).
2730
2731 * unexcw.c ( __malloc_initialized): Declare external variable.
2732 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2733
2734 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2735 New variables.
2736 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2737 dumped emacs.
2738 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2739 in the static heap.
2740 [CYGWIN] (special_realloc): New function.
2741 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2742 requests to realloc storage in the static heap.
2743
2744 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2745
2746 * bidi.c (bidi_initialize): Remove unused local.
2747
2748 2011-08-15 Eli Zaretskii <eliz@gnu.org>
2749
2750 * bidimirror.h:
2751 * biditype.h: Remove file.
2752 * makefile.w32-in ($(BLD)/bidi.$(O)):
2753 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
2754
2755 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2756
2757 * chartab.c: Improve commentary for the uniprop_table API.
2758
2759 * bidi.c (bidi_paragraph_init): Support zero value of
2760 bidi_ignore_explicit_marks_for_paragraph_level.
2761 (bidi_initialize): Use uniprop_table instead of including
2762 biditype.h and bidimirror.h.
2763
2764 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2765 coordinates of the iterator when restoring from ppos_it.
2766 (Bug#9296)
2767
2768 2011-08-14 Kenichi Handa <handa@m17n.org>
2769
2770 * process.c (create_process): Call setup_process_coding_systems
2771 after the pid of the process is set to -1 (Bug#8162).
2772
2773 2011-08-14 Eli Zaretskii <eliz@gnu.org>
2774
2775 * xdisp.c (move_it_in_display_line_to): Don't invoke
2776 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2777 ppos_it. Fixes vertical cursor motion when line beginning is
2778 covered by an image. (Bug#9296)
2779
2780 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2781
2782 * nsterm.h (ns_run_ascript): Declare.
2783 (NSAPP_DATA2_RUNASSCRIPT): Define.
2784
2785 * nsfns.m (as_script, as_result, as_status): New static variables.
2786 (ns_run_ascript): New function.
2787 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
2788 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2789 the event loop. Get status from as_status (Bug#7276).
2790
2791 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2792 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2793 the event loop (Bug#7276).
2794
2795 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2796
2797 * gnutls.c (QCgnutls_bootprop_priority)
2798 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2799 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2800 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2801 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2802 (QCgnutls_bootprop_verify_hostname_error)
2803 (QCgnutls_bootprop_callbacks_verify): Rename from
2804 Qgnutls_bootprop_..., all uses changed.
2805
2806 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2807 uses changed.
2808
2809 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2810
2811 * xfaces.c (Qframe_set_background_mode): Now static.
2812 * dispextern.h (Qframe_set_background_mode): Remove decl.
2813
2814 * process.c (Fnetwork_interface_info): Declare local only if needed.
2815
2816 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2817
2818 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2819 (Fnetwork_interface_list): Allocate in increments of bytes instead
2820 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2821 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2822 sockaddr.
2823 (struct ifflag_def): notrailers is smart on OSX.
2824 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2825 Get hardware address with getifaddrs if available.
2826
2827 2011-08-12 Eli Zaretskii <eliz@gnu.org>
2828
2829 * xdisp.c (iterate_out_of_display_property): xassert that
2830 IT->position is set to within IT->object's boundaries. Break from
2831 the loop as soon as EOB is reached; avoids infloops in redisplay
2832 when IT->position is set up wrongly due to some bug.
2833 Set IT->current to match the bidi iterator unconditionally.
2834 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2835 entry. Force push_it to save on the stack the current
2836 buffer/string position, to be restored by pop_it. Fix flags in
2837 the iterator structure wrt the object coming from a display
2838 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2839 properties. (Bug#9284)
2840
2841 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
2842
2843 * fontset.c (fontset_get_font_group): Add proper type checks.
2844 (Bug#9172)
2845
2846 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2847
2848 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2849 and LC_VERSION_MIN_MACOSX.
2850 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2851 (dump_it) [LC_FUNCTION_STARTS]: Use it.
2852
2853 2011-08-08 Eli Zaretskii <eliz@gnu.org>
2854
2855 * xdisp.c (forward_to_next_line_start): Allow to use the
2856 no-display-properties-and-no-overlays under bidi display.
2857 Set disp_pos in the bidi iterator to avoid searches for display
2858 properties and overlays.
2859
2860 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
2861
2862 * editfns.c (Fset_time_zone_rule): Document relationship with the
2863 setenv function.
2864
2865 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2866 the font entity extracted from the cache (Bug#8109).
2867
2868 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
2869
2870 * composite.c (autocmp_chars): Don't reset point. That is done by
2871 restore_point_unwind (Bug#5984).
2872
2873 2011-08-07 Juri Linkov <juri@jurta.org>
2874
2875 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2876 to show the arg `TIME' instead of `TIMEVAL'.
2877
2878 2011-08-06 Eli Zaretskii <eliz@gnu.org>
2879
2880 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2881 display property strides EOL and includes a newline, as in
2882 longlines-mode. (Bug#9254)
2883 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2884 word-wrap under bidirectional display. (Bug#9224)
2885
2886 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2887 is non-zero, even if the data buffer is NULL. Fixes a crash in
2888 vertical-motion with longlines-mode. (Bug#9254)
2889
2890 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2891
2892 * bidi.c <bidi_cache_total_alloc>: Now static.
2893 (bidi_initialize): Initialize bidi_cache_total_alloc.
2894
2895 * xdisp.c (display_line): Release buffer allocated for shelved bidi
2896 cache. (Bug#9221)
2897
2898 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2899 amount allocated this far in `bidi_cache_total_alloc'.
2900 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2901 non-zero, only free the data buffer without restoring the cache
2902 contents. All callers changed.
2903
2904 * dispextern.h (bidi_unshelve_cache): Update prototype.
2905
2906 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2907 (move_it_in_display_line, move_it_to)
2908 (move_it_vertically_backward, move_it_by_lines): Replace the call
2909 to xfree to an equivalent call to bidi_unshelve_cache.
2910 (move_it_in_display_line_to): Fix logic of returning
2911 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
2912
2913 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2914
2915 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2916 came from a string character with a `cursor' property. (Bug#9229)
2917
2918 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2919
2920 * Makefile.in (LIB_PTHREAD): New variable.
2921 (LIBES): Add LIB_PTHREAD (Bug#9216).
2922
2923 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2924 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2925
2926 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2927
2928 * regex.c (re_iswctype): Remove some redundant boolean conversions.
2929
2930 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2931
2932 * xterm.c (x_find_topmost_parent): New function.
2933 (x_set_frame_alpha): Find topmost parent window with
2934 x_find_topmost_parent and set the property there also (bug#9181).
2935 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2936
2937 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2938
2939 * callproc.c (Fcall_process): Avoid vfork clobbering
2940 the local vars buffer, coding_systems, current_dir.
2941
2942 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2943
2944 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2945
2946 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2947
2948 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2949 so that it is not optimized away.
2950
2951 * xdisp.c (compute_display_string_pos): Remove unused local.
2952
2953 2011-08-02 Eli Zaretskii <eliz@gnu.org>
2954
2955 Fix slow cursor motion and scrolling in large buffers with
2956 selective display, like Org Mode buffers. (Bug#9218)
2957
2958 * dispextern.h (struct bidi_it): New member disp_prop_p.
2959
2960 * xdisp.c: Remove one-slot cache of display string positions.
2961 (compute_display_string_pos): Accept an additional argument
2962 DISP_PROP_P; callers changed. Scan at most 5K characters forward
2963 for a display string or property. If found, set DISP_PROP_P
2964 non-zero.
2965
2966 * bidi.c (bidi_fetch_char): Accept an additional argument
2967 DISP_PROP_P, and pass it to compute_display_string_pos.
2968 Only handle text covered by a display string if DISP_PROP_P is returned
2969 non-zero. All callers of bidi_fetch_char changed.
2970
2971 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2972
2973 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2974
2975 2010-12-03 Don March <don@ohspite.net>
2976
2977 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2978 last character M-[char] is translated to ESC [char] (bug#7541).
2979
2980 2011-08-02 Kenichi Handa <handa@m17n.org>
2981
2982 * lisp.h (uniprop_table): Extern it.
2983
2984 * chartab.c (uniprop_table): Make it non-static.
2985
2986 2011-08-01 Eli Zaretskii <eliz@gnu.org>
2987
2988 * xdisp.c (forward_to_next_line_start): Accept additional argument
2989 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2990 on the newline.
2991 (reseat_at_next_visible_line_start): Use the bidi iterator state
2992 returned by forward_to_next_line_start to restore the state of
2993 it->bidi_it after backing up to previous newline. (Bug#9212)
2994
2995 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2996
2997 * regex.c (re_comp): Protoize.
2998 (re_exec): Fix return type.
2999 (regexec): Fix type of `ret'. (Bug#9203)
3000
3001 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3002
3003 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3004 This is needed if max-image-size is a floating-point number.
3005
3006 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3007
3008 * print.c (print_object): Print empty symbol as ##.
3009
3010 * lread.c (read1): Read ## as empty symbol.
3011
3012 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3013
3014 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3015 setting frame foreground color (Bug#9175).
3016 (x_set_background_color): Likewise.
3017
3018 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3019 contents (Bug#9176).
3020 (EmacsTooltip -init): Remove bezels and add shadows to
3021 tooltip windows.
3022
3023 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3024 or scroll bar (Bug#8470).
3025
3026 * nsfont.m (nsfont_open): Remove assignment to voffset and
3027 unnecessary vars hshink, expand, hd, full_height, min_height.
3028 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3029
3030 * nsterm.h (nsfont_info): Remove voffset field.
3031
3032 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3033
3034 Implement strike-through and overline on NextStep (Bug#8863).
3035
3036 * nsfont.m (nsfont_open): Use underline position provided by font,
3037 instead of hard-coded value of 2.
3038 (nsfont_draw): Call ns_draw_text_decoration instead.
3039
3040 * nsterm.h: Add declaration for ns_draw_text_decoration.
3041
3042 * nsterm.m (ns_draw_text_decoration): New function for drawing
3043 underline, overline, and strike-through.
3044 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3045 ns_draw_text_decoration. Change treatment of cursor drawing to
3046 accommodate underlining, etc.
3047
3048 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3049
3050 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3051 default.
3052
3053 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3054
3055 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3056 Without this fix, if a signal arrives just after memory fills up,
3057 'malloc' might be invoked reentrantly.
3058
3059 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3060 In other words, assume that every image size is allowed, on non-X
3061 hosts. This assumption is probably wrong, but it lets Emacs compile.
3062
3063 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3064
3065 * regex.c (re_iswctype): Convert return values to boolean.
3066
3067 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3068
3069 * xdisp.c (compute_display_string_pos): Don't use cached display
3070 string position if the buffer had its restriction changed.
3071 (Bug#9184)
3072
3073 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3074
3075 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3076
3077 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3078
3079 Integer signedness and overflow and related fixes. (Bug#9079)
3080
3081 * bidi.c: Integer size and overflow fixes.
3082 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3083 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3084 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3085 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3086 (bidi_find_other_level_edge):
3087 Use ptrdiff_t instead of EMACS_INT where either will do.
3088 This works better on 32-bit hosts configured --with-wide-int.
3089 (bidi_cache_ensure_space): Check for size-calculation overflow.
3090 Use % rather than repeated addition, for better worst-case speed.
3091 Don't set bidi_cache_size until after xrealloc returns, because it
3092 might not return.
3093 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3094 (bidi_cache_ensure_space): Also check that the bidi cache size
3095 does not exceed that of the largest Lisp string or buffer. See Eli
3096 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3097
3098 * alloc.c (__malloc_size_t): Remove.
3099 All uses replaced by size_t. See Andreas Schwab's note
3100 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3101
3102 * image.c: Improve checking for integer overflow.
3103 (check_image_size): Assume that f is nonnull, since
3104 it is always nonnull in practice. This is one less thing to
3105 worry about when checking for integer overflow later.
3106 (x_check_image_size): New function, which checks for integer
3107 overflow issues inside X.
3108 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3109 This removes the need for a memory_full check.
3110 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3111 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3112 (xbm_read_bitmap_data): Change locals back to 'int', since
3113 their values must fit in 'int'.
3114 (xpm_load_image, png_load, tiff_load):
3115 Invoke x_create_x_image_and_pixmap earlier,
3116 to avoid much needless work if the image is too large.
3117 (tiff_load): Treat overly large images as if
3118 x_create_x_image_and_pixmap failed, not as malloc failures.
3119 (gs_load): Use x_check_image_size.
3120
3121 * gtkutil.c: Omit integer casts.
3122 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3123 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3124
3125 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3126
3127 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3128 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3129 would wrongly return t on a 64-bit host.
3130
3131 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3132 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3133 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3134 and therefore cause GCC to emit a bogus diagnostic in some cases.
3135
3136 * image.c: Integer signedness and overflow and related fixes.
3137 This is not an exhaustive set of fixes, but it's time to
3138 record what I've got.
3139 (lookup_pixel_color, check_image_size): Remove redundant decls.
3140 (check_image_size): Don't assume that arbitrary EMACS_INT values
3141 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3142 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3143 (tiff_load, imagemagick_load_image):
3144 Check for overflow in size calculations.
3145 (x_create_x_image_and_pixmap): Remove unnecessary test for
3146 xmalloc returning NULL; that can't happen.
3147 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3148 (xpm_color_bucket): Use better integer hashing function.
3149 (xpm_cache_color): Don't possibly over-allocate memory.
3150 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3151 (gif_memory_source):
3152 Use ptrdiff_t, not int or size_t, to record sizes.
3153 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3154 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3155 either works, as we prefer signed integers.
3156 (tiff_read_from_memory, tiff_write_from_memory):
3157 Return tsize_t, not size_t, since that's what the TIFF API wants.
3158 (tiff_read_from_memory): Don't fail simply because the read would
3159 go past EOF; instead, return a short read.
3160 (tiff_load): Omit no-longer-needed casts.
3161 (Fimagemagick_types): Don't assume size fits into 'int'.
3162
3163 Improve hashing quality when configured --with-wide-int.
3164 * fns.c (hash_string): New function, taken from sxhash_string.
3165 Do not discard information about ASCII character case; this
3166 discarding is no longer needed.
3167 (sxhash-string): Use it. Change sig to match it. Caller changed.
3168 * lisp.h: Declare it.
3169 * lread.c (hash_string): Remove, since we now use fns.c's version.
3170 The fns.c version returns a wider integer if --with-wide-int is
3171 specified, so this should help the quality of the hashing a bit.
3172
3173 * emacs.c: Integer overflow minor fix.
3174 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3175 Define only if GNU_LINUX.
3176 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3177
3178 * dispnew.c: Integer signedness and overflow fixes.
3179 Remove unnecessary forward decls, that were a maintenance hassle.
3180 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3181 All uses changed.
3182 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3183 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3184 (prepare_desired_row, line_draw_cost):
3185 Use int, not unsigned, where either works.
3186 (save_current_matrix, restore_current_matrix):
3187 Use ptrdiff_t, not size_t, where either works.
3188 (init_display): Check for overflow more accurately, and without
3189 relying on undefined behavior.
3190
3191 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3192 Remove, replacing with the new symbols in lisp.h. All uses changed.
3193 * fileio.c (make_temp_name):
3194 * filelock.c (lock_file_1, lock_file):
3195 * xdisp.c (message_dolog):
3196 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3197 Use pMd etc. instead.
3198 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3199 replacing the pWIDE etc. symbols removed from editfns.c.
3200
3201 * keyboard.h (num_input_events): Now uintmax_t.
3202 This is (very slightly) less likely to mess up due to wraparound.
3203 All uses changed.
3204
3205 * buffer.c: Integer signedness fixes.
3206 (alloc_buffer_text, enlarge_buffer_text):
3207 Use ptrdiff_t rather than size_t when either will do, as we prefer
3208 signed integers.
3209
3210 * alloc.c: Integer signedness and overflow fixes.
3211 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3212 (__malloc_size_t): Default to size_t, not to int.
3213 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3214 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3215 Prefer ptrdiff_t to size_t when either would do, as we prefer
3216 signed integers.
3217 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3218 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3219 Now const. Initialize with values that are in range even if char
3220 is signed.
3221 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3222 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3223 These functions do the right thing with sizes > 2**32.
3224 (check_depth): Now ptrdiff_t, not int.
3225 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3226 Adjust to new way of storing sizes. Check for size overflow bugs
3227 in rest of code.
3228 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3229 slightly wrong anyway, as it missed one instance of
3230 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3231 (refill_memory_reserve): Omit needless cast to size_t.
3232 (mark_object_loop_halt): Mark as externally visible.
3233
3234 * xselect.c: Integer signedness and overflow fixes.
3235 (Fx_register_dnd_atom, x_handle_dnd_message):
3236 Use ptrdiff_t, not size_t, since we prefer signed.
3237 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3238 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3239 x_dnd_atoms_size and x_dnd_atoms_length.
3240
3241 * doprnt.c: Prefer signed to unsigned when either works.
3242 * eval.c (verror):
3243 * doprnt.c (doprnt):
3244 * lisp.h (doprnt):
3245 * xdisp.c (vmessage):
3246 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3247 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3248 prefer signed arithmetic to avoid comparison confusion.
3249 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3250 but is a bit tricky.
3251
3252 Assume freestanding C89 headers, string.h, stdlib.h.
3253 * data.c, doprnt.c, floatfns.c, print.c:
3254 Include float.h unconditionally.
3255 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3256 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3257 * regex.c: Likewise for stddef.h, string.h.
3258 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3259 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3260 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3261 (STDC_HEADERS): Remove obsolete defines.
3262 * sysdep.c: Include limits.h unconditionally.
3263
3264 Assume support for memcmp, memcpy, memmove, memset.
3265 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3266 * regex.c (memcmp, memcpy):
3267 Remove; we assume C89 now.
3268
3269 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3270 (__malloc_safe_bcopy): Remove; no longer needed.
3271
3272 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3273 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3274 well either way, and we prefer signed to unsigned.
3275
3276 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3277
3278 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3279 closes the connection while we're reading (bug#9182).
3280
3281 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3282
3283 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3284 are specified (Bug#9168).
3285
3286 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3287
3288 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3289 Found by GCC static checking and --with-wide-int on a 32-bit host.
3290
3291 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3292
3293 * xdisp.c (compute_display_string_pos): Fix logic of caching
3294 previous display string position. Initialize cached_prev_pos to
3295 -1. Fixes slow-down at the beginning of a buffer.
3296
3297 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3298
3299 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3300 for attrs[LFACE_FONTSET_INDEX].
3301
3302 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3303
3304 * xml.c (parse_region): Remove unused local
3305 that was recently introduced.
3306
3307 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3308
3309 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3310 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3311
3312 * xdisp.c (move_it_in_display_line_to): Record the best matching
3313 position for TO_CHARPOS while scanning the line, and restore it on
3314 exit if none of the characters scanned was an exact match.
3315 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3316 when exact match is impossible due to invisible text, and the
3317 lines are truncated.
3318
3319 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3320
3321 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3322 for OSX >= 10.7.
3323
3324 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3325
3326 Fix a significant slow-down of cursor motion with C-n, C-p,
3327 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3328 auto-repeat under bidi redisplay in fontified buffers.
3329 * xdisp.c (compute_stop_pos_backwards): New function.
3330 (next_element_from_buffer): Call compute_stop_pos_backwards to
3331 find a suitable prev_stop when we find ourselves before
3332 base_level_stop.
3333 (reseat): Don't look for prev_stop, as that could mean a very long
3334 run.
3335 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3336 <cached_disp_overlay_modiff>: Cache for last found display string
3337 position.
3338 (compute_display_string_pos): Return the cached position if asked
3339 about the same buffer in the same area of character positions, and
3340 the buffer wasn't changed since the time the display string
3341 position was cached.
3342
3343 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3344
3345 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3346 is an integer, which is important for empty lines. (Bug#9149)
3347
3348 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3349
3350 * frame.c (Fmodify_frame_parameters): In tty case, update the
3351 default face if necessary (Bug#4238).
3352
3353 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3354
3355 * editfns.c (Fstring_to_char): No need to explain what a character
3356 is in the docstring (Bug#6576).
3357
3358 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3359
3360 * xml.c (parse_region): Make sure we always return a tree.
3361
3362 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3363
3364 * xml.c (parse_region): If a document contains only comments,
3365 return that, too.
3366
3367 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3368
3369 * xml.c (make_dom): Return comments, too.
3370
3371 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3372
3373 Port to OpenBSD.
3374 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3375 and the surrounding thread.
3376 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3377 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3378 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3379 timer goes off.
3380 * s/openbsd.h (BROKEN_SIGIO): Define.
3381 * unexelf.c (unexec) [__OpenBSD__]:
3382 Don't update the .mdebug section of the Alpha COFF symbol table.
3383
3384 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3385
3386 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3387 (bug#8460).
3388
3389 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3390
3391 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3392 This fixes some race conditions on the permissions of any newly
3393 created file.
3394
3395 * alloc.c (valid_pointer_p): Use pipe, not open.
3396 This fixes some permissions issues when debugging.
3397
3398 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3399 If fchown fails to set both uid and gid, try to set just gid,
3400 as that is sometimes allowed. Adjust the file's mode to eliminate
3401 setuid or setgid bits that are inappropriate if fchown fails.
3402
3403 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3404
3405 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3406 to compare Lisp_Objects.
3407 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3408 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3409 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3410
3411 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3412
3413 * lread.c (read_integer): Unread even EOF character.
3414 (read1): Likewise. Properly record start position of symbol.
3415
3416 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3417 symbol character follows.
3418
3419 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3420
3421 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3422 This works around a problem with the previous change to Fcopy_file.
3423 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3424 and without this change, GCC might complain about discarding
3425 fchown's return value.
3426
3427 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3428
3429 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3430
3431 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3432
3433 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3434
3435 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3436
3437 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3438 it's used from the C level.
3439
3440 * process.c: Use the same condition for POLL_FOR_INPUT in both
3441 keyboard.c and process.c (bug#1858).
3442
3443 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3444
3445 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3446 (Fgnutls_boot): Use it.
3447
3448 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3449
3450 * doc.c (Fsubstitute_command_keys): Revert last change.
3451
3452 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3453
3454 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3455 quotes the next character, and doesn't affect other longer
3456 sequences (bug#8935).
3457
3458 * lread.c (syms_of_lread): Clarify that is isn't only
3459 `eval-buffer' and `eval-defun' that's affected by
3460 `lexical-binding' (bug#8460).
3461
3462 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3463
3464 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3465 bidi redisplay when a line includes both an image and is truncated.
3466
3467 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3468
3469 Fix minor problems found by static checking.
3470 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3471 (elsz): Now a signed constant, not a size_t var. We prefer signed
3472 types to unsigned, to avoid integer comparison confusion. Without
3473 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3474 "cannot optimize loop, the loop counter may overflow", a symptom
3475 of the confusion.
3476 * indent.c (Fvertical_motion): Mark locals as initialized.
3477 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3478
3479 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3480
3481 * search.c (Fre_search_backward): Mention `case-fold-search' in
3482 all the re_search_* functions (bug#8138).
3483
3484 * keyboard.c (Fopen_dribble_file): Document when the file is
3485 closed (bug#8056).
3486
3487 2011-07-14 Eli Zaretskii <eliz@gnu.org>
3488
3489 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3490 bidi_cache_idx.
3491
3492 Support bidi reordering of display and overlay strings.
3493 * xdisp.c (compute_display_string_pos)
3494 (compute_display_string_end): Accept additional argument STRING.
3495 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3496 (reseat_to_string): Initialize bidi_it->string.s and
3497 bidi_it->string.schars.
3498 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3499 NULL (avoids a crash in bidi_paragraph_init).
3500 Initialize itb.string.lstring.
3501 (init_iterator): Call bidi_init_it only of a valid
3502 buffer position was specified. Initialize paragraph_embedding to
3503 L2R.
3504 (reseat_to_string): Initialize the bidi iterator.
3505 (display_string): If we need to ignore text properties of
3506 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3507 original value of -1 will not work with bidi.)
3508 (compute_display_string_pos): First arg is now struct
3509 `text_pos *'; all callers changed. Support display properties on
3510 Lisp strings.
3511 (compute_display_string_end): Support display properties on Lisp
3512 strings.
3513 (init_iterator, reseat_1, reseat_to_string): Initialize the
3514 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3515 when iterating on a string not from display properties).
3516 (compute_display_string_pos, compute_display_string_end):
3517 Fix calculation of the object to scan. Fixes an error when using
3518 arrow keys.
3519 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
3520 base_level_stop; instead, set base_level_stop to BEGV.
3521 Fixes crashes in vertical-motion.
3522 (next_element_from_buffer): Improve commentary for when
3523 the iterator is before prev_stop.
3524 (init_iterator): Initialize bidi_p from the default value of
3525 bidi-display-reordering, not from buffer-local value. Use the
3526 buffer-local value only if initializing for buffer iteration.
3527 (handle_invisible_prop): Support invisible properties on strings
3528 that are being bidi-reordered.
3529 (set_iterator_to_next): Support bidi reordering of C strings and
3530 Lisp strings.
3531 (next_element_from_string): Support bidi reordering of Lisp
3532 strings.
3533 (handle_stop_backwards): Support Lisp strings as well.
3534 (display_string): Support display of R2L glyph rows.
3535 Use IT_STRING_CHARPOS when displaying from a Lisp string.
3536 (init_iterator): Don't initialize it->bidi_p for strings
3537 here.
3538 (reseat_to_string): Initialize it->bidi_p for strings here.
3539 (next_element_from_string, next_element_from_c_string)
3540 (next_element_from_buffer): Add xassert's for correspondence
3541 between IT's object being iterated and it->bidi_it.string
3542 structure.
3543 (face_before_or_after_it_pos): Support bidi iteration.
3544 (next_element_from_c_string): Handle the case of the first string
3545 character that is not the first one in the visual order.
3546 (get_visually_first_element): New function, refactored from common
3547 parts of next_element_from_buffer, next_element_from_string, and
3548 next_element_from_c_string.
3549 (tool_bar_lines_needed, redisplay_tool_bar)
3550 (display_menu_bar): Force left-to-right direction. Add a FIXME
3551 comment for making that be controlled by a user option.
3552 (push_it, pop_it): Save and restore the state of the
3553 bidi iterator. Save and restore the bidi_p flag.
3554 (pop_it): Iterate out of display property for string iteration as
3555 well.
3556 (iterate_out_of_display_property): Support iteration over strings.
3557 (handle_single_display_spec): Set up it->bidi_it for iteration
3558 over a display string, and call bidi_init_it.
3559 (handle_single_display_spec, next_overlay_string)
3560 (get_overlay_strings_1, push_display_prop): Set up the bidi
3561 iterator for displaying display or overlay strings.
3562 (forward_to_next_line_start): Don't use the shortcut if
3563 bidi-iterating.
3564 (back_to_previous_visible_line_start): If handle_display_prop
3565 pushed the iterator stack, restore the internal state of the bidi
3566 iterator by calling bidi_pop_it same number of times.
3567 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3568 and we are bidi-iterating, don't decrement the iterator position;
3569 instead, set the first_elt flag in the bidi iterator, to produce
3570 the same effect.
3571 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3572 (push_display_prop): xassert that we are iterating a buffer.
3573 (push_it, pop_it): Save and restore paragraph_embedding member.
3574 (handle_single_display_spec, next_overlay_string)
3575 (get_overlay_strings_1, reseat_1, reseat_to_string)
3576 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3577 correctly. Don't assume unibyte strings are not bidi-reordered.
3578 (compute_display_string_pos)
3579 (compute_display_string_end): Fix handling the case of C string.
3580 (push_it, pop_it): Save and restore from_disp_prop_p.
3581 (handle_single_display_spec, push_display_prop): Set the
3582 from_disp_prop_p flag.
3583 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3584 (pop_it): Call iterate_out_of_display_property only if we are
3585 popping after iteration over a string that came from a display
3586 property. Fix a typo in popping stretch info. Add an assertion
3587 for verifying that the iterator position is in sync with the bidi
3588 iterator.
3589 (handle_single_display_spec, get_overlay_strings_1)
3590 (push_display_prop): Fix initialization of paragraph direction for
3591 string when that of the parent object is not yet determined.
3592 (reseat_1): Call bidi_init_it to resync the bidi
3593 iterator with IT's position. (Bug#7616)
3594 (find_row_edges): If ROW->start.pos gives position
3595 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3596 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3597 Reset the from_disp_prop_p flag.
3598 (SAVE_IT, RESTORE_IT): New macros.
3599 (pos_visible_p, face_before_or_after_it_pos)
3600 (back_to_previous_visible_line_start)
3601 (move_it_in_display_line_to, move_it_in_display_line)
3602 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3603 (try_scrolling, redisplay_window, display_line): Use them when
3604 saving a temporary copy of the iterator and restoring it back.
3605 (back_to_previous_visible_line_start, reseat_1)
3606 (init_iterator): Empty the bidi cache "stack".
3607 (move_it_in_display_line_to): If iterator ended up at
3608 EOL, but we never saw any buffer positions smaller than
3609 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3610 motion in bidi-reordered lines.
3611 (move_it_in_display_line_to): Record prev_method and prev_pos
3612 immediately before the call to set_iterator_to_next. Fixes cursor
3613 motion in bidi-reordered lines with stretch glyphs and strings
3614 displayed in margins. (Bug#8133) (Bug#8867)
3615 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3616 TO_CHARPOS.
3617 (pos_visible_p): Support positions in bidi-reordered lines.
3618 Save and restore bidi cache.
3619
3620 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3621 (bidi_paragraph_info): Delete unused struct.
3622 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3623 (bidi_cache_start): New variable.
3624 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3625 to zero.
3626 (bidi_cache_fetch_state, bidi_cache_search)
3627 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3628 (bidi_cache_find, bidi_peek_at_next_level)
3629 (bidi_level_of_next_char, bidi_find_other_level_edge)
3630 (bidi_move_to_visually_next): Compare cache index with
3631 bidi_cache_start rather than with zero.
3632 (bidi_fetch_char): Accept new argument STRING; all callers
3633 changed. Support iteration over a string. Support strings with
3634 display properties. Support unibyte strings. Fix the type of
3635 `len' according to what STRING_CHAR_AND_LENGTH expects.
3636 (bidi_paragraph_init, bidi_resolve_explicit_1)
3637 (bidi_resolve_explicit, bidi_resolve_weak)
3638 (bidi_level_of_next_char, bidi_move_to_visually_next):
3639 Support iteration over a string.
3640 (bidi_set_sor_type, bidi_resolve_explicit_1)
3641 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3642 can now be zero (for strings); special values 0 and -1 were
3643 changed to -1 and -2, respectively.
3644 (bidi_char_at_pos): New function.
3645 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3646 Call it instead of FETCH_MULTIBYTE_CHAR.
3647 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3648 initialized to valid values.
3649 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3650 values.
3651 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3652 the test for valid cached positions. Fix the logic for looking up
3653 the sentinel state in the cache. GCPRO the Lisp string we are
3654 iterating.
3655 (bidi_push_it, bidi_pop_it): New functions.
3656 (bidi_initialize): Initialize the bidi cache start stack pointer.
3657 (bidi_cache_ensure_space): New function, refactored from part of
3658 bidi_cache_iterator_state. Don't assume the required size is just
3659 one BIDI_CACHE_CHUNK away.
3660 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3661 (bidi_count_bytes, bidi_char_at_pos): New functions.
3662 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3663 always valid if bidi_cache_idx is valid.
3664 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3665 is valid if it's going to be used.
3666 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3667 (bidi_cache_fetch_state, bidi_cache_search)
3668 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3669 (bidi_cache_iterator_state, bidi_cache_find)
3670 (bidi_find_other_level_edge, bidi_cache_start_stack):
3671 All variables related to cache indices are now EMACS_INT.
3672
3673 * dispextern.h (struct bidi_string_data): New structure.
3674 (struct bidi_it): New member `string'. Make flag members be 1-bit
3675 fields, and put them last in the struct.
3676 (compute_display_string_pos, compute_display_string_end):
3677 Update prototypes.
3678 (bidi_push_it, bidi_pop_it): Add prototypes.
3679 (struct iterator_stack_entry): New members bidi_p,
3680 paragraph_embedding, and from_disp_prop_p.
3681 (struct it): Member bidi_p is now a bit field 1 bit wide.
3682 (bidi_shelve_cache, bidi_unshelve_cache):
3683 Declare prototypes.
3684
3685 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3686 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3687 and vector-like objects.
3688
3689 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3690 cache around display iteration.
3691
3692 * window.c (Fwindow_end, window_scroll_pixel_based)
3693 (displayed_window_lines, Frecenter): Save and restore the bidi
3694 cache around display iteration.
3695
3696 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3697
3698 * editfns.c (Fdelete_region): Clarify the use of the named
3699 parameters (bug#6788).
3700
3701 2011-07-14 Martin Rudalics <rudalics@gmx.at>
3702
3703 * indent.c (Fvertical_motion): Set and restore w->pointm when
3704 saving and restoring the window's buffer (Bug#9006).
3705
3706 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3707
3708 * editfns.c (Fstring_to_char): Clarify just what is returned
3709 (bug#6576). Text by Eli Zaretskii.
3710
3711 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
3712
3713 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3714
3715 2011-07-13 Eli Zaretskii <eliz@gnu.org>
3716
3717 * buffer.c (mmap_find): Fix a typo.
3718
3719 2011-07-13 Johan Bockgård <bojohan@gnu.org>
3720
3721 Fix execution of x selection hooks.
3722 * xselect.c (Qx_lost_selection_functions)
3723 (Qx_sent_selection_functions): New vars.
3724 (syms_of_xselect): DEFSYM them.
3725 (x_handle_selection_request): Pass Qx_sent_selection_functions
3726 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3727 (x_handle_selection_clear,x_clear_frame_selections):
3728 Pass Qx_lost_selection_functions rather than
3729 Vx_lost_selection_functions to Frun_hook_with_args.
3730
3731 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3732
3733 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
3734 The old code sometimes used this field without initializing it.
3735
3736 * alloc.c (gc_sweep): Don't read past end of array.
3737 In theory, the old code could also have corrupted Emacs internals,
3738 though it'd be very unlikely.
3739
3740 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3741
3742 * character.c (Fcharacterp): Don't advertise optional ignored
3743 argument. (Bug#4026)
3744
3745 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3746
3747 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3748 key" (bug#4257).
3749
3750 * window.c (Fset_window_start): Doc fix (bug#4199).
3751 (Fset_window_hscroll): Ditto.
3752
3753 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3754
3755 Fix minor new problems caught by GCC 4.6.1.
3756 * term.c (init_tty): Remove unused local.
3757 * xsettings.c (store_monospaced_changed): Define this function only
3758 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
3759 not used otherwise.
3760
3761 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
3762
3763 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3764
3765 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3766
3767 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3768 are the mini-buffer and the echo area (bug#3320).
3769
3770 * term.c (init_tty): Remove support for supdup, c10 and perq
3771 terminals, which are no longer supported (bug#1482).
3772
3773 2011-07-10 Johan Bockgård <bojohan@gnu.org>
3774
3775 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3776
3777 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3778
3779 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3780 for non-popups (Bug#3642).
3781
3782 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3783
3784 * alloc.c (reset_malloc_hooks): Protoize.
3785 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
3786 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3787 * cm.c (losecursor): Likewise.
3788 * data.c (fmod): Likewise.
3789 * dispnew.c (swap_glyphs_in_rows): Likewise.
3790 * emacs.c (memory_warning_signal): Likewise.
3791 * floatfns.c (float_error): Likewise.
3792 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3793 (otf_open, font_otf_capability, generate_otf_features)
3794 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3795 Likewise.
3796 * image.c (pbm_read_file): Likewise.
3797 * indent.c (string_display_width): Likewise.
3798 * intervals.c (check_for_interval, search_for_interval)
3799 (inc_interval_count, count_intervals, root_interval)
3800 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3801 * lread.c (defalias): Likewise.
3802 * ralloc.c (r_alloc_check): Likewise.
3803 * regex.c (set_image_of_range_1, set_image_of_range)
3804 (regex_grow_registers): Likewise.
3805 * sysdep.c (strerror): Likewise.
3806 * termcap.c (valid_filename_p, tprint, main): Likewise.
3807 * tparam.c (main): Likewise.
3808 * unexhp9k800.c (run_time_remap, save_data_space)
3809 (update_file_ptrs, read_header, write_header, calculate_checksum)
3810 (copy_file, copy_rest, display_header): Likewise.
3811 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3812 Likewise.
3813 * xdisp.c (check_it): Likewise.
3814 * xfaces.c (register_color, unregister_color, unregister_colors):
3815 Likewise.
3816 * xfns.c (print_fontset_result): Likewise.
3817 * xrdb.c (member, fatal, main): Likewise.
3818
3819 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3820
3821 Fix minor problems found by static checking (Bug#9031).
3822 * chartab.c (char_table_set_range, map_sub_char_table):
3823 Remove unused locals.
3824 (uniprop_table): Now static.
3825 * composite.c (_work_char): Remove unused static var.
3826
3827 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
3828
3829 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3830
3831 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3832
3833 * gtkutil.c (qttip_cb): Remove code without function.
3834
3835 2011-07-09 Eli Zaretskii <eliz@gnu.org>
3836
3837 * w32.c (pthread_sigmask): New stub.
3838
3839 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
3840
3841 Use pthread_sigmask, not sigprocmask (Bug#9010).
3842 sigprocmask is portable only for single-threaded applications, and
3843 Emacs can be multi-threaded when it uses GTK.
3844 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3845 (LIBES): Use it.
3846 * callproc.c (Fcall_process):
3847 * process.c (create_process):
3848 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3849 Use pthread_sigmask, not sigprocmask.
3850
3851 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3852
3853 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3854 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3855 wrong (Bug#8591).
3856
3857 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3858
3859 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3860 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3861 (xg_hide_tooltip): Fix comment.
3862
3863 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3864 in registerServicesMenuSendTypes.
3865 (validRequestorForSendType): Don't check ns_return_types.
3866
3867 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3868 ns_return_type.
3869
3870 2011-07-08 Jason Rumney <jasonr@gnu.org>
3871
3872 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3873 SH_SHOW for hidden windows (Bug#5482).
3874
3875 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3876 frame struct members of non-existent frames (Bug#6284).
3877
3878 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3879
3880 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3881 variable firstTime not needed on OSX >= 10.6.
3882 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3883 >= 10.5. Use setKnobProportion, setDoubleValue.
3884
3885 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3886 (MAC_OS_X_VERSION_10_5): Define if not defined.
3887 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3888 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3889 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3890
3891 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3892 cString and lossyCString on OSX >= 10.4
3893
3894 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
3895 sizeToFit on OSX >= 10.2.
3896
3897 * nsimage.m (allocInitFromFile): Don't use deprecated method
3898 bestRepresentationForDevice on OSX >= 10.6.
3899
3900 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3901 to avoid warning.
3902
3903 * emacs.c: Declare unexec_init_emacs_zone.
3904
3905 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3906
3907 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3908
3909 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3910 on svcsMenu (Bug#8842).
3911
3912 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3913 ns_return_types.
3914 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3915
3916 * nsterm.m (QUTF8_STRING): Declare.
3917 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3918 (validRequestorForSendType): Return type is (id).
3919 Change indexOfObjectIdenticalTo to indexOfObject.
3920 Check if we have local selection before returning self (Bug#8842).
3921 (writeSelectionToPasteboard): Put local selection into paste board
3922 if we have a local selection (Bug#8842).
3923 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3924
3925 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3926 (ns_get_local_selection): Declare.
3927
3928 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3929
3930 * keymap.c (describe_map_tree): Don't insert a double newline at
3931 the end of the buffer (bug#1169) and return whether we inserted
3932 something.
3933
3934 * callint.c (Fcall_interactively): Change "reading args" to
3935 "providing args" to try to clarify what it does (bug#1010).
3936
3937 2011-07-07 Kenichi Handa <handa@m17n.org>
3938
3939 * composite.c (composition_compute_stop_pos): Ignore a static
3940 composition starting before CHARPOS (Bug#8915).
3941
3942 * xdisp.c (handle_composition_prop): Likewise.
3943
3944 2011-07-07 Eli Zaretskii <eliz@gnu.org>
3945
3946 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3947 (Bug#9015)
3948
3949 2011-07-07 Kenichi Handa <handa@m17n.org>
3950
3951 * character.h (unicode_category_t): New enum type.
3952
3953 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3954 (Qchar_code_property_table): New variable.
3955 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3956 (UNIPROP_COMPRESSED_FORM_P): New macros.
3957 (char_table_ascii): Uncompress the compressed values.
3958 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3959 Uncompress the compressed values.
3960 (sub_char_table_ref_and_range): Likewise.
3961 (char_table_ref_and_range): Uncompress the compressed values.
3962 (sub_char_table_set): New arg is_uniprop. Callers changed.
3963 Uncompress the compressed values.
3964 (sub_char_table_set_range): Args changed. Callers changed.
3965 (char_table_set_range): Adjuted for the above change.
3966 (map_sub_char_table): Delete args default_val and parent. Add arg
3967 top. Give decoded values to a Lisp function.
3968 (map_char_table): Adjust for the above change. Give decoded
3969 values to a Lisp function. Gcpro more variables.
3970 (uniprop_table_uncompress)
3971 (uniprop_decode_value_run_length): New functions.
3972 (uniprop_decoder, uniprop_decoder_count): New variables.
3973 (uniprop_get_decoder, uniprop_encode_value_character)
3974 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3975 New functions.
3976 (uniprop_encoder, uniprop_encoder_count): New variables.
3977 (uniprop_get_encoder, uniprop_table)
3978 (Funicode_property_table_internal, Fget_unicode_property_internal)
3979 (Fput_unicode_property_internal): New functions.
3980 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3981 Sunicode_property_table_internal, Sget_unicode_property_internal,
3982 and Sput_unicode_property_internal. Defvar_lisp
3983 char-code-property-alist.
3984
3985 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
3986 Vunicode_category_table.
3987
3988 * font.c (font_range): Adjust for the change of
3989 Vunicode_category_table.
3990
3991 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3992
3993 * m/iris4d.h: Remove file, move contents ...
3994 * s/irix6-5.h: ... here.
3995
3996 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3997
3998 Remove unportable assumption about struct layout (Bug#8884).
3999 * alloc.c (mark_buffer):
4000 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4001 (clone_per_buffer_values): Don't assume that
4002 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4003 This isn't true in general, and it's particularly not true
4004 if Emacs is configured with --with-wide-int.
4005 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4006 New macros, used in the buffer.c change.
4007
4008 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4009
4010 * xsettings.c: Use both GConf and GSettings if both are available.
4011 (store_config_changed_event): Add comment.
4012 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4013 (store_tool_bar_style_changed): New functions.
4014 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4015 (struct xsettings): Move font inside HAVE_XFT.
4016 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4017 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4018 Move inside HAVE_XFT.
4019 (something_changed_gsettingsCB): Rename from something_changedCB.
4020 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4021 also.
4022 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4023 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4024 (something_changed_gconfCB): Rename from something_changedCB.
4025 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4026 (parse_settings): Move check for font inside HAVE_XFT.
4027 (read_settings, apply_xft_settings): Add comment.
4028 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4029 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4030 call store_font_name_changed.
4031 (xft_settings_event): Add comment.
4032 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4033 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4034 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4035 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4036 (xsettings_initialize): Call init_gsettings last.
4037 (xsettings_get_system_font, xsettings_get_system_normal_font):
4038 Add comment.
4039
4040 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4041
4042 Random fixes. E.g., (random) never returned negative values.
4043 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4044 subseconds part to the entropy, as that's a bit more random.
4045 Prefer signed to unsigned, since the signedness doesn't matter and
4046 in general we prefer signed. When given a limit, use a
4047 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4048 latter isn't right if USE_2_TAGS_FOR_INTS.
4049 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4050 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4051
4052 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4053
4054 * textprop.c (text_property_stickiness):
4055 Obey Vtext_property_default_nonsticky.
4056 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4057 * w32fns.c (syms_of_w32fns):
4058 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4059
4060 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4061
4062 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4063 This is more efficient than Ffile_directory_p and avoids a minor race.
4064
4065 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4066
4067 * buffer.c (Foverlay_put): Say what the return value is
4068 (bug#7835).
4069
4070 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4071 is a directory before asking whether to use the file name
4072 (bug#7564).
4073 (barf_or_query_if_file_exists): Make the "File is a directory"
4074 error be more correct.
4075
4076 * fns.c (Frequire): Remove the mention of the .gz files, since
4077 that's installation-specific, but keep the mention of
4078 `get-load-suffixes'.
4079
4080 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4081
4082 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4083 Report string overflow if the output is too long.
4084
4085 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4086
4087 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4088 (syms_of_gnutls): Remove duplicate DEFSYM for
4089 Qgnutls_bootprop_verify_hostname_error, an error for
4090 Qgnutls_bootprop_verify_error (which is no longer used).
4091
4092 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4093 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4094 Also (re)move comments that are misplaced or no longer relevant.
4095
4096 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4097
4098 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4099
4100 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4101
4102 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4103 and background color parameters if they have been changed.
4104
4105 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4106
4107 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4108
4109 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4110
4111 * xsettings.c (SYSTEM_FONT): Define only when used.
4112 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4113
4114 * keymap.c (access_keymap_1): Now static.
4115
4116 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4117
4118 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4119 leave any prefix arg for the up event (Bug#1586).
4120
4121 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4122
4123 * lread.c (syms_of_lread): Mention single symbols defined by
4124 `defvar' or `defconst' (bug#7154).
4125
4126 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4127 (Frequire): Mention get-load-suffixes.
4128
4129 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4130
4131 * window.h (window): Remove clone_number slot.
4132 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4133 Remove.
4134 (make_parent_window, make_window, saved_window)
4135 (Fset_window_configuration, save_window_save): Don't deal with
4136 clone numbers.
4137 * buffer.c (Qclone_number): Remove declaration.
4138 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4139
4140 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4141
4142 Add multiple inheritance to keymaps.
4143 * keymap.c (Fmake_composed_keymap): New function.
4144 (Fset_keymap_parent): Simplify.
4145 (fix_submap_inheritance): Remove.
4146 (access_keymap_1): New function extracted from access_keymap to handle
4147 embedded parents and handle lists of maps.
4148 (access_keymap): Use it.
4149 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4150 (Fcopy_keymap): Handle embedded parents.
4151 (Fcommand_remapping, define_as_prefix): Simplify.
4152 (Fkey_binding): Simplify.
4153 (syms_of_keymap): Move minibuffer-local-completion-map,
4154 minibuffer-local-filename-completion-map,
4155 minibuffer-local-must-match-map, and
4156 minibuffer-local-filename-must-match-map to Elisp.
4157 (syms_of_keymap): Defsubr make-composed-keymap.
4158 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4159 (parse_menu_item): Trivial simplification.
4160
4161 2011-07-01 Glenn Morris <rgm@gnu.org>
4162
4163 * Makefile.in (SETTINGS_LIBS): Fix typo.
4164
4165 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4166
4167 * coding.c (Fencode_coding_string): Record the last coding system
4168 used, as the function doc string says (bug#8738).
4169
4170 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4171
4172 * xsettings.c (store_monospaced_changed): Take new font as arg and
4173 check for change against current_mono_font.
4174 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4175 (emacs_settings_constructor, emacs_settings_get_property)
4176 (emacs_settings_set_property, emacs_settings_class_init)
4177 (emacs_settings_init, gsettings_obj): Remove.
4178 (something_changedCB): New function for HAVE_GSETTINGS.
4179 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4180 with value as argument.
4181 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4182 g_settings_new (Bug#8967). Do not create gsettings_obj.
4183 Remove calls to g_settings_bind. Connect something_changedCB to
4184 "changed".
4185
4186 * xgselect.c: Add defined (HAVE_GSETTINGS).
4187 (xgselect_initialize): Ditto.
4188
4189 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4190 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4191 xg_select.
4192
4193 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4194
4195 * eval.c (struct backtrace): Simplify and port the data structure.
4196 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4197 signed bit field, as this assumption is not portable and it makes
4198 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4199 "char debug_on_exit : 1" as this is not portable either; instead,
4200 use the portable "unsigned int debug_on_exit : 1". Remove unused
4201 member evalargs. Remove obsolete comments about cc bombing out.
4202
4203 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4204
4205 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4206 Let HAVE_GSETTINGS override HAVE_GCONF.
4207 (store_monospaced_changed): New function.
4208 (EMACS_SETTINGS): A new type derived from GObject to handle
4209 GSettings notifications.
4210 (emacs_settings_constructor, emacs_settings_get_property)
4211 (emacs_settings_set_property, emacs_settings_class_init):
4212 New functions.
4213 (gsettings_client, gsettings_obj): New variables.
4214 (GSETTINGS_SCHEMA): New define.
4215 (something_changedCB): Call store_monospaced_changed.
4216 (init_gsettings): New function.
4217 (xsettings_initialize): Call init_gsettings.
4218 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4219 to NULL.
4220
4221 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4222 GCONF_CFLAGS/LIBS.
4223
4224 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4225
4226 * window.c (resize_root_window, grow_mini_window)
4227 (shrink_mini_window): Rename Qresize_root_window to
4228 Qwindow_resize_root_window and Qresize_root_window_vertically to
4229 Qwindow_resize_root_window_vertically.
4230
4231 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4232
4233 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4234
4235 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4236
4237 * makefile.w32-in: Redesign dependencies so they reflect more
4238 clearly which files are directly included by each source file,
4239 and not through other includes.
4240
4241 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4242
4243 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4244 (sort_overlays, overlay_strings): When an overlay's clone number
4245 matches the window's clone number process the overlay even if
4246 the overlay's window property doesn't match the current window.
4247
4248 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4249 (Fwindow_hchild): Rename to Fwindow_left_child.
4250 (Fwindow_next): Rename to Fwindow_next_sibling.
4251 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4252 (resize_window_check): Rename to window_resize_check.
4253 (resize_window_apply): Rename to window_resize_apply.
4254 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4255 (Fdelete_other_windows_internal, resize_frame_windows)
4256 (Fsplit_window_internal, Fdelete_window_internal)
4257 (grow_mini_window, shrink_mini_window)
4258 (Fresize_mini_window_internal): Fix callers accordingly.
4259
4260 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4261
4262 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4263 (emacs_fixed_set_min_size): Remove.
4264 (emacs_fixed_new): Take frame as argument.
4265
4266 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4267 (_EmacsFixedPrivate): Remove minwidth/height.
4268 Add struct frame *f.
4269 (emacs_fixed_init): Initialize priv->f.
4270 (get_parent_class, emacs_fixed_set_min_size): Remove.
4271 (emacs_fixed_new): Set priv->f to argument.
4272 (emacs_fixed_get_preferred_width)
4273 (emacs_fixed_get_preferred_height): Use min_width/height from
4274 frames size_hint to set minimum and natural (Bug#8919).
4275 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4276 and use min_width/height from frames size_hint to set
4277 min_width/height (Bug#8919).
4278
4279 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4280 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4281 Fix indentation.
4282
4283 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4284
4285 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4286 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4287 called at ZV.
4288
4289 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4290
4291 * process.c (wait_reading_process_output): Bypass select if
4292 waiting for a cell while ignoring keyboard input, and input is
4293 pending. Suggested by Jan Djärv (Bug#8869).
4294
4295 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4296
4297 Use gnulib's dup2 module instead of rolling our own.
4298 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4299
4300 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4301
4302 * dispnew.c (scrolling_window): Before scrolling, turn off a
4303 mouse-highlight in the window being scrolled.
4304
4305 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4306
4307 Move DEFSYM to lisp.h and use everywhere.
4308
4309 * character.h (DEFSYM): Move declaration...
4310 * lisp.h (DEFSYM): ...here.
4311
4312 * gnutls.c:
4313 * minibuf.c:
4314 * w32menu.c:
4315 * w32proc.c:
4316 * w32select.c: Don't include character.h.
4317
4318 * alloc.c (syms_of_alloc):
4319 * buffer.c (syms_of_buffer):
4320 * bytecode.c (syms_of_bytecode):
4321 * callint.c (syms_of_callint):
4322 * casefiddle.c (syms_of_casefiddle):
4323 * casetab.c (init_casetab_once):
4324 * category.c (init_category_once, syms_of_category):
4325 * ccl.c (syms_of_ccl):
4326 * cmds.c (syms_of_cmds):
4327 * composite.c (syms_of_composite):
4328 * dbusbind.c (syms_of_dbusbind):
4329 * dired.c (syms_of_dired):
4330 * dispnew.c (syms_of_display):
4331 * doc.c (syms_of_doc):
4332 * editfns.c (syms_of_editfns):
4333 * emacs.c (syms_of_emacs):
4334 * eval.c (syms_of_eval):
4335 * fileio.c (syms_of_fileio):
4336 * fns.c (syms_of_fns):
4337 * frame.c (syms_of_frame):
4338 * fringe.c (syms_of_fringe):
4339 * insdel.c (syms_of_insdel):
4340 * keymap.c (syms_of_keymap):
4341 * lread.c (init_obarray, syms_of_lread):
4342 * macros.c (syms_of_macros):
4343 * msdos.c (syms_of_msdos):
4344 * print.c (syms_of_print):
4345 * process.c (syms_of_process):
4346 * search.c (syms_of_search):
4347 * sound.c (syms_of_sound):
4348 * syntax.c (init_syntax_once, syms_of_syntax):
4349 * terminal.c (syms_of_terminal):
4350 * textprop.c (syms_of_textprop):
4351 * undo.c (syms_of_undo):
4352 * w32.c (globals_of_w32):
4353 * window.c (syms_of_window):
4354 * xdisp.c (syms_of_xdisp):
4355 * xfaces.c (syms_of_xfaces):
4356 * xfns.c (syms_of_xfns):
4357 * xmenu.c (syms_of_xmenu):
4358 * xsettings.c (syms_of_xsettings):
4359 * xterm.c (syms_of_xterm): Use DEFSYM.
4360
4361 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4362
4363 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4364
4365 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4366
4367 Integer and buffer overflow fixes (Bug#8873).
4368
4369 * print.c (printchar, strout): Check for string overflow.
4370 (PRINTPREPARE, printchar, strout):
4371 Don't set size unless allocation succeeds.
4372
4373 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4374 for sizes. Check for string overflow more accurately.
4375 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4376
4377 * macros.c: Integer and buffer overflow fixes.
4378 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4379 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4380 Use ptrdiff_t, not int, for sizes.
4381 Don't increment bufsize until after realloc succeeds.
4382 Check for size-calculation overflow.
4383 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4384
4385 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4386
4387 * lread.c: Integer overflow fixes.
4388 (read_integer): Radix is now EMACS_INT, not int,
4389 to improve quality of diagnostics for out-of-range radices.
4390 Calculate buffer size correctly for out-of-range radices.
4391 (read1): Check for integer overflow in radices, and in
4392 read-circle numbers.
4393 (read_escape): Avoid int overflow.
4394 (Fload, openp, read_buffer_size, read1)
4395 (substitute_object_recurse, read_vector, read_list, map_obarray):
4396 Use ptrdiff_t, not int, for sizes.
4397 (read1): Use EMACS_INT, not int, for sizes.
4398 Check for size overflow.
4399
4400 * image.c (cache_image): Check for size arithmetic overflow.
4401
4402 * lread.c: Integer overflow issues.
4403 (saved_doc_string_size, saved_doc_string_length)
4404 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4405 Now ptrdiff_t, not int.
4406 (read1): Don't assume doc string length fits in int. Check for
4407 out-of-range doc string lengths.
4408 (read_list): Don't assume file position fits in int.
4409 (read_escape): Check for hex character overflow.
4410
4411 2011-06-22 Leo Liu <sdl.web@gmail.com>
4412
4413 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4414 Move to minibuffer.el.
4415
4416 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4417
4418 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4419 The following patches are for when GLYPH_DEBUG && !XASSERT.
4420 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4421 * dispnew.c (flush_stdout):
4422 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4423 Mark as externally visible.
4424 * dispnew.c (check_window_matrix_pointers): Now static.
4425 * dispnew.c (window_to_frame_vpos):
4426 * xfns.c (unwind_create_frame):
4427 * xterm.c (x_check_font): Remove unused local.
4428 * scroll.c (CHECK_BOUNDS):
4429 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4430 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4431 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4432 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4433 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4434 Now static.
4435 (debug_method_add): Use va_list and vsprintf rather than relying
4436 on undefined behavior with wrong number of arguments.
4437 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4438 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4439 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4440 since we're not interested in debugging glyphs with old libraries.
4441 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4442 GCC 4.6.0's static checking.
4443
4444 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4445
4446 Integer overflow and signedness fixes (Bug#8873).
4447 A few related buffer overrun fixes, too.
4448
4449 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4450
4451 * dispextern.h (struct face.stipple):
4452 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4453 (x_bitmap_mask, x_allocate_bitmap_record)
4454 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4455 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4456 (x_create_bitmap_from_xpm_data):
4457 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4458 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4459 (.bitmaps_last):
4460 * xfaces.c (load_pixmap):
4461 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4462 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4463 (.bitmaps_last, struct x_output.icon_bitmap):
4464 Use ptrdiff_t, not int, for bitmap indexes.
4465 (x_allocate_bitmap_record): Check for size overflow.
4466 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4467
4468 Use ptrdiff_t, not int, for overlay counts.
4469 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4470 * editfns.c (overlays_around, get_pos_property):
4471 * textprop.c (get_char_property_and_overlay):
4472 * xdisp.c (next_overlay_change, note_mouse_highlight):
4473 * xfaces.c (face_at_buffer_position):
4474 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4475 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4476 (Fnext_overlay_change, Fprevious_overlay_change)
4477 (mouse_face_overlay_overlaps, Foverlays_in):
4478 Use ptrdiff_t, not int, for sizes.
4479 (overlays_at, overlays_in): Check for size-calculation overflow.
4480
4481 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4482
4483 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4484 (x_session_initialize): Do not assume string length fits in int.
4485
4486 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4487 This is unlikely, but can occur if DPI is outlandish.
4488
4489 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
4490 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4491
4492 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4493 * xrdb.c (magic_file_p, search_magic_path):
4494 Omit last arg SUFFIX; it was always 0. All callers changed.
4495 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4496
4497 * xfont.c (xfont_match): Avoid need for strlen.
4498
4499 * xfns.c: Don't assume strlen fits in int.
4500 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4501
4502 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4503 not unsigned long, as we prefer signed integers. All callers changed.
4504 Detect integer overflow in repeat count.
4505 (message_dolog): Don't assume print length fits in 39 bytes.
4506 (display_mode_element): Don't assume strlen fits in int.
4507
4508 * termcap.c: Don't assume sizes fit in int and never overflow.
4509 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4510 (gobble_line): Check for size-calculation overflow.
4511
4512 * minibuf.c (Fread_buffer):
4513 * lread.c (intern, intern_c_string):
4514 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4515 Don't assume string length fits in int.
4516
4517 * keyboard.c (parse_tool_bar_item):
4518 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4519
4520 * font.c: Don't assume string length fits in int.
4521 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4522 Use ptrdiff_t, not int.
4523 (font_intern_prop): Don't assume string length fits in int.
4524 Don't assume integer property fits in fixnum.
4525 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
4526
4527 * filelock.c: Fix some buffer overrun and integer overflow issues.
4528 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
4529 Reformulate so as not to need the command string.
4530 Invoke gzip -cd rather than gunzip, as it's more portable.
4531 (lock_info_type, lock_file_1, lock_file):
4532 Don't assume pid_t and time_t fit in unsigned long.
4533 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4534 (current_lock_owner): Prefer signed type for sizes.
4535 Use memcpy, not strncpy, where memcpy is what is really wanted.
4536 Don't assume (via atoi) that time_t and pid_t fit in int.
4537 Check for time_t and/or pid_t out of range, e.g., via a network share.
4538 Don't alloca where an auto var works fine.
4539
4540 * fileio.c: Fix some integer overflow issues.
4541 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4542 Don't assume string length fits in int.
4543 (directory_file_name): Don't assume string length fits in long.
4544 (make_temp_name): Don't assume pid fits in int, or that its print
4545 length is less than 20.
4546
4547 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4548
4549 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4550
4551 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4552
4553 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4554 We prefer signed integers, even for size calculations.
4555
4556 * emacs.c: Don't assume string length fits in 'int'.
4557 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4558 (main): Don't invoke strlen when not needed.
4559
4560 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4561 (XD_DEBUG_MESSAGE): Don't waste a byte.
4562
4563 * callproc.c (getenv_internal_1, getenv_internal)
4564 (Fgetenv_internal):
4565 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4566
4567 * lread.c (invalid_syntax): Omit length argument.
4568 All uses changed. This doesn't fix a bug, but it simplifies the
4569 code away from its former Hollerith-constant appearance, and it's
4570 one less 'int' to worry about when looking at integer-overflow issues.
4571 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
4572
4573 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4574 This didn't break anything, but it didn't help either.
4575 It's confusing to put a bogus integer in a place where the actual
4576 value does not matter.
4577 (LIST_END_P): Remove unused macro and its bogus comment.
4578 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
4579
4580 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4581 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4582 implementation.
4583 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4584 We prefer signed types, and the value cannot exceed the EMACS_INT
4585 range anyway (because otherwise the length would not be representable).
4586 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4587 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4588 This avoids a GCC warning when WIDE_EMACS_INT.
4589
4590 * indent.c (sane_tab_width): New function.
4591 (current_column, scan_for_column, Findent_to, position_indentation)
4592 (compute_motion): Use it. This is just for clarity.
4593 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
4594
4595 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
4596
4597 * lisp.h (lint_assume): New macro.
4598 * composite.c (composition_gstring_put_cache):
4599 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4600
4601 * editfns.c, insdel.c:
4602 Omit unnecessary forward decls, to simplify future changes.
4603
4604 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4605
4606 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4607
4608 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
4609 Use much-faster test for byte-length change.
4610 Don't assume string byte-length fits in 'int'.
4611 Check that character arg fits in 'int'.
4612 (mapcar1): Declare byte as byte, for clarity.
4613
4614 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4615
4616 * fns.c (concat): Catch string overflow earlier.
4617 Do not rely on integer wraparound.
4618
4619 * dispextern.h (struct it.overlay_strings_charpos)
4620 (struct it.selective): Now EMACS_INT, not int.
4621 * xdisp.c (forward_to_next_line_start)
4622 (back_to_previous_visible_line_start)
4623 (reseat_at_next_visible_line_start, next_element_from_buffer):
4624 Don't arbitrarily truncate the value of 'selective' to int.
4625
4626 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4627
4628 * composite.c: Don't truncate sizes to 'int'.
4629 (composition_gstring_p, composition_reseat_it)
4630 (composition_adjust_point): Use EMACS_INT, not int.
4631 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4632 not EMACS_UINT, for indexes.
4633
4634 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4635
4636 * buffer.c: Include <verify.h>.
4637 (struct sortvec.priority, struct sortstr.priority):
4638 Now EMACS_INT, not int.
4639 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
4640 (struct sortstr.size, record_overlay_string)
4641 (struct sortstrlist.size, struct sortlist.used):
4642 Don't truncate size to int.
4643 (record_overlay_string): Check for size-calculation overflow.
4644 (init_buffer_once): Check at compile-time, not run-time.
4645
4646 2011-06-22 Jim Meyering <meyering@redhat.com>
4647
4648 Don't leak an XBM-image-sized buffer
4649 * image.c (xbm_load): Free the image buffer after using it.
4650
4651 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4652
4653 Port to Sun C.
4654 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4655 that Sun C diagnosed.
4656 * fns.c (secure_hash): Fix pointer signedness issue.
4657 * intervals.c (static_offset_intervals): New function.
4658 (offset_intervals): Use it.
4659
4660 2011-06-21 Leo Liu <sdl.web@gmail.com>
4661
4662 * deps.mk (fns.o):
4663 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4664 sha512.h.
4665
4666 * fns.c (secure_hash): Rename from crypto_hash_function and change
4667 the first arg to accept symbols.
4668 (Fsecure_hash): New primitive.
4669 (syms_of_fns): New symbols.
4670
4671 2011-06-20 Deniz Dogan <deniz@dogan.se>
4672
4673 * process.c (Fset_process_buffer): Clarify return value in
4674 docstring.
4675
4676 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
4677
4678 * dispnew.c (add_window_display_history): Use BVAR.
4679
4680 * xdisp.c (debug_method_add): Use BVAR.
4681 (check_window_end, dump_glyph_matrix, dump_glyph)
4682 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4683
4684 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4685 Likewise.
4686
4687 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4688 check till after the cache is created in init_frame_faces.
4689
4690 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4691
4692 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4693
4694 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4695
4696 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4697 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4698 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4699
4700 Improve buffer-overflow checking (Bug#8873).
4701 * fileio.c (Finsert_file_contents):
4702 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4703 Remove the old (too-loose) buffer overflow checks.
4704 They weren't needed, since make_gap checks for buffer overflow.
4705 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4706 The old code merely checked for Emacs fixnum overflow, and relied
4707 on undefined (wraparound) behavior. The new code avoids undefined
4708 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4709
4710 * editfns.c (Finsert_char): Don't dump core with very negative counts.
4711 Tune. Don't use wider integers than needed. Don't use alloca.
4712 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
4713
4714 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4715
4716 * insdel.c, lisp.h (buffer_overflow): New function.
4717 (insert_from_buffer_1, replace_range, replace_range_2):
4718 * insdel.c (make_gap_larger):
4719 * editfns.c (Finsert_char):
4720 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4721
4722 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4723
4724 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4725
4726 Integer overflow and signedness fixes (Bug#8873).
4727
4728 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4729 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4730
4731 * fileio.c: Don't assume EMACS_INT fits in off_t.
4732 (emacs_lseek): New static function.
4733 (Finsert_file_contents, Fwrite_region): Use it.
4734 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4735
4736 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4737
4738 * fns.c: Don't overflow int when computing a list length.
4739 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4740 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4741 truncation on 64-bit hosts. Check for QUIT every
4742 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4743 faster and is responsive enough.
4744 (Flength): Report an error instead of overflowing an integer.
4745 (Fsafe_length): Return a float if the value is not representable
4746 as a fixnum. This shouldn't happen except in contrived situations.
4747 (Fnthcdr, Fsort): Don't assume list length fits in int.
4748 (Fcopy_sequence): Don't assume vector length fits in int.
4749
4750 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4751 (header_size, word_size): New constants.
4752 (allocate_vectorlike): Don't check size overflow here.
4753 (allocate_vector): Check it here instead, since this is the only
4754 caller of allocate_vectorlike that could cause overflow.
4755 Check that the new vector's length is representable as a fixnum.
4756
4757 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4758 The previous code was bogus. For example, next_almost_prime (32)
4759 returned 39, which is undesirable as it is a multiple of 3; and
4760 next_almost_prime (24) returned 25, which is a multiple of 5 so
4761 why was the code bothering to check for multiples of 7?
4762
4763 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4764
4765 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4766
4767 Variadic C functions now count arguments with ptrdiff_t.
4768 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4769 Back then I didn't know that the Emacs coding style prefers signed int.
4770 Also, in the meantime I found a few more instances where arguments
4771 were being counted with int, which may truncate counts on 64-bit
4772 machines, or EMACS_INT, which may be unnecessarily wide.
4773 * lisp.h (struct Lisp_Subr.function.aMANY)
4774 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4775 Arg counts are now ptrdiff_t, not size_t.
4776 All variadic functions and their callers changed accordingly.
4777 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4778 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4779 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4780 * callint.c (Fcall_interactively): Check arg count for overflow,
4781 to avoid potential buffer overrun. Use signed char, not 'int',
4782 for 'varies' array, so that we needn't bother to check its size
4783 calculation for overflow.
4784 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4785 * eval.c (apply_lambda):
4786 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4787 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4788 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4789
4790 * callint.c (Fcall_interactively): Don't use index var as event count.
4791
4792 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4793 * mem-limits.h (SIZE): Remove; no longer used.
4794
4795 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
4796
4797 Remove unnecessary casts.
4798 * xterm.c (x_term_init):
4799 * xfns.c (x_set_border_pixel):
4800 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4801 These aren't needed now that we assume ANSI C.
4802
4803 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4804 It's more likely to cause problems (due to unsigned overflow)
4805 than to cure them.
4806
4807 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4808
4809 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4810
4811 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4812
4813 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4814
4815 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4816
4817 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4818
4819 GLYPH_CODE_FACE returns EMACS_INT, not int.
4820 * dispextern.h (merge_faces):
4821 * xfaces.c (merge_faces):
4822 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4823 Don't assume EMACS_INT fits in int.
4824
4825 * character.h (CHAR_VALID_P): Remove unused parameter.
4826 * fontset.c, lisp.h, xdisp.c: All uses changed.
4827
4828 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4829
4830 * fns.c (concat): Minor tuning based on overflow analysis.
4831 This doesn't fix any bugs. Use int to hold character, instead
4832 of constantly refetching from Emacs object. Use XFASTINT, not
4833 XINT, for value known to be a character. Don't bother comparing
4834 a single byte to 0400, as it's always less.
4835
4836 * floatfns.c (Fexpt):
4837 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4838
4839 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4840 for characters.
4841
4842 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4843
4844 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4845 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4846 incorrectly succeed when S was a string, because 4294967386 was
4847 truncated before it was used.
4848
4849 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4850 Otherwise, an out-of-range integer could cause undefined behavior
4851 on a 64-bit host.
4852
4853 * composite.c: Use int, not EMACS_INT, for characters.
4854 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4855 EMACS_INT, for values that are known to be in character range.
4856 This doesn't fix any bugs but is the usual style inside Emacs and
4857 may generate better code on 32-bit machines.
4858
4859 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4860 This is for reasons similar to the recent CHAR_STRING fix.
4861 * charset.c (Fencode_char): Check that character arg is actually
4862 a character. Pass an int to ENCODE_CHAR.
4863 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4864 wider than 'int', as a compile-time check to prevent future regressions
4865 in this area.
4866
4867 * character.c (char_string): Remove unnecessary casts.
4868
4869 Make sure a 64-bit char is never passed to CHAR_STRING.
4870 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4871 by silently ignoring the top 32 bits, allowing some values
4872 that were far too large to be valid characters.
4873 * character.h: Include <verify.h>.
4874 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4875 arguments are no wider than unsigned, as a compile-time check
4876 to prevent future regressions in this area.
4877 * data.c (Faset):
4878 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
4879 (Fsubst_char_in_region):
4880 * fns.c (concat):
4881 * xdisp.c (decode_mode_spec_coding):
4882 Adjust to CHAR_STRING's new requirement.
4883 * editfns.c (Finsert_char, Fsubst_char_in_region):
4884 * fns.c (concat): Check that character args are actually
4885 characters. Without this test, these functions did the wrong
4886 thing with wildly out-of-range values on 64-bit hosts.
4887
4888 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4889 These casts should not be needed on 32-bit hosts, either.
4890 * keyboard.c (read_char):
4891 * lread.c (Fload): Remove casts to unsigned.
4892
4893 * lisp.h (UNSIGNED_CMP): New macro.
4894 This fixes comparison bugs on 64-bit hosts.
4895 (ASCII_CHAR_P): Use it.
4896 * casefiddle.c (casify_object):
4897 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
4898 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4899 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4900 * dispextern.h (FACE_FROM_ID):
4901 * keyboard.c (read_char): Use UNSIGNED_CMP.
4902
4903 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4904 not to EMACS_INT, to avoid GCC warning.
4905
4906 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4907
4908 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4909 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4910 isn't needed on 32-bit machines.
4911
4912 * buffer.c (Fgenerate_new_buffer_name):
4913 Use EMACS_INT for count, not int.
4914 (advance_to_char_boundary): Return EMACS_INT, not int.
4915
4916 * data.c (Qcompiled_function): Now static.
4917
4918 * window.c (window_body_lines): Now static.
4919
4920 * image.c (gif_load): Rename local to avoid shadowing.
4921
4922 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4923 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4924 * alloc.c (make_save_value): Integer argument is now of type
4925 ptrdiff_t, not int.
4926 (mark_object): Use ptrdiff_t, not int.
4927 * lisp.h (pD): New macro.
4928 * print.c (print_object): Use it.
4929
4930 * alloc.c: Use EMACS_INT, not int, to count objects.
4931 (total_conses, total_markers, total_symbols, total_vector_size)
4932 (total_free_conses, total_free_markers, total_free_symbols)
4933 (total_free_floats, total_floats, total_free_intervals)
4934 (total_intervals, total_strings, total_free_strings):
4935 Now EMACS_INT, not int. All uses changed.
4936 (Fgarbage_collect): Compute overall total using a double, so that
4937 integer overflow is less likely to be a problem. Check for overflow
4938 when converting back to an integer.
4939 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4940 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4941 These were 'int' variables that could overflow on 64-bit hosts;
4942 they were never used, so remove them instead of repairing them.
4943 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
4944 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4945 Previously, this ceilinged at INT_MAX, but that doesn't work on
4946 64-bit machines.
4947 (allocate_pseudovector): Don't use EMACS_INT when int would do.
4948
4949 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
4950 (allocate_vectorlike): Check for ptrdiff_t overflow.
4951 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4952 when a (possibly-narrower) signed value would do just as well.
4953 We prefer using signed arithmetic, to avoid comparison confusion.
4954
4955 * alloc.c: Catch some string size overflows that we were missing.
4956 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4957 for convenience in STRING_BYTES_MAX.
4958 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4959 The definition here is exact; the one in lisp.h was approximate.
4960 (allocate_string_data): Check for string overflow. This catches
4961 some instances we weren't catching before. Also, it catches
4962 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4963 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4964 and ptrdiff_t and EMACS_INT are both 64 bits.
4965
4966 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4967 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
4968 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
4969
4970 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4971
4972 * alloc.c (Fmake_string): Check for out-of-range init.
4973
4974 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4975
4976 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4977
4978 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4979
4980 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4981 xg_get_default_scrollbar_width.
4982
4983 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4984 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4985 (style_changed_cb): Call update_theme_scrollbar_width and call
4986 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4987 all frames (Bug#8505).
4988 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4989 Call gtk_window_set_resizable if HAVE_GTK3.
4990 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4991 and height if HAVE_GTK3 (Bug#8505).
4992 (scroll_bar_width_for_theme): New variable.
4993 (update_theme_scrollbar_width): New function.
4994 (xg_get_default_scrollbar_width): Move code to
4995 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4996 (xg_initialize): Call update_theme_scrollbar_width.
4997
4998 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4999
5000 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5001
5002 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5003
5004 * frame.c (make_frame): Call other_buffer_safely instead of
5005 other_buffer.
5006
5007 * window.c (temp_output_buffer_show): Call display_buffer with
5008 second argument Vtemp_buffer_show_specifiers and reset latter
5009 immediately after the call.
5010 (Vtemp_buffer_show_specifiers): New variable.
5011 (auto_window_vscroll_p, next_screen_context_lines)
5012 (Vscroll_preserve_screen_position): Remove leading asterisks from
5013 doc-strings.
5014
5015 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5016
5017 Fix minor problems found by GCC 4.6.0 static checking.
5018 * buffer.c (Qclone_number): Remove for now, as it's unused.
5019 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5020 (record_buffer): Remove unused local.
5021 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5022 (set_frame_buffer_list): Remove; unused.
5023 * frame.h (other_visible_frames): Remove decl.
5024 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5025 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5026 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5027 if HAVE_GPM.
5028 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5029 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5030 Define only if HAVE_GPM.
5031 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5032 (update_hints_inhibit): Remove; never set. All uses removed.
5033 * widgetprv.h (emacsFrameClassRec): Remove decl.
5034 * window.c (delete_deletable_window): Now returns void, since it
5035 wasn't returning anything.
5036 (compare_window_configurations): Remove unused locals.
5037 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5038 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5039 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5040 the same widths as pointers. This follows up on the 2011-05-06 patch.
5041 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5042 * xterm.h: Likewise.
5043 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5044
5045 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5046
5047 * makefile.w32-in: Update dependencies.
5048 (LISP_H): Add lib/intprops.h.
5049
5050 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5051
5052 * image.c (gif_load): Add animation frame delay to the metadata.
5053 (syms_of_image): Use DEFSYM. New symbol `delay'.
5054
5055 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5056
5057 * window.c (delete_deletable_window): Re-add.
5058 (Fset_window_configuration): Rewrite to handle dead buffers and
5059 consequently deletable windows.
5060 (window_tree, Fwindow_tree): Remove. Supply functionality in
5061 window.el.
5062 (compare_window_configurations): Simplify code.
5063
5064 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5065
5066 * image.c (imagemagick_load_image): Fix type mismatch.
5067 (Fimagemagick_types): Likewise.
5068
5069 * window.h (replace_buffer_in_windows): Declare.
5070
5071 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5072
5073 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5074 Qclone_number. Remove external declaration of Qdelete_window.
5075 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5076 code.
5077 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5078 Run Qbuffer_list_update_hook if allowed.
5079 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5080 buffer list implementation.
5081 (other_buffer_safely): New function.
5082 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5083 calls to replace_buffer_in_windows and
5084 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5085 if allowed.
5086 (record_buffer): Inhibit quitting and rewrite using quittable
5087 functions. Run Qbuffer_list_update_hook if allowed.
5088 (Frecord_buffer, Funrecord_buffer): New functions.
5089 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5090 Move switch-to-buffer to window.el.
5091 (bury-buffer): Move to window.el.
5092 (Vbuffer_list_update_hook): New variable.
5093
5094 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5095 section.
5096
5097 * window.h (resize_frame_windows): Move up in code.
5098 (Fwindow_frame): Remove EXFUN.
5099 (replace_buffer_in_all_windows): Remove prototype.
5100 (replace_buffer_in_windows_safely): Add prototype.
5101
5102 * window.c: Declare Qdelete_window static again. Move down
5103 declaration of select_count.
5104 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5105 (Fother_window): Move to window.el.
5106 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5107 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5108 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5109 window.el.
5110 (replace_buffer_in_windows): Implement by calling
5111 Qreplace_buffer_in_windows.
5112 (replace_buffer_in_all_windows): Remove with some functionality
5113 moved into replace_buffer_in_windows_safely.
5114 (replace_buffer_in_windows_safely): New function.
5115 (select_window_norecord, select_frame_norecord): Move in front
5116 of run_window_configuration_change_hook. Remove now obsolete
5117 declarations.
5118 (Fset_window_buffer): Rewrite doc-string.
5119 Call Qrecord_window_buffer.
5120 (keys_of_window): Move binding for other-window to window.el.
5121
5122 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5123
5124 * dispextern.h (struct image): Replace data member, whose int_val
5125 and ptr_val fields were not used by anything, with a single
5126 lisp_val object.
5127
5128 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5129 (gif_clear_image, gif_load, imagemagick_load_image)
5130 (gs_clear_image, gs_load): Callers changed.
5131
5132 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5133
5134 * buffer.h: Include <time.h>, for time_t.
5135 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5136
5137 Fix minor problems found by static checking.
5138
5139 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5140
5141 Make identifiers static if they are not used in other modules.
5142 * data.c (Qcompiled_function, Qframe, Qvector):
5143 * image.c (QimageMagick, Qsvg):
5144 * minibuf.c (Qmetadata):
5145 * window.c (resize_window_check, resize_root_window): Now static.
5146 * window.h (resize_window_check, resize_root_window): Remove decls.
5147
5148 * window.c (window_deletion_count, delete_deletable_window):
5149 Remove; unused.
5150 (window_body_lines): Now static.
5151 (Fdelete_other_windows_internal): Mark vars as initialized.
5152 Make sure 'resize_failed' is initialized.
5153 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5154 (resize_window_apply): Remove unused local.
5155 * window.h (delete_deletable_window): Remove decl.
5156
5157 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5158 (imagemagick_load_image): Fix pointer signedness problem by changing
5159 last arg from unsigned char * to char *. All uses changed.
5160 Also, fix a local for similar reasons.
5161 Remove unused locals. Remove locals to avoid shadowing.
5162 (fn_rsvg_handle_free): Remove; unused.
5163 (svg_load, svg_load_image): Fix pointer signedness problem.
5164 (imagemagick_load_image): Don't use garbage pointer image_wand.
5165
5166 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5167
5168 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5169
5170 * image.c (gif_load): Fix omitted cast error introduced by
5171 2011-06-06 change.
5172
5173 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5174
5175 * window.h (resize_proportionally, orig_total_lines)
5176 (orig_top_line): Remove from window structure.
5177 (set_window_height, set_window_width, change_window_heights)
5178 (Fdelete_window): Remove prototypes.
5179 (resize_frame_windows): Remove duplicate declaration.
5180
5181 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5182
5183 * window.h (resize_frame_windows, resize_window_check)
5184 (delete_deletable_window, resize_root_window)
5185 (resize_frame_windows): Declare prototypes.
5186
5187 * window.c (resize_window_apply): Make definition be "static" to
5188 match the prototype.
5189
5190 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5191
5192 * window.c: Remove declarations of Qwindow_size_fixed,
5193 window_min_size_1, window_min_size_2, window_min_size,
5194 size_window, window_fixed_size_p, enlarge_window, delete_window.
5195 Remove static from declaration of Qdelete_window, it's
5196 temporarily needed by Fbury_buffer.
5197 (replace_window): Don't assign orig_top_line and
5198 orig_total_lines.
5199 (Fdelete_window, delete_window): Remove. Window deletion is
5200 handled by window.el.
5201 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5202 Replace Fdelete_window calls with calls to Qdelete_window.
5203 (Fdelete_other_windows): Remove. Deleting other windows is
5204 handled by window.el.
5205 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5206 handled in window.el.
5207 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5208 Window minimum sizes are handled in window.el.
5209 (shrink_windows, size_window, set_window_height)
5210 (set_window_width, change_window_heights, window_height)
5211 (window_width, CURBEG, CURSIZE, enlarge_window)
5212 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5213 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5214 handled in window.el.
5215 (make_dummy_parent): Rename to make_parent_window and give it a
5216 second argument horflag.
5217 (make_window): Don't set resize_proportionally any more.
5218 (Fsplit_window): Remove. Windows are split in window.el.
5219 (save_restore_action, save_restore_orig_size)
5220 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5221 Resize mini windows in window.el.
5222 (grow_mini_window, shrink_mini_window): Implement by calling
5223 Qresize_root_window_vertically, resize_window_check and
5224 resize_window_apply.
5225 (saved_window, Fset_window_configuration, save_window_save):
5226 Do not handle orig_top_line, orig_total_lines, and
5227 resize_proportionally.
5228 (window_min_height, window_min_width): Move to window.el.
5229 (keys_of_window): Move bindings for delete-other-windows,
5230 split-window, delete-window and enlarge-window to window.el.
5231
5232 * buffer.c: Temporarily extern Qdelete_window.
5233 (Fbury_buffer): Temporarily call Qdelete_window instead of
5234 Fdelete_window (Fbury_buffer will move to window.el soon).
5235
5236 * frame.c (set_menu_bar_lines_1): Remove code handling
5237 orig_top_line and orig_total_lines.
5238
5239 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5240 set_window_height but set heights directly.
5241 (change_frame_size_1): Use resize_frame_windows.
5242
5243 * xdisp.c (init_xdisp): Don't use set_window_height but set
5244 heights directly.
5245
5246 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5247 Use resize_frame_windows instead of change_window_heights and run
5248 run_window_configuration_change_hook.
5249
5250 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5251 instead of change_window_heights and run
5252 run_window_configuration_change_hook.
5253
5254 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5255
5256 * window.c (replace_window): Rename second argument REPLACEMENT to
5257 NEW. New third argument SETFLAG. Rewrite.
5258 (delete_window, make_dummy_parent): Call replace_window with
5259 third argument 1.
5260 (window_list_1): Move down in code.
5261 (run_window_configuration_change_hook): Move set_buffer part
5262 before select_frame_norecord part in order to unwind correctly.
5263 Rename count1 to count.
5264 (recombine_windows, delete_deletable_window, resize_root_window)
5265 (Fdelete_other_windows_internal)
5266 (Frun_window_configuration_change_hook, make_parent_window)
5267 (resize_window_check, resize_window_apply, Fresize_window_apply)
5268 (resize_frame_windows, Fsplit_window_internal)
5269 (Fdelete_window_internal, Fresize_mini_window_internal):
5270 New functions.
5271 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5272
5273 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5274
5275 * window.h (window): Add some new members to window structure -
5276 normal_lines, normal_cols, new_total, new_normal, clone_number,
5277 splits, nest, prev_buffers, next_buffers.
5278 (WINDOW_TOTAL_SIZE): Move here from window.c.
5279 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5280
5281 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5282 Remove.
5283 (make_dummy_parent): Set new members of windows structure.
5284 (make_window): Move down in code. Handle new members of window
5285 structure.
5286 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5287 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5288 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5289 (Fset_window_prev_buffers, Fwindow_next_buffers)
5290 (Fset_window_next_buffers, Fset_window_clone_number):
5291 New functions.
5292 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5293 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5294 Doc-string fixes.
5295 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5296 Argument WINDOW can be now internal window too.
5297 (Fwindow_use_time): Move up in code.
5298 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5299 Rewrite doc-string.
5300 (Fset_window_configuration, saved_window)
5301 (Fcurrent_window_configuration, save_window_save): Handle new
5302 members of window structure.
5303 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5304 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5305 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5306 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5307 Qget_mru_window, Qresize_root_window,
5308 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5309 Qauto_buffer_name; staticpro them.
5310
5311 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5312
5313 * window.c (Fwindow_total_size, Fwindow_left_column)
5314 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5315 (Fwindow_list_1): New functions.
5316 (window_box_text_cols): Replace with window_body_cols.
5317 (Fwindow_width, Fscroll_left, Fscroll_right):
5318 Use window_body_cols instead of window_box_text_cols.
5319 (delete_window, Fset_window_configuration):
5320 Call delete_all_subwindows with window as argument.
5321 (delete_all_subwindows): Take a window as argument and not a
5322 structure. Rewrite.
5323 (window_loop): Remove handling of GET_LRU_WINDOW and
5324 GET_LARGEST_WINDOW.
5325 (Fget_lru_window, Fget_largest_window): Move to window.el.
5326
5327 * window.h: Extern window_body_cols instead of
5328 window_box_text_cols. delete_all_subwindows now takes a
5329 Lisp_Object as argument.
5330
5331 * indent.c (compute_motion, Fcompute_motion):
5332 Use window_body_cols instead of window_box_text_cols.
5333
5334 * frame.c (delete_frame): Call delete_all_subwindows with root
5335 window as argument.
5336
5337 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5338
5339 * fns.c (Fputhash): Document return value.
5340
5341 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5342
5343 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5344
5345 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5346
5347 Cons<->int and similar integer overflow fixes (Bug#8794).
5348
5349 Check for overflow when converting integer to cons and back.
5350 * charset.c (Fdefine_charset_internal, Fdecode_char):
5351 Use cons_to_unsigned to catch overflow.
5352 (Fencode_char): Use INTEGER_TO_CONS.
5353 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5354 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5355 * data.c (long_to_cons, cons_to_long): Remove.
5356 (cons_to_unsigned, cons_to_signed): New functions.
5357 These signal an error for invalid or out-of-range values.
5358 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5359 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5360 * font.c (Ffont_variation_glyphs):
5361 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5362 * lisp.h: Include <intprops.h>.
5363 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5364 (cons_to_signed, cons_to_unsigned): New decls.
5365 (long_to_cons, cons_to_long): Remove decls.
5366 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5367 (Fprimitive_undo): Use CONS_TO_INTEGER.
5368 * xfns.c (Fx_window_property): Likewise.
5369 * xselect.c: Include <limits.h>.
5370 (x_own_selection, selection_data_to_lisp_data):
5371 Use INTEGER_TO_CONS.
5372 (x_handle_selection_request, x_handle_selection_clear)
5373 (x_get_foreign_selection, Fx_disown_selection_internal)
5374 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5375 (lisp_data_to_selection_data): Use cons_to_unsigned.
5376 (x_fill_property_data): Use cons_to_signed.
5377 Report values out of range.
5378
5379 Check for buffer and string overflow more precisely.
5380 * buffer.h (BUF_BYTES_MAX): New macro.
5381 * lisp.h (STRING_BYTES_MAX): New macro.
5382 * alloc.c (Fmake_string):
5383 * character.c (string_escape_byte8):
5384 * coding.c (coding_alloc_by_realloc):
5385 * doprnt.c (doprnt):
5386 * editfns.c (Fformat):
5387 * eval.c (verror):
5388 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5389 since they may not be the same number.
5390 * editfns.c (Finsert_char):
5391 * fileio.c (Finsert_file_contents):
5392 Likewise for BUF_BYTES_MAX.
5393
5394 * image.c: Use ptrdiff_t, not int, for sizes.
5395 (slurp_file): Switch from int to ptrdiff_t.
5396 All uses changed.
5397 (slurp_file): Check that file size fits in both size_t (for
5398 malloc) and ptrdiff_t (for sanity and safety).
5399
5400 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5401 if b->modtime has its maximal value.
5402
5403 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5404
5405 Don't assume time_t can fit into int.
5406 * buffer.h (struct buffer.modtime): Now time_t, not int.
5407 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5408 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5409
5410 Minor fixes for signed vs unsigned integers.
5411 * character.h (MAYBE_UNIFY_CHAR):
5412 * charset.c (maybe_unify_char):
5413 * keyboard.c (read_char, reorder_modifiers):
5414 XINT -> XFASTINT, since the integer must be nonnegative.
5415 * ftfont.c (ftfont_spec_pattern):
5416 * keymap.c (access_keymap, silly_event_symbol_error):
5417 XUINT -> XFASTINT, since the integer must be nonnegative.
5418 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5419 since it makes no difference and we prefer signed.
5420 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5421 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5422 nonnegative.
5423
5424 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5425
5426 * window.h (Fwindow_frame): Declare.
5427
5428 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5429
5430 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5431 (SPARE_MEMORY): Always define.
5432 (LARGE_REQUEST): Remove.
5433 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5434
5435 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5436
5437 * lisp.h: Move EXFUNS for Fframe_root_window,
5438 Fframe_first_window and Fset_frame_selected_window to window.h.
5439
5440 * window.h: Move EXFUNS for Fframe_root_window,
5441 Fframe_first_window and Fset_frame_selected_window here from
5442 lisp.h.
5443
5444 * frame.c (Fwindow_frame, Fframe_first_window)
5445 (Fframe_root_window, Fframe_selected_window)
5446 (Fset_frame_selected_window): Move to window.c.
5447 (Factive_minibuffer_window): Move to minibuf.c.
5448 (Fother_visible_frames_p): New function.
5449
5450 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5451
5452 * window.c (decode_window, decode_any_window): Move up in code.
5453 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5454 (inhibit_frame_unsplittable): Remove unused variable.
5455 (Fwindow_buffer): Move up and rewrite doc-string.
5456 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5457 (Fwindow_prev): New functions.
5458 (Fwindow_frame): Move here from frame.c. Accept any window as
5459 argument.
5460 (Fframe_root_window, Fframe_first_window)
5461 (Fframe_selected_window): Move here from frame.c. Accept frame
5462 or arbitrary window as argument. Update doc-strings.
5463 (Fminibuffer_window): Move up in code.
5464 (Fwindow_minibuffer_p): Move up in code and simplify.
5465 (Fset_frame_selected_window): Move here from frame.c.
5466 Marginal rewrite.
5467 (Fselected_window, select_window, Fselect_window): Move up in
5468 code. Minor doc-string fixes.
5469
5470 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5471
5472 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5473 Do not assume that spare memory exists; that assumption is valid
5474 only if SYSTEM_MALLOC.
5475 (LARGE_REQUEST): New macro, so that the issue of large requests
5476 is separated from the issue of spare memory.
5477
5478 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5479
5480 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5481 format. (Bug#8806)
5482
5483 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5484
5485 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5486 before statements.
5487
5488 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5489
5490 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5491
5492 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5493
5494 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5495 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5496
5497 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5498
5499 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5500
5501 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
5502
5503 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5504 (x_clipboard_manager_save): Add return value.
5505 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5506 New error handlers.
5507 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5508 Obey Vx_select_enable_clipboard_manager. Catch errors in
5509 x_clipboard_manager_save (Bug#8779).
5510 (Vx_select_enable_clipboard_manager): New variable.
5511 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
5512
5513 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
5514
5515 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5516
5517 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5518
5519 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5520 in the current matrix if keep_current_p is non-zero.
5521
5522 2011-06-04 Eli Zaretskii <eliz@gnu.org>
5523
5524 * bidi.c (bidi_level_of_next_char): Fix last change.
5525
5526 2011-06-03 Eli Zaretskii <eliz@gnu.org>
5527
5528 Support bidi reordering of text covered by display properties.
5529
5530 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5531 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5532 (bidi_cache_search, bidi_cache_iterator_state)
5533 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5534 (bidi_level_of_next_char, bidi_move_to_visually_next):
5535 Support character positions inside a run of characters covered by a
5536 display string.
5537 (bidi_paragraph_init, bidi_resolve_explicit_1)
5538 (bidi_level_of_next_char): Call bidi_fetch_char and
5539 bidi_fetch_char_advance instead of FETCH_CHAR and
5540 FETCH_CHAR_ADVANCE.
5541 (bidi_init_it): Initialize new members.
5542 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5543 definitions.
5544 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5545 instead of using explicit *_CHAR codes.
5546 (bidi_resolve_explicit, bidi_resolve_weak):
5547 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
5548 bidirectional text is supported only in multibyte buffers.
5549 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5550 it to initialize the frame_window_p member of struct bidi_it.
5551 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5552 (bidi_resolve_explicit, bidi_resolve_weak)
5553 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5554 bidi_it->nchars is non-positive.
5555 (bidi_level_of_next_char): Don't try to lookup the cache for the
5556 next/previous character if nothing is cached there yet, or if we
5557 were just reseat()'ed to a new position.
5558
5559 * xdisp.c (set_cursor_from_row): Set start and stop points
5560 according to the row's direction when priming the loop that looks
5561 for the glyph on which to display cursor.
5562 (single_display_spec_intangible_p): Function deleted.
5563 (display_prop_intangible_p): Reimplement to call
5564 handle_display_spec instead of single_display_spec_intangible_p.
5565 Accept 3 additional arguments needed by handle_display_spec.
5566 This fixes incorrect cursor motion across display property with complex
5567 values: lists, `(when COND...)' forms, etc.
5568 (single_display_spec_string_p): Support property values that are
5569 lists with the argument STRING its top-level element.
5570 (display_prop_string_p): Fix the condition for processing a
5571 property that is a list to be consistent with handle_display_spec.
5572 (handle_display_spec): New function, refactored from the
5573 last portion of handle_display_prop.
5574 (compute_display_string_pos): Accept additional argument
5575 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5576 value of a `display' property is a "replacing spec".
5577 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5578 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5579 the display property, but just return a value indicating whether
5580 the display property will replace the characters it covers.
5581 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5582 frame_window_p members of struct bidi_it.
5583 (compute_display_string_pos, compute_display_string_end):
5584 New functions.
5585 (push_it): Accept second argument POSITION, where pop_it should
5586 jump to continue iteration.
5587 (reseat_1): Initialize bidi_it.disp_pos.
5588
5589 * keyboard.c (adjust_point_for_property): Adjust the call to
5590 display_prop_intangible_p to its new signature.
5591
5592 * dispextern.h (struct bidi_it): New member frame_window_p.
5593 (bidi_init_it): Update prototypes.
5594 (display_prop_intangible_p): Update prototype.
5595 (compute_display_string_pos, compute_display_string_end):
5596 Declare prototypes.
5597 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5598 EMACS_INT.
5599
5600 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
5601
5602 Malloc failure behavior now depends on size of allocation.
5603 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5604 * lisp.h: Change signatures accordingly.
5605 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5606 All callers changed. (Bug#8762)
5607
5608 * gnutls.c: Use Emacs's memory allocators.
5609 Without this change, the gnutls library would invoke malloc etc.
5610 directly, which causes problems on non-SYNC_INPUT hosts, and which
5611 runs afoul of improving memory_full behavior. (Bug#8761)
5612 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5613 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5614 xfree instead of the default malloc, realloc, free.
5615 (Fgnutls_boot): No need to check for memory allocation failure,
5616 since xmalloc does that for us.
5617
5618 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
5619 * category.c (hash_get_category_set):
5620 * ccl.c (ccl_driver):
5621 * charset.c (Fdefine_charset_internal):
5622 * charset.h (struct charset.hash_index):
5623 * composite.c (get_composition_id, gstring_lookup_cache)
5624 (composition_gstring_put_cache):
5625 * composite.h (struct composition.hash_index):
5626 * dispextern.h (struct image.hash):
5627 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5628 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5629 (hashfn_equal, hashfn_user_defined, make_hash_table)
5630 (maybe_resize_hash_table, hash_lookup, hash_put)
5631 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5632 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5633 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5634 * image.c (make_image, search_image_cache, lookup_image)
5635 (xpm_put_color_table_h):
5636 * lisp.h (struct Lisp_Hash_Table):
5637 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
5638 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
5639 for hashes and hash indexes, instead of 'unsigned' and 'int'.
5640 * alloc.c (allocate_vectorlike):
5641 Check for overflow in vector size calculations.
5642 * ccl.c (ccl_driver):
5643 Check for overflow when converting EMACS_INT to int.
5644 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5645 need to be updated by these changes.
5646 * fns.c (make_hash_table, maybe_resize_hash_table):
5647 Check for integer overflow with large hash tables.
5648 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5649 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5650 (SXHASH_REDUCE): New macro.
5651 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5652 Use it instead of discarding useful hash info with large hash values.
5653 (sxhash_float): New function.
5654 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5655 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
5656 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5657 Rewrite to use FIXNUM_BITS, as this simplifies things.
5658 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5659 Adjust signatures to match updated version of code.
5660 (consing_since_gc): Now EMACS_INT, since a single hash table can
5661 use more than INT_MAX bytes.
5662
5663 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5664
5665 Make it possible to build with GCC-4.6+ -O2 -flto.
5666
5667 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5668
5669 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5670
5671 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5672 Call minibuffer-inactive-mode.
5673
5674 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
5675
5676 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5677 Update dependencies.
5678
5679 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5680
5681 * data.c (init_data): Remove code for UTS, this system is not
5682 supported anymore.
5683
5684 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5685
5686 Don't force ./temacs to start in terminal mode.
5687
5688 * frame.c (make_initial_frame): Initialize faces in all cases, not
5689 only when CANNOT_DUMP is defined.
5690 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5691
5692 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5693
5694 * dispnew.c (add_window_display_history): Use const for the string
5695 pointer. Remove declaration, not needed.
5696
5697 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5698
5699 Use 'inline', not 'INLINE'.
5700 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
5701 * alloc.c, fontset.c (INLINE): Remove.
5702 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5703 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5704 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5705 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5706 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5707
5708 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5709
5710 Make it possible to run ./temacs.
5711
5712 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5713 syms_of_callproc does the same thing. Remove test for
5714 "initialized", do it in the caller.
5715 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5716
5717 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5718
5719 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5720 (read_minibuf): Use get_minibuffer.
5721 (syms_of_minibuf): Use DEFSYM.
5722 (Qmetadata): New var.
5723 * data.c (Qbuffer): Don't make it static.
5724 (syms_of_data): Use DEFSYM.
5725
5726 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5727
5728 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5729 (CCL_CODE_MIN): New macro.
5730
5731 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5732
5733 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5734
5735 * eval.c (Qdebug): Now static.
5736 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5737 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5738 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5739
5740 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5741
5742 * image.c: Various fixes to ImageMagick code comments.
5743 (Fimagemagick_types): Doc fix.
5744
5745 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5746
5747 Minor fixes prompted by GCC 4.6.0 warnings.
5748
5749 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5750
5751 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5752 (x_clipboard_manager_save_all): Move extern decl to ...
5753 * xterm.h: ... here, so that it can be checked for consistency.
5754
5755 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5756
5757 * xselect.c (x_clipboard_manager_save_frame)
5758 (x_clipboard_manager_save_all): New functions.
5759 (Fx_clipboard_manager_save): Lisp function deleted.
5760
5761 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5762 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5763
5764 * xterm.h: Update prototype.
5765
5766 2011-05-28 William Xu <william.xwl@gmail.com>
5767
5768 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5769 exiting (Bug#8239).
5770
5771 2011-05-28 Jim Meyering <meyering@redhat.com>
5772
5773 Avoid a sign-extension bug in crypto_hash_function.
5774 * fns.c (to_uchar): Define.
5775 (crypto_hash_function): Use it to convert some newly-signed
5776 variables to unsigned, to avoid sign-extension bugs. For example,
5777 without this change, (md5 "truc") would evaluate to
5778 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5779 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
5780 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
5781
5782 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5783
5784 Integer overflow fixes.
5785
5786 * dbusbind.c: Serial number integer overflow fixes.
5787 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
5788 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5789 to hold a serial number that is too large for a fixnum.
5790 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5791 Check for serial numbers out of range. Decode any serial number
5792 that was so large that it became a float. (Bug#8722)
5793
5794 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5795 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5796 Use XFASTINT rather than XUINT when numbers are nonnegative.
5797 (xd_append_arg, Fdbus_method_return_internal):
5798 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5799 arguments, check that Lisp number is nonnegative, rather than
5800 silently wrapping negative numbers around. (Bug#8722)
5801 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
5802 (Bug#8722)
5803
5804 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5805
5806 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5807
5808 ccl: add integer overflow checks
5809 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5810 (IN_INT_RANGE): New macros.
5811 (ccl_driver): Use them to check for integer overflow when
5812 decoding a CCL program. Many of the new checks are whether XINT (x)
5813 fits in int; it doesn't always, on 64-bit hosts. The new version
5814 doesn't catch all possible integer overflows, but it's an
5815 improvement. (Bug#8719)
5816
5817 * alloc.c (make_event_array): Use XINT, not XUINT.
5818 There's no need for unsigned here.
5819
5820 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5821 This follows up to the 2011-05-06 change that substituted uintptr_t
5822 for EMACS_INT. This case wasn't caught back then.
5823
5824 Rework Fformat to avoid integer overflow issues.
5825 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5826 now (part of C89). Include <verify.h>.
5827 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5828 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5829 (Fformat): Avoid the prepass trying to compute sizes; it was only
5830 approximate and thus did not catch overflow reliably. Instead, walk
5831 through the format just once, formatting and computing sizes as we go,
5832 checking for integer overflow at every step, and allocating a larger
5833 buffer as needed. Keep track separately whether the format is
5834 multibyte. Keep only the most-recently calculated precision, rather
5835 than them all. Record whether each argument has been converted to
5836 string. Use EMACS_INT, not int, for byte and char and arg counts.
5837 Support field widths and precisions larger than INT_MAX. Avoid
5838 sprintf's undefined behavior with conversion specifications such as %#d
5839 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5840 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5841 formatting out-of-range floating point numbers with int
5842 formats. (Bug#8668)
5843
5844 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5845
5846 * data.c: Avoid integer truncation in expressions involving floats.
5847 * data.c: Include <intprops.h>.
5848 (arith_driver): When there's an integer overflow in an expression
5849 involving floating point, convert the integers to floating point
5850 so that the resulting value does not suffer from catastrophic
5851 integer truncation. For example, on a 64-bit host (* 4
5852 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5853 Do not rely on undefined behavior after integer overflow.
5854
5855 merge count_size_as_multibyte, parse_str_to_multibyte
5856 * character.c, character.h (count_size_as_multibyte):
5857 Rename from parse_str_to_multibyte; all uses changed.
5858 Check for integer overflow.
5859 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5860 since it's now a duplicate of the other. This is more of
5861 a character than a buffer op, so better that it's in character.c.
5862 * fns.c, print.c: Adjust to above changes.
5863
5864 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5865
5866 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5867
5868 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5869
5870 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5871 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5872 (x_clipboard_manager_save): Now static.
5873 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5874
5875 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5876 (crypto_hash_function): Now static.
5877 Fix pointer signedness problems. Avoid unnecessary initializations.
5878
5879 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
5880
5881 * termhooks.h (Vselection_alist): Make it terminal-local.
5882
5883 * terminal.c (create_terminal): Initialize it.
5884
5885 * xselect.c: Support for clipboard managers.
5886 (Vselection_alist): Move to termhooks.h as terminal-local var.
5887 (LOCAL_SELECTION): New macro.
5888 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5889 (symbol_to_x_atom): Remove gratuitous arg.
5890 (x_handle_selection_request, lisp_data_to_selection_data)
5891 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
5892 (x_own_selection, x_get_local_selection, x_convert_selection):
5893 New arg, specifying work frame. Use terminal-local Vselection_alist.
5894 (some_frame_on_display): Delete unused function.
5895 (Fx_own_selection_internal, Fx_get_selection_internal)
5896 (Fx_disown_selection_internal, Fx_selection_owner_p)
5897 (Fx_selection_exists_p): New optional frame arg.
5898 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5899 (x_handle_selection_clear): Don't treat other terminals with the
5900 same keyboard specially. Use the terminal-local Vselection_alist.
5901 (x_clear_frame_selections): Use Frun_hook_with_args.
5902
5903 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5904
5905 * xterm.h: Add support for those atoms.
5906
5907 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
5908
5909 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5910 (converted_selections, conversion_fail_tag): New global variables.
5911 (x_selection_request_lisp_error): Free the above.
5912 (x_get_local_selection): Remove unnecessary code.
5913 (x_reply_selection_request): Args changed; handle arbitrary array
5914 of converted selections stored in converted_selections.
5915 Separate the XChangeProperty and SelectionNotify steps.
5916 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5917 (x_convert_selection): New function.
5918 (x_handle_selection_event): Simplify.
5919 (x_get_foreign_selection): Don't ignore incoming requests while
5920 waiting for an answer; this will fail when we implement
5921 SAVE_TARGETS, and seems unnecessary anyway.
5922 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5923 (Vx_sent_selection_functions): Doc fix.
5924
5925 2011-05-26 Leo Liu <sdl.web@gmail.com>
5926
5927 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5928
5929 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5930
5931 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5932
5933 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5934 for fringe update if it has periodic bitmap.
5935 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
5936 and fringe_bitmap_periodic_p.
5937
5938 * fringe.c (get_fringe_bitmap_data): New function.
5939 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5940 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5941 row. Mark glyph row for fringe update if periodicity changed.
5942
5943 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5944 for fringe update unless it has periodic bitmap.
5945
5946 2011-05-25 Kenichi Handa <handa@m17n.org>
5947
5948 * xdisp.c (get_next_display_element): Set correct it->face_id for
5949 a static composition.
5950
5951 2011-05-24 Leo Liu <sdl.web@gmail.com>
5952
5953 * deps.mk (fns.o):
5954 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5955
5956 * fns.c (crypto_hash_function, Fsha1): New function.
5957 (Fmd5): Use crypto_hash_function.
5958 (syms_of_fns): Add Ssha1.
5959
5960 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5961
5962 * gnutls.c: Remove unused macros.
5963 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5964 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5965 Remove macros that are defined and never used.
5966 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5967
5968 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5969
5970 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5971 (Fx_get_selection_internal): Minor cleanup.
5972 (Fx_own_selection_internal): Rename arguments for consistency with
5973 select.el.
5974
5975 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5976
5977 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5978
5979 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5980
5981 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5982
5983 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5984
5985 * dispnew.c (scrolling_window): Don't exclude the case that the
5986 last enabled row in the desired matrix touches the bottom boundary.
5987
5988 2011-05-21 Glenn Morris <rgm@gnu.org>
5989
5990 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
5991 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5992 and add some more files.
5993
5994 2011-05-20 Eli Zaretskii <eliz@gnu.org>
5995
5996 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5997 report_file_error introduced by the change from 2011-05-07.
5998
5999 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6000
6001 * systime.h (Time): Define only if emacs is defined.
6002 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6003 where the include path doesn't have X11/X.h by default. See
6004 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6005
6006 2011-05-20 Kenichi Handa <handa@m17n.org>
6007
6008 * composite.c (find_automatic_composition): Fix previous change.
6009
6010 2011-05-20 Glenn Morris <rgm@gnu.org>
6011
6012 * lisp.mk: New file, split from Makefile.in.
6013 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6014 (shortlisp): Remove.
6015 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6016
6017 2011-05-19 Glenn Morris <rgm@gnu.org>
6018
6019 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6020 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6021 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6022 (lisp): Set the order to that of loadup.el.
6023 (shortlisp): Make it a copy of $lisp.
6024 (SOME_MACHINE_LISP): Remove.
6025 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6026 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6027
6028 2011-05-18 Kenichi Handa <handa@m17n.org>
6029
6030 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6031 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6032 (find_automatic_composition): Mostly rewrite for efficiency.
6033
6034 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6035
6036 * makefile.w32-in: Update dependencies.
6037
6038 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6039
6040 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6041 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6042
6043 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6044
6045 Fix some integer overflow issues, such as string length overflow.
6046
6047 * insdel.c (count_size_as_multibyte): Check for string overflow.
6048
6049 * character.c (lisp_string_width): Check for string overflow.
6050 Use EMACS_INT, not int, for string indexes and lengths; in
6051 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6052 the resulting string length overflows an EMACS_INT; instead,
6053 report a string overflow if no precision given. When checking for
6054 precision exhaustion, use a check that cannot possibly have
6055 integer overflow. (Bug#8675)
6056 * character.h (lisp_string_width): Adjust to new signature.
6057
6058 * alloc.c (string_overflow): New function.
6059 (Fmake_string): Use it. This doesn't change behavior, but saves
6060 a few bytes and will simplify future changes.
6061 * character.c (string_escape_byte8): Likewise.
6062 * lisp.h (string_overflow): New decl.
6063
6064 Fixups, following up to the user-interface timestamp change.
6065 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6066 for UI timestamps, instead of unsigned long.
6067 * msdos.c (mouse_get_pos): Likewise.
6068 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6069 * w32gui.h (Time): Define by including "systime.h" rather than by
6070 declaring it ourselves. (Bug#8664)
6071
6072 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6073 * image.c (clear_image_cache): Likewise.
6074
6075 * term.c (term_mouse_position): Don't assume time_t wraparound.
6076
6077 Be more systematic about user-interface timestamps.
6078 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6079 and sometimes 'EMACS_UINT', to represent these timestamps.
6080 This change causes it to use 'Time' uniformly, as that's what X uses.
6081 This makes the code easier to follow, and makes it easier to catch
6082 integer overflow bugs such as Bug#8664.
6083 * frame.c (Fmouse_position, Fmouse_pixel_position):
6084 Use Time, not unsigned long, for user-interface timestamps.
6085 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6086 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6087 * keyboard.h (last_event_timestamp): Likewise.
6088 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6089 * menu.h (xmenu_show): Likewise.
6090 * term.c (term_mouse_position): Likewise.
6091 * termhooks.h (struct input_event.timestamp): Likewise.
6092 (struct terminal.mouse_position_hook): Likewise.
6093 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6094 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6095 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6096 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6097 what it was before.
6098 * menu.h, termhooks.h: Include "systime.h", for Time.
6099
6100 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6101 Don't assume that the difference between two unsigned long values
6102 can fit into an integer. At this point, we know button_down_time
6103 <= event->timestamp, so the difference must be nonnegative, so
6104 there's no need to cast the result if double-click-time is
6105 nonnegative, as it should be; check that it's nonnegative, just in
6106 case. This bug is triggered when events are more than 2**31 ms
6107 apart (about 25 days). (Bug#8664)
6108
6109 * xselect.c (last_event_timestamp): Remove duplicate decl.
6110 (x_own_selection): Remove needless cast to unsigned long.
6111
6112 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6113 that always fit in int. Use a sentinel instead of a counter, to
6114 avoid a temp and to allay GCC's concerns about possible int overflow.
6115 * frame.h (struct frame): Use int for menu_bar_items_used
6116 instead of EMACS_INT, since it always fits in int.
6117
6118 * menu.c (grow_menu_items): Check for int overflow.
6119
6120 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6121
6122 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6123 Before, the code was not consistent. These values cannot exceed
6124 2**31 - 1 so there's no need to make them unsigned.
6125 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6126 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6127 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6128 as modifiers.
6129 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6130
6131 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6132 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6133 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6134 presumably because the widths might not match.
6135
6136 * window.c (size_window): Avoid needless test at loop start.
6137
6138 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6139
6140 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6141
6142 2011-05-12 Drew Adams <drew.adams@oracle.com>
6143
6144 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6145
6146 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6147
6148 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6149 `width' to `bar_area_x' and `bar_area_width', respectively.
6150 (x_scroll_run): Take account of fringe background extension.
6151
6152 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6153 Rename local vars `left' and `width' to `bar_area_x' and
6154 `bar_area_width', respectively.
6155 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6156 background extension.
6157
6158 2011-05-10 Jim Meyering <meyering@redhat.com>
6159
6160 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6161
6162 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6163
6164 * image.c (Finit_image_library): Return t for built-in image types,
6165 like pbm and xbm. (Bug#8640)
6166
6167 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6168
6169 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6170
6171 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6172
6173 * w32console.c (Fset_screen_color): Doc fix.
6174 (Fget_screen_color): New function.
6175 (syms_of_ntterm): Defsubr it.
6176
6177 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6178 unlink the temporary file if Fcall_process didn't create it in the
6179 first place.
6180 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6181 child process will be redirected to a file specified with `:file'.
6182 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6183 cue to call_process_cleanup not to close that handle.
6184
6185 2011-05-07 Ben Key <bkey76@gmail.com>
6186
6187 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6188 one of two shell specific rules, either bootstrap-temacs-CMD or
6189 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6190 to the previous implementation of the bootstrap-temacs rule.
6191 The bootstrap-temacs-CMD rule is similar to the previous
6192 implementation of the bootstrap-temacs rule except that it
6193 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6194 variable.
6195
6196 These changes, along with some changes to nt/configure.bat,
6197 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6198 earlier fix to add support for --cflags and --ldflags options
6199 that include quotes so that it works whether make uses cmd or
6200 sh as the shell.
6201
6202 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6203
6204 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6205 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6206 is a constant.
6207 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6208 a string. Handle both cases.
6209 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6210 (Fdbus_register_method): Use Qinvalid_function.
6211
6212 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6213
6214 * makefile.w32-in: Update dependencies.
6215 (LISP_H): Add inttypes.h and stdin.h.
6216 (PROCESS_H): Add unistd.h.
6217
6218 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6219
6220 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6221 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6222
6223 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6224
6225 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6226
6227 * term.c (vfatal): Remove stray call to va_end.
6228 It's not needed and the C Standard doesn't allow it here anyway.
6229
6230 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6231 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6232
6233 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6234 bytes.
6235
6236 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6237
6238 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6239
6240 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6241
6242 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6243
6244 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6245
6246 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6247 * charset.c (Fdefine_charset_internal): Don't initialize
6248 charset.code_space[15]. The value was garbage, on hosts with
6249 32-bit int (Bug#8600).
6250
6251 * lread.c (read_integer): Be more consistent with string-to-number.
6252 Use string_to_number to do the actual conversion; this avoids
6253 rounding errors and fixes some other screwups. Without this fix,
6254 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6255 (digit_to_number): Move earlier, for benefit of read_integer.
6256 Return -1 if the digit is out of range for the base, -2 if it is
6257 not a digit in any supported base. (Bug#8602)
6258
6259 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6260
6261 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6262 to match comment at start of function. This also removes a
6263 GCC warning about overflow in a 32+64-bit port.
6264
6265 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6266
6267 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6268 Reported by Stefan Monnier in
6269 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6270 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6271 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6272
6273 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6274 (EMACS_UINTPTR): Likewise, with uintptr_t.
6275
6276 * lisp.h: Prefer 64-bit EMACS_INT if available.
6277 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6278 on 32-bit hosts that have 64-bit int, so that they can access
6279 large files.
6280 However, temporarily disable this change unless the temporary
6281 symbol WIDE_EMACS_INT is defined.
6282
6283 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6284
6285 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6286 This removes an assumption that EMACS_INT and long are the same
6287 width as pointers. The assumption is true for Emacs porting targets
6288 now, but we want to make other targets possible.
6289 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6290 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6291 In the rest of the code, change types of integers that hold casted
6292 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6293 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6294 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6295 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6296 No need to cast type when ORing.
6297 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6298 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6299 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6300 assume EMACS_INT is the same width as char *.
6301 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6302 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6303 Remove no-longer-needed casts.
6304 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6305 (xg_tool_bar_help_callback, xg_make_tool_item):
6306 Use EMACS_INTPTR to hold an integer
6307 that will be cast to void *; this can avoid a GCC warning
6308 if EMACS_INT is not the same width as void *.
6309 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6310 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6311 (current_message_1, set_message_1):
6312 Use a local to convert to proper width without a cast.
6313 * xmenu.c (dialog_selection_callback): Likewise.
6314
6315 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6316 Also, don't assume VALBITS / RAND_BITS is less than 5,
6317 and don't rely on undefined behavior when shifting a 1 left into
6318 the sign bit.
6319 * lisp.h (get_random): Change signature to match.
6320
6321 * lread.c (hash_string): Use size_t, not int, for hash computation.
6322 Normally we prefer signed values; but hashing is special, because
6323 it's better to use unsigned division on hash table sizes so that
6324 the remainder is nonnegative. Also, size_t is the natural width
6325 for hashing into memory. The previous code used 'int', which doesn't
6326 retain enough info to hash well into very large tables.
6327 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6328
6329 * dbusbind.c: Don't possibly lose pointer info when converting.
6330 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6331 Use XPNTR rather than XHASH, so that the high-order bits of
6332 the pointer aren't lost when converting through void *.
6333
6334 * eval.c (Fautoload): Don't double-shift a pointer.
6335
6336 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6337
6338 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6339
6340 * gnutls.c (DEF_GNUTLS_FN):
6341 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6342
6343 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6344
6345 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6346 marker. (Bug#8610)
6347
6348 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6349
6350 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6351 New version that can reserve upto 2GB of heap space.
6352
6353 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6354
6355 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6356
6357 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6358
6359 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6360 `gnutls_certificate_set_x509_key_file'.
6361
6362 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6363
6364 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6365 Update dependencies.
6366
6367 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6368
6369 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6370 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6371 Remove unused parameter `fildes'.
6372 * process.c (read_process_output, send_process): Don't pass it.
6373
6374 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6375
6376 Fix previous change: the library cache is defined in w32.c.
6377 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6378 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6379
6380 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6381
6382 Implement dynamic loading of GnuTLS on Windows.
6383
6384 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6385 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6386 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6387 Declare.
6388
6389 * gnutls.c (Qgnutls_dll): Define.
6390 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6391 (gnutls_*): Declare function pointers.
6392 (init_gnutls_functions): New function to initialize function pointers.
6393 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6394 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6395 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6396 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6397 (emacs_gnutls_write, emacs_gnutls_read)
6398 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6399 (Fgnutls_available_p): New function.
6400 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6401 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6402 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6403
6404 * image.c: Include w32.h.
6405 (Vimage_type_cache): Delete.
6406 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6407 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6408 (w32_delayed_load): Move to w32.c.
6409
6410 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6411
6412 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6413 (w32_delayed_load): Move from image.c. When loading a library, record
6414 its filename in the :loaded-from property of the library id.
6415 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6416 Initialize and staticpro them.
6417 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6418
6419 * process.c: Include lisp.h before w32.h, not after.
6420 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6421 instead of gnutls_record_check_pending.
6422
6423 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6424
6425 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6426
6427 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6428 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6429 as passed in.
6430
6431 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6432
6433 * xterm.c (x_set_frame_alpha): Do not set property on anything
6434 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6435
6436 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6437
6438 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6439
6440 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6441
6442 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6443 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6444 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6445 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6446 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6447 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6448 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6449 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6450 (Qgnutls_bootprop_callbacks_verify): Make static.
6451
6452 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6453
6454 * callproc.c: Indentation fixup.
6455
6456 * sysdep.c (wait_for_termination_1): Make static.
6457 (wait_for_termination, interruptible_wait_for_termination):
6458 Move after wait_for_termination_1.
6459
6460 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6461
6462 * sysdep.c (interruptible_wait_for_termination): New function
6463 which is like wait_for_termination, but allows keyboard
6464 interruptions.
6465
6466 * callproc.c (Fcall_process): Add (:file "file") as an option for
6467 the STDOUT buffer.
6468 (Fcall_process_region): Ditto.
6469
6470 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6471
6472 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6473 rather than `XVECTOR (FOO)->size'.
6474
6475 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6476 inttypes.h, as a gnulib replacement is used if it not available in
6477 system headers.
6478
6479 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6480
6481 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6482 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6483 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6484
6485 * coding.c (coding_alloc_by_realloc): Error out if destination
6486 will grow beyond MOST_POSITIVE_FIXNUM.
6487 (decode_coding_emacs_mule): Abort if there isn't enough place in
6488 charbuf for the composition carryover bytes. Reserve an extra
6489 space for up to 2 characters produced in a loop.
6490 (decode_coding_iso_2022): Abort if there isn't enough place in
6491 charbuf for the composition carryover bytes.
6492
6493 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6494
6495 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6496 aborting when %lld or %lll format is passed.
6497 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6498 %llo or %llx format is passed. (Bug#8545)
6499
6500 * window.c (window_scroll_line_based): Use a marker instead of
6501 simple variables to record original value of point. (Bug#7952)
6502
6503 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6504 produced by %s or %c overflows available buffer space. (Bug#8545)
6505
6506 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6507
6508 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
6509 (SIZE_MAX): Move defn after all includes, as they might #define it.
6510
6511 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6512
6513 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6514
6515 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6516
6517 * keyboard.c (Qdelayed_warnings_hook): Define.
6518 (command_loop_1): Run `delayed-warnings-hook'
6519 if Vdelayed_warnings_list is non-nil.
6520 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6521 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6522
6523 2011-04-28 Eli Zaretskii <eliz@gnu.org>
6524
6525 * doprnt.c (doprnt): Don't return value smaller than the buffer
6526 size if the message was truncated. (Bug#8545).
6527
6528 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6529
6530 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6531 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6532
6533 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6534
6535 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6536
6537 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
6538
6539 * makefile.w32-in: Update dependencies.
6540
6541 2011-04-27 Eli Zaretskii <eliz@gnu.org>
6542
6543 Improve `doprnt' and its usage. (Bug#8545)
6544 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6545 `format_end'. Remove support for %l as a conversion specifier.
6546 Don't use xrealloc. Improve diagnostics when the %l size modifier
6547 is used. Update the commentary.
6548
6549 * eval.c (verror): Simplify calculation of size_t.
6550
6551 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6552 messages.
6553
6554 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6555
6556 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6557 change.
6558
6559 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6560
6561 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6562 This makes this file independent of the recent pseudovector change.
6563
6564 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
6565
6566 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6567
6568 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
6569 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
6570 Remove unused local.
6571 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
6572
6573 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
6574 GCC 4.6.0 optimizes based on type-based alias analysis.
6575 For example, if b is of type struct buffer * and v of type struct
6576 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6577 != &v->size, and therefore "v->size = 1; b->size = 2; return
6578 v->size;" must therefore return 1. This assumption is incorrect
6579 for Emacs, since it type-puns struct Lisp_Vector * with many other
6580 types. To fix this problem, this patch adds a new type struct
6581 vectorlike_header that documents the constraints on layout of vectors
6582 and pseudovectors, and helps optimizing compilers not get fooled
6583 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6584 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
6585 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6586 the size member.
6587 (XSETPVECTYPE): Rewrite in terms of new macro.
6588 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6589 This is a bit clearer, and further avoids the possibility of
6590 undesirable aliasing.
6591 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
6592 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
6593 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6594 since Lisp_Subr is a special case (no "next" field).
6595 (ASIZE): Now uses header.size rather than size.
6596 All previous uses of XVECTOR (foo)->size replaced to use this macro,
6597 to avoid the hassle of writing XVECTOR (foo)->header.size.
6598 (struct vectorlike_header): New type.
6599 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6600 object, to help avoid aliasing.
6601 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6602 (SUBRP): Likewise, since Lisp_Subr is a special case.
6603 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6604 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6605 (struct Lisp_Hash_Table): Combine first two members into a single
6606 struct vectorlike_header member. All uses of "size" and "next" members
6607 changed to be "header.size" and "header.next".
6608 * buffer.h (struct buffer): Likewise.
6609 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6610 * frame.h (struct frame): Likewise.
6611 * process.h (struct Lisp_Process): Likewise.
6612 * termhooks.h (struct terminal): Likewise.
6613 * window.c (struct save_window_data, struct saved_window): Likewise.
6614 * window.h (struct window): Likewise.
6615 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6616 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6617 * buffer.c (init_buffer_once): Likewise.
6618 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6619 special case.
6620 * process.c (Fformat_network_address): Use local var for size,
6621 for brevity.
6622
6623 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6624
6625 Make the Lisp reader and string-to-float more consistent (Bug#8525)
6626 * data.c (atof): Remove decl; no longer used or needed.
6627 (digit_to_number): Move to lread.c.
6628 (Fstring_to_number): Use new string_to_number function, to be
6629 consistent with how the Lisp reader treats infinities and NaNs.
6630 Do not assume that floating-point numbers represent EMACS_INT
6631 without losing information; this is not true on most 64-bit hosts.
6632 Avoid double-rounding errors, by insisting on integers when
6633 parsing non-base-10 numbers, as the documentation specifies.
6634 * lisp.h (string_to_number): New decl, replacing ...
6635 (isfloat_string): Remove.
6636 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
6637 (read1): Do not accept +. and -. as integers; this
6638 appears to have been a coding error. Similarly, do not accept
6639 strings like +-1e0 as floating point numbers. Do not report
6640 overflow for integer overflows unless the base is not 10 which
6641 means we have no simple and reliable way to continue.
6642 Break out the floating-point parsing into a new
6643 function string_to_number, so that Fstring_to_number parses
6644 floating point numbers consistently with the Lisp reader.
6645 (digit_to_number): Move here from data.c. Make it static inline.
6646 (E_CHAR, EXP_INT): Remove, replacing with ...
6647 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6648 (string_to_number): New function, replacing isfloat_string.
6649 This function checks for valid syntax and produces the resulting
6650 Lisp float number too. Rework it so that string-to-number
6651 no longer mishandles examples like "1.0e+". Use strtoumax,
6652 so that overflow for non-base-10 numbers is reported only when
6653 there's no portable and simple way to convert to floating point.
6654
6655 * textprop.c (set_text_properties_1): Rewrite for clarity,
6656 and to avoid GCC warning about integer overflow.
6657
6658 * intervals.h (struct interval): Use EMACS_INT for members
6659 where EMACS_UINT might cause problems. See
6660 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6661 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6662 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6663 All uses changed.
6664 (offset_intervals): Tell GCC not to worry about length overflow
6665 when negating a negative length.
6666
6667 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6668 (overrun_check_free): Likewise.
6669
6670 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6671 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6672 word size.
6673
6674 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6675 (gnutls_make_error): Rename local to avoid shadowing.
6676 (gnutls_emacs_global_deinit): ifdef out; not used.
6677 (Fgnutls_boot): Use const for pointer to readonly storage.
6678 Comment out unused local. Fix pointer signedness problems.
6679
6680 * lread.c (openp): Don't stuff size_t into an 'int'.
6681 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6682 about possible signed overflow.
6683
6684 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6685 (GDK_KEY_g): Don't define if already defined.
6686 (xg_prepare_tooltip): Avoid pointer signedness problem.
6687 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6688
6689 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6690 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6691
6692 * xfns.c (Fx_window_property): Simplify a bit,
6693 to make a bit faster and to avoid GCC 4.6.0 warning.
6694 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6695
6696 * fns.c (internal_equal): Don't assume size_t fits in int.
6697
6698 * alloc.c (compact_small_strings): Tighten assertion a little.
6699
6700 Replace pEd with more-general pI, and fix some printf arg casts.
6701 * lisp.h (pI): New macro, generalizing old pEd macro to other
6702 conversion specifiers. For example, use "...%"pI"d..." rather
6703 than "...%"pEd"...".
6704 (pEd): Remove. All uses replaced with similar uses of pI.
6705 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6706 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6707 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6708 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6709 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6710 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6711 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6712 64-bit hosts.
6713 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6714 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6715 * print.c (safe_debug_print, print_object): Likewise.
6716 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6717 to int.
6718 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6719 avoiding the 0 flag, which is not portable.
6720 * process.c (Fmake_network_process): Use pI to avoid cast.
6721 * region-cache.c (pp_cache): Likewise.
6722 * xdisp.c (decode_mode_spec): Likewise.
6723 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6724 behavior on 64-bit hosts with printf arg.
6725 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
6726 (x_stop_queuing_selection_requests): Likewise.
6727 (x_get_window_property): Don't truncate byte count to an 'int'
6728 when tracing.
6729
6730 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6731 here, since it parses constructs like leading '-' and spaces,
6732 which are not wanted; and it overflows with large numbers.
6733 Instead, simply match F[0-9]+, which is what is wanted anyway.
6734
6735 * alloc.c: Remove unportable assumptions about struct layout.
6736 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6737 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6738 (allocate_vectorlike, make_pure_vector): Use the new macros,
6739 plus offsetof, to remove unportable assumptions about struct layout.
6740 These assumptions hold on all porting targets that I know of, but
6741 they are not guaranteed, they're easy to remove, and removing them
6742 makes further changes easier.
6743
6744 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6745 This doesn't fix a bug but makes the code clearer.
6746 (string_overrun_cookie): Now const. Use initializers that
6747 don't formally overflow signed char, to avoid warnings.
6748 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6749 can cause Emacs to crash when string overrun checking is enabled.
6750 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6751 multiple of sizeof (EMACS_INT); it need not be, if
6752 alignof(EMACS_INT) < sizeof (EMACS_INT).
6753 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
6754
6755 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
6756
6757 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6758
6759 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6760
6761 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
6762 supposed to be handshaking. (Bug#8556)
6763 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6764
6765 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
6766
6767 * lisp.h (Qdebug): List symbol.
6768 * eval.c (Qdebug): Restore global linkage.
6769 * keyboard.c (debug-on-event): New variable.
6770 (handle_user_signal): Break into debugger when debug-on-event
6771 matches the current signal symbol.
6772
6773 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6774
6775 * alloc.c (check_sblock, check_string_bytes)
6776 (check_string_free_list): Convert to standard C.
6777
6778 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6779
6780 * w32.c (emacs_gnutls_push): Fix typo.
6781
6782 2011-04-25 Eli Zaretskii <eliz@gnu.org>
6783
6784 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6785 "cast to pointer from integer of different size".
6786
6787 Improve doprnt and its use in verror. (Bug#8545)
6788 * doprnt.c (doprnt): Document the set of format control sequences
6789 supported by the function. Use SAFE_ALLOCA instead of always
6790 using `alloca'.
6791
6792 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6793 is one byte too soon. Don't use xrealloc; instead xfree and
6794 xmalloc anew.
6795
6796 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6797
6798 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6799 callbacks stage.
6800
6801 * gnutls.c: Renamed global_initialized to
6802 gnutls_global_initialized. Added internals for the
6803 :verify-hostname-error, :verify-error, and :verify-flags
6804 parameters of `gnutls-boot' and documented those parameters in the
6805 docstring. Start callback support.
6806 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6807 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6808 on error. Return error code.
6809 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6810 (emacs_gnutls_read): Likewise.
6811 (Fgnutls_boot): Return handshake error code.
6812 (emacs_gnutls_handle_error): New function.
6813 (wsaerror_to_errno): Likewise.
6814
6815 * w32.h (emacs_gnutls_pull): Add prototype.
6816 (emacs_gnutls_push): Likewise.
6817
6818 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6819 (emacs_gnutls_push): Likewise.
6820
6821 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6822
6823 * process.c (wait_reading_process_output): Check if GnuTLS
6824 buffered some data internally if no FDs are set for TLS
6825 connections.
6826
6827 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6828 (LIBS): Link to USER_LIBS.
6829 ($(BLD)/gnutls.$(0)): New target.
6830
6831 2011-04-24 Eli Zaretskii <eliz@gnu.org>
6832
6833 * xdisp.c (handle_single_display_spec): Rename the
6834 display_replaced_before_p argument into display_replaced_p, to
6835 make it consistent with the commentary. Fix typos in the
6836 commentary.
6837
6838 * textprop.c (syms_of_textprop): Remove dead code.
6839 (copy_text_properties): Delete obsolete commentary about an
6840 interface that was deleted long ago. Fix typos in the description
6841 of arguments.
6842
6843 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6844 to changes in oldXMenu/XMenu.h from 2011-04-16.
6845 <menu_help_message, prev_menu_help_message>: Constify.
6846 (IT_menu_make_room): menu->help_text is now `const char **';
6847 adjust.
6848
6849 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6850 to changes in oldXMenu/XMenu.h from 2011-04-16.
6851 (struct XMenu): Declare `help_text' `const char **'.
6852
6853 * xfaces.c <Qunspecified>: Make extern again.
6854
6855 * syntax.c: Include sys/types.h before including regex.h, as
6856 required by Posix.
6857
6858 * doc.c (get_doc_string): Improve the format passed to `error'.
6859
6860 * doprnt.c (doprnt): Improve commentary.
6861
6862 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6863
6864 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6865 them with etags.
6866
6867 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6868 changes in globals.h immediately force recompilation.
6869 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6870 $(CURDIR)/s/ms-w32.h.
6871 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
6872
6873 * character.c (Fchar_direction): Function deleted.
6874 (syms_of_character): Don't defsubr it.
6875 <char-direction-table>: Deleted.
6876
6877 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6878
6879 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6880 * doprnt.c: Include limits.h.
6881 (SIZE_MAX): New macro.
6882 (doprnt): Return a size_t value. 2nd arg is now size_t.
6883 Many local variables are now size_t instead of int or unsigned.
6884 Improve overflow protection. Support `l' modifier for integer
6885 conversions. Support %l conversion. Don't assume an EMACS_INT
6886 argument for integer conversions and for %c.
6887
6888 * lisp.h (doprnt): Restore prototype.
6889
6890 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6891 $(SRC)/character.h.
6892
6893 * Makefile.in (base_obj): Add back doprnt.o.
6894
6895 * deps.mk (doprnt.o): Add back prerequisites.
6896 (callint.o): Depend on character.h.
6897
6898 * eval.c (internal_lisp_condition_case): Include the handler
6899 representation in the error message.
6900 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6901 when breaking from the loop.
6902
6903 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6904
6905 * callint.c (Fcall_interactively): When displaying error message
6906 about invalid control letter, pass the character's codepoint, not
6907 a pointer to its multibyte form. Improve display of the character
6908 in octal and display also its hex code.
6909
6910 * character.c (char_string): Use %x to display the (unsigned)
6911 codepoint of an invalid character, to avoid displaying a bogus
6912 negative value.
6913
6914 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6915 `error', not SYMBOL_NAME itself.
6916
6917 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6918 character arguments to `error'.
6919
6920 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6921 to `error' in error message about FINAL_CHAR argument. Make sure
6922 FINAL_CHAR is a character, and use %c when it is passed as
6923 argument to `error'.
6924
6925 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6926
6927 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6928
6929 * w32.c: Include <time.h>.
6930 (sys_localtime): New function.
6931
6932 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
6933
6934 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6935
6936 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
6937
6938 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
6939
6940 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6941 zombies (Bug#8467).
6942
6943 2011-04-19 Eli Zaretskii <eliz@gnu.org>
6944
6945 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6946 gl_state.e_property when gl_state.object is Qt.
6947
6948 * insdel.c (make_gap_larger): Remove limitation of buffer size
6949 to <= INT_MAX.
6950
6951 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
6952
6953 * xdisp.c (lookup_glyphless_char_display)
6954 (produce_glyphless_glyph): Handle cons cell entry in
6955 glyphless-char-display.
6956 (Vglyphless_char_display): Document it.
6957
6958 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6959 glyphless-char-display.
6960
6961 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
6962
6963 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6964
6965 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6966
6967 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6968 definition for no-X builds.
6969
6970 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
6971
6972 Static checks with GCC 4.6.0 and non-default toolkits.
6973
6974 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6975
6976 * process.c (keyboard_bit_set): Define only if SIGIO.
6977 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6978 (send_process): Repair possible setjmp clobbering.
6979
6980 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6981
6982 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6983
6984 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6985
6986 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6987 Define only if needed.
6988
6989 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6990 by pacifying GCC about it. Maybe it's time to retire it?
6991 * xfaces.c (USG, __TIMEVAL__): Likewise.
6992
6993 * dispextern.h (struct redisplay_interface): Rename param
6994 to avoid shadowing.
6995 * termhooks.h (struct terminal): Likewise.
6996 * xterm.c (xembed_send_message): Likewise.
6997
6998 * insdel.c (make_gap_smaller): Define only if
6999 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7000
7001 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7002 it.
7003
7004 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7005 so that we aren't warned about unused symbols.
7006
7007 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7008
7009 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7010
7011 * xfns.c (x_real_positions): Mark locals as initialized.
7012
7013 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7014
7015 * xterm.c: Fix problems found by static analysis with other toolkits.
7016 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7017 (x_dispatch_event): Declare static if USE_GTK, and
7018 define if USE_GTK || USE_X_TOOLKIT.
7019 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7020 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7021 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7022 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7023
7024 * xmenu.c (menu_help_callback): Pointer type fixes.
7025 Use const pointers when pointing at readonly data. Avoid pointer
7026 signedness clashes.
7027 (FALSE): Remove unused macro.
7028 (update_frame_menubar): Remove unused decl.
7029
7030 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7031
7032 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7033 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7034 (single_menu_item): Rename local to avoid shadowing.
7035
7036 * keyboard.c (make_lispy_event): Remove unused local var.
7037
7038 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7039 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7040
7041 * bitmaps: Change bitmaps from unsigned char back to the X11
7042 compatible char. Avoid the old compiler warnings about
7043 out-of-range initializers by using, for example, '\xab' rather
7044 than 0xab.
7045
7046 * xgselect.c (xgselect_initialize): Check vs interface
7047 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7048
7049 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7050
7051 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7052 to read-only memory.
7053
7054 * fns.c (vector): Remove; this old hack is no longer needed.
7055
7056 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7057 Remove unused var.
7058 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7059
7060 * xrdb.c (x_load_resources): Omit unused local.
7061
7062 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7063 (x_window): Rename locals to avoid shadowing.
7064 (USG): Use the kludged USG macro, to pacify gcc.
7065
7066 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7067 (x_term_init): Remove local to avoid shadowing.
7068
7069 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7070
7071 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7072 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7073
7074 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7075
7076 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7077
7078 Fix regex.c, syntax.c and friends for buffers > 2GB.
7079 * syntax.h (struct gl_state_s): Declare character position members
7080 EMACS_INT.
7081
7082 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7083
7084 * textprop.c (verify_interval_modification, interval_of):
7085 Declare arguments EMACS_INT.
7086
7087 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7088 EMACS_INT.
7089
7090 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7091
7092 * indent.c (Fvertical_motion): Local variable it_start is now
7093 EMACS_INT.
7094
7095 * regex.c (re_match, re_match_2, re_match_2_internal)
7096 (bcmp_translate, regcomp, regexec, print_double_string)
7097 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7098 (re_compile_pattern, re_exec): Declare arguments and local
7099 variables `size_t' and `ssize_t' and return values `regoff_t', as
7100 appropriate.
7101 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7102 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7103 <compile_stack_type>: `size' and `avail' are now `size_t'.
7104
7105 * regex.h <regoff_t>: Use ssize_t, not int.
7106 (re_search, re_search_2, re_match, re_match_2): Arguments that
7107 specify buffer/string position and length are now ssize_t and
7108 size_t. Return type is regoff_t.
7109
7110 2011-04-16 Ben Key <bkey76@gmail.com>
7111
7112 * nsfont.m: Fixed bugs in ns_get_family and
7113 ns_descriptor_to_entity that were caused by using free to
7114 deallocate memory blocks that were allocated by xmalloc (via
7115 xstrdup). This caused Emacs to crash when compiled with
7116 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7117 --enable-checking=xmallocoverrun). xfree is now used to
7118 deallocate these memory blocks.
7119
7120 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7121
7122 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7123
7124 emacs_write: Accept and return EMACS_INT for sizes.
7125 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7126 et seq.
7127 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7128 Accept and return EMACS_INT.
7129 (emacs_gnutls_write): Return the number of bytes written on
7130 partial writes.
7131 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7132 (emacs_read, emacs_write): Remove check for negative size, as the
7133 Emacs source code has been audited now.
7134 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7135 (emacs_read, emacs_write): Use it.
7136 * process.c (send_process): Adjust to the new signatures of
7137 emacs_write and emacs_gnutls_write. Do not attempt to store
7138 a byte offset into an 'int'; it might overflow.
7139 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7140
7141 * sound.c: Don't assume sizes fit in 'int'.
7142 (struct sound_device.period_size, alsa_period_size):
7143 Return EMACS_INT, not int.
7144 (struct sound_device.write, vox_write, alsa_write):
7145 Accept EMACS_INT, not int.
7146 (wav_play, au_play): Use EMACS_INT to store sizes and to
7147 record read return values.
7148
7149 2011-04-15 Ben Key <bkey76@gmail.com>
7150
7151 * keyboard.c (Qundefined): Don't declare static since it is used
7152 in nsfns.m.
7153 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7154 static since they are used in nsfont.m.
7155
7156 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7157
7158 * process.c (Qprocessp): Don't declare static.
7159 * lisp.h (Qprocessp): Declare again.
7160
7161 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7162
7163 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7164
7165 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7166
7167 Improve C-level modularity by making more things 'static'.
7168
7169 Don't publish debugger-only interfaces to other modules.
7170 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7171 (verify_bytepos, count_markers): Move decls to the only modules
7172 that need them.
7173 * region-cache.h (pp_cache): Likewise.
7174 * window.h (check_all_windows): Likewise.
7175 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7176
7177 * sysdep.c (croak): Now static, if
7178 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7179 * syssignal.h (croak): Declare only if not static.
7180
7181 * alloc.c (refill_memory_reserve): Now static if
7182 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7183 * lisp.h (refill_memory_reserve): Declare only if not static.
7184
7185 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7186 Define only if USE_LUCID.
7187
7188 * xrdb.c (x_customization_string, x_rm_string): Now static.
7189
7190 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7191 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7192
7193 * xdisp.c (draw_row_with_mouse_face): Now static.
7194 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7195
7196 * window.h (check_all_windows): Mark externally visible.
7197
7198 * window.c (window_deletion_count): Now static.
7199
7200 * undo.c: Make symbols static if they're not exported.
7201 (last_undo_buffer, last_boundary_position, pending_boundary):
7202 Now static.
7203
7204 * textprop.c (interval_insert_behind_hooks): Now static.
7205 (interval_insert_in_front_hooks): Likewise.
7206
7207 * term.c: Make symbols static if they're not exported.
7208 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7209 (max_frame_lines, tty_set_terminal_modes):
7210 (tty_reset_terminal_modes, tty_turn_off_highlight):
7211 (get_tty_terminal): Now static.
7212 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7213 * termhooks.h (term_mouse_moveto): Do not declare if
7214 HAVE_WINDOW_SYSTEM.
7215 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7216 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7217
7218 * sysdep.c: Make symbols static if they're not exported.
7219 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7220 Now static.
7221 (sigprocmask_set, full_mask): Remove; unused.
7222 (wait_debugging): Mark as visible.
7223 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7224 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7225
7226 * syntax.c (syntax_temp): Define only if !__GNUC__.
7227
7228 * sound.c (current_sound_device, current_sound): Now static.
7229
7230 * search.c (searchbufs, searchbuf_head): Now static.
7231
7232 * scroll.c (scroll_cost): Remove; unused.
7233 * dispextern.h (scroll_cost): Remove decl.
7234
7235 * region-cache.h (pp_cache): Mark as externally visible.
7236
7237 * process.c: Make symbols static if they're not exported.
7238 (process_tick, update_tick, create_process, chan_process):
7239 (Vprocess_alist, proc_buffered_char, datagram_access):
7240 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7241 (deactivate_process): Mark defn as static, as well as decl.
7242 * lisp.h (create_process): Remove decl.
7243 * process.h (chan_process, Vprocess_alist): Remove decls.
7244
7245 * print.c: Make symbols static if they're not exported.
7246 (print_depth, new_backquote_output, being_printed, print_buffer):
7247 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7248 (print_interval, print_number_index, initial_stderr_stream):
7249 Now static.
7250 * lisp.h (Fprinc): Remove decl.
7251 (debug_output_compilation_hack): Mark as externally visible.
7252
7253 * sysdep.c (croak): Move decl from here to syssignal.h.
7254 * syssignal.h (croak): Put it here, so the API can be checked when
7255 'croak' is called from dissociate_if_controlling_tty.
7256
7257 * minibuf.c: Make symbols static if they're not exported.
7258 (minibuf_save_list, choose_minibuf_frame): Now static.
7259 * lisp.h (choose_minibuf_frame): Remove decl.
7260
7261 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7262
7263 * lread.c: Make symbols static if they're not exported.
7264 (read_objects, initial_obarray, oblookup_last_bucket_number):
7265 Now static.
7266 (make_symbol): Remove; unused.
7267 * lisp.h (initial_obarray, make_symbol): Remove decls.
7268
7269 * keyboard.c: Make symbols static if they're not exported.
7270 (single_kboard, recent_keys_index, total_keys, recent_keys):
7271 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7272 (this_single_command_key_start, echoing, last_auto_save):
7273 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7274 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7275 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7276 (Vlispy_mouse_stem, double_click_count):
7277 Now static.
7278 (force_auto_save_soon): Define only if SIGDANGER.
7279 (ignore_mouse_drag_p): Now static if
7280 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7281 (print_help): Remove; unused.
7282 (stop_character, last_timer_event): Mark as externally visible.
7283 * keyboard.h (ignore_mouse_drag_p): Declare only if
7284 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7285 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7286 * lisp.h (echoing): Remove decl.
7287 (force_auto_save_soon): Declare only if SIGDANGER.
7288 * xdisp.c (redisplay_window): Simplify code, to make it more
7289 obvious that ignore_mouse_drag_p is not accessed if !defined
7290 USE_GTK && !defined HAVE_NS.
7291
7292 * intervals.c: Make symbols static if they're not exported.
7293 (merge_properties_sticky, merge_interval_right, delete_interval):
7294 Now static.
7295 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7296
7297 * insdel.c: Make symbols static if they're not exported.
7298 However, leave prepare_to_modify_buffer alone. It's never
7299 called from outside this function, but that appears to be a bug.
7300 (combine_after_change_list, combine_after_change_buffer):
7301 (adjust_after_replace, signal_before_change): Now static.
7302 (adjust_after_replace_noundo): Remove; unused.
7303 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7304 (signal_before_change): Remove decls.
7305
7306 * indent.c (val_compute_motion, val_vmotion): Now static.
7307
7308 * image.c: Make symbols static if they're not exported.
7309 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7310 if USE_GTK.
7311 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7312 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7313
7314 * fringe.c (standard_bitmaps): Now static.
7315 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7316
7317 * frame.c: Make symbols static if they're not exported.
7318 (x_report_frame_params, make_terminal_frame): Now static.
7319 (get_frame_param): Now static, unless HAVE_NS.
7320 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7321 (x_get_resource_string): Remove; not used.
7322 * frame.h (make_terminal_frame, x_report_frame_params):
7323 (x_get_resource_string); Remove decls.
7324 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7325 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7326
7327 * font.c, fontset.c: Make symbols static if they're not exported.
7328 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7329 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7330 * font.c (font_close_object): Now static.
7331 * font.h (font_close_object): Remove.
7332 * fontset.c (FONTSET_OBJLIST): Remove.
7333 (free_realized_fontset) #if-0 the body, which does nothing.
7334 (face_suitable_for_char_p): #if-0, as it's never called.
7335 * fontset.h (face_suitable_for_char_p): Remove decl.
7336 * xfaces.c (face_at_string_position):
7337 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7338 since 0 is always ASCII.
7339
7340 * fns.c (weak_hash_tables): Now static.
7341
7342 * fileio.c: Make symbols static if they're not exported.
7343 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7344 (Vwrite_region_annotation_buffers): Now static.
7345
7346 * eval.c: Make symbols static if they're not exported.
7347 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7348 * lisp.h (backtrace_list): Remove decl.
7349
7350 * emacs.c: Make symbols static if they're not exported.
7351 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7352 (fatal_error_code, fatal_error_signal_hook, standard_args):
7353 Now static.
7354 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7355 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7356 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7357 * lisp.h (fatal_error_signal_hook): Remove decl.
7358 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7359
7360 * editfns.c: Move a (normally-unused) function to its only use.
7361 * editfns.c, lisp.h (get_operating_system_release): Remove.
7362 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7363 worth the hassle of breaking this out.
7364
7365 * xterm.c: Make symbols static if they're not exported.
7366 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7367 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7368 (x_destroy_window, x_delete_display):
7369 Now static.
7370 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7371 (x_mouse_leave): Remove; unused.
7372 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7373 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7374 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7375 Remove decls.
7376 (x_mouse_leave): Declare only if WINDOWSNT.
7377 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7378 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7379 USE_X_TOOLKIT.
7380
7381 * ftxfont.c: Make symbols static if they're not exported.
7382 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7383 HAVE_FREETYPE.
7384 * font.h (ftxfont_driver): Likewise.
7385
7386 * xfns.c: Make symbols static if they're not exported.
7387 (x_last_font_name, x_display_info_for_name):
7388 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7389 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7390 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7391 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7392 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7393 (last_show_tip_args): Now static.
7394 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7395 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7396 (x_screen_planes): Remove; unused.
7397 * dispextern.h (x_screen_planes): Remove decl.
7398
7399 * dispnew.c: Make symbols static if they're not exported.
7400 * dispextern.h (redraw_garbaged_frames, scrolling):
7401 (increment_row_positions): Remove.
7402 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7403 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7404 Now static.
7405 (redraw_garbaged_frames): Remove; unused.
7406
7407 * xfaces.c: Make symbols static if they're not exported.
7408 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7409 Remove decls.
7410 * xterm.h (defined_color): Remove decls.
7411 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7412 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7413 (menu_face_changed_default, defined_color, free_realized_face):
7414 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7415 (ascii_face_of_lisp_face): Remove; unused.
7416
7417 * xdisp.c: Make symbols static if they're not exported.
7418 * dispextern.h (scratch_glyph_row, window_box_edges):
7419 (glyph_to_pixel_coords, set_cursor_from_row):
7420 (get_next_display_element, set_iterator_to_next):
7421 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7422 (show_mouse_face): Remove decls
7423 * frame.h (message_buf_print): Likewise.
7424 * lisp.h (pop_message, set_message, check_point_in_composition):
7425 Likewise.
7426 * xterm.h (set_vertical_scroll_bar): Likewise.
7427 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7428 (message_buf_print, scratch_glyph_row, displayed_buffer):
7429 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7430 (get_next_display_element, show_mouse_face, window_box_edges):
7431 (frame_to_window_pixel_xy, check_point_in_composition):
7432 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7433 (glyph_to_pixel_coords): Remove; unused.
7434
7435 * dired.c (file_name_completion): Now static.
7436
7437 * dbusbind.c (xd_in_read_queued_messages): Now static.
7438
7439 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7440 * data.c (circular_list_error): Remove.
7441
7442 * commands.h (last_point_position, last_point_position_buffer):
7443 (last_point_position_window): Remove decls.
7444 * keyboard.c: Make these variables static.
7445
7446 * coding.h (coding, code_convert_region, encode_coding_gap):
7447 Remove decls.
7448 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7449 (iso_code_class, detect_coding, code_convert_region): Now static.
7450 (encode_coding_gap): Remove; unused.
7451
7452 * chartab.c (chartab_chars, chartab_bits): Now static.
7453
7454 * charset.h (charset_iso_8859_1): Remove decl.
7455 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7456 Now static.
7457
7458 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7459 * ccl.c (Vccl_program_table): Now static.
7460 (check_ccl_update): Remove; unused.
7461
7462 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7463 * category.h: ... from here.
7464 * category.c (check_category_table, set_category_set): Now static.
7465
7466 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7467 * lisp.h: Remove these decls.
7468
7469 * buffer.c (buffer_count): Remove unused var.
7470
7471 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7472 so that it's not optimized away.
7473 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7474 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7475 exported only to the debugger.
7476
7477 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7478 * atimer.h (run_all_atimers): Remove; not exported.
7479
7480 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7481 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7482 was inaccessible from Lisp.
7483 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7484 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7485
7486 alloc.c: Import and export fewer symbols, and remove unused items.
7487 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7488 is defined.
7489 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7490 it's not optimized away by whole-program optimization.
7491 (message_enable_multibyte, free_misc): Remove.
7492 (catchlist, handlerlist, mark_backtrace):
7493 Declare only if BYTE_MARK_STACK.
7494 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7495 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7496 (message_enable_multibyte): Remove decl.
7497 (free_misc, interval_free_list, float_block, float_block_index):
7498 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7499 (cons_free_list, last_marked_index):
7500 Now static.
7501 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7502 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7503 (mark_backtrace): Define only if BYTE_MARK_STACK.
7504 * xdisp.c (message_enable_multibyte): Now static.
7505
7506 Declare Lisp_Object Q* variables to be 'static' if not exported.
7507 This makes it easier for human readers (and static analyzers)
7508 to see whether these variables are used from other modules.
7509 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7510 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7511 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7512 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7513 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7514 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7515 * xmenu.c, xselect.c:
7516 Declare Q* vars static if they are not used in other modules.
7517 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7518 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7519 Remove decls of unexported vars.
7520 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7521
7522 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7523
7524 Make Emacs functions such as Fatom 'static' by default.
7525 This makes it easier for human readers (and static analyzers)
7526 to see whether these functions can be called from other modules.
7527 DEFUN now defines a static function. To make the function external
7528 so that it can be used in other C modules, use the new macro DEFUE.
7529 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7530 (Finit_image_library):
7531 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7532 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7533 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7534 Remove decls, since these functions are now static.
7535 (Funintern, Fget_internal_run_time): New decls, since these functions
7536 were already external.
7537
7538 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7539 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7540 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7541 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7542 * keyboard.c, keymap.c, lread.c:
7543 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7544 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7545 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7546 Mark functions with DEFUE instead of DEFUN,
7547 if they are used in other modules.
7548 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7549 decls for now-static functions.
7550 * buffer.h (Fdelete_overlay): Remove decl.
7551 * callproc.c (Fgetenv_internal): Mark as internal.
7552 * composite.c (Fremove_list_of_text_properties): Remove decl.
7553 (Fcomposition_get_gstring): New forward static decl.
7554 * composite.h (Fcomposite_get_gstring): Remove decl.
7555 * dired.c (Ffile_attributes): New forward static decl.
7556 * doc.c (Fdocumntation_property): New forward static decl.
7557 * eval.c (Ffetch_bytecode): New forward static decl.
7558 (Funintern): Remove extern decl; now in .h file where it belongs.
7559 * fileio.c (Fmake_symbolic_link): New forward static decl.
7560 * image.c (Finit_image_library): New forward static decl.
7561 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7562 * intervals.h (Fprevious_property_change):
7563 (Fremove_list_of_text_properties): Remove decls.
7564 * keyboard.c (Fthis_command_keys): Remove decl.
7565 (Fcommand_execute): New forward static decl.
7566 * keymap.c (Flookup_key): New forward static decl.
7567 (Fcopy_keymap): Now static.
7568 * keymap.h (Flookup_key): Remove decl.
7569 * process.c (Fget_process): New forward static decl.
7570 (Fprocess_datagram_address): Mark as internal.
7571 * syntax.c (Fsyntax_table_p): New forward static decl.
7572 (skip_chars): Remove duplicate decl.
7573 * textprop.c (Fprevious_property_change): New forward static decl.
7574 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7575 Now internal.
7576 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7577 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7578
7579 * editfns.c (Fformat): Remove unreachable code.
7580
7581 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7582
7583 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7584 change. (Bug#8496)
7585
7586 2011-04-13 Eli Zaretskii <eliz@gnu.org>
7587
7588 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7589 when at ZV. (Bug#8487)
7590
7591 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7592
7593 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7594 (Bug#8437)
7595 * keyboard.c (parse_tool_bar_item): Likewise.
7596 * sound.c (sound_cleanup, alsa_close): Likewise.
7597 * termcap.c (tgetent): Likewise.
7598 * xfns.c (x_default_font_parameter): Likewise.
7599 * xsettings.c (read_and_apply_settings): Likewise.
7600
7601 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7602 (overrun_check_free): Protoize.
7603
7604 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7605
7606 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7607 since callers should never pass a negative size.
7608 Change the signature to match that of plain 'read' and 'write'; see
7609 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7610 * lisp.h: Update prototypes of emacs_write and emacs_read.
7611
7612 2011-04-11 Eli Zaretskii <eliz@gnu.org>
7613
7614 * xdisp.c (redisplay_window): Don't try to determine the character
7615 position of the scroll margin if the window start point w->startp
7616 is outside the buffer's accessible region. (Bug#8468)
7617
7618 2011-04-10 Eli Zaretskii <eliz@gnu.org>
7619
7620 Fix write-region and its subroutines for buffers > 2GB.
7621 * fileio.c (a_write, e_write): Modify declaration of arguments and
7622 local variables to support buffers larger than 2GB.
7623 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7624
7625 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7626 argument, local variables, and return value.
7627
7628 * lisp.h: Update prototypes of emacs_write and emacs_read.
7629
7630 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7631
7632 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
7633
7634 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7635
7636 Fix more problems found by GCC 4.6.0's static checks.
7637
7638 * xdisp.c (vmessage): Use a better test for character truncation.
7639
7640 * charset.c (load_charset_map): <, not <=, for optimization,
7641 and to avoid potential problems with integer overflow.
7642 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
7643 * casetab.c (set_identity, shuffle): Likewise.
7644 * editfns.c (Fformat): Likewise.
7645 * syntax.c (skip_chars): Likewise.
7646
7647 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7648 This also lets GCC 4.6.0 generate slightly better loop code.
7649
7650 * callint.c (Fcall_interactively): <, not <=, for optimization.
7651 (Fcall_interactively): Count the number of arguments produced,
7652 not the number of arguments given. This is simpler and lets GCC
7653 4.6.0 generate slightly better code.
7654
7655 * ftfont.c: Distingish more carefully between FcChar8 and char.
7656 The previous code passed unsigned char * to a functions like
7657 strlen and xstrcasecmp that expect char *, which does not
7658 conform to the C standard.
7659 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7660 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7661 char * when the C standard requires it.
7662
7663 * keyboard.c (read_char): Remove unused var.
7664
7665 * eval.c: Port to Windows vsnprintf (Bug#8435).
7666 Include <limits.h>.
7667 (SIZE_MAX): Define if the headers do not.
7668 (verror): Do not give up if vsnprintf returns a negative count.
7669 Instead, grow the buffer. This ports to Windows vsnprintf, which
7670 does not conform to C99. Problem reported by Eli Zaretskii.
7671 Also, simplify the allocation scheme, by avoiding the need for
7672 calling realloc, and removing the ALLOCATED variable.
7673
7674 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7675
7676 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7677 But keep the doprint source code for now, as we might revamp it
7678 and use it again (Bug#8435).
7679 * lisp.h (doprnt): Remove.
7680 * Makefile.in (base_obj): Remove doprnt.o.
7681 * deps.mk (doprnt.o): Remove.
7682
7683 error: Print 32- and 64-bit integers portably (Bug#8435).
7684 Without this change, on typical 64-bit hosts error ("...%d...", N)
7685 was used to print both 32- and 64-bit integers N, which relied on
7686 undefined behavior.
7687 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7688 New macro.
7689 * lisp.h (error, verror): Mark as printf-like functions.
7690 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7691 Report overflow in size calculations when allocating printf buffer.
7692 Do not truncate output string at its first null byte.
7693 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7694 Truncate the output at a character boundary, since vsnprintf does not
7695 do that.
7696 * charset.c (check_iso_charset_parameter): Convert internal
7697 character to string before calling 'error', since %c now has the
7698 printf meaning.
7699 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7700 overflow when computing char to be passed to 'error'. Do not
7701 pass Lisp_Object to 'error'; pass the integer instead.
7702 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7703 formatted with plain %d.
7704
7705 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7706
7707 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7708
7709 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7710
7711 * xterm.c (x_catch_errors): Remove duplicate declaration.
7712
7713 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7714
7715 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7716
7717 2011-04-10 Jim Meyering <meyering@redhat.com>
7718
7719 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7720 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7721 return ssize_t not "int", and use size_t as the buffer length.
7722 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7723 * gnutls.h: Update declarations.
7724 * process.c (read_process_output): Use ssize_t, to match.
7725 (send_process): Likewise.
7726
7727 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7728
7729 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7730
7731 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7732
7733 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7734 Use unsigned char, to match FcChar8 type definition.
7735
7736 * xterm.c (handle_one_xevent):
7737 * xmenu.c (create_and_show_popup_menu):
7738 * xselect.c (x_decline_selection_request)
7739 (x_reply_selection_request): Avoid type-punned deref of X events.
7740
7741 2011-04-09 Eli Zaretskii <eliz@gnu.org>
7742
7743 Fix some uses of `int' instead of EMACS_INT.
7744 * search.c (string_match_1, fast_string_match)
7745 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7746 (scan_buffer, find_next_newline_no_quit)
7747 (find_before_next_newline, search_command, Freplace_match)
7748 (Fmatch_data): Make some `int' variables be EMACS_INT.
7749
7750 * xdisp.c (display_count_lines): 3rd argument and return value now
7751 EMACS_INT. All callers changed.
7752 (pint2hrstr): Last argument is now EMACS_INT.
7753
7754 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7755 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7756 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7757 (decode_coding_utf_16, decode_coding_emacs_mule)
7758 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7759 (decode_coding_ccl, decode_coding_charset)
7760 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7761 (decode_coding_iso_2022, decode_coding_emacs_mule)
7762 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7763 <char_offset, last_offset>: Declare EMACS_INT.
7764 (encode_coding_utf_8, encode_coding_utf_16)
7765 (encode_coding_emacs_mule, encode_invocation_designation)
7766 (encode_designation_at_bol, encode_coding_iso_2022)
7767 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7768 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7769 Declare EMACS_INT.
7770 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7771 (encode_invocation_designation): Last argument P_NCHARS is now
7772 EMACS_INT.
7773 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7774 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7775
7776 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7777 All users changed.
7778
7779 * ccl.c (Fccl_execute_on_string): Declare some variables
7780 EMACS_INT.
7781
7782 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
7783
7784 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7785
7786 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7787
7788 * process.c (Fformat_network_address): Doc fix.
7789
7790 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7791
7792 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
7793
7794 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
7795
7796 * keyboard.c (read_char): Call Lisp function help-form-show,
7797 instead of using internal_with_output_to_temp_buffer.
7798 (Qhelp_form_show): New var.
7799 (syms_of_keyboard): Use DEFSYM macro.
7800
7801 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7802
7803 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7804
7805 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
7806
7807 * process.c (Flist_processes): Remove to Lisp.
7808 (list_processes_1): Delete.
7809
7810 2011-04-06 Eli Zaretskii <eliz@gnu.org>
7811
7812 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7813
7814 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7815
7816 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
7817
7818 Fix more problems found by GCC 4.6.0's static checks.
7819
7820 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7821
7822 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7823
7824 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
7825
7826 * xdisp.c (vmessage): Mark as a printf-like function.
7827
7828 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7829
7830 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7831
7832 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7833 printf-like functions.
7834 (tiff_load): Add casts to remove these marks before passing them
7835 to system-supplied API.
7836
7837 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7838
7839 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7840 This avoids several warnings with gcc -Wstrict-overflow.
7841 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7842 directly, rather than having caller test rule sign. This avoids
7843 some unnecessary tests.
7844 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7845 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7846 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
7847
7848 * xfont.c (xfont_text_extents): Remove var that was set but not used.
7849 (xfont_open): Avoid unnecessary tests.
7850
7851 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7852
7853 * composite.h, composite.c (composition_gstring_put_cache):
7854 Use EMACS_INT, not int, for length.
7855
7856 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7857 breaking out part of COMPOSITION_DECODE_RULE.
7858 (COMPOSITION_DECODE_RULE): Use it.
7859 * composite.c (get_composition_id): Remove unused local vars,
7860 by using the new macro.
7861
7862 * textprop.c (set_text_properties_1): Change while to do-while,
7863 since the condition is always true at first.
7864
7865 * intervals.c (graft_intervals_into_buffer): Mark var as used.
7866 (interval_deletion_adjustment): Return unsigned value.
7867 All uses changed.
7868
7869 * process.c (list_processes_1, create_pty, read_process_output):
7870 (exec_sentinel): Remove vars that were set but not used.
7871 (create_pty): Remove unnecessary "volatile"s.
7872 (Fnetwork_interface_info): Avoid possibility of int overflow.
7873 (read_process_output): Do adaptive read buffering even if carryover.
7874 (read_process_output): Simplify nbytes computation if buffered.
7875
7876 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7877
7878 * syntax.c (scan_words): Remove var that was set but not used.
7879 (update_syntax_table): Use unsigned instead of int.
7880
7881 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
7882 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
7883 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
7884
7885 * print.c (print_error_message): Avoid int overflow.
7886
7887 * font.c (font_list_entities): Redo for clarity,
7888 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7889
7890 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
7891 (font_score): Avoid potential overflow in diff calculation.
7892
7893 * fns.c (substring_both): Remove var that is set but not used.
7894 (sxhash): Redo loop for clarity and to avoid wraparound warning.
7895
7896 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7897
7898 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7899 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7900 can always succeed if overflow has undefined behavior.
7901
7902 * search.c (boyer_moore, wordify): Remove vars set but not used.
7903 (wordify): Omit three unnecessary tests.
7904
7905 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7906 All callers changed. This avoids the need for an unused var.
7907
7908 * casefiddle.c (casify_region): Remove var that is set but not used.
7909
7910 * dired.c (file_name_completion): Remove var that is set but not used.
7911
7912 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7913
7914 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
7915 (Finsert_file_contents): Remove unnecessary code checking fd.
7916
7917 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7918 Check for integer overflow on size calculations.
7919
7920 * buffer.c (Fprevious_overlay_change): Remove var that is set
7921 but not used.
7922
7923 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7924 Remove vars that are set but not used.
7925 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
7926 (timer_check_2): Mark vars as initialized.
7927
7928 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7929
7930 * image.c (lookup_image): Remove var that is set but not used.
7931 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
7932
7933 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7934 that are set but not used.
7935
7936 * xfns.c (make_invisible_cursor): Don't return garbage
7937 if XCreateBitmapFromData fails (Bug#8410).
7938
7939 * xselect.c (x_get_local_selection, x_handle_property_notify):
7940 Remove vars that are set but not used.
7941
7942 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
7943 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
7944
7945 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7946 Remove var that is set but not used.
7947 (scroll_bar_windows_size): Now size_t, not int.
7948 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7949 Check for overflow.
7950
7951 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7952 (map_tty_color) [!defined MSDOS]: Likewise.
7953
7954 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7955
7956 * coding.c: Remove vars that are set but not used.
7957 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7958 All callers changed.
7959 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7960 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7961 (decode_coding_charset): Remove vars that are set but not used.
7962
7963 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7964 that is set but not used.
7965
7966 * print.c (print_object): Remove var that is set but not used.
7967
7968 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
7969 The gnulib version avoids calling malloc in the usual case,
7970 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7971 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7972 * filelock.c (current_lock_owner): Likewise.
7973 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7974 * sysdep.c: Include allocator.h, careadlinkat.h.
7975 (emacs_no_realloc_allocator): New static constant.
7976 (emacs_readlink): New function.
7977 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7978 ../lib/careadlinkat.h.
7979
7980 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7981
7982 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7983 first non-nil return value).
7984
7985 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7986
7987 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7988 if not defined (Bug#8403).
7989
7990 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7991
7992 * xdisp.c (display_count_lines): Remove parameter `start',
7993 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7994 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7995 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7996 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7997 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7998 and thereabouts. All callers changed.
7999 (get_per_char_metric): Remove parameter `f', unused since
8000 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8001
8002 2011-04-02 Jim Meyering <meyering@redhat.com>
8003
8004 do not dereference NULL upon failed strdup
8005 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8006 (ns_get_family): Likewise.
8007
8008 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8009
8010 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8011
8012 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8013
8014 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8015 later (Bug#8403).
8016
8017 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8018
8019 Add lexical binding.
8020
8021 * window.c (Ftemp_output_buffer_show): New fun.
8022 (Fsave_window_excursion):
8023 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8024
8025 * lread.c (lisp_file_lexically_bound_p): New function.
8026 (Fload): Bind Qlexical_binding.
8027 (readevalloop): Remove `evalfun' arg.
8028 Bind Qinternal_interpreter_environment.
8029 (Feval_buffer): Bind Qlexical_binding.
8030 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8031 Mark as dynamic.
8032 (syms_of_lread): Declare `lexical-binding'.
8033
8034 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8035
8036 * keyboard.c (eval_dyn): New fun.
8037 (menu_item_eval_property): Use it.
8038
8039 * image.c (parse_image_spec): Use Ffunctionp.
8040
8041 * fns.c (concat, mapcar1): Accept byte-code-functions.
8042
8043 * eval.c (Fsetq): Handle lexical vars.
8044 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8045 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8046 (FletX, Flet): Obey lexical binding.
8047 (Fcommandp): Handle closures.
8048 (Feval): New `lexical' arg.
8049 (eval_sub): New function extracted from Feval. Use it almost
8050 everywhere where Feval was used. Look up vars in lexical env.
8051 Handle closures.
8052 (Ffunctionp): Move from subr.el.
8053 (Ffuncall): Handle closures.
8054 (apply_lambda): Remove `eval_flags'.
8055 (funcall_lambda): Handle closures and new byte-code-functions.
8056 (Fspecial_variable_p): New function.
8057 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8058 but without exporting it to Lisp.
8059
8060 * doc.c (Fdocumentation, store_function_docstring):
8061 * data.c (Finteractive_form): Handle closures.
8062
8063 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8064 interactive spec.
8065
8066 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8067 New byte-codes.
8068 (exec_byte_code): New function extracted from Fbyte_code to handle new
8069 calling convention for byte-code-functions. Add new byte-codes.
8070
8071 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8072
8073 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8074
8075 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8076
8077 * xdisp.c (redisplay_internal): Fix prototype.
8078
8079 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8080
8081 * xdisp.c (SCROLL_LIMIT): New macro.
8082 (try_scrolling): Use it when setting scroll_limit.
8083 Limit scrolling to 100 screen lines.
8084 (redisplay_window): Even when falling back on "recentering",
8085 position point in the window according to scroll-conservatively,
8086 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8087
8088 (try_scrolling): When point is above the window, allow searching
8089 as far as scroll_max, or one screenful, to compute vertical
8090 distance from PT to the scroll margin position. This prevents
8091 try_scrolling from unnecessarily failing when
8092 scroll-conservatively is set to a value slightly larger than the
8093 window height. Clean up the case of PT below the margin at bottom
8094 of window: scroll_max can no longer be INT_MAX. When aggressive
8095 scrolling is in use, don't let point enter the opposite scroll
8096 margin as result of the scroll.
8097 (syms_of_xdisp) <scroll-conservatively>: Document the
8098 threshold of 100 lines for never-recentering scrolling.
8099
8100 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8101
8102 * dispextern.h (move_it_by_lines):
8103 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8104 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8105 (message_log_check_duplicate): Remove parameters `prev_bol' and
8106 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8107 (redisplay_internal): Remove parameter `preserve_echo_area',
8108 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8109
8110 * indent.c (Fvertical_motion):
8111 * window.c (window_scroll_pixel_based, Frecenter):
8112 Don't pass `need_y_p' to `move_it_by_lines'.
8113
8114 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8115
8116 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8117 steal a few bits to be more compact.
8118 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8119 Remove unneeded casts.
8120
8121 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8122
8123 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8124
8125 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8126 binding" message (bug#7967).
8127
8128 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8129
8130 Fix more problems found by GCC 4.6.0's static checks.
8131
8132 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8133 Remove unused local var.
8134
8135 * editfns.c (Fmessage_box): Remove unused local var.
8136
8137 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8138 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8139 Omit unused local vars.
8140 * window.c (shrink_windows): Omit unused local var.
8141 * menu.c (digest_single_submenu): Omit unused local var.
8142 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8143 Omit unused local var.
8144
8145 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8146 Don't assume string length fits in int.
8147 (keyremap_step, read_key_sequence): Use size_t for sizes.
8148 (read_key_sequence): Don't check last_real_key_start redundantly.
8149
8150 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8151 instead of alloca (Bug#8344).
8152
8153 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8154 (Fbacktrace_frame): Don't assume nframes fits in int.
8155
8156 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8157
8158 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8159 concerns.
8160
8161 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8162
8163 * cm.c (calccost): Turn while-do into do-while, for clarity.
8164
8165 * keyboard.c (syms_of_keyboard): Use the same style as later
8166 in this function when indexing through an array. This also
8167 works around GCC bug 48267.
8168
8169 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8170
8171 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8172
8173 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8174 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8175
8176 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8177 This avoids undefined behavior on integer overflow, and is a bit
8178 more convenient anyway since it is compared to a size_t variable.
8179
8180 Variadic C functions now count arguments with size_t, not int.
8181 This avoids an unnecessary limitation on 64-bit machines, which
8182 caused (substring ...) to crash on large vectors (Bug#8344).
8183 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8184 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8185 All variadic functions and their callers changed accordingly.
8186 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8187 * data.c (arith_driver, float_arith_driver): Likewise.
8188 * editfns.c (general_insert_function): Likewise.
8189 * eval.c (struct backtrace.nargs, interactive_p)
8190 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8191 (funcall_lambda, mark_backtrace): Likewise.
8192 * fns.c (concat): Likewise.
8193 * frame.c (x_set_frame_parameters): Likewise.
8194 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8195 0 if not found, not -1. All callers changed.
8196
8197 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8198 (stack_copy_size): Now size_t, not int.
8199 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8200
8201 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8202
8203 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8204 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8205 All callers changed.
8206
8207 * lisp.h (multibyte_char_to_unibyte):
8208 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8209 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8210 * character.h (CHAR_TO_BYTE8):
8211 * cmds.c (internal_self_insert):
8212 * editfns.c (general_insert_function):
8213 * keymap.c (push_key_description):
8214 * search.c (Freplace_match):
8215 * xdisp.c (message_dolog, set_message_1): All callers changed.
8216
8217 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8218
8219 * keyboard.c (safe_run_hook_funcall): New function.
8220 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8221 don't set the hook to nil, but remove the offending function instead.
8222 (Qcommand_hook_internal): Remove, unused.
8223 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8224 Vcommand_hook_internal.
8225
8226 * eval.c (enum run_hooks_condition): Remove.
8227 (funcall_nil, funcall_not): New functions.
8228 (run_hook_with_args): Call each function through a `funcall' argument.
8229 Remove `cond' argument, now redundant.
8230 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8231 (Frun_hook_with_args_until_failure): Adjust accordingly.
8232 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8233
8234 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8235
8236 * dispextern.h (string_buffer_position): Remove declaration.
8237
8238 * print.c (strout): Remove parameter `multibyte', unused since
8239 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8240
8241 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8242 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8243 All callers changed.
8244
8245 * w32.c (_wsa_errlist): Use braces for struct initializers.
8246
8247 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8248 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8249 All callers changed.
8250 (string_buffer_position): Likewise. Also, make static (it's never
8251 used outside xdisp.c).
8252 (cursor_row_p): Remove parameter `w', unused since
8253 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8254 (decode_mode_spec): Remove parameter `precision', introduced during
8255 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8256 All callers changed.
8257
8258 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8259
8260 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8261
8262 2011-03-27 Anders Lindgren <andlind@gmail.com>
8263
8264 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8265 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8266 (ns_update_auto_hide_menu_bar): New functions.
8267 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8268 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8269 ns_constrain_all_frames.
8270 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8271 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8272
8273 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8274
8275 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8276
8277 2011-03-27 Glenn Morris <rgm@gnu.org>
8278
8279 * syssignal.h: Replace RETSIGTYPE with void.
8280 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8281 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8282 Replace SIGTYPE with void everywhere.
8283 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8284 * s/template.h (SIGTYPE): Remove commented out definition.
8285
8286 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8287
8288 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8289 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8290
8291 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8292
8293 * w32.c (read_unc_volume): Use parameter `henum', instead of
8294 global variable `wget_enum_handle'.
8295
8296 * keymap.c (describe_vector): Remove parameters `indices' and
8297 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8298 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8299
8300 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8301
8302 * keyboard.c (timer_check): Remove parameter `do_it_now',
8303 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8304 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8305 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8306
8307 * keyboard.c (read_char):
8308 * w32menu.c (w32_menu_display_help):
8309 * xmenu.c (show_help_event, menu_help_callback):
8310 Adjust calls to `show_help_echo'.
8311
8312 * gtkutil.c (xg_maybe_add_timer):
8313 * keyboard.c (readable_events):
8314 * process.c (wait_reading_process_output):
8315 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8316
8317 * insdel.c (adjust_markers_gap_motion):
8318 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8319 (gap_left, gap_right): Don't call it.
8320
8321 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8322
8323 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8324 incurred during fontification.
8325
8326 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8327
8328 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8329 (DEFVAR_PER_BUFFER): Don't pass it.
8330
8331 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8332 (scrolling_window): Don't pass it.
8333
8334 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8335
8336 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8337
8338 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8339 and `suffix'.
8340 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8341 of variables specific to SELinux and computation of `encoded_absname'.
8342
8343 * image.c (XPutPixel): Remove unused variable `height'.
8344
8345 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8346
8347 * unexw32.c (get_section_info): Remove unused variable `section'.
8348
8349 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8350 (system_process_attributes): Remove unused variable `sess'.
8351 (sys_read): Remove unused variable `err'.
8352
8353 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8354 (w32_wnd_proc): Remove unused variable `isdead'.
8355 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8356 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8357 (x_create_tip_frame): Remove unused variable `tem'.
8358
8359 * w32inevt.c (w32_console_read_socket):
8360 Remove unused variable `no_events'.
8361
8362 * w32term.c (x_draw_composite_glyph_string_foreground):
8363 Remove unused variable `width'.
8364
8365 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8366
8367 * w32term.c (x_set_glyph_string_clipping):
8368 Don't pass uninitialized region to CombineRgn.
8369
8370 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8371
8372 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8373 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8374 (Fx_close_connection): Remove unused variable `i'.
8375
8376 * w32font.c (w32font_draw): Return number of glyphs.
8377 (w32font_open_internal): Remove unused variable `i'.
8378 (w32font_driver): Add missing initializer.
8379
8380 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8381 (fill_in_menu): Remove unused variable `items_added'.
8382
8383 * w32term.c (last_mouse_press_frame): Remove static global variable.
8384 (w32_clip_to_row): Remove unused variable `f'.
8385 (x_delete_terminal): Remove unused variable `i'.
8386
8387 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8388 (NOTHING): Remove unused static global variable.
8389 (uniscribe_check_otf): Remove unused variable `table'.
8390 (uniscribe_font_driver): Add missing initializers.
8391
8392 2011-03-23 Julien Danjou <julien@danjou.info>
8393
8394 * term.c (Fsuspend_tty, Fresume_tty):
8395 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8396 * window.c (temp_output_buffer_show):
8397 * insdel.c (signal_before_change):
8398 * frame.c (Fhandle_switch_frame):
8399 * fileio.c (Fdo_auto_save):
8400 * emacs.c (Fkill_emacs):
8401 * editfns.c (save_excursion_restore):
8402 * cmds.c (internal_self_insert):
8403 * callint.c (Fcall_interactively):
8404 * buffer.c (Fkill_all_local_variables):
8405 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8406 Use Frun_hooks.
8407 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8408 unconditionnaly since it does the check itself.
8409
8410 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8411
8412 Fix more problems found by GCC 4.5.2's static checks.
8413
8414 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8415 the first time through the loop, since we know p0 < p1 then.
8416 This also avoids a gcc -Wstrict-overflow warning.
8417
8418 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8419 leading to a memory leak, possible in functions like
8420 load_charset_map_from_file that can allocate an unbounded number
8421 of objects (Bug#8318).
8422
8423 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8424 that could (at least in theory) be that large.
8425
8426 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8427 This is less likely to overflow, and avoids undefined behavior if
8428 overflow does occur. All callers changed. Use strtoul to scan
8429 for the unsigned long integer.
8430 (pint2hrstr): Simplify and tune code slightly.
8431 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8432
8433 * scroll.c (do_scrolling): Work around GCC bug 48228.
8434 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8435
8436 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8437 This also avoids a warning with gcc -Wstrict-overflow.
8438 (validate_x_resource_name): Simplify count usage.
8439 This also avoids a warning with gcc -Wstrict-overflow.
8440
8441 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8442 fail (Bug#8306).
8443
8444 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8445
8446 * process.c (Fmake_network_process): Use socklen_t, not int,
8447 where POSIX says socklen_t is required in portable programs.
8448 This fixes a porting bug on hosts like 64-bit HP-UX, where
8449 socklen_t is wider than int (Bug#8277).
8450 (Fmake_network_process, server_accept_connection):
8451 (wait_reading_process_output, read_process_output):
8452 Likewise.
8453
8454 * process.c: Rename or move locals to avoid shadowing.
8455 (list_processes_1, Fmake_network_process):
8456 (read_process_output_error_handler, exec_sentinel_error_handler):
8457 Rename or move locals.
8458 (Fmake_network_process): Define label "retry_connect" only if needed.
8459 (Fnetwork_interface_info): Fix pointer signedness.
8460 (process_send_signal): Add cast to avoid pointer signedness problem.
8461 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8462 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8463
8464 Make tparam.h and terminfo.c consistent.
8465 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8466 Include tparam.h instead, since it declares them.
8467 * cm.h (PC): Remove extern decl; tparam.h now does this.
8468 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8469 * terminfo.c: Include tparam.h, to check interfaces.
8470 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8471 (tparam): Adjust signature to match interface in tparam.h;
8472 this removes some undefined behavior. Check that outstring and len
8473 are zero, which they always are with Emacs.
8474 * tparam.h (PC, BC, UP): New extern decls.
8475
8476 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8477 (xftfont_open): Rename locals to avoid shadowing.
8478
8479 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8480 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8481 (OTF_TAG_SYM): Omit macro if not needed.
8482 (ftfont_list): Remove unused local.
8483 (get_adstyle_property, ftfont_pattern_entity):
8484 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8485 Rename locals to avoid shadowing.
8486
8487 * xfont.c (xfont_list_family): Mark var as initialized.
8488
8489 * xml.c (make_dom): Now static.
8490
8491 * composite.c (composition_compute_stop_pos): Rename local to
8492 avoid shadowing.
8493 (composition_reseat_it): Remove unused locals.
8494 (find_automatic_composition, composition_adjust_point): Likewise.
8495 (composition_update_it): Mark var as initialized.
8496 (find_automatic_composition): Mark vars as initialized,
8497 with a FIXME (Bug#8290).
8498
8499 character.h: Rename locals to avoid shadowing.
8500 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8501 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8502 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8503 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8504 to avoid shadowing.
8505
8506 * textprop.c (property_change_between_p): Remove; unused.
8507
8508 * intervals.c (interval_start_pos): Now static.
8509
8510 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8511
8512 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8513 Rename locals to avoid shadowing.
8514
8515 * sound.c (wav_play, au_play, Fplay_sound_internal):
8516 Fix pointer signedness.
8517 (alsa_choose_format): Remove unused local var.
8518 (wav_play): Initialize a variable to 0, to prevent undefined
8519 behavior (Bug#8278).
8520
8521 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8522
8523 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8524
8525 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8526 clobbering (Bug#8298).
8527 * sysdep.c (sys_subshell): Likewise.
8528 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
8529
8530 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8531 This should get cleaned up, so that child_setup has the
8532 same signature on all platforms.
8533
8534 * callproc.c (call_process_cleanup): Now static.
8535 (relocate_fd): Rename locals to avoid shadowing.
8536
8537 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
8538
8539 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8540 not to be necessary, and produces flickering.
8541
8542 2011-03-20 Glenn Morris <rgm@gnu.org>
8543
8544 * config.in: Remove file.
8545
8546 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
8547
8548 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8549 are now in src/globals.h.
8550 (syms_of_minibuf): Remove spurious & from previous change.
8551
8552 2011-03-20 Leo <sdl.web@gmail.com>
8553
8554 * minibuf.c (completing-read-function): New variable.
8555 (completing-read-default): Rename from completing-read.
8556 (completing-read): Call completing-read-function.
8557
8558 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8559
8560 * xfaces.c (Fx_load_color_file):
8561 Read color file from absolute filename (bug#8250).
8562
8563 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8564
8565 * makefile.w32-in: Update dependencies.
8566
8567 2011-03-17 Eli Zaretskii <eliz@gnu.org>
8568
8569 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8570
8571 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8572
8573 Fix more problems found by GCC 4.5.2's static checks.
8574
8575 * process.c (make_serial_process_unwind, send_process_trap):
8576 (sigchld_handler): Now static.
8577
8578 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8579 That way, the code declares only the vars that it needs.
8580 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8581 * s/cygwin.h (PTY_ITERATION): Likewise.
8582 * s/darwin.h (PTY_ITERATION): Likewise.
8583 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8584
8585 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8586 * process.c (allocate_pty): Don't declare stb unless it's needed.
8587
8588 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
8589 (CONSTANTLIM): Remove; unused.
8590 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8591 Define only if needed.
8592
8593 * unexelf.c (unexec): Name an expression,
8594 to avoid gcc -Wbad-function-cast warning.
8595 Use a different way to cause a compilation error if anyone uses
8596 n rather than nn, a way that does not involve shadowing.
8597 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
8598
8599 * deps.mk (unexalpha.o): Remove; unused.
8600
8601 New file unexec.h, the (simple) interface for unexec (Bug#8267).
8602 * unexec.h: New file.
8603 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8604 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8605 Depend on unexec.h.
8606 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8607 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8608 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
8609 Change as necessary to match prototype in unexec.h.
8610
8611 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8612 shadowing.
8613 (back_comment, skip_chars): Mark vars as initialized.
8614
8615 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8616 Rename locals to avoid shadowing.
8617
8618 * lread.c (read1): Rewrite so as not to use empty "else".
8619 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
8620
8621 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8622
8623 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8624 warning when compiling print.c.
8625
8626 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8627 instead of using an uninitialized var.
8628 (font_sort_entities): Mark var as initialized.
8629
8630 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8631
8632 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8633 pointers to constants.
8634 (font_parse_fcname): Remove unused vars.
8635 (font_delete_unmatched): Now static.
8636 (font_get_spec): Remove; unused.
8637 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8638 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8639 Rename or move locals to avoid shadowing.
8640
8641 * fns.c (require_nesting_list, require_unwind): Now static.
8642 (Ffillarray): Rename locals to avoid shadowing.
8643
8644 * floatfns.c (domain_error2): Define only if needed.
8645 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
8646
8647 * alloc.c (mark_backtrace): Move decl from here ...
8648 * lisp.h: ... to here, so that it can be checked.
8649
8650 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
8651 (Fdefvar): Rewrite so as not to use empty "else".
8652 (lisp_indirect_variable): Name an expression,
8653 to avoid gcc -Wbad-function-cast warning.
8654 (Fdefvar): Rename locals to avoid shadowing.
8655
8656 * callint.c (quotify_arg, quotify_args): Now static.
8657 (Fcall_interactively): Rename locals to avoid shadowing.
8658 Use const pointer when appropriate.
8659
8660 * lisp.h (get_system_name, get_operating_system_release):
8661 Move decls here, to check interfaces.
8662 * process.c (get_operating_system_release): Move decl to lisp.h.
8663 * xrdb.c (get_system_name): Likewise.
8664 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8665 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8666 some of which prompt warnings from gcc -Wbad-function-cast.
8667 (Fformat_time_string, Fencode_time, Finsert_char):
8668 (Ftranslate_region_internal, Fformat):
8669 Rename or remove local vars to avoid shadowing.
8670 (Ftranslate_region_internal): Mark var as initialized.
8671
8672 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8673 avoid shadowing.
8674
8675 * lisp.h (eassert): Check that the argument compiles, even if
8676 ENABLE_CHECKING is not defined.
8677
8678 * data.c (Findirect_variable): Name an expression, to avoid
8679 gcc -Wbad-function-cast warning.
8680 (default_value, arithcompare, arith_driver, arith_error): Now static.
8681 (store_symval_forwarding): Rename local to avoid shadowing.
8682 (Fmake_variable_buffer_local, Fmake_local_variable):
8683 Mark variables as initialized.
8684 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
8685
8686 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
8687 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8688 Rename locals to avoid shadowing.
8689 (mark_stack): Move local variables into the #ifdef region where
8690 they're used.
8691 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8692 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8693 needed otherwise.
8694 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8695 (GC_STRING_CHARS): Remove; not used.
8696 (Fmemory_limit): Cast sbrk's returned value to char *.
8697
8698 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8699 avoids undefined behavior in theory.
8700
8701 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8702
8703 Use functions, not macros, for up- and down-casing (Bug#8254).
8704 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8705 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8706 to use the following functions instead of these macros.
8707 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8708 EMACS_INT, since callers assume the returned value fits in int.
8709 (upcase1): Likewise, for UPCASE_TABLE.
8710 (uppercasep, lowercasep, upcase): New static inline functions.
8711 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
8712 the race-condition problem in the old DOWNCASE.
8713
8714 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8715 Rename locals to avoid shadowing.
8716 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
8717 (regex_compile, re_search_2, re_match_2_internal):
8718 Remove unused local vars.
8719 (FREE_VAR): Rewrite so as not to use empty "else",
8720 which gcc can warn about.
8721 (regex_compile, re_match_2_internal): Mark locals as initialized.
8722 (RETALLOC_IF): Define only if needed.
8723 (WORDCHAR_P): Likewise. This one is never needed, but is used
8724 only in a comment talking about a compiler bug, so put inside
8725 the #if 0 of that comment.
8726 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8727 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8728 Remove; unused.
8729
8730 * search.c (boyer_moore): Rename locals to avoid shadowing.
8731 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8732 (PREV_CHAR_BOUNDARY): Likewise.
8733
8734 * search.c (simple_search): Remove unused var.
8735
8736 * dired.c (compile_pattern): Move decl from here ...
8737 * lisp.h: ... to here, so that it can be checked.
8738 (struct re_registers): New forward decl.
8739
8740 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8741
8742 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8743 All uses changed.
8744 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8745 Rename locals to avoid shadowing.
8746 (Fvertical_motion): Mark locals as initialized.
8747
8748 * casefiddle.c (casify_object, casify_region): Now static.
8749 (casify_region): Mark local as initialized.
8750
8751 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8752
8753 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8754 New macros, so that the caller can use some names other than
8755 gcpro1, gcpro2, etc.
8756 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8757 of the new macros.
8758 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8759 argument, for consistency with GCPRO2_VAR, etc: it is now the
8760 prefix of the variable, not the variable itself. All uses
8761 changed.
8762 * dired.c (directory_files_internal, file_name_completion):
8763 Rename locals to avoid shadowing.
8764
8765 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8766 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8767 dired.c's scmp function, had undefined behavior.
8768 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8769 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8770 * buffer.h: ... to here, because these macros use current_buffer,
8771 and the new implementation with inline functions needs to have
8772 current_buffer in scope now, rather than later when the macros
8773 are used.
8774 (downcase, upcase1): New static inline functions.
8775 (DOWNCASE, UPCASE1): Reimplement using these functions.
8776 This avoids undefined behavior in expressions like
8777 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8778 from race conditions in accessing the global variables
8779 case_temp1 and case_temp2.
8780 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8781 * lisp.h (case_temp1, case_temp2): Remove their decls.
8782 * character.h (ASCII_CHAR_P): Move from here ...
8783 * lisp.h: ... to here, so that the inline functions mentioned
8784 above can use them.
8785
8786 * dired.c (directory_files_internal_unwind): Now static.
8787
8788 * fileio.c (file_name_as_directory, directory_file_name):
8789 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8790 Now static.
8791 (file_name_as_directory): Use const pointers when appropriate.
8792 (Fexpand_file_name): Likewise. In particular, newdir might
8793 point at constant storage, so make it a const pointer.
8794 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
8795 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8796 signedness issues.
8797 (Fset_file_times, Finsert_file_contents, auto_save_error):
8798 Rename locals to avoid shadowing.
8799
8800 * minibuf.c (choose_minibuf_frame_1): Now static.
8801 (Ftry_completion, Fall_completions): Rename or remove locals
8802 to avoid shadowing.
8803
8804 * marker.c (bytepos_to_charpos): Remove; unused.
8805
8806 * lisp.h (verify_bytepos, count_markers): New decls,
8807 so that gcc does not warn that these functions aren't declared.
8808
8809 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8810 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
8811 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
8812 (copy_text): Remove unused local var.
8813
8814 * filelock.c (within_one_second): Now static.
8815 (lock_file_1): Rename local to avoid shadowing.
8816
8817 * buffer.c (fix_overlays_before): Mark locals as initialized.
8818 (fix_start_end_in_overlays): Likewise. This function should be
8819 simplified by using pointers-to-pointers, but that's a different
8820 matter.
8821 (switch_to_buffer_1): Now static.
8822 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8823 (report_overlay_modification): Rename locals to avoid shadowing.
8824
8825 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
8826 Fix pointer signedness issue.
8827 (sys_subshell): Mark local as volatile if checking for lint,
8828 to suppress a gcc -Wclobbered warning that does not seem to be right.
8829 (MAXPATHLEN): Define only if needed.
8830
8831 * process.c (serial_open, serial_configure): Move decls from here ...
8832 * systty.h: ... to here, so that they can be checked.
8833
8834 * fns.c (get_random, seed_random): Move extern decls from here ...
8835 * lisp.h: ... to here, so that they can be checked.
8836
8837 * sysdep.c (reset_io): Now static.
8838 (wait_for_termination_signal): Remove; unused.
8839
8840 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8841 (copy_keymap_item, append_key, push_text_char_description):
8842 Now static.
8843 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
8844 (DENSE_TABLE_SIZE): Remove; unused.
8845 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8846 (describe_map_tree):
8847 Rename locals to avoid shadowing.
8848
8849 * keyboard.c: Declare functions static if they are not used elsewhere.
8850 (echo_char, echo_dash, cmd_error, top_level_2):
8851 (poll_for_input, handle_async_input): Now static.
8852 (read_char, kbd_buffer_get_event, make_lispy_position):
8853 (make_lispy_event, make_lispy_movement, apply_modifiers):
8854 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8855 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8856 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
8857 (read_key_sequence, read_char): Mark locals as initialized.
8858 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
8859
8860 * keyboard.h (make_ctrl_char): New decl.
8861 (mark_kboards): Move decl here ...
8862 * alloc.c (mark_kboards): ... from here.
8863
8864 * lisp.h (force_auto_save_soon): New decl.
8865
8866 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
8867 (DEFINE_DUMMY_FUNCTION): New macro.
8868 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8869 Use it.
8870 (main): Add casts to avoid warnings
8871 if GCC considers string literals to be constants.
8872
8873 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8874
8875 * dbusbind.c: Pointer signedness fixes.
8876 (xd_signature, xd_append_arg, xd_initialize):
8877 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8878 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8879 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8880 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8881
8882 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8883 if GCC considers string literals to be constants.
8884 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
8885
8886 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8887
8888 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8889 (print_preprocess, print_object): New macro to fix last change.
8890
8891 * print.c (print_preprocess): Don't forget font objects.
8892
8893 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
8894
8895 * emacs.c (USAGE3): Doc fixes.
8896
8897 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8898
8899 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8900 structure.
8901
8902 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
8903
8904 * lisp.h (VWindow_system, Qfile_name_history):
8905 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8906 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8907 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8908
8909 * w32select.c: Don't #include "keyboard.h".
8910 (run_protected): Add extern declaration for waiting_for_input.
8911
8912 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8913 * w32console.c (detect_input_pending, read_input_pending)
8914 (encode_terminal_code):
8915 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8916 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8917 (w32_system_caret_y, Qfile_name_history):
8918 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8919 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8920 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8921 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8922 * w32proc.c (Qlocal, report_file_error):
8923 * w32term.c (Vwindow_system, updating_frame):
8924 * w32uniscribe.c (initialized, uniscribe_font_driver):
8925 Remove unneeded extern declarations.
8926
8927 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
8928
8929 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
8930
8931 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
8932
8933 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8934 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8935 These macros can no longer be used for assignment.
8936
8937 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8938 Assign struct members directly, instead of using BUF_BEGV etc.
8939 (record_buffer_markers, fetch_buffer_markers): New functions for
8940 recording and fetching special buffer markers.
8941 (set_buffer_internal_1, set_buffer_temp): Use them.
8942
8943 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8944
8945 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8946
8947 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8948 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8949
8950 * xdisp.c (hscroll_window_tree):
8951 (reconsider_clip_changes): Use PT instead of BUF_PT.
8952
8953 2011-03-13 Eli Zaretskii <eliz@gnu.org>
8954
8955 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8956 $(EMACS_ROOT)/lib/intprops.h.
8957
8958 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8959
8960 Fix more problems found by GCC 4.5.2's static checks.
8961
8962 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8963 to unsigned char * to avoid compiler diagnostic.
8964 (xg_free_frame_widgets): Make it clear that a local variable is
8965 needed only if USE_GTK_TOOLTIP.
8966 (gdk_window_get_screen): Make it clear that this macro is needed
8967 only if USE_GTK_TOOLTIP.
8968 (int_gtk_range_get_value): New function, which avoids a diagnostic
8969 from gcc -Wbad-function-cast.
8970 (xg_set_toolkit_scroll_bar_thumb): Use it.
8971 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8972 diagnostic from gcc -Wbad-function-cast.
8973 (get_utf8_string, xg_get_file_with_chooser):
8974 Rename locals to avoid shadowing.
8975 (create_dialog): Move locals to avoid shadowing.
8976
8977 * xgselect.c (xg_select): Remove unused var.
8978
8979 * image.c (four_corners_best): Mark locals as initialized.
8980 (gif_load): Initialize transparent_p to zero (Bug#8238).
8981 Mark another local as initialized.
8982 (my_png_error, my_error_exit): Mark with NO_RETURN.
8983
8984 * image.c (clear_image_cache): Now static.
8985 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
8986 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
8987 (x_edge_detection): Remove unnecessary cast that
8988 gcc -Wbad-function-cast diagnoses.
8989 (gif_load): Fix pointer signedness.
8990 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8991 (jpeg_load, gif_load): Rename locals to avoid shadowing.
8992
8993 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
8994
8995 Improve quality of tests for time stamp overflow.
8996 For example, without this patch (encode-time 0 0 0 1 1
8997 1152921504606846976) returns the obviously-bogus value (-948597
8998 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8999 reports time overflow. See
9000 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9001 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9002 * editfns.c: Include limits.h and intprops.h.
9003 (TIME_T_MIN, TIME_T_MAX): New macros.
9004 (time_overflow): Move earlier, to before first use.
9005 (hi_time, lo_time): New functions, for an accurate test for
9006 out-of-range times.
9007 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9008 (Fget_internal_run_time): Don't assume time_t fits in int.
9009 (make_time): Use list2 instead of Fcons twice.
9010 (Fdecode_time): More accurate test for out-of-range times.
9011 (check_tm_member): New function.
9012 (Fencode_time): Use it, to test for out-of-range times.
9013 (lisp_time_argument): Don't rely on undefined left-shift and
9014 right-shift behavior when checking for time stamp overflow.
9015
9016 * editfns.c (time_overflow): New function, refactoring common code.
9017 (Fformat_time_string, Fdecode_time, Fencode_time):
9018 (Fcurrent_time_string): Use it.
9019
9020 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9021 * dired.c (make_time): Move to ...
9022 * editfns.c (make_time): ... here.
9023 * systime.h: Note the move.
9024
9025 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9026
9027 * fringe.c (update_window_fringes): Remove unused variables.
9028
9029 * unexmacosx.c (copy_data_segment): Also copy __got section.
9030 (Bug#8223)
9031
9032 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9033
9034 * termcap.c [MSDOS]: Include "msdos.h".
9035 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9036 Constify `char *' arguments and their references according to
9037 prototypes in tparam.h.
9038
9039 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9040
9041 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9042 Adapt all references accordingly.
9043
9044 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9045
9046 2011-03-11 Tom Tromey <tromey@redhat.com>
9047
9048 * buffer.c (syms_of_buffer): Remove obsolete comment.
9049
9050 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9051
9052 * termhooks.h (encode_terminal_code): Declare prototype.
9053
9054 * msdos.c (encode_terminal_code): Don't declare prototype.
9055
9056 * term.c (encode_terminal_code): Now external again, used by
9057 w32console.c and msdos.c.
9058
9059 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9060 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9061
9062 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9063
9064 Fix some minor problems found by GCC 4.5.2's static checks.
9065
9066 * fringe.c (update_window_fringes): Mark locals as initialized
9067 (Bug#8227).
9068 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9069
9070 * alloc.c (mark_fringe_data): Move decl from here ...
9071 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9072 to check its interface.
9073 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9074
9075 * fontset.c (free_realized_fontset): Now static.
9076 (Fset_fontset_font): Rename local to avoid shadowing.
9077 (fontset_font): Mark local as initialized.
9078 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9079
9080 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9081
9082 * xselect.c (x_disown_buffer_selections): Remove; not used.
9083 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9084 (x_own_selection, Fx_disown_selection_internal): Rename locals
9085 to avoid shadowing.
9086 (x_handle_dnd_message): Remove local to avoid shadowing.
9087
9088 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9089 so that the caller can use some name other than gcpro1.
9090 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9091 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9092 (Fx_backspace_delete_keys_p):
9093 Use them to avoid shadowing, and rename vars to avoid shadowing.
9094 (x_decode_color, x_set_name, x_window): Now static.
9095 (Fx_create_frame): Add braces to silence GCC warning.
9096 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9097 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9098 Remove unused locals.
9099 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9100 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9101 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9102 macros.
9103
9104 * xterm.h (x_mouse_leave): New decl.
9105
9106 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9107 Remove unused functions.
9108 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9109 (x_calc_absolute_position): Now static.
9110 (XTread_socket): Don't define label "out" unless it's used.
9111 Don't declare local "event" unless it's used.
9112 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9113 unless they are used.
9114 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9115 (x_fatal_error_signal): Remove; not used.
9116 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9117 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9118 (x_error_catcher, x_connection_closed, x_error_handler):
9119 (x_error_quitter, xembed_send_message, x_iconify_frame):
9120 (my_log_handler): Rename locals to avoid shadowing.
9121 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9122 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9123
9124 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9125 Rename or move locals to avoid shadowing.
9126 (tty_defined_color, merge_face_heights): Now static.
9127 (free_realized_faces_for_fontset): Remove; not used.
9128 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9129 does not deduce is never used uninitialized.
9130 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9131 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9132
9133 * terminal.c (store_terminal_param): Now static.
9134
9135 * xmenu.c (menu_highlight_callback): Now static.
9136 (set_frame_menubar): Remove unused local.
9137 (xmenu_show): Rename parameter to avoid shadowing.
9138 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9139 since they might point to immutable storage.
9140 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9141 since it's unused otherwise.
9142
9143 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9144 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9145 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9146 avoids a gcc -Wuninitialized diagnostic.
9147 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9148 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9149 does not deduce are never used uninitialized.
9150
9151 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9152
9153 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9154 * window.c (window_loop, size_window):
9155 (run_window_configuration_change_hook, enlarge_window): Likewise.
9156
9157 * window.c (display_buffer): Now static.
9158 (size_window): Mark variables that gcc -Wuninitialized
9159 does not deduce are never used uninitialized.
9160 * window.h (check_all_windows): New decl, to forestall
9161 gcc -Wmissing-prototypes diagnostic.
9162 * dispextern.h (bidi_dump_cached_states): Likewise.
9163
9164 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9165 shadowing.
9166 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9167 Include <limits.h>.
9168 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9169 and to avoid gcc -Wuninitialized warning.
9170 (load_charset_map): Mark variables that gcc -Wuninitialized
9171 does not deduce are never used uninitialized.
9172 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9173
9174 * coding.c (coding_set_source, coding_set_destination):
9175 Use "else { /* comment */ }" rather than "else /* comment */;"
9176 for clarity, and to avoid gcc -Wempty-body warning.
9177 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9178 a block, when the outer 'i' will do.
9179 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9180 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9181 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9182 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9183 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9184 Rename locals to avoid shadowing.
9185 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9186 * coding.c (emacs_mule_char, encode_invocation_designation):
9187 Now static, since they're not used elsewhere.
9188 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9189 (decode_coding_object, encode_coding_object, detect_coding_system):
9190 (decode_coding_emacs_mule): Mark variables that gcc
9191 -Wuninitialized does not deduce are never used uninitialized.
9192 (detect_coding_iso_2022): Initialize a local variable that might
9193 be used uninitialized. Leave a FIXME because it's not clear that
9194 this initialization is needed. (Bug#8211)
9195 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9196 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9197 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9198 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9199 Remove unused macros.
9200
9201 * category.c (hash_get_category_set): Remove unused local var.
9202 (copy_category_table): Now static, since it's not used elsewhere.
9203 * character.c (string_count_byte8): Likewise.
9204
9205 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9206 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9207
9208 * chartab.c (copy_sub_char_table): Now static, since it's not used
9209 elsewhere.
9210 (sub_char_table_ref_and_range, char_table_ref_and_range):
9211 Rename locals to avoid shadowing.
9212 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9213
9214 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9215 (BIDI_BOB): Remove unused macro.
9216
9217 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9218 deduce are never used uninitialized.
9219 * term.c (encode_terminal_code): Likewise.
9220
9221 * term.c (encode_terminal_code): Now static. Remove unused local.
9222
9223 * tparam.h: New file.
9224 * term.c, tparam.h: Include it.
9225 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9226 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9227 Move these decls to tparam.h, and make them agree with what
9228 is actually in tparam.c. The previous trick of using incompatible
9229 decls in different modules does not conform to the C standard.
9230 All callers of tparam changed to use tparam's actual API.
9231 * tparam.c (tparam1, tparam, tgoto):
9232 Use const pointers where appropriate.
9233
9234 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9235 * cm.h (struct cm): Likewise.
9236 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9237 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9238 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9239 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9240 (turn_on_face, init_tty): Likewise.
9241 * termchar.h (struct tty_display_info): Likewise.
9242
9243 * term.c (term_mouse_position): Rename local to avoid shadowing.
9244
9245 * alloc.c (mark_ttys): Move decl from here ...
9246 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9247
9248 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9249
9250 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9251
9252 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9253
9254 * search.c (compile_pattern_1): Remove argument regp, unused since
9255 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9256 (compile_pattern): Don't pass it.
9257
9258 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9259
9260 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9261 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9262 for ! HAVE_GTK3.
9263 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9264
9265 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9266
9267 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9268 gdk_window_get_screen, gdk_window_get_geometry,
9269 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9270 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9271 (xg_get_pixbuf_from_pixmap): New function.
9272 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9273 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9274 Call xg_get_pixbuf_from_pixmap instead of
9275 gdk_pixbuf_get_from_drawable.
9276 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9277 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9278 (xg_check_special_colors): Use GtkStyleContext and its functions
9279 for HAVE_GTK3.
9280 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9281 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9282 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9283 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9284 Call gtk_widget_get_preferred_size.
9285 (xg_frame_resized): gdk_window_get_geometry only takes 5
9286 parameters.
9287 (xg_win_to_widget, xg_event_is_for_menubar):
9288 Call gdk_x11_window_lookup_for_display.
9289 (xg_set_widget_bg): New function.
9290 (delete_cb): New function.
9291 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9292 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
9293 (xg_set_background_color): Call xg_set_widget_bg.
9294 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9295 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9296 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9297 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9298 if ! HAVE_GTK3.
9299 (update_frame_tool_bar): Call gtk_widget_hide.
9300 (xg_initialize): Use GDK_KEY_g.
9301
9302 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9303 if ! HAVE_GTK3
9304 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9305
9306 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9307 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9308 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9309
9310 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9311
9312 * w32xfns.c (select_palette): Check success of RealizePalette against
9313 GDI_ERROR, not zero.
9314
9315 See ChangeLog.11 for earlier changes.
9316
9317 ;; Local Variables:
9318 ;; coding: utf-8
9319 ;; End:
9320
9321 Copyright (C) 2011 Free Software Foundation, Inc.
9322
9323 This file is part of GNU Emacs.
9324
9325 GNU Emacs is free software: you can redistribute it and/or modify
9326 it under the terms of the GNU General Public License as published by
9327 the Free Software Foundation, either version 3 of the License, or
9328 (at your option) any later version.
9329
9330 GNU Emacs is distributed in the hope that it will be useful,
9331 but WITHOUT ANY WARRANTY; without even the implied warranty of
9332 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9333 GNU General Public License for more details.
9334
9335 You should have received a copy of the GNU General Public License
9336 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.