]> code.delx.au - gnu-emacs/blob - src/ChangeLog
Merge from trunk.
[gnu-emacs] / src / ChangeLog
1 2011-06-08 Paul Eggert <eggert@cs.ucla.edu>
2
3 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5 * alloc.c (make_save_value): Integer argument is now of type
6 ptrdiff_t, not int.
7 (mark_object): Use ptrdiff_t, not int.
8 * lisp.h (pD): New macro.
9 * print.c (print_object): Use it.
10
11 * alloc.c: Use EMACS_INT, not int, to count objects.
12 (total_conses, total_markers, total_symbols, total_vector_size)
13 (total_free_conses, total_free_markers, total_free_symbols)
14 (total_free_floats, total_floats, total_free_intervals, total_intervals)
15 (total_strings, total_free_strings):
16 Now EMACS_INT, not int. All uses changed.
17 (Fgarbage_collect): Compute overall total using a double, so that
18 integer overflow is less likely to be a problem. Check for overflow
19 when converting back to an integer.
20 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
21 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
22 These were 'int' variables that could overflow on 64-bit hosts;
23 they were never used, so remove them instead of repairing them.
24 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
25 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
26 Previously, this ceilinged at INT_MAX, but that doesn't work on
27 64-bit machines.
28 (allocate_pseudovector): Don't use EMACS_INT when int would do.
29
30 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
31 (allocate_vectorlike): Check for ptrdiff_t overflow.
32 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
33 when a (possibly-narrower) signed value would do just as well.
34 We prefer using signed arithmetic, to avoid comparison confusion.
35
36 * alloc.c: Catch some string size overflows that we were missing.
37 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
38 for convenience in STRING_BYTES_MAX.
39 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
40 The definition here is exact; the one in lisp.h was approximate.
41 (allocate_string_data): Check for string overflow. This catches
42 some instances we weren't catching before. Also, it catches
43 size_t overflow on (unusual) hosts where SIZE_MAX <= min
44 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
45 and ptrdiff_t and EMACS_INT are both 64 bits.
46
47 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
48 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
49 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
50
51 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
52
53 * alloc.c (Fmake_string): Check for out-of-range init.
54
55 2011-06-08 Martin Rudalics <rudalics@gmx.at>
56
57 * window.h (window): Add some new members to window structure -
58 normal_lines, normal_cols, new_total, new_normal, clone_number,
59 splits, nest, prev_buffers, next_buffers.
60 (WINDOW_TOTAL_SIZE): Move here from window.c.
61 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
62
63 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
64 Remove.
65 (make_dummy_parent): Set new members of windows structure.
66 (make_window): Move down in code. Handle new members of window
67 structure.
68 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
69 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
70 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
71 (Fset_window_prev_buffers, Fwindow_next_buffers)
72 (Fset_window_next_buffers, Fset_window_clone_number): New
73 functions.
74 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
75 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
76 Doc-string fixes.
77 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
78 Argument WINDOW can be now internal window too.
79 (Fwindow_use_time): Move up in code.
80 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
81 Rewrite doc-string.
82 (Fset_window_configuration, saved_window)
83 (Fcurrent_window_configuration, save_window_save): Handle new
84 members of window structure.
85 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
86 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
87 (syms_of_window): New Lisp objects Qrecord_window_buffer,
88 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
89 Qget_mru_window, Qresize_root_window,
90 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
91 Qauto_buffer_name; staticpro them.
92
93 2011-06-07 Martin Rudalics <rudalics@gmx.at>
94
95 * window.c (Fwindow_total_size, Fwindow_left_column)
96 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
97 (Fwindow_list_1): New functions.
98 (window_box_text_cols): Replace with window_body_cols.
99 (Fwindow_width, Fscroll_left, Fscroll_right): Use
100 window_body_cols instead of window_box_text_cols.
101 (delete_window, Fset_window_configuration): Call
102 delete_all_subwindows with window as argument.
103 (delete_all_subwindows): Take a window as argument and not a
104 structure. Rewrite.
105 (window_loop): Remove handling of GET_LRU_WINDOW and
106 GET_LARGEST_WINDOW.
107 (Fget_lru_window, Fget_largest_window): Move to window.el.
108
109 * window.h: Extern window_body_cols instead of
110 window_box_text_cols. delete_all_subwindows now takes a
111 Lisp_Object as argument.
112
113 * indent.c (compute_motion, Fcompute_motion): Use
114 window_body_cols instead of window_box_text_cols.
115
116 * frame.c (delete_frame): Call delete_all_subwindows with root
117 window as argument.
118
119 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
120
121 * fns.c (Fputhash): Document return value.
122
123 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
124
125 * image.c (gif_load): Implement gif89a spec "no disposal" method.
126
127 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
128
129 Cons<->int and similar integer overflow fixes (Bug#8794).
130
131 Check for overflow when converting integer to cons and back.
132 * charset.c (Fdefine_charset_internal, Fdecode_char):
133 Use cons_to_unsigned to catch overflow.
134 (Fencode_char): Use INTEGER_TO_CONS.
135 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
136 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
137 * data.c (long_to_cons, cons_to_long): Remove.
138 (cons_to_unsigned, cons_to_signed): New functions.
139 These signal an error for invalid or out-of-range values.
140 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
141 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
142 * font.c (Ffont_variation_glyphs):
143 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
144 * lisp.h: Include <intprops.h>.
145 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
146 (cons_to_signed, cons_to_unsigned): New decls.
147 (long_to_cons, cons_to_long): Remove decls.
148 * undo.c (record_first_change): Use INTEGER_TO_CONS.
149 (Fprimitive_undo): Use CONS_TO_INTEGER.
150 * xfns.c (Fx_window_property): Likewise.
151 * xselect.c: Include <limits.h>.
152 (x_own_selection, selection_data_to_lisp_data):
153 Use INTEGER_TO_CONS.
154 (x_handle_selection_request, x_handle_selection_clear)
155 (x_get_foreign_selection, Fx_disown_selection_internal)
156 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
157 (lisp_data_to_selection_data): Use cons_to_unsigned.
158 (x_fill_property_data): Use cons_to_signed.
159 Report values out of range.
160
161 Check for buffer and string overflow more precisely.
162 * buffer.h (BUF_BYTES_MAX): New macro.
163 * lisp.h (STRING_BYTES_MAX): New macro.
164 * alloc.c (Fmake_string):
165 * character.c (string_escape_byte8):
166 * coding.c (coding_alloc_by_realloc):
167 * doprnt.c (doprnt):
168 * editfns.c (Fformat):
169 * eval.c (verror):
170 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
171 since they may not be the same number.
172 * editfns.c (Finsert_char):
173 * fileio.c (Finsert_file_contents):
174 Likewise for BUF_BYTES_MAX.
175
176 * image.c: Use ptrdiff_t, not int, for sizes.
177 (slurp_file): Switch from int to ptrdiff_t.
178 All uses changed.
179 (slurp_file): Check that file size fits in both size_t (for
180 malloc) and ptrdiff_t (for sanity and safety).
181
182 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
183 if b->modtime has its maximal value.
184
185 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
186
187 Don't assume time_t can fit into int.
188 * buffer.h (struct buffer.modtime): Now time_t, not int.
189 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
190 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
191
192 Minor fixes for signed vs unsigned integers.
193 * character.h (MAYBE_UNIFY_CHAR):
194 * charset.c (maybe_unify_char):
195 * keyboard.c (read_char, reorder_modifiers):
196 XINT -> XFASTINT, since the integer must be nonnegative.
197 * ftfont.c (ftfont_spec_pattern):
198 * keymap.c (access_keymap, silly_event_symbol_error):
199 XUINT -> XFASTINT, since the integer must be nonnegative.
200 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
201 since it makes no difference and we prefer signed.
202 * keyboard.c (record_char): Use XUINT when all the neighbors do.
203 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
204 nonnegative.
205
206 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
207
208 * window.h (Fwindow_frame): Declare.
209
210 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
211
212 * alloc.c: Simplify handling of large-request failures (Bug#8800).
213 (SPARE_MEMORY): Always define.
214 (LARGE_REQUEST): Remove.
215 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
216
217 2011-06-06 Martin Rudalics <rudalics@gmx.at>
218
219 * lisp.h: Move EXFUNS for Fframe_root_window,
220 Fframe_first_window and Fset_frame_selected_window to window.h.
221
222 * window.h: Move EXFUNS for Fframe_root_window,
223 Fframe_first_window and Fset_frame_selected_window here from
224 lisp.h.
225
226 * frame.c (Fwindow_frame, Fframe_first_window)
227 (Fframe_root_window, Fframe_selected_window)
228 (Fset_frame_selected_window): Move to window.c.
229 (Factive_minibuffer_window): Move to minibuf.c.
230 (Fother_visible_frames_p): New function.
231
232 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
233
234 * window.c (decode_window, decode_any_window): Move up in code.
235 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
236 (inhibit_frame_unsplittable): Remove unused variable.
237 (Fwindow_buffer): Move up and rewrite doc-string.
238 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
239 (Fwindow_prev): New functions.
240 (Fwindow_frame): Move here from frame.c. Accept any window as
241 argument.
242 (Fframe_root_window, Fframe_first_window)
243 (Fframe_selected_window): Move here from frame.c. Accept frame
244 or arbitrary window as argument. Update doc-strings.
245 (Fminibuffer_window): Move up in code.
246 (Fwindow_minibuffer_p): Move up in code and simplify.
247 (Fset_frame_selected_window): Move here from frame.c.
248 Marginal rewrite.
249 (Fselected_window, select_window, Fselect_window): Move up in
250 code. Minor doc-string fixes.
251
252 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
253
254 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
255 Do not assume that spare memory exists; that assumption is valid
256 only if SYSTEM_MALLOC.
257 (LARGE_REQUEST): New macro, so that the issue of large requests
258 is separated from the issue of spare memory.
259
260 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
261
262 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
263 format. (Bug#8806)
264
265 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
266
267 * xfns.c (x_set_scroll_bar_default_width): Move declarations
268 before statements.
269
270 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
271
272 * gtkutil.c (xg_get_default_scrollbar_width): New function.
273
274 * gtkutil.h: Declare xg_get_default_scrollbar_width.
275
276 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
277 min width by calling x_set_scroll_bar_default_width (Bug#8505).
278
279 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
280
281 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
282
283 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
284
285 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
286 (x_clipboard_manager_save): Add return value.
287 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
288 New error handlers.
289 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
290 Obey Vx_select_enable_clipboard_manager. Catch errors in
291 x_clipboard_manager_save (Bug#8779).
292 (Vx_select_enable_clipboard_manager): New variable.
293 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
294
295 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
296
297 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
298
299 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
300
301 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
302 in the current matrix if keep_current_p is non-zero.
303
304 2011-06-04 Eli Zaretskii <eliz@gnu.org>
305
306 * bidi.c (bidi_level_of_next_char): Fix last change.
307
308 2011-06-03 Eli Zaretskii <eliz@gnu.org>
309
310 Support bidi reordering of text covered by display properties.
311
312 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
313 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
314 (bidi_cache_search, bidi_cache_iterator_state)
315 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
316 (bidi_level_of_next_char, bidi_move_to_visually_next):
317 Support character positions inside a run of characters covered by a
318 display string.
319 (bidi_paragraph_init, bidi_resolve_explicit_1)
320 (bidi_level_of_next_char): Call bidi_fetch_char and
321 bidi_fetch_char_advance instead of FETCH_CHAR and
322 FETCH_CHAR_ADVANCE.
323 (bidi_init_it): Initialize new members.
324 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
325 definitions.
326 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
327 instead of using explicit *_CHAR codes.
328 (bidi_resolve_explicit, bidi_resolve_weak):
329 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
330 bidirectional text is supported only in multibyte buffers.
331 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
332 it to initialize the frame_window_p member of struct bidi_it.
333 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
334 (bidi_resolve_explicit, bidi_resolve_weak)
335 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
336 bidi_it->nchars is non-positive.
337 (bidi_level_of_next_char): Don't try to lookup the cache for the
338 next/previous character if nothing is cached there yet, or if we
339 were just reseat()'ed to a new position.
340
341 * xdisp.c (set_cursor_from_row): Set start and stop points
342 according to the row's direction when priming the loop that looks
343 for the glyph on which to display cursor.
344 (single_display_spec_intangible_p): Function deleted.
345 (display_prop_intangible_p): Reimplement to call
346 handle_display_spec instead of single_display_spec_intangible_p.
347 Accept 3 additional arguments needed by handle_display_spec.
348 This fixes incorrect cursor motion across display property with complex
349 values: lists, `(when COND...)' forms, etc.
350 (single_display_spec_string_p): Support property values that are
351 lists with the argument STRING its top-level element.
352 (display_prop_string_p): Fix the condition for processing a
353 property that is a list to be consistent with handle_display_spec.
354 (handle_display_spec): New function, refactored from the
355 last portion of handle_display_prop.
356 (compute_display_string_pos): Accept additional argument
357 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
358 value of a `display' property is a "replacing spec".
359 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
360 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
361 the display property, but just return a value indicating whether
362 the display property will replace the characters it covers.
363 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
364 frame_window_p members of struct bidi_it.
365 (compute_display_string_pos, compute_display_string_end):
366 New functions.
367 (push_it): Accept second argument POSITION, where pop_it should
368 jump to continue iteration.
369 (reseat_1): Initialize bidi_it.disp_pos.
370
371 * keyboard.c (adjust_point_for_property): Adjust the call to
372 display_prop_intangible_p to its new signature.
373
374 * dispextern.h (struct bidi_it): New member frame_window_p.
375 (bidi_init_it): Update prototypes.
376 (display_prop_intangible_p): Update prototype.
377 (compute_display_string_pos, compute_display_string_end):
378 Declare prototypes.
379 (struct bidi_it): New members nchars and disp_pos. ch_len is now
380 EMACS_INT.
381
382 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
383
384 Malloc failure behavior now depends on size of allocation.
385 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
386 * lisp.h: Change signatures accordingly.
387 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
388 All callers changed. (Bug#8762)
389
390 * gnutls.c: Use Emacs's memory allocators.
391 Without this change, the gnutls library would invoke malloc etc.
392 directly, which causes problems on non-SYNC_INPUT hosts, and which
393 runs afoul of improving memory_full behavior. (Bug#8761)
394 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
395 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
396 xfree instead of the default malloc, realloc, free.
397 (Fgnutls_boot): No need to check for memory allocation failure,
398 since xmalloc does that for us.
399
400 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
401 * category.c (hash_get_category_set):
402 * ccl.c (ccl_driver):
403 * charset.c (Fdefine_charset_internal):
404 * charset.h (struct charset.hash_index):
405 * composite.c (get_composition_id, gstring_lookup_cache)
406 (composition_gstring_put_cache):
407 * composite.h (struct composition.hash_index):
408 * dispextern.h (struct image.hash):
409 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
410 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
411 (hashfn_equal, hashfn_user_defined, make_hash_table)
412 (maybe_resize_hash_table, hash_lookup, hash_put)
413 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
414 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
415 (Fsxhash, Fgethash, Fputhash, Fmaphash):
416 * image.c (make_image, search_image_cache, lookup_image)
417 (xpm_put_color_table_h):
418 * lisp.h (struct Lisp_Hash_Table):
419 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
420 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
421 for hashes and hash indexes, instead of 'unsigned' and 'int'.
422 * alloc.c (allocate_vectorlike):
423 Check for overflow in vector size calculations.
424 * ccl.c (ccl_driver):
425 Check for overflow when converting EMACS_INT to int.
426 * fns.c, image.c: Remove unnecessary static decls that would otherwise
427 need to be updated by these changes.
428 * fns.c (make_hash_table, maybe_resize_hash_table):
429 Check for integer overflow with large hash tables.
430 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
431 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
432 (SXHASH_REDUCE): New macro.
433 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
434 Use it instead of discarding useful hash info with large hash values.
435 (sxhash_float): New function.
436 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
437 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
438 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
439 Rewrite to use FIXNUM_BITS, as this simplifies things.
440 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
441 Adjust signatures to match updated version of code.
442 (consing_since_gc): Now EMACS_INT, since a single hash table can
443 use more than INT_MAX bytes.
444
445 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
446
447 Make it possible to build with GCC-4.6+ -O2 -flto.
448
449 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
450
451 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
452
453 * minibuf.c (get_minibuffer, read_minibuf_unwind):
454 Call minibuffer-inactive-mode.
455
456 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
457
458 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
459 Update dependencies.
460
461 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
462
463 * data.c (init_data): Remove code for UTS, this system is not
464 supported anymore.
465
466 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
467
468 Don't force ./temacs to start in terminal mode.
469
470 * frame.c (make_initial_frame): Initialize faces in all cases, not
471 only when CANNOT_DUMP is defined.
472 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
473
474 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
475
476 * dispnew.c (add_window_display_history): Use const for the string
477 pointer. Remove declaration, not needed.
478
479 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
480
481 Use 'inline', not 'INLINE'.
482 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
483 * alloc.c, fontset.c (INLINE): Remove.
484 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
485 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
486 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
487 * gmalloc.c (register_heapinfo): Use inline unconditionally.
488 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
489
490 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
491
492 Make it possible to run ./temacs.
493
494 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
495 syms_of_callproc does the same thing. Remove test for
496 "initialized", do it in the caller.
497 * emacs.c (main): Avoid calling set_initial_environment when dumping.
498
499 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
500
501 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
502 (read_minibuf): Use get_minibuffer.
503 (syms_of_minibuf): Use DEFSYM.
504 (Qmetadata): New var.
505 * data.c (Qbuffer): Don't make it static.
506 (syms_of_data): Use DEFSYM.
507
508 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
509
510 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
511 (CCL_CODE_MIN): New macro.
512
513 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
514
515 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
516
517 * eval.c (Qdebug): Now static.
518 * lisp.h (Qdebug): Remove decl. This reverts a part of the
519 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
520 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
521
522 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
523
524 * image.c: Various fixes to ImageMagick code comments.
525 (Fimagemagick_types): Doc fix.
526
527 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
528
529 Minor fixes prompted by GCC 4.6.0 warnings.
530
531 * xselect.c (converted_selections, conversion_fail_tag): Now static.
532
533 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
534 (x_clipboard_manager_save_all): Move extern decl to ...
535 * xterm.h: ... here, so that it can be checked for consistency.
536
537 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
538
539 * xselect.c (x_clipboard_manager_save_frame)
540 (x_clipboard_manager_save_all): New functions.
541 (Fx_clipboard_manager_save): Lisp function deleted.
542
543 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
544 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
545
546 * xterm.h: Update prototype.
547
548 2011-05-28 William Xu <william.xwl@gmail.com>
549
550 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
551 exiting (Bug#8239).
552
553 2011-05-28 Jim Meyering <meyering@redhat.com>
554
555 Avoid a sign-extension bug in crypto_hash_function.
556 * fns.c (to_uchar): Define.
557 (crypto_hash_function): Use it to convert some newly-signed
558 variables to unsigned, to avoid sign-extension bugs. For example,
559 without this change, (md5 "truc") would evaluate to
560 45723a2aff78ff4fff7fff1114760e62 rather than the expected
561 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
562 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
563
564 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
565
566 Integer overflow fixes.
567
568 * dbusbind.c: Serial number integer overflow fixes.
569 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
570 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
571 to hold a serial number that is too large for a fixnum.
572 (Fdbus_method_return_internal, Fdbus_method_error_internal):
573 Check for serial numbers out of range. Decode any serial number
574 that was so large that it became a float. (Bug#8722)
575
576 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
577 (Fdbus_call_method, Fdbus_call_method_asynchronously):
578 Use XFASTINT rather than XUINT when numbers are nonnegative.
579 (xd_append_arg, Fdbus_method_return_internal):
580 (Fdbus_method_error_internal): Likewise. Also, for unsigned
581 arguments, check that Lisp number is nonnegative, rather than
582 silently wrapping negative numbers around. (Bug#8722)
583 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
584 (Bug#8722)
585
586 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
587
588 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
589
590 ccl: add integer overflow checks
591 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
592 (IN_INT_RANGE): New macros.
593 (ccl_driver): Use them to check for integer overflow when
594 decoding a CCL program. Many of the new checks are whether XINT (x)
595 fits in int; it doesn't always, on 64-bit hosts. The new version
596 doesn't catch all possible integer overflows, but it's an
597 improvement. (Bug#8719)
598
599 * alloc.c (make_event_array): Use XINT, not XUINT.
600 There's no need for unsigned here.
601
602 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
603 This follows up to the 2011-05-06 change that substituted uintptr_t
604 for EMACS_INT. This case wasn't caught back then.
605
606 Rework Fformat to avoid integer overflow issues.
607 * editfns.c: Include <float.h> unconditionally, as it's everywhere
608 now (part of C89). Include <verify.h>.
609 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
610 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
611 (Fformat): Avoid the prepass trying to compute sizes; it was only
612 approximate and thus did not catch overflow reliably. Instead, walk
613 through the format just once, formatting and computing sizes as we go,
614 checking for integer overflow at every step, and allocating a larger
615 buffer as needed. Keep track separately whether the format is
616 multibyte. Keep only the most-recently calculated precision, rather
617 than them all. Record whether each argument has been converted to
618 string. Use EMACS_INT, not int, for byte and char and arg counts.
619 Support field widths and precisions larger than INT_MAX. Avoid
620 sprintf's undefined behavior with conversion specifications such as %#d
621 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
622 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
623 formatting out-of-range floating point numbers with int
624 formats. (Bug#8668)
625
626 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
627
628 * data.c: Avoid integer truncation in expressions involving floats.
629 * data.c: Include <intprops.h>.
630 (arith_driver): When there's an integer overflow in an expression
631 involving floating point, convert the integers to floating point
632 so that the resulting value does not suffer from catastrophic
633 integer truncation. For example, on a 64-bit host (* 4
634 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
635 Do not rely on undefined behavior after integer overflow.
636
637 merge count_size_as_multibyte, parse_str_to_multibyte
638 * character.c, character.h (count_size_as_multibyte):
639 Rename from parse_str_to_multibyte; all uses changed.
640 Check for integer overflow.
641 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
642 since it's now a duplicate of the other. This is more of
643 a character than a buffer op, so better that it's in character.c.
644 * fns.c, print.c: Adjust to above changes.
645
646 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
647
648 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
649
650 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
651
652 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
653 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
654 (x_clipboard_manager_save): Now static.
655 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
656
657 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
658 (crypto_hash_function): Now static.
659 Fix pointer signedness problems. Avoid unnecessary initializations.
660
661 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
662
663 * termhooks.h (Vselection_alist): Make it terminal-local.
664
665 * terminal.c (create_terminal): Initialize it.
666
667 * xselect.c: Support for clipboard managers.
668 (Vselection_alist): Move to termhooks.h as terminal-local var.
669 (LOCAL_SELECTION): New macro.
670 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
671 (symbol_to_x_atom): Remove gratuitous arg.
672 (x_handle_selection_request, lisp_data_to_selection_data)
673 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
674 (x_own_selection, x_get_local_selection, x_convert_selection):
675 New arg, specifying work frame. Use terminal-local Vselection_alist.
676 (some_frame_on_display): Delete unused function.
677 (Fx_own_selection_internal, Fx_get_selection_internal)
678 (Fx_disown_selection_internal, Fx_selection_owner_p)
679 (Fx_selection_exists_p): New optional frame arg.
680 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
681 (x_handle_selection_clear): Don't treat other terminals with the
682 same keyboard specially. Use the terminal-local Vselection_alist.
683 (x_clear_frame_selections): Use Frun_hook_with_args.
684
685 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
686
687 * xterm.h: Add support for those atoms.
688
689 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
690
691 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
692 (converted_selections, conversion_fail_tag): New global variables.
693 (x_selection_request_lisp_error): Free the above.
694 (x_get_local_selection): Remove unnecessary code.
695 (x_reply_selection_request): Args changed; handle arbitrary array
696 of converted selections stored in converted_selections.
697 Separate the XChangeProperty and SelectionNotify steps.
698 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
699 (x_convert_selection): New function.
700 (x_handle_selection_event): Simplify.
701 (x_get_foreign_selection): Don't ignore incoming requests while
702 waiting for an answer; this will fail when we implement
703 SAVE_TARGETS, and seems unnecessary anyway.
704 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
705 (Vx_sent_selection_functions): Doc fix.
706
707 2011-05-26 Leo Liu <sdl.web@gmail.com>
708
709 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
710
711 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
712
713 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
714
715 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
716 for fringe update if it has periodic bitmap.
717 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
718 and fringe_bitmap_periodic_p.
719
720 * fringe.c (get_fringe_bitmap_data): New function.
721 (draw_fringe_bitmap_1, update_window_fringes): Use it.
722 (update_window_fringes): Record periodicity of fringe bitmap in glyph
723 row. Mark glyph row for fringe update if periodicity changed.
724
725 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
726 for fringe update unless it has periodic bitmap.
727
728 2011-05-25 Kenichi Handa <handa@m17n.org>
729
730 * xdisp.c (get_next_display_element): Set correct it->face_id for
731 a static composition.
732
733 2011-05-24 Leo Liu <sdl.web@gmail.com>
734
735 * deps.mk (fns.o):
736 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
737
738 * fns.c (crypto_hash_function, Fsha1): New function.
739 (Fmd5): Use crypto_hash_function.
740 (syms_of_fns): Add Ssha1.
741
742 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
743
744 * gnutls.c: Remove unused macros.
745 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
746 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
747 Remove macros that are defined and never used.
748 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
749
750 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
751
752 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
753 (Fx_get_selection_internal): Minor cleanup.
754 (Fx_own_selection_internal): Rename arguments for consistency with
755 select.el.
756
757 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
758
759 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
760
761 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
762
763 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
764
765 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
766
767 * dispnew.c (scrolling_window): Don't exclude the case that the
768 last enabled row in the desired matrix touches the bottom boundary.
769
770 2011-05-21 Glenn Morris <rgm@gnu.org>
771
772 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
773 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
774 and add some more files.
775
776 2011-05-20 Eli Zaretskii <eliz@gnu.org>
777
778 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
779 report_file_error introduced by the change from 2011-05-07.
780
781 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
782
783 * systime.h (Time): Define only if emacs is defined.
784 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
785 where the include path doesn't have X11/X.h by default. See
786 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
787
788 2011-05-20 Kenichi Handa <handa@m17n.org>
789
790 * composite.c (find_automatic_composition): Fix previous change.
791
792 2011-05-20 Glenn Morris <rgm@gnu.org>
793
794 * lisp.mk: New file, split from Makefile.in.
795 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
796 (shortlisp): Remove.
797 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
798
799 2011-05-19 Glenn Morris <rgm@gnu.org>
800
801 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
802 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
803 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
804 (lisp): Set the order to that of loadup.el.
805 (shortlisp): Make it a copy of $lisp.
806 (SOME_MACHINE_LISP): Remove.
807 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
808 Use just $shortlisp, not $SOME_MACHINE_LISP too.
809
810 2011-05-18 Kenichi Handa <handa@m17n.org>
811
812 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
813 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
814 (find_automatic_composition): Mostly rewrite for efficiency.
815
816 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
817
818 * makefile.w32-in: Update dependencies.
819
820 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
821
822 * menu.c: Include limits.h (fixes the MS-Windows build broken by
823 revision 104625).
824
825 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
826
827 Fix some integer overflow issues, such as string length overflow.
828
829 * insdel.c (count_size_as_multibyte): Check for string overflow.
830
831 * character.c (lisp_string_width): Check for string overflow.
832 Use EMACS_INT, not int, for string indexes and lengths; in
833 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
834 the resulting string length overflows an EMACS_INT; instead,
835 report a string overflow if no precision given. When checking for
836 precision exhaustion, use a check that cannot possibly have
837 integer overflow. (Bug#8675)
838 * character.h (lisp_string_width): Adjust to new signature.
839
840 * alloc.c (string_overflow): New function.
841 (Fmake_string): Use it. This doesn't change behavior, but saves
842 a few bytes and will simplify future changes.
843 * character.c (string_escape_byte8): Likewise.
844 * lisp.h (string_overflow): New decl.
845
846 Fixups, following up to the user-interface timestamp change.
847 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
848 for UI timestamps, instead of unsigned long.
849 * msdos.c (mouse_get_pos): Likewise.
850 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
851 * w32gui.h (Time): Define by including "systime.h" rather than by
852 declaring it ourselves. (Bug#8664)
853
854 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
855 * image.c (clear_image_cache): Likewise.
856
857 * term.c (term_mouse_position): Don't assume time_t wraparound.
858
859 Be more systematic about user-interface timestamps.
860 Before, the code sometimes used 'Time', sometimes 'unsigned long',
861 and sometimes 'EMACS_UINT', to represent these timestamps.
862 This change causes it to use 'Time' uniformly, as that's what X uses.
863 This makes the code easier to follow, and makes it easier to catch
864 integer overflow bugs such as Bug#8664.
865 * frame.c (Fmouse_position, Fmouse_pixel_position):
866 Use Time, not unsigned long, for user-interface timestamps.
867 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
868 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
869 * keyboard.h (last_event_timestamp): Likewise.
870 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
871 * menu.h (xmenu_show): Likewise.
872 * term.c (term_mouse_position): Likewise.
873 * termhooks.h (struct input_event.timestamp): Likewise.
874 (struct terminal.mouse_position_hook): Likewise.
875 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
876 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
877 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
878 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
879 what it was before.
880 * menu.h, termhooks.h: Include "systime.h", for Time.
881
882 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
883 Don't assume that the difference between two unsigned long values
884 can fit into an integer. At this point, we know button_down_time
885 <= event->timestamp, so the difference must be nonnegative, so
886 there's no need to cast the result if double-click-time is
887 nonnegative, as it should be; check that it's nonnegative, just in
888 case. This bug is triggered when events are more than 2**31 ms
889 apart (about 25 days). (Bug#8664)
890
891 * xselect.c (last_event_timestamp): Remove duplicate decl.
892 (x_own_selection): Remove needless cast to unsigned long.
893
894 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
895 that always fit in int. Use a sentinel instead of a counter, to
896 avoid a temp and to allay GCC's concerns about possible int overflow.
897 * frame.h (struct frame): Use int for menu_bar_items_used
898 instead of EMACS_INT, since it always fits in int.
899
900 * menu.c (grow_menu_items): Check for int overflow.
901
902 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
903
904 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
905 Before, the code was not consistent. These values cannot exceed
906 2**31 - 1 so there's no need to make them unsigned.
907 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
908 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
909 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
910 as modifiers.
911 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
912
913 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
914 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
915 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
916 presumably because the widths might not match.
917
918 * window.c (size_window): Avoid needless test at loop start.
919
920 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
921
922 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
923
924 2011-05-12 Drew Adams <drew.adams@oracle.com>
925
926 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
927
928 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
929
930 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
931 `width' to `bar_area_x' and `bar_area_width', respectively.
932 (x_scroll_run): Take account of fringe background extension.
933
934 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
935 Rename local vars `left' and `width' to `bar_area_x' and
936 `bar_area_width', respectively.
937 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
938 background extension.
939
940 2011-05-10 Jim Meyering <meyering@redhat.com>
941
942 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
943
944 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
945
946 * image.c (Finit_image_library): Return t for built-in image types,
947 like pbm and xbm. (Bug#8640)
948
949 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
950
951 * w32menu.c (set_frame_menubar): Fix submenu allocation.
952
953 2011-05-07 Eli Zaretskii <eliz@gnu.org>
954
955 * w32console.c (Fset_screen_color): Doc fix.
956 (Fget_screen_color): New function.
957 (syms_of_ntterm): Defsubr it.
958
959 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
960 unlink the temporary file if Fcall_process didn't create it in the
961 first place.
962 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
963 child process will be redirected to a file specified with `:file'.
964 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
965 cue to call_process_cleanup not to close that handle.
966
967 2011-05-07 Ben Key <bkey76@gmail.com>
968
969 * makefile.w32-in: The bootstrap-temacs rule now makes use of
970 one of two shell specific rules, either bootstrap-temacs-CMD or
971 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
972 to the previous implementation of the bootstrap-temacs rule.
973 The bootstrap-temacs-CMD rule is similar to the previous
974 implementation of the bootstrap-temacs rule except that it
975 makes use of the ESC_CFLAGS variable instead of the CFLAGS
976 variable.
977
978 These changes, along with some changes to nt/configure.bat,
979 nt/gmake.defs, and nt/nmake.defs, are required to extend my
980 earlier fix to add support for --cflags and --ldflags options
981 that include quotes so that it works whether make uses cmd or
982 sh as the shell.
983
984 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
985
986 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
987 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
988 is a constant.
989 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
990 a string. Handle both cases.
991 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
992 (Fdbus_register_method): Use Qinvalid_function.
993
994 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
995
996 * makefile.w32-in: Update dependencies.
997 (LISP_H): Add inttypes.h and stdin.h.
998 (PROCESS_H): Add unistd.h.
999
1000 2011-05-06 Eli Zaretskii <eliz@gnu.org>
1001
1002 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1003 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1004
1005 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
1006
1007 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1008
1009 * term.c (vfatal): Remove stray call to va_end.
1010 It's not needed and the C Standard doesn't allow it here anyway.
1011
1012 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1013 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1014
1015 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1016 bytes.
1017
1018 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1019
1020 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1021
1022 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1023
1024 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1025
1026 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1027
1028 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1029 * charset.c (Fdefine_charset_internal): Don't initialize
1030 charset.code_space[15]. The value was garbage, on hosts with
1031 32-bit int (Bug#8600).
1032
1033 * lread.c (read_integer): Be more consistent with string-to-number.
1034 Use string_to_number to do the actual conversion; this avoids
1035 rounding errors and fixes some other screwups. Without this fix,
1036 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1037 (digit_to_number): Move earlier, for benefit of read_integer.
1038 Return -1 if the digit is out of range for the base, -2 if it is
1039 not a digit in any supported base. (Bug#8602)
1040
1041 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1042
1043 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1044 to match comment at start of function. This also removes a
1045 GCC warning about overflow in a 32+64-bit port.
1046
1047 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1048
1049 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1050 Reported by Stefan Monnier in
1051 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
1052 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1053 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
1054
1055 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1056 (EMACS_UINTPTR): Likewise, with uintptr_t.
1057
1058 * lisp.h: Prefer 64-bit EMACS_INT if available.
1059 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1060 on 32-bit hosts that have 64-bit int, so that they can access
1061 large files.
1062 However, temporarily disable this change unless the temporary
1063 symbol WIDE_EMACS_INT is defined.
1064
1065 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1066
1067 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1068 This removes an assumption that EMACS_INT and long are the same
1069 width as pointers. The assumption is true for Emacs porting targets
1070 now, but we want to make other targets possible.
1071 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1072 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1073 In the rest of the code, change types of integers that hold casted
1074 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1075 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1076 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1077 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1078 No need to cast type when ORing.
1079 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1080 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1081 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1082 assume EMACS_INT is the same width as char *.
1083 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1084 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1085 Remove no-longer-needed casts.
1086 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1087 (xg_tool_bar_help_callback, xg_make_tool_item):
1088 Use EMACS_INTPTR to hold an integer
1089 that will be cast to void *; this can avoid a GCC warning
1090 if EMACS_INT is not the same width as void *.
1091 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1092 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1093 (current_message_1, set_message_1):
1094 Use a local to convert to proper width without a cast.
1095 * xmenu.c (dialog_selection_callback): Likewise.
1096
1097 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1098 Also, don't assume VALBITS / RAND_BITS is less than 5,
1099 and don't rely on undefined behavior when shifting a 1 left into
1100 the sign bit.
1101 * lisp.h (get_random): Change signature to match.
1102
1103 * lread.c (hash_string): Use size_t, not int, for hash computation.
1104 Normally we prefer signed values; but hashing is special, because
1105 it's better to use unsigned division on hash table sizes so that
1106 the remainder is nonnegative. Also, size_t is the natural width
1107 for hashing into memory. The previous code used 'int', which doesn't
1108 retain enough info to hash well into very large tables.
1109 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1110
1111 * dbusbind.c: Don't possibly lose pointer info when converting.
1112 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1113 Use XPNTR rather than XHASH, so that the high-order bits of
1114 the pointer aren't lost when converting through void *.
1115
1116 * eval.c (Fautoload): Don't double-shift a pointer.
1117
1118 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1119
1120 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1121
1122 * gnutls.c (DEF_GNUTLS_FN):
1123 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1124
1125 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1126
1127 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1128 marker. (Bug#8610)
1129
1130 2011-05-05 Eli Zaretskii <eliz@gnu.org>
1131
1132 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1133 New version that can reserve upto 2GB of heap space.
1134
1135 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
1136
1137 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1138
1139 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1140
1141 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1142 `gnutls_certificate_set_x509_key_file'.
1143
1144 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
1145
1146 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1147 Update dependencies.
1148
1149 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1150
1151 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1152 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1153 Remove unused parameter `fildes'.
1154 * process.c (read_process_output, send_process): Don't pass it.
1155
1156 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1157
1158 Fix previous change: the library cache is defined in w32.c.
1159 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1160 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1161
1162 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1163
1164 Implement dynamic loading of GnuTLS on Windows.
1165
1166 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1167 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1168 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1169 Declare.
1170
1171 * gnutls.c (Qgnutls_dll): Define.
1172 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1173 (gnutls_*): Declare function pointers.
1174 (init_gnutls_functions): New function to initialize function pointers.
1175 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1176 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1177 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1178 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1179 (emacs_gnutls_write, emacs_gnutls_read)
1180 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1181 (Fgnutls_available_p): New function.
1182 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1183 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1184 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1185
1186 * image.c: Include w32.h.
1187 (Vimage_type_cache): Delete.
1188 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1189 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1190 (w32_delayed_load): Move to w32.c.
1191
1192 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1193
1194 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1195 (w32_delayed_load): Move from image.c. When loading a library, record
1196 its filename in the :loaded-from property of the library id.
1197 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1198 Initialize and staticpro them.
1199 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1200
1201 * process.c: Include lisp.h before w32.h, not after.
1202 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1203 instead of gnutls_record_check_pending.
1204
1205 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1206
1207 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1208
1209 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1210 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1211 as passed in.
1212
1213 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1214
1215 * xterm.c (x_set_frame_alpha): Do not set property on anything
1216 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1217
1218 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1219
1220 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1221
1222 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1223
1224 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1225 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1226 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1227 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1228 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1229 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1230 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1231 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1232 (Qgnutls_bootprop_callbacks_verify): Make static.
1233
1234 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1235
1236 * callproc.c: Indentation fixup.
1237
1238 * sysdep.c (wait_for_termination_1): Make static.
1239 (wait_for_termination, interruptible_wait_for_termination):
1240 Move after wait_for_termination_1.
1241
1242 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1243
1244 * sysdep.c (interruptible_wait_for_termination): New function
1245 which is like wait_for_termination, but allows keyboard
1246 interruptions.
1247
1248 * callproc.c (Fcall_process): Add (:file "file") as an option for
1249 the STDOUT buffer.
1250 (Fcall_process_region): Ditto.
1251
1252 2011-04-30 Eli Zaretskii <eliz@gnu.org>
1253
1254 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1255 rather than `XVECTOR (FOO)->size'.
1256
1257 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1258 inttypes.h, as a gnulib replacement is used if it not available in
1259 system headers.
1260
1261 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1262
1263 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1264 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1265 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1266
1267 * coding.c (coding_alloc_by_realloc): Error out if destination
1268 will grow beyond MOST_POSITIVE_FIXNUM.
1269 (decode_coding_emacs_mule): Abort if there isn't enough place in
1270 charbuf for the composition carryover bytes. Reserve an extra
1271 space for up to 2 characters produced in a loop.
1272 (decode_coding_iso_2022): Abort if there isn't enough place in
1273 charbuf for the composition carryover bytes.
1274
1275 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1276
1277 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1278 aborting when %lld or %lll format is passed.
1279 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1280 %llo or %llx format is passed. (Bug#8545)
1281
1282 * window.c (window_scroll_line_based): Use a marker instead of
1283 simple variables to record original value of point. (Bug#7952)
1284
1285 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1286 produced by %s or %c overflows available buffer space. (Bug#8545)
1287
1288 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1289
1290 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
1291 (SIZE_MAX): Move defn after all includes, as they might #define it.
1292
1293 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1294
1295 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1296
1297 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1298
1299 * keyboard.c (Qdelayed_warnings_hook): Define.
1300 (command_loop_1): Run `delayed-warnings-hook'
1301 if Vdelayed_warnings_list is non-nil.
1302 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1303 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1304
1305 2011-04-28 Eli Zaretskii <eliz@gnu.org>
1306
1307 * doprnt.c (doprnt): Don't return value smaller than the buffer
1308 size if the message was truncated. (Bug#8545).
1309
1310 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1311
1312 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1313 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1314
1315 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1316
1317 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1318
1319 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
1320
1321 * makefile.w32-in: Update dependencies.
1322
1323 2011-04-27 Eli Zaretskii <eliz@gnu.org>
1324
1325 Improve `doprnt' and its usage. (Bug#8545)
1326 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1327 `format_end'. Remove support for %l as a conversion specifier.
1328 Don't use xrealloc. Improve diagnostics when the %l size modifier
1329 is used. Update the commentary.
1330
1331 * eval.c (verror): Simplify calculation of size_t.
1332
1333 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1334 messages.
1335
1336 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1337
1338 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1339 change.
1340
1341 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1342
1343 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1344 This makes this file independent of the recent pseudovector change.
1345
1346 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
1347
1348 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1349
1350 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
1351 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
1352 Remove unused local.
1353 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
1354
1355 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
1356 GCC 4.6.0 optimizes based on type-based alias analysis.
1357 For example, if b is of type struct buffer * and v of type struct
1358 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1359 != &v->size, and therefore "v->size = 1; b->size = 2; return
1360 v->size;" must therefore return 1. This assumption is incorrect
1361 for Emacs, since it type-puns struct Lisp_Vector * with many other
1362 types. To fix this problem, this patch adds a new type struct
1363 vectorlike_header that documents the constraints on layout of vectors
1364 and pseudovectors, and helps optimizing compilers not get fooled
1365 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1366 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
1367 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1368 the size member.
1369 (XSETPVECTYPE): Rewrite in terms of new macro.
1370 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1371 This is a bit clearer, and further avoids the possibility of
1372 undesirable aliasing.
1373 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
1374 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
1375 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1376 since Lisp_Subr is a special case (no "next" field).
1377 (ASIZE): Now uses header.size rather than size.
1378 All previous uses of XVECTOR (foo)->size replaced to use this macro,
1379 to avoid the hassle of writing XVECTOR (foo)->header.size.
1380 (struct vectorlike_header): New type.
1381 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1382 object, to help avoid aliasing.
1383 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1384 (SUBRP): Likewise, since Lisp_Subr is a special case.
1385 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1386 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1387 (struct Lisp_Hash_Table): Combine first two members into a single
1388 struct vectorlike_header member. All uses of "size" and "next" members
1389 changed to be "header.size" and "header.next".
1390 * buffer.h (struct buffer): Likewise.
1391 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1392 * frame.h (struct frame): Likewise.
1393 * process.h (struct Lisp_Process): Likewise.
1394 * termhooks.h (struct terminal): Likewise.
1395 * window.c (struct save_window_data, struct saved_window): Likewise.
1396 * window.h (struct window): Likewise.
1397 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1398 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1399 * buffer.c (init_buffer_once): Likewise.
1400 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1401 special case.
1402 * process.c (Fformat_network_address): Use local var for size,
1403 for brevity.
1404
1405 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1406
1407 Make the Lisp reader and string-to-float more consistent (Bug#8525)
1408 * data.c (atof): Remove decl; no longer used or needed.
1409 (digit_to_number): Move to lread.c.
1410 (Fstring_to_number): Use new string_to_number function, to be
1411 consistent with how the Lisp reader treats infinities and NaNs.
1412 Do not assume that floating-point numbers represent EMACS_INT
1413 without losing information; this is not true on most 64-bit hosts.
1414 Avoid double-rounding errors, by insisting on integers when
1415 parsing non-base-10 numbers, as the documentation specifies.
1416 * lisp.h (string_to_number): New decl, replacing ...
1417 (isfloat_string): Remove.
1418 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
1419 (read1): Do not accept +. and -. as integers; this
1420 appears to have been a coding error. Similarly, do not accept
1421 strings like +-1e0 as floating point numbers. Do not report
1422 overflow for integer overflows unless the base is not 10 which
1423 means we have no simple and reliable way to continue.
1424 Break out the floating-point parsing into a new
1425 function string_to_number, so that Fstring_to_number parses
1426 floating point numbers consistently with the Lisp reader.
1427 (digit_to_number): Move here from data.c. Make it static inline.
1428 (E_CHAR, EXP_INT): Remove, replacing with ...
1429 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1430 (string_to_number): New function, replacing isfloat_string.
1431 This function checks for valid syntax and produces the resulting
1432 Lisp float number too. Rework it so that string-to-number
1433 no longer mishandles examples like "1.0e+". Use strtoumax,
1434 so that overflow for non-base-10 numbers is reported only when
1435 there's no portable and simple way to convert to floating point.
1436
1437 * textprop.c (set_text_properties_1): Rewrite for clarity,
1438 and to avoid GCC warning about integer overflow.
1439
1440 * intervals.h (struct interval): Use EMACS_INT for members
1441 where EMACS_UINT might cause problems. See
1442 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
1443 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
1444 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
1445 All uses changed.
1446 (offset_intervals): Tell GCC not to worry about length overflow
1447 when negating a negative length.
1448
1449 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
1450 (overrun_check_free): Likewise.
1451
1452 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
1453 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
1454 word size.
1455
1456 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1457 (gnutls_make_error): Rename local to avoid shadowing.
1458 (gnutls_emacs_global_deinit): ifdef out; not used.
1459 (Fgnutls_boot): Use const for pointer to readonly storage.
1460 Comment out unused local. Fix pointer signedness problems.
1461
1462 * lread.c (openp): Don't stuff size_t into an 'int'.
1463 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
1464 about possible signed overflow.
1465
1466 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1467 (GDK_KEY_g): Don't define if already defined.
1468 (xg_prepare_tooltip): Avoid pointer signedness problem.
1469 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
1470
1471 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
1472 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
1473
1474 * xfns.c (Fx_window_property): Simplify a bit,
1475 to make a bit faster and to avoid GCC 4.6.0 warning.
1476 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
1477
1478 * fns.c (internal_equal): Don't assume size_t fits in int.
1479
1480 * alloc.c (compact_small_strings): Tighten assertion a little.
1481
1482 Replace pEd with more-general pI, and fix some printf arg casts.
1483 * lisp.h (pI): New macro, generalizing old pEd macro to other
1484 conversion specifiers. For example, use "...%"pI"d..." rather
1485 than "...%"pEd"...".
1486 (pEd): Remove. All uses replaced with similar uses of pI.
1487 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
1488 * alloc.c (check_pure_size): Don't overflow by converting size to int.
1489 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
1490 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
1491 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
1492 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
1493 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
1494 64-bit hosts.
1495 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
1496 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
1497 * print.c (safe_debug_print, print_object): Likewise.
1498 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
1499 to int.
1500 Use pI instead of if-then-else-abort. Use %p to avoid casts,
1501 avoiding the 0 flag, which is not portable.
1502 * process.c (Fmake_network_process): Use pI to avoid cast.
1503 * region-cache.c (pp_cache): Likewise.
1504 * xdisp.c (decode_mode_spec): Likewise.
1505 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
1506 behavior on 64-bit hosts with printf arg.
1507 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
1508 (x_stop_queuing_selection_requests): Likewise.
1509 (x_get_window_property): Don't truncate byte count to an 'int'
1510 when tracing.
1511
1512 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
1513 here, since it parses constructs like leading '-' and spaces,
1514 which are not wanted; and it overflows with large numbers.
1515 Instead, simply match F[0-9]+, which is what is wanted anyway.
1516
1517 * alloc.c: Remove unportable assumptions about struct layout.
1518 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
1519 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
1520 (allocate_vectorlike, make_pure_vector): Use the new macros,
1521 plus offsetof, to remove unportable assumptions about struct layout.
1522 These assumptions hold on all porting targets that I know of, but
1523 they are not guaranteed, they're easy to remove, and removing them
1524 makes further changes easier.
1525
1526 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
1527 This doesn't fix a bug but makes the code clearer.
1528 (string_overrun_cookie): Now const. Use initializers that
1529 don't formally overflow signed char, to avoid warnings.
1530 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
1531 can cause Emacs to crash when string overrun checking is enabled.
1532 (allocate_buffer): Don't assume sizeof (struct buffer) is a
1533 multiple of sizeof (EMACS_INT); it need not be, if
1534 alignof(EMACS_INT) < sizeof (EMACS_INT).
1535 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
1536
1537 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
1538
1539 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1540
1541 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1542
1543 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
1544 supposed to be handshaking. (Bug#8556)
1545 Reported by Paul Eggert <eggert@cs.ucla.edu>.
1546
1547 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
1548
1549 * lisp.h (Qdebug): List symbol.
1550 * eval.c (Qdebug): Restore global linkage.
1551 * keyboard.c (debug-on-event): New variable.
1552 (handle_user_signal): Break into debugger when debug-on-event
1553 matches the current signal symbol.
1554
1555 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
1556
1557 * alloc.c (check_sblock, check_string_bytes)
1558 (check_string_free_list): Convert to standard C.
1559
1560 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
1561
1562 * w32.c (emacs_gnutls_push): Fix typo.
1563
1564 2011-04-25 Eli Zaretskii <eliz@gnu.org>
1565
1566 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
1567 "cast to pointer from integer of different size".
1568
1569 Improve doprnt and its use in verror. (Bug#8545)
1570 * doprnt.c (doprnt): Document the set of format control sequences
1571 supported by the function. Use SAFE_ALLOCA instead of always
1572 using `alloca'.
1573
1574 * eval.c (verror): Don't limit the buffer size at size_max-1, that
1575 is one byte too soon. Don't use xrealloc; instead xfree and
1576 xmalloc anew.
1577
1578 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
1579
1580 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
1581 callbacks stage.
1582
1583 * gnutls.c: Renamed global_initialized to
1584 gnutls_global_initialized. Added internals for the
1585 :verify-hostname-error, :verify-error, and :verify-flags
1586 parameters of `gnutls-boot' and documented those parameters in the
1587 docstring. Start callback support.
1588 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
1589 unless a fatal error occured. Call gnutls_alert_send_appropriate
1590 on error. Return error code.
1591 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
1592 (emacs_gnutls_read): Likewise.
1593 (Fgnutls_boot): Return handshake error code.
1594 (emacs_gnutls_handle_error): New function.
1595 (wsaerror_to_errno): Likewise.
1596
1597 * w32.h (emacs_gnutls_pull): Add prototype.
1598 (emacs_gnutls_push): Likewise.
1599
1600 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
1601 (emacs_gnutls_push): Likewise.
1602
1603 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
1604
1605 * process.c (wait_reading_process_output): Check if GnuTLS
1606 buffered some data internally if no FDs are set for TLS
1607 connections.
1608
1609 * makefile.w32-in (OBJ2): Add gnutls.$(O).
1610 (LIBS): Link to USER_LIBS.
1611 ($(BLD)/gnutls.$(0)): New target.
1612
1613 2011-04-24 Eli Zaretskii <eliz@gnu.org>
1614
1615 * xdisp.c (handle_single_display_spec): Rename the
1616 display_replaced_before_p argument into display_replaced_p, to
1617 make it consistent with the commentary. Fix typos in the
1618 commentary.
1619
1620 * textprop.c (syms_of_textprop): Remove dead code.
1621 (copy_text_properties): Delete obsolete commentary about an
1622 interface that was deleted long ago. Fix typos in the description
1623 of arguments.
1624
1625 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
1626 to changes in oldXMenu/XMenu.h from 2011-04-16.
1627 <menu_help_message, prev_menu_help_message>: Constify.
1628 (IT_menu_make_room): menu->help_text is now `const char **';
1629 adjust.
1630
1631 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
1632 to changes in oldXMenu/XMenu.h from 2011-04-16.
1633 (struct XMenu): Declare `help_text' `const char **'.
1634
1635 * xfaces.c <Qunspecified>: Make extern again.
1636
1637 * syntax.c: Include sys/types.h before including regex.h, as
1638 required by Posix.
1639
1640 * doc.c (get_doc_string): Improve the format passed to `error'.
1641
1642 * doprnt.c (doprnt): Improve commentary.
1643
1644 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
1645
1646 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
1647 them with etags.
1648
1649 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
1650 changes in globals.h immediately force recompilation.
1651 (TAGS): Depend on $(CURDIR)/m/intel386.h and
1652 $(CURDIR)/s/ms-w32.h.
1653 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
1654
1655 * character.c (Fchar_direction): Function deleted.
1656 (syms_of_character): Don't defsubr it.
1657 <char-direction-table>: Deleted.
1658
1659 2011-04-23 Eli Zaretskii <eliz@gnu.org>
1660
1661 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
1662 * doprnt.c: Include limits.h.
1663 (SIZE_MAX): New macro.
1664 (doprnt): Return a size_t value. 2nd arg is now size_t.
1665 Many local variables are now size_t instead of int or unsigned.
1666 Improve overflow protection. Support `l' modifier for integer
1667 conversions. Support %l conversion. Don't assume an EMACS_INT
1668 argument for integer conversions and for %c.
1669
1670 * lisp.h (doprnt): Restore prototype.
1671
1672 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
1673 $(SRC)/character.h.
1674
1675 * Makefile.in (base_obj): Add back doprnt.o.
1676
1677 * deps.mk (doprnt.o): Add back prerequisites.
1678 (callint.o): Depend on character.h.
1679
1680 * eval.c (internal_lisp_condition_case): Include the handler
1681 representation in the error message.
1682 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1683 when breaking from the loop.
1684
1685 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1686
1687 * callint.c (Fcall_interactively): When displaying error message
1688 about invalid control letter, pass the character's codepoint, not
1689 a pointer to its multibyte form. Improve display of the character
1690 in octal and display also its hex code.
1691
1692 * character.c (char_string): Use %x to display the (unsigned)
1693 codepoint of an invalid character, to avoid displaying a bogus
1694 negative value.
1695
1696 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1697 `error', not SYMBOL_NAME itself.
1698
1699 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1700 character arguments to `error'.
1701
1702 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1703 to `error' in error message about FINAL_CHAR argument. Make sure
1704 FINAL_CHAR is a character, and use %c when it is passed as
1705 argument to `error'.
1706
1707 2011-04-23 Eli Zaretskii <eliz@gnu.org>
1708
1709 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1710
1711 * w32.c: Include <time.h>.
1712 (sys_localtime): New function.
1713
1714 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
1715
1716 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1717
1718 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
1719
1720 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
1721
1722 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1723 zombies (Bug#8467).
1724
1725 2011-04-19 Eli Zaretskii <eliz@gnu.org>
1726
1727 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1728 gl_state.e_property when gl_state.object is Qt.
1729
1730 * insdel.c (make_gap_larger): Remove limitation of buffer size
1731 to <= INT_MAX.
1732
1733 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
1734
1735 * xdisp.c (lookup_glyphless_char_display)
1736 (produce_glyphless_glyph): Handle cons cell entry in
1737 glyphless-char-display.
1738 (Vglyphless_char_display): Document it.
1739
1740 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1741 glyphless-char-display.
1742
1743 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
1744
1745 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
1746
1747 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1748
1749 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
1750 definition for no-X builds.
1751
1752 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
1753
1754 Static checks with GCC 4.6.0 and non-default toolkits.
1755
1756 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1757
1758 * process.c (keyboard_bit_set): Define only if SIGIO.
1759 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
1760 (send_process): Repair possible setjmp clobbering.
1761
1762 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
1763
1764 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1765
1766 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
1767
1768 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
1769 Define only if needed.
1770
1771 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
1772 by pacifying GCC about it. Maybe it's time to retire it?
1773 * xfaces.c (USG, __TIMEVAL__): Likewise.
1774
1775 * dispextern.h (struct redisplay_interface): Rename param
1776 to avoid shadowing.
1777 * termhooks.h (struct terminal): Likewise.
1778 * xterm.c (xembed_send_message): Likewise.
1779
1780 * insdel.c (make_gap_smaller): Define only if
1781 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
1782
1783 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
1784 it.
1785
1786 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
1787 so that we aren't warned about unused symbols.
1788
1789 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
1790
1791 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
1792
1793 * xfns.c (x_real_positions): Mark locals as initialized.
1794
1795 * xmenu.c (xmenu_show): Don't use uninitialized vars.
1796
1797 * xterm.c: Fix problems found by static analysis with other toolkits.
1798 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
1799 (x_dispatch_event): Declare static if USE_GTK, and
1800 define if USE_GTK || USE_X_TOOLKIT.
1801 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
1802 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
1803 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
1804 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
1805
1806 * xmenu.c (menu_help_callback): Pointer type fixes.
1807 Use const pointers when pointing at readonly data. Avoid pointer
1808 signedness clashes.
1809 (FALSE): Remove unused macro.
1810 (update_frame_menubar): Remove unused decl.
1811
1812 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
1813
1814 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
1815 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
1816 (single_menu_item): Rename local to avoid shadowing.
1817
1818 * keyboard.c (make_lispy_event): Remove unused local var.
1819
1820 * frame.c, frame.h (x_get_resource_string): Bring this back, but
1821 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
1822
1823 * bitmaps: Change bitmaps from unsigned char back to the X11
1824 compatible char. Avoid the old compiler warnings about
1825 out-of-range initializers by using, for example, '\xab' rather
1826 than 0xab.
1827
1828 * xgselect.c (xgselect_initialize): Check vs interface
1829 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
1830
1831 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
1832
1833 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
1834 to read-only memory.
1835
1836 * fns.c (vector): Remove; this old hack is no longer needed.
1837
1838 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
1839 Remove unused var.
1840 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
1841
1842 * xrdb.c (x_load_resources): Omit unused local.
1843
1844 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
1845 (x_window): Rename locals to avoid shadowing.
1846 (USG): Use the kludged USG macro, to pacify gcc.
1847
1848 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
1849 (x_term_init): Remove local to avoid shadowing.
1850
1851 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
1852
1853 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
1854 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
1855
1856 2011-04-16 Eli Zaretskii <eliz@gnu.org>
1857
1858 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
1859
1860 Fix regex.c, syntax.c and friends for buffers > 2GB.
1861 * syntax.h (struct gl_state_s): Declare character position members
1862 EMACS_INT.
1863
1864 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
1865
1866 * textprop.c (verify_interval_modification, interval_of):
1867 Declare arguments EMACS_INT.
1868
1869 * intervals.c (adjust_intervals_for_insertion): Declare arguments
1870 EMACS_INT.
1871
1872 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
1873
1874 * indent.c (Fvertical_motion): Local variable it_start is now
1875 EMACS_INT.
1876
1877 * regex.c (re_match, re_match_2, re_match_2_internal)
1878 (bcmp_translate, regcomp, regexec, print_double_string)
1879 (group_in_compile_stack, re_search, re_search_2, regex_compile)
1880 (re_compile_pattern, re_exec): Declare arguments and local
1881 variables `size_t' and `ssize_t' and return values `regoff_t', as
1882 appropriate.
1883 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
1884 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
1885 <compile_stack_type>: `size' and `avail' are now `size_t'.
1886
1887 * regex.h <regoff_t>: Use ssize_t, not int.
1888 (re_search, re_search_2, re_match, re_match_2): Arguments that
1889 specify buffer/string position and length are now ssize_t and
1890 size_t. Return type is regoff_t.
1891
1892 2011-04-16 Ben Key <bkey76@gmail.com>
1893
1894 * nsfont.m: Fixed bugs in ns_get_family and
1895 ns_descriptor_to_entity that were caused by using free to
1896 deallocate memory blocks that were allocated by xmalloc (via
1897 xstrdup). This caused Emacs to crash when compiled with
1898 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
1899 --enable-checking=xmallocoverrun). xfree is now used to
1900 deallocate these memory blocks.
1901
1902 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
1903
1904 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1905
1906 emacs_write: Accept and return EMACS_INT for sizes.
1907 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1908 et seq.
1909 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1910 Accept and return EMACS_INT.
1911 (emacs_gnutls_write): Return the number of bytes written on
1912 partial writes.
1913 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
1914 (emacs_read, emacs_write): Remove check for negative size, as the
1915 Emacs source code has been audited now.
1916 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1917 (emacs_read, emacs_write): Use it.
1918 * process.c (send_process): Adjust to the new signatures of
1919 emacs_write and emacs_gnutls_write. Do not attempt to store
1920 a byte offset into an 'int'; it might overflow.
1921 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
1922
1923 * sound.c: Don't assume sizes fit in 'int'.
1924 (struct sound_device.period_size, alsa_period_size):
1925 Return EMACS_INT, not int.
1926 (struct sound_device.write, vox_write, alsa_write):
1927 Accept EMACS_INT, not int.
1928 (wav_play, au_play): Use EMACS_INT to store sizes and to
1929 record read return values.
1930
1931 2011-04-15 Ben Key <bkey76@gmail.com>
1932
1933 * keyboard.c (Qundefined): Don't declare static since it is used
1934 in nsfns.m.
1935 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1936 static since they are used in nsfont.m.
1937
1938 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1939
1940 * process.c (Qprocessp): Don't declare static.
1941 * lisp.h (Qprocessp): Declare again.
1942
1943 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
1944
1945 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1946
1947 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1948
1949 Improve C-level modularity by making more things 'static'.
1950
1951 Don't publish debugger-only interfaces to other modules.
1952 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1953 (verify_bytepos, count_markers): Move decls to the only modules
1954 that need them.
1955 * region-cache.h (pp_cache): Likewise.
1956 * window.h (check_all_windows): Likewise.
1957 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1958
1959 * sysdep.c (croak): Now static, if
1960 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1961 * syssignal.h (croak): Declare only if not static.
1962
1963 * alloc.c (refill_memory_reserve): Now static if
1964 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1965 * lisp.h (refill_memory_reserve): Declare only if not static.
1966
1967 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1968 Define only if USE_LUCID.
1969
1970 * xrdb.c (x_customization_string, x_rm_string): Now static.
1971
1972 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1973 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1974
1975 * xdisp.c (draw_row_with_mouse_face): Now static.
1976 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1977
1978 * window.h (check_all_windows): Mark externally visible.
1979
1980 * window.c (window_deletion_count): Now static.
1981
1982 * undo.c: Make symbols static if they're not exported.
1983 (last_undo_buffer, last_boundary_position, pending_boundary):
1984 Now static.
1985
1986 * textprop.c (interval_insert_behind_hooks): Now static.
1987 (interval_insert_in_front_hooks): Likewise.
1988
1989 * term.c: Make symbols static if they're not exported.
1990 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
1991 (max_frame_lines, tty_set_terminal_modes):
1992 (tty_reset_terminal_modes, tty_turn_off_highlight):
1993 (get_tty_terminal): Now static.
1994 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
1995 * termhooks.h (term_mouse_moveto): Do not declare if
1996 HAVE_WINDOW_SYSTEM.
1997 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
1998 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
1999
2000 * sysdep.c: Make symbols static if they're not exported.
2001 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2002 Now static.
2003 (sigprocmask_set, full_mask): Remove; unused.
2004 (wait_debugging): Mark as visible.
2005 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2006 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2007
2008 * syntax.c (syntax_temp): Define only if !__GNUC__.
2009
2010 * sound.c (current_sound_device, current_sound): Now static.
2011
2012 * search.c (searchbufs, searchbuf_head): Now static.
2013
2014 * scroll.c (scroll_cost): Remove; unused.
2015 * dispextern.h (scroll_cost): Remove decl.
2016
2017 * region-cache.h (pp_cache): Mark as externally visible.
2018
2019 * process.c: Make symbols static if they're not exported.
2020 (process_tick, update_tick, create_process, chan_process):
2021 (Vprocess_alist, proc_buffered_char, datagram_access):
2022 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2023 (deactivate_process): Mark defn as static, as well as decl.
2024 * lisp.h (create_process): Remove decl.
2025 * process.h (chan_process, Vprocess_alist): Remove decls.
2026
2027 * print.c: Make symbols static if they're not exported.
2028 (print_depth, new_backquote_output, being_printed, print_buffer):
2029 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2030 (print_interval, print_number_index, initial_stderr_stream):
2031 Now static.
2032 * lisp.h (Fprinc): Remove decl.
2033 (debug_output_compilation_hack): Mark as externally visible.
2034
2035 * sysdep.c (croak): Move decl from here to syssignal.h.
2036 * syssignal.h (croak): Put it here, so the API can be checked when
2037 'croak' is called from dissociate_if_controlling_tty.
2038
2039 * minibuf.c: Make symbols static if they're not exported.
2040 (minibuf_save_list, choose_minibuf_frame): Now static.
2041 * lisp.h (choose_minibuf_frame): Remove decl.
2042
2043 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2044
2045 * lread.c: Make symbols static if they're not exported.
2046 (read_objects, initial_obarray, oblookup_last_bucket_number):
2047 Now static.
2048 (make_symbol): Remove; unused.
2049 * lisp.h (initial_obarray, make_symbol): Remove decls.
2050
2051 * keyboard.c: Make symbols static if they're not exported.
2052 (single_kboard, recent_keys_index, total_keys, recent_keys):
2053 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2054 (this_single_command_key_start, echoing, last_auto_save):
2055 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2056 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2057 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2058 (Vlispy_mouse_stem, double_click_count):
2059 Now static.
2060 (force_auto_save_soon): Define only if SIGDANGER.
2061 (ignore_mouse_drag_p): Now static if
2062 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2063 (print_help): Remove; unused.
2064 (stop_character, last_timer_event): Mark as externally visible.
2065 * keyboard.h (ignore_mouse_drag_p): Declare only if
2066 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2067 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2068 * lisp.h (echoing): Remove decl.
2069 (force_auto_save_soon): Declare only if SIGDANGER.
2070 * xdisp.c (redisplay_window): Simplify code, to make it more
2071 obvious that ignore_mouse_drag_p is not accessed if !defined
2072 USE_GTK && !defined HAVE_NS.
2073
2074 * intervals.c: Make symbols static if they're not exported.
2075 (merge_properties_sticky, merge_interval_right, delete_interval):
2076 Now static.
2077 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2078
2079 * insdel.c: Make symbols static if they're not exported.
2080 However, leave prepare_to_modify_buffer alone. It's never
2081 called from outside this function, but that appears to be a bug.
2082 (combine_after_change_list, combine_after_change_buffer):
2083 (adjust_after_replace, signal_before_change): Now static.
2084 (adjust_after_replace_noundo): Remove; unused.
2085 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
2086 (signal_before_change): Remove decls.
2087
2088 * indent.c (val_compute_motion, val_vmotion): Now static.
2089
2090 * image.c: Make symbols static if they're not exported.
2091 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2092 if USE_GTK.
2093 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2094 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2095
2096 * fringe.c (standard_bitmaps): Now static.
2097 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2098
2099 * frame.c: Make symbols static if they're not exported.
2100 (x_report_frame_params, make_terminal_frame): Now static.
2101 (get_frame_param): Now static, unless HAVE_NS.
2102 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2103 (x_get_resource_string): Remove; not used.
2104 * frame.h (make_terminal_frame, x_report_frame_params):
2105 (x_get_resource_string); Remove decls.
2106 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2107 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2108
2109 * font.c, fontset.c: Make symbols static if they're not exported.
2110 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2111 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2112 * font.c (font_close_object): Now static.
2113 * font.h (font_close_object): Remove.
2114 * fontset.c (FONTSET_OBJLIST): Remove.
2115 (free_realized_fontset) #if-0 the body, which does nothing.
2116 (face_suitable_for_char_p): #if-0, as it's never called.
2117 * fontset.h (face_suitable_for_char_p): Remove decl.
2118 * xfaces.c (face_at_string_position):
2119 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
2120 since 0 is always ASCII.
2121
2122 * fns.c (weak_hash_tables): Now static.
2123
2124 * fileio.c: Make symbols static if they're not exported.
2125 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2126 (Vwrite_region_annotation_buffers): Now static.
2127
2128 * eval.c: Make symbols static if they're not exported.
2129 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2130 * lisp.h (backtrace_list): Remove decl.
2131
2132 * emacs.c: Make symbols static if they're not exported.
2133 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2134 (fatal_error_code, fatal_error_signal_hook, standard_args):
2135 Now static.
2136 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2137 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2138 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2139 * lisp.h (fatal_error_signal_hook): Remove decl.
2140 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2141
2142 * editfns.c: Move a (normally-unused) function to its only use.
2143 * editfns.c, lisp.h (get_operating_system_release): Remove.
2144 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2145 worth the hassle of breaking this out.
2146
2147 * xterm.c: Make symbols static if they're not exported.
2148 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2149 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2150 (x_destroy_window, x_delete_display):
2151 Now static.
2152 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2153 (x_mouse_leave): Remove; unused.
2154 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2155 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2156 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2157 Remove decls.
2158 (x_mouse_leave): Declare only if WINDOWSNT.
2159 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2160 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2161 USE_X_TOOLKIT.
2162
2163 * ftxfont.c: Make symbols static if they're not exported.
2164 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2165 HAVE_FREETYPE.
2166 * font.h (ftxfont_driver): Likewise.
2167
2168 * xfns.c: Make symbols static if they're not exported.
2169 (x_last_font_name, x_display_info_for_name):
2170 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2171 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2172 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2173 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2174 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2175 (last_show_tip_args): Now static.
2176 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2177 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2178 (x_screen_planes): Remove; unused.
2179 * dispextern.h (x_screen_planes): Remove decl.
2180
2181 * dispnew.c: Make symbols static if they're not exported.
2182 * dispextern.h (redraw_garbaged_frames, scrolling):
2183 (increment_row_positions): Remove.
2184 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2185 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2186 Now static.
2187 (redraw_garbaged_frames): Remove; unused.
2188
2189 * xfaces.c: Make symbols static if they're not exported.
2190 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2191 Remove decls.
2192 * xterm.h (defined_color): Remove decls.
2193 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2194 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2195 (menu_face_changed_default, defined_color, free_realized_face):
2196 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2197 (ascii_face_of_lisp_face): Remove; unused.
2198
2199 * xdisp.c: Make symbols static if they're not exported.
2200 * dispextern.h (scratch_glyph_row, window_box_edges):
2201 (glyph_to_pixel_coords, set_cursor_from_row):
2202 (get_next_display_element, set_iterator_to_next):
2203 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2204 (show_mouse_face): Remove decls
2205 * frame.h (message_buf_print): Likewise.
2206 * lisp.h (pop_message, set_message, check_point_in_composition):
2207 Likewise.
2208 * xterm.h (set_vertical_scroll_bar): Likewise.
2209 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2210 (message_buf_print, scratch_glyph_row, displayed_buffer):
2211 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2212 (get_next_display_element, show_mouse_face, window_box_edges):
2213 (frame_to_window_pixel_xy, check_point_in_composition):
2214 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2215 (glyph_to_pixel_coords): Remove; unused.
2216
2217 * dired.c (file_name_completion): Now static.
2218
2219 * dbusbind.c (xd_in_read_queued_messages): Now static.
2220
2221 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2222 * data.c (circular_list_error): Remove.
2223
2224 * commands.h (last_point_position, last_point_position_buffer):
2225 (last_point_position_window): Remove decls.
2226 * keyboard.c: Make these variables static.
2227
2228 * coding.h (coding, code_convert_region, encode_coding_gap):
2229 Remove decls.
2230 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2231 (iso_code_class, detect_coding, code_convert_region): Now static.
2232 (encode_coding_gap): Remove; unused.
2233
2234 * chartab.c (chartab_chars, chartab_bits): Now static.
2235
2236 * charset.h (charset_iso_8859_1): Remove decl.
2237 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2238 Now static.
2239
2240 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2241 * ccl.c (Vccl_program_table): Now static.
2242 (check_ccl_update): Remove; unused.
2243
2244 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2245 * category.h: ... from here.
2246 * category.c (check_category_table, set_category_set): Now static.
2247
2248 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2249 * lisp.h: Remove these decls.
2250
2251 * buffer.c (buffer_count): Remove unused var.
2252
2253 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2254 so that it's not optimized away.
2255 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2256 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2257 exported only to the debugger.
2258
2259 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
2260 * atimer.h (run_all_atimers): Remove; not exported.
2261
2262 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2263 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2264 was inaccessible from Lisp.
2265 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2266 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2267
2268 alloc.c: Import and export fewer symbols, and remove unused items.
2269 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2270 is defined.
2271 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2272 it's not optimized away by whole-program optimization.
2273 (message_enable_multibyte, free_misc): Remove.
2274 (catchlist, handlerlist, mark_backtrace):
2275 Declare only if BYTE_MARK_STACK.
2276 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2277 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2278 (message_enable_multibyte): Remove decl.
2279 (free_misc, interval_free_list, float_block, float_block_index):
2280 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2281 (cons_free_list, last_marked_index):
2282 Now static.
2283 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2284 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2285 (mark_backtrace): Define only if BYTE_MARK_STACK.
2286 * xdisp.c (message_enable_multibyte): Now static.
2287
2288 Declare Lisp_Object Q* variables to be 'static' if not exported.
2289 This makes it easier for human readers (and static analyzers)
2290 to see whether these variables are used from other modules.
2291 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2292 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2293 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2294 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2295 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2296 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2297 * xmenu.c, xselect.c:
2298 Declare Q* vars static if they are not used in other modules.
2299 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2300 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2301 Remove decls of unexported vars.
2302 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2303
2304 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2305
2306 Make Emacs functions such as Fatom 'static' by default.
2307 This makes it easier for human readers (and static analyzers)
2308 to see whether these functions can be called from other modules.
2309 DEFUN now defines a static function. To make the function external
2310 so that it can be used in other C modules, use the new macro DEFUE.
2311 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2312 (Finit_image_library):
2313 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2314 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2315 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2316 Remove decls, since these functions are now static.
2317 (Funintern, Fget_internal_run_time): New decls, since these functions
2318 were already external.
2319
2320 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2321 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2322 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2323 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2324 * keyboard.c, keymap.c, lread.c:
2325 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2326 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2327 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2328 Mark functions with DEFUE instead of DEFUN,
2329 if they are used in other modules.
2330 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2331 decls for now-static functions.
2332 * buffer.h (Fdelete_overlay): Remove decl.
2333 * callproc.c (Fgetenv_internal): Mark as internal.
2334 * composite.c (Fremove_list_of_text_properties): Remove decl.
2335 (Fcomposition_get_gstring): New forward static decl.
2336 * composite.h (Fcomposite_get_gstring): Remove decl.
2337 * dired.c (Ffile_attributes): New forward static decl.
2338 * doc.c (Fdocumntation_property): New forward static decl.
2339 * eval.c (Ffetch_bytecode): New forward static decl.
2340 (Funintern): Remove extern decl; now in .h file where it belongs.
2341 * fileio.c (Fmake_symbolic_link): New forward static decl.
2342 * image.c (Finit_image_library): New forward static decl.
2343 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2344 * intervals.h (Fprevious_property_change):
2345 (Fremove_list_of_text_properties): Remove decls.
2346 * keyboard.c (Fthis_command_keys): Remove decl.
2347 (Fcommand_execute): New forward static decl.
2348 * keymap.c (Flookup_key): New forward static decl.
2349 (Fcopy_keymap): Now static.
2350 * keymap.h (Flookup_key): Remove decl.
2351 * process.c (Fget_process): New forward static decl.
2352 (Fprocess_datagram_address): Mark as internal.
2353 * syntax.c (Fsyntax_table_p): New forward static decl.
2354 (skip_chars): Remove duplicate decl.
2355 * textprop.c (Fprevious_property_change): New forward static decl.
2356 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2357 Now internal.
2358 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2359 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2360
2361 * editfns.c (Fformat): Remove unreachable code.
2362
2363 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2364
2365 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2366 change. (Bug#8496)
2367
2368 2011-04-13 Eli Zaretskii <eliz@gnu.org>
2369
2370 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2371 when at ZV. (Bug#8487)
2372
2373 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2374
2375 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2376 (Bug#8437)
2377 * keyboard.c (parse_tool_bar_item): Likewise.
2378 * sound.c (sound_cleanup, alsa_close): Likewise.
2379 * termcap.c (tgetent): Likewise.
2380 * xfns.c (x_default_font_parameter): Likewise.
2381 * xsettings.c (read_and_apply_settings): Likewise.
2382
2383 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2384 (overrun_check_free): Protoize.
2385
2386 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2387
2388 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2389 since callers should never pass a negative size.
2390 Change the signature to match that of plain 'read' and 'write'; see
2391 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2392 * lisp.h: Update prototypes of emacs_write and emacs_read.
2393
2394 2011-04-11 Eli Zaretskii <eliz@gnu.org>
2395
2396 * xdisp.c (redisplay_window): Don't try to determine the character
2397 position of the scroll margin if the window start point w->startp
2398 is outside the buffer's accessible region. (Bug#8468)
2399
2400 2011-04-10 Eli Zaretskii <eliz@gnu.org>
2401
2402 Fix write-region and its subroutines for buffers > 2GB.
2403 * fileio.c (a_write, e_write): Modify declaration of arguments and
2404 local variables to support buffers larger than 2GB.
2405 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2406
2407 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2408 argument, local variables, and return value.
2409
2410 * lisp.h: Update prototypes of emacs_write and emacs_read.
2411
2412 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2413
2414 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
2415
2416 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2417
2418 Fix more problems found by GCC 4.6.0's static checks.
2419
2420 * xdisp.c (vmessage): Use a better test for character truncation.
2421
2422 * charset.c (load_charset_map): <, not <=, for optimization,
2423 and to avoid potential problems with integer overflow.
2424 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
2425 * casetab.c (set_identity, shuffle): Likewise.
2426 * editfns.c (Fformat): Likewise.
2427 * syntax.c (skip_chars): Likewise.
2428
2429 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2430 This also lets GCC 4.6.0 generate slightly better loop code.
2431
2432 * callint.c (Fcall_interactively): <, not <=, for optimization.
2433 (Fcall_interactively): Count the number of arguments produced,
2434 not the number of arguments given. This is simpler and lets GCC
2435 4.6.0 generate slightly better code.
2436
2437 * ftfont.c: Distingish more carefully between FcChar8 and char.
2438 The previous code passed unsigned char * to a functions like
2439 strlen and xstrcasecmp that expect char *, which does not
2440 conform to the C standard.
2441 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
2442 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
2443 char * when the C standard requires it.
2444
2445 * keyboard.c (read_char): Remove unused var.
2446
2447 * eval.c: Port to Windows vsnprintf (Bug#8435).
2448 Include <limits.h>.
2449 (SIZE_MAX): Define if the headers do not.
2450 (verror): Do not give up if vsnprintf returns a negative count.
2451 Instead, grow the buffer. This ports to Windows vsnprintf, which
2452 does not conform to C99. Problem reported by Eli Zaretskii.
2453 Also, simplify the allocation scheme, by avoiding the need for
2454 calling realloc, and removing the ALLOCATED variable.
2455
2456 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
2457
2458 Remove invocations of doprnt, as Emacs now uses vsnprintf.
2459 But keep the doprint source code for now, as we might revamp it
2460 and use it again (Bug#8435).
2461 * lisp.h (doprnt): Remove.
2462 * Makefile.in (base_obj): Remove doprnt.o.
2463 * deps.mk (doprnt.o): Remove.
2464
2465 error: Print 32- and 64-bit integers portably (Bug#8435).
2466 Without this change, on typical 64-bit hosts error ("...%d...", N)
2467 was used to print both 32- and 64-bit integers N, which relied on
2468 undefined behavior.
2469 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
2470 New macro.
2471 * lisp.h (error, verror): Mark as printf-like functions.
2472 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
2473 Report overflow in size calculations when allocating printf buffer.
2474 Do not truncate output string at its first null byte.
2475 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
2476 Truncate the output at a character boundary, since vsnprintf does not
2477 do that.
2478 * charset.c (check_iso_charset_parameter): Convert internal
2479 character to string before calling 'error', since %c now has the
2480 printf meaning.
2481 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
2482 overflow when computing char to be passed to 'error'. Do not
2483 pass Lisp_Object to 'error'; pass the integer instead.
2484 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
2485 formatted with plain %d.
2486
2487 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
2488
2489 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
2490
2491 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
2492
2493 * xterm.c (x_catch_errors): Remove duplicate declaration.
2494
2495 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
2496
2497 * xdisp.c, lisp.h (message_nolog): Remove; unused.
2498
2499 2011-04-10 Jim Meyering <meyering@redhat.com>
2500
2501 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
2502 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
2503 return ssize_t not "int", and use size_t as the buffer length.
2504 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
2505 * gnutls.h: Update declarations.
2506 * process.c (read_process_output): Use ssize_t, to match.
2507 (send_process): Likewise.
2508
2509 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
2510
2511 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
2512
2513 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
2514
2515 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
2516 Use unsigned char, to match FcChar8 type definition.
2517
2518 * xterm.c (handle_one_xevent):
2519 * xmenu.c (create_and_show_popup_menu):
2520 * xselect.c (x_decline_selection_request)
2521 (x_reply_selection_request): Avoid type-punned deref of X events.
2522
2523 2011-04-09 Eli Zaretskii <eliz@gnu.org>
2524
2525 Fix some uses of `int' instead of EMACS_INT.
2526 * search.c (string_match_1, fast_string_match)
2527 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
2528 (scan_buffer, find_next_newline_no_quit)
2529 (find_before_next_newline, search_command, Freplace_match)
2530 (Fmatch_data): Make some `int' variables be EMACS_INT.
2531
2532 * xdisp.c (display_count_lines): 3rd argument and return value now
2533 EMACS_INT. All callers changed.
2534 (pint2hrstr): Last argument is now EMACS_INT.
2535
2536 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2537 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2538 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2539 (decode_coding_utf_16, decode_coding_emacs_mule)
2540 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2541 (decode_coding_ccl, decode_coding_charset)
2542 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
2543 (decode_coding_iso_2022, decode_coding_emacs_mule)
2544 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
2545 <char_offset, last_offset>: Declare EMACS_INT.
2546 (encode_coding_utf_8, encode_coding_utf_16)
2547 (encode_coding_emacs_mule, encode_invocation_designation)
2548 (encode_designation_at_bol, encode_coding_iso_2022)
2549 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
2550 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
2551 Declare EMACS_INT.
2552 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
2553 (encode_invocation_designation): Last argument P_NCHARS is now
2554 EMACS_INT.
2555 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
2556 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
2557
2558 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
2559 All users changed.
2560
2561 * ccl.c (Fccl_execute_on_string): Declare some variables
2562 EMACS_INT.
2563
2564 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
2565
2566 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
2567
2568 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
2569
2570 * process.c (Fformat_network_address): Doc fix.
2571
2572 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
2573
2574 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
2575
2576 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
2577
2578 * keyboard.c (read_char): Call Lisp function help-form-show,
2579 instead of using internal_with_output_to_temp_buffer.
2580 (Qhelp_form_show): New var.
2581 (syms_of_keyboard): Use DEFSYM macro.
2582
2583 * print.c (internal_with_output_to_temp_buffer): Function deleted.
2584
2585 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
2586
2587 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
2588
2589 * process.c (Flist_processes): Remove to Lisp.
2590 (list_processes_1): Delete.
2591
2592 2011-04-06 Eli Zaretskii <eliz@gnu.org>
2593
2594 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
2595
2596 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
2597
2598 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
2599
2600 Fix more problems found by GCC 4.6.0's static checks.
2601
2602 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
2603
2604 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
2605
2606 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
2607
2608 * xdisp.c (vmessage): Mark as a printf-like function.
2609
2610 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
2611
2612 * sound.c (sound_warning): Don't crash if arg contains a printf format.
2613
2614 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
2615 printf-like functions.
2616 (tiff_load): Add casts to remove these marks before passing them
2617 to system-supplied API.
2618
2619 * eval.c (Fsignal): Remove excess argument to 'fatal'.
2620
2621 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
2622 This avoids several warnings with gcc -Wstrict-overflow.
2623 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
2624 directly, rather than having caller test rule sign. This avoids
2625 some unnecessary tests.
2626 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
2627 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
2628 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
2629
2630 * xfont.c (xfont_text_extents): Remove var that was set but not used.
2631 (xfont_open): Avoid unnecessary tests.
2632
2633 * composite.c (composition_gstring_put_cache): Use unsigned integer.
2634
2635 * composite.h, composite.c (composition_gstring_put_cache):
2636 Use EMACS_INT, not int, for length.
2637
2638 * composite.h (COMPOSITION_DECODE_REFS): New macro,
2639 breaking out part of COMPOSITION_DECODE_RULE.
2640 (COMPOSITION_DECODE_RULE): Use it.
2641 * composite.c (get_composition_id): Remove unused local vars,
2642 by using the new macro.
2643
2644 * textprop.c (set_text_properties_1): Change while to do-while,
2645 since the condition is always true at first.
2646
2647 * intervals.c (graft_intervals_into_buffer): Mark var as used.
2648 (interval_deletion_adjustment): Return unsigned value.
2649 All uses changed.
2650
2651 * process.c (list_processes_1, create_pty, read_process_output):
2652 (exec_sentinel): Remove vars that were set but not used.
2653 (create_pty): Remove unnecessary "volatile"s.
2654 (Fnetwork_interface_info): Avoid possibility of int overflow.
2655 (read_process_output): Do adaptive read buffering even if carryover.
2656 (read_process_output): Simplify nbytes computation if buffered.
2657
2658 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
2659
2660 * syntax.c (scan_words): Remove var that was set but not used.
2661 (update_syntax_table): Use unsigned instead of int.
2662
2663 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
2664 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
2665 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
2666
2667 * print.c (print_error_message): Avoid int overflow.
2668
2669 * font.c (font_list_entities): Redo for clarity,
2670 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
2671
2672 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
2673 (font_score): Avoid potential overflow in diff calculation.
2674
2675 * fns.c (substring_both): Remove var that is set but not used.
2676 (sxhash): Redo loop for clarity and to avoid wraparound warning.
2677
2678 * eval.c (funcall_lambda): Rename local to avoid shadowing.
2679
2680 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2681 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2682 can always succeed if overflow has undefined behavior.
2683
2684 * search.c (boyer_moore, wordify): Remove vars set but not used.
2685 (wordify): Omit three unnecessary tests.
2686
2687 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2688 All callers changed. This avoids the need for an unused var.
2689
2690 * casefiddle.c (casify_region): Remove var that is set but not used.
2691
2692 * dired.c (file_name_completion): Remove var that is set but not used.
2693
2694 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2695
2696 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
2697 (Finsert_file_contents): Remove unnecessary code checking fd.
2698
2699 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2700 Check for integer overflow on size calculations.
2701
2702 * buffer.c (Fprevious_overlay_change): Remove var that is set
2703 but not used.
2704
2705 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2706 Remove vars that are set but not used.
2707 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
2708 (timer_check_2): Mark vars as initialized.
2709
2710 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2711
2712 * image.c (lookup_image): Remove var that is set but not used.
2713 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
2714
2715 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2716 that are set but not used.
2717
2718 * xfns.c (make_invisible_cursor): Don't return garbage
2719 if XCreateBitmapFromData fails (Bug#8410).
2720
2721 * xselect.c (x_get_local_selection, x_handle_property_notify):
2722 Remove vars that are set but not used.
2723
2724 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
2725 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
2726
2727 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2728 Remove var that is set but not used.
2729 (scroll_bar_windows_size): Now size_t, not int.
2730 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2731 Check for overflow.
2732
2733 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2734 (map_tty_color) [!defined MSDOS]: Likewise.
2735
2736 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2737
2738 * coding.c: Remove vars that are set but not used.
2739 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2740 All callers changed.
2741 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2742 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
2743 (decode_coding_charset): Remove vars that are set but not used.
2744
2745 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
2746 that is set but not used.
2747
2748 * print.c (print_object): Remove var that is set but not used.
2749
2750 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
2751 The gnulib version avoids calling malloc in the usual case,
2752 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2753 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
2754 * filelock.c (current_lock_owner): Likewise.
2755 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2756 * sysdep.c: Include allocator.h, careadlinkat.h.
2757 (emacs_no_realloc_allocator): New static constant.
2758 (emacs_readlink): New function.
2759 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
2760 ../lib/careadlinkat.h.
2761
2762 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
2763
2764 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2765 first non-nil return value).
2766
2767 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
2768
2769 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
2770 if not defined (Bug#8403).
2771
2772 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
2773
2774 * xdisp.c (display_count_lines): Remove parameter `start',
2775 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2776 (get_char_face_and_encoding): Remove parameter `multibyte_p',
2777 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2778 (fill_stretch_glyph_string): Remove parameters `row' and `area',
2779 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
2780 and thereabouts. All callers changed.
2781 (get_per_char_metric): Remove parameter `f', unused since
2782 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2783
2784 2011-04-02 Jim Meyering <meyering@redhat.com>
2785
2786 do not dereference NULL upon failed strdup
2787 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
2788 (ns_get_family): Likewise.
2789
2790 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
2791
2792 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
2793
2794 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
2795
2796 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
2797 later (Bug#8403).
2798
2799 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
2800
2801 Add lexical binding.
2802
2803 * window.c (Ftemp_output_buffer_show): New fun.
2804 (Fsave_window_excursion):
2805 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
2806
2807 * lread.c (lisp_file_lexically_bound_p): New function.
2808 (Fload): Bind Qlexical_binding.
2809 (readevalloop): Remove `evalfun' arg.
2810 Bind Qinternal_interpreter_environment.
2811 (Feval_buffer): Bind Qlexical_binding.
2812 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
2813 Mark as dynamic.
2814 (syms_of_lread): Declare `lexical-binding'.
2815
2816 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
2817
2818 * keyboard.c (eval_dyn): New fun.
2819 (menu_item_eval_property): Use it.
2820
2821 * image.c (parse_image_spec): Use Ffunctionp.
2822
2823 * fns.c (concat, mapcar1): Accept byte-code-functions.
2824
2825 * eval.c (Fsetq): Handle lexical vars.
2826 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
2827 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
2828 (FletX, Flet): Obey lexical binding.
2829 (Fcommandp): Handle closures.
2830 (Feval): New `lexical' arg.
2831 (eval_sub): New function extracted from Feval. Use it almost
2832 everywhere where Feval was used. Look up vars in lexical env.
2833 Handle closures.
2834 (Ffunctionp): Move from subr.el.
2835 (Ffuncall): Handle closures.
2836 (apply_lambda): Remove `eval_flags'.
2837 (funcall_lambda): Handle closures and new byte-code-functions.
2838 (Fspecial_variable_p): New function.
2839 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
2840 but without exporting it to Lisp.
2841
2842 * doc.c (Fdocumentation, store_function_docstring):
2843 * data.c (Finteractive_form): Handle closures.
2844
2845 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
2846 interactive spec.
2847
2848 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
2849 New byte-codes.
2850 (exec_byte_code): New function extracted from Fbyte_code to handle new
2851 calling convention for byte-code-functions. Add new byte-codes.
2852
2853 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
2854
2855 * alloc.c (Fmake_symbol): Init new `declared_special' field.
2856
2857 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
2858
2859 * xdisp.c (redisplay_internal): Fix prototype.
2860
2861 2011-03-31 Eli Zaretskii <eliz@gnu.org>
2862
2863 * xdisp.c (SCROLL_LIMIT): New macro.
2864 (try_scrolling): Use it when setting scroll_limit.
2865 Limit scrolling to 100 screen lines.
2866 (redisplay_window): Even when falling back on "recentering",
2867 position point in the window according to scroll-conservatively,
2868 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
2869
2870 (try_scrolling): When point is above the window, allow searching
2871 as far as scroll_max, or one screenful, to compute vertical
2872 distance from PT to the scroll margin position. This prevents
2873 try_scrolling from unnecessarily failing when
2874 scroll-conservatively is set to a value slightly larger than the
2875 window height. Clean up the case of PT below the margin at bottom
2876 of window: scroll_max can no longer be INT_MAX. When aggressive
2877 scrolling is in use, don't let point enter the opposite scroll
2878 margin as result of the scroll.
2879 (syms_of_xdisp) <scroll-conservatively>: Document the
2880 threshold of 100 lines for never-recentering scrolling.
2881
2882 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
2883
2884 * dispextern.h (move_it_by_lines):
2885 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
2886 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
2887 (message_log_check_duplicate): Remove parameters `prev_bol' and
2888 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2889 (redisplay_internal): Remove parameter `preserve_echo_area',
2890 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
2891
2892 * indent.c (Fvertical_motion):
2893 * window.c (window_scroll_pixel_based, Frecenter):
2894 Don't pass `need_y_p' to `move_it_by_lines'.
2895
2896 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
2897
2898 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
2899 steal a few bits to be more compact.
2900 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2901 Remove unneeded casts.
2902
2903 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2904
2905 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2906
2907 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2908 binding" message (bug#7967).
2909
2910 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2911
2912 Fix more problems found by GCC 4.6.0's static checks.
2913
2914 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2915 Remove unused local var.
2916
2917 * editfns.c (Fmessage_box): Remove unused local var.
2918
2919 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2920 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2921 Omit unused local vars.
2922 * window.c (shrink_windows): Omit unused local var.
2923 * menu.c (digest_single_submenu): Omit unused local var.
2924 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2925 Omit unused local var.
2926
2927 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2928 Don't assume string length fits in int.
2929 (keyremap_step, read_key_sequence): Use size_t for sizes.
2930 (read_key_sequence): Don't check last_real_key_start redundantly.
2931
2932 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2933 instead of alloca (Bug#8344).
2934
2935 * eval.c (Fbacktrace): Don't assume nargs fits in int.
2936 (Fbacktrace_frame): Don't assume nframes fits in int.
2937
2938 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2939
2940 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2941 concerns.
2942
2943 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2944
2945 * cm.c (calccost): Turn while-do into do-while, for clarity.
2946
2947 * keyboard.c (syms_of_keyboard): Use the same style as later
2948 in this function when indexing through an array. This also
2949 works around GCC bug 48267.
2950
2951 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2952
2953 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2954
2955 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2956 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2957
2958 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2959 This avoids undefined behavior on integer overflow, and is a bit
2960 more convenient anyway since it is compared to a size_t variable.
2961
2962 Variadic C functions now count arguments with size_t, not int.
2963 This avoids an unnecessary limitation on 64-bit machines, which
2964 caused (substring ...) to crash on large vectors (Bug#8344).
2965 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2966 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
2967 All variadic functions and their callers changed accordingly.
2968 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2969 * data.c (arith_driver, float_arith_driver): Likewise.
2970 * editfns.c (general_insert_function): Likewise.
2971 * eval.c (struct backtrace.nargs, interactive_p)
2972 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2973 (funcall_lambda, mark_backtrace): Likewise.
2974 * fns.c (concat): Likewise.
2975 * frame.c (x_set_frame_parameters): Likewise.
2976 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2977 0 if not found, not -1. All callers changed.
2978
2979 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2980 (stack_copy_size): Now size_t, not int.
2981 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2982
2983 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
2984
2985 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2986 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2987 All callers changed.
2988
2989 * lisp.h (multibyte_char_to_unibyte):
2990 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
2991 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2992 * character.h (CHAR_TO_BYTE8):
2993 * cmds.c (internal_self_insert):
2994 * editfns.c (general_insert_function):
2995 * keymap.c (push_key_description):
2996 * search.c (Freplace_match):
2997 * xdisp.c (message_dolog, set_message_1): All callers changed.
2998
2999 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3000
3001 * keyboard.c (safe_run_hook_funcall): New function.
3002 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3003 don't set the hook to nil, but remove the offending function instead.
3004 (Qcommand_hook_internal): Remove, unused.
3005 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3006 Vcommand_hook_internal.
3007
3008 * eval.c (enum run_hooks_condition): Remove.
3009 (funcall_nil, funcall_not): New functions.
3010 (run_hook_with_args): Call each function through a `funcall' argument.
3011 Remove `cond' argument, now redundant.
3012 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3013 (Frun_hook_with_args_until_failure): Adjust accordingly.
3014 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3015
3016 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3017
3018 * dispextern.h (string_buffer_position): Remove declaration.
3019
3020 * print.c (strout): Remove parameter `multibyte', unused since
3021 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3022
3023 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3024 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3025 All callers changed.
3026
3027 * w32.c (_wsa_errlist): Use braces for struct initializers.
3028
3029 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3030 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3031 All callers changed.
3032 (string_buffer_position): Likewise. Also, make static (it's never
3033 used outside xdisp.c).
3034 (cursor_row_p): Remove parameter `w', unused since
3035 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3036 (decode_mode_spec): Remove parameter `precision', introduced during
3037 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3038 All callers changed.
3039
3040 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3041
3042 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3043
3044 2011-03-27 Anders Lindgren <andlind@gmail.com>
3045
3046 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3047 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3048 (ns_update_auto_hide_menu_bar): New functions.
3049 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3050 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3051 ns_constrain_all_frames.
3052 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3053 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3054
3055 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3056
3057 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3058
3059 2011-03-27 Glenn Morris <rgm@gnu.org>
3060
3061 * syssignal.h: Replace RETSIGTYPE with void.
3062 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3063 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3064 Replace SIGTYPE with void everywhere.
3065 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3066 * s/template.h (SIGTYPE): Remove commented out definition.
3067
3068 2011-03-26 Eli Zaretskii <eliz@gnu.org>
3069
3070 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3071 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3072
3073 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
3074
3075 * w32.c (read_unc_volume): Use parameter `henum', instead of
3076 global variable `wget_enum_handle'.
3077
3078 * keymap.c (describe_vector): Remove parameters `indices' and
3079 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3080 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3081
3082 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3083
3084 * keyboard.c (timer_check): Remove parameter `do_it_now',
3085 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3086 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3087 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3088
3089 * keyboard.c (read_char):
3090 * w32menu.c (w32_menu_display_help):
3091 * xmenu.c (show_help_event, menu_help_callback):
3092 Adjust calls to `show_help_echo'.
3093
3094 * gtkutil.c (xg_maybe_add_timer):
3095 * keyboard.c (readable_events):
3096 * process.c (wait_reading_process_output):
3097 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3098
3099 * insdel.c (adjust_markers_gap_motion):
3100 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3101 (gap_left, gap_right): Don't call it.
3102
3103 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
3104
3105 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3106 incurred during fontification.
3107
3108 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3109
3110 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3111 (DEFVAR_PER_BUFFER): Don't pass it.
3112
3113 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3114 (scrolling_window): Don't pass it.
3115
3116 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3117
3118 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3119
3120 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3121 and `suffix'.
3122 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3123 of variables specific to SELinux and computation of `encoded_absname'.
3124
3125 * image.c (XPutPixel): Remove unused variable `height'.
3126
3127 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3128
3129 * unexw32.c (get_section_info): Remove unused variable `section'.
3130
3131 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3132 (system_process_attributes): Remove unused variable `sess'.
3133 (sys_read): Remove unused variable `err'.
3134
3135 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3136 (w32_wnd_proc): Remove unused variable `isdead'.
3137 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3138 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3139 (x_create_tip_frame): Remove unused variable `tem'.
3140
3141 * w32inevt.c (w32_console_read_socket):
3142 Remove unused variable `no_events'.
3143
3144 * w32term.c (x_draw_composite_glyph_string_foreground):
3145 Remove unused variable `width'.
3146
3147 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
3148
3149 * w32term.c (x_set_glyph_string_clipping):
3150 Don't pass uninitialized region to CombineRgn.
3151
3152 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
3153
3154 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3155 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3156 (Fx_close_connection): Remove unused variable `i'.
3157
3158 * w32font.c (w32font_draw): Return number of glyphs.
3159 (w32font_open_internal): Remove unused variable `i'.
3160 (w32font_driver): Add missing initializer.
3161
3162 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3163 (fill_in_menu): Remove unused variable `items_added'.
3164
3165 * w32term.c (last_mouse_press_frame): Remove static global variable.
3166 (w32_clip_to_row): Remove unused variable `f'.
3167 (x_delete_terminal): Remove unused variable `i'.
3168
3169 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3170 (NOTHING): Remove unused static global variable.
3171 (uniscribe_check_otf): Remove unused variable `table'.
3172 (uniscribe_font_driver): Add missing initializers.
3173
3174 2011-03-23 Julien Danjou <julien@danjou.info>
3175
3176 * term.c (Fsuspend_tty, Fresume_tty):
3177 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3178 * window.c (temp_output_buffer_show):
3179 * insdel.c (signal_before_change):
3180 * frame.c (Fhandle_switch_frame):
3181 * fileio.c (Fdo_auto_save):
3182 * emacs.c (Fkill_emacs):
3183 * editfns.c (save_excursion_restore):
3184 * cmds.c (internal_self_insert):
3185 * callint.c (Fcall_interactively):
3186 * buffer.c (Fkill_all_local_variables):
3187 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3188 Use Frun_hooks.
3189 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
3190 unconditionnaly since it does the check itself.
3191
3192 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
3193
3194 Fix more problems found by GCC 4.5.2's static checks.
3195
3196 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3197 the first time through the loop, since we know p0 < p1 then.
3198 This also avoids a gcc -Wstrict-overflow warning.
3199
3200 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3201 leading to a memory leak, possible in functions like
3202 load_charset_map_from_file that can allocate an unbounded number
3203 of objects (Bug#8318).
3204
3205 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3206 that could (at least in theory) be that large.
3207
3208 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3209 This is less likely to overflow, and avoids undefined behavior if
3210 overflow does occur. All callers changed. Use strtoul to scan
3211 for the unsigned long integer.
3212 (pint2hrstr): Simplify and tune code slightly.
3213 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
3214
3215 * scroll.c (do_scrolling): Work around GCC bug 48228.
3216 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3217
3218 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3219 This also avoids a warning with gcc -Wstrict-overflow.
3220 (validate_x_resource_name): Simplify count usage.
3221 This also avoids a warning with gcc -Wstrict-overflow.
3222
3223 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3224 fail (Bug#8306).
3225
3226 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
3227
3228 * process.c (Fmake_network_process): Use socklen_t, not int,
3229 where POSIX says socklen_t is required in portable programs.
3230 This fixes a porting bug on hosts like 64-bit HP-UX, where
3231 socklen_t is wider than int (Bug#8277).
3232 (Fmake_network_process, server_accept_connection):
3233 (wait_reading_process_output, read_process_output):
3234 Likewise.
3235
3236 * process.c: Rename or move locals to avoid shadowing.
3237 (list_processes_1, Fmake_network_process):
3238 (read_process_output_error_handler, exec_sentinel_error_handler):
3239 Rename or move locals.
3240 (Fmake_network_process): Define label "retry_connect" only if needed.
3241 (Fnetwork_interface_info): Fix pointer signedness.
3242 (process_send_signal): Add cast to avoid pointer signedness problem.
3243 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
3244 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
3245
3246 Make tparam.h and terminfo.c consistent.
3247 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3248 Include tparam.h instead, since it declares them.
3249 * cm.h (PC): Remove extern decl; tparam.h now does this.
3250 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3251 * terminfo.c: Include tparam.h, to check interfaces.
3252 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3253 (tparam): Adjust signature to match interface in tparam.h;
3254 this removes some undefined behavior. Check that outstring and len
3255 are zero, which they always are with Emacs.
3256 * tparam.h (PC, BC, UP): New extern decls.
3257
3258 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
3259 (xftfont_open): Rename locals to avoid shadowing.
3260
3261 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
3262 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3263 (OTF_TAG_SYM): Omit macro if not needed.
3264 (ftfont_list): Remove unused local.
3265 (get_adstyle_property, ftfont_pattern_entity):
3266 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3267 Rename locals to avoid shadowing.
3268
3269 * xfont.c (xfont_list_family): Mark var as initialized.
3270
3271 * xml.c (make_dom): Now static.
3272
3273 * composite.c (composition_compute_stop_pos): Rename local to
3274 avoid shadowing.
3275 (composition_reseat_it): Remove unused locals.
3276 (find_automatic_composition, composition_adjust_point): Likewise.
3277 (composition_update_it): Mark var as initialized.
3278 (find_automatic_composition): Mark vars as initialized,
3279 with a FIXME (Bug#8290).
3280
3281 character.h: Rename locals to avoid shadowing.
3282 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3283 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3284 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3285 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3286 to avoid shadowing.
3287
3288 * textprop.c (property_change_between_p): Remove; unused.
3289
3290 * intervals.c (interval_start_pos): Now static.
3291
3292 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3293
3294 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3295 Rename locals to avoid shadowing.
3296
3297 * sound.c (wav_play, au_play, Fplay_sound_internal):
3298 Fix pointer signedness.
3299 (alsa_choose_format): Remove unused local var.
3300 (wav_play): Initialize a variable to 0, to prevent undefined
3301 behavior (Bug#8278).
3302
3303 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3304
3305 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3306
3307 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3308 clobbering (Bug#8298).
3309 * sysdep.c (sys_subshell): Likewise.
3310 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
3311
3312 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3313 This should get cleaned up, so that child_setup has the
3314 same signature on all platforms.
3315
3316 * callproc.c (call_process_cleanup): Now static.
3317 (relocate_fd): Rename locals to avoid shadowing.
3318
3319 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
3320
3321 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3322 not to be necessary, and produces flickering.
3323
3324 2011-03-20 Glenn Morris <rgm@gnu.org>
3325
3326 * config.in: Remove file.
3327
3328 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
3329
3330 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3331 are now in src/globals.h.
3332 (syms_of_minibuf): Remove spurious & from previous change.
3333
3334 2011-03-20 Leo <sdl.web@gmail.com>
3335
3336 * minibuf.c (completing-read-function): New variable.
3337 (completing-read-default): Rename from completing-read.
3338 (completing-read): Call completing-read-function.
3339
3340 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3341
3342 * xfaces.c (Fx_load_color_file):
3343 Read color file from absolute filename (bug#8250).
3344
3345 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3346
3347 * makefile.w32-in: Update dependencies.
3348
3349 2011-03-17 Eli Zaretskii <eliz@gnu.org>
3350
3351 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3352
3353 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3354
3355 Fix more problems found by GCC 4.5.2's static checks.
3356
3357 * process.c (make_serial_process_unwind, send_process_trap):
3358 (sigchld_handler): Now static.
3359
3360 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3361 That way, the code declares only the vars that it needs.
3362 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3363 * s/cygwin.h (PTY_ITERATION): Likewise.
3364 * s/darwin.h (PTY_ITERATION): Likewise.
3365 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3366
3367 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3368 * process.c (allocate_pty): Don't declare stb unless it's needed.
3369
3370 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
3371 (CONSTANTLIM): Remove; unused.
3372 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3373 Define only if needed.
3374
3375 * unexelf.c (unexec): Name an expression,
3376 to avoid gcc -Wbad-function-cast warning.
3377 Use a different way to cause a compilation error if anyone uses
3378 n rather than nn, a way that does not involve shadowing.
3379 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
3380
3381 * deps.mk (unexalpha.o): Remove; unused.
3382
3383 New file unexec.h, the (simple) interface for unexec (Bug#8267).
3384 * unexec.h: New file.
3385 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3386 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3387 Depend on unexec.h.
3388 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3389 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3390 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
3391 Change as necessary to match prototype in unexec.h.
3392
3393 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3394 shadowing.
3395 (back_comment, skip_chars): Mark vars as initialized.
3396
3397 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3398 Rename locals to avoid shadowing.
3399
3400 * lread.c (read1): Rewrite so as not to use empty "else".
3401 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
3402
3403 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3404
3405 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3406 warning when compiling print.c.
3407
3408 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3409 instead of using an uninitialized var.
3410 (font_sort_entities): Mark var as initialized.
3411
3412 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3413
3414 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3415 pointers to constants.
3416 (font_parse_fcname): Remove unused vars.
3417 (font_delete_unmatched): Now static.
3418 (font_get_spec): Remove; unused.
3419 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3420 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3421 Rename or move locals to avoid shadowing.
3422
3423 * fns.c (require_nesting_list, require_unwind): Now static.
3424 (Ffillarray): Rename locals to avoid shadowing.
3425
3426 * floatfns.c (domain_error2): Define only if needed.
3427 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
3428
3429 * alloc.c (mark_backtrace): Move decl from here ...
3430 * lisp.h: ... to here, so that it can be checked.
3431
3432 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
3433 (Fdefvar): Rewrite so as not to use empty "else".
3434 (lisp_indirect_variable): Name an expression,
3435 to avoid gcc -Wbad-function-cast warning.
3436 (Fdefvar): Rename locals to avoid shadowing.
3437
3438 * callint.c (quotify_arg, quotify_args): Now static.
3439 (Fcall_interactively): Rename locals to avoid shadowing.
3440 Use const pointer when appropriate.
3441
3442 * lisp.h (get_system_name, get_operating_system_release):
3443 Move decls here, to check interfaces.
3444 * process.c (get_operating_system_release): Move decl to lisp.h.
3445 * xrdb.c (get_system_name): Likewise.
3446 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
3447 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
3448 some of which prompt warnings from gcc -Wbad-function-cast.
3449 (Fformat_time_string, Fencode_time, Finsert_char):
3450 (Ftranslate_region_internal, Fformat):
3451 Rename or remove local vars to avoid shadowing.
3452 (Ftranslate_region_internal): Mark var as initialized.
3453
3454 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
3455 avoid shadowing.
3456
3457 * lisp.h (eassert): Check that the argument compiles, even if
3458 ENABLE_CHECKING is not defined.
3459
3460 * data.c (Findirect_variable): Name an expression, to avoid
3461 gcc -Wbad-function-cast warning.
3462 (default_value, arithcompare, arith_driver, arith_error): Now static.
3463 (store_symval_forwarding): Rename local to avoid shadowing.
3464 (Fmake_variable_buffer_local, Fmake_local_variable):
3465 Mark variables as initialized.
3466 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
3467
3468 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
3469 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
3470 Rename locals to avoid shadowing.
3471 (mark_stack): Move local variables into the #ifdef region where
3472 they're used.
3473 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
3474 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
3475 needed otherwise.
3476 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
3477 (GC_STRING_CHARS): Remove; not used.
3478 (Fmemory_limit): Cast sbrk's returned value to char *.
3479
3480 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
3481 avoids undefined behavior in theory.
3482
3483 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
3484
3485 Use functions, not macros, for up- and down-casing (Bug#8254).
3486 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3487 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
3488 to use the following functions instead of these macros.
3489 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
3490 EMACS_INT, since callers assume the returned value fits in int.
3491 (upcase1): Likewise, for UPCASE_TABLE.
3492 (uppercasep, lowercasep, upcase): New static inline functions.
3493 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
3494 the race-condition problem in the old DOWNCASE.
3495
3496 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
3497 Rename locals to avoid shadowing.
3498 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
3499 (regex_compile, re_search_2, re_match_2_internal):
3500 Remove unused local vars.
3501 (FREE_VAR): Rewrite so as not to use empty "else",
3502 which gcc can warn about.
3503 (regex_compile, re_match_2_internal): Mark locals as initialized.
3504 (RETALLOC_IF): Define only if needed.
3505 (WORDCHAR_P): Likewise. This one is never needed, but is used
3506 only in a comment talking about a compiler bug, so put inside
3507 the #if 0 of that comment.
3508 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
3509 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
3510 Remove; unused.
3511
3512 * search.c (boyer_moore): Rename locals to avoid shadowing.
3513 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
3514 (PREV_CHAR_BOUNDARY): Likewise.
3515
3516 * search.c (simple_search): Remove unused var.
3517
3518 * dired.c (compile_pattern): Move decl from here ...
3519 * lisp.h: ... to here, so that it can be checked.
3520 (struct re_registers): New forward decl.
3521
3522 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
3523
3524 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
3525 All uses changed.
3526 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
3527 Rename locals to avoid shadowing.
3528 (Fvertical_motion): Mark locals as initialized.
3529
3530 * casefiddle.c (casify_object, casify_region): Now static.
3531 (casify_region): Mark local as initialized.
3532
3533 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
3534
3535 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3536 New macros, so that the caller can use some names other than
3537 gcpro1, gcpro2, etc.
3538 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3539 of the new macros.
3540 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3541 argument, for consistency with GCPRO2_VAR, etc: it is now the
3542 prefix of the variable, not the variable itself. All uses
3543 changed.
3544 * dired.c (directory_files_internal, file_name_completion):
3545 Rename locals to avoid shadowing.
3546
3547 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
3548 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
3549 dired.c's scmp function, had undefined behavior.
3550 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3551 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
3552 * buffer.h: ... to here, because these macros use current_buffer,
3553 and the new implementation with inline functions needs to have
3554 current_buffer in scope now, rather than later when the macros
3555 are used.
3556 (downcase, upcase1): New static inline functions.
3557 (DOWNCASE, UPCASE1): Reimplement using these functions.
3558 This avoids undefined behavior in expressions like
3559 DOWNCASE (x) == DOWNCASE (y), which previously suffered
3560 from race conditions in accessing the global variables
3561 case_temp1 and case_temp2.
3562 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
3563 * lisp.h (case_temp1, case_temp2): Remove their decls.
3564 * character.h (ASCII_CHAR_P): Move from here ...
3565 * lisp.h: ... to here, so that the inline functions mentioned
3566 above can use them.
3567
3568 * dired.c (directory_files_internal_unwind): Now static.
3569
3570 * fileio.c (file_name_as_directory, directory_file_name):
3571 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
3572 Now static.
3573 (file_name_as_directory): Use const pointers when appropriate.
3574 (Fexpand_file_name): Likewise. In particular, newdir might
3575 point at constant storage, so make it a const pointer.
3576 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
3577 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
3578 signedness issues.
3579 (Fset_file_times, Finsert_file_contents, auto_save_error):
3580 Rename locals to avoid shadowing.
3581
3582 * minibuf.c (choose_minibuf_frame_1): Now static.
3583 (Ftry_completion, Fall_completions): Rename or remove locals
3584 to avoid shadowing.
3585
3586 * marker.c (bytepos_to_charpos): Remove; unused.
3587
3588 * lisp.h (verify_bytepos, count_markers): New decls,
3589 so that gcc does not warn that these functions aren't declared.
3590
3591 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
3592 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
3593 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
3594 (copy_text): Remove unused local var.
3595
3596 * filelock.c (within_one_second): Now static.
3597 (lock_file_1): Rename local to avoid shadowing.
3598
3599 * buffer.c (fix_overlays_before): Mark locals as initialized.
3600 (fix_start_end_in_overlays): Likewise. This function should be
3601 simplified by using pointers-to-pointers, but that's a different
3602 matter.
3603 (switch_to_buffer_1): Now static.
3604 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
3605 (report_overlay_modification): Rename locals to avoid shadowing.
3606
3607 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
3608 Fix pointer signedness issue.
3609 (sys_subshell): Mark local as volatile if checking for lint,
3610 to suppress a gcc -Wclobbered warning that does not seem to be right.
3611 (MAXPATHLEN): Define only if needed.
3612
3613 * process.c (serial_open, serial_configure): Move decls from here ...
3614 * systty.h: ... to here, so that they can be checked.
3615
3616 * fns.c (get_random, seed_random): Move extern decls from here ...
3617 * lisp.h: ... to here, so that they can be checked.
3618
3619 * sysdep.c (reset_io): Now static.
3620 (wait_for_termination_signal): Remove; unused.
3621
3622 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
3623 (copy_keymap_item, append_key, push_text_char_description):
3624 Now static.
3625 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
3626 (DENSE_TABLE_SIZE): Remove; unused.
3627 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
3628 (describe_map_tree):
3629 Rename locals to avoid shadowing.
3630
3631 * keyboard.c: Declare functions static if they are not used elsewhere.
3632 (echo_char, echo_dash, cmd_error, top_level_2):
3633 (poll_for_input, handle_async_input): Now static.
3634 (read_char, kbd_buffer_get_event, make_lispy_position):
3635 (make_lispy_event, make_lispy_movement, apply_modifiers):
3636 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
3637 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
3638 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
3639 (read_key_sequence, read_char): Mark locals as initialized.
3640 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
3641
3642 * keyboard.h (make_ctrl_char): New decl.
3643 (mark_kboards): Move decl here ...
3644 * alloc.c (mark_kboards): ... from here.
3645
3646 * lisp.h (force_auto_save_soon): New decl.
3647
3648 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
3649 (DEFINE_DUMMY_FUNCTION): New macro.
3650 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
3651 Use it.
3652 (main): Add casts to avoid warnings
3653 if GCC considers string literals to be constants.
3654
3655 * lisp.h (fatal_error_signal): Add decl, since it's exported.
3656
3657 * dbusbind.c: Pointer signedness fixes.
3658 (xd_signature, xd_append_arg, xd_initialize):
3659 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3660 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3661 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
3662 (Fdbus_register_signal): Use SSDATA when the context wants char *.
3663
3664 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
3665 if GCC considers string literals to be constants.
3666 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
3667
3668 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
3669
3670 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
3671 (print_preprocess, print_object): New macro to fix last change.
3672
3673 * print.c (print_preprocess): Don't forget font objects.
3674
3675 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
3676
3677 * emacs.c (USAGE3): Doc fixes.
3678
3679 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
3680
3681 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3682 structure.
3683
3684 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
3685
3686 * lisp.h (VWindow_system, Qfile_name_history):
3687 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3688 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3689 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3690
3691 * w32select.c: Don't #include "keyboard.h".
3692 (run_protected): Add extern declaration for waiting_for_input.
3693
3694 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3695 * w32console.c (detect_input_pending, read_input_pending)
3696 (encode_terminal_code):
3697 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3698 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3699 (w32_system_caret_y, Qfile_name_history):
3700 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3701 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3702 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3703 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3704 * w32proc.c (Qlocal, report_file_error):
3705 * w32term.c (Vwindow_system, updating_frame):
3706 * w32uniscribe.c (initialized, uniscribe_font_driver):
3707 Remove unneeded extern declarations.
3708
3709 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
3710
3711 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
3712
3713 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
3714
3715 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3716 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3717 These macros can no longer be used for assignment.
3718
3719 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3720 Assign struct members directly, instead of using BUF_BEGV etc.
3721 (record_buffer_markers, fetch_buffer_markers): New functions for
3722 recording and fetching special buffer markers.
3723 (set_buffer_internal_1, set_buffer_temp): Use them.
3724
3725 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3726
3727 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3728
3729 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3730 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3731
3732 * xdisp.c (hscroll_window_tree):
3733 (reconsider_clip_changes): Use PT instead of BUF_PT.
3734
3735 2011-03-13 Eli Zaretskii <eliz@gnu.org>
3736
3737 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3738 $(EMACS_ROOT)/lib/intprops.h.
3739
3740 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3741
3742 Fix more problems found by GCC 4.5.2's static checks.
3743
3744 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
3745 to unsigned char * to avoid compiler diagnostic.
3746 (xg_free_frame_widgets): Make it clear that a local variable is
3747 needed only if USE_GTK_TOOLTIP.
3748 (gdk_window_get_screen): Make it clear that this macro is needed
3749 only if USE_GTK_TOOLTIP.
3750 (int_gtk_range_get_value): New function, which avoids a diagnostic
3751 from gcc -Wbad-function-cast.
3752 (xg_set_toolkit_scroll_bar_thumb): Use it.
3753 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
3754 diagnostic from gcc -Wbad-function-cast.
3755 (get_utf8_string, xg_get_file_with_chooser):
3756 Rename locals to avoid shadowing.
3757 (create_dialog): Move locals to avoid shadowing.
3758
3759 * xgselect.c (xg_select): Remove unused var.
3760
3761 * image.c (four_corners_best): Mark locals as initialized.
3762 (gif_load): Initialize transparent_p to zero (Bug#8238).
3763 Mark another local as initialized.
3764 (my_png_error, my_error_exit): Mark with NO_RETURN.
3765
3766 * image.c (clear_image_cache): Now static.
3767 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
3768 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
3769 (x_edge_detection): Remove unnecessary cast that
3770 gcc -Wbad-function-cast diagnoses.
3771 (gif_load): Fix pointer signedness.
3772 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
3773 (jpeg_load, gif_load): Rename locals to avoid shadowing.
3774
3775 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3776
3777 Improve quality of tests for time stamp overflow.
3778 For example, without this patch (encode-time 0 0 0 1 1
3779 1152921504606846976) returns the obviously-bogus value (-948597
3780 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
3781 reports time overflow. See
3782 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
3783 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
3784 * editfns.c: Include limits.h and intprops.h.
3785 (TIME_T_MIN, TIME_T_MAX): New macros.
3786 (time_overflow): Move earlier, to before first use.
3787 (hi_time, lo_time): New functions, for an accurate test for
3788 out-of-range times.
3789 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
3790 (Fget_internal_run_time): Don't assume time_t fits in int.
3791 (make_time): Use list2 instead of Fcons twice.
3792 (Fdecode_time): More accurate test for out-of-range times.
3793 (check_tm_member): New function.
3794 (Fencode_time): Use it, to test for out-of-range times.
3795 (lisp_time_argument): Don't rely on undefined left-shift and
3796 right-shift behavior when checking for time stamp overflow.
3797
3798 * editfns.c (time_overflow): New function, refactoring common code.
3799 (Fformat_time_string, Fdecode_time, Fencode_time):
3800 (Fcurrent_time_string): Use it.
3801
3802 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
3803 * dired.c (make_time): Move to ...
3804 * editfns.c (make_time): ... here.
3805 * systime.h: Note the move.
3806
3807 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3808
3809 * fringe.c (update_window_fringes): Remove unused variables.
3810
3811 * unexmacosx.c (copy_data_segment): Also copy __got section.
3812 (Bug#8223)
3813
3814 2011-03-12 Eli Zaretskii <eliz@gnu.org>
3815
3816 * termcap.c [MSDOS]: Include "msdos.h".
3817 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
3818 Constify `char *' arguments and their references according to
3819 prototypes in tparam.h.
3820
3821 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
3822
3823 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
3824 Adapt all references accordingly.
3825
3826 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
3827
3828 2011-03-11 Tom Tromey <tromey@redhat.com>
3829
3830 * buffer.c (syms_of_buffer): Remove obsolete comment.
3831
3832 2011-03-11 Eli Zaretskii <eliz@gnu.org>
3833
3834 * termhooks.h (encode_terminal_code): Declare prototype.
3835
3836 * msdos.c (encode_terminal_code): Don't declare prototype.
3837
3838 * term.c (encode_terminal_code): Now external again, used by
3839 w32console.c and msdos.c.
3840
3841 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
3842 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
3843
3844 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
3845
3846 Fix some minor problems found by GCC 4.5.2's static checks.
3847
3848 * fringe.c (update_window_fringes): Mark locals as initialized
3849 (Bug#8227).
3850 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
3851
3852 * alloc.c (mark_fringe_data): Move decl from here ...
3853 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
3854 to check its interface.
3855 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
3856
3857 * fontset.c (free_realized_fontset): Now static.
3858 (Fset_fontset_font): Rename local to avoid shadowing.
3859 (fontset_font): Mark local as initialized.
3860 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
3861
3862 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
3863
3864 * xselect.c (x_disown_buffer_selections): Remove; not used.
3865 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
3866 (x_own_selection, Fx_disown_selection_internal): Rename locals
3867 to avoid shadowing.
3868 (x_handle_dnd_message): Remove local to avoid shadowing.
3869
3870 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
3871 so that the caller can use some name other than gcpro1.
3872 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
3873 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3874 (Fx_backspace_delete_keys_p):
3875 Use them to avoid shadowing, and rename vars to avoid shadowing.
3876 (x_decode_color, x_set_name, x_window): Now static.
3877 (Fx_create_frame): Add braces to silence GCC warning.
3878 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
3879 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
3880 Remove unused locals.
3881 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3882 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
3883 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
3884 macros.
3885
3886 * xterm.h (x_mouse_leave): New decl.
3887
3888 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
3889 Remove unused functions.
3890 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
3891 (x_calc_absolute_position): Now static.
3892 (XTread_socket): Don't define label "out" unless it's used.
3893 Don't declare local "event" unless it's used.
3894 (x_iconify_frame, x_free_frame_resources): Don't declare locals
3895 unless they are used.
3896 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
3897 (x_fatal_error_signal): Remove; not used.
3898 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
3899 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
3900 (x_error_catcher, x_connection_closed, x_error_handler):
3901 (x_error_quitter, xembed_send_message, x_iconify_frame):
3902 (my_log_handler): Rename locals to avoid shadowing.
3903 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
3904 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
3905
3906 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3907 Rename or move locals to avoid shadowing.
3908 (tty_defined_color, merge_face_heights): Now static.
3909 (free_realized_faces_for_fontset): Remove; not used.
3910 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3911 does not deduce is never used uninitialized.
3912 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3913 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
3914
3915 * terminal.c (store_terminal_param): Now static.
3916
3917 * xmenu.c (menu_highlight_callback): Now static.
3918 (set_frame_menubar): Remove unused local.
3919 (xmenu_show): Rename parameter to avoid shadowing.
3920 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3921 since they might point to immutable storage.
3922 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3923 since it's unused otherwise.
3924
3925 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
3926 Add a FIXME, since the code still doesn't look right. (Bug#8215)
3927 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3928 avoids a gcc -Wuninitialized diagnostic.
3929 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
3930 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3931 does not deduce are never used uninitialized.
3932
3933 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3934
3935 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
3936 * window.c (window_loop, size_window):
3937 (run_window_configuration_change_hook, enlarge_window): Likewise.
3938
3939 * window.c (display_buffer): Now static.
3940 (size_window): Mark variables that gcc -Wuninitialized
3941 does not deduce are never used uninitialized.
3942 * window.h (check_all_windows): New decl, to forestall
3943 gcc -Wmissing-prototypes diagnostic.
3944 * dispextern.h (bidi_dump_cached_states): Likewise.
3945
3946 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3947 shadowing.
3948 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
3949 Include <limits.h>.
3950 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3951 and to avoid gcc -Wuninitialized warning.
3952 (load_charset_map): Mark variables that gcc -Wuninitialized
3953 does not deduce are never used uninitialized.
3954 (load_charset): Abort instead of using uninitialized var (Bug#8229).
3955
3956 * coding.c (coding_set_source, coding_set_destination):
3957 Use "else { /* comment */ }" rather than "else /* comment */;"
3958 for clarity, and to avoid gcc -Wempty-body warning.
3959 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3960 a block, when the outer 'i' will do.
3961 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3962 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3963 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3964 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3965 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3966 Rename locals to avoid shadowing.
3967 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
3968 * coding.c (emacs_mule_char, encode_invocation_designation):
3969 Now static, since they're not used elsewhere.
3970 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
3971 (decode_coding_object, encode_coding_object, detect_coding_system):
3972 (decode_coding_emacs_mule): Mark variables that gcc
3973 -Wuninitialized does not deduce are never used uninitialized.
3974 (detect_coding_iso_2022): Initialize a local variable that might
3975 be used uninitialized. Leave a FIXME because it's not clear that
3976 this initialization is needed. (Bug#8211)
3977 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3978 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3979 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3980 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3981 Remove unused macros.
3982
3983 * category.c (hash_get_category_set): Remove unused local var.
3984 (copy_category_table): Now static, since it's not used elsewhere.
3985 * character.c (string_count_byte8): Likewise.
3986
3987 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
3988 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
3989
3990 * chartab.c (copy_sub_char_table): Now static, since it's not used
3991 elsewhere.
3992 (sub_char_table_ref_and_range, char_table_ref_and_range):
3993 Rename locals to avoid shadowing.
3994 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
3995
3996 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
3997 (BIDI_BOB): Remove unused macro.
3998
3999 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4000 deduce are never used uninitialized.
4001 * term.c (encode_terminal_code): Likewise.
4002
4003 * term.c (encode_terminal_code): Now static. Remove unused local.
4004
4005 * tparam.h: New file.
4006 * term.c, tparam.h: Include it.
4007 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4008 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4009 Move these decls to tparam.h, and make them agree with what
4010 is actually in tparam.c. The previous trick of using incompatible
4011 decls in different modules does not conform to the C standard.
4012 All callers of tparam changed to use tparam's actual API.
4013 * tparam.c (tparam1, tparam, tgoto):
4014 Use const pointers where appropriate.
4015
4016 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4017 * cm.h (struct cm): Likewise.
4018 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4019 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4020 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4021 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4022 (turn_on_face, init_tty): Likewise.
4023 * termchar.h (struct tty_display_info): Likewise.
4024
4025 * term.c (term_mouse_position): Rename local to avoid shadowing.
4026
4027 * alloc.c (mark_ttys): Move decl from here ...
4028 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4029
4030 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4031
4032 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4033
4034 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
4035
4036 * search.c (compile_pattern_1): Remove argument regp, unused since
4037 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4038 (compile_pattern): Don't pass it.
4039
4040 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4041
4042 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4043 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4044 for ! HAVE_GTK3.
4045 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4046
4047 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4048
4049 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4050 gdk_window_get_screen, gdk_window_get_geometry,
4051 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4052 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4053 (xg_get_pixbuf_from_pixmap): New function.
4054 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4055 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4056 Call xg_get_pixbuf_from_pixmap instead of
4057 gdk_pixbuf_get_from_drawable.
4058 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4059 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4060 (xg_check_special_colors): Use GtkStyleContext and its functions
4061 for HAVE_GTK3.
4062 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4063 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4064 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
4065 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4066 Call gtk_widget_get_preferred_size.
4067 (xg_frame_resized): gdk_window_get_geometry only takes 5
4068 parameters.
4069 (xg_win_to_widget, xg_event_is_for_menubar):
4070 Call gdk_x11_window_lookup_for_display.
4071 (xg_set_widget_bg): New function.
4072 (delete_cb): New function.
4073 (xg_create_frame_widgets): Connect delete-event to delete_cb.
4074 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4075 (xg_set_background_color): Call xg_set_widget_bg.
4076 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4077 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4078 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4079 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4080 if ! HAVE_GTK3.
4081 (update_frame_tool_bar): Call gtk_widget_hide.
4082 (xg_initialize): Use GDK_KEY_g.
4083
4084 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4085 if ! HAVE_GTK3
4086 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4087
4088 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4089 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4090 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4091
4092 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
4093
4094 * w32xfns.c (select_palette): Check success of RealizePalette against
4095 GDI_ERROR, not zero.
4096
4097 See ChangeLog.11 for earlier changes.
4098
4099 ;; Local Variables:
4100 ;; coding: utf-8
4101 ;; End:
4102
4103 Copyright (C) 2011 Free Software Foundation, Inc.
4104
4105 This file is part of GNU Emacs.
4106
4107 GNU Emacs is free software: you can redistribute it and/or modify
4108 it under the terms of the GNU General Public License as published by
4109 the Free Software Foundation, either version 3 of the License, or
4110 (at your option) any later version.
4111
4112 GNU Emacs is distributed in the hope that it will be useful,
4113 but WITHOUT ANY WARRANTY; without even the implied warranty of
4114 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4115 GNU General Public License for more details.
4116
4117 You should have received a copy of the GNU General Public License
4118 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.