1 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
3 Avoid calls to strlen in path processing functions.
4 * fileio.c (file_name_as_directory): Add comment. Change to add
5 srclen argument and return the length of result. Adjust users
7 (directory_file_name): Fix comment. Change to add srclen argument,
8 swap 1nd and 2st arguments to obey the common convention. Adjust
10 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
12 2012-07-10 Glenn Morris <rgm@gnu.org>
14 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
15 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
16 * s/gnu.h (DATA_START): Move definitions to configure.
18 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
19 We include usg5-4-common.h, which defines them both.
21 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
22 O_RDONLY already includes it).
24 Stop ns builds setting the EMACSLOADPATH environment variable.
25 * nsterm.m (ns_load_path): Rename from ns_init_paths.
26 Now it does not set EMACSLOADPATH, just returns the load-path string.
27 * nsterm.h: Update accordingly.
28 * lread.c [HAVE_NS]: Include nsterm.h.
29 (init_lread) [HAVE_NS]: Use ns_load_path.
30 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
32 2012-07-09 Glenn Morris <rgm@gnu.org>
34 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
35 since the included bsd-common.h does so.
37 Stop ns builds setting the EMACSPATH environment variable.
38 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
39 (ns_init_paths): Do not set EMACSPATH.
40 * nsterm.h (ns_exec_path): Add it.
41 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
44 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
46 2012-07-09 Paul Eggert <eggert@cs.ucla.edu>
48 * process.c (wait_reading_process_output): 'waitchannels' was unset
49 when read_kbd || !NILP (wait_for_cell); fix this.
51 Add GCC-style 'const' attribute to functions that can use it.
52 * character.h (char_resolve_modifier_mask):
53 * keyboard.h (make_ctrl_char):
54 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
55 (init_character_once, next_almost_prime, init_fns, init_image)
56 (flush_pending_output, init_sound):
57 * mem-limits.h (start_of_data):
58 * menu.h (finish_menu_items):
60 * emacs.c (DEFINE_DUMMY_FUNCTION):
61 Declare the dummy function with ATTRIBUTE_CONST.
62 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
63 Add decls with ATTRIBUTE_CONST.
65 Minor improvements to make_formatted_string.
66 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
67 where int is good enough, as vsprintf returns an int.
68 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
70 2012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
72 Use make_formatted_string to avoid double length calculation.
73 * lisp.h (make_formatted_string): New prototype.
74 * alloc.c (make_formatted_string): New function.
75 * buffer.c (Fgenerate_new_buffer_name): Use it.
76 * dbus.c (syms_of_dbusbind): Likewise.
77 * editfns.c (Fcurrent_time_zone): Likewise.
78 * filelock.c (get_boot_time): Likewise.
79 * frame.c (make_terminal_frame, set_term_frame_name)
80 (x_report_frame_params): Likewise.
81 * image.c (gs_load): Likewise.
82 * minibuf.c (get_minibuffer): Likewise.
83 * msdos.c (dos_set_window_size): Likewise.
84 * process.c (make_process): Likewise.
85 * xdisp.c (ensure_echo_area_buffers): Likewise.
86 * xsettings.c (apply_xft_settings): Likewise.
88 2012-07-09 Glenn Morris <rgm@gnu.org>
90 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
91 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
92 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
93 * nsterm.h (ns_etc_directory): Add it.
94 * callproc.c [HAVE_NS]: Include nsterm.h.
95 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
97 2012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
99 Move marker debugging code under MARKER_DEBUG.
100 * marker.c (MARKER_DEBUG): Move marker debugging code under
101 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
102 for bootstrap with --enable-checking (~3x slowdown reported
103 by Juanma Barranquero <lekktu@gmail.com>).
104 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
106 2012-07-08 Paul Eggert <eggert@cs.ucla.edu>
108 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
109 See <http://bugs.gnu.org/11825#29>.
111 2012-07-08 Eli Zaretskii <eliz@gnu.org>
113 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
114 has no font, use the frame's font. (Bug#11813)
115 (display_line): Add commentary about displaying truncation glyphs
117 (produce_special_glyphs): Move here from term.c.
119 * term.c (produce_special_glyphs): Move to xdisp.c.
121 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
124 2012-07-07 Andreas Schwab <schwab@linux-m68k.org>
126 * xdisp.c (display_line): Avoid warning about implicit declaration
129 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
131 * lisp.h: Remove empty conditional.
133 2012-07-07 Paul Eggert <eggert@cs.ucla.edu>
135 * lread.c (load_path_check): Now static.
137 Fix some minor --with-ns problems found by static checking.
138 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
139 (x_set_font) [!HAVE_X_WINDOWS]:
140 * image.c (xpm_load_image) [HAVE_NS]:
141 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
142 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
144 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
145 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
146 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
147 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
148 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
149 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
150 Fix pointer signedness problem.
151 * xfaces.c (FRAME_X_FONT_TABLE):
152 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
154 2012-07-07 Glenn Morris <rgm@gnu.org>
156 * lread.c (load_path_check): New function, split from init_lread.
157 (init_lread): Reorganize. Motivation:
158 If EMACSLOADPATH is set, check/warn about that rather than the
159 defaults, which we are not going to use. Hence we can remove
160 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
161 Don't warn if site-lisp directories are missing.
162 If not installed, start from a blank load-path, since
163 PATH_LOADSEARCH refers to the eventual installation directories.
165 2012-07-07 Eli Zaretskii <eliz@gnu.org>
167 Support truncation and continuation glyphs on GUI frames, when
168 fringes are disabled. (Bug#11832)
169 * xdisp.c (init_iterator): Get dimensions of truncation and
170 continuation glyphs even if on GUI frames. Adjust
171 it->last_visible_x on GUI frames when the left or right fringes,
173 (start_display, move_it_in_display_line_to): Handle the case of a
174 GUI frame without a fringe to display continuation or truncation
176 (insert_left_trunc_glyphs): Support GUI frames: make sure
177 truncation glyphs overwrite enough glyphs from the current line to
178 have sufficient space in pixels.
179 (display_line): Support truncation and continuation glyphs on GUI
180 frames. If some spare pixels are left on the line after inserting
181 the truncation glyphs, fill that space with a stretch glyph of a
182 suitably computed width.
184 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
185 produce_glyphs, to support GUI sessions.
187 2012-07-07 Paul Eggert <eggert@cs.ucla.edu>
189 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
191 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
193 Do not require float-time's arg to fit in time_t (Bug#11825).
194 This works better on hosts where time_t is unsigned, and where
195 float-time is applied to the (negative) difference between two times.
196 * editfns.c (decode_time_components): Last arg is now double *,
197 not int *, and means to store all the result as a double, without
198 worrying about whether the seconds part fits in time_t.
200 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
202 (Ffloat_time): Do not fail merely because the specified time falls
203 outside of time_t range.
205 2012-07-07 Glenn Morris <rgm@gnu.org>
207 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
208 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
209 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
211 2012-07-07 Juanma Barranquero <lekktu@gmail.com>
213 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
216 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
218 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
220 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
221 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
222 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
223 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
224 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
225 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
227 * xfont.c (compare_font_names): Redo to omit the need for casts.
229 2012-07-06 Andreas Schwab <schwab@linux-m68k.org>
231 * xfns.c (Fx_change_window_property): Doc fix.
232 * w32fns.c (Fx_change_window_property): Doc fix.
234 * w32fns.c (Fx_window_property): Accept the same arguments as the
235 X Windows version. Doc fix.
236 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
238 2012-07-06 Juanma Barranquero <lekktu@gmail.com>
239 Eli Zaretskii <eliz@gnu.org>
241 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
242 Windows-specific code from nt/config.nt moved here.
243 Obsolete settings removed.
245 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
247 * process.c: Avoid unnecessary calls to gettime.
248 (wait_reading_process_output): Don't get the time of day
249 when gobbling data immediately and not waiting, as there's no need
250 for it in that case. This removes a FIXME.
252 2012-07-06 Jan Djärv <jan.h.d@swipnet.se>
254 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
255 is defined (Bug#11768).
257 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
259 Fix marker debugging code.
260 * marker.c (byte_char_debug_check): Do not perform the check
261 if buffer is not multibyte.
262 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
263 Call byte_char_debug_check with correct arguments.
265 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
267 Compile marker debugging code only if ENABLE_CHECKING is defined.
268 * marker.c (byte_char_debug_check, count_markers):
269 Use only if ENABLE_CHECKING is defined.
270 (byte_debug_flag): Remove.
271 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
272 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
274 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
276 Avoid code repetition in marker-related functions.
277 * marker.c (attach_marker): New function.
278 (Fset_marker, set_marker_restricted, set_marker_both)
279 (set_marker_restricted_both): Use it.
280 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
281 Consistently rename charno to charpos.
282 (marker_position): Add eassert.
283 (marker_byte_position): Convert to eassert.
285 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
287 Simplify list operations in unchain_overlay and unchain_marker.
288 * buffer.c (unchain_overlay): Simplify. Add comment.
289 * marker.c (unchain_marker): Simplify. Fix comments.
291 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
293 Introduce fast path for the widely used marker operation.
294 * alloc.c (build_marker): New function.
295 * lisp.h (build_marker): New prototype.
296 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
297 * composite.c (autocmp_chars): Likewise.
298 * editfns.c (buildmark): Remove.
299 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
300 (save_restriction_save): Use build_marker.
301 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
302 * window.c (save_window_save): Likewise.
304 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
306 Do not use Fdelete_overlay in delete_all_overlays
307 to avoid redundant calls to unchain_overlay.
308 * buffer.c (drop_overlay): New function.
309 (delete_all_overlays, Fdelete_overlay): Use it.
310 * minibuf.c (get_minibuffer): Fix comment.
312 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
314 Port to OpenBSD 5.1 amd64.
315 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
316 This is needed for OpenBSD, and should be harmless on all BSD systems.
317 Also, include <sys/sysctl.h>, as it should be available on all
318 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
319 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
320 use p_pid member, not kp_proc.pid.
322 2012-07-06 Glenn Morris <rgm@gnu.org>
324 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
326 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
328 More xmalloc and related cleanup.
329 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
330 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
331 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
332 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
333 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
334 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
335 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
336 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
337 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
339 Omit needless casts involving void * pointers and allocation.
340 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
341 as the former is more robust if P's type is changed.
342 Prefer xzalloc to xmalloc + memset 0.
343 Simplify malloc-or-realloc to realloc.
344 Don't worry about xmalloc returning a null pointer.
345 Prefer xstrdup to xmalloc + strcpy.
346 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
348 * keyboard.c (apply_modifiers_uncached): Prefer local array to
349 alloca of a constant.
351 2012-07-05 Eli Zaretskii <eliz@gnu.org>
353 * xdisp.c (display_line): Fix horizontal pixel coordinates when
354 hscroll is larger than the line width. Fixes long and futile
355 looping inside extend_face_to_end_of_line (on a TTY) producing
356 glyphs that are not needed and thrown away.
358 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
360 * marker.c (set_marker_restricted_both): Simplify by using
363 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
365 * editfns.c (region_limit): Simplify by using clip_to_bounds.
367 2012-07-05 Jan Djärv <jan.h.d@swipnet.se>
369 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
370 not defined (Bug#11768).
371 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
372 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
373 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
374 followed by gtk_box_set_homogeneous (Bug#11768).
375 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
376 (update_theme_scrollbar_width, xg_create_scroll_bar):
377 Use gtk_scrollbar_new (Bug#11768).
378 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
379 (is_box_type): New function (Bug#11768).
380 (xg_tool_item_stale_p): Call is_box_type.
381 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
382 with default display (Bug#11768).
384 2012-07-05 Eli Zaretskii <eliz@gnu.org>
386 * xdisp.c (window_hscroll_limited): New function.
387 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
388 coordinates when window's hscroll is set to insanely large
391 2012-07-05 Juanma Barranquero <lekktu@gmail.com>
393 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
394 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
396 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
399 * lisp.h (xzalloc): New prototype. Omit needless casts.
400 * alloc.c (xzalloc): New function. Omit needless casts.
401 * charset.c: Omit needless casts. Convert all calls to
402 xmalloc with following memset to xzalloc.
403 * dispnew.c: Likewise.
404 * fringe.c: Likewise.
408 * w32fns.c: Likewise.
409 * w32font.c: Likewise.
410 * w32term.c: Likewise.
411 * xfaces.c: Likewise.
414 * atimer.c: Omit needless casts.
415 * buffer.c: Likewise.
416 * callproc.c: Likewise.
418 * coding.c: Likewise.
419 * composite.c: Likewise.
421 * doprnt.c: Likewise.
422 * editfns.c: Likewise.
425 * filelock.c: Likewise.
427 * gtkutil.c: Likewise.
428 * keyboard.c: Likewise.
431 * minibuf.c: Likewise.
434 * process.c: Likewise.
435 * region-cache.c: Likewise.
436 * search.c: Likewise.
437 * sysdep.c: Likewise.
438 * termcap.c: Likewise.
439 * terminal.c: Likewise.
440 * tparam.c: Likewise.
441 * w16select.c: Likewise.
443 * w32reg.c: Likewise.
444 * w32select.c: Likewise.
445 * w32uniscribe.c: Likewise.
446 * widget.c: Likewise.
450 * xselect.c: Likewise.
452 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
454 * fileio.c (time_error_value): Check the right error number.
455 Problem reported by Troels Nielsen in
456 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
458 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
460 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
461 This should be fixed in a better way; see Eli Zaretskii in
462 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
463 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
465 * fileio.c (time_error_value): Rename from special_mtime.
466 The old name's problems were noted by Eli Zaretskii in
467 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
469 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
470 This variable's comment says Emacs needs at least one GDB-visible
471 symbol of type enum pvec_type, to work around GDB problems.
472 The symbol's value doesn't matter.
474 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
475 that causes compilation to fail on pre-C99 compilers.
477 2012-07-04 Juanma Barranquero <lekktu@gmail.com>
479 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
480 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
482 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
484 * buffer.c (init_buffer_once): Fix initialization of
485 headers for buffer_defaults and buffer_local_symbols.
486 Reported by Juanma Barranquero <lekktu@gmail.com>.
488 2012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
490 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
491 * lisp.h (enum pvec_type): Use fewer bits.
492 (PSEUDOVECTOR_SIZE_BITS): New constant.
493 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
494 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
496 (PSEUDOVECTOR_TYPEP): New macro.
497 (TYPED_PSEUDOVECTORP): Use it.
498 * fns.c (internal_equal): Adapt code to extract pvectype.
499 * emacs.c (gdb_pvec_type): Update type.
500 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
501 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
502 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
503 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
504 (sweep_vectors): Use it. Use local var `total_bytes' instead of
505 abusing vector->header.next.nbytes.
506 (live_vector_p): Use PVEC_TYPE.
507 (mark_object): Adapt code to extract pvectype. Use switch.
509 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
511 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
512 Tighten new eassert a bit.
514 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
516 Fix compilation with --enable-gcc-warnings and -O1
518 * doprnt.c (doprnt): Change type of tem to int, initialize
519 to avoid compiler warning. Add eassert.
520 * search.c (simple_search): Initialize match_byte to avoid
521 compiler warning. Add eassert.
523 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
525 Avoid weird behavior with large horizontal scrolls.
526 Without this change, for example, large hscroll values would
527 mess up Emacs's display on Fedora 15 x86, presumably due to
528 overflows in int calculations in the display code.
529 Also, if buffers had long lines, Emacs would freeze.
530 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
531 (set_window_hscroll): New function, containing the old guts of
532 Fset_window_hscroll. Return the clipped value.
533 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
534 This avoids the need to check against PTRDIFF_MAX.
536 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
538 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
540 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
542 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
544 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
545 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
546 since GCC 4.4.6 issues a bogus warning for them.
548 Fix bugs in file timestamp newness comparisons.
549 * fileio.c (Ffile_newer_than_file_p):
550 * lread.c (Fload): Use full timestamp resolution of files,
551 not just the 1-second resolution, so that files that are only
552 slightly newer still count as newer.
553 * fileio.c (Ffile_newer_than_file_p): Don't assume file
554 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
556 2012-07-03 Paul Eggert <eggert@cs.ucla.edu>
558 * fileio.c: Improve handling of file time marker. (Bug#11852)
559 (special_mtime): New function.
560 (Finsert_file_contents, Fverify_visited_file_modtime):
561 Use it to set special mtime values consistently.
563 2012-07-03 Andreas Schwab <schwab@linux-m68k.org>
565 * fileio.c (Finsert_file_contents): Properly handle st_mtime
566 marker for non-existing file. (Bug#11852)
568 2012-07-03 Glenn Morris <rgm@gnu.org>
570 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
571 and did not make it into globals.h).
573 2012-07-03 Tom Tromey <tromey@redhat.com>
575 * window.c (Fset_window_margins, Fset_window_fringes)
576 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
577 * textprop.c (Fprevious_property_change): No longer static.
578 * syntax.c (Fsyntax_table_p): No longer static.
579 * process.c (Fget_process, Fprocess_datagram_address): No longer
581 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
582 * keyboard.c (Fcommand_execute): No longer static.
584 * insdel.c (Fcombine_after_change_execute): No longer static.
585 * image.c (Finit_image_library): No longer static.
586 * fileio.c (Fmake_symbolic_link): No longer static.
587 * eval.c (Ffetch_bytecode): No longer static.
588 * editfns.c (Fuser_full_name): No longer static.
589 * doc.c (Fdocumentation_property, Fsnarf_documentation):
591 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
593 * dired.c (Ffile_attributes): No longer static.
594 * composite.c (Fcomposition_get_gstring): No longer static.
595 * callproc.c (Fgetenv_internal): No longer static.
597 * ccl.h: Remove EXFUNs.
598 * buffer.h: Remove EXFUNs.
599 * dispextern.h: Remove EXFUNs.
600 * intervals.h: Remove EXFUNs.
601 * fontset.h: Remove EXFUN.
602 * font.h: Remove EXFUNs.
603 * dosfns.c (system_process_attributes): Remove EXFUN.
604 * keymap.h: Remove EXFUNs.
605 * lisp.h: Remove EXFUNs.
606 * w32term.h: Remove EXFUNs.
607 * window.h: Remove EXFUNs.
608 * xsettings.h: Remove EXFUN.
609 * xterm.h: Remove EXFUN.
611 2012-07-03 Glenn Morris <rgm@gnu.org>
613 * lisp.h (Frandom): Make it visible to C.
614 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
615 buffer for invisible buffers. (Bug#1229)
617 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
619 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
620 values which aren't power of 2.
621 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
622 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
625 2012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
627 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
629 * alloc.c (mark_object): Revert part of last patch to use `switch'.
631 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
633 * alloc.c (allocate_vector_block): Remove redundant
634 calls to mallopt if DOUG_LEA_MALLOC is defined.
635 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
636 avoid calls to mallopt if zero_vector is returned.
638 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
640 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
641 is enabled, avoid dereferencing NULL current_sblock if
644 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
646 Cleanup basic buffer management.
647 * buffer.h (struct buffer): Change layout to use generic vector
648 marking code. Fix some comments. Change type of 'clip_changed'
649 to bitfield. Remove unused #ifndef old.
650 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
651 (GET_OVERLAYS_AT): Fix indentation.
652 (for_each_per_buffer_object_at): New macro.
653 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
654 (Fbuffer_local_variables): Use it.
655 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
656 * alloc.c (allocate_buffer): Adjust to match new layout of
657 struct buffer. Fix comment.
658 (mark_overlay): New function.
659 (mark_buffer): Use it. Use mark_vectorlike to mark normal
660 Lisp area of struct buffer.
661 (mark_object): Use it. Adjust marking of misc objects
662 and related comments.
664 2012-07-02 Paul Eggert <eggert@cs.ucla.edu>
666 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
667 wrapper that is not needed because the wrapped code is a no-op (zero
668 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
669 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
671 2012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
673 * alloc.c (mark_buffer): Simplify. Remove prototype.
674 (mark_object): Add comment. Reorganize marking of vector-like
675 objects. Use CHECK_LIVE for all vector-like objects except buffers
676 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
677 redundant calls to mark_vectorlike for bool vectors.
679 2012-06-30 Glenn Morris <rgm@gnu.org>
681 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
683 * epaths.in (PATH_SITELOADSEARCH): New.
684 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
685 This is rather than relying on --enable-locallisppath elements
686 having "site-lisp" in their names. (Bug#10208#25, 11658)
688 2012-06-30 Eli Zaretskii <eliz@gnu.org>
690 * w32proc.c (sys_select): Accept and ignore one more argument.
692 * w32.c (emacs_gnutls_pull): Call select with one more argument.
694 * sysselect.h [DOS_NT]: Don't include sys/select.h.
695 (pselect) [!MS_DOS]: Redirect to sys_select.
697 * sysdep.c: Don't include dos.h and dosfns.h.
699 * process.c (sys_select):
700 * msdos.c (sys_select): Accept one more argument and ignore it.
702 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
703 adapt data types and code to that.
706 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
707 which clashes with the gnulib function of the same name.
709 2012-06-30 Andreas Schwab <schwab@linux-m68k.org>
711 * font.c (font_style_to_value, font_style_symbolic)
712 (font_prop_validate_style): Add type checks for values in
715 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
717 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
720 2012-06-29 Eli Zaretskii <eliz@gnu.org>
722 * xdisp.c (try_window_id): Undo last change.
724 * w32.c (getwd): Adjust commentary about startup_dir.
725 (init_environment): Always call sys_access, even in non-MSVC
726 builds. Don't chdir to the directory of the Emacs executable.
727 This undoes code from 1997 which was justified by the need to
728 "avoid conflicts when removing and renaming directories". But its
729 downside was that every relative file name was being interpreted
730 relative to the directory of the Emacs executable, which can never
731 be TRT. In particular, it broke sys_access when called with
733 (sys_access): Map GetLastError to errno.
735 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
737 * window.h (struct window): Change type of 'fringes_outside_margins'
738 to bitfield. Fix comment. Adjust users accordingly.
739 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
741 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
744 2012-06-29 Andreas Schwab <schwab@linux-m68k.org>
746 * gnutls.c (emacs_gnutls_handshake):
747 Add QUIT to make the loop interruptible.
749 2012-06-29 Glenn Morris <rgm@gnu.org>
751 * charset.c (init_charset): Make lack of etc/charsets fatal.
753 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
755 * editfns.c (region_limit): Fix type mismatch.
757 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
759 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
760 undefined. Convert from xassert to eassert.
761 * nsmenu.m: Convert from xassert to eassert.
762 * nsterm.m: Likewise.
764 2012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
766 * editfns.c (region_limit): Clip to narrowing (bug#11770).
768 2012-06-28 Paul Eggert <eggert@cs.ucla.edu>
770 Avoid integer overflow on scroll-left and scroll-right.
771 * window.c (HSCROLL_MAX): New macro.
772 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
773 overflow when requested scroll falls outside ptrdiff_t range.
775 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
777 * window.h (struct window): Change type of 'hscroll',
778 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
779 'last_modified' and 'last_overlay_modified' to EMACS_INT.
780 Adjust users accordingly.
781 * xdisp.c (try_cursor_movement): Replace type check with eassert.
782 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
783 from EMACS_INT to ptrdiff_t.
784 (make_window): Omit redundant initialization.
786 2012-06-28 Juanma Barranquero <lekktu@gmail.com>
788 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
790 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
792 * window.h (struct window): Change type of 'use_time' and
793 'sequence_number' from Lisp_Object to int.
794 * frame.c (make_frame): Adjust users accordingly.
795 * print.c (print_object): Likewise.
796 * window.c (select_window, Fwindow_use_time, make_parent_window)
797 (make_window): Likewise.
799 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
801 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
802 enabled with --enable-checking=[all,glyphs] configure option.
803 Fix GLYPH_DEBUG usage assuming that it may be undefined,
804 adjust comments accordingly.
805 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
806 undefined, adjust comments accordingly.
808 * scroll.c: Likewise.
809 * w32fns.c: Likewise.
810 * w32term.c: Likewise.
812 * xfaces.c: Likewise.
816 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
818 Generalize run-time debugging checks.
819 * dispextern.h (XASSERTS): Remove.
820 * fontset.c (xassert): Remove.
821 Convert from xassert to eassert.
822 * alloc.c: Convert from xassert to eassert.
824 * dispnew.c: Likewise.
826 * fringe.c: Likewise.
827 * ftfont.c: Likewise.
828 * gtkutil.c: Likewise.
830 * keyboard.c: Likewise.
832 * process.c: Likewise.
833 * scroll.c: Likewise.
836 * w32console.c: Likewise.
837 * w32fns.c: Likewise.
838 * w32term.c: Likewise.
839 * window.c: Likewise.
841 * xfaces.c: Likewise.
843 * xselect.c: Likewise.
846 2012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
848 * fns.c (maybe_resize_hash_table): Output message when growing the
851 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
853 * alloc.c (allocate_string_data): Remove dead code.
854 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
855 avoid GCC warning about unused macro.
857 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
859 * alloc.c (allocate_string): Omit intervals initialization.
860 * alloc.c (make_uninit_multibyte_string): Initialize intervals
861 as in make_pure_string and make_pure_c_string.
863 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
865 * alloc.c (allocate_string): Fix last change.
867 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
869 * alloc.c (allocate_string): Remove two redundant calls
870 to memset, add explicit initialization where appropriate.
872 2012-06-27 Glenn Morris <rgm@gnu.org>
874 * lisp.mk (lisp): Remove paths.elc.
876 2012-06-27 Chong Yidong <cyd@gnu.org>
878 * doc.c (Fsubstitute_command_keys): Fix punctuation.
880 2012-06-26 John Wiegley <johnw@newartisans.com>
882 * unexmacosx.c (copy_data_segment): Add two section names used
883 on Mac OS X Lion: __mod_init_func and __mod_term_func.
885 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
886 when building with Clang.
888 2012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
890 * eval.c (Fapply): Allow calling it with a single argument.
892 2012-06-26 Eli Zaretskii <eliz@gnu.org>
894 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
895 _stricmp and _strnicmp.
896 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
898 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
900 * alloc.c (allocate_window): Zero out non-Lisp part of newly
902 (allocate_process): Likewise for new process.
903 (allocate_terminal): Change to use offsetof.
904 (allocate_frame): Likewise.
905 * frame.c (make_frame): Omit redundant initialization.
906 * window.c (make_parent_window): Use memset.
907 (make_window): Omit redundant initialization.
908 * process.c (make_process): Omit redundant initialization.
909 * terminal.c (create_terminal): Likewise.
911 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
913 * term.c (delete_tty): Remove redundant call to memset.
915 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
917 * alloc.c: Remove build_string.
918 * lisp.h: Define build_string as static inline. This provides
919 a better opportunity to optimize away calls to strlen when the
920 function is called with compile-time constant argument.
921 * image.c (imagemagick_error): Convert to build_string.
922 * w32proc.c (sys_spawnve): Likewise.
923 * xterm.c (x_term_init): Likewise.
925 2012-06-26 Paul Eggert <eggert@cs.ucla.edu>
927 Use sprintf return value instead of invoking strlen on result.
928 In the old days this wasn't portable, since some sprintf
929 implementations returned char *. But they died out years ago and
930 Emacs already assumes sprintf returns int.
931 Similarly for float_to_string.
932 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
933 * ccl.c (ccl_driver):
934 * character.c (string_escape_byte8):
935 * data.c (Fnumber_to_string):
937 * print.c (print_object):
938 * xdisp.c (message_dolog):
939 * xfns.c (syms_of_xfns):
940 Use sprintf or float_to_string result to avoid need to call strlen.
941 * data.c (Fnumber_to_string):
942 Use make_unibyte_string, since the string must be ASCII.
943 * lisp.h, print.c (float_to_string): Now returns int length.
944 * term.c (produce_glyphless_glyph):
945 Use sprintf result rather than recomputing it.
947 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
948 * Makefile.in (ALL_CFLAGS):
949 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
950 * gmalloc.c, regex.c: Include <config.h> unconditionally.
952 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
954 * dispextern.h (xstrcasecmp): Define to library function
955 strcasecmp if available.
956 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
958 2012-06-25 Andreas Schwab <schwab@linux-m68k.org>
960 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
961 Avoid comma operator.
962 * menu.c (push_submenu_start, push_submenu_end)
963 (push_left_right_boundary, push_menu_pane): Likewise.
964 * msdos.c (dos_rawgetc): Likewise.
966 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
968 * xfns.c (xic_create_fontsetname): Remove redundant calls
971 2012-06-25 Paul Eggert <eggert@cs.ucla.edu>
973 * gtkutil.c (get_utf8_string): Remove redundant assignment.
974 sprintf already null-terminates its output.
976 * xfns.c (x_window): Remove redundant cast.
978 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
980 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
981 `const char *' to `char *' to avoid compiler warning.
983 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
985 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
986 instead of truncating it to 63 (admittedly a generous limit).
988 * process.c: Fix spelling and caps in comments.
990 2012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
992 * emacs.c (setpgrp): Remove definition, unused.
993 * sysdep.c (setpgrp): Remove definition, not used in this file.
995 2012-06-24 Juanma Barranquero <lekktu@gmail.com>
997 * makefile.w32-in: Update dependencies.
999 2012-06-24 Eli Zaretskii <eliz@gnu.org>
1001 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
1002 (SYSTIME_H): Add nt/inc/sys/time.h.
1004 * systime.h [WINDOWSNT]: Include sys/time.h.
1006 * s/ms-w32.h (struct timespec): Definition moved from
1007 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
1009 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1011 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
1012 * buffer.h (buffer_slot_type_mismatch):
1013 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1014 * eval.c (unwind_to_catch):
1015 * image.c (my_png_error, my_error_exit):
1016 * keyboard.c (quit_throw_to_read_char, user_error)
1017 (Fexit_recursive_edit, Fabort_recursive_edit):
1018 * lisp.h (die, args_out_of_range, args_out_of_range_3)
1019 (wrong_type_argument, buffer_overflow, __executable_start)
1020 (memory_full, buffer_memory_full, string_overflow, Fthrow)
1021 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
1022 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
1024 (child_setup) [!DOS_NT]:
1025 * lread.c (end_of_file_error, invalid_syntax):
1026 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1027 * puresize.h (pure_write_error):
1028 * search.c (matcher_overflow):
1029 * sound.c (sound_perror, alsa_sound_perror):
1030 * sysdep.c, syssignal.h (croak):
1031 * term.c (maybe_fatal, vfatal):
1032 * textprop.c (text_read_only):
1033 * undo.c (user_error):
1034 * unexmacosx.c (unexec_error):
1035 * xterm.c (x_ins_del_lines, x_delete_glyphs):
1036 Use _Noreturn rather than NO_RETURN.
1037 No need for separate decl merely because of _Noreturn.
1038 * sound.c (sound_warning, parse_sound):
1039 Remove unnecessary forward decls.
1041 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1043 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
1044 * lisp.h (WAIT_READING_MAX): New macro.
1045 * dispnew.c (Fsleep_for, sit_for):
1046 * keyboard.c (kbd_buffer_get_event):
1047 * process.c (Faccept_process_output):
1048 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
1049 This improves on the previous patch, which introduced a bug
1050 when time_t is unsigned and as wide as intmax_t.
1051 See <http://bugs.gnu.org/9000#51>.
1053 2012-06-23 Eli Zaretskii <eliz@gnu.org>
1055 * dispnew.c (sit_for, Fsleep_for):
1056 * keyboard.c (kbd_buffer_get_event):
1057 * process.c (Faccept_process_output): Avoid compiler warnings when
1058 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
1060 2012-06-23 Juanma Barranquero <lekktu@gmail.com>
1062 * makefile.w32-in: Update dependencies.
1064 * w32.c (ltime): Add return type and declare static.
1065 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
1067 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1069 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
1070 Privately reported by Herbert J. Skuhra.
1071 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
1073 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
1074 not make_lisp_timeval, when the argument is of type EMACS_TIME.
1076 2012-06-23 Eli Zaretskii <eliz@gnu.org>
1078 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
1079 last argument of make_unibyte_string.
1081 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
1082 language ID in the event parameters.
1084 * w32term.c (w32_read_socket): Put the new keyboard codepage into
1085 event.code, not the obscure "character set ID".
1087 2012-06-23 Chong Yidong <cyd@gnu.org>
1089 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
1091 2012-06-23 Eli Zaretskii <eliz@gnu.org>
1093 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
1094 * w32.c (fdutimens): New function.
1096 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
1098 * s/ms-w32.h (pselect): Redirect to sys_select.
1100 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
1102 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
1103 in the logic of incrementing and decrementing the value of
1104 use_relocatable_buffers.
1106 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1108 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
1109 Privately reported by Herbert J. Skuhra.
1110 [__FreeBSD__]: Remove "*/" typo after "#include".
1111 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
1112 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
1113 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
1114 Don't assume EMACS_TIME and struct timeval are the same type.
1116 2012-06-22 Paul Eggert <eggert@cs.ucla.edu>
1118 Support higher-resolution time stamps (Bug#9000).
1119 The time stamps are only nanosecond-resolution at the C level,
1120 since that's the best that any real-world system supports now.
1121 But they are picosecond-resolution at the Lisp level, as that's
1122 easy, and leaves room for future OS improvements.
1124 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
1127 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
1128 Don't get current time unless it's needed.
1130 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
1131 now provides it if it's absent.
1132 (start_atimer): Port to higher-res time stamps.
1133 Check for time stamp overflow. Don't get current time more
1134 often than is needed.
1136 * buffer.h (struct buffer): Buffer modtime now has high resolution.
1137 Include systime.h, not time.h.
1138 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
1140 * dired.c: Include stat-time.h.
1141 (Ffile-attributes): File times now have higher resolution.
1143 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
1144 (struct image): Timestamp now has higher resolution.
1146 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
1147 has at least microseconds now. All uses removed.
1148 (update_frame, update_single_window, update_window, update_frame_1)
1149 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
1151 * editfns.c (time_overflow): Now extern.
1152 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
1153 (float-time, Fformat_time_string, Fcurrent_time_string)
1154 (Fcurrent_time_zone): Accept and generate higher-resolution
1156 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
1157 (decode_time_components, lisp_seconds_argument): New functions.
1158 (make_time): Now static.
1159 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
1160 Report an error if the time is invalid, rather than having the caller
1163 * fileio.c: Include <stat-time.h>
1164 (Fcopy_file): Copy higher-resolution time stamps.
1165 Prefer to set the time stamp via a file descriptor if that works.
1166 (Fset_file_times, Finsert_file_contents, Fwrite_region)
1167 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
1168 (Fvisited_file_modtime, Fset_visited_file_modtime):
1169 Support higher-resolution time stamps.
1171 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
1173 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
1175 * image.c (prepare_image_for_display, clear_image_cache)
1176 (lookup_image): Port to higer-resolution time stamps.
1178 * keyboard.c (start_polling, bind_polling_period):
1179 Check for time stamp overflow.
1180 (read_char, kbd_buffer_get_event, timer_start_idle)
1181 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
1182 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
1183 Port to higher-resolution time stamps. Do not assume time_t is signed.
1184 (decode_timer): New function. Timers are now vectors of length 9,
1185 not 8, to accommodate the picosecond component.
1186 (timer_check_2): Use it.
1188 * nsterm.m (select_timeout, timeval_subtract): Remove.
1189 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
1190 as they're a bit more accurate and handle overflow better.
1191 (ns_select): Change prototype to be compatible with pselect.
1192 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
1193 * nsterm.h (ns_select): Adjust prototype.
1195 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
1196 us-resolution time stamps.
1197 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
1199 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
1201 * lisp.h (time_overflow): New decl.
1202 (wait_reading_process_output): First arg is now intmax_t, not int,
1203 to accommodate larger waits.
1205 * process.h (struct Lisp_Process.read_output_delay):
1206 Now counts nanoseconds, not microseconds.
1207 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
1209 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
1210 (wait_reading_process_output):
1211 Port to ns-resolution time stamps.
1212 (Faccept_process_output, wait_reading_process_output):
1213 Check for time stamp overflow. Do not assume time_t is signed.
1214 (select_wrapper): Remove; we now use pselect.
1215 (Fprocess_attributes): Now generates ns-resolution time stamps.
1217 * sysdep.c: Include utimens.h. Don't include utime.h
1218 or worry about struct utimbuf; gnulib does that for us now.
1219 (gettimeofday): Remove; gnulib provides a substitute.
1220 (make_timeval): New function.
1221 (set_file_times): Now sets ns-resolution time stamps.
1222 New arg FD; all uses changed.
1223 (time_from_jiffies, ltime_from_jiffies, get_up_time)
1224 (system_process_attributes):
1225 Now returns ns-resolution time stamp. All uses changed.
1226 Check for time stamp overflow.
1228 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
1229 provides a substitute now.
1231 * systime.h: Include timespec.h rather than sys/time.h and time.h,
1232 since it guarantees struct timespec.
1233 (EMACS_TIME): Now struct timespec, so that we can support
1234 ns-resolution time stamps.
1235 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
1236 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
1237 (EMACS_USECS): Remove.
1238 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
1239 so multiply the arg by 1000 before storing it.
1240 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
1242 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
1243 Port to ns-resolution time stamps.
1244 (EMACS_TIME_NEG_P): Remove; replaced by....
1245 (EMACS_TIME_SIGN): New macro.
1246 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
1247 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
1248 (set_file_times, make_time, lisp_time_argument): Adjust signature.
1249 (make_timeval, make_lisp_time, decode_time_components): New decls.
1250 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
1251 that it mishandled time_t overflow. You can't compare by subtracting!
1252 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
1253 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
1255 * term.c: Include <sys/time.h>.
1256 (timeval_to_Time): New function, for proper overflow wraparound.
1257 (term_mouse_position, term_mouse_click): Use it.
1259 * undo.c (record_first_change): Support higher-resolution time stamps
1261 (Fprimitive_undo): Use them when restoring time stamps.
1263 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
1264 (w32_get_internal_run_time):
1265 Port to higher-resolution Emacs time stamps.
1266 (ltime): Now accepts single 64-bit integer, as that's more convenient
1269 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
1271 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
1272 for compatibility with pselect. Support ns-resolution time stamps.
1274 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
1276 * xselect.c (wait_for_property_change, x_get_foreign_selection):
1277 Check for time stamp overflow, and support ns-resolution time stamps.
1279 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
1280 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
1281 (timeval_subtract): Remove; no longer needed.
1282 (XTflash, XTring_bell, x_wait_for_event):
1283 Port to ns-resolution time stamps. Don't assume time_t is signed.
1285 2012-06-22 Chong Yidong <cyd@gnu.org>
1287 * xdisp.c (x_consider_frame_title): Revert last change.
1289 2012-06-22 Eli Zaretskii <eliz@gnu.org>
1291 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
1292 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
1293 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
1294 staticidx goes up to 1597 out of 1600 = 0x640.)
1296 2012-06-20 Paul Eggert <eggert@cs.ucla.edu>
1298 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
1299 Otherwise, the umask might be mistakenly 0 while handling input signals.
1301 2012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
1303 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
1305 2012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
1307 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
1308 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
1309 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
1310 access to `contents' member of Lisp_Vector objects with AREF and ASET
1313 2012-06-19 Chong Yidong <cyd@gnu.org>
1315 * frame.c (delete_frame): When selecting a frame on a different
1316 text terminal, do not alter the terminal's top-frame.
1318 * xdisp.c (format_mode_line_unwind_data): Record the target
1319 frame's selected window and its terminal's top-frame.
1320 (unwind_format_mode_line): Restore them.
1321 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
1323 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
1324 since tty frames can be explicitly named.
1325 (prepare_menu_bars): Likewise.
1327 * term.c (Ftty_top_frame): New function.
1329 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1331 Port byte-code-meter to modern targets.
1332 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
1333 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
1334 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
1335 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
1336 (METER_1, METER_2): Simplify.
1338 2012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
1340 * data.c (Fdefalias): Return `symbol' (bug#11686).
1342 2012-06-18 Martin Rudalics <rudalics@gmx.at>
1344 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1345 gets killed during executing of this function (Bug#11665).
1346 Try to always return Qt when the buffer has been actually killed.
1347 (Vkill_buffer_query_functions): In doc-string say that functions
1348 run by this hook should not change the current buffer.
1350 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1352 Fix recently-introduced process.c problems found by static checking.
1353 * process.c (write_queue_push, write_queue_pop, send_process):
1354 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
1355 (write_queue_pop): Fix pointer signedness problem.
1356 (send_process): Remove unused local.
1358 2012-06-17 Chong Yidong <cyd@gnu.org>
1360 * xdisp.c (redisplay_internal): No need to redisplay terminal
1361 frames that are not on top.
1363 2012-06-17 Troels Nielsen <bn.troels@gmail.com>
1365 * process.c (make_process): Initialize write_queue.
1366 (write_queue_push, write_queue_pop): New functions.
1367 (send_process): Use them to maintain correct ordering of process
1370 2012-06-17 Paul Eggert <eggert@cs.ucla.edu>
1372 * lisp.h (eassert): Assume C89 or later.
1373 This removes the need for CHECK.
1374 (CHECK): Remove. Its comments about always evaluating its
1375 argument were confusing, as 'eassert' typically does not evaluate
1378 * coding.c (produce_chars): Use ptrdiff_t, not int.
1380 * xterm.c (x_draw_underwave): Check for integer overflow.
1381 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
1383 2012-06-17 Jan Djärv <jan.h.d@swipnet.se>
1385 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
1386 referenced (Bug#11583).
1388 2012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
1390 Implement wave-style variant of underlining.
1391 * dispextern.h (face_underline_type): New enum.
1392 (face): Add field for underline type.
1393 * nsterm.m (ns_draw_underwave): New function.
1394 (ns_draw_text_decoration): Use it.
1395 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
1397 (x_draw_glyph_string): Use them.
1398 * xfaces.c (Qline, Qwave): New Lisp objects.
1399 (check_lface_attrs, merge_face_ref)
1400 (Finternal_set_lisp_face_attribute, realize_x_face):
1401 Handle wave-style underline face attributes.
1402 * xterm.c (x_draw_underwave): New function.
1403 (x_draw_glyph_string): Use it.
1405 2012-06-16 Juanma Barranquero <lekktu@gmail.com>
1407 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
1408 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
1409 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
1410 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
1411 ($(BLD)/w32select.$(O)): Update dependencies.
1413 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1415 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
1416 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
1417 * character.c (_fetch_multibyte_char_p): Remove.
1418 * alloc.c: Include "character.h" before "buffer.h".
1420 * buffer.c: Likewise.
1421 * bytecode.c: Likewise.
1422 * callint.c: Likewise.
1423 * callproc.c: Likewise.
1424 * casefiddle.c: Likewise.
1425 * casetab.c: Likewise.
1426 * category.c: Likewise.
1428 * coding.c: Likewise.
1429 * composite.c: Likewise.
1430 * dired.c: Likewise.
1431 * dispnew.c: Likewise.
1433 * dosfns.c: Likewise.
1434 * editfns.c: Likewise.
1435 * emacs.c: Likewise.
1436 * fileio.c: Likewise.
1437 * filelock.c: Likewise.
1439 * fontset.c: Likewise.
1440 * fringe.c: Likewise.
1441 * indent.c: Likewise.
1442 * insdel.c: Likewise.
1443 * intervals.c: Likewise.
1444 * keyboard.c: Likewise.
1445 * keymap.c: Likewise.
1446 * lread.c: Likewise.
1447 * macros.c: Likewise.
1448 * marker.c: Likewise.
1449 * minibuf.c: Likewise.
1450 * nsfns.m: Likewise.
1451 * nsmenu.m: Likewise.
1452 * print.c: Likewise.
1453 * process.c: Likewise.
1454 * regex.c: Likewise.
1455 * region-cache.c: Likewise.
1456 * search.c: Likewise.
1457 * syntax.c: Likewise.
1459 * textprop.c: Likewise.
1461 * unexsol.c: Likewise.
1462 * w16select.c: Likewise.
1463 * w32fns.c: Likewise.
1464 * w32menu.c: Likewise.
1465 * window.c: Likewise.
1466 * xdisp.c: Likewise.
1468 * xmenu.c: Likewise.
1470 * xselect.c: Likewise.
1472 2012-06-16 Eli Zaretskii <eliz@gnu.org>
1474 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
1475 If all the glyphs of the glyph row came from strings, and we have no
1476 cursor positioning clues, put the cursor on the first glyph of the
1478 (handle_face_prop): Use chunk-relative overlay string index when
1479 indexing into it->string_overlays array. (Bug#11653)
1480 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
1481 the rightmost. (Bug#11720)
1483 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1485 * category.h (CHAR_HAS_CATEGORY): Define as inline.
1486 (CATEGORY_MEMBER): Enforce 1/0 value.
1487 * category.c (_temp_category_set): Remove.
1489 2012-06-16 Eli Zaretskii <eliz@gnu.org>
1491 * window.c (Fdelete_other_windows_internal)
1492 (Fdelete_window_internal): Don't access frame's mouse highlight
1493 info of the initial frame. (Bug#11677)
1495 2012-06-14 Paul Eggert <eggert@cs.ucla.edu>
1497 * .gdbinit (xgetint): Fix recently-introduced paren typo.
1498 Assume USE_2_TAGS_FOR_INTS.
1499 (xreload): Adjust $tagmask width to match recent lisp.h change.
1501 Simplify lisp.h in minor ways that should not affect code.
1502 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
1503 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
1504 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
1505 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
1506 (INTTYPEBITS): New macro, for clarity.
1507 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1508 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
1509 Simplify now that USE_LSB_TAG is always defined.
1510 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
1511 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
1513 2012-06-13 Juanma Barranquero <lekktu@gmail.com>
1515 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
1517 2012-06-13 Glenn Morris <rgm@gnu.org>
1519 * s/bsd-common.h (BSD4_3):
1520 * s/usg5-4-common.h (USG5_4): No longer define; unused.
1522 2012-06-13 Andreas Schwab <schwab@linux-m68k.org>
1524 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
1527 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
1529 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
1530 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1531 * alloc.c (widen_to_Lisp_Object): Remove.
1532 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
1533 * frame.c (delete_frame): Remove outdated comment.
1534 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
1535 USE_LISP_UNION_TYPE.
1536 (Fw32_unregister_hot_key): Likewise.
1537 (Fw32_toggle_lock_key): Likewise.
1538 * w32menu.c (add_menu_item): Likewise.
1539 (w32_menu_display_help): Use XIL instead of checking
1540 USE_LISP_UNION_TYPE.
1541 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
1542 (init_heap): Likewise.
1543 * w32term.c (w32_read_socket): Update comment.
1545 2012-06-13 Glenn Morris <rgm@gnu.org>
1547 * s/usg5-4-common.h, src/s/unixware.h:
1548 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
1550 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
1552 2012-06-13 Paul Eggert <eggert@cs.ucla.edu>
1554 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
1555 * alloc.c (make_number) [!defined make_number]:
1556 Remove, as lisp.h always defines this now.
1557 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
1558 (roundup_size): Verify that it is a power of 2.
1559 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
1560 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
1561 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
1562 -DUSE_LSB_TAG=0, to override the automatically-selected default.
1563 USE_LSB_TAG now is always defined to be either 0 or 1.
1565 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
1566 code works fine either way, and efficiency is not a concern here,
1567 as the union type is for debugging, not for production.
1568 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
1569 Use an inline function on all platforms when using the union type,
1570 since this is simpler and 'static inline' can be used portably
1572 (LISP_INITIALLY_ZERO): New macro.
1573 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
1574 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
1576 2012-06-12 Glenn Morris <rgm@gnu.org>
1578 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
1580 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
1582 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
1583 Move BROKEN_SIGIO to configure.
1585 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
1586 Move NO_TERMIO to configure.
1588 2012-06-12 Chong Yidong <cyd@gnu.org>
1590 * image.c (imagemagick_load_image): Use MagickFlattenImage if
1591 MagickMergeImageLayers is undefined. Use pixel pusher loop if
1592 MagickExportImagePixels is undefined.
1594 2012-06-12 Paul Eggert <eggert@cs.ucla.edu>
1596 * image.c (imagemagick_load_image): Remove unused label.
1598 2012-06-11 Glenn Morris <rgm@gnu.org>
1600 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1601 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
1602 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
1603 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
1605 2012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
1607 * alloc.c (make_byte_code): New function.
1608 (Fmake_byte_code): Use it. Don't purify here.
1609 * lread.c (read1): Use it as well to avoid extra allocation.
1611 2012-06-11 Chong Yidong <cyd@gnu.org>
1613 * image.c (imagemagick_load_image): Implement transparency.
1615 2012-06-10 Andreas Schwab <schwab@linux-m68k.org>
1617 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
1618 account for preceding backslashes. (Bug#11663)
1620 2012-06-09 Chong Yidong <cyd@gnu.org>
1622 * term.c: Support italics in capable terminals (Bug#9652).
1623 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
1624 (turn_on_face): Output using TS_enter_italic_mode if available.
1625 Don't handle unused blinking and alt-charset cases.
1626 (turn_off_face): Handle italic case; discard unused tty_blinking_p
1627 and tty_alt_charset_p cases.
1628 (tty_capable_p, init_tty): Support italics.
1630 * termchar.h (struct tty_display_info): Add field for italics.
1631 Remove unused blink field.
1633 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
1636 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
1637 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
1638 tty_alt_charset_p. Add tty_italic_p.
1640 2012-06-09 Michael Albinus <michael.albinus@gmx.de>
1642 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
1643 dbus_type_is_basic if available.
1644 (xd_extract_signed, xd_extract_unsigned): Rename from
1645 extract_signed and extract_unsigned, respectively. Adapt callers.
1647 2012-06-09 Chong Yidong <cyd@gnu.org>
1649 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
1651 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
1654 2012-06-08 Paul Eggert <eggert@cs.ucla.edu>
1656 * xdisp.c (vmessage): Treat frame message as multibyte.
1657 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
1658 would generate the diagnostic "Making \302\247 buffer-local while
1661 2012-06-08 Eli Zaretskii <eliz@gnu.org>
1663 * dispnew.c (showing_window_margins_p): Undo last change, which
1664 was done due to an inadvertent commit.
1665 (adjust_frame_glyphs_for_frame_redisplay): Do call
1666 showing_window_margins_p.
1668 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1670 * eval.c (Fmake_var_non_special): New primitive.
1671 (syms_of_eval): Defsubr it.
1672 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
1674 2012-06-08 Juanma Barranquero <lekktu@gmail.com>
1676 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
1677 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
1679 2012-06-08 Eli Zaretskii <eliz@gnu.org>
1681 * alloc.c (allocate_vectorlike): Fix last change.
1683 2012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
1685 Block-based vector allocation of small vectors.
1686 * lisp.h (struct vectorlike_header): New field `nbytes',
1687 adjust comment accordingly.
1688 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
1689 to denote vector blocks. Adjust users (live_vector_p,
1690 mark_maybe_pointer, valid_lisp_object_p) accordingly.
1691 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
1692 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
1693 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
1694 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
1695 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
1696 (roundup_size): New constant.
1697 (struct vector_block): New data type.
1698 (vector_blocks, vector_free_lists, zero_vector): New variables.
1699 (all_vectors): Rename to `large_vectors'.
1700 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
1701 (sweep_vectors): New functions.
1702 (allocate_vectorlike): Return `zero_vector' as the only vector of
1703 0 items. Allocate new vector from block if vector size is less than
1704 or equal to VBLOCK_BYTES_MAX.
1705 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
1706 (init_alloc_once): Add call to init_vectors.
1708 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1710 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
1712 2012-06-07 Paul Eggert <eggert@cs.ucla.edu>
1714 * doprnt.c (doprnt): Truncate multibyte char correctly.
1715 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
1716 would mishandle a string argument "Xc" if X was a multibyte
1717 character of length 2: it would truncate after X's first byte
1718 rather than including all of X.
1720 2012-06-06 Chong Yidong <cyd@gnu.org>
1722 * buffer.c (word_wrap): Doc fix.
1724 2012-06-04 Paul Eggert <eggert@cs.ucla.edu>
1726 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
1728 2012-06-03 Glenn Morris <rgm@gnu.org>
1730 * xdisp.c (tool-bar-style): Doc fix.
1732 2012-06-03 Ulrich Müller <ulm@gentoo.org>
1734 * Makefile.in (PAXCTL): Define.
1735 (temacs$(EXEEXT)): Disable memory randomization for the temacs
1736 binary via PaX flags if the paxctl utility is available.
1737 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
1738 Restore PaX flags to their default. (Bug#11398)
1740 2012-06-03 Chong Yidong <cyd@gnu.org>
1742 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
1745 2012-06-03 Chong Yidong <cyd@gnu.org>
1747 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
1748 (note_mode_line_or_margin_highlight): If there is no help echo,
1749 use mode-line-default-help-echo. Handle the case where the mouse
1750 position is past the end of the mode line string.
1752 * buffer.c (buffer_local_value_1): New function, split from
1753 Fbuffer_local_value; can return Qunbound.
1754 (Fbuffer_local_value): Use it.
1755 (Vmode_line_format): Docstring tweaks.
1757 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1759 * sysdep.c (system_process_attributes): Improve comment.
1761 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
1763 * keyboard.c: Export real-this-command to Elisp.
1764 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
1765 and DEFVAR it. Update all users.
1767 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1769 * minibuf.c (Fassoc_string): Remove duplicate declaration.
1771 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
1772 Convert pctcpu and pctmem to Lisp float properly.
1773 Let the compiler fold better, as 100.0/0x8000 is exact.
1775 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
1777 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
1780 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
1782 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
1784 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
1786 For a 'struct window', replace some Lisp_Object fields to
1787 bitfields where appropriate, remove unused fields.
1788 * window.h (struct window): Remove unused 'last_mark_x' and
1789 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
1790 change it's type from Lisp_Object to bitfield.
1791 Change type of 'force_start', 'optional_new_start',
1792 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
1793 fields from Lisp_Object to bitfield. Adjust users accordingly.
1795 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1797 Pacify gcc -Wdouble-precision when using Xaw.
1798 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
1799 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
1800 Use 'float' consistently, rather than 'float' in most places
1801 and 'double' in a couple of places.
1803 2012-05-31 Eli Zaretskii <eliz@gnu.org>
1805 * xdisp.c (handle_stop): Detect whether we have overlay strings
1806 loaded by testing it->current.overlay_string_index to be
1807 non-negative, instead of checking whether n_overlay_strings is
1808 positive. (Bug#11587)
1810 2012-05-31 Chong Yidong <cyd@gnu.org>
1812 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
1814 * doc.c (Fsubstitute_command_keys): Doc fix.
1816 2012-05-31 Eli Zaretskii <eliz@gnu.org>
1818 * search.c (search_buffer): Remove calls to
1819 r_alloc_inhibit_buffer_relocation, as it is now called by
1820 maybe_unify_char, which was the cause of relocation of buffer text
1823 2012-05-31 Eli Zaretskii <eliz@gnu.org>
1825 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
1826 for the duration of call to load_charset, to avoid problems with
1827 callers of maybe_unify_char that access buffer text through C
1830 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
1831 decrement the inhibition flag, instead of just setting or
1834 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1836 Remove obsolete '#define static' cruft.
1837 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
1838 This #undef was "temporary" in 2000; it is no longer needed
1839 now that '#define static' has gone away.
1840 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
1841 (gray_bitmap_bits): Remove; no longer needed.
1842 All uses replaced with definiens.
1843 * xterm.c: Include "bitmaps/gray.xbm".
1845 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1847 Clean up __executable_start, monstartup when --enable-profiling.
1848 The following changes affect the code only when profiling.
1849 * dispnew.c (__executable_start): Rename from safe_bcopy.
1850 Define only on platforms that need it.
1851 * emacs.c: Include <sys/gmon.h> when profiling.
1852 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
1853 (__executable_start): Remove decl, since lisp.h does it now.
1854 (safe_bcopy): Remove decl; no longer has that name.
1855 (main): Coalesce #if into single bit of code, for simplicity.
1856 Cast pointers to uintptr_t, since standard libraries want integers
1858 * lisp.h (__executable_start): New decl.
1860 2012-05-31 Glenn Morris <rgm@gnu.org>
1862 * image.c (Fimagemagick_types): Doc fix.
1864 2012-05-30 Jim Meyering <meyering@redhat.com>
1866 * callproc.c (Fcall_process_region): Include directory component
1867 in mkstemp error message (Bug#11586).
1869 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1871 * alloc.c, lisp.h (make_pure_vector): Now static.
1873 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
1875 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
1876 Move to byte-run.el.
1877 (Fautoload): Do the hash-doc more carefully.
1878 * data.c (Fdefalias): Purify definition, except for keymaps.
1879 (Qdefun): Move from eval.c.
1880 * lisp.h (Qdefun): Remove.
1881 * lread.c (read1): Tiny simplification.
1883 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
1885 Do not create empty overlays with the evaporate property (Bug#9642).
1886 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
1887 Bug#9642, but explicitly check that the buffer the overlay would
1888 be moved to is live and rearrange lines to make sure that errors
1889 will not put the overlay in an inconsistent state.
1890 (Fdelete_overlay): Cosmetics.
1892 2012-05-28 Eli Zaretskii <eliz@gnu.org>
1894 * w32term.c (my_bring_window_to_top): New function.
1895 (x_raise_frame): Use handle returned by DeferWindowPos, which
1896 could be different from the original one.
1897 Call my_bring_window_to_top instead of my_set_foreground_window.
1900 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
1901 by calling BringWindowToTop.
1903 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
1904 (WM_EMACS_END): Increase by one.
1906 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
1908 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
1909 This avoids undefined behavior that might cause the eassert
1910 to not catch an out-of-range value.
1912 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
1914 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
1915 Update dependencies.
1917 2012-05-27 Eli Zaretskii <eliz@gnu.org>
1919 * bidi.c (bidi_mirror_char): Fix last change.
1921 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
1923 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
1924 when referring to sectname field in printf format.
1926 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
1928 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
1929 Only r_alloc_inhibit_buffer_relocation needed to be added;
1930 the others were already declared.
1932 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
1933 before checking whether it's out of range. Put the check inside
1935 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
1937 2012-05-27 Ken Brown <kbrown@cornell.edu>
1939 * callproc.c (Fcall_process): Restore a line that was accidentally
1940 commented out in the 2011-02-13 change (bug#11547).
1942 2012-05-27 Eli Zaretskii <eliz@gnu.org>
1944 * lisp.h [REL_ALLOC]: Add prototypes for external functions
1945 defined on ralloc.c.
1947 * buffer.c [REL_ALLOC]: Remove prototypes of
1948 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
1949 they are now on lisp.h.
1951 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
1953 * search.c (search_buffer): Use it to inhibit relocation of buffer
1954 text while re_search_2 is doing its job, because re_search_2 is
1955 passed C pointers to buffer text. (Bug#11519)
1957 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
1960 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
1961 state after an additional call to move_it_in_display_line_to, keep
1962 the values of it->max_ascent and it->max_descent found for the
1964 (pos_visible_p): Revert the comparison against bottom_y to what it
1965 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
1968 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1970 Fix coding-related core dumps with gcc -ftrapv.
1971 The code was computing A - B, where A and B are pointers, and B is
1972 random garbage. This can lead to core dumps on platforms that
1973 have special pointer registers, and it also leads to core dumps on
1974 x86-64 when compiled with gcc -ftrapv. The fix is to compute
1975 A - B only when B is initialized properly.
1976 * coding.c (coding_set_source, coding_set_destination): Return void.
1977 (coding_change_source, coding_change_destinations): New functions,
1978 with the old behaviors of coding_set_source and coding_set_destination.
1979 All callers that need an offset changed to use these new functions.
1981 2012-05-26 Glenn Morris <rgm@gnu.org>
1983 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
1985 2012-05-26 Eli Zaretskii <eliz@gnu.org>
1987 Extend mouse support on W32 text-mode console.
1988 * xdisp.c (draw_row_with_mouse_face):
1989 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
1991 * w32console.c: Include window.h.
1992 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
1994 (initialize_w32_display): Initialize mouse-highlight data.
1996 * w32inevt.c: Include termchar.h and window.h.
1997 (do_mouse_event): Support mouse-autoselect-window. When the mouse
1998 moves, call note_mouse_highlight. If help_echo changed, call
1999 gen_help_event to produce help-echo message in the echo area.
2000 Call clear_mouse_face if mouse_face_hidden is set in the mouse
2003 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2005 * lread.c (read1): Simplify slightly to avoid an overflow warning
2006 with GCC 4.7.0 on x86-64.
2008 2012-05-26 Eli Zaretskii <eliz@gnu.org>
2010 * bidi.c (bidi_mirror_char): Revert last change: an int is
2011 definitely wide enough here.
2013 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
2015 Fix integer width and related bugs (Bug#9874).
2016 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
2017 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
2018 (string_bytes, check_sblock, allocate_string_data):
2019 (compact_small_strings, Fmake_bool_vector, make_string)
2020 (make_unibyte_string, make_multibyte_string)
2021 (make_string_from_bytes, make_specified_string)
2022 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
2023 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
2025 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2026 (allocate_pseudovector):
2027 Use int, not EMACS_INT, where int is wide enough.
2028 (inhibit_garbage_collection, Fgarbage_collect):
2029 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2030 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
2031 int might not be wide enough.
2032 (bidi_cache_search, bidi_cache_find, bidi_init_it)
2033 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
2034 (bidi_at_paragraph_end, bidi_find_paragraph_start)
2035 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2036 (bidi_level_of_next_char, bidi_move_to_visually_next):
2037 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2038 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
2039 (Fkill_buffer, Fset_buffer_major_mode)
2040 (advance_to_char_boundary, Fbuffer_swap_text)
2041 (Fset_buffer_multibyte, overlays_at, overlays_in)
2042 (overlay_touches_p, struct sortvec, record_overlay_string)
2043 (overlay_strings, recenter_overlay_lists)
2044 (adjust_overlays_for_insert, adjust_overlays_for_delete)
2045 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
2046 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
2047 (Foverlay_recenter, last_overlay_modification_hooks_used)
2048 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
2049 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2050 (validate_region): Omit unnecessary test for b <= e,
2051 since that's guaranteed by the previous test.
2052 (adjust_overlays_for_delete): Avoid pos + length overflow.
2053 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
2054 (report_overlay_modification):
2055 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2056 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
2057 Omit pointer cast, which isn't needed anyway, and doesn't work
2058 after the EMACS_INT -> ptrdiff_t change.
2059 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
2060 * buffer.h: Adjust decls to match defn changes elsewhere.
2061 (struct buffer_text, struct buffer):
2062 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2063 Use EMACS_INT, not int, where int might not be wide enough.
2064 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
2065 not int, to avoid needless 32-bit limit on 64-bit hosts.
2066 (exec_byte_code): Use tighter memory-full test, one that checks
2067 for alloca overflow. Don't compute the address of the object just
2068 before an array, as that's not portable. Use EMACS_INT, not
2069 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
2070 * callint.c (Fcall_interactively):
2071 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2072 * callproc.c (call_process_kill, Fcall_process):
2073 Don't assume pid_t fits into an Emacs fixnum.
2074 (call_process_cleanup, Fcall_process, child_setup):
2075 Don't assume pid_t fits into int.
2076 (call_process_cleanup, Fcall_process, delete_temp_file)
2077 (Fcall_process_region):
2078 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2079 (Fcall_process): Simplify handling of volatile integers.
2080 Use int, not EMACS_INT, where int will do.
2081 * casefiddle.c (casify_object, casify_region, operate_on_word)
2082 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
2083 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2084 (casify_object): Avoid integer overflow when overallocating buffer.
2085 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
2086 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
2087 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
2088 * category.h (CATEGORYP): Don't assume arg is nonnegative.
2089 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
2090 integers are now checked earlier. All uses replaced with XINT.
2092 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2093 For CCL_MapSingle, check that content and value are in int range.
2094 (ccl_driver, Fregister_code_conversion_map):
2095 Check that Vcode_version_map_vector is a vector.
2096 (resolve_symbol_ccl_program): Check that vector header is in range.
2097 Always copy the vector, so that we can check its contents reliably
2098 now rather than having to recheck each instruction as it's being
2099 executed. Check that vector words fit in 'int'.
2100 (ccl_get_compiled_code, Fregister_ccl_program)
2101 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
2102 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
2103 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
2104 contents are in range.
2105 (Fccl_execute_on_string): Check that status is in range.
2106 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
2107 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
2108 Accept and return EMACS_INT, not int, because callers can pass values
2110 (c_string_width, strwidth, lisp_string_width, chars_in_text)
2111 (multibyte_chars_in_text, parse_str_as_multibyte)
2112 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
2113 (str_as_unibyte, str_to_unibyte, string_count_byte8)
2114 (string_escape_byte8, Fget_byte):
2115 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2116 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
2117 avoid mishandling large integers.
2118 * character.h: Adjust decls to match defn changes elsewhere.
2119 * charset.c (load_charset_map_from_file, find_charsets_in_text)
2120 (Ffind_charset_region):
2121 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2122 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
2123 (load_charset_map_from_vector, Fdefine_charset_internal):
2124 Don't assume fixnum fits in int.
2125 (load_charset_map_from_vector, Fmap_charset_chars):
2126 Remove now-unnecessary CHECK_NATNUMs.
2127 (Fdefine_charset_internal): Check ranges here, more carefully.
2128 Don't rely on undefined behavior with signed left shift overflow.
2129 Don't assume unsigned int fits into fixnum, or that fixnum fits
2130 into unsigned int. Don't require max_code to be a valid fixnum;
2131 that's not true for gb10830 4-byte on a 32-bit host. Allow
2132 invalid_code to be a cons, for the same reason. Require code_offset
2133 to be a character. Avoid int overflow if max_char is close
2135 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
2136 this is intended anyway and avoids some undefined behavior.
2137 (load_charset_map): Pass unsigned, not int, as 2nd arg of
2138 INDEX_TO_CODE_POINT, as that's what it expects.
2139 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
2140 * charset.h (DECODE_CHAR): Return int, not unsigned;
2141 this is what was intended anyway, and it avoids undefined behavior.
2142 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
2143 integer-overflow issues.
2144 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
2145 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
2146 where the argument is EMACS_INT, and this behavior is not intended.
2147 * chartab.c (Fmake_char_table, Fset_char_table_range)
2148 (uniprop_get_decoder, uniprop_get_encoder):
2149 Don't assume fixnum fits in int.
2150 * cmds.c (move_point): New function, that does the gist of
2151 Fforward_char and Fbackward_char, but does so while checking
2152 for integer overflow more accurately.
2153 (Fforward_char, Fbackward_char): Use it.
2154 (Fforward_line, Fend_of_line, internal_self_insert)
2155 (internal_self_insert):
2156 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2157 Fix a FIXME, by checking for integer overflow when calculating
2158 target_clm and actual_clm.
2159 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
2160 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
2161 (ASSURE_DESTINATION, coding_alloc_by_realloc)
2162 (coding_alloc_by_making_gap, alloc_destination)
2163 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
2164 (encode_coding_utf_16, detect_coding_emacs_mule)
2165 (decode_coding_emacs_mule, encode_coding_emacs_mule)
2166 (detect_coding_iso_2022, decode_coding_iso_2022)
2167 (encode_invocation_designation, encode_designation_at_bol)
2168 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2169 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
2170 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
2171 (encode_coding_ccl, encode_coding_raw_text)
2172 (detect_coding_charset, decode_coding_charset)
2173 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
2174 (produce_composition, produce_charset, produce_annotation)
2175 (decode_coding, handle_composition_annotation)
2176 (handle_charset_annotation, consume_chars, decode_coding_gap)
2177 (decode_coding_object, encode_coding_object, detect_coding_system)
2178 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
2179 (code_convert_region, code_convert_string)
2180 (Fdefine_coding_system_internal)
2181 (coding_set_source, coding_set_destination):
2182 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2183 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
2184 (Fdefine_coding_system_internal):
2185 Don't assume fixnums fit in int.
2186 (decode_coding_gap, decode_coding_object, encode_coding_object)
2187 (Fread_coding_system, Fdetect_coding_region)
2188 (Funencodable_char_position, Fcheck_coding_systems_region)
2189 (get_translation, handle_composition_annotation, consume_chars):
2190 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2191 (consume_chars): Rewrite to not calculate an address outside buffer.
2192 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
2193 Don't access memory outside of the args array.
2194 (Fdefine_coding_system_internal): Check for charset-id overflow.
2195 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
2196 result of ENCODE_CHAR.
2197 * coding.h: Adjust decls to match defn changes elsewhere.
2198 (struct coding_system):
2199 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2200 * composite.c (get_composition_id, find_composition)
2201 (run_composition_function, update_compositions)
2202 (compose_text, composition_gstring_put_cache)
2203 (composition_gstring_p, composition_gstring_width)
2204 (fill_gstring_header, fill_gstring_body, autocmp_chars)
2205 (composition_compute_stop_pos, composition_reseat_it)
2206 (composition_update_it, struct position_record)
2207 (find_automatic_composition, composition_adjust_point)
2208 (Fcomposition_get_gstring, Ffind_composition_internal):
2209 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2210 (update_compositions):
2211 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2212 * composite.h: Adjust decls to match defn changes elsewhere.
2213 (struct composition):
2214 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2215 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
2216 Do not attempt to compute the address of the object just before a
2217 buffer; this is not portable.
2219 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2220 (Faset): Use int, not EMACS_INT, where int is wide enough.
2221 (Fstring_to_number): Don't assume fixnums fit in int.
2222 (Frem): Don't assume arg is nonnegative.
2223 * dbusbind.c (xd_append_arg): Check for integers out of range.
2224 (Fdbus_call_method): Don't overflow the timeout int.
2225 (extract_signed, extract_unsigned): New functions.
2226 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
2227 (xd_get_connection_references): Return ptrdiff_t, not int.
2229 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
2230 (xd_read_message_1):
2231 Use int, not unsigned, where the dbus API uses int.
2232 (Fdbus_message_internal): Don't overflow mtype.
2233 (syms_of_dbusbind): Allocate right-sized buffer for integers.
2234 * dired.c (directory_files_internal, file_name_completion, scmp)
2235 (file_name_completion_stat):
2236 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2237 (file_name_completion): Don't overflow matchcount.
2238 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
2239 * dispextern.h: Adjust decls to match defn changes elsewhere.
2240 (struct text_pos, struct glyph, struct bidi_saved_info)
2241 (struct bidi_string_data, struct bidi_it, struct composition_it)
2243 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2244 (struct display_pos, struct composition_it, struct it):
2245 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2246 * dispnew.c (increment_matrix_positions)
2247 (increment_row_positions, mode_line_string)
2248 (marginal_area_string):
2249 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2250 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
2251 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2252 (duration_to_sec_usec): New function, to check for overflow better.
2253 (Fsleep_for, sit_for): Use it.
2254 * doc.c (get_doc_string, store_function_docstring):
2255 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2256 (get_doc_string, Fsnarf_documentation):
2257 Use int, not EMACS_INT, where int is wide enough.
2259 Use SAFE_ALLOCA, not alloca.
2260 Check for overflow when converting EMACS_INT to off_t.
2261 * doprnt.c (doprnt):
2262 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2263 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
2264 Don't assume uid_t fits into fixnum.
2265 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
2266 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
2267 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
2268 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
2269 (general_insert_function)
2270 (Finsert_char, make_buffer_string, make_buffer_string_both)
2271 (update_buffer_properties, Fbuffer_substring)
2272 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
2273 (Fsubst_char_in_region, check_translation)
2274 (Ftranslate_region_internal, save_restriction_restore, Fformat)
2275 (transpose_markers, Ftranspose_regions):
2276 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2277 (clip_to_bounds): Move to lisp.h as an inline function).
2278 (Fconstrain_to_field): Don't assume integers are nonnegative.
2279 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
2280 (Fsubst_char_in_region, Fsave_restriction):
2281 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2282 (Femacs_pid): Don't assume pid_t fits into fixnum.
2283 (lo_time): Use int, not EMACS_INT, when int suffices.
2284 (lisp_time_argument): Check for usec out of range.
2285 (Fencode_time): Don't assume fixnum fits in int.
2286 (Fuser_login_name, Fuser_full_name): Signal an error
2287 if a uid argument is out of range, rather than relying on
2289 (Fformat_time_string): Remove now-unnecessary check.
2290 lisp_time_argument checks for out-of-range usec now.
2291 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
2292 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
2293 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
2294 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
2295 (init_cmdargs, Fdump_emacs):
2296 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2297 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
2298 the bottom (typically) 32 bits of the fixnum.
2299 * eval.c (specpdl_size, call_debugger):
2300 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2301 (when_entered_debugger, Fbacktrace_debug):
2302 Don't assume fixnum can fit in int.
2303 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
2304 the object just before a buffer; this is not portable.
2305 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
2306 (grow_specpdl, unbind_to):
2307 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2308 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
2309 (grow_specpdl): Simplify allocation by using xpalloc.
2310 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
2311 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
2312 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
2313 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2314 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
2316 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2317 (Fcopy_file, non_regular_nbytes, read_non_regular)
2318 (Finsert_file_contents):
2319 Use int, not EMACS_INT, where int is wide enough.
2320 (READ_BUF_SIZE): Verify that it fits in int.
2321 (Finsert_file_contents): Check that counts are in proper range,
2322 rather than assuming fixnums fit into ptrdiff_t etc.
2323 Don't assume fixnums fit into int.
2324 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
2325 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
2326 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
2327 (string_char_to_byte, string_byte_to_char)
2328 (string_make_multibyte, string_to_multibyte)
2329 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
2330 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
2331 (substring_both, Fdelete, internal_equal, Ffillarray)
2332 (Fclear_string, mapcar1)
2333 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
2334 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
2335 (larger_vector, make_hash_table, maybe_resize_hash_table)
2336 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
2337 (Fmaphash, secure_hash):
2338 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2339 (concat): Check for string index and length overflow.
2340 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
2342 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2343 (larger_vector): New API (vec, incr_min, size_max) replaces old
2344 one (vec, new_size, init). This catches size overflow.
2345 INIT was removed because it was always Qnil.
2346 All callers changed.
2347 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
2348 the upper bound on a hash table index size.
2349 (make_hash_table, maybe_resize_hash_table): Use it.
2350 (secure_hash): Computer start_byte and end_byte only after
2351 they're known to be in ptrdiff_t range.
2352 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
2353 (Ffont_get_glyphs, Ffont_at):
2354 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2355 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
2356 (Flist_fonts, Fopen_font):
2357 Don't assume fixnum can fit in int.
2358 (check_gstring): Don't assume index can fit in int.
2359 (font_match_p): Check that fixnum is a character, not a nonnegative
2360 fixnum, since the later code needs to stuff it into an int.
2361 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
2362 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
2363 conversion overflow issues.
2364 (Fopen_font): Check for integer out of range.
2365 (Ffont_get_glyphs): Don't assume index can fit in int.
2366 * font.h: Adjust decls to match defn changes elsewhere.
2367 * fontset.c (reorder_font_vector): Redo score calculation to avoid
2369 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
2370 printmax_t, where ptrdiff_t is wide enough.
2371 (Finternal_char_font):
2372 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2373 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
2374 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
2375 (Fset_frame_position, x_set_frame_parameters)
2376 (x_set_line_spacing, x_set_border_width)
2377 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
2378 Check that fixnums are in proper range for system types.
2379 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
2380 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2381 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
2382 Use SAFE_ALLOCA_LISP, not alloca.
2383 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
2384 intptr_t is wide enough.
2385 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
2386 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
2387 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
2388 Check for fixnum out of range.
2389 * ftfont.c (ftfont_list): Don't assume index fits in int.
2390 Check that fixnums are in proper range for system types.
2391 (ftfont_shape_by_flt):
2392 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2393 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2394 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2395 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
2396 Check that fixnums are in proper range for system types.
2397 * gnutls.h: Adjust decls to match defn changes elsewhere.
2398 * gtkutil.c (xg_dialog_run):
2399 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2400 (update_frame_tool_bar):
2401 Check that fixnums are in proper range for system types.
2402 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
2403 (lookup_image): Check that fixnums are in range for system types.
2404 * indent.c (last_known_column, last_known_column_point):
2405 (current_column_bol_cache):
2406 (skip_invisible, current_column, check_display_width):
2407 (check_display_width, scan_for_column, current_column_1)
2408 (Findent_to, Fcurrent_indentation, position_indentation)
2409 (indented_beyond_p, Fmove_to_column, compute_motion):
2410 (Fcompute_motion, Fvertical_motion):
2411 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2412 (last_known_column_modified): Use EMACS_INT, not int.
2413 (check_display_width):
2415 Check that fixnums and floats are in proper range for system types.
2416 (compute_motion): Don't assume index or fixnum fits in int.
2417 (compute_motion, Fcompute_motion):
2418 Use int, not EMACS_INT, when it is wide enough.
2419 (vmotion): Omit local var start_hpos that is always 0; that way
2420 we don't need to worry about overflow in expressions involving it.
2421 * indent.h: Adjust decls to match defn changes elsewhere.
2423 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2424 Use int, not EMACS_INT, where int is wide enough.
2425 Remove unused members ovstring_chars_done and tab_offset;
2427 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
2428 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
2429 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
2430 (make_gap, copy_text, insert, insert_and_inherit)
2431 (insert_before_markers, insert_before_markers_and_inherit)
2432 (insert_1, count_combining_before, count_combining_after)
2433 (insert_1_both, insert_from_string)
2434 (insert_from_string_before_markers, insert_from_string_1)
2435 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
2436 (adjust_after_replace, adjust_after_insert, replace_range)
2437 (replace_range_2, del_range, del_range_1, del_range_byte)
2438 (del_range_both, del_range_2, modify_region)
2439 (prepare_to_modify_buffer, signal_before_change)
2440 (signal_after_change, Fcombine_after_change_execute):
2441 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2442 * intervals.c (traverse_intervals, rotate_right, rotate_left)
2443 (balance_an_interval, split_interval_right, split_interval_left)
2444 (find_interval, next_interval, update_interval)
2445 (adjust_intervals_for_insertion, delete_node, delete_interval)
2446 (interval_deletion_adjustment, adjust_intervals_for_deletion)
2447 (static_offset_intervals, offset_intervals)
2448 (merge_interval_right, merge_interval_left, make_new_interval)
2449 (graft_intervals_into_buffer, temp_set_point_both)
2450 (temp_set_point, set_point, adjust_for_invis_intang)
2451 (set_point_both, move_if_not_intangible, get_property_and_range)
2452 (get_local_map, copy_intervals, copy_intervals_to_string)
2453 (compare_string_intervals, set_intervals_multibyte_1):
2454 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2455 * intervals.h: Adjust decls to match defn changes elsewhere.
2457 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2458 * keyboard.c (this_command_key_count, this_single_command_key_start)
2459 (before_command_key_count, before_command_echo_length, echo_now)
2460 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
2461 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
2462 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
2463 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
2464 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2465 (last_non_minibuf_size, last_point_position, echo_truncate)
2466 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
2467 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
2468 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
2469 (stuff_buffered_input):
2470 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2471 (last_auto_save, command_loop_1, read_char):
2472 Use EMACS_INT, not int, to avoid integer overflow.
2473 (record_char): Avoid overflow in total_keys computation.
2474 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
2475 * keyboard.h: Adjust decls to match defn changes elsewhere.
2476 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
2477 (Fkey_description, Fdescribe_vector, Flookup_key):
2478 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2479 (click_position): New function, to check that positions are in range.
2480 (Fcurrent_active_maps):
2482 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2483 (Faccessible_keymaps, Fkey_description):
2484 (preferred_sequence_p):
2485 Don't assume fixnum can fit into int.
2486 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
2487 Check for integer overflow in size calculations.
2488 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
2489 avoid mishandling large integers.
2490 * lisp.h: Adjust decls to match defn changes elsewhere.
2491 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
2492 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
2493 (struct Lisp_Marker):
2494 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2495 (clip_to_bounds): Now an inline function, moved here from editfns.c.
2496 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
2497 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
2498 All callers changed.
2499 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
2500 Assume the arg has valid form, since it always does.
2501 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
2502 unsigned integer system type.
2503 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
2504 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
2505 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2506 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
2507 (duration_to_sec_usec): New decl.
2508 * lread.c (read_from_string_index, read_from_string_index_byte)
2509 (read_from_string_limit, readchar, unreadchar, openp)
2510 (read_internal_start, read1, oblookup):
2511 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2512 (Fload, readevalloop, Feval_buffer, Feval_region):
2513 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2514 (openp): Check for out-of-range argument to 'access'.
2515 (read1): Use int, not EMACS_INT, where int is wide enough.
2516 Don't assume fixnum fits into int.
2517 Fix off-by-one error that can read outside a buffer.
2518 (read_filtered_event): Use duration_to_sec_usec
2519 to do proper overflow checking on durations.
2520 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
2521 in size calculation.
2522 (Fexecute_kbd_macro):
2523 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2524 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
2525 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
2526 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
2527 (set_marker_both, set_marker_restricted_both, marker_position)
2528 (marker_byte_position, Fbuffer_has_markers_at):
2529 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2530 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
2531 * menu.c (ensure_menu_items): Rename from grow_menu_items.
2532 It now merely ensures that the menu is large enough, without
2533 necessarily growing it, as this avoids some integer overflow issues.
2534 All callers changed.
2535 (keymap_panes, parse_single_submenu, Fx_popup_menu):
2536 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2537 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
2538 Use SAFE_ALLOCA_LISP, not alloca.
2539 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
2540 to EMACS_INT. Check that fixnums are in proper range for system types.
2541 * minibuf.c (minibuf_prompt_width, string_to_object)
2542 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
2543 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
2544 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2545 (get_minibuffer, read_minibuf_unwind):
2546 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2547 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
2548 this simplifies overflow checking. All callers changed.
2549 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
2551 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2552 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
2553 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
2554 Check that fixnums are in proper range for system types.
2555 (Fx_create_frame, Fx_show_tip):
2556 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2557 * nsfont.m (ns_findfonts, nsfont_list_family):
2558 Don't assume fixnum fits in long.
2559 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
2560 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2561 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
2563 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
2564 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2565 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
2566 (PRINTDECLARE, PRINTPREPARE):
2567 (strout, print_string):
2568 (print, print_preprocess, print_check_string_charset_prop)
2570 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2572 (temp_output_buffer_setup, Fprin1_to_string, print_object):
2573 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2574 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
2575 (printchar, strout): Use xpalloc to catch size calculation overflow.
2576 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
2577 (print_error_message): Use SAFE_ALLOCA, not alloca.
2578 (print_object): Use int, not EMACS_INT, where int is wide enough.
2579 (print_depth, new_backquote_output, print_number_index):
2580 Use ptrdiff_t, not int, where int might not be wide enough.
2581 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
2582 (Fset_process_window_size, Fformat_network_address)
2583 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
2585 Check that fixnums are in proper range for system types.
2586 (Fsignal_process): Simplify by avoiding a goto.
2587 Check for process-ids out of pid_t range rather than relying on
2589 (process_tick, update_tick): Use EMACS_INT, not int.
2590 (Fformat_network_address, read_process_output, send_process)
2591 (Fprocess_send_region, status_notify):
2592 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2593 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
2594 (wait_reading_process_output, read_process_output, exec_sentinel):
2595 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2596 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
2597 (Faccept_process_output): Use duration_to_sec_usec to do proper
2598 overflow checking on durations.
2599 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
2600 Don't assume pid_t fits in int.
2601 * process.h (struct Lisp_Process): Members tick and update_tick
2602 are now of type EMACS_INT, not int.
2603 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
2604 configured --with-wide-int.
2605 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
2606 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
2607 * search.c (looking_at_1, string_match_1):
2608 (fast_string_match, fast_c_string_match_ignore_case)
2609 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
2610 (scan_newline, find_before_next_newline, search_command)
2611 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
2612 (set_search_regs, wordify):
2615 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2616 (string_match_1, search_buffer, set_search_regs):
2618 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2619 (wordify): Check for overflow in size calculation.
2620 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
2621 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
2622 Check that fixnums are in proper range for system types.
2623 * sound.c (struct sound_device)
2624 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
2625 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2626 (Fplay_sound_internal):
2627 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2628 * syntax.c (struct lisp_parse_state, find_start_modiff)
2629 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
2630 (Fparse_partial_sexp):
2631 Don't assume fixnums can fit in int.
2632 (struct lisp_parse_state, find_start_pos, find_start_value)
2633 (find_start_value_byte, find_start_begv)
2634 (update_syntax_table, char_quoted, dec_bytepos)
2635 (find_defun_start, prev_char_comend_first, back_comment):
2636 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
2637 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
2638 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2639 (Finternal_describe_syntax_value): Check that match_lisp is a
2640 character, not an integer, since the code stuffs it into int.
2641 (scan_words, scan_sexps_forward):
2642 Check that fixnums are in proper range for system types.
2644 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2645 (scan_sexps_forward):
2646 Use CHARACTERP, not INTEGERP, since the value must fit into int.
2647 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
2648 * syntax.h: Adjust decls to match defn changes elsewhere.
2649 (struct gl_state_s):
2650 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2651 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
2652 MOST_POSITIVE_FIXNUM.
2653 * sysdep.c (wait_for_termination_1, wait_for_termination)
2654 (interruptible_wait_for_termination, mkdir):
2655 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
2656 (emacs_read, emacs_write):
2657 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2658 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
2659 and double all fit in int.
2660 * term.c (set_tty_color_mode):
2661 Check that fixnums are in proper range for system types.
2662 * termhooks.h (struct input_event):
2663 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2664 * textprop.c (validate_interval_range, interval_of)
2665 (Fadd_text_properties, set_text_properties_1)
2666 (Fremove_text_properties, Fremove_list_of_text_properties)
2667 (Ftext_property_any, Ftext_property_not_all)
2668 (copy_text_properties, text_property_list, extend_property_ranges)
2669 (verify_interval_modification):
2670 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2671 (Fnext_single_char_property_change)
2672 (Fprevious_single_char_property_change):
2673 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2674 (copy_text_properties):
2675 Check for integer overflow in index calculation.
2676 * undo.c (last_boundary_position, record_point, record_insert)
2677 (record_delete, record_marker_adjustment, record_change)
2678 (record_property_change):
2679 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2680 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
2681 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2682 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2683 (Fx_hide_tip, Fx_file_dialog):
2684 * w32menu.c (set_frame_menubar):
2685 Use ptrdiff_t, not int, for consistency with rest of code.
2686 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
2687 (select_window, Fdelete_other_windows_internal)
2688 (window_scroll_pixel_based, window_scroll_line_based)
2689 (Frecenter, Fset_window_configuration):
2690 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2691 (Fset_window_hscroll, run_window_configuration_change_hook)
2692 (set_window_buffer, temp_output_buffer_show, scroll_command)
2693 (Fscroll_other_window, Frecenter):
2694 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2695 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
2696 Don't assume fixnum fits in int.
2697 (Fset_window_scroll_bars):
2698 Check that fixnums are in proper range for system types.
2699 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
2700 (string_pos, c_string_pos, number_of_chars, init_iterator)
2701 (in_ellipses_for_invisible_text_p, init_from_display_pos)
2702 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
2703 (compute_display_string_end, handle_face_prop)
2704 (face_before_or_after_it_pos, handle_invisible_prop)
2705 (handle_display_prop, handle_display_spec, handle_single_display_spec)
2706 (display_prop_intangible_p, string_buffer_position_lim)
2707 (string_buffer_position, handle_composition_prop, load_overlay_strings)
2708 (get_overlay_strings_1, get_overlay_strings)
2709 (iterate_out_of_display_property, forward_to_next_line_start)
2710 (back_to_previous_visible_line_start, reseat, reseat_to_string)
2711 (get_next_display_element, set_iterator_to_next)
2712 (get_visually_first_element, compute_stop_pos_backwards)
2713 (handle_stop_backwards, next_element_from_buffer)
2714 (move_it_in_display_line_to, move_it_in_display_line)
2715 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2716 (add_to_log, message_dolog, message_log_check_duplicate)
2717 (message2, message2_nolog, message3, message3_nolog
2718 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
2719 (current_message_1, truncate_echo_area, truncate_message_1)
2720 (set_message, set_message_1, store_mode_line_noprop)
2721 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
2722 (text_outside_line_unchanged_p, check_point_in_composition)
2723 (reconsider_clip_changes)
2724 (redisplay_internal, set_cursor_from_row, try_scrolling)
2725 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
2726 (redisplay_window, find_last_unchanged_at_beg_row)
2727 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
2728 (trailing_whitespace_p, find_row_edges, display_line)
2729 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
2730 (display_mode_element, store_mode_line_string)
2731 (pint2str, pint2hrstr, decode_mode_spec)
2732 (display_count_lines, display_string, draw_glyphs)
2733 (x_produce_glyphs, x_insert_glyphs)
2734 (rows_from_pos_range, mouse_face_from_buffer_pos)
2735 (fast_find_string_pos, mouse_face_from_string_pos)
2736 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2737 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2738 (safe_call, init_from_display_pos, handle_fontified_prop)
2739 (handle_single_display_spec, load_overlay_strings)
2740 (with_echo_area_buffer, setup_echo_area_for_printing)
2741 (display_echo_area, echo_area_display)
2742 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
2743 (update_tool_bar, hscroll_window_tree, redisplay_internal)
2744 (redisplay_window, dump_glyph_row, display_mode_line)
2745 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
2746 (handle_display_spec, display_prop_string_p):
2747 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2748 (handle_single_display_spec, build_desired_tool_bar_string)
2749 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
2750 (get_specified_cursor_type):
2751 Check that fixnums are in proper range for system types.
2752 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
2753 (Flookup_image_map):
2754 Don't assume fixnums fit in int.
2755 (compare_overlay_entries):
2756 Avoid mishandling comparisons due to subtraction overflow.
2757 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
2758 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
2759 (handle_tool_bar_click):
2760 Use int, not unsigned, since we prefer signed and the signedness
2761 doesn't matter here.
2762 (get_next_display_element, next_element_from_display_vector):
2763 Use int, not EMACS_INT, when int is wide enough.
2764 (start_hourglass): Use duration_to_sec_usec to do proper
2765 overflow checking on durations.
2766 * xfaces.c (Fbitmap_spec_p):
2767 Check that fixnums are in proper range for system types.
2768 (compare_fonts_by_sort_order):
2769 Avoid mishandling comparisons due to subtraction overflow.
2770 (Fx_family_fonts, realize_basic_faces):
2771 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2773 Don't assume fixnum fits in int.
2774 Use SAFE_ALLOCA_LISP, not alloca.
2775 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
2776 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
2777 (face_at_buffer_position, face_for_overlay_string)
2778 (face_at_string_position):
2779 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2780 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
2781 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
2783 Check that fixnums are in proper range for system types.
2784 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2785 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
2786 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2787 (Fx_change_window_property): Don't assume fixnums fit in int.
2788 * xfont.c (xfont_chars_supported):
2789 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2790 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
2791 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
2792 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2793 * xml.c (parse_region):
2794 * xrdb.c (magic_file_p):
2795 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2796 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
2797 (x_get_local_selection, x_reply_selection_request)
2798 (x_handle_selection_request, wait_for_property_change):
2799 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2800 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
2801 short is wide enough.
2802 (x_send_client_event): Don't assume fixnum fits in int.
2803 * xterm.c (x_x_to_emacs_modifiers):
2804 Don't assume EMACS_INT overflows nicely into int.
2805 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
2807 (handle_one_xevent): NATNUMP can eval its arg twice.
2808 (x_connection_closed):
2809 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2810 * xterm.h: Adjust decls to match defn changes elsewhere.
2811 (struct scroll_bar): Use struct vectorlike_header
2812 rather than rolling our own approximation.
2813 (SCROLL_BAR_VEC_SIZE): Remove; not used.
2815 2012-05-25 Glenn Morris <rgm@gnu.org>
2817 * lisp.mk (lisp): Update for more files being compiled now.
2819 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
2821 * lread.c: Remove `read_pure' which makes no difference.
2822 (read_pure): Remove var.
2823 (unreadpure): Remove function.
2824 (readevalloop): Don't call read_list with -1 flag.
2825 (read1, read_vector): Don't test read_pure any more.
2826 (read_list): Simplify.
2828 * fileio.c, character.h: Minor style tweaks.
2830 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
2832 * window.h (clip_changed): Remove useless declaration.
2834 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
2836 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
2837 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
2839 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
2842 This directory predates autoconf and is no longer needed nowadays.
2843 Move its few remaining bits of functionality to where they're needed.
2844 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
2845 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
2846 * m/template.h: Remove.
2847 * Makefile.in (M_FILE): Remove. All uses removed.
2848 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
2849 * lisp.h (USE_LSB_TAG):
2850 * mem-limits.h (EXCEEDS_LISP_PTR):
2851 Use VAL_MAX, not VALBITS, in #if.
2852 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
2853 (EMACS_UINT): Define unconditionally now.
2854 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
2855 (BITS_PER_EMACS_INT): New constants, replacing
2856 what used to be in config.h, but not useful in #if.
2857 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
2858 define them any more.
2859 (VAL_MAX): New macro.
2861 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
2862 BITS_PER_EMACS_INT, in #if.
2863 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
2864 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
2865 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
2866 * s/ms-w32.h (DATA_START):
2867 Move here from removed file m/intel386.h.
2868 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
2869 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
2871 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
2873 Assume C89 or later.
2874 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
2875 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
2877 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
2878 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
2879 * textprop.c, tparam.c (NULL): Remove.
2880 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
2881 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
2882 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
2883 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
2884 * xterm.c (input_signal_count): Assume volatile works.
2886 2012-05-21 Ken Brown <kbrown@cornell.edu>
2888 * xgselect.c (xg_select): Fix first argument in call to 'select'
2891 2012-05-20 Ken Brown <kbrown@cornell.edu>
2893 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
2894 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
2896 2012-05-19 Ken Brown <kbrown@cornell.edu>
2898 * xfns.c (x_in_use): Remove `static' qualifier.
2899 * xterm.h (x_in_use): Declare.
2900 * xgselect.c: Include xterm.h.
2901 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
2902 and `display_arg' (bug#9754).
2904 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
2906 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
2908 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
2909 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
2911 2012-05-18 Eli Zaretskii <eliz@gnu.org>
2913 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
2915 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
2916 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
2918 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
2919 reference to image_cache->refcount.
2920 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
2922 2012-05-17 Juri Linkov <juri@jurta.org>
2924 * search.c (Fword_search_regexp, Fword_search_backward)
2925 (Fword_search_forward, Fword_search_backward_lax)
2926 (Fword_search_forward_lax): Move functions to isearch.el
2927 (bug#10145, bug#11381).
2929 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
2931 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
2933 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
2935 * lread.c (init_obarray): Declare Qt and Qnil as special.
2937 2012-05-14 Glenn Morris <rgm@gnu.org>
2939 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
2940 Put "libexec" before "bin", for the sake of init_callproc_1.
2942 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2944 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
2946 * unexaix.c: Port to more-recent AIX compilers.
2947 (report_error, report_error_1, make_hdr, copy_sym)
2948 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
2949 Make arguments const char *, not char *, to avoid violations of C
2950 standard and to fix some AIX warnings reported by Gilles Pion.
2952 2012-05-14 Eli Zaretskii <eliz@gnu.org>
2954 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
2955 already have overlays loaded.
2956 (handle_single_display_spec): Before returning without displaying
2957 fringe bitmap, synchronize the bidi iterator with the main display
2958 iterator, by calling iterate_out_of_display_property.
2959 (iterate_out_of_display_property): Detect buffer iteration by
2960 testing that it->string is a Lisp string.
2961 (get_next_display_element): When the current object is exhausted,
2962 and there's something on it->stack, call set_iterator_to_next to
2963 proceed with what's on the stack, instead of returning zero.
2964 (set_iterator_to_next): If called at the end of a Lisp string,
2965 proceed to consider_string_end without incrementing string
2966 position. Don't increment display vector index past the end of
2967 the display vector. (Bug#11417)
2968 (pos_visible_p): Don't report a position visible when move_it_to
2969 stopped at the last line of window, which happens to be scanned
2970 backwards by the bidi iteration. (Bug#11464)
2972 2012-05-14 Eli Zaretskii <eliz@gnu.org>
2974 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
2975 and right-margin display specs even if the spec is invalid or we
2976 are on a TTY, and thus unable to display on the fringes.
2977 That's because the text with the property will not be displayed anyway,
2978 so we need to signal to the caller that this is a "replacing"
2979 display spec. This fixes display when the spec is invalid or we
2982 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2984 * unexaix.c (make_hdr): Fix typo in prototype.
2985 This bug broke the build on AIX. Problem reported by Gilles Pion.
2987 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
2989 * keyboard.c (kbd_buffer_get_event): Read special events also in
2990 batch mode. (Bug#11415)
2992 2012-05-12 Glenn Morris <rgm@gnu.org>
2994 * ns.mk: Update for ns_appbindir no longer having trailing "/".
2996 2012-05-12 Eli Zaretskii <eliz@gnu.org>
2998 * lisp.mk (lisp): Add newcomment.elc.
3000 2012-05-12 Glenn Morris <rgm@gnu.org>
3002 * Makefile.in (MKDIR_P): New, set by configure.
3003 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
3005 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
3007 Remove unused function hourglass_started.
3008 * dispextern.h (hourglass_started):
3009 * w32fns.c (hourglass_started):
3010 * xdisp.c (hourglass_started): Remove.
3012 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
3014 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
3015 Update dependencies.
3017 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
3019 * xgselect.c (xg_select): Put maxfds+1 into a var.
3020 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
3022 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
3024 2012-05-10 Dave Abrahams <dave@boostpro.com>
3026 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
3027 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
3029 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
3031 * dbusbind.c (xd_registered_buses): New internal Lisp object.
3032 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
3033 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
3034 Initialize xd_registered_buses.
3036 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
3038 Untag more efficiently if USE_LSB_TAG.
3039 This is based on a proposal by YAMAMOTO Mitsuharu in
3040 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
3041 For an admittedly artificial (nth 8000 longlist) benchmark on
3042 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
3043 Emacs's overall text size by 1%.
3044 * lisp.h (XUNTAG): New macro.
3045 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
3046 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
3047 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
3048 * eval.c (Fautoload):
3049 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
3050 * frame.h (XFRAME): Use XUNTAG.
3052 Port recent dbusbind.c changes to 32-bit --with-wide-int.
3053 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
3054 Remove unportable assumptions about print widths of types like
3056 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
3057 intptr_t when converting between pointer and integer, to avoid GCC
3058 warnings about wrong width.
3060 2012-05-09 Eli Zaretskii <eliz@gnu.org>
3062 * w32proc.c (new_child): Force Windows to reserve only 64KB of
3063 stack for each reader_thread, instead of defaulting to 8MB
3064 determined by the linker. This avoids failures in creating
3065 subprocesses on Windows 7, see the discussion in this thread:
3066 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
3068 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
3070 Fix up display of the *Minibuf-0* buffer in the mini window.
3071 * keyboard.c (read_char): Don't clear the echo area if there's no
3073 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
3074 contents of *Minibuf-0*) if there's no message displayed in its stead.
3076 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
3078 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
3081 2012-05-06 Chong Yidong <cyd@gnu.org>
3083 * lisp.mk (lisp): Update.
3085 2012-05-05 Jim Meyering <meyering@redhat.com>
3087 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
3089 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3091 * data.c (PUT_ERROR): New macro.
3092 (syms_of_data): Use it. Add new error type `user-error'.
3093 * undo.c (user_error): New function.
3094 (Fprimitive_undo): Use it.
3095 * print.c (print_error_message): Adjust print style for `user-error'.
3096 * keyboard.c (user_error): New function.
3097 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
3099 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
3101 Do not limit current-time-string to years 1000..9999.
3102 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
3103 (Fcurrent_time_string): Support any year that is supported by the
3104 underlying localtime representation. Don't use asctime, as it
3105 has undefined behavior for years outside the range -999..9999.
3107 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
3109 Fix race conditions involving setenv, gmtime, localtime, asctime.
3110 Without this fix, interrupts could mess up code that uses these
3111 nonreentrant functions, since setting TZ invalidates existing
3112 tm_zone or tzname values, and since most of these functions return
3113 pointers to static storage.
3114 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
3115 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
3116 Grow the critical sections to include not just invoking
3117 localtime/gmtime, but also accessing these functions' results
3118 including their tm_zone values if any, and any related TZ setting.
3119 (format_time_string): Last arg is now struct tm *, not struct tm **,
3120 so that the struct tm is saved in the critical section.
3121 All callers changed. Simplify allocation of initial buffer, partly
3122 motivated by the fact that memory allocation needs to be outside
3123 the critical section.
3125 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
3127 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
3128 with RESET_INTERVAL.
3130 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3131 Remove duplicated buffer name initialization.
3133 2012-05-02 Jim Meyering <jim@meyering.net>
3135 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
3137 * xfns.c (x_window): Use xstrdup (Bug#11375).
3139 2012-05-02 Eli Zaretskii <eliz@gnu.org>
3141 * xdisp.c (pos_visible_p): If already at a newline from the
3142 display string before the 'while' loop, don't walk back the glyphs
3143 from it3.glyph_row. Solves assertion violation when the display
3144 string begins with a newline (egg.el). (Bug#11367)
3146 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
3148 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
3151 2012-05-01 Glenn Morris <rgm@gnu.org>
3153 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
3154 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
3155 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
3156 All were removed before 23.1.
3158 * dispnew.c: Remove HAVE_LIBNCURSES test;
3159 it is always true on relevant platforms.
3161 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
3162 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
3164 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
3166 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
3168 * .gdbinit (xpr): Remove checks for no longer existing misc types.
3169 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
3172 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
3174 Do not avoid creating empty evaporating overlays (Bug#9642).
3175 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
3176 That is, do not delete an evaporating overlay if it becomes
3177 empty after its bounds are adjusted to fit within its buffer.
3178 This fix caused other problems, and I'm reverting it until we get
3179 to the bottom of them.
3181 2012-04-27 Chong Yidong <cyd@gnu.org>
3183 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
3185 2012-04-27 Eli Zaretskii <eliz@gnu.org>
3187 * xdisp.c (pos_visible_p): If the window start position is beyond
3188 ZV, start the display from buffer beginning. Prevents assertion
3189 violation in init_iterator when the minibuffer window is scrolled
3192 * window.c (window_scroll_pixel_based): Likewise.
3194 2012-04-27 Chong Yidong <cyd@gnu.org>
3196 * keymap.c (where_is_internal): Doc fix (Bug#10872).
3198 2012-04-27 Glenn Morris <rgm@gnu.org>
3200 * fileio.c (Fcopy_file, Fset_file_selinux_context):
3201 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
3203 2012-04-27 Eli Zaretskii <eliz@gnu.org>
3205 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
3206 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
3208 2012-04-26 Eli Zaretskii <eliz@gnu.org>
3210 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
3211 display element, check also the underlying string or buffer
3212 character. (Bug#11341)
3214 * w32menu.c: Include w32heap.h.
3215 (add_menu_item): If the call to AppendMenuW (via
3216 unicode_append_menu) fails, disable Unicode menus only if we are
3217 running on Windows 9X/Me.
3219 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
3221 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
3222 (xgetint): Add missing shift for LSB tags.
3224 2012-04-24 Martin Rudalics <rudalics@gmx.at>
3226 * keyboard.c (read_char): Don't wipe echo area for select window
3227 events: These might get delayed via `mouse-autoselect-window'
3230 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
3232 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
3233 manipulation of :loaded-from data.
3235 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
3237 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
3238 now a cons (bug#11311).
3240 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
3242 Do not create empty overlays with the evaporate property (Bug#9642).
3243 * buffer.c (Fmove_overlay): Delete an evaporating overlay
3244 if it becomes empty after its bounds are adjusted to fit within
3245 its buffer. Without this fix, in a nonempty buffer (let ((o
3246 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
3247 yields an empty overlay that has the evaporate property, which is
3248 not supposed to happen.
3250 Fix minor GTK3 problems found by static checking.
3251 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3252 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3253 (struct _EmacsFixedClass, emacs_fixed_get_type):
3254 Move decls here from emacsgtkfixed.h, since they needn't be public.
3255 (emacs_fixed_get_type): Now static.
3256 (emacs_fixed_class_init): Omit unused local.
3257 (emacs_fixed_child_type): Remove; unused.
3258 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3259 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3260 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
3261 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
3262 (EMACS_FIXED_GET_CLASS): Remove; unused.
3263 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
3265 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
3266 Problem reported by Juanma Barranquero for Windows -Wunused-function.
3268 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3270 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
3271 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
3272 (__malloc_size_t, __malloc_ptrdiff_t):
3273 Remove. All uses removed, replaced by the definiens if needed,
3274 since we can assume C89 or better now.
3275 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
3276 (protect_malloc_state, align, get_contiguous_space)
3277 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
3278 (malloc_atfork_handler_child, malloc_enable_thread)
3279 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
3280 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
3281 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
3282 (special_realloc, _realloc_internal_nolock, _realloc_internal)
3283 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
3284 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
3285 Define using prototypes, not old style.
3286 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
3287 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
3288 (align): Don't assume that signed integer overflow wraps around.
3289 Omit unused local var.
3290 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
3291 (_free_internal_nolock, memalign, mallochook, reallochook):
3292 Omit no-longer-needed casts.
3293 (valloc): Use getpagesize, not __getpagesize.
3294 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
3295 (struct hdr): The 'magic' member is now size_t, not unsigned long.
3297 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
3299 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
3301 Move functions from C to Lisp. Make non-blocking method calls
3302 the default. Implement further D-Bus standard interfaces.
3304 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
3305 (QCdbus_request_name_allow_replacement)
3306 (QCdbus_request_name_replace_existing)
3307 (QCdbus_request_name_do_not_queue)
3308 (QCdbus_request_name_reply_primary_owner)
3309 (QCdbus_request_name_reply_in_queue)
3310 (QCdbus_request_name_reply_exists)
3311 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
3312 (QCdbus_registered_serial, QCdbus_registered_method)
3313 (QCdbus_registered_signal): New Lisp objects.
3314 (XD_DEBUG_MESSAGE): Use sizeof.
3315 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
3316 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
3317 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
3318 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
3319 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
3320 (xd_signature, xd_append_arg): Allow float for integer types.
3321 (xd_get_connection_references): New function.
3322 (xd_get_connection_address): Rename from xd_initialize.
3323 Return cached address.
3324 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
3325 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
3327 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
3328 Return number of refcounts.
3329 (Fdbus_get_unique_name): Make stronger parameter check.
3330 (Fdbus_message_internal): New defun.
3331 (Fdbus_call_method, Fdbus_call_method_asynchronously)
3332 (Fdbus_method_return_internal, Fdbus_method_error_internal)
3333 (Fdbus_send_signal, Fdbus_register_service)
3334 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
3335 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
3336 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
3337 (Vdbus_compiled_version, Vdbus_runtime_version)
3338 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
3339 (Vdbus_message_type_method_return, Vdbus_message_type_error)
3340 (Vdbus_message_type_signal): New defvars.
3341 (Vdbus_registered_buses, Vdbus_registered_objects_table):
3344 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3346 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
3347 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
3348 Do not assume ptrdiff_t is the same width as 'int'.
3350 * alloc.c: Handle unusual debugging option combinations.
3351 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
3352 since the two debugging options are incompatible.
3353 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
3355 (mem_init, mem_insert, mem_insert_fixup):
3356 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
3357 (NEED_MEM_INSERT): Remove; no longer needed.
3359 2012-04-22 Leo Liu <sdl.web@gmail.com>
3361 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
3363 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3365 * sysdep.c [__FreeBSD__]: Minor cleanups.
3366 (list_system_processes, system_process_attributes) [__FreeBSD__]:
3367 Use Emacs indenting style more consistently. Avoid some casts.
3368 Use 'double' consistently rather than mixing 'float' and 'double'.
3370 2012-04-21 Eduard Wiebe <usenet@pusto.de>
3372 * sysdep.c (list_system_processes, system_process_attributes):
3373 Add implementation for FreeBSD (Bug#5243).
3375 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
3377 * lisp.mk (lisp): Update.
3379 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
3381 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
3382 It is never used otherwise.
3384 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
3386 * print.c (print_preprocess): Only check print_depth if print-circle
3388 (print_object): Check for cycles even when print-circle is nil and
3389 print-gensym is t, but only check print_depth if print-circle is nil.
3391 2012-04-20 Chong Yidong <cyd@gnu.org>
3393 * process.c (wait_reading_process_output): If EIO occurs on a pty,
3394 set the status to "failed" and ensure that sentinel is run.
3396 2012-04-20 Glenn Morris <rgm@gnu.org>
3398 * process.c (Fset_process_inherit_coding_system_flag)
3399 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
3400 (Fmake_network_process, Fmake_serial_process): Doc fix.
3402 2012-04-20 Eli Zaretskii <eliz@gnu.org>
3404 * xdisp.c (string_buffer_position_lim): Limit starting position to
3406 (set_cursor_from_row): If called for a mode-line or header-line
3407 row, return zero immediately.
3408 (try_cursor_movement): If inside continuation line, don't back up
3409 farther than the first row after the header line, if any.
3410 Don't consider the header-line row as "partially visible", even if
3411 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
3413 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
3415 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
3418 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
3419 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
3421 configure: new option --enable-gcc-warnings (Bug#11207)
3422 * Makefile.in (C_WARNINGS_SWITCH): Remove.
3423 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
3424 (ALL_CFLAGS): Use new macros rather than old.
3425 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
3426 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
3427 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
3428 -Wunused-result, -Wunused-variable. This should go away once
3429 the Emacs and Gnulib regex code is merged.
3430 (xmalloc, xrealloc): Now static.
3432 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
3434 * dired.c (Fsystem_groups): Remove unused local.
3436 2012-04-17 Glenn Morris <rgm@gnu.org>
3438 * dired.c (Fsystem_users): Doc fix.
3440 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
3442 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
3443 (syms_of_dired): Add them.
3445 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
3447 Fix minor alloc.c problems found by static checking.
3448 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
3449 New extern decls, to avoid calling undeclared functions.
3450 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
3451 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
3452 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
3453 (NEED_MEM_INSERT): New macro.
3454 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
3455 Remove one incorrect comment and fix another.
3457 Fix minor ralloc.c problems found by static checking.
3458 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3459 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
3460 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
3461 (r_alloc_sbrk): Now static.
3463 Improve ralloc.c interface checking.
3464 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3465 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
3466 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
3467 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
3468 [REL_ALLOC]: ... to here, to check interface.
3469 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
3470 Remove decls. This fixes an "It stinks!".
3472 * alloc.c (which_symbols): Fix alignment issue / type clash.
3474 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
3476 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
3477 (struct Lisp_Misc_Any): Likewise.
3478 (struct Lisp_Free): Likewise.
3479 * alloc.c (union aligned_Lisp_Symbol): Define.
3480 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
3481 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
3482 (union aligned_Lisp_Misc): Define.
3483 (MARKER_BLOCK_SIZE, struct marker_block): Use union
3484 aligned_Lisp_Misc instead of union Lisp_Misc.
3485 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
3487 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
3489 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
3490 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
3491 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
3492 * s/netbsd.h, s/sol2-6.h:
3493 Remove definition of GC_MARK_STACK, since the default now works.
3494 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
3495 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
3496 no longer the default.
3497 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
3499 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
3501 * lread.c (lisp_file_lexically_bound_p):
3502 Fix hang at ";-*-\n" (bug#11238).
3504 2012-04-14 Eli Zaretskii <eliz@gnu.org>
3506 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
3507 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
3509 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
3511 * nsterm.m (constrainFrameRect): Always constrain when there is only
3512 one screen (Bug#10962).
3514 2012-04-13 Ken Brown <kbrown@cornell.edu>
3516 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
3518 2012-04-13 Reuben Thomas <rrt@sc3d.org>
3520 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
3522 2012-04-11 Daniel Colascione <dancol@dancol.org>
3524 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
3525 against is gone. It's better to use vfork now so that when Cygwin
3526 gains a new, working vfork, we use it automatically (bug#10398).
3528 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3530 * window.c (save_window_save): Obey window-point-insertion-type.
3532 2012-04-11 Glenn Morris <rgm@gnu.org>
3534 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
3536 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3538 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
3540 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
3542 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
3543 (force_quit_count): New var.
3544 (handle_interrupt): Use it.
3546 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
3548 * w32.c (w32_delayed_load): Record the full path of the library
3549 being loaded (bug#10424).
3551 2012-04-09 Glenn Morris <rgm@gnu.org>
3553 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
3554 not just in the obarray, before snarfing them. (Bug#11036)
3556 * Makefile.in ($(leimdir)/leim-list.el):
3557 Pass EMACS rather than BUILT_EMACS.
3559 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
3561 * process.c (make_process):
3562 * process.h: Add integer `gnutls_handshakes_tried' member to
3565 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
3566 Add convenience `GNUTLS_LOG2i' macro.
3568 * gnutls.c (gnutls_log_function2i): Convenience log function.
3569 (emacs_gnutls_read): Use new log functions,
3570 `gnutls_handshakes_tried' process member, and
3571 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
3572 attempts per process (connection).
3574 2012-04-09 Chong Yidong <cyd@gnu.org>
3576 * eval.c (Fuser_variable_p, user_variable_p_eh)
3577 (lisp_indirect_variable): Functions deleted.
3578 (Fdefvar): Caller changed.
3580 * callint.c (Finteractive, Fcall_interactively):
3581 * minibuf.c (Fread_variable): Callers changed.
3583 2012-04-09 Eli Zaretskii <eliz@gnu.org>
3585 * xdisp.c (set_cursor_from_row): If the display string appears in
3586 the buffer at position that is closer to point than the position
3587 after the display string, display the cursor on the first glyph of
3588 the display string. Fixes cursor display when a 'display' text
3589 property immediately follows invisible text. (Bug#11094)
3591 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
3593 composite.c: use 'double' consistently
3594 * composite.c (get_composition_id): Use 'double' consistently
3595 instead of converting 'float' to 'double' and vice versa; this is
3596 easier to understand and avoids a GCC warning.
3598 2012-04-09 Glenn Morris <rgm@gnu.org>
3600 * Makefile.in: Generate leim-list with bootstrap-emacs, in
3601 preparation for dumping it with emacs. (Bug#4789)
3602 (leimdir): New variable.
3603 ($(leimdir)/leim-list.el): New rule.
3604 (emacs$(EXEEXT)): Depend on leim-list.el.
3606 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
3607 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
3608 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
3610 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
3612 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
3615 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
3617 * xml.c (init_libxml2_functions) [WINDOWSNT]:
3618 Remove unused local variable.
3620 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3622 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
3623 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
3624 (mark_memory): Mark Lisp_Objects only if pointers might hide in
3625 objects, as mark_maybe_pointer will catch them otherwise.
3626 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
3627 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
3629 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3631 Fix typo that broke non-Windows builds.
3632 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
3634 2012-04-07 Eli Zaretskii <eliz@gnu.org>
3636 Support building on MS-Windows with libxml2.
3638 * makefile.w32-in (OBJ2): Add xml.$(O).
3639 (GLOBAL_SOURCES): Add xml.c.
3640 ($(BLD)/xml.$(O)): New dependency list.
3642 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
3643 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
3644 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
3645 [!WINDOWSNT]: New macros.
3646 (init_libxml2_functions, libxml2_loaded_p): New functions.
3647 (parse_region): Call fn_xmlCheckVersion instead of using the macro
3648 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
3649 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
3650 Calls xmlCleanupParser only if libxml2 was loaded (or statically
3652 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
3653 Call init_libxml2_functions before calling libxml2 functions.
3654 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
3656 * emacs.c: Don't include libxml/parser.h.
3657 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
3658 xmlCleanupParser directly.
3660 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
3662 2012-04-07 Eli Zaretskii <eliz@gnu.org>
3664 * indent.c (Fvertical_motion): If there is a display string at
3665 point, use it.vpos to compute how many lines to backtrack after
3666 move_it_to point. (Bug#11133)
3668 2012-04-06 Eli Zaretskii <eliz@gnu.org>
3670 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
3671 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
3672 about subtle differences between FETCH_CHAR* and STRING_CHAR*
3673 macros related to unification of CJK characters. For the details,
3674 see the discussion following the message here:
3675 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
3677 2012-04-04 Chong Yidong <cyd@gnu.org>
3679 * keyboard.c (Vdelayed_warnings_list): Doc fix.
3681 2012-04-01 Eli Zaretskii <eliz@gnu.org>
3683 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
3684 instead of alloca. (Bug#11138)
3686 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
3688 * w32menu.c (is_simple_dialog): Properly check lisp types.
3691 2012-03-31 Eli Zaretskii <eliz@gnu.org>
3693 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
3694 position we get to after a call to move_it_to fails the
3695 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
3696 only if we wind up in a string from display property. (Bug#11063)
3698 * window.c (Fdelete_other_windows_internal): Invalidate the row
3699 and column information about mouse highlight, so that redisplay
3700 restores it after reallocating the glyph matrices. (Bug#7464)
3702 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
3703 string comes from a `display' text property, use the buffer
3704 position of that property as if we actually saw that position in
3706 (move_it_by_lines): Remove the assertion that
3707 "it->current_x == 0 && it->hpos == 0" which can be legitimately
3708 violated when there's a before-string at the beginning of a line.
3711 2012-03-30 Eli Zaretskii <eliz@gnu.org>
3713 * xdisp.c (append_space_for_newline): If the default face was
3714 remapped, use the remapped face for the appended newline.
3715 (extend_face_to_end_of_line): Use the remapped default face for
3716 extending the face to the end of the line.
3717 (display_line): Call extend_face_to_end_of_line when the default
3718 face was remapped. (Bug#11068)
3720 2012-03-29 Eli Zaretskii <eliz@gnu.org>
3722 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
3724 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3726 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
3728 2012-03-27 Glenn Morris <rgm@gnu.org>
3730 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
3733 2012-03-26 Kenichi Handa <handa@m17n.org>
3735 * dispextern.h (struct glyph): Fix previous change. Change the
3736 bit length of glyphless.ch to 25 (Bug#11082).
3738 2012-03-26 Chong Yidong <cyd@gnu.org>
3740 * keyboard.c (Vselection_inhibit_update_commands): New variable.
3741 (command_loop_1): Use it; inhibit selection update for
3742 handle-select-window too (Bug#8996).
3744 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
3746 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
3748 2012-03-25 Kenichi Handa <handa@m17n.org>
3750 * dispextern.h (struct glyph): Change the bit length of
3751 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
3753 2012-03-24 Eli Zaretskii <eliz@gnu.org>
3755 * s/ms-w32.h (tzname): Include time.h before redirecting to
3756 _tzname. Fixes the MSVC build. (Bug#9960)
3758 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
3760 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
3763 * xterm.c (XTread_socket): Only modify handling_signal if
3764 !SYNC_INPUT. (Bug#11080)
3766 2012-03-23 Eli Zaretskii <eliz@gnu.org>
3768 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
3769 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
3770 when fetching a multibyte character consumes more bytes than
3771 CHAR_BYTES returns, due to unification of CJK characters in
3772 string_char. (Bug#11073)
3774 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
3776 * process.c (wait_reading_process_output): Handle pty disconnect
3777 by refraining from sending oneself a SIGCHLD (bug#10933).
3779 2012-03-22 Chong Yidong <cyd@gnu.org>
3781 * dispextern.h (struct it): New member string_from_prefix_prop_p.
3783 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
3784 Mark string as coming from a prefix property.
3785 (handle_face_prop): Use default face for prefix strings (Bug#4281).
3786 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
3788 2012-03-21 Chong Yidong <cyd@gnu.org>
3790 * xfaces.c (Vface_remapping_alist): Doc fix.
3792 2012-03-20 Eli Zaretskii <eliz@gnu.org>
3794 * w32proc.c (Fw32_set_console_codepage)
3795 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
3798 2012-03-20 Chong Yidong <cyd@gnu.org>
3800 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
3801 to reflect default non-nil value of redisplay-dont-pause.
3803 2012-03-19 Kenichi Handa <handa@m17n.org>
3805 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
3806 it fit in a valid range (Bug#11003).
3808 2012-03-18 Eli Zaretskii <eliz@gnu.org>
3810 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
3811 that is not from display property, accept the row as a "cursor
3812 row" if one of the string's character has a non-nil `cursor'
3813 property. Fixes cursor positioning when there are newlines in
3814 overlay strings, e.g. in icomplete.el. (Bug#11035)
3816 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
3818 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
3820 2012-03-12 Chong Yidong <cyd@gnu.org>
3822 * eval.c (inhibit_lisp_code): Rename from
3823 inhibit_window_configuration_change_hook; move from window.c.
3825 * xfns.c (unwind_create_frame_1, Fx_create_frame):
3826 * window.c (run_window_configuration_change_hook)
3827 (syms_of_window): Callers changed.
3829 2012-03-11 Chong Yidong <cyd@gnu.org>
3831 * keymap.c (Fkey_description): Doc fix (Bug#9700).
3833 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
3835 2012-03-10 Chong Yidong <cyd@gnu.org>
3837 * frame.c (other_visible_frames): Don't assume the selected frame
3838 is visible (Bug#10955).
3840 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
3842 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
3844 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
3846 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
3847 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
3850 2012-03-03 Glenn Morris <rgm@gnu.org>
3852 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
3854 2012-03-02 Eli Zaretskii <eliz@gnu.org>
3856 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
3857 position past the first glyph_row that ends at ZV. (Bug#10902)
3858 (redisplay_window, next_element_from_string): Fix typos in
3860 (redisplay_window): Pass to move_it_vertically the margin in
3861 pixels, not in screen lines.
3863 2012-03-02 Glenn Morris <rgm@gnu.org>
3865 * buffer.c (buffer-list-update-hook): Doc fix.
3867 2012-02-29 Eli Zaretskii <eliz@gnu.org>
3869 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
3870 push_it before setting up the iterator for the first overlay
3871 string, even if we have an empty string loaded.
3872 (next_overlay_string): If there's an empty string on the iterator
3873 stack, pop the stack. (Bug#10903)
3875 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
3877 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
3878 Suggested by Stefan Monnier in
3879 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
3880 * alloc.c (widen_to_Lisp_Object): New static function.
3881 (mark_memory): Also mark Lisp_Objects by fetching pointer words
3882 and widening them to Lisp_Objects. This would work even if
3883 USE_LSB_TAG is defined and wide integers are used, which might
3884 happen in a future version of Emacs.
3886 2012-02-25 Chong Yidong <cyd@gnu.org>
3888 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
3891 * xselect.c (Fx_selection_exists_p): Doc fix.
3892 (x_clipboard_manager_save_all): Print an informative message
3893 before saving to clipboard manager.
3895 2012-02-24 Chong Yidong <cyd@gnu.org>
3897 * keyboard.c (process_special_events): Handle all X selection
3898 requests in kbd_buffer, not just the next one (Bug#8869).
3900 2012-02-23 Chong Yidong <cyd@gnu.org>
3902 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
3903 call when setting menu-bar-lines and tool-bar-lines parameters.
3904 (unwind_create_frame_1): New helper function.
3906 * window.c (inhibit_window_configuration_change_hook): New var.
3907 (run_window_configuration_change_hook): Obey it.
3908 (syms_of_window): Initialize it.
3910 2012-02-22 Chong Yidong <cyd@gnu.org>
3912 * xterm.c (x_draw_image_relief): Add missing type check for
3913 Vtool_bar_button_margin (Bug#10743).
3915 2012-02-21 Chong Yidong <cyd@gnu.org>
3917 * fileio.c (Vfile_name_handler_alist): Doc fix.
3919 * buffer.c (Fget_file_buffer): Protect against invalid file
3920 handler return value.
3922 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
3924 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
3925 when computing $valmask.
3927 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
3928 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
3929 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
3930 It's useless in that case, and it can cause problems on hosts
3931 that allocate halves of EMACS_INT values separately.
3932 Reported by Dan Horák. Diagnosed by Andreas Schwab in
3933 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
3934 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
3935 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
3936 it avoids undefined behavior on hosts where shifting right by more
3937 than the word width has undefined behavior.
3939 2012-02-19 Chong Yidong <cyd@gnu.org>
3941 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
3942 (Funhandled_file_name_directory, Ffile_name_as_directory)
3943 (Fdirectory_file_name, Fexpand_file_name)
3944 (Fsubstitute_in_file_name): Protect against invalid file handler
3945 return values (Bug#10845).
3947 2012-02-18 Eli Zaretskii <eliz@gnu.org>
3949 * .gdbinit (pitx): Fix incorrect references to fields of the
3952 2012-02-17 Chong Yidong <cyd@gnu.org>
3954 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
3956 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
3958 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
3959 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
3961 2012-02-15 Chong Yidong <cyd@gnu.org>
3963 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
3964 marked as special. Also, starting docstrings with * is obsolete.
3966 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
3968 * gnutls.c (emacs_gnutls_write): Fix last change.
3970 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
3972 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
3975 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
3977 * keymap.c (Fsingle_key_description): Handle char ranges.
3979 2012-02-12 Chong Yidong <cyd@gnu.org>
3981 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
3982 as that creates a dangerous corner case.
3984 * window.c (Fdelete_window_internal): Invalidate the mouse
3985 highlight (Bug#9904).
3987 2012-02-12 Glenn Morris <rgm@gnu.org>
3989 * xselect.c (Fx_own_selection_internal)
3990 (Fx_get_selection_internal, Fx_disown_selection_internal)
3991 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
3992 * nsselect.m (Fx_own_selection_internal)
3993 (Fx_disown_selection_internal, Fx_selection_exists_p)
3994 (Fx_selection_owner_p, Fx_get_selection_internal):
3995 Sync docs and argument specs with the xselect.c versions.
3997 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
3999 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
4001 2012-02-11 Eli Zaretskii <eliz@gnu.org>
4003 * w32select.c (Fx_selection_exists_p): Sync doc string and
4004 argument list with xselect.c. (Bug#10783)
4006 * w16select.c (Fx_selection_exists_p): Sync doc string and
4007 argument list with xselect.c. (Bug#10783)
4009 2012-02-10 Glenn Morris <rgm@gnu.org>
4011 * fns.c (Fsecure_hash): Doc fix.
4013 2012-02-09 Kenichi Handa <handa@m17n.org>
4015 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
4017 2012-02-07 Chong Yidong <cyd@gnu.org>
4019 * buffer.c (Fbuffer_local_variables)
4020 (buffer_lisp_local_variables): Handle unbound vars correctly;
4021 don't let Qunbound leak into Lisp.
4023 2012-02-07 Glenn Morris <rgm@gnu.org>
4025 * image.c (Fimagemagick_types): Doc fix.
4027 * image.c (imagemagick-render-type): Change it from a lisp object
4028 to an integer. Move the doc here from the lisp manual.
4029 Treat all values not equal to 0 the same.
4031 2012-02-06 Chong Yidong <cyd@gnu.org>
4033 * doc.c (store_function_docstring): Avoid applying docstring of
4034 alias to base function (Bug#2603).
4036 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
4038 * .gdbinit (pp1, pv1): Remove redundant defines.
4041 2012-02-04 Chong Yidong <cyd@gnu.org>
4043 * nsterm.m: Declare a global (Bug#10694).
4045 2012-02-04 Eli Zaretskii <eliz@gnu.org>
4047 * w32.c (get_emacs_configuration_options):
4048 Include --enable-checking, if specified, in the return value.
4050 2012-02-04 Martin Rudalics <rudalics@gmx.at>
4052 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
4053 after rounding frame sizes. (Bug#9723)
4055 2012-02-04 Eli Zaretskii <eliz@gnu.org>
4057 * keyboard.c (adjust_point_for_property): Don't position point
4058 before BEGV. (Bug#10696)
4060 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
4062 Handle overflow when computing char display width (Bug#9496).
4063 * character.c (char_width): Return EMACS_INT, not int.
4064 (char_width, c_string_width): Check for overflow when
4065 computing the width; this is possible now that individual
4066 characters can have unbounded width. Problem introduced
4067 by merge from Emacs 23 on 2012-01-19.
4069 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
4071 * dbusbind.c (Fdbus_register_method): Mention the return value
4072 :ignore in the docstring.
4074 2012-02-02 Glenn Morris <rgm@gnu.org>
4076 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
4078 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4079 Unconditionally set to t. (Bug#10673)
4080 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4081 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4082 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
4084 2012-02-02 Kenichi Handa <handa@m17n.org>
4086 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
4087 0, do not call append_composite_glyph.
4089 2012-02-02 Kenichi Handa <handa@m17n.org>
4091 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
4093 (x_produce_glyphs): If the component of a composition is a null
4094 string, set it->pixel_width to 1 to avoid zero-width glyph.
4096 2012-02-01 Eli Zaretskii <eliz@gnu.org>
4098 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
4099 first 2 arguments are identical. This makes inserting large
4100 output from a subprocess an order of magnitude faster on
4101 MS-Windows, where all sbrk'ed memory is always contiguous.
4103 2012-01-31 Glenn Morris <rgm@gnu.org>
4105 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4106 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4107 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
4109 2012-01-29 Glenn Morris <rgm@gnu.org>
4111 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
4113 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
4115 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
4117 2012-01-28 Chong Yidong <cyd@gnu.org>
4119 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
4121 2012-01-26 Chong Yidong <cyd@gnu.org>
4123 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
4125 * search.c (Fsearch_forward, Fsearch_backward): Document negative
4126 repeat counts (Bug#10507).
4128 2012-01-26 Glenn Morris <rgm@gnu.org>
4130 * lread.c (syms_of_lread): Doc fix.
4132 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
4134 * coding.c (encode_designation_at_bol): Change return value to
4137 2012-01-25 Chong Yidong <cyd@gnu.org>
4139 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
4141 2012-01-21 Chong Yidong <cyd@gnu.org>
4143 * floatfns.c (Fcopysign): Make the second argument non-optional,
4144 since nil is not allowed anyway.
4146 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
4148 * process.c (read_process_output): Use p instead of XPROCESS (proc).
4149 (send_process): Likewise.
4151 2012-01-19 Martin Rudalics <rudalics@gmx.at>
4153 * window.c (save_window_save, Fcurrent_window_configuration)
4154 (Vwindow_persistent_parameters): Do not use Qstate.
4155 Rewrite doc-strings.
4157 2012-01-19 Kenichi Handa <handa@m17n.org>
4159 * character.c (char_width): New function.
4160 (Fchar_width, c_string_width, lisp_string_width):
4161 Use char_width (Bug#9496).
4163 2012-01-16 Martin Rudalics <rudalics@gmx.at>
4165 * window.c (Vwindow_persistent_parameters): New variable.
4166 (Fset_window_configuration, save_window_save): Handle persistent
4169 2012-01-14 Eli Zaretskii <eliz@gnu.org>
4171 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
4172 thrashing the stack of the thread. (Bug#9087)
4174 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
4176 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
4178 2012-01-11 Eli Zaretskii <eliz@gnu.org>
4180 * xdisp.c (rows_from_pos_range): Handle the case where the
4181 highlight ends on a newline. (Bug#10464)
4182 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
4183 he end column for display of highlight that ends on a newline
4186 2012-01-11 Glenn Morris <rgm@gnu.org>
4188 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
4189 from load-path also when installation-directory is nil. (Bug#10208)
4191 2012-01-10 Glenn Morris <rgm@gnu.org>
4193 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
4195 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
4196 Update template values to be closer to their typical values these days.
4198 2012-01-09 Eli Zaretskii <eliz@gnu.org>
4200 * xdisp.c (rows_from_pos_range): Accept additional argument
4201 DISP_STRING, and accept any glyph in a row whose object is that
4202 string as eligible for mouse highlight. Fixes mouse highlight of
4203 display strings from overlays. (Bug#10464)
4205 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
4207 emacs: fix an auto-save permissions race condition (Bug#10400)
4208 * fileio.c (auto_saving_dir_umask): New static var.
4209 (Fmake_directory_internal): Use it.
4210 (do_auto_save_make_dir): Set it, instead of invoking chmod after
4211 creating the directory. The old code temporarily assigns
4212 too-generous permissions to the directory.
4213 (do_auto_save_eh): Clear it.
4214 (Fdo_auto_save): Catch all errors, not just file errors, so
4215 that the var is always cleared.
4217 2012-01-07 Eli Zaretskii <eliz@gnu.org>
4219 * search.c (scan_buffer): Pass character positions to
4220 know_region_cache, not byte positions. (Bug#6540)
4222 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
4224 * w32.c (sys_rename): Report EXDEV when rename of a directory
4225 fails because the target is on another logical disk. (Bug#10284)
4227 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
4229 * xterm.c (x_embed_request_focus): New function.
4231 * xterm.h: Add prototype.
4233 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
4235 2012-01-05 Glenn Morris <rgm@gnu.org>
4237 * emacs.c (emacs_copyright): Update short copyright year to 2012.
4239 2012-01-01 Eli Zaretskii <eliz@gnu.org>
4241 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
4242 Load gnutls_transport_set_lowat only if GnuTLS version is below
4244 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
4245 GnuTLS versions below 2.11.1.
4247 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
4249 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
4250 to the doc string advising against its use for altering the way
4251 windows are scrolled.
4253 2011-12-28 Kenichi Handa <handa@m17n.org>
4255 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
4256 coding-system ASCII compatible only when it does not produce BOM
4257 on encoding (Bug#10383).
4259 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
4261 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
4263 (create_and_show_popup_menu): Always use menu_position_func for
4266 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
4268 * callint.c (Fcall_interactively): Don't truncate prompt string.
4270 2011-12-23 Eli Zaretskii <eliz@gnu.org>
4272 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
4273 property that ends at ZV, so that the bidi iteration could be
4274 resumed from there (after widening). (Bug#10360)
4276 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
4278 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
4280 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
4282 * nsterm.m (x_free_frame_resources):
4283 Release f->output_data.ns->miniimage.
4284 (ns_index_color): Fix indentation. Do not retain
4285 color_table->colors[i].
4287 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
4290 * nsfns.m (x_set_background_color): Assign return value from
4291 ns_index_color to face-background instead of NSColor*.
4292 (ns_implicitly_set_icon_type): Fix indentation.
4293 Change assignment in for loop to comparison.
4295 * emacs.c (ns_pool): New variable.
4296 (main): Assign ns_pool.
4297 (Fkill_emacs): Call ns_release_autorelease_pool.
4299 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
4300 autorelease fdesc, release fdAttrs and tdict.
4301 (ns_get_covering_families): Release charset.
4302 (ns_findfonts): Release NSFontDescriptor created with new.
4303 (ns_uni_to_glyphs): Fix indentation.
4304 (setString): Release attrStr before assigning new value.
4306 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4308 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
4310 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
4311 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
4313 2011-12-18 David Reitter <reitter@cmu.edu>
4315 * nsterm.m (ns_term_init): Subscribe for notifications
4316 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
4317 to method trackingNotification in EmacsMenu.
4319 * nsmenu.m (trackingMenu): New variable.
4320 (trackingNotification): New method (from Aquamacs).
4321 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
4322 from Aquamacs (Bug#7030).
4324 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4326 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
4327 (symbol_to_nsstring): Fix indentation.
4328 (ns_symbol_to_pb): New function.
4329 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
4330 (Fns_rotate_cut_buffers_internal): Remove.
4331 (Fns_store_selection_internal): Rename from
4332 Fns_store_cut_buffer_internal.
4333 (ns_get_foreign_selection, Fx_own_selection_internal)
4334 (Fx_disown_selection_internal, Fx_selection_exists_p)
4335 (Fns_get_selection_internal, Fns_store_selection_internal):
4336 Use ns_symbol_to_pb and check if return value is nil.
4337 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
4338 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
4339 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
4340 renamed to Sns_store_selection_internal.
4341 (ns_handle_selection_request): Move code to Fx_own_selection_internal
4342 and remove this function.
4343 (ns_handle_selection_clear): Remove, never used.
4344 (Fx_own_selection_internal): Move code from ns_handle_selection_request
4347 2011-12-17 Ken Brown <kbrown@cornell.edu>
4349 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
4350 GID is unknown (Bug#10257).
4352 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
4354 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
4355 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
4356 which caused a build failure on GNU/Linux IA-64. This problem was
4357 introduced by my 2011-10-07 patch.
4359 2011-12-15 Juri Linkov <juri@jurta.org>
4361 * image.c (imagemagick_error): New function. (Bug#10112)
4362 (imagemagick_load_image): Comment out `MagickSetResolution' call.
4363 Use `imagemagick_error' where ImageMagick functions return
4365 (Fimagemagick_types): Add `Fnreverse' to return the list in the
4368 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4370 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
4371 fill background (Bug#8992).
4373 2011-12-13 Martin Rudalics <rudalics@gmx.at>
4375 * window.c (Vwindow_combination_resize)
4376 (Vwindow_combination_limit): Use t instead of non-nil in
4378 (Vrecenter_redisplay): Add first sentence of doc-string on
4380 (Frecenter): Fix doc-string typo.
4382 2011-12-11 Kenichi Handa <handa@m17n.org>
4384 * coding.c (Funencodable_char_position): Pay attention to the
4385 buffer text relocation (Bug#9389).
4387 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4389 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
4390 gtk_init (Bug#10100).
4392 2011-12-10 Eli Zaretskii <eliz@gnu.org>
4394 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
4395 IT->string is nil. (Bug#10263)
4397 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4399 * nsterm.h (x_free_frame_resources): Declare.
4401 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
4402 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
4404 * nsterm.h (ns_get_defaults_value): Declare.
4406 * nsterm.m (ns_default): Call ns_get_defaults_value.
4408 2011-12-09 Eli Zaretskii <eliz@gnu.org>
4410 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
4413 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4415 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
4416 that where the value of an _OBJC_* symbol points to is in the .bss
4417 section (Bug#10240).
4419 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4421 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
4422 after the loop to call ccl_driver at least once (Bug#8619).
4424 2011-12-08 Kenichi Handa <handa@m17n.org>
4426 * ftfont.c (get_adstyle_property): Fix previous change
4429 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
4431 * w32.c (init_environment): If no_site_lisp, remove site-lisp
4432 dirs from the default value of EMACSLOADPATH (bug#10208).
4434 2011-12-07 Glenn Morris <rgm@gnu.org>
4436 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
4437 installation and source directories as well. (Bug#10208)
4439 2011-12-06 Chong Yidong <cyd@gnu.org>
4441 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
4443 2011-12-06 Glenn Morris <rgm@gnu.org>
4445 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
4446 as an error, not just -1. (Bug#10217)
4448 2011-12-05 Chong Yidong <cyd@gnu.org>
4450 * keyboard.c (process_special_events): New function.
4451 (swallow_events, Finput_pending_p): Use it (Bug#10195).
4453 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
4455 * coding.c (encode_designation_at_bol): Don't use uninitialized
4456 local variable (Bug#9318).
4458 2011-12-05 Kenichi Handa <handa@m17n.org>
4460 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
4461 return Qnil (Bug#8046, Bug#10193).
4463 2011-12-05 Kenichi Handa <handa@m17n.org>
4465 * coding.c (encode_designation_at_bol): New args charbuf_end and
4466 dst. Return the number of produced bytes. Callers changed.
4467 (coding_set_source): Return how many bytes coding->source was
4469 (coding_set_destination): Return how many bytes
4470 coding->destination was relocated.
4471 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
4472 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
4474 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4476 * coding.c (CODING_CHAR_CHARSET_P): New macro.
4477 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
4480 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
4482 The following changes are to fix Bug#9318.
4484 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
4485 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
4486 (encode_coding_iso_2022, encode_coding_sjis)
4487 (encode_coding_big5, encode_coding_charset): Use the above macros.
4489 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
4491 * lisp.h (process_quit_flag): Fix external declaration.
4493 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
4495 Don't macro-inline non-performance-critical code.
4496 * eval.c (process_quit_flag): New function.
4497 * lisp.h (QUIT): Use it.
4499 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
4501 * nsfns.m (get_geometry_from_preferences): New function.
4502 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
4504 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
4506 * emacs.c (Qkill_emacs): Define.
4507 (syms_of_emacs): Initialize it.
4508 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
4509 Qquit_flag to `kill-emacs' instead.
4510 (quit_throw_to_read_char): Add parameter `from_signal'.
4511 All callers changed. Call Fkill_emacs if requested and safe.
4512 * lisp.h (QUIT): Call Fkill_emacs if requested.
4514 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
4516 * widget.c (update_wm_hints): Return if wmshell is null.
4517 (widget_update_wm_size_hints): New function.
4519 * widget.h (widget_update_wm_size_hints): Declare.
4521 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
4522 widget_update_wm_size_hints (Bug#10104).
4524 2011-12-03 Eli Zaretskii <eliz@gnu.org>
4526 * xdisp.c (handle_invisible_prop): If the invisible text ends just
4527 before a newline, prepare the bidi iterator for consuming the
4528 newline, and keep the current paragraph direction. (Bug#10183)
4529 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
4531 2011-12-02 Juri Linkov <juri@jurta.org>
4533 * search.c (Fword_search_regexp): New Lisp function created from
4534 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
4535 (Fword_search_backward, Fword_search_forward)
4536 (Fword_search_backward_lax, Fword_search_forward_lax):
4537 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
4538 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
4540 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
4542 * fileio.c (Finsert_file_contents): Move after-change-function call
4543 to before the "handled:" label, since all "goto handled" appear in
4544 cases where the *-change-functions have already been properly called
4547 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
4549 * keyboard.c (interrupt_signal): Don't call kill-emacs when
4550 waiting for input. (Bug#10169)
4552 2011-11-30 Eli Zaretskii <eliz@gnu.org>
4554 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
4555 verifies glyph row's hash code--we have just reallocated the
4556 glyphs, so their contents can be complete garbage. (Bug#10164)
4558 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
4560 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
4562 2011-11-30 Eli Zaretskii <eliz@gnu.org>
4564 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
4565 attributes are tested _before_ calling verify_row_hash, to protect
4566 against GCC re-ordering of the tests. (Bug#10164)
4568 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
4570 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
4572 * xterm.c (handle_one_xevent): Only set async_visible and friends
4573 if net_wm_state_hidden_seen is non-zero (Bug#10002)
4574 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
4575 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
4577 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
4579 Remove GCPRO-related macros that exist only to avoid shadowing locals.
4580 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
4581 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
4582 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4583 All uses changed to use GCPRO1 etc.
4584 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
4585 Revert to old implementation (i.e., before 2011-03-11).
4587 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4589 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
4590 of scroll runs so as to avoid assigning disabled bogus rows and
4591 unnecessary graphics copy operations.
4593 2011-11-27 Eli Zaretskii <eliz@gnu.org>
4595 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
4596 (snprintf) [_MSC_VER]: Redirect to _snprintf.
4597 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
4598 (malloc, free, realloc, calloc): Redirect to e_* only when
4601 * lisp.h (GCTYPEBITS): Move before first use.
4602 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
4603 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
4604 this macro definition.
4606 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
4609 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
4611 * gtkutil.c (xg_create_frame_widgets):
4612 Call gtk_window_set_has_resize_grip (FALSE) if that function is
4613 present with Gtk+ 2.0.
4615 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4617 * fileio.c (Finsert_file_contents): Undo previous change; see
4618 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4620 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4622 Rename locals to avoid shadowing.
4623 * fileio.c (Finsert_file_contents):
4624 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
4625 * process.c (wait_reading_process_output):
4626 Rename inner 'proc' to 'p' to avoid shadowing.
4627 Indent for consistency with usual Emacs style.
4629 2011-11-25 Eli Zaretskii <eliz@gnu.org>
4631 * xdisp.c (redisplay_window): If cursor row is not fully visible
4632 after recentering, and scroll-conservatively is set to a large
4633 number, scroll window by a few more lines to make the cursor fully
4634 visible and out of scroll-margin. (Bug#10105)
4635 (start_display): Don't move to the next line if the display should
4636 start at a newline that is part of a display vector or an overlay
4639 2011-11-24 Juri Linkov <juri@jurta.org>
4641 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
4642 after the `MagickPingImage' call. (Bug#10112)
4644 2011-11-23 Chong Yidong <cyd@gnu.org>
4646 * window.c (Fcoordinates_in_window_p): Accept only live windows.
4648 2011-11-23 Martin Rudalics <rudalics@gmx.at>
4650 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
4651 making another buffer current. (Bug#10114)
4653 2011-11-23 Glenn Morris <rgm@gnu.org>
4655 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
4657 2011-11-23 Chong Yidong <cyd@gnu.org>
4659 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
4660 using it (Bug#5984).
4662 2011-11-22 Eli Zaretskii <eliz@gnu.org>
4664 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
4665 and header-lines, as they don't have one computed for them.
4668 * .gdbinit (prow): Make displayed values more self-explaining.
4669 Add row's hash code.
4671 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
4673 * process.c (wait_reading_process_output): Fix asynchrounous
4674 GnuTLS socket handling on some versions of the GnuTLS library.
4675 (wait_reading_process_output): Add comment and URL.
4677 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
4679 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
4681 2011-11-21 Chong Yidong <cyd@gnu.org>
4683 * window.c (Fnext_window, Fprevious_window): Doc fix.
4685 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4687 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
4689 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
4691 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
4693 2011-11-20 Martin Rudalics <rudalics@gmx.at>
4695 * window.c (Fset_window_combination_limit): Rename argument
4697 (Vwindow_combination_limit): Remove "status" from doc-string.
4699 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
4701 * m/ibms390.h: Remove.
4702 * m/ibms390x.h: Don't include "ibms390.h".
4704 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4706 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
4707 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
4709 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
4711 * casetab.c (Fset_case_table):
4712 * charset.c (Fcharset_after): Fix typos.
4714 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
4716 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
4717 Otherwise, valgrind does not work on some platforms.
4718 Problem reported by Andreas Schwab in
4719 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
4720 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
4721 is set, removing the need for VIRT_ADDRESS_VARIES.
4722 (PURE_P): Use a more-efficient implementation that needs just one
4723 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
4724 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
4725 to 4 (xorl, subq, cmpq, setbe).
4726 * alloc.c (pure): Always extern now, since that's the
4727 VIRT_ADDR_VARIES behavior.
4728 (PURE_POINTER_P): Use a single comparison, not two, for
4729 consistency with the new puresize.h.
4730 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
4731 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
4732 Remove VIRT_ADDR_VARIES no longer needed.
4734 2011-11-19 Eli Zaretskii <eliz@gnu.org>
4736 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
4737 (erase_phys_cursor, update_window_cursor, show_mouse_face)
4738 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
4739 behave as if the cursor position were at the window margin.
4741 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
4742 and the cursor position is out of bounds, behave as if the cursor
4743 position were at the window margin. (Bug#10075)
4745 2011-11-18 Chong Yidong <cyd@gnu.org>
4747 * window.c (Fwindow_combination_limit): Make first argument
4748 non-optional, since it is meaningless for live windows like the
4751 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
4753 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
4755 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
4757 * intervals.c: Fix grafting over the whole buffer (bug#10071).
4758 (graft_intervals_into_buffer): Simplify.
4760 2011-11-18 Eli Zaretskii <eliz@gnu.org>
4762 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
4763 hash values of the two rows.
4764 (copy_row_except_pointers): Preserve the used[] arrays and the
4765 hash values of the two rows. (Bug#10035)
4766 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
4768 * xdisp.c (row_hash): New function, body extracted from
4769 compute_line_metrics.
4770 (compute_line_metrics): Call row_hash, instead of computing the
4773 * dispnew.c (verify_row_hash): Call row_hash for computing the
4774 hash code of a row, instead of duplicating code from xdisp.c.
4776 * dispextern.h (row_hash): Add prototype.
4778 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
4780 * frame.c (delete_frame): Don't delete the terminal when the last
4781 X frame is closed if emacs is built with GTK toolkit.
4783 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
4785 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
4787 2011-11-17 Martin Rudalics <rudalics@gmx.at>
4789 * window.c (Vwindow_splits): Rename to
4790 Vwindow_combination_resize. Suggested by Juri Linkov.
4791 (Fsplit_window_internal): Use Vwindow_combination_resize instead
4794 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
4796 * nsfns.m (Fns_font_name):
4797 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
4799 2011-11-16 Martin Rudalics <rudalics@gmx.at>
4801 * window.h (window): Rename slot "nest" to "combination_limit".
4802 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
4803 (Fset_window_nest): Rename to Fset_window_combination_limit.
4804 (Vwindow_nest): Rename to Vwindow_combination_limit.
4805 (recombine_windows, make_parent_window, make_window)
4806 (Fsplit_window_internal, saved_window)
4807 (Fset_window_configuration, save_window_save): Rename all
4808 occurrences of window_nest to window_combination_limit.
4810 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
4812 * image.c (imagemagick_load_image): Fix typo.
4814 2011-11-14 Eli Zaretskii <eliz@gnu.org>
4816 * xdisp.c (display_line): Move the call to
4817 highlight_trailing_whitespace before the call to
4818 compute_line_metrics, since the latter needs to see the final
4819 faces of all the glyphs to compute ROW's hash value.
4820 Fixes assertion violations in row_equal_p. (Bug#10035)
4822 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
4824 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
4825 just return (bug#10044).
4827 2011-11-12 Eli Zaretskii <eliz@gnu.org>
4829 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
4830 with user-defined heap size. Bump the default size of the temacs
4831 heap to 27MB, to avoid memory warning when running temacs.
4832 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
4834 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
4835 current_matrix and desired_matrix. (Bug#9990)
4836 (verify_row_hash) [XASSERTS]: New function.
4837 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
4838 that the hash value of glyph rows is correct.
4840 2011-11-12 Martin Rudalics <rudalics@gmx.at>
4842 * window.h (window): Remove splits slot.
4843 * window.c (Fwindow_splits, Fset_window_splits): Remove.
4844 (Fdelete_other_windows_internal, make_parent_window)
4845 (make_window, Fsplit_window_internal, Fdelete_window_internal)
4846 (Fset_window_configuration, save_window_save): Don't deal with
4847 split status of windows.
4848 (saved_window): Remove splits slot.
4849 (Vwindow_splits): Rewrite doc-string.
4851 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
4853 * xfns.c (unwind_create_frame):
4854 * nsfns.m (unwind_create_frame):
4855 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
4856 Vframe_list (Bug#9999).
4858 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
4860 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
4862 2011-11-11 Kenichi Handa <handa@m17n.org>
4864 * callproc.c (Fcall_process): Set the member dst_multibyte of
4867 2011-11-11 Johan Bockgård <bojohan@gnu.org>
4869 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
4870 avoid a crash (bug#9496).
4872 2011-11-09 Chong Yidong <cyd@gnu.org>
4874 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
4875 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
4877 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4879 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
4881 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4883 Avoid some portability problems by eschewing 'extern inline' functions.
4884 The trivial performance wins aren't worth the portability hassles; see
4885 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
4887 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4888 (window_box_width, window_box_left, window_box_left_offset)
4889 (window_box_right, window_box_right_offset): Undo previous change,
4890 by removing the "extern"s.
4891 * intervals.c (adjust_intervals_for_insertion)
4892 (adjust_intervals_for_deletion): Undo previous change,
4893 making these static again.
4894 (offset_intervals, temp_set_point_both, temp_set_point)
4895 (copy_intervals_to_string): No longer inline.
4896 * xdisp.c (window_text_bottom_y, window_box_width)
4897 (window_box_height, window_box_left_offset)
4898 (window_box_right_offset, window_box_left, window_box_right)
4899 (window_box): No longer inline.
4901 2011-11-08 Chong Yidong <cyd@gnu.org>
4903 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
4904 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
4905 Signal an error if not a live window.
4906 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
4907 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
4909 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
4911 * lisp.h (syms_of_abbrev): Remove declaration.
4912 Reported by CHENG Gao <chenggao@royau.me>.
4914 2011-11-07 Eli Zaretskii <eliz@gnu.org>
4916 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
4917 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
4918 of temacs in GUI mode.
4920 2011-11-07 Martin Rudalics <rudalics@gmx.at>
4922 * window.h: Declare delete_all_child_windows instead of
4923 delete_all_subwindows.
4924 * window.c (Fwindow_nest, Fset_window_nest)
4925 (Fset_window_new_total, Fset_window_new_normal)
4926 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
4927 (delete_all_subwindows): Rename to delete_all_child_windows.
4928 (Fdelete_other_windows_internal, Fset_window_configuration):
4929 Call delete_all_child_windows instead of delete_all_subwindows.
4930 * frame.c (delete_frame): Call delete_all_child_windows instead
4931 of delete_all_subwindows.
4933 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
4935 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
4936 This is also needed for porting to any host where GC_MARK_STACK is
4937 not GC_MAKE_GCPROS_NOOPS.
4938 (which_symbols): Use it.
4940 2011-11-07 Kenichi Handa <handa@m17n.org>
4942 * coding.c (coding_set_destination): Check coding->src_pos only
4943 when coding->src_object is a buffer (bug#9910).
4945 * process.c (send_process): Set the member src_multibyte of coding
4946 to 0 (bug#9911) when sending a unibyte text.
4948 * callproc.c (Fcall_process): Set the member src_multibyte of
4949 process_coding to 0 (bug#9912).
4951 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4953 * xmenu.c (cleanup_widget_value_tree): New function.
4954 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
4955 calling free_menubar_widget_value_tree directly (Bug#9830).
4957 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
4959 Fix some portability problems with 'inline'.
4960 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4961 (window_box_width, window_box_left, window_box_left_offset)
4962 (window_box_right, window_box_right_offset): Declare extern.
4963 Otherwise, these inline functions do not conform to C99 and
4964 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
4965 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
4966 * intervals.c (adjust_intervals_for_insertion)
4967 (adjust_intervals_for_deletion): Now extern, because otherwise the
4968 extern inline functions 'offset_intervals' couldn't refer to it.
4969 (static_offset_intervals): Remove.
4970 (offset_intervals): Rewrite using the old contents of
4971 static_offset_intervals. The old version didn't conform to C99
4972 because an extern inline function contained a reference to an
4973 identifier with static linkage.
4975 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
4977 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
4980 2011-11-06 Eli Zaretskii <eliz@gnu.org>
4982 * xdisp.c (init_iterator, reseat_to_string): Don't set the
4983 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
4984 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
4985 return Qleft_to_right.
4987 2011-11-06 Chong Yidong <cyd@gnu.org>
4989 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
4990 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
4991 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
4992 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
4993 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
4994 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
4995 (Fwindow_vscroll): Doc fix.
4996 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
4997 argument, since it makes no sense to pass a live window and for
4998 consistency with window-child.
5000 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
5002 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
5005 2011-11-05 Jason Rumney <jasonr@gnu.org>
5007 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
5008 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
5010 (add_font_entity_to_list): Fix logic errors in mixed boolean and
5011 bitwise arithmetic preventing use of unicode-sip and non-truetype
5014 2011-11-05 Eli Zaretskii <eliz@gnu.org>
5016 * s/ms-w32.h (fstat, stat, utime): Move redirections to
5019 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
5020 initialization code to keep similarity to xfns.c after changes
5023 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
5025 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
5026 (unwind_create_frame): New function (Bug#9943).
5027 (Fx_create_frame): Restructure code to be more similar to the one in
5028 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
5029 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
5030 Move terminal->reference_count++ just before making the frame official
5033 * nsterm.m (x_free_frame_resources): New function.
5034 (x_destroy_window): Move code to x_free_frame_resources.
5036 * xfns.c (unwind_create_frame): Fix comment.
5037 (Fx_create_frame, x_create_tip_frame):
5038 Move terminal->reference_count++ just before making the frame
5039 official. Move initialization of image_cache_refcount and
5040 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
5042 2011-11-05 Eli Zaretskii <eliz@gnu.org>
5044 Support MSVC build with newer versions of Visual Studio.
5045 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
5046 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
5049 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
5050 which are not supported by MSVC.
5051 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
5052 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
5054 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
5056 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
5058 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
5060 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
5062 Support MSVC build with newer versions of Visual Studio.
5063 * w32.c: Don't include w32api.h for MSVC.
5064 (init_environment) [_MSC_VER]: Call sys_access, not _access.
5066 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
5067 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
5068 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
5069 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
5071 (alloca) [_MSC_VER]: Define to _alloca.
5073 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
5075 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
5077 2011-11-04 Eli Zaretskii <eliz@gnu.org>
5079 * xdisp.c (note_mouse_highlight): If either of
5080 previous/next-single-property-change returns nil, treat that as
5081 the beginning or the end of the buffer. (Bug#9955)
5083 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
5085 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
5086 label is not null (Bug#9951).
5087 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
5090 2011-11-04 Eli Zaretskii <eliz@gnu.org>
5092 * window.c (Fwindow_body_size): Mention in the doc string that the
5093 return value is in frame's canonical units. (Bug#9949)
5095 2011-11-03 Eli Zaretskii <eliz@gnu.org>
5097 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
5099 * w32fns.c (unwind_create_frame): If needed, free the glyph
5100 matrices of the partially constructed frame. (Bug#9943)
5101 * xfns.c (unwind_create_frame): Likewise.
5103 2011-11-01 Eli Zaretskii <eliz@gnu.org>
5105 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
5106 Don't stop backward scan on the continuation glyph, even though
5107 its CHARPOS is positive.
5108 (mouse_face_from_buffer_pos, note_mouse_highlight):
5109 Rename cover_string to disp_string.
5111 2011-11-01 Martin Rudalics <rudalics@gmx.at>
5113 * window.c (temp_output_buffer_show): Don't use
5114 Vtemp_buffer_show_specifiers.
5115 (Vtemp_buffer_show_specifiers): Remove unused variable.
5117 2011-10-30 Eli Zaretskii <eliz@gnu.org>
5119 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
5120 past the beginning of the current glyph matrix.
5122 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
5124 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
5125 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
5126 HAVE_GTK3 (Bug#9869).
5128 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
5129 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
5131 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
5133 * xterm.c: Declare x_handle_net_wm_state to return int.
5134 (handle_one_xevent): Check if we are iconified but don't have
5135 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
5136 (get_current_wm_state): Return non-zero if not hidden,
5137 check for _NET_WM_STATE_HIDDEN (Bug#9893).
5138 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
5139 (x_handle_net_wm_state): Return what get_current_wm_state returns.
5140 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
5142 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
5144 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
5145 so that this new function doesn't get optimized away by a
5146 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
5148 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5150 * frame.h (MOUSE_HL_INFO): Remove excess parens.
5152 2011-10-29 Eli Zaretskii <eliz@gnu.org>
5154 Fix the `xbytecode' command.
5155 * .gdbinit (xprintbytestr): New command.
5156 (xwhichsymbols): Rename from `which'; all callers changed.
5157 (xbytecode): Print the byte-code string as well.
5159 2011-10-29 Kim Storm <storm@cua.dk>
5161 * alloc.c (which_symbols): New function.
5163 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5165 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
5168 2011-10-29 Glenn Morris <rgm@gnu.org>
5170 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
5171 Not clear what it was for, and it causes various bugs. (Bug#9839)
5173 2011-10-28 Eli Zaretskii <eliz@gnu.org>
5175 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
5176 possible random value that matches one of those tested as
5177 condition to clear the mouse face.
5179 2011-10-28 Chong Yidong <cyd@gnu.org>
5181 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
5183 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
5185 * window.c (make_window): Initialize phys_cursor_on_p.
5187 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
5189 * lisp.h (struct Lisp_Symbol): Update comments.
5191 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
5193 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
5195 2011-10-28 Eli Zaretskii <eliz@gnu.org>
5197 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
5198 <oslsachem@gmail.com> for helping to debug this.
5200 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
5201 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
5202 (g_b_init_get_glyph_outline_w): New static variables.
5203 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
5204 (GetGlyphOutlineW_Proc): New typedefs.
5205 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
5206 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
5208 (w32font_open_internal, compute_metrics):
5209 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
5210 instead of calling the "wide" APIs directly.
5212 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
5214 * w32.h (syms_of_w32font): Add prototype.
5216 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
5218 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
5219 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
5220 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
5221 (Fmove_to_window_line): Doc fix.
5223 2011-10-27 Chong Yidong <cyd@gnu.org>
5225 * process.c (make_process): Set gnutls_state to NULL.
5227 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
5228 non-NULL, regardless of GNUTLS_INITSTAGE.
5229 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
5230 an error. Set process slots as soon as we allocate them.
5232 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
5234 2011-10-27 Chong Yidong <cyd@gnu.org>
5236 * gnutls.c (emacs_gnutls_deinit): New function.
5237 Deallocate credentials structures as well as calling gnutls_deinit.
5238 (Fgnutls_deinit, Fgnutls_boot): Use it.
5240 * process.c (make_process): Initialize GnuTLS credentials to NULL.
5241 (deactivate_process): Call emacs_gnutls_deinit.
5243 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
5245 * image.c (x_create_x_image_and_pixmap):
5246 * w32.c (sys_rename, w32_delayed_load):
5247 * w32font.c (fill_in_logfont):
5248 * w32reg.c (x_get_string_resource): Silence compiler warnings.
5250 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
5252 * w32fns.c (w32_default_color_map): New function,
5253 extracted from Fw32_default_color_map.
5254 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5256 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
5258 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
5260 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
5262 * keyboard.c (test_undefined): New function (bug#9751).
5263 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
5265 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
5267 * sysdep.c (init_sys_modes): Fix the check for the controlling
5268 terminal (Bug#6649).
5270 2011-10-20 Eli Zaretskii <eliz@gnu.org>
5272 * dispextern.h (struct bidi_it): New member next_en_type.
5274 * bidi.c (bidi_line_init): Initialize the next_en_type member.
5275 (bidi_resolve_explicit_1): When next_en_pos is valid for the
5276 current character, check also for next_en_type being WEAK_EN.
5277 (bidi_resolve_weak): Don't enter the expensive loop if the current
5278 position is before next_en_pos. Record the bidi type of the first
5279 non-ET, non-BN character we find, in addition to its position.
5280 (bidi_level_of_next_char): Invalidate next_en_type when
5281 next_en_pos is over-stepped.
5283 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
5285 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
5286 * editfns.c: Rewrite current-time-zone so that it invokes
5287 the equivalent of (format-time-string "%Z") to get the time zone name.
5288 This fixes a bug when the time zone name contains characters that
5289 need converting from the system time locale to Emacs internal format.
5290 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
5291 that patch fixed format-time-string to do the conversion, but
5292 I forgot to fix current-time-zone.
5293 (format_time_string): New function, containing most of
5294 what Fformat_time_string used to contain.
5295 (Fformat_time_string): Rewrite in terms of format_time_string.
5296 This doesn't change this function's behavior.
5297 (current-time-zone): Rewrite to use format_time_string.
5298 This fixes the bug reported by Michael Schierl in
5299 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
5300 Jason Rumney's 2007-06-07 change worked around this bug, but
5302 * systime.h (tzname, timezone): Remove no-longer-used declarations.
5304 2011-10-19 Eli Zaretskii <eliz@gnu.org>
5306 * xdisp.c (start_display): If the character at POS is displayed
5307 via a display vector, reset IT->current.dpvec_index to zero.
5308 (try_window_reusing_current_matrix): If a line ends in a display
5309 vector or the next line starts in a display vector, continue
5310 redrawing the window even though the character position of
5311 start_row was reached.
5314 2011-10-18 Chong Yidong <cyd@gnu.org>
5316 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
5317 with nobreak-char-display too.
5319 2011-10-18 Eli Zaretskii <eliz@gnu.org>
5321 Fix part 3 of bug#9771.
5322 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
5323 (bidi_resolve_neutral): Don't enter the expensive loop looking for
5324 non-neutral characters if the current character is a paragraph
5325 separator (a.k.a. Newline). This avoids running the same
5326 expensive loop twice, once when we consume the preceding newline
5327 and the other time when the line actually needs to be displayed.
5328 Avoid the loop when we see neutrals on the base embedding level
5329 following a character whose directionality is the same as the
5330 paragraph's. This avoids running the expensive loop when a line
5331 ends in a long sequence of neutrals, like control characters.
5332 Add assertion against STRONG_AL type. Slightly rearrange code
5333 that determines the type of a neutral given the first non-neutral
5335 (bidi_level_of_next_char): Set next_en_pos to zero when
5336 invalidating its info.
5338 2011-10-17 Eli Zaretskii <eliz@gnu.org>
5340 * xdisp.c (push_display_prop): Determine whether to record string
5341 or buffer position by IT->string, not by IT->method. Allow
5342 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
5343 (move_it_vertically_backward): Don't look for character position
5344 immediately after the newline when in a continuation line.
5347 2011-10-15 Martin Rudalics <rudalics@gmx.at>
5349 * window.c (coordinates_in_window): Rewrite and delabelize
5350 vertical border check. (Bug#5357) (Bug#9618)
5352 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
5354 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
5355 errors in XSetWindowBorder (bug#9310).
5357 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
5359 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
5360 avoid crash when xmalloc overrun checking is enabled.
5362 2011-10-13 Eli Zaretskii <eliz@gnu.org>
5364 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
5365 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
5366 cursor motion with <left> and <right> arrow keys.
5368 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
5369 some callers set that themselves.
5371 2011-10-12 Eli Zaretskii <eliz@gnu.org>
5373 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
5374 display string and the previous row comes from the same string and
5375 is empty. (Bug#9739) (Bug#9738)
5377 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
5379 * doc.c (get_doc_string): Encode file name (bug#9735).
5381 2011-10-12 Eli Zaretskii <eliz@gnu.org>
5383 * bidi.c (bidi_level_of_next_char):
5384 * xdisp.c (get_visually_first_element): Remove old incorrect
5385 comments regarding the Unicode Line Separator character.
5387 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
5389 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
5391 * alloc.c (Fgc_status): Do not access beyond zombies array
5392 boundary if nzombies > MAX_ZOMBIES.
5393 * alloc.c (dump_zombies): Add missing format specifier.
5395 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
5397 * xdisp.c (set_cursor_from_row): Simplify conditionals,
5398 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
5400 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
5401 Some packages use them to denote characters with modifiers.
5403 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
5405 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
5406 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
5407 matching a pp-number. Rename parameter var to var1.
5409 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
5411 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
5413 2011-10-08 Glenn Morris <rgm@gnu.org>
5415 * callint.c (Fcall_interactively): Give a more explicit error for the
5416 'c' case with a non-character input. (Bug#8479)
5418 2011-10-08 Eli Zaretskii <eliz@gnu.org>
5420 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
5422 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
5423 lines that are hscrolled on the left.
5425 * dispnew.c (buffer_posn_from_coords): Account for a possible
5426 presence of header-line. (Bug#4426)
5428 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
5430 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
5431 Don't advertise functionality which we discourage or doesn't work.
5433 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
5435 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
5436 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
5437 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
5438 this makes Emacs dump core during garbage collection on rare
5439 occasions. sizeof is obviously inferior to offsetof here, so
5440 stick with offsetof.
5441 (GC_POINTER_ALIGNMENT): New macro.
5442 (mark_memory): Omit 3rd (offset) arg; caller changed.
5443 Don't assume EMACS_INT alignment is the same as pointer alignment.
5445 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
5447 * keyboard.c (read_key_sequence_remapped): New var.
5448 (read_key_sequence): Compute remapping in the right buffer.
5449 (command_loop_1): Use read_key_sequence's remapping directly.
5451 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
5453 * dired.c (file_name_completion): Don't expand file name.
5454 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
5455 before checking file name handler.
5457 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
5458 they've been requested explicitly (bug#9591).
5460 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
5462 * keymap.c (Fsingle_key_description): Use make_specified_string
5463 instead of build_string to build string from push_key_description.
5466 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5468 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
5469 This fixes a Y2038 bug on 64-bit hosts.
5470 * buffer.c (reset_buffer):
5471 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
5472 (Fclear_buffer_auto_save_failure):
5473 Use 0, not -1, to represent an unset failure time, since time_t
5474 might not be signed.
5476 Remove dependency on glibc malloc internals.
5477 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5478 Move back here from lisp.h, but with their new implementations.
5479 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5480 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
5481 * charset.c (charset_table_init): New static var.
5482 (syms_of_charset): Use it instead of xmalloc. This removes a
5483 dependency on glibc malloc internals. See Eli Zaretskii's comment in
5484 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
5485 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5486 Move back to alloc.c.
5487 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5488 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
5490 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
5492 * nsterm.m (windowDidResize): Call x_set_window_size only when
5493 ns_in_resize is true. Otherwise set pixelwidth/height and
5494 call change_frame_size (Bug#9628).
5496 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5498 Port --enable-checking=all to Fedora 14 x86-64.
5499 * charset.c (syms_of_charset): Also account for glibc malloc's
5500 internal overhead when calculating the initial malloc maximum.
5502 Port --enable-checking=all to Fedora 14 x86.
5503 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5505 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
5506 (overrun_check_realloc, overrun_check_free):
5507 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
5508 That way, xmalloc returns a properly-aligned pointer even if
5509 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
5510 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
5511 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
5512 into account when calculating the initial malloc maximum.
5513 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5514 Move here from alloc.c, so that charset.c can use it too.
5515 Properly align; the old code wasn't right for common 32-bit hosts
5516 when configured with --enable-checking=all.
5517 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5518 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
5520 2011-09-29 Eli Zaretskii <eliz@gnu.org>
5522 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
5525 2011-09-28 Eli Zaretskii <eliz@gnu.org>
5527 * xdisp.c (compute_display_string_end): If there's no display
5528 string at CHARPOS, return -1.
5530 * bidi.c (bidi_fetch_char): When compute_display_string_end
5531 returns a negative value, treat the character as a normal
5532 character not covered by a display string. (Bug#9624)
5534 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
5536 * lread.c (Fread_from_string): Fix typo in docstring.
5538 2011-09-27 Eli Zaretskii <eliz@gnu.org>
5540 * xdisp.c (handle_invisible_prop): If invisible text ends on a
5541 newline, reseat the iterator instead of bidi-iterating there one
5542 character at a time. (Bug#9610)
5543 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
5544 TO_CHARPOS if the bidi iterator is at base embedding level.
5546 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
5548 * lread.c (readevalloop): Use correct code for NBSP.
5549 (read1): Likewise. (Bug#9608)
5551 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
5553 * dbusbind.c (Fdbus_register_signal): When service is not
5554 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
5556 2011-09-25 Glenn Morris <rgm@gnu.org>
5558 * buffer.c (truncate-lines): Doc fix.
5560 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
5562 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
5563 (Fset_window_next_buffers): Doc fix.
5565 2011-09-24 Glenn Morris <rgm@gnu.org>
5567 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
5569 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
5571 Fix minor problems found by static checking.
5572 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
5573 * indent.c (Fvertical_motion): Fix == vs = typo.
5575 2011-09-24 Eli Zaretskii <eliz@gnu.org>
5577 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
5578 Default value is now t. Doc fix.
5580 * indent.c (Fvertical_motion): Compute and apply the overshoot
5581 logic when moving up, not only when moving down. Fix the
5582 confusing name and values of the it_overshoot_expected variable;
5583 logic changes accordingly. (Bug#9254) (Bug#9549)
5585 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
5586 CHARPOS is covered by a display string which includes newlines.
5587 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
5588 is covered by a display string with embedded newlines.
5590 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
5592 * dbusbind.c (Fdbus_register_signal): Add match rule to
5593 Vdbus_registered_objects_table. (Bug#9581)
5594 (Fdbus_register_method, Vdbus_registered_objects_table):
5597 2011-09-24 Jim Meyering <meyering@redhat.com>
5599 do not ignore write error for any output size
5600 The previous change was incomplete.
5601 While it makes emacs --batch detect the vast majority of stdout
5602 write failures, errors were still ignored whenever the output size is
5603 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
5604 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
5605 && echo FAIL: ignored write error
5606 FAIL: ignored write error
5607 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
5608 && echo FAIL: ignored write error
5609 FAIL: ignored write error
5610 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
5612 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
5614 * emacs.c (Fkill_emacs): In noninteractive mode exit
5615 non-successfully if a write error occurred on stdout. (Bug#9574)
5617 2011-09-21 Eli Zaretskii <eliz@gnu.org>
5619 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
5622 * dispextern.h (struct it): Update the comment documenting what
5625 2011-09-20 Eli Zaretskii <eliz@gnu.org>
5627 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
5628 a display string, extend search for cursor position to end of row.
5629 (find_row_edges): If the row ends in a newline from a display
5630 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
5631 Handle the case of a display string with multiple newlines.
5632 (Fcurrent_bidi_paragraph_direction): Fix search for previous
5633 non-empty line. Fixes confusing cursor motion with arrow keys at
5634 the beginning of a line that starts with whitespace.
5636 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5638 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
5641 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
5643 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
5646 2011-09-18 Eli Zaretskii <eliz@gnu.org>
5648 * xdisp.c (display_line): Record maximum and minimum buffer
5649 positions even if no glyphs were produced (e.g., by a zero-width
5650 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
5651 buffer positions that will be removed from the glyph row because
5653 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
5654 column is beyond frame width: don't subtract 1 "pixel" when
5655 computing width of the stretch.
5656 (reseat_at_next_visible_line_start): Undo the change made on
5657 2011-09-17 that saved paragraph information and restored it after
5658 the call to `reseat'. (Bug#9545)
5660 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5662 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
5663 and turn window cursor on if cleared (Bug#9415).
5665 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
5667 * search.c (boyer_moore): Take unibyte characters from pattern
5668 literally. (Bug#9458)
5670 2011-09-18 Eli Zaretskii <eliz@gnu.org>
5672 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
5674 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
5676 Fix minor problem found by static checking.
5677 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
5678 initialized, to pacify gcc -Wuninitialized.
5680 * fileio.c: Report proper errno when syscall falls.
5681 (Finsert_file_contents): Save and restore errno,
5682 so that report_file_error outputs the correct diagnostic.
5683 (Fwrite_region) [CLASH_DETECTION]: Likewise.
5685 2011-09-18 Eli Zaretskii <eliz@gnu.org>
5687 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
5689 2011-09-17 Eli Zaretskii <eliz@gnu.org>
5691 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
5692 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
5694 2011-09-17 Eli Zaretskii <eliz@gnu.org>
5696 * xdisp.c (reseat_at_next_visible_line_start): Keep information
5697 about the current paragraph and restore it after the call to reseat.
5699 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
5700 (bidi_find_paragraph_start): Search back for paragraph beginning
5701 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
5702 (bidi_move_to_visually_next): Only trigger paragraph-related
5703 computations when the last character is a newline or at EOB, not
5704 just any NEUTRAL_B. (Bug#9470)
5706 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
5707 truncated lines if point is covered by a display string. (Bug#9524)
5709 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
5711 * xselect.c: Relax test for outgoing X longs (Bug#9498).
5712 (cons_to_x_long): New function.
5713 (lisp_data_to_selection_data): Use it. Correct the test for
5714 short-versus-long data; it was negated. Break out of vector
5715 loop, for efficiency, when a long datum is discovered.
5717 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
5719 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
5721 2011-09-16 Eli Zaretskii <eliz@gnu.org>
5723 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
5724 GCC PR/17406) by declaring this function with external scope.
5726 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5728 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
5729 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
5731 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
5733 * editfns.c (Fformat): Correctly handle text properties on "%%".
5735 2011-09-15 Eli Zaretskii <eliz@gnu.org>
5737 * xterm.c (x_draw_composite_glyph_string_foreground):
5738 * w32term.c (x_draw_composite_glyph_string_foreground):
5739 * term.c (encode_terminal_code):
5740 * composite.c (composition_update_it, get_composition_id):
5741 * xdisp.c (get_next_display_element)
5742 (fill_composite_glyph_string): Add comments about special meaning
5743 of TAB characters in a composition.
5745 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5747 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
5748 This occurs when processing a multibyte format.
5749 Problem reported by Wolfgang Jenker.
5751 2011-09-15 Johan Bockgård <bojohan@gnu.org>
5753 * xdisp.c (try_cursor_movement): Only check for exact match if
5754 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
5756 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5758 Remove unused external symbols.
5759 * dispextern.h (calc_pixel_width_or_height): Remove decl.
5760 * xdisp.c (calc_pixel_width_or_height): Now static.
5761 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
5762 * indent.c (check_display_width):
5763 * w32term.c: Fix comment to match code.
5764 * xterm.c, xterm.h (x_catching_errors): Remove.
5766 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5768 * xselect.c: Use signed conversions more consistently (Bug#9498).
5769 (selection_data_to_lisp_data): Assume incoming selection data are
5770 signed integers, not unsigned. This is to be consistent with
5771 outgoing selection data, which was modified to use signed integers
5772 in as part of the fix to Bug#9196 in response to Jan D.'s comment
5773 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
5774 expects long, not unsigned long.
5776 2011-09-14 Eli Zaretskii <eliz@gnu.org>
5778 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
5779 computation of loop end. Reported by Johan Bockgård
5782 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
5784 * frame.c (Fother_visible_frames_p): Function deleted.
5786 2011-09-12 Eli Zaretskii <eliz@gnu.org>
5788 * indent.c (compute_motion): Process display vector front to back
5789 rather than the other way around. (Bug#2496)
5791 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
5793 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
5795 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
5797 * minibuf.c (Fread_from_minibuffer): Doc fix.
5799 2011-09-11 Eli Zaretskii <eliz@gnu.org>
5801 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
5802 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
5804 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5806 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
5807 value for non-existent files.
5809 2011-09-11 Eli Zaretskii <eliz@gnu.org>
5811 * fileio.c (Finsert_file_contents): If the file cannot be opened,
5812 set its "size" to -1. This will set the modtime_size field of
5813 the corresponding buffer to -1, which is what
5814 verify-visited-file-modtime expects for files that do not exist.
5817 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
5819 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
5821 * lisp.h: ... from here. push_key_description is no longer
5822 defined in keyboard.c, so its declaration should not be in
5823 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
5824 logically belongs with push_key_description.
5826 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
5828 * buffer.h: Include <sys/types.h> instead of <time.h>.
5829 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
5830 Problem reported by Herbert J. Skuhra.
5832 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
5834 * xml.c (parse_region): Make the parsing work for
5835 non-comment-starting XML files again (bug#9144).
5837 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
5839 * image.c (gif_load): Fix calculation of bottom and right corner.
5842 2011-09-10 Eli Zaretskii <eliz@gnu.org>
5844 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
5845 redisplay in small windows.
5847 2011-09-09 Eli Zaretskii <eliz@gnu.org>
5849 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
5851 2011-09-08 Martin Rudalics <rudalics@gmx.at>
5853 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
5854 Operate on live windows only.
5856 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
5858 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
5860 2011-09-07 Eli Zaretskii <eliz@gnu.org>
5862 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
5863 only under bidi iteration.
5865 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
5867 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
5869 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5871 isnan: Fix porting problem to Solaris 10 with bundled gcc.
5872 Without this fix, the command to link temacs failed due to an
5873 undefined symbol __builtin_isnan. This is because
5874 /usr/include/iso/math_c99.h #defines isnan(x) to
5875 __builtin_isnan(x), but the bundled gcc, which identifies itself
5876 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
5878 * floatfns.c (isnan): #undef, and then #define to a clone of
5880 (Fisnan): Always define, since it's always available now.
5881 (syms_of_floatfns): Always define isnan at the Lisp level.
5883 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5885 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
5887 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5889 * fileio.c: Fix bugs with large file offsets (Bug#9428).
5890 The previous code assumed that file offsets (off_t values) fit in
5891 EMACS_INT variables, which is not true on typical 32-bit hosts.
5892 The code messed up by falsely reporting buffer overflow in cases
5893 such as (insert-file-contents "big" nil 1 2) into an empty buffer
5894 when "big" contains more than 2**29 bytes, even though this
5895 inserts just one byte and does not overflow the buffer.
5896 (Finsert_file_contents): Store file offsets as off_t
5897 values, not as EMACS_INT values. Check for overflow when
5898 converting between EMACS_INT and off_t. When checking for
5899 buffer overflow or for overlap, take the offsets into account.
5900 Don't use EMACS_INT for small values where int suffices.
5901 When checking for overlap, fix a typo: ZV was used where
5902 ZV_BYTE was intended.
5903 (Fwrite_region): Don't assume off_t fits into 'long'.
5904 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
5906 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
5908 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
5910 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5912 sprintf-related integer and memory overflow issues (Bug#9412).
5914 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
5915 (esprintf, exprintf, evxprintf): New functions.
5916 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
5917 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
5918 (modify_event_symbol): Do not assume that the length of
5919 name_alist_or_stem is safe to alloca and fits in int.
5920 (Fexecute_extended_command): Likewise for function name and binding.
5921 (Frecursion_depth): Wrap around reliably on integer overflow.
5922 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
5923 since some callers pass EMACS_INT values.
5924 (Fsingle_key_description): Don't crash if symbol name contains more
5925 than MAX_ALLOCA bytes.
5926 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
5927 (get_minibuffer): Arg is now EMACS_INT, not int.
5928 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
5929 (esprintf, exprintf, evxprintf): New decls.
5930 * window.h (command_loop_level, minibuf_level): Reflect API changes.
5932 * dbusbind.c (signature_cat): New function.
5933 (xd_signature, Fdbus_register_signal):
5934 Do not overrun buffer; instead, report string overflow.
5936 * dispnew.c (add_window_display_history): Don't overrun buffer.
5937 Truncate instead; this is OK since it's just a log.
5939 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
5940 even if the time zone offset is outlandishly large.
5941 Don't mishandle offset == INT_MIN.
5943 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
5944 when creating daemon; the previous buffer-overflow check was incorrect.
5946 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
5947 which has the guts of the old verror function.
5949 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
5950 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
5952 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
5953 (font_unparse_xlfd): Don't blindly alloca long strings.
5954 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
5955 fits in int, when using sprintf. Use single snprintf to count
5956 length of string rather than counting it via multiple sprintfs;
5957 that's simpler and more reliable.
5958 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
5959 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
5960 sprintf, in case result does not fit in int.
5962 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
5963 (fontset_from_font): Print it.
5965 * frame.c (tty_frame_count): Now printmax_t, not int.
5966 (make_terminal_frame, set_term_frame_name): Print it.
5967 (x_report_frame_params): In X, window IDs are unsigned long,
5968 not signed long, so print them as unsigned.
5969 (validate_x_resource_name): Check for implausibly long names,
5970 and don't assume name length fits in 'int'.
5971 (x_get_resource_string): Don't blindly alloca invocation name;
5972 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
5975 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
5976 (xg_check_special_colors, xg_set_geometry):
5977 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
5979 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
5980 Use esprintf, not sprintf, in case result does not fit in int.
5982 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5983 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
5984 it as a large positive number.
5985 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
5986 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5988 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
5989 in case result does not fit in int.
5991 * print.c (float_to_string): Detect width overflow more reliably.
5992 (print_object): Make sprintf buffer a bit bigger, to avoid potential
5993 buffer overrun. Don't assume list length fits in 'int'. Treat
5994 print length of 0 as 0, not as infinity; to be consistent with other
5995 uses of print length in this function. Don't overflow print length
5996 index. Don't assume hash table size fits in 'long', or that
5997 vectorlike size fits in 'unsigned long'.
5999 * process.c (make_process): Use printmax_t, not int, to format
6000 process-name gensyms.
6002 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
6004 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
6005 to avoid potential buffer overrun.
6007 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
6008 if X resource line is longer than 512 bytes.
6010 * xfns.c (x_window): Make sprintf buffer a bit bigger
6011 to avoid potential buffer overrun.
6013 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
6015 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
6017 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
6019 Integer overflow fixes for scrolling, etc.
6020 Without these, Emacs silently mishandles large integers sometimes.
6021 For example, "C-u 4294967297 M-x recenter" was treated as if
6022 it were "C-u 1 M-x recenter" on a typical 64-bit host.
6024 * xdisp.c (try_window_id): Check Emacs fixnum range before
6025 converting to 'int'.
6027 * window.c (window_scroll_line_based, Frecenter):
6028 Check that an Emacs fixnum is in range before assigning it to 'int'.
6029 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
6030 values converted from Emacs fixnums.
6031 (Frecenter): Don't wrap around a line count if it is out of 'int'
6032 range; instead, treat it as an extreme value.
6033 (Fset_window_configuration, compare_window_configurations):
6034 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
6036 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
6037 that can exceed INT_MAX. Check that EMACS_INT value is in range
6038 before assigning it to the (possibly-narrower) index.
6039 (match_limit): Don't assume that a fixnum can fit in 'int'.
6041 * print.c (print_object): Use ptrdiff_t, not int, for index that can
6044 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
6045 (Fvertical_motion): Don't wrap around LINES values that don't fit
6046 in 'int'. Instead, treat them as extreme values. This is good
6047 enough for windows, which can't have more than INT_MAX lines anyway.
6049 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6051 * Require libxml/parser.h to avoid compilation warning.
6053 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
6055 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
6056 since this reportedly can destroy thread storage.
6058 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
6060 * syntax.c (find_defun_start): Update all cache variables if
6061 exiting early (Bug#9401).
6063 2011-08-30 Eli Zaretskii <eliz@gnu.org>
6065 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
6067 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
6068 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
6069 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
6071 * term.c (tty_append_glyph): New function.
6072 (produce_stretch_glyph): Static function and its prototype deleted.
6074 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
6077 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
6079 * image.c (parse_image_spec): Check for nonnegative, not for positive,
6080 when checking :margin (Bug#9390).
6081 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
6082 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
6083 so that the name doesn't mislead. All uses changed.
6085 2011-08-28 Johan Bockgård <bojohan@gnu.org>
6087 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
6090 2011-08-27 Eli Zaretskii <eliz@gnu.org>
6092 * xdisp.c (move_it_to): Don't bail out early when reaching
6093 position beyond to_charpos, if we are scanning backwards.
6094 (move_it_vertically_backward): When DY == 0, make sure we get to
6095 the first character in the line after the newline.
6097 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
6099 * ccl.c: Improve and simplify overflow checking (Bug#9196).
6100 (ccl_driver): Do not generate an out-of-range pointer.
6101 (Fccl_execute_on_string): Remove unnecessary check for
6102 integer overflow, noted by Stefan Monnier in
6103 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
6104 Remove a FIXME that didn't need fixing.
6105 Simplify the newly-introduced buffer reallocation code.
6107 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
6109 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
6111 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
6113 Integer and memory overflow issues (Bug#9196).
6115 * doc.c (get_doc_string): Rework so that
6116 get_doc_string_buffer_size is the actual buffer size, rather than
6117 being 1 less than the actual buffer size; this makes xpalloc more
6120 * image.c (x_allocate_bitmap_record, cache_image):
6121 * xselect.c (Fx_register_dnd_atom):
6122 Simplify previous changes by using xpalloc.
6124 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
6125 since either will do and ptrdiff_t is convenient with xpalloc.
6127 * charset.c (charset_table_size)
6128 (struct charset_sort_data.priority): Now ptrdiff_t.
6129 (charset_compare): Don't overflow if priorities differ greatly.
6130 (Fsort_charsets): Don't assume list length fits in int.
6131 Check for size-calculation overflow when allocating sort data.
6132 (syms_of_charset): Allocate an initial charset table that is
6133 just under 64 KiB, to avoid problems with glibc malloc and mmap.
6135 * cmds.c (internal_self_insert): Check for size-calculation overflow.
6137 * composite.h (struct composition.glyph_len): Now int, not unsigned.
6138 The actual value is always <= INT_MAX, and leaving it unsigned made
6139 overflow checking harder.
6141 * dispextern.h (struct glyph_matrix.rows_allocated)
6142 (struct face_cache.size): Now ptrdiff_t, for convenience in use
6143 with xpalloc. The values are still always <= INT_MAX.
6145 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
6147 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
6148 (SAFE_NALLOCA): New macro.
6150 * region-cache.c (struct boundary.pos, find_cache_boundary)
6151 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
6152 (set_cache_region, invalidate_region_cache)
6153 (revalidate_region_cache, know_region_cache, region_cache_forward)
6154 (region_cache_backward, pp_cache):
6155 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
6156 so that ptrdiff_t * can be passed to xpalloc.
6157 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
6158 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
6159 (pp_cache): Don't assume cache_len fits in int.
6160 * region-cache.h: Adjust extern decls to match.
6162 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
6163 EMACS_INT, since either will do, for xpalloc.
6165 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
6166 (xnmalloc, xnrealloc, xpalloc): New functions.
6168 * bidi.c (bidi_shelve_header_size): New constant.
6169 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
6170 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
6172 * bidi.c (bidi_cache_shrink):
6173 * buffer.c (overlays_at, overlays_in, record_overlay_string)
6175 Don't update size of array until after memory allocation succeeds,
6176 because xmalloc/xrealloc may not return.
6177 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
6178 now that we have proper integer overflow checking.
6179 (record_overlay_string, overlay_strings): Catch overflows when
6180 calculating size of overlay_str_buf.
6182 * callproc.c (Fcall_process): Check for size overflow when
6183 calculating size of args2.
6184 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
6185 Normally we prefer signed values, but sticking with ptrdiff_t would
6186 require adding more-complicated checks.
6188 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
6189 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
6190 Redo buffer-overflow calculations to avoid integer overflow.
6191 Add a FIXME comment where memory seems to be over-allocated.
6193 * character.c (Fstring): Check for size-calculation overflow.
6195 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
6196 unnecessary integer overflow. Check for size overflow.
6197 (encode_coding_object): Don't update size until xmalloc succeeds.
6199 * composite.c (get_composition_id): Check for overflow in glyph
6200 length calculations.
6202 Integer and memory overflow fixes for display code.
6203 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
6204 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
6205 (scrolling_window): Check for overflow in size calculations.
6206 (line_draw_cost, realloc_glyph_pool, add_row_entry):
6207 Don't assume glyph table len fits in int.
6208 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
6209 (row_table_size): Now ptrdiff_t, not int.
6210 (scrolling_window): Avoid overflow in size calculations.
6211 Don't update size until allocation succeeds.
6212 * fns.c (concat): Check for overflow in size calculations.
6213 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
6214 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6215 (NEXT_ALMOST_PRIME_LIMIT): New constant.
6217 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
6218 (get_doc_string): Check for size calculation overflow.
6219 Don't update size until allocation succeeds.
6220 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
6221 EMACS_INT, where ptrdiff_t will do.
6222 (Fsubstitute_command_keys): Check for string overflow.
6224 * editfns.c (set_time_zone_rule): Don't assume environment length
6226 (message_length): Now ptrdiff_t, not int.
6227 (Fmessage_box): Don't update size until allocation succeeds.
6228 Don't assume message length fits in int.
6229 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
6231 * emacs.c (main): Do not reallocate argv, since there is a null at
6232 the end that can be overwritten, and this way there's no need to
6233 worry about size-calculation overflow.
6234 (sort_args): Check for size-calculation overflow.
6236 * eval.c (init_eval_once, grow_specpdl): Don't update size until
6238 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
6240 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
6241 (x_set_scroll_bar_width, x_figure_window_size):
6242 Check for integer overflow.
6243 (x_set_alpha): Do not assume XINT fits in int.
6245 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
6246 This is for the members text_lines, text_cols, total_lines, total_cols,
6247 where the system imposes an 'int' limit.
6249 * fringe.c (Fdefine_fringe_bitmap):
6250 Don't update size until alloc works.
6252 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
6253 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
6255 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
6256 Check for size-calculation overflow.
6257 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
6258 do, as we prefer signed integers.
6259 (id_to_widget.max_size, id_to_widget.used)
6260 (xg_store_widget_in_map, xg_remove_widget_from_map)
6261 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
6262 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
6263 Use and return ptrdiff_t, not int.
6264 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
6265 * gtkutil.h: Change prototypes to match the above.
6267 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
6268 are duplicate now that they've been promoted to lisp.h.
6269 (x_allocate_bitmap_record, x_alloc_image_color)
6270 (make_image_cache, cache_image, xpm_load):
6271 Don't update size until alloc is done.
6272 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
6274 Check for size calculation overflow.
6275 (ct_colors_allocated_max): New constant.
6276 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
6279 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
6280 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
6281 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
6282 Use ptrdiff_t, not int, to count maps.
6283 (read_char_minibuf_menu_prompt): Check for overflow in size
6284 calculations. Don't update size until allocation succeeds.
6285 Redo calculations to avoid overflow.
6286 * keyboard.h: Change prototypes to match the above.
6288 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
6290 (current_minor_maps): Check for size calculation overflow.
6291 * keymap.h: Change prototypes to match the above.
6293 * lread.c (read1, init_obarray): Don't update size until alloc done.
6295 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
6296 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
6298 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
6299 Now ptrdiff_t, not int.
6300 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
6301 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
6303 * process.c (Fnetwork_interface_list): Check for overflow
6304 in size calculation.
6306 * region-cache.c (move_cache_gap): Check for size calculation overflow.
6308 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
6309 overflow. Don't bother calling xmalloc when xrealloc will do.
6311 * search.c (Freplace_match): Check for size calculation overflow.
6312 (Fset_match_data): Don't assume list lengths fit in 'int'.
6314 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
6315 for command line length. Do not attempt to address one before the
6316 beginning of an array, as that's not portable.
6318 * term.c (max_frame_lines): Remove; unused.
6319 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
6321 (encode_terminal_code, calculate_costs): Check for size
6322 calculation overflow.
6323 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
6324 table lengths and related sizes. Don't update size until alloc
6325 done. Redo calculations to avoid overflow.
6326 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
6328 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
6329 subtracting pointers.
6330 (gobble_line): Check for overflow more carefully. Don't update size
6333 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
6334 Don't update size until alloc done.
6335 Redo size calculations to avoid overflow.
6336 Check for size calculation overflow.
6337 (main) [DEBUG]: Fix typo in invoking tparam1.
6339 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
6340 Use ptrdiff_t, not int, for sizes.
6341 (store_mode_line_noprop_char): Don't update size until alloc done.
6343 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
6344 Use ptrdiff_t, not int, for sizes.
6345 (Finternal_make_lisp_face, cache_face):
6346 Check for size calculation overflow.
6347 (cache_face): Treat size calculation overflows as if they were
6348 memory exhaustion (the usual treatment), rather than aborting.
6350 * xfns.c (x_encode_text, x_set_name_internal)
6351 (Fx_change_window_property): Use ptrdiff_t, not int, to count
6352 sizes, since they can exceed INT_MAX in size. Check for size
6353 calculation overflow.
6355 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
6356 (xg_select): Check for size calculation overflow.
6357 Don't update size until alloc done.
6359 * xrdb.c (get_environ_db): Don't assume path length fits in int,
6360 as sprintf is limited to int lengths.
6362 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
6363 (X_LONG_MIN): New macros.
6364 Use them to make the following changes clearer.
6365 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
6366 This change doesn't affect the value now, but it may help remind
6367 future maintainers not to raise the value too much later.
6368 (SELECTION_QUANTUM): Remove, replacing with ...
6369 (selection_quantum): ... new function, which avoids overflow.
6371 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
6372 assumption that selection length fits in 'int'.
6373 (x_reply_selection_request, x_handle_selection_request)
6374 (x_get_window_property, receive_incremental_selection)
6375 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
6376 (lisp_data_to_selection_data, clean_local_selection_data):
6377 Use ptrdiff_t, not int, to record length of selection.
6378 (x_reply_selection_request, x_get_window_property)
6379 (receive_incremental_selection, x_property_data_to_lisp):
6380 Redo calculations to avoid overflow.
6381 (x_reply_selection_request): When sending hint, ceiling it at
6382 X_LONG_MAX rather than relying on wraparound overflow to send
6384 (x_get_window_property, receive_incremental_selection)
6385 (lisp_data_to_selection_data, x_property_data_to_lisp):
6386 Check for size-calculation overflow.
6387 (x_get_window_property, receive_incremental_selection)
6388 (lisp_data_to_selection_data, Fx_register_dnd_atom):
6389 Don't store size until memory allocation succeeds.
6390 (x_get_window_property): Plug memory leak on memory exhaustion.
6391 Don't double-block input; malloc is safe here. Don't assume 2**34
6392 - 4 fits in unsigned long. Add an xassert to check
6393 XGetWindowProperty overflow. Be more careful about overflow
6394 calculations, and distinguish size from memory overflow better.
6395 (receive_incremental_selection): When tracing, don't assume
6396 unsigned int is less than INT_MAX.
6397 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
6398 harmful) conversions of unsigned short to int.
6399 (lisp_data_to_selection_data): Don't assume that integers
6400 in the range -65535 through -1 fit in an X unsigned short.
6401 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
6402 result parameters unless successful. Rely on cons_to_unsigned
6403 to report problems with elements; the old code wasn't right anyway.
6404 (x_check_property_data): Check for int overflow; we cannot use
6405 a wider type due to X limits.
6406 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
6408 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
6410 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
6411 (x_term_init): Check for size calculation overflow.
6412 (x_color_cells): Don't store size until memory allocation succeeds.
6413 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
6414 Don't assume alloca size is less than MAX_ALLOCA.
6415 (x_term_init): Don't assume length fits in int (sprintf is limited
6418 Use ptrdiff_t for composition IDs.
6419 * character.c (lisp_string_width):
6420 * composite.c (composition_table_size, n_compositions)
6421 (get_composition_id, composition_gstring_from_id):
6422 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
6423 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
6424 * window.c (Frecenter):
6425 Use ptrdiff_t, not int, for composition IDs.
6426 * composite.c (get_composition_id): Check for integer overflow.
6427 * composite.h: Adjust prototypes to match the above changes.
6429 Use ptrdiff_t for hash table indexes.
6430 * category.c (hash_get_category_set):
6431 * ccl.c (ccl_driver):
6432 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
6433 * coding.c (coding_system_charset_list, detect_coding_system):
6434 * coding.h (struct coding_system.id):
6435 * composite.c (get_composition_id, gstring_lookup_cache):
6436 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
6437 * image.c (xpm_get_color_table_h):
6438 * lisp.h (hash_lookup, hash_put):
6439 * minibuf.c (Ftest_completion):
6440 Use ptrdiff_t for hash table indexes, not int (which is too
6441 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
6442 32-bit --with-wide-int hosts).
6444 * charset.c (Fdefine_charset_internal): Check for integer overflow.
6445 Add a FIXME comment about memory leaks.
6446 (syms_of_charset): Don't assume xmalloc returns.
6448 Don't assume that stated character widths fit in int.
6449 * character.c (Fchar_width, c_string_width, lisp_string_width):
6450 * character.h (CHAR_WIDTH):
6451 * indent.c (MULTIBYTE_BYTES_WIDTH):
6452 Use sanitize_char_width to avoid undefined and/or bad behavior
6453 with outlandish widths.
6454 * character.h (sanitize_tab_width): Rename from sanitize_width,
6455 now that we have two such functions. All uses changed.
6456 (sanitize_char_width): New inline function.
6458 Don't assume that tab-width fits in int.
6459 * character.h (sanitize_width): New inline function.
6460 (SANE_TAB_WIDTH): New macro.
6461 (ASCII_CHAR_WIDTH): Use it.
6462 * indent.c (sane_tab_width): Remove. All uses replaced by
6463 SANE_TAB_WIDTH (current_buffer).
6464 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
6466 * fileio.c: Integer overflow issues with file modes.
6467 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
6469 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
6470 Remove unreachable code.
6471 (read_hex, load_charset_map_from_file): Check for integer overflow.
6473 * xterm.c: Don't go over XClientMessageEvent limit.
6474 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
6475 (x_send_scroll_bar_event): Likewise. Check that the size does not
6476 exceed limits imposed by XClientMessageEvent, as well as the usual
6477 ptrdiff_t and size_t limits.
6479 * keyboard.c: Overflow, signedness and related fixes.
6480 (make_lispy_movement): Use same integer type in forward decl
6481 that is used in the definition.
6482 (read_key_sequence, keyremap_step):
6483 Change bufsize argument back to int, undoing my 2011-03-30 change.
6484 We prefer signed types, and int is wide enough here.
6485 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
6486 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
6487 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
6488 length, not size_t. Use ptrdiff_t for index, not int.
6489 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
6490 possibility of integer overflow.
6492 Overflow, signedness and related fixes for images.
6494 * dispextern.h (struct it.stack[0].u.image.image_id)
6495 (struct_it.image_id, struct image.id, struct image_cache.size)
6496 (struct image_cache.used, struct image_cache.ref_count):
6497 * gtkutil.c (update_frame_tool_bar):
6498 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
6499 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
6500 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
6501 * nsmenu.m (update_frame_tool_bar):
6502 * xdisp.c (calc_pixel_width_or_height):
6503 * xfns.c (image_cache_refcount):
6504 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
6505 on typical 64-bit hosts.
6507 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6508 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
6509 Omit unnecessary casts to int.
6510 (parse_image_spec): Check that integers fall into 'int' range
6511 when the callers expect that.
6512 (image_ascent): Redo ascent calculation to avoid int overflow.
6513 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
6514 (lookup_image): Remove unnecessary tests.
6515 (xbm_image_p): Locals are now of int, not EMACS_INT,
6516 since parse_image_check makes sure they fit into int.
6517 (png_load, gif_load, svg_load_image):
6518 Prefer int to unsigned where either will do.
6519 (tiff_handler): New function, combining the cores of the
6520 old tiff_error_handler and tiff_warning_handler.
6521 This function is rewritten to use vsnprintf and thereby avoid
6522 stack buffer overflows. It uses only the features of vsnprintf
6523 that are common to both POSIX and native Microsoft.
6524 (tiff_error_handler, tiff_warning_handler): Use it.
6525 (tiff_load, gif_load, imagemagick_load_image):
6526 Don't assume :index value fits in 'int'.
6527 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
6528 (imagemagick_load_image): Check that crop parameters fit into
6529 the integer types that MagickCropImage accepts. Don't assume
6530 Vimagemagick_render_type has a nonnegative value. Don't assume
6531 size_t fits in 'long'.
6532 (gs_load): Use printmax_t to print the widest integers possible.
6533 Check for integer overflow when computing image height and width.
6535 2011-08-26 Eli Zaretskii <eliz@gnu.org>
6537 * xdisp.c (redisplay_window): Don't force window start if point
6538 will be invisible in the resulting window. (Bug#9324)
6540 2011-08-25 Eli Zaretskii <eliz@gnu.org>
6542 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
6543 the display spec is of the form `(space ...)'.
6544 (handle_display_spec): Return the value returned by
6545 handle_single_display_spec, not just 1 or zero.
6546 (handle_single_display_spec): If the display spec is of the form
6547 `(space ...)', and specifies display in the text area, return 2
6549 (try_cursor_movement): Check for the need to scroll more
6550 accurately, and prefer exact match for point under bidi.
6551 Don't advance `row' beyond the last row of the window.
6553 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
6554 into disp_prop; all users changed.
6556 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
6557 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
6558 for the text covered by the display property.
6560 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
6562 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
6563 Change return value to nil.
6564 (Frecord_buffer): Delete unused function.
6566 2011-08-24 Eli Zaretskii <eliz@gnu.org>
6568 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
6569 buffers, return left-to-right.
6570 (set_cursor_from_row): Consider candidate row a win if its glyph
6571 represents a newline and point is on that newline. Fixes cursor
6572 positioning on the newline at EOL of R2L text within L2R
6573 paragraph, and vice versa.
6574 (try_cursor_movement): Check continued rows, in addition to
6575 continuation rows. Fixes unwarranted scroll when point enters a
6576 continued line of R2L text within an L2R paragraph, or vice versa.
6577 (cursor_row_p): Consider the case of point being equal to
6578 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
6579 from the end of a short line to the beginning of a continued line
6580 of R2L text within L2R paragraph.
6581 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
6582 composed characters.
6584 * bidi.c (bidi_check_type): Use xassert.
6585 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
6588 2011-08-23 Eli Zaretskii <eliz@gnu.org>
6590 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
6593 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
6595 * nsfont.m (ns_otf_to_script): Fix typo.
6597 2011-08-22 Kenichi Handa <handa@m17n.org>
6599 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
6600 extra slot even if the purpose is char-code-property-table.
6602 2011-08-23 Eli Zaretskii <eliz@gnu.org>
6604 * xdisp.c (redisplay_window): When computing centering_position,
6605 account for the height of the header line. (Bug#8874)
6607 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
6608 instead of CHAR_TO_BYTE. Fixes a crash when a completion
6609 candidate is selected by the mouse, and that candidate has a
6610 composed character under the mouse.
6612 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
6613 coordinates reported by pos-visible-in-window-p for a composed
6614 character in column zero.
6616 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
6618 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
6620 2011-08-22 Eli Zaretskii <eliz@gnu.org>
6622 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
6623 consider it a hit if to_charpos is anywhere in the range of the
6624 composed buffer positions.
6626 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
6628 * image.c (gif_load): Don't assume that each subimage has the same
6629 dimensions as the base image. Handle disposal method that is
6630 "undefined" by the gif spec (Bug#9335).
6632 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
6634 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
6635 (Fcondition_case): Document `debug' symbol in error handler.
6637 2011-08-19 Eli Zaretskii <eliz@gnu.org>
6639 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
6640 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
6641 from an Org mode buffer to a Speedbar frame.
6643 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
6644 a composition, take its buffer position from IT->cmp_it.charpos.
6645 Fixes cursor positioning at the beginning of a line that begins
6646 with a composed character.
6648 2011-08-18 Eli Zaretskii <eliz@gnu.org>
6650 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
6651 character bidirectional type, use STRONG_L instead. Fixes crashes
6652 in a buffer produced by `describe-categories'.
6654 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
6655 members before the level stack, so they would be saved and
6656 restored when copying iterator state. Fixes incorrect reordering
6657 around TABs covered by display properties.
6659 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
6661 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
6663 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
6665 * eval.c (internal_condition_case, internal_condition_case_1)
6666 (internal_condition_case_2, internal_condition_case_n):
6667 Remove unnecessary aborts (Bug#9081).
6669 2011-08-17 Eli Zaretskii <eliz@gnu.org>
6671 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
6672 has no `load' handler, try opening the file locally. (Bug#9311)
6674 2011-08-16 Ken Brown <kbrown@cornell.edu>
6676 * gmalloc.c: Expand comment.
6678 2011-08-16 Eli Zaretskii <eliz@gnu.org>
6680 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
6681 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
6683 2011-08-16 Ken Brown <kbrown@cornell.edu>
6685 Fix memory allocation problems in Cygwin build (Bug#9273).
6687 * unexcw.c ( __malloc_initialized): Declare external variable.
6688 (fixup_executable): Force the dumped emacs to reinitialize malloc.
6690 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
6692 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
6694 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
6696 [CYGWIN] (special_realloc): New function.
6697 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
6698 requests to realloc storage in the static heap.
6700 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
6702 * bidi.c (bidi_initialize): Remove unused local.
6704 2011-08-15 Eli Zaretskii <eliz@gnu.org>
6707 * biditype.h: Remove file.
6708 * makefile.w32-in ($(BLD)/bidi.$(O)):
6709 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
6711 * dispextern.h: Fix a typo in the comment to bidi_type_t.
6713 * chartab.c: Improve commentary for the uniprop_table API.
6715 * bidi.c (bidi_paragraph_init): Support zero value of
6716 bidi_ignore_explicit_marks_for_paragraph_level.
6717 (bidi_initialize): Use uniprop_table instead of including
6718 biditype.h and bidimirror.h.
6720 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
6721 coordinates of the iterator when restoring from ppos_it.
6724 2011-08-14 Kenichi Handa <handa@m17n.org>
6726 * process.c (create_process): Call setup_process_coding_systems
6727 after the pid of the process is set to -1 (Bug#8162).
6729 2011-08-14 Eli Zaretskii <eliz@gnu.org>
6731 * xdisp.c (move_it_in_display_line_to): Don't invoke
6732 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
6733 ppos_it. Fixes vertical cursor motion when line beginning is
6734 covered by an image. (Bug#9296)
6736 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
6738 * nsterm.h (ns_run_ascript): Declare.
6739 (NSAPP_DATA2_RUNASSCRIPT): Define.
6741 * nsfns.m (as_script, as_result, as_status): New static variables.
6742 (ns_run_ascript): New function.
6743 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
6744 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
6745 the event loop. Get status from as_status (Bug#7276).
6747 * nsterm.m (sendEvent): If event is NSApplicationDefined and
6748 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
6749 the event loop (Bug#7276).
6751 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
6753 * gnutls.c (QCgnutls_bootprop_priority)
6754 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
6755 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
6756 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
6757 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
6758 (QCgnutls_bootprop_verify_hostname_error)
6759 (QCgnutls_bootprop_callbacks_verify): Rename from
6760 Qgnutls_bootprop_..., all uses changed.
6762 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
6765 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
6767 * xfaces.c (Qframe_set_background_mode): Now static.
6768 * dispextern.h (Qframe_set_background_mode): Remove decl.
6770 * process.c (Fnetwork_interface_info): Declare local only if needed.
6772 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
6774 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
6775 (Fnetwork_interface_list): Allocate in increments of bytes instead
6776 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
6777 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
6779 (struct ifflag_def): notrailers is smart on OSX.
6780 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
6781 Get hardware address with getifaddrs if available.
6783 2011-08-12 Eli Zaretskii <eliz@gnu.org>
6785 * xdisp.c (iterate_out_of_display_property): xassert that
6786 IT->position is set to within IT->object's boundaries. Break from
6787 the loop as soon as EOB is reached; avoids infloops in redisplay
6788 when IT->position is set up wrongly due to some bug.
6789 Set IT->current to match the bidi iterator unconditionally.
6790 (push_display_prop): Allow GET_FROM_STRING as IT->method on
6791 entry. Force push_it to save on the stack the current
6792 buffer/string position, to be restored by pop_it. Fix flags in
6793 the iterator structure wrt the object coming from a display
6794 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
6795 properties. (Bug#9284)
6797 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
6799 * fontset.c (fontset_get_font_group): Add proper type checks.
6802 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6804 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
6805 and LC_VERSION_MIN_MACOSX.
6806 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
6807 (dump_it) [LC_FUNCTION_STARTS]: Use it.
6809 2011-08-08 Eli Zaretskii <eliz@gnu.org>
6811 * xdisp.c (forward_to_next_line_start): Allow to use the
6812 no-display-properties-and-no-overlays under bidi display.
6813 Set disp_pos in the bidi iterator to avoid searches for display
6814 properties and overlays.
6816 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
6818 * editfns.c (Fset_time_zone_rule): Document relationship with the
6821 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
6822 the font entity extracted from the cache (Bug#8109).
6824 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
6826 * composite.c (autocmp_chars): Don't reset point. That is done by
6827 restore_point_unwind (Bug#5984).
6829 2011-08-07 Juri Linkov <juri@jurta.org>
6831 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
6832 to show the arg `TIME' instead of `TIMEVAL'.
6834 2011-08-06 Eli Zaretskii <eliz@gnu.org>
6836 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
6837 display property strides EOL and includes a newline, as in
6838 longlines-mode. (Bug#9254)
6839 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
6840 word-wrap under bidirectional display. (Bug#9224)
6842 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
6843 is non-zero, even if the data buffer is NULL. Fixes a crash in
6844 vertical-motion with longlines-mode. (Bug#9254)
6846 2011-08-05 Eli Zaretskii <eliz@gnu.org>
6848 * bidi.c <bidi_cache_total_alloc>: Now static.
6849 (bidi_initialize): Initialize bidi_cache_total_alloc.
6851 * xdisp.c (display_line): Release buffer allocated for shelved bidi
6854 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
6855 amount allocated this far in `bidi_cache_total_alloc'.
6856 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
6857 non-zero, only free the data buffer without restoring the cache
6858 contents. All callers changed.
6860 * dispextern.h (bidi_unshelve_cache): Update prototype.
6862 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
6863 (move_it_in_display_line, move_it_to)
6864 (move_it_vertically_backward, move_it_by_lines): Replace the call
6865 to xfree to an equivalent call to bidi_unshelve_cache.
6866 (move_it_in_display_line_to): Fix logic of returning
6867 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
6869 2011-08-05 Eli Zaretskii <eliz@gnu.org>
6871 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
6872 came from a string character with a `cursor' property. (Bug#9229)
6874 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6876 * Makefile.in (LIB_PTHREAD): New variable.
6877 (LIBES): Add LIB_PTHREAD (Bug#9216).
6879 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
6880 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
6882 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
6884 * regex.c (re_iswctype): Remove some redundant boolean conversions.
6886 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6888 * xterm.c (x_find_topmost_parent): New function.
6889 (x_set_frame_alpha): Find topmost parent window with
6890 x_find_topmost_parent and set the property there also (bug#9181).
6891 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
6893 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
6895 * callproc.c (Fcall_process): Avoid vfork clobbering
6896 the local vars buffer, coding_systems, current_dir.
6898 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
6900 * keymap.c (Fmake_composed_keymap): Move to subr.el.
6902 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
6904 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
6905 so that it is not optimized away.
6907 * xdisp.c (compute_display_string_pos): Remove unused local.
6909 2011-08-02 Eli Zaretskii <eliz@gnu.org>
6911 Fix slow cursor motion and scrolling in large buffers with
6912 selective display, like Org Mode buffers. (Bug#9218)
6914 * dispextern.h (struct bidi_it): New member disp_prop_p.
6916 * xdisp.c: Remove one-slot cache of display string positions.
6917 (compute_display_string_pos): Accept an additional argument
6918 DISP_PROP_P; callers changed. Scan at most 5K characters forward
6919 for a display string or property. If found, set DISP_PROP_P
6922 * bidi.c (bidi_fetch_char): Accept an additional argument
6923 DISP_PROP_P, and pass it to compute_display_string_pos.
6924 Only handle text covered by a display string if DISP_PROP_P is returned
6925 non-zero. All callers of bidi_fetch_char changed.
6927 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
6929 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
6931 2010-12-03 Don March <don@ohspite.net>
6933 * keymap.c (Fdefine_key): Fix non-prefix key error message when
6934 last character M-[char] is translated to ESC [char] (bug#7541).
6936 2011-08-02 Kenichi Handa <handa@m17n.org>
6938 * lisp.h (uniprop_table): Extern it.
6940 * chartab.c (uniprop_table): Make it non-static.
6942 2011-08-01 Eli Zaretskii <eliz@gnu.org>
6944 * xdisp.c (forward_to_next_line_start): Accept additional argument
6945 BIDI_IT_PREV, and store into it the state of the bidi iterator had
6947 (reseat_at_next_visible_line_start): Use the bidi iterator state
6948 returned by forward_to_next_line_start to restore the state of
6949 it->bidi_it after backing up to previous newline. (Bug#9212)
6951 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
6953 * regex.c (re_comp): Protoize.
6954 (re_exec): Fix return type.
6955 (regexec): Fix type of `ret'. (Bug#9203)
6957 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6959 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
6960 This is needed if max-image-size is a floating-point number.
6962 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6964 * print.c (print_object): Print empty symbol as ##.
6966 * lread.c (read1): Read ## as empty symbol.
6968 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6970 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
6971 setting frame foreground color (Bug#9175).
6972 (x_set_background_color): Likewise.
6974 * nsmenu.m (-setText): Size tooltip dimensions precisely to
6975 contents (Bug#9176).
6976 (EmacsTooltip -init): Remove bezels and add shadows to
6979 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
6980 or scroll bar (Bug#8470).
6982 * nsfont.m (nsfont_open): Remove assignment to voffset and
6983 unnecessary vars hshink, expand, hd, full_height, min_height.
6984 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
6986 * nsterm.h (nsfont_info): Remove voffset field.
6988 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6990 Implement strike-through and overline on NextStep (Bug#8863).
6992 * nsfont.m (nsfont_open): Use underline position provided by font,
6993 instead of hard-coded value of 2.
6994 (nsfont_draw): Call ns_draw_text_decoration instead.
6996 * nsterm.h: Add declaration for ns_draw_text_decoration.
6998 * nsterm.m (ns_draw_text_decoration): New function for drawing
6999 underline, overline, and strike-through.
7000 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
7001 ns_draw_text_decoration. Change treatment of cursor drawing to
7002 accommodate underlining, etc.
7004 2011-07-28 Eli Zaretskii <eliz@gnu.org>
7006 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
7009 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7011 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
7012 Without this fix, if a signal arrives just after memory fills up,
7013 'malloc' might be invoked reentrantly.
7015 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
7016 In other words, assume that every image size is allowed, on non-X
7017 hosts. This assumption is probably wrong, but it lets Emacs compile.
7019 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7021 * regex.c (re_iswctype): Convert return values to boolean.
7023 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
7025 * xdisp.c (compute_display_string_pos): Don't use cached display
7026 string position if the buffer had its restriction changed.
7029 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7031 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7033 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7035 Integer signedness and overflow and related fixes. (Bug#9079)
7037 * bidi.c: Integer size and overflow fixes.
7038 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
7039 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
7040 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7041 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
7042 (bidi_find_other_level_edge):
7043 Use ptrdiff_t instead of EMACS_INT where either will do.
7044 This works better on 32-bit hosts configured --with-wide-int.
7045 (bidi_cache_ensure_space): Check for size-calculation overflow.
7046 Use % rather than repeated addition, for better worst-case speed.
7047 Don't set bidi_cache_size until after xrealloc returns, because it
7049 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
7050 (bidi_cache_ensure_space): Also check that the bidi cache size
7051 does not exceed that of the largest Lisp string or buffer. See Eli
7052 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
7054 * alloc.c (__malloc_size_t): Remove.
7055 All uses replaced by size_t. See Andreas Schwab's note
7056 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
7058 * image.c: Improve checking for integer overflow.
7059 (check_image_size): Assume that f is nonnull, since
7060 it is always nonnull in practice. This is one less thing to
7061 worry about when checking for integer overflow later.
7062 (x_check_image_size): New function, which checks for integer
7063 overflow issues inside X.
7064 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
7065 This removes the need for a memory_full check.
7066 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
7067 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
7068 (xbm_read_bitmap_data): Change locals back to 'int', since
7069 their values must fit in 'int'.
7070 (xpm_load_image, png_load, tiff_load):
7071 Invoke x_create_x_image_and_pixmap earlier,
7072 to avoid much needless work if the image is too large.
7073 (tiff_load): Treat overly large images as if
7074 x_create_x_image_and_pixmap failed, not as malloc failures.
7075 (gs_load): Use x_check_image_size.
7077 * gtkutil.c: Omit integer casts.
7078 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
7079 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
7081 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
7083 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
7084 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
7085 would wrongly return t on a 64-bit host.
7087 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
7088 The plain *_OVERFLOW macros run afoul of GCC bug 49705
7089 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
7090 and therefore cause GCC to emit a bogus diagnostic in some cases.
7092 * image.c: Integer signedness and overflow and related fixes.
7093 This is not an exhaustive set of fixes, but it's time to
7094 record what I've got.
7095 (lookup_pixel_color, check_image_size): Remove redundant decls.
7096 (check_image_size): Don't assume that arbitrary EMACS_INT values
7097 fit in 'int', or that arbitrary 'double' values fit in 'int'.
7098 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
7099 (tiff_load, imagemagick_load_image):
7100 Check for overflow in size calculations.
7101 (x_create_x_image_and_pixmap): Remove unnecessary test for
7102 xmalloc returning NULL; that can't happen.
7103 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
7104 (xpm_color_bucket): Use better integer hashing function.
7105 (xpm_cache_color): Don't possibly over-allocate memory.
7106 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
7107 (gif_memory_source):
7108 Use ptrdiff_t, not int or size_t, to record sizes.
7109 (png_load): Don't assume values greater than 2**31 fit in 'int'.
7110 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
7111 either works, as we prefer signed integers.
7112 (tiff_read_from_memory, tiff_write_from_memory):
7113 Return tsize_t, not size_t, since that's what the TIFF API wants.
7114 (tiff_read_from_memory): Don't fail simply because the read would
7115 go past EOF; instead, return a short read.
7116 (tiff_load): Omit no-longer-needed casts.
7117 (Fimagemagick_types): Don't assume size fits into 'int'.
7119 Improve hashing quality when configured --with-wide-int.
7120 * fns.c (hash_string): New function, taken from sxhash_string.
7121 Do not discard information about ASCII character case; this
7122 discarding is no longer needed.
7123 (sxhash-string): Use it. Change sig to match it. Caller changed.
7124 * lisp.h: Declare it.
7125 * lread.c (hash_string): Remove, since we now use fns.c's version.
7126 The fns.c version returns a wider integer if --with-wide-int is
7127 specified, so this should help the quality of the hashing a bit.
7129 * emacs.c: Integer overflow minor fix.
7130 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
7131 Define only if GNU_LINUX.
7132 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
7134 * dispnew.c: Integer signedness and overflow fixes.
7135 Remove unnecessary forward decls, that were a maintenance hassle.
7136 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
7138 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
7139 (scrolling_window): Use ptrdiff_t, not int, for byte count.
7140 (prepare_desired_row, line_draw_cost):
7141 Use int, not unsigned, where either works.
7142 (save_current_matrix, restore_current_matrix):
7143 Use ptrdiff_t, not size_t, where either works.
7144 (init_display): Check for overflow more accurately, and without
7145 relying on undefined behavior.
7147 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
7148 Remove, replacing with the new symbols in lisp.h. All uses changed.
7149 * fileio.c (make_temp_name):
7150 * filelock.c (lock_file_1, lock_file):
7151 * xdisp.c (message_dolog):
7152 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
7153 Use pMd etc. instead.
7154 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
7155 replacing the pWIDE etc. symbols removed from editfns.c.
7157 * keyboard.h (num_input_events): Now uintmax_t.
7158 This is (very slightly) less likely to mess up due to wraparound.
7161 * buffer.c: Integer signedness fixes.
7162 (alloc_buffer_text, enlarge_buffer_text):
7163 Use ptrdiff_t rather than size_t when either will do, as we prefer
7166 * alloc.c: Integer signedness and overflow fixes.
7167 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
7168 (__malloc_size_t): Default to size_t, not to int.
7169 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
7170 (Fgarbage_collect, mark_object_loop_halt, mark_object):
7171 Prefer ptrdiff_t to size_t when either would do, as we prefer
7173 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
7174 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
7175 Now const. Initialize with values that are in range even if char
7177 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
7178 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
7179 These functions do the right thing with sizes > 2**32.
7180 (check_depth): Now ptrdiff_t, not int.
7181 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
7182 Adjust to new way of storing sizes. Check for size overflow bugs
7184 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
7185 slightly wrong anyway, as it missed one instance of
7186 XMALLOC_OVERRUN_CHECK_OVERHEAD.
7187 (refill_memory_reserve): Omit needless cast to size_t.
7188 (mark_object_loop_halt): Mark as externally visible.
7190 * xselect.c: Integer signedness and overflow fixes.
7191 (Fx_register_dnd_atom, x_handle_dnd_message):
7192 Use ptrdiff_t, not size_t, since we prefer signed.
7193 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
7194 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
7195 x_dnd_atoms_size and x_dnd_atoms_length.
7197 * doprnt.c: Prefer signed to unsigned when either works.
7199 * doprnt.c (doprnt):
7201 * xdisp.c (vmessage):
7202 Use ptrdiff_t, not size_t, when using or implementing doprnt,
7203 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
7204 prefer signed arithmetic to avoid comparison confusion.
7205 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
7206 but is a bit tricky.
7208 Assume freestanding C89 headers, string.h, stdlib.h.
7209 * data.c, doprnt.c, floatfns.c, print.c:
7210 Include float.h unconditionally.
7211 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
7212 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
7213 * regex.c: Likewise for stddef.h, string.h.
7214 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
7215 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
7216 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
7217 (STDC_HEADERS): Remove obsolete defines.
7218 * sysdep.c: Include limits.h unconditionally.
7220 Assume support for memcmp, memcpy, memmove, memset.
7221 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
7222 * regex.c (memcmp, memcpy):
7223 Remove; we assume C89 now.
7225 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
7226 (__malloc_safe_bcopy): Remove; no longer needed.
7228 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
7229 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
7230 well either way, and we prefer signed to unsigned.
7232 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
7234 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
7235 closes the connection while we're reading (bug#9182).
7237 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
7239 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
7240 are specified (Bug#9168).
7242 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
7244 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
7245 Found by GCC static checking and --with-wide-int on a 32-bit host.
7247 2011-07-25 Eli Zaretskii <eliz@gnu.org>
7249 * xdisp.c (compute_display_string_pos): Fix logic of caching
7250 previous display string position. Initialize cached_prev_pos to
7251 -1. Fixes slow-down at the beginning of a buffer.
7253 2011-07-24 Eli Zaretskii <eliz@gnu.org>
7255 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
7256 for attrs[LFACE_FONTSET_INDEX].
7258 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
7260 * xml.c (parse_region): Remove unused local
7261 that was recently introduced.
7263 2011-07-23 Eli Zaretskii <eliz@gnu.org>
7265 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
7266 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
7268 * xdisp.c (move_it_in_display_line_to): Record the best matching
7269 position for TO_CHARPOS while scanning the line, and restore it on
7270 exit if none of the characters scanned was an exact match.
7271 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
7272 when exact match is impossible due to invisible text, and the
7273 lines are truncated.
7275 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
7277 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
7280 2011-07-22 Eli Zaretskii <eliz@gnu.org>
7282 Fix a significant slow-down of cursor motion with C-n, C-p,
7283 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
7284 auto-repeat under bidi redisplay in fontified buffers.
7285 * xdisp.c (compute_stop_pos_backwards): New function.
7286 (next_element_from_buffer): Call compute_stop_pos_backwards to
7287 find a suitable prev_stop when we find ourselves before
7289 (reseat): Don't look for prev_stop, as that could mean a very long
7291 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
7292 <cached_disp_overlay_modiff>: Cache for last found display string
7294 (compute_display_string_pos): Return the cached position if asked
7295 about the same buffer in the same area of character positions, and
7296 the buffer wasn't changed since the time the display string
7297 position was cached.
7299 2011-07-22 Eli Zaretskii <eliz@gnu.org>
7301 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
7302 is an integer, which is important for empty lines. (Bug#9149)
7304 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
7306 * frame.c (Fmodify_frame_parameters): In tty case, update the
7307 default face if necessary (Bug#4238).
7309 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
7311 * editfns.c (Fstring_to_char): No need to explain what a character
7312 is in the docstring (Bug#6576).
7314 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7316 * xml.c (parse_region): Make sure we always return a tree.
7318 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
7320 * xml.c (parse_region): If a document contains only comments,
7323 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7325 * xml.c (make_dom): Return comments, too.
7327 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
7330 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
7331 and the surrounding thread.
7332 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
7333 rather than fgets, and retry after EINTR. Otherwise, 'emacs
7334 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
7336 * s/openbsd.h (BROKEN_SIGIO): Define.
7337 * unexelf.c (unexec) [__OpenBSD__]:
7338 Don't update the .mdebug section of the Alpha COFF symbol table.
7340 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7342 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
7345 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
7347 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
7348 This fixes some race conditions on the permissions of any newly
7351 * alloc.c (valid_pointer_p): Use pipe, not open.
7352 This fixes some permissions issues when debugging.
7354 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
7355 If fchown fails to set both uid and gid, try to set just gid,
7356 as that is sometimes allowed. Adjust the file's mode to eliminate
7357 setuid or setgid bits that are inappropriate if fchown fails.
7359 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
7361 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
7362 to compare Lisp_Objects.
7363 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
7364 global_gnutls_log_level, don't mistake it for a Lisp_Object.
7365 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
7367 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
7369 * lread.c (read_integer): Unread even EOF character.
7370 (read1): Likewise. Properly record start position of symbol.
7372 * lread.c (read1): Read `#:' as empty uninterned symbol if no
7373 symbol character follows.
7375 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
7377 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
7378 This works around a problem with the previous change to Fcopy_file.
7379 Recent glibc declares fchown with __attribute__((warn_unused_result)),
7380 and without this change, GCC might complain about discarding
7381 fchown's return value.
7383 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
7385 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
7387 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
7389 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
7391 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
7393 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
7394 it's used from the C level.
7396 * process.c: Use the same condition for POLL_FOR_INPUT in both
7397 keyboard.c and process.c (bug#1858).
7399 2011-07-09 Lawrence Mitchell <wence@gmx.li>
7401 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
7402 (Fgnutls_boot): Use it.
7404 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
7406 * doc.c (Fsubstitute_command_keys): Revert last change.
7408 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
7410 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
7411 quotes the next character, and doesn't affect other longer
7412 sequences (bug#8935).
7414 * lread.c (syms_of_lread): Clarify that is isn't only
7415 `eval-buffer' and `eval-defun' that's affected by
7416 `lexical-binding' (bug#8460).
7418 2011-07-15 Eli Zaretskii <eliz@gnu.org>
7420 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
7421 bidi redisplay when a line includes both an image and is truncated.
7423 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
7425 Fix minor problems found by static checking.
7426 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
7427 (elsz): Now a signed constant, not a size_t var. We prefer signed
7428 types to unsigned, to avoid integer comparison confusion. Without
7429 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
7430 "cannot optimize loop, the loop counter may overflow", a symptom
7432 * indent.c (Fvertical_motion): Mark locals as initialized.
7433 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
7435 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7437 * search.c (Fre_search_backward): Mention `case-fold-search' in
7438 all the re_search_* functions (bug#8138).
7440 * keyboard.c (Fopen_dribble_file): Document when the file is
7443 2011-07-14 Eli Zaretskii <eliz@gnu.org>
7445 * bidi.c (bidi_dump_cached_states): Fix format of displaying
7448 Support bidi reordering of display and overlay strings.
7449 * xdisp.c (compute_display_string_pos)
7450 (compute_display_string_end): Accept additional argument STRING.
7451 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
7452 (reseat_to_string): Initialize bidi_it->string.s and
7453 bidi_it->string.schars.
7454 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
7455 NULL (avoids a crash in bidi_paragraph_init).
7456 Initialize itb.string.lstring.
7457 (init_iterator): Call bidi_init_it only of a valid
7458 buffer position was specified. Initialize paragraph_embedding to
7460 (reseat_to_string): Initialize the bidi iterator.
7461 (display_string): If we need to ignore text properties of
7462 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
7463 original value of -1 will not work with bidi.)
7464 (compute_display_string_pos): First arg is now struct
7465 `text_pos *'; all callers changed. Support display properties on
7467 (compute_display_string_end): Support display properties on Lisp
7469 (init_iterator, reseat_1, reseat_to_string): Initialize the
7470 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
7471 when iterating on a string not from display properties).
7472 (compute_display_string_pos, compute_display_string_end):
7473 Fix calculation of the object to scan. Fixes an error when using
7475 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
7476 base_level_stop; instead, set base_level_stop to BEGV.
7477 Fixes crashes in vertical-motion.
7478 (next_element_from_buffer): Improve commentary for when
7479 the iterator is before prev_stop.
7480 (init_iterator): Initialize bidi_p from the default value of
7481 bidi-display-reordering, not from buffer-local value. Use the
7482 buffer-local value only if initializing for buffer iteration.
7483 (handle_invisible_prop): Support invisible properties on strings
7484 that are being bidi-reordered.
7485 (set_iterator_to_next): Support bidi reordering of C strings and
7487 (next_element_from_string): Support bidi reordering of Lisp
7489 (handle_stop_backwards): Support Lisp strings as well.
7490 (display_string): Support display of R2L glyph rows.
7491 Use IT_STRING_CHARPOS when displaying from a Lisp string.
7492 (init_iterator): Don't initialize it->bidi_p for strings
7494 (reseat_to_string): Initialize it->bidi_p for strings here.
7495 (next_element_from_string, next_element_from_c_string)
7496 (next_element_from_buffer): Add xassert's for correspondence
7497 between IT's object being iterated and it->bidi_it.string
7499 (face_before_or_after_it_pos): Support bidi iteration.
7500 (next_element_from_c_string): Handle the case of the first string
7501 character that is not the first one in the visual order.
7502 (get_visually_first_element): New function, refactored from common
7503 parts of next_element_from_buffer, next_element_from_string, and
7504 next_element_from_c_string.
7505 (tool_bar_lines_needed, redisplay_tool_bar)
7506 (display_menu_bar): Force left-to-right direction. Add a FIXME
7507 comment for making that be controlled by a user option.
7508 (push_it, pop_it): Save and restore the state of the
7509 bidi iterator. Save and restore the bidi_p flag.
7510 (pop_it): Iterate out of display property for string iteration as
7512 (iterate_out_of_display_property): Support iteration over strings.
7513 (handle_single_display_spec): Set up it->bidi_it for iteration
7514 over a display string, and call bidi_init_it.
7515 (handle_single_display_spec, next_overlay_string)
7516 (get_overlay_strings_1, push_display_prop): Set up the bidi
7517 iterator for displaying display or overlay strings.
7518 (forward_to_next_line_start): Don't use the shortcut if
7520 (back_to_previous_visible_line_start): If handle_display_prop
7521 pushed the iterator stack, restore the internal state of the bidi
7522 iterator by calling bidi_pop_it same number of times.
7523 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
7524 and we are bidi-iterating, don't decrement the iterator position;
7525 instead, set the first_elt flag in the bidi iterator, to produce
7527 (reseat_1): Remove redundant setting of string_from_display_prop_p.
7528 (push_display_prop): xassert that we are iterating a buffer.
7529 (push_it, pop_it): Save and restore paragraph_embedding member.
7530 (handle_single_display_spec, next_overlay_string)
7531 (get_overlay_strings_1, reseat_1, reseat_to_string)
7532 (push_display_prop): Set up the `unibyte' member of bidi_it.string
7533 correctly. Don't assume unibyte strings are not bidi-reordered.
7534 (compute_display_string_pos)
7535 (compute_display_string_end): Fix handling the case of C string.
7536 (push_it, pop_it): Save and restore from_disp_prop_p.
7537 (handle_single_display_spec, push_display_prop): Set the
7538 from_disp_prop_p flag.
7539 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
7540 (pop_it): Call iterate_out_of_display_property only if we are
7541 popping after iteration over a string that came from a display
7542 property. Fix a typo in popping stretch info. Add an assertion
7543 for verifying that the iterator position is in sync with the bidi
7545 (handle_single_display_spec, get_overlay_strings_1)
7546 (push_display_prop): Fix initialization of paragraph direction for
7547 string when that of the parent object is not yet determined.
7548 (reseat_1): Call bidi_init_it to resync the bidi
7549 iterator with IT's position. (Bug#7616)
7550 (find_row_edges): If ROW->start.pos gives position
7551 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
7552 (handle_stop, back_to_previous_visible_line_start, reseat_1):
7553 Reset the from_disp_prop_p flag.
7554 (SAVE_IT, RESTORE_IT): New macros.
7555 (pos_visible_p, face_before_or_after_it_pos)
7556 (back_to_previous_visible_line_start)
7557 (move_it_in_display_line_to, move_it_in_display_line)
7558 (move_it_to, move_it_vertically_backward, move_it_by_lines)
7559 (try_scrolling, redisplay_window, display_line): Use them when
7560 saving a temporary copy of the iterator and restoring it back.
7561 (back_to_previous_visible_line_start, reseat_1)
7562 (init_iterator): Empty the bidi cache "stack".
7563 (move_it_in_display_line_to): If iterator ended up at
7564 EOL, but we never saw any buffer positions smaller than
7565 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
7566 motion in bidi-reordered lines.
7567 (move_it_in_display_line_to): Record prev_method and prev_pos
7568 immediately before the call to set_iterator_to_next. Fixes cursor
7569 motion in bidi-reordered lines with stretch glyphs and strings
7570 displayed in margins. (Bug#8133) (Bug#8867)
7571 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
7573 (pos_visible_p): Support positions in bidi-reordered lines.
7574 Save and restore bidi cache.
7576 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
7577 (bidi_paragraph_info): Delete unused struct.
7578 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
7579 (bidi_cache_start): New variable.
7580 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
7582 (bidi_cache_fetch_state, bidi_cache_search)
7583 (bidi_cache_find_level_change, bidi_cache_iterator_state)
7584 (bidi_cache_find, bidi_peek_at_next_level)
7585 (bidi_level_of_next_char, bidi_find_other_level_edge)
7586 (bidi_move_to_visually_next): Compare cache index with
7587 bidi_cache_start rather than with zero.
7588 (bidi_fetch_char): Accept new argument STRING; all callers
7589 changed. Support iteration over a string. Support strings with
7590 display properties. Support unibyte strings. Fix the type of
7591 `len' according to what STRING_CHAR_AND_LENGTH expects.
7592 (bidi_paragraph_init, bidi_resolve_explicit_1)
7593 (bidi_resolve_explicit, bidi_resolve_weak)
7594 (bidi_level_of_next_char, bidi_move_to_visually_next):
7595 Support iteration over a string.
7596 (bidi_set_sor_type, bidi_resolve_explicit_1)
7597 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
7598 can now be zero (for strings); special values 0 and -1 were
7599 changed to -1 and -2, respectively.
7600 (bidi_char_at_pos): New function.
7601 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
7602 Call it instead of FETCH_MULTIBYTE_CHAR.
7603 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
7604 initialized to valid values.
7605 (bidi_init_it): Don't initialize charpos and bytepos with invalid
7607 (bidi_level_of_next_char): Allow the sentinel "position" to pass
7608 the test for valid cached positions. Fix the logic for looking up
7609 the sentinel state in the cache. GCPRO the Lisp string we are
7611 (bidi_push_it, bidi_pop_it): New functions.
7612 (bidi_initialize): Initialize the bidi cache start stack pointer.
7613 (bidi_cache_ensure_space): New function, refactored from part of
7614 bidi_cache_iterator_state. Don't assume the required size is just
7615 one BIDI_CACHE_CHUNK away.
7616 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
7617 (bidi_count_bytes, bidi_char_at_pos): New functions.
7618 (bidi_cache_search): Don't assume bidi_cache_last_idx is
7619 always valid if bidi_cache_idx is valid.
7620 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
7621 is valid if it's going to be used.
7622 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
7623 (bidi_cache_fetch_state, bidi_cache_search)
7624 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7625 (bidi_cache_iterator_state, bidi_cache_find)
7626 (bidi_find_other_level_edge, bidi_cache_start_stack):
7627 All variables related to cache indices are now EMACS_INT.
7629 * dispextern.h (struct bidi_string_data): New structure.
7630 (struct bidi_it): New member `string'. Make flag members be 1-bit
7631 fields, and put them last in the struct.
7632 (compute_display_string_pos, compute_display_string_end):
7634 (bidi_push_it, bidi_pop_it): Add prototypes.
7635 (struct iterator_stack_entry): New members bidi_p,
7636 paragraph_embedding, and from_disp_prop_p.
7637 (struct it): Member bidi_p is now a bit field 1 bit wide.
7638 (bidi_shelve_cache, bidi_unshelve_cache):
7641 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
7642 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
7643 and vector-like objects.
7645 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
7646 cache around display iteration.
7648 * window.c (Fwindow_end, window_scroll_pixel_based)
7649 (displayed_window_lines, Frecenter): Save and restore the bidi
7650 cache around display iteration.
7652 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7654 * editfns.c (Fdelete_region): Clarify the use of the named
7655 parameters (bug#6788).
7657 2011-07-14 Martin Rudalics <rudalics@gmx.at>
7659 * indent.c (Fvertical_motion): Set and restore w->pointm when
7660 saving and restoring the window's buffer (Bug#9006).
7662 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
7664 * editfns.c (Fstring_to_char): Clarify just what is returned
7665 (bug#6576). Text by Eli Zaretskii.
7667 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
7669 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
7671 2011-07-13 Eli Zaretskii <eliz@gnu.org>
7673 * buffer.c (mmap_find): Fix a typo.
7675 2011-07-13 Johan Bockgård <bojohan@gnu.org>
7677 Fix execution of x selection hooks.
7678 * xselect.c (Qx_lost_selection_functions)
7679 (Qx_sent_selection_functions): New vars.
7680 (syms_of_xselect): DEFSYM them.
7681 (x_handle_selection_request): Pass Qx_sent_selection_functions
7682 rather than Vx_sent_selection_functions to Frun_hook_with_args.
7683 (x_handle_selection_clear,x_clear_frame_selections):
7684 Pass Qx_lost_selection_functions rather than
7685 Vx_lost_selection_functions to Frun_hook_with_args.
7687 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
7689 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
7690 The old code sometimes used this field without initializing it.
7692 * alloc.c (gc_sweep): Don't read past end of array.
7693 In theory, the old code could also have corrupted Emacs internals,
7694 though it'd be very unlikely.
7696 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
7698 * character.c (Fcharacterp): Don't advertise optional ignored
7699 argument. (Bug#4026)
7701 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
7703 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
7706 * window.c (Fset_window_start): Doc fix (bug#4199).
7707 (Fset_window_hscroll): Ditto.
7709 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
7711 Fix minor new problems caught by GCC 4.6.1.
7712 * term.c (init_tty): Remove unused local.
7713 * xsettings.c (store_monospaced_changed): Define this function only
7714 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
7717 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
7719 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
7721 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7723 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
7724 are the mini-buffer and the echo area (bug#3320).
7726 * term.c (init_tty): Remove support for supdup, c10 and perq
7727 terminals, which are no longer supported (bug#1482).
7729 2011-07-10 Johan Bockgård <bojohan@gnu.org>
7731 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
7733 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
7735 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
7736 for non-popups (Bug#3642).
7738 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
7740 * alloc.c (reset_malloc_hooks): Protoize.
7741 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
7742 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
7743 * cm.c (losecursor): Likewise.
7744 * data.c (fmod): Likewise.
7745 * dispnew.c (swap_glyphs_in_rows): Likewise.
7746 * emacs.c (memory_warning_signal): Likewise.
7747 * floatfns.c (float_error): Likewise.
7748 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
7749 (otf_open, font_otf_capability, generate_otf_features)
7750 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
7752 * image.c (pbm_read_file): Likewise.
7753 * indent.c (string_display_width): Likewise.
7754 * intervals.c (check_for_interval, search_for_interval)
7755 (inc_interval_count, count_intervals, root_interval)
7756 (adjust_intervals_for_insertion, make_new_interval): Likewise.
7757 * lread.c (defalias): Likewise.
7758 * ralloc.c (r_alloc_check): Likewise.
7759 * regex.c (set_image_of_range_1, set_image_of_range)
7760 (regex_grow_registers): Likewise.
7761 * sysdep.c (strerror): Likewise.
7762 * termcap.c (valid_filename_p, tprint, main): Likewise.
7763 * tparam.c (main): Likewise.
7764 * unexhp9k800.c (run_time_remap, save_data_space)
7765 (update_file_ptrs, read_header, write_header, calculate_checksum)
7766 (copy_file, copy_rest, display_header): Likewise.
7767 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
7769 * xdisp.c (check_it): Likewise.
7770 * xfaces.c (register_color, unregister_color, unregister_colors):
7772 * xfns.c (print_fontset_result): Likewise.
7773 * xrdb.c (member, fatal, main): Likewise.
7775 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
7777 Fix minor problems found by static checking (Bug#9031).
7778 * chartab.c (char_table_set_range, map_sub_char_table):
7779 Remove unused locals.
7780 (uniprop_table): Now static.
7781 * composite.c (_work_char): Remove unused static var.
7783 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
7785 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
7787 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
7789 * gtkutil.c (qttip_cb): Remove code without function.
7791 2011-07-09 Eli Zaretskii <eliz@gnu.org>
7793 * w32.c (pthread_sigmask): New stub.
7795 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
7797 Use pthread_sigmask, not sigprocmask (Bug#9010).
7798 sigprocmask is portable only for single-threaded applications, and
7799 Emacs can be multi-threaded when it uses GTK.
7800 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
7802 * callproc.c (Fcall_process):
7803 * process.c (create_process):
7804 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
7805 Use pthread_sigmask, not sigprocmask.
7807 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7809 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
7810 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
7813 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7815 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
7816 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
7817 (xg_hide_tooltip): Fix comment.
7819 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
7820 in registerServicesMenuSendTypes.
7821 (validRequestorForSendType): Don't check ns_return_types.
7823 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
7826 2011-07-08 Jason Rumney <jasonr@gnu.org>
7828 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
7829 SH_SHOW for hidden windows (Bug#5482).
7831 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
7832 frame struct members of non-existent frames (Bug#6284).
7834 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7836 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
7837 variable firstTime not needed on OSX >= 10.6.
7838 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
7839 >= 10.5. Use setKnobProportion, setDoubleValue.
7841 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
7842 (MAC_OS_X_VERSION_10_5): Define if not defined.
7843 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
7844 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
7845 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
7847 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
7848 cString and lossyCString on OSX >= 10.4.
7850 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
7851 sizeToFit on OSX >= 10.2.
7853 * nsimage.m (allocInitFromFile): Don't use deprecated method
7854 bestRepresentationForDevice on OSX >= 10.6.
7856 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
7859 * emacs.c: Declare unexec_init_emacs_zone.
7861 * nsgui.h: Fix compiler warning about gnulib redefining verify.
7863 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
7865 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
7866 on svcsMenu (Bug#8842).
7868 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
7870 (Fns_list_services): Just return Qnil on 10.6, code not working there.
7872 * nsterm.m (QUTF8_STRING): Declare.
7873 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
7874 (validRequestorForSendType): Return type is (id).
7875 Change indexOfObjectIdenticalTo to indexOfObject.
7876 Check if we have local selection before returning self (Bug#8842).
7877 (writeSelectionToPasteboard): Put local selection into paste board
7878 if we have a local selection (Bug#8842).
7879 (syms_of_nsterm): DEFSYM QUTF8_STRING.
7881 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
7882 (ns_get_local_selection): Declare.
7884 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
7886 * keymap.c (describe_map_tree): Don't insert a double newline at
7887 the end of the buffer (bug#1169) and return whether we inserted
7890 * callint.c (Fcall_interactively): Change "reading args" to
7891 "providing args" to try to clarify what it does (bug#1010).
7893 2011-07-07 Kenichi Handa <handa@m17n.org>
7895 * composite.c (composition_compute_stop_pos): Ignore a static
7896 composition starting before CHARPOS (Bug#8915).
7898 * xdisp.c (handle_composition_prop): Likewise.
7900 2011-07-07 Eli Zaretskii <eliz@gnu.org>
7902 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
7905 2011-07-07 Kenichi Handa <handa@m17n.org>
7907 * character.h (unicode_category_t): New enum type.
7909 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
7910 (Qchar_code_property_table): New variable.
7911 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
7912 (UNIPROP_COMPRESSED_FORM_P): New macros.
7913 (char_table_ascii): Uncompress the compressed values.
7914 (sub_char_table_ref): New arg is_uniprop. Callers changed.
7915 Uncompress the compressed values.
7916 (sub_char_table_ref_and_range): Likewise.
7917 (char_table_ref_and_range): Uncompress the compressed values.
7918 (sub_char_table_set): New arg is_uniprop. Callers changed.
7919 Uncompress the compressed values.
7920 (sub_char_table_set_range): Args changed. Callers changed.
7921 (char_table_set_range): Adjuted for the above change.
7922 (map_sub_char_table): Delete args default_val and parent. Add arg
7923 top. Give decoded values to a Lisp function.
7924 (map_char_table): Adjust for the above change. Give decoded
7925 values to a Lisp function. Gcpro more variables.
7926 (uniprop_table_uncompress)
7927 (uniprop_decode_value_run_length): New functions.
7928 (uniprop_decoder, uniprop_decoder_count): New variables.
7929 (uniprop_get_decoder, uniprop_encode_value_character)
7930 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
7932 (uniprop_encoder, uniprop_encoder_count): New variables.
7933 (uniprop_get_encoder, uniprop_table)
7934 (Funicode_property_table_internal, Fget_unicode_property_internal)
7935 (Fput_unicode_property_internal): New functions.
7936 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
7937 Sunicode_property_table_internal, Sget_unicode_property_internal,
7938 and Sput_unicode_property_internal. Defvar_lisp
7939 char-code-property-alist.
7941 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
7942 Vunicode_category_table.
7944 * font.c (font_range): Adjust for the change of
7945 Vunicode_category_table.
7947 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
7949 * m/iris4d.h: Remove file, move contents ...
7950 * s/irix6-5.h: ... here.
7952 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
7954 Remove unportable assumption about struct layout (Bug#8884).
7955 * alloc.c (mark_buffer):
7956 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
7957 (clone_per_buffer_values): Don't assume that
7958 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
7959 This isn't true in general, and it's particularly not true
7960 if Emacs is configured with --with-wide-int.
7961 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
7962 New macros, used in the buffer.c change.
7964 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
7966 * xsettings.c: Use both GConf and GSettings if both are available.
7967 (store_config_changed_event): Add comment.
7968 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
7969 (store_tool_bar_style_changed): New functions.
7970 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
7971 (struct xsettings): Move font inside HAVE_XFT.
7972 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
7973 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
7974 Move inside HAVE_XFT.
7975 (something_changed_gsettingsCB): Rename from something_changedCB.
7976 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
7978 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
7979 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
7980 (something_changed_gconfCB): Rename from something_changedCB.
7981 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
7982 (parse_settings): Move check for font inside HAVE_XFT.
7983 (read_settings, apply_xft_settings): Add comment.
7984 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
7985 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
7986 call store_font_name_changed.
7987 (xft_settings_event): Add comment.
7988 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
7989 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
7990 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
7991 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
7992 (xsettings_initialize): Call init_gsettings last.
7993 (xsettings_get_system_font, xsettings_get_system_normal_font):
7996 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
7998 Random fixes. E.g., (random) never returned negative values.
7999 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
8000 subseconds part to the entropy, as that's a bit more random.
8001 Prefer signed to unsigned, since the signedness doesn't matter and
8002 in general we prefer signed. When given a limit, use a
8003 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
8004 latter isn't right if USE_2_TAGS_FOR_INTS.
8005 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
8006 not 0..VALMASK. Don't discard "excess" bits that random () returns.
8008 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
8010 * textprop.c (text_property_stickiness):
8011 Obey Vtext_property_default_nonsticky.
8012 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
8013 * w32fns.c (syms_of_w32fns):
8014 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
8016 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8018 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
8019 This is more efficient than Ffile_directory_p and avoids a minor race.
8021 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
8023 * buffer.c (Foverlay_put): Say what the return value is
8026 * fileio.c (barf_or_query_if_file_exists): Check first if the file
8027 is a directory before asking whether to use the file name
8029 (barf_or_query_if_file_exists): Make the "File is a directory"
8030 error be more correct.
8032 * fns.c (Frequire): Remove the mention of the .gz files, since
8033 that's installation-specific, but keep the mention of
8034 `get-load-suffixes'.
8036 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8038 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
8039 Report string overflow if the output is too long.
8041 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
8043 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
8044 (syms_of_gnutls): Remove duplicate DEFSYM for
8045 Qgnutls_bootprop_verify_hostname_error, an error for
8046 Qgnutls_bootprop_verify_error (which is no longer used).
8048 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
8049 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
8050 Also (re)move comments that are misplaced or no longer relevant.
8052 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8054 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
8056 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
8058 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
8059 and background color parameters if they have been changed.
8061 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8063 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
8065 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
8067 * xsettings.c (SYSTEM_FONT): Define only when used.
8068 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
8070 * keymap.c (access_keymap_1): Now static.
8072 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
8074 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
8075 leave any prefix arg for the up event (Bug#1586).
8077 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
8079 * lread.c (syms_of_lread): Mention single symbols defined by
8080 `defvar' or `defconst' (bug#7154).
8082 * fns.c (Frequire): Mention .el.gz files (bug#7314).
8083 (Frequire): Mention get-load-suffixes.
8085 2011-07-02 Martin Rudalics <rudalics@gmx.at>
8087 * window.h (window): Remove clone_number slot.
8088 * window.c (Fwindow_clone_number, Fset_window_clone_number):
8090 (make_parent_window, make_window, saved_window)
8091 (Fset_window_configuration, save_window_save): Don't deal with
8093 * buffer.c (Qclone_number): Remove declaration.
8094 (sort_overlays, overlay_strings): Don't deal with clone numbers.
8096 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
8098 Add multiple inheritance to keymaps.
8099 * keymap.c (Fmake_composed_keymap): New function.
8100 (Fset_keymap_parent): Simplify.
8101 (fix_submap_inheritance): Remove.
8102 (access_keymap_1): New function extracted from access_keymap to handle
8103 embedded parents and handle lists of maps.
8104 (access_keymap): Use it.
8105 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
8106 (Fcopy_keymap): Handle embedded parents.
8107 (Fcommand_remapping, define_as_prefix): Simplify.
8108 (Fkey_binding): Simplify.
8109 (syms_of_keymap): Move minibuffer-local-completion-map,
8110 minibuffer-local-filename-completion-map,
8111 minibuffer-local-must-match-map, and
8112 minibuffer-local-filename-must-match-map to Elisp.
8113 (syms_of_keymap): Defsubr make-composed-keymap.
8114 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
8115 (parse_menu_item): Trivial simplification.
8117 2011-07-01 Glenn Morris <rgm@gnu.org>
8119 * Makefile.in (SETTINGS_LIBS): Fix typo.
8121 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
8123 * coding.c (Fencode_coding_string): Record the last coding system
8124 used, as the function doc string says (bug#8738).
8126 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
8128 * xsettings.c (store_monospaced_changed): Take new font as arg and
8129 check for change against current_mono_font.
8130 (EMACS_TYPE_SETTINGS): Remove this and related defines.
8131 (emacs_settings_constructor, emacs_settings_get_property)
8132 (emacs_settings_set_property, emacs_settings_class_init)
8133 (emacs_settings_init, gsettings_obj): Remove.
8134 (something_changedCB): New function for HAVE_GSETTINGS.
8135 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
8136 with value as argument.
8137 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
8138 g_settings_new (Bug#8967). Do not create gsettings_obj.
8139 Remove calls to g_settings_bind. Connect something_changedCB to
8142 * xgselect.c: Add defined (HAVE_GSETTINGS).
8143 (xgselect_initialize): Ditto.
8145 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
8146 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
8149 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
8151 * eval.c (struct backtrace): Simplify and port the data structure.
8152 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
8153 signed bit field, as this assumption is not portable and it makes
8154 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
8155 "char debug_on_exit : 1" as this is not portable either; instead,
8156 use the portable "unsigned int debug_on_exit : 1". Remove unused
8157 member evalargs. Remove obsolete comments about cc bombing out.
8159 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
8161 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
8162 Let HAVE_GSETTINGS override HAVE_GCONF.
8163 (store_monospaced_changed): New function.
8164 (EMACS_SETTINGS): A new type derived from GObject to handle
8165 GSettings notifications.
8166 (emacs_settings_constructor, emacs_settings_get_property)
8167 (emacs_settings_set_property, emacs_settings_class_init):
8169 (gsettings_client, gsettings_obj): New variables.
8170 (GSETTINGS_SCHEMA): New define.
8171 (something_changedCB): Call store_monospaced_changed.
8172 (init_gsettings): New function.
8173 (xsettings_initialize): Call init_gsettings.
8174 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
8177 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
8180 2011-06-29 Martin Rudalics <rudalics@gmx.at>
8182 * window.c (resize_root_window, grow_mini_window)
8183 (shrink_mini_window): Rename Qresize_root_window to
8184 Qwindow_resize_root_window and Qresize_root_window_vertically to
8185 Qwindow_resize_root_window_vertically.
8187 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
8189 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
8191 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
8193 * makefile.w32-in: Redesign dependencies so they reflect more
8194 clearly which files are directly included by each source file,
8195 and not through other includes.
8197 2011-06-27 Martin Rudalics <rudalics@gmx.at>
8199 * buffer.c (Qclone_number): Declare static and DEFSYM it.
8200 (sort_overlays, overlay_strings): When an overlay's clone number
8201 matches the window's clone number process the overlay even if
8202 the overlay's window property doesn't match the current window.
8204 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
8205 (Fwindow_hchild): Rename to Fwindow_left_child.
8206 (Fwindow_next): Rename to Fwindow_next_sibling.
8207 (Fwindow_prev): Rename to Fwindow_prev_sibling.
8208 (resize_window_check): Rename to window_resize_check.
8209 (resize_window_apply): Rename to window_resize_apply.
8210 (Fresize_window_apply): Rename to Fwindow_resize_apply.
8211 (Fdelete_other_windows_internal, resize_frame_windows)
8212 (Fsplit_window_internal, Fdelete_window_internal)
8213 (grow_mini_window, shrink_mini_window)
8214 (Fresize_mini_window_internal): Fix callers accordingly.
8216 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
8218 * emacsgtkfixed.h: State that this is only used with Gtk+3.
8219 (emacs_fixed_set_min_size): Remove.
8220 (emacs_fixed_new): Take frame as argument.
8222 * emacsgtkfixed.c: State that this is only used with Gtk+3.
8223 (_EmacsFixedPrivate): Remove minwidth/height.
8224 Add struct frame *f.
8225 (emacs_fixed_init): Initialize priv->f.
8226 (get_parent_class, emacs_fixed_set_min_size): Remove.
8227 (emacs_fixed_new): Set priv->f to argument.
8228 (emacs_fixed_get_preferred_width)
8229 (emacs_fixed_get_preferred_height): Use min_width/height from
8230 frames size_hint to set minimum and natural (Bug#8919).
8231 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
8232 and use min_width/height from frames size_hint to set
8233 min_width/height (Bug#8919).
8235 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
8236 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
8239 2011-06-26 Eli Zaretskii <eliz@gnu.org>
8241 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
8242 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
8245 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
8247 * process.c (wait_reading_process_output): Bypass select if
8248 waiting for a cell while ignoring keyboard input, and input is
8249 pending. Suggested by Jan Djärv (Bug#8869).
8251 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
8253 Use gnulib's dup2 module instead of rolling our own.
8254 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
8256 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8258 * dispnew.c (scrolling_window): Before scrolling, turn off a
8259 mouse-highlight in the window being scrolled.
8261 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
8263 Move DEFSYM to lisp.h and use everywhere.
8265 * character.h (DEFSYM): Move declaration...
8266 * lisp.h (DEFSYM): ...here.
8272 * w32select.c: Don't include character.h.
8274 * alloc.c (syms_of_alloc):
8275 * buffer.c (syms_of_buffer):
8276 * bytecode.c (syms_of_bytecode):
8277 * callint.c (syms_of_callint):
8278 * casefiddle.c (syms_of_casefiddle):
8279 * casetab.c (init_casetab_once):
8280 * category.c (init_category_once, syms_of_category):
8281 * ccl.c (syms_of_ccl):
8282 * cmds.c (syms_of_cmds):
8283 * composite.c (syms_of_composite):
8284 * dbusbind.c (syms_of_dbusbind):
8285 * dired.c (syms_of_dired):
8286 * dispnew.c (syms_of_display):
8287 * doc.c (syms_of_doc):
8288 * editfns.c (syms_of_editfns):
8289 * emacs.c (syms_of_emacs):
8290 * eval.c (syms_of_eval):
8291 * fileio.c (syms_of_fileio):
8292 * fns.c (syms_of_fns):
8293 * frame.c (syms_of_frame):
8294 * fringe.c (syms_of_fringe):
8295 * insdel.c (syms_of_insdel):
8296 * keymap.c (syms_of_keymap):
8297 * lread.c (init_obarray, syms_of_lread):
8298 * macros.c (syms_of_macros):
8299 * msdos.c (syms_of_msdos):
8300 * print.c (syms_of_print):
8301 * process.c (syms_of_process):
8302 * search.c (syms_of_search):
8303 * sound.c (syms_of_sound):
8304 * syntax.c (init_syntax_once, syms_of_syntax):
8305 * terminal.c (syms_of_terminal):
8306 * textprop.c (syms_of_textprop):
8307 * undo.c (syms_of_undo):
8308 * w32.c (globals_of_w32):
8309 * window.c (syms_of_window):
8310 * xdisp.c (syms_of_xdisp):
8311 * xfaces.c (syms_of_xfaces):
8312 * xfns.c (syms_of_xfns):
8313 * xmenu.c (syms_of_xmenu):
8314 * xsettings.c (syms_of_xsettings):
8315 * xterm.c (syms_of_xterm): Use DEFSYM.
8317 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
8319 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
8321 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
8323 Integer and buffer overflow fixes (Bug#8873).
8325 * print.c (printchar, strout): Check for string overflow.
8326 (PRINTPREPARE, printchar, strout):
8327 Don't set size unless allocation succeeds.
8329 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
8330 for sizes. Check for string overflow more accurately.
8331 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
8333 * macros.c: Integer and buffer overflow fixes.
8334 * keyboard.h (struct keyboard.kbd_macro_bufsize):
8335 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
8336 Use ptrdiff_t, not int, for sizes.
8337 Don't increment bufsize until after realloc succeeds.
8338 Check for size-calculation overflow.
8339 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
8341 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
8343 * lread.c: Integer overflow fixes.
8344 (read_integer): Radix is now EMACS_INT, not int,
8345 to improve quality of diagnostics for out-of-range radices.
8346 Calculate buffer size correctly for out-of-range radices.
8347 (read1): Check for integer overflow in radices, and in
8348 read-circle numbers.
8349 (read_escape): Avoid int overflow.
8350 (Fload, openp, read_buffer_size, read1)
8351 (substitute_object_recurse, read_vector, read_list, map_obarray):
8352 Use ptrdiff_t, not int, for sizes.
8353 (read1): Use EMACS_INT, not int, for sizes.
8354 Check for size overflow.
8356 * image.c (cache_image): Check for size arithmetic overflow.
8358 * lread.c: Integer overflow issues.
8359 (saved_doc_string_size, saved_doc_string_length)
8360 (prev_saved_doc_string_size, prev_saved_doc_string_length):
8361 Now ptrdiff_t, not int.
8362 (read1): Don't assume doc string length fits in int. Check for
8363 out-of-range doc string lengths.
8364 (read_list): Don't assume file position fits in int.
8365 (read_escape): Check for hex character overflow.
8367 2011-06-22 Leo Liu <sdl.web@gmail.com>
8369 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
8370 Move to minibuffer.el.
8372 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8374 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
8375 The following patches are for when GLYPH_DEBUG && !XASSERT.
8376 * dispextern.h (trace_redisplay_p, dump_glyph_string):
8377 * dispnew.c (flush_stdout):
8378 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
8379 Mark as externally visible.
8380 * dispnew.c (check_window_matrix_pointers): Now static.
8381 * dispnew.c (window_to_frame_vpos):
8382 * xfns.c (unwind_create_frame):
8383 * xterm.c (x_check_font): Remove unused local.
8384 * scroll.c (CHECK_BOUNDS):
8385 * xfaces.c (cache_fache): Rename local to avoid shadowing.
8386 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
8387 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
8388 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
8389 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
8391 (debug_method_add): Use va_list and vsprintf rather than relying
8392 on undefined behavior with wrong number of arguments.
8393 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
8394 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
8395 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
8396 since we're not interested in debugging glyphs with old libraries.
8397 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
8398 GCC 4.6.0's static checking.
8400 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8402 Integer overflow and signedness fixes (Bug#8873).
8403 A few related buffer overrun fixes, too.
8405 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
8407 * dispextern.h (struct face.stipple):
8408 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
8409 (x_bitmap_mask, x_allocate_bitmap_record)
8410 (x_create_bitmap_from_data, x_create_bitmap_from_file)
8411 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
8412 (x_create_bitmap_from_xpm_data):
8413 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
8414 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
8416 * xfaces.c (load_pixmap):
8417 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
8418 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
8419 (.bitmaps_last, struct x_output.icon_bitmap):
8420 Use ptrdiff_t, not int, for bitmap indexes.
8421 (x_allocate_bitmap_record): Check for size overflow.
8422 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
8424 Use ptrdiff_t, not int, for overlay counts.
8425 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
8426 * editfns.c (overlays_around, get_pos_property):
8427 * textprop.c (get_char_property_and_overlay):
8428 * xdisp.c (next_overlay_change, note_mouse_highlight):
8429 * xfaces.c (face_at_buffer_position):
8430 * buffer.c (OVERLAY_COUNT_MAX): New macro.
8431 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
8432 (Fnext_overlay_change, Fprevious_overlay_change)
8433 (mouse_face_overlay_overlaps, Foverlays_in):
8434 Use ptrdiff_t, not int, for sizes.
8435 (overlays_at, overlays_in): Check for size-calculation overflow.
8437 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
8439 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
8440 (x_session_initialize): Do not assume string length fits in int.
8442 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
8443 This is unlikely, but can occur if DPI is outlandish.
8445 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
8446 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
8448 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
8449 * xrdb.c (magic_file_p, search_magic_path):
8450 Omit last arg SUFFIX; it was always 0. All callers changed.
8451 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
8453 * xfont.c (xfont_match): Avoid need for strlen.
8455 * xfns.c: Don't assume strlen fits in int.
8456 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
8458 * xdisp.c (message_log_check_duplicate): Return intmax_t,
8459 not unsigned long, as we prefer signed integers. All callers changed.
8460 Detect integer overflow in repeat count.
8461 (message_dolog): Don't assume print length fits in 39 bytes.
8462 (display_mode_element): Don't assume strlen fits in int.
8464 * termcap.c: Don't assume sizes fit in int and never overflow.
8465 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
8466 (gobble_line): Check for size-calculation overflow.
8468 * minibuf.c (Fread_buffer):
8469 * lread.c (intern, intern_c_string):
8470 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
8471 Don't assume string length fits in int.
8473 * keyboard.c (parse_tool_bar_item):
8474 * gtkutil.c (style_changed_cb): Avoid need for strlen.
8476 * font.c: Don't assume string length fits in int.
8477 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
8478 Use ptrdiff_t, not int.
8479 (font_intern_prop): Don't assume string length fits in int.
8480 Don't assume integer property fits in fixnum.
8481 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
8483 * filelock.c: Fix some buffer overrun and integer overflow issues.
8484 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
8485 Reformulate so as not to need the command string.
8486 Invoke gzip -cd rather than gunzip, as it's more portable.
8487 (lock_info_type, lock_file_1, lock_file):
8488 Don't assume pid_t and time_t fit in unsigned long.
8489 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
8490 (current_lock_owner): Prefer signed type for sizes.
8491 Use memcpy, not strncpy, where memcpy is what is really wanted.
8492 Don't assume (via atoi) that time_t and pid_t fit in int.
8493 Check for time_t and/or pid_t out of range, e.g., via a network share.
8494 Don't alloca where an auto var works fine.
8496 * fileio.c: Fix some integer overflow issues.
8497 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
8498 Don't assume string length fits in int.
8499 (directory_file_name): Don't assume string length fits in long.
8500 (make_temp_name): Don't assume pid fits in int, or that its print
8501 length is less than 20.
8503 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
8505 * coding.c (make_subsidiaries): Don't assume string length fits in int.
8507 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
8509 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
8510 We prefer signed integers, even for size calculations.
8512 * emacs.c: Don't assume string length fits in 'int'.
8513 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
8514 (main): Don't invoke strlen when not needed.
8516 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
8517 (XD_DEBUG_MESSAGE): Don't waste a byte.
8519 * callproc.c (getenv_internal_1, getenv_internal)
8521 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
8523 * lread.c (invalid_syntax): Omit length argument.
8524 All uses changed. This doesn't fix a bug, but it simplifies the
8525 code away from its former Hollerith-constant appearance, and it's
8526 one less 'int' to worry about when looking at integer-overflow issues.
8527 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
8529 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
8530 This didn't break anything, but it didn't help either.
8531 It's confusing to put a bogus integer in a place where the actual
8532 value does not matter.
8533 (LIST_END_P): Remove unused macro and its bogus comment.
8534 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
8536 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
8537 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
8539 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
8540 We prefer signed types, and the value cannot exceed the EMACS_INT
8541 range anyway (because otherwise the length would not be representable).
8542 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
8543 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
8544 This avoids a GCC warning when WIDE_EMACS_INT.
8546 * indent.c (sane_tab_width): New function.
8547 (current_column, scan_for_column, Findent_to, position_indentation)
8548 (compute_motion): Use it. This is just for clarity.
8549 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
8551 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
8553 * lisp.h (lint_assume): New macro.
8554 * composite.c (composition_gstring_put_cache):
8555 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
8557 * editfns.c, insdel.c:
8558 Omit unnecessary forward decls, to simplify future changes.
8560 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
8562 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
8564 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
8565 Use much-faster test for byte-length change.
8566 Don't assume string byte-length fits in 'int'.
8567 Check that character arg fits in 'int'.
8568 (mapcar1): Declare byte as byte, for clarity.
8570 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
8572 * fns.c (concat): Catch string overflow earlier.
8573 Do not rely on integer wraparound.
8575 * dispextern.h (struct it.overlay_strings_charpos)
8576 (struct it.selective): Now EMACS_INT, not int.
8577 * xdisp.c (forward_to_next_line_start)
8578 (back_to_previous_visible_line_start)
8579 (reseat_at_next_visible_line_start, next_element_from_buffer):
8580 Don't arbitrarily truncate the value of 'selective' to int.
8582 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
8584 * composite.c: Don't truncate sizes to 'int'.
8585 (composition_gstring_p, composition_reseat_it)
8586 (composition_adjust_point): Use EMACS_INT, not int.
8587 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
8588 not EMACS_UINT, for indexes.
8590 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
8592 * buffer.c: Include <verify.h>.
8593 (struct sortvec.priority, struct sortstr.priority):
8594 Now EMACS_INT, not int.
8595 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
8596 (struct sortstr.size, record_overlay_string)
8597 (struct sortstrlist.size, struct sortlist.used):
8598 Don't truncate size to int.
8599 (record_overlay_string): Check for size-calculation overflow.
8600 (init_buffer_once): Check at compile-time, not run-time.
8602 2011-06-22 Jim Meyering <meyering@redhat.com>
8604 Don't leak an XBM-image-sized buffer
8605 * image.c (xbm_load): Free the image buffer after using it.
8607 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
8610 * composite.c (find_automatic_composition): Omit needless 'return 0;'
8611 that Sun C diagnosed.
8612 * fns.c (secure_hash): Fix pointer signedness issue.
8613 * intervals.c (static_offset_intervals): New function.
8614 (offset_intervals): Use it.
8616 2011-06-21 Leo Liu <sdl.web@gmail.com>
8619 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
8622 * fns.c (secure_hash): Rename from crypto_hash_function and change
8623 the first arg to accept symbols.
8624 (Fsecure_hash): New primitive.
8625 (syms_of_fns): New symbols.
8627 2011-06-20 Deniz Dogan <deniz@dogan.se>
8629 * process.c (Fset_process_buffer): Clarify return value in
8632 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
8634 * dispnew.c (add_window_display_history): Use BVAR.
8636 * xdisp.c (debug_method_add): Use BVAR.
8637 (check_window_end, dump_glyph_matrix, dump_glyph)
8638 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
8640 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
8643 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
8644 check till after the cache is created in init_frame_faces.
8646 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
8648 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
8650 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
8652 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
8653 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
8654 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
8656 Improve buffer-overflow checking (Bug#8873).
8657 * fileio.c (Finsert_file_contents):
8658 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
8659 Remove the old (too-loose) buffer overflow checks.
8660 They weren't needed, since make_gap checks for buffer overflow.
8661 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
8662 The old code merely checked for Emacs fixnum overflow, and relied
8663 on undefined (wraparound) behavior. The new code avoids undefined
8664 behavior, and also checks for ptrdiff_t and/or size_t overflow.
8666 * editfns.c (Finsert_char): Don't dump core with very negative counts.
8667 Tune. Don't use wider integers than needed. Don't use alloca.
8668 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
8670 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
8672 * insdel.c, lisp.h (buffer_overflow): New function.
8673 (insert_from_buffer_1, replace_range, replace_range_2):
8674 * insdel.c (make_gap_larger):
8675 * editfns.c (Finsert_char):
8676 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
8678 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
8680 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
8682 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
8684 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
8685 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
8687 * fileio.c: Don't assume EMACS_INT fits in off_t.
8688 (emacs_lseek): New static function.
8689 (Finsert_file_contents, Fwrite_region): Use it.
8690 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
8692 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
8694 * fns.c: Don't overflow int when computing a list length.
8695 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
8696 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
8697 truncation on 64-bit hosts. Check for QUIT every
8698 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
8699 faster and is responsive enough.
8700 (Flength): Report an error instead of overflowing an integer.
8701 (Fsafe_length): Return a float if the value is not representable
8702 as a fixnum. This shouldn't happen except in contrived situations.
8703 (Fnthcdr, Fsort): Don't assume list length fits in int.
8704 (Fcopy_sequence): Don't assume vector length fits in int.
8706 * alloc.c: Check that resized vectors' lengths fit in fixnums.
8707 (header_size, word_size): New constants.
8708 (allocate_vectorlike): Don't check size overflow here.
8709 (allocate_vector): Check it here instead, since this is the only
8710 caller of allocate_vectorlike that could cause overflow.
8711 Check that the new vector's length is representable as a fixnum.
8713 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
8714 The previous code was bogus. For example, next_almost_prime (32)
8715 returned 39, which is undesirable as it is a multiple of 3; and
8716 next_almost_prime (24) returned 25, which is a multiple of 5 so
8717 why was the code bothering to check for multiples of 7?
8719 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
8721 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
8723 Variadic C functions now count arguments with ptrdiff_t.
8724 This partly undoes my 2011-03-30 change, which replaced int with size_t.
8725 Back then I didn't know that the Emacs coding style prefers signed int.
8726 Also, in the meantime I found a few more instances where arguments
8727 were being counted with int, which may truncate counts on 64-bit
8728 machines, or EMACS_INT, which may be unnecessarily wide.
8729 * lisp.h (struct Lisp_Subr.function.aMANY)
8730 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
8731 Arg counts are now ptrdiff_t, not size_t.
8732 All variadic functions and their callers changed accordingly.
8733 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
8734 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
8735 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
8736 * callint.c (Fcall_interactively): Check arg count for overflow,
8737 to avoid potential buffer overrun. Use signed char, not 'int',
8738 for 'varies' array, so that we needn't bother to check its size
8739 calculation for overflow.
8740 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
8741 * eval.c (apply_lambda):
8742 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
8743 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
8744 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
8746 * callint.c (Fcall_interactively): Don't use index var as event count.
8748 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
8749 * mem-limits.h (SIZE): Remove; no longer used.
8751 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
8753 Remove unnecessary casts.
8754 * xterm.c (x_term_init):
8755 * xfns.c (x_set_border_pixel):
8756 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
8757 These aren't needed now that we assume ANSI C.
8759 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
8760 It's more likely to cause problems (due to unsigned overflow)
8763 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
8765 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
8767 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
8769 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
8771 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
8773 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
8775 GLYPH_CODE_FACE returns EMACS_INT, not int.
8776 * dispextern.h (merge_faces):
8777 * xfaces.c (merge_faces):
8778 * xdisp.c (get_next_display_element, next_element_from_display_vector):
8779 Don't assume EMACS_INT fits in int.
8781 * character.h (CHAR_VALID_P): Remove unused parameter.
8782 * fontset.c, lisp.h, xdisp.c: All uses changed.
8784 * editfns.c (Ftranslate_region_internal): Omit redundant test.
8786 * fns.c (concat): Minor tuning based on overflow analysis.
8787 This doesn't fix any bugs. Use int to hold character, instead
8788 of constantly refetching from Emacs object. Use XFASTINT, not
8789 XINT, for value known to be a character. Don't bother comparing
8790 a single byte to 0400, as it's always less.
8792 * floatfns.c (Fexpt):
8793 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
8795 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
8798 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
8800 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
8801 Without this fix, on a 64-bit host (aset S 0 4294967386) would
8802 incorrectly succeed when S was a string, because 4294967386 was
8803 truncated before it was used.
8805 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
8806 Otherwise, an out-of-range integer could cause undefined behavior
8809 * composite.c: Use int, not EMACS_INT, for characters.
8810 (fill_gstring_body, composition_compute_stop_pos): Use int, not
8811 EMACS_INT, for values that are known to be in character range.
8812 This doesn't fix any bugs but is the usual style inside Emacs and
8813 may generate better code on 32-bit machines.
8815 Make sure a 64-bit char is never passed to ENCODE_CHAR.
8816 This is for reasons similar to the recent CHAR_STRING fix.
8817 * charset.c (Fencode_char): Check that character arg is actually
8818 a character. Pass an int to ENCODE_CHAR.
8819 * charset.h (ENCODE_CHAR): Verify that the character argument is no
8820 wider than 'int', as a compile-time check to prevent future regressions
8823 * character.c (char_string): Remove unnecessary casts.
8825 Make sure a 64-bit char is never passed to CHAR_STRING.
8826 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
8827 by silently ignoring the top 32 bits, allowing some values
8828 that were far too large to be valid characters.
8829 * character.h: Include <verify.h>.
8830 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
8831 arguments are no wider than unsigned, as a compile-time check
8832 to prevent future regressions in this area.
8834 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
8835 (Fsubst_char_in_region):
8837 * xdisp.c (decode_mode_spec_coding):
8838 Adjust to CHAR_STRING's new requirement.
8839 * editfns.c (Finsert_char, Fsubst_char_in_region):
8840 * fns.c (concat): Check that character args are actually
8841 characters. Without this test, these functions did the wrong
8842 thing with wildly out-of-range values on 64-bit hosts.
8844 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
8845 These casts should not be needed on 32-bit hosts, either.
8846 * keyboard.c (read_char):
8847 * lread.c (Fload): Remove casts to unsigned.
8849 * lisp.h (UNSIGNED_CMP): New macro.
8850 This fixes comparison bugs on 64-bit hosts.
8851 (ASCII_CHAR_P): Use it.
8852 * casefiddle.c (casify_object):
8853 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
8854 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
8855 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
8856 * dispextern.h (FACE_FROM_ID):
8857 * keyboard.c (read_char): Use UNSIGNED_CMP.
8859 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
8860 not to EMACS_INT, to avoid GCC warning.
8862 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
8864 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
8865 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
8866 isn't needed on 32-bit machines.
8868 * buffer.c (Fgenerate_new_buffer_name):
8869 Use EMACS_INT for count, not int.
8870 (advance_to_char_boundary): Return EMACS_INT, not int.
8872 * data.c (Qcompiled_function): Now static.
8874 * window.c (window_body_lines): Now static.
8876 * image.c (gif_load): Rename local to avoid shadowing.
8878 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
8879 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
8880 * alloc.c (make_save_value): Integer argument is now of type
8882 (mark_object): Use ptrdiff_t, not int.
8883 * lisp.h (pD): New macro.
8884 * print.c (print_object): Use it.
8886 * alloc.c: Use EMACS_INT, not int, to count objects.
8887 (total_conses, total_markers, total_symbols, total_vector_size)
8888 (total_free_conses, total_free_markers, total_free_symbols)
8889 (total_free_floats, total_floats, total_free_intervals)
8890 (total_intervals, total_strings, total_free_strings):
8891 Now EMACS_INT, not int. All uses changed.
8892 (Fgarbage_collect): Compute overall total using a double, so that
8893 integer overflow is less likely to be a problem. Check for overflow
8894 when converting back to an integer.
8895 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
8896 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
8897 These were 'int' variables that could overflow on 64-bit hosts;
8898 they were never used, so remove them instead of repairing them.
8899 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
8900 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
8901 Previously, this ceilinged at INT_MAX, but that doesn't work on
8903 (allocate_pseudovector): Don't use EMACS_INT when int would do.
8905 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
8906 (allocate_vectorlike): Check for ptrdiff_t overflow.
8907 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
8908 when a (possibly-narrower) signed value would do just as well.
8909 We prefer using signed arithmetic, to avoid comparison confusion.
8911 * alloc.c: Catch some string size overflows that we were missing.
8912 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
8913 for convenience in STRING_BYTES_MAX.
8914 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
8915 The definition here is exact; the one in lisp.h was approximate.
8916 (allocate_string_data): Check for string overflow. This catches
8917 some instances we weren't catching before. Also, it catches
8918 size_t overflow on (unusual) hosts where SIZE_MAX <= min
8919 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
8920 and ptrdiff_t and EMACS_INT are both 64 bits.
8922 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
8923 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
8924 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
8926 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
8928 * alloc.c (Fmake_string): Check for out-of-range init.
8930 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
8932 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
8934 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
8936 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
8937 xg_get_default_scrollbar_width.
8939 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
8940 (int_gtk_range_get_value): Move to the scroll bar part of the file.
8941 (style_changed_cb): Call update_theme_scrollbar_width and call
8942 x_set_scroll_bar_default_width and xg_frame_set_char_size for
8943 all frames (Bug#8505).
8944 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
8945 Call gtk_window_set_resizable if HAVE_GTK3.
8946 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
8947 and height if HAVE_GTK3 (Bug#8505).
8948 (scroll_bar_width_for_theme): New variable.
8949 (update_theme_scrollbar_width): New function.
8950 (xg_get_default_scrollbar_width): Move code to
8951 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
8952 (xg_initialize): Call update_theme_scrollbar_width.
8954 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
8956 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
8958 2011-06-12 Martin Rudalics <rudalics@gmx.at>
8960 * frame.c (make_frame): Call other_buffer_safely instead of
8963 * window.c (temp_output_buffer_show): Call display_buffer with
8964 second argument Vtemp_buffer_show_specifiers and reset latter
8965 immediately after the call.
8966 (Vtemp_buffer_show_specifiers): New variable.
8967 (auto_window_vscroll_p, next_screen_context_lines)
8968 (Vscroll_preserve_screen_position): Remove leading asterisks from
8971 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
8973 Fix minor problems found by GCC 4.6.0 static checking.
8974 * buffer.c (Qclone_number): Remove for now, as it's unused.
8975 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
8976 (record_buffer): Remove unused local.
8977 * frame.c (other_visible_frames, frame_buffer_list): Now static.
8978 (set_frame_buffer_list): Remove; unused.
8979 * frame.h (other_visible_frames): Remove decl.
8980 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
8981 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
8982 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
8984 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
8985 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
8986 Define only if HAVE_GPM.
8987 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
8988 (update_hints_inhibit): Remove; never set. All uses removed.
8989 * widgetprv.h (emacsFrameClassRec): Remove decl.
8990 * window.c (delete_deletable_window): Now returns void, since it
8991 wasn't returning anything.
8992 (compare_window_configurations): Remove unused locals.
8993 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
8994 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
8995 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
8996 the same widths as pointers. This follows up on the 2011-05-06 patch.
8997 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
8998 * xterm.h: Likewise.
8999 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
9001 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
9003 * makefile.w32-in: Update dependencies.
9004 (LISP_H): Add lib/intprops.h.
9006 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
9008 * image.c (gif_load): Add animation frame delay to the metadata.
9009 (syms_of_image): Use DEFSYM. New symbol `delay'.
9011 2011-06-11 Martin Rudalics <rudalics@gmx.at>
9013 * window.c (delete_deletable_window): Re-add.
9014 (Fset_window_configuration): Rewrite to handle dead buffers and
9015 consequently deletable windows.
9016 (window_tree, Fwindow_tree): Remove. Supply functionality in
9018 (compare_window_configurations): Simplify code.
9020 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
9022 * image.c (imagemagick_load_image): Fix type mismatch.
9023 (Fimagemagick_types): Likewise.
9025 * window.h (replace_buffer_in_windows): Declare.
9027 2011-06-11 Martin Rudalics <rudalics@gmx.at>
9029 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
9030 Qclone_number. Remove external declaration of Qdelete_window.
9031 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
9033 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
9034 Run Qbuffer_list_update_hook if allowed.
9035 (Fother_buffer): Rewrite doc-string. Major rewrite for new
9036 buffer list implementation.
9037 (other_buffer_safely): New function.
9038 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
9039 calls to replace_buffer_in_windows and
9040 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
9042 (record_buffer): Inhibit quitting and rewrite using quittable
9043 functions. Run Qbuffer_list_update_hook if allowed.
9044 (Frecord_buffer, Funrecord_buffer): New functions.
9045 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
9046 Move switch-to-buffer to window.el.
9047 (bury-buffer): Move to window.el.
9048 (Vbuffer_list_update_hook): New variable.
9050 * lisp.h (other_buffer_safely): Add prototype in buffer.c
9053 * window.h (resize_frame_windows): Move up in code.
9054 (Fwindow_frame): Remove EXFUN.
9055 (replace_buffer_in_all_windows): Remove prototype.
9056 (replace_buffer_in_windows_safely): Add prototype.
9058 * window.c: Declare Qdelete_window static again. Move down
9059 declaration of select_count.
9060 (Fnext_window, Fprevious_window): Rewrite doc-strings.
9061 (Fother_window): Move to window.el.
9062 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
9063 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
9064 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
9066 (replace_buffer_in_windows): Implement by calling
9067 Qreplace_buffer_in_windows.
9068 (replace_buffer_in_all_windows): Remove with some functionality
9069 moved into replace_buffer_in_windows_safely.
9070 (replace_buffer_in_windows_safely): New function.
9071 (select_window_norecord, select_frame_norecord): Move in front
9072 of run_window_configuration_change_hook. Remove now obsolete
9074 (Fset_window_buffer): Rewrite doc-string.
9075 Call Qrecord_window_buffer.
9076 (keys_of_window): Move binding for other-window to window.el.
9078 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
9080 * dispextern.h (struct image): Replace data member, whose int_val
9081 and ptr_val fields were not used by anything, with a single
9084 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
9085 (gif_clear_image, gif_load, imagemagick_load_image)
9086 (gs_clear_image, gs_load): Callers changed.
9088 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
9090 * buffer.h: Include <time.h>, for time_t.
9091 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
9093 Fix minor problems found by static checking.
9095 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
9097 Make identifiers static if they are not used in other modules.
9098 * data.c (Qcompiled_function, Qframe, Qvector):
9099 * image.c (QimageMagick, Qsvg):
9100 * minibuf.c (Qmetadata):
9101 * window.c (resize_window_check, resize_root_window): Now static.
9102 * window.h (resize_window_check, resize_root_window): Remove decls.
9104 * window.c (window_deletion_count, delete_deletable_window):
9106 (window_body_lines): Now static.
9107 (Fdelete_other_windows_internal): Mark vars as initialized.
9108 Make sure 'resize_failed' is initialized.
9109 (run_window_configuration_change_hook): Rename local to avoid shadowing.
9110 (resize_window_apply): Remove unused local.
9111 * window.h (delete_deletable_window): Remove decl.
9113 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
9114 (imagemagick_load_image): Fix pointer signedness problem by changing
9115 last arg from unsigned char * to char *. All uses changed.
9116 Also, fix a local for similar reasons.
9117 Remove unused locals. Remove locals to avoid shadowing.
9118 (fn_rsvg_handle_free): Remove; unused.
9119 (svg_load, svg_load_image): Fix pointer signedness problem.
9120 (imagemagick_load_image): Don't use garbage pointer image_wand.
9122 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
9124 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
9126 * image.c (gif_load): Fix omitted cast error introduced by
9129 2011-06-10 Martin Rudalics <rudalics@gmx.at>
9131 * window.h (resize_proportionally, orig_total_lines)
9132 (orig_top_line): Remove from window structure.
9133 (set_window_height, set_window_width, change_window_heights)
9134 (Fdelete_window): Remove prototypes.
9135 (resize_frame_windows): Remove duplicate declaration.
9137 2011-06-10 Eli Zaretskii <eliz@gnu.org>
9139 * window.h (resize_frame_windows, resize_window_check)
9140 (delete_deletable_window, resize_root_window)
9141 (resize_frame_windows): Declare prototypes.
9143 * window.c (resize_window_apply): Make definition be "static" to
9144 match the prototype.
9146 2011-06-10 Martin Rudalics <rudalics@gmx.at>
9148 * window.c: Remove declarations of Qwindow_size_fixed,
9149 window_min_size_1, window_min_size_2, window_min_size,
9150 size_window, window_fixed_size_p, enlarge_window, delete_window.
9151 Remove static from declaration of Qdelete_window, it's
9152 temporarily needed by Fbury_buffer.
9153 (replace_window): Don't assign orig_top_line and
9155 (Fdelete_window, delete_window): Remove. Window deletion is
9156 handled by window.el.
9157 (window_loop): Remove DELETE_OTHER_WINDOWS case.
9158 Replace Fdelete_window calls with calls to Qdelete_window.
9159 (Fdelete_other_windows): Remove. Deleting other windows is
9160 handled by window.el.
9161 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
9162 handled in window.el.
9163 (window_min_size_2, window_min_size_1, window_min_size): Remove.
9164 Window minimum sizes are handled in window.el.
9165 (shrink_windows, size_window, set_window_height)
9166 (set_window_width, change_window_heights, window_height)
9167 (window_width, CURBEG, CURSIZE, enlarge_window)
9168 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
9169 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
9170 handled in window.el.
9171 (make_dummy_parent): Rename to make_parent_window and give it a
9172 second argument horflag.
9173 (make_window): Don't set resize_proportionally any more.
9174 (Fsplit_window): Remove. Windows are split in window.el.
9175 (save_restore_action, save_restore_orig_size)
9176 (shrink_window_lowest_first, save_restore_orig_size): Remove.
9177 Resize mini windows in window.el.
9178 (grow_mini_window, shrink_mini_window): Implement by calling
9179 Qresize_root_window_vertically, resize_window_check and
9180 resize_window_apply.
9181 (saved_window, Fset_window_configuration, save_window_save):
9182 Do not handle orig_top_line, orig_total_lines, and
9183 resize_proportionally.
9184 (window_min_height, window_min_width): Move to window.el.
9185 (keys_of_window): Move bindings for delete-other-windows,
9186 split-window, delete-window and enlarge-window to window.el.
9188 * buffer.c: Temporarily extern Qdelete_window.
9189 (Fbury_buffer): Temporarily call Qdelete_window instead of
9190 Fdelete_window (Fbury_buffer will move to window.el soon).
9192 * frame.c (set_menu_bar_lines_1): Remove code handling
9193 orig_top_line and orig_total_lines.
9195 * dispnew.c (adjust_frame_glyphs_initially): Don't use
9196 set_window_height but set heights directly.
9197 (change_frame_size_1): Use resize_frame_windows.
9199 * xdisp.c (init_xdisp): Don't use set_window_height but set
9202 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
9203 Use resize_frame_windows instead of change_window_heights and run
9204 run_window_configuration_change_hook.
9206 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
9207 instead of change_window_heights and run
9208 run_window_configuration_change_hook.
9210 2011-06-09 Martin Rudalics <rudalics@gmx.at>
9212 * window.c (replace_window): Rename second argument REPLACEMENT to
9213 NEW. New third argument SETFLAG. Rewrite.
9214 (delete_window, make_dummy_parent): Call replace_window with
9216 (window_list_1): Move down in code.
9217 (run_window_configuration_change_hook): Move set_buffer part
9218 before select_frame_norecord part in order to unwind correctly.
9219 Rename count1 to count.
9220 (recombine_windows, delete_deletable_window, resize_root_window)
9221 (Fdelete_other_windows_internal)
9222 (Frun_window_configuration_change_hook, make_parent_window)
9223 (resize_window_check, resize_window_apply, Fresize_window_apply)
9224 (resize_frame_windows, Fsplit_window_internal)
9225 (Fdelete_window_internal, Fresize_mini_window_internal):
9227 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
9229 2011-06-08 Martin Rudalics <rudalics@gmx.at>
9231 * window.h (window): Add some new members to window structure -
9232 normal_lines, normal_cols, new_total, new_normal, clone_number,
9233 splits, nest, prev_buffers, next_buffers.
9234 (WINDOW_TOTAL_SIZE): Move here from window.c.
9235 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
9237 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
9239 (make_dummy_parent): Set new members of windows structure.
9240 (make_window): Move down in code. Handle new members of window
9242 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
9243 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
9244 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
9245 (Fset_window_prev_buffers, Fwindow_next_buffers)
9246 (Fset_window_next_buffers, Fset_window_clone_number):
9248 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
9249 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
9251 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
9252 Argument WINDOW can be now internal window too.
9253 (Fwindow_use_time): Move up in code.
9254 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
9256 (Fset_window_configuration, saved_window)
9257 (Fcurrent_window_configuration, save_window_save): Handle new
9258 members of window structure.
9259 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
9260 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
9261 (syms_of_window): New Lisp objects Qrecord_window_buffer,
9262 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
9263 Qget_mru_window, Qresize_root_window,
9264 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
9265 Qauto_buffer_name; staticpro them.
9267 2011-06-07 Martin Rudalics <rudalics@gmx.at>
9269 * window.c (Fwindow_total_size, Fwindow_left_column)
9270 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
9271 (Fwindow_list_1): New functions.
9272 (window_box_text_cols): Replace with window_body_cols.
9273 (Fwindow_width, Fscroll_left, Fscroll_right):
9274 Use window_body_cols instead of window_box_text_cols.
9275 (delete_window, Fset_window_configuration):
9276 Call delete_all_subwindows with window as argument.
9277 (delete_all_subwindows): Take a window as argument and not a
9279 (window_loop): Remove handling of GET_LRU_WINDOW and
9281 (Fget_lru_window, Fget_largest_window): Move to window.el.
9283 * window.h: Extern window_body_cols instead of
9284 window_box_text_cols. delete_all_subwindows now takes a
9285 Lisp_Object as argument.
9287 * indent.c (compute_motion, Fcompute_motion):
9288 Use window_body_cols instead of window_box_text_cols.
9290 * frame.c (delete_frame): Call delete_all_subwindows with root
9293 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
9295 * fns.c (Fputhash): Document return value.
9297 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
9299 * image.c (gif_load): Implement gif89a spec "no disposal" method.
9301 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9303 Cons<->int and similar integer overflow fixes (Bug#8794).
9305 Check for overflow when converting integer to cons and back.
9306 * charset.c (Fdefine_charset_internal, Fdecode_char):
9307 Use cons_to_unsigned to catch overflow.
9308 (Fencode_char): Use INTEGER_TO_CONS.
9309 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
9310 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
9311 * data.c (long_to_cons, cons_to_long): Remove.
9312 (cons_to_unsigned, cons_to_signed): New functions.
9313 These signal an error for invalid or out-of-range values.
9314 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
9315 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
9316 * font.c (Ffont_variation_glyphs):
9317 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
9318 * lisp.h: Include <intprops.h>.
9319 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
9320 (cons_to_signed, cons_to_unsigned): New decls.
9321 (long_to_cons, cons_to_long): Remove decls.
9322 * undo.c (record_first_change): Use INTEGER_TO_CONS.
9323 (Fprimitive_undo): Use CONS_TO_INTEGER.
9324 * xfns.c (Fx_window_property): Likewise.
9325 * xselect.c: Include <limits.h>.
9326 (x_own_selection, selection_data_to_lisp_data):
9327 Use INTEGER_TO_CONS.
9328 (x_handle_selection_request, x_handle_selection_clear)
9329 (x_get_foreign_selection, Fx_disown_selection_internal)
9330 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
9331 (lisp_data_to_selection_data): Use cons_to_unsigned.
9332 (x_fill_property_data): Use cons_to_signed.
9333 Report values out of range.
9335 Check for buffer and string overflow more precisely.
9336 * buffer.h (BUF_BYTES_MAX): New macro.
9337 * lisp.h (STRING_BYTES_MAX): New macro.
9338 * alloc.c (Fmake_string):
9339 * character.c (string_escape_byte8):
9340 * coding.c (coding_alloc_by_realloc):
9341 * doprnt.c (doprnt):
9342 * editfns.c (Fformat):
9344 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
9345 since they may not be the same number.
9346 * editfns.c (Finsert_char):
9347 * fileio.c (Finsert_file_contents):
9348 Likewise for BUF_BYTES_MAX.
9350 * image.c: Use ptrdiff_t, not int, for sizes.
9351 (slurp_file): Switch from int to ptrdiff_t.
9353 (slurp_file): Check that file size fits in both size_t (for
9354 malloc) and ptrdiff_t (for sanity and safety).
9356 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
9357 if b->modtime has its maximal value.
9359 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
9361 Don't assume time_t can fit into int.
9362 * buffer.h (struct buffer.modtime): Now time_t, not int.
9363 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
9364 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
9366 Minor fixes for signed vs unsigned integers.
9367 * character.h (MAYBE_UNIFY_CHAR):
9368 * charset.c (maybe_unify_char):
9369 * keyboard.c (read_char, reorder_modifiers):
9370 XINT -> XFASTINT, since the integer must be nonnegative.
9371 * ftfont.c (ftfont_spec_pattern):
9372 * keymap.c (access_keymap, silly_event_symbol_error):
9373 XUINT -> XFASTINT, since the integer must be nonnegative.
9374 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
9375 since it makes no difference and we prefer signed.
9376 * keyboard.c (record_char): Use XUINT when all the neighbors do.
9377 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
9380 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
9382 * window.h (Fwindow_frame): Declare.
9384 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9386 * alloc.c: Simplify handling of large-request failures (Bug#8800).
9387 (SPARE_MEMORY): Always define.
9388 (LARGE_REQUEST): Remove.
9389 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
9391 2011-06-06 Martin Rudalics <rudalics@gmx.at>
9393 * lisp.h: Move EXFUNS for Fframe_root_window,
9394 Fframe_first_window and Fset_frame_selected_window to window.h.
9396 * window.h: Move EXFUNS for Fframe_root_window,
9397 Fframe_first_window and Fset_frame_selected_window here from
9400 * frame.c (Fwindow_frame, Fframe_first_window)
9401 (Fframe_root_window, Fframe_selected_window)
9402 (Fset_frame_selected_window): Move to window.c.
9403 (Factive_minibuffer_window): Move to minibuf.c.
9404 (Fother_visible_frames_p): New function.
9406 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
9408 * window.c (decode_window, decode_any_window): Move up in code.
9409 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
9410 (inhibit_frame_unsplittable): Remove unused variable.
9411 (Fwindow_buffer): Move up and rewrite doc-string.
9412 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
9413 (Fwindow_prev): New functions.
9414 (Fwindow_frame): Move here from frame.c. Accept any window as
9416 (Fframe_root_window, Fframe_first_window)
9417 (Fframe_selected_window): Move here from frame.c. Accept frame
9418 or arbitrary window as argument. Update doc-strings.
9419 (Fminibuffer_window): Move up in code.
9420 (Fwindow_minibuffer_p): Move up in code and simplify.
9421 (Fset_frame_selected_window): Move here from frame.c.
9423 (Fselected_window, select_window, Fselect_window): Move up in
9424 code. Minor doc-string fixes.
9426 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9428 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
9429 Do not assume that spare memory exists; that assumption is valid
9430 only if SYSTEM_MALLOC.
9431 (LARGE_REQUEST): New macro, so that the issue of large requests
9432 is separated from the issue of spare memory.
9434 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
9436 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
9439 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
9441 * xfns.c (x_set_scroll_bar_default_width): Move declarations
9444 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
9446 * gtkutil.c (xg_get_default_scrollbar_width): New function.
9448 * gtkutil.h: Declare xg_get_default_scrollbar_width.
9450 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
9451 min width by calling x_set_scroll_bar_default_width (Bug#8505).
9453 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
9455 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
9457 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
9459 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
9460 (x_clipboard_manager_save): Add return value.
9461 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
9463 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
9464 Obey Vx_select_enable_clipboard_manager. Catch errors in
9465 x_clipboard_manager_save (Bug#8779).
9466 (Vx_select_enable_clipboard_manager): New variable.
9467 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
9469 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
9471 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
9473 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9475 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
9476 in the current matrix if keep_current_p is non-zero.
9478 2011-06-04 Eli Zaretskii <eliz@gnu.org>
9480 * bidi.c (bidi_level_of_next_char): Fix last change.
9482 2011-06-03 Eli Zaretskii <eliz@gnu.org>
9484 Support bidi reordering of text covered by display properties.
9486 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
9487 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
9488 (bidi_cache_search, bidi_cache_iterator_state)
9489 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
9490 (bidi_level_of_next_char, bidi_move_to_visually_next):
9491 Support character positions inside a run of characters covered by a
9493 (bidi_paragraph_init, bidi_resolve_explicit_1)
9494 (bidi_level_of_next_char): Call bidi_fetch_char and
9495 bidi_fetch_char_advance instead of FETCH_CHAR and
9497 (bidi_init_it): Initialize new members.
9498 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
9500 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
9501 instead of using explicit *_CHAR codes.
9502 (bidi_resolve_explicit, bidi_resolve_weak):
9503 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
9504 bidirectional text is supported only in multibyte buffers.
9505 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
9506 it to initialize the frame_window_p member of struct bidi_it.
9507 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
9508 (bidi_resolve_explicit, bidi_resolve_weak)
9509 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
9510 bidi_it->nchars is non-positive.
9511 (bidi_level_of_next_char): Don't try to lookup the cache for the
9512 next/previous character if nothing is cached there yet, or if we
9513 were just reseat()'ed to a new position.
9515 * xdisp.c (set_cursor_from_row): Set start and stop points
9516 according to the row's direction when priming the loop that looks
9517 for the glyph on which to display cursor.
9518 (single_display_spec_intangible_p): Function deleted.
9519 (display_prop_intangible_p): Reimplement to call
9520 handle_display_spec instead of single_display_spec_intangible_p.
9521 Accept 3 additional arguments needed by handle_display_spec.
9522 This fixes incorrect cursor motion across display property with complex
9523 values: lists, `(when COND...)' forms, etc.
9524 (single_display_spec_string_p): Support property values that are
9525 lists with the argument STRING its top-level element.
9526 (display_prop_string_p): Fix the condition for processing a
9527 property that is a list to be consistent with handle_display_spec.
9528 (handle_display_spec): New function, refactored from the
9529 last portion of handle_display_prop.
9530 (compute_display_string_pos): Accept additional argument
9531 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
9532 value of a `display' property is a "replacing spec".
9533 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
9534 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
9535 the display property, but just return a value indicating whether
9536 the display property will replace the characters it covers.
9537 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
9538 frame_window_p members of struct bidi_it.
9539 (compute_display_string_pos, compute_display_string_end):
9541 (push_it): Accept second argument POSITION, where pop_it should
9542 jump to continue iteration.
9543 (reseat_1): Initialize bidi_it.disp_pos.
9545 * keyboard.c (adjust_point_for_property): Adjust the call to
9546 display_prop_intangible_p to its new signature.
9548 * dispextern.h (struct bidi_it): New member frame_window_p.
9549 (bidi_init_it): Update prototypes.
9550 (display_prop_intangible_p): Update prototype.
9551 (compute_display_string_pos, compute_display_string_end):
9553 (struct bidi_it): New members nchars and disp_pos. ch_len is now
9556 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
9558 Malloc failure behavior now depends on size of allocation.
9559 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
9560 * lisp.h: Change signatures accordingly.
9561 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
9562 All callers changed. (Bug#8762)
9564 * gnutls.c: Use Emacs's memory allocators.
9565 Without this change, the gnutls library would invoke malloc etc.
9566 directly, which causes problems on non-SYNC_INPUT hosts, and which
9567 runs afoul of improving memory_full behavior. (Bug#8761)
9568 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
9569 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
9570 xfree instead of the default malloc, realloc, free.
9571 (Fgnutls_boot): No need to check for memory allocation failure,
9572 since xmalloc does that for us.
9574 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
9575 * category.c (hash_get_category_set):
9576 * ccl.c (ccl_driver):
9577 * charset.c (Fdefine_charset_internal):
9578 * charset.h (struct charset.hash_index):
9579 * composite.c (get_composition_id, gstring_lookup_cache)
9580 (composition_gstring_put_cache):
9581 * composite.h (struct composition.hash_index):
9582 * dispextern.h (struct image.hash):
9583 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
9584 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
9585 (hashfn_equal, hashfn_user_defined, make_hash_table)
9586 (maybe_resize_hash_table, hash_lookup, hash_put)
9587 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
9588 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
9589 (Fsxhash, Fgethash, Fputhash, Fmaphash):
9590 * image.c (make_image, search_image_cache, lookup_image)
9591 (xpm_put_color_table_h):
9592 * lisp.h (struct Lisp_Hash_Table):
9593 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
9594 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
9595 for hashes and hash indexes, instead of 'unsigned' and 'int'.
9596 * alloc.c (allocate_vectorlike):
9597 Check for overflow in vector size calculations.
9598 * ccl.c (ccl_driver):
9599 Check for overflow when converting EMACS_INT to int.
9600 * fns.c, image.c: Remove unnecessary static decls that would otherwise
9601 need to be updated by these changes.
9602 * fns.c (make_hash_table, maybe_resize_hash_table):
9603 Check for integer overflow with large hash tables.
9604 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
9605 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
9606 (SXHASH_REDUCE): New macro.
9607 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
9608 Use it instead of discarding useful hash info with large hash values.
9609 (sxhash_float): New function.
9610 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
9611 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
9612 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
9613 Rewrite to use FIXNUM_BITS, as this simplifies things.
9614 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
9615 Adjust signatures to match updated version of code.
9616 (consing_since_gc): Now EMACS_INT, since a single hash table can
9617 use more than INT_MAX bytes.
9619 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
9621 Make it possible to build with GCC-4.6+ -O2 -flto.
9623 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
9625 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
9627 * minibuf.c (get_minibuffer, read_minibuf_unwind):
9628 Call minibuffer-inactive-mode.
9630 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
9632 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
9633 Update dependencies.
9635 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9637 * data.c (init_data): Remove code for UTS, this system is not
9640 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9642 Don't force ./temacs to start in terminal mode.
9644 * frame.c (make_initial_frame): Initialize faces in all cases, not
9645 only when CANNOT_DUMP is defined.
9646 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
9648 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9650 * dispnew.c (add_window_display_history): Use const for the string
9651 pointer. Remove declaration, not needed.
9653 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9655 Use 'inline', not 'INLINE'.
9656 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
9657 * alloc.c, fontset.c (INLINE): Remove.
9658 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
9659 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
9660 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
9661 * gmalloc.c (register_heapinfo): Use inline unconditionally.
9662 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
9664 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9666 Make it possible to run ./temacs.
9668 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
9669 syms_of_callproc does the same thing. Remove test for
9670 "initialized", do it in the caller.
9671 * emacs.c (main): Avoid calling set_initial_environment when dumping.
9673 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
9675 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
9676 (read_minibuf): Use get_minibuffer.
9677 (syms_of_minibuf): Use DEFSYM.
9678 (Qmetadata): New var.
9679 * data.c (Qbuffer): Don't make it static.
9680 (syms_of_data): Use DEFSYM.
9682 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9684 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
9685 (CCL_CODE_MIN): New macro.
9687 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
9689 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
9691 * eval.c (Qdebug): Now static.
9692 * lisp.h (Qdebug): Remove decl. This reverts a part of the
9693 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
9694 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
9696 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
9698 * image.c: Various fixes to ImageMagick code comments.
9699 (Fimagemagick_types): Doc fix.
9701 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
9703 Minor fixes prompted by GCC 4.6.0 warnings.
9705 * xselect.c (converted_selections, conversion_fail_tag): Now static.
9707 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
9708 (x_clipboard_manager_save_all): Move extern decl to ...
9709 * xterm.h: ... here, so that it can be checked for consistency.
9711 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
9713 * xselect.c (x_clipboard_manager_save_frame)
9714 (x_clipboard_manager_save_all): New functions.
9715 (Fx_clipboard_manager_save): Lisp function deleted.
9717 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
9718 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
9720 * xterm.h: Update prototype.
9722 2011-05-28 William Xu <william.xwl@gmail.com>
9724 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
9727 2011-05-28 Jim Meyering <meyering@redhat.com>
9729 Avoid a sign-extension bug in crypto_hash_function.
9730 * fns.c (to_uchar): Define.
9731 (crypto_hash_function): Use it to convert some newly-signed
9732 variables to unsigned, to avoid sign-extension bugs. For example,
9733 without this change, (md5 "truc") would evaluate to
9734 45723a2aff78ff4fff7fff1114760e62 rather than the expected
9735 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
9736 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
9738 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9740 Integer overflow fixes.
9742 * dbusbind.c: Serial number integer overflow fixes.
9743 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
9744 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
9745 to hold a serial number that is too large for a fixnum.
9746 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9747 Check for serial numbers out of range. Decode any serial number
9748 that was so large that it became a float. (Bug#8722)
9750 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
9751 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9752 Use XFASTINT rather than XUINT when numbers are nonnegative.
9753 (xd_append_arg, Fdbus_method_return_internal):
9754 (Fdbus_method_error_internal): Likewise. Also, for unsigned
9755 arguments, check that Lisp number is nonnegative, rather than
9756 silently wrapping negative numbers around. (Bug#8722)
9757 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
9760 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
9762 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
9764 ccl: Add integer overflow checks.
9765 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
9766 (IN_INT_RANGE): New macros.
9767 (ccl_driver): Use them to check for integer overflow when
9768 decoding a CCL program. Many of the new checks are whether XINT (x)
9769 fits in int; it doesn't always, on 64-bit hosts. The new version
9770 doesn't catch all possible integer overflows, but it's an
9771 improvement. (Bug#8719)
9773 * alloc.c (make_event_array): Use XINT, not XUINT.
9774 There's no need for unsigned here.
9776 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
9777 This follows up to the 2011-05-06 change that substituted uintptr_t
9778 for EMACS_INT. This case wasn't caught back then.
9780 Rework Fformat to avoid integer overflow issues.
9781 * editfns.c: Include <float.h> unconditionally, as it's everywhere
9782 now (part of C89). Include <verify.h>.
9783 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
9784 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
9785 (Fformat): Avoid the prepass trying to compute sizes; it was only
9786 approximate and thus did not catch overflow reliably. Instead, walk
9787 through the format just once, formatting and computing sizes as we go,
9788 checking for integer overflow at every step, and allocating a larger
9789 buffer as needed. Keep track separately whether the format is
9790 multibyte. Keep only the most-recently calculated precision, rather
9791 than them all. Record whether each argument has been converted to
9792 string. Use EMACS_INT, not int, for byte and char and arg counts.
9793 Support field widths and precisions larger than INT_MAX. Avoid
9794 sprintf's undefined behavior with conversion specifications such as %#d
9795 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
9796 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
9797 formatting out-of-range floating point numbers with int
9800 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
9802 * data.c: Avoid integer truncation in expressions involving floats.
9803 * data.c: Include <intprops.h>.
9804 (arith_driver): When there's an integer overflow in an expression
9805 involving floating point, convert the integers to floating point
9806 so that the resulting value does not suffer from catastrophic
9807 integer truncation. For example, on a 64-bit host (* 4
9808 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
9809 Do not rely on undefined behavior after integer overflow.
9811 merge count_size_as_multibyte, parse_str_to_multibyte
9812 * character.c, character.h (count_size_as_multibyte):
9813 Rename from parse_str_to_multibyte; all uses changed.
9814 Check for integer overflow.
9815 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
9816 since it's now a duplicate of the other. This is more of
9817 a character than a buffer op, so better that it's in character.c.
9818 * fns.c, print.c: Adjust to above changes.
9820 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
9822 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
9824 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9826 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9827 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
9828 (x_clipboard_manager_save): Now static.
9829 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
9831 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9832 (crypto_hash_function): Now static.
9833 Fix pointer signedness problems. Avoid unnecessary initializations.
9835 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
9837 * termhooks.h (Vselection_alist): Make it terminal-local.
9839 * terminal.c (create_terminal): Initialize it.
9841 * xselect.c: Support for clipboard managers.
9842 (Vselection_alist): Move to termhooks.h as terminal-local var.
9843 (LOCAL_SELECTION): New macro.
9844 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
9845 (symbol_to_x_atom): Remove gratuitous arg.
9846 (x_handle_selection_request, lisp_data_to_selection_data)
9847 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
9848 (x_own_selection, x_get_local_selection, x_convert_selection):
9849 New arg, specifying work frame. Use terminal-local Vselection_alist.
9850 (some_frame_on_display): Delete unused function.
9851 (Fx_own_selection_internal, Fx_get_selection_internal)
9852 (Fx_disown_selection_internal, Fx_selection_owner_p)
9853 (Fx_selection_exists_p): New optional frame arg.
9854 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
9855 (x_handle_selection_clear): Don't treat other terminals with the
9856 same keyboard specially. Use the terminal-local Vselection_alist.
9857 (x_clear_frame_selections): Use Frun_hook_with_args.
9859 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
9861 * xterm.h: Add support for those atoms.
9863 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
9865 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
9866 (converted_selections, conversion_fail_tag): New global variables.
9867 (x_selection_request_lisp_error): Free the above.
9868 (x_get_local_selection): Remove unnecessary code.
9869 (x_reply_selection_request): Args changed; handle arbitrary array
9870 of converted selections stored in converted_selections.
9871 Separate the XChangeProperty and SelectionNotify steps.
9872 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
9873 (x_convert_selection): New function.
9874 (x_handle_selection_event): Simplify.
9875 (x_get_foreign_selection): Don't ignore incoming requests while
9876 waiting for an answer; this will fail when we implement
9877 SAVE_TARGETS, and seems unnecessary anyway.
9878 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
9879 (Vx_sent_selection_functions): Doc fix.
9881 2011-05-26 Leo Liu <sdl.web@gmail.com>
9883 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
9885 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9887 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
9889 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
9890 for fringe update if it has periodic bitmap.
9891 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
9892 and fringe_bitmap_periodic_p.
9894 * fringe.c (get_fringe_bitmap_data): New function.
9895 (draw_fringe_bitmap_1, update_window_fringes): Use it.
9896 (update_window_fringes): Record periodicity of fringe bitmap in glyph
9897 row. Mark glyph row for fringe update if periodicity changed.
9899 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
9900 for fringe update unless it has periodic bitmap.
9902 2011-05-25 Kenichi Handa <handa@m17n.org>
9904 * xdisp.c (get_next_display_element): Set correct it->face_id for
9905 a static composition.
9907 2011-05-24 Leo Liu <sdl.web@gmail.com>
9910 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
9912 * fns.c (crypto_hash_function, Fsha1): New function.
9913 (Fmd5): Use crypto_hash_function.
9914 (syms_of_fns): Add Ssha1.
9916 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9918 * gnutls.c: Remove unused macros.
9919 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
9920 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
9921 Remove macros that are defined and never used.
9922 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
9924 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
9926 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
9927 (Fx_get_selection_internal): Minor cleanup.
9928 (Fx_own_selection_internal): Rename arguments for consistency with
9931 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9933 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
9935 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
9937 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
9939 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9941 * dispnew.c (scrolling_window): Don't exclude the case that the
9942 last enabled row in the desired matrix touches the bottom boundary.
9944 2011-05-21 Glenn Morris <rgm@gnu.org>
9946 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
9947 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
9948 and add some more files.
9950 2011-05-20 Eli Zaretskii <eliz@gnu.org>
9952 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
9953 report_file_error introduced by the change from 2011-05-07.
9955 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
9957 * systime.h (Time): Define only if emacs is defined.
9958 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
9959 where the include path doesn't have X11/X.h by default. See
9960 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
9962 2011-05-20 Kenichi Handa <handa@m17n.org>
9964 * composite.c (find_automatic_composition): Fix previous change.
9966 2011-05-20 Glenn Morris <rgm@gnu.org>
9968 * lisp.mk: New file, split from Makefile.in.
9969 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
9970 (shortlisp): Remove.
9971 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
9973 2011-05-19 Glenn Morris <rgm@gnu.org>
9975 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
9976 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
9977 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
9978 (lisp): Set the order to that of loadup.el.
9979 (shortlisp): Make it a copy of $lisp.
9980 (SOME_MACHINE_LISP): Remove.
9981 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
9982 Use just $shortlisp, not $SOME_MACHINE_LISP too.
9984 2011-05-18 Kenichi Handa <handa@m17n.org>
9986 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
9987 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
9988 (find_automatic_composition): Mostly rewrite for efficiency.
9990 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
9992 * makefile.w32-in: Update dependencies.
9994 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
9996 * menu.c: Include limits.h (fixes the MS-Windows build broken by
9997 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
9999 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
10001 Fix some integer overflow issues, such as string length overflow.
10003 * insdel.c (count_size_as_multibyte): Check for string overflow.
10005 * character.c (lisp_string_width): Check for string overflow.
10006 Use EMACS_INT, not int, for string indexes and lengths; in
10007 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
10008 the resulting string length overflows an EMACS_INT; instead,
10009 report a string overflow if no precision given. When checking for
10010 precision exhaustion, use a check that cannot possibly have
10011 integer overflow. (Bug#8675)
10012 * character.h (lisp_string_width): Adjust to new signature.
10014 * alloc.c (string_overflow): New function.
10015 (Fmake_string): Use it. This doesn't change behavior, but saves
10016 a few bytes and will simplify future changes.
10017 * character.c (string_escape_byte8): Likewise.
10018 * lisp.h (string_overflow): New decl.
10020 Fixups, following up to the user-interface timestamp change.
10021 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
10022 for UI timestamps, instead of unsigned long.
10023 * msdos.c (mouse_get_pos): Likewise.
10024 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
10025 * w32gui.h (Time): Define by including "systime.h" rather than by
10026 declaring it ourselves. (Bug#8664)
10028 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
10029 * image.c (clear_image_cache): Likewise.
10031 * term.c (term_mouse_position): Don't assume time_t wraparound.
10033 Be more systematic about user-interface timestamps.
10034 Before, the code sometimes used 'Time', sometimes 'unsigned long',
10035 and sometimes 'EMACS_UINT', to represent these timestamps.
10036 This change causes it to use 'Time' uniformly, as that's what X uses.
10037 This makes the code easier to follow, and makes it easier to catch
10038 integer overflow bugs such as Bug#8664.
10039 * frame.c (Fmouse_position, Fmouse_pixel_position):
10040 Use Time, not unsigned long, for user-interface timestamps.
10041 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
10042 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
10043 * keyboard.h (last_event_timestamp): Likewise.
10044 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
10045 * menu.h (xmenu_show): Likewise.
10046 * term.c (term_mouse_position): Likewise.
10047 * termhooks.h (struct input_event.timestamp): Likewise.
10048 (struct terminal.mouse_position_hook): Likewise.
10049 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
10050 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
10051 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
10052 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
10053 what it was before.
10054 * menu.h, termhooks.h: Include "systime.h", for Time.
10056 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
10057 Don't assume that the difference between two unsigned long values
10058 can fit into an integer. At this point, we know button_down_time
10059 <= event->timestamp, so the difference must be nonnegative, so
10060 there's no need to cast the result if double-click-time is
10061 nonnegative, as it should be; check that it's nonnegative, just in
10062 case. This bug is triggered when events are more than 2**31 ms
10063 apart (about 25 days). (Bug#8664)
10065 * xselect.c (last_event_timestamp): Remove duplicate decl.
10066 (x_own_selection): Remove needless cast to unsigned long.
10068 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
10069 that always fit in int. Use a sentinel instead of a counter, to
10070 avoid a temp and to allay GCC's concerns about possible int overflow.
10071 * frame.h (struct frame): Use int for menu_bar_items_used
10072 instead of EMACS_INT, since it always fits in int.
10074 * menu.c (grow_menu_items): Check for int overflow.
10076 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
10078 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
10079 Before, the code was not consistent. These values cannot exceed
10080 2**31 - 1 so there's no need to make them unsigned.
10081 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
10082 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
10083 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
10085 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
10087 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
10088 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
10089 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
10090 presumably because the widths might not match.
10092 * window.c (size_window): Avoid needless test at loop start.
10094 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
10096 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
10098 2011-05-12 Drew Adams <drew.adams@oracle.com>
10100 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
10102 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10104 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
10105 `width' to `bar_area_x' and `bar_area_width', respectively.
10106 (x_scroll_run): Take account of fringe background extension.
10108 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
10109 Rename local vars `left' and `width' to `bar_area_x' and
10110 `bar_area_width', respectively.
10111 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
10112 background extension.
10114 2011-05-10 Jim Meyering <meyering@redhat.com>
10116 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
10118 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
10120 * image.c (Finit_image_library): Return t for built-in image types,
10121 like pbm and xbm. (Bug#8640)
10123 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
10125 * w32menu.c (set_frame_menubar): Fix submenu allocation.
10127 2011-05-07 Eli Zaretskii <eliz@gnu.org>
10129 * w32console.c (Fset_screen_color): Doc fix.
10130 (Fget_screen_color): New function.
10131 (syms_of_ntterm): Defsubr it.
10133 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
10134 unlink the temporary file if Fcall_process didn't create it in the
10136 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
10137 child process will be redirected to a file specified with `:file'.
10138 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
10139 cue to call_process_cleanup not to close that handle.
10141 2011-05-07 Ben Key <bkey76@gmail.com>
10143 * makefile.w32-in: The bootstrap-temacs rule now makes use of
10144 one of two shell specific rules, either bootstrap-temacs-CMD or
10145 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
10146 to the previous implementation of the bootstrap-temacs rule.
10147 The bootstrap-temacs-CMD rule is similar to the previous
10148 implementation of the bootstrap-temacs rule except that it
10149 makes use of the ESC_CFLAGS variable instead of the CFLAGS
10152 These changes, along with some changes to nt/configure.bat,
10153 nt/gmake.defs, and nt/nmake.defs, are required to extend my
10154 earlier fix to add support for --cflags and --ldflags options
10155 that include quotes so that it works whether make uses cmd or
10158 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
10160 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
10161 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
10163 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
10164 a string. Handle both cases.
10165 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
10166 (Fdbus_register_method): Use Qinvalid_function.
10168 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
10170 * makefile.w32-in: Update dependencies.
10171 (LISP_H): Add inttypes.h and stdin.h.
10172 (PROCESS_H): Add unistd.h.
10174 2011-05-06 Eli Zaretskii <eliz@gnu.org>
10176 * lread.c: Include limits.h (fixes the MS-Windows build broken by
10177 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
10179 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
10181 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
10183 * term.c (vfatal): Remove stray call to va_end.
10184 It's not needed and the C Standard doesn't allow it here anyway.
10186 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
10187 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
10189 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
10192 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
10194 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
10196 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
10198 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
10200 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
10202 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
10203 * charset.c (Fdefine_charset_internal): Don't initialize
10204 charset.code_space[15]. The value was garbage, on hosts with
10205 32-bit int (Bug#8600).
10207 * lread.c (read_integer): Be more consistent with string-to-number.
10208 Use string_to_number to do the actual conversion; this avoids
10209 rounding errors and fixes some other screwups. Without this fix,
10210 for example, #x1fffffffffffffff was misread as -2305843009213693952.
10211 (digit_to_number): Move earlier, for benefit of read_integer.
10212 Return -1 if the digit is out of range for the base, -2 if it is
10213 not a digit in any supported base. (Bug#8602)
10215 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
10217 * dispnew.c (scrolling_window): Return 1 if we scrolled,
10218 to match comment at start of function. This also removes a
10219 GCC warning about overflow in a 32+64-bit port.
10221 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
10223 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
10224 Reported by Stefan Monnier in
10225 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
10226 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10227 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
10229 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
10230 (EMACS_UINTPTR): Likewise, with uintptr_t.
10232 * lisp.h: Prefer 64-bit EMACS_INT if available.
10233 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
10234 on 32-bit hosts that have 64-bit int, so that they can access
10236 However, temporarily disable this change unless the temporary
10237 symbol WIDE_EMACS_INT is defined.
10239 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
10241 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
10242 This removes an assumption that EMACS_INT and long are the same
10243 width as pointers. The assumption is true for Emacs porting targets
10244 now, but we want to make other targets possible.
10245 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
10246 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
10247 In the rest of the code, change types of integers that hold casted
10248 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
10249 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
10250 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
10251 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
10252 No need to cast type when ORing.
10253 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
10254 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
10255 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
10256 assume EMACS_INT is the same width as char *.
10257 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
10258 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
10259 Remove no-longer-needed casts.
10260 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
10261 (xg_tool_bar_help_callback, xg_make_tool_item):
10262 Use EMACS_INTPTR to hold an integer
10263 that will be cast to void *; this can avoid a GCC warning
10264 if EMACS_INT is not the same width as void *.
10265 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
10266 * xdisp.c (display_echo_area_1, resize_mini_window_1):
10267 (current_message_1, set_message_1):
10268 Use a local to convert to proper width without a cast.
10269 * xmenu.c (dialog_selection_callback): Likewise.
10271 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
10272 Also, don't assume VALBITS / RAND_BITS is less than 5,
10273 and don't rely on undefined behavior when shifting a 1 left into
10275 * lisp.h (get_random): Change signature to match.
10277 * lread.c (hash_string): Use size_t, not int, for hash computation.
10278 Normally we prefer signed values; but hashing is special, because
10279 it's better to use unsigned division on hash table sizes so that
10280 the remainder is nonnegative. Also, size_t is the natural width
10281 for hashing into memory. The previous code used 'int', which doesn't
10282 retain enough info to hash well into very large tables.
10283 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
10285 * dbusbind.c: Don't possibly lose pointer info when converting.
10286 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10287 Use XPNTR rather than XHASH, so that the high-order bits of
10288 the pointer aren't lost when converting through void *.
10290 * eval.c (Fautoload): Don't double-shift a pointer.
10292 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
10294 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
10296 * gnutls.c (DEF_GNUTLS_FN):
10297 * image.c (DEF_IMGLIB_FN): Make function pointers static.
10299 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
10301 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
10304 2011-05-05 Eli Zaretskii <eliz@gnu.org>
10306 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
10307 New version that can reserve upto 2GB of heap space.
10309 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
10311 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
10313 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
10315 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
10316 `gnutls_certificate_set_x509_key_file'.
10318 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
10320 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
10321 Update dependencies.
10323 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
10325 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
10326 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
10327 Remove unused parameter `fildes'.
10328 * process.c (read_process_output, send_process): Don't pass it.
10330 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
10332 Fix previous change: the library cache is defined in w32.c.
10333 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
10334 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
10336 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
10338 Implement dynamic loading of GnuTLS on Windows.
10340 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
10341 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
10342 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10345 * gnutls.c (Qgnutls_dll): Define.
10346 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
10347 (gnutls_*): Declare function pointers.
10348 (init_gnutls_functions): New function to initialize function pointers.
10349 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
10350 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
10351 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10352 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
10353 (emacs_gnutls_write, emacs_gnutls_read)
10354 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
10355 (Fgnutls_available_p): New function.
10356 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
10357 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
10358 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
10360 * image.c: Include w32.h.
10361 (Vimage_type_cache): Delete.
10362 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
10363 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
10364 (w32_delayed_load): Move to w32.c.
10366 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
10368 * w32.c (QCloaded_from, Vlibrary_cache): Define.
10369 (w32_delayed_load): Move from image.c. When loading a library, record
10370 its filename in the :loaded-from property of the library id.
10371 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
10372 Initialize and staticpro them.
10373 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
10375 * process.c: Include lisp.h before w32.h, not after.
10376 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
10377 instead of gnutls_record_check_pending.
10379 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
10381 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
10383 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
10384 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
10387 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
10389 * xterm.c (x_set_frame_alpha): Do not set property on anything
10390 else than FRAME_X_OUTER_WINDOW (Bug#8608).
10392 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
10394 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
10396 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
10398 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
10399 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
10400 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
10401 (gnutls_global_initialized, Qgnutls_bootprop_priority)
10402 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
10403 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
10404 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
10405 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
10406 (Qgnutls_bootprop_callbacks_verify): Make static.
10408 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
10410 * callproc.c: Indentation fixup.
10412 * sysdep.c (wait_for_termination_1): Make static.
10413 (wait_for_termination, interruptible_wait_for_termination):
10414 Move after wait_for_termination_1.
10416 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
10418 * sysdep.c (interruptible_wait_for_termination): New function
10419 which is like wait_for_termination, but allows keyboard
10422 * callproc.c (Fcall_process): Add (:file "file") as an option for
10424 (Fcall_process_region): Ditto.
10426 2011-04-30 Eli Zaretskii <eliz@gnu.org>
10428 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
10429 rather than `XVECTOR (FOO)->size'.
10431 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
10432 inttypes.h, as a gnulib replacement is used if it not available in
10435 2011-04-21 Eli Zaretskii <eliz@gnu.org>
10437 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
10438 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
10439 of MOST_POSITIVE_FIXNUM. (Bug#8528)
10441 * coding.c (coding_alloc_by_realloc): Error out if destination
10442 will grow beyond MOST_POSITIVE_FIXNUM.
10443 (decode_coding_emacs_mule): Abort if there isn't enough place in
10444 charbuf for the composition carryover bytes. Reserve an extra
10445 space for up to 2 characters produced in a loop.
10446 (decode_coding_iso_2022): Abort if there isn't enough place in
10447 charbuf for the composition carryover bytes.
10449 2011-04-21 Eli Zaretskii <eliz@gnu.org>
10451 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
10452 aborting when %lld or %lll format is passed.
10453 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
10454 %llo or %llx format is passed. (Bug#8545)
10456 * window.c (window_scroll_line_based): Use a marker instead of
10457 simple variables to record original value of point. (Bug#7952)
10459 * doprnt.c (doprnt): Fix the case where a multibyte sequence
10460 produced by %s or %c overflows available buffer space. (Bug#8545)
10462 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
10464 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
10465 (SIZE_MAX): Move defn after all includes, as they might #define it.
10467 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
10469 * w32.c (init_environment): Warn about defaulting HOME to C:\.
10471 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
10473 * keyboard.c (Qdelayed_warnings_hook): Define.
10474 (command_loop_1): Run `delayed-warnings-hook'
10475 if Vdelayed_warnings_list is non-nil.
10476 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
10477 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
10479 2011-04-28 Eli Zaretskii <eliz@gnu.org>
10481 * doprnt.c (doprnt): Don't return value smaller than the buffer
10482 size if the message was truncated. (Bug#8545).
10484 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
10486 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
10487 (Fx_window_property): #if-0 the whole functions, not just the bodies.
10489 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10491 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
10493 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
10495 * makefile.w32-in: Update dependencies.
10497 2011-04-27 Eli Zaretskii <eliz@gnu.org>
10499 Improve `doprnt' and its usage. (Bug#8545)
10500 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
10501 `format_end'. Remove support for %l as a conversion specifier.
10502 Don't use xrealloc. Improve diagnostics when the %l size modifier
10503 is used. Update the commentary.
10505 * eval.c (verror): Simplify calculation of size_t.
10507 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
10510 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
10512 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
10515 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10517 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
10518 This makes this file independent of the recent pseudovector change.
10520 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
10522 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
10524 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
10525 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
10526 Remove unused local.
10527 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
10529 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
10530 GCC 4.6.0 optimizes based on type-based alias analysis.
10531 For example, if b is of type struct buffer * and v of type struct
10532 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
10533 != &v->size, and therefore "v->size = 1; b->size = 2; return
10534 v->size;" must therefore return 1. This assumption is incorrect
10535 for Emacs, since it type-puns struct Lisp_Vector * with many other
10536 types. To fix this problem, this patch adds a new type struct
10537 vectorlike_header that documents the constraints on layout of vectors
10538 and pseudovectors, and helps optimizing compilers not get fooled
10539 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
10540 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
10541 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
10543 (XSETPVECTYPE): Rewrite in terms of new macro.
10544 (XSETPVECTYPESIZE): New macro, specifying both type and size.
10545 This is a bit clearer, and further avoids the possibility of
10546 undesirable aliasing.
10547 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
10548 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
10549 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
10550 since Lisp_Subr is a special case (no "next" field).
10551 (ASIZE): Now uses header.size rather than size.
10552 All previous uses of XVECTOR (foo)->size replaced to use this macro,
10553 to avoid the hassle of writing XVECTOR (foo)->header.size.
10554 (struct vectorlike_header): New type.
10555 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
10556 object, to help avoid aliasing.
10557 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
10558 (SUBRP): Likewise, since Lisp_Subr is a special case.
10559 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
10560 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
10561 (struct Lisp_Hash_Table): Combine first two members into a single
10562 struct vectorlike_header member. All uses of "size" and "next" members
10563 changed to be "header.size" and "header.next".
10564 * buffer.h (struct buffer): Likewise.
10565 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
10566 * frame.h (struct frame): Likewise.
10567 * process.h (struct Lisp_Process): Likewise.
10568 * termhooks.h (struct terminal): Likewise.
10569 * window.c (struct save_window_data, struct saved_window): Likewise.
10570 * window.h (struct window): Likewise.
10571 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
10572 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
10573 * buffer.c (init_buffer_once): Likewise.
10574 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
10576 * process.c (Fformat_network_address): Use local var for size,
10579 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
10581 Make the Lisp reader and string-to-float more consistent (Bug#8525)
10582 * data.c (atof): Remove decl; no longer used or needed.
10583 (digit_to_number): Move to lread.c.
10584 (Fstring_to_number): Use new string_to_number function, to be
10585 consistent with how the Lisp reader treats infinities and NaNs.
10586 Do not assume that floating-point numbers represent EMACS_INT
10587 without losing information; this is not true on most 64-bit hosts.
10588 Avoid double-rounding errors, by insisting on integers when
10589 parsing non-base-10 numbers, as the documentation specifies.
10590 * lisp.h (string_to_number): New decl, replacing ...
10591 (isfloat_string): Remove.
10592 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
10593 (read1): Do not accept +. and -. as integers; this
10594 appears to have been a coding error. Similarly, do not accept
10595 strings like +-1e0 as floating point numbers. Do not report
10596 overflow for integer overflows unless the base is not 10 which
10597 means we have no simple and reliable way to continue.
10598 Break out the floating-point parsing into a new
10599 function string_to_number, so that Fstring_to_number parses
10600 floating point numbers consistently with the Lisp reader.
10601 (digit_to_number): Move here from data.c. Make it static inline.
10602 (E_CHAR, EXP_INT): Remove, replacing with ...
10603 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
10604 (string_to_number): New function, replacing isfloat_string.
10605 This function checks for valid syntax and produces the resulting
10606 Lisp float number too. Rework it so that string-to-number
10607 no longer mishandles examples like "1.0e+". Use strtoumax,
10608 so that overflow for non-base-10 numbers is reported only when
10609 there's no portable and simple way to convert to floating point.
10611 * textprop.c (set_text_properties_1): Rewrite for clarity,
10612 and to avoid GCC warning about integer overflow.
10614 * intervals.h (struct interval): Use EMACS_INT for members
10615 where EMACS_UINT might cause problems. See
10616 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
10617 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
10618 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
10620 (offset_intervals): Tell GCC not to worry about length overflow
10621 when negating a negative length.
10623 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
10624 (overrun_check_free): Likewise.
10626 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
10627 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
10630 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10631 (gnutls_make_error): Rename local to avoid shadowing.
10632 (gnutls_emacs_global_deinit): ifdef out; not used.
10633 (Fgnutls_boot): Use const for pointer to readonly storage.
10634 Comment out unused local. Fix pointer signedness problems.
10636 * lread.c (openp): Don't stuff size_t into an 'int'.
10637 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
10638 about possible signed overflow.
10640 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10641 (GDK_KEY_g): Don't define if already defined.
10642 (xg_prepare_tooltip): Avoid pointer signedness problem.
10643 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
10645 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
10646 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
10648 * xfns.c (Fx_window_property): Simplify a bit,
10649 to make a bit faster and to avoid GCC 4.6.0 warning.
10650 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
10652 * fns.c (internal_equal): Don't assume size_t fits in int.
10654 * alloc.c (compact_small_strings): Tighten assertion a little.
10656 Replace pEd with more-general pI, and fix some printf arg casts.
10657 * lisp.h (pI): New macro, generalizing old pEd macro to other
10658 conversion specifiers. For example, use "...%"pI"d..." rather
10659 than "...%"pEd"...".
10660 (pEd): Remove. All uses replaced with similar uses of pI.
10661 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
10662 * alloc.c (check_pure_size): Don't overflow by converting size to int.
10663 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
10664 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
10665 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
10666 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
10667 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
10669 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
10670 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
10671 * print.c (safe_debug_print, print_object): Likewise.
10672 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
10674 Use pI instead of if-then-else-abort. Use %p to avoid casts,
10675 avoiding the 0 flag, which is not portable.
10676 * process.c (Fmake_network_process): Use pI to avoid cast.
10677 * region-cache.c (pp_cache): Likewise.
10678 * xdisp.c (decode_mode_spec): Likewise.
10679 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
10680 behavior on 64-bit hosts with printf arg.
10681 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
10682 (x_stop_queuing_selection_requests): Likewise.
10683 (x_get_window_property): Don't truncate byte count to an 'int'
10686 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
10687 here, since it parses constructs like leading '-' and spaces,
10688 which are not wanted; and it overflows with large numbers.
10689 Instead, simply match F[0-9]+, which is what is wanted anyway.
10691 * alloc.c: Remove unportable assumptions about struct layout.
10692 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
10693 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
10694 (allocate_vectorlike, make_pure_vector): Use the new macros,
10695 plus offsetof, to remove unportable assumptions about struct layout.
10696 These assumptions hold on all porting targets that I know of, but
10697 they are not guaranteed, they're easy to remove, and removing them
10698 makes further changes easier.
10700 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
10701 This doesn't fix a bug but makes the code clearer.
10702 (string_overrun_cookie): Now const. Use initializers that
10703 don't formally overflow signed char, to avoid warnings.
10704 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
10705 can cause Emacs to crash when string overrun checking is enabled.
10706 (allocate_buffer): Don't assume sizeof (struct buffer) is a
10707 multiple of sizeof (EMACS_INT); it need not be, if
10708 alignof(EMACS_INT) < sizeof (EMACS_INT).
10709 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
10711 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
10713 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
10715 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
10717 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
10718 supposed to be handshaking. (Bug#8556)
10719 Reported by Paul Eggert <eggert@cs.ucla.edu>.
10721 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
10723 * lisp.h (Qdebug): List symbol.
10724 * eval.c (Qdebug): Restore global linkage.
10725 * keyboard.c (debug-on-event): New variable.
10726 (handle_user_signal): Break into debugger when debug-on-event
10727 matches the current signal symbol.
10729 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
10731 * alloc.c (check_sblock, check_string_bytes)
10732 (check_string_free_list): Convert to standard C.
10734 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
10736 * w32.c (emacs_gnutls_push): Fix typo.
10738 2011-04-25 Eli Zaretskii <eliz@gnu.org>
10740 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
10741 "cast to pointer from integer of different size".
10743 Improve doprnt and its use in verror. (Bug#8545)
10744 * doprnt.c (doprnt): Document the set of format control sequences
10745 supported by the function. Use SAFE_ALLOCA instead of always
10748 * eval.c (verror): Don't limit the buffer size at size_max-1, that
10749 is one byte too soon. Don't use xrealloc; instead xfree and
10752 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
10754 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
10757 * gnutls.c: Renamed global_initialized to
10758 gnutls_global_initialized. Added internals for the
10759 :verify-hostname-error, :verify-error, and :verify-flags
10760 parameters of `gnutls-boot' and documented those parameters in the
10761 docstring. Start callback support.
10762 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
10763 unless a fatal error occurred. Call gnutls_alert_send_appropriate
10764 on error. Return error code.
10765 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
10766 (emacs_gnutls_read): Likewise.
10767 (Fgnutls_boot): Return handshake error code.
10768 (emacs_gnutls_handle_error): New function.
10769 (wsaerror_to_errno): Likewise.
10771 * w32.h (emacs_gnutls_pull): Add prototype.
10772 (emacs_gnutls_push): Likewise.
10774 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
10775 (emacs_gnutls_push): Likewise.
10777 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
10779 * process.c (wait_reading_process_output): Check if GnuTLS
10780 buffered some data internally if no FDs are set for TLS
10783 * makefile.w32-in (OBJ2): Add gnutls.$(O).
10784 (LIBS): Link to USER_LIBS.
10785 ($(BLD)/gnutls.$(0)): New target.
10787 2011-04-24 Eli Zaretskii <eliz@gnu.org>
10789 * xdisp.c (handle_single_display_spec): Rename the
10790 display_replaced_before_p argument into display_replaced_p, to
10791 make it consistent with the commentary. Fix typos in the
10794 * textprop.c (syms_of_textprop): Remove dead code.
10795 (copy_text_properties): Delete obsolete commentary about an
10796 interface that was deleted long ago. Fix typos in the description
10799 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
10800 to changes in oldXMenu/XMenu.h from 2011-04-16.
10801 <menu_help_message, prev_menu_help_message>: Constify.
10802 (IT_menu_make_room): menu->help_text is now `const char **';
10805 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
10806 to changes in oldXMenu/XMenu.h from 2011-04-16.
10807 (struct XMenu): Declare `help_text' `const char **'.
10809 * xfaces.c <Qunspecified>: Make extern again.
10811 * syntax.c: Include sys/types.h before including regex.h, as
10814 * doc.c (get_doc_string): Improve the format passed to `error'.
10816 * doprnt.c (doprnt): Improve commentary.
10818 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
10820 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
10823 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
10824 changes in globals.h immediately force recompilation.
10825 (TAGS): Depend on $(CURDIR)/m/intel386.h and
10826 $(CURDIR)/s/ms-w32.h.
10827 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
10829 * character.c (Fchar_direction): Function deleted.
10830 (syms_of_character): Don't defsubr it.
10831 <char-direction-table>: Deleted.
10833 2011-04-23 Eli Zaretskii <eliz@gnu.org>
10835 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
10836 * doprnt.c: Include limits.h.
10837 (SIZE_MAX): New macro.
10838 (doprnt): Return a size_t value. 2nd arg is now size_t.
10839 Many local variables are now size_t instead of int or unsigned.
10840 Improve overflow protection. Support `l' modifier for integer
10841 conversions. Support %l conversion. Don't assume an EMACS_INT
10842 argument for integer conversions and for %c.
10844 * lisp.h (doprnt): Restore prototype.
10846 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
10847 $(SRC)/character.h.
10849 * Makefile.in (base_obj): Add back doprnt.o.
10851 * deps.mk (doprnt.o): Add back prerequisites.
10852 (callint.o): Depend on character.h.
10854 * eval.c (internal_lisp_condition_case): Include the handler
10855 representation in the error message.
10856 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
10857 when breaking from the loop.
10859 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
10861 * callint.c (Fcall_interactively): When displaying error message
10862 about invalid control letter, pass the character's codepoint, not
10863 a pointer to its multibyte form. Improve display of the character
10864 in octal and display also its hex code.
10866 * character.c (char_string): Use %x to display the (unsigned)
10867 codepoint of an invalid character, to avoid displaying a bogus
10870 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
10871 `error', not SYMBOL_NAME itself.
10873 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
10874 character arguments to `error'.
10876 * charset.c (check_iso_charset_parameter): Fix incorrect argument
10877 to `error' in error message about FINAL_CHAR argument. Make sure
10878 FINAL_CHAR is a character, and use %c when it is passed as
10879 argument to `error'.
10881 2011-04-23 Eli Zaretskii <eliz@gnu.org>
10883 * s/ms-w32.h (localtime): Redirect to sys_localtime.
10885 * w32.c: Include <time.h>.
10886 (sys_localtime): New function.
10888 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
10890 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
10892 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
10894 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
10896 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
10897 zombies (Bug#8467).
10899 2011-04-19 Eli Zaretskii <eliz@gnu.org>
10901 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
10902 gl_state.e_property when gl_state.object is Qt.
10904 * insdel.c (make_gap_larger): Remove limitation of buffer size
10907 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
10909 * xdisp.c (lookup_glyphless_char_display)
10910 (produce_glyphless_glyph): Handle cons cell entry in
10911 glyphless-char-display.
10912 (Vglyphless_char_display): Document it.
10914 * term.c (produce_glyphless_glyph): Handle cons cell entry in
10915 glyphless-char-display.
10917 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
10919 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
10921 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
10923 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
10924 definition for no-X builds.
10926 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
10928 Static checks with GCC 4.6.0 and non-default toolkits.
10930 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
10932 * process.c (keyboard_bit_set): Define only if SIGIO.
10933 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
10934 (send_process): Repair possible setjmp clobbering.
10936 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
10938 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
10940 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
10942 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
10943 Define only if needed.
10945 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
10946 by pacifying GCC about it. Maybe it's time to retire it?
10947 * xfaces.c (USG, __TIMEVAL__): Likewise.
10949 * dispextern.h (struct redisplay_interface): Rename param
10950 to avoid shadowing.
10951 * termhooks.h (struct terminal): Likewise.
10952 * xterm.c (xembed_send_message): Likewise.
10954 * insdel.c (make_gap_smaller): Define only if
10955 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
10957 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
10960 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
10961 so that we aren't warned about unused symbols.
10963 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
10965 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
10967 * xfns.c (x_real_positions): Mark locals as initialized.
10969 * xmenu.c (xmenu_show): Don't use uninitialized vars.
10971 * xterm.c: Fix problems found by static analysis with other toolkits.
10972 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
10973 (x_dispatch_event): Declare static if USE_GTK, and
10974 define if USE_GTK || USE_X_TOOLKIT.
10975 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
10976 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
10977 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
10978 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
10980 * xmenu.c (menu_help_callback): Pointer type fixes.
10981 Use const pointers when pointing at readonly data. Avoid pointer
10982 signedness clashes.
10983 (FALSE): Remove unused macro.
10984 (update_frame_menubar): Remove unused decl.
10986 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
10988 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
10989 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
10990 (single_menu_item): Rename local to avoid shadowing.
10992 * keyboard.c (make_lispy_event): Remove unused local var.
10994 * frame.c, frame.h (x_get_resource_string): Bring this back, but
10995 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
10997 * bitmaps: Change bitmaps from unsigned char back to the X11
10998 compatible char. Avoid the old compiler warnings about
10999 out-of-range initializers by using, for example, '\xab' rather
11002 * xgselect.c (xgselect_initialize): Check vs interface
11003 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
11005 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
11007 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
11008 to read-only memory.
11010 * fns.c (vector): Remove; this old hack is no longer needed.
11012 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
11014 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
11016 * xrdb.c (x_load_resources): Omit unused local.
11018 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
11019 (x_window): Rename locals to avoid shadowing.
11020 (USG): Use the kludged USG macro, to pacify gcc.
11022 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
11023 (x_term_init): Remove local to avoid shadowing.
11025 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
11027 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
11028 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
11030 2011-04-16 Eli Zaretskii <eliz@gnu.org>
11032 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
11034 Fix regex.c, syntax.c and friends for buffers > 2GB.
11035 * syntax.h (struct gl_state_s): Declare character position members
11038 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
11040 * textprop.c (verify_interval_modification, interval_of):
11041 Declare arguments EMACS_INT.
11043 * intervals.c (adjust_intervals_for_insertion): Declare arguments
11046 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
11048 * indent.c (Fvertical_motion): Local variable it_start is now
11051 * regex.c (re_match, re_match_2, re_match_2_internal)
11052 (bcmp_translate, regcomp, regexec, print_double_string)
11053 (group_in_compile_stack, re_search, re_search_2, regex_compile)
11054 (re_compile_pattern, re_exec): Declare arguments and local
11055 variables `size_t' and `ssize_t' and return values `regoff_t', as
11057 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
11058 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
11059 <compile_stack_type>: `size' and `avail' are now `size_t'.
11061 * regex.h <regoff_t>: Use ssize_t, not int.
11062 (re_search, re_search_2, re_match, re_match_2): Arguments that
11063 specify buffer/string position and length are now ssize_t and
11064 size_t. Return type is regoff_t.
11066 2011-04-16 Ben Key <bkey76@gmail.com>
11068 * nsfont.m: Fixed bugs in ns_get_family and
11069 ns_descriptor_to_entity that were caused by using free to
11070 deallocate memory blocks that were allocated by xmalloc (via
11071 xstrdup). This caused Emacs to crash when compiled with
11072 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
11073 --enable-checking=xmallocoverrun). xfree is now used to
11074 deallocate these memory blocks.
11076 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
11078 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
11080 emacs_write: Accept and return EMACS_INT for sizes.
11081 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
11083 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
11084 Accept and return EMACS_INT.
11085 (emacs_gnutls_write): Return the number of bytes written on
11087 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
11088 (emacs_read, emacs_write): Remove check for negative size, as the
11089 Emacs source code has been audited now.
11090 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
11091 (emacs_read, emacs_write): Use it.
11092 * process.c (send_process): Adjust to the new signatures of
11093 emacs_write and emacs_gnutls_write. Do not attempt to store
11094 a byte offset into an 'int'; it might overflow.
11095 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
11097 * sound.c: Don't assume sizes fit in 'int'.
11098 (struct sound_device.period_size, alsa_period_size):
11099 Return EMACS_INT, not int.
11100 (struct sound_device.write, vox_write, alsa_write):
11101 Accept EMACS_INT, not int.
11102 (wav_play, au_play): Use EMACS_INT to store sizes and to
11103 record read return values.
11105 2011-04-15 Ben Key <bkey76@gmail.com>
11107 * keyboard.c (Qundefined): Don't declare static since it is used
11109 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
11110 static since they are used in nsfont.m.
11112 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
11114 * process.c (Qprocessp): Don't declare static.
11115 * lisp.h (Qprocessp): Declare again.
11117 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
11119 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
11121 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
11123 Improve C-level modularity by making more things 'static'.
11125 Don't publish debugger-only interfaces to other modules.
11126 * lisp.h (safe_debug_print, debug_output_compilation_hack):
11127 (verify_bytepos, count_markers): Move decls to the only modules
11129 * region-cache.h (pp_cache): Likewise.
11130 * window.h (check_all_windows): Likewise.
11131 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
11133 * sysdep.c (croak): Now static, if
11134 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
11135 * syssignal.h (croak): Declare only if not static.
11137 * alloc.c (refill_memory_reserve): Now static if
11138 !defined REL_ALLOC || defined SYSTEM_MALLOC.
11139 * lisp.h (refill_memory_reserve): Declare only if not static.
11141 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
11142 Define only if USE_LUCID.
11144 * xrdb.c (x_customization_string, x_rm_string): Now static.
11146 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
11147 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
11149 * xdisp.c (draw_row_with_mouse_face): Now static.
11150 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
11152 * window.h (check_all_windows): Mark externally visible.
11154 * window.c (window_deletion_count): Now static.
11156 * undo.c: Make symbols static if they're not exported.
11157 (last_undo_buffer, last_boundary_position, pending_boundary):
11160 * textprop.c (interval_insert_behind_hooks): Now static.
11161 (interval_insert_in_front_hooks): Likewise.
11163 * term.c: Make symbols static if they're not exported.
11164 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
11165 (max_frame_lines, tty_set_terminal_modes):
11166 (tty_reset_terminal_modes, tty_turn_off_highlight):
11167 (get_tty_terminal): Now static.
11168 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
11169 * termhooks.h (term_mouse_moveto): Do not declare if
11170 HAVE_WINDOW_SYSTEM.
11171 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
11172 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
11174 * sysdep.c: Make symbols static if they're not exported.
11175 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
11177 (sigprocmask_set, full_mask): Remove; unused.
11178 (wait_debugging): Mark as visible.
11179 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
11180 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
11182 * syntax.c (syntax_temp): Define only if !__GNUC__.
11184 * sound.c (current_sound_device, current_sound): Now static.
11186 * search.c (searchbufs, searchbuf_head): Now static.
11188 * scroll.c (scroll_cost): Remove; unused.
11189 * dispextern.h (scroll_cost): Remove decl.
11191 * region-cache.h (pp_cache): Mark as externally visible.
11193 * process.c: Make symbols static if they're not exported.
11194 (process_tick, update_tick, create_process, chan_process):
11195 (Vprocess_alist, proc_buffered_char, datagram_access):
11196 (fd_callback_data, send_process_frame, process_sent_to): Now static.
11197 (deactivate_process): Mark defn as static, as well as decl.
11198 * lisp.h (create_process): Remove decl.
11199 * process.h (chan_process, Vprocess_alist): Remove decls.
11201 * print.c: Make symbols static if they're not exported.
11202 (print_depth, new_backquote_output, being_printed, print_buffer):
11203 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
11204 (print_interval, print_number_index, initial_stderr_stream):
11206 * lisp.h (Fprinc): Remove decl.
11207 (debug_output_compilation_hack): Mark as externally visible.
11209 * sysdep.c (croak): Move decl from here to syssignal.h.
11210 * syssignal.h (croak): Put it here, so the API can be checked when
11211 'croak' is called from dissociate_if_controlling_tty.
11213 * minibuf.c: Make symbols static if they're not exported.
11214 (minibuf_save_list, choose_minibuf_frame): Now static.
11215 * lisp.h (choose_minibuf_frame): Remove decl.
11217 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
11219 * lread.c: Make symbols static if they're not exported.
11220 (read_objects, initial_obarray, oblookup_last_bucket_number):
11222 (make_symbol): Remove; unused.
11223 * lisp.h (initial_obarray, make_symbol): Remove decls.
11225 * keyboard.c: Make symbols static if they're not exported.
11226 (single_kboard, recent_keys_index, total_keys, recent_keys):
11227 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
11228 (this_single_command_key_start, echoing, last_auto_save):
11229 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
11230 (command_loop, echo_now, keyboard_init_hook, help_char_p):
11231 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
11232 (Vlispy_mouse_stem, double_click_count):
11234 (force_auto_save_soon): Define only if SIGDANGER.
11235 (ignore_mouse_drag_p): Now static if
11236 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
11237 (print_help): Remove; unused.
11238 (stop_character, last_timer_event): Mark as externally visible.
11239 * keyboard.h (ignore_mouse_drag_p): Declare only if
11240 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
11241 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
11242 * lisp.h (echoing): Remove decl.
11243 (force_auto_save_soon): Declare only if SIGDANGER.
11244 * xdisp.c (redisplay_window): Simplify code, to make it more
11245 obvious that ignore_mouse_drag_p is not accessed if !defined
11246 USE_GTK && !defined HAVE_NS.
11248 * intervals.c: Make symbols static if they're not exported.
11249 (merge_properties_sticky, merge_interval_right, delete_interval):
11251 * intervals.h (merge_interval_right, delete_interval): Remove decls.
11253 * insdel.c: Make symbols static if they're not exported.
11254 However, leave prepare_to_modify_buffer alone. It's never
11255 called from outside this function, but that appears to be a bug.
11256 (combine_after_change_list, combine_after_change_buffer):
11257 (adjust_after_replace, signal_before_change): Now static.
11258 (adjust_after_replace_noundo): Remove; unused.
11259 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
11260 (signal_before_change): Remove decls.
11262 * indent.c (val_compute_motion, val_vmotion): Now static.
11264 * image.c: Make symbols static if they're not exported.
11265 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
11267 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
11268 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
11270 * fringe.c (standard_bitmaps): Now static.
11271 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
11273 * frame.c: Make symbols static if they're not exported.
11274 (x_report_frame_params, make_terminal_frame): Now static.
11275 (get_frame_param): Now static, unless HAVE_NS.
11276 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
11277 (x_get_resource_string): Remove; not used.
11278 * frame.h (make_terminal_frame, x_report_frame_params):
11279 (x_get_resource_string); Remove decls.
11280 (x_fullscreen_adjust): Declare only if WINDOWSNT.
11281 * lisp.h (get_frame_param): Declare only if HAVE_NS.
11283 * font.c, fontset.c: Make symbols static if they're not exported.
11284 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
11285 (FACE_SUITABLE_FOR_CHAR_P): Use it.
11286 * font.c (font_close_object): Now static.
11287 * font.h (font_close_object): Remove.
11288 * fontset.c (FONTSET_OBJLIST): Remove.
11289 (free_realized_fontset) #if-0 the body, which does nothing.
11290 (face_suitable_for_char_p): #if-0, as it's never called.
11291 * fontset.h (face_suitable_for_char_p): Remove decl.
11292 * xfaces.c (face_at_string_position):
11293 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
11294 since 0 is always ASCII.
11296 * fns.c (weak_hash_tables): Now static.
11298 * fileio.c: Make symbols static if they're not exported.
11299 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
11300 (Vwrite_region_annotation_buffers): Now static.
11302 * eval.c: Make symbols static if they're not exported.
11303 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
11304 * lisp.h (backtrace_list): Remove decl.
11306 * emacs.c: Make symbols static if they're not exported.
11307 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
11308 (fatal_error_code, fatal_error_signal_hook, standard_args):
11310 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
11311 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
11312 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
11313 * lisp.h (fatal_error_signal_hook): Remove decl.
11314 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
11316 * editfns.c: Move a (normally-unused) function to its only use.
11317 * editfns.c, lisp.h (get_operating_system_release): Remove.
11318 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
11319 worth the hassle of breaking this out.
11321 * xterm.c: Make symbols static if they're not exported.
11322 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
11323 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
11324 (x_destroy_window, x_delete_display):
11326 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
11327 (x_mouse_leave): Remove; unused.
11328 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
11329 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
11330 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
11332 (x_mouse_leave): Declare only if WINDOWSNT.
11333 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
11334 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
11337 * ftxfont.c: Make symbols static if they're not exported.
11338 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
11340 * font.h (ftxfont_driver): Likewise.
11342 * xfns.c: Make symbols static if they're not exported.
11343 (x_last_font_name, x_display_info_for_name):
11344 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
11345 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
11346 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
11347 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
11348 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
11349 (last_show_tip_args): Now static.
11350 (xic_defaut_fontset, xic_create_fontsetname): Define only if
11351 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
11352 (x_screen_planes): Remove; unused.
11353 * dispextern.h (x_screen_planes): Remove decl.
11355 * dispnew.c: Make symbols static if they're not exported.
11356 * dispextern.h (redraw_garbaged_frames, scrolling):
11357 (increment_row_positions): Remove.
11358 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
11359 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
11361 (redraw_garbaged_frames): Remove; unused.
11363 * xfaces.c: Make symbols static if they're not exported.
11364 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
11366 * xterm.h (defined_color): Remove decls.
11367 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
11368 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
11369 (menu_face_changed_default, defined_color, free_realized_face):
11370 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
11371 (ascii_face_of_lisp_face): Remove; unused.
11373 * xdisp.c: Make symbols static if they're not exported.
11374 * dispextern.h (scratch_glyph_row, window_box_edges):
11375 (glyph_to_pixel_coords, set_cursor_from_row):
11376 (get_next_display_element, set_iterator_to_next):
11377 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
11378 (show_mouse_face): Remove decls
11379 * frame.h (message_buf_print): Likewise.
11380 * lisp.h (pop_message, set_message, check_point_in_composition):
11382 * xterm.h (set_vertical_scroll_bar): Likewise.
11383 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
11384 (message_buf_print, scratch_glyph_row, displayed_buffer):
11385 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
11386 (get_next_display_element, show_mouse_face, window_box_edges):
11387 (frame_to_window_pixel_xy, check_point_in_composition):
11388 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
11389 (glyph_to_pixel_coords): Remove; unused.
11391 * dired.c (file_name_completion): Now static.
11393 * dbusbind.c (xd_in_read_queued_messages): Now static.
11395 * lisp.h (circular_list_error, FOREACH): Remove; unused.
11396 * data.c (circular_list_error): Remove.
11398 * commands.h (last_point_position, last_point_position_buffer):
11399 (last_point_position_window): Remove decls.
11400 * keyboard.c: Make these variables static.
11402 * coding.h (coding, code_convert_region, encode_coding_gap):
11404 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
11405 (iso_code_class, detect_coding, code_convert_region): Now static.
11406 (encode_coding_gap): Remove; unused.
11408 * chartab.c (chartab_chars, chartab_bits): Now static.
11410 * charset.h (charset_iso_8859_1): Remove decl.
11411 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
11414 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
11415 * ccl.c (Vccl_program_table): Now static.
11416 (check_ccl_update): Remove; unused.
11418 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
11419 * category.h: ... from here.
11420 * category.c (check_category_table, set_category_set): Now static.
11422 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
11423 * lisp.h: Remove these decls.
11425 * buffer.c (buffer_count): Remove unused var.
11427 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
11428 so that it's not optimized away.
11429 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
11430 * dispextern.h (bidi_dump_cached_states): Remove, since it's
11431 exported only to the debugger.
11433 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
11434 * atimer.h (run_all_atimers): Remove; not exported.
11436 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
11437 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
11438 was inaccessible from Lisp.
11439 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
11440 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
11442 alloc.c: Import and export fewer symbols, and remove unused items.
11443 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
11445 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
11446 it's not optimized away by whole-program optimization.
11447 (message_enable_multibyte, free_misc): Remove.
11448 (catchlist, handlerlist, mark_backtrace):
11449 Declare only if BYTE_MARK_STACK.
11450 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
11451 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
11452 (message_enable_multibyte): Remove decl.
11453 (free_misc, interval_free_list, float_block, float_block_index):
11454 (n_float_blocks, float_free_list, cons_block, cons_block_index):
11455 (cons_free_list, last_marked_index):
11457 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
11458 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
11459 (mark_backtrace): Define only if BYTE_MARK_STACK.
11460 * xdisp.c (message_enable_multibyte): Now static.
11462 Declare Lisp_Object Q* variables to be 'static' if not exported.
11463 This makes it easier for human readers (and static analyzers)
11464 to see whether these variables are used from other modules.
11465 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
11466 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
11467 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
11468 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
11469 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
11470 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
11471 * xmenu.c, xselect.c:
11472 Declare Q* vars static if they are not used in other modules.
11473 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
11474 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
11475 Remove decls of unexported vars.
11476 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
11478 * lisp.h (DEFINE_FUNC): Make sname 'static'.
11480 Make Emacs functions such as Fatom 'static' by default.
11481 This makes it easier for human readers (and static analyzers)
11482 to see whether these functions can be called from other modules.
11483 DEFUN now defines a static function. To make the function external
11484 so that it can be used in other C modules, use the new macro DEFUE.
11485 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
11486 (Finit_image_library):
11487 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
11488 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
11489 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
11490 Remove decls, since these functions are now static.
11491 (Funintern, Fget_internal_run_time): New decls, since these functions
11492 were already external.
11494 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
11495 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
11496 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
11497 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
11498 * keyboard.c, keymap.c, lread.c:
11499 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
11500 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
11501 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
11502 Mark functions with DEFUE instead of DEFUN,
11503 if they are used in other modules.
11504 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
11505 decls for now-static functions.
11506 * buffer.h (Fdelete_overlay): Remove decl.
11507 * callproc.c (Fgetenv_internal): Mark as internal.
11508 * composite.c (Fremove_list_of_text_properties): Remove decl.
11509 (Fcomposition_get_gstring): New forward static decl.
11510 * composite.h (Fcomposite_get_gstring): Remove decl.
11511 * dired.c (Ffile_attributes): New forward static decl.
11512 * doc.c (Fdocumntation_property): New forward static decl.
11513 * eval.c (Ffetch_bytecode): New forward static decl.
11514 (Funintern): Remove extern decl; now in .h file where it belongs.
11515 * fileio.c (Fmake_symbolic_link): New forward static decl.
11516 * image.c (Finit_image_library): New forward static decl.
11517 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
11518 * intervals.h (Fprevious_property_change):
11519 (Fremove_list_of_text_properties): Remove decls.
11520 * keyboard.c (Fthis_command_keys): Remove decl.
11521 (Fcommand_execute): New forward static decl.
11522 * keymap.c (Flookup_key): New forward static decl.
11523 (Fcopy_keymap): Now static.
11524 * keymap.h (Flookup_key): Remove decl.
11525 * process.c (Fget_process): New forward static decl.
11526 (Fprocess_datagram_address): Mark as internal.
11527 * syntax.c (Fsyntax_table_p): New forward static decl.
11528 (skip_chars): Remove duplicate decl.
11529 * textprop.c (Fprevious_property_change): New forward static decl.
11530 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
11532 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
11533 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
11535 * editfns.c (Fformat): Remove unreachable code.
11537 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
11539 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
11542 2011-04-13 Eli Zaretskii <eliz@gnu.org>
11544 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
11545 when at ZV. (Bug#8487)
11547 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
11549 * charset.c (Fclear_charset_maps): Use xfree instead of free.
11551 * keyboard.c (parse_tool_bar_item): Likewise.
11552 * sound.c (sound_cleanup, alsa_close): Likewise.
11553 * termcap.c (tgetent): Likewise.
11554 * xfns.c (x_default_font_parameter): Likewise.
11555 * xsettings.c (read_and_apply_settings): Likewise.
11557 * alloc.c (overrun_check_malloc, overrun_check_realloc)
11558 (overrun_check_free): Protoize.
11560 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
11562 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
11563 since callers should never pass a negative size.
11564 Change the signature to match that of plain 'read' and 'write'; see
11565 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
11566 * lisp.h: Update prototypes of emacs_write and emacs_read.
11568 2011-04-11 Eli Zaretskii <eliz@gnu.org>
11570 * xdisp.c (redisplay_window): Don't try to determine the character
11571 position of the scroll margin if the window start point w->startp
11572 is outside the buffer's accessible region. (Bug#8468)
11574 2011-04-10 Eli Zaretskii <eliz@gnu.org>
11576 Fix write-region and its subroutines for buffers > 2GB.
11577 * fileio.c (a_write, e_write): Modify declaration of arguments and
11578 local variables to support buffers larger than 2GB.
11579 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
11581 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
11582 argument, local variables, and return value.
11584 * lisp.h: Update prototypes of emacs_write and emacs_read.
11586 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
11588 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
11590 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
11592 Fix more problems found by GCC 4.6.0's static checks.
11594 * xdisp.c (vmessage): Use a better test for character truncation.
11596 * charset.c (load_charset_map): <, not <=, for optimization,
11597 and to avoid potential problems with integer overflow.
11598 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
11599 * casetab.c (set_identity, shuffle): Likewise.
11600 * editfns.c (Fformat): Likewise.
11601 * syntax.c (skip_chars): Likewise.
11603 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
11604 This also lets GCC 4.6.0 generate slightly better loop code.
11606 * callint.c (Fcall_interactively): <, not <=, for optimization.
11607 (Fcall_interactively): Count the number of arguments produced,
11608 not the number of arguments given. This is simpler and lets GCC
11609 4.6.0 generate slightly better code.
11611 * ftfont.c: Distingish more carefully between FcChar8 and char.
11612 The previous code passed unsigned char * to a functions like
11613 strlen and xstrcasecmp that expect char *, which does not
11614 conform to the C standard.
11615 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
11616 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
11617 char * when the C standard requires it.
11619 * keyboard.c (read_char): Remove unused var.
11621 * eval.c: Port to Windows vsnprintf (Bug#8435).
11622 Include <limits.h>.
11623 (SIZE_MAX): Define if the headers do not.
11624 (verror): Do not give up if vsnprintf returns a negative count.
11625 Instead, grow the buffer. This ports to Windows vsnprintf, which
11626 does not conform to C99. Problem reported by Eli Zaretskii.
11627 Also, simplify the allocation scheme, by avoiding the need for
11628 calling realloc, and removing the ALLOCATED variable.
11630 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
11632 Remove invocations of doprnt, as Emacs now uses vsnprintf.
11633 But keep the doprint source code for now, as we might revamp it
11634 and use it again (Bug#8435).
11635 * lisp.h (doprnt): Remove.
11636 * Makefile.in (base_obj): Remove doprnt.o.
11637 * deps.mk (doprnt.o): Remove.
11639 error: Print 32- and 64-bit integers portably (Bug#8435).
11640 Without this change, on typical 64-bit hosts error ("...%d...", N)
11641 was used to print both 32- and 64-bit integers N, which relied on
11642 undefined behavior.
11643 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
11644 * lisp.h (error, verror): Mark as printf-like functions.
11645 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
11646 Report overflow in size calculations when allocating printf buffer.
11647 Do not truncate output string at its first null byte.
11648 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
11649 Truncate the output at a character boundary, since vsnprintf does not
11651 * charset.c (check_iso_charset_parameter): Convert internal
11652 character to string before calling 'error', since %c now has the
11654 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
11655 overflow when computing char to be passed to 'error'. Do not
11656 pass Lisp_Object to 'error'; pass the integer instead.
11657 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
11658 formatted with plain %d.
11660 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
11662 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
11664 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
11666 * xterm.c (x_catch_errors): Remove duplicate declaration.
11668 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
11670 * xdisp.c, lisp.h (message_nolog): Remove; unused.
11672 2011-04-10 Jim Meyering <meyering@redhat.com>
11674 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
11675 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
11676 return ssize_t not "int", and use size_t as the buffer length.
11677 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
11678 * gnutls.h: Update declarations.
11679 * process.c (read_process_output): Use ssize_t, to match.
11680 (send_process): Likewise.
11682 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
11684 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
11686 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
11688 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
11689 Use unsigned char, to match FcChar8 type definition.
11691 * xterm.c (handle_one_xevent):
11692 * xmenu.c (create_and_show_popup_menu):
11693 * xselect.c (x_decline_selection_request)
11694 (x_reply_selection_request): Avoid type-punned deref of X events.
11696 2011-04-09 Eli Zaretskii <eliz@gnu.org>
11698 Fix some uses of `int' instead of EMACS_INT.
11699 * search.c (string_match_1, fast_string_match)
11700 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
11701 (scan_buffer, find_next_newline_no_quit)
11702 (find_before_next_newline, search_command, Freplace_match)
11703 (Fmatch_data): Make some `int' variables be EMACS_INT.
11705 * xdisp.c (display_count_lines): 3rd argument and return value now
11706 EMACS_INT. All callers changed.
11707 (pint2hrstr): Last argument is now EMACS_INT.
11709 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
11710 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
11711 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
11712 (decode_coding_utf_16, decode_coding_emacs_mule)
11713 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
11714 (decode_coding_ccl, decode_coding_charset)
11715 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
11716 (decode_coding_iso_2022, decode_coding_emacs_mule)
11717 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
11718 <char_offset, last_offset>: Declare EMACS_INT.
11719 (encode_coding_utf_8, encode_coding_utf_16)
11720 (encode_coding_emacs_mule, encode_invocation_designation)
11721 (encode_designation_at_bol, encode_coding_iso_2022)
11722 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
11723 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
11725 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
11726 (encode_invocation_designation): Last argument P_NCHARS is now
11728 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
11729 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
11731 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
11734 * ccl.c (Fccl_execute_on_string): Declare some variables
11737 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
11739 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
11741 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
11743 * process.c (Fformat_network_address): Doc fix.
11745 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
11747 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
11749 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
11751 * keyboard.c (read_char): Call Lisp function help-form-show,
11752 instead of using internal_with_output_to_temp_buffer.
11753 (Qhelp_form_show): New var.
11754 (syms_of_keyboard): Use DEFSYM macro.
11756 * print.c (internal_with_output_to_temp_buffer): Function deleted.
11758 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
11760 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
11762 * process.c (Flist_processes): Remove to Lisp.
11763 (list_processes_1): Delete.
11765 2011-04-06 Eli Zaretskii <eliz@gnu.org>
11767 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
11769 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
11771 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
11773 Fix more problems found by GCC 4.6.0's static checks.
11775 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
11777 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
11779 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
11781 * xdisp.c (vmessage): Mark as a printf-like function.
11783 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
11785 * sound.c (sound_warning): Don't crash if arg contains a printf format.
11787 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
11788 printf-like functions.
11789 (tiff_load): Add casts to remove these marks before passing them
11790 to system-supplied API.
11792 * eval.c (Fsignal): Remove excess argument to 'fatal'.
11794 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
11795 This avoids several warnings with gcc -Wstrict-overflow.
11796 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
11797 directly, rather than having caller test rule sign. This avoids
11798 some unnecessary tests.
11799 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
11800 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
11801 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
11803 * xfont.c (xfont_text_extents): Remove var that was set but not used.
11804 (xfont_open): Avoid unnecessary tests.
11806 * composite.c (composition_gstring_put_cache): Use unsigned integer.
11808 * composite.h, composite.c (composition_gstring_put_cache):
11809 Use EMACS_INT, not int, for length.
11811 * composite.h (COMPOSITION_DECODE_REFS): New macro,
11812 breaking out part of COMPOSITION_DECODE_RULE.
11813 (COMPOSITION_DECODE_RULE): Use it.
11814 * composite.c (get_composition_id): Remove unused local vars,
11815 by using the new macro.
11817 * textprop.c (set_text_properties_1): Change while to do-while,
11818 since the condition is always true at first.
11820 * intervals.c (graft_intervals_into_buffer): Mark var as used.
11821 (interval_deletion_adjustment): Return unsigned value.
11824 * process.c (list_processes_1, create_pty, read_process_output):
11825 (exec_sentinel): Remove vars that were set but not used.
11826 (create_pty): Remove unnecessary "volatile"s.
11827 (Fnetwork_interface_info): Avoid possibility of int overflow.
11828 (read_process_output): Do adaptive read buffering even if carryover.
11829 (read_process_output): Simplify nbytes computation if buffered.
11831 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
11833 * syntax.c (scan_words): Remove var that was set but not used.
11834 (update_syntax_table): Use unsigned instead of int.
11836 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
11837 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
11838 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
11840 * print.c (print_error_message): Avoid int overflow.
11842 * font.c (font_list_entities): Redo for clarity,
11843 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
11845 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
11846 (font_score): Avoid potential overflow in diff calculation.
11848 * fns.c (substring_both): Remove var that is set but not used.
11849 (sxhash): Redo loop for clarity and to avoid wraparound warning.
11851 * eval.c (funcall_lambda): Rename local to avoid shadowing.
11853 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
11854 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
11855 can always succeed if overflow has undefined behavior.
11857 * search.c (boyer_moore, wordify): Remove vars set but not used.
11858 (wordify): Omit three unnecessary tests.
11860 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
11861 All callers changed. This avoids the need for an unused var.
11863 * casefiddle.c (casify_region): Remove var that is set but not used.
11865 * dired.c (file_name_completion): Remove var that is set but not used.
11867 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
11869 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
11870 (Finsert_file_contents): Remove unnecessary code checking fd.
11872 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
11873 Check for integer overflow on size calculations.
11875 * buffer.c (Fprevious_overlay_change): Remove var that is set
11878 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
11879 Remove vars that are set but not used.
11880 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
11881 (timer_check_2): Mark vars as initialized.
11883 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
11885 * image.c (lookup_image): Remove var that is set but not used.
11886 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
11888 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
11889 that are set but not used.
11891 * xfns.c (make_invisible_cursor): Don't return garbage
11892 if XCreateBitmapFromData fails (Bug#8410).
11894 * xselect.c (x_get_local_selection, x_handle_property_notify):
11895 Remove vars that are set but not used.
11897 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
11898 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
11900 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
11901 Remove var that is set but not used.
11902 (scroll_bar_windows_size): Now size_t, not int.
11903 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
11904 Check for overflow.
11906 * xfaces.c (realize_named_face): Remove vars that are set but not used.
11907 (map_tty_color) [!defined MSDOS]: Likewise.
11909 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
11911 * coding.c: Remove vars that are set but not used.
11912 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
11913 All callers changed.
11914 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
11915 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
11916 (decode_coding_charset): Remove vars that are set but not used.
11918 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
11919 that is set but not used.
11921 * print.c (print_object): Remove var that is set but not used.
11923 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
11924 The gnulib version avoids calling malloc in the usual case,
11925 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
11926 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
11927 * filelock.c (current_lock_owner): Likewise.
11928 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
11929 * sysdep.c: Include allocator.h, careadlinkat.h.
11930 (emacs_no_realloc_allocator): New static constant.
11931 (emacs_readlink): New function.
11932 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
11933 ../lib/careadlinkat.h.
11935 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
11937 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
11938 first non-nil return value).
11940 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
11942 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
11943 if not defined (Bug#8403).
11945 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
11947 * xdisp.c (display_count_lines): Remove parameter `start',
11948 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11949 (get_char_face_and_encoding): Remove parameter `multibyte_p',
11950 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11951 (fill_stretch_glyph_string): Remove parameters `row' and `area',
11952 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
11953 and thereabouts. All callers changed.
11954 (get_per_char_metric): Remove parameter `f', unused since
11955 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11957 2011-04-02 Jim Meyering <meyering@redhat.com>
11959 do not dereference NULL upon failed strdup
11960 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
11961 (ns_get_family): Likewise.
11963 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
11965 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
11967 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
11969 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
11972 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
11974 Add lexical binding.
11976 * window.c (Ftemp_output_buffer_show): New fun.
11977 (Fsave_window_excursion):
11978 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
11980 * lread.c (lisp_file_lexically_bound_p): New function.
11981 (Fload): Bind Qlexical_binding.
11982 (readevalloop): Remove `evalfun' arg.
11983 Bind Qinternal_interpreter_environment.
11984 (Feval_buffer): Bind Qlexical_binding.
11985 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
11987 (syms_of_lread): Declare `lexical-binding'.
11989 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
11991 * keyboard.c (eval_dyn): New fun.
11992 (menu_item_eval_property): Use it.
11994 * image.c (parse_image_spec): Use Ffunctionp.
11996 * fns.c (concat, mapcar1): Accept byte-code-functions.
11998 * eval.c (Fsetq): Handle lexical vars.
11999 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
12000 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
12001 (FletX, Flet): Obey lexical binding.
12002 (Fcommandp): Handle closures.
12003 (Feval): New `lexical' arg.
12004 (eval_sub): New function extracted from Feval. Use it almost
12005 everywhere where Feval was used. Look up vars in lexical env.
12007 (Ffunctionp): Move from subr.el.
12008 (Ffuncall): Handle closures.
12009 (apply_lambda): Remove `eval_flags'.
12010 (funcall_lambda): Handle closures and new byte-code-functions.
12011 (Fspecial_variable_p): New function.
12012 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
12013 but without exporting it to Lisp.
12015 * doc.c (Fdocumentation, store_function_docstring):
12016 * data.c (Finteractive_form): Handle closures.
12018 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
12021 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
12023 (exec_byte_code): New function extracted from Fbyte_code to handle new
12024 calling convention for byte-code-functions. Add new byte-codes.
12026 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
12028 * alloc.c (Fmake_symbol): Init new `declared_special' field.
12030 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
12032 * xdisp.c (redisplay_internal): Fix prototype.
12034 2011-03-31 Eli Zaretskii <eliz@gnu.org>
12036 * xdisp.c (SCROLL_LIMIT): New macro.
12037 (try_scrolling): Use it when setting scroll_limit.
12038 Limit scrolling to 100 screen lines.
12039 (redisplay_window): Even when falling back on "recentering",
12040 position point in the window according to scroll-conservatively,
12041 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
12043 (try_scrolling): When point is above the window, allow searching
12044 as far as scroll_max, or one screenful, to compute vertical
12045 distance from PT to the scroll margin position. This prevents
12046 try_scrolling from unnecessarily failing when
12047 scroll-conservatively is set to a value slightly larger than the
12048 window height. Clean up the case of PT below the margin at bottom
12049 of window: scroll_max can no longer be INT_MAX. When aggressive
12050 scrolling is in use, don't let point enter the opposite scroll
12051 margin as result of the scroll.
12052 (syms_of_xdisp) <scroll-conservatively>: Document the
12053 threshold of 100 lines for never-recentering scrolling.
12055 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
12057 * dispextern.h (move_it_by_lines):
12058 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
12059 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
12060 (message_log_check_duplicate): Remove parameters `prev_bol' and
12061 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12062 (redisplay_internal): Remove parameter `preserve_echo_area',
12063 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
12065 * indent.c (Fvertical_motion):
12066 * window.c (window_scroll_pixel_based, Frecenter):
12067 Don't pass `need_y_p' to `move_it_by_lines'.
12069 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
12071 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
12072 steal a few bits to be more compact.
12073 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
12074 Remove unneeded casts.
12076 * bytecode.c (Fbyte_code): CAR and CDR can GC.
12078 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
12080 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
12081 binding" message (bug#7967).
12083 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
12085 Fix more problems found by GCC 4.6.0's static checks.
12087 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
12088 Remove unused local var.
12090 * editfns.c (Fmessage_box): Remove unused local var.
12092 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
12093 (note_mode_line_or_margin_highlight, note_mouse_highlight):
12094 Omit unused local vars.
12095 * window.c (shrink_windows): Omit unused local var.
12096 * menu.c (digest_single_submenu): Omit unused local var.
12097 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
12098 Omit unused local var.
12100 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
12101 Don't assume string length fits in int.
12102 (keyremap_step, read_key_sequence): Use size_t for sizes.
12103 (read_key_sequence): Don't check last_real_key_start redundantly.
12105 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
12106 instead of alloca (Bug#8344).
12108 * eval.c (Fbacktrace): Don't assume nargs fits in int.
12109 (Fbacktrace_frame): Don't assume nframes fits in int.
12111 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
12113 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
12116 * term.c (produce_glyphless_glyph): Remove unnecessary test.
12118 * cm.c (calccost): Turn while-do into do-while, for clarity.
12120 * keyboard.c (syms_of_keyboard): Use the same style as later
12121 in this function when indexing through an array. This also
12122 works around GCC bug 48267.
12124 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
12126 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
12128 * chartab.c (sub_char_table_ref_and_range): Redo for slight
12129 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
12131 * keyboard.c, keyboard.h (num_input_events): Now size_t.
12132 This avoids undefined behavior on integer overflow, and is a bit
12133 more convenient anyway since it is compared to a size_t variable.
12135 Variadic C functions now count arguments with size_t, not int.
12136 This avoids an unnecessary limitation on 64-bit machines, which
12137 caused (substring ...) to crash on large vectors (Bug#8344).
12138 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
12139 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
12140 All variadic functions and their callers changed accordingly.
12141 (struct gcpro.nvars): Now size_t, not int. All uses changed.
12142 * data.c (arith_driver, float_arith_driver): Likewise.
12143 * editfns.c (general_insert_function): Likewise.
12144 * eval.c (struct backtrace.nargs, interactive_p)
12145 (internal_condition_case_n, run_hook_with_args, apply_lambda)
12146 (funcall_lambda, mark_backtrace): Likewise.
12147 * fns.c (concat): Likewise.
12148 * frame.c (x_set_frame_parameters): Likewise.
12149 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
12150 0 if not found, not -1. All callers changed.
12152 * alloc.c (garbage_collect): Don't assume stack size fits in int.
12153 (stack_copy_size): Now size_t, not int.
12154 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
12156 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
12158 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
12159 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12160 All callers changed.
12162 * lisp.h (multibyte_char_to_unibyte):
12163 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
12164 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12165 * character.h (CHAR_TO_BYTE8):
12166 * cmds.c (internal_self_insert):
12167 * editfns.c (general_insert_function):
12168 * keymap.c (push_key_description):
12169 * search.c (Freplace_match):
12170 * xdisp.c (message_dolog, set_message_1): All callers changed.
12172 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
12174 * keyboard.c (safe_run_hook_funcall): New function.
12175 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
12176 don't set the hook to nil, but remove the offending function instead.
12177 (Qcommand_hook_internal): Remove, unused.
12178 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
12179 Vcommand_hook_internal.
12181 * eval.c (enum run_hooks_condition): Remove.
12182 (funcall_nil, funcall_not): New functions.
12183 (run_hook_with_args): Call each function through a `funcall' argument.
12184 Remove `cond' argument, now redundant.
12185 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
12186 (Frun_hook_with_args_until_failure): Adjust accordingly.
12187 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
12189 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
12191 * dispextern.h (string_buffer_position): Remove declaration.
12193 * print.c (strout): Remove parameter `multibyte', unused since
12194 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
12196 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
12197 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
12198 All callers changed.
12200 * w32.c (_wsa_errlist): Use braces for struct initializers.
12202 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
12203 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
12204 All callers changed.
12205 (string_buffer_position): Likewise. Also, make static (it's never
12206 used outside xdisp.c).
12207 (cursor_row_p): Remove parameter `w', unused since
12208 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
12209 (decode_mode_spec): Remove parameter `precision', introduced during
12210 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
12211 All callers changed.
12213 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12215 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
12217 2011-03-27 Anders Lindgren <andlind@gmail.com>
12219 * nsterm.m (ns_menu_bar_is_hidden): New variable.
12220 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
12221 (ns_update_auto_hide_menu_bar): New functions.
12222 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
12223 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
12224 ns_constrain_all_frames.
12225 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
12226 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
12228 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12230 * nsmenu.m (runDialogAt): Remove argument to timer_check.
12232 2011-03-27 Glenn Morris <rgm@gnu.org>
12234 * syssignal.h: Replace RETSIGTYPE with void.
12235 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
12236 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
12237 Replace SIGTYPE with void everywhere.
12238 * s/usg5-4-common.h (SIGTYPE): Remove definition.
12239 * s/template.h (SIGTYPE): Remove commented out definition.
12241 2011-03-26 Eli Zaretskii <eliz@gnu.org>
12243 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
12244 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
12246 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
12248 * w32.c (read_unc_volume): Use parameter `henum', instead of
12249 global variable `wget_enum_handle'.
12251 * keymap.c (describe_vector): Remove parameters `indices' and
12252 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
12253 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
12255 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
12257 * keyboard.c (timer_check): Remove parameter `do_it_now',
12258 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
12259 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
12260 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
12262 * keyboard.c (read_char):
12263 * w32menu.c (w32_menu_display_help):
12264 * xmenu.c (show_help_event, menu_help_callback):
12265 Adjust calls to `show_help_echo'.
12267 * gtkutil.c (xg_maybe_add_timer):
12268 * keyboard.c (readable_events):
12269 * process.c (wait_reading_process_output):
12270 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
12272 * insdel.c (adjust_markers_gap_motion):
12273 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
12274 (gap_left, gap_right): Don't call it.
12276 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
12278 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
12279 incurred during fontification.
12281 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
12283 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
12284 (DEFVAR_PER_BUFFER): Don't pass it.
12286 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
12287 (scrolling_window): Don't pass it.
12289 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
12291 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
12293 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
12295 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
12296 of variables specific to SELinux and computation of `encoded_absname'.
12298 * image.c (XPutPixel): Remove unused variable `height'.
12300 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
12302 * unexw32.c (get_section_info): Remove unused variable `section'.
12304 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
12305 (system_process_attributes): Remove unused variable `sess'.
12306 (sys_read): Remove unused variable `err'.
12308 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
12309 (w32_wnd_proc): Remove unused variable `isdead'.
12310 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
12311 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
12312 (x_create_tip_frame): Remove unused variable `tem'.
12314 * w32inevt.c (w32_console_read_socket):
12315 Remove unused variable `no_events'.
12317 * w32term.c (x_draw_composite_glyph_string_foreground):
12318 Remove unused variable `width'.
12320 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
12322 * w32term.c (x_set_glyph_string_clipping):
12323 Don't pass uninitialized region to CombineRgn.
12325 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
12327 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
12328 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
12329 (Fx_close_connection): Remove unused variable `i'.
12331 * w32font.c (w32font_draw): Return number of glyphs.
12332 (w32font_open_internal): Remove unused variable `i'.
12333 (w32font_driver): Add missing initializer.
12335 * w32menu.c (utf8to16): Remove unused variable `utf16'.
12336 (fill_in_menu): Remove unused variable `items_added'.
12338 * w32term.c (last_mouse_press_frame): Remove static global variable.
12339 (w32_clip_to_row): Remove unused variable `f'.
12340 (x_delete_terminal): Remove unused variable `i'.
12342 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
12343 (NOTHING): Remove unused static global variable.
12344 (uniscribe_check_otf): Remove unused variable `table'.
12345 (uniscribe_font_driver): Add missing initializers.
12347 2011-03-23 Julien Danjou <julien@danjou.info>
12349 * term.c (Fsuspend_tty, Fresume_tty):
12350 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
12351 * window.c (temp_output_buffer_show):
12352 * insdel.c (signal_before_change):
12353 * frame.c (Fhandle_switch_frame):
12354 * fileio.c (Fdo_auto_save):
12355 * emacs.c (Fkill_emacs):
12356 * editfns.c (save_excursion_restore):
12357 * cmds.c (internal_self_insert):
12358 * callint.c (Fcall_interactively):
12359 * buffer.c (Fkill_all_local_variables):
12360 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
12362 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
12363 unconditionally since it does the check itself.
12365 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
12367 Fix more problems found by GCC 4.5.2's static checks.
12369 * coding.c (encode_coding_raw_text): Avoid unnecessary test
12370 the first time through the loop, since we know p0 < p1 then.
12371 This also avoids a gcc -Wstrict-overflow warning.
12373 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
12374 leading to a memory leak, possible in functions like
12375 load_charset_map_from_file that can allocate an unbounded number
12376 of objects (Bug#8318).
12378 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
12379 that could (at least in theory) be that large.
12381 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
12382 This is less likely to overflow, and avoids undefined behavior if
12383 overflow does occur. All callers changed. Use strtoul to scan
12384 for the unsigned long integer.
12385 (pint2hrstr): Simplify and tune code slightly.
12386 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
12388 * scroll.c (do_scrolling): Work around GCC bug 48228.
12389 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
12391 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
12392 This also avoids a warning with gcc -Wstrict-overflow.
12393 (validate_x_resource_name): Simplify count usage.
12394 This also avoids a warning with gcc -Wstrict-overflow.
12396 * fileio.c (Fcopy_file): Report error if fchown or fchmod
12399 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
12401 * process.c (Fmake_network_process): Use socklen_t, not int,
12402 where POSIX says socklen_t is required in portable programs.
12403 This fixes a porting bug on hosts like 64-bit HP-UX, where
12404 socklen_t is wider than int (Bug#8277).
12405 (Fmake_network_process, server_accept_connection):
12406 (wait_reading_process_output, read_process_output):
12409 * process.c: Rename or move locals to avoid shadowing.
12410 (list_processes_1, Fmake_network_process):
12411 (read_process_output_error_handler, exec_sentinel_error_handler):
12412 Rename or move locals.
12413 (Fmake_network_process): Define label "retry_connect" only if needed.
12414 (Fnetwork_interface_info): Fix pointer signedness.
12415 (process_send_signal): Add cast to avoid pointer signedness problem.
12416 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
12417 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
12419 Make tparam.h and terminfo.c consistent.
12420 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
12421 Include tparam.h instead, since it declares them.
12422 * cm.h (PC): Remove extern decl; tparam.h now does this.
12423 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
12424 * terminfo.c: Include tparam.h, to check interfaces.
12425 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
12426 (tparam): Adjust signature to match interface in tparam.h;
12427 this removes some undefined behavior. Check that outstring and len
12428 are zero, which they always are with Emacs.
12429 * tparam.h (PC, BC, UP): New extern decls.
12431 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
12432 (xftfont_open): Rename locals to avoid shadowing.
12434 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
12435 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
12436 (OTF_TAG_SYM): Omit macro if not needed.
12437 (ftfont_list): Remove unused local.
12438 (get_adstyle_property, ftfont_pattern_entity):
12439 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
12440 Rename locals to avoid shadowing.
12442 * xfont.c (xfont_list_family): Mark var as initialized.
12444 * xml.c (make_dom): Now static.
12446 * composite.c (composition_compute_stop_pos): Rename local to
12448 (composition_reseat_it): Remove unused locals.
12449 (find_automatic_composition, composition_adjust_point): Likewise.
12450 (composition_update_it): Mark var as initialized.
12451 (find_automatic_composition): Mark vars as initialized,
12452 with a FIXME (Bug#8290).
12454 character.h: Rename locals to avoid shadowing.
12455 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
12456 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
12457 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
12458 (BUF_DEC_POS): Be more systematic about renaming local temporaries
12459 to avoid shadowing.
12461 * textprop.c (property_change_between_p): Remove; unused.
12463 * intervals.c (interval_start_pos): Now static.
12465 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
12467 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
12468 Rename locals to avoid shadowing.
12470 * sound.c (wav_play, au_play, Fplay_sound_internal):
12471 Fix pointer signedness.
12472 (alsa_choose_format): Remove unused local var.
12473 (wav_play): Initialize a variable to 0, to prevent undefined
12474 behavior (Bug#8278).
12476 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
12478 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
12480 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
12481 clobbering (Bug#8298).
12482 * sysdep.c (sys_subshell): Likewise.
12483 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
12485 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
12486 This should get cleaned up, so that child_setup has the
12487 same signature on all platforms.
12489 * callproc.c (call_process_cleanup): Now static.
12490 (relocate_fd): Rename locals to avoid shadowing.
12492 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
12494 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
12495 not to be necessary, and produces flickering.
12497 2011-03-20 Glenn Morris <rgm@gnu.org>
12499 * config.in: Remove file.
12501 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
12503 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
12504 are now in src/globals.h.
12505 (syms_of_minibuf): Remove spurious & from previous change.
12507 2011-03-20 Leo Liu <sdl.web@gmail.com>
12509 * minibuf.c (completing-read-function): New variable.
12510 (completing-read-default): Rename from completing-read.
12511 (completing-read): Call completing-read-function.
12513 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
12515 * xfaces.c (Fx_load_color_file):
12516 Read color file from absolute filename (bug#8250).
12518 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
12520 * makefile.w32-in: Update dependencies.
12522 2011-03-17 Eli Zaretskii <eliz@gnu.org>
12524 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
12526 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
12528 Fix more problems found by GCC 4.5.2's static checks.
12530 * process.c (make_serial_process_unwind, send_process_trap):
12531 (sigchld_handler): Now static.
12533 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
12534 That way, the code declares only the vars that it needs.
12535 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
12536 * s/cygwin.h (PTY_ITERATION): Likewise.
12537 * s/darwin.h (PTY_ITERATION): Likewise.
12538 * s/gnu-linux.h (PTY_ITERATION): Likewise.
12540 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
12541 * process.c (allocate_pty): Don't declare stb unless it's needed.
12543 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
12544 (CONSTANTLIM): Remove; unused.
12545 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
12546 Define only if needed.
12548 * unexelf.c (unexec): Name an expression,
12549 to avoid gcc -Wbad-function-cast warning.
12550 Use a different way to cause a compilation error if anyone uses
12551 n rather than nn, a way that does not involve shadowing.
12552 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
12554 * deps.mk (unexalpha.o): Remove; unused.
12556 New file unexec.h, the (simple) interface for unexec (Bug#8267).
12557 * unexec.h: New file.
12558 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
12559 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
12560 Depend on unexec.h.
12561 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
12562 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
12563 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
12564 Change as necessary to match prototype in unexec.h.
12566 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
12568 (back_comment, skip_chars): Mark vars as initialized.
12570 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
12571 Rename locals to avoid shadowing.
12573 * lread.c (read1): Rewrite so as not to use empty "else".
12574 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
12576 * print.c (Fredirect_debugging_output): Fix pointer signedess.
12578 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
12579 warning when compiling print.c.
12581 * font.c (font_unparse_fcname): Abort in an "impossible" situation
12582 instead of using an uninitialized var.
12583 (font_sort_entities): Mark var as initialized.
12585 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
12587 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
12588 pointers to constants.
12589 (font_parse_fcname): Remove unused vars.
12590 (font_delete_unmatched): Now static.
12591 (font_get_spec): Remove; unused.
12592 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
12593 (font_update_drivers, Ffont_get_glyphs, font_add_log):
12594 Rename or move locals to avoid shadowing.
12596 * fns.c (require_nesting_list, require_unwind): Now static.
12597 (Ffillarray): Rename locals to avoid shadowing.
12599 * floatfns.c (domain_error2): Define only if needed.
12600 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
12602 * alloc.c (mark_backtrace): Move decl from here ...
12603 * lisp.h: ... to here, so that it can be checked.
12605 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
12606 (Fdefvar): Rewrite so as not to use empty "else".
12607 (lisp_indirect_variable): Name an expression,
12608 to avoid gcc -Wbad-function-cast warning.
12609 (Fdefvar): Rename locals to avoid shadowing.
12611 * callint.c (quotify_arg, quotify_args): Now static.
12612 (Fcall_interactively): Rename locals to avoid shadowing.
12613 Use const pointer when appropriate.
12615 * lisp.h (get_system_name, get_operating_system_release):
12616 Move decls here, to check interfaces.
12617 * process.c (get_operating_system_release): Move decl to lisp.h.
12618 * xrdb.c (get_system_name): Likewise.
12619 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
12620 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
12621 some of which prompt warnings from gcc -Wbad-function-cast.
12622 (Fformat_time_string, Fencode_time, Finsert_char):
12623 (Ftranslate_region_internal, Fformat):
12624 Rename or remove local vars to avoid shadowing.
12625 (Ftranslate_region_internal): Mark var as initialized.
12627 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
12630 * lisp.h (eassert): Check that the argument compiles, even if
12631 ENABLE_CHECKING is not defined.
12633 * data.c (Findirect_variable): Name an expression, to avoid
12634 gcc -Wbad-function-cast warning.
12635 (default_value, arithcompare, arith_driver, arith_error): Now static.
12636 (store_symval_forwarding): Rename local to avoid shadowing.
12637 (Fmake_variable_buffer_local, Fmake_local_variable):
12638 Mark variables as initialized.
12639 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
12641 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
12642 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
12643 Rename locals to avoid shadowing.
12644 (mark_stack): Move local variables into the #ifdef region where
12646 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
12647 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
12649 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
12650 (GC_STRING_CHARS): Remove; not used.
12651 (Fmemory_limit): Cast sbrk's returned value to char *.
12653 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
12654 avoids undefined behavior in theory.
12656 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
12658 Use functions, not macros, for up- and down-casing (Bug#8254).
12659 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12660 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
12661 to use the following functions instead of these macros.
12662 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
12663 EMACS_INT, since callers assume the returned value fits in int.
12664 (upcase1): Likewise, for UPCASE_TABLE.
12665 (uppercasep, lowercasep, upcase): New static inline functions.
12666 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
12667 the race-condition problem in the old DOWNCASE.
12669 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
12670 Rename locals to avoid shadowing.
12671 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
12672 (regex_compile, re_search_2, re_match_2_internal):
12673 Remove unused local vars.
12674 (FREE_VAR): Rewrite so as not to use empty "else",
12675 which gcc can warn about.
12676 (regex_compile, re_match_2_internal): Mark locals as initialized.
12677 (RETALLOC_IF): Define only if needed.
12678 (WORDCHAR_P): Likewise. This one is never needed, but is used
12679 only in a comment talking about a compiler bug, so put inside
12680 the #if 0 of that comment.
12681 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
12682 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
12685 * search.c (boyer_moore): Rename locals to avoid shadowing.
12686 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
12687 (PREV_CHAR_BOUNDARY): Likewise.
12689 * search.c (simple_search): Remove unused var.
12691 * dired.c (compile_pattern): Move decl from here ...
12692 * lisp.h: ... to here, so that it can be checked.
12693 (struct re_registers): New forward decl.
12695 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
12697 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
12699 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
12700 Rename locals to avoid shadowing.
12701 (Fvertical_motion): Mark locals as initialized.
12703 * casefiddle.c (casify_object, casify_region): Now static.
12704 (casify_region): Mark local as initialized.
12706 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
12708 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
12709 New macros, so that the caller can use some names other than
12710 gcpro1, gcpro2, etc.
12711 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
12713 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
12714 argument, for consistency with GCPRO2_VAR, etc: it is now the
12715 prefix of the variable, not the variable itself. All uses
12717 * dired.c (directory_files_internal, file_name_completion):
12718 Rename locals to avoid shadowing.
12720 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
12721 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
12722 dired.c's scmp function, had undefined behavior.
12723 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12724 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
12725 * buffer.h: ... to here, because these macros use current_buffer,
12726 and the new implementation with inline functions needs to have
12727 current_buffer in scope now, rather than later when the macros
12729 (downcase, upcase1): New static inline functions.
12730 (DOWNCASE, UPCASE1): Reimplement using these functions.
12731 This avoids undefined behavior in expressions like
12732 DOWNCASE (x) == DOWNCASE (y), which previously suffered
12733 from race conditions in accessing the global variables
12734 case_temp1 and case_temp2.
12735 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
12736 * lisp.h (case_temp1, case_temp2): Remove their decls.
12737 * character.h (ASCII_CHAR_P): Move from here ...
12738 * lisp.h: ... to here, so that the inline functions mentioned
12739 above can use them.
12741 * dired.c (directory_files_internal_unwind): Now static.
12743 * fileio.c (file_name_as_directory, directory_file_name):
12744 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
12746 (file_name_as_directory): Use const pointers when appropriate.
12747 (Fexpand_file_name): Likewise. In particular, newdir might
12748 point at constant storage, so make it a const pointer.
12749 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
12750 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
12752 (Fset_file_times, Finsert_file_contents, auto_save_error):
12753 Rename locals to avoid shadowing.
12755 * minibuf.c (choose_minibuf_frame_1): Now static.
12756 (Ftry_completion, Fall_completions): Rename or remove locals
12757 to avoid shadowing.
12759 * marker.c (bytepos_to_charpos): Remove; unused.
12761 * lisp.h (verify_bytepos, count_markers): New decls,
12762 so that gcc does not warn that these functions aren't declared.
12764 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
12765 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
12766 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
12767 (copy_text): Remove unused local var.
12769 * filelock.c (within_one_second): Now static.
12770 (lock_file_1): Rename local to avoid shadowing.
12772 * buffer.c (fix_overlays_before): Mark locals as initialized.
12773 (fix_start_end_in_overlays): Likewise. This function should be
12774 simplified by using pointers-to-pointers, but that's a different
12776 (switch_to_buffer_1): Now static.
12777 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
12778 (report_overlay_modification): Rename locals to avoid shadowing.
12780 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
12781 Fix pointer signedness issue.
12782 (sys_subshell): Mark local as volatile if checking for lint,
12783 to suppress a gcc -Wclobbered warning that does not seem to be right.
12784 (MAXPATHLEN): Define only if needed.
12786 * process.c (serial_open, serial_configure): Move decls from here ...
12787 * systty.h: ... to here, so that they can be checked.
12789 * fns.c (get_random, seed_random): Move extern decls from here ...
12790 * lisp.h: ... to here, so that they can be checked.
12792 * sysdep.c (reset_io): Now static.
12793 (wait_for_termination_signal): Remove; unused.
12795 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
12796 (copy_keymap_item, append_key, push_text_char_description):
12798 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
12799 (DENSE_TABLE_SIZE): Remove; unused.
12800 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
12801 (describe_map_tree):
12802 Rename locals to avoid shadowing.
12804 * keyboard.c: Declare functions static if they are not used elsewhere.
12805 (echo_char, echo_dash, cmd_error, top_level_2):
12806 (poll_for_input, handle_async_input): Now static.
12807 (read_char, kbd_buffer_get_event, make_lispy_position):
12808 (make_lispy_event, make_lispy_movement, apply_modifiers):
12809 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
12810 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
12811 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
12812 (read_key_sequence, read_char): Mark locals as initialized.
12813 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
12815 * keyboard.h (make_ctrl_char): New decl.
12816 (mark_kboards): Move decl here ...
12817 * alloc.c (mark_kboards): ... from here.
12819 * lisp.h (force_auto_save_soon): New decl.
12821 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
12822 (DEFINE_DUMMY_FUNCTION): New macro.
12823 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
12825 (main): Add casts to avoid warnings
12826 if GCC considers string literals to be constants.
12828 * lisp.h (fatal_error_signal): Add decl, since it's exported.
12830 * dbusbind.c: Pointer signedness fixes.
12831 (xd_signature, xd_append_arg, xd_initialize):
12832 (Fdbus_call_method, Fdbus_call_method_asynchronously):
12833 (Fdbus_method_return_internal, Fdbus_method_error_internal):
12834 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
12835 (Fdbus_register_signal): Use SSDATA when the context wants char *.
12837 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
12838 if GCC considers string literals to be constants.
12839 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
12841 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
12843 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
12844 (print_preprocess, print_object): New macro to fix last change.
12846 * print.c (print_preprocess): Don't forget font objects.
12848 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
12850 * emacs.c (USAGE3): Doc fixes.
12852 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
12854 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
12857 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
12859 * lisp.h (VWindow_system, Qfile_name_history):
12860 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
12861 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
12862 (w32_system_caret_x, w32_system_caret_y): Declare extern.
12864 * w32select.c: Don't #include "keyboard.h".
12865 (run_protected): Add extern declaration for waiting_for_input.
12867 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
12868 * w32console.c (detect_input_pending, read_input_pending)
12869 (encode_terminal_code):
12870 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
12871 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
12872 (w32_system_caret_y, Qfile_name_history):
12873 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
12874 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
12875 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
12876 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
12877 * w32proc.c (Qlocal, report_file_error):
12878 * w32term.c (Vwindow_system, updating_frame):
12879 * w32uniscribe.c (initialized, uniscribe_font_driver):
12880 Remove unneeded extern declarations.
12882 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
12884 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
12886 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
12888 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
12889 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
12890 These macros can no longer be used for assignment.
12892 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
12893 Assign struct members directly, instead of using BUF_BEGV etc.
12894 (record_buffer_markers, fetch_buffer_markers): New functions for
12895 recording and fetching special buffer markers.
12896 (set_buffer_internal_1, set_buffer_temp): Use them.
12898 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
12900 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
12902 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
12903 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
12905 * xdisp.c (hscroll_window_tree):
12906 (reconsider_clip_changes): Use PT instead of BUF_PT.
12908 2011-03-13 Eli Zaretskii <eliz@gnu.org>
12910 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
12911 $(EMACS_ROOT)/lib/intprops.h.
12913 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
12915 Fix more problems found by GCC 4.5.2's static checks.
12917 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
12918 to unsigned char * to avoid compiler diagnostic.
12919 (xg_free_frame_widgets): Make it clear that a local variable is
12920 needed only if USE_GTK_TOOLTIP.
12921 (gdk_window_get_screen): Make it clear that this macro is needed
12922 only if USE_GTK_TOOLTIP.
12923 (int_gtk_range_get_value): New function, which avoids a diagnostic
12924 from gcc -Wbad-function-cast.
12925 (xg_set_toolkit_scroll_bar_thumb): Use it.
12926 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
12927 diagnostic from gcc -Wbad-function-cast.
12928 (get_utf8_string, xg_get_file_with_chooser):
12929 Rename locals to avoid shadowing.
12930 (create_dialog): Move locals to avoid shadowing.
12932 * xgselect.c (xg_select): Remove unused var.
12934 * image.c (four_corners_best): Mark locals as initialized.
12935 (gif_load): Initialize transparent_p to zero (Bug#8238).
12936 Mark another local as initialized.
12937 (my_png_error, my_error_exit): Mark with NO_RETURN.
12939 * image.c (clear_image_cache): Now static.
12940 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
12941 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
12942 (x_edge_detection): Remove unnecessary cast that
12943 gcc -Wbad-function-cast diagnoses.
12944 (gif_load): Fix pointer signedness.
12945 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
12946 (jpeg_load, gif_load): Rename locals to avoid shadowing.
12948 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
12950 Improve quality of tests for time stamp overflow.
12951 For example, without this patch (encode-time 0 0 0 1 1
12952 1152921504606846976) returns the obviously-bogus value (-948597
12953 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
12954 reports time overflow. See
12955 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
12956 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
12957 * editfns.c: Include limits.h and intprops.h.
12958 (TIME_T_MIN, TIME_T_MAX): New macros.
12959 (time_overflow): Move earlier, to before first use.
12960 (hi_time, lo_time): New functions, for an accurate test for
12961 out-of-range times.
12962 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
12963 (Fget_internal_run_time): Don't assume time_t fits in int.
12964 (make_time): Use list2 instead of Fcons twice.
12965 (Fdecode_time): More accurate test for out-of-range times.
12966 (check_tm_member): New function.
12967 (Fencode_time): Use it, to test for out-of-range times.
12968 (lisp_time_argument): Don't rely on undefined left-shift and
12969 right-shift behavior when checking for time stamp overflow.
12971 * editfns.c (time_overflow): New function, refactoring common code.
12972 (Fformat_time_string, Fdecode_time, Fencode_time):
12973 (Fcurrent_time_string): Use it.
12975 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
12976 * dired.c (make_time): Move to ...
12977 * editfns.c (make_time): ... here.
12978 * systime.h: Note the move.
12980 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
12982 * fringe.c (update_window_fringes): Remove unused variables.
12984 * unexmacosx.c (copy_data_segment): Also copy __got section.
12987 2011-03-12 Eli Zaretskii <eliz@gnu.org>
12989 * termcap.c [MSDOS]: Include "msdos.h".
12990 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
12991 Constify `char *' arguments and their references according to
12992 prototypes in tparam.h.
12994 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
12996 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
12997 Adapt all references accordingly.
12999 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
13001 2011-03-11 Tom Tromey <tromey@redhat.com>
13003 * buffer.c (syms_of_buffer): Remove obsolete comment.
13005 2011-03-11 Eli Zaretskii <eliz@gnu.org>
13007 * termhooks.h (encode_terminal_code): Declare prototype.
13009 * msdos.c (encode_terminal_code): Don't declare prototype.
13011 * term.c (encode_terminal_code): Now external again, used by
13012 w32console.c and msdos.c.
13014 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
13015 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
13017 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
13019 Fix some minor problems found by GCC 4.5.2's static checks.
13021 * fringe.c (update_window_fringes): Mark locals as initialized
13023 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
13025 * alloc.c (mark_fringe_data): Move decl from here ...
13026 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
13027 to check its interface.
13028 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
13030 * fontset.c (free_realized_fontset): Now static.
13031 (Fset_fontset_font): Rename local to avoid shadowing.
13032 (fontset_font): Mark local as initialized.
13033 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
13035 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
13037 * xselect.c (x_disown_buffer_selections): Remove; not used.
13038 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
13039 (x_own_selection, Fx_disown_selection_internal): Rename locals
13040 to avoid shadowing.
13041 (x_handle_dnd_message): Remove local to avoid shadowing.
13043 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
13044 so that the caller can use some name other than gcpro1.
13045 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
13046 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13047 (Fx_backspace_delete_keys_p):
13048 Use them to avoid shadowing, and rename vars to avoid shadowing.
13049 (x_decode_color, x_set_name, x_window): Now static.
13050 (Fx_create_frame): Add braces to silence GCC warning.
13051 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
13052 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
13053 Remove unused locals.
13054 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13055 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
13056 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
13059 * xterm.h (x_mouse_leave): New decl.
13061 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
13062 Remove unused functions.
13063 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
13064 (x_calc_absolute_position): Now static.
13065 (XTread_socket): Don't define label "out" unless it's used.
13066 Don't declare local "event" unless it's used.
13067 (x_iconify_frame, x_free_frame_resources): Don't declare locals
13068 unless they are used.
13069 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
13070 (x_fatal_error_signal): Remove; not used.
13071 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
13072 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
13073 (x_error_catcher, x_connection_closed, x_error_handler):
13074 (x_error_quitter, xembed_send_message, x_iconify_frame):
13075 (my_log_handler): Rename locals to avoid shadowing.
13076 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
13077 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
13079 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
13080 Rename or move locals to avoid shadowing.
13081 (tty_defined_color, merge_face_heights): Now static.
13082 (free_realized_faces_for_fontset): Remove; not used.
13083 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
13084 does not deduce is never used uninitialized.
13085 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
13086 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
13088 * terminal.c (store_terminal_param): Now static.
13090 * xmenu.c (menu_highlight_callback): Now static.
13091 (set_frame_menubar): Remove unused local.
13092 (xmenu_show): Rename parameter to avoid shadowing.
13093 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
13094 since they might point to immutable storage.
13095 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
13096 since it's unused otherwise.
13098 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
13099 Add a FIXME, since the code still doesn't look right. (Bug#8215)
13100 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
13101 avoids a gcc -Wuninitialized diagnostic.
13102 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
13103 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
13104 does not deduce are never used uninitialized.
13106 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
13108 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
13109 * window.c (window_loop, size_window):
13110 (run_window_configuration_change_hook, enlarge_window): Likewise.
13112 * window.c (display_buffer): Now static.
13113 (size_window): Mark variables that gcc -Wuninitialized
13114 does not deduce are never used uninitialized.
13115 * window.h (check_all_windows): New decl, to forestall
13116 gcc -Wmissing-prototypes diagnostic.
13117 * dispextern.h (bidi_dump_cached_states): Likewise.
13119 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
13121 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
13122 Include <limits.h>.
13123 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
13124 and to avoid gcc -Wuninitialized warning.
13125 (load_charset_map): Mark variables that gcc -Wuninitialized
13126 does not deduce are never used uninitialized.
13127 (load_charset): Abort instead of using uninitialized var (Bug#8229).
13129 * coding.c (coding_set_source, coding_set_destination):
13130 Use "else { /* comment */ }" rather than "else /* comment */;"
13131 for clarity, and to avoid gcc -Wempty-body warning.
13132 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
13133 a block, when the outer 'i' will do.
13134 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
13135 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
13136 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
13137 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
13138 (Fdecode_sjis_char, Fdefine_coding_system_internal):
13139 Rename locals to avoid shadowing.
13140 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
13141 * coding.c (emacs_mule_char, encode_invocation_designation):
13142 Now static, since they're not used elsewhere.
13143 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
13144 (decode_coding_object, encode_coding_object, detect_coding_system):
13145 (decode_coding_emacs_mule): Mark variables that gcc
13146 -Wuninitialized does not deduce are never used uninitialized.
13147 (detect_coding_iso_2022): Initialize a local variable that might
13148 be used uninitialized. Leave a FIXME because it's not clear that
13149 this initialization is needed. (Bug#8211)
13150 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
13151 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
13152 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
13153 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
13154 Remove unused macros.
13156 * category.c (hash_get_category_set): Remove unused local var.
13157 (copy_category_table): Now static, since it's not used elsewhere.
13158 * character.c (string_count_byte8): Likewise.
13160 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
13161 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
13163 * chartab.c (copy_sub_char_table): Now static, since it's not used
13165 (sub_char_table_ref_and_range, char_table_ref_and_range):
13166 Rename locals to avoid shadowing.
13167 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
13169 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
13170 (BIDI_BOB): Remove unused macro.
13172 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
13173 deduce are never used uninitialized.
13174 * term.c (encode_terminal_code): Likewise.
13176 * term.c (encode_terminal_code): Now static. Remove unused local.
13178 * tparam.h: New file.
13179 * term.c, tparam.h: Include it.
13180 * deps.mk (term.o, tparam.o): Depend on tparam.h.
13181 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
13182 Move these decls to tparam.h, and make them agree with what
13183 is actually in tparam.c. The previous trick of using incompatible
13184 decls in different modules does not conform to the C standard.
13185 All callers of tparam changed to use tparam's actual API.
13186 * tparam.c (tparam1, tparam, tgoto):
13187 Use const pointers where appropriate.
13189 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
13190 * cm.h (struct cm): Likewise.
13191 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
13192 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
13193 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
13194 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
13195 (turn_on_face, init_tty): Likewise.
13196 * termchar.h (struct tty_display_info): Likewise.
13198 * term.c (term_mouse_position): Rename local to avoid shadowing.
13200 * alloc.c (mark_ttys): Move decl from here ...
13201 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
13203 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
13205 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
13207 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
13209 * search.c (compile_pattern_1): Remove argument regp, unused since
13210 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
13211 (compile_pattern): Don't pass it.
13213 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
13215 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
13216 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
13218 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
13220 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
13222 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
13223 gdk_window_get_screen, gdk_window_get_geometry,
13224 gdk_x11_window_lookup_for_display and GDK_KEY_g.
13225 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
13226 (xg_get_pixbuf_from_pixmap): New function.
13227 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
13228 to Pixmap, take frame as parameter, remove GdkColormap parameter.
13229 Call xg_get_pixbuf_from_pixmap instead of
13230 gdk_pixbuf_get_from_drawable.
13231 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
13232 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
13233 (xg_check_special_colors): Use GtkStyleContext and its functions
13235 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
13236 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
13237 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
13238 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
13239 Call gtk_widget_get_preferred_size.
13240 (xg_frame_resized): gdk_window_get_geometry only takes 5
13242 (xg_win_to_widget, xg_event_is_for_menubar):
13243 Call gdk_x11_window_lookup_for_display.
13244 (xg_set_widget_bg): New function.
13245 (delete_cb): New function.
13246 (xg_create_frame_widgets): Connect delete-event to delete_cb.
13247 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
13248 (xg_set_background_color): Call xg_set_widget_bg.
13249 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
13250 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
13251 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
13252 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
13254 (update_frame_tool_bar): Call gtk_widget_hide.
13255 (xg_initialize): Use GDK_KEY_g.
13257 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
13259 (x_session_initialize): Call gdk_x11_set_sm_client_id.
13261 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
13262 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
13263 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
13265 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
13267 * w32xfns.c (select_palette): Check success of RealizePalette against
13268 GDI_ERROR, not zero.
13270 See ChangeLog.11 for earlier changes.
13272 ;; Local Variables:
13276 Copyright (C) 2011-2012 Free Software Foundation, Inc.
13278 This file is part of GNU Emacs.
13280 GNU Emacs is free software: you can redistribute it and/or modify
13281 it under the terms of the GNU General Public License as published by
13282 the Free Software Foundation, either version 3 of the License, or
13283 (at your option) any later version.
13285 GNU Emacs is distributed in the hope that it will be useful,
13286 but WITHOUT ANY WARRANTY; without even the implied warranty of
13287 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13288 GNU General Public License for more details.
13290 You should have received a copy of the GNU General Public License
13291 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.