]> code.delx.au - gnu-emacs/blob - src/ChangeLog
* xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
[gnu-emacs] / src / ChangeLog
1 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2
3 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
4 instead of truncating it to 63 (admittedly a generous limit).
5
6 * process.c: Fix spelling and caps in comments.
7
8 2012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
9
10 * emacs.c (setpgrp): Remove definition, unused.
11 * sysdep.c (setpgrp): Remove definition, not used in this file.
12
13 2012-06-24 Juanma Barranquero <lekktu@gmail.com>
14
15 * makefile.w32-in: Update dependencies.
16
17 2012-06-24 Eli Zaretskii <eliz@gnu.org>
18
19 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
20 (SYSTIME_H): Add nt/inc/sys/time.h.
21
22 * systime.h [WINDOWSNT]: Include sys/time.h.
23
24 * s/ms-w32.h (struct timespec): Definition moved from
25 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
26
27 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
28
29 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
30 * buffer.h (buffer_slot_type_mismatch):
31 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
32 * eval.c (unwind_to_catch):
33 * image.c (my_png_error, my_error_exit):
34 * keyboard.c (quit_throw_to_read_char, user_error)
35 (Fexit_recursive_edit, Fabort_recursive_edit):
36 * lisp.h (die, args_out_of_range, args_out_of_range_3)
37 (wrong_type_argument, buffer_overflow, __executable_start)
38 (memory_full, buffer_memory_full, string_overflow, Fthrow)
39 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
40 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
41 (fatal):
42 (child_setup) [!DOS_NT]:
43 * lread.c (end_of_file_error, invalid_syntax):
44 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
45 * puresize.h (pure_write_error):
46 * search.c (matcher_overflow):
47 * sound.c (sound_perror, alsa_sound_perror):
48 * sysdep.c, syssignal.h (croak):
49 * term.c (maybe_fatal, vfatal):
50 * textprop.c (text_read_only):
51 * undo.c (user_error):
52 * unexmacosx.c (unexec_error):
53 * xterm.c (x_ins_del_lines, x_delete_glyphs):
54 Use _Noreturn rather than NO_RETURN.
55 No need for separate decl merely because of _Noreturn.
56 * sound.c (sound_warning, parse_sound):
57 Remove unnecessary forward decls.
58
59 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
60
61 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
62 * lisp.h (WAIT_READING_MAX): New macro.
63 * dispnew.c (Fsleep_for, sit_for):
64 * keyboard.c (kbd_buffer_get_event):
65 * process.c (Faccept_process_output):
66 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
67 This improves on the previous patch, which introduced a bug
68 when time_t is unsigned and as wide as intmax_t.
69 See <http://bugs.gnu.org/9000#51>.
70
71 2012-06-23 Eli Zaretskii <eliz@gnu.org>
72
73 * dispnew.c (sit_for, Fsleep_for):
74 * keyboard.c (kbd_buffer_get_event):
75 * process.c (Faccept_process_output): Avoid compiler warnings when
76 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
77
78 2012-06-23 Juanma Barranquero <lekktu@gmail.com>
79
80 * makefile.w32-in: Update dependencies.
81
82 * w32.c (ltime): Add return type and declare static.
83 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
84
85 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
86
87 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
88 Privately reported by Herbert J. Skuhra.
89 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
90 All uses changed.
91 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
92 not make_lisp_timeval, when the argument is of type EMACS_TIME.
93
94 2012-06-23 Eli Zaretskii <eliz@gnu.org>
95
96 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
97 last argument of make_unibyte_string.
98
99 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
100 language ID in the event parameters.
101
102 * w32term.c (w32_read_socket): Put the new keyboard codepage into
103 event.code, not the obscure "character set ID".
104
105 2012-06-23 Chong Yidong <cyd@gnu.org>
106
107 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
108
109 2012-06-23 Eli Zaretskii <eliz@gnu.org>
110
111 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
112 * w32.c (fdutimens): New function.
113
114 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
115
116 * s/ms-w32.h (pselect): Redirect to sys_select.
117
118 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
119
120 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
121 in the logic of incrementing and decrementing the value of
122 use_relocatable_buffers.
123
124 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
125
126 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
127 Privately reported by Herbert J. Skuhra.
128 [__FreeBSD__]: Remove "*/" typo after "#include".
129 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
130 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
131 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
132 Don't assume EMACS_TIME and struct timeval are the same type.
133
134 2012-06-22 Paul Eggert <eggert@cs.ucla.edu>
135
136 Support higher-resolution time stamps (Bug#9000).
137 The time stamps are only nanosecond-resolution at the C level,
138 since that's the best that any real-world system supports now.
139 But they are picosecond-resolution at the Lisp level, as that's
140 easy, and leaves room for future OS improvements.
141
142 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
143 (LIBES): Use it.
144
145 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
146 Don't get current time unless it's needed.
147
148 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
149 now provides it if it's absent.
150 (start_atimer): Port to higher-res time stamps.
151 Check for time stamp overflow. Don't get current time more
152 often than is needed.
153
154 * buffer.h (struct buffer): Buffer modtime now has high resolution.
155 Include systime.h, not time.h.
156 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
157
158 * dired.c: Include stat-time.h.
159 (Ffile-attributes): File times now have higher resolution.
160
161 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
162 (struct image): Timestamp now has higher resolution.
163
164 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
165 has at least microseconds now. All uses removed.
166 (update_frame, update_single_window, update_window, update_frame_1)
167 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
168
169 * editfns.c (time_overflow): Now extern.
170 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
171 (float-time, Fformat_time_string, Fcurrent_time_string)
172 (Fcurrent_time_zone): Accept and generate higher-resolution
173 time stamps.
174 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
175 (decode_time_components, lisp_seconds_argument): New functions.
176 (make_time): Now static.
177 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
178 Report an error if the time is invalid, rather than having the caller
179 do that.
180
181 * fileio.c: Include <stat-time.h>
182 (Fcopy_file): Copy higher-resolution time stamps.
183 Prefer to set the time stamp via a file descriptor if that works.
184 (Fset_file_times, Finsert_file_contents, Fwrite_region)
185 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
186 (Fvisited_file_modtime, Fset_visited_file_modtime):
187 Support higher-resolution time stamps.
188
189 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
190
191 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
192
193 * image.c (prepare_image_for_display, clear_image_cache)
194 (lookup_image): Port to higer-resolution time stamps.
195
196 * keyboard.c (start_polling, bind_polling_period):
197 Check for time stamp overflow.
198 (read_char, kbd_buffer_get_event, timer_start_idle)
199 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
200 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
201 Port to higher-resolution time stamps. Do not assume time_t is signed.
202 (decode_timer): New function. Timers are now vectors of length 9,
203 not 8, to accommodate the picosecond component.
204 (timer_check_2): Use it.
205
206 * nsterm.m (select_timeout, timeval_subtract): Remove.
207 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
208 as they're a bit more accurate and handle overflow better.
209 (ns_select): Change prototype to be compatible with pselect.
210 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
211 * nsterm.h (ns_select): Adjust prototype.
212
213 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
214 us-resolution time stamps.
215 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
216
217 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
218
219 * lisp.h (time_overflow): New decl.
220 (wait_reading_process_output): First arg is now intmax_t, not int,
221 to accommodate larger waits.
222
223 * process.h (struct Lisp_Process.read_output_delay):
224 Now counts nanoseconds, not microseconds.
225 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
226 EMACS_HAS_USECS.
227 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
228 (wait_reading_process_output):
229 Port to ns-resolution time stamps.
230 (Faccept_process_output, wait_reading_process_output):
231 Check for time stamp overflow. Do not assume time_t is signed.
232 (select_wrapper): Remove; we now use pselect.
233 (Fprocess_attributes): Now generates ns-resolution time stamps.
234
235 * sysdep.c: Include utimens.h. Don't include utime.h
236 or worry about struct utimbuf; gnulib does that for us now.
237 (gettimeofday): Remove; gnulib provides a substitute.
238 (make_timeval): New function.
239 (set_file_times): Now sets ns-resolution time stamps.
240 New arg FD; all uses changed.
241 (time_from_jiffies, ltime_from_jiffies, get_up_time)
242 (system_process_attributes):
243 Now returns ns-resolution time stamp. All uses changed.
244 Check for time stamp overflow.
245
246 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
247 provides a substitute now.
248
249 * systime.h: Include timespec.h rather than sys/time.h and time.h,
250 since it guarantees struct timespec.
251 (EMACS_TIME): Now struct timespec, so that we can support
252 ns-resolution time stamps.
253 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
254 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
255 (EMACS_USECS): Remove.
256 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
257 so multiply the arg by 1000 before storing it.
258 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
259 New macros.
260 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
261 Port to ns-resolution time stamps.
262 (EMACS_TIME_NEG_P): Remove; replaced by....
263 (EMACS_TIME_SIGN): New macro.
264 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
265 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
266 (set_file_times, make_time, lisp_time_argument): Adjust signature.
267 (make_timeval, make_lisp_time, decode_time_components): New decls.
268 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
269 that it mishandled time_t overflow. You can't compare by subtracting!
270 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
271 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
272
273 * term.c: Include <sys/time.h>.
274 (timeval_to_Time): New function, for proper overflow wraparound.
275 (term_mouse_position, term_mouse_click): Use it.
276
277 * undo.c (record_first_change): Support higher-resolution time stamps
278 in the undo buffer.
279 (Fprimitive_undo): Use them when restoring time stamps.
280
281 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
282 (w32_get_internal_run_time):
283 Port to higher-resolution Emacs time stamps.
284 (ltime): Now accepts single 64-bit integer, as that's more convenient
285 for callers.
286
287 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
288
289 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
290 for compatibility with pselect. Support ns-resolution time stamps.
291
292 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
293
294 * xselect.c (wait_for_property_change, x_get_foreign_selection):
295 Check for time stamp overflow, and support ns-resolution time stamps.
296
297 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
298 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
299 (timeval_subtract): Remove; no longer needed.
300 (XTflash, XTring_bell, x_wait_for_event):
301 Port to ns-resolution time stamps. Don't assume time_t is signed.
302
303 2012-06-22 Chong Yidong <cyd@gnu.org>
304
305 * xdisp.c (x_consider_frame_title): Revert last change.
306
307 2012-06-22 Eli Zaretskii <eliz@gnu.org>
308
309 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
310 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
311 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
312 staticidx goes up to 1597 out of 1600 = 0x640.)
313
314 2012-06-20 Paul Eggert <eggert@cs.ucla.edu>
315
316 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
317 Otherwise, the umask might be mistakenly 0 while handling input signals.
318
319 2012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
320
321 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
322
323 2012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
324
325 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
326 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
327 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
328 access to `contents' member of Lisp_Vector objects with AREF and ASET
329 where appropriate.
330
331 2012-06-19 Chong Yidong <cyd@gnu.org>
332
333 * frame.c (delete_frame): When selecting a frame on a different
334 text terminal, do not alter the terminal's top-frame.
335
336 * xdisp.c (format_mode_line_unwind_data): Record the target
337 frame's selected window and its terminal's top-frame.
338 (unwind_format_mode_line): Restore them.
339 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
340 Callers changed.
341 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
342 since tty frames can be explicitly named.
343 (prepare_menu_bars): Likewise.
344
345 * term.c (Ftty_top_frame): New function.
346
347 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
348
349 Port byte-code-meter to modern targets.
350 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
351 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
352 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
353 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
354 (METER_1, METER_2): Simplify.
355
356 2012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
357
358 * data.c (Fdefalias): Return `symbol' (bug#11686).
359
360 2012-06-18 Martin Rudalics <rudalics@gmx.at>
361
362 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
363 gets killed during executing of this function (Bug#11665).
364 Try to always return Qt when the buffer has been actually killed.
365 (Vkill_buffer_query_functions): In doc-string say that functions
366 run by this hook should not change the current buffer.
367
368 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
369
370 Fix recently-introduced process.c problems found by static checking.
371 * process.c (write_queue_push, write_queue_pop, send_process):
372 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
373 (write_queue_pop): Fix pointer signedness problem.
374 (send_process): Remove unused local.
375
376 2012-06-17 Chong Yidong <cyd@gnu.org>
377
378 * xdisp.c (redisplay_internal): No need to redisplay terminal
379 frames that are not on top.
380
381 2012-06-17 Troels Nielsen <bn.troels@gmail.com>
382
383 * process.c (make_process): Initialize write_queue.
384 (write_queue_push, write_queue_pop): New functions.
385 (send_process): Use them to maintain correct ordering of process
386 writes (Bug#10815).
387
388 2012-06-17 Paul Eggert <eggert@cs.ucla.edu>
389
390 * lisp.h (eassert): Assume C89 or later.
391 This removes the need for CHECK.
392 (CHECK): Remove. Its comments about always evaluating its
393 argument were confusing, as 'eassert' typically does not evaluate
394 its argument.
395
396 * coding.c (produce_chars): Use ptrdiff_t, not int.
397
398 * xterm.c (x_draw_underwave): Check for integer overflow.
399 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
400
401 2012-06-17 Jan Djärv <jan.h.d@swipnet.se>
402
403 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
404 referenced (Bug#11583).
405
406 2012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
407
408 Implement wave-style variant of underlining.
409 * dispextern.h (face_underline_type): New enum.
410 (face): Add field for underline type.
411 * nsterm.m (ns_draw_underwave): New function.
412 (ns_draw_text_decoration): Use it.
413 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
414 New functions.
415 (x_draw_glyph_string): Use them.
416 * xfaces.c (Qline, Qwave): New Lisp objects.
417 (check_lface_attrs, merge_face_ref)
418 (Finternal_set_lisp_face_attribute, realize_x_face):
419 Handle wave-style underline face attributes.
420 * xterm.c (x_draw_underwave): New function.
421 (x_draw_glyph_string): Use it.
422
423 2012-06-16 Juanma Barranquero <lekktu@gmail.com>
424
425 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
426 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
427 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
428 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
429 ($(BLD)/w32select.$(O)): Update dependencies.
430
431 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
432
433 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
434 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
435 * character.c (_fetch_multibyte_char_p): Remove.
436 * alloc.c: Include "character.h" before "buffer.h".
437 * bidi.c: Likewise.
438 * buffer.c: Likewise.
439 * bytecode.c: Likewise.
440 * callint.c: Likewise.
441 * callproc.c: Likewise.
442 * casefiddle.c: Likewise.
443 * casetab.c: Likewise.
444 * category.c: Likewise.
445 * cmds.c: Likewise.
446 * coding.c: Likewise.
447 * composite.c: Likewise.
448 * dired.c: Likewise.
449 * dispnew.c: Likewise.
450 * doc.c: Likewise.
451 * dosfns.c: Likewise.
452 * editfns.c: Likewise.
453 * emacs.c: Likewise.
454 * fileio.c: Likewise.
455 * filelock.c: Likewise.
456 * font.c: Likewise.
457 * fontset.c: Likewise.
458 * fringe.c: Likewise.
459 * indent.c: Likewise.
460 * insdel.c: Likewise.
461 * intervals.c: Likewise.
462 * keyboard.c: Likewise.
463 * keymap.c: Likewise.
464 * lread.c: Likewise.
465 * macros.c: Likewise.
466 * marker.c: Likewise.
467 * minibuf.c: Likewise.
468 * nsfns.m: Likewise.
469 * nsmenu.m: Likewise.
470 * print.c: Likewise.
471 * process.c: Likewise.
472 * regex.c: Likewise.
473 * region-cache.c: Likewise.
474 * search.c: Likewise.
475 * syntax.c: Likewise.
476 * term.c: Likewise.
477 * textprop.c: Likewise.
478 * undo.c: Likewise.
479 * unexsol.c: Likewise.
480 * w16select.c: Likewise.
481 * w32fns.c: Likewise.
482 * w32menu.c: Likewise.
483 * window.c: Likewise.
484 * xdisp.c: Likewise.
485 * xfns.c: Likewise.
486 * xmenu.c: Likewise.
487 * xml.c: Likewise.
488 * xselect.c: Likewise.
489
490 2012-06-16 Eli Zaretskii <eliz@gnu.org>
491
492 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
493 If all the glyphs of the glyph row came from strings, and we have no
494 cursor positioning clues, put the cursor on the first glyph of the
495 row.
496 (handle_face_prop): Use chunk-relative overlay string index when
497 indexing into it->string_overlays array. (Bug#11653)
498 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
499 the rightmost. (Bug#11720)
500
501 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
502
503 * category.h (CHAR_HAS_CATEGORY): Define as inline.
504 (CATEGORY_MEMBER): Enforce 1/0 value.
505 * category.c (_temp_category_set): Remove.
506
507 2012-06-16 Eli Zaretskii <eliz@gnu.org>
508
509 * window.c (Fdelete_other_windows_internal)
510 (Fdelete_window_internal): Don't access frame's mouse highlight
511 info of the initial frame. (Bug#11677)
512
513 2012-06-14 Paul Eggert <eggert@cs.ucla.edu>
514
515 * .gdbinit (xgetint): Fix recently-introduced paren typo.
516 Assume USE_2_TAGS_FOR_INTS.
517 (xreload): Adjust $tagmask width to match recent lisp.h change.
518
519 Simplify lisp.h in minor ways that should not affect code.
520 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
521 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
522 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
523 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
524 (INTTYPEBITS): New macro, for clarity.
525 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
526 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
527 Simplify now that USE_LSB_TAG is always defined.
528 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
529 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
530
531 2012-06-13 Juanma Barranquero <lekktu@gmail.com>
532
533 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
534
535 2012-06-13 Glenn Morris <rgm@gnu.org>
536
537 * s/bsd-common.h (BSD4_3):
538 * s/usg5-4-common.h (USG5_4): No longer define; unused.
539
540 2012-06-13 Andreas Schwab <schwab@linux-m68k.org>
541
542 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
543 instead of union.
544 (XLI, XIL): Define.
545 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
546 Use them.
547 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
548 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
549 * alloc.c (widen_to_Lisp_Object): Remove.
550 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
551 * frame.c (delete_frame): Remove outdated comment.
552 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
553 USE_LISP_UNION_TYPE.
554 (Fw32_unregister_hot_key): Likewise.
555 (Fw32_toggle_lock_key): Likewise.
556 * w32menu.c (add_menu_item): Likewise.
557 (w32_menu_display_help): Use XIL instead of checking
558 USE_LISP_UNION_TYPE.
559 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
560 (init_heap): Likewise.
561 * w32term.c (w32_read_socket): Update comment.
562
563 2012-06-13 Glenn Morris <rgm@gnu.org>
564
565 * s/usg5-4-common.h, src/s/unixware.h:
566 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
567
568 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
569
570 2012-06-13 Paul Eggert <eggert@cs.ucla.edu>
571
572 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
573 * alloc.c (make_number) [!defined make_number]:
574 Remove, as lisp.h always defines this now.
575 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
576 (roundup_size): Verify that it is a power of 2.
577 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
578 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
579 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
580 -DUSE_LSB_TAG=0, to override the automatically-selected default.
581 USE_LSB_TAG now is always defined to be either 0 or 1.
582 All uses changed.
583 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
584 code works fine either way, and efficiency is not a concern here,
585 as the union type is for debugging, not for production.
586 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
587 Use an inline function on all platforms when using the union type,
588 since this is simpler and 'static inline' can be used portably
589 within Emacs now.
590 (LISP_INITIALLY_ZERO): New macro.
591 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
592 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
593
594 2012-06-12 Glenn Morris <rgm@gnu.org>
595
596 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
597
598 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
599
600 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
601 Move BROKEN_SIGIO to configure.
602
603 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
604 Move NO_TERMIO to configure.
605
606 2012-06-12 Chong Yidong <cyd@gnu.org>
607
608 * image.c (imagemagick_load_image): Use MagickFlattenImage if
609 MagickMergeImageLayers is undefined. Use pixel pusher loop if
610 MagickExportImagePixels is undefined.
611
612 2012-06-12 Paul Eggert <eggert@cs.ucla.edu>
613
614 * image.c (imagemagick_load_image): Remove unused label.
615
616 2012-06-11 Glenn Morris <rgm@gnu.org>
617
618 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
619 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
620 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
621 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
622
623 2012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
624
625 * alloc.c (make_byte_code): New function.
626 (Fmake_byte_code): Use it. Don't purify here.
627 * lread.c (read1): Use it as well to avoid extra allocation.
628
629 2012-06-11 Chong Yidong <cyd@gnu.org>
630
631 * image.c (imagemagick_load_image): Implement transparency.
632
633 2012-06-10 Andreas Schwab <schwab@linux-m68k.org>
634
635 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
636 account for preceding backslashes. (Bug#11663)
637
638 2012-06-09 Chong Yidong <cyd@gnu.org>
639
640 * term.c: Support italics in capable terminals (Bug#9652).
641 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
642 (turn_on_face): Output using TS_enter_italic_mode if available.
643 Don't handle unused blinking and alt-charset cases.
644 (turn_off_face): Handle italic case; discard unused tty_blinking_p
645 and tty_alt_charset_p cases.
646 (tty_capable_p, init_tty): Support italics.
647
648 * termchar.h (struct tty_display_info): Add field for italics.
649 Remove unused blink field.
650
651 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
652 Handle slant.
653
654 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
655 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
656 tty_alt_charset_p. Add tty_italic_p.
657
658 2012-06-09 Michael Albinus <michael.albinus@gmx.de>
659
660 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
661 dbus_type_is_basic if available.
662 (xd_extract_signed, xd_extract_unsigned): Rename from
663 extract_signed and extract_unsigned, respectively. Adapt callers.
664
665 2012-06-09 Chong Yidong <cyd@gnu.org>
666
667 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
668
669 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
670 case (Bug#9752).
671
672 2012-06-08 Paul Eggert <eggert@cs.ucla.edu>
673
674 * xdisp.c (vmessage): Treat frame message as multibyte.
675 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
676 would generate the diagnostic "Making \302\247 buffer-local while
677 let-bound!".
678
679 2012-06-08 Eli Zaretskii <eliz@gnu.org>
680
681 * dispnew.c (showing_window_margins_p): Undo last change, which
682 was done due to an inadvertent commit.
683 (adjust_frame_glyphs_for_frame_redisplay): Do call
684 showing_window_margins_p.
685
686 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
687
688 * eval.c (Fmake_var_non_special): New primitive.
689 (syms_of_eval): Defsubr it.
690 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
691
692 2012-06-08 Juanma Barranquero <lekktu@gmail.com>
693
694 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
695 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
696
697 2012-06-08 Eli Zaretskii <eliz@gnu.org>
698
699 * alloc.c (allocate_vectorlike): Fix last change.
700
701 2012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
702
703 Block-based vector allocation of small vectors.
704 * lisp.h (struct vectorlike_header): New field `nbytes',
705 adjust comment accordingly.
706 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
707 to denote vector blocks. Adjust users (live_vector_p,
708 mark_maybe_pointer, valid_lisp_object_p) accordingly.
709 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
710 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
711 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
712 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
713 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
714 (roundup_size): New constant.
715 (struct vector_block): New data type.
716 (vector_blocks, vector_free_lists, zero_vector): New variables.
717 (all_vectors): Rename to `large_vectors'.
718 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
719 (sweep_vectors): New functions.
720 (allocate_vectorlike): Return `zero_vector' as the only vector of
721 0 items. Allocate new vector from block if vector size is less than
722 or equal to VBLOCK_BYTES_MAX.
723 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
724 (init_alloc_once): Add call to init_vectors.
725
726 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
727
728 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
729
730 2012-06-07 Paul Eggert <eggert@cs.ucla.edu>
731
732 * doprnt.c (doprnt): Truncate multibyte char correctly.
733 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
734 would mishandle a string argument "Xc" if X was a multibyte
735 character of length 2: it would truncate after X's first byte
736 rather than including all of X.
737
738 2012-06-06 Chong Yidong <cyd@gnu.org>
739
740 * buffer.c (word_wrap): Doc fix.
741
742 2012-06-04 Paul Eggert <eggert@cs.ucla.edu>
743
744 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
745
746 2012-06-03 Glenn Morris <rgm@gnu.org>
747
748 * xdisp.c (tool-bar-style): Doc fix.
749
750 2012-06-03 Ulrich Müller <ulm@gentoo.org>
751
752 * Makefile.in (PAXCTL): Define.
753 (temacs$(EXEEXT)): Disable memory randomization for the temacs
754 binary via PaX flags if the paxctl utility is available.
755 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
756 Restore PaX flags to their default. (Bug#11398)
757
758 2012-06-03 Chong Yidong <cyd@gnu.org>
759
760 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
761 buffer (Bug#11226).
762
763 2012-06-03 Chong Yidong <cyd@gnu.org>
764
765 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
766 (note_mode_line_or_margin_highlight): If there is no help echo,
767 use mode-line-default-help-echo. Handle the case where the mouse
768 position is past the end of the mode line string.
769
770 * buffer.c (buffer_local_value_1): New function, split from
771 Fbuffer_local_value; can return Qunbound.
772 (Fbuffer_local_value): Use it.
773 (Vmode_line_format): Docstring tweaks.
774
775 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
776
777 * sysdep.c (system_process_attributes): Improve comment.
778
779 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
780
781 * keyboard.c: Export real-this-command to Elisp.
782 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
783 and DEFVAR it. Update all users.
784
785 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
786
787 * minibuf.c (Fassoc_string): Remove duplicate declaration.
788
789 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
790 Convert pctcpu and pctmem to Lisp float properly.
791 Let the compiler fold better, as 100.0/0x8000 is exact.
792
793 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
794
795 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
796 cons_block.
797
798 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
799
800 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
801
802 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
803
804 For a 'struct window', replace some Lisp_Object fields to
805 bitfields where appropriate, remove unused fields.
806 * window.h (struct window): Remove unused 'last_mark_x' and
807 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
808 change it's type from Lisp_Object to bitfield.
809 Change type of 'force_start', 'optional_new_start',
810 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
811 fields from Lisp_Object to bitfield. Adjust users accordingly.
812
813 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
814
815 Pacify gcc -Wdouble-precision when using Xaw.
816 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
817 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
818 Use 'float' consistently, rather than 'float' in most places
819 and 'double' in a couple of places.
820
821 2012-05-31 Eli Zaretskii <eliz@gnu.org>
822
823 * xdisp.c (handle_stop): Detect whether we have overlay strings
824 loaded by testing it->current.overlay_string_index to be
825 non-negative, instead of checking whether n_overlay_strings is
826 positive. (Bug#11587)
827
828 2012-05-31 Chong Yidong <cyd@gnu.org>
829
830 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
831
832 * doc.c (Fsubstitute_command_keys): Doc fix.
833
834 2012-05-31 Eli Zaretskii <eliz@gnu.org>
835
836 * search.c (search_buffer): Remove calls to
837 r_alloc_inhibit_buffer_relocation, as it is now called by
838 maybe_unify_char, which was the cause of relocation of buffer text
839 in bug#11519.
840
841 2012-05-31 Eli Zaretskii <eliz@gnu.org>
842
843 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
844 for the duration of call to load_charset, to avoid problems with
845 callers of maybe_unify_char that access buffer text through C
846 pointers.
847
848 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
849 decrement the inhibition flag, instead of just setting or
850 resetting it.
851
852 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
853
854 Remove obsolete '#define static' cruft.
855 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
856 This #undef was "temporary" in 2000; it is no longer needed
857 now that '#define static' has gone away.
858 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
859 (gray_bitmap_bits): Remove; no longer needed.
860 All uses replaced with definiens.
861 * xterm.c: Include "bitmaps/gray.xbm".
862
863 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
864
865 Clean up __executable_start, monstartup when --enable-profiling.
866 The following changes affect the code only when profiling.
867 * dispnew.c (__executable_start): Rename from safe_bcopy.
868 Define only on platforms that need it.
869 * emacs.c: Include <sys/gmon.h> when profiling.
870 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
871 (__executable_start): Remove decl, since lisp.h does it now.
872 (safe_bcopy): Remove decl; no longer has that name.
873 (main): Coalesce #if into single bit of code, for simplicity.
874 Cast pointers to uintptr_t, since standard libraries want integers
875 and not pointers.
876 * lisp.h (__executable_start): New decl.
877
878 2012-05-31 Glenn Morris <rgm@gnu.org>
879
880 * image.c (Fimagemagick_types): Doc fix.
881
882 2012-05-30 Jim Meyering <meyering@redhat.com>
883
884 * callproc.c (Fcall_process_region): Include directory component
885 in mkstemp error message (Bug#11586).
886
887 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
888
889 * alloc.c, lisp.h (make_pure_vector): Now static.
890
891 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
892
893 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
894 Move to byte-run.el.
895 (Fautoload): Do the hash-doc more carefully.
896 * data.c (Fdefalias): Purify definition, except for keymaps.
897 (Qdefun): Move from eval.c.
898 * lisp.h (Qdefun): Remove.
899 * lread.c (read1): Tiny simplification.
900
901 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
902
903 Do not create empty overlays with the evaporate property (Bug#9642).
904 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
905 Bug#9642, but explicitly check that the buffer the overlay would
906 be moved to is live and rearrange lines to make sure that errors
907 will not put the overlay in an inconsistent state.
908 (Fdelete_overlay): Cosmetics.
909
910 2012-05-28 Eli Zaretskii <eliz@gnu.org>
911
912 * w32term.c (my_bring_window_to_top): New function.
913 (x_raise_frame): Use handle returned by DeferWindowPos, which
914 could be different from the original one.
915 Call my_bring_window_to_top instead of my_set_foreground_window.
916 (Bug#11513)
917
918 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
919 by calling BringWindowToTop.
920
921 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
922 (WM_EMACS_END): Increase by one.
923
924 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
925
926 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
927 This avoids undefined behavior that might cause the eassert
928 to not catch an out-of-range value.
929
930 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
931
932 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
933 Update dependencies.
934
935 2012-05-27 Eli Zaretskii <eliz@gnu.org>
936
937 * bidi.c (bidi_mirror_char): Fix last change.
938
939 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
940
941 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
942 when referring to sectname field in printf format.
943
944 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
945
946 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
947 Only r_alloc_inhibit_buffer_relocation needed to be added;
948 the others were already declared.
949
950 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
951 before checking whether it's out of range. Put the check inside
952 eassert. See
953 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
954
955 2012-05-27 Ken Brown <kbrown@cornell.edu>
956
957 * callproc.c (Fcall_process): Restore a line that was accidentally
958 commented out in the 2011-02-13 change (bug#11547).
959
960 2012-05-27 Eli Zaretskii <eliz@gnu.org>
961
962 * lisp.h [REL_ALLOC]: Add prototypes for external functions
963 defined on ralloc.c.
964
965 * buffer.c [REL_ALLOC]: Remove prototypes of
966 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
967 they are now on lisp.h.
968
969 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
970
971 * search.c (search_buffer): Use it to inhibit relocation of buffer
972 text while re_search_2 is doing its job, because re_search_2 is
973 passed C pointers to buffer text. (Bug#11519)
974
975 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
976 Update value to 24.
977
978 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
979 state after an additional call to move_it_in_display_line_to, keep
980 the values of it->max_ascent and it->max_descent found for the
981 entire line.
982 (pos_visible_p): Revert the comparison against bottom_y to what it
983 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
984 (Bug#11464)
985
986 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
987
988 Fix coding-related core dumps with gcc -ftrapv.
989 The code was computing A - B, where A and B are pointers, and B is
990 random garbage. This can lead to core dumps on platforms that
991 have special pointer registers, and it also leads to core dumps on
992 x86-64 when compiled with gcc -ftrapv. The fix is to compute
993 A - B only when B is initialized properly.
994 * coding.c (coding_set_source, coding_set_destination): Return void.
995 (coding_change_source, coding_change_destinations): New functions,
996 with the old behaviors of coding_set_source and coding_set_destination.
997 All callers that need an offset changed to use these new functions.
998
999 2012-05-26 Glenn Morris <rgm@gnu.org>
1000
1001 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
1002
1003 2012-05-26 Eli Zaretskii <eliz@gnu.org>
1004
1005 Extend mouse support on W32 text-mode console.
1006 * xdisp.c (draw_row_with_mouse_face):
1007 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
1008
1009 * w32console.c: Include window.h.
1010 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
1011 New functions.
1012 (initialize_w32_display): Initialize mouse-highlight data.
1013
1014 * w32inevt.c: Include termchar.h and window.h.
1015 (do_mouse_event): Support mouse-autoselect-window. When the mouse
1016 moves, call note_mouse_highlight. If help_echo changed, call
1017 gen_help_event to produce help-echo message in the echo area.
1018 Call clear_mouse_face if mouse_face_hidden is set in the mouse
1019 highlight info.
1020
1021 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1022
1023 * lread.c (read1): Simplify slightly to avoid an overflow warning
1024 with GCC 4.7.0 on x86-64.
1025
1026 2012-05-26 Eli Zaretskii <eliz@gnu.org>
1027
1028 * bidi.c (bidi_mirror_char): Revert last change: an int is
1029 definitely wide enough here.
1030
1031 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
1032
1033 Fix integer width and related bugs (Bug#9874).
1034 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
1035 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
1036 (string_bytes, check_sblock, allocate_string_data):
1037 (compact_small_strings, Fmake_bool_vector, make_string)
1038 (make_unibyte_string, make_multibyte_string)
1039 (make_string_from_bytes, make_specified_string)
1040 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
1041 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
1042 (mark_vectorlike):
1043 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1044 (allocate_pseudovector):
1045 Use int, not EMACS_INT, where int is wide enough.
1046 (inhibit_garbage_collection, Fgarbage_collect):
1047 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1048 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
1049 int might not be wide enough.
1050 (bidi_cache_search, bidi_cache_find, bidi_init_it)
1051 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
1052 (bidi_at_paragraph_end, bidi_find_paragraph_start)
1053 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1054 (bidi_level_of_next_char, bidi_move_to_visually_next):
1055 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1056 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
1057 (Fkill_buffer, Fset_buffer_major_mode)
1058 (advance_to_char_boundary, Fbuffer_swap_text)
1059 (Fset_buffer_multibyte, overlays_at, overlays_in)
1060 (overlay_touches_p, struct sortvec, record_overlay_string)
1061 (overlay_strings, recenter_overlay_lists)
1062 (adjust_overlays_for_insert, adjust_overlays_for_delete)
1063 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
1064 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
1065 (Foverlay_recenter, last_overlay_modification_hooks_used)
1066 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
1067 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1068 (validate_region): Omit unnecessary test for b <= e,
1069 since that's guaranteed by the previous test.
1070 (adjust_overlays_for_delete): Avoid pos + length overflow.
1071 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
1072 (report_overlay_modification):
1073 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1074 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
1075 Omit pointer cast, which isn't needed anyway, and doesn't work
1076 after the EMACS_INT -> ptrdiff_t change.
1077 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
1078 * buffer.h: Adjust decls to match defn changes elsewhere.
1079 (struct buffer_text, struct buffer):
1080 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1081 Use EMACS_INT, not int, where int might not be wide enough.
1082 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
1083 not int, to avoid needless 32-bit limit on 64-bit hosts.
1084 (exec_byte_code): Use tighter memory-full test, one that checks
1085 for alloca overflow. Don't compute the address of the object just
1086 before an array, as that's not portable. Use EMACS_INT, not
1087 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
1088 * callint.c (Fcall_interactively):
1089 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1090 * callproc.c (call_process_kill, Fcall_process):
1091 Don't assume pid_t fits into an Emacs fixnum.
1092 (call_process_cleanup, Fcall_process, child_setup):
1093 Don't assume pid_t fits into int.
1094 (call_process_cleanup, Fcall_process, delete_temp_file)
1095 (Fcall_process_region):
1096 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1097 (Fcall_process): Simplify handling of volatile integers.
1098 Use int, not EMACS_INT, where int will do.
1099 * casefiddle.c (casify_object, casify_region, operate_on_word)
1100 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
1101 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1102 (casify_object): Avoid integer overflow when overallocating buffer.
1103 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
1104 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
1105 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
1106 * category.h (CATEGORYP): Don't assume arg is nonnegative.
1107 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
1108 integers are now checked earlier. All uses replaced with XINT.
1109 (ccl_driver):
1110 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1111 For CCL_MapSingle, check that content and value are in int range.
1112 (ccl_driver, Fregister_code_conversion_map):
1113 Check that Vcode_version_map_vector is a vector.
1114 (resolve_symbol_ccl_program): Check that vector header is in range.
1115 Always copy the vector, so that we can check its contents reliably
1116 now rather than having to recheck each instruction as it's being
1117 executed. Check that vector words fit in 'int'.
1118 (ccl_get_compiled_code, Fregister_ccl_program)
1119 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
1120 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
1121 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
1122 contents are in range.
1123 (Fccl_execute_on_string): Check that status is in range.
1124 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
1125 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
1126 Accept and return EMACS_INT, not int, because callers can pass values
1127 out of 'int' range.
1128 (c_string_width, strwidth, lisp_string_width, chars_in_text)
1129 (multibyte_chars_in_text, parse_str_as_multibyte)
1130 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
1131 (str_as_unibyte, str_to_unibyte, string_count_byte8)
1132 (string_escape_byte8, Fget_byte):
1133 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1134 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
1135 avoid mishandling large integers.
1136 * character.h: Adjust decls to match defn changes elsewhere.
1137 * charset.c (load_charset_map_from_file, find_charsets_in_text)
1138 (Ffind_charset_region):
1139 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1140 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
1141 (load_charset_map_from_vector, Fdefine_charset_internal):
1142 Don't assume fixnum fits in int.
1143 (load_charset_map_from_vector, Fmap_charset_chars):
1144 Remove now-unnecessary CHECK_NATNUMs.
1145 (Fdefine_charset_internal): Check ranges here, more carefully.
1146 Don't rely on undefined behavior with signed left shift overflow.
1147 Don't assume unsigned int fits into fixnum, or that fixnum fits
1148 into unsigned int. Don't require max_code to be a valid fixnum;
1149 that's not true for gb10830 4-byte on a 32-bit host. Allow
1150 invalid_code to be a cons, for the same reason. Require code_offset
1151 to be a character. Avoid int overflow if max_char is close
1152 to INT_MAX.
1153 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
1154 this is intended anyway and avoids some undefined behavior.
1155 (load_charset_map): Pass unsigned, not int, as 2nd arg of
1156 INDEX_TO_CODE_POINT, as that's what it expects.
1157 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
1158 * charset.h (DECODE_CHAR): Return int, not unsigned;
1159 this is what was intended anyway, and it avoids undefined behavior.
1160 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
1161 integer-overflow issues.
1162 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
1163 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
1164 where the argument is EMACS_INT, and this behavior is not intended.
1165 * chartab.c (Fmake_char_table, Fset_char_table_range)
1166 (uniprop_get_decoder, uniprop_get_encoder):
1167 Don't assume fixnum fits in int.
1168 * cmds.c (move_point): New function, that does the gist of
1169 Fforward_char and Fbackward_char, but does so while checking
1170 for integer overflow more accurately.
1171 (Fforward_char, Fbackward_char): Use it.
1172 (Fforward_line, Fend_of_line, internal_self_insert)
1173 (internal_self_insert):
1174 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1175 Fix a FIXME, by checking for integer overflow when calculating
1176 target_clm and actual_clm.
1177 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
1178 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
1179 (ASSURE_DESTINATION, coding_alloc_by_realloc)
1180 (coding_alloc_by_making_gap, alloc_destination)
1181 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
1182 (encode_coding_utf_16, detect_coding_emacs_mule)
1183 (decode_coding_emacs_mule, encode_coding_emacs_mule)
1184 (detect_coding_iso_2022, decode_coding_iso_2022)
1185 (encode_invocation_designation, encode_designation_at_bol)
1186 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1187 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
1188 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
1189 (encode_coding_ccl, encode_coding_raw_text)
1190 (detect_coding_charset, decode_coding_charset)
1191 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
1192 (produce_composition, produce_charset, produce_annotation)
1193 (decode_coding, handle_composition_annotation)
1194 (handle_charset_annotation, consume_chars, decode_coding_gap)
1195 (decode_coding_object, encode_coding_object, detect_coding_system)
1196 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
1197 (code_convert_region, code_convert_string)
1198 (Fdefine_coding_system_internal)
1199 (coding_set_source, coding_set_destination):
1200 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1201 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
1202 (Fdefine_coding_system_internal):
1203 Don't assume fixnums fit in int.
1204 (decode_coding_gap, decode_coding_object, encode_coding_object)
1205 (Fread_coding_system, Fdetect_coding_region)
1206 (Funencodable_char_position, Fcheck_coding_systems_region)
1207 (get_translation, handle_composition_annotation, consume_chars):
1208 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1209 (consume_chars): Rewrite to not calculate an address outside buffer.
1210 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
1211 Don't access memory outside of the args array.
1212 (Fdefine_coding_system_internal): Check for charset-id overflow.
1213 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
1214 result of ENCODE_CHAR.
1215 * coding.h: Adjust decls to match defn changes elsewhere.
1216 (struct coding_system):
1217 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1218 * composite.c (get_composition_id, find_composition)
1219 (run_composition_function, update_compositions)
1220 (compose_text, composition_gstring_put_cache)
1221 (composition_gstring_p, composition_gstring_width)
1222 (fill_gstring_header, fill_gstring_body, autocmp_chars)
1223 (composition_compute_stop_pos, composition_reseat_it)
1224 (composition_update_it, struct position_record)
1225 (find_automatic_composition, composition_adjust_point)
1226 (Fcomposition_get_gstring, Ffind_composition_internal):
1227 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1228 (update_compositions):
1229 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1230 * composite.h: Adjust decls to match defn changes elsewhere.
1231 (struct composition):
1232 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1233 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
1234 Do not attempt to compute the address of the object just before a
1235 buffer; this is not portable.
1236 (Faref, Faset):
1237 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1238 (Faset): Use int, not EMACS_INT, where int is wide enough.
1239 (Fstring_to_number): Don't assume fixnums fit in int.
1240 (Frem): Don't assume arg is nonnegative.
1241 * dbusbind.c (xd_append_arg): Check for integers out of range.
1242 (Fdbus_call_method): Don't overflow the timeout int.
1243 (extract_signed, extract_unsigned): New functions.
1244 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
1245 (xd_get_connection_references): Return ptrdiff_t, not int.
1246 All uses changed.
1247 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
1248 (xd_read_message_1):
1249 Use int, not unsigned, where the dbus API uses int.
1250 (Fdbus_message_internal): Don't overflow mtype.
1251 (syms_of_dbusbind): Allocate right-sized buffer for integers.
1252 * dired.c (directory_files_internal, file_name_completion, scmp)
1253 (file_name_completion_stat):
1254 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1255 (file_name_completion): Don't overflow matchcount.
1256 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
1257 * dispextern.h: Adjust decls to match defn changes elsewhere.
1258 (struct text_pos, struct glyph, struct bidi_saved_info)
1259 (struct bidi_string_data, struct bidi_it, struct composition_it)
1260 (struct it):
1261 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1262 (struct display_pos, struct composition_it, struct it):
1263 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1264 * dispnew.c (increment_matrix_positions)
1265 (increment_row_positions, mode_line_string)
1266 (marginal_area_string):
1267 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1268 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
1269 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1270 (duration_to_sec_usec): New function, to check for overflow better.
1271 (Fsleep_for, sit_for): Use it.
1272 * doc.c (get_doc_string, store_function_docstring):
1273 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1274 (get_doc_string, Fsnarf_documentation):
1275 Use int, not EMACS_INT, where int is wide enough.
1276 (get_doc_string):
1277 Use SAFE_ALLOCA, not alloca.
1278 Check for overflow when converting EMACS_INT to off_t.
1279 * doprnt.c (doprnt):
1280 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1281 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
1282 Don't assume uid_t fits into fixnum.
1283 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
1284 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
1285 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
1286 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
1287 (general_insert_function)
1288 (Finsert_char, make_buffer_string, make_buffer_string_both)
1289 (update_buffer_properties, Fbuffer_substring)
1290 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
1291 (Fsubst_char_in_region, check_translation)
1292 (Ftranslate_region_internal, save_restriction_restore, Fformat)
1293 (transpose_markers, Ftranspose_regions):
1294 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1295 (clip_to_bounds): Move to lisp.h as an inline function).
1296 (Fconstrain_to_field): Don't assume integers are nonnegative.
1297 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
1298 (Fsubst_char_in_region, Fsave_restriction):
1299 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1300 (Femacs_pid): Don't assume pid_t fits into fixnum.
1301 (lo_time): Use int, not EMACS_INT, when int suffices.
1302 (lisp_time_argument): Check for usec out of range.
1303 (Fencode_time): Don't assume fixnum fits in int.
1304 (Fuser_login_name, Fuser_full_name): Signal an error
1305 if a uid argument is out of range, rather than relying on
1306 undefined behavior.
1307 (Fformat_time_string): Remove now-unnecessary check.
1308 lisp_time_argument checks for out-of-range usec now.
1309 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
1310 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
1311 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
1312 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
1313 (init_cmdargs, Fdump_emacs):
1314 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1315 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
1316 the bottom (typically) 32 bits of the fixnum.
1317 * eval.c (specpdl_size, call_debugger):
1318 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1319 (when_entered_debugger, Fbacktrace_debug):
1320 Don't assume fixnum can fit in int.
1321 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
1322 the object just before a buffer; this is not portable.
1323 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
1324 (grow_specpdl, unbind_to):
1325 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1326 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
1327 (grow_specpdl): Simplify allocation by using xpalloc.
1328 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
1329 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
1330 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
1331 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1332 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
1333 (a_write, e_write):
1334 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1335 (Fcopy_file, non_regular_nbytes, read_non_regular)
1336 (Finsert_file_contents):
1337 Use int, not EMACS_INT, where int is wide enough.
1338 (READ_BUF_SIZE): Verify that it fits in int.
1339 (Finsert_file_contents): Check that counts are in proper range,
1340 rather than assuming fixnums fit into ptrdiff_t etc.
1341 Don't assume fixnums fit into int.
1342 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
1343 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
1344 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
1345 (string_char_to_byte, string_byte_to_char)
1346 (string_make_multibyte, string_to_multibyte)
1347 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
1348 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
1349 (substring_both, Fdelete, internal_equal, Ffillarray)
1350 (Fclear_string, mapcar1)
1351 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
1352 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
1353 (larger_vector, make_hash_table, maybe_resize_hash_table)
1354 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
1355 (Fmaphash, secure_hash):
1356 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1357 (concat): Check for string index and length overflow.
1358 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
1359 (Frequire):
1360 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1361 (larger_vector): New API (vec, incr_min, size_max) replaces old
1362 one (vec, new_size, init). This catches size overflow.
1363 INIT was removed because it was always Qnil.
1364 All callers changed.
1365 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
1366 the upper bound on a hash table index size.
1367 (make_hash_table, maybe_resize_hash_table): Use it.
1368 (secure_hash): Computer start_byte and end_byte only after
1369 they're known to be in ptrdiff_t range.
1370 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
1371 (Ffont_get_glyphs, Ffont_at):
1372 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1373 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
1374 (Flist_fonts, Fopen_font):
1375 Don't assume fixnum can fit in int.
1376 (check_gstring): Don't assume index can fit in int.
1377 (font_match_p): Check that fixnum is a character, not a nonnegative
1378 fixnum, since the later code needs to stuff it into an int.
1379 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
1380 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
1381 conversion overflow issues.
1382 (Fopen_font): Check for integer out of range.
1383 (Ffont_get_glyphs): Don't assume index can fit in int.
1384 * font.h: Adjust decls to match defn changes elsewhere.
1385 * fontset.c (reorder_font_vector): Redo score calculation to avoid
1386 integer overflow.
1387 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
1388 printmax_t, where ptrdiff_t is wide enough.
1389 (Finternal_char_font):
1390 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1391 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
1392 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
1393 (Fset_frame_position, x_set_frame_parameters)
1394 (x_set_line_spacing, x_set_border_width)
1395 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
1396 Check that fixnums are in proper range for system types.
1397 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
1398 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1399 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
1400 Use SAFE_ALLOCA_LISP, not alloca.
1401 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
1402 intptr_t is wide enough.
1403 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
1404 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
1405 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
1406 Check for fixnum out of range.
1407 * ftfont.c (ftfont_list): Don't assume index fits in int.
1408 Check that fixnums are in proper range for system types.
1409 (ftfont_shape_by_flt):
1410 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1411 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1412 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1413 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
1414 Check that fixnums are in proper range for system types.
1415 * gnutls.h: Adjust decls to match defn changes elsewhere.
1416 * gtkutil.c (xg_dialog_run):
1417 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1418 (update_frame_tool_bar):
1419 Check that fixnums are in proper range for system types.
1420 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
1421 (lookup_image): Check that fixnums are in range for system types.
1422 * indent.c (last_known_column, last_known_column_point):
1423 (current_column_bol_cache):
1424 (skip_invisible, current_column, check_display_width):
1425 (check_display_width, scan_for_column, current_column_1)
1426 (Findent_to, Fcurrent_indentation, position_indentation)
1427 (indented_beyond_p, Fmove_to_column, compute_motion):
1428 (Fcompute_motion, Fvertical_motion):
1429 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1430 (last_known_column_modified): Use EMACS_INT, not int.
1431 (check_display_width):
1432 (Fcompute_motion):
1433 Check that fixnums and floats are in proper range for system types.
1434 (compute_motion): Don't assume index or fixnum fits in int.
1435 (compute_motion, Fcompute_motion):
1436 Use int, not EMACS_INT, when it is wide enough.
1437 (vmotion): Omit local var start_hpos that is always 0; that way
1438 we don't need to worry about overflow in expressions involving it.
1439 * indent.h: Adjust decls to match defn changes elsewhere.
1440 (struct position):
1441 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1442 Use int, not EMACS_INT, where int is wide enough.
1443 Remove unused members ovstring_chars_done and tab_offset;
1444 all uses removed.
1445 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
1446 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
1447 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
1448 (make_gap, copy_text, insert, insert_and_inherit)
1449 (insert_before_markers, insert_before_markers_and_inherit)
1450 (insert_1, count_combining_before, count_combining_after)
1451 (insert_1_both, insert_from_string)
1452 (insert_from_string_before_markers, insert_from_string_1)
1453 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
1454 (adjust_after_replace, adjust_after_insert, replace_range)
1455 (replace_range_2, del_range, del_range_1, del_range_byte)
1456 (del_range_both, del_range_2, modify_region)
1457 (prepare_to_modify_buffer, signal_before_change)
1458 (signal_after_change, Fcombine_after_change_execute):
1459 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1460 * intervals.c (traverse_intervals, rotate_right, rotate_left)
1461 (balance_an_interval, split_interval_right, split_interval_left)
1462 (find_interval, next_interval, update_interval)
1463 (adjust_intervals_for_insertion, delete_node, delete_interval)
1464 (interval_deletion_adjustment, adjust_intervals_for_deletion)
1465 (static_offset_intervals, offset_intervals)
1466 (merge_interval_right, merge_interval_left, make_new_interval)
1467 (graft_intervals_into_buffer, temp_set_point_both)
1468 (temp_set_point, set_point, adjust_for_invis_intang)
1469 (set_point_both, move_if_not_intangible, get_property_and_range)
1470 (get_local_map, copy_intervals, copy_intervals_to_string)
1471 (compare_string_intervals, set_intervals_multibyte_1):
1472 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1473 * intervals.h: Adjust decls to match defn changes elsewhere.
1474 (struct interval):
1475 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1476 * keyboard.c (this_command_key_count, this_single_command_key_start)
1477 (before_command_key_count, before_command_echo_length, echo_now)
1478 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
1479 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
1480 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
1481 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
1482 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1483 (last_non_minibuf_size, last_point_position, echo_truncate)
1484 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
1485 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
1486 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
1487 (stuff_buffered_input):
1488 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1489 (last_auto_save, command_loop_1, read_char):
1490 Use EMACS_INT, not int, to avoid integer overflow.
1491 (record_char): Avoid overflow in total_keys computation.
1492 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
1493 * keyboard.h: Adjust decls to match defn changes elsewhere.
1494 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
1495 (Fkey_description, Fdescribe_vector, Flookup_key):
1496 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1497 (click_position): New function, to check that positions are in range.
1498 (Fcurrent_active_maps):
1499 (describe_command):
1500 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1501 (Faccessible_keymaps, Fkey_description):
1502 (preferred_sequence_p):
1503 Don't assume fixnum can fit into int.
1504 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
1505 Check for integer overflow in size calculations.
1506 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
1507 avoid mishandling large integers.
1508 * lisp.h: Adjust decls to match defn changes elsewhere.
1509 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
1510 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
1511 (struct Lisp_Marker):
1512 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1513 (clip_to_bounds): Now an inline function, moved here from editfns.c.
1514 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
1515 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
1516 All callers changed.
1517 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
1518 Assume the arg has valid form, since it always does.
1519 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
1520 unsigned integer system type.
1521 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
1522 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
1523 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1524 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
1525 (duration_to_sec_usec): New decl.
1526 * lread.c (read_from_string_index, read_from_string_index_byte)
1527 (read_from_string_limit, readchar, unreadchar, openp)
1528 (read_internal_start, read1, oblookup):
1529 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1530 (Fload, readevalloop, Feval_buffer, Feval_region):
1531 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1532 (openp): Check for out-of-range argument to 'access'.
1533 (read1): Use int, not EMACS_INT, where int is wide enough.
1534 Don't assume fixnum fits into int.
1535 Fix off-by-one error that can read outside a buffer.
1536 (read_filtered_event): Use duration_to_sec_usec
1537 to do proper overflow checking on durations.
1538 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
1539 in size calculation.
1540 (Fexecute_kbd_macro):
1541 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1542 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
1543 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
1544 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
1545 (set_marker_both, set_marker_restricted_both, marker_position)
1546 (marker_byte_position, Fbuffer_has_markers_at):
1547 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1548 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
1549 * menu.c (ensure_menu_items): Rename from grow_menu_items.
1550 It now merely ensures that the menu is large enough, without
1551 necessarily growing it, as this avoids some integer overflow issues.
1552 All callers changed.
1553 (keymap_panes, parse_single_submenu, Fx_popup_menu):
1554 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1555 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
1556 Use SAFE_ALLOCA_LISP, not alloca.
1557 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
1558 to EMACS_INT. Check that fixnums are in proper range for system types.
1559 * minibuf.c (minibuf_prompt_width, string_to_object)
1560 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
1561 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
1562 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1563 (get_minibuffer, read_minibuf_unwind):
1564 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1565 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
1566 this simplifies overflow checking. All callers changed.
1567 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
1568 (Ftest_completion):
1569 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1570 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
1571 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
1572 Check that fixnums are in proper range for system types.
1573 (Fx_create_frame, Fx_show_tip):
1574 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1575 * nsfont.m (ns_findfonts, nsfont_list_family):
1576 Don't assume fixnum fits in long.
1577 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
1578 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1579 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
1580 wide enough.
1581 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
1582 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1583 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
1584 (PRINTDECLARE, PRINTPREPARE):
1585 (strout, print_string):
1586 (print, print_preprocess, print_check_string_charset_prop)
1587 (print_object):
1588 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1589 (PRINTDECLARE):
1590 (temp_output_buffer_setup, Fprin1_to_string, print_object):
1591 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1592 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
1593 (printchar, strout): Use xpalloc to catch size calculation overflow.
1594 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
1595 (print_error_message): Use SAFE_ALLOCA, not alloca.
1596 (print_object): Use int, not EMACS_INT, where int is wide enough.
1597 (print_depth, new_backquote_output, print_number_index):
1598 Use ptrdiff_t, not int, where int might not be wide enough.
1599 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
1600 (Fset_process_window_size, Fformat_network_address)
1601 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
1602 (sigchld_handler):
1603 Check that fixnums are in proper range for system types.
1604 (Fsignal_process): Simplify by avoiding a goto.
1605 Check for process-ids out of pid_t range rather than relying on
1606 undefined behavior.
1607 (process_tick, update_tick): Use EMACS_INT, not int.
1608 (Fformat_network_address, read_process_output, send_process)
1609 (Fprocess_send_region, status_notify):
1610 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1611 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
1612 (wait_reading_process_output, read_process_output, exec_sentinel):
1613 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1614 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
1615 (Faccept_process_output): Use duration_to_sec_usec to do proper
1616 overflow checking on durations.
1617 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
1618 Don't assume pid_t fits in int.
1619 * process.h (struct Lisp_Process): Members tick and update_tick
1620 are now of type EMACS_INT, not int.
1621 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
1622 configured --with-wide-int.
1623 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
1624 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
1625 * search.c (looking_at_1, string_match_1):
1626 (fast_string_match, fast_c_string_match_ignore_case)
1627 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
1628 (scan_newline, find_before_next_newline, search_command)
1629 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
1630 (set_search_regs, wordify):
1631 (Freplace_match):
1632 (Fmatch_data):
1633 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1634 (string_match_1, search_buffer, set_search_regs):
1635 (Fmatch_data):
1636 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1637 (wordify): Check for overflow in size calculation.
1638 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
1639 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
1640 Check that fixnums are in proper range for system types.
1641 * sound.c (struct sound_device)
1642 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
1643 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1644 (Fplay_sound_internal):
1645 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1646 * syntax.c (struct lisp_parse_state, find_start_modiff)
1647 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
1648 (Fparse_partial_sexp):
1649 Don't assume fixnums can fit in int.
1650 (struct lisp_parse_state, find_start_pos, find_start_value)
1651 (find_start_value_byte, find_start_begv)
1652 (update_syntax_table, char_quoted, dec_bytepos)
1653 (find_defun_start, prev_char_comend_first, back_comment):
1654 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
1655 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
1656 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1657 (Finternal_describe_syntax_value): Check that match_lisp is a
1658 character, not an integer, since the code stuffs it into int.
1659 (scan_words, scan_sexps_forward):
1660 Check that fixnums are in proper range for system types.
1661 (Fforward_word):
1662 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1663 (scan_sexps_forward):
1664 Use CHARACTERP, not INTEGERP, since the value must fit into int.
1665 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
1666 * syntax.h: Adjust decls to match defn changes elsewhere.
1667 (struct gl_state_s):
1668 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1669 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
1670 MOST_POSITIVE_FIXNUM.
1671 * sysdep.c (wait_for_termination_1, wait_for_termination)
1672 (interruptible_wait_for_termination, mkdir):
1673 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
1674 (emacs_read, emacs_write):
1675 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1676 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
1677 and double all fit in int.
1678 * term.c (set_tty_color_mode):
1679 Check that fixnums are in proper range for system types.
1680 * termhooks.h (struct input_event):
1681 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1682 * textprop.c (validate_interval_range, interval_of)
1683 (Fadd_text_properties, set_text_properties_1)
1684 (Fremove_text_properties, Fremove_list_of_text_properties)
1685 (Ftext_property_any, Ftext_property_not_all)
1686 (copy_text_properties, text_property_list, extend_property_ranges)
1687 (verify_interval_modification):
1688 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1689 (Fnext_single_char_property_change)
1690 (Fprevious_single_char_property_change):
1691 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1692 (copy_text_properties):
1693 Check for integer overflow in index calculation.
1694 * undo.c (last_boundary_position, record_point, record_insert)
1695 (record_delete, record_marker_adjustment, record_change)
1696 (record_property_change):
1697 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1698 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
1699 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1700 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1701 (Fx_hide_tip, Fx_file_dialog):
1702 * w32menu.c (set_frame_menubar):
1703 Use ptrdiff_t, not int, for consistency with rest of code.
1704 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
1705 (select_window, Fdelete_other_windows_internal)
1706 (window_scroll_pixel_based, window_scroll_line_based)
1707 (Frecenter, Fset_window_configuration):
1708 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1709 (Fset_window_hscroll, run_window_configuration_change_hook)
1710 (set_window_buffer, temp_output_buffer_show, scroll_command)
1711 (Fscroll_other_window, Frecenter):
1712 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1713 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
1714 Don't assume fixnum fits in int.
1715 (Fset_window_scroll_bars):
1716 Check that fixnums are in proper range for system types.
1717 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
1718 (string_pos, c_string_pos, number_of_chars, init_iterator)
1719 (in_ellipses_for_invisible_text_p, init_from_display_pos)
1720 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
1721 (compute_display_string_end, handle_face_prop)
1722 (face_before_or_after_it_pos, handle_invisible_prop)
1723 (handle_display_prop, handle_display_spec, handle_single_display_spec)
1724 (display_prop_intangible_p, string_buffer_position_lim)
1725 (string_buffer_position, handle_composition_prop, load_overlay_strings)
1726 (get_overlay_strings_1, get_overlay_strings)
1727 (iterate_out_of_display_property, forward_to_next_line_start)
1728 (back_to_previous_visible_line_start, reseat, reseat_to_string)
1729 (get_next_display_element, set_iterator_to_next)
1730 (get_visually_first_element, compute_stop_pos_backwards)
1731 (handle_stop_backwards, next_element_from_buffer)
1732 (move_it_in_display_line_to, move_it_in_display_line)
1733 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1734 (add_to_log, message_dolog, message_log_check_duplicate)
1735 (message2, message2_nolog, message3, message3_nolog
1736 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
1737 (current_message_1, truncate_echo_area, truncate_message_1)
1738 (set_message, set_message_1, store_mode_line_noprop)
1739 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
1740 (text_outside_line_unchanged_p, check_point_in_composition)
1741 (reconsider_clip_changes)
1742 (redisplay_internal, set_cursor_from_row, try_scrolling)
1743 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
1744 (redisplay_window, find_last_unchanged_at_beg_row)
1745 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
1746 (trailing_whitespace_p, find_row_edges, display_line)
1747 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
1748 (display_mode_element, store_mode_line_string)
1749 (pint2str, pint2hrstr, decode_mode_spec)
1750 (display_count_lines, display_string, draw_glyphs)
1751 (x_produce_glyphs, x_insert_glyphs)
1752 (rows_from_pos_range, mouse_face_from_buffer_pos)
1753 (fast_find_string_pos, mouse_face_from_string_pos)
1754 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1755 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1756 (safe_call, init_from_display_pos, handle_fontified_prop)
1757 (handle_single_display_spec, load_overlay_strings)
1758 (with_echo_area_buffer, setup_echo_area_for_printing)
1759 (display_echo_area, echo_area_display)
1760 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
1761 (update_tool_bar, hscroll_window_tree, redisplay_internal)
1762 (redisplay_window, dump_glyph_row, display_mode_line)
1763 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
1764 (handle_display_spec, display_prop_string_p):
1765 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1766 (handle_single_display_spec, build_desired_tool_bar_string)
1767 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
1768 (get_specified_cursor_type):
1769 Check that fixnums are in proper range for system types.
1770 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
1771 (Flookup_image_map):
1772 Don't assume fixnums fit in int.
1773 (compare_overlay_entries):
1774 Avoid mishandling comparisons due to subtraction overflow.
1775 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
1776 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
1777 (handle_tool_bar_click):
1778 Use int, not unsigned, since we prefer signed and the signedness
1779 doesn't matter here.
1780 (get_next_display_element, next_element_from_display_vector):
1781 Use int, not EMACS_INT, when int is wide enough.
1782 (start_hourglass): Use duration_to_sec_usec to do proper
1783 overflow checking on durations.
1784 * xfaces.c (Fbitmap_spec_p):
1785 Check that fixnums are in proper range for system types.
1786 (compare_fonts_by_sort_order):
1787 Avoid mishandling comparisons due to subtraction overflow.
1788 (Fx_family_fonts, realize_basic_faces):
1789 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1790 (Fx_family_fonts):
1791 Don't assume fixnum fits in int.
1792 Use SAFE_ALLOCA_LISP, not alloca.
1793 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
1794 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
1795 (face_at_buffer_position, face_for_overlay_string)
1796 (face_at_string_position):
1797 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1798 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
1799 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
1800 (Fx_show_tip):
1801 Check that fixnums are in proper range for system types.
1802 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1803 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
1804 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1805 (Fx_change_window_property): Don't assume fixnums fit in int.
1806 * xfont.c (xfont_chars_supported):
1807 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1808 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
1809 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
1810 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1811 * xml.c (parse_region):
1812 * xrdb.c (magic_file_p):
1813 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1814 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
1815 (x_get_local_selection, x_reply_selection_request)
1816 (x_handle_selection_request, wait_for_property_change):
1817 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1818 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
1819 short is wide enough.
1820 (x_send_client_event): Don't assume fixnum fits in int.
1821 * xterm.c (x_x_to_emacs_modifiers):
1822 Don't assume EMACS_INT overflows nicely into int.
1823 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
1824 may come from Lisp.
1825 (handle_one_xevent): NATNUMP can eval its arg twice.
1826 (x_connection_closed):
1827 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1828 * xterm.h: Adjust decls to match defn changes elsewhere.
1829 (struct scroll_bar): Use struct vectorlike_header
1830 rather than rolling our own approximation.
1831 (SCROLL_BAR_VEC_SIZE): Remove; not used.
1832
1833 2012-05-25 Glenn Morris <rgm@gnu.org>
1834
1835 * lisp.mk (lisp): Update for more files being compiled now.
1836
1837 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
1838
1839 * lread.c: Remove `read_pure' which makes no difference.
1840 (read_pure): Remove var.
1841 (unreadpure): Remove function.
1842 (readevalloop): Don't call read_list with -1 flag.
1843 (read1, read_vector): Don't test read_pure any more.
1844 (read_list): Simplify.
1845
1846 * fileio.c, character.h: Minor style tweaks.
1847
1848 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
1849
1850 * window.h (clip_changed): Remove useless declaration.
1851
1852 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
1853
1854 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
1855 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
1856
1857 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
1858
1859 Remove src/m/*.
1860 This directory predates autoconf and is no longer needed nowadays.
1861 Move its few remaining bits of functionality to where they're needed.
1862 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
1863 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
1864 * m/template.h: Remove.
1865 * Makefile.in (M_FILE): Remove. All uses removed.
1866 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
1867 * lisp.h (USE_LSB_TAG):
1868 * mem-limits.h (EXCEEDS_LISP_PTR):
1869 Use VAL_MAX, not VALBITS, in #if.
1870 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
1871 (EMACS_UINT): Define unconditionally now.
1872 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
1873 (BITS_PER_EMACS_INT): New constants, replacing
1874 what used to be in config.h, but not useful in #if.
1875 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
1876 define them any more.
1877 (VAL_MAX): New macro.
1878 (VALMASK): Use it.
1879 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
1880 BITS_PER_EMACS_INT, in #if.
1881 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
1882 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
1883 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
1884 * s/ms-w32.h (DATA_START):
1885 Move here from removed file m/intel386.h.
1886 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
1887 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
1888
1889 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
1890
1891 Assume C89 or later.
1892 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
1893 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
1894 (xrealloc):
1895 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
1896 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
1897 * textprop.c, tparam.c (NULL): Remove.
1898 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
1899 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
1900 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
1901 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
1902 * xterm.c (input_signal_count): Assume volatile works.
1903
1904 2012-05-21 Ken Brown <kbrown@cornell.edu>
1905
1906 * xgselect.c (xg_select): Fix first argument in call to 'select'
1907 (bug#11508).
1908
1909 2012-05-20 Ken Brown <kbrown@cornell.edu>
1910
1911 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
1912 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1913
1914 2012-05-19 Ken Brown <kbrown@cornell.edu>
1915
1916 * xfns.c (x_in_use): Remove `static' qualifier.
1917 * xterm.h (x_in_use): Declare.
1918 * xgselect.c: Include xterm.h.
1919 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
1920 and `display_arg' (bug#9754).
1921
1922 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
1923
1924 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
1925
1926 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
1927 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
1928
1929 2012-05-18 Eli Zaretskii <eliz@gnu.org>
1930
1931 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
1932
1933 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
1934 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
1935
1936 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
1937 reference to image_cache->refcount.
1938 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
1939
1940 2012-05-17 Juri Linkov <juri@jurta.org>
1941
1942 * search.c (Fword_search_regexp, Fword_search_backward)
1943 (Fword_search_forward, Fword_search_backward_lax)
1944 (Fword_search_forward_lax): Move functions to isearch.el
1945 (bug#10145, bug#11381).
1946
1947 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
1948
1949 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
1950
1951 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
1952
1953 * lread.c (init_obarray): Declare Qt and Qnil as special.
1954
1955 2012-05-14 Glenn Morris <rgm@gnu.org>
1956
1957 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
1958 Put "libexec" before "bin", for the sake of init_callproc_1.
1959
1960 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1961
1962 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
1963
1964 * unexaix.c: Port to more-recent AIX compilers.
1965 (report_error, report_error_1, make_hdr, copy_sym)
1966 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
1967 Make arguments const char *, not char *, to avoid violations of C
1968 standard and to fix some AIX warnings reported by Gilles Pion.
1969
1970 2012-05-14 Eli Zaretskii <eliz@gnu.org>
1971
1972 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
1973 already have overlays loaded.
1974 (handle_single_display_spec): Before returning without displaying
1975 fringe bitmap, synchronize the bidi iterator with the main display
1976 iterator, by calling iterate_out_of_display_property.
1977 (iterate_out_of_display_property): Detect buffer iteration by
1978 testing that it->string is a Lisp string.
1979 (get_next_display_element): When the current object is exhausted,
1980 and there's something on it->stack, call set_iterator_to_next to
1981 proceed with what's on the stack, instead of returning zero.
1982 (set_iterator_to_next): If called at the end of a Lisp string,
1983 proceed to consider_string_end without incrementing string
1984 position. Don't increment display vector index past the end of
1985 the display vector. (Bug#11417)
1986 (pos_visible_p): Don't report a position visible when move_it_to
1987 stopped at the last line of window, which happens to be scanned
1988 backwards by the bidi iteration. (Bug#11464)
1989
1990 2012-05-14 Eli Zaretskii <eliz@gnu.org>
1991
1992 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
1993 and right-margin display specs even if the spec is invalid or we
1994 are on a TTY, and thus unable to display on the fringes.
1995 That's because the text with the property will not be displayed anyway,
1996 so we need to signal to the caller that this is a "replacing"
1997 display spec. This fixes display when the spec is invalid or we
1998 are on a TTY.
1999
2000 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2001
2002 * unexaix.c (make_hdr): Fix typo in prototype.
2003 This bug broke the build on AIX. Problem reported by Gilles Pion.
2004
2005 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
2006
2007 * keyboard.c (kbd_buffer_get_event): Read special events also in
2008 batch mode. (Bug#11415)
2009
2010 2012-05-12 Glenn Morris <rgm@gnu.org>
2011
2012 * ns.mk: Update for ns_appbindir no longer having trailing "/".
2013
2014 2012-05-12 Eli Zaretskii <eliz@gnu.org>
2015
2016 * lisp.mk (lisp): Add newcomment.elc.
2017
2018 2012-05-12 Glenn Morris <rgm@gnu.org>
2019
2020 * Makefile.in (MKDIR_P): New, set by configure.
2021 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
2022
2023 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
2024
2025 Remove unused function hourglass_started.
2026 * dispextern.h (hourglass_started):
2027 * w32fns.c (hourglass_started):
2028 * xdisp.c (hourglass_started): Remove.
2029
2030 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
2031
2032 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
2033 Update dependencies.
2034
2035 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
2036
2037 * xgselect.c (xg_select): Put maxfds+1 into a var.
2038 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
2039
2040 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
2041
2042 2012-05-10 Dave Abrahams <dave@boostpro.com>
2043
2044 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
2045 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
2046
2047 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
2048
2049 * dbusbind.c (xd_registered_buses): New internal Lisp object.
2050 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
2051 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
2052 Initialize xd_registered_buses.
2053
2054 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
2055
2056 Untag more efficiently if USE_LSB_TAG.
2057 This is based on a proposal by YAMAMOTO Mitsuharu in
2058 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
2059 For an admittedly artificial (nth 8000 longlist) benchmark on
2060 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
2061 Emacs's overall text size by 1%.
2062 * lisp.h (XUNTAG): New macro.
2063 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
2064 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
2065 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
2066 * eval.c (Fautoload):
2067 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
2068 * frame.h (XFRAME): Use XUNTAG.
2069
2070 Port recent dbusbind.c changes to 32-bit --with-wide-int.
2071 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
2072 Remove unportable assumptions about print widths of types like
2073 dbus_uint32_t.
2074 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
2075 intptr_t when converting between pointer and integer, to avoid GCC
2076 warnings about wrong width.
2077
2078 2012-05-09 Eli Zaretskii <eliz@gnu.org>
2079
2080 * w32proc.c (new_child): Force Windows to reserve only 64KB of
2081 stack for each reader_thread, instead of defaulting to 8MB
2082 determined by the linker. This avoids failures in creating
2083 subprocesses on Windows 7, see the discussion in this thread:
2084 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
2085
2086 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
2087
2088 Fix up display of the *Minibuf-0* buffer in the mini window.
2089 * keyboard.c (read_char): Don't clear the echo area if there's no
2090 message to clear.
2091 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2092 contents of *Minibuf-0*) if there's no message displayed in its stead.
2093
2094 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
2095
2096 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
2097 batch mode.
2098
2099 2012-05-06 Chong Yidong <cyd@gnu.org>
2100
2101 * lisp.mk (lisp): Update.
2102
2103 2012-05-05 Jim Meyering <meyering@redhat.com>
2104
2105 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
2106
2107 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
2108
2109 * data.c (PUT_ERROR): New macro.
2110 (syms_of_data): Use it. Add new error type `user-error'.
2111 * undo.c (user_error): New function.
2112 (Fprimitive_undo): Use it.
2113 * print.c (print_error_message): Adjust print style for `user-error'.
2114 * keyboard.c (user_error): New function.
2115 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
2116
2117 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
2118
2119 Do not limit current-time-string to years 1000..9999.
2120 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
2121 (Fcurrent_time_string): Support any year that is supported by the
2122 underlying localtime representation. Don't use asctime, as it
2123 has undefined behavior for years outside the range -999..9999.
2124
2125 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
2126
2127 Fix race conditions involving setenv, gmtime, localtime, asctime.
2128 Without this fix, interrupts could mess up code that uses these
2129 nonreentrant functions, since setting TZ invalidates existing
2130 tm_zone or tzname values, and since most of these functions return
2131 pointers to static storage.
2132 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
2133 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
2134 Grow the critical sections to include not just invoking
2135 localtime/gmtime, but also accessing these functions' results
2136 including their tm_zone values if any, and any related TZ setting.
2137 (format_time_string): Last arg is now struct tm *, not struct tm **,
2138 so that the struct tm is saved in the critical section.
2139 All callers changed. Simplify allocation of initial buffer, partly
2140 motivated by the fact that memory allocation needs to be outside
2141 the critical section.
2142
2143 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
2144
2145 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
2146 with RESET_INTERVAL.
2147
2148 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2149 Remove duplicated buffer name initialization.
2150
2151 2012-05-02 Jim Meyering <jim@meyering.net>
2152
2153 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
2154
2155 * xfns.c (x_window): Use xstrdup (Bug#11375).
2156
2157 2012-05-02 Eli Zaretskii <eliz@gnu.org>
2158
2159 * xdisp.c (pos_visible_p): If already at a newline from the
2160 display string before the 'while' loop, don't walk back the glyphs
2161 from it3.glyph_row. Solves assertion violation when the display
2162 string begins with a newline (egg.el). (Bug#11367)
2163
2164 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
2165
2166 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
2167 Move to simple.el.
2168
2169 2012-05-01 Glenn Morris <rgm@gnu.org>
2170
2171 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
2172 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
2173 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
2174 All were removed before 23.1.
2175
2176 * dispnew.c: Remove HAVE_LIBNCURSES test;
2177 it is always true on relevant platforms.
2178
2179 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
2180 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
2181
2182 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
2183
2184 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
2185
2186 * .gdbinit (xpr): Remove checks for no longer existing misc types.
2187 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
2188 Remove.
2189
2190 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
2191
2192 Do not avoid creating empty evaporating overlays (Bug#9642).
2193 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
2194 That is, do not delete an evaporating overlay if it becomes
2195 empty after its bounds are adjusted to fit within its buffer.
2196 This fix caused other problems, and I'm reverting it until we get
2197 to the bottom of them.
2198
2199 2012-04-27 Chong Yidong <cyd@gnu.org>
2200
2201 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
2202
2203 2012-04-27 Eli Zaretskii <eliz@gnu.org>
2204
2205 * xdisp.c (pos_visible_p): If the window start position is beyond
2206 ZV, start the display from buffer beginning. Prevents assertion
2207 violation in init_iterator when the minibuffer window is scrolled
2208 via the scroll bar.
2209
2210 * window.c (window_scroll_pixel_based): Likewise.
2211
2212 2012-04-27 Chong Yidong <cyd@gnu.org>
2213
2214 * keymap.c (where_is_internal): Doc fix (Bug#10872).
2215
2216 2012-04-27 Glenn Morris <rgm@gnu.org>
2217
2218 * fileio.c (Fcopy_file, Fset_file_selinux_context):
2219 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
2220
2221 2012-04-27 Eli Zaretskii <eliz@gnu.org>
2222
2223 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
2224 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
2225
2226 2012-04-26 Eli Zaretskii <eliz@gnu.org>
2227
2228 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
2229 display element, check also the underlying string or buffer
2230 character. (Bug#11341)
2231
2232 * w32menu.c: Include w32heap.h.
2233 (add_menu_item): If the call to AppendMenuW (via
2234 unicode_append_menu) fails, disable Unicode menus only if we are
2235 running on Windows 9X/Me.
2236
2237 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
2238
2239 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
2240 (xgetint): Add missing shift for LSB tags.
2241
2242 2012-04-24 Martin Rudalics <rudalics@gmx.at>
2243
2244 * keyboard.c (read_char): Don't wipe echo area for select window
2245 events: These might get delayed via `mouse-autoselect-window'
2246 (Bug#11304).
2247
2248 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
2249
2250 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
2251 manipulation of :loaded-from data.
2252
2253 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
2254
2255 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
2256 now a cons (bug#11311).
2257
2258 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
2259
2260 Do not create empty overlays with the evaporate property (Bug#9642).
2261 * buffer.c (Fmove_overlay): Delete an evaporating overlay
2262 if it becomes empty after its bounds are adjusted to fit within
2263 its buffer. Without this fix, in a nonempty buffer (let ((o
2264 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
2265 yields an empty overlay that has the evaporate property, which is
2266 not supposed to happen.
2267
2268 Fix minor GTK3 problems found by static checking.
2269 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2270 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2271 (struct _EmacsFixedClass, emacs_fixed_get_type):
2272 Move decls here from emacsgtkfixed.h, since they needn't be public.
2273 (emacs_fixed_get_type): Now static.
2274 (emacs_fixed_class_init): Omit unused local.
2275 (emacs_fixed_child_type): Remove; unused.
2276 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2277 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2278 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
2279 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
2280 (EMACS_FIXED_GET_CLASS): Remove; unused.
2281 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
2282
2283 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
2284 Problem reported by Juanma Barranquero for Windows -Wunused-function.
2285
2286 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2287
2288 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
2289 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
2290 (__malloc_size_t, __malloc_ptrdiff_t):
2291 Remove. All uses removed, replaced by the definiens if needed,
2292 since we can assume C89 or better now.
2293 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
2294 (protect_malloc_state, align, get_contiguous_space)
2295 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
2296 (malloc_atfork_handler_child, malloc_enable_thread)
2297 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
2298 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
2299 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
2300 (special_realloc, _realloc_internal_nolock, _realloc_internal)
2301 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
2302 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
2303 Define using prototypes, not old style.
2304 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
2305 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
2306 (align): Don't assume that signed integer overflow wraps around.
2307 Omit unused local var.
2308 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
2309 (_free_internal_nolock, memalign, mallochook, reallochook):
2310 Omit no-longer-needed casts.
2311 (valloc): Use getpagesize, not __getpagesize.
2312 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
2313 (struct hdr): The 'magic' member is now size_t, not unsigned long.
2314
2315 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
2316
2317 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
2318
2319 Move functions from C to Lisp. Make non-blocking method calls
2320 the default. Implement further D-Bus standard interfaces.
2321
2322 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
2323 (QCdbus_request_name_allow_replacement)
2324 (QCdbus_request_name_replace_existing)
2325 (QCdbus_request_name_do_not_queue)
2326 (QCdbus_request_name_reply_primary_owner)
2327 (QCdbus_request_name_reply_in_queue)
2328 (QCdbus_request_name_reply_exists)
2329 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
2330 (QCdbus_registered_serial, QCdbus_registered_method)
2331 (QCdbus_registered_signal): New Lisp objects.
2332 (XD_DEBUG_MESSAGE): Use sizeof.
2333 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
2334 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
2335 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
2336 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
2337 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
2338 (xd_signature, xd_append_arg): Allow float for integer types.
2339 (xd_get_connection_references): New function.
2340 (xd_get_connection_address): Rename from xd_initialize.
2341 Return cached address.
2342 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
2343 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
2344 level.
2345 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
2346 Return number of refcounts.
2347 (Fdbus_get_unique_name): Make stronger parameter check.
2348 (Fdbus_message_internal): New defun.
2349 (Fdbus_call_method, Fdbus_call_method_asynchronously)
2350 (Fdbus_method_return_internal, Fdbus_method_error_internal)
2351 (Fdbus_send_signal, Fdbus_register_service)
2352 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
2353 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
2354 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
2355 (Vdbus_compiled_version, Vdbus_runtime_version)
2356 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
2357 (Vdbus_message_type_method_return, Vdbus_message_type_error)
2358 (Vdbus_message_type_signal): New defvars.
2359 (Vdbus_registered_buses, Vdbus_registered_objects_table):
2360 Adapt docstring.
2361
2362 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2363
2364 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
2365 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
2366 Do not assume ptrdiff_t is the same width as 'int'.
2367
2368 * alloc.c: Handle unusual debugging option combinations.
2369 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
2370 since the two debugging options are incompatible.
2371 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
2372 is defined.
2373 (mem_init, mem_insert, mem_insert_fixup):
2374 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
2375 (NEED_MEM_INSERT): Remove; no longer needed.
2376
2377 2012-04-22 Leo Liu <sdl.web@gmail.com>
2378
2379 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
2380
2381 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2382
2383 * sysdep.c [__FreeBSD__]: Minor cleanups.
2384 (list_system_processes, system_process_attributes) [__FreeBSD__]:
2385 Use Emacs indenting style more consistently. Avoid some casts.
2386 Use 'double' consistently rather than mixing 'float' and 'double'.
2387
2388 2012-04-21 Eduard Wiebe <usenet@pusto.de>
2389
2390 * sysdep.c (list_system_processes, system_process_attributes):
2391 Add implementation for FreeBSD (Bug#5243).
2392
2393 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
2394
2395 * lisp.mk (lisp): Update.
2396
2397 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
2398
2399 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
2400 It is never used otherwise.
2401
2402 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
2403
2404 * print.c (print_preprocess): Only check print_depth if print-circle
2405 is nil.
2406 (print_object): Check for cycles even when print-circle is nil and
2407 print-gensym is t, but only check print_depth if print-circle is nil.
2408
2409 2012-04-20 Chong Yidong <cyd@gnu.org>
2410
2411 * process.c (wait_reading_process_output): If EIO occurs on a pty,
2412 set the status to "failed" and ensure that sentinel is run.
2413
2414 2012-04-20 Glenn Morris <rgm@gnu.org>
2415
2416 * process.c (Fset_process_inherit_coding_system_flag)
2417 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
2418 (Fmake_network_process, Fmake_serial_process): Doc fix.
2419
2420 2012-04-20 Eli Zaretskii <eliz@gnu.org>
2421
2422 * xdisp.c (string_buffer_position_lim): Limit starting position to
2423 BEGV.
2424 (set_cursor_from_row): If called for a mode-line or header-line
2425 row, return zero immediately.
2426 (try_cursor_movement): If inside continuation line, don't back up
2427 farther than the first row after the header line, if any.
2428 Don't consider the header-line row as "partially visible", even if
2429 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
2430
2431 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
2432
2433 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
2434 (bug#11238).
2435
2436 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
2437 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
2438
2439 configure: new option --enable-gcc-warnings (Bug#11207)
2440 * Makefile.in (C_WARNINGS_SWITCH): Remove.
2441 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
2442 (ALL_CFLAGS): Use new macros rather than old.
2443 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
2444 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
2445 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
2446 -Wunused-result, -Wunused-variable. This should go away once
2447 the Emacs and Gnulib regex code is merged.
2448 (xmalloc, xrealloc): Now static.
2449
2450 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
2451
2452 * dired.c (Fsystem_groups): Remove unused local.
2453
2454 2012-04-17 Glenn Morris <rgm@gnu.org>
2455
2456 * dired.c (Fsystem_users): Doc fix.
2457
2458 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
2459
2460 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
2461 (syms_of_dired): Add them.
2462
2463 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
2464
2465 Fix minor alloc.c problems found by static checking.
2466 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
2467 New extern decls, to avoid calling undeclared functions.
2468 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
2469 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
2470 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
2471 (NEED_MEM_INSERT): New macro.
2472 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
2473 Remove one incorrect comment and fix another.
2474
2475 Fix minor ralloc.c problems found by static checking.
2476 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2477 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
2478 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
2479 (r_alloc_sbrk): Now static.
2480
2481 Improve ralloc.c interface checking.
2482 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2483 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
2484 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
2485 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
2486 [REL_ALLOC]: ... to here, to check interface.
2487 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
2488 Remove decls. This fixes an "It stinks!".
2489
2490 * alloc.c (which_symbols): Fix alignment issue / type clash.
2491
2492 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
2493
2494 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
2495 (struct Lisp_Misc_Any): Likewise.
2496 (struct Lisp_Free): Likewise.
2497 * alloc.c (union aligned_Lisp_Symbol): Define.
2498 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
2499 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
2500 (union aligned_Lisp_Misc): Define.
2501 (MARKER_BLOCK_SIZE, struct marker_block): Use union
2502 aligned_Lisp_Misc instead of union Lisp_Misc.
2503 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
2504
2505 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
2506
2507 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
2508 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
2509 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
2510 * s/netbsd.h, s/sol2-6.h:
2511 Remove definition of GC_MARK_STACK, since the default now works.
2512 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
2513 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
2514 no longer the default.
2515 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
2516
2517 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
2518
2519 * lread.c (lisp_file_lexically_bound_p):
2520 Fix hang at ";-*-\n" (bug#11238).
2521
2522 2012-04-14 Eli Zaretskii <eliz@gnu.org>
2523
2524 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
2525 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
2526
2527 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
2528
2529 * nsterm.m (constrainFrameRect): Always constrain when there is only
2530 one screen (Bug#10962).
2531
2532 2012-04-13 Ken Brown <kbrown@cornell.edu>
2533
2534 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
2535
2536 2012-04-13 Reuben Thomas <rrt@sc3d.org>
2537
2538 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
2539
2540 2012-04-11 Daniel Colascione <dancol@dancol.org>
2541
2542 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
2543 against is gone. It's better to use vfork now so that when Cygwin
2544 gains a new, working vfork, we use it automatically (bug#10398).
2545
2546 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2547
2548 * window.c (save_window_save): Obey window-point-insertion-type.
2549
2550 2012-04-11 Glenn Morris <rgm@gnu.org>
2551
2552 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
2553
2554 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2555
2556 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
2557
2558 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
2559
2560 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
2561 (force_quit_count): New var.
2562 (handle_interrupt): Use it.
2563
2564 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
2565
2566 * w32.c (w32_delayed_load): Record the full path of the library
2567 being loaded (bug#10424).
2568
2569 2012-04-09 Glenn Morris <rgm@gnu.org>
2570
2571 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
2572 not just in the obarray, before snarfing them. (Bug#11036)
2573
2574 * Makefile.in ($(leimdir)/leim-list.el):
2575 Pass EMACS rather than BUILT_EMACS.
2576
2577 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
2578
2579 * process.c (make_process):
2580 * process.h: Add integer `gnutls_handshakes_tried' member to
2581 process struct.
2582
2583 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
2584 Add convenience `GNUTLS_LOG2i' macro.
2585
2586 * gnutls.c (gnutls_log_function2i): Convenience log function.
2587 (emacs_gnutls_read): Use new log functions,
2588 `gnutls_handshakes_tried' process member, and
2589 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
2590 attempts per process (connection).
2591
2592 2012-04-09 Chong Yidong <cyd@gnu.org>
2593
2594 * eval.c (Fuser_variable_p, user_variable_p_eh)
2595 (lisp_indirect_variable): Functions deleted.
2596 (Fdefvar): Caller changed.
2597
2598 * callint.c (Finteractive, Fcall_interactively):
2599 * minibuf.c (Fread_variable): Callers changed.
2600
2601 2012-04-09 Eli Zaretskii <eliz@gnu.org>
2602
2603 * xdisp.c (set_cursor_from_row): If the display string appears in
2604 the buffer at position that is closer to point than the position
2605 after the display string, display the cursor on the first glyph of
2606 the display string. Fixes cursor display when a 'display' text
2607 property immediately follows invisible text. (Bug#11094)
2608
2609 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
2610
2611 composite.c: use 'double' consistently
2612 * composite.c (get_composition_id): Use 'double' consistently
2613 instead of converting 'float' to 'double' and vice versa; this is
2614 easier to understand and avoids a GCC warning.
2615
2616 2012-04-09 Glenn Morris <rgm@gnu.org>
2617
2618 * Makefile.in: Generate leim-list with bootstrap-emacs, in
2619 preparation for dumping it with emacs. (Bug#4789)
2620 (leimdir): New variable.
2621 ($(leimdir)/leim-list.el): New rule.
2622 (emacs$(EXEEXT)): Depend on leim-list.el.
2623
2624 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
2625 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
2626 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
2627
2628 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
2629
2630 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
2631 proper alignment.
2632
2633 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
2634
2635 * xml.c (init_libxml2_functions) [WINDOWSNT]:
2636 Remove unused local variable.
2637
2638 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2639
2640 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
2641 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
2642 (mark_memory): Mark Lisp_Objects only if pointers might hide in
2643 objects, as mark_maybe_pointer will catch them otherwise.
2644 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
2645 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
2646
2647 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2648
2649 Fix typo that broke non-Windows builds.
2650 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
2651
2652 2012-04-07 Eli Zaretskii <eliz@gnu.org>
2653
2654 Support building on MS-Windows with libxml2.
2655
2656 * makefile.w32-in (OBJ2): Add xml.$(O).
2657 (GLOBAL_SOURCES): Add xml.c.
2658 ($(BLD)/xml.$(O)): New dependency list.
2659
2660 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
2661 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
2662 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
2663 [!WINDOWSNT]: New macros.
2664 (init_libxml2_functions, libxml2_loaded_p): New functions.
2665 (parse_region): Call fn_xmlCheckVersion instead of using the macro
2666 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
2667 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
2668 Calls xmlCleanupParser only if libxml2 was loaded (or statically
2669 linked in).
2670 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
2671 Call init_libxml2_functions before calling libxml2 functions.
2672 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
2673
2674 * emacs.c: Don't include libxml/parser.h.
2675 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
2676 xmlCleanupParser directly.
2677
2678 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
2679
2680 2012-04-07 Eli Zaretskii <eliz@gnu.org>
2681
2682 * indent.c (Fvertical_motion): If there is a display string at
2683 point, use it.vpos to compute how many lines to backtrack after
2684 move_it_to point. (Bug#11133)
2685
2686 2012-04-06 Eli Zaretskii <eliz@gnu.org>
2687
2688 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
2689 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
2690 about subtle differences between FETCH_CHAR* and STRING_CHAR*
2691 macros related to unification of CJK characters. For the details,
2692 see the discussion following the message here:
2693 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
2694
2695 2012-04-04 Chong Yidong <cyd@gnu.org>
2696
2697 * keyboard.c (Vdelayed_warnings_list): Doc fix.
2698
2699 2012-04-01 Eli Zaretskii <eliz@gnu.org>
2700
2701 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
2702 instead of alloca. (Bug#11138)
2703
2704 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
2705
2706 * w32menu.c (is_simple_dialog): Properly check lisp types.
2707 (Bug#11141)
2708
2709 2012-03-31 Eli Zaretskii <eliz@gnu.org>
2710
2711 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
2712 position we get to after a call to move_it_to fails the
2713 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
2714 only if we wind up in a string from display property. (Bug#11063)
2715
2716 * window.c (Fdelete_other_windows_internal): Invalidate the row
2717 and column information about mouse highlight, so that redisplay
2718 restores it after reallocating the glyph matrices. (Bug#7464)
2719
2720 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
2721 string comes from a `display' text property, use the buffer
2722 position of that property as if we actually saw that position in
2723 the row's glyphs.
2724 (move_it_by_lines): Remove the assertion that
2725 "it->current_x == 0 && it->hpos == 0" which can be legitimately
2726 violated when there's a before-string at the beginning of a line.
2727 (Bug#11063)
2728
2729 2012-03-30 Eli Zaretskii <eliz@gnu.org>
2730
2731 * xdisp.c (append_space_for_newline): If the default face was
2732 remapped, use the remapped face for the appended newline.
2733 (extend_face_to_end_of_line): Use the remapped default face for
2734 extending the face to the end of the line.
2735 (display_line): Call extend_face_to_end_of_line when the default
2736 face was remapped. (Bug#11068)
2737
2738 2012-03-29 Eli Zaretskii <eliz@gnu.org>
2739
2740 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
2741
2742 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2743
2744 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
2745
2746 2012-03-27 Glenn Morris <rgm@gnu.org>
2747
2748 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
2749 Doc fixes.
2750
2751 2012-03-26 Kenichi Handa <handa@m17n.org>
2752
2753 * dispextern.h (struct glyph): Fix previous change. Change the
2754 bit length of glyphless.ch to 25 (Bug#11082).
2755
2756 2012-03-26 Chong Yidong <cyd@gnu.org>
2757
2758 * keyboard.c (Vselection_inhibit_update_commands): New variable.
2759 (command_loop_1): Use it; inhibit selection update for
2760 handle-select-window too (Bug#8996).
2761
2762 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
2763
2764 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
2765
2766 2012-03-25 Kenichi Handa <handa@m17n.org>
2767
2768 * dispextern.h (struct glyph): Change the bit length of
2769 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
2770
2771 2012-03-24 Eli Zaretskii <eliz@gnu.org>
2772
2773 * s/ms-w32.h (tzname): Include time.h before redirecting to
2774 _tzname. Fixes the MSVC build. (Bug#9960)
2775
2776 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
2777
2778 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
2779 characters.
2780
2781 * xterm.c (XTread_socket): Only modify handling_signal if
2782 !SYNC_INPUT. (Bug#11080)
2783
2784 2012-03-23 Eli Zaretskii <eliz@gnu.org>
2785
2786 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
2787 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
2788 when fetching a multibyte character consumes more bytes than
2789 CHAR_BYTES returns, due to unification of CJK characters in
2790 string_char. (Bug#11073)
2791
2792 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
2793
2794 * process.c (wait_reading_process_output): Handle pty disconnect
2795 by refraining from sending oneself a SIGCHLD (bug#10933).
2796
2797 2012-03-22 Chong Yidong <cyd@gnu.org>
2798
2799 * dispextern.h (struct it): New member string_from_prefix_prop_p.
2800
2801 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
2802 Mark string as coming from a prefix property.
2803 (handle_face_prop): Use default face for prefix strings (Bug#4281).
2804 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
2805
2806 2012-03-21 Chong Yidong <cyd@gnu.org>
2807
2808 * xfaces.c (Vface_remapping_alist): Doc fix.
2809
2810 2012-03-20 Eli Zaretskii <eliz@gnu.org>
2811
2812 * w32proc.c (Fw32_set_console_codepage)
2813 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
2814 Doc fixes.
2815
2816 2012-03-20 Chong Yidong <cyd@gnu.org>
2817
2818 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
2819 to reflect default non-nil value of redisplay-dont-pause.
2820
2821 2012-03-19 Kenichi Handa <handa@m17n.org>
2822
2823 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
2824 it fit in a valid range (Bug#11003).
2825
2826 2012-03-18 Eli Zaretskii <eliz@gnu.org>
2827
2828 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
2829 that is not from display property, accept the row as a "cursor
2830 row" if one of the string's character has a non-nil `cursor'
2831 property. Fixes cursor positioning when there are newlines in
2832 overlay strings, e.g. in icomplete.el. (Bug#11035)
2833
2834 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
2835
2836 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
2837
2838 2012-03-12 Chong Yidong <cyd@gnu.org>
2839
2840 * eval.c (inhibit_lisp_code): Rename from
2841 inhibit_window_configuration_change_hook; move from window.c.
2842
2843 * xfns.c (unwind_create_frame_1, Fx_create_frame):
2844 * window.c (run_window_configuration_change_hook)
2845 (syms_of_window): Callers changed.
2846
2847 2012-03-11 Chong Yidong <cyd@gnu.org>
2848
2849 * keymap.c (Fkey_description): Doc fix (Bug#9700).
2850
2851 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
2852
2853 2012-03-10 Chong Yidong <cyd@gnu.org>
2854
2855 * frame.c (other_visible_frames): Don't assume the selected frame
2856 is visible (Bug#10955).
2857
2858 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
2859
2860 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
2861
2862 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
2863
2864 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
2865 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
2866 zero (Bug#10954).
2867
2868 2012-03-03 Glenn Morris <rgm@gnu.org>
2869
2870 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
2871
2872 2012-03-02 Eli Zaretskii <eliz@gnu.org>
2873
2874 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
2875 position past the first glyph_row that ends at ZV. (Bug#10902)
2876 (redisplay_window, next_element_from_string): Fix typos in
2877 comments.
2878 (redisplay_window): Pass to move_it_vertically the margin in
2879 pixels, not in screen lines.
2880
2881 2012-03-02 Glenn Morris <rgm@gnu.org>
2882
2883 * buffer.c (buffer-list-update-hook): Doc fix.
2884
2885 2012-02-29 Eli Zaretskii <eliz@gnu.org>
2886
2887 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
2888 push_it before setting up the iterator for the first overlay
2889 string, even if we have an empty string loaded.
2890 (next_overlay_string): If there's an empty string on the iterator
2891 stack, pop the stack. (Bug#10903)
2892
2893 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
2894
2895 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
2896 Suggested by Stefan Monnier in
2897 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
2898 * alloc.c (widen_to_Lisp_Object): New static function.
2899 (mark_memory): Also mark Lisp_Objects by fetching pointer words
2900 and widening them to Lisp_Objects. This would work even if
2901 USE_LSB_TAG is defined and wide integers are used, which might
2902 happen in a future version of Emacs.
2903
2904 2012-02-25 Chong Yidong <cyd@gnu.org>
2905
2906 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
2907 Doc fix.
2908
2909 * xselect.c (Fx_selection_exists_p): Doc fix.
2910 (x_clipboard_manager_save_all): Print an informative message
2911 before saving to clipboard manager.
2912
2913 2012-02-24 Chong Yidong <cyd@gnu.org>
2914
2915 * keyboard.c (process_special_events): Handle all X selection
2916 requests in kbd_buffer, not just the next one (Bug#8869).
2917
2918 2012-02-23 Chong Yidong <cyd@gnu.org>
2919
2920 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
2921 call when setting menu-bar-lines and tool-bar-lines parameters.
2922 (unwind_create_frame_1): New helper function.
2923
2924 * window.c (inhibit_window_configuration_change_hook): New var.
2925 (run_window_configuration_change_hook): Obey it.
2926 (syms_of_window): Initialize it.
2927
2928 2012-02-22 Chong Yidong <cyd@gnu.org>
2929
2930 * xterm.c (x_draw_image_relief): Add missing type check for
2931 Vtool_bar_button_margin (Bug#10743).
2932
2933 2012-02-21 Chong Yidong <cyd@gnu.org>
2934
2935 * fileio.c (Vfile_name_handler_alist): Doc fix.
2936
2937 * buffer.c (Fget_file_buffer): Protect against invalid file
2938 handler return value.
2939
2940 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
2941
2942 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
2943 when computing $valmask.
2944
2945 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
2946 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
2947 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
2948 It's useless in that case, and it can cause problems on hosts
2949 that allocate halves of EMACS_INT values separately.
2950 Reported by Dan Horák. Diagnosed by Andreas Schwab in
2951 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
2952 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
2953 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
2954 it avoids undefined behavior on hosts where shifting right by more
2955 than the word width has undefined behavior.
2956
2957 2012-02-19 Chong Yidong <cyd@gnu.org>
2958
2959 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
2960 (Funhandled_file_name_directory, Ffile_name_as_directory)
2961 (Fdirectory_file_name, Fexpand_file_name)
2962 (Fsubstitute_in_file_name): Protect against invalid file handler
2963 return values (Bug#10845).
2964
2965 2012-02-18 Eli Zaretskii <eliz@gnu.org>
2966
2967 * .gdbinit (pitx): Fix incorrect references to fields of the
2968 iterator stack.
2969
2970 2012-02-17 Chong Yidong <cyd@gnu.org>
2971
2972 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
2973
2974 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
2975
2976 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
2977 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
2978
2979 2012-02-15 Chong Yidong <cyd@gnu.org>
2980
2981 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
2982 marked as special. Also, starting docstrings with * is obsolete.
2983
2984 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
2985
2986 * gnutls.c (emacs_gnutls_write): Fix last change.
2987
2988 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
2989
2990 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
2991 send_process.
2992
2993 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
2994
2995 * keymap.c (Fsingle_key_description): Handle char ranges.
2996
2997 2012-02-12 Chong Yidong <cyd@gnu.org>
2998
2999 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
3000 as that creates a dangerous corner case.
3001
3002 * window.c (Fdelete_window_internal): Invalidate the mouse
3003 highlight (Bug#9904).
3004
3005 2012-02-12 Glenn Morris <rgm@gnu.org>
3006
3007 * xselect.c (Fx_own_selection_internal)
3008 (Fx_get_selection_internal, Fx_disown_selection_internal)
3009 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
3010 * nsselect.m (Fx_own_selection_internal)
3011 (Fx_disown_selection_internal, Fx_selection_exists_p)
3012 (Fx_selection_owner_p, Fx_get_selection_internal):
3013 Sync docs and argument specs with the xselect.c versions.
3014
3015 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
3016
3017 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
3018
3019 2012-02-11 Eli Zaretskii <eliz@gnu.org>
3020
3021 * w32select.c (Fx_selection_exists_p): Sync doc string and
3022 argument list with xselect.c. (Bug#10783)
3023
3024 * w16select.c (Fx_selection_exists_p): Sync doc string and
3025 argument list with xselect.c. (Bug#10783)
3026
3027 2012-02-10 Glenn Morris <rgm@gnu.org>
3028
3029 * fns.c (Fsecure_hash): Doc fix.
3030
3031 2012-02-09 Kenichi Handa <handa@m17n.org>
3032
3033 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
3034
3035 2012-02-07 Chong Yidong <cyd@gnu.org>
3036
3037 * buffer.c (Fbuffer_local_variables)
3038 (buffer_lisp_local_variables): Handle unbound vars correctly;
3039 don't let Qunbound leak into Lisp.
3040
3041 2012-02-07 Glenn Morris <rgm@gnu.org>
3042
3043 * image.c (Fimagemagick_types): Doc fix.
3044
3045 * image.c (imagemagick-render-type): Change it from a lisp object
3046 to an integer. Move the doc here from the lisp manual.
3047 Treat all values not equal to 0 the same.
3048
3049 2012-02-06 Chong Yidong <cyd@gnu.org>
3050
3051 * doc.c (store_function_docstring): Avoid applying docstring of
3052 alias to base function (Bug#2603).
3053
3054 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
3055
3056 * .gdbinit (pp1, pv1): Remove redundant defines.
3057 (pr): Use pp.
3058
3059 2012-02-04 Chong Yidong <cyd@gnu.org>
3060
3061 * nsterm.m: Declare a global (Bug#10694).
3062
3063 2012-02-04 Eli Zaretskii <eliz@gnu.org>
3064
3065 * w32.c (get_emacs_configuration_options):
3066 Include --enable-checking, if specified, in the return value.
3067
3068 2012-02-04 Martin Rudalics <rudalics@gmx.at>
3069
3070 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
3071 after rounding frame sizes. (Bug#9723)
3072
3073 2012-02-04 Eli Zaretskii <eliz@gnu.org>
3074
3075 * keyboard.c (adjust_point_for_property): Don't position point
3076 before BEGV. (Bug#10696)
3077
3078 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
3079
3080 Handle overflow when computing char display width (Bug#9496).
3081 * character.c (char_width): Return EMACS_INT, not int.
3082 (char_width, c_string_width): Check for overflow when
3083 computing the width; this is possible now that individual
3084 characters can have unbounded width. Problem introduced
3085 by merge from Emacs 23 on 2012-01-19.
3086
3087 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
3088
3089 * dbusbind.c (Fdbus_register_method): Mention the return value
3090 :ignore in the docstring.
3091
3092 2012-02-02 Glenn Morris <rgm@gnu.org>
3093
3094 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
3095
3096 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3097 Unconditionally set to t. (Bug#10673)
3098 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3099 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
3100 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
3101
3102 2012-02-02 Kenichi Handa <handa@m17n.org>
3103
3104 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
3105 0, do not call append_composite_glyph.
3106
3107 2012-02-02 Kenichi Handa <handa@m17n.org>
3108
3109 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
3110 NULL (Bug#6988).
3111 (x_produce_glyphs): If the component of a composition is a null
3112 string, set it->pixel_width to 1 to avoid zero-width glyph.
3113
3114 2012-02-01 Eli Zaretskii <eliz@gnu.org>
3115
3116 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
3117 first 2 arguments are identical. This makes inserting large
3118 output from a subprocess an order of magnitude faster on
3119 MS-Windows, where all sbrk'ed memory is always contiguous.
3120
3121 2012-01-31 Glenn Morris <rgm@gnu.org>
3122
3123 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3124 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
3125 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
3126
3127 2012-01-29 Glenn Morris <rgm@gnu.org>
3128
3129 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
3130
3131 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
3132
3133 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
3134
3135 2012-01-28 Chong Yidong <cyd@gnu.org>
3136
3137 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
3138
3139 2012-01-26 Chong Yidong <cyd@gnu.org>
3140
3141 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
3142
3143 * search.c (Fsearch_forward, Fsearch_backward): Document negative
3144 repeat counts (Bug#10507).
3145
3146 2012-01-26 Glenn Morris <rgm@gnu.org>
3147
3148 * lread.c (syms_of_lread): Doc fix.
3149
3150 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
3151
3152 * coding.c (encode_designation_at_bol): Change return value to
3153 EMACS_INT.
3154
3155 2012-01-25 Chong Yidong <cyd@gnu.org>
3156
3157 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
3158
3159 2012-01-21 Chong Yidong <cyd@gnu.org>
3160
3161 * floatfns.c (Fcopysign): Make the second argument non-optional,
3162 since nil is not allowed anyway.
3163
3164 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
3165
3166 * process.c (read_process_output): Use p instead of XPROCESS (proc).
3167 (send_process): Likewise.
3168
3169 2012-01-19 Martin Rudalics <rudalics@gmx.at>
3170
3171 * window.c (save_window_save, Fcurrent_window_configuration)
3172 (Vwindow_persistent_parameters): Do not use Qstate.
3173 Rewrite doc-strings.
3174
3175 2012-01-19 Kenichi Handa <handa@m17n.org>
3176
3177 * character.c (char_width): New function.
3178 (Fchar_width, c_string_width, lisp_string_width):
3179 Use char_width (Bug#9496).
3180
3181 2012-01-16 Martin Rudalics <rudalics@gmx.at>
3182
3183 * window.c (Vwindow_persistent_parameters): New variable.
3184 (Fset_window_configuration, save_window_save): Handle persistent
3185 window parameters.
3186
3187 2012-01-14 Eli Zaretskii <eliz@gnu.org>
3188
3189 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
3190 thrashing the stack of the thread. (Bug#9087)
3191
3192 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
3193
3194 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
3195
3196 2012-01-11 Eli Zaretskii <eliz@gnu.org>
3197
3198 * xdisp.c (rows_from_pos_range): Handle the case where the
3199 highlight ends on a newline. (Bug#10464)
3200 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
3201 he end column for display of highlight that ends on a newline
3202 before a R2L line.
3203
3204 2012-01-11 Glenn Morris <rgm@gnu.org>
3205
3206 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
3207 from load-path also when installation-directory is nil. (Bug#10208)
3208
3209 2012-01-10 Glenn Morris <rgm@gnu.org>
3210
3211 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
3212
3213 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
3214 Update template values to be closer to their typical values these days.
3215
3216 2012-01-09 Eli Zaretskii <eliz@gnu.org>
3217
3218 * xdisp.c (rows_from_pos_range): Accept additional argument
3219 DISP_STRING, and accept any glyph in a row whose object is that
3220 string as eligible for mouse highlight. Fixes mouse highlight of
3221 display strings from overlays. (Bug#10464)
3222
3223 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
3224
3225 emacs: fix an auto-save permissions race condition (Bug#10400)
3226 * fileio.c (auto_saving_dir_umask): New static var.
3227 (Fmake_directory_internal): Use it.
3228 (do_auto_save_make_dir): Set it, instead of invoking chmod after
3229 creating the directory. The old code temporarily assigns
3230 too-generous permissions to the directory.
3231 (do_auto_save_eh): Clear it.
3232 (Fdo_auto_save): Catch all errors, not just file errors, so
3233 that the var is always cleared.
3234
3235 2012-01-07 Eli Zaretskii <eliz@gnu.org>
3236
3237 * search.c (scan_buffer): Pass character positions to
3238 know_region_cache, not byte positions. (Bug#6540)
3239
3240 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
3241
3242 * w32.c (sys_rename): Report EXDEV when rename of a directory
3243 fails because the target is on another logical disk. (Bug#10284)
3244
3245 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
3246
3247 * xterm.c (x_embed_request_focus): New function.
3248
3249 * xterm.h: Add prototype.
3250
3251 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
3252
3253 2012-01-05 Glenn Morris <rgm@gnu.org>
3254
3255 * emacs.c (emacs_copyright): Update short copyright year to 2012.
3256
3257 2012-01-01 Eli Zaretskii <eliz@gnu.org>
3258
3259 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
3260 Load gnutls_transport_set_lowat only if GnuTLS version is below
3261 2.11.1.
3262 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
3263 GnuTLS versions below 2.11.1.
3264
3265 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
3266
3267 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
3268 to the doc string advising against its use for altering the way
3269 windows are scrolled.
3270
3271 2011-12-28 Kenichi Handa <handa@m17n.org>
3272
3273 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
3274 coding-system ASCII compatible only when it does not produce BOM
3275 on encoding (Bug#10383).
3276
3277 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
3278
3279 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
3280 can scroll.
3281 (create_and_show_popup_menu): Always use menu_position_func for
3282 Gtk3 (Bug#10361).
3283
3284 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
3285
3286 * callint.c (Fcall_interactively): Don't truncate prompt string.
3287
3288 2011-12-23 Eli Zaretskii <eliz@gnu.org>
3289
3290 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
3291 property that ends at ZV, so that the bidi iteration could be
3292 resumed from there (after widening). (Bug#10360)
3293
3294 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
3295
3296 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
3297
3298 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
3299
3300 * nsterm.m (x_free_frame_resources):
3301 Release f->output_data.ns->miniimage.
3302 (ns_index_color): Fix indentation. Do not retain
3303 color_table->colors[i].
3304
3305 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
3306 before returning.
3307
3308 * nsfns.m (x_set_background_color): Assign return value from
3309 ns_index_color to face-background instead of NSColor*.
3310 (ns_implicitly_set_icon_type): Fix indentation.
3311 Change assignment in for loop to comparison.
3312
3313 * emacs.c (ns_pool): New variable.
3314 (main): Assign ns_pool.
3315 (Fkill_emacs): Call ns_release_autorelease_pool.
3316
3317 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
3318 autorelease fdesc, release fdAttrs and tdict.
3319 (ns_get_covering_families): Release charset.
3320 (ns_findfonts): Release NSFontDescriptor created with new.
3321 (ns_uni_to_glyphs): Fix indentation.
3322 (setString): Release attrStr before assigning new value.
3323
3324 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
3325
3326 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
3327 and NS_IMPL_COCOA.
3328 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
3329 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
3330
3331 2011-12-18 David Reitter <reitter@cmu.edu>
3332
3333 * nsterm.m (ns_term_init): Subscribe for notifications
3334 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
3335 to method trackingNotification in EmacsMenu.
3336
3337 * nsmenu.m (trackingMenu): New variable.
3338 (trackingNotification): New method (from Aquamacs).
3339 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3340 from Aquamacs (Bug#7030).
3341
3342 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
3343
3344 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
3345 (symbol_to_nsstring): Fix indentation.
3346 (ns_symbol_to_pb): New function.
3347 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
3348 (Fns_rotate_cut_buffers_internal): Remove.
3349 (Fns_store_selection_internal): Rename from
3350 Fns_store_cut_buffer_internal.
3351 (ns_get_foreign_selection, Fx_own_selection_internal)
3352 (Fx_disown_selection_internal, Fx_selection_exists_p)
3353 (Fns_get_selection_internal, Fns_store_selection_internal):
3354 Use ns_symbol_to_pb and check if return value is nil.
3355 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
3356 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
3357 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
3358 renamed to Sns_store_selection_internal.
3359 (ns_handle_selection_request): Move code to Fx_own_selection_internal
3360 and remove this function.
3361 (ns_handle_selection_clear): Remove, never used.
3362 (Fx_own_selection_internal): Move code from ns_handle_selection_request
3363 here.
3364
3365 2011-12-17 Ken Brown <kbrown@cornell.edu>
3366
3367 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
3368 GID is unknown (Bug#10257).
3369
3370 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
3371
3372 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
3373 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
3374 which caused a build failure on GNU/Linux IA-64. This problem was
3375 introduced by my 2011-10-07 patch.
3376
3377 2011-12-15 Juri Linkov <juri@jurta.org>
3378
3379 * image.c (imagemagick_error): New function. (Bug#10112)
3380 (imagemagick_load_image): Comment out `MagickSetResolution' call.
3381 Use `imagemagick_error' where ImageMagick functions return
3382 `MagickFalse'.
3383 (Fimagemagick_types): Add `Fnreverse' to return the list in the
3384 proper order.
3385
3386 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3387
3388 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
3389 fill background (Bug#8992).
3390
3391 2011-12-13 Martin Rudalics <rudalics@gmx.at>
3392
3393 * window.c (Vwindow_combination_resize)
3394 (Vwindow_combination_limit): Use t instead of non-nil in
3395 doc-strings.
3396 (Vrecenter_redisplay): Add first sentence of doc-string on
3397 separate line.
3398 (Frecenter): Fix doc-string typo.
3399
3400 2011-12-11 Kenichi Handa <handa@m17n.org>
3401
3402 * coding.c (Funencodable_char_position): Pay attention to the
3403 buffer text relocation (Bug#9389).
3404
3405 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
3406
3407 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
3408 gtk_init (Bug#10100).
3409
3410 2011-12-10 Eli Zaretskii <eliz@gnu.org>
3411
3412 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
3413 IT->string is nil. (Bug#10263)
3414
3415 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
3416
3417 * nsterm.h (x_free_frame_resources): Declare.
3418
3419 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
3420 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
3421
3422 * nsterm.h (ns_get_defaults_value): Declare.
3423
3424 * nsterm.m (ns_default): Call ns_get_defaults_value.
3425
3426 2011-12-09 Eli Zaretskii <eliz@gnu.org>
3427
3428 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
3429 (Bug#10170)
3430
3431 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3432
3433 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
3434 that where the value of an _OBJC_* symbol points to is in the .bss
3435 section (Bug#10240).
3436
3437 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3438
3439 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
3440 after the loop to call ccl_driver at least once (Bug#8619).
3441
3442 2011-12-08 Kenichi Handa <handa@m17n.org>
3443
3444 * ftfont.c (get_adstyle_property): Fix previous change
3445 (Bug#10233).
3446
3447 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
3448
3449 * w32.c (init_environment): If no_site_lisp, remove site-lisp
3450 dirs from the default value of EMACSLOADPATH (bug#10208).
3451
3452 2011-12-07 Glenn Morris <rgm@gnu.org>
3453
3454 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
3455 installation and source directories as well. (Bug#10208)
3456
3457 2011-12-06 Chong Yidong <cyd@gnu.org>
3458
3459 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
3460
3461 2011-12-06 Glenn Morris <rgm@gnu.org>
3462
3463 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
3464 as an error, not just -1. (Bug#10217)
3465
3466 2011-12-05 Chong Yidong <cyd@gnu.org>
3467
3468 * keyboard.c (process_special_events): New function.
3469 (swallow_events, Finput_pending_p): Use it (Bug#10195).
3470
3471 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
3472
3473 * coding.c (encode_designation_at_bol): Don't use uninitialized
3474 local variable (Bug#9318).
3475
3476 2011-12-05 Kenichi Handa <handa@m17n.org>
3477
3478 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
3479 return Qnil (Bug#8046, Bug#10193).
3480
3481 2011-12-05 Kenichi Handa <handa@m17n.org>
3482
3483 * coding.c (encode_designation_at_bol): New args charbuf_end and
3484 dst. Return the number of produced bytes. Callers changed.
3485 (coding_set_source): Return how many bytes coding->source was
3486 relocated.
3487 (coding_set_destination): Return how many bytes
3488 coding->destination was relocated.
3489 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
3490 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
3491
3492 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3493
3494 * coding.c (CODING_CHAR_CHARSET_P): New macro.
3495 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
3496 macro (Bug#9318).
3497
3498 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
3499
3500 The following changes are to fix Bug#9318.
3501
3502 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
3503 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
3504 (encode_coding_iso_2022, encode_coding_sjis)
3505 (encode_coding_big5, encode_coding_charset): Use the above macros.
3506
3507 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
3508
3509 * lisp.h (process_quit_flag): Fix external declaration.
3510
3511 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
3512
3513 Don't macro-inline non-performance-critical code.
3514 * eval.c (process_quit_flag): New function.
3515 * lisp.h (QUIT): Use it.
3516
3517 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
3518
3519 * nsfns.m (get_geometry_from_preferences): New function.
3520 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
3521
3522 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
3523
3524 * emacs.c (Qkill_emacs): Define.
3525 (syms_of_emacs): Initialize it.
3526 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
3527 Qquit_flag to `kill-emacs' instead.
3528 (quit_throw_to_read_char): Add parameter `from_signal'.
3529 All callers changed. Call Fkill_emacs if requested and safe.
3530 * lisp.h (QUIT): Call Fkill_emacs if requested.
3531
3532 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
3533
3534 * widget.c (update_wm_hints): Return if wmshell is null.
3535 (widget_update_wm_size_hints): New function.
3536
3537 * widget.h (widget_update_wm_size_hints): Declare.
3538
3539 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
3540 widget_update_wm_size_hints (Bug#10104).
3541
3542 2011-12-03 Eli Zaretskii <eliz@gnu.org>
3543
3544 * xdisp.c (handle_invisible_prop): If the invisible text ends just
3545 before a newline, prepare the bidi iterator for consuming the
3546 newline, and keep the current paragraph direction. (Bug#10183)
3547 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
3548
3549 2011-12-02 Juri Linkov <juri@jurta.org>
3550
3551 * search.c (Fword_search_regexp): New Lisp function created from
3552 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
3553 (Fword_search_backward, Fword_search_forward)
3554 (Fword_search_backward_lax, Fword_search_forward_lax):
3555 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
3556 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
3557
3558 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
3559
3560 * fileio.c (Finsert_file_contents): Move after-change-function call
3561 to before the "handled:" label, since all "goto handled" appear in
3562 cases where the *-change-functions have already been properly called
3563 (bug#10117).
3564
3565 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
3566
3567 * keyboard.c (interrupt_signal): Don't call kill-emacs when
3568 waiting for input. (Bug#10169)
3569
3570 2011-11-30 Eli Zaretskii <eliz@gnu.org>
3571
3572 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
3573 verifies glyph row's hash code--we have just reallocated the
3574 glyphs, so their contents can be complete garbage. (Bug#10164)
3575
3576 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
3577
3578 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
3579
3580 2011-11-30 Eli Zaretskii <eliz@gnu.org>
3581
3582 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
3583 attributes are tested _before_ calling verify_row_hash, to protect
3584 against GCC re-ordering of the tests. (Bug#10164)
3585
3586 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
3587
3588 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
3589
3590 * xterm.c (handle_one_xevent): Only set async_visible and friends
3591 if net_wm_state_hidden_seen is non-zero (Bug#10002)
3592 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
3593 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
3594
3595 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
3596
3597 Remove GCPRO-related macros that exist only to avoid shadowing locals.
3598 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
3599 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
3600 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3601 All uses changed to use GCPRO1 etc.
3602 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
3603 Revert to old implementation (i.e., before 2011-03-11).
3604
3605 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3606
3607 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
3608 of scroll runs so as to avoid assigning disabled bogus rows and
3609 unnecessary graphics copy operations.
3610
3611 2011-11-27 Eli Zaretskii <eliz@gnu.org>
3612
3613 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
3614 (snprintf) [_MSC_VER]: Redirect to _snprintf.
3615 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
3616 (malloc, free, realloc, calloc): Redirect to e_* only when
3617 compiling Emacs.
3618
3619 * lisp.h (GCTYPEBITS): Move before first use.
3620 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
3621 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
3622 this macro definition.
3623
3624 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
3625 _MSC_VER.
3626
3627 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
3628
3629 * gtkutil.c (xg_create_frame_widgets):
3630 Call gtk_window_set_has_resize_grip (FALSE) if that function is
3631 present with Gtk+ 2.0.
3632
3633 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3634
3635 * fileio.c (Finsert_file_contents): Undo previous change; see
3636 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3637
3638 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3639
3640 Rename locals to avoid shadowing.
3641 * fileio.c (Finsert_file_contents):
3642 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
3643 * process.c (wait_reading_process_output):
3644 Rename inner 'proc' to 'p' to avoid shadowing.
3645 Indent for consistency with usual Emacs style.
3646
3647 2011-11-25 Eli Zaretskii <eliz@gnu.org>
3648
3649 * xdisp.c (redisplay_window): If cursor row is not fully visible
3650 after recentering, and scroll-conservatively is set to a large
3651 number, scroll window by a few more lines to make the cursor fully
3652 visible and out of scroll-margin. (Bug#10105)
3653 (start_display): Don't move to the next line if the display should
3654 start at a newline that is part of a display vector or an overlay
3655 string. (Bug#10119)
3656
3657 2011-11-24 Juri Linkov <juri@jurta.org>
3658
3659 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
3660 after the `MagickPingImage' call. (Bug#10112)
3661
3662 2011-11-23 Chong Yidong <cyd@gnu.org>
3663
3664 * window.c (Fcoordinates_in_window_p): Accept only live windows.
3665
3666 2011-11-23 Martin Rudalics <rudalics@gmx.at>
3667
3668 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
3669 making another buffer current. (Bug#10114)
3670
3671 2011-11-23 Glenn Morris <rgm@gnu.org>
3672
3673 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
3674
3675 2011-11-23 Chong Yidong <cyd@gnu.org>
3676
3677 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
3678 using it (Bug#5984).
3679
3680 2011-11-22 Eli Zaretskii <eliz@gnu.org>
3681
3682 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
3683 and header-lines, as they don't have one computed for them.
3684 (Bug#10098)
3685
3686 * .gdbinit (prow): Make displayed values more self-explaining.
3687 Add row's hash code.
3688
3689 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
3690
3691 * process.c (wait_reading_process_output): Fix asynchrounous
3692 GnuTLS socket handling on some versions of the GnuTLS library.
3693 (wait_reading_process_output): Add comment and URL.
3694
3695 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
3696
3697 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
3698
3699 2011-11-21 Chong Yidong <cyd@gnu.org>
3700
3701 * window.c (Fnext_window, Fprevious_window): Doc fix.
3702
3703 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3704
3705 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
3706
3707 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
3708
3709 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
3710
3711 2011-11-20 Martin Rudalics <rudalics@gmx.at>
3712
3713 * window.c (Fset_window_combination_limit): Rename argument
3714 STATUS to LIMIT.
3715 (Vwindow_combination_limit): Remove "status" from doc-string.
3716
3717 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
3718
3719 * m/ibms390.h: Remove.
3720 * m/ibms390x.h: Don't include "ibms390.h".
3721
3722 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3723
3724 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
3725 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
3726
3727 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
3728
3729 * casetab.c (Fset_case_table):
3730 * charset.c (Fcharset_after): Fix typos.
3731
3732 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
3733
3734 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
3735 Otherwise, valgrind does not work on some platforms.
3736 Problem reported by Andreas Schwab in
3737 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
3738 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
3739 is set, removing the need for VIRT_ADDRESS_VARIES.
3740 (PURE_P): Use a more-efficient implementation that needs just one
3741 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
3742 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
3743 to 4 (xorl, subq, cmpq, setbe).
3744 * alloc.c (pure): Always extern now, since that's the
3745 VIRT_ADDR_VARIES behavior.
3746 (PURE_POINTER_P): Use a single comparison, not two, for
3747 consistency with the new puresize.h.
3748 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
3749 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
3750 Remove VIRT_ADDR_VARIES no longer needed.
3751
3752 2011-11-19 Eli Zaretskii <eliz@gnu.org>
3753
3754 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
3755 (erase_phys_cursor, update_window_cursor, show_mouse_face)
3756 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
3757 behave as if the cursor position were at the window margin.
3758
3759 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
3760 and the cursor position is out of bounds, behave as if the cursor
3761 position were at the window margin. (Bug#10075)
3762
3763 2011-11-18 Chong Yidong <cyd@gnu.org>
3764
3765 * window.c (Fwindow_combination_limit): Make first argument
3766 non-optional, since it is meaningless for live windows like the
3767 selected window.
3768
3769 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
3770
3771 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
3772
3773 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
3774
3775 * intervals.c: Fix grafting over the whole buffer (bug#10071).
3776 (graft_intervals_into_buffer): Simplify.
3777
3778 2011-11-18 Eli Zaretskii <eliz@gnu.org>
3779
3780 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
3781 hash values of the two rows.
3782 (copy_row_except_pointers): Preserve the used[] arrays and the
3783 hash values of the two rows. (Bug#10035)
3784 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
3785
3786 * xdisp.c (row_hash): New function, body extracted from
3787 compute_line_metrics.
3788 (compute_line_metrics): Call row_hash, instead of computing the
3789 hash code inline.
3790
3791 * dispnew.c (verify_row_hash): Call row_hash for computing the
3792 hash code of a row, instead of duplicating code from xdisp.c.
3793
3794 * dispextern.h (row_hash): Add prototype.
3795
3796 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
3797
3798 * frame.c (delete_frame): Don't delete the terminal when the last
3799 X frame is closed if emacs is built with GTK toolkit.
3800
3801 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
3802
3803 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
3804
3805 2011-11-17 Martin Rudalics <rudalics@gmx.at>
3806
3807 * window.c (Vwindow_splits): Rename to
3808 Vwindow_combination_resize. Suggested by Juri Linkov.
3809 (Fsplit_window_internal): Use Vwindow_combination_resize instead
3810 of Vwindow_splits.
3811
3812 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
3813
3814 * nsfns.m (Fns_font_name):
3815 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
3816
3817 2011-11-16 Martin Rudalics <rudalics@gmx.at>
3818
3819 * window.h (window): Rename slot "nest" to "combination_limit".
3820 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
3821 (Fset_window_nest): Rename to Fset_window_combination_limit.
3822 (Vwindow_nest): Rename to Vwindow_combination_limit.
3823 (recombine_windows, make_parent_window, make_window)
3824 (Fsplit_window_internal, saved_window)
3825 (Fset_window_configuration, save_window_save): Rename all
3826 occurrences of window_nest to window_combination_limit.
3827
3828 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
3829
3830 * image.c (imagemagick_load_image): Fix typo.
3831
3832 2011-11-14 Eli Zaretskii <eliz@gnu.org>
3833
3834 * xdisp.c (display_line): Move the call to
3835 highlight_trailing_whitespace before the call to
3836 compute_line_metrics, since the latter needs to see the final
3837 faces of all the glyphs to compute ROW's hash value.
3838 Fixes assertion violations in row_equal_p. (Bug#10035)
3839
3840 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
3841
3842 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
3843 just return (bug#10044).
3844
3845 2011-11-12 Eli Zaretskii <eliz@gnu.org>
3846
3847 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
3848 with user-defined heap size. Bump the default size of the temacs
3849 heap to 27MB, to avoid memory warning when running temacs.
3850 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
3851
3852 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
3853 current_matrix and desired_matrix. (Bug#9990)
3854 (verify_row_hash) [XASSERTS]: New function.
3855 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
3856 that the hash value of glyph rows is correct.
3857
3858 2011-11-12 Martin Rudalics <rudalics@gmx.at>
3859
3860 * window.h (window): Remove splits slot.
3861 * window.c (Fwindow_splits, Fset_window_splits): Remove.
3862 (Fdelete_other_windows_internal, make_parent_window)
3863 (make_window, Fsplit_window_internal, Fdelete_window_internal)
3864 (Fset_window_configuration, save_window_save): Don't deal with
3865 split status of windows.
3866 (saved_window): Remove splits slot.
3867 (Vwindow_splits): Rewrite doc-string.
3868
3869 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
3870
3871 * xfns.c (unwind_create_frame):
3872 * nsfns.m (unwind_create_frame):
3873 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
3874 Vframe_list (Bug#9999).
3875
3876 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
3877
3878 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
3879
3880 2011-11-11 Kenichi Handa <handa@m17n.org>
3881
3882 * callproc.c (Fcall_process): Set the member dst_multibyte of
3883 process_coding.
3884
3885 2011-11-11 Johan Bockgård <bojohan@gnu.org>
3886
3887 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
3888 avoid a crash (bug#9496).
3889
3890 2011-11-09 Chong Yidong <cyd@gnu.org>
3891
3892 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
3893 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
3894
3895 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3896
3897 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
3898
3899 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3900
3901 Avoid some portability problems by eschewing 'extern inline' functions.
3902 The trivial performance wins aren't worth the portability hassles; see
3903 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
3904 et seq.
3905 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3906 (window_box_width, window_box_left, window_box_left_offset)
3907 (window_box_right, window_box_right_offset): Undo previous change,
3908 by removing the "extern"s.
3909 * intervals.c (adjust_intervals_for_insertion)
3910 (adjust_intervals_for_deletion): Undo previous change,
3911 making these static again.
3912 (offset_intervals, temp_set_point_both, temp_set_point)
3913 (copy_intervals_to_string): No longer inline.
3914 * xdisp.c (window_text_bottom_y, window_box_width)
3915 (window_box_height, window_box_left_offset)
3916 (window_box_right_offset, window_box_left, window_box_right)
3917 (window_box): No longer inline.
3918
3919 2011-11-08 Chong Yidong <cyd@gnu.org>
3920
3921 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
3922 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
3923 Signal an error if not a live window.
3924 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
3925 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
3926
3927 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
3928
3929 * lisp.h (syms_of_abbrev): Remove declaration.
3930 Reported by CHENG Gao <chenggao@royau.me>.
3931
3932 2011-11-07 Eli Zaretskii <eliz@gnu.org>
3933
3934 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
3935 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
3936 of temacs in GUI mode.
3937
3938 2011-11-07 Martin Rudalics <rudalics@gmx.at>
3939
3940 * window.h: Declare delete_all_child_windows instead of
3941 delete_all_subwindows.
3942 * window.c (Fwindow_nest, Fset_window_nest)
3943 (Fset_window_new_total, Fset_window_new_normal)
3944 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
3945 (delete_all_subwindows): Rename to delete_all_child_windows.
3946 (Fdelete_other_windows_internal, Fset_window_configuration):
3947 Call delete_all_child_windows instead of delete_all_subwindows.
3948 * frame.c (delete_frame): Call delete_all_child_windows instead
3949 of delete_all_subwindows.
3950
3951 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
3952
3953 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
3954 This is also needed for porting to any host where GC_MARK_STACK is
3955 not GC_MAKE_GCPROS_NOOPS.
3956 (which_symbols): Use it.
3957
3958 2011-11-07 Kenichi Handa <handa@m17n.org>
3959
3960 * coding.c (coding_set_destination): Check coding->src_pos only
3961 when coding->src_object is a buffer (bug#9910).
3962
3963 * process.c (send_process): Set the member src_multibyte of coding
3964 to 0 (bug#9911) when sending a unibyte text.
3965
3966 * callproc.c (Fcall_process): Set the member src_multibyte of
3967 process_coding to 0 (bug#9912).
3968
3969 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3970
3971 * xmenu.c (cleanup_widget_value_tree): New function.
3972 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
3973 calling free_menubar_widget_value_tree directly (Bug#9830).
3974
3975 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
3976
3977 Fix some portability problems with 'inline'.
3978 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3979 (window_box_width, window_box_left, window_box_left_offset)
3980 (window_box_right, window_box_right_offset): Declare extern.
3981 Otherwise, these inline functions do not conform to C99 and
3982 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
3983 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
3984 * intervals.c (adjust_intervals_for_insertion)
3985 (adjust_intervals_for_deletion): Now extern, because otherwise the
3986 extern inline functions 'offset_intervals' couldn't refer to it.
3987 (static_offset_intervals): Remove.
3988 (offset_intervals): Rewrite using the old contents of
3989 static_offset_intervals. The old version didn't conform to C99
3990 because an extern inline function contained a reference to an
3991 identifier with static linkage.
3992
3993 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
3994
3995 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
3996 GC.
3997
3998 2011-11-06 Eli Zaretskii <eliz@gnu.org>
3999
4000 * xdisp.c (init_iterator, reseat_to_string): Don't set the
4001 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
4002 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
4003 return Qleft_to_right.
4004
4005 2011-11-06 Chong Yidong <cyd@gnu.org>
4006
4007 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
4008 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
4009 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
4010 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
4011 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
4012 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
4013 (Fwindow_vscroll): Doc fix.
4014 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
4015 argument, since it makes no sense to pass a live window and for
4016 consistency with window-child.
4017
4018 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
4019
4020 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
4021 support MSVC.
4022
4023 2011-11-05 Jason Rumney <jasonr@gnu.org>
4024
4025 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
4026 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
4027 fonts (Bug#6029).
4028 (add_font_entity_to_list): Fix logic errors in mixed boolean and
4029 bitwise arithmetic preventing use of unicode-sip and non-truetype
4030 opentype fonts.
4031
4032 2011-11-05 Eli Zaretskii <eliz@gnu.org>
4033
4034 * s/ms-w32.h (fstat, stat, utime): Move redirections to
4035 "emacs"-only part.
4036
4037 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
4038 initialization code to keep similarity to xfns.c after changes
4039 from 2011-11-05.
4040
4041 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
4042
4043 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
4044 (unwind_create_frame): New function (Bug#9943).
4045 (Fx_create_frame): Restructure code to be more similar to the one in
4046 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
4047 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
4048 Move terminal->reference_count++ just before making the frame official
4049 (Bug#9943).
4050
4051 * nsterm.m (x_free_frame_resources): New function.
4052 (x_destroy_window): Move code to x_free_frame_resources.
4053
4054 * xfns.c (unwind_create_frame): Fix comment.
4055 (Fx_create_frame, x_create_tip_frame):
4056 Move terminal->reference_count++ just before making the frame
4057 official. Move initialization of image_cache_refcount and
4058 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
4059
4060 2011-11-05 Eli Zaretskii <eliz@gnu.org>
4061
4062 Support MSVC build with newer versions of Visual Studio.
4063 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
4064 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
4065 nt/gmake.defs.
4066
4067 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
4068 which are not supported by MSVC.
4069 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
4070 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
4071 bitfields.
4072 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
4073 types in bitfields.
4074 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
4075
4076 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
4077
4078 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
4079
4080 Support MSVC build with newer versions of Visual Studio.
4081 * w32.c: Don't include w32api.h for MSVC.
4082 (init_environment) [_MSC_VER]: Call sys_access, not _access.
4083
4084 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
4085 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
4086 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
4087 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
4088 e_* cousins.
4089 (alloca) [_MSC_VER]: Define to _alloca.
4090
4091 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
4092
4093 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
4094
4095 2011-11-04 Eli Zaretskii <eliz@gnu.org>
4096
4097 * xdisp.c (note_mouse_highlight): If either of
4098 previous/next-single-property-change returns nil, treat that as
4099 the beginning or the end of the buffer. (Bug#9955)
4100
4101 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
4102
4103 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
4104 label is not null (Bug#9951).
4105 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
4106 may be NULL.
4107
4108 2011-11-04 Eli Zaretskii <eliz@gnu.org>
4109
4110 * window.c (Fwindow_body_size): Mention in the doc string that the
4111 return value is in frame's canonical units. (Bug#9949)
4112
4113 2011-11-03 Eli Zaretskii <eliz@gnu.org>
4114
4115 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
4116
4117 * w32fns.c (unwind_create_frame): If needed, free the glyph
4118 matrices of the partially constructed frame. (Bug#9943)
4119 * xfns.c (unwind_create_frame): Likewise.
4120
4121 2011-11-01 Eli Zaretskii <eliz@gnu.org>
4122
4123 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
4124 Don't stop backward scan on the continuation glyph, even though
4125 its CHARPOS is positive.
4126 (mouse_face_from_buffer_pos, note_mouse_highlight):
4127 Rename cover_string to disp_string.
4128
4129 2011-11-01 Martin Rudalics <rudalics@gmx.at>
4130
4131 * window.c (temp_output_buffer_show): Don't use
4132 Vtemp_buffer_show_specifiers.
4133 (Vtemp_buffer_show_specifiers): Remove unused variable.
4134
4135 2011-10-30 Eli Zaretskii <eliz@gnu.org>
4136
4137 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
4138 past the beginning of the current glyph matrix.
4139
4140 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
4141
4142 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
4143 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
4144 HAVE_GTK3 (Bug#9869).
4145
4146 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
4147 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
4148
4149 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
4150
4151 * xterm.c: Declare x_handle_net_wm_state to return int.
4152 (handle_one_xevent): Check if we are iconified but don't have
4153 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
4154 (get_current_wm_state): Return non-zero if not hidden,
4155 check for _NET_WM_STATE_HIDDEN (Bug#9893).
4156 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
4157 (x_handle_net_wm_state): Return what get_current_wm_state returns.
4158 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
4159
4160 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
4161
4162 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
4163 so that this new function doesn't get optimized away by a
4164 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
4165
4166 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4167
4168 * frame.h (MOUSE_HL_INFO): Remove excess parens.
4169
4170 2011-10-29 Eli Zaretskii <eliz@gnu.org>
4171
4172 Fix the `xbytecode' command.
4173 * .gdbinit (xprintbytestr): New command.
4174 (xwhichsymbols): Rename from `which'; all callers changed.
4175 (xbytecode): Print the byte-code string as well.
4176
4177 2011-10-29 Kim Storm <storm@cua.dk>
4178
4179 * alloc.c (which_symbols): New function.
4180
4181 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4182
4183 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
4184 line. (Bug#9903)
4185
4186 2011-10-29 Glenn Morris <rgm@gnu.org>
4187
4188 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
4189 Not clear what it was for, and it causes various bugs. (Bug#9839)
4190
4191 2011-10-28 Eli Zaretskii <eliz@gnu.org>
4192
4193 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
4194 possible random value that matches one of those tested as
4195 condition to clear the mouse face.
4196
4197 2011-10-28 Chong Yidong <cyd@gnu.org>
4198
4199 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
4200
4201 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
4202
4203 * window.c (make_window): Initialize phys_cursor_on_p.
4204
4205 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
4206
4207 * lisp.h (struct Lisp_Symbol): Update comments.
4208
4209 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
4210
4211 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
4212
4213 2011-10-28 Eli Zaretskii <eliz@gnu.org>
4214
4215 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
4216 <oslsachem@gmail.com> for helping to debug this.
4217
4218 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
4219 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
4220 (g_b_init_get_glyph_outline_w): New static variables.
4221 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
4222 (GetGlyphOutlineW_Proc): New typedefs.
4223 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
4224 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
4225 New functions.
4226 (w32font_open_internal, compute_metrics):
4227 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
4228 instead of calling the "wide" APIs directly.
4229
4230 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
4231
4232 * w32.h (syms_of_w32font): Add prototype.
4233
4234 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
4235
4236 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
4237 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
4238 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
4239 (Fmove_to_window_line): Doc fix.
4240
4241 2011-10-27 Chong Yidong <cyd@gnu.org>
4242
4243 * process.c (make_process): Set gnutls_state to NULL.
4244
4245 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
4246 non-NULL, regardless of GNUTLS_INITSTAGE.
4247 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
4248 an error. Set process slots as soon as we allocate them.
4249
4250 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
4251
4252 2011-10-27 Chong Yidong <cyd@gnu.org>
4253
4254 * gnutls.c (emacs_gnutls_deinit): New function.
4255 Deallocate credentials structures as well as calling gnutls_deinit.
4256 (Fgnutls_deinit, Fgnutls_boot): Use it.
4257
4258 * process.c (make_process): Initialize GnuTLS credentials to NULL.
4259 (deactivate_process): Call emacs_gnutls_deinit.
4260
4261 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
4262
4263 * image.c (x_create_x_image_and_pixmap):
4264 * w32.c (sys_rename, w32_delayed_load):
4265 * w32font.c (fill_in_logfont):
4266 * w32reg.c (x_get_string_resource): Silence compiler warnings.
4267
4268 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
4269
4270 * w32fns.c (w32_default_color_map): New function,
4271 extracted from Fw32_default_color_map.
4272 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
4273
4274 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
4275
4276 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
4277
4278 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
4279
4280 * keyboard.c (test_undefined): New function (bug#9751).
4281 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
4282
4283 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
4284
4285 * sysdep.c (init_sys_modes): Fix the check for the controlling
4286 terminal (Bug#6649).
4287
4288 2011-10-20 Eli Zaretskii <eliz@gnu.org>
4289
4290 * dispextern.h (struct bidi_it): New member next_en_type.
4291
4292 * bidi.c (bidi_line_init): Initialize the next_en_type member.
4293 (bidi_resolve_explicit_1): When next_en_pos is valid for the
4294 current character, check also for next_en_type being WEAK_EN.
4295 (bidi_resolve_weak): Don't enter the expensive loop if the current
4296 position is before next_en_pos. Record the bidi type of the first
4297 non-ET, non-BN character we find, in addition to its position.
4298 (bidi_level_of_next_char): Invalidate next_en_type when
4299 next_en_pos is over-stepped.
4300
4301 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
4302
4303 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
4304 * editfns.c: Rewrite current-time-zone so that it invokes
4305 the equivalent of (format-time-string "%Z") to get the time zone name.
4306 This fixes a bug when the time zone name contains characters that
4307 need converting from the system time locale to Emacs internal format.
4308 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
4309 that patch fixed format-time-string to do the conversion, but
4310 I forgot to fix current-time-zone.
4311 (format_time_string): New function, containing most of
4312 what Fformat_time_string used to contain.
4313 (Fformat_time_string): Rewrite in terms of format_time_string.
4314 This doesn't change this function's behavior.
4315 (current-time-zone): Rewrite to use format_time_string.
4316 This fixes the bug reported by Michael Schierl in
4317 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
4318 Jason Rumney's 2007-06-07 change worked around this bug, but
4319 didn't fix it.
4320 * systime.h (tzname, timezone): Remove no-longer-used declarations.
4321
4322 2011-10-19 Eli Zaretskii <eliz@gnu.org>
4323
4324 * xdisp.c (start_display): If the character at POS is displayed
4325 via a display vector, reset IT->current.dpvec_index to zero.
4326 (try_window_reusing_current_matrix): If a line ends in a display
4327 vector or the next line starts in a display vector, continue
4328 redrawing the window even though the character position of
4329 start_row was reached.
4330 (Bug#9771, part 2)
4331
4332 2011-10-18 Chong Yidong <cyd@gnu.org>
4333
4334 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
4335 with nobreak-char-display too.
4336
4337 2011-10-18 Eli Zaretskii <eliz@gnu.org>
4338
4339 Fix part 3 of bug#9771.
4340 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
4341 (bidi_resolve_neutral): Don't enter the expensive loop looking for
4342 non-neutral characters if the current character is a paragraph
4343 separator (a.k.a. Newline). This avoids running the same
4344 expensive loop twice, once when we consume the preceding newline
4345 and the other time when the line actually needs to be displayed.
4346 Avoid the loop when we see neutrals on the base embedding level
4347 following a character whose directionality is the same as the
4348 paragraph's. This avoids running the expensive loop when a line
4349 ends in a long sequence of neutrals, like control characters.
4350 Add assertion against STRONG_AL type. Slightly rearrange code
4351 that determines the type of a neutral given the first non-neutral
4352 that follows it.
4353 (bidi_level_of_next_char): Set next_en_pos to zero when
4354 invalidating its info.
4355
4356 2011-10-17 Eli Zaretskii <eliz@gnu.org>
4357
4358 * xdisp.c (push_display_prop): Determine whether to record string
4359 or buffer position by IT->string, not by IT->method. Allow
4360 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
4361 (move_it_vertically_backward): Don't look for character position
4362 immediately after the newline when in a continuation line.
4363 (Bug#9771, part 1)
4364
4365 2011-10-15 Martin Rudalics <rudalics@gmx.at>
4366
4367 * window.c (coordinates_in_window): Rewrite and delabelize
4368 vertical border check. (Bug#5357) (Bug#9618)
4369
4370 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
4371
4372 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
4373 errors in XSetWindowBorder (bug#9310).
4374
4375 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
4376
4377 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
4378 avoid crash when xmalloc overrun checking is enabled.
4379
4380 2011-10-13 Eli Zaretskii <eliz@gnu.org>
4381
4382 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
4383 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
4384 cursor motion with <left> and <right> arrow keys.
4385
4386 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
4387 some callers set that themselves.
4388
4389 2011-10-12 Eli Zaretskii <eliz@gnu.org>
4390
4391 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
4392 display string and the previous row comes from the same string and
4393 is empty. (Bug#9739) (Bug#9738)
4394
4395 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
4396
4397 * doc.c (get_doc_string): Encode file name (bug#9735).
4398
4399 2011-10-12 Eli Zaretskii <eliz@gnu.org>
4400
4401 * bidi.c (bidi_level_of_next_char):
4402 * xdisp.c (get_visually_first_element): Remove old incorrect
4403 comments regarding the Unicode Line Separator character.
4404
4405 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
4406
4407 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
4408
4409 * alloc.c (Fgc_status): Do not access beyond zombies array
4410 boundary if nzombies > MAX_ZOMBIES.
4411 * alloc.c (dump_zombies): Add missing format specifier.
4412
4413 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
4414
4415 * xdisp.c (set_cursor_from_row): Simplify conditionals,
4416 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
4417
4418 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
4419 Some packages use them to denote characters with modifiers.
4420
4421 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
4422
4423 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
4424 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
4425 matching a pp-number. Rename parameter var to var1.
4426
4427 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
4428
4429 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
4430
4431 2011-10-08 Glenn Morris <rgm@gnu.org>
4432
4433 * callint.c (Fcall_interactively): Give a more explicit error for the
4434 'c' case with a non-character input. (Bug#8479)
4435
4436 2011-10-08 Eli Zaretskii <eliz@gnu.org>
4437
4438 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
4439 lines.
4440 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
4441 lines that are hscrolled on the left.
4442
4443 * dispnew.c (buffer_posn_from_coords): Account for a possible
4444 presence of header-line. (Bug#4426)
4445
4446 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
4447
4448 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
4449 Don't advertise functionality which we discourage or doesn't work.
4450
4451 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
4452
4453 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
4454 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
4455 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
4456 this makes Emacs dump core during garbage collection on rare
4457 occasions. sizeof is obviously inferior to offsetof here, so
4458 stick with offsetof.
4459 (GC_POINTER_ALIGNMENT): New macro.
4460 (mark_memory): Omit 3rd (offset) arg; caller changed.
4461 Don't assume EMACS_INT alignment is the same as pointer alignment.
4462
4463 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
4464
4465 * keyboard.c (read_key_sequence_remapped): New var.
4466 (read_key_sequence): Compute remapping in the right buffer.
4467 (command_loop_1): Use read_key_sequence's remapping directly.
4468
4469 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
4470
4471 * dired.c (file_name_completion): Don't expand file name.
4472 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
4473 before checking file name handler.
4474
4475 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
4476 they've been requested explicitly (bug#9591).
4477
4478 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
4479
4480 * keymap.c (Fsingle_key_description): Use make_specified_string
4481 instead of build_string to build string from push_key_description.
4482 (Bug#5193)
4483
4484 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4485
4486 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
4487 This fixes a Y2038 bug on 64-bit hosts.
4488 * buffer.c (reset_buffer):
4489 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
4490 (Fclear_buffer_auto_save_failure):
4491 Use 0, not -1, to represent an unset failure time, since time_t
4492 might not be signed.
4493
4494 Remove dependency on glibc malloc internals.
4495 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4496 Move back here from lisp.h, but with their new implementations.
4497 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4498 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
4499 * charset.c (charset_table_init): New static var.
4500 (syms_of_charset): Use it instead of xmalloc. This removes a
4501 dependency on glibc malloc internals. See Eli Zaretskii's comment in
4502 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
4503 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4504 Move back to alloc.c.
4505 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4506 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
4507
4508 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
4509
4510 * nsterm.m (windowDidResize): Call x_set_window_size only when
4511 ns_in_resize is true. Otherwise set pixelwidth/height and
4512 call change_frame_size (Bug#9628).
4513
4514 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4515
4516 Port --enable-checking=all to Fedora 14 x86-64.
4517 * charset.c (syms_of_charset): Also account for glibc malloc's
4518 internal overhead when calculating the initial malloc maximum.
4519
4520 Port --enable-checking=all to Fedora 14 x86.
4521 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4522 Move to lisp.h.
4523 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
4524 (overrun_check_realloc, overrun_check_free):
4525 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
4526 That way, xmalloc returns a properly-aligned pointer even if
4527 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
4528 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
4529 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
4530 into account when calculating the initial malloc maximum.
4531 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4532 Move here from alloc.c, so that charset.c can use it too.
4533 Properly align; the old code wasn't right for common 32-bit hosts
4534 when configured with --enable-checking=all.
4535 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4536 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
4537
4538 2011-09-29 Eli Zaretskii <eliz@gnu.org>
4539
4540 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
4541 use EDOM.
4542
4543 2011-09-28 Eli Zaretskii <eliz@gnu.org>
4544
4545 * xdisp.c (compute_display_string_end): If there's no display
4546 string at CHARPOS, return -1.
4547
4548 * bidi.c (bidi_fetch_char): When compute_display_string_end
4549 returns a negative value, treat the character as a normal
4550 character not covered by a display string. (Bug#9624)
4551
4552 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
4553
4554 * lread.c (Fread_from_string): Fix typo in docstring.
4555
4556 2011-09-27 Eli Zaretskii <eliz@gnu.org>
4557
4558 * xdisp.c (handle_invisible_prop): If invisible text ends on a
4559 newline, reseat the iterator instead of bidi-iterating there one
4560 character at a time. (Bug#9610)
4561 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
4562 TO_CHARPOS if the bidi iterator is at base embedding level.
4563
4564 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
4565
4566 * lread.c (readevalloop): Use correct code for NBSP.
4567 (read1): Likewise. (Bug#9608)
4568
4569 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
4570
4571 * dbusbind.c (Fdbus_register_signal): When service is not
4572 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
4573
4574 2011-09-25 Glenn Morris <rgm@gnu.org>
4575
4576 * buffer.c (truncate-lines): Doc fix.
4577
4578 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
4579
4580 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
4581 (Fset_window_next_buffers): Doc fix.
4582
4583 2011-09-24 Glenn Morris <rgm@gnu.org>
4584
4585 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
4586
4587 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
4588
4589 Fix minor problems found by static checking.
4590 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
4591 * indent.c (Fvertical_motion): Fix == vs = typo.
4592
4593 2011-09-24 Eli Zaretskii <eliz@gnu.org>
4594
4595 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
4596 Default value is now t. Doc fix.
4597
4598 * indent.c (Fvertical_motion): Compute and apply the overshoot
4599 logic when moving up, not only when moving down. Fix the
4600 confusing name and values of the it_overshoot_expected variable;
4601 logic changes accordingly. (Bug#9254) (Bug#9549)
4602
4603 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
4604 CHARPOS is covered by a display string which includes newlines.
4605 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
4606 is covered by a display string with embedded newlines.
4607
4608 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
4609
4610 * dbusbind.c (Fdbus_register_signal): Add match rule to
4611 Vdbus_registered_objects_table. (Bug#9581)
4612 (Fdbus_register_method, Vdbus_registered_objects_table):
4613 Fix docstring.
4614
4615 2011-09-24 Jim Meyering <meyering@redhat.com>
4616
4617 do not ignore write error for any output size
4618 The previous change was incomplete.
4619 While it makes emacs --batch detect the vast majority of stdout
4620 write failures, errors were still ignored whenever the output size is
4621 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
4622 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
4623 && echo FAIL: ignored write error
4624 FAIL: ignored write error
4625 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
4626 && echo FAIL: ignored write error
4627 FAIL: ignored write error
4628 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
4629
4630 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
4631
4632 * emacs.c (Fkill_emacs): In noninteractive mode exit
4633 non-successfully if a write error occurred on stdout. (Bug#9574)
4634
4635 2011-09-21 Eli Zaretskii <eliz@gnu.org>
4636
4637 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
4638 the xassert test.
4639
4640 * dispextern.h (struct it): Update the comment documenting what
4641 can it->OBJECT be.
4642
4643 2011-09-20 Eli Zaretskii <eliz@gnu.org>
4644
4645 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
4646 a display string, extend search for cursor position to end of row.
4647 (find_row_edges): If the row ends in a newline from a display
4648 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
4649 Handle the case of a display string with multiple newlines.
4650 (Fcurrent_bidi_paragraph_direction): Fix search for previous
4651 non-empty line. Fixes confusing cursor motion with arrow keys at
4652 the beginning of a line that starts with whitespace.
4653
4654 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4655
4656 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
4657 (bug#9493).
4658
4659 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
4660
4661 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
4662 boolean (Bug#9154).
4663
4664 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4665
4666 * xdisp.c (display_line): Record maximum and minimum buffer
4667 positions even if no glyphs were produced (e.g., by a zero-width
4668 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
4669 buffer positions that will be removed from the glyph row because
4670 they don't fit.
4671 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
4672 column is beyond frame width: don't subtract 1 "pixel" when
4673 computing width of the stretch.
4674 (reseat_at_next_visible_line_start): Undo the change made on
4675 2011-09-17 that saved paragraph information and restored it after
4676 the call to `reseat'. (Bug#9545)
4677
4678 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4679
4680 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
4681 and turn window cursor on if cleared (Bug#9415).
4682
4683 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
4684
4685 * search.c (boyer_moore): Take unibyte characters from pattern
4686 literally. (Bug#9458)
4687
4688 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4689
4690 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
4691
4692 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
4693
4694 Fix minor problem found by static checking.
4695 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
4696 initialized, to pacify gcc -Wuninitialized.
4697
4698 * fileio.c: Report proper errno when syscall falls.
4699 (Finsert_file_contents): Save and restore errno,
4700 so that report_file_error outputs the correct diagnostic.
4701 (Fwrite_region) [CLASH_DETECTION]: Likewise.
4702
4703 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4704
4705 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
4706
4707 2011-09-17 Eli Zaretskii <eliz@gnu.org>
4708
4709 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
4710 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
4711
4712 2011-09-17 Eli Zaretskii <eliz@gnu.org>
4713
4714 * xdisp.c (reseat_at_next_visible_line_start): Keep information
4715 about the current paragraph and restore it after the call to reseat.
4716
4717 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
4718 (bidi_find_paragraph_start): Search back for paragraph beginning
4719 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
4720 (bidi_move_to_visually_next): Only trigger paragraph-related
4721 computations when the last character is a newline or at EOB, not
4722 just any NEUTRAL_B. (Bug#9470)
4723
4724 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
4725 truncated lines if point is covered by a display string. (Bug#9524)
4726
4727 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
4728
4729 * xselect.c: Relax test for outgoing X longs (Bug#9498).
4730 (cons_to_x_long): New function.
4731 (lisp_data_to_selection_data): Use it. Correct the test for
4732 short-versus-long data; it was negated. Break out of vector
4733 loop, for efficiency, when a long datum is discovered.
4734
4735 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
4736
4737 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
4738
4739 2011-09-16 Eli Zaretskii <eliz@gnu.org>
4740
4741 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
4742 GCC PR/17406) by declaring this function with external scope.
4743
4744 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4745
4746 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
4747 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
4748
4749 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
4750
4751 * editfns.c (Fformat): Correctly handle text properties on "%%".
4752
4753 2011-09-15 Eli Zaretskii <eliz@gnu.org>
4754
4755 * xterm.c (x_draw_composite_glyph_string_foreground):
4756 * w32term.c (x_draw_composite_glyph_string_foreground):
4757 * term.c (encode_terminal_code):
4758 * composite.c (composition_update_it, get_composition_id):
4759 * xdisp.c (get_next_display_element)
4760 (fill_composite_glyph_string): Add comments about special meaning
4761 of TAB characters in a composition.
4762
4763 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4764
4765 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4766 This occurs when processing a multibyte format.
4767 Problem reported by Wolfgang Jenker.
4768
4769 2011-09-15 Johan Bockgård <bojohan@gnu.org>
4770
4771 * xdisp.c (try_cursor_movement): Only check for exact match if
4772 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
4773
4774 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4775
4776 Remove unused external symbols.
4777 * dispextern.h (calc_pixel_width_or_height): Remove decl.
4778 * xdisp.c (calc_pixel_width_or_height): Now static.
4779 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
4780 * indent.c (check_display_width):
4781 * w32term.c: Fix comment to match code.
4782 * xterm.c, xterm.h (x_catching_errors): Remove.
4783
4784 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4785
4786 * xselect.c: Use signed conversions more consistently (Bug#9498).
4787 (selection_data_to_lisp_data): Assume incoming selection data are
4788 signed integers, not unsigned. This is to be consistent with
4789 outgoing selection data, which was modified to use signed integers
4790 in as part of the fix to Bug#9196 in response to Jan D.'s comment
4791 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
4792 expects long, not unsigned long.
4793
4794 2011-09-14 Eli Zaretskii <eliz@gnu.org>
4795
4796 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
4797 computation of loop end. Reported by Johan Bockgård
4798 <bojohan@gnu.org>.
4799
4800 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
4801
4802 * frame.c (Fother_visible_frames_p): Function deleted.
4803
4804 2011-09-12 Eli Zaretskii <eliz@gnu.org>
4805
4806 * indent.c (compute_motion): Process display vector front to back
4807 rather than the other way around. (Bug#2496)
4808
4809 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
4810
4811 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
4812
4813 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
4814
4815 * minibuf.c (Fread_from_minibuffer): Doc fix.
4816
4817 2011-09-11 Eli Zaretskii <eliz@gnu.org>
4818
4819 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
4820 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
4821
4822 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4823
4824 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
4825 value for non-existent files.
4826
4827 2011-09-11 Eli Zaretskii <eliz@gnu.org>
4828
4829 * fileio.c (Finsert_file_contents): If the file cannot be opened,
4830 set its "size" to -1. This will set the modtime_size field of
4831 the corresponding buffer to -1, which is what
4832 verify-visited-file-modtime expects for files that do not exist.
4833 (Bug#9139)
4834
4835 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
4836
4837 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
4838 here ...
4839 * lisp.h: ... from here. push_key_description is no longer
4840 defined in keyboard.c, so its declaration should not be in
4841 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
4842 logically belongs with push_key_description.
4843
4844 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
4845
4846 * buffer.h: Include <sys/types.h> instead of <time.h>.
4847 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
4848 Problem reported by Herbert J. Skuhra.
4849
4850 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
4851
4852 * xml.c (parse_region): Make the parsing work for
4853 non-comment-starting XML files again (bug#9144).
4854
4855 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
4856
4857 * image.c (gif_load): Fix calculation of bottom and right corner.
4858 (Bug#9468)
4859
4860 2011-09-10 Eli Zaretskii <eliz@gnu.org>
4861
4862 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
4863 redisplay in small windows.
4864
4865 2011-09-09 Eli Zaretskii <eliz@gnu.org>
4866
4867 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
4868
4869 2011-09-08 Martin Rudalics <rudalics@gmx.at>
4870
4871 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
4872 Operate on live windows only.
4873
4874 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
4875
4876 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
4877
4878 2011-09-07 Eli Zaretskii <eliz@gnu.org>
4879
4880 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
4881 only under bidi iteration.
4882
4883 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
4884
4885 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
4886
4887 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4888
4889 isnan: Fix porting problem to Solaris 10 with bundled gcc.
4890 Without this fix, the command to link temacs failed due to an
4891 undefined symbol __builtin_isnan. This is because
4892 /usr/include/iso/math_c99.h #defines isnan(x) to
4893 __builtin_isnan(x), but the bundled gcc, which identifies itself
4894 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
4895 a __builtin_isnan.
4896 * floatfns.c (isnan): #undef, and then #define to a clone of
4897 what's in data.c.
4898 (Fisnan): Always define, since it's always available now.
4899 (syms_of_floatfns): Always define isnan at the Lisp level.
4900
4901 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4902
4903 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
4904
4905 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4906
4907 * fileio.c: Fix bugs with large file offsets (Bug#9428).
4908 The previous code assumed that file offsets (off_t values) fit in
4909 EMACS_INT variables, which is not true on typical 32-bit hosts.
4910 The code messed up by falsely reporting buffer overflow in cases
4911 such as (insert-file-contents "big" nil 1 2) into an empty buffer
4912 when "big" contains more than 2**29 bytes, even though this
4913 inserts just one byte and does not overflow the buffer.
4914 (Finsert_file_contents): Store file offsets as off_t
4915 values, not as EMACS_INT values. Check for overflow when
4916 converting between EMACS_INT and off_t. When checking for
4917 buffer overflow or for overlap, take the offsets into account.
4918 Don't use EMACS_INT for small values where int suffices.
4919 When checking for overlap, fix a typo: ZV was used where
4920 ZV_BYTE was intended.
4921 (Fwrite_region): Don't assume off_t fits into 'long'.
4922 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
4923
4924 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
4925
4926 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
4927
4928 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4929
4930 sprintf-related integer and memory overflow issues (Bug#9412).
4931
4932 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
4933 (esprintf, exprintf, evxprintf): New functions.
4934 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
4935 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
4936 (modify_event_symbol): Do not assume that the length of
4937 name_alist_or_stem is safe to alloca and fits in int.
4938 (Fexecute_extended_command): Likewise for function name and binding.
4939 (Frecursion_depth): Wrap around reliably on integer overflow.
4940 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
4941 since some callers pass EMACS_INT values.
4942 (Fsingle_key_description): Don't crash if symbol name contains more
4943 than MAX_ALLOCA bytes.
4944 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
4945 (get_minibuffer): Arg is now EMACS_INT, not int.
4946 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
4947 (esprintf, exprintf, evxprintf): New decls.
4948 * window.h (command_loop_level, minibuf_level): Reflect API changes.
4949
4950 * dbusbind.c (signature_cat): New function.
4951 (xd_signature, Fdbus_register_signal):
4952 Do not overrun buffer; instead, report string overflow.
4953
4954 * dispnew.c (add_window_display_history): Don't overrun buffer.
4955 Truncate instead; this is OK since it's just a log.
4956
4957 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
4958 even if the time zone offset is outlandishly large.
4959 Don't mishandle offset == INT_MIN.
4960
4961 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
4962 when creating daemon; the previous buffer-overflow check was incorrect.
4963
4964 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
4965 which has the guts of the old verror function.
4966
4967 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
4968 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
4969
4970 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
4971 (font_unparse_xlfd): Don't blindly alloca long strings.
4972 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
4973 fits in int, when using sprintf. Use single snprintf to count
4974 length of string rather than counting it via multiple sprintfs;
4975 that's simpler and more reliable.
4976 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
4977 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
4978 sprintf, in case result does not fit in int.
4979
4980 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
4981 (fontset_from_font): Print it.
4982
4983 * frame.c (tty_frame_count): Now printmax_t, not int.
4984 (make_terminal_frame, set_term_frame_name): Print it.
4985 (x_report_frame_params): In X, window IDs are unsigned long,
4986 not signed long, so print them as unsigned.
4987 (validate_x_resource_name): Check for implausibly long names,
4988 and don't assume name length fits in 'int'.
4989 (x_get_resource_string): Don't blindly alloca invocation name;
4990 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
4991 not fit in int.
4992
4993 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
4994 (xg_check_special_colors, xg_set_geometry):
4995 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
4996
4997 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
4998 Use esprintf, not sprintf, in case result does not fit in int.
4999
5000 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5001 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
5002 it as a large positive number.
5003 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
5004 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5005
5006 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
5007 in case result does not fit in int.
5008
5009 * print.c (float_to_string): Detect width overflow more reliably.
5010 (print_object): Make sprintf buffer a bit bigger, to avoid potential
5011 buffer overrun. Don't assume list length fits in 'int'. Treat
5012 print length of 0 as 0, not as infinity; to be consistent with other
5013 uses of print length in this function. Don't overflow print length
5014 index. Don't assume hash table size fits in 'long', or that
5015 vectorlike size fits in 'unsigned long'.
5016
5017 * process.c (make_process): Use printmax_t, not int, to format
5018 process-name gensyms.
5019
5020 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
5021
5022 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
5023 to avoid potential buffer overrun.
5024
5025 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
5026 if X resource line is longer than 512 bytes.
5027
5028 * xfns.c (x_window): Make sprintf buffer a bit bigger
5029 to avoid potential buffer overrun.
5030
5031 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
5032
5033 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
5034
5035 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5036
5037 Integer overflow fixes for scrolling, etc.
5038 Without these, Emacs silently mishandles large integers sometimes.
5039 For example, "C-u 4294967297 M-x recenter" was treated as if
5040 it were "C-u 1 M-x recenter" on a typical 64-bit host.
5041
5042 * xdisp.c (try_window_id): Check Emacs fixnum range before
5043 converting to 'int'.
5044
5045 * window.c (window_scroll_line_based, Frecenter):
5046 Check that an Emacs fixnum is in range before assigning it to 'int'.
5047 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
5048 values converted from Emacs fixnums.
5049 (Frecenter): Don't wrap around a line count if it is out of 'int'
5050 range; instead, treat it as an extreme value.
5051 (Fset_window_configuration, compare_window_configurations):
5052 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
5053
5054 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
5055 that can exceed INT_MAX. Check that EMACS_INT value is in range
5056 before assigning it to the (possibly-narrower) index.
5057 (match_limit): Don't assume that a fixnum can fit in 'int'.
5058
5059 * print.c (print_object): Use ptrdiff_t, not int, for index that can
5060 exceed INT_MAX.
5061
5062 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
5063 (Fvertical_motion): Don't wrap around LINES values that don't fit
5064 in 'int'. Instead, treat them as extreme values. This is good
5065 enough for windows, which can't have more than INT_MAX lines anyway.
5066
5067 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5068
5069 * Require libxml/parser.h to avoid compilation warning.
5070
5071 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
5072
5073 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
5074 since this reportedly can destroy thread storage.
5075
5076 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
5077
5078 * syntax.c (find_defun_start): Update all cache variables if
5079 exiting early (Bug#9401).
5080
5081 2011-08-30 Eli Zaretskii <eliz@gnu.org>
5082
5083 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
5084
5085 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
5086 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
5087 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
5088
5089 * term.c (tty_append_glyph): New function.
5090 (produce_stretch_glyph): Static function and its prototype deleted.
5091
5092 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
5093 Add prototypes.
5094
5095 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
5096
5097 * image.c (parse_image_spec): Check for nonnegative, not for positive,
5098 when checking :margin (Bug#9390).
5099 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
5100 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
5101 so that the name doesn't mislead. All uses changed.
5102
5103 2011-08-28 Johan Bockgård <bojohan@gnu.org>
5104
5105 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
5106 set_tty_hooks.
5107
5108 2011-08-27 Eli Zaretskii <eliz@gnu.org>
5109
5110 * xdisp.c (move_it_to): Don't bail out early when reaching
5111 position beyond to_charpos, if we are scanning backwards.
5112 (move_it_vertically_backward): When DY == 0, make sure we get to
5113 the first character in the line after the newline.
5114
5115 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
5116
5117 * ccl.c: Improve and simplify overflow checking (Bug#9196).
5118 (ccl_driver): Do not generate an out-of-range pointer.
5119 (Fccl_execute_on_string): Remove unnecessary check for
5120 integer overflow, noted by Stefan Monnier in
5121 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
5122 Remove a FIXME that didn't need fixing.
5123 Simplify the newly-introduced buffer reallocation code.
5124
5125 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
5126
5127 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
5128
5129 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
5130
5131 Integer and memory overflow issues (Bug#9196).
5132
5133 * doc.c (get_doc_string): Rework so that
5134 get_doc_string_buffer_size is the actual buffer size, rather than
5135 being 1 less than the actual buffer size; this makes xpalloc more
5136 convenient.
5137
5138 * image.c (x_allocate_bitmap_record, cache_image):
5139 * xselect.c (Fx_register_dnd_atom):
5140 Simplify previous changes by using xpalloc.
5141
5142 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
5143 since either will do and ptrdiff_t is convenient with xpalloc.
5144
5145 * charset.c (charset_table_size)
5146 (struct charset_sort_data.priority): Now ptrdiff_t.
5147 (charset_compare): Don't overflow if priorities differ greatly.
5148 (Fsort_charsets): Don't assume list length fits in int.
5149 Check for size-calculation overflow when allocating sort data.
5150 (syms_of_charset): Allocate an initial charset table that is
5151 just under 64 KiB, to avoid problems with glibc malloc and mmap.
5152
5153 * cmds.c (internal_self_insert): Check for size-calculation overflow.
5154
5155 * composite.h (struct composition.glyph_len): Now int, not unsigned.
5156 The actual value is always <= INT_MAX, and leaving it unsigned made
5157 overflow checking harder.
5158
5159 * dispextern.h (struct glyph_matrix.rows_allocated)
5160 (struct face_cache.size): Now ptrdiff_t, for convenience in use
5161 with xpalloc. The values are still always <= INT_MAX.
5162
5163 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
5164
5165 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
5166 (SAFE_NALLOCA): New macro.
5167
5168 * region-cache.c (struct boundary.pos, find_cache_boundary)
5169 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
5170 (set_cache_region, invalidate_region_cache)
5171 (revalidate_region_cache, know_region_cache, region_cache_forward)
5172 (region_cache_backward, pp_cache):
5173 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
5174 so that ptrdiff_t * can be passed to xpalloc.
5175 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
5176 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
5177 (pp_cache): Don't assume cache_len fits in int.
5178 * region-cache.h: Adjust extern decls to match.
5179
5180 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
5181 EMACS_INT, since either will do, for xpalloc.
5182
5183 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
5184 (xnmalloc, xnrealloc, xpalloc): New functions.
5185
5186 * bidi.c (bidi_shelve_header_size): New constant.
5187 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
5188 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
5189
5190 * bidi.c (bidi_cache_shrink):
5191 * buffer.c (overlays_at, overlays_in, record_overlay_string)
5192 (overlay_strings):
5193 Don't update size of array until after memory allocation succeeds,
5194 because xmalloc/xrealloc may not return.
5195 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
5196 now that we have proper integer overflow checking.
5197 (record_overlay_string, overlay_strings): Catch overflows when
5198 calculating size of overlay_str_buf.
5199
5200 * callproc.c (Fcall_process): Check for size overflow when
5201 calculating size of args2.
5202 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
5203 Normally we prefer signed values, but sticking with ptrdiff_t would
5204 require adding more-complicated checks.
5205
5206 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
5207 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
5208 Redo buffer-overflow calculations to avoid integer overflow.
5209 Add a FIXME comment where memory seems to be over-allocated.
5210
5211 * character.c (Fstring): Check for size-calculation overflow.
5212
5213 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
5214 unnecessary integer overflow. Check for size overflow.
5215 (encode_coding_object): Don't update size until xmalloc succeeds.
5216
5217 * composite.c (get_composition_id): Check for overflow in glyph
5218 length calculations.
5219
5220 Integer and memory overflow fixes for display code.
5221 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
5222 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
5223 (scrolling_window): Check for overflow in size calculations.
5224 (line_draw_cost, realloc_glyph_pool, add_row_entry):
5225 Don't assume glyph table len fits in int.
5226 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
5227 (row_table_size): Now ptrdiff_t, not int.
5228 (scrolling_window): Avoid overflow in size calculations.
5229 Don't update size until allocation succeeds.
5230 * fns.c (concat): Check for overflow in size calculations.
5231 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
5232 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5233 (NEXT_ALMOST_PRIME_LIMIT): New constant.
5234
5235 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
5236 (get_doc_string): Check for size calculation overflow.
5237 Don't update size until allocation succeeds.
5238 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
5239 EMACS_INT, where ptrdiff_t will do.
5240 (Fsubstitute_command_keys): Check for string overflow.
5241
5242 * editfns.c (set_time_zone_rule): Don't assume environment length
5243 fits in int.
5244 (message_length): Now ptrdiff_t, not int.
5245 (Fmessage_box): Don't update size until allocation succeeds.
5246 Don't assume message length fits in int.
5247 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
5248
5249 * emacs.c (main): Do not reallocate argv, since there is a null at
5250 the end that can be overwritten, and this way there's no need to
5251 worry about size-calculation overflow.
5252 (sort_args): Check for size-calculation overflow.
5253
5254 * eval.c (init_eval_once, grow_specpdl): Don't update size until
5255 alloc succeeds.
5256 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
5257
5258 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
5259 (x_set_scroll_bar_width, x_figure_window_size):
5260 Check for integer overflow.
5261 (x_set_alpha): Do not assume XINT fits in int.
5262
5263 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
5264 This is for the members text_lines, text_cols, total_lines, total_cols,
5265 where the system imposes an 'int' limit.
5266
5267 * fringe.c (Fdefine_fringe_bitmap):
5268 Don't update size until alloc works.
5269
5270 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
5271 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
5272
5273 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
5274 Check for size-calculation overflow.
5275 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
5276 do, as we prefer signed integers.
5277 (id_to_widget.max_size, id_to_widget.used)
5278 (xg_store_widget_in_map, xg_remove_widget_from_map)
5279 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
5280 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
5281 Use and return ptrdiff_t, not int.
5282 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
5283 * gtkutil.h: Change prototypes to match the above.
5284
5285 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
5286 are duplicate now that they've been promoted to lisp.h.
5287 (x_allocate_bitmap_record, x_alloc_image_color)
5288 (make_image_cache, cache_image, xpm_load):
5289 Don't update size until alloc is done.
5290 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
5291 (x_detect_edges):
5292 Check for size calculation overflow.
5293 (ct_colors_allocated_max): New constant.
5294 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
5295 overflow.
5296
5297 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
5298 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
5299 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
5300 Use ptrdiff_t, not int, to count maps.
5301 (read_char_minibuf_menu_prompt): Check for overflow in size
5302 calculations. Don't update size until allocation succeeds.
5303 Redo calculations to avoid overflow.
5304 * keyboard.h: Change prototypes to match the above.
5305
5306 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
5307 to count maps.
5308 (current_minor_maps): Check for size calculation overflow.
5309 * keymap.h: Change prototypes to match the above.
5310
5311 * lread.c (read1, init_obarray): Don't update size until alloc done.
5312
5313 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
5314 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
5315
5316 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
5317 Now ptrdiff_t, not int.
5318 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
5319 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
5320
5321 * process.c (Fnetwork_interface_list): Check for overflow
5322 in size calculation.
5323
5324 * region-cache.c (move_cache_gap): Check for size calculation overflow.
5325
5326 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
5327 overflow. Don't bother calling xmalloc when xrealloc will do.
5328
5329 * search.c (Freplace_match): Check for size calculation overflow.
5330 (Fset_match_data): Don't assume list lengths fit in 'int'.
5331
5332 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
5333 for command line length. Do not attempt to address one before the
5334 beginning of an array, as that's not portable.
5335
5336 * term.c (max_frame_lines): Remove; unused.
5337 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
5338 not int.
5339 (encode_terminal_code, calculate_costs): Check for size
5340 calculation overflow.
5341 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
5342 table lengths and related sizes. Don't update size until alloc
5343 done. Redo calculations to avoid overflow.
5344 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
5345
5346 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
5347 subtracting pointers.
5348 (gobble_line): Check for overflow more carefully. Don't update size
5349 until alloc done.
5350
5351 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
5352 Don't update size until alloc done.
5353 Redo size calculations to avoid overflow.
5354 Check for size calculation overflow.
5355 (main) [DEBUG]: Fix typo in invoking tparam1.
5356
5357 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
5358 Use ptrdiff_t, not int, for sizes.
5359 (store_mode_line_noprop_char): Don't update size until alloc done.
5360
5361 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
5362 Use ptrdiff_t, not int, for sizes.
5363 (Finternal_make_lisp_face, cache_face):
5364 Check for size calculation overflow.
5365 (cache_face): Treat size calculation overflows as if they were
5366 memory exhaustion (the usual treatment), rather than aborting.
5367
5368 * xfns.c (x_encode_text, x_set_name_internal)
5369 (Fx_change_window_property): Use ptrdiff_t, not int, to count
5370 sizes, since they can exceed INT_MAX in size. Check for size
5371 calculation overflow.
5372
5373 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
5374 (xg_select): Check for size calculation overflow.
5375 Don't update size until alloc done.
5376
5377 * xrdb.c (get_environ_db): Don't assume path length fits in int,
5378 as sprintf is limited to int lengths.
5379
5380 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
5381 (X_LONG_MIN): New macros.
5382 Use them to make the following changes clearer.
5383 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
5384 This change doesn't affect the value now, but it may help remind
5385 future maintainers not to raise the value too much later.
5386 (SELECTION_QUANTUM): Remove, replacing with ...
5387 (selection_quantum): ... new function, which avoids overflow.
5388 All uses changed.
5389 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
5390 assumption that selection length fits in 'int'.
5391 (x_reply_selection_request, x_handle_selection_request)
5392 (x_get_window_property, receive_incremental_selection)
5393 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
5394 (lisp_data_to_selection_data, clean_local_selection_data):
5395 Use ptrdiff_t, not int, to record length of selection.
5396 (x_reply_selection_request, x_get_window_property)
5397 (receive_incremental_selection, x_property_data_to_lisp):
5398 Redo calculations to avoid overflow.
5399 (x_reply_selection_request): When sending hint, ceiling it at
5400 X_LONG_MAX rather than relying on wraparound overflow to send
5401 something.
5402 (x_get_window_property, receive_incremental_selection)
5403 (lisp_data_to_selection_data, x_property_data_to_lisp):
5404 Check for size-calculation overflow.
5405 (x_get_window_property, receive_incremental_selection)
5406 (lisp_data_to_selection_data, Fx_register_dnd_atom):
5407 Don't store size until memory allocation succeeds.
5408 (x_get_window_property): Plug memory leak on memory exhaustion.
5409 Don't double-block input; malloc is safe here. Don't assume 2**34
5410 - 4 fits in unsigned long. Add an xassert to check
5411 XGetWindowProperty overflow. Be more careful about overflow
5412 calculations, and distinguish size from memory overflow better.
5413 (receive_incremental_selection): When tracing, don't assume
5414 unsigned int is less than INT_MAX.
5415 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
5416 harmful) conversions of unsigned short to int.
5417 (lisp_data_to_selection_data): Don't assume that integers
5418 in the range -65535 through -1 fit in an X unsigned short.
5419 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
5420 result parameters unless successful. Rely on cons_to_unsigned
5421 to report problems with elements; the old code wasn't right anyway.
5422 (x_check_property_data): Check for int overflow; we cannot use
5423 a wider type due to X limits.
5424 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
5425
5426 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
5427
5428 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
5429 (x_term_init): Check for size calculation overflow.
5430 (x_color_cells): Don't store size until memory allocation succeeds.
5431 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
5432 Don't assume alloca size is less than MAX_ALLOCA.
5433 (x_term_init): Don't assume length fits in int (sprintf is limited
5434 to int size).
5435
5436 Use ptrdiff_t for composition IDs.
5437 * character.c (lisp_string_width):
5438 * composite.c (composition_table_size, n_compositions)
5439 (get_composition_id, composition_gstring_from_id):
5440 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
5441 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
5442 * window.c (Frecenter):
5443 Use ptrdiff_t, not int, for composition IDs.
5444 * composite.c (get_composition_id): Check for integer overflow.
5445 * composite.h: Adjust prototypes to match the above changes.
5446
5447 Use ptrdiff_t for hash table indexes.
5448 * category.c (hash_get_category_set):
5449 * ccl.c (ccl_driver):
5450 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
5451 * coding.c (coding_system_charset_list, detect_coding_system):
5452 * coding.h (struct coding_system.id):
5453 * composite.c (get_composition_id, gstring_lookup_cache):
5454 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
5455 * image.c (xpm_get_color_table_h):
5456 * lisp.h (hash_lookup, hash_put):
5457 * minibuf.c (Ftest_completion):
5458 Use ptrdiff_t for hash table indexes, not int (which is too
5459 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
5460 32-bit --with-wide-int hosts).
5461
5462 * charset.c (Fdefine_charset_internal): Check for integer overflow.
5463 Add a FIXME comment about memory leaks.
5464 (syms_of_charset): Don't assume xmalloc returns.
5465
5466 Don't assume that stated character widths fit in int.
5467 * character.c (Fchar_width, c_string_width, lisp_string_width):
5468 * character.h (CHAR_WIDTH):
5469 * indent.c (MULTIBYTE_BYTES_WIDTH):
5470 Use sanitize_char_width to avoid undefined and/or bad behavior
5471 with outlandish widths.
5472 * character.h (sanitize_tab_width): Rename from sanitize_width,
5473 now that we have two such functions. All uses changed.
5474 (sanitize_char_width): New inline function.
5475
5476 Don't assume that tab-width fits in int.
5477 * character.h (sanitize_width): New inline function.
5478 (SANE_TAB_WIDTH): New macro.
5479 (ASCII_CHAR_WIDTH): Use it.
5480 * indent.c (sane_tab_width): Remove. All uses replaced by
5481 SANE_TAB_WIDTH (current_buffer).
5482 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
5483
5484 * fileio.c: Integer overflow issues with file modes.
5485 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
5486
5487 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
5488 Remove unreachable code.
5489 (read_hex, load_charset_map_from_file): Check for integer overflow.
5490
5491 * xterm.c: Don't go over XClientMessageEvent limit.
5492 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
5493 (x_send_scroll_bar_event): Likewise. Check that the size does not
5494 exceed limits imposed by XClientMessageEvent, as well as the usual
5495 ptrdiff_t and size_t limits.
5496
5497 * keyboard.c: Overflow, signedness and related fixes.
5498 (make_lispy_movement): Use same integer type in forward decl
5499 that is used in the definition.
5500 (read_key_sequence, keyremap_step):
5501 Change bufsize argument back to int, undoing my 2011-03-30 change.
5502 We prefer signed types, and int is wide enough here.
5503 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
5504 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
5505 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
5506 length, not size_t. Use ptrdiff_t for index, not int.
5507 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
5508 possibility of integer overflow.
5509
5510 Overflow, signedness and related fixes for images.
5511
5512 * dispextern.h (struct it.stack[0].u.image.image_id)
5513 (struct_it.image_id, struct image.id, struct image_cache.size)
5514 (struct image_cache.used, struct image_cache.ref_count):
5515 * gtkutil.c (update_frame_tool_bar):
5516 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
5517 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
5518 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
5519 * nsmenu.m (update_frame_tool_bar):
5520 * xdisp.c (calc_pixel_width_or_height):
5521 * xfns.c (image_cache_refcount):
5522 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
5523 on typical 64-bit hosts.
5524
5525 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5526 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
5527 Omit unnecessary casts to int.
5528 (parse_image_spec): Check that integers fall into 'int' range
5529 when the callers expect that.
5530 (image_ascent): Redo ascent calculation to avoid int overflow.
5531 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
5532 (lookup_image): Remove unnecessary tests.
5533 (xbm_image_p): Locals are now of int, not EMACS_INT,
5534 since parse_image_check makes sure they fit into int.
5535 (png_load, gif_load, svg_load_image):
5536 Prefer int to unsigned where either will do.
5537 (tiff_handler): New function, combining the cores of the
5538 old tiff_error_handler and tiff_warning_handler.
5539 This function is rewritten to use vsnprintf and thereby avoid
5540 stack buffer overflows. It uses only the features of vsnprintf
5541 that are common to both POSIX and native Microsoft.
5542 (tiff_error_handler, tiff_warning_handler): Use it.
5543 (tiff_load, gif_load, imagemagick_load_image):
5544 Don't assume :index value fits in 'int'.
5545 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
5546 (imagemagick_load_image): Check that crop parameters fit into
5547 the integer types that MagickCropImage accepts. Don't assume
5548 Vimagemagick_render_type has a nonnegative value. Don't assume
5549 size_t fits in 'long'.
5550 (gs_load): Use printmax_t to print the widest integers possible.
5551 Check for integer overflow when computing image height and width.
5552
5553 2011-08-26 Eli Zaretskii <eliz@gnu.org>
5554
5555 * xdisp.c (redisplay_window): Don't force window start if point
5556 will be invisible in the resulting window. (Bug#9324)
5557
5558 2011-08-25 Eli Zaretskii <eliz@gnu.org>
5559
5560 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
5561 the display spec is of the form `(space ...)'.
5562 (handle_display_spec): Return the value returned by
5563 handle_single_display_spec, not just 1 or zero.
5564 (handle_single_display_spec): If the display spec is of the form
5565 `(space ...)', and specifies display in the text area, return 2
5566 rather than 1.
5567 (try_cursor_movement): Check for the need to scroll more
5568 accurately, and prefer exact match for point under bidi.
5569 Don't advance `row' beyond the last row of the window.
5570
5571 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
5572 into disp_prop; all users changed.
5573
5574 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
5575 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
5576 for the text covered by the display property.
5577
5578 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
5579
5580 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
5581 Change return value to nil.
5582 (Frecord_buffer): Delete unused function.
5583
5584 2011-08-24 Eli Zaretskii <eliz@gnu.org>
5585
5586 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
5587 buffers, return left-to-right.
5588 (set_cursor_from_row): Consider candidate row a win if its glyph
5589 represents a newline and point is on that newline. Fixes cursor
5590 positioning on the newline at EOL of R2L text within L2R
5591 paragraph, and vice versa.
5592 (try_cursor_movement): Check continued rows, in addition to
5593 continuation rows. Fixes unwarranted scroll when point enters a
5594 continued line of R2L text within an L2R paragraph, or vice versa.
5595 (cursor_row_p): Consider the case of point being equal to
5596 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
5597 from the end of a short line to the beginning of a continued line
5598 of R2L text within L2R paragraph.
5599 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
5600 composed characters.
5601
5602 * bidi.c (bidi_check_type): Use xassert.
5603 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
5604 members.
5605
5606 2011-08-23 Eli Zaretskii <eliz@gnu.org>
5607
5608 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
5609 a character.
5610
5611 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
5612
5613 * nsfont.m (ns_otf_to_script): Fix typo.
5614
5615 2011-08-22 Kenichi Handa <handa@m17n.org>
5616
5617 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
5618 extra slot even if the purpose is char-code-property-table.
5619
5620 2011-08-23 Eli Zaretskii <eliz@gnu.org>
5621
5622 * xdisp.c (redisplay_window): When computing centering_position,
5623 account for the height of the header line. (Bug#8874)
5624
5625 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
5626 instead of CHAR_TO_BYTE. Fixes a crash when a completion
5627 candidate is selected by the mouse, and that candidate has a
5628 composed character under the mouse.
5629
5630 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
5631 coordinates reported by pos-visible-in-window-p for a composed
5632 character in column zero.
5633
5634 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
5635
5636 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
5637
5638 2011-08-22 Eli Zaretskii <eliz@gnu.org>
5639
5640 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
5641 consider it a hit if to_charpos is anywhere in the range of the
5642 composed buffer positions.
5643
5644 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
5645
5646 * image.c (gif_load): Don't assume that each subimage has the same
5647 dimensions as the base image. Handle disposal method that is
5648 "undefined" by the gif spec (Bug#9335).
5649
5650 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
5651
5652 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
5653 (Fcondition_case): Document `debug' symbol in error handler.
5654
5655 2011-08-19 Eli Zaretskii <eliz@gnu.org>
5656
5657 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
5658 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
5659 from an Org mode buffer to a Speedbar frame.
5660
5661 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
5662 a composition, take its buffer position from IT->cmp_it.charpos.
5663 Fixes cursor positioning at the beginning of a line that begins
5664 with a composed character.
5665
5666 2011-08-18 Eli Zaretskii <eliz@gnu.org>
5667
5668 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
5669 character bidirectional type, use STRONG_L instead. Fixes crashes
5670 in a buffer produced by `describe-categories'.
5671
5672 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
5673 members before the level stack, so they would be saved and
5674 restored when copying iterator state. Fixes incorrect reordering
5675 around TABs covered by display properties.
5676
5677 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
5678
5679 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
5680
5681 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
5682
5683 * eval.c (internal_condition_case, internal_condition_case_1)
5684 (internal_condition_case_2, internal_condition_case_n):
5685 Remove unnecessary aborts (Bug#9081).
5686
5687 2011-08-17 Eli Zaretskii <eliz@gnu.org>
5688
5689 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
5690 has no `load' handler, try opening the file locally. (Bug#9311)
5691
5692 2011-08-16 Ken Brown <kbrown@cornell.edu>
5693
5694 * gmalloc.c: Expand comment.
5695
5696 2011-08-16 Eli Zaretskii <eliz@gnu.org>
5697
5698 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
5699 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
5700
5701 2011-08-16 Ken Brown <kbrown@cornell.edu>
5702
5703 Fix memory allocation problems in Cygwin build (Bug#9273).
5704
5705 * unexcw.c ( __malloc_initialized): Declare external variable.
5706 (fixup_executable): Force the dumped emacs to reinitialize malloc.
5707
5708 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
5709 New variables.
5710 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
5711 dumped emacs.
5712 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
5713 in the static heap.
5714 [CYGWIN] (special_realloc): New function.
5715 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
5716 requests to realloc storage in the static heap.
5717
5718 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
5719
5720 * bidi.c (bidi_initialize): Remove unused local.
5721
5722 2011-08-15 Eli Zaretskii <eliz@gnu.org>
5723
5724 * bidimirror.h:
5725 * biditype.h: Remove file.
5726 * makefile.w32-in ($(BLD)/bidi.$(O)):
5727 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
5728
5729 * dispextern.h: Fix a typo in the comment to bidi_type_t.
5730
5731 * chartab.c: Improve commentary for the uniprop_table API.
5732
5733 * bidi.c (bidi_paragraph_init): Support zero value of
5734 bidi_ignore_explicit_marks_for_paragraph_level.
5735 (bidi_initialize): Use uniprop_table instead of including
5736 biditype.h and bidimirror.h.
5737
5738 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
5739 coordinates of the iterator when restoring from ppos_it.
5740 (Bug#9296)
5741
5742 2011-08-14 Kenichi Handa <handa@m17n.org>
5743
5744 * process.c (create_process): Call setup_process_coding_systems
5745 after the pid of the process is set to -1 (Bug#8162).
5746
5747 2011-08-14 Eli Zaretskii <eliz@gnu.org>
5748
5749 * xdisp.c (move_it_in_display_line_to): Don't invoke
5750 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
5751 ppos_it. Fixes vertical cursor motion when line beginning is
5752 covered by an image. (Bug#9296)
5753
5754 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
5755
5756 * nsterm.h (ns_run_ascript): Declare.
5757 (NSAPP_DATA2_RUNASSCRIPT): Define.
5758
5759 * nsfns.m (as_script, as_result, as_status): New static variables.
5760 (ns_run_ascript): New function.
5761 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
5762 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
5763 the event loop. Get status from as_status (Bug#7276).
5764
5765 * nsterm.m (sendEvent): If event is NSApplicationDefined and
5766 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
5767 the event loop (Bug#7276).
5768
5769 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
5770
5771 * gnutls.c (QCgnutls_bootprop_priority)
5772 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
5773 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
5774 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
5775 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
5776 (QCgnutls_bootprop_verify_hostname_error)
5777 (QCgnutls_bootprop_callbacks_verify): Rename from
5778 Qgnutls_bootprop_..., all uses changed.
5779
5780 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
5781 uses changed.
5782
5783 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
5784
5785 * xfaces.c (Qframe_set_background_mode): Now static.
5786 * dispextern.h (Qframe_set_background_mode): Remove decl.
5787
5788 * process.c (Fnetwork_interface_info): Declare local only if needed.
5789
5790 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
5791
5792 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
5793 (Fnetwork_interface_list): Allocate in increments of bytes instead
5794 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
5795 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
5796 sockaddr.
5797 (struct ifflag_def): notrailers is smart on OSX.
5798 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
5799 Get hardware address with getifaddrs if available.
5800
5801 2011-08-12 Eli Zaretskii <eliz@gnu.org>
5802
5803 * xdisp.c (iterate_out_of_display_property): xassert that
5804 IT->position is set to within IT->object's boundaries. Break from
5805 the loop as soon as EOB is reached; avoids infloops in redisplay
5806 when IT->position is set up wrongly due to some bug.
5807 Set IT->current to match the bidi iterator unconditionally.
5808 (push_display_prop): Allow GET_FROM_STRING as IT->method on
5809 entry. Force push_it to save on the stack the current
5810 buffer/string position, to be restored by pop_it. Fix flags in
5811 the iterator structure wrt the object coming from a display
5812 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
5813 properties. (Bug#9284)
5814
5815 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
5816
5817 * fontset.c (fontset_get_font_group): Add proper type checks.
5818 (Bug#9172)
5819
5820 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5821
5822 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
5823 and LC_VERSION_MIN_MACOSX.
5824 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
5825 (dump_it) [LC_FUNCTION_STARTS]: Use it.
5826
5827 2011-08-08 Eli Zaretskii <eliz@gnu.org>
5828
5829 * xdisp.c (forward_to_next_line_start): Allow to use the
5830 no-display-properties-and-no-overlays under bidi display.
5831 Set disp_pos in the bidi iterator to avoid searches for display
5832 properties and overlays.
5833
5834 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
5835
5836 * editfns.c (Fset_time_zone_rule): Document relationship with the
5837 setenv function.
5838
5839 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
5840 the font entity extracted from the cache (Bug#8109).
5841
5842 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
5843
5844 * composite.c (autocmp_chars): Don't reset point. That is done by
5845 restore_point_unwind (Bug#5984).
5846
5847 2011-08-07 Juri Linkov <juri@jurta.org>
5848
5849 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
5850 to show the arg `TIME' instead of `TIMEVAL'.
5851
5852 2011-08-06 Eli Zaretskii <eliz@gnu.org>
5853
5854 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
5855 display property strides EOL and includes a newline, as in
5856 longlines-mode. (Bug#9254)
5857 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
5858 word-wrap under bidirectional display. (Bug#9224)
5859
5860 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
5861 is non-zero, even if the data buffer is NULL. Fixes a crash in
5862 vertical-motion with longlines-mode. (Bug#9254)
5863
5864 2011-08-05 Eli Zaretskii <eliz@gnu.org>
5865
5866 * bidi.c <bidi_cache_total_alloc>: Now static.
5867 (bidi_initialize): Initialize bidi_cache_total_alloc.
5868
5869 * xdisp.c (display_line): Release buffer allocated for shelved bidi
5870 cache. (Bug#9221)
5871
5872 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
5873 amount allocated this far in `bidi_cache_total_alloc'.
5874 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
5875 non-zero, only free the data buffer without restoring the cache
5876 contents. All callers changed.
5877
5878 * dispextern.h (bidi_unshelve_cache): Update prototype.
5879
5880 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
5881 (move_it_in_display_line, move_it_to)
5882 (move_it_vertically_backward, move_it_by_lines): Replace the call
5883 to xfree to an equivalent call to bidi_unshelve_cache.
5884 (move_it_in_display_line_to): Fix logic of returning
5885 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
5886
5887 2011-08-05 Eli Zaretskii <eliz@gnu.org>
5888
5889 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
5890 came from a string character with a `cursor' property. (Bug#9229)
5891
5892 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5893
5894 * Makefile.in (LIB_PTHREAD): New variable.
5895 (LIBES): Add LIB_PTHREAD (Bug#9216).
5896
5897 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
5898 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
5899
5900 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
5901
5902 * regex.c (re_iswctype): Remove some redundant boolean conversions.
5903
5904 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5905
5906 * xterm.c (x_find_topmost_parent): New function.
5907 (x_set_frame_alpha): Find topmost parent window with
5908 x_find_topmost_parent and set the property there also (bug#9181).
5909 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
5910
5911 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
5912
5913 * callproc.c (Fcall_process): Avoid vfork clobbering
5914 the local vars buffer, coding_systems, current_dir.
5915
5916 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
5917
5918 * keymap.c (Fmake_composed_keymap): Move to subr.el.
5919
5920 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
5921
5922 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
5923 so that it is not optimized away.
5924
5925 * xdisp.c (compute_display_string_pos): Remove unused local.
5926
5927 2011-08-02 Eli Zaretskii <eliz@gnu.org>
5928
5929 Fix slow cursor motion and scrolling in large buffers with
5930 selective display, like Org Mode buffers. (Bug#9218)
5931
5932 * dispextern.h (struct bidi_it): New member disp_prop_p.
5933
5934 * xdisp.c: Remove one-slot cache of display string positions.
5935 (compute_display_string_pos): Accept an additional argument
5936 DISP_PROP_P; callers changed. Scan at most 5K characters forward
5937 for a display string or property. If found, set DISP_PROP_P
5938 non-zero.
5939
5940 * bidi.c (bidi_fetch_char): Accept an additional argument
5941 DISP_PROP_P, and pass it to compute_display_string_pos.
5942 Only handle text covered by a display string if DISP_PROP_P is returned
5943 non-zero. All callers of bidi_fetch_char changed.
5944
5945 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
5946
5947 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
5948
5949 2010-12-03 Don March <don@ohspite.net>
5950
5951 * keymap.c (Fdefine_key): Fix non-prefix key error message when
5952 last character M-[char] is translated to ESC [char] (bug#7541).
5953
5954 2011-08-02 Kenichi Handa <handa@m17n.org>
5955
5956 * lisp.h (uniprop_table): Extern it.
5957
5958 * chartab.c (uniprop_table): Make it non-static.
5959
5960 2011-08-01 Eli Zaretskii <eliz@gnu.org>
5961
5962 * xdisp.c (forward_to_next_line_start): Accept additional argument
5963 BIDI_IT_PREV, and store into it the state of the bidi iterator had
5964 on the newline.
5965 (reseat_at_next_visible_line_start): Use the bidi iterator state
5966 returned by forward_to_next_line_start to restore the state of
5967 it->bidi_it after backing up to previous newline. (Bug#9212)
5968
5969 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
5970
5971 * regex.c (re_comp): Protoize.
5972 (re_exec): Fix return type.
5973 (regexec): Fix type of `ret'. (Bug#9203)
5974
5975 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5976
5977 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
5978 This is needed if max-image-size is a floating-point number.
5979
5980 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5981
5982 * print.c (print_object): Print empty symbol as ##.
5983
5984 * lread.c (read1): Read ## as empty symbol.
5985
5986 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5987
5988 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
5989 setting frame foreground color (Bug#9175).
5990 (x_set_background_color): Likewise.
5991
5992 * nsmenu.m (-setText): Size tooltip dimensions precisely to
5993 contents (Bug#9176).
5994 (EmacsTooltip -init): Remove bezels and add shadows to
5995 tooltip windows.
5996
5997 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
5998 or scroll bar (Bug#8470).
5999
6000 * nsfont.m (nsfont_open): Remove assignment to voffset and
6001 unnecessary vars hshink, expand, hd, full_height, min_height.
6002 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
6003
6004 * nsterm.h (nsfont_info): Remove voffset field.
6005
6006 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6007
6008 Implement strike-through and overline on NextStep (Bug#8863).
6009
6010 * nsfont.m (nsfont_open): Use underline position provided by font,
6011 instead of hard-coded value of 2.
6012 (nsfont_draw): Call ns_draw_text_decoration instead.
6013
6014 * nsterm.h: Add declaration for ns_draw_text_decoration.
6015
6016 * nsterm.m (ns_draw_text_decoration): New function for drawing
6017 underline, overline, and strike-through.
6018 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
6019 ns_draw_text_decoration. Change treatment of cursor drawing to
6020 accommodate underlining, etc.
6021
6022 2011-07-28 Eli Zaretskii <eliz@gnu.org>
6023
6024 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
6025 default.
6026
6027 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6028
6029 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
6030 Without this fix, if a signal arrives just after memory fills up,
6031 'malloc' might be invoked reentrantly.
6032
6033 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
6034 In other words, assume that every image size is allowed, on non-X
6035 hosts. This assumption is probably wrong, but it lets Emacs compile.
6036
6037 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6038
6039 * regex.c (re_iswctype): Convert return values to boolean.
6040
6041 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
6042
6043 * xdisp.c (compute_display_string_pos): Don't use cached display
6044 string position if the buffer had its restriction changed.
6045 (Bug#9184)
6046
6047 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6048
6049 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6050
6051 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6052
6053 Integer signedness and overflow and related fixes. (Bug#9079)
6054
6055 * bidi.c: Integer size and overflow fixes.
6056 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
6057 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
6058 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6059 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
6060 (bidi_find_other_level_edge):
6061 Use ptrdiff_t instead of EMACS_INT where either will do.
6062 This works better on 32-bit hosts configured --with-wide-int.
6063 (bidi_cache_ensure_space): Check for size-calculation overflow.
6064 Use % rather than repeated addition, for better worst-case speed.
6065 Don't set bidi_cache_size until after xrealloc returns, because it
6066 might not return.
6067 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
6068 (bidi_cache_ensure_space): Also check that the bidi cache size
6069 does not exceed that of the largest Lisp string or buffer. See Eli
6070 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
6071
6072 * alloc.c (__malloc_size_t): Remove.
6073 All uses replaced by size_t. See Andreas Schwab's note
6074 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
6075
6076 * image.c: Improve checking for integer overflow.
6077 (check_image_size): Assume that f is nonnull, since
6078 it is always nonnull in practice. This is one less thing to
6079 worry about when checking for integer overflow later.
6080 (x_check_image_size): New function, which checks for integer
6081 overflow issues inside X.
6082 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
6083 This removes the need for a memory_full check.
6084 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
6085 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
6086 (xbm_read_bitmap_data): Change locals back to 'int', since
6087 their values must fit in 'int'.
6088 (xpm_load_image, png_load, tiff_load):
6089 Invoke x_create_x_image_and_pixmap earlier,
6090 to avoid much needless work if the image is too large.
6091 (tiff_load): Treat overly large images as if
6092 x_create_x_image_and_pixmap failed, not as malloc failures.
6093 (gs_load): Use x_check_image_size.
6094
6095 * gtkutil.c: Omit integer casts.
6096 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
6097 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
6098
6099 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
6100
6101 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
6102 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
6103 would wrongly return t on a 64-bit host.
6104
6105 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
6106 The plain *_OVERFLOW macros run afoul of GCC bug 49705
6107 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
6108 and therefore cause GCC to emit a bogus diagnostic in some cases.
6109
6110 * image.c: Integer signedness and overflow and related fixes.
6111 This is not an exhaustive set of fixes, but it's time to
6112 record what I've got.
6113 (lookup_pixel_color, check_image_size): Remove redundant decls.
6114 (check_image_size): Don't assume that arbitrary EMACS_INT values
6115 fit in 'int', or that arbitrary 'double' values fit in 'int'.
6116 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
6117 (tiff_load, imagemagick_load_image):
6118 Check for overflow in size calculations.
6119 (x_create_x_image_and_pixmap): Remove unnecessary test for
6120 xmalloc returning NULL; that can't happen.
6121 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
6122 (xpm_color_bucket): Use better integer hashing function.
6123 (xpm_cache_color): Don't possibly over-allocate memory.
6124 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
6125 (gif_memory_source):
6126 Use ptrdiff_t, not int or size_t, to record sizes.
6127 (png_load): Don't assume values greater than 2**31 fit in 'int'.
6128 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
6129 either works, as we prefer signed integers.
6130 (tiff_read_from_memory, tiff_write_from_memory):
6131 Return tsize_t, not size_t, since that's what the TIFF API wants.
6132 (tiff_read_from_memory): Don't fail simply because the read would
6133 go past EOF; instead, return a short read.
6134 (tiff_load): Omit no-longer-needed casts.
6135 (Fimagemagick_types): Don't assume size fits into 'int'.
6136
6137 Improve hashing quality when configured --with-wide-int.
6138 * fns.c (hash_string): New function, taken from sxhash_string.
6139 Do not discard information about ASCII character case; this
6140 discarding is no longer needed.
6141 (sxhash-string): Use it. Change sig to match it. Caller changed.
6142 * lisp.h: Declare it.
6143 * lread.c (hash_string): Remove, since we now use fns.c's version.
6144 The fns.c version returns a wider integer if --with-wide-int is
6145 specified, so this should help the quality of the hashing a bit.
6146
6147 * emacs.c: Integer overflow minor fix.
6148 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
6149 Define only if GNU_LINUX.
6150 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
6151
6152 * dispnew.c: Integer signedness and overflow fixes.
6153 Remove unnecessary forward decls, that were a maintenance hassle.
6154 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
6155 All uses changed.
6156 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
6157 (scrolling_window): Use ptrdiff_t, not int, for byte count.
6158 (prepare_desired_row, line_draw_cost):
6159 Use int, not unsigned, where either works.
6160 (save_current_matrix, restore_current_matrix):
6161 Use ptrdiff_t, not size_t, where either works.
6162 (init_display): Check for overflow more accurately, and without
6163 relying on undefined behavior.
6164
6165 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
6166 Remove, replacing with the new symbols in lisp.h. All uses changed.
6167 * fileio.c (make_temp_name):
6168 * filelock.c (lock_file_1, lock_file):
6169 * xdisp.c (message_dolog):
6170 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
6171 Use pMd etc. instead.
6172 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
6173 replacing the pWIDE etc. symbols removed from editfns.c.
6174
6175 * keyboard.h (num_input_events): Now uintmax_t.
6176 This is (very slightly) less likely to mess up due to wraparound.
6177 All uses changed.
6178
6179 * buffer.c: Integer signedness fixes.
6180 (alloc_buffer_text, enlarge_buffer_text):
6181 Use ptrdiff_t rather than size_t when either will do, as we prefer
6182 signed integers.
6183
6184 * alloc.c: Integer signedness and overflow fixes.
6185 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
6186 (__malloc_size_t): Default to size_t, not to int.
6187 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
6188 (Fgarbage_collect, mark_object_loop_halt, mark_object):
6189 Prefer ptrdiff_t to size_t when either would do, as we prefer
6190 signed integers.
6191 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
6192 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
6193 Now const. Initialize with values that are in range even if char
6194 is signed.
6195 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
6196 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
6197 These functions do the right thing with sizes > 2**32.
6198 (check_depth): Now ptrdiff_t, not int.
6199 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
6200 Adjust to new way of storing sizes. Check for size overflow bugs
6201 in rest of code.
6202 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
6203 slightly wrong anyway, as it missed one instance of
6204 XMALLOC_OVERRUN_CHECK_OVERHEAD.
6205 (refill_memory_reserve): Omit needless cast to size_t.
6206 (mark_object_loop_halt): Mark as externally visible.
6207
6208 * xselect.c: Integer signedness and overflow fixes.
6209 (Fx_register_dnd_atom, x_handle_dnd_message):
6210 Use ptrdiff_t, not size_t, since we prefer signed.
6211 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
6212 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
6213 x_dnd_atoms_size and x_dnd_atoms_length.
6214
6215 * doprnt.c: Prefer signed to unsigned when either works.
6216 * eval.c (verror):
6217 * doprnt.c (doprnt):
6218 * lisp.h (doprnt):
6219 * xdisp.c (vmessage):
6220 Use ptrdiff_t, not size_t, when using or implementing doprnt,
6221 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
6222 prefer signed arithmetic to avoid comparison confusion.
6223 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
6224 but is a bit tricky.
6225
6226 Assume freestanding C89 headers, string.h, stdlib.h.
6227 * data.c, doprnt.c, floatfns.c, print.c:
6228 Include float.h unconditionally.
6229 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
6230 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
6231 * regex.c: Likewise for stddef.h, string.h.
6232 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
6233 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
6234 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
6235 (STDC_HEADERS): Remove obsolete defines.
6236 * sysdep.c: Include limits.h unconditionally.
6237
6238 Assume support for memcmp, memcpy, memmove, memset.
6239 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
6240 * regex.c (memcmp, memcpy):
6241 Remove; we assume C89 now.
6242
6243 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
6244 (__malloc_safe_bcopy): Remove; no longer needed.
6245
6246 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6247 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
6248 well either way, and we prefer signed to unsigned.
6249
6250 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
6251
6252 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
6253 closes the connection while we're reading (bug#9182).
6254
6255 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
6256
6257 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
6258 are specified (Bug#9168).
6259
6260 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
6261
6262 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
6263 Found by GCC static checking and --with-wide-int on a 32-bit host.
6264
6265 2011-07-25 Eli Zaretskii <eliz@gnu.org>
6266
6267 * xdisp.c (compute_display_string_pos): Fix logic of caching
6268 previous display string position. Initialize cached_prev_pos to
6269 -1. Fixes slow-down at the beginning of a buffer.
6270
6271 2011-07-24 Eli Zaretskii <eliz@gnu.org>
6272
6273 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
6274 for attrs[LFACE_FONTSET_INDEX].
6275
6276 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
6277
6278 * xml.c (parse_region): Remove unused local
6279 that was recently introduced.
6280
6281 2011-07-23 Eli Zaretskii <eliz@gnu.org>
6282
6283 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
6284 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
6285
6286 * xdisp.c (move_it_in_display_line_to): Record the best matching
6287 position for TO_CHARPOS while scanning the line, and restore it on
6288 exit if none of the characters scanned was an exact match.
6289 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
6290 when exact match is impossible due to invisible text, and the
6291 lines are truncated.
6292
6293 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
6294
6295 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
6296 for OSX >= 10.7.
6297
6298 2011-07-22 Eli Zaretskii <eliz@gnu.org>
6299
6300 Fix a significant slow-down of cursor motion with C-n, C-p,
6301 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
6302 auto-repeat under bidi redisplay in fontified buffers.
6303 * xdisp.c (compute_stop_pos_backwards): New function.
6304 (next_element_from_buffer): Call compute_stop_pos_backwards to
6305 find a suitable prev_stop when we find ourselves before
6306 base_level_stop.
6307 (reseat): Don't look for prev_stop, as that could mean a very long
6308 run.
6309 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
6310 <cached_disp_overlay_modiff>: Cache for last found display string
6311 position.
6312 (compute_display_string_pos): Return the cached position if asked
6313 about the same buffer in the same area of character positions, and
6314 the buffer wasn't changed since the time the display string
6315 position was cached.
6316
6317 2011-07-22 Eli Zaretskii <eliz@gnu.org>
6318
6319 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
6320 is an integer, which is important for empty lines. (Bug#9149)
6321
6322 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
6323
6324 * frame.c (Fmodify_frame_parameters): In tty case, update the
6325 default face if necessary (Bug#4238).
6326
6327 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
6328
6329 * editfns.c (Fstring_to_char): No need to explain what a character
6330 is in the docstring (Bug#6576).
6331
6332 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6333
6334 * xml.c (parse_region): Make sure we always return a tree.
6335
6336 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
6337
6338 * xml.c (parse_region): If a document contains only comments,
6339 return that, too.
6340
6341 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6342
6343 * xml.c (make_dom): Return comments, too.
6344
6345 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
6346
6347 Port to OpenBSD.
6348 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
6349 and the surrounding thread.
6350 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
6351 rather than fgets, and retry after EINTR. Otherwise, 'emacs
6352 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
6353 timer goes off.
6354 * s/openbsd.h (BROKEN_SIGIO): Define.
6355 * unexelf.c (unexec) [__OpenBSD__]:
6356 Don't update the .mdebug section of the Alpha COFF symbol table.
6357
6358 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6359
6360 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
6361 (bug#8460).
6362
6363 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
6364
6365 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
6366 This fixes some race conditions on the permissions of any newly
6367 created file.
6368
6369 * alloc.c (valid_pointer_p): Use pipe, not open.
6370 This fixes some permissions issues when debugging.
6371
6372 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
6373 If fchown fails to set both uid and gid, try to set just gid,
6374 as that is sometimes allowed. Adjust the file's mode to eliminate
6375 setuid or setgid bits that are inappropriate if fchown fails.
6376
6377 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
6378
6379 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
6380 to compare Lisp_Objects.
6381 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
6382 global_gnutls_log_level, don't mistake it for a Lisp_Object.
6383 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
6384
6385 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
6386
6387 * lread.c (read_integer): Unread even EOF character.
6388 (read1): Likewise. Properly record start position of symbol.
6389
6390 * lread.c (read1): Read `#:' as empty uninterned symbol if no
6391 symbol character follows.
6392
6393 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
6394
6395 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
6396 This works around a problem with the previous change to Fcopy_file.
6397 Recent glibc declares fchown with __attribute__((warn_unused_result)),
6398 and without this change, GCC might complain about discarding
6399 fchown's return value.
6400
6401 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
6402
6403 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
6404
6405 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
6406
6407 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
6408
6409 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
6410
6411 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
6412 it's used from the C level.
6413
6414 * process.c: Use the same condition for POLL_FOR_INPUT in both
6415 keyboard.c and process.c (bug#1858).
6416
6417 2011-07-09 Lawrence Mitchell <wence@gmx.li>
6418
6419 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
6420 (Fgnutls_boot): Use it.
6421
6422 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
6423
6424 * doc.c (Fsubstitute_command_keys): Revert last change.
6425
6426 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
6427
6428 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
6429 quotes the next character, and doesn't affect other longer
6430 sequences (bug#8935).
6431
6432 * lread.c (syms_of_lread): Clarify that is isn't only
6433 `eval-buffer' and `eval-defun' that's affected by
6434 `lexical-binding' (bug#8460).
6435
6436 2011-07-15 Eli Zaretskii <eliz@gnu.org>
6437
6438 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6439 bidi redisplay when a line includes both an image and is truncated.
6440
6441 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
6442
6443 Fix minor problems found by static checking.
6444 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
6445 (elsz): Now a signed constant, not a size_t var. We prefer signed
6446 types to unsigned, to avoid integer comparison confusion. Without
6447 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
6448 "cannot optimize loop, the loop counter may overflow", a symptom
6449 of the confusion.
6450 * indent.c (Fvertical_motion): Mark locals as initialized.
6451 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
6452
6453 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6454
6455 * search.c (Fre_search_backward): Mention `case-fold-search' in
6456 all the re_search_* functions (bug#8138).
6457
6458 * keyboard.c (Fopen_dribble_file): Document when the file is
6459 closed (bug#8056).
6460
6461 2011-07-14 Eli Zaretskii <eliz@gnu.org>
6462
6463 * bidi.c (bidi_dump_cached_states): Fix format of displaying
6464 bidi_cache_idx.
6465
6466 Support bidi reordering of display and overlay strings.
6467 * xdisp.c (compute_display_string_pos)
6468 (compute_display_string_end): Accept additional argument STRING.
6469 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
6470 (reseat_to_string): Initialize bidi_it->string.s and
6471 bidi_it->string.schars.
6472 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
6473 NULL (avoids a crash in bidi_paragraph_init).
6474 Initialize itb.string.lstring.
6475 (init_iterator): Call bidi_init_it only of a valid
6476 buffer position was specified. Initialize paragraph_embedding to
6477 L2R.
6478 (reseat_to_string): Initialize the bidi iterator.
6479 (display_string): If we need to ignore text properties of
6480 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
6481 original value of -1 will not work with bidi.)
6482 (compute_display_string_pos): First arg is now struct
6483 `text_pos *'; all callers changed. Support display properties on
6484 Lisp strings.
6485 (compute_display_string_end): Support display properties on Lisp
6486 strings.
6487 (init_iterator, reseat_1, reseat_to_string): Initialize the
6488 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
6489 when iterating on a string not from display properties).
6490 (compute_display_string_pos, compute_display_string_end):
6491 Fix calculation of the object to scan. Fixes an error when using
6492 arrow keys.
6493 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
6494 base_level_stop; instead, set base_level_stop to BEGV.
6495 Fixes crashes in vertical-motion.
6496 (next_element_from_buffer): Improve commentary for when
6497 the iterator is before prev_stop.
6498 (init_iterator): Initialize bidi_p from the default value of
6499 bidi-display-reordering, not from buffer-local value. Use the
6500 buffer-local value only if initializing for buffer iteration.
6501 (handle_invisible_prop): Support invisible properties on strings
6502 that are being bidi-reordered.
6503 (set_iterator_to_next): Support bidi reordering of C strings and
6504 Lisp strings.
6505 (next_element_from_string): Support bidi reordering of Lisp
6506 strings.
6507 (handle_stop_backwards): Support Lisp strings as well.
6508 (display_string): Support display of R2L glyph rows.
6509 Use IT_STRING_CHARPOS when displaying from a Lisp string.
6510 (init_iterator): Don't initialize it->bidi_p for strings
6511 here.
6512 (reseat_to_string): Initialize it->bidi_p for strings here.
6513 (next_element_from_string, next_element_from_c_string)
6514 (next_element_from_buffer): Add xassert's for correspondence
6515 between IT's object being iterated and it->bidi_it.string
6516 structure.
6517 (face_before_or_after_it_pos): Support bidi iteration.
6518 (next_element_from_c_string): Handle the case of the first string
6519 character that is not the first one in the visual order.
6520 (get_visually_first_element): New function, refactored from common
6521 parts of next_element_from_buffer, next_element_from_string, and
6522 next_element_from_c_string.
6523 (tool_bar_lines_needed, redisplay_tool_bar)
6524 (display_menu_bar): Force left-to-right direction. Add a FIXME
6525 comment for making that be controlled by a user option.
6526 (push_it, pop_it): Save and restore the state of the
6527 bidi iterator. Save and restore the bidi_p flag.
6528 (pop_it): Iterate out of display property for string iteration as
6529 well.
6530 (iterate_out_of_display_property): Support iteration over strings.
6531 (handle_single_display_spec): Set up it->bidi_it for iteration
6532 over a display string, and call bidi_init_it.
6533 (handle_single_display_spec, next_overlay_string)
6534 (get_overlay_strings_1, push_display_prop): Set up the bidi
6535 iterator for displaying display or overlay strings.
6536 (forward_to_next_line_start): Don't use the shortcut if
6537 bidi-iterating.
6538 (back_to_previous_visible_line_start): If handle_display_prop
6539 pushed the iterator stack, restore the internal state of the bidi
6540 iterator by calling bidi_pop_it same number of times.
6541 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
6542 and we are bidi-iterating, don't decrement the iterator position;
6543 instead, set the first_elt flag in the bidi iterator, to produce
6544 the same effect.
6545 (reseat_1): Remove redundant setting of string_from_display_prop_p.
6546 (push_display_prop): xassert that we are iterating a buffer.
6547 (push_it, pop_it): Save and restore paragraph_embedding member.
6548 (handle_single_display_spec, next_overlay_string)
6549 (get_overlay_strings_1, reseat_1, reseat_to_string)
6550 (push_display_prop): Set up the `unibyte' member of bidi_it.string
6551 correctly. Don't assume unibyte strings are not bidi-reordered.
6552 (compute_display_string_pos)
6553 (compute_display_string_end): Fix handling the case of C string.
6554 (push_it, pop_it): Save and restore from_disp_prop_p.
6555 (handle_single_display_spec, push_display_prop): Set the
6556 from_disp_prop_p flag.
6557 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
6558 (pop_it): Call iterate_out_of_display_property only if we are
6559 popping after iteration over a string that came from a display
6560 property. Fix a typo in popping stretch info. Add an assertion
6561 for verifying that the iterator position is in sync with the bidi
6562 iterator.
6563 (handle_single_display_spec, get_overlay_strings_1)
6564 (push_display_prop): Fix initialization of paragraph direction for
6565 string when that of the parent object is not yet determined.
6566 (reseat_1): Call bidi_init_it to resync the bidi
6567 iterator with IT's position. (Bug#7616)
6568 (find_row_edges): If ROW->start.pos gives position
6569 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
6570 (handle_stop, back_to_previous_visible_line_start, reseat_1):
6571 Reset the from_disp_prop_p flag.
6572 (SAVE_IT, RESTORE_IT): New macros.
6573 (pos_visible_p, face_before_or_after_it_pos)
6574 (back_to_previous_visible_line_start)
6575 (move_it_in_display_line_to, move_it_in_display_line)
6576 (move_it_to, move_it_vertically_backward, move_it_by_lines)
6577 (try_scrolling, redisplay_window, display_line): Use them when
6578 saving a temporary copy of the iterator and restoring it back.
6579 (back_to_previous_visible_line_start, reseat_1)
6580 (init_iterator): Empty the bidi cache "stack".
6581 (move_it_in_display_line_to): If iterator ended up at
6582 EOL, but we never saw any buffer positions smaller than
6583 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
6584 motion in bidi-reordered lines.
6585 (move_it_in_display_line_to): Record prev_method and prev_pos
6586 immediately before the call to set_iterator_to_next. Fixes cursor
6587 motion in bidi-reordered lines with stretch glyphs and strings
6588 displayed in margins. (Bug#8133) (Bug#8867)
6589 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
6590 TO_CHARPOS.
6591 (pos_visible_p): Support positions in bidi-reordered lines.
6592 Save and restore bidi cache.
6593
6594 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
6595 (bidi_paragraph_info): Delete unused struct.
6596 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
6597 (bidi_cache_start): New variable.
6598 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
6599 to zero.
6600 (bidi_cache_fetch_state, bidi_cache_search)
6601 (bidi_cache_find_level_change, bidi_cache_iterator_state)
6602 (bidi_cache_find, bidi_peek_at_next_level)
6603 (bidi_level_of_next_char, bidi_find_other_level_edge)
6604 (bidi_move_to_visually_next): Compare cache index with
6605 bidi_cache_start rather than with zero.
6606 (bidi_fetch_char): Accept new argument STRING; all callers
6607 changed. Support iteration over a string. Support strings with
6608 display properties. Support unibyte strings. Fix the type of
6609 `len' according to what STRING_CHAR_AND_LENGTH expects.
6610 (bidi_paragraph_init, bidi_resolve_explicit_1)
6611 (bidi_resolve_explicit, bidi_resolve_weak)
6612 (bidi_level_of_next_char, bidi_move_to_visually_next):
6613 Support iteration over a string.
6614 (bidi_set_sor_type, bidi_resolve_explicit_1)
6615 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
6616 can now be zero (for strings); special values 0 and -1 were
6617 changed to -1 and -2, respectively.
6618 (bidi_char_at_pos): New function.
6619 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
6620 Call it instead of FETCH_MULTIBYTE_CHAR.
6621 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
6622 initialized to valid values.
6623 (bidi_init_it): Don't initialize charpos and bytepos with invalid
6624 values.
6625 (bidi_level_of_next_char): Allow the sentinel "position" to pass
6626 the test for valid cached positions. Fix the logic for looking up
6627 the sentinel state in the cache. GCPRO the Lisp string we are
6628 iterating.
6629 (bidi_push_it, bidi_pop_it): New functions.
6630 (bidi_initialize): Initialize the bidi cache start stack pointer.
6631 (bidi_cache_ensure_space): New function, refactored from part of
6632 bidi_cache_iterator_state. Don't assume the required size is just
6633 one BIDI_CACHE_CHUNK away.
6634 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
6635 (bidi_count_bytes, bidi_char_at_pos): New functions.
6636 (bidi_cache_search): Don't assume bidi_cache_last_idx is
6637 always valid if bidi_cache_idx is valid.
6638 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
6639 is valid if it's going to be used.
6640 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
6641 (bidi_cache_fetch_state, bidi_cache_search)
6642 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6643 (bidi_cache_iterator_state, bidi_cache_find)
6644 (bidi_find_other_level_edge, bidi_cache_start_stack):
6645 All variables related to cache indices are now EMACS_INT.
6646
6647 * dispextern.h (struct bidi_string_data): New structure.
6648 (struct bidi_it): New member `string'. Make flag members be 1-bit
6649 fields, and put them last in the struct.
6650 (compute_display_string_pos, compute_display_string_end):
6651 Update prototypes.
6652 (bidi_push_it, bidi_pop_it): Add prototypes.
6653 (struct iterator_stack_entry): New members bidi_p,
6654 paragraph_embedding, and from_disp_prop_p.
6655 (struct it): Member bidi_p is now a bit field 1 bit wide.
6656 (bidi_shelve_cache, bidi_unshelve_cache):
6657 Declare prototypes.
6658
6659 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
6660 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
6661 and vector-like objects.
6662
6663 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
6664 cache around display iteration.
6665
6666 * window.c (Fwindow_end, window_scroll_pixel_based)
6667 (displayed_window_lines, Frecenter): Save and restore the bidi
6668 cache around display iteration.
6669
6670 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6671
6672 * editfns.c (Fdelete_region): Clarify the use of the named
6673 parameters (bug#6788).
6674
6675 2011-07-14 Martin Rudalics <rudalics@gmx.at>
6676
6677 * indent.c (Fvertical_motion): Set and restore w->pointm when
6678 saving and restoring the window's buffer (Bug#9006).
6679
6680 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
6681
6682 * editfns.c (Fstring_to_char): Clarify just what is returned
6683 (bug#6576). Text by Eli Zaretskii.
6684
6685 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
6686
6687 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
6688
6689 2011-07-13 Eli Zaretskii <eliz@gnu.org>
6690
6691 * buffer.c (mmap_find): Fix a typo.
6692
6693 2011-07-13 Johan Bockgård <bojohan@gnu.org>
6694
6695 Fix execution of x selection hooks.
6696 * xselect.c (Qx_lost_selection_functions)
6697 (Qx_sent_selection_functions): New vars.
6698 (syms_of_xselect): DEFSYM them.
6699 (x_handle_selection_request): Pass Qx_sent_selection_functions
6700 rather than Vx_sent_selection_functions to Frun_hook_with_args.
6701 (x_handle_selection_clear,x_clear_frame_selections):
6702 Pass Qx_lost_selection_functions rather than
6703 Vx_lost_selection_functions to Frun_hook_with_args.
6704
6705 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
6706
6707 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
6708 The old code sometimes used this field without initializing it.
6709
6710 * alloc.c (gc_sweep): Don't read past end of array.
6711 In theory, the old code could also have corrupted Emacs internals,
6712 though it'd be very unlikely.
6713
6714 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
6715
6716 * character.c (Fcharacterp): Don't advertise optional ignored
6717 argument. (Bug#4026)
6718
6719 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
6720
6721 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
6722 key" (bug#4257).
6723
6724 * window.c (Fset_window_start): Doc fix (bug#4199).
6725 (Fset_window_hscroll): Ditto.
6726
6727 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
6728
6729 Fix minor new problems caught by GCC 4.6.1.
6730 * term.c (init_tty): Remove unused local.
6731 * xsettings.c (store_monospaced_changed): Define this function only
6732 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
6733 not used otherwise.
6734
6735 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
6736
6737 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
6738
6739 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6740
6741 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
6742 are the mini-buffer and the echo area (bug#3320).
6743
6744 * term.c (init_tty): Remove support for supdup, c10 and perq
6745 terminals, which are no longer supported (bug#1482).
6746
6747 2011-07-10 Johan Bockgård <bojohan@gnu.org>
6748
6749 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
6750
6751 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
6752
6753 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
6754 for non-popups (Bug#3642).
6755
6756 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
6757
6758 * alloc.c (reset_malloc_hooks): Protoize.
6759 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
6760 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
6761 * cm.c (losecursor): Likewise.
6762 * data.c (fmod): Likewise.
6763 * dispnew.c (swap_glyphs_in_rows): Likewise.
6764 * emacs.c (memory_warning_signal): Likewise.
6765 * floatfns.c (float_error): Likewise.
6766 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
6767 (otf_open, font_otf_capability, generate_otf_features)
6768 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
6769 Likewise.
6770 * image.c (pbm_read_file): Likewise.
6771 * indent.c (string_display_width): Likewise.
6772 * intervals.c (check_for_interval, search_for_interval)
6773 (inc_interval_count, count_intervals, root_interval)
6774 (adjust_intervals_for_insertion, make_new_interval): Likewise.
6775 * lread.c (defalias): Likewise.
6776 * ralloc.c (r_alloc_check): Likewise.
6777 * regex.c (set_image_of_range_1, set_image_of_range)
6778 (regex_grow_registers): Likewise.
6779 * sysdep.c (strerror): Likewise.
6780 * termcap.c (valid_filename_p, tprint, main): Likewise.
6781 * tparam.c (main): Likewise.
6782 * unexhp9k800.c (run_time_remap, save_data_space)
6783 (update_file_ptrs, read_header, write_header, calculate_checksum)
6784 (copy_file, copy_rest, display_header): Likewise.
6785 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
6786 Likewise.
6787 * xdisp.c (check_it): Likewise.
6788 * xfaces.c (register_color, unregister_color, unregister_colors):
6789 Likewise.
6790 * xfns.c (print_fontset_result): Likewise.
6791 * xrdb.c (member, fatal, main): Likewise.
6792
6793 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
6794
6795 Fix minor problems found by static checking (Bug#9031).
6796 * chartab.c (char_table_set_range, map_sub_char_table):
6797 Remove unused locals.
6798 (uniprop_table): Now static.
6799 * composite.c (_work_char): Remove unused static var.
6800
6801 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
6802
6803 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
6804
6805 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
6806
6807 * gtkutil.c (qttip_cb): Remove code without function.
6808
6809 2011-07-09 Eli Zaretskii <eliz@gnu.org>
6810
6811 * w32.c (pthread_sigmask): New stub.
6812
6813 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
6814
6815 Use pthread_sigmask, not sigprocmask (Bug#9010).
6816 sigprocmask is portable only for single-threaded applications, and
6817 Emacs can be multi-threaded when it uses GTK.
6818 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
6819 (LIBES): Use it.
6820 * callproc.c (Fcall_process):
6821 * process.c (create_process):
6822 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
6823 Use pthread_sigmask, not sigprocmask.
6824
6825 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6826
6827 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
6828 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
6829 wrong (Bug#8591).
6830
6831 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6832
6833 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
6834 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
6835 (xg_hide_tooltip): Fix comment.
6836
6837 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
6838 in registerServicesMenuSendTypes.
6839 (validRequestorForSendType): Don't check ns_return_types.
6840
6841 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
6842 ns_return_type.
6843
6844 2011-07-08 Jason Rumney <jasonr@gnu.org>
6845
6846 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
6847 SH_SHOW for hidden windows (Bug#5482).
6848
6849 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
6850 frame struct members of non-existent frames (Bug#6284).
6851
6852 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6853
6854 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
6855 variable firstTime not needed on OSX >= 10.6.
6856 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
6857 >= 10.5. Use setKnobProportion, setDoubleValue.
6858
6859 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
6860 (MAC_OS_X_VERSION_10_5): Define if not defined.
6861 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
6862 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
6863 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
6864
6865 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
6866 cString and lossyCString on OSX >= 10.4
6867
6868 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
6869 sizeToFit on OSX >= 10.2.
6870
6871 * nsimage.m (allocInitFromFile): Don't use deprecated method
6872 bestRepresentationForDevice on OSX >= 10.6.
6873
6874 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
6875 to avoid warning.
6876
6877 * emacs.c: Declare unexec_init_emacs_zone.
6878
6879 * nsgui.h: Fix compiler warning about gnulib redefining verify.
6880
6881 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
6882
6883 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
6884 on svcsMenu (Bug#8842).
6885
6886 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
6887 ns_return_types.
6888 (Fns_list_services): Just return Qnil on 10.6, code not working there.
6889
6890 * nsterm.m (QUTF8_STRING): Declare.
6891 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
6892 (validRequestorForSendType): Return type is (id).
6893 Change indexOfObjectIdenticalTo to indexOfObject.
6894 Check if we have local selection before returning self (Bug#8842).
6895 (writeSelectionToPasteboard): Put local selection into paste board
6896 if we have a local selection (Bug#8842).
6897 (syms_of_nsterm): DEFSYM QUTF8_STRING.
6898
6899 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
6900 (ns_get_local_selection): Declare.
6901
6902 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
6903
6904 * keymap.c (describe_map_tree): Don't insert a double newline at
6905 the end of the buffer (bug#1169) and return whether we inserted
6906 something.
6907
6908 * callint.c (Fcall_interactively): Change "reading args" to
6909 "providing args" to try to clarify what it does (bug#1010).
6910
6911 2011-07-07 Kenichi Handa <handa@m17n.org>
6912
6913 * composite.c (composition_compute_stop_pos): Ignore a static
6914 composition starting before CHARPOS (Bug#8915).
6915
6916 * xdisp.c (handle_composition_prop): Likewise.
6917
6918 2011-07-07 Eli Zaretskii <eliz@gnu.org>
6919
6920 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
6921 (Bug#9015)
6922
6923 2011-07-07 Kenichi Handa <handa@m17n.org>
6924
6925 * character.h (unicode_category_t): New enum type.
6926
6927 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
6928 (Qchar_code_property_table): New variable.
6929 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
6930 (UNIPROP_COMPRESSED_FORM_P): New macros.
6931 (char_table_ascii): Uncompress the compressed values.
6932 (sub_char_table_ref): New arg is_uniprop. Callers changed.
6933 Uncompress the compressed values.
6934 (sub_char_table_ref_and_range): Likewise.
6935 (char_table_ref_and_range): Uncompress the compressed values.
6936 (sub_char_table_set): New arg is_uniprop. Callers changed.
6937 Uncompress the compressed values.
6938 (sub_char_table_set_range): Args changed. Callers changed.
6939 (char_table_set_range): Adjuted for the above change.
6940 (map_sub_char_table): Delete args default_val and parent. Add arg
6941 top. Give decoded values to a Lisp function.
6942 (map_char_table): Adjust for the above change. Give decoded
6943 values to a Lisp function. Gcpro more variables.
6944 (uniprop_table_uncompress)
6945 (uniprop_decode_value_run_length): New functions.
6946 (uniprop_decoder, uniprop_decoder_count): New variables.
6947 (uniprop_get_decoder, uniprop_encode_value_character)
6948 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
6949 New functions.
6950 (uniprop_encoder, uniprop_encoder_count): New variables.
6951 (uniprop_get_encoder, uniprop_table)
6952 (Funicode_property_table_internal, Fget_unicode_property_internal)
6953 (Fput_unicode_property_internal): New functions.
6954 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
6955 Sunicode_property_table_internal, Sget_unicode_property_internal,
6956 and Sput_unicode_property_internal. Defvar_lisp
6957 char-code-property-alist.
6958
6959 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
6960 Vunicode_category_table.
6961
6962 * font.c (font_range): Adjust for the change of
6963 Vunicode_category_table.
6964
6965 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
6966
6967 * m/iris4d.h: Remove file, move contents ...
6968 * s/irix6-5.h: ... here.
6969
6970 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
6971
6972 Remove unportable assumption about struct layout (Bug#8884).
6973 * alloc.c (mark_buffer):
6974 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
6975 (clone_per_buffer_values): Don't assume that
6976 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
6977 This isn't true in general, and it's particularly not true
6978 if Emacs is configured with --with-wide-int.
6979 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
6980 New macros, used in the buffer.c change.
6981
6982 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
6983
6984 * xsettings.c: Use both GConf and GSettings if both are available.
6985 (store_config_changed_event): Add comment.
6986 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
6987 (store_tool_bar_style_changed): New functions.
6988 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
6989 (struct xsettings): Move font inside HAVE_XFT.
6990 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
6991 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
6992 Move inside HAVE_XFT.
6993 (something_changed_gsettingsCB): Rename from something_changedCB.
6994 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
6995 also.
6996 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
6997 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
6998 (something_changed_gconfCB): Rename from something_changedCB.
6999 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
7000 (parse_settings): Move check for font inside HAVE_XFT.
7001 (read_settings, apply_xft_settings): Add comment.
7002 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
7003 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
7004 call store_font_name_changed.
7005 (xft_settings_event): Add comment.
7006 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
7007 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
7008 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
7009 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
7010 (xsettings_initialize): Call init_gsettings last.
7011 (xsettings_get_system_font, xsettings_get_system_normal_font):
7012 Add comment.
7013
7014 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
7015
7016 Random fixes. E.g., (random) never returned negative values.
7017 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
7018 subseconds part to the entropy, as that's a bit more random.
7019 Prefer signed to unsigned, since the signedness doesn't matter and
7020 in general we prefer signed. When given a limit, use a
7021 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
7022 latter isn't right if USE_2_TAGS_FOR_INTS.
7023 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
7024 not 0..VALMASK. Don't discard "excess" bits that random () returns.
7025
7026 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
7027
7028 * textprop.c (text_property_stickiness):
7029 Obey Vtext_property_default_nonsticky.
7030 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
7031 * w32fns.c (syms_of_w32fns):
7032 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
7033
7034 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7035
7036 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
7037 This is more efficient than Ffile_directory_p and avoids a minor race.
7038
7039 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
7040
7041 * buffer.c (Foverlay_put): Say what the return value is
7042 (bug#7835).
7043
7044 * fileio.c (barf_or_query_if_file_exists): Check first if the file
7045 is a directory before asking whether to use the file name
7046 (bug#7564).
7047 (barf_or_query_if_file_exists): Make the "File is a directory"
7048 error be more correct.
7049
7050 * fns.c (Frequire): Remove the mention of the .gz files, since
7051 that's installation-specific, but keep the mention of
7052 `get-load-suffixes'.
7053
7054 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7055
7056 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
7057 Report string overflow if the output is too long.
7058
7059 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
7060
7061 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
7062 (syms_of_gnutls): Remove duplicate DEFSYM for
7063 Qgnutls_bootprop_verify_hostname_error, an error for
7064 Qgnutls_bootprop_verify_error (which is no longer used).
7065
7066 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
7067 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
7068 Also (re)move comments that are misplaced or no longer relevant.
7069
7070 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7071
7072 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
7073
7074 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
7075
7076 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
7077 and background color parameters if they have been changed.
7078
7079 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7080
7081 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
7082
7083 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
7084
7085 * xsettings.c (SYSTEM_FONT): Define only when used.
7086 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
7087
7088 * keymap.c (access_keymap_1): Now static.
7089
7090 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
7091
7092 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
7093 leave any prefix arg for the up event (Bug#1586).
7094
7095 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
7096
7097 * lread.c (syms_of_lread): Mention single symbols defined by
7098 `defvar' or `defconst' (bug#7154).
7099
7100 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7101 (Frequire): Mention get-load-suffixes.
7102
7103 2011-07-02 Martin Rudalics <rudalics@gmx.at>
7104
7105 * window.h (window): Remove clone_number slot.
7106 * window.c (Fwindow_clone_number, Fset_window_clone_number):
7107 Remove.
7108 (make_parent_window, make_window, saved_window)
7109 (Fset_window_configuration, save_window_save): Don't deal with
7110 clone numbers.
7111 * buffer.c (Qclone_number): Remove declaration.
7112 (sort_overlays, overlay_strings): Don't deal with clone numbers.
7113
7114 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
7115
7116 Add multiple inheritance to keymaps.
7117 * keymap.c (Fmake_composed_keymap): New function.
7118 (Fset_keymap_parent): Simplify.
7119 (fix_submap_inheritance): Remove.
7120 (access_keymap_1): New function extracted from access_keymap to handle
7121 embedded parents and handle lists of maps.
7122 (access_keymap): Use it.
7123 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
7124 (Fcopy_keymap): Handle embedded parents.
7125 (Fcommand_remapping, define_as_prefix): Simplify.
7126 (Fkey_binding): Simplify.
7127 (syms_of_keymap): Move minibuffer-local-completion-map,
7128 minibuffer-local-filename-completion-map,
7129 minibuffer-local-must-match-map, and
7130 minibuffer-local-filename-must-match-map to Elisp.
7131 (syms_of_keymap): Defsubr make-composed-keymap.
7132 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
7133 (parse_menu_item): Trivial simplification.
7134
7135 2011-07-01 Glenn Morris <rgm@gnu.org>
7136
7137 * Makefile.in (SETTINGS_LIBS): Fix typo.
7138
7139 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
7140
7141 * coding.c (Fencode_coding_string): Record the last coding system
7142 used, as the function doc string says (bug#8738).
7143
7144 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
7145
7146 * xsettings.c (store_monospaced_changed): Take new font as arg and
7147 check for change against current_mono_font.
7148 (EMACS_TYPE_SETTINGS): Remove this and related defines.
7149 (emacs_settings_constructor, emacs_settings_get_property)
7150 (emacs_settings_set_property, emacs_settings_class_init)
7151 (emacs_settings_init, gsettings_obj): Remove.
7152 (something_changedCB): New function for HAVE_GSETTINGS.
7153 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
7154 with value as argument.
7155 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
7156 g_settings_new (Bug#8967). Do not create gsettings_obj.
7157 Remove calls to g_settings_bind. Connect something_changedCB to
7158 "changed".
7159
7160 * xgselect.c: Add defined (HAVE_GSETTINGS).
7161 (xgselect_initialize): Ditto.
7162
7163 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
7164 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
7165 xg_select.
7166
7167 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
7168
7169 * eval.c (struct backtrace): Simplify and port the data structure.
7170 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
7171 signed bit field, as this assumption is not portable and it makes
7172 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
7173 "char debug_on_exit : 1" as this is not portable either; instead,
7174 use the portable "unsigned int debug_on_exit : 1". Remove unused
7175 member evalargs. Remove obsolete comments about cc bombing out.
7176
7177 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
7178
7179 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
7180 Let HAVE_GSETTINGS override HAVE_GCONF.
7181 (store_monospaced_changed): New function.
7182 (EMACS_SETTINGS): A new type derived from GObject to handle
7183 GSettings notifications.
7184 (emacs_settings_constructor, emacs_settings_get_property)
7185 (emacs_settings_set_property, emacs_settings_class_init):
7186 New functions.
7187 (gsettings_client, gsettings_obj): New variables.
7188 (GSETTINGS_SCHEMA): New define.
7189 (something_changedCB): Call store_monospaced_changed.
7190 (init_gsettings): New function.
7191 (xsettings_initialize): Call init_gsettings.
7192 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
7193 to NULL.
7194
7195 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
7196 GCONF_CFLAGS/LIBS.
7197
7198 2011-06-29 Martin Rudalics <rudalics@gmx.at>
7199
7200 * window.c (resize_root_window, grow_mini_window)
7201 (shrink_mini_window): Rename Qresize_root_window to
7202 Qwindow_resize_root_window and Qresize_root_window_vertically to
7203 Qwindow_resize_root_window_vertically.
7204
7205 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
7206
7207 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
7208
7209 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
7210
7211 * makefile.w32-in: Redesign dependencies so they reflect more
7212 clearly which files are directly included by each source file,
7213 and not through other includes.
7214
7215 2011-06-27 Martin Rudalics <rudalics@gmx.at>
7216
7217 * buffer.c (Qclone_number): Declare static and DEFSYM it.
7218 (sort_overlays, overlay_strings): When an overlay's clone number
7219 matches the window's clone number process the overlay even if
7220 the overlay's window property doesn't match the current window.
7221
7222 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
7223 (Fwindow_hchild): Rename to Fwindow_left_child.
7224 (Fwindow_next): Rename to Fwindow_next_sibling.
7225 (Fwindow_prev): Rename to Fwindow_prev_sibling.
7226 (resize_window_check): Rename to window_resize_check.
7227 (resize_window_apply): Rename to window_resize_apply.
7228 (Fresize_window_apply): Rename to Fwindow_resize_apply.
7229 (Fdelete_other_windows_internal, resize_frame_windows)
7230 (Fsplit_window_internal, Fdelete_window_internal)
7231 (grow_mini_window, shrink_mini_window)
7232 (Fresize_mini_window_internal): Fix callers accordingly.
7233
7234 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
7235
7236 * emacsgtkfixed.h: State that this is only used with Gtk+3.
7237 (emacs_fixed_set_min_size): Remove.
7238 (emacs_fixed_new): Take frame as argument.
7239
7240 * emacsgtkfixed.c: State that this is only used with Gtk+3.
7241 (_EmacsFixedPrivate): Remove minwidth/height.
7242 Add struct frame *f.
7243 (emacs_fixed_init): Initialize priv->f.
7244 (get_parent_class, emacs_fixed_set_min_size): Remove.
7245 (emacs_fixed_new): Set priv->f to argument.
7246 (emacs_fixed_get_preferred_width)
7247 (emacs_fixed_get_preferred_height): Use min_width/height from
7248 frames size_hint to set minimum and natural (Bug#8919).
7249 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
7250 and use min_width/height from frames size_hint to set
7251 min_width/height (Bug#8919).
7252
7253 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
7254 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
7255 Fix indentation.
7256
7257 2011-06-26 Eli Zaretskii <eliz@gnu.org>
7258
7259 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
7260 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
7261 called at ZV.
7262
7263 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
7264
7265 * process.c (wait_reading_process_output): Bypass select if
7266 waiting for a cell while ignoring keyboard input, and input is
7267 pending. Suggested by Jan Djärv (Bug#8869).
7268
7269 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
7270
7271 Use gnulib's dup2 module instead of rolling our own.
7272 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
7273
7274 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7275
7276 * dispnew.c (scrolling_window): Before scrolling, turn off a
7277 mouse-highlight in the window being scrolled.
7278
7279 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
7280
7281 Move DEFSYM to lisp.h and use everywhere.
7282
7283 * character.h (DEFSYM): Move declaration...
7284 * lisp.h (DEFSYM): ...here.
7285
7286 * gnutls.c:
7287 * minibuf.c:
7288 * w32menu.c:
7289 * w32proc.c:
7290 * w32select.c: Don't include character.h.
7291
7292 * alloc.c (syms_of_alloc):
7293 * buffer.c (syms_of_buffer):
7294 * bytecode.c (syms_of_bytecode):
7295 * callint.c (syms_of_callint):
7296 * casefiddle.c (syms_of_casefiddle):
7297 * casetab.c (init_casetab_once):
7298 * category.c (init_category_once, syms_of_category):
7299 * ccl.c (syms_of_ccl):
7300 * cmds.c (syms_of_cmds):
7301 * composite.c (syms_of_composite):
7302 * dbusbind.c (syms_of_dbusbind):
7303 * dired.c (syms_of_dired):
7304 * dispnew.c (syms_of_display):
7305 * doc.c (syms_of_doc):
7306 * editfns.c (syms_of_editfns):
7307 * emacs.c (syms_of_emacs):
7308 * eval.c (syms_of_eval):
7309 * fileio.c (syms_of_fileio):
7310 * fns.c (syms_of_fns):
7311 * frame.c (syms_of_frame):
7312 * fringe.c (syms_of_fringe):
7313 * insdel.c (syms_of_insdel):
7314 * keymap.c (syms_of_keymap):
7315 * lread.c (init_obarray, syms_of_lread):
7316 * macros.c (syms_of_macros):
7317 * msdos.c (syms_of_msdos):
7318 * print.c (syms_of_print):
7319 * process.c (syms_of_process):
7320 * search.c (syms_of_search):
7321 * sound.c (syms_of_sound):
7322 * syntax.c (init_syntax_once, syms_of_syntax):
7323 * terminal.c (syms_of_terminal):
7324 * textprop.c (syms_of_textprop):
7325 * undo.c (syms_of_undo):
7326 * w32.c (globals_of_w32):
7327 * window.c (syms_of_window):
7328 * xdisp.c (syms_of_xdisp):
7329 * xfaces.c (syms_of_xfaces):
7330 * xfns.c (syms_of_xfns):
7331 * xmenu.c (syms_of_xmenu):
7332 * xsettings.c (syms_of_xsettings):
7333 * xterm.c (syms_of_xterm): Use DEFSYM.
7334
7335 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
7336
7337 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
7338
7339 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
7340
7341 Integer and buffer overflow fixes (Bug#8873).
7342
7343 * print.c (printchar, strout): Check for string overflow.
7344 (PRINTPREPARE, printchar, strout):
7345 Don't set size unless allocation succeeds.
7346
7347 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
7348 for sizes. Check for string overflow more accurately.
7349 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
7350
7351 * macros.c: Integer and buffer overflow fixes.
7352 * keyboard.h (struct keyboard.kbd_macro_bufsize):
7353 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
7354 Use ptrdiff_t, not int, for sizes.
7355 Don't increment bufsize until after realloc succeeds.
7356 Check for size-calculation overflow.
7357 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
7358
7359 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
7360
7361 * lread.c: Integer overflow fixes.
7362 (read_integer): Radix is now EMACS_INT, not int,
7363 to improve quality of diagnostics for out-of-range radices.
7364 Calculate buffer size correctly for out-of-range radices.
7365 (read1): Check for integer overflow in radices, and in
7366 read-circle numbers.
7367 (read_escape): Avoid int overflow.
7368 (Fload, openp, read_buffer_size, read1)
7369 (substitute_object_recurse, read_vector, read_list, map_obarray):
7370 Use ptrdiff_t, not int, for sizes.
7371 (read1): Use EMACS_INT, not int, for sizes.
7372 Check for size overflow.
7373
7374 * image.c (cache_image): Check for size arithmetic overflow.
7375
7376 * lread.c: Integer overflow issues.
7377 (saved_doc_string_size, saved_doc_string_length)
7378 (prev_saved_doc_string_size, prev_saved_doc_string_length):
7379 Now ptrdiff_t, not int.
7380 (read1): Don't assume doc string length fits in int. Check for
7381 out-of-range doc string lengths.
7382 (read_list): Don't assume file position fits in int.
7383 (read_escape): Check for hex character overflow.
7384
7385 2011-06-22 Leo Liu <sdl.web@gmail.com>
7386
7387 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
7388 Move to minibuffer.el.
7389
7390 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7391
7392 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
7393 The following patches are for when GLYPH_DEBUG && !XASSERT.
7394 * dispextern.h (trace_redisplay_p, dump_glyph_string):
7395 * dispnew.c (flush_stdout):
7396 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
7397 Mark as externally visible.
7398 * dispnew.c (check_window_matrix_pointers): Now static.
7399 * dispnew.c (window_to_frame_vpos):
7400 * xfns.c (unwind_create_frame):
7401 * xterm.c (x_check_font): Remove unused local.
7402 * scroll.c (CHECK_BOUNDS):
7403 * xfaces.c (cache_fache): Rename local to avoid shadowing.
7404 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
7405 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
7406 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
7407 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
7408 Now static.
7409 (debug_method_add): Use va_list and vsprintf rather than relying
7410 on undefined behavior with wrong number of arguments.
7411 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
7412 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
7413 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
7414 since we're not interested in debugging glyphs with old libraries.
7415 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
7416 GCC 4.6.0's static checking.
7417
7418 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7419
7420 Integer overflow and signedness fixes (Bug#8873).
7421 A few related buffer overrun fixes, too.
7422
7423 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
7424
7425 * dispextern.h (struct face.stipple):
7426 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
7427 (x_bitmap_mask, x_allocate_bitmap_record)
7428 (x_create_bitmap_from_data, x_create_bitmap_from_file)
7429 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
7430 (x_create_bitmap_from_xpm_data):
7431 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
7432 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
7433 (.bitmaps_last):
7434 * xfaces.c (load_pixmap):
7435 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
7436 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
7437 (.bitmaps_last, struct x_output.icon_bitmap):
7438 Use ptrdiff_t, not int, for bitmap indexes.
7439 (x_allocate_bitmap_record): Check for size overflow.
7440 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
7441
7442 Use ptrdiff_t, not int, for overlay counts.
7443 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
7444 * editfns.c (overlays_around, get_pos_property):
7445 * textprop.c (get_char_property_and_overlay):
7446 * xdisp.c (next_overlay_change, note_mouse_highlight):
7447 * xfaces.c (face_at_buffer_position):
7448 * buffer.c (OVERLAY_COUNT_MAX): New macro.
7449 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
7450 (Fnext_overlay_change, Fprevious_overlay_change)
7451 (mouse_face_overlay_overlaps, Foverlays_in):
7452 Use ptrdiff_t, not int, for sizes.
7453 (overlays_at, overlays_in): Check for size-calculation overflow.
7454
7455 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
7456
7457 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
7458 (x_session_initialize): Do not assume string length fits in int.
7459
7460 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
7461 This is unlikely, but can occur if DPI is outlandish.
7462
7463 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
7464 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
7465
7466 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
7467 * xrdb.c (magic_file_p, search_magic_path):
7468 Omit last arg SUFFIX; it was always 0. All callers changed.
7469 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
7470
7471 * xfont.c (xfont_match): Avoid need for strlen.
7472
7473 * xfns.c: Don't assume strlen fits in int.
7474 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
7475
7476 * xdisp.c (message_log_check_duplicate): Return intmax_t,
7477 not unsigned long, as we prefer signed integers. All callers changed.
7478 Detect integer overflow in repeat count.
7479 (message_dolog): Don't assume print length fits in 39 bytes.
7480 (display_mode_element): Don't assume strlen fits in int.
7481
7482 * termcap.c: Don't assume sizes fit in int and never overflow.
7483 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
7484 (gobble_line): Check for size-calculation overflow.
7485
7486 * minibuf.c (Fread_buffer):
7487 * lread.c (intern, intern_c_string):
7488 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
7489 Don't assume string length fits in int.
7490
7491 * keyboard.c (parse_tool_bar_item):
7492 * gtkutil.c (style_changed_cb): Avoid need for strlen.
7493
7494 * font.c: Don't assume string length fits in int.
7495 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
7496 Use ptrdiff_t, not int.
7497 (font_intern_prop): Don't assume string length fits in int.
7498 Don't assume integer property fits in fixnum.
7499 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
7500
7501 * filelock.c: Fix some buffer overrun and integer overflow issues.
7502 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
7503 Reformulate so as not to need the command string.
7504 Invoke gzip -cd rather than gunzip, as it's more portable.
7505 (lock_info_type, lock_file_1, lock_file):
7506 Don't assume pid_t and time_t fit in unsigned long.
7507 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
7508 (current_lock_owner): Prefer signed type for sizes.
7509 Use memcpy, not strncpy, where memcpy is what is really wanted.
7510 Don't assume (via atoi) that time_t and pid_t fit in int.
7511 Check for time_t and/or pid_t out of range, e.g., via a network share.
7512 Don't alloca where an auto var works fine.
7513
7514 * fileio.c: Fix some integer overflow issues.
7515 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
7516 Don't assume string length fits in int.
7517 (directory_file_name): Don't assume string length fits in long.
7518 (make_temp_name): Don't assume pid fits in int, or that its print
7519 length is less than 20.
7520
7521 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
7522
7523 * coding.c (make_subsidiaries): Don't assume string length fits in int.
7524
7525 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
7526
7527 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
7528 We prefer signed integers, even for size calculations.
7529
7530 * emacs.c: Don't assume string length fits in 'int'.
7531 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
7532 (main): Don't invoke strlen when not needed.
7533
7534 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
7535 (XD_DEBUG_MESSAGE): Don't waste a byte.
7536
7537 * callproc.c (getenv_internal_1, getenv_internal)
7538 (Fgetenv_internal):
7539 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
7540
7541 * lread.c (invalid_syntax): Omit length argument.
7542 All uses changed. This doesn't fix a bug, but it simplifies the
7543 code away from its former Hollerith-constant appearance, and it's
7544 one less 'int' to worry about when looking at integer-overflow issues.
7545 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
7546
7547 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
7548 This didn't break anything, but it didn't help either.
7549 It's confusing to put a bogus integer in a place where the actual
7550 value does not matter.
7551 (LIST_END_P): Remove unused macro and its bogus comment.
7552 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
7553
7554 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
7555 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
7556 implementation.
7557 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
7558 We prefer signed types, and the value cannot exceed the EMACS_INT
7559 range anyway (because otherwise the length would not be representable).
7560 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
7561 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
7562 This avoids a GCC warning when WIDE_EMACS_INT.
7563
7564 * indent.c (sane_tab_width): New function.
7565 (current_column, scan_for_column, Findent_to, position_indentation)
7566 (compute_motion): Use it. This is just for clarity.
7567 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
7568
7569 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
7570
7571 * lisp.h (lint_assume): New macro.
7572 * composite.c (composition_gstring_put_cache):
7573 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
7574
7575 * editfns.c, insdel.c:
7576 Omit unnecessary forward decls, to simplify future changes.
7577
7578 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
7579
7580 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
7581
7582 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
7583 Use much-faster test for byte-length change.
7584 Don't assume string byte-length fits in 'int'.
7585 Check that character arg fits in 'int'.
7586 (mapcar1): Declare byte as byte, for clarity.
7587
7588 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
7589
7590 * fns.c (concat): Catch string overflow earlier.
7591 Do not rely on integer wraparound.
7592
7593 * dispextern.h (struct it.overlay_strings_charpos)
7594 (struct it.selective): Now EMACS_INT, not int.
7595 * xdisp.c (forward_to_next_line_start)
7596 (back_to_previous_visible_line_start)
7597 (reseat_at_next_visible_line_start, next_element_from_buffer):
7598 Don't arbitrarily truncate the value of 'selective' to int.
7599
7600 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
7601
7602 * composite.c: Don't truncate sizes to 'int'.
7603 (composition_gstring_p, composition_reseat_it)
7604 (composition_adjust_point): Use EMACS_INT, not int.
7605 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
7606 not EMACS_UINT, for indexes.
7607
7608 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
7609
7610 * buffer.c: Include <verify.h>.
7611 (struct sortvec.priority, struct sortstr.priority):
7612 Now EMACS_INT, not int.
7613 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
7614 (struct sortstr.size, record_overlay_string)
7615 (struct sortstrlist.size, struct sortlist.used):
7616 Don't truncate size to int.
7617 (record_overlay_string): Check for size-calculation overflow.
7618 (init_buffer_once): Check at compile-time, not run-time.
7619
7620 2011-06-22 Jim Meyering <meyering@redhat.com>
7621
7622 Don't leak an XBM-image-sized buffer
7623 * image.c (xbm_load): Free the image buffer after using it.
7624
7625 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
7626
7627 Port to Sun C.
7628 * composite.c (find_automatic_composition): Omit needless 'return 0;'
7629 that Sun C diagnosed.
7630 * fns.c (secure_hash): Fix pointer signedness issue.
7631 * intervals.c (static_offset_intervals): New function.
7632 (offset_intervals): Use it.
7633
7634 2011-06-21 Leo Liu <sdl.web@gmail.com>
7635
7636 * deps.mk (fns.o):
7637 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
7638 sha512.h.
7639
7640 * fns.c (secure_hash): Rename from crypto_hash_function and change
7641 the first arg to accept symbols.
7642 (Fsecure_hash): New primitive.
7643 (syms_of_fns): New symbols.
7644
7645 2011-06-20 Deniz Dogan <deniz@dogan.se>
7646
7647 * process.c (Fset_process_buffer): Clarify return value in
7648 docstring.
7649
7650 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
7651
7652 * dispnew.c (add_window_display_history): Use BVAR.
7653
7654 * xdisp.c (debug_method_add): Use BVAR.
7655 (check_window_end, dump_glyph_matrix, dump_glyph)
7656 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
7657
7658 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
7659 Likewise.
7660
7661 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
7662 check till after the cache is created in init_frame_faces.
7663
7664 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
7665
7666 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
7667
7668 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
7669
7670 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
7671 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
7672 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
7673
7674 Improve buffer-overflow checking (Bug#8873).
7675 * fileio.c (Finsert_file_contents):
7676 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
7677 Remove the old (too-loose) buffer overflow checks.
7678 They weren't needed, since make_gap checks for buffer overflow.
7679 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
7680 The old code merely checked for Emacs fixnum overflow, and relied
7681 on undefined (wraparound) behavior. The new code avoids undefined
7682 behavior, and also checks for ptrdiff_t and/or size_t overflow.
7683
7684 * editfns.c (Finsert_char): Don't dump core with very negative counts.
7685 Tune. Don't use wider integers than needed. Don't use alloca.
7686 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
7687
7688 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
7689
7690 * insdel.c, lisp.h (buffer_overflow): New function.
7691 (insert_from_buffer_1, replace_range, replace_range_2):
7692 * insdel.c (make_gap_larger):
7693 * editfns.c (Finsert_char):
7694 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
7695
7696 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
7697
7698 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
7699
7700 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
7701
7702 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
7703 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
7704
7705 * fileio.c: Don't assume EMACS_INT fits in off_t.
7706 (emacs_lseek): New static function.
7707 (Finsert_file_contents, Fwrite_region): Use it.
7708 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
7709
7710 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
7711
7712 * fns.c: Don't overflow int when computing a list length.
7713 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
7714 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
7715 truncation on 64-bit hosts. Check for QUIT every
7716 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
7717 faster and is responsive enough.
7718 (Flength): Report an error instead of overflowing an integer.
7719 (Fsafe_length): Return a float if the value is not representable
7720 as a fixnum. This shouldn't happen except in contrived situations.
7721 (Fnthcdr, Fsort): Don't assume list length fits in int.
7722 (Fcopy_sequence): Don't assume vector length fits in int.
7723
7724 * alloc.c: Check that resized vectors' lengths fit in fixnums.
7725 (header_size, word_size): New constants.
7726 (allocate_vectorlike): Don't check size overflow here.
7727 (allocate_vector): Check it here instead, since this is the only
7728 caller of allocate_vectorlike that could cause overflow.
7729 Check that the new vector's length is representable as a fixnum.
7730
7731 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
7732 The previous code was bogus. For example, next_almost_prime (32)
7733 returned 39, which is undesirable as it is a multiple of 3; and
7734 next_almost_prime (24) returned 25, which is a multiple of 5 so
7735 why was the code bothering to check for multiples of 7?
7736
7737 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
7738
7739 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
7740
7741 Variadic C functions now count arguments with ptrdiff_t.
7742 This partly undoes my 2011-03-30 change, which replaced int with size_t.
7743 Back then I didn't know that the Emacs coding style prefers signed int.
7744 Also, in the meantime I found a few more instances where arguments
7745 were being counted with int, which may truncate counts on 64-bit
7746 machines, or EMACS_INT, which may be unnecessarily wide.
7747 * lisp.h (struct Lisp_Subr.function.aMANY)
7748 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
7749 Arg counts are now ptrdiff_t, not size_t.
7750 All variadic functions and their callers changed accordingly.
7751 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
7752 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
7753 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
7754 * callint.c (Fcall_interactively): Check arg count for overflow,
7755 to avoid potential buffer overrun. Use signed char, not 'int',
7756 for 'varies' array, so that we needn't bother to check its size
7757 calculation for overflow.
7758 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
7759 * eval.c (apply_lambda):
7760 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
7761 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
7762 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
7763
7764 * callint.c (Fcall_interactively): Don't use index var as event count.
7765
7766 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
7767 * mem-limits.h (SIZE): Remove; no longer used.
7768
7769 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
7770
7771 Remove unnecessary casts.
7772 * xterm.c (x_term_init):
7773 * xfns.c (x_set_border_pixel):
7774 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
7775 These aren't needed now that we assume ANSI C.
7776
7777 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
7778 It's more likely to cause problems (due to unsigned overflow)
7779 than to cure them.
7780
7781 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
7782
7783 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
7784
7785 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
7786
7787 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
7788
7789 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
7790
7791 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
7792
7793 GLYPH_CODE_FACE returns EMACS_INT, not int.
7794 * dispextern.h (merge_faces):
7795 * xfaces.c (merge_faces):
7796 * xdisp.c (get_next_display_element, next_element_from_display_vector):
7797 Don't assume EMACS_INT fits in int.
7798
7799 * character.h (CHAR_VALID_P): Remove unused parameter.
7800 * fontset.c, lisp.h, xdisp.c: All uses changed.
7801
7802 * editfns.c (Ftranslate_region_internal): Omit redundant test.
7803
7804 * fns.c (concat): Minor tuning based on overflow analysis.
7805 This doesn't fix any bugs. Use int to hold character, instead
7806 of constantly refetching from Emacs object. Use XFASTINT, not
7807 XINT, for value known to be a character. Don't bother comparing
7808 a single byte to 0400, as it's always less.
7809
7810 * floatfns.c (Fexpt):
7811 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
7812
7813 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
7814 for characters.
7815
7816 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
7817
7818 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
7819 Without this fix, on a 64-bit host (aset S 0 4294967386) would
7820 incorrectly succeed when S was a string, because 4294967386 was
7821 truncated before it was used.
7822
7823 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
7824 Otherwise, an out-of-range integer could cause undefined behavior
7825 on a 64-bit host.
7826
7827 * composite.c: Use int, not EMACS_INT, for characters.
7828 (fill_gstring_body, composition_compute_stop_pos): Use int, not
7829 EMACS_INT, for values that are known to be in character range.
7830 This doesn't fix any bugs but is the usual style inside Emacs and
7831 may generate better code on 32-bit machines.
7832
7833 Make sure a 64-bit char is never passed to ENCODE_CHAR.
7834 This is for reasons similar to the recent CHAR_STRING fix.
7835 * charset.c (Fencode_char): Check that character arg is actually
7836 a character. Pass an int to ENCODE_CHAR.
7837 * charset.h (ENCODE_CHAR): Verify that the character argument is no
7838 wider than 'int', as a compile-time check to prevent future regressions
7839 in this area.
7840
7841 * character.c (char_string): Remove unnecessary casts.
7842
7843 Make sure a 64-bit char is never passed to CHAR_STRING.
7844 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
7845 by silently ignoring the top 32 bits, allowing some values
7846 that were far too large to be valid characters.
7847 * character.h: Include <verify.h>.
7848 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
7849 arguments are no wider than unsigned, as a compile-time check
7850 to prevent future regressions in this area.
7851 * data.c (Faset):
7852 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
7853 (Fsubst_char_in_region):
7854 * fns.c (concat):
7855 * xdisp.c (decode_mode_spec_coding):
7856 Adjust to CHAR_STRING's new requirement.
7857 * editfns.c (Finsert_char, Fsubst_char_in_region):
7858 * fns.c (concat): Check that character args are actually
7859 characters. Without this test, these functions did the wrong
7860 thing with wildly out-of-range values on 64-bit hosts.
7861
7862 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
7863 These casts should not be needed on 32-bit hosts, either.
7864 * keyboard.c (read_char):
7865 * lread.c (Fload): Remove casts to unsigned.
7866
7867 * lisp.h (UNSIGNED_CMP): New macro.
7868 This fixes comparison bugs on 64-bit hosts.
7869 (ASCII_CHAR_P): Use it.
7870 * casefiddle.c (casify_object):
7871 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
7872 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
7873 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
7874 * dispextern.h (FACE_FROM_ID):
7875 * keyboard.c (read_char): Use UNSIGNED_CMP.
7876
7877 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
7878 not to EMACS_INT, to avoid GCC warning.
7879
7880 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
7881
7882 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
7883 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
7884 isn't needed on 32-bit machines.
7885
7886 * buffer.c (Fgenerate_new_buffer_name):
7887 Use EMACS_INT for count, not int.
7888 (advance_to_char_boundary): Return EMACS_INT, not int.
7889
7890 * data.c (Qcompiled_function): Now static.
7891
7892 * window.c (window_body_lines): Now static.
7893
7894 * image.c (gif_load): Rename local to avoid shadowing.
7895
7896 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
7897 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
7898 * alloc.c (make_save_value): Integer argument is now of type
7899 ptrdiff_t, not int.
7900 (mark_object): Use ptrdiff_t, not int.
7901 * lisp.h (pD): New macro.
7902 * print.c (print_object): Use it.
7903
7904 * alloc.c: Use EMACS_INT, not int, to count objects.
7905 (total_conses, total_markers, total_symbols, total_vector_size)
7906 (total_free_conses, total_free_markers, total_free_symbols)
7907 (total_free_floats, total_floats, total_free_intervals)
7908 (total_intervals, total_strings, total_free_strings):
7909 Now EMACS_INT, not int. All uses changed.
7910 (Fgarbage_collect): Compute overall total using a double, so that
7911 integer overflow is less likely to be a problem. Check for overflow
7912 when converting back to an integer.
7913 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
7914 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
7915 These were 'int' variables that could overflow on 64-bit hosts;
7916 they were never used, so remove them instead of repairing them.
7917 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
7918 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
7919 Previously, this ceilinged at INT_MAX, but that doesn't work on
7920 64-bit machines.
7921 (allocate_pseudovector): Don't use EMACS_INT when int would do.
7922
7923 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
7924 (allocate_vectorlike): Check for ptrdiff_t overflow.
7925 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
7926 when a (possibly-narrower) signed value would do just as well.
7927 We prefer using signed arithmetic, to avoid comparison confusion.
7928
7929 * alloc.c: Catch some string size overflows that we were missing.
7930 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
7931 for convenience in STRING_BYTES_MAX.
7932 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
7933 The definition here is exact; the one in lisp.h was approximate.
7934 (allocate_string_data): Check for string overflow. This catches
7935 some instances we weren't catching before. Also, it catches
7936 size_t overflow on (unusual) hosts where SIZE_MAX <= min
7937 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
7938 and ptrdiff_t and EMACS_INT are both 64 bits.
7939
7940 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
7941 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
7942 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
7943
7944 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
7945
7946 * alloc.c (Fmake_string): Check for out-of-range init.
7947
7948 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
7949
7950 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
7951
7952 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
7953
7954 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
7955 xg_get_default_scrollbar_width.
7956
7957 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
7958 (int_gtk_range_get_value): Move to the scroll bar part of the file.
7959 (style_changed_cb): Call update_theme_scrollbar_width and call
7960 x_set_scroll_bar_default_width and xg_frame_set_char_size for
7961 all frames (Bug#8505).
7962 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
7963 Call gtk_window_set_resizable if HAVE_GTK3.
7964 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
7965 and height if HAVE_GTK3 (Bug#8505).
7966 (scroll_bar_width_for_theme): New variable.
7967 (update_theme_scrollbar_width): New function.
7968 (xg_get_default_scrollbar_width): Move code to
7969 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
7970 (xg_initialize): Call update_theme_scrollbar_width.
7971
7972 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
7973
7974 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
7975
7976 2011-06-12 Martin Rudalics <rudalics@gmx.at>
7977
7978 * frame.c (make_frame): Call other_buffer_safely instead of
7979 other_buffer.
7980
7981 * window.c (temp_output_buffer_show): Call display_buffer with
7982 second argument Vtemp_buffer_show_specifiers and reset latter
7983 immediately after the call.
7984 (Vtemp_buffer_show_specifiers): New variable.
7985 (auto_window_vscroll_p, next_screen_context_lines)
7986 (Vscroll_preserve_screen_position): Remove leading asterisks from
7987 doc-strings.
7988
7989 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
7990
7991 Fix minor problems found by GCC 4.6.0 static checking.
7992 * buffer.c (Qclone_number): Remove for now, as it's unused.
7993 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
7994 (record_buffer): Remove unused local.
7995 * frame.c (other_visible_frames, frame_buffer_list): Now static.
7996 (set_frame_buffer_list): Remove; unused.
7997 * frame.h (other_visible_frames): Remove decl.
7998 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
7999 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
8000 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
8001 if HAVE_GPM.
8002 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
8003 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
8004 Define only if HAVE_GPM.
8005 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
8006 (update_hints_inhibit): Remove; never set. All uses removed.
8007 * widgetprv.h (emacsFrameClassRec): Remove decl.
8008 * window.c (delete_deletable_window): Now returns void, since it
8009 wasn't returning anything.
8010 (compare_window_configurations): Remove unused locals.
8011 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
8012 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
8013 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
8014 the same widths as pointers. This follows up on the 2011-05-06 patch.
8015 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
8016 * xterm.h: Likewise.
8017 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
8018
8019 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
8020
8021 * makefile.w32-in: Update dependencies.
8022 (LISP_H): Add lib/intprops.h.
8023
8024 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
8025
8026 * image.c (gif_load): Add animation frame delay to the metadata.
8027 (syms_of_image): Use DEFSYM. New symbol `delay'.
8028
8029 2011-06-11 Martin Rudalics <rudalics@gmx.at>
8030
8031 * window.c (delete_deletable_window): Re-add.
8032 (Fset_window_configuration): Rewrite to handle dead buffers and
8033 consequently deletable windows.
8034 (window_tree, Fwindow_tree): Remove. Supply functionality in
8035 window.el.
8036 (compare_window_configurations): Simplify code.
8037
8038 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
8039
8040 * image.c (imagemagick_load_image): Fix type mismatch.
8041 (Fimagemagick_types): Likewise.
8042
8043 * window.h (replace_buffer_in_windows): Declare.
8044
8045 2011-06-11 Martin Rudalics <rudalics@gmx.at>
8046
8047 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
8048 Qclone_number. Remove external declaration of Qdelete_window.
8049 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
8050 code.
8051 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
8052 Run Qbuffer_list_update_hook if allowed.
8053 (Fother_buffer): Rewrite doc-string. Major rewrite for new
8054 buffer list implementation.
8055 (other_buffer_safely): New function.
8056 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
8057 calls to replace_buffer_in_windows and
8058 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
8059 if allowed.
8060 (record_buffer): Inhibit quitting and rewrite using quittable
8061 functions. Run Qbuffer_list_update_hook if allowed.
8062 (Frecord_buffer, Funrecord_buffer): New functions.
8063 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
8064 Move switch-to-buffer to window.el.
8065 (bury-buffer): Move to window.el.
8066 (Vbuffer_list_update_hook): New variable.
8067
8068 * lisp.h (other_buffer_safely): Add prototype in buffer.c
8069 section.
8070
8071 * window.h (resize_frame_windows): Move up in code.
8072 (Fwindow_frame): Remove EXFUN.
8073 (replace_buffer_in_all_windows): Remove prototype.
8074 (replace_buffer_in_windows_safely): Add prototype.
8075
8076 * window.c: Declare Qdelete_window static again. Move down
8077 declaration of select_count.
8078 (Fnext_window, Fprevious_window): Rewrite doc-strings.
8079 (Fother_window): Move to window.el.
8080 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
8081 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
8082 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
8083 window.el.
8084 (replace_buffer_in_windows): Implement by calling
8085 Qreplace_buffer_in_windows.
8086 (replace_buffer_in_all_windows): Remove with some functionality
8087 moved into replace_buffer_in_windows_safely.
8088 (replace_buffer_in_windows_safely): New function.
8089 (select_window_norecord, select_frame_norecord): Move in front
8090 of run_window_configuration_change_hook. Remove now obsolete
8091 declarations.
8092 (Fset_window_buffer): Rewrite doc-string.
8093 Call Qrecord_window_buffer.
8094 (keys_of_window): Move binding for other-window to window.el.
8095
8096 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
8097
8098 * dispextern.h (struct image): Replace data member, whose int_val
8099 and ptr_val fields were not used by anything, with a single
8100 lisp_val object.
8101
8102 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
8103 (gif_clear_image, gif_load, imagemagick_load_image)
8104 (gs_clear_image, gs_load): Callers changed.
8105
8106 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
8107
8108 * buffer.h: Include <time.h>, for time_t.
8109 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
8110
8111 Fix minor problems found by static checking.
8112
8113 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
8114
8115 Make identifiers static if they are not used in other modules.
8116 * data.c (Qcompiled_function, Qframe, Qvector):
8117 * image.c (QimageMagick, Qsvg):
8118 * minibuf.c (Qmetadata):
8119 * window.c (resize_window_check, resize_root_window): Now static.
8120 * window.h (resize_window_check, resize_root_window): Remove decls.
8121
8122 * window.c (window_deletion_count, delete_deletable_window):
8123 Remove; unused.
8124 (window_body_lines): Now static.
8125 (Fdelete_other_windows_internal): Mark vars as initialized.
8126 Make sure 'resize_failed' is initialized.
8127 (run_window_configuration_change_hook): Rename local to avoid shadowing.
8128 (resize_window_apply): Remove unused local.
8129 * window.h (delete_deletable_window): Remove decl.
8130
8131 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
8132 (imagemagick_load_image): Fix pointer signedness problem by changing
8133 last arg from unsigned char * to char *. All uses changed.
8134 Also, fix a local for similar reasons.
8135 Remove unused locals. Remove locals to avoid shadowing.
8136 (fn_rsvg_handle_free): Remove; unused.
8137 (svg_load, svg_load_image): Fix pointer signedness problem.
8138 (imagemagick_load_image): Don't use garbage pointer image_wand.
8139
8140 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
8141
8142 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
8143
8144 * image.c (gif_load): Fix omitted cast error introduced by
8145 2011-06-06 change.
8146
8147 2011-06-10 Martin Rudalics <rudalics@gmx.at>
8148
8149 * window.h (resize_proportionally, orig_total_lines)
8150 (orig_top_line): Remove from window structure.
8151 (set_window_height, set_window_width, change_window_heights)
8152 (Fdelete_window): Remove prototypes.
8153 (resize_frame_windows): Remove duplicate declaration.
8154
8155 2011-06-10 Eli Zaretskii <eliz@gnu.org>
8156
8157 * window.h (resize_frame_windows, resize_window_check)
8158 (delete_deletable_window, resize_root_window)
8159 (resize_frame_windows): Declare prototypes.
8160
8161 * window.c (resize_window_apply): Make definition be "static" to
8162 match the prototype.
8163
8164 2011-06-10 Martin Rudalics <rudalics@gmx.at>
8165
8166 * window.c: Remove declarations of Qwindow_size_fixed,
8167 window_min_size_1, window_min_size_2, window_min_size,
8168 size_window, window_fixed_size_p, enlarge_window, delete_window.
8169 Remove static from declaration of Qdelete_window, it's
8170 temporarily needed by Fbury_buffer.
8171 (replace_window): Don't assign orig_top_line and
8172 orig_total_lines.
8173 (Fdelete_window, delete_window): Remove. Window deletion is
8174 handled by window.el.
8175 (window_loop): Remove DELETE_OTHER_WINDOWS case.
8176 Replace Fdelete_window calls with calls to Qdelete_window.
8177 (Fdelete_other_windows): Remove. Deleting other windows is
8178 handled by window.el.
8179 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
8180 handled in window.el.
8181 (window_min_size_2, window_min_size_1, window_min_size): Remove.
8182 Window minimum sizes are handled in window.el.
8183 (shrink_windows, size_window, set_window_height)
8184 (set_window_width, change_window_heights, window_height)
8185 (window_width, CURBEG, CURSIZE, enlarge_window)
8186 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
8187 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
8188 handled in window.el.
8189 (make_dummy_parent): Rename to make_parent_window and give it a
8190 second argument horflag.
8191 (make_window): Don't set resize_proportionally any more.
8192 (Fsplit_window): Remove. Windows are split in window.el.
8193 (save_restore_action, save_restore_orig_size)
8194 (shrink_window_lowest_first, save_restore_orig_size): Remove.
8195 Resize mini windows in window.el.
8196 (grow_mini_window, shrink_mini_window): Implement by calling
8197 Qresize_root_window_vertically, resize_window_check and
8198 resize_window_apply.
8199 (saved_window, Fset_window_configuration, save_window_save):
8200 Do not handle orig_top_line, orig_total_lines, and
8201 resize_proportionally.
8202 (window_min_height, window_min_width): Move to window.el.
8203 (keys_of_window): Move bindings for delete-other-windows,
8204 split-window, delete-window and enlarge-window to window.el.
8205
8206 * buffer.c: Temporarily extern Qdelete_window.
8207 (Fbury_buffer): Temporarily call Qdelete_window instead of
8208 Fdelete_window (Fbury_buffer will move to window.el soon).
8209
8210 * frame.c (set_menu_bar_lines_1): Remove code handling
8211 orig_top_line and orig_total_lines.
8212
8213 * dispnew.c (adjust_frame_glyphs_initially): Don't use
8214 set_window_height but set heights directly.
8215 (change_frame_size_1): Use resize_frame_windows.
8216
8217 * xdisp.c (init_xdisp): Don't use set_window_height but set
8218 heights directly.
8219
8220 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
8221 Use resize_frame_windows instead of change_window_heights and run
8222 run_window_configuration_change_hook.
8223
8224 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
8225 instead of change_window_heights and run
8226 run_window_configuration_change_hook.
8227
8228 2011-06-09 Martin Rudalics <rudalics@gmx.at>
8229
8230 * window.c (replace_window): Rename second argument REPLACEMENT to
8231 NEW. New third argument SETFLAG. Rewrite.
8232 (delete_window, make_dummy_parent): Call replace_window with
8233 third argument 1.
8234 (window_list_1): Move down in code.
8235 (run_window_configuration_change_hook): Move set_buffer part
8236 before select_frame_norecord part in order to unwind correctly.
8237 Rename count1 to count.
8238 (recombine_windows, delete_deletable_window, resize_root_window)
8239 (Fdelete_other_windows_internal)
8240 (Frun_window_configuration_change_hook, make_parent_window)
8241 (resize_window_check, resize_window_apply, Fresize_window_apply)
8242 (resize_frame_windows, Fsplit_window_internal)
8243 (Fdelete_window_internal, Fresize_mini_window_internal):
8244 New functions.
8245 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
8246
8247 2011-06-08 Martin Rudalics <rudalics@gmx.at>
8248
8249 * window.h (window): Add some new members to window structure -
8250 normal_lines, normal_cols, new_total, new_normal, clone_number,
8251 splits, nest, prev_buffers, next_buffers.
8252 (WINDOW_TOTAL_SIZE): Move here from window.c.
8253 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
8254
8255 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
8256 Remove.
8257 (make_dummy_parent): Set new members of windows structure.
8258 (make_window): Move down in code. Handle new members of window
8259 structure.
8260 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
8261 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
8262 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
8263 (Fset_window_prev_buffers, Fwindow_next_buffers)
8264 (Fset_window_next_buffers, Fset_window_clone_number):
8265 New functions.
8266 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
8267 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
8268 Doc-string fixes.
8269 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
8270 Argument WINDOW can be now internal window too.
8271 (Fwindow_use_time): Move up in code.
8272 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
8273 Rewrite doc-string.
8274 (Fset_window_configuration, saved_window)
8275 (Fcurrent_window_configuration, save_window_save): Handle new
8276 members of window structure.
8277 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
8278 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
8279 (syms_of_window): New Lisp objects Qrecord_window_buffer,
8280 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
8281 Qget_mru_window, Qresize_root_window,
8282 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
8283 Qauto_buffer_name; staticpro them.
8284
8285 2011-06-07 Martin Rudalics <rudalics@gmx.at>
8286
8287 * window.c (Fwindow_total_size, Fwindow_left_column)
8288 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
8289 (Fwindow_list_1): New functions.
8290 (window_box_text_cols): Replace with window_body_cols.
8291 (Fwindow_width, Fscroll_left, Fscroll_right):
8292 Use window_body_cols instead of window_box_text_cols.
8293 (delete_window, Fset_window_configuration):
8294 Call delete_all_subwindows with window as argument.
8295 (delete_all_subwindows): Take a window as argument and not a
8296 structure. Rewrite.
8297 (window_loop): Remove handling of GET_LRU_WINDOW and
8298 GET_LARGEST_WINDOW.
8299 (Fget_lru_window, Fget_largest_window): Move to window.el.
8300
8301 * window.h: Extern window_body_cols instead of
8302 window_box_text_cols. delete_all_subwindows now takes a
8303 Lisp_Object as argument.
8304
8305 * indent.c (compute_motion, Fcompute_motion):
8306 Use window_body_cols instead of window_box_text_cols.
8307
8308 * frame.c (delete_frame): Call delete_all_subwindows with root
8309 window as argument.
8310
8311 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
8312
8313 * fns.c (Fputhash): Document return value.
8314
8315 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
8316
8317 * image.c (gif_load): Implement gif89a spec "no disposal" method.
8318
8319 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8320
8321 Cons<->int and similar integer overflow fixes (Bug#8794).
8322
8323 Check for overflow when converting integer to cons and back.
8324 * charset.c (Fdefine_charset_internal, Fdecode_char):
8325 Use cons_to_unsigned to catch overflow.
8326 (Fencode_char): Use INTEGER_TO_CONS.
8327 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
8328 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
8329 * data.c (long_to_cons, cons_to_long): Remove.
8330 (cons_to_unsigned, cons_to_signed): New functions.
8331 These signal an error for invalid or out-of-range values.
8332 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
8333 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
8334 * font.c (Ffont_variation_glyphs):
8335 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
8336 * lisp.h: Include <intprops.h>.
8337 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
8338 (cons_to_signed, cons_to_unsigned): New decls.
8339 (long_to_cons, cons_to_long): Remove decls.
8340 * undo.c (record_first_change): Use INTEGER_TO_CONS.
8341 (Fprimitive_undo): Use CONS_TO_INTEGER.
8342 * xfns.c (Fx_window_property): Likewise.
8343 * xselect.c: Include <limits.h>.
8344 (x_own_selection, selection_data_to_lisp_data):
8345 Use INTEGER_TO_CONS.
8346 (x_handle_selection_request, x_handle_selection_clear)
8347 (x_get_foreign_selection, Fx_disown_selection_internal)
8348 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
8349 (lisp_data_to_selection_data): Use cons_to_unsigned.
8350 (x_fill_property_data): Use cons_to_signed.
8351 Report values out of range.
8352
8353 Check for buffer and string overflow more precisely.
8354 * buffer.h (BUF_BYTES_MAX): New macro.
8355 * lisp.h (STRING_BYTES_MAX): New macro.
8356 * alloc.c (Fmake_string):
8357 * character.c (string_escape_byte8):
8358 * coding.c (coding_alloc_by_realloc):
8359 * doprnt.c (doprnt):
8360 * editfns.c (Fformat):
8361 * eval.c (verror):
8362 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
8363 since they may not be the same number.
8364 * editfns.c (Finsert_char):
8365 * fileio.c (Finsert_file_contents):
8366 Likewise for BUF_BYTES_MAX.
8367
8368 * image.c: Use ptrdiff_t, not int, for sizes.
8369 (slurp_file): Switch from int to ptrdiff_t.
8370 All uses changed.
8371 (slurp_file): Check that file size fits in both size_t (for
8372 malloc) and ptrdiff_t (for sanity and safety).
8373
8374 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
8375 if b->modtime has its maximal value.
8376
8377 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
8378
8379 Don't assume time_t can fit into int.
8380 * buffer.h (struct buffer.modtime): Now time_t, not int.
8381 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
8382 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
8383
8384 Minor fixes for signed vs unsigned integers.
8385 * character.h (MAYBE_UNIFY_CHAR):
8386 * charset.c (maybe_unify_char):
8387 * keyboard.c (read_char, reorder_modifiers):
8388 XINT -> XFASTINT, since the integer must be nonnegative.
8389 * ftfont.c (ftfont_spec_pattern):
8390 * keymap.c (access_keymap, silly_event_symbol_error):
8391 XUINT -> XFASTINT, since the integer must be nonnegative.
8392 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
8393 since it makes no difference and we prefer signed.
8394 * keyboard.c (record_char): Use XUINT when all the neighbors do.
8395 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
8396 nonnegative.
8397
8398 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
8399
8400 * window.h (Fwindow_frame): Declare.
8401
8402 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8403
8404 * alloc.c: Simplify handling of large-request failures (Bug#8800).
8405 (SPARE_MEMORY): Always define.
8406 (LARGE_REQUEST): Remove.
8407 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
8408
8409 2011-06-06 Martin Rudalics <rudalics@gmx.at>
8410
8411 * lisp.h: Move EXFUNS for Fframe_root_window,
8412 Fframe_first_window and Fset_frame_selected_window to window.h.
8413
8414 * window.h: Move EXFUNS for Fframe_root_window,
8415 Fframe_first_window and Fset_frame_selected_window here from
8416 lisp.h.
8417
8418 * frame.c (Fwindow_frame, Fframe_first_window)
8419 (Fframe_root_window, Fframe_selected_window)
8420 (Fset_frame_selected_window): Move to window.c.
8421 (Factive_minibuffer_window): Move to minibuf.c.
8422 (Fother_visible_frames_p): New function.
8423
8424 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
8425
8426 * window.c (decode_window, decode_any_window): Move up in code.
8427 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
8428 (inhibit_frame_unsplittable): Remove unused variable.
8429 (Fwindow_buffer): Move up and rewrite doc-string.
8430 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
8431 (Fwindow_prev): New functions.
8432 (Fwindow_frame): Move here from frame.c. Accept any window as
8433 argument.
8434 (Fframe_root_window, Fframe_first_window)
8435 (Fframe_selected_window): Move here from frame.c. Accept frame
8436 or arbitrary window as argument. Update doc-strings.
8437 (Fminibuffer_window): Move up in code.
8438 (Fwindow_minibuffer_p): Move up in code and simplify.
8439 (Fset_frame_selected_window): Move here from frame.c.
8440 Marginal rewrite.
8441 (Fselected_window, select_window, Fselect_window): Move up in
8442 code. Minor doc-string fixes.
8443
8444 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8445
8446 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
8447 Do not assume that spare memory exists; that assumption is valid
8448 only if SYSTEM_MALLOC.
8449 (LARGE_REQUEST): New macro, so that the issue of large requests
8450 is separated from the issue of spare memory.
8451
8452 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
8453
8454 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
8455 format. (Bug#8806)
8456
8457 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
8458
8459 * xfns.c (x_set_scroll_bar_default_width): Move declarations
8460 before statements.
8461
8462 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
8463
8464 * gtkutil.c (xg_get_default_scrollbar_width): New function.
8465
8466 * gtkutil.h: Declare xg_get_default_scrollbar_width.
8467
8468 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
8469 min width by calling x_set_scroll_bar_default_width (Bug#8505).
8470
8471 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
8472
8473 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
8474
8475 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
8476
8477 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
8478 (x_clipboard_manager_save): Add return value.
8479 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
8480 New error handlers.
8481 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
8482 Obey Vx_select_enable_clipboard_manager. Catch errors in
8483 x_clipboard_manager_save (Bug#8779).
8484 (Vx_select_enable_clipboard_manager): New variable.
8485 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
8486
8487 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8488
8489 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
8490
8491 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8492
8493 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
8494 in the current matrix if keep_current_p is non-zero.
8495
8496 2011-06-04 Eli Zaretskii <eliz@gnu.org>
8497
8498 * bidi.c (bidi_level_of_next_char): Fix last change.
8499
8500 2011-06-03 Eli Zaretskii <eliz@gnu.org>
8501
8502 Support bidi reordering of text covered by display properties.
8503
8504 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
8505 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
8506 (bidi_cache_search, bidi_cache_iterator_state)
8507 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
8508 (bidi_level_of_next_char, bidi_move_to_visually_next):
8509 Support character positions inside a run of characters covered by a
8510 display string.
8511 (bidi_paragraph_init, bidi_resolve_explicit_1)
8512 (bidi_level_of_next_char): Call bidi_fetch_char and
8513 bidi_fetch_char_advance instead of FETCH_CHAR and
8514 FETCH_CHAR_ADVANCE.
8515 (bidi_init_it): Initialize new members.
8516 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
8517 definitions.
8518 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
8519 instead of using explicit *_CHAR codes.
8520 (bidi_resolve_explicit, bidi_resolve_weak):
8521 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
8522 bidirectional text is supported only in multibyte buffers.
8523 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
8524 it to initialize the frame_window_p member of struct bidi_it.
8525 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
8526 (bidi_resolve_explicit, bidi_resolve_weak)
8527 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
8528 bidi_it->nchars is non-positive.
8529 (bidi_level_of_next_char): Don't try to lookup the cache for the
8530 next/previous character if nothing is cached there yet, or if we
8531 were just reseat()'ed to a new position.
8532
8533 * xdisp.c (set_cursor_from_row): Set start and stop points
8534 according to the row's direction when priming the loop that looks
8535 for the glyph on which to display cursor.
8536 (single_display_spec_intangible_p): Function deleted.
8537 (display_prop_intangible_p): Reimplement to call
8538 handle_display_spec instead of single_display_spec_intangible_p.
8539 Accept 3 additional arguments needed by handle_display_spec.
8540 This fixes incorrect cursor motion across display property with complex
8541 values: lists, `(when COND...)' forms, etc.
8542 (single_display_spec_string_p): Support property values that are
8543 lists with the argument STRING its top-level element.
8544 (display_prop_string_p): Fix the condition for processing a
8545 property that is a list to be consistent with handle_display_spec.
8546 (handle_display_spec): New function, refactored from the
8547 last portion of handle_display_prop.
8548 (compute_display_string_pos): Accept additional argument
8549 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
8550 value of a `display' property is a "replacing spec".
8551 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
8552 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
8553 the display property, but just return a value indicating whether
8554 the display property will replace the characters it covers.
8555 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
8556 frame_window_p members of struct bidi_it.
8557 (compute_display_string_pos, compute_display_string_end):
8558 New functions.
8559 (push_it): Accept second argument POSITION, where pop_it should
8560 jump to continue iteration.
8561 (reseat_1): Initialize bidi_it.disp_pos.
8562
8563 * keyboard.c (adjust_point_for_property): Adjust the call to
8564 display_prop_intangible_p to its new signature.
8565
8566 * dispextern.h (struct bidi_it): New member frame_window_p.
8567 (bidi_init_it): Update prototypes.
8568 (display_prop_intangible_p): Update prototype.
8569 (compute_display_string_pos, compute_display_string_end):
8570 Declare prototypes.
8571 (struct bidi_it): New members nchars and disp_pos. ch_len is now
8572 EMACS_INT.
8573
8574 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
8575
8576 Malloc failure behavior now depends on size of allocation.
8577 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
8578 * lisp.h: Change signatures accordingly.
8579 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
8580 All callers changed. (Bug#8762)
8581
8582 * gnutls.c: Use Emacs's memory allocators.
8583 Without this change, the gnutls library would invoke malloc etc.
8584 directly, which causes problems on non-SYNC_INPUT hosts, and which
8585 runs afoul of improving memory_full behavior. (Bug#8761)
8586 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
8587 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
8588 xfree instead of the default malloc, realloc, free.
8589 (Fgnutls_boot): No need to check for memory allocation failure,
8590 since xmalloc does that for us.
8591
8592 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
8593 * category.c (hash_get_category_set):
8594 * ccl.c (ccl_driver):
8595 * charset.c (Fdefine_charset_internal):
8596 * charset.h (struct charset.hash_index):
8597 * composite.c (get_composition_id, gstring_lookup_cache)
8598 (composition_gstring_put_cache):
8599 * composite.h (struct composition.hash_index):
8600 * dispextern.h (struct image.hash):
8601 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
8602 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
8603 (hashfn_equal, hashfn_user_defined, make_hash_table)
8604 (maybe_resize_hash_table, hash_lookup, hash_put)
8605 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
8606 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
8607 (Fsxhash, Fgethash, Fputhash, Fmaphash):
8608 * image.c (make_image, search_image_cache, lookup_image)
8609 (xpm_put_color_table_h):
8610 * lisp.h (struct Lisp_Hash_Table):
8611 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
8612 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
8613 for hashes and hash indexes, instead of 'unsigned' and 'int'.
8614 * alloc.c (allocate_vectorlike):
8615 Check for overflow in vector size calculations.
8616 * ccl.c (ccl_driver):
8617 Check for overflow when converting EMACS_INT to int.
8618 * fns.c, image.c: Remove unnecessary static decls that would otherwise
8619 need to be updated by these changes.
8620 * fns.c (make_hash_table, maybe_resize_hash_table):
8621 Check for integer overflow with large hash tables.
8622 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
8623 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
8624 (SXHASH_REDUCE): New macro.
8625 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
8626 Use it instead of discarding useful hash info with large hash values.
8627 (sxhash_float): New function.
8628 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
8629 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
8630 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
8631 Rewrite to use FIXNUM_BITS, as this simplifies things.
8632 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
8633 Adjust signatures to match updated version of code.
8634 (consing_since_gc): Now EMACS_INT, since a single hash table can
8635 use more than INT_MAX bytes.
8636
8637 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
8638
8639 Make it possible to build with GCC-4.6+ -O2 -flto.
8640
8641 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
8642
8643 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
8644
8645 * minibuf.c (get_minibuffer, read_minibuf_unwind):
8646 Call minibuffer-inactive-mode.
8647
8648 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
8649
8650 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
8651 Update dependencies.
8652
8653 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8654
8655 * data.c (init_data): Remove code for UTS, this system is not
8656 supported anymore.
8657
8658 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8659
8660 Don't force ./temacs to start in terminal mode.
8661
8662 * frame.c (make_initial_frame): Initialize faces in all cases, not
8663 only when CANNOT_DUMP is defined.
8664 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
8665
8666 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8667
8668 * dispnew.c (add_window_display_history): Use const for the string
8669 pointer. Remove declaration, not needed.
8670
8671 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8672
8673 Use 'inline', not 'INLINE'.
8674 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
8675 * alloc.c, fontset.c (INLINE): Remove.
8676 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
8677 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
8678 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
8679 * gmalloc.c (register_heapinfo): Use inline unconditionally.
8680 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
8681
8682 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8683
8684 Make it possible to run ./temacs.
8685
8686 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
8687 syms_of_callproc does the same thing. Remove test for
8688 "initialized", do it in the caller.
8689 * emacs.c (main): Avoid calling set_initial_environment when dumping.
8690
8691 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
8692
8693 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
8694 (read_minibuf): Use get_minibuffer.
8695 (syms_of_minibuf): Use DEFSYM.
8696 (Qmetadata): New var.
8697 * data.c (Qbuffer): Don't make it static.
8698 (syms_of_data): Use DEFSYM.
8699
8700 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8701
8702 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
8703 (CCL_CODE_MIN): New macro.
8704
8705 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
8706
8707 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
8708
8709 * eval.c (Qdebug): Now static.
8710 * lisp.h (Qdebug): Remove decl. This reverts a part of the
8711 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
8712 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
8713
8714 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
8715
8716 * image.c: Various fixes to ImageMagick code comments.
8717 (Fimagemagick_types): Doc fix.
8718
8719 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
8720
8721 Minor fixes prompted by GCC 4.6.0 warnings.
8722
8723 * xselect.c (converted_selections, conversion_fail_tag): Now static.
8724
8725 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
8726 (x_clipboard_manager_save_all): Move extern decl to ...
8727 * xterm.h: ... here, so that it can be checked for consistency.
8728
8729 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
8730
8731 * xselect.c (x_clipboard_manager_save_frame)
8732 (x_clipboard_manager_save_all): New functions.
8733 (Fx_clipboard_manager_save): Lisp function deleted.
8734
8735 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
8736 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
8737
8738 * xterm.h: Update prototype.
8739
8740 2011-05-28 William Xu <william.xwl@gmail.com>
8741
8742 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
8743 exiting (Bug#8239).
8744
8745 2011-05-28 Jim Meyering <meyering@redhat.com>
8746
8747 Avoid a sign-extension bug in crypto_hash_function.
8748 * fns.c (to_uchar): Define.
8749 (crypto_hash_function): Use it to convert some newly-signed
8750 variables to unsigned, to avoid sign-extension bugs. For example,
8751 without this change, (md5 "truc") would evaluate to
8752 45723a2aff78ff4fff7fff1114760e62 rather than the expected
8753 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
8754 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
8755
8756 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8757
8758 Integer overflow fixes.
8759
8760 * dbusbind.c: Serial number integer overflow fixes.
8761 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
8762 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
8763 to hold a serial number that is too large for a fixnum.
8764 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8765 Check for serial numbers out of range. Decode any serial number
8766 that was so large that it became a float. (Bug#8722)
8767
8768 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
8769 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8770 Use XFASTINT rather than XUINT when numbers are nonnegative.
8771 (xd_append_arg, Fdbus_method_return_internal):
8772 (Fdbus_method_error_internal): Likewise. Also, for unsigned
8773 arguments, check that Lisp number is nonnegative, rather than
8774 silently wrapping negative numbers around. (Bug#8722)
8775 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
8776 (Bug#8722)
8777
8778 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
8779
8780 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
8781
8782 ccl: Add integer overflow checks.
8783 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
8784 (IN_INT_RANGE): New macros.
8785 (ccl_driver): Use them to check for integer overflow when
8786 decoding a CCL program. Many of the new checks are whether XINT (x)
8787 fits in int; it doesn't always, on 64-bit hosts. The new version
8788 doesn't catch all possible integer overflows, but it's an
8789 improvement. (Bug#8719)
8790
8791 * alloc.c (make_event_array): Use XINT, not XUINT.
8792 There's no need for unsigned here.
8793
8794 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
8795 This follows up to the 2011-05-06 change that substituted uintptr_t
8796 for EMACS_INT. This case wasn't caught back then.
8797
8798 Rework Fformat to avoid integer overflow issues.
8799 * editfns.c: Include <float.h> unconditionally, as it's everywhere
8800 now (part of C89). Include <verify.h>.
8801 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
8802 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
8803 (Fformat): Avoid the prepass trying to compute sizes; it was only
8804 approximate and thus did not catch overflow reliably. Instead, walk
8805 through the format just once, formatting and computing sizes as we go,
8806 checking for integer overflow at every step, and allocating a larger
8807 buffer as needed. Keep track separately whether the format is
8808 multibyte. Keep only the most-recently calculated precision, rather
8809 than them all. Record whether each argument has been converted to
8810 string. Use EMACS_INT, not int, for byte and char and arg counts.
8811 Support field widths and precisions larger than INT_MAX. Avoid
8812 sprintf's undefined behavior with conversion specifications such as %#d
8813 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
8814 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
8815 formatting out-of-range floating point numbers with int
8816 formats. (Bug#8668)
8817
8818 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
8819
8820 * data.c: Avoid integer truncation in expressions involving floats.
8821 * data.c: Include <intprops.h>.
8822 (arith_driver): When there's an integer overflow in an expression
8823 involving floating point, convert the integers to floating point
8824 so that the resulting value does not suffer from catastrophic
8825 integer truncation. For example, on a 64-bit host (* 4
8826 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
8827 Do not rely on undefined behavior after integer overflow.
8828
8829 merge count_size_as_multibyte, parse_str_to_multibyte
8830 * character.c, character.h (count_size_as_multibyte):
8831 Rename from parse_str_to_multibyte; all uses changed.
8832 Check for integer overflow.
8833 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
8834 since it's now a duplicate of the other. This is more of
8835 a character than a buffer op, so better that it's in character.c.
8836 * fns.c, print.c: Adjust to above changes.
8837
8838 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
8839
8840 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
8841
8842 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8843
8844 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8845 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
8846 (x_clipboard_manager_save): Now static.
8847 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
8848
8849 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8850 (crypto_hash_function): Now static.
8851 Fix pointer signedness problems. Avoid unnecessary initializations.
8852
8853 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
8854
8855 * termhooks.h (Vselection_alist): Make it terminal-local.
8856
8857 * terminal.c (create_terminal): Initialize it.
8858
8859 * xselect.c: Support for clipboard managers.
8860 (Vselection_alist): Move to termhooks.h as terminal-local var.
8861 (LOCAL_SELECTION): New macro.
8862 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
8863 (symbol_to_x_atom): Remove gratuitous arg.
8864 (x_handle_selection_request, lisp_data_to_selection_data)
8865 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
8866 (x_own_selection, x_get_local_selection, x_convert_selection):
8867 New arg, specifying work frame. Use terminal-local Vselection_alist.
8868 (some_frame_on_display): Delete unused function.
8869 (Fx_own_selection_internal, Fx_get_selection_internal)
8870 (Fx_disown_selection_internal, Fx_selection_owner_p)
8871 (Fx_selection_exists_p): New optional frame arg.
8872 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
8873 (x_handle_selection_clear): Don't treat other terminals with the
8874 same keyboard specially. Use the terminal-local Vselection_alist.
8875 (x_clear_frame_selections): Use Frun_hook_with_args.
8876
8877 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
8878
8879 * xterm.h: Add support for those atoms.
8880
8881 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
8882
8883 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
8884 (converted_selections, conversion_fail_tag): New global variables.
8885 (x_selection_request_lisp_error): Free the above.
8886 (x_get_local_selection): Remove unnecessary code.
8887 (x_reply_selection_request): Args changed; handle arbitrary array
8888 of converted selections stored in converted_selections.
8889 Separate the XChangeProperty and SelectionNotify steps.
8890 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
8891 (x_convert_selection): New function.
8892 (x_handle_selection_event): Simplify.
8893 (x_get_foreign_selection): Don't ignore incoming requests while
8894 waiting for an answer; this will fail when we implement
8895 SAVE_TARGETS, and seems unnecessary anyway.
8896 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
8897 (Vx_sent_selection_functions): Doc fix.
8898
8899 2011-05-26 Leo Liu <sdl.web@gmail.com>
8900
8901 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
8902
8903 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8904
8905 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
8906
8907 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
8908 for fringe update if it has periodic bitmap.
8909 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
8910 and fringe_bitmap_periodic_p.
8911
8912 * fringe.c (get_fringe_bitmap_data): New function.
8913 (draw_fringe_bitmap_1, update_window_fringes): Use it.
8914 (update_window_fringes): Record periodicity of fringe bitmap in glyph
8915 row. Mark glyph row for fringe update if periodicity changed.
8916
8917 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
8918 for fringe update unless it has periodic bitmap.
8919
8920 2011-05-25 Kenichi Handa <handa@m17n.org>
8921
8922 * xdisp.c (get_next_display_element): Set correct it->face_id for
8923 a static composition.
8924
8925 2011-05-24 Leo Liu <sdl.web@gmail.com>
8926
8927 * deps.mk (fns.o):
8928 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
8929
8930 * fns.c (crypto_hash_function, Fsha1): New function.
8931 (Fmd5): Use crypto_hash_function.
8932 (syms_of_fns): Add Ssha1.
8933
8934 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8935
8936 * gnutls.c: Remove unused macros.
8937 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
8938 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
8939 Remove macros that are defined and never used.
8940 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
8941
8942 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
8943
8944 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
8945 (Fx_get_selection_internal): Minor cleanup.
8946 (Fx_own_selection_internal): Rename arguments for consistency with
8947 select.el.
8948
8949 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8950
8951 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
8952
8953 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
8954
8955 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
8956
8957 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8958
8959 * dispnew.c (scrolling_window): Don't exclude the case that the
8960 last enabled row in the desired matrix touches the bottom boundary.
8961
8962 2011-05-21 Glenn Morris <rgm@gnu.org>
8963
8964 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
8965 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
8966 and add some more files.
8967
8968 2011-05-20 Eli Zaretskii <eliz@gnu.org>
8969
8970 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
8971 report_file_error introduced by the change from 2011-05-07.
8972
8973 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
8974
8975 * systime.h (Time): Define only if emacs is defined.
8976 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
8977 where the include path doesn't have X11/X.h by default. See
8978 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
8979
8980 2011-05-20 Kenichi Handa <handa@m17n.org>
8981
8982 * composite.c (find_automatic_composition): Fix previous change.
8983
8984 2011-05-20 Glenn Morris <rgm@gnu.org>
8985
8986 * lisp.mk: New file, split from Makefile.in.
8987 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
8988 (shortlisp): Remove.
8989 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
8990
8991 2011-05-19 Glenn Morris <rgm@gnu.org>
8992
8993 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
8994 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
8995 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
8996 (lisp): Set the order to that of loadup.el.
8997 (shortlisp): Make it a copy of $lisp.
8998 (SOME_MACHINE_LISP): Remove.
8999 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
9000 Use just $shortlisp, not $SOME_MACHINE_LISP too.
9001
9002 2011-05-18 Kenichi Handa <handa@m17n.org>
9003
9004 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
9005 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
9006 (find_automatic_composition): Mostly rewrite for efficiency.
9007
9008 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
9009
9010 * makefile.w32-in: Update dependencies.
9011
9012 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
9013
9014 * menu.c: Include limits.h (fixes the MS-Windows build broken by
9015 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
9016
9017 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
9018
9019 Fix some integer overflow issues, such as string length overflow.
9020
9021 * insdel.c (count_size_as_multibyte): Check for string overflow.
9022
9023 * character.c (lisp_string_width): Check for string overflow.
9024 Use EMACS_INT, not int, for string indexes and lengths; in
9025 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
9026 the resulting string length overflows an EMACS_INT; instead,
9027 report a string overflow if no precision given. When checking for
9028 precision exhaustion, use a check that cannot possibly have
9029 integer overflow. (Bug#8675)
9030 * character.h (lisp_string_width): Adjust to new signature.
9031
9032 * alloc.c (string_overflow): New function.
9033 (Fmake_string): Use it. This doesn't change behavior, but saves
9034 a few bytes and will simplify future changes.
9035 * character.c (string_escape_byte8): Likewise.
9036 * lisp.h (string_overflow): New decl.
9037
9038 Fixups, following up to the user-interface timestamp change.
9039 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
9040 for UI timestamps, instead of unsigned long.
9041 * msdos.c (mouse_get_pos): Likewise.
9042 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
9043 * w32gui.h (Time): Define by including "systime.h" rather than by
9044 declaring it ourselves. (Bug#8664)
9045
9046 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
9047 * image.c (clear_image_cache): Likewise.
9048
9049 * term.c (term_mouse_position): Don't assume time_t wraparound.
9050
9051 Be more systematic about user-interface timestamps.
9052 Before, the code sometimes used 'Time', sometimes 'unsigned long',
9053 and sometimes 'EMACS_UINT', to represent these timestamps.
9054 This change causes it to use 'Time' uniformly, as that's what X uses.
9055 This makes the code easier to follow, and makes it easier to catch
9056 integer overflow bugs such as Bug#8664.
9057 * frame.c (Fmouse_position, Fmouse_pixel_position):
9058 Use Time, not unsigned long, for user-interface timestamps.
9059 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
9060 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
9061 * keyboard.h (last_event_timestamp): Likewise.
9062 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
9063 * menu.h (xmenu_show): Likewise.
9064 * term.c (term_mouse_position): Likewise.
9065 * termhooks.h (struct input_event.timestamp): Likewise.
9066 (struct terminal.mouse_position_hook): Likewise.
9067 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
9068 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
9069 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
9070 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
9071 what it was before.
9072 * menu.h, termhooks.h: Include "systime.h", for Time.
9073
9074 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
9075 Don't assume that the difference between two unsigned long values
9076 can fit into an integer. At this point, we know button_down_time
9077 <= event->timestamp, so the difference must be nonnegative, so
9078 there's no need to cast the result if double-click-time is
9079 nonnegative, as it should be; check that it's nonnegative, just in
9080 case. This bug is triggered when events are more than 2**31 ms
9081 apart (about 25 days). (Bug#8664)
9082
9083 * xselect.c (last_event_timestamp): Remove duplicate decl.
9084 (x_own_selection): Remove needless cast to unsigned long.
9085
9086 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
9087 that always fit in int. Use a sentinel instead of a counter, to
9088 avoid a temp and to allay GCC's concerns about possible int overflow.
9089 * frame.h (struct frame): Use int for menu_bar_items_used
9090 instead of EMACS_INT, since it always fits in int.
9091
9092 * menu.c (grow_menu_items): Check for int overflow.
9093
9094 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
9095
9096 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
9097 Before, the code was not consistent. These values cannot exceed
9098 2**31 - 1 so there's no need to make them unsigned.
9099 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
9100 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
9101 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
9102 as modifiers.
9103 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
9104
9105 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
9106 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
9107 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
9108 presumably because the widths might not match.
9109
9110 * window.c (size_window): Avoid needless test at loop start.
9111
9112 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
9113
9114 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
9115
9116 2011-05-12 Drew Adams <drew.adams@oracle.com>
9117
9118 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
9119
9120 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9121
9122 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
9123 `width' to `bar_area_x' and `bar_area_width', respectively.
9124 (x_scroll_run): Take account of fringe background extension.
9125
9126 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
9127 Rename local vars `left' and `width' to `bar_area_x' and
9128 `bar_area_width', respectively.
9129 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
9130 background extension.
9131
9132 2011-05-10 Jim Meyering <meyering@redhat.com>
9133
9134 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
9135
9136 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
9137
9138 * image.c (Finit_image_library): Return t for built-in image types,
9139 like pbm and xbm. (Bug#8640)
9140
9141 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
9142
9143 * w32menu.c (set_frame_menubar): Fix submenu allocation.
9144
9145 2011-05-07 Eli Zaretskii <eliz@gnu.org>
9146
9147 * w32console.c (Fset_screen_color): Doc fix.
9148 (Fget_screen_color): New function.
9149 (syms_of_ntterm): Defsubr it.
9150
9151 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
9152 unlink the temporary file if Fcall_process didn't create it in the
9153 first place.
9154 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
9155 child process will be redirected to a file specified with `:file'.
9156 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
9157 cue to call_process_cleanup not to close that handle.
9158
9159 2011-05-07 Ben Key <bkey76@gmail.com>
9160
9161 * makefile.w32-in: The bootstrap-temacs rule now makes use of
9162 one of two shell specific rules, either bootstrap-temacs-CMD or
9163 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
9164 to the previous implementation of the bootstrap-temacs rule.
9165 The bootstrap-temacs-CMD rule is similar to the previous
9166 implementation of the bootstrap-temacs rule except that it
9167 makes use of the ESC_CFLAGS variable instead of the CFLAGS
9168 variable.
9169
9170 These changes, along with some changes to nt/configure.bat,
9171 nt/gmake.defs, and nt/nmake.defs, are required to extend my
9172 earlier fix to add support for --cflags and --ldflags options
9173 that include quotes so that it works whether make uses cmd or
9174 sh as the shell.
9175
9176 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
9177
9178 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
9179 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
9180 is a constant.
9181 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
9182 a string. Handle both cases.
9183 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
9184 (Fdbus_register_method): Use Qinvalid_function.
9185
9186 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
9187
9188 * makefile.w32-in: Update dependencies.
9189 (LISP_H): Add inttypes.h and stdin.h.
9190 (PROCESS_H): Add unistd.h.
9191
9192 2011-05-06 Eli Zaretskii <eliz@gnu.org>
9193
9194 * lread.c: Include limits.h (fixes the MS-Windows build broken by
9195 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
9196
9197 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
9198
9199 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
9200
9201 * term.c (vfatal): Remove stray call to va_end.
9202 It's not needed and the C Standard doesn't allow it here anyway.
9203
9204 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
9205 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
9206
9207 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
9208 bytes.
9209
9210 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
9211
9212 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
9213
9214 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
9215
9216 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
9217
9218 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
9219
9220 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
9221 * charset.c (Fdefine_charset_internal): Don't initialize
9222 charset.code_space[15]. The value was garbage, on hosts with
9223 32-bit int (Bug#8600).
9224
9225 * lread.c (read_integer): Be more consistent with string-to-number.
9226 Use string_to_number to do the actual conversion; this avoids
9227 rounding errors and fixes some other screwups. Without this fix,
9228 for example, #x1fffffffffffffff was misread as -2305843009213693952.
9229 (digit_to_number): Move earlier, for benefit of read_integer.
9230 Return -1 if the digit is out of range for the base, -2 if it is
9231 not a digit in any supported base. (Bug#8602)
9232
9233 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
9234
9235 * dispnew.c (scrolling_window): Return 1 if we scrolled,
9236 to match comment at start of function. This also removes a
9237 GCC warning about overflow in a 32+64-bit port.
9238
9239 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
9240
9241 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
9242 Reported by Stefan Monnier in
9243 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
9244 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9245 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
9246
9247 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
9248 (EMACS_UINTPTR): Likewise, with uintptr_t.
9249
9250 * lisp.h: Prefer 64-bit EMACS_INT if available.
9251 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
9252 on 32-bit hosts that have 64-bit int, so that they can access
9253 large files.
9254 However, temporarily disable this change unless the temporary
9255 symbol WIDE_EMACS_INT is defined.
9256
9257 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
9258
9259 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
9260 This removes an assumption that EMACS_INT and long are the same
9261 width as pointers. The assumption is true for Emacs porting targets
9262 now, but we want to make other targets possible.
9263 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
9264 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
9265 In the rest of the code, change types of integers that hold casted
9266 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
9267 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
9268 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
9269 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
9270 No need to cast type when ORing.
9271 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
9272 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
9273 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
9274 assume EMACS_INT is the same width as char *.
9275 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
9276 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
9277 Remove no-longer-needed casts.
9278 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
9279 (xg_tool_bar_help_callback, xg_make_tool_item):
9280 Use EMACS_INTPTR to hold an integer
9281 that will be cast to void *; this can avoid a GCC warning
9282 if EMACS_INT is not the same width as void *.
9283 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
9284 * xdisp.c (display_echo_area_1, resize_mini_window_1):
9285 (current_message_1, set_message_1):
9286 Use a local to convert to proper width without a cast.
9287 * xmenu.c (dialog_selection_callback): Likewise.
9288
9289 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
9290 Also, don't assume VALBITS / RAND_BITS is less than 5,
9291 and don't rely on undefined behavior when shifting a 1 left into
9292 the sign bit.
9293 * lisp.h (get_random): Change signature to match.
9294
9295 * lread.c (hash_string): Use size_t, not int, for hash computation.
9296 Normally we prefer signed values; but hashing is special, because
9297 it's better to use unsigned division on hash table sizes so that
9298 the remainder is nonnegative. Also, size_t is the natural width
9299 for hashing into memory. The previous code used 'int', which doesn't
9300 retain enough info to hash well into very large tables.
9301 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
9302
9303 * dbusbind.c: Don't possibly lose pointer info when converting.
9304 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9305 Use XPNTR rather than XHASH, so that the high-order bits of
9306 the pointer aren't lost when converting through void *.
9307
9308 * eval.c (Fautoload): Don't double-shift a pointer.
9309
9310 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
9311
9312 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
9313
9314 * gnutls.c (DEF_GNUTLS_FN):
9315 * image.c (DEF_IMGLIB_FN): Make function pointers static.
9316
9317 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
9318
9319 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
9320 marker. (Bug#8610)
9321
9322 2011-05-05 Eli Zaretskii <eliz@gnu.org>
9323
9324 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
9325 New version that can reserve upto 2GB of heap space.
9326
9327 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
9328
9329 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
9330
9331 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
9332
9333 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
9334 `gnutls_certificate_set_x509_key_file'.
9335
9336 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
9337
9338 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
9339 Update dependencies.
9340
9341 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
9342
9343 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
9344 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
9345 Remove unused parameter `fildes'.
9346 * process.c (read_process_output, send_process): Don't pass it.
9347
9348 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
9349
9350 Fix previous change: the library cache is defined in w32.c.
9351 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
9352 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
9353
9354 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
9355
9356 Implement dynamic loading of GnuTLS on Windows.
9357
9358 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
9359 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
9360 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9361 Declare.
9362
9363 * gnutls.c (Qgnutls_dll): Define.
9364 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
9365 (gnutls_*): Declare function pointers.
9366 (init_gnutls_functions): New function to initialize function pointers.
9367 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
9368 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
9369 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9370 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
9371 (emacs_gnutls_write, emacs_gnutls_read)
9372 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
9373 (Fgnutls_available_p): New function.
9374 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
9375 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
9376 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
9377
9378 * image.c: Include w32.h.
9379 (Vimage_type_cache): Delete.
9380 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
9381 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
9382 (w32_delayed_load): Move to w32.c.
9383
9384 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
9385
9386 * w32.c (QCloaded_from, Vlibrary_cache): Define.
9387 (w32_delayed_load): Move from image.c. When loading a library, record
9388 its filename in the :loaded-from property of the library id.
9389 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
9390 Initialize and staticpro them.
9391 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
9392
9393 * process.c: Include lisp.h before w32.h, not after.
9394 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
9395 instead of gnutls_record_check_pending.
9396
9397 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
9398
9399 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
9400
9401 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
9402 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
9403 as passed in.
9404
9405 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
9406
9407 * xterm.c (x_set_frame_alpha): Do not set property on anything
9408 else than FRAME_X_OUTER_WINDOW (Bug#8608).
9409
9410 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
9411
9412 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
9413
9414 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
9415
9416 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
9417 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
9418 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
9419 (gnutls_global_initialized, Qgnutls_bootprop_priority)
9420 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
9421 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
9422 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
9423 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
9424 (Qgnutls_bootprop_callbacks_verify): Make static.
9425
9426 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
9427
9428 * callproc.c: Indentation fixup.
9429
9430 * sysdep.c (wait_for_termination_1): Make static.
9431 (wait_for_termination, interruptible_wait_for_termination):
9432 Move after wait_for_termination_1.
9433
9434 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
9435
9436 * sysdep.c (interruptible_wait_for_termination): New function
9437 which is like wait_for_termination, but allows keyboard
9438 interruptions.
9439
9440 * callproc.c (Fcall_process): Add (:file "file") as an option for
9441 the STDOUT buffer.
9442 (Fcall_process_region): Ditto.
9443
9444 2011-04-30 Eli Zaretskii <eliz@gnu.org>
9445
9446 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
9447 rather than `XVECTOR (FOO)->size'.
9448
9449 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
9450 inttypes.h, as a gnulib replacement is used if it not available in
9451 system headers.
9452
9453 2011-04-21 Eli Zaretskii <eliz@gnu.org>
9454
9455 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
9456 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
9457 of MOST_POSITIVE_FIXNUM. (Bug#8528)
9458
9459 * coding.c (coding_alloc_by_realloc): Error out if destination
9460 will grow beyond MOST_POSITIVE_FIXNUM.
9461 (decode_coding_emacs_mule): Abort if there isn't enough place in
9462 charbuf for the composition carryover bytes. Reserve an extra
9463 space for up to 2 characters produced in a loop.
9464 (decode_coding_iso_2022): Abort if there isn't enough place in
9465 charbuf for the composition carryover bytes.
9466
9467 2011-04-21 Eli Zaretskii <eliz@gnu.org>
9468
9469 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
9470 aborting when %lld or %lll format is passed.
9471 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
9472 %llo or %llx format is passed. (Bug#8545)
9473
9474 * window.c (window_scroll_line_based): Use a marker instead of
9475 simple variables to record original value of point. (Bug#7952)
9476
9477 * doprnt.c (doprnt): Fix the case where a multibyte sequence
9478 produced by %s or %c overflows available buffer space. (Bug#8545)
9479
9480 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
9481
9482 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
9483 (SIZE_MAX): Move defn after all includes, as they might #define it.
9484
9485 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
9486
9487 * w32.c (init_environment): Warn about defaulting HOME to C:\.
9488
9489 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
9490
9491 * keyboard.c (Qdelayed_warnings_hook): Define.
9492 (command_loop_1): Run `delayed-warnings-hook'
9493 if Vdelayed_warnings_list is non-nil.
9494 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
9495 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
9496
9497 2011-04-28 Eli Zaretskii <eliz@gnu.org>
9498
9499 * doprnt.c (doprnt): Don't return value smaller than the buffer
9500 size if the message was truncated. (Bug#8545).
9501
9502 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
9503
9504 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
9505 (Fx_window_property): #if-0 the whole functions, not just the bodies.
9506
9507 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9508
9509 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
9510
9511 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
9512
9513 * makefile.w32-in: Update dependencies.
9514
9515 2011-04-27 Eli Zaretskii <eliz@gnu.org>
9516
9517 Improve `doprnt' and its usage. (Bug#8545)
9518 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
9519 `format_end'. Remove support for %l as a conversion specifier.
9520 Don't use xrealloc. Improve diagnostics when the %l size modifier
9521 is used. Update the commentary.
9522
9523 * eval.c (verror): Simplify calculation of size_t.
9524
9525 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
9526 messages.
9527
9528 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
9529
9530 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
9531 change.
9532
9533 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9534
9535 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
9536 This makes this file independent of the recent pseudovector change.
9537
9538 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
9539
9540 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
9541
9542 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
9543 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
9544 Remove unused local.
9545 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
9546
9547 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
9548 GCC 4.6.0 optimizes based on type-based alias analysis.
9549 For example, if b is of type struct buffer * and v of type struct
9550 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
9551 != &v->size, and therefore "v->size = 1; b->size = 2; return
9552 v->size;" must therefore return 1. This assumption is incorrect
9553 for Emacs, since it type-puns struct Lisp_Vector * with many other
9554 types. To fix this problem, this patch adds a new type struct
9555 vectorlike_header that documents the constraints on layout of vectors
9556 and pseudovectors, and helps optimizing compilers not get fooled
9557 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
9558 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
9559 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
9560 the size member.
9561 (XSETPVECTYPE): Rewrite in terms of new macro.
9562 (XSETPVECTYPESIZE): New macro, specifying both type and size.
9563 This is a bit clearer, and further avoids the possibility of
9564 undesirable aliasing.
9565 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
9566 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
9567 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
9568 since Lisp_Subr is a special case (no "next" field).
9569 (ASIZE): Now uses header.size rather than size.
9570 All previous uses of XVECTOR (foo)->size replaced to use this macro,
9571 to avoid the hassle of writing XVECTOR (foo)->header.size.
9572 (struct vectorlike_header): New type.
9573 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
9574 object, to help avoid aliasing.
9575 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
9576 (SUBRP): Likewise, since Lisp_Subr is a special case.
9577 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
9578 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
9579 (struct Lisp_Hash_Table): Combine first two members into a single
9580 struct vectorlike_header member. All uses of "size" and "next" members
9581 changed to be "header.size" and "header.next".
9582 * buffer.h (struct buffer): Likewise.
9583 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
9584 * frame.h (struct frame): Likewise.
9585 * process.h (struct Lisp_Process): Likewise.
9586 * termhooks.h (struct terminal): Likewise.
9587 * window.c (struct save_window_data, struct saved_window): Likewise.
9588 * window.h (struct window): Likewise.
9589 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
9590 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
9591 * buffer.c (init_buffer_once): Likewise.
9592 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
9593 special case.
9594 * process.c (Fformat_network_address): Use local var for size,
9595 for brevity.
9596
9597 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
9598
9599 Make the Lisp reader and string-to-float more consistent (Bug#8525)
9600 * data.c (atof): Remove decl; no longer used or needed.
9601 (digit_to_number): Move to lread.c.
9602 (Fstring_to_number): Use new string_to_number function, to be
9603 consistent with how the Lisp reader treats infinities and NaNs.
9604 Do not assume that floating-point numbers represent EMACS_INT
9605 without losing information; this is not true on most 64-bit hosts.
9606 Avoid double-rounding errors, by insisting on integers when
9607 parsing non-base-10 numbers, as the documentation specifies.
9608 * lisp.h (string_to_number): New decl, replacing ...
9609 (isfloat_string): Remove.
9610 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
9611 (read1): Do not accept +. and -. as integers; this
9612 appears to have been a coding error. Similarly, do not accept
9613 strings like +-1e0 as floating point numbers. Do not report
9614 overflow for integer overflows unless the base is not 10 which
9615 means we have no simple and reliable way to continue.
9616 Break out the floating-point parsing into a new
9617 function string_to_number, so that Fstring_to_number parses
9618 floating point numbers consistently with the Lisp reader.
9619 (digit_to_number): Move here from data.c. Make it static inline.
9620 (E_CHAR, EXP_INT): Remove, replacing with ...
9621 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
9622 (string_to_number): New function, replacing isfloat_string.
9623 This function checks for valid syntax and produces the resulting
9624 Lisp float number too. Rework it so that string-to-number
9625 no longer mishandles examples like "1.0e+". Use strtoumax,
9626 so that overflow for non-base-10 numbers is reported only when
9627 there's no portable and simple way to convert to floating point.
9628
9629 * textprop.c (set_text_properties_1): Rewrite for clarity,
9630 and to avoid GCC warning about integer overflow.
9631
9632 * intervals.h (struct interval): Use EMACS_INT for members
9633 where EMACS_UINT might cause problems. See
9634 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
9635 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
9636 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
9637 All uses changed.
9638 (offset_intervals): Tell GCC not to worry about length overflow
9639 when negating a negative length.
9640
9641 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
9642 (overrun_check_free): Likewise.
9643
9644 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
9645 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
9646 word size.
9647
9648 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9649 (gnutls_make_error): Rename local to avoid shadowing.
9650 (gnutls_emacs_global_deinit): ifdef out; not used.
9651 (Fgnutls_boot): Use const for pointer to readonly storage.
9652 Comment out unused local. Fix pointer signedness problems.
9653
9654 * lread.c (openp): Don't stuff size_t into an 'int'.
9655 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
9656 about possible signed overflow.
9657
9658 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9659 (GDK_KEY_g): Don't define if already defined.
9660 (xg_prepare_tooltip): Avoid pointer signedness problem.
9661 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
9662
9663 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
9664 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
9665
9666 * xfns.c (Fx_window_property): Simplify a bit,
9667 to make a bit faster and to avoid GCC 4.6.0 warning.
9668 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
9669
9670 * fns.c (internal_equal): Don't assume size_t fits in int.
9671
9672 * alloc.c (compact_small_strings): Tighten assertion a little.
9673
9674 Replace pEd with more-general pI, and fix some printf arg casts.
9675 * lisp.h (pI): New macro, generalizing old pEd macro to other
9676 conversion specifiers. For example, use "...%"pI"d..." rather
9677 than "...%"pEd"...".
9678 (pEd): Remove. All uses replaced with similar uses of pI.
9679 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
9680 * alloc.c (check_pure_size): Don't overflow by converting size to int.
9681 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
9682 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
9683 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
9684 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
9685 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
9686 64-bit hosts.
9687 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
9688 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
9689 * print.c (safe_debug_print, print_object): Likewise.
9690 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
9691 to int.
9692 Use pI instead of if-then-else-abort. Use %p to avoid casts,
9693 avoiding the 0 flag, which is not portable.
9694 * process.c (Fmake_network_process): Use pI to avoid cast.
9695 * region-cache.c (pp_cache): Likewise.
9696 * xdisp.c (decode_mode_spec): Likewise.
9697 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
9698 behavior on 64-bit hosts with printf arg.
9699 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
9700 (x_stop_queuing_selection_requests): Likewise.
9701 (x_get_window_property): Don't truncate byte count to an 'int'
9702 when tracing.
9703
9704 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
9705 here, since it parses constructs like leading '-' and spaces,
9706 which are not wanted; and it overflows with large numbers.
9707 Instead, simply match F[0-9]+, which is what is wanted anyway.
9708
9709 * alloc.c: Remove unportable assumptions about struct layout.
9710 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
9711 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
9712 (allocate_vectorlike, make_pure_vector): Use the new macros,
9713 plus offsetof, to remove unportable assumptions about struct layout.
9714 These assumptions hold on all porting targets that I know of, but
9715 they are not guaranteed, they're easy to remove, and removing them
9716 makes further changes easier.
9717
9718 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
9719 This doesn't fix a bug but makes the code clearer.
9720 (string_overrun_cookie): Now const. Use initializers that
9721 don't formally overflow signed char, to avoid warnings.
9722 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
9723 can cause Emacs to crash when string overrun checking is enabled.
9724 (allocate_buffer): Don't assume sizeof (struct buffer) is a
9725 multiple of sizeof (EMACS_INT); it need not be, if
9726 alignof(EMACS_INT) < sizeof (EMACS_INT).
9727 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
9728
9729 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
9730
9731 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
9732
9733 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
9734
9735 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
9736 supposed to be handshaking. (Bug#8556)
9737 Reported by Paul Eggert <eggert@cs.ucla.edu>.
9738
9739 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
9740
9741 * lisp.h (Qdebug): List symbol.
9742 * eval.c (Qdebug): Restore global linkage.
9743 * keyboard.c (debug-on-event): New variable.
9744 (handle_user_signal): Break into debugger when debug-on-event
9745 matches the current signal symbol.
9746
9747 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
9748
9749 * alloc.c (check_sblock, check_string_bytes)
9750 (check_string_free_list): Convert to standard C.
9751
9752 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
9753
9754 * w32.c (emacs_gnutls_push): Fix typo.
9755
9756 2011-04-25 Eli Zaretskii <eliz@gnu.org>
9757
9758 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
9759 "cast to pointer from integer of different size".
9760
9761 Improve doprnt and its use in verror. (Bug#8545)
9762 * doprnt.c (doprnt): Document the set of format control sequences
9763 supported by the function. Use SAFE_ALLOCA instead of always
9764 using `alloca'.
9765
9766 * eval.c (verror): Don't limit the buffer size at size_max-1, that
9767 is one byte too soon. Don't use xrealloc; instead xfree and
9768 xmalloc anew.
9769
9770 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
9771
9772 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
9773 callbacks stage.
9774
9775 * gnutls.c: Renamed global_initialized to
9776 gnutls_global_initialized. Added internals for the
9777 :verify-hostname-error, :verify-error, and :verify-flags
9778 parameters of `gnutls-boot' and documented those parameters in the
9779 docstring. Start callback support.
9780 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
9781 unless a fatal error occurred. Call gnutls_alert_send_appropriate
9782 on error. Return error code.
9783 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
9784 (emacs_gnutls_read): Likewise.
9785 (Fgnutls_boot): Return handshake error code.
9786 (emacs_gnutls_handle_error): New function.
9787 (wsaerror_to_errno): Likewise.
9788
9789 * w32.h (emacs_gnutls_pull): Add prototype.
9790 (emacs_gnutls_push): Likewise.
9791
9792 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
9793 (emacs_gnutls_push): Likewise.
9794
9795 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
9796
9797 * process.c (wait_reading_process_output): Check if GnuTLS
9798 buffered some data internally if no FDs are set for TLS
9799 connections.
9800
9801 * makefile.w32-in (OBJ2): Add gnutls.$(O).
9802 (LIBS): Link to USER_LIBS.
9803 ($(BLD)/gnutls.$(0)): New target.
9804
9805 2011-04-24 Eli Zaretskii <eliz@gnu.org>
9806
9807 * xdisp.c (handle_single_display_spec): Rename the
9808 display_replaced_before_p argument into display_replaced_p, to
9809 make it consistent with the commentary. Fix typos in the
9810 commentary.
9811
9812 * textprop.c (syms_of_textprop): Remove dead code.
9813 (copy_text_properties): Delete obsolete commentary about an
9814 interface that was deleted long ago. Fix typos in the description
9815 of arguments.
9816
9817 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
9818 to changes in oldXMenu/XMenu.h from 2011-04-16.
9819 <menu_help_message, prev_menu_help_message>: Constify.
9820 (IT_menu_make_room): menu->help_text is now `const char **';
9821 adjust.
9822
9823 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
9824 to changes in oldXMenu/XMenu.h from 2011-04-16.
9825 (struct XMenu): Declare `help_text' `const char **'.
9826
9827 * xfaces.c <Qunspecified>: Make extern again.
9828
9829 * syntax.c: Include sys/types.h before including regex.h, as
9830 required by POSIX.
9831
9832 * doc.c (get_doc_string): Improve the format passed to `error'.
9833
9834 * doprnt.c (doprnt): Improve commentary.
9835
9836 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
9837
9838 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
9839 them with etags.
9840
9841 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
9842 changes in globals.h immediately force recompilation.
9843 (TAGS): Depend on $(CURDIR)/m/intel386.h and
9844 $(CURDIR)/s/ms-w32.h.
9845 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
9846
9847 * character.c (Fchar_direction): Function deleted.
9848 (syms_of_character): Don't defsubr it.
9849 <char-direction-table>: Deleted.
9850
9851 2011-04-23 Eli Zaretskii <eliz@gnu.org>
9852
9853 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
9854 * doprnt.c: Include limits.h.
9855 (SIZE_MAX): New macro.
9856 (doprnt): Return a size_t value. 2nd arg is now size_t.
9857 Many local variables are now size_t instead of int or unsigned.
9858 Improve overflow protection. Support `l' modifier for integer
9859 conversions. Support %l conversion. Don't assume an EMACS_INT
9860 argument for integer conversions and for %c.
9861
9862 * lisp.h (doprnt): Restore prototype.
9863
9864 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
9865 $(SRC)/character.h.
9866
9867 * Makefile.in (base_obj): Add back doprnt.o.
9868
9869 * deps.mk (doprnt.o): Add back prerequisites.
9870 (callint.o): Depend on character.h.
9871
9872 * eval.c (internal_lisp_condition_case): Include the handler
9873 representation in the error message.
9874 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
9875 when breaking from the loop.
9876
9877 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
9878
9879 * callint.c (Fcall_interactively): When displaying error message
9880 about invalid control letter, pass the character's codepoint, not
9881 a pointer to its multibyte form. Improve display of the character
9882 in octal and display also its hex code.
9883
9884 * character.c (char_string): Use %x to display the (unsigned)
9885 codepoint of an invalid character, to avoid displaying a bogus
9886 negative value.
9887
9888 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
9889 `error', not SYMBOL_NAME itself.
9890
9891 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
9892 character arguments to `error'.
9893
9894 * charset.c (check_iso_charset_parameter): Fix incorrect argument
9895 to `error' in error message about FINAL_CHAR argument. Make sure
9896 FINAL_CHAR is a character, and use %c when it is passed as
9897 argument to `error'.
9898
9899 2011-04-23 Eli Zaretskii <eliz@gnu.org>
9900
9901 * s/ms-w32.h (localtime): Redirect to sys_localtime.
9902
9903 * w32.c: Include <time.h>.
9904 (sys_localtime): New function.
9905
9906 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
9907
9908 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
9909
9910 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
9911
9912 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
9913
9914 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
9915 zombies (Bug#8467).
9916
9917 2011-04-19 Eli Zaretskii <eliz@gnu.org>
9918
9919 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
9920 gl_state.e_property when gl_state.object is Qt.
9921
9922 * insdel.c (make_gap_larger): Remove limitation of buffer size
9923 to <= INT_MAX.
9924
9925 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
9926
9927 * xdisp.c (lookup_glyphless_char_display)
9928 (produce_glyphless_glyph): Handle cons cell entry in
9929 glyphless-char-display.
9930 (Vglyphless_char_display): Document it.
9931
9932 * term.c (produce_glyphless_glyph): Handle cons cell entry in
9933 glyphless-char-display.
9934
9935 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
9936
9937 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
9938
9939 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
9940
9941 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
9942 definition for no-X builds.
9943
9944 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
9945
9946 Static checks with GCC 4.6.0 and non-default toolkits.
9947
9948 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
9949
9950 * process.c (keyboard_bit_set): Define only if SIGIO.
9951 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
9952 (send_process): Repair possible setjmp clobbering.
9953
9954 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
9955
9956 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
9957
9958 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
9959
9960 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
9961 Define only if needed.
9962
9963 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
9964 by pacifying GCC about it. Maybe it's time to retire it?
9965 * xfaces.c (USG, __TIMEVAL__): Likewise.
9966
9967 * dispextern.h (struct redisplay_interface): Rename param
9968 to avoid shadowing.
9969 * termhooks.h (struct terminal): Likewise.
9970 * xterm.c (xembed_send_message): Likewise.
9971
9972 * insdel.c (make_gap_smaller): Define only if
9973 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
9974
9975 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
9976 it.
9977
9978 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
9979 so that we aren't warned about unused symbols.
9980
9981 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
9982
9983 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
9984
9985 * xfns.c (x_real_positions): Mark locals as initialized.
9986
9987 * xmenu.c (xmenu_show): Don't use uninitialized vars.
9988
9989 * xterm.c: Fix problems found by static analysis with other toolkits.
9990 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
9991 (x_dispatch_event): Declare static if USE_GTK, and
9992 define if USE_GTK || USE_X_TOOLKIT.
9993 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
9994 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
9995 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
9996 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
9997
9998 * xmenu.c (menu_help_callback): Pointer type fixes.
9999 Use const pointers when pointing at readonly data. Avoid pointer
10000 signedness clashes.
10001 (FALSE): Remove unused macro.
10002 (update_frame_menubar): Remove unused decl.
10003
10004 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
10005
10006 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
10007 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
10008 (single_menu_item): Rename local to avoid shadowing.
10009
10010 * keyboard.c (make_lispy_event): Remove unused local var.
10011
10012 * frame.c, frame.h (x_get_resource_string): Bring this back, but
10013 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
10014
10015 * bitmaps: Change bitmaps from unsigned char back to the X11
10016 compatible char. Avoid the old compiler warnings about
10017 out-of-range initializers by using, for example, '\xab' rather
10018 than 0xab.
10019
10020 * xgselect.c (xgselect_initialize): Check vs interface
10021 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
10022
10023 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
10024
10025 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
10026 to read-only memory.
10027
10028 * fns.c (vector): Remove; this old hack is no longer needed.
10029
10030 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
10031 Remove unused var.
10032 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
10033
10034 * xrdb.c (x_load_resources): Omit unused local.
10035
10036 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
10037 (x_window): Rename locals to avoid shadowing.
10038 (USG): Use the kludged USG macro, to pacify gcc.
10039
10040 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
10041 (x_term_init): Remove local to avoid shadowing.
10042
10043 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
10044
10045 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
10046 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
10047
10048 2011-04-16 Eli Zaretskii <eliz@gnu.org>
10049
10050 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
10051
10052 Fix regex.c, syntax.c and friends for buffers > 2GB.
10053 * syntax.h (struct gl_state_s): Declare character position members
10054 EMACS_INT.
10055
10056 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
10057
10058 * textprop.c (verify_interval_modification, interval_of):
10059 Declare arguments EMACS_INT.
10060
10061 * intervals.c (adjust_intervals_for_insertion): Declare arguments
10062 EMACS_INT.
10063
10064 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
10065
10066 * indent.c (Fvertical_motion): Local variable it_start is now
10067 EMACS_INT.
10068
10069 * regex.c (re_match, re_match_2, re_match_2_internal)
10070 (bcmp_translate, regcomp, regexec, print_double_string)
10071 (group_in_compile_stack, re_search, re_search_2, regex_compile)
10072 (re_compile_pattern, re_exec): Declare arguments and local
10073 variables `size_t' and `ssize_t' and return values `regoff_t', as
10074 appropriate.
10075 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
10076 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
10077 <compile_stack_type>: `size' and `avail' are now `size_t'.
10078
10079 * regex.h <regoff_t>: Use ssize_t, not int.
10080 (re_search, re_search_2, re_match, re_match_2): Arguments that
10081 specify buffer/string position and length are now ssize_t and
10082 size_t. Return type is regoff_t.
10083
10084 2011-04-16 Ben Key <bkey76@gmail.com>
10085
10086 * nsfont.m: Fixed bugs in ns_get_family and
10087 ns_descriptor_to_entity that were caused by using free to
10088 deallocate memory blocks that were allocated by xmalloc (via
10089 xstrdup). This caused Emacs to crash when compiled with
10090 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
10091 --enable-checking=xmallocoverrun). xfree is now used to
10092 deallocate these memory blocks.
10093
10094 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
10095
10096 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
10097
10098 emacs_write: Accept and return EMACS_INT for sizes.
10099 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
10100 et seq.
10101 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
10102 Accept and return EMACS_INT.
10103 (emacs_gnutls_write): Return the number of bytes written on
10104 partial writes.
10105 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
10106 (emacs_read, emacs_write): Remove check for negative size, as the
10107 Emacs source code has been audited now.
10108 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
10109 (emacs_read, emacs_write): Use it.
10110 * process.c (send_process): Adjust to the new signatures of
10111 emacs_write and emacs_gnutls_write. Do not attempt to store
10112 a byte offset into an 'int'; it might overflow.
10113 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
10114
10115 * sound.c: Don't assume sizes fit in 'int'.
10116 (struct sound_device.period_size, alsa_period_size):
10117 Return EMACS_INT, not int.
10118 (struct sound_device.write, vox_write, alsa_write):
10119 Accept EMACS_INT, not int.
10120 (wav_play, au_play): Use EMACS_INT to store sizes and to
10121 record read return values.
10122
10123 2011-04-15 Ben Key <bkey76@gmail.com>
10124
10125 * keyboard.c (Qundefined): Don't declare static since it is used
10126 in nsfns.m.
10127 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
10128 static since they are used in nsfont.m.
10129
10130 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
10131
10132 * process.c (Qprocessp): Don't declare static.
10133 * lisp.h (Qprocessp): Declare again.
10134
10135 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
10136
10137 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
10138
10139 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
10140
10141 Improve C-level modularity by making more things 'static'.
10142
10143 Don't publish debugger-only interfaces to other modules.
10144 * lisp.h (safe_debug_print, debug_output_compilation_hack):
10145 (verify_bytepos, count_markers): Move decls to the only modules
10146 that need them.
10147 * region-cache.h (pp_cache): Likewise.
10148 * window.h (check_all_windows): Likewise.
10149 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
10150
10151 * sysdep.c (croak): Now static, if
10152 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
10153 * syssignal.h (croak): Declare only if not static.
10154
10155 * alloc.c (refill_memory_reserve): Now static if
10156 !defined REL_ALLOC || defined SYSTEM_MALLOC.
10157 * lisp.h (refill_memory_reserve): Declare only if not static.
10158
10159 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
10160 Define only if USE_LUCID.
10161
10162 * xrdb.c (x_customization_string, x_rm_string): Now static.
10163
10164 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
10165 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
10166
10167 * xdisp.c (draw_row_with_mouse_face): Now static.
10168 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
10169
10170 * window.h (check_all_windows): Mark externally visible.
10171
10172 * window.c (window_deletion_count): Now static.
10173
10174 * undo.c: Make symbols static if they're not exported.
10175 (last_undo_buffer, last_boundary_position, pending_boundary):
10176 Now static.
10177
10178 * textprop.c (interval_insert_behind_hooks): Now static.
10179 (interval_insert_in_front_hooks): Likewise.
10180
10181 * term.c: Make symbols static if they're not exported.
10182 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
10183 (max_frame_lines, tty_set_terminal_modes):
10184 (tty_reset_terminal_modes, tty_turn_off_highlight):
10185 (get_tty_terminal): Now static.
10186 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
10187 * termhooks.h (term_mouse_moveto): Do not declare if
10188 HAVE_WINDOW_SYSTEM.
10189 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
10190 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
10191
10192 * sysdep.c: Make symbols static if they're not exported.
10193 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
10194 Now static.
10195 (sigprocmask_set, full_mask): Remove; unused.
10196 (wait_debugging): Mark as visible.
10197 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
10198 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
10199
10200 * syntax.c (syntax_temp): Define only if !__GNUC__.
10201
10202 * sound.c (current_sound_device, current_sound): Now static.
10203
10204 * search.c (searchbufs, searchbuf_head): Now static.
10205
10206 * scroll.c (scroll_cost): Remove; unused.
10207 * dispextern.h (scroll_cost): Remove decl.
10208
10209 * region-cache.h (pp_cache): Mark as externally visible.
10210
10211 * process.c: Make symbols static if they're not exported.
10212 (process_tick, update_tick, create_process, chan_process):
10213 (Vprocess_alist, proc_buffered_char, datagram_access):
10214 (fd_callback_data, send_process_frame, process_sent_to): Now static.
10215 (deactivate_process): Mark defn as static, as well as decl.
10216 * lisp.h (create_process): Remove decl.
10217 * process.h (chan_process, Vprocess_alist): Remove decls.
10218
10219 * print.c: Make symbols static if they're not exported.
10220 (print_depth, new_backquote_output, being_printed, print_buffer):
10221 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
10222 (print_interval, print_number_index, initial_stderr_stream):
10223 Now static.
10224 * lisp.h (Fprinc): Remove decl.
10225 (debug_output_compilation_hack): Mark as externally visible.
10226
10227 * sysdep.c (croak): Move decl from here to syssignal.h.
10228 * syssignal.h (croak): Put it here, so the API can be checked when
10229 'croak' is called from dissociate_if_controlling_tty.
10230
10231 * minibuf.c: Make symbols static if they're not exported.
10232 (minibuf_save_list, choose_minibuf_frame): Now static.
10233 * lisp.h (choose_minibuf_frame): Remove decl.
10234
10235 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
10236
10237 * lread.c: Make symbols static if they're not exported.
10238 (read_objects, initial_obarray, oblookup_last_bucket_number):
10239 Now static.
10240 (make_symbol): Remove; unused.
10241 * lisp.h (initial_obarray, make_symbol): Remove decls.
10242
10243 * keyboard.c: Make symbols static if they're not exported.
10244 (single_kboard, recent_keys_index, total_keys, recent_keys):
10245 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
10246 (this_single_command_key_start, echoing, last_auto_save):
10247 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
10248 (command_loop, echo_now, keyboard_init_hook, help_char_p):
10249 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
10250 (Vlispy_mouse_stem, double_click_count):
10251 Now static.
10252 (force_auto_save_soon): Define only if SIGDANGER.
10253 (ignore_mouse_drag_p): Now static if
10254 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
10255 (print_help): Remove; unused.
10256 (stop_character, last_timer_event): Mark as externally visible.
10257 * keyboard.h (ignore_mouse_drag_p): Declare only if
10258 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
10259 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
10260 * lisp.h (echoing): Remove decl.
10261 (force_auto_save_soon): Declare only if SIGDANGER.
10262 * xdisp.c (redisplay_window): Simplify code, to make it more
10263 obvious that ignore_mouse_drag_p is not accessed if !defined
10264 USE_GTK && !defined HAVE_NS.
10265
10266 * intervals.c: Make symbols static if they're not exported.
10267 (merge_properties_sticky, merge_interval_right, delete_interval):
10268 Now static.
10269 * intervals.h (merge_interval_right, delete_interval): Remove decls.
10270
10271 * insdel.c: Make symbols static if they're not exported.
10272 However, leave prepare_to_modify_buffer alone. It's never
10273 called from outside this function, but that appears to be a bug.
10274 (combine_after_change_list, combine_after_change_buffer):
10275 (adjust_after_replace, signal_before_change): Now static.
10276 (adjust_after_replace_noundo): Remove; unused.
10277 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
10278 (signal_before_change): Remove decls.
10279
10280 * indent.c (val_compute_motion, val_vmotion): Now static.
10281
10282 * image.c: Make symbols static if they're not exported.
10283 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
10284 if USE_GTK.
10285 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
10286 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
10287
10288 * fringe.c (standard_bitmaps): Now static.
10289 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
10290
10291 * frame.c: Make symbols static if they're not exported.
10292 (x_report_frame_params, make_terminal_frame): Now static.
10293 (get_frame_param): Now static, unless HAVE_NS.
10294 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
10295 (x_get_resource_string): Remove; not used.
10296 * frame.h (make_terminal_frame, x_report_frame_params):
10297 (x_get_resource_string); Remove decls.
10298 (x_fullscreen_adjust): Declare only if WINDOWSNT.
10299 * lisp.h (get_frame_param): Declare only if HAVE_NS.
10300
10301 * font.c, fontset.c: Make symbols static if they're not exported.
10302 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
10303 (FACE_SUITABLE_FOR_CHAR_P): Use it.
10304 * font.c (font_close_object): Now static.
10305 * font.h (font_close_object): Remove.
10306 * fontset.c (FONTSET_OBJLIST): Remove.
10307 (free_realized_fontset) #if-0 the body, which does nothing.
10308 (face_suitable_for_char_p): #if-0, as it's never called.
10309 * fontset.h (face_suitable_for_char_p): Remove decl.
10310 * xfaces.c (face_at_string_position):
10311 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
10312 since 0 is always ASCII.
10313
10314 * fns.c (weak_hash_tables): Now static.
10315
10316 * fileio.c: Make symbols static if they're not exported.
10317 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
10318 (Vwrite_region_annotation_buffers): Now static.
10319
10320 * eval.c: Make symbols static if they're not exported.
10321 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
10322 * lisp.h (backtrace_list): Remove decl.
10323
10324 * emacs.c: Make symbols static if they're not exported.
10325 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
10326 (fatal_error_code, fatal_error_signal_hook, standard_args):
10327 Now static.
10328 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
10329 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
10330 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
10331 * lisp.h (fatal_error_signal_hook): Remove decl.
10332 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
10333
10334 * editfns.c: Move a (normally-unused) function to its only use.
10335 * editfns.c, lisp.h (get_operating_system_release): Remove.
10336 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
10337 worth the hassle of breaking this out.
10338
10339 * xterm.c: Make symbols static if they're not exported.
10340 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
10341 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
10342 (x_destroy_window, x_delete_display):
10343 Now static.
10344 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
10345 (x_mouse_leave): Remove; unused.
10346 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
10347 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
10348 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
10349 Remove decls.
10350 (x_mouse_leave): Declare only if WINDOWSNT.
10351 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
10352 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
10353 USE_X_TOOLKIT.
10354
10355 * ftxfont.c: Make symbols static if they're not exported.
10356 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
10357 HAVE_FREETYPE.
10358 * font.h (ftxfont_driver): Likewise.
10359
10360 * xfns.c: Make symbols static if they're not exported.
10361 (x_last_font_name, x_display_info_for_name):
10362 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
10363 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
10364 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
10365 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
10366 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
10367 (last_show_tip_args): Now static.
10368 (xic_defaut_fontset, xic_create_fontsetname): Define only if
10369 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
10370 (x_screen_planes): Remove; unused.
10371 * dispextern.h (x_screen_planes): Remove decl.
10372
10373 * dispnew.c: Make symbols static if they're not exported.
10374 * dispextern.h (redraw_garbaged_frames, scrolling):
10375 (increment_row_positions): Remove.
10376 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
10377 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
10378 Now static.
10379 (redraw_garbaged_frames): Remove; unused.
10380
10381 * xfaces.c: Make symbols static if they're not exported.
10382 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
10383 Remove decls.
10384 * xterm.h (defined_color): Remove decls.
10385 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
10386 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
10387 (menu_face_changed_default, defined_color, free_realized_face):
10388 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
10389 (ascii_face_of_lisp_face): Remove; unused.
10390
10391 * xdisp.c: Make symbols static if they're not exported.
10392 * dispextern.h (scratch_glyph_row, window_box_edges):
10393 (glyph_to_pixel_coords, set_cursor_from_row):
10394 (get_next_display_element, set_iterator_to_next):
10395 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
10396 (show_mouse_face): Remove decls
10397 * frame.h (message_buf_print): Likewise.
10398 * lisp.h (pop_message, set_message, check_point_in_composition):
10399 Likewise.
10400 * xterm.h (set_vertical_scroll_bar): Likewise.
10401 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
10402 (message_buf_print, scratch_glyph_row, displayed_buffer):
10403 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
10404 (get_next_display_element, show_mouse_face, window_box_edges):
10405 (frame_to_window_pixel_xy, check_point_in_composition):
10406 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
10407 (glyph_to_pixel_coords): Remove; unused.
10408
10409 * dired.c (file_name_completion): Now static.
10410
10411 * dbusbind.c (xd_in_read_queued_messages): Now static.
10412
10413 * lisp.h (circular_list_error, FOREACH): Remove; unused.
10414 * data.c (circular_list_error): Remove.
10415
10416 * commands.h (last_point_position, last_point_position_buffer):
10417 (last_point_position_window): Remove decls.
10418 * keyboard.c: Make these variables static.
10419
10420 * coding.h (coding, code_convert_region, encode_coding_gap):
10421 Remove decls.
10422 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
10423 (iso_code_class, detect_coding, code_convert_region): Now static.
10424 (encode_coding_gap): Remove; unused.
10425
10426 * chartab.c (chartab_chars, chartab_bits): Now static.
10427
10428 * charset.h (charset_iso_8859_1): Remove decl.
10429 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
10430 Now static.
10431
10432 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
10433 * ccl.c (Vccl_program_table): Now static.
10434 (check_ccl_update): Remove; unused.
10435
10436 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
10437 * category.h: ... from here.
10438 * category.c (check_category_table, set_category_set): Now static.
10439
10440 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
10441 * lisp.h: Remove these decls.
10442
10443 * buffer.c (buffer_count): Remove unused var.
10444
10445 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
10446 so that it's not optimized away.
10447 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
10448 * dispextern.h (bidi_dump_cached_states): Remove, since it's
10449 exported only to the debugger.
10450
10451 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
10452 * atimer.h (run_all_atimers): Remove; not exported.
10453
10454 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
10455 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
10456 was inaccessible from Lisp.
10457 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
10458 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
10459
10460 alloc.c: Import and export fewer symbols, and remove unused items.
10461 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
10462 is defined.
10463 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
10464 it's not optimized away by whole-program optimization.
10465 (message_enable_multibyte, free_misc): Remove.
10466 (catchlist, handlerlist, mark_backtrace):
10467 Declare only if BYTE_MARK_STACK.
10468 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
10469 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
10470 (message_enable_multibyte): Remove decl.
10471 (free_misc, interval_free_list, float_block, float_block_index):
10472 (n_float_blocks, float_free_list, cons_block, cons_block_index):
10473 (cons_free_list, last_marked_index):
10474 Now static.
10475 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
10476 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
10477 (mark_backtrace): Define only if BYTE_MARK_STACK.
10478 * xdisp.c (message_enable_multibyte): Now static.
10479
10480 Declare Lisp_Object Q* variables to be 'static' if not exported.
10481 This makes it easier for human readers (and static analyzers)
10482 to see whether these variables are used from other modules.
10483 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
10484 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
10485 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
10486 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
10487 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
10488 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
10489 * xmenu.c, xselect.c:
10490 Declare Q* vars static if they are not used in other modules.
10491 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
10492 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
10493 Remove decls of unexported vars.
10494 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
10495
10496 * lisp.h (DEFINE_FUNC): Make sname 'static'.
10497
10498 Make Emacs functions such as Fatom 'static' by default.
10499 This makes it easier for human readers (and static analyzers)
10500 to see whether these functions can be called from other modules.
10501 DEFUN now defines a static function. To make the function external
10502 so that it can be used in other C modules, use the new macro DEFUE.
10503 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
10504 (Finit_image_library):
10505 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
10506 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
10507 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
10508 Remove decls, since these functions are now static.
10509 (Funintern, Fget_internal_run_time): New decls, since these functions
10510 were already external.
10511
10512 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
10513 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
10514 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
10515 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
10516 * keyboard.c, keymap.c, lread.c:
10517 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
10518 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
10519 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
10520 Mark functions with DEFUE instead of DEFUN,
10521 if they are used in other modules.
10522 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
10523 decls for now-static functions.
10524 * buffer.h (Fdelete_overlay): Remove decl.
10525 * callproc.c (Fgetenv_internal): Mark as internal.
10526 * composite.c (Fremove_list_of_text_properties): Remove decl.
10527 (Fcomposition_get_gstring): New forward static decl.
10528 * composite.h (Fcomposite_get_gstring): Remove decl.
10529 * dired.c (Ffile_attributes): New forward static decl.
10530 * doc.c (Fdocumntation_property): New forward static decl.
10531 * eval.c (Ffetch_bytecode): New forward static decl.
10532 (Funintern): Remove extern decl; now in .h file where it belongs.
10533 * fileio.c (Fmake_symbolic_link): New forward static decl.
10534 * image.c (Finit_image_library): New forward static decl.
10535 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
10536 * intervals.h (Fprevious_property_change):
10537 (Fremove_list_of_text_properties): Remove decls.
10538 * keyboard.c (Fthis_command_keys): Remove decl.
10539 (Fcommand_execute): New forward static decl.
10540 * keymap.c (Flookup_key): New forward static decl.
10541 (Fcopy_keymap): Now static.
10542 * keymap.h (Flookup_key): Remove decl.
10543 * process.c (Fget_process): New forward static decl.
10544 (Fprocess_datagram_address): Mark as internal.
10545 * syntax.c (Fsyntax_table_p): New forward static decl.
10546 (skip_chars): Remove duplicate decl.
10547 * textprop.c (Fprevious_property_change): New forward static decl.
10548 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
10549 Now internal.
10550 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
10551 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
10552
10553 * editfns.c (Fformat): Remove unreachable code.
10554
10555 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
10556
10557 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
10558 change. (Bug#8496)
10559
10560 2011-04-13 Eli Zaretskii <eliz@gnu.org>
10561
10562 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
10563 when at ZV. (Bug#8487)
10564
10565 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
10566
10567 * charset.c (Fclear_charset_maps): Use xfree instead of free.
10568 (Bug#8437)
10569 * keyboard.c (parse_tool_bar_item): Likewise.
10570 * sound.c (sound_cleanup, alsa_close): Likewise.
10571 * termcap.c (tgetent): Likewise.
10572 * xfns.c (x_default_font_parameter): Likewise.
10573 * xsettings.c (read_and_apply_settings): Likewise.
10574
10575 * alloc.c (overrun_check_malloc, overrun_check_realloc)
10576 (overrun_check_free): Protoize.
10577
10578 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
10579
10580 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
10581 since callers should never pass a negative size.
10582 Change the signature to match that of plain 'read' and 'write'; see
10583 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
10584 * lisp.h: Update prototypes of emacs_write and emacs_read.
10585
10586 2011-04-11 Eli Zaretskii <eliz@gnu.org>
10587
10588 * xdisp.c (redisplay_window): Don't try to determine the character
10589 position of the scroll margin if the window start point w->startp
10590 is outside the buffer's accessible region. (Bug#8468)
10591
10592 2011-04-10 Eli Zaretskii <eliz@gnu.org>
10593
10594 Fix write-region and its subroutines for buffers > 2GB.
10595 * fileio.c (a_write, e_write): Modify declaration of arguments and
10596 local variables to support buffers larger than 2GB.
10597 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
10598
10599 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
10600 argument, local variables, and return value.
10601
10602 * lisp.h: Update prototypes of emacs_write and emacs_read.
10603
10604 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
10605
10606 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
10607
10608 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
10609
10610 Fix more problems found by GCC 4.6.0's static checks.
10611
10612 * xdisp.c (vmessage): Use a better test for character truncation.
10613
10614 * charset.c (load_charset_map): <, not <=, for optimization,
10615 and to avoid potential problems with integer overflow.
10616 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
10617 * casetab.c (set_identity, shuffle): Likewise.
10618 * editfns.c (Fformat): Likewise.
10619 * syntax.c (skip_chars): Likewise.
10620
10621 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
10622 This also lets GCC 4.6.0 generate slightly better loop code.
10623
10624 * callint.c (Fcall_interactively): <, not <=, for optimization.
10625 (Fcall_interactively): Count the number of arguments produced,
10626 not the number of arguments given. This is simpler and lets GCC
10627 4.6.0 generate slightly better code.
10628
10629 * ftfont.c: Distingish more carefully between FcChar8 and char.
10630 The previous code passed unsigned char * to a functions like
10631 strlen and xstrcasecmp that expect char *, which does not
10632 conform to the C standard.
10633 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
10634 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
10635 char * when the C standard requires it.
10636
10637 * keyboard.c (read_char): Remove unused var.
10638
10639 * eval.c: Port to Windows vsnprintf (Bug#8435).
10640 Include <limits.h>.
10641 (SIZE_MAX): Define if the headers do not.
10642 (verror): Do not give up if vsnprintf returns a negative count.
10643 Instead, grow the buffer. This ports to Windows vsnprintf, which
10644 does not conform to C99. Problem reported by Eli Zaretskii.
10645 Also, simplify the allocation scheme, by avoiding the need for
10646 calling realloc, and removing the ALLOCATED variable.
10647
10648 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
10649
10650 Remove invocations of doprnt, as Emacs now uses vsnprintf.
10651 But keep the doprint source code for now, as we might revamp it
10652 and use it again (Bug#8435).
10653 * lisp.h (doprnt): Remove.
10654 * Makefile.in (base_obj): Remove doprnt.o.
10655 * deps.mk (doprnt.o): Remove.
10656
10657 error: Print 32- and 64-bit integers portably (Bug#8435).
10658 Without this change, on typical 64-bit hosts error ("...%d...", N)
10659 was used to print both 32- and 64-bit integers N, which relied on
10660 undefined behavior.
10661 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
10662 * lisp.h (error, verror): Mark as printf-like functions.
10663 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
10664 Report overflow in size calculations when allocating printf buffer.
10665 Do not truncate output string at its first null byte.
10666 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
10667 Truncate the output at a character boundary, since vsnprintf does not
10668 do that.
10669 * charset.c (check_iso_charset_parameter): Convert internal
10670 character to string before calling 'error', since %c now has the
10671 printf meaning.
10672 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
10673 overflow when computing char to be passed to 'error'. Do not
10674 pass Lisp_Object to 'error'; pass the integer instead.
10675 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
10676 formatted with plain %d.
10677
10678 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
10679
10680 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
10681
10682 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
10683
10684 * xterm.c (x_catch_errors): Remove duplicate declaration.
10685
10686 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
10687
10688 * xdisp.c, lisp.h (message_nolog): Remove; unused.
10689
10690 2011-04-10 Jim Meyering <meyering@redhat.com>
10691
10692 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
10693 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
10694 return ssize_t not "int", and use size_t as the buffer length.
10695 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
10696 * gnutls.h: Update declarations.
10697 * process.c (read_process_output): Use ssize_t, to match.
10698 (send_process): Likewise.
10699
10700 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
10701
10702 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
10703
10704 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
10705
10706 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
10707 Use unsigned char, to match FcChar8 type definition.
10708
10709 * xterm.c (handle_one_xevent):
10710 * xmenu.c (create_and_show_popup_menu):
10711 * xselect.c (x_decline_selection_request)
10712 (x_reply_selection_request): Avoid type-punned deref of X events.
10713
10714 2011-04-09 Eli Zaretskii <eliz@gnu.org>
10715
10716 Fix some uses of `int' instead of EMACS_INT.
10717 * search.c (string_match_1, fast_string_match)
10718 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
10719 (scan_buffer, find_next_newline_no_quit)
10720 (find_before_next_newline, search_command, Freplace_match)
10721 (Fmatch_data): Make some `int' variables be EMACS_INT.
10722
10723 * xdisp.c (display_count_lines): 3rd argument and return value now
10724 EMACS_INT. All callers changed.
10725 (pint2hrstr): Last argument is now EMACS_INT.
10726
10727 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
10728 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
10729 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
10730 (decode_coding_utf_16, decode_coding_emacs_mule)
10731 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
10732 (decode_coding_ccl, decode_coding_charset)
10733 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
10734 (decode_coding_iso_2022, decode_coding_emacs_mule)
10735 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
10736 <char_offset, last_offset>: Declare EMACS_INT.
10737 (encode_coding_utf_8, encode_coding_utf_16)
10738 (encode_coding_emacs_mule, encode_invocation_designation)
10739 (encode_designation_at_bol, encode_coding_iso_2022)
10740 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
10741 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
10742 Declare EMACS_INT.
10743 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
10744 (encode_invocation_designation): Last argument P_NCHARS is now
10745 EMACS_INT.
10746 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
10747 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
10748
10749 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
10750 All users changed.
10751
10752 * ccl.c (Fccl_execute_on_string): Declare some variables
10753 EMACS_INT.
10754
10755 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
10756
10757 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
10758
10759 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
10760
10761 * process.c (Fformat_network_address): Doc fix.
10762
10763 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
10764
10765 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
10766
10767 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
10768
10769 * keyboard.c (read_char): Call Lisp function help-form-show,
10770 instead of using internal_with_output_to_temp_buffer.
10771 (Qhelp_form_show): New var.
10772 (syms_of_keyboard): Use DEFSYM macro.
10773
10774 * print.c (internal_with_output_to_temp_buffer): Function deleted.
10775
10776 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
10777
10778 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
10779
10780 * process.c (Flist_processes): Remove to Lisp.
10781 (list_processes_1): Delete.
10782
10783 2011-04-06 Eli Zaretskii <eliz@gnu.org>
10784
10785 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
10786
10787 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
10788
10789 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
10790
10791 Fix more problems found by GCC 4.6.0's static checks.
10792
10793 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
10794
10795 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
10796
10797 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
10798
10799 * xdisp.c (vmessage): Mark as a printf-like function.
10800
10801 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
10802
10803 * sound.c (sound_warning): Don't crash if arg contains a printf format.
10804
10805 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
10806 printf-like functions.
10807 (tiff_load): Add casts to remove these marks before passing them
10808 to system-supplied API.
10809
10810 * eval.c (Fsignal): Remove excess argument to 'fatal'.
10811
10812 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
10813 This avoids several warnings with gcc -Wstrict-overflow.
10814 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
10815 directly, rather than having caller test rule sign. This avoids
10816 some unnecessary tests.
10817 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
10818 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
10819 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
10820
10821 * xfont.c (xfont_text_extents): Remove var that was set but not used.
10822 (xfont_open): Avoid unnecessary tests.
10823
10824 * composite.c (composition_gstring_put_cache): Use unsigned integer.
10825
10826 * composite.h, composite.c (composition_gstring_put_cache):
10827 Use EMACS_INT, not int, for length.
10828
10829 * composite.h (COMPOSITION_DECODE_REFS): New macro,
10830 breaking out part of COMPOSITION_DECODE_RULE.
10831 (COMPOSITION_DECODE_RULE): Use it.
10832 * composite.c (get_composition_id): Remove unused local vars,
10833 by using the new macro.
10834
10835 * textprop.c (set_text_properties_1): Change while to do-while,
10836 since the condition is always true at first.
10837
10838 * intervals.c (graft_intervals_into_buffer): Mark var as used.
10839 (interval_deletion_adjustment): Return unsigned value.
10840 All uses changed.
10841
10842 * process.c (list_processes_1, create_pty, read_process_output):
10843 (exec_sentinel): Remove vars that were set but not used.
10844 (create_pty): Remove unnecessary "volatile"s.
10845 (Fnetwork_interface_info): Avoid possibility of int overflow.
10846 (read_process_output): Do adaptive read buffering even if carryover.
10847 (read_process_output): Simplify nbytes computation if buffered.
10848
10849 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
10850
10851 * syntax.c (scan_words): Remove var that was set but not used.
10852 (update_syntax_table): Use unsigned instead of int.
10853
10854 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
10855 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
10856 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
10857
10858 * print.c (print_error_message): Avoid int overflow.
10859
10860 * font.c (font_list_entities): Redo for clarity,
10861 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
10862
10863 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
10864 (font_score): Avoid potential overflow in diff calculation.
10865
10866 * fns.c (substring_both): Remove var that is set but not used.
10867 (sxhash): Redo loop for clarity and to avoid wraparound warning.
10868
10869 * eval.c (funcall_lambda): Rename local to avoid shadowing.
10870
10871 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
10872 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
10873 can always succeed if overflow has undefined behavior.
10874
10875 * search.c (boyer_moore, wordify): Remove vars set but not used.
10876 (wordify): Omit three unnecessary tests.
10877
10878 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
10879 All callers changed. This avoids the need for an unused var.
10880
10881 * casefiddle.c (casify_region): Remove var that is set but not used.
10882
10883 * dired.c (file_name_completion): Remove var that is set but not used.
10884
10885 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
10886
10887 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
10888 (Finsert_file_contents): Remove unnecessary code checking fd.
10889
10890 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
10891 Check for integer overflow on size calculations.
10892
10893 * buffer.c (Fprevious_overlay_change): Remove var that is set
10894 but not used.
10895
10896 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
10897 Remove vars that are set but not used.
10898 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
10899 (timer_check_2): Mark vars as initialized.
10900
10901 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
10902
10903 * image.c (lookup_image): Remove var that is set but not used.
10904 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
10905
10906 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
10907 that are set but not used.
10908
10909 * xfns.c (make_invisible_cursor): Don't return garbage
10910 if XCreateBitmapFromData fails (Bug#8410).
10911
10912 * xselect.c (x_get_local_selection, x_handle_property_notify):
10913 Remove vars that are set but not used.
10914
10915 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
10916 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
10917
10918 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
10919 Remove var that is set but not used.
10920 (scroll_bar_windows_size): Now size_t, not int.
10921 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
10922 Check for overflow.
10923
10924 * xfaces.c (realize_named_face): Remove vars that are set but not used.
10925 (map_tty_color) [!defined MSDOS]: Likewise.
10926
10927 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
10928
10929 * coding.c: Remove vars that are set but not used.
10930 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
10931 All callers changed.
10932 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
10933 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
10934 (decode_coding_charset): Remove vars that are set but not used.
10935
10936 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
10937 that is set but not used.
10938
10939 * print.c (print_object): Remove var that is set but not used.
10940
10941 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
10942 The gnulib version avoids calling malloc in the usual case,
10943 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
10944 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
10945 * filelock.c (current_lock_owner): Likewise.
10946 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
10947 * sysdep.c: Include allocator.h, careadlinkat.h.
10948 (emacs_no_realloc_allocator): New static constant.
10949 (emacs_readlink): New function.
10950 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
10951 ../lib/careadlinkat.h.
10952
10953 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
10954
10955 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
10956 first non-nil return value).
10957
10958 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
10959
10960 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
10961 if not defined (Bug#8403).
10962
10963 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
10964
10965 * xdisp.c (display_count_lines): Remove parameter `start',
10966 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10967 (get_char_face_and_encoding): Remove parameter `multibyte_p',
10968 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10969 (fill_stretch_glyph_string): Remove parameters `row' and `area',
10970 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
10971 and thereabouts. All callers changed.
10972 (get_per_char_metric): Remove parameter `f', unused since
10973 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10974
10975 2011-04-02 Jim Meyering <meyering@redhat.com>
10976
10977 do not dereference NULL upon failed strdup
10978 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
10979 (ns_get_family): Likewise.
10980
10981 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
10982
10983 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
10984
10985 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
10986
10987 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
10988 later (Bug#8403).
10989
10990 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
10991
10992 Add lexical binding.
10993
10994 * window.c (Ftemp_output_buffer_show): New fun.
10995 (Fsave_window_excursion):
10996 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
10997
10998 * lread.c (lisp_file_lexically_bound_p): New function.
10999 (Fload): Bind Qlexical_binding.
11000 (readevalloop): Remove `evalfun' arg.
11001 Bind Qinternal_interpreter_environment.
11002 (Feval_buffer): Bind Qlexical_binding.
11003 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
11004 Mark as dynamic.
11005 (syms_of_lread): Declare `lexical-binding'.
11006
11007 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
11008
11009 * keyboard.c (eval_dyn): New fun.
11010 (menu_item_eval_property): Use it.
11011
11012 * image.c (parse_image_spec): Use Ffunctionp.
11013
11014 * fns.c (concat, mapcar1): Accept byte-code-functions.
11015
11016 * eval.c (Fsetq): Handle lexical vars.
11017 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
11018 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
11019 (FletX, Flet): Obey lexical binding.
11020 (Fcommandp): Handle closures.
11021 (Feval): New `lexical' arg.
11022 (eval_sub): New function extracted from Feval. Use it almost
11023 everywhere where Feval was used. Look up vars in lexical env.
11024 Handle closures.
11025 (Ffunctionp): Move from subr.el.
11026 (Ffuncall): Handle closures.
11027 (apply_lambda): Remove `eval_flags'.
11028 (funcall_lambda): Handle closures and new byte-code-functions.
11029 (Fspecial_variable_p): New function.
11030 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
11031 but without exporting it to Lisp.
11032
11033 * doc.c (Fdocumentation, store_function_docstring):
11034 * data.c (Finteractive_form): Handle closures.
11035
11036 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
11037 interactive spec.
11038
11039 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
11040 New byte-codes.
11041 (exec_byte_code): New function extracted from Fbyte_code to handle new
11042 calling convention for byte-code-functions. Add new byte-codes.
11043
11044 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
11045
11046 * alloc.c (Fmake_symbol): Init new `declared_special' field.
11047
11048 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
11049
11050 * xdisp.c (redisplay_internal): Fix prototype.
11051
11052 2011-03-31 Eli Zaretskii <eliz@gnu.org>
11053
11054 * xdisp.c (SCROLL_LIMIT): New macro.
11055 (try_scrolling): Use it when setting scroll_limit.
11056 Limit scrolling to 100 screen lines.
11057 (redisplay_window): Even when falling back on "recentering",
11058 position point in the window according to scroll-conservatively,
11059 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
11060
11061 (try_scrolling): When point is above the window, allow searching
11062 as far as scroll_max, or one screenful, to compute vertical
11063 distance from PT to the scroll margin position. This prevents
11064 try_scrolling from unnecessarily failing when
11065 scroll-conservatively is set to a value slightly larger than the
11066 window height. Clean up the case of PT below the margin at bottom
11067 of window: scroll_max can no longer be INT_MAX. When aggressive
11068 scrolling is in use, don't let point enter the opposite scroll
11069 margin as result of the scroll.
11070 (syms_of_xdisp) <scroll-conservatively>: Document the
11071 threshold of 100 lines for never-recentering scrolling.
11072
11073 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
11074
11075 * dispextern.h (move_it_by_lines):
11076 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
11077 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
11078 (message_log_check_duplicate): Remove parameters `prev_bol' and
11079 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11080 (redisplay_internal): Remove parameter `preserve_echo_area',
11081 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
11082
11083 * indent.c (Fvertical_motion):
11084 * window.c (window_scroll_pixel_based, Frecenter):
11085 Don't pass `need_y_p' to `move_it_by_lines'.
11086
11087 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
11088
11089 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
11090 steal a few bits to be more compact.
11091 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
11092 Remove unneeded casts.
11093
11094 * bytecode.c (Fbyte_code): CAR and CDR can GC.
11095
11096 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
11097
11098 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
11099 binding" message (bug#7967).
11100
11101 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
11102
11103 Fix more problems found by GCC 4.6.0's static checks.
11104
11105 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
11106 Remove unused local var.
11107
11108 * editfns.c (Fmessage_box): Remove unused local var.
11109
11110 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
11111 (note_mode_line_or_margin_highlight, note_mouse_highlight):
11112 Omit unused local vars.
11113 * window.c (shrink_windows): Omit unused local var.
11114 * menu.c (digest_single_submenu): Omit unused local var.
11115 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
11116 Omit unused local var.
11117
11118 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
11119 Don't assume string length fits in int.
11120 (keyremap_step, read_key_sequence): Use size_t for sizes.
11121 (read_key_sequence): Don't check last_real_key_start redundantly.
11122
11123 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
11124 instead of alloca (Bug#8344).
11125
11126 * eval.c (Fbacktrace): Don't assume nargs fits in int.
11127 (Fbacktrace_frame): Don't assume nframes fits in int.
11128
11129 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
11130
11131 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
11132 concerns.
11133
11134 * term.c (produce_glyphless_glyph): Remove unnecessary test.
11135
11136 * cm.c (calccost): Turn while-do into do-while, for clarity.
11137
11138 * keyboard.c (syms_of_keyboard): Use the same style as later
11139 in this function when indexing through an array. This also
11140 works around GCC bug 48267.
11141
11142 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
11143
11144 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
11145
11146 * chartab.c (sub_char_table_ref_and_range): Redo for slight
11147 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
11148
11149 * keyboard.c, keyboard.h (num_input_events): Now size_t.
11150 This avoids undefined behavior on integer overflow, and is a bit
11151 more convenient anyway since it is compared to a size_t variable.
11152
11153 Variadic C functions now count arguments with size_t, not int.
11154 This avoids an unnecessary limitation on 64-bit machines, which
11155 caused (substring ...) to crash on large vectors (Bug#8344).
11156 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
11157 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
11158 All variadic functions and their callers changed accordingly.
11159 (struct gcpro.nvars): Now size_t, not int. All uses changed.
11160 * data.c (arith_driver, float_arith_driver): Likewise.
11161 * editfns.c (general_insert_function): Likewise.
11162 * eval.c (struct backtrace.nargs, interactive_p)
11163 (internal_condition_case_n, run_hook_with_args, apply_lambda)
11164 (funcall_lambda, mark_backtrace): Likewise.
11165 * fns.c (concat): Likewise.
11166 * frame.c (x_set_frame_parameters): Likewise.
11167 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
11168 0 if not found, not -1. All callers changed.
11169
11170 * alloc.c (garbage_collect): Don't assume stack size fits in int.
11171 (stack_copy_size): Now size_t, not int.
11172 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
11173
11174 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
11175
11176 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
11177 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11178 All callers changed.
11179
11180 * lisp.h (multibyte_char_to_unibyte):
11181 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
11182 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11183 * character.h (CHAR_TO_BYTE8):
11184 * cmds.c (internal_self_insert):
11185 * editfns.c (general_insert_function):
11186 * keymap.c (push_key_description):
11187 * search.c (Freplace_match):
11188 * xdisp.c (message_dolog, set_message_1): All callers changed.
11189
11190 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
11191
11192 * keyboard.c (safe_run_hook_funcall): New function.
11193 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
11194 don't set the hook to nil, but remove the offending function instead.
11195 (Qcommand_hook_internal): Remove, unused.
11196 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
11197 Vcommand_hook_internal.
11198
11199 * eval.c (enum run_hooks_condition): Remove.
11200 (funcall_nil, funcall_not): New functions.
11201 (run_hook_with_args): Call each function through a `funcall' argument.
11202 Remove `cond' argument, now redundant.
11203 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
11204 (Frun_hook_with_args_until_failure): Adjust accordingly.
11205 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
11206
11207 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
11208
11209 * dispextern.h (string_buffer_position): Remove declaration.
11210
11211 * print.c (strout): Remove parameter `multibyte', unused since
11212 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
11213
11214 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
11215 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
11216 All callers changed.
11217
11218 * w32.c (_wsa_errlist): Use braces for struct initializers.
11219
11220 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
11221 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
11222 All callers changed.
11223 (string_buffer_position): Likewise. Also, make static (it's never
11224 used outside xdisp.c).
11225 (cursor_row_p): Remove parameter `w', unused since
11226 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
11227 (decode_mode_spec): Remove parameter `precision', introduced during
11228 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
11229 All callers changed.
11230
11231 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11232
11233 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
11234
11235 2011-03-27 Anders Lindgren <andlind@gmail.com>
11236
11237 * nsterm.m (ns_menu_bar_is_hidden): New variable.
11238 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
11239 (ns_update_auto_hide_menu_bar): New functions.
11240 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
11241 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
11242 ns_constrain_all_frames.
11243 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
11244 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
11245
11246 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11247
11248 * nsmenu.m (runDialogAt): Remove argument to timer_check.
11249
11250 2011-03-27 Glenn Morris <rgm@gnu.org>
11251
11252 * syssignal.h: Replace RETSIGTYPE with void.
11253 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
11254 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
11255 Replace SIGTYPE with void everywhere.
11256 * s/usg5-4-common.h (SIGTYPE): Remove definition.
11257 * s/template.h (SIGTYPE): Remove commented out definition.
11258
11259 2011-03-26 Eli Zaretskii <eliz@gnu.org>
11260
11261 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
11262 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
11263
11264 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
11265
11266 * w32.c (read_unc_volume): Use parameter `henum', instead of
11267 global variable `wget_enum_handle'.
11268
11269 * keymap.c (describe_vector): Remove parameters `indices' and
11270 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
11271 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
11272
11273 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
11274
11275 * keyboard.c (timer_check): Remove parameter `do_it_now',
11276 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
11277 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
11278 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
11279
11280 * keyboard.c (read_char):
11281 * w32menu.c (w32_menu_display_help):
11282 * xmenu.c (show_help_event, menu_help_callback):
11283 Adjust calls to `show_help_echo'.
11284
11285 * gtkutil.c (xg_maybe_add_timer):
11286 * keyboard.c (readable_events):
11287 * process.c (wait_reading_process_output):
11288 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
11289
11290 * insdel.c (adjust_markers_gap_motion):
11291 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
11292 (gap_left, gap_right): Don't call it.
11293
11294 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
11295
11296 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
11297 incurred during fontification.
11298
11299 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
11300
11301 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
11302 (DEFVAR_PER_BUFFER): Don't pass it.
11303
11304 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
11305 (scrolling_window): Don't pass it.
11306
11307 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
11308
11309 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
11310
11311 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
11312 and `suffix'.
11313 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
11314 of variables specific to SELinux and computation of `encoded_absname'.
11315
11316 * image.c (XPutPixel): Remove unused variable `height'.
11317
11318 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
11319
11320 * unexw32.c (get_section_info): Remove unused variable `section'.
11321
11322 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
11323 (system_process_attributes): Remove unused variable `sess'.
11324 (sys_read): Remove unused variable `err'.
11325
11326 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
11327 (w32_wnd_proc): Remove unused variable `isdead'.
11328 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
11329 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
11330 (x_create_tip_frame): Remove unused variable `tem'.
11331
11332 * w32inevt.c (w32_console_read_socket):
11333 Remove unused variable `no_events'.
11334
11335 * w32term.c (x_draw_composite_glyph_string_foreground):
11336 Remove unused variable `width'.
11337
11338 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
11339
11340 * w32term.c (x_set_glyph_string_clipping):
11341 Don't pass uninitialized region to CombineRgn.
11342
11343 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
11344
11345 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
11346 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
11347 (Fx_close_connection): Remove unused variable `i'.
11348
11349 * w32font.c (w32font_draw): Return number of glyphs.
11350 (w32font_open_internal): Remove unused variable `i'.
11351 (w32font_driver): Add missing initializer.
11352
11353 * w32menu.c (utf8to16): Remove unused variable `utf16'.
11354 (fill_in_menu): Remove unused variable `items_added'.
11355
11356 * w32term.c (last_mouse_press_frame): Remove static global variable.
11357 (w32_clip_to_row): Remove unused variable `f'.
11358 (x_delete_terminal): Remove unused variable `i'.
11359
11360 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
11361 (NOTHING): Remove unused static global variable.
11362 (uniscribe_check_otf): Remove unused variable `table'.
11363 (uniscribe_font_driver): Add missing initializers.
11364
11365 2011-03-23 Julien Danjou <julien@danjou.info>
11366
11367 * term.c (Fsuspend_tty, Fresume_tty):
11368 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
11369 * window.c (temp_output_buffer_show):
11370 * insdel.c (signal_before_change):
11371 * frame.c (Fhandle_switch_frame):
11372 * fileio.c (Fdo_auto_save):
11373 * emacs.c (Fkill_emacs):
11374 * editfns.c (save_excursion_restore):
11375 * cmds.c (internal_self_insert):
11376 * callint.c (Fcall_interactively):
11377 * buffer.c (Fkill_all_local_variables):
11378 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
11379 Use Frun_hooks.
11380 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
11381 unconditionally since it does the check itself.
11382
11383 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
11384
11385 Fix more problems found by GCC 4.5.2's static checks.
11386
11387 * coding.c (encode_coding_raw_text): Avoid unnecessary test
11388 the first time through the loop, since we know p0 < p1 then.
11389 This also avoids a gcc -Wstrict-overflow warning.
11390
11391 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
11392 leading to a memory leak, possible in functions like
11393 load_charset_map_from_file that can allocate an unbounded number
11394 of objects (Bug#8318).
11395
11396 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
11397 that could (at least in theory) be that large.
11398
11399 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
11400 This is less likely to overflow, and avoids undefined behavior if
11401 overflow does occur. All callers changed. Use strtoul to scan
11402 for the unsigned long integer.
11403 (pint2hrstr): Simplify and tune code slightly.
11404 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
11405
11406 * scroll.c (do_scrolling): Work around GCC bug 48228.
11407 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
11408
11409 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
11410 This also avoids a warning with gcc -Wstrict-overflow.
11411 (validate_x_resource_name): Simplify count usage.
11412 This also avoids a warning with gcc -Wstrict-overflow.
11413
11414 * fileio.c (Fcopy_file): Report error if fchown or fchmod
11415 fail (Bug#8306).
11416
11417 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
11418
11419 * process.c (Fmake_network_process): Use socklen_t, not int,
11420 where POSIX says socklen_t is required in portable programs.
11421 This fixes a porting bug on hosts like 64-bit HP-UX, where
11422 socklen_t is wider than int (Bug#8277).
11423 (Fmake_network_process, server_accept_connection):
11424 (wait_reading_process_output, read_process_output):
11425 Likewise.
11426
11427 * process.c: Rename or move locals to avoid shadowing.
11428 (list_processes_1, Fmake_network_process):
11429 (read_process_output_error_handler, exec_sentinel_error_handler):
11430 Rename or move locals.
11431 (Fmake_network_process): Define label "retry_connect" only if needed.
11432 (Fnetwork_interface_info): Fix pointer signedness.
11433 (process_send_signal): Add cast to avoid pointer signedness problem.
11434 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
11435 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
11436
11437 Make tparam.h and terminfo.c consistent.
11438 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
11439 Include tparam.h instead, since it declares them.
11440 * cm.h (PC): Remove extern decl; tparam.h now does this.
11441 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
11442 * terminfo.c: Include tparam.h, to check interfaces.
11443 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
11444 (tparam): Adjust signature to match interface in tparam.h;
11445 this removes some undefined behavior. Check that outstring and len
11446 are zero, which they always are with Emacs.
11447 * tparam.h (PC, BC, UP): New extern decls.
11448
11449 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
11450 (xftfont_open): Rename locals to avoid shadowing.
11451
11452 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
11453 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
11454 (OTF_TAG_SYM): Omit macro if not needed.
11455 (ftfont_list): Remove unused local.
11456 (get_adstyle_property, ftfont_pattern_entity):
11457 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
11458 Rename locals to avoid shadowing.
11459
11460 * xfont.c (xfont_list_family): Mark var as initialized.
11461
11462 * xml.c (make_dom): Now static.
11463
11464 * composite.c (composition_compute_stop_pos): Rename local to
11465 avoid shadowing.
11466 (composition_reseat_it): Remove unused locals.
11467 (find_automatic_composition, composition_adjust_point): Likewise.
11468 (composition_update_it): Mark var as initialized.
11469 (find_automatic_composition): Mark vars as initialized,
11470 with a FIXME (Bug#8290).
11471
11472 character.h: Rename locals to avoid shadowing.
11473 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
11474 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
11475 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
11476 (BUF_DEC_POS): Be more systematic about renaming local temporaries
11477 to avoid shadowing.
11478
11479 * textprop.c (property_change_between_p): Remove; unused.
11480
11481 * intervals.c (interval_start_pos): Now static.
11482
11483 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
11484
11485 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
11486 Rename locals to avoid shadowing.
11487
11488 * sound.c (wav_play, au_play, Fplay_sound_internal):
11489 Fix pointer signedness.
11490 (alsa_choose_format): Remove unused local var.
11491 (wav_play): Initialize a variable to 0, to prevent undefined
11492 behavior (Bug#8278).
11493
11494 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
11495
11496 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
11497
11498 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
11499 clobbering (Bug#8298).
11500 * sysdep.c (sys_subshell): Likewise.
11501 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
11502
11503 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
11504 This should get cleaned up, so that child_setup has the
11505 same signature on all platforms.
11506
11507 * callproc.c (call_process_cleanup): Now static.
11508 (relocate_fd): Rename locals to avoid shadowing.
11509
11510 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
11511
11512 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
11513 not to be necessary, and produces flickering.
11514
11515 2011-03-20 Glenn Morris <rgm@gnu.org>
11516
11517 * config.in: Remove file.
11518
11519 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
11520
11521 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
11522 are now in src/globals.h.
11523 (syms_of_minibuf): Remove spurious & from previous change.
11524
11525 2011-03-20 Leo Liu <sdl.web@gmail.com>
11526
11527 * minibuf.c (completing-read-function): New variable.
11528 (completing-read-default): Rename from completing-read.
11529 (completing-read): Call completing-read-function.
11530
11531 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
11532
11533 * xfaces.c (Fx_load_color_file):
11534 Read color file from absolute filename (bug#8250).
11535
11536 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
11537
11538 * makefile.w32-in: Update dependencies.
11539
11540 2011-03-17 Eli Zaretskii <eliz@gnu.org>
11541
11542 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
11543
11544 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
11545
11546 Fix more problems found by GCC 4.5.2's static checks.
11547
11548 * process.c (make_serial_process_unwind, send_process_trap):
11549 (sigchld_handler): Now static.
11550
11551 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
11552 That way, the code declares only the vars that it needs.
11553 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
11554 * s/cygwin.h (PTY_ITERATION): Likewise.
11555 * s/darwin.h (PTY_ITERATION): Likewise.
11556 * s/gnu-linux.h (PTY_ITERATION): Likewise.
11557
11558 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
11559 * process.c (allocate_pty): Don't declare stb unless it's needed.
11560
11561 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
11562 (CONSTANTLIM): Remove; unused.
11563 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
11564 Define only if needed.
11565
11566 * unexelf.c (unexec): Name an expression,
11567 to avoid gcc -Wbad-function-cast warning.
11568 Use a different way to cause a compilation error if anyone uses
11569 n rather than nn, a way that does not involve shadowing.
11570 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
11571
11572 * deps.mk (unexalpha.o): Remove; unused.
11573
11574 New file unexec.h, the (simple) interface for unexec (Bug#8267).
11575 * unexec.h: New file.
11576 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
11577 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
11578 Depend on unexec.h.
11579 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
11580 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
11581 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
11582 Change as necessary to match prototype in unexec.h.
11583
11584 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
11585 shadowing.
11586 (back_comment, skip_chars): Mark vars as initialized.
11587
11588 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
11589 Rename locals to avoid shadowing.
11590
11591 * lread.c (read1): Rewrite so as not to use empty "else".
11592 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
11593
11594 * print.c (Fredirect_debugging_output): Fix pointer signedess.
11595
11596 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
11597 warning when compiling print.c.
11598
11599 * font.c (font_unparse_fcname): Abort in an "impossible" situation
11600 instead of using an uninitialized var.
11601 (font_sort_entities): Mark var as initialized.
11602
11603 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
11604
11605 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
11606 pointers to constants.
11607 (font_parse_fcname): Remove unused vars.
11608 (font_delete_unmatched): Now static.
11609 (font_get_spec): Remove; unused.
11610 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
11611 (font_update_drivers, Ffont_get_glyphs, font_add_log):
11612 Rename or move locals to avoid shadowing.
11613
11614 * fns.c (require_nesting_list, require_unwind): Now static.
11615 (Ffillarray): Rename locals to avoid shadowing.
11616
11617 * floatfns.c (domain_error2): Define only if needed.
11618 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
11619
11620 * alloc.c (mark_backtrace): Move decl from here ...
11621 * lisp.h: ... to here, so that it can be checked.
11622
11623 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
11624 (Fdefvar): Rewrite so as not to use empty "else".
11625 (lisp_indirect_variable): Name an expression,
11626 to avoid gcc -Wbad-function-cast warning.
11627 (Fdefvar): Rename locals to avoid shadowing.
11628
11629 * callint.c (quotify_arg, quotify_args): Now static.
11630 (Fcall_interactively): Rename locals to avoid shadowing.
11631 Use const pointer when appropriate.
11632
11633 * lisp.h (get_system_name, get_operating_system_release):
11634 Move decls here, to check interfaces.
11635 * process.c (get_operating_system_release): Move decl to lisp.h.
11636 * xrdb.c (get_system_name): Likewise.
11637 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
11638 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
11639 some of which prompt warnings from gcc -Wbad-function-cast.
11640 (Fformat_time_string, Fencode_time, Finsert_char):
11641 (Ftranslate_region_internal, Fformat):
11642 Rename or remove local vars to avoid shadowing.
11643 (Ftranslate_region_internal): Mark var as initialized.
11644
11645 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
11646 avoid shadowing.
11647
11648 * lisp.h (eassert): Check that the argument compiles, even if
11649 ENABLE_CHECKING is not defined.
11650
11651 * data.c (Findirect_variable): Name an expression, to avoid
11652 gcc -Wbad-function-cast warning.
11653 (default_value, arithcompare, arith_driver, arith_error): Now static.
11654 (store_symval_forwarding): Rename local to avoid shadowing.
11655 (Fmake_variable_buffer_local, Fmake_local_variable):
11656 Mark variables as initialized.
11657 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
11658
11659 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
11660 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
11661 Rename locals to avoid shadowing.
11662 (mark_stack): Move local variables into the #ifdef region where
11663 they're used.
11664 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
11665 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
11666 needed otherwise.
11667 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
11668 (GC_STRING_CHARS): Remove; not used.
11669 (Fmemory_limit): Cast sbrk's returned value to char *.
11670
11671 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
11672 avoids undefined behavior in theory.
11673
11674 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
11675
11676 Use functions, not macros, for up- and down-casing (Bug#8254).
11677 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11678 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
11679 to use the following functions instead of these macros.
11680 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
11681 EMACS_INT, since callers assume the returned value fits in int.
11682 (upcase1): Likewise, for UPCASE_TABLE.
11683 (uppercasep, lowercasep, upcase): New static inline functions.
11684 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
11685 the race-condition problem in the old DOWNCASE.
11686
11687 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
11688 Rename locals to avoid shadowing.
11689 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
11690 (regex_compile, re_search_2, re_match_2_internal):
11691 Remove unused local vars.
11692 (FREE_VAR): Rewrite so as not to use empty "else",
11693 which gcc can warn about.
11694 (regex_compile, re_match_2_internal): Mark locals as initialized.
11695 (RETALLOC_IF): Define only if needed.
11696 (WORDCHAR_P): Likewise. This one is never needed, but is used
11697 only in a comment talking about a compiler bug, so put inside
11698 the #if 0 of that comment.
11699 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
11700 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
11701 Remove; unused.
11702
11703 * search.c (boyer_moore): Rename locals to avoid shadowing.
11704 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
11705 (PREV_CHAR_BOUNDARY): Likewise.
11706
11707 * search.c (simple_search): Remove unused var.
11708
11709 * dired.c (compile_pattern): Move decl from here ...
11710 * lisp.h: ... to here, so that it can be checked.
11711 (struct re_registers): New forward decl.
11712
11713 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
11714
11715 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
11716 All uses changed.
11717 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
11718 Rename locals to avoid shadowing.
11719 (Fvertical_motion): Mark locals as initialized.
11720
11721 * casefiddle.c (casify_object, casify_region): Now static.
11722 (casify_region): Mark local as initialized.
11723
11724 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
11725
11726 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
11727 New macros, so that the caller can use some names other than
11728 gcpro1, gcpro2, etc.
11729 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
11730 of the new macros.
11731 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
11732 argument, for consistency with GCPRO2_VAR, etc: it is now the
11733 prefix of the variable, not the variable itself. All uses
11734 changed.
11735 * dired.c (directory_files_internal, file_name_completion):
11736 Rename locals to avoid shadowing.
11737
11738 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
11739 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
11740 dired.c's scmp function, had undefined behavior.
11741 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11742 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
11743 * buffer.h: ... to here, because these macros use current_buffer,
11744 and the new implementation with inline functions needs to have
11745 current_buffer in scope now, rather than later when the macros
11746 are used.
11747 (downcase, upcase1): New static inline functions.
11748 (DOWNCASE, UPCASE1): Reimplement using these functions.
11749 This avoids undefined behavior in expressions like
11750 DOWNCASE (x) == DOWNCASE (y), which previously suffered
11751 from race conditions in accessing the global variables
11752 case_temp1 and case_temp2.
11753 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
11754 * lisp.h (case_temp1, case_temp2): Remove their decls.
11755 * character.h (ASCII_CHAR_P): Move from here ...
11756 * lisp.h: ... to here, so that the inline functions mentioned
11757 above can use them.
11758
11759 * dired.c (directory_files_internal_unwind): Now static.
11760
11761 * fileio.c (file_name_as_directory, directory_file_name):
11762 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
11763 Now static.
11764 (file_name_as_directory): Use const pointers when appropriate.
11765 (Fexpand_file_name): Likewise. In particular, newdir might
11766 point at constant storage, so make it a const pointer.
11767 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
11768 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
11769 signedness issues.
11770 (Fset_file_times, Finsert_file_contents, auto_save_error):
11771 Rename locals to avoid shadowing.
11772
11773 * minibuf.c (choose_minibuf_frame_1): Now static.
11774 (Ftry_completion, Fall_completions): Rename or remove locals
11775 to avoid shadowing.
11776
11777 * marker.c (bytepos_to_charpos): Remove; unused.
11778
11779 * lisp.h (verify_bytepos, count_markers): New decls,
11780 so that gcc does not warn that these functions aren't declared.
11781
11782 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
11783 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
11784 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
11785 (copy_text): Remove unused local var.
11786
11787 * filelock.c (within_one_second): Now static.
11788 (lock_file_1): Rename local to avoid shadowing.
11789
11790 * buffer.c (fix_overlays_before): Mark locals as initialized.
11791 (fix_start_end_in_overlays): Likewise. This function should be
11792 simplified by using pointers-to-pointers, but that's a different
11793 matter.
11794 (switch_to_buffer_1): Now static.
11795 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
11796 (report_overlay_modification): Rename locals to avoid shadowing.
11797
11798 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
11799 Fix pointer signedness issue.
11800 (sys_subshell): Mark local as volatile if checking for lint,
11801 to suppress a gcc -Wclobbered warning that does not seem to be right.
11802 (MAXPATHLEN): Define only if needed.
11803
11804 * process.c (serial_open, serial_configure): Move decls from here ...
11805 * systty.h: ... to here, so that they can be checked.
11806
11807 * fns.c (get_random, seed_random): Move extern decls from here ...
11808 * lisp.h: ... to here, so that they can be checked.
11809
11810 * sysdep.c (reset_io): Now static.
11811 (wait_for_termination_signal): Remove; unused.
11812
11813 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
11814 (copy_keymap_item, append_key, push_text_char_description):
11815 Now static.
11816 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
11817 (DENSE_TABLE_SIZE): Remove; unused.
11818 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
11819 (describe_map_tree):
11820 Rename locals to avoid shadowing.
11821
11822 * keyboard.c: Declare functions static if they are not used elsewhere.
11823 (echo_char, echo_dash, cmd_error, top_level_2):
11824 (poll_for_input, handle_async_input): Now static.
11825 (read_char, kbd_buffer_get_event, make_lispy_position):
11826 (make_lispy_event, make_lispy_movement, apply_modifiers):
11827 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
11828 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
11829 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
11830 (read_key_sequence, read_char): Mark locals as initialized.
11831 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
11832
11833 * keyboard.h (make_ctrl_char): New decl.
11834 (mark_kboards): Move decl here ...
11835 * alloc.c (mark_kboards): ... from here.
11836
11837 * lisp.h (force_auto_save_soon): New decl.
11838
11839 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
11840 (DEFINE_DUMMY_FUNCTION): New macro.
11841 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
11842 Use it.
11843 (main): Add casts to avoid warnings
11844 if GCC considers string literals to be constants.
11845
11846 * lisp.h (fatal_error_signal): Add decl, since it's exported.
11847
11848 * dbusbind.c: Pointer signedness fixes.
11849 (xd_signature, xd_append_arg, xd_initialize):
11850 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11851 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11852 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
11853 (Fdbus_register_signal): Use SSDATA when the context wants char *.
11854
11855 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
11856 if GCC considers string literals to be constants.
11857 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
11858
11859 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
11860
11861 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
11862 (print_preprocess, print_object): New macro to fix last change.
11863
11864 * print.c (print_preprocess): Don't forget font objects.
11865
11866 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
11867
11868 * emacs.c (USAGE3): Doc fixes.
11869
11870 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
11871
11872 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
11873 structure.
11874
11875 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
11876
11877 * lisp.h (VWindow_system, Qfile_name_history):
11878 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
11879 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
11880 (w32_system_caret_x, w32_system_caret_y): Declare extern.
11881
11882 * w32select.c: Don't #include "keyboard.h".
11883 (run_protected): Add extern declaration for waiting_for_input.
11884
11885 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
11886 * w32console.c (detect_input_pending, read_input_pending)
11887 (encode_terminal_code):
11888 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
11889 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
11890 (w32_system_caret_y, Qfile_name_history):
11891 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
11892 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
11893 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
11894 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
11895 * w32proc.c (Qlocal, report_file_error):
11896 * w32term.c (Vwindow_system, updating_frame):
11897 * w32uniscribe.c (initialized, uniscribe_font_driver):
11898 Remove unneeded extern declarations.
11899
11900 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
11901
11902 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
11903
11904 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
11905
11906 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
11907 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
11908 These macros can no longer be used for assignment.
11909
11910 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
11911 Assign struct members directly, instead of using BUF_BEGV etc.
11912 (record_buffer_markers, fetch_buffer_markers): New functions for
11913 recording and fetching special buffer markers.
11914 (set_buffer_internal_1, set_buffer_temp): Use them.
11915
11916 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
11917
11918 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
11919
11920 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
11921 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
11922
11923 * xdisp.c (hscroll_window_tree):
11924 (reconsider_clip_changes): Use PT instead of BUF_PT.
11925
11926 2011-03-13 Eli Zaretskii <eliz@gnu.org>
11927
11928 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
11929 $(EMACS_ROOT)/lib/intprops.h.
11930
11931 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
11932
11933 Fix more problems found by GCC 4.5.2's static checks.
11934
11935 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
11936 to unsigned char * to avoid compiler diagnostic.
11937 (xg_free_frame_widgets): Make it clear that a local variable is
11938 needed only if USE_GTK_TOOLTIP.
11939 (gdk_window_get_screen): Make it clear that this macro is needed
11940 only if USE_GTK_TOOLTIP.
11941 (int_gtk_range_get_value): New function, which avoids a diagnostic
11942 from gcc -Wbad-function-cast.
11943 (xg_set_toolkit_scroll_bar_thumb): Use it.
11944 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
11945 diagnostic from gcc -Wbad-function-cast.
11946 (get_utf8_string, xg_get_file_with_chooser):
11947 Rename locals to avoid shadowing.
11948 (create_dialog): Move locals to avoid shadowing.
11949
11950 * xgselect.c (xg_select): Remove unused var.
11951
11952 * image.c (four_corners_best): Mark locals as initialized.
11953 (gif_load): Initialize transparent_p to zero (Bug#8238).
11954 Mark another local as initialized.
11955 (my_png_error, my_error_exit): Mark with NO_RETURN.
11956
11957 * image.c (clear_image_cache): Now static.
11958 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
11959 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
11960 (x_edge_detection): Remove unnecessary cast that
11961 gcc -Wbad-function-cast diagnoses.
11962 (gif_load): Fix pointer signedness.
11963 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
11964 (jpeg_load, gif_load): Rename locals to avoid shadowing.
11965
11966 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
11967
11968 Improve quality of tests for time stamp overflow.
11969 For example, without this patch (encode-time 0 0 0 1 1
11970 1152921504606846976) returns the obviously-bogus value (-948597
11971 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
11972 reports time overflow. See
11973 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
11974 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
11975 * editfns.c: Include limits.h and intprops.h.
11976 (TIME_T_MIN, TIME_T_MAX): New macros.
11977 (time_overflow): Move earlier, to before first use.
11978 (hi_time, lo_time): New functions, for an accurate test for
11979 out-of-range times.
11980 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
11981 (Fget_internal_run_time): Don't assume time_t fits in int.
11982 (make_time): Use list2 instead of Fcons twice.
11983 (Fdecode_time): More accurate test for out-of-range times.
11984 (check_tm_member): New function.
11985 (Fencode_time): Use it, to test for out-of-range times.
11986 (lisp_time_argument): Don't rely on undefined left-shift and
11987 right-shift behavior when checking for time stamp overflow.
11988
11989 * editfns.c (time_overflow): New function, refactoring common code.
11990 (Fformat_time_string, Fdecode_time, Fencode_time):
11991 (Fcurrent_time_string): Use it.
11992
11993 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
11994 * dired.c (make_time): Move to ...
11995 * editfns.c (make_time): ... here.
11996 * systime.h: Note the move.
11997
11998 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11999
12000 * fringe.c (update_window_fringes): Remove unused variables.
12001
12002 * unexmacosx.c (copy_data_segment): Also copy __got section.
12003 (Bug#8223)
12004
12005 2011-03-12 Eli Zaretskii <eliz@gnu.org>
12006
12007 * termcap.c [MSDOS]: Include "msdos.h".
12008 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
12009 Constify `char *' arguments and their references according to
12010 prototypes in tparam.h.
12011
12012 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
12013
12014 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
12015 Adapt all references accordingly.
12016
12017 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
12018
12019 2011-03-11 Tom Tromey <tromey@redhat.com>
12020
12021 * buffer.c (syms_of_buffer): Remove obsolete comment.
12022
12023 2011-03-11 Eli Zaretskii <eliz@gnu.org>
12024
12025 * termhooks.h (encode_terminal_code): Declare prototype.
12026
12027 * msdos.c (encode_terminal_code): Don't declare prototype.
12028
12029 * term.c (encode_terminal_code): Now external again, used by
12030 w32console.c and msdos.c.
12031
12032 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
12033 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
12034
12035 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
12036
12037 Fix some minor problems found by GCC 4.5.2's static checks.
12038
12039 * fringe.c (update_window_fringes): Mark locals as initialized
12040 (Bug#8227).
12041 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
12042
12043 * alloc.c (mark_fringe_data): Move decl from here ...
12044 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
12045 to check its interface.
12046 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
12047
12048 * fontset.c (free_realized_fontset): Now static.
12049 (Fset_fontset_font): Rename local to avoid shadowing.
12050 (fontset_font): Mark local as initialized.
12051 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
12052
12053 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
12054
12055 * xselect.c (x_disown_buffer_selections): Remove; not used.
12056 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
12057 (x_own_selection, Fx_disown_selection_internal): Rename locals
12058 to avoid shadowing.
12059 (x_handle_dnd_message): Remove local to avoid shadowing.
12060
12061 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
12062 so that the caller can use some name other than gcpro1.
12063 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
12064 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12065 (Fx_backspace_delete_keys_p):
12066 Use them to avoid shadowing, and rename vars to avoid shadowing.
12067 (x_decode_color, x_set_name, x_window): Now static.
12068 (Fx_create_frame): Add braces to silence GCC warning.
12069 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
12070 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
12071 Remove unused locals.
12072 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12073 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
12074 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
12075 macros.
12076
12077 * xterm.h (x_mouse_leave): New decl.
12078
12079 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
12080 Remove unused functions.
12081 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
12082 (x_calc_absolute_position): Now static.
12083 (XTread_socket): Don't define label "out" unless it's used.
12084 Don't declare local "event" unless it's used.
12085 (x_iconify_frame, x_free_frame_resources): Don't declare locals
12086 unless they are used.
12087 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
12088 (x_fatal_error_signal): Remove; not used.
12089 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
12090 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
12091 (x_error_catcher, x_connection_closed, x_error_handler):
12092 (x_error_quitter, xembed_send_message, x_iconify_frame):
12093 (my_log_handler): Rename locals to avoid shadowing.
12094 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
12095 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
12096
12097 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
12098 Rename or move locals to avoid shadowing.
12099 (tty_defined_color, merge_face_heights): Now static.
12100 (free_realized_faces_for_fontset): Remove; not used.
12101 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
12102 does not deduce is never used uninitialized.
12103 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
12104 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
12105
12106 * terminal.c (store_terminal_param): Now static.
12107
12108 * xmenu.c (menu_highlight_callback): Now static.
12109 (set_frame_menubar): Remove unused local.
12110 (xmenu_show): Rename parameter to avoid shadowing.
12111 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
12112 since they might point to immutable storage.
12113 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
12114 since it's unused otherwise.
12115
12116 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
12117 Add a FIXME, since the code still doesn't look right. (Bug#8215)
12118 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
12119 avoids a gcc -Wuninitialized diagnostic.
12120 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
12121 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
12122 does not deduce are never used uninitialized.
12123
12124 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
12125
12126 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
12127 * window.c (window_loop, size_window):
12128 (run_window_configuration_change_hook, enlarge_window): Likewise.
12129
12130 * window.c (display_buffer): Now static.
12131 (size_window): Mark variables that gcc -Wuninitialized
12132 does not deduce are never used uninitialized.
12133 * window.h (check_all_windows): New decl, to forestall
12134 gcc -Wmissing-prototypes diagnostic.
12135 * dispextern.h (bidi_dump_cached_states): Likewise.
12136
12137 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
12138 shadowing.
12139 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
12140 Include <limits.h>.
12141 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
12142 and to avoid gcc -Wuninitialized warning.
12143 (load_charset_map): Mark variables that gcc -Wuninitialized
12144 does not deduce are never used uninitialized.
12145 (load_charset): Abort instead of using uninitialized var (Bug#8229).
12146
12147 * coding.c (coding_set_source, coding_set_destination):
12148 Use "else { /* comment */ }" rather than "else /* comment */;"
12149 for clarity, and to avoid gcc -Wempty-body warning.
12150 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
12151 a block, when the outer 'i' will do.
12152 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
12153 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
12154 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
12155 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
12156 (Fdecode_sjis_char, Fdefine_coding_system_internal):
12157 Rename locals to avoid shadowing.
12158 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
12159 * coding.c (emacs_mule_char, encode_invocation_designation):
12160 Now static, since they're not used elsewhere.
12161 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
12162 (decode_coding_object, encode_coding_object, detect_coding_system):
12163 (decode_coding_emacs_mule): Mark variables that gcc
12164 -Wuninitialized does not deduce are never used uninitialized.
12165 (detect_coding_iso_2022): Initialize a local variable that might
12166 be used uninitialized. Leave a FIXME because it's not clear that
12167 this initialization is needed. (Bug#8211)
12168 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
12169 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
12170 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
12171 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
12172 Remove unused macros.
12173
12174 * category.c (hash_get_category_set): Remove unused local var.
12175 (copy_category_table): Now static, since it's not used elsewhere.
12176 * character.c (string_count_byte8): Likewise.
12177
12178 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
12179 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
12180
12181 * chartab.c (copy_sub_char_table): Now static, since it's not used
12182 elsewhere.
12183 (sub_char_table_ref_and_range, char_table_ref_and_range):
12184 Rename locals to avoid shadowing.
12185 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
12186
12187 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
12188 (BIDI_BOB): Remove unused macro.
12189
12190 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
12191 deduce are never used uninitialized.
12192 * term.c (encode_terminal_code): Likewise.
12193
12194 * term.c (encode_terminal_code): Now static. Remove unused local.
12195
12196 * tparam.h: New file.
12197 * term.c, tparam.h: Include it.
12198 * deps.mk (term.o, tparam.o): Depend on tparam.h.
12199 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
12200 Move these decls to tparam.h, and make them agree with what
12201 is actually in tparam.c. The previous trick of using incompatible
12202 decls in different modules does not conform to the C standard.
12203 All callers of tparam changed to use tparam's actual API.
12204 * tparam.c (tparam1, tparam, tgoto):
12205 Use const pointers where appropriate.
12206
12207 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
12208 * cm.h (struct cm): Likewise.
12209 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
12210 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
12211 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
12212 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
12213 (turn_on_face, init_tty): Likewise.
12214 * termchar.h (struct tty_display_info): Likewise.
12215
12216 * term.c (term_mouse_position): Rename local to avoid shadowing.
12217
12218 * alloc.c (mark_ttys): Move decl from here ...
12219 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
12220
12221 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
12222
12223 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
12224
12225 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
12226
12227 * search.c (compile_pattern_1): Remove argument regp, unused since
12228 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
12229 (compile_pattern): Don't pass it.
12230
12231 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
12232
12233 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
12234 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
12235 for ! HAVE_GTK3.
12236 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
12237
12238 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
12239
12240 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
12241 gdk_window_get_screen, gdk_window_get_geometry,
12242 gdk_x11_window_lookup_for_display and GDK_KEY_g.
12243 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
12244 (xg_get_pixbuf_from_pixmap): New function.
12245 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
12246 to Pixmap, take frame as parameter, remove GdkColormap parameter.
12247 Call xg_get_pixbuf_from_pixmap instead of
12248 gdk_pixbuf_get_from_drawable.
12249 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
12250 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
12251 (xg_check_special_colors): Use GtkStyleContext and its functions
12252 for HAVE_GTK3.
12253 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
12254 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
12255 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
12256 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
12257 Call gtk_widget_get_preferred_size.
12258 (xg_frame_resized): gdk_window_get_geometry only takes 5
12259 parameters.
12260 (xg_win_to_widget, xg_event_is_for_menubar):
12261 Call gdk_x11_window_lookup_for_display.
12262 (xg_set_widget_bg): New function.
12263 (delete_cb): New function.
12264 (xg_create_frame_widgets): Connect delete-event to delete_cb.
12265 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
12266 (xg_set_background_color): Call xg_set_widget_bg.
12267 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
12268 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
12269 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
12270 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
12271 if ! HAVE_GTK3.
12272 (update_frame_tool_bar): Call gtk_widget_hide.
12273 (xg_initialize): Use GDK_KEY_g.
12274
12275 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
12276 if ! HAVE_GTK3
12277 (x_session_initialize): Call gdk_x11_set_sm_client_id.
12278
12279 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
12280 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
12281 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
12282
12283 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
12284
12285 * w32xfns.c (select_palette): Check success of RealizePalette against
12286 GDI_ERROR, not zero.
12287
12288 See ChangeLog.11 for earlier changes.
12289
12290 ;; Local Variables:
12291 ;; coding: utf-8
12292 ;; End:
12293
12294 Copyright (C) 2011-2012 Free Software Foundation, Inc.
12295
12296 This file is part of GNU Emacs.
12297
12298 GNU Emacs is free software: you can redistribute it and/or modify
12299 it under the terms of the GNU General Public License as published by
12300 the Free Software Foundation, either version 3 of the License, or
12301 (at your option) any later version.
12302
12303 GNU Emacs is distributed in the hope that it will be useful,
12304 but WITHOUT ANY WARRANTY; without even the implied warranty of
12305 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12306 GNU General Public License for more details.
12307
12308 You should have received a copy of the GNU General Public License
12309 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.