]> code.delx.au - gnu-emacs/blob - src/ChangeLog
* xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
[gnu-emacs] / src / ChangeLog
1 2011-05-03 Paul Eggert <eggert@cs.ucla.edu>
2
3 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4
5 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6
7 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
8 * charset.c (Fdefine_charset_internal): Don't initialize
9 charset.code_space[15]. The value was garbage, on hosts with
10 32-bit int (Bug#8600).
11
12 * lread.c (read_integer): Be more consistent with string-to-number.
13 Use string_to_number to do the actual conversion; this avoids
14 rounding errors and fixes some other screwups. Without this fix,
15 for example, #x1fffffffffffffff was misread as -2305843009213693952.
16 (digit_to_number): Move earlier, for benefit of read_integer.
17 Return -1 if the digit is out of range for the base, -2 if it is
18 not a digit in any supported base. (Bug#8602)
19
20 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
21
22 * dispnew.c (scrolling_window): Return 1 if we scrolled,
23 to match comment at start of function. This also removes a
24 GCC warning about overflow in a 32+64-bit port.
25
26 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
27
28 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
29 Reported by Stefan Monnier in
30 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
31 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages): Use
32 SYMBOLP-guarded XSYMBOL, not XPNTR.
33
34 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
35 (EMACS_UINTPTR): Likewise, with uintptr_t.
36
37 * lisp.h: Prefer 64-bit EMACS_INT if available.
38 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
39 on 32-bit hosts that have 64-bit int, so that they can access
40 large files.
41
42 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
43
44 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
45 This removes an assumption that EMACS_INT and long are the same
46 width as pointers. The assumption is true for Emacs porting targets
47 now, but we want to make other targets possible.
48 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
49 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
50 In the rest of the code, change types of integers that hold casted
51 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
52 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
53 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
54 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
55 No need to cast type when ORing.
56 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
57 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
58 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
59 assume EMACS_INT is the same width as char *.
60 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
61 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
62 Remove no-longer-needed casts.
63 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
64 (xg_tool_bar_help_callback, xg_make_tool_item):
65 Use EMACS_INTPTR to hold an integer
66 that will be cast to void *; this can avoid a GCC warning
67 if EMACS_INT is not the same width as void *.
68 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
69 * xdisp.c (display_echo_area_1, resize_mini_window_1):
70 (current_message_1, set_message_1):
71 Use a local to convert to proper width without a cast.
72 * xmenu.c (dialog_selection_callback): Likewise.
73
74 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
75 Also, don't assume VALBITS / RAND_BITS is less than 5,
76 and don't rely on undefined behavior when shifting a 1 left into
77 the sign bit.
78 * lisp.h (get_random): Change signature to match.
79
80 * lread.c (hash_string): Use size_t, not int, for hash computation.
81 Normally we prefer signed values; but hashing is special, because
82 it's better to use unsigned division on hash table sizes so that
83 the remainder is nonnegative. Also, size_t is the natural width
84 for hashing into memory. The previous code used 'int', which doesn't
85 retain enough info to hash well into very large tables.
86 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
87
88 * dbusbind.c: Don't possibly lose pointer info when converting.
89 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
90 Use XPNTR rather than XHASH, so that the high-order bits of
91 the pointer aren't lost when converting through void *.
92
93 * eval.c (Fautoload): Don't double-shift a pointer.
94
95 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
96
97 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
98
99 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
100
101 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
102
103 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
104 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
105 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
106 (gnutls_global_initialized, Qgnutls_bootprop_priority)
107 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
108 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
109 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
110 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
111 (Qgnutls_bootprop_callbacks_verify): Make static.
112
113 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
114
115 * callproc.c: Indentation fixup.
116
117 * sysdep.c (wait_for_termination_1): Make static.
118 (wait_for_termination, interruptible_wait_for_termination): Move
119 after wait_for_termination_1.
120
121 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
122
123 * sysdep.c (interruptible_wait_for_termination): New function
124 which is like wait_for_termination, but allows keyboard
125 interruptions.
126
127 * callproc.c (Fcall_process): Add (:file "file") as an option for
128 the STDOUT buffer.
129 (Fcall_process_region): Ditto.
130
131 2011-04-30 Eli Zaretskii <eliz@gnu.org>
132
133 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
134 rather than `XVECTOR (FOO)->size'.
135
136 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
137 inttypes.h, as a gnulib replacement is used if it not available in
138 system headers.
139
140 2011-04-21 Eli Zaretskii <eliz@gnu.org>
141
142 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
143 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
144 of MOST_POSITIVE_FIXNUM. (Bug#8528)
145
146 * coding.c (coding_alloc_by_realloc): Error out if destination
147 will grow beyond MOST_POSITIVE_FIXNUM.
148 (decode_coding_emacs_mule): Abort if there isn't enough place in
149 charbuf for the composition carryover bytes. Reserve an extra
150 space for up to 2 characters produced in a loop.
151 (decode_coding_iso_2022): Abort if there isn't enough place in
152 charbuf for the composition carryover bytes.
153
154 2011-04-21 Eli Zaretskii <eliz@gnu.org>
155
156 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
157 aborting when %lld or %lll format is passed.
158 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
159 %llo or %llx format is passed. (Bug#8545)
160
161 * window.c (window_scroll_line_based): Use a marker instead of
162 simple variables to record original value of point. (Bug#7952)
163
164 * doprnt.c (doprnt): Fix the case where a multibyte sequence
165 produced by %s or %c overflows available buffer space. (Bug#8545)
166
167 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
168
169 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
170 (SIZE_MAX): Move defn after all includes, as they might #define it.
171
172 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
173
174 * w32.c (init_environment): Warn about defaulting HOME to C:\.
175
176 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
177
178 * keyboard.c (Qdelayed_warnings_hook): Define.
179 (command_loop_1): Run `delayed-warnings-hook'
180 if Vdelayed_warnings_list is non-nil.
181 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
182 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
183
184 2011-04-28 Eli Zaretskii <eliz@gnu.org>
185
186 * doprnt.c (doprnt): Don't return value smaller than the buffer
187 size if the message was truncated. (Bug#8545).
188
189 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
190
191 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
192 (Fx_window_property): #if-0 the whole functions, not just the bodies.
193
194 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
195
196 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
197
198 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
199
200 * makefile.w32-in: Update dependencies.
201
202 2011-04-27 Eli Zaretskii <eliz@gnu.org>
203
204 Improve `doprnt' and its usage. (Bug#8545)
205 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
206 `format_end'. Remove support for %l as a conversion specifier.
207 Don't use xrealloc. Improve diagnostics when the %l size modifier
208 is used. Update the commentary.
209
210 * eval.c (verror): Simplify calculation of size_t.
211
212 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
213 messages.
214
215 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
216
217 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
218 change.
219
220 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
221
222 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
223 This makes this file independent of the recent pseudovector change.
224
225 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
226
227 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
228
229 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
230 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
231 Remove unused local.
232 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
233
234 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
235 GCC 4.6.0 optimizes based on type-based alias analysis. For
236 example, if b is of type struct buffer * and v of type struct
237 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
238 != &v->size, and therefore "v->size = 1; b->size = 2; return
239 v->size;" must therefore return 1. This assumption is incorrect
240 for Emacs, since it type-puns struct Lisp_Vector * with many other
241 types. To fix this problem, this patch adds a new type struct
242 vectorlike_header that documents the constraints on layout of vectors
243 and pseudovectors, and helps optimizing compilers not get fooled
244 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
245 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
246 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
247 the size member.
248 (XSETPVECTYPE): Rewrite in terms of new macro.
249 (XSETPVECTYPESIZE): New macro, specifying both type and size.
250 This is a bit clearer, and further avoids the possibility of
251 undesirable aliasing.
252 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
253 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
254 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
255 since Lisp_Subr is a special case (no "next" field).
256 (ASIZE): Now uses header.size rather than size. All
257 previous uses of XVECTOR (foo)->size replaced to use this macro,
258 to avoid the hassle of writing XVECTOR (foo)->header.size.
259 (struct vectorlike_header): New type.
260 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
261 object, to help avoid aliasing.
262 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
263 (SUBRP): Likewise, since Lisp_Subr is a special case.
264 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
265 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
266 (struct Lisp_Hash_Table): Combine first two members into a single
267 struct vectorlike_header member. All uses of "size" and "next" members
268 changed to be "header.size" and "header.next".
269 * buffer.h (struct buffer): Likewise.
270 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
271 * frame.h (struct frame): Likewise.
272 * process.h (struct Lisp_Process): Likewise.
273 * termhooks.h (struct terminal): Likewise.
274 * window.c (struct save_window_data, struct saved_window): Likewise.
275 * window.h (struct window): Likewise.
276 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
277 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
278 * buffer.c (init_buffer_once): Likewise.
279 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
280 special case.
281 * process.c (Fformat_network_address): Use local var for size,
282 for brevity.
283
284 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
285
286 Make the Lisp reader and string-to-float more consistent (Bug#8525)
287 * data.c (atof): Remove decl; no longer used or needed.
288 (digit_to_number): Move to lread.c.
289 (Fstring_to_number): Use new string_to_number function, to be
290 consistent with how the Lisp reader treats infinities and NaNs.
291 Do not assume that floating-point numbers represent EMACS_INT
292 without losing information; this is not true on most 64-bit hosts.
293 Avoid double-rounding errors, by insisting on integers when
294 parsing non-base-10 numbers, as the documentation specifies.
295 * lisp.h (string_to_number): New decl, replacing ...
296 (isfloat_string): Remove.
297 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
298 (read1): Do not accept +. and -. as integers; this
299 appears to have been a coding error. Similarly, do not accept
300 strings like +-1e0 as floating point numbers. Do not report
301 overflow for integer overflows unless the base is not 10 which
302 means we have no simple and reliable way to continue.
303 Break out the floating-point parsing into a new
304 function string_to_number, so that Fstring_to_number parses
305 floating point numbers consistently with the Lisp reader.
306 (digit_to_number): Moved here from data.c. Make it static inline.
307 (E_CHAR, EXP_INT): Remove, replacing with ...
308 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
309 (string_to_number): New function, replacing isfloat_string.
310 This function checks for valid syntax and produces the resulting
311 Lisp float number too. Rework it so that string-to-number
312 no longer mishandles examples like "1.0e+". Use strtoumax,
313 so that overflow for non-base-10 numbers is reported only when
314 there's no portable and simple way to convert to floating point.
315
316 * textprop.c (set_text_properties_1): Rewrite for clarity,
317 and to avoid GCC warning about integer overflow.
318
319 * intervals.h (struct interval): Use EMACS_INT for members
320 where EMACS_UINT might cause problems. See
321 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
322 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
323 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
324 All uses changed.
325 (offset_intervals): Tell GCC not to worry about length overflow
326 when negating a negative length.
327
328 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
329 (overrun_check_free): Likewise.
330
331 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
332 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
333 word size.
334
335 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
336 (gnutls_make_error): Rename local to avoid shadowing.
337 (gnutls_emacs_global_deinit): ifdef out; not used.
338 (Fgnutls_boot): Use const for pointer to readonly storage.
339 Comment out unused local. Fix pointer signedness problems.
340
341 * lread.c (openp): Don't stuff size_t into an 'int'.
342 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
343 about possible signed overflow.
344
345 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
346 (GDK_KEY_g): Don't define if already defined.
347 (xg_prepare_tooltip): Avoid pointer signedness problem.
348 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
349
350 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
351 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
352
353 * xfns.c (Fx_window_property): Simplify a bit,
354 to make a bit faster and to avoid GCC 4.6.0 warning.
355 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
356
357 * fns.c (internal_equal): Don't assume size_t fits in int.
358
359 * alloc.c (compact_small_strings): Tighten assertion a little.
360
361 Replace pEd with more-general pI, and fix some printf arg casts.
362 * lisp.h (pI): New macro, generalizing old pEd macro to other
363 conversion specifiers. For example, use "...%"pI"d..." rather
364 than "...%"pEd"...".
365 (pEd): Remove. All uses replaced with similar uses of pI.
366 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
367 * alloc.c (check_pure_size): Don't overflow by converting size to int.
368 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
369 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
370 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
371 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
372 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
373 64-bit hosts.
374 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
375 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
376 * print.c (safe_debug_print, print_object): Likewise.
377 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
378 to int.
379 Use pI instead of if-then-else-abort. Use %p to avoid casts,
380 avoiding the 0 flag, which is not portable.
381 * process.c (Fmake_network_process): Use pI to avoid cast.
382 * region-cache.c (pp_cache): Likewise.
383 * xdisp.c (decode_mode_spec): Likewise.
384 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
385 behavior on 64-bit hosts with printf arg.
386 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
387 (x_stop_queuing_selection_requests): Likewise.
388 (x_get_window_property): Don't truncate byte count to an 'int'
389 when tracing.
390
391 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
392 here, since it parses constructs like leading '-' and spaces,
393 which are not wanted; and it overflows with large numbers.
394 Instead, simply match F[0-9]+, which is what is wanted anyway.
395
396 * alloc.c: Remove unportable assumptions about struct layout.
397 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
398 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
399 (allocate_vectorlike, make_pure_vector): Use the new macros,
400 plus offsetof, to remove unportable assumptions about struct layout.
401 These assumptions hold on all porting targets that I know of, but
402 they are not guaranteed, they're easy to remove, and removing them
403 makes further changes easier.
404
405 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
406 This doesn't fix a bug but makes the code clearer.
407 (string_overrun_cookie): Now const. Use initializers that
408 don't formally overflow signed char, to avoid warnings.
409 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
410 can cause Emacs to crash when string overrun checking is enabled.
411 (allocate_buffer): Don't assume sizeof (struct buffer) is a
412 multiple of sizeof (EMACS_INT); it need not be, if
413 alignof(EMACS_INT) < sizeof (EMACS_INT).
414 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
415
416 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
417
418 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
419
420 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
421
422 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
423 supposed to be handshaking. (Bug#8556)
424 Reported by Paul Eggert <eggert@cs.ucla.edu>.
425
426 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
427
428 * lisp.h (Qdebug): List symbol.
429 * eval.c (Qdebug): Restore global linkage.
430 * keyboard.c (debug-on-event): New variable.
431 (handle_user_signal): Break into debugger when debug-on-event
432 matches the current signal symbol.
433
434 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
435
436 * alloc.c (check_sblock, check_string_bytes)
437 (check_string_free_list): Convert to standard C.
438
439 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
440
441 * w32.c (emacs_gnutls_push): Fix typo.
442
443 2011-04-25 Eli Zaretskii <eliz@gnu.org>
444
445 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
446 "cast to pointer from integer of different size".
447
448 Improve doprnt and its use in verror. (Bug#8545)
449 * doprnt.c (doprnt): Document the set of format control sequences
450 supported by the function. Use SAFE_ALLOCA instead of always
451 using `alloca'.
452
453 * eval.c (verror): Don't limit the buffer size at size_max-1, that
454 is one byte too soon. Don't use xrealloc; instead xfree and
455 xmalloc anew.
456
457 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
458
459 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
460 callbacks stage.
461
462 * gnutls.c: Renamed global_initialized to
463 gnutls_global_initialized. Added internals for the
464 :verify-hostname-error, :verify-error, and :verify-flags
465 parameters of `gnutls-boot' and documented those parameters in the
466 docstring. Start callback support.
467 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
468 unless a fatal error occured. Call gnutls_alert_send_appropriate
469 on error. Return error code.
470 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
471 (emacs_gnutls_read): Likewise.
472 (Fgnutls_boot): Return handshake error code.
473 (emacs_gnutls_handle_error): New function.
474 (wsaerror_to_errno): Likewise.
475
476 * w32.h (emacs_gnutls_pull): Add prototype.
477 (emacs_gnutls_push): Likewise.
478
479 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
480 (emacs_gnutls_push): Likewise.
481
482 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
483
484 * process.c (wait_reading_process_output): Check if GnuTLS
485 buffered some data internally if no FDs are set for TLS
486 connections.
487
488 * makefile.w32-in (OBJ2): Add gnutls.$(O).
489 (LIBS): Link to USER_LIBS.
490 ($(BLD)/gnutls.$(0)): New target.
491
492 2011-04-24 Eli Zaretskii <eliz@gnu.org>
493
494 * xdisp.c (handle_single_display_spec): Rename the
495 display_replaced_before_p argument into display_replaced_p, to
496 make it consistent with the commentary. Fix typos in the
497 commentary.
498
499 * textprop.c (syms_of_textprop): Remove dead code.
500 (copy_text_properties): Delete obsolete commentary about an
501 interface that was deleted long ago. Fix typos in the description
502 of arguments.
503
504 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
505 to changes in oldXMenu/XMenu.h from 2011-04-16.
506 <menu_help_message, prev_menu_help_message>: Constify.
507 (IT_menu_make_room): menu->help_text is now `const char **';
508 adjust.
509
510 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
511 to changes in oldXMenu/XMenu.h from 2011-04-16.
512 (struct XMenu): Declare `help_text' `const char **'.
513
514 * xfaces.c <Qunspecified>: Make extern again.
515
516 * syntax.c: Include sys/types.h before including regex.h, as
517 required by Posix.
518
519 * doc.c (get_doc_string): Improve the format passed to `error'.
520
521 * doprnt.c (doprnt): Improve commentary.
522
523 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
524
525 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
526 them with etags.
527
528 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
529 changes in globals.h immediately force recompilation.
530 (TAGS): Depend on $(CURDIR)/m/intel386.h and
531 $(CURDIR)/s/ms-w32.h.
532 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
533
534 * character.c (Fchar_direction): Function deleted.
535 (syms_of_character): Don't defsubr it.
536 <char-direction-table>: Deleted.
537
538 2011-04-23 Eli Zaretskii <eliz@gnu.org>
539
540 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
541 * doprnt.c: Include limits.h.
542 (SIZE_MAX): New macro.
543 (doprnt): Return a size_t value. 2nd arg is now size_t. Many
544 local variables are now size_t instead of int or unsigned.
545 Improve overflow protection. Support `l' modifier for integer
546 conversions. Support %l conversion. Don't assume an EMACS_INT
547 argument for integer conversions and for %c.
548
549 * lisp.h (doprnt): Restore prototype.
550
551 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
552 $(SRC)/character.h.
553
554 * Makefile.in (base_obj): Add back doprnt.o.
555
556 * deps.mk (doprnt.o): Add back prerequisites.
557 (callint.o): Depend on character.h.
558
559 * eval.c (internal_lisp_condition_case): Include the handler
560 representation in the error message.
561 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
562 when breaking from the loop.
563
564 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
565
566 * callint.c (Fcall_interactively): When displaying error message
567 about invalid control letter, pass the character's codepoint, not
568 a pointer to its multibyte form. Improve display of the character
569 in octal and display also its hex code.
570
571 * character.c (char_string): Use %x to display the (unsigned)
572 codepoint of an invalid character, to avoid displaying a bogus
573 negative value.
574
575 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
576 `error', not SYMBOL_NAME itself.
577
578 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
579 character arguments to `error'.
580
581 * charset.c (check_iso_charset_parameter): Fix incorrect argument
582 to `error' in error message about FINAL_CHAR argument. Make sure
583 FINAL_CHAR is a character, and use %c when it is passed as
584 argument to `error'.
585
586 2011-04-23 Eli Zaretskii <eliz@gnu.org>
587
588 * s/ms-w32.h (localtime): Redirect to sys_localtime.
589
590 * w32.c: Include <time.h>.
591 (sys_localtime): New function.
592
593 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
594
595 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
596
597 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
598
599 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
600
601 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
602 zombies (Bug#8467).
603
604 2011-04-19 Eli Zaretskii <eliz@gnu.org>
605
606 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
607 gl_state.e_property when gl_state.object is Qt.
608
609 * insdel.c (make_gap_larger): Remove limitation of buffer size
610 to <= INT_MAX.
611
612 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
613
614 * xdisp.c (lookup_glyphless_char_display)
615 (produce_glyphless_glyph): Handle cons cell entry in
616 glyphless-char-display.
617 (Vglyphless_char_display): Document it.
618
619 * term.c (produce_glyphless_glyph): Handle cons cell entry in
620 glyphless-char-display.
621
622 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
623
624 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
625
626 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
627
628 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
629 definition for no-X builds.
630
631 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
632
633 Static checks with GCC 4.6.0 and non-default toolkits.
634
635 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
636
637 * process.c (keyboard_bit_set): Define only if SIGIO.
638 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
639 (send_process): Repair possible setjmp clobbering.
640
641 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
642
643 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
644
645 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
646
647 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
648 Define only if needed.
649
650 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
651 by pacifying GCC about it. Maybe it's time to retire it?
652 * xfaces.c (USG, __TIMEVAL__): Likewise.
653
654 * dispextern.h (struct redisplay_interface): Rename param
655 to avoid shadowing.
656 * termhooks.h (struct terminal): Likewise.
657 * xterm.c (xembed_send_message): Likewise.
658
659 * insdel.c (make_gap_smaller): Define only if
660 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
661
662 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
663 it.
664
665 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
666 so that we aren't warned about unused symbols.
667
668 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
669
670 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
671
672 * xfns.c (x_real_positions): Mark locals as initialized.
673
674 * xmenu.c (xmenu_show): Don't use uninitialized vars.
675
676 * xterm.c: Fix problems found by static analysis with other toolkits.
677 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
678 (x_dispatch_event): Declare static if USE_GTK, and
679 define if USE_GTK || USE_X_TOOLKIT.
680 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
681 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
682 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
683 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
684
685 * xmenu.c (menu_help_callback): Pointer type fixes.
686 Use const pointers when pointing at readonly data. Avoid pointer
687 signedness clashes.
688 (FALSE): Remove unused macro.
689 (update_frame_menubar): Remove unused decl.
690
691 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
692
693 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
694 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
695 (single_menu_item): Rename local to avoid shadowing.
696
697 * keyboard.c (make_lispy_event): Remove unused local var.
698
699 * frame.c, frame.h (x_get_resource_string): Bring this back, but
700 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
701
702 * bitmaps: Change bitmaps from unsigned char back to the X11
703 compatible char. Avoid the old compiler warnings about
704 out-of-range initializers by using, for example, '\xab' rather
705 than 0xab.
706
707 * xgselect.c (xgselect_initialize): Check vs interface
708 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
709
710 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
711
712 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
713 to read-only memory.
714
715 * fns.c (vector): Remove; this old hack is no longer needed.
716
717 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
718 Remove unused var.
719 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
720
721 * xrdb.c (x_load_resources): Omit unused local.
722
723 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
724 (x_window): Rename locals to avoid shadowing.
725 (USG): Use the kludged USG macro, to pacify gcc.
726
727 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
728 (x_term_init): Remove local to avoid shadowing.
729
730 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
731
732 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
733 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
734
735 2011-04-16 Eli Zaretskii <eliz@gnu.org>
736
737 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
738
739 Fix regex.c, syntax.c and friends for buffers > 2GB.
740 * syntax.h (struct gl_state_s): Declare character position members
741 EMACS_INT.
742
743 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
744
745 * textprop.c (verify_interval_modification, interval_of): Declare
746 arguments EMACS_INT.
747
748 * intervals.c (adjust_intervals_for_insertion): Declare arguments
749 EMACS_INT.
750
751 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
752
753 * indent.c (Fvertical_motion): Local variable it_start is now
754 EMACS_INT.
755
756 * regex.c (re_match, re_match_2, re_match_2_internal)
757 (bcmp_translate, regcomp, regexec, print_double_string)
758 (group_in_compile_stack, re_search, re_search_2, regex_compile)
759 (re_compile_pattern, re_exec): Declare arguments and local
760 variables `size_t' and `ssize_t' and return values `regoff_t', as
761 appropriate.
762 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
763 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
764 <compile_stack_type>: `size' and `avail' are now `size_t'.
765
766 * regex.h <regoff_t>: Use ssize_t, not int.
767 (re_search, re_search_2, re_match, re_match_2): Arguments that
768 specify buffer/string position and length are now ssize_t and
769 size_t. Return type is regoff_t.
770
771 2011-04-16 Ben Key <bkey76@gmail.com>
772
773 * nsfont.m: Fixed bugs in ns_get_family and
774 ns_descriptor_to_entity that were caused by using free to
775 deallocate memory blocks that were allocated by xmalloc (via
776 xstrdup). This caused Emacs to crash when compiled with
777 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
778 --enable-checking=xmallocoverrun). xfree is now used to
779 deallocate these memory blocks.
780
781 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
782
783 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
784
785 emacs_write: Accept and return EMACS_INT for sizes.
786 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
787 et seq.
788 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
789 Accept and return EMACS_INT.
790 (emacs_gnutls_write): Return the number of bytes written on
791 partial writes.
792 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
793 (emacs_read, emacs_write): Remove check for negative size, as the
794 Emacs source code has been audited now.
795 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
796 (emacs_read, emacs_write): Use it.
797 * process.c (send_process): Adjust to the new signatures of
798 emacs_write and emacs_gnutls_write. Do not attempt to store
799 a byte offset into an 'int'; it might overflow.
800 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
801
802 * sound.c: Don't assume sizes fit in 'int'.
803 (struct sound_device.period_size, alsa_period_size):
804 Return EMACS_INT, not int.
805 (struct sound_device.write, vox_write, alsa_write):
806 Accept EMACS_INT, not int.
807 (wav_play, au_play): Use EMACS_INT to store sizes and to
808 record read return values.
809
810 2011-04-15 Ben Key <bkey76@gmail.com>
811
812 * keyboard.c (Qundefined): Don't declare static since it is used
813 in nsfns.m.
814 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
815 static since they are used in nsfont.m.
816
817 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
818
819 * process.c (Qprocessp): Don't declare static.
820 * lisp.h (Qprocessp): Declare again.
821
822 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
823
824 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
825
826 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
827
828 Improve C-level modularity by making more things 'static'.
829
830 Don't publish debugger-only interfaces to other modules.
831 * lisp.h (safe_debug_print, debug_output_compilation_hack):
832 (verify_bytepos, count_markers): Move decls to the only modules
833 that need them.
834 * region-cache.h (pp_cache): Likewise.
835 * window.h (check_all_windows): Likewise.
836 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
837
838 * sysdep.c (croak): Now static, if
839 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
840 * syssignal.h (croak): Declare only if not static.
841
842 * alloc.c (refill_memory_reserve): Now static if
843 !defined REL_ALLOC || defined SYSTEM_MALLOC.
844 * lisp.h (refill_memory_reserve): Declare only if not static.
845
846 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
847 Define only if USE_LUCID.
848
849 * xrdb.c (x_customization_string, x_rm_string): Now static.
850
851 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
852 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
853
854 * xdisp.c (draw_row_with_mouse_face): Now static.
855 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
856
857 * window.h (check_all_windows): Mark externally visible.
858
859 * window.c (window_deletion_count): Now static.
860
861 * undo.c: Make symbols static if they're not exported.
862 (last_undo_buffer, last_boundary_position, pending_boundary):
863 Now static.
864
865 * textprop.c (interval_insert_behind_hooks): Now static.
866 (interval_insert_in_front_hooks): Likewise.
867
868 * term.c: Make symbols static if they're not exported.
869 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
870 (max_frame_lines, tty_set_terminal_modes):
871 (tty_reset_terminal_modes, tty_turn_off_highlight):
872 (get_tty_terminal): Now static.
873 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
874 * termhooks.h (term_mouse_moveto): Do not declare if
875 HAVE_WINDOW_SYSTEM.
876 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
877 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
878
879 * sysdep.c: Make symbols static if they're not exported.
880 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
881 Now static.
882 (sigprocmask_set, full_mask): Remove; unused.
883 (wait_debugging): Mark as visible.
884 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
885 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
886
887 * syntax.c (syntax_temp): Define only if !__GNUC__.
888
889 * sound.c (current_sound_device, current_sound): Now static.
890
891 * search.c (searchbufs, searchbuf_head): Now static.
892
893 * scroll.c (scroll_cost): Remove; unused.
894 * dispextern.h (scroll_cost): Remove decl.
895
896 * region-cache.h (pp_cache): Mark as externally visible.
897
898 * process.c: Make symbols static if they're not exported.
899 (process_tick, update_tick, create_process, chan_process):
900 (Vprocess_alist, proc_buffered_char, datagram_access):
901 (fd_callback_data, send_process_frame, process_sent_to): Now static.
902 (deactivate_process): Mark defn as static, as well as decl.
903 * lisp.h (create_process): Remove decl.
904 * process.h (chan_process, Vprocess_alist): Remove decls.
905
906 * print.c: Make symbols static if they're not exported.
907 (print_depth, new_backquote_output, being_printed, print_buffer):
908 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
909 (print_interval, print_number_index, initial_stderr_stream):
910 Now static.
911 * lisp.h (Fprinc): Remove decl.
912 (debug_output_compilation_hack): Mark as externally visible.
913
914 * sysdep.c (croak): Move decl from here to syssignal.h.
915 * syssignal.h (croak): Put it here, so the API can be checked when
916 'croak' is called from dissociate_if_controlling_tty.
917
918 * minibuf.c: Make symbols static if they're not exported.
919 (minibuf_save_list, choose_minibuf_frame): Now static.
920 * lisp.h (choose_minibuf_frame): Remove decl.
921
922 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
923
924 * lread.c: Make symbols static if they're not exported.
925 (read_objects, initial_obarray, oblookup_last_bucket_number):
926 Now static.
927 (make_symbol): Remove; unused.
928 * lisp.h (initial_obarray, make_symbol): Remove decls.
929
930 * keyboard.c: Make symbols static if they're not exported.
931 (single_kboard, recent_keys_index, total_keys, recent_keys):
932 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
933 (this_single_command_key_start, echoing, last_auto_save):
934 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
935 (command_loop, echo_now, keyboard_init_hook, help_char_p):
936 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
937 (Vlispy_mouse_stem, double_click_count):
938 Now static.
939 (force_auto_save_soon): Define only if SIGDANGER.
940 (ignore_mouse_drag_p): Now static if
941 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
942 (print_help): Remove; unused.
943 (stop_character, last_timer_event): Mark as externally visible.
944 * keyboard.h (ignore_mouse_drag_p): Declare only if
945 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
946 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
947 * lisp.h (echoing): Remove decl.
948 (force_auto_save_soon): Declare only if SIGDANGER.
949 * xdisp.c (redisplay_window): Simplify code, to make it more
950 obvious that ignore_mouse_drag_p is not accessed if !defined
951 USE_GTK && !defined HAVE_NS.
952
953 * intervals.c: Make symbols static if they're not exported.
954 (merge_properties_sticky, merge_interval_right, delete_interval):
955 Now static.
956 * intervals.h (merge_interval_right, delete_interval): Remove decls.
957
958 * insdel.c: Make symbols static if they're not exported.
959 However, leave prepare_to_modify_buffer alone. It's never
960 called from outside this function, but that appears to be a bug.
961 (combine_after_change_list, combine_after_change_buffer):
962 (adjust_after_replace, signal_before_change): Now static.
963 (adjust_after_replace_noundo): Remove; unused.
964 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
965 (signal_before_change): Remove decls.
966
967 * indent.c (val_compute_motion, val_vmotion): Now static.
968
969 * image.c: Make symbols static if they're not exported.
970 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
971 if USE_GTK.
972 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
973 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
974
975 * fringe.c (standard_bitmaps): Now static.
976 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
977
978 * frame.c: Make symbols static if they're not exported.
979 (x_report_frame_params, make_terminal_frame): Now static.
980 (get_frame_param): Now static, unless HAVE_NS.
981 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
982 (x_get_resource_string): Remove; not used.
983 * frame.h (make_terminal_frame, x_report_frame_params):
984 (x_get_resource_string); Remove decls.
985 (x_fullscreen_adjust): Declare only if WINDOWSNT.
986 * lisp.h (get_frame_param): Declare only if HAVE_NS.
987
988 * font.c, fontset.c: Make symbols static if they're not exported.
989 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
990 (FACE_SUITABLE_FOR_CHAR_P): Use it.
991 * font.c (font_close_object): Now static.
992 * font.h (font_close_object): Remove.
993 * fontset.c (FONTSET_OBJLIST): Remove.
994 (free_realized_fontset) #if-0 the body, which does nothing.
995 (face_suitable_for_char_p): #if-0, as it's never called.
996 * fontset.h (face_suitable_for_char_p): Remove decl.
997 * xfaces.c (face_at_string_position): Use
998 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
999 since 0 is always ASCII.
1000
1001 * fns.c (weak_hash_tables): Now static.
1002
1003 * fileio.c: Make symbols static if they're not exported.
1004 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
1005 (Vwrite_region_annotation_buffers): Now static.
1006
1007 * eval.c: Make symbols static if they're not exported.
1008 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
1009 * lisp.h (backtrace_list): Remove decl.
1010
1011 * emacs.c: Make symbols static if they're not exported.
1012 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
1013 (fatal_error_code, fatal_error_signal_hook, standard_args):
1014 Now static.
1015 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
1016 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
1017 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
1018 * lisp.h (fatal_error_signal_hook): Remove decl.
1019 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
1020
1021 * editfns.c: Move a (normally-unused) function to its only use.
1022 * editfns.c, lisp.h (get_operating_system_release): Remove.
1023 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
1024 worth the hassle of breaking this out.
1025
1026 * xterm.c: Make symbols static if they're not exported.
1027 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
1028 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
1029 (x_destroy_window, x_delete_display):
1030 Now static.
1031 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
1032 (x_mouse_leave): Remove; unused.
1033 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
1034 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
1035 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
1036 Remove decls.
1037 (x_mouse_leave): Declare only if WINDOWSNT.
1038 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
1039 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
1040 USE_X_TOOLKIT.
1041
1042 * ftxfont.c: Make symbols static if they're not exported.
1043 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
1044 HAVE_FREETYPE.
1045 * font.h (ftxfont_driver): Likewise.
1046
1047 * xfns.c: Make symbols static if they're not exported.
1048 (x_last_font_name, x_display_info_for_name):
1049 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
1050 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
1051 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
1052 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
1053 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
1054 (last_show_tip_args): Now static.
1055 (xic_defaut_fontset, xic_create_fontsetname): Define only if
1056 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
1057 (x_screen_planes): Remove; unused.
1058 * dispextern.h (x_screen_planes): Remove decl.
1059
1060 * dispnew.c: Make symbols static if they're not exported.
1061 * dispextern.h (redraw_garbaged_frames, scrolling):
1062 (increment_row_positions): Remove.
1063 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
1064 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
1065 Now static.
1066 (redraw_garbaged_frames): Remove; unused.
1067
1068 * xfaces.c: Make symbols static if they're not exported.
1069 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
1070 Remove decls.
1071 * xterm.h (defined_color): Remove decls.
1072 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
1073 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
1074 (menu_face_changed_default, defined_color, free_realized_face):
1075 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
1076 (ascii_face_of_lisp_face): Remove; unused.
1077
1078 * xdisp.c: Make symbols static if they're not exported.
1079 * dispextern.h (scratch_glyph_row, window_box_edges):
1080 (glyph_to_pixel_coords, set_cursor_from_row):
1081 (get_next_display_element, set_iterator_to_next):
1082 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
1083 (show_mouse_face): Remove decls
1084 * frame.h (message_buf_print): Likewise.
1085 * lisp.h (pop_message, set_message, check_point_in_composition):
1086 Likewise.
1087 * xterm.h (set_vertical_scroll_bar): Likewise.
1088 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
1089 (message_buf_print, scratch_glyph_row, displayed_buffer):
1090 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
1091 (get_next_display_element, show_mouse_face, window_box_edges):
1092 (frame_to_window_pixel_xy, check_point_in_composition):
1093 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
1094 (glyph_to_pixel_coords): Remove; unused.
1095
1096 * dired.c (file_name_completion): Now static.
1097
1098 * dbusbind.c (xd_in_read_queued_messages): Now static.
1099
1100 * lisp.h (circular_list_error, FOREACH): Remove; unused.
1101 * data.c (circular_list_error): Remove.
1102
1103 * commands.h (last_point_position, last_point_position_buffer):
1104 (last_point_position_window): Remove decls.
1105 * keyboard.c: Make these variables static.
1106
1107 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
1108 decls.
1109 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
1110 (iso_code_class, detect_coding, code_convert_region): Now static.
1111 (encode_coding_gap): Remove; unused.
1112
1113 * chartab.c (chartab_chars, chartab_bits): Now static.
1114
1115 * charset.h (charset_iso_8859_1): Remove decl.
1116 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
1117 Now static.
1118
1119 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
1120 * ccl.c (Vccl_program_table): Now static.
1121 (check_ccl_update): Remove; unused.
1122
1123 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
1124 * category.h: ... from here.
1125 * category.c (check_category_table, set_category_set): Now static.
1126
1127 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
1128 * lisp.h: Remove these decls.
1129
1130 * buffer.c (buffer_count): Remove unused var.
1131
1132 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
1133 so that it's not optimized away.
1134 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
1135 * dispextern.h (bidi_dump_cached_states): Remove, since it's
1136 exported only to the debugger.
1137
1138 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
1139 * atimer.h (run_all_atimers): Removed; not exported.
1140
1141 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
1142 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
1143 was inaccessible from Lisp.
1144 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
1145 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
1146
1147 alloc.c: Import and export fewer symbols, and remove unused items.
1148 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
1149 is defined.
1150 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
1151 it's not optimized away by whole-program optimization.
1152 (message_enable_multibyte, free_misc): Remove.
1153 (catchlist, handlerlist, mark_backtrace):
1154 Declare only if BYTE_MARK_STACK.
1155 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
1156 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
1157 (message_enable_multibyte): Remove decl.
1158 (free_misc, interval_free_list, float_block, float_block_index):
1159 (n_float_blocks, float_free_list, cons_block, cons_block_index):
1160 (cons_free_list, last_marked_index):
1161 Now static.
1162 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
1163 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
1164 (mark_backtrace): Define only if BYTE_MARK_STACK.
1165 * xdisp.c (message_enable_multibyte): Now static.
1166
1167 Declare Lisp_Object Q* variables to be 'static' if not exported.
1168 This makes it easier for human readers (and static analyzers)
1169 to see whether these variables are used from other modules.
1170 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
1171 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
1172 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
1173 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
1174 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
1175 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
1176 * xmenu.c, xselect.c:
1177 Declare Q* vars static if they are not used in other modules.
1178 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
1179 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
1180 Remove decls of unexported vars.
1181 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
1182
1183 * lisp.h (DEFINE_FUNC): Make sname 'static'.
1184
1185 Make Emacs functions such as Fatom 'static' by default.
1186 This makes it easier for human readers (and static analyzers)
1187 to see whether these functions can be called from other modules.
1188 DEFUN now defines a static function. To make the function external
1189 so that it can be used in other C modules, use the new macro DEFUE.
1190 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
1191 (Finit_image_library):
1192 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
1193 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
1194 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
1195 Remove decls, since these functions are now static.
1196 (Funintern, Fget_internal_run_time): New decls, since these functions
1197 were already external.
1198
1199 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
1200 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
1201 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
1202 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
1203 * keyboard.c, keymap.c, lread.c:
1204 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
1205 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
1206 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
1207 Mark functions with DEFUE instead of DEFUN,
1208 if they are used in other modules.
1209 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
1210 decls for now-static functions.
1211 * buffer.h (Fdelete_overlay): Remove decl.
1212 * callproc.c (Fgetenv_internal): Mark as internal.
1213 * composite.c (Fremove_list_of_text_properties): Remove decl.
1214 (Fcomposition_get_gstring): New forward static decl.
1215 * composite.h (Fcomposite_get_gstring): Remove decl.
1216 * dired.c (Ffile_attributes): New forward static decl.
1217 * doc.c (Fdocumntation_property): New forward static decl.
1218 * eval.c (Ffetch_bytecode): New forward static decl.
1219 (Funintern): Remove extern decl; now in .h file where it belongs.
1220 * fileio.c (Fmake_symbolic_link): New forward static decl.
1221 * image.c (Finit_image_library): New forward static decl.
1222 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
1223 * intervals.h (Fprevious_property_change):
1224 (Fremove_list_of_text_properties): Remove decls.
1225 * keyboard.c (Fthis_command_keys): Remove decl.
1226 (Fcommand_execute): New forward static decl.
1227 * keymap.c (Flookup_key): New forward static decl.
1228 (Fcopy_keymap): Now static.
1229 * keymap.h (Flookup_key): Remove decl.
1230 * process.c (Fget_process): New forward static decl.
1231 (Fprocess_datagram_address): Mark as internal.
1232 * syntax.c (Fsyntax_table_p): New forward static decl.
1233 (skip_chars): Remove duplicate decl.
1234 * textprop.c (Fprevious_property_change): New forward static decl.
1235 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
1236 Now internal.
1237 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
1238 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
1239
1240 * editfns.c (Fformat): Remove unreachable code.
1241
1242 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
1243
1244 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
1245 change. (Bug#8496)
1246
1247 2011-04-13 Eli Zaretskii <eliz@gnu.org>
1248
1249 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
1250 when at ZV. (Bug#8487)
1251
1252 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
1253
1254 * charset.c (Fclear_charset_maps): Use xfree instead of free.
1255 (Bug#8437)
1256 * keyboard.c (parse_tool_bar_item): Likewise.
1257 * sound.c (sound_cleanup, alsa_close): Likewise.
1258 * termcap.c (tgetent): Likewise.
1259 * xfns.c (x_default_font_parameter): Likewise.
1260 * xsettings.c (read_and_apply_settings): Likewise.
1261
1262 * alloc.c (overrun_check_malloc, overrun_check_realloc)
1263 (overrun_check_free): Protoize.
1264
1265 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
1266
1267 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
1268 since callers should never pass a negative size.
1269 Change the signature to match that of plain 'read' and 'write'; see
1270 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
1271 * lisp.h: Update prototypes of emacs_write and emacs_read.
1272
1273 2011-04-11 Eli Zaretskii <eliz@gnu.org>
1274
1275 * xdisp.c (redisplay_window): Don't try to determine the character
1276 position of the scroll margin if the window start point w->startp
1277 is outside the buffer's accessible region. (Bug#8468)
1278
1279 2011-04-10 Eli Zaretskii <eliz@gnu.org>
1280
1281 Fix write-region and its subroutines for buffers > 2GB.
1282 * fileio.c (a_write, e_write): Modify declaration of arguments and
1283 local variables to support buffers larger than 2GB.
1284 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
1285
1286 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
1287 argument, local variables, and return value.
1288
1289 * lisp.h: Update prototypes of emacs_write and emacs_read.
1290
1291 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
1292
1293 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
1294
1295 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
1296
1297 Fix more problems found by GCC 4.6.0's static checks.
1298
1299 * xdisp.c (vmessage): Use a better test for character truncation.
1300
1301 * charset.c (load_charset_map): <, not <=, for optimization,
1302 and to avoid potential problems with integer overflow.
1303 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
1304 * casetab.c (set_identity, shuffle): Likewise.
1305 * editfns.c (Fformat): Likewise.
1306 * syntax.c (skip_chars): Likewise.
1307
1308 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
1309 This also lets GCC 4.6.0 generate slightly better loop code.
1310
1311 * callint.c (Fcall_interactively): <, not <=, for optimization.
1312 (Fcall_interactively): Count the number of arguments produced,
1313 not the number of arguments given. This is simpler and lets GCC
1314 4.6.0 generate slightly better code.
1315
1316 * ftfont.c: Distingish more carefully between FcChar8 and char.
1317 The previous code passed unsigned char * to a functions like
1318 strlen and xstrcasecmp that expect char *, which does not
1319 conform to the C standard.
1320 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
1321 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
1322 char * when the C standard requires it.
1323
1324 * keyboard.c (read_char): Remove unused var.
1325
1326 * eval.c: Port to Windows vsnprintf (Bug#8435).
1327 Include <limits.h>.
1328 (SIZE_MAX): Define if the headers do not.
1329 (verror): Do not give up if vsnprintf returns a negative count.
1330 Instead, grow the buffer. This ports to Windows vsnprintf, which
1331 does not conform to C99. Problem reported by Eli Zaretskii.
1332 Also, simplify the allocation scheme, by avoiding the need for
1333 calling realloc, and removing the ALLOCATED variable.
1334
1335 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
1336
1337 Remove invocations of doprnt, as Emacs now uses vsnprintf.
1338 But keep the doprint source code for now, as we might revamp it
1339 and use it again (Bug#8435).
1340 * lisp.h (doprnt): Remove.
1341 * Makefile.in (base_obj): Remove doprnt.o.
1342 * deps.mk (doprnt.o): Remove.
1343
1344 error: Print 32- and 64-bit integers portably (Bug#8435).
1345 Without this change, on typical 64-bit hosts error ("...%d...", N)
1346 was used to print both 32- and 64-bit integers N, which relied on
1347 undefined behavior.
1348 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
1349 New macro.
1350 * lisp.h (error, verror): Mark as printf-like functions.
1351 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
1352 Report overflow in size calculations when allocating printf buffer.
1353 Do not truncate output string at its first null byte.
1354 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
1355 Truncate the output at a character boundary, since vsnprintf does not
1356 do that.
1357 * charset.c (check_iso_charset_parameter): Convert internal
1358 character to string before calling 'error', since %c now has the
1359 printf meaning.
1360 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
1361 overflow when computing char to be passed to 'error'. Do not
1362 pass Lisp_Object to 'error'; pass the integer instead.
1363 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
1364 formatted with plain %d.
1365
1366 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
1367
1368 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
1369
1370 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
1371
1372 * xterm.c (x_catch_errors): Remove duplicate declaration.
1373
1374 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
1375
1376 * xdisp.c, lisp.h (message_nolog): Remove; unused.
1377
1378 2011-04-10 Jim Meyering <meyering@redhat.com>
1379
1380 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
1381 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
1382 return ssize_t not "int", and use size_t as the buffer length.
1383 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
1384 * gnutls.h: Update declarations.
1385 * process.c (read_process_output): Use ssize_t, to match.
1386 (send_process): Likewise.
1387
1388 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
1389
1390 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
1391
1392 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
1393
1394 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
1395 unsigned char, to match FcChar8 type definition.
1396
1397 * xterm.c (handle_one_xevent):
1398 * xmenu.c (create_and_show_popup_menu):
1399 * xselect.c (x_decline_selection_request)
1400 (x_reply_selection_request): Avoid type-punned deref of X events.
1401
1402 2011-04-09 Eli Zaretskii <eliz@gnu.org>
1403
1404 Fix some uses of `int' instead of EMACS_INT.
1405 * search.c (string_match_1, fast_string_match)
1406 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
1407 (scan_buffer, find_next_newline_no_quit)
1408 (find_before_next_newline, search_command, Freplace_match)
1409 (Fmatch_data): Make some `int' variables be EMACS_INT.
1410
1411 * xdisp.c (display_count_lines): 3rd argument and return value now
1412 EMACS_INT. All callers changed.
1413 (pint2hrstr): Last argument is now EMACS_INT.
1414
1415 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
1416 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1417 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
1418 (decode_coding_utf_16, decode_coding_emacs_mule)
1419 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
1420 (decode_coding_ccl, decode_coding_charset)
1421 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
1422 (decode_coding_iso_2022, decode_coding_emacs_mule)
1423 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
1424 <char_offset, last_offset>: Declare EMACS_INT.
1425 (encode_coding_utf_8, encode_coding_utf_16)
1426 (encode_coding_emacs_mule, encode_invocation_designation)
1427 (encode_designation_at_bol, encode_coding_iso_2022)
1428 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
1429 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
1430 Declare EMACS_INT.
1431 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
1432 (encode_invocation_designation): Last argument P_NCHARS is now
1433 EMACS_INT.
1434 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
1435 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
1436
1437 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
1438 All users changed.
1439
1440 * ccl.c (Fccl_execute_on_string): Declare some variables
1441 EMACS_INT.
1442
1443 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
1444
1445 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
1446
1447 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
1448
1449 * process.c (Fformat_network_address): Doc fix.
1450
1451 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
1452
1453 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
1454
1455 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
1456
1457 * keyboard.c (read_char): Call Lisp function help-form-show,
1458 instead of using internal_with_output_to_temp_buffer.
1459 (Qhelp_form_show): New var.
1460 (syms_of_keyboard): Use DEFSYM macro.
1461
1462 * print.c (internal_with_output_to_temp_buffer): Function deleted.
1463
1464 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
1465
1466 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
1467
1468 * process.c (Flist_processes): Removed to Lisp.
1469 (list_processes_1): Deleted.
1470
1471 2011-04-06 Eli Zaretskii <eliz@gnu.org>
1472
1473 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
1474
1475 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
1476
1477 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
1478
1479 Fix more problems found by GCC 4.6.0's static checks.
1480
1481 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
1482
1483 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
1484
1485 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1486
1487 * xdisp.c (vmessage): Mark as a printf-like function.
1488
1489 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
1490
1491 * sound.c (sound_warning): Don't crash if arg contains a printf format.
1492
1493 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
1494 printf-like functions.
1495 (tiff_load): Add casts to remove these marks before passing them
1496 to system-supplied API.
1497
1498 * eval.c (Fsignal): Remove excess argument to 'fatal'.
1499
1500 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
1501 This avoids several warnings with gcc -Wstrict-overflow.
1502 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
1503 directly, rather than having caller test rule sign. This avoids
1504 some unnecessary tests.
1505 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
1506 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
1507 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
1508
1509 * xfont.c (xfont_text_extents): Remove var that was set but not used.
1510 (xfont_open): Avoid unnecessary tests.
1511
1512 * composite.c (composition_gstring_put_cache): Use unsigned integer.
1513
1514 * composite.h, composite.c (composition_gstring_put_cache):
1515 Use EMACS_INT, not int, for length.
1516
1517 * composite.h (COMPOSITION_DECODE_REFS): New macro,
1518 breaking out part of COMPOSITION_DECODE_RULE.
1519 (COMPOSITION_DECODE_RULE): Use it.
1520 * composite.c (get_composition_id): Remove unused local vars,
1521 by using the new macro.
1522
1523 * textprop.c (set_text_properties_1): Change while to do-while,
1524 since the condition is always true at first.
1525
1526 * intervals.c (graft_intervals_into_buffer): Mark var as used.
1527 (interval_deletion_adjustment): Return unsigned value.
1528 All uses changed.
1529
1530 * process.c (list_processes_1, create_pty, read_process_output):
1531 (exec_sentinel): Remove vars that were set but not used.
1532 (create_pty): Remove unnecessary "volatile"s.
1533 (Fnetwork_interface_info): Avoid possibility of int overflow.
1534 (read_process_output): Do adaptive read buffering even if carryover.
1535 (read_process_output): Simplify nbytes computation if buffered.
1536
1537 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
1538
1539 * syntax.c (scan_words): Remove var that was set but not used.
1540 (update_syntax_table): Use unsigned instead of int.
1541
1542 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
1543 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
1544 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
1545
1546 * print.c (print_error_message): Avoid int overflow.
1547
1548 * font.c (font_list_entities): Redo for clarity,
1549 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
1550
1551 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
1552 (font_score): Avoid potential overflow in diff calculation.
1553
1554 * fns.c (substring_both): Remove var that is set but not used.
1555 (sxhash): Redo loop for clarity and to avoid wraparound warning.
1556
1557 * eval.c (funcall_lambda): Rename local to avoid shadowing.
1558
1559 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
1560 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
1561 can always succeed if overflow has undefined behavior.
1562
1563 * search.c (boyer_moore, wordify): Remove vars set but not used.
1564 (wordify): Omit three unnecessary tests.
1565
1566 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
1567 All callers changed. This avoids the need for an unused var.
1568
1569 * casefiddle.c (casify_region): Remove var that is set but not used.
1570
1571 * dired.c (file_name_completion): Remove var that is set but not used.
1572
1573 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
1574
1575 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
1576 (Finsert_file_contents): Remove unnecessary code checking fd.
1577
1578 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
1579 Check for integer overflow on size calculations.
1580
1581 * buffer.c (Fprevious_overlay_change): Remove var that is set
1582 but not used.
1583
1584 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
1585 Remove vars that are set but not used.
1586 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
1587 (timer_check_2): Mark vars as initialized.
1588
1589 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
1590
1591 * image.c (lookup_image): Remove var that is set but not used.
1592 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
1593
1594 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
1595 that are set but not used.
1596
1597 * xfns.c (make_invisible_cursor): Don't return garbage
1598 if XCreateBitmapFromData fails (Bug#8410).
1599
1600 * xselect.c (x_get_local_selection, x_handle_property_notify):
1601 Remove vars that are set but not used.
1602
1603 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
1604 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
1605
1606 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
1607 Remove var that is set but not used.
1608 (scroll_bar_windows_size): Now size_t, not int.
1609 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
1610 Check for overflow.
1611
1612 * xfaces.c (realize_named_face): Remove vars that are set but not used.
1613 (map_tty_color) [!defined MSDOS]: Likewise.
1614
1615 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
1616
1617 * coding.c: Remove vars that are set but not used.
1618 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
1619 All callers changed.
1620 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
1621 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
1622 (decode_coding_charset): Remove vars that are set but not used.
1623
1624 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
1625 that is set but not used.
1626
1627 * print.c (print_object): Remove var that is set but not used.
1628
1629 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
1630 The gnulib version avoids calling malloc in the usual case,
1631 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
1632 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
1633 * filelock.c (current_lock_owner): Likewise.
1634 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
1635 * sysdep.c: Include allocator.h, careadlinkat.h.
1636 (emacs_no_realloc_allocator): New static constant.
1637 (emacs_readlink): New function.
1638 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
1639 ../lib/careadlinkat.h.
1640
1641 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
1642
1643 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
1644 first non-nil return value).
1645
1646 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
1647
1648 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
1649 if not defined (Bug#8403).
1650
1651 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
1652
1653 * xdisp.c (display_count_lines): Remove parameter `start',
1654 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1655 (get_char_face_and_encoding): Remove parameter `multibyte_p',
1656 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1657 (fill_stretch_glyph_string): Remove parameters `row' and `area',
1658 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
1659 and thereabouts. All callers changed.
1660 (get_per_char_metric): Remove parameter `f', unused since
1661 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1662
1663 2011-04-02 Jim Meyering <meyering@redhat.com>
1664
1665 do not dereference NULL upon failed strdup
1666 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
1667 (ns_get_family): Likewise.
1668
1669 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
1670
1671 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
1672
1673 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
1674
1675 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
1676 later (Bug#8403).
1677
1678 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
1679
1680 Add lexical binding.
1681
1682 * window.c (Ftemp_output_buffer_show): New fun.
1683 (Fsave_window_excursion):
1684 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
1685
1686 * lread.c (lisp_file_lexically_bound_p): New function.
1687 (Fload): Bind Qlexical_binding.
1688 (readevalloop): Remove `evalfun' arg.
1689 Bind Qinternal_interpreter_environment.
1690 (Feval_buffer): Bind Qlexical_binding.
1691 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
1692 Mark as dynamic.
1693 (syms_of_lread): Declare `lexical-binding'.
1694
1695 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
1696
1697 * keyboard.c (eval_dyn): New fun.
1698 (menu_item_eval_property): Use it.
1699
1700 * image.c (parse_image_spec): Use Ffunctionp.
1701
1702 * fns.c (concat, mapcar1): Accept byte-code-functions.
1703
1704 * eval.c (Fsetq): Handle lexical vars.
1705 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
1706 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
1707 (FletX, Flet): Obey lexical binding.
1708 (Fcommandp): Handle closures.
1709 (Feval): New `lexical' arg.
1710 (eval_sub): New function extracted from Feval. Use it almost
1711 everywhere where Feval was used. Look up vars in lexical env.
1712 Handle closures.
1713 (Ffunctionp): Move from subr.el.
1714 (Ffuncall): Handle closures.
1715 (apply_lambda): Remove `eval_flags'.
1716 (funcall_lambda): Handle closures and new byte-code-functions.
1717 (Fspecial_variable_p): New function.
1718 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
1719 but without exporting it to Lisp.
1720
1721 * doc.c (Fdocumentation, store_function_docstring):
1722 * data.c (Finteractive_form): Handle closures.
1723
1724 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
1725 interactive spec.
1726
1727 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
1728 byte-codes.
1729 (exec_byte_code): New function extracted from Fbyte_code to handle new
1730 calling convention for byte-code-functions. Add new byte-codes.
1731
1732 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
1733
1734 * alloc.c (Fmake_symbol): Init new `declared_special' field.
1735
1736 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
1737
1738 * xdisp.c (redisplay_internal): Fix prototype.
1739
1740 2011-03-31 Eli Zaretskii <eliz@gnu.org>
1741
1742 * xdisp.c (SCROLL_LIMIT): New macro.
1743 (try_scrolling): Use it when setting scroll_limit. Limit
1744 scrolling to 100 screen lines.
1745 (redisplay_window): Even when falling back on "recentering",
1746 position point in the window according to scroll-conservatively,
1747 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
1748
1749 (try_scrolling): When point is above the window, allow searching
1750 as far as scroll_max, or one screenful, to compute vertical
1751 distance from PT to the scroll margin position. This prevents
1752 try_scrolling from unnecessarily failing when
1753 scroll-conservatively is set to a value slightly larger than the
1754 window height. Clean up the case of PT below the margin at bottom
1755 of window: scroll_max can no longer be INT_MAX. When aggressive
1756 scrolling is in use, don't let point enter the opposite scroll
1757 margin as result of the scroll.
1758 (syms_of_xdisp) <scroll-conservatively>: Document the
1759 threshold of 100 lines for never-recentering scrolling.
1760
1761 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
1762
1763 * dispextern.h (move_it_by_lines):
1764 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
1765 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
1766 (message_log_check_duplicate): Remove parameters `prev_bol' and
1767 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1768 (redisplay_internal): Remove parameter `preserve_echo_area',
1769 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
1770
1771 * indent.c (Fvertical_motion):
1772 * window.c (window_scroll_pixel_based, Frecenter):
1773 Don't pass `need_y_p' to `move_it_by_lines'.
1774
1775 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
1776
1777 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
1778 steal a few bits to be more compact.
1779 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
1780 Remove unneeded casts.
1781
1782 * bytecode.c (Fbyte_code): CAR and CDR can GC.
1783
1784 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
1785
1786 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
1787 binding" message (bug#7967).
1788
1789 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
1790
1791 Fix more problems found by GCC 4.6.0's static checks.
1792
1793 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
1794 Remove unused local var.
1795
1796 * editfns.c (Fmessage_box): Remove unused local var.
1797
1798 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
1799 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1800 Omit unused local vars.
1801 * window.c (shrink_windows): Omit unused local var.
1802 * menu.c (digest_single_submenu): Omit unused local var.
1803 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
1804 Omit unused local var.
1805
1806 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
1807 Don't assume string length fits in int.
1808 (keyremap_step, read_key_sequence): Use size_t for sizes.
1809 (read_key_sequence): Don't check last_real_key_start redundantly.
1810
1811 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
1812 instead of alloca (Bug#8344).
1813
1814 * eval.c (Fbacktrace): Don't assume nargs fits in int.
1815 (Fbacktrace_frame): Don't assume nframes fits in int.
1816
1817 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
1818
1819 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
1820 concerns.
1821
1822 * term.c (produce_glyphless_glyph): Remove unnecessary test.
1823
1824 * cm.c (calccost): Turn while-do into do-while, for clarity.
1825
1826 * keyboard.c (syms_of_keyboard): Use the same style as later
1827 in this function when indexing through an array. This also
1828 works around GCC bug 48267.
1829
1830 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
1831
1832 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
1833
1834 * chartab.c (sub_char_table_ref_and_range): Redo for slight
1835 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
1836
1837 * keyboard.c, keyboard.h (num_input_events): Now size_t.
1838 This avoids undefined behavior on integer overflow, and is a bit
1839 more convenient anyway since it is compared to a size_t variable.
1840
1841 Variadic C functions now count arguments with size_t, not int.
1842 This avoids an unnecessary limitation on 64-bit machines, which
1843 caused (substring ...) to crash on large vectors (Bug#8344).
1844 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
1845 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
1846 All variadic functions and their callers changed accordingly.
1847 (struct gcpro.nvars): Now size_t, not int. All uses changed.
1848 * data.c (arith_driver, float_arith_driver): Likewise.
1849 * editfns.c (general_insert_function): Likewise.
1850 * eval.c (struct backtrace.nargs, interactive_p)
1851 (internal_condition_case_n, run_hook_with_args, apply_lambda)
1852 (funcall_lambda, mark_backtrace): Likewise.
1853 * fns.c (concat): Likewise.
1854 * frame.c (x_set_frame_parameters): Likewise.
1855 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
1856 0 if not found, not -1. All callers changed.
1857
1858 * alloc.c (garbage_collect): Don't assume stack size fits in int.
1859 (stack_copy_size): Now size_t, not int.
1860 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
1861
1862 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
1863
1864 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
1865 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1866 All callers changed.
1867
1868 * lisp.h (multibyte_char_to_unibyte):
1869 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
1870 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1871 * character.h (CHAR_TO_BYTE8):
1872 * cmds.c (internal_self_insert):
1873 * editfns.c (general_insert_function):
1874 * keymap.c (push_key_description):
1875 * search.c (Freplace_match):
1876 * xdisp.c (message_dolog, set_message_1): All callers changed.
1877
1878 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1879
1880 * keyboard.c (safe_run_hook_funcall): New function.
1881 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
1882 don't set the hook to nil, but remove the offending function instead.
1883 (Qcommand_hook_internal): Remove, unused.
1884 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
1885 Vcommand_hook_internal.
1886
1887 * eval.c (enum run_hooks_condition): Remove.
1888 (funcall_nil, funcall_not): New functions.
1889 (run_hook_with_args): Call each function through a `funcall' argument.
1890 Remove `cond' argument, now redundant.
1891 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
1892 (Frun_hook_with_args_until_failure): Adjust accordingly.
1893 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
1894
1895 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
1896
1897 * dispextern.h (string_buffer_position): Remove declaration.
1898
1899 * print.c (strout): Remove parameter `multibyte', unused since
1900 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
1901
1902 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
1903 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
1904 All callers changed.
1905
1906 * w32.c (_wsa_errlist): Use braces for struct initializers.
1907
1908 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
1909 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
1910 All callers changed.
1911 (string_buffer_position): Likewise. Also, make static (it's never
1912 used outside xdisp.c).
1913 (cursor_row_p): Remove parameter `w', unused since
1914 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
1915 (decode_mode_spec): Remove parameter `precision', introduced during
1916 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
1917 All callers changed.
1918
1919 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1920
1921 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
1922
1923 2011-03-27 Anders Lindgren <andlind@gmail.com>
1924
1925 * nsterm.m (ns_menu_bar_is_hidden): New variable.
1926 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
1927 (ns_update_auto_hide_menu_bar): New functions.
1928 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
1929 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
1930 ns_constrain_all_frames.
1931 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
1932 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
1933
1934 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1935
1936 * nsmenu.m (runDialogAt): Remove argument to timer_check.
1937
1938 2011-03-27 Glenn Morris <rgm@gnu.org>
1939
1940 * syssignal.h: Replace RETSIGTYPE with void.
1941 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
1942 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
1943 Replace SIGTYPE with void everywhere.
1944 * s/usg5-4-common.h (SIGTYPE): Remove definition.
1945 * s/template.h (SIGTYPE): Remove commented out definition.
1946
1947 2011-03-26 Eli Zaretskii <eliz@gnu.org>
1948
1949 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
1950 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
1951
1952 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
1953
1954 * w32.c (read_unc_volume): Use parameter `henum', instead of
1955 global variable `wget_enum_handle'.
1956
1957 * keymap.c (describe_vector): Remove parameters `indices' and
1958 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
1959 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
1960
1961 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
1962
1963 * keyboard.c (timer_check): Remove parameter `do_it_now',
1964 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
1965 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
1966 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
1967
1968 * keyboard.c (read_char):
1969 * w32menu.c (w32_menu_display_help):
1970 * xmenu.c (show_help_event, menu_help_callback):
1971 Adjust calls to `show_help_echo'.
1972
1973 * gtkutil.c (xg_maybe_add_timer):
1974 * keyboard.c (readable_events):
1975 * process.c (wait_reading_process_output):
1976 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
1977
1978 * insdel.c (adjust_markers_gap_motion):
1979 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
1980 (gap_left, gap_right): Don't call it.
1981
1982 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
1983
1984 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
1985 incurred during fontification.
1986
1987 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
1988
1989 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
1990 (DEFVAR_PER_BUFFER): Don't pass it.
1991
1992 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
1993 (scrolling_window): Don't pass it.
1994
1995 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
1996
1997 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
1998
1999 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
2000 and `suffix'.
2001 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
2002 of variables specific to SELinux and computation of `encoded_absname'.
2003
2004 * image.c (XPutPixel): Remove unused variable `height'.
2005
2006 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
2007
2008 * unexw32.c (get_section_info): Remove unused variable `section'.
2009
2010 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
2011 (system_process_attributes): Remove unused variable `sess'.
2012 (sys_read): Remove unused variable `err'.
2013
2014 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
2015 (w32_wnd_proc): Remove unused variable `isdead'.
2016 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
2017 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
2018 (x_create_tip_frame): Remove unused variable `tem'.
2019
2020 * w32inevt.c (w32_console_read_socket):
2021 Remove unused variable `no_events'.
2022
2023 * w32term.c (x_draw_composite_glyph_string_foreground):
2024 Remove unused variable `width'.
2025
2026 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
2027
2028 * w32term.c (x_set_glyph_string_clipping):
2029 Don't pass uninitialized region to CombineRgn.
2030
2031 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
2032
2033 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
2034 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
2035 (Fx_close_connection): Remove unused variable `i'.
2036
2037 * w32font.c (w32font_draw): Return number of glyphs.
2038 (w32font_open_internal): Remove unused variable `i'.
2039 (w32font_driver): Add missing initializer.
2040
2041 * w32menu.c (utf8to16): Remove unused variable `utf16'.
2042 (fill_in_menu): Remove unused variable `items_added'.
2043
2044 * w32term.c (last_mouse_press_frame): Remove static global variable.
2045 (w32_clip_to_row): Remove unused variable `f'.
2046 (x_delete_terminal): Remove unused variable `i'.
2047
2048 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
2049 (NOTHING): Remove unused static global variable.
2050 (uniscribe_check_otf): Remove unused variable `table'.
2051 (uniscribe_font_driver): Add missing initializers.
2052
2053 2011-03-23 Julien Danjou <julien@danjou.info>
2054
2055 * term.c (Fsuspend_tty, Fresume_tty):
2056 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
2057 * window.c (temp_output_buffer_show):
2058 * insdel.c (signal_before_change):
2059 * frame.c (Fhandle_switch_frame):
2060 * fileio.c (Fdo_auto_save):
2061 * emacs.c (Fkill_emacs):
2062 * editfns.c (save_excursion_restore):
2063 * cmds.c (internal_self_insert):
2064 * callint.c (Fcall_interactively):
2065 * buffer.c (Fkill_all_local_variables):
2066 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
2067 Use Frun_hooks.
2068 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
2069 unconditionnaly since it does the check itself.
2070
2071 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
2072
2073 Fix more problems found by GCC 4.5.2's static checks.
2074
2075 * coding.c (encode_coding_raw_text): Avoid unnecessary test
2076 the first time through the loop, since we know p0 < p1 then.
2077 This also avoids a gcc -Wstrict-overflow warning.
2078
2079 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
2080 leading to a memory leak, possible in functions like
2081 load_charset_map_from_file that can allocate an unbounded number
2082 of objects (Bug#8318).
2083
2084 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
2085 that could (at least in theory) be that large.
2086
2087 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
2088 This is less likely to overflow, and avoids undefined behavior if
2089 overflow does occur. All callers changed. Use strtoul to scan
2090 for the unsigned long integer.
2091 (pint2hrstr): Simplify and tune code slightly.
2092 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
2093
2094 * scroll.c (do_scrolling): Work around GCC bug 48228.
2095 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
2096
2097 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
2098 This also avoids a warning with gcc -Wstrict-overflow.
2099 (validate_x_resource_name): Simplify count usage.
2100 This also avoids a warning with gcc -Wstrict-overflow.
2101
2102 * fileio.c (Fcopy_file): Report error if fchown or fchmod
2103 fail (Bug#8306).
2104
2105 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
2106
2107 * process.c (Fmake_network_process): Use socklen_t, not int,
2108 where POSIX says socklen_t is required in portable programs.
2109 This fixes a porting bug on hosts like 64-bit HP-UX, where
2110 socklen_t is wider than int (Bug#8277).
2111 (Fmake_network_process, server_accept_connection):
2112 (wait_reading_process_output, read_process_output):
2113 Likewise.
2114
2115 * process.c: Rename or move locals to avoid shadowing.
2116 (list_processes_1, Fmake_network_process):
2117 (read_process_output_error_handler, exec_sentinel_error_handler):
2118 Rename or move locals.
2119 (Fmake_network_process): Define label "retry_connect" only if needed.
2120 (Fnetwork_interface_info): Fix pointer signedness.
2121 (process_send_signal): Add cast to avoid pointer signedness problem.
2122 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
2123 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
2124
2125 Make tparam.h and terminfo.c consistent.
2126 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
2127 Include tparam.h instead, since it declares them.
2128 * cm.h (PC): Remove extern decl; tparam.h now does this.
2129 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
2130 * terminfo.c: Include tparam.h, to check interfaces.
2131 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
2132 (tparam): Adjust signature to match interface in tparam.h;
2133 this removes some undefined behavior. Check that outstring and len
2134 are zero, which they always are with Emacs.
2135 * tparam.h (PC, BC, UP): New extern decls.
2136
2137 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
2138 (xftfont_open): Rename locals to avoid shadowing.
2139
2140 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
2141 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
2142 (OTF_TAG_SYM): Omit macro if not needed.
2143 (ftfont_list): Remove unused local.
2144 (get_adstyle_property, ftfont_pattern_entity):
2145 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
2146 Rename locals to avoid shadowing.
2147
2148 * xfont.c (xfont_list_family): Mark var as initialized.
2149
2150 * xml.c (make_dom): Now static.
2151
2152 * composite.c (composition_compute_stop_pos): Rename local to
2153 avoid shadowing.
2154 (composition_reseat_it): Remove unused locals.
2155 (find_automatic_composition, composition_adjust_point): Likewise.
2156 (composition_update_it): Mark var as initialized.
2157 (find_automatic_composition): Mark vars as initialized,
2158 with a FIXME (Bug#8290).
2159
2160 character.h: Rename locals to avoid shadowing.
2161 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
2162 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
2163 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
2164 (BUF_DEC_POS): Be more systematic about renaming local temporaries
2165 to avoid shadowing.
2166
2167 * textprop.c (property_change_between_p): Remove; unused.
2168
2169 * intervals.c (interval_start_pos): Now static.
2170
2171 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
2172
2173 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
2174 Rename locals to avoid shadowing.
2175
2176 * sound.c (wav_play, au_play, Fplay_sound_internal):
2177 Fix pointer signedness.
2178 (alsa_choose_format): Remove unused local var.
2179 (wav_play): Initialize a variable to 0, to prevent undefined
2180 behavior (Bug#8278).
2181
2182 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
2183
2184 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
2185
2186 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
2187 clobbering (Bug#8298).
2188 * sysdep.c (sys_subshell): Likewise.
2189 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
2190
2191 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
2192 This should get cleaned up, so that child_setup has the
2193 same signature on all platforms.
2194
2195 * callproc.c (call_process_cleanup): Now static.
2196 (relocate_fd): Rename locals to avoid shadowing.
2197
2198 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
2199
2200 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
2201 not to be necessary, and produces flickering.
2202
2203 2011-03-20 Glenn Morris <rgm@gnu.org>
2204
2205 * config.in: Remove file.
2206
2207 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
2208
2209 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
2210 are now in src/globals.h.
2211 (syms_of_minibuf): Remove spurious & from previous change.
2212
2213 2011-03-20 Leo <sdl.web@gmail.com>
2214
2215 * minibuf.c (completing-read-function): New variable.
2216 (completing-read-default): Rename from completing-read.
2217 (completing-read): Call completing-read-function.
2218
2219 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
2220
2221 * xfaces.c (Fx_load_color_file):
2222 Read color file from absolute filename (bug#8250).
2223
2224 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
2225
2226 * makefile.w32-in: Update dependencies.
2227
2228 2011-03-17 Eli Zaretskii <eliz@gnu.org>
2229
2230 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
2231
2232 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
2233
2234 Fix more problems found by GCC 4.5.2's static checks.
2235
2236 * process.c (make_serial_process_unwind, send_process_trap):
2237 (sigchld_handler): Now static.
2238
2239 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
2240 That way, the code declares only the vars that it needs.
2241 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
2242 * s/cygwin.h (PTY_ITERATION): Likewise.
2243 * s/darwin.h (PTY_ITERATION): Likewise.
2244 * s/gnu-linux.h (PTY_ITERATION): Likewise.
2245
2246 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
2247 * process.c (allocate_pty): Don't declare stb unless it's needed.
2248
2249 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
2250 (CONSTANTLIM): Remove; unused.
2251 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
2252 Define only if needed.
2253
2254 * unexelf.c (unexec): Name an expression,
2255 to avoid gcc -Wbad-function-cast warning.
2256 Use a different way to cause a compilation error if anyone uses
2257 n rather than nn, a way that does not involve shadowing.
2258 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
2259
2260 * deps.mk (unexalpha.o): Remove; unused.
2261
2262 New file unexec.h, the (simple) interface for unexec (Bug#8267).
2263 * unexec.h: New file.
2264 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
2265 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
2266 Depend on unexec.h.
2267 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
2268 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
2269 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
2270 Change as necessary to match prototype in unexec.h.
2271
2272 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
2273 shadowing.
2274 (back_comment, skip_chars): Mark vars as initialized.
2275
2276 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
2277 Rename locals to avoid shadowing.
2278
2279 * lread.c (read1): Rewrite so as not to use empty "else".
2280 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
2281
2282 * print.c (Fredirect_debugging_output): Fix pointer signedess.
2283
2284 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
2285 warning when compiling print.c.
2286
2287 * font.c (font_unparse_fcname): Abort in an "impossible" situation
2288 instead of using an uninitialized var.
2289 (font_sort_entities): Mark var as initialized.
2290
2291 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
2292
2293 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
2294 pointers to constants.
2295 (font_parse_fcname): Remove unused vars.
2296 (font_delete_unmatched): Now static.
2297 (font_get_spec): Remove; unused.
2298 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
2299 (font_update_drivers, Ffont_get_glyphs, font_add_log):
2300 Rename or move locals to avoid shadowing.
2301
2302 * fns.c (require_nesting_list, require_unwind): Now static.
2303 (Ffillarray): Rename locals to avoid shadowing.
2304
2305 * floatfns.c (domain_error2): Define only if needed.
2306 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
2307
2308 * alloc.c (mark_backtrace): Move decl from here ...
2309 * lisp.h: ... to here, so that it can be checked.
2310
2311 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
2312 (Fdefvar): Rewrite so as not to use empty "else".
2313 (lisp_indirect_variable): Name an expression,
2314 to avoid gcc -Wbad-function-cast warning.
2315 (Fdefvar): Rename locals to avoid shadowing.
2316
2317 * callint.c (quotify_arg, quotify_args): Now static.
2318 (Fcall_interactively): Rename locals to avoid shadowing.
2319 Use const pointer when appropriate.
2320
2321 * lisp.h (get_system_name, get_operating_system_release):
2322 Move decls here, to check interfaces.
2323 * process.c (get_operating_system_release): Move decl to lisp.h.
2324 * xrdb.c (get_system_name): Likewise.
2325 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
2326 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
2327 some of which prompt warnings from gcc -Wbad-function-cast.
2328 (Fformat_time_string, Fencode_time, Finsert_char):
2329 (Ftranslate_region_internal, Fformat):
2330 Rename or remove local vars to avoid shadowing.
2331 (Ftranslate_region_internal): Mark var as initialized.
2332
2333 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
2334 avoid shadowing.
2335
2336 * lisp.h (eassert): Check that the argument compiles, even if
2337 ENABLE_CHECKING is not defined.
2338
2339 * data.c (Findirect_variable): Name an expression, to avoid
2340 gcc -Wbad-function-cast warning.
2341 (default_value, arithcompare, arith_driver, arith_error): Now static.
2342 (store_symval_forwarding): Rename local to avoid shadowing.
2343 (Fmake_variable_buffer_local, Fmake_local_variable):
2344 Mark variables as initialized.
2345 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
2346
2347 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
2348 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
2349 Rename locals to avoid shadowing.
2350 (mark_stack): Move local variables into the #ifdef region where
2351 they're used.
2352 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
2353 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
2354 needed otherwise.
2355 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
2356 (GC_STRING_CHARS): Remove; not used.
2357 (Fmemory_limit): Cast sbrk's returned value to char *.
2358
2359 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
2360 avoids undefined behavior in theory.
2361
2362 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
2363
2364 Use functions, not macros, for up- and down-casing (Bug#8254).
2365 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2366 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
2367 to use the following functions instead of these macros.
2368 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
2369 EMACS_INT, since callers assume the returned value fits in int.
2370 (upcase1): Likewise, for UPCASE_TABLE.
2371 (uppercasep, lowercasep, upcase): New static inline functions.
2372 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
2373 the race-condition problem in the old DOWNCASE.
2374
2375 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
2376 Rename locals to avoid shadowing.
2377 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
2378 (regex_compile, re_search_2, re_match_2_internal):
2379 Remove unused local vars.
2380 (FREE_VAR): Rewrite so as not to use empty "else",
2381 which gcc can warn about.
2382 (regex_compile, re_match_2_internal): Mark locals as initialized.
2383 (RETALLOC_IF): Define only if needed.
2384 (WORDCHAR_P): Likewise. This one is never needed, but is used
2385 only in a comment talking about a compiler bug, so put inside
2386 the #if 0 of that comment.
2387 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
2388 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
2389 Remove; unused.
2390
2391 * search.c (boyer_moore): Rename locals to avoid shadowing.
2392 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
2393 (PREV_CHAR_BOUNDARY): Likewise.
2394
2395 * search.c (simple_search): Remove unused var.
2396
2397 * dired.c (compile_pattern): Move decl from here ...
2398 * lisp.h: ... to here, so that it can be checked.
2399 (struct re_registers): New forward decl.
2400
2401 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
2402
2403 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
2404 All uses changed.
2405 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
2406 Rename locals to avoid shadowing.
2407 (Fvertical_motion): Mark locals as initialized.
2408
2409 * casefiddle.c (casify_object, casify_region): Now static.
2410 (casify_region): Mark local as initialized.
2411
2412 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
2413
2414 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
2415 New macros, so that the caller can use some names other than
2416 gcpro1, gcpro2, etc.
2417 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
2418 of the new macros.
2419 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
2420 argument, for consistency with GCPRO2_VAR, etc: it is now the
2421 prefix of the variable, not the variable itself. All uses
2422 changed.
2423 * dired.c (directory_files_internal, file_name_completion):
2424 Rename locals to avoid shadowing.
2425
2426 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
2427 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
2428 dired.c's scmp function, had undefined behavior.
2429 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2430 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
2431 * buffer.h: ... to here, because these macros use current_buffer,
2432 and the new implementation with inline functions needs to have
2433 current_buffer in scope now, rather than later when the macros
2434 are used.
2435 (downcase, upcase1): New static inline functions.
2436 (DOWNCASE, UPCASE1): Reimplement using these functions.
2437 This avoids undefined behavior in expressions like
2438 DOWNCASE (x) == DOWNCASE (y), which previously suffered
2439 from race conditions in accessing the global variables
2440 case_temp1 and case_temp2.
2441 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
2442 * lisp.h (case_temp1, case_temp2): Remove their decls.
2443 * character.h (ASCII_CHAR_P): Move from here ...
2444 * lisp.h: ... to here, so that the inline functions mentioned
2445 above can use them.
2446
2447 * dired.c (directory_files_internal_unwind): Now static.
2448
2449 * fileio.c (file_name_as_directory, directory_file_name):
2450 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
2451 Now static.
2452 (file_name_as_directory): Use const pointers when appropriate.
2453 (Fexpand_file_name): Likewise. In particular, newdir might
2454 point at constant storage, so make it a const pointer.
2455 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
2456 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
2457 signedness issues.
2458 (Fset_file_times, Finsert_file_contents, auto_save_error):
2459 Rename locals to avoid shadowing.
2460
2461 * minibuf.c (choose_minibuf_frame_1): Now static.
2462 (Ftry_completion, Fall_completions): Rename or remove locals
2463 to avoid shadowing.
2464
2465 * marker.c (bytepos_to_charpos): Remove; unused.
2466
2467 * lisp.h (verify_bytepos, count_markers): New decls,
2468 so that gcc does not warn that these functions aren't declared.
2469
2470 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
2471 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
2472 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
2473 (copy_text): Remove unused local var.
2474
2475 * filelock.c (within_one_second): Now static.
2476 (lock_file_1): Rename local to avoid shadowing.
2477
2478 * buffer.c (fix_overlays_before): Mark locals as initialized.
2479 (fix_start_end_in_overlays): Likewise. This function should be
2480 simplified by using pointers-to-pointers, but that's a different
2481 matter.
2482 (switch_to_buffer_1): Now static.
2483 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
2484 (report_overlay_modification): Rename locals to avoid shadowing.
2485
2486 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
2487 Fix pointer signedness issue.
2488 (sys_subshell): Mark local as volatile if checking for lint,
2489 to suppress a gcc -Wclobbered warning that does not seem to be right.
2490 (MAXPATHLEN): Define only if needed.
2491
2492 * process.c (serial_open, serial_configure): Move decls from here ...
2493 * systty.h: ... to here, so that they can be checked.
2494
2495 * fns.c (get_random, seed_random): Move extern decls from here ...
2496 * lisp.h: ... to here, so that they can be checked.
2497
2498 * sysdep.c (reset_io): Now static.
2499 (wait_for_termination_signal): Remove; unused.
2500
2501 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
2502 (copy_keymap_item, append_key, push_text_char_description):
2503 Now static.
2504 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
2505 (DENSE_TABLE_SIZE): Remove; unused.
2506 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
2507 (describe_map_tree):
2508 Rename locals to avoid shadowing.
2509
2510 * keyboard.c: Declare functions static if they are not used elsewhere.
2511 (echo_char, echo_dash, cmd_error, top_level_2):
2512 (poll_for_input, handle_async_input): Now static.
2513 (read_char, kbd_buffer_get_event, make_lispy_position):
2514 (make_lispy_event, make_lispy_movement, apply_modifiers):
2515 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
2516 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
2517 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
2518 (read_key_sequence, read_char): Mark locals as initialized.
2519 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2520
2521 * keyboard.h (make_ctrl_char): New decl.
2522 (mark_kboards): Move decl here ...
2523 * alloc.c (mark_kboards): ... from here.
2524
2525 * lisp.h (force_auto_save_soon): New decl.
2526
2527 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
2528 (DEFINE_DUMMY_FUNCTION): New macro.
2529 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
2530 Use it.
2531 (main): Add casts to avoid warnings
2532 if GCC considers string literals to be constants.
2533
2534 * lisp.h (fatal_error_signal): Add decl, since it's exported.
2535
2536 * dbusbind.c: Pointer signedness fixes.
2537 (xd_signature, xd_append_arg, xd_initialize):
2538 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2539 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2540 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
2541 (Fdbus_register_signal): Use SSDATA when the context wants char *.
2542
2543 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
2544 if GCC considers string literals to be constants.
2545 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
2546
2547 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
2548
2549 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
2550 (print_preprocess, print_object): New macro to fix last change.
2551
2552 * print.c (print_preprocess): Don't forget font objects.
2553
2554 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
2555
2556 * emacs.c (USAGE3): Doc fixes.
2557
2558 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
2559
2560 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
2561 structure.
2562
2563 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
2564
2565 * lisp.h (VWindow_system, Qfile_name_history):
2566 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
2567 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
2568 (w32_system_caret_x, w32_system_caret_y): Declare extern.
2569
2570 * w32select.c: Don't #include "keyboard.h".
2571 (run_protected): Add extern declaration for waiting_for_input.
2572
2573 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
2574 * w32console.c (detect_input_pending, read_input_pending)
2575 (encode_terminal_code):
2576 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
2577 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
2578 (w32_system_caret_y, Qfile_name_history):
2579 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
2580 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
2581 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
2582 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
2583 * w32proc.c (Qlocal, report_file_error):
2584 * w32term.c (Vwindow_system, updating_frame):
2585 * w32uniscribe.c (initialized, uniscribe_font_driver):
2586 Remove unneeded extern declarations.
2587
2588 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
2589
2590 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2591
2592 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
2593
2594 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
2595 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
2596 These macros can no longer be used for assignment.
2597
2598 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2599 Assign struct members directly, instead of using BUF_BEGV etc.
2600 (record_buffer_markers, fetch_buffer_markers): New functions for
2601 recording and fetching special buffer markers.
2602 (set_buffer_internal_1, set_buffer_temp): Use them.
2603
2604 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
2605
2606 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
2607
2608 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
2609 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
2610
2611 * xdisp.c (hscroll_window_tree):
2612 (reconsider_clip_changes): Use PT instead of BUF_PT.
2613
2614 2011-03-13 Eli Zaretskii <eliz@gnu.org>
2615
2616 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
2617 $(EMACS_ROOT)/lib/intprops.h.
2618
2619 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
2620
2621 Fix more problems found by GCC 4.5.2's static checks.
2622
2623 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
2624 to unsigned char * to avoid compiler diagnostic.
2625 (xg_free_frame_widgets): Make it clear that a local variable is
2626 needed only if USE_GTK_TOOLTIP.
2627 (gdk_window_get_screen): Make it clear that this macro is needed
2628 only if USE_GTK_TOOLTIP.
2629 (int_gtk_range_get_value): New function, which avoids a diagnostic
2630 from gcc -Wbad-function-cast.
2631 (xg_set_toolkit_scroll_bar_thumb): Use it.
2632 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
2633 diagnostic from gcc -Wbad-function-cast.
2634 (get_utf8_string, xg_get_file_with_chooser):
2635 Rename locals to avoid shadowing.
2636 (create_dialog): Move locals to avoid shadowing.
2637
2638 * xgselect.c (xg_select): Remove unused var.
2639
2640 * image.c (four_corners_best): Mark locals as initialized.
2641 (gif_load): Initialize transparent_p to zero (Bug#8238).
2642 Mark another local as initialized.
2643 (my_png_error, my_error_exit): Mark with NO_RETURN.
2644
2645 * image.c (clear_image_cache): Now static.
2646 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
2647 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
2648 (x_edge_detection): Remove unnecessary cast that
2649 gcc -Wbad-function-cast diagnoses.
2650 (gif_load): Fix pointer signedness.
2651 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
2652 (jpeg_load, gif_load): Rename locals to avoid shadowing.
2653
2654 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
2655
2656 Improve quality of tests for time stamp overflow.
2657 For example, without this patch (encode-time 0 0 0 1 1
2658 1152921504606846976) returns the obviously-bogus value (-948597
2659 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
2660 reports time overflow. See
2661 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
2662 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
2663 * editfns.c: Include limits.h and intprops.h.
2664 (TIME_T_MIN, TIME_T_MAX): New macros.
2665 (time_overflow): Move earlier, to before first use.
2666 (hi_time, lo_time): New functions, for an accurate test for
2667 out-of-range times.
2668 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
2669 (Fget_internal_run_time): Don't assume time_t fits in int.
2670 (make_time): Use list2 instead of Fcons twice.
2671 (Fdecode_time): More accurate test for out-of-range times.
2672 (check_tm_member): New function.
2673 (Fencode_time): Use it, to test for out-of-range times.
2674 (lisp_time_argument): Don't rely on undefined left-shift and
2675 right-shift behavior when checking for time stamp overflow.
2676
2677 * editfns.c (time_overflow): New function, refactoring common code.
2678 (Fformat_time_string, Fdecode_time, Fencode_time):
2679 (Fcurrent_time_string): Use it.
2680
2681 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
2682 * dired.c (make_time): Move to ...
2683 * editfns.c (make_time): ... here.
2684 * systime.h: Note the move.
2685
2686 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2687
2688 * fringe.c (update_window_fringes): Remove unused variables.
2689
2690 * unexmacosx.c (copy_data_segment): Also copy __got section.
2691 (Bug#8223)
2692
2693 2011-03-12 Eli Zaretskii <eliz@gnu.org>
2694
2695 * termcap.c [MSDOS]: Include "msdos.h".
2696 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
2697 Constify `char *' arguments and their references according to
2698 prototypes in tparam.h.
2699
2700 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
2701
2702 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
2703 Adapt all references accordingly.
2704
2705 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
2706
2707 2011-03-11 Tom Tromey <tromey@redhat.com>
2708
2709 * buffer.c (syms_of_buffer): Remove obsolete comment.
2710
2711 2011-03-11 Eli Zaretskii <eliz@gnu.org>
2712
2713 * termhooks.h (encode_terminal_code): Declare prototype.
2714
2715 * msdos.c (encode_terminal_code): Don't declare prototype.
2716
2717 * term.c (encode_terminal_code): Now external again, used by
2718 w32console.c and msdos.c.
2719
2720 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
2721 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
2722
2723 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
2724
2725 Fix some minor problems found by GCC 4.5.2's static checks.
2726
2727 * fringe.c (update_window_fringes): Mark locals as initialized
2728 (Bug#8227).
2729 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
2730
2731 * alloc.c (mark_fringe_data): Move decl from here ...
2732 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
2733 to check its interface.
2734 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
2735
2736 * fontset.c (free_realized_fontset): Now static.
2737 (Fset_fontset_font): Rename local to avoid shadowing.
2738 (fontset_font): Mark local as initialized.
2739 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
2740
2741 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
2742
2743 * xselect.c (x_disown_buffer_selections): Remove; not used.
2744 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
2745 (x_own_selection, Fx_disown_selection_internal): Rename locals
2746 to avoid shadowing.
2747 (x_handle_dnd_message): Remove local to avoid shadowing.
2748
2749 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
2750 so that the caller can use some name other than gcpro1.
2751 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
2752 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2753 (Fx_backspace_delete_keys_p):
2754 Use them to avoid shadowing, and rename vars to avoid shadowing.
2755 (x_decode_color, x_set_name, x_window): Now static.
2756 (Fx_create_frame): Add braces to silence GCC warning.
2757 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
2758 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
2759 Remove unused locals.
2760 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2761 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
2762 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
2763 macros.
2764
2765 * xterm.h (x_mouse_leave): New decl.
2766
2767 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
2768 Remove unused functions.
2769 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
2770 (x_calc_absolute_position): Now static.
2771 (XTread_socket): Don't define label "out" unless it's used.
2772 Don't declare local "event" unless it's used.
2773 (x_iconify_frame, x_free_frame_resources): Don't declare locals
2774 unless they are used.
2775 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
2776 (x_fatal_error_signal): Remove; not used.
2777 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
2778 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
2779 (x_error_catcher, x_connection_closed, x_error_handler):
2780 (x_error_quitter, xembed_send_message, x_iconify_frame):
2781 (my_log_handler): Rename locals to avoid shadowing.
2782 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2783 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
2784
2785 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
2786 Rename or move locals to avoid shadowing.
2787 (tty_defined_color, merge_face_heights): Now static.
2788 (free_realized_faces_for_fontset): Remove; not used.
2789 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
2790 does not deduce is never used uninitialized.
2791 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
2792 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
2793
2794 * terminal.c (store_terminal_param): Now static.
2795
2796 * xmenu.c (menu_highlight_callback): Now static.
2797 (set_frame_menubar): Remove unused local.
2798 (xmenu_show): Rename parameter to avoid shadowing.
2799 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
2800 since they might point to immutable storage.
2801 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
2802 since it's unused otherwise.
2803
2804 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
2805 Add a FIXME, since the code still doesn't look right. (Bug#8215)
2806 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
2807 avoids a gcc -Wuninitialized diagnostic.
2808 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
2809 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
2810 does not deduce are never used uninitialized.
2811
2812 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
2813
2814 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
2815 * window.c (window_loop, size_window):
2816 (run_window_configuration_change_hook, enlarge_window): Likewise.
2817
2818 * window.c (display_buffer): Now static.
2819 (size_window): Mark variables that gcc -Wuninitialized
2820 does not deduce are never used uninitialized.
2821 * window.h (check_all_windows): New decl, to forestall
2822 gcc -Wmissing-prototypes diagnostic.
2823 * dispextern.h (bidi_dump_cached_states): Likewise.
2824
2825 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
2826 shadowing.
2827 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
2828 Include <limits.h>.
2829 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
2830 and to avoid gcc -Wuninitialized warning.
2831 (load_charset_map): Mark variables that gcc -Wuninitialized
2832 does not deduce are never used uninitialized.
2833 (load_charset): Abort instead of using uninitialized var (Bug#8229).
2834
2835 * coding.c (coding_set_source, coding_set_destination):
2836 Use "else { /* comment */ }" rather than "else /* comment */;"
2837 for clarity, and to avoid gcc -Wempty-body warning.
2838 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
2839 a block, when the outer 'i' will do.
2840 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
2841 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
2842 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
2843 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
2844 (Fdecode_sjis_char, Fdefine_coding_system_internal):
2845 Rename locals to avoid shadowing.
2846 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
2847 * coding.c (emacs_mule_char, encode_invocation_designation):
2848 Now static, since they're not used elsewhere.
2849 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
2850 (decode_coding_object, encode_coding_object, detect_coding_system):
2851 (decode_coding_emacs_mule): Mark variables that gcc
2852 -Wuninitialized does not deduce are never used uninitialized.
2853 (detect_coding_iso_2022): Initialize a local variable that might
2854 be used uninitialized. Leave a FIXME because it's not clear that
2855 this initialization is needed. (Bug#8211)
2856 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
2857 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
2858 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
2859 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
2860 Remove unused macros.
2861
2862 * category.c (hash_get_category_set): Remove unused local var.
2863 (copy_category_table): Now static, since it's not used elsewhere.
2864 * character.c (string_count_byte8): Likewise.
2865
2866 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
2867 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
2868
2869 * chartab.c (copy_sub_char_table): Now static, since it's not used
2870 elsewhere.
2871 (sub_char_table_ref_and_range, char_table_ref_and_range):
2872 Rename locals to avoid shadowing.
2873 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
2874
2875 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
2876 (BIDI_BOB): Remove unused macro.
2877
2878 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
2879 deduce are never used uninitialized.
2880 * term.c (encode_terminal_code): Likewise.
2881
2882 * term.c (encode_terminal_code): Now static. Remove unused local.
2883
2884 * tparam.h: New file.
2885 * term.c, tparam.h: Include it.
2886 * deps.mk (term.o, tparam.o): Depend on tparam.h.
2887 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
2888 Move these decls to tparam.h, and make them agree with what
2889 is actually in tparam.c. The previous trick of using incompatible
2890 decls in different modules does not conform to the C standard.
2891 All callers of tparam changed to use tparam's actual API.
2892 * tparam.c (tparam1, tparam, tgoto):
2893 Use const pointers where appropriate.
2894
2895 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
2896 * cm.h (struct cm): Likewise.
2897 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
2898 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
2899 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
2900 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
2901 (turn_on_face, init_tty): Likewise.
2902 * termchar.h (struct tty_display_info): Likewise.
2903
2904 * term.c (term_mouse_position): Rename local to avoid shadowing.
2905
2906 * alloc.c (mark_ttys): Move decl from here ...
2907 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
2908
2909 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
2910
2911 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
2912
2913 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
2914
2915 * search.c (compile_pattern_1): Remove argument regp, unused since
2916 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
2917 (compile_pattern): Don't pass it.
2918
2919 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
2920
2921 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
2922 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
2923 for ! HAVE_GTK3.
2924 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
2925
2926 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
2927
2928 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
2929 gdk_window_get_screen, gdk_window_get_geometry,
2930 gdk_x11_window_lookup_for_display and GDK_KEY_g.
2931 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
2932 (xg_get_pixbuf_from_pixmap): New function.
2933 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
2934 to Pixmap, take frame as parameter, remove GdkColormap parameter.
2935 Call xg_get_pixbuf_from_pixmap instead of
2936 gdk_pixbuf_get_from_drawable.
2937 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
2938 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
2939 (xg_check_special_colors): Use GtkStyleContext and its functions
2940 for HAVE_GTK3.
2941 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
2942 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
2943 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
2944 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
2945 Call gtk_widget_get_preferred_size.
2946 (xg_frame_resized): gdk_window_get_geometry only takes 5
2947 parameters.
2948 (xg_win_to_widget, xg_event_is_for_menubar):
2949 Call gdk_x11_window_lookup_for_display.
2950 (xg_set_widget_bg): New function.
2951 (delete_cb): New function.
2952 (xg_create_frame_widgets): Connect delete-event to delete_cb.
2953 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
2954 (xg_set_background_color): Call xg_set_widget_bg.
2955 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
2956 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
2957 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
2958 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
2959 if ! HAVE_GTK3.
2960 (update_frame_tool_bar): Call gtk_widget_hide.
2961 (xg_initialize): Use GDK_KEY_g.
2962
2963 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
2964 if ! HAVE_GTK3
2965 (x_session_initialize): Call gdk_x11_set_sm_client_id.
2966
2967 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
2968 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
2969 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
2970
2971 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
2972
2973 * w32xfns.c (select_palette): Check success of RealizePalette against
2974 GDI_ERROR, not zero.
2975
2976 See ChangeLog.11 for earlier changes.
2977
2978 ;; Local Variables:
2979 ;; coding: utf-8
2980 ;; End:
2981
2982 Copyright (C) 2011 Free Software Foundation, Inc.
2983
2984 This file is part of GNU Emacs.
2985
2986 GNU Emacs is free software: you can redistribute it and/or modify
2987 it under the terms of the GNU General Public License as published by
2988 the Free Software Foundation, either version 3 of the License, or
2989 (at your option) any later version.
2990
2991 GNU Emacs is distributed in the hope that it will be useful,
2992 but WITHOUT ANY WARRANTY; without even the implied warranty of
2993 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
2994 GNU General Public License for more details.
2995
2996 You should have received a copy of the GNU General Public License
2997 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.