1 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3 Overflow, signedness and related fixes for images.
5 * dispextern.h (struct it.stack[0].u.image.image_id)
6 (struct_it.image_id, struct image.id, struct image_cache.size)
7 (struct image_cache.used, struct image_cache.ref_count):
8 * gtkutil.c (update_frame_tool_bar):
9 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
10 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
11 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
12 * nsmenu.m (update_frame_tool_bar):
13 * xdisp.c (calc_pixel_width_or_height):
14 * xfns.c (image_cache_refcount):
15 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
16 on typical 64-bit hosts.
18 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
19 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
20 Omit unnecessary casts to int.
21 (parse_image_spec): Check that integers fall into 'int' range
22 when the callers expect that.
23 (image_ascent): Redo ascent calculation to avoid int overflow.
24 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
25 (lookup_image): Remove unnecessary tests.
26 (xbm_image_p): Locals are now of int, not EMACS_INT,
27 since parse_image_check makes sure they fit into int.
28 (png_load, gif_load, svg_load_image):
29 Prefer int to unsigned where either will do.
30 (tiff_handler): New function, combining the cores of the
31 old tiff_error_handler and tiff_warning_handler. This
32 function is rewritten to use vsnprintf and thereby avoid
33 stack buffer overflows. It uses only the features of vsnprintf
34 that are common to both POSIX and native Microsoft.
35 (tiff_error_handler, tiff_warning_handler): Use it.
36 (tiff_load, gif_load, imagemagick_load_image):
37 Don't assume :index value fits in 'int'.
38 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
39 (imagemagick_load_image): Check that crop parameters fit into
40 the integer types that MagickCropImage accepts. Don't assume
41 Vimagemagick_render_type has a nonnegative value. Don't assume
42 size_t fits in 'long'.
43 (gs_load): Use printmax_t to print the widest integers possible.
44 Check for integer overflow when computing image height and width.
46 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
48 Integer signedness and overflow and related fixes. (Bug#9079)
50 * bidi.c: Integer size and overflow fixes.
51 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
52 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
53 (bidi_cache_find_level_change, bidi_cache_ensure_space)
54 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
55 (bidi_find_other_level_edge):
56 Use ptrdiff_t instead of EMACS_INT where either will do.
57 This works better on 32-bit hosts configured --with-wide-int.
58 (bidi_cache_ensure_space): Check for size-calculation overflow.
59 Use % rather than repeated addition, for better worst-case speed.
60 Don't set bidi_cache_size until after xrealloc returns, because it
62 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
63 (bidi_cache_ensure_space): Also check that the bidi cache size
64 does not exceed that of the largest Lisp string or buffer. See Eli
65 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
67 * alloc.c (__malloc_size_t): Remove.
68 All uses replaced by size_t. See Andreas Schwab's note
69 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
71 * image.c: Improve checking for integer overflow.
72 (check_image_size): Assume that f is nonnull, since
73 it is always nonnull in practice. This is one less thing to
74 worry about when checking for integer overflow later.
75 (x_check_image_size): New function, which checks for integer
76 overflow issues inside X.
77 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
78 This removes the need for a memory_full check.
79 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
80 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
81 (xbm_read_bitmap_data): Change locals back to 'int', since
82 their values must fit in 'int'.
83 (xpm_load_image, png_load, tiff_load):
84 Invoke x_create_x_image_and_pixmap earlier,
85 to avoid much needless work if the image is too large.
86 (tiff_load): Treat overly large images as if
87 x_create_x_image_and_pixmap failed, not as malloc failures.
88 (gs_load): Use x_check_image_size.
90 * gtkutil.c: Omit integer casts.
91 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
92 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
94 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
96 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
97 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
98 would wrongly return t on a 64-bit host.
100 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
101 The plain *_OVERFLOW macros run afoul of GCC bug 49705
102 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
103 and therefore cause GCC to emit a bogus diagnostic in some cases.
105 * image.c: Integer signedness and overflow and related fixes.
106 This is not an exhaustive set of fixes, but it's time to
107 record what I've got.
108 (lookup_pixel_color, check_image_size): Remove redundant decls.
109 (check_image_size): Don't assume that arbitrary EMACS_INT values
110 fit in 'int', or that arbitrary 'double' values fit in 'int'.
111 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
112 (tiff_load, imagemagick_load_image):
113 Check for overflow in size calculations.
114 (x_create_x_image_and_pixmap): Remove unnecessary test for
115 xmalloc returning NULL; that can't happen.
116 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
117 (xpm_color_bucket): Use better integer hashing function.
118 (xpm_cache_color): Don't possibly over-allocate memory.
119 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
121 Use ptrdiff_t, not int or size_t, to record sizes.
122 (png_load): Don't assume values greater than 2**31 fit in 'int'.
123 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
124 either works, as we prefer signed integers.
125 (tiff_read_from_memory, tiff_write_from_memory):
126 Return tsize_t, not size_t, since that's what the TIFF API wants.
127 (tiff_read_from_memory): Don't fail simply because the read would
128 go past EOF; instead, return a short read.
129 (tiff_load): Omit no-longer-needed casts.
130 (Fimagemagick_types): Don't assume size fits into 'int'.
132 Improve hashing quality when configured --with-wide-int.
133 * fns.c (hash_string): New function, taken from sxhash_string.
134 Do not discard information about ASCII character case; this
135 discarding is no longer needed.
136 (sxhash-string): Use it. Change sig to match it. Caller changed.
137 * lisp.h: Declare it.
138 * lread.c (hash_string): Remove, since we now use fns.c's version.
139 The fns.c version returns a wider integer if --with-wide-int is
140 specified, so this should help the quality of the hashing a bit.
142 * emacs.c: Integer overflow minor fix.
143 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
144 Define only if GNU_LINUX.
145 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
147 * dispnew.c: Integer signedness and overflow fixes.
148 Remove unnecessary forward decls, that were a maintenance hassle.
149 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
151 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
152 (scrolling_window): Use ptrdiff_t, not int, for byte count.
153 (prepare_desired_row, line_draw_cost):
154 Use int, not unsigned, where either works.
155 (save_current_matrix, restore_current_matrix):
156 Use ptrdiff_t, not size_t, where either works.
157 (init_display): Check for overflow more accurately, and without
158 relying on undefined behavior.
160 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
161 Remove, replacing with the new symbols in lisp.h. All uses changed.
162 * fileio.c (make_temp_name):
163 * filelock.c (lock_file_1, lock_file):
164 * xdisp.c (message_dolog):
165 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
166 Use pMd etc. instead.
167 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
168 replacing the pWIDE etc. symbols removed from editfns.c.
170 * keyboard.h (num_input_events): Now uintmax_t.
171 This is (very slightly) less likely to mess up due to wraparound.
174 * buffer.c: Integer signedness fixes.
175 (alloc_buffer_text, enlarge_buffer_text):
176 Use ptrdiff_t rather than size_t when either will do, as we prefer
179 * alloc.c: Integer signedness and overflow fixes.
180 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
181 (__malloc_size_t): Default to size_t, not to int.
182 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
183 (Fgarbage_collect, mark_object_loop_halt, mark_object):
184 Prefer ptrdiff_t to size_t when either would do, as we prefer
186 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
187 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
188 Now const. Initialize with values that are in range even if char
190 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
191 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
192 These functions do the right thing with sizes > 2**32.
193 (check_depth): Now ptrdiff_t, not int.
194 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
195 Adjust to new way of storing sizes. Check for size overflow bugs
197 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
198 slightly wrong anyway, as it missed one instance of
199 XMALLOC_OVERRUN_CHECK_OVERHEAD.
200 (refill_memory_reserve): Omit needless cast to size_t.
201 (mark_object_loop_halt): Mark as externally visible.
203 * xselect.c: Integer signedness and overflow fixes.
204 (Fx_register_dnd_atom, x_handle_dnd_message):
205 Use ptrdiff_t, not size_t, since we prefer signed.
206 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
207 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
208 x_dnd_atoms_size and x_dnd_atoms_length.
210 * doprnt.c: Prefer signed to unsigned when either works.
214 * xdisp.c (vmessage):
215 Use ptrdiff_t, not size_t, when using or implementing doprnt,
216 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
217 prefer signed arithmetic to avoid comparison confusion.
218 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
221 Assume freestanding C89 headers, string.h, stdlib.h.
222 * data.c, doprnt.c, floatfns.c, print.c:
223 Include float.h unconditionally.
224 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
225 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
226 * regex.c: Likewise for stddef.h, string.h.
227 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
228 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
229 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
230 (STDC_HEADERS): Remove obsolete defines.
231 * sysdep.c: Include limits.h unconditionally.
233 Assume support for memcmp, memcpy, memmove, memset.
234 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
235 * regex.c (memcmp, memcpy):
236 Remove; we assume C89 now.
238 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
239 (__malloc_safe_bcopy): Remove; no longer needed.
241 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
242 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
243 well either way, and we prefer signed to unsigned.
245 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
247 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
248 This works around a problem with the previous change to Fcopy_file.
249 Recent glibc declares fchown with __attribute__((warn_unused_result)),
250 and without this change, GCC might complain about discarding
251 fchown's return value.
253 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
255 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
257 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
259 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
261 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
263 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
264 it's used from the C level.
266 * process.c: Use the same condition for POLL_FOR_INPUT in both
267 keyboard.c and process.c (bug#1858).
269 2011-07-09 Lawrence Mitchell <wence@gmx.li>
271 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
272 (Fgnutls_boot): Use it.
274 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
276 * doc.c (Fsubstitute_command_keys): Revert last change.
278 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
280 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
281 quotes the next character, and doesn't affect other longer
282 sequences (bug#8935).
284 * lread.c (syms_of_lread): Clarify that is isn't only
285 `eval-buffer' and `eval-defun' that's affected by
286 `lexical-binding' (bug#8460).
288 2011-07-15 Eli Zaretskii <eliz@gnu.org>
290 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
291 bidi redisplay when a line includes both an image and is
294 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
296 Fix minor problems found by static checking.
297 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
298 (elsz): Now a signed constant, not a size_t var. We prefer signed
299 types to unsigned, to avoid integer comparison confusion. Without
300 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
301 "cannot optimize loop, the loop counter may overflow", a symptom
303 * indent.c (Fvertical_motion): Mark locals as initialized.
304 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
306 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
308 * search.c (Fre_search_backward): Mention `case-fold-search' in
309 all the re_search_* functions (bug#8138).
311 * keyboard.c (Fopen_dribble_file): Document when the file is
314 2011-07-14 Eli Zaretskii <eliz@gnu.org>
316 * bidi.c (bidi_dump_cached_states): Fix format of displaying
319 Support bidi reordering of display and overlay strings.
320 * xdisp.c (compute_display_string_pos)
321 (compute_display_string_end): Accept additional argument STRING.
322 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
323 (reseat_to_string): Initialize bidi_it->string.s and
324 bidi_it->string.schars.
325 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
326 NULL (avoids a crash in bidi_paragraph_init). Initialize
328 (init_iterator): Call bidi_init_it only of a valid
329 buffer position was specified. Initialize paragraph_embedding to
331 (reseat_to_string): Initialize the bidi iterator.
332 (display_string): If we need to ignore text properties of
333 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
334 original value of -1 will not work with bidi.)
335 (compute_display_string_pos): First arg is now struct
336 `text_pos *'; all callers changed. Support display properties on
338 (compute_display_string_end): Support display properties on Lisp
340 (init_iterator, reseat_1, reseat_to_string): Initialize the
341 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
342 when iterating on a string not from display properties).
343 (compute_display_string_pos, compute_display_string_end): Fix
344 calculation of the object to scan. Fixes an error when using
346 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
347 base_level_stop; instead, set base_level_stop to BEGV. Fixes
348 crashes in vertical-motion.
349 (next_element_from_buffer): Improve commentary for when
350 the iterator is before prev_stop.
351 (init_iterator): Initialize bidi_p from the default value of
352 bidi-display-reordering, not from buffer-local value. Use the
353 buffer-local value only if initializing for buffer iteration.
354 (handle_invisible_prop): Support invisible properties on strings
355 that are being bidi-reordered.
356 (set_iterator_to_next): Support bidi reordering of C strings and
358 (next_element_from_string): Support bidi reordering of Lisp
360 (handle_stop_backwards): Support Lisp strings as well.
361 (display_string): Support display of R2L glyph rows. Use
362 IT_STRING_CHARPOS when displaying from a Lisp string.
363 (init_iterator): Don't initialize it->bidi_p for strings
365 (reseat_to_string): Initialize it->bidi_p for strings here.
366 (next_element_from_string, next_element_from_c_string)
367 (next_element_from_buffer): Add xassert's for correspondence
368 between IT's object being iterated and it->bidi_it.string
370 (face_before_or_after_it_pos): Support bidi iteration.
371 (next_element_from_c_string): Handle the case of the first string
372 character that is not the first one in the visual order.
373 (get_visually_first_element): New function, refactored from common
374 parts of next_element_from_buffer, next_element_from_string, and
375 next_element_from_c_string.
376 (tool_bar_lines_needed, redisplay_tool_bar)
377 (display_menu_bar): Force left-to-right direction. Add a FIXME
378 comment for making that be controlled by a user option.
379 (push_it, pop_it): Save and restore the state of the
380 bidi iterator. Save and restore the bidi_p flag.
381 (pop_it): Iterate out of display property for string iteration as
383 (iterate_out_of_display_property): Support iteration over strings.
384 (handle_single_display_spec): Set up it->bidi_it for iteration
385 over a display string, and call bidi_init_it.
386 (handle_single_display_spec, next_overlay_string)
387 (get_overlay_strings_1, push_display_prop): Set up the bidi
388 iterator for displaying display or overlay strings.
389 (forward_to_next_line_start): Don't use the shortcut if
391 (back_to_previous_visible_line_start): If handle_display_prop
392 pushed the iterator stack, restore the internal state of the bidi
393 iterator by calling bidi_pop_it same number of times.
394 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
395 and we are bidi-iterating, don't decrement the iterator position;
396 instead, set the first_elt flag in the bidi iterator, to produce
398 (reseat_1): Remove redundant setting of string_from_display_prop_p.
399 (push_display_prop): xassert that we are iterating a buffer.
400 (push_it, pop_it): Save and restore paragraph_embedding member.
401 (handle_single_display_spec, next_overlay_string)
402 (get_overlay_strings_1, reseat_1, reseat_to_string)
403 (push_display_prop): Set up the `unibyte' member of bidi_it.string
404 correctly. Don't assume unibyte strings are not bidi-reordered.
405 (compute_display_string_pos)
406 (compute_display_string_end): Fix handling the case of C string.
407 (push_it, pop_it): Save and restore from_disp_prop_p.
408 (handle_single_display_spec, push_display_prop): Set the
409 from_disp_prop_p flag.
410 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
411 (pop_it): Call iterate_out_of_display_property only if we are
412 popping after iteration over a string that came from a display
413 property. Fix a typo in popping stretch info. Add an assertion
414 for verifying that the iterator position is in sync with the bidi
416 (handle_single_display_spec, get_overlay_strings_1)
417 (push_display_prop): Fix initialization of paragraph direction for
418 string when that of the parent object is not yet determined.
419 (reseat_1): Call bidi_init_it to resync the bidi
420 iterator with IT's position. (Bug#7616)
421 (find_row_edges): If ROW->start.pos gives position
422 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
423 (handle_stop, back_to_previous_visible_line_start, reseat_1):
424 Reset the from_disp_prop_p flag.
425 (SAVE_IT, RESTORE_IT): New macros.
426 (pos_visible_p, face_before_or_after_it_pos)
427 (back_to_previous_visible_line_start)
428 (move_it_in_display_line_to, move_it_in_display_line)
429 (move_it_to, move_it_vertically_backward, move_it_by_lines)
430 (try_scrolling, redisplay_window, display_line): Use them when
431 saving a temporary copy of the iterator and restoring it back.
432 (back_to_previous_visible_line_start, reseat_1)
433 (init_iterator): Empty the bidi cache "stack".
434 (move_it_in_display_line_to): If iterator ended up at
435 EOL, but we never saw any buffer positions smaller than
436 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
437 motion in bidi-reordered lines.
438 (move_it_in_display_line_to): Record prev_method and prev_pos
439 immediately before the call to set_iterator_to_next. Fixes cursor
440 motion in bidi-reordered lines with stretch glyphs and strings
441 displayed in margins. (Bug#8133) (Bug#8867)
442 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
444 (pos_visible_p): Support positions in bidi-reordered lines. Save
445 and restore bidi cache.
447 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
448 (bidi_paragraph_info): Delete unused struct.
449 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
450 (bidi_cache_start): New variable.
451 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
453 (bidi_cache_fetch_state, bidi_cache_search)
454 (bidi_cache_find_level_change, bidi_cache_iterator_state)
455 (bidi_cache_find, bidi_peek_at_next_level)
456 (bidi_level_of_next_char, bidi_find_other_level_edge)
457 (bidi_move_to_visually_next): Compare cache index with
458 bidi_cache_start rather than with zero.
459 (bidi_fetch_char): Accept new argument STRING; all callers
460 changed. Support iteration over a string. Support strings with
461 display properties. Support unibyte strings. Fix the type of
462 `len' according to what STRING_CHAR_AND_LENGTH expects.
463 (bidi_paragraph_init, bidi_resolve_explicit_1)
464 (bidi_resolve_explicit, bidi_resolve_weak)
465 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
466 iteration over a string.
467 (bidi_set_sor_type, bidi_resolve_explicit_1)
468 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
469 can now be zero (for strings); special values 0 and -1 were
470 changed to -1 and -2, respectively.
471 (bidi_char_at_pos): New function.
472 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
473 Call it instead of FETCH_MULTIBYTE_CHAR.
474 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
475 initialized to valid values.
476 (bidi_init_it): Don't initialize charpos and bytepos with invalid
478 (bidi_level_of_next_char): Allow the sentinel "position" to pass
479 the test for valid cached positions. Fix the logic for looking up
480 the sentinel state in the cache. GCPRO the Lisp string we are
482 (bidi_push_it, bidi_pop_it): New functions.
483 (bidi_initialize): Initialize the bidi cache start stack pointer.
484 (bidi_cache_ensure_space): New function, refactored from part of
485 bidi_cache_iterator_state. Don't assume the required size is just
486 one BIDI_CACHE_CHUNK away.
487 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
488 (bidi_count_bytes, bidi_char_at_pos): New functions.
489 (bidi_cache_search): Don't assume bidi_cache_last_idx is
490 always valid if bidi_cache_idx is valid.
491 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
492 is valid if it's going to be used.
493 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
494 (bidi_cache_fetch_state, bidi_cache_search)
495 (bidi_cache_find_level_change, bidi_cache_ensure_space)
496 (bidi_cache_iterator_state, bidi_cache_find)
497 (bidi_find_other_level_edge, bidi_cache_start_stack): All
498 variables related to cache indices are now EMACS_INT.
500 * dispextern.h (struct bidi_string_data): New structure.
501 (struct bidi_it): New member `string'. Make flag members be 1-bit
502 fields, and put them last in the struct.
503 (compute_display_string_pos, compute_display_string_end): Update
505 (bidi_push_it, bidi_pop_it): Add prototypes.
506 (struct iterator_stack_entry): New members bidi_p,
507 paragraph_embedding, and from_disp_prop_p.
508 (struct it): Member bidi_p is now a bit field 1 bit wide.
509 (bidi_shelve_cache, bidi_unshelve_cache): Declare
512 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
513 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
514 and vector-like objects.
516 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
517 cache around display iteration.
519 * window.c (Fwindow_end, window_scroll_pixel_based)
520 (displayed_window_lines, Frecenter): Save and restore the bidi
521 cache around display iteration.
523 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
525 * editfns.c (Fdelete_region): Clarify the use of the named
526 parameters (bug#6788).
528 2011-07-14 Martin Rudalics <rudalics@gmx.at>
530 * indent.c (Fvertical_motion): Set and restore w->pointm when
531 saving and restoring the window's buffer (Bug#9006).
533 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
535 * editfns.c (Fstring_to_char): Clarify just what is returned
536 (bug#6576). Text by Eli Zaretskii.
538 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
540 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
542 2011-07-13 Eli Zaretskii <eliz@gnu.org>
544 * buffer.c (mmap_find): Fix a typo.
546 2011-07-13 Johan Bockgård <bojohan@gnu.org>
548 Fix execution of x selection hooks.
549 * xselect.c (Qx_lost_selection_functions)
550 (Qx_sent_selection_functions): New vars.
551 (syms_of_xselect): DEFSYM them.
552 (x_handle_selection_request): Pass Qx_sent_selection_functions
553 rather than Vx_sent_selection_functions to Frun_hook_with_args.
554 (x_handle_selection_clear,x_clear_frame_selections):
555 Pass Qx_lost_selection_functions rather than
556 Vx_lost_selection_functions to Frun_hook_with_args.
558 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
560 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
561 The old code sometimes used this field without initializing it.
563 * alloc.c (gc_sweep): Don't read past end of array.
564 In theory, the old code could also have corrupted Emacs internals,
565 though it'd be very unlikely.
567 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
569 * character.c (Fcharacterp): Don't advertise optional ignored
572 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
574 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
577 * window.c (Fset_window_start): Doc fix (bug#4199).
578 (Fset_window_hscroll): Ditto.
580 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
582 Fix minor new problems caught by GCC 4.6.1.
583 * term.c (init_tty): Remove unused local.
584 * xsettings.c (store_monospaced_changed): Define this function only
585 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
588 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
590 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
592 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
594 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
595 are the mini-buffer and the echo area (bug#3320).
597 * term.c (init_tty): Remove support for supdup, c10 and perq
598 terminals, which are no longer supported (bug#1482).
600 2011-07-10 Johan Bockgård <bojohan@gnu.org>
602 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
604 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
606 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
607 for non-popups (Bug#3642).
609 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
611 * alloc.c (reset_malloc_hooks): Protoize.
612 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
613 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
614 * cm.c (losecursor): Likewise.
615 * data.c (fmod): Likewise.
616 * dispnew.c (swap_glyphs_in_rows): Likewise.
617 * emacs.c (memory_warning_signal): Likewise.
618 * floatfns.c (float_error): Likewise.
619 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
620 (otf_open, font_otf_capability, generate_otf_features)
621 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
623 * image.c (pbm_read_file): Likewise.
624 * indent.c (string_display_width): Likewise.
625 * intervals.c (check_for_interval, search_for_interval)
626 (inc_interval_count, count_intervals, root_interval)
627 (adjust_intervals_for_insertion, make_new_interval): Likewise.
628 * lread.c (defalias): Likewise.
629 * ralloc.c (r_alloc_check): Likewise.
630 * regex.c (set_image_of_range_1, set_image_of_range)
631 (regex_grow_registers): Likewise.
632 * sysdep.c (strerror): Likewise.
633 * termcap.c (valid_filename_p, tprint, main): Likewise.
634 * tparam.c (main): Likewise.
635 * unexhp9k800.c (run_time_remap, save_data_space)
636 (update_file_ptrs, read_header, write_header, calculate_checksum)
637 (copy_file, copy_rest, display_header): Likewise.
638 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
640 * xdisp.c (check_it): Likewise.
641 * xfaces.c (register_color, unregister_color, unregister_colors):
643 * xfns.c (print_fontset_result): Likewise.
644 * xrdb.c (member, fatal, main): Likewise.
646 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
648 Fix minor problems found by static checking (Bug#9031).
649 * chartab.c (char_table_set_range, map_sub_char_table):
650 Remove unused locals.
651 (uniprop_table): Now static.
652 * composite.c (_work_char): Remove unused static var.
654 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
656 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
658 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
660 * gtkutil.c (qttip_cb): Remove code without function.
662 2011-07-09 Eli Zaretskii <eliz@gnu.org>
664 * w32.c (pthread_sigmask): New stub.
666 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
668 Use pthread_sigmask, not sigprocmask (Bug#9010).
669 sigprocmask is portable only for single-threaded applications, and
670 Emacs can be multi-threaded when it uses GTK.
671 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
673 * callproc.c (Fcall_process):
674 * process.c (create_process):
675 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
676 Use pthread_sigmask, not sigprocmask.
678 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
680 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
681 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
684 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
686 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
687 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
688 (xg_hide_tooltip): Fix comment.
690 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
691 in registerServicesMenuSendTypes.
692 (validRequestorForSendType): Don't check ns_return_types.
694 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
697 2011-07-08 Jason Rumney <jasonr@gnu.org>
699 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
700 frame struct members of non-existent frames (Bug#6284).
702 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
704 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
705 variable firstTime not needed on OSX >= 10.6.
706 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
707 >= 10.5. Use setKnobProportion, setDoubleValue.
709 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
710 (MAC_OS_X_VERSION_10_5): Define if not defined.
711 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
712 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
713 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
715 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
716 cString and lossyCString on OSX >= 10.4
718 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
719 sizeToFit on OSX >= 10.2.
721 * nsimage.m (allocInitFromFile): Don't use deprecated method
722 bestRepresentationForDevice on OSX >= 10.6.
724 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
727 * emacs.c: Declare unexec_init_emacs_zone.
729 * nsgui.h: Fix compiler warning about gnulib redefining verify.
731 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
733 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
734 on svcsMenu (Bug#8842).
736 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
738 (Fns_list_services): Just return Qnil on 10.6, code not working there.
740 * nsterm.m (QUTF8_STRING): Declare.
741 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
742 (validRequestorForSendType): Return type is (id).
743 Change indexOfObjectIdenticalTo to indexOfObject.
744 Check if we have local selection before returning self (Bug#8842).
745 (writeSelectionToPasteboard): Put local selection into paste board
746 if we have a local selection (Bug#8842).
747 (syms_of_nsterm): DEFSYM QUTF8_STRING.
749 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
750 (ns_get_local_selection): Declare.
752 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
754 * keymap.c (describe_map_tree): Don't insert a double newline at
755 the end of the buffer (bug#1169) and return whether we inserted
758 * callint.c (Fcall_interactively): Change "reading args" to
759 "providing args" to try to clarify what it does (bug#1010).
761 2011-07-07 Kenichi Handa <handa@m17n.org>
763 * composite.c (composition_compute_stop_pos): Ignore a static
764 composition starting before CHARPOS (Bug#8915).
766 * xdisp.c (handle_composition_prop): Likewise.
768 2011-07-07 Eli Zaretskii <eliz@gnu.org>
770 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
773 2011-07-07 Kenichi Handa <handa@m17n.org>
775 * character.h (unicode_category_t): New enum type.
777 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
778 (Qchar_code_property_table): New variable.
779 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
780 (UNIPROP_COMPRESSED_FORM_P): New macros.
781 (char_table_ascii): Uncompress the compressed values.
782 (sub_char_table_ref): New arg is_uniprop. Callers changed.
783 Uncompress the compressed values.
784 (sub_char_table_ref_and_range): Likewise.
785 (char_table_ref_and_range): Uncompress the compressed values.
786 (sub_char_table_set): New arg is_uniprop. Callers changed.
787 Uncompress the compressed values.
788 (sub_char_table_set_range): Args changed. Callers changed.
789 (char_table_set_range): Adjuted for the above change.
790 (map_sub_char_table): Delete args default_val and parent. Add arg
791 top. Give decoded values to a Lisp function.
792 (map_char_table): Adjusted for the above change. Give decoded
793 values to a Lisp function. Gcpro more variables.
794 (uniprop_table_uncompress)
795 (uniprop_decode_value_run_length): New functions.
796 (uniprop_decoder, uniprop_decoder_count): New variables.
797 (uniprop_get_decoder, uniprop_encode_value_character)
798 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
800 (uniprop_encoder, uniprop_encoder_count): New variables.
801 (uniprop_get_encoder, uniprop_table)
802 (Funicode_property_table_internal, Fget_unicode_property_internal)
803 (Fput_unicode_property_internal): New functions.
804 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
805 Sunicode_property_table_internal, Sget_unicode_property_internal,
806 and Sput_unicode_property_internal. Defvar_lisp
807 char-code-property-alist.
809 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
810 Vunicode_category_table.
812 * font.c (font_range): Adjusted for the change of
813 Vunicode_category_table.
815 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
817 * m/iris4d.h: Remove file, move contents ...
818 * s/irix6-5.h: ... here.
820 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
822 Remove unportable assumption about struct layout (Bug#8884).
823 * alloc.c (mark_buffer):
824 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
825 (clone_per_buffer_values): Don't assume that
826 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
827 This isn't true in general, and it's particularly not true
828 if Emacs is configured with --with-wide-int.
829 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
830 New macros, used in the buffer.c change.
832 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
834 * xsettings.c: Use both GConf and GSettings if both are available.
835 (store_config_changed_event): Add comment.
836 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
837 (store_tool_bar_style_changed): New functions.
838 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
839 (struct xsettings): Move font inside HAVE_XFT.
840 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
841 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
842 Move inside HAVE_XFT.
843 (something_changed_gsettingsCB): Renamed from something_changedCB.
844 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
846 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
847 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
848 (something_changed_gconfCB): Renamed from something_changedCB.
849 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
850 (parse_settings): Move check for font inside HAVE_XFT.
851 (read_settings, apply_xft_settings): Add comment.
852 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
853 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
854 call store_font_name_changed.
855 (xft_settings_event): Add comment.
856 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
857 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
858 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
859 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
860 (xsettings_initialize): Call init_gsettings last.
861 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
864 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
866 Random fixes. E.g., (random) never returned negative values.
867 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
868 subseconds part to the entropy, as that's a bit more random.
869 Prefer signed to unsigned, since the signedness doesn't matter and
870 in general we prefer signed. When given a limit, use a
871 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
872 latter isn't right if USE_2_TAGS_FOR_INTS.
873 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
874 not 0..VALMASK. Don't discard "excess" bits that random () returns.
876 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
878 * textprop.c (text_property_stickiness):
879 Obey Vtext_property_default_nonsticky.
880 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
881 * w32fns.c (syms_of_w32fns):
882 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
884 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
886 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
887 This is more efficient than Ffile_directory_p and avoids a minor race.
889 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
891 * buffer.c (Foverlay_put): Say what the return value is
894 * fileio.c (barf_or_query_if_file_exists): Check first if the file
895 is a directory before asking whether to use the file name
897 (barf_or_query_if_file_exists): Make the "File is a directory"
898 error be more correct.
900 * fns.c (Frequire): Remove the mention of the .gz files, since
901 that's installation-specific, but keep the mention of
904 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
906 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
907 Report string overflow if the output is too long.
909 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
911 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
912 (syms_of_gnutls): Remove duplicate DEFSYM for
913 Qgnutls_bootprop_verify_hostname_error, an error for
914 Qgnutls_bootprop_verify_error (which is no longer used).
916 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
917 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
918 Also (re)move comments that are misplaced or no longer relevant.
920 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
922 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
924 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
926 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
927 and background color parameters if they have been changed.
929 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
931 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
933 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
935 * xsettings.c (SYSTEM_FONT): Define only when used.
936 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
938 * keymap.c (access_keymap_1): Now static.
940 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
942 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
943 leave any prefix arg for the up event (Bug#1586).
945 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
947 * lread.c (syms_of_lread): Mention single symbols defined by
948 `defvar' or `defconst' (bug#7154).
950 * fns.c (Frequire): Mention .el.gz files (bug#7314).
951 (Frequire): Mention get-load-suffixes.
953 2011-07-02 Martin Rudalics <rudalics@gmx.at>
955 * window.h (window): Remove clone_number slot.
956 * window.c (Fwindow_clone_number, Fset_window_clone_number):
958 (make_parent_window, make_window, saved_window)
959 (Fset_window_configuration, save_window_save): Don't deal with
961 * buffer.c (Qclone_number): Remove declaration.
962 (sort_overlays, overlay_strings): Don't deal with clone numbers.
964 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
966 Add multiple inheritance to keymaps.
967 * keymap.c (Fmake_composed_keymap): New function.
968 (Fset_keymap_parent): Simplify.
969 (fix_submap_inheritance): Remove.
970 (access_keymap_1): New function extracted from access_keymap to handle
971 embedded parents and handle lists of maps.
972 (access_keymap): Use it.
973 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
974 (Fcopy_keymap): Handle embedded parents.
975 (Fcommand_remapping, define_as_prefix): Simplify.
976 (Fkey_binding): Simplify.
977 (syms_of_keymap): Move minibuffer-local-completion-map,
978 minibuffer-local-filename-completion-map,
979 minibuffer-local-must-match-map, and
980 minibuffer-local-filename-must-match-map to Elisp.
981 (syms_of_keymap): Defsubr make-composed-keymap.
982 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
983 (parse_menu_item): Trivial simplification.
985 2011-07-01 Glenn Morris <rgm@gnu.org>
987 * Makefile.in (SETTINGS_LIBS): Fix typo.
989 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
991 * coding.c (Fencode_coding_string): Record the last coding system
992 used, as the function doc string says (bug#8738).
994 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
996 * xsettings.c (store_monospaced_changed): Take new font as arg and
997 check for change against current_mono_font.
998 (EMACS_TYPE_SETTINGS): Remove this and related defines.
999 (emacs_settings_constructor, emacs_settings_get_property)
1000 (emacs_settings_set_property, emacs_settings_class_init)
1001 (emacs_settings_init, gsettings_obj): Remove.
1002 (something_changedCB): New function for HAVE_GSETTINGS.
1003 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
1004 with value as argument.
1005 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
1006 g_settings_new (Bug#8967). Do not create gsettings_obj.
1007 Remove calls to g_settings_bind. Connect something_changedCB to
1010 * xgselect.c: Add defined (HAVE_GSETTINGS).
1011 (xgselect_initialize): Ditto.
1013 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
1014 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
1017 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
1019 * eval.c (struct backtrace): Simplify and port the data structure.
1020 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
1021 signed bit field, as this assumption is not portable and it makes
1022 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
1023 "char debug_on_exit : 1" as this is not portable either; instead,
1024 use the portable "unsigned int debug_on_exit : 1". Remove unused
1025 member evalargs. Remove obsolete comments about cc bombing out.
1027 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
1029 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
1030 Let HAVE_GSETTINGS override HAVE_GCONF.
1031 (store_monospaced_changed): New function.
1032 (EMACS_SETTINGS): A new type derived from GObject to handle
1033 GSettings notifications.
1034 (emacs_settings_constructor, emacs_settings_get_property)
1035 (emacs_settings_set_property, emacs_settings_class_init):
1037 (gsettings_client, gsettings_obj): New variables.
1038 (GSETTINGS_SCHEMA): New define.
1039 (something_changedCB): Call store_monospaced_changed.
1040 (init_gsettings): New function.
1041 (xsettings_initialize): Call init_gsettings.
1042 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
1045 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
1048 2011-06-29 Martin Rudalics <rudalics@gmx.at>
1050 * window.c (resize_root_window, grow_mini_window)
1051 (shrink_mini_window): Rename Qresize_root_window to
1052 Qwindow_resize_root_window and Qresize_root_window_vertically to
1053 Qwindow_resize_root_window_vertically.
1055 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
1057 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
1059 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
1061 * makefile.w32-in: Redesign dependencies so they reflect more
1062 clearly which files are directly included by each source file,
1063 and not through other includes.
1065 2011-06-27 Martin Rudalics <rudalics@gmx.at>
1067 * buffer.c (Qclone_number): Declare static and DEFSYM it.
1068 (sort_overlays, overlay_strings): When an overlay's clone number
1069 matches the window's clone number process the overlay even if
1070 the overlay's window property doesn't match the current window.
1072 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
1073 (Fwindow_hchild): Rename to Fwindow_left_child.
1074 (Fwindow_next): Rename to Fwindow_next_sibling.
1075 (Fwindow_prev): Rename to Fwindow_prev_sibling.
1076 (resize_window_check): Rename to window_resize_check.
1077 (resize_window_apply): Rename to window_resize_apply.
1078 (Fresize_window_apply): Rename to Fwindow_resize_apply.
1079 (Fdelete_other_windows_internal, resize_frame_windows)
1080 (Fsplit_window_internal, Fdelete_window_internal)
1081 (grow_mini_window, shrink_mini_window)
1082 (Fresize_mini_window_internal): Fix callers accordingly.
1084 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
1086 * emacsgtkfixed.h: State that this is only used with Gtk+3.
1087 (emacs_fixed_set_min_size): Remove.
1088 (emacs_fixed_new): Take frame as argument.
1090 * emacsgtkfixed.c: State that this is only used with Gtk+3.
1091 (_EmacsFixedPrivate): Remove minwidth/height.
1092 Add struct frame *f.
1093 (emacs_fixed_init): Initialize priv->f.
1094 (get_parent_class, emacs_fixed_set_min_size): Remove.
1095 (emacs_fixed_new): Set priv->f to argument.
1096 (emacs_fixed_get_preferred_width)
1097 (emacs_fixed_get_preferred_height): Use min_width/height from
1098 frames size_hint to set minimum and natural (Bug#8919).
1099 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
1100 and use min_width/height from frames size_hint to set
1101 min_width/height (Bug#8919).
1103 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
1104 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
1107 2011-06-26 Eli Zaretskii <eliz@gnu.org>
1109 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1110 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1113 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
1115 * process.c (wait_reading_process_output): Bypass select if
1116 waiting for a cell while ignoring keyboard input, and input is
1117 pending. Suggested by Jan Djärv (Bug#8869).
1119 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1121 Use gnulib's dup2 module instead of rolling our own.
1122 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1124 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1126 * dispnew.c (scrolling_window): Before scrolling, turn off a
1127 mouse-highlight in the window being scrolled.
1129 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
1131 Move DEFSYM to lisp.h and use everywhere.
1133 * character.h (DEFSYM): Move declaration...
1134 * lisp.h (DEFSYM): ...here.
1140 * w32select.c: Don't include character.h.
1142 * alloc.c (syms_of_alloc):
1143 * buffer.c (syms_of_buffer):
1144 * bytecode.c (syms_of_bytecode):
1145 * callint.c (syms_of_callint):
1146 * casefiddle.c (syms_of_casefiddle):
1147 * casetab.c (init_casetab_once):
1148 * category.c (init_category_once, syms_of_category):
1149 * ccl.c (syms_of_ccl):
1150 * cmds.c (syms_of_cmds):
1151 * composite.c (syms_of_composite):
1152 * dbusbind.c (syms_of_dbusbind):
1153 * dired.c (syms_of_dired):
1154 * dispnew.c (syms_of_display):
1155 * doc.c (syms_of_doc):
1156 * editfns.c (syms_of_editfns):
1157 * emacs.c (syms_of_emacs):
1158 * eval.c (syms_of_eval):
1159 * fileio.c (syms_of_fileio):
1160 * fns.c (syms_of_fns):
1161 * frame.c (syms_of_frame):
1162 * fringe.c (syms_of_fringe):
1163 * insdel.c (syms_of_insdel):
1164 * keymap.c (syms_of_keymap):
1165 * lread.c (init_obarray, syms_of_lread):
1166 * macros.c (syms_of_macros):
1167 * msdos.c (syms_of_msdos):
1168 * print.c (syms_of_print):
1169 * process.c (syms_of_process):
1170 * search.c (syms_of_search):
1171 * sound.c (syms_of_sound):
1172 * syntax.c (init_syntax_once, syms_of_syntax):
1173 * terminal.c (syms_of_terminal):
1174 * textprop.c (syms_of_textprop):
1175 * undo.c (syms_of_undo):
1176 * w32.c (globals_of_w32):
1177 * window.c (syms_of_window):
1178 * xdisp.c (syms_of_xdisp):
1179 * xfaces.c (syms_of_xfaces):
1180 * xfns.c (syms_of_xfns):
1181 * xmenu.c (syms_of_xmenu):
1182 * xsettings.c (syms_of_xsettings):
1183 * xterm.c (syms_of_xterm): Use DEFSYM.
1185 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1187 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
1189 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1191 Integer and buffer overflow fixes (Bug#8873).
1193 * print.c (printchar, strout): Check for string overflow.
1194 (PRINTPREPARE, printchar, strout):
1195 Don't set size unless allocation succeeds.
1197 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1198 for sizes. Check for string overflow more accurately.
1199 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1201 * macros.c: Integer and buffer overflow fixes.
1202 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1203 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1204 Use ptrdiff_t, not int, for sizes.
1205 Don't increment bufsize until after realloc succeeds.
1206 Check for size-calculation overflow.
1207 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1209 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1211 * lread.c: Integer overflow fixes.
1212 (read_integer): Radix is now EMACS_INT, not int,
1213 to improve quality of diagnostics for out-of-range radices.
1214 Calculate buffer size correctly for out-of-range radices.
1215 (read1): Check for integer overflow in radices, and in
1216 read-circle numbers.
1217 (read_escape): Avoid int overflow.
1218 (Fload, openp, read_buffer_size, read1)
1219 (substitute_object_recurse, read_vector, read_list, map_obarray):
1220 Use ptrdiff_t, not int, for sizes.
1221 (read1): Use EMACS_INT, not int, for sizes.
1222 Check for size overflow.
1224 * image.c (cache_image): Check for size arithmetic overflow.
1226 * lread.c: Integer overflow issues.
1227 (saved_doc_string_size, saved_doc_string_length)
1228 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1229 Now ptrdiff_t, not int.
1230 (read1): Don't assume doc string length fits in int. Check for
1231 out-of-range doc string lengths.
1232 (read_list): Don't assume file position fits in int.
1233 (read_escape): Check for hex character overflow.
1235 2011-06-22 Leo Liu <sdl.web@gmail.com>
1237 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1238 Move to minibuffer.el.
1240 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1242 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
1243 The following patches are for when GLYPH_DEBUG && !XASSERT.
1244 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1245 * dispnew.c (flush_stdout):
1246 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1247 Mark as externally visible.
1248 * dispnew.c (check_window_matrix_pointers): Now static.
1249 * dispnew.c (window_to_frame_vpos):
1250 * xfns.c (unwind_create_frame):
1251 * xterm.c (x_check_font): Remove unused local.
1252 * scroll.c (CHECK_BOUNDS):
1253 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1254 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1255 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1256 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1257 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1259 (debug_method_add): Use va_list and vsprintf rather than relying
1260 on undefined behavior with wrong number of arguments.
1261 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1262 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1263 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1264 since we're not interested in debugging glyphs with old libraries.
1265 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1266 GCC 4.6.0's static checking.
1268 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1270 Integer overflow and signedness fixes (Bug#8873).
1271 A few related buffer overrun fixes, too.
1273 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1275 * dispextern.h (struct face.stipple):
1276 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1277 (x_bitmap_mask, x_allocate_bitmap_record)
1278 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1279 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1280 (x_create_bitmap_from_xpm_data):
1281 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1282 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1284 * xfaces.c (load_pixmap):
1285 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1286 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1287 (.bitmaps_last, struct x_output.icon_bitmap):
1288 Use ptrdiff_t, not int, for bitmap indexes.
1289 (x_allocate_bitmap_record): Check for size overflow.
1290 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1292 Use ptrdiff_t, not int, for overlay counts.
1293 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1294 * editfns.c (overlays_around, get_pos_property):
1295 * textprop.c (get_char_property_and_overlay):
1296 * xdisp.c (next_overlay_change, note_mouse_highlight):
1297 * xfaces.c (face_at_buffer_position):
1298 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1299 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1300 (Fnext_overlay_change, Fprevious_overlay_change)
1301 (mouse_face_overlay_overlaps, Foverlays_in):
1302 Use ptrdiff_t, not int, for sizes.
1303 (overlays_at, overlays_in): Check for size-calculation overflow.
1305 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1307 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1308 (x_session_initialize): Do not assume string length fits in int.
1310 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1311 This is unlikely, but can occur if DPI is outlandish.
1313 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
1314 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1316 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1317 * xrdb.c (magic_file_p, search_magic_path):
1318 Omit last arg SUFFIX; it was always 0. All callers changed.
1319 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1321 * xfont.c (xfont_match): Avoid need for strlen.
1323 * xfns.c: Don't assume strlen fits in int.
1324 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1326 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1327 not unsigned long, as we prefer signed integers. All callers changed.
1328 Detect integer overflow in repeat count.
1329 (message_dolog): Don't assume print length fits in 39 bytes.
1330 (display_mode_element): Don't assume strlen fits in int.
1332 * termcap.c: Don't assume sizes fit in int and never overflow.
1333 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1334 (gobble_line): Check for size-calculation overflow.
1336 * minibuf.c (Fread_buffer):
1337 * lread.c (intern, intern_c_string):
1338 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1339 Don't assume string length fits in int.
1341 * keyboard.c (parse_tool_bar_item):
1342 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1344 * font.c: Don't assume string length fits in int.
1345 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1346 Use ptrdiff_t, not int.
1347 (font_intern_prop): Don't assume string length fits in int.
1348 Don't assume integer property fits in fixnum.
1349 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
1351 * filelock.c: Fix some buffer overrun and integer overflow issues.
1352 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
1353 Reformulate so as not to need the command string.
1354 Invoke gzip -cd rather than gunzip, as it's more portable.
1355 (lock_info_type, lock_file_1, lock_file):
1356 Don't assume pid_t and time_t fit in unsigned long.
1357 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1358 (current_lock_owner): Prefer signed type for sizes.
1359 Use memcpy, not strncpy, where memcpy is what is really wanted.
1360 Don't assume (via atoi) that time_t and pid_t fit in int.
1361 Check for time_t and/or pid_t out of range, e.g., via a network share.
1362 Don't alloca where an auto var works fine.
1364 * fileio.c: Fix some integer overflow issues.
1365 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1366 Don't assume string length fits in int.
1367 (directory_file_name): Don't assume string length fits in long.
1368 (make_temp_name): Don't assume pid fits in int, or that its print
1369 length is less than 20.
1371 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1373 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1375 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1377 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1378 We prefer signed integers, even for size calculations.
1380 * emacs.c: Don't assume string length fits in 'int'.
1381 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1382 (main): Don't invoke strlen when not needed.
1384 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1385 (XD_DEBUG_MESSAGE): Don't waste a byte.
1387 * callproc.c (getenv_internal_1, getenv_internal)
1389 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1391 * lread.c (invalid_syntax): Omit length argument.
1392 All uses changed. This doesn't fix a bug, but it simplifies the
1393 code away from its former Hollerith-constant appearance, and it's
1394 one less 'int' to worry about when looking at integer-overflow issues.
1395 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
1397 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1398 This didn't break anything, but it didn't help either.
1399 It's confusing to put a bogus integer in a place where the actual
1400 value does not matter.
1401 (LIST_END_P): Remove unused macro and its bogus comment.
1402 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
1404 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1405 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1407 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1408 We prefer signed types, and the value cannot exceed the EMACS_INT
1409 range anyway (because otherwise the length would not be representable).
1410 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1411 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1412 This avoids a GCC warning when WIDE_EMACS_INT.
1414 * indent.c (sane_tab_width): New function.
1415 (current_column, scan_for_column, Findent_to, position_indentation)
1416 (compute_motion): Use it. This is just for clarity.
1417 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
1419 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
1421 * lisp.h (lint_assume): New macro.
1422 * composite.c (composition_gstring_put_cache):
1423 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1425 * editfns.c, insdel.c:
1426 Omit unnecessary forward decls, to simplify future changes.
1428 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1430 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1432 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
1433 Use much-faster test for byte-length change.
1434 Don't assume string byte-length fits in 'int'.
1435 Check that character arg fits in 'int'.
1436 (mapcar1): Declare byte as byte, for clarity.
1438 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1440 * fns.c (concat): Catch string overflow earlier.
1441 Do not rely on integer wraparound.
1443 * dispextern.h (struct it.overlay_strings_charpos)
1444 (struct it.selective): Now EMACS_INT, not int.
1445 * xdisp.c (forward_to_next_line_start)
1446 (back_to_previous_visible_line_start)
1447 (reseat_at_next_visible_line_start, next_element_from_buffer):
1448 Don't arbitrarily truncate the value of 'selective' to int.
1450 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1452 * composite.c: Don't truncate sizes to 'int'.
1453 (composition_gstring_p, composition_reseat_it)
1454 (composition_adjust_point): Use EMACS_INT, not int.
1455 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1456 not EMACS_UINT, for indexes.
1458 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1460 * buffer.c: Include <verify.h>.
1461 (struct sortvec.priority, struct sortstr.priority):
1462 Now EMACS_INT, not int.
1463 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
1464 (struct sortstr.size, record_overlay_string)
1465 (struct sortstrlist.size, struct sortlist.used):
1466 Don't truncate size to int.
1467 (record_overlay_string): Check for size-calculation overflow.
1468 (init_buffer_once): Check at compile-time, not run-time.
1470 2011-06-22 Jim Meyering <meyering@redhat.com>
1472 Don't leak an XBM-image-sized buffer
1473 * image.c (xbm_load): Free the image buffer after using it.
1475 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1478 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1479 that Sun C diagnosed.
1480 * fns.c (secure_hash): Fix pointer signedness issue.
1481 * intervals.c (static_offset_intervals): New function.
1482 (offset_intervals): Use it.
1484 2011-06-21 Leo Liu <sdl.web@gmail.com>
1487 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1490 * fns.c (secure_hash): Rename from crypto_hash_function and change
1491 the first arg to accept symbols.
1492 (Fsecure_hash): New primitive.
1493 (syms_of_fns): New symbols.
1495 2011-06-20 Deniz Dogan <deniz@dogan.se>
1497 * process.c (Fset_process_buffer): Clarify return value in
1500 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
1502 * dispnew.c (add_window_display_history): Use BVAR.
1504 * xdisp.c (debug_method_add): Use BVAR.
1505 (check_window_end, dump_glyph_matrix, dump_glyph)
1506 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1508 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1511 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1512 check till after the cache is created in init_frame_faces.
1514 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1516 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1518 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1520 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1521 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1522 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1524 Improve buffer-overflow checking (Bug#8873).
1525 * fileio.c (Finsert_file_contents):
1526 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1527 Remove the old (too-loose) buffer overflow checks.
1528 They weren't needed, since make_gap checks for buffer overflow.
1529 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1530 The old code merely checked for Emacs fixnum overflow, and relied
1531 on undefined (wraparound) behavior. The new code avoids undefined
1532 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1534 * editfns.c (Finsert_char): Don't dump core with very negative counts.
1535 Tune. Don't use wider integers than needed. Don't use alloca.
1536 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
1538 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1540 * insdel.c, lisp.h (buffer_overflow): New function.
1541 (insert_from_buffer_1, replace_range, replace_range_2):
1542 * insdel.c (make_gap_larger):
1543 * editfns.c (Finsert_char):
1544 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1546 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1548 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1550 Integer overflow and signedness fixes (Bug#8873).
1552 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1553 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1555 * fileio.c: Don't assume EMACS_INT fits in off_t.
1556 (emacs_lseek): New static function.
1557 (Finsert_file_contents, Fwrite_region): Use it.
1558 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1560 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1562 * fns.c: Don't overflow int when computing a list length.
1563 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1564 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1565 truncation on 64-bit hosts. Check for QUIT every
1566 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1567 faster and is responsive enough.
1568 (Flength): Report an error instead of overflowing an integer.
1569 (Fsafe_length): Return a float if the value is not representable
1570 as a fixnum. This shouldn't happen except in contrived situations.
1571 (Fnthcdr, Fsort): Don't assume list length fits in int.
1572 (Fcopy_sequence): Don't assume vector length fits in int.
1574 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1575 (header_size, word_size): New constants.
1576 (allocate_vectorlike): Don't check size overflow here.
1577 (allocate_vector): Check it here instead, since this is the only
1578 caller of allocate_vectorlike that could cause overflow.
1579 Check that the new vector's length is representable as a fixnum.
1581 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1582 The previous code was bogus. For example, next_almost_prime (32)
1583 returned 39, which is undesirable as it is a multiple of 3; and
1584 next_almost_prime (24) returned 25, which is a multiple of 5 so
1585 why was the code bothering to check for multiples of 7?
1587 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1589 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1591 Variadic C functions now count arguments with ptrdiff_t.
1592 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1593 Back then I didn't know that the Emacs coding style prefers signed int.
1594 Also, in the meantime I found a few more instances where arguments
1595 were being counted with int, which may truncate counts on 64-bit
1596 machines, or EMACS_INT, which may be unnecessarily wide.
1597 * lisp.h (struct Lisp_Subr.function.aMANY)
1598 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1599 Arg counts are now ptrdiff_t, not size_t.
1600 All variadic functions and their callers changed accordingly.
1601 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1602 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1603 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1604 * callint.c (Fcall_interactively): Check arg count for overflow,
1605 to avoid potential buffer overrun. Use signed char, not 'int',
1606 for 'varies' array, so that we needn't bother to check its size
1607 calculation for overflow.
1608 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1609 * eval.c (apply_lambda):
1610 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1611 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1612 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1614 * callint.c (Fcall_interactively): Don't use index var as event count.
1616 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1617 * mem-limits.h (SIZE): Remove; no longer used.
1619 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
1621 Remove unnecessary casts.
1622 * xterm.c (x_term_init):
1623 * xfns.c (x_set_border_pixel):
1624 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1625 These aren't needed now that we assume ANSI C.
1627 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1628 It's more likely to cause problems (due to unsigned overflow)
1631 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1633 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1635 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1637 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1639 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1641 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1643 GLYPH_CODE_FACE returns EMACS_INT, not int.
1644 * dispextern.h (merge_faces):
1645 * xfaces.c (merge_faces):
1646 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1647 Don't assume EMACS_INT fits in int.
1649 * character.h (CHAR_VALID_P): Remove unused parameter.
1650 * fontset.c, lisp.h, xdisp.c: All uses changed.
1652 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1654 * fns.c (concat): Minor tuning based on overflow analysis.
1655 This doesn't fix any bugs. Use int to hold character, instead
1656 of constantly refetching from Emacs object. Use XFASTINT, not
1657 XINT, for value known to be a character. Don't bother comparing
1658 a single byte to 0400, as it's always less.
1660 * floatfns.c (Fexpt):
1661 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1663 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1666 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1668 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1669 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1670 incorrectly succeed when S was a string, because 4294967386 was
1671 truncated before it was used.
1673 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1674 Otherwise, an out-of-range integer could cause undefined behavior
1677 * composite.c: Use int, not EMACS_INT, for characters.
1678 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1679 EMACS_INT, for values that are known to be in character range.
1680 This doesn't fix any bugs but is the usual style inside Emacs and
1681 may generate better code on 32-bit machines.
1683 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1684 This is for reasons similar to the recent CHAR_STRING fix.
1685 * charset.c (Fencode_char): Check that character arg is actually
1686 a character. Pass an int to ENCODE_CHAR.
1687 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1688 wider than 'int', as a compile-time check to prevent future regressions
1691 * character.c (char_string): Remove unnecessary casts.
1693 Make sure a 64-bit char is never passed to CHAR_STRING.
1694 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1695 by silently ignoring the top 32 bits, allowing some values
1696 that were far too large to be valid characters.
1697 * character.h: Include <verify.h>.
1698 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1699 arguments are no wider than unsigned, as a compile-time check
1700 to prevent future regressions in this area.
1702 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
1703 (Fsubst_char_in_region):
1705 * xdisp.c (decode_mode_spec_coding):
1706 Adjust to CHAR_STRING's new requirement.
1707 * editfns.c (Finsert_char, Fsubst_char_in_region):
1708 * fns.c (concat): Check that character args are actually
1709 characters. Without this test, these functions did the wrong
1710 thing with wildly out-of-range values on 64-bit hosts.
1712 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1713 These casts should not be needed on 32-bit hosts, either.
1714 * keyboard.c (read_char):
1715 * lread.c (Fload): Remove casts to unsigned.
1717 * lisp.h (UNSIGNED_CMP): New macro.
1718 This fixes comparison bugs on 64-bit hosts.
1719 (ASCII_CHAR_P): Use it.
1720 * casefiddle.c (casify_object):
1721 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
1722 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1723 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1724 * dispextern.h (FACE_FROM_ID):
1725 * keyboard.c (read_char): Use UNSIGNED_CMP.
1727 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1728 not to EMACS_INT, to avoid GCC warning.
1730 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1732 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1733 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1734 isn't needed on 32-bit machines.
1736 * buffer.c (Fgenerate_new_buffer_name):
1737 Use EMACS_INT for count, not int.
1738 (advance_to_char_boundary): Return EMACS_INT, not int.
1740 * data.c (Qcompiled_function): Now static.
1742 * window.c (window_body_lines): Now static.
1744 * image.c (gif_load): Rename local to avoid shadowing.
1746 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
1747 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
1748 * alloc.c (make_save_value): Integer argument is now of type
1750 (mark_object): Use ptrdiff_t, not int.
1751 * lisp.h (pD): New macro.
1752 * print.c (print_object): Use it.
1754 * alloc.c: Use EMACS_INT, not int, to count objects.
1755 (total_conses, total_markers, total_symbols, total_vector_size)
1756 (total_free_conses, total_free_markers, total_free_symbols)
1757 (total_free_floats, total_floats, total_free_intervals)
1758 (total_intervals, total_strings, total_free_strings):
1759 Now EMACS_INT, not int. All uses changed.
1760 (Fgarbage_collect): Compute overall total using a double, so that
1761 integer overflow is less likely to be a problem. Check for overflow
1762 when converting back to an integer.
1763 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
1764 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
1765 These were 'int' variables that could overflow on 64-bit hosts;
1766 they were never used, so remove them instead of repairing them.
1767 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
1768 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
1769 Previously, this ceilinged at INT_MAX, but that doesn't work on
1771 (allocate_pseudovector): Don't use EMACS_INT when int would do.
1773 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
1774 (allocate_vectorlike): Check for ptrdiff_t overflow.
1775 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
1776 when a (possibly-narrower) signed value would do just as well.
1777 We prefer using signed arithmetic, to avoid comparison confusion.
1779 * alloc.c: Catch some string size overflows that we were missing.
1780 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
1781 for convenience in STRING_BYTES_MAX.
1782 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
1783 The definition here is exact; the one in lisp.h was approximate.
1784 (allocate_string_data): Check for string overflow. This catches
1785 some instances we weren't catching before. Also, it catches
1786 size_t overflow on (unusual) hosts where SIZE_MAX <= min
1787 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
1788 and ptrdiff_t and EMACS_INT are both 64 bits.
1790 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
1791 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
1792 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
1794 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
1796 * alloc.c (Fmake_string): Check for out-of-range init.
1798 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
1800 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
1802 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
1804 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
1805 xg_get_default_scrollbar_width.
1807 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
1808 (int_gtk_range_get_value): Move to the scroll bar part of the file.
1809 (style_changed_cb): Call update_theme_scrollbar_width and call
1810 x_set_scroll_bar_default_width and xg_frame_set_char_size for
1811 all frames (Bug#8505).
1812 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
1813 Call gtk_window_set_resizable if HAVE_GTK3.
1814 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
1815 and height if HAVE_GTK3 (Bug#8505).
1816 (scroll_bar_width_for_theme): New variable.
1817 (update_theme_scrollbar_width): New function.
1818 (xg_get_default_scrollbar_width): Move code to
1819 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
1820 (xg_initialize): Call update_theme_scrollbar_width.
1822 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
1824 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
1826 2011-06-12 Martin Rudalics <rudalics@gmx.at>
1828 * frame.c (make_frame): Call other_buffer_safely instead of
1831 * window.c (temp_output_buffer_show): Call display_buffer with
1832 second argument Vtemp_buffer_show_specifiers and reset latter
1833 immediately after the call.
1834 (Vtemp_buffer_show_specifiers): New variable.
1835 (auto_window_vscroll_p, next_screen_context_lines)
1836 (Vscroll_preserve_screen_position): Remove leading asterisks from
1839 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
1841 Fix minor problems found by GCC 4.6.0 static checking.
1842 * buffer.c (Qclone_number): Remove for now, as it's unused.
1843 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
1844 (record_buffer): Remove unused local.
1845 * frame.c (other_visible_frames, frame_buffer_list): Now static.
1846 (set_frame_buffer_list): Remove; unused.
1847 * frame.h (other_visible_frames): Remove decl.
1848 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
1849 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
1850 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
1852 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
1853 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
1854 Define only if HAVE_GPM.
1855 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
1856 (update_hints_inhibit): Remove; never set. All uses removed.
1857 * widgetprv.h (emacsFrameClassRec): Remove decl.
1858 * window.c (delete_deletable_window): Now returns void, since it
1859 wasn't returning anything.
1860 (compare_window_configurations): Remove unused locals.
1861 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
1862 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
1863 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
1864 the same widths as pointers. This follows up on the 2011-05-06 patch.
1865 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
1866 * xterm.h: Likewise.
1867 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
1869 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
1871 * makefile.w32-in: Update dependencies.
1872 (LISP_H): Add lib/intprops.h.
1874 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
1876 * image.c (gif_load): Add animation frame delay to the metadata.
1877 (syms_of_image): Use DEFSYM. New symbol `delay'.
1879 2011-06-11 Martin Rudalics <rudalics@gmx.at>
1881 * window.c (delete_deletable_window): Re-add.
1882 (Fset_window_configuration): Rewrite to handle dead buffers and
1883 consequently deletable windows.
1884 (window_tree, Fwindow_tree): Remove. Supply functionality in
1886 (compare_window_configurations): Simplify code.
1888 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
1890 * image.c (imagemagick_load_image): Fix type mismatch.
1891 (Fimagemagick_types): Likewise.
1893 * window.h (replace_buffer_in_windows): Declare.
1895 2011-06-11 Martin Rudalics <rudalics@gmx.at>
1897 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
1898 Qclone_number. Remove external declaration of Qdelete_window.
1899 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
1901 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
1902 Qbuffer_list_update_hook if allowed.
1903 (Fother_buffer): Rewrite doc-string. Major rewrite for new
1904 buffer list implementation.
1905 (other_buffer_safely): New function.
1906 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
1907 calls to replace_buffer_in_windows and
1908 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
1910 (record_buffer): Inhibit quitting and rewrite using quittable
1911 functions. Run Qbuffer_list_update_hook if allowed.
1912 (Frecord_buffer, Funrecord_buffer): New functions.
1913 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
1914 switch-to-buffer to window.el.
1915 (bury-buffer): Move to window.el.
1916 (Vbuffer_list_update_hook): New variable.
1918 * lisp.h (other_buffer_safely): Add prototype in buffer.c
1921 * window.h (resize_frame_windows): Move up in code.
1922 (Fwindow_frame): Remove EXFUN.
1923 (replace_buffer_in_all_windows): Remove prototype.
1924 (replace_buffer_in_windows_safely): Add prototype.
1926 * window.c: Declare Qdelete_window static again. Move down
1927 declaration of select_count.
1928 (Fnext_window, Fprevious_window): Rewrite doc-strings.
1929 (Fother_window): Move to window.el.
1930 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
1931 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
1932 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
1934 (replace_buffer_in_windows): Implement by calling
1935 Qreplace_buffer_in_windows.
1936 (replace_buffer_in_all_windows): Remove with some functionality
1937 moved into replace_buffer_in_windows_safely.
1938 (replace_buffer_in_windows_safely): New function.
1939 (select_window_norecord, select_frame_norecord): Move in front
1940 of run_window_configuration_change_hook. Remove now obsolete
1942 (Fset_window_buffer): Rewrite doc-string. Call
1943 Qrecord_window_buffer.
1944 (keys_of_window): Move binding for other-window to window.el.
1946 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
1948 * dispextern.h (struct image): Replace data member, whose int_val
1949 and ptr_val fields were not used by anything, with a single
1952 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
1953 (gif_clear_image, gif_load, imagemagick_load_image)
1954 (gs_clear_image, gs_load): Callers changed.
1956 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
1958 * buffer.h: Include <time.h>, for time_t.
1959 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
1961 Fix minor problems found by static checking.
1963 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
1965 Make identifiers static if they are not used in other modules.
1966 * data.c (Qcompiled_function, Qframe, Qvector):
1967 * image.c (QimageMagick, Qsvg):
1968 * minibuf.c (Qmetadata):
1969 * window.c (resize_window_check, resize_root_window): Now static.
1970 * window.h (resize_window_check, resize_root_window): Remove decls.
1972 * window.c (window_deletion_count, delete_deletable_window):
1974 (window_body_lines): Now static.
1975 (Fdelete_other_windows_internal): Mark vars as initialized.
1976 Make sure 'resize_failed' is initialized.
1977 (run_window_configuration_change_hook): Rename local to avoid shadowing.
1978 (resize_window_apply): Remove unused local.
1979 * window.h (delete_deletable_window): Remove decl.
1981 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
1982 (imagemagick_load_image): Fix pointer signedness problem by changing
1983 last arg from unsigned char * to char *. All uses changed.
1984 Also, fix a local for similar reasons.
1985 Remove unused locals. Remove locals to avoid shadowing.
1986 (fn_rsvg_handle_free): Remove; unused.
1987 (svg_load, svg_load_image): Fix pointer signedness problem.
1988 (imagemagick_load_image): Don't use garbage pointer image_wand.
1990 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
1992 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
1994 * image.c (gif_load): Fix omitted cast error introduced by
1997 2011-06-10 Martin Rudalics <rudalics@gmx.at>
1999 * window.h (resize_proportionally, orig_total_lines)
2000 (orig_top_line): Remove from window structure.
2001 (set_window_height, set_window_width, change_window_heights)
2002 (Fdelete_window): Remove prototypes.
2003 (resize_frame_windows): Remove duplicate declaration.
2005 2011-06-10 Eli Zaretskii <eliz@gnu.org>
2007 * window.h (resize_frame_windows, resize_window_check)
2008 (delete_deletable_window, resize_root_window)
2009 (resize_frame_windows): Declare prototypes.
2011 * window.c (resize_window_apply): Make definition be "static" to
2012 match the prototype.
2014 2011-06-10 Martin Rudalics <rudalics@gmx.at>
2016 * window.c: Remove declarations of Qwindow_size_fixed,
2017 window_min_size_1, window_min_size_2, window_min_size,
2018 size_window, window_fixed_size_p, enlarge_window, delete_window.
2019 Remove static from declaration of Qdelete_window, it's
2020 temporarily needed by Fbury_buffer.
2021 (replace_window): Don't assign orig_top_line and
2023 (Fdelete_window, delete_window): Remove. Window deletion is
2024 handled by window.el.
2025 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
2026 Fdelete_window calls with calls to Qdelete_window.
2027 (Fdelete_other_windows): Remove. Deleting other windows is
2028 handled by window.el.
2029 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
2030 handled in window.el.
2031 (window_min_size_2, window_min_size_1, window_min_size): Remove.
2032 Window minimum sizes are handled in window.el.
2033 (shrink_windows, size_window, set_window_height)
2034 (set_window_width, change_window_heights, window_height)
2035 (window_width, CURBEG, CURSIZE, enlarge_window)
2036 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
2037 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
2038 handled in window.el.
2039 (make_dummy_parent): Rename to make_parent_window and give it a
2040 second argument horflag.
2041 (make_window): Don't set resize_proportionally any more.
2042 (Fsplit_window): Remove. Windows are split in window.el.
2043 (save_restore_action, save_restore_orig_size)
2044 (shrink_window_lowest_first, save_restore_orig_size): Remove.
2045 Resize mini windows in window.el.
2046 (grow_mini_window, shrink_mini_window): Implement by calling
2047 Qresize_root_window_vertically, resize_window_check and
2048 resize_window_apply.
2049 (saved_window, Fset_window_configuration, save_window_save): Do
2050 not handle orig_top_line, orig_total_lines, and
2051 resize_proportionally.
2052 (window_min_height, window_min_width): Move to window.el.
2053 (keys_of_window): Move bindings for delete-other-windows,
2054 split-window, delete-window and enlarge-window to window.el.
2056 * buffer.c: Temporarily extern Qdelete_window.
2057 (Fbury_buffer): Temporarily call Qdelete_window instead of
2058 Fdelete_window (Fbury_buffer will move to window.el soon).
2060 * frame.c (set_menu_bar_lines_1): Remove code handling
2061 orig_top_line and orig_total_lines.
2063 * dispnew.c (adjust_frame_glyphs_initially): Don't use
2064 set_window_height but set heights directly.
2065 (change_frame_size_1): Use resize_frame_windows.
2067 * xdisp.c (init_xdisp): Don't use set_window_height but set
2070 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
2071 resize_frame_windows instead of change_window_heights and run
2072 run_window_configuration_change_hook.
2074 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
2075 instead of change_window_heights and run
2076 run_window_configuration_change_hook.
2078 2011-06-09 Martin Rudalics <rudalics@gmx.at>
2080 * window.c (replace_window): Rename second argument REPLACEMENT to
2081 NEW. New third argument SETFLAG. Rewrite.
2082 (delete_window, make_dummy_parent): Call replace_window with
2084 (window_list_1): Move down in code.
2085 (run_window_configuration_change_hook): Move set_buffer part
2086 before select_frame_norecord part in order to unwind correctly.
2087 Rename count1 to count.
2088 (recombine_windows, delete_deletable_window, resize_root_window)
2089 (Fdelete_other_windows_internal)
2090 (Frun_window_configuration_change_hook, make_parent_window)
2091 (resize_window_check, resize_window_apply, Fresize_window_apply)
2092 (resize_frame_windows, Fsplit_window_internal)
2093 (Fdelete_window_internal, Fresize_mini_window_internal): New
2095 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
2097 2011-06-08 Martin Rudalics <rudalics@gmx.at>
2099 * window.h (window): Add some new members to window structure -
2100 normal_lines, normal_cols, new_total, new_normal, clone_number,
2101 splits, nest, prev_buffers, next_buffers.
2102 (WINDOW_TOTAL_SIZE): Move here from window.c.
2103 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
2105 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2107 (make_dummy_parent): Set new members of windows structure.
2108 (make_window): Move down in code. Handle new members of window
2110 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2111 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2112 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2113 (Fset_window_prev_buffers, Fwindow_next_buffers)
2114 (Fset_window_next_buffers, Fset_window_clone_number): New
2116 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2117 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2119 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2120 Argument WINDOW can be now internal window too.
2121 (Fwindow_use_time): Move up in code.
2122 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2124 (Fset_window_configuration, saved_window)
2125 (Fcurrent_window_configuration, save_window_save): Handle new
2126 members of window structure.
2127 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2128 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2129 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2130 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2131 Qget_mru_window, Qresize_root_window,
2132 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2133 Qauto_buffer_name; staticpro them.
2135 2011-06-07 Martin Rudalics <rudalics@gmx.at>
2137 * window.c (Fwindow_total_size, Fwindow_left_column)
2138 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2139 (Fwindow_list_1): New functions.
2140 (window_box_text_cols): Replace with window_body_cols.
2141 (Fwindow_width, Fscroll_left, Fscroll_right): Use
2142 window_body_cols instead of window_box_text_cols.
2143 (delete_window, Fset_window_configuration): Call
2144 delete_all_subwindows with window as argument.
2145 (delete_all_subwindows): Take a window as argument and not a
2147 (window_loop): Remove handling of GET_LRU_WINDOW and
2149 (Fget_lru_window, Fget_largest_window): Move to window.el.
2151 * window.h: Extern window_body_cols instead of
2152 window_box_text_cols. delete_all_subwindows now takes a
2153 Lisp_Object as argument.
2155 * indent.c (compute_motion, Fcompute_motion): Use
2156 window_body_cols instead of window_box_text_cols.
2158 * frame.c (delete_frame): Call delete_all_subwindows with root
2161 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2163 * fns.c (Fputhash): Document return value.
2165 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
2167 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2169 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2171 Cons<->int and similar integer overflow fixes (Bug#8794).
2173 Check for overflow when converting integer to cons and back.
2174 * charset.c (Fdefine_charset_internal, Fdecode_char):
2175 Use cons_to_unsigned to catch overflow.
2176 (Fencode_char): Use INTEGER_TO_CONS.
2177 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2178 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2179 * data.c (long_to_cons, cons_to_long): Remove.
2180 (cons_to_unsigned, cons_to_signed): New functions.
2181 These signal an error for invalid or out-of-range values.
2182 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2183 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2184 * font.c (Ffont_variation_glyphs):
2185 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2186 * lisp.h: Include <intprops.h>.
2187 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2188 (cons_to_signed, cons_to_unsigned): New decls.
2189 (long_to_cons, cons_to_long): Remove decls.
2190 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2191 (Fprimitive_undo): Use CONS_TO_INTEGER.
2192 * xfns.c (Fx_window_property): Likewise.
2193 * xselect.c: Include <limits.h>.
2194 (x_own_selection, selection_data_to_lisp_data):
2195 Use INTEGER_TO_CONS.
2196 (x_handle_selection_request, x_handle_selection_clear)
2197 (x_get_foreign_selection, Fx_disown_selection_internal)
2198 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2199 (lisp_data_to_selection_data): Use cons_to_unsigned.
2200 (x_fill_property_data): Use cons_to_signed.
2201 Report values out of range.
2203 Check for buffer and string overflow more precisely.
2204 * buffer.h (BUF_BYTES_MAX): New macro.
2205 * lisp.h (STRING_BYTES_MAX): New macro.
2206 * alloc.c (Fmake_string):
2207 * character.c (string_escape_byte8):
2208 * coding.c (coding_alloc_by_realloc):
2209 * doprnt.c (doprnt):
2210 * editfns.c (Fformat):
2212 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2213 since they may not be the same number.
2214 * editfns.c (Finsert_char):
2215 * fileio.c (Finsert_file_contents):
2216 Likewise for BUF_BYTES_MAX.
2218 * image.c: Use ptrdiff_t, not int, for sizes.
2219 (slurp_file): Switch from int to ptrdiff_t.
2221 (slurp_file): Check that file size fits in both size_t (for
2222 malloc) and ptrdiff_t (for sanity and safety).
2224 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2225 if b->modtime has its maximal value.
2227 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2229 Don't assume time_t can fit into int.
2230 * buffer.h (struct buffer.modtime): Now time_t, not int.
2231 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2232 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2234 Minor fixes for signed vs unsigned integers.
2235 * character.h (MAYBE_UNIFY_CHAR):
2236 * charset.c (maybe_unify_char):
2237 * keyboard.c (read_char, reorder_modifiers):
2238 XINT -> XFASTINT, since the integer must be nonnegative.
2239 * ftfont.c (ftfont_spec_pattern):
2240 * keymap.c (access_keymap, silly_event_symbol_error):
2241 XUINT -> XFASTINT, since the integer must be nonnegative.
2242 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2243 since it makes no difference and we prefer signed.
2244 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2245 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2248 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2250 * window.h (Fwindow_frame): Declare.
2252 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2254 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2255 (SPARE_MEMORY): Always define.
2256 (LARGE_REQUEST): Remove.
2257 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2259 2011-06-06 Martin Rudalics <rudalics@gmx.at>
2261 * lisp.h: Move EXFUNS for Fframe_root_window,
2262 Fframe_first_window and Fset_frame_selected_window to window.h.
2264 * window.h: Move EXFUNS for Fframe_root_window,
2265 Fframe_first_window and Fset_frame_selected_window here from
2268 * frame.c (Fwindow_frame, Fframe_first_window)
2269 (Fframe_root_window, Fframe_selected_window)
2270 (Fset_frame_selected_window): Move to window.c.
2271 (Factive_minibuffer_window): Move to minibuf.c.
2272 (Fother_visible_frames_p): New function.
2274 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2276 * window.c (decode_window, decode_any_window): Move up in code.
2277 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2278 (inhibit_frame_unsplittable): Remove unused variable.
2279 (Fwindow_buffer): Move up and rewrite doc-string.
2280 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2281 (Fwindow_prev): New functions.
2282 (Fwindow_frame): Move here from frame.c. Accept any window as
2284 (Fframe_root_window, Fframe_first_window)
2285 (Fframe_selected_window): Move here from frame.c. Accept frame
2286 or arbitrary window as argument. Update doc-strings.
2287 (Fminibuffer_window): Move up in code.
2288 (Fwindow_minibuffer_p): Move up in code and simplify.
2289 (Fset_frame_selected_window): Move here from frame.c.
2291 (Fselected_window, select_window, Fselect_window): Move up in
2292 code. Minor doc-string fixes.
2294 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2296 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2297 Do not assume that spare memory exists; that assumption is valid
2298 only if SYSTEM_MALLOC.
2299 (LARGE_REQUEST): New macro, so that the issue of large requests
2300 is separated from the issue of spare memory.
2302 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2304 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2307 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2309 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2312 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2314 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2316 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2318 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2319 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2321 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
2323 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2325 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
2327 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2328 (x_clipboard_manager_save): Add return value.
2329 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2331 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2332 Obey Vx_select_enable_clipboard_manager. Catch errors in
2333 x_clipboard_manager_save (Bug#8779).
2334 (Vx_select_enable_clipboard_manager): New variable.
2335 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
2337 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
2339 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2341 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2343 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2344 in the current matrix if keep_current_p is non-zero.
2346 2011-06-04 Eli Zaretskii <eliz@gnu.org>
2348 * bidi.c (bidi_level_of_next_char): Fix last change.
2350 2011-06-03 Eli Zaretskii <eliz@gnu.org>
2352 Support bidi reordering of text covered by display properties.
2354 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2355 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2356 (bidi_cache_search, bidi_cache_iterator_state)
2357 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2358 (bidi_level_of_next_char, bidi_move_to_visually_next):
2359 Support character positions inside a run of characters covered by a
2361 (bidi_paragraph_init, bidi_resolve_explicit_1)
2362 (bidi_level_of_next_char): Call bidi_fetch_char and
2363 bidi_fetch_char_advance instead of FETCH_CHAR and
2365 (bidi_init_it): Initialize new members.
2366 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2368 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2369 instead of using explicit *_CHAR codes.
2370 (bidi_resolve_explicit, bidi_resolve_weak):
2371 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
2372 bidirectional text is supported only in multibyte buffers.
2373 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2374 it to initialize the frame_window_p member of struct bidi_it.
2375 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2376 (bidi_resolve_explicit, bidi_resolve_weak)
2377 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2378 bidi_it->nchars is non-positive.
2379 (bidi_level_of_next_char): Don't try to lookup the cache for the
2380 next/previous character if nothing is cached there yet, or if we
2381 were just reseat()'ed to a new position.
2383 * xdisp.c (set_cursor_from_row): Set start and stop points
2384 according to the row's direction when priming the loop that looks
2385 for the glyph on which to display cursor.
2386 (single_display_spec_intangible_p): Function deleted.
2387 (display_prop_intangible_p): Reimplement to call
2388 handle_display_spec instead of single_display_spec_intangible_p.
2389 Accept 3 additional arguments needed by handle_display_spec.
2390 This fixes incorrect cursor motion across display property with complex
2391 values: lists, `(when COND...)' forms, etc.
2392 (single_display_spec_string_p): Support property values that are
2393 lists with the argument STRING its top-level element.
2394 (display_prop_string_p): Fix the condition for processing a
2395 property that is a list to be consistent with handle_display_spec.
2396 (handle_display_spec): New function, refactored from the
2397 last portion of handle_display_prop.
2398 (compute_display_string_pos): Accept additional argument
2399 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2400 value of a `display' property is a "replacing spec".
2401 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2402 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2403 the display property, but just return a value indicating whether
2404 the display property will replace the characters it covers.
2405 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2406 frame_window_p members of struct bidi_it.
2407 (compute_display_string_pos, compute_display_string_end):
2409 (push_it): Accept second argument POSITION, where pop_it should
2410 jump to continue iteration.
2411 (reseat_1): Initialize bidi_it.disp_pos.
2413 * keyboard.c (adjust_point_for_property): Adjust the call to
2414 display_prop_intangible_p to its new signature.
2416 * dispextern.h (struct bidi_it): New member frame_window_p.
2417 (bidi_init_it): Update prototypes.
2418 (display_prop_intangible_p): Update prototype.
2419 (compute_display_string_pos, compute_display_string_end):
2421 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2424 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
2426 Malloc failure behavior now depends on size of allocation.
2427 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2428 * lisp.h: Change signatures accordingly.
2429 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2430 All callers changed. (Bug#8762)
2432 * gnutls.c: Use Emacs's memory allocators.
2433 Without this change, the gnutls library would invoke malloc etc.
2434 directly, which causes problems on non-SYNC_INPUT hosts, and which
2435 runs afoul of improving memory_full behavior. (Bug#8761)
2436 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2437 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2438 xfree instead of the default malloc, realloc, free.
2439 (Fgnutls_boot): No need to check for memory allocation failure,
2440 since xmalloc does that for us.
2442 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
2443 * category.c (hash_get_category_set):
2444 * ccl.c (ccl_driver):
2445 * charset.c (Fdefine_charset_internal):
2446 * charset.h (struct charset.hash_index):
2447 * composite.c (get_composition_id, gstring_lookup_cache)
2448 (composition_gstring_put_cache):
2449 * composite.h (struct composition.hash_index):
2450 * dispextern.h (struct image.hash):
2451 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2452 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2453 (hashfn_equal, hashfn_user_defined, make_hash_table)
2454 (maybe_resize_hash_table, hash_lookup, hash_put)
2455 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2456 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2457 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2458 * image.c (make_image, search_image_cache, lookup_image)
2459 (xpm_put_color_table_h):
2460 * lisp.h (struct Lisp_Hash_Table):
2461 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
2462 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
2463 for hashes and hash indexes, instead of 'unsigned' and 'int'.
2464 * alloc.c (allocate_vectorlike):
2465 Check for overflow in vector size calculations.
2466 * ccl.c (ccl_driver):
2467 Check for overflow when converting EMACS_INT to int.
2468 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2469 need to be updated by these changes.
2470 * fns.c (make_hash_table, maybe_resize_hash_table):
2471 Check for integer overflow with large hash tables.
2472 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2473 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2474 (SXHASH_REDUCE): New macro.
2475 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2476 Use it instead of discarding useful hash info with large hash values.
2477 (sxhash_float): New function.
2478 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2479 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
2480 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2481 Rewrite to use FIXNUM_BITS, as this simplifies things.
2482 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2483 Adjust signatures to match updated version of code.
2484 (consing_since_gc): Now EMACS_INT, since a single hash table can
2485 use more than INT_MAX bytes.
2487 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2489 Make it possible to build with GCC-4.6+ -O2 -flto.
2491 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2493 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2495 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2496 Call minibuffer-inactive-mode.
2498 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
2500 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2501 Update dependencies.
2503 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2505 * data.c (init_data): Remove code for UTS, this system is not
2508 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2510 Don't force ./temacs to start in terminal mode.
2512 * frame.c (make_initial_frame): Initialize faces in all cases, not
2513 only when CANNOT_DUMP is defined.
2514 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2516 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2518 * dispnew.c (add_window_display_history): Use const for the string
2519 pointer. Remove declaration, not needed.
2521 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2523 Use 'inline', not 'INLINE'.
2524 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
2525 * alloc.c, fontset.c (INLINE): Remove.
2526 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2527 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2528 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2529 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2530 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2532 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2534 Make it possible to run ./temacs.
2536 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2537 syms_of_callproc does the same thing. Remove test for
2538 "initialized", do it in the caller.
2539 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2541 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2543 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2544 (read_minibuf): Use get_minibuffer.
2545 (syms_of_minibuf): Use DEFSYM.
2546 (Qmetadata): New var.
2547 * data.c (Qbuffer): Don't make it static.
2548 (syms_of_data): Use DEFSYM.
2550 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2552 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2553 (CCL_CODE_MIN): New macro.
2555 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2557 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2559 * eval.c (Qdebug): Now static.
2560 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2561 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2562 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2564 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2566 * image.c: Various fixes to ImageMagick code comments.
2567 (Fimagemagick_types): Doc fix.
2569 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2571 Minor fixes prompted by GCC 4.6.0 warnings.
2573 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2575 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2576 (x_clipboard_manager_save_all): Move extern decl to ...
2577 * xterm.h: ... here, so that it can be checked for consistency.
2579 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2581 * xselect.c (x_clipboard_manager_save_frame)
2582 (x_clipboard_manager_save_all): New functions.
2583 (Fx_clipboard_manager_save): Lisp function deleted.
2585 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2586 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2588 * xterm.h: Update prototype.
2590 2011-05-28 William Xu <william.xwl@gmail.com>
2592 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2595 2011-05-28 Jim Meyering <meyering@redhat.com>
2597 Avoid a sign-extension bug in crypto_hash_function.
2598 * fns.c (to_uchar): Define.
2599 (crypto_hash_function): Use it to convert some newly-signed
2600 variables to unsigned, to avoid sign-extension bugs. For example,
2601 without this change, (md5 "truc") would evaluate to
2602 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2603 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
2604 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
2606 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2608 Integer overflow fixes.
2610 * dbusbind.c: Serial number integer overflow fixes.
2611 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
2612 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2613 to hold a serial number that is too large for a fixnum.
2614 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2615 Check for serial numbers out of range. Decode any serial number
2616 that was so large that it became a float. (Bug#8722)
2618 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2619 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2620 Use XFASTINT rather than XUINT when numbers are nonnegative.
2621 (xd_append_arg, Fdbus_method_return_internal):
2622 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2623 arguments, check that Lisp number is nonnegative, rather than
2624 silently wrapping negative numbers around. (Bug#8722)
2625 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
2628 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2630 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2632 ccl: add integer overflow checks
2633 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2634 (IN_INT_RANGE): New macros.
2635 (ccl_driver): Use them to check for integer overflow when
2636 decoding a CCL program. Many of the new checks are whether XINT (x)
2637 fits in int; it doesn't always, on 64-bit hosts. The new version
2638 doesn't catch all possible integer overflows, but it's an
2639 improvement. (Bug#8719)
2641 * alloc.c (make_event_array): Use XINT, not XUINT.
2642 There's no need for unsigned here.
2644 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2645 This follows up to the 2011-05-06 change that substituted uintptr_t
2646 for EMACS_INT. This case wasn't caught back then.
2648 Rework Fformat to avoid integer overflow issues.
2649 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2650 now (part of C89). Include <verify.h>.
2651 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2652 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2653 (Fformat): Avoid the prepass trying to compute sizes; it was only
2654 approximate and thus did not catch overflow reliably. Instead, walk
2655 through the format just once, formatting and computing sizes as we go,
2656 checking for integer overflow at every step, and allocating a larger
2657 buffer as needed. Keep track separately whether the format is
2658 multibyte. Keep only the most-recently calculated precision, rather
2659 than them all. Record whether each argument has been converted to
2660 string. Use EMACS_INT, not int, for byte and char and arg counts.
2661 Support field widths and precisions larger than INT_MAX. Avoid
2662 sprintf's undefined behavior with conversion specifications such as %#d
2663 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2664 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2665 formatting out-of-range floating point numbers with int
2668 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2670 * data.c: Avoid integer truncation in expressions involving floats.
2671 * data.c: Include <intprops.h>.
2672 (arith_driver): When there's an integer overflow in an expression
2673 involving floating point, convert the integers to floating point
2674 so that the resulting value does not suffer from catastrophic
2675 integer truncation. For example, on a 64-bit host (* 4
2676 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2677 Do not rely on undefined behavior after integer overflow.
2679 merge count_size_as_multibyte, parse_str_to_multibyte
2680 * character.c, character.h (count_size_as_multibyte):
2681 Rename from parse_str_to_multibyte; all uses changed.
2682 Check for integer overflow.
2683 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2684 since it's now a duplicate of the other. This is more of
2685 a character than a buffer op, so better that it's in character.c.
2686 * fns.c, print.c: Adjust to above changes.
2688 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2690 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2692 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2694 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2695 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2696 (x_clipboard_manager_save): Now static.
2697 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2699 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2700 (crypto_hash_function): Now static.
2701 Fix pointer signedness problems. Avoid unnecessary initializations.
2703 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
2705 * termhooks.h (Vselection_alist): Make it terminal-local.
2707 * terminal.c (create_terminal): Initialize it.
2709 * xselect.c: Support for clipboard managers.
2710 (Vselection_alist): Move to termhooks.h as terminal-local var.
2711 (LOCAL_SELECTION): New macro.
2712 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2713 (symbol_to_x_atom): Remove gratuitous arg.
2714 (x_handle_selection_request, lisp_data_to_selection_data)
2715 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
2716 (x_own_selection, x_get_local_selection, x_convert_selection):
2717 New arg, specifying work frame. Use terminal-local Vselection_alist.
2718 (some_frame_on_display): Delete unused function.
2719 (Fx_own_selection_internal, Fx_get_selection_internal)
2720 (Fx_disown_selection_internal, Fx_selection_owner_p)
2721 (Fx_selection_exists_p): New optional frame arg.
2722 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2723 (x_handle_selection_clear): Don't treat other terminals with the
2724 same keyboard specially. Use the terminal-local Vselection_alist.
2725 (x_clear_frame_selections): Use Frun_hook_with_args.
2727 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2729 * xterm.h: Add support for those atoms.
2731 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
2733 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2734 (converted_selections, conversion_fail_tag): New global variables.
2735 (x_selection_request_lisp_error): Free the above.
2736 (x_get_local_selection): Remove unnecessary code.
2737 (x_reply_selection_request): Args changed; handle arbitrary array
2738 of converted selections stored in converted_selections.
2739 Separate the XChangeProperty and SelectionNotify steps.
2740 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2741 (x_convert_selection): New function.
2742 (x_handle_selection_event): Simplify.
2743 (x_get_foreign_selection): Don't ignore incoming requests while
2744 waiting for an answer; this will fail when we implement
2745 SAVE_TARGETS, and seems unnecessary anyway.
2746 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
2747 (Vx_sent_selection_functions): Doc fix.
2749 2011-05-26 Leo Liu <sdl.web@gmail.com>
2751 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
2753 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2755 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
2757 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
2758 for fringe update if it has periodic bitmap.
2759 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
2760 and fringe_bitmap_periodic_p.
2762 * fringe.c (get_fringe_bitmap_data): New function.
2763 (draw_fringe_bitmap_1, update_window_fringes): Use it.
2764 (update_window_fringes): Record periodicity of fringe bitmap in glyph
2765 row. Mark glyph row for fringe update if periodicity changed.
2767 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
2768 for fringe update unless it has periodic bitmap.
2770 2011-05-25 Kenichi Handa <handa@m17n.org>
2772 * xdisp.c (get_next_display_element): Set correct it->face_id for
2773 a static composition.
2775 2011-05-24 Leo Liu <sdl.web@gmail.com>
2778 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
2780 * fns.c (crypto_hash_function, Fsha1): New function.
2781 (Fmd5): Use crypto_hash_function.
2782 (syms_of_fns): Add Ssha1.
2784 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2786 * gnutls.c: Remove unused macros.
2787 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
2788 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
2789 Remove macros that are defined and never used.
2790 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
2792 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
2794 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
2795 (Fx_get_selection_internal): Minor cleanup.
2796 (Fx_own_selection_internal): Rename arguments for consistency with
2799 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2801 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
2803 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
2805 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
2807 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2809 * dispnew.c (scrolling_window): Don't exclude the case that the
2810 last enabled row in the desired matrix touches the bottom boundary.
2812 2011-05-21 Glenn Morris <rgm@gnu.org>
2814 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
2815 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
2816 and add some more files.
2818 2011-05-20 Eli Zaretskii <eliz@gnu.org>
2820 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
2821 report_file_error introduced by the change from 2011-05-07.
2823 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
2825 * systime.h (Time): Define only if emacs is defined.
2826 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
2827 where the include path doesn't have X11/X.h by default. See
2828 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
2830 2011-05-20 Kenichi Handa <handa@m17n.org>
2832 * composite.c (find_automatic_composition): Fix previous change.
2834 2011-05-20 Glenn Morris <rgm@gnu.org>
2836 * lisp.mk: New file, split from Makefile.in.
2837 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
2838 (shortlisp): Remove.
2839 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
2841 2011-05-19 Glenn Morris <rgm@gnu.org>
2843 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
2844 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
2845 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
2846 (lisp): Set the order to that of loadup.el.
2847 (shortlisp): Make it a copy of $lisp.
2848 (SOME_MACHINE_LISP): Remove.
2849 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
2850 Use just $shortlisp, not $SOME_MACHINE_LISP too.
2852 2011-05-18 Kenichi Handa <handa@m17n.org>
2854 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
2855 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
2856 (find_automatic_composition): Mostly rewrite for efficiency.
2858 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
2860 * makefile.w32-in: Update dependencies.
2862 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
2864 * menu.c: Include limits.h (fixes the MS-Windows build broken by
2865 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
2867 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
2869 Fix some integer overflow issues, such as string length overflow.
2871 * insdel.c (count_size_as_multibyte): Check for string overflow.
2873 * character.c (lisp_string_width): Check for string overflow.
2874 Use EMACS_INT, not int, for string indexes and lengths; in
2875 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
2876 the resulting string length overflows an EMACS_INT; instead,
2877 report a string overflow if no precision given. When checking for
2878 precision exhaustion, use a check that cannot possibly have
2879 integer overflow. (Bug#8675)
2880 * character.h (lisp_string_width): Adjust to new signature.
2882 * alloc.c (string_overflow): New function.
2883 (Fmake_string): Use it. This doesn't change behavior, but saves
2884 a few bytes and will simplify future changes.
2885 * character.c (string_escape_byte8): Likewise.
2886 * lisp.h (string_overflow): New decl.
2888 Fixups, following up to the user-interface timestamp change.
2889 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
2890 for UI timestamps, instead of unsigned long.
2891 * msdos.c (mouse_get_pos): Likewise.
2892 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
2893 * w32gui.h (Time): Define by including "systime.h" rather than by
2894 declaring it ourselves. (Bug#8664)
2896 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
2897 * image.c (clear_image_cache): Likewise.
2899 * term.c (term_mouse_position): Don't assume time_t wraparound.
2901 Be more systematic about user-interface timestamps.
2902 Before, the code sometimes used 'Time', sometimes 'unsigned long',
2903 and sometimes 'EMACS_UINT', to represent these timestamps.
2904 This change causes it to use 'Time' uniformly, as that's what X uses.
2905 This makes the code easier to follow, and makes it easier to catch
2906 integer overflow bugs such as Bug#8664.
2907 * frame.c (Fmouse_position, Fmouse_pixel_position):
2908 Use Time, not unsigned long, for user-interface timestamps.
2909 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
2910 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
2911 * keyboard.h (last_event_timestamp): Likewise.
2912 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
2913 * menu.h (xmenu_show): Likewise.
2914 * term.c (term_mouse_position): Likewise.
2915 * termhooks.h (struct input_event.timestamp): Likewise.
2916 (struct terminal.mouse_position_hook): Likewise.
2917 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
2918 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
2919 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
2920 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
2922 * menu.h, termhooks.h: Include "systime.h", for Time.
2924 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
2925 Don't assume that the difference between two unsigned long values
2926 can fit into an integer. At this point, we know button_down_time
2927 <= event->timestamp, so the difference must be nonnegative, so
2928 there's no need to cast the result if double-click-time is
2929 nonnegative, as it should be; check that it's nonnegative, just in
2930 case. This bug is triggered when events are more than 2**31 ms
2931 apart (about 25 days). (Bug#8664)
2933 * xselect.c (last_event_timestamp): Remove duplicate decl.
2934 (x_own_selection): Remove needless cast to unsigned long.
2936 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
2937 that always fit in int. Use a sentinel instead of a counter, to
2938 avoid a temp and to allay GCC's concerns about possible int overflow.
2939 * frame.h (struct frame): Use int for menu_bar_items_used
2940 instead of EMACS_INT, since it always fits in int.
2942 * menu.c (grow_menu_items): Check for int overflow.
2944 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
2946 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
2947 Before, the code was not consistent. These values cannot exceed
2948 2**31 - 1 so there's no need to make them unsigned.
2949 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
2950 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
2951 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
2953 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
2955 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
2956 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
2957 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
2958 presumably because the widths might not match.
2960 * window.c (size_window): Avoid needless test at loop start.
2962 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
2964 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
2966 2011-05-12 Drew Adams <drew.adams@oracle.com>
2968 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
2970 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2972 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
2973 `width' to `bar_area_x' and `bar_area_width', respectively.
2974 (x_scroll_run): Take account of fringe background extension.
2976 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
2977 Rename local vars `left' and `width' to `bar_area_x' and
2978 `bar_area_width', respectively.
2979 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
2980 background extension.
2982 2011-05-10 Jim Meyering <meyering@redhat.com>
2984 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
2986 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
2988 * image.c (Finit_image_library): Return t for built-in image types,
2989 like pbm and xbm. (Bug#8640)
2991 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
2993 * w32menu.c (set_frame_menubar): Fix submenu allocation.
2995 2011-05-07 Eli Zaretskii <eliz@gnu.org>
2997 * w32console.c (Fset_screen_color): Doc fix.
2998 (Fget_screen_color): New function.
2999 (syms_of_ntterm): Defsubr it.
3001 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3002 unlink the temporary file if Fcall_process didn't create it in the
3004 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
3005 child process will be redirected to a file specified with `:file'.
3006 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
3007 cue to call_process_cleanup not to close that handle.
3009 2011-05-07 Ben Key <bkey76@gmail.com>
3011 * makefile.w32-in: The bootstrap-temacs rule now makes use of
3012 one of two shell specific rules, either bootstrap-temacs-CMD or
3013 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
3014 to the previous implementation of the bootstrap-temacs rule.
3015 The bootstrap-temacs-CMD rule is similar to the previous
3016 implementation of the bootstrap-temacs rule except that it
3017 makes use of the ESC_CFLAGS variable instead of the CFLAGS
3020 These changes, along with some changes to nt/configure.bat,
3021 nt/gmake.defs, and nt/nmake.defs, are required to extend my
3022 earlier fix to add support for --cflags and --ldflags options
3023 that include quotes so that it works whether make uses cmd or
3026 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
3028 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
3029 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
3031 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
3032 a string. Handle both cases.
3033 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
3034 (Fdbus_register_method): Use Qinvalid_function.
3036 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3038 * makefile.w32-in: Update dependencies.
3039 (LISP_H): Add inttypes.h and stdin.h.
3040 (PROCESS_H): Add unistd.h.
3042 2011-05-06 Eli Zaretskii <eliz@gnu.org>
3044 * lread.c: Include limits.h (fixes the MS-Windows build broken by
3045 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
3047 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
3049 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
3051 * term.c (vfatal): Remove stray call to va_end.
3052 It's not needed and the C Standard doesn't allow it here anyway.
3054 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
3055 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
3057 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
3060 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
3062 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3064 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
3066 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
3068 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
3070 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
3071 * charset.c (Fdefine_charset_internal): Don't initialize
3072 charset.code_space[15]. The value was garbage, on hosts with
3073 32-bit int (Bug#8600).
3075 * lread.c (read_integer): Be more consistent with string-to-number.
3076 Use string_to_number to do the actual conversion; this avoids
3077 rounding errors and fixes some other screwups. Without this fix,
3078 for example, #x1fffffffffffffff was misread as -2305843009213693952.
3079 (digit_to_number): Move earlier, for benefit of read_integer.
3080 Return -1 if the digit is out of range for the base, -2 if it is
3081 not a digit in any supported base. (Bug#8602)
3083 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
3085 * dispnew.c (scrolling_window): Return 1 if we scrolled,
3086 to match comment at start of function. This also removes a
3087 GCC warning about overflow in a 32+64-bit port.
3089 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
3091 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
3092 Reported by Stefan Monnier in
3093 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
3094 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3095 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
3097 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
3098 (EMACS_UINTPTR): Likewise, with uintptr_t.
3100 * lisp.h: Prefer 64-bit EMACS_INT if available.
3101 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
3102 on 32-bit hosts that have 64-bit int, so that they can access
3104 However, temporarily disable this change unless the temporary
3105 symbol WIDE_EMACS_INT is defined.
3107 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3109 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3110 This removes an assumption that EMACS_INT and long are the same
3111 width as pointers. The assumption is true for Emacs porting targets
3112 now, but we want to make other targets possible.
3113 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3114 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3115 In the rest of the code, change types of integers that hold casted
3116 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3117 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3118 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3119 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3120 No need to cast type when ORing.
3121 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3122 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3123 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3124 assume EMACS_INT is the same width as char *.
3125 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3126 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3127 Remove no-longer-needed casts.
3128 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3129 (xg_tool_bar_help_callback, xg_make_tool_item):
3130 Use EMACS_INTPTR to hold an integer
3131 that will be cast to void *; this can avoid a GCC warning
3132 if EMACS_INT is not the same width as void *.
3133 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3134 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3135 (current_message_1, set_message_1):
3136 Use a local to convert to proper width without a cast.
3137 * xmenu.c (dialog_selection_callback): Likewise.
3139 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3140 Also, don't assume VALBITS / RAND_BITS is less than 5,
3141 and don't rely on undefined behavior when shifting a 1 left into
3143 * lisp.h (get_random): Change signature to match.
3145 * lread.c (hash_string): Use size_t, not int, for hash computation.
3146 Normally we prefer signed values; but hashing is special, because
3147 it's better to use unsigned division on hash table sizes so that
3148 the remainder is nonnegative. Also, size_t is the natural width
3149 for hashing into memory. The previous code used 'int', which doesn't
3150 retain enough info to hash well into very large tables.
3151 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3153 * dbusbind.c: Don't possibly lose pointer info when converting.
3154 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3155 Use XPNTR rather than XHASH, so that the high-order bits of
3156 the pointer aren't lost when converting through void *.
3158 * eval.c (Fautoload): Don't double-shift a pointer.
3160 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3162 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3164 * gnutls.c (DEF_GNUTLS_FN):
3165 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3167 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3169 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3172 2011-05-05 Eli Zaretskii <eliz@gnu.org>
3174 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3175 New version that can reserve upto 2GB of heap space.
3177 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
3179 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3181 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3183 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3184 `gnutls_certificate_set_x509_key_file'.
3186 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
3188 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3189 Update dependencies.
3191 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3193 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3194 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3195 Remove unused parameter `fildes'.
3196 * process.c (read_process_output, send_process): Don't pass it.
3198 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3200 Fix previous change: the library cache is defined in w32.c.
3201 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3202 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3204 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3206 Implement dynamic loading of GnuTLS on Windows.
3208 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3209 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3210 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3213 * gnutls.c (Qgnutls_dll): Define.
3214 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3215 (gnutls_*): Declare function pointers.
3216 (init_gnutls_functions): New function to initialize function pointers.
3217 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3218 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3219 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3220 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3221 (emacs_gnutls_write, emacs_gnutls_read)
3222 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3223 (Fgnutls_available_p): New function.
3224 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3225 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3226 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3228 * image.c: Include w32.h.
3229 (Vimage_type_cache): Delete.
3230 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3231 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3232 (w32_delayed_load): Move to w32.c.
3234 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3236 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3237 (w32_delayed_load): Move from image.c. When loading a library, record
3238 its filename in the :loaded-from property of the library id.
3239 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3240 Initialize and staticpro them.
3241 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3243 * process.c: Include lisp.h before w32.h, not after.
3244 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3245 instead of gnutls_record_check_pending.
3247 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3249 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3251 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3252 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3255 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3257 * xterm.c (x_set_frame_alpha): Do not set property on anything
3258 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3260 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3262 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3264 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3266 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3267 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3268 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3269 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3270 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3271 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3272 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3273 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3274 (Qgnutls_bootprop_callbacks_verify): Make static.
3276 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3278 * callproc.c: Indentation fixup.
3280 * sysdep.c (wait_for_termination_1): Make static.
3281 (wait_for_termination, interruptible_wait_for_termination):
3282 Move after wait_for_termination_1.
3284 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3286 * sysdep.c (interruptible_wait_for_termination): New function
3287 which is like wait_for_termination, but allows keyboard
3290 * callproc.c (Fcall_process): Add (:file "file") as an option for
3292 (Fcall_process_region): Ditto.
3294 2011-04-30 Eli Zaretskii <eliz@gnu.org>
3296 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3297 rather than `XVECTOR (FOO)->size'.
3299 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3300 inttypes.h, as a gnulib replacement is used if it not available in
3303 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3305 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3306 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3307 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3309 * coding.c (coding_alloc_by_realloc): Error out if destination
3310 will grow beyond MOST_POSITIVE_FIXNUM.
3311 (decode_coding_emacs_mule): Abort if there isn't enough place in
3312 charbuf for the composition carryover bytes. Reserve an extra
3313 space for up to 2 characters produced in a loop.
3314 (decode_coding_iso_2022): Abort if there isn't enough place in
3315 charbuf for the composition carryover bytes.
3317 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3319 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3320 aborting when %lld or %lll format is passed.
3321 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3322 %llo or %llx format is passed. (Bug#8545)
3324 * window.c (window_scroll_line_based): Use a marker instead of
3325 simple variables to record original value of point. (Bug#7952)
3327 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3328 produced by %s or %c overflows available buffer space. (Bug#8545)
3330 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3332 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
3333 (SIZE_MAX): Move defn after all includes, as they might #define it.
3335 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3337 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3339 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3341 * keyboard.c (Qdelayed_warnings_hook): Define.
3342 (command_loop_1): Run `delayed-warnings-hook'
3343 if Vdelayed_warnings_list is non-nil.
3344 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3345 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3347 2011-04-28 Eli Zaretskii <eliz@gnu.org>
3349 * doprnt.c (doprnt): Don't return value smaller than the buffer
3350 size if the message was truncated. (Bug#8545).
3352 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3354 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3355 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3357 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3359 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3361 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
3363 * makefile.w32-in: Update dependencies.
3365 2011-04-27 Eli Zaretskii <eliz@gnu.org>
3367 Improve `doprnt' and its usage. (Bug#8545)
3368 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3369 `format_end'. Remove support for %l as a conversion specifier.
3370 Don't use xrealloc. Improve diagnostics when the %l size modifier
3371 is used. Update the commentary.
3373 * eval.c (verror): Simplify calculation of size_t.
3375 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3378 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3380 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3383 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3385 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3386 This makes this file independent of the recent pseudovector change.
3388 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
3390 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3392 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
3393 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
3394 Remove unused local.
3395 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
3397 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
3398 GCC 4.6.0 optimizes based on type-based alias analysis.
3399 For example, if b is of type struct buffer * and v of type struct
3400 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3401 != &v->size, and therefore "v->size = 1; b->size = 2; return
3402 v->size;" must therefore return 1. This assumption is incorrect
3403 for Emacs, since it type-puns struct Lisp_Vector * with many other
3404 types. To fix this problem, this patch adds a new type struct
3405 vectorlike_header that documents the constraints on layout of vectors
3406 and pseudovectors, and helps optimizing compilers not get fooled
3407 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3408 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
3409 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3411 (XSETPVECTYPE): Rewrite in terms of new macro.
3412 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3413 This is a bit clearer, and further avoids the possibility of
3414 undesirable aliasing.
3415 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
3416 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
3417 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3418 since Lisp_Subr is a special case (no "next" field).
3419 (ASIZE): Now uses header.size rather than size.
3420 All previous uses of XVECTOR (foo)->size replaced to use this macro,
3421 to avoid the hassle of writing XVECTOR (foo)->header.size.
3422 (struct vectorlike_header): New type.
3423 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3424 object, to help avoid aliasing.
3425 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3426 (SUBRP): Likewise, since Lisp_Subr is a special case.
3427 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3428 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3429 (struct Lisp_Hash_Table): Combine first two members into a single
3430 struct vectorlike_header member. All uses of "size" and "next" members
3431 changed to be "header.size" and "header.next".
3432 * buffer.h (struct buffer): Likewise.
3433 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3434 * frame.h (struct frame): Likewise.
3435 * process.h (struct Lisp_Process): Likewise.
3436 * termhooks.h (struct terminal): Likewise.
3437 * window.c (struct save_window_data, struct saved_window): Likewise.
3438 * window.h (struct window): Likewise.
3439 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3440 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3441 * buffer.c (init_buffer_once): Likewise.
3442 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3444 * process.c (Fformat_network_address): Use local var for size,
3447 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3449 Make the Lisp reader and string-to-float more consistent (Bug#8525)
3450 * data.c (atof): Remove decl; no longer used or needed.
3451 (digit_to_number): Move to lread.c.
3452 (Fstring_to_number): Use new string_to_number function, to be
3453 consistent with how the Lisp reader treats infinities and NaNs.
3454 Do not assume that floating-point numbers represent EMACS_INT
3455 without losing information; this is not true on most 64-bit hosts.
3456 Avoid double-rounding errors, by insisting on integers when
3457 parsing non-base-10 numbers, as the documentation specifies.
3458 * lisp.h (string_to_number): New decl, replacing ...
3459 (isfloat_string): Remove.
3460 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
3461 (read1): Do not accept +. and -. as integers; this
3462 appears to have been a coding error. Similarly, do not accept
3463 strings like +-1e0 as floating point numbers. Do not report
3464 overflow for integer overflows unless the base is not 10 which
3465 means we have no simple and reliable way to continue.
3466 Break out the floating-point parsing into a new
3467 function string_to_number, so that Fstring_to_number parses
3468 floating point numbers consistently with the Lisp reader.
3469 (digit_to_number): Move here from data.c. Make it static inline.
3470 (E_CHAR, EXP_INT): Remove, replacing with ...
3471 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3472 (string_to_number): New function, replacing isfloat_string.
3473 This function checks for valid syntax and produces the resulting
3474 Lisp float number too. Rework it so that string-to-number
3475 no longer mishandles examples like "1.0e+". Use strtoumax,
3476 so that overflow for non-base-10 numbers is reported only when
3477 there's no portable and simple way to convert to floating point.
3479 * textprop.c (set_text_properties_1): Rewrite for clarity,
3480 and to avoid GCC warning about integer overflow.
3482 * intervals.h (struct interval): Use EMACS_INT for members
3483 where EMACS_UINT might cause problems. See
3484 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3485 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3486 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3488 (offset_intervals): Tell GCC not to worry about length overflow
3489 when negating a negative length.
3491 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3492 (overrun_check_free): Likewise.
3494 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3495 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3498 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3499 (gnutls_make_error): Rename local to avoid shadowing.
3500 (gnutls_emacs_global_deinit): ifdef out; not used.
3501 (Fgnutls_boot): Use const for pointer to readonly storage.
3502 Comment out unused local. Fix pointer signedness problems.
3504 * lread.c (openp): Don't stuff size_t into an 'int'.
3505 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3506 about possible signed overflow.
3508 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3509 (GDK_KEY_g): Don't define if already defined.
3510 (xg_prepare_tooltip): Avoid pointer signedness problem.
3511 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3513 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3514 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3516 * xfns.c (Fx_window_property): Simplify a bit,
3517 to make a bit faster and to avoid GCC 4.6.0 warning.
3518 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3520 * fns.c (internal_equal): Don't assume size_t fits in int.
3522 * alloc.c (compact_small_strings): Tighten assertion a little.
3524 Replace pEd with more-general pI, and fix some printf arg casts.
3525 * lisp.h (pI): New macro, generalizing old pEd macro to other
3526 conversion specifiers. For example, use "...%"pI"d..." rather
3527 than "...%"pEd"...".
3528 (pEd): Remove. All uses replaced with similar uses of pI.
3529 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3530 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3531 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3532 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3533 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3534 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3535 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3537 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3538 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3539 * print.c (safe_debug_print, print_object): Likewise.
3540 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3542 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3543 avoiding the 0 flag, which is not portable.
3544 * process.c (Fmake_network_process): Use pI to avoid cast.
3545 * region-cache.c (pp_cache): Likewise.
3546 * xdisp.c (decode_mode_spec): Likewise.
3547 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3548 behavior on 64-bit hosts with printf arg.
3549 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
3550 (x_stop_queuing_selection_requests): Likewise.
3551 (x_get_window_property): Don't truncate byte count to an 'int'
3554 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3555 here, since it parses constructs like leading '-' and spaces,
3556 which are not wanted; and it overflows with large numbers.
3557 Instead, simply match F[0-9]+, which is what is wanted anyway.
3559 * alloc.c: Remove unportable assumptions about struct layout.
3560 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3561 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3562 (allocate_vectorlike, make_pure_vector): Use the new macros,
3563 plus offsetof, to remove unportable assumptions about struct layout.
3564 These assumptions hold on all porting targets that I know of, but
3565 they are not guaranteed, they're easy to remove, and removing them
3566 makes further changes easier.
3568 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3569 This doesn't fix a bug but makes the code clearer.
3570 (string_overrun_cookie): Now const. Use initializers that
3571 don't formally overflow signed char, to avoid warnings.
3572 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3573 can cause Emacs to crash when string overrun checking is enabled.
3574 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3575 multiple of sizeof (EMACS_INT); it need not be, if
3576 alignof(EMACS_INT) < sizeof (EMACS_INT).
3577 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
3579 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
3581 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3583 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3585 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
3586 supposed to be handshaking. (Bug#8556)
3587 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3589 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
3591 * lisp.h (Qdebug): List symbol.
3592 * eval.c (Qdebug): Restore global linkage.
3593 * keyboard.c (debug-on-event): New variable.
3594 (handle_user_signal): Break into debugger when debug-on-event
3595 matches the current signal symbol.
3597 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3599 * alloc.c (check_sblock, check_string_bytes)
3600 (check_string_free_list): Convert to standard C.
3602 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3604 * w32.c (emacs_gnutls_push): Fix typo.
3606 2011-04-25 Eli Zaretskii <eliz@gnu.org>
3608 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3609 "cast to pointer from integer of different size".
3611 Improve doprnt and its use in verror. (Bug#8545)
3612 * doprnt.c (doprnt): Document the set of format control sequences
3613 supported by the function. Use SAFE_ALLOCA instead of always
3616 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3617 is one byte too soon. Don't use xrealloc; instead xfree and
3620 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3622 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3625 * gnutls.c: Renamed global_initialized to
3626 gnutls_global_initialized. Added internals for the
3627 :verify-hostname-error, :verify-error, and :verify-flags
3628 parameters of `gnutls-boot' and documented those parameters in the
3629 docstring. Start callback support.
3630 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3631 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3632 on error. Return error code.
3633 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3634 (emacs_gnutls_read): Likewise.
3635 (Fgnutls_boot): Return handshake error code.
3636 (emacs_gnutls_handle_error): New function.
3637 (wsaerror_to_errno): Likewise.
3639 * w32.h (emacs_gnutls_pull): Add prototype.
3640 (emacs_gnutls_push): Likewise.
3642 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3643 (emacs_gnutls_push): Likewise.
3645 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3647 * process.c (wait_reading_process_output): Check if GnuTLS
3648 buffered some data internally if no FDs are set for TLS
3651 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3652 (LIBS): Link to USER_LIBS.
3653 ($(BLD)/gnutls.$(0)): New target.
3655 2011-04-24 Eli Zaretskii <eliz@gnu.org>
3657 * xdisp.c (handle_single_display_spec): Rename the
3658 display_replaced_before_p argument into display_replaced_p, to
3659 make it consistent with the commentary. Fix typos in the
3662 * textprop.c (syms_of_textprop): Remove dead code.
3663 (copy_text_properties): Delete obsolete commentary about an
3664 interface that was deleted long ago. Fix typos in the description
3667 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3668 to changes in oldXMenu/XMenu.h from 2011-04-16.
3669 <menu_help_message, prev_menu_help_message>: Constify.
3670 (IT_menu_make_room): menu->help_text is now `const char **';
3673 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3674 to changes in oldXMenu/XMenu.h from 2011-04-16.
3675 (struct XMenu): Declare `help_text' `const char **'.
3677 * xfaces.c <Qunspecified>: Make extern again.
3679 * syntax.c: Include sys/types.h before including regex.h, as
3682 * doc.c (get_doc_string): Improve the format passed to `error'.
3684 * doprnt.c (doprnt): Improve commentary.
3686 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3688 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3691 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3692 changes in globals.h immediately force recompilation.
3693 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3694 $(CURDIR)/s/ms-w32.h.
3695 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
3697 * character.c (Fchar_direction): Function deleted.
3698 (syms_of_character): Don't defsubr it.
3699 <char-direction-table>: Deleted.
3701 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3703 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3704 * doprnt.c: Include limits.h.
3705 (SIZE_MAX): New macro.
3706 (doprnt): Return a size_t value. 2nd arg is now size_t.
3707 Many local variables are now size_t instead of int or unsigned.
3708 Improve overflow protection. Support `l' modifier for integer
3709 conversions. Support %l conversion. Don't assume an EMACS_INT
3710 argument for integer conversions and for %c.
3712 * lisp.h (doprnt): Restore prototype.
3714 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3717 * Makefile.in (base_obj): Add back doprnt.o.
3719 * deps.mk (doprnt.o): Add back prerequisites.
3720 (callint.o): Depend on character.h.
3722 * eval.c (internal_lisp_condition_case): Include the handler
3723 representation in the error message.
3724 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3725 when breaking from the loop.
3727 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3729 * callint.c (Fcall_interactively): When displaying error message
3730 about invalid control letter, pass the character's codepoint, not
3731 a pointer to its multibyte form. Improve display of the character
3732 in octal and display also its hex code.
3734 * character.c (char_string): Use %x to display the (unsigned)
3735 codepoint of an invalid character, to avoid displaying a bogus
3738 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3739 `error', not SYMBOL_NAME itself.
3741 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3742 character arguments to `error'.
3744 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3745 to `error' in error message about FINAL_CHAR argument. Make sure
3746 FINAL_CHAR is a character, and use %c when it is passed as
3747 argument to `error'.
3749 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3751 * s/ms-w32.h (localtime): Redirect to sys_localtime.
3753 * w32.c: Include <time.h>.
3754 (sys_localtime): New function.
3756 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
3758 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
3760 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
3762 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
3764 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
3767 2011-04-19 Eli Zaretskii <eliz@gnu.org>
3769 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
3770 gl_state.e_property when gl_state.object is Qt.
3772 * insdel.c (make_gap_larger): Remove limitation of buffer size
3775 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
3777 * xdisp.c (lookup_glyphless_char_display)
3778 (produce_glyphless_glyph): Handle cons cell entry in
3779 glyphless-char-display.
3780 (Vglyphless_char_display): Document it.
3782 * term.c (produce_glyphless_glyph): Handle cons cell entry in
3783 glyphless-char-display.
3785 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
3787 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
3789 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
3791 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
3792 definition for no-X builds.
3794 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
3796 Static checks with GCC 4.6.0 and non-default toolkits.
3798 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
3800 * process.c (keyboard_bit_set): Define only if SIGIO.
3801 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
3802 (send_process): Repair possible setjmp clobbering.
3804 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
3806 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
3808 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
3810 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
3811 Define only if needed.
3813 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
3814 by pacifying GCC about it. Maybe it's time to retire it?
3815 * xfaces.c (USG, __TIMEVAL__): Likewise.
3817 * dispextern.h (struct redisplay_interface): Rename param
3819 * termhooks.h (struct terminal): Likewise.
3820 * xterm.c (xembed_send_message): Likewise.
3822 * insdel.c (make_gap_smaller): Define only if
3823 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
3825 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
3828 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
3829 so that we aren't warned about unused symbols.
3831 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
3833 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
3835 * xfns.c (x_real_positions): Mark locals as initialized.
3837 * xmenu.c (xmenu_show): Don't use uninitialized vars.
3839 * xterm.c: Fix problems found by static analysis with other toolkits.
3840 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
3841 (x_dispatch_event): Declare static if USE_GTK, and
3842 define if USE_GTK || USE_X_TOOLKIT.
3843 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
3844 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
3845 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
3846 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
3848 * xmenu.c (menu_help_callback): Pointer type fixes.
3849 Use const pointers when pointing at readonly data. Avoid pointer
3851 (FALSE): Remove unused macro.
3852 (update_frame_menubar): Remove unused decl.
3854 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
3856 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
3857 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
3858 (single_menu_item): Rename local to avoid shadowing.
3860 * keyboard.c (make_lispy_event): Remove unused local var.
3862 * frame.c, frame.h (x_get_resource_string): Bring this back, but
3863 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
3865 * bitmaps: Change bitmaps from unsigned char back to the X11
3866 compatible char. Avoid the old compiler warnings about
3867 out-of-range initializers by using, for example, '\xab' rather
3870 * xgselect.c (xgselect_initialize): Check vs interface
3871 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
3873 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
3875 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
3876 to read-only memory.
3878 * fns.c (vector): Remove; this old hack is no longer needed.
3880 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
3882 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
3884 * xrdb.c (x_load_resources): Omit unused local.
3886 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
3887 (x_window): Rename locals to avoid shadowing.
3888 (USG): Use the kludged USG macro, to pacify gcc.
3890 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
3891 (x_term_init): Remove local to avoid shadowing.
3893 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
3895 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
3896 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
3898 2011-04-16 Eli Zaretskii <eliz@gnu.org>
3900 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
3902 Fix regex.c, syntax.c and friends for buffers > 2GB.
3903 * syntax.h (struct gl_state_s): Declare character position members
3906 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
3908 * textprop.c (verify_interval_modification, interval_of):
3909 Declare arguments EMACS_INT.
3911 * intervals.c (adjust_intervals_for_insertion): Declare arguments
3914 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
3916 * indent.c (Fvertical_motion): Local variable it_start is now
3919 * regex.c (re_match, re_match_2, re_match_2_internal)
3920 (bcmp_translate, regcomp, regexec, print_double_string)
3921 (group_in_compile_stack, re_search, re_search_2, regex_compile)
3922 (re_compile_pattern, re_exec): Declare arguments and local
3923 variables `size_t' and `ssize_t' and return values `regoff_t', as
3925 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
3926 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
3927 <compile_stack_type>: `size' and `avail' are now `size_t'.
3929 * regex.h <regoff_t>: Use ssize_t, not int.
3930 (re_search, re_search_2, re_match, re_match_2): Arguments that
3931 specify buffer/string position and length are now ssize_t and
3932 size_t. Return type is regoff_t.
3934 2011-04-16 Ben Key <bkey76@gmail.com>
3936 * nsfont.m: Fixed bugs in ns_get_family and
3937 ns_descriptor_to_entity that were caused by using free to
3938 deallocate memory blocks that were allocated by xmalloc (via
3939 xstrdup). This caused Emacs to crash when compiled with
3940 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
3941 --enable-checking=xmallocoverrun). xfree is now used to
3942 deallocate these memory blocks.
3944 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3946 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
3948 emacs_write: Accept and return EMACS_INT for sizes.
3949 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
3951 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
3952 Accept and return EMACS_INT.
3953 (emacs_gnutls_write): Return the number of bytes written on
3955 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
3956 (emacs_read, emacs_write): Remove check for negative size, as the
3957 Emacs source code has been audited now.
3958 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
3959 (emacs_read, emacs_write): Use it.
3960 * process.c (send_process): Adjust to the new signatures of
3961 emacs_write and emacs_gnutls_write. Do not attempt to store
3962 a byte offset into an 'int'; it might overflow.
3963 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
3965 * sound.c: Don't assume sizes fit in 'int'.
3966 (struct sound_device.period_size, alsa_period_size):
3967 Return EMACS_INT, not int.
3968 (struct sound_device.write, vox_write, alsa_write):
3969 Accept EMACS_INT, not int.
3970 (wav_play, au_play): Use EMACS_INT to store sizes and to
3971 record read return values.
3973 2011-04-15 Ben Key <bkey76@gmail.com>
3975 * keyboard.c (Qundefined): Don't declare static since it is used
3977 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
3978 static since they are used in nsfont.m.
3980 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
3982 * process.c (Qprocessp): Don't declare static.
3983 * lisp.h (Qprocessp): Declare again.
3985 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
3987 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
3989 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
3991 Improve C-level modularity by making more things 'static'.
3993 Don't publish debugger-only interfaces to other modules.
3994 * lisp.h (safe_debug_print, debug_output_compilation_hack):
3995 (verify_bytepos, count_markers): Move decls to the only modules
3997 * region-cache.h (pp_cache): Likewise.
3998 * window.h (check_all_windows): Likewise.
3999 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4001 * sysdep.c (croak): Now static, if
4002 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4003 * syssignal.h (croak): Declare only if not static.
4005 * alloc.c (refill_memory_reserve): Now static if
4006 !defined REL_ALLOC || defined SYSTEM_MALLOC.
4007 * lisp.h (refill_memory_reserve): Declare only if not static.
4009 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
4010 Define only if USE_LUCID.
4012 * xrdb.c (x_customization_string, x_rm_string): Now static.
4014 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4015 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
4017 * xdisp.c (draw_row_with_mouse_face): Now static.
4018 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
4020 * window.h (check_all_windows): Mark externally visible.
4022 * window.c (window_deletion_count): Now static.
4024 * undo.c: Make symbols static if they're not exported.
4025 (last_undo_buffer, last_boundary_position, pending_boundary):
4028 * textprop.c (interval_insert_behind_hooks): Now static.
4029 (interval_insert_in_front_hooks): Likewise.
4031 * term.c: Make symbols static if they're not exported.
4032 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
4033 (max_frame_lines, tty_set_terminal_modes):
4034 (tty_reset_terminal_modes, tty_turn_off_highlight):
4035 (get_tty_terminal): Now static.
4036 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
4037 * termhooks.h (term_mouse_moveto): Do not declare if
4039 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
4040 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
4042 * sysdep.c: Make symbols static if they're not exported.
4043 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
4045 (sigprocmask_set, full_mask): Remove; unused.
4046 (wait_debugging): Mark as visible.
4047 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
4048 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
4050 * syntax.c (syntax_temp): Define only if !__GNUC__.
4052 * sound.c (current_sound_device, current_sound): Now static.
4054 * search.c (searchbufs, searchbuf_head): Now static.
4056 * scroll.c (scroll_cost): Remove; unused.
4057 * dispextern.h (scroll_cost): Remove decl.
4059 * region-cache.h (pp_cache): Mark as externally visible.
4061 * process.c: Make symbols static if they're not exported.
4062 (process_tick, update_tick, create_process, chan_process):
4063 (Vprocess_alist, proc_buffered_char, datagram_access):
4064 (fd_callback_data, send_process_frame, process_sent_to): Now static.
4065 (deactivate_process): Mark defn as static, as well as decl.
4066 * lisp.h (create_process): Remove decl.
4067 * process.h (chan_process, Vprocess_alist): Remove decls.
4069 * print.c: Make symbols static if they're not exported.
4070 (print_depth, new_backquote_output, being_printed, print_buffer):
4071 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
4072 (print_interval, print_number_index, initial_stderr_stream):
4074 * lisp.h (Fprinc): Remove decl.
4075 (debug_output_compilation_hack): Mark as externally visible.
4077 * sysdep.c (croak): Move decl from here to syssignal.h.
4078 * syssignal.h (croak): Put it here, so the API can be checked when
4079 'croak' is called from dissociate_if_controlling_tty.
4081 * minibuf.c: Make symbols static if they're not exported.
4082 (minibuf_save_list, choose_minibuf_frame): Now static.
4083 * lisp.h (choose_minibuf_frame): Remove decl.
4085 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
4087 * lread.c: Make symbols static if they're not exported.
4088 (read_objects, initial_obarray, oblookup_last_bucket_number):
4090 (make_symbol): Remove; unused.
4091 * lisp.h (initial_obarray, make_symbol): Remove decls.
4093 * keyboard.c: Make symbols static if they're not exported.
4094 (single_kboard, recent_keys_index, total_keys, recent_keys):
4095 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
4096 (this_single_command_key_start, echoing, last_auto_save):
4097 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
4098 (command_loop, echo_now, keyboard_init_hook, help_char_p):
4099 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
4100 (Vlispy_mouse_stem, double_click_count):
4102 (force_auto_save_soon): Define only if SIGDANGER.
4103 (ignore_mouse_drag_p): Now static if
4104 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
4105 (print_help): Remove; unused.
4106 (stop_character, last_timer_event): Mark as externally visible.
4107 * keyboard.h (ignore_mouse_drag_p): Declare only if
4108 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4109 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4110 * lisp.h (echoing): Remove decl.
4111 (force_auto_save_soon): Declare only if SIGDANGER.
4112 * xdisp.c (redisplay_window): Simplify code, to make it more
4113 obvious that ignore_mouse_drag_p is not accessed if !defined
4114 USE_GTK && !defined HAVE_NS.
4116 * intervals.c: Make symbols static if they're not exported.
4117 (merge_properties_sticky, merge_interval_right, delete_interval):
4119 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4121 * insdel.c: Make symbols static if they're not exported.
4122 However, leave prepare_to_modify_buffer alone. It's never
4123 called from outside this function, but that appears to be a bug.
4124 (combine_after_change_list, combine_after_change_buffer):
4125 (adjust_after_replace, signal_before_change): Now static.
4126 (adjust_after_replace_noundo): Remove; unused.
4127 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4128 (signal_before_change): Remove decls.
4130 * indent.c (val_compute_motion, val_vmotion): Now static.
4132 * image.c: Make symbols static if they're not exported.
4133 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4135 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4136 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4138 * fringe.c (standard_bitmaps): Now static.
4139 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4141 * frame.c: Make symbols static if they're not exported.
4142 (x_report_frame_params, make_terminal_frame): Now static.
4143 (get_frame_param): Now static, unless HAVE_NS.
4144 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4145 (x_get_resource_string): Remove; not used.
4146 * frame.h (make_terminal_frame, x_report_frame_params):
4147 (x_get_resource_string); Remove decls.
4148 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4149 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4151 * font.c, fontset.c: Make symbols static if they're not exported.
4152 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4153 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4154 * font.c (font_close_object): Now static.
4155 * font.h (font_close_object): Remove.
4156 * fontset.c (FONTSET_OBJLIST): Remove.
4157 (free_realized_fontset) #if-0 the body, which does nothing.
4158 (face_suitable_for_char_p): #if-0, as it's never called.
4159 * fontset.h (face_suitable_for_char_p): Remove decl.
4160 * xfaces.c (face_at_string_position):
4161 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
4162 since 0 is always ASCII.
4164 * fns.c (weak_hash_tables): Now static.
4166 * fileio.c: Make symbols static if they're not exported.
4167 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4168 (Vwrite_region_annotation_buffers): Now static.
4170 * eval.c: Make symbols static if they're not exported.
4171 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4172 * lisp.h (backtrace_list): Remove decl.
4174 * emacs.c: Make symbols static if they're not exported.
4175 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4176 (fatal_error_code, fatal_error_signal_hook, standard_args):
4178 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4179 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4180 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4181 * lisp.h (fatal_error_signal_hook): Remove decl.
4182 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4184 * editfns.c: Move a (normally-unused) function to its only use.
4185 * editfns.c, lisp.h (get_operating_system_release): Remove.
4186 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4187 worth the hassle of breaking this out.
4189 * xterm.c: Make symbols static if they're not exported.
4190 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4191 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4192 (x_destroy_window, x_delete_display):
4194 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4195 (x_mouse_leave): Remove; unused.
4196 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4197 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4198 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4200 (x_mouse_leave): Declare only if WINDOWSNT.
4201 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4202 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4205 * ftxfont.c: Make symbols static if they're not exported.
4206 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4208 * font.h (ftxfont_driver): Likewise.
4210 * xfns.c: Make symbols static if they're not exported.
4211 (x_last_font_name, x_display_info_for_name):
4212 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4213 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4214 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4215 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4216 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4217 (last_show_tip_args): Now static.
4218 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4219 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4220 (x_screen_planes): Remove; unused.
4221 * dispextern.h (x_screen_planes): Remove decl.
4223 * dispnew.c: Make symbols static if they're not exported.
4224 * dispextern.h (redraw_garbaged_frames, scrolling):
4225 (increment_row_positions): Remove.
4226 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4227 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4229 (redraw_garbaged_frames): Remove; unused.
4231 * xfaces.c: Make symbols static if they're not exported.
4232 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4234 * xterm.h (defined_color): Remove decls.
4235 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4236 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4237 (menu_face_changed_default, defined_color, free_realized_face):
4238 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4239 (ascii_face_of_lisp_face): Remove; unused.
4241 * xdisp.c: Make symbols static if they're not exported.
4242 * dispextern.h (scratch_glyph_row, window_box_edges):
4243 (glyph_to_pixel_coords, set_cursor_from_row):
4244 (get_next_display_element, set_iterator_to_next):
4245 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4246 (show_mouse_face): Remove decls
4247 * frame.h (message_buf_print): Likewise.
4248 * lisp.h (pop_message, set_message, check_point_in_composition):
4250 * xterm.h (set_vertical_scroll_bar): Likewise.
4251 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4252 (message_buf_print, scratch_glyph_row, displayed_buffer):
4253 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4254 (get_next_display_element, show_mouse_face, window_box_edges):
4255 (frame_to_window_pixel_xy, check_point_in_composition):
4256 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4257 (glyph_to_pixel_coords): Remove; unused.
4259 * dired.c (file_name_completion): Now static.
4261 * dbusbind.c (xd_in_read_queued_messages): Now static.
4263 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4264 * data.c (circular_list_error): Remove.
4266 * commands.h (last_point_position, last_point_position_buffer):
4267 (last_point_position_window): Remove decls.
4268 * keyboard.c: Make these variables static.
4270 * coding.h (coding, code_convert_region, encode_coding_gap):
4272 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4273 (iso_code_class, detect_coding, code_convert_region): Now static.
4274 (encode_coding_gap): Remove; unused.
4276 * chartab.c (chartab_chars, chartab_bits): Now static.
4278 * charset.h (charset_iso_8859_1): Remove decl.
4279 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4282 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4283 * ccl.c (Vccl_program_table): Now static.
4284 (check_ccl_update): Remove; unused.
4286 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4287 * category.h: ... from here.
4288 * category.c (check_category_table, set_category_set): Now static.
4290 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4291 * lisp.h: Remove these decls.
4293 * buffer.c (buffer_count): Remove unused var.
4295 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4296 so that it's not optimized away.
4297 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4298 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4299 exported only to the debugger.
4301 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
4302 * atimer.h (run_all_atimers): Remove; not exported.
4304 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4305 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4306 was inaccessible from Lisp.
4307 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4308 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4310 alloc.c: Import and export fewer symbols, and remove unused items.
4311 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4313 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4314 it's not optimized away by whole-program optimization.
4315 (message_enable_multibyte, free_misc): Remove.
4316 (catchlist, handlerlist, mark_backtrace):
4317 Declare only if BYTE_MARK_STACK.
4318 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4319 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4320 (message_enable_multibyte): Remove decl.
4321 (free_misc, interval_free_list, float_block, float_block_index):
4322 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4323 (cons_free_list, last_marked_index):
4325 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4326 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4327 (mark_backtrace): Define only if BYTE_MARK_STACK.
4328 * xdisp.c (message_enable_multibyte): Now static.
4330 Declare Lisp_Object Q* variables to be 'static' if not exported.
4331 This makes it easier for human readers (and static analyzers)
4332 to see whether these variables are used from other modules.
4333 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4334 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4335 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4336 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4337 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4338 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4339 * xmenu.c, xselect.c:
4340 Declare Q* vars static if they are not used in other modules.
4341 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4342 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4343 Remove decls of unexported vars.
4344 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4346 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4348 Make Emacs functions such as Fatom 'static' by default.
4349 This makes it easier for human readers (and static analyzers)
4350 to see whether these functions can be called from other modules.
4351 DEFUN now defines a static function. To make the function external
4352 so that it can be used in other C modules, use the new macro DEFUE.
4353 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4354 (Finit_image_library):
4355 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4356 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4357 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4358 Remove decls, since these functions are now static.
4359 (Funintern, Fget_internal_run_time): New decls, since these functions
4360 were already external.
4362 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4363 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4364 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4365 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4366 * keyboard.c, keymap.c, lread.c:
4367 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4368 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4369 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4370 Mark functions with DEFUE instead of DEFUN,
4371 if they are used in other modules.
4372 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4373 decls for now-static functions.
4374 * buffer.h (Fdelete_overlay): Remove decl.
4375 * callproc.c (Fgetenv_internal): Mark as internal.
4376 * composite.c (Fremove_list_of_text_properties): Remove decl.
4377 (Fcomposition_get_gstring): New forward static decl.
4378 * composite.h (Fcomposite_get_gstring): Remove decl.
4379 * dired.c (Ffile_attributes): New forward static decl.
4380 * doc.c (Fdocumntation_property): New forward static decl.
4381 * eval.c (Ffetch_bytecode): New forward static decl.
4382 (Funintern): Remove extern decl; now in .h file where it belongs.
4383 * fileio.c (Fmake_symbolic_link): New forward static decl.
4384 * image.c (Finit_image_library): New forward static decl.
4385 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4386 * intervals.h (Fprevious_property_change):
4387 (Fremove_list_of_text_properties): Remove decls.
4388 * keyboard.c (Fthis_command_keys): Remove decl.
4389 (Fcommand_execute): New forward static decl.
4390 * keymap.c (Flookup_key): New forward static decl.
4391 (Fcopy_keymap): Now static.
4392 * keymap.h (Flookup_key): Remove decl.
4393 * process.c (Fget_process): New forward static decl.
4394 (Fprocess_datagram_address): Mark as internal.
4395 * syntax.c (Fsyntax_table_p): New forward static decl.
4396 (skip_chars): Remove duplicate decl.
4397 * textprop.c (Fprevious_property_change): New forward static decl.
4398 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4400 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4401 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4403 * editfns.c (Fformat): Remove unreachable code.
4405 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4407 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4410 2011-04-13 Eli Zaretskii <eliz@gnu.org>
4412 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4413 when at ZV. (Bug#8487)
4415 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4417 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4419 * keyboard.c (parse_tool_bar_item): Likewise.
4420 * sound.c (sound_cleanup, alsa_close): Likewise.
4421 * termcap.c (tgetent): Likewise.
4422 * xfns.c (x_default_font_parameter): Likewise.
4423 * xsettings.c (read_and_apply_settings): Likewise.
4425 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4426 (overrun_check_free): Protoize.
4428 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4430 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4431 since callers should never pass a negative size.
4432 Change the signature to match that of plain 'read' and 'write'; see
4433 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4434 * lisp.h: Update prototypes of emacs_write and emacs_read.
4436 2011-04-11 Eli Zaretskii <eliz@gnu.org>
4438 * xdisp.c (redisplay_window): Don't try to determine the character
4439 position of the scroll margin if the window start point w->startp
4440 is outside the buffer's accessible region. (Bug#8468)
4442 2011-04-10 Eli Zaretskii <eliz@gnu.org>
4444 Fix write-region and its subroutines for buffers > 2GB.
4445 * fileio.c (a_write, e_write): Modify declaration of arguments and
4446 local variables to support buffers larger than 2GB.
4447 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4449 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4450 argument, local variables, and return value.
4452 * lisp.h: Update prototypes of emacs_write and emacs_read.
4454 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4456 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
4458 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4460 Fix more problems found by GCC 4.6.0's static checks.
4462 * xdisp.c (vmessage): Use a better test for character truncation.
4464 * charset.c (load_charset_map): <, not <=, for optimization,
4465 and to avoid potential problems with integer overflow.
4466 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
4467 * casetab.c (set_identity, shuffle): Likewise.
4468 * editfns.c (Fformat): Likewise.
4469 * syntax.c (skip_chars): Likewise.
4471 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4472 This also lets GCC 4.6.0 generate slightly better loop code.
4474 * callint.c (Fcall_interactively): <, not <=, for optimization.
4475 (Fcall_interactively): Count the number of arguments produced,
4476 not the number of arguments given. This is simpler and lets GCC
4477 4.6.0 generate slightly better code.
4479 * ftfont.c: Distingish more carefully between FcChar8 and char.
4480 The previous code passed unsigned char * to a functions like
4481 strlen and xstrcasecmp that expect char *, which does not
4482 conform to the C standard.
4483 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4484 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4485 char * when the C standard requires it.
4487 * keyboard.c (read_char): Remove unused var.
4489 * eval.c: Port to Windows vsnprintf (Bug#8435).
4491 (SIZE_MAX): Define if the headers do not.
4492 (verror): Do not give up if vsnprintf returns a negative count.
4493 Instead, grow the buffer. This ports to Windows vsnprintf, which
4494 does not conform to C99. Problem reported by Eli Zaretskii.
4495 Also, simplify the allocation scheme, by avoiding the need for
4496 calling realloc, and removing the ALLOCATED variable.
4498 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4500 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4501 But keep the doprint source code for now, as we might revamp it
4502 and use it again (Bug#8435).
4503 * lisp.h (doprnt): Remove.
4504 * Makefile.in (base_obj): Remove doprnt.o.
4505 * deps.mk (doprnt.o): Remove.
4507 error: Print 32- and 64-bit integers portably (Bug#8435).
4508 Without this change, on typical 64-bit hosts error ("...%d...", N)
4509 was used to print both 32- and 64-bit integers N, which relied on
4511 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4513 * lisp.h (error, verror): Mark as printf-like functions.
4514 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4515 Report overflow in size calculations when allocating printf buffer.
4516 Do not truncate output string at its first null byte.
4517 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4518 Truncate the output at a character boundary, since vsnprintf does not
4520 * charset.c (check_iso_charset_parameter): Convert internal
4521 character to string before calling 'error', since %c now has the
4523 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4524 overflow when computing char to be passed to 'error'. Do not
4525 pass Lisp_Object to 'error'; pass the integer instead.
4526 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4527 formatted with plain %d.
4529 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4531 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4533 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4535 * xterm.c (x_catch_errors): Remove duplicate declaration.
4537 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4539 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4541 2011-04-10 Jim Meyering <meyering@redhat.com>
4543 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4544 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4545 return ssize_t not "int", and use size_t as the buffer length.
4546 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4547 * gnutls.h: Update declarations.
4548 * process.c (read_process_output): Use ssize_t, to match.
4549 (send_process): Likewise.
4551 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4553 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4555 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4557 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4558 Use unsigned char, to match FcChar8 type definition.
4560 * xterm.c (handle_one_xevent):
4561 * xmenu.c (create_and_show_popup_menu):
4562 * xselect.c (x_decline_selection_request)
4563 (x_reply_selection_request): Avoid type-punned deref of X events.
4565 2011-04-09 Eli Zaretskii <eliz@gnu.org>
4567 Fix some uses of `int' instead of EMACS_INT.
4568 * search.c (string_match_1, fast_string_match)
4569 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4570 (scan_buffer, find_next_newline_no_quit)
4571 (find_before_next_newline, search_command, Freplace_match)
4572 (Fmatch_data): Make some `int' variables be EMACS_INT.
4574 * xdisp.c (display_count_lines): 3rd argument and return value now
4575 EMACS_INT. All callers changed.
4576 (pint2hrstr): Last argument is now EMACS_INT.
4578 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4579 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4580 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4581 (decode_coding_utf_16, decode_coding_emacs_mule)
4582 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4583 (decode_coding_ccl, decode_coding_charset)
4584 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4585 (decode_coding_iso_2022, decode_coding_emacs_mule)
4586 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4587 <char_offset, last_offset>: Declare EMACS_INT.
4588 (encode_coding_utf_8, encode_coding_utf_16)
4589 (encode_coding_emacs_mule, encode_invocation_designation)
4590 (encode_designation_at_bol, encode_coding_iso_2022)
4591 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4592 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4594 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4595 (encode_invocation_designation): Last argument P_NCHARS is now
4597 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4598 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4600 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4603 * ccl.c (Fccl_execute_on_string): Declare some variables
4606 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
4608 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4610 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4612 * process.c (Fformat_network_address): Doc fix.
4614 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4616 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4618 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
4620 * keyboard.c (read_char): Call Lisp function help-form-show,
4621 instead of using internal_with_output_to_temp_buffer.
4622 (Qhelp_form_show): New var.
4623 (syms_of_keyboard): Use DEFSYM macro.
4625 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4627 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4629 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
4631 * process.c (Flist_processes): Remove to Lisp.
4632 (list_processes_1): Delete.
4634 2011-04-06 Eli Zaretskii <eliz@gnu.org>
4636 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4638 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4640 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
4642 Fix more problems found by GCC 4.6.0's static checks.
4644 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4646 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4648 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
4650 * xdisp.c (vmessage): Mark as a printf-like function.
4652 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4654 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4656 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4657 printf-like functions.
4658 (tiff_load): Add casts to remove these marks before passing them
4659 to system-supplied API.
4661 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4663 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4664 This avoids several warnings with gcc -Wstrict-overflow.
4665 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4666 directly, rather than having caller test rule sign. This avoids
4667 some unnecessary tests.
4668 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4669 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4670 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
4672 * xfont.c (xfont_text_extents): Remove var that was set but not used.
4673 (xfont_open): Avoid unnecessary tests.
4675 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4677 * composite.h, composite.c (composition_gstring_put_cache):
4678 Use EMACS_INT, not int, for length.
4680 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4681 breaking out part of COMPOSITION_DECODE_RULE.
4682 (COMPOSITION_DECODE_RULE): Use it.
4683 * composite.c (get_composition_id): Remove unused local vars,
4684 by using the new macro.
4686 * textprop.c (set_text_properties_1): Change while to do-while,
4687 since the condition is always true at first.
4689 * intervals.c (graft_intervals_into_buffer): Mark var as used.
4690 (interval_deletion_adjustment): Return unsigned value.
4693 * process.c (list_processes_1, create_pty, read_process_output):
4694 (exec_sentinel): Remove vars that were set but not used.
4695 (create_pty): Remove unnecessary "volatile"s.
4696 (Fnetwork_interface_info): Avoid possibility of int overflow.
4697 (read_process_output): Do adaptive read buffering even if carryover.
4698 (read_process_output): Simplify nbytes computation if buffered.
4700 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4702 * syntax.c (scan_words): Remove var that was set but not used.
4703 (update_syntax_table): Use unsigned instead of int.
4705 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
4706 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
4707 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
4709 * print.c (print_error_message): Avoid int overflow.
4711 * font.c (font_list_entities): Redo for clarity,
4712 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4714 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
4715 (font_score): Avoid potential overflow in diff calculation.
4717 * fns.c (substring_both): Remove var that is set but not used.
4718 (sxhash): Redo loop for clarity and to avoid wraparound warning.
4720 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4722 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4723 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4724 can always succeed if overflow has undefined behavior.
4726 * search.c (boyer_moore, wordify): Remove vars set but not used.
4727 (wordify): Omit three unnecessary tests.
4729 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4730 All callers changed. This avoids the need for an unused var.
4732 * casefiddle.c (casify_region): Remove var that is set but not used.
4734 * dired.c (file_name_completion): Remove var that is set but not used.
4736 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4738 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
4739 (Finsert_file_contents): Remove unnecessary code checking fd.
4741 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4742 Check for integer overflow on size calculations.
4744 * buffer.c (Fprevious_overlay_change): Remove var that is set
4747 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
4748 Remove vars that are set but not used.
4749 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
4750 (timer_check_2): Mark vars as initialized.
4752 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
4754 * image.c (lookup_image): Remove var that is set but not used.
4755 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
4757 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
4758 that are set but not used.
4760 * xfns.c (make_invisible_cursor): Don't return garbage
4761 if XCreateBitmapFromData fails (Bug#8410).
4763 * xselect.c (x_get_local_selection, x_handle_property_notify):
4764 Remove vars that are set but not used.
4766 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
4767 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
4769 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
4770 Remove var that is set but not used.
4771 (scroll_bar_windows_size): Now size_t, not int.
4772 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
4775 * xfaces.c (realize_named_face): Remove vars that are set but not used.
4776 (map_tty_color) [!defined MSDOS]: Likewise.
4778 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
4780 * coding.c: Remove vars that are set but not used.
4781 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
4782 All callers changed.
4783 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
4784 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
4785 (decode_coding_charset): Remove vars that are set but not used.
4787 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
4788 that is set but not used.
4790 * print.c (print_object): Remove var that is set but not used.
4792 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
4793 The gnulib version avoids calling malloc in the usual case,
4794 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
4795 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
4796 * filelock.c (current_lock_owner): Likewise.
4797 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
4798 * sysdep.c: Include allocator.h, careadlinkat.h.
4799 (emacs_no_realloc_allocator): New static constant.
4800 (emacs_readlink): New function.
4801 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
4802 ../lib/careadlinkat.h.
4804 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
4806 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
4807 first non-nil return value).
4809 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
4811 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
4812 if not defined (Bug#8403).
4814 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
4816 * xdisp.c (display_count_lines): Remove parameter `start',
4817 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4818 (get_char_face_and_encoding): Remove parameter `multibyte_p',
4819 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4820 (fill_stretch_glyph_string): Remove parameters `row' and `area',
4821 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
4822 and thereabouts. All callers changed.
4823 (get_per_char_metric): Remove parameter `f', unused since
4824 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4826 2011-04-02 Jim Meyering <meyering@redhat.com>
4828 do not dereference NULL upon failed strdup
4829 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
4830 (ns_get_family): Likewise.
4832 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
4834 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
4836 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
4838 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
4841 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
4843 Add lexical binding.
4845 * window.c (Ftemp_output_buffer_show): New fun.
4846 (Fsave_window_excursion):
4847 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
4849 * lread.c (lisp_file_lexically_bound_p): New function.
4850 (Fload): Bind Qlexical_binding.
4851 (readevalloop): Remove `evalfun' arg.
4852 Bind Qinternal_interpreter_environment.
4853 (Feval_buffer): Bind Qlexical_binding.
4854 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
4856 (syms_of_lread): Declare `lexical-binding'.
4858 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
4860 * keyboard.c (eval_dyn): New fun.
4861 (menu_item_eval_property): Use it.
4863 * image.c (parse_image_spec): Use Ffunctionp.
4865 * fns.c (concat, mapcar1): Accept byte-code-functions.
4867 * eval.c (Fsetq): Handle lexical vars.
4868 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
4869 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
4870 (FletX, Flet): Obey lexical binding.
4871 (Fcommandp): Handle closures.
4872 (Feval): New `lexical' arg.
4873 (eval_sub): New function extracted from Feval. Use it almost
4874 everywhere where Feval was used. Look up vars in lexical env.
4876 (Ffunctionp): Move from subr.el.
4877 (Ffuncall): Handle closures.
4878 (apply_lambda): Remove `eval_flags'.
4879 (funcall_lambda): Handle closures and new byte-code-functions.
4880 (Fspecial_variable_p): New function.
4881 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
4882 but without exporting it to Lisp.
4884 * doc.c (Fdocumentation, store_function_docstring):
4885 * data.c (Finteractive_form): Handle closures.
4887 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
4890 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
4892 (exec_byte_code): New function extracted from Fbyte_code to handle new
4893 calling convention for byte-code-functions. Add new byte-codes.
4895 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
4897 * alloc.c (Fmake_symbol): Init new `declared_special' field.
4899 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
4901 * xdisp.c (redisplay_internal): Fix prototype.
4903 2011-03-31 Eli Zaretskii <eliz@gnu.org>
4905 * xdisp.c (SCROLL_LIMIT): New macro.
4906 (try_scrolling): Use it when setting scroll_limit.
4907 Limit scrolling to 100 screen lines.
4908 (redisplay_window): Even when falling back on "recentering",
4909 position point in the window according to scroll-conservatively,
4910 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
4912 (try_scrolling): When point is above the window, allow searching
4913 as far as scroll_max, or one screenful, to compute vertical
4914 distance from PT to the scroll margin position. This prevents
4915 try_scrolling from unnecessarily failing when
4916 scroll-conservatively is set to a value slightly larger than the
4917 window height. Clean up the case of PT below the margin at bottom
4918 of window: scroll_max can no longer be INT_MAX. When aggressive
4919 scrolling is in use, don't let point enter the opposite scroll
4920 margin as result of the scroll.
4921 (syms_of_xdisp) <scroll-conservatively>: Document the
4922 threshold of 100 lines for never-recentering scrolling.
4924 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
4926 * dispextern.h (move_it_by_lines):
4927 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
4928 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
4929 (message_log_check_duplicate): Remove parameters `prev_bol' and
4930 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4931 (redisplay_internal): Remove parameter `preserve_echo_area',
4932 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
4934 * indent.c (Fvertical_motion):
4935 * window.c (window_scroll_pixel_based, Frecenter):
4936 Don't pass `need_y_p' to `move_it_by_lines'.
4938 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
4940 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
4941 steal a few bits to be more compact.
4942 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
4943 Remove unneeded casts.
4945 * bytecode.c (Fbyte_code): CAR and CDR can GC.
4947 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
4949 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
4950 binding" message (bug#7967).
4952 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
4954 Fix more problems found by GCC 4.6.0's static checks.
4956 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
4957 Remove unused local var.
4959 * editfns.c (Fmessage_box): Remove unused local var.
4961 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
4962 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4963 Omit unused local vars.
4964 * window.c (shrink_windows): Omit unused local var.
4965 * menu.c (digest_single_submenu): Omit unused local var.
4966 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
4967 Omit unused local var.
4969 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
4970 Don't assume string length fits in int.
4971 (keyremap_step, read_key_sequence): Use size_t for sizes.
4972 (read_key_sequence): Don't check last_real_key_start redundantly.
4974 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
4975 instead of alloca (Bug#8344).
4977 * eval.c (Fbacktrace): Don't assume nargs fits in int.
4978 (Fbacktrace_frame): Don't assume nframes fits in int.
4980 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
4982 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
4985 * term.c (produce_glyphless_glyph): Remove unnecessary test.
4987 * cm.c (calccost): Turn while-do into do-while, for clarity.
4989 * keyboard.c (syms_of_keyboard): Use the same style as later
4990 in this function when indexing through an array. This also
4991 works around GCC bug 48267.
4993 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
4995 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
4997 * chartab.c (sub_char_table_ref_and_range): Redo for slight
4998 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5000 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5001 This avoids undefined behavior on integer overflow, and is a bit
5002 more convenient anyway since it is compared to a size_t variable.
5004 Variadic C functions now count arguments with size_t, not int.
5005 This avoids an unnecessary limitation on 64-bit machines, which
5006 caused (substring ...) to crash on large vectors (Bug#8344).
5007 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
5008 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
5009 All variadic functions and their callers changed accordingly.
5010 (struct gcpro.nvars): Now size_t, not int. All uses changed.
5011 * data.c (arith_driver, float_arith_driver): Likewise.
5012 * editfns.c (general_insert_function): Likewise.
5013 * eval.c (struct backtrace.nargs, interactive_p)
5014 (internal_condition_case_n, run_hook_with_args, apply_lambda)
5015 (funcall_lambda, mark_backtrace): Likewise.
5016 * fns.c (concat): Likewise.
5017 * frame.c (x_set_frame_parameters): Likewise.
5018 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
5019 0 if not found, not -1. All callers changed.
5021 * alloc.c (garbage_collect): Don't assume stack size fits in int.
5022 (stack_copy_size): Now size_t, not int.
5023 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
5025 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5027 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
5028 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5029 All callers changed.
5031 * lisp.h (multibyte_char_to_unibyte):
5032 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
5033 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5034 * character.h (CHAR_TO_BYTE8):
5035 * cmds.c (internal_self_insert):
5036 * editfns.c (general_insert_function):
5037 * keymap.c (push_key_description):
5038 * search.c (Freplace_match):
5039 * xdisp.c (message_dolog, set_message_1): All callers changed.
5041 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5043 * keyboard.c (safe_run_hook_funcall): New function.
5044 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
5045 don't set the hook to nil, but remove the offending function instead.
5046 (Qcommand_hook_internal): Remove, unused.
5047 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
5048 Vcommand_hook_internal.
5050 * eval.c (enum run_hooks_condition): Remove.
5051 (funcall_nil, funcall_not): New functions.
5052 (run_hook_with_args): Call each function through a `funcall' argument.
5053 Remove `cond' argument, now redundant.
5054 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
5055 (Frun_hook_with_args_until_failure): Adjust accordingly.
5056 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
5058 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
5060 * dispextern.h (string_buffer_position): Remove declaration.
5062 * print.c (strout): Remove parameter `multibyte', unused since
5063 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
5065 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
5066 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
5067 All callers changed.
5069 * w32.c (_wsa_errlist): Use braces for struct initializers.
5071 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
5072 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
5073 All callers changed.
5074 (string_buffer_position): Likewise. Also, make static (it's never
5075 used outside xdisp.c).
5076 (cursor_row_p): Remove parameter `w', unused since
5077 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
5078 (decode_mode_spec): Remove parameter `precision', introduced during
5079 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
5080 All callers changed.
5082 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5084 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
5086 2011-03-27 Anders Lindgren <andlind@gmail.com>
5088 * nsterm.m (ns_menu_bar_is_hidden): New variable.
5089 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
5090 (ns_update_auto_hide_menu_bar): New functions.
5091 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
5092 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
5093 ns_constrain_all_frames.
5094 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
5095 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
5097 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5099 * nsmenu.m (runDialogAt): Remove argument to timer_check.
5101 2011-03-27 Glenn Morris <rgm@gnu.org>
5103 * syssignal.h: Replace RETSIGTYPE with void.
5104 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
5105 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
5106 Replace SIGTYPE with void everywhere.
5107 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5108 * s/template.h (SIGTYPE): Remove commented out definition.
5110 2011-03-26 Eli Zaretskii <eliz@gnu.org>
5112 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5113 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5115 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
5117 * w32.c (read_unc_volume): Use parameter `henum', instead of
5118 global variable `wget_enum_handle'.
5120 * keymap.c (describe_vector): Remove parameters `indices' and
5121 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5122 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5124 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5126 * keyboard.c (timer_check): Remove parameter `do_it_now',
5127 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5128 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5129 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5131 * keyboard.c (read_char):
5132 * w32menu.c (w32_menu_display_help):
5133 * xmenu.c (show_help_event, menu_help_callback):
5134 Adjust calls to `show_help_echo'.
5136 * gtkutil.c (xg_maybe_add_timer):
5137 * keyboard.c (readable_events):
5138 * process.c (wait_reading_process_output):
5139 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5141 * insdel.c (adjust_markers_gap_motion):
5142 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5143 (gap_left, gap_right): Don't call it.
5145 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
5147 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5148 incurred during fontification.
5150 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5152 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5153 (DEFVAR_PER_BUFFER): Don't pass it.
5155 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5156 (scrolling_window): Don't pass it.
5158 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5160 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5162 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5164 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5165 of variables specific to SELinux and computation of `encoded_absname'.
5167 * image.c (XPutPixel): Remove unused variable `height'.
5169 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5171 * unexw32.c (get_section_info): Remove unused variable `section'.
5173 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5174 (system_process_attributes): Remove unused variable `sess'.
5175 (sys_read): Remove unused variable `err'.
5177 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5178 (w32_wnd_proc): Remove unused variable `isdead'.
5179 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5180 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5181 (x_create_tip_frame): Remove unused variable `tem'.
5183 * w32inevt.c (w32_console_read_socket):
5184 Remove unused variable `no_events'.
5186 * w32term.c (x_draw_composite_glyph_string_foreground):
5187 Remove unused variable `width'.
5189 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
5191 * w32term.c (x_set_glyph_string_clipping):
5192 Don't pass uninitialized region to CombineRgn.
5194 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
5196 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5197 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5198 (Fx_close_connection): Remove unused variable `i'.
5200 * w32font.c (w32font_draw): Return number of glyphs.
5201 (w32font_open_internal): Remove unused variable `i'.
5202 (w32font_driver): Add missing initializer.
5204 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5205 (fill_in_menu): Remove unused variable `items_added'.
5207 * w32term.c (last_mouse_press_frame): Remove static global variable.
5208 (w32_clip_to_row): Remove unused variable `f'.
5209 (x_delete_terminal): Remove unused variable `i'.
5211 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5212 (NOTHING): Remove unused static global variable.
5213 (uniscribe_check_otf): Remove unused variable `table'.
5214 (uniscribe_font_driver): Add missing initializers.
5216 2011-03-23 Julien Danjou <julien@danjou.info>
5218 * term.c (Fsuspend_tty, Fresume_tty):
5219 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5220 * window.c (temp_output_buffer_show):
5221 * insdel.c (signal_before_change):
5222 * frame.c (Fhandle_switch_frame):
5223 * fileio.c (Fdo_auto_save):
5224 * emacs.c (Fkill_emacs):
5225 * editfns.c (save_excursion_restore):
5226 * cmds.c (internal_self_insert):
5227 * callint.c (Fcall_interactively):
5228 * buffer.c (Fkill_all_local_variables):
5229 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5231 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
5232 unconditionnaly since it does the check itself.
5234 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
5236 Fix more problems found by GCC 4.5.2's static checks.
5238 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5239 the first time through the loop, since we know p0 < p1 then.
5240 This also avoids a gcc -Wstrict-overflow warning.
5242 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5243 leading to a memory leak, possible in functions like
5244 load_charset_map_from_file that can allocate an unbounded number
5245 of objects (Bug#8318).
5247 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5248 that could (at least in theory) be that large.
5250 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5251 This is less likely to overflow, and avoids undefined behavior if
5252 overflow does occur. All callers changed. Use strtoul to scan
5253 for the unsigned long integer.
5254 (pint2hrstr): Simplify and tune code slightly.
5255 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
5257 * scroll.c (do_scrolling): Work around GCC bug 48228.
5258 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5260 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5261 This also avoids a warning with gcc -Wstrict-overflow.
5262 (validate_x_resource_name): Simplify count usage.
5263 This also avoids a warning with gcc -Wstrict-overflow.
5265 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5268 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
5270 * process.c (Fmake_network_process): Use socklen_t, not int,
5271 where POSIX says socklen_t is required in portable programs.
5272 This fixes a porting bug on hosts like 64-bit HP-UX, where
5273 socklen_t is wider than int (Bug#8277).
5274 (Fmake_network_process, server_accept_connection):
5275 (wait_reading_process_output, read_process_output):
5278 * process.c: Rename or move locals to avoid shadowing.
5279 (list_processes_1, Fmake_network_process):
5280 (read_process_output_error_handler, exec_sentinel_error_handler):
5281 Rename or move locals.
5282 (Fmake_network_process): Define label "retry_connect" only if needed.
5283 (Fnetwork_interface_info): Fix pointer signedness.
5284 (process_send_signal): Add cast to avoid pointer signedness problem.
5285 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
5286 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
5288 Make tparam.h and terminfo.c consistent.
5289 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5290 Include tparam.h instead, since it declares them.
5291 * cm.h (PC): Remove extern decl; tparam.h now does this.
5292 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5293 * terminfo.c: Include tparam.h, to check interfaces.
5294 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5295 (tparam): Adjust signature to match interface in tparam.h;
5296 this removes some undefined behavior. Check that outstring and len
5297 are zero, which they always are with Emacs.
5298 * tparam.h (PC, BC, UP): New extern decls.
5300 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
5301 (xftfont_open): Rename locals to avoid shadowing.
5303 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
5304 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5305 (OTF_TAG_SYM): Omit macro if not needed.
5306 (ftfont_list): Remove unused local.
5307 (get_adstyle_property, ftfont_pattern_entity):
5308 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5309 Rename locals to avoid shadowing.
5311 * xfont.c (xfont_list_family): Mark var as initialized.
5313 * xml.c (make_dom): Now static.
5315 * composite.c (composition_compute_stop_pos): Rename local to
5317 (composition_reseat_it): Remove unused locals.
5318 (find_automatic_composition, composition_adjust_point): Likewise.
5319 (composition_update_it): Mark var as initialized.
5320 (find_automatic_composition): Mark vars as initialized,
5321 with a FIXME (Bug#8290).
5323 character.h: Rename locals to avoid shadowing.
5324 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5325 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5326 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5327 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5330 * textprop.c (property_change_between_p): Remove; unused.
5332 * intervals.c (interval_start_pos): Now static.
5334 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5336 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5337 Rename locals to avoid shadowing.
5339 * sound.c (wav_play, au_play, Fplay_sound_internal):
5340 Fix pointer signedness.
5341 (alsa_choose_format): Remove unused local var.
5342 (wav_play): Initialize a variable to 0, to prevent undefined
5343 behavior (Bug#8278).
5345 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5347 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5349 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5350 clobbering (Bug#8298).
5351 * sysdep.c (sys_subshell): Likewise.
5352 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
5354 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5355 This should get cleaned up, so that child_setup has the
5356 same signature on all platforms.
5358 * callproc.c (call_process_cleanup): Now static.
5359 (relocate_fd): Rename locals to avoid shadowing.
5361 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
5363 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5364 not to be necessary, and produces flickering.
5366 2011-03-20 Glenn Morris <rgm@gnu.org>
5368 * config.in: Remove file.
5370 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
5372 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5373 are now in src/globals.h.
5374 (syms_of_minibuf): Remove spurious & from previous change.
5376 2011-03-20 Leo <sdl.web@gmail.com>
5378 * minibuf.c (completing-read-function): New variable.
5379 (completing-read-default): Rename from completing-read.
5380 (completing-read): Call completing-read-function.
5382 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5384 * xfaces.c (Fx_load_color_file):
5385 Read color file from absolute filename (bug#8250).
5387 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5389 * makefile.w32-in: Update dependencies.
5391 2011-03-17 Eli Zaretskii <eliz@gnu.org>
5393 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5395 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5397 Fix more problems found by GCC 4.5.2's static checks.
5399 * process.c (make_serial_process_unwind, send_process_trap):
5400 (sigchld_handler): Now static.
5402 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5403 That way, the code declares only the vars that it needs.
5404 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5405 * s/cygwin.h (PTY_ITERATION): Likewise.
5406 * s/darwin.h (PTY_ITERATION): Likewise.
5407 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5409 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5410 * process.c (allocate_pty): Don't declare stb unless it's needed.
5412 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
5413 (CONSTANTLIM): Remove; unused.
5414 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5415 Define only if needed.
5417 * unexelf.c (unexec): Name an expression,
5418 to avoid gcc -Wbad-function-cast warning.
5419 Use a different way to cause a compilation error if anyone uses
5420 n rather than nn, a way that does not involve shadowing.
5421 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
5423 * deps.mk (unexalpha.o): Remove; unused.
5425 New file unexec.h, the (simple) interface for unexec (Bug#8267).
5426 * unexec.h: New file.
5427 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5428 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5430 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5431 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5432 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
5433 Change as necessary to match prototype in unexec.h.
5435 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5437 (back_comment, skip_chars): Mark vars as initialized.
5439 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5440 Rename locals to avoid shadowing.
5442 * lread.c (read1): Rewrite so as not to use empty "else".
5443 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
5445 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5447 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5448 warning when compiling print.c.
5450 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5451 instead of using an uninitialized var.
5452 (font_sort_entities): Mark var as initialized.
5454 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5456 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5457 pointers to constants.
5458 (font_parse_fcname): Remove unused vars.
5459 (font_delete_unmatched): Now static.
5460 (font_get_spec): Remove; unused.
5461 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5462 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5463 Rename or move locals to avoid shadowing.
5465 * fns.c (require_nesting_list, require_unwind): Now static.
5466 (Ffillarray): Rename locals to avoid shadowing.
5468 * floatfns.c (domain_error2): Define only if needed.
5469 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
5471 * alloc.c (mark_backtrace): Move decl from here ...
5472 * lisp.h: ... to here, so that it can be checked.
5474 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
5475 (Fdefvar): Rewrite so as not to use empty "else".
5476 (lisp_indirect_variable): Name an expression,
5477 to avoid gcc -Wbad-function-cast warning.
5478 (Fdefvar): Rename locals to avoid shadowing.
5480 * callint.c (quotify_arg, quotify_args): Now static.
5481 (Fcall_interactively): Rename locals to avoid shadowing.
5482 Use const pointer when appropriate.
5484 * lisp.h (get_system_name, get_operating_system_release):
5485 Move decls here, to check interfaces.
5486 * process.c (get_operating_system_release): Move decl to lisp.h.
5487 * xrdb.c (get_system_name): Likewise.
5488 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5489 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5490 some of which prompt warnings from gcc -Wbad-function-cast.
5491 (Fformat_time_string, Fencode_time, Finsert_char):
5492 (Ftranslate_region_internal, Fformat):
5493 Rename or remove local vars to avoid shadowing.
5494 (Ftranslate_region_internal): Mark var as initialized.
5496 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5499 * lisp.h (eassert): Check that the argument compiles, even if
5500 ENABLE_CHECKING is not defined.
5502 * data.c (Findirect_variable): Name an expression, to avoid
5503 gcc -Wbad-function-cast warning.
5504 (default_value, arithcompare, arith_driver, arith_error): Now static.
5505 (store_symval_forwarding): Rename local to avoid shadowing.
5506 (Fmake_variable_buffer_local, Fmake_local_variable):
5507 Mark variables as initialized.
5508 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
5510 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
5511 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5512 Rename locals to avoid shadowing.
5513 (mark_stack): Move local variables into the #ifdef region where
5515 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5516 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5518 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5519 (GC_STRING_CHARS): Remove; not used.
5520 (Fmemory_limit): Cast sbrk's returned value to char *.
5522 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5523 avoids undefined behavior in theory.
5525 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5527 Use functions, not macros, for up- and down-casing (Bug#8254).
5528 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5529 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5530 to use the following functions instead of these macros.
5531 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5532 EMACS_INT, since callers assume the returned value fits in int.
5533 (upcase1): Likewise, for UPCASE_TABLE.
5534 (uppercasep, lowercasep, upcase): New static inline functions.
5535 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
5536 the race-condition problem in the old DOWNCASE.
5538 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5539 Rename locals to avoid shadowing.
5540 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
5541 (regex_compile, re_search_2, re_match_2_internal):
5542 Remove unused local vars.
5543 (FREE_VAR): Rewrite so as not to use empty "else",
5544 which gcc can warn about.
5545 (regex_compile, re_match_2_internal): Mark locals as initialized.
5546 (RETALLOC_IF): Define only if needed.
5547 (WORDCHAR_P): Likewise. This one is never needed, but is used
5548 only in a comment talking about a compiler bug, so put inside
5549 the #if 0 of that comment.
5550 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5551 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5554 * search.c (boyer_moore): Rename locals to avoid shadowing.
5555 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5556 (PREV_CHAR_BOUNDARY): Likewise.
5558 * search.c (simple_search): Remove unused var.
5560 * dired.c (compile_pattern): Move decl from here ...
5561 * lisp.h: ... to here, so that it can be checked.
5562 (struct re_registers): New forward decl.
5564 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5566 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5568 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5569 Rename locals to avoid shadowing.
5570 (Fvertical_motion): Mark locals as initialized.
5572 * casefiddle.c (casify_object, casify_region): Now static.
5573 (casify_region): Mark local as initialized.
5575 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5577 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5578 New macros, so that the caller can use some names other than
5579 gcpro1, gcpro2, etc.
5580 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5582 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5583 argument, for consistency with GCPRO2_VAR, etc: it is now the
5584 prefix of the variable, not the variable itself. All uses
5586 * dired.c (directory_files_internal, file_name_completion):
5587 Rename locals to avoid shadowing.
5589 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5590 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5591 dired.c's scmp function, had undefined behavior.
5592 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5593 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5594 * buffer.h: ... to here, because these macros use current_buffer,
5595 and the new implementation with inline functions needs to have
5596 current_buffer in scope now, rather than later when the macros
5598 (downcase, upcase1): New static inline functions.
5599 (DOWNCASE, UPCASE1): Reimplement using these functions.
5600 This avoids undefined behavior in expressions like
5601 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5602 from race conditions in accessing the global variables
5603 case_temp1 and case_temp2.
5604 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5605 * lisp.h (case_temp1, case_temp2): Remove their decls.
5606 * character.h (ASCII_CHAR_P): Move from here ...
5607 * lisp.h: ... to here, so that the inline functions mentioned
5610 * dired.c (directory_files_internal_unwind): Now static.
5612 * fileio.c (file_name_as_directory, directory_file_name):
5613 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5615 (file_name_as_directory): Use const pointers when appropriate.
5616 (Fexpand_file_name): Likewise. In particular, newdir might
5617 point at constant storage, so make it a const pointer.
5618 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
5619 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5621 (Fset_file_times, Finsert_file_contents, auto_save_error):
5622 Rename locals to avoid shadowing.
5624 * minibuf.c (choose_minibuf_frame_1): Now static.
5625 (Ftry_completion, Fall_completions): Rename or remove locals
5628 * marker.c (bytepos_to_charpos): Remove; unused.
5630 * lisp.h (verify_bytepos, count_markers): New decls,
5631 so that gcc does not warn that these functions aren't declared.
5633 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5634 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
5635 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
5636 (copy_text): Remove unused local var.
5638 * filelock.c (within_one_second): Now static.
5639 (lock_file_1): Rename local to avoid shadowing.
5641 * buffer.c (fix_overlays_before): Mark locals as initialized.
5642 (fix_start_end_in_overlays): Likewise. This function should be
5643 simplified by using pointers-to-pointers, but that's a different
5645 (switch_to_buffer_1): Now static.
5646 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5647 (report_overlay_modification): Rename locals to avoid shadowing.
5649 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
5650 Fix pointer signedness issue.
5651 (sys_subshell): Mark local as volatile if checking for lint,
5652 to suppress a gcc -Wclobbered warning that does not seem to be right.
5653 (MAXPATHLEN): Define only if needed.
5655 * process.c (serial_open, serial_configure): Move decls from here ...
5656 * systty.h: ... to here, so that they can be checked.
5658 * fns.c (get_random, seed_random): Move extern decls from here ...
5659 * lisp.h: ... to here, so that they can be checked.
5661 * sysdep.c (reset_io): Now static.
5662 (wait_for_termination_signal): Remove; unused.
5664 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5665 (copy_keymap_item, append_key, push_text_char_description):
5667 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
5668 (DENSE_TABLE_SIZE): Remove; unused.
5669 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5670 (describe_map_tree):
5671 Rename locals to avoid shadowing.
5673 * keyboard.c: Declare functions static if they are not used elsewhere.
5674 (echo_char, echo_dash, cmd_error, top_level_2):
5675 (poll_for_input, handle_async_input): Now static.
5676 (read_char, kbd_buffer_get_event, make_lispy_position):
5677 (make_lispy_event, make_lispy_movement, apply_modifiers):
5678 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5679 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5680 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
5681 (read_key_sequence, read_char): Mark locals as initialized.
5682 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
5684 * keyboard.h (make_ctrl_char): New decl.
5685 (mark_kboards): Move decl here ...
5686 * alloc.c (mark_kboards): ... from here.
5688 * lisp.h (force_auto_save_soon): New decl.
5690 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
5691 (DEFINE_DUMMY_FUNCTION): New macro.
5692 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5694 (main): Add casts to avoid warnings
5695 if GCC considers string literals to be constants.
5697 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5699 * dbusbind.c: Pointer signedness fixes.
5700 (xd_signature, xd_append_arg, xd_initialize):
5701 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5702 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5703 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5704 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5706 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5707 if GCC considers string literals to be constants.
5708 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
5710 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5712 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5713 (print_preprocess, print_object): New macro to fix last change.
5715 * print.c (print_preprocess): Don't forget font objects.
5717 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
5719 * emacs.c (USAGE3): Doc fixes.
5721 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5723 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5726 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
5728 * lisp.h (VWindow_system, Qfile_name_history):
5729 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5730 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5731 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5733 * w32select.c: Don't #include "keyboard.h".
5734 (run_protected): Add extern declaration for waiting_for_input.
5736 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5737 * w32console.c (detect_input_pending, read_input_pending)
5738 (encode_terminal_code):
5739 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5740 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5741 (w32_system_caret_y, Qfile_name_history):
5742 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5743 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5744 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5745 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5746 * w32proc.c (Qlocal, report_file_error):
5747 * w32term.c (Vwindow_system, updating_frame):
5748 * w32uniscribe.c (initialized, uniscribe_font_driver):
5749 Remove unneeded extern declarations.
5751 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
5753 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
5755 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
5757 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
5758 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
5759 These macros can no longer be used for assignment.
5761 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5762 Assign struct members directly, instead of using BUF_BEGV etc.
5763 (record_buffer_markers, fetch_buffer_markers): New functions for
5764 recording and fetching special buffer markers.
5765 (set_buffer_internal_1, set_buffer_temp): Use them.
5767 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
5769 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
5771 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
5772 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
5774 * xdisp.c (hscroll_window_tree):
5775 (reconsider_clip_changes): Use PT instead of BUF_PT.
5777 2011-03-13 Eli Zaretskii <eliz@gnu.org>
5779 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
5780 $(EMACS_ROOT)/lib/intprops.h.
5782 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
5784 Fix more problems found by GCC 4.5.2's static checks.
5786 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
5787 to unsigned char * to avoid compiler diagnostic.
5788 (xg_free_frame_widgets): Make it clear that a local variable is
5789 needed only if USE_GTK_TOOLTIP.
5790 (gdk_window_get_screen): Make it clear that this macro is needed
5791 only if USE_GTK_TOOLTIP.
5792 (int_gtk_range_get_value): New function, which avoids a diagnostic
5793 from gcc -Wbad-function-cast.
5794 (xg_set_toolkit_scroll_bar_thumb): Use it.
5795 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
5796 diagnostic from gcc -Wbad-function-cast.
5797 (get_utf8_string, xg_get_file_with_chooser):
5798 Rename locals to avoid shadowing.
5799 (create_dialog): Move locals to avoid shadowing.
5801 * xgselect.c (xg_select): Remove unused var.
5803 * image.c (four_corners_best): Mark locals as initialized.
5804 (gif_load): Initialize transparent_p to zero (Bug#8238).
5805 Mark another local as initialized.
5806 (my_png_error, my_error_exit): Mark with NO_RETURN.
5808 * image.c (clear_image_cache): Now static.
5809 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
5810 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
5811 (x_edge_detection): Remove unnecessary cast that
5812 gcc -Wbad-function-cast diagnoses.
5813 (gif_load): Fix pointer signedness.
5814 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
5815 (jpeg_load, gif_load): Rename locals to avoid shadowing.
5817 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
5819 Improve quality of tests for time stamp overflow.
5820 For example, without this patch (encode-time 0 0 0 1 1
5821 1152921504606846976) returns the obviously-bogus value (-948597
5822 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
5823 reports time overflow. See
5824 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
5825 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
5826 * editfns.c: Include limits.h and intprops.h.
5827 (TIME_T_MIN, TIME_T_MAX): New macros.
5828 (time_overflow): Move earlier, to before first use.
5829 (hi_time, lo_time): New functions, for an accurate test for
5831 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
5832 (Fget_internal_run_time): Don't assume time_t fits in int.
5833 (make_time): Use list2 instead of Fcons twice.
5834 (Fdecode_time): More accurate test for out-of-range times.
5835 (check_tm_member): New function.
5836 (Fencode_time): Use it, to test for out-of-range times.
5837 (lisp_time_argument): Don't rely on undefined left-shift and
5838 right-shift behavior when checking for time stamp overflow.
5840 * editfns.c (time_overflow): New function, refactoring common code.
5841 (Fformat_time_string, Fdecode_time, Fencode_time):
5842 (Fcurrent_time_string): Use it.
5844 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
5845 * dired.c (make_time): Move to ...
5846 * editfns.c (make_time): ... here.
5847 * systime.h: Note the move.
5849 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5851 * fringe.c (update_window_fringes): Remove unused variables.
5853 * unexmacosx.c (copy_data_segment): Also copy __got section.
5856 2011-03-12 Eli Zaretskii <eliz@gnu.org>
5858 * termcap.c [MSDOS]: Include "msdos.h".
5859 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
5860 Constify `char *' arguments and their references according to
5861 prototypes in tparam.h.
5863 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
5865 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
5866 Adapt all references accordingly.
5868 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
5870 2011-03-11 Tom Tromey <tromey@redhat.com>
5872 * buffer.c (syms_of_buffer): Remove obsolete comment.
5874 2011-03-11 Eli Zaretskii <eliz@gnu.org>
5876 * termhooks.h (encode_terminal_code): Declare prototype.
5878 * msdos.c (encode_terminal_code): Don't declare prototype.
5880 * term.c (encode_terminal_code): Now external again, used by
5881 w32console.c and msdos.c.
5883 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
5884 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
5886 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
5888 Fix some minor problems found by GCC 4.5.2's static checks.
5890 * fringe.c (update_window_fringes): Mark locals as initialized
5892 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
5894 * alloc.c (mark_fringe_data): Move decl from here ...
5895 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
5896 to check its interface.
5897 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
5899 * fontset.c (free_realized_fontset): Now static.
5900 (Fset_fontset_font): Rename local to avoid shadowing.
5901 (fontset_font): Mark local as initialized.
5902 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
5904 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
5906 * xselect.c (x_disown_buffer_selections): Remove; not used.
5907 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
5908 (x_own_selection, Fx_disown_selection_internal): Rename locals
5910 (x_handle_dnd_message): Remove local to avoid shadowing.
5912 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
5913 so that the caller can use some name other than gcpro1.
5914 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
5915 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5916 (Fx_backspace_delete_keys_p):
5917 Use them to avoid shadowing, and rename vars to avoid shadowing.
5918 (x_decode_color, x_set_name, x_window): Now static.
5919 (Fx_create_frame): Add braces to silence GCC warning.
5920 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
5921 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
5922 Remove unused locals.
5923 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5924 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
5925 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
5928 * xterm.h (x_mouse_leave): New decl.
5930 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
5931 Remove unused functions.
5932 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
5933 (x_calc_absolute_position): Now static.
5934 (XTread_socket): Don't define label "out" unless it's used.
5935 Don't declare local "event" unless it's used.
5936 (x_iconify_frame, x_free_frame_resources): Don't declare locals
5937 unless they are used.
5938 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
5939 (x_fatal_error_signal): Remove; not used.
5940 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
5941 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
5942 (x_error_catcher, x_connection_closed, x_error_handler):
5943 (x_error_quitter, xembed_send_message, x_iconify_frame):
5944 (my_log_handler): Rename locals to avoid shadowing.
5945 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
5946 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
5948 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
5949 Rename or move locals to avoid shadowing.
5950 (tty_defined_color, merge_face_heights): Now static.
5951 (free_realized_faces_for_fontset): Remove; not used.
5952 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
5953 does not deduce is never used uninitialized.
5954 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
5955 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
5957 * terminal.c (store_terminal_param): Now static.
5959 * xmenu.c (menu_highlight_callback): Now static.
5960 (set_frame_menubar): Remove unused local.
5961 (xmenu_show): Rename parameter to avoid shadowing.
5962 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
5963 since they might point to immutable storage.
5964 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
5965 since it's unused otherwise.
5967 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
5968 Add a FIXME, since the code still doesn't look right. (Bug#8215)
5969 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
5970 avoids a gcc -Wuninitialized diagnostic.
5971 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
5972 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
5973 does not deduce are never used uninitialized.
5975 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
5977 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
5978 * window.c (window_loop, size_window):
5979 (run_window_configuration_change_hook, enlarge_window): Likewise.
5981 * window.c (display_buffer): Now static.
5982 (size_window): Mark variables that gcc -Wuninitialized
5983 does not deduce are never used uninitialized.
5984 * window.h (check_all_windows): New decl, to forestall
5985 gcc -Wmissing-prototypes diagnostic.
5986 * dispextern.h (bidi_dump_cached_states): Likewise.
5988 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
5990 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
5992 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
5993 and to avoid gcc -Wuninitialized warning.
5994 (load_charset_map): Mark variables that gcc -Wuninitialized
5995 does not deduce are never used uninitialized.
5996 (load_charset): Abort instead of using uninitialized var (Bug#8229).
5998 * coding.c (coding_set_source, coding_set_destination):
5999 Use "else { /* comment */ }" rather than "else /* comment */;"
6000 for clarity, and to avoid gcc -Wempty-body warning.
6001 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6002 a block, when the outer 'i' will do.
6003 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
6004 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
6005 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
6006 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
6007 (Fdecode_sjis_char, Fdefine_coding_system_internal):
6008 Rename locals to avoid shadowing.
6009 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
6010 * coding.c (emacs_mule_char, encode_invocation_designation):
6011 Now static, since they're not used elsewhere.
6012 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
6013 (decode_coding_object, encode_coding_object, detect_coding_system):
6014 (decode_coding_emacs_mule): Mark variables that gcc
6015 -Wuninitialized does not deduce are never used uninitialized.
6016 (detect_coding_iso_2022): Initialize a local variable that might
6017 be used uninitialized. Leave a FIXME because it's not clear that
6018 this initialization is needed. (Bug#8211)
6019 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
6020 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
6021 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
6022 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
6023 Remove unused macros.
6025 * category.c (hash_get_category_set): Remove unused local var.
6026 (copy_category_table): Now static, since it's not used elsewhere.
6027 * character.c (string_count_byte8): Likewise.
6029 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
6030 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
6032 * chartab.c (copy_sub_char_table): Now static, since it's not used
6034 (sub_char_table_ref_and_range, char_table_ref_and_range):
6035 Rename locals to avoid shadowing.
6036 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
6038 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
6039 (BIDI_BOB): Remove unused macro.
6041 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
6042 deduce are never used uninitialized.
6043 * term.c (encode_terminal_code): Likewise.
6045 * term.c (encode_terminal_code): Now static. Remove unused local.
6047 * tparam.h: New file.
6048 * term.c, tparam.h: Include it.
6049 * deps.mk (term.o, tparam.o): Depend on tparam.h.
6050 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
6051 Move these decls to tparam.h, and make them agree with what
6052 is actually in tparam.c. The previous trick of using incompatible
6053 decls in different modules does not conform to the C standard.
6054 All callers of tparam changed to use tparam's actual API.
6055 * tparam.c (tparam1, tparam, tgoto):
6056 Use const pointers where appropriate.
6058 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
6059 * cm.h (struct cm): Likewise.
6060 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
6061 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
6062 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
6063 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
6064 (turn_on_face, init_tty): Likewise.
6065 * termchar.h (struct tty_display_info): Likewise.
6067 * term.c (term_mouse_position): Rename local to avoid shadowing.
6069 * alloc.c (mark_ttys): Move decl from here ...
6070 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
6072 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
6074 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
6076 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
6078 * search.c (compile_pattern_1): Remove argument regp, unused since
6079 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
6080 (compile_pattern): Don't pass it.
6082 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
6084 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
6085 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
6087 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
6089 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
6091 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
6092 gdk_window_get_screen, gdk_window_get_geometry,
6093 gdk_x11_window_lookup_for_display and GDK_KEY_g.
6094 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
6095 (xg_get_pixbuf_from_pixmap): New function.
6096 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
6097 to Pixmap, take frame as parameter, remove GdkColormap parameter.
6098 Call xg_get_pixbuf_from_pixmap instead of
6099 gdk_pixbuf_get_from_drawable.
6100 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
6101 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
6102 (xg_check_special_colors): Use GtkStyleContext and its functions
6104 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
6105 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
6106 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
6107 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6108 Call gtk_widget_get_preferred_size.
6109 (xg_frame_resized): gdk_window_get_geometry only takes 5
6111 (xg_win_to_widget, xg_event_is_for_menubar):
6112 Call gdk_x11_window_lookup_for_display.
6113 (xg_set_widget_bg): New function.
6114 (delete_cb): New function.
6115 (xg_create_frame_widgets): Connect delete-event to delete_cb.
6116 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6117 (xg_set_background_color): Call xg_set_widget_bg.
6118 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6119 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6120 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6121 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6123 (update_frame_tool_bar): Call gtk_widget_hide.
6124 (xg_initialize): Use GDK_KEY_g.
6126 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6128 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6130 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6131 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6132 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6134 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
6136 * w32xfns.c (select_palette): Check success of RealizePalette against
6137 GDI_ERROR, not zero.
6139 See ChangeLog.11 for earlier changes.
6145 Copyright (C) 2011 Free Software Foundation, Inc.
6147 This file is part of GNU Emacs.
6149 GNU Emacs is free software: you can redistribute it and/or modify
6150 it under the terms of the GNU General Public License as published by
6151 the Free Software Foundation, either version 3 of the License, or
6152 (at your option) any later version.
6154 GNU Emacs is distributed in the hope that it will be useful,
6155 but WITHOUT ANY WARRANTY; without even the implied warranty of
6156 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6157 GNU General Public License for more details.
6159 You should have received a copy of the GNU General Public License
6160 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.