]> code.delx.au - gnu-emacs/blob - src/ChangeLog
* chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
[gnu-emacs] / src / ChangeLog
1 2011-04-09 Paul Eggert <eggert@cs.ucla.edu>
2
3 * charset.c (load_charset_map): <, not <=, for optimization.
4 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
5
6 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7 This also lets GCC 4.6.0 generate slightly better loop code.
8
9 * callint.c (Fcall_interactively): <, not <=, for optimization.
10 (Fcall_interactively): Count the number of arguments produced,
11 not the number of arguments given. This is simpler and lets GCC
12 4.6.0 generate slightly better code.
13
14 * ftfont.c: Distingish more carefully between FcChar8 and char.
15 The previous code passed unsigned char * to a functions like
16 strlen and xstrcasecmp that expect char *, which does not
17 conform to the C standard.
18 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
19 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
20 char * when the C standard requires it.
21
22 * keyboard.c (read_char): Remove unused var.
23
24 * eval.c: Port to Windows vsnprintf (Bug#8435).
25 Include <limits.h>.
26 (SIZE_MAX): Define if the headers do not.
27 (verror): Do not give up if vsnprintf returns a negative count.
28 Instead, grow the buffer. This ports to Windows vsnprintf, which
29 does not conform to C99. Problem reported by Eli Zaretskii.
30 Also, simplify the allocation scheme, by avoiding the need for
31 calling realloc, and removing the ALLOCATED variable.
32
33 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
34
35 Remove the doprnt implementation, as Emacs now uses vsnprintf.
36 * doprnt.c: Remove.
37 * lisp.h (doprnt): Remove.
38 * Makefile.in (base_obj): Remove doprnt.o.
39 * deps.mk (doprnt.o): Remove.
40
41 error: Print 32- and 64-bit integers portably (Bug#8435).
42 Without this change, on typical 64-bit hosts error ("...%d...", N)
43 was used to print both 32- and 64-bit integers N, which relied on
44 undefined behavior.
45 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
46 New macro.
47 * lisp.h (error, verror): Mark as printf-like functions.
48 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
49 Report overflow in size calculations when allocating printf buffer.
50 Do not truncate output string at its first null byte.
51 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
52 Truncate the output at a character boundary, since vsnprintf does not
53 do that.
54 * charset.c (check_iso_charset_parameter): Convert internal
55 character to string before calling 'error', since %c now has the
56 printf meaning.
57 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
58 overflow when computing char to be passed to 'error'. Do not
59 pass Lisp_Object to 'error'; pass the integer instead.
60 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
61 formatted with plain %d.
62
63 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
64
65 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
66
67 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
68
69 * xterm.c (x_catch_errors): Remove duplicate declaration.
70
71 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
72
73 * xdisp.c, lisp.h (message_nolog): Remove; unused.
74
75 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
76
77 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
78 unsigned char, to match FcChar8 type definition.
79
80 * xterm.c (handle_one_xevent):
81 * xmenu.c (create_and_show_popup_menu):
82 * xselect.c (x_decline_selection_request)
83 (x_reply_selection_request): Avoid type-punned deref of X events.
84
85 2011-04-09 Eli Zaretskii <eliz@emacstest.gnu.org>
86
87 Fix some uses of `int' instead of EMACS_INT.
88 * search.c (string_match_1, fast_string_match)
89 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
90 (scan_buffer, find_next_newline_no_quit)
91 (find_before_next_newline, search_command, Freplace_match)
92 (Fmatch_data): Make some `int' variables be EMACS_INT.
93
94 * xdisp.c (display_count_lines): 3rd argument and return value now
95 EMACS_INT. All callers changed.
96 (pint2hrstr): Last argument is now EMACS_INT.
97
98 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
99 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
100 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
101 (decode_coding_utf_16, decode_coding_emacs_mule)
102 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
103 (decode_coding_ccl, decode_coding_charset)
104 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
105 (decode_coding_iso_2022, decode_coding_emacs_mule)
106 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
107 <char_offset, last_offset>: Declare EMACS_INT.
108 (encode_coding_utf_8, encode_coding_utf_16)
109 (encode_coding_emacs_mule, encode_invocation_designation)
110 (encode_designation_at_bol, encode_coding_iso_2022)
111 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
112 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
113 Declare EMACS_INT.
114 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
115 (encode_invocation_designation): Last argument P_NCHARS is now
116 EMACS_INT.
117 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
118 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
119
120 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
121 All users changed.
122
123 * ccl.c (Fccl_execute_on_string): Declare some variables
124 EMACS_INT.
125
126 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
127
128 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
129
130 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
131
132 * process.c (Fformat_network_address): Doc fix.
133
134 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
135
136 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
137
138 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
139
140 * keyboard.c (read_char): Call Lisp function help-form-show,
141 instead of using internal_with_output_to_temp_buffer.
142 (Qhelp_form_show): New var.
143 (syms_of_keyboard): Use DEFSYM macro.
144
145 * print.c (internal_with_output_to_temp_buffer): Function deleted.
146
147 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
148
149 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
150
151 * process.c (Flist_processes): Removed to Lisp.
152 (list_processes_1): Deleted.
153
154 2011-04-06 Eli Zaretskii <eliz@gnu.org>
155
156 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
157
158 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
159
160 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
161
162 Fix more problems found by GCC 4.6.0's static checks.
163
164 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
165
166 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
167
168 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
169
170 * xdisp.c (vmessage): Mark as a printf-like function.
171
172 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
173
174 * sound.c (sound_warning): Don't crash if arg contains a printf format.
175
176 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
177 printf-like functions.
178 (tiff_load): Add casts to remove these marks before passing them
179 to system-supplied API.
180
181 * eval.c (Fsignal): Remove excess argument to 'fatal'.
182
183 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
184 This avoids several warnings with gcc -Wstrict-overflow.
185 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
186 directly, rather than having caller test rule sign. This avoids
187 some unnecessary tests.
188 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
189 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
190 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
191
192 * xfont.c (xfont_text_extents): Remove var that was set but not used.
193 (xfont_open): Avoid unnecessary tests.
194
195 * composite.c (composition_gstring_put_cache): Use unsigned integer.
196
197 * composite.h, composite.c (composition_gstring_put_cache):
198 Use EMACS_INT, not int, for length.
199
200 * composite.h (COMPOSITION_DECODE_REFS): New macro,
201 breaking out part of COMPOSITION_DECODE_RULE.
202 (COMPOSITION_DECODE_RULE): Use it.
203 * composite.c (get_composition_id): Remove unused local vars,
204 by using the new macro.
205
206 * textprop.c (set_text_properties_1): Change while to do-while,
207 since the condition is always true at first.
208
209 * intervals.c (graft_intervals_into_buffer): Mark var as used.
210 (interval_deletion_adjustment): Return unsigned value.
211 All uses changed.
212
213 * process.c (list_processes_1, create_pty, read_process_output):
214 (exec_sentinel): Remove vars that were set but not used.
215 (create_pty): Remove unnecessary "volatile"s.
216 (Fnetwork_interface_info): Avoid possibility of int overflow.
217 (read_process_output): Do adaptive read buffering even if carryover.
218 (read_process_output): Simplify nbytes computation if buffered.
219
220 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
221
222 * syntax.c (scan_words): Remove var that was set but not used.
223 (update_syntax_table): Use unsigned instead of int.
224
225 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
226 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
227 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
228
229 * print.c (print_error_message): Avoid int overflow.
230
231 * font.c (font_list_entities): Redo for clarity,
232 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
233
234 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
235 (font_score): Avoid potential overflow in diff calculation.
236
237 * fns.c (substring_both): Remove var that is set but not used.
238 (sxhash): Redo loop for clarity and to avoid wraparound warning.
239
240 * eval.c (funcall_lambda): Rename local to avoid shadowing.
241
242 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
243 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
244 can always succeed if overflow has undefined behavior.
245
246 * search.c (boyer_moore, wordify): Remove vars set but not used.
247 (wordify): Omit three unnecessary tests.
248
249 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
250 All callers changed. This avoids the need for an unused var.
251
252 * casefiddle.c (casify_region): Remove var that is set but not used.
253
254 * dired.c (file_name_completion): Remove var that is set but not used.
255
256 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
257
258 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
259 (Finsert_file_contents): Remove unnecessary code checking fd.
260
261 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
262 Check for integer overflow on size calculations.
263
264 * buffer.c (Fprevious_overlay_change): Remove var that is set
265 but not used.
266
267 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
268 Remove vars that are set but not used.
269 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
270 (timer_check_2): Mark vars as initialized.
271
272 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
273
274 * image.c (lookup_image): Remove var that is set but not used.
275 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
276
277 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
278 that are set but not used.
279
280 * xfns.c (make_invisible_cursor): Don't return garbage
281 if XCreateBitmapFromData fails (Bug#8410).
282
283 * xselect.c (x_get_local_selection, x_handle_property_notify):
284 Remove vars that are set but not used.
285
286 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
287 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
288
289 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
290 Remove var that is set but not used.
291 (scroll_bar_windows_size): Now size_t, not int.
292 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
293 Check for overflow.
294
295 * xfaces.c (realize_named_face): Remove vars that are set but not used.
296 (map_tty_color) [!defined MSDOS]: Likewise.
297
298 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
299
300 * coding.c: Remove vars that are set but not used.
301 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
302 All callers changed.
303 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
304 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
305 (decode_coding_charset): Remove vars that are set but not used.
306
307 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
308 that is set but not used.
309
310 * print.c (print_object): Remove var that is set but not used.
311
312 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
313 The gnulib version avoids calling malloc in the usual case,
314 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
315 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
316 * filelock.c (current_lock_owner): Likewise.
317 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
318 * sysdep.c: Include allocator.h, careadlinkat.h.
319 (emacs_no_realloc_allocator): New static constant.
320 (emacs_readlink): New function.
321 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
322 ../lib/careadlinkat.h.
323
324 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
325
326 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
327 first non-nil return value).
328
329 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
330
331 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
332 if not defined (Bug#8403).
333
334 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
335
336 * xdisp.c (display_count_lines): Remove parameter `start',
337 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
338 (get_char_face_and_encoding): Remove parameter `multibyte_p',
339 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
340 (fill_stretch_glyph_string): Remove parameters `row' and `area',
341 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
342 and thereabouts. All callers changed.
343 (get_per_char_metric): Remove parameter `f', unused since
344 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
345
346 2011-04-02 Jim Meyering <meyering@redhat.com>
347
348 do not dereference NULL upon failed strdup
349 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
350 (ns_get_family): Likewise.
351
352 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
353
354 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
355
356 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
357
358 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
359 later (Bug#8403).
360
361 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
362
363 Add lexical binding.
364
365 * window.c (Ftemp_output_buffer_show): New fun.
366 (Fsave_window_excursion):
367 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
368
369 * lread.c (lisp_file_lexically_bound_p): New function.
370 (Fload): Bind Qlexical_binding.
371 (readevalloop): Remove `evalfun' arg.
372 Bind Qinternal_interpreter_environment.
373 (Feval_buffer): Bind Qlexical_binding.
374 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
375 Mark as dynamic.
376 (syms_of_lread): Declare `lexical-binding'.
377
378 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
379
380 * keyboard.c (eval_dyn): New fun.
381 (menu_item_eval_property): Use it.
382
383 * image.c (parse_image_spec): Use Ffunctionp.
384
385 * fns.c (concat, mapcar1): Accept byte-code-functions.
386
387 * eval.c (Fsetq): Handle lexical vars.
388 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
389 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
390 (FletX, Flet): Obey lexical binding.
391 (Fcommandp): Handle closures.
392 (Feval): New `lexical' arg.
393 (eval_sub): New function extracted from Feval. Use it almost
394 everywhere where Feval was used. Look up vars in lexical env.
395 Handle closures.
396 (Ffunctionp): Move from subr.el.
397 (Ffuncall): Handle closures.
398 (apply_lambda): Remove `eval_flags'.
399 (funcall_lambda): Handle closures and new byte-code-functions.
400 (Fspecial_variable_p): New function.
401 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
402 but without exporting it to Lisp.
403
404 * doc.c (Fdocumentation, store_function_docstring):
405 * data.c (Finteractive_form): Handle closures.
406
407 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
408 interactive spec.
409
410 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
411 byte-codes.
412 (exec_byte_code): New function extracted from Fbyte_code to handle new
413 calling convention for byte-code-functions. Add new byte-codes.
414
415 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
416
417 * alloc.c (Fmake_symbol): Init new `declared_special' field.
418
419 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
420
421 * xdisp.c (redisplay_internal): Fix prototype.
422
423 2011-03-31 Eli Zaretskii <eliz@gnu.org>
424
425 * xdisp.c (SCROLL_LIMIT): New macro.
426 (try_scrolling): Use it when setting scroll_limit. Limit
427 scrolling to 100 screen lines.
428 (redisplay_window): Even when falling back on "recentering",
429 position point in the window according to scroll-conservatively,
430 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
431
432 (try_scrolling): When point is above the window, allow searching
433 as far as scroll_max, or one screenful, to compute vertical
434 distance from PT to the scroll margin position. This prevents
435 try_scrolling from unnecessarily failing when
436 scroll-conservatively is set to a value slightly larger than the
437 window height. Clean up the case of PT below the margin at bottom
438 of window: scroll_max can no longer be INT_MAX. When aggressive
439 scrolling is in use, don't let point enter the opposite scroll
440 margin as result of the scroll.
441 (syms_of_xdisp) <scroll-conservatively>: Document the
442 threshold of 100 lines for never-recentering scrolling.
443
444 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
445
446 * dispextern.h (move_it_by_lines):
447 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
448 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
449 (message_log_check_duplicate): Remove parameters `prev_bol' and
450 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
451 (redisplay_internal): Remove parameter `preserve_echo_area',
452 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
453
454 * indent.c (Fvertical_motion):
455 * window.c (window_scroll_pixel_based, Frecenter):
456 Don't pass `need_y_p' to `move_it_by_lines'.
457
458 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
459
460 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
461 steal a few bits to be more compact.
462 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
463 Remove unneeded casts.
464
465 * bytecode.c (Fbyte_code): CAR and CDR can GC.
466
467 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
468
469 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
470 binding" message (bug#7967).
471
472 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
473
474 Fix more problems found by GCC 4.6.0's static checks.
475
476 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
477 Remove unused local var.
478
479 * editfns.c (Fmessage_box): Remove unused local var.
480
481 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
482 (note_mode_line_or_margin_highlight, note_mouse_highlight):
483 Omit unused local vars.
484 * window.c (shrink_windows): Omit unused local var.
485 * menu.c (digest_single_submenu): Omit unused local var.
486 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
487 Omit unused local var.
488
489 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
490 Don't assume string length fits in int.
491 (keyremap_step, read_key_sequence): Use size_t for sizes.
492 (read_key_sequence): Don't check last_real_key_start redundantly.
493
494 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
495 instead of alloca (Bug#8344).
496
497 * eval.c (Fbacktrace): Don't assume nargs fits in int.
498 (Fbacktrace_frame): Don't assume nframes fits in int.
499
500 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
501
502 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
503 concerns.
504
505 * term.c (produce_glyphless_glyph): Remove unnecessary test.
506
507 * cm.c (calccost): Turn while-do into do-while, for clarity.
508
509 * keyboard.c (syms_of_keyboard): Use the same style as later
510 in this function when indexing through an array. This also
511 works around GCC bug 48267.
512
513 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
514
515 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
516
517 * chartab.c (sub_char_table_ref_and_range): Redo for slight
518 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
519
520 * keyboard.c, keyboard.h (num_input_events): Now size_t.
521 This avoids undefined behavior on integer overflow, and is a bit
522 more convenient anyway since it is compared to a size_t variable.
523
524 Variadic C functions now count arguments with size_t, not int.
525 This avoids an unnecessary limitation on 64-bit machines, which
526 caused (substring ...) to crash on large vectors (Bug#8344).
527 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
528 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
529 All variadic functions and their callers changed accordingly.
530 (struct gcpro.nvars): Now size_t, not int. All uses changed.
531 * data.c (arith_driver, float_arith_driver): Likewise.
532 * editfns.c (general_insert_function): Likewise.
533 * eval.c (struct backtrace.nargs, interactive_p)
534 (internal_condition_case_n, run_hook_with_args, apply_lambda)
535 (funcall_lambda, mark_backtrace): Likewise.
536 * fns.c (concat): Likewise.
537 * frame.c (x_set_frame_parameters): Likewise.
538 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
539 0 if not found, not -1. All callers changed.
540
541 * alloc.c (garbage_collect): Don't assume stack size fits in int.
542 (stack_copy_size): Now size_t, not int.
543 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
544
545 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
546
547 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
548 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
549 All callers changed.
550
551 * lisp.h (multibyte_char_to_unibyte):
552 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
553 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
554 * character.h (CHAR_TO_BYTE8):
555 * cmds.c (internal_self_insert):
556 * editfns.c (general_insert_function):
557 * keymap.c (push_key_description):
558 * search.c (Freplace_match):
559 * xdisp.c (message_dolog, set_message_1): All callers changed.
560
561 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
562
563 * keyboard.c (safe_run_hook_funcall): New function.
564 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
565 don't set the hook to nil, but remove the offending function instead.
566 (Qcommand_hook_internal): Remove, unused.
567 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
568 Vcommand_hook_internal.
569
570 * eval.c (enum run_hooks_condition): Remove.
571 (funcall_nil, funcall_not): New functions.
572 (run_hook_with_args): Call each function through a `funcall' argument.
573 Remove `cond' argument, now redundant.
574 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
575 (Frun_hook_with_args_until_failure): Adjust accordingly.
576 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
577
578 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
579
580 * dispextern.h (string_buffer_position): Remove declaration.
581
582 * print.c (strout): Remove parameter `multibyte', unused since
583 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
584
585 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
586 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
587 All callers changed.
588
589 * w32.c (_wsa_errlist): Use braces for struct initializers.
590
591 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
592 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
593 All callers changed.
594 (string_buffer_position): Likewise. Also, make static (it's never
595 used outside xdisp.c).
596 (cursor_row_p): Remove parameter `w', unused since
597 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
598 (decode_mode_spec): Remove parameter `precision', introduced during
599 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
600 All callers changed.
601
602 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
603
604 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
605
606 2011-03-27 Anders Lindgren <andlind@gmail.com>
607
608 * nsterm.m (ns_menu_bar_is_hidden): New variable.
609 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
610 (ns_update_auto_hide_menu_bar): New functions.
611 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
612 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
613 ns_constrain_all_frames.
614 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
615 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
616
617 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
618
619 * nsmenu.m (runDialogAt): Remove argument to timer_check.
620
621 2011-03-27 Glenn Morris <rgm@gnu.org>
622
623 * syssignal.h: Replace RETSIGTYPE with void.
624 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
625 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
626 Replace SIGTYPE with void everywhere.
627 * s/usg5-4-common.h (SIGTYPE): Remove definition.
628 * s/template.h (SIGTYPE): Remove commented out definition.
629
630 2011-03-26 Eli Zaretskii <eliz@gnu.org>
631
632 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
633 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
634
635 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
636
637 * w32.c (read_unc_volume): Use parameter `henum', instead of
638 global variable `wget_enum_handle'.
639
640 * keymap.c (describe_vector): Remove parameters `indices' and
641 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
642 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
643
644 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
645
646 * keyboard.c (timer_check): Remove parameter `do_it_now',
647 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
648 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
649 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
650
651 * keyboard.c (read_char):
652 * w32menu.c (w32_menu_display_help):
653 * xmenu.c (show_help_event, menu_help_callback):
654 Adjust calls to `show_help_echo'.
655
656 * gtkutil.c (xg_maybe_add_timer):
657 * keyboard.c (readable_events):
658 * process.c (wait_reading_process_output):
659 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
660
661 * insdel.c (adjust_markers_gap_motion):
662 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
663 (gap_left, gap_right): Don't call it.
664
665 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
666
667 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
668 incurred during fontification.
669
670 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
671
672 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
673 (DEFVAR_PER_BUFFER): Don't pass it.
674
675 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
676 (scrolling_window): Don't pass it.
677
678 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
679
680 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
681
682 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
683 and `suffix'.
684 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
685 of variables specific to SELinux and computation of `encoded_absname'.
686
687 * image.c (XPutPixel): Remove unused variable `height'.
688
689 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
690
691 * unexw32.c (get_section_info): Remove unused variable `section'.
692
693 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
694 (system_process_attributes): Remove unused variable `sess'.
695 (sys_read): Remove unused variable `err'.
696
697 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
698 (w32_wnd_proc): Remove unused variable `isdead'.
699 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
700 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
701 (x_create_tip_frame): Remove unused variable `tem'.
702
703 * w32inevt.c (w32_console_read_socket):
704 Remove unused variable `no_events'.
705
706 * w32term.c (x_draw_composite_glyph_string_foreground):
707 Remove unused variable `width'.
708
709 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
710
711 * w32term.c (x_set_glyph_string_clipping):
712 Don't pass uninitialized region to CombineRgn.
713
714 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
715
716 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
717 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
718 (Fx_close_connection): Remove unused variable `i'.
719
720 * w32font.c (w32font_draw): Return number of glyphs.
721 (w32font_open_internal): Remove unused variable `i'.
722 (w32font_driver): Add missing initializer.
723
724 * w32menu.c (utf8to16): Remove unused variable `utf16'.
725 (fill_in_menu): Remove unused variable `items_added'.
726
727 * w32term.c (last_mouse_press_frame): Remove static global variable.
728 (w32_clip_to_row): Remove unused variable `f'.
729 (x_delete_terminal): Remove unused variable `i'.
730
731 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
732 (NOTHING): Remove unused static global variable.
733 (uniscribe_check_otf): Remove unused variable `table'.
734 (uniscribe_font_driver): Add missing initializers.
735
736 2011-03-23 Julien Danjou <julien@danjou.info>
737
738 * term.c (Fsuspend_tty, Fresume_tty):
739 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
740 * window.c (temp_output_buffer_show):
741 * insdel.c (signal_before_change):
742 * frame.c (Fhandle_switch_frame):
743 * fileio.c (Fdo_auto_save):
744 * emacs.c (Fkill_emacs):
745 * editfns.c (save_excursion_restore):
746 * cmds.c (internal_self_insert):
747 * callint.c (Fcall_interactively):
748 * buffer.c (Fkill_all_local_variables):
749 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
750 Use Frun_hooks.
751 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
752 unconditionnaly since it does the check itself.
753
754 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
755
756 Fix more problems found by GCC 4.5.2's static checks.
757
758 * coding.c (encode_coding_raw_text): Avoid unnecessary test
759 the first time through the loop, since we know p0 < p1 then.
760 This also avoids a gcc -Wstrict-overflow warning.
761
762 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
763 leading to a memory leak, possible in functions like
764 load_charset_map_from_file that can allocate an unbounded number
765 of objects (Bug#8318).
766
767 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
768 that could (at least in theory) be that large.
769
770 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
771 This is less likely to overflow, and avoids undefined behavior if
772 overflow does occur. All callers changed. Use strtoul to scan
773 for the unsigned long integer.
774 (pint2hrstr): Simplify and tune code slightly.
775 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
776
777 * scroll.c (do_scrolling): Work around GCC bug 48228.
778 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
779
780 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
781 This also avoids a warning with gcc -Wstrict-overflow.
782 (validate_x_resource_name): Simplify count usage.
783 This also avoids a warning with gcc -Wstrict-overflow.
784
785 * fileio.c (Fcopy_file): Report error if fchown or fchmod
786 fail (Bug#8306).
787
788 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
789
790 * process.c (Fmake_network_process): Use socklen_t, not int,
791 where POSIX says socklen_t is required in portable programs.
792 This fixes a porting bug on hosts like 64-bit HP-UX, where
793 socklen_t is wider than int (Bug#8277).
794 (Fmake_network_process, server_accept_connection):
795 (wait_reading_process_output, read_process_output):
796 Likewise.
797
798 * process.c: Rename or move locals to avoid shadowing.
799 (list_processes_1, Fmake_network_process):
800 (read_process_output_error_handler, exec_sentinel_error_handler):
801 Rename or move locals.
802 (Fmake_network_process): Define label "retry_connect" only if needed.
803 (Fnetwork_interface_info): Fix pointer signedness.
804 (process_send_signal): Add cast to avoid pointer signedness problem.
805 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
806 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
807
808 Make tparam.h and terminfo.c consistent.
809 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
810 Include tparam.h instead, since it declares them.
811 * cm.h (PC): Remove extern decl; tparam.h now does this.
812 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
813 * terminfo.c: Include tparam.h, to check interfaces.
814 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
815 (tparam): Adjust signature to match interface in tparam.h;
816 this removes some undefined behavior. Check that outstring and len
817 are zero, which they always are with Emacs.
818 * tparam.h (PC, BC, UP): New extern decls.
819
820 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
821 (xftfont_open): Rename locals to avoid shadowing.
822
823 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
824 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
825 (OTF_TAG_SYM): Omit macro if not needed.
826 (ftfont_list): Remove unused local.
827 (get_adstyle_property, ftfont_pattern_entity):
828 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
829 Rename locals to avoid shadowing.
830
831 * xfont.c (xfont_list_family): Mark var as initialized.
832
833 * xml.c (make_dom): Now static.
834
835 * composite.c (composition_compute_stop_pos): Rename local to
836 avoid shadowing.
837 (composition_reseat_it): Remove unused locals.
838 (find_automatic_composition, composition_adjust_point): Likewise.
839 (composition_update_it): Mark var as initialized.
840 (find_automatic_composition): Mark vars as initialized,
841 with a FIXME (Bug#8290).
842
843 character.h: Rename locals to avoid shadowing.
844 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
845 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
846 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
847 (BUF_DEC_POS): Be more systematic about renaming local temporaries
848 to avoid shadowing.
849
850 * textprop.c (property_change_between_p): Remove; unused.
851
852 * intervals.c (interval_start_pos): Now static.
853
854 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
855
856 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
857 Rename locals to avoid shadowing.
858
859 * sound.c (wav_play, au_play, Fplay_sound_internal):
860 Fix pointer signedness.
861 (alsa_choose_format): Remove unused local var.
862 (wav_play): Initialize a variable to 0, to prevent undefined
863 behavior (Bug#8278).
864
865 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
866
867 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
868
869 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
870 clobbering (Bug#8298).
871 * sysdep.c (sys_subshell): Likewise.
872 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
873
874 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
875 This should get cleaned up, so that child_setup has the
876 same signature on all platforms.
877
878 * callproc.c (call_process_cleanup): Now static.
879 (relocate_fd): Rename locals to avoid shadowing.
880
881 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
882
883 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
884 not to be necessary, and produces flickering.
885
886 2011-03-20 Glenn Morris <rgm@gnu.org>
887
888 * config.in: Remove file.
889
890 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
891
892 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
893 are now in src/globals.h.
894 (syms_of_minibuf): Remove spurious & from previous change.
895
896 2011-03-20 Leo <sdl.web@gmail.com>
897
898 * minibuf.c (completing-read-function): New variable.
899 (completing-read-default): Rename from completing-read.
900 (completing-read): Call completing-read-function.
901
902 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
903
904 * xfaces.c (Fx_load_color_file):
905 Read color file from absolute filename (bug#8250).
906
907 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
908
909 * makefile.w32-in: Update dependencies.
910
911 2011-03-17 Eli Zaretskii <eliz@gnu.org>
912
913 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
914
915 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
916
917 Fix more problems found by GCC 4.5.2's static checks.
918
919 * process.c (make_serial_process_unwind, send_process_trap):
920 (sigchld_handler): Now static.
921
922 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
923 That way, the code declares only the vars that it needs.
924 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
925 * s/cygwin.h (PTY_ITERATION): Likewise.
926 * s/darwin.h (PTY_ITERATION): Likewise.
927 * s/gnu-linux.h (PTY_ITERATION): Likewise.
928
929 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
930 * process.c (allocate_pty): Don't declare stb unless it's needed.
931
932 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
933 (CONSTANTLIM): Remove; unused.
934 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
935 Define only if needed.
936
937 * unexelf.c (unexec): Name an expression,
938 to avoid gcc -Wbad-function-cast warning.
939 Use a different way to cause a compilation error if anyone uses
940 n rather than nn, a way that does not involve shadowing.
941 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
942
943 * deps.mk (unexalpha.o): Remove; unused.
944
945 New file unexec.h, the (simple) interface for unexec (Bug#8267).
946 * unexec.h: New file.
947 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
948 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
949 Depend on unexec.h.
950 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
951 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
952 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
953 Change as necessary to match prototype in unexec.h.
954
955 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
956 shadowing.
957 (back_comment, skip_chars): Mark vars as initialized.
958
959 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
960 Rename locals to avoid shadowing.
961
962 * lread.c (read1): Rewrite so as not to use empty "else".
963 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
964
965 * print.c (Fredirect_debugging_output): Fix pointer signedess.
966
967 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
968 warning when compiling print.c.
969
970 * font.c (font_unparse_fcname): Abort in an "impossible" situation
971 instead of using an uninitialized var.
972 (font_sort_entities): Mark var as initialized.
973
974 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
975
976 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
977 pointers to constants.
978 (font_parse_fcname): Remove unused vars.
979 (font_delete_unmatched): Now static.
980 (font_get_spec): Remove; unused.
981 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
982 (font_update_drivers, Ffont_get_glyphs, font_add_log):
983 Rename or move locals to avoid shadowing.
984
985 * fns.c (require_nesting_list, require_unwind): Now static.
986 (Ffillarray): Rename locals to avoid shadowing.
987
988 * floatfns.c (domain_error2): Define only if needed.
989 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
990
991 * alloc.c (mark_backtrace): Move decl from here ...
992 * lisp.h: ... to here, so that it can be checked.
993
994 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
995 (Fdefvar): Rewrite so as not to use empty "else".
996 (lisp_indirect_variable): Name an expression,
997 to avoid gcc -Wbad-function-cast warning.
998 (Fdefvar): Rename locals to avoid shadowing.
999
1000 * callint.c (quotify_arg, quotify_args): Now static.
1001 (Fcall_interactively): Rename locals to avoid shadowing.
1002 Use const pointer when appropriate.
1003
1004 * lisp.h (get_system_name, get_operating_system_release):
1005 Move decls here, to check interfaces.
1006 * process.c (get_operating_system_release): Move decl to lisp.h.
1007 * xrdb.c (get_system_name): Likewise.
1008 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
1009 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
1010 some of which prompt warnings from gcc -Wbad-function-cast.
1011 (Fformat_time_string, Fencode_time, Finsert_char):
1012 (Ftranslate_region_internal, Fformat):
1013 Rename or remove local vars to avoid shadowing.
1014 (Ftranslate_region_internal): Mark var as initialized.
1015
1016 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
1017 avoid shadowing.
1018
1019 * lisp.h (eassert): Check that the argument compiles, even if
1020 ENABLE_CHECKING is not defined.
1021
1022 * data.c (Findirect_variable): Name an expression, to avoid
1023 gcc -Wbad-function-cast warning.
1024 (default_value, arithcompare, arith_driver, arith_error): Now static.
1025 (store_symval_forwarding): Rename local to avoid shadowing.
1026 (Fmake_variable_buffer_local, Fmake_local_variable):
1027 Mark variables as initialized.
1028 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
1029
1030 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
1031 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
1032 Rename locals to avoid shadowing.
1033 (mark_stack): Move local variables into the #ifdef region where
1034 they're used.
1035 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
1036 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
1037 needed otherwise.
1038 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
1039 (GC_STRING_CHARS): Remove; not used.
1040 (Fmemory_limit): Cast sbrk's returned value to char *.
1041
1042 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
1043 avoids undefined behavior in theory.
1044
1045 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
1046
1047 Use functions, not macros, for up- and down-casing (Bug#8254).
1048 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1049 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
1050 to use the following functions instead of these macros.
1051 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
1052 EMACS_INT, since callers assume the returned value fits in int.
1053 (upcase1): Likewise, for UPCASE_TABLE.
1054 (uppercasep, lowercasep, upcase): New static inline functions.
1055 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
1056 the race-condition problem in the old DOWNCASE.
1057
1058 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
1059 Rename locals to avoid shadowing.
1060 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
1061 (regex_compile, re_search_2, re_match_2_internal):
1062 Remove unused local vars.
1063 (FREE_VAR): Rewrite so as not to use empty "else",
1064 which gcc can warn about.
1065 (regex_compile, re_match_2_internal): Mark locals as initialized.
1066 (RETALLOC_IF): Define only if needed.
1067 (WORDCHAR_P): Likewise. This one is never needed, but is used
1068 only in a comment talking about a compiler bug, so put inside
1069 the #if 0 of that comment.
1070 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
1071 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
1072 Remove; unused.
1073
1074 * search.c (boyer_moore): Rename locals to avoid shadowing.
1075 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
1076 (PREV_CHAR_BOUNDARY): Likewise.
1077
1078 * search.c (simple_search): Remove unused var.
1079
1080 * dired.c (compile_pattern): Move decl from here ...
1081 * lisp.h: ... to here, so that it can be checked.
1082 (struct re_registers): New forward decl.
1083
1084 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
1085
1086 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
1087 All uses changed.
1088 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
1089 Rename locals to avoid shadowing.
1090 (Fvertical_motion): Mark locals as initialized.
1091
1092 * casefiddle.c (casify_object, casify_region): Now static.
1093 (casify_region): Mark local as initialized.
1094
1095 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
1096
1097 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
1098 New macros, so that the caller can use some names other than
1099 gcpro1, gcpro2, etc.
1100 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
1101 of the new macros.
1102 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
1103 argument, for consistency with GCPRO2_VAR, etc: it is now the
1104 prefix of the variable, not the variable itself. All uses
1105 changed.
1106 * dired.c (directory_files_internal, file_name_completion):
1107 Rename locals to avoid shadowing.
1108
1109 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
1110 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
1111 dired.c's scmp function, had undefined behavior.
1112 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1113 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
1114 * buffer.h: ... to here, because these macros use current_buffer,
1115 and the new implementation with inline functions needs to have
1116 current_buffer in scope now, rather than later when the macros
1117 are used.
1118 (downcase, upcase1): New static inline functions.
1119 (DOWNCASE, UPCASE1): Reimplement using these functions.
1120 This avoids undefined behavior in expressions like
1121 DOWNCASE (x) == DOWNCASE (y), which previously suffered
1122 from race conditions in accessing the global variables
1123 case_temp1 and case_temp2.
1124 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
1125 * lisp.h (case_temp1, case_temp2): Remove their decls.
1126 * character.h (ASCII_CHAR_P): Move from here ...
1127 * lisp.h: ... to here, so that the inline functions mentioned
1128 above can use them.
1129
1130 * dired.c (directory_files_internal_unwind): Now static.
1131
1132 * fileio.c (file_name_as_directory, directory_file_name):
1133 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
1134 Now static.
1135 (file_name_as_directory): Use const pointers when appropriate.
1136 (Fexpand_file_name): Likewise. In particular, newdir might
1137 point at constant storage, so make it a const pointer.
1138 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
1139 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
1140 signedness issues.
1141 (Fset_file_times, Finsert_file_contents, auto_save_error):
1142 Rename locals to avoid shadowing.
1143
1144 * minibuf.c (choose_minibuf_frame_1): Now static.
1145 (Ftry_completion, Fall_completions): Rename or remove locals
1146 to avoid shadowing.
1147
1148 * marker.c (bytepos_to_charpos): Remove; unused.
1149
1150 * lisp.h (verify_bytepos, count_markers): New decls,
1151 so that gcc does not warn that these functions aren't declared.
1152
1153 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
1154 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
1155 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
1156 (copy_text): Remove unused local var.
1157
1158 * filelock.c (within_one_second): Now static.
1159 (lock_file_1): Rename local to avoid shadowing.
1160
1161 * buffer.c (fix_overlays_before): Mark locals as initialized.
1162 (fix_start_end_in_overlays): Likewise. This function should be
1163 simplified by using pointers-to-pointers, but that's a different
1164 matter.
1165 (switch_to_buffer_1): Now static.
1166 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
1167 (report_overlay_modification): Rename locals to avoid shadowing.
1168
1169 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
1170 Fix pointer signedness issue.
1171 (sys_subshell): Mark local as volatile if checking for lint,
1172 to suppress a gcc -Wclobbered warning that does not seem to be right.
1173 (MAXPATHLEN): Define only if needed.
1174
1175 * process.c (serial_open, serial_configure): Move decls from here ...
1176 * systty.h: ... to here, so that they can be checked.
1177
1178 * fns.c (get_random, seed_random): Move extern decls from here ...
1179 * lisp.h: ... to here, so that they can be checked.
1180
1181 * sysdep.c (reset_io): Now static.
1182 (wait_for_termination_signal): Remove; unused.
1183
1184 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
1185 (copy_keymap_item, append_key, push_text_char_description):
1186 Now static.
1187 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
1188 (DENSE_TABLE_SIZE): Remove; unused.
1189 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
1190 (describe_map_tree):
1191 Rename locals to avoid shadowing.
1192
1193 * keyboard.c: Declare functions static if they are not used elsewhere.
1194 (echo_char, echo_dash, cmd_error, top_level_2):
1195 (poll_for_input, handle_async_input): Now static.
1196 (read_char, kbd_buffer_get_event, make_lispy_position):
1197 (make_lispy_event, make_lispy_movement, apply_modifiers):
1198 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
1199 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
1200 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
1201 (read_key_sequence, read_char): Mark locals as initialized.
1202 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
1203
1204 * keyboard.h (make_ctrl_char): New decl.
1205 (mark_kboards): Move decl here ...
1206 * alloc.c (mark_kboards): ... from here.
1207
1208 * lisp.h (force_auto_save_soon): New decl.
1209
1210 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
1211 (DEFINE_DUMMY_FUNCTION): New macro.
1212 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
1213 Use it.
1214 (main): Add casts to avoid warnings
1215 if GCC considers string literals to be constants.
1216
1217 * lisp.h (fatal_error_signal): Add decl, since it's exported.
1218
1219 * dbusbind.c: Pointer signedness fixes.
1220 (xd_signature, xd_append_arg, xd_initialize):
1221 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1222 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1223 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
1224 (Fdbus_register_signal): Use SSDATA when the context wants char *.
1225
1226 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
1227 if GCC considers string literals to be constants.
1228 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
1229
1230 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
1231
1232 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
1233 (print_preprocess, print_object): New macro to fix last change.
1234
1235 * print.c (print_preprocess): Don't forget font objects.
1236
1237 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
1238
1239 * emacs.c (USAGE3): Doc fixes.
1240
1241 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
1242
1243 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
1244 structure.
1245
1246 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
1247
1248 * lisp.h (VWindow_system, Qfile_name_history):
1249 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
1250 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
1251 (w32_system_caret_x, w32_system_caret_y): Declare extern.
1252
1253 * w32select.c: Don't #include "keyboard.h".
1254 (run_protected): Add extern declaration for waiting_for_input.
1255
1256 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
1257 * w32console.c (detect_input_pending, read_input_pending)
1258 (encode_terminal_code):
1259 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
1260 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
1261 (w32_system_caret_y, Qfile_name_history):
1262 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
1263 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
1264 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
1265 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
1266 * w32proc.c (Qlocal, report_file_error):
1267 * w32term.c (Vwindow_system, updating_frame):
1268 * w32uniscribe.c (initialized, uniscribe_font_driver):
1269 Remove unneeded extern declarations.
1270
1271 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
1272
1273 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
1274
1275 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
1276
1277 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
1278 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
1279 These macros can no longer be used for assignment.
1280
1281 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1282 Assign struct members directly, instead of using BUF_BEGV etc.
1283 (record_buffer_markers, fetch_buffer_markers): New functions for
1284 recording and fetching special buffer markers.
1285 (set_buffer_internal_1, set_buffer_temp): Use them.
1286
1287 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
1288
1289 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
1290
1291 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
1292 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
1293
1294 * xdisp.c (hscroll_window_tree):
1295 (reconsider_clip_changes): Use PT instead of BUF_PT.
1296
1297 2011-03-13 Eli Zaretskii <eliz@gnu.org>
1298
1299 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
1300 $(EMACS_ROOT)/lib/intprops.h.
1301
1302 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
1303
1304 Fix more problems found by GCC 4.5.2's static checks.
1305
1306 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
1307 to unsigned char * to avoid compiler diagnostic.
1308 (xg_free_frame_widgets): Make it clear that a local variable is
1309 needed only if USE_GTK_TOOLTIP.
1310 (gdk_window_get_screen): Make it clear that this macro is needed
1311 only if USE_GTK_TOOLTIP.
1312 (int_gtk_range_get_value): New function, which avoids a diagnostic
1313 from gcc -Wbad-function-cast.
1314 (xg_set_toolkit_scroll_bar_thumb): Use it.
1315 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
1316 diagnostic from gcc -Wbad-function-cast.
1317 (get_utf8_string, xg_get_file_with_chooser):
1318 Rename locals to avoid shadowing.
1319 (create_dialog): Move locals to avoid shadowing.
1320
1321 * xgselect.c (xg_select): Remove unused var.
1322
1323 * image.c (four_corners_best): Mark locals as initialized.
1324 (gif_load): Initialize transparent_p to zero (Bug#8238).
1325 Mark another local as initialized.
1326 (my_png_error, my_error_exit): Mark with NO_RETURN.
1327
1328 * image.c (clear_image_cache): Now static.
1329 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
1330 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
1331 (x_edge_detection): Remove unnecessary cast that
1332 gcc -Wbad-function-cast diagnoses.
1333 (gif_load): Fix pointer signedness.
1334 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
1335 (jpeg_load, gif_load): Rename locals to avoid shadowing.
1336
1337 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
1338
1339 Improve quality of tests for time stamp overflow.
1340 For example, without this patch (encode-time 0 0 0 1 1
1341 1152921504606846976) returns the obviously-bogus value (-948597
1342 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
1343 reports time overflow. See
1344 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
1345 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
1346 * editfns.c: Include limits.h and intprops.h.
1347 (TIME_T_MIN, TIME_T_MAX): New macros.
1348 (time_overflow): Move earlier, to before first use.
1349 (hi_time, lo_time): New functions, for an accurate test for
1350 out-of-range times.
1351 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
1352 (Fget_internal_run_time): Don't assume time_t fits in int.
1353 (make_time): Use list2 instead of Fcons twice.
1354 (Fdecode_time): More accurate test for out-of-range times.
1355 (check_tm_member): New function.
1356 (Fencode_time): Use it, to test for out-of-range times.
1357 (lisp_time_argument): Don't rely on undefined left-shift and
1358 right-shift behavior when checking for time stamp overflow.
1359
1360 * editfns.c (time_overflow): New function, refactoring common code.
1361 (Fformat_time_string, Fdecode_time, Fencode_time):
1362 (Fcurrent_time_string): Use it.
1363
1364 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
1365 * dired.c (make_time): Move to ...
1366 * editfns.c (make_time): ... here.
1367 * systime.h: Note the move.
1368
1369 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1370
1371 * fringe.c (update_window_fringes): Remove unused variables.
1372
1373 * unexmacosx.c (copy_data_segment): Also copy __got section.
1374 (Bug#8223)
1375
1376 2011-03-12 Eli Zaretskii <eliz@gnu.org>
1377
1378 * termcap.c [MSDOS]: Include "msdos.h".
1379 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
1380 Constify `char *' arguments and their references according to
1381 prototypes in tparam.h.
1382
1383 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
1384
1385 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
1386 Adapt all references accordingly.
1387
1388 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
1389
1390 2011-03-11 Tom Tromey <tromey@redhat.com>
1391
1392 * buffer.c (syms_of_buffer): Remove obsolete comment.
1393
1394 2011-03-11 Eli Zaretskii <eliz@gnu.org>
1395
1396 * termhooks.h (encode_terminal_code): Declare prototype.
1397
1398 * msdos.c (encode_terminal_code): Don't declare prototype.
1399
1400 * term.c (encode_terminal_code): Now external again, used by
1401 w32console.c and msdos.c.
1402
1403 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
1404 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
1405
1406 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
1407
1408 Fix some minor problems found by GCC 4.5.2's static checks.
1409
1410 * fringe.c (update_window_fringes): Mark locals as initialized
1411 (Bug#8227).
1412 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
1413
1414 * alloc.c (mark_fringe_data): Move decl from here ...
1415 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
1416 to check its interface.
1417 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
1418
1419 * fontset.c (free_realized_fontset): Now static.
1420 (Fset_fontset_font): Rename local to avoid shadowing.
1421 (fontset_font): Mark local as initialized.
1422 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
1423
1424 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
1425
1426 * xselect.c (x_disown_buffer_selections): Remove; not used.
1427 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
1428 (x_own_selection, Fx_disown_selection_internal): Rename locals
1429 to avoid shadowing.
1430 (x_handle_dnd_message): Remove local to avoid shadowing.
1431
1432 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
1433 so that the caller can use some name other than gcpro1.
1434 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
1435 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1436 (Fx_backspace_delete_keys_p):
1437 Use them to avoid shadowing, and rename vars to avoid shadowing.
1438 (x_decode_color, x_set_name, x_window): Now static.
1439 (Fx_create_frame): Add braces to silence GCC warning.
1440 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
1441 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
1442 Remove unused locals.
1443 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1444 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
1445 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
1446 macros.
1447
1448 * xterm.h (x_mouse_leave): New decl.
1449
1450 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
1451 Remove unused functions.
1452 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
1453 (x_calc_absolute_position): Now static.
1454 (XTread_socket): Don't define label "out" unless it's used.
1455 Don't declare local "event" unless it's used.
1456 (x_iconify_frame, x_free_frame_resources): Don't declare locals
1457 unless they are used.
1458 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
1459 (x_fatal_error_signal): Remove; not used.
1460 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
1461 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
1462 (x_error_catcher, x_connection_closed, x_error_handler):
1463 (x_error_quitter, xembed_send_message, x_iconify_frame):
1464 (my_log_handler): Rename locals to avoid shadowing.
1465 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
1466 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
1467
1468 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
1469 Rename or move locals to avoid shadowing.
1470 (tty_defined_color, merge_face_heights): Now static.
1471 (free_realized_faces_for_fontset): Remove; not used.
1472 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
1473 does not deduce is never used uninitialized.
1474 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
1475 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
1476
1477 * terminal.c (store_terminal_param): Now static.
1478
1479 * xmenu.c (menu_highlight_callback): Now static.
1480 (set_frame_menubar): Remove unused local.
1481 (xmenu_show): Rename parameter to avoid shadowing.
1482 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
1483 since they might point to immutable storage.
1484 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
1485 since it's unused otherwise.
1486
1487 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
1488 Add a FIXME, since the code still doesn't look right. (Bug#8215)
1489 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
1490 avoids a gcc -Wuninitialized diagnostic.
1491 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
1492 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
1493 does not deduce are never used uninitialized.
1494
1495 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
1496
1497 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
1498 * window.c (window_loop, size_window):
1499 (run_window_configuration_change_hook, enlarge_window): Likewise.
1500
1501 * window.c (display_buffer): Now static.
1502 (size_window): Mark variables that gcc -Wuninitialized
1503 does not deduce are never used uninitialized.
1504 * window.h (check_all_windows): New decl, to forestall
1505 gcc -Wmissing-prototypes diagnostic.
1506 * dispextern.h (bidi_dump_cached_states): Likewise.
1507
1508 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
1509 shadowing.
1510 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
1511 Include <limits.h>.
1512 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
1513 and to avoid gcc -Wuninitialized warning.
1514 (load_charset_map): Mark variables that gcc -Wuninitialized
1515 does not deduce are never used uninitialized.
1516 (load_charset): Abort instead of using uninitialized var (Bug#8229).
1517
1518 * coding.c (coding_set_source, coding_set_destination):
1519 Use "else { /* comment */ }" rather than "else /* comment */;"
1520 for clarity, and to avoid gcc -Wempty-body warning.
1521 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
1522 a block, when the outer 'i' will do.
1523 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
1524 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
1525 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
1526 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
1527 (Fdecode_sjis_char, Fdefine_coding_system_internal):
1528 Rename locals to avoid shadowing.
1529 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
1530 * coding.c (emacs_mule_char, encode_invocation_designation):
1531 Now static, since they're not used elsewhere.
1532 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
1533 (decode_coding_object, encode_coding_object, detect_coding_system):
1534 (decode_coding_emacs_mule): Mark variables that gcc
1535 -Wuninitialized does not deduce are never used uninitialized.
1536 (detect_coding_iso_2022): Initialize a local variable that might
1537 be used uninitialized. Leave a FIXME because it's not clear that
1538 this initialization is needed. (Bug#8211)
1539 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
1540 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
1541 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
1542 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
1543 Remove unused macros.
1544
1545 * category.c (hash_get_category_set): Remove unused local var.
1546 (copy_category_table): Now static, since it's not used elsewhere.
1547 * character.c (string_count_byte8): Likewise.
1548
1549 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
1550 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
1551
1552 * chartab.c (copy_sub_char_table): Now static, since it's not used
1553 elsewhere.
1554 (sub_char_table_ref_and_range, char_table_ref_and_range):
1555 Rename locals to avoid shadowing.
1556 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
1557
1558 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
1559 (BIDI_BOB): Remove unused macro.
1560
1561 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
1562 deduce are never used uninitialized.
1563 * term.c (encode_terminal_code): Likewise.
1564
1565 * term.c (encode_terminal_code): Now static. Remove unused local.
1566
1567 * tparam.h: New file.
1568 * term.c, tparam.h: Include it.
1569 * deps.mk (term.o, tparam.o): Depend on tparam.h.
1570 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
1571 Move these decls to tparam.h, and make them agree with what
1572 is actually in tparam.c. The previous trick of using incompatible
1573 decls in different modules does not conform to the C standard.
1574 All callers of tparam changed to use tparam's actual API.
1575 * tparam.c (tparam1, tparam, tgoto):
1576 Use const pointers where appropriate.
1577
1578 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
1579 * cm.h (struct cm): Likewise.
1580 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
1581 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
1582 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
1583 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
1584 (turn_on_face, init_tty): Likewise.
1585 * termchar.h (struct tty_display_info): Likewise.
1586
1587 * term.c (term_mouse_position): Rename local to avoid shadowing.
1588
1589 * alloc.c (mark_ttys): Move decl from here ...
1590 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
1591
1592 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
1593
1594 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
1595
1596 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
1597
1598 * search.c (compile_pattern_1): Remove argument regp, unused since
1599 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
1600 (compile_pattern): Don't pass it.
1601
1602 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
1603
1604 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
1605 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
1606 for ! HAVE_GTK3.
1607 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
1608
1609 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
1610
1611 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
1612 gdk_window_get_screen, gdk_window_get_geometry,
1613 gdk_x11_window_lookup_for_display and GDK_KEY_g.
1614 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
1615 (xg_get_pixbuf_from_pixmap): New function.
1616 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
1617 to Pixmap, take frame as parameter, remove GdkColormap parameter.
1618 Call xg_get_pixbuf_from_pixmap instead of
1619 gdk_pixbuf_get_from_drawable.
1620 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
1621 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
1622 (xg_check_special_colors): Use GtkStyleContext and its functions
1623 for HAVE_GTK3.
1624 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
1625 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
1626 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
1627 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
1628 Call gtk_widget_get_preferred_size.
1629 (xg_frame_resized): gdk_window_get_geometry only takes 5
1630 parameters.
1631 (xg_win_to_widget, xg_event_is_for_menubar):
1632 Call gdk_x11_window_lookup_for_display.
1633 (xg_set_widget_bg): New function.
1634 (delete_cb): New function.
1635 (xg_create_frame_widgets): connect delete-event to delete_cb.
1636 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
1637 (xg_set_background_color): Call xg_set_widget_bg.
1638 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
1639 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
1640 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
1641 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
1642 if ! HAVE_GTK3.
1643 (update_frame_tool_bar): Call gtk_widget_hide.
1644 (xg_initialize): Use GDK_KEY_g.
1645
1646 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
1647 if ! HAVE_GTK3
1648 (x_session_initialize): Call gdk_x11_set_sm_client_id.
1649
1650 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
1651 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
1652 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
1653
1654 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
1655
1656 * w32xfns.c (select_palette): Check success of RealizePalette against
1657 GDI_ERROR, not zero.
1658
1659 See ChangeLog.11 for earlier changes.
1660
1661 ;; Local Variables:
1662 ;; coding: utf-8
1663 ;; End:
1664
1665 Copyright (C) 2011 Free Software Foundation, Inc.
1666
1667 This file is part of GNU Emacs.
1668
1669 GNU Emacs is free software: you can redistribute it and/or modify
1670 it under the terms of the GNU General Public License as published by
1671 the Free Software Foundation, either version 3 of the License, or
1672 (at your option) any later version.
1673
1674 GNU Emacs is distributed in the hope that it will be useful,
1675 but WITHOUT ANY WARRANTY; without even the implied warranty of
1676 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
1677 GNU General Public License for more details.
1678
1679 You should have received a copy of the GNU General Public License
1680 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.