1 2012-06-01 Chong Yidong <cyd@gnu.org>
3 * Version 24.1 released.
5 2012-05-30 Eli Zaretskii <eliz@gnu.org>
7 * xdisp.c (handle_stop): Detect whether we have overlay strings
8 loaded by testing it->current.overlay_string_index to be
9 non-negative, instead of checking whether n_overlay_strings is
12 2012-05-30 Chong Yidong <cyd@gnu.org>
14 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
16 * doc.c (Fsubstitute_command_keys): Doc fix.
18 2012-05-29 Eli Zaretskii <eliz@gnu.org>
20 * search.c (search_buffer): Remove calls to
21 r_alloc_inhibit_buffer_relocation, as it is now called by
22 maybe_unify_char, which was the cause of relocation of buffer text
25 2012-05-23 Eli Zaretskii <eliz@gnu.org>
27 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
28 for the duration of call to load_charset, to avoid problems with
29 callers of maybe_unify_char that access buffer text through C
32 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
33 decrement the inhibition flag, instead of just setting or
36 2012-05-24 Ken Brown <kbrown@cornell.edu>
38 * callproc.c (Fcall_process): Restore a line that was accidentally
39 commented out in the 2011-02-13 change (bug#11547).
41 2012-05-23 Eli Zaretskii <eliz@gnu.org>
43 * lisp.h [REL_ALLOC]: Add prototypes for external functions
46 * buffer.c [REL_ALLOC]: Remove prototypes of
47 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
48 they are now on lisp.h.
50 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
52 * search.c (search_buffer): Use it to inhibit relocation of buffer
53 text while re_search_2 is doing its job, because re_search_2 is
54 passed C pointers to buffer text. (Bug#11519)
56 2012-05-21 Eli Zaretskii <eliz@gnu.org>
58 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
61 2012-05-19 Eli Zaretskii <eliz@gnu.org>
63 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
64 state after an additional call to move_it_in_display_line_to, keep
65 the values of it->max_ascent and it->max_descent found for the
67 (pos_visible_p): Revert the comparison against bottom_y to what it
68 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
71 2012-05-15 Eli Zaretskii <eliz@gnu.org>
73 * xdisp.c (pos_visible_p): Fix last change. (Bug#11464)
75 2012-05-13 Eli Zaretskii <eliz@gnu.org>
77 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
78 already have overlays loaded.
79 (handle_single_display_spec): Before returning without displaying
80 fringe bitmap, synchronize the bidi iterator with the main display
81 iterator, by calling iterate_out_of_display_property.
82 (iterate_out_of_display_property): Detect buffer iteration by
83 testing that it->string is a Lisp string.
84 (get_next_display_element): When the current object is exhausted,
85 and there's something on it->stack, call set_iterator_to_next to
86 proceed with what's on the stack, instead of returning zero.
87 (set_iterator_to_next): If called at the end of a Lisp string,
88 proceed to consider_string_end without incrementing string
89 position. Don't increment display vector index past the end of
90 the display vector. (Bug#11417)
91 (pos_visible_p): Don't report a position visible when move_it_to
92 stopped at the last line of window, which happens to be scanned
93 backwards by the bidi iteration. (Bug#11464)
95 2012-05-11 Eli Zaretskii <eliz@gnu.org>
97 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
98 and right-margin display specs even if the spec is invalid or we
99 are on a TTY, and thus unable to display on the fringes. That's
100 because the text with the property will not be displayed anyway,
101 so we need to signal to the caller that this is a "replacing"
102 display spec. This fixes display when the spec is invalid or we
105 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
107 * unexaix.c (make_hdr): Fix typo in prototype.
108 This bug broke the build on AIX. Problem reported by Gilles Pion.
110 2012-05-05 Eli Zaretskii <eliz@gnu.org>
112 * w32proc.c (new_child): Force Windows to reserve only 64KB of
113 stack for each reader_thread, instead of defaulting to 8MB
114 determined by the linker. This avoids failures in creating
115 subprocesses on Windows 7, see the discussion in this thread:
116 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
118 2012-05-02 Jim Meyering <meyering@redhat.com>
120 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
122 2012-04-29 Eli Zaretskii <eliz@gnu.org>
124 * xdisp.c (pos_visible_p): If already at a newline from the
125 display string before the 'while' loop, don't walk back the glyphs
126 from it3.glyph_row. Solves assertion violation when the display
127 string begins with a newline (egg.el). (Bug#11367)
129 2012-04-24 Chong Yidong <cyd@gnu.org>
131 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
133 2012-04-23 Eli Zaretskii <eliz@gnu.org>
135 * xdisp.c (pos_visible_p): If the window start position is beyond
136 ZV, start the display from buffer beginning. Prevents assertion
137 violation in init_iterator when the minibuffer window is scrolled
140 * window.c (window_scroll_pixel_based): Likewise.
142 2012-04-23 Chong Yidong <cyd@gnu.org>
144 * keymap.c (where_is_internal): Doc fix (Bug#10872).
146 2012-04-20 Glenn Morris <rgm@gnu.org>
148 * fileio.c (Fcopy_file, Fset_file_selinux_context):
149 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
151 2012-04-20 Eli Zaretskii <eliz@gnu.org>
153 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers): Don't
154 overrun array limits of glyph row's used[] array. (Bug#11288)
156 2012-04-20 Chong Yidong <cyd@gnu.org>
158 * process.c (wait_reading_process_output): If EIO occurs on a pty,
159 set the status to "failed" and ensure that sentinel is run.
161 2012-04-18 Glenn Morris <rgm@gnu.org>
163 * process.c (Fset_process_inherit_coding_system_flag)
164 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
165 (Fmake_network_process, Fmake_serial_process): Doc fix.
167 2012-04-17 Eli Zaretskii <eliz@gnu.org>
169 * xdisp.c (string_buffer_position_lim): Limit starting position to
171 (set_cursor_from_row): If called for a mode-line or header-line
172 row, return zero immediately.
173 (try_cursor_movement): If inside continuation line, don't back up
174 farther than the first row after the header line, if any. Don't
175 consider the header-line row as "partially visible", even if
176 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
178 2012-04-13 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
180 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n" (bug#11238).
182 2012-04-10 Teodor Zlatanov <tzz@lifelogs.com>
184 * process.c (make_process):
185 * process.h: Add integer `gnutls_handshakes_tried' member to
188 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
189 Add convenience `GNUTLS_LOG2i' macro.
191 * gnutls.c (gnutls_log_function2i): Convenience log function.
192 (emacs_gnutls_read): Use new log functions,
193 `gnutls_handshakes_tried' process member, and
194 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
195 attempts per process (connection).
197 2012-04-09 Eli Zaretskii <eliz@gnu.org>
199 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
200 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
202 2012-04-09 Jan Djärv <jan.h.d@swipnet.se>
204 * nsterm.m (constrainFrameRect): Always constrain when there is only
205 one screen (Bug#10962).
207 2012-04-06 Eli Zaretskii <eliz@gnu.org>
209 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
210 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
211 about subtle differences between FETCH_CHAR* and STRING_CHAR*
212 macros related to unification of CJK characters. For the details,
213 see the discussion following the message here:
214 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
216 2012-04-04 Chong Yidong <cyd@gnu.org>
218 * keyboard.c (Vdelayed_warnings_list): Doc fix.
220 2012-04-01 Eli Zaretskii <eliz@gnu.org>
222 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
223 instead of alloca. (Bug#11138)
225 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
227 * w32menu.c (is_simple_dialog): Properly check lisp types.
230 2012-03-31 Eli Zaretskii <eliz@gnu.org>
232 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
233 position we get to after a call to move_it_to fails the
234 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
235 only if we wind up in a string from display property. (Bug#11063)
237 * window.c (Fdelete_other_windows_internal): Invalidate the row
238 and column information about mouse highlight, so that redisplay
239 restores it after reallocating the glyph matrices. (Bug#7464)
241 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
242 string comes from a `display' text property, use the buffer
243 position of that property as if we actually saw that position in
245 (move_it_by_lines): Remove the assertion that
246 "it->current_x == 0 && it->hpos == 0" which can be legitimately
247 violated when there's a before-string at the beginning of a line.
250 2012-03-30 Eli Zaretskii <eliz@gnu.org>
252 * xdisp.c (append_space_for_newline): If the default face was
253 remapped, use the remapped face for the appended newline.
254 (extend_face_to_end_of_line): Use the remapped default face for
255 extending the face to the end of the line.
256 (display_line): Call extend_face_to_end_of_line when the default
257 face was remapped. (Bug#11068)
259 2012-03-29 Eli Zaretskii <eliz@gnu.org>
261 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
263 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
265 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
267 2012-03-27 Glenn Morris <rgm@gnu.org>
269 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
272 2012-03-26 Kenichi Handa <handa@m17n.org>
274 * dispextern.h (struct glyph): Fix previous change. Change the
275 bit length of glyphless.ch to 25 (Bug#11082).
277 2012-03-26 Chong Yidong <cyd@gnu.org>
279 * keyboard.c (Vselection_inhibit_update_commands): New variable.
280 (command_loop_1): Use it; inhibit selection update for
281 handle-select-window too (Bug#8996).
283 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
285 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
287 2012-03-25 Kenichi Handa <handa@m17n.org>
289 * dispextern.h (struct glyph): Change the bit length of
290 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
292 2012-03-24 Eli Zaretskii <eliz@gnu.org>
294 * s/ms-w32.h (tzname): Include time.h before redirecting to
295 _tzname. Fixes the MSVC build. (Bug#9960)
297 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
299 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
302 * xterm.c (XTread_socket): Only modify handling_signal if
303 !SYNC_INPUT. (Bug#11080)
305 2012-03-23 Eli Zaretskii <eliz@gnu.org>
307 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
308 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
309 when fetching a multibyte character consumes more bytes than
310 CHAR_BYTES returns, due to unification of CJK characters in
311 string_char. (Bug#11073)
313 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
315 * process.c (wait_reading_process_output): Handle pty disconnect
316 by refraining from sending oneself a SIGCHLD (bug#10933).
318 2012-03-22 Chong Yidong <cyd@gnu.org>
320 * dispextern.h (struct it): New member string_from_prefix_prop_p.
322 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
323 Mark string as coming from a prefix property.
324 (handle_face_prop): Use default face for prefix strings (Bug#4281).
325 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
327 2012-03-21 Chong Yidong <cyd@gnu.org>
329 * xfaces.c (Vface_remapping_alist): Doc fix.
331 2012-03-20 Eli Zaretskii <eliz@gnu.org>
333 * w32proc.c (Fw32_set_console_codepage)
334 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
337 2012-03-20 Chong Yidong <cyd@gnu.org>
339 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
340 to reflect default non-nil value of redisplay-dont-pause.
342 2012-03-19 Kenichi Handa <handa@m17n.org>
344 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
345 it fit in a valid range (Bug#11003).
347 2012-03-18 Eli Zaretskii <eliz@gnu.org>
349 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
350 that is not from display property, accept the row as a "cursor
351 row" if one of the string's character has a non-nil `cursor'
352 property. Fixes cursor positioning when there are newlines in
353 overlay strings, e.g. in icomplete.el. (Bug#11035)
355 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
357 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
359 2012-03-12 Chong Yidong <cyd@gnu.org>
361 * eval.c (inhibit_lisp_code): Rename from
362 inhibit_window_configuration_change_hook; move from window.c.
364 * xfns.c (unwind_create_frame_1, Fx_create_frame):
365 * window.c (run_window_configuration_change_hook)
366 (syms_of_window): Callers changed.
368 2012-03-11 Chong Yidong <cyd@gnu.org>
370 * keymap.c (Fkey_description): Doc fix (Bug#9700).
372 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
374 2012-03-10 Chong Yidong <cyd@gnu.org>
376 * frame.c (other_visible_frames): Don't assume the selected frame
377 is visible (Bug#10955).
379 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
381 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
383 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
385 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
386 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
389 2012-03-03 Glenn Morris <rgm@gnu.org>
391 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
393 2012-03-02 Eli Zaretskii <eliz@gnu.org>
395 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
396 position past the first glyph_row that ends at ZV. (Bug#10902)
397 (redisplay_window, next_element_from_string): Fix typos in
399 (redisplay_window): Pass to move_it_vertically the margin in
400 pixels, not in screen lines.
402 2012-03-02 Glenn Morris <rgm@gnu.org>
404 * buffer.c (buffer-list-update-hook): Doc fix.
406 2012-02-29 Eli Zaretskii <eliz@gnu.org>
408 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
409 push_it before setting up the iterator for the first overlay
410 string, even if we have an empty string loaded.
411 (next_overlay_string): If there's an empty string on the iterator
412 stack, pop the stack. (Bug#10903)
414 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
416 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
417 Suggested by Stefan Monnier in
418 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
419 * alloc.c (widen_to_Lisp_Object): New static function.
420 (mark_memory): Also mark Lisp_Objects by fetching pointer words
421 and widening them to Lisp_Objects. This would work even if
422 USE_LSB_TAG is defined and wide integers are used, which might
423 happen in a future version of Emacs.
425 2012-02-25 Chong Yidong <cyd@gnu.org>
427 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
430 * xselect.c (Fx_selection_exists_p): Doc fix.
431 (x_clipboard_manager_save_all): Print an informative message
432 before saving to clipboard manager.
434 2012-02-24 Chong Yidong <cyd@gnu.org>
436 * keyboard.c (process_special_events): Handle all X selection
437 requests in kbd_buffer, not just the next one (Bug#8869).
439 2012-02-23 Chong Yidong <cyd@gnu.org>
441 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
442 call when setting menu-bar-lines and tool-bar-lines parameters.
443 (unwind_create_frame_1): New helper function.
445 * window.c (inhibit_window_configuration_change_hook): New var.
446 (run_window_configuration_change_hook): Obey it.
447 (syms_of_window): Initialize it.
449 2012-02-22 Chong Yidong <cyd@gnu.org>
451 * xterm.c (x_draw_image_relief): Add missing type check for
452 Vtool_bar_button_margin (Bug#10743).
454 2012-02-21 Chong Yidong <cyd@gnu.org>
456 * fileio.c (Vfile_name_handler_alist): Doc fix.
458 * buffer.c (Fget_file_buffer): Protect against invalid file
459 handler return value.
461 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
463 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
464 when computing $valmask.
466 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
467 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
468 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
469 It's useless in that case, and it can cause problems on hosts
470 that allocate halves of EMACS_INT values separately.
471 Reported by Dan Horák. Diagnosed by Andreas Schwab in
472 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
473 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
474 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
475 it avoids undefined behavior on hosts where shifting right by more
476 than the word width has undefined behavior.
478 2012-02-19 Chong Yidong <cyd@gnu.org>
480 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
481 (Funhandled_file_name_directory, Ffile_name_as_directory)
482 (Fdirectory_file_name, Fexpand_file_name)
483 (Fsubstitute_in_file_name): Protect against invalid file handler
484 return values (Bug#10845).
486 2012-02-18 Eli Zaretskii <eliz@gnu.org>
488 * .gdbinit (pitx): Fix incorrect references to fields of the
491 2012-02-17 Chong Yidong <cyd@gnu.org>
493 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
495 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
497 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
498 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
500 2012-02-15 Chong Yidong <cyd@gnu.org>
502 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
503 marked as special. Also, starting docstrings with * is obsolete.
505 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
507 * gnutls.c (emacs_gnutls_write): Fix last change.
509 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
511 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
514 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
516 * keymap.c (Fsingle_key_description): Handle char ranges.
518 2012-02-12 Chong Yidong <cyd@gnu.org>
520 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
521 as that creates a dangerous corner case.
523 * window.c (Fdelete_window_internal): Invalidate the mouse
524 highlight (Bug#9904).
526 2012-02-12 Glenn Morris <rgm@gnu.org>
528 * xselect.c (Fx_own_selection_internal)
529 (Fx_get_selection_internal, Fx_disown_selection_internal)
530 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
531 * nsselect.m (Fx_own_selection_internal)
532 (Fx_disown_selection_internal, Fx_selection_exists_p)
533 (Fx_selection_owner_p, Fx_get_selection_internal):
534 Sync docs and argument specs with the xselect.c versions.
536 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
538 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
540 2012-02-11 Eli Zaretskii <eliz@gnu.org>
542 * w32select.c (Fx_selection_exists_p): Sync doc string and
543 argument list with xselect.c. (Bug#10783)
545 * w16select.c (Fx_selection_exists_p): Sync doc string and
546 argument list with xselect.c. (Bug#10783)
548 2012-02-10 Glenn Morris <rgm@gnu.org>
550 * fns.c (Fsecure_hash): Doc fix.
552 2012-02-09 Kenichi Handa <handa@m17n.org>
554 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
556 2012-02-07 Chong Yidong <cyd@gnu.org>
558 * buffer.c (Fbuffer_local_variables)
559 (buffer_lisp_local_variables): Handle unbound vars correctly;
560 don't let Qunbound leak into Lisp.
562 2012-02-07 Glenn Morris <rgm@gnu.org>
564 * image.c (Fimagemagick_types): Doc fix.
566 * image.c (imagemagick-render-type): Change it from a lisp object
567 to an integer. Move the doc here from the lisp manual.
568 Treat all values not equal to 0 the same.
570 2012-02-06 Chong Yidong <cyd@gnu.org>
572 * doc.c (store_function_docstring): Avoid applying docstring of
573 alias to base function (Bug#2603).
575 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
577 * .gdbinit (pp1, pv1): Remove redundant defines.
580 2012-02-04 Chong Yidong <cyd@gnu.org>
582 * nsterm.m: Declare a global (Bug#10694).
584 2012-02-04 Eli Zaretskii <eliz@gnu.org>
586 * w32.c (get_emacs_configuration_options):
587 Include --enable-checking, if specified, in the return value.
589 2012-02-04 Martin Rudalics <rudalics@gmx.at>
591 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
592 after rounding frame sizes. (Bug#9723)
594 2012-02-04 Eli Zaretskii <eliz@gnu.org>
596 * keyboard.c (adjust_point_for_property): Don't position point
597 before BEGV. (Bug#10696)
599 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
601 Handle overflow when computing char display width (Bug#9496).
602 * character.c (char_width): Return EMACS_INT, not int.
603 (char_width, c_string_width): Check for overflow when
604 computing the width; this is possible now that individual
605 characters can have unbounded width. Problem introduced
606 by merge from Emacs 23 on 2012-01-19.
608 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
610 * dbusbind.c (Fdbus_register_method): Mention the return value
611 :ignore in the docstring.
613 2012-02-02 Glenn Morris <rgm@gnu.org>
615 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
617 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
618 Unconditionally set to t. (Bug#10673)
619 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
620 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
621 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
623 2012-02-02 Kenichi Handa <handa@m17n.org>
625 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
626 0, do not call append_composite_glyph.
628 2012-02-02 Kenichi Handa <handa@m17n.org>
630 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
632 (x_produce_glyphs): If the component of a composition is a null
633 string, set it->pixel_width to 1 to avoid zero-width glyph.
635 2012-02-01 Eli Zaretskii <eliz@gnu.org>
637 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
638 first 2 arguments are identical. This makes inserting large
639 output from a subprocess an order of magnitude faster on
640 MS-Windows, where all sbrk'ed memory is always contiguous.
642 2012-01-31 Glenn Morris <rgm@gnu.org>
644 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
645 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
646 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
648 2012-01-29 Glenn Morris <rgm@gnu.org>
650 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
652 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
654 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
656 2012-01-28 Chong Yidong <cyd@gnu.org>
658 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
660 2012-01-26 Chong Yidong <cyd@gnu.org>
662 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
664 * search.c (Fsearch_forward, Fsearch_backward): Document negative
665 repeat counts (Bug#10507).
667 2012-01-26 Glenn Morris <rgm@gnu.org>
669 * lread.c (syms_of_lread): Doc fix.
671 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
673 * coding.c (encode_designation_at_bol): Change return value to
676 2012-01-25 Chong Yidong <cyd@gnu.org>
678 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
680 2012-01-21 Chong Yidong <cyd@gnu.org>
682 * floatfns.c (Fcopysign): Make the second argument non-optional,
683 since nil is not allowed anyway.
685 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
687 * process.c (read_process_output): Use p instead of XPROCESS (proc).
688 (send_process): Likewise.
690 2012-01-19 Martin Rudalics <rudalics@gmx.at>
692 * window.c (save_window_save, Fcurrent_window_configuration)
693 (Vwindow_persistent_parameters): Do not use Qstate.
696 2012-01-19 Kenichi Handa <handa@m17n.org>
698 * character.c (char_width): New function.
699 (Fchar_width, c_string_width, lisp_string_width):
700 Use char_width (Bug#9496).
702 2012-01-16 Martin Rudalics <rudalics@gmx.at>
704 * window.c (Vwindow_persistent_parameters): New variable.
705 (Fset_window_configuration, save_window_save): Handle persistent
708 2012-01-14 Eli Zaretskii <eliz@gnu.org>
710 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
711 thrashing the stack of the thread. (Bug#9087)
713 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
715 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
717 2012-01-11 Eli Zaretskii <eliz@gnu.org>
719 * xdisp.c (rows_from_pos_range): Handle the case where the
720 highlight ends on a newline. (Bug#10464)
721 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
722 he end column for display of highlight that ends on a newline
725 2012-01-11 Glenn Morris <rgm@gnu.org>
727 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
728 from load-path also when installation-directory is nil. (Bug#10208)
730 2012-01-10 Glenn Morris <rgm@gnu.org>
732 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
734 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
735 Update template values to be closer to their typical values these days.
737 2012-01-09 Eli Zaretskii <eliz@gnu.org>
739 * xdisp.c (rows_from_pos_range): Accept additional argument
740 DISP_STRING, and accept any glyph in a row whose object is that
741 string as eligible for mouse highlight. Fixes mouse highlight of
742 display strings from overlays. (Bug#10464)
744 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
746 emacs: fix an auto-save permissions race condition (Bug#10400)
747 * fileio.c (auto_saving_dir_umask): New static var.
748 (Fmake_directory_internal): Use it.
749 (do_auto_save_make_dir): Set it, instead of invoking chmod after
750 creating the directory. The old code temporarily assigns
751 too-generous permissions to the directory.
752 (do_auto_save_eh): Clear it.
753 (Fdo_auto_save): Catch all errors, not just file errors, so
754 that the var is always cleared.
756 2012-01-07 Eli Zaretskii <eliz@gnu.org>
758 * search.c (scan_buffer): Pass character positions to
759 know_region_cache, not byte positions. (Bug#6540)
761 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
763 * w32.c (sys_rename): Report EXDEV when rename of a directory
764 fails because the target is on another logical disk. (Bug#10284)
766 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
768 * xterm.c (x_embed_request_focus): New function.
770 * xterm.h: Add prototype.
772 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
774 2012-01-05 Glenn Morris <rgm@gnu.org>
776 * emacs.c (emacs_copyright): Update short copyright year to 2012.
778 2012-01-01 Eli Zaretskii <eliz@gnu.org>
780 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
781 Load gnutls_transport_set_lowat only if GnuTLS version is below
783 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
784 GnuTLS versions below 2.11.1.
786 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
788 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
789 to the doc string advising against its use for altering the way
790 windows are scrolled.
792 2011-12-28 Kenichi Handa <handa@m17n.org>
794 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
795 coding-system ASCII compatible only when it does not produce BOM
796 on encoding (Bug#10383).
798 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
800 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
802 (create_and_show_popup_menu): Always use menu_position_func for
805 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
807 * callint.c (Fcall_interactively): Don't truncate prompt string.
809 2011-12-23 Eli Zaretskii <eliz@gnu.org>
811 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
812 property that ends at ZV, so that the bidi iteration could be
813 resumed from there (after widening). (Bug#10360)
815 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
817 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
819 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
821 * nsterm.m (x_free_frame_resources):
822 Release f->output_data.ns->miniimage.
823 (ns_index_color): Fix indentation. Do not retain
824 color_table->colors[i].
826 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
829 * nsfns.m (x_set_background_color): Assign return value from
830 ns_index_color to face-background instead of NSColor*.
831 (ns_implicitly_set_icon_type): Fix indentation.
832 Change assignment in for loop to comparison.
834 * emacs.c (ns_pool): New variable.
835 (main): Assign ns_pool.
836 (Fkill_emacs): Call ns_release_autorelease_pool.
838 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
839 autorelease fdesc, release fdAttrs and tdict.
840 (ns_get_covering_families): Release charset.
841 (ns_findfonts): Release NSFontDescriptor created with new.
842 (ns_uni_to_glyphs): Fix indentation.
843 (setString): Release attrStr before assigning new value.
845 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
847 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
849 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
850 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
852 2011-12-18 David Reitter <reitter@cmu.edu>
854 * nsterm.m (ns_term_init): Subscribe for notifications
855 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
856 to method trackingNotification in EmacsMenu.
858 * nsmenu.m (trackingMenu): New variable.
859 (trackingNotification): New method (from Aquamacs).
860 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
861 from Aquamacs (Bug#7030).
863 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
865 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
866 (symbol_to_nsstring): Fix indentation.
867 (ns_symbol_to_pb): New function.
868 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
869 (Fns_rotate_cut_buffers_internal): Remove.
870 (Fns_store_selection_internal): Rename from
871 Fns_store_cut_buffer_internal.
872 (ns_get_foreign_selection, Fx_own_selection_internal)
873 (Fx_disown_selection_internal, Fx_selection_exists_p)
874 (Fns_get_selection_internal, Fns_store_selection_internal):
875 Use ns_symbol_to_pb and check if return value is nil.
876 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
877 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
878 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
879 renamed to Sns_store_selection_internal.
880 (ns_handle_selection_request): Move code to Fx_own_selection_internal
881 and remove this function.
882 (ns_handle_selection_clear): Remove, never used.
883 (Fx_own_selection_internal): Move code from ns_handle_selection_request
886 2011-12-17 Ken Brown <kbrown@cornell.edu>
888 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
889 GID is unknown (Bug#10257).
891 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
893 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
894 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
895 which caused a build failure on GNU/Linux IA-64. This problem was
896 introduced by my 2011-10-07 patch.
898 2011-12-15 Juri Linkov <juri@jurta.org>
900 * image.c (imagemagick_error): New function. (Bug#10112)
901 (imagemagick_load_image): Comment out `MagickSetResolution' call.
902 Use `imagemagick_error' where ImageMagick functions return
904 (Fimagemagick_types): Add `Fnreverse' to return the list in the
907 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
909 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
910 fill background (Bug#8992).
912 2011-12-13 Martin Rudalics <rudalics@gmx.at>
914 * window.c (Vwindow_combination_resize)
915 (Vwindow_combination_limit): Use t instead of non-nil in
917 (Vrecenter_redisplay): Add first sentence of doc-string on
919 (Frecenter): Fix doc-string typo.
921 2011-12-11 Kenichi Handa <handa@m17n.org>
923 * coding.c (Funencodable_char_position): Pay attention to the
924 buffer text relocation (Bug#9389).
926 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
928 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
929 gtk_init (Bug#10100).
931 2011-12-10 Eli Zaretskii <eliz@gnu.org>
933 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
934 IT->string is nil. (Bug#10263)
936 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
938 * nsterm.h (x_free_frame_resources): Declare.
940 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
941 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
943 * nsterm.h (ns_get_defaults_value): Declare.
945 * nsterm.m (ns_default): Call ns_get_defaults_value.
947 2011-12-09 Eli Zaretskii <eliz@gnu.org>
949 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
952 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
954 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
955 that where the value of an _OBJC_* symbol points to is in the .bss
958 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
960 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
961 after the loop to call ccl_driver at least once (Bug#8619).
963 2011-12-08 Kenichi Handa <handa@m17n.org>
965 * ftfont.c (get_adstyle_property): Fix previous change
968 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
970 * w32.c (init_environment): If no_site_lisp, remove site-lisp
971 dirs from the default value of EMACSLOADPATH (bug#10208).
973 2011-12-07 Glenn Morris <rgm@gnu.org>
975 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
976 installation and source directories as well. (Bug#10208)
978 2011-12-06 Chong Yidong <cyd@gnu.org>
980 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
982 2011-12-06 Glenn Morris <rgm@gnu.org>
984 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
985 as an error, not just -1. (Bug#10217)
987 2011-12-05 Chong Yidong <cyd@gnu.org>
989 * keyboard.c (process_special_events): New function.
990 (swallow_events, Finput_pending_p): Use it (Bug#10195).
992 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
994 * coding.c (encode_designation_at_bol): Don't use uninitialized
995 local variable (Bug#9318).
997 2011-12-05 Kenichi Handa <handa@m17n.org>
999 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
1000 return Qnil (Bug#8046, Bug#10193).
1002 2011-12-05 Kenichi Handa <handa@m17n.org>
1004 * coding.c (encode_designation_at_bol): New args charbuf_end and
1005 dst. Return the number of produced bytes. Callers changed.
1006 (coding_set_source): Return how many bytes coding->source was
1008 (coding_set_destination): Return how many bytes
1009 coding->destination was relocated.
1010 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
1011 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
1013 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1015 * coding.c (CODING_CHAR_CHARSET_P): New macro.
1016 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
1019 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
1021 The following changes are to fix Bug#9318.
1023 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
1024 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
1025 (encode_coding_iso_2022, encode_coding_sjis)
1026 (encode_coding_big5, encode_coding_charset): Use the above macros.
1028 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
1030 * lisp.h (process_quit_flag): Fix external declaration.
1032 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
1034 Don't macro-inline non-performance-critical code.
1035 * eval.c (process_quit_flag): New function.
1036 * lisp.h (QUIT): Use it.
1038 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
1040 * nsfns.m (get_geometry_from_preferences): New function.
1041 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
1043 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
1045 * emacs.c (Qkill_emacs): Define.
1046 (syms_of_emacs): Initialize it.
1047 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
1048 Qquit_flag to `kill-emacs' instead.
1049 (quit_throw_to_read_char): Add parameter `from_signal'.
1050 All callers changed. Call Fkill_emacs if requested and safe.
1051 * lisp.h (QUIT): Call Fkill_emacs if requested.
1053 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
1055 * widget.c (update_wm_hints): Return if wmshell is null.
1056 (widget_update_wm_size_hints): New function.
1058 * widget.h (widget_update_wm_size_hints): Declare.
1060 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
1061 widget_update_wm_size_hints (Bug#10104).
1063 2011-12-03 Eli Zaretskii <eliz@gnu.org>
1065 * xdisp.c (handle_invisible_prop): If the invisible text ends just
1066 before a newline, prepare the bidi iterator for consuming the
1067 newline, and keep the current paragraph direction. (Bug#10183)
1068 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
1070 2011-12-02 Juri Linkov <juri@jurta.org>
1072 * search.c (Fword_search_regexp): New Lisp function created from
1073 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
1074 (Fword_search_backward, Fword_search_forward)
1075 (Fword_search_backward_lax, Fword_search_forward_lax):
1076 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
1077 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1079 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1081 * fileio.c (Finsert_file_contents): Move after-change-function call
1082 to before the "handled:" label, since all "goto handled" appear in
1083 cases where the *-change-functions have already been properly called
1086 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1088 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1089 waiting for input. (Bug#10169)
1091 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1093 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1094 verifies glyph row's hash code--we have just reallocated the
1095 glyphs, so their contents can be complete garbage. (Bug#10164)
1097 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
1099 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1101 2011-11-30 Eli Zaretskii <eliz@gnu.org>
1103 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1104 attributes are tested _before_ calling verify_row_hash, to protect
1105 against GCC re-ordering of the tests. (Bug#10164)
1107 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1109 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1111 * xterm.c (handle_one_xevent): Only set async_visible and friends
1112 if net_wm_state_hidden_seen is non-zero (Bug#10002)
1113 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
1114 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1116 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1118 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1119 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1120 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1121 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1122 All uses changed to use GCPRO1 etc.
1123 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1124 Revert to old implementation (i.e., before 2011-03-11).
1126 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1128 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1129 of scroll runs so as to avoid assigning disabled bogus rows and
1130 unnecessary graphics copy operations.
1132 2011-11-27 Eli Zaretskii <eliz@gnu.org>
1134 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1135 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1136 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1137 (malloc, free, realloc, calloc): Redirect to e_* only when
1140 * lisp.h (GCTYPEBITS): Move before first use.
1141 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1142 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1143 this macro definition.
1145 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1148 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1150 * gtkutil.c (xg_create_frame_widgets):
1151 Call gtk_window_set_has_resize_grip (FALSE) if that function is
1152 present with Gtk+ 2.0.
1154 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1156 * fileio.c (Finsert_file_contents): Undo previous change; see
1157 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1159 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1161 Rename locals to avoid shadowing.
1162 * fileio.c (Finsert_file_contents):
1163 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1164 * process.c (wait_reading_process_output):
1165 Rename inner 'proc' to 'p' to avoid shadowing.
1166 Indent for consistency with usual Emacs style.
1168 2011-11-25 Eli Zaretskii <eliz@gnu.org>
1170 * xdisp.c (redisplay_window): If cursor row is not fully visible
1171 after recentering, and scroll-conservatively is set to a large
1172 number, scroll window by a few more lines to make the cursor fully
1173 visible and out of scroll-margin. (Bug#10105)
1174 (start_display): Don't move to the next line if the display should
1175 start at a newline that is part of a display vector or an overlay
1178 2011-11-24 Juri Linkov <juri@jurta.org>
1180 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1181 after the `MagickPingImage' call. (Bug#10112)
1183 2011-11-23 Chong Yidong <cyd@gnu.org>
1185 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1187 2011-11-23 Martin Rudalics <rudalics@gmx.at>
1189 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1190 making another buffer current. (Bug#10114)
1192 2011-11-23 Glenn Morris <rgm@gnu.org>
1194 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1196 2011-11-23 Chong Yidong <cyd@gnu.org>
1198 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1199 using it (Bug#5984).
1201 2011-11-22 Eli Zaretskii <eliz@gnu.org>
1203 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1204 and header-lines, as they don't have one computed for them.
1207 * .gdbinit (prow): Make displayed values more self-explaining.
1208 Add row's hash code.
1210 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1212 * process.c (wait_reading_process_output): Fix asynchrounous
1213 GnuTLS socket handling on some versions of the GnuTLS library.
1214 (wait_reading_process_output): Add comment and URL.
1216 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1218 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1220 2011-11-21 Chong Yidong <cyd@gnu.org>
1222 * window.c (Fnext_window, Fprevious_window): Doc fix.
1224 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1226 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1228 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1230 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1232 2011-11-20 Martin Rudalics <rudalics@gmx.at>
1234 * window.c (Fset_window_combination_limit): Rename argument
1236 (Vwindow_combination_limit): Remove "status" from doc-string.
1238 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1240 * m/ibms390.h: Remove.
1241 * m/ibms390x.h: Don't include "ibms390.h".
1243 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1245 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1246 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1248 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1250 * casetab.c (Fset_case_table):
1251 * charset.c (Fcharset_after): Fix typos.
1253 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
1255 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1256 Otherwise, valgrind does not work on some platforms.
1257 Problem reported by Andreas Schwab in
1258 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1259 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1260 is set, removing the need for VIRT_ADDRESS_VARIES.
1261 (PURE_P): Use a more-efficient implementation that needs just one
1262 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1263 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1264 to 4 (xorl, subq, cmpq, setbe).
1265 * alloc.c (pure): Always extern now, since that's the
1266 VIRT_ADDR_VARIES behavior.
1267 (PURE_POINTER_P): Use a single comparison, not two, for
1268 consistency with the new puresize.h.
1269 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1270 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1271 Remove VIRT_ADDR_VARIES no longer needed.
1273 2011-11-19 Eli Zaretskii <eliz@gnu.org>
1275 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1276 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1277 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1278 behave as if the cursor position were at the window margin.
1280 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1281 and the cursor position is out of bounds, behave as if the cursor
1282 position were at the window margin. (Bug#10075)
1284 2011-11-18 Chong Yidong <cyd@gnu.org>
1286 * window.c (Fwindow_combination_limit): Make first argument
1287 non-optional, since it is meaningless for live windows like the
1290 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1292 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1294 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1296 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1297 (graft_intervals_into_buffer): Simplify.
1299 2011-11-18 Eli Zaretskii <eliz@gnu.org>
1301 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1302 hash values of the two rows.
1303 (copy_row_except_pointers): Preserve the used[] arrays and the
1304 hash values of the two rows. (Bug#10035)
1305 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
1307 * xdisp.c (row_hash): New function, body extracted from
1308 compute_line_metrics.
1309 (compute_line_metrics): Call row_hash, instead of computing the
1312 * dispnew.c (verify_row_hash): Call row_hash for computing the
1313 hash code of a row, instead of duplicating code from xdisp.c.
1315 * dispextern.h (row_hash): Add prototype.
1317 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1319 * frame.c (delete_frame): Don't delete the terminal when the last
1320 X frame is closed if emacs is built with GTK toolkit.
1322 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
1324 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1326 2011-11-17 Martin Rudalics <rudalics@gmx.at>
1328 * window.c (Vwindow_splits): Rename to
1329 Vwindow_combination_resize. Suggested by Juri Linkov.
1330 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1333 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
1335 * nsfns.m (Fns_font_name):
1336 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
1338 2011-11-16 Martin Rudalics <rudalics@gmx.at>
1340 * window.h (window): Rename slot "nest" to "combination_limit".
1341 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1342 (Fset_window_nest): Rename to Fset_window_combination_limit.
1343 (Vwindow_nest): Rename to Vwindow_combination_limit.
1344 (recombine_windows, make_parent_window, make_window)
1345 (Fsplit_window_internal, saved_window)
1346 (Fset_window_configuration, save_window_save): Rename all
1347 occurrences of window_nest to window_combination_limit.
1349 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
1351 * image.c (imagemagick_load_image): Fix typo.
1353 2011-11-14 Eli Zaretskii <eliz@gnu.org>
1355 * xdisp.c (display_line): Move the call to
1356 highlight_trailing_whitespace before the call to
1357 compute_line_metrics, since the latter needs to see the final
1358 faces of all the glyphs to compute ROW's hash value.
1359 Fixes assertion violations in row_equal_p. (Bug#10035)
1361 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
1363 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1364 just return (bug#10044).
1366 2011-11-12 Eli Zaretskii <eliz@gnu.org>
1368 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1369 with user-defined heap size. Bump the default size of the temacs
1370 heap to 27MB, to avoid memory warning when running temacs.
1371 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1373 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1374 current_matrix and desired_matrix. (Bug#9990)
1375 (verify_row_hash) [XASSERTS]: New function.
1376 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1377 that the hash value of glyph rows is correct.
1379 2011-11-12 Martin Rudalics <rudalics@gmx.at>
1381 * window.h (window): Remove splits slot.
1382 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1383 (Fdelete_other_windows_internal, make_parent_window)
1384 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1385 (Fset_window_configuration, save_window_save): Don't deal with
1386 split status of windows.
1387 (saved_window): Remove splits slot.
1388 (Vwindow_splits): Rewrite doc-string.
1390 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1392 * xfns.c (unwind_create_frame):
1393 * nsfns.m (unwind_create_frame):
1394 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1395 Vframe_list (Bug#9999).
1397 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1399 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1401 2011-11-11 Kenichi Handa <handa@m17n.org>
1403 * callproc.c (Fcall_process): Set the member dst_multibyte of
1406 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1408 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1409 avoid a crash (bug#9496).
1411 2011-11-09 Chong Yidong <cyd@gnu.org>
1413 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1414 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1416 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1418 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1420 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1422 Avoid some portability problems by eschewing 'extern inline' functions.
1423 The trivial performance wins aren't worth the portability hassles; see
1424 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1426 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1427 (window_box_width, window_box_left, window_box_left_offset)
1428 (window_box_right, window_box_right_offset): Undo previous change,
1429 by removing the "extern"s.
1430 * intervals.c (adjust_intervals_for_insertion)
1431 (adjust_intervals_for_deletion): Undo previous change,
1432 making these static again.
1433 (offset_intervals, temp_set_point_both, temp_set_point)
1434 (copy_intervals_to_string): No longer inline.
1435 * xdisp.c (window_text_bottom_y, window_box_width)
1436 (window_box_height, window_box_left_offset)
1437 (window_box_right_offset, window_box_left, window_box_right)
1438 (window_box): No longer inline.
1440 2011-11-08 Chong Yidong <cyd@gnu.org>
1442 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1443 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1444 Signal an error if not a live window.
1445 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1446 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1448 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1450 * lisp.h (syms_of_abbrev): Remove declaration.
1451 Reported by CHENG Gao <chenggao@royau.me>.
1453 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1455 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1456 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1457 of temacs in GUI mode.
1459 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1461 * window.h: Declare delete_all_child_windows instead of
1462 delete_all_subwindows.
1463 * window.c (Fwindow_nest, Fset_window_nest)
1464 (Fset_window_new_total, Fset_window_new_normal)
1465 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1466 (delete_all_subwindows): Rename to delete_all_child_windows.
1467 (Fdelete_other_windows_internal, Fset_window_configuration):
1468 Call delete_all_child_windows instead of delete_all_subwindows.
1469 * frame.c (delete_frame): Call delete_all_child_windows instead
1470 of delete_all_subwindows.
1472 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1474 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1475 This is also needed for porting to any host where GC_MARK_STACK is
1476 not GC_MAKE_GCPROS_NOOPS.
1477 (which_symbols): Use it.
1479 2011-11-07 Kenichi Handa <handa@m17n.org>
1481 * coding.c (coding_set_destination): Check coding->src_pos only
1482 when coding->src_object is a buffer (bug#9910).
1484 * process.c (send_process): Set the member src_multibyte of coding
1485 to 0 (bug#9911) when sending a unibyte text.
1487 * callproc.c (Fcall_process): Set the member src_multibyte of
1488 process_coding to 0 (bug#9912).
1490 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1492 * xmenu.c (cleanup_widget_value_tree): New function.
1493 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1494 calling free_menubar_widget_value_tree directly (Bug#9830).
1496 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1498 Fix some portability problems with 'inline'.
1499 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1500 (window_box_width, window_box_left, window_box_left_offset)
1501 (window_box_right, window_box_right_offset): Declare extern.
1502 Otherwise, these inline functions do not conform to C99 and
1503 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1504 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1505 * intervals.c (adjust_intervals_for_insertion)
1506 (adjust_intervals_for_deletion): Now extern, because otherwise the
1507 extern inline functions 'offset_intervals' couldn't refer to it.
1508 (static_offset_intervals): Remove.
1509 (offset_intervals): Rewrite using the old contents of
1510 static_offset_intervals. The old version didn't conform to C99
1511 because an extern inline function contained a reference to an
1512 identifier with static linkage.
1514 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1516 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1519 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1521 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1522 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1523 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1524 return Qleft_to_right.
1526 2011-11-06 Chong Yidong <cyd@gnu.org>
1528 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1529 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1530 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1531 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1532 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1533 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1534 (Fwindow_vscroll): Doc fix.
1535 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1536 argument, since it makes no sense to pass a live window and for
1537 consistency with window-child.
1539 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1541 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1544 2011-11-05 Jason Rumney <jasonr@gnu.org>
1546 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1547 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1549 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1550 bitwise arithmetic preventing use of unicode-sip and non-truetype
1553 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1555 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1558 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1559 initialization code to keep similarity to xfns.c after changes
1562 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1564 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1565 (unwind_create_frame): New function (Bug#9943).
1566 (Fx_create_frame): Restructure code to be more similar to the one in
1567 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1568 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1569 Move terminal->reference_count++ just before making the frame official
1572 * nsterm.m (x_free_frame_resources): New function.
1573 (x_destroy_window): Move code to x_free_frame_resources.
1575 * xfns.c (unwind_create_frame): Fix comment.
1576 (Fx_create_frame, x_create_tip_frame):
1577 Move terminal->reference_count++ just before making the frame
1578 official. Move initialization of image_cache_refcount and
1579 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1581 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1583 Support MSVC build with newer versions of Visual Studio.
1584 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1585 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1588 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1589 which are not supported by MSVC.
1590 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1591 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1593 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1595 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1597 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1599 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1601 Support MSVC build with newer versions of Visual Studio.
1602 * w32.c: Don't include w32api.h for MSVC.
1603 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1605 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1606 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1607 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1608 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1610 (alloca) [_MSC_VER]: Define to _alloca.
1612 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1614 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1616 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1618 * xdisp.c (note_mouse_highlight): If either of
1619 previous/next-single-property-change returns nil, treat that as
1620 the beginning or the end of the buffer. (Bug#9955)
1622 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1624 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1625 label is not null (Bug#9951).
1626 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1629 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1631 * window.c (Fwindow_body_size): Mention in the doc string that the
1632 return value is in frame's canonical units. (Bug#9949)
1634 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1636 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1638 * w32fns.c (unwind_create_frame): If needed, free the glyph
1639 matrices of the partially constructed frame. (Bug#9943)
1640 * xfns.c (unwind_create_frame): Likewise.
1642 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1644 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1645 Don't stop backward scan on the continuation glyph, even though
1646 its CHARPOS is positive.
1647 (mouse_face_from_buffer_pos, note_mouse_highlight):
1648 Rename cover_string to disp_string.
1650 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1652 * window.c (temp_output_buffer_show): Don't use
1653 Vtemp_buffer_show_specifiers.
1654 (Vtemp_buffer_show_specifiers): Remove unused variable.
1656 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1658 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1659 past the beginning of the current glyph matrix.
1661 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1663 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1664 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1665 HAVE_GTK3 (Bug#9869).
1667 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1668 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1670 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1672 * xterm.c: Declare x_handle_net_wm_state to return int.
1673 (handle_one_xevent): Check if we are iconified but don't have
1674 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1675 (get_current_wm_state): Return non-zero if not hidden,
1676 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1677 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1678 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1679 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1681 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1683 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1684 so that this new function doesn't get optimized away by a
1685 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1687 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1689 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1691 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1693 Fix the `xbytecode' command.
1694 * .gdbinit (xprintbytestr): New command.
1695 (xwhichsymbols): Rename from `which'; all callers changed.
1696 (xbytecode): Print the byte-code string as well.
1698 2011-10-29 Kim Storm <storm@cua.dk>
1700 * alloc.c (which_symbols): New function.
1702 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1704 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1707 2011-10-29 Glenn Morris <rgm@gnu.org>
1709 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1710 Not clear what it was for, and it causes various bugs. (Bug#9839)
1712 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1714 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1715 possible random value that matches one of those tested as
1716 condition to clear the mouse face.
1718 2011-10-28 Chong Yidong <cyd@gnu.org>
1720 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1722 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1724 * window.c (make_window): Initialize phys_cursor_on_p.
1726 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1728 * lisp.h (struct Lisp_Symbol): Update comments.
1730 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1732 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1734 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1736 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1737 <oslsachem@gmail.com> for helping to debug this.
1739 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1740 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1741 (g_b_init_get_glyph_outline_w): New static variables.
1742 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1743 (GetGlyphOutlineW_Proc): New typedefs.
1744 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1745 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1747 (w32font_open_internal, compute_metrics):
1748 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1749 instead of calling the "wide" APIs directly.
1751 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1753 * w32.h (syms_of_w32font): Add prototype.
1755 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1757 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1758 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1759 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1760 (Fmove_to_window_line): Doc fix.
1762 2011-10-27 Chong Yidong <cyd@gnu.org>
1764 * process.c (make_process): Set gnutls_state to NULL.
1766 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1767 non-NULL, regardless of GNUTLS_INITSTAGE.
1768 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1769 an error. Set process slots as soon as we allocate them.
1771 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1773 2011-10-27 Chong Yidong <cyd@gnu.org>
1775 * gnutls.c (emacs_gnutls_deinit): New function.
1776 Deallocate credentials structures as well as calling gnutls_deinit.
1777 (Fgnutls_deinit, Fgnutls_boot): Use it.
1779 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1780 (deactivate_process): Call emacs_gnutls_deinit.
1782 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1784 * image.c (x_create_x_image_and_pixmap):
1785 * w32.c (sys_rename, w32_delayed_load):
1786 * w32font.c (fill_in_logfont):
1787 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1789 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1791 * w32fns.c (w32_default_color_map): New function,
1792 extracted from Fw32_default_color_map.
1793 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1795 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1797 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1799 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1801 * keyboard.c (test_undefined): New function (bug#9751).
1802 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1804 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1806 * sysdep.c (init_sys_modes): Fix the check for the controlling
1807 terminal (Bug#6649).
1809 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1811 * dispextern.h (struct bidi_it): New member next_en_type.
1813 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1814 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1815 current character, check also for next_en_type being WEAK_EN.
1816 (bidi_resolve_weak): Don't enter the expensive loop if the current
1817 position is before next_en_pos. Record the bidi type of the first
1818 non-ET, non-BN character we find, in addition to its position.
1819 (bidi_level_of_next_char): Invalidate next_en_type when
1820 next_en_pos is over-stepped.
1822 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1824 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1825 * editfns.c: Rewrite current-time-zone so that it invokes
1826 the equivalent of (format-time-string "%Z") to get the time zone name.
1827 This fixes a bug when the time zone name contains characters that
1828 need converting from the system time locale to Emacs internal format.
1829 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1830 that patch fixed format-time-string to do the conversion, but
1831 I forgot to fix current-time-zone.
1832 (format_time_string): New function, containing most of
1833 what Fformat_time_string used to contain.
1834 (Fformat_time_string): Rewrite in terms of format_time_string.
1835 This doesn't change this function's behavior.
1836 (current-time-zone): Rewrite to use format_time_string.
1837 This fixes the bug reported by Michael Schierl in
1838 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1839 Jason Rumney's 2007-06-07 change worked around this bug, but
1841 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1843 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1845 * xdisp.c (start_display): If the character at POS is displayed
1846 via a display vector, reset IT->current.dpvec_index to zero.
1847 (try_window_reusing_current_matrix): If a line ends in a display
1848 vector or the next line starts in a display vector, continue
1849 redrawing the window even though the character position of
1850 start_row was reached.
1853 2011-10-18 Chong Yidong <cyd@gnu.org>
1855 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1856 with nobreak-char-display too.
1858 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1860 Fix part 3 of bug#9771.
1861 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1862 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1863 non-neutral characters if the current character is a paragraph
1864 separator (a.k.a. Newline). This avoids running the same
1865 expensive loop twice, once when we consume the preceding newline
1866 and the other time when the line actually needs to be displayed.
1867 Avoid the loop when we see neutrals on the base embedding level
1868 following a character whose directionality is the same as the
1869 paragraph's. This avoids running the expensive loop when a line
1870 ends in a long sequence of neutrals, like control characters.
1871 Add assertion against STRONG_AL type. Slightly rearrange code
1872 that determines the type of a neutral given the first non-neutral
1874 (bidi_level_of_next_char): Set next_en_pos to zero when
1875 invalidating its info.
1877 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1879 * xdisp.c (push_display_prop): Determine whether to record string
1880 or buffer position by IT->string, not by IT->method. Allow
1881 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1882 (move_it_vertically_backward): Don't look for character position
1883 immediately after the newline when in a continuation line.
1886 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1888 * window.c (coordinates_in_window): Rewrite and delabelize
1889 vertical border check. (Bug#5357) (Bug#9618)
1891 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1893 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1894 errors in XSetWindowBorder (bug#9310).
1896 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1898 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1899 avoid crash when xmalloc overrun checking is enabled.
1901 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1903 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1904 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1905 cursor motion with <left> and <right> arrow keys.
1907 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1908 some callers set that themselves.
1910 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1912 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1913 display string and the previous row comes from the same string and
1914 is empty. (Bug#9739) (Bug#9738)
1916 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1918 * doc.c (get_doc_string): Encode file name (bug#9735).
1920 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1922 * bidi.c (bidi_level_of_next_char):
1923 * xdisp.c (get_visually_first_element): Remove old incorrect
1924 comments regarding the Unicode Line Separator character.
1926 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1928 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1930 * alloc.c (Fgc_status): Do not access beyond zombies array
1931 boundary if nzombies > MAX_ZOMBIES.
1932 * alloc.c (dump_zombies): Add missing format specifier.
1934 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1936 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1937 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1939 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1940 Some packages use them to denote characters with modifiers.
1942 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1944 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1945 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1946 matching a pp-number. Rename parameter var to var1.
1948 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1950 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1952 2011-10-08 Glenn Morris <rgm@gnu.org>
1954 * callint.c (Fcall_interactively): Give a more explicit error for the
1955 'c' case with a non-character input. (Bug#8479)
1957 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1959 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1961 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1962 lines that are hscrolled on the left.
1964 * dispnew.c (buffer_posn_from_coords): Account for a possible
1965 presence of header-line. (Bug#4426)
1967 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1969 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1970 Don't advertise functionality which we discourage or doesn't work.
1972 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1974 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1975 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1976 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1977 this makes Emacs dump core during garbage collection on rare
1978 occasions. sizeof is obviously inferior to offsetof here, so
1979 stick with offsetof.
1980 (GC_POINTER_ALIGNMENT): New macro.
1981 (mark_memory): Omit 3rd (offset) arg; caller changed.
1982 Don't assume EMACS_INT alignment is the same as pointer alignment.
1984 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1986 * keyboard.c (read_key_sequence_remapped): New var.
1987 (read_key_sequence): Compute remapping in the right buffer.
1988 (command_loop_1): Use read_key_sequence's remapping directly.
1990 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1992 * dired.c (file_name_completion): Don't expand file name.
1993 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1994 before checking file name handler.
1996 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1997 they've been requested explicitly (bug#9591).
1999 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
2001 * keymap.c (Fsingle_key_description): Use make_specified_string
2002 instead of build_string to build string from push_key_description.
2005 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2007 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
2008 This fixes a Y2038 bug on 64-bit hosts.
2009 * buffer.c (reset_buffer):
2010 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
2011 (Fclear_buffer_auto_save_failure):
2012 Use 0, not -1, to represent an unset failure time, since time_t
2013 might not be signed.
2015 Remove dependency on glibc malloc internals.
2016 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2017 Move back here from lisp.h, but with their new implementations.
2018 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2019 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
2020 * charset.c (charset_table_init): New static var.
2021 (syms_of_charset): Use it instead of xmalloc. This removes a
2022 dependency on glibc malloc internals. See Eli Zaretskii's comment in
2023 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
2024 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2025 Move back to alloc.c.
2026 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2027 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
2029 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
2031 * nsterm.m (windowDidResize): Call x_set_window_size only when
2032 ns_in_resize is true. Otherwise set pixelwidth/height and
2033 call change_frame_size (Bug#9628).
2035 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2037 Port --enable-checking=all to Fedora 14 x86-64.
2038 * charset.c (syms_of_charset): Also account for glibc malloc's
2039 internal overhead when calculating the initial malloc maximum.
2041 Port --enable-checking=all to Fedora 14 x86.
2042 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2044 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
2045 (overrun_check_realloc, overrun_check_free):
2046 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
2047 That way, xmalloc returns a properly-aligned pointer even if
2048 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
2049 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
2050 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
2051 into account when calculating the initial malloc maximum.
2052 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2053 Move here from alloc.c, so that charset.c can use it too.
2054 Properly align; the old code wasn't right for common 32-bit hosts
2055 when configured with --enable-checking=all.
2056 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2057 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
2059 2011-09-29 Eli Zaretskii <eliz@gnu.org>
2061 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
2064 2011-09-28 Eli Zaretskii <eliz@gnu.org>
2066 * xdisp.c (compute_display_string_end): If there's no display
2067 string at CHARPOS, return -1.
2069 * bidi.c (bidi_fetch_char): When compute_display_string_end
2070 returns a negative value, treat the character as a normal
2071 character not covered by a display string. (Bug#9624)
2073 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
2075 * lread.c (Fread_from_string): Fix typo in docstring.
2077 2011-09-27 Eli Zaretskii <eliz@gnu.org>
2079 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2080 newline, reseat the iterator instead of bidi-iterating there one
2081 character at a time. (Bug#9610)
2082 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2083 TO_CHARPOS if the bidi iterator is at base embedding level.
2085 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2087 * lread.c (readevalloop): Use correct code for NBSP.
2088 (read1): Likewise. (Bug#9608)
2090 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
2092 * dbusbind.c (Fdbus_register_signal): When service is not
2093 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2095 2011-09-25 Glenn Morris <rgm@gnu.org>
2097 * buffer.c (truncate-lines): Doc fix.
2099 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
2101 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2102 (Fset_window_next_buffers): Doc fix.
2104 2011-09-24 Glenn Morris <rgm@gnu.org>
2106 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2108 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2110 Fix minor problems found by static checking.
2111 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
2112 * indent.c (Fvertical_motion): Fix == vs = typo.
2114 2011-09-24 Eli Zaretskii <eliz@gnu.org>
2116 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2117 Default value is now t. Doc fix.
2119 * indent.c (Fvertical_motion): Compute and apply the overshoot
2120 logic when moving up, not only when moving down. Fix the
2121 confusing name and values of the it_overshoot_expected variable;
2122 logic changes accordingly. (Bug#9254) (Bug#9549)
2124 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2125 CHARPOS is covered by a display string which includes newlines.
2126 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2127 is covered by a display string with embedded newlines.
2129 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
2131 * dbusbind.c (Fdbus_register_signal): Add match rule to
2132 Vdbus_registered_objects_table. (Bug#9581)
2133 (Fdbus_register_method, Vdbus_registered_objects_table):
2136 2011-09-24 Jim Meyering <meyering@redhat.com>
2138 do not ignore write error for any output size
2139 The previous change was incomplete.
2140 While it makes emacs --batch detect the vast majority of stdout
2141 write failures, errors were still ignored whenever the output size is
2142 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2143 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2144 && echo FAIL: ignored write error
2145 FAIL: ignored write error
2146 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2147 && echo FAIL: ignored write error
2148 FAIL: ignored write error
2149 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2151 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2153 * emacs.c (Fkill_emacs): In noninteractive mode exit
2154 non-successfully if a write error occurred on stdout. (Bug#9574)
2156 2011-09-21 Eli Zaretskii <eliz@gnu.org>
2158 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2161 * dispextern.h (struct it): Update the comment documenting what
2164 2011-09-20 Eli Zaretskii <eliz@gnu.org>
2166 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2167 a display string, extend search for cursor position to end of row.
2168 (find_row_edges): If the row ends in a newline from a display
2169 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2170 Handle the case of a display string with multiple newlines.
2171 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2172 non-empty line. Fixes confusing cursor motion with arrow keys at
2173 the beginning of a line that starts with whitespace.
2175 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2177 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2180 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
2182 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2185 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2187 * xdisp.c (display_line): Record maximum and minimum buffer
2188 positions even if no glyphs were produced (e.g., by a zero-width
2189 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2190 buffer positions that will be removed from the glyph row because
2192 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2193 column is beyond frame width: don't subtract 1 "pixel" when
2194 computing width of the stretch.
2195 (reseat_at_next_visible_line_start): Undo the change made on
2196 2011-09-17 that saved paragraph information and restored it after
2197 the call to `reseat'. (Bug#9545)
2199 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2201 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2202 and turn window cursor on if cleared (Bug#9415).
2204 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
2206 * search.c (boyer_moore): Take unibyte characters from pattern
2207 literally. (Bug#9458)
2209 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2211 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2213 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2215 Fix minor problem found by static checking.
2216 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2217 initialized, to pacify gcc -Wuninitialized.
2219 * fileio.c: Report proper errno when syscall falls.
2220 (Finsert_file_contents): Save and restore errno,
2221 so that report_file_error outputs the correct diagnostic.
2222 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2224 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2226 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2228 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2230 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2231 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2233 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2235 * xdisp.c (reseat_at_next_visible_line_start): Keep information
2236 about the current paragraph and restore it after the call to reseat.
2238 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2239 (bidi_find_paragraph_start): Search back for paragraph beginning
2240 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2241 (bidi_move_to_visually_next): Only trigger paragraph-related
2242 computations when the last character is a newline or at EOB, not
2243 just any NEUTRAL_B. (Bug#9470)
2245 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2246 truncated lines if point is covered by a display string. (Bug#9524)
2248 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2250 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2251 (cons_to_x_long): New function.
2252 (lisp_data_to_selection_data): Use it. Correct the test for
2253 short-versus-long data; it was negated. Break out of vector
2254 loop, for efficiency, when a long datum is discovered.
2256 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2258 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2260 2011-09-16 Eli Zaretskii <eliz@gnu.org>
2262 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2263 GCC PR/17406) by declaring this function with external scope.
2265 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2267 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2268 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2270 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2272 * editfns.c (Fformat): Correctly handle text properties on "%%".
2274 2011-09-15 Eli Zaretskii <eliz@gnu.org>
2276 * xterm.c (x_draw_composite_glyph_string_foreground):
2277 * w32term.c (x_draw_composite_glyph_string_foreground):
2278 * term.c (encode_terminal_code):
2279 * composite.c (composition_update_it, get_composition_id):
2280 * xdisp.c (get_next_display_element)
2281 (fill_composite_glyph_string): Add comments about special meaning
2282 of TAB characters in a composition.
2284 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2286 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
2287 This occurs when processing a multibyte format.
2288 Problem reported by Wolfgang Jenker.
2290 2011-09-15 Johan Bockgård <bojohan@gnu.org>
2292 * xdisp.c (try_cursor_movement): Only check for exact match if
2293 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2295 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2297 Remove unused external symbols.
2298 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2299 * xdisp.c (calc_pixel_width_or_height): Now static.
2300 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2301 * indent.c (check_display_width):
2302 * w32term.c: Fix comment to match code.
2303 * xterm.c, xterm.h (x_catching_errors): Remove.
2305 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2307 * xselect.c: Use signed conversions more consistently (Bug#9498).
2308 (selection_data_to_lisp_data): Assume incoming selection data are
2309 signed integers, not unsigned. This is to be consistent with
2310 outgoing selection data, which was modified to use signed integers
2311 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2312 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2313 expects long, not unsigned long.
2315 2011-09-14 Eli Zaretskii <eliz@gnu.org>
2317 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2318 computation of loop end. Reported by Johan Bockgård
2321 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
2323 * frame.c (Fother_visible_frames_p): Function deleted.
2325 2011-09-12 Eli Zaretskii <eliz@gnu.org>
2327 * indent.c (compute_motion): Process display vector front to back
2328 rather than the other way around. (Bug#2496)
2330 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2332 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2334 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
2336 * minibuf.c (Fread_from_minibuffer): Doc fix.
2338 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2340 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2341 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2343 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2345 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2346 value for non-existent files.
2348 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2350 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2351 set its "size" to -1. This will set the modtime_size field of
2352 the corresponding buffer to -1, which is what
2353 verify-visited-file-modtime expects for files that do not exist.
2356 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2358 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2360 * lisp.h: ... from here. push_key_description is no longer
2361 defined in keyboard.c, so its declaration should not be in
2362 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2363 logically belongs with push_key_description.
2365 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2367 * buffer.h: Include <sys/types.h> instead of <time.h>.
2368 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2369 Problem reported by Herbert J. Skuhra.
2371 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2373 * xml.c (parse_region): Make the parsing work for
2374 non-comment-starting XML files again (bug#9144).
2376 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2378 * image.c (gif_load): Fix calculation of bottom and right corner.
2381 2011-09-10 Eli Zaretskii <eliz@gnu.org>
2383 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2384 redisplay in small windows.
2386 2011-09-09 Eli Zaretskii <eliz@gnu.org>
2388 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2390 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2392 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2393 Operate on live windows only.
2395 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2397 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2399 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2401 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2402 only under bidi iteration.
2404 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2406 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2408 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2410 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2411 Without this fix, the command to link temacs failed due to an
2412 undefined symbol __builtin_isnan. This is because
2413 /usr/include/iso/math_c99.h #defines isnan(x) to
2414 __builtin_isnan(x), but the bundled gcc, which identifies itself
2415 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2417 * floatfns.c (isnan): #undef, and then #define to a clone of
2419 (Fisnan): Always define, since it's always available now.
2420 (syms_of_floatfns): Always define isnan at the Lisp level.
2422 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2424 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2426 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2428 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2429 The previous code assumed that file offsets (off_t values) fit in
2430 EMACS_INT variables, which is not true on typical 32-bit hosts.
2431 The code messed up by falsely reporting buffer overflow in cases
2432 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2433 when "big" contains more than 2**29 bytes, even though this
2434 inserts just one byte and does not overflow the buffer.
2435 (Finsert_file_contents): Store file offsets as off_t
2436 values, not as EMACS_INT values. Check for overflow when
2437 converting between EMACS_INT and off_t. When checking for
2438 buffer overflow or for overlap, take the offsets into account.
2439 Don't use EMACS_INT for small values where int suffices.
2440 When checking for overlap, fix a typo: ZV was used where
2441 ZV_BYTE was intended.
2442 (Fwrite_region): Don't assume off_t fits into 'long'.
2443 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2445 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2447 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2449 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2451 sprintf-related integer and memory overflow issues (Bug#9412).
2453 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2454 (esprintf, exprintf, evxprintf): New functions.
2455 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2456 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2457 (modify_event_symbol): Do not assume that the length of
2458 name_alist_or_stem is safe to alloca and fits in int.
2459 (Fexecute_extended_command): Likewise for function name and binding.
2460 (Frecursion_depth): Wrap around reliably on integer overflow.
2461 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2462 since some callers pass EMACS_INT values.
2463 (Fsingle_key_description): Don't crash if symbol name contains more
2464 than MAX_ALLOCA bytes.
2465 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2466 (get_minibuffer): Arg is now EMACS_INT, not int.
2467 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2468 (esprintf, exprintf, evxprintf): New decls.
2469 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2471 * dbusbind.c (signature_cat): New function.
2472 (xd_signature, Fdbus_register_signal):
2473 Do not overrun buffer; instead, report string overflow.
2475 * dispnew.c (add_window_display_history): Don't overrun buffer.
2476 Truncate instead; this is OK since it's just a log.
2478 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2479 even if the time zone offset is outlandishly large.
2480 Don't mishandle offset == INT_MIN.
2482 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2483 when creating daemon; the previous buffer-overflow check was incorrect.
2485 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2486 which has the guts of the old verror function.
2488 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2489 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2491 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2492 (font_unparse_xlfd): Don't blindly alloca long strings.
2493 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2494 fits in int, when using sprintf. Use single snprintf to count
2495 length of string rather than counting it via multiple sprintfs;
2496 that's simpler and more reliable.
2497 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2498 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2499 sprintf, in case result does not fit in int.
2501 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2502 (fontset_from_font): Print it.
2504 * frame.c (tty_frame_count): Now printmax_t, not int.
2505 (make_terminal_frame, set_term_frame_name): Print it.
2506 (x_report_frame_params): In X, window IDs are unsigned long,
2507 not signed long, so print them as unsigned.
2508 (validate_x_resource_name): Check for implausibly long names,
2509 and don't assume name length fits in 'int'.
2510 (x_get_resource_string): Don't blindly alloca invocation name;
2511 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2514 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2515 (xg_check_special_colors, xg_set_geometry):
2516 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2518 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2519 Use esprintf, not sprintf, in case result does not fit in int.
2521 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2522 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2523 it as a large positive number.
2524 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2525 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2527 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2528 in case result does not fit in int.
2530 * print.c (float_to_string): Detect width overflow more reliably.
2531 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2532 buffer overrun. Don't assume list length fits in 'int'. Treat
2533 print length of 0 as 0, not as infinity; to be consistent with other
2534 uses of print length in this function. Don't overflow print length
2535 index. Don't assume hash table size fits in 'long', or that
2536 vectorlike size fits in 'unsigned long'.
2538 * process.c (make_process): Use printmax_t, not int, to format
2539 process-name gensyms.
2541 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2543 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2544 to avoid potential buffer overrun.
2546 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2547 if X resource line is longer than 512 bytes.
2549 * xfns.c (x_window): Make sprintf buffer a bit bigger
2550 to avoid potential buffer overrun.
2552 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2554 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2556 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2558 Integer overflow fixes for scrolling, etc.
2559 Without these, Emacs silently mishandles large integers sometimes.
2560 For example, "C-u 4294967297 M-x recenter" was treated as if
2561 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2563 * xdisp.c (try_window_id): Check Emacs fixnum range before
2564 converting to 'int'.
2566 * window.c (window_scroll_line_based, Frecenter):
2567 Check that an Emacs fixnum is in range before assigning it to 'int'.
2568 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2569 values converted from Emacs fixnums.
2570 (Frecenter): Don't wrap around a line count if it is out of 'int'
2571 range; instead, treat it as an extreme value.
2572 (Fset_window_configuration, compare_window_configurations):
2573 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2575 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2576 that can exceed INT_MAX. Check that EMACS_INT value is in range
2577 before assigning it to the (possibly-narrower) index.
2578 (match_limit): Don't assume that a fixnum can fit in 'int'.
2580 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2583 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2584 (Fvertical_motion): Don't wrap around LINES values that don't fit
2585 in 'int'. Instead, treat them as extreme values. This is good
2586 enough for windows, which can't have more than INT_MAX lines anyway.
2588 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2590 * Require libxml/parser.h to avoid compilation warning.
2592 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2594 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2595 since this reportedly can destroy thread storage.
2597 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2599 * syntax.c (find_defun_start): Update all cache variables if
2600 exiting early (Bug#9401).
2602 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2604 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2606 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2607 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2608 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2610 * term.c (tty_append_glyph): New function.
2611 (produce_stretch_glyph): Static function and its prototype deleted.
2613 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2616 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2618 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2619 when checking :margin (Bug#9390).
2620 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2621 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2622 so that the name doesn't mislead. All uses changed.
2624 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2626 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2629 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2631 * xdisp.c (move_it_to): Don't bail out early when reaching
2632 position beyond to_charpos, if we are scanning backwards.
2633 (move_it_vertically_backward): When DY == 0, make sure we get to
2634 the first character in the line after the newline.
2636 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2638 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2639 (ccl_driver): Do not generate an out-of-range pointer.
2640 (Fccl_execute_on_string): Remove unnecessary check for
2641 integer overflow, noted by Stefan Monnier in
2642 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2643 Remove a FIXME that didn't need fixing.
2644 Simplify the newly-introduced buffer reallocation code.
2646 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2648 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2650 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2652 Integer and memory overflow issues (Bug#9196).
2654 * doc.c (get_doc_string): Rework so that
2655 get_doc_string_buffer_size is the actual buffer size, rather than
2656 being 1 less than the actual buffer size; this makes xpalloc more
2659 * image.c (x_allocate_bitmap_record, cache_image):
2660 * xselect.c (Fx_register_dnd_atom):
2661 Simplify previous changes by using xpalloc.
2663 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2664 since either will do and ptrdiff_t is convenient with xpalloc.
2666 * charset.c (charset_table_size)
2667 (struct charset_sort_data.priority): Now ptrdiff_t.
2668 (charset_compare): Don't overflow if priorities differ greatly.
2669 (Fsort_charsets): Don't assume list length fits in int.
2670 Check for size-calculation overflow when allocating sort data.
2671 (syms_of_charset): Allocate an initial charset table that is
2672 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2674 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2676 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2677 The actual value is always <= INT_MAX, and leaving it unsigned made
2678 overflow checking harder.
2680 * dispextern.h (struct glyph_matrix.rows_allocated)
2681 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2682 with xpalloc. The values are still always <= INT_MAX.
2684 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2686 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2687 (SAFE_NALLOCA): New macro.
2689 * region-cache.c (struct boundary.pos, find_cache_boundary)
2690 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2691 (set_cache_region, invalidate_region_cache)
2692 (revalidate_region_cache, know_region_cache, region_cache_forward)
2693 (region_cache_backward, pp_cache):
2694 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2695 so that ptrdiff_t * can be passed to xpalloc.
2696 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2697 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2698 (pp_cache): Don't assume cache_len fits in int.
2699 * region-cache.h: Adjust extern decls to match.
2701 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2702 EMACS_INT, since either will do, for xpalloc.
2704 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2705 (xnmalloc, xnrealloc, xpalloc): New functions.
2707 * bidi.c (bidi_shelve_header_size): New constant.
2708 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2709 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2711 * bidi.c (bidi_cache_shrink):
2712 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2714 Don't update size of array until after memory allocation succeeds,
2715 because xmalloc/xrealloc may not return.
2716 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2717 now that we have proper integer overflow checking.
2718 (record_overlay_string, overlay_strings): Catch overflows when
2719 calculating size of overlay_str_buf.
2721 * callproc.c (Fcall_process): Check for size overflow when
2722 calculating size of args2.
2723 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2724 Normally we prefer signed values, but sticking with ptrdiff_t would
2725 require adding more-complicated checks.
2727 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2728 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2729 Redo buffer-overflow calculations to avoid integer overflow.
2730 Add a FIXME comment where memory seems to be over-allocated.
2732 * character.c (Fstring): Check for size-calculation overflow.
2734 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2735 unnecessary integer overflow. Check for size overflow.
2736 (encode_coding_object): Don't update size until xmalloc succeeds.
2738 * composite.c (get_composition_id): Check for overflow in glyph
2739 length calculations.
2741 Integer and memory overflow fixes for display code.
2742 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2743 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2744 (scrolling_window): Check for overflow in size calculations.
2745 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2746 Don't assume glyph table len fits in int.
2747 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2748 (row_table_size): Now ptrdiff_t, not int.
2749 (scrolling_window): Avoid overflow in size calculations.
2750 Don't update size until allocation succeeds.
2751 * fns.c (concat): Check for overflow in size calculations.
2752 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2753 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2754 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2756 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2757 (get_doc_string): Check for size calculation overflow.
2758 Don't update size until allocation succeeds.
2759 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2760 EMACS_INT, where ptrdiff_t will do.
2761 (Fsubstitute_command_keys): Check for string overflow.
2763 * editfns.c (set_time_zone_rule): Don't assume environment length
2765 (message_length): Now ptrdiff_t, not int.
2766 (Fmessage_box): Don't update size until allocation succeeds.
2767 Don't assume message length fits in int.
2768 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2770 * emacs.c (main): Do not reallocate argv, since there is a null at
2771 the end that can be overwritten, and this way there's no need to
2772 worry about size-calculation overflow.
2773 (sort_args): Check for size-calculation overflow.
2775 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2777 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2779 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2780 (x_set_scroll_bar_width, x_figure_window_size):
2781 Check for integer overflow.
2782 (x_set_alpha): Do not assume XINT fits in int.
2784 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2785 This is for the members text_lines, text_cols, total_lines, total_cols,
2786 where the system imposes an 'int' limit.
2788 * fringe.c (Fdefine_fringe_bitmap):
2789 Don't update size until alloc works.
2791 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2792 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2794 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2795 Check for size-calculation overflow.
2796 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2797 do, as we prefer signed integers.
2798 (id_to_widget.max_size, id_to_widget.used)
2799 (xg_store_widget_in_map, xg_remove_widget_from_map)
2800 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2801 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2802 Use and return ptrdiff_t, not int.
2803 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2804 * gtkutil.h: Change prototypes to match the above.
2806 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2807 are duplicate now that they've been promoted to lisp.h.
2808 (x_allocate_bitmap_record, x_alloc_image_color)
2809 (make_image_cache, cache_image, xpm_load):
2810 Don't update size until alloc is done.
2811 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2813 Check for size calculation overflow.
2814 (ct_colors_allocated_max): New constant.
2815 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2818 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2819 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2820 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2821 Use ptrdiff_t, not int, to count maps.
2822 (read_char_minibuf_menu_prompt): Check for overflow in size
2823 calculations. Don't update size until allocation succeeds.
2824 Redo calculations to avoid overflow.
2825 * keyboard.h: Change prototypes to match the above.
2827 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2829 (current_minor_maps): Check for size calculation overflow.
2830 * keymap.h: Change prototypes to match the above.
2832 * lread.c (read1, init_obarray): Don't update size until alloc done.
2834 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2835 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2837 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2838 Now ptrdiff_t, not int.
2839 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2840 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2842 * process.c (Fnetwork_interface_list): Check for overflow
2843 in size calculation.
2845 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2847 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2848 overflow. Don't bother calling xmalloc when xrealloc will do.
2850 * search.c (Freplace_match): Check for size calculation overflow.
2851 (Fset_match_data): Don't assume list lengths fit in 'int'.
2853 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2854 for command line length. Do not attempt to address one before the
2855 beginning of an array, as that's not portable.
2857 * term.c (max_frame_lines): Remove; unused.
2858 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2860 (encode_terminal_code, calculate_costs): Check for size
2861 calculation overflow.
2862 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2863 table lengths and related sizes. Don't update size until alloc
2864 done. Redo calculations to avoid overflow.
2865 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2867 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2868 subtracting pointers.
2869 (gobble_line): Check for overflow more carefully. Don't update size
2872 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2873 Don't update size until alloc done.
2874 Redo size calculations to avoid overflow.
2875 Check for size calculation overflow.
2876 (main) [DEBUG]: Fix typo in invoking tparam1.
2878 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2879 Use ptrdiff_t, not int, for sizes.
2880 (store_mode_line_noprop_char): Don't update size until alloc done.
2882 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2883 Use ptrdiff_t, not int, for sizes.
2884 (Finternal_make_lisp_face, cache_face):
2885 Check for size calculation overflow.
2886 (cache_face): Treat size calculation overflows as if they were
2887 memory exhaustion (the usual treatment), rather than aborting.
2889 * xfns.c (x_encode_text, x_set_name_internal)
2890 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2891 sizes, since they can exceed INT_MAX in size. Check for size
2892 calculation overflow.
2894 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2895 (xg_select): Check for size calculation overflow.
2896 Don't update size until alloc done.
2898 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2899 as sprintf is limited to int lengths.
2901 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2902 (X_LONG_MIN): New macros.
2903 Use them to make the following changes clearer.
2904 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2905 This change doesn't affect the value now, but it may help remind
2906 future maintainers not to raise the value too much later.
2907 (SELECTION_QUANTUM): Remove, replacing with ...
2908 (selection_quantum): ... new function, which avoids overflow.
2910 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2911 assumption that selection length fits in 'int'.
2912 (x_reply_selection_request, x_handle_selection_request)
2913 (x_get_window_property, receive_incremental_selection)
2914 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2915 (lisp_data_to_selection_data, clean_local_selection_data):
2916 Use ptrdiff_t, not int, to record length of selection.
2917 (x_reply_selection_request, x_get_window_property)
2918 (receive_incremental_selection, x_property_data_to_lisp):
2919 Redo calculations to avoid overflow.
2920 (x_reply_selection_request): When sending hint, ceiling it at
2921 X_LONG_MAX rather than relying on wraparound overflow to send
2923 (x_get_window_property, receive_incremental_selection)
2924 (lisp_data_to_selection_data, x_property_data_to_lisp):
2925 Check for size-calculation overflow.
2926 (x_get_window_property, receive_incremental_selection)
2927 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2928 Don't store size until memory allocation succeeds.
2929 (x_get_window_property): Plug memory leak on memory exhaustion.
2930 Don't double-block input; malloc is safe here. Don't assume 2**34
2931 - 4 fits in unsigned long. Add an xassert to check
2932 XGetWindowProperty overflow. Be more careful about overflow
2933 calculations, and distinguish size from memory overflow better.
2934 (receive_incremental_selection): When tracing, don't assume
2935 unsigned int is less than INT_MAX.
2936 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2937 harmful) conversions of unsigned short to int.
2938 (lisp_data_to_selection_data): Don't assume that integers
2939 in the range -65535 through -1 fit in an X unsigned short.
2940 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2941 result parameters unless successful. Rely on cons_to_unsigned
2942 to report problems with elements; the old code wasn't right anyway.
2943 (x_check_property_data): Check for int overflow; we cannot use
2944 a wider type due to X limits.
2945 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2947 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2949 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2950 (x_term_init): Check for size calculation overflow.
2951 (x_color_cells): Don't store size until memory allocation succeeds.
2952 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2953 Don't assume alloca size is less than MAX_ALLOCA.
2954 (x_term_init): Don't assume length fits in int (sprintf is limited
2957 Use ptrdiff_t for composition IDs.
2958 * character.c (lisp_string_width):
2959 * composite.c (composition_table_size, n_compositions)
2960 (get_composition_id, composition_gstring_from_id):
2961 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2962 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2963 * window.c (Frecenter):
2964 Use ptrdiff_t, not int, for composition IDs.
2965 * composite.c (get_composition_id): Check for integer overflow.
2966 * composite.h: Adjust prototypes to match the above changes.
2968 Use ptrdiff_t for hash table indexes.
2969 * category.c (hash_get_category_set):
2970 * ccl.c (ccl_driver):
2971 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2972 * coding.c (coding_system_charset_list, detect_coding_system):
2973 * coding.h (struct coding_system.id):
2974 * composite.c (get_composition_id, gstring_lookup_cache):
2975 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2976 * image.c (xpm_get_color_table_h):
2977 * lisp.h (hash_lookup, hash_put):
2978 * minibuf.c (Ftest_completion):
2979 Use ptrdiff_t for hash table indexes, not int (which is too
2980 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2981 32-bit --with-wide-int hosts).
2983 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2984 Add a FIXME comment about memory leaks.
2985 (syms_of_charset): Don't assume xmalloc returns.
2987 Don't assume that stated character widths fit in int.
2988 * character.c (Fchar_width, c_string_width, lisp_string_width):
2989 * character.h (CHAR_WIDTH):
2990 * indent.c (MULTIBYTE_BYTES_WIDTH):
2991 Use sanitize_char_width to avoid undefined and/or bad behavior
2992 with outlandish widths.
2993 * character.h (sanitize_tab_width): Rename from sanitize_width,
2994 now that we have two such functions. All uses changed.
2995 (sanitize_char_width): New inline function.
2997 Don't assume that tab-width fits in int.
2998 * character.h (sanitize_width): New inline function.
2999 (SANE_TAB_WIDTH): New macro.
3000 (ASCII_CHAR_WIDTH): Use it.
3001 * indent.c (sane_tab_width): Remove. All uses replaced by
3002 SANE_TAB_WIDTH (current_buffer).
3003 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
3005 * fileio.c: Integer overflow issues with file modes.
3006 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
3008 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
3009 Remove unreachable code.
3010 (read_hex, load_charset_map_from_file): Check for integer overflow.
3012 * xterm.c: Don't go over XClientMessageEvent limit.
3013 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
3014 (x_send_scroll_bar_event): Likewise. Check that the size does not
3015 exceed limits imposed by XClientMessageEvent, as well as the usual
3016 ptrdiff_t and size_t limits.
3018 * keyboard.c: Overflow, signedness and related fixes.
3019 (make_lispy_movement): Use same integer type in forward decl
3020 that is used in the definition.
3021 (read_key_sequence, keyremap_step):
3022 Change bufsize argument back to int, undoing my 2011-03-30 change.
3023 We prefer signed types, and int is wide enough here.
3024 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
3025 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
3026 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
3027 length, not size_t. Use ptrdiff_t for index, not int.
3028 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
3029 possibility of integer overflow.
3031 Overflow, signedness and related fixes for images.
3033 * dispextern.h (struct it.stack[0].u.image.image_id)
3034 (struct_it.image_id, struct image.id, struct image_cache.size)
3035 (struct image_cache.used, struct image_cache.ref_count):
3036 * gtkutil.c (update_frame_tool_bar):
3037 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
3038 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
3039 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
3040 * nsmenu.m (update_frame_tool_bar):
3041 * xdisp.c (calc_pixel_width_or_height):
3042 * xfns.c (image_cache_refcount):
3043 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
3044 on typical 64-bit hosts.
3046 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3047 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
3048 Omit unnecessary casts to int.
3049 (parse_image_spec): Check that integers fall into 'int' range
3050 when the callers expect that.
3051 (image_ascent): Redo ascent calculation to avoid int overflow.
3052 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
3053 (lookup_image): Remove unnecessary tests.
3054 (xbm_image_p): Locals are now of int, not EMACS_INT,
3055 since parse_image_check makes sure they fit into int.
3056 (png_load, gif_load, svg_load_image):
3057 Prefer int to unsigned where either will do.
3058 (tiff_handler): New function, combining the cores of the
3059 old tiff_error_handler and tiff_warning_handler.
3060 This function is rewritten to use vsnprintf and thereby avoid
3061 stack buffer overflows. It uses only the features of vsnprintf
3062 that are common to both POSIX and native Microsoft.
3063 (tiff_error_handler, tiff_warning_handler): Use it.
3064 (tiff_load, gif_load, imagemagick_load_image):
3065 Don't assume :index value fits in 'int'.
3066 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
3067 (imagemagick_load_image): Check that crop parameters fit into
3068 the integer types that MagickCropImage accepts. Don't assume
3069 Vimagemagick_render_type has a nonnegative value. Don't assume
3070 size_t fits in 'long'.
3071 (gs_load): Use printmax_t to print the widest integers possible.
3072 Check for integer overflow when computing image height and width.
3074 2011-08-26 Eli Zaretskii <eliz@gnu.org>
3076 * xdisp.c (redisplay_window): Don't force window start if point
3077 will be invisible in the resulting window. (Bug#9324)
3079 2011-08-25 Eli Zaretskii <eliz@gnu.org>
3081 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3082 the display spec is of the form `(space ...)'.
3083 (handle_display_spec): Return the value returned by
3084 handle_single_display_spec, not just 1 or zero.
3085 (handle_single_display_spec): If the display spec is of the form
3086 `(space ...)', and specifies display in the text area, return 2
3088 (try_cursor_movement): Check for the need to scroll more
3089 accurately, and prefer exact match for point under bidi.
3090 Don't advance `row' beyond the last row of the window.
3092 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3093 into disp_prop; all users changed.
3095 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3096 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3097 for the text covered by the display property.
3099 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
3101 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3102 Change return value to nil.
3103 (Frecord_buffer): Delete unused function.
3105 2011-08-24 Eli Zaretskii <eliz@gnu.org>
3107 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3108 buffers, return left-to-right.
3109 (set_cursor_from_row): Consider candidate row a win if its glyph
3110 represents a newline and point is on that newline. Fixes cursor
3111 positioning on the newline at EOL of R2L text within L2R
3112 paragraph, and vice versa.
3113 (try_cursor_movement): Check continued rows, in addition to
3114 continuation rows. Fixes unwarranted scroll when point enters a
3115 continued line of R2L text within an L2R paragraph, or vice versa.
3116 (cursor_row_p): Consider the case of point being equal to
3117 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3118 from the end of a short line to the beginning of a continued line
3119 of R2L text within L2R paragraph.
3120 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3121 composed characters.
3123 * bidi.c (bidi_check_type): Use xassert.
3124 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3127 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3129 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3132 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
3134 * nsfont.m (ns_otf_to_script): Fix typo.
3136 2011-08-22 Kenichi Handa <handa@m17n.org>
3138 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3139 extra slot even if the purpose is char-code-property-table.
3141 2011-08-23 Eli Zaretskii <eliz@gnu.org>
3143 * xdisp.c (redisplay_window): When computing centering_position,
3144 account for the height of the header line. (Bug#8874)
3146 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3147 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3148 candidate is selected by the mouse, and that candidate has a
3149 composed character under the mouse.
3151 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3152 coordinates reported by pos-visible-in-window-p for a composed
3153 character in column zero.
3155 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3157 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3159 2011-08-22 Eli Zaretskii <eliz@gnu.org>
3161 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3162 consider it a hit if to_charpos is anywhere in the range of the
3163 composed buffer positions.
3165 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
3167 * image.c (gif_load): Don't assume that each subimage has the same
3168 dimensions as the base image. Handle disposal method that is
3169 "undefined" by the gif spec (Bug#9335).
3171 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
3173 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
3174 (Fcondition_case): Document `debug' symbol in error handler.
3176 2011-08-19 Eli Zaretskii <eliz@gnu.org>
3178 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3179 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3180 from an Org mode buffer to a Speedbar frame.
3182 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3183 a composition, take its buffer position from IT->cmp_it.charpos.
3184 Fixes cursor positioning at the beginning of a line that begins
3185 with a composed character.
3187 2011-08-18 Eli Zaretskii <eliz@gnu.org>
3189 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3190 character bidirectional type, use STRONG_L instead. Fixes crashes
3191 in a buffer produced by `describe-categories'.
3193 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3194 members before the level stack, so they would be saved and
3195 restored when copying iterator state. Fixes incorrect reordering
3196 around TABs covered by display properties.
3198 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3200 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
3202 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
3204 * eval.c (internal_condition_case, internal_condition_case_1)
3205 (internal_condition_case_2, internal_condition_case_n):
3206 Remove unnecessary aborts (Bug#9081).
3208 2011-08-17 Eli Zaretskii <eliz@gnu.org>
3210 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3211 has no `load' handler, try opening the file locally. (Bug#9311)
3213 2011-08-16 Ken Brown <kbrown@cornell.edu>
3215 * gmalloc.c: Expand comment.
3217 2011-08-16 Eli Zaretskii <eliz@gnu.org>
3219 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3220 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3222 2011-08-16 Ken Brown <kbrown@cornell.edu>
3224 Fix memory allocation problems in Cygwin build (Bug#9273).
3226 * unexcw.c ( __malloc_initialized): Declare external variable.
3227 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3229 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3231 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3233 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3235 [CYGWIN] (special_realloc): New function.
3236 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3237 requests to realloc storage in the static heap.
3239 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3241 * bidi.c (bidi_initialize): Remove unused local.
3243 2011-08-15 Eli Zaretskii <eliz@gnu.org>
3246 * biditype.h: Remove file.
3247 * makefile.w32-in ($(BLD)/bidi.$(O)):
3248 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
3250 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3252 * chartab.c: Improve commentary for the uniprop_table API.
3254 * bidi.c (bidi_paragraph_init): Support zero value of
3255 bidi_ignore_explicit_marks_for_paragraph_level.
3256 (bidi_initialize): Use uniprop_table instead of including
3257 biditype.h and bidimirror.h.
3259 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3260 coordinates of the iterator when restoring from ppos_it.
3263 2011-08-14 Kenichi Handa <handa@m17n.org>
3265 * process.c (create_process): Call setup_process_coding_systems
3266 after the pid of the process is set to -1 (Bug#8162).
3268 2011-08-14 Eli Zaretskii <eliz@gnu.org>
3270 * xdisp.c (move_it_in_display_line_to): Don't invoke
3271 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3272 ppos_it. Fixes vertical cursor motion when line beginning is
3273 covered by an image. (Bug#9296)
3275 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3277 * nsterm.h (ns_run_ascript): Declare.
3278 (NSAPP_DATA2_RUNASSCRIPT): Define.
3280 * nsfns.m (as_script, as_result, as_status): New static variables.
3281 (ns_run_ascript): New function.
3282 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
3283 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3284 the event loop. Get status from as_status (Bug#7276).
3286 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3287 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3288 the event loop (Bug#7276).
3290 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3292 * gnutls.c (QCgnutls_bootprop_priority)
3293 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3294 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3295 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3296 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3297 (QCgnutls_bootprop_verify_hostname_error)
3298 (QCgnutls_bootprop_callbacks_verify): Rename from
3299 Qgnutls_bootprop_..., all uses changed.
3301 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3304 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3306 * xfaces.c (Qframe_set_background_mode): Now static.
3307 * dispextern.h (Qframe_set_background_mode): Remove decl.
3309 * process.c (Fnetwork_interface_info): Declare local only if needed.
3311 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3313 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3314 (Fnetwork_interface_list): Allocate in increments of bytes instead
3315 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3316 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3318 (struct ifflag_def): notrailers is smart on OSX.
3319 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3320 Get hardware address with getifaddrs if available.
3322 2011-08-12 Eli Zaretskii <eliz@gnu.org>
3324 * xdisp.c (iterate_out_of_display_property): xassert that
3325 IT->position is set to within IT->object's boundaries. Break from
3326 the loop as soon as EOB is reached; avoids infloops in redisplay
3327 when IT->position is set up wrongly due to some bug.
3328 Set IT->current to match the bidi iterator unconditionally.
3329 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3330 entry. Force push_it to save on the stack the current
3331 buffer/string position, to be restored by pop_it. Fix flags in
3332 the iterator structure wrt the object coming from a display
3333 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3334 properties. (Bug#9284)
3336 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
3338 * fontset.c (fontset_get_font_group): Add proper type checks.
3341 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3343 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3344 and LC_VERSION_MIN_MACOSX.
3345 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3346 (dump_it) [LC_FUNCTION_STARTS]: Use it.
3348 2011-08-08 Eli Zaretskii <eliz@gnu.org>
3350 * xdisp.c (forward_to_next_line_start): Allow to use the
3351 no-display-properties-and-no-overlays under bidi display.
3352 Set disp_pos in the bidi iterator to avoid searches for display
3353 properties and overlays.
3355 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
3357 * editfns.c (Fset_time_zone_rule): Document relationship with the
3360 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3361 the font entity extracted from the cache (Bug#8109).
3363 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
3365 * composite.c (autocmp_chars): Don't reset point. That is done by
3366 restore_point_unwind (Bug#5984).
3368 2011-08-07 Juri Linkov <juri@jurta.org>
3370 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3371 to show the arg `TIME' instead of `TIMEVAL'.
3373 2011-08-06 Eli Zaretskii <eliz@gnu.org>
3375 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3376 display property strides EOL and includes a newline, as in
3377 longlines-mode. (Bug#9254)
3378 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3379 word-wrap under bidirectional display. (Bug#9224)
3381 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3382 is non-zero, even if the data buffer is NULL. Fixes a crash in
3383 vertical-motion with longlines-mode. (Bug#9254)
3385 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3387 * bidi.c <bidi_cache_total_alloc>: Now static.
3388 (bidi_initialize): Initialize bidi_cache_total_alloc.
3390 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3393 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3394 amount allocated this far in `bidi_cache_total_alloc'.
3395 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3396 non-zero, only free the data buffer without restoring the cache
3397 contents. All callers changed.
3399 * dispextern.h (bidi_unshelve_cache): Update prototype.
3401 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3402 (move_it_in_display_line, move_it_to)
3403 (move_it_vertically_backward, move_it_by_lines): Replace the call
3404 to xfree to an equivalent call to bidi_unshelve_cache.
3405 (move_it_in_display_line_to): Fix logic of returning
3406 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3408 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3410 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3411 came from a string character with a `cursor' property. (Bug#9229)
3413 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3415 * Makefile.in (LIB_PTHREAD): New variable.
3416 (LIBES): Add LIB_PTHREAD (Bug#9216).
3418 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3419 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3421 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3423 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3425 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3427 * xterm.c (x_find_topmost_parent): New function.
3428 (x_set_frame_alpha): Find topmost parent window with
3429 x_find_topmost_parent and set the property there also (bug#9181).
3430 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3432 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3434 * callproc.c (Fcall_process): Avoid vfork clobbering
3435 the local vars buffer, coding_systems, current_dir.
3437 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3439 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3441 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3443 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3444 so that it is not optimized away.
3446 * xdisp.c (compute_display_string_pos): Remove unused local.
3448 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3450 Fix slow cursor motion and scrolling in large buffers with
3451 selective display, like Org Mode buffers. (Bug#9218)
3453 * dispextern.h (struct bidi_it): New member disp_prop_p.
3455 * xdisp.c: Remove one-slot cache of display string positions.
3456 (compute_display_string_pos): Accept an additional argument
3457 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3458 for a display string or property. If found, set DISP_PROP_P
3461 * bidi.c (bidi_fetch_char): Accept an additional argument
3462 DISP_PROP_P, and pass it to compute_display_string_pos.
3463 Only handle text covered by a display string if DISP_PROP_P is returned
3464 non-zero. All callers of bidi_fetch_char changed.
3466 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3468 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3470 2010-12-03 Don March <don@ohspite.net>
3472 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3473 last character M-[char] is translated to ESC [char] (bug#7541).
3475 2011-08-02 Kenichi Handa <handa@m17n.org>
3477 * lisp.h (uniprop_table): Extern it.
3479 * chartab.c (uniprop_table): Make it non-static.
3481 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3483 * xdisp.c (forward_to_next_line_start): Accept additional argument
3484 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3486 (reseat_at_next_visible_line_start): Use the bidi iterator state
3487 returned by forward_to_next_line_start to restore the state of
3488 it->bidi_it after backing up to previous newline. (Bug#9212)
3490 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3492 * regex.c (re_comp): Protoize.
3493 (re_exec): Fix return type.
3494 (regexec): Fix type of `ret'. (Bug#9203)
3496 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3498 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3499 This is needed if max-image-size is a floating-point number.
3501 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3503 * print.c (print_object): Print empty symbol as ##.
3505 * lread.c (read1): Read ## as empty symbol.
3507 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3509 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3510 setting frame foreground color (Bug#9175).
3511 (x_set_background_color): Likewise.
3513 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3514 contents (Bug#9176).
3515 (EmacsTooltip -init): Remove bezels and add shadows to
3518 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3519 or scroll bar (Bug#8470).
3521 * nsfont.m (nsfont_open): Remove assignment to voffset and
3522 unnecessary vars hshink, expand, hd, full_height, min_height.
3523 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3525 * nsterm.h (nsfont_info): Remove voffset field.
3527 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3529 Implement strike-through and overline on NextStep (Bug#8863).
3531 * nsfont.m (nsfont_open): Use underline position provided by font,
3532 instead of hard-coded value of 2.
3533 (nsfont_draw): Call ns_draw_text_decoration instead.
3535 * nsterm.h: Add declaration for ns_draw_text_decoration.
3537 * nsterm.m (ns_draw_text_decoration): New function for drawing
3538 underline, overline, and strike-through.
3539 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3540 ns_draw_text_decoration. Change treatment of cursor drawing to
3541 accommodate underlining, etc.
3543 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3545 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3548 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3550 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3551 Without this fix, if a signal arrives just after memory fills up,
3552 'malloc' might be invoked reentrantly.
3554 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3555 In other words, assume that every image size is allowed, on non-X
3556 hosts. This assumption is probably wrong, but it lets Emacs compile.
3558 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3560 * regex.c (re_iswctype): Convert return values to boolean.
3562 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3564 * xdisp.c (compute_display_string_pos): Don't use cached display
3565 string position if the buffer had its restriction changed.
3568 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3570 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3572 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3574 Integer signedness and overflow and related fixes. (Bug#9079)
3576 * bidi.c: Integer size and overflow fixes.
3577 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3578 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3579 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3580 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3581 (bidi_find_other_level_edge):
3582 Use ptrdiff_t instead of EMACS_INT where either will do.
3583 This works better on 32-bit hosts configured --with-wide-int.
3584 (bidi_cache_ensure_space): Check for size-calculation overflow.
3585 Use % rather than repeated addition, for better worst-case speed.
3586 Don't set bidi_cache_size until after xrealloc returns, because it
3588 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3589 (bidi_cache_ensure_space): Also check that the bidi cache size
3590 does not exceed that of the largest Lisp string or buffer. See Eli
3591 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3593 * alloc.c (__malloc_size_t): Remove.
3594 All uses replaced by size_t. See Andreas Schwab's note
3595 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3597 * image.c: Improve checking for integer overflow.
3598 (check_image_size): Assume that f is nonnull, since
3599 it is always nonnull in practice. This is one less thing to
3600 worry about when checking for integer overflow later.
3601 (x_check_image_size): New function, which checks for integer
3602 overflow issues inside X.
3603 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3604 This removes the need for a memory_full check.
3605 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3606 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3607 (xbm_read_bitmap_data): Change locals back to 'int', since
3608 their values must fit in 'int'.
3609 (xpm_load_image, png_load, tiff_load):
3610 Invoke x_create_x_image_and_pixmap earlier,
3611 to avoid much needless work if the image is too large.
3612 (tiff_load): Treat overly large images as if
3613 x_create_x_image_and_pixmap failed, not as malloc failures.
3614 (gs_load): Use x_check_image_size.
3616 * gtkutil.c: Omit integer casts.
3617 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3618 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3620 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3622 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3623 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3624 would wrongly return t on a 64-bit host.
3626 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3627 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3628 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3629 and therefore cause GCC to emit a bogus diagnostic in some cases.
3631 * image.c: Integer signedness and overflow and related fixes.
3632 This is not an exhaustive set of fixes, but it's time to
3633 record what I've got.
3634 (lookup_pixel_color, check_image_size): Remove redundant decls.
3635 (check_image_size): Don't assume that arbitrary EMACS_INT values
3636 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3637 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3638 (tiff_load, imagemagick_load_image):
3639 Check for overflow in size calculations.
3640 (x_create_x_image_and_pixmap): Remove unnecessary test for
3641 xmalloc returning NULL; that can't happen.
3642 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3643 (xpm_color_bucket): Use better integer hashing function.
3644 (xpm_cache_color): Don't possibly over-allocate memory.
3645 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3646 (gif_memory_source):
3647 Use ptrdiff_t, not int or size_t, to record sizes.
3648 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3649 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3650 either works, as we prefer signed integers.
3651 (tiff_read_from_memory, tiff_write_from_memory):
3652 Return tsize_t, not size_t, since that's what the TIFF API wants.
3653 (tiff_read_from_memory): Don't fail simply because the read would
3654 go past EOF; instead, return a short read.
3655 (tiff_load): Omit no-longer-needed casts.
3656 (Fimagemagick_types): Don't assume size fits into 'int'.
3658 Improve hashing quality when configured --with-wide-int.
3659 * fns.c (hash_string): New function, taken from sxhash_string.
3660 Do not discard information about ASCII character case; this
3661 discarding is no longer needed.
3662 (sxhash-string): Use it. Change sig to match it. Caller changed.
3663 * lisp.h: Declare it.
3664 * lread.c (hash_string): Remove, since we now use fns.c's version.
3665 The fns.c version returns a wider integer if --with-wide-int is
3666 specified, so this should help the quality of the hashing a bit.
3668 * emacs.c: Integer overflow minor fix.
3669 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3670 Define only if GNU_LINUX.
3671 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3673 * dispnew.c: Integer signedness and overflow fixes.
3674 Remove unnecessary forward decls, that were a maintenance hassle.
3675 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3677 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3678 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3679 (prepare_desired_row, line_draw_cost):
3680 Use int, not unsigned, where either works.
3681 (save_current_matrix, restore_current_matrix):
3682 Use ptrdiff_t, not size_t, where either works.
3683 (init_display): Check for overflow more accurately, and without
3684 relying on undefined behavior.
3686 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3687 Remove, replacing with the new symbols in lisp.h. All uses changed.
3688 * fileio.c (make_temp_name):
3689 * filelock.c (lock_file_1, lock_file):
3690 * xdisp.c (message_dolog):
3691 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3692 Use pMd etc. instead.
3693 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3694 replacing the pWIDE etc. symbols removed from editfns.c.
3696 * keyboard.h (num_input_events): Now uintmax_t.
3697 This is (very slightly) less likely to mess up due to wraparound.
3700 * buffer.c: Integer signedness fixes.
3701 (alloc_buffer_text, enlarge_buffer_text):
3702 Use ptrdiff_t rather than size_t when either will do, as we prefer
3705 * alloc.c: Integer signedness and overflow fixes.
3706 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3707 (__malloc_size_t): Default to size_t, not to int.
3708 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3709 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3710 Prefer ptrdiff_t to size_t when either would do, as we prefer
3712 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3713 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3714 Now const. Initialize with values that are in range even if char
3716 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3717 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3718 These functions do the right thing with sizes > 2**32.
3719 (check_depth): Now ptrdiff_t, not int.
3720 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3721 Adjust to new way of storing sizes. Check for size overflow bugs
3723 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3724 slightly wrong anyway, as it missed one instance of
3725 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3726 (refill_memory_reserve): Omit needless cast to size_t.
3727 (mark_object_loop_halt): Mark as externally visible.
3729 * xselect.c: Integer signedness and overflow fixes.
3730 (Fx_register_dnd_atom, x_handle_dnd_message):
3731 Use ptrdiff_t, not size_t, since we prefer signed.
3732 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3733 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3734 x_dnd_atoms_size and x_dnd_atoms_length.
3736 * doprnt.c: Prefer signed to unsigned when either works.
3738 * doprnt.c (doprnt):
3740 * xdisp.c (vmessage):
3741 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3742 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3743 prefer signed arithmetic to avoid comparison confusion.
3744 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3745 but is a bit tricky.
3747 Assume freestanding C89 headers, string.h, stdlib.h.
3748 * data.c, doprnt.c, floatfns.c, print.c:
3749 Include float.h unconditionally.
3750 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3751 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3752 * regex.c: Likewise for stddef.h, string.h.
3753 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3754 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3755 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3756 (STDC_HEADERS): Remove obsolete defines.
3757 * sysdep.c: Include limits.h unconditionally.
3759 Assume support for memcmp, memcpy, memmove, memset.
3760 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3761 * regex.c (memcmp, memcpy):
3762 Remove; we assume C89 now.
3764 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3765 (__malloc_safe_bcopy): Remove; no longer needed.
3767 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3768 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3769 well either way, and we prefer signed to unsigned.
3771 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3773 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3774 closes the connection while we're reading (bug#9182).
3776 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3778 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3779 are specified (Bug#9168).
3781 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3783 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3784 Found by GCC static checking and --with-wide-int on a 32-bit host.
3786 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3788 * xdisp.c (compute_display_string_pos): Fix logic of caching
3789 previous display string position. Initialize cached_prev_pos to
3790 -1. Fixes slow-down at the beginning of a buffer.
3792 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3794 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3795 for attrs[LFACE_FONTSET_INDEX].
3797 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3799 * xml.c (parse_region): Remove unused local
3800 that was recently introduced.
3802 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3804 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3805 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3807 * xdisp.c (move_it_in_display_line_to): Record the best matching
3808 position for TO_CHARPOS while scanning the line, and restore it on
3809 exit if none of the characters scanned was an exact match.
3810 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3811 when exact match is impossible due to invisible text, and the
3812 lines are truncated.
3814 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3816 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3819 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3821 Fix a significant slow-down of cursor motion with C-n, C-p,
3822 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3823 auto-repeat under bidi redisplay in fontified buffers.
3824 * xdisp.c (compute_stop_pos_backwards): New function.
3825 (next_element_from_buffer): Call compute_stop_pos_backwards to
3826 find a suitable prev_stop when we find ourselves before
3828 (reseat): Don't look for prev_stop, as that could mean a very long
3830 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3831 <cached_disp_overlay_modiff>: Cache for last found display string
3833 (compute_display_string_pos): Return the cached position if asked
3834 about the same buffer in the same area of character positions, and
3835 the buffer wasn't changed since the time the display string
3836 position was cached.
3838 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3840 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3841 is an integer, which is important for empty lines. (Bug#9149)
3843 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3845 * frame.c (Fmodify_frame_parameters): In tty case, update the
3846 default face if necessary (Bug#4238).
3848 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3850 * editfns.c (Fstring_to_char): No need to explain what a character
3851 is in the docstring (Bug#6576).
3853 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3855 * xml.c (parse_region): Make sure we always return a tree.
3857 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3859 * xml.c (parse_region): If a document contains only comments,
3862 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3864 * xml.c (make_dom): Return comments, too.
3866 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3869 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3870 and the surrounding thread.
3871 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3872 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3873 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3875 * s/openbsd.h (BROKEN_SIGIO): Define.
3876 * unexelf.c (unexec) [__OpenBSD__]:
3877 Don't update the .mdebug section of the Alpha COFF symbol table.
3879 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3881 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3884 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3886 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3887 This fixes some race conditions on the permissions of any newly
3890 * alloc.c (valid_pointer_p): Use pipe, not open.
3891 This fixes some permissions issues when debugging.
3893 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3894 If fchown fails to set both uid and gid, try to set just gid,
3895 as that is sometimes allowed. Adjust the file's mode to eliminate
3896 setuid or setgid bits that are inappropriate if fchown fails.
3898 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3900 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3901 to compare Lisp_Objects.
3902 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3903 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3904 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3906 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3908 * lread.c (read_integer): Unread even EOF character.
3909 (read1): Likewise. Properly record start position of symbol.
3911 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3912 symbol character follows.
3914 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3916 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3917 This works around a problem with the previous change to Fcopy_file.
3918 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3919 and without this change, GCC might complain about discarding
3920 fchown's return value.
3922 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3924 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3926 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3928 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3930 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3932 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3933 it's used from the C level.
3935 * process.c: Use the same condition for POLL_FOR_INPUT in both
3936 keyboard.c and process.c (bug#1858).
3938 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3940 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3941 (Fgnutls_boot): Use it.
3943 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3945 * doc.c (Fsubstitute_command_keys): Revert last change.
3947 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3949 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3950 quotes the next character, and doesn't affect other longer
3951 sequences (bug#8935).
3953 * lread.c (syms_of_lread): Clarify that is isn't only
3954 `eval-buffer' and `eval-defun' that's affected by
3955 `lexical-binding' (bug#8460).
3957 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3959 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3960 bidi redisplay when a line includes both an image and is truncated.
3962 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3964 Fix minor problems found by static checking.
3965 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3966 (elsz): Now a signed constant, not a size_t var. We prefer signed
3967 types to unsigned, to avoid integer comparison confusion. Without
3968 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3969 "cannot optimize loop, the loop counter may overflow", a symptom
3971 * indent.c (Fvertical_motion): Mark locals as initialized.
3972 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3974 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3976 * search.c (Fre_search_backward): Mention `case-fold-search' in
3977 all the re_search_* functions (bug#8138).
3979 * keyboard.c (Fopen_dribble_file): Document when the file is
3982 2011-07-14 Eli Zaretskii <eliz@gnu.org>
3984 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3987 Support bidi reordering of display and overlay strings.
3988 * xdisp.c (compute_display_string_pos)
3989 (compute_display_string_end): Accept additional argument STRING.
3990 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3991 (reseat_to_string): Initialize bidi_it->string.s and
3992 bidi_it->string.schars.
3993 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3994 NULL (avoids a crash in bidi_paragraph_init).
3995 Initialize itb.string.lstring.
3996 (init_iterator): Call bidi_init_it only of a valid
3997 buffer position was specified. Initialize paragraph_embedding to
3999 (reseat_to_string): Initialize the bidi iterator.
4000 (display_string): If we need to ignore text properties of
4001 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
4002 original value of -1 will not work with bidi.)
4003 (compute_display_string_pos): First arg is now struct
4004 `text_pos *'; all callers changed. Support display properties on
4006 (compute_display_string_end): Support display properties on Lisp
4008 (init_iterator, reseat_1, reseat_to_string): Initialize the
4009 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
4010 when iterating on a string not from display properties).
4011 (compute_display_string_pos, compute_display_string_end):
4012 Fix calculation of the object to scan. Fixes an error when using
4014 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
4015 base_level_stop; instead, set base_level_stop to BEGV.
4016 Fixes crashes in vertical-motion.
4017 (next_element_from_buffer): Improve commentary for when
4018 the iterator is before prev_stop.
4019 (init_iterator): Initialize bidi_p from the default value of
4020 bidi-display-reordering, not from buffer-local value. Use the
4021 buffer-local value only if initializing for buffer iteration.
4022 (handle_invisible_prop): Support invisible properties on strings
4023 that are being bidi-reordered.
4024 (set_iterator_to_next): Support bidi reordering of C strings and
4026 (next_element_from_string): Support bidi reordering of Lisp
4028 (handle_stop_backwards): Support Lisp strings as well.
4029 (display_string): Support display of R2L glyph rows.
4030 Use IT_STRING_CHARPOS when displaying from a Lisp string.
4031 (init_iterator): Don't initialize it->bidi_p for strings
4033 (reseat_to_string): Initialize it->bidi_p for strings here.
4034 (next_element_from_string, next_element_from_c_string)
4035 (next_element_from_buffer): Add xassert's for correspondence
4036 between IT's object being iterated and it->bidi_it.string
4038 (face_before_or_after_it_pos): Support bidi iteration.
4039 (next_element_from_c_string): Handle the case of the first string
4040 character that is not the first one in the visual order.
4041 (get_visually_first_element): New function, refactored from common
4042 parts of next_element_from_buffer, next_element_from_string, and
4043 next_element_from_c_string.
4044 (tool_bar_lines_needed, redisplay_tool_bar)
4045 (display_menu_bar): Force left-to-right direction. Add a FIXME
4046 comment for making that be controlled by a user option.
4047 (push_it, pop_it): Save and restore the state of the
4048 bidi iterator. Save and restore the bidi_p flag.
4049 (pop_it): Iterate out of display property for string iteration as
4051 (iterate_out_of_display_property): Support iteration over strings.
4052 (handle_single_display_spec): Set up it->bidi_it for iteration
4053 over a display string, and call bidi_init_it.
4054 (handle_single_display_spec, next_overlay_string)
4055 (get_overlay_strings_1, push_display_prop): Set up the bidi
4056 iterator for displaying display or overlay strings.
4057 (forward_to_next_line_start): Don't use the shortcut if
4059 (back_to_previous_visible_line_start): If handle_display_prop
4060 pushed the iterator stack, restore the internal state of the bidi
4061 iterator by calling bidi_pop_it same number of times.
4062 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
4063 and we are bidi-iterating, don't decrement the iterator position;
4064 instead, set the first_elt flag in the bidi iterator, to produce
4066 (reseat_1): Remove redundant setting of string_from_display_prop_p.
4067 (push_display_prop): xassert that we are iterating a buffer.
4068 (push_it, pop_it): Save and restore paragraph_embedding member.
4069 (handle_single_display_spec, next_overlay_string)
4070 (get_overlay_strings_1, reseat_1, reseat_to_string)
4071 (push_display_prop): Set up the `unibyte' member of bidi_it.string
4072 correctly. Don't assume unibyte strings are not bidi-reordered.
4073 (compute_display_string_pos)
4074 (compute_display_string_end): Fix handling the case of C string.
4075 (push_it, pop_it): Save and restore from_disp_prop_p.
4076 (handle_single_display_spec, push_display_prop): Set the
4077 from_disp_prop_p flag.
4078 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4079 (pop_it): Call iterate_out_of_display_property only if we are
4080 popping after iteration over a string that came from a display
4081 property. Fix a typo in popping stretch info. Add an assertion
4082 for verifying that the iterator position is in sync with the bidi
4084 (handle_single_display_spec, get_overlay_strings_1)
4085 (push_display_prop): Fix initialization of paragraph direction for
4086 string when that of the parent object is not yet determined.
4087 (reseat_1): Call bidi_init_it to resync the bidi
4088 iterator with IT's position. (Bug#7616)
4089 (find_row_edges): If ROW->start.pos gives position
4090 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4091 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4092 Reset the from_disp_prop_p flag.
4093 (SAVE_IT, RESTORE_IT): New macros.
4094 (pos_visible_p, face_before_or_after_it_pos)
4095 (back_to_previous_visible_line_start)
4096 (move_it_in_display_line_to, move_it_in_display_line)
4097 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4098 (try_scrolling, redisplay_window, display_line): Use them when
4099 saving a temporary copy of the iterator and restoring it back.
4100 (back_to_previous_visible_line_start, reseat_1)
4101 (init_iterator): Empty the bidi cache "stack".
4102 (move_it_in_display_line_to): If iterator ended up at
4103 EOL, but we never saw any buffer positions smaller than
4104 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4105 motion in bidi-reordered lines.
4106 (move_it_in_display_line_to): Record prev_method and prev_pos
4107 immediately before the call to set_iterator_to_next. Fixes cursor
4108 motion in bidi-reordered lines with stretch glyphs and strings
4109 displayed in margins. (Bug#8133) (Bug#8867)
4110 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4112 (pos_visible_p): Support positions in bidi-reordered lines.
4113 Save and restore bidi cache.
4115 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4116 (bidi_paragraph_info): Delete unused struct.
4117 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4118 (bidi_cache_start): New variable.
4119 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4121 (bidi_cache_fetch_state, bidi_cache_search)
4122 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4123 (bidi_cache_find, bidi_peek_at_next_level)
4124 (bidi_level_of_next_char, bidi_find_other_level_edge)
4125 (bidi_move_to_visually_next): Compare cache index with
4126 bidi_cache_start rather than with zero.
4127 (bidi_fetch_char): Accept new argument STRING; all callers
4128 changed. Support iteration over a string. Support strings with
4129 display properties. Support unibyte strings. Fix the type of
4130 `len' according to what STRING_CHAR_AND_LENGTH expects.
4131 (bidi_paragraph_init, bidi_resolve_explicit_1)
4132 (bidi_resolve_explicit, bidi_resolve_weak)
4133 (bidi_level_of_next_char, bidi_move_to_visually_next):
4134 Support iteration over a string.
4135 (bidi_set_sor_type, bidi_resolve_explicit_1)
4136 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4137 can now be zero (for strings); special values 0 and -1 were
4138 changed to -1 and -2, respectively.
4139 (bidi_char_at_pos): New function.
4140 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4141 Call it instead of FETCH_MULTIBYTE_CHAR.
4142 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4143 initialized to valid values.
4144 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4146 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4147 the test for valid cached positions. Fix the logic for looking up
4148 the sentinel state in the cache. GCPRO the Lisp string we are
4150 (bidi_push_it, bidi_pop_it): New functions.
4151 (bidi_initialize): Initialize the bidi cache start stack pointer.
4152 (bidi_cache_ensure_space): New function, refactored from part of
4153 bidi_cache_iterator_state. Don't assume the required size is just
4154 one BIDI_CACHE_CHUNK away.
4155 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4156 (bidi_count_bytes, bidi_char_at_pos): New functions.
4157 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4158 always valid if bidi_cache_idx is valid.
4159 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4160 is valid if it's going to be used.
4161 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4162 (bidi_cache_fetch_state, bidi_cache_search)
4163 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4164 (bidi_cache_iterator_state, bidi_cache_find)
4165 (bidi_find_other_level_edge, bidi_cache_start_stack):
4166 All variables related to cache indices are now EMACS_INT.
4168 * dispextern.h (struct bidi_string_data): New structure.
4169 (struct bidi_it): New member `string'. Make flag members be 1-bit
4170 fields, and put them last in the struct.
4171 (compute_display_string_pos, compute_display_string_end):
4173 (bidi_push_it, bidi_pop_it): Add prototypes.
4174 (struct iterator_stack_entry): New members bidi_p,
4175 paragraph_embedding, and from_disp_prop_p.
4176 (struct it): Member bidi_p is now a bit field 1 bit wide.
4177 (bidi_shelve_cache, bidi_unshelve_cache):
4180 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4181 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4182 and vector-like objects.
4184 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4185 cache around display iteration.
4187 * window.c (Fwindow_end, window_scroll_pixel_based)
4188 (displayed_window_lines, Frecenter): Save and restore the bidi
4189 cache around display iteration.
4191 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4193 * editfns.c (Fdelete_region): Clarify the use of the named
4194 parameters (bug#6788).
4196 2011-07-14 Martin Rudalics <rudalics@gmx.at>
4198 * indent.c (Fvertical_motion): Set and restore w->pointm when
4199 saving and restoring the window's buffer (Bug#9006).
4201 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4203 * editfns.c (Fstring_to_char): Clarify just what is returned
4204 (bug#6576). Text by Eli Zaretskii.
4206 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
4208 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4210 2011-07-13 Eli Zaretskii <eliz@gnu.org>
4212 * buffer.c (mmap_find): Fix a typo.
4214 2011-07-13 Johan Bockgård <bojohan@gnu.org>
4216 Fix execution of x selection hooks.
4217 * xselect.c (Qx_lost_selection_functions)
4218 (Qx_sent_selection_functions): New vars.
4219 (syms_of_xselect): DEFSYM them.
4220 (x_handle_selection_request): Pass Qx_sent_selection_functions
4221 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4222 (x_handle_selection_clear,x_clear_frame_selections):
4223 Pass Qx_lost_selection_functions rather than
4224 Vx_lost_selection_functions to Frun_hook_with_args.
4226 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4228 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
4229 The old code sometimes used this field without initializing it.
4231 * alloc.c (gc_sweep): Don't read past end of array.
4232 In theory, the old code could also have corrupted Emacs internals,
4233 though it'd be very unlikely.
4235 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4237 * character.c (Fcharacterp): Don't advertise optional ignored
4238 argument. (Bug#4026)
4240 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4242 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4245 * window.c (Fset_window_start): Doc fix (bug#4199).
4246 (Fset_window_hscroll): Ditto.
4248 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4250 Fix minor new problems caught by GCC 4.6.1.
4251 * term.c (init_tty): Remove unused local.
4252 * xsettings.c (store_monospaced_changed): Define this function only
4253 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
4256 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
4258 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4260 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4262 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4263 are the mini-buffer and the echo area (bug#3320).
4265 * term.c (init_tty): Remove support for supdup, c10 and perq
4266 terminals, which are no longer supported (bug#1482).
4268 2011-07-10 Johan Bockgård <bojohan@gnu.org>
4270 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4272 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4274 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4275 for non-popups (Bug#3642).
4277 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4279 * alloc.c (reset_malloc_hooks): Protoize.
4280 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
4281 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4282 * cm.c (losecursor): Likewise.
4283 * data.c (fmod): Likewise.
4284 * dispnew.c (swap_glyphs_in_rows): Likewise.
4285 * emacs.c (memory_warning_signal): Likewise.
4286 * floatfns.c (float_error): Likewise.
4287 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4288 (otf_open, font_otf_capability, generate_otf_features)
4289 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4291 * image.c (pbm_read_file): Likewise.
4292 * indent.c (string_display_width): Likewise.
4293 * intervals.c (check_for_interval, search_for_interval)
4294 (inc_interval_count, count_intervals, root_interval)
4295 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4296 * lread.c (defalias): Likewise.
4297 * ralloc.c (r_alloc_check): Likewise.
4298 * regex.c (set_image_of_range_1, set_image_of_range)
4299 (regex_grow_registers): Likewise.
4300 * sysdep.c (strerror): Likewise.
4301 * termcap.c (valid_filename_p, tprint, main): Likewise.
4302 * tparam.c (main): Likewise.
4303 * unexhp9k800.c (run_time_remap, save_data_space)
4304 (update_file_ptrs, read_header, write_header, calculate_checksum)
4305 (copy_file, copy_rest, display_header): Likewise.
4306 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4308 * xdisp.c (check_it): Likewise.
4309 * xfaces.c (register_color, unregister_color, unregister_colors):
4311 * xfns.c (print_fontset_result): Likewise.
4312 * xrdb.c (member, fatal, main): Likewise.
4314 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4316 Fix minor problems found by static checking (Bug#9031).
4317 * chartab.c (char_table_set_range, map_sub_char_table):
4318 Remove unused locals.
4319 (uniprop_table): Now static.
4320 * composite.c (_work_char): Remove unused static var.
4322 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
4324 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4326 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4328 * gtkutil.c (qttip_cb): Remove code without function.
4330 2011-07-09 Eli Zaretskii <eliz@gnu.org>
4332 * w32.c (pthread_sigmask): New stub.
4334 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
4336 Use pthread_sigmask, not sigprocmask (Bug#9010).
4337 sigprocmask is portable only for single-threaded applications, and
4338 Emacs can be multi-threaded when it uses GTK.
4339 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4341 * callproc.c (Fcall_process):
4342 * process.c (create_process):
4343 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4344 Use pthread_sigmask, not sigprocmask.
4346 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4348 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4349 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4352 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4354 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4355 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4356 (xg_hide_tooltip): Fix comment.
4358 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4359 in registerServicesMenuSendTypes.
4360 (validRequestorForSendType): Don't check ns_return_types.
4362 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4365 2011-07-08 Jason Rumney <jasonr@gnu.org>
4367 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4368 SH_SHOW for hidden windows (Bug#5482).
4370 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4371 frame struct members of non-existent frames (Bug#6284).
4373 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4375 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4376 variable firstTime not needed on OSX >= 10.6.
4377 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4378 >= 10.5. Use setKnobProportion, setDoubleValue.
4380 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4381 (MAC_OS_X_VERSION_10_5): Define if not defined.
4382 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4383 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4384 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4386 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4387 cString and lossyCString on OSX >= 10.4
4389 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4390 sizeToFit on OSX >= 10.2.
4392 * nsimage.m (allocInitFromFile): Don't use deprecated method
4393 bestRepresentationForDevice on OSX >= 10.6.
4395 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4398 * emacs.c: Declare unexec_init_emacs_zone.
4400 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4402 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4404 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4405 on svcsMenu (Bug#8842).
4407 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4409 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4411 * nsterm.m (QUTF8_STRING): Declare.
4412 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4413 (validRequestorForSendType): Return type is (id).
4414 Change indexOfObjectIdenticalTo to indexOfObject.
4415 Check if we have local selection before returning self (Bug#8842).
4416 (writeSelectionToPasteboard): Put local selection into paste board
4417 if we have a local selection (Bug#8842).
4418 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4420 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4421 (ns_get_local_selection): Declare.
4423 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4425 * keymap.c (describe_map_tree): Don't insert a double newline at
4426 the end of the buffer (bug#1169) and return whether we inserted
4429 * callint.c (Fcall_interactively): Change "reading args" to
4430 "providing args" to try to clarify what it does (bug#1010).
4432 2011-07-07 Kenichi Handa <handa@m17n.org>
4434 * composite.c (composition_compute_stop_pos): Ignore a static
4435 composition starting before CHARPOS (Bug#8915).
4437 * xdisp.c (handle_composition_prop): Likewise.
4439 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4441 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4444 2011-07-07 Kenichi Handa <handa@m17n.org>
4446 * character.h (unicode_category_t): New enum type.
4448 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4449 (Qchar_code_property_table): New variable.
4450 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4451 (UNIPROP_COMPRESSED_FORM_P): New macros.
4452 (char_table_ascii): Uncompress the compressed values.
4453 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4454 Uncompress the compressed values.
4455 (sub_char_table_ref_and_range): Likewise.
4456 (char_table_ref_and_range): Uncompress the compressed values.
4457 (sub_char_table_set): New arg is_uniprop. Callers changed.
4458 Uncompress the compressed values.
4459 (sub_char_table_set_range): Args changed. Callers changed.
4460 (char_table_set_range): Adjuted for the above change.
4461 (map_sub_char_table): Delete args default_val and parent. Add arg
4462 top. Give decoded values to a Lisp function.
4463 (map_char_table): Adjust for the above change. Give decoded
4464 values to a Lisp function. Gcpro more variables.
4465 (uniprop_table_uncompress)
4466 (uniprop_decode_value_run_length): New functions.
4467 (uniprop_decoder, uniprop_decoder_count): New variables.
4468 (uniprop_get_decoder, uniprop_encode_value_character)
4469 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4471 (uniprop_encoder, uniprop_encoder_count): New variables.
4472 (uniprop_get_encoder, uniprop_table)
4473 (Funicode_property_table_internal, Fget_unicode_property_internal)
4474 (Fput_unicode_property_internal): New functions.
4475 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4476 Sunicode_property_table_internal, Sget_unicode_property_internal,
4477 and Sput_unicode_property_internal. Defvar_lisp
4478 char-code-property-alist.
4480 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4481 Vunicode_category_table.
4483 * font.c (font_range): Adjust for the change of
4484 Vunicode_category_table.
4486 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4488 * m/iris4d.h: Remove file, move contents ...
4489 * s/irix6-5.h: ... here.
4491 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4493 Remove unportable assumption about struct layout (Bug#8884).
4494 * alloc.c (mark_buffer):
4495 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4496 (clone_per_buffer_values): Don't assume that
4497 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4498 This isn't true in general, and it's particularly not true
4499 if Emacs is configured with --with-wide-int.
4500 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4501 New macros, used in the buffer.c change.
4503 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4505 * xsettings.c: Use both GConf and GSettings if both are available.
4506 (store_config_changed_event): Add comment.
4507 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4508 (store_tool_bar_style_changed): New functions.
4509 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4510 (struct xsettings): Move font inside HAVE_XFT.
4511 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4512 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4513 Move inside HAVE_XFT.
4514 (something_changed_gsettingsCB): Rename from something_changedCB.
4515 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4517 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4518 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4519 (something_changed_gconfCB): Rename from something_changedCB.
4520 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4521 (parse_settings): Move check for font inside HAVE_XFT.
4522 (read_settings, apply_xft_settings): Add comment.
4523 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4524 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4525 call store_font_name_changed.
4526 (xft_settings_event): Add comment.
4527 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4528 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4529 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4530 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4531 (xsettings_initialize): Call init_gsettings last.
4532 (xsettings_get_system_font, xsettings_get_system_normal_font):
4535 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4537 Random fixes. E.g., (random) never returned negative values.
4538 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4539 subseconds part to the entropy, as that's a bit more random.
4540 Prefer signed to unsigned, since the signedness doesn't matter and
4541 in general we prefer signed. When given a limit, use a
4542 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4543 latter isn't right if USE_2_TAGS_FOR_INTS.
4544 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4545 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4547 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4549 * textprop.c (text_property_stickiness):
4550 Obey Vtext_property_default_nonsticky.
4551 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4552 * w32fns.c (syms_of_w32fns):
4553 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4555 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4557 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4558 This is more efficient than Ffile_directory_p and avoids a minor race.
4560 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4562 * buffer.c (Foverlay_put): Say what the return value is
4565 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4566 is a directory before asking whether to use the file name
4568 (barf_or_query_if_file_exists): Make the "File is a directory"
4569 error be more correct.
4571 * fns.c (Frequire): Remove the mention of the .gz files, since
4572 that's installation-specific, but keep the mention of
4573 `get-load-suffixes'.
4575 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4577 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4578 Report string overflow if the output is too long.
4580 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4582 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4583 (syms_of_gnutls): Remove duplicate DEFSYM for
4584 Qgnutls_bootprop_verify_hostname_error, an error for
4585 Qgnutls_bootprop_verify_error (which is no longer used).
4587 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4588 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4589 Also (re)move comments that are misplaced or no longer relevant.
4591 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4593 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4595 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4597 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4598 and background color parameters if they have been changed.
4600 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4602 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4604 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4606 * xsettings.c (SYSTEM_FONT): Define only when used.
4607 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4609 * keymap.c (access_keymap_1): Now static.
4611 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4613 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4614 leave any prefix arg for the up event (Bug#1586).
4616 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4618 * lread.c (syms_of_lread): Mention single symbols defined by
4619 `defvar' or `defconst' (bug#7154).
4621 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4622 (Frequire): Mention get-load-suffixes.
4624 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4626 * window.h (window): Remove clone_number slot.
4627 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4629 (make_parent_window, make_window, saved_window)
4630 (Fset_window_configuration, save_window_save): Don't deal with
4632 * buffer.c (Qclone_number): Remove declaration.
4633 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4635 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4637 Add multiple inheritance to keymaps.
4638 * keymap.c (Fmake_composed_keymap): New function.
4639 (Fset_keymap_parent): Simplify.
4640 (fix_submap_inheritance): Remove.
4641 (access_keymap_1): New function extracted from access_keymap to handle
4642 embedded parents and handle lists of maps.
4643 (access_keymap): Use it.
4644 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4645 (Fcopy_keymap): Handle embedded parents.
4646 (Fcommand_remapping, define_as_prefix): Simplify.
4647 (Fkey_binding): Simplify.
4648 (syms_of_keymap): Move minibuffer-local-completion-map,
4649 minibuffer-local-filename-completion-map,
4650 minibuffer-local-must-match-map, and
4651 minibuffer-local-filename-must-match-map to Elisp.
4652 (syms_of_keymap): Defsubr make-composed-keymap.
4653 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4654 (parse_menu_item): Trivial simplification.
4656 2011-07-01 Glenn Morris <rgm@gnu.org>
4658 * Makefile.in (SETTINGS_LIBS): Fix typo.
4660 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4662 * coding.c (Fencode_coding_string): Record the last coding system
4663 used, as the function doc string says (bug#8738).
4665 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4667 * xsettings.c (store_monospaced_changed): Take new font as arg and
4668 check for change against current_mono_font.
4669 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4670 (emacs_settings_constructor, emacs_settings_get_property)
4671 (emacs_settings_set_property, emacs_settings_class_init)
4672 (emacs_settings_init, gsettings_obj): Remove.
4673 (something_changedCB): New function for HAVE_GSETTINGS.
4674 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4675 with value as argument.
4676 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4677 g_settings_new (Bug#8967). Do not create gsettings_obj.
4678 Remove calls to g_settings_bind. Connect something_changedCB to
4681 * xgselect.c: Add defined (HAVE_GSETTINGS).
4682 (xgselect_initialize): Ditto.
4684 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4685 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4688 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4690 * eval.c (struct backtrace): Simplify and port the data structure.
4691 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4692 signed bit field, as this assumption is not portable and it makes
4693 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4694 "char debug_on_exit : 1" as this is not portable either; instead,
4695 use the portable "unsigned int debug_on_exit : 1". Remove unused
4696 member evalargs. Remove obsolete comments about cc bombing out.
4698 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4700 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4701 Let HAVE_GSETTINGS override HAVE_GCONF.
4702 (store_monospaced_changed): New function.
4703 (EMACS_SETTINGS): A new type derived from GObject to handle
4704 GSettings notifications.
4705 (emacs_settings_constructor, emacs_settings_get_property)
4706 (emacs_settings_set_property, emacs_settings_class_init):
4708 (gsettings_client, gsettings_obj): New variables.
4709 (GSETTINGS_SCHEMA): New define.
4710 (something_changedCB): Call store_monospaced_changed.
4711 (init_gsettings): New function.
4712 (xsettings_initialize): Call init_gsettings.
4713 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4716 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4719 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4721 * window.c (resize_root_window, grow_mini_window)
4722 (shrink_mini_window): Rename Qresize_root_window to
4723 Qwindow_resize_root_window and Qresize_root_window_vertically to
4724 Qwindow_resize_root_window_vertically.
4726 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4728 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4730 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4732 * makefile.w32-in: Redesign dependencies so they reflect more
4733 clearly which files are directly included by each source file,
4734 and not through other includes.
4736 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4738 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4739 (sort_overlays, overlay_strings): When an overlay's clone number
4740 matches the window's clone number process the overlay even if
4741 the overlay's window property doesn't match the current window.
4743 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4744 (Fwindow_hchild): Rename to Fwindow_left_child.
4745 (Fwindow_next): Rename to Fwindow_next_sibling.
4746 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4747 (resize_window_check): Rename to window_resize_check.
4748 (resize_window_apply): Rename to window_resize_apply.
4749 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4750 (Fdelete_other_windows_internal, resize_frame_windows)
4751 (Fsplit_window_internal, Fdelete_window_internal)
4752 (grow_mini_window, shrink_mini_window)
4753 (Fresize_mini_window_internal): Fix callers accordingly.
4755 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4757 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4758 (emacs_fixed_set_min_size): Remove.
4759 (emacs_fixed_new): Take frame as argument.
4761 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4762 (_EmacsFixedPrivate): Remove minwidth/height.
4763 Add struct frame *f.
4764 (emacs_fixed_init): Initialize priv->f.
4765 (get_parent_class, emacs_fixed_set_min_size): Remove.
4766 (emacs_fixed_new): Set priv->f to argument.
4767 (emacs_fixed_get_preferred_width)
4768 (emacs_fixed_get_preferred_height): Use min_width/height from
4769 frames size_hint to set minimum and natural (Bug#8919).
4770 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4771 and use min_width/height from frames size_hint to set
4772 min_width/height (Bug#8919).
4774 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4775 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4778 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4780 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4781 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4784 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4786 * process.c (wait_reading_process_output): Bypass select if
4787 waiting for a cell while ignoring keyboard input, and input is
4788 pending. Suggested by Jan Djärv (Bug#8869).
4790 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4792 Use gnulib's dup2 module instead of rolling our own.
4793 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4795 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4797 * dispnew.c (scrolling_window): Before scrolling, turn off a
4798 mouse-highlight in the window being scrolled.
4800 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4802 Move DEFSYM to lisp.h and use everywhere.
4804 * character.h (DEFSYM): Move declaration...
4805 * lisp.h (DEFSYM): ...here.
4811 * w32select.c: Don't include character.h.
4813 * alloc.c (syms_of_alloc):
4814 * buffer.c (syms_of_buffer):
4815 * bytecode.c (syms_of_bytecode):
4816 * callint.c (syms_of_callint):
4817 * casefiddle.c (syms_of_casefiddle):
4818 * casetab.c (init_casetab_once):
4819 * category.c (init_category_once, syms_of_category):
4820 * ccl.c (syms_of_ccl):
4821 * cmds.c (syms_of_cmds):
4822 * composite.c (syms_of_composite):
4823 * dbusbind.c (syms_of_dbusbind):
4824 * dired.c (syms_of_dired):
4825 * dispnew.c (syms_of_display):
4826 * doc.c (syms_of_doc):
4827 * editfns.c (syms_of_editfns):
4828 * emacs.c (syms_of_emacs):
4829 * eval.c (syms_of_eval):
4830 * fileio.c (syms_of_fileio):
4831 * fns.c (syms_of_fns):
4832 * frame.c (syms_of_frame):
4833 * fringe.c (syms_of_fringe):
4834 * insdel.c (syms_of_insdel):
4835 * keymap.c (syms_of_keymap):
4836 * lread.c (init_obarray, syms_of_lread):
4837 * macros.c (syms_of_macros):
4838 * msdos.c (syms_of_msdos):
4839 * print.c (syms_of_print):
4840 * process.c (syms_of_process):
4841 * search.c (syms_of_search):
4842 * sound.c (syms_of_sound):
4843 * syntax.c (init_syntax_once, syms_of_syntax):
4844 * terminal.c (syms_of_terminal):
4845 * textprop.c (syms_of_textprop):
4846 * undo.c (syms_of_undo):
4847 * w32.c (globals_of_w32):
4848 * window.c (syms_of_window):
4849 * xdisp.c (syms_of_xdisp):
4850 * xfaces.c (syms_of_xfaces):
4851 * xfns.c (syms_of_xfns):
4852 * xmenu.c (syms_of_xmenu):
4853 * xsettings.c (syms_of_xsettings):
4854 * xterm.c (syms_of_xterm): Use DEFSYM.
4856 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4858 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4860 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4862 Integer and buffer overflow fixes (Bug#8873).
4864 * print.c (printchar, strout): Check for string overflow.
4865 (PRINTPREPARE, printchar, strout):
4866 Don't set size unless allocation succeeds.
4868 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4869 for sizes. Check for string overflow more accurately.
4870 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4872 * macros.c: Integer and buffer overflow fixes.
4873 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4874 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4875 Use ptrdiff_t, not int, for sizes.
4876 Don't increment bufsize until after realloc succeeds.
4877 Check for size-calculation overflow.
4878 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4880 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4882 * lread.c: Integer overflow fixes.
4883 (read_integer): Radix is now EMACS_INT, not int,
4884 to improve quality of diagnostics for out-of-range radices.
4885 Calculate buffer size correctly for out-of-range radices.
4886 (read1): Check for integer overflow in radices, and in
4887 read-circle numbers.
4888 (read_escape): Avoid int overflow.
4889 (Fload, openp, read_buffer_size, read1)
4890 (substitute_object_recurse, read_vector, read_list, map_obarray):
4891 Use ptrdiff_t, not int, for sizes.
4892 (read1): Use EMACS_INT, not int, for sizes.
4893 Check for size overflow.
4895 * image.c (cache_image): Check for size arithmetic overflow.
4897 * lread.c: Integer overflow issues.
4898 (saved_doc_string_size, saved_doc_string_length)
4899 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4900 Now ptrdiff_t, not int.
4901 (read1): Don't assume doc string length fits in int. Check for
4902 out-of-range doc string lengths.
4903 (read_list): Don't assume file position fits in int.
4904 (read_escape): Check for hex character overflow.
4906 2011-06-22 Leo Liu <sdl.web@gmail.com>
4908 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4909 Move to minibuffer.el.
4911 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4913 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4914 The following patches are for when GLYPH_DEBUG && !XASSERT.
4915 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4916 * dispnew.c (flush_stdout):
4917 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4918 Mark as externally visible.
4919 * dispnew.c (check_window_matrix_pointers): Now static.
4920 * dispnew.c (window_to_frame_vpos):
4921 * xfns.c (unwind_create_frame):
4922 * xterm.c (x_check_font): Remove unused local.
4923 * scroll.c (CHECK_BOUNDS):
4924 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4925 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4926 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4927 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4928 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4930 (debug_method_add): Use va_list and vsprintf rather than relying
4931 on undefined behavior with wrong number of arguments.
4932 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4933 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4934 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4935 since we're not interested in debugging glyphs with old libraries.
4936 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4937 GCC 4.6.0's static checking.
4939 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4941 Integer overflow and signedness fixes (Bug#8873).
4942 A few related buffer overrun fixes, too.
4944 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4946 * dispextern.h (struct face.stipple):
4947 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4948 (x_bitmap_mask, x_allocate_bitmap_record)
4949 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4950 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4951 (x_create_bitmap_from_xpm_data):
4952 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4953 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4955 * xfaces.c (load_pixmap):
4956 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4957 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4958 (.bitmaps_last, struct x_output.icon_bitmap):
4959 Use ptrdiff_t, not int, for bitmap indexes.
4960 (x_allocate_bitmap_record): Check for size overflow.
4961 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4963 Use ptrdiff_t, not int, for overlay counts.
4964 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4965 * editfns.c (overlays_around, get_pos_property):
4966 * textprop.c (get_char_property_and_overlay):
4967 * xdisp.c (next_overlay_change, note_mouse_highlight):
4968 * xfaces.c (face_at_buffer_position):
4969 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4970 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4971 (Fnext_overlay_change, Fprevious_overlay_change)
4972 (mouse_face_overlay_overlaps, Foverlays_in):
4973 Use ptrdiff_t, not int, for sizes.
4974 (overlays_at, overlays_in): Check for size-calculation overflow.
4976 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4978 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4979 (x_session_initialize): Do not assume string length fits in int.
4981 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4982 This is unlikely, but can occur if DPI is outlandish.
4984 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
4985 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4987 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4988 * xrdb.c (magic_file_p, search_magic_path):
4989 Omit last arg SUFFIX; it was always 0. All callers changed.
4990 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4992 * xfont.c (xfont_match): Avoid need for strlen.
4994 * xfns.c: Don't assume strlen fits in int.
4995 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4997 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4998 not unsigned long, as we prefer signed integers. All callers changed.
4999 Detect integer overflow in repeat count.
5000 (message_dolog): Don't assume print length fits in 39 bytes.
5001 (display_mode_element): Don't assume strlen fits in int.
5003 * termcap.c: Don't assume sizes fit in int and never overflow.
5004 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
5005 (gobble_line): Check for size-calculation overflow.
5007 * minibuf.c (Fread_buffer):
5008 * lread.c (intern, intern_c_string):
5009 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
5010 Don't assume string length fits in int.
5012 * keyboard.c (parse_tool_bar_item):
5013 * gtkutil.c (style_changed_cb): Avoid need for strlen.
5015 * font.c: Don't assume string length fits in int.
5016 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
5017 Use ptrdiff_t, not int.
5018 (font_intern_prop): Don't assume string length fits in int.
5019 Don't assume integer property fits in fixnum.
5020 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
5022 * filelock.c: Fix some buffer overrun and integer overflow issues.
5023 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
5024 Reformulate so as not to need the command string.
5025 Invoke gzip -cd rather than gunzip, as it's more portable.
5026 (lock_info_type, lock_file_1, lock_file):
5027 Don't assume pid_t and time_t fit in unsigned long.
5028 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
5029 (current_lock_owner): Prefer signed type for sizes.
5030 Use memcpy, not strncpy, where memcpy is what is really wanted.
5031 Don't assume (via atoi) that time_t and pid_t fit in int.
5032 Check for time_t and/or pid_t out of range, e.g., via a network share.
5033 Don't alloca where an auto var works fine.
5035 * fileio.c: Fix some integer overflow issues.
5036 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
5037 Don't assume string length fits in int.
5038 (directory_file_name): Don't assume string length fits in long.
5039 (make_temp_name): Don't assume pid fits in int, or that its print
5040 length is less than 20.
5042 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
5044 * coding.c (make_subsidiaries): Don't assume string length fits in int.
5046 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
5048 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
5049 We prefer signed integers, even for size calculations.
5051 * emacs.c: Don't assume string length fits in 'int'.
5052 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
5053 (main): Don't invoke strlen when not needed.
5055 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
5056 (XD_DEBUG_MESSAGE): Don't waste a byte.
5058 * callproc.c (getenv_internal_1, getenv_internal)
5060 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
5062 * lread.c (invalid_syntax): Omit length argument.
5063 All uses changed. This doesn't fix a bug, but it simplifies the
5064 code away from its former Hollerith-constant appearance, and it's
5065 one less 'int' to worry about when looking at integer-overflow issues.
5066 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
5068 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
5069 This didn't break anything, but it didn't help either.
5070 It's confusing to put a bogus integer in a place where the actual
5071 value does not matter.
5072 (LIST_END_P): Remove unused macro and its bogus comment.
5073 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
5075 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
5076 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5078 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5079 We prefer signed types, and the value cannot exceed the EMACS_INT
5080 range anyway (because otherwise the length would not be representable).
5081 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5082 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5083 This avoids a GCC warning when WIDE_EMACS_INT.
5085 * indent.c (sane_tab_width): New function.
5086 (current_column, scan_for_column, Findent_to, position_indentation)
5087 (compute_motion): Use it. This is just for clarity.
5088 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
5090 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
5092 * lisp.h (lint_assume): New macro.
5093 * composite.c (composition_gstring_put_cache):
5094 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5096 * editfns.c, insdel.c:
5097 Omit unnecessary forward decls, to simplify future changes.
5099 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5101 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5103 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
5104 Use much-faster test for byte-length change.
5105 Don't assume string byte-length fits in 'int'.
5106 Check that character arg fits in 'int'.
5107 (mapcar1): Declare byte as byte, for clarity.
5109 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5111 * fns.c (concat): Catch string overflow earlier.
5112 Do not rely on integer wraparound.
5114 * dispextern.h (struct it.overlay_strings_charpos)
5115 (struct it.selective): Now EMACS_INT, not int.
5116 * xdisp.c (forward_to_next_line_start)
5117 (back_to_previous_visible_line_start)
5118 (reseat_at_next_visible_line_start, next_element_from_buffer):
5119 Don't arbitrarily truncate the value of 'selective' to int.
5121 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5123 * composite.c: Don't truncate sizes to 'int'.
5124 (composition_gstring_p, composition_reseat_it)
5125 (composition_adjust_point): Use EMACS_INT, not int.
5126 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5127 not EMACS_UINT, for indexes.
5129 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5131 * buffer.c: Include <verify.h>.
5132 (struct sortvec.priority, struct sortstr.priority):
5133 Now EMACS_INT, not int.
5134 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
5135 (struct sortstr.size, record_overlay_string)
5136 (struct sortstrlist.size, struct sortlist.used):
5137 Don't truncate size to int.
5138 (record_overlay_string): Check for size-calculation overflow.
5139 (init_buffer_once): Check at compile-time, not run-time.
5141 2011-06-22 Jim Meyering <meyering@redhat.com>
5143 Don't leak an XBM-image-sized buffer
5144 * image.c (xbm_load): Free the image buffer after using it.
5146 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5149 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5150 that Sun C diagnosed.
5151 * fns.c (secure_hash): Fix pointer signedness issue.
5152 * intervals.c (static_offset_intervals): New function.
5153 (offset_intervals): Use it.
5155 2011-06-21 Leo Liu <sdl.web@gmail.com>
5158 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5161 * fns.c (secure_hash): Rename from crypto_hash_function and change
5162 the first arg to accept symbols.
5163 (Fsecure_hash): New primitive.
5164 (syms_of_fns): New symbols.
5166 2011-06-20 Deniz Dogan <deniz@dogan.se>
5168 * process.c (Fset_process_buffer): Clarify return value in
5171 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
5173 * dispnew.c (add_window_display_history): Use BVAR.
5175 * xdisp.c (debug_method_add): Use BVAR.
5176 (check_window_end, dump_glyph_matrix, dump_glyph)
5177 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5179 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5182 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5183 check till after the cache is created in init_frame_faces.
5185 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5187 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5189 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5191 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5192 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5193 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5195 Improve buffer-overflow checking (Bug#8873).
5196 * fileio.c (Finsert_file_contents):
5197 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5198 Remove the old (too-loose) buffer overflow checks.
5199 They weren't needed, since make_gap checks for buffer overflow.
5200 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5201 The old code merely checked for Emacs fixnum overflow, and relied
5202 on undefined (wraparound) behavior. The new code avoids undefined
5203 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5205 * editfns.c (Finsert_char): Don't dump core with very negative counts.
5206 Tune. Don't use wider integers than needed. Don't use alloca.
5207 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
5209 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5211 * insdel.c, lisp.h (buffer_overflow): New function.
5212 (insert_from_buffer_1, replace_range, replace_range_2):
5213 * insdel.c (make_gap_larger):
5214 * editfns.c (Finsert_char):
5215 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5217 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5219 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5221 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
5223 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5224 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5226 * fileio.c: Don't assume EMACS_INT fits in off_t.
5227 (emacs_lseek): New static function.
5228 (Finsert_file_contents, Fwrite_region): Use it.
5229 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5231 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5233 * fns.c: Don't overflow int when computing a list length.
5234 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5235 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5236 truncation on 64-bit hosts. Check for QUIT every
5237 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5238 faster and is responsive enough.
5239 (Flength): Report an error instead of overflowing an integer.
5240 (Fsafe_length): Return a float if the value is not representable
5241 as a fixnum. This shouldn't happen except in contrived situations.
5242 (Fnthcdr, Fsort): Don't assume list length fits in int.
5243 (Fcopy_sequence): Don't assume vector length fits in int.
5245 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5246 (header_size, word_size): New constants.
5247 (allocate_vectorlike): Don't check size overflow here.
5248 (allocate_vector): Check it here instead, since this is the only
5249 caller of allocate_vectorlike that could cause overflow.
5250 Check that the new vector's length is representable as a fixnum.
5252 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5253 The previous code was bogus. For example, next_almost_prime (32)
5254 returned 39, which is undesirable as it is a multiple of 3; and
5255 next_almost_prime (24) returned 25, which is a multiple of 5 so
5256 why was the code bothering to check for multiples of 7?
5258 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5260 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5262 Variadic C functions now count arguments with ptrdiff_t.
5263 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5264 Back then I didn't know that the Emacs coding style prefers signed int.
5265 Also, in the meantime I found a few more instances where arguments
5266 were being counted with int, which may truncate counts on 64-bit
5267 machines, or EMACS_INT, which may be unnecessarily wide.
5268 * lisp.h (struct Lisp_Subr.function.aMANY)
5269 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5270 Arg counts are now ptrdiff_t, not size_t.
5271 All variadic functions and their callers changed accordingly.
5272 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5273 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5274 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5275 * callint.c (Fcall_interactively): Check arg count for overflow,
5276 to avoid potential buffer overrun. Use signed char, not 'int',
5277 for 'varies' array, so that we needn't bother to check its size
5278 calculation for overflow.
5279 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5280 * eval.c (apply_lambda):
5281 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5282 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5283 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5285 * callint.c (Fcall_interactively): Don't use index var as event count.
5287 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5288 * mem-limits.h (SIZE): Remove; no longer used.
5290 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5292 Remove unnecessary casts.
5293 * xterm.c (x_term_init):
5294 * xfns.c (x_set_border_pixel):
5295 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5296 These aren't needed now that we assume ANSI C.
5298 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5299 It's more likely to cause problems (due to unsigned overflow)
5302 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5304 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5306 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5308 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5310 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5312 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5314 GLYPH_CODE_FACE returns EMACS_INT, not int.
5315 * dispextern.h (merge_faces):
5316 * xfaces.c (merge_faces):
5317 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5318 Don't assume EMACS_INT fits in int.
5320 * character.h (CHAR_VALID_P): Remove unused parameter.
5321 * fontset.c, lisp.h, xdisp.c: All uses changed.
5323 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5325 * fns.c (concat): Minor tuning based on overflow analysis.
5326 This doesn't fix any bugs. Use int to hold character, instead
5327 of constantly refetching from Emacs object. Use XFASTINT, not
5328 XINT, for value known to be a character. Don't bother comparing
5329 a single byte to 0400, as it's always less.
5331 * floatfns.c (Fexpt):
5332 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5334 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5337 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5339 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5340 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5341 incorrectly succeed when S was a string, because 4294967386 was
5342 truncated before it was used.
5344 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5345 Otherwise, an out-of-range integer could cause undefined behavior
5348 * composite.c: Use int, not EMACS_INT, for characters.
5349 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5350 EMACS_INT, for values that are known to be in character range.
5351 This doesn't fix any bugs but is the usual style inside Emacs and
5352 may generate better code on 32-bit machines.
5354 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5355 This is for reasons similar to the recent CHAR_STRING fix.
5356 * charset.c (Fencode_char): Check that character arg is actually
5357 a character. Pass an int to ENCODE_CHAR.
5358 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5359 wider than 'int', as a compile-time check to prevent future regressions
5362 * character.c (char_string): Remove unnecessary casts.
5364 Make sure a 64-bit char is never passed to CHAR_STRING.
5365 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5366 by silently ignoring the top 32 bits, allowing some values
5367 that were far too large to be valid characters.
5368 * character.h: Include <verify.h>.
5369 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5370 arguments are no wider than unsigned, as a compile-time check
5371 to prevent future regressions in this area.
5373 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
5374 (Fsubst_char_in_region):
5376 * xdisp.c (decode_mode_spec_coding):
5377 Adjust to CHAR_STRING's new requirement.
5378 * editfns.c (Finsert_char, Fsubst_char_in_region):
5379 * fns.c (concat): Check that character args are actually
5380 characters. Without this test, these functions did the wrong
5381 thing with wildly out-of-range values on 64-bit hosts.
5383 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5384 These casts should not be needed on 32-bit hosts, either.
5385 * keyboard.c (read_char):
5386 * lread.c (Fload): Remove casts to unsigned.
5388 * lisp.h (UNSIGNED_CMP): New macro.
5389 This fixes comparison bugs on 64-bit hosts.
5390 (ASCII_CHAR_P): Use it.
5391 * casefiddle.c (casify_object):
5392 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5393 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5394 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5395 * dispextern.h (FACE_FROM_ID):
5396 * keyboard.c (read_char): Use UNSIGNED_CMP.
5398 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5399 not to EMACS_INT, to avoid GCC warning.
5401 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5403 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5404 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5405 isn't needed on 32-bit machines.
5407 * buffer.c (Fgenerate_new_buffer_name):
5408 Use EMACS_INT for count, not int.
5409 (advance_to_char_boundary): Return EMACS_INT, not int.
5411 * data.c (Qcompiled_function): Now static.
5413 * window.c (window_body_lines): Now static.
5415 * image.c (gif_load): Rename local to avoid shadowing.
5417 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5418 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5419 * alloc.c (make_save_value): Integer argument is now of type
5421 (mark_object): Use ptrdiff_t, not int.
5422 * lisp.h (pD): New macro.
5423 * print.c (print_object): Use it.
5425 * alloc.c: Use EMACS_INT, not int, to count objects.
5426 (total_conses, total_markers, total_symbols, total_vector_size)
5427 (total_free_conses, total_free_markers, total_free_symbols)
5428 (total_free_floats, total_floats, total_free_intervals)
5429 (total_intervals, total_strings, total_free_strings):
5430 Now EMACS_INT, not int. All uses changed.
5431 (Fgarbage_collect): Compute overall total using a double, so that
5432 integer overflow is less likely to be a problem. Check for overflow
5433 when converting back to an integer.
5434 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5435 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5436 These were 'int' variables that could overflow on 64-bit hosts;
5437 they were never used, so remove them instead of repairing them.
5438 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5439 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5440 Previously, this ceilinged at INT_MAX, but that doesn't work on
5442 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5444 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5445 (allocate_vectorlike): Check for ptrdiff_t overflow.
5446 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5447 when a (possibly-narrower) signed value would do just as well.
5448 We prefer using signed arithmetic, to avoid comparison confusion.
5450 * alloc.c: Catch some string size overflows that we were missing.
5451 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5452 for convenience in STRING_BYTES_MAX.
5453 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5454 The definition here is exact; the one in lisp.h was approximate.
5455 (allocate_string_data): Check for string overflow. This catches
5456 some instances we weren't catching before. Also, it catches
5457 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5458 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5459 and ptrdiff_t and EMACS_INT are both 64 bits.
5461 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5462 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5463 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5465 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5467 * alloc.c (Fmake_string): Check for out-of-range init.
5469 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5471 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5473 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5475 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5476 xg_get_default_scrollbar_width.
5478 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5479 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5480 (style_changed_cb): Call update_theme_scrollbar_width and call
5481 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5482 all frames (Bug#8505).
5483 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5484 Call gtk_window_set_resizable if HAVE_GTK3.
5485 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5486 and height if HAVE_GTK3 (Bug#8505).
5487 (scroll_bar_width_for_theme): New variable.
5488 (update_theme_scrollbar_width): New function.
5489 (xg_get_default_scrollbar_width): Move code to
5490 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5491 (xg_initialize): Call update_theme_scrollbar_width.
5493 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5495 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5497 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5499 * frame.c (make_frame): Call other_buffer_safely instead of
5502 * window.c (temp_output_buffer_show): Call display_buffer with
5503 second argument Vtemp_buffer_show_specifiers and reset latter
5504 immediately after the call.
5505 (Vtemp_buffer_show_specifiers): New variable.
5506 (auto_window_vscroll_p, next_screen_context_lines)
5507 (Vscroll_preserve_screen_position): Remove leading asterisks from
5510 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5512 Fix minor problems found by GCC 4.6.0 static checking.
5513 * buffer.c (Qclone_number): Remove for now, as it's unused.
5514 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5515 (record_buffer): Remove unused local.
5516 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5517 (set_frame_buffer_list): Remove; unused.
5518 * frame.h (other_visible_frames): Remove decl.
5519 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5520 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5521 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5523 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5524 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5525 Define only if HAVE_GPM.
5526 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5527 (update_hints_inhibit): Remove; never set. All uses removed.
5528 * widgetprv.h (emacsFrameClassRec): Remove decl.
5529 * window.c (delete_deletable_window): Now returns void, since it
5530 wasn't returning anything.
5531 (compare_window_configurations): Remove unused locals.
5532 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5533 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5534 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5535 the same widths as pointers. This follows up on the 2011-05-06 patch.
5536 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5537 * xterm.h: Likewise.
5538 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5540 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5542 * makefile.w32-in: Update dependencies.
5543 (LISP_H): Add lib/intprops.h.
5545 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5547 * image.c (gif_load): Add animation frame delay to the metadata.
5548 (syms_of_image): Use DEFSYM. New symbol `delay'.
5550 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5552 * window.c (delete_deletable_window): Re-add.
5553 (Fset_window_configuration): Rewrite to handle dead buffers and
5554 consequently deletable windows.
5555 (window_tree, Fwindow_tree): Remove. Supply functionality in
5557 (compare_window_configurations): Simplify code.
5559 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5561 * image.c (imagemagick_load_image): Fix type mismatch.
5562 (Fimagemagick_types): Likewise.
5564 * window.h (replace_buffer_in_windows): Declare.
5566 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5568 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5569 Qclone_number. Remove external declaration of Qdelete_window.
5570 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5572 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5573 Run Qbuffer_list_update_hook if allowed.
5574 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5575 buffer list implementation.
5576 (other_buffer_safely): New function.
5577 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5578 calls to replace_buffer_in_windows and
5579 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5581 (record_buffer): Inhibit quitting and rewrite using quittable
5582 functions. Run Qbuffer_list_update_hook if allowed.
5583 (Frecord_buffer, Funrecord_buffer): New functions.
5584 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5585 Move switch-to-buffer to window.el.
5586 (bury-buffer): Move to window.el.
5587 (Vbuffer_list_update_hook): New variable.
5589 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5592 * window.h (resize_frame_windows): Move up in code.
5593 (Fwindow_frame): Remove EXFUN.
5594 (replace_buffer_in_all_windows): Remove prototype.
5595 (replace_buffer_in_windows_safely): Add prototype.
5597 * window.c: Declare Qdelete_window static again. Move down
5598 declaration of select_count.
5599 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5600 (Fother_window): Move to window.el.
5601 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5602 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5603 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5605 (replace_buffer_in_windows): Implement by calling
5606 Qreplace_buffer_in_windows.
5607 (replace_buffer_in_all_windows): Remove with some functionality
5608 moved into replace_buffer_in_windows_safely.
5609 (replace_buffer_in_windows_safely): New function.
5610 (select_window_norecord, select_frame_norecord): Move in front
5611 of run_window_configuration_change_hook. Remove now obsolete
5613 (Fset_window_buffer): Rewrite doc-string.
5614 Call Qrecord_window_buffer.
5615 (keys_of_window): Move binding for other-window to window.el.
5617 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5619 * dispextern.h (struct image): Replace data member, whose int_val
5620 and ptr_val fields were not used by anything, with a single
5623 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5624 (gif_clear_image, gif_load, imagemagick_load_image)
5625 (gs_clear_image, gs_load): Callers changed.
5627 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5629 * buffer.h: Include <time.h>, for time_t.
5630 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5632 Fix minor problems found by static checking.
5634 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5636 Make identifiers static if they are not used in other modules.
5637 * data.c (Qcompiled_function, Qframe, Qvector):
5638 * image.c (QimageMagick, Qsvg):
5639 * minibuf.c (Qmetadata):
5640 * window.c (resize_window_check, resize_root_window): Now static.
5641 * window.h (resize_window_check, resize_root_window): Remove decls.
5643 * window.c (window_deletion_count, delete_deletable_window):
5645 (window_body_lines): Now static.
5646 (Fdelete_other_windows_internal): Mark vars as initialized.
5647 Make sure 'resize_failed' is initialized.
5648 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5649 (resize_window_apply): Remove unused local.
5650 * window.h (delete_deletable_window): Remove decl.
5652 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5653 (imagemagick_load_image): Fix pointer signedness problem by changing
5654 last arg from unsigned char * to char *. All uses changed.
5655 Also, fix a local for similar reasons.
5656 Remove unused locals. Remove locals to avoid shadowing.
5657 (fn_rsvg_handle_free): Remove; unused.
5658 (svg_load, svg_load_image): Fix pointer signedness problem.
5659 (imagemagick_load_image): Don't use garbage pointer image_wand.
5661 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5663 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5665 * image.c (gif_load): Fix omitted cast error introduced by
5668 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5670 * window.h (resize_proportionally, orig_total_lines)
5671 (orig_top_line): Remove from window structure.
5672 (set_window_height, set_window_width, change_window_heights)
5673 (Fdelete_window): Remove prototypes.
5674 (resize_frame_windows): Remove duplicate declaration.
5676 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5678 * window.h (resize_frame_windows, resize_window_check)
5679 (delete_deletable_window, resize_root_window)
5680 (resize_frame_windows): Declare prototypes.
5682 * window.c (resize_window_apply): Make definition be "static" to
5683 match the prototype.
5685 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5687 * window.c: Remove declarations of Qwindow_size_fixed,
5688 window_min_size_1, window_min_size_2, window_min_size,
5689 size_window, window_fixed_size_p, enlarge_window, delete_window.
5690 Remove static from declaration of Qdelete_window, it's
5691 temporarily needed by Fbury_buffer.
5692 (replace_window): Don't assign orig_top_line and
5694 (Fdelete_window, delete_window): Remove. Window deletion is
5695 handled by window.el.
5696 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5697 Replace Fdelete_window calls with calls to Qdelete_window.
5698 (Fdelete_other_windows): Remove. Deleting other windows is
5699 handled by window.el.
5700 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5701 handled in window.el.
5702 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5703 Window minimum sizes are handled in window.el.
5704 (shrink_windows, size_window, set_window_height)
5705 (set_window_width, change_window_heights, window_height)
5706 (window_width, CURBEG, CURSIZE, enlarge_window)
5707 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5708 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5709 handled in window.el.
5710 (make_dummy_parent): Rename to make_parent_window and give it a
5711 second argument horflag.
5712 (make_window): Don't set resize_proportionally any more.
5713 (Fsplit_window): Remove. Windows are split in window.el.
5714 (save_restore_action, save_restore_orig_size)
5715 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5716 Resize mini windows in window.el.
5717 (grow_mini_window, shrink_mini_window): Implement by calling
5718 Qresize_root_window_vertically, resize_window_check and
5719 resize_window_apply.
5720 (saved_window, Fset_window_configuration, save_window_save):
5721 Do not handle orig_top_line, orig_total_lines, and
5722 resize_proportionally.
5723 (window_min_height, window_min_width): Move to window.el.
5724 (keys_of_window): Move bindings for delete-other-windows,
5725 split-window, delete-window and enlarge-window to window.el.
5727 * buffer.c: Temporarily extern Qdelete_window.
5728 (Fbury_buffer): Temporarily call Qdelete_window instead of
5729 Fdelete_window (Fbury_buffer will move to window.el soon).
5731 * frame.c (set_menu_bar_lines_1): Remove code handling
5732 orig_top_line and orig_total_lines.
5734 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5735 set_window_height but set heights directly.
5736 (change_frame_size_1): Use resize_frame_windows.
5738 * xdisp.c (init_xdisp): Don't use set_window_height but set
5741 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5742 Use resize_frame_windows instead of change_window_heights and run
5743 run_window_configuration_change_hook.
5745 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5746 instead of change_window_heights and run
5747 run_window_configuration_change_hook.
5749 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5751 * window.c (replace_window): Rename second argument REPLACEMENT to
5752 NEW. New third argument SETFLAG. Rewrite.
5753 (delete_window, make_dummy_parent): Call replace_window with
5755 (window_list_1): Move down in code.
5756 (run_window_configuration_change_hook): Move set_buffer part
5757 before select_frame_norecord part in order to unwind correctly.
5758 Rename count1 to count.
5759 (recombine_windows, delete_deletable_window, resize_root_window)
5760 (Fdelete_other_windows_internal)
5761 (Frun_window_configuration_change_hook, make_parent_window)
5762 (resize_window_check, resize_window_apply, Fresize_window_apply)
5763 (resize_frame_windows, Fsplit_window_internal)
5764 (Fdelete_window_internal, Fresize_mini_window_internal):
5766 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5768 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5770 * window.h (window): Add some new members to window structure -
5771 normal_lines, normal_cols, new_total, new_normal, clone_number,
5772 splits, nest, prev_buffers, next_buffers.
5773 (WINDOW_TOTAL_SIZE): Move here from window.c.
5774 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5776 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5778 (make_dummy_parent): Set new members of windows structure.
5779 (make_window): Move down in code. Handle new members of window
5781 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5782 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5783 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5784 (Fset_window_prev_buffers, Fwindow_next_buffers)
5785 (Fset_window_next_buffers, Fset_window_clone_number):
5787 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5788 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5790 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5791 Argument WINDOW can be now internal window too.
5792 (Fwindow_use_time): Move up in code.
5793 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5795 (Fset_window_configuration, saved_window)
5796 (Fcurrent_window_configuration, save_window_save): Handle new
5797 members of window structure.
5798 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5799 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5800 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5801 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5802 Qget_mru_window, Qresize_root_window,
5803 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5804 Qauto_buffer_name; staticpro them.
5806 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5808 * window.c (Fwindow_total_size, Fwindow_left_column)
5809 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5810 (Fwindow_list_1): New functions.
5811 (window_box_text_cols): Replace with window_body_cols.
5812 (Fwindow_width, Fscroll_left, Fscroll_right):
5813 Use window_body_cols instead of window_box_text_cols.
5814 (delete_window, Fset_window_configuration):
5815 Call delete_all_subwindows with window as argument.
5816 (delete_all_subwindows): Take a window as argument and not a
5818 (window_loop): Remove handling of GET_LRU_WINDOW and
5820 (Fget_lru_window, Fget_largest_window): Move to window.el.
5822 * window.h: Extern window_body_cols instead of
5823 window_box_text_cols. delete_all_subwindows now takes a
5824 Lisp_Object as argument.
5826 * indent.c (compute_motion, Fcompute_motion):
5827 Use window_body_cols instead of window_box_text_cols.
5829 * frame.c (delete_frame): Call delete_all_subwindows with root
5832 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5834 * fns.c (Fputhash): Document return value.
5836 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5838 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5840 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5842 Cons<->int and similar integer overflow fixes (Bug#8794).
5844 Check for overflow when converting integer to cons and back.
5845 * charset.c (Fdefine_charset_internal, Fdecode_char):
5846 Use cons_to_unsigned to catch overflow.
5847 (Fencode_char): Use INTEGER_TO_CONS.
5848 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5849 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5850 * data.c (long_to_cons, cons_to_long): Remove.
5851 (cons_to_unsigned, cons_to_signed): New functions.
5852 These signal an error for invalid or out-of-range values.
5853 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5854 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5855 * font.c (Ffont_variation_glyphs):
5856 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5857 * lisp.h: Include <intprops.h>.
5858 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5859 (cons_to_signed, cons_to_unsigned): New decls.
5860 (long_to_cons, cons_to_long): Remove decls.
5861 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5862 (Fprimitive_undo): Use CONS_TO_INTEGER.
5863 * xfns.c (Fx_window_property): Likewise.
5864 * xselect.c: Include <limits.h>.
5865 (x_own_selection, selection_data_to_lisp_data):
5866 Use INTEGER_TO_CONS.
5867 (x_handle_selection_request, x_handle_selection_clear)
5868 (x_get_foreign_selection, Fx_disown_selection_internal)
5869 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5870 (lisp_data_to_selection_data): Use cons_to_unsigned.
5871 (x_fill_property_data): Use cons_to_signed.
5872 Report values out of range.
5874 Check for buffer and string overflow more precisely.
5875 * buffer.h (BUF_BYTES_MAX): New macro.
5876 * lisp.h (STRING_BYTES_MAX): New macro.
5877 * alloc.c (Fmake_string):
5878 * character.c (string_escape_byte8):
5879 * coding.c (coding_alloc_by_realloc):
5880 * doprnt.c (doprnt):
5881 * editfns.c (Fformat):
5883 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5884 since they may not be the same number.
5885 * editfns.c (Finsert_char):
5886 * fileio.c (Finsert_file_contents):
5887 Likewise for BUF_BYTES_MAX.
5889 * image.c: Use ptrdiff_t, not int, for sizes.
5890 (slurp_file): Switch from int to ptrdiff_t.
5892 (slurp_file): Check that file size fits in both size_t (for
5893 malloc) and ptrdiff_t (for sanity and safety).
5895 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5896 if b->modtime has its maximal value.
5898 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5900 Don't assume time_t can fit into int.
5901 * buffer.h (struct buffer.modtime): Now time_t, not int.
5902 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5903 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5905 Minor fixes for signed vs unsigned integers.
5906 * character.h (MAYBE_UNIFY_CHAR):
5907 * charset.c (maybe_unify_char):
5908 * keyboard.c (read_char, reorder_modifiers):
5909 XINT -> XFASTINT, since the integer must be nonnegative.
5910 * ftfont.c (ftfont_spec_pattern):
5911 * keymap.c (access_keymap, silly_event_symbol_error):
5912 XUINT -> XFASTINT, since the integer must be nonnegative.
5913 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5914 since it makes no difference and we prefer signed.
5915 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5916 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5919 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5921 * window.h (Fwindow_frame): Declare.
5923 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5925 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5926 (SPARE_MEMORY): Always define.
5927 (LARGE_REQUEST): Remove.
5928 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5930 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5932 * lisp.h: Move EXFUNS for Fframe_root_window,
5933 Fframe_first_window and Fset_frame_selected_window to window.h.
5935 * window.h: Move EXFUNS for Fframe_root_window,
5936 Fframe_first_window and Fset_frame_selected_window here from
5939 * frame.c (Fwindow_frame, Fframe_first_window)
5940 (Fframe_root_window, Fframe_selected_window)
5941 (Fset_frame_selected_window): Move to window.c.
5942 (Factive_minibuffer_window): Move to minibuf.c.
5943 (Fother_visible_frames_p): New function.
5945 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5947 * window.c (decode_window, decode_any_window): Move up in code.
5948 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5949 (inhibit_frame_unsplittable): Remove unused variable.
5950 (Fwindow_buffer): Move up and rewrite doc-string.
5951 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5952 (Fwindow_prev): New functions.
5953 (Fwindow_frame): Move here from frame.c. Accept any window as
5955 (Fframe_root_window, Fframe_first_window)
5956 (Fframe_selected_window): Move here from frame.c. Accept frame
5957 or arbitrary window as argument. Update doc-strings.
5958 (Fminibuffer_window): Move up in code.
5959 (Fwindow_minibuffer_p): Move up in code and simplify.
5960 (Fset_frame_selected_window): Move here from frame.c.
5962 (Fselected_window, select_window, Fselect_window): Move up in
5963 code. Minor doc-string fixes.
5965 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5967 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5968 Do not assume that spare memory exists; that assumption is valid
5969 only if SYSTEM_MALLOC.
5970 (LARGE_REQUEST): New macro, so that the issue of large requests
5971 is separated from the issue of spare memory.
5973 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5975 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5978 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5980 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5983 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5985 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5987 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5989 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5990 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5992 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5994 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5996 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
5998 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5999 (x_clipboard_manager_save): Add return value.
6000 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
6002 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
6003 Obey Vx_select_enable_clipboard_manager. Catch errors in
6004 x_clipboard_manager_save (Bug#8779).
6005 (Vx_select_enable_clipboard_manager): New variable.
6006 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
6008 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
6010 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
6012 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6014 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
6015 in the current matrix if keep_current_p is non-zero.
6017 2011-06-04 Eli Zaretskii <eliz@gnu.org>
6019 * bidi.c (bidi_level_of_next_char): Fix last change.
6021 2011-06-03 Eli Zaretskii <eliz@gnu.org>
6023 Support bidi reordering of text covered by display properties.
6025 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
6026 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
6027 (bidi_cache_search, bidi_cache_iterator_state)
6028 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
6029 (bidi_level_of_next_char, bidi_move_to_visually_next):
6030 Support character positions inside a run of characters covered by a
6032 (bidi_paragraph_init, bidi_resolve_explicit_1)
6033 (bidi_level_of_next_char): Call bidi_fetch_char and
6034 bidi_fetch_char_advance instead of FETCH_CHAR and
6036 (bidi_init_it): Initialize new members.
6037 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
6039 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
6040 instead of using explicit *_CHAR codes.
6041 (bidi_resolve_explicit, bidi_resolve_weak):
6042 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
6043 bidirectional text is supported only in multibyte buffers.
6044 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
6045 it to initialize the frame_window_p member of struct bidi_it.
6046 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
6047 (bidi_resolve_explicit, bidi_resolve_weak)
6048 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
6049 bidi_it->nchars is non-positive.
6050 (bidi_level_of_next_char): Don't try to lookup the cache for the
6051 next/previous character if nothing is cached there yet, or if we
6052 were just reseat()'ed to a new position.
6054 * xdisp.c (set_cursor_from_row): Set start and stop points
6055 according to the row's direction when priming the loop that looks
6056 for the glyph on which to display cursor.
6057 (single_display_spec_intangible_p): Function deleted.
6058 (display_prop_intangible_p): Reimplement to call
6059 handle_display_spec instead of single_display_spec_intangible_p.
6060 Accept 3 additional arguments needed by handle_display_spec.
6061 This fixes incorrect cursor motion across display property with complex
6062 values: lists, `(when COND...)' forms, etc.
6063 (single_display_spec_string_p): Support property values that are
6064 lists with the argument STRING its top-level element.
6065 (display_prop_string_p): Fix the condition for processing a
6066 property that is a list to be consistent with handle_display_spec.
6067 (handle_display_spec): New function, refactored from the
6068 last portion of handle_display_prop.
6069 (compute_display_string_pos): Accept additional argument
6070 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
6071 value of a `display' property is a "replacing spec".
6072 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
6073 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
6074 the display property, but just return a value indicating whether
6075 the display property will replace the characters it covers.
6076 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
6077 frame_window_p members of struct bidi_it.
6078 (compute_display_string_pos, compute_display_string_end):
6080 (push_it): Accept second argument POSITION, where pop_it should
6081 jump to continue iteration.
6082 (reseat_1): Initialize bidi_it.disp_pos.
6084 * keyboard.c (adjust_point_for_property): Adjust the call to
6085 display_prop_intangible_p to its new signature.
6087 * dispextern.h (struct bidi_it): New member frame_window_p.
6088 (bidi_init_it): Update prototypes.
6089 (display_prop_intangible_p): Update prototype.
6090 (compute_display_string_pos, compute_display_string_end):
6092 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6095 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
6097 Malloc failure behavior now depends on size of allocation.
6098 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6099 * lisp.h: Change signatures accordingly.
6100 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6101 All callers changed. (Bug#8762)
6103 * gnutls.c: Use Emacs's memory allocators.
6104 Without this change, the gnutls library would invoke malloc etc.
6105 directly, which causes problems on non-SYNC_INPUT hosts, and which
6106 runs afoul of improving memory_full behavior. (Bug#8761)
6107 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6108 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6109 xfree instead of the default malloc, realloc, free.
6110 (Fgnutls_boot): No need to check for memory allocation failure,
6111 since xmalloc does that for us.
6113 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
6114 * category.c (hash_get_category_set):
6115 * ccl.c (ccl_driver):
6116 * charset.c (Fdefine_charset_internal):
6117 * charset.h (struct charset.hash_index):
6118 * composite.c (get_composition_id, gstring_lookup_cache)
6119 (composition_gstring_put_cache):
6120 * composite.h (struct composition.hash_index):
6121 * dispextern.h (struct image.hash):
6122 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6123 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6124 (hashfn_equal, hashfn_user_defined, make_hash_table)
6125 (maybe_resize_hash_table, hash_lookup, hash_put)
6126 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6127 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6128 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6129 * image.c (make_image, search_image_cache, lookup_image)
6130 (xpm_put_color_table_h):
6131 * lisp.h (struct Lisp_Hash_Table):
6132 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
6133 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
6134 for hashes and hash indexes, instead of 'unsigned' and 'int'.
6135 * alloc.c (allocate_vectorlike):
6136 Check for overflow in vector size calculations.
6137 * ccl.c (ccl_driver):
6138 Check for overflow when converting EMACS_INT to int.
6139 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6140 need to be updated by these changes.
6141 * fns.c (make_hash_table, maybe_resize_hash_table):
6142 Check for integer overflow with large hash tables.
6143 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6144 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6145 (SXHASH_REDUCE): New macro.
6146 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6147 Use it instead of discarding useful hash info with large hash values.
6148 (sxhash_float): New function.
6149 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6150 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
6151 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6152 Rewrite to use FIXNUM_BITS, as this simplifies things.
6153 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6154 Adjust signatures to match updated version of code.
6155 (consing_since_gc): Now EMACS_INT, since a single hash table can
6156 use more than INT_MAX bytes.
6158 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6160 Make it possible to build with GCC-4.6+ -O2 -flto.
6162 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6164 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6166 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6167 Call minibuffer-inactive-mode.
6169 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
6171 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6172 Update dependencies.
6174 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6176 * data.c (init_data): Remove code for UTS, this system is not
6179 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6181 Don't force ./temacs to start in terminal mode.
6183 * frame.c (make_initial_frame): Initialize faces in all cases, not
6184 only when CANNOT_DUMP is defined.
6185 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6187 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6189 * dispnew.c (add_window_display_history): Use const for the string
6190 pointer. Remove declaration, not needed.
6192 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6194 Use 'inline', not 'INLINE'.
6195 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
6196 * alloc.c, fontset.c (INLINE): Remove.
6197 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6198 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6199 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6200 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6201 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6203 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6205 Make it possible to run ./temacs.
6207 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6208 syms_of_callproc does the same thing. Remove test for
6209 "initialized", do it in the caller.
6210 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6212 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6214 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6215 (read_minibuf): Use get_minibuffer.
6216 (syms_of_minibuf): Use DEFSYM.
6217 (Qmetadata): New var.
6218 * data.c (Qbuffer): Don't make it static.
6219 (syms_of_data): Use DEFSYM.
6221 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6223 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6224 (CCL_CODE_MIN): New macro.
6226 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6228 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6230 * eval.c (Qdebug): Now static.
6231 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6232 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6233 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6235 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6237 * image.c: Various fixes to ImageMagick code comments.
6238 (Fimagemagick_types): Doc fix.
6240 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6242 Minor fixes prompted by GCC 4.6.0 warnings.
6244 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6246 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6247 (x_clipboard_manager_save_all): Move extern decl to ...
6248 * xterm.h: ... here, so that it can be checked for consistency.
6250 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6252 * xselect.c (x_clipboard_manager_save_frame)
6253 (x_clipboard_manager_save_all): New functions.
6254 (Fx_clipboard_manager_save): Lisp function deleted.
6256 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6257 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6259 * xterm.h: Update prototype.
6261 2011-05-28 William Xu <william.xwl@gmail.com>
6263 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6266 2011-05-28 Jim Meyering <meyering@redhat.com>
6268 Avoid a sign-extension bug in crypto_hash_function.
6269 * fns.c (to_uchar): Define.
6270 (crypto_hash_function): Use it to convert some newly-signed
6271 variables to unsigned, to avoid sign-extension bugs. For example,
6272 without this change, (md5 "truc") would evaluate to
6273 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6274 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
6275 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
6277 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6279 Integer overflow fixes.
6281 * dbusbind.c: Serial number integer overflow fixes.
6282 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
6283 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6284 to hold a serial number that is too large for a fixnum.
6285 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6286 Check for serial numbers out of range. Decode any serial number
6287 that was so large that it became a float. (Bug#8722)
6289 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6290 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6291 Use XFASTINT rather than XUINT when numbers are nonnegative.
6292 (xd_append_arg, Fdbus_method_return_internal):
6293 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6294 arguments, check that Lisp number is nonnegative, rather than
6295 silently wrapping negative numbers around. (Bug#8722)
6296 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
6299 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6301 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6303 ccl: Add integer overflow checks.
6304 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6305 (IN_INT_RANGE): New macros.
6306 (ccl_driver): Use them to check for integer overflow when
6307 decoding a CCL program. Many of the new checks are whether XINT (x)
6308 fits in int; it doesn't always, on 64-bit hosts. The new version
6309 doesn't catch all possible integer overflows, but it's an
6310 improvement. (Bug#8719)
6312 * alloc.c (make_event_array): Use XINT, not XUINT.
6313 There's no need for unsigned here.
6315 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6316 This follows up to the 2011-05-06 change that substituted uintptr_t
6317 for EMACS_INT. This case wasn't caught back then.
6319 Rework Fformat to avoid integer overflow issues.
6320 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6321 now (part of C89). Include <verify.h>.
6322 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6323 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6324 (Fformat): Avoid the prepass trying to compute sizes; it was only
6325 approximate and thus did not catch overflow reliably. Instead, walk
6326 through the format just once, formatting and computing sizes as we go,
6327 checking for integer overflow at every step, and allocating a larger
6328 buffer as needed. Keep track separately whether the format is
6329 multibyte. Keep only the most-recently calculated precision, rather
6330 than them all. Record whether each argument has been converted to
6331 string. Use EMACS_INT, not int, for byte and char and arg counts.
6332 Support field widths and precisions larger than INT_MAX. Avoid
6333 sprintf's undefined behavior with conversion specifications such as %#d
6334 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6335 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6336 formatting out-of-range floating point numbers with int
6339 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6341 * data.c: Avoid integer truncation in expressions involving floats.
6342 * data.c: Include <intprops.h>.
6343 (arith_driver): When there's an integer overflow in an expression
6344 involving floating point, convert the integers to floating point
6345 so that the resulting value does not suffer from catastrophic
6346 integer truncation. For example, on a 64-bit host (* 4
6347 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6348 Do not rely on undefined behavior after integer overflow.
6350 merge count_size_as_multibyte, parse_str_to_multibyte
6351 * character.c, character.h (count_size_as_multibyte):
6352 Rename from parse_str_to_multibyte; all uses changed.
6353 Check for integer overflow.
6354 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6355 since it's now a duplicate of the other. This is more of
6356 a character than a buffer op, so better that it's in character.c.
6357 * fns.c, print.c: Adjust to above changes.
6359 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6361 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6363 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6365 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6366 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6367 (x_clipboard_manager_save): Now static.
6368 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6370 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6371 (crypto_hash_function): Now static.
6372 Fix pointer signedness problems. Avoid unnecessary initializations.
6374 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
6376 * termhooks.h (Vselection_alist): Make it terminal-local.
6378 * terminal.c (create_terminal): Initialize it.
6380 * xselect.c: Support for clipboard managers.
6381 (Vselection_alist): Move to termhooks.h as terminal-local var.
6382 (LOCAL_SELECTION): New macro.
6383 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6384 (symbol_to_x_atom): Remove gratuitous arg.
6385 (x_handle_selection_request, lisp_data_to_selection_data)
6386 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6387 (x_own_selection, x_get_local_selection, x_convert_selection):
6388 New arg, specifying work frame. Use terminal-local Vselection_alist.
6389 (some_frame_on_display): Delete unused function.
6390 (Fx_own_selection_internal, Fx_get_selection_internal)
6391 (Fx_disown_selection_internal, Fx_selection_owner_p)
6392 (Fx_selection_exists_p): New optional frame arg.
6393 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6394 (x_handle_selection_clear): Don't treat other terminals with the
6395 same keyboard specially. Use the terminal-local Vselection_alist.
6396 (x_clear_frame_selections): Use Frun_hook_with_args.
6398 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6400 * xterm.h: Add support for those atoms.
6402 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6404 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6405 (converted_selections, conversion_fail_tag): New global variables.
6406 (x_selection_request_lisp_error): Free the above.
6407 (x_get_local_selection): Remove unnecessary code.
6408 (x_reply_selection_request): Args changed; handle arbitrary array
6409 of converted selections stored in converted_selections.
6410 Separate the XChangeProperty and SelectionNotify steps.
6411 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6412 (x_convert_selection): New function.
6413 (x_handle_selection_event): Simplify.
6414 (x_get_foreign_selection): Don't ignore incoming requests while
6415 waiting for an answer; this will fail when we implement
6416 SAVE_TARGETS, and seems unnecessary anyway.
6417 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6418 (Vx_sent_selection_functions): Doc fix.
6420 2011-05-26 Leo Liu <sdl.web@gmail.com>
6422 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6424 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6426 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6428 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6429 for fringe update if it has periodic bitmap.
6430 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6431 and fringe_bitmap_periodic_p.
6433 * fringe.c (get_fringe_bitmap_data): New function.
6434 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6435 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6436 row. Mark glyph row for fringe update if periodicity changed.
6438 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6439 for fringe update unless it has periodic bitmap.
6441 2011-05-25 Kenichi Handa <handa@m17n.org>
6443 * xdisp.c (get_next_display_element): Set correct it->face_id for
6444 a static composition.
6446 2011-05-24 Leo Liu <sdl.web@gmail.com>
6449 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6451 * fns.c (crypto_hash_function, Fsha1): New function.
6452 (Fmd5): Use crypto_hash_function.
6453 (syms_of_fns): Add Ssha1.
6455 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6457 * gnutls.c: Remove unused macros.
6458 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6459 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6460 Remove macros that are defined and never used.
6461 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6463 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6465 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6466 (Fx_get_selection_internal): Minor cleanup.
6467 (Fx_own_selection_internal): Rename arguments for consistency with
6470 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6472 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6474 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6476 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6478 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6480 * dispnew.c (scrolling_window): Don't exclude the case that the
6481 last enabled row in the desired matrix touches the bottom boundary.
6483 2011-05-21 Glenn Morris <rgm@gnu.org>
6485 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6486 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6487 and add some more files.
6489 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6491 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6492 report_file_error introduced by the change from 2011-05-07.
6494 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6496 * systime.h (Time): Define only if emacs is defined.
6497 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6498 where the include path doesn't have X11/X.h by default. See
6499 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6501 2011-05-20 Kenichi Handa <handa@m17n.org>
6503 * composite.c (find_automatic_composition): Fix previous change.
6505 2011-05-20 Glenn Morris <rgm@gnu.org>
6507 * lisp.mk: New file, split from Makefile.in.
6508 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6509 (shortlisp): Remove.
6510 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6512 2011-05-19 Glenn Morris <rgm@gnu.org>
6514 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6515 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6516 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6517 (lisp): Set the order to that of loadup.el.
6518 (shortlisp): Make it a copy of $lisp.
6519 (SOME_MACHINE_LISP): Remove.
6520 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6521 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6523 2011-05-18 Kenichi Handa <handa@m17n.org>
6525 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6526 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6527 (find_automatic_composition): Mostly rewrite for efficiency.
6529 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6531 * makefile.w32-in: Update dependencies.
6533 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6535 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6536 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6538 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6540 Fix some integer overflow issues, such as string length overflow.
6542 * insdel.c (count_size_as_multibyte): Check for string overflow.
6544 * character.c (lisp_string_width): Check for string overflow.
6545 Use EMACS_INT, not int, for string indexes and lengths; in
6546 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6547 the resulting string length overflows an EMACS_INT; instead,
6548 report a string overflow if no precision given. When checking for
6549 precision exhaustion, use a check that cannot possibly have
6550 integer overflow. (Bug#8675)
6551 * character.h (lisp_string_width): Adjust to new signature.
6553 * alloc.c (string_overflow): New function.
6554 (Fmake_string): Use it. This doesn't change behavior, but saves
6555 a few bytes and will simplify future changes.
6556 * character.c (string_escape_byte8): Likewise.
6557 * lisp.h (string_overflow): New decl.
6559 Fixups, following up to the user-interface timestamp change.
6560 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6561 for UI timestamps, instead of unsigned long.
6562 * msdos.c (mouse_get_pos): Likewise.
6563 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6564 * w32gui.h (Time): Define by including "systime.h" rather than by
6565 declaring it ourselves. (Bug#8664)
6567 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6568 * image.c (clear_image_cache): Likewise.
6570 * term.c (term_mouse_position): Don't assume time_t wraparound.
6572 Be more systematic about user-interface timestamps.
6573 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6574 and sometimes 'EMACS_UINT', to represent these timestamps.
6575 This change causes it to use 'Time' uniformly, as that's what X uses.
6576 This makes the code easier to follow, and makes it easier to catch
6577 integer overflow bugs such as Bug#8664.
6578 * frame.c (Fmouse_position, Fmouse_pixel_position):
6579 Use Time, not unsigned long, for user-interface timestamps.
6580 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6581 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6582 * keyboard.h (last_event_timestamp): Likewise.
6583 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6584 * menu.h (xmenu_show): Likewise.
6585 * term.c (term_mouse_position): Likewise.
6586 * termhooks.h (struct input_event.timestamp): Likewise.
6587 (struct terminal.mouse_position_hook): Likewise.
6588 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6589 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6590 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6591 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6593 * menu.h, termhooks.h: Include "systime.h", for Time.
6595 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6596 Don't assume that the difference between two unsigned long values
6597 can fit into an integer. At this point, we know button_down_time
6598 <= event->timestamp, so the difference must be nonnegative, so
6599 there's no need to cast the result if double-click-time is
6600 nonnegative, as it should be; check that it's nonnegative, just in
6601 case. This bug is triggered when events are more than 2**31 ms
6602 apart (about 25 days). (Bug#8664)
6604 * xselect.c (last_event_timestamp): Remove duplicate decl.
6605 (x_own_selection): Remove needless cast to unsigned long.
6607 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6608 that always fit in int. Use a sentinel instead of a counter, to
6609 avoid a temp and to allay GCC's concerns about possible int overflow.
6610 * frame.h (struct frame): Use int for menu_bar_items_used
6611 instead of EMACS_INT, since it always fits in int.
6613 * menu.c (grow_menu_items): Check for int overflow.
6615 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6617 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6618 Before, the code was not consistent. These values cannot exceed
6619 2**31 - 1 so there's no need to make them unsigned.
6620 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6621 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6622 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6624 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6626 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6627 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6628 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6629 presumably because the widths might not match.
6631 * window.c (size_window): Avoid needless test at loop start.
6633 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6635 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6637 2011-05-12 Drew Adams <drew.adams@oracle.com>
6639 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6641 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6643 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6644 `width' to `bar_area_x' and `bar_area_width', respectively.
6645 (x_scroll_run): Take account of fringe background extension.
6647 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6648 Rename local vars `left' and `width' to `bar_area_x' and
6649 `bar_area_width', respectively.
6650 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6651 background extension.
6653 2011-05-10 Jim Meyering <meyering@redhat.com>
6655 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6657 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6659 * image.c (Finit_image_library): Return t for built-in image types,
6660 like pbm and xbm. (Bug#8640)
6662 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6664 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6666 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6668 * w32console.c (Fset_screen_color): Doc fix.
6669 (Fget_screen_color): New function.
6670 (syms_of_ntterm): Defsubr it.
6672 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6673 unlink the temporary file if Fcall_process didn't create it in the
6675 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6676 child process will be redirected to a file specified with `:file'.
6677 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6678 cue to call_process_cleanup not to close that handle.
6680 2011-05-07 Ben Key <bkey76@gmail.com>
6682 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6683 one of two shell specific rules, either bootstrap-temacs-CMD or
6684 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6685 to the previous implementation of the bootstrap-temacs rule.
6686 The bootstrap-temacs-CMD rule is similar to the previous
6687 implementation of the bootstrap-temacs rule except that it
6688 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6691 These changes, along with some changes to nt/configure.bat,
6692 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6693 earlier fix to add support for --cflags and --ldflags options
6694 that include quotes so that it works whether make uses cmd or
6697 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6699 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6700 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6702 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6703 a string. Handle both cases.
6704 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6705 (Fdbus_register_method): Use Qinvalid_function.
6707 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6709 * makefile.w32-in: Update dependencies.
6710 (LISP_H): Add inttypes.h and stdin.h.
6711 (PROCESS_H): Add unistd.h.
6713 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6715 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6716 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6718 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6720 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6722 * term.c (vfatal): Remove stray call to va_end.
6723 It's not needed and the C Standard doesn't allow it here anyway.
6725 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6726 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6728 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6731 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6733 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6735 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6737 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6739 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6741 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6742 * charset.c (Fdefine_charset_internal): Don't initialize
6743 charset.code_space[15]. The value was garbage, on hosts with
6744 32-bit int (Bug#8600).
6746 * lread.c (read_integer): Be more consistent with string-to-number.
6747 Use string_to_number to do the actual conversion; this avoids
6748 rounding errors and fixes some other screwups. Without this fix,
6749 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6750 (digit_to_number): Move earlier, for benefit of read_integer.
6751 Return -1 if the digit is out of range for the base, -2 if it is
6752 not a digit in any supported base. (Bug#8602)
6754 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6756 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6757 to match comment at start of function. This also removes a
6758 GCC warning about overflow in a 32+64-bit port.
6760 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6762 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6763 Reported by Stefan Monnier in
6764 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6765 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6766 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6768 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6769 (EMACS_UINTPTR): Likewise, with uintptr_t.
6771 * lisp.h: Prefer 64-bit EMACS_INT if available.
6772 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6773 on 32-bit hosts that have 64-bit int, so that they can access
6775 However, temporarily disable this change unless the temporary
6776 symbol WIDE_EMACS_INT is defined.
6778 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6780 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6781 This removes an assumption that EMACS_INT and long are the same
6782 width as pointers. The assumption is true for Emacs porting targets
6783 now, but we want to make other targets possible.
6784 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6785 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6786 In the rest of the code, change types of integers that hold casted
6787 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6788 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6789 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6790 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6791 No need to cast type when ORing.
6792 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6793 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6794 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6795 assume EMACS_INT is the same width as char *.
6796 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6797 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6798 Remove no-longer-needed casts.
6799 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6800 (xg_tool_bar_help_callback, xg_make_tool_item):
6801 Use EMACS_INTPTR to hold an integer
6802 that will be cast to void *; this can avoid a GCC warning
6803 if EMACS_INT is not the same width as void *.
6804 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6805 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6806 (current_message_1, set_message_1):
6807 Use a local to convert to proper width without a cast.
6808 * xmenu.c (dialog_selection_callback): Likewise.
6810 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6811 Also, don't assume VALBITS / RAND_BITS is less than 5,
6812 and don't rely on undefined behavior when shifting a 1 left into
6814 * lisp.h (get_random): Change signature to match.
6816 * lread.c (hash_string): Use size_t, not int, for hash computation.
6817 Normally we prefer signed values; but hashing is special, because
6818 it's better to use unsigned division on hash table sizes so that
6819 the remainder is nonnegative. Also, size_t is the natural width
6820 for hashing into memory. The previous code used 'int', which doesn't
6821 retain enough info to hash well into very large tables.
6822 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6824 * dbusbind.c: Don't possibly lose pointer info when converting.
6825 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6826 Use XPNTR rather than XHASH, so that the high-order bits of
6827 the pointer aren't lost when converting through void *.
6829 * eval.c (Fautoload): Don't double-shift a pointer.
6831 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6833 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6835 * gnutls.c (DEF_GNUTLS_FN):
6836 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6838 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6840 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6843 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6845 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6846 New version that can reserve upto 2GB of heap space.
6848 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6850 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6852 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6854 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6855 `gnutls_certificate_set_x509_key_file'.
6857 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6859 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6860 Update dependencies.
6862 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6864 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6865 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6866 Remove unused parameter `fildes'.
6867 * process.c (read_process_output, send_process): Don't pass it.
6869 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6871 Fix previous change: the library cache is defined in w32.c.
6872 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6873 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6875 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6877 Implement dynamic loading of GnuTLS on Windows.
6879 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6880 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6881 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6884 * gnutls.c (Qgnutls_dll): Define.
6885 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6886 (gnutls_*): Declare function pointers.
6887 (init_gnutls_functions): New function to initialize function pointers.
6888 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6889 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6890 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6891 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6892 (emacs_gnutls_write, emacs_gnutls_read)
6893 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6894 (Fgnutls_available_p): New function.
6895 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6896 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6897 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6899 * image.c: Include w32.h.
6900 (Vimage_type_cache): Delete.
6901 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6902 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6903 (w32_delayed_load): Move to w32.c.
6905 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6907 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6908 (w32_delayed_load): Move from image.c. When loading a library, record
6909 its filename in the :loaded-from property of the library id.
6910 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6911 Initialize and staticpro them.
6912 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6914 * process.c: Include lisp.h before w32.h, not after.
6915 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6916 instead of gnutls_record_check_pending.
6918 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6920 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6922 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6923 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6926 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6928 * xterm.c (x_set_frame_alpha): Do not set property on anything
6929 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6931 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6933 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6935 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6937 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6938 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6939 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6940 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6941 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6942 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6943 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6944 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6945 (Qgnutls_bootprop_callbacks_verify): Make static.
6947 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6949 * callproc.c: Indentation fixup.
6951 * sysdep.c (wait_for_termination_1): Make static.
6952 (wait_for_termination, interruptible_wait_for_termination):
6953 Move after wait_for_termination_1.
6955 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6957 * sysdep.c (interruptible_wait_for_termination): New function
6958 which is like wait_for_termination, but allows keyboard
6961 * callproc.c (Fcall_process): Add (:file "file") as an option for
6963 (Fcall_process_region): Ditto.
6965 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6967 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6968 rather than `XVECTOR (FOO)->size'.
6970 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6971 inttypes.h, as a gnulib replacement is used if it not available in
6974 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6976 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6977 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6978 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6980 * coding.c (coding_alloc_by_realloc): Error out if destination
6981 will grow beyond MOST_POSITIVE_FIXNUM.
6982 (decode_coding_emacs_mule): Abort if there isn't enough place in
6983 charbuf for the composition carryover bytes. Reserve an extra
6984 space for up to 2 characters produced in a loop.
6985 (decode_coding_iso_2022): Abort if there isn't enough place in
6986 charbuf for the composition carryover bytes.
6988 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6990 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6991 aborting when %lld or %lll format is passed.
6992 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6993 %llo or %llx format is passed. (Bug#8545)
6995 * window.c (window_scroll_line_based): Use a marker instead of
6996 simple variables to record original value of point. (Bug#7952)
6998 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6999 produced by %s or %c overflows available buffer space. (Bug#8545)
7001 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
7003 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
7004 (SIZE_MAX): Move defn after all includes, as they might #define it.
7006 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7008 * w32.c (init_environment): Warn about defaulting HOME to C:\.
7010 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7012 * keyboard.c (Qdelayed_warnings_hook): Define.
7013 (command_loop_1): Run `delayed-warnings-hook'
7014 if Vdelayed_warnings_list is non-nil.
7015 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
7016 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
7018 2011-04-28 Eli Zaretskii <eliz@gnu.org>
7020 * doprnt.c (doprnt): Don't return value smaller than the buffer
7021 size if the message was truncated. (Bug#8545).
7023 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
7025 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
7026 (Fx_window_property): #if-0 the whole functions, not just the bodies.
7028 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7030 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
7032 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
7034 * makefile.w32-in: Update dependencies.
7036 2011-04-27 Eli Zaretskii <eliz@gnu.org>
7038 Improve `doprnt' and its usage. (Bug#8545)
7039 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
7040 `format_end'. Remove support for %l as a conversion specifier.
7041 Don't use xrealloc. Improve diagnostics when the %l size modifier
7042 is used. Update the commentary.
7044 * eval.c (verror): Simplify calculation of size_t.
7046 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
7049 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
7051 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
7054 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7056 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
7057 This makes this file independent of the recent pseudovector change.
7059 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
7061 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
7063 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7064 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
7065 Remove unused local.
7066 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
7068 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
7069 GCC 4.6.0 optimizes based on type-based alias analysis.
7070 For example, if b is of type struct buffer * and v of type struct
7071 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
7072 != &v->size, and therefore "v->size = 1; b->size = 2; return
7073 v->size;" must therefore return 1. This assumption is incorrect
7074 for Emacs, since it type-puns struct Lisp_Vector * with many other
7075 types. To fix this problem, this patch adds a new type struct
7076 vectorlike_header that documents the constraints on layout of vectors
7077 and pseudovectors, and helps optimizing compilers not get fooled
7078 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7079 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
7080 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7082 (XSETPVECTYPE): Rewrite in terms of new macro.
7083 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7084 This is a bit clearer, and further avoids the possibility of
7085 undesirable aliasing.
7086 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
7087 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
7088 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7089 since Lisp_Subr is a special case (no "next" field).
7090 (ASIZE): Now uses header.size rather than size.
7091 All previous uses of XVECTOR (foo)->size replaced to use this macro,
7092 to avoid the hassle of writing XVECTOR (foo)->header.size.
7093 (struct vectorlike_header): New type.
7094 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7095 object, to help avoid aliasing.
7096 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7097 (SUBRP): Likewise, since Lisp_Subr is a special case.
7098 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7099 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7100 (struct Lisp_Hash_Table): Combine first two members into a single
7101 struct vectorlike_header member. All uses of "size" and "next" members
7102 changed to be "header.size" and "header.next".
7103 * buffer.h (struct buffer): Likewise.
7104 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7105 * frame.h (struct frame): Likewise.
7106 * process.h (struct Lisp_Process): Likewise.
7107 * termhooks.h (struct terminal): Likewise.
7108 * window.c (struct save_window_data, struct saved_window): Likewise.
7109 * window.h (struct window): Likewise.
7110 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7111 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7112 * buffer.c (init_buffer_once): Likewise.
7113 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7115 * process.c (Fformat_network_address): Use local var for size,
7118 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7120 Make the Lisp reader and string-to-float more consistent (Bug#8525)
7121 * data.c (atof): Remove decl; no longer used or needed.
7122 (digit_to_number): Move to lread.c.
7123 (Fstring_to_number): Use new string_to_number function, to be
7124 consistent with how the Lisp reader treats infinities and NaNs.
7125 Do not assume that floating-point numbers represent EMACS_INT
7126 without losing information; this is not true on most 64-bit hosts.
7127 Avoid double-rounding errors, by insisting on integers when
7128 parsing non-base-10 numbers, as the documentation specifies.
7129 * lisp.h (string_to_number): New decl, replacing ...
7130 (isfloat_string): Remove.
7131 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
7132 (read1): Do not accept +. and -. as integers; this
7133 appears to have been a coding error. Similarly, do not accept
7134 strings like +-1e0 as floating point numbers. Do not report
7135 overflow for integer overflows unless the base is not 10 which
7136 means we have no simple and reliable way to continue.
7137 Break out the floating-point parsing into a new
7138 function string_to_number, so that Fstring_to_number parses
7139 floating point numbers consistently with the Lisp reader.
7140 (digit_to_number): Move here from data.c. Make it static inline.
7141 (E_CHAR, EXP_INT): Remove, replacing with ...
7142 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7143 (string_to_number): New function, replacing isfloat_string.
7144 This function checks for valid syntax and produces the resulting
7145 Lisp float number too. Rework it so that string-to-number
7146 no longer mishandles examples like "1.0e+". Use strtoumax,
7147 so that overflow for non-base-10 numbers is reported only when
7148 there's no portable and simple way to convert to floating point.
7150 * textprop.c (set_text_properties_1): Rewrite for clarity,
7151 and to avoid GCC warning about integer overflow.
7153 * intervals.h (struct interval): Use EMACS_INT for members
7154 where EMACS_UINT might cause problems. See
7155 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7156 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7157 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7159 (offset_intervals): Tell GCC not to worry about length overflow
7160 when negating a negative length.
7162 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7163 (overrun_check_free): Likewise.
7165 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7166 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7169 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7170 (gnutls_make_error): Rename local to avoid shadowing.
7171 (gnutls_emacs_global_deinit): ifdef out; not used.
7172 (Fgnutls_boot): Use const for pointer to readonly storage.
7173 Comment out unused local. Fix pointer signedness problems.
7175 * lread.c (openp): Don't stuff size_t into an 'int'.
7176 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7177 about possible signed overflow.
7179 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7180 (GDK_KEY_g): Don't define if already defined.
7181 (xg_prepare_tooltip): Avoid pointer signedness problem.
7182 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7184 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7185 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7187 * xfns.c (Fx_window_property): Simplify a bit,
7188 to make a bit faster and to avoid GCC 4.6.0 warning.
7189 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7191 * fns.c (internal_equal): Don't assume size_t fits in int.
7193 * alloc.c (compact_small_strings): Tighten assertion a little.
7195 Replace pEd with more-general pI, and fix some printf arg casts.
7196 * lisp.h (pI): New macro, generalizing old pEd macro to other
7197 conversion specifiers. For example, use "...%"pI"d..." rather
7198 than "...%"pEd"...".
7199 (pEd): Remove. All uses replaced with similar uses of pI.
7200 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
7201 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7202 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7203 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7204 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7205 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7206 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7208 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7209 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7210 * print.c (safe_debug_print, print_object): Likewise.
7211 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7213 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7214 avoiding the 0 flag, which is not portable.
7215 * process.c (Fmake_network_process): Use pI to avoid cast.
7216 * region-cache.c (pp_cache): Likewise.
7217 * xdisp.c (decode_mode_spec): Likewise.
7218 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7219 behavior on 64-bit hosts with printf arg.
7220 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
7221 (x_stop_queuing_selection_requests): Likewise.
7222 (x_get_window_property): Don't truncate byte count to an 'int'
7225 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7226 here, since it parses constructs like leading '-' and spaces,
7227 which are not wanted; and it overflows with large numbers.
7228 Instead, simply match F[0-9]+, which is what is wanted anyway.
7230 * alloc.c: Remove unportable assumptions about struct layout.
7231 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7232 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7233 (allocate_vectorlike, make_pure_vector): Use the new macros,
7234 plus offsetof, to remove unportable assumptions about struct layout.
7235 These assumptions hold on all porting targets that I know of, but
7236 they are not guaranteed, they're easy to remove, and removing them
7237 makes further changes easier.
7239 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7240 This doesn't fix a bug but makes the code clearer.
7241 (string_overrun_cookie): Now const. Use initializers that
7242 don't formally overflow signed char, to avoid warnings.
7243 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7244 can cause Emacs to crash when string overrun checking is enabled.
7245 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7246 multiple of sizeof (EMACS_INT); it need not be, if
7247 alignof(EMACS_INT) < sizeof (EMACS_INT).
7248 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
7250 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
7252 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7254 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7256 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
7257 supposed to be handshaking. (Bug#8556)
7258 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7260 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
7262 * lisp.h (Qdebug): List symbol.
7263 * eval.c (Qdebug): Restore global linkage.
7264 * keyboard.c (debug-on-event): New variable.
7265 (handle_user_signal): Break into debugger when debug-on-event
7266 matches the current signal symbol.
7268 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7270 * alloc.c (check_sblock, check_string_bytes)
7271 (check_string_free_list): Convert to standard C.
7273 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7275 * w32.c (emacs_gnutls_push): Fix typo.
7277 2011-04-25 Eli Zaretskii <eliz@gnu.org>
7279 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7280 "cast to pointer from integer of different size".
7282 Improve doprnt and its use in verror. (Bug#8545)
7283 * doprnt.c (doprnt): Document the set of format control sequences
7284 supported by the function. Use SAFE_ALLOCA instead of always
7287 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7288 is one byte too soon. Don't use xrealloc; instead xfree and
7291 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7293 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7296 * gnutls.c: Renamed global_initialized to
7297 gnutls_global_initialized. Added internals for the
7298 :verify-hostname-error, :verify-error, and :verify-flags
7299 parameters of `gnutls-boot' and documented those parameters in the
7300 docstring. Start callback support.
7301 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7302 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7303 on error. Return error code.
7304 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7305 (emacs_gnutls_read): Likewise.
7306 (Fgnutls_boot): Return handshake error code.
7307 (emacs_gnutls_handle_error): New function.
7308 (wsaerror_to_errno): Likewise.
7310 * w32.h (emacs_gnutls_pull): Add prototype.
7311 (emacs_gnutls_push): Likewise.
7313 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7314 (emacs_gnutls_push): Likewise.
7316 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7318 * process.c (wait_reading_process_output): Check if GnuTLS
7319 buffered some data internally if no FDs are set for TLS
7322 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7323 (LIBS): Link to USER_LIBS.
7324 ($(BLD)/gnutls.$(0)): New target.
7326 2011-04-24 Eli Zaretskii <eliz@gnu.org>
7328 * xdisp.c (handle_single_display_spec): Rename the
7329 display_replaced_before_p argument into display_replaced_p, to
7330 make it consistent with the commentary. Fix typos in the
7333 * textprop.c (syms_of_textprop): Remove dead code.
7334 (copy_text_properties): Delete obsolete commentary about an
7335 interface that was deleted long ago. Fix typos in the description
7338 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7339 to changes in oldXMenu/XMenu.h from 2011-04-16.
7340 <menu_help_message, prev_menu_help_message>: Constify.
7341 (IT_menu_make_room): menu->help_text is now `const char **';
7344 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7345 to changes in oldXMenu/XMenu.h from 2011-04-16.
7346 (struct XMenu): Declare `help_text' `const char **'.
7348 * xfaces.c <Qunspecified>: Make extern again.
7350 * syntax.c: Include sys/types.h before including regex.h, as
7353 * doc.c (get_doc_string): Improve the format passed to `error'.
7355 * doprnt.c (doprnt): Improve commentary.
7357 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7359 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7362 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7363 changes in globals.h immediately force recompilation.
7364 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7365 $(CURDIR)/s/ms-w32.h.
7366 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
7368 * character.c (Fchar_direction): Function deleted.
7369 (syms_of_character): Don't defsubr it.
7370 <char-direction-table>: Deleted.
7372 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7374 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7375 * doprnt.c: Include limits.h.
7376 (SIZE_MAX): New macro.
7377 (doprnt): Return a size_t value. 2nd arg is now size_t.
7378 Many local variables are now size_t instead of int or unsigned.
7379 Improve overflow protection. Support `l' modifier for integer
7380 conversions. Support %l conversion. Don't assume an EMACS_INT
7381 argument for integer conversions and for %c.
7383 * lisp.h (doprnt): Restore prototype.
7385 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7388 * Makefile.in (base_obj): Add back doprnt.o.
7390 * deps.mk (doprnt.o): Add back prerequisites.
7391 (callint.o): Depend on character.h.
7393 * eval.c (internal_lisp_condition_case): Include the handler
7394 representation in the error message.
7395 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7396 when breaking from the loop.
7398 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7400 * callint.c (Fcall_interactively): When displaying error message
7401 about invalid control letter, pass the character's codepoint, not
7402 a pointer to its multibyte form. Improve display of the character
7403 in octal and display also its hex code.
7405 * character.c (char_string): Use %x to display the (unsigned)
7406 codepoint of an invalid character, to avoid displaying a bogus
7409 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7410 `error', not SYMBOL_NAME itself.
7412 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7413 character arguments to `error'.
7415 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7416 to `error' in error message about FINAL_CHAR argument. Make sure
7417 FINAL_CHAR is a character, and use %c when it is passed as
7418 argument to `error'.
7420 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7422 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7424 * w32.c: Include <time.h>.
7425 (sys_localtime): New function.
7427 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7429 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7431 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7433 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7435 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7438 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7440 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7441 gl_state.e_property when gl_state.object is Qt.
7443 * insdel.c (make_gap_larger): Remove limitation of buffer size
7446 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7448 * xdisp.c (lookup_glyphless_char_display)
7449 (produce_glyphless_glyph): Handle cons cell entry in
7450 glyphless-char-display.
7451 (Vglyphless_char_display): Document it.
7453 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7454 glyphless-char-display.
7456 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7458 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7460 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7462 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7463 definition for no-X builds.
7465 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7467 Static checks with GCC 4.6.0 and non-default toolkits.
7469 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7471 * process.c (keyboard_bit_set): Define only if SIGIO.
7472 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7473 (send_process): Repair possible setjmp clobbering.
7475 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7477 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7479 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7481 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7482 Define only if needed.
7484 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7485 by pacifying GCC about it. Maybe it's time to retire it?
7486 * xfaces.c (USG, __TIMEVAL__): Likewise.
7488 * dispextern.h (struct redisplay_interface): Rename param
7490 * termhooks.h (struct terminal): Likewise.
7491 * xterm.c (xembed_send_message): Likewise.
7493 * insdel.c (make_gap_smaller): Define only if
7494 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7496 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7499 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7500 so that we aren't warned about unused symbols.
7502 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7504 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7506 * xfns.c (x_real_positions): Mark locals as initialized.
7508 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7510 * xterm.c: Fix problems found by static analysis with other toolkits.
7511 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7512 (x_dispatch_event): Declare static if USE_GTK, and
7513 define if USE_GTK || USE_X_TOOLKIT.
7514 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7515 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7516 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7517 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7519 * xmenu.c (menu_help_callback): Pointer type fixes.
7520 Use const pointers when pointing at readonly data. Avoid pointer
7522 (FALSE): Remove unused macro.
7523 (update_frame_menubar): Remove unused decl.
7525 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7527 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7528 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7529 (single_menu_item): Rename local to avoid shadowing.
7531 * keyboard.c (make_lispy_event): Remove unused local var.
7533 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7534 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7536 * bitmaps: Change bitmaps from unsigned char back to the X11
7537 compatible char. Avoid the old compiler warnings about
7538 out-of-range initializers by using, for example, '\xab' rather
7541 * xgselect.c (xgselect_initialize): Check vs interface
7542 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7544 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7546 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7547 to read-only memory.
7549 * fns.c (vector): Remove; this old hack is no longer needed.
7551 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7553 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7555 * xrdb.c (x_load_resources): Omit unused local.
7557 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7558 (x_window): Rename locals to avoid shadowing.
7559 (USG): Use the kludged USG macro, to pacify gcc.
7561 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7562 (x_term_init): Remove local to avoid shadowing.
7564 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7566 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7567 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7569 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7571 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7573 Fix regex.c, syntax.c and friends for buffers > 2GB.
7574 * syntax.h (struct gl_state_s): Declare character position members
7577 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7579 * textprop.c (verify_interval_modification, interval_of):
7580 Declare arguments EMACS_INT.
7582 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7585 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7587 * indent.c (Fvertical_motion): Local variable it_start is now
7590 * regex.c (re_match, re_match_2, re_match_2_internal)
7591 (bcmp_translate, regcomp, regexec, print_double_string)
7592 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7593 (re_compile_pattern, re_exec): Declare arguments and local
7594 variables `size_t' and `ssize_t' and return values `regoff_t', as
7596 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7597 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7598 <compile_stack_type>: `size' and `avail' are now `size_t'.
7600 * regex.h <regoff_t>: Use ssize_t, not int.
7601 (re_search, re_search_2, re_match, re_match_2): Arguments that
7602 specify buffer/string position and length are now ssize_t and
7603 size_t. Return type is regoff_t.
7605 2011-04-16 Ben Key <bkey76@gmail.com>
7607 * nsfont.m: Fixed bugs in ns_get_family and
7608 ns_descriptor_to_entity that were caused by using free to
7609 deallocate memory blocks that were allocated by xmalloc (via
7610 xstrdup). This caused Emacs to crash when compiled with
7611 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7612 --enable-checking=xmallocoverrun). xfree is now used to
7613 deallocate these memory blocks.
7615 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7617 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7619 emacs_write: Accept and return EMACS_INT for sizes.
7620 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7622 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7623 Accept and return EMACS_INT.
7624 (emacs_gnutls_write): Return the number of bytes written on
7626 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7627 (emacs_read, emacs_write): Remove check for negative size, as the
7628 Emacs source code has been audited now.
7629 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7630 (emacs_read, emacs_write): Use it.
7631 * process.c (send_process): Adjust to the new signatures of
7632 emacs_write and emacs_gnutls_write. Do not attempt to store
7633 a byte offset into an 'int'; it might overflow.
7634 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7636 * sound.c: Don't assume sizes fit in 'int'.
7637 (struct sound_device.period_size, alsa_period_size):
7638 Return EMACS_INT, not int.
7639 (struct sound_device.write, vox_write, alsa_write):
7640 Accept EMACS_INT, not int.
7641 (wav_play, au_play): Use EMACS_INT to store sizes and to
7642 record read return values.
7644 2011-04-15 Ben Key <bkey76@gmail.com>
7646 * keyboard.c (Qundefined): Don't declare static since it is used
7648 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7649 static since they are used in nsfont.m.
7651 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7653 * process.c (Qprocessp): Don't declare static.
7654 * lisp.h (Qprocessp): Declare again.
7656 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7658 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7660 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7662 Improve C-level modularity by making more things 'static'.
7664 Don't publish debugger-only interfaces to other modules.
7665 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7666 (verify_bytepos, count_markers): Move decls to the only modules
7668 * region-cache.h (pp_cache): Likewise.
7669 * window.h (check_all_windows): Likewise.
7670 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7672 * sysdep.c (croak): Now static, if
7673 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7674 * syssignal.h (croak): Declare only if not static.
7676 * alloc.c (refill_memory_reserve): Now static if
7677 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7678 * lisp.h (refill_memory_reserve): Declare only if not static.
7680 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7681 Define only if USE_LUCID.
7683 * xrdb.c (x_customization_string, x_rm_string): Now static.
7685 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7686 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7688 * xdisp.c (draw_row_with_mouse_face): Now static.
7689 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7691 * window.h (check_all_windows): Mark externally visible.
7693 * window.c (window_deletion_count): Now static.
7695 * undo.c: Make symbols static if they're not exported.
7696 (last_undo_buffer, last_boundary_position, pending_boundary):
7699 * textprop.c (interval_insert_behind_hooks): Now static.
7700 (interval_insert_in_front_hooks): Likewise.
7702 * term.c: Make symbols static if they're not exported.
7703 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7704 (max_frame_lines, tty_set_terminal_modes):
7705 (tty_reset_terminal_modes, tty_turn_off_highlight):
7706 (get_tty_terminal): Now static.
7707 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7708 * termhooks.h (term_mouse_moveto): Do not declare if
7710 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7711 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7713 * sysdep.c: Make symbols static if they're not exported.
7714 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7716 (sigprocmask_set, full_mask): Remove; unused.
7717 (wait_debugging): Mark as visible.
7718 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7719 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7721 * syntax.c (syntax_temp): Define only if !__GNUC__.
7723 * sound.c (current_sound_device, current_sound): Now static.
7725 * search.c (searchbufs, searchbuf_head): Now static.
7727 * scroll.c (scroll_cost): Remove; unused.
7728 * dispextern.h (scroll_cost): Remove decl.
7730 * region-cache.h (pp_cache): Mark as externally visible.
7732 * process.c: Make symbols static if they're not exported.
7733 (process_tick, update_tick, create_process, chan_process):
7734 (Vprocess_alist, proc_buffered_char, datagram_access):
7735 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7736 (deactivate_process): Mark defn as static, as well as decl.
7737 * lisp.h (create_process): Remove decl.
7738 * process.h (chan_process, Vprocess_alist): Remove decls.
7740 * print.c: Make symbols static if they're not exported.
7741 (print_depth, new_backquote_output, being_printed, print_buffer):
7742 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7743 (print_interval, print_number_index, initial_stderr_stream):
7745 * lisp.h (Fprinc): Remove decl.
7746 (debug_output_compilation_hack): Mark as externally visible.
7748 * sysdep.c (croak): Move decl from here to syssignal.h.
7749 * syssignal.h (croak): Put it here, so the API can be checked when
7750 'croak' is called from dissociate_if_controlling_tty.
7752 * minibuf.c: Make symbols static if they're not exported.
7753 (minibuf_save_list, choose_minibuf_frame): Now static.
7754 * lisp.h (choose_minibuf_frame): Remove decl.
7756 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7758 * lread.c: Make symbols static if they're not exported.
7759 (read_objects, initial_obarray, oblookup_last_bucket_number):
7761 (make_symbol): Remove; unused.
7762 * lisp.h (initial_obarray, make_symbol): Remove decls.
7764 * keyboard.c: Make symbols static if they're not exported.
7765 (single_kboard, recent_keys_index, total_keys, recent_keys):
7766 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7767 (this_single_command_key_start, echoing, last_auto_save):
7768 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7769 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7770 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7771 (Vlispy_mouse_stem, double_click_count):
7773 (force_auto_save_soon): Define only if SIGDANGER.
7774 (ignore_mouse_drag_p): Now static if
7775 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7776 (print_help): Remove; unused.
7777 (stop_character, last_timer_event): Mark as externally visible.
7778 * keyboard.h (ignore_mouse_drag_p): Declare only if
7779 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7780 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7781 * lisp.h (echoing): Remove decl.
7782 (force_auto_save_soon): Declare only if SIGDANGER.
7783 * xdisp.c (redisplay_window): Simplify code, to make it more
7784 obvious that ignore_mouse_drag_p is not accessed if !defined
7785 USE_GTK && !defined HAVE_NS.
7787 * intervals.c: Make symbols static if they're not exported.
7788 (merge_properties_sticky, merge_interval_right, delete_interval):
7790 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7792 * insdel.c: Make symbols static if they're not exported.
7793 However, leave prepare_to_modify_buffer alone. It's never
7794 called from outside this function, but that appears to be a bug.
7795 (combine_after_change_list, combine_after_change_buffer):
7796 (adjust_after_replace, signal_before_change): Now static.
7797 (adjust_after_replace_noundo): Remove; unused.
7798 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7799 (signal_before_change): Remove decls.
7801 * indent.c (val_compute_motion, val_vmotion): Now static.
7803 * image.c: Make symbols static if they're not exported.
7804 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7806 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7807 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7809 * fringe.c (standard_bitmaps): Now static.
7810 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7812 * frame.c: Make symbols static if they're not exported.
7813 (x_report_frame_params, make_terminal_frame): Now static.
7814 (get_frame_param): Now static, unless HAVE_NS.
7815 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7816 (x_get_resource_string): Remove; not used.
7817 * frame.h (make_terminal_frame, x_report_frame_params):
7818 (x_get_resource_string); Remove decls.
7819 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7820 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7822 * font.c, fontset.c: Make symbols static if they're not exported.
7823 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7824 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7825 * font.c (font_close_object): Now static.
7826 * font.h (font_close_object): Remove.
7827 * fontset.c (FONTSET_OBJLIST): Remove.
7828 (free_realized_fontset) #if-0 the body, which does nothing.
7829 (face_suitable_for_char_p): #if-0, as it's never called.
7830 * fontset.h (face_suitable_for_char_p): Remove decl.
7831 * xfaces.c (face_at_string_position):
7832 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7833 since 0 is always ASCII.
7835 * fns.c (weak_hash_tables): Now static.
7837 * fileio.c: Make symbols static if they're not exported.
7838 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7839 (Vwrite_region_annotation_buffers): Now static.
7841 * eval.c: Make symbols static if they're not exported.
7842 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7843 * lisp.h (backtrace_list): Remove decl.
7845 * emacs.c: Make symbols static if they're not exported.
7846 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7847 (fatal_error_code, fatal_error_signal_hook, standard_args):
7849 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7850 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7851 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7852 * lisp.h (fatal_error_signal_hook): Remove decl.
7853 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7855 * editfns.c: Move a (normally-unused) function to its only use.
7856 * editfns.c, lisp.h (get_operating_system_release): Remove.
7857 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7858 worth the hassle of breaking this out.
7860 * xterm.c: Make symbols static if they're not exported.
7861 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7862 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7863 (x_destroy_window, x_delete_display):
7865 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7866 (x_mouse_leave): Remove; unused.
7867 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7868 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7869 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7871 (x_mouse_leave): Declare only if WINDOWSNT.
7872 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7873 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7876 * ftxfont.c: Make symbols static if they're not exported.
7877 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7879 * font.h (ftxfont_driver): Likewise.
7881 * xfns.c: Make symbols static if they're not exported.
7882 (x_last_font_name, x_display_info_for_name):
7883 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7884 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7885 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7886 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7887 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7888 (last_show_tip_args): Now static.
7889 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7890 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7891 (x_screen_planes): Remove; unused.
7892 * dispextern.h (x_screen_planes): Remove decl.
7894 * dispnew.c: Make symbols static if they're not exported.
7895 * dispextern.h (redraw_garbaged_frames, scrolling):
7896 (increment_row_positions): Remove.
7897 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7898 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7900 (redraw_garbaged_frames): Remove; unused.
7902 * xfaces.c: Make symbols static if they're not exported.
7903 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7905 * xterm.h (defined_color): Remove decls.
7906 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7907 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7908 (menu_face_changed_default, defined_color, free_realized_face):
7909 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7910 (ascii_face_of_lisp_face): Remove; unused.
7912 * xdisp.c: Make symbols static if they're not exported.
7913 * dispextern.h (scratch_glyph_row, window_box_edges):
7914 (glyph_to_pixel_coords, set_cursor_from_row):
7915 (get_next_display_element, set_iterator_to_next):
7916 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7917 (show_mouse_face): Remove decls
7918 * frame.h (message_buf_print): Likewise.
7919 * lisp.h (pop_message, set_message, check_point_in_composition):
7921 * xterm.h (set_vertical_scroll_bar): Likewise.
7922 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7923 (message_buf_print, scratch_glyph_row, displayed_buffer):
7924 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7925 (get_next_display_element, show_mouse_face, window_box_edges):
7926 (frame_to_window_pixel_xy, check_point_in_composition):
7927 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7928 (glyph_to_pixel_coords): Remove; unused.
7930 * dired.c (file_name_completion): Now static.
7932 * dbusbind.c (xd_in_read_queued_messages): Now static.
7934 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7935 * data.c (circular_list_error): Remove.
7937 * commands.h (last_point_position, last_point_position_buffer):
7938 (last_point_position_window): Remove decls.
7939 * keyboard.c: Make these variables static.
7941 * coding.h (coding, code_convert_region, encode_coding_gap):
7943 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7944 (iso_code_class, detect_coding, code_convert_region): Now static.
7945 (encode_coding_gap): Remove; unused.
7947 * chartab.c (chartab_chars, chartab_bits): Now static.
7949 * charset.h (charset_iso_8859_1): Remove decl.
7950 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7953 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7954 * ccl.c (Vccl_program_table): Now static.
7955 (check_ccl_update): Remove; unused.
7957 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7958 * category.h: ... from here.
7959 * category.c (check_category_table, set_category_set): Now static.
7961 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7962 * lisp.h: Remove these decls.
7964 * buffer.c (buffer_count): Remove unused var.
7966 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7967 so that it's not optimized away.
7968 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7969 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7970 exported only to the debugger.
7972 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7973 * atimer.h (run_all_atimers): Remove; not exported.
7975 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7976 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7977 was inaccessible from Lisp.
7978 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7979 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7981 alloc.c: Import and export fewer symbols, and remove unused items.
7982 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7984 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7985 it's not optimized away by whole-program optimization.
7986 (message_enable_multibyte, free_misc): Remove.
7987 (catchlist, handlerlist, mark_backtrace):
7988 Declare only if BYTE_MARK_STACK.
7989 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7990 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7991 (message_enable_multibyte): Remove decl.
7992 (free_misc, interval_free_list, float_block, float_block_index):
7993 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7994 (cons_free_list, last_marked_index):
7996 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7997 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7998 (mark_backtrace): Define only if BYTE_MARK_STACK.
7999 * xdisp.c (message_enable_multibyte): Now static.
8001 Declare Lisp_Object Q* variables to be 'static' if not exported.
8002 This makes it easier for human readers (and static analyzers)
8003 to see whether these variables are used from other modules.
8004 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
8005 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
8006 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
8007 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
8008 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
8009 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
8010 * xmenu.c, xselect.c:
8011 Declare Q* vars static if they are not used in other modules.
8012 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
8013 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
8014 Remove decls of unexported vars.
8015 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
8017 * lisp.h (DEFINE_FUNC): Make sname 'static'.
8019 Make Emacs functions such as Fatom 'static' by default.
8020 This makes it easier for human readers (and static analyzers)
8021 to see whether these functions can be called from other modules.
8022 DEFUN now defines a static function. To make the function external
8023 so that it can be used in other C modules, use the new macro DEFUE.
8024 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
8025 (Finit_image_library):
8026 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
8027 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
8028 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
8029 Remove decls, since these functions are now static.
8030 (Funintern, Fget_internal_run_time): New decls, since these functions
8031 were already external.
8033 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
8034 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
8035 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
8036 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
8037 * keyboard.c, keymap.c, lread.c:
8038 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
8039 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
8040 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
8041 Mark functions with DEFUE instead of DEFUN,
8042 if they are used in other modules.
8043 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
8044 decls for now-static functions.
8045 * buffer.h (Fdelete_overlay): Remove decl.
8046 * callproc.c (Fgetenv_internal): Mark as internal.
8047 * composite.c (Fremove_list_of_text_properties): Remove decl.
8048 (Fcomposition_get_gstring): New forward static decl.
8049 * composite.h (Fcomposite_get_gstring): Remove decl.
8050 * dired.c (Ffile_attributes): New forward static decl.
8051 * doc.c (Fdocumntation_property): New forward static decl.
8052 * eval.c (Ffetch_bytecode): New forward static decl.
8053 (Funintern): Remove extern decl; now in .h file where it belongs.
8054 * fileio.c (Fmake_symbolic_link): New forward static decl.
8055 * image.c (Finit_image_library): New forward static decl.
8056 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
8057 * intervals.h (Fprevious_property_change):
8058 (Fremove_list_of_text_properties): Remove decls.
8059 * keyboard.c (Fthis_command_keys): Remove decl.
8060 (Fcommand_execute): New forward static decl.
8061 * keymap.c (Flookup_key): New forward static decl.
8062 (Fcopy_keymap): Now static.
8063 * keymap.h (Flookup_key): Remove decl.
8064 * process.c (Fget_process): New forward static decl.
8065 (Fprocess_datagram_address): Mark as internal.
8066 * syntax.c (Fsyntax_table_p): New forward static decl.
8067 (skip_chars): Remove duplicate decl.
8068 * textprop.c (Fprevious_property_change): New forward static decl.
8069 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
8071 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
8072 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
8074 * editfns.c (Fformat): Remove unreachable code.
8076 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
8078 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8081 2011-04-13 Eli Zaretskii <eliz@gnu.org>
8083 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8084 when at ZV. (Bug#8487)
8086 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8088 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8090 * keyboard.c (parse_tool_bar_item): Likewise.
8091 * sound.c (sound_cleanup, alsa_close): Likewise.
8092 * termcap.c (tgetent): Likewise.
8093 * xfns.c (x_default_font_parameter): Likewise.
8094 * xsettings.c (read_and_apply_settings): Likewise.
8096 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8097 (overrun_check_free): Protoize.
8099 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8101 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8102 since callers should never pass a negative size.
8103 Change the signature to match that of plain 'read' and 'write'; see
8104 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8105 * lisp.h: Update prototypes of emacs_write and emacs_read.
8107 2011-04-11 Eli Zaretskii <eliz@gnu.org>
8109 * xdisp.c (redisplay_window): Don't try to determine the character
8110 position of the scroll margin if the window start point w->startp
8111 is outside the buffer's accessible region. (Bug#8468)
8113 2011-04-10 Eli Zaretskii <eliz@gnu.org>
8115 Fix write-region and its subroutines for buffers > 2GB.
8116 * fileio.c (a_write, e_write): Modify declaration of arguments and
8117 local variables to support buffers larger than 2GB.
8118 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8120 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8121 argument, local variables, and return value.
8123 * lisp.h: Update prototypes of emacs_write and emacs_read.
8125 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8127 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
8129 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8131 Fix more problems found by GCC 4.6.0's static checks.
8133 * xdisp.c (vmessage): Use a better test for character truncation.
8135 * charset.c (load_charset_map): <, not <=, for optimization,
8136 and to avoid potential problems with integer overflow.
8137 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
8138 * casetab.c (set_identity, shuffle): Likewise.
8139 * editfns.c (Fformat): Likewise.
8140 * syntax.c (skip_chars): Likewise.
8142 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8143 This also lets GCC 4.6.0 generate slightly better loop code.
8145 * callint.c (Fcall_interactively): <, not <=, for optimization.
8146 (Fcall_interactively): Count the number of arguments produced,
8147 not the number of arguments given. This is simpler and lets GCC
8148 4.6.0 generate slightly better code.
8150 * ftfont.c: Distingish more carefully between FcChar8 and char.
8151 The previous code passed unsigned char * to a functions like
8152 strlen and xstrcasecmp that expect char *, which does not
8153 conform to the C standard.
8154 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8155 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8156 char * when the C standard requires it.
8158 * keyboard.c (read_char): Remove unused var.
8160 * eval.c: Port to Windows vsnprintf (Bug#8435).
8162 (SIZE_MAX): Define if the headers do not.
8163 (verror): Do not give up if vsnprintf returns a negative count.
8164 Instead, grow the buffer. This ports to Windows vsnprintf, which
8165 does not conform to C99. Problem reported by Eli Zaretskii.
8166 Also, simplify the allocation scheme, by avoiding the need for
8167 calling realloc, and removing the ALLOCATED variable.
8169 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8171 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8172 But keep the doprint source code for now, as we might revamp it
8173 and use it again (Bug#8435).
8174 * lisp.h (doprnt): Remove.
8175 * Makefile.in (base_obj): Remove doprnt.o.
8176 * deps.mk (doprnt.o): Remove.
8178 error: Print 32- and 64-bit integers portably (Bug#8435).
8179 Without this change, on typical 64-bit hosts error ("...%d...", N)
8180 was used to print both 32- and 64-bit integers N, which relied on
8182 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
8183 * lisp.h (error, verror): Mark as printf-like functions.
8184 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8185 Report overflow in size calculations when allocating printf buffer.
8186 Do not truncate output string at its first null byte.
8187 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8188 Truncate the output at a character boundary, since vsnprintf does not
8190 * charset.c (check_iso_charset_parameter): Convert internal
8191 character to string before calling 'error', since %c now has the
8193 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8194 overflow when computing char to be passed to 'error'. Do not
8195 pass Lisp_Object to 'error'; pass the integer instead.
8196 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8197 formatted with plain %d.
8199 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8201 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8203 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8205 * xterm.c (x_catch_errors): Remove duplicate declaration.
8207 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8209 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8211 2011-04-10 Jim Meyering <meyering@redhat.com>
8213 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8214 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8215 return ssize_t not "int", and use size_t as the buffer length.
8216 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8217 * gnutls.h: Update declarations.
8218 * process.c (read_process_output): Use ssize_t, to match.
8219 (send_process): Likewise.
8221 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8223 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8225 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8227 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8228 Use unsigned char, to match FcChar8 type definition.
8230 * xterm.c (handle_one_xevent):
8231 * xmenu.c (create_and_show_popup_menu):
8232 * xselect.c (x_decline_selection_request)
8233 (x_reply_selection_request): Avoid type-punned deref of X events.
8235 2011-04-09 Eli Zaretskii <eliz@gnu.org>
8237 Fix some uses of `int' instead of EMACS_INT.
8238 * search.c (string_match_1, fast_string_match)
8239 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8240 (scan_buffer, find_next_newline_no_quit)
8241 (find_before_next_newline, search_command, Freplace_match)
8242 (Fmatch_data): Make some `int' variables be EMACS_INT.
8244 * xdisp.c (display_count_lines): 3rd argument and return value now
8245 EMACS_INT. All callers changed.
8246 (pint2hrstr): Last argument is now EMACS_INT.
8248 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8249 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8250 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8251 (decode_coding_utf_16, decode_coding_emacs_mule)
8252 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8253 (decode_coding_ccl, decode_coding_charset)
8254 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8255 (decode_coding_iso_2022, decode_coding_emacs_mule)
8256 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8257 <char_offset, last_offset>: Declare EMACS_INT.
8258 (encode_coding_utf_8, encode_coding_utf_16)
8259 (encode_coding_emacs_mule, encode_invocation_designation)
8260 (encode_designation_at_bol, encode_coding_iso_2022)
8261 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8262 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8264 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8265 (encode_invocation_designation): Last argument P_NCHARS is now
8267 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8268 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8270 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8273 * ccl.c (Fccl_execute_on_string): Declare some variables
8276 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
8278 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8280 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8282 * process.c (Fformat_network_address): Doc fix.
8284 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8286 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
8288 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
8290 * keyboard.c (read_char): Call Lisp function help-form-show,
8291 instead of using internal_with_output_to_temp_buffer.
8292 (Qhelp_form_show): New var.
8293 (syms_of_keyboard): Use DEFSYM macro.
8295 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8297 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8299 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
8301 * process.c (Flist_processes): Remove to Lisp.
8302 (list_processes_1): Delete.
8304 2011-04-06 Eli Zaretskii <eliz@gnu.org>
8306 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8308 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8310 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
8312 Fix more problems found by GCC 4.6.0's static checks.
8314 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8316 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8318 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
8320 * xdisp.c (vmessage): Mark as a printf-like function.
8322 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8324 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8326 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8327 printf-like functions.
8328 (tiff_load): Add casts to remove these marks before passing them
8329 to system-supplied API.
8331 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8333 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8334 This avoids several warnings with gcc -Wstrict-overflow.
8335 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8336 directly, rather than having caller test rule sign. This avoids
8337 some unnecessary tests.
8338 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8339 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8340 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
8342 * xfont.c (xfont_text_extents): Remove var that was set but not used.
8343 (xfont_open): Avoid unnecessary tests.
8345 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8347 * composite.h, composite.c (composition_gstring_put_cache):
8348 Use EMACS_INT, not int, for length.
8350 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8351 breaking out part of COMPOSITION_DECODE_RULE.
8352 (COMPOSITION_DECODE_RULE): Use it.
8353 * composite.c (get_composition_id): Remove unused local vars,
8354 by using the new macro.
8356 * textprop.c (set_text_properties_1): Change while to do-while,
8357 since the condition is always true at first.
8359 * intervals.c (graft_intervals_into_buffer): Mark var as used.
8360 (interval_deletion_adjustment): Return unsigned value.
8363 * process.c (list_processes_1, create_pty, read_process_output):
8364 (exec_sentinel): Remove vars that were set but not used.
8365 (create_pty): Remove unnecessary "volatile"s.
8366 (Fnetwork_interface_info): Avoid possibility of int overflow.
8367 (read_process_output): Do adaptive read buffering even if carryover.
8368 (read_process_output): Simplify nbytes computation if buffered.
8370 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8372 * syntax.c (scan_words): Remove var that was set but not used.
8373 (update_syntax_table): Use unsigned instead of int.
8375 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
8376 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
8377 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8379 * print.c (print_error_message): Avoid int overflow.
8381 * font.c (font_list_entities): Redo for clarity,
8382 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8384 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8385 (font_score): Avoid potential overflow in diff calculation.
8387 * fns.c (substring_both): Remove var that is set but not used.
8388 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8390 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8392 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8393 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8394 can always succeed if overflow has undefined behavior.
8396 * search.c (boyer_moore, wordify): Remove vars set but not used.
8397 (wordify): Omit three unnecessary tests.
8399 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8400 All callers changed. This avoids the need for an unused var.
8402 * casefiddle.c (casify_region): Remove var that is set but not used.
8404 * dired.c (file_name_completion): Remove var that is set but not used.
8406 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8408 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8409 (Finsert_file_contents): Remove unnecessary code checking fd.
8411 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8412 Check for integer overflow on size calculations.
8414 * buffer.c (Fprevious_overlay_change): Remove var that is set
8417 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8418 Remove vars that are set but not used.
8419 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8420 (timer_check_2): Mark vars as initialized.
8422 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8424 * image.c (lookup_image): Remove var that is set but not used.
8425 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8427 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8428 that are set but not used.
8430 * xfns.c (make_invisible_cursor): Don't return garbage
8431 if XCreateBitmapFromData fails (Bug#8410).
8433 * xselect.c (x_get_local_selection, x_handle_property_notify):
8434 Remove vars that are set but not used.
8436 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8437 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8439 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8440 Remove var that is set but not used.
8441 (scroll_bar_windows_size): Now size_t, not int.
8442 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8445 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8446 (map_tty_color) [!defined MSDOS]: Likewise.
8448 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8450 * coding.c: Remove vars that are set but not used.
8451 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8452 All callers changed.
8453 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8454 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8455 (decode_coding_charset): Remove vars that are set but not used.
8457 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8458 that is set but not used.
8460 * print.c (print_object): Remove var that is set but not used.
8462 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8463 The gnulib version avoids calling malloc in the usual case,
8464 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8465 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8466 * filelock.c (current_lock_owner): Likewise.
8467 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8468 * sysdep.c: Include allocator.h, careadlinkat.h.
8469 (emacs_no_realloc_allocator): New static constant.
8470 (emacs_readlink): New function.
8471 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8472 ../lib/careadlinkat.h.
8474 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8476 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8477 first non-nil return value).
8479 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8481 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8482 if not defined (Bug#8403).
8484 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8486 * xdisp.c (display_count_lines): Remove parameter `start',
8487 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8488 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8489 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8490 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8491 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8492 and thereabouts. All callers changed.
8493 (get_per_char_metric): Remove parameter `f', unused since
8494 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8496 2011-04-02 Jim Meyering <meyering@redhat.com>
8498 do not dereference NULL upon failed strdup
8499 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8500 (ns_get_family): Likewise.
8502 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8504 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8506 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8508 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8511 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8513 Add lexical binding.
8515 * window.c (Ftemp_output_buffer_show): New fun.
8516 (Fsave_window_excursion):
8517 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8519 * lread.c (lisp_file_lexically_bound_p): New function.
8520 (Fload): Bind Qlexical_binding.
8521 (readevalloop): Remove `evalfun' arg.
8522 Bind Qinternal_interpreter_environment.
8523 (Feval_buffer): Bind Qlexical_binding.
8524 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8526 (syms_of_lread): Declare `lexical-binding'.
8528 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8530 * keyboard.c (eval_dyn): New fun.
8531 (menu_item_eval_property): Use it.
8533 * image.c (parse_image_spec): Use Ffunctionp.
8535 * fns.c (concat, mapcar1): Accept byte-code-functions.
8537 * eval.c (Fsetq): Handle lexical vars.
8538 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8539 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8540 (FletX, Flet): Obey lexical binding.
8541 (Fcommandp): Handle closures.
8542 (Feval): New `lexical' arg.
8543 (eval_sub): New function extracted from Feval. Use it almost
8544 everywhere where Feval was used. Look up vars in lexical env.
8546 (Ffunctionp): Move from subr.el.
8547 (Ffuncall): Handle closures.
8548 (apply_lambda): Remove `eval_flags'.
8549 (funcall_lambda): Handle closures and new byte-code-functions.
8550 (Fspecial_variable_p): New function.
8551 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8552 but without exporting it to Lisp.
8554 * doc.c (Fdocumentation, store_function_docstring):
8555 * data.c (Finteractive_form): Handle closures.
8557 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8560 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8562 (exec_byte_code): New function extracted from Fbyte_code to handle new
8563 calling convention for byte-code-functions. Add new byte-codes.
8565 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8567 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8569 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8571 * xdisp.c (redisplay_internal): Fix prototype.
8573 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8575 * xdisp.c (SCROLL_LIMIT): New macro.
8576 (try_scrolling): Use it when setting scroll_limit.
8577 Limit scrolling to 100 screen lines.
8578 (redisplay_window): Even when falling back on "recentering",
8579 position point in the window according to scroll-conservatively,
8580 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8582 (try_scrolling): When point is above the window, allow searching
8583 as far as scroll_max, or one screenful, to compute vertical
8584 distance from PT to the scroll margin position. This prevents
8585 try_scrolling from unnecessarily failing when
8586 scroll-conservatively is set to a value slightly larger than the
8587 window height. Clean up the case of PT below the margin at bottom
8588 of window: scroll_max can no longer be INT_MAX. When aggressive
8589 scrolling is in use, don't let point enter the opposite scroll
8590 margin as result of the scroll.
8591 (syms_of_xdisp) <scroll-conservatively>: Document the
8592 threshold of 100 lines for never-recentering scrolling.
8594 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8596 * dispextern.h (move_it_by_lines):
8597 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8598 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8599 (message_log_check_duplicate): Remove parameters `prev_bol' and
8600 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8601 (redisplay_internal): Remove parameter `preserve_echo_area',
8602 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8604 * indent.c (Fvertical_motion):
8605 * window.c (window_scroll_pixel_based, Frecenter):
8606 Don't pass `need_y_p' to `move_it_by_lines'.
8608 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8610 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8611 steal a few bits to be more compact.
8612 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8613 Remove unneeded casts.
8615 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8617 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8619 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8620 binding" message (bug#7967).
8622 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8624 Fix more problems found by GCC 4.6.0's static checks.
8626 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8627 Remove unused local var.
8629 * editfns.c (Fmessage_box): Remove unused local var.
8631 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8632 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8633 Omit unused local vars.
8634 * window.c (shrink_windows): Omit unused local var.
8635 * menu.c (digest_single_submenu): Omit unused local var.
8636 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8637 Omit unused local var.
8639 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8640 Don't assume string length fits in int.
8641 (keyremap_step, read_key_sequence): Use size_t for sizes.
8642 (read_key_sequence): Don't check last_real_key_start redundantly.
8644 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8645 instead of alloca (Bug#8344).
8647 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8648 (Fbacktrace_frame): Don't assume nframes fits in int.
8650 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8652 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8655 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8657 * cm.c (calccost): Turn while-do into do-while, for clarity.
8659 * keyboard.c (syms_of_keyboard): Use the same style as later
8660 in this function when indexing through an array. This also
8661 works around GCC bug 48267.
8663 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8665 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8667 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8668 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8670 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8671 This avoids undefined behavior on integer overflow, and is a bit
8672 more convenient anyway since it is compared to a size_t variable.
8674 Variadic C functions now count arguments with size_t, not int.
8675 This avoids an unnecessary limitation on 64-bit machines, which
8676 caused (substring ...) to crash on large vectors (Bug#8344).
8677 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8678 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8679 All variadic functions and their callers changed accordingly.
8680 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8681 * data.c (arith_driver, float_arith_driver): Likewise.
8682 * editfns.c (general_insert_function): Likewise.
8683 * eval.c (struct backtrace.nargs, interactive_p)
8684 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8685 (funcall_lambda, mark_backtrace): Likewise.
8686 * fns.c (concat): Likewise.
8687 * frame.c (x_set_frame_parameters): Likewise.
8688 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8689 0 if not found, not -1. All callers changed.
8691 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8692 (stack_copy_size): Now size_t, not int.
8693 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8695 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8697 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8698 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8699 All callers changed.
8701 * lisp.h (multibyte_char_to_unibyte):
8702 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8703 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8704 * character.h (CHAR_TO_BYTE8):
8705 * cmds.c (internal_self_insert):
8706 * editfns.c (general_insert_function):
8707 * keymap.c (push_key_description):
8708 * search.c (Freplace_match):
8709 * xdisp.c (message_dolog, set_message_1): All callers changed.
8711 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8713 * keyboard.c (safe_run_hook_funcall): New function.
8714 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8715 don't set the hook to nil, but remove the offending function instead.
8716 (Qcommand_hook_internal): Remove, unused.
8717 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8718 Vcommand_hook_internal.
8720 * eval.c (enum run_hooks_condition): Remove.
8721 (funcall_nil, funcall_not): New functions.
8722 (run_hook_with_args): Call each function through a `funcall' argument.
8723 Remove `cond' argument, now redundant.
8724 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8725 (Frun_hook_with_args_until_failure): Adjust accordingly.
8726 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8728 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8730 * dispextern.h (string_buffer_position): Remove declaration.
8732 * print.c (strout): Remove parameter `multibyte', unused since
8733 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8735 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8736 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8737 All callers changed.
8739 * w32.c (_wsa_errlist): Use braces for struct initializers.
8741 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8742 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8743 All callers changed.
8744 (string_buffer_position): Likewise. Also, make static (it's never
8745 used outside xdisp.c).
8746 (cursor_row_p): Remove parameter `w', unused since
8747 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8748 (decode_mode_spec): Remove parameter `precision', introduced during
8749 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8750 All callers changed.
8752 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8754 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8756 2011-03-27 Anders Lindgren <andlind@gmail.com>
8758 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8759 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8760 (ns_update_auto_hide_menu_bar): New functions.
8761 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8762 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8763 ns_constrain_all_frames.
8764 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8765 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8767 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8769 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8771 2011-03-27 Glenn Morris <rgm@gnu.org>
8773 * syssignal.h: Replace RETSIGTYPE with void.
8774 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8775 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8776 Replace SIGTYPE with void everywhere.
8777 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8778 * s/template.h (SIGTYPE): Remove commented out definition.
8780 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8782 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8783 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8785 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8787 * w32.c (read_unc_volume): Use parameter `henum', instead of
8788 global variable `wget_enum_handle'.
8790 * keymap.c (describe_vector): Remove parameters `indices' and
8791 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8792 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8794 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8796 * keyboard.c (timer_check): Remove parameter `do_it_now',
8797 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8798 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8799 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8801 * keyboard.c (read_char):
8802 * w32menu.c (w32_menu_display_help):
8803 * xmenu.c (show_help_event, menu_help_callback):
8804 Adjust calls to `show_help_echo'.
8806 * gtkutil.c (xg_maybe_add_timer):
8807 * keyboard.c (readable_events):
8808 * process.c (wait_reading_process_output):
8809 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8811 * insdel.c (adjust_markers_gap_motion):
8812 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8813 (gap_left, gap_right): Don't call it.
8815 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8817 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8818 incurred during fontification.
8820 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8822 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8823 (DEFVAR_PER_BUFFER): Don't pass it.
8825 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8826 (scrolling_window): Don't pass it.
8828 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8830 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8832 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8834 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8835 of variables specific to SELinux and computation of `encoded_absname'.
8837 * image.c (XPutPixel): Remove unused variable `height'.
8839 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8841 * unexw32.c (get_section_info): Remove unused variable `section'.
8843 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8844 (system_process_attributes): Remove unused variable `sess'.
8845 (sys_read): Remove unused variable `err'.
8847 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8848 (w32_wnd_proc): Remove unused variable `isdead'.
8849 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8850 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8851 (x_create_tip_frame): Remove unused variable `tem'.
8853 * w32inevt.c (w32_console_read_socket):
8854 Remove unused variable `no_events'.
8856 * w32term.c (x_draw_composite_glyph_string_foreground):
8857 Remove unused variable `width'.
8859 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8861 * w32term.c (x_set_glyph_string_clipping):
8862 Don't pass uninitialized region to CombineRgn.
8864 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8866 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8867 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8868 (Fx_close_connection): Remove unused variable `i'.
8870 * w32font.c (w32font_draw): Return number of glyphs.
8871 (w32font_open_internal): Remove unused variable `i'.
8872 (w32font_driver): Add missing initializer.
8874 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8875 (fill_in_menu): Remove unused variable `items_added'.
8877 * w32term.c (last_mouse_press_frame): Remove static global variable.
8878 (w32_clip_to_row): Remove unused variable `f'.
8879 (x_delete_terminal): Remove unused variable `i'.
8881 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8882 (NOTHING): Remove unused static global variable.
8883 (uniscribe_check_otf): Remove unused variable `table'.
8884 (uniscribe_font_driver): Add missing initializers.
8886 2011-03-23 Julien Danjou <julien@danjou.info>
8888 * term.c (Fsuspend_tty, Fresume_tty):
8889 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8890 * window.c (temp_output_buffer_show):
8891 * insdel.c (signal_before_change):
8892 * frame.c (Fhandle_switch_frame):
8893 * fileio.c (Fdo_auto_save):
8894 * emacs.c (Fkill_emacs):
8895 * editfns.c (save_excursion_restore):
8896 * cmds.c (internal_self_insert):
8897 * callint.c (Fcall_interactively):
8898 * buffer.c (Fkill_all_local_variables):
8899 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8901 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8902 unconditionally since it does the check itself.
8904 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8906 Fix more problems found by GCC 4.5.2's static checks.
8908 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8909 the first time through the loop, since we know p0 < p1 then.
8910 This also avoids a gcc -Wstrict-overflow warning.
8912 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8913 leading to a memory leak, possible in functions like
8914 load_charset_map_from_file that can allocate an unbounded number
8915 of objects (Bug#8318).
8917 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8918 that could (at least in theory) be that large.
8920 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8921 This is less likely to overflow, and avoids undefined behavior if
8922 overflow does occur. All callers changed. Use strtoul to scan
8923 for the unsigned long integer.
8924 (pint2hrstr): Simplify and tune code slightly.
8925 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8927 * scroll.c (do_scrolling): Work around GCC bug 48228.
8928 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8930 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8931 This also avoids a warning with gcc -Wstrict-overflow.
8932 (validate_x_resource_name): Simplify count usage.
8933 This also avoids a warning with gcc -Wstrict-overflow.
8935 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8938 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8940 * process.c (Fmake_network_process): Use socklen_t, not int,
8941 where POSIX says socklen_t is required in portable programs.
8942 This fixes a porting bug on hosts like 64-bit HP-UX, where
8943 socklen_t is wider than int (Bug#8277).
8944 (Fmake_network_process, server_accept_connection):
8945 (wait_reading_process_output, read_process_output):
8948 * process.c: Rename or move locals to avoid shadowing.
8949 (list_processes_1, Fmake_network_process):
8950 (read_process_output_error_handler, exec_sentinel_error_handler):
8951 Rename or move locals.
8952 (Fmake_network_process): Define label "retry_connect" only if needed.
8953 (Fnetwork_interface_info): Fix pointer signedness.
8954 (process_send_signal): Add cast to avoid pointer signedness problem.
8955 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8956 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8958 Make tparam.h and terminfo.c consistent.
8959 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8960 Include tparam.h instead, since it declares them.
8961 * cm.h (PC): Remove extern decl; tparam.h now does this.
8962 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8963 * terminfo.c: Include tparam.h, to check interfaces.
8964 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8965 (tparam): Adjust signature to match interface in tparam.h;
8966 this removes some undefined behavior. Check that outstring and len
8967 are zero, which they always are with Emacs.
8968 * tparam.h (PC, BC, UP): New extern decls.
8970 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8971 (xftfont_open): Rename locals to avoid shadowing.
8973 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8974 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8975 (OTF_TAG_SYM): Omit macro if not needed.
8976 (ftfont_list): Remove unused local.
8977 (get_adstyle_property, ftfont_pattern_entity):
8978 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8979 Rename locals to avoid shadowing.
8981 * xfont.c (xfont_list_family): Mark var as initialized.
8983 * xml.c (make_dom): Now static.
8985 * composite.c (composition_compute_stop_pos): Rename local to
8987 (composition_reseat_it): Remove unused locals.
8988 (find_automatic_composition, composition_adjust_point): Likewise.
8989 (composition_update_it): Mark var as initialized.
8990 (find_automatic_composition): Mark vars as initialized,
8991 with a FIXME (Bug#8290).
8993 character.h: Rename locals to avoid shadowing.
8994 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8995 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8996 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8997 (BUF_DEC_POS): Be more systematic about renaming local temporaries
9000 * textprop.c (property_change_between_p): Remove; unused.
9002 * intervals.c (interval_start_pos): Now static.
9004 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
9006 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
9007 Rename locals to avoid shadowing.
9009 * sound.c (wav_play, au_play, Fplay_sound_internal):
9010 Fix pointer signedness.
9011 (alsa_choose_format): Remove unused local var.
9012 (wav_play): Initialize a variable to 0, to prevent undefined
9013 behavior (Bug#8278).
9015 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
9017 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
9019 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
9020 clobbering (Bug#8298).
9021 * sysdep.c (sys_subshell): Likewise.
9022 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
9024 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
9025 This should get cleaned up, so that child_setup has the
9026 same signature on all platforms.
9028 * callproc.c (call_process_cleanup): Now static.
9029 (relocate_fd): Rename locals to avoid shadowing.
9031 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
9033 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
9034 not to be necessary, and produces flickering.
9036 2011-03-20 Glenn Morris <rgm@gnu.org>
9038 * config.in: Remove file.
9040 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
9042 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
9043 are now in src/globals.h.
9044 (syms_of_minibuf): Remove spurious & from previous change.
9046 2011-03-20 Leo Liu <sdl.web@gmail.com>
9048 * minibuf.c (completing-read-function): New variable.
9049 (completing-read-default): Rename from completing-read.
9050 (completing-read): Call completing-read-function.
9052 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9054 * xfaces.c (Fx_load_color_file):
9055 Read color file from absolute filename (bug#8250).
9057 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
9059 * makefile.w32-in: Update dependencies.
9061 2011-03-17 Eli Zaretskii <eliz@gnu.org>
9063 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
9065 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
9067 Fix more problems found by GCC 4.5.2's static checks.
9069 * process.c (make_serial_process_unwind, send_process_trap):
9070 (sigchld_handler): Now static.
9072 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
9073 That way, the code declares only the vars that it needs.
9074 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
9075 * s/cygwin.h (PTY_ITERATION): Likewise.
9076 * s/darwin.h (PTY_ITERATION): Likewise.
9077 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9079 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9080 * process.c (allocate_pty): Don't declare stb unless it's needed.
9082 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
9083 (CONSTANTLIM): Remove; unused.
9084 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9085 Define only if needed.
9087 * unexelf.c (unexec): Name an expression,
9088 to avoid gcc -Wbad-function-cast warning.
9089 Use a different way to cause a compilation error if anyone uses
9090 n rather than nn, a way that does not involve shadowing.
9091 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
9093 * deps.mk (unexalpha.o): Remove; unused.
9095 New file unexec.h, the (simple) interface for unexec (Bug#8267).
9096 * unexec.h: New file.
9097 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9098 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9100 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9101 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9102 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
9103 Change as necessary to match prototype in unexec.h.
9105 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9107 (back_comment, skip_chars): Mark vars as initialized.
9109 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9110 Rename locals to avoid shadowing.
9112 * lread.c (read1): Rewrite so as not to use empty "else".
9113 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
9115 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9117 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9118 warning when compiling print.c.
9120 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9121 instead of using an uninitialized var.
9122 (font_sort_entities): Mark var as initialized.
9124 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9126 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9127 pointers to constants.
9128 (font_parse_fcname): Remove unused vars.
9129 (font_delete_unmatched): Now static.
9130 (font_get_spec): Remove; unused.
9131 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9132 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9133 Rename or move locals to avoid shadowing.
9135 * fns.c (require_nesting_list, require_unwind): Now static.
9136 (Ffillarray): Rename locals to avoid shadowing.
9138 * floatfns.c (domain_error2): Define only if needed.
9139 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
9141 * alloc.c (mark_backtrace): Move decl from here ...
9142 * lisp.h: ... to here, so that it can be checked.
9144 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
9145 (Fdefvar): Rewrite so as not to use empty "else".
9146 (lisp_indirect_variable): Name an expression,
9147 to avoid gcc -Wbad-function-cast warning.
9148 (Fdefvar): Rename locals to avoid shadowing.
9150 * callint.c (quotify_arg, quotify_args): Now static.
9151 (Fcall_interactively): Rename locals to avoid shadowing.
9152 Use const pointer when appropriate.
9154 * lisp.h (get_system_name, get_operating_system_release):
9155 Move decls here, to check interfaces.
9156 * process.c (get_operating_system_release): Move decl to lisp.h.
9157 * xrdb.c (get_system_name): Likewise.
9158 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9159 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9160 some of which prompt warnings from gcc -Wbad-function-cast.
9161 (Fformat_time_string, Fencode_time, Finsert_char):
9162 (Ftranslate_region_internal, Fformat):
9163 Rename or remove local vars to avoid shadowing.
9164 (Ftranslate_region_internal): Mark var as initialized.
9166 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9169 * lisp.h (eassert): Check that the argument compiles, even if
9170 ENABLE_CHECKING is not defined.
9172 * data.c (Findirect_variable): Name an expression, to avoid
9173 gcc -Wbad-function-cast warning.
9174 (default_value, arithcompare, arith_driver, arith_error): Now static.
9175 (store_symval_forwarding): Rename local to avoid shadowing.
9176 (Fmake_variable_buffer_local, Fmake_local_variable):
9177 Mark variables as initialized.
9178 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
9180 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
9181 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9182 Rename locals to avoid shadowing.
9183 (mark_stack): Move local variables into the #ifdef region where
9185 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9186 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9188 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9189 (GC_STRING_CHARS): Remove; not used.
9190 (Fmemory_limit): Cast sbrk's returned value to char *.
9192 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9193 avoids undefined behavior in theory.
9195 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9197 Use functions, not macros, for up- and down-casing (Bug#8254).
9198 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9199 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9200 to use the following functions instead of these macros.
9201 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9202 EMACS_INT, since callers assume the returned value fits in int.
9203 (upcase1): Likewise, for UPCASE_TABLE.
9204 (uppercasep, lowercasep, upcase): New static inline functions.
9205 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
9206 the race-condition problem in the old DOWNCASE.
9208 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9209 Rename locals to avoid shadowing.
9210 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
9211 (regex_compile, re_search_2, re_match_2_internal):
9212 Remove unused local vars.
9213 (FREE_VAR): Rewrite so as not to use empty "else",
9214 which gcc can warn about.
9215 (regex_compile, re_match_2_internal): Mark locals as initialized.
9216 (RETALLOC_IF): Define only if needed.
9217 (WORDCHAR_P): Likewise. This one is never needed, but is used
9218 only in a comment talking about a compiler bug, so put inside
9219 the #if 0 of that comment.
9220 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9221 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9224 * search.c (boyer_moore): Rename locals to avoid shadowing.
9225 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9226 (PREV_CHAR_BOUNDARY): Likewise.
9228 * search.c (simple_search): Remove unused var.
9230 * dired.c (compile_pattern): Move decl from here ...
9231 * lisp.h: ... to here, so that it can be checked.
9232 (struct re_registers): New forward decl.
9234 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9236 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9238 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9239 Rename locals to avoid shadowing.
9240 (Fvertical_motion): Mark locals as initialized.
9242 * casefiddle.c (casify_object, casify_region): Now static.
9243 (casify_region): Mark local as initialized.
9245 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9247 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9248 New macros, so that the caller can use some names other than
9249 gcpro1, gcpro2, etc.
9250 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9252 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9253 argument, for consistency with GCPRO2_VAR, etc: it is now the
9254 prefix of the variable, not the variable itself. All uses
9256 * dired.c (directory_files_internal, file_name_completion):
9257 Rename locals to avoid shadowing.
9259 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9260 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9261 dired.c's scmp function, had undefined behavior.
9262 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9263 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9264 * buffer.h: ... to here, because these macros use current_buffer,
9265 and the new implementation with inline functions needs to have
9266 current_buffer in scope now, rather than later when the macros
9268 (downcase, upcase1): New static inline functions.
9269 (DOWNCASE, UPCASE1): Reimplement using these functions.
9270 This avoids undefined behavior in expressions like
9271 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9272 from race conditions in accessing the global variables
9273 case_temp1 and case_temp2.
9274 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9275 * lisp.h (case_temp1, case_temp2): Remove their decls.
9276 * character.h (ASCII_CHAR_P): Move from here ...
9277 * lisp.h: ... to here, so that the inline functions mentioned
9280 * dired.c (directory_files_internal_unwind): Now static.
9282 * fileio.c (file_name_as_directory, directory_file_name):
9283 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9285 (file_name_as_directory): Use const pointers when appropriate.
9286 (Fexpand_file_name): Likewise. In particular, newdir might
9287 point at constant storage, so make it a const pointer.
9288 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
9289 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9291 (Fset_file_times, Finsert_file_contents, auto_save_error):
9292 Rename locals to avoid shadowing.
9294 * minibuf.c (choose_minibuf_frame_1): Now static.
9295 (Ftry_completion, Fall_completions): Rename or remove locals
9298 * marker.c (bytepos_to_charpos): Remove; unused.
9300 * lisp.h (verify_bytepos, count_markers): New decls,
9301 so that gcc does not warn that these functions aren't declared.
9303 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9304 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
9305 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
9306 (copy_text): Remove unused local var.
9308 * filelock.c (within_one_second): Now static.
9309 (lock_file_1): Rename local to avoid shadowing.
9311 * buffer.c (fix_overlays_before): Mark locals as initialized.
9312 (fix_start_end_in_overlays): Likewise. This function should be
9313 simplified by using pointers-to-pointers, but that's a different
9315 (switch_to_buffer_1): Now static.
9316 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9317 (report_overlay_modification): Rename locals to avoid shadowing.
9319 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
9320 Fix pointer signedness issue.
9321 (sys_subshell): Mark local as volatile if checking for lint,
9322 to suppress a gcc -Wclobbered warning that does not seem to be right.
9323 (MAXPATHLEN): Define only if needed.
9325 * process.c (serial_open, serial_configure): Move decls from here ...
9326 * systty.h: ... to here, so that they can be checked.
9328 * fns.c (get_random, seed_random): Move extern decls from here ...
9329 * lisp.h: ... to here, so that they can be checked.
9331 * sysdep.c (reset_io): Now static.
9332 (wait_for_termination_signal): Remove; unused.
9334 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9335 (copy_keymap_item, append_key, push_text_char_description):
9337 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
9338 (DENSE_TABLE_SIZE): Remove; unused.
9339 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9340 (describe_map_tree):
9341 Rename locals to avoid shadowing.
9343 * keyboard.c: Declare functions static if they are not used elsewhere.
9344 (echo_char, echo_dash, cmd_error, top_level_2):
9345 (poll_for_input, handle_async_input): Now static.
9346 (read_char, kbd_buffer_get_event, make_lispy_position):
9347 (make_lispy_event, make_lispy_movement, apply_modifiers):
9348 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9349 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9350 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
9351 (read_key_sequence, read_char): Mark locals as initialized.
9352 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
9354 * keyboard.h (make_ctrl_char): New decl.
9355 (mark_kboards): Move decl here ...
9356 * alloc.c (mark_kboards): ... from here.
9358 * lisp.h (force_auto_save_soon): New decl.
9360 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
9361 (DEFINE_DUMMY_FUNCTION): New macro.
9362 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9364 (main): Add casts to avoid warnings
9365 if GCC considers string literals to be constants.
9367 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9369 * dbusbind.c: Pointer signedness fixes.
9370 (xd_signature, xd_append_arg, xd_initialize):
9371 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9372 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9373 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9374 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9376 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9377 if GCC considers string literals to be constants.
9378 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9380 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9382 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9383 (print_preprocess, print_object): New macro to fix last change.
9385 * print.c (print_preprocess): Don't forget font objects.
9387 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9389 * emacs.c (USAGE3): Doc fixes.
9391 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9393 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9396 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9398 * lisp.h (VWindow_system, Qfile_name_history):
9399 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9400 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9401 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9403 * w32select.c: Don't #include "keyboard.h".
9404 (run_protected): Add extern declaration for waiting_for_input.
9406 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9407 * w32console.c (detect_input_pending, read_input_pending)
9408 (encode_terminal_code):
9409 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9410 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9411 (w32_system_caret_y, Qfile_name_history):
9412 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9413 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9414 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9415 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9416 * w32proc.c (Qlocal, report_file_error):
9417 * w32term.c (Vwindow_system, updating_frame):
9418 * w32uniscribe.c (initialized, uniscribe_font_driver):
9419 Remove unneeded extern declarations.
9421 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9423 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9425 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9427 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9428 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9429 These macros can no longer be used for assignment.
9431 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9432 Assign struct members directly, instead of using BUF_BEGV etc.
9433 (record_buffer_markers, fetch_buffer_markers): New functions for
9434 recording and fetching special buffer markers.
9435 (set_buffer_internal_1, set_buffer_temp): Use them.
9437 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9439 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9441 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9442 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9444 * xdisp.c (hscroll_window_tree):
9445 (reconsider_clip_changes): Use PT instead of BUF_PT.
9447 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9449 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9450 $(EMACS_ROOT)/lib/intprops.h.
9452 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9454 Fix more problems found by GCC 4.5.2's static checks.
9456 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9457 to unsigned char * to avoid compiler diagnostic.
9458 (xg_free_frame_widgets): Make it clear that a local variable is
9459 needed only if USE_GTK_TOOLTIP.
9460 (gdk_window_get_screen): Make it clear that this macro is needed
9461 only if USE_GTK_TOOLTIP.
9462 (int_gtk_range_get_value): New function, which avoids a diagnostic
9463 from gcc -Wbad-function-cast.
9464 (xg_set_toolkit_scroll_bar_thumb): Use it.
9465 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9466 diagnostic from gcc -Wbad-function-cast.
9467 (get_utf8_string, xg_get_file_with_chooser):
9468 Rename locals to avoid shadowing.
9469 (create_dialog): Move locals to avoid shadowing.
9471 * xgselect.c (xg_select): Remove unused var.
9473 * image.c (four_corners_best): Mark locals as initialized.
9474 (gif_load): Initialize transparent_p to zero (Bug#8238).
9475 Mark another local as initialized.
9476 (my_png_error, my_error_exit): Mark with NO_RETURN.
9478 * image.c (clear_image_cache): Now static.
9479 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9480 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9481 (x_edge_detection): Remove unnecessary cast that
9482 gcc -Wbad-function-cast diagnoses.
9483 (gif_load): Fix pointer signedness.
9484 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9485 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9487 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9489 Improve quality of tests for time stamp overflow.
9490 For example, without this patch (encode-time 0 0 0 1 1
9491 1152921504606846976) returns the obviously-bogus value (-948597
9492 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9493 reports time overflow. See
9494 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9495 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9496 * editfns.c: Include limits.h and intprops.h.
9497 (TIME_T_MIN, TIME_T_MAX): New macros.
9498 (time_overflow): Move earlier, to before first use.
9499 (hi_time, lo_time): New functions, for an accurate test for
9501 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9502 (Fget_internal_run_time): Don't assume time_t fits in int.
9503 (make_time): Use list2 instead of Fcons twice.
9504 (Fdecode_time): More accurate test for out-of-range times.
9505 (check_tm_member): New function.
9506 (Fencode_time): Use it, to test for out-of-range times.
9507 (lisp_time_argument): Don't rely on undefined left-shift and
9508 right-shift behavior when checking for time stamp overflow.
9510 * editfns.c (time_overflow): New function, refactoring common code.
9511 (Fformat_time_string, Fdecode_time, Fencode_time):
9512 (Fcurrent_time_string): Use it.
9514 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9515 * dired.c (make_time): Move to ...
9516 * editfns.c (make_time): ... here.
9517 * systime.h: Note the move.
9519 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9521 * fringe.c (update_window_fringes): Remove unused variables.
9523 * unexmacosx.c (copy_data_segment): Also copy __got section.
9526 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9528 * termcap.c [MSDOS]: Include "msdos.h".
9529 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9530 Constify `char *' arguments and their references according to
9531 prototypes in tparam.h.
9533 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9535 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9536 Adapt all references accordingly.
9538 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9540 2011-03-11 Tom Tromey <tromey@redhat.com>
9542 * buffer.c (syms_of_buffer): Remove obsolete comment.
9544 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9546 * termhooks.h (encode_terminal_code): Declare prototype.
9548 * msdos.c (encode_terminal_code): Don't declare prototype.
9550 * term.c (encode_terminal_code): Now external again, used by
9551 w32console.c and msdos.c.
9553 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9554 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9556 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9558 Fix some minor problems found by GCC 4.5.2's static checks.
9560 * fringe.c (update_window_fringes): Mark locals as initialized
9562 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9564 * alloc.c (mark_fringe_data): Move decl from here ...
9565 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9566 to check its interface.
9567 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9569 * fontset.c (free_realized_fontset): Now static.
9570 (Fset_fontset_font): Rename local to avoid shadowing.
9571 (fontset_font): Mark local as initialized.
9572 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9574 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9576 * xselect.c (x_disown_buffer_selections): Remove; not used.
9577 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9578 (x_own_selection, Fx_disown_selection_internal): Rename locals
9580 (x_handle_dnd_message): Remove local to avoid shadowing.
9582 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9583 so that the caller can use some name other than gcpro1.
9584 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9585 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9586 (Fx_backspace_delete_keys_p):
9587 Use them to avoid shadowing, and rename vars to avoid shadowing.
9588 (x_decode_color, x_set_name, x_window): Now static.
9589 (Fx_create_frame): Add braces to silence GCC warning.
9590 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9591 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9592 Remove unused locals.
9593 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9594 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9595 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9598 * xterm.h (x_mouse_leave): New decl.
9600 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9601 Remove unused functions.
9602 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9603 (x_calc_absolute_position): Now static.
9604 (XTread_socket): Don't define label "out" unless it's used.
9605 Don't declare local "event" unless it's used.
9606 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9607 unless they are used.
9608 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9609 (x_fatal_error_signal): Remove; not used.
9610 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9611 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9612 (x_error_catcher, x_connection_closed, x_error_handler):
9613 (x_error_quitter, xembed_send_message, x_iconify_frame):
9614 (my_log_handler): Rename locals to avoid shadowing.
9615 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9616 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9618 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9619 Rename or move locals to avoid shadowing.
9620 (tty_defined_color, merge_face_heights): Now static.
9621 (free_realized_faces_for_fontset): Remove; not used.
9622 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9623 does not deduce is never used uninitialized.
9624 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9625 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9627 * terminal.c (store_terminal_param): Now static.
9629 * xmenu.c (menu_highlight_callback): Now static.
9630 (set_frame_menubar): Remove unused local.
9631 (xmenu_show): Rename parameter to avoid shadowing.
9632 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9633 since they might point to immutable storage.
9634 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9635 since it's unused otherwise.
9637 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9638 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9639 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9640 avoids a gcc -Wuninitialized diagnostic.
9641 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9642 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9643 does not deduce are never used uninitialized.
9645 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9647 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9648 * window.c (window_loop, size_window):
9649 (run_window_configuration_change_hook, enlarge_window): Likewise.
9651 * window.c (display_buffer): Now static.
9652 (size_window): Mark variables that gcc -Wuninitialized
9653 does not deduce are never used uninitialized.
9654 * window.h (check_all_windows): New decl, to forestall
9655 gcc -Wmissing-prototypes diagnostic.
9656 * dispextern.h (bidi_dump_cached_states): Likewise.
9658 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9660 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9662 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9663 and to avoid gcc -Wuninitialized warning.
9664 (load_charset_map): Mark variables that gcc -Wuninitialized
9665 does not deduce are never used uninitialized.
9666 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9668 * coding.c (coding_set_source, coding_set_destination):
9669 Use "else { /* comment */ }" rather than "else /* comment */;"
9670 for clarity, and to avoid gcc -Wempty-body warning.
9671 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9672 a block, when the outer 'i' will do.
9673 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9674 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9675 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9676 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9677 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9678 Rename locals to avoid shadowing.
9679 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9680 * coding.c (emacs_mule_char, encode_invocation_designation):
9681 Now static, since they're not used elsewhere.
9682 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9683 (decode_coding_object, encode_coding_object, detect_coding_system):
9684 (decode_coding_emacs_mule): Mark variables that gcc
9685 -Wuninitialized does not deduce are never used uninitialized.
9686 (detect_coding_iso_2022): Initialize a local variable that might
9687 be used uninitialized. Leave a FIXME because it's not clear that
9688 this initialization is needed. (Bug#8211)
9689 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9690 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9691 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9692 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9693 Remove unused macros.
9695 * category.c (hash_get_category_set): Remove unused local var.
9696 (copy_category_table): Now static, since it's not used elsewhere.
9697 * character.c (string_count_byte8): Likewise.
9699 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9700 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9702 * chartab.c (copy_sub_char_table): Now static, since it's not used
9704 (sub_char_table_ref_and_range, char_table_ref_and_range):
9705 Rename locals to avoid shadowing.
9706 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9708 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9709 (BIDI_BOB): Remove unused macro.
9711 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9712 deduce are never used uninitialized.
9713 * term.c (encode_terminal_code): Likewise.
9715 * term.c (encode_terminal_code): Now static. Remove unused local.
9717 * tparam.h: New file.
9718 * term.c, tparam.h: Include it.
9719 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9720 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9721 Move these decls to tparam.h, and make them agree with what
9722 is actually in tparam.c. The previous trick of using incompatible
9723 decls in different modules does not conform to the C standard.
9724 All callers of tparam changed to use tparam's actual API.
9725 * tparam.c (tparam1, tparam, tgoto):
9726 Use const pointers where appropriate.
9728 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9729 * cm.h (struct cm): Likewise.
9730 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9731 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9732 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9733 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9734 (turn_on_face, init_tty): Likewise.
9735 * termchar.h (struct tty_display_info): Likewise.
9737 * term.c (term_mouse_position): Rename local to avoid shadowing.
9739 * alloc.c (mark_ttys): Move decl from here ...
9740 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9742 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9744 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9746 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9748 * search.c (compile_pattern_1): Remove argument regp, unused since
9749 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9750 (compile_pattern): Don't pass it.
9752 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9754 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9755 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9757 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9759 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9761 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9762 gdk_window_get_screen, gdk_window_get_geometry,
9763 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9764 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9765 (xg_get_pixbuf_from_pixmap): New function.
9766 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9767 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9768 Call xg_get_pixbuf_from_pixmap instead of
9769 gdk_pixbuf_get_from_drawable.
9770 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9771 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9772 (xg_check_special_colors): Use GtkStyleContext and its functions
9774 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9775 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9776 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9777 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9778 Call gtk_widget_get_preferred_size.
9779 (xg_frame_resized): gdk_window_get_geometry only takes 5
9781 (xg_win_to_widget, xg_event_is_for_menubar):
9782 Call gdk_x11_window_lookup_for_display.
9783 (xg_set_widget_bg): New function.
9784 (delete_cb): New function.
9785 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9786 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9787 (xg_set_background_color): Call xg_set_widget_bg.
9788 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9789 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9790 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9791 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9793 (update_frame_tool_bar): Call gtk_widget_hide.
9794 (xg_initialize): Use GDK_KEY_g.
9796 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9798 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9800 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9801 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9802 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9804 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9806 * w32xfns.c (select_palette): Check success of RealizePalette against
9807 GDI_ERROR, not zero.
9809 See ChangeLog.11 for earlier changes.
9815 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9817 This file is part of GNU Emacs.
9819 GNU Emacs is free software: you can redistribute it and/or modify
9820 it under the terms of the GNU General Public License as published by
9821 the Free Software Foundation, either version 3 of the License, or
9822 (at your option) any later version.
9824 GNU Emacs is distributed in the hope that it will be useful,
9825 but WITHOUT ANY WARRANTY; without even the implied warranty of
9826 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9827 GNU General Public License for more details.
9829 You should have received a copy of the GNU General Public License
9830 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.