1 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3 * Makefile.in (gl-stamp): move-if-change is now in build-aux.
5 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
7 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
8 Found by GCC static checking and --with-wide-int on a 32-bit host.
10 2011-07-25 Eli Zaretskii <eliz@gnu.org>
12 * xdisp.c (compute_display_string_pos): Fix logic of caching
13 previous display string position. Initialize cached_prev_pos to
14 -1. Fixes slow-down at the beginning of a buffer.
16 2011-07-24 Eli Zaretskii <eliz@gnu.org>
18 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
19 for attrs[LFACE_FONTSET_INDEX].
21 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
23 * xml.c (parse_region): Remove unused local
24 that was recently introduced.
26 2011-07-23 Eli Zaretskii <eliz@gnu.org>
28 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
29 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
31 * xdisp.c (move_it_in_display_line_to): Record the best matching
32 position for TO_CHARPOS while scanning the line, and restore it on
33 exit if none of the characters scanned was an exact match. Fixes
34 vertical-motion and pos-visible-in-window-p under bidi redisplay
35 when exact match is impossible due to invisible text, and the
38 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
40 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
43 2011-07-22 Eli Zaretskii <eliz@gnu.org>
45 Fix a significant slow-down of cursor motion with C-n, C-p,
46 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
47 auto-repeat under bidi redisplay in fontified buffers.
48 * xdisp.c (compute_stop_pos_backwards): New function.
49 (next_element_from_buffer): Call compute_stop_pos_backwards to
50 find a suitable prev_stop when we find ourselves before
52 (reseat): Don't look for prev_stop, as that could mean a very long
54 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
55 <cached_disp_overlay_modiff>: Cache for last found display string
57 (compute_display_string_pos): Return the cached position if asked
58 about the same buffer in the same area of character positions, and
59 the buffer wasn't changed since the time the display string
62 2011-07-22 Eli Zaretskii <eliz@gnu.org>
64 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
65 is an integer, which is important for empty lines. (Bug#9149)
67 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
69 * frame.c (Fmodify_frame_parameters): In tty case, update the
70 default face if necessary (Bug#4238).
72 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
74 * editfns.c (Fstring_to_char): No need to explain what a character
75 is in the docstring (Bug#6576).
77 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
79 * xml.c (parse_region): Make sure we always return a tree.
81 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
83 * xml.c (parse_region): If a document contains only comments,
86 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
88 * xml.c (make_dom): Return comments, too.
90 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
93 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
94 and the surrounding thread.
95 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
96 rather than fgets, and retry after EINTR. Otherwise, 'emacs
97 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
99 * s/openbsd.h (BROKEN_SIGIO): Define.
100 * unexelf.c (unexec) [__OpenBSD__]:
101 Don't update the .mdebug section of the Alpha COFF symbol table.
103 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
105 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
108 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
110 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
111 This fixes some race conditions on the permissions of any newly
114 * alloc.c (valid_pointer_p): Use pipe, not open.
115 This fixes some permissions issues when debugging.
117 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
118 If fchown fails to set both uid and gid, try to set just gid,
119 as that is sometimes allowed. Adjust the file's mode to eliminate
120 setuid or setgid bits that are inappropriate if fchown fails.
122 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
124 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
125 to compare Lisp_Objects.
126 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
127 global_gnutls_log_level, don't mistake it for a Lisp_Object.
128 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
130 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
132 * lread.c (read_integer): Unread even EOF character.
133 (read1): Likewise. Properly record start position of symbol.
135 * lread.c (read1): Read `#:' as empty uninterned symbol if no
136 symbol character follows.
138 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
140 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
141 This works around a problem with the previous change to Fcopy_file.
142 Recent glibc declares fchown with __attribute__((warn_unused_result)),
143 and without this change, GCC might complain about discarding
144 fchown's return value.
146 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
148 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
150 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
152 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
154 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
156 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
157 it's used from the C level.
159 * process.c: Use the same condition for POLL_FOR_INPUT in both
160 keyboard.c and process.c (bug#1858).
162 2011-07-09 Lawrence Mitchell <wence@gmx.li>
164 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
165 (Fgnutls_boot): Use it.
167 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
169 * doc.c (Fsubstitute_command_keys): Revert last change.
171 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
173 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
174 quotes the next character, and doesn't affect other longer
175 sequences (bug#8935).
177 * lread.c (syms_of_lread): Clarify that is isn't only
178 `eval-buffer' and `eval-defun' that's affected by
179 `lexical-binding' (bug#8460).
181 2011-07-15 Eli Zaretskii <eliz@gnu.org>
183 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
184 bidi redisplay when a line includes both an image and is
187 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
189 Fix minor problems found by static checking.
190 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
191 (elsz): Now a signed constant, not a size_t var. We prefer signed
192 types to unsigned, to avoid integer comparison confusion. Without
193 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
194 "cannot optimize loop, the loop counter may overflow", a symptom
196 * indent.c (Fvertical_motion): Mark locals as initialized.
197 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
199 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
201 * search.c (Fre_search_backward): Mention `case-fold-search' in
202 all the re_search_* functions (bug#8138).
204 * keyboard.c (Fopen_dribble_file): Document when the file is
207 2011-07-14 Eli Zaretskii <eliz@gnu.org>
209 * bidi.c (bidi_dump_cached_states): Fix format of displaying
212 Support bidi reordering of display and overlay strings.
213 * xdisp.c (compute_display_string_pos)
214 (compute_display_string_end): Accept additional argument STRING.
215 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
216 (reseat_to_string): Initialize bidi_it->string.s and
217 bidi_it->string.schars.
218 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
219 NULL (avoids a crash in bidi_paragraph_init). Initialize
221 (init_iterator): Call bidi_init_it only of a valid
222 buffer position was specified. Initialize paragraph_embedding to
224 (reseat_to_string): Initialize the bidi iterator.
225 (display_string): If we need to ignore text properties of
226 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
227 original value of -1 will not work with bidi.)
228 (compute_display_string_pos): First arg is now struct
229 `text_pos *'; all callers changed. Support display properties on
231 (compute_display_string_end): Support display properties on Lisp
233 (init_iterator, reseat_1, reseat_to_string): Initialize the
234 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
235 when iterating on a string not from display properties).
236 (compute_display_string_pos, compute_display_string_end): Fix
237 calculation of the object to scan. Fixes an error when using
239 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
240 base_level_stop; instead, set base_level_stop to BEGV. Fixes
241 crashes in vertical-motion.
242 (next_element_from_buffer): Improve commentary for when
243 the iterator is before prev_stop.
244 (init_iterator): Initialize bidi_p from the default value of
245 bidi-display-reordering, not from buffer-local value. Use the
246 buffer-local value only if initializing for buffer iteration.
247 (handle_invisible_prop): Support invisible properties on strings
248 that are being bidi-reordered.
249 (set_iterator_to_next): Support bidi reordering of C strings and
251 (next_element_from_string): Support bidi reordering of Lisp
253 (handle_stop_backwards): Support Lisp strings as well.
254 (display_string): Support display of R2L glyph rows. Use
255 IT_STRING_CHARPOS when displaying from a Lisp string.
256 (init_iterator): Don't initialize it->bidi_p for strings
258 (reseat_to_string): Initialize it->bidi_p for strings here.
259 (next_element_from_string, next_element_from_c_string)
260 (next_element_from_buffer): Add xassert's for correspondence
261 between IT's object being iterated and it->bidi_it.string
263 (face_before_or_after_it_pos): Support bidi iteration.
264 (next_element_from_c_string): Handle the case of the first string
265 character that is not the first one in the visual order.
266 (get_visually_first_element): New function, refactored from common
267 parts of next_element_from_buffer, next_element_from_string, and
268 next_element_from_c_string.
269 (tool_bar_lines_needed, redisplay_tool_bar)
270 (display_menu_bar): Force left-to-right direction. Add a FIXME
271 comment for making that be controlled by a user option.
272 (push_it, pop_it): Save and restore the state of the
273 bidi iterator. Save and restore the bidi_p flag.
274 (pop_it): Iterate out of display property for string iteration as
276 (iterate_out_of_display_property): Support iteration over strings.
277 (handle_single_display_spec): Set up it->bidi_it for iteration
278 over a display string, and call bidi_init_it.
279 (handle_single_display_spec, next_overlay_string)
280 (get_overlay_strings_1, push_display_prop): Set up the bidi
281 iterator for displaying display or overlay strings.
282 (forward_to_next_line_start): Don't use the shortcut if
284 (back_to_previous_visible_line_start): If handle_display_prop
285 pushed the iterator stack, restore the internal state of the bidi
286 iterator by calling bidi_pop_it same number of times.
287 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
288 and we are bidi-iterating, don't decrement the iterator position;
289 instead, set the first_elt flag in the bidi iterator, to produce
291 (reseat_1): Remove redundant setting of string_from_display_prop_p.
292 (push_display_prop): xassert that we are iterating a buffer.
293 (push_it, pop_it): Save and restore paragraph_embedding member.
294 (handle_single_display_spec, next_overlay_string)
295 (get_overlay_strings_1, reseat_1, reseat_to_string)
296 (push_display_prop): Set up the `unibyte' member of bidi_it.string
297 correctly. Don't assume unibyte strings are not bidi-reordered.
298 (compute_display_string_pos)
299 (compute_display_string_end): Fix handling the case of C string.
300 (push_it, pop_it): Save and restore from_disp_prop_p.
301 (handle_single_display_spec, push_display_prop): Set the
302 from_disp_prop_p flag.
303 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
304 (pop_it): Call iterate_out_of_display_property only if we are
305 popping after iteration over a string that came from a display
306 property. Fix a typo in popping stretch info. Add an assertion
307 for verifying that the iterator position is in sync with the bidi
309 (handle_single_display_spec, get_overlay_strings_1)
310 (push_display_prop): Fix initialization of paragraph direction for
311 string when that of the parent object is not yet determined.
312 (reseat_1): Call bidi_init_it to resync the bidi
313 iterator with IT's position. (Bug#7616)
314 (find_row_edges): If ROW->start.pos gives position
315 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
316 (handle_stop, back_to_previous_visible_line_start, reseat_1):
317 Reset the from_disp_prop_p flag.
318 (SAVE_IT, RESTORE_IT): New macros.
319 (pos_visible_p, face_before_or_after_it_pos)
320 (back_to_previous_visible_line_start)
321 (move_it_in_display_line_to, move_it_in_display_line)
322 (move_it_to, move_it_vertically_backward, move_it_by_lines)
323 (try_scrolling, redisplay_window, display_line): Use them when
324 saving a temporary copy of the iterator and restoring it back.
325 (back_to_previous_visible_line_start, reseat_1)
326 (init_iterator): Empty the bidi cache "stack".
327 (move_it_in_display_line_to): If iterator ended up at
328 EOL, but we never saw any buffer positions smaller than
329 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
330 motion in bidi-reordered lines.
331 (move_it_in_display_line_to): Record prev_method and prev_pos
332 immediately before the call to set_iterator_to_next. Fixes cursor
333 motion in bidi-reordered lines with stretch glyphs and strings
334 displayed in margins. (Bug#8133) (Bug#8867)
335 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
337 (pos_visible_p): Support positions in bidi-reordered lines. Save
338 and restore bidi cache.
340 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
341 (bidi_paragraph_info): Delete unused struct.
342 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
343 (bidi_cache_start): New variable.
344 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
346 (bidi_cache_fetch_state, bidi_cache_search)
347 (bidi_cache_find_level_change, bidi_cache_iterator_state)
348 (bidi_cache_find, bidi_peek_at_next_level)
349 (bidi_level_of_next_char, bidi_find_other_level_edge)
350 (bidi_move_to_visually_next): Compare cache index with
351 bidi_cache_start rather than with zero.
352 (bidi_fetch_char): Accept new argument STRING; all callers
353 changed. Support iteration over a string. Support strings with
354 display properties. Support unibyte strings. Fix the type of
355 `len' according to what STRING_CHAR_AND_LENGTH expects.
356 (bidi_paragraph_init, bidi_resolve_explicit_1)
357 (bidi_resolve_explicit, bidi_resolve_weak)
358 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
359 iteration over a string.
360 (bidi_set_sor_type, bidi_resolve_explicit_1)
361 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
362 can now be zero (for strings); special values 0 and -1 were
363 changed to -1 and -2, respectively.
364 (bidi_char_at_pos): New function.
365 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
366 Call it instead of FETCH_MULTIBYTE_CHAR.
367 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
368 initialized to valid values.
369 (bidi_init_it): Don't initialize charpos and bytepos with invalid
371 (bidi_level_of_next_char): Allow the sentinel "position" to pass
372 the test for valid cached positions. Fix the logic for looking up
373 the sentinel state in the cache. GCPRO the Lisp string we are
375 (bidi_push_it, bidi_pop_it): New functions.
376 (bidi_initialize): Initialize the bidi cache start stack pointer.
377 (bidi_cache_ensure_space): New function, refactored from part of
378 bidi_cache_iterator_state. Don't assume the required size is just
379 one BIDI_CACHE_CHUNK away.
380 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
381 (bidi_count_bytes, bidi_char_at_pos): New functions.
382 (bidi_cache_search): Don't assume bidi_cache_last_idx is
383 always valid if bidi_cache_idx is valid.
384 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
385 is valid if it's going to be used.
386 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
387 (bidi_cache_fetch_state, bidi_cache_search)
388 (bidi_cache_find_level_change, bidi_cache_ensure_space)
389 (bidi_cache_iterator_state, bidi_cache_find)
390 (bidi_find_other_level_edge, bidi_cache_start_stack): All
391 variables related to cache indices are now EMACS_INT.
393 * dispextern.h (struct bidi_string_data): New structure.
394 (struct bidi_it): New member `string'. Make flag members be 1-bit
395 fields, and put them last in the struct.
396 (compute_display_string_pos, compute_display_string_end): Update
398 (bidi_push_it, bidi_pop_it): Add prototypes.
399 (struct iterator_stack_entry): New members bidi_p,
400 paragraph_embedding, and from_disp_prop_p.
401 (struct it): Member bidi_p is now a bit field 1 bit wide.
402 (bidi_shelve_cache, bidi_unshelve_cache): Declare
405 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
406 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
407 and vector-like objects.
409 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
410 cache around display iteration.
412 * window.c (Fwindow_end, window_scroll_pixel_based)
413 (displayed_window_lines, Frecenter): Save and restore the bidi
414 cache around display iteration.
416 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
418 * editfns.c (Fdelete_region): Clarify the use of the named
419 parameters (bug#6788).
421 2011-07-14 Martin Rudalics <rudalics@gmx.at>
423 * indent.c (Fvertical_motion): Set and restore w->pointm when
424 saving and restoring the window's buffer (Bug#9006).
426 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
428 * editfns.c (Fstring_to_char): Clarify just what is returned
429 (bug#6576). Text by Eli Zaretskii.
431 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
433 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
435 2011-07-13 Eli Zaretskii <eliz@gnu.org>
437 * buffer.c (mmap_find): Fix a typo.
439 2011-07-13 Johan Bockgård <bojohan@gnu.org>
441 Fix execution of x selection hooks.
442 * xselect.c (Qx_lost_selection_functions)
443 (Qx_sent_selection_functions): New vars.
444 (syms_of_xselect): DEFSYM them.
445 (x_handle_selection_request): Pass Qx_sent_selection_functions
446 rather than Vx_sent_selection_functions to Frun_hook_with_args.
447 (x_handle_selection_clear,x_clear_frame_selections):
448 Pass Qx_lost_selection_functions rather than
449 Vx_lost_selection_functions to Frun_hook_with_args.
451 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
453 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
454 The old code sometimes used this field without initializing it.
456 * alloc.c (gc_sweep): Don't read past end of array.
457 In theory, the old code could also have corrupted Emacs internals,
458 though it'd be very unlikely.
460 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
462 * character.c (Fcharacterp): Don't advertise optional ignored
465 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
467 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
470 * window.c (Fset_window_start): Doc fix (bug#4199).
471 (Fset_window_hscroll): Ditto.
473 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
475 Fix minor new problems caught by GCC 4.6.1.
476 * term.c (init_tty): Remove unused local.
477 * xsettings.c (store_monospaced_changed): Define this function only
478 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
481 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
483 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
485 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
487 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
488 are the mini-buffer and the echo area (bug#3320).
490 * term.c (init_tty): Remove support for supdup, c10 and perq
491 terminals, which are no longer supported (bug#1482).
493 2011-07-10 Johan Bockgård <bojohan@gnu.org>
495 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
497 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
499 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
500 for non-popups (Bug#3642).
502 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
504 * alloc.c (reset_malloc_hooks): Protoize.
505 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
506 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
507 * cm.c (losecursor): Likewise.
508 * data.c (fmod): Likewise.
509 * dispnew.c (swap_glyphs_in_rows): Likewise.
510 * emacs.c (memory_warning_signal): Likewise.
511 * floatfns.c (float_error): Likewise.
512 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
513 (otf_open, font_otf_capability, generate_otf_features)
514 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
516 * image.c (pbm_read_file): Likewise.
517 * indent.c (string_display_width): Likewise.
518 * intervals.c (check_for_interval, search_for_interval)
519 (inc_interval_count, count_intervals, root_interval)
520 (adjust_intervals_for_insertion, make_new_interval): Likewise.
521 * lread.c (defalias): Likewise.
522 * ralloc.c (r_alloc_check): Likewise.
523 * regex.c (set_image_of_range_1, set_image_of_range)
524 (regex_grow_registers): Likewise.
525 * sysdep.c (strerror): Likewise.
526 * termcap.c (valid_filename_p, tprint, main): Likewise.
527 * tparam.c (main): Likewise.
528 * unexhp9k800.c (run_time_remap, save_data_space)
529 (update_file_ptrs, read_header, write_header, calculate_checksum)
530 (copy_file, copy_rest, display_header): Likewise.
531 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
533 * xdisp.c (check_it): Likewise.
534 * xfaces.c (register_color, unregister_color, unregister_colors):
536 * xfns.c (print_fontset_result): Likewise.
537 * xrdb.c (member, fatal, main): Likewise.
539 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
541 Fix minor problems found by static checking (Bug#9031).
542 * chartab.c (char_table_set_range, map_sub_char_table):
543 Remove unused locals.
544 (uniprop_table): Now static.
545 * composite.c (_work_char): Remove unused static var.
547 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
549 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
551 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
553 * gtkutil.c (qttip_cb): Remove code without function.
555 2011-07-09 Eli Zaretskii <eliz@gnu.org>
557 * w32.c (pthread_sigmask): New stub.
559 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
561 Use pthread_sigmask, not sigprocmask (Bug#9010).
562 sigprocmask is portable only for single-threaded applications, and
563 Emacs can be multi-threaded when it uses GTK.
564 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
566 * callproc.c (Fcall_process):
567 * process.c (create_process):
568 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
569 Use pthread_sigmask, not sigprocmask.
571 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
573 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
574 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
577 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
579 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
580 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
581 (xg_hide_tooltip): Fix comment.
583 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
584 in registerServicesMenuSendTypes.
585 (validRequestorForSendType): Don't check ns_return_types.
587 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
590 2011-07-08 Jason Rumney <jasonr@gnu.org>
592 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
593 frame struct members of non-existent frames (Bug#6284).
595 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
597 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
598 variable firstTime not needed on OSX >= 10.6.
599 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
600 >= 10.5. Use setKnobProportion, setDoubleValue.
602 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
603 (MAC_OS_X_VERSION_10_5): Define if not defined.
604 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
605 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
606 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
608 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
609 cString and lossyCString on OSX >= 10.4
611 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
612 sizeToFit on OSX >= 10.2.
614 * nsimage.m (allocInitFromFile): Don't use deprecated method
615 bestRepresentationForDevice on OSX >= 10.6.
617 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
620 * emacs.c: Declare unexec_init_emacs_zone.
622 * nsgui.h: Fix compiler warning about gnulib redefining verify.
624 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
626 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
627 on svcsMenu (Bug#8842).
629 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
631 (Fns_list_services): Just return Qnil on 10.6, code not working there.
633 * nsterm.m (QUTF8_STRING): Declare.
634 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
635 (validRequestorForSendType): Return type is (id).
636 Change indexOfObjectIdenticalTo to indexOfObject.
637 Check if we have local selection before returning self (Bug#8842).
638 (writeSelectionToPasteboard): Put local selection into paste board
639 if we have a local selection (Bug#8842).
640 (syms_of_nsterm): DEFSYM QUTF8_STRING.
642 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
643 (ns_get_local_selection): Declare.
645 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
647 * keymap.c (describe_map_tree): Don't insert a double newline at
648 the end of the buffer (bug#1169) and return whether we inserted
651 * callint.c (Fcall_interactively): Change "reading args" to
652 "providing args" to try to clarify what it does (bug#1010).
654 2011-07-07 Kenichi Handa <handa@m17n.org>
656 * composite.c (composition_compute_stop_pos): Ignore a static
657 composition starting before CHARPOS (Bug#8915).
659 * xdisp.c (handle_composition_prop): Likewise.
661 2011-07-07 Eli Zaretskii <eliz@gnu.org>
663 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
666 2011-07-07 Kenichi Handa <handa@m17n.org>
668 * character.h (unicode_category_t): New enum type.
670 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
671 (Qchar_code_property_table): New variable.
672 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
673 (UNIPROP_COMPRESSED_FORM_P): New macros.
674 (char_table_ascii): Uncompress the compressed values.
675 (sub_char_table_ref): New arg is_uniprop. Callers changed.
676 Uncompress the compressed values.
677 (sub_char_table_ref_and_range): Likewise.
678 (char_table_ref_and_range): Uncompress the compressed values.
679 (sub_char_table_set): New arg is_uniprop. Callers changed.
680 Uncompress the compressed values.
681 (sub_char_table_set_range): Args changed. Callers changed.
682 (char_table_set_range): Adjuted for the above change.
683 (map_sub_char_table): Delete args default_val and parent. Add arg
684 top. Give decoded values to a Lisp function.
685 (map_char_table): Adjusted for the above change. Give decoded
686 values to a Lisp function. Gcpro more variables.
687 (uniprop_table_uncompress)
688 (uniprop_decode_value_run_length): New functions.
689 (uniprop_decoder, uniprop_decoder_count): New variables.
690 (uniprop_get_decoder, uniprop_encode_value_character)
691 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
693 (uniprop_encoder, uniprop_encoder_count): New variables.
694 (uniprop_get_encoder, uniprop_table)
695 (Funicode_property_table_internal, Fget_unicode_property_internal)
696 (Fput_unicode_property_internal): New functions.
697 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
698 Sunicode_property_table_internal, Sget_unicode_property_internal,
699 and Sput_unicode_property_internal. Defvar_lisp
700 char-code-property-alist.
702 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
703 Vunicode_category_table.
705 * font.c (font_range): Adjusted for the change of
706 Vunicode_category_table.
708 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
710 * m/iris4d.h: Remove file, move contents ...
711 * s/irix6-5.h: ... here.
713 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
715 Remove unportable assumption about struct layout (Bug#8884).
716 * alloc.c (mark_buffer):
717 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
718 (clone_per_buffer_values): Don't assume that
719 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
720 This isn't true in general, and it's particularly not true
721 if Emacs is configured with --with-wide-int.
722 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
723 New macros, used in the buffer.c change.
725 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
727 * xsettings.c: Use both GConf and GSettings if both are available.
728 (store_config_changed_event): Add comment.
729 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
730 (store_tool_bar_style_changed): New functions.
731 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
732 (struct xsettings): Move font inside HAVE_XFT.
733 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
734 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
735 Move inside HAVE_XFT.
736 (something_changed_gsettingsCB): Renamed from something_changedCB.
737 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
739 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
740 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
741 (something_changed_gconfCB): Renamed from something_changedCB.
742 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
743 (parse_settings): Move check for font inside HAVE_XFT.
744 (read_settings, apply_xft_settings): Add comment.
745 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
746 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
747 call store_font_name_changed.
748 (xft_settings_event): Add comment.
749 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
750 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
751 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
752 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
753 (xsettings_initialize): Call init_gsettings last.
754 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
757 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
759 Random fixes. E.g., (random) never returned negative values.
760 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
761 subseconds part to the entropy, as that's a bit more random.
762 Prefer signed to unsigned, since the signedness doesn't matter and
763 in general we prefer signed. When given a limit, use a
764 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
765 latter isn't right if USE_2_TAGS_FOR_INTS.
766 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
767 not 0..VALMASK. Don't discard "excess" bits that random () returns.
769 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
771 * textprop.c (text_property_stickiness):
772 Obey Vtext_property_default_nonsticky.
773 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
774 * w32fns.c (syms_of_w32fns):
775 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
777 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
779 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
780 This is more efficient than Ffile_directory_p and avoids a minor race.
782 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
784 * buffer.c (Foverlay_put): Say what the return value is
787 * fileio.c (barf_or_query_if_file_exists): Check first if the file
788 is a directory before asking whether to use the file name
790 (barf_or_query_if_file_exists): Make the "File is a directory"
791 error be more correct.
793 * fns.c (Frequire): Remove the mention of the .gz files, since
794 that's installation-specific, but keep the mention of
797 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
799 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
800 Report string overflow if the output is too long.
802 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
804 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
805 (syms_of_gnutls): Remove duplicate DEFSYM for
806 Qgnutls_bootprop_verify_hostname_error, an error for
807 Qgnutls_bootprop_verify_error (which is no longer used).
809 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
810 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
811 Also (re)move comments that are misplaced or no longer relevant.
813 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
815 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
817 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
819 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
820 and background color parameters if they have been changed.
822 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
824 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
826 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
828 * xsettings.c (SYSTEM_FONT): Define only when used.
829 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
831 * keymap.c (access_keymap_1): Now static.
833 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
835 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
836 leave any prefix arg for the up event (Bug#1586).
838 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
840 * lread.c (syms_of_lread): Mention single symbols defined by
841 `defvar' or `defconst' (bug#7154).
843 * fns.c (Frequire): Mention .el.gz files (bug#7314).
844 (Frequire): Mention get-load-suffixes.
846 2011-07-02 Martin Rudalics <rudalics@gmx.at>
848 * window.h (window): Remove clone_number slot.
849 * window.c (Fwindow_clone_number, Fset_window_clone_number):
851 (make_parent_window, make_window, saved_window)
852 (Fset_window_configuration, save_window_save): Don't deal with
854 * buffer.c (Qclone_number): Remove declaration.
855 (sort_overlays, overlay_strings): Don't deal with clone numbers.
857 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
859 Add multiple inheritance to keymaps.
860 * keymap.c (Fmake_composed_keymap): New function.
861 (Fset_keymap_parent): Simplify.
862 (fix_submap_inheritance): Remove.
863 (access_keymap_1): New function extracted from access_keymap to handle
864 embedded parents and handle lists of maps.
865 (access_keymap): Use it.
866 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
867 (Fcopy_keymap): Handle embedded parents.
868 (Fcommand_remapping, define_as_prefix): Simplify.
869 (Fkey_binding): Simplify.
870 (syms_of_keymap): Move minibuffer-local-completion-map,
871 minibuffer-local-filename-completion-map,
872 minibuffer-local-must-match-map, and
873 minibuffer-local-filename-must-match-map to Elisp.
874 (syms_of_keymap): Defsubr make-composed-keymap.
875 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
876 (parse_menu_item): Trivial simplification.
878 2011-07-01 Glenn Morris <rgm@gnu.org>
880 * Makefile.in (SETTINGS_LIBS): Fix typo.
882 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
884 * coding.c (Fencode_coding_string): Record the last coding system
885 used, as the function doc string says (bug#8738).
887 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
889 * xsettings.c (store_monospaced_changed): Take new font as arg and
890 check for change against current_mono_font.
891 (EMACS_TYPE_SETTINGS): Remove this and related defines.
892 (emacs_settings_constructor, emacs_settings_get_property)
893 (emacs_settings_set_property, emacs_settings_class_init)
894 (emacs_settings_init, gsettings_obj): Remove.
895 (something_changedCB): New function for HAVE_GSETTINGS.
896 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
897 with value as argument.
898 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
899 g_settings_new (Bug#8967). Do not create gsettings_obj.
900 Remove calls to g_settings_bind. Connect something_changedCB to
903 * xgselect.c: Add defined (HAVE_GSETTINGS).
904 (xgselect_initialize): Ditto.
906 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
907 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
910 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
912 * eval.c (struct backtrace): Simplify and port the data structure.
913 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
914 signed bit field, as this assumption is not portable and it makes
915 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
916 "char debug_on_exit : 1" as this is not portable either; instead,
917 use the portable "unsigned int debug_on_exit : 1". Remove unused
918 member evalargs. Remove obsolete comments about cc bombing out.
920 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
922 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
923 Let HAVE_GSETTINGS override HAVE_GCONF.
924 (store_monospaced_changed): New function.
925 (EMACS_SETTINGS): A new type derived from GObject to handle
926 GSettings notifications.
927 (emacs_settings_constructor, emacs_settings_get_property)
928 (emacs_settings_set_property, emacs_settings_class_init):
930 (gsettings_client, gsettings_obj): New variables.
931 (GSETTINGS_SCHEMA): New define.
932 (something_changedCB): Call store_monospaced_changed.
933 (init_gsettings): New function.
934 (xsettings_initialize): Call init_gsettings.
935 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
938 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
941 2011-06-29 Martin Rudalics <rudalics@gmx.at>
943 * window.c (resize_root_window, grow_mini_window)
944 (shrink_mini_window): Rename Qresize_root_window to
945 Qwindow_resize_root_window and Qresize_root_window_vertically to
946 Qwindow_resize_root_window_vertically.
948 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
950 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
952 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
954 * makefile.w32-in: Redesign dependencies so they reflect more
955 clearly which files are directly included by each source file,
956 and not through other includes.
958 2011-06-27 Martin Rudalics <rudalics@gmx.at>
960 * buffer.c (Qclone_number): Declare static and DEFSYM it.
961 (sort_overlays, overlay_strings): When an overlay's clone number
962 matches the window's clone number process the overlay even if
963 the overlay's window property doesn't match the current window.
965 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
966 (Fwindow_hchild): Rename to Fwindow_left_child.
967 (Fwindow_next): Rename to Fwindow_next_sibling.
968 (Fwindow_prev): Rename to Fwindow_prev_sibling.
969 (resize_window_check): Rename to window_resize_check.
970 (resize_window_apply): Rename to window_resize_apply.
971 (Fresize_window_apply): Rename to Fwindow_resize_apply.
972 (Fdelete_other_windows_internal, resize_frame_windows)
973 (Fsplit_window_internal, Fdelete_window_internal)
974 (grow_mini_window, shrink_mini_window)
975 (Fresize_mini_window_internal): Fix callers accordingly.
977 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
979 * emacsgtkfixed.h: State that this is only used with Gtk+3.
980 (emacs_fixed_set_min_size): Remove.
981 (emacs_fixed_new): Take frame as argument.
983 * emacsgtkfixed.c: State that this is only used with Gtk+3.
984 (_EmacsFixedPrivate): Remove minwidth/height.
986 (emacs_fixed_init): Initialize priv->f.
987 (get_parent_class, emacs_fixed_set_min_size): Remove.
988 (emacs_fixed_new): Set priv->f to argument.
989 (emacs_fixed_get_preferred_width)
990 (emacs_fixed_get_preferred_height): Use min_width/height from
991 frames size_hint to set minimum and natural (Bug#8919).
992 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
993 and use min_width/height from frames size_hint to set
994 min_width/height (Bug#8919).
996 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
997 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
1000 2011-06-26 Eli Zaretskii <eliz@gnu.org>
1002 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1003 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1006 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
1008 * process.c (wait_reading_process_output): Bypass select if
1009 waiting for a cell while ignoring keyboard input, and input is
1010 pending. Suggested by Jan Djärv (Bug#8869).
1012 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1014 Use gnulib's dup2 module instead of rolling our own.
1015 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1017 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1019 * dispnew.c (scrolling_window): Before scrolling, turn off a
1020 mouse-highlight in the window being scrolled.
1022 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
1024 Move DEFSYM to lisp.h and use everywhere.
1026 * character.h (DEFSYM): Move declaration...
1027 * lisp.h (DEFSYM): ...here.
1033 * w32select.c: Don't include character.h.
1035 * alloc.c (syms_of_alloc):
1036 * buffer.c (syms_of_buffer):
1037 * bytecode.c (syms_of_bytecode):
1038 * callint.c (syms_of_callint):
1039 * casefiddle.c (syms_of_casefiddle):
1040 * casetab.c (init_casetab_once):
1041 * category.c (init_category_once, syms_of_category):
1042 * ccl.c (syms_of_ccl):
1043 * cmds.c (syms_of_cmds):
1044 * composite.c (syms_of_composite):
1045 * dbusbind.c (syms_of_dbusbind):
1046 * dired.c (syms_of_dired):
1047 * dispnew.c (syms_of_display):
1048 * doc.c (syms_of_doc):
1049 * editfns.c (syms_of_editfns):
1050 * emacs.c (syms_of_emacs):
1051 * eval.c (syms_of_eval):
1052 * fileio.c (syms_of_fileio):
1053 * fns.c (syms_of_fns):
1054 * frame.c (syms_of_frame):
1055 * fringe.c (syms_of_fringe):
1056 * insdel.c (syms_of_insdel):
1057 * keymap.c (syms_of_keymap):
1058 * lread.c (init_obarray, syms_of_lread):
1059 * macros.c (syms_of_macros):
1060 * msdos.c (syms_of_msdos):
1061 * print.c (syms_of_print):
1062 * process.c (syms_of_process):
1063 * search.c (syms_of_search):
1064 * sound.c (syms_of_sound):
1065 * syntax.c (init_syntax_once, syms_of_syntax):
1066 * terminal.c (syms_of_terminal):
1067 * textprop.c (syms_of_textprop):
1068 * undo.c (syms_of_undo):
1069 * w32.c (globals_of_w32):
1070 * window.c (syms_of_window):
1071 * xdisp.c (syms_of_xdisp):
1072 * xfaces.c (syms_of_xfaces):
1073 * xfns.c (syms_of_xfns):
1074 * xmenu.c (syms_of_xmenu):
1075 * xsettings.c (syms_of_xsettings):
1076 * xterm.c (syms_of_xterm): Use DEFSYM.
1078 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1080 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
1082 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1084 Integer and buffer overflow fixes (Bug#8873).
1086 * print.c (printchar, strout): Check for string overflow.
1087 (PRINTPREPARE, printchar, strout):
1088 Don't set size unless allocation succeeds.
1090 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1091 for sizes. Check for string overflow more accurately.
1092 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1094 * macros.c: Integer and buffer overflow fixes.
1095 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1096 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1097 Use ptrdiff_t, not int, for sizes.
1098 Don't increment bufsize until after realloc succeeds.
1099 Check for size-calculation overflow.
1100 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1102 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1104 * lread.c: Integer overflow fixes.
1105 (read_integer): Radix is now EMACS_INT, not int,
1106 to improve quality of diagnostics for out-of-range radices.
1107 Calculate buffer size correctly for out-of-range radices.
1108 (read1): Check for integer overflow in radices, and in
1109 read-circle numbers.
1110 (read_escape): Avoid int overflow.
1111 (Fload, openp, read_buffer_size, read1)
1112 (substitute_object_recurse, read_vector, read_list, map_obarray):
1113 Use ptrdiff_t, not int, for sizes.
1114 (read1): Use EMACS_INT, not int, for sizes.
1115 Check for size overflow.
1117 * image.c (cache_image): Check for size arithmetic overflow.
1119 * lread.c: Integer overflow issues.
1120 (saved_doc_string_size, saved_doc_string_length)
1121 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1122 Now ptrdiff_t, not int.
1123 (read1): Don't assume doc string length fits in int. Check for
1124 out-of-range doc string lengths.
1125 (read_list): Don't assume file position fits in int.
1126 (read_escape): Check for hex character overflow.
1128 2011-06-22 Leo Liu <sdl.web@gmail.com>
1130 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1131 Move to minibuffer.el.
1133 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1135 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
1136 The following patches are for when GLYPH_DEBUG && !XASSERT.
1137 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1138 * dispnew.c (flush_stdout):
1139 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1140 Mark as externally visible.
1141 * dispnew.c (check_window_matrix_pointers): Now static.
1142 * dispnew.c (window_to_frame_vpos):
1143 * xfns.c (unwind_create_frame):
1144 * xterm.c (x_check_font): Remove unused local.
1145 * scroll.c (CHECK_BOUNDS):
1146 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1147 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1148 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1149 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1150 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1152 (debug_method_add): Use va_list and vsprintf rather than relying
1153 on undefined behavior with wrong number of arguments.
1154 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1155 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1156 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1157 since we're not interested in debugging glyphs with old libraries.
1158 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1159 GCC 4.6.0's static checking.
1161 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1163 Integer overflow and signedness fixes (Bug#8873).
1164 A few related buffer overrun fixes, too.
1166 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1168 * dispextern.h (struct face.stipple):
1169 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1170 (x_bitmap_mask, x_allocate_bitmap_record)
1171 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1172 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1173 (x_create_bitmap_from_xpm_data):
1174 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1175 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1177 * xfaces.c (load_pixmap):
1178 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1179 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1180 (.bitmaps_last, struct x_output.icon_bitmap):
1181 Use ptrdiff_t, not int, for bitmap indexes.
1182 (x_allocate_bitmap_record): Check for size overflow.
1183 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1185 Use ptrdiff_t, not int, for overlay counts.
1186 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1187 * editfns.c (overlays_around, get_pos_property):
1188 * textprop.c (get_char_property_and_overlay):
1189 * xdisp.c (next_overlay_change, note_mouse_highlight):
1190 * xfaces.c (face_at_buffer_position):
1191 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1192 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1193 (Fnext_overlay_change, Fprevious_overlay_change)
1194 (mouse_face_overlay_overlaps, Foverlays_in):
1195 Use ptrdiff_t, not int, for sizes.
1196 (overlays_at, overlays_in): Check for size-calculation overflow.
1198 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1200 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1201 (x_session_initialize): Do not assume string length fits in int.
1203 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1204 This is unlikely, but can occur if DPI is outlandish.
1206 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
1207 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1209 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1210 * xrdb.c (magic_file_p, search_magic_path):
1211 Omit last arg SUFFIX; it was always 0. All callers changed.
1212 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1214 * xfont.c (xfont_match): Avoid need for strlen.
1216 * xfns.c: Don't assume strlen fits in int.
1217 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1219 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1220 not unsigned long, as we prefer signed integers. All callers changed.
1221 Detect integer overflow in repeat count.
1222 (message_dolog): Don't assume print length fits in 39 bytes.
1223 (display_mode_element): Don't assume strlen fits in int.
1225 * termcap.c: Don't assume sizes fit in int and never overflow.
1226 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1227 (gobble_line): Check for size-calculation overflow.
1229 * minibuf.c (Fread_buffer):
1230 * lread.c (intern, intern_c_string):
1231 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1232 Don't assume string length fits in int.
1234 * keyboard.c (parse_tool_bar_item):
1235 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1237 * font.c: Don't assume string length fits in int.
1238 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1239 Use ptrdiff_t, not int.
1240 (font_intern_prop): Don't assume string length fits in int.
1241 Don't assume integer property fits in fixnum.
1242 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
1244 * filelock.c: Fix some buffer overrun and integer overflow issues.
1245 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
1246 Reformulate so as not to need the command string.
1247 Invoke gzip -cd rather than gunzip, as it's more portable.
1248 (lock_info_type, lock_file_1, lock_file):
1249 Don't assume pid_t and time_t fit in unsigned long.
1250 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1251 (current_lock_owner): Prefer signed type for sizes.
1252 Use memcpy, not strncpy, where memcpy is what is really wanted.
1253 Don't assume (via atoi) that time_t and pid_t fit in int.
1254 Check for time_t and/or pid_t out of range, e.g., via a network share.
1255 Don't alloca where an auto var works fine.
1257 * fileio.c: Fix some integer overflow issues.
1258 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1259 Don't assume string length fits in int.
1260 (directory_file_name): Don't assume string length fits in long.
1261 (make_temp_name): Don't assume pid fits in int, or that its print
1262 length is less than 20.
1264 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1266 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1268 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1270 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1271 We prefer signed integers, even for size calculations.
1273 * emacs.c: Don't assume string length fits in 'int'.
1274 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1275 (main): Don't invoke strlen when not needed.
1277 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1278 (XD_DEBUG_MESSAGE): Don't waste a byte.
1280 * callproc.c (getenv_internal_1, getenv_internal)
1282 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1284 * lread.c (invalid_syntax): Omit length argument.
1285 All uses changed. This doesn't fix a bug, but it simplifies the
1286 code away from its former Hollerith-constant appearance, and it's
1287 one less 'int' to worry about when looking at integer-overflow issues.
1288 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
1290 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1291 This didn't break anything, but it didn't help either.
1292 It's confusing to put a bogus integer in a place where the actual
1293 value does not matter.
1294 (LIST_END_P): Remove unused macro and its bogus comment.
1295 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
1297 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1298 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1300 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1301 We prefer signed types, and the value cannot exceed the EMACS_INT
1302 range anyway (because otherwise the length would not be representable).
1303 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1304 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1305 This avoids a GCC warning when WIDE_EMACS_INT.
1307 * indent.c (sane_tab_width): New function.
1308 (current_column, scan_for_column, Findent_to, position_indentation)
1309 (compute_motion): Use it. This is just for clarity.
1310 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
1312 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
1314 * lisp.h (lint_assume): New macro.
1315 * composite.c (composition_gstring_put_cache):
1316 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1318 * editfns.c, insdel.c:
1319 Omit unnecessary forward decls, to simplify future changes.
1321 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1323 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1325 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
1326 Use much-faster test for byte-length change.
1327 Don't assume string byte-length fits in 'int'.
1328 Check that character arg fits in 'int'.
1329 (mapcar1): Declare byte as byte, for clarity.
1331 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1333 * fns.c (concat): Catch string overflow earlier.
1334 Do not rely on integer wraparound.
1336 * dispextern.h (struct it.overlay_strings_charpos)
1337 (struct it.selective): Now EMACS_INT, not int.
1338 * xdisp.c (forward_to_next_line_start)
1339 (back_to_previous_visible_line_start)
1340 (reseat_at_next_visible_line_start, next_element_from_buffer):
1341 Don't arbitrarily truncate the value of 'selective' to int.
1343 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1345 * composite.c: Don't truncate sizes to 'int'.
1346 (composition_gstring_p, composition_reseat_it)
1347 (composition_adjust_point): Use EMACS_INT, not int.
1348 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1349 not EMACS_UINT, for indexes.
1351 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1353 * buffer.c: Include <verify.h>.
1354 (struct sortvec.priority, struct sortstr.priority):
1355 Now EMACS_INT, not int.
1356 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
1357 (struct sortstr.size, record_overlay_string)
1358 (struct sortstrlist.size, struct sortlist.used):
1359 Don't truncate size to int.
1360 (record_overlay_string): Check for size-calculation overflow.
1361 (init_buffer_once): Check at compile-time, not run-time.
1363 2011-06-22 Jim Meyering <meyering@redhat.com>
1365 Don't leak an XBM-image-sized buffer
1366 * image.c (xbm_load): Free the image buffer after using it.
1368 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1371 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1372 that Sun C diagnosed.
1373 * fns.c (secure_hash): Fix pointer signedness issue.
1374 * intervals.c (static_offset_intervals): New function.
1375 (offset_intervals): Use it.
1377 2011-06-21 Leo Liu <sdl.web@gmail.com>
1380 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1383 * fns.c (secure_hash): Rename from crypto_hash_function and change
1384 the first arg to accept symbols.
1385 (Fsecure_hash): New primitive.
1386 (syms_of_fns): New symbols.
1388 2011-06-20 Deniz Dogan <deniz@dogan.se>
1390 * process.c (Fset_process_buffer): Clarify return value in
1393 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
1395 * dispnew.c (add_window_display_history): Use BVAR.
1397 * xdisp.c (debug_method_add): Use BVAR.
1398 (check_window_end, dump_glyph_matrix, dump_glyph)
1399 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1401 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1404 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1405 check till after the cache is created in init_frame_faces.
1407 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1409 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1411 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1413 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1414 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1415 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1417 Improve buffer-overflow checking (Bug#8873).
1418 * fileio.c (Finsert_file_contents):
1419 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1420 Remove the old (too-loose) buffer overflow checks.
1421 They weren't needed, since make_gap checks for buffer overflow.
1422 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1423 The old code merely checked for Emacs fixnum overflow, and relied
1424 on undefined (wraparound) behavior. The new code avoids undefined
1425 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1427 * editfns.c (Finsert_char): Don't dump core with very negative counts.
1428 Tune. Don't use wider integers than needed. Don't use alloca.
1429 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
1431 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1433 * insdel.c, lisp.h (buffer_overflow): New function.
1434 (insert_from_buffer_1, replace_range, replace_range_2):
1435 * insdel.c (make_gap_larger):
1436 * editfns.c (Finsert_char):
1437 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1439 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1441 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1443 Integer overflow and signedness fixes (Bug#8873).
1445 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1446 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1448 * fileio.c: Don't assume EMACS_INT fits in off_t.
1449 (emacs_lseek): New static function.
1450 (Finsert_file_contents, Fwrite_region): Use it.
1451 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1453 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1455 * fns.c: Don't overflow int when computing a list length.
1456 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1457 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1458 truncation on 64-bit hosts. Check for QUIT every
1459 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1460 faster and is responsive enough.
1461 (Flength): Report an error instead of overflowing an integer.
1462 (Fsafe_length): Return a float if the value is not representable
1463 as a fixnum. This shouldn't happen except in contrived situations.
1464 (Fnthcdr, Fsort): Don't assume list length fits in int.
1465 (Fcopy_sequence): Don't assume vector length fits in int.
1467 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1468 (header_size, word_size): New constants.
1469 (allocate_vectorlike): Don't check size overflow here.
1470 (allocate_vector): Check it here instead, since this is the only
1471 caller of allocate_vectorlike that could cause overflow.
1472 Check that the new vector's length is representable as a fixnum.
1474 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1475 The previous code was bogus. For example, next_almost_prime (32)
1476 returned 39, which is undesirable as it is a multiple of 3; and
1477 next_almost_prime (24) returned 25, which is a multiple of 5 so
1478 why was the code bothering to check for multiples of 7?
1480 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1482 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1484 Variadic C functions now count arguments with ptrdiff_t.
1485 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1486 Back then I didn't know that the Emacs coding style prefers signed int.
1487 Also, in the meantime I found a few more instances where arguments
1488 were being counted with int, which may truncate counts on 64-bit
1489 machines, or EMACS_INT, which may be unnecessarily wide.
1490 * lisp.h (struct Lisp_Subr.function.aMANY)
1491 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1492 Arg counts are now ptrdiff_t, not size_t.
1493 All variadic functions and their callers changed accordingly.
1494 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1495 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1496 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1497 * callint.c (Fcall_interactively): Check arg count for overflow,
1498 to avoid potential buffer overrun. Use signed char, not 'int',
1499 for 'varies' array, so that we needn't bother to check its size
1500 calculation for overflow.
1501 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1502 * eval.c (apply_lambda):
1503 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1504 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1505 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1507 * callint.c (Fcall_interactively): Don't use index var as event count.
1509 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1510 * mem-limits.h (SIZE): Remove; no longer used.
1512 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
1514 Remove unnecessary casts.
1515 * xterm.c (x_term_init):
1516 * xfns.c (x_set_border_pixel):
1517 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1518 These aren't needed now that we assume ANSI C.
1520 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1521 It's more likely to cause problems (due to unsigned overflow)
1524 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1526 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1528 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1530 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1532 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1534 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1536 GLYPH_CODE_FACE returns EMACS_INT, not int.
1537 * dispextern.h (merge_faces):
1538 * xfaces.c (merge_faces):
1539 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1540 Don't assume EMACS_INT fits in int.
1542 * character.h (CHAR_VALID_P): Remove unused parameter.
1543 * fontset.c, lisp.h, xdisp.c: All uses changed.
1545 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1547 * fns.c (concat): Minor tuning based on overflow analysis.
1548 This doesn't fix any bugs. Use int to hold character, instead
1549 of constantly refetching from Emacs object. Use XFASTINT, not
1550 XINT, for value known to be a character. Don't bother comparing
1551 a single byte to 0400, as it's always less.
1553 * floatfns.c (Fexpt):
1554 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1556 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1559 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1561 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1562 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1563 incorrectly succeed when S was a string, because 4294967386 was
1564 truncated before it was used.
1566 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1567 Otherwise, an out-of-range integer could cause undefined behavior
1570 * composite.c: Use int, not EMACS_INT, for characters.
1571 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1572 EMACS_INT, for values that are known to be in character range.
1573 This doesn't fix any bugs but is the usual style inside Emacs and
1574 may generate better code on 32-bit machines.
1576 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1577 This is for reasons similar to the recent CHAR_STRING fix.
1578 * charset.c (Fencode_char): Check that character arg is actually
1579 a character. Pass an int to ENCODE_CHAR.
1580 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1581 wider than 'int', as a compile-time check to prevent future regressions
1584 * character.c (char_string): Remove unnecessary casts.
1586 Make sure a 64-bit char is never passed to CHAR_STRING.
1587 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1588 by silently ignoring the top 32 bits, allowing some values
1589 that were far too large to be valid characters.
1590 * character.h: Include <verify.h>.
1591 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1592 arguments are no wider than unsigned, as a compile-time check
1593 to prevent future regressions in this area.
1595 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
1596 (Fsubst_char_in_region):
1598 * xdisp.c (decode_mode_spec_coding):
1599 Adjust to CHAR_STRING's new requirement.
1600 * editfns.c (Finsert_char, Fsubst_char_in_region):
1601 * fns.c (concat): Check that character args are actually
1602 characters. Without this test, these functions did the wrong
1603 thing with wildly out-of-range values on 64-bit hosts.
1605 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1606 These casts should not be needed on 32-bit hosts, either.
1607 * keyboard.c (read_char):
1608 * lread.c (Fload): Remove casts to unsigned.
1610 * lisp.h (UNSIGNED_CMP): New macro.
1611 This fixes comparison bugs on 64-bit hosts.
1612 (ASCII_CHAR_P): Use it.
1613 * casefiddle.c (casify_object):
1614 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
1615 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1616 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1617 * dispextern.h (FACE_FROM_ID):
1618 * keyboard.c (read_char): Use UNSIGNED_CMP.
1620 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1621 not to EMACS_INT, to avoid GCC warning.
1623 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1625 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1626 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1627 isn't needed on 32-bit machines.
1629 * buffer.c (Fgenerate_new_buffer_name):
1630 Use EMACS_INT for count, not int.
1631 (advance_to_char_boundary): Return EMACS_INT, not int.
1633 * data.c (Qcompiled_function): Now static.
1635 * window.c (window_body_lines): Now static.
1637 * image.c (gif_load): Rename local to avoid shadowing.
1639 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
1640 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
1641 * alloc.c (make_save_value): Integer argument is now of type
1643 (mark_object): Use ptrdiff_t, not int.
1644 * lisp.h (pD): New macro.
1645 * print.c (print_object): Use it.
1647 * alloc.c: Use EMACS_INT, not int, to count objects.
1648 (total_conses, total_markers, total_symbols, total_vector_size)
1649 (total_free_conses, total_free_markers, total_free_symbols)
1650 (total_free_floats, total_floats, total_free_intervals)
1651 (total_intervals, total_strings, total_free_strings):
1652 Now EMACS_INT, not int. All uses changed.
1653 (Fgarbage_collect): Compute overall total using a double, so that
1654 integer overflow is less likely to be a problem. Check for overflow
1655 when converting back to an integer.
1656 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
1657 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
1658 These were 'int' variables that could overflow on 64-bit hosts;
1659 they were never used, so remove them instead of repairing them.
1660 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
1661 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
1662 Previously, this ceilinged at INT_MAX, but that doesn't work on
1664 (allocate_pseudovector): Don't use EMACS_INT when int would do.
1666 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
1667 (allocate_vectorlike): Check for ptrdiff_t overflow.
1668 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
1669 when a (possibly-narrower) signed value would do just as well.
1670 We prefer using signed arithmetic, to avoid comparison confusion.
1672 * alloc.c: Catch some string size overflows that we were missing.
1673 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
1674 for convenience in STRING_BYTES_MAX.
1675 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
1676 The definition here is exact; the one in lisp.h was approximate.
1677 (allocate_string_data): Check for string overflow. This catches
1678 some instances we weren't catching before. Also, it catches
1679 size_t overflow on (unusual) hosts where SIZE_MAX <= min
1680 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
1681 and ptrdiff_t and EMACS_INT are both 64 bits.
1683 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
1684 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
1685 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
1687 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
1689 * alloc.c (Fmake_string): Check for out-of-range init.
1691 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
1693 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
1695 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
1697 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
1698 xg_get_default_scrollbar_width.
1700 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
1701 (int_gtk_range_get_value): Move to the scroll bar part of the file.
1702 (style_changed_cb): Call update_theme_scrollbar_width and call
1703 x_set_scroll_bar_default_width and xg_frame_set_char_size for
1704 all frames (Bug#8505).
1705 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
1706 Call gtk_window_set_resizable if HAVE_GTK3.
1707 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
1708 and height if HAVE_GTK3 (Bug#8505).
1709 (scroll_bar_width_for_theme): New variable.
1710 (update_theme_scrollbar_width): New function.
1711 (xg_get_default_scrollbar_width): Move code to
1712 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
1713 (xg_initialize): Call update_theme_scrollbar_width.
1715 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
1717 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
1719 2011-06-12 Martin Rudalics <rudalics@gmx.at>
1721 * frame.c (make_frame): Call other_buffer_safely instead of
1724 * window.c (temp_output_buffer_show): Call display_buffer with
1725 second argument Vtemp_buffer_show_specifiers and reset latter
1726 immediately after the call.
1727 (Vtemp_buffer_show_specifiers): New variable.
1728 (auto_window_vscroll_p, next_screen_context_lines)
1729 (Vscroll_preserve_screen_position): Remove leading asterisks from
1732 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
1734 Fix minor problems found by GCC 4.6.0 static checking.
1735 * buffer.c (Qclone_number): Remove for now, as it's unused.
1736 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
1737 (record_buffer): Remove unused local.
1738 * frame.c (other_visible_frames, frame_buffer_list): Now static.
1739 (set_frame_buffer_list): Remove; unused.
1740 * frame.h (other_visible_frames): Remove decl.
1741 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
1742 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
1743 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
1745 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
1746 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
1747 Define only if HAVE_GPM.
1748 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
1749 (update_hints_inhibit): Remove; never set. All uses removed.
1750 * widgetprv.h (emacsFrameClassRec): Remove decl.
1751 * window.c (delete_deletable_window): Now returns void, since it
1752 wasn't returning anything.
1753 (compare_window_configurations): Remove unused locals.
1754 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
1755 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
1756 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
1757 the same widths as pointers. This follows up on the 2011-05-06 patch.
1758 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
1759 * xterm.h: Likewise.
1760 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
1762 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
1764 * makefile.w32-in: Update dependencies.
1765 (LISP_H): Add lib/intprops.h.
1767 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
1769 * image.c (gif_load): Add animation frame delay to the metadata.
1770 (syms_of_image): Use DEFSYM. New symbol `delay'.
1772 2011-06-11 Martin Rudalics <rudalics@gmx.at>
1774 * window.c (delete_deletable_window): Re-add.
1775 (Fset_window_configuration): Rewrite to handle dead buffers and
1776 consequently deletable windows.
1777 (window_tree, Fwindow_tree): Remove. Supply functionality in
1779 (compare_window_configurations): Simplify code.
1781 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
1783 * image.c (imagemagick_load_image): Fix type mismatch.
1784 (Fimagemagick_types): Likewise.
1786 * window.h (replace_buffer_in_windows): Declare.
1788 2011-06-11 Martin Rudalics <rudalics@gmx.at>
1790 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
1791 Qclone_number. Remove external declaration of Qdelete_window.
1792 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
1794 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
1795 Qbuffer_list_update_hook if allowed.
1796 (Fother_buffer): Rewrite doc-string. Major rewrite for new
1797 buffer list implementation.
1798 (other_buffer_safely): New function.
1799 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
1800 calls to replace_buffer_in_windows and
1801 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
1803 (record_buffer): Inhibit quitting and rewrite using quittable
1804 functions. Run Qbuffer_list_update_hook if allowed.
1805 (Frecord_buffer, Funrecord_buffer): New functions.
1806 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
1807 switch-to-buffer to window.el.
1808 (bury-buffer): Move to window.el.
1809 (Vbuffer_list_update_hook): New variable.
1811 * lisp.h (other_buffer_safely): Add prototype in buffer.c
1814 * window.h (resize_frame_windows): Move up in code.
1815 (Fwindow_frame): Remove EXFUN.
1816 (replace_buffer_in_all_windows): Remove prototype.
1817 (replace_buffer_in_windows_safely): Add prototype.
1819 * window.c: Declare Qdelete_window static again. Move down
1820 declaration of select_count.
1821 (Fnext_window, Fprevious_window): Rewrite doc-strings.
1822 (Fother_window): Move to window.el.
1823 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
1824 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
1825 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
1827 (replace_buffer_in_windows): Implement by calling
1828 Qreplace_buffer_in_windows.
1829 (replace_buffer_in_all_windows): Remove with some functionality
1830 moved into replace_buffer_in_windows_safely.
1831 (replace_buffer_in_windows_safely): New function.
1832 (select_window_norecord, select_frame_norecord): Move in front
1833 of run_window_configuration_change_hook. Remove now obsolete
1835 (Fset_window_buffer): Rewrite doc-string. Call
1836 Qrecord_window_buffer.
1837 (keys_of_window): Move binding for other-window to window.el.
1839 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
1841 * dispextern.h (struct image): Replace data member, whose int_val
1842 and ptr_val fields were not used by anything, with a single
1845 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
1846 (gif_clear_image, gif_load, imagemagick_load_image)
1847 (gs_clear_image, gs_load): Callers changed.
1849 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
1851 * buffer.h: Include <time.h>, for time_t.
1852 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
1854 Fix minor problems found by static checking.
1856 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
1858 Make identifiers static if they are not used in other modules.
1859 * data.c (Qcompiled_function, Qframe, Qvector):
1860 * image.c (QimageMagick, Qsvg):
1861 * minibuf.c (Qmetadata):
1862 * window.c (resize_window_check, resize_root_window): Now static.
1863 * window.h (resize_window_check, resize_root_window): Remove decls.
1865 * window.c (window_deletion_count, delete_deletable_window):
1867 (window_body_lines): Now static.
1868 (Fdelete_other_windows_internal): Mark vars as initialized.
1869 Make sure 'resize_failed' is initialized.
1870 (run_window_configuration_change_hook): Rename local to avoid shadowing.
1871 (resize_window_apply): Remove unused local.
1872 * window.h (delete_deletable_window): Remove decl.
1874 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
1875 (imagemagick_load_image): Fix pointer signedness problem by changing
1876 last arg from unsigned char * to char *. All uses changed.
1877 Also, fix a local for similar reasons.
1878 Remove unused locals. Remove locals to avoid shadowing.
1879 (fn_rsvg_handle_free): Remove; unused.
1880 (svg_load, svg_load_image): Fix pointer signedness problem.
1881 (imagemagick_load_image): Don't use garbage pointer image_wand.
1883 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
1885 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
1887 * image.c (gif_load): Fix omitted cast error introduced by
1890 2011-06-10 Martin Rudalics <rudalics@gmx.at>
1892 * window.h (resize_proportionally, orig_total_lines)
1893 (orig_top_line): Remove from window structure.
1894 (set_window_height, set_window_width, change_window_heights)
1895 (Fdelete_window): Remove prototypes.
1896 (resize_frame_windows): Remove duplicate declaration.
1898 2011-06-10 Eli Zaretskii <eliz@gnu.org>
1900 * window.h (resize_frame_windows, resize_window_check)
1901 (delete_deletable_window, resize_root_window)
1902 (resize_frame_windows): Declare prototypes.
1904 * window.c (resize_window_apply): Make definition be "static" to
1905 match the prototype.
1907 2011-06-10 Martin Rudalics <rudalics@gmx.at>
1909 * window.c: Remove declarations of Qwindow_size_fixed,
1910 window_min_size_1, window_min_size_2, window_min_size,
1911 size_window, window_fixed_size_p, enlarge_window, delete_window.
1912 Remove static from declaration of Qdelete_window, it's
1913 temporarily needed by Fbury_buffer.
1914 (replace_window): Don't assign orig_top_line and
1916 (Fdelete_window, delete_window): Remove. Window deletion is
1917 handled by window.el.
1918 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
1919 Fdelete_window calls with calls to Qdelete_window.
1920 (Fdelete_other_windows): Remove. Deleting other windows is
1921 handled by window.el.
1922 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
1923 handled in window.el.
1924 (window_min_size_2, window_min_size_1, window_min_size): Remove.
1925 Window minimum sizes are handled in window.el.
1926 (shrink_windows, size_window, set_window_height)
1927 (set_window_width, change_window_heights, window_height)
1928 (window_width, CURBEG, CURSIZE, enlarge_window)
1929 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
1930 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
1931 handled in window.el.
1932 (make_dummy_parent): Rename to make_parent_window and give it a
1933 second argument horflag.
1934 (make_window): Don't set resize_proportionally any more.
1935 (Fsplit_window): Remove. Windows are split in window.el.
1936 (save_restore_action, save_restore_orig_size)
1937 (shrink_window_lowest_first, save_restore_orig_size): Remove.
1938 Resize mini windows in window.el.
1939 (grow_mini_window, shrink_mini_window): Implement by calling
1940 Qresize_root_window_vertically, resize_window_check and
1941 resize_window_apply.
1942 (saved_window, Fset_window_configuration, save_window_save): Do
1943 not handle orig_top_line, orig_total_lines, and
1944 resize_proportionally.
1945 (window_min_height, window_min_width): Move to window.el.
1946 (keys_of_window): Move bindings for delete-other-windows,
1947 split-window, delete-window and enlarge-window to window.el.
1949 * buffer.c: Temporarily extern Qdelete_window.
1950 (Fbury_buffer): Temporarily call Qdelete_window instead of
1951 Fdelete_window (Fbury_buffer will move to window.el soon).
1953 * frame.c (set_menu_bar_lines_1): Remove code handling
1954 orig_top_line and orig_total_lines.
1956 * dispnew.c (adjust_frame_glyphs_initially): Don't use
1957 set_window_height but set heights directly.
1958 (change_frame_size_1): Use resize_frame_windows.
1960 * xdisp.c (init_xdisp): Don't use set_window_height but set
1963 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
1964 resize_frame_windows instead of change_window_heights and run
1965 run_window_configuration_change_hook.
1967 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
1968 instead of change_window_heights and run
1969 run_window_configuration_change_hook.
1971 2011-06-09 Martin Rudalics <rudalics@gmx.at>
1973 * window.c (replace_window): Rename second argument REPLACEMENT to
1974 NEW. New third argument SETFLAG. Rewrite.
1975 (delete_window, make_dummy_parent): Call replace_window with
1977 (window_list_1): Move down in code.
1978 (run_window_configuration_change_hook): Move set_buffer part
1979 before select_frame_norecord part in order to unwind correctly.
1980 Rename count1 to count.
1981 (recombine_windows, delete_deletable_window, resize_root_window)
1982 (Fdelete_other_windows_internal)
1983 (Frun_window_configuration_change_hook, make_parent_window)
1984 (resize_window_check, resize_window_apply, Fresize_window_apply)
1985 (resize_frame_windows, Fsplit_window_internal)
1986 (Fdelete_window_internal, Fresize_mini_window_internal): New
1988 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
1990 2011-06-08 Martin Rudalics <rudalics@gmx.at>
1992 * window.h (window): Add some new members to window structure -
1993 normal_lines, normal_cols, new_total, new_normal, clone_number,
1994 splits, nest, prev_buffers, next_buffers.
1995 (WINDOW_TOTAL_SIZE): Move here from window.c.
1996 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
1998 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2000 (make_dummy_parent): Set new members of windows structure.
2001 (make_window): Move down in code. Handle new members of window
2003 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2004 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2005 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2006 (Fset_window_prev_buffers, Fwindow_next_buffers)
2007 (Fset_window_next_buffers, Fset_window_clone_number): New
2009 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2010 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2012 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2013 Argument WINDOW can be now internal window too.
2014 (Fwindow_use_time): Move up in code.
2015 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2017 (Fset_window_configuration, saved_window)
2018 (Fcurrent_window_configuration, save_window_save): Handle new
2019 members of window structure.
2020 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2021 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2022 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2023 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2024 Qget_mru_window, Qresize_root_window,
2025 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2026 Qauto_buffer_name; staticpro them.
2028 2011-06-07 Martin Rudalics <rudalics@gmx.at>
2030 * window.c (Fwindow_total_size, Fwindow_left_column)
2031 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2032 (Fwindow_list_1): New functions.
2033 (window_box_text_cols): Replace with window_body_cols.
2034 (Fwindow_width, Fscroll_left, Fscroll_right): Use
2035 window_body_cols instead of window_box_text_cols.
2036 (delete_window, Fset_window_configuration): Call
2037 delete_all_subwindows with window as argument.
2038 (delete_all_subwindows): Take a window as argument and not a
2040 (window_loop): Remove handling of GET_LRU_WINDOW and
2042 (Fget_lru_window, Fget_largest_window): Move to window.el.
2044 * window.h: Extern window_body_cols instead of
2045 window_box_text_cols. delete_all_subwindows now takes a
2046 Lisp_Object as argument.
2048 * indent.c (compute_motion, Fcompute_motion): Use
2049 window_body_cols instead of window_box_text_cols.
2051 * frame.c (delete_frame): Call delete_all_subwindows with root
2054 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2056 * fns.c (Fputhash): Document return value.
2058 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
2060 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2062 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2064 Cons<->int and similar integer overflow fixes (Bug#8794).
2066 Check for overflow when converting integer to cons and back.
2067 * charset.c (Fdefine_charset_internal, Fdecode_char):
2068 Use cons_to_unsigned to catch overflow.
2069 (Fencode_char): Use INTEGER_TO_CONS.
2070 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2071 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2072 * data.c (long_to_cons, cons_to_long): Remove.
2073 (cons_to_unsigned, cons_to_signed): New functions.
2074 These signal an error for invalid or out-of-range values.
2075 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2076 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2077 * font.c (Ffont_variation_glyphs):
2078 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2079 * lisp.h: Include <intprops.h>.
2080 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2081 (cons_to_signed, cons_to_unsigned): New decls.
2082 (long_to_cons, cons_to_long): Remove decls.
2083 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2084 (Fprimitive_undo): Use CONS_TO_INTEGER.
2085 * xfns.c (Fx_window_property): Likewise.
2086 * xselect.c: Include <limits.h>.
2087 (x_own_selection, selection_data_to_lisp_data):
2088 Use INTEGER_TO_CONS.
2089 (x_handle_selection_request, x_handle_selection_clear)
2090 (x_get_foreign_selection, Fx_disown_selection_internal)
2091 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2092 (lisp_data_to_selection_data): Use cons_to_unsigned.
2093 (x_fill_property_data): Use cons_to_signed.
2094 Report values out of range.
2096 Check for buffer and string overflow more precisely.
2097 * buffer.h (BUF_BYTES_MAX): New macro.
2098 * lisp.h (STRING_BYTES_MAX): New macro.
2099 * alloc.c (Fmake_string):
2100 * character.c (string_escape_byte8):
2101 * coding.c (coding_alloc_by_realloc):
2102 * doprnt.c (doprnt):
2103 * editfns.c (Fformat):
2105 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2106 since they may not be the same number.
2107 * editfns.c (Finsert_char):
2108 * fileio.c (Finsert_file_contents):
2109 Likewise for BUF_BYTES_MAX.
2111 * image.c: Use ptrdiff_t, not int, for sizes.
2112 (slurp_file): Switch from int to ptrdiff_t.
2114 (slurp_file): Check that file size fits in both size_t (for
2115 malloc) and ptrdiff_t (for sanity and safety).
2117 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2118 if b->modtime has its maximal value.
2120 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2122 Don't assume time_t can fit into int.
2123 * buffer.h (struct buffer.modtime): Now time_t, not int.
2124 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2125 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2127 Minor fixes for signed vs unsigned integers.
2128 * character.h (MAYBE_UNIFY_CHAR):
2129 * charset.c (maybe_unify_char):
2130 * keyboard.c (read_char, reorder_modifiers):
2131 XINT -> XFASTINT, since the integer must be nonnegative.
2132 * ftfont.c (ftfont_spec_pattern):
2133 * keymap.c (access_keymap, silly_event_symbol_error):
2134 XUINT -> XFASTINT, since the integer must be nonnegative.
2135 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2136 since it makes no difference and we prefer signed.
2137 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2138 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2141 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2143 * window.h (Fwindow_frame): Declare.
2145 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2147 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2148 (SPARE_MEMORY): Always define.
2149 (LARGE_REQUEST): Remove.
2150 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2152 2011-06-06 Martin Rudalics <rudalics@gmx.at>
2154 * lisp.h: Move EXFUNS for Fframe_root_window,
2155 Fframe_first_window and Fset_frame_selected_window to window.h.
2157 * window.h: Move EXFUNS for Fframe_root_window,
2158 Fframe_first_window and Fset_frame_selected_window here from
2161 * frame.c (Fwindow_frame, Fframe_first_window)
2162 (Fframe_root_window, Fframe_selected_window)
2163 (Fset_frame_selected_window): Move to window.c.
2164 (Factive_minibuffer_window): Move to minibuf.c.
2165 (Fother_visible_frames_p): New function.
2167 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2169 * window.c (decode_window, decode_any_window): Move up in code.
2170 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2171 (inhibit_frame_unsplittable): Remove unused variable.
2172 (Fwindow_buffer): Move up and rewrite doc-string.
2173 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2174 (Fwindow_prev): New functions.
2175 (Fwindow_frame): Move here from frame.c. Accept any window as
2177 (Fframe_root_window, Fframe_first_window)
2178 (Fframe_selected_window): Move here from frame.c. Accept frame
2179 or arbitrary window as argument. Update doc-strings.
2180 (Fminibuffer_window): Move up in code.
2181 (Fwindow_minibuffer_p): Move up in code and simplify.
2182 (Fset_frame_selected_window): Move here from frame.c.
2184 (Fselected_window, select_window, Fselect_window): Move up in
2185 code. Minor doc-string fixes.
2187 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2189 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2190 Do not assume that spare memory exists; that assumption is valid
2191 only if SYSTEM_MALLOC.
2192 (LARGE_REQUEST): New macro, so that the issue of large requests
2193 is separated from the issue of spare memory.
2195 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2197 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2200 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2202 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2205 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2207 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2209 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2211 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2212 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2214 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
2216 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2218 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
2220 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2221 (x_clipboard_manager_save): Add return value.
2222 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2224 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2225 Obey Vx_select_enable_clipboard_manager. Catch errors in
2226 x_clipboard_manager_save (Bug#8779).
2227 (Vx_select_enable_clipboard_manager): New variable.
2228 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
2230 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
2232 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2234 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2236 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2237 in the current matrix if keep_current_p is non-zero.
2239 2011-06-04 Eli Zaretskii <eliz@gnu.org>
2241 * bidi.c (bidi_level_of_next_char): Fix last change.
2243 2011-06-03 Eli Zaretskii <eliz@gnu.org>
2245 Support bidi reordering of text covered by display properties.
2247 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2248 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2249 (bidi_cache_search, bidi_cache_iterator_state)
2250 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2251 (bidi_level_of_next_char, bidi_move_to_visually_next):
2252 Support character positions inside a run of characters covered by a
2254 (bidi_paragraph_init, bidi_resolve_explicit_1)
2255 (bidi_level_of_next_char): Call bidi_fetch_char and
2256 bidi_fetch_char_advance instead of FETCH_CHAR and
2258 (bidi_init_it): Initialize new members.
2259 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2261 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2262 instead of using explicit *_CHAR codes.
2263 (bidi_resolve_explicit, bidi_resolve_weak):
2264 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
2265 bidirectional text is supported only in multibyte buffers.
2266 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2267 it to initialize the frame_window_p member of struct bidi_it.
2268 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2269 (bidi_resolve_explicit, bidi_resolve_weak)
2270 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2271 bidi_it->nchars is non-positive.
2272 (bidi_level_of_next_char): Don't try to lookup the cache for the
2273 next/previous character if nothing is cached there yet, or if we
2274 were just reseat()'ed to a new position.
2276 * xdisp.c (set_cursor_from_row): Set start and stop points
2277 according to the row's direction when priming the loop that looks
2278 for the glyph on which to display cursor.
2279 (single_display_spec_intangible_p): Function deleted.
2280 (display_prop_intangible_p): Reimplement to call
2281 handle_display_spec instead of single_display_spec_intangible_p.
2282 Accept 3 additional arguments needed by handle_display_spec.
2283 This fixes incorrect cursor motion across display property with complex
2284 values: lists, `(when COND...)' forms, etc.
2285 (single_display_spec_string_p): Support property values that are
2286 lists with the argument STRING its top-level element.
2287 (display_prop_string_p): Fix the condition for processing a
2288 property that is a list to be consistent with handle_display_spec.
2289 (handle_display_spec): New function, refactored from the
2290 last portion of handle_display_prop.
2291 (compute_display_string_pos): Accept additional argument
2292 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2293 value of a `display' property is a "replacing spec".
2294 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2295 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2296 the display property, but just return a value indicating whether
2297 the display property will replace the characters it covers.
2298 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2299 frame_window_p members of struct bidi_it.
2300 (compute_display_string_pos, compute_display_string_end):
2302 (push_it): Accept second argument POSITION, where pop_it should
2303 jump to continue iteration.
2304 (reseat_1): Initialize bidi_it.disp_pos.
2306 * keyboard.c (adjust_point_for_property): Adjust the call to
2307 display_prop_intangible_p to its new signature.
2309 * dispextern.h (struct bidi_it): New member frame_window_p.
2310 (bidi_init_it): Update prototypes.
2311 (display_prop_intangible_p): Update prototype.
2312 (compute_display_string_pos, compute_display_string_end):
2314 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2317 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
2319 Malloc failure behavior now depends on size of allocation.
2320 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2321 * lisp.h: Change signatures accordingly.
2322 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2323 All callers changed. (Bug#8762)
2325 * gnutls.c: Use Emacs's memory allocators.
2326 Without this change, the gnutls library would invoke malloc etc.
2327 directly, which causes problems on non-SYNC_INPUT hosts, and which
2328 runs afoul of improving memory_full behavior. (Bug#8761)
2329 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2330 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2331 xfree instead of the default malloc, realloc, free.
2332 (Fgnutls_boot): No need to check for memory allocation failure,
2333 since xmalloc does that for us.
2335 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
2336 * category.c (hash_get_category_set):
2337 * ccl.c (ccl_driver):
2338 * charset.c (Fdefine_charset_internal):
2339 * charset.h (struct charset.hash_index):
2340 * composite.c (get_composition_id, gstring_lookup_cache)
2341 (composition_gstring_put_cache):
2342 * composite.h (struct composition.hash_index):
2343 * dispextern.h (struct image.hash):
2344 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2345 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2346 (hashfn_equal, hashfn_user_defined, make_hash_table)
2347 (maybe_resize_hash_table, hash_lookup, hash_put)
2348 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2349 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2350 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2351 * image.c (make_image, search_image_cache, lookup_image)
2352 (xpm_put_color_table_h):
2353 * lisp.h (struct Lisp_Hash_Table):
2354 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
2355 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
2356 for hashes and hash indexes, instead of 'unsigned' and 'int'.
2357 * alloc.c (allocate_vectorlike):
2358 Check for overflow in vector size calculations.
2359 * ccl.c (ccl_driver):
2360 Check for overflow when converting EMACS_INT to int.
2361 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2362 need to be updated by these changes.
2363 * fns.c (make_hash_table, maybe_resize_hash_table):
2364 Check for integer overflow with large hash tables.
2365 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2366 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2367 (SXHASH_REDUCE): New macro.
2368 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2369 Use it instead of discarding useful hash info with large hash values.
2370 (sxhash_float): New function.
2371 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2372 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
2373 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2374 Rewrite to use FIXNUM_BITS, as this simplifies things.
2375 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2376 Adjust signatures to match updated version of code.
2377 (consing_since_gc): Now EMACS_INT, since a single hash table can
2378 use more than INT_MAX bytes.
2380 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2382 Make it possible to build with GCC-4.6+ -O2 -flto.
2384 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2386 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2388 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2389 Call minibuffer-inactive-mode.
2391 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
2393 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2394 Update dependencies.
2396 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2398 * data.c (init_data): Remove code for UTS, this system is not
2401 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2403 Don't force ./temacs to start in terminal mode.
2405 * frame.c (make_initial_frame): Initialize faces in all cases, not
2406 only when CANNOT_DUMP is defined.
2407 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2409 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2411 * dispnew.c (add_window_display_history): Use const for the string
2412 pointer. Remove declaration, not needed.
2414 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2416 Use 'inline', not 'INLINE'.
2417 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
2418 * alloc.c, fontset.c (INLINE): Remove.
2419 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2420 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2421 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2422 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2423 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2425 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2427 Make it possible to run ./temacs.
2429 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2430 syms_of_callproc does the same thing. Remove test for
2431 "initialized", do it in the caller.
2432 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2434 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2436 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2437 (read_minibuf): Use get_minibuffer.
2438 (syms_of_minibuf): Use DEFSYM.
2439 (Qmetadata): New var.
2440 * data.c (Qbuffer): Don't make it static.
2441 (syms_of_data): Use DEFSYM.
2443 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2445 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2446 (CCL_CODE_MIN): New macro.
2448 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2450 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2452 * eval.c (Qdebug): Now static.
2453 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2454 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2455 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2457 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2459 * image.c: Various fixes to ImageMagick code comments.
2460 (Fimagemagick_types): Doc fix.
2462 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2464 Minor fixes prompted by GCC 4.6.0 warnings.
2466 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2468 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2469 (x_clipboard_manager_save_all): Move extern decl to ...
2470 * xterm.h: ... here, so that it can be checked for consistency.
2472 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
2474 * xselect.c (x_clipboard_manager_save_frame)
2475 (x_clipboard_manager_save_all): New functions.
2476 (Fx_clipboard_manager_save): Lisp function deleted.
2478 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2479 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2481 * xterm.h: Update prototype.
2483 2011-05-28 William Xu <william.xwl@gmail.com>
2485 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2488 2011-05-28 Jim Meyering <meyering@redhat.com>
2490 Avoid a sign-extension bug in crypto_hash_function.
2491 * fns.c (to_uchar): Define.
2492 (crypto_hash_function): Use it to convert some newly-signed
2493 variables to unsigned, to avoid sign-extension bugs. For example,
2494 without this change, (md5 "truc") would evaluate to
2495 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2496 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
2497 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
2499 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2501 Integer overflow fixes.
2503 * dbusbind.c: Serial number integer overflow fixes.
2504 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
2505 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2506 to hold a serial number that is too large for a fixnum.
2507 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2508 Check for serial numbers out of range. Decode any serial number
2509 that was so large that it became a float. (Bug#8722)
2511 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2512 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2513 Use XFASTINT rather than XUINT when numbers are nonnegative.
2514 (xd_append_arg, Fdbus_method_return_internal):
2515 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2516 arguments, check that Lisp number is nonnegative, rather than
2517 silently wrapping negative numbers around. (Bug#8722)
2518 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
2521 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2523 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2525 ccl: add integer overflow checks
2526 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2527 (IN_INT_RANGE): New macros.
2528 (ccl_driver): Use them to check for integer overflow when
2529 decoding a CCL program. Many of the new checks are whether XINT (x)
2530 fits in int; it doesn't always, on 64-bit hosts. The new version
2531 doesn't catch all possible integer overflows, but it's an
2532 improvement. (Bug#8719)
2534 * alloc.c (make_event_array): Use XINT, not XUINT.
2535 There's no need for unsigned here.
2537 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2538 This follows up to the 2011-05-06 change that substituted uintptr_t
2539 for EMACS_INT. This case wasn't caught back then.
2541 Rework Fformat to avoid integer overflow issues.
2542 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2543 now (part of C89). Include <verify.h>.
2544 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2545 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2546 (Fformat): Avoid the prepass trying to compute sizes; it was only
2547 approximate and thus did not catch overflow reliably. Instead, walk
2548 through the format just once, formatting and computing sizes as we go,
2549 checking for integer overflow at every step, and allocating a larger
2550 buffer as needed. Keep track separately whether the format is
2551 multibyte. Keep only the most-recently calculated precision, rather
2552 than them all. Record whether each argument has been converted to
2553 string. Use EMACS_INT, not int, for byte and char and arg counts.
2554 Support field widths and precisions larger than INT_MAX. Avoid
2555 sprintf's undefined behavior with conversion specifications such as %#d
2556 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2557 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2558 formatting out-of-range floating point numbers with int
2561 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2563 * data.c: Avoid integer truncation in expressions involving floats.
2564 * data.c: Include <intprops.h>.
2565 (arith_driver): When there's an integer overflow in an expression
2566 involving floating point, convert the integers to floating point
2567 so that the resulting value does not suffer from catastrophic
2568 integer truncation. For example, on a 64-bit host (* 4
2569 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2570 Do not rely on undefined behavior after integer overflow.
2572 merge count_size_as_multibyte, parse_str_to_multibyte
2573 * character.c, character.h (count_size_as_multibyte):
2574 Rename from parse_str_to_multibyte; all uses changed.
2575 Check for integer overflow.
2576 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2577 since it's now a duplicate of the other. This is more of
2578 a character than a buffer op, so better that it's in character.c.
2579 * fns.c, print.c: Adjust to above changes.
2581 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2583 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2585 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2587 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2588 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2589 (x_clipboard_manager_save): Now static.
2590 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2592 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2593 (crypto_hash_function): Now static.
2594 Fix pointer signedness problems. Avoid unnecessary initializations.
2596 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
2598 * termhooks.h (Vselection_alist): Make it terminal-local.
2600 * terminal.c (create_terminal): Initialize it.
2602 * xselect.c: Support for clipboard managers.
2603 (Vselection_alist): Move to termhooks.h as terminal-local var.
2604 (LOCAL_SELECTION): New macro.
2605 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2606 (symbol_to_x_atom): Remove gratuitous arg.
2607 (x_handle_selection_request, lisp_data_to_selection_data)
2608 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
2609 (x_own_selection, x_get_local_selection, x_convert_selection):
2610 New arg, specifying work frame. Use terminal-local Vselection_alist.
2611 (some_frame_on_display): Delete unused function.
2612 (Fx_own_selection_internal, Fx_get_selection_internal)
2613 (Fx_disown_selection_internal, Fx_selection_owner_p)
2614 (Fx_selection_exists_p): New optional frame arg.
2615 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2616 (x_handle_selection_clear): Don't treat other terminals with the
2617 same keyboard specially. Use the terminal-local Vselection_alist.
2618 (x_clear_frame_selections): Use Frun_hook_with_args.
2620 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2622 * xterm.h: Add support for those atoms.
2624 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
2626 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2627 (converted_selections, conversion_fail_tag): New global variables.
2628 (x_selection_request_lisp_error): Free the above.
2629 (x_get_local_selection): Remove unnecessary code.
2630 (x_reply_selection_request): Args changed; handle arbitrary array
2631 of converted selections stored in converted_selections.
2632 Separate the XChangeProperty and SelectionNotify steps.
2633 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2634 (x_convert_selection): New function.
2635 (x_handle_selection_event): Simplify.
2636 (x_get_foreign_selection): Don't ignore incoming requests while
2637 waiting for an answer; this will fail when we implement
2638 SAVE_TARGETS, and seems unnecessary anyway.
2639 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
2640 (Vx_sent_selection_functions): Doc fix.
2642 2011-05-26 Leo Liu <sdl.web@gmail.com>
2644 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
2646 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2648 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
2650 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
2651 for fringe update if it has periodic bitmap.
2652 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
2653 and fringe_bitmap_periodic_p.
2655 * fringe.c (get_fringe_bitmap_data): New function.
2656 (draw_fringe_bitmap_1, update_window_fringes): Use it.
2657 (update_window_fringes): Record periodicity of fringe bitmap in glyph
2658 row. Mark glyph row for fringe update if periodicity changed.
2660 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
2661 for fringe update unless it has periodic bitmap.
2663 2011-05-25 Kenichi Handa <handa@m17n.org>
2665 * xdisp.c (get_next_display_element): Set correct it->face_id for
2666 a static composition.
2668 2011-05-24 Leo Liu <sdl.web@gmail.com>
2671 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
2673 * fns.c (crypto_hash_function, Fsha1): New function.
2674 (Fmd5): Use crypto_hash_function.
2675 (syms_of_fns): Add Ssha1.
2677 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2679 * gnutls.c: Remove unused macros.
2680 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
2681 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
2682 Remove macros that are defined and never used.
2683 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
2685 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
2687 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
2688 (Fx_get_selection_internal): Minor cleanup.
2689 (Fx_own_selection_internal): Rename arguments for consistency with
2692 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2694 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
2696 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
2698 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
2700 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2702 * dispnew.c (scrolling_window): Don't exclude the case that the
2703 last enabled row in the desired matrix touches the bottom boundary.
2705 2011-05-21 Glenn Morris <rgm@gnu.org>
2707 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
2708 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
2709 and add some more files.
2711 2011-05-20 Eli Zaretskii <eliz@gnu.org>
2713 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
2714 report_file_error introduced by the change from 2011-05-07.
2716 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
2718 * systime.h (Time): Define only if emacs is defined.
2719 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
2720 where the include path doesn't have X11/X.h by default. See
2721 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
2723 2011-05-20 Kenichi Handa <handa@m17n.org>
2725 * composite.c (find_automatic_composition): Fix previous change.
2727 2011-05-20 Glenn Morris <rgm@gnu.org>
2729 * lisp.mk: New file, split from Makefile.in.
2730 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
2731 (shortlisp): Remove.
2732 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
2734 2011-05-19 Glenn Morris <rgm@gnu.org>
2736 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
2737 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
2738 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
2739 (lisp): Set the order to that of loadup.el.
2740 (shortlisp): Make it a copy of $lisp.
2741 (SOME_MACHINE_LISP): Remove.
2742 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
2743 Use just $shortlisp, not $SOME_MACHINE_LISP too.
2745 2011-05-18 Kenichi Handa <handa@m17n.org>
2747 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
2748 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
2749 (find_automatic_composition): Mostly rewrite for efficiency.
2751 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
2753 * makefile.w32-in: Update dependencies.
2755 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
2757 * menu.c: Include limits.h (fixes the MS-Windows build broken by
2758 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
2760 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
2762 Fix some integer overflow issues, such as string length overflow.
2764 * insdel.c (count_size_as_multibyte): Check for string overflow.
2766 * character.c (lisp_string_width): Check for string overflow.
2767 Use EMACS_INT, not int, for string indexes and lengths; in
2768 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
2769 the resulting string length overflows an EMACS_INT; instead,
2770 report a string overflow if no precision given. When checking for
2771 precision exhaustion, use a check that cannot possibly have
2772 integer overflow. (Bug#8675)
2773 * character.h (lisp_string_width): Adjust to new signature.
2775 * alloc.c (string_overflow): New function.
2776 (Fmake_string): Use it. This doesn't change behavior, but saves
2777 a few bytes and will simplify future changes.
2778 * character.c (string_escape_byte8): Likewise.
2779 * lisp.h (string_overflow): New decl.
2781 Fixups, following up to the user-interface timestamp change.
2782 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
2783 for UI timestamps, instead of unsigned long.
2784 * msdos.c (mouse_get_pos): Likewise.
2785 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
2786 * w32gui.h (Time): Define by including "systime.h" rather than by
2787 declaring it ourselves. (Bug#8664)
2789 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
2790 * image.c (clear_image_cache): Likewise.
2792 * term.c (term_mouse_position): Don't assume time_t wraparound.
2794 Be more systematic about user-interface timestamps.
2795 Before, the code sometimes used 'Time', sometimes 'unsigned long',
2796 and sometimes 'EMACS_UINT', to represent these timestamps.
2797 This change causes it to use 'Time' uniformly, as that's what X uses.
2798 This makes the code easier to follow, and makes it easier to catch
2799 integer overflow bugs such as Bug#8664.
2800 * frame.c (Fmouse_position, Fmouse_pixel_position):
2801 Use Time, not unsigned long, for user-interface timestamps.
2802 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
2803 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
2804 * keyboard.h (last_event_timestamp): Likewise.
2805 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
2806 * menu.h (xmenu_show): Likewise.
2807 * term.c (term_mouse_position): Likewise.
2808 * termhooks.h (struct input_event.timestamp): Likewise.
2809 (struct terminal.mouse_position_hook): Likewise.
2810 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
2811 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
2812 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
2813 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
2815 * menu.h, termhooks.h: Include "systime.h", for Time.
2817 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
2818 Don't assume that the difference between two unsigned long values
2819 can fit into an integer. At this point, we know button_down_time
2820 <= event->timestamp, so the difference must be nonnegative, so
2821 there's no need to cast the result if double-click-time is
2822 nonnegative, as it should be; check that it's nonnegative, just in
2823 case. This bug is triggered when events are more than 2**31 ms
2824 apart (about 25 days). (Bug#8664)
2826 * xselect.c (last_event_timestamp): Remove duplicate decl.
2827 (x_own_selection): Remove needless cast to unsigned long.
2829 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
2830 that always fit in int. Use a sentinel instead of a counter, to
2831 avoid a temp and to allay GCC's concerns about possible int overflow.
2832 * frame.h (struct frame): Use int for menu_bar_items_used
2833 instead of EMACS_INT, since it always fits in int.
2835 * menu.c (grow_menu_items): Check for int overflow.
2837 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
2839 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
2840 Before, the code was not consistent. These values cannot exceed
2841 2**31 - 1 so there's no need to make them unsigned.
2842 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
2843 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
2844 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
2846 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
2848 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
2849 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
2850 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
2851 presumably because the widths might not match.
2853 * window.c (size_window): Avoid needless test at loop start.
2855 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
2857 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
2859 2011-05-12 Drew Adams <drew.adams@oracle.com>
2861 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
2863 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2865 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
2866 `width' to `bar_area_x' and `bar_area_width', respectively.
2867 (x_scroll_run): Take account of fringe background extension.
2869 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
2870 Rename local vars `left' and `width' to `bar_area_x' and
2871 `bar_area_width', respectively.
2872 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
2873 background extension.
2875 2011-05-10 Jim Meyering <meyering@redhat.com>
2877 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
2879 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
2881 * image.c (Finit_image_library): Return t for built-in image types,
2882 like pbm and xbm. (Bug#8640)
2884 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
2886 * w32menu.c (set_frame_menubar): Fix submenu allocation.
2888 2011-05-07 Eli Zaretskii <eliz@gnu.org>
2890 * w32console.c (Fset_screen_color): Doc fix.
2891 (Fget_screen_color): New function.
2892 (syms_of_ntterm): Defsubr it.
2894 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
2895 unlink the temporary file if Fcall_process didn't create it in the
2897 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
2898 child process will be redirected to a file specified with `:file'.
2899 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
2900 cue to call_process_cleanup not to close that handle.
2902 2011-05-07 Ben Key <bkey76@gmail.com>
2904 * makefile.w32-in: The bootstrap-temacs rule now makes use of
2905 one of two shell specific rules, either bootstrap-temacs-CMD or
2906 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
2907 to the previous implementation of the bootstrap-temacs rule.
2908 The bootstrap-temacs-CMD rule is similar to the previous
2909 implementation of the bootstrap-temacs rule except that it
2910 makes use of the ESC_CFLAGS variable instead of the CFLAGS
2913 These changes, along with some changes to nt/configure.bat,
2914 nt/gmake.defs, and nt/nmake.defs, are required to extend my
2915 earlier fix to add support for --cflags and --ldflags options
2916 that include quotes so that it works whether make uses cmd or
2919 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
2921 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
2922 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
2924 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
2925 a string. Handle both cases.
2926 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
2927 (Fdbus_register_method): Use Qinvalid_function.
2929 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
2931 * makefile.w32-in: Update dependencies.
2932 (LISP_H): Add inttypes.h and stdin.h.
2933 (PROCESS_H): Add unistd.h.
2935 2011-05-06 Eli Zaretskii <eliz@gnu.org>
2937 * lread.c: Include limits.h (fixes the MS-Windows build broken by
2938 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
2940 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
2942 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
2944 * term.c (vfatal): Remove stray call to va_end.
2945 It's not needed and the C Standard doesn't allow it here anyway.
2947 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
2948 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
2950 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
2953 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
2955 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2957 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
2959 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
2961 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
2963 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
2964 * charset.c (Fdefine_charset_internal): Don't initialize
2965 charset.code_space[15]. The value was garbage, on hosts with
2966 32-bit int (Bug#8600).
2968 * lread.c (read_integer): Be more consistent with string-to-number.
2969 Use string_to_number to do the actual conversion; this avoids
2970 rounding errors and fixes some other screwups. Without this fix,
2971 for example, #x1fffffffffffffff was misread as -2305843009213693952.
2972 (digit_to_number): Move earlier, for benefit of read_integer.
2973 Return -1 if the digit is out of range for the base, -2 if it is
2974 not a digit in any supported base. (Bug#8602)
2976 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
2978 * dispnew.c (scrolling_window): Return 1 if we scrolled,
2979 to match comment at start of function. This also removes a
2980 GCC warning about overflow in a 32+64-bit port.
2982 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
2984 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
2985 Reported by Stefan Monnier in
2986 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
2987 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2988 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
2990 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
2991 (EMACS_UINTPTR): Likewise, with uintptr_t.
2993 * lisp.h: Prefer 64-bit EMACS_INT if available.
2994 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
2995 on 32-bit hosts that have 64-bit int, so that they can access
2997 However, temporarily disable this change unless the temporary
2998 symbol WIDE_EMACS_INT is defined.
3000 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3002 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3003 This removes an assumption that EMACS_INT and long are the same
3004 width as pointers. The assumption is true for Emacs porting targets
3005 now, but we want to make other targets possible.
3006 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3007 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3008 In the rest of the code, change types of integers that hold casted
3009 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3010 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3011 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3012 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3013 No need to cast type when ORing.
3014 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3015 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3016 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3017 assume EMACS_INT is the same width as char *.
3018 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3019 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3020 Remove no-longer-needed casts.
3021 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3022 (xg_tool_bar_help_callback, xg_make_tool_item):
3023 Use EMACS_INTPTR to hold an integer
3024 that will be cast to void *; this can avoid a GCC warning
3025 if EMACS_INT is not the same width as void *.
3026 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3027 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3028 (current_message_1, set_message_1):
3029 Use a local to convert to proper width without a cast.
3030 * xmenu.c (dialog_selection_callback): Likewise.
3032 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3033 Also, don't assume VALBITS / RAND_BITS is less than 5,
3034 and don't rely on undefined behavior when shifting a 1 left into
3036 * lisp.h (get_random): Change signature to match.
3038 * lread.c (hash_string): Use size_t, not int, for hash computation.
3039 Normally we prefer signed values; but hashing is special, because
3040 it's better to use unsigned division on hash table sizes so that
3041 the remainder is nonnegative. Also, size_t is the natural width
3042 for hashing into memory. The previous code used 'int', which doesn't
3043 retain enough info to hash well into very large tables.
3044 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3046 * dbusbind.c: Don't possibly lose pointer info when converting.
3047 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3048 Use XPNTR rather than XHASH, so that the high-order bits of
3049 the pointer aren't lost when converting through void *.
3051 * eval.c (Fautoload): Don't double-shift a pointer.
3053 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3055 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
3057 * gnutls.c (DEF_GNUTLS_FN):
3058 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3060 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3062 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3065 2011-05-05 Eli Zaretskii <eliz@gnu.org>
3067 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3068 New version that can reserve upto 2GB of heap space.
3070 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
3072 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3074 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3076 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3077 `gnutls_certificate_set_x509_key_file'.
3079 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
3081 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3082 Update dependencies.
3084 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3086 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3087 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3088 Remove unused parameter `fildes'.
3089 * process.c (read_process_output, send_process): Don't pass it.
3091 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3093 Fix previous change: the library cache is defined in w32.c.
3094 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3095 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3097 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
3099 Implement dynamic loading of GnuTLS on Windows.
3101 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3102 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3103 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3106 * gnutls.c (Qgnutls_dll): Define.
3107 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3108 (gnutls_*): Declare function pointers.
3109 (init_gnutls_functions): New function to initialize function pointers.
3110 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3111 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3112 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3113 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3114 (emacs_gnutls_write, emacs_gnutls_read)
3115 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3116 (Fgnutls_available_p): New function.
3117 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3118 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3119 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3121 * image.c: Include w32.h.
3122 (Vimage_type_cache): Delete.
3123 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3124 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3125 (w32_delayed_load): Move to w32.c.
3127 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3129 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3130 (w32_delayed_load): Move from image.c. When loading a library, record
3131 its filename in the :loaded-from property of the library id.
3132 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3133 Initialize and staticpro them.
3134 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3136 * process.c: Include lisp.h before w32.h, not after.
3137 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3138 instead of gnutls_record_check_pending.
3140 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3142 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3144 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3145 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3148 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3150 * xterm.c (x_set_frame_alpha): Do not set property on anything
3151 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3153 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3155 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3157 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
3159 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3160 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3161 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3162 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3163 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3164 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3165 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3166 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3167 (Qgnutls_bootprop_callbacks_verify): Make static.
3169 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3171 * callproc.c: Indentation fixup.
3173 * sysdep.c (wait_for_termination_1): Make static.
3174 (wait_for_termination, interruptible_wait_for_termination):
3175 Move after wait_for_termination_1.
3177 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3179 * sysdep.c (interruptible_wait_for_termination): New function
3180 which is like wait_for_termination, but allows keyboard
3183 * callproc.c (Fcall_process): Add (:file "file") as an option for
3185 (Fcall_process_region): Ditto.
3187 2011-04-30 Eli Zaretskii <eliz@gnu.org>
3189 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3190 rather than `XVECTOR (FOO)->size'.
3192 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3193 inttypes.h, as a gnulib replacement is used if it not available in
3196 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3198 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3199 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3200 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3202 * coding.c (coding_alloc_by_realloc): Error out if destination
3203 will grow beyond MOST_POSITIVE_FIXNUM.
3204 (decode_coding_emacs_mule): Abort if there isn't enough place in
3205 charbuf for the composition carryover bytes. Reserve an extra
3206 space for up to 2 characters produced in a loop.
3207 (decode_coding_iso_2022): Abort if there isn't enough place in
3208 charbuf for the composition carryover bytes.
3210 2011-04-21 Eli Zaretskii <eliz@gnu.org>
3212 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3213 aborting when %lld or %lll format is passed.
3214 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3215 %llo or %llx format is passed. (Bug#8545)
3217 * window.c (window_scroll_line_based): Use a marker instead of
3218 simple variables to record original value of point. (Bug#7952)
3220 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3221 produced by %s or %c overflows available buffer space. (Bug#8545)
3223 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3225 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
3226 (SIZE_MAX): Move defn after all includes, as they might #define it.
3228 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3230 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3232 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3234 * keyboard.c (Qdelayed_warnings_hook): Define.
3235 (command_loop_1): Run `delayed-warnings-hook'
3236 if Vdelayed_warnings_list is non-nil.
3237 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3238 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3240 2011-04-28 Eli Zaretskii <eliz@gnu.org>
3242 * doprnt.c (doprnt): Don't return value smaller than the buffer
3243 size if the message was truncated. (Bug#8545).
3245 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
3247 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3248 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3250 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3252 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3254 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
3256 * makefile.w32-in: Update dependencies.
3258 2011-04-27 Eli Zaretskii <eliz@gnu.org>
3260 Improve `doprnt' and its usage. (Bug#8545)
3261 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3262 `format_end'. Remove support for %l as a conversion specifier.
3263 Don't use xrealloc. Improve diagnostics when the %l size modifier
3264 is used. Update the commentary.
3266 * eval.c (verror): Simplify calculation of size_t.
3268 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3271 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3273 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3276 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3278 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3279 This makes this file independent of the recent pseudovector change.
3281 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
3283 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3285 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
3286 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
3287 Remove unused local.
3288 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
3290 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
3291 GCC 4.6.0 optimizes based on type-based alias analysis.
3292 For example, if b is of type struct buffer * and v of type struct
3293 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3294 != &v->size, and therefore "v->size = 1; b->size = 2; return
3295 v->size;" must therefore return 1. This assumption is incorrect
3296 for Emacs, since it type-puns struct Lisp_Vector * with many other
3297 types. To fix this problem, this patch adds a new type struct
3298 vectorlike_header that documents the constraints on layout of vectors
3299 and pseudovectors, and helps optimizing compilers not get fooled
3300 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3301 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
3302 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3304 (XSETPVECTYPE): Rewrite in terms of new macro.
3305 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3306 This is a bit clearer, and further avoids the possibility of
3307 undesirable aliasing.
3308 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
3309 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
3310 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3311 since Lisp_Subr is a special case (no "next" field).
3312 (ASIZE): Now uses header.size rather than size.
3313 All previous uses of XVECTOR (foo)->size replaced to use this macro,
3314 to avoid the hassle of writing XVECTOR (foo)->header.size.
3315 (struct vectorlike_header): New type.
3316 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3317 object, to help avoid aliasing.
3318 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3319 (SUBRP): Likewise, since Lisp_Subr is a special case.
3320 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3321 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3322 (struct Lisp_Hash_Table): Combine first two members into a single
3323 struct vectorlike_header member. All uses of "size" and "next" members
3324 changed to be "header.size" and "header.next".
3325 * buffer.h (struct buffer): Likewise.
3326 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3327 * frame.h (struct frame): Likewise.
3328 * process.h (struct Lisp_Process): Likewise.
3329 * termhooks.h (struct terminal): Likewise.
3330 * window.c (struct save_window_data, struct saved_window): Likewise.
3331 * window.h (struct window): Likewise.
3332 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3333 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3334 * buffer.c (init_buffer_once): Likewise.
3335 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3337 * process.c (Fformat_network_address): Use local var for size,
3340 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3342 Make the Lisp reader and string-to-float more consistent (Bug#8525)
3343 * data.c (atof): Remove decl; no longer used or needed.
3344 (digit_to_number): Move to lread.c.
3345 (Fstring_to_number): Use new string_to_number function, to be
3346 consistent with how the Lisp reader treats infinities and NaNs.
3347 Do not assume that floating-point numbers represent EMACS_INT
3348 without losing information; this is not true on most 64-bit hosts.
3349 Avoid double-rounding errors, by insisting on integers when
3350 parsing non-base-10 numbers, as the documentation specifies.
3351 * lisp.h (string_to_number): New decl, replacing ...
3352 (isfloat_string): Remove.
3353 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
3354 (read1): Do not accept +. and -. as integers; this
3355 appears to have been a coding error. Similarly, do not accept
3356 strings like +-1e0 as floating point numbers. Do not report
3357 overflow for integer overflows unless the base is not 10 which
3358 means we have no simple and reliable way to continue.
3359 Break out the floating-point parsing into a new
3360 function string_to_number, so that Fstring_to_number parses
3361 floating point numbers consistently with the Lisp reader.
3362 (digit_to_number): Move here from data.c. Make it static inline.
3363 (E_CHAR, EXP_INT): Remove, replacing with ...
3364 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3365 (string_to_number): New function, replacing isfloat_string.
3366 This function checks for valid syntax and produces the resulting
3367 Lisp float number too. Rework it so that string-to-number
3368 no longer mishandles examples like "1.0e+". Use strtoumax,
3369 so that overflow for non-base-10 numbers is reported only when
3370 there's no portable and simple way to convert to floating point.
3372 * textprop.c (set_text_properties_1): Rewrite for clarity,
3373 and to avoid GCC warning about integer overflow.
3375 * intervals.h (struct interval): Use EMACS_INT for members
3376 where EMACS_UINT might cause problems. See
3377 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3378 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3379 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3381 (offset_intervals): Tell GCC not to worry about length overflow
3382 when negating a negative length.
3384 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3385 (overrun_check_free): Likewise.
3387 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3388 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3391 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3392 (gnutls_make_error): Rename local to avoid shadowing.
3393 (gnutls_emacs_global_deinit): ifdef out; not used.
3394 (Fgnutls_boot): Use const for pointer to readonly storage.
3395 Comment out unused local. Fix pointer signedness problems.
3397 * lread.c (openp): Don't stuff size_t into an 'int'.
3398 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3399 about possible signed overflow.
3401 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3402 (GDK_KEY_g): Don't define if already defined.
3403 (xg_prepare_tooltip): Avoid pointer signedness problem.
3404 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3406 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3407 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3409 * xfns.c (Fx_window_property): Simplify a bit,
3410 to make a bit faster and to avoid GCC 4.6.0 warning.
3411 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3413 * fns.c (internal_equal): Don't assume size_t fits in int.
3415 * alloc.c (compact_small_strings): Tighten assertion a little.
3417 Replace pEd with more-general pI, and fix some printf arg casts.
3418 * lisp.h (pI): New macro, generalizing old pEd macro to other
3419 conversion specifiers. For example, use "...%"pI"d..." rather
3420 than "...%"pEd"...".
3421 (pEd): Remove. All uses replaced with similar uses of pI.
3422 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3423 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3424 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3425 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3426 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3427 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3428 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3430 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3431 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3432 * print.c (safe_debug_print, print_object): Likewise.
3433 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3435 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3436 avoiding the 0 flag, which is not portable.
3437 * process.c (Fmake_network_process): Use pI to avoid cast.
3438 * region-cache.c (pp_cache): Likewise.
3439 * xdisp.c (decode_mode_spec): Likewise.
3440 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3441 behavior on 64-bit hosts with printf arg.
3442 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
3443 (x_stop_queuing_selection_requests): Likewise.
3444 (x_get_window_property): Don't truncate byte count to an 'int'
3447 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3448 here, since it parses constructs like leading '-' and spaces,
3449 which are not wanted; and it overflows with large numbers.
3450 Instead, simply match F[0-9]+, which is what is wanted anyway.
3452 * alloc.c: Remove unportable assumptions about struct layout.
3453 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3454 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3455 (allocate_vectorlike, make_pure_vector): Use the new macros,
3456 plus offsetof, to remove unportable assumptions about struct layout.
3457 These assumptions hold on all porting targets that I know of, but
3458 they are not guaranteed, they're easy to remove, and removing them
3459 makes further changes easier.
3461 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3462 This doesn't fix a bug but makes the code clearer.
3463 (string_overrun_cookie): Now const. Use initializers that
3464 don't formally overflow signed char, to avoid warnings.
3465 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3466 can cause Emacs to crash when string overrun checking is enabled.
3467 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3468 multiple of sizeof (EMACS_INT); it need not be, if
3469 alignof(EMACS_INT) < sizeof (EMACS_INT).
3470 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
3472 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
3474 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3476 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3478 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
3479 supposed to be handshaking. (Bug#8556)
3480 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3482 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
3484 * lisp.h (Qdebug): List symbol.
3485 * eval.c (Qdebug): Restore global linkage.
3486 * keyboard.c (debug-on-event): New variable.
3487 (handle_user_signal): Break into debugger when debug-on-event
3488 matches the current signal symbol.
3490 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3492 * alloc.c (check_sblock, check_string_bytes)
3493 (check_string_free_list): Convert to standard C.
3495 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3497 * w32.c (emacs_gnutls_push): Fix typo.
3499 2011-04-25 Eli Zaretskii <eliz@gnu.org>
3501 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3502 "cast to pointer from integer of different size".
3504 Improve doprnt and its use in verror. (Bug#8545)
3505 * doprnt.c (doprnt): Document the set of format control sequences
3506 supported by the function. Use SAFE_ALLOCA instead of always
3509 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3510 is one byte too soon. Don't use xrealloc; instead xfree and
3513 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3515 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3518 * gnutls.c: Renamed global_initialized to
3519 gnutls_global_initialized. Added internals for the
3520 :verify-hostname-error, :verify-error, and :verify-flags
3521 parameters of `gnutls-boot' and documented those parameters in the
3522 docstring. Start callback support.
3523 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3524 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3525 on error. Return error code.
3526 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3527 (emacs_gnutls_read): Likewise.
3528 (Fgnutls_boot): Return handshake error code.
3529 (emacs_gnutls_handle_error): New function.
3530 (wsaerror_to_errno): Likewise.
3532 * w32.h (emacs_gnutls_pull): Add prototype.
3533 (emacs_gnutls_push): Likewise.
3535 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3536 (emacs_gnutls_push): Likewise.
3538 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3540 * process.c (wait_reading_process_output): Check if GnuTLS
3541 buffered some data internally if no FDs are set for TLS
3544 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3545 (LIBS): Link to USER_LIBS.
3546 ($(BLD)/gnutls.$(0)): New target.
3548 2011-04-24 Eli Zaretskii <eliz@gnu.org>
3550 * xdisp.c (handle_single_display_spec): Rename the
3551 display_replaced_before_p argument into display_replaced_p, to
3552 make it consistent with the commentary. Fix typos in the
3555 * textprop.c (syms_of_textprop): Remove dead code.
3556 (copy_text_properties): Delete obsolete commentary about an
3557 interface that was deleted long ago. Fix typos in the description
3560 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3561 to changes in oldXMenu/XMenu.h from 2011-04-16.
3562 <menu_help_message, prev_menu_help_message>: Constify.
3563 (IT_menu_make_room): menu->help_text is now `const char **';
3566 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3567 to changes in oldXMenu/XMenu.h from 2011-04-16.
3568 (struct XMenu): Declare `help_text' `const char **'.
3570 * xfaces.c <Qunspecified>: Make extern again.
3572 * syntax.c: Include sys/types.h before including regex.h, as
3575 * doc.c (get_doc_string): Improve the format passed to `error'.
3577 * doprnt.c (doprnt): Improve commentary.
3579 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3581 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3584 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3585 changes in globals.h immediately force recompilation.
3586 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3587 $(CURDIR)/s/ms-w32.h.
3588 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
3590 * character.c (Fchar_direction): Function deleted.
3591 (syms_of_character): Don't defsubr it.
3592 <char-direction-table>: Deleted.
3594 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3596 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3597 * doprnt.c: Include limits.h.
3598 (SIZE_MAX): New macro.
3599 (doprnt): Return a size_t value. 2nd arg is now size_t.
3600 Many local variables are now size_t instead of int or unsigned.
3601 Improve overflow protection. Support `l' modifier for integer
3602 conversions. Support %l conversion. Don't assume an EMACS_INT
3603 argument for integer conversions and for %c.
3605 * lisp.h (doprnt): Restore prototype.
3607 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3610 * Makefile.in (base_obj): Add back doprnt.o.
3612 * deps.mk (doprnt.o): Add back prerequisites.
3613 (callint.o): Depend on character.h.
3615 * eval.c (internal_lisp_condition_case): Include the handler
3616 representation in the error message.
3617 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3618 when breaking from the loop.
3620 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3622 * callint.c (Fcall_interactively): When displaying error message
3623 about invalid control letter, pass the character's codepoint, not
3624 a pointer to its multibyte form. Improve display of the character
3625 in octal and display also its hex code.
3627 * character.c (char_string): Use %x to display the (unsigned)
3628 codepoint of an invalid character, to avoid displaying a bogus
3631 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3632 `error', not SYMBOL_NAME itself.
3634 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3635 character arguments to `error'.
3637 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3638 to `error' in error message about FINAL_CHAR argument. Make sure
3639 FINAL_CHAR is a character, and use %c when it is passed as
3640 argument to `error'.
3642 2011-04-23 Eli Zaretskii <eliz@gnu.org>
3644 * s/ms-w32.h (localtime): Redirect to sys_localtime.
3646 * w32.c: Include <time.h>.
3647 (sys_localtime): New function.
3649 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
3651 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
3653 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
3655 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
3657 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
3660 2011-04-19 Eli Zaretskii <eliz@gnu.org>
3662 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
3663 gl_state.e_property when gl_state.object is Qt.
3665 * insdel.c (make_gap_larger): Remove limitation of buffer size
3668 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
3670 * xdisp.c (lookup_glyphless_char_display)
3671 (produce_glyphless_glyph): Handle cons cell entry in
3672 glyphless-char-display.
3673 (Vglyphless_char_display): Document it.
3675 * term.c (produce_glyphless_glyph): Handle cons cell entry in
3676 glyphless-char-display.
3678 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
3680 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
3682 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
3684 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
3685 definition for no-X builds.
3687 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
3689 Static checks with GCC 4.6.0 and non-default toolkits.
3691 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
3693 * process.c (keyboard_bit_set): Define only if SIGIO.
3694 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
3695 (send_process): Repair possible setjmp clobbering.
3697 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
3699 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
3701 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
3703 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
3704 Define only if needed.
3706 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
3707 by pacifying GCC about it. Maybe it's time to retire it?
3708 * xfaces.c (USG, __TIMEVAL__): Likewise.
3710 * dispextern.h (struct redisplay_interface): Rename param
3712 * termhooks.h (struct terminal): Likewise.
3713 * xterm.c (xembed_send_message): Likewise.
3715 * insdel.c (make_gap_smaller): Define only if
3716 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
3718 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
3721 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
3722 so that we aren't warned about unused symbols.
3724 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
3726 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
3728 * xfns.c (x_real_positions): Mark locals as initialized.
3730 * xmenu.c (xmenu_show): Don't use uninitialized vars.
3732 * xterm.c: Fix problems found by static analysis with other toolkits.
3733 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
3734 (x_dispatch_event): Declare static if USE_GTK, and
3735 define if USE_GTK || USE_X_TOOLKIT.
3736 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
3737 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
3738 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
3739 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
3741 * xmenu.c (menu_help_callback): Pointer type fixes.
3742 Use const pointers when pointing at readonly data. Avoid pointer
3744 (FALSE): Remove unused macro.
3745 (update_frame_menubar): Remove unused decl.
3747 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
3749 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
3750 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
3751 (single_menu_item): Rename local to avoid shadowing.
3753 * keyboard.c (make_lispy_event): Remove unused local var.
3755 * frame.c, frame.h (x_get_resource_string): Bring this back, but
3756 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
3758 * bitmaps: Change bitmaps from unsigned char back to the X11
3759 compatible char. Avoid the old compiler warnings about
3760 out-of-range initializers by using, for example, '\xab' rather
3763 * xgselect.c (xgselect_initialize): Check vs interface
3764 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
3766 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
3768 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
3769 to read-only memory.
3771 * fns.c (vector): Remove; this old hack is no longer needed.
3773 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
3775 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
3777 * xrdb.c (x_load_resources): Omit unused local.
3779 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
3780 (x_window): Rename locals to avoid shadowing.
3781 (USG): Use the kludged USG macro, to pacify gcc.
3783 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
3784 (x_term_init): Remove local to avoid shadowing.
3786 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
3788 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
3789 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
3791 2011-04-16 Eli Zaretskii <eliz@gnu.org>
3793 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
3795 Fix regex.c, syntax.c and friends for buffers > 2GB.
3796 * syntax.h (struct gl_state_s): Declare character position members
3799 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
3801 * textprop.c (verify_interval_modification, interval_of):
3802 Declare arguments EMACS_INT.
3804 * intervals.c (adjust_intervals_for_insertion): Declare arguments
3807 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
3809 * indent.c (Fvertical_motion): Local variable it_start is now
3812 * regex.c (re_match, re_match_2, re_match_2_internal)
3813 (bcmp_translate, regcomp, regexec, print_double_string)
3814 (group_in_compile_stack, re_search, re_search_2, regex_compile)
3815 (re_compile_pattern, re_exec): Declare arguments and local
3816 variables `size_t' and `ssize_t' and return values `regoff_t', as
3818 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
3819 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
3820 <compile_stack_type>: `size' and `avail' are now `size_t'.
3822 * regex.h <regoff_t>: Use ssize_t, not int.
3823 (re_search, re_search_2, re_match, re_match_2): Arguments that
3824 specify buffer/string position and length are now ssize_t and
3825 size_t. Return type is regoff_t.
3827 2011-04-16 Ben Key <bkey76@gmail.com>
3829 * nsfont.m: Fixed bugs in ns_get_family and
3830 ns_descriptor_to_entity that were caused by using free to
3831 deallocate memory blocks that were allocated by xmalloc (via
3832 xstrdup). This caused Emacs to crash when compiled with
3833 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
3834 --enable-checking=xmallocoverrun). xfree is now used to
3835 deallocate these memory blocks.
3837 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3839 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
3841 emacs_write: Accept and return EMACS_INT for sizes.
3842 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
3844 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
3845 Accept and return EMACS_INT.
3846 (emacs_gnutls_write): Return the number of bytes written on
3848 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
3849 (emacs_read, emacs_write): Remove check for negative size, as the
3850 Emacs source code has been audited now.
3851 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
3852 (emacs_read, emacs_write): Use it.
3853 * process.c (send_process): Adjust to the new signatures of
3854 emacs_write and emacs_gnutls_write. Do not attempt to store
3855 a byte offset into an 'int'; it might overflow.
3856 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
3858 * sound.c: Don't assume sizes fit in 'int'.
3859 (struct sound_device.period_size, alsa_period_size):
3860 Return EMACS_INT, not int.
3861 (struct sound_device.write, vox_write, alsa_write):
3862 Accept EMACS_INT, not int.
3863 (wav_play, au_play): Use EMACS_INT to store sizes and to
3864 record read return values.
3866 2011-04-15 Ben Key <bkey76@gmail.com>
3868 * keyboard.c (Qundefined): Don't declare static since it is used
3870 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
3871 static since they are used in nsfont.m.
3873 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
3875 * process.c (Qprocessp): Don't declare static.
3876 * lisp.h (Qprocessp): Declare again.
3878 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
3880 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
3882 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
3884 Improve C-level modularity by making more things 'static'.
3886 Don't publish debugger-only interfaces to other modules.
3887 * lisp.h (safe_debug_print, debug_output_compilation_hack):
3888 (verify_bytepos, count_markers): Move decls to the only modules
3890 * region-cache.h (pp_cache): Likewise.
3891 * window.h (check_all_windows): Likewise.
3892 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
3894 * sysdep.c (croak): Now static, if
3895 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
3896 * syssignal.h (croak): Declare only if not static.
3898 * alloc.c (refill_memory_reserve): Now static if
3899 !defined REL_ALLOC || defined SYSTEM_MALLOC.
3900 * lisp.h (refill_memory_reserve): Declare only if not static.
3902 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
3903 Define only if USE_LUCID.
3905 * xrdb.c (x_customization_string, x_rm_string): Now static.
3907 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
3908 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
3910 * xdisp.c (draw_row_with_mouse_face): Now static.
3911 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
3913 * window.h (check_all_windows): Mark externally visible.
3915 * window.c (window_deletion_count): Now static.
3917 * undo.c: Make symbols static if they're not exported.
3918 (last_undo_buffer, last_boundary_position, pending_boundary):
3921 * textprop.c (interval_insert_behind_hooks): Now static.
3922 (interval_insert_in_front_hooks): Likewise.
3924 * term.c: Make symbols static if they're not exported.
3925 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
3926 (max_frame_lines, tty_set_terminal_modes):
3927 (tty_reset_terminal_modes, tty_turn_off_highlight):
3928 (get_tty_terminal): Now static.
3929 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
3930 * termhooks.h (term_mouse_moveto): Do not declare if
3932 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
3933 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
3935 * sysdep.c: Make symbols static if they're not exported.
3936 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
3938 (sigprocmask_set, full_mask): Remove; unused.
3939 (wait_debugging): Mark as visible.
3940 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
3941 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
3943 * syntax.c (syntax_temp): Define only if !__GNUC__.
3945 * sound.c (current_sound_device, current_sound): Now static.
3947 * search.c (searchbufs, searchbuf_head): Now static.
3949 * scroll.c (scroll_cost): Remove; unused.
3950 * dispextern.h (scroll_cost): Remove decl.
3952 * region-cache.h (pp_cache): Mark as externally visible.
3954 * process.c: Make symbols static if they're not exported.
3955 (process_tick, update_tick, create_process, chan_process):
3956 (Vprocess_alist, proc_buffered_char, datagram_access):
3957 (fd_callback_data, send_process_frame, process_sent_to): Now static.
3958 (deactivate_process): Mark defn as static, as well as decl.
3959 * lisp.h (create_process): Remove decl.
3960 * process.h (chan_process, Vprocess_alist): Remove decls.
3962 * print.c: Make symbols static if they're not exported.
3963 (print_depth, new_backquote_output, being_printed, print_buffer):
3964 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
3965 (print_interval, print_number_index, initial_stderr_stream):
3967 * lisp.h (Fprinc): Remove decl.
3968 (debug_output_compilation_hack): Mark as externally visible.
3970 * sysdep.c (croak): Move decl from here to syssignal.h.
3971 * syssignal.h (croak): Put it here, so the API can be checked when
3972 'croak' is called from dissociate_if_controlling_tty.
3974 * minibuf.c: Make symbols static if they're not exported.
3975 (minibuf_save_list, choose_minibuf_frame): Now static.
3976 * lisp.h (choose_minibuf_frame): Remove decl.
3978 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
3980 * lread.c: Make symbols static if they're not exported.
3981 (read_objects, initial_obarray, oblookup_last_bucket_number):
3983 (make_symbol): Remove; unused.
3984 * lisp.h (initial_obarray, make_symbol): Remove decls.
3986 * keyboard.c: Make symbols static if they're not exported.
3987 (single_kboard, recent_keys_index, total_keys, recent_keys):
3988 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
3989 (this_single_command_key_start, echoing, last_auto_save):
3990 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
3991 (command_loop, echo_now, keyboard_init_hook, help_char_p):
3992 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
3993 (Vlispy_mouse_stem, double_click_count):
3995 (force_auto_save_soon): Define only if SIGDANGER.
3996 (ignore_mouse_drag_p): Now static if
3997 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
3998 (print_help): Remove; unused.
3999 (stop_character, last_timer_event): Mark as externally visible.
4000 * keyboard.h (ignore_mouse_drag_p): Declare only if
4001 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4002 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4003 * lisp.h (echoing): Remove decl.
4004 (force_auto_save_soon): Declare only if SIGDANGER.
4005 * xdisp.c (redisplay_window): Simplify code, to make it more
4006 obvious that ignore_mouse_drag_p is not accessed if !defined
4007 USE_GTK && !defined HAVE_NS.
4009 * intervals.c: Make symbols static if they're not exported.
4010 (merge_properties_sticky, merge_interval_right, delete_interval):
4012 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4014 * insdel.c: Make symbols static if they're not exported.
4015 However, leave prepare_to_modify_buffer alone. It's never
4016 called from outside this function, but that appears to be a bug.
4017 (combine_after_change_list, combine_after_change_buffer):
4018 (adjust_after_replace, signal_before_change): Now static.
4019 (adjust_after_replace_noundo): Remove; unused.
4020 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4021 (signal_before_change): Remove decls.
4023 * indent.c (val_compute_motion, val_vmotion): Now static.
4025 * image.c: Make symbols static if they're not exported.
4026 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4028 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4029 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4031 * fringe.c (standard_bitmaps): Now static.
4032 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4034 * frame.c: Make symbols static if they're not exported.
4035 (x_report_frame_params, make_terminal_frame): Now static.
4036 (get_frame_param): Now static, unless HAVE_NS.
4037 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4038 (x_get_resource_string): Remove; not used.
4039 * frame.h (make_terminal_frame, x_report_frame_params):
4040 (x_get_resource_string); Remove decls.
4041 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4042 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4044 * font.c, fontset.c: Make symbols static if they're not exported.
4045 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4046 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4047 * font.c (font_close_object): Now static.
4048 * font.h (font_close_object): Remove.
4049 * fontset.c (FONTSET_OBJLIST): Remove.
4050 (free_realized_fontset) #if-0 the body, which does nothing.
4051 (face_suitable_for_char_p): #if-0, as it's never called.
4052 * fontset.h (face_suitable_for_char_p): Remove decl.
4053 * xfaces.c (face_at_string_position):
4054 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
4055 since 0 is always ASCII.
4057 * fns.c (weak_hash_tables): Now static.
4059 * fileio.c: Make symbols static if they're not exported.
4060 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4061 (Vwrite_region_annotation_buffers): Now static.
4063 * eval.c: Make symbols static if they're not exported.
4064 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4065 * lisp.h (backtrace_list): Remove decl.
4067 * emacs.c: Make symbols static if they're not exported.
4068 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4069 (fatal_error_code, fatal_error_signal_hook, standard_args):
4071 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4072 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4073 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4074 * lisp.h (fatal_error_signal_hook): Remove decl.
4075 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4077 * editfns.c: Move a (normally-unused) function to its only use.
4078 * editfns.c, lisp.h (get_operating_system_release): Remove.
4079 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4080 worth the hassle of breaking this out.
4082 * xterm.c: Make symbols static if they're not exported.
4083 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4084 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4085 (x_destroy_window, x_delete_display):
4087 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4088 (x_mouse_leave): Remove; unused.
4089 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4090 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4091 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4093 (x_mouse_leave): Declare only if WINDOWSNT.
4094 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4095 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4098 * ftxfont.c: Make symbols static if they're not exported.
4099 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4101 * font.h (ftxfont_driver): Likewise.
4103 * xfns.c: Make symbols static if they're not exported.
4104 (x_last_font_name, x_display_info_for_name):
4105 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4106 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4107 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4108 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4109 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4110 (last_show_tip_args): Now static.
4111 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4112 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4113 (x_screen_planes): Remove; unused.
4114 * dispextern.h (x_screen_planes): Remove decl.
4116 * dispnew.c: Make symbols static if they're not exported.
4117 * dispextern.h (redraw_garbaged_frames, scrolling):
4118 (increment_row_positions): Remove.
4119 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4120 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4122 (redraw_garbaged_frames): Remove; unused.
4124 * xfaces.c: Make symbols static if they're not exported.
4125 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4127 * xterm.h (defined_color): Remove decls.
4128 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4129 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4130 (menu_face_changed_default, defined_color, free_realized_face):
4131 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4132 (ascii_face_of_lisp_face): Remove; unused.
4134 * xdisp.c: Make symbols static if they're not exported.
4135 * dispextern.h (scratch_glyph_row, window_box_edges):
4136 (glyph_to_pixel_coords, set_cursor_from_row):
4137 (get_next_display_element, set_iterator_to_next):
4138 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4139 (show_mouse_face): Remove decls
4140 * frame.h (message_buf_print): Likewise.
4141 * lisp.h (pop_message, set_message, check_point_in_composition):
4143 * xterm.h (set_vertical_scroll_bar): Likewise.
4144 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4145 (message_buf_print, scratch_glyph_row, displayed_buffer):
4146 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4147 (get_next_display_element, show_mouse_face, window_box_edges):
4148 (frame_to_window_pixel_xy, check_point_in_composition):
4149 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4150 (glyph_to_pixel_coords): Remove; unused.
4152 * dired.c (file_name_completion): Now static.
4154 * dbusbind.c (xd_in_read_queued_messages): Now static.
4156 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4157 * data.c (circular_list_error): Remove.
4159 * commands.h (last_point_position, last_point_position_buffer):
4160 (last_point_position_window): Remove decls.
4161 * keyboard.c: Make these variables static.
4163 * coding.h (coding, code_convert_region, encode_coding_gap):
4165 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4166 (iso_code_class, detect_coding, code_convert_region): Now static.
4167 (encode_coding_gap): Remove; unused.
4169 * chartab.c (chartab_chars, chartab_bits): Now static.
4171 * charset.h (charset_iso_8859_1): Remove decl.
4172 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4175 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4176 * ccl.c (Vccl_program_table): Now static.
4177 (check_ccl_update): Remove; unused.
4179 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4180 * category.h: ... from here.
4181 * category.c (check_category_table, set_category_set): Now static.
4183 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4184 * lisp.h: Remove these decls.
4186 * buffer.c (buffer_count): Remove unused var.
4188 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4189 so that it's not optimized away.
4190 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4191 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4192 exported only to the debugger.
4194 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
4195 * atimer.h (run_all_atimers): Remove; not exported.
4197 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4198 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4199 was inaccessible from Lisp.
4200 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4201 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4203 alloc.c: Import and export fewer symbols, and remove unused items.
4204 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4206 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4207 it's not optimized away by whole-program optimization.
4208 (message_enable_multibyte, free_misc): Remove.
4209 (catchlist, handlerlist, mark_backtrace):
4210 Declare only if BYTE_MARK_STACK.
4211 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4212 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4213 (message_enable_multibyte): Remove decl.
4214 (free_misc, interval_free_list, float_block, float_block_index):
4215 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4216 (cons_free_list, last_marked_index):
4218 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4219 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4220 (mark_backtrace): Define only if BYTE_MARK_STACK.
4221 * xdisp.c (message_enable_multibyte): Now static.
4223 Declare Lisp_Object Q* variables to be 'static' if not exported.
4224 This makes it easier for human readers (and static analyzers)
4225 to see whether these variables are used from other modules.
4226 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4227 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4228 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4229 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4230 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4231 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4232 * xmenu.c, xselect.c:
4233 Declare Q* vars static if they are not used in other modules.
4234 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4235 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4236 Remove decls of unexported vars.
4237 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4239 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4241 Make Emacs functions such as Fatom 'static' by default.
4242 This makes it easier for human readers (and static analyzers)
4243 to see whether these functions can be called from other modules.
4244 DEFUN now defines a static function. To make the function external
4245 so that it can be used in other C modules, use the new macro DEFUE.
4246 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4247 (Finit_image_library):
4248 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4249 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4250 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4251 Remove decls, since these functions are now static.
4252 (Funintern, Fget_internal_run_time): New decls, since these functions
4253 were already external.
4255 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4256 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4257 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4258 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4259 * keyboard.c, keymap.c, lread.c:
4260 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4261 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4262 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4263 Mark functions with DEFUE instead of DEFUN,
4264 if they are used in other modules.
4265 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4266 decls for now-static functions.
4267 * buffer.h (Fdelete_overlay): Remove decl.
4268 * callproc.c (Fgetenv_internal): Mark as internal.
4269 * composite.c (Fremove_list_of_text_properties): Remove decl.
4270 (Fcomposition_get_gstring): New forward static decl.
4271 * composite.h (Fcomposite_get_gstring): Remove decl.
4272 * dired.c (Ffile_attributes): New forward static decl.
4273 * doc.c (Fdocumntation_property): New forward static decl.
4274 * eval.c (Ffetch_bytecode): New forward static decl.
4275 (Funintern): Remove extern decl; now in .h file where it belongs.
4276 * fileio.c (Fmake_symbolic_link): New forward static decl.
4277 * image.c (Finit_image_library): New forward static decl.
4278 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4279 * intervals.h (Fprevious_property_change):
4280 (Fremove_list_of_text_properties): Remove decls.
4281 * keyboard.c (Fthis_command_keys): Remove decl.
4282 (Fcommand_execute): New forward static decl.
4283 * keymap.c (Flookup_key): New forward static decl.
4284 (Fcopy_keymap): Now static.
4285 * keymap.h (Flookup_key): Remove decl.
4286 * process.c (Fget_process): New forward static decl.
4287 (Fprocess_datagram_address): Mark as internal.
4288 * syntax.c (Fsyntax_table_p): New forward static decl.
4289 (skip_chars): Remove duplicate decl.
4290 * textprop.c (Fprevious_property_change): New forward static decl.
4291 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4293 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4294 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4296 * editfns.c (Fformat): Remove unreachable code.
4298 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4300 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4303 2011-04-13 Eli Zaretskii <eliz@gnu.org>
4305 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4306 when at ZV. (Bug#8487)
4308 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4310 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4312 * keyboard.c (parse_tool_bar_item): Likewise.
4313 * sound.c (sound_cleanup, alsa_close): Likewise.
4314 * termcap.c (tgetent): Likewise.
4315 * xfns.c (x_default_font_parameter): Likewise.
4316 * xsettings.c (read_and_apply_settings): Likewise.
4318 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4319 (overrun_check_free): Protoize.
4321 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4323 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4324 since callers should never pass a negative size.
4325 Change the signature to match that of plain 'read' and 'write'; see
4326 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4327 * lisp.h: Update prototypes of emacs_write and emacs_read.
4329 2011-04-11 Eli Zaretskii <eliz@gnu.org>
4331 * xdisp.c (redisplay_window): Don't try to determine the character
4332 position of the scroll margin if the window start point w->startp
4333 is outside the buffer's accessible region. (Bug#8468)
4335 2011-04-10 Eli Zaretskii <eliz@gnu.org>
4337 Fix write-region and its subroutines for buffers > 2GB.
4338 * fileio.c (a_write, e_write): Modify declaration of arguments and
4339 local variables to support buffers larger than 2GB.
4340 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4342 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4343 argument, local variables, and return value.
4345 * lisp.h: Update prototypes of emacs_write and emacs_read.
4347 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4349 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
4351 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4353 Fix more problems found by GCC 4.6.0's static checks.
4355 * xdisp.c (vmessage): Use a better test for character truncation.
4357 * charset.c (load_charset_map): <, not <=, for optimization,
4358 and to avoid potential problems with integer overflow.
4359 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
4360 * casetab.c (set_identity, shuffle): Likewise.
4361 * editfns.c (Fformat): Likewise.
4362 * syntax.c (skip_chars): Likewise.
4364 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4365 This also lets GCC 4.6.0 generate slightly better loop code.
4367 * callint.c (Fcall_interactively): <, not <=, for optimization.
4368 (Fcall_interactively): Count the number of arguments produced,
4369 not the number of arguments given. This is simpler and lets GCC
4370 4.6.0 generate slightly better code.
4372 * ftfont.c: Distingish more carefully between FcChar8 and char.
4373 The previous code passed unsigned char * to a functions like
4374 strlen and xstrcasecmp that expect char *, which does not
4375 conform to the C standard.
4376 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4377 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4378 char * when the C standard requires it.
4380 * keyboard.c (read_char): Remove unused var.
4382 * eval.c: Port to Windows vsnprintf (Bug#8435).
4384 (SIZE_MAX): Define if the headers do not.
4385 (verror): Do not give up if vsnprintf returns a negative count.
4386 Instead, grow the buffer. This ports to Windows vsnprintf, which
4387 does not conform to C99. Problem reported by Eli Zaretskii.
4388 Also, simplify the allocation scheme, by avoiding the need for
4389 calling realloc, and removing the ALLOCATED variable.
4391 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4393 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4394 But keep the doprint source code for now, as we might revamp it
4395 and use it again (Bug#8435).
4396 * lisp.h (doprnt): Remove.
4397 * Makefile.in (base_obj): Remove doprnt.o.
4398 * deps.mk (doprnt.o): Remove.
4400 error: Print 32- and 64-bit integers portably (Bug#8435).
4401 Without this change, on typical 64-bit hosts error ("...%d...", N)
4402 was used to print both 32- and 64-bit integers N, which relied on
4404 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4406 * lisp.h (error, verror): Mark as printf-like functions.
4407 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4408 Report overflow in size calculations when allocating printf buffer.
4409 Do not truncate output string at its first null byte.
4410 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4411 Truncate the output at a character boundary, since vsnprintf does not
4413 * charset.c (check_iso_charset_parameter): Convert internal
4414 character to string before calling 'error', since %c now has the
4416 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4417 overflow when computing char to be passed to 'error'. Do not
4418 pass Lisp_Object to 'error'; pass the integer instead.
4419 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4420 formatted with plain %d.
4422 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4424 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4426 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4428 * xterm.c (x_catch_errors): Remove duplicate declaration.
4430 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4432 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4434 2011-04-10 Jim Meyering <meyering@redhat.com>
4436 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4437 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4438 return ssize_t not "int", and use size_t as the buffer length.
4439 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4440 * gnutls.h: Update declarations.
4441 * process.c (read_process_output): Use ssize_t, to match.
4442 (send_process): Likewise.
4444 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4446 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4448 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
4450 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4451 Use unsigned char, to match FcChar8 type definition.
4453 * xterm.c (handle_one_xevent):
4454 * xmenu.c (create_and_show_popup_menu):
4455 * xselect.c (x_decline_selection_request)
4456 (x_reply_selection_request): Avoid type-punned deref of X events.
4458 2011-04-09 Eli Zaretskii <eliz@gnu.org>
4460 Fix some uses of `int' instead of EMACS_INT.
4461 * search.c (string_match_1, fast_string_match)
4462 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4463 (scan_buffer, find_next_newline_no_quit)
4464 (find_before_next_newline, search_command, Freplace_match)
4465 (Fmatch_data): Make some `int' variables be EMACS_INT.
4467 * xdisp.c (display_count_lines): 3rd argument and return value now
4468 EMACS_INT. All callers changed.
4469 (pint2hrstr): Last argument is now EMACS_INT.
4471 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4472 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4473 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4474 (decode_coding_utf_16, decode_coding_emacs_mule)
4475 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4476 (decode_coding_ccl, decode_coding_charset)
4477 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4478 (decode_coding_iso_2022, decode_coding_emacs_mule)
4479 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4480 <char_offset, last_offset>: Declare EMACS_INT.
4481 (encode_coding_utf_8, encode_coding_utf_16)
4482 (encode_coding_emacs_mule, encode_invocation_designation)
4483 (encode_designation_at_bol, encode_coding_iso_2022)
4484 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4485 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4487 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4488 (encode_invocation_designation): Last argument P_NCHARS is now
4490 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4491 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4493 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4496 * ccl.c (Fccl_execute_on_string): Declare some variables
4499 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
4501 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4503 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4505 * process.c (Fformat_network_address): Doc fix.
4507 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4509 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4511 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
4513 * keyboard.c (read_char): Call Lisp function help-form-show,
4514 instead of using internal_with_output_to_temp_buffer.
4515 (Qhelp_form_show): New var.
4516 (syms_of_keyboard): Use DEFSYM macro.
4518 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4520 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4522 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
4524 * process.c (Flist_processes): Remove to Lisp.
4525 (list_processes_1): Delete.
4527 2011-04-06 Eli Zaretskii <eliz@gnu.org>
4529 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4531 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4533 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
4535 Fix more problems found by GCC 4.6.0's static checks.
4537 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4539 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4541 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
4543 * xdisp.c (vmessage): Mark as a printf-like function.
4545 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4547 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4549 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4550 printf-like functions.
4551 (tiff_load): Add casts to remove these marks before passing them
4552 to system-supplied API.
4554 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4556 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4557 This avoids several warnings with gcc -Wstrict-overflow.
4558 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4559 directly, rather than having caller test rule sign. This avoids
4560 some unnecessary tests.
4561 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4562 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4563 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
4565 * xfont.c (xfont_text_extents): Remove var that was set but not used.
4566 (xfont_open): Avoid unnecessary tests.
4568 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4570 * composite.h, composite.c (composition_gstring_put_cache):
4571 Use EMACS_INT, not int, for length.
4573 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4574 breaking out part of COMPOSITION_DECODE_RULE.
4575 (COMPOSITION_DECODE_RULE): Use it.
4576 * composite.c (get_composition_id): Remove unused local vars,
4577 by using the new macro.
4579 * textprop.c (set_text_properties_1): Change while to do-while,
4580 since the condition is always true at first.
4582 * intervals.c (graft_intervals_into_buffer): Mark var as used.
4583 (interval_deletion_adjustment): Return unsigned value.
4586 * process.c (list_processes_1, create_pty, read_process_output):
4587 (exec_sentinel): Remove vars that were set but not used.
4588 (create_pty): Remove unnecessary "volatile"s.
4589 (Fnetwork_interface_info): Avoid possibility of int overflow.
4590 (read_process_output): Do adaptive read buffering even if carryover.
4591 (read_process_output): Simplify nbytes computation if buffered.
4593 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4595 * syntax.c (scan_words): Remove var that was set but not used.
4596 (update_syntax_table): Use unsigned instead of int.
4598 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
4599 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
4600 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
4602 * print.c (print_error_message): Avoid int overflow.
4604 * font.c (font_list_entities): Redo for clarity,
4605 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4607 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
4608 (font_score): Avoid potential overflow in diff calculation.
4610 * fns.c (substring_both): Remove var that is set but not used.
4611 (sxhash): Redo loop for clarity and to avoid wraparound warning.
4613 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4615 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4616 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4617 can always succeed if overflow has undefined behavior.
4619 * search.c (boyer_moore, wordify): Remove vars set but not used.
4620 (wordify): Omit three unnecessary tests.
4622 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4623 All callers changed. This avoids the need for an unused var.
4625 * casefiddle.c (casify_region): Remove var that is set but not used.
4627 * dired.c (file_name_completion): Remove var that is set but not used.
4629 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4631 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
4632 (Finsert_file_contents): Remove unnecessary code checking fd.
4634 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4635 Check for integer overflow on size calculations.
4637 * buffer.c (Fprevious_overlay_change): Remove var that is set
4640 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
4641 Remove vars that are set but not used.
4642 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
4643 (timer_check_2): Mark vars as initialized.
4645 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
4647 * image.c (lookup_image): Remove var that is set but not used.
4648 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
4650 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
4651 that are set but not used.
4653 * xfns.c (make_invisible_cursor): Don't return garbage
4654 if XCreateBitmapFromData fails (Bug#8410).
4656 * xselect.c (x_get_local_selection, x_handle_property_notify):
4657 Remove vars that are set but not used.
4659 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
4660 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
4662 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
4663 Remove var that is set but not used.
4664 (scroll_bar_windows_size): Now size_t, not int.
4665 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
4668 * xfaces.c (realize_named_face): Remove vars that are set but not used.
4669 (map_tty_color) [!defined MSDOS]: Likewise.
4671 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
4673 * coding.c: Remove vars that are set but not used.
4674 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
4675 All callers changed.
4676 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
4677 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
4678 (decode_coding_charset): Remove vars that are set but not used.
4680 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
4681 that is set but not used.
4683 * print.c (print_object): Remove var that is set but not used.
4685 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
4686 The gnulib version avoids calling malloc in the usual case,
4687 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
4688 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
4689 * filelock.c (current_lock_owner): Likewise.
4690 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
4691 * sysdep.c: Include allocator.h, careadlinkat.h.
4692 (emacs_no_realloc_allocator): New static constant.
4693 (emacs_readlink): New function.
4694 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
4695 ../lib/careadlinkat.h.
4697 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
4699 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
4700 first non-nil return value).
4702 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
4704 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
4705 if not defined (Bug#8403).
4707 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
4709 * xdisp.c (display_count_lines): Remove parameter `start',
4710 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4711 (get_char_face_and_encoding): Remove parameter `multibyte_p',
4712 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4713 (fill_stretch_glyph_string): Remove parameters `row' and `area',
4714 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
4715 and thereabouts. All callers changed.
4716 (get_per_char_metric): Remove parameter `f', unused since
4717 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4719 2011-04-02 Jim Meyering <meyering@redhat.com>
4721 do not dereference NULL upon failed strdup
4722 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
4723 (ns_get_family): Likewise.
4725 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
4727 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
4729 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
4731 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
4734 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
4736 Add lexical binding.
4738 * window.c (Ftemp_output_buffer_show): New fun.
4739 (Fsave_window_excursion):
4740 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
4742 * lread.c (lisp_file_lexically_bound_p): New function.
4743 (Fload): Bind Qlexical_binding.
4744 (readevalloop): Remove `evalfun' arg.
4745 Bind Qinternal_interpreter_environment.
4746 (Feval_buffer): Bind Qlexical_binding.
4747 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
4749 (syms_of_lread): Declare `lexical-binding'.
4751 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
4753 * keyboard.c (eval_dyn): New fun.
4754 (menu_item_eval_property): Use it.
4756 * image.c (parse_image_spec): Use Ffunctionp.
4758 * fns.c (concat, mapcar1): Accept byte-code-functions.
4760 * eval.c (Fsetq): Handle lexical vars.
4761 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
4762 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
4763 (FletX, Flet): Obey lexical binding.
4764 (Fcommandp): Handle closures.
4765 (Feval): New `lexical' arg.
4766 (eval_sub): New function extracted from Feval. Use it almost
4767 everywhere where Feval was used. Look up vars in lexical env.
4769 (Ffunctionp): Move from subr.el.
4770 (Ffuncall): Handle closures.
4771 (apply_lambda): Remove `eval_flags'.
4772 (funcall_lambda): Handle closures and new byte-code-functions.
4773 (Fspecial_variable_p): New function.
4774 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
4775 but without exporting it to Lisp.
4777 * doc.c (Fdocumentation, store_function_docstring):
4778 * data.c (Finteractive_form): Handle closures.
4780 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
4783 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
4785 (exec_byte_code): New function extracted from Fbyte_code to handle new
4786 calling convention for byte-code-functions. Add new byte-codes.
4788 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
4790 * alloc.c (Fmake_symbol): Init new `declared_special' field.
4792 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
4794 * xdisp.c (redisplay_internal): Fix prototype.
4796 2011-03-31 Eli Zaretskii <eliz@gnu.org>
4798 * xdisp.c (SCROLL_LIMIT): New macro.
4799 (try_scrolling): Use it when setting scroll_limit.
4800 Limit scrolling to 100 screen lines.
4801 (redisplay_window): Even when falling back on "recentering",
4802 position point in the window according to scroll-conservatively,
4803 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
4805 (try_scrolling): When point is above the window, allow searching
4806 as far as scroll_max, or one screenful, to compute vertical
4807 distance from PT to the scroll margin position. This prevents
4808 try_scrolling from unnecessarily failing when
4809 scroll-conservatively is set to a value slightly larger than the
4810 window height. Clean up the case of PT below the margin at bottom
4811 of window: scroll_max can no longer be INT_MAX. When aggressive
4812 scrolling is in use, don't let point enter the opposite scroll
4813 margin as result of the scroll.
4814 (syms_of_xdisp) <scroll-conservatively>: Document the
4815 threshold of 100 lines for never-recentering scrolling.
4817 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
4819 * dispextern.h (move_it_by_lines):
4820 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
4821 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
4822 (message_log_check_duplicate): Remove parameters `prev_bol' and
4823 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4824 (redisplay_internal): Remove parameter `preserve_echo_area',
4825 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
4827 * indent.c (Fvertical_motion):
4828 * window.c (window_scroll_pixel_based, Frecenter):
4829 Don't pass `need_y_p' to `move_it_by_lines'.
4831 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
4833 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
4834 steal a few bits to be more compact.
4835 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
4836 Remove unneeded casts.
4838 * bytecode.c (Fbyte_code): CAR and CDR can GC.
4840 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
4842 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
4843 binding" message (bug#7967).
4845 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
4847 Fix more problems found by GCC 4.6.0's static checks.
4849 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
4850 Remove unused local var.
4852 * editfns.c (Fmessage_box): Remove unused local var.
4854 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
4855 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4856 Omit unused local vars.
4857 * window.c (shrink_windows): Omit unused local var.
4858 * menu.c (digest_single_submenu): Omit unused local var.
4859 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
4860 Omit unused local var.
4862 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
4863 Don't assume string length fits in int.
4864 (keyremap_step, read_key_sequence): Use size_t for sizes.
4865 (read_key_sequence): Don't check last_real_key_start redundantly.
4867 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
4868 instead of alloca (Bug#8344).
4870 * eval.c (Fbacktrace): Don't assume nargs fits in int.
4871 (Fbacktrace_frame): Don't assume nframes fits in int.
4873 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
4875 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
4878 * term.c (produce_glyphless_glyph): Remove unnecessary test.
4880 * cm.c (calccost): Turn while-do into do-while, for clarity.
4882 * keyboard.c (syms_of_keyboard): Use the same style as later
4883 in this function when indexing through an array. This also
4884 works around GCC bug 48267.
4886 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
4888 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
4890 * chartab.c (sub_char_table_ref_and_range): Redo for slight
4891 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
4893 * keyboard.c, keyboard.h (num_input_events): Now size_t.
4894 This avoids undefined behavior on integer overflow, and is a bit
4895 more convenient anyway since it is compared to a size_t variable.
4897 Variadic C functions now count arguments with size_t, not int.
4898 This avoids an unnecessary limitation on 64-bit machines, which
4899 caused (substring ...) to crash on large vectors (Bug#8344).
4900 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
4901 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
4902 All variadic functions and their callers changed accordingly.
4903 (struct gcpro.nvars): Now size_t, not int. All uses changed.
4904 * data.c (arith_driver, float_arith_driver): Likewise.
4905 * editfns.c (general_insert_function): Likewise.
4906 * eval.c (struct backtrace.nargs, interactive_p)
4907 (internal_condition_case_n, run_hook_with_args, apply_lambda)
4908 (funcall_lambda, mark_backtrace): Likewise.
4909 * fns.c (concat): Likewise.
4910 * frame.c (x_set_frame_parameters): Likewise.
4911 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
4912 0 if not found, not -1. All callers changed.
4914 * alloc.c (garbage_collect): Don't assume stack size fits in int.
4915 (stack_copy_size): Now size_t, not int.
4916 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
4918 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
4920 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
4921 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4922 All callers changed.
4924 * lisp.h (multibyte_char_to_unibyte):
4925 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
4926 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4927 * character.h (CHAR_TO_BYTE8):
4928 * cmds.c (internal_self_insert):
4929 * editfns.c (general_insert_function):
4930 * keymap.c (push_key_description):
4931 * search.c (Freplace_match):
4932 * xdisp.c (message_dolog, set_message_1): All callers changed.
4934 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4936 * keyboard.c (safe_run_hook_funcall): New function.
4937 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
4938 don't set the hook to nil, but remove the offending function instead.
4939 (Qcommand_hook_internal): Remove, unused.
4940 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
4941 Vcommand_hook_internal.
4943 * eval.c (enum run_hooks_condition): Remove.
4944 (funcall_nil, funcall_not): New functions.
4945 (run_hook_with_args): Call each function through a `funcall' argument.
4946 Remove `cond' argument, now redundant.
4947 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
4948 (Frun_hook_with_args_until_failure): Adjust accordingly.
4949 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
4951 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
4953 * dispextern.h (string_buffer_position): Remove declaration.
4955 * print.c (strout): Remove parameter `multibyte', unused since
4956 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
4958 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
4959 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
4960 All callers changed.
4962 * w32.c (_wsa_errlist): Use braces for struct initializers.
4964 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
4965 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
4966 All callers changed.
4967 (string_buffer_position): Likewise. Also, make static (it's never
4968 used outside xdisp.c).
4969 (cursor_row_p): Remove parameter `w', unused since
4970 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
4971 (decode_mode_spec): Remove parameter `precision', introduced during
4972 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
4973 All callers changed.
4975 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4977 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
4979 2011-03-27 Anders Lindgren <andlind@gmail.com>
4981 * nsterm.m (ns_menu_bar_is_hidden): New variable.
4982 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
4983 (ns_update_auto_hide_menu_bar): New functions.
4984 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
4985 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
4986 ns_constrain_all_frames.
4987 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
4988 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
4990 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4992 * nsmenu.m (runDialogAt): Remove argument to timer_check.
4994 2011-03-27 Glenn Morris <rgm@gnu.org>
4996 * syssignal.h: Replace RETSIGTYPE with void.
4997 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
4998 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
4999 Replace SIGTYPE with void everywhere.
5000 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5001 * s/template.h (SIGTYPE): Remove commented out definition.
5003 2011-03-26 Eli Zaretskii <eliz@gnu.org>
5005 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5006 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5008 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
5010 * w32.c (read_unc_volume): Use parameter `henum', instead of
5011 global variable `wget_enum_handle'.
5013 * keymap.c (describe_vector): Remove parameters `indices' and
5014 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5015 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5017 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5019 * keyboard.c (timer_check): Remove parameter `do_it_now',
5020 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5021 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5022 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5024 * keyboard.c (read_char):
5025 * w32menu.c (w32_menu_display_help):
5026 * xmenu.c (show_help_event, menu_help_callback):
5027 Adjust calls to `show_help_echo'.
5029 * gtkutil.c (xg_maybe_add_timer):
5030 * keyboard.c (readable_events):
5031 * process.c (wait_reading_process_output):
5032 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5034 * insdel.c (adjust_markers_gap_motion):
5035 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5036 (gap_left, gap_right): Don't call it.
5038 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
5040 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5041 incurred during fontification.
5043 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5045 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5046 (DEFVAR_PER_BUFFER): Don't pass it.
5048 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5049 (scrolling_window): Don't pass it.
5051 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
5053 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5055 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5057 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5058 of variables specific to SELinux and computation of `encoded_absname'.
5060 * image.c (XPutPixel): Remove unused variable `height'.
5062 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5064 * unexw32.c (get_section_info): Remove unused variable `section'.
5066 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5067 (system_process_attributes): Remove unused variable `sess'.
5068 (sys_read): Remove unused variable `err'.
5070 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5071 (w32_wnd_proc): Remove unused variable `isdead'.
5072 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5073 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5074 (x_create_tip_frame): Remove unused variable `tem'.
5076 * w32inevt.c (w32_console_read_socket):
5077 Remove unused variable `no_events'.
5079 * w32term.c (x_draw_composite_glyph_string_foreground):
5080 Remove unused variable `width'.
5082 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
5084 * w32term.c (x_set_glyph_string_clipping):
5085 Don't pass uninitialized region to CombineRgn.
5087 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
5089 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5090 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5091 (Fx_close_connection): Remove unused variable `i'.
5093 * w32font.c (w32font_draw): Return number of glyphs.
5094 (w32font_open_internal): Remove unused variable `i'.
5095 (w32font_driver): Add missing initializer.
5097 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5098 (fill_in_menu): Remove unused variable `items_added'.
5100 * w32term.c (last_mouse_press_frame): Remove static global variable.
5101 (w32_clip_to_row): Remove unused variable `f'.
5102 (x_delete_terminal): Remove unused variable `i'.
5104 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5105 (NOTHING): Remove unused static global variable.
5106 (uniscribe_check_otf): Remove unused variable `table'.
5107 (uniscribe_font_driver): Add missing initializers.
5109 2011-03-23 Julien Danjou <julien@danjou.info>
5111 * term.c (Fsuspend_tty, Fresume_tty):
5112 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5113 * window.c (temp_output_buffer_show):
5114 * insdel.c (signal_before_change):
5115 * frame.c (Fhandle_switch_frame):
5116 * fileio.c (Fdo_auto_save):
5117 * emacs.c (Fkill_emacs):
5118 * editfns.c (save_excursion_restore):
5119 * cmds.c (internal_self_insert):
5120 * callint.c (Fcall_interactively):
5121 * buffer.c (Fkill_all_local_variables):
5122 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5124 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
5125 unconditionnaly since it does the check itself.
5127 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
5129 Fix more problems found by GCC 4.5.2's static checks.
5131 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5132 the first time through the loop, since we know p0 < p1 then.
5133 This also avoids a gcc -Wstrict-overflow warning.
5135 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5136 leading to a memory leak, possible in functions like
5137 load_charset_map_from_file that can allocate an unbounded number
5138 of objects (Bug#8318).
5140 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5141 that could (at least in theory) be that large.
5143 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5144 This is less likely to overflow, and avoids undefined behavior if
5145 overflow does occur. All callers changed. Use strtoul to scan
5146 for the unsigned long integer.
5147 (pint2hrstr): Simplify and tune code slightly.
5148 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
5150 * scroll.c (do_scrolling): Work around GCC bug 48228.
5151 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5153 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5154 This also avoids a warning with gcc -Wstrict-overflow.
5155 (validate_x_resource_name): Simplify count usage.
5156 This also avoids a warning with gcc -Wstrict-overflow.
5158 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5161 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
5163 * process.c (Fmake_network_process): Use socklen_t, not int,
5164 where POSIX says socklen_t is required in portable programs.
5165 This fixes a porting bug on hosts like 64-bit HP-UX, where
5166 socklen_t is wider than int (Bug#8277).
5167 (Fmake_network_process, server_accept_connection):
5168 (wait_reading_process_output, read_process_output):
5171 * process.c: Rename or move locals to avoid shadowing.
5172 (list_processes_1, Fmake_network_process):
5173 (read_process_output_error_handler, exec_sentinel_error_handler):
5174 Rename or move locals.
5175 (Fmake_network_process): Define label "retry_connect" only if needed.
5176 (Fnetwork_interface_info): Fix pointer signedness.
5177 (process_send_signal): Add cast to avoid pointer signedness problem.
5178 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
5179 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
5181 Make tparam.h and terminfo.c consistent.
5182 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5183 Include tparam.h instead, since it declares them.
5184 * cm.h (PC): Remove extern decl; tparam.h now does this.
5185 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5186 * terminfo.c: Include tparam.h, to check interfaces.
5187 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5188 (tparam): Adjust signature to match interface in tparam.h;
5189 this removes some undefined behavior. Check that outstring and len
5190 are zero, which they always are with Emacs.
5191 * tparam.h (PC, BC, UP): New extern decls.
5193 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
5194 (xftfont_open): Rename locals to avoid shadowing.
5196 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
5197 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5198 (OTF_TAG_SYM): Omit macro if not needed.
5199 (ftfont_list): Remove unused local.
5200 (get_adstyle_property, ftfont_pattern_entity):
5201 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5202 Rename locals to avoid shadowing.
5204 * xfont.c (xfont_list_family): Mark var as initialized.
5206 * xml.c (make_dom): Now static.
5208 * composite.c (composition_compute_stop_pos): Rename local to
5210 (composition_reseat_it): Remove unused locals.
5211 (find_automatic_composition, composition_adjust_point): Likewise.
5212 (composition_update_it): Mark var as initialized.
5213 (find_automatic_composition): Mark vars as initialized,
5214 with a FIXME (Bug#8290).
5216 character.h: Rename locals to avoid shadowing.
5217 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5218 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5219 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5220 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5223 * textprop.c (property_change_between_p): Remove; unused.
5225 * intervals.c (interval_start_pos): Now static.
5227 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5229 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5230 Rename locals to avoid shadowing.
5232 * sound.c (wav_play, au_play, Fplay_sound_internal):
5233 Fix pointer signedness.
5234 (alsa_choose_format): Remove unused local var.
5235 (wav_play): Initialize a variable to 0, to prevent undefined
5236 behavior (Bug#8278).
5238 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5240 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5242 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5243 clobbering (Bug#8298).
5244 * sysdep.c (sys_subshell): Likewise.
5245 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
5247 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5248 This should get cleaned up, so that child_setup has the
5249 same signature on all platforms.
5251 * callproc.c (call_process_cleanup): Now static.
5252 (relocate_fd): Rename locals to avoid shadowing.
5254 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
5256 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5257 not to be necessary, and produces flickering.
5259 2011-03-20 Glenn Morris <rgm@gnu.org>
5261 * config.in: Remove file.
5263 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
5265 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5266 are now in src/globals.h.
5267 (syms_of_minibuf): Remove spurious & from previous change.
5269 2011-03-20 Leo <sdl.web@gmail.com>
5271 * minibuf.c (completing-read-function): New variable.
5272 (completing-read-default): Rename from completing-read.
5273 (completing-read): Call completing-read-function.
5275 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5277 * xfaces.c (Fx_load_color_file):
5278 Read color file from absolute filename (bug#8250).
5280 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
5282 * makefile.w32-in: Update dependencies.
5284 2011-03-17 Eli Zaretskii <eliz@gnu.org>
5286 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5288 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5290 Fix more problems found by GCC 4.5.2's static checks.
5292 * process.c (make_serial_process_unwind, send_process_trap):
5293 (sigchld_handler): Now static.
5295 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5296 That way, the code declares only the vars that it needs.
5297 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5298 * s/cygwin.h (PTY_ITERATION): Likewise.
5299 * s/darwin.h (PTY_ITERATION): Likewise.
5300 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5302 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5303 * process.c (allocate_pty): Don't declare stb unless it's needed.
5305 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
5306 (CONSTANTLIM): Remove; unused.
5307 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5308 Define only if needed.
5310 * unexelf.c (unexec): Name an expression,
5311 to avoid gcc -Wbad-function-cast warning.
5312 Use a different way to cause a compilation error if anyone uses
5313 n rather than nn, a way that does not involve shadowing.
5314 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
5316 * deps.mk (unexalpha.o): Remove; unused.
5318 New file unexec.h, the (simple) interface for unexec (Bug#8267).
5319 * unexec.h: New file.
5320 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5321 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5323 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5324 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5325 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
5326 Change as necessary to match prototype in unexec.h.
5328 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5330 (back_comment, skip_chars): Mark vars as initialized.
5332 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5333 Rename locals to avoid shadowing.
5335 * lread.c (read1): Rewrite so as not to use empty "else".
5336 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
5338 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5340 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5341 warning when compiling print.c.
5343 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5344 instead of using an uninitialized var.
5345 (font_sort_entities): Mark var as initialized.
5347 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5349 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5350 pointers to constants.
5351 (font_parse_fcname): Remove unused vars.
5352 (font_delete_unmatched): Now static.
5353 (font_get_spec): Remove; unused.
5354 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5355 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5356 Rename or move locals to avoid shadowing.
5358 * fns.c (require_nesting_list, require_unwind): Now static.
5359 (Ffillarray): Rename locals to avoid shadowing.
5361 * floatfns.c (domain_error2): Define only if needed.
5362 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
5364 * alloc.c (mark_backtrace): Move decl from here ...
5365 * lisp.h: ... to here, so that it can be checked.
5367 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
5368 (Fdefvar): Rewrite so as not to use empty "else".
5369 (lisp_indirect_variable): Name an expression,
5370 to avoid gcc -Wbad-function-cast warning.
5371 (Fdefvar): Rename locals to avoid shadowing.
5373 * callint.c (quotify_arg, quotify_args): Now static.
5374 (Fcall_interactively): Rename locals to avoid shadowing.
5375 Use const pointer when appropriate.
5377 * lisp.h (get_system_name, get_operating_system_release):
5378 Move decls here, to check interfaces.
5379 * process.c (get_operating_system_release): Move decl to lisp.h.
5380 * xrdb.c (get_system_name): Likewise.
5381 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5382 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5383 some of which prompt warnings from gcc -Wbad-function-cast.
5384 (Fformat_time_string, Fencode_time, Finsert_char):
5385 (Ftranslate_region_internal, Fformat):
5386 Rename or remove local vars to avoid shadowing.
5387 (Ftranslate_region_internal): Mark var as initialized.
5389 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5392 * lisp.h (eassert): Check that the argument compiles, even if
5393 ENABLE_CHECKING is not defined.
5395 * data.c (Findirect_variable): Name an expression, to avoid
5396 gcc -Wbad-function-cast warning.
5397 (default_value, arithcompare, arith_driver, arith_error): Now static.
5398 (store_symval_forwarding): Rename local to avoid shadowing.
5399 (Fmake_variable_buffer_local, Fmake_local_variable):
5400 Mark variables as initialized.
5401 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
5403 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
5404 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5405 Rename locals to avoid shadowing.
5406 (mark_stack): Move local variables into the #ifdef region where
5408 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5409 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5411 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5412 (GC_STRING_CHARS): Remove; not used.
5413 (Fmemory_limit): Cast sbrk's returned value to char *.
5415 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5416 avoids undefined behavior in theory.
5418 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5420 Use functions, not macros, for up- and down-casing (Bug#8254).
5421 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5422 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5423 to use the following functions instead of these macros.
5424 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5425 EMACS_INT, since callers assume the returned value fits in int.
5426 (upcase1): Likewise, for UPCASE_TABLE.
5427 (uppercasep, lowercasep, upcase): New static inline functions.
5428 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
5429 the race-condition problem in the old DOWNCASE.
5431 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5432 Rename locals to avoid shadowing.
5433 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
5434 (regex_compile, re_search_2, re_match_2_internal):
5435 Remove unused local vars.
5436 (FREE_VAR): Rewrite so as not to use empty "else",
5437 which gcc can warn about.
5438 (regex_compile, re_match_2_internal): Mark locals as initialized.
5439 (RETALLOC_IF): Define only if needed.
5440 (WORDCHAR_P): Likewise. This one is never needed, but is used
5441 only in a comment talking about a compiler bug, so put inside
5442 the #if 0 of that comment.
5443 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5444 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5447 * search.c (boyer_moore): Rename locals to avoid shadowing.
5448 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5449 (PREV_CHAR_BOUNDARY): Likewise.
5451 * search.c (simple_search): Remove unused var.
5453 * dired.c (compile_pattern): Move decl from here ...
5454 * lisp.h: ... to here, so that it can be checked.
5455 (struct re_registers): New forward decl.
5457 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5459 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5461 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5462 Rename locals to avoid shadowing.
5463 (Fvertical_motion): Mark locals as initialized.
5465 * casefiddle.c (casify_object, casify_region): Now static.
5466 (casify_region): Mark local as initialized.
5468 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5470 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5471 New macros, so that the caller can use some names other than
5472 gcpro1, gcpro2, etc.
5473 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5475 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5476 argument, for consistency with GCPRO2_VAR, etc: it is now the
5477 prefix of the variable, not the variable itself. All uses
5479 * dired.c (directory_files_internal, file_name_completion):
5480 Rename locals to avoid shadowing.
5482 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5483 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5484 dired.c's scmp function, had undefined behavior.
5485 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5486 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5487 * buffer.h: ... to here, because these macros use current_buffer,
5488 and the new implementation with inline functions needs to have
5489 current_buffer in scope now, rather than later when the macros
5491 (downcase, upcase1): New static inline functions.
5492 (DOWNCASE, UPCASE1): Reimplement using these functions.
5493 This avoids undefined behavior in expressions like
5494 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5495 from race conditions in accessing the global variables
5496 case_temp1 and case_temp2.
5497 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5498 * lisp.h (case_temp1, case_temp2): Remove their decls.
5499 * character.h (ASCII_CHAR_P): Move from here ...
5500 * lisp.h: ... to here, so that the inline functions mentioned
5503 * dired.c (directory_files_internal_unwind): Now static.
5505 * fileio.c (file_name_as_directory, directory_file_name):
5506 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5508 (file_name_as_directory): Use const pointers when appropriate.
5509 (Fexpand_file_name): Likewise. In particular, newdir might
5510 point at constant storage, so make it a const pointer.
5511 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
5512 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5514 (Fset_file_times, Finsert_file_contents, auto_save_error):
5515 Rename locals to avoid shadowing.
5517 * minibuf.c (choose_minibuf_frame_1): Now static.
5518 (Ftry_completion, Fall_completions): Rename or remove locals
5521 * marker.c (bytepos_to_charpos): Remove; unused.
5523 * lisp.h (verify_bytepos, count_markers): New decls,
5524 so that gcc does not warn that these functions aren't declared.
5526 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5527 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
5528 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
5529 (copy_text): Remove unused local var.
5531 * filelock.c (within_one_second): Now static.
5532 (lock_file_1): Rename local to avoid shadowing.
5534 * buffer.c (fix_overlays_before): Mark locals as initialized.
5535 (fix_start_end_in_overlays): Likewise. This function should be
5536 simplified by using pointers-to-pointers, but that's a different
5538 (switch_to_buffer_1): Now static.
5539 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5540 (report_overlay_modification): Rename locals to avoid shadowing.
5542 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
5543 Fix pointer signedness issue.
5544 (sys_subshell): Mark local as volatile if checking for lint,
5545 to suppress a gcc -Wclobbered warning that does not seem to be right.
5546 (MAXPATHLEN): Define only if needed.
5548 * process.c (serial_open, serial_configure): Move decls from here ...
5549 * systty.h: ... to here, so that they can be checked.
5551 * fns.c (get_random, seed_random): Move extern decls from here ...
5552 * lisp.h: ... to here, so that they can be checked.
5554 * sysdep.c (reset_io): Now static.
5555 (wait_for_termination_signal): Remove; unused.
5557 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5558 (copy_keymap_item, append_key, push_text_char_description):
5560 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
5561 (DENSE_TABLE_SIZE): Remove; unused.
5562 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5563 (describe_map_tree):
5564 Rename locals to avoid shadowing.
5566 * keyboard.c: Declare functions static if they are not used elsewhere.
5567 (echo_char, echo_dash, cmd_error, top_level_2):
5568 (poll_for_input, handle_async_input): Now static.
5569 (read_char, kbd_buffer_get_event, make_lispy_position):
5570 (make_lispy_event, make_lispy_movement, apply_modifiers):
5571 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5572 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5573 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
5574 (read_key_sequence, read_char): Mark locals as initialized.
5575 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
5577 * keyboard.h (make_ctrl_char): New decl.
5578 (mark_kboards): Move decl here ...
5579 * alloc.c (mark_kboards): ... from here.
5581 * lisp.h (force_auto_save_soon): New decl.
5583 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
5584 (DEFINE_DUMMY_FUNCTION): New macro.
5585 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5587 (main): Add casts to avoid warnings
5588 if GCC considers string literals to be constants.
5590 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5592 * dbusbind.c: Pointer signedness fixes.
5593 (xd_signature, xd_append_arg, xd_initialize):
5594 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5595 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5596 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5597 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5599 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5600 if GCC considers string literals to be constants.
5601 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
5603 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5605 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5606 (print_preprocess, print_object): New macro to fix last change.
5608 * print.c (print_preprocess): Don't forget font objects.
5610 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
5612 * emacs.c (USAGE3): Doc fixes.
5614 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5616 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5619 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
5621 * lisp.h (VWindow_system, Qfile_name_history):
5622 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5623 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5624 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5626 * w32select.c: Don't #include "keyboard.h".
5627 (run_protected): Add extern declaration for waiting_for_input.
5629 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5630 * w32console.c (detect_input_pending, read_input_pending)
5631 (encode_terminal_code):
5632 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5633 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5634 (w32_system_caret_y, Qfile_name_history):
5635 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5636 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5637 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5638 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5639 * w32proc.c (Qlocal, report_file_error):
5640 * w32term.c (Vwindow_system, updating_frame):
5641 * w32uniscribe.c (initialized, uniscribe_font_driver):
5642 Remove unneeded extern declarations.
5644 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
5646 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
5648 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
5650 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
5651 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
5652 These macros can no longer be used for assignment.
5654 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5655 Assign struct members directly, instead of using BUF_BEGV etc.
5656 (record_buffer_markers, fetch_buffer_markers): New functions for
5657 recording and fetching special buffer markers.
5658 (set_buffer_internal_1, set_buffer_temp): Use them.
5660 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
5662 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
5664 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
5665 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
5667 * xdisp.c (hscroll_window_tree):
5668 (reconsider_clip_changes): Use PT instead of BUF_PT.
5670 2011-03-13 Eli Zaretskii <eliz@gnu.org>
5672 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
5673 $(EMACS_ROOT)/lib/intprops.h.
5675 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
5677 Fix more problems found by GCC 4.5.2's static checks.
5679 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
5680 to unsigned char * to avoid compiler diagnostic.
5681 (xg_free_frame_widgets): Make it clear that a local variable is
5682 needed only if USE_GTK_TOOLTIP.
5683 (gdk_window_get_screen): Make it clear that this macro is needed
5684 only if USE_GTK_TOOLTIP.
5685 (int_gtk_range_get_value): New function, which avoids a diagnostic
5686 from gcc -Wbad-function-cast.
5687 (xg_set_toolkit_scroll_bar_thumb): Use it.
5688 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
5689 diagnostic from gcc -Wbad-function-cast.
5690 (get_utf8_string, xg_get_file_with_chooser):
5691 Rename locals to avoid shadowing.
5692 (create_dialog): Move locals to avoid shadowing.
5694 * xgselect.c (xg_select): Remove unused var.
5696 * image.c (four_corners_best): Mark locals as initialized.
5697 (gif_load): Initialize transparent_p to zero (Bug#8238).
5698 Mark another local as initialized.
5699 (my_png_error, my_error_exit): Mark with NO_RETURN.
5701 * image.c (clear_image_cache): Now static.
5702 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
5703 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
5704 (x_edge_detection): Remove unnecessary cast that
5705 gcc -Wbad-function-cast diagnoses.
5706 (gif_load): Fix pointer signedness.
5707 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
5708 (jpeg_load, gif_load): Rename locals to avoid shadowing.
5710 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
5712 Improve quality of tests for time stamp overflow.
5713 For example, without this patch (encode-time 0 0 0 1 1
5714 1152921504606846976) returns the obviously-bogus value (-948597
5715 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
5716 reports time overflow. See
5717 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
5718 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
5719 * editfns.c: Include limits.h and intprops.h.
5720 (TIME_T_MIN, TIME_T_MAX): New macros.
5721 (time_overflow): Move earlier, to before first use.
5722 (hi_time, lo_time): New functions, for an accurate test for
5724 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
5725 (Fget_internal_run_time): Don't assume time_t fits in int.
5726 (make_time): Use list2 instead of Fcons twice.
5727 (Fdecode_time): More accurate test for out-of-range times.
5728 (check_tm_member): New function.
5729 (Fencode_time): Use it, to test for out-of-range times.
5730 (lisp_time_argument): Don't rely on undefined left-shift and
5731 right-shift behavior when checking for time stamp overflow.
5733 * editfns.c (time_overflow): New function, refactoring common code.
5734 (Fformat_time_string, Fdecode_time, Fencode_time):
5735 (Fcurrent_time_string): Use it.
5737 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
5738 * dired.c (make_time): Move to ...
5739 * editfns.c (make_time): ... here.
5740 * systime.h: Note the move.
5742 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5744 * fringe.c (update_window_fringes): Remove unused variables.
5746 * unexmacosx.c (copy_data_segment): Also copy __got section.
5749 2011-03-12 Eli Zaretskii <eliz@gnu.org>
5751 * termcap.c [MSDOS]: Include "msdos.h".
5752 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
5753 Constify `char *' arguments and their references according to
5754 prototypes in tparam.h.
5756 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
5758 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
5759 Adapt all references accordingly.
5761 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
5763 2011-03-11 Tom Tromey <tromey@redhat.com>
5765 * buffer.c (syms_of_buffer): Remove obsolete comment.
5767 2011-03-11 Eli Zaretskii <eliz@gnu.org>
5769 * termhooks.h (encode_terminal_code): Declare prototype.
5771 * msdos.c (encode_terminal_code): Don't declare prototype.
5773 * term.c (encode_terminal_code): Now external again, used by
5774 w32console.c and msdos.c.
5776 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
5777 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
5779 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
5781 Fix some minor problems found by GCC 4.5.2's static checks.
5783 * fringe.c (update_window_fringes): Mark locals as initialized
5785 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
5787 * alloc.c (mark_fringe_data): Move decl from here ...
5788 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
5789 to check its interface.
5790 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
5792 * fontset.c (free_realized_fontset): Now static.
5793 (Fset_fontset_font): Rename local to avoid shadowing.
5794 (fontset_font): Mark local as initialized.
5795 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
5797 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
5799 * xselect.c (x_disown_buffer_selections): Remove; not used.
5800 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
5801 (x_own_selection, Fx_disown_selection_internal): Rename locals
5803 (x_handle_dnd_message): Remove local to avoid shadowing.
5805 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
5806 so that the caller can use some name other than gcpro1.
5807 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
5808 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5809 (Fx_backspace_delete_keys_p):
5810 Use them to avoid shadowing, and rename vars to avoid shadowing.
5811 (x_decode_color, x_set_name, x_window): Now static.
5812 (Fx_create_frame): Add braces to silence GCC warning.
5813 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
5814 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
5815 Remove unused locals.
5816 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5817 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
5818 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
5821 * xterm.h (x_mouse_leave): New decl.
5823 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
5824 Remove unused functions.
5825 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
5826 (x_calc_absolute_position): Now static.
5827 (XTread_socket): Don't define label "out" unless it's used.
5828 Don't declare local "event" unless it's used.
5829 (x_iconify_frame, x_free_frame_resources): Don't declare locals
5830 unless they are used.
5831 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
5832 (x_fatal_error_signal): Remove; not used.
5833 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
5834 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
5835 (x_error_catcher, x_connection_closed, x_error_handler):
5836 (x_error_quitter, xembed_send_message, x_iconify_frame):
5837 (my_log_handler): Rename locals to avoid shadowing.
5838 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
5839 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
5841 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
5842 Rename or move locals to avoid shadowing.
5843 (tty_defined_color, merge_face_heights): Now static.
5844 (free_realized_faces_for_fontset): Remove; not used.
5845 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
5846 does not deduce is never used uninitialized.
5847 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
5848 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
5850 * terminal.c (store_terminal_param): Now static.
5852 * xmenu.c (menu_highlight_callback): Now static.
5853 (set_frame_menubar): Remove unused local.
5854 (xmenu_show): Rename parameter to avoid shadowing.
5855 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
5856 since they might point to immutable storage.
5857 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
5858 since it's unused otherwise.
5860 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
5861 Add a FIXME, since the code still doesn't look right. (Bug#8215)
5862 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
5863 avoids a gcc -Wuninitialized diagnostic.
5864 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
5865 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
5866 does not deduce are never used uninitialized.
5868 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
5870 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
5871 * window.c (window_loop, size_window):
5872 (run_window_configuration_change_hook, enlarge_window): Likewise.
5874 * window.c (display_buffer): Now static.
5875 (size_window): Mark variables that gcc -Wuninitialized
5876 does not deduce are never used uninitialized.
5877 * window.h (check_all_windows): New decl, to forestall
5878 gcc -Wmissing-prototypes diagnostic.
5879 * dispextern.h (bidi_dump_cached_states): Likewise.
5881 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
5883 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
5885 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
5886 and to avoid gcc -Wuninitialized warning.
5887 (load_charset_map): Mark variables that gcc -Wuninitialized
5888 does not deduce are never used uninitialized.
5889 (load_charset): Abort instead of using uninitialized var (Bug#8229).
5891 * coding.c (coding_set_source, coding_set_destination):
5892 Use "else { /* comment */ }" rather than "else /* comment */;"
5893 for clarity, and to avoid gcc -Wempty-body warning.
5894 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
5895 a block, when the outer 'i' will do.
5896 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
5897 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
5898 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
5899 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
5900 (Fdecode_sjis_char, Fdefine_coding_system_internal):
5901 Rename locals to avoid shadowing.
5902 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
5903 * coding.c (emacs_mule_char, encode_invocation_designation):
5904 Now static, since they're not used elsewhere.
5905 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
5906 (decode_coding_object, encode_coding_object, detect_coding_system):
5907 (decode_coding_emacs_mule): Mark variables that gcc
5908 -Wuninitialized does not deduce are never used uninitialized.
5909 (detect_coding_iso_2022): Initialize a local variable that might
5910 be used uninitialized. Leave a FIXME because it's not clear that
5911 this initialization is needed. (Bug#8211)
5912 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
5913 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
5914 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
5915 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
5916 Remove unused macros.
5918 * category.c (hash_get_category_set): Remove unused local var.
5919 (copy_category_table): Now static, since it's not used elsewhere.
5920 * character.c (string_count_byte8): Likewise.
5922 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
5923 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
5925 * chartab.c (copy_sub_char_table): Now static, since it's not used
5927 (sub_char_table_ref_and_range, char_table_ref_and_range):
5928 Rename locals to avoid shadowing.
5929 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
5931 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
5932 (BIDI_BOB): Remove unused macro.
5934 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
5935 deduce are never used uninitialized.
5936 * term.c (encode_terminal_code): Likewise.
5938 * term.c (encode_terminal_code): Now static. Remove unused local.
5940 * tparam.h: New file.
5941 * term.c, tparam.h: Include it.
5942 * deps.mk (term.o, tparam.o): Depend on tparam.h.
5943 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
5944 Move these decls to tparam.h, and make them agree with what
5945 is actually in tparam.c. The previous trick of using incompatible
5946 decls in different modules does not conform to the C standard.
5947 All callers of tparam changed to use tparam's actual API.
5948 * tparam.c (tparam1, tparam, tgoto):
5949 Use const pointers where appropriate.
5951 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
5952 * cm.h (struct cm): Likewise.
5953 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
5954 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
5955 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
5956 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
5957 (turn_on_face, init_tty): Likewise.
5958 * termchar.h (struct tty_display_info): Likewise.
5960 * term.c (term_mouse_position): Rename local to avoid shadowing.
5962 * alloc.c (mark_ttys): Move decl from here ...
5963 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
5965 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
5967 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
5969 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
5971 * search.c (compile_pattern_1): Remove argument regp, unused since
5972 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
5973 (compile_pattern): Don't pass it.
5975 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
5977 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
5978 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
5980 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
5982 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
5984 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
5985 gdk_window_get_screen, gdk_window_get_geometry,
5986 gdk_x11_window_lookup_for_display and GDK_KEY_g.
5987 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
5988 (xg_get_pixbuf_from_pixmap): New function.
5989 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
5990 to Pixmap, take frame as parameter, remove GdkColormap parameter.
5991 Call xg_get_pixbuf_from_pixmap instead of
5992 gdk_pixbuf_get_from_drawable.
5993 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
5994 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
5995 (xg_check_special_colors): Use GtkStyleContext and its functions
5997 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
5998 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
5999 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
6000 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6001 Call gtk_widget_get_preferred_size.
6002 (xg_frame_resized): gdk_window_get_geometry only takes 5
6004 (xg_win_to_widget, xg_event_is_for_menubar):
6005 Call gdk_x11_window_lookup_for_display.
6006 (xg_set_widget_bg): New function.
6007 (delete_cb): New function.
6008 (xg_create_frame_widgets): Connect delete-event to delete_cb.
6009 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6010 (xg_set_background_color): Call xg_set_widget_bg.
6011 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6012 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6013 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6014 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6016 (update_frame_tool_bar): Call gtk_widget_hide.
6017 (xg_initialize): Use GDK_KEY_g.
6019 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6021 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6023 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6024 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6025 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6027 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
6029 * w32xfns.c (select_palette): Check success of RealizePalette against
6030 GDI_ERROR, not zero.
6032 See ChangeLog.11 for earlier changes.
6038 Copyright (C) 2011 Free Software Foundation, Inc.
6040 This file is part of GNU Emacs.
6042 GNU Emacs is free software: you can redistribute it and/or modify
6043 it under the terms of the GNU General Public License as published by
6044 the Free Software Foundation, either version 3 of the License, or
6045 (at your option) any later version.
6047 GNU Emacs is distributed in the hope that it will be useful,
6048 but WITHOUT ANY WARRANTY; without even the implied warranty of
6049 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6050 GNU General Public License for more details.
6052 You should have received a copy of the GNU General Public License
6053 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.