]> code.delx.au - gnu-emacs/blob - src/ChangeLog
Minor cleanup to avoid forward declarations.
[gnu-emacs] / src / ChangeLog
1 2013-08-30 Dmitry Antipov <dmantipov@yandex.ru>
2
3 Minor cleanup to avoid forward declarations.
4 * coding.h (struct ccl_spec): Remove forward declaration.
5 * composite.h (toplevel): Include font.h.
6 (struct composition_it, struct face, struct font_metrics):
7 Remove forward declaration.
8 * dispextern.h (struct image, struct atimer): Likewise.
9 * emacsgtkfixed.h (struct frame): Likewise.
10 * emacsgtkfixed.c (toplevel): Reorder headers and drop stdio.h.
11 * font.h (struct font_driver, struct font, struct glyph_string)
12 (struct face): Remove forward declaration.
13 * fontset.h (struct face, struct font): Likewise.
14 * frame.h (toplevel): Style cleanup.
15 (enum output_method): Move to...
16 * termhooks.h (enum output_method): ...here.
17 (struct glyph, struct frame, struct ns_display_info)
18 (struct x_display_info, struct w32_display_info):
19 Remove forward declaration.
20 * xterm.h (toplevel): Include termhooks.h.
21 (struct font, struct window, struct glyph_matrix, struct frame)
22 (struct input_event, struct face, struct image): Remove forward
23 declaration.
24 * gtkutil.h (struct _widget_value): Likewise.
25 * keyboard.h (toplevel): Include termhooks.h.
26 (struct input_event): Remove forward declaration.
27
28 2013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
29
30 * intervals.c (set_point_from_marker): New function.
31 * editfns.c (Fgoto_char):
32 * process.c (Finternal_default_process_filter):
33 * window.c (select_window_1): Use it.
34 * buffer.h (set_point_from_marker): Add prototype.
35
36 2013-08-29 Eli Zaretskii <eliz@gnu.org>
37
38 * w32.c (term_winsock): Call release_listen_threads before calling
39 WSACleanup.
40 (_sys_wait_accept): Wait for accept event in a loop with a finite
41 timeout, instead of waiting indefinitely. Will hopefully avoid
42 hanging during exit because WSACleanup deadlocks waiting for the
43 event object to be released. (Bug#14333)
44
45 * w32proc.c (release_listen_threads): New function, signals all
46 the reader threads that listen for connections to stop waiting.
47
48 * w32.h (release_listen_threads): Add prototype.
49
50 2013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
51
52 * alloc.c (Fmake_marker, build_marker): Zero need_adjustment
53 field of new marker (for sanity and safety).
54 * lisp.h (XSETMARKER): Remove unused macro (it doesn't work
55 anyway because XMISCTYPE is a function and can't be an lvalue).
56
57 2013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
58
59 * xterm.c (x_clear_area): Lost 7th arg because it is always False.
60 (x_after_update_window_line, x_scroll_bar_create):
61 (x_scroll_bar_set_handle, XTset_vertical_scroll_bar):
62 (handle_one_xevent, x_clear_frame_area):
63 * gtkutil.c (xg_clear_under_internal_border, xg_update_scrollbar_pos):
64 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Adjust users.
65 * xterm.h (x_clear_area): Adjust prototype.
66
67 2013-08-29 Dmitry Antipov <dmantipov@yandex.ru>
68
69 Hook scanning and indentation functions to find_newline. This helps
70 to avoid duplicated code and renders more respect to newline cache.
71 * lisp.h (scan_newline): Prefer ptrdiff_t to EMACS_INT.
72 * cmds.c (Fforward_line):
73 * indent.c (scan_for_column, Fcurrent_indentation, indented_beyond_p):
74 Use find_newline and avoid unnecessary point movements.
75 * search.c (scan_newline): Implement on top of find_newline.
76
77 2013-08-28 Stefan Monnier <monnier@iro.umontreal.ca>
78
79 * eval.c (Ffuncall): Fix handling of ((lambda ..) ..) in lexically
80 scoped code (bug#11258).
81
82 2013-08-28 Davor Cubranic <cubranic@stat.ubc.ca> (tiny change)
83
84 * nsterm.m (last_window): New variable.
85 (EV_TRAILER2): New macro.
86 (EV_TRAILER): Call EV_TRAILER2.
87 (mouseMoved:): Add support for mouse-autoselect-window
88 on nextstep (Bug#6888).
89
90 2013-08-28 Andreas Schwab <schwab@suse.de>
91
92 * regex.c (CHAR_CHARSET, CHARSET_LEADING_CODE_BASE, CHAR_HEAD_P)
93 (SINGLE_BYTE_CHAR_P, SAME_CHARSET_P, MAKE_CHAR, BYTE8_TO_CHAR):
94 Remove unused macro definitions.
95 (CHARSET_RANGE_TABLE_BITS, EXTEND_RANGE_TABLE)
96 (SET_RANGE_TABLE_WORK_AREA_BIT, SET_RANGE_TABLE_WORK_AREA):
97 Only define if emacs.
98
99 2013-08-28 Dmitry Antipov <dmantipov@yandex.ru>
100
101 Prefer enum glyph_row_area to int where appropriate.
102 * dispextern.h (enum glyph_row_area): Add ANY_AREA member.
103 Fix comment.
104 (window_box, window_box_width, window_box_left, window_box_left_offset)
105 (window_box_right, window_box_right_offset): Adjust prototypes.
106 * xdisp.c (window_box, window_box_width, window_box_left)
107 (window_box_left_offset, window_box_right, window_box_right_offset):
108 Use enum glyph_row_area. Adjust users and tweak comment where needed.
109 (window_box_edges): Likewise. Lost 2nd arg since it is always ANY_AREA.
110 * nsterm.m (ns_clip_to_row):
111 * w32term.c (w32_clip_to_row):
112 * xterm.c (x_clip_to_row): Likewise.
113
114 2013-08-28 Dmitry Antipov <dmantipov@yandex.ru>
115
116 * buffer.c (Foverlays_at, Foverlays_in, Fnext_overlay_change)
117 (Fprevious_overlay_change): Fast path for buffer with no overlays.
118
119 2013-08-28 Paul Eggert <eggert@cs.ucla.edu>
120
121 * Makefile.in (SHELL): Now @SHELL@, not /bin/sh,
122 for portability to hosts where /bin/sh has problems.
123
124 2013-08-28 Dmitry Antipov <dmantipov@yandex.ru>
125
126 Redesign redisplay interface to drop global output_cursor.
127 * dispextern.h (struct redisplay_interface): Remove cursor_to member.
128 (toplevel): Remove declaration of output_cursor.
129 (set_output_cursor, x_cursor_to): Remove prototype.
130 * window.h (struct window): New member output_cursor.
131 (output_cursor_to): New function to replace RIF member.
132 * dispnew.c (redraw_overlapped_rows, update_marginal_area)
133 (update_text_area, set_window_cursor_after_update): Use it.
134 * xdisp.c (output_cursor, set_output_cursor, x_cursor_to): Remove.
135 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
136 * nsterm.m (ns_update_window_begin, ns_update_window_end):
137 * w32term.c (x_update_window_begin, x_update_window_end):
138 * xterm.c (x_update_window_begin, x_update_window_end):
139 Adjust to use per-window output cursor.
140
141 2013-08-27 Paul Eggert <eggert@cs.ucla.edu>
142
143 Simplify SELECT_TYPE-related code.
144 Like EMACS_TIME, this portability layer is no longer needed, since
145 Emacs has been using fd_set as a portability layer for some time.
146 * sysselect.h (FD_SETSIZE): Rename from MAXDESC. All uses changed.
147 (SELECT_TYPE): Remove. All uses changed to fd_set.
148 (fd_set) [!FD_SET]: New typedef.
149
150 Simplify EMACS_TIME-related code.
151 This portability layer is no longer needed, since Emacs has been
152 using struct timespec as a portability layer for some time.
153 * atimer.h, buffer.h, dispextern.h, xgselect.h:
154 Include <time.h> rather than "systime.h"; that's all that's needed now.
155 * dispnew.c: Include <timespec.h> rather than "systime.h";
156 that's all that's needed now.
157 * systime.h (EMACS_TIME): Remove. All uses changed to struct timespec.
158 (EMACS_TIME_RESOLUTION): Remove. All uses changed to
159 TIMESPEC_RESOLUTION.
160 (LOG10_EMACS_TIME_RESOLUTION): Remove. All uses changed to
161 LOG10_TIMESPEC_RESOLUTION.
162 (EMACS_SECS, emacs_secs_addr): Remove. All uses changed to tv_sec.
163 (EMACS_NSECS): Remove. All uses changed to tv_nsec.
164 (make_emacs_time): Remove. All used changed to make_timespec.
165 (invalid_timespec): Rename from invalid_emacs_time. All uses changed.
166 (current_timespec): Rename from current_emacs_time. All uses changed.
167 (add_emacs_time): Remove. All uses changed to timespec_add.
168 (sub_emacs_time): Remove. All uses change dot timespec_sub.
169 (EMACS_TIME_SIGN): Remove. All uses changed to timespec_sign.
170 (timespec_valid_p): Rename from EMACS_TIME_VALID_P. All uses changed.
171 (EMACS_TIME_FROM_DOUBLE): Remove. All uses changed to dtotimespec.
172 (EMACS_TIME_TO_DOUBLE): Remove. All uses changed to timespectod.
173 (current_timespec): Rename from current_emacs_time. All uses changed.
174 (EMACS_TIME_EQ, EMACS_TIME_LT, EMACS_TIME_LE): Remove. All uses
175 changed to timespec_cmp.
176 * xgselect.c: Include <timespec.h>, since our .h files don't.
177
178 2013-08-27 Dmitry Antipov <dmantipov@yandex.ru>
179
180 * xterm.h (FONT_TYPE_FOR_UNIBYTE, FONT_TYPE_FOR_MULTIBYTE:)
181 * nsterm.h (FONT_TYPE_FOR_UNIBYTE, FONT_TYPE_FOR_MULTIBYTE):
182 Remove the leftovers.
183 * gtkutil.c (toplevel): Do not declare Qxft but include
184 font.h to do so.
185 * image.c (toplevel): Do not declare Vlibrary_cache because
186 it's already done in lisp.h.
187
188 2013-08-27 Dmitry Antipov <dmantipov@yandex.ru>
189
190 * lisp.h (Mouse_HLInfo): Move from here...
191 * dispextern.h (Mouse_HLInfo): ...to here and offload lisp.h.
192 (reset_mouse_highlight): New function.
193 * msdos.c (dos_set_window_size, IT_update_begin)
194 (internal_terminal_init):
195 * nsterm.m (ns_update_window_end, x_free_frame_resources)
196 (ns_initialize_display_info):
197 * w32console.c (initialize_w32_display):
198 * w32term.c (x_update_window_end, x_free_frame_resources)
199 (w32_initialize_display_info):
200 * xterm.c (x_update_window_end, x_free_frame_resources, x_term_init):
201 * window.c (Fdelete_other_windows_internal):
202 * xdisp.c (clear_mouse_face, cancel_mouse_face): Use it.
203 * termchar.h (toplevel):
204 * xterm.h (toplevel): Include dispextern.h.
205
206 2013-08-26 Paul Eggert <eggert@cs.ucla.edu>
207
208 Fix minor problems found by static checking.
209 * image.c (XGetPixel, XPutPixel) [HAVE_NS]: Now static.
210 (expect): Avoid nested-if warning.
211 (x_build_heuristic_mask) [HAVE_NS]: Avoid unused-var warning.
212 * nsmenu.m (fillWithWidgetValue:): Avoid type warning.
213 * nsterm.h, nsterm.m (ns_select):
214 * xgselect.c, xgselect.h (xg_select):
215 Adjust signature to better match pselect's.
216 * nsterm.m (ns_select):
217 Don't set *TIMEOUT, since pselect doesn't.
218 * regex.c (whitespace_regexp): Now const_re_char *, to avoid
219 diagnostic about assigning const char * to it.
220 * xfaces.c (x_display_info) [HAVE_NS]: Remove; unused.
221
222 2013-08-26 Stefan Monnier <monnier@iro.umontreal.ca>
223
224 * lread.c (substitute_object_recurse): Handle hash-tables as well
225 (bug#15190).
226
227 2013-08-26 Paul Eggert <eggert@cs.ucla.edu>
228
229 Fix unlikely core dump in init_tty, and simplify terminfo case.
230 * term.c (init_tty) [TERMINFO]: Fix check for buffer overrun.
231 The old version incorrectly dumped core if malloc returned a
232 buffer containing only non-NUL bytes.
233 (init_tty): Do not allocate or free termcap buffers; the
234 struct does that for us now.
235 * termchar.h (TERMCAP_BUFFER_SIZE) [!TERMINFO]: New constant.
236 (struct tty_display_info): Define members termcap_term_buffer and
237 termcap_strings_buffer only if !TERMINFO, since terminfo doesn't
238 use them. Allocate them directly in struct rather than indirectly
239 via a pointer, to simplify init_tty.
240
241 * frame.c (check_minibuf_window): Initialize 'window' properly,
242 so that Emacs reliably aborts later if 'window' is not initialized.
243
244 2013-08-26 Jan Djärv <jan.h.d@swipnet.se>
245
246 * gtkutil.c (xg_initialize): Set gtk-menu-bar-accel to "" instead
247 of VoidSymbol (Bug#15154).
248
249 2013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
250
251 * lisp.h (Mouse_HLInfo): Drop set-but-unused members
252 mouse_face_beg_y and mouse_face_end_y.
253 * xdisp.c (note_tool_bar_highlight, mouse_face_from_buffer_pos)
254 (mouse_face_from_string_pos, note_mode_line_or_margin_highlight):
255 Adjust users and update comment where appropriate.
256
257 2013-08-26 Martin Rudalics <rudalics@gmx.at>
258
259 * frame.c (check_minibuf_window): New function.
260 (delete_frame, Fmake_frame_invisible, Ficonify_frame):
261 Call check_minibuf_window (Bug#15183).
262
263 2013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
264
265 * window.h (struct window): Replace last_cursor with last_cursor_vpos
266 because this is the only last cursor data we need to keep and consult.
267 * window.c (replace_window, set_window_buffer, Fsplit_window_internal):
268 * xdisp.c (mark_window_display_accurate_1, try_cursor_movement):
269 Adjust users.
270
271 2013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
272
273 Fix recovering from possible decompression error.
274 Since insert_from_gap doesn't always move point, we can't use PT as
275 the position where the partially decompressed data ends, and
276 should count how many bytes was produced so far.
277 * decompress.c (struct decompress_unwind_data): Add nbytes member.
278 (unwind_decompress): Really delete partially uncompressed data.
279 (Fzlib_decompress_region): Take decompressed data size into account.
280
281 2013-08-26 Dmitry Antipov <dmantipov@yandex.ru>
282
283 * syntax.c (init_syntax_once): Adjust comment and do an early
284 initialization of Qchar_table_extra_slots just once...
285 * casetab.c (init_casetab_once):
286 * category.c (init_category_once):
287 * character.c (syms_of_character):
288 * coding.c (syms_of_coding):
289 * xdisp.c (syms_of_xdisp): ...and omit it here.
290
291 2013-08-24 Eli Zaretskii <eliz@gnu.org>
292
293 * xdisp.c (get_next_display_element): Don't apply to characters
294 from a display vector the logic of setting it->end_of_box_run_p
295 suitable for characters from a buffer. (Bug#15175)
296
297 * w32.c (fdutimens): Call 'utime', which is implemented on w32.c
298 to handle directories, rather than '_utime' which doesn't.
299 (Bug#15176)
300
301 2013-08-24 Jan Djärv <jan.h.d@swipnet.se>
302
303 * gtkutil.c (x_wm_set_size_hint): Don't set hints when maximized
304 or fullscreen (Bug#14627).
305
306 2013-08-24 Paul Eggert <eggert@cs.ucla.edu>
307
308 System-dependent integer overflow fixes.
309 * process.c (Fset_process_window_size): Signal an error if
310 the window size is outside the range supported by the lower level.
311 * sysdep.c (set_window_size): Return negative on error,
312 nonnegative on success, rather than -1, 0, 1 on not in system,
313 failure, success. This is simpler. Caller changed.
314 (serial_configure): Remove unnecessary initialization of local.
315 (procfs_get_total_memory) [GNU_LINUX]: Don't assume system memory
316 size fits in unsigned long; this isn't true on some 32-bit hosts.
317 Avoid buffer overrun if some future version of /proc/meminfo has a
318 variable name longer than 20 bytes.
319 (system_process_attributes) [__FreeBSD__]:
320 Don't assume hw.availpages fits in 'int'.
321
322 2013-08-23 Paul Eggert <eggert@cs.ucla.edu>
323
324 Don't let very long directory names overrun the stack.
325 Fix some related minor problems involving "//", vfork.
326 * callproc.c (encode_current_directory): New function.
327 (call_process): Don't append "/"; not needed.
328 * fileio.c (file_name_as_directory_slop): New constant.
329 (file_name_as_directory): Allow SRC to be longer than SRCLEN;
330 this can save the caller having to alloca.
331 (Ffile_name_as_directory, Fdirectory_file_name, Fexpand_file_name):
332 Use SAFE_ALLOCA, not alloca.
333 (directory_file_name, Fexpand_file_name): Leave leading "//"
334 alone, since it can be special even on POSIX platforms.
335 * callproc.c (call_process):
336 * process.c (Fformat_network_address):
337 * sysdep.c (sys_subshell):
338 Use encode_current_directory rather than rolling our own.
339 (create_process): No need to encode directory; caller does that now.
340 * process.h (encode_current_directory): New decl.
341 * sysdep.c (sys_subshell): Work even if vfork trashes saved_handlers.
342 Rework to avoid 'goto xyzzy;'.
343
344 2013-08-23 Eli Zaretskii <eliz@gnu.org>
345
346 * xdisp.c (handle_face_prop): If the default face was remapped use
347 the remapped face for strings from prefix properties. (Bug#15155)
348
349 2013-08-23 Dmitry Antipov <dmantipov@yandex.ru>
350
351 Minor cleanup for redisplay interface and few related functions.
352 * frame.h (enum text_cursor_kinds): Move from here...
353 * dispextern.h (enum text_cursor_kinds): ...to here.
354 (toplevel): Drop unnecessary declarations.
355 (struct redisplay_interface): Use bool and enum text_cursor_kinds
356 in update_window_end_hook and draw_window_cursor functions.
357 (display_and_set_cursor, x_update_cursor): Adjust prototypes.
358 * nsterm.m (ns_update_window_end, ns_draw_window_cursor):
359 * w32term.c (x_update_window_end,w32_draw_window_cursor):
360 * xterm.c (x_update_window_end, x_draw_window_cursor):
361 * xdisp.c (display_and_set_cursor, update_window_cursor)
362 (update_cursor_in_window_tree, x_update_cursor): Use bool and
363 enum text_cursor_kinds where appropriate.
364
365 2013-08-23 Dmitry Antipov <dmantipov@yandex.ru>
366
367 Redesign redisplay interface to drop updated_row and updated_area.
368 * dispextern.h (updated_row, updated_area): Remove declaration.
369 (struct redisplay_interface): Pass glyph row and row area parameters
370 to write_glyphs, insert_glyphs and clear_end_of_line functions.
371 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
372 Adjust prototypes.
373 * dispnew.c (updated_row, updated_area): Remove.
374 (redraw_overlapped_rows, update_window_line): Adjust user.
375 (update_marginal_area, update_text_area): Likewise. Pass updated row
376 as a parameter. Prefer enum glyph_row_area to int where appropriate.
377 * xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
378 Adjust users.
379
380 2013-08-22 Paul Eggert <eggert@cs.ucla.edu>
381
382 * process.c (flush_pending_output): Remove stub.
383 All uses removed.
384
385 2013-08-21 Paul Eggert <eggert@cs.ucla.edu>
386
387 * callproc.c: Fix race that killed background processes (Bug#15144).
388 (call_process): New arg TEMPFILE_INDEX. Callers changed.
389 Record deleted process-id in critical section, not afterwards.
390 Don't mistakenly kill process created by a call-process invocation
391 that discards output and does not wait.
392
393 2013-08-21 Dmitry Antipov <dmantipov@yandex.ru>
394
395 Fix compilation with GC_MARK_STACK == GC_USE_GCPROS_AS_BEFORE
396 and GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES.
397 * alloc.c (toplevel): Remove unnecessary nested #if...#endif.
398 (mark_maybe_object) [!GC_MARK_STACK]: Define to emacs_abort
399 to shut up compiler in mark_object.
400 (dump_zombies): Convert to global and add EXTERNALLY_VISIBLE.
401
402 2013-08-21 Paul Eggert <eggert@cs.ucla.edu>
403
404 * process.c (allocate_pty) [PTY_OPEN]: Set fd's FD_CLOEXEC flag.
405 We can't portably rely on PTY_OPEN doing that, even if
406 it calls posix_openpt with O_CLOEXEC.
407
408 2013-08-20 Kenichi Handa <handa@gnu.org>
409
410 * character.c (string_char): Improve commentary.
411
412 2013-08-20 Paul Eggert <eggert@cs.ucla.edu>
413
414 * image.c (SIGNATURE_DIGESTSIZE): Remove.
415 (struct animation_cache): Make signature a flexible array member.
416 All uses changed. This is a tad slower but may insulate us better
417 from future changes to ImageMagick.
418
419 2013-08-19 Paul Eggert <eggert@cs.ucla.edu>
420
421 * image.c: Shrink memory needed for animation cache.
422 (SIGNATURE_DIGESTSIZE): New constant.
423 (struct animation_cache): Make 'signature' a fixed size array of bytes.
424 (imagemagick_create_cache): Copy the signature. This saves
425 several KB of memory that ImageMagick wastes per signature.
426 Don't bother updating the update_time, as the caller does that now.
427 (imagemagick_prune_animation_cache): Don't destroy the signature, as
428 it's a fixed size struct member now.
429 (imagemagick_get_animation_cache): Always destroy the signature,
430 as it's now imagemagick_create_cache's responsibility to copy it.
431 Avoid duplicate calls to strcmp and to imagemagick_create_cache,
432 and use memcmp rather than strcmp.
433 eassert that ImageMagick returns a signature of the specified length.
434
435 2013-08-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
436
437 * image.c (imagemagick_get_animation_cache): Don't segfault on
438 each invocation.
439 (imagemagick_get_animation_cache): Revert to previous definition
440 so that it actually works. But keep the memory leak fix.
441 (imagemagick_get_animation_cache): Fix memory leak.
442
443 2013-08-19 Paul Eggert <eggert@cs.ucla.edu>
444
445 * image.c: Fix animation cache signature memory leak.
446 Fix some other minor performance problems while we're at it.
447 (imagemagick_create_cache): Clear just the members that
448 need clearing. Don't set update_time, as caller does that now.
449 (imagemagick_prune_animation_cache, imagemagick_get_animation_cache):
450 Simplify by using pointer-to-pointer instead of a prev pointer.
451 (imagemagick_prune_animation_cache): Use make_emacs_time rather
452 than EMACS_TIME_FROM_DOUBLE, and DestroyString rather than free.
453 (imagemagick_get_animation_cache): Don't xstrdup the image signature;
454 it's already a copy. Free the signature probe unless it's cached.
455
456 * process.c (handle_child_signal): Fix crash; deleted pid (Bug#15106).
457 This was introduced by my 2013-08-12 fix for Bug#15035.
458
459 2013-08-19 Dmitry Antipov <dmantipov@yandex.ru>
460
461 * image.c (imagemagick_create_cache, imagemagick_get_animation_cache)
462 (imagemagick_prune_animation_cache): Now static.
463
464 2013-08-18 Lars Magne Ingebrigtsen <larsi@gnus.org>
465
466 * image.c (imagemagick_get_animation_cache): Don't segfault when
467 pruning all entries.
468
469 2013-08-18 Ken Brown <kbrown@cornell.edu>
470
471 * sheap.c (STATIC_HEAP_SIZE): Adjust to current needs; use bigger
472 static heap if ENABLE_CHECKING is defined.
473 (max_bss_sbrk_ptr): New variable.
474 (bss_sbrk): Use it.
475 (report_sheap_usage): Report maximum static heap usage instead of
476 ending static heap usage.
477
478 2013-08-17 Eli Zaretskii <eliz@gnu.org>
479
480 * decompress.c (Fzlib_available_p) [WINDOWSNT]: Update the value
481 of zlib_initialized according to the results of calling
482 init_zlib_functions.
483
484 2013-08-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
485
486 * image.c: Implement an ImageMagick per-image cache.
487 (imagemagick_get_animation_cache): Fix a double-free error.
488 (imagemagick_load_image): Remove the ping_wand code, which only
489 apparently saved time on invalid animated images, and slowed down
490 everything else. Optimise for the common case.
491
492 2013-08-16 Xue Fuqiao <xfq.free@gmail.com>
493
494 * buffer.c (syms_of_buffer) <buffer-undo-list>: Doc fix.
495
496 * editfns.c (insert_before_markers): Mention overlay in the doc string.
497
498 * marker.c (set_marker): Remove documentation of undefined behavior.
499
500 2013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
501
502 * image.c (imagemagick_compute_animated_image): Animate correctly
503 when sub-images are smaller than the main image.
504 (imagemagick_compute_animated_image): Setting the iterator row to
505 zero is apparently not allowed.
506 (imagemagick_compute_animated_image): Allow images that say they
507 have sub-images that are bigger than the main image, but just crop
508 them.
509
510 2013-08-15 Jan Djärv <jan.h.d@swipnet.se>
511
512 * nsmenu.m (menuWillOpen:): Fix preprocessor test (Bug#15001).
513
514 2013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
515
516 * image.c (imagemagick_compute_animated_image): Respect the GIF
517 disposal methods.
518
519 2013-08-15 Ken Brown <kbrown@cornell.edu>
520
521 * emacs.c (main): Update comment about G_SLICE_ALWAYS_MALLOC.
522 * gmalloc.c (memalign) [CYGWIN]: Revert last change; it's not
523 needed.
524
525 2013-08-15 Paul Eggert <eggert@cs.ucla.edu>
526
527 Fix minor problems found by static checking.
528 * frame.c (delete_frame):
529 * xdisp.c (next_element_from_display_vector):
530 Avoid uninitialized local.
531 * image.c (imagemagick_compute_animated_image): Port to C89.
532 Prefer usual GNU indentation style for loops.
533 Be more careful about bizarrely large sizes, by using ptrdiff_t
534 instead of int.
535
536 2013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
537
538 Fix infinite frame selection loop (Bug#15025).
539 * frame.c (delete_frame): Prefer fast ad-hoc loop to next_frame.
540
541 2013-08-15 Eli Zaretskii <eliz@gnu.org>
542
543 * xdisp.c (compute_window_start_on_continuation_line):
544 When WORD_WRAP is in effect, use move_it_to instead of move_it_by_lines
545 to make sure we end up setting the window start at the leftmost
546 visible character of the display line. This avoids funky
547 horizontal shifting because the window start is not kept on the
548 same position. (Bug#15090)
549 (next_element_from_display_vector): Support 'box' face attribute
550 in the face definitions of a display vector. (Bug#15099)
551
552 2013-08-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
553
554 * image.c (imagemagick_compute_animated_image): Implement animated
555 images (bug#14700).
556 (imagemagick_compute_animated_image): Fix some compilation
557 warnings. Implement a very simple cache to make the animation
558 usable at all, but it should be replaced with a per-image cache.
559
560 2013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
561
562 * lisp.h (FOR_EACH_ALIST_VALUE): New macro
563 to do `for' loops over alist values.
564 * buffer.h (FOR_EACH_BUFFER):
565 * process.c (FOR_EACH_PROCESS): Use it.
566 (handle_child_signal, status_notify, Fget_buffer_process)
567 (kill_buffer_processes): Use FOR_EACH_PROCESS.
568
569 2013-08-15 Dmitry Antipov <dmantipov@yandex.ru>
570
571 * term.c (get_named_tty, create_tty_output, tty_free_frame_resources)
572 (tty_free_frame_resources, delete_tty): Prefer eassert to emacs_abort.
573 * image.c (make_image_cache): For struct image_cache, prefer xmalloc
574 to xzalloc and so avoid redundant call to memset.
575 * xterm.c (x_term_init): Avoid unnecessary initializations of dpyinfo
576 members because it is allocated with xzalloc and so already zeroed.
577
578 2013-08-14 Ken Brown <kbrown@cornell.edu>
579
580 * gmalloc.c (memalign) [CYGWIN]: Rename to emacs_memalign
581 (Bug#15094).
582
583 2013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
584
585 Utility function and macro to copy Lisp string to C string.
586 * lisp.h (xlispstrdupa): New macro.
587 (xlispstrdup): New prototype.
588 * alloc.c (xlispstrdup): New function.
589 * callint.c (Fcall_interactively):
590 * fileio.c (Ffile_name_directory, Fexpand_file_name)
591 (Fsubstitute_in_file_name):
592 * frame.c (Fmake_terminal_frame): Use xlispstrdupa.
593 * image.c (x_create_bitmap_from_file):
594 * w32term.c (w32_term_init):
595 * xterm.c (x_term_init): Use xlispstrdup.
596
597 2013-08-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
598
599 * image.c (imagemagick_load_image): Make animated pictures work.
600 There's still some problems with background color settings, though
601 (bug#14700).
602
603 * decompress.c (unwind_decompress): Always restore point.
604
605 2013-08-14 Xue Fuqiao <xfq.free@gmail.com>
606
607 * marker.c (set_marker): Reformat documentation.
608
609 2013-08-14 Paul Eggert <eggert@cs.ucla.edu>
610
611 * xdisp.c (cursor_type_changed): Now static.
612
613 * image.c (imagemagick_filename_hint): New arg HINT_BUFFER.
614 Use changed. This avoids the need to call xmalloc and for the
615 caller to call xfree, and avoids memory leaks in some situations.
616
617 2013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
618
619 * xdisp.c (adjust_window_ends): Move duplicated code to new function.
620 (try_window, try_window_reusing_current_matrix, try_window_id): Use it.
621 (redisplay_window): If window_end_valid is cleared due to non-zero
622 windows_or_buffers_changed, clear current_matrix_up_to_date_p and
623 so do not call to try_cursor_movement for that window.
624
625 2013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
626
627 * window.h (struct window): Convert window_end_pos and
628 window_end_vpos from Lisp_Object to ptrdiff_t and int, respectively.
629 (wset_window_end_pos, wset_window_end_vpos): Remove.
630 * dispnew.c (adjust_glyph_matrix):
631 * window.c (Fwindow_end, replace_window, set_window_buffer)
632 (make_window):
633 * xdisp.c (check_window_end, move_it_to, redisplay_internal)
634 (set_vertical_scroll_bar, redisplay_window, try_window)
635 (try_window_reusing_current_matrix, find_first_unchanged_at_end_row)
636 (try_window_id, decode_mode_spec, mouse_face_from_buffer_pos)
637 (note_mouse_highlight): Adjust users.
638 (try_cursor_movement): Likewise. Convert old precondition to eassert.
639 Add comment.
640
641 2013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
642
643 Fix --enable-gcc-warnings errors introduced in 2013-08-13 commit.
644 * image.c (imagemagick_filename_hint): Use `const char *' and
645 prefer SSDATA to SDATA to avoid warnings.
646
647 2013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
648
649 Cleanup window fringes, margins and scroll bars adjustments.
650 * window.c (set_window_fringes, set_window_margins)
651 (set_window_scroll_bars, apply_window_adjustment): New functions.
652 (set_window_buffer, Fset_window_margins, Fset_window_fringes)
653 (Fset_window_scroll_bars): Use them.
654
655 2013-08-14 Dmitry Antipov <dmantipov@yandex.ru>
656
657 * window.h (struct window): Convert scroll_bar_width
658 from Lisp_Object to integer. Adjust comment.
659 (WINDOW_CONFIG_SCROLL_BAR_WIDTH, WINDOW_CONFIG_SCROLL_BAR_COLS):
660 Adjust users.
661 * window.c (wset_scroll_bar_width): Remove.
662 (make_window): Initialize scroll_bar_width.
663 (Fsplit_window_internal): Use direct assignment.
664 (Fset_window_configuration, save_window_save):
665 Convert Lisp_Object to integer and back where appropriate.
666 (Fset_window_scroll_bars): Adjust user. Return t if any scroll
667 bar was actually changed, and mention this in docstring.
668
669 2013-08-13 Paul Eggert <eggert@cs.ucla.edu>
670
671 * decompress.c: Minor simplifications.
672 (Fzlib_decompress_region): Don't bother verifying
673 that avail_out <= UINT_MAX, as that was confusing.
674 Mention the restriction in a comment instead.
675 Prefer 'int' to 'ptrdiff_t' when 'int' is wide enough.
676
677 2013-08-13 Jan Djärv <jan.h.d@swipnet.se>
678
679 * nsmenu.m (x_activate_menubar): Check for OSX >= 10.5
680 (trackingNotification:): Call ns_check_menu_open only for OSX >= 10.5.
681
682 2013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
683
684 * image.c (imagemagick_filename_hint): Check for errors in the
685 alist structure.
686
687 2013-08-13 Eli Zaretskii <eliz@gnu.org>
688
689 * window.c (Fwindow_margins): Return nil when there's no marginal
690 area, as per the documented API.
691
692 * w32term.c (x_scroll_bar_create): Use ALLOCATE_PSEUDOVECTOR, not
693 Fmake_vector, as scroll bar's struct members are not all Lisp
694 objects now. This avoids crashes in GC.
695
696 * w32term.h (struct scroll_bar): Convert fringe_extended_p to a
697 bool, so its address could be taken.
698
699 2013-08-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
700
701 * image.c (imagemagick_filename_hint): New function to possibly
702 apply `image-content-type-suffixes'.
703 (imagemagick_load_image): Use it.
704
705 2013-08-13 Eli Zaretskii <eliz@gnu.org>
706
707 * decompress.c (Fzlib_decompress_region) [WINDOWSNT]: Return Qnil
708 if loading zlib failed.
709
710 2013-08-13 Jan Djärv <jan.h.d@swipnet.se>
711
712 * nsterm.m (ns_set_vertical_scroll_bar): Fix breakage intruduced by
713 2013-08-13 checkin below. Change bool to BOOL, rule is:
714 All Obj-C code uses BOOL, except for interfaces callable from C.
715
716 * nsterm.h: Fix CGFloat for OSX 10.4 (Bug#15086).
717
718 2013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
719
720 * window.h (WINDOW_FRINGE_EXTENDED_P): New macro.
721 * nsterm.m (ns_set_vertical_scroll_bar): Use it. Use convenient
722 bool instead of BOOL.
723 * w32term.h (struct scroll_bar): Convert fringe_extended_p
724 from Lisp_Object to bitfield. Adjust comment.
725 * w32term.c (x_scroll_bar_create): Adjust user.
726 Use WINDOW_FRINGE_EXTENDED_P and bool for boolean.
727 * xterm.c (XTset_vertical_scroll_bar): Likewise.
728 Use bool for boolean.
729 * xterm.h (struct scroll_bar): Prefer commonly used `unsigned'
730 to `unsigned int' when defining a bitfield.
731
732 2013-08-13 Paul Eggert <eggert@cs.ucla.edu>
733
734 * decompress.c (Fzlib_decompress_region): Try to clarify 'avail_out'.
735
736 2013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
737
738 * window.h (struct window): Convert left_margin_cols and
739 right_margin_cols from Lisp_Objects to integers. Adjust comment.
740 (WINDOW_LEFT_MARGIN_COLS, WINDOW_RIGHT_MARGIN_COLS)
741 (WINDOW_LEFT_MARGIN_WIDTH, WINDOW_RIGHT_MARGIN_WIDTH):
742 Adjust users.
743 * dispnew.c (margin_glyphs_to_reserve): Convert 3rd arg to int.
744 Adjust comment.
745 (showing_window_margins_p, update_window_line, update_frame_1):
746 * fringe.c (draw_fringe_bitmap_1):
747 * xdisp.c (window_box_width): Adjust users.
748 * window.c (wset_left_margin_cols, wset_right_margin_cols): Remove.
749 (adjust_window_margins, set_window_buffer, Fsplit_window_internal):
750 Use direct assignment.
751 (Fset_window_configuration, save_window_save, Fwindow_margins):
752 Convert Lisp_Object to integer and back where appropriate.
753 (Fset_window_margins): Adjust user. Return t if any margin
754 was actually changed, and mention this in docstring.
755
756 2013-08-13 Xue Fuqiao <xfq.free@gmail.com>
757
758 * syntax.c (forward_word):
759 * cmds.c (forward_char, backward_char): Mention the optional argument.
760
761 2013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
762
763 * window.h (struct window): Convert left_fringe_width
764 and right_fringe_width from Lisp_Objects to integers.
765 Adjust comment.
766 (WINDOW_FRINGE_COLS, WINDOW_LEFT_FRINGE_WIDTH)
767 (WINDOW_RIGHT_FRINGE_WIDTH): Adjust users.
768 * window.c (wset_left_fringe_width, wset_right_fringe_width):
769 Remove.
770 (make_window): Initialize new integer fields to -1.
771 (Fsplit_window_internal): Use direct assignment.
772 (Fset_window_configuration, save_window_save):
773 Convert Lisp_Object to integer and back where appropriate.
774 (Fset_window_fringes): Adjust user. Return t if any fringe
775 was actually changed, and mention this in docstring.
776
777 2013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
778
779 * keyboard.c (Fdiscard_input): Do not increment update_mode_lines.
780 * nsfns.m (x_set_cursor_type):
781 * w32fns.c (x_set_cursor_type):
782 * xfns.m (x_set_cursor_type): Do not set cursor_type_changed here...
783 * xdisp.c (set_frame_cursor_types): ...but in common code.
784
785 2013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
786
787 * font.c (clear_font_cache): New function, stripped from...
788 (Fclear_font_cache): ...here, which now uses the function
789 above. Adjust comment.
790 * font.h (clear_font_cache): Add prototype.
791 * xfaces.c (clear_face_cache): Use clear_font_cache.
792
793 2013-08-13 Dmitry Antipov <dmantipov@yandex.ru>
794
795 * window.c (Fset_window_start): Compare `w', not `window' because
796 `w' might not be equal to `window' after call to decode_live_window.
797
798 2013-08-12 Paul Eggert <eggert@cs.ucla.edu>
799
800 * process.c (deactivate_process): Reset fds to -1 (Bug#15035).
801 This fixes a problem introduced by the Bug#15035 patch
802 when using GPG. Reported by Herbert J. Skuhra.
803
804 2013-08-12 Eli Zaretskii <eliz@gnu.org>
805
806 * decompress.c <zlib_initialized> [WINDOWSNT]: New static variable.
807 (Fzlib_decompress_region) [WINDOWSNT]: Call init_zlib_functions if
808 not yet initialized.
809
810 2013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
811
812 * decompress.c (Fzlib_decompress_region): Support zlib
813 decompression, too, and rename.
814
815 2013-08-12 Paul Eggert <eggert@cs.ucla.edu>
816
817 Minor zlib configuration tweaks.
818 * decompress.c (fn_inflateInit2) [!WINDOWSNT]:
819 Don't assume presence of fn_inflateInit2_ zlib internal function.
820
821 2013-08-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
822
823 * decompress.c (Fzlib_decompress_gzipped_region): Rename to
824 include the zlib prefix.
825
826 2013-08-12 Eli Zaretskii <eliz@gnu.org>
827
828 * decompress.c [WINDOWSNT]: Include windows.h and w32.h.
829 (DEF_ZLIB_FN, LOAD_ZLIB_FN) [WINDOWSNT]: New macros. Use them to
830 define static variables that are pointers to zlib functions to be
831 dynamically loaded.
832 (init_zlib_functions) [WINDOWSNT]: New function.
833 (fn_inflateInit2_, fn_inflate, fn_inflateEnd, fn_inflateInit2):
834 New macros.
835 (Fdecompress_gzipped_region, unwind_decompress): Use the fn_*
836 macros instead of invoking the zlib functions directly.
837 (syms_of_decompress): DEFSYM Qzlib_dll.
838 Staticpro Szlib_available_p.
839
840 2013-08-12 Dmitry Antipov <dmantipov@yandex.ru>
841
842 Avoid looping over all frame windows to freeze and unfreeze.
843 * window.h (struct window): Drop frozen_window_start_p.
844 (freeze_window_starts): Drop prototype.
845 * frame.h (struct frame): New frozen_window_starts flag.
846 (FRAME_WINDOWS_FROZEN): New macro.
847 * window.c (freeze_window_start, freeze_window_starts):
848 Remove.
849 (select_window, replace_window): Adjust users.
850 * xdisp.c (resize_mini_window): Use FRAME_WINDOWS_FROZEN.
851 (window_frozen_p): New function.
852 (redisplay_window): Use it.
853
854 2013-08-12 Paul Eggert <eggert@cs.ucla.edu>
855
856 Fix some fd issues when running subprocesses (Bug#15035).
857 Fix bugs that can leak files or file descriptors on errors.
858 Don't unlink open temp files, as that's hard for users to diagnose
859 when things go awry (e.g., temp disk exhausted).
860 Don't bother to lock temp files. Check for invalid recursion.
861 * callproc.c (synch_process_fd): Remove. All uses removed.
862 (synch_process_tempfile): New var or macro.
863 (CALLPROC_STDOUT, CALLPROC_STDERR, CALLPROC_PIPEREAD, CALLPROC_FDS):
864 New constants.
865 (record_kill_process): New arg, the temp name. All callers changed.
866 (delete_temp_file): Now just a simple wrapper around unlink.
867 (call_process_kill): New arg, the call_process_fd array.
868 Close them all. Clear synch_process_pid. Remove the temp file,
869 or arrange for it to be removed.
870 (call_process_cleanup) [MSDOS]: Arg no longer contains file name;
871 that's been moved to synch_process_tempfile. Caller changed.
872 Do not remove the tempfile; that's now call_process_kill's
873 responsibility.
874 (call_process_cleanup) [!MSDOS]: Do not record unwind-protect for
875 call_process_kill; the caller now does that.
876 (call_process_cleanup): Do not close the process fd; that's now
877 call_process_kill's responsibility.
878 (Fcall_process): Implement via new function call_process, which
879 has most of the old body of Fcall_process, but with a different API.
880 (call_process): New function that does not open or close filefd if
881 it is nonnegative. Record which fds need to be closed, and let
882 call_process_kill close (and remove the tempfile, on MSDOS) on error.
883 Signal an error if invoked recursively (could be done via a hook).
884 Simplify creation of the tempfile in the MSDOS case.
885 Don't create the output file until after checking for the executable.
886 Report any failure to open /dev/null.
887 Don't open /dev/null for writing twice; once is enough.
888 Don't create pipe if all output is being discarded or sent to file.
889 Don't worry about setting up the coding system or reading from the
890 pipe if all output is being discarded.
891 Hoist fd_error local into top level, to lessen block nesting.
892 Don't record deleted pid here; now done by Fcall_process_region.
893 (Fcall_process) [MSDOS]: Report mktemp failure immediately,
894 and note its success in synch_process_tempfile.
895 Do not leak resources when child_setup fails.
896 (Fcall_process) [!MSDOS && !WINDOWSNT]: Remove duplicate assignment
897 to child_errno. Remove unnecessary close of fd0; it's close-on-exec.
898 (create_temp_file): Now returns open fd, with an additional
899 Lisp_Object * argument to return the name. All callers changed.
900 Do not close the file; rewind it instead, and leave it open for
901 the caller. Do not lock the temp file. Unwind-protect the file
902 and the file-descriptor.
903 (Fcall_process_region): If the input is /dev/null, unwind-protect it.
904 If an asynchrounous process, record it here, not in call_process.
905 (syms_of_callproc) [MSDOS]: Initialize synch_process_tempfile.
906 * eval.c (set_unwind_protect): New function.
907 * fileio.c (write_region): New function, generalized from the
908 old Fwrite_region. Do not lock temp files.
909 (Fwrite_region): Use it.
910 * lisp.h (set_unwind_protect, write_region): New decls.
911 * process.c: Include <verify.h>.
912 (make_process): Mark fds as initially closed.
913 (deleted_pid_list): Now a list of pid-filename pairs.
914 All uses changed.
915 (close_process_fd): New function.
916 (SUBPROCESS_STDIN, WRITE_TO_SUBPROCESS, READ_FROM_SUBPROCESS)
917 (SUBPROCESS_STDOUT, READ_FROM_EXEC_MONITOR, EXEC_MONITOR_OUTPUT):
918 New constants. Verify that their number matches PROCESS_OPEN_FDS.
919 (create_process, create_pty, Fmake_serial_process)
920 (server_accept_connection): Record which fds need to be closed,
921 and let deactivate_process close them.
922 (Fmake_network_process): Do not discard the unwind-protect
923 until it's safe to do so.
924 (deactivate_process): Close the fds opened by create_process etc.
925 (Fprocess_send_eof): Adjust to new way of recording open fds.
926 Report an error if /dev/null can't be opened, instead of aborting.
927 * process.h (PROCESS_OPEN_FDS): New constant.
928 (struct Lisp_Process): New member open_fds.
929 (record_kill_process, record_deleted_pid): Adjust signatures.
930 (record_deleted_pid): Move decl here ...
931 * syswait.h (record_deleted_pid): ... from here.
932
933 2013-08-11 Paul Eggert <eggert@cs.ucla.edu>
934
935 * decompress.c: Fix bugs with large buffers and weird inputs.
936 Tune a bit. Reindent as per usual Emacs style.
937 (BUFFER_SIZE): Remove.
938 (Fdecompress_gzipped_region): Do not mishandle input buffers with
939 more than UINT_MAX bytes. Decompress into the gap instead of into
940 an auto buffer, as this should avoid copying. Return nil if
941 'inflate' returns Z_NEED_DICT, as we have no dictionary. Do not
942 set immediate_quit; we shouldn't trust zlib code that much.
943
944 2013-08-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
945
946 * decompress.c (Fdecompress_gzipped_region): Respect all zlib
947 errors, and really move the gap to where we want it.
948
949 * lisp.h: Include decompress.c support.
950
951 * emacs.c (main): Include decompress.c support.
952
953 * Makefile.in: Include -lz if present.
954
955 2013-08-11 Jan Djärv <jan.h.d@swipnet.se>
956
957 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:frame:
958 (initWithTitle:): Initialize frame to 0.
959 (fillWithWidgetValue:): Call fillWithWidgetValue:frame.
960 (fillWithWidgetValue:frame:): Rename from
961 fillWithWidgetValue:setDelegate, call initWithTile:frame: if f.
962
963 * nsterm.h (EmacsMenu): fillWithWidgetValue:setDelegate renamed to
964 fillWithWidgetValue:frame:
965
966 * nsfns.m (Fns_convert_utf8_nfd_to_nfc): Allocate and release pool to
967 remove memory leak warnings.
968
969 * nsterm.m (menu_pending_title, ns_get_pending_menu_title): Remove.
970 (ns_check_menu_open): Handle menu == nil. Remove assignment to
971 menu_pending_title.
972
973 * nsmenu.m (ns_update_menubar): Call fillWithWidgetValue:setDelegate.
974 (x_activate_menubar): Update the whole menu.
975 (trackingNotification:): Call ns_check_menu_open if tracking ends.
976 (menuWillOpen:): Increment trackingMenu. For OSX <= 10.6, exit if
977 current event is not NSSystemDefined (Bug#15001).
978 Call ns_check_menu_open only if trackingMenu is 2.
979 (menuDidClose:): New method, decrease trackingMenu.
980 (fillWithWidgetValue:setDelegate:): New method.
981 (fillWithWidgetValue:): Call the above.
982
983 * nsterm.h (EmacsMenu): Add fillWithWidgetValue:setDelegate:
984
985 2013-08-11 Paul Eggert <eggert@cs.ucla.edu>
986
987 Omit some unnecessary casts.
988 Many of these go back to the old pre-C89 days, when they may have
989 been needed, but we've been assuming C89 or later for a while now.
990 * alloc.c (live_string_p, live_cons_p, live_symbol_p)
991 (live_float_p, live_misc_p, live_vector_p):
992 * buffer.c (compare_overlays, cmp_for_strings, mmap_find)
993 (mmap_alloc, alloc_buffer_text, enlarge_buffer_text)
994 (defvar_per_buffer):
995 * callint.c (Fcall_interactively):
996 * doc.c (Fsubstitute_command_keys):
997 * filelock.c (get_boot_time):
998 * frame.c (xrdb_get_resource):
999 * gtkutil.c (hierarchy_ch_cb, qttip_cb, style_changed_cb)
1000 (delete_cb, xg_dialog_response_cb, xg_maybe_add_timer)
1001 (xg_get_file_name_from_selector, menuitem_destroy_callback)
1002 (menuitem_highlight_callback, menu_destroy_callback)
1003 (xg_update_menu_item, xg_modify_menubar_widgets, menubar_map_cb)
1004 (xg_tool_bar_callback, xg_get_tool_bar_widgets)
1005 (xg_tool_bar_detach_callback, xg_tool_bar_attach_callback)
1006 (xg_tool_bar_help_callback, tb_size_cb):
1007 * image.c (xpm_alloc_color, png_read_from_memory)
1008 (png_read_from_file, png_load_body, our_memory_skip_input_data)
1009 (jpeg_memory_src, jpeg_file_src, imagemagick_load_image)
1010 (syms_of_image):
1011 * keymap.c (describe_map):
1012 * nsfns.m (Fns_display_monitor_attributes_list):
1013 * nsmenu.m (process_dialog:):
1014 * nsterm.m (hold_event):
1015 * process.c (wait_reading_process_output):
1016 * regex.c (REGEX_REALLOCATE, re_set_registers, re_exec, regexec):
1017 * scroll.c (do_direct_scrolling, scrolling_1):
1018 * termcap.c (tgetent):
1019 * window.c (check_window_containing, add_window_to_list)
1020 (freeze_window_starts):
1021 * xdisp.c (compare_overlay_entries, vmessage):
1022 * xfns.c (x_window, x_get_monitor_attributes_xinerama)
1023 (x_get_monitor_attributes_xrandr)
1024 (Fx_display_monitor_attributes_list, x_display_info_for_name)
1025 (Fx_open_connection, file_dialog_cb, file_dialog_unmap_cb):
1026 * xfont.c (xfont_match, xfont_open):
1027 * xmenu.c (x_menu_wait_for_event, menu_highlight_callback)
1028 (menubar_selection_callback, menu_position_func)
1029 (popup_selection_callback, create_and_show_popup_menu)
1030 (dialog_selection_callback, create_and_show_dialog):
1031 * xrdb.c (x_get_string_resource):
1032 (main) [TESTRM]:
1033 * xsmfns.c (x_session_check_input):
1034 * xterm.c (x_draw_glyphless_glyph_string_foreground)
1035 (xm_scroll_callback, xg_scroll_callback, xg_end_scroll_callback)
1036 (xaw_jump_callback, xaw_scroll_callback):
1037 Omit unnecessary casts.
1038
1039 2013-08-10 Paul Eggert <eggert@cs.ucla.edu>
1040
1041 Minor string-length refactoring.
1042 * alloc.c (xstrdup): Use memcpy, not strcpy, since the length's known.
1043 * frame.c (make_monitor_attribute_list):
1044 Prefer build_string to strlen + make_string.
1045
1046 2013-08-10 Jan Djärv <jan.h.d@swipnet.se>
1047
1048 * xterm.c (x_error_handler): Also ignore BadWindow for X_SetInputFocus,
1049 don't check minor_code (Bug#14417).
1050
1051 2013-08-09 Eli Zaretskii <eliz@gnu.org>
1052
1053 * xdisp.c (draw_glyphs): Don't compare row pointers, compare row
1054 vertical positions instead. This avoids calling MATRIX_ROW with
1055 row numbers that are possibly beyond valid limits. (Bug#15064)
1056
1057 2013-08-09 Dmitry Antipov <dmantipov@yandex.ru>
1058
1059 Use xstrdup and build_unibyte_string where applicable.
1060 * alloc.c (xstrdup): Tiny cleanup. Add eassert.
1061 * xfns.c (x_window):
1062 * xrdb.c (x_get_customization_string):
1063 * xterm.c (xim_initialize):
1064 * w32fns.c (w32_window): Use xstrdup.
1065 (w32_display_monitor_attributes_list):
1066 * emacs.c (init_cmdargs):
1067 * keyboard.c (PUSH_C_STR):
1068 * nsfont.m (nsfont_open):
1069 * sysdep.c (system_process_attributes):
1070 * w32.c (system_process_attributes):
1071 * xdisp.c (message1, message1_nolog): Use build_unibyte_string.
1072
1073 2013-08-09 Eli Zaretskii <eliz@gnu.org>
1074
1075 * w32.c (PEXCEPTION_POINTERS, PEXCEPTION_RECORD, PCONTEXT): Define
1076 variables of these types so that GDB would know about them, as aid
1077 for debugging fatal exceptions. (Bug#15024) See also
1078 http://sourceware.org/ml/gdb/2013-08/msg00010.html for related
1079 discussions.
1080
1081 2013-08-08 Jan Djärv <jan.h.d@swipnet.se>
1082
1083 * nsterm.m (ns_update_begin): Don't change clip path if it would be
1084 larger than the NSWindow (Bug#14934).
1085
1086 2013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
1087
1088 Redesign redisplay interface to drop global variable updated_window.
1089 Always pass currently updated window as a parameter to update routines.
1090 * dispextern.h (updated_window): Remove declaration.
1091 (struct redisplay_interface): Pass window parameter to
1092 write_glyphs, insert_glyphs, clear_end_of_line, cursor_to
1093 and after_update_window_hook.
1094 (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line, x_cursor_to):
1095 Adjust prototypes.
1096 * dispnew.c (updated_window): Remove.
1097 (redraw_overlapped_rows, update_marginal_area, update_text_area)
1098 (update_window_line): Adjust to match redisplay interface changes.
1099 * nsterm.m (ns_update_window_begin, ns_update_window_end)
1100 (ns_scroll_run, ns_after_update_window_line):
1101 * w32term.c (x_update_window_begin, x_update_window_end)
1102 (x_after_update_window_line, x_scroll_run):
1103 * xterm.c (x_update_window_begin, x_update_window_end)
1104 (x_after_update_window_line, x_scroll_run):
1105 * xdisp.c (x_write_glyphs, x_insert_glyphs, x_clear_end_of_line):
1106 Likewise. Adjust comments where appropriate.
1107 (x_cursor_to): Simplify because this is always called during window
1108 update (but install debugging check anyway).
1109 (expose_window): Check must_be_updated_p flag to see whether this
1110 function is called during window update.
1111
1112 2013-08-08 Dmitry Antipov <dmantipov@yandex.ru>
1113
1114 Do not reset window modification event counters excessively.
1115 These leftovers and poor man's tricky methods to catch extra
1116 redisplay's attention are no longer needed.
1117 * frame.c (set_menu_bar_lines_1):
1118 * minibuf.c (read_minibuf_unwind):
1119 * window.c (Fset_window_start, set_window_buffer, window_resize_apply)
1120 (grow_mini_window, shrink_mini_window, window_scroll_pixel_based)
1121 (window_scroll_line_based, Fset_window_configuration):
1122 * xdisp.c (redisplay_window): Do not reset last_modified and
1123 last_overlay_modified counters.
1124
1125 2013-08-07 Jan Djärv <jan.h.d@swipnet.se>
1126
1127 * xselect.c (x_send_client_event): Set send_event and serial, memset
1128 data.l as it might be bigger than data.b. Use 24 bit mask to
1129 XSendEvent (Bug#15034).
1130
1131 2013-08-07 Eli Zaretskii <eliz@gnu.org>
1132
1133 * xdisp.c (prepare_menu_bars): Don't call x_consider_frame_title
1134 for TTY frames that are not the top frame on their console.
1135 (Bug#14616)
1136
1137 2013-08-07 Martin Rudalics <rudalics@gmx.at>
1138
1139 * w32term.c (w32fullscreen_hook): Really maximize frame when
1140 asked for (Bug#14841).
1141
1142 2013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
1143
1144 Prefer selected_window to Fselected_window, likewise for frames.
1145 * buffer.c (Fbuffer_swap_text):
1146 * data.c (Fvariable_binding_locus):
1147 * window.c (run_window_configuration_change_hook): Adjust users.
1148 * w16select.c (Fw16_set_clipboard_data, Fw16_get_clipboard_data):
1149 Use decode_live_frame.
1150
1151 2013-08-07 Dmitry Antipov <dmantipov@yandex.ru>
1152
1153 Be more careful if selected window shows the buffer other than current,
1154 use window_outdated only if this is not so. This change should also
1155 address some weird issues discussed in Bug#13012.
1156 * window.h (window_outdated): New prototype.
1157 * window.c (window_outdated): Now here. Convert from static and
1158 always assume window's buffer.
1159 (Fwindow_end, Fwindow_line_height): Use it.
1160 * xdisp.c (reconsider_clip_changes): Remove prototype, drop 2nd arg
1161 and always assume window's buffer.
1162 (redisplay_window): Adjust user.
1163 (redisplay_internal): Call to reconsider_clip_changes once and
1164 check whether mode line should be updated only if selected window
1165 shows current buffer.
1166 (run_window_scroll_functions): Use eassert for debugging check.
1167 (Fmove_point_visually, note_mouse_highlight): Use window_outdated.
1168
1169 2013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
1170
1171 * window.c (window_scroll, window_scroll_pixel_based)
1172 (window_scroll_line_based): Use bool for booleans.
1173
1174 2013-08-06 Paul Eggert <eggert@cs.ucla.edu>
1175
1176 * process.c: Fix minor off-by-one issues in descriptor counts.
1177 This shouldn't fix any real bugs, but it cleans up the code a bit.
1178 (max_process_desc, max_input_desc): -1, not 0, means none.
1179 All uses changed.
1180 (delete_input_desc): New function.
1181 (delete_write_fd, delete_keyboard_wait_descriptor): Use it.
1182 (deactivate_process): Scan backwards when recomuting max_process_desc;
1183 that should be faster.
1184 (init_process_emacs): Initialize max_input_desc.
1185
1186 2013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
1187
1188 Use region cache to speedup bidi_find_paragraph_start.
1189 * buffer.h (struct buffer): New member bidi_paragraph_cache.
1190 Rename cache_long_line_scans to cache_long_scans.
1191 * buffer.c (bset_cache_long_line_scans): Rename to
1192 bset_cache_long_scans.
1193 (Fget_buffer_create, Fmake_indirect_buffer, Fkill_buffer)
1194 (Fbuffer_swap_text, init_buffer_once): Take bidi_paragraph_cache
1195 into account.
1196 (syms_of_buffer): Rename cache-long-line-scans to
1197 cache-long-scans. Adjust docstring.
1198 * search.c (newline_cache_on_off):
1199 * indent.c (width_run_cache_on_off): Adjust users.
1200 * bidi.c (bidi_paragraph_cache_on_off): New function.
1201 (bidi_find_paragraph_start): Use bidi_paragraph_cache if needed.
1202 * insdel.c (prepare_to_modify_buffer):
1203 Invalidate bidi_paragraph_cache if enabled.
1204
1205 2013-08-06 Dmitry Antipov <dmantipov@yandex.ru>
1206
1207 Invalidate region caches only if buffer text is going to be changed.
1208 * lisp.h (modify_region_1): Remove 3rd arg and rename to...
1209 (modify_text): ...new prototype.
1210 (prepare_to_modify_buffer_1): New prototype.
1211 * textprop.c (modify_region): Rename to...
1212 (modify_text_properties): ...new function.
1213 (add_text_properties_1, set_text_properties, Fremove_text_properties)
1214 (Fremove_list_of_text_properties): Adjust users.
1215 * insdel.c (modify_region_1): Remove 3rd arg and reimplement as...
1216 (modify_text): ...new function.
1217 (prepare_to_modify_buffer): Reimplement mostly as a wrapper for...
1218 (prepare_to_modify_buffer_1): ...new function.
1219 * casefiddle.c (casify_region):
1220 * editfns.c (Fsubst_char_in_region, Ftranslate_region_internal)
1221 (Ftranspose_regions): Use modify_text.
1222
1223 2013-08-05 Stefan Monnier <monnier@iro.umontreal.ca>
1224
1225 * lisp.mk (lisp): Add nadvice.elc.
1226
1227 2013-08-05 Dmitry Antipov <dmantipov@yandex.ru>
1228
1229 New macro to iterate over live buffers similar to frames.
1230 * buffer.h (FOR_EACH_LIVE_BUFFER): New macro.
1231 (Vbuffer_alist, Qpriority, Qbefore_string, Qafter_string):
1232 Declare buffer-related variables here to offload lisp.h.
1233 * buffer.c (Vbuffer_alist): Adjust comment.
1234 (Fget_file_buffer, get_truename_buffer, Fother_buffer)
1235 (other_buffer_safely):
1236 * data.c (store_symval_forwarding):
1237 * dispnew.c (Fframe_or_buffer_changed_p):
1238 * fileio.c (Fdo_auto_save):
1239 * filelock.c (unlock_all_files):
1240 * minibuf.c (read_minibuf): Use FOR_EACH_LIVE_BUFFER.
1241
1242 2013-08-04 Paul Eggert <eggert@cs.ucla.edu>
1243
1244 Fix some minor races in hosts lacking mkostemp (Bug#15015).
1245 * callproc.c (create_temp_file):
1246 * filelock.c (create_lock_file):
1247 Assume mkostemp, since it's now provided by Gnulib.
1248
1249 2013-08-04 Eli Zaretskii <eliz@gnu.org>
1250
1251 * w32.c (mkostemp): New function.
1252 (mktemp): Remove, no longer used. Most of the code reused in
1253 mkostemp. (Bug#15015)
1254 (mktemp): Don't undef.
1255
1256 2013-08-04 Dmitry Antipov <dmantipov@yandex.ru>
1257
1258 * dispnew.c (glyph_matrix_count, glyph_pool_count):
1259 Move under GLYPH_DEBUG and ENABLE_CHECKING.
1260 (new_glyph_matrix, free_glyph_matrix, new_glyph_pool)
1261 (free_glyph_pool, check_glyph_memory): Likewise for
1262 all users. Adjust comments where appropriate.
1263
1264 2013-08-03 Paul Eggert <eggert@cs.ucla.edu>
1265
1266 * composite.h: Minor fixups.
1267 (composition_registered_p): Rename from COMPOSITION_REGISTERD_P
1268 to fix a misspelling, and change it to an inline function while
1269 we're at it (it need not be a macro). All uses changed.
1270 (composition_method, composition_valid_p):
1271 Rewrite to avoid assignments in if-conditions.
1272
1273 2013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
1274
1275 Do not use global Lisp_Object in composition macros.
1276 * composite.h (composition_temp): Remove declaration.
1277 (COMPOSITION_METHOD, COMPOSITION_VALID_P): Replace with...
1278 (composition_method, composition_valid_p): ...inline functions.
1279 (compose_region): Remove the leftover.
1280 * composite.c (composition_temp): Remove.
1281 (run_composition_function, update_compositions)
1282 (composition_compute_stop_pos, composition_adjust_point)
1283 (Ffind_composition_internal):
1284 * coding.c (handle_composition_annotation):
1285 * xdisp.c (handle_composition_prop, check_point_in_composition):
1286 Related users changed.
1287
1288 2013-08-03 Dmitry Antipov <dmantipov@yandex.ru>
1289
1290 Drop FRAME_PTR typedef.
1291 * composite.c, font.c, font.h, fontset.c, fontset.h, frame.c, frame.h:
1292 * ftfont.c, ftxfont.c, gtkutil.c, gtkutil.h, image.c, keyboard.c:
1293 * menu.c, menu.h, msdos.c, nsfns.m, nsfont.m, nsmenu.m, nsterm.h:
1294 * nsterm.m, scroll.c, term.c, w32fns.c, w32font.c, w32font.h:
1295 * w32inevt.c, w32inevt.h, w32menu.c, w32notify.c, w32term.c, w32term.h:
1296 * w32uniscribe.c, w32xfns.c, widget.c, window.c, xdisp.c, xfaces.c:
1297 * xfns.c, xfont.c, xftfont.c, xmenu.c, xselect.c, xterm.c:
1298 All related users changed.
1299
1300 2013-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1301
1302 * eval.c (default_toplevel_binding): New function.
1303 (Fdefvar): Use it.
1304 (unbind_to, backtrace_eval_unrewind): Do a bit of CSE simplification.
1305 (Fdefault_toplevel_value, Fset_default_toplevel_value): New subrs.
1306 (syms_of_eval): Export them.
1307 * data.c (Fdefault_value): Micro cleanup.
1308 * term.c (init_tty): Use "false".
1309
1310 2013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
1311
1312 Fix X GC leak in GTK and raw (no toolkit) X ports.
1313 * xterm.c (x_free_frame_resources): If white and black relief
1314 GCs are allocated, always free them here.
1315 * xfns.c (x_make_gc): Omit redundant initialization.
1316 * widget.c (create_frame_gcs): Remove the leftover.
1317 (EmacsFrameDestroy): Do nothing because all GCs are now freed
1318 in x_free_frame_resources.
1319
1320 2013-08-02 Jan Djärv <jan.h.d@swipnet.se>
1321
1322 * nsterm.m (windowWillResize:toSize:): Only change title if
1323 ! maximizing_resize && FULLSCREEN_NONE (Bug#15005). strdup title before
1324 modifying it.
1325 (viewDidEndLiveResize): New method.
1326
1327 * nsterm.h (EmacsView): Add maximizing_resize, put it and old_title
1328 inside NS_IMPL_COCOA.
1329
1330 2013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
1331
1332 * insdel.c (adjust_after_replace, replace_range, del_range_2):
1333 Do not check whether undo is enabled because record_insert and
1334 record_delete does that themselves.
1335
1336 2013-08-02 Dmitry Antipov <dmantipov@yandex.ru>
1337
1338 * xterm.h (struct x_output) [HAVE_X_I18N]: Remove xic_base_fontname
1339 member which is not really used any more.
1340 (FRAME_XIC_BASE_FONTNAME): Remove.
1341 * xfns.c (xic_free_fontset): Adjust user.
1342 * xmenu.c (mouse_position_for_popup, x_activate_menubar)
1343 (update_frame_menubar, set_frame_menubar, free_frame_menubar)
1344 (create_and_show_popup_menu, xmenu_show, create_and_show_dialog)
1345 (xdialog_show): Use eassert for debugging check.
1346 * w32term.c (x_unfocus_frame): Remove unused dummy function.
1347
1348 2013-08-01 Paul Eggert <eggert@cs.ucla.edu>
1349
1350 * fileio.c, fns.c (merge): Move extern decl from here ...
1351 * lisp.h (merge): ... to here.
1352
1353 2013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1354
1355 Fix last font-related change.
1356 * w32font.h (w32font_list_internal, w32font_match_internal):
1357 Fix prototype.
1358 * w32uniscribe.c (uniscribe_list, uniscribe_match):
1359 (uniscribe_list_family): Adjust to match font API change.
1360 MS-Windows breakage reported by Juanma Barranquero <lekktu@gmail.com>
1361 at http://lists.gnu.org/archive/html/emacs-devel/2013-08/msg00006.html.
1362
1363 2013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1364
1365 * frame.h (FRAME_MOUSE_UPDATE):
1366 * nsterm.m (ns_frame_up_to_date): Omit redundant check
1367 whether hlinfo->mouse_face_mouse_frame is non-NULL.
1368
1369 2013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1370
1371 Avoid redundant Lisp_Object <-> struct frame conversions in font API.
1372 * font.h (struct font_driver): Change list, match, and list_family
1373 functions to accept struct frame * as first arg.
1374 * font.c (font_score, font_compare, font_sort_entities):
1375 Remove prototypes.
1376 (font_sort_entities, font_list_entities, font_select_entity):
1377 (font_find_for_lface, Flist_fonts, Ffont_family_list): Adjust to
1378 match font API change.
1379 * xfont.c (xfont_list, xfont_match, xfont_list_family):
1380 * ftfont.c (ftfont_list, ftfont_match, ftfont_list_family):
1381 * ftxfont.c (ftxfont_list, ftxfont_match):
1382 * xftfont.c (xftfont_list, xftfont_match):
1383 * nsfont.m (nsfont_list, nsfont_match, nsfont_list_family):
1384 * w32font.c (w32font_list, w32font_match, w32font_list):
1385 (w32font_list_internal, w32_font_match_internal): Likewise.
1386 * xfaces.c (Fx_family_fonts): Adjust user.
1387
1388 2013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1389
1390 Do not use pure Xism x_wm_set_icon_position in non-X ports.
1391 * frame.c (x_set_frame_parameters): Call to x_wm_set_icon_position
1392 only if HAVE_X_WINDOWS is in use.
1393 * frame.h (x_set_frame_parameters): Move under HAVE_X_WINDOWS.
1394 * nsterm.m (x_wm_set_icon_position): Remove no-op.
1395 * w32term.c (x_wm_set_icon_position): Likewise.
1396 * w32fns.c (x_icon): Adjust user.
1397
1398 2013-08-01 Dmitry Antipov <dmantipov@yandex.ru>
1399
1400 * xterm.c (last_mouse_press_frame): Remove the
1401 leftover which is not really used any more.
1402 (handle_one_xevent, syms_of_xterm): Adjust users.
1403 (x_flush): Call XFlush once per each X display, not frame.
1404 This is better because this code always unconditionally skips
1405 non-X frames in Vframe_list and issues the only XFlush if we
1406 have more than one X frame on the same X display.
1407 (any_help_event_p, x_draw_glyph_string_background, x_display_ok):
1408 Use bool for booleans.
1409 (x_draw_glyph_string_background, cvt_string_to_pixel):
1410 (cvt_pixel_dtor): Drop unnecessary prototypes.
1411 * xterm.h (x_display_ok): Adjust prototype.
1412
1413 2013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
1414
1415 Drop unnecessary functions that deals with frame pixel size.
1416 * frame.h, msdos.h, w32term.h, xterm.h (x_pixel_width)
1417 (x_pixel_height): Drop prototypes.
1418 * msdos.c, nsfns.m, w32fns.c, xfns.c (x_pixel_width)
1419 (x_pixel_height): Drop implementations.
1420 * frame.c (Fframe_pixel_height): Use FRAME_PIXEL_HEIGHT
1421 which should be always valid for window frame.
1422 (Frame_pixel_width): Likewise with FRAME_PIXEL_WIDTH.
1423 * w32menu.c (Fx_popup_dialog):
1424 * xmenu.c (Fx_popup_dialog): Likewise for both.
1425
1426 2013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
1427
1428 * frame.c (Fmake_terminal_frame): Use store_in_alist to setup
1429 frame parameters and call to Fmodify_frame_parameters just once.
1430 (Fset_frame_height, Fset_frame_width): Mention nil frame in docstring.
1431 (Fset_frame_size, Fset_frame_position): Use decode_live_frame
1432 and mention nil frame in docstring.
1433
1434 2013-07-31 Dmitry Antipov <dmantipov@yandex.ru>
1435
1436 * frame.c (make_frame, x_set_frame_parameters): Use bool for boolean.
1437 (x_figure_window_size): Likewise. Adjust to return long.
1438 (syms_of_frame): Do not DEFSYM Qterminal_live_p.
1439 (toplevel): Move Qterminal_live_p to...
1440 * terminal.c (toplevel): ...here, make it static, and...
1441 (syms_of_terminal): ...DEFSYM here.
1442 * frame.h (Qterminal_live_p): Remove declaration.
1443 (make_frame, x_figure_window_size): Adjust prototype.
1444 * nsfns.m (Fx_create_frame): Use long for window flags.
1445
1446 2013-07-30 Paul Eggert <eggert@cs.ucla.edu>
1447
1448 Fix tempfile bug on platforms lacking mkostemp and mkstemp (Bug#14986).
1449 * callproc.c (create_temp_file) [! (HAVE_MKOSTEMP || HAVE_MKSTEMP)]:
1450 Do not assume that emacs_close (INT_MAX) is a no-op.
1451
1452 2013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
1453
1454 * xfaces.c (make_face_cache): For struct face_cache, prefer
1455 xmalloc to xzalloc and so avoid redundant call to memset.
1456 (Finternal_set_lisp_face_attribute): Fix comment typo and style.
1457
1458 2013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
1459
1460 * fringe.c (draw_window_fringes, update_window_fringes)
1461 (compute_fringe_widths):
1462 * w32term.c (x_draw_glyph_string):
1463 * window.c (candidate_window_p, Frecenter):
1464 * xfaces.c (realize_basic_faces, realize_default_face)
1465 (Fbitmap_space_p, Finternal_set_lisp_face_attribute)
1466 (x_update_menu_appearance, face_attr_equal_p, lface_equal_p):
1467 * xfns.c (x_set_cursor_color, xic_free_xfontset):
1468 * xmenu.c (Fx_menu_bar_open_internal):
1469 * xselect.c (x_reply_selection_request, Fx_get_atom_name):
1470 * xsettings.c (xft_settings_event):
1471 * xterm.c (x_draw_glyph_string, x_had_errors_p):
1472 Use bool for booleans. Adjust style and comments where
1473 appropriate.
1474 * dispextern.h (draw_window_fringes, update_window_fringes)
1475 (compute_fringe_widths):
1476 * xterm.h (x_had_errors_p): Adjust prototype.
1477
1478 2013-07-30 Dmitry Antipov <dmantipov@yandex.ru>
1479
1480 * frame.c (Fmodify_frame_parameters): Always check 2nd arg with
1481 CHECK_LIST. Rewrite the loop to avoid useless local variable.
1482
1483 2013-07-29 Dmitry Antipov <dmantipov@yandex.ru>
1484
1485 * fns.c (toplevel): Remove comment before Fsafe_length because
1486 it checks for QUIT.
1487
1488 2013-07-28 Paul Eggert <eggert@cs.ucla.edu>
1489
1490 * frame.c (delete_frame): Avoid unnecessary 'this_f' test (Bug#14970).
1491
1492 2013-07-28 Eli Zaretskii <eliz@gnu.org>
1493
1494 * w32fns.c (w32_wnd_proc) <WM_IME_STARTCOMPOSITION>: Make sure the
1495 frame which got the message is still alive, before dereferencing
1496 its pointer. (Bug#14970)
1497
1498 * frame.c (delete_frame): Test "this" frame's minibuffer window to
1499 be a live window, before using it as such. (Bug#14970)
1500
1501 2013-07-27 Eli Zaretskii <eliz@gnu.org>
1502
1503 * w32term.c (w32_read_socket) <WM_KILLFOCUS>: Call
1504 w32_detect_focus_change instead of doing part of its job by hand.
1505 This fixes the problem whereby FOCUS_OUT events were not sent to
1506 the event queue.
1507
1508 2013-07-26 Eli Zaretskii <eliz@gnu.org>
1509
1510 * process.c (Fprocess_list): Doc fix.
1511
1512 * w32term.c (w32_read_socket) <WM_EMACS_PAINT>: Warn about frame
1513 being re-exposed only if it didn't ask to become visible.
1514 <WM_SIZE>: Under SIZE_RESTORED, only set the frame visible if it
1515 was previously iconified. (Bug#14841)
1516 (x_iconify_frame): Mark the frame iconified.
1517
1518 2013-07-26 Paul Eggert <eggert@cs.ucla.edu>
1519
1520 Fix minor problems found by static checking.
1521 * eval.c (get_backtrace_frame, backtrace_eval_unrewind): Now static.
1522 (backtrace_eval_unrewind): ';' -> '{}' to pacify GCC.
1523
1524 2013-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
1525
1526 * eval.c (set_specpdl_old_value): New function.
1527 (unbind_to): Minor simplification.
1528 (get_backtrace_frame): New function.
1529 (Fbacktrace_frame): Use it. Add `base' argument.
1530 (backtrace_eval_unrewind, Fbacktrace_eval): New functions.
1531 (syms_of_eval): Export backtrace-eval.
1532 * xterm.c (x_focus_changed): Simplify.
1533
1534 2013-07-25 Paul Eggert <eggert@cs.ucla.edu>
1535
1536 * fileio.c (Finsert_file_contents): Avoid double-close (Bug#14936).
1537
1538 2013-07-24 Eli Zaretskii <eliz@gnu.org>
1539
1540 * xdisp.c (redisplay_window): Instead of moving point out of
1541 scroll margin, reject the force_start method, and try scrolling
1542 instead. (Bug#14780)
1543
1544 2013-07-24 Ken Brown <kbrown@cornell.edu>
1545
1546 * alloc.c (make_save_ptr): Define if HAVE_NTGUI is defined
1547 (Bug#14944).
1548
1549 2013-07-24 Paul Eggert <eggert@cs.ucla.edu>
1550
1551 * eval.c (Fprogn): Do not check that BODY is a proper list.
1552 This undoes the previous change. The check slows down the
1553 interpreter, and is not needed to prevent a crash. See
1554 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00693.html>.
1555
1556 2013-07-23 Glenn Morris <rgm@gnu.org>
1557
1558 * Makefile.in ($(etc)/DOC, temacs$(EXEEXT)): Ensure etc/ exists.
1559
1560 2013-07-23 Paul Eggert <eggert@cs.ucla.edu>
1561
1562 Port to GNU/Linux systems with tinfo but not ncurses.
1563 * dispnew.c (init_display): Depend on USE_NCURSES, not GNU_LINUX,
1564 to decide whether ncurses is being used. Without this change,
1565 GCC complains about tgetent not being declared, on a system
1566 that has tinfo installed but ncurses not installed.
1567
1568 * eval.c (Fprogn): Check that BODY is a proper list.
1569
1570 Tune UNEVALLED functions by using XCAR instead of Fcar, etc.
1571 * data.c (Fsetq_default):
1572 * eval.c (Fif, Fcond, Fprog1, Fsetq, Fquote, Ffunction, Fdefvar)
1573 (Fdefconst, FletX, Flet, Fwhile, Fcatch, Funwind_protect)
1574 (Fcondition_case):
1575 Tune by taking advantage of the fact that ARGS is always a list
1576 when a function is declared to have UNEVALLED args.
1577
1578 * emacsgtkfixed.c: Port to GCC 4.6.
1579 GCC 4.6 complains about -Wunused-local-typedefs, introduced in 4.7.
1580
1581 2013-07-23 Juanma Barranquero <lekktu@gmail.com>
1582
1583 * callproc.c (child_setup)[!WINDOWSNT]: Move exec_errno and pid
1584 here to silence compiler warnings.
1585
1586 2013-07-22 Paul Eggert <eggert@cs.ucla.edu>
1587
1588 * sysdep.c (frame) [__FreeBSD__]: #define to freebsd_frame
1589 when including <sys/user.h>, to prevent Sparc/ARM machine/frame.h
1590 from messing up Emacs's 'struct frame' (Bug#14923).
1591
1592 2013-07-21 Paul Eggert <eggert@cs.ucla.edu>
1593
1594 * alloc.c (make_save_ptr_ptr): Define this function.
1595 It was inadvertently omitted. It's needed only if
1596 HAVE_MENUS && ! (USE_X_TOOLKIT || USE_GTK).
1597
1598 2013-07-21 Jan Djärv <jan.h.d@swipnet.se>
1599
1600 * nsterm.m (sendEvent:): Skip mouse moved if no dialog and no Emacs
1601 frame have focus (Bug#14895).
1602
1603 2013-07-21 Paul Eggert <eggert@cs.ucla.edu>
1604
1605 Avoid vfork-related deadlock more cleanly.
1606 * callproc.c (child_setup): When the child's exec fails, output
1607 the program name, as that's more useful. Use O_NONBLOCK to avoid
1608 deadlock.
1609 * process.c (create_process_1): Remove; no longer needed.
1610 (create_process): Remove timer hack; no longer needed, now that
1611 the child avoids deadlock.
1612
1613 2013-07-20 Glenn Morris <rgm@gnu.org>
1614
1615 * image.c (Fimage_flush): Fix doc typo.
1616
1617 2013-07-20 Paul Eggert <eggert@cs.ucla.edu>
1618
1619 Fix array bounds violation when pty allocation fails.
1620 * process.c (PTY_NAME_SIZE): New constant.
1621 (pty_name): Remove static variable; it's now auto.
1622 (allocate_pty): Define even if !HAVE_PTYS; that's simpler.
1623 Take pty_name as an arg rather than using a static variable.
1624 All callers changed.
1625 (create_process): Recover pty_flag from process, not from volatile local.
1626 (create_pty): Stay inside array even when pty allocation fails.
1627 (Fmake_serial_process): Omit unnecessary initializaiton of pty_flag.
1628
1629 * lread.c (Fload): Avoid initialization only when lint checking.
1630 Mention that it's needed only for older GCCs.
1631
1632 2013-07-20 Kenichi Handa <handa@gnu.org>
1633
1634 * coding.c (CODING_ISO_FLAG_LEVEL_4): New macro.
1635 (decode_coding_iso_2022): Check the single-shift area. (Bug#8522)
1636
1637 2013-07-20 Andreas Schwab <schwab@linux-m68k.org>
1638
1639 * lread.c (Fload): Avoid uninitialized warning.
1640
1641 2013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1642
1643 Fix some minor file descriptor leaks and related glitches.
1644 * filelock.c (create_lock_file) [!O_CLOEXEC]: Use fcntl with FD_CLOEXEC.
1645 (create_lock_file): Use write, not emacs_write.
1646 * image.c (slurp_file, png_load_body):
1647 * process.c (Fnetwork_interface_list, Fnetwork_interface_info)
1648 (server_accept_connection):
1649 Don't leak an fd on memory allocation failure.
1650 * image.c (slurp_file): Add a cheap heuristic for growing files.
1651 * xfaces.c (Fx_load_color_file): Block input around the fopen too,
1652 as that's what the other routines do. Maybe input need not be
1653 blocked at all, but it's better to be consistent.
1654 Avoid undefined behavior when strlen is zero.
1655
1656 * alloc.c (staticpro): Avoid buffer overrun on repeated calls.
1657 (NSTATICS): Now a constant; doesn't need to be a macro.
1658
1659 2013-07-19 Richard Stallman <rms@gnu.org>
1660
1661 * coding.c (decode_coding_utf_8): Add simple loop for fast
1662 processing of ASCII characters.
1663
1664 2013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1665
1666 * conf_post.h (RE_TRANSLATE_P) [emacs]: Remove obsolete optimization.
1667
1668 2013-07-19 Eli Zaretskii <eliz@gnu.org>
1669
1670 * keyboard.c (kbd_buffer_get_event): Use Display_Info instead of
1671 unportable 'struct x_display_info'.
1672 (DISPLAY_LIST_INFO): Delete macro: not needed, since Display_Info
1673 is a portable type.
1674
1675 2013-07-19 Paul Eggert <eggert@cs.ucla.edu>
1676
1677 * sysdep.c [GNU_LINUX]: Fix fd and memory leaks and similar issues.
1678 (procfs_ttyname): Don't use uninitialized storage if emacs_fopen
1679 or fscanf fails.
1680 (system_process_attributes): Prefer plain char to unsigned char
1681 when either will do. Clean up properly if interrupted or if
1682 memory allocations fail. Don't assume sscanf succeeds.
1683 Remove no-longer-needed workaround to stop GCC from whining.
1684 Read command-line once, instead of multiple times. Check read status a
1685 bit more carefully.
1686
1687 Fix obscure porting bug with varargs functions.
1688 The code assumed that int is treated like ptrdiff_t in a vararg
1689 function, which is not a portable assumption. There was a similar
1690 -- though these days less likely -- porting problem with various
1691 assumptions that pointers of different types all smell the same as
1692 far as vararg functions is conserved. To make this problem less
1693 likely in the future, redo the API to use varargs functions.
1694 * alloc.c (make_save_value): Remove this vararg function.
1695 All uses changed to ...
1696 (make_save_int_int_int, make_save_obj_obj_obj_obj)
1697 (make_save_ptr_int, make_save_funcptr_ptr_obj, make_save_memory):
1698 New functions.
1699 (make_save_ptr): Rename from make_save_pointer, for consistency with
1700 the above. Define only on platforms that need it. All uses changed.
1701
1702 2013-07-18 Paul Eggert <eggert@cs.ucla.edu>
1703
1704 * keyboard.c: Try to fix typos in previous change.
1705 (DISPLAY_LIST_INFO): New macro.
1706 (kbd_buffer_get_event): Do not access members that are not present
1707 in X11. Revert inadvertent change of "!=" to "=".
1708
1709 2013-07-18 Juanma Barranquero <lekktu@gmail.com>
1710
1711 * keyboard.c (kbd_buffer_get_event):
1712 * w32term.c (x_focus_changed): Port FOCUS_(IN|OUT)_EVENT changes to W32.
1713 Followup to 2013-07-16T11:41:06Z!jan.h.d@swipnet.se.
1714
1715 2013-07-18 Paul Eggert <eggert@cs.ucla.edu>
1716
1717 * filelock.c: Fix unlikely file descriptor leaks.
1718 (get_boot_time_1): Rework to avoid using emacs_open.
1719 This doesn't actually fix a leak, but is better anyway.
1720 (read_lock_data): Use read, not emacs_read.
1721
1722 * doc.c: Fix minor memory and file descriptor leaks.
1723 * doc.c (get_doc_string): Fix memory leak when doc file absent.
1724 (get_doc_string, Fsnarf_documentation):
1725 Fix file descriptor leak on error.
1726
1727 * term.c: Fix minor fdopen-related file descriptor leaks.
1728 * term.c (Fresume_tty) [!MSDOS]: Close fd if fdopen (fd) fails.
1729 (init_tty) [!DOS_NT]: Likewise. Also close fd if isatty (fd) fails.
1730
1731 * charset.c: Fix file descriptor leaks and errno issues.
1732 Include <errno.h>.
1733 (load_charset_map_from_file): Don't leak file descriptor on error.
1734 Use plain record_xmalloc since the allocation is larger than
1735 MAX_ALLOCA; that's simpler here. Simplify test for exhaustion
1736 of entries.
1737 * eval.c (record_unwind_protect_nothing):
1738 * fileio.c (fclose_unwind):
1739 New functions.
1740 * lread.c (load_unwind): Remove. All uses replaced by fclose_unwind.
1741 The replacement doesn't block input, but that no longer seems
1742 necessary.
1743
1744 2013-07-17 Paul Eggert <eggert@cs.ucla.edu>
1745
1746 * lread.c: Fix file descriptor leaks and errno issues.
1747 (Fload): Close some races that leaked fds or streams when 'load'
1748 was interrupted.
1749 (Fload, openp): Report error number of last nontrivial failure to open.
1750 ENOENT counts as trivial.
1751 * eval.c (do_nothing, clear_unwind_protect, set_unwind_protect_ptr):
1752 New functions.
1753 * fileio.c (close_file_unwind): No need to test whether FD is nonnegative,
1754 now that the function is always called with a nonnegative arg.
1755 * lisp.h (set_unwind_protect_ptr, set_unwind_protect_int): Remove.
1756 All uses replaced with ...
1757 (clear_unwind_protect, set_unwind_protect_ptr): New decls.
1758
1759 A few more minor file errno-reporting bugs.
1760 * callproc.c (Fcall_process):
1761 * doc.c (Fsnarf_documentation):
1762 * fileio.c (Frename_file, Fadd_name_to_file, Fmake_symbolic_link):
1763 * process.c (set_socket_option):
1764 Don't let a constructor trash errno.
1765 * doc.c: Include <errno.h>.
1766
1767 2013-07-16 Juanma Barranquero <lekktu@gmail.com>
1768
1769 * w32fns.c (unwind_create_tip_frame): Fix declaration.
1770
1771 2013-07-16 Paul Eggert <eggert@cs.ucla.edu>
1772
1773 Fix w32 bug with call-process-region (Bug#14885).
1774 * callproc.c (Fcall_process_region): Pass nil, not "/dev/null",
1775 to Fcall_process when the input is empty. This simplifies the
1776 code a bit. It makes no difference on POSIXish platforms but
1777 apparently it fixes a bug on w32.
1778
1779 Fix bug where insert-file-contents closes a file twice (Bug#14839).
1780 * fileio.c (close_file_unwind): Don't close if FD is negative;
1781 this can happen when unwinding a zapped file descriptor.
1782 (Finsert_file_contents): Unwind-protect the fd before the point marker,
1783 in case Emacs runs out of memory between the two unwind-protects.
1784 Don't trash errno when closing FD.
1785 Zap the FD in the specpdl when closing it, instead of deferring
1786 the removal of the unwind-protect; this fixes a bug where a child
1787 function unwinds the stack past us.
1788
1789 New unwind-protect flavors to better type-check C callbacks.
1790 This also lessens the need to write wrappers for callbacks,
1791 and the need for make_save_pointer.
1792 * alloca.c (free_save_value):
1793 * atimer.c (run_all_atimers):
1794 Now extern.
1795 * alloc.c (safe_alloca_unwind):
1796 * atimer.c (unwind_stop_other_atimers):
1797 * keyboard.c (cancel_hourglass_unwind) [HAVE_WINDOW_SYSTEM]:
1798 * menu.c (cleanup_popup_menu) [HAVE_NS]:
1799 * minibuf.c (choose_minibuf_frame_1):
1800 * process.c (make_serial_process_unwind):
1801 * xdisp.h (pop_message_unwind):
1802 * xselect.c (queue_selection_requests_unwind):
1803 Remove no-longer-needed wrapper. All uses replaced by the wrappee.
1804 * alloca.c (record_xmalloc):
1805 Prefer record_unwind_protect_ptr to record_unwind_protect with
1806 make_save_pointer.
1807 * alloca.c (Fgarbage_collect):
1808 Prefer record_unwind_protect_void to passing a dummy.
1809 * buffer.c (restore_buffer):
1810 * window.c (restore_window_configuration):
1811 * xfns.c, w32fns.c (do_unwind_create_frame)
1812 New wrapper. All record-unwind uses of wrappee changed.
1813 * buffer.c (set_buffer_if_live):
1814 * callproc.c (call_process_cleanup, delete_temp_file):
1815 * coding.c (code_conversion_restore):
1816 * dired.c (directory_files_internal_w32_unwind) [WINDOWSNT]:
1817 * editfns.c (save_excursion_restore)
1818 (subst_char_in_region_unwind, subst_char_in_region_unwind_1)
1819 (save_restriction_restore):
1820 * eval.c (restore_stack_limits, un_autoload):
1821 * fns.c (require_unwind):
1822 * keyboard.c (recursive_edit_unwind, tracking_off):
1823 * lread.c (record_load_unwind, load_warn_old_style_backquotes):
1824 * macros.c (pop_kbd_macro, restore_menu_items):
1825 * nsfns.m (unwind_create_frame):
1826 * print.c (print_unwind):
1827 * process.c (start_process_unwind):
1828 * search.c (unwind_set_match_data):
1829 * window.c (select_window_norecord, select_frame_norecord):
1830 * xdisp.c (unwind_with_echo_area_buffer, unwind_format_mode_line)
1831 (fast_set_selected_frame):
1832 * xfns.c, w32fns.c (unwind_create_tip_frame):
1833 Return void, not a dummy Lisp_Object. All uses changed.
1834 * buffer.h (set_buffer_if_live): Move decl here from lisp.h.
1835 * callproc.c (call_process_kill):
1836 * fileio.c (restore_point_unwind, decide_coding_unwind)
1837 (build_annotations_unwind):
1838 * insdel.c (Fcombine_after_change_execute_1):
1839 * keyboard.c (read_char_help_form_unwind):
1840 * menu.c (unuse_menu_items):
1841 * minibuf.c (run_exit_minibuf_hook, read_minibuf_unwind):
1842 * sound.c (sound_cleanup):
1843 * xdisp.c (unwind_redisplay):
1844 * xfns.c (clean_up_dialog):
1845 * xselect.c (x_selection_request_lisp_error, x_catch_errors_unwind):
1846 Accept no args and return void, instead of accepting and returning
1847 a dummy Lisp_Object. All uses changed.
1848 * cygw32.c (fchdir_unwind):
1849 * fileio.c (close_file_unwind):
1850 * keyboard.c (restore_kboard_configuration):
1851 * lread.c (readevalllop_1):
1852 * process.c (wait_reading_process_output_unwind):
1853 Accept int and return void, rather than accepting an Emacs integer
1854 and returning a dummy object. In some cases this fixes an
1855 unlikely bug when the corresponding int is outside Emacs integer
1856 range. All uses changed.
1857 * dired.c (directory_files_internal_unwind):
1858 * fileio.c (do_auto_save_unwind):
1859 * gtkutil.c (pop_down_dialog):
1860 * insdel.c (reset_var_on_error):
1861 * lread.c (load_unwind):
1862 * xfns.c (clean_up_file_dialog):
1863 * xmenu.c, nsmenu.m (pop_down_menu):
1864 * xmenu.c (cleanup_widget_value_tree):
1865 * xselect.c (wait_for_property_change_unwind):
1866 Accept pointer and return void, rather than accepting an Emacs
1867 save value encapsulating the pointer and returning a dummy object.
1868 All uses changed.
1869 * editfns.c (Fformat): Update the saved pointer directly via
1870 set_unwind_protect_ptr rather than indirectly via make_save_pointer.
1871 * eval.c (specpdl_func): Remove. All uses replaced by definiens.
1872 (unwind_body): New function.
1873 (record_unwind_protect): First arg is now a function returning void,
1874 not a dummy Lisp_Object.
1875 (record_unwind_protect_ptr, record_unwind_protect_int)
1876 (record_unwind_protect_void): New functions.
1877 (unbind_to): Support SPECPDL_UNWIND_PTR etc.
1878 * fileio.c (struct auto_save_unwind): New type.
1879 (do_auto_save_unwind): Use it.
1880 (do_auto_save_unwind_1): Remove; subsumed by new do_auto_save_unwind.
1881 * insdel.c (struct rvoe_arg): New type.
1882 (reset_var_on_error): Use it.
1883 * lisp.h (SPECPDL_UNWIND_PTR, SPECPDL_UNWIND_INT, SPECPDL_UNWIND_VOID):
1884 New constants.
1885 (specbinding_func): Remove; there are now several such functions.
1886 (union specbinding): New members unwind_ptr, unwind_int, unwind_void.
1887 (set_unwind_protect_ptr): New function.
1888 * xselect.c: Remove unnecessary forward decls, to simplify maintenance.
1889
1890 Be simpler and more consistent about reporting I/O errors.
1891 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
1892 Say "Read error" and "Write error", rather than "I/O error", or
1893 "IO error reading", or "IO error writing", when a read or write
1894 error occurs.
1895 * process.c (Fmake_network_process, wait_reading_process_output)
1896 (send_process, Fprocess_send_eof, wait_reading_process_output):
1897 Capitalize diagnostics consistently. Put "failed foo" at the
1898 start of the diagnostic, so that we don't capitalize the
1899 function name "foo". Consistently say "failed" for such
1900 diagnostics.
1901 * sysdep.c, w32.c (serial_open): Now accepts Lisp string, not C string.
1902 All callers changed. This is so it can use report_file_error.
1903 * sysdep.c (serial_open, serial_configure): Capitalize I/O
1904 diagnostics consistently as above.
1905
1906 * fileio.c (report_file_errno): Fix errno reporting bug.
1907 If the file name is neither null nor a pair, package it up as a
1908 singleton list. All callers changed, both to this function and to
1909 report_file_error. This fixes a bug where the memory allocator
1910 invoked by list1 set errno so that the immediately following
1911 report_file_error reported the wrong errno value.
1912
1913 Fix minor problems found by --enable-gcc-warnings.
1914 * frame.c (Fhandle_focus_in, Fhandle_focus_out): Return a value.
1915 * keyboard.c (kbd_buffer_get_event): Remove unused local.
1916
1917 2013-07-16 Jan Djärv <jan.h.d@swipnet.se>
1918
1919 * xterm.c (x_focus_changed): Always generate FOCUS_IN_EVENT.
1920 Set event->arg to Qt if switch-event shall be generated.
1921 Generate FOCUS_OUT_EVENT for FocusOut if this is the focused frame.
1922
1923 * termhooks.h (enum event_kind): Add FOCUS_OUT_EVENT.
1924
1925 * nsterm.m (windowDidResignKey): If this is the focused frame, generate
1926 FOCUS_OUT_EVENT.
1927
1928 * keyboard.c (Qfocus_in, Qfocus_out): New static objects.
1929 (make_lispy_focus_in, make_lispy_focus_out): Declare and define.
1930 (kbd_buffer_get_event): For FOCUS_IN, make a focus_in event if no
1931 switch frame event is made. Check ! NILP (event->arg) if X11 (moved
1932 from xterm.c). Make focus_out event for FOCUS_OUT_EVENT if NS or X11
1933 and there is a focused frame.
1934 (head_table): Add focus-in and focus-out.
1935 (keys_of_keyboard): Add focus-in and focus-out to Vspecial_event_map,
1936 bind to handle-focus-in/out.
1937
1938 * frame.c (Fhandle_focus_in, Fhandle_focus_out): New functions.
1939 (Fhandle_switch_frame): Call Fhandle_focus_in.
1940 (syms_of_frame): defsubr handle-focus-in/out.
1941
1942 2013-07-16 Paul Eggert <eggert@cs.ucla.edu>
1943
1944 Fix porting bug to older POSIXish platforms (Bug#14862).
1945 * sysdep.c (emacs_pipe): New function, that implements
1946 pipe2 (fd, O_CLOEXEC) even on hosts that lack O_CLOEXEC.
1947 This should port better to CentOS 5 and to Mac OS X 10.6.
1948 All calls to pipe2 changed.
1949
1950 Prefer list1 (X) to Fcons (X, Qnil) when building lists.
1951 This makes the code easier to read and the executable a bit smaller.
1952 Do not replace all calls to Fcons that happen to create lists,
1953 just calls that are intended to create lists. For example, when
1954 creating an alist that maps FOO to nil, use list1 (Fcons (FOO, Qnil))
1955 rather than list1 (list1 (FOO)) or Fcons (Fcons (FOO, Qnil), Qnil).
1956 Similarly for list2 through list5.
1957 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1958 * bytecode.c (exec_byte_code):
1959 * callint.c (quotify_arg, Fcall_interactively):
1960 * callproc.c (Fcall_process, create_temp_file):
1961 * charset.c (load_charset_map_from_file)
1962 (Fdefine_charset_internal, init_charset):
1963 * coding.c (get_translation_table, detect_coding_system)
1964 (Fcheck_coding_systems_region)
1965 (Fset_terminal_coding_system_internal)
1966 (Fdefine_coding_system_internal, Fdefine_coding_system_alias):
1967 * composite.c (update_compositions, Ffind_composition_internal):
1968 * dired.c (directory_files_internal, file_name_completion)
1969 (Fsystem_users):
1970 * dispnew.c (Fopen_termscript, bitch_at_user, init_display):
1971 * doc.c (Fsnarf_documentation):
1972 * editfns.c (Fmessage_box):
1973 * emacs.c (main):
1974 * eval.c (do_debug_on_call, signal_error, maybe_call_debugger)
1975 (Feval, eval_sub, Ffuncall, apply_lambda):
1976 * fileio.c (make_temp_name, Fcopy_file, Faccess_file)
1977 (Fset_file_selinux_context, Fset_file_acl, Fset_file_modes)
1978 (Fset_file_times, Finsert_file_contents)
1979 (Fchoose_write_coding_system, Fwrite_region):
1980 * fns.c (Flax_plist_put, Fyes_or_no_p, syms_of_fns):
1981 * font.c (font_registry_charsets, font_parse_fcname)
1982 (font_prepare_cache, font_update_drivers, Flist_fonts):
1983 * fontset.c (Fset_fontset_font, Ffontset_info, syms_of_fontset):
1984 * frame.c (make_frame, Fmake_terminal_frame)
1985 (x_set_frame_parameters, x_report_frame_params)
1986 (x_default_parameter, Fx_parse_geometry):
1987 * ftfont.c (syms_of_ftfont):
1988 * image.c (gif_load):
1989 * keyboard.c (command_loop_1):
1990 * keymap.c (Fmake_keymap, Fmake_sparse_keymap, access_keymap_1)
1991 (Fcopy_keymap, append_key, Fcurrent_active_maps)
1992 (Fminor_mode_key_binding, accessible_keymaps_1)
1993 (Faccessible_keymaps, Fwhere_is_internal):
1994 * lread.c (read_emacs_mule_char):
1995 * menu.c (find_and_return_menu_selection):
1996 * minibuf.c (get_minibuffer):
1997 * nsfns.m (Fns_perform_service):
1998 * nsfont.m (ns_script_to_charset):
1999 * nsmenu.m (ns_popup_dialog):
2000 * nsselect.m (ns_get_local_selection, ns_string_from_pasteboard)
2001 (Fx_own_selection_internal):
2002 * nsterm.m (append2):
2003 * print.c (Fredirect_debugging_output)
2004 (print_prune_string_charset):
2005 * process.c (Fdelete_process, Fprocess_contact)
2006 (Fformat_network_address, set_socket_option)
2007 (read_and_dispose_of_process_output, write_queue_push)
2008 (send_process, exec_sentinel):
2009 * sound.c (Fplay_sound_internal):
2010 * textprop.c (validate_plist, add_properties)
2011 (Fput_text_property, Fadd_face_text_property)
2012 (copy_text_properties, text_property_list, syms_of_textprop):
2013 * unexaix.c (report_error):
2014 * unexcoff.c (report_error):
2015 * unexsol.c (unexec):
2016 * xdisp.c (redisplay_tool_bar, store_mode_line_string)
2017 (Fformat_mode_line, syms_of_xdisp):
2018 * xfaces.c (set_font_frame_param)
2019 (Finternal_lisp_face_attribute_values)
2020 (Finternal_merge_in_global_face, syms_of_xfaces):
2021 * xfns.c (x_default_scroll_bar_color_parameter)
2022 (x_default_font_parameter, x_create_tip_frame):
2023 * xfont.c (xfont_supported_scripts):
2024 * xmenu.c (Fx_popup_dialog, xmenu_show, xdialog_show)
2025 (menu_help_callback, xmenu_show):
2026 * xml.c (make_dom):
2027 * xterm.c (set_wm_state):
2028 Prefer list1 (FOO) to Fcons (FOO, Qnil) when creating a list,
2029 and similarly for list2 through list5.
2030
2031 2013-07-15 Paul Eggert <eggert@cs.ucla.edu>
2032
2033 * callproc.c (Fcall_process_region): Fix minor race and tune.
2034 (create_temp_file): New function, with the temp-file-creation part
2035 of the old Fcall_process_region. Use Fcopy_sequence to create the
2036 temp file name, rather than alloca + build_string, for simplicity.
2037 Don't bother to block input around the temp file creation;
2038 shouldn't be needed. Simplify use of mktemp.
2039 Use record_unwind_protect immediately after creating the temp file;
2040 this closes an unlikely race where the temp file was not removed.
2041 Use memcpy rather than an open-coded loop.
2042 (Fcall_process_region): Use the new function. If the input is
2043 empty, redirect from /dev/null rather than from a newly created
2044 empty temp file; this avoids unnecessary file system traffic.
2045
2046 2013-07-14 Paul Eggert <eggert@cs.ucla.edu>
2047
2048 * filelock.c (create_lock_file) [!HAVE_MKOSTEMP && !HAVE_MKSTEMP]:
2049 Simplify by making this case like the other two. This is a bit
2050 slower on obsolete hosts, but the extra complexity isn't worth it.
2051
2052 * callproc.c (child_setup, relocate_fd) [!DOS_NT]:
2053 * process.c (create_process) [!DOS_NT]:
2054 Remove now-unnecessary calls to emacs_close.
2055
2056 2013-07-13 Eli Zaretskii <eliz@gnu.org>
2057
2058 * w32term.c (x_draw_hollow_cursor): Delete the brush object when
2059 returning early. (Bug#14850)
2060
2061 * coding.c (syms_of_coding): Set up inhibit-null-byte-detection
2062 and inhibit-iso-escape-detection attributes of 'undecided'.
2063 (Bug#14822)
2064
2065 2013-07-13 Paul Eggert <eggert@cs.ucla.edu>
2066
2067 * deps.mk (sysdep.o): Remove dependency on ../lib/ignore-value.h.
2068 Reported by Herbert J. Skuhra in
2069 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00455.html>.
2070
2071 Don't lose top specpdl entry when memory is exhausted.
2072 * eval.c (grow_specpdl): Increment specpdl top by 1 and check for
2073 specpdl overflow here, to simplify callers; all callers changed.
2074 Always reserve an unused entry at the stack top; this avoids
2075 losing the top entry's information when memory is exhausted.
2076
2077 2013-07-12 Paul Eggert <eggert@cs.ucla.edu>
2078
2079 Clean up errno reporting and fix some errno-reporting bugs.
2080 * callproc.c (Fcall_process):
2081 * fileio.c (Fcopy_file, Finsert_file_contents, Fwrite_region):
2082 * process.c (create_process, Fmake_network_process):
2083 * unexaix.c (report_error):
2084 * unexcoff.c (report_error):
2085 Be more careful about reporting the errno of failed operations.
2086 The code previously reported the wrong errno sometimes.
2087 Also, prefer report_file_errno to setting errno + report_file_error.
2088 (Fcall_process): Look at openp return value rather than at path,
2089 as that's a bit faster and clearer when there's a numeric predicate.
2090 * fileio.c (report_file_errno): New function, with most of the
2091 old contents of report_file_error.
2092 (report_file_error): Use it.
2093 (Ffile_exists_p, Ffile_accessible_directory_p):
2094 Set errno to 0 when it is junk.
2095 * fileio.c (Faccess_file):
2096 * image.c (x_create_bitmap_from_file):
2097 Use faccessat rather than opening the file, to avoid the hassle of
2098 having a file descriptor open.
2099 * lisp.h (report_file_errno): New decl.
2100 * lread.c (Flocate_file_internal): File descriptor 0 is valid, too.
2101
2102 Minor EBADF fixes.
2103 * process.c (create_process, wait_reading_process_output) [AIX]:
2104 Remove obsolete SIGHUP-related code, as Emacs no longer disables
2105 SIGHUP, so EBADF is no longer acceptable here (it wouldn't work in
2106 a multithreaded environment anyway).
2107 * sysdep.c (emacs_close): It's not dangerous to invoke emacs_close (-1).
2108
2109 2013-07-12 Andreas Schwab <schwab@linux-m68k.org>
2110
2111 * image.c (x_find_image_file): Don't close a remote file handle.
2112
2113 2013-07-12 Paul Eggert <eggert@cs.ucla.edu>
2114
2115 Fix races with threads and file descriptors.
2116 * callproc.c (Fcall_process_region):
2117 * dired.c (open_directory):
2118 * emacs.c (main, Fdaemon_initialized):
2119 * image.c (x_find_image_file):
2120 * inotify.c (Finotify_rm_watch):
2121 * lread.c (Flocate_file_internal):
2122 * process.c (Fnetwork_interface_list, Fnetwork_interface_info):
2123 * term.c (term_mouse_moveto, init_tty):
2124 * termcap.c (tgetent):
2125 * unexaix.c, unexcoff.c (report_error, report_error_1, adjust_lnnoptrs)
2126 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c (unexec):
2127 * unexhp9k800.c, unexmacosx.c (unexec):
2128 * callproc.c (Fcall_process_region):
2129 Use emacs_close, not close.
2130 * sysdep.c (POSIX_CLOSE_RESTART, posix_close) [!POSIX_CLOSE_RESTART]:
2131 New macro and function, which emulates the POSIX_CLOSE_RESTART macro
2132 and posix_close function on current platforms (which all lack them).
2133 (emacs_close): Use it. This should fix the races on GNU/Linux and
2134 on AIX and on future platforms that support POSIX_CLOSE_RESTART,
2135 and it should avoid closing random victim file descriptors on
2136 other platforms.
2137
2138 2013-07-11 Paul Eggert <eggert@cs.ucla.edu>
2139
2140 * inotify.c (uninitialized): Remove. All uses replaced by -1.
2141 (Finotify_add_watch): Simplify, since -1 means uninitialized now.
2142 Touch up doc a bit.
2143
2144 * eval.c (backtrace_function, backtrace_args): Now EXTERNALLY_VISIBLE.
2145 This is for .gdbinit xbacktrace.
2146
2147 * sysdep.c, term.c, termcap.c, terminal.c: Integer-related minor fixes.
2148 * sysdep.c (emacs_get_tty): Return void, since nobody uses the value.
2149 (emacs_set_tty): Now static.
2150 * sysdep.c (emacs_set_tty, tabs_safe_p, emacs_close):
2151 * term.c (tty_capable_p, tty_default_color_capabilities)
2152 (get_tty_terminal, term_mouse_movement)
2153 (handle_one_term_event, init_tty, maybe_fatal):
2154 * termcap.c (tgetst1, struct termcap_buffer, valid_filename_p)
2155 (tgetent, scan_file, name_match, compare_contin):
2156 * terminal.c (get_terminal):
2157 Use bool for boolean.
2158 * sysdep.c (init_system_name): Don't overflow stack on huge hostname.
2159 Prefer char to unsigned char if either will do.
2160 * term.c (OUTPUT, turn_on_face): Omit unnecessary casts to int.
2161 (tty_write_glyphs): Prefer int to unsigned.
2162 (produce_glyphless_glyph): Remove 2nd (unused) int arg.
2163 All callers changed.
2164 * termcap.c (tprint, main) [TEST]: Remove non-working test.
2165
2166 2013-07-10 Paul Eggert <eggert@cs.ucla.edu>
2167
2168 Port to C89.
2169 * bytecode.c (BYTE_CODE_THREADED): Do not define if __STRICT_ANSI__.
2170 (B__dummy__): New dummy symbol, to pacify C89.
2171 * dbusbind.c (XD_DEBUG_MESSAGE): Omit debugging on C89 hosts, since
2172 they can't grok varargs macros.
2173 * dispnew.c (add_window_display_history)
2174 (add_frame_display_history):
2175 * print.c (print_object):
2176 * xdisp.c (debug_method_add):
2177 Use %p printf format only for void pointers.
2178 * emacs.c (usage_message): New constant, replacing ...
2179 (USAGE1, USAGE2, USAGE3): Remove; they were too long for C89.
2180 (main): Adjust to usage reorg.
2181 * fns.c (syms_of_fns):
2182 * profiler.c (syms_of_profiler):
2183 Don't use non-constant struct initializers.
2184 * gnutls.h (gnutls_initstage_t):
2185 * lisp.h (enum Lisp_Fwd_Type):
2186 * lread.c (lisp_file_lexically_bound_p):
2187 * xsettings.c (anonymous enum):
2188 Remove trailing comma.
2189 * xsettings.c (apply_xft_settings): Use %f, not %lf; %lf is a C99ism.
2190 * lisp.h (ENUM_BF): Use unsigned if pedantic.
2191 (DEFUN_FUNCTION_INIT): New macro, that falls back on a cast if pre-C99.
2192 (DEFUN): Use it.
2193 * regex.c (const_re_char): New type, to pacify strict C89.
2194 All uses of 'const re_char' replaced to use it.
2195 * regex.h (_Restrict_): Rename from __restrict, to avoid clash
2196 with glibc when strict C89. This change is imported from gnulib.
2197 All uses changed.
2198 (_Restrict_arr_): Rename from __restrict_arr, similarly.
2199 * sysdep.c (time_from_jiffies) [!HAVE_LONG_LONG_INT]:
2200 Omit GNU_LINUX implementation, since it requires long long.
2201 * xterm.c (x_draw_underwave):
2202 Do not assume the traditional order of struct's members.
2203 (x_term_init): Rewrite to avoid the need for non-constant structure
2204 initializers.
2205
2206 Syntax cleanup, mostly replacing macros with functions.
2207 This removes the need for the syntax_temp hack.
2208 * search.c: Include syntax.h after buffer.h, since syntax.h uses BVAR.
2209 * syntax.c (SYNTAX_INLINE): New macro.
2210 (SYNTAX_FLAGS_COMSTART_FIRST, SYNTAX_FLAGS_COMSTART_SECOND)
2211 (SYNTAX_FLAGS_COMEND_FIRST, SYNTAX_FLAGS_COMEND_SECOND)
2212 (SYNTAX_FLAGS_PREFIX, SYNTAX_FLAGS_COMMENT_STYLEB)
2213 (SYNTAX_FLAGS_COMMENT_STYLEC, SYNTAX_FLAGS_COMMENT_STYLEC2)
2214 (SYNTAX_FLAGS_COMMENT_NESTED, SYNTAX_FLAGS_COMMENT_STYLE)
2215 (SYNTAX_COMEND_FIRST): Now functions, not macros.
2216 (ST_COMMENT_STYLE, ST_STRING_STYLE, INTERVALS_AT_ONCE):
2217 Now constants, not macros.
2218 (syntax_temp) [!__GNUC__]: Remove.
2219 (SYNTAX_PREFIX): Remove; all uses replaced by syntax_prefix_flag_p.
2220 (syntax_prefix_flag_p): Move implementation of SYNTAX_PREFIX here.
2221 (SET_RAW_SYNTAX_ENTRY, SET_RAW_SYNTAX_ENTRY_RANGE, SYNTAX_MATCH)
2222 (SETUP_SYNTAX_TABLE, SETUP_SYNTAX_TABLE_FOR_OBJECT):
2223 Move here from syntax.h; now functions, not macros. Except for the
2224 last function, these are static since only syntax.c uses them.
2225 (syntax_multibyte): Rename from SYNTAX_WITH_MULTIBYTE_CHECK.
2226 All uses changed. Now a function, not a macro; use this fact
2227 to simplify the code.
2228 (scan_lists, scan_sexps_forward): Remove workarounds for ancient
2229 compiler bugs; no longer relevant.
2230 * syntax.h: Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
2231 (SYNTAX_INLINE): New macro.
2232 (struct gl_state_s, gl_state): Move earlier, so that it's in scope
2233 for the new functions. Use bool for boolean member.
2234 (SYNTAX_ENTRY, SYNTAX, SYNTAX_WITH_FLAGS, SYNTAX_MATCH)
2235 (SYNTAX_TABLE_BYTE_TO_CHAR, UPDATE_SYNTAX_TABLE_FORWARD)
2236 (UPDATE_SYNTAX_TABLE_BACKWARD, UPDATE_SYNTAX_TABLE)
2237 (SETUP_BUFFER_SYNTAX_TABLE):
2238 Now extern inline functions, not macros.
2239 (CURRENT_SYNTAX_TABLE, SYNTAX_ENTRY_INT):
2240 Remove; all uses replaced by implementation.
2241 (syntax_temp) [!__GNUC__]: Remove decl.
2242 (SETUP_SYNTAX_TABLE_FOR_OBJECT): New decl.
2243
2244 2013-07-10 Jan Djärv <jan.h.d@swipnet.se>
2245
2246 * emacs.c (main): Fix syntax error.
2247
2248 2013-07-10 Paul Eggert <eggert@cs.ucla.edu>
2249
2250 Timestamp fixes for undo (Bug#14824).
2251 * atimer.c (schedule_atimer):
2252 * fileio.c (Ffile_newer_than_file_p):
2253 Minor cleanup: use EMACS_TIME_LT so that we can remove EMACS_TIME_GT.
2254 * buffer.c (buffer-undo-list): Document (t . 0) and (t . -1).
2255 * fileio.c (Fclear_visited_file_modtime): Move to lisp/files.el.
2256 (syms_of_fileio): Remove Sclear_visited_file_name.
2257 (Fvisited_file_modtime): Return -1, not (-1 ...), when the visited
2258 file doesn't exist; this avoids an ambiguity with negative timestamps.
2259 (Fset_visited_file_modtime): Accept -1 and 0 as time-list arg.
2260 * systime.h (make_emacs_time, invalid_emacs_time):
2261 Don't assume struct timespec layout; POSIX doesn't guarantee it.
2262 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE): Remove.
2263 * undo.c (record_first_change): Push (visited-file-modtime) onto
2264 undo list rather than reimplementing it by hand, incorrectly.
2265
2266 2013-07-09 Ken Brown <kbrown@cornell.edu>
2267
2268 * sheap.c (STATIC_HEAP_SIZE) [__x86_64__]: Increase to 18MB.
2269
2270 2013-07-09 Juanma Barranquero <lekktu@gmail.com>
2271
2272 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/sysdep.$(O)): Update.
2273
2274 2013-07-09 Paul Eggert <eggert@cs.ucla.edu>
2275
2276 Handle errno and exit status a bit more carefully.
2277 * callproc.c (child_setup) [!DOS_NT]: Don't try to stuff an error
2278 number into an exit status. Instead, use EXIT_CANCELED.
2279 (child_setup) [!MSDOS]: Avoid possible deadlock with vfork.
2280 * callproc.c (relocate_fd):
2281 * emacs.c (close_output_streams, main):
2282 * process.c (create_process):
2283 * sysdep.c (sys_subshell) [!DOS_NT || !WINDOWSNT]:
2284 Use emacs_perror for simplicity.
2285 * callproc.c (relocate_fd, main):
2286 * sysdep.c (sys_subshell):
2287 Exit with EXIT_CANCELED etc., not 1, when exec setup fails.
2288 (shut_down_emacs): Use emacs_write, not write.
2289 * emacs.c, sysdep.c: Don't include <ignore-value.h>.
2290 * fileio.c (Fcopy_file, e_write):
2291 * nsterm.m (ns_select):
2292 * process.c (send_process):
2293 * sound.c (vox_write):
2294 Use emacs_write_sig, not emacs_write.
2295 * lisp.h (emacs_write_sig, emacs_perror): New decls.
2296 * process.h (EXIT_CANCELED), EXIT_CANNOT_INVOKE, EXIT_ENOENT):
2297 New constants.
2298 * sysdep.c (emacs_backtrace): Use emacs_write, not ignore_value
2299 of write.
2300 (emacs_full_write): New function.
2301 (emacs_write): Rewrite to use it.
2302 (emacswrite_sig, emacs_perror): New functions.
2303 * xrdb.c (fatal): Don't invoke perror, since errno might be garbage.
2304
2305 2013-07-08 Magnus Henoch <magnus.henoch@gmail.com> (tiny change)
2306
2307 * image.c (imagemagick_load_image): Do not use MagickExportImagePixels
2308 on NS even if it is present. Pixmap on NS is a void*.
2309
2310 2013-07-07 Paul Eggert <eggert@cs.ucla.edu>
2311
2312 Port to Ubuntu 10 (Bug#14803).
2313 Problem reported by T.V. Raman.
2314 * process.c (close_on_exec, accept4, process_socket):
2315 Define these if !HAVE_ACCEPT4, not if !SOCK_CLOEXEC.
2316
2317 2013-07-07 Eli Zaretskii <eliz@gnu.org>
2318
2319 * w32.c (sys_dup): Declare prototype.
2320
2321 * filelock.c:
2322 * emacs.c:
2323 * callproc.c [WINDOWSNT]: Include sys/socket.h.
2324
2325 2013-07-07 Paul Eggert <eggert@cs.ucla.edu>
2326
2327 Make file descriptors close-on-exec when possible (Bug#14803).
2328 This simplifies Emacs a bit, since it no longer needs to worry
2329 about closing file descriptors by hand in some cases.
2330 It also fixes some unlikely races. Not all such races, as
2331 libraries often open files internally without setting
2332 close-on-exec, but it's an improvement.
2333 * alloc.c (valid_pointer_p) [!WINDOWSNT]:
2334 * callproc.c (Fcall_process) [!MSDOS]:
2335 * emacs.c (main) [!DOS_NT]:
2336 * nsterm.m (ns_term_init):
2337 * process.c (create_process):
2338 Use 'pipe2' with O_CLOEXEC instead of 'pipe'.
2339 * emacs.c (Fcall_process_region) [HAVE_MKOSTEMP]:
2340 * filelock.c (create_lock_file) [HAVE_MKOSTEMP]:
2341 Prefer mkostemp with O_CLOEXEC to mkstemp.
2342 * callproc.c (relocate_fd) [!WINDOWSNT]:
2343 * emacs.c (main): Use F_DUPFD_CLOEXEC, not plain F_DUPFD.
2344 No need to use fcntl (..., F_SETFD, FD_CLOEXEC), since we're
2345 now using pipe2.
2346 * filelock.c (create_lock_file) [! HAVE_MKOSTEMP]:
2347 Make the resulting file descriptor close-on-exec.
2348 * lisp.h, lread.c, process.c (close_load_descs, close_process_descs):
2349 * lread.c (load_descriptor_list, load_descriptor_unwind):
2350 Remove; no longer needed. All uses removed.
2351 * process.c (SOCK_CLOEXEC): Define to 0 if not supplied by system.
2352 (close_on_exec, accept4, process_socket) [!SOCK_CLOEXEC]:
2353 New functions.
2354 (socket) [!SOCK_CLOEXEC]: Supply a substitute.
2355 (Fmake_network_process, Fnetwork_interface_list):
2356 (Fnetwork_interface_info, server_accept_connection):
2357 Make newly-created socket close-on-exec.
2358 * sysdep.c (emacs_open, emacs_fopen):
2359 Make new-created descriptor close-on-exec.
2360 * w32.c (fcntl): Support F_DUPFD_CLOEXEC well enough for Emacs.
2361 * w32.c, w32.h (pipe2): Rename from 'pipe', with new flags arg.
2362
2363 2013-07-07 Jan Djärv <jan.h.d@swipnet.se>
2364
2365 * nsterm.m (sendEvent:): Propagate keyboard events to modal windows
2366 for NS_IMPL_GNUSTEP.
2367
2368 2013-07-07 Paul Eggert <eggert@cs.ucla.edu>
2369
2370 Fix openp errno handling.
2371 * callproc.c (Fcall_process): Preserve openp errno around close.
2372 * lread.c (openp): Set errno when returning -1, as some callers
2373 expect this.
2374
2375 2013-07-06 Jan Djärv <jan.h.d@swipnet.se>
2376
2377 * nsterm.m (sendEvent:): Handle NSAPP_DATA2_RUNFILEDIALOG.
2378
2379 * nsterm.h (NSSavePanel): Update comment.
2380 (NSAPP_DATA2_RUNFILEDIALOG): Define.
2381 (ns_run_file_dialog): Declare.
2382
2383 * nsfns.m: Remove panelOK.
2384 (ns_fd_data): New.
2385 (ns_run_file_dialog): New function.
2386 (Fns_read_file_name): Fill in ns_fd_data, post an event and start the
2387 event loop, so file dialog is popped up by ns_run_file_dialog, called
2388 by sendEvent (Bug#14578).
2389 (EmacsSavePanel, EmacsOpenPanel): Remove ok and cancel methods.
2390
2391 2013-07-06 Eli Zaretskii <eliz@gnu.org>
2392
2393 * xdisp.c (default_line_pixel_height): New function.
2394 (pos_visible_p, move_it_vertically_backward, try_scrolling)
2395 (try_cursor_movement, redisplay_window, try_window)
2396 (try_window_id): Use it instead of FRAME_LINE_HEIGHT. (Bug#14771)
2397
2398 * window.c (window_scroll_pixel_based):
2399 use default_line_pixel_height.
2400
2401 * dispextern.h (default_line_pixel_height): Add prototype.
2402
2403 * frame.c (x_set_line_spacing): Accept a float value for
2404 line-spacing parameter, per the documentation.
2405
2406 * data.c (Fmultibyte_string_p): Doc fix.
2407
2408 2013-07-05 Paul Eggert <eggert@cs.ucla.edu>
2409
2410 Use emacs_open more consistently when opening files.
2411 This handles EINTR more consistently now, and makes it easier
2412 to introduce other uniform changes to file descriptor handling.
2413 * src/systdio.h: New file.
2414 * src/buffer.c (mmap_init):
2415 * cygw32.c (chdir_to_default_directory):
2416 * dispnew.c (Fopen_termscript):
2417 * emacs.c (Fdaemon_initialized):
2418 * fileio.c (Fdo_auto_save):
2419 * image.c (slurp_file, png_load_body, jpeg_load_body):
2420 * keyboard.c (Fopen_dribble_file):
2421 * lread.c (Fload):
2422 * print.c (Fredirect_debugging_output):
2423 * sysdep.c (get_up_time, procfs_ttyname, procfs_get_total_memory):
2424 * termcap.c (tgetent):
2425 * unexaix.c, unexcoff.c (unexec, adjust_lnnoptrs):
2426 * unexcw.c, unexelf.c, unexhp9k800.c, unexmacosx.c (unexec):
2427 * w32term.c (w32_initialize) [CYGWIN]:
2428 * xfaces.c (Fx_load_color_file):
2429 Use emacs_open instead of plain open, and emacs_fopen instead of
2430 plain fopen.
2431 * dispnew.c, fileio.c, image.c, keyboard.c, lread.c, print.c, sysdep.c:
2432 * xfaces.c: Include sysstdio.h rather than stdio.h, for emacs_fopen.
2433 * callproc.c (default_output_mode): New constant.
2434 (Fcall_process): Use it to call emacs_open instead of plain creat.
2435 * dispnew.c (Fopen_termscript): Fix minor race in opening termscript.
2436 * sysdep.c (emacs_open): Add commentary and don't call file name "path".
2437 (emacs_fopen): New function.
2438 * unexaix.c, unexcoff.c, unexelf.c, unexhp9k800.c, unexmacosx.c:
2439 Include <lisp.h>, for emacs_open.
2440 * unexelf.c (fatal): Remove decl; not needed with <lisp.h> included.
2441
2442 Remove duplicate #include directives.
2443 * alloc.c [GC_MARK_STACK == GC_USE_GCPROS_CHECK_ZOMBIES]:
2444 * xfaces.c:
2445 Don't include stdio.h twice.
2446 * buffer.c [USE_MMAP_FOR_BUFFERS]:
2447 Don't include sys/types.h or stdio.h twice.
2448 * fileio.c [WINDOWSNT | MSDOS]: Don't include fcntl.h twice.
2449 * lread.c: Don't include coding.h twice.
2450 * nsfont.m: Don't include frame.h twice.
2451 * process.c [HAVE_RES_INIT]: Don't include <netinet/in.h> twice.
2452 * ralloc.c: Don't include <unistd.h> twice.
2453 * xdisp.c: Don't include font.h twice.
2454 * xterm.c: Don't include fontset.h twice.
2455 * xterm.h [USE_X_TOOLKIT]: Don't include X11/StringDefs.h twice.
2456
2457 2013-07-04 Paul Eggert <eggert@cs.ucla.edu>
2458
2459 Scale ImageMagick images more carefully.
2460 * image.c (scale_image_size) [HAVE_IMAGEMAGICK]: New function.
2461 (compute_image_size): Use it. Define only if HAVE_IMAGEMAGICK.
2462 Be more careful about avoiding undefined behavior after
2463 integer overflow and division by zero.
2464
2465 2013-07-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2466
2467 * w32fns.c (Qgeometry, Qworkarea, Qmm_size, Qframes): New variables.
2468 (syms_of_w32fns): DEFSYM them.
2469 (MONITORINFOF_PRIMARY, SM_XVIRTUALSCREEN, SM_YVIRTUALSCREEN)
2470 (CCHDEVICENAME): Define macros if not defined.
2471 (struct MONITOR_INFO_EX): New struct.
2472 (MonitorEnum_Proc, EnumDisplayMonitors_Proc): New prototypes.
2473 (enum_display_monitors_fn): New variable.
2474 (globals_of_w32fns): Initialize it.
2475 (Fx_display_pixel_width, Fx_display_pixel_height)
2476 (Fx_display_mm_height, Fx_display_mm_width): Mention behavior on
2477 multi-monitor setups in docstrings.
2478 (Fx_display_mm_height, Fx_display_mm_width): Approximate whole
2479 screen size by primary monitor's millimeter per pixel.
2480 (w32_monitor_enum, w32_display_monitor_attributes_list)
2481 (w32_display_monitor_attributes_list_fallback)
2482 (Fw32_display_monitor_attributes_list): New functions.
2483 (syms_of_w32fns): Defsubr Sw32_display_monitor_attributes_list.
2484
2485 * w32term.c (SM_CXVIRTUALSCREEN, SM_CYVIRTUALSCREEN): Define macros
2486 if not defined.
2487 (x_display_pixel_height, x_display_pixel_width): Use GetSystemMetrics.
2488
2489 2013-07-04 Michael Albinus <michael.albinus@gmx.de>
2490
2491 * fileio.c (Qfile_notify_error): New error symbol.
2492
2493 * gfilenotify.c (Fgfile_add_watch, Fgfile_rm_watch):
2494 * inotify.c (inotify_callback, symbol_to_inotifymask)
2495 (Finotify_add_watch, Finotify_rm_watch): Use it.
2496 (inotifyevent_to_event): Exchange order of cookie and file name.
2497 (Finotify_add_watch): Adapt docstring.
2498
2499 * lisp.h (Qfile_notify_error): Declare.
2500
2501 2013-07-04 Paul Eggert <eggert@cs.ucla.edu>
2502
2503 Try again to fix FreeBSD bug re multithreaded memory alloc (Bug#14569).
2504 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
2505 Do not clear _malloc_thread_enabled_p, undoing the previous change,
2506 which did not work (see <http://bugs.gnu.org/14569#307>).
2507 (main): Do not invoke malloc_enable_thread if (! CANNOT_DUMP
2508 && (!noninteractive || initialized)). This attempts to thread
2509 the needle between the Scylla of FreeBSD and the Charybdis of Cygwin.
2510
2511 2013-07-04 Juanma Barranquero <lekktu@gmail.com>
2512
2513 * image.c (x_to_xcolors) [HAVE_NTGUI]: Remove unused var `hdc'.
2514 (x_build_heuristic_mask) [HAVE_NTGUI]: Remove unused var `frame_dc'.
2515
2516 2013-07-04 Paul Eggert <eggert@cs.ucla.edu>
2517
2518 Try to fix FreeBSD bug re multithreaded memory allocation (Bug#14569).
2519 * emacs.c (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
2520 Clear _malloc_thread_enabled_p at startup. Reported by Ashish SHUKLA in
2521 <http://lists.gnu.org/archive/html/emacs-devel/2013-07/msg00088.html>.
2522
2523 2013-07-02 Paul Eggert <eggert@cs.ucla.edu>
2524
2525 * sysdep.c (sys_siglist) [HAVE_DECL___SYS_SIGLIST]:
2526 Define to __sys_siglist.
2527
2528 2013-07-02 Eli Zaretskii <eliz@gnu.org>
2529
2530 * xdisp.c (IT_OVERFLOW_NEWLINE_INTO_FRINGE): Don't disallow
2531 word-wrap, so that overflow-newline-into-fringe would work in
2532 visual-line-mode. (Bug#2749)
2533 (move_it_in_display_line_to): When the last scanned display
2534 element fits exactly on the display line, and
2535 overflow-newline-into-fringe is non-nil, but wrap_it is valid,
2536 don't return MOVE_NEWLINE_OR_CR, but instead back up to the last
2537 wrap point and return MOVE_LINE_CONTINUED. Fixes problems with
2538 finding buffer position that corresponds to pixel coordinates,
2539 e.g. in buffer_posn_from_coords.
2540
2541 2013-07-02 Jan Djärv <jan.h.d@swipnet.se>
2542
2543 * process.c (handle_child_signal): Call catch_child_signal if
2544 NS_IMPL_GNUSTEP.
2545
2546 2013-07-02 Paul Eggert <eggert@cs.ucla.edu>
2547
2548 Don't convert function pointers to void * and back.
2549 It isn't portable C, and it's easy enough to avoid.
2550 * alloc.c: Verify SAVE_FUNCPOINTER bits, too.
2551 (make_save_value): Add support for SAVE_FUNCPOINTER.
2552 * keymap.c (map_keymap_char_table_item, map_keymap_internal):
2553 * print.c (print_object):
2554 Distinguish function from object pointers.
2555 * lisp.h (SAVE_FUNCPOINTER): New constant.
2556 (SAVE_SLOT_BITS): Adjust to it.
2557 (SAVE_TYPE_FUNCPTR_PTR_OBJ): New constant, replacing
2558 SAVE_TYPE_PTR_PTR_OBJ. Change the only use.
2559 (voidfuncptr): New typedef.
2560 (struct Lisp_Save_Value): New member data[0].funcpointer.
2561 (XSAVE_FUNCPOINTER): New function.
2562
2563 Simplify buildobj processing.
2564 * Makefile.in (buildobj.h): Make it a sequence of strings each
2565 followed by comma, rather than a single string. Put it into a
2566 .tmp file in case there's an error while generating it.
2567 (gl-stamp): Use .tmp for temp files.
2568 (mostlyclean): Clean .tmp files.
2569 * doc.c (buildobj): Move to just the routine that needs it.
2570 It's now an array of strings, so processing is simpler.
2571
2572 2013-07-01 Paul Eggert <eggert@cs.ucla.edu>
2573
2574 Fix bug re noninteractive multithreaded memory allocation (Bug#14569).
2575 * emacs.c (malloc_enable_thread): Hoist extern decl to top level.
2576 (main) [HAVE_PTHREAD && !SYSTEM_MALLOC && !DOUG_LEA_MALLOC]:
2577 Invoke malloc_enable_thread even when not interactive.
2578 Problem reported by Ken Brown in <http://bugs.gnu.org/14569#275>.
2579 * process.c (init_process_emacs) [CYGWIN]: Tickle glib even
2580 in this case, since the underlying bug has now been fixed.
2581
2582 2013-07-01 Juanma Barranquero <lekktu@gmail.com>
2583
2584 * emacs.c (Fkill_emacs): Expand Vauto_save_list_file_name before
2585 unlinking it (bug#14691).
2586
2587 2013-06-30 Michal Nazarewicz <mina86@mina86.com>
2588
2589 * buffer.c (FKill_buffer): Run `kill-buffer-query-functions'
2590 before checking whether buffer is modified. This lets
2591 `kill-buffer-query-functions' cancel killing of the buffer or save
2592 its content before `kill-buffer' asks user the "Buffer %s
2593 modified; kill anyway?" question.
2594
2595 2013-06-30 Jan Djärv <jan.h.d@swipnet.se>
2596
2597 * nsfns.m (handlePanelKeys): Don't process Command+Function keys.
2598 Let the super performKeyEquivalent deal with them (Bug#14747).
2599
2600 2013-06-30 Paul Eggert <eggert@cs.ucla.edu>
2601
2602 * widget.c (resize_cb): Remove unused local.
2603
2604 Do not use GTK 3 if it exists but cannot be compiled.
2605 * xmenu.c (x_menu_wait_for_event) [!USE_GTK]:
2606 * xterm.c (x_error_handler) [!USE_GTK]:
2607 Do not use GTK 3.
2608
2609 * intervals.c (get_local_map): Actually clip POSITION (Bug#14753).
2610
2611 2013-06-30 Eli Zaretskii <eliz@gnu.org>
2612
2613 * intervals.c (get_local_map): Instead of aborting, clip POSITION
2614 to the valid range of values. (Bug#14753)
2615
2616 * xdisp.c (Fmove_point_visually): Invalidate the cursor position
2617 when moving point by using the current glyph matrix. This avoids
2618 the need to force redisplay when this function is called in a
2619 loop.
2620
2621 2013-06-29 Paul Eggert <eggert@cs.ucla.edu>
2622
2623 Fix minor problems found by static checking.
2624 * coding.c (encode_inhibit_flag, inhibit_flag): New functions.
2625 Redo the latter's body to sidestep GCC parenthesization warnings.
2626 (setup_coding_system, detect_coding, detect_coding_system): Use them.
2627 * coding.c (detect_coding, detect_coding_system):
2628 * coding.h (struct undecided_spec):
2629 Use bool for boolean.
2630 * image.c (QCmax_width, QCmax_height): Now static.
2631 * xdisp.c (Fmove_point_visually): Remove unused local.
2632
2633 2013-06-29 Eli Zaretskii <eliz@gnu.org>
2634
2635 * xdisp.c (Fmove_point_visually): New function.
2636
2637 2013-06-28 Kenichi Handa <handa@gnu.org>
2638
2639 * coding.h (define_coding_undecided_arg_index): New enum.
2640 (coding_attr_index): New members
2641 coding_attr_undecided_inhibit_null_byte_detection,
2642 coding_attr_undecided_inhibit_iso_escape_detection,
2643 coding_attr_undecided_prefer_utf_8.
2644 (undecided_spec): New struct.
2645 (struct coding_system): New member `undecided' of the member
2646 `spec'.
2647
2648 * coding.c (setup_coding_system): Handle CODING->spec.undecided.
2649 (detect_coding): Likewise.
2650 (detect_coding_system): Likewise.
2651 (Fdefine_coding_system_internal): New coding system properties
2652 :inhibit-null-byte-detection, :inhibit-iso-escape-detection, and
2653 :prefer-utf-8.
2654 (syms_of_coding): Adjust for coding_arg_undecided_max.
2655
2656 2013-06-28 Paul Eggert <eggert@cs.ucla.edu>
2657
2658 * image.c (x_from_xcolors): Remove unused local.
2659
2660 2013-06-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2661
2662 Defer image data transfer between X client and server until actual
2663 display happens.
2664
2665 * dispextern.h (struct image) [HAVE_X_WINDOWS]: New members `ximg'
2666 and `mask_img'.
2667
2668 * image.c (Destroy_Image): Remove.
2669 (x_clear_image_1): New arg `flags' instead of 3 bools `pixmap_p',
2670 `mask_p', and `colors_p'. All uses changed.
2671 (x_clear_image_1) [HAVE_X_WINDOWS]: Destroy `ximg' and `mask_img'.
2672 (CLEAR_IMAGE_PIXMAP, CLEAR_IMAGE_MASK, CLEAR_IMAGE_COLORS):
2673 New macros for `flags' arg to x_clear_image_1.
2674 (postprocess_image, xpm_load_image, x_build_heuristic_mask)
2675 (png_load_body): Use x_clear_image_1 instead of Free_Pixmap.
2676 (ZPixmap, XGetImage) [HAVE_NS]: Remove.
2677 (image_get_x_image_or_dc, image_unget_x_image_or_dc)
2678 (image_get_x_image, image_unget_x_image): New functions or macros.
2679 (image_background, image_background_transparent, x_to_xcolors)
2680 (x_build_heuristic_mask): Use image_get_x_image_or_dc instead of
2681 XGetImage or CreateCompatibleDC. Use image_unget_x_image_or_dc
2682 instead of Destroy_Image.
2683 (image_create_x_image_and_pixmap, image_put_x_image): New functions.
2684 (xpm_load_image, x_from_xcolors, x_build_heuristic_mask, pbm_load)
2685 (png_load_body, jpeg_load_body, tiff_load, gif_load)
2686 (imagemagick_load_image, svg_load_image): Use them instead of
2687 x_create_x_image_and_pixmap, and x_put_x_image followed by
2688 x_destroy_x_image, respectively.
2689 (xpm_load) [HAVE_XPM && !HAVE_NTGUI]: Use XpmReadFileToImage and
2690 XpmCreateImageFromBuffer instead of XpmReadFileToPixmap and
2691 XpmCreatePixmapFromBuffer. Create pixmaps. Fill background and
2692 background_transparent fields.
2693 (image_sync_to_pixmaps) [HAVE_X_WINDOWS]: New function.
2694 (prepare_image_for_display, x_disable_image) [HAVE_X_WINDOWS]: Use it.
2695
2696 2013-06-27 Paul Eggert <eggert@cs.ucla.edu>
2697
2698 Do not tickle glib SIGCHLD handling if Cygwin (Bug#14569).
2699 This mostly consists of undoing recent changes.
2700 * callproc.c (Fcall_process):
2701 * process.c (create_process):
2702 Do not worry about catching SIGCHLD here, undoing previous change.
2703 * nsterm.m (ns_term_init): Re-catch SIGCHLD, undoing previous change.
2704 * process.c, process.h (catch_child_signal):
2705 No longer extern if !NS_IMPL_GNUSTEP, undoing 06-22 change.
2706 * process.c (catch_child_handler): Don't worry about being called
2707 lazily and do not assume caller has blocked SIGCHLD, undoing
2708 previous change. Move first-time stuff back to
2709 init_process_emacs, undoing 06-22 change. If CYGWIN, do not
2710 tickle glib, as that causes Cygwin bootstrap to fail. Do not
2711 set lib_child_handler if it's already initialized, which may
2712 help avoid problems on GNUStep.
2713
2714 2013-06-23 Paul Eggert <eggert@cs.ucla.edu>
2715
2716 A more-conservative workaround for Cygwin SIGCHLD issues (Bug#14569).
2717 * callproc.c (Fcall_process):
2718 * process.c (create_process):
2719 Make sure SIGCHLD is caught before we fork,
2720 since Emacs startup no arranges to catch SIGCHLD.
2721 * process.c (lib_child_handler): Initialize to null, not to
2722 dummy_handler.
2723 (catch_child_signal): Allow self to be called lazily.
2724 Do nothing if it's already been called.
2725 Assume caller has blocked SIGCHLD (all callers do now).
2726 * emacs.c (main): Do not catch SIGCHLD here; defer it until
2727 just before it's really needed.
2728 * nsterm.m (ns_term_init): No need to re-catch SIGCHLD here,
2729 since it hasn't been caught yet.
2730
2731 2013-06-23 Lars Magne Ingebrigtsen <larsi@gnus.org>
2732
2733 * image.c (compute_image_size): New function to implement
2734 :max-width and :max-height.
2735 (imagemagick_load_image): Use it.
2736
2737 2013-06-23 Paul Eggert <eggert@cs.ucla.edu>
2738
2739 Try to avoid malloc SEGVs on Cygwin (Bug#14569).
2740 * callproc.c, process.h (block_child_signal, unblock_child_signal):
2741 Now extern.
2742 * emacs.c (main): Catch SIGCHLD just before initializing gfilenotify.
2743 * process.c (catch_child_signal): Block SIGCHLD while futzing with
2744 the SIGCHLD handler, since the code is not atomic and (due to glib)
2745 signals may be arriving now.
2746 * sysdep.c (init_signals): Do not catch child signals here;
2747 'main' now does that later, at a safer time.
2748
2749 2013-06-22 Paul Eggert <eggert@cs.ucla.edu>
2750
2751 Clean up SIGCHLD handling a bit (Bug#14569).
2752 * process.c, process.h (catch_child_signal):
2753 Now always extern, even if !NS_IMPL_GNUSTEP.
2754 * process.c (catch_child_signal): Move glib tickler here from
2755 init_process_emacs, so that it's done earlier in Emacs
2756 initialization. Also move the noninteractive && !initialized
2757 check here from init_process_emacs. This is all a bit cleaner for
2758 GNUish platforms, and I hope it works around the Cygwin bug.
2759 * sysdep.c (init_signals): Invoke catch_child_signal here, so
2760 that glib signal handling is tickled before glib creates threads.
2761
2762 * process.c (wait_reading_process_output): Avoid int overflow
2763 when reading more than 2 GiB total from a process.
2764
2765 2013-06-21 Paul Eggert <eggert@cs.ucla.edu>
2766
2767 * process.c (create_process): Handle a couple more cases,
2768 i.e., work even if new_argv and wait_child_setup[i] are cached.
2769 Use Fcall_process's style for volatile vars.
2770
2771 2013-06-21 Andreas Schwab <schwab@linux-m68k.org>
2772
2773 * process.c (create_process): Mark PROCESS volatile.
2774
2775 2013-06-21 Paul Eggert <eggert@cs.ucla.edu>
2776
2777 Use C99-style flexible array members if available.
2778 This avoids some subtle aliasing issues, which typically
2779 aren't a problem with GCC but may be a problem elsewhere.
2780 * alloc.c (sdata): New typedef, replacing the old struct sdata.
2781 It is a struct if GC_CHECK_STRING_BYTES, a union otherwise.
2782 In either case, it uses a flexible array member rather than
2783 the old struct hack. All uses changed.
2784 (SDATA_NBYTES, sweep_strings) [!GC_CHECK_STRING_BYTES]:
2785 Adjust to sdata reorganization.
2786 * alloc.c (VBLOCK_BYTES_MIN, allocate_vectorlike, Fgarbage_collect):
2787 Use offsetof (struct, flex_array_member), not sizeof (struct), as
2788 that ports better to pre-C99 non-GCC.
2789 * chartab.c (Fmake_char_table, make_sub_char_table, copy_char_table):
2790 Use CHAR_TABLE_STANDARD_SLOTS rather than its definition,
2791 as the latter has changed.
2792 * conf_post.h (FLEXIBLE_ARRAY_MEMBER): Move here from w32.c,
2793 and port better to pre-C99 GCC.
2794 * image.c (struct xpm_cached_color):
2795 * lisp.h (struct Lisp_Vector, struct Lisp_Bool_Vector)
2796 (struct Lisp_Char_Table, struct Lisp_Sub_Char_Table):
2797 Use FLEXIBLE_ARRAY_MEMBER.
2798 * lisp.h (string_bytes) [GC_CHECK_STRING_BYTES]:
2799 Move decl to top level so it gets checked against implementation.
2800 (CHAR_TABLE_STANDARD_SLOTS): Adjust to struct Lisp_Char_Table change.
2801 * w32.c (FLEXIBLE_ARRAY_MEMBER): Move to conf_post.h.
2802
2803 2013-06-20 Paul Eggert <eggert@cs.ucla.edu>
2804
2805 * syntax.c: Integer cleanups.
2806 (SYNTAX_FLAGS_COMMENT_STYLEC): Return a boolean, not 0-or-2.
2807 All uses that need 0-or-2 changed to:
2808 (SYNTAX_FLAGS_COMMENT_STYLEC2): New macro, with the same semantics
2809 as the old SYNTAX_FLAGS_COMMENT_STYLEC.
2810 (struct lisp_parse_state, syntax_prefix_flag_p, update_syntax_table)
2811 (char_quoted, prev_char_comend_first, back_comment)
2812 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
2813 (in_classes, forw_comment, scan_lists, scan_sexps_forward):
2814 Use bool for boolean.
2815 (update_syntax_table, skip_chars, skip_syntaxes):
2816 Prefer int to unsigned when either will do.
2817 (back_comment): Return boolean success flag, like forw_comment,
2818 instead of positive-or-minus-1 (which might have overflowed int anyway).
2819 Don't stuff ptrdiff_t into int.
2820 (syntax_spec_code, syntax_code_spec): Now const.
2821 (Fmatching_paren, scan_lists, scan_sexps_forward):
2822 Use enum syntaxcode for syntax code.
2823 (Fmatching_paren): Check that arg is a character, not just an integer.
2824 (Fstring_to_syntax): Don't assume 0377 fits in enum syntaxcode.
2825 (Finternal_describe_syntax_value): Omit no-longer-needed
2826 comparison to 0.
2827 (skip_chars): Use char, not unsigned char, when the distinction
2828 doesn't matter.
2829 (forw_comment, scan_lists): Prefer A |= B to A = A || B when B's cheap.
2830 * bytecode.c (exec_byte_code):
2831 * syntax.c (syntax_spec_code, Fchar_syntax)
2832 (Finternal_describe_syntax_value, skip_chars, skip_syntaxes)
2833 (init_syntax_once):
2834 * syntax.h (SYNTAX_WITH_FLAGS):
2835 Omit unnecessary casts.
2836
2837 2013-06-20 Eli Zaretskii <eliz@gnu.org>
2838
2839 * w32fns.c (w32_wnd_proc): Don't compute the header line and mode
2840 line dimensions here, to avoid race conditions with the main
2841 thread. (Bug#14062, bug#14630, bug#14669)
2842
2843 * w32term.c (w32_draw_window_cursor): Compute the header line and
2844 mode line dimensions here.
2845 <w32_system_caret_window, w32_system_caret_hdr_height>:
2846 <w32_system_caret_mode_height>: New variables.
2847
2848 * w32term.h: Declare them.
2849
2850 2013-06-20 Paul Eggert <eggert@cs.ucla.edu>
2851
2852 * alloc.c (die): Move "assertion failed" string here ...
2853 * lisp.h (eassert): ... from here. Also, suppress evaluation of
2854 COND when SUPPRESS_CHECKING. This shrinks the executable text
2855 size by 0.8% to 2.2% when configured with --enable-checking,
2856 depending on optimization flags (GCC 4.8.1 x86-64).
2857
2858 * floatfns.c (Flog10): Move to Lisp (marked obsolete there).
2859
2860 2013-06-20 Rüdiger Sonderfeld <ruediger@c-plusplus.de>
2861
2862 * floatfns.c (Flog) [HAVE_LOG2]: Use log2 if available and if the
2863 base is 2; this is more accurate.
2864
2865 2013-06-19 Juanma Barranquero <lekktu@gmail.com>
2866
2867 * sound.c (string_default): Move to !WINDOWSNT section.
2868 (Fplay_sound_internal) [WINDOWSNT]: Remove i_result to avoid warning.
2869
2870 2013-06-19 Paul Eggert <eggert@cs.ucla.edu>
2871
2872 * sound.c: Integer cleanups.
2873 Remove unnecessary forward decls.
2874 (struct sound_device): The 'file' member is now a Lisp_Object, not
2875 a char *, so that we needn't invoke alloca on a huge size.
2876 (Fplay_sound_internal): Adjust to this.
2877 (string_default): New function.
2878 (vox_open, vox_init, alsa_open, alsa_configure, alsa_init):
2879 Use it to adjust to the struct sound_device change.
2880 (parse_sound, wav_init, au_init, alsa_init): Use bool for booleans.
2881 (be2hs) [0]: Remove.
2882
2883 * syntax.c (skip_chars): Don't use uninitialized storage
2884 when searching a multibyte buffer for characters that are not in a
2885 unibyte string that contains non-ASCII characters.
2886
2887 2013-06-18 Jan Djärv <jan.h.d@swipnet.se>
2888
2889 * process.c: Include xgselect.h if HAVE_GLIB. Include glib.h
2890 if HAVE_GLIB && ! WINDOWSNT (Bug#14654).
2891
2892 2013-06-18 Paul Eggert <eggert@cs.ucla.edu>
2893
2894 * conf_post.h: Add comments for INLINE, EXTERN_INLINE, etc.
2895
2896 2013-06-18 Kenichi Handa <handa@gnu.org>
2897
2898 * font.c (Ffont_spec): Signal an error for an invalid font name
2899 (Bug#14648).
2900
2901 2013-06-18 Paul Eggert <eggert@cs.ucla.edu>
2902
2903 Porting fixes for merged specpdl and backtrace stacks (Bug#14643).
2904 In particular this ports to 32-bit sparc Sun cc.
2905 * eval.c (init_eval_once, grow_specpdl): Allocate a specbinding
2906 array with a dummy element at specpdl[-1], so that its address can
2907 be taken portably.
2908 (unbind_to): Do not copy the binding; not needed, now that we
2909 copy old_value in the one place where the copy is needed.
2910 * fileio.c (Fwrite_region): Use ptrdiff_t, not int, for specpdl count.
2911 * lisp.h (BITS_PER_PTRDIFF_T): Remove; no longer needed.
2912 (union specbinding): Rename from struct specbinding. Redo layout
2913 to avoid the need for 'ptrdiff_t nargs : BITS_PER_PTRDIFF_T - 1;',
2914 which is not portable. With Sun C 5.12 32-bit sparc, the
2915 declaration causes nargs to be an unsigned bitfield, a behavior
2916 that the C standard allows; but Emacs wants nargs to be signed.
2917 The overall type is now a union of structures rather than a
2918 structure of union of structures, and the 'kind' member is now a
2919 bitfield, so that the overall type doesn't grow. All uses changed.
2920 * process.c (Fmake_serial_process): Remove unnecessary initialization.
2921
2922 2013-06-17 Paul Eggert <eggert@cs.ucla.edu>
2923
2924 * frame.c (x_report_frame_params): Cast parent_desc to uintptr_t.
2925 Needed if HAVE_NTGUI. Reported by Juanma Barranquero.
2926
2927 * nsfont.m (ns_registry_to_script): Parenthesize while expression.
2928
2929 2013-06-17 Eli Zaretskii <eliz@gnu.org>
2930
2931 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
2932 unless we know that the window w's frame is a frame object.
2933 Another attempt at solving bug#14062 and bug#14630.
2934
2935 2013-06-17 Lars Magne Ingebrigtsen <larsi@gnus.org>
2936
2937 * textprop.c (property_set_type): New enum.
2938 (add_properties): Allow appending/prepending text properties.
2939 (add_text_properties_1): Factored out of Fadd_text_properties.
2940 (Fadd_text_properties): Move all the code into
2941 add_text_properties_1.
2942 (Fadd_face_text_property): New function that calls
2943 add_text_properties_1.
2944
2945 2013-06-17 Paul Eggert <eggert@cs.ucla.edu>
2946
2947 Move functions from lisp.h to individual modules when possible.
2948 From a suggestion by Andreas Schwab in <http://bugs.gnu.org/11935#68>.
2949 * alloc.c (XFLOAT_INIT, set_symbol_name):
2950 * buffer.c (CHECK_OVERLAY):
2951 * chartab.c (CHECK_CHAR_TABLE, set_char_table_ascii)
2952 (set_char_table_parent):
2953 * coding.c (CHECK_NATNUM_CAR, CHECK_NATNUM_CDR):
2954 * data.c (BOOLFWDP, INTFWDP, KBOARD_OBJFWDP, OBJFWDP, XBOOLFWD)
2955 (XKBOARD_OBJFWD, XINTFWD, XOBJFWD, CHECK_SUBR, set_blv_found)
2956 (blv_value, set_blv_value, set_blv_where, set_blv_defcell)
2957 (set_blv_valcell):
2958 * emacs.c (setlocale) [!HAVE_SETLOCALE]:
2959 * eval.c (specpdl_symbol, specpdl_old_value, specpdl_where)
2960 (specpdl_arg, specpdl_func, backtrace_function, backtrace_nargs)
2961 (backtrace_args, backtrace_debug_on_exit):
2962 * floatfns.c (CHECK_FLOAT):
2963 * fns.c (CHECK_HASH_TABLE, CHECK_LIST_END)
2964 (set_hash_key_and_value, set_hash_next, set_hash_next_slot)
2965 (set_hash_hash, set_hash_hash_slot, set_hash_index)
2966 (set_hash_index_slot):
2967 * keymap.c (CHECK_VECTOR_OR_CHAR_TABLE):
2968 * marker.c (CHECK_MARKER):
2969 * textprop.c (CHECK_STRING_OR_BUFFER):
2970 * window.c (CHECK_WINDOW_CONFIGURATION):
2971 Move here from lisp.h, and make these functions static rather than
2972 extern inline.
2973 * buffer.c (Qoverlayp):
2974 * data.c (Qsubrp):
2975 * fns.c (Qhash_table_p):
2976 * window.c (Qwindow_configuration_p):
2977 Now static.
2978 * lisp.h: Remove the abovementioned defns and decls.
2979
2980 Use functions, not macros, for XINT etc (Bug#11935).
2981 In lisp.h, prefer functions to function-like macros, and
2982 constants to object-like macros, when either will do. This:
2983 . simplifies use, as there's no more need to worry about
2984 arguments' side effects being evaluated multiple times.
2985 . makes the code easier to debug on some platforms.
2986 However, when using gcc -O0, keep using function-like macros
2987 for a few critical operations, for performance reasons.
2988 This sort of thing isn't needed with gcc -Og, but -Og
2989 is a GCC 4.8 feature and isn't widely-enough available yet.
2990 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]:
2991 Remove enum lsb_bits; no longer needed.
2992 (allocate_misc, free_misc): Don't use XMISCTYPE as an lvalue.
2993 * buffer.c (Qoverlap):
2994 * data.c (Qsubrp):
2995 * fns.c (Qhash_table_p):
2996 Now extern, so lisp.h can use these symbols.
2997 * dispextern.h: Include character.h, for MAX_CHAR etc.
2998 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
2999 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
3000 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
3001 (GLYPH_CODE_P): Move here from lisp.h.
3002 (GLYPH_CHAR, GLYPH_FACE, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
3003 (GLYPH_CHAR_VALID_P, GLYPH_CODE_P): Now functions, not macros.
3004 (GLYPH_MODE_LINE_FACE): Now enums, not macros.
3005 * eval.c (Fautoload): Cast XUNTAG output to intptr_t, since
3006 XUNTAG now returns void *.
3007 * lisp.h (lisp_h_XLI, lisp_h_XIL, lisp_h_CHECK_LIST_CONS)
3008 (lisp_h_CHECK_NUMBER CHECK_SYMBOL, lisp_h_CHECK_TYPE)
3009 (lisp_h_CONSP, lisp_h_EQ, lisp_h_FLOATP, lisp_h_INTEGERP)
3010 (lisp_h_MARKERP, lisp_h_MISCP, lisp_h_NILP)
3011 (lisp_h_SET_SYMBOL_VAL, lisp_h_SYMBOL_CONSTANT_P)
3012 (lisp_h_SYMBOL_VAL, lisp_h_SYMBOLP, lisp_h_VECTORLIKEP)
3013 (lisp_h_XCAR, lisp_h_XCDR, lisp_h_XCONS, lisp_h_XHASH)
3014 (lisp_h_XPNTR, lisp_h_XSYMBOL):
3015 New macros, renamed from their sans-lisp_h_ counterparts.
3016 (XLI, XIL, CHECK_LIST_CONS, CHECK_NUMBER CHECK_SYMBOL)
3017 (CHECK_TYPE, CONSP, EQ, FLOATP, INTEGERP, MARKERP)
3018 (MISCP, NILP, SET_SYMBOL_VAL, SYMBOL_CONSTANT_P, SYMBOL_VAL, SYMBOLP)
3019 (VECTORLIKEP, XCAR, XCDR, XCONS, XHASH, XPNTR, XSYMBOL):
3020 If compiling via GCC without optimization, define these as macros
3021 in addition to inline functions.
3022 To disable this, compile with -DINLINING=0.
3023 (LISP_MACRO_DEFUN, LISP_MACRO_DEFUN_VOID): New macros.
3024 (check_cons_list) [!GC_CHECK_CONS_LIST]: Likewise.
3025 (make_number, XFASTINT, XINT, XTYPE, XUNTAG): Likewise, but
3026 hand-optimize only in the USE_LSB_TAG case, as GNUish hosts do that.
3027 (INTMASK, VALMASK): Now macros, since static values cannot be
3028 accessed from extern inline functions.
3029 (VALMASK): Also a constant, for benefit of old GDB.
3030 (LISP_INT_TAG_P): Remove; no longer needed as the only caller
3031 is INTEGERP, which can fold it in.
3032 (XLI, XIL, XHASH, XTYPE, XINT, XFASTINT, XUINT)
3033 (make_number, XPNTR, XUNTAG, EQ, XCONS, XVECTOR, XSTRING, XSYMBOL)
3034 (XFLOAT, XPROCESS, XWINDOW, XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE)
3035 (XSUB_CHAR_TABLE, XBOOL_VECTOR, make_lisp_ptr, CHECK_TYPE)
3036 (CHECK_STRING_OR_BUFFER, XCAR, XCDR, XSETCAR, XSETCDR, CAR, CDR)
3037 (CAR_SAFE, CDR_SAFE, STRING_MULTIBYTE, SDATA, SSDATA, SREF, SSET)
3038 (SCHARS, STRING_BYTES, SBYTES, STRING_SET_CHARS, STRING_COPYIN, AREF)
3039 (ASIZE, ASET, CHAR_TABLE_REF_ASCII, CHAR_TABLE_REF)
3040 (CHAR_TABLE_SET, CHAR_TABLE_EXTRA_SLOTS, SYMBOL_VAL, SYMBOL_ALIAS)
3041 (SYMBOL_BLV, SYMBOL_FWD, SET_SYMBOL_VAL, SET_SYMBOL_ALIAS)
3042 (SET_SYMBOL_BLV, SET_SYMBOL_FWD, SYMBOL_NAME, SYMBOL_INTERNED_P)
3043 (SYMBOL_INTERNED_IN_INITIAL_OBARRAY_P, SYMBOL_CONSTANT_P)
3044 (XHASH_TABLE, HASH_TABLE_P, CHECK_HASH_TABLE, HASH_KEY, HASH_VALUE)
3045 (HASH_NEXT, HASH_HASH, HASH_INDEX, HASH_TABLE_SIZE)
3046 (XMISC, XMISCANY, XMARKER, XOVERLAY, XSAVE_VALUE, XFWDTYPE)
3047 (XINTFWD, XBOOLFWD, XOBJFWD, XBUFFER_OBJFWD, XKBOARD_OBJFWD)
3048 (XFLOAT_DATA, XFLOAT_INIT, NILP, NUMBERP, NATNUMP)
3049 (RANGED_INTEGERP, CONSP, FLOATP, MISCP, STRINGP, SYMBOLP)
3050 (INTEGERP, VECTORLIKEP, VECTORP, OVERLAYP)
3051 (MARKERP, SAVE_VALUEP, AUTOLOADP, INTFWDP, BOOLFWDP, OBJFWDP)
3052 (BUFFER_OBJFWDP, KBOARD_OBJFWDP, PSEUDOVECTOR_TYPEP)
3053 (PSEUDOVECTORP, WINDOW_CONFIGURATIONP, PROCESSP, WINDOWP)
3054 (TERMINALP, SUBRP, COMPILEDP, BUFFERP, CHAR_TABLE_P)
3055 (SUB_CHAR_TABLE_P, BOOL_VECTOR_P, FRAMEP, IMAGEP, ARRAYP)
3056 (CHECK_LIST, CHECK_LIST_CONS, CHECK_LIST_END, CHECK_STRING)
3057 (CHECK_STRING_CAR, CHECK_CONS, CHECK_SYMBOL, CHECK_CHAR_TABLE)
3058 (CHECK_VECTOR, CHECK_VECTOR_OR_STRING, CHECK_ARRAY)
3059 (CHECK_VECTOR_OR_CHAR_TABLE, CHECK_BUFFER, CHECK_WINDOW)
3060 (CHECK_WINDOW_CONFIGURATION, CHECK_PROCESS, CHECK_SUBR)
3061 (CHECK_NUMBER, CHECK_NATNUM, CHECK_MARKER, XFLOATINT)
3062 (CHECK_FLOAT, CHECK_NUMBER_OR_FLOAT, CHECK_OVERLAY)
3063 (CHECK_NUMBER_CAR, CHECK_NUMBER_CDR, CHECK_NATNUM_CAR)
3064 (CHECK_NATNUM_CDR, FUNCTIONP, SPECPDL_INDEX, LOADHIST_ATTACH)
3065 Now functions.
3066 (check_cons_list) [!GC_CHECK_CONS_LIST]: New empty function.
3067 (LISP_MAKE_RVALUE, TYPEMASK): Remove; no longer needed.
3068 (VALMASK): Define in one place rather than in two, merging the
3069 USE_LSB_TAG parts; this is simpler.
3070 (aref_addr, gc_aset, MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM)
3071 (max, min, struct Lisp_String, UNSIGNED_CMP, ASCII_CHAR_P):
3072 Move up, to avoid use before definition.
3073 Also include "globals.h" earlier, for the same reason.
3074 (make_natnum): New function.
3075 (XUNTAG): Now returns void *, not intptr_t, as this means fewer casts.
3076 (union Lisp_Fwd, BOOLFWDP, BOOL_VECTOR_P, BUFFER_OBJFWDP, BUFFERP)
3077 (CHAR_TABLE_P, CHAR_TABLE_REF_ASCII, CONSP, FLOATP, INTEGERP, INTFWDP)
3078 (KBOARD_OBJFWDP, MARKERP, MISCP, NILP, OBJFWDP, OVERLAYP, PROCESSP)
3079 (PSEUDOVECTORP, SAVE_VALUEP, STRINGP, SUB_CHAR_TABLE_P, SUBRP, SYMBOLP)
3080 (VECTORLIKEP, WINDOWP, Qoverlayp, char_table_ref, char_table_set)
3081 (char_table_translate, Qarrayp, Qbufferp, Qbuffer_or_string_p)
3082 (Qchar_table_p, Qconsp, Qfloatp, Qintegerp, Qlambda, Qlistp, Qmarkerp)
3083 (Qnil, Qnumberp, Qsubrp, Qstringp, Qsymbolp, Qvectorp)
3084 (Qvector_or_char_table_p, Qwholenump, Ffboundp, wrong_type_argument)
3085 (initialized, Qhash_table_p, extract_float, Qprocessp, Qwindowp)
3086 (Qwindow_configuration_p, Qimage): New forward declarations.
3087 (XSETFASTINT): Simplify by rewriting in terms of make_natnum.
3088 (STRING_COPYIN): Remove; unused.
3089 (XCAR_AS_LVALUE, XCDR_AS_LVALUE): Remove these macros, replacing with ...
3090 (xcar_addr, xcdr_addr): New functions. All uses changed.
3091 (IEEE_FLOATING_POINT): Now a constant, not a macro.
3092 (GLYPH, GLYPH_CHAR, GLYPH_FACE, SET_GLYPH_CHAR, SET_GLYPH_FACE)
3093 (SET_GLYPH, GLYPH_CODE_CHAR, GLYPH_CODE_FACE)
3094 (SET_GLYPH_FROM_GLYPH_CODE, GLYPH_MODE_LINE_FACE, GLYPH_CHAR_VALID_P)
3095 (GLYPH_CODE_P): Move to dispextern.h, to avoid define-before-use.
3096 (TYPE_RANGED_INTEGERP): Simplify.
3097 (Qsubrp, Qhash_table_p, Qoverlayp): New extern decls.
3098 (setlocale, fixup_locale, synchronize_system_messages_locale)
3099 (synchronize_system_time_locale) [!HAVE_SETLOCALE]:
3100 Now empty functions, not macros.
3101 (functionp): Return bool, not int.
3102 * window.c (Qwindow_configuration_p): Now extern,
3103 so window.h can use it.
3104 * window.h (Qwindowp): Move decl back to lisp.h.
3105
3106 2013-06-15 Eli Zaretskii <eliz@gnu.org>
3107
3108 * xdisp.c (Fline_pixel_height): New function, required for solving
3109 bug #14567.
3110
3111 2013-06-15 Paul Eggert <eggert@cs.ucla.edu>
3112
3113 * fns.c (Fcopy_sequence): Simplify XTYPE calculation.
3114
3115 2013-06-13 Stefan Monnier <monnier@iro.umontreal.ca>
3116
3117 * lread.c (syms_of_lread):
3118 * fns.c (Fprovide): Adjust to new format of after-load-alist.
3119
3120 2013-06-13 Kelly Dean <kellydeanch@yahoo.com> (tiny change)
3121
3122 * fileio.c (Fdo_auto_save): Trap errors in auto-save-hook. (Bug#14479)
3123
3124 2013-06-12 Xue Fuqiao <xfq.free@gmail.com>
3125
3126 * fileio.c (expand_file_name): Doc fix.
3127
3128 2013-06-11 Paul Eggert <eggert@cs.ucla.edu>
3129
3130 Tickle glib by waiting for Emacs itself, not for process 0 (Bug#14569).
3131 * process.c (init_process_emacs) [HAVE_GLIB && !WINDOWSNT]:
3132 Wait for self, not for 0. This can't hurt on GNU or similar
3133 system, and may help with Cygwin.
3134
3135 * keyboard.c: Don't use PROP (...) as an lvalue.
3136 (parse_tool_bar_item) [!USE_GTK && !HAVE_NS]:
3137 Use set_prop (A, B), not PROP (A) = B.
3138
3139 2013-06-10 Eli Zaretskii <eliz@gnu.org>
3140
3141 * xdisp.c (get_it_property): Use it->window instead of generating
3142 a Lisp object from it->w.
3143
3144 2013-06-09 Eli Zaretskii <eliz@gnu.org>
3145
3146 * xdisp.c (get_it_property): If it->object is a buffer, pass to
3147 get-char-property the window that is being rendered, instead of
3148 the buffer, to support window-specific overlays. (Bug#14575)
3149 (compute_display_string_pos): When W is NULL, use the current
3150 buffer as the object to pass to get-char-property.
3151 (Fcurrent_bidi_paragraph_direction): Assign NULL to the window
3152 pointer member of the bidi iterator, since no window is pertinent
3153 to this function.
3154
3155 2013-06-08 Eli Zaretskii <eliz@gnu.org>
3156
3157 * bidi.c (bidi_fetch_char): Accept additional argument, the window
3158 being displayed, and pass it to compute_display_string_pos.
3159 (bidi_level_of_next_char, bidi_resolve_explicit_1)
3160 (bidi_paragraph_init): All callers changed.
3161
3162 * xdisp.c (init_from_display_pos, init_iterator)
3163 (handle_single_display_spec, next_overlay_string)
3164 (get_overlay_strings_1, reseat_1, reseat_to_string)
3165 (push_prefix_prop, Fcurrent_bidi_paragraph_direction):
3166 Set bidi_it.w member from it->w.
3167 (compute_display_string_pos): Accept additional argument, the
3168 window being displayed, and pass it to Fget_char_property.
3169 (Bug#14575)
3170
3171 * dispextern.h (struct bidi_it): New member w, the window being
3172 displayed.
3173 (compute_display_string_pos): Adjust prototype.
3174
3175 2013-06-08 Jan Djärv <jan.h.d@swipnet.se>
3176
3177 * xgselect.c: Remove unneeded include xterm.h.
3178
3179 * process.c (wait_reading_process_output): Check for NS before GLIB.
3180 GLIB may be linked in due to rsvg, but ns_select must be called.
3181
3182 * xgselect.c (xg_select): Remove call to window_system_available
3183 and g_main_context_pending at the top, so Gdk events (i.e. file
3184 notify) are processed when Emacs is started with -nw.
3185
3186 2013-06-07 Eli Zaretskii <eliz@gnu.org>
3187
3188 * Makefile.in (ctagsfiles1, ctagsfiles2): Don't include *.m files.
3189 (ctagsfiles3): New variable, includes only *.m files.
3190 (TAGS): Use an explicit language name in the regular expressions,
3191 to avoid transformation of '/SOMETHING' by MSYS to
3192 'c:\MSYS\SOMETHING'.
3193
3194 2013-06-07 Richard Copley <rcopley@gmail.com> (tiny change)
3195
3196 * epaths.in: Fix commentary to PATH_SITELOADSEARCH.
3197
3198 2013-06-06 Eli Zaretskii <eliz@gnu.org>
3199
3200 * xdisp.c (note_mouse_highlight): When mouse-highlight is off,
3201 still need to set the mouse pointer shape and activate help-echo.
3202 (Bug#14558)
3203
3204 2013-06-06 Paul Eggert <eggert@cs.ucla.edu>
3205
3206 A few porting etc. fixes for the new file monitor code.
3207 See the thread containing
3208 <http://lists.gnu.org/archive/html/emacs-devel/2013-06/msg00109.html>.
3209 * gfilenotify.c (dir_monitor_callback, Fgfile_add_watch)
3210 (Fgfile_rm_watch): Don't assume EMACS_INT is the same width as a pointer.
3211 (dir_monitor_callback, Fgfile_rm_watch):
3212 Use assq_no_quit instead of Fassoc, for speed.
3213 (dir_monitor_callback, Fgfile_rm_watch):
3214 eassert that the monitor is a fixnum.
3215 (dir_monitor_callback): No need for CDR_SAFE.
3216 Simplify building of lisp with alternative tails.
3217 (Fgfile_add_watch, Fgfile_rm_watch):
3218 Do not assume glib functions set errno reliably on failure.
3219 (Fgfile_add_watch): Check that the monitor survives the XIL trick,
3220 and signal an error otherwise.
3221 (Fgfile_rm_watch): Prefer CONSP to !NILP.
3222 Use Fdelq instead of Fdelete, for speed.
3223
3224 2013-06-05 Eli Zaretskii <eliz@gnu.org>
3225
3226 * xdisp.c (handle_tool_bar_click): When mouse-highlight is off,
3227 don't insist on being invoked on a highlighted tool-bar button.
3228 Avoids losing tool-bar functionality when mouse-highlight is nil.
3229 (note_tool_bar_highlight, note_mode_line_or_margin_highlight):
3230 Don't highlight when mouse-highlight is nil.
3231 (note_mouse_highlight): When mouse-highlight is nil, don't return
3232 right away; instead, run tool-bar and mode-line highlight
3233 subroutine, clear any existing highlight, and revert the mouse
3234 pointer to its default shape. (Bug#14558)
3235
3236 2013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
3237
3238 * lisp.mk (lisp): Add prog-mode.el.
3239
3240 2013-06-05 Paul Eggert <eggert@cs.ucla.edu>
3241
3242 Chain glib's SIGCHLD handler from Emacs's (Bug#14474).
3243 * process.c (dummy_handler): New function.
3244 (lib_child_handler): New static var.
3245 (handle_child_signal): Invoke it.
3246 (catch_child_signal): If a library has set up a signal handler,
3247 save it into lib_child_handler.
3248 (init_process_emacs): If using glib and not on Windows, tickle glib's
3249 child-handling code so that it initializes its private SIGCHLD handler.
3250 * syssignal.h (SA_SIGINFO): Default to 0.
3251 * xterm.c (x_term_init): Remove D-bus hack that I installed on May
3252 31; it should no longer be needed now.
3253
3254 2013-06-05 Michael Albinus <michael.albinus@gmx.de>
3255
3256 * emacs.c (main) [HAVE_GFILENOTIFY]: Call globals_of_gfilenotify.
3257
3258 * gfilenotify.c (globals_of_gfilenotify): New function.
3259 (syms_of_gfilenotify): Move global initialization there.
3260
3261 * lisp.h (globals_of_gfilenotify) [HAVE_GFILENOTIFY]: Add prototype.
3262
3263 2013-06-05 Stefan Monnier <monnier@iro.umontreal.ca>
3264
3265 * keymap.c (Fcurrent_active_maps, Fdescribe_buffer_bindings):
3266 * keyboard.c (menu_bar_items, tool_bar_items):
3267 * doc.c (Fsubstitute_command_keys): Voverriding_terminal_local_map does
3268 not override local keymaps any more.
3269
3270 2013-06-04 Eli Zaretskii <eliz@gnu.org>
3271
3272 * window.c (Fpos_visible_in_window_p): Doc fix. (Bug#14540)
3273
3274 2013-06-03 Eli Zaretskii <eliz@gnu.org>
3275
3276 * w32console.c (initialize_w32_display): Return the dimensions of
3277 the console window via 2 additional arguments, not via the current
3278 frame. This avoids crashes due to overrunning the bounds of
3279 frame's decode_mode_spec_buffer, which is not resized following
3280 the change of the frame dimensions from the initial 10x10.
3281
3282 * w32term.h (w32_initialize_display_info): Adjust prototype.
3283
3284 * term.c (init_tty): Take dimensions of the frame from the values
3285 returned by initialize_w32_display.
3286
3287 * Makefile.in (GFILENOTIFY_CFLAGS, GFILENOTIFY_LIBS): New variables.
3288 (ALL_CFLAGS): Add $(GFILENOTIFY_CFLAGS).
3289 (LIBES): Add $(GFILENOTIFY_LIBS).
3290
3291 * w32inevt.c (handle_file_notifications): Add dummy implementation
3292 for !HAVE_W32NOTIFY.
3293
3294 * w32term.c: Wrap code with HAVE_W32NOTIFY.
3295
3296 2013-06-03 Jan Djärv <jan.h.d@swipnet.se>
3297
3298 * xgselect.c: Replace #if defined ... with #ifdef HAVE_GLIB.
3299
3300 * process.c (wait_reading_process_output): Call xg_select if HAVE_GLIB.
3301
3302 * Makefile.in (XGSELOBJ): New, xgselect.o if GLib is used, or empty.
3303
3304 2013-06-03 Paul Eggert <eggert@cs.ucla.edu>
3305
3306 Fix minor problems found by static checking.
3307 * data.c (pure_write_error):
3308 Use xsignal2, not Fsignal, as Fsignal might return.
3309 * eval.c (set_backtrace_debug_on_exit): Now static.
3310 (backtrace_p, backtrace_top, backtrace_next, record_in_backtrace):
3311 No longer inline. EXTERN_INLINE is needed only for functions
3312 defined in .h files. Reindent function header as per GNU style.
3313 (backtrace_p, backtrace_top, backtrace_next):
3314 Mark EXTERNALLY_VISIBLE so they don't get optimized away by the
3315 compiler or linker. Add extern decls to pacify gcc -Wall.
3316 * frame.c, frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
3317 Now static.
3318 * frame.c (free_monitors): Define only on platforms that need it.
3319 * nsterm.m (ns_term_init):
3320 * process.c (catch_child_signal):
3321 Don't worry about whether SIGCHLD is defined, as SIGCHLD is
3322 defined on all porting targets these days.
3323 * process.c, process.h (catch_child_signal):
3324 Make it extern only if NS_IMPL_GNUSTEP is defined.
3325
3326 2013-06-03 Eli Zaretskii <eliz@gnu.org>
3327
3328 * w32.c (gettimeofday): Make the signature identical to prototype
3329 in nt/inc/sys/time.h.
3330
3331 2013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
3332
3333 * eval.c (backtrace_p, backtrace_top, backtrace_next): Export them to
3334 .gdbinit.
3335
3336 * keyboard.c (safe_run_hooks_error): Improve error message.
3337
3338 * data.c (pure_write_error): Add `object' argument.
3339 * puresize.h (CHECK_IMPURE): Use it.
3340
3341 2013-06-03 Michael Albinus <michael.albinus@gmx.de>
3342
3343 * Makefile.in (NOTIFY_OBJ): New variable.
3344 (base_obj): Replace inotify.o by $(NOTIFY_OBJ).
3345
3346 * emacs.c (main): Use HAVE_W32NOTIFY to wrap respective code.
3347 Call syms_of_gfilenotify.
3348
3349 * gfilenotify.c: New file.
3350
3351 * keyboard.c (Qfile_notify): New variable. Replaces Qfile_inotify
3352 and Qfile_w32notify.
3353 (top): Wrap respective code by HAVE_GFILENOTIFY, HAVE_INOTIFY,
3354 HAVE_W32NOTIFY and USE_FILE_NOTIFY.
3355
3356 * lisp.h: Declare syms_of_gfilenotify.
3357
3358 * termhooks.h (e): Wrap enum by USE_FILE_NOTIFY.
3359
3360 2013-06-03 Stefan Monnier <monnier@iro.umontreal.ca>
3361
3362 Merge the specpdl and backtrace stacks. Make the structure of the
3363 specpdl entries more obvious via a tagged union of structs.
3364 * lisp.h (BITS_PER_PTRDIFF_T): New constant.
3365 (enum specbind_tag): New enum.
3366 (struct specbinding): Make it a tagged union of structs.
3367 Add a case for backtrace records.
3368 (specpdl_symbol, specpdl_old_value, specpdl_where, specpdl_arg)
3369 (specpdl_func, backtrace_function, backtrace_nargs, backtrace_args)
3370 (backtrace_debug_on_exit): New accessors.
3371 (struct backtrace): Remove.
3372 (struct catchtag): Remove backlist field.
3373 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
3374 Move to eval.c.
3375 (Flocal_variable_p): Speed up the common case where the binding is
3376 already loaded.
3377 * eval.c (backtrace_list): Remove.
3378 (set_specpdl_symbol, set_specpdl_old_value): Remove.
3379 (set_backtrace_args, set_backtrace_nargs)
3380 (set_backtrace_debug_on_exit, backtrace_p, backtrace_top)
3381 (backtrace_next): New functions.
3382 (Fdefvaralias, Fdefvar): Adjust to new specpdl format.
3383 (unwind_to_catch, internal_lisp_condition_case)
3384 (internal_condition_case, internal_condition_case_1)
3385 (internal_condition_case_2, internal_condition_case_n): Don't bother
3386 with backtrace_list any more.
3387 (Fsignal): Adjust to new backtrace format.
3388 (grow_specpdl): Move up.
3389 (record_in_backtrace): New function.
3390 (eval_sub, Ffuncall): Use it.
3391 (apply_lambda): Adjust to new backtrace format.
3392 (let_shadows_buffer_binding_p, let_shadows_global_binding_p): Move from
3393 data.c.
3394 (specbind): Adjust to new specpdl format. Simplify.
3395 (record_unwind_protect, unbind_to): Adjust to new specpdl format.
3396 (Fbacktrace_debug, Fbacktrace, Fbacktrace_frame): Adjust to new
3397 backtrace format.
3398 (mark_backtrace): Remove.
3399 (mark_specpdl, get_backtrace, backtrace_top_function): New functions.
3400 * xdisp.c (redisplay_internal): Use record_in_backtrace.
3401 * alloc.c (Fgarbage_collect): Use record_in_backtrace.
3402 Use mark_specpdl.
3403 * profiler.c (record_backtrace): Use get_backtrace.
3404 (handle_profiler_signal): Use backtrace_top_function.
3405 * .gdbinit (xbacktrace, hookpost-backtrace): Use new backtrace
3406 accessor functions.
3407
3408 2013-06-02 Jan Djärv <jan.h.d@swipnet.se>
3409
3410 * process.h (catch_child_signal): Declare.
3411
3412 * process.c (catch_child_signal): New function.
3413 (init_process_emacs): Call it.
3414
3415 * nsterm.m: Include process.h if NS_IMPL_GNUSTEP.
3416 (ns_menu_bar_is_hidden, menu_will_open_state): Define only if
3417 NS_IMPL_COCOA.
3418 (x_set_cursor_type): Remove declaration.
3419 (ns_update_begin): Only use r and bp if NS_IMPL_COCOA.
3420 (ns_update_end, ns_focus, ns_unfocus): Remove GNUStep specific code.
3421 (x_set_window_size): Remove 3 pixels from toolbar if NS_IMPL_GNUSTEP.
3422 (ns_get_color): Use F suffix on float.
3423 (ns_color_to_lisp, ns_query_color): Use EmacsCGFloat.
3424 (ns_get_rgb_color): Remove.
3425 (x_set_frame_alpha): Move view inside NS_IMPL_COCOA.
3426 (note_mouse_movement): x and y are CGFloat.
3427 (ns_draw_fringe_bitmap): Remove unused rowY.
3428 Change #if to COCOA && >= 10_6.
3429 (ns_draw_window_cursor): Remove unused overspill.
3430 (ns_draw_underwave): width and x are EamcsCGFloat.
3431 (ns_draw_box): thickness is CGFloat.
3432 (ns_dumpglyphs_image): Change #if to COCOA && >= 10_6.
3433 (ns_send_appdefined): When NS_IMPL_GNUSTEP, redirect to main thread
3434 if not in main thread.
3435 (ns_get_pending_menu_title, ns_check_menu_open)
3436 (ns_check_pending_open_menu): Put inside #if COCOA && >= 10_5.
3437 (ns_term_init): Call catch_child_signal if NS_IMPL_GNUSTEP && SIGCHLD.
3438 (sendFromMainThread:): New method.
3439 (changeFont:): size is CGFloat.
3440 (keyDown:): Check for Delete when NS_IMPL_GNUSTEP.
3441 Disable warning about permanent text.
3442 (characterIndexForPoint:): Adjust return type depending on GNUStep
3443 version.
3444 (mouseDown:): delta is CGFloat.
3445 (updateFrameSize): Remove unised variable f.
3446 (initFrameFromEmacs): Move toggleButton inside NS_IMPL_COCOA.
3447 Cast float to EmacsCGFloat.
3448 (windowWillUseStandardFrame:defaultFrame:): Set maximized_height
3449 also to -1 when restoring.
3450 (windowDidExitFullScreen:): Put call to updateCollectionBehaviour
3451 inside NS_IMPL_COCOA.
3452 (toggleFullScreen:): Put call to toggleFullScreen inside
3453 NS_IMPL_COCOA. Cast float to EmacsCGFloat.
3454 (setPosition:portion:whole:): por is CGFloat.
3455 (getMouseMotionPart:window:x:y:): Add F suffix to float.
3456 (mouseDown:): Use CGFloat.
3457 (mouseDragged:): Remove unised variable edge.
3458 (EmacsDocument): Implement for NS_IMPL_GNUSTEP.
3459
3460 * nsterm.h (EmacsCGFloat): Typedef for OSX and GNUStep when the size
3461 of CGFloat differs.
3462 (EmacsApp): New variable nextappdefined. Declare sendFromMainThread
3463 when NS_IMPL_GNUSTEP.
3464 (EmacsDocument): Declare when NS_IMPL_GNUSTEP.
3465 (EmacsView): Remove unlockFocusNeedsFlush, add windowDidMove.
3466 (EmacsToolbar): Add clearAll. Add tag argument to
3467 addDisplayItemWithImage.
3468 (EmacsSavePanel, EmacsOpenPanel): Remove getFilename and getDirectory.
3469
3470 * nsselect.m (ns_get_local_selection): Remove unused variable type.
3471
3472 * nsmenu.m (ns_update_menubar): Make static.
3473 (x_activate_menubar): Surround with ifdef NS_IMPL_COCOA
3474 (fillWithWidgetValue:): Add cast to SEL for setAction.
3475 (addSubmenuWithTitle:forFrame:): Add cast to SEL for action.
3476 (update_frame_tool_bar): Update code for GNUStep.
3477 (clearAll): New method.
3478 (addDisplayItemWithImage:idx:tag:helpText:enabled:): Handle new tag
3479 argument. Call insertItemWithItemIdentifier when NS_IMPL_GNUSTEP.
3480 Move identifierToItem setObject and activeIdentifiers addObject before
3481 call to insertItemWithItemIdentifier.
3482 (validateVisibleItems): Fix indentation.
3483 (toolbarAllowedItemIdentifiers:): Return activeIdentifiers.
3484 (initWithContentRect:styleMask:backing:defer:): Add ClosableWindow and
3485 UtilityWindow to aStyle, remove call to setStyleMask.
3486
3487 * nsimage.m (setXBMColor:, getPixelAtX:Y:): Use EmacsCGFloat.
3488
3489 * nsfont.m (ns_attribute_fvalue, ns_spec_to_descriptor)
3490 (ns_charset_covers, ns_get_covering_families, nsfont_open):
3491 Use F suffix on floats.
3492 (ns_char_width): Returns CGFloat.
3493 (ns_ascii_average_width): w is CGFloat instead of float.
3494 (nsfont_draw): cbuf and c are unsigned. Cast to char* in call to
3495 DPSxshow.
3496 (ns_glyph_metrics): CGFloat instead of float.
3497
3498 * nsfns.m (x_set_foreground_color, x_set_background_color):
3499 Use EmacsCGFloat.
3500 (ns_implicitly_set_icon_type, Fx_create_frame): Make static,
3501 remove unused variables.
3502 (Fns_read_file_name): Keep track if panel is for save.
3503 Use ns_filename_from_panel/ns_directory_from_panel.
3504 (Fns_list_services): delegate only used for COCOA.
3505 (Fns_convert_utf8_nfd_to_nfc): Remove warning for GNUStep.
3506 Just return the input if GNUStep.
3507 (x_screen_planes): Remove.
3508 (Fxw_color_values): Use EmacsCGFloat
3509 (Fns_display_monitor_attributes_list): Only get screen number for
3510 Cocoa.
3511 (getDirectory, getFilename): Remove from EmacsOpenPanel and
3512 EmacsSavePanel.
3513 (EmacsOpenPanel:ok:): Use ns_filename_from_panel and
3514 ns_directory_from_panel.
3515
3516 2013-06-01 Paul Eggert <eggert@cs.ucla.edu>
3517
3518 * process.c (handle_child_signal): Also use WCONTINUED.
3519 This is so that list-processes doesn't mistakenly list the process
3520 as stopped, when the process has actually been continued and is
3521 now running.
3522
3523 2013-05-31 Paul Eggert <eggert@cs.ucla.edu>
3524
3525 Don't let D-bus autolaunch mess up SIGCHLD handling (Bug#14474).
3526 * xterm.c (x_term_init): Inhibit D-Bus autolaunch if D-Bus is
3527 not already configured.
3528
3529 * fileio.c (Finsert_file_contents): Remove unused local (Bug#8447).
3530
3531 2013-05-29 Eli Zaretskii <eliz@gnu.org>
3532
3533 * Makefile.in (mostlyclean): Remove *.res files.
3534
3535 2013-05-29 Stefan Monnier <monnier@iro.umontreal.ca>
3536
3537 * fileio.c (Finsert_file_contents): Preserve undo info when reverting
3538 a buffer (bug#8447).
3539
3540 2013-05-27 Eli Zaretskii <eliz@gnu.org>
3541
3542 * xdisp.c (pos_visible_p): When CHARPOS is displayed frrom a
3543 display vector, and we backtrack, handle the case that the
3544 previous character position is also displayed from a display
3545 vector or covered by a display string or image. (Bug#14476)
3546
3547 2013-05-25 Jan Djärv <jan.h.d@swipnet.se>
3548
3549 * xfns.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
3550 (struct MonitorInfo, free_monitors): Remove.
3551 (x_make_monitor_attribute_list): Call make_monitor_attribute_list.
3552 (Fx_display_monitor_attributes_list): Call make_monitor_attribute_list.
3553 (syms_of_xfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
3554 Qframes, Qsource.
3555
3556 * nsfns.m (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Remove.
3557 (struct MonitorInfo, free_monitors): Remove.
3558 (ns_screen_name): Make static.
3559 (ns_make_monitor_attribute_list): Call make_monitor_attribute_list.
3560 (syms_of_nsfns): Remove DEFSYM for Qgeometry, Qworkarea, Qmm_size,
3561 Qframes, Qsource.
3562
3563 * frame.h (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
3564 (struct MonitorInfo): New struct.
3565 (free_monitors, make_monitor_attribute_list): Declare.
3566
3567 * frame.c (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource):
3568 New Lisp_Object:s.
3569 (free_monitors, make_monitor_attribute_list): New functions.
3570 (syms_of_frame): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes,
3571 Qsource.
3572
3573 2013-05-25 Xue Fuqiao <xfq.free@gmail.com>
3574
3575 * callproc.c (call_process): Refine the doc string. (Bug#14045)
3576
3577 2013-05-23 Stefan Monnier <monnier@iro.umontreal.ca>
3578
3579 * keyboard.c: Apply keyboard decoding only to events that come directly
3580 from the tty, not from unread-command-events (bug#14368).
3581 (read_event_from_main_queue): New function, extracted from read_char).
3582 (read_decoded_char): Remove.
3583 (read_decoded_event_from_main_queue): New function to replace it.
3584 (read_char): Use it.
3585 (read_key_sequence): Use read_char rather than read_decoded_char.
3586
3587 * keyboard.c (read_decoded_char): Don't decode under w32 (bug#14403).
3588
3589 2013-05-22 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
3590
3591 * casetab.c (init_casetab_once): Fix last change (bug#14424).
3592
3593 2013-05-22 Kenichi Handa <handa@gnu.org>
3594
3595 The following changes are to fix the setting of
3596 buffer-file-coding-system on, for instance, C-x RET c unix RET
3597 _FILE_OF_DOS_EOL_TYPE_ RET.
3598
3599 * coding.h (struct coding_system): New member detected_utf8_chars.
3600
3601 * coding.c (detect_coding_utf_8): Count characters and check EOL
3602 format. Include CATEGORY_MASK_UTF_8_AUTO in detect_info->found if
3603 BOM is there.
3604 (setup_coding_system): Do not initialize coding->head_ascii.
3605 (check_ascii): Do not set coding->eol_seen but update it. Do not
3606 call adjust_coding_eol_type here.
3607 (detect_coding): Fix detection of BOM for utf-8 and utf-16.
3608 If the eol-type of CODING is already specified, adjust the eol type
3609 of the found coding-system.
3610 (decode_coding_gap): Cancel previous change. Utilize the
3611 character numbers counted by detect_coding_utf_8. Fix detection
3612 of BOM for utf-8.
3613
3614 2013-05-21 Barry OReilly <gundaetiapo@gmail.com> (tiny change)
3615
3616 * search.c (looking_at_1): Only set last_thing_searched if the match
3617 changed the match-data (bug#14281).
3618
3619 2013-05-21 Dmitry Antipov <dmantipov@yandex.ru>
3620
3621 * xdisp.c (reseat_at_previous_visible_line_start):
3622 Already declared in dispextern.h, so remove it here.
3623 (move_it_vertically_backward): Likewise.
3624
3625 2013-05-20 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3626
3627 * xfns.c (check_x_display_info): Don't use XINT for terminal object.
3628 (Fx_display_pixel_width, Fx_display_pixel_height)
3629 (Fx_display_mm_width, Fx_display_mm_height):
3630 Mention `display-monitor-attributes-list' in docstrings.
3631
3632 * nsfns.m (ns_get_screen): Remove function. All uses removed.
3633 (check_ns_display_info): Sync with check_x_display_info in xfns.c.
3634 (Fx_server_max_request_size, Fx_server_vendor, Fx_server_version)
3635 (Fx_display_screens, Fx_display_mm_width, Fx_display_mm_height)
3636 (Fx_display_backing_store, Fx_display_visual_class)
3637 (Fx_display_save_under, Fx_close_connection, Fxw_display_color_p)
3638 (Fx_display_grayscale_p, Fx_display_pixel_width)
3639 (Fx_display_pixel_height, Fx_display_planes)
3640 (Fx_display_color_cells): Sync args and docstrings with xfns.c.
3641 (Fx_display_screens): Don't confuse X11 screens with NS screens.
3642 (Fx_display_mm_width, Fx_display_mm_height)
3643 (Fx_display_pixel_width, Fx_display_pixel_width): Return width or
3644 height for all physical monitors as in X11.
3645
3646 * nsterm.m (x_display_pixel_width, x_display_pixel_height):
3647 Return pixel width or height for all physical monitors as in X11.
3648
3649 2013-05-18 Paul Eggert <eggert@cs.ucla.edu>
3650
3651 Port --enable-gcc-warnings to clang.
3652 * bytecode.c (exec_byte_code):
3653 * regex.c:
3654 Redo diagnostic pragmas to pacify clang, too.
3655 * dbusbind.c (xd_retrieve_arg): Do not use uninitialized variable.
3656 * editfns.c (Fencode_time):
3657 * fileio.c (file_accessible_directory_p):
3658 * font.c (font_unparse_xlfd):
3659 Use '&"string"[index]' instead of '"string" + (index)'.
3660 * undo.c (user_error): Remove; unused.
3661
3662 2013-05-16 Eli Zaretskii <eliz@gnu.org>
3663
3664 * insdel.c (insert_1_both): Document the arguments, instead of
3665 referring to insert_1, which no longer exists.
3666
3667 * xdisp.c (message_dolog): If the *Messages* buffer is shown in
3668 some window, increment windows_or_buffers_changed, so that
3669 *Messages* display in that window is updated. (Bug#14408)
3670
3671 * w32.c: Include epaths.h.
3672 (init_environment): Use cmdproxy.exe without leading directories.
3673 Support emacs.exe in src; point SHELL to cmdproxy in ../nt in that
3674 case.
3675 (gettimeofday): Adjust signature and return value to Posix
3676 expectations.
3677
3678 * unexw32.c (open_output_file): Delete the existing emacs.exe
3679 before creating it, to break the hard link to the versioned
3680 executable.
3681
3682 * Makefile.in (EMACS_MANIFEST, CM_OBJ, TEMACS_POST_LINK)
3683 (ADDSECTION, EMACS_HEAPSIZE, MINGW_TEMACS_POST_LINK)
3684 (FIRSTFILE_OBJ): New variables.
3685 (W32_RES): Rename to EMACSRES. All users changed.
3686 (base_obj): Use $(CM_OBJ).
3687 (ALLOBJS): Use $(FIRSTFILE_OBJ).
3688 (emacs$(EXEEXT)): Depend on $(ADDSECTION).
3689 (temacs$(EXEEXT)): Use $(TEMACS_POST_LINK), and move
3690 $(W32_RES_LINK) before $(LIBES).
3691 (emacs.res): Depend on $(EMACS_MANIFEST). Put emacs.rc in nt.
3692
3693 2013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3694
3695 * makefile.w32-in (DOC): Use just "DOC".
3696
3697 * Makefile.in (bootstrap-clean): DOC-* doesn't exist any more.
3698
3699 * process.c: Export default filters and sentinels to Elisp.
3700 (Qinternal_default_process_sentinel, Qinternal_default_process_filter):
3701 New constants.
3702 (pset_filter, pset_sentinel, make_process, Fset_process_filter)
3703 (Fset_process_sentinel, Fformat_network_address):
3704 Default to them instead of nil.
3705 (server_accept_connection): Sentinels can't be nil any more.
3706 (read_and_dispose_of_process_output): New function, extracted from
3707 read_process_output.
3708 (read_process_output): Use it; filters can't be nil.
3709 (Finternal_default_process_filter): New function, extracted from
3710 read_process_output.
3711 (exec_sentinel_unwind): Remove function.
3712 (exec_sentinel): Don't zilch sentinel while running.
3713 (status_notify): Sentinels can't be nil.
3714 (Finternal_default_process_sentinel): New function extracted from
3715 status_notify.
3716 (setup_process_coding_systems): Default filter is not nil any more.
3717 (syms_of_process): Export new Elisp functions and initialize
3718 new constants.
3719 * lisp.h (make_lisp_proc): New function.
3720
3721 2013-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3722
3723 * regex.c (regex_compile) [\=, \>, \<]: Don't forget to set laststart.
3724
3725 2013-05-14 Eli Zaretskii <eliz@gnu.org>
3726
3727 * w32fns.c (w32_wnd_proc): Don't call WINDOW_HEADER_LINE_HEIGHT
3728 unless we know that the window w is a leaf window.
3729 Another attempt at solving bug#14062.
3730
3731 2013-05-14 Jan Djärv <jan.h.d@swipnet.se>
3732
3733 * nsfont.m (ns_spec_to_descriptor): Retain and autorelease
3734 fdesc (Bug#14375).
3735
3736 2013-05-12 Paul Eggert <eggert@cs.ucla.edu>
3737
3738 * image.c (gif_load): Check that subimages fit (Bug#14345).
3739
3740 2013-05-09 Stefan Monnier <monnier@iro.umontreal.ca>
3741
3742 * lread.c (skip_dyn_eof): New function.
3743 (read1): Use it to skip the end of a file in response to #@00.
3744
3745 * doc.c (get_doc_string): Slightly relax the sanity checking.
3746
3747 2013-05-09 Jan Djärv <jan.h.d@swipnet.se>
3748
3749 * nsfns.m: Include IOGraphicsLib.h if Cocoa.
3750 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): Declare.
3751 (MonitorInfo): New struct.
3752 (free_monitors, ns_screen_name, ns_make_monitor_attribute_list)
3753 (Fns_display_monitor_attributes_list): New functions.
3754 (display-usable-bounds): Remove.
3755 (syms_of_nsfns): DEFSYM Qgeometry, Qworkarea, Qmm_size, Qframes and
3756 Qsource.
3757
3758 2013-05-09 Paul Eggert <eggert@cs.ucla.edu>
3759
3760 * xterm.h (GTK_PREREQ): Remove, replacing with GTK_CHECK_VERSION.
3761 (GTK_CHECK_VERSION): New macro, if not already defined.
3762 All uses of GTK_PREREQ, GTK_MAJOR_VERSION, etc.
3763 replaced by GTK_CHECK_VERSION.
3764
3765 2013-05-08 Paul Eggert <eggert@cs.ucla.edu>
3766
3767 * xterm.h (GTK_PREREQ): New macro.
3768 All simple uses of GTK_MAJOR_VERSION and GTK_MINOR_VERSION changed
3769 to use this macro instead, for consistency and clarity.
3770
3771 2013-05-08 Eli Zaretskii <eliz@gnu.org>
3772
3773 * xdisp.c (row_for_charpos_p): New function, with code of
3774 cursor_row_p, but accepts an additional argument CHARPOS instead
3775 of using a hardcoded PT.
3776 (cursor_row_p): Call row_for_charpos_p with 2nd argument PT.
3777 (row_containing_pos): Call row_for_charpos_p instead of partially
3778 doing the same. Fixes cursor positioning under longlines-mode
3779 when longlines-show-effect includes more than one newline, when
3780 moving the cursor vertically up.
3781
3782 2013-05-08 Juanma Barranquero <lekktu@gmail.com>
3783
3784 * makefile.w32-in (ACL_H): New macro.
3785 ($(BLD)/fileio.$(O)): Update dependencies.
3786
3787 2013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3788
3789 Use Gnulib ACL implementation, for benefit of Solaris etc. (Bug#14295)
3790 * Makefile.in (LIB_ACL): New macro.
3791 (LIBACL_LIBS): Remove.
3792 (LIBES): Use LIB_ACL, not LIBACL_LIBS.
3793 * fileio.c: Include <acl.h>.
3794 Use HAVE_ACL_SET_FILE rather than HAVE_POSIX_ACL.
3795 (ACL_NOT_WELL_SUPPORTED): Remove. All uses replaced by
3796 !acl_errno_valid.
3797 (Fcopy_file) [!WINDOWSNT]: Use qcopy_acl instead of rolling
3798 it ourselves.
3799
3800 * unexelf.c: Don't assume ElfW (Half) fits in int.
3801 (entry_address, find_section, unexec): Use ptrdiff_t, not int,
3802 when dealing with ElfW (Half) values, since they can exceed 2**31
3803 on 64-bit OpenBSD hosts. Problem reported privately by Han Boetes.
3804 (entry_address): Omit unused NUM arg. All uses changed.
3805
3806 2013-05-07 Juri Linkov <juri@jurta.org>
3807
3808 * callint.c (Fcall_interactively): Set `visargs[i]' for code 'n'
3809 to the string converted from number with `Fnumber_to_string'.
3810 (Bug#14254)
3811
3812 2013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3813
3814 * xfns.c (x_get_net_workarea): Define only if !GTK || GTK<3.4.
3815 This fixes a problem introduced by my previous change.
3816
3817 2013-05-07 Glenn Morris <rgm@gnu.org>
3818
3819 * lread.c (readchar): Don't read from a dead buffer. (Bug#14280)
3820
3821 2013-05-07 Jan Djärv <jan.h.d@swipnet.se>
3822
3823 * xfns.c: Move misplaced ifndef USE_GTK from previous checkin.
3824
3825 2013-05-07 Paul Eggert <eggert@cs.ucla.edu>
3826
3827 Static checking by GCC 4.8.0.
3828 * xfns.c (x_get_net_workarea, struct MonitorInfo, free_monitors)
3829 (x_get_monitor_for_frame, x_make_monitor_attribute_list)
3830 (x_get_monitor_attributes_fallback)
3831 (x_get_monitor_attributes_xinerama)
3832 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes):
3833 Define only if USE_GTK.
3834 (free_monitors): Define only if HAVE_XINERAMA || HAVE_XRANDR.
3835 (x_get_monitor_attributes_fallback): Omit unused locals.
3836 (x_get_monitor_attributes_xinerama, Fx_display_monitor_attributes_list):
3837 Use double, not float, to avoid mixed-mode floating point arithmetic.
3838
3839 2013-05-07 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3840 Jan Djärv <jan.h.d@swipnet.se>
3841
3842 * Makefile.in (XRANDR_LIBS, XRANDR_CFLAGS, XINERAMA_LIBS)
3843 (XINERAMA_CFLAGS): New macros.
3844 (ALL_CFLAGS, LIBES): Use them.
3845
3846 * xfns.c: Include <X11/extensions/Xrandr.h> if HAVE_XRANDR, and
3847 include <X11/extensions/Xinerama.h> if HAVE_XINERAMA.
3848 (Qgeometry, Qworkarea, Qmm_size, Qframes, Qsource): New variables.
3849 (syms_of_xfns): DEFSYM them.
3850 (struct MonitorInfo): New struct.
3851 (x_get_net_workarea, free_monitors, x_get_monitor_for_frame)
3852 (x_make_monitor_attribute_list, x_get_monitor_attributes_fallback)
3853 (x_get_monitor_attributes_xrandr, x_get_monitor_attributes)
3854 (x_get_monitor_attributes_xinerama): New functions.
3855 (Fx_display_monitor_attributes_list): New primitive.
3856 (syms_of_xfns): Defsubr it.
3857
3858 * xterm.h (x_display_info): Add Xatom_net_workarea and
3859 Xatom_net_current_desktop.
3860
3861 * xterm.c (x_term_init): Initialize dpyinfo->Xatom_net_workarea
3862 and dpyinfo->Xatom_net_current_desktop.
3863
3864 2013-05-06 Eli Zaretskii <eliz@gnu.org>
3865
3866 * xdisp.c (pos_visible_p): Use the special code for finding the
3867 beginning of a display property or overlay for any "replacing"
3868 display property, not just for display strings. This solves
3869 incorrect reporting of position by posn-at-point. (Bug#14241)
3870
3871 2013-05-06 Paul Eggert <eggert@cs.ucla.edu>
3872
3873 * unexelf.c: Fix some 32-bit integer problems, notably when debugging.
3874 Include <limits.h>, <stdbool.h>, <intprops.h>, <verify.h>.
3875 Verify that ElfW (Half) fits in int.
3876 (fatal): Use same signature as lisp.h.
3877 (UNEXELF_DEBUG): New macro, replacing DEBUG, so that people can
3878 configure and build with -DUNEXELF_DEBUG without worrying about
3879 other modules that use DEBUG.
3880 (DEBUG_LOG) [UNEXELF_DEBUG]: New macro. All debug code that prints
3881 possibly-wide integers now uses it instead of plain fprintf.
3882 (entry_address): New function, which avoids problems with 32-bit
3883 overflow on 64-bit hosts.
3884 (OLD_SECTION_H, NEW_SECTION_H, NEW_PROGRAM_H): Use it.
3885 (round_up): Don't assume the remainder fits in int.
3886 (find_section): Use bool for boolean. Simplify debug code.
3887 (unexec): Don't assume file sizes fit in int or size_t.
3888 Omit unnecessary trailing newline in 'fatal' format.
3889 Use strerror rather than outputting decimal error number.
3890 Remove unused code when emacs is not defined;
3891 this file relies on Emacs now.
3892 Don't assume e_phnum and e_shnum are positive.
3893
3894 * regex.c: Fix problems when DEBUG is defined.
3895 (extract_number, extract_number_and_incr): Define regardless of
3896 whether DEBUG is defined; that's simpler and makes the code less
3897 likely to go stale in the normal case when DEBUG is not defined.
3898 Return int rather than taking an int * arg. All callers changed.
3899 (DEBUG_PRINT1, DEBUG_PRINT2, DEBUG_PRINT3, DEBUG_PRINT4):
3900 Remove, replacing with ...
3901 (DEBUG_PRINT): New macro. All callers changed.
3902 (DEBUG_COMPILES_ARGUMENTS): New macro.
3903 (print_fastmap, print_partial_compiled_pattern) [DEBUG]:
3904 (print_compiled_pattern, print_double_string) [DEBUG]:
3905 Use prototype rather than old-style definition.
3906 (print_partial_compiled_pattern, print_compiled_pattern) [DEBUG]:
3907 (ENSURE_FAIL_STACK, PUSH_FAILURE_REG) [DEBUG]:
3908 (POP_FAILURE_REG_OR_COUNT, PUSH_FAILURE_POINT) [DEBUG]:
3909 (POP_FAILURE_POINT, re_match_2_internal) [DEBUG]:
3910 Don't assume ptrdiff_t, size_t, and long are the same width as int.
3911 (POINTER_TO_OFFSET): Return ptrdiff_t, not regoff_t.
3912 This matters only when DEBUG is defined.
3913
3914 2013-05-05 Eli Zaretskii <eliz@gnu.org>
3915
3916 * xdisp.c (set_iterator_to_next): Set the
3917 ignore_overlay_strings_at_pos_p flag only if we are _really_
3918 iterating over an overlay string, as indicated by the
3919 current.overlay_string_index member. (Bug#14306)
3920
3921 2013-05-05 Jan Djärv <jan.h.d@swipnet.se>
3922
3923 * nsmenu.m (ns_update_menubar): Move initialization of submenuTitle
3924 to where it is used, to avoid autorelease issues (Bug#14050).
3925
3926 2013-05-05 Paul Eggert <eggert@cs.ucla.edu>
3927
3928 `write-region-inhibit-fsync' defaults to noninteractive (Bug#14273).
3929 * fileio.c (syms_of_fileio): Implement this.
3930 * filelock.c (create_lock_file): If symbolic links don't work, so
3931 we use a regular file as a lock file, do not fsync the lock file;
3932 it's not needed.
3933
3934 2013-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3935
3936 * minibuf.c (Fread_minibuffer, Feval_minibuffer): Move to Elisp.
3937 (syms_of_minibuf): Adjust accodingly.
3938 * lread.c (Fread):
3939 * callint.c (Fcall_interactively): Adjust calls accordingly.
3940
3941 2013-05-04 Eli Zaretskii <eliz@gnu.org>
3942
3943 * dispextern.h (WINDOW_WANTS_HEADER_LINE_P): Verify that
3944 w->contents is a buffer before computing everything else.
3945 Use parentheses to disambiguate last part of the condition.
3946
3947 * w32fns.c (w32_wnd_proc): Remove temporary code used to trap
3948 assertion violations. (Bug#14062)
3949
3950 2013-05-01 David Reitter <david.reitter@gmail.com>
3951
3952 * nsfns.m (ns_tooltip): Initialize.
3953
3954 2013-04-28 Eli Zaretskii <eliz@gnu.org>
3955
3956 * coding.c (decode_coding_gap): Don't remove the character before
3957 a newline unless it's a CR character. (Bug#14287)
3958
3959 2013-04-28 Dan Nicolaescu <dann@gnu.org>
3960
3961 * dispextern.h (struct face): Move enum face_underline_type
3962 earlier so that bitfields can be in the same word.
3963
3964 2013-04-28 Jan Djärv <jan.h.d@swipnet.se>
3965
3966 * nsfns.m (handlePanelKeys): New function.
3967 (EmacsOpenPanel:performKeyEquivalent:)
3968 (EmacsSavePanel:performKeyEquivalent:): Call handlePanelKeys to handle
3969 arrows/function/control and copy/paste keys (Bug#14296).
3970
3971 2013-04-27 Juri Linkov <juri@jurta.org>
3972
3973 * callint.c (Fcall_interactively): Call `Qread_number' for
3974 interactive code letter `n' instead of using duplicate code.
3975 (Bug#14254)
3976
3977 2013-04-27 Paul Eggert <eggert@cs.ucla.edu>
3978
3979 * systime.h (make_timeval): Declare as 'const'.
3980
3981 2013-04-27 Kenichi Handa <handa@gnu.org>
3982
3983 * font.c (font_open_entity): Always open a font of manageable
3984 size.
3985
3986 2013-04-26 Paul Eggert <eggert@cs.ucla.edu>
3987
3988 Port better to AIX (Bug#14258).
3989 * lisp.h (ENUM_BF) [__IBMC__]: Make it 'unsigned int' here, too,
3990 to pacify AIX xlc.
3991
3992 2013-04-24 Kenichi Handa <handa@gnu.org>
3993
3994 * coding.c (decode_coding_iso_2022): When an invalid escape
3995 sequence is encountered, reset the invocation and designation
3996 status to the safest one.
3997
3998 2013-04-22 Paul Eggert <eggert@cs.ucla.edu>
3999
4000 * Makefile.in (bootstrap-clean): Remove stamp-h1 too.
4001 Without this fix, "make distclean" leaves stamp-h1 behind.
4002
4003 2013-04-20 Erik Charlebois <erikcharlebois@gmail.com>
4004
4005 * w32fns.c (w32_fullscreen_rect): New function to compute the
4006 window rectangle for the given fullscreen mode.
4007 (w32_wnd_proc): When in a fullscreen mode, WM_WINDOWPOSCHANGING no
4008 longer tunes the window size. This keeps the window's edges flush
4009 with the screen and allows the taskbar to hide itself in fullboth.
4010
4011 * w32term.c (w32fullscreen_hook): 'fullboth' now shows without
4012 window decorations and uses the entire screen.
4013
4014 * w32term.h (w32_fullscreen_rect) Add prototype.
4015 (struct w32_output): Replace normal_width, normal_height,
4016 normal_top, and normal_left members with a single normal_placement
4017 struct.
4018 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP):
4019 Remove macros.
4020 (FRAME_NORMAL_PLACEMENT): New macro.
4021
4022 2013-04-16 Juanma Barranquero <lekktu@gmail.com>
4023
4024 * minibuf.c (Ftest_completion): Silence compiler warning.
4025
4026 2013-04-15 Eli Zaretskii <eliz@gnu.org>
4027
4028 * w32fns.c (w32_wnd_proc): Add more assertions to investigate
4029 bug#14062.
4030
4031 * frame.h (WINDOW_FRAME): Protect macro and its argument with
4032 parentheses.
4033
4034 * dispextern.h (CURRENT_MODE_LINE_HEIGHT)
4035 (CURRENT_HEADER_LINE_HEIGHT, WINDOW_WANTS_MODELINE_P)
4036 (WINDOW_WANTS_HEADER_LINE_P): Protect macro arguments with
4037 parentheses where appropriate.
4038
4039 2013-04-14 Paul Eggert <eggert@cs.ucla.edu>
4040
4041 * keyboard.c (timer_start_idle): Remove no-longer-used local.
4042
4043 2013-04-14 Eli Zaretskii <eliz@gnu.org>
4044
4045 * buffer.c (syms_of_buffer) <left-margin-width, right-margin-width>
4046 <left-fringe-width, right-fringe-width, fringes-outside-margins>:
4047 Mention in the doc string that setting these variables takes
4048 effect only after a call to set-window-buffer. (Bug#14200)
4049
4050 2013-04-13 Eli Zaretskii <eliz@gnu.org>
4051
4052 * indent.c (Fvertical_motion): Don't consider display strings on
4053 overlay strings as display strings on the buffer position we
4054 started from. This prevents vertical cursor motion from jumping
4055 more than one line when there's an overlay string with a display
4056 property at end of line.
4057 Reported by Karl Chen <Karl.Chen@quarl.org> in
4058 http://lists.gnu.org/archive/html/emacs-devel/2013-04/msg00362.html.
4059
4060 2013-04-12 Stefan Monnier <monnier@iro.umontreal.ca>
4061
4062 * window.c (select_window): `record_buffer' even if window is
4063 already selected (bug#14191).
4064
4065 2013-04-11 Eli Zaretskii <eliz@gnu.org>
4066
4067 * window.c (Fwindow_end): Test more flags, including the buffer's
4068 last_overlay_modified flag, to determine whether the window's
4069 display is really up-to-date. Prevents the function from
4070 returning a stale value. (Bug#14170)
4071 (Fwindow_line_height): Fix the test for up-to-date-ness of the
4072 current matrix.
4073
4074 2013-04-10 Eli Zaretskii <eliz@gnu.org>
4075
4076 * frame.c (do_switch_frame): Mark the TTY frame we switch to as
4077 garbaged only if it is not already the top frame on its TTY.
4078 This prevents flickering due to constant redrawing of TTY frames when
4079 there are GUI frames open in the same session. (Bug#13864)
4080
4081 2013-04-10 Stefan Monnier <monnier@iro.umontreal.ca>
4082
4083 * keyboard.c (timer_start_idle): Call internal-timer-start-idle instead
4084 of marking the idle timers directly.
4085
4086 2013-04-09 Stefan Monnier <monnier@iro.umontreal.ca>
4087
4088 * minibuf.c (Ftest_completion): Ignore non-string/symbol keys in hash
4089 tables (bug#14054).
4090
4091 2013-04-08 Stefan Monnier <monnier@iro.umontreal.ca>
4092
4093 * window.c (select_window): Don't record_buffer while the invariant is
4094 temporarily broken (bug#14161).
4095
4096 * fns.c (Fdelq): Don't assume !NILP => CONSP.
4097
4098 2013-04-07 Eli Zaretskii <eliz@gnu.org>
4099
4100 * fileio.c (ACL_NOT_WELL_SUPPORTED): Define macro for WINDOWSNT.
4101
4102 2013-04-07 Romain Francoise <romain@orebokech.com>
4103
4104 Ignore additional platform-specific ACL errors (Bug#13702).
4105 * fileio.c (ACL_NOT_WELL_SUPPORTED): New macro copied from gnulib.
4106 (Fcopy_file, Fset_file_acl) [HAVE_POSIX_ACL]: Use it.
4107
4108 2013-03-31 Jan Djärv <jan.h.d@swipnet.se>
4109
4110 * nsterm.m (ns_mouse_position): Use NS_FRAME_P instead of checking
4111 f->output_data.ns.
4112
4113 2013-04-07 Paul Eggert <eggert@cs.ucla.edu>
4114
4115 Fix --enable-profiling bug introduced by 2013-02-25 change (Bug#13783).
4116 This bug was introduced by my 2013-02-25 change that simplified
4117 data_start configuration. Without this change, on GNU/Linux
4118 an Emacs configured with --enable-profiling fails immediately
4119 due to a profiler signal.
4120 * Makefile.in: Compile with $(PROFILING_CFLAGS), but do not link
4121 with these flags. On platforms where special flags are needed
4122 when linking temacs, the flags are now in LD_SWITCH_SYSTEM_TEMACS.
4123 (ALL_CFLAGS): Remove $(PROFILING_CFLAGS).
4124 (.c.o, .m.o): Compile with $(PROFILING_CFLAGS).
4125
4126 2013-04-07 Dmitry Antipov <dmantipov@yandex.ru>
4127
4128 Get rid of some platform-specific functions examining window
4129 system and its capabilities. This is a partial rework of the
4130 2013-04-05 change.
4131 * lisp.h (have_menus_p): Remove prototype. This function is
4132 replaced with platform-independent window_system_available.
4133 (check_window_system): Move to...
4134 * frame.h (decode_window_system_frame, window_system_available):
4135 ...here, add new prototypes.
4136 * frame.c (window_system_available, decode_window_system_frame):
4137 New functions.
4138 (check_window_system): Platform-independent now.
4139 * xterm.h (x_in_use): Remove declaration.
4140 (check_x_frame):
4141 * w32term.h (check_x_frame):
4142 * nsterm.h (check_x_frame): Remove prototypes. This function
4143 is replaced with platform-independent decode_window_system_frame.
4144 * msdos.c (have_menus_p): Remove.
4145 * nsfns.m (check_window_system, have_menus_p, check_ns_frame):
4146 Remove platform-specific functions. Use check_window_system,
4147 decode_window_system_frame and check_ns_display_info where
4148 appropriate. Minor style and comment tweaks.
4149 * w32fns.c (w32_in_use, check_window_system, have_menus_p)
4150 (check_x_frame): Likewise.
4151 * xfns.c (x_in_use, check_window_system, have_menus_p, check_x_frame):
4152 Likewise.
4153 * fileio.c, fns.c, font.c, fontset.c, image.c, menu.c, nsmenu.m:
4154 * nsselect.m, nsterm.m, w32font.c, w32menu.c, xfaces.c, xgselect.c:
4155 * xmenu.c, xselect.c: All related users changed.
4156
4157 2013-04-03 Kenichi Handa <handa@gnu.org>
4158
4159 The following changes is to optimize the code for reading UTF-8
4160 files.
4161
4162 * coding.c (check_ascii): Rename from detect_ascii. Return value
4163 changed. Check EOL format. Do not call adjust_coding_eol_type
4164 here.
4165 (check_utf_8): New function.
4166 (adjust_coding_eol_type): Do nothing if already adjusted.
4167 (detect_coding): Compare the return value of check_ascii with
4168 coding->src_bytes. Call adjust_coding_eol_type if necessary.
4169 (decode_coding_gap): Optimize for valid UTF-8.
4170
4171 2013-03-21 Kenichi Handa <handa@gnu.org>
4172
4173 * coding.c (syms_of_coding): Cancel previous change.
4174
4175 * insdel.c (insert_from_gap): Fix previous change.
4176
4177 2013-04-05 Dmitry Antipov <dmantipov@yandex.ru>
4178
4179 Consistently use platform-specific function to detect window system.
4180 * lisp.h (check_window_system): New prototype. This function is
4181 going to replace check_x, check_w32 and check_ns.
4182 (have_menus_p): Mention msdos.c in comment.
4183 * fontset.c (check_window_system_func): Remove. Adjust all users.
4184 * fontset.h (check_window_system_func): Remove prototype.
4185 * nsterm.h (check_ns):
4186 * xterm.h (check_x):
4187 * w32term.h (check_w32): Likewise.
4188 * menu.c (Fx_popup_menu): Use check_window_system.
4189 * msdos.c (check_window_system): Define for MS-DOS.
4190 * nsfns.m (check_window_system): Define for NS. Adjust all users.
4191 * w32fns.c (check_window_system): Likewise for MS-Windows.
4192 * xfns.c (check_window_system): Likewise for X.
4193 * font.c, frame.c, nsmenu.m, nsselect.m, nsterm.m, w32menu.c:
4194 * xfaces.c, xmenu.c: Use check_window_system where appropriate.
4195
4196 2013-04-02 Paul Eggert <eggert@cs.ucla.edu>
4197
4198 Prefer < to > in range checks such as 0 <= i && i < N.
4199 This makes it easier to visualize quantities on a number line.
4200 This patch doesn't apply to all such range checks,
4201 only to the range checks affected by the 2013-03-24 change.
4202 This patch reverts most of the 2013-03-24 change.
4203 * alloc.c (xpalloc, Fgarbage_collect):
4204 * ccl.c (ccl_driver, resolve_symbol_ccl_program):
4205 * character.c (string_escape_byte8):
4206 * charset.c (read_hex):
4207 * data.c (cons_to_unsigned):
4208 * dispnew.c (update_frame_1):
4209 * doc.c (Fsubstitute_command_keys):
4210 * doprnt.c (doprnt):
4211 * editfns.c (hi_time, decode_time_components):
4212 * fileio.c (file_offset):
4213 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
4214 * font.c (font_intern_prop):
4215 * frame.c (x_set_alpha):
4216 * gtkutil.c (get_utf8_string):
4217 * indent.c (check_display_width):
4218 * keymap.c (Fkey_description):
4219 * lisp.h (FIXNUM_OVERFLOW_P, vcopy):
4220 * lread.c (read1):
4221 * minibuf.c (read_minibuf_noninteractive):
4222 * process.c (wait_reading_process_output):
4223 * search.c (Freplace_match):
4224 * window.c (get_phys_cursor_glyph):
4225 * xdisp.c (redisplay_internal):
4226 * xsmfns.c (smc_save_yourself_CB):
4227 Prefer < to > for range checks.
4228 * dispnew.c (sit_for): Don't mishandle NaNs.
4229 This fixes a bug introduced in the 2013-03-24 change.
4230 * editfns.c (decode_time_components): Don't hoist comparison.
4231 This fixes another bug introduced in the 2013-03-24 change.
4232
4233 2013-03-31 Dmitry Antipov <dmantipov@yandex.ru>
4234
4235 * frame.h (struct frame): Drop scroll_bottom_vpos
4236 member becaue all real users are dead long ago.
4237 (FRAME_SCROLL_BOTTOM_VPOS): Remove.
4238 * xdisp.c (redisplay_internal): Adjust user.
4239
4240 2013-03-30 Darren Ho <darren.hoo@gmail.com> (tiny change)
4241
4242 * nsmenu.m (showAtX:Y:for:): setLevel to
4243 NSPopUpMenuWindowLevel (Bug#13998).
4244
4245 2013-03-30 Jan Djärv <jan.h.d@swipnet.se>
4246
4247 * nsterm.h (ns_get_pending_menu_title, ns_check_menu_open)
4248 (ns_check_pending_open_menu): Declare.
4249
4250 * nsmenu.m (ns_update_menubar): Correct NSTRACE.
4251 (x_activate_menubar): Update the menu with title that matches
4252 ns_get_pending_menu_title, and call
4253 ns_check_pending_openmenu (Bug#12698).
4254 (menuWillOpen:): New method.
4255 (menuNeedsUpdate:): Add check for ! COCOA || OSX < 10.5 (Bug#12698).
4256
4257 * nsterm.m (menu_will_open_state, menu_mouse_point)
4258 (menu_pending_title): New varaibles.
4259 (ns_get_pending_menu_title, ns_check_menu_open)
4260 (ns_check_pending_open_menu): New functions.
4261
4262 2013-03-29 Dmitry Antipov <dmantipov@yandex.ru>
4263
4264 * indent.c (current_column_bol_cache): Remove leftover which is not
4265 used in Fmove_to_column any more.
4266 (current_column, scan_for_column): Adjust users.
4267 * keyboard.c (last_point_position_buffer, last_point_position_window):
4268 Remove leftovers which are not used for recording undo any more.
4269 (command_loop_1, syms_of_keyboard): Adjust users.
4270 * xdisp.c (last_max_ascent): Remove leftover which is not used in
4271 redisplay_window any more.
4272 (move_it_to): Adjust user.
4273
4274 2013-03-29 Juanma Barranquero <lekktu@gmail.com>
4275
4276 * makefile.w32-in ($(BLD)/filelock.$(O), $(BLD)/filelock.$(O)):
4277 Update dependencies.
4278
4279 2013-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4280
4281 * lisp.h (save_type, XSAVE_POINTER, set_save_pointer, XSAVE_INTEGER)
4282 (set_save_integer, XSAVE_OBJECT, XSAVE_VALUE): Move to avoid
4283 forward references.
4284
4285 2013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
4286
4287 * window.h (struct window): Replace hchild, vchild and buffer slots
4288 with the only contents slot. This is possible because each valid
4289 window may have either the child window (in vertical or horizontal
4290 combination) or buffer to display (for the leaf window). Using that,
4291 a lof of operations to traverse and/or change window hierarchies may
4292 be simplified. New member horizontal is used to distinguish between
4293 horizontal and vertical combinations of internal windows.
4294 (WINDOW_LEAF_P, WINDOW_HORIZONTAL_COMBINATION_P)
4295 (WINDOW_VERTICAL_COMBINATION_P): New macros.
4296 (WINDOW_VALID_P, WINDOW_LIVE_P): Adjust to match struct window changes.
4297 * window.c (wset_hchild, wset_vchild): Remove. Adjust all users.
4298 Use contents slot, not buffer, where appropriate.
4299 (wset_combination): New function.
4300 (wset_buffer): Add eassert.
4301 (Fframe_first_window): Simplify the loop reaching first window.
4302 (Fwindow_buffer): Use WINDOW_LEAF_P.
4303 (Fwindow_top_child): Use WINDOW_VERTICAL_COMBINATION_P.
4304 (Fwindow_left_child): Use WINDOW_HORIZONTAL_COMBINATION_P.
4305 (unshow_buffer): Convert initial debugging check to eassert.
4306 (replace_window, recombine_windows, Fdelete_other_windows_internal)
4307 (make_parent_window, window_resize_check, window_resize_apply)
4308 (resize_frame_windows, Fsplit_window_internal, Fdelete_window_internal)
4309 (Fset_window_configuration, delete_all_child_windows, save_window_save):
4310 Adjust to match struct window changes.
4311 (window_loop): Check for broken markers in CHECK_ALL_WINDOWS.
4312 (mark_window_cursors_off, count_windows, get_leaf_windows)
4313 (foreach_window_1): Simplify the loop.
4314 * alloc.c (mark_object): Do not check for the leaf window because
4315 internal windows has no glyph matrices anyway.
4316 * dispnew.c (clear_window_matrices, showing_window_margins_p)
4317 (allocate_matrices_for_window_redisplay, fake_current_matrices)
4318 (allocate_matrices_for_frame_redisplay, free_window_matrices)
4319 (build_frame_matrix_from_window_tree, mirror_make_current)
4320 (frame_row_to_window, mirror_line_dance, check_window_matrix_pointers)
4321 (update_window_tree, set_window_update_flags): Simplify the loop.
4322 (sync_window_with_frame_matrix_rows): Enforce live window.
4323 Use contents slot, not buffer, where appropriate.
4324 * frame.c (set_menu_bar_lines_1): Use WINDOW_VERTICAL_COMBINATION_P
4325 and WINDOW_HORIZONTAL_COMBINATION_P.
4326 (make_frame_visible_1): Simplify the loop.
4327 Use contents slot, not buffer, where appropriate.
4328 * xdisp.c (hscroll_window_tree, mark_window_display_accurate)
4329 (redisplay_windows, redisplay_mode_lines, update_cursor_in_window_tree)
4330 (expose_window_tree): Likewise.
4331 Use contents slot, not buffer, where appropriate.
4332 * textprop.c (get_char_property_and_overlay): Add CHECK_LIVE_WINDOW
4333 to avoid deleted windows. Use contents slot instead of buffer.
4334 * buffer.c, dispextern.h, editfns.c, fileio.c, font.c, fringe.c:
4335 * indent.c, insdel.c, keyboard.c, keymap.c, minibuf.c, msdos.c:
4336 * nsfns.m, nsmenu.m, nsterm.m, print.c, w32fns.c, w32menu.c, xfaces.c:
4337 * xfns.c, xmenu.c: Use contents slot, not buffer, where appropriate.
4338
4339 2013-03-28 Eli Zaretskii <eliz@gnu.org>
4340
4341 * w32fns.c (w32_wnd_proc) [ENABLE_CHECKING]: Add code to help
4342 identify the reasons for assertion violations in bug#14062 and
4343 similar ones.
4344 (Fx_show_tip): Fix compilation error under
4345 "--enable-check-lisp-object-type". (Bug#14073)
4346
4347 * image.c (g_error_free) [WINDOWSNT]: Add DEF_IMGLIB_FN.
4348 Reported by <rzl24ozi@gmail.com>.
4349
4350 2013-03-28 Dmitry Antipov <dmantipov@yandex.ru>
4351
4352 * xdisp.c (with_echo_area_buffer_unwind_data): Save window
4353 start marker...
4354 (unwind_with_echo_area_buffer): ...to restore it here.
4355 This is needed to ensure that...
4356 (redisplay_window): ...both window markers are valid here,
4357 which is verified by eassert.
4358 * editfns.c (save_excursion_save): Do not assume that
4359 selected_window always displays the buffer.
4360 * buffer.c (Fbuffer_swap_text): Adjust window start markers.
4361 Fix comment.
4362
4363 2013-03-27 Stefan Monnier <monnier@iro.umontreal.ca>
4364
4365 * casetab.c (init_casetab_once): Don't abuse the ascii eqv table for
4366 the upcase table.
4367
4368 2013-03-27 rzl24ozi <rzl24ozi@gmail.com> (tiny changes)
4369
4370 * image.c [WINDOWSNT]: Fix calls to DEF_IMGLIB_FN for SVG function.
4371
4372 2013-03-27 Eli Zaretskii <eliz@gnu.org>
4373
4374 * w32proc.c (IsValidLocale) [__GNUC__]: Don't declare prototype,
4375 since MinGW's w32api headers do. This avoids compiler warnings.
4376
4377 * w32.c (FSCTL_GET_REPARSE_POINT) [_MSC_VER || _W64]: Don't define
4378 if already defined.
4379
4380 2013-03-26 Eli Zaretskii <eliz@gnu.org>
4381
4382 * w32.c (_REPARSE_DATA_BUFFER): Condition by _MSVC and _W64.
4383
4384 2013-03-26 Jan Djärv <jan.h.d@swipnet.se>
4385
4386 * gtkutil.c (style_changed_cb): Check if frame is live and an
4387 X frame (Bug#14038).
4388
4389 2013-03-26 Eli Zaretskii <eliz@gnu.org>
4390
4391 * w32.c (_PROCESS_MEMORY_COUNTERS_EX) [_WIN32_WINNT < 0x0500]:
4392 Define only for _WIN32_WINNT less than 0x0500.
4393 (_ANONYMOUS_UNION, _ANONYMOUS_STRUCT) [!_W64]: Don't define for
4394 MinGW64.
4395 Move inclusion of time.h before sys/time.h, so that MinGW64 could
4396 see its own definitions of 'struct timeval' and 'struct timezone'.
4397
4398 Fix incompatibilities between MinGW.org and MinGW64 headers.
4399 * w32term.c (WCRANGE, GLYPHSET): Don't define if _W64 is defined.
4400
4401 * w32.c (REPARSE_DATA_BUFFER): Guard with
4402 MAXIMUM_REPARSE_DATA_BUFFER_SIZE being defined.
4403
4404 2013-03-25 Jan Djärv <jan.h.d@swipnet.se>
4405
4406 * xterm.c: Include X11/XKBlib.h
4407 (XTring_bell): Use XkbBell if HAVE_XKB (Bug#14041).
4408
4409 2013-03-24 Andreas Schwab <schwab@linux-m68k.org>
4410
4411 * alloc.c (xpalloc, Fgarbage_collect): Reorder conditions that are
4412 written backwards.
4413 * blockinput.h (input_blocked_p): Likewise.
4414 * bytecode.c (exec_byte_code): Likewise.
4415 * callproc.c (call_process_kill, call_process_cleanup)
4416 (Fcall_process): Likewise.
4417 * ccl.c (ccl_driver, resolve_symbol_ccl_program)
4418 (Fccl_execute_on_string): Likewise.
4419 * character.c (string_escape_byte8): Likewise.
4420 * charset.c (read_hex): Likewise.
4421 * cm.c (calccost): Likewise.
4422 * data.c (cons_to_unsigned): Likewise.
4423 * dired.c (directory_files_internal, file_name_completion):
4424 Likewise.
4425 * dispnew.c (scrolling_window, update_frame_1, Fsleep_for)
4426 (sit_for): Likewise.
4427 * doc.c (Fsubstitute_command_keys): Likewise.
4428 * doprnt.c (doprnt): Likewise.
4429 * editfns.c (hi_time, decode_time_components, Fformat): Likewise.
4430 * emacsgtkfixed.c: Likewise.
4431 * fileio.c (file_offset, Fwrite_region): Likewise.
4432 * floatfns.c (Fexpt, fmod_float): Likewise.
4433 * fns.c (larger_vector, make_hash_table, Fmake_hash_table):
4434 Likewise.
4435 * font.c (font_intern_prop): Likewise.
4436 * frame.c (x_set_alpha): Likewise.
4437 * gtkutil.c (get_utf8_string): Likewise.
4438 * indent.c (check_display_width): Likewise.
4439 * intervals.c (create_root_interval, rotate_right, rotate_left)
4440 (split_interval_right, split_interval_left)
4441 (adjust_intervals_for_insertion, delete_node)
4442 (interval_deletion_adjustment, adjust_intervals_for_deletion)
4443 (merge_interval_right, merge_interval_left, copy_intervals)
4444 (set_intervals_multibyte_1): Likewise.
4445 * keyboard.c (gobble_input, append_tool_bar_item): Likewise.
4446 * keymap.c (Fkey_description): Likewise.
4447 * lisp.h (FIXNUM_OVERFLOW_P, vcopy): Likewise.
4448 * lread.c (openp, read_integer, read1, string_to_number):
4449 Likewise.
4450 * menu.c (ensure_menu_items): Likewise.
4451 * minibuf.c (read_minibuf_noninteractive): Likewise.
4452 * print.c (printchar, strout): Likewise.
4453 * process.c (create_process, Faccept_process_output)
4454 (wait_reading_process_output, read_process_output, send_process)
4455 (wait_reading_process_output): Likewise.
4456 * profiler.c (make_log, handle_profiler_signal): Likewise.
4457 * regex.c (re_exec): Likewise.
4458 * regex.h: Likewise.
4459 * search.c (looking_at_1, Freplace_match): Likewise.
4460 * sysdep.c (get_child_status, procfs_ttyname)
4461 (procfs_get_total_memory): Likewise.
4462 * systime.h (EMACS_TIME_VALID_P): Likewise.
4463 * term.c (dissociate_if_controlling_tty): Likewise.
4464 * window.c (get_phys_cursor_glyph): Likewise.
4465 * xdisp.c (init_iterator, redisplay_internal, redisplay_window)
4466 (try_window_reusing_current_matrix, try_window_id, pint2hrstr):
4467 Likewise.
4468 * xfns.c (Fx_window_property): Likewise.
4469 * xmenu.c (set_frame_menubar): Likewise.
4470 * xselect.c (x_get_window_property, x_handle_dnd_message):
4471 Likewise.
4472 * xsmfns.c (smc_save_yourself_CB): Likewise.
4473 * xterm.c (x_scroll_bar_set_handle): Likewise.
4474
4475 2013-03-24 Dmitry Antipov <dmantipov@yandex.ru>
4476
4477 * xfaces.c (Finternal_face_x_get_resource): Allow 3rd (frame) argument
4478 to be optional or nil. Adjust comment and convert it to docstring.
4479 * xselect.c (Fx_send_client_event): Rename to Fx_send_client_message.
4480 * frame.c (display_x_get_resource, Fx_get_resource): Break long line.
4481
4482 2013-03-24 Paul Eggert <eggert@cs.ucla.edu>
4483
4484 Static checking by GCC 4.8-20130319.
4485 * image.c (gif_load): Assume pass < 3 to pacify GCC.
4486 * process.c (Fset_process_datagram_address)
4487 (Fmake_network_process): Check get_lisp_to_sockaddr_size return value.
4488 * xdisp.c (get_char_face_and_encoding):
4489 (get_glyph_face_and_encoding): Ensure that *CHAR2B is initialized.
4490 (get_glyph_face_and_encoding): Prepare face before possibly using it.
4491 (get_per_char_metric): Don't use CHAR2B if it might not be initialized.
4492
4493 2013-03-24 Ken Brown <kbrown@cornell.edu>
4494
4495 * w32fns.c (emacs_abort) [CYGWIN]: Define `_open' as a macro to
4496 fix compilation on 64-bit Cygwin, where underscores are not
4497 automatically prepended.
4498
4499 * w32term.c (w32_initialize): Silence compiler warning.
4500
4501 2013-03-23 Eli Zaretskii <eliz@gnu.org>
4502
4503 * w32term.c (w32fullscreen_hook): Use FRAME_NORMAL_WIDTH,
4504 FRAME_NORMAL_HEIGHT, and FRAME_PREV_FSMODE, instead of static
4505 variables, to save and restore frame dimensions.
4506 Use FRAME_NORMAL_LEFT and FRAME_NORMAL_TOP to restore frame position
4507 after returning from a 'fullscreen' configuration.
4508 use SendMessage instead of PostMessage to send the SC_RESTORE message,
4509 to avoid races between the main thread and the input thread.
4510
4511 * w32term.h (struct w32_output): New members normal_width,
4512 normal_height, normal_top, normal_left, and prev_fsmode.
4513 (FRAME_NORMAL_WIDTH, FRAME_NORMAL_HEIGHT, FRAME_NORMAL_TOP)
4514 (FRAME_NORMAL_LEFT, FRAME_PREV_FSMODE): New macros to access these
4515 members of a frame.
4516
4517 * w32term.c (w32fullscreen_hook): Record last value of the frame's
4518 'fullscreen' parameter. Always record previous width and height
4519 of the frame, except when switching out of maximized modes, so
4520 that they could be restored correctly, instead of resetting to the
4521 default frame dimensions. Send SC_RESTORE command to the frame,
4522 unless we are going to send SC_MAXIMIZE, to restore the frame
4523 resize hints in the mouse pointer shown by the window manager.
4524 (Bug#14032)
4525
4526 * frame.c (get_frame_param): Now extern for WINDOWSNT as well.
4527
4528 * lisp.h (get_frame_param): Adjust conditions for prototype
4529 declaration.
4530
4531 2013-03-22 Ken Brown <kbrown@cornell.edu>
4532
4533 * unexcw.c: Drop unneeded inclusion of w32common.h.
4534 (report_sheap_usage): Declare.
4535 (read_exe_header): Add magic numbers for x86_64.
4536 (fixup_executable): Fix printf format specifier for unsigned long
4537 argument.
4538
4539 2013-03-22 Dmitry Antipov <dmantipov@yandex.ru>
4540
4541 * frame.h (struct frame): Put menu_bar_window under #ifdef
4542 because this member is not needed when X toolkit is in use.
4543 (fset_menu_bar_window):
4544 * dispnew.c (clear_current_matrices, clear_desired_matrices)
4545 (free_glyphs, update_frame):
4546 * xdisp.c (expose_frame): Likewise.
4547 (display_menu_bar): Likewise. Remove redundant eassert.
4548 * window.h (WINDOW_MENU_BAR_P): Always define to 0 if X
4549 toolkit is in use.
4550
4551 2013-03-21 Paul Eggert <eggert@cs.ucla.edu>
4552
4553 Use functions and constants to manipulate Lisp_Save_Value objects.
4554 This replaces code that used macros and strings and token-pasting.
4555 The change makes the C source a bit easier to follow,
4556 and shrinks the Emacs executable a bit.
4557 * alloc.c: Verify some properties of Lisp_Save_Value's representation.
4558 (make_save_value): Change 1st arg from string to enum. All callers
4559 changed.
4560 (INTX): Remove.
4561 (mark_object): Use if, not #if, for GC_MARK_STACK.
4562 * lisp.h (SAVE_VALUEP, XSAVE_VALUE, XSAVE_POINTER, XSAVE_INTEGER)
4563 (XSAVE_OBJECT): Now functions, not macros.
4564 (STRING_BYTES_BOUND): Now just a macro, not a constant too;
4565 the constant was never used.
4566 (SAVE_SLOT_BITS, SAVE_VALUE_SLOTS, SAVE_TYPE_BITS, SAVE_TYPE_INT_INT)
4567 (SAVE_TYPE_INT_INT_INT, SAVE_TYPE_OBJ_OBJ, SAVE_TYPE_OBJ_OBJ_OBJ)
4568 (SAVE_TYPE_OBJ_OBJ_OBJ_OBJ, SAVE_TYPE_PTR_INT, SAVE_TYPE_PTR_OBJ)
4569 (SAVE_TYPE_PTR_PTR, SAVE_TYPE_PTR_PTR_OBJ, SAVE_TYPE_MEMORY):
4570 New constants.
4571 (struct Lisp_Save_Value): Replace members area, type0, type1, type2,
4572 type3 with a single member save_type. All uses changed.
4573 (save_type, set_save_pointer, set_save_integer): New functions.
4574 * print.c (PRINTX): Remove.
4575
4576 * alloc.c: Remove redundant static declarations.
4577
4578 2013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
4579
4580 * window.h (struct window): Convert left_col, top_line, total_lines
4581 and total_cols from Lisp_Objects to integers. Adjust comments.
4582 (wset_left_col, wset_top_line, wset_total_cols, wset_total_lines):
4583 Remove.
4584 (WINDOW_TOTAL_COLS, WINDOW_TOTAL_LINES, WINDOW_LEFT_EDGE_COL)
4585 (WINDOW_TOP_EDGE_LINE): Drop Lisp_Object to integer conversion.
4586 * dispnew.c, frame.c, w32fns.c, window.c, xdisp.c, xfns.c:
4587 Adjust users where appropriate.
4588
4589 2013-03-20 Dmitry Antipov <dmantipov@yandex.ru>
4590
4591 * frame.h (struct frame): Drop resx and resy because the same data is
4592 available from window system-specific output context. Adjust users.
4593 (default_pixels_per_inch_x, default_pixels_per_inch_y):
4594 New functions to provide defaults when no window system available.
4595 (FRAME_RES_X, FRAME_RES_Y): New macros.
4596 (NUMVAL): Move from xdisp.c.
4597 * font.c (font_pixel_size, font_find_for_lface, font_open_for_lface)
4598 (Ffont_face_attributes, Fopen_font):
4599 * image.c (gs_load):
4600 * w32font.c (fill_in_logfont):
4601 * xdisp.c (calc_pixel_width_or_height):
4602 * xfaces.c (Fx_family_fonts, set_lface_from_font): Use them.
4603 * xsettings.c (apply_xft_settings): Drop frame loop and adjust comment.
4604
4605 2013-03-20 Kenichi Handa <handa@gnu.org>
4606
4607 * coding.c (syms_of_coding): Initialize disable_ascii_optimization
4608 to 1 (temporary workaround until a bug related to ASCII
4609 optimization is fixed).
4610
4611 2013-03-19 Dmitry Antipov <dmantipov@yandex.ru>
4612
4613 * window.c (Fwindow_combination_limit, Fset_window_combination_limit):
4614 Signal error if window is not internal. Adjust docstring.
4615 (delete_all_child_windows): Use combination_limit to save the buffer.
4616 (Fset_window_configuration): Adjust accordingly.
4617 * print.c (syms_of_print): Initialize debugging output not here...
4618 (init_print_once): ...but in a new function here.
4619 * lisp.h (init_print_once): Add prototype.
4620 * emacs.c (main): Add call to init_print_once. Adjust comments.
4621
4622 2013-03-18 Dmitry Antipov <dmantipov@yandex.ru>
4623
4624 * window.c (window_resize_check, window_resize_apply)
4625 (window_from_coordinates, recombine_windows, set_window_buffer)
4626 (make_parent_window, Fwindow_resize_apply, resize_frame_windows)
4627 (Fsplit_window_internal, Fdelete_window_internal)
4628 (freeze_window_starts): Use bool for booleans.
4629 * window.h (window_frame_coordinates, resize_frame_windows)
4630 (freeze_window_starts, set_window_buffer): Adjust prototypes.
4631
4632 2013-03-17 Stefan Monnier <monnier@iro.umontreal.ca>
4633
4634 * dispnew.c (bitch_at_user): Use `user-error'.
4635
4636 2013-03-17 Ken Brown <kbrown@cornell.edu>
4637
4638 * dispextern.h (RGB_PIXEL_COLOR): Move here from image.c. Use it
4639 as return type of image_background. (Bug#13981)
4640 * image.c (RGB_PIXEL_COLOR): Move to dispextern.h.
4641
4642 2013-03-16 Jan Djärv <jan.h.d@swipnet.se>
4643
4644 * nsterm.m (updateFrameSize:): Change resize increments if needed.
4645 (ns_select): Don't return with result uninitialized.
4646
4647 * nsterm.h (EmacsSavePanel, EmacsOpenPanel): Add getFilename
4648 and getDirectory.
4649
4650 * nsfns.m (ns_filename_from_panel, ns_directory_from_panel):
4651 New functions.
4652 (Fns_read_file_name): ret is BOOL. If ! dir_only_p, don't choose
4653 directories. If filename is nil, get directory name (Bug#13932).
4654 Use getFilename and getDirectory.
4655 (getFilename, getDirectory): New methods for EmacsSavePanel and
4656 EmacsOpenPanel.
4657 (ok:): In EmacsOpenPanel, if we can't choose directories, just return.
4658
4659 2013-03-15 Paul Eggert <eggert@cs.ucla.edu>
4660
4661 * coding.c (decode_coding_gap): Fix typo caught by static checking.
4662
4663 2013-03-15 Kenichi Handa <handa@gnu.org>
4664
4665 * insdel.c (insert_from_gap): New arg text_at_gap_tail.
4666 (adjust_after_replace): Make it back to static. Delete the third
4667 arg text_at_gap_tail. Cancel the code for handling it.
4668
4669 * coding.h (struct coding_system): New member eol_seen.
4670
4671 * coding.c (detect_ascii): New function.
4672 (detect_coding): Set coding->head_ascii and coding->eol_seen only
4673 when the source bytes are actually scanned. On detecting for
4674 coding_category_utf_8_auto, call detect_ascii instead of scanning
4675 source bytes directly.
4676 (produce_chars): Call insert_from_gap with the new arg 0.
4677 (encode_coding): Likewise.
4678 (decode_coding_gap): Control ASCII optimization by the variable
4679 disable_ascii_optimization instead of #ifndef .. #endif.
4680 Deccode EOL format according to coding->eol_seen.
4681 (syms_of_coding): Declare disable-ascii-optimization as a Lisp
4682 variable.
4683
4684 * lisp.h (adjust_after_replace): Cancel externing it.
4685 (insert_from_gap): Adjust prototype.
4686
4687 2013-03-15 Eli Zaretskii <eliz@gnu.org>
4688
4689 * w32term.c (w32fullscreen_hook): Swap FULLSCREEN_BOTH and
4690 FULLSCREEN_MAXIMIZED. (Bug#13935)
4691
4692 2013-03-15 Dmitry Antipov <dmantipov@yandex.ru>
4693
4694 * region-cache.c (find_cache_boundary, move_cache_gap)
4695 (insert_cache_boundary, delete_cache_boundaries, set_cache_region):
4696 Simplify debugging check and convert to eassert. Adjust comment.
4697 (pp_cache): Put under ENABLE_CHECKING.
4698
4699 2013-03-14 Eli Zaretskii <eliz@gnu.org>
4700
4701 * w32term.c (w32_read_socket) <WM_WINDOWPOSCHANGED>: Remove old
4702 and incorrect code. Treat WM_WINDOWPOSCHANGED like WM_ACTIVATE
4703 and WM_ACTIVATEAPP.
4704 (w32fullscreen_hook): If the frame is visible, reset
4705 f->want_fullscreen flag after changing the frame size. If the
4706 frame is not visible, set f->want_fullscreen to FULLSCREEN_WAIT.
4707 (Bug#13953)
4708
4709 2013-03-13 Daniel Colascione <dancol@dancol.org>
4710
4711 * emacs.c (main): Call syms_of_cygw32 on CYGWIN non-NTGUI builds
4712 too so that these builds can use Cygwin's file conversion
4713 functions. (We've been building and linking cygw32.o all along
4714 and just not using it.)
4715
4716 2013-03-13 Paul Eggert <eggert@cs.ucla.edu>
4717
4718 File synchronization fixes (Bug#13944).
4719 * Makefile.in (LIB_FDATASYNC): New macro.
4720 (LIBES): Use it.
4721 * conf_post.h (BSD_SYSTEM, BSD_SYSTEM_AHB): Remove; no longer needed.
4722 * fileio.c (Fwrite_region, write_region_inhibit_fsync):
4723 Don't worry about HAVE_FSYNC, since a substitute fsync is
4724 available if the system lacks one.
4725 (Fwrite_regin): Retry fsync if interrupted.
4726
4727 2013-03-13 Eli Zaretskii <eliz@gnu.org>
4728
4729 * w32term.c (w32_read_socket): If the Emacs frame is being
4730 activated, call w32fullscreen_hook, to make sure the new frame
4731 dimensions are in effect. (Bug#13937)
4732
4733 2013-03-13 Dmitry Antipov <dmantipov@yandex.ru>
4734
4735 * xdisp.c (init_iterator): Simplify because both character and byte
4736 positions are either specified or -1. Add eassert. Adjust comment.
4737 * window.c (Fscroll_other_window): Use SET_PT_BOTH because both
4738 character and byte positions can be obtained from marker.
4739
4740 2013-03-13 Paul Eggert <eggert@cs.ucla.edu>
4741
4742 Static checking by Sun C 5.12.
4743 * alloc.c (buffer_memory_full) [REL_ALLOC]:
4744 * bytecode.c (exec_byte_code):
4745 * dispnew.c (init_display):
4746 * eval.c (error):
4747 * fileio.c (Fsubstitute_in_file_name):
4748 * keyboard.c (Fevent_convert_list):
4749 * keymap.c (Fsingle_key_description):
4750 * term.c (maybe_fatal, fatal):
4751 * xfns.c (Fx_display_backing_store, Fx_display_visual_class):
4752 * xsmfns.c (Fhandle_save_session):
4753 Omit unreachable code.
4754 * keymap.c (map_keymap_char_table_item): Cast void * to
4755 a function pointer type; the C Standard requires this.
4756
4757 * sysdep.c: Remove a use of BSD_SYSTEM, which I'm trying to phase out.
4758 Include <sys/param.h> unconditionally, as that works elsewhere and
4759 is simpler here. Include <sys/sysctl.h> if DARWIN_OS ||
4760 __FreeBSD__, not if BSD_SYSTEM, since it's needed only for Darwin
4761 and FreeBSD now.
4762
4763 See ChangeLog.12 for earlier changes.
4764
4765 ;; Local Variables:
4766 ;; coding: utf-8
4767 ;; End:
4768
4769 Copyright (C) 2011-2013 Free Software Foundation, Inc.
4770
4771 This file is part of GNU Emacs.
4772
4773 GNU Emacs is free software: you can redistribute it and/or modify
4774 it under the terms of the GNU General Public License as published by
4775 the Free Software Foundation, either version 3 of the License, or
4776 (at your option) any later version.
4777
4778 GNU Emacs is distributed in the hope that it will be useful,
4779 but WITHOUT ANY WARRANTY; without even the implied warranty of
4780 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4781 GNU General Public License for more details.
4782
4783 You should have received a copy of the GNU General Public License
4784 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.