1 2012-07-10 Glenn Morris <rgm@gnu.org>
3 Stop ns builds setting the EMACSLOADPATH environment variable.
4 * nsterm.m (ns_load_path): Rename from ns_init_paths.
5 Now it does not set EMACSLOADPATH, just returns the load-path string.
6 * nsterm.h: Update accordingly.
7 * lread.c [HAVE_NS]: Include nsterm.h.
8 (init_lread) [HAVE_NS]: Use ns_load_path.
9 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
11 2012-07-09 Glenn Morris <rgm@gnu.org>
13 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
14 since the included bsd-common.h does so.
16 Stop ns builds setting the EMACSPATH environment variable.
17 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
18 (ns_init_paths): Do not set EMACSPATH.
19 * nsterm.h (ns_exec_path): Add it.
20 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
23 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
25 2012-07-09 Paul Eggert <eggert@cs.ucla.edu>
27 * process.c (wait_reading_process_output): 'waitchannels' was unset
28 when read_kbd || !NILP (wait_for_cell); fix this.
30 Add GCC-style 'const' attribute to functions that can use it.
31 * character.h (char_resolve_modifier_mask):
32 * keyboard.h (make_ctrl_char):
33 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
34 (init_character_once, next_almost_prime, init_fns, init_image)
35 (flush_pending_output, init_sound):
36 * mem-limits.h (start_of_data):
37 * menu.h (finish_menu_items):
39 * emacs.c (DEFINE_DUMMY_FUNCTION):
40 Declare the dummy function with ATTRIBUTE_CONST.
41 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
42 Add decls with ATTRIBUTE_CONST.
44 Minor improvements to make_formatted_string.
45 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
46 where int is good enough, as vsprintf returns an int.
47 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
49 2012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
51 Use make_formatted_string to avoid double length calculation.
52 * lisp.h (make_formatted_string): New prototype.
53 * alloc.c (make_formatted_string): New function.
54 * buffer.c (Fgenerate_new_buffer_name): Use it.
55 * dbus.c (syms_of_dbusbind): Likewise.
56 * editfns.c (Fcurrent_time_zone): Likewise.
57 * filelock.c (get_boot_time): Likewise.
58 * frame.c (make_terminal_frame, set_term_frame_name)
59 (x_report_frame_params): Likewise.
60 * image.c (gs_load): Likewise.
61 * minibuf.c (get_minibuffer): Likewise.
62 * msdos.c (dos_set_window_size): Likewise.
63 * process.c (make_process): Likewise.
64 * xdisp.c (ensure_echo_area_buffers): Likewise.
65 * xsettings.c (apply_xft_settings): Likewise.
67 2012-07-09 Glenn Morris <rgm@gnu.org>
69 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
70 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
71 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
72 * nsterm.h (ns_etc_directory): Add it.
73 * callproc.c [HAVE_NS]: Include nsterm.h.
74 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
76 2012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
78 Move marker debugging code under MARKER_DEBUG.
79 * marker.c (MARKER_DEBUG): Move marker debugging code under
80 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
81 for bootstrap with --enable-checking (~3x slowdown reported
82 by Juanma Barranquero <lekktu@gmail.com>).
83 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
85 2012-07-08 Paul Eggert <eggert@cs.ucla.edu>
87 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
88 See <http://bugs.gnu.org/11825#29>.
90 2012-07-08 Eli Zaretskii <eliz@gnu.org>
92 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
93 has no font, use the frame's font. (Bug#11813)
94 (display_line): Add commentary about displaying truncation glyphs
96 (produce_special_glyphs): Move here from term.c.
98 * term.c (produce_special_glyphs): Move to xdisp.c.
100 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
103 2012-07-07 Andreas Schwab <schwab@linux-m68k.org>
105 * xdisp.c (display_line): Avoid warning about implicit declaration
108 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
110 * lisp.h: Remove empty conditional.
112 2012-07-07 Paul Eggert <eggert@cs.ucla.edu>
114 * lread.c (load_path_check): Now static.
116 Fix some minor --with-ns problems found by static checking.
117 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
118 (x_set_font) [!HAVE_X_WINDOWS]:
119 * image.c (xpm_load_image) [HAVE_NS]:
120 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
121 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
123 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
124 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
125 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
126 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
127 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
128 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
129 Fix pointer signedness problem.
130 * xfaces.c (FRAME_X_FONT_TABLE):
131 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
133 2012-07-07 Glenn Morris <rgm@gnu.org>
135 * lread.c (load_path_check): New function, split from init_lread.
136 (init_lread): Reorganize. Motivation:
137 If EMACSLOADPATH is set, check/warn about that rather than the
138 defaults, which we are not going to use. Hence we can remove
139 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
140 Don't warn if site-lisp directories are missing.
141 If not installed, start from a blank load-path, since
142 PATH_LOADSEARCH refers to the eventual installation directories.
144 2012-07-07 Eli Zaretskii <eliz@gnu.org>
146 Support truncation and continuation glyphs on GUI frames, when
147 fringes are disabled. (Bug#11832)
148 * xdisp.c (init_iterator): Get dimensions of truncation and
149 continuation glyphs even if on GUI frames. Adjust
150 it->last_visible_x on GUI frames when the left or right fringes,
152 (start_display, move_it_in_display_line_to): Handle the case of a
153 GUI frame without a fringe to display continuation or truncation
155 (insert_left_trunc_glyphs): Support GUI frames: make sure
156 truncation glyphs overwrite enough glyphs from the current line to
157 have sufficient space in pixels.
158 (display_line): Support truncation and continuation glyphs on GUI
159 frames. If some spare pixels are left on the line after inserting
160 the truncation glyphs, fill that space with a stretch glyph of a
161 suitably computed width.
163 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
164 produce_glyphs, to support GUI sessions.
166 2012-07-07 Paul Eggert <eggert@cs.ucla.edu>
168 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
170 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
172 Do not require float-time's arg to fit in time_t (Bug#11825).
173 This works better on hosts where time_t is unsigned, and where
174 float-time is applied to the (negative) difference between two times.
175 * editfns.c (decode_time_components): Last arg is now double *,
176 not int *, and means to store all the result as a double, without
177 worrying about whether the seconds part fits in time_t.
179 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
181 (Ffloat_time): Do not fail merely because the specified time falls
182 outside of time_t range.
184 2012-07-07 Glenn Morris <rgm@gnu.org>
186 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
187 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
188 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
190 2012-07-07 Juanma Barranquero <lekktu@gmail.com>
192 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
195 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
197 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
199 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
200 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
201 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
202 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
203 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
204 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
206 * xfont.c (compare_font_names): Redo to omit the need for casts.
208 2012-07-06 Andreas Schwab <schwab@linux-m68k.org>
210 * xfns.c (Fx_change_window_property): Doc fix.
211 * w32fns.c (Fx_change_window_property): Doc fix.
213 * w32fns.c (Fx_window_property): Accept the same arguments as the
214 X Windows version. Doc fix.
215 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
217 2012-07-06 Juanma Barranquero <lekktu@gmail.com>
218 Eli Zaretskii <eliz@gnu.org>
220 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
221 Windows-specific code from nt/config.nt moved here.
222 Obsolete settings removed.
224 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
226 * process.c: Avoid unnecessary calls to gettime.
227 (wait_reading_process_output): Don't get the time of day
228 when gobbling data immediately and not waiting, as there's no need
229 for it in that case. This removes a FIXME.
231 2012-07-06 Jan Djärv <jan.h.d@swipnet.se>
233 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
234 is defined (Bug#11768).
236 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
238 Fix marker debugging code.
239 * marker.c (byte_char_debug_check): Do not perform the check
240 if buffer is not multibyte.
241 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
242 Call byte_char_debug_check with correct arguments.
244 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
246 Compile marker debugging code only if ENABLE_CHECKING is defined.
247 * marker.c (byte_char_debug_check, count_markers):
248 Use only if ENABLE_CHECKING is defined.
249 (byte_debug_flag): Remove.
250 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
251 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
253 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
255 Avoid code repetition in marker-related functions.
256 * marker.c (attach_marker): New function.
257 (Fset_marker, set_marker_restricted, set_marker_both)
258 (set_marker_restricted_both): Use it.
259 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
260 Consistently rename charno to charpos.
261 (marker_position): Add eassert.
262 (marker_byte_position): Convert to eassert.
264 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
266 Simplify list operations in unchain_overlay and unchain_marker.
267 * buffer.c (unchain_overlay): Simplify. Add comment.
268 * marker.c (unchain_marker): Simplify. Fix comments.
270 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
272 Introduce fast path for the widely used marker operation.
273 * alloc.c (build_marker): New function.
274 * lisp.h (build_marker): New prototype.
275 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
276 * composite.c (autocmp_chars): Likewise.
277 * editfns.c (buildmark): Remove.
278 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
279 (save_restriction_save): Use build_marker.
280 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
281 * window.c (save_window_save): Likewise.
283 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
285 Do not use Fdelete_overlay in delete_all_overlays
286 to avoid redundant calls to unchain_overlay.
287 * buffer.c (drop_overlay): New function.
288 (delete_all_overlays, Fdelete_overlay): Use it.
289 * minibuf.c (get_minibuffer): Fix comment.
291 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
293 Port to OpenBSD 5.1 amd64.
294 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
295 This is needed for OpenBSD, and should be harmless on all BSD systems.
296 Also, include <sys/sysctl.h>, as it should be available on all
297 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
298 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
299 use p_pid member, not kp_proc.pid.
301 2012-07-06 Glenn Morris <rgm@gnu.org>
303 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
305 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
307 More xmalloc and related cleanup.
308 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
309 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
310 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
311 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
312 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
313 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
314 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
315 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
316 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
318 Omit needless casts involving void * pointers and allocation.
319 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
320 as the former is more robust if P's type is changed.
321 Prefer xzalloc to xmalloc + memset 0.
322 Simplify malloc-or-realloc to realloc.
323 Don't worry about xmalloc returning a null pointer.
324 Prefer xstrdup to xmalloc + strcpy.
325 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
327 * keyboard.c (apply_modifiers_uncached): Prefer local array to
328 alloca of a constant.
330 2012-07-05 Eli Zaretskii <eliz@gnu.org>
332 * xdisp.c (display_line): Fix horizontal pixel coordinates when
333 hscroll is larger than the line width. Fixes long and futile
334 looping inside extend_face_to_end_of_line (on a TTY) producing
335 glyphs that are not needed and thrown away.
337 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
339 * marker.c (set_marker_restricted_both): Simplify by using
342 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
344 * editfns.c (region_limit): Simplify by using clip_to_bounds.
346 2012-07-05 Jan Djärv <jan.h.d@swipnet.se>
348 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
349 not defined (Bug#11768).
350 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
351 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
352 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
353 followed by gtk_box_set_homogeneous (Bug#11768).
354 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
355 (update_theme_scrollbar_width, xg_create_scroll_bar):
356 Use gtk_scrollbar_new (Bug#11768).
357 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
358 (is_box_type): New function (Bug#11768).
359 (xg_tool_item_stale_p): Call is_box_type.
360 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
361 with default display (Bug#11768).
363 2012-07-05 Eli Zaretskii <eliz@gnu.org>
365 * xdisp.c (window_hscroll_limited): New function.
366 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
367 coordinates when window's hscroll is set to insanely large
370 2012-07-05 Juanma Barranquero <lekktu@gmail.com>
372 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
373 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
375 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
378 * lisp.h (xzalloc): New prototype. Omit needless casts.
379 * alloc.c (xzalloc): New function. Omit needless casts.
380 * charset.c: Omit needless casts. Convert all calls to
381 xmalloc with following memset to xzalloc.
382 * dispnew.c: Likewise.
383 * fringe.c: Likewise.
387 * w32fns.c: Likewise.
388 * w32font.c: Likewise.
389 * w32term.c: Likewise.
390 * xfaces.c: Likewise.
393 * atimer.c: Omit needless casts.
394 * buffer.c: Likewise.
395 * callproc.c: Likewise.
397 * coding.c: Likewise.
398 * composite.c: Likewise.
400 * doprnt.c: Likewise.
401 * editfns.c: Likewise.
404 * filelock.c: Likewise.
406 * gtkutil.c: Likewise.
407 * keyboard.c: Likewise.
410 * minibuf.c: Likewise.
413 * process.c: Likewise.
414 * region-cache.c: Likewise.
415 * search.c: Likewise.
416 * sysdep.c: Likewise.
417 * termcap.c: Likewise.
418 * terminal.c: Likewise.
419 * tparam.c: Likewise.
420 * w16select.c: Likewise.
422 * w32reg.c: Likewise.
423 * w32select.c: Likewise.
424 * w32uniscribe.c: Likewise.
425 * widget.c: Likewise.
429 * xselect.c: Likewise.
431 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
433 * fileio.c (time_error_value): Check the right error number.
434 Problem reported by Troels Nielsen in
435 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
437 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
439 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
440 This should be fixed in a better way; see Eli Zaretskii in
441 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
442 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
444 * fileio.c (time_error_value): Rename from special_mtime.
445 The old name's problems were noted by Eli Zaretskii in
446 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
448 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
449 This variable's comment says Emacs needs at least one GDB-visible
450 symbol of type enum pvec_type, to work around GDB problems.
451 The symbol's value doesn't matter.
453 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
454 that causes compilation to fail on pre-C99 compilers.
456 2012-07-04 Juanma Barranquero <lekktu@gmail.com>
458 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
459 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
461 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
463 * buffer.c (init_buffer_once): Fix initialization of
464 headers for buffer_defaults and buffer_local_symbols.
465 Reported by Juanma Barranquero <lekktu@gmail.com>.
467 2012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
469 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
470 * lisp.h (enum pvec_type): Use fewer bits.
471 (PSEUDOVECTOR_SIZE_BITS): New constant.
472 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
473 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
475 (PSEUDOVECTOR_TYPEP): New macro.
476 (TYPED_PSEUDOVECTORP): Use it.
477 * fns.c (internal_equal): Adapt code to extract pvectype.
478 * emacs.c (gdb_pvec_type): Update type.
479 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
480 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
481 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
482 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
483 (sweep_vectors): Use it. Use local var `total_bytes' instead of
484 abusing vector->header.next.nbytes.
485 (live_vector_p): Use PVEC_TYPE.
486 (mark_object): Adapt code to extract pvectype. Use switch.
488 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
490 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
491 Tighten new eassert a bit.
493 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
495 Fix compilation with --enable-gcc-warnings and -O1
497 * doprnt.c (doprnt): Change type of tem to int, initialize
498 to avoid compiler warning. Add eassert.
499 * search.c (simple_search): Initialize match_byte to avoid
500 compiler warning. Add eassert.
502 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
504 Avoid weird behavior with large horizontal scrolls.
505 Without this change, for example, large hscroll values would
506 mess up Emacs's display on Fedora 15 x86, presumably due to
507 overflows in int calculations in the display code.
508 Also, if buffers had long lines, Emacs would freeze.
509 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
510 (set_window_hscroll): New function, containing the old guts of
511 Fset_window_hscroll. Return the clipped value.
512 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
513 This avoids the need to check against PTRDIFF_MAX.
515 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
517 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
519 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
521 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
523 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
524 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
525 since GCC 4.4.6 issues a bogus warning for them.
527 Fix bugs in file timestamp newness comparisons.
528 * fileio.c (Ffile_newer_than_file_p):
529 * lread.c (Fload): Use full timestamp resolution of files,
530 not just the 1-second resolution, so that files that are only
531 slightly newer still count as newer.
532 * fileio.c (Ffile_newer_than_file_p): Don't assume file
533 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
535 2012-07-03 Paul Eggert <eggert@cs.ucla.edu>
537 * fileio.c: Improve handling of file time marker. (Bug#11852)
538 (special_mtime): New function.
539 (Finsert_file_contents, Fverify_visited_file_modtime):
540 Use it to set special mtime values consistently.
542 2012-07-03 Andreas Schwab <schwab@linux-m68k.org>
544 * fileio.c (Finsert_file_contents): Properly handle st_mtime
545 marker for non-existing file. (Bug#11852)
547 2012-07-03 Glenn Morris <rgm@gnu.org>
549 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
550 and did not make it into globals.h).
552 2012-07-03 Tom Tromey <tromey@redhat.com>
554 * window.c (Fset_window_margins, Fset_window_fringes)
555 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
556 * textprop.c (Fprevious_property_change): No longer static.
557 * syntax.c (Fsyntax_table_p): No longer static.
558 * process.c (Fget_process, Fprocess_datagram_address): No longer
560 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
561 * keyboard.c (Fcommand_execute): No longer static.
563 * insdel.c (Fcombine_after_change_execute): No longer static.
564 * image.c (Finit_image_library): No longer static.
565 * fileio.c (Fmake_symbolic_link): No longer static.
566 * eval.c (Ffetch_bytecode): No longer static.
567 * editfns.c (Fuser_full_name): No longer static.
568 * doc.c (Fdocumentation_property, Fsnarf_documentation):
570 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
572 * dired.c (Ffile_attributes): No longer static.
573 * composite.c (Fcomposition_get_gstring): No longer static.
574 * callproc.c (Fgetenv_internal): No longer static.
576 * ccl.h: Remove EXFUNs.
577 * buffer.h: Remove EXFUNs.
578 * dispextern.h: Remove EXFUNs.
579 * intervals.h: Remove EXFUNs.
580 * fontset.h: Remove EXFUN.
581 * font.h: Remove EXFUNs.
582 * dosfns.c (system_process_attributes): Remove EXFUN.
583 * keymap.h: Remove EXFUNs.
584 * lisp.h: Remove EXFUNs.
585 * w32term.h: Remove EXFUNs.
586 * window.h: Remove EXFUNs.
587 * xsettings.h: Remove EXFUN.
588 * xterm.h: Remove EXFUN.
590 2012-07-03 Glenn Morris <rgm@gnu.org>
592 * lisp.h (Frandom): Make it visible to C.
593 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
594 buffer for invisible buffers. (Bug#1229)
596 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
598 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
599 values which aren't power of 2.
600 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
601 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
604 2012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
606 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
608 * alloc.c (mark_object): Revert part of last patch to use `switch'.
610 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
612 * alloc.c (allocate_vector_block): Remove redundant
613 calls to mallopt if DOUG_LEA_MALLOC is defined.
614 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
615 avoid calls to mallopt if zero_vector is returned.
617 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
619 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
620 is enabled, avoid dereferencing NULL current_sblock if
623 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
625 Cleanup basic buffer management.
626 * buffer.h (struct buffer): Change layout to use generic vector
627 marking code. Fix some comments. Change type of 'clip_changed'
628 to bitfield. Remove unused #ifndef old.
629 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
630 (GET_OVERLAYS_AT): Fix indentation.
631 (for_each_per_buffer_object_at): New macro.
632 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
633 (Fbuffer_local_variables): Use it.
634 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
635 * alloc.c (allocate_buffer): Adjust to match new layout of
636 struct buffer. Fix comment.
637 (mark_overlay): New function.
638 (mark_buffer): Use it. Use mark_vectorlike to mark normal
639 Lisp area of struct buffer.
640 (mark_object): Use it. Adjust marking of misc objects
641 and related comments.
643 2012-07-02 Paul Eggert <eggert@cs.ucla.edu>
645 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
646 wrapper that is not needed because the wrapped code is a no-op (zero
647 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
648 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
650 2012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
652 * alloc.c (mark_buffer): Simplify. Remove prototype.
653 (mark_object): Add comment. Reorganize marking of vector-like
654 objects. Use CHECK_LIVE for all vector-like objects except buffers
655 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
656 redundant calls to mark_vectorlike for bool vectors.
658 2012-06-30 Glenn Morris <rgm@gnu.org>
660 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
662 * epaths.in (PATH_SITELOADSEARCH): New.
663 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
664 This is rather than relying on --enable-locallisppath elements
665 having "site-lisp" in their names. (Bug#10208#25, 11658)
667 2012-06-30 Eli Zaretskii <eliz@gnu.org>
669 * w32proc.c (sys_select): Accept and ignore one more argument.
671 * w32.c (emacs_gnutls_pull): Call select with one more argument.
673 * sysselect.h [DOS_NT]: Don't include sys/select.h.
674 (pselect) [!MS_DOS]: Redirect to sys_select.
676 * sysdep.c: Don't include dos.h and dosfns.h.
678 * process.c (sys_select):
679 * msdos.c (sys_select): Accept one more argument and ignore it.
681 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
682 adapt data types and code to that.
685 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
686 which clashes with the gnulib function of the same name.
688 2012-06-30 Andreas Schwab <schwab@linux-m68k.org>
690 * font.c (font_style_to_value, font_style_symbolic)
691 (font_prop_validate_style): Add type checks for values in
694 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
696 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
699 2012-06-29 Eli Zaretskii <eliz@gnu.org>
701 * xdisp.c (try_window_id): Undo last change.
703 * w32.c (getwd): Adjust commentary about startup_dir.
704 (init_environment): Always call sys_access, even in non-MSVC
705 builds. Don't chdir to the directory of the Emacs executable.
706 This undoes code from 1997 which was justified by the need to
707 "avoid conflicts when removing and renaming directories". But its
708 downside was that every relative file name was being interpreted
709 relative to the directory of the Emacs executable, which can never
710 be TRT. In particular, it broke sys_access when called with
712 (sys_access): Map GetLastError to errno.
714 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
716 * window.h (struct window): Change type of 'fringes_outside_margins'
717 to bitfield. Fix comment. Adjust users accordingly.
718 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
720 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
723 2012-06-29 Andreas Schwab <schwab@linux-m68k.org>
725 * gnutls.c (emacs_gnutls_handshake):
726 Add QUIT to make the loop interruptible.
728 2012-06-29 Glenn Morris <rgm@gnu.org>
730 * charset.c (init_charset): Make lack of etc/charsets fatal.
732 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
734 * editfns.c (region_limit): Fix type mismatch.
736 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
738 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
739 undefined. Convert from xassert to eassert.
740 * nsmenu.m: Convert from xassert to eassert.
741 * nsterm.m: Likewise.
743 2012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
745 * editfns.c (region_limit): Clip to narrowing (bug#11770).
747 2012-06-28 Paul Eggert <eggert@cs.ucla.edu>
749 Avoid integer overflow on scroll-left and scroll-right.
750 * window.c (HSCROLL_MAX): New macro.
751 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
752 overflow when requested scroll falls outside ptrdiff_t range.
754 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
756 * window.h (struct window): Change type of 'hscroll',
757 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
758 'last_modified' and 'last_overlay_modified' to EMACS_INT.
759 Adjust users accordingly.
760 * xdisp.c (try_cursor_movement): Replace type check with eassert.
761 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
762 from EMACS_INT to ptrdiff_t.
763 (make_window): Omit redundant initialization.
765 2012-06-28 Juanma Barranquero <lekktu@gmail.com>
767 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
769 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
771 * window.h (struct window): Change type of 'use_time' and
772 'sequence_number' from Lisp_Object to int.
773 * frame.c (make_frame): Adjust users accordingly.
774 * print.c (print_object): Likewise.
775 * window.c (select_window, Fwindow_use_time, make_parent_window)
776 (make_window): Likewise.
778 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
780 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
781 enabled with --enable-checking=[all,glyphs] configure option.
782 Fix GLYPH_DEBUG usage assuming that it may be undefined,
783 adjust comments accordingly.
784 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
785 undefined, adjust comments accordingly.
787 * scroll.c: Likewise.
788 * w32fns.c: Likewise.
789 * w32term.c: Likewise.
791 * xfaces.c: Likewise.
795 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
797 Generalize run-time debugging checks.
798 * dispextern.h (XASSERTS): Remove.
799 * fontset.c (xassert): Remove.
800 Convert from xassert to eassert.
801 * alloc.c: Convert from xassert to eassert.
803 * dispnew.c: Likewise.
805 * fringe.c: Likewise.
806 * ftfont.c: Likewise.
807 * gtkutil.c: Likewise.
809 * keyboard.c: Likewise.
811 * process.c: Likewise.
812 * scroll.c: Likewise.
815 * w32console.c: Likewise.
816 * w32fns.c: Likewise.
817 * w32term.c: Likewise.
818 * window.c: Likewise.
820 * xfaces.c: Likewise.
822 * xselect.c: Likewise.
825 2012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
827 * fns.c (maybe_resize_hash_table): Output message when growing the
830 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
832 * alloc.c (allocate_string_data): Remove dead code.
833 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
834 avoid GCC warning about unused macro.
836 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
838 * alloc.c (allocate_string): Omit intervals initialization.
839 * alloc.c (make_uninit_multibyte_string): Initialize intervals
840 as in make_pure_string and make_pure_c_string.
842 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
844 * alloc.c (allocate_string): Fix last change.
846 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
848 * alloc.c (allocate_string): Remove two redundant calls
849 to memset, add explicit initialization where appropriate.
851 2012-06-27 Glenn Morris <rgm@gnu.org>
853 * lisp.mk (lisp): Remove paths.elc.
855 2012-06-27 Chong Yidong <cyd@gnu.org>
857 * doc.c (Fsubstitute_command_keys): Fix punctuation.
859 2012-06-26 John Wiegley <johnw@newartisans.com>
861 * unexmacosx.c (copy_data_segment): Add two section names used
862 on Mac OS X Lion: __mod_init_func and __mod_term_func.
864 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
865 when building with Clang.
867 2012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
869 * eval.c (Fapply): Allow calling it with a single argument.
871 2012-06-26 Eli Zaretskii <eliz@gnu.org>
873 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
874 _stricmp and _strnicmp.
875 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
877 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
879 * alloc.c (allocate_window): Zero out non-Lisp part of newly
881 (allocate_process): Likewise for new process.
882 (allocate_terminal): Change to use offsetof.
883 (allocate_frame): Likewise.
884 * frame.c (make_frame): Omit redundant initialization.
885 * window.c (make_parent_window): Use memset.
886 (make_window): Omit redundant initialization.
887 * process.c (make_process): Omit redundant initialization.
888 * terminal.c (create_terminal): Likewise.
890 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
892 * term.c (delete_tty): Remove redundant call to memset.
894 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
896 * alloc.c: Remove build_string.
897 * lisp.h: Define build_string as static inline. This provides
898 a better opportunity to optimize away calls to strlen when the
899 function is called with compile-time constant argument.
900 * image.c (imagemagick_error): Convert to build_string.
901 * w32proc.c (sys_spawnve): Likewise.
902 * xterm.c (x_term_init): Likewise.
904 2012-06-26 Paul Eggert <eggert@cs.ucla.edu>
906 Use sprintf return value instead of invoking strlen on result.
907 In the old days this wasn't portable, since some sprintf
908 implementations returned char *. But they died out years ago and
909 Emacs already assumes sprintf returns int.
910 Similarly for float_to_string.
911 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
912 * ccl.c (ccl_driver):
913 * character.c (string_escape_byte8):
914 * data.c (Fnumber_to_string):
916 * print.c (print_object):
917 * xdisp.c (message_dolog):
918 * xfns.c (syms_of_xfns):
919 Use sprintf or float_to_string result to avoid need to call strlen.
920 * data.c (Fnumber_to_string):
921 Use make_unibyte_string, since the string must be ASCII.
922 * lisp.h, print.c (float_to_string): Now returns int length.
923 * term.c (produce_glyphless_glyph):
924 Use sprintf result rather than recomputing it.
926 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
927 * Makefile.in (ALL_CFLAGS):
928 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
929 * gmalloc.c, regex.c: Include <config.h> unconditionally.
931 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
933 * dispextern.h (xstrcasecmp): Define to library function
934 strcasecmp if available.
935 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
937 2012-06-25 Andreas Schwab <schwab@linux-m68k.org>
939 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
940 Avoid comma operator.
941 * menu.c (push_submenu_start, push_submenu_end)
942 (push_left_right_boundary, push_menu_pane): Likewise.
943 * msdos.c (dos_rawgetc): Likewise.
945 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
947 * xfns.c (xic_create_fontsetname): Remove redundant calls
950 2012-06-25 Paul Eggert <eggert@cs.ucla.edu>
952 * gtkutil.c (get_utf8_string): Remove redundant assignment.
953 sprintf already null-terminates its output.
955 * xfns.c (x_window): Remove redundant cast.
957 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
959 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
960 `const char *' to `char *' to avoid compiler warning.
962 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
964 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
965 instead of truncating it to 63 (admittedly a generous limit).
967 * process.c: Fix spelling and caps in comments.
969 2012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
971 * emacs.c (setpgrp): Remove definition, unused.
972 * sysdep.c (setpgrp): Remove definition, not used in this file.
974 2012-06-24 Juanma Barranquero <lekktu@gmail.com>
976 * makefile.w32-in: Update dependencies.
978 2012-06-24 Eli Zaretskii <eliz@gnu.org>
980 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
981 (SYSTIME_H): Add nt/inc/sys/time.h.
983 * systime.h [WINDOWSNT]: Include sys/time.h.
985 * s/ms-w32.h (struct timespec): Definition moved from
986 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
988 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
990 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
991 * buffer.h (buffer_slot_type_mismatch):
992 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
993 * eval.c (unwind_to_catch):
994 * image.c (my_png_error, my_error_exit):
995 * keyboard.c (quit_throw_to_read_char, user_error)
996 (Fexit_recursive_edit, Fabort_recursive_edit):
997 * lisp.h (die, args_out_of_range, args_out_of_range_3)
998 (wrong_type_argument, buffer_overflow, __executable_start)
999 (memory_full, buffer_memory_full, string_overflow, Fthrow)
1000 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
1001 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
1003 (child_setup) [!DOS_NT]:
1004 * lread.c (end_of_file_error, invalid_syntax):
1005 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1006 * puresize.h (pure_write_error):
1007 * search.c (matcher_overflow):
1008 * sound.c (sound_perror, alsa_sound_perror):
1009 * sysdep.c, syssignal.h (croak):
1010 * term.c (maybe_fatal, vfatal):
1011 * textprop.c (text_read_only):
1012 * undo.c (user_error):
1013 * unexmacosx.c (unexec_error):
1014 * xterm.c (x_ins_del_lines, x_delete_glyphs):
1015 Use _Noreturn rather than NO_RETURN.
1016 No need for separate decl merely because of _Noreturn.
1017 * sound.c (sound_warning, parse_sound):
1018 Remove unnecessary forward decls.
1020 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1022 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
1023 * lisp.h (WAIT_READING_MAX): New macro.
1024 * dispnew.c (Fsleep_for, sit_for):
1025 * keyboard.c (kbd_buffer_get_event):
1026 * process.c (Faccept_process_output):
1027 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
1028 This improves on the previous patch, which introduced a bug
1029 when time_t is unsigned and as wide as intmax_t.
1030 See <http://bugs.gnu.org/9000#51>.
1032 2012-06-23 Eli Zaretskii <eliz@gnu.org>
1034 * dispnew.c (sit_for, Fsleep_for):
1035 * keyboard.c (kbd_buffer_get_event):
1036 * process.c (Faccept_process_output): Avoid compiler warnings when
1037 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
1039 2012-06-23 Juanma Barranquero <lekktu@gmail.com>
1041 * makefile.w32-in: Update dependencies.
1043 * w32.c (ltime): Add return type and declare static.
1044 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
1046 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1048 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
1049 Privately reported by Herbert J. Skuhra.
1050 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
1052 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
1053 not make_lisp_timeval, when the argument is of type EMACS_TIME.
1055 2012-06-23 Eli Zaretskii <eliz@gnu.org>
1057 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
1058 last argument of make_unibyte_string.
1060 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
1061 language ID in the event parameters.
1063 * w32term.c (w32_read_socket): Put the new keyboard codepage into
1064 event.code, not the obscure "character set ID".
1066 2012-06-23 Chong Yidong <cyd@gnu.org>
1068 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
1070 2012-06-23 Eli Zaretskii <eliz@gnu.org>
1072 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
1073 * w32.c (fdutimens): New function.
1075 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
1077 * s/ms-w32.h (pselect): Redirect to sys_select.
1079 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
1081 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
1082 in the logic of incrementing and decrementing the value of
1083 use_relocatable_buffers.
1085 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1087 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
1088 Privately reported by Herbert J. Skuhra.
1089 [__FreeBSD__]: Remove "*/" typo after "#include".
1090 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
1091 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
1092 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
1093 Don't assume EMACS_TIME and struct timeval are the same type.
1095 2012-06-22 Paul Eggert <eggert@cs.ucla.edu>
1097 Support higher-resolution time stamps (Bug#9000).
1098 The time stamps are only nanosecond-resolution at the C level,
1099 since that's the best that any real-world system supports now.
1100 But they are picosecond-resolution at the Lisp level, as that's
1101 easy, and leaves room for future OS improvements.
1103 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
1106 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
1107 Don't get current time unless it's needed.
1109 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
1110 now provides it if it's absent.
1111 (start_atimer): Port to higher-res time stamps.
1112 Check for time stamp overflow. Don't get current time more
1113 often than is needed.
1115 * buffer.h (struct buffer): Buffer modtime now has high resolution.
1116 Include systime.h, not time.h.
1117 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
1119 * dired.c: Include stat-time.h.
1120 (Ffile-attributes): File times now have higher resolution.
1122 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
1123 (struct image): Timestamp now has higher resolution.
1125 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
1126 has at least microseconds now. All uses removed.
1127 (update_frame, update_single_window, update_window, update_frame_1)
1128 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
1130 * editfns.c (time_overflow): Now extern.
1131 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
1132 (float-time, Fformat_time_string, Fcurrent_time_string)
1133 (Fcurrent_time_zone): Accept and generate higher-resolution
1135 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
1136 (decode_time_components, lisp_seconds_argument): New functions.
1137 (make_time): Now static.
1138 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
1139 Report an error if the time is invalid, rather than having the caller
1142 * fileio.c: Include <stat-time.h>
1143 (Fcopy_file): Copy higher-resolution time stamps.
1144 Prefer to set the time stamp via a file descriptor if that works.
1145 (Fset_file_times, Finsert_file_contents, Fwrite_region)
1146 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
1147 (Fvisited_file_modtime, Fset_visited_file_modtime):
1148 Support higher-resolution time stamps.
1150 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
1152 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
1154 * image.c (prepare_image_for_display, clear_image_cache)
1155 (lookup_image): Port to higer-resolution time stamps.
1157 * keyboard.c (start_polling, bind_polling_period):
1158 Check for time stamp overflow.
1159 (read_char, kbd_buffer_get_event, timer_start_idle)
1160 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
1161 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
1162 Port to higher-resolution time stamps. Do not assume time_t is signed.
1163 (decode_timer): New function. Timers are now vectors of length 9,
1164 not 8, to accommodate the picosecond component.
1165 (timer_check_2): Use it.
1167 * nsterm.m (select_timeout, timeval_subtract): Remove.
1168 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
1169 as they're a bit more accurate and handle overflow better.
1170 (ns_select): Change prototype to be compatible with pselect.
1171 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
1172 * nsterm.h (ns_select): Adjust prototype.
1174 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
1175 us-resolution time stamps.
1176 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
1178 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
1180 * lisp.h (time_overflow): New decl.
1181 (wait_reading_process_output): First arg is now intmax_t, not int,
1182 to accommodate larger waits.
1184 * process.h (struct Lisp_Process.read_output_delay):
1185 Now counts nanoseconds, not microseconds.
1186 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
1188 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
1189 (wait_reading_process_output):
1190 Port to ns-resolution time stamps.
1191 (Faccept_process_output, wait_reading_process_output):
1192 Check for time stamp overflow. Do not assume time_t is signed.
1193 (select_wrapper): Remove; we now use pselect.
1194 (Fprocess_attributes): Now generates ns-resolution time stamps.
1196 * sysdep.c: Include utimens.h. Don't include utime.h
1197 or worry about struct utimbuf; gnulib does that for us now.
1198 (gettimeofday): Remove; gnulib provides a substitute.
1199 (make_timeval): New function.
1200 (set_file_times): Now sets ns-resolution time stamps.
1201 New arg FD; all uses changed.
1202 (time_from_jiffies, ltime_from_jiffies, get_up_time)
1203 (system_process_attributes):
1204 Now returns ns-resolution time stamp. All uses changed.
1205 Check for time stamp overflow.
1207 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
1208 provides a substitute now.
1210 * systime.h: Include timespec.h rather than sys/time.h and time.h,
1211 since it guarantees struct timespec.
1212 (EMACS_TIME): Now struct timespec, so that we can support
1213 ns-resolution time stamps.
1214 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
1215 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
1216 (EMACS_USECS): Remove.
1217 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
1218 so multiply the arg by 1000 before storing it.
1219 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
1221 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
1222 Port to ns-resolution time stamps.
1223 (EMACS_TIME_NEG_P): Remove; replaced by....
1224 (EMACS_TIME_SIGN): New macro.
1225 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
1226 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
1227 (set_file_times, make_time, lisp_time_argument): Adjust signature.
1228 (make_timeval, make_lisp_time, decode_time_components): New decls.
1229 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
1230 that it mishandled time_t overflow. You can't compare by subtracting!
1231 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
1232 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
1234 * term.c: Include <sys/time.h>.
1235 (timeval_to_Time): New function, for proper overflow wraparound.
1236 (term_mouse_position, term_mouse_click): Use it.
1238 * undo.c (record_first_change): Support higher-resolution time stamps
1240 (Fprimitive_undo): Use them when restoring time stamps.
1242 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
1243 (w32_get_internal_run_time):
1244 Port to higher-resolution Emacs time stamps.
1245 (ltime): Now accepts single 64-bit integer, as that's more convenient
1248 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
1250 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
1251 for compatibility with pselect. Support ns-resolution time stamps.
1253 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
1255 * xselect.c (wait_for_property_change, x_get_foreign_selection):
1256 Check for time stamp overflow, and support ns-resolution time stamps.
1258 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
1259 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
1260 (timeval_subtract): Remove; no longer needed.
1261 (XTflash, XTring_bell, x_wait_for_event):
1262 Port to ns-resolution time stamps. Don't assume time_t is signed.
1264 2012-06-22 Chong Yidong <cyd@gnu.org>
1266 * xdisp.c (x_consider_frame_title): Revert last change.
1268 2012-06-22 Eli Zaretskii <eliz@gnu.org>
1270 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
1271 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
1272 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
1273 staticidx goes up to 1597 out of 1600 = 0x640.)
1275 2012-06-20 Paul Eggert <eggert@cs.ucla.edu>
1277 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
1278 Otherwise, the umask might be mistakenly 0 while handling input signals.
1280 2012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
1282 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
1284 2012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
1286 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
1287 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
1288 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
1289 access to `contents' member of Lisp_Vector objects with AREF and ASET
1292 2012-06-19 Chong Yidong <cyd@gnu.org>
1294 * frame.c (delete_frame): When selecting a frame on a different
1295 text terminal, do not alter the terminal's top-frame.
1297 * xdisp.c (format_mode_line_unwind_data): Record the target
1298 frame's selected window and its terminal's top-frame.
1299 (unwind_format_mode_line): Restore them.
1300 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
1302 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
1303 since tty frames can be explicitly named.
1304 (prepare_menu_bars): Likewise.
1306 * term.c (Ftty_top_frame): New function.
1308 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1310 Port byte-code-meter to modern targets.
1311 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
1312 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
1313 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
1314 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
1315 (METER_1, METER_2): Simplify.
1317 2012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
1319 * data.c (Fdefalias): Return `symbol' (bug#11686).
1321 2012-06-18 Martin Rudalics <rudalics@gmx.at>
1323 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1324 gets killed during executing of this function (Bug#11665).
1325 Try to always return Qt when the buffer has been actually killed.
1326 (Vkill_buffer_query_functions): In doc-string say that functions
1327 run by this hook should not change the current buffer.
1329 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1331 Fix recently-introduced process.c problems found by static checking.
1332 * process.c (write_queue_push, write_queue_pop, send_process):
1333 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
1334 (write_queue_pop): Fix pointer signedness problem.
1335 (send_process): Remove unused local.
1337 2012-06-17 Chong Yidong <cyd@gnu.org>
1339 * xdisp.c (redisplay_internal): No need to redisplay terminal
1340 frames that are not on top.
1342 2012-06-17 Troels Nielsen <bn.troels@gmail.com>
1344 * process.c (make_process): Initialize write_queue.
1345 (write_queue_push, write_queue_pop): New functions.
1346 (send_process): Use them to maintain correct ordering of process
1349 2012-06-17 Paul Eggert <eggert@cs.ucla.edu>
1351 * lisp.h (eassert): Assume C89 or later.
1352 This removes the need for CHECK.
1353 (CHECK): Remove. Its comments about always evaluating its
1354 argument were confusing, as 'eassert' typically does not evaluate
1357 * coding.c (produce_chars): Use ptrdiff_t, not int.
1359 * xterm.c (x_draw_underwave): Check for integer overflow.
1360 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
1362 2012-06-17 Jan Djärv <jan.h.d@swipnet.se>
1364 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
1365 referenced (Bug#11583).
1367 2012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
1369 Implement wave-style variant of underlining.
1370 * dispextern.h (face_underline_type): New enum.
1371 (face): Add field for underline type.
1372 * nsterm.m (ns_draw_underwave): New function.
1373 (ns_draw_text_decoration): Use it.
1374 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
1376 (x_draw_glyph_string): Use them.
1377 * xfaces.c (Qline, Qwave): New Lisp objects.
1378 (check_lface_attrs, merge_face_ref)
1379 (Finternal_set_lisp_face_attribute, realize_x_face):
1380 Handle wave-style underline face attributes.
1381 * xterm.c (x_draw_underwave): New function.
1382 (x_draw_glyph_string): Use it.
1384 2012-06-16 Juanma Barranquero <lekktu@gmail.com>
1386 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
1387 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
1388 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
1389 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
1390 ($(BLD)/w32select.$(O)): Update dependencies.
1392 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1394 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
1395 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
1396 * character.c (_fetch_multibyte_char_p): Remove.
1397 * alloc.c: Include "character.h" before "buffer.h".
1399 * buffer.c: Likewise.
1400 * bytecode.c: Likewise.
1401 * callint.c: Likewise.
1402 * callproc.c: Likewise.
1403 * casefiddle.c: Likewise.
1404 * casetab.c: Likewise.
1405 * category.c: Likewise.
1407 * coding.c: Likewise.
1408 * composite.c: Likewise.
1409 * dired.c: Likewise.
1410 * dispnew.c: Likewise.
1412 * dosfns.c: Likewise.
1413 * editfns.c: Likewise.
1414 * emacs.c: Likewise.
1415 * fileio.c: Likewise.
1416 * filelock.c: Likewise.
1418 * fontset.c: Likewise.
1419 * fringe.c: Likewise.
1420 * indent.c: Likewise.
1421 * insdel.c: Likewise.
1422 * intervals.c: Likewise.
1423 * keyboard.c: Likewise.
1424 * keymap.c: Likewise.
1425 * lread.c: Likewise.
1426 * macros.c: Likewise.
1427 * marker.c: Likewise.
1428 * minibuf.c: Likewise.
1429 * nsfns.m: Likewise.
1430 * nsmenu.m: Likewise.
1431 * print.c: Likewise.
1432 * process.c: Likewise.
1433 * regex.c: Likewise.
1434 * region-cache.c: Likewise.
1435 * search.c: Likewise.
1436 * syntax.c: Likewise.
1438 * textprop.c: Likewise.
1440 * unexsol.c: Likewise.
1441 * w16select.c: Likewise.
1442 * w32fns.c: Likewise.
1443 * w32menu.c: Likewise.
1444 * window.c: Likewise.
1445 * xdisp.c: Likewise.
1447 * xmenu.c: Likewise.
1449 * xselect.c: Likewise.
1451 2012-06-16 Eli Zaretskii <eliz@gnu.org>
1453 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
1454 If all the glyphs of the glyph row came from strings, and we have no
1455 cursor positioning clues, put the cursor on the first glyph of the
1457 (handle_face_prop): Use chunk-relative overlay string index when
1458 indexing into it->string_overlays array. (Bug#11653)
1459 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
1460 the rightmost. (Bug#11720)
1462 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1464 * category.h (CHAR_HAS_CATEGORY): Define as inline.
1465 (CATEGORY_MEMBER): Enforce 1/0 value.
1466 * category.c (_temp_category_set): Remove.
1468 2012-06-16 Eli Zaretskii <eliz@gnu.org>
1470 * window.c (Fdelete_other_windows_internal)
1471 (Fdelete_window_internal): Don't access frame's mouse highlight
1472 info of the initial frame. (Bug#11677)
1474 2012-06-14 Paul Eggert <eggert@cs.ucla.edu>
1476 * .gdbinit (xgetint): Fix recently-introduced paren typo.
1477 Assume USE_2_TAGS_FOR_INTS.
1478 (xreload): Adjust $tagmask width to match recent lisp.h change.
1480 Simplify lisp.h in minor ways that should not affect code.
1481 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
1482 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
1483 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
1484 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
1485 (INTTYPEBITS): New macro, for clarity.
1486 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1487 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
1488 Simplify now that USE_LSB_TAG is always defined.
1489 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
1490 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
1492 2012-06-13 Juanma Barranquero <lekktu@gmail.com>
1494 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
1496 2012-06-13 Glenn Morris <rgm@gnu.org>
1498 * s/bsd-common.h (BSD4_3):
1499 * s/usg5-4-common.h (USG5_4): No longer define; unused.
1501 2012-06-13 Andreas Schwab <schwab@linux-m68k.org>
1503 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
1506 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
1508 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
1509 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1510 * alloc.c (widen_to_Lisp_Object): Remove.
1511 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
1512 * frame.c (delete_frame): Remove outdated comment.
1513 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
1514 USE_LISP_UNION_TYPE.
1515 (Fw32_unregister_hot_key): Likewise.
1516 (Fw32_toggle_lock_key): Likewise.
1517 * w32menu.c (add_menu_item): Likewise.
1518 (w32_menu_display_help): Use XIL instead of checking
1519 USE_LISP_UNION_TYPE.
1520 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
1521 (init_heap): Likewise.
1522 * w32term.c (w32_read_socket): Update comment.
1524 2012-06-13 Glenn Morris <rgm@gnu.org>
1526 * s/usg5-4-common.h, src/s/unixware.h:
1527 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
1529 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
1531 2012-06-13 Paul Eggert <eggert@cs.ucla.edu>
1533 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
1534 * alloc.c (make_number) [!defined make_number]:
1535 Remove, as lisp.h always defines this now.
1536 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
1537 (roundup_size): Verify that it is a power of 2.
1538 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
1539 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
1540 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
1541 -DUSE_LSB_TAG=0, to override the automatically-selected default.
1542 USE_LSB_TAG now is always defined to be either 0 or 1.
1544 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
1545 code works fine either way, and efficiency is not a concern here,
1546 as the union type is for debugging, not for production.
1547 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
1548 Use an inline function on all platforms when using the union type,
1549 since this is simpler and 'static inline' can be used portably
1551 (LISP_INITIALLY_ZERO): New macro.
1552 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
1553 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
1555 2012-06-12 Glenn Morris <rgm@gnu.org>
1557 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
1559 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
1561 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
1562 Move BROKEN_SIGIO to configure.
1564 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
1565 Move NO_TERMIO to configure.
1567 2012-06-12 Chong Yidong <cyd@gnu.org>
1569 * image.c (imagemagick_load_image): Use MagickFlattenImage if
1570 MagickMergeImageLayers is undefined. Use pixel pusher loop if
1571 MagickExportImagePixels is undefined.
1573 2012-06-12 Paul Eggert <eggert@cs.ucla.edu>
1575 * image.c (imagemagick_load_image): Remove unused label.
1577 2012-06-11 Glenn Morris <rgm@gnu.org>
1579 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1580 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
1581 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
1582 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
1584 2012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
1586 * alloc.c (make_byte_code): New function.
1587 (Fmake_byte_code): Use it. Don't purify here.
1588 * lread.c (read1): Use it as well to avoid extra allocation.
1590 2012-06-11 Chong Yidong <cyd@gnu.org>
1592 * image.c (imagemagick_load_image): Implement transparency.
1594 2012-06-10 Andreas Schwab <schwab@linux-m68k.org>
1596 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
1597 account for preceding backslashes. (Bug#11663)
1599 2012-06-09 Chong Yidong <cyd@gnu.org>
1601 * term.c: Support italics in capable terminals (Bug#9652).
1602 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
1603 (turn_on_face): Output using TS_enter_italic_mode if available.
1604 Don't handle unused blinking and alt-charset cases.
1605 (turn_off_face): Handle italic case; discard unused tty_blinking_p
1606 and tty_alt_charset_p cases.
1607 (tty_capable_p, init_tty): Support italics.
1609 * termchar.h (struct tty_display_info): Add field for italics.
1610 Remove unused blink field.
1612 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
1615 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
1616 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
1617 tty_alt_charset_p. Add tty_italic_p.
1619 2012-06-09 Michael Albinus <michael.albinus@gmx.de>
1621 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
1622 dbus_type_is_basic if available.
1623 (xd_extract_signed, xd_extract_unsigned): Rename from
1624 extract_signed and extract_unsigned, respectively. Adapt callers.
1626 2012-06-09 Chong Yidong <cyd@gnu.org>
1628 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
1630 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
1633 2012-06-08 Paul Eggert <eggert@cs.ucla.edu>
1635 * xdisp.c (vmessage): Treat frame message as multibyte.
1636 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
1637 would generate the diagnostic "Making \302\247 buffer-local while
1640 2012-06-08 Eli Zaretskii <eliz@gnu.org>
1642 * dispnew.c (showing_window_margins_p): Undo last change, which
1643 was done due to an inadvertent commit.
1644 (adjust_frame_glyphs_for_frame_redisplay): Do call
1645 showing_window_margins_p.
1647 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1649 * eval.c (Fmake_var_non_special): New primitive.
1650 (syms_of_eval): Defsubr it.
1651 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
1653 2012-06-08 Juanma Barranquero <lekktu@gmail.com>
1655 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
1656 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
1658 2012-06-08 Eli Zaretskii <eliz@gnu.org>
1660 * alloc.c (allocate_vectorlike): Fix last change.
1662 2012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
1664 Block-based vector allocation of small vectors.
1665 * lisp.h (struct vectorlike_header): New field `nbytes',
1666 adjust comment accordingly.
1667 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
1668 to denote vector blocks. Adjust users (live_vector_p,
1669 mark_maybe_pointer, valid_lisp_object_p) accordingly.
1670 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
1671 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
1672 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
1673 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
1674 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
1675 (roundup_size): New constant.
1676 (struct vector_block): New data type.
1677 (vector_blocks, vector_free_lists, zero_vector): New variables.
1678 (all_vectors): Rename to `large_vectors'.
1679 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
1680 (sweep_vectors): New functions.
1681 (allocate_vectorlike): Return `zero_vector' as the only vector of
1682 0 items. Allocate new vector from block if vector size is less than
1683 or equal to VBLOCK_BYTES_MAX.
1684 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
1685 (init_alloc_once): Add call to init_vectors.
1687 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1689 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
1691 2012-06-07 Paul Eggert <eggert@cs.ucla.edu>
1693 * doprnt.c (doprnt): Truncate multibyte char correctly.
1694 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
1695 would mishandle a string argument "Xc" if X was a multibyte
1696 character of length 2: it would truncate after X's first byte
1697 rather than including all of X.
1699 2012-06-06 Chong Yidong <cyd@gnu.org>
1701 * buffer.c (word_wrap): Doc fix.
1703 2012-06-04 Paul Eggert <eggert@cs.ucla.edu>
1705 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
1707 2012-06-03 Glenn Morris <rgm@gnu.org>
1709 * xdisp.c (tool-bar-style): Doc fix.
1711 2012-06-03 Ulrich Müller <ulm@gentoo.org>
1713 * Makefile.in (PAXCTL): Define.
1714 (temacs$(EXEEXT)): Disable memory randomization for the temacs
1715 binary via PaX flags if the paxctl utility is available.
1716 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
1717 Restore PaX flags to their default. (Bug#11398)
1719 2012-06-03 Chong Yidong <cyd@gnu.org>
1721 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
1724 2012-06-03 Chong Yidong <cyd@gnu.org>
1726 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
1727 (note_mode_line_or_margin_highlight): If there is no help echo,
1728 use mode-line-default-help-echo. Handle the case where the mouse
1729 position is past the end of the mode line string.
1731 * buffer.c (buffer_local_value_1): New function, split from
1732 Fbuffer_local_value; can return Qunbound.
1733 (Fbuffer_local_value): Use it.
1734 (Vmode_line_format): Docstring tweaks.
1736 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1738 * sysdep.c (system_process_attributes): Improve comment.
1740 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
1742 * keyboard.c: Export real-this-command to Elisp.
1743 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
1744 and DEFVAR it. Update all users.
1746 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1748 * minibuf.c (Fassoc_string): Remove duplicate declaration.
1750 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
1751 Convert pctcpu and pctmem to Lisp float properly.
1752 Let the compiler fold better, as 100.0/0x8000 is exact.
1754 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
1756 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
1759 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
1761 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
1763 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
1765 For a 'struct window', replace some Lisp_Object fields to
1766 bitfields where appropriate, remove unused fields.
1767 * window.h (struct window): Remove unused 'last_mark_x' and
1768 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
1769 change it's type from Lisp_Object to bitfield.
1770 Change type of 'force_start', 'optional_new_start',
1771 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
1772 fields from Lisp_Object to bitfield. Adjust users accordingly.
1774 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1776 Pacify gcc -Wdouble-precision when using Xaw.
1777 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
1778 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
1779 Use 'float' consistently, rather than 'float' in most places
1780 and 'double' in a couple of places.
1782 2012-05-31 Eli Zaretskii <eliz@gnu.org>
1784 * xdisp.c (handle_stop): Detect whether we have overlay strings
1785 loaded by testing it->current.overlay_string_index to be
1786 non-negative, instead of checking whether n_overlay_strings is
1787 positive. (Bug#11587)
1789 2012-05-31 Chong Yidong <cyd@gnu.org>
1791 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
1793 * doc.c (Fsubstitute_command_keys): Doc fix.
1795 2012-05-31 Eli Zaretskii <eliz@gnu.org>
1797 * search.c (search_buffer): Remove calls to
1798 r_alloc_inhibit_buffer_relocation, as it is now called by
1799 maybe_unify_char, which was the cause of relocation of buffer text
1802 2012-05-31 Eli Zaretskii <eliz@gnu.org>
1804 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
1805 for the duration of call to load_charset, to avoid problems with
1806 callers of maybe_unify_char that access buffer text through C
1809 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
1810 decrement the inhibition flag, instead of just setting or
1813 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1815 Remove obsolete '#define static' cruft.
1816 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
1817 This #undef was "temporary" in 2000; it is no longer needed
1818 now that '#define static' has gone away.
1819 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
1820 (gray_bitmap_bits): Remove; no longer needed.
1821 All uses replaced with definiens.
1822 * xterm.c: Include "bitmaps/gray.xbm".
1824 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1826 Clean up __executable_start, monstartup when --enable-profiling.
1827 The following changes affect the code only when profiling.
1828 * dispnew.c (__executable_start): Rename from safe_bcopy.
1829 Define only on platforms that need it.
1830 * emacs.c: Include <sys/gmon.h> when profiling.
1831 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
1832 (__executable_start): Remove decl, since lisp.h does it now.
1833 (safe_bcopy): Remove decl; no longer has that name.
1834 (main): Coalesce #if into single bit of code, for simplicity.
1835 Cast pointers to uintptr_t, since standard libraries want integers
1837 * lisp.h (__executable_start): New decl.
1839 2012-05-31 Glenn Morris <rgm@gnu.org>
1841 * image.c (Fimagemagick_types): Doc fix.
1843 2012-05-30 Jim Meyering <meyering@redhat.com>
1845 * callproc.c (Fcall_process_region): Include directory component
1846 in mkstemp error message (Bug#11586).
1848 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1850 * alloc.c, lisp.h (make_pure_vector): Now static.
1852 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
1854 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
1855 Move to byte-run.el.
1856 (Fautoload): Do the hash-doc more carefully.
1857 * data.c (Fdefalias): Purify definition, except for keymaps.
1858 (Qdefun): Move from eval.c.
1859 * lisp.h (Qdefun): Remove.
1860 * lread.c (read1): Tiny simplification.
1862 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
1864 Do not create empty overlays with the evaporate property (Bug#9642).
1865 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
1866 Bug#9642, but explicitly check that the buffer the overlay would
1867 be moved to is live and rearrange lines to make sure that errors
1868 will not put the overlay in an inconsistent state.
1869 (Fdelete_overlay): Cosmetics.
1871 2012-05-28 Eli Zaretskii <eliz@gnu.org>
1873 * w32term.c (my_bring_window_to_top): New function.
1874 (x_raise_frame): Use handle returned by DeferWindowPos, which
1875 could be different from the original one.
1876 Call my_bring_window_to_top instead of my_set_foreground_window.
1879 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
1880 by calling BringWindowToTop.
1882 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
1883 (WM_EMACS_END): Increase by one.
1885 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
1887 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
1888 This avoids undefined behavior that might cause the eassert
1889 to not catch an out-of-range value.
1891 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
1893 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
1894 Update dependencies.
1896 2012-05-27 Eli Zaretskii <eliz@gnu.org>
1898 * bidi.c (bidi_mirror_char): Fix last change.
1900 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
1902 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
1903 when referring to sectname field in printf format.
1905 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
1907 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
1908 Only r_alloc_inhibit_buffer_relocation needed to be added;
1909 the others were already declared.
1911 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
1912 before checking whether it's out of range. Put the check inside
1914 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
1916 2012-05-27 Ken Brown <kbrown@cornell.edu>
1918 * callproc.c (Fcall_process): Restore a line that was accidentally
1919 commented out in the 2011-02-13 change (bug#11547).
1921 2012-05-27 Eli Zaretskii <eliz@gnu.org>
1923 * lisp.h [REL_ALLOC]: Add prototypes for external functions
1924 defined on ralloc.c.
1926 * buffer.c [REL_ALLOC]: Remove prototypes of
1927 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
1928 they are now on lisp.h.
1930 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
1932 * search.c (search_buffer): Use it to inhibit relocation of buffer
1933 text while re_search_2 is doing its job, because re_search_2 is
1934 passed C pointers to buffer text. (Bug#11519)
1936 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
1939 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
1940 state after an additional call to move_it_in_display_line_to, keep
1941 the values of it->max_ascent and it->max_descent found for the
1943 (pos_visible_p): Revert the comparison against bottom_y to what it
1944 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
1947 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1949 Fix coding-related core dumps with gcc -ftrapv.
1950 The code was computing A - B, where A and B are pointers, and B is
1951 random garbage. This can lead to core dumps on platforms that
1952 have special pointer registers, and it also leads to core dumps on
1953 x86-64 when compiled with gcc -ftrapv. The fix is to compute
1954 A - B only when B is initialized properly.
1955 * coding.c (coding_set_source, coding_set_destination): Return void.
1956 (coding_change_source, coding_change_destinations): New functions,
1957 with the old behaviors of coding_set_source and coding_set_destination.
1958 All callers that need an offset changed to use these new functions.
1960 2012-05-26 Glenn Morris <rgm@gnu.org>
1962 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
1964 2012-05-26 Eli Zaretskii <eliz@gnu.org>
1966 Extend mouse support on W32 text-mode console.
1967 * xdisp.c (draw_row_with_mouse_face):
1968 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
1970 * w32console.c: Include window.h.
1971 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
1973 (initialize_w32_display): Initialize mouse-highlight data.
1975 * w32inevt.c: Include termchar.h and window.h.
1976 (do_mouse_event): Support mouse-autoselect-window. When the mouse
1977 moves, call note_mouse_highlight. If help_echo changed, call
1978 gen_help_event to produce help-echo message in the echo area.
1979 Call clear_mouse_face if mouse_face_hidden is set in the mouse
1982 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1984 * lread.c (read1): Simplify slightly to avoid an overflow warning
1985 with GCC 4.7.0 on x86-64.
1987 2012-05-26 Eli Zaretskii <eliz@gnu.org>
1989 * bidi.c (bidi_mirror_char): Revert last change: an int is
1990 definitely wide enough here.
1992 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
1994 Fix integer width and related bugs (Bug#9874).
1995 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
1996 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
1997 (string_bytes, check_sblock, allocate_string_data):
1998 (compact_small_strings, Fmake_bool_vector, make_string)
1999 (make_unibyte_string, make_multibyte_string)
2000 (make_string_from_bytes, make_specified_string)
2001 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
2002 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
2004 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2005 (allocate_pseudovector):
2006 Use int, not EMACS_INT, where int is wide enough.
2007 (inhibit_garbage_collection, Fgarbage_collect):
2008 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2009 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
2010 int might not be wide enough.
2011 (bidi_cache_search, bidi_cache_find, bidi_init_it)
2012 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
2013 (bidi_at_paragraph_end, bidi_find_paragraph_start)
2014 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2015 (bidi_level_of_next_char, bidi_move_to_visually_next):
2016 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2017 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
2018 (Fkill_buffer, Fset_buffer_major_mode)
2019 (advance_to_char_boundary, Fbuffer_swap_text)
2020 (Fset_buffer_multibyte, overlays_at, overlays_in)
2021 (overlay_touches_p, struct sortvec, record_overlay_string)
2022 (overlay_strings, recenter_overlay_lists)
2023 (adjust_overlays_for_insert, adjust_overlays_for_delete)
2024 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
2025 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
2026 (Foverlay_recenter, last_overlay_modification_hooks_used)
2027 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
2028 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2029 (validate_region): Omit unnecessary test for b <= e,
2030 since that's guaranteed by the previous test.
2031 (adjust_overlays_for_delete): Avoid pos + length overflow.
2032 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
2033 (report_overlay_modification):
2034 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2035 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
2036 Omit pointer cast, which isn't needed anyway, and doesn't work
2037 after the EMACS_INT -> ptrdiff_t change.
2038 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
2039 * buffer.h: Adjust decls to match defn changes elsewhere.
2040 (struct buffer_text, struct buffer):
2041 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2042 Use EMACS_INT, not int, where int might not be wide enough.
2043 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
2044 not int, to avoid needless 32-bit limit on 64-bit hosts.
2045 (exec_byte_code): Use tighter memory-full test, one that checks
2046 for alloca overflow. Don't compute the address of the object just
2047 before an array, as that's not portable. Use EMACS_INT, not
2048 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
2049 * callint.c (Fcall_interactively):
2050 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2051 * callproc.c (call_process_kill, Fcall_process):
2052 Don't assume pid_t fits into an Emacs fixnum.
2053 (call_process_cleanup, Fcall_process, child_setup):
2054 Don't assume pid_t fits into int.
2055 (call_process_cleanup, Fcall_process, delete_temp_file)
2056 (Fcall_process_region):
2057 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2058 (Fcall_process): Simplify handling of volatile integers.
2059 Use int, not EMACS_INT, where int will do.
2060 * casefiddle.c (casify_object, casify_region, operate_on_word)
2061 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
2062 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2063 (casify_object): Avoid integer overflow when overallocating buffer.
2064 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
2065 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
2066 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
2067 * category.h (CATEGORYP): Don't assume arg is nonnegative.
2068 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
2069 integers are now checked earlier. All uses replaced with XINT.
2071 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2072 For CCL_MapSingle, check that content and value are in int range.
2073 (ccl_driver, Fregister_code_conversion_map):
2074 Check that Vcode_version_map_vector is a vector.
2075 (resolve_symbol_ccl_program): Check that vector header is in range.
2076 Always copy the vector, so that we can check its contents reliably
2077 now rather than having to recheck each instruction as it's being
2078 executed. Check that vector words fit in 'int'.
2079 (ccl_get_compiled_code, Fregister_ccl_program)
2080 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
2081 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
2082 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
2083 contents are in range.
2084 (Fccl_execute_on_string): Check that status is in range.
2085 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
2086 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
2087 Accept and return EMACS_INT, not int, because callers can pass values
2089 (c_string_width, strwidth, lisp_string_width, chars_in_text)
2090 (multibyte_chars_in_text, parse_str_as_multibyte)
2091 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
2092 (str_as_unibyte, str_to_unibyte, string_count_byte8)
2093 (string_escape_byte8, Fget_byte):
2094 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2095 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
2096 avoid mishandling large integers.
2097 * character.h: Adjust decls to match defn changes elsewhere.
2098 * charset.c (load_charset_map_from_file, find_charsets_in_text)
2099 (Ffind_charset_region):
2100 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2101 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
2102 (load_charset_map_from_vector, Fdefine_charset_internal):
2103 Don't assume fixnum fits in int.
2104 (load_charset_map_from_vector, Fmap_charset_chars):
2105 Remove now-unnecessary CHECK_NATNUMs.
2106 (Fdefine_charset_internal): Check ranges here, more carefully.
2107 Don't rely on undefined behavior with signed left shift overflow.
2108 Don't assume unsigned int fits into fixnum, or that fixnum fits
2109 into unsigned int. Don't require max_code to be a valid fixnum;
2110 that's not true for gb10830 4-byte on a 32-bit host. Allow
2111 invalid_code to be a cons, for the same reason. Require code_offset
2112 to be a character. Avoid int overflow if max_char is close
2114 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
2115 this is intended anyway and avoids some undefined behavior.
2116 (load_charset_map): Pass unsigned, not int, as 2nd arg of
2117 INDEX_TO_CODE_POINT, as that's what it expects.
2118 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
2119 * charset.h (DECODE_CHAR): Return int, not unsigned;
2120 this is what was intended anyway, and it avoids undefined behavior.
2121 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
2122 integer-overflow issues.
2123 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
2124 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
2125 where the argument is EMACS_INT, and this behavior is not intended.
2126 * chartab.c (Fmake_char_table, Fset_char_table_range)
2127 (uniprop_get_decoder, uniprop_get_encoder):
2128 Don't assume fixnum fits in int.
2129 * cmds.c (move_point): New function, that does the gist of
2130 Fforward_char and Fbackward_char, but does so while checking
2131 for integer overflow more accurately.
2132 (Fforward_char, Fbackward_char): Use it.
2133 (Fforward_line, Fend_of_line, internal_self_insert)
2134 (internal_self_insert):
2135 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2136 Fix a FIXME, by checking for integer overflow when calculating
2137 target_clm and actual_clm.
2138 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
2139 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
2140 (ASSURE_DESTINATION, coding_alloc_by_realloc)
2141 (coding_alloc_by_making_gap, alloc_destination)
2142 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
2143 (encode_coding_utf_16, detect_coding_emacs_mule)
2144 (decode_coding_emacs_mule, encode_coding_emacs_mule)
2145 (detect_coding_iso_2022, decode_coding_iso_2022)
2146 (encode_invocation_designation, encode_designation_at_bol)
2147 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2148 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
2149 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
2150 (encode_coding_ccl, encode_coding_raw_text)
2151 (detect_coding_charset, decode_coding_charset)
2152 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
2153 (produce_composition, produce_charset, produce_annotation)
2154 (decode_coding, handle_composition_annotation)
2155 (handle_charset_annotation, consume_chars, decode_coding_gap)
2156 (decode_coding_object, encode_coding_object, detect_coding_system)
2157 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
2158 (code_convert_region, code_convert_string)
2159 (Fdefine_coding_system_internal)
2160 (coding_set_source, coding_set_destination):
2161 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2162 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
2163 (Fdefine_coding_system_internal):
2164 Don't assume fixnums fit in int.
2165 (decode_coding_gap, decode_coding_object, encode_coding_object)
2166 (Fread_coding_system, Fdetect_coding_region)
2167 (Funencodable_char_position, Fcheck_coding_systems_region)
2168 (get_translation, handle_composition_annotation, consume_chars):
2169 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2170 (consume_chars): Rewrite to not calculate an address outside buffer.
2171 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
2172 Don't access memory outside of the args array.
2173 (Fdefine_coding_system_internal): Check for charset-id overflow.
2174 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
2175 result of ENCODE_CHAR.
2176 * coding.h: Adjust decls to match defn changes elsewhere.
2177 (struct coding_system):
2178 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2179 * composite.c (get_composition_id, find_composition)
2180 (run_composition_function, update_compositions)
2181 (compose_text, composition_gstring_put_cache)
2182 (composition_gstring_p, composition_gstring_width)
2183 (fill_gstring_header, fill_gstring_body, autocmp_chars)
2184 (composition_compute_stop_pos, composition_reseat_it)
2185 (composition_update_it, struct position_record)
2186 (find_automatic_composition, composition_adjust_point)
2187 (Fcomposition_get_gstring, Ffind_composition_internal):
2188 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2189 (update_compositions):
2190 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2191 * composite.h: Adjust decls to match defn changes elsewhere.
2192 (struct composition):
2193 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2194 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
2195 Do not attempt to compute the address of the object just before a
2196 buffer; this is not portable.
2198 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2199 (Faset): Use int, not EMACS_INT, where int is wide enough.
2200 (Fstring_to_number): Don't assume fixnums fit in int.
2201 (Frem): Don't assume arg is nonnegative.
2202 * dbusbind.c (xd_append_arg): Check for integers out of range.
2203 (Fdbus_call_method): Don't overflow the timeout int.
2204 (extract_signed, extract_unsigned): New functions.
2205 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
2206 (xd_get_connection_references): Return ptrdiff_t, not int.
2208 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
2209 (xd_read_message_1):
2210 Use int, not unsigned, where the dbus API uses int.
2211 (Fdbus_message_internal): Don't overflow mtype.
2212 (syms_of_dbusbind): Allocate right-sized buffer for integers.
2213 * dired.c (directory_files_internal, file_name_completion, scmp)
2214 (file_name_completion_stat):
2215 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2216 (file_name_completion): Don't overflow matchcount.
2217 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
2218 * dispextern.h: Adjust decls to match defn changes elsewhere.
2219 (struct text_pos, struct glyph, struct bidi_saved_info)
2220 (struct bidi_string_data, struct bidi_it, struct composition_it)
2222 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2223 (struct display_pos, struct composition_it, struct it):
2224 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2225 * dispnew.c (increment_matrix_positions)
2226 (increment_row_positions, mode_line_string)
2227 (marginal_area_string):
2228 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2229 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
2230 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2231 (duration_to_sec_usec): New function, to check for overflow better.
2232 (Fsleep_for, sit_for): Use it.
2233 * doc.c (get_doc_string, store_function_docstring):
2234 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2235 (get_doc_string, Fsnarf_documentation):
2236 Use int, not EMACS_INT, where int is wide enough.
2238 Use SAFE_ALLOCA, not alloca.
2239 Check for overflow when converting EMACS_INT to off_t.
2240 * doprnt.c (doprnt):
2241 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2242 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
2243 Don't assume uid_t fits into fixnum.
2244 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
2245 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
2246 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
2247 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
2248 (general_insert_function)
2249 (Finsert_char, make_buffer_string, make_buffer_string_both)
2250 (update_buffer_properties, Fbuffer_substring)
2251 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
2252 (Fsubst_char_in_region, check_translation)
2253 (Ftranslate_region_internal, save_restriction_restore, Fformat)
2254 (transpose_markers, Ftranspose_regions):
2255 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2256 (clip_to_bounds): Move to lisp.h as an inline function).
2257 (Fconstrain_to_field): Don't assume integers are nonnegative.
2258 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
2259 (Fsubst_char_in_region, Fsave_restriction):
2260 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2261 (Femacs_pid): Don't assume pid_t fits into fixnum.
2262 (lo_time): Use int, not EMACS_INT, when int suffices.
2263 (lisp_time_argument): Check for usec out of range.
2264 (Fencode_time): Don't assume fixnum fits in int.
2265 (Fuser_login_name, Fuser_full_name): Signal an error
2266 if a uid argument is out of range, rather than relying on
2268 (Fformat_time_string): Remove now-unnecessary check.
2269 lisp_time_argument checks for out-of-range usec now.
2270 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
2271 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
2272 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
2273 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
2274 (init_cmdargs, Fdump_emacs):
2275 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2276 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
2277 the bottom (typically) 32 bits of the fixnum.
2278 * eval.c (specpdl_size, call_debugger):
2279 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2280 (when_entered_debugger, Fbacktrace_debug):
2281 Don't assume fixnum can fit in int.
2282 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
2283 the object just before a buffer; this is not portable.
2284 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
2285 (grow_specpdl, unbind_to):
2286 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2287 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
2288 (grow_specpdl): Simplify allocation by using xpalloc.
2289 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
2290 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
2291 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
2292 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2293 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
2295 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2296 (Fcopy_file, non_regular_nbytes, read_non_regular)
2297 (Finsert_file_contents):
2298 Use int, not EMACS_INT, where int is wide enough.
2299 (READ_BUF_SIZE): Verify that it fits in int.
2300 (Finsert_file_contents): Check that counts are in proper range,
2301 rather than assuming fixnums fit into ptrdiff_t etc.
2302 Don't assume fixnums fit into int.
2303 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
2304 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
2305 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
2306 (string_char_to_byte, string_byte_to_char)
2307 (string_make_multibyte, string_to_multibyte)
2308 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
2309 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
2310 (substring_both, Fdelete, internal_equal, Ffillarray)
2311 (Fclear_string, mapcar1)
2312 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
2313 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
2314 (larger_vector, make_hash_table, maybe_resize_hash_table)
2315 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
2316 (Fmaphash, secure_hash):
2317 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2318 (concat): Check for string index and length overflow.
2319 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
2321 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2322 (larger_vector): New API (vec, incr_min, size_max) replaces old
2323 one (vec, new_size, init). This catches size overflow.
2324 INIT was removed because it was always Qnil.
2325 All callers changed.
2326 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
2327 the upper bound on a hash table index size.
2328 (make_hash_table, maybe_resize_hash_table): Use it.
2329 (secure_hash): Computer start_byte and end_byte only after
2330 they're known to be in ptrdiff_t range.
2331 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
2332 (Ffont_get_glyphs, Ffont_at):
2333 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2334 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
2335 (Flist_fonts, Fopen_font):
2336 Don't assume fixnum can fit in int.
2337 (check_gstring): Don't assume index can fit in int.
2338 (font_match_p): Check that fixnum is a character, not a nonnegative
2339 fixnum, since the later code needs to stuff it into an int.
2340 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
2341 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
2342 conversion overflow issues.
2343 (Fopen_font): Check for integer out of range.
2344 (Ffont_get_glyphs): Don't assume index can fit in int.
2345 * font.h: Adjust decls to match defn changes elsewhere.
2346 * fontset.c (reorder_font_vector): Redo score calculation to avoid
2348 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
2349 printmax_t, where ptrdiff_t is wide enough.
2350 (Finternal_char_font):
2351 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2352 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
2353 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
2354 (Fset_frame_position, x_set_frame_parameters)
2355 (x_set_line_spacing, x_set_border_width)
2356 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
2357 Check that fixnums are in proper range for system types.
2358 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
2359 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2360 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
2361 Use SAFE_ALLOCA_LISP, not alloca.
2362 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
2363 intptr_t is wide enough.
2364 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
2365 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
2366 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
2367 Check for fixnum out of range.
2368 * ftfont.c (ftfont_list): Don't assume index fits in int.
2369 Check that fixnums are in proper range for system types.
2370 (ftfont_shape_by_flt):
2371 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2372 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2373 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2374 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
2375 Check that fixnums are in proper range for system types.
2376 * gnutls.h: Adjust decls to match defn changes elsewhere.
2377 * gtkutil.c (xg_dialog_run):
2378 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2379 (update_frame_tool_bar):
2380 Check that fixnums are in proper range for system types.
2381 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
2382 (lookup_image): Check that fixnums are in range for system types.
2383 * indent.c (last_known_column, last_known_column_point):
2384 (current_column_bol_cache):
2385 (skip_invisible, current_column, check_display_width):
2386 (check_display_width, scan_for_column, current_column_1)
2387 (Findent_to, Fcurrent_indentation, position_indentation)
2388 (indented_beyond_p, Fmove_to_column, compute_motion):
2389 (Fcompute_motion, Fvertical_motion):
2390 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2391 (last_known_column_modified): Use EMACS_INT, not int.
2392 (check_display_width):
2394 Check that fixnums and floats are in proper range for system types.
2395 (compute_motion): Don't assume index or fixnum fits in int.
2396 (compute_motion, Fcompute_motion):
2397 Use int, not EMACS_INT, when it is wide enough.
2398 (vmotion): Omit local var start_hpos that is always 0; that way
2399 we don't need to worry about overflow in expressions involving it.
2400 * indent.h: Adjust decls to match defn changes elsewhere.
2402 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2403 Use int, not EMACS_INT, where int is wide enough.
2404 Remove unused members ovstring_chars_done and tab_offset;
2406 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
2407 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
2408 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
2409 (make_gap, copy_text, insert, insert_and_inherit)
2410 (insert_before_markers, insert_before_markers_and_inherit)
2411 (insert_1, count_combining_before, count_combining_after)
2412 (insert_1_both, insert_from_string)
2413 (insert_from_string_before_markers, insert_from_string_1)
2414 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
2415 (adjust_after_replace, adjust_after_insert, replace_range)
2416 (replace_range_2, del_range, del_range_1, del_range_byte)
2417 (del_range_both, del_range_2, modify_region)
2418 (prepare_to_modify_buffer, signal_before_change)
2419 (signal_after_change, Fcombine_after_change_execute):
2420 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2421 * intervals.c (traverse_intervals, rotate_right, rotate_left)
2422 (balance_an_interval, split_interval_right, split_interval_left)
2423 (find_interval, next_interval, update_interval)
2424 (adjust_intervals_for_insertion, delete_node, delete_interval)
2425 (interval_deletion_adjustment, adjust_intervals_for_deletion)
2426 (static_offset_intervals, offset_intervals)
2427 (merge_interval_right, merge_interval_left, make_new_interval)
2428 (graft_intervals_into_buffer, temp_set_point_both)
2429 (temp_set_point, set_point, adjust_for_invis_intang)
2430 (set_point_both, move_if_not_intangible, get_property_and_range)
2431 (get_local_map, copy_intervals, copy_intervals_to_string)
2432 (compare_string_intervals, set_intervals_multibyte_1):
2433 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2434 * intervals.h: Adjust decls to match defn changes elsewhere.
2436 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2437 * keyboard.c (this_command_key_count, this_single_command_key_start)
2438 (before_command_key_count, before_command_echo_length, echo_now)
2439 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
2440 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
2441 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
2442 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
2443 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2444 (last_non_minibuf_size, last_point_position, echo_truncate)
2445 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
2446 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
2447 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
2448 (stuff_buffered_input):
2449 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2450 (last_auto_save, command_loop_1, read_char):
2451 Use EMACS_INT, not int, to avoid integer overflow.
2452 (record_char): Avoid overflow in total_keys computation.
2453 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
2454 * keyboard.h: Adjust decls to match defn changes elsewhere.
2455 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
2456 (Fkey_description, Fdescribe_vector, Flookup_key):
2457 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2458 (click_position): New function, to check that positions are in range.
2459 (Fcurrent_active_maps):
2461 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2462 (Faccessible_keymaps, Fkey_description):
2463 (preferred_sequence_p):
2464 Don't assume fixnum can fit into int.
2465 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
2466 Check for integer overflow in size calculations.
2467 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
2468 avoid mishandling large integers.
2469 * lisp.h: Adjust decls to match defn changes elsewhere.
2470 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
2471 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
2472 (struct Lisp_Marker):
2473 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2474 (clip_to_bounds): Now an inline function, moved here from editfns.c.
2475 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
2476 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
2477 All callers changed.
2478 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
2479 Assume the arg has valid form, since it always does.
2480 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
2481 unsigned integer system type.
2482 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
2483 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
2484 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2485 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
2486 (duration_to_sec_usec): New decl.
2487 * lread.c (read_from_string_index, read_from_string_index_byte)
2488 (read_from_string_limit, readchar, unreadchar, openp)
2489 (read_internal_start, read1, oblookup):
2490 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2491 (Fload, readevalloop, Feval_buffer, Feval_region):
2492 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2493 (openp): Check for out-of-range argument to 'access'.
2494 (read1): Use int, not EMACS_INT, where int is wide enough.
2495 Don't assume fixnum fits into int.
2496 Fix off-by-one error that can read outside a buffer.
2497 (read_filtered_event): Use duration_to_sec_usec
2498 to do proper overflow checking on durations.
2499 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
2500 in size calculation.
2501 (Fexecute_kbd_macro):
2502 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2503 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
2504 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
2505 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
2506 (set_marker_both, set_marker_restricted_both, marker_position)
2507 (marker_byte_position, Fbuffer_has_markers_at):
2508 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2509 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
2510 * menu.c (ensure_menu_items): Rename from grow_menu_items.
2511 It now merely ensures that the menu is large enough, without
2512 necessarily growing it, as this avoids some integer overflow issues.
2513 All callers changed.
2514 (keymap_panes, parse_single_submenu, Fx_popup_menu):
2515 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2516 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
2517 Use SAFE_ALLOCA_LISP, not alloca.
2518 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
2519 to EMACS_INT. Check that fixnums are in proper range for system types.
2520 * minibuf.c (minibuf_prompt_width, string_to_object)
2521 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
2522 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
2523 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2524 (get_minibuffer, read_minibuf_unwind):
2525 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2526 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
2527 this simplifies overflow checking. All callers changed.
2528 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
2530 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2531 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
2532 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
2533 Check that fixnums are in proper range for system types.
2534 (Fx_create_frame, Fx_show_tip):
2535 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2536 * nsfont.m (ns_findfonts, nsfont_list_family):
2537 Don't assume fixnum fits in long.
2538 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
2539 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2540 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
2542 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
2543 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2544 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
2545 (PRINTDECLARE, PRINTPREPARE):
2546 (strout, print_string):
2547 (print, print_preprocess, print_check_string_charset_prop)
2549 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2551 (temp_output_buffer_setup, Fprin1_to_string, print_object):
2552 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2553 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
2554 (printchar, strout): Use xpalloc to catch size calculation overflow.
2555 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
2556 (print_error_message): Use SAFE_ALLOCA, not alloca.
2557 (print_object): Use int, not EMACS_INT, where int is wide enough.
2558 (print_depth, new_backquote_output, print_number_index):
2559 Use ptrdiff_t, not int, where int might not be wide enough.
2560 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
2561 (Fset_process_window_size, Fformat_network_address)
2562 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
2564 Check that fixnums are in proper range for system types.
2565 (Fsignal_process): Simplify by avoiding a goto.
2566 Check for process-ids out of pid_t range rather than relying on
2568 (process_tick, update_tick): Use EMACS_INT, not int.
2569 (Fformat_network_address, read_process_output, send_process)
2570 (Fprocess_send_region, status_notify):
2571 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2572 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
2573 (wait_reading_process_output, read_process_output, exec_sentinel):
2574 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2575 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
2576 (Faccept_process_output): Use duration_to_sec_usec to do proper
2577 overflow checking on durations.
2578 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
2579 Don't assume pid_t fits in int.
2580 * process.h (struct Lisp_Process): Members tick and update_tick
2581 are now of type EMACS_INT, not int.
2582 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
2583 configured --with-wide-int.
2584 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
2585 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
2586 * search.c (looking_at_1, string_match_1):
2587 (fast_string_match, fast_c_string_match_ignore_case)
2588 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
2589 (scan_newline, find_before_next_newline, search_command)
2590 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
2591 (set_search_regs, wordify):
2594 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2595 (string_match_1, search_buffer, set_search_regs):
2597 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2598 (wordify): Check for overflow in size calculation.
2599 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
2600 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
2601 Check that fixnums are in proper range for system types.
2602 * sound.c (struct sound_device)
2603 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
2604 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2605 (Fplay_sound_internal):
2606 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2607 * syntax.c (struct lisp_parse_state, find_start_modiff)
2608 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
2609 (Fparse_partial_sexp):
2610 Don't assume fixnums can fit in int.
2611 (struct lisp_parse_state, find_start_pos, find_start_value)
2612 (find_start_value_byte, find_start_begv)
2613 (update_syntax_table, char_quoted, dec_bytepos)
2614 (find_defun_start, prev_char_comend_first, back_comment):
2615 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
2616 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
2617 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2618 (Finternal_describe_syntax_value): Check that match_lisp is a
2619 character, not an integer, since the code stuffs it into int.
2620 (scan_words, scan_sexps_forward):
2621 Check that fixnums are in proper range for system types.
2623 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2624 (scan_sexps_forward):
2625 Use CHARACTERP, not INTEGERP, since the value must fit into int.
2626 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
2627 * syntax.h: Adjust decls to match defn changes elsewhere.
2628 (struct gl_state_s):
2629 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2630 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
2631 MOST_POSITIVE_FIXNUM.
2632 * sysdep.c (wait_for_termination_1, wait_for_termination)
2633 (interruptible_wait_for_termination, mkdir):
2634 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
2635 (emacs_read, emacs_write):
2636 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2637 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
2638 and double all fit in int.
2639 * term.c (set_tty_color_mode):
2640 Check that fixnums are in proper range for system types.
2641 * termhooks.h (struct input_event):
2642 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2643 * textprop.c (validate_interval_range, interval_of)
2644 (Fadd_text_properties, set_text_properties_1)
2645 (Fremove_text_properties, Fremove_list_of_text_properties)
2646 (Ftext_property_any, Ftext_property_not_all)
2647 (copy_text_properties, text_property_list, extend_property_ranges)
2648 (verify_interval_modification):
2649 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2650 (Fnext_single_char_property_change)
2651 (Fprevious_single_char_property_change):
2652 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2653 (copy_text_properties):
2654 Check for integer overflow in index calculation.
2655 * undo.c (last_boundary_position, record_point, record_insert)
2656 (record_delete, record_marker_adjustment, record_change)
2657 (record_property_change):
2658 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2659 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
2660 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2661 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2662 (Fx_hide_tip, Fx_file_dialog):
2663 * w32menu.c (set_frame_menubar):
2664 Use ptrdiff_t, not int, for consistency with rest of code.
2665 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
2666 (select_window, Fdelete_other_windows_internal)
2667 (window_scroll_pixel_based, window_scroll_line_based)
2668 (Frecenter, Fset_window_configuration):
2669 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2670 (Fset_window_hscroll, run_window_configuration_change_hook)
2671 (set_window_buffer, temp_output_buffer_show, scroll_command)
2672 (Fscroll_other_window, Frecenter):
2673 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2674 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
2675 Don't assume fixnum fits in int.
2676 (Fset_window_scroll_bars):
2677 Check that fixnums are in proper range for system types.
2678 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
2679 (string_pos, c_string_pos, number_of_chars, init_iterator)
2680 (in_ellipses_for_invisible_text_p, init_from_display_pos)
2681 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
2682 (compute_display_string_end, handle_face_prop)
2683 (face_before_or_after_it_pos, handle_invisible_prop)
2684 (handle_display_prop, handle_display_spec, handle_single_display_spec)
2685 (display_prop_intangible_p, string_buffer_position_lim)
2686 (string_buffer_position, handle_composition_prop, load_overlay_strings)
2687 (get_overlay_strings_1, get_overlay_strings)
2688 (iterate_out_of_display_property, forward_to_next_line_start)
2689 (back_to_previous_visible_line_start, reseat, reseat_to_string)
2690 (get_next_display_element, set_iterator_to_next)
2691 (get_visually_first_element, compute_stop_pos_backwards)
2692 (handle_stop_backwards, next_element_from_buffer)
2693 (move_it_in_display_line_to, move_it_in_display_line)
2694 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2695 (add_to_log, message_dolog, message_log_check_duplicate)
2696 (message2, message2_nolog, message3, message3_nolog
2697 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
2698 (current_message_1, truncate_echo_area, truncate_message_1)
2699 (set_message, set_message_1, store_mode_line_noprop)
2700 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
2701 (text_outside_line_unchanged_p, check_point_in_composition)
2702 (reconsider_clip_changes)
2703 (redisplay_internal, set_cursor_from_row, try_scrolling)
2704 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
2705 (redisplay_window, find_last_unchanged_at_beg_row)
2706 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
2707 (trailing_whitespace_p, find_row_edges, display_line)
2708 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
2709 (display_mode_element, store_mode_line_string)
2710 (pint2str, pint2hrstr, decode_mode_spec)
2711 (display_count_lines, display_string, draw_glyphs)
2712 (x_produce_glyphs, x_insert_glyphs)
2713 (rows_from_pos_range, mouse_face_from_buffer_pos)
2714 (fast_find_string_pos, mouse_face_from_string_pos)
2715 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2716 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2717 (safe_call, init_from_display_pos, handle_fontified_prop)
2718 (handle_single_display_spec, load_overlay_strings)
2719 (with_echo_area_buffer, setup_echo_area_for_printing)
2720 (display_echo_area, echo_area_display)
2721 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
2722 (update_tool_bar, hscroll_window_tree, redisplay_internal)
2723 (redisplay_window, dump_glyph_row, display_mode_line)
2724 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
2725 (handle_display_spec, display_prop_string_p):
2726 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2727 (handle_single_display_spec, build_desired_tool_bar_string)
2728 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
2729 (get_specified_cursor_type):
2730 Check that fixnums are in proper range for system types.
2731 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
2732 (Flookup_image_map):
2733 Don't assume fixnums fit in int.
2734 (compare_overlay_entries):
2735 Avoid mishandling comparisons due to subtraction overflow.
2736 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
2737 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
2738 (handle_tool_bar_click):
2739 Use int, not unsigned, since we prefer signed and the signedness
2740 doesn't matter here.
2741 (get_next_display_element, next_element_from_display_vector):
2742 Use int, not EMACS_INT, when int is wide enough.
2743 (start_hourglass): Use duration_to_sec_usec to do proper
2744 overflow checking on durations.
2745 * xfaces.c (Fbitmap_spec_p):
2746 Check that fixnums are in proper range for system types.
2747 (compare_fonts_by_sort_order):
2748 Avoid mishandling comparisons due to subtraction overflow.
2749 (Fx_family_fonts, realize_basic_faces):
2750 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2752 Don't assume fixnum fits in int.
2753 Use SAFE_ALLOCA_LISP, not alloca.
2754 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
2755 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
2756 (face_at_buffer_position, face_for_overlay_string)
2757 (face_at_string_position):
2758 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2759 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
2760 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
2762 Check that fixnums are in proper range for system types.
2763 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2764 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
2765 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2766 (Fx_change_window_property): Don't assume fixnums fit in int.
2767 * xfont.c (xfont_chars_supported):
2768 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2769 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
2770 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
2771 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2772 * xml.c (parse_region):
2773 * xrdb.c (magic_file_p):
2774 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2775 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
2776 (x_get_local_selection, x_reply_selection_request)
2777 (x_handle_selection_request, wait_for_property_change):
2778 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2779 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
2780 short is wide enough.
2781 (x_send_client_event): Don't assume fixnum fits in int.
2782 * xterm.c (x_x_to_emacs_modifiers):
2783 Don't assume EMACS_INT overflows nicely into int.
2784 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
2786 (handle_one_xevent): NATNUMP can eval its arg twice.
2787 (x_connection_closed):
2788 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2789 * xterm.h: Adjust decls to match defn changes elsewhere.
2790 (struct scroll_bar): Use struct vectorlike_header
2791 rather than rolling our own approximation.
2792 (SCROLL_BAR_VEC_SIZE): Remove; not used.
2794 2012-05-25 Glenn Morris <rgm@gnu.org>
2796 * lisp.mk (lisp): Update for more files being compiled now.
2798 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
2800 * lread.c: Remove `read_pure' which makes no difference.
2801 (read_pure): Remove var.
2802 (unreadpure): Remove function.
2803 (readevalloop): Don't call read_list with -1 flag.
2804 (read1, read_vector): Don't test read_pure any more.
2805 (read_list): Simplify.
2807 * fileio.c, character.h: Minor style tweaks.
2809 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
2811 * window.h (clip_changed): Remove useless declaration.
2813 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
2815 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
2816 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
2818 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
2821 This directory predates autoconf and is no longer needed nowadays.
2822 Move its few remaining bits of functionality to where they're needed.
2823 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
2824 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
2825 * m/template.h: Remove.
2826 * Makefile.in (M_FILE): Remove. All uses removed.
2827 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
2828 * lisp.h (USE_LSB_TAG):
2829 * mem-limits.h (EXCEEDS_LISP_PTR):
2830 Use VAL_MAX, not VALBITS, in #if.
2831 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
2832 (EMACS_UINT): Define unconditionally now.
2833 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
2834 (BITS_PER_EMACS_INT): New constants, replacing
2835 what used to be in config.h, but not useful in #if.
2836 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
2837 define them any more.
2838 (VAL_MAX): New macro.
2840 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
2841 BITS_PER_EMACS_INT, in #if.
2842 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
2843 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
2844 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
2845 * s/ms-w32.h (DATA_START):
2846 Move here from removed file m/intel386.h.
2847 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
2848 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
2850 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
2852 Assume C89 or later.
2853 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
2854 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
2856 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
2857 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
2858 * textprop.c, tparam.c (NULL): Remove.
2859 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
2860 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
2861 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
2862 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
2863 * xterm.c (input_signal_count): Assume volatile works.
2865 2012-05-21 Ken Brown <kbrown@cornell.edu>
2867 * xgselect.c (xg_select): Fix first argument in call to 'select'
2870 2012-05-20 Ken Brown <kbrown@cornell.edu>
2872 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
2873 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
2875 2012-05-19 Ken Brown <kbrown@cornell.edu>
2877 * xfns.c (x_in_use): Remove `static' qualifier.
2878 * xterm.h (x_in_use): Declare.
2879 * xgselect.c: Include xterm.h.
2880 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
2881 and `display_arg' (bug#9754).
2883 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
2885 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
2887 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
2888 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
2890 2012-05-18 Eli Zaretskii <eliz@gnu.org>
2892 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
2894 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
2895 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
2897 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
2898 reference to image_cache->refcount.
2899 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
2901 2012-05-17 Juri Linkov <juri@jurta.org>
2903 * search.c (Fword_search_regexp, Fword_search_backward)
2904 (Fword_search_forward, Fword_search_backward_lax)
2905 (Fword_search_forward_lax): Move functions to isearch.el
2906 (bug#10145, bug#11381).
2908 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
2910 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
2912 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
2914 * lread.c (init_obarray): Declare Qt and Qnil as special.
2916 2012-05-14 Glenn Morris <rgm@gnu.org>
2918 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
2919 Put "libexec" before "bin", for the sake of init_callproc_1.
2921 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2923 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
2925 * unexaix.c: Port to more-recent AIX compilers.
2926 (report_error, report_error_1, make_hdr, copy_sym)
2927 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
2928 Make arguments const char *, not char *, to avoid violations of C
2929 standard and to fix some AIX warnings reported by Gilles Pion.
2931 2012-05-14 Eli Zaretskii <eliz@gnu.org>
2933 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
2934 already have overlays loaded.
2935 (handle_single_display_spec): Before returning without displaying
2936 fringe bitmap, synchronize the bidi iterator with the main display
2937 iterator, by calling iterate_out_of_display_property.
2938 (iterate_out_of_display_property): Detect buffer iteration by
2939 testing that it->string is a Lisp string.
2940 (get_next_display_element): When the current object is exhausted,
2941 and there's something on it->stack, call set_iterator_to_next to
2942 proceed with what's on the stack, instead of returning zero.
2943 (set_iterator_to_next): If called at the end of a Lisp string,
2944 proceed to consider_string_end without incrementing string
2945 position. Don't increment display vector index past the end of
2946 the display vector. (Bug#11417)
2947 (pos_visible_p): Don't report a position visible when move_it_to
2948 stopped at the last line of window, which happens to be scanned
2949 backwards by the bidi iteration. (Bug#11464)
2951 2012-05-14 Eli Zaretskii <eliz@gnu.org>
2953 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
2954 and right-margin display specs even if the spec is invalid or we
2955 are on a TTY, and thus unable to display on the fringes.
2956 That's because the text with the property will not be displayed anyway,
2957 so we need to signal to the caller that this is a "replacing"
2958 display spec. This fixes display when the spec is invalid or we
2961 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2963 * unexaix.c (make_hdr): Fix typo in prototype.
2964 This bug broke the build on AIX. Problem reported by Gilles Pion.
2966 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
2968 * keyboard.c (kbd_buffer_get_event): Read special events also in
2969 batch mode. (Bug#11415)
2971 2012-05-12 Glenn Morris <rgm@gnu.org>
2973 * ns.mk: Update for ns_appbindir no longer having trailing "/".
2975 2012-05-12 Eli Zaretskii <eliz@gnu.org>
2977 * lisp.mk (lisp): Add newcomment.elc.
2979 2012-05-12 Glenn Morris <rgm@gnu.org>
2981 * Makefile.in (MKDIR_P): New, set by configure.
2982 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
2984 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
2986 Remove unused function hourglass_started.
2987 * dispextern.h (hourglass_started):
2988 * w32fns.c (hourglass_started):
2989 * xdisp.c (hourglass_started): Remove.
2991 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
2993 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
2994 Update dependencies.
2996 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
2998 * xgselect.c (xg_select): Put maxfds+1 into a var.
2999 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
3001 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
3003 2012-05-10 Dave Abrahams <dave@boostpro.com>
3005 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
3006 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
3008 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
3010 * dbusbind.c (xd_registered_buses): New internal Lisp object.
3011 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
3012 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
3013 Initialize xd_registered_buses.
3015 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
3017 Untag more efficiently if USE_LSB_TAG.
3018 This is based on a proposal by YAMAMOTO Mitsuharu in
3019 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
3020 For an admittedly artificial (nth 8000 longlist) benchmark on
3021 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
3022 Emacs's overall text size by 1%.
3023 * lisp.h (XUNTAG): New macro.
3024 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
3025 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
3026 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
3027 * eval.c (Fautoload):
3028 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
3029 * frame.h (XFRAME): Use XUNTAG.
3031 Port recent dbusbind.c changes to 32-bit --with-wide-int.
3032 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
3033 Remove unportable assumptions about print widths of types like
3035 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
3036 intptr_t when converting between pointer and integer, to avoid GCC
3037 warnings about wrong width.
3039 2012-05-09 Eli Zaretskii <eliz@gnu.org>
3041 * w32proc.c (new_child): Force Windows to reserve only 64KB of
3042 stack for each reader_thread, instead of defaulting to 8MB
3043 determined by the linker. This avoids failures in creating
3044 subprocesses on Windows 7, see the discussion in this thread:
3045 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
3047 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
3049 Fix up display of the *Minibuf-0* buffer in the mini window.
3050 * keyboard.c (read_char): Don't clear the echo area if there's no
3052 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
3053 contents of *Minibuf-0*) if there's no message displayed in its stead.
3055 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
3057 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
3060 2012-05-06 Chong Yidong <cyd@gnu.org>
3062 * lisp.mk (lisp): Update.
3064 2012-05-05 Jim Meyering <meyering@redhat.com>
3066 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
3068 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3070 * data.c (PUT_ERROR): New macro.
3071 (syms_of_data): Use it. Add new error type `user-error'.
3072 * undo.c (user_error): New function.
3073 (Fprimitive_undo): Use it.
3074 * print.c (print_error_message): Adjust print style for `user-error'.
3075 * keyboard.c (user_error): New function.
3076 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
3078 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
3080 Do not limit current-time-string to years 1000..9999.
3081 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
3082 (Fcurrent_time_string): Support any year that is supported by the
3083 underlying localtime representation. Don't use asctime, as it
3084 has undefined behavior for years outside the range -999..9999.
3086 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
3088 Fix race conditions involving setenv, gmtime, localtime, asctime.
3089 Without this fix, interrupts could mess up code that uses these
3090 nonreentrant functions, since setting TZ invalidates existing
3091 tm_zone or tzname values, and since most of these functions return
3092 pointers to static storage.
3093 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
3094 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
3095 Grow the critical sections to include not just invoking
3096 localtime/gmtime, but also accessing these functions' results
3097 including their tm_zone values if any, and any related TZ setting.
3098 (format_time_string): Last arg is now struct tm *, not struct tm **,
3099 so that the struct tm is saved in the critical section.
3100 All callers changed. Simplify allocation of initial buffer, partly
3101 motivated by the fact that memory allocation needs to be outside
3102 the critical section.
3104 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
3106 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
3107 with RESET_INTERVAL.
3109 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3110 Remove duplicated buffer name initialization.
3112 2012-05-02 Jim Meyering <jim@meyering.net>
3114 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
3116 * xfns.c (x_window): Use xstrdup (Bug#11375).
3118 2012-05-02 Eli Zaretskii <eliz@gnu.org>
3120 * xdisp.c (pos_visible_p): If already at a newline from the
3121 display string before the 'while' loop, don't walk back the glyphs
3122 from it3.glyph_row. Solves assertion violation when the display
3123 string begins with a newline (egg.el). (Bug#11367)
3125 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
3127 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
3130 2012-05-01 Glenn Morris <rgm@gnu.org>
3132 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
3133 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
3134 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
3135 All were removed before 23.1.
3137 * dispnew.c: Remove HAVE_LIBNCURSES test;
3138 it is always true on relevant platforms.
3140 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
3141 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
3143 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
3145 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
3147 * .gdbinit (xpr): Remove checks for no longer existing misc types.
3148 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
3151 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
3153 Do not avoid creating empty evaporating overlays (Bug#9642).
3154 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
3155 That is, do not delete an evaporating overlay if it becomes
3156 empty after its bounds are adjusted to fit within its buffer.
3157 This fix caused other problems, and I'm reverting it until we get
3158 to the bottom of them.
3160 2012-04-27 Chong Yidong <cyd@gnu.org>
3162 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
3164 2012-04-27 Eli Zaretskii <eliz@gnu.org>
3166 * xdisp.c (pos_visible_p): If the window start position is beyond
3167 ZV, start the display from buffer beginning. Prevents assertion
3168 violation in init_iterator when the minibuffer window is scrolled
3171 * window.c (window_scroll_pixel_based): Likewise.
3173 2012-04-27 Chong Yidong <cyd@gnu.org>
3175 * keymap.c (where_is_internal): Doc fix (Bug#10872).
3177 2012-04-27 Glenn Morris <rgm@gnu.org>
3179 * fileio.c (Fcopy_file, Fset_file_selinux_context):
3180 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
3182 2012-04-27 Eli Zaretskii <eliz@gnu.org>
3184 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
3185 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
3187 2012-04-26 Eli Zaretskii <eliz@gnu.org>
3189 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
3190 display element, check also the underlying string or buffer
3191 character. (Bug#11341)
3193 * w32menu.c: Include w32heap.h.
3194 (add_menu_item): If the call to AppendMenuW (via
3195 unicode_append_menu) fails, disable Unicode menus only if we are
3196 running on Windows 9X/Me.
3198 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
3200 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
3201 (xgetint): Add missing shift for LSB tags.
3203 2012-04-24 Martin Rudalics <rudalics@gmx.at>
3205 * keyboard.c (read_char): Don't wipe echo area for select window
3206 events: These might get delayed via `mouse-autoselect-window'
3209 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
3211 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
3212 manipulation of :loaded-from data.
3214 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
3216 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
3217 now a cons (bug#11311).
3219 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
3221 Do not create empty overlays with the evaporate property (Bug#9642).
3222 * buffer.c (Fmove_overlay): Delete an evaporating overlay
3223 if it becomes empty after its bounds are adjusted to fit within
3224 its buffer. Without this fix, in a nonempty buffer (let ((o
3225 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
3226 yields an empty overlay that has the evaporate property, which is
3227 not supposed to happen.
3229 Fix minor GTK3 problems found by static checking.
3230 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3231 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3232 (struct _EmacsFixedClass, emacs_fixed_get_type):
3233 Move decls here from emacsgtkfixed.h, since they needn't be public.
3234 (emacs_fixed_get_type): Now static.
3235 (emacs_fixed_class_init): Omit unused local.
3236 (emacs_fixed_child_type): Remove; unused.
3237 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3238 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3239 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
3240 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
3241 (EMACS_FIXED_GET_CLASS): Remove; unused.
3242 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
3244 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
3245 Problem reported by Juanma Barranquero for Windows -Wunused-function.
3247 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3249 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
3250 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
3251 (__malloc_size_t, __malloc_ptrdiff_t):
3252 Remove. All uses removed, replaced by the definiens if needed,
3253 since we can assume C89 or better now.
3254 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
3255 (protect_malloc_state, align, get_contiguous_space)
3256 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
3257 (malloc_atfork_handler_child, malloc_enable_thread)
3258 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
3259 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
3260 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
3261 (special_realloc, _realloc_internal_nolock, _realloc_internal)
3262 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
3263 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
3264 Define using prototypes, not old style.
3265 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
3266 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
3267 (align): Don't assume that signed integer overflow wraps around.
3268 Omit unused local var.
3269 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
3270 (_free_internal_nolock, memalign, mallochook, reallochook):
3271 Omit no-longer-needed casts.
3272 (valloc): Use getpagesize, not __getpagesize.
3273 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
3274 (struct hdr): The 'magic' member is now size_t, not unsigned long.
3276 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
3278 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
3280 Move functions from C to Lisp. Make non-blocking method calls
3281 the default. Implement further D-Bus standard interfaces.
3283 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
3284 (QCdbus_request_name_allow_replacement)
3285 (QCdbus_request_name_replace_existing)
3286 (QCdbus_request_name_do_not_queue)
3287 (QCdbus_request_name_reply_primary_owner)
3288 (QCdbus_request_name_reply_in_queue)
3289 (QCdbus_request_name_reply_exists)
3290 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
3291 (QCdbus_registered_serial, QCdbus_registered_method)
3292 (QCdbus_registered_signal): New Lisp objects.
3293 (XD_DEBUG_MESSAGE): Use sizeof.
3294 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
3295 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
3296 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
3297 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
3298 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
3299 (xd_signature, xd_append_arg): Allow float for integer types.
3300 (xd_get_connection_references): New function.
3301 (xd_get_connection_address): Rename from xd_initialize.
3302 Return cached address.
3303 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
3304 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
3306 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
3307 Return number of refcounts.
3308 (Fdbus_get_unique_name): Make stronger parameter check.
3309 (Fdbus_message_internal): New defun.
3310 (Fdbus_call_method, Fdbus_call_method_asynchronously)
3311 (Fdbus_method_return_internal, Fdbus_method_error_internal)
3312 (Fdbus_send_signal, Fdbus_register_service)
3313 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
3314 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
3315 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
3316 (Vdbus_compiled_version, Vdbus_runtime_version)
3317 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
3318 (Vdbus_message_type_method_return, Vdbus_message_type_error)
3319 (Vdbus_message_type_signal): New defvars.
3320 (Vdbus_registered_buses, Vdbus_registered_objects_table):
3323 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3325 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
3326 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
3327 Do not assume ptrdiff_t is the same width as 'int'.
3329 * alloc.c: Handle unusual debugging option combinations.
3330 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
3331 since the two debugging options are incompatible.
3332 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
3334 (mem_init, mem_insert, mem_insert_fixup):
3335 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
3336 (NEED_MEM_INSERT): Remove; no longer needed.
3338 2012-04-22 Leo Liu <sdl.web@gmail.com>
3340 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
3342 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3344 * sysdep.c [__FreeBSD__]: Minor cleanups.
3345 (list_system_processes, system_process_attributes) [__FreeBSD__]:
3346 Use Emacs indenting style more consistently. Avoid some casts.
3347 Use 'double' consistently rather than mixing 'float' and 'double'.
3349 2012-04-21 Eduard Wiebe <usenet@pusto.de>
3351 * sysdep.c (list_system_processes, system_process_attributes):
3352 Add implementation for FreeBSD (Bug#5243).
3354 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
3356 * lisp.mk (lisp): Update.
3358 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
3360 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
3361 It is never used otherwise.
3363 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
3365 * print.c (print_preprocess): Only check print_depth if print-circle
3367 (print_object): Check for cycles even when print-circle is nil and
3368 print-gensym is t, but only check print_depth if print-circle is nil.
3370 2012-04-20 Chong Yidong <cyd@gnu.org>
3372 * process.c (wait_reading_process_output): If EIO occurs on a pty,
3373 set the status to "failed" and ensure that sentinel is run.
3375 2012-04-20 Glenn Morris <rgm@gnu.org>
3377 * process.c (Fset_process_inherit_coding_system_flag)
3378 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
3379 (Fmake_network_process, Fmake_serial_process): Doc fix.
3381 2012-04-20 Eli Zaretskii <eliz@gnu.org>
3383 * xdisp.c (string_buffer_position_lim): Limit starting position to
3385 (set_cursor_from_row): If called for a mode-line or header-line
3386 row, return zero immediately.
3387 (try_cursor_movement): If inside continuation line, don't back up
3388 farther than the first row after the header line, if any.
3389 Don't consider the header-line row as "partially visible", even if
3390 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
3392 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
3394 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
3397 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
3398 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
3400 configure: new option --enable-gcc-warnings (Bug#11207)
3401 * Makefile.in (C_WARNINGS_SWITCH): Remove.
3402 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
3403 (ALL_CFLAGS): Use new macros rather than old.
3404 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
3405 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
3406 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
3407 -Wunused-result, -Wunused-variable. This should go away once
3408 the Emacs and Gnulib regex code is merged.
3409 (xmalloc, xrealloc): Now static.
3411 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
3413 * dired.c (Fsystem_groups): Remove unused local.
3415 2012-04-17 Glenn Morris <rgm@gnu.org>
3417 * dired.c (Fsystem_users): Doc fix.
3419 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
3421 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
3422 (syms_of_dired): Add them.
3424 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
3426 Fix minor alloc.c problems found by static checking.
3427 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
3428 New extern decls, to avoid calling undeclared functions.
3429 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
3430 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
3431 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
3432 (NEED_MEM_INSERT): New macro.
3433 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
3434 Remove one incorrect comment and fix another.
3436 Fix minor ralloc.c problems found by static checking.
3437 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3438 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
3439 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
3440 (r_alloc_sbrk): Now static.
3442 Improve ralloc.c interface checking.
3443 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3444 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
3445 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
3446 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
3447 [REL_ALLOC]: ... to here, to check interface.
3448 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
3449 Remove decls. This fixes an "It stinks!".
3451 * alloc.c (which_symbols): Fix alignment issue / type clash.
3453 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
3455 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
3456 (struct Lisp_Misc_Any): Likewise.
3457 (struct Lisp_Free): Likewise.
3458 * alloc.c (union aligned_Lisp_Symbol): Define.
3459 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
3460 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
3461 (union aligned_Lisp_Misc): Define.
3462 (MARKER_BLOCK_SIZE, struct marker_block): Use union
3463 aligned_Lisp_Misc instead of union Lisp_Misc.
3464 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
3466 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
3468 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
3469 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
3470 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
3471 * s/netbsd.h, s/sol2-6.h:
3472 Remove definition of GC_MARK_STACK, since the default now works.
3473 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
3474 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
3475 no longer the default.
3476 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
3478 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
3480 * lread.c (lisp_file_lexically_bound_p):
3481 Fix hang at ";-*-\n" (bug#11238).
3483 2012-04-14 Eli Zaretskii <eliz@gnu.org>
3485 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
3486 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
3488 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
3490 * nsterm.m (constrainFrameRect): Always constrain when there is only
3491 one screen (Bug#10962).
3493 2012-04-13 Ken Brown <kbrown@cornell.edu>
3495 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
3497 2012-04-13 Reuben Thomas <rrt@sc3d.org>
3499 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
3501 2012-04-11 Daniel Colascione <dancol@dancol.org>
3503 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
3504 against is gone. It's better to use vfork now so that when Cygwin
3505 gains a new, working vfork, we use it automatically (bug#10398).
3507 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3509 * window.c (save_window_save): Obey window-point-insertion-type.
3511 2012-04-11 Glenn Morris <rgm@gnu.org>
3513 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
3515 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3517 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
3519 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
3521 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
3522 (force_quit_count): New var.
3523 (handle_interrupt): Use it.
3525 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
3527 * w32.c (w32_delayed_load): Record the full path of the library
3528 being loaded (bug#10424).
3530 2012-04-09 Glenn Morris <rgm@gnu.org>
3532 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
3533 not just in the obarray, before snarfing them. (Bug#11036)
3535 * Makefile.in ($(leimdir)/leim-list.el):
3536 Pass EMACS rather than BUILT_EMACS.
3538 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
3540 * process.c (make_process):
3541 * process.h: Add integer `gnutls_handshakes_tried' member to
3544 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
3545 Add convenience `GNUTLS_LOG2i' macro.
3547 * gnutls.c (gnutls_log_function2i): Convenience log function.
3548 (emacs_gnutls_read): Use new log functions,
3549 `gnutls_handshakes_tried' process member, and
3550 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
3551 attempts per process (connection).
3553 2012-04-09 Chong Yidong <cyd@gnu.org>
3555 * eval.c (Fuser_variable_p, user_variable_p_eh)
3556 (lisp_indirect_variable): Functions deleted.
3557 (Fdefvar): Caller changed.
3559 * callint.c (Finteractive, Fcall_interactively):
3560 * minibuf.c (Fread_variable): Callers changed.
3562 2012-04-09 Eli Zaretskii <eliz@gnu.org>
3564 * xdisp.c (set_cursor_from_row): If the display string appears in
3565 the buffer at position that is closer to point than the position
3566 after the display string, display the cursor on the first glyph of
3567 the display string. Fixes cursor display when a 'display' text
3568 property immediately follows invisible text. (Bug#11094)
3570 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
3572 composite.c: use 'double' consistently
3573 * composite.c (get_composition_id): Use 'double' consistently
3574 instead of converting 'float' to 'double' and vice versa; this is
3575 easier to understand and avoids a GCC warning.
3577 2012-04-09 Glenn Morris <rgm@gnu.org>
3579 * Makefile.in: Generate leim-list with bootstrap-emacs, in
3580 preparation for dumping it with emacs. (Bug#4789)
3581 (leimdir): New variable.
3582 ($(leimdir)/leim-list.el): New rule.
3583 (emacs$(EXEEXT)): Depend on leim-list.el.
3585 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
3586 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
3587 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
3589 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
3591 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
3594 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
3596 * xml.c (init_libxml2_functions) [WINDOWSNT]:
3597 Remove unused local variable.
3599 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3601 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
3602 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
3603 (mark_memory): Mark Lisp_Objects only if pointers might hide in
3604 objects, as mark_maybe_pointer will catch them otherwise.
3605 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
3606 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
3608 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3610 Fix typo that broke non-Windows builds.
3611 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
3613 2012-04-07 Eli Zaretskii <eliz@gnu.org>
3615 Support building on MS-Windows with libxml2.
3617 * makefile.w32-in (OBJ2): Add xml.$(O).
3618 (GLOBAL_SOURCES): Add xml.c.
3619 ($(BLD)/xml.$(O)): New dependency list.
3621 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
3622 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
3623 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
3624 [!WINDOWSNT]: New macros.
3625 (init_libxml2_functions, libxml2_loaded_p): New functions.
3626 (parse_region): Call fn_xmlCheckVersion instead of using the macro
3627 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
3628 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
3629 Calls xmlCleanupParser only if libxml2 was loaded (or statically
3631 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
3632 Call init_libxml2_functions before calling libxml2 functions.
3633 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
3635 * emacs.c: Don't include libxml/parser.h.
3636 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
3637 xmlCleanupParser directly.
3639 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
3641 2012-04-07 Eli Zaretskii <eliz@gnu.org>
3643 * indent.c (Fvertical_motion): If there is a display string at
3644 point, use it.vpos to compute how many lines to backtrack after
3645 move_it_to point. (Bug#11133)
3647 2012-04-06 Eli Zaretskii <eliz@gnu.org>
3649 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
3650 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
3651 about subtle differences between FETCH_CHAR* and STRING_CHAR*
3652 macros related to unification of CJK characters. For the details,
3653 see the discussion following the message here:
3654 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
3656 2012-04-04 Chong Yidong <cyd@gnu.org>
3658 * keyboard.c (Vdelayed_warnings_list): Doc fix.
3660 2012-04-01 Eli Zaretskii <eliz@gnu.org>
3662 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
3663 instead of alloca. (Bug#11138)
3665 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
3667 * w32menu.c (is_simple_dialog): Properly check lisp types.
3670 2012-03-31 Eli Zaretskii <eliz@gnu.org>
3672 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
3673 position we get to after a call to move_it_to fails the
3674 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
3675 only if we wind up in a string from display property. (Bug#11063)
3677 * window.c (Fdelete_other_windows_internal): Invalidate the row
3678 and column information about mouse highlight, so that redisplay
3679 restores it after reallocating the glyph matrices. (Bug#7464)
3681 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
3682 string comes from a `display' text property, use the buffer
3683 position of that property as if we actually saw that position in
3685 (move_it_by_lines): Remove the assertion that
3686 "it->current_x == 0 && it->hpos == 0" which can be legitimately
3687 violated when there's a before-string at the beginning of a line.
3690 2012-03-30 Eli Zaretskii <eliz@gnu.org>
3692 * xdisp.c (append_space_for_newline): If the default face was
3693 remapped, use the remapped face for the appended newline.
3694 (extend_face_to_end_of_line): Use the remapped default face for
3695 extending the face to the end of the line.
3696 (display_line): Call extend_face_to_end_of_line when the default
3697 face was remapped. (Bug#11068)
3699 2012-03-29 Eli Zaretskii <eliz@gnu.org>
3701 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
3703 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3705 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
3707 2012-03-27 Glenn Morris <rgm@gnu.org>
3709 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
3712 2012-03-26 Kenichi Handa <handa@m17n.org>
3714 * dispextern.h (struct glyph): Fix previous change. Change the
3715 bit length of glyphless.ch to 25 (Bug#11082).
3717 2012-03-26 Chong Yidong <cyd@gnu.org>
3719 * keyboard.c (Vselection_inhibit_update_commands): New variable.
3720 (command_loop_1): Use it; inhibit selection update for
3721 handle-select-window too (Bug#8996).
3723 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
3725 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
3727 2012-03-25 Kenichi Handa <handa@m17n.org>
3729 * dispextern.h (struct glyph): Change the bit length of
3730 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
3732 2012-03-24 Eli Zaretskii <eliz@gnu.org>
3734 * s/ms-w32.h (tzname): Include time.h before redirecting to
3735 _tzname. Fixes the MSVC build. (Bug#9960)
3737 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
3739 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
3742 * xterm.c (XTread_socket): Only modify handling_signal if
3743 !SYNC_INPUT. (Bug#11080)
3745 2012-03-23 Eli Zaretskii <eliz@gnu.org>
3747 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
3748 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
3749 when fetching a multibyte character consumes more bytes than
3750 CHAR_BYTES returns, due to unification of CJK characters in
3751 string_char. (Bug#11073)
3753 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
3755 * process.c (wait_reading_process_output): Handle pty disconnect
3756 by refraining from sending oneself a SIGCHLD (bug#10933).
3758 2012-03-22 Chong Yidong <cyd@gnu.org>
3760 * dispextern.h (struct it): New member string_from_prefix_prop_p.
3762 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
3763 Mark string as coming from a prefix property.
3764 (handle_face_prop): Use default face for prefix strings (Bug#4281).
3765 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
3767 2012-03-21 Chong Yidong <cyd@gnu.org>
3769 * xfaces.c (Vface_remapping_alist): Doc fix.
3771 2012-03-20 Eli Zaretskii <eliz@gnu.org>
3773 * w32proc.c (Fw32_set_console_codepage)
3774 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
3777 2012-03-20 Chong Yidong <cyd@gnu.org>
3779 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
3780 to reflect default non-nil value of redisplay-dont-pause.
3782 2012-03-19 Kenichi Handa <handa@m17n.org>
3784 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
3785 it fit in a valid range (Bug#11003).
3787 2012-03-18 Eli Zaretskii <eliz@gnu.org>
3789 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
3790 that is not from display property, accept the row as a "cursor
3791 row" if one of the string's character has a non-nil `cursor'
3792 property. Fixes cursor positioning when there are newlines in
3793 overlay strings, e.g. in icomplete.el. (Bug#11035)
3795 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
3797 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
3799 2012-03-12 Chong Yidong <cyd@gnu.org>
3801 * eval.c (inhibit_lisp_code): Rename from
3802 inhibit_window_configuration_change_hook; move from window.c.
3804 * xfns.c (unwind_create_frame_1, Fx_create_frame):
3805 * window.c (run_window_configuration_change_hook)
3806 (syms_of_window): Callers changed.
3808 2012-03-11 Chong Yidong <cyd@gnu.org>
3810 * keymap.c (Fkey_description): Doc fix (Bug#9700).
3812 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
3814 2012-03-10 Chong Yidong <cyd@gnu.org>
3816 * frame.c (other_visible_frames): Don't assume the selected frame
3817 is visible (Bug#10955).
3819 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
3821 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
3823 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
3825 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
3826 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
3829 2012-03-03 Glenn Morris <rgm@gnu.org>
3831 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
3833 2012-03-02 Eli Zaretskii <eliz@gnu.org>
3835 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
3836 position past the first glyph_row that ends at ZV. (Bug#10902)
3837 (redisplay_window, next_element_from_string): Fix typos in
3839 (redisplay_window): Pass to move_it_vertically the margin in
3840 pixels, not in screen lines.
3842 2012-03-02 Glenn Morris <rgm@gnu.org>
3844 * buffer.c (buffer-list-update-hook): Doc fix.
3846 2012-02-29 Eli Zaretskii <eliz@gnu.org>
3848 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
3849 push_it before setting up the iterator for the first overlay
3850 string, even if we have an empty string loaded.
3851 (next_overlay_string): If there's an empty string on the iterator
3852 stack, pop the stack. (Bug#10903)
3854 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
3856 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
3857 Suggested by Stefan Monnier in
3858 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
3859 * alloc.c (widen_to_Lisp_Object): New static function.
3860 (mark_memory): Also mark Lisp_Objects by fetching pointer words
3861 and widening them to Lisp_Objects. This would work even if
3862 USE_LSB_TAG is defined and wide integers are used, which might
3863 happen in a future version of Emacs.
3865 2012-02-25 Chong Yidong <cyd@gnu.org>
3867 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
3870 * xselect.c (Fx_selection_exists_p): Doc fix.
3871 (x_clipboard_manager_save_all): Print an informative message
3872 before saving to clipboard manager.
3874 2012-02-24 Chong Yidong <cyd@gnu.org>
3876 * keyboard.c (process_special_events): Handle all X selection
3877 requests in kbd_buffer, not just the next one (Bug#8869).
3879 2012-02-23 Chong Yidong <cyd@gnu.org>
3881 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
3882 call when setting menu-bar-lines and tool-bar-lines parameters.
3883 (unwind_create_frame_1): New helper function.
3885 * window.c (inhibit_window_configuration_change_hook): New var.
3886 (run_window_configuration_change_hook): Obey it.
3887 (syms_of_window): Initialize it.
3889 2012-02-22 Chong Yidong <cyd@gnu.org>
3891 * xterm.c (x_draw_image_relief): Add missing type check for
3892 Vtool_bar_button_margin (Bug#10743).
3894 2012-02-21 Chong Yidong <cyd@gnu.org>
3896 * fileio.c (Vfile_name_handler_alist): Doc fix.
3898 * buffer.c (Fget_file_buffer): Protect against invalid file
3899 handler return value.
3901 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
3903 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
3904 when computing $valmask.
3906 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
3907 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
3908 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
3909 It's useless in that case, and it can cause problems on hosts
3910 that allocate halves of EMACS_INT values separately.
3911 Reported by Dan Horák. Diagnosed by Andreas Schwab in
3912 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
3913 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
3914 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
3915 it avoids undefined behavior on hosts where shifting right by more
3916 than the word width has undefined behavior.
3918 2012-02-19 Chong Yidong <cyd@gnu.org>
3920 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
3921 (Funhandled_file_name_directory, Ffile_name_as_directory)
3922 (Fdirectory_file_name, Fexpand_file_name)
3923 (Fsubstitute_in_file_name): Protect against invalid file handler
3924 return values (Bug#10845).
3926 2012-02-18 Eli Zaretskii <eliz@gnu.org>
3928 * .gdbinit (pitx): Fix incorrect references to fields of the
3931 2012-02-17 Chong Yidong <cyd@gnu.org>
3933 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
3935 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
3937 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
3938 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
3940 2012-02-15 Chong Yidong <cyd@gnu.org>
3942 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
3943 marked as special. Also, starting docstrings with * is obsolete.
3945 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
3947 * gnutls.c (emacs_gnutls_write): Fix last change.
3949 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
3951 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
3954 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
3956 * keymap.c (Fsingle_key_description): Handle char ranges.
3958 2012-02-12 Chong Yidong <cyd@gnu.org>
3960 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
3961 as that creates a dangerous corner case.
3963 * window.c (Fdelete_window_internal): Invalidate the mouse
3964 highlight (Bug#9904).
3966 2012-02-12 Glenn Morris <rgm@gnu.org>
3968 * xselect.c (Fx_own_selection_internal)
3969 (Fx_get_selection_internal, Fx_disown_selection_internal)
3970 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
3971 * nsselect.m (Fx_own_selection_internal)
3972 (Fx_disown_selection_internal, Fx_selection_exists_p)
3973 (Fx_selection_owner_p, Fx_get_selection_internal):
3974 Sync docs and argument specs with the xselect.c versions.
3976 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
3978 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
3980 2012-02-11 Eli Zaretskii <eliz@gnu.org>
3982 * w32select.c (Fx_selection_exists_p): Sync doc string and
3983 argument list with xselect.c. (Bug#10783)
3985 * w16select.c (Fx_selection_exists_p): Sync doc string and
3986 argument list with xselect.c. (Bug#10783)
3988 2012-02-10 Glenn Morris <rgm@gnu.org>
3990 * fns.c (Fsecure_hash): Doc fix.
3992 2012-02-09 Kenichi Handa <handa@m17n.org>
3994 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
3996 2012-02-07 Chong Yidong <cyd@gnu.org>
3998 * buffer.c (Fbuffer_local_variables)
3999 (buffer_lisp_local_variables): Handle unbound vars correctly;
4000 don't let Qunbound leak into Lisp.
4002 2012-02-07 Glenn Morris <rgm@gnu.org>
4004 * image.c (Fimagemagick_types): Doc fix.
4006 * image.c (imagemagick-render-type): Change it from a lisp object
4007 to an integer. Move the doc here from the lisp manual.
4008 Treat all values not equal to 0 the same.
4010 2012-02-06 Chong Yidong <cyd@gnu.org>
4012 * doc.c (store_function_docstring): Avoid applying docstring of
4013 alias to base function (Bug#2603).
4015 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
4017 * .gdbinit (pp1, pv1): Remove redundant defines.
4020 2012-02-04 Chong Yidong <cyd@gnu.org>
4022 * nsterm.m: Declare a global (Bug#10694).
4024 2012-02-04 Eli Zaretskii <eliz@gnu.org>
4026 * w32.c (get_emacs_configuration_options):
4027 Include --enable-checking, if specified, in the return value.
4029 2012-02-04 Martin Rudalics <rudalics@gmx.at>
4031 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
4032 after rounding frame sizes. (Bug#9723)
4034 2012-02-04 Eli Zaretskii <eliz@gnu.org>
4036 * keyboard.c (adjust_point_for_property): Don't position point
4037 before BEGV. (Bug#10696)
4039 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
4041 Handle overflow when computing char display width (Bug#9496).
4042 * character.c (char_width): Return EMACS_INT, not int.
4043 (char_width, c_string_width): Check for overflow when
4044 computing the width; this is possible now that individual
4045 characters can have unbounded width. Problem introduced
4046 by merge from Emacs 23 on 2012-01-19.
4048 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
4050 * dbusbind.c (Fdbus_register_method): Mention the return value
4051 :ignore in the docstring.
4053 2012-02-02 Glenn Morris <rgm@gnu.org>
4055 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
4057 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4058 Unconditionally set to t. (Bug#10673)
4059 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4060 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4061 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
4063 2012-02-02 Kenichi Handa <handa@m17n.org>
4065 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
4066 0, do not call append_composite_glyph.
4068 2012-02-02 Kenichi Handa <handa@m17n.org>
4070 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
4072 (x_produce_glyphs): If the component of a composition is a null
4073 string, set it->pixel_width to 1 to avoid zero-width glyph.
4075 2012-02-01 Eli Zaretskii <eliz@gnu.org>
4077 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
4078 first 2 arguments are identical. This makes inserting large
4079 output from a subprocess an order of magnitude faster on
4080 MS-Windows, where all sbrk'ed memory is always contiguous.
4082 2012-01-31 Glenn Morris <rgm@gnu.org>
4084 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4085 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4086 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
4088 2012-01-29 Glenn Morris <rgm@gnu.org>
4090 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
4092 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
4094 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
4096 2012-01-28 Chong Yidong <cyd@gnu.org>
4098 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
4100 2012-01-26 Chong Yidong <cyd@gnu.org>
4102 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
4104 * search.c (Fsearch_forward, Fsearch_backward): Document negative
4105 repeat counts (Bug#10507).
4107 2012-01-26 Glenn Morris <rgm@gnu.org>
4109 * lread.c (syms_of_lread): Doc fix.
4111 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
4113 * coding.c (encode_designation_at_bol): Change return value to
4116 2012-01-25 Chong Yidong <cyd@gnu.org>
4118 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
4120 2012-01-21 Chong Yidong <cyd@gnu.org>
4122 * floatfns.c (Fcopysign): Make the second argument non-optional,
4123 since nil is not allowed anyway.
4125 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
4127 * process.c (read_process_output): Use p instead of XPROCESS (proc).
4128 (send_process): Likewise.
4130 2012-01-19 Martin Rudalics <rudalics@gmx.at>
4132 * window.c (save_window_save, Fcurrent_window_configuration)
4133 (Vwindow_persistent_parameters): Do not use Qstate.
4134 Rewrite doc-strings.
4136 2012-01-19 Kenichi Handa <handa@m17n.org>
4138 * character.c (char_width): New function.
4139 (Fchar_width, c_string_width, lisp_string_width):
4140 Use char_width (Bug#9496).
4142 2012-01-16 Martin Rudalics <rudalics@gmx.at>
4144 * window.c (Vwindow_persistent_parameters): New variable.
4145 (Fset_window_configuration, save_window_save): Handle persistent
4148 2012-01-14 Eli Zaretskii <eliz@gnu.org>
4150 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
4151 thrashing the stack of the thread. (Bug#9087)
4153 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
4155 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
4157 2012-01-11 Eli Zaretskii <eliz@gnu.org>
4159 * xdisp.c (rows_from_pos_range): Handle the case where the
4160 highlight ends on a newline. (Bug#10464)
4161 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
4162 he end column for display of highlight that ends on a newline
4165 2012-01-11 Glenn Morris <rgm@gnu.org>
4167 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
4168 from load-path also when installation-directory is nil. (Bug#10208)
4170 2012-01-10 Glenn Morris <rgm@gnu.org>
4172 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
4174 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
4175 Update template values to be closer to their typical values these days.
4177 2012-01-09 Eli Zaretskii <eliz@gnu.org>
4179 * xdisp.c (rows_from_pos_range): Accept additional argument
4180 DISP_STRING, and accept any glyph in a row whose object is that
4181 string as eligible for mouse highlight. Fixes mouse highlight of
4182 display strings from overlays. (Bug#10464)
4184 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
4186 emacs: fix an auto-save permissions race condition (Bug#10400)
4187 * fileio.c (auto_saving_dir_umask): New static var.
4188 (Fmake_directory_internal): Use it.
4189 (do_auto_save_make_dir): Set it, instead of invoking chmod after
4190 creating the directory. The old code temporarily assigns
4191 too-generous permissions to the directory.
4192 (do_auto_save_eh): Clear it.
4193 (Fdo_auto_save): Catch all errors, not just file errors, so
4194 that the var is always cleared.
4196 2012-01-07 Eli Zaretskii <eliz@gnu.org>
4198 * search.c (scan_buffer): Pass character positions to
4199 know_region_cache, not byte positions. (Bug#6540)
4201 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
4203 * w32.c (sys_rename): Report EXDEV when rename of a directory
4204 fails because the target is on another logical disk. (Bug#10284)
4206 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
4208 * xterm.c (x_embed_request_focus): New function.
4210 * xterm.h: Add prototype.
4212 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
4214 2012-01-05 Glenn Morris <rgm@gnu.org>
4216 * emacs.c (emacs_copyright): Update short copyright year to 2012.
4218 2012-01-01 Eli Zaretskii <eliz@gnu.org>
4220 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
4221 Load gnutls_transport_set_lowat only if GnuTLS version is below
4223 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
4224 GnuTLS versions below 2.11.1.
4226 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
4228 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
4229 to the doc string advising against its use for altering the way
4230 windows are scrolled.
4232 2011-12-28 Kenichi Handa <handa@m17n.org>
4234 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
4235 coding-system ASCII compatible only when it does not produce BOM
4236 on encoding (Bug#10383).
4238 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
4240 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
4242 (create_and_show_popup_menu): Always use menu_position_func for
4245 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
4247 * callint.c (Fcall_interactively): Don't truncate prompt string.
4249 2011-12-23 Eli Zaretskii <eliz@gnu.org>
4251 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
4252 property that ends at ZV, so that the bidi iteration could be
4253 resumed from there (after widening). (Bug#10360)
4255 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
4257 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
4259 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
4261 * nsterm.m (x_free_frame_resources):
4262 Release f->output_data.ns->miniimage.
4263 (ns_index_color): Fix indentation. Do not retain
4264 color_table->colors[i].
4266 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
4269 * nsfns.m (x_set_background_color): Assign return value from
4270 ns_index_color to face-background instead of NSColor*.
4271 (ns_implicitly_set_icon_type): Fix indentation.
4272 Change assignment in for loop to comparison.
4274 * emacs.c (ns_pool): New variable.
4275 (main): Assign ns_pool.
4276 (Fkill_emacs): Call ns_release_autorelease_pool.
4278 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
4279 autorelease fdesc, release fdAttrs and tdict.
4280 (ns_get_covering_families): Release charset.
4281 (ns_findfonts): Release NSFontDescriptor created with new.
4282 (ns_uni_to_glyphs): Fix indentation.
4283 (setString): Release attrStr before assigning new value.
4285 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4287 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
4289 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
4290 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
4292 2011-12-18 David Reitter <reitter@cmu.edu>
4294 * nsterm.m (ns_term_init): Subscribe for notifications
4295 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
4296 to method trackingNotification in EmacsMenu.
4298 * nsmenu.m (trackingMenu): New variable.
4299 (trackingNotification): New method (from Aquamacs).
4300 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
4301 from Aquamacs (Bug#7030).
4303 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4305 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
4306 (symbol_to_nsstring): Fix indentation.
4307 (ns_symbol_to_pb): New function.
4308 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
4309 (Fns_rotate_cut_buffers_internal): Remove.
4310 (Fns_store_selection_internal): Rename from
4311 Fns_store_cut_buffer_internal.
4312 (ns_get_foreign_selection, Fx_own_selection_internal)
4313 (Fx_disown_selection_internal, Fx_selection_exists_p)
4314 (Fns_get_selection_internal, Fns_store_selection_internal):
4315 Use ns_symbol_to_pb and check if return value is nil.
4316 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
4317 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
4318 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
4319 renamed to Sns_store_selection_internal.
4320 (ns_handle_selection_request): Move code to Fx_own_selection_internal
4321 and remove this function.
4322 (ns_handle_selection_clear): Remove, never used.
4323 (Fx_own_selection_internal): Move code from ns_handle_selection_request
4326 2011-12-17 Ken Brown <kbrown@cornell.edu>
4328 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
4329 GID is unknown (Bug#10257).
4331 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
4333 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
4334 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
4335 which caused a build failure on GNU/Linux IA-64. This problem was
4336 introduced by my 2011-10-07 patch.
4338 2011-12-15 Juri Linkov <juri@jurta.org>
4340 * image.c (imagemagick_error): New function. (Bug#10112)
4341 (imagemagick_load_image): Comment out `MagickSetResolution' call.
4342 Use `imagemagick_error' where ImageMagick functions return
4344 (Fimagemagick_types): Add `Fnreverse' to return the list in the
4347 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4349 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
4350 fill background (Bug#8992).
4352 2011-12-13 Martin Rudalics <rudalics@gmx.at>
4354 * window.c (Vwindow_combination_resize)
4355 (Vwindow_combination_limit): Use t instead of non-nil in
4357 (Vrecenter_redisplay): Add first sentence of doc-string on
4359 (Frecenter): Fix doc-string typo.
4361 2011-12-11 Kenichi Handa <handa@m17n.org>
4363 * coding.c (Funencodable_char_position): Pay attention to the
4364 buffer text relocation (Bug#9389).
4366 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4368 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
4369 gtk_init (Bug#10100).
4371 2011-12-10 Eli Zaretskii <eliz@gnu.org>
4373 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
4374 IT->string is nil. (Bug#10263)
4376 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4378 * nsterm.h (x_free_frame_resources): Declare.
4380 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
4381 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
4383 * nsterm.h (ns_get_defaults_value): Declare.
4385 * nsterm.m (ns_default): Call ns_get_defaults_value.
4387 2011-12-09 Eli Zaretskii <eliz@gnu.org>
4389 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
4392 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4394 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
4395 that where the value of an _OBJC_* symbol points to is in the .bss
4396 section (Bug#10240).
4398 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4400 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
4401 after the loop to call ccl_driver at least once (Bug#8619).
4403 2011-12-08 Kenichi Handa <handa@m17n.org>
4405 * ftfont.c (get_adstyle_property): Fix previous change
4408 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
4410 * w32.c (init_environment): If no_site_lisp, remove site-lisp
4411 dirs from the default value of EMACSLOADPATH (bug#10208).
4413 2011-12-07 Glenn Morris <rgm@gnu.org>
4415 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
4416 installation and source directories as well. (Bug#10208)
4418 2011-12-06 Chong Yidong <cyd@gnu.org>
4420 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
4422 2011-12-06 Glenn Morris <rgm@gnu.org>
4424 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
4425 as an error, not just -1. (Bug#10217)
4427 2011-12-05 Chong Yidong <cyd@gnu.org>
4429 * keyboard.c (process_special_events): New function.
4430 (swallow_events, Finput_pending_p): Use it (Bug#10195).
4432 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
4434 * coding.c (encode_designation_at_bol): Don't use uninitialized
4435 local variable (Bug#9318).
4437 2011-12-05 Kenichi Handa <handa@m17n.org>
4439 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
4440 return Qnil (Bug#8046, Bug#10193).
4442 2011-12-05 Kenichi Handa <handa@m17n.org>
4444 * coding.c (encode_designation_at_bol): New args charbuf_end and
4445 dst. Return the number of produced bytes. Callers changed.
4446 (coding_set_source): Return how many bytes coding->source was
4448 (coding_set_destination): Return how many bytes
4449 coding->destination was relocated.
4450 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
4451 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
4453 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4455 * coding.c (CODING_CHAR_CHARSET_P): New macro.
4456 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
4459 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
4461 The following changes are to fix Bug#9318.
4463 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
4464 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
4465 (encode_coding_iso_2022, encode_coding_sjis)
4466 (encode_coding_big5, encode_coding_charset): Use the above macros.
4468 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
4470 * lisp.h (process_quit_flag): Fix external declaration.
4472 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
4474 Don't macro-inline non-performance-critical code.
4475 * eval.c (process_quit_flag): New function.
4476 * lisp.h (QUIT): Use it.
4478 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
4480 * nsfns.m (get_geometry_from_preferences): New function.
4481 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
4483 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
4485 * emacs.c (Qkill_emacs): Define.
4486 (syms_of_emacs): Initialize it.
4487 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
4488 Qquit_flag to `kill-emacs' instead.
4489 (quit_throw_to_read_char): Add parameter `from_signal'.
4490 All callers changed. Call Fkill_emacs if requested and safe.
4491 * lisp.h (QUIT): Call Fkill_emacs if requested.
4493 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
4495 * widget.c (update_wm_hints): Return if wmshell is null.
4496 (widget_update_wm_size_hints): New function.
4498 * widget.h (widget_update_wm_size_hints): Declare.
4500 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
4501 widget_update_wm_size_hints (Bug#10104).
4503 2011-12-03 Eli Zaretskii <eliz@gnu.org>
4505 * xdisp.c (handle_invisible_prop): If the invisible text ends just
4506 before a newline, prepare the bidi iterator for consuming the
4507 newline, and keep the current paragraph direction. (Bug#10183)
4508 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
4510 2011-12-02 Juri Linkov <juri@jurta.org>
4512 * search.c (Fword_search_regexp): New Lisp function created from
4513 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
4514 (Fword_search_backward, Fword_search_forward)
4515 (Fword_search_backward_lax, Fword_search_forward_lax):
4516 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
4517 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
4519 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
4521 * fileio.c (Finsert_file_contents): Move after-change-function call
4522 to before the "handled:" label, since all "goto handled" appear in
4523 cases where the *-change-functions have already been properly called
4526 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
4528 * keyboard.c (interrupt_signal): Don't call kill-emacs when
4529 waiting for input. (Bug#10169)
4531 2011-11-30 Eli Zaretskii <eliz@gnu.org>
4533 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
4534 verifies glyph row's hash code--we have just reallocated the
4535 glyphs, so their contents can be complete garbage. (Bug#10164)
4537 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
4539 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
4541 2011-11-30 Eli Zaretskii <eliz@gnu.org>
4543 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
4544 attributes are tested _before_ calling verify_row_hash, to protect
4545 against GCC re-ordering of the tests. (Bug#10164)
4547 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
4549 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
4551 * xterm.c (handle_one_xevent): Only set async_visible and friends
4552 if net_wm_state_hidden_seen is non-zero (Bug#10002)
4553 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
4554 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
4556 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
4558 Remove GCPRO-related macros that exist only to avoid shadowing locals.
4559 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
4560 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
4561 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4562 All uses changed to use GCPRO1 etc.
4563 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
4564 Revert to old implementation (i.e., before 2011-03-11).
4566 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4568 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
4569 of scroll runs so as to avoid assigning disabled bogus rows and
4570 unnecessary graphics copy operations.
4572 2011-11-27 Eli Zaretskii <eliz@gnu.org>
4574 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
4575 (snprintf) [_MSC_VER]: Redirect to _snprintf.
4576 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
4577 (malloc, free, realloc, calloc): Redirect to e_* only when
4580 * lisp.h (GCTYPEBITS): Move before first use.
4581 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
4582 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
4583 this macro definition.
4585 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
4588 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
4590 * gtkutil.c (xg_create_frame_widgets):
4591 Call gtk_window_set_has_resize_grip (FALSE) if that function is
4592 present with Gtk+ 2.0.
4594 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4596 * fileio.c (Finsert_file_contents): Undo previous change; see
4597 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4599 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4601 Rename locals to avoid shadowing.
4602 * fileio.c (Finsert_file_contents):
4603 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
4604 * process.c (wait_reading_process_output):
4605 Rename inner 'proc' to 'p' to avoid shadowing.
4606 Indent for consistency with usual Emacs style.
4608 2011-11-25 Eli Zaretskii <eliz@gnu.org>
4610 * xdisp.c (redisplay_window): If cursor row is not fully visible
4611 after recentering, and scroll-conservatively is set to a large
4612 number, scroll window by a few more lines to make the cursor fully
4613 visible and out of scroll-margin. (Bug#10105)
4614 (start_display): Don't move to the next line if the display should
4615 start at a newline that is part of a display vector or an overlay
4618 2011-11-24 Juri Linkov <juri@jurta.org>
4620 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
4621 after the `MagickPingImage' call. (Bug#10112)
4623 2011-11-23 Chong Yidong <cyd@gnu.org>
4625 * window.c (Fcoordinates_in_window_p): Accept only live windows.
4627 2011-11-23 Martin Rudalics <rudalics@gmx.at>
4629 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
4630 making another buffer current. (Bug#10114)
4632 2011-11-23 Glenn Morris <rgm@gnu.org>
4634 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
4636 2011-11-23 Chong Yidong <cyd@gnu.org>
4638 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
4639 using it (Bug#5984).
4641 2011-11-22 Eli Zaretskii <eliz@gnu.org>
4643 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
4644 and header-lines, as they don't have one computed for them.
4647 * .gdbinit (prow): Make displayed values more self-explaining.
4648 Add row's hash code.
4650 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
4652 * process.c (wait_reading_process_output): Fix asynchrounous
4653 GnuTLS socket handling on some versions of the GnuTLS library.
4654 (wait_reading_process_output): Add comment and URL.
4656 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
4658 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
4660 2011-11-21 Chong Yidong <cyd@gnu.org>
4662 * window.c (Fnext_window, Fprevious_window): Doc fix.
4664 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4666 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
4668 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
4670 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
4672 2011-11-20 Martin Rudalics <rudalics@gmx.at>
4674 * window.c (Fset_window_combination_limit): Rename argument
4676 (Vwindow_combination_limit): Remove "status" from doc-string.
4678 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
4680 * m/ibms390.h: Remove.
4681 * m/ibms390x.h: Don't include "ibms390.h".
4683 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4685 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
4686 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
4688 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
4690 * casetab.c (Fset_case_table):
4691 * charset.c (Fcharset_after): Fix typos.
4693 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
4695 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
4696 Otherwise, valgrind does not work on some platforms.
4697 Problem reported by Andreas Schwab in
4698 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
4699 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
4700 is set, removing the need for VIRT_ADDRESS_VARIES.
4701 (PURE_P): Use a more-efficient implementation that needs just one
4702 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
4703 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
4704 to 4 (xorl, subq, cmpq, setbe).
4705 * alloc.c (pure): Always extern now, since that's the
4706 VIRT_ADDR_VARIES behavior.
4707 (PURE_POINTER_P): Use a single comparison, not two, for
4708 consistency with the new puresize.h.
4709 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
4710 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
4711 Remove VIRT_ADDR_VARIES no longer needed.
4713 2011-11-19 Eli Zaretskii <eliz@gnu.org>
4715 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
4716 (erase_phys_cursor, update_window_cursor, show_mouse_face)
4717 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
4718 behave as if the cursor position were at the window margin.
4720 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
4721 and the cursor position is out of bounds, behave as if the cursor
4722 position were at the window margin. (Bug#10075)
4724 2011-11-18 Chong Yidong <cyd@gnu.org>
4726 * window.c (Fwindow_combination_limit): Make first argument
4727 non-optional, since it is meaningless for live windows like the
4730 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
4732 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
4734 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
4736 * intervals.c: Fix grafting over the whole buffer (bug#10071).
4737 (graft_intervals_into_buffer): Simplify.
4739 2011-11-18 Eli Zaretskii <eliz@gnu.org>
4741 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
4742 hash values of the two rows.
4743 (copy_row_except_pointers): Preserve the used[] arrays and the
4744 hash values of the two rows. (Bug#10035)
4745 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
4747 * xdisp.c (row_hash): New function, body extracted from
4748 compute_line_metrics.
4749 (compute_line_metrics): Call row_hash, instead of computing the
4752 * dispnew.c (verify_row_hash): Call row_hash for computing the
4753 hash code of a row, instead of duplicating code from xdisp.c.
4755 * dispextern.h (row_hash): Add prototype.
4757 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
4759 * frame.c (delete_frame): Don't delete the terminal when the last
4760 X frame is closed if emacs is built with GTK toolkit.
4762 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
4764 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
4766 2011-11-17 Martin Rudalics <rudalics@gmx.at>
4768 * window.c (Vwindow_splits): Rename to
4769 Vwindow_combination_resize. Suggested by Juri Linkov.
4770 (Fsplit_window_internal): Use Vwindow_combination_resize instead
4773 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
4775 * nsfns.m (Fns_font_name):
4776 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
4778 2011-11-16 Martin Rudalics <rudalics@gmx.at>
4780 * window.h (window): Rename slot "nest" to "combination_limit".
4781 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
4782 (Fset_window_nest): Rename to Fset_window_combination_limit.
4783 (Vwindow_nest): Rename to Vwindow_combination_limit.
4784 (recombine_windows, make_parent_window, make_window)
4785 (Fsplit_window_internal, saved_window)
4786 (Fset_window_configuration, save_window_save): Rename all
4787 occurrences of window_nest to window_combination_limit.
4789 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
4791 * image.c (imagemagick_load_image): Fix typo.
4793 2011-11-14 Eli Zaretskii <eliz@gnu.org>
4795 * xdisp.c (display_line): Move the call to
4796 highlight_trailing_whitespace before the call to
4797 compute_line_metrics, since the latter needs to see the final
4798 faces of all the glyphs to compute ROW's hash value.
4799 Fixes assertion violations in row_equal_p. (Bug#10035)
4801 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
4803 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
4804 just return (bug#10044).
4806 2011-11-12 Eli Zaretskii <eliz@gnu.org>
4808 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
4809 with user-defined heap size. Bump the default size of the temacs
4810 heap to 27MB, to avoid memory warning when running temacs.
4811 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
4813 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
4814 current_matrix and desired_matrix. (Bug#9990)
4815 (verify_row_hash) [XASSERTS]: New function.
4816 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
4817 that the hash value of glyph rows is correct.
4819 2011-11-12 Martin Rudalics <rudalics@gmx.at>
4821 * window.h (window): Remove splits slot.
4822 * window.c (Fwindow_splits, Fset_window_splits): Remove.
4823 (Fdelete_other_windows_internal, make_parent_window)
4824 (make_window, Fsplit_window_internal, Fdelete_window_internal)
4825 (Fset_window_configuration, save_window_save): Don't deal with
4826 split status of windows.
4827 (saved_window): Remove splits slot.
4828 (Vwindow_splits): Rewrite doc-string.
4830 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
4832 * xfns.c (unwind_create_frame):
4833 * nsfns.m (unwind_create_frame):
4834 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
4835 Vframe_list (Bug#9999).
4837 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
4839 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
4841 2011-11-11 Kenichi Handa <handa@m17n.org>
4843 * callproc.c (Fcall_process): Set the member dst_multibyte of
4846 2011-11-11 Johan Bockgård <bojohan@gnu.org>
4848 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
4849 avoid a crash (bug#9496).
4851 2011-11-09 Chong Yidong <cyd@gnu.org>
4853 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
4854 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
4856 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4858 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
4860 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4862 Avoid some portability problems by eschewing 'extern inline' functions.
4863 The trivial performance wins aren't worth the portability hassles; see
4864 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
4866 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4867 (window_box_width, window_box_left, window_box_left_offset)
4868 (window_box_right, window_box_right_offset): Undo previous change,
4869 by removing the "extern"s.
4870 * intervals.c (adjust_intervals_for_insertion)
4871 (adjust_intervals_for_deletion): Undo previous change,
4872 making these static again.
4873 (offset_intervals, temp_set_point_both, temp_set_point)
4874 (copy_intervals_to_string): No longer inline.
4875 * xdisp.c (window_text_bottom_y, window_box_width)
4876 (window_box_height, window_box_left_offset)
4877 (window_box_right_offset, window_box_left, window_box_right)
4878 (window_box): No longer inline.
4880 2011-11-08 Chong Yidong <cyd@gnu.org>
4882 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
4883 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
4884 Signal an error if not a live window.
4885 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
4886 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
4888 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
4890 * lisp.h (syms_of_abbrev): Remove declaration.
4891 Reported by CHENG Gao <chenggao@royau.me>.
4893 2011-11-07 Eli Zaretskii <eliz@gnu.org>
4895 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
4896 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
4897 of temacs in GUI mode.
4899 2011-11-07 Martin Rudalics <rudalics@gmx.at>
4901 * window.h: Declare delete_all_child_windows instead of
4902 delete_all_subwindows.
4903 * window.c (Fwindow_nest, Fset_window_nest)
4904 (Fset_window_new_total, Fset_window_new_normal)
4905 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
4906 (delete_all_subwindows): Rename to delete_all_child_windows.
4907 (Fdelete_other_windows_internal, Fset_window_configuration):
4908 Call delete_all_child_windows instead of delete_all_subwindows.
4909 * frame.c (delete_frame): Call delete_all_child_windows instead
4910 of delete_all_subwindows.
4912 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
4914 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
4915 This is also needed for porting to any host where GC_MARK_STACK is
4916 not GC_MAKE_GCPROS_NOOPS.
4917 (which_symbols): Use it.
4919 2011-11-07 Kenichi Handa <handa@m17n.org>
4921 * coding.c (coding_set_destination): Check coding->src_pos only
4922 when coding->src_object is a buffer (bug#9910).
4924 * process.c (send_process): Set the member src_multibyte of coding
4925 to 0 (bug#9911) when sending a unibyte text.
4927 * callproc.c (Fcall_process): Set the member src_multibyte of
4928 process_coding to 0 (bug#9912).
4930 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4932 * xmenu.c (cleanup_widget_value_tree): New function.
4933 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
4934 calling free_menubar_widget_value_tree directly (Bug#9830).
4936 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
4938 Fix some portability problems with 'inline'.
4939 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4940 (window_box_width, window_box_left, window_box_left_offset)
4941 (window_box_right, window_box_right_offset): Declare extern.
4942 Otherwise, these inline functions do not conform to C99 and
4943 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
4944 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
4945 * intervals.c (adjust_intervals_for_insertion)
4946 (adjust_intervals_for_deletion): Now extern, because otherwise the
4947 extern inline functions 'offset_intervals' couldn't refer to it.
4948 (static_offset_intervals): Remove.
4949 (offset_intervals): Rewrite using the old contents of
4950 static_offset_intervals. The old version didn't conform to C99
4951 because an extern inline function contained a reference to an
4952 identifier with static linkage.
4954 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
4956 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
4959 2011-11-06 Eli Zaretskii <eliz@gnu.org>
4961 * xdisp.c (init_iterator, reseat_to_string): Don't set the
4962 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
4963 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
4964 return Qleft_to_right.
4966 2011-11-06 Chong Yidong <cyd@gnu.org>
4968 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
4969 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
4970 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
4971 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
4972 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
4973 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
4974 (Fwindow_vscroll): Doc fix.
4975 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
4976 argument, since it makes no sense to pass a live window and for
4977 consistency with window-child.
4979 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
4981 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
4984 2011-11-05 Jason Rumney <jasonr@gnu.org>
4986 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
4987 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
4989 (add_font_entity_to_list): Fix logic errors in mixed boolean and
4990 bitwise arithmetic preventing use of unicode-sip and non-truetype
4993 2011-11-05 Eli Zaretskii <eliz@gnu.org>
4995 * s/ms-w32.h (fstat, stat, utime): Move redirections to
4998 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
4999 initialization code to keep similarity to xfns.c after changes
5002 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
5004 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
5005 (unwind_create_frame): New function (Bug#9943).
5006 (Fx_create_frame): Restructure code to be more similar to the one in
5007 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
5008 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
5009 Move terminal->reference_count++ just before making the frame official
5012 * nsterm.m (x_free_frame_resources): New function.
5013 (x_destroy_window): Move code to x_free_frame_resources.
5015 * xfns.c (unwind_create_frame): Fix comment.
5016 (Fx_create_frame, x_create_tip_frame):
5017 Move terminal->reference_count++ just before making the frame
5018 official. Move initialization of image_cache_refcount and
5019 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
5021 2011-11-05 Eli Zaretskii <eliz@gnu.org>
5023 Support MSVC build with newer versions of Visual Studio.
5024 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
5025 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
5028 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
5029 which are not supported by MSVC.
5030 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
5031 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
5033 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
5035 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
5037 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
5039 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
5041 Support MSVC build with newer versions of Visual Studio.
5042 * w32.c: Don't include w32api.h for MSVC.
5043 (init_environment) [_MSC_VER]: Call sys_access, not _access.
5045 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
5046 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
5047 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
5048 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
5050 (alloca) [_MSC_VER]: Define to _alloca.
5052 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
5054 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
5056 2011-11-04 Eli Zaretskii <eliz@gnu.org>
5058 * xdisp.c (note_mouse_highlight): If either of
5059 previous/next-single-property-change returns nil, treat that as
5060 the beginning or the end of the buffer. (Bug#9955)
5062 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
5064 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
5065 label is not null (Bug#9951).
5066 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
5069 2011-11-04 Eli Zaretskii <eliz@gnu.org>
5071 * window.c (Fwindow_body_size): Mention in the doc string that the
5072 return value is in frame's canonical units. (Bug#9949)
5074 2011-11-03 Eli Zaretskii <eliz@gnu.org>
5076 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
5078 * w32fns.c (unwind_create_frame): If needed, free the glyph
5079 matrices of the partially constructed frame. (Bug#9943)
5080 * xfns.c (unwind_create_frame): Likewise.
5082 2011-11-01 Eli Zaretskii <eliz@gnu.org>
5084 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
5085 Don't stop backward scan on the continuation glyph, even though
5086 its CHARPOS is positive.
5087 (mouse_face_from_buffer_pos, note_mouse_highlight):
5088 Rename cover_string to disp_string.
5090 2011-11-01 Martin Rudalics <rudalics@gmx.at>
5092 * window.c (temp_output_buffer_show): Don't use
5093 Vtemp_buffer_show_specifiers.
5094 (Vtemp_buffer_show_specifiers): Remove unused variable.
5096 2011-10-30 Eli Zaretskii <eliz@gnu.org>
5098 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
5099 past the beginning of the current glyph matrix.
5101 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
5103 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
5104 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
5105 HAVE_GTK3 (Bug#9869).
5107 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
5108 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
5110 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
5112 * xterm.c: Declare x_handle_net_wm_state to return int.
5113 (handle_one_xevent): Check if we are iconified but don't have
5114 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
5115 (get_current_wm_state): Return non-zero if not hidden,
5116 check for _NET_WM_STATE_HIDDEN (Bug#9893).
5117 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
5118 (x_handle_net_wm_state): Return what get_current_wm_state returns.
5119 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
5121 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
5123 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
5124 so that this new function doesn't get optimized away by a
5125 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
5127 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5129 * frame.h (MOUSE_HL_INFO): Remove excess parens.
5131 2011-10-29 Eli Zaretskii <eliz@gnu.org>
5133 Fix the `xbytecode' command.
5134 * .gdbinit (xprintbytestr): New command.
5135 (xwhichsymbols): Rename from `which'; all callers changed.
5136 (xbytecode): Print the byte-code string as well.
5138 2011-10-29 Kim Storm <storm@cua.dk>
5140 * alloc.c (which_symbols): New function.
5142 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5144 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
5147 2011-10-29 Glenn Morris <rgm@gnu.org>
5149 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
5150 Not clear what it was for, and it causes various bugs. (Bug#9839)
5152 2011-10-28 Eli Zaretskii <eliz@gnu.org>
5154 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
5155 possible random value that matches one of those tested as
5156 condition to clear the mouse face.
5158 2011-10-28 Chong Yidong <cyd@gnu.org>
5160 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
5162 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
5164 * window.c (make_window): Initialize phys_cursor_on_p.
5166 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
5168 * lisp.h (struct Lisp_Symbol): Update comments.
5170 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
5172 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
5174 2011-10-28 Eli Zaretskii <eliz@gnu.org>
5176 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
5177 <oslsachem@gmail.com> for helping to debug this.
5179 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
5180 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
5181 (g_b_init_get_glyph_outline_w): New static variables.
5182 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
5183 (GetGlyphOutlineW_Proc): New typedefs.
5184 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
5185 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
5187 (w32font_open_internal, compute_metrics):
5188 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
5189 instead of calling the "wide" APIs directly.
5191 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
5193 * w32.h (syms_of_w32font): Add prototype.
5195 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
5197 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
5198 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
5199 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
5200 (Fmove_to_window_line): Doc fix.
5202 2011-10-27 Chong Yidong <cyd@gnu.org>
5204 * process.c (make_process): Set gnutls_state to NULL.
5206 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
5207 non-NULL, regardless of GNUTLS_INITSTAGE.
5208 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
5209 an error. Set process slots as soon as we allocate them.
5211 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
5213 2011-10-27 Chong Yidong <cyd@gnu.org>
5215 * gnutls.c (emacs_gnutls_deinit): New function.
5216 Deallocate credentials structures as well as calling gnutls_deinit.
5217 (Fgnutls_deinit, Fgnutls_boot): Use it.
5219 * process.c (make_process): Initialize GnuTLS credentials to NULL.
5220 (deactivate_process): Call emacs_gnutls_deinit.
5222 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
5224 * image.c (x_create_x_image_and_pixmap):
5225 * w32.c (sys_rename, w32_delayed_load):
5226 * w32font.c (fill_in_logfont):
5227 * w32reg.c (x_get_string_resource): Silence compiler warnings.
5229 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
5231 * w32fns.c (w32_default_color_map): New function,
5232 extracted from Fw32_default_color_map.
5233 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5235 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
5237 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
5239 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
5241 * keyboard.c (test_undefined): New function (bug#9751).
5242 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
5244 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
5246 * sysdep.c (init_sys_modes): Fix the check for the controlling
5247 terminal (Bug#6649).
5249 2011-10-20 Eli Zaretskii <eliz@gnu.org>
5251 * dispextern.h (struct bidi_it): New member next_en_type.
5253 * bidi.c (bidi_line_init): Initialize the next_en_type member.
5254 (bidi_resolve_explicit_1): When next_en_pos is valid for the
5255 current character, check also for next_en_type being WEAK_EN.
5256 (bidi_resolve_weak): Don't enter the expensive loop if the current
5257 position is before next_en_pos. Record the bidi type of the first
5258 non-ET, non-BN character we find, in addition to its position.
5259 (bidi_level_of_next_char): Invalidate next_en_type when
5260 next_en_pos is over-stepped.
5262 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
5264 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
5265 * editfns.c: Rewrite current-time-zone so that it invokes
5266 the equivalent of (format-time-string "%Z") to get the time zone name.
5267 This fixes a bug when the time zone name contains characters that
5268 need converting from the system time locale to Emacs internal format.
5269 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
5270 that patch fixed format-time-string to do the conversion, but
5271 I forgot to fix current-time-zone.
5272 (format_time_string): New function, containing most of
5273 what Fformat_time_string used to contain.
5274 (Fformat_time_string): Rewrite in terms of format_time_string.
5275 This doesn't change this function's behavior.
5276 (current-time-zone): Rewrite to use format_time_string.
5277 This fixes the bug reported by Michael Schierl in
5278 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
5279 Jason Rumney's 2007-06-07 change worked around this bug, but
5281 * systime.h (tzname, timezone): Remove no-longer-used declarations.
5283 2011-10-19 Eli Zaretskii <eliz@gnu.org>
5285 * xdisp.c (start_display): If the character at POS is displayed
5286 via a display vector, reset IT->current.dpvec_index to zero.
5287 (try_window_reusing_current_matrix): If a line ends in a display
5288 vector or the next line starts in a display vector, continue
5289 redrawing the window even though the character position of
5290 start_row was reached.
5293 2011-10-18 Chong Yidong <cyd@gnu.org>
5295 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
5296 with nobreak-char-display too.
5298 2011-10-18 Eli Zaretskii <eliz@gnu.org>
5300 Fix part 3 of bug#9771.
5301 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
5302 (bidi_resolve_neutral): Don't enter the expensive loop looking for
5303 non-neutral characters if the current character is a paragraph
5304 separator (a.k.a. Newline). This avoids running the same
5305 expensive loop twice, once when we consume the preceding newline
5306 and the other time when the line actually needs to be displayed.
5307 Avoid the loop when we see neutrals on the base embedding level
5308 following a character whose directionality is the same as the
5309 paragraph's. This avoids running the expensive loop when a line
5310 ends in a long sequence of neutrals, like control characters.
5311 Add assertion against STRONG_AL type. Slightly rearrange code
5312 that determines the type of a neutral given the first non-neutral
5314 (bidi_level_of_next_char): Set next_en_pos to zero when
5315 invalidating its info.
5317 2011-10-17 Eli Zaretskii <eliz@gnu.org>
5319 * xdisp.c (push_display_prop): Determine whether to record string
5320 or buffer position by IT->string, not by IT->method. Allow
5321 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
5322 (move_it_vertically_backward): Don't look for character position
5323 immediately after the newline when in a continuation line.
5326 2011-10-15 Martin Rudalics <rudalics@gmx.at>
5328 * window.c (coordinates_in_window): Rewrite and delabelize
5329 vertical border check. (Bug#5357) (Bug#9618)
5331 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
5333 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
5334 errors in XSetWindowBorder (bug#9310).
5336 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
5338 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
5339 avoid crash when xmalloc overrun checking is enabled.
5341 2011-10-13 Eli Zaretskii <eliz@gnu.org>
5343 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
5344 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
5345 cursor motion with <left> and <right> arrow keys.
5347 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
5348 some callers set that themselves.
5350 2011-10-12 Eli Zaretskii <eliz@gnu.org>
5352 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
5353 display string and the previous row comes from the same string and
5354 is empty. (Bug#9739) (Bug#9738)
5356 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
5358 * doc.c (get_doc_string): Encode file name (bug#9735).
5360 2011-10-12 Eli Zaretskii <eliz@gnu.org>
5362 * bidi.c (bidi_level_of_next_char):
5363 * xdisp.c (get_visually_first_element): Remove old incorrect
5364 comments regarding the Unicode Line Separator character.
5366 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
5368 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
5370 * alloc.c (Fgc_status): Do not access beyond zombies array
5371 boundary if nzombies > MAX_ZOMBIES.
5372 * alloc.c (dump_zombies): Add missing format specifier.
5374 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
5376 * xdisp.c (set_cursor_from_row): Simplify conditionals,
5377 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
5379 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
5380 Some packages use them to denote characters with modifiers.
5382 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
5384 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
5385 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
5386 matching a pp-number. Rename parameter var to var1.
5388 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
5390 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
5392 2011-10-08 Glenn Morris <rgm@gnu.org>
5394 * callint.c (Fcall_interactively): Give a more explicit error for the
5395 'c' case with a non-character input. (Bug#8479)
5397 2011-10-08 Eli Zaretskii <eliz@gnu.org>
5399 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
5401 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
5402 lines that are hscrolled on the left.
5404 * dispnew.c (buffer_posn_from_coords): Account for a possible
5405 presence of header-line. (Bug#4426)
5407 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
5409 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
5410 Don't advertise functionality which we discourage or doesn't work.
5412 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
5414 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
5415 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
5416 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
5417 this makes Emacs dump core during garbage collection on rare
5418 occasions. sizeof is obviously inferior to offsetof here, so
5419 stick with offsetof.
5420 (GC_POINTER_ALIGNMENT): New macro.
5421 (mark_memory): Omit 3rd (offset) arg; caller changed.
5422 Don't assume EMACS_INT alignment is the same as pointer alignment.
5424 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
5426 * keyboard.c (read_key_sequence_remapped): New var.
5427 (read_key_sequence): Compute remapping in the right buffer.
5428 (command_loop_1): Use read_key_sequence's remapping directly.
5430 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
5432 * dired.c (file_name_completion): Don't expand file name.
5433 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
5434 before checking file name handler.
5436 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
5437 they've been requested explicitly (bug#9591).
5439 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
5441 * keymap.c (Fsingle_key_description): Use make_specified_string
5442 instead of build_string to build string from push_key_description.
5445 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5447 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
5448 This fixes a Y2038 bug on 64-bit hosts.
5449 * buffer.c (reset_buffer):
5450 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
5451 (Fclear_buffer_auto_save_failure):
5452 Use 0, not -1, to represent an unset failure time, since time_t
5453 might not be signed.
5455 Remove dependency on glibc malloc internals.
5456 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5457 Move back here from lisp.h, but with their new implementations.
5458 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5459 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
5460 * charset.c (charset_table_init): New static var.
5461 (syms_of_charset): Use it instead of xmalloc. This removes a
5462 dependency on glibc malloc internals. See Eli Zaretskii's comment in
5463 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
5464 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5465 Move back to alloc.c.
5466 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5467 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
5469 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
5471 * nsterm.m (windowDidResize): Call x_set_window_size only when
5472 ns_in_resize is true. Otherwise set pixelwidth/height and
5473 call change_frame_size (Bug#9628).
5475 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5477 Port --enable-checking=all to Fedora 14 x86-64.
5478 * charset.c (syms_of_charset): Also account for glibc malloc's
5479 internal overhead when calculating the initial malloc maximum.
5481 Port --enable-checking=all to Fedora 14 x86.
5482 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5484 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
5485 (overrun_check_realloc, overrun_check_free):
5486 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
5487 That way, xmalloc returns a properly-aligned pointer even if
5488 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
5489 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
5490 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
5491 into account when calculating the initial malloc maximum.
5492 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5493 Move here from alloc.c, so that charset.c can use it too.
5494 Properly align; the old code wasn't right for common 32-bit hosts
5495 when configured with --enable-checking=all.
5496 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5497 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
5499 2011-09-29 Eli Zaretskii <eliz@gnu.org>
5501 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
5504 2011-09-28 Eli Zaretskii <eliz@gnu.org>
5506 * xdisp.c (compute_display_string_end): If there's no display
5507 string at CHARPOS, return -1.
5509 * bidi.c (bidi_fetch_char): When compute_display_string_end
5510 returns a negative value, treat the character as a normal
5511 character not covered by a display string. (Bug#9624)
5513 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
5515 * lread.c (Fread_from_string): Fix typo in docstring.
5517 2011-09-27 Eli Zaretskii <eliz@gnu.org>
5519 * xdisp.c (handle_invisible_prop): If invisible text ends on a
5520 newline, reseat the iterator instead of bidi-iterating there one
5521 character at a time. (Bug#9610)
5522 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
5523 TO_CHARPOS if the bidi iterator is at base embedding level.
5525 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
5527 * lread.c (readevalloop): Use correct code for NBSP.
5528 (read1): Likewise. (Bug#9608)
5530 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
5532 * dbusbind.c (Fdbus_register_signal): When service is not
5533 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
5535 2011-09-25 Glenn Morris <rgm@gnu.org>
5537 * buffer.c (truncate-lines): Doc fix.
5539 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
5541 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
5542 (Fset_window_next_buffers): Doc fix.
5544 2011-09-24 Glenn Morris <rgm@gnu.org>
5546 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
5548 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
5550 Fix minor problems found by static checking.
5551 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
5552 * indent.c (Fvertical_motion): Fix == vs = typo.
5554 2011-09-24 Eli Zaretskii <eliz@gnu.org>
5556 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
5557 Default value is now t. Doc fix.
5559 * indent.c (Fvertical_motion): Compute and apply the overshoot
5560 logic when moving up, not only when moving down. Fix the
5561 confusing name and values of the it_overshoot_expected variable;
5562 logic changes accordingly. (Bug#9254) (Bug#9549)
5564 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
5565 CHARPOS is covered by a display string which includes newlines.
5566 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
5567 is covered by a display string with embedded newlines.
5569 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
5571 * dbusbind.c (Fdbus_register_signal): Add match rule to
5572 Vdbus_registered_objects_table. (Bug#9581)
5573 (Fdbus_register_method, Vdbus_registered_objects_table):
5576 2011-09-24 Jim Meyering <meyering@redhat.com>
5578 do not ignore write error for any output size
5579 The previous change was incomplete.
5580 While it makes emacs --batch detect the vast majority of stdout
5581 write failures, errors were still ignored whenever the output size is
5582 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
5583 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
5584 && echo FAIL: ignored write error
5585 FAIL: ignored write error
5586 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
5587 && echo FAIL: ignored write error
5588 FAIL: ignored write error
5589 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
5591 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
5593 * emacs.c (Fkill_emacs): In noninteractive mode exit
5594 non-successfully if a write error occurred on stdout. (Bug#9574)
5596 2011-09-21 Eli Zaretskii <eliz@gnu.org>
5598 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
5601 * dispextern.h (struct it): Update the comment documenting what
5604 2011-09-20 Eli Zaretskii <eliz@gnu.org>
5606 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
5607 a display string, extend search for cursor position to end of row.
5608 (find_row_edges): If the row ends in a newline from a display
5609 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
5610 Handle the case of a display string with multiple newlines.
5611 (Fcurrent_bidi_paragraph_direction): Fix search for previous
5612 non-empty line. Fixes confusing cursor motion with arrow keys at
5613 the beginning of a line that starts with whitespace.
5615 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5617 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
5620 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
5622 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
5625 2011-09-18 Eli Zaretskii <eliz@gnu.org>
5627 * xdisp.c (display_line): Record maximum and minimum buffer
5628 positions even if no glyphs were produced (e.g., by a zero-width
5629 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
5630 buffer positions that will be removed from the glyph row because
5632 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
5633 column is beyond frame width: don't subtract 1 "pixel" when
5634 computing width of the stretch.
5635 (reseat_at_next_visible_line_start): Undo the change made on
5636 2011-09-17 that saved paragraph information and restored it after
5637 the call to `reseat'. (Bug#9545)
5639 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5641 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
5642 and turn window cursor on if cleared (Bug#9415).
5644 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
5646 * search.c (boyer_moore): Take unibyte characters from pattern
5647 literally. (Bug#9458)
5649 2011-09-18 Eli Zaretskii <eliz@gnu.org>
5651 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
5653 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
5655 Fix minor problem found by static checking.
5656 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
5657 initialized, to pacify gcc -Wuninitialized.
5659 * fileio.c: Report proper errno when syscall falls.
5660 (Finsert_file_contents): Save and restore errno,
5661 so that report_file_error outputs the correct diagnostic.
5662 (Fwrite_region) [CLASH_DETECTION]: Likewise.
5664 2011-09-18 Eli Zaretskii <eliz@gnu.org>
5666 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
5668 2011-09-17 Eli Zaretskii <eliz@gnu.org>
5670 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
5671 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
5673 2011-09-17 Eli Zaretskii <eliz@gnu.org>
5675 * xdisp.c (reseat_at_next_visible_line_start): Keep information
5676 about the current paragraph and restore it after the call to reseat.
5678 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
5679 (bidi_find_paragraph_start): Search back for paragraph beginning
5680 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
5681 (bidi_move_to_visually_next): Only trigger paragraph-related
5682 computations when the last character is a newline or at EOB, not
5683 just any NEUTRAL_B. (Bug#9470)
5685 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
5686 truncated lines if point is covered by a display string. (Bug#9524)
5688 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
5690 * xselect.c: Relax test for outgoing X longs (Bug#9498).
5691 (cons_to_x_long): New function.
5692 (lisp_data_to_selection_data): Use it. Correct the test for
5693 short-versus-long data; it was negated. Break out of vector
5694 loop, for efficiency, when a long datum is discovered.
5696 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
5698 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
5700 2011-09-16 Eli Zaretskii <eliz@gnu.org>
5702 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
5703 GCC PR/17406) by declaring this function with external scope.
5705 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5707 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
5708 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
5710 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
5712 * editfns.c (Fformat): Correctly handle text properties on "%%".
5714 2011-09-15 Eli Zaretskii <eliz@gnu.org>
5716 * xterm.c (x_draw_composite_glyph_string_foreground):
5717 * w32term.c (x_draw_composite_glyph_string_foreground):
5718 * term.c (encode_terminal_code):
5719 * composite.c (composition_update_it, get_composition_id):
5720 * xdisp.c (get_next_display_element)
5721 (fill_composite_glyph_string): Add comments about special meaning
5722 of TAB characters in a composition.
5724 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5726 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
5727 This occurs when processing a multibyte format.
5728 Problem reported by Wolfgang Jenker.
5730 2011-09-15 Johan Bockgård <bojohan@gnu.org>
5732 * xdisp.c (try_cursor_movement): Only check for exact match if
5733 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
5735 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5737 Remove unused external symbols.
5738 * dispextern.h (calc_pixel_width_or_height): Remove decl.
5739 * xdisp.c (calc_pixel_width_or_height): Now static.
5740 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
5741 * indent.c (check_display_width):
5742 * w32term.c: Fix comment to match code.
5743 * xterm.c, xterm.h (x_catching_errors): Remove.
5745 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5747 * xselect.c: Use signed conversions more consistently (Bug#9498).
5748 (selection_data_to_lisp_data): Assume incoming selection data are
5749 signed integers, not unsigned. This is to be consistent with
5750 outgoing selection data, which was modified to use signed integers
5751 in as part of the fix to Bug#9196 in response to Jan D.'s comment
5752 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
5753 expects long, not unsigned long.
5755 2011-09-14 Eli Zaretskii <eliz@gnu.org>
5757 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
5758 computation of loop end. Reported by Johan Bockgård
5761 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
5763 * frame.c (Fother_visible_frames_p): Function deleted.
5765 2011-09-12 Eli Zaretskii <eliz@gnu.org>
5767 * indent.c (compute_motion): Process display vector front to back
5768 rather than the other way around. (Bug#2496)
5770 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
5772 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
5774 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
5776 * minibuf.c (Fread_from_minibuffer): Doc fix.
5778 2011-09-11 Eli Zaretskii <eliz@gnu.org>
5780 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
5781 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
5783 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5785 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
5786 value for non-existent files.
5788 2011-09-11 Eli Zaretskii <eliz@gnu.org>
5790 * fileio.c (Finsert_file_contents): If the file cannot be opened,
5791 set its "size" to -1. This will set the modtime_size field of
5792 the corresponding buffer to -1, which is what
5793 verify-visited-file-modtime expects for files that do not exist.
5796 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
5798 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
5800 * lisp.h: ... from here. push_key_description is no longer
5801 defined in keyboard.c, so its declaration should not be in
5802 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
5803 logically belongs with push_key_description.
5805 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
5807 * buffer.h: Include <sys/types.h> instead of <time.h>.
5808 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
5809 Problem reported by Herbert J. Skuhra.
5811 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
5813 * xml.c (parse_region): Make the parsing work for
5814 non-comment-starting XML files again (bug#9144).
5816 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
5818 * image.c (gif_load): Fix calculation of bottom and right corner.
5821 2011-09-10 Eli Zaretskii <eliz@gnu.org>
5823 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
5824 redisplay in small windows.
5826 2011-09-09 Eli Zaretskii <eliz@gnu.org>
5828 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
5830 2011-09-08 Martin Rudalics <rudalics@gmx.at>
5832 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
5833 Operate on live windows only.
5835 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
5837 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
5839 2011-09-07 Eli Zaretskii <eliz@gnu.org>
5841 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
5842 only under bidi iteration.
5844 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
5846 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
5848 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5850 isnan: Fix porting problem to Solaris 10 with bundled gcc.
5851 Without this fix, the command to link temacs failed due to an
5852 undefined symbol __builtin_isnan. This is because
5853 /usr/include/iso/math_c99.h #defines isnan(x) to
5854 __builtin_isnan(x), but the bundled gcc, which identifies itself
5855 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
5857 * floatfns.c (isnan): #undef, and then #define to a clone of
5859 (Fisnan): Always define, since it's always available now.
5860 (syms_of_floatfns): Always define isnan at the Lisp level.
5862 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5864 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
5866 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5868 * fileio.c: Fix bugs with large file offsets (Bug#9428).
5869 The previous code assumed that file offsets (off_t values) fit in
5870 EMACS_INT variables, which is not true on typical 32-bit hosts.
5871 The code messed up by falsely reporting buffer overflow in cases
5872 such as (insert-file-contents "big" nil 1 2) into an empty buffer
5873 when "big" contains more than 2**29 bytes, even though this
5874 inserts just one byte and does not overflow the buffer.
5875 (Finsert_file_contents): Store file offsets as off_t
5876 values, not as EMACS_INT values. Check for overflow when
5877 converting between EMACS_INT and off_t. When checking for
5878 buffer overflow or for overlap, take the offsets into account.
5879 Don't use EMACS_INT for small values where int suffices.
5880 When checking for overlap, fix a typo: ZV was used where
5881 ZV_BYTE was intended.
5882 (Fwrite_region): Don't assume off_t fits into 'long'.
5883 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
5885 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
5887 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
5889 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5891 sprintf-related integer and memory overflow issues (Bug#9412).
5893 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
5894 (esprintf, exprintf, evxprintf): New functions.
5895 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
5896 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
5897 (modify_event_symbol): Do not assume that the length of
5898 name_alist_or_stem is safe to alloca and fits in int.
5899 (Fexecute_extended_command): Likewise for function name and binding.
5900 (Frecursion_depth): Wrap around reliably on integer overflow.
5901 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
5902 since some callers pass EMACS_INT values.
5903 (Fsingle_key_description): Don't crash if symbol name contains more
5904 than MAX_ALLOCA bytes.
5905 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
5906 (get_minibuffer): Arg is now EMACS_INT, not int.
5907 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
5908 (esprintf, exprintf, evxprintf): New decls.
5909 * window.h (command_loop_level, minibuf_level): Reflect API changes.
5911 * dbusbind.c (signature_cat): New function.
5912 (xd_signature, Fdbus_register_signal):
5913 Do not overrun buffer; instead, report string overflow.
5915 * dispnew.c (add_window_display_history): Don't overrun buffer.
5916 Truncate instead; this is OK since it's just a log.
5918 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
5919 even if the time zone offset is outlandishly large.
5920 Don't mishandle offset == INT_MIN.
5922 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
5923 when creating daemon; the previous buffer-overflow check was incorrect.
5925 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
5926 which has the guts of the old verror function.
5928 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
5929 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
5931 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
5932 (font_unparse_xlfd): Don't blindly alloca long strings.
5933 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
5934 fits in int, when using sprintf. Use single snprintf to count
5935 length of string rather than counting it via multiple sprintfs;
5936 that's simpler and more reliable.
5937 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
5938 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
5939 sprintf, in case result does not fit in int.
5941 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
5942 (fontset_from_font): Print it.
5944 * frame.c (tty_frame_count): Now printmax_t, not int.
5945 (make_terminal_frame, set_term_frame_name): Print it.
5946 (x_report_frame_params): In X, window IDs are unsigned long,
5947 not signed long, so print them as unsigned.
5948 (validate_x_resource_name): Check for implausibly long names,
5949 and don't assume name length fits in 'int'.
5950 (x_get_resource_string): Don't blindly alloca invocation name;
5951 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
5954 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
5955 (xg_check_special_colors, xg_set_geometry):
5956 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
5958 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
5959 Use esprintf, not sprintf, in case result does not fit in int.
5961 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5962 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
5963 it as a large positive number.
5964 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
5965 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5967 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
5968 in case result does not fit in int.
5970 * print.c (float_to_string): Detect width overflow more reliably.
5971 (print_object): Make sprintf buffer a bit bigger, to avoid potential
5972 buffer overrun. Don't assume list length fits in 'int'. Treat
5973 print length of 0 as 0, not as infinity; to be consistent with other
5974 uses of print length in this function. Don't overflow print length
5975 index. Don't assume hash table size fits in 'long', or that
5976 vectorlike size fits in 'unsigned long'.
5978 * process.c (make_process): Use printmax_t, not int, to format
5979 process-name gensyms.
5981 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
5983 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
5984 to avoid potential buffer overrun.
5986 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
5987 if X resource line is longer than 512 bytes.
5989 * xfns.c (x_window): Make sprintf buffer a bit bigger
5990 to avoid potential buffer overrun.
5992 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
5994 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
5996 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5998 Integer overflow fixes for scrolling, etc.
5999 Without these, Emacs silently mishandles large integers sometimes.
6000 For example, "C-u 4294967297 M-x recenter" was treated as if
6001 it were "C-u 1 M-x recenter" on a typical 64-bit host.
6003 * xdisp.c (try_window_id): Check Emacs fixnum range before
6004 converting to 'int'.
6006 * window.c (window_scroll_line_based, Frecenter):
6007 Check that an Emacs fixnum is in range before assigning it to 'int'.
6008 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
6009 values converted from Emacs fixnums.
6010 (Frecenter): Don't wrap around a line count if it is out of 'int'
6011 range; instead, treat it as an extreme value.
6012 (Fset_window_configuration, compare_window_configurations):
6013 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
6015 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
6016 that can exceed INT_MAX. Check that EMACS_INT value is in range
6017 before assigning it to the (possibly-narrower) index.
6018 (match_limit): Don't assume that a fixnum can fit in 'int'.
6020 * print.c (print_object): Use ptrdiff_t, not int, for index that can
6023 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
6024 (Fvertical_motion): Don't wrap around LINES values that don't fit
6025 in 'int'. Instead, treat them as extreme values. This is good
6026 enough for windows, which can't have more than INT_MAX lines anyway.
6028 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6030 * Require libxml/parser.h to avoid compilation warning.
6032 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
6034 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
6035 since this reportedly can destroy thread storage.
6037 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
6039 * syntax.c (find_defun_start): Update all cache variables if
6040 exiting early (Bug#9401).
6042 2011-08-30 Eli Zaretskii <eliz@gnu.org>
6044 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
6046 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
6047 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
6048 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
6050 * term.c (tty_append_glyph): New function.
6051 (produce_stretch_glyph): Static function and its prototype deleted.
6053 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
6056 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
6058 * image.c (parse_image_spec): Check for nonnegative, not for positive,
6059 when checking :margin (Bug#9390).
6060 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
6061 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
6062 so that the name doesn't mislead. All uses changed.
6064 2011-08-28 Johan Bockgård <bojohan@gnu.org>
6066 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
6069 2011-08-27 Eli Zaretskii <eliz@gnu.org>
6071 * xdisp.c (move_it_to): Don't bail out early when reaching
6072 position beyond to_charpos, if we are scanning backwards.
6073 (move_it_vertically_backward): When DY == 0, make sure we get to
6074 the first character in the line after the newline.
6076 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
6078 * ccl.c: Improve and simplify overflow checking (Bug#9196).
6079 (ccl_driver): Do not generate an out-of-range pointer.
6080 (Fccl_execute_on_string): Remove unnecessary check for
6081 integer overflow, noted by Stefan Monnier in
6082 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
6083 Remove a FIXME that didn't need fixing.
6084 Simplify the newly-introduced buffer reallocation code.
6086 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
6088 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
6090 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
6092 Integer and memory overflow issues (Bug#9196).
6094 * doc.c (get_doc_string): Rework so that
6095 get_doc_string_buffer_size is the actual buffer size, rather than
6096 being 1 less than the actual buffer size; this makes xpalloc more
6099 * image.c (x_allocate_bitmap_record, cache_image):
6100 * xselect.c (Fx_register_dnd_atom):
6101 Simplify previous changes by using xpalloc.
6103 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
6104 since either will do and ptrdiff_t is convenient with xpalloc.
6106 * charset.c (charset_table_size)
6107 (struct charset_sort_data.priority): Now ptrdiff_t.
6108 (charset_compare): Don't overflow if priorities differ greatly.
6109 (Fsort_charsets): Don't assume list length fits in int.
6110 Check for size-calculation overflow when allocating sort data.
6111 (syms_of_charset): Allocate an initial charset table that is
6112 just under 64 KiB, to avoid problems with glibc malloc and mmap.
6114 * cmds.c (internal_self_insert): Check for size-calculation overflow.
6116 * composite.h (struct composition.glyph_len): Now int, not unsigned.
6117 The actual value is always <= INT_MAX, and leaving it unsigned made
6118 overflow checking harder.
6120 * dispextern.h (struct glyph_matrix.rows_allocated)
6121 (struct face_cache.size): Now ptrdiff_t, for convenience in use
6122 with xpalloc. The values are still always <= INT_MAX.
6124 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
6126 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
6127 (SAFE_NALLOCA): New macro.
6129 * region-cache.c (struct boundary.pos, find_cache_boundary)
6130 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
6131 (set_cache_region, invalidate_region_cache)
6132 (revalidate_region_cache, know_region_cache, region_cache_forward)
6133 (region_cache_backward, pp_cache):
6134 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
6135 so that ptrdiff_t * can be passed to xpalloc.
6136 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
6137 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
6138 (pp_cache): Don't assume cache_len fits in int.
6139 * region-cache.h: Adjust extern decls to match.
6141 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
6142 EMACS_INT, since either will do, for xpalloc.
6144 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
6145 (xnmalloc, xnrealloc, xpalloc): New functions.
6147 * bidi.c (bidi_shelve_header_size): New constant.
6148 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
6149 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
6151 * bidi.c (bidi_cache_shrink):
6152 * buffer.c (overlays_at, overlays_in, record_overlay_string)
6154 Don't update size of array until after memory allocation succeeds,
6155 because xmalloc/xrealloc may not return.
6156 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
6157 now that we have proper integer overflow checking.
6158 (record_overlay_string, overlay_strings): Catch overflows when
6159 calculating size of overlay_str_buf.
6161 * callproc.c (Fcall_process): Check for size overflow when
6162 calculating size of args2.
6163 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
6164 Normally we prefer signed values, but sticking with ptrdiff_t would
6165 require adding more-complicated checks.
6167 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
6168 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
6169 Redo buffer-overflow calculations to avoid integer overflow.
6170 Add a FIXME comment where memory seems to be over-allocated.
6172 * character.c (Fstring): Check for size-calculation overflow.
6174 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
6175 unnecessary integer overflow. Check for size overflow.
6176 (encode_coding_object): Don't update size until xmalloc succeeds.
6178 * composite.c (get_composition_id): Check for overflow in glyph
6179 length calculations.
6181 Integer and memory overflow fixes for display code.
6182 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
6183 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
6184 (scrolling_window): Check for overflow in size calculations.
6185 (line_draw_cost, realloc_glyph_pool, add_row_entry):
6186 Don't assume glyph table len fits in int.
6187 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
6188 (row_table_size): Now ptrdiff_t, not int.
6189 (scrolling_window): Avoid overflow in size calculations.
6190 Don't update size until allocation succeeds.
6191 * fns.c (concat): Check for overflow in size calculations.
6192 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
6193 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6194 (NEXT_ALMOST_PRIME_LIMIT): New constant.
6196 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
6197 (get_doc_string): Check for size calculation overflow.
6198 Don't update size until allocation succeeds.
6199 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
6200 EMACS_INT, where ptrdiff_t will do.
6201 (Fsubstitute_command_keys): Check for string overflow.
6203 * editfns.c (set_time_zone_rule): Don't assume environment length
6205 (message_length): Now ptrdiff_t, not int.
6206 (Fmessage_box): Don't update size until allocation succeeds.
6207 Don't assume message length fits in int.
6208 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
6210 * emacs.c (main): Do not reallocate argv, since there is a null at
6211 the end that can be overwritten, and this way there's no need to
6212 worry about size-calculation overflow.
6213 (sort_args): Check for size-calculation overflow.
6215 * eval.c (init_eval_once, grow_specpdl): Don't update size until
6217 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
6219 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
6220 (x_set_scroll_bar_width, x_figure_window_size):
6221 Check for integer overflow.
6222 (x_set_alpha): Do not assume XINT fits in int.
6224 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
6225 This is for the members text_lines, text_cols, total_lines, total_cols,
6226 where the system imposes an 'int' limit.
6228 * fringe.c (Fdefine_fringe_bitmap):
6229 Don't update size until alloc works.
6231 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
6232 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
6234 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
6235 Check for size-calculation overflow.
6236 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
6237 do, as we prefer signed integers.
6238 (id_to_widget.max_size, id_to_widget.used)
6239 (xg_store_widget_in_map, xg_remove_widget_from_map)
6240 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
6241 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
6242 Use and return ptrdiff_t, not int.
6243 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
6244 * gtkutil.h: Change prototypes to match the above.
6246 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
6247 are duplicate now that they've been promoted to lisp.h.
6248 (x_allocate_bitmap_record, x_alloc_image_color)
6249 (make_image_cache, cache_image, xpm_load):
6250 Don't update size until alloc is done.
6251 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
6253 Check for size calculation overflow.
6254 (ct_colors_allocated_max): New constant.
6255 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
6258 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
6259 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
6260 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
6261 Use ptrdiff_t, not int, to count maps.
6262 (read_char_minibuf_menu_prompt): Check for overflow in size
6263 calculations. Don't update size until allocation succeeds.
6264 Redo calculations to avoid overflow.
6265 * keyboard.h: Change prototypes to match the above.
6267 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
6269 (current_minor_maps): Check for size calculation overflow.
6270 * keymap.h: Change prototypes to match the above.
6272 * lread.c (read1, init_obarray): Don't update size until alloc done.
6274 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
6275 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
6277 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
6278 Now ptrdiff_t, not int.
6279 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
6280 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
6282 * process.c (Fnetwork_interface_list): Check for overflow
6283 in size calculation.
6285 * region-cache.c (move_cache_gap): Check for size calculation overflow.
6287 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
6288 overflow. Don't bother calling xmalloc when xrealloc will do.
6290 * search.c (Freplace_match): Check for size calculation overflow.
6291 (Fset_match_data): Don't assume list lengths fit in 'int'.
6293 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
6294 for command line length. Do not attempt to address one before the
6295 beginning of an array, as that's not portable.
6297 * term.c (max_frame_lines): Remove; unused.
6298 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
6300 (encode_terminal_code, calculate_costs): Check for size
6301 calculation overflow.
6302 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
6303 table lengths and related sizes. Don't update size until alloc
6304 done. Redo calculations to avoid overflow.
6305 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
6307 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
6308 subtracting pointers.
6309 (gobble_line): Check for overflow more carefully. Don't update size
6312 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
6313 Don't update size until alloc done.
6314 Redo size calculations to avoid overflow.
6315 Check for size calculation overflow.
6316 (main) [DEBUG]: Fix typo in invoking tparam1.
6318 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
6319 Use ptrdiff_t, not int, for sizes.
6320 (store_mode_line_noprop_char): Don't update size until alloc done.
6322 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
6323 Use ptrdiff_t, not int, for sizes.
6324 (Finternal_make_lisp_face, cache_face):
6325 Check for size calculation overflow.
6326 (cache_face): Treat size calculation overflows as if they were
6327 memory exhaustion (the usual treatment), rather than aborting.
6329 * xfns.c (x_encode_text, x_set_name_internal)
6330 (Fx_change_window_property): Use ptrdiff_t, not int, to count
6331 sizes, since they can exceed INT_MAX in size. Check for size
6332 calculation overflow.
6334 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
6335 (xg_select): Check for size calculation overflow.
6336 Don't update size until alloc done.
6338 * xrdb.c (get_environ_db): Don't assume path length fits in int,
6339 as sprintf is limited to int lengths.
6341 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
6342 (X_LONG_MIN): New macros.
6343 Use them to make the following changes clearer.
6344 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
6345 This change doesn't affect the value now, but it may help remind
6346 future maintainers not to raise the value too much later.
6347 (SELECTION_QUANTUM): Remove, replacing with ...
6348 (selection_quantum): ... new function, which avoids overflow.
6350 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
6351 assumption that selection length fits in 'int'.
6352 (x_reply_selection_request, x_handle_selection_request)
6353 (x_get_window_property, receive_incremental_selection)
6354 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
6355 (lisp_data_to_selection_data, clean_local_selection_data):
6356 Use ptrdiff_t, not int, to record length of selection.
6357 (x_reply_selection_request, x_get_window_property)
6358 (receive_incremental_selection, x_property_data_to_lisp):
6359 Redo calculations to avoid overflow.
6360 (x_reply_selection_request): When sending hint, ceiling it at
6361 X_LONG_MAX rather than relying on wraparound overflow to send
6363 (x_get_window_property, receive_incremental_selection)
6364 (lisp_data_to_selection_data, x_property_data_to_lisp):
6365 Check for size-calculation overflow.
6366 (x_get_window_property, receive_incremental_selection)
6367 (lisp_data_to_selection_data, Fx_register_dnd_atom):
6368 Don't store size until memory allocation succeeds.
6369 (x_get_window_property): Plug memory leak on memory exhaustion.
6370 Don't double-block input; malloc is safe here. Don't assume 2**34
6371 - 4 fits in unsigned long. Add an xassert to check
6372 XGetWindowProperty overflow. Be more careful about overflow
6373 calculations, and distinguish size from memory overflow better.
6374 (receive_incremental_selection): When tracing, don't assume
6375 unsigned int is less than INT_MAX.
6376 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
6377 harmful) conversions of unsigned short to int.
6378 (lisp_data_to_selection_data): Don't assume that integers
6379 in the range -65535 through -1 fit in an X unsigned short.
6380 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
6381 result parameters unless successful. Rely on cons_to_unsigned
6382 to report problems with elements; the old code wasn't right anyway.
6383 (x_check_property_data): Check for int overflow; we cannot use
6384 a wider type due to X limits.
6385 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
6387 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
6389 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
6390 (x_term_init): Check for size calculation overflow.
6391 (x_color_cells): Don't store size until memory allocation succeeds.
6392 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
6393 Don't assume alloca size is less than MAX_ALLOCA.
6394 (x_term_init): Don't assume length fits in int (sprintf is limited
6397 Use ptrdiff_t for composition IDs.
6398 * character.c (lisp_string_width):
6399 * composite.c (composition_table_size, n_compositions)
6400 (get_composition_id, composition_gstring_from_id):
6401 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
6402 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
6403 * window.c (Frecenter):
6404 Use ptrdiff_t, not int, for composition IDs.
6405 * composite.c (get_composition_id): Check for integer overflow.
6406 * composite.h: Adjust prototypes to match the above changes.
6408 Use ptrdiff_t for hash table indexes.
6409 * category.c (hash_get_category_set):
6410 * ccl.c (ccl_driver):
6411 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
6412 * coding.c (coding_system_charset_list, detect_coding_system):
6413 * coding.h (struct coding_system.id):
6414 * composite.c (get_composition_id, gstring_lookup_cache):
6415 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
6416 * image.c (xpm_get_color_table_h):
6417 * lisp.h (hash_lookup, hash_put):
6418 * minibuf.c (Ftest_completion):
6419 Use ptrdiff_t for hash table indexes, not int (which is too
6420 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
6421 32-bit --with-wide-int hosts).
6423 * charset.c (Fdefine_charset_internal): Check for integer overflow.
6424 Add a FIXME comment about memory leaks.
6425 (syms_of_charset): Don't assume xmalloc returns.
6427 Don't assume that stated character widths fit in int.
6428 * character.c (Fchar_width, c_string_width, lisp_string_width):
6429 * character.h (CHAR_WIDTH):
6430 * indent.c (MULTIBYTE_BYTES_WIDTH):
6431 Use sanitize_char_width to avoid undefined and/or bad behavior
6432 with outlandish widths.
6433 * character.h (sanitize_tab_width): Rename from sanitize_width,
6434 now that we have two such functions. All uses changed.
6435 (sanitize_char_width): New inline function.
6437 Don't assume that tab-width fits in int.
6438 * character.h (sanitize_width): New inline function.
6439 (SANE_TAB_WIDTH): New macro.
6440 (ASCII_CHAR_WIDTH): Use it.
6441 * indent.c (sane_tab_width): Remove. All uses replaced by
6442 SANE_TAB_WIDTH (current_buffer).
6443 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
6445 * fileio.c: Integer overflow issues with file modes.
6446 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
6448 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
6449 Remove unreachable code.
6450 (read_hex, load_charset_map_from_file): Check for integer overflow.
6452 * xterm.c: Don't go over XClientMessageEvent limit.
6453 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
6454 (x_send_scroll_bar_event): Likewise. Check that the size does not
6455 exceed limits imposed by XClientMessageEvent, as well as the usual
6456 ptrdiff_t and size_t limits.
6458 * keyboard.c: Overflow, signedness and related fixes.
6459 (make_lispy_movement): Use same integer type in forward decl
6460 that is used in the definition.
6461 (read_key_sequence, keyremap_step):
6462 Change bufsize argument back to int, undoing my 2011-03-30 change.
6463 We prefer signed types, and int is wide enough here.
6464 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
6465 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
6466 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
6467 length, not size_t. Use ptrdiff_t for index, not int.
6468 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
6469 possibility of integer overflow.
6471 Overflow, signedness and related fixes for images.
6473 * dispextern.h (struct it.stack[0].u.image.image_id)
6474 (struct_it.image_id, struct image.id, struct image_cache.size)
6475 (struct image_cache.used, struct image_cache.ref_count):
6476 * gtkutil.c (update_frame_tool_bar):
6477 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
6478 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
6479 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
6480 * nsmenu.m (update_frame_tool_bar):
6481 * xdisp.c (calc_pixel_width_or_height):
6482 * xfns.c (image_cache_refcount):
6483 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
6484 on typical 64-bit hosts.
6486 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6487 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
6488 Omit unnecessary casts to int.
6489 (parse_image_spec): Check that integers fall into 'int' range
6490 when the callers expect that.
6491 (image_ascent): Redo ascent calculation to avoid int overflow.
6492 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
6493 (lookup_image): Remove unnecessary tests.
6494 (xbm_image_p): Locals are now of int, not EMACS_INT,
6495 since parse_image_check makes sure they fit into int.
6496 (png_load, gif_load, svg_load_image):
6497 Prefer int to unsigned where either will do.
6498 (tiff_handler): New function, combining the cores of the
6499 old tiff_error_handler and tiff_warning_handler.
6500 This function is rewritten to use vsnprintf and thereby avoid
6501 stack buffer overflows. It uses only the features of vsnprintf
6502 that are common to both POSIX and native Microsoft.
6503 (tiff_error_handler, tiff_warning_handler): Use it.
6504 (tiff_load, gif_load, imagemagick_load_image):
6505 Don't assume :index value fits in 'int'.
6506 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
6507 (imagemagick_load_image): Check that crop parameters fit into
6508 the integer types that MagickCropImage accepts. Don't assume
6509 Vimagemagick_render_type has a nonnegative value. Don't assume
6510 size_t fits in 'long'.
6511 (gs_load): Use printmax_t to print the widest integers possible.
6512 Check for integer overflow when computing image height and width.
6514 2011-08-26 Eli Zaretskii <eliz@gnu.org>
6516 * xdisp.c (redisplay_window): Don't force window start if point
6517 will be invisible in the resulting window. (Bug#9324)
6519 2011-08-25 Eli Zaretskii <eliz@gnu.org>
6521 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
6522 the display spec is of the form `(space ...)'.
6523 (handle_display_spec): Return the value returned by
6524 handle_single_display_spec, not just 1 or zero.
6525 (handle_single_display_spec): If the display spec is of the form
6526 `(space ...)', and specifies display in the text area, return 2
6528 (try_cursor_movement): Check for the need to scroll more
6529 accurately, and prefer exact match for point under bidi.
6530 Don't advance `row' beyond the last row of the window.
6532 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
6533 into disp_prop; all users changed.
6535 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
6536 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
6537 for the text covered by the display property.
6539 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
6541 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
6542 Change return value to nil.
6543 (Frecord_buffer): Delete unused function.
6545 2011-08-24 Eli Zaretskii <eliz@gnu.org>
6547 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
6548 buffers, return left-to-right.
6549 (set_cursor_from_row): Consider candidate row a win if its glyph
6550 represents a newline and point is on that newline. Fixes cursor
6551 positioning on the newline at EOL of R2L text within L2R
6552 paragraph, and vice versa.
6553 (try_cursor_movement): Check continued rows, in addition to
6554 continuation rows. Fixes unwarranted scroll when point enters a
6555 continued line of R2L text within an L2R paragraph, or vice versa.
6556 (cursor_row_p): Consider the case of point being equal to
6557 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
6558 from the end of a short line to the beginning of a continued line
6559 of R2L text within L2R paragraph.
6560 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
6561 composed characters.
6563 * bidi.c (bidi_check_type): Use xassert.
6564 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
6567 2011-08-23 Eli Zaretskii <eliz@gnu.org>
6569 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
6572 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
6574 * nsfont.m (ns_otf_to_script): Fix typo.
6576 2011-08-22 Kenichi Handa <handa@m17n.org>
6578 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
6579 extra slot even if the purpose is char-code-property-table.
6581 2011-08-23 Eli Zaretskii <eliz@gnu.org>
6583 * xdisp.c (redisplay_window): When computing centering_position,
6584 account for the height of the header line. (Bug#8874)
6586 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
6587 instead of CHAR_TO_BYTE. Fixes a crash when a completion
6588 candidate is selected by the mouse, and that candidate has a
6589 composed character under the mouse.
6591 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
6592 coordinates reported by pos-visible-in-window-p for a composed
6593 character in column zero.
6595 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
6597 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
6599 2011-08-22 Eli Zaretskii <eliz@gnu.org>
6601 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
6602 consider it a hit if to_charpos is anywhere in the range of the
6603 composed buffer positions.
6605 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
6607 * image.c (gif_load): Don't assume that each subimage has the same
6608 dimensions as the base image. Handle disposal method that is
6609 "undefined" by the gif spec (Bug#9335).
6611 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
6613 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
6614 (Fcondition_case): Document `debug' symbol in error handler.
6616 2011-08-19 Eli Zaretskii <eliz@gnu.org>
6618 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
6619 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
6620 from an Org mode buffer to a Speedbar frame.
6622 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
6623 a composition, take its buffer position from IT->cmp_it.charpos.
6624 Fixes cursor positioning at the beginning of a line that begins
6625 with a composed character.
6627 2011-08-18 Eli Zaretskii <eliz@gnu.org>
6629 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
6630 character bidirectional type, use STRONG_L instead. Fixes crashes
6631 in a buffer produced by `describe-categories'.
6633 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
6634 members before the level stack, so they would be saved and
6635 restored when copying iterator state. Fixes incorrect reordering
6636 around TABs covered by display properties.
6638 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
6640 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
6642 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
6644 * eval.c (internal_condition_case, internal_condition_case_1)
6645 (internal_condition_case_2, internal_condition_case_n):
6646 Remove unnecessary aborts (Bug#9081).
6648 2011-08-17 Eli Zaretskii <eliz@gnu.org>
6650 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
6651 has no `load' handler, try opening the file locally. (Bug#9311)
6653 2011-08-16 Ken Brown <kbrown@cornell.edu>
6655 * gmalloc.c: Expand comment.
6657 2011-08-16 Eli Zaretskii <eliz@gnu.org>
6659 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
6660 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
6662 2011-08-16 Ken Brown <kbrown@cornell.edu>
6664 Fix memory allocation problems in Cygwin build (Bug#9273).
6666 * unexcw.c ( __malloc_initialized): Declare external variable.
6667 (fixup_executable): Force the dumped emacs to reinitialize malloc.
6669 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
6671 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
6673 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
6675 [CYGWIN] (special_realloc): New function.
6676 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
6677 requests to realloc storage in the static heap.
6679 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
6681 * bidi.c (bidi_initialize): Remove unused local.
6683 2011-08-15 Eli Zaretskii <eliz@gnu.org>
6686 * biditype.h: Remove file.
6687 * makefile.w32-in ($(BLD)/bidi.$(O)):
6688 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
6690 * dispextern.h: Fix a typo in the comment to bidi_type_t.
6692 * chartab.c: Improve commentary for the uniprop_table API.
6694 * bidi.c (bidi_paragraph_init): Support zero value of
6695 bidi_ignore_explicit_marks_for_paragraph_level.
6696 (bidi_initialize): Use uniprop_table instead of including
6697 biditype.h and bidimirror.h.
6699 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
6700 coordinates of the iterator when restoring from ppos_it.
6703 2011-08-14 Kenichi Handa <handa@m17n.org>
6705 * process.c (create_process): Call setup_process_coding_systems
6706 after the pid of the process is set to -1 (Bug#8162).
6708 2011-08-14 Eli Zaretskii <eliz@gnu.org>
6710 * xdisp.c (move_it_in_display_line_to): Don't invoke
6711 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
6712 ppos_it. Fixes vertical cursor motion when line beginning is
6713 covered by an image. (Bug#9296)
6715 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
6717 * nsterm.h (ns_run_ascript): Declare.
6718 (NSAPP_DATA2_RUNASSCRIPT): Define.
6720 * nsfns.m (as_script, as_result, as_status): New static variables.
6721 (ns_run_ascript): New function.
6722 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
6723 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
6724 the event loop. Get status from as_status (Bug#7276).
6726 * nsterm.m (sendEvent): If event is NSApplicationDefined and
6727 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
6728 the event loop (Bug#7276).
6730 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
6732 * gnutls.c (QCgnutls_bootprop_priority)
6733 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
6734 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
6735 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
6736 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
6737 (QCgnutls_bootprop_verify_hostname_error)
6738 (QCgnutls_bootprop_callbacks_verify): Rename from
6739 Qgnutls_bootprop_..., all uses changed.
6741 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
6744 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
6746 * xfaces.c (Qframe_set_background_mode): Now static.
6747 * dispextern.h (Qframe_set_background_mode): Remove decl.
6749 * process.c (Fnetwork_interface_info): Declare local only if needed.
6751 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
6753 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
6754 (Fnetwork_interface_list): Allocate in increments of bytes instead
6755 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
6756 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
6758 (struct ifflag_def): notrailers is smart on OSX.
6759 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
6760 Get hardware address with getifaddrs if available.
6762 2011-08-12 Eli Zaretskii <eliz@gnu.org>
6764 * xdisp.c (iterate_out_of_display_property): xassert that
6765 IT->position is set to within IT->object's boundaries. Break from
6766 the loop as soon as EOB is reached; avoids infloops in redisplay
6767 when IT->position is set up wrongly due to some bug.
6768 Set IT->current to match the bidi iterator unconditionally.
6769 (push_display_prop): Allow GET_FROM_STRING as IT->method on
6770 entry. Force push_it to save on the stack the current
6771 buffer/string position, to be restored by pop_it. Fix flags in
6772 the iterator structure wrt the object coming from a display
6773 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
6774 properties. (Bug#9284)
6776 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
6778 * fontset.c (fontset_get_font_group): Add proper type checks.
6781 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6783 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
6784 and LC_VERSION_MIN_MACOSX.
6785 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
6786 (dump_it) [LC_FUNCTION_STARTS]: Use it.
6788 2011-08-08 Eli Zaretskii <eliz@gnu.org>
6790 * xdisp.c (forward_to_next_line_start): Allow to use the
6791 no-display-properties-and-no-overlays under bidi display.
6792 Set disp_pos in the bidi iterator to avoid searches for display
6793 properties and overlays.
6795 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
6797 * editfns.c (Fset_time_zone_rule): Document relationship with the
6800 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
6801 the font entity extracted from the cache (Bug#8109).
6803 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
6805 * composite.c (autocmp_chars): Don't reset point. That is done by
6806 restore_point_unwind (Bug#5984).
6808 2011-08-07 Juri Linkov <juri@jurta.org>
6810 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
6811 to show the arg `TIME' instead of `TIMEVAL'.
6813 2011-08-06 Eli Zaretskii <eliz@gnu.org>
6815 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
6816 display property strides EOL and includes a newline, as in
6817 longlines-mode. (Bug#9254)
6818 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
6819 word-wrap under bidirectional display. (Bug#9224)
6821 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
6822 is non-zero, even if the data buffer is NULL. Fixes a crash in
6823 vertical-motion with longlines-mode. (Bug#9254)
6825 2011-08-05 Eli Zaretskii <eliz@gnu.org>
6827 * bidi.c <bidi_cache_total_alloc>: Now static.
6828 (bidi_initialize): Initialize bidi_cache_total_alloc.
6830 * xdisp.c (display_line): Release buffer allocated for shelved bidi
6833 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
6834 amount allocated this far in `bidi_cache_total_alloc'.
6835 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
6836 non-zero, only free the data buffer without restoring the cache
6837 contents. All callers changed.
6839 * dispextern.h (bidi_unshelve_cache): Update prototype.
6841 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
6842 (move_it_in_display_line, move_it_to)
6843 (move_it_vertically_backward, move_it_by_lines): Replace the call
6844 to xfree to an equivalent call to bidi_unshelve_cache.
6845 (move_it_in_display_line_to): Fix logic of returning
6846 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
6848 2011-08-05 Eli Zaretskii <eliz@gnu.org>
6850 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
6851 came from a string character with a `cursor' property. (Bug#9229)
6853 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6855 * Makefile.in (LIB_PTHREAD): New variable.
6856 (LIBES): Add LIB_PTHREAD (Bug#9216).
6858 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
6859 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
6861 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
6863 * regex.c (re_iswctype): Remove some redundant boolean conversions.
6865 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6867 * xterm.c (x_find_topmost_parent): New function.
6868 (x_set_frame_alpha): Find topmost parent window with
6869 x_find_topmost_parent and set the property there also (bug#9181).
6870 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
6872 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
6874 * callproc.c (Fcall_process): Avoid vfork clobbering
6875 the local vars buffer, coding_systems, current_dir.
6877 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
6879 * keymap.c (Fmake_composed_keymap): Move to subr.el.
6881 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
6883 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
6884 so that it is not optimized away.
6886 * xdisp.c (compute_display_string_pos): Remove unused local.
6888 2011-08-02 Eli Zaretskii <eliz@gnu.org>
6890 Fix slow cursor motion and scrolling in large buffers with
6891 selective display, like Org Mode buffers. (Bug#9218)
6893 * dispextern.h (struct bidi_it): New member disp_prop_p.
6895 * xdisp.c: Remove one-slot cache of display string positions.
6896 (compute_display_string_pos): Accept an additional argument
6897 DISP_PROP_P; callers changed. Scan at most 5K characters forward
6898 for a display string or property. If found, set DISP_PROP_P
6901 * bidi.c (bidi_fetch_char): Accept an additional argument
6902 DISP_PROP_P, and pass it to compute_display_string_pos.
6903 Only handle text covered by a display string if DISP_PROP_P is returned
6904 non-zero. All callers of bidi_fetch_char changed.
6906 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
6908 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
6910 2010-12-03 Don March <don@ohspite.net>
6912 * keymap.c (Fdefine_key): Fix non-prefix key error message when
6913 last character M-[char] is translated to ESC [char] (bug#7541).
6915 2011-08-02 Kenichi Handa <handa@m17n.org>
6917 * lisp.h (uniprop_table): Extern it.
6919 * chartab.c (uniprop_table): Make it non-static.
6921 2011-08-01 Eli Zaretskii <eliz@gnu.org>
6923 * xdisp.c (forward_to_next_line_start): Accept additional argument
6924 BIDI_IT_PREV, and store into it the state of the bidi iterator had
6926 (reseat_at_next_visible_line_start): Use the bidi iterator state
6927 returned by forward_to_next_line_start to restore the state of
6928 it->bidi_it after backing up to previous newline. (Bug#9212)
6930 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
6932 * regex.c (re_comp): Protoize.
6933 (re_exec): Fix return type.
6934 (regexec): Fix type of `ret'. (Bug#9203)
6936 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6938 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
6939 This is needed if max-image-size is a floating-point number.
6941 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6943 * print.c (print_object): Print empty symbol as ##.
6945 * lread.c (read1): Read ## as empty symbol.
6947 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6949 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
6950 setting frame foreground color (Bug#9175).
6951 (x_set_background_color): Likewise.
6953 * nsmenu.m (-setText): Size tooltip dimensions precisely to
6954 contents (Bug#9176).
6955 (EmacsTooltip -init): Remove bezels and add shadows to
6958 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
6959 or scroll bar (Bug#8470).
6961 * nsfont.m (nsfont_open): Remove assignment to voffset and
6962 unnecessary vars hshink, expand, hd, full_height, min_height.
6963 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
6965 * nsterm.h (nsfont_info): Remove voffset field.
6967 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6969 Implement strike-through and overline on NextStep (Bug#8863).
6971 * nsfont.m (nsfont_open): Use underline position provided by font,
6972 instead of hard-coded value of 2.
6973 (nsfont_draw): Call ns_draw_text_decoration instead.
6975 * nsterm.h: Add declaration for ns_draw_text_decoration.
6977 * nsterm.m (ns_draw_text_decoration): New function for drawing
6978 underline, overline, and strike-through.
6979 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
6980 ns_draw_text_decoration. Change treatment of cursor drawing to
6981 accommodate underlining, etc.
6983 2011-07-28 Eli Zaretskii <eliz@gnu.org>
6985 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
6988 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6990 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
6991 Without this fix, if a signal arrives just after memory fills up,
6992 'malloc' might be invoked reentrantly.
6994 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
6995 In other words, assume that every image size is allowed, on non-X
6996 hosts. This assumption is probably wrong, but it lets Emacs compile.
6998 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7000 * regex.c (re_iswctype): Convert return values to boolean.
7002 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
7004 * xdisp.c (compute_display_string_pos): Don't use cached display
7005 string position if the buffer had its restriction changed.
7008 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7010 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7012 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7014 Integer signedness and overflow and related fixes. (Bug#9079)
7016 * bidi.c: Integer size and overflow fixes.
7017 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
7018 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
7019 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7020 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
7021 (bidi_find_other_level_edge):
7022 Use ptrdiff_t instead of EMACS_INT where either will do.
7023 This works better on 32-bit hosts configured --with-wide-int.
7024 (bidi_cache_ensure_space): Check for size-calculation overflow.
7025 Use % rather than repeated addition, for better worst-case speed.
7026 Don't set bidi_cache_size until after xrealloc returns, because it
7028 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
7029 (bidi_cache_ensure_space): Also check that the bidi cache size
7030 does not exceed that of the largest Lisp string or buffer. See Eli
7031 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
7033 * alloc.c (__malloc_size_t): Remove.
7034 All uses replaced by size_t. See Andreas Schwab's note
7035 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
7037 * image.c: Improve checking for integer overflow.
7038 (check_image_size): Assume that f is nonnull, since
7039 it is always nonnull in practice. This is one less thing to
7040 worry about when checking for integer overflow later.
7041 (x_check_image_size): New function, which checks for integer
7042 overflow issues inside X.
7043 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
7044 This removes the need for a memory_full check.
7045 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
7046 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
7047 (xbm_read_bitmap_data): Change locals back to 'int', since
7048 their values must fit in 'int'.
7049 (xpm_load_image, png_load, tiff_load):
7050 Invoke x_create_x_image_and_pixmap earlier,
7051 to avoid much needless work if the image is too large.
7052 (tiff_load): Treat overly large images as if
7053 x_create_x_image_and_pixmap failed, not as malloc failures.
7054 (gs_load): Use x_check_image_size.
7056 * gtkutil.c: Omit integer casts.
7057 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
7058 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
7060 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
7062 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
7063 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
7064 would wrongly return t on a 64-bit host.
7066 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
7067 The plain *_OVERFLOW macros run afoul of GCC bug 49705
7068 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
7069 and therefore cause GCC to emit a bogus diagnostic in some cases.
7071 * image.c: Integer signedness and overflow and related fixes.
7072 This is not an exhaustive set of fixes, but it's time to
7073 record what I've got.
7074 (lookup_pixel_color, check_image_size): Remove redundant decls.
7075 (check_image_size): Don't assume that arbitrary EMACS_INT values
7076 fit in 'int', or that arbitrary 'double' values fit in 'int'.
7077 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
7078 (tiff_load, imagemagick_load_image):
7079 Check for overflow in size calculations.
7080 (x_create_x_image_and_pixmap): Remove unnecessary test for
7081 xmalloc returning NULL; that can't happen.
7082 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
7083 (xpm_color_bucket): Use better integer hashing function.
7084 (xpm_cache_color): Don't possibly over-allocate memory.
7085 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
7086 (gif_memory_source):
7087 Use ptrdiff_t, not int or size_t, to record sizes.
7088 (png_load): Don't assume values greater than 2**31 fit in 'int'.
7089 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
7090 either works, as we prefer signed integers.
7091 (tiff_read_from_memory, tiff_write_from_memory):
7092 Return tsize_t, not size_t, since that's what the TIFF API wants.
7093 (tiff_read_from_memory): Don't fail simply because the read would
7094 go past EOF; instead, return a short read.
7095 (tiff_load): Omit no-longer-needed casts.
7096 (Fimagemagick_types): Don't assume size fits into 'int'.
7098 Improve hashing quality when configured --with-wide-int.
7099 * fns.c (hash_string): New function, taken from sxhash_string.
7100 Do not discard information about ASCII character case; this
7101 discarding is no longer needed.
7102 (sxhash-string): Use it. Change sig to match it. Caller changed.
7103 * lisp.h: Declare it.
7104 * lread.c (hash_string): Remove, since we now use fns.c's version.
7105 The fns.c version returns a wider integer if --with-wide-int is
7106 specified, so this should help the quality of the hashing a bit.
7108 * emacs.c: Integer overflow minor fix.
7109 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
7110 Define only if GNU_LINUX.
7111 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
7113 * dispnew.c: Integer signedness and overflow fixes.
7114 Remove unnecessary forward decls, that were a maintenance hassle.
7115 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
7117 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
7118 (scrolling_window): Use ptrdiff_t, not int, for byte count.
7119 (prepare_desired_row, line_draw_cost):
7120 Use int, not unsigned, where either works.
7121 (save_current_matrix, restore_current_matrix):
7122 Use ptrdiff_t, not size_t, where either works.
7123 (init_display): Check for overflow more accurately, and without
7124 relying on undefined behavior.
7126 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
7127 Remove, replacing with the new symbols in lisp.h. All uses changed.
7128 * fileio.c (make_temp_name):
7129 * filelock.c (lock_file_1, lock_file):
7130 * xdisp.c (message_dolog):
7131 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
7132 Use pMd etc. instead.
7133 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
7134 replacing the pWIDE etc. symbols removed from editfns.c.
7136 * keyboard.h (num_input_events): Now uintmax_t.
7137 This is (very slightly) less likely to mess up due to wraparound.
7140 * buffer.c: Integer signedness fixes.
7141 (alloc_buffer_text, enlarge_buffer_text):
7142 Use ptrdiff_t rather than size_t when either will do, as we prefer
7145 * alloc.c: Integer signedness and overflow fixes.
7146 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
7147 (__malloc_size_t): Default to size_t, not to int.
7148 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
7149 (Fgarbage_collect, mark_object_loop_halt, mark_object):
7150 Prefer ptrdiff_t to size_t when either would do, as we prefer
7152 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
7153 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
7154 Now const. Initialize with values that are in range even if char
7156 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
7157 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
7158 These functions do the right thing with sizes > 2**32.
7159 (check_depth): Now ptrdiff_t, not int.
7160 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
7161 Adjust to new way of storing sizes. Check for size overflow bugs
7163 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
7164 slightly wrong anyway, as it missed one instance of
7165 XMALLOC_OVERRUN_CHECK_OVERHEAD.
7166 (refill_memory_reserve): Omit needless cast to size_t.
7167 (mark_object_loop_halt): Mark as externally visible.
7169 * xselect.c: Integer signedness and overflow fixes.
7170 (Fx_register_dnd_atom, x_handle_dnd_message):
7171 Use ptrdiff_t, not size_t, since we prefer signed.
7172 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
7173 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
7174 x_dnd_atoms_size and x_dnd_atoms_length.
7176 * doprnt.c: Prefer signed to unsigned when either works.
7178 * doprnt.c (doprnt):
7180 * xdisp.c (vmessage):
7181 Use ptrdiff_t, not size_t, when using or implementing doprnt,
7182 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
7183 prefer signed arithmetic to avoid comparison confusion.
7184 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
7185 but is a bit tricky.
7187 Assume freestanding C89 headers, string.h, stdlib.h.
7188 * data.c, doprnt.c, floatfns.c, print.c:
7189 Include float.h unconditionally.
7190 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
7191 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
7192 * regex.c: Likewise for stddef.h, string.h.
7193 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
7194 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
7195 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
7196 (STDC_HEADERS): Remove obsolete defines.
7197 * sysdep.c: Include limits.h unconditionally.
7199 Assume support for memcmp, memcpy, memmove, memset.
7200 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
7201 * regex.c (memcmp, memcpy):
7202 Remove; we assume C89 now.
7204 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
7205 (__malloc_safe_bcopy): Remove; no longer needed.
7207 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
7208 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
7209 well either way, and we prefer signed to unsigned.
7211 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
7213 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
7214 closes the connection while we're reading (bug#9182).
7216 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
7218 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
7219 are specified (Bug#9168).
7221 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
7223 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
7224 Found by GCC static checking and --with-wide-int on a 32-bit host.
7226 2011-07-25 Eli Zaretskii <eliz@gnu.org>
7228 * xdisp.c (compute_display_string_pos): Fix logic of caching
7229 previous display string position. Initialize cached_prev_pos to
7230 -1. Fixes slow-down at the beginning of a buffer.
7232 2011-07-24 Eli Zaretskii <eliz@gnu.org>
7234 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
7235 for attrs[LFACE_FONTSET_INDEX].
7237 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
7239 * xml.c (parse_region): Remove unused local
7240 that was recently introduced.
7242 2011-07-23 Eli Zaretskii <eliz@gnu.org>
7244 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
7245 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
7247 * xdisp.c (move_it_in_display_line_to): Record the best matching
7248 position for TO_CHARPOS while scanning the line, and restore it on
7249 exit if none of the characters scanned was an exact match.
7250 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
7251 when exact match is impossible due to invisible text, and the
7252 lines are truncated.
7254 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
7256 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
7259 2011-07-22 Eli Zaretskii <eliz@gnu.org>
7261 Fix a significant slow-down of cursor motion with C-n, C-p,
7262 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
7263 auto-repeat under bidi redisplay in fontified buffers.
7264 * xdisp.c (compute_stop_pos_backwards): New function.
7265 (next_element_from_buffer): Call compute_stop_pos_backwards to
7266 find a suitable prev_stop when we find ourselves before
7268 (reseat): Don't look for prev_stop, as that could mean a very long
7270 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
7271 <cached_disp_overlay_modiff>: Cache for last found display string
7273 (compute_display_string_pos): Return the cached position if asked
7274 about the same buffer in the same area of character positions, and
7275 the buffer wasn't changed since the time the display string
7276 position was cached.
7278 2011-07-22 Eli Zaretskii <eliz@gnu.org>
7280 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
7281 is an integer, which is important for empty lines. (Bug#9149)
7283 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
7285 * frame.c (Fmodify_frame_parameters): In tty case, update the
7286 default face if necessary (Bug#4238).
7288 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
7290 * editfns.c (Fstring_to_char): No need to explain what a character
7291 is in the docstring (Bug#6576).
7293 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7295 * xml.c (parse_region): Make sure we always return a tree.
7297 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
7299 * xml.c (parse_region): If a document contains only comments,
7302 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7304 * xml.c (make_dom): Return comments, too.
7306 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
7309 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
7310 and the surrounding thread.
7311 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
7312 rather than fgets, and retry after EINTR. Otherwise, 'emacs
7313 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
7315 * s/openbsd.h (BROKEN_SIGIO): Define.
7316 * unexelf.c (unexec) [__OpenBSD__]:
7317 Don't update the .mdebug section of the Alpha COFF symbol table.
7319 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7321 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
7324 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
7326 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
7327 This fixes some race conditions on the permissions of any newly
7330 * alloc.c (valid_pointer_p): Use pipe, not open.
7331 This fixes some permissions issues when debugging.
7333 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
7334 If fchown fails to set both uid and gid, try to set just gid,
7335 as that is sometimes allowed. Adjust the file's mode to eliminate
7336 setuid or setgid bits that are inappropriate if fchown fails.
7338 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
7340 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
7341 to compare Lisp_Objects.
7342 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
7343 global_gnutls_log_level, don't mistake it for a Lisp_Object.
7344 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
7346 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
7348 * lread.c (read_integer): Unread even EOF character.
7349 (read1): Likewise. Properly record start position of symbol.
7351 * lread.c (read1): Read `#:' as empty uninterned symbol if no
7352 symbol character follows.
7354 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
7356 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
7357 This works around a problem with the previous change to Fcopy_file.
7358 Recent glibc declares fchown with __attribute__((warn_unused_result)),
7359 and without this change, GCC might complain about discarding
7360 fchown's return value.
7362 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
7364 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
7366 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
7368 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
7370 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
7372 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
7373 it's used from the C level.
7375 * process.c: Use the same condition for POLL_FOR_INPUT in both
7376 keyboard.c and process.c (bug#1858).
7378 2011-07-09 Lawrence Mitchell <wence@gmx.li>
7380 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
7381 (Fgnutls_boot): Use it.
7383 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
7385 * doc.c (Fsubstitute_command_keys): Revert last change.
7387 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
7389 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
7390 quotes the next character, and doesn't affect other longer
7391 sequences (bug#8935).
7393 * lread.c (syms_of_lread): Clarify that is isn't only
7394 `eval-buffer' and `eval-defun' that's affected by
7395 `lexical-binding' (bug#8460).
7397 2011-07-15 Eli Zaretskii <eliz@gnu.org>
7399 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
7400 bidi redisplay when a line includes both an image and is truncated.
7402 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
7404 Fix minor problems found by static checking.
7405 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
7406 (elsz): Now a signed constant, not a size_t var. We prefer signed
7407 types to unsigned, to avoid integer comparison confusion. Without
7408 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
7409 "cannot optimize loop, the loop counter may overflow", a symptom
7411 * indent.c (Fvertical_motion): Mark locals as initialized.
7412 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
7414 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7416 * search.c (Fre_search_backward): Mention `case-fold-search' in
7417 all the re_search_* functions (bug#8138).
7419 * keyboard.c (Fopen_dribble_file): Document when the file is
7422 2011-07-14 Eli Zaretskii <eliz@gnu.org>
7424 * bidi.c (bidi_dump_cached_states): Fix format of displaying
7427 Support bidi reordering of display and overlay strings.
7428 * xdisp.c (compute_display_string_pos)
7429 (compute_display_string_end): Accept additional argument STRING.
7430 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
7431 (reseat_to_string): Initialize bidi_it->string.s and
7432 bidi_it->string.schars.
7433 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
7434 NULL (avoids a crash in bidi_paragraph_init).
7435 Initialize itb.string.lstring.
7436 (init_iterator): Call bidi_init_it only of a valid
7437 buffer position was specified. Initialize paragraph_embedding to
7439 (reseat_to_string): Initialize the bidi iterator.
7440 (display_string): If we need to ignore text properties of
7441 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
7442 original value of -1 will not work with bidi.)
7443 (compute_display_string_pos): First arg is now struct
7444 `text_pos *'; all callers changed. Support display properties on
7446 (compute_display_string_end): Support display properties on Lisp
7448 (init_iterator, reseat_1, reseat_to_string): Initialize the
7449 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
7450 when iterating on a string not from display properties).
7451 (compute_display_string_pos, compute_display_string_end):
7452 Fix calculation of the object to scan. Fixes an error when using
7454 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
7455 base_level_stop; instead, set base_level_stop to BEGV.
7456 Fixes crashes in vertical-motion.
7457 (next_element_from_buffer): Improve commentary for when
7458 the iterator is before prev_stop.
7459 (init_iterator): Initialize bidi_p from the default value of
7460 bidi-display-reordering, not from buffer-local value. Use the
7461 buffer-local value only if initializing for buffer iteration.
7462 (handle_invisible_prop): Support invisible properties on strings
7463 that are being bidi-reordered.
7464 (set_iterator_to_next): Support bidi reordering of C strings and
7466 (next_element_from_string): Support bidi reordering of Lisp
7468 (handle_stop_backwards): Support Lisp strings as well.
7469 (display_string): Support display of R2L glyph rows.
7470 Use IT_STRING_CHARPOS when displaying from a Lisp string.
7471 (init_iterator): Don't initialize it->bidi_p for strings
7473 (reseat_to_string): Initialize it->bidi_p for strings here.
7474 (next_element_from_string, next_element_from_c_string)
7475 (next_element_from_buffer): Add xassert's for correspondence
7476 between IT's object being iterated and it->bidi_it.string
7478 (face_before_or_after_it_pos): Support bidi iteration.
7479 (next_element_from_c_string): Handle the case of the first string
7480 character that is not the first one in the visual order.
7481 (get_visually_first_element): New function, refactored from common
7482 parts of next_element_from_buffer, next_element_from_string, and
7483 next_element_from_c_string.
7484 (tool_bar_lines_needed, redisplay_tool_bar)
7485 (display_menu_bar): Force left-to-right direction. Add a FIXME
7486 comment for making that be controlled by a user option.
7487 (push_it, pop_it): Save and restore the state of the
7488 bidi iterator. Save and restore the bidi_p flag.
7489 (pop_it): Iterate out of display property for string iteration as
7491 (iterate_out_of_display_property): Support iteration over strings.
7492 (handle_single_display_spec): Set up it->bidi_it for iteration
7493 over a display string, and call bidi_init_it.
7494 (handle_single_display_spec, next_overlay_string)
7495 (get_overlay_strings_1, push_display_prop): Set up the bidi
7496 iterator for displaying display or overlay strings.
7497 (forward_to_next_line_start): Don't use the shortcut if
7499 (back_to_previous_visible_line_start): If handle_display_prop
7500 pushed the iterator stack, restore the internal state of the bidi
7501 iterator by calling bidi_pop_it same number of times.
7502 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
7503 and we are bidi-iterating, don't decrement the iterator position;
7504 instead, set the first_elt flag in the bidi iterator, to produce
7506 (reseat_1): Remove redundant setting of string_from_display_prop_p.
7507 (push_display_prop): xassert that we are iterating a buffer.
7508 (push_it, pop_it): Save and restore paragraph_embedding member.
7509 (handle_single_display_spec, next_overlay_string)
7510 (get_overlay_strings_1, reseat_1, reseat_to_string)
7511 (push_display_prop): Set up the `unibyte' member of bidi_it.string
7512 correctly. Don't assume unibyte strings are not bidi-reordered.
7513 (compute_display_string_pos)
7514 (compute_display_string_end): Fix handling the case of C string.
7515 (push_it, pop_it): Save and restore from_disp_prop_p.
7516 (handle_single_display_spec, push_display_prop): Set the
7517 from_disp_prop_p flag.
7518 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
7519 (pop_it): Call iterate_out_of_display_property only if we are
7520 popping after iteration over a string that came from a display
7521 property. Fix a typo in popping stretch info. Add an assertion
7522 for verifying that the iterator position is in sync with the bidi
7524 (handle_single_display_spec, get_overlay_strings_1)
7525 (push_display_prop): Fix initialization of paragraph direction for
7526 string when that of the parent object is not yet determined.
7527 (reseat_1): Call bidi_init_it to resync the bidi
7528 iterator with IT's position. (Bug#7616)
7529 (find_row_edges): If ROW->start.pos gives position
7530 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
7531 (handle_stop, back_to_previous_visible_line_start, reseat_1):
7532 Reset the from_disp_prop_p flag.
7533 (SAVE_IT, RESTORE_IT): New macros.
7534 (pos_visible_p, face_before_or_after_it_pos)
7535 (back_to_previous_visible_line_start)
7536 (move_it_in_display_line_to, move_it_in_display_line)
7537 (move_it_to, move_it_vertically_backward, move_it_by_lines)
7538 (try_scrolling, redisplay_window, display_line): Use them when
7539 saving a temporary copy of the iterator and restoring it back.
7540 (back_to_previous_visible_line_start, reseat_1)
7541 (init_iterator): Empty the bidi cache "stack".
7542 (move_it_in_display_line_to): If iterator ended up at
7543 EOL, but we never saw any buffer positions smaller than
7544 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
7545 motion in bidi-reordered lines.
7546 (move_it_in_display_line_to): Record prev_method and prev_pos
7547 immediately before the call to set_iterator_to_next. Fixes cursor
7548 motion in bidi-reordered lines with stretch glyphs and strings
7549 displayed in margins. (Bug#8133) (Bug#8867)
7550 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
7552 (pos_visible_p): Support positions in bidi-reordered lines.
7553 Save and restore bidi cache.
7555 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
7556 (bidi_paragraph_info): Delete unused struct.
7557 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
7558 (bidi_cache_start): New variable.
7559 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
7561 (bidi_cache_fetch_state, bidi_cache_search)
7562 (bidi_cache_find_level_change, bidi_cache_iterator_state)
7563 (bidi_cache_find, bidi_peek_at_next_level)
7564 (bidi_level_of_next_char, bidi_find_other_level_edge)
7565 (bidi_move_to_visually_next): Compare cache index with
7566 bidi_cache_start rather than with zero.
7567 (bidi_fetch_char): Accept new argument STRING; all callers
7568 changed. Support iteration over a string. Support strings with
7569 display properties. Support unibyte strings. Fix the type of
7570 `len' according to what STRING_CHAR_AND_LENGTH expects.
7571 (bidi_paragraph_init, bidi_resolve_explicit_1)
7572 (bidi_resolve_explicit, bidi_resolve_weak)
7573 (bidi_level_of_next_char, bidi_move_to_visually_next):
7574 Support iteration over a string.
7575 (bidi_set_sor_type, bidi_resolve_explicit_1)
7576 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
7577 can now be zero (for strings); special values 0 and -1 were
7578 changed to -1 and -2, respectively.
7579 (bidi_char_at_pos): New function.
7580 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
7581 Call it instead of FETCH_MULTIBYTE_CHAR.
7582 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
7583 initialized to valid values.
7584 (bidi_init_it): Don't initialize charpos and bytepos with invalid
7586 (bidi_level_of_next_char): Allow the sentinel "position" to pass
7587 the test for valid cached positions. Fix the logic for looking up
7588 the sentinel state in the cache. GCPRO the Lisp string we are
7590 (bidi_push_it, bidi_pop_it): New functions.
7591 (bidi_initialize): Initialize the bidi cache start stack pointer.
7592 (bidi_cache_ensure_space): New function, refactored from part of
7593 bidi_cache_iterator_state. Don't assume the required size is just
7594 one BIDI_CACHE_CHUNK away.
7595 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
7596 (bidi_count_bytes, bidi_char_at_pos): New functions.
7597 (bidi_cache_search): Don't assume bidi_cache_last_idx is
7598 always valid if bidi_cache_idx is valid.
7599 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
7600 is valid if it's going to be used.
7601 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
7602 (bidi_cache_fetch_state, bidi_cache_search)
7603 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7604 (bidi_cache_iterator_state, bidi_cache_find)
7605 (bidi_find_other_level_edge, bidi_cache_start_stack):
7606 All variables related to cache indices are now EMACS_INT.
7608 * dispextern.h (struct bidi_string_data): New structure.
7609 (struct bidi_it): New member `string'. Make flag members be 1-bit
7610 fields, and put them last in the struct.
7611 (compute_display_string_pos, compute_display_string_end):
7613 (bidi_push_it, bidi_pop_it): Add prototypes.
7614 (struct iterator_stack_entry): New members bidi_p,
7615 paragraph_embedding, and from_disp_prop_p.
7616 (struct it): Member bidi_p is now a bit field 1 bit wide.
7617 (bidi_shelve_cache, bidi_unshelve_cache):
7620 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
7621 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
7622 and vector-like objects.
7624 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
7625 cache around display iteration.
7627 * window.c (Fwindow_end, window_scroll_pixel_based)
7628 (displayed_window_lines, Frecenter): Save and restore the bidi
7629 cache around display iteration.
7631 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7633 * editfns.c (Fdelete_region): Clarify the use of the named
7634 parameters (bug#6788).
7636 2011-07-14 Martin Rudalics <rudalics@gmx.at>
7638 * indent.c (Fvertical_motion): Set and restore w->pointm when
7639 saving and restoring the window's buffer (Bug#9006).
7641 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
7643 * editfns.c (Fstring_to_char): Clarify just what is returned
7644 (bug#6576). Text by Eli Zaretskii.
7646 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
7648 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
7650 2011-07-13 Eli Zaretskii <eliz@gnu.org>
7652 * buffer.c (mmap_find): Fix a typo.
7654 2011-07-13 Johan Bockgård <bojohan@gnu.org>
7656 Fix execution of x selection hooks.
7657 * xselect.c (Qx_lost_selection_functions)
7658 (Qx_sent_selection_functions): New vars.
7659 (syms_of_xselect): DEFSYM them.
7660 (x_handle_selection_request): Pass Qx_sent_selection_functions
7661 rather than Vx_sent_selection_functions to Frun_hook_with_args.
7662 (x_handle_selection_clear,x_clear_frame_selections):
7663 Pass Qx_lost_selection_functions rather than
7664 Vx_lost_selection_functions to Frun_hook_with_args.
7666 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
7668 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
7669 The old code sometimes used this field without initializing it.
7671 * alloc.c (gc_sweep): Don't read past end of array.
7672 In theory, the old code could also have corrupted Emacs internals,
7673 though it'd be very unlikely.
7675 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
7677 * character.c (Fcharacterp): Don't advertise optional ignored
7678 argument. (Bug#4026)
7680 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
7682 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
7685 * window.c (Fset_window_start): Doc fix (bug#4199).
7686 (Fset_window_hscroll): Ditto.
7688 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
7690 Fix minor new problems caught by GCC 4.6.1.
7691 * term.c (init_tty): Remove unused local.
7692 * xsettings.c (store_monospaced_changed): Define this function only
7693 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
7696 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
7698 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
7700 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7702 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
7703 are the mini-buffer and the echo area (bug#3320).
7705 * term.c (init_tty): Remove support for supdup, c10 and perq
7706 terminals, which are no longer supported (bug#1482).
7708 2011-07-10 Johan Bockgård <bojohan@gnu.org>
7710 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
7712 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
7714 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
7715 for non-popups (Bug#3642).
7717 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
7719 * alloc.c (reset_malloc_hooks): Protoize.
7720 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
7721 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
7722 * cm.c (losecursor): Likewise.
7723 * data.c (fmod): Likewise.
7724 * dispnew.c (swap_glyphs_in_rows): Likewise.
7725 * emacs.c (memory_warning_signal): Likewise.
7726 * floatfns.c (float_error): Likewise.
7727 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
7728 (otf_open, font_otf_capability, generate_otf_features)
7729 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
7731 * image.c (pbm_read_file): Likewise.
7732 * indent.c (string_display_width): Likewise.
7733 * intervals.c (check_for_interval, search_for_interval)
7734 (inc_interval_count, count_intervals, root_interval)
7735 (adjust_intervals_for_insertion, make_new_interval): Likewise.
7736 * lread.c (defalias): Likewise.
7737 * ralloc.c (r_alloc_check): Likewise.
7738 * regex.c (set_image_of_range_1, set_image_of_range)
7739 (regex_grow_registers): Likewise.
7740 * sysdep.c (strerror): Likewise.
7741 * termcap.c (valid_filename_p, tprint, main): Likewise.
7742 * tparam.c (main): Likewise.
7743 * unexhp9k800.c (run_time_remap, save_data_space)
7744 (update_file_ptrs, read_header, write_header, calculate_checksum)
7745 (copy_file, copy_rest, display_header): Likewise.
7746 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
7748 * xdisp.c (check_it): Likewise.
7749 * xfaces.c (register_color, unregister_color, unregister_colors):
7751 * xfns.c (print_fontset_result): Likewise.
7752 * xrdb.c (member, fatal, main): Likewise.
7754 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
7756 Fix minor problems found by static checking (Bug#9031).
7757 * chartab.c (char_table_set_range, map_sub_char_table):
7758 Remove unused locals.
7759 (uniprop_table): Now static.
7760 * composite.c (_work_char): Remove unused static var.
7762 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
7764 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
7766 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
7768 * gtkutil.c (qttip_cb): Remove code without function.
7770 2011-07-09 Eli Zaretskii <eliz@gnu.org>
7772 * w32.c (pthread_sigmask): New stub.
7774 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
7776 Use pthread_sigmask, not sigprocmask (Bug#9010).
7777 sigprocmask is portable only for single-threaded applications, and
7778 Emacs can be multi-threaded when it uses GTK.
7779 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
7781 * callproc.c (Fcall_process):
7782 * process.c (create_process):
7783 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
7784 Use pthread_sigmask, not sigprocmask.
7786 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7788 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
7789 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
7792 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7794 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
7795 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
7796 (xg_hide_tooltip): Fix comment.
7798 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
7799 in registerServicesMenuSendTypes.
7800 (validRequestorForSendType): Don't check ns_return_types.
7802 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
7805 2011-07-08 Jason Rumney <jasonr@gnu.org>
7807 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
7808 SH_SHOW for hidden windows (Bug#5482).
7810 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
7811 frame struct members of non-existent frames (Bug#6284).
7813 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7815 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
7816 variable firstTime not needed on OSX >= 10.6.
7817 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
7818 >= 10.5. Use setKnobProportion, setDoubleValue.
7820 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
7821 (MAC_OS_X_VERSION_10_5): Define if not defined.
7822 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
7823 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
7824 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
7826 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
7827 cString and lossyCString on OSX >= 10.4.
7829 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
7830 sizeToFit on OSX >= 10.2.
7832 * nsimage.m (allocInitFromFile): Don't use deprecated method
7833 bestRepresentationForDevice on OSX >= 10.6.
7835 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
7838 * emacs.c: Declare unexec_init_emacs_zone.
7840 * nsgui.h: Fix compiler warning about gnulib redefining verify.
7842 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
7844 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
7845 on svcsMenu (Bug#8842).
7847 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
7849 (Fns_list_services): Just return Qnil on 10.6, code not working there.
7851 * nsterm.m (QUTF8_STRING): Declare.
7852 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
7853 (validRequestorForSendType): Return type is (id).
7854 Change indexOfObjectIdenticalTo to indexOfObject.
7855 Check if we have local selection before returning self (Bug#8842).
7856 (writeSelectionToPasteboard): Put local selection into paste board
7857 if we have a local selection (Bug#8842).
7858 (syms_of_nsterm): DEFSYM QUTF8_STRING.
7860 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
7861 (ns_get_local_selection): Declare.
7863 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
7865 * keymap.c (describe_map_tree): Don't insert a double newline at
7866 the end of the buffer (bug#1169) and return whether we inserted
7869 * callint.c (Fcall_interactively): Change "reading args" to
7870 "providing args" to try to clarify what it does (bug#1010).
7872 2011-07-07 Kenichi Handa <handa@m17n.org>
7874 * composite.c (composition_compute_stop_pos): Ignore a static
7875 composition starting before CHARPOS (Bug#8915).
7877 * xdisp.c (handle_composition_prop): Likewise.
7879 2011-07-07 Eli Zaretskii <eliz@gnu.org>
7881 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
7884 2011-07-07 Kenichi Handa <handa@m17n.org>
7886 * character.h (unicode_category_t): New enum type.
7888 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
7889 (Qchar_code_property_table): New variable.
7890 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
7891 (UNIPROP_COMPRESSED_FORM_P): New macros.
7892 (char_table_ascii): Uncompress the compressed values.
7893 (sub_char_table_ref): New arg is_uniprop. Callers changed.
7894 Uncompress the compressed values.
7895 (sub_char_table_ref_and_range): Likewise.
7896 (char_table_ref_and_range): Uncompress the compressed values.
7897 (sub_char_table_set): New arg is_uniprop. Callers changed.
7898 Uncompress the compressed values.
7899 (sub_char_table_set_range): Args changed. Callers changed.
7900 (char_table_set_range): Adjuted for the above change.
7901 (map_sub_char_table): Delete args default_val and parent. Add arg
7902 top. Give decoded values to a Lisp function.
7903 (map_char_table): Adjust for the above change. Give decoded
7904 values to a Lisp function. Gcpro more variables.
7905 (uniprop_table_uncompress)
7906 (uniprop_decode_value_run_length): New functions.
7907 (uniprop_decoder, uniprop_decoder_count): New variables.
7908 (uniprop_get_decoder, uniprop_encode_value_character)
7909 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
7911 (uniprop_encoder, uniprop_encoder_count): New variables.
7912 (uniprop_get_encoder, uniprop_table)
7913 (Funicode_property_table_internal, Fget_unicode_property_internal)
7914 (Fput_unicode_property_internal): New functions.
7915 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
7916 Sunicode_property_table_internal, Sget_unicode_property_internal,
7917 and Sput_unicode_property_internal. Defvar_lisp
7918 char-code-property-alist.
7920 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
7921 Vunicode_category_table.
7923 * font.c (font_range): Adjust for the change of
7924 Vunicode_category_table.
7926 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
7928 * m/iris4d.h: Remove file, move contents ...
7929 * s/irix6-5.h: ... here.
7931 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
7933 Remove unportable assumption about struct layout (Bug#8884).
7934 * alloc.c (mark_buffer):
7935 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
7936 (clone_per_buffer_values): Don't assume that
7937 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
7938 This isn't true in general, and it's particularly not true
7939 if Emacs is configured with --with-wide-int.
7940 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
7941 New macros, used in the buffer.c change.
7943 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
7945 * xsettings.c: Use both GConf and GSettings if both are available.
7946 (store_config_changed_event): Add comment.
7947 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
7948 (store_tool_bar_style_changed): New functions.
7949 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
7950 (struct xsettings): Move font inside HAVE_XFT.
7951 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
7952 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
7953 Move inside HAVE_XFT.
7954 (something_changed_gsettingsCB): Rename from something_changedCB.
7955 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
7957 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
7958 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
7959 (something_changed_gconfCB): Rename from something_changedCB.
7960 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
7961 (parse_settings): Move check for font inside HAVE_XFT.
7962 (read_settings, apply_xft_settings): Add comment.
7963 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
7964 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
7965 call store_font_name_changed.
7966 (xft_settings_event): Add comment.
7967 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
7968 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
7969 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
7970 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
7971 (xsettings_initialize): Call init_gsettings last.
7972 (xsettings_get_system_font, xsettings_get_system_normal_font):
7975 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
7977 Random fixes. E.g., (random) never returned negative values.
7978 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
7979 subseconds part to the entropy, as that's a bit more random.
7980 Prefer signed to unsigned, since the signedness doesn't matter and
7981 in general we prefer signed. When given a limit, use a
7982 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
7983 latter isn't right if USE_2_TAGS_FOR_INTS.
7984 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
7985 not 0..VALMASK. Don't discard "excess" bits that random () returns.
7987 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
7989 * textprop.c (text_property_stickiness):
7990 Obey Vtext_property_default_nonsticky.
7991 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
7992 * w32fns.c (syms_of_w32fns):
7993 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
7995 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7997 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
7998 This is more efficient than Ffile_directory_p and avoids a minor race.
8000 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
8002 * buffer.c (Foverlay_put): Say what the return value is
8005 * fileio.c (barf_or_query_if_file_exists): Check first if the file
8006 is a directory before asking whether to use the file name
8008 (barf_or_query_if_file_exists): Make the "File is a directory"
8009 error be more correct.
8011 * fns.c (Frequire): Remove the mention of the .gz files, since
8012 that's installation-specific, but keep the mention of
8013 `get-load-suffixes'.
8015 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8017 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
8018 Report string overflow if the output is too long.
8020 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
8022 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
8023 (syms_of_gnutls): Remove duplicate DEFSYM for
8024 Qgnutls_bootprop_verify_hostname_error, an error for
8025 Qgnutls_bootprop_verify_error (which is no longer used).
8027 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
8028 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
8029 Also (re)move comments that are misplaced or no longer relevant.
8031 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8033 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
8035 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
8037 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
8038 and background color parameters if they have been changed.
8040 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8042 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
8044 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
8046 * xsettings.c (SYSTEM_FONT): Define only when used.
8047 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
8049 * keymap.c (access_keymap_1): Now static.
8051 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
8053 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
8054 leave any prefix arg for the up event (Bug#1586).
8056 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
8058 * lread.c (syms_of_lread): Mention single symbols defined by
8059 `defvar' or `defconst' (bug#7154).
8061 * fns.c (Frequire): Mention .el.gz files (bug#7314).
8062 (Frequire): Mention get-load-suffixes.
8064 2011-07-02 Martin Rudalics <rudalics@gmx.at>
8066 * window.h (window): Remove clone_number slot.
8067 * window.c (Fwindow_clone_number, Fset_window_clone_number):
8069 (make_parent_window, make_window, saved_window)
8070 (Fset_window_configuration, save_window_save): Don't deal with
8072 * buffer.c (Qclone_number): Remove declaration.
8073 (sort_overlays, overlay_strings): Don't deal with clone numbers.
8075 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
8077 Add multiple inheritance to keymaps.
8078 * keymap.c (Fmake_composed_keymap): New function.
8079 (Fset_keymap_parent): Simplify.
8080 (fix_submap_inheritance): Remove.
8081 (access_keymap_1): New function extracted from access_keymap to handle
8082 embedded parents and handle lists of maps.
8083 (access_keymap): Use it.
8084 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
8085 (Fcopy_keymap): Handle embedded parents.
8086 (Fcommand_remapping, define_as_prefix): Simplify.
8087 (Fkey_binding): Simplify.
8088 (syms_of_keymap): Move minibuffer-local-completion-map,
8089 minibuffer-local-filename-completion-map,
8090 minibuffer-local-must-match-map, and
8091 minibuffer-local-filename-must-match-map to Elisp.
8092 (syms_of_keymap): Defsubr make-composed-keymap.
8093 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
8094 (parse_menu_item): Trivial simplification.
8096 2011-07-01 Glenn Morris <rgm@gnu.org>
8098 * Makefile.in (SETTINGS_LIBS): Fix typo.
8100 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
8102 * coding.c (Fencode_coding_string): Record the last coding system
8103 used, as the function doc string says (bug#8738).
8105 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
8107 * xsettings.c (store_monospaced_changed): Take new font as arg and
8108 check for change against current_mono_font.
8109 (EMACS_TYPE_SETTINGS): Remove this and related defines.
8110 (emacs_settings_constructor, emacs_settings_get_property)
8111 (emacs_settings_set_property, emacs_settings_class_init)
8112 (emacs_settings_init, gsettings_obj): Remove.
8113 (something_changedCB): New function for HAVE_GSETTINGS.
8114 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
8115 with value as argument.
8116 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
8117 g_settings_new (Bug#8967). Do not create gsettings_obj.
8118 Remove calls to g_settings_bind. Connect something_changedCB to
8121 * xgselect.c: Add defined (HAVE_GSETTINGS).
8122 (xgselect_initialize): Ditto.
8124 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
8125 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
8128 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
8130 * eval.c (struct backtrace): Simplify and port the data structure.
8131 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
8132 signed bit field, as this assumption is not portable and it makes
8133 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
8134 "char debug_on_exit : 1" as this is not portable either; instead,
8135 use the portable "unsigned int debug_on_exit : 1". Remove unused
8136 member evalargs. Remove obsolete comments about cc bombing out.
8138 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
8140 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
8141 Let HAVE_GSETTINGS override HAVE_GCONF.
8142 (store_monospaced_changed): New function.
8143 (EMACS_SETTINGS): A new type derived from GObject to handle
8144 GSettings notifications.
8145 (emacs_settings_constructor, emacs_settings_get_property)
8146 (emacs_settings_set_property, emacs_settings_class_init):
8148 (gsettings_client, gsettings_obj): New variables.
8149 (GSETTINGS_SCHEMA): New define.
8150 (something_changedCB): Call store_monospaced_changed.
8151 (init_gsettings): New function.
8152 (xsettings_initialize): Call init_gsettings.
8153 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
8156 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
8159 2011-06-29 Martin Rudalics <rudalics@gmx.at>
8161 * window.c (resize_root_window, grow_mini_window)
8162 (shrink_mini_window): Rename Qresize_root_window to
8163 Qwindow_resize_root_window and Qresize_root_window_vertically to
8164 Qwindow_resize_root_window_vertically.
8166 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
8168 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
8170 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
8172 * makefile.w32-in: Redesign dependencies so they reflect more
8173 clearly which files are directly included by each source file,
8174 and not through other includes.
8176 2011-06-27 Martin Rudalics <rudalics@gmx.at>
8178 * buffer.c (Qclone_number): Declare static and DEFSYM it.
8179 (sort_overlays, overlay_strings): When an overlay's clone number
8180 matches the window's clone number process the overlay even if
8181 the overlay's window property doesn't match the current window.
8183 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
8184 (Fwindow_hchild): Rename to Fwindow_left_child.
8185 (Fwindow_next): Rename to Fwindow_next_sibling.
8186 (Fwindow_prev): Rename to Fwindow_prev_sibling.
8187 (resize_window_check): Rename to window_resize_check.
8188 (resize_window_apply): Rename to window_resize_apply.
8189 (Fresize_window_apply): Rename to Fwindow_resize_apply.
8190 (Fdelete_other_windows_internal, resize_frame_windows)
8191 (Fsplit_window_internal, Fdelete_window_internal)
8192 (grow_mini_window, shrink_mini_window)
8193 (Fresize_mini_window_internal): Fix callers accordingly.
8195 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
8197 * emacsgtkfixed.h: State that this is only used with Gtk+3.
8198 (emacs_fixed_set_min_size): Remove.
8199 (emacs_fixed_new): Take frame as argument.
8201 * emacsgtkfixed.c: State that this is only used with Gtk+3.
8202 (_EmacsFixedPrivate): Remove minwidth/height.
8203 Add struct frame *f.
8204 (emacs_fixed_init): Initialize priv->f.
8205 (get_parent_class, emacs_fixed_set_min_size): Remove.
8206 (emacs_fixed_new): Set priv->f to argument.
8207 (emacs_fixed_get_preferred_width)
8208 (emacs_fixed_get_preferred_height): Use min_width/height from
8209 frames size_hint to set minimum and natural (Bug#8919).
8210 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
8211 and use min_width/height from frames size_hint to set
8212 min_width/height (Bug#8919).
8214 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
8215 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
8218 2011-06-26 Eli Zaretskii <eliz@gnu.org>
8220 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
8221 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
8224 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
8226 * process.c (wait_reading_process_output): Bypass select if
8227 waiting for a cell while ignoring keyboard input, and input is
8228 pending. Suggested by Jan Djärv (Bug#8869).
8230 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
8232 Use gnulib's dup2 module instead of rolling our own.
8233 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
8235 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8237 * dispnew.c (scrolling_window): Before scrolling, turn off a
8238 mouse-highlight in the window being scrolled.
8240 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
8242 Move DEFSYM to lisp.h and use everywhere.
8244 * character.h (DEFSYM): Move declaration...
8245 * lisp.h (DEFSYM): ...here.
8251 * w32select.c: Don't include character.h.
8253 * alloc.c (syms_of_alloc):
8254 * buffer.c (syms_of_buffer):
8255 * bytecode.c (syms_of_bytecode):
8256 * callint.c (syms_of_callint):
8257 * casefiddle.c (syms_of_casefiddle):
8258 * casetab.c (init_casetab_once):
8259 * category.c (init_category_once, syms_of_category):
8260 * ccl.c (syms_of_ccl):
8261 * cmds.c (syms_of_cmds):
8262 * composite.c (syms_of_composite):
8263 * dbusbind.c (syms_of_dbusbind):
8264 * dired.c (syms_of_dired):
8265 * dispnew.c (syms_of_display):
8266 * doc.c (syms_of_doc):
8267 * editfns.c (syms_of_editfns):
8268 * emacs.c (syms_of_emacs):
8269 * eval.c (syms_of_eval):
8270 * fileio.c (syms_of_fileio):
8271 * fns.c (syms_of_fns):
8272 * frame.c (syms_of_frame):
8273 * fringe.c (syms_of_fringe):
8274 * insdel.c (syms_of_insdel):
8275 * keymap.c (syms_of_keymap):
8276 * lread.c (init_obarray, syms_of_lread):
8277 * macros.c (syms_of_macros):
8278 * msdos.c (syms_of_msdos):
8279 * print.c (syms_of_print):
8280 * process.c (syms_of_process):
8281 * search.c (syms_of_search):
8282 * sound.c (syms_of_sound):
8283 * syntax.c (init_syntax_once, syms_of_syntax):
8284 * terminal.c (syms_of_terminal):
8285 * textprop.c (syms_of_textprop):
8286 * undo.c (syms_of_undo):
8287 * w32.c (globals_of_w32):
8288 * window.c (syms_of_window):
8289 * xdisp.c (syms_of_xdisp):
8290 * xfaces.c (syms_of_xfaces):
8291 * xfns.c (syms_of_xfns):
8292 * xmenu.c (syms_of_xmenu):
8293 * xsettings.c (syms_of_xsettings):
8294 * xterm.c (syms_of_xterm): Use DEFSYM.
8296 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
8298 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
8300 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
8302 Integer and buffer overflow fixes (Bug#8873).
8304 * print.c (printchar, strout): Check for string overflow.
8305 (PRINTPREPARE, printchar, strout):
8306 Don't set size unless allocation succeeds.
8308 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
8309 for sizes. Check for string overflow more accurately.
8310 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
8312 * macros.c: Integer and buffer overflow fixes.
8313 * keyboard.h (struct keyboard.kbd_macro_bufsize):
8314 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
8315 Use ptrdiff_t, not int, for sizes.
8316 Don't increment bufsize until after realloc succeeds.
8317 Check for size-calculation overflow.
8318 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
8320 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
8322 * lread.c: Integer overflow fixes.
8323 (read_integer): Radix is now EMACS_INT, not int,
8324 to improve quality of diagnostics for out-of-range radices.
8325 Calculate buffer size correctly for out-of-range radices.
8326 (read1): Check for integer overflow in radices, and in
8327 read-circle numbers.
8328 (read_escape): Avoid int overflow.
8329 (Fload, openp, read_buffer_size, read1)
8330 (substitute_object_recurse, read_vector, read_list, map_obarray):
8331 Use ptrdiff_t, not int, for sizes.
8332 (read1): Use EMACS_INT, not int, for sizes.
8333 Check for size overflow.
8335 * image.c (cache_image): Check for size arithmetic overflow.
8337 * lread.c: Integer overflow issues.
8338 (saved_doc_string_size, saved_doc_string_length)
8339 (prev_saved_doc_string_size, prev_saved_doc_string_length):
8340 Now ptrdiff_t, not int.
8341 (read1): Don't assume doc string length fits in int. Check for
8342 out-of-range doc string lengths.
8343 (read_list): Don't assume file position fits in int.
8344 (read_escape): Check for hex character overflow.
8346 2011-06-22 Leo Liu <sdl.web@gmail.com>
8348 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
8349 Move to minibuffer.el.
8351 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8353 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
8354 The following patches are for when GLYPH_DEBUG && !XASSERT.
8355 * dispextern.h (trace_redisplay_p, dump_glyph_string):
8356 * dispnew.c (flush_stdout):
8357 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
8358 Mark as externally visible.
8359 * dispnew.c (check_window_matrix_pointers): Now static.
8360 * dispnew.c (window_to_frame_vpos):
8361 * xfns.c (unwind_create_frame):
8362 * xterm.c (x_check_font): Remove unused local.
8363 * scroll.c (CHECK_BOUNDS):
8364 * xfaces.c (cache_fache): Rename local to avoid shadowing.
8365 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
8366 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
8367 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
8368 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
8370 (debug_method_add): Use va_list and vsprintf rather than relying
8371 on undefined behavior with wrong number of arguments.
8372 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
8373 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
8374 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
8375 since we're not interested in debugging glyphs with old libraries.
8376 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
8377 GCC 4.6.0's static checking.
8379 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8381 Integer overflow and signedness fixes (Bug#8873).
8382 A few related buffer overrun fixes, too.
8384 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
8386 * dispextern.h (struct face.stipple):
8387 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
8388 (x_bitmap_mask, x_allocate_bitmap_record)
8389 (x_create_bitmap_from_data, x_create_bitmap_from_file)
8390 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
8391 (x_create_bitmap_from_xpm_data):
8392 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
8393 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
8395 * xfaces.c (load_pixmap):
8396 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
8397 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
8398 (.bitmaps_last, struct x_output.icon_bitmap):
8399 Use ptrdiff_t, not int, for bitmap indexes.
8400 (x_allocate_bitmap_record): Check for size overflow.
8401 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
8403 Use ptrdiff_t, not int, for overlay counts.
8404 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
8405 * editfns.c (overlays_around, get_pos_property):
8406 * textprop.c (get_char_property_and_overlay):
8407 * xdisp.c (next_overlay_change, note_mouse_highlight):
8408 * xfaces.c (face_at_buffer_position):
8409 * buffer.c (OVERLAY_COUNT_MAX): New macro.
8410 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
8411 (Fnext_overlay_change, Fprevious_overlay_change)
8412 (mouse_face_overlay_overlaps, Foverlays_in):
8413 Use ptrdiff_t, not int, for sizes.
8414 (overlays_at, overlays_in): Check for size-calculation overflow.
8416 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
8418 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
8419 (x_session_initialize): Do not assume string length fits in int.
8421 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
8422 This is unlikely, but can occur if DPI is outlandish.
8424 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
8425 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
8427 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
8428 * xrdb.c (magic_file_p, search_magic_path):
8429 Omit last arg SUFFIX; it was always 0. All callers changed.
8430 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
8432 * xfont.c (xfont_match): Avoid need for strlen.
8434 * xfns.c: Don't assume strlen fits in int.
8435 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
8437 * xdisp.c (message_log_check_duplicate): Return intmax_t,
8438 not unsigned long, as we prefer signed integers. All callers changed.
8439 Detect integer overflow in repeat count.
8440 (message_dolog): Don't assume print length fits in 39 bytes.
8441 (display_mode_element): Don't assume strlen fits in int.
8443 * termcap.c: Don't assume sizes fit in int and never overflow.
8444 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
8445 (gobble_line): Check for size-calculation overflow.
8447 * minibuf.c (Fread_buffer):
8448 * lread.c (intern, intern_c_string):
8449 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
8450 Don't assume string length fits in int.
8452 * keyboard.c (parse_tool_bar_item):
8453 * gtkutil.c (style_changed_cb): Avoid need for strlen.
8455 * font.c: Don't assume string length fits in int.
8456 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
8457 Use ptrdiff_t, not int.
8458 (font_intern_prop): Don't assume string length fits in int.
8459 Don't assume integer property fits in fixnum.
8460 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
8462 * filelock.c: Fix some buffer overrun and integer overflow issues.
8463 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
8464 Reformulate so as not to need the command string.
8465 Invoke gzip -cd rather than gunzip, as it's more portable.
8466 (lock_info_type, lock_file_1, lock_file):
8467 Don't assume pid_t and time_t fit in unsigned long.
8468 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
8469 (current_lock_owner): Prefer signed type for sizes.
8470 Use memcpy, not strncpy, where memcpy is what is really wanted.
8471 Don't assume (via atoi) that time_t and pid_t fit in int.
8472 Check for time_t and/or pid_t out of range, e.g., via a network share.
8473 Don't alloca where an auto var works fine.
8475 * fileio.c: Fix some integer overflow issues.
8476 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
8477 Don't assume string length fits in int.
8478 (directory_file_name): Don't assume string length fits in long.
8479 (make_temp_name): Don't assume pid fits in int, or that its print
8480 length is less than 20.
8482 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
8484 * coding.c (make_subsidiaries): Don't assume string length fits in int.
8486 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
8488 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
8489 We prefer signed integers, even for size calculations.
8491 * emacs.c: Don't assume string length fits in 'int'.
8492 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
8493 (main): Don't invoke strlen when not needed.
8495 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
8496 (XD_DEBUG_MESSAGE): Don't waste a byte.
8498 * callproc.c (getenv_internal_1, getenv_internal)
8500 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
8502 * lread.c (invalid_syntax): Omit length argument.
8503 All uses changed. This doesn't fix a bug, but it simplifies the
8504 code away from its former Hollerith-constant appearance, and it's
8505 one less 'int' to worry about when looking at integer-overflow issues.
8506 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
8508 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
8509 This didn't break anything, but it didn't help either.
8510 It's confusing to put a bogus integer in a place where the actual
8511 value does not matter.
8512 (LIST_END_P): Remove unused macro and its bogus comment.
8513 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
8515 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
8516 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
8518 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
8519 We prefer signed types, and the value cannot exceed the EMACS_INT
8520 range anyway (because otherwise the length would not be representable).
8521 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
8522 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
8523 This avoids a GCC warning when WIDE_EMACS_INT.
8525 * indent.c (sane_tab_width): New function.
8526 (current_column, scan_for_column, Findent_to, position_indentation)
8527 (compute_motion): Use it. This is just for clarity.
8528 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
8530 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
8532 * lisp.h (lint_assume): New macro.
8533 * composite.c (composition_gstring_put_cache):
8534 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
8536 * editfns.c, insdel.c:
8537 Omit unnecessary forward decls, to simplify future changes.
8539 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
8541 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
8543 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
8544 Use much-faster test for byte-length change.
8545 Don't assume string byte-length fits in 'int'.
8546 Check that character arg fits in 'int'.
8547 (mapcar1): Declare byte as byte, for clarity.
8549 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
8551 * fns.c (concat): Catch string overflow earlier.
8552 Do not rely on integer wraparound.
8554 * dispextern.h (struct it.overlay_strings_charpos)
8555 (struct it.selective): Now EMACS_INT, not int.
8556 * xdisp.c (forward_to_next_line_start)
8557 (back_to_previous_visible_line_start)
8558 (reseat_at_next_visible_line_start, next_element_from_buffer):
8559 Don't arbitrarily truncate the value of 'selective' to int.
8561 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
8563 * composite.c: Don't truncate sizes to 'int'.
8564 (composition_gstring_p, composition_reseat_it)
8565 (composition_adjust_point): Use EMACS_INT, not int.
8566 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
8567 not EMACS_UINT, for indexes.
8569 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
8571 * buffer.c: Include <verify.h>.
8572 (struct sortvec.priority, struct sortstr.priority):
8573 Now EMACS_INT, not int.
8574 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
8575 (struct sortstr.size, record_overlay_string)
8576 (struct sortstrlist.size, struct sortlist.used):
8577 Don't truncate size to int.
8578 (record_overlay_string): Check for size-calculation overflow.
8579 (init_buffer_once): Check at compile-time, not run-time.
8581 2011-06-22 Jim Meyering <meyering@redhat.com>
8583 Don't leak an XBM-image-sized buffer
8584 * image.c (xbm_load): Free the image buffer after using it.
8586 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
8589 * composite.c (find_automatic_composition): Omit needless 'return 0;'
8590 that Sun C diagnosed.
8591 * fns.c (secure_hash): Fix pointer signedness issue.
8592 * intervals.c (static_offset_intervals): New function.
8593 (offset_intervals): Use it.
8595 2011-06-21 Leo Liu <sdl.web@gmail.com>
8598 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
8601 * fns.c (secure_hash): Rename from crypto_hash_function and change
8602 the first arg to accept symbols.
8603 (Fsecure_hash): New primitive.
8604 (syms_of_fns): New symbols.
8606 2011-06-20 Deniz Dogan <deniz@dogan.se>
8608 * process.c (Fset_process_buffer): Clarify return value in
8611 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
8613 * dispnew.c (add_window_display_history): Use BVAR.
8615 * xdisp.c (debug_method_add): Use BVAR.
8616 (check_window_end, dump_glyph_matrix, dump_glyph)
8617 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
8619 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
8622 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
8623 check till after the cache is created in init_frame_faces.
8625 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
8627 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
8629 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
8631 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
8632 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
8633 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
8635 Improve buffer-overflow checking (Bug#8873).
8636 * fileio.c (Finsert_file_contents):
8637 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
8638 Remove the old (too-loose) buffer overflow checks.
8639 They weren't needed, since make_gap checks for buffer overflow.
8640 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
8641 The old code merely checked for Emacs fixnum overflow, and relied
8642 on undefined (wraparound) behavior. The new code avoids undefined
8643 behavior, and also checks for ptrdiff_t and/or size_t overflow.
8645 * editfns.c (Finsert_char): Don't dump core with very negative counts.
8646 Tune. Don't use wider integers than needed. Don't use alloca.
8647 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
8649 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
8651 * insdel.c, lisp.h (buffer_overflow): New function.
8652 (insert_from_buffer_1, replace_range, replace_range_2):
8653 * insdel.c (make_gap_larger):
8654 * editfns.c (Finsert_char):
8655 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
8657 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
8659 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
8661 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
8663 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
8664 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
8666 * fileio.c: Don't assume EMACS_INT fits in off_t.
8667 (emacs_lseek): New static function.
8668 (Finsert_file_contents, Fwrite_region): Use it.
8669 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
8671 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
8673 * fns.c: Don't overflow int when computing a list length.
8674 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
8675 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
8676 truncation on 64-bit hosts. Check for QUIT every
8677 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
8678 faster and is responsive enough.
8679 (Flength): Report an error instead of overflowing an integer.
8680 (Fsafe_length): Return a float if the value is not representable
8681 as a fixnum. This shouldn't happen except in contrived situations.
8682 (Fnthcdr, Fsort): Don't assume list length fits in int.
8683 (Fcopy_sequence): Don't assume vector length fits in int.
8685 * alloc.c: Check that resized vectors' lengths fit in fixnums.
8686 (header_size, word_size): New constants.
8687 (allocate_vectorlike): Don't check size overflow here.
8688 (allocate_vector): Check it here instead, since this is the only
8689 caller of allocate_vectorlike that could cause overflow.
8690 Check that the new vector's length is representable as a fixnum.
8692 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
8693 The previous code was bogus. For example, next_almost_prime (32)
8694 returned 39, which is undesirable as it is a multiple of 3; and
8695 next_almost_prime (24) returned 25, which is a multiple of 5 so
8696 why was the code bothering to check for multiples of 7?
8698 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
8700 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
8702 Variadic C functions now count arguments with ptrdiff_t.
8703 This partly undoes my 2011-03-30 change, which replaced int with size_t.
8704 Back then I didn't know that the Emacs coding style prefers signed int.
8705 Also, in the meantime I found a few more instances where arguments
8706 were being counted with int, which may truncate counts on 64-bit
8707 machines, or EMACS_INT, which may be unnecessarily wide.
8708 * lisp.h (struct Lisp_Subr.function.aMANY)
8709 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
8710 Arg counts are now ptrdiff_t, not size_t.
8711 All variadic functions and their callers changed accordingly.
8712 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
8713 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
8714 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
8715 * callint.c (Fcall_interactively): Check arg count for overflow,
8716 to avoid potential buffer overrun. Use signed char, not 'int',
8717 for 'varies' array, so that we needn't bother to check its size
8718 calculation for overflow.
8719 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
8720 * eval.c (apply_lambda):
8721 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
8722 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
8723 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
8725 * callint.c (Fcall_interactively): Don't use index var as event count.
8727 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
8728 * mem-limits.h (SIZE): Remove; no longer used.
8730 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
8732 Remove unnecessary casts.
8733 * xterm.c (x_term_init):
8734 * xfns.c (x_set_border_pixel):
8735 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
8736 These aren't needed now that we assume ANSI C.
8738 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
8739 It's more likely to cause problems (due to unsigned overflow)
8742 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
8744 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
8746 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
8748 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
8750 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
8752 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
8754 GLYPH_CODE_FACE returns EMACS_INT, not int.
8755 * dispextern.h (merge_faces):
8756 * xfaces.c (merge_faces):
8757 * xdisp.c (get_next_display_element, next_element_from_display_vector):
8758 Don't assume EMACS_INT fits in int.
8760 * character.h (CHAR_VALID_P): Remove unused parameter.
8761 * fontset.c, lisp.h, xdisp.c: All uses changed.
8763 * editfns.c (Ftranslate_region_internal): Omit redundant test.
8765 * fns.c (concat): Minor tuning based on overflow analysis.
8766 This doesn't fix any bugs. Use int to hold character, instead
8767 of constantly refetching from Emacs object. Use XFASTINT, not
8768 XINT, for value known to be a character. Don't bother comparing
8769 a single byte to 0400, as it's always less.
8771 * floatfns.c (Fexpt):
8772 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
8774 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
8777 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
8779 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
8780 Without this fix, on a 64-bit host (aset S 0 4294967386) would
8781 incorrectly succeed when S was a string, because 4294967386 was
8782 truncated before it was used.
8784 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
8785 Otherwise, an out-of-range integer could cause undefined behavior
8788 * composite.c: Use int, not EMACS_INT, for characters.
8789 (fill_gstring_body, composition_compute_stop_pos): Use int, not
8790 EMACS_INT, for values that are known to be in character range.
8791 This doesn't fix any bugs but is the usual style inside Emacs and
8792 may generate better code on 32-bit machines.
8794 Make sure a 64-bit char is never passed to ENCODE_CHAR.
8795 This is for reasons similar to the recent CHAR_STRING fix.
8796 * charset.c (Fencode_char): Check that character arg is actually
8797 a character. Pass an int to ENCODE_CHAR.
8798 * charset.h (ENCODE_CHAR): Verify that the character argument is no
8799 wider than 'int', as a compile-time check to prevent future regressions
8802 * character.c (char_string): Remove unnecessary casts.
8804 Make sure a 64-bit char is never passed to CHAR_STRING.
8805 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
8806 by silently ignoring the top 32 bits, allowing some values
8807 that were far too large to be valid characters.
8808 * character.h: Include <verify.h>.
8809 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
8810 arguments are no wider than unsigned, as a compile-time check
8811 to prevent future regressions in this area.
8813 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
8814 (Fsubst_char_in_region):
8816 * xdisp.c (decode_mode_spec_coding):
8817 Adjust to CHAR_STRING's new requirement.
8818 * editfns.c (Finsert_char, Fsubst_char_in_region):
8819 * fns.c (concat): Check that character args are actually
8820 characters. Without this test, these functions did the wrong
8821 thing with wildly out-of-range values on 64-bit hosts.
8823 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
8824 These casts should not be needed on 32-bit hosts, either.
8825 * keyboard.c (read_char):
8826 * lread.c (Fload): Remove casts to unsigned.
8828 * lisp.h (UNSIGNED_CMP): New macro.
8829 This fixes comparison bugs on 64-bit hosts.
8830 (ASCII_CHAR_P): Use it.
8831 * casefiddle.c (casify_object):
8832 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
8833 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
8834 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
8835 * dispextern.h (FACE_FROM_ID):
8836 * keyboard.c (read_char): Use UNSIGNED_CMP.
8838 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
8839 not to EMACS_INT, to avoid GCC warning.
8841 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
8843 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
8844 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
8845 isn't needed on 32-bit machines.
8847 * buffer.c (Fgenerate_new_buffer_name):
8848 Use EMACS_INT for count, not int.
8849 (advance_to_char_boundary): Return EMACS_INT, not int.
8851 * data.c (Qcompiled_function): Now static.
8853 * window.c (window_body_lines): Now static.
8855 * image.c (gif_load): Rename local to avoid shadowing.
8857 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
8858 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
8859 * alloc.c (make_save_value): Integer argument is now of type
8861 (mark_object): Use ptrdiff_t, not int.
8862 * lisp.h (pD): New macro.
8863 * print.c (print_object): Use it.
8865 * alloc.c: Use EMACS_INT, not int, to count objects.
8866 (total_conses, total_markers, total_symbols, total_vector_size)
8867 (total_free_conses, total_free_markers, total_free_symbols)
8868 (total_free_floats, total_floats, total_free_intervals)
8869 (total_intervals, total_strings, total_free_strings):
8870 Now EMACS_INT, not int. All uses changed.
8871 (Fgarbage_collect): Compute overall total using a double, so that
8872 integer overflow is less likely to be a problem. Check for overflow
8873 when converting back to an integer.
8874 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
8875 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
8876 These were 'int' variables that could overflow on 64-bit hosts;
8877 they were never used, so remove them instead of repairing them.
8878 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
8879 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
8880 Previously, this ceilinged at INT_MAX, but that doesn't work on
8882 (allocate_pseudovector): Don't use EMACS_INT when int would do.
8884 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
8885 (allocate_vectorlike): Check for ptrdiff_t overflow.
8886 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
8887 when a (possibly-narrower) signed value would do just as well.
8888 We prefer using signed arithmetic, to avoid comparison confusion.
8890 * alloc.c: Catch some string size overflows that we were missing.
8891 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
8892 for convenience in STRING_BYTES_MAX.
8893 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
8894 The definition here is exact; the one in lisp.h was approximate.
8895 (allocate_string_data): Check for string overflow. This catches
8896 some instances we weren't catching before. Also, it catches
8897 size_t overflow on (unusual) hosts where SIZE_MAX <= min
8898 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
8899 and ptrdiff_t and EMACS_INT are both 64 bits.
8901 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
8902 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
8903 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
8905 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
8907 * alloc.c (Fmake_string): Check for out-of-range init.
8909 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
8911 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
8913 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
8915 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
8916 xg_get_default_scrollbar_width.
8918 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
8919 (int_gtk_range_get_value): Move to the scroll bar part of the file.
8920 (style_changed_cb): Call update_theme_scrollbar_width and call
8921 x_set_scroll_bar_default_width and xg_frame_set_char_size for
8922 all frames (Bug#8505).
8923 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
8924 Call gtk_window_set_resizable if HAVE_GTK3.
8925 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
8926 and height if HAVE_GTK3 (Bug#8505).
8927 (scroll_bar_width_for_theme): New variable.
8928 (update_theme_scrollbar_width): New function.
8929 (xg_get_default_scrollbar_width): Move code to
8930 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
8931 (xg_initialize): Call update_theme_scrollbar_width.
8933 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
8935 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
8937 2011-06-12 Martin Rudalics <rudalics@gmx.at>
8939 * frame.c (make_frame): Call other_buffer_safely instead of
8942 * window.c (temp_output_buffer_show): Call display_buffer with
8943 second argument Vtemp_buffer_show_specifiers and reset latter
8944 immediately after the call.
8945 (Vtemp_buffer_show_specifiers): New variable.
8946 (auto_window_vscroll_p, next_screen_context_lines)
8947 (Vscroll_preserve_screen_position): Remove leading asterisks from
8950 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
8952 Fix minor problems found by GCC 4.6.0 static checking.
8953 * buffer.c (Qclone_number): Remove for now, as it's unused.
8954 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
8955 (record_buffer): Remove unused local.
8956 * frame.c (other_visible_frames, frame_buffer_list): Now static.
8957 (set_frame_buffer_list): Remove; unused.
8958 * frame.h (other_visible_frames): Remove decl.
8959 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
8960 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
8961 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
8963 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
8964 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
8965 Define only if HAVE_GPM.
8966 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
8967 (update_hints_inhibit): Remove; never set. All uses removed.
8968 * widgetprv.h (emacsFrameClassRec): Remove decl.
8969 * window.c (delete_deletable_window): Now returns void, since it
8970 wasn't returning anything.
8971 (compare_window_configurations): Remove unused locals.
8972 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
8973 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
8974 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
8975 the same widths as pointers. This follows up on the 2011-05-06 patch.
8976 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
8977 * xterm.h: Likewise.
8978 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
8980 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
8982 * makefile.w32-in: Update dependencies.
8983 (LISP_H): Add lib/intprops.h.
8985 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
8987 * image.c (gif_load): Add animation frame delay to the metadata.
8988 (syms_of_image): Use DEFSYM. New symbol `delay'.
8990 2011-06-11 Martin Rudalics <rudalics@gmx.at>
8992 * window.c (delete_deletable_window): Re-add.
8993 (Fset_window_configuration): Rewrite to handle dead buffers and
8994 consequently deletable windows.
8995 (window_tree, Fwindow_tree): Remove. Supply functionality in
8997 (compare_window_configurations): Simplify code.
8999 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
9001 * image.c (imagemagick_load_image): Fix type mismatch.
9002 (Fimagemagick_types): Likewise.
9004 * window.h (replace_buffer_in_windows): Declare.
9006 2011-06-11 Martin Rudalics <rudalics@gmx.at>
9008 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
9009 Qclone_number. Remove external declaration of Qdelete_window.
9010 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
9012 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
9013 Run Qbuffer_list_update_hook if allowed.
9014 (Fother_buffer): Rewrite doc-string. Major rewrite for new
9015 buffer list implementation.
9016 (other_buffer_safely): New function.
9017 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
9018 calls to replace_buffer_in_windows and
9019 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
9021 (record_buffer): Inhibit quitting and rewrite using quittable
9022 functions. Run Qbuffer_list_update_hook if allowed.
9023 (Frecord_buffer, Funrecord_buffer): New functions.
9024 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
9025 Move switch-to-buffer to window.el.
9026 (bury-buffer): Move to window.el.
9027 (Vbuffer_list_update_hook): New variable.
9029 * lisp.h (other_buffer_safely): Add prototype in buffer.c
9032 * window.h (resize_frame_windows): Move up in code.
9033 (Fwindow_frame): Remove EXFUN.
9034 (replace_buffer_in_all_windows): Remove prototype.
9035 (replace_buffer_in_windows_safely): Add prototype.
9037 * window.c: Declare Qdelete_window static again. Move down
9038 declaration of select_count.
9039 (Fnext_window, Fprevious_window): Rewrite doc-strings.
9040 (Fother_window): Move to window.el.
9041 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
9042 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
9043 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
9045 (replace_buffer_in_windows): Implement by calling
9046 Qreplace_buffer_in_windows.
9047 (replace_buffer_in_all_windows): Remove with some functionality
9048 moved into replace_buffer_in_windows_safely.
9049 (replace_buffer_in_windows_safely): New function.
9050 (select_window_norecord, select_frame_norecord): Move in front
9051 of run_window_configuration_change_hook. Remove now obsolete
9053 (Fset_window_buffer): Rewrite doc-string.
9054 Call Qrecord_window_buffer.
9055 (keys_of_window): Move binding for other-window to window.el.
9057 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
9059 * dispextern.h (struct image): Replace data member, whose int_val
9060 and ptr_val fields were not used by anything, with a single
9063 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
9064 (gif_clear_image, gif_load, imagemagick_load_image)
9065 (gs_clear_image, gs_load): Callers changed.
9067 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
9069 * buffer.h: Include <time.h>, for time_t.
9070 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
9072 Fix minor problems found by static checking.
9074 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
9076 Make identifiers static if they are not used in other modules.
9077 * data.c (Qcompiled_function, Qframe, Qvector):
9078 * image.c (QimageMagick, Qsvg):
9079 * minibuf.c (Qmetadata):
9080 * window.c (resize_window_check, resize_root_window): Now static.
9081 * window.h (resize_window_check, resize_root_window): Remove decls.
9083 * window.c (window_deletion_count, delete_deletable_window):
9085 (window_body_lines): Now static.
9086 (Fdelete_other_windows_internal): Mark vars as initialized.
9087 Make sure 'resize_failed' is initialized.
9088 (run_window_configuration_change_hook): Rename local to avoid shadowing.
9089 (resize_window_apply): Remove unused local.
9090 * window.h (delete_deletable_window): Remove decl.
9092 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
9093 (imagemagick_load_image): Fix pointer signedness problem by changing
9094 last arg from unsigned char * to char *. All uses changed.
9095 Also, fix a local for similar reasons.
9096 Remove unused locals. Remove locals to avoid shadowing.
9097 (fn_rsvg_handle_free): Remove; unused.
9098 (svg_load, svg_load_image): Fix pointer signedness problem.
9099 (imagemagick_load_image): Don't use garbage pointer image_wand.
9101 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
9103 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
9105 * image.c (gif_load): Fix omitted cast error introduced by
9108 2011-06-10 Martin Rudalics <rudalics@gmx.at>
9110 * window.h (resize_proportionally, orig_total_lines)
9111 (orig_top_line): Remove from window structure.
9112 (set_window_height, set_window_width, change_window_heights)
9113 (Fdelete_window): Remove prototypes.
9114 (resize_frame_windows): Remove duplicate declaration.
9116 2011-06-10 Eli Zaretskii <eliz@gnu.org>
9118 * window.h (resize_frame_windows, resize_window_check)
9119 (delete_deletable_window, resize_root_window)
9120 (resize_frame_windows): Declare prototypes.
9122 * window.c (resize_window_apply): Make definition be "static" to
9123 match the prototype.
9125 2011-06-10 Martin Rudalics <rudalics@gmx.at>
9127 * window.c: Remove declarations of Qwindow_size_fixed,
9128 window_min_size_1, window_min_size_2, window_min_size,
9129 size_window, window_fixed_size_p, enlarge_window, delete_window.
9130 Remove static from declaration of Qdelete_window, it's
9131 temporarily needed by Fbury_buffer.
9132 (replace_window): Don't assign orig_top_line and
9134 (Fdelete_window, delete_window): Remove. Window deletion is
9135 handled by window.el.
9136 (window_loop): Remove DELETE_OTHER_WINDOWS case.
9137 Replace Fdelete_window calls with calls to Qdelete_window.
9138 (Fdelete_other_windows): Remove. Deleting other windows is
9139 handled by window.el.
9140 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
9141 handled in window.el.
9142 (window_min_size_2, window_min_size_1, window_min_size): Remove.
9143 Window minimum sizes are handled in window.el.
9144 (shrink_windows, size_window, set_window_height)
9145 (set_window_width, change_window_heights, window_height)
9146 (window_width, CURBEG, CURSIZE, enlarge_window)
9147 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
9148 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
9149 handled in window.el.
9150 (make_dummy_parent): Rename to make_parent_window and give it a
9151 second argument horflag.
9152 (make_window): Don't set resize_proportionally any more.
9153 (Fsplit_window): Remove. Windows are split in window.el.
9154 (save_restore_action, save_restore_orig_size)
9155 (shrink_window_lowest_first, save_restore_orig_size): Remove.
9156 Resize mini windows in window.el.
9157 (grow_mini_window, shrink_mini_window): Implement by calling
9158 Qresize_root_window_vertically, resize_window_check and
9159 resize_window_apply.
9160 (saved_window, Fset_window_configuration, save_window_save):
9161 Do not handle orig_top_line, orig_total_lines, and
9162 resize_proportionally.
9163 (window_min_height, window_min_width): Move to window.el.
9164 (keys_of_window): Move bindings for delete-other-windows,
9165 split-window, delete-window and enlarge-window to window.el.
9167 * buffer.c: Temporarily extern Qdelete_window.
9168 (Fbury_buffer): Temporarily call Qdelete_window instead of
9169 Fdelete_window (Fbury_buffer will move to window.el soon).
9171 * frame.c (set_menu_bar_lines_1): Remove code handling
9172 orig_top_line and orig_total_lines.
9174 * dispnew.c (adjust_frame_glyphs_initially): Don't use
9175 set_window_height but set heights directly.
9176 (change_frame_size_1): Use resize_frame_windows.
9178 * xdisp.c (init_xdisp): Don't use set_window_height but set
9181 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
9182 Use resize_frame_windows instead of change_window_heights and run
9183 run_window_configuration_change_hook.
9185 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
9186 instead of change_window_heights and run
9187 run_window_configuration_change_hook.
9189 2011-06-09 Martin Rudalics <rudalics@gmx.at>
9191 * window.c (replace_window): Rename second argument REPLACEMENT to
9192 NEW. New third argument SETFLAG. Rewrite.
9193 (delete_window, make_dummy_parent): Call replace_window with
9195 (window_list_1): Move down in code.
9196 (run_window_configuration_change_hook): Move set_buffer part
9197 before select_frame_norecord part in order to unwind correctly.
9198 Rename count1 to count.
9199 (recombine_windows, delete_deletable_window, resize_root_window)
9200 (Fdelete_other_windows_internal)
9201 (Frun_window_configuration_change_hook, make_parent_window)
9202 (resize_window_check, resize_window_apply, Fresize_window_apply)
9203 (resize_frame_windows, Fsplit_window_internal)
9204 (Fdelete_window_internal, Fresize_mini_window_internal):
9206 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
9208 2011-06-08 Martin Rudalics <rudalics@gmx.at>
9210 * window.h (window): Add some new members to window structure -
9211 normal_lines, normal_cols, new_total, new_normal, clone_number,
9212 splits, nest, prev_buffers, next_buffers.
9213 (WINDOW_TOTAL_SIZE): Move here from window.c.
9214 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
9216 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
9218 (make_dummy_parent): Set new members of windows structure.
9219 (make_window): Move down in code. Handle new members of window
9221 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
9222 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
9223 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
9224 (Fset_window_prev_buffers, Fwindow_next_buffers)
9225 (Fset_window_next_buffers, Fset_window_clone_number):
9227 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
9228 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
9230 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
9231 Argument WINDOW can be now internal window too.
9232 (Fwindow_use_time): Move up in code.
9233 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
9235 (Fset_window_configuration, saved_window)
9236 (Fcurrent_window_configuration, save_window_save): Handle new
9237 members of window structure.
9238 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
9239 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
9240 (syms_of_window): New Lisp objects Qrecord_window_buffer,
9241 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
9242 Qget_mru_window, Qresize_root_window,
9243 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
9244 Qauto_buffer_name; staticpro them.
9246 2011-06-07 Martin Rudalics <rudalics@gmx.at>
9248 * window.c (Fwindow_total_size, Fwindow_left_column)
9249 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
9250 (Fwindow_list_1): New functions.
9251 (window_box_text_cols): Replace with window_body_cols.
9252 (Fwindow_width, Fscroll_left, Fscroll_right):
9253 Use window_body_cols instead of window_box_text_cols.
9254 (delete_window, Fset_window_configuration):
9255 Call delete_all_subwindows with window as argument.
9256 (delete_all_subwindows): Take a window as argument and not a
9258 (window_loop): Remove handling of GET_LRU_WINDOW and
9260 (Fget_lru_window, Fget_largest_window): Move to window.el.
9262 * window.h: Extern window_body_cols instead of
9263 window_box_text_cols. delete_all_subwindows now takes a
9264 Lisp_Object as argument.
9266 * indent.c (compute_motion, Fcompute_motion):
9267 Use window_body_cols instead of window_box_text_cols.
9269 * frame.c (delete_frame): Call delete_all_subwindows with root
9272 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
9274 * fns.c (Fputhash): Document return value.
9276 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
9278 * image.c (gif_load): Implement gif89a spec "no disposal" method.
9280 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9282 Cons<->int and similar integer overflow fixes (Bug#8794).
9284 Check for overflow when converting integer to cons and back.
9285 * charset.c (Fdefine_charset_internal, Fdecode_char):
9286 Use cons_to_unsigned to catch overflow.
9287 (Fencode_char): Use INTEGER_TO_CONS.
9288 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
9289 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
9290 * data.c (long_to_cons, cons_to_long): Remove.
9291 (cons_to_unsigned, cons_to_signed): New functions.
9292 These signal an error for invalid or out-of-range values.
9293 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
9294 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
9295 * font.c (Ffont_variation_glyphs):
9296 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
9297 * lisp.h: Include <intprops.h>.
9298 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
9299 (cons_to_signed, cons_to_unsigned): New decls.
9300 (long_to_cons, cons_to_long): Remove decls.
9301 * undo.c (record_first_change): Use INTEGER_TO_CONS.
9302 (Fprimitive_undo): Use CONS_TO_INTEGER.
9303 * xfns.c (Fx_window_property): Likewise.
9304 * xselect.c: Include <limits.h>.
9305 (x_own_selection, selection_data_to_lisp_data):
9306 Use INTEGER_TO_CONS.
9307 (x_handle_selection_request, x_handle_selection_clear)
9308 (x_get_foreign_selection, Fx_disown_selection_internal)
9309 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
9310 (lisp_data_to_selection_data): Use cons_to_unsigned.
9311 (x_fill_property_data): Use cons_to_signed.
9312 Report values out of range.
9314 Check for buffer and string overflow more precisely.
9315 * buffer.h (BUF_BYTES_MAX): New macro.
9316 * lisp.h (STRING_BYTES_MAX): New macro.
9317 * alloc.c (Fmake_string):
9318 * character.c (string_escape_byte8):
9319 * coding.c (coding_alloc_by_realloc):
9320 * doprnt.c (doprnt):
9321 * editfns.c (Fformat):
9323 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
9324 since they may not be the same number.
9325 * editfns.c (Finsert_char):
9326 * fileio.c (Finsert_file_contents):
9327 Likewise for BUF_BYTES_MAX.
9329 * image.c: Use ptrdiff_t, not int, for sizes.
9330 (slurp_file): Switch from int to ptrdiff_t.
9332 (slurp_file): Check that file size fits in both size_t (for
9333 malloc) and ptrdiff_t (for sanity and safety).
9335 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
9336 if b->modtime has its maximal value.
9338 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
9340 Don't assume time_t can fit into int.
9341 * buffer.h (struct buffer.modtime): Now time_t, not int.
9342 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
9343 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
9345 Minor fixes for signed vs unsigned integers.
9346 * character.h (MAYBE_UNIFY_CHAR):
9347 * charset.c (maybe_unify_char):
9348 * keyboard.c (read_char, reorder_modifiers):
9349 XINT -> XFASTINT, since the integer must be nonnegative.
9350 * ftfont.c (ftfont_spec_pattern):
9351 * keymap.c (access_keymap, silly_event_symbol_error):
9352 XUINT -> XFASTINT, since the integer must be nonnegative.
9353 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
9354 since it makes no difference and we prefer signed.
9355 * keyboard.c (record_char): Use XUINT when all the neighbors do.
9356 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
9359 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
9361 * window.h (Fwindow_frame): Declare.
9363 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9365 * alloc.c: Simplify handling of large-request failures (Bug#8800).
9366 (SPARE_MEMORY): Always define.
9367 (LARGE_REQUEST): Remove.
9368 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
9370 2011-06-06 Martin Rudalics <rudalics@gmx.at>
9372 * lisp.h: Move EXFUNS for Fframe_root_window,
9373 Fframe_first_window and Fset_frame_selected_window to window.h.
9375 * window.h: Move EXFUNS for Fframe_root_window,
9376 Fframe_first_window and Fset_frame_selected_window here from
9379 * frame.c (Fwindow_frame, Fframe_first_window)
9380 (Fframe_root_window, Fframe_selected_window)
9381 (Fset_frame_selected_window): Move to window.c.
9382 (Factive_minibuffer_window): Move to minibuf.c.
9383 (Fother_visible_frames_p): New function.
9385 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
9387 * window.c (decode_window, decode_any_window): Move up in code.
9388 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
9389 (inhibit_frame_unsplittable): Remove unused variable.
9390 (Fwindow_buffer): Move up and rewrite doc-string.
9391 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
9392 (Fwindow_prev): New functions.
9393 (Fwindow_frame): Move here from frame.c. Accept any window as
9395 (Fframe_root_window, Fframe_first_window)
9396 (Fframe_selected_window): Move here from frame.c. Accept frame
9397 or arbitrary window as argument. Update doc-strings.
9398 (Fminibuffer_window): Move up in code.
9399 (Fwindow_minibuffer_p): Move up in code and simplify.
9400 (Fset_frame_selected_window): Move here from frame.c.
9402 (Fselected_window, select_window, Fselect_window): Move up in
9403 code. Minor doc-string fixes.
9405 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9407 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
9408 Do not assume that spare memory exists; that assumption is valid
9409 only if SYSTEM_MALLOC.
9410 (LARGE_REQUEST): New macro, so that the issue of large requests
9411 is separated from the issue of spare memory.
9413 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
9415 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
9418 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
9420 * xfns.c (x_set_scroll_bar_default_width): Move declarations
9423 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
9425 * gtkutil.c (xg_get_default_scrollbar_width): New function.
9427 * gtkutil.h: Declare xg_get_default_scrollbar_width.
9429 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
9430 min width by calling x_set_scroll_bar_default_width (Bug#8505).
9432 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
9434 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
9436 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
9438 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
9439 (x_clipboard_manager_save): Add return value.
9440 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
9442 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
9443 Obey Vx_select_enable_clipboard_manager. Catch errors in
9444 x_clipboard_manager_save (Bug#8779).
9445 (Vx_select_enable_clipboard_manager): New variable.
9446 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
9448 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
9450 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
9452 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9454 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
9455 in the current matrix if keep_current_p is non-zero.
9457 2011-06-04 Eli Zaretskii <eliz@gnu.org>
9459 * bidi.c (bidi_level_of_next_char): Fix last change.
9461 2011-06-03 Eli Zaretskii <eliz@gnu.org>
9463 Support bidi reordering of text covered by display properties.
9465 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
9466 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
9467 (bidi_cache_search, bidi_cache_iterator_state)
9468 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
9469 (bidi_level_of_next_char, bidi_move_to_visually_next):
9470 Support character positions inside a run of characters covered by a
9472 (bidi_paragraph_init, bidi_resolve_explicit_1)
9473 (bidi_level_of_next_char): Call bidi_fetch_char and
9474 bidi_fetch_char_advance instead of FETCH_CHAR and
9476 (bidi_init_it): Initialize new members.
9477 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
9479 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
9480 instead of using explicit *_CHAR codes.
9481 (bidi_resolve_explicit, bidi_resolve_weak):
9482 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
9483 bidirectional text is supported only in multibyte buffers.
9484 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
9485 it to initialize the frame_window_p member of struct bidi_it.
9486 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
9487 (bidi_resolve_explicit, bidi_resolve_weak)
9488 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
9489 bidi_it->nchars is non-positive.
9490 (bidi_level_of_next_char): Don't try to lookup the cache for the
9491 next/previous character if nothing is cached there yet, or if we
9492 were just reseat()'ed to a new position.
9494 * xdisp.c (set_cursor_from_row): Set start and stop points
9495 according to the row's direction when priming the loop that looks
9496 for the glyph on which to display cursor.
9497 (single_display_spec_intangible_p): Function deleted.
9498 (display_prop_intangible_p): Reimplement to call
9499 handle_display_spec instead of single_display_spec_intangible_p.
9500 Accept 3 additional arguments needed by handle_display_spec.
9501 This fixes incorrect cursor motion across display property with complex
9502 values: lists, `(when COND...)' forms, etc.
9503 (single_display_spec_string_p): Support property values that are
9504 lists with the argument STRING its top-level element.
9505 (display_prop_string_p): Fix the condition for processing a
9506 property that is a list to be consistent with handle_display_spec.
9507 (handle_display_spec): New function, refactored from the
9508 last portion of handle_display_prop.
9509 (compute_display_string_pos): Accept additional argument
9510 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
9511 value of a `display' property is a "replacing spec".
9512 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
9513 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
9514 the display property, but just return a value indicating whether
9515 the display property will replace the characters it covers.
9516 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
9517 frame_window_p members of struct bidi_it.
9518 (compute_display_string_pos, compute_display_string_end):
9520 (push_it): Accept second argument POSITION, where pop_it should
9521 jump to continue iteration.
9522 (reseat_1): Initialize bidi_it.disp_pos.
9524 * keyboard.c (adjust_point_for_property): Adjust the call to
9525 display_prop_intangible_p to its new signature.
9527 * dispextern.h (struct bidi_it): New member frame_window_p.
9528 (bidi_init_it): Update prototypes.
9529 (display_prop_intangible_p): Update prototype.
9530 (compute_display_string_pos, compute_display_string_end):
9532 (struct bidi_it): New members nchars and disp_pos. ch_len is now
9535 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
9537 Malloc failure behavior now depends on size of allocation.
9538 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
9539 * lisp.h: Change signatures accordingly.
9540 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
9541 All callers changed. (Bug#8762)
9543 * gnutls.c: Use Emacs's memory allocators.
9544 Without this change, the gnutls library would invoke malloc etc.
9545 directly, which causes problems on non-SYNC_INPUT hosts, and which
9546 runs afoul of improving memory_full behavior. (Bug#8761)
9547 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
9548 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
9549 xfree instead of the default malloc, realloc, free.
9550 (Fgnutls_boot): No need to check for memory allocation failure,
9551 since xmalloc does that for us.
9553 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
9554 * category.c (hash_get_category_set):
9555 * ccl.c (ccl_driver):
9556 * charset.c (Fdefine_charset_internal):
9557 * charset.h (struct charset.hash_index):
9558 * composite.c (get_composition_id, gstring_lookup_cache)
9559 (composition_gstring_put_cache):
9560 * composite.h (struct composition.hash_index):
9561 * dispextern.h (struct image.hash):
9562 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
9563 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
9564 (hashfn_equal, hashfn_user_defined, make_hash_table)
9565 (maybe_resize_hash_table, hash_lookup, hash_put)
9566 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
9567 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
9568 (Fsxhash, Fgethash, Fputhash, Fmaphash):
9569 * image.c (make_image, search_image_cache, lookup_image)
9570 (xpm_put_color_table_h):
9571 * lisp.h (struct Lisp_Hash_Table):
9572 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
9573 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
9574 for hashes and hash indexes, instead of 'unsigned' and 'int'.
9575 * alloc.c (allocate_vectorlike):
9576 Check for overflow in vector size calculations.
9577 * ccl.c (ccl_driver):
9578 Check for overflow when converting EMACS_INT to int.
9579 * fns.c, image.c: Remove unnecessary static decls that would otherwise
9580 need to be updated by these changes.
9581 * fns.c (make_hash_table, maybe_resize_hash_table):
9582 Check for integer overflow with large hash tables.
9583 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
9584 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
9585 (SXHASH_REDUCE): New macro.
9586 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
9587 Use it instead of discarding useful hash info with large hash values.
9588 (sxhash_float): New function.
9589 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
9590 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
9591 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
9592 Rewrite to use FIXNUM_BITS, as this simplifies things.
9593 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
9594 Adjust signatures to match updated version of code.
9595 (consing_since_gc): Now EMACS_INT, since a single hash table can
9596 use more than INT_MAX bytes.
9598 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
9600 Make it possible to build with GCC-4.6+ -O2 -flto.
9602 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
9604 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
9606 * minibuf.c (get_minibuffer, read_minibuf_unwind):
9607 Call minibuffer-inactive-mode.
9609 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
9611 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
9612 Update dependencies.
9614 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9616 * data.c (init_data): Remove code for UTS, this system is not
9619 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9621 Don't force ./temacs to start in terminal mode.
9623 * frame.c (make_initial_frame): Initialize faces in all cases, not
9624 only when CANNOT_DUMP is defined.
9625 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
9627 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9629 * dispnew.c (add_window_display_history): Use const for the string
9630 pointer. Remove declaration, not needed.
9632 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9634 Use 'inline', not 'INLINE'.
9635 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
9636 * alloc.c, fontset.c (INLINE): Remove.
9637 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
9638 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
9639 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
9640 * gmalloc.c (register_heapinfo): Use inline unconditionally.
9641 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
9643 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9645 Make it possible to run ./temacs.
9647 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
9648 syms_of_callproc does the same thing. Remove test for
9649 "initialized", do it in the caller.
9650 * emacs.c (main): Avoid calling set_initial_environment when dumping.
9652 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
9654 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
9655 (read_minibuf): Use get_minibuffer.
9656 (syms_of_minibuf): Use DEFSYM.
9657 (Qmetadata): New var.
9658 * data.c (Qbuffer): Don't make it static.
9659 (syms_of_data): Use DEFSYM.
9661 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9663 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
9664 (CCL_CODE_MIN): New macro.
9666 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
9668 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
9670 * eval.c (Qdebug): Now static.
9671 * lisp.h (Qdebug): Remove decl. This reverts a part of the
9672 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
9673 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
9675 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
9677 * image.c: Various fixes to ImageMagick code comments.
9678 (Fimagemagick_types): Doc fix.
9680 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
9682 Minor fixes prompted by GCC 4.6.0 warnings.
9684 * xselect.c (converted_selections, conversion_fail_tag): Now static.
9686 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
9687 (x_clipboard_manager_save_all): Move extern decl to ...
9688 * xterm.h: ... here, so that it can be checked for consistency.
9690 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
9692 * xselect.c (x_clipboard_manager_save_frame)
9693 (x_clipboard_manager_save_all): New functions.
9694 (Fx_clipboard_manager_save): Lisp function deleted.
9696 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
9697 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
9699 * xterm.h: Update prototype.
9701 2011-05-28 William Xu <william.xwl@gmail.com>
9703 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
9706 2011-05-28 Jim Meyering <meyering@redhat.com>
9708 Avoid a sign-extension bug in crypto_hash_function.
9709 * fns.c (to_uchar): Define.
9710 (crypto_hash_function): Use it to convert some newly-signed
9711 variables to unsigned, to avoid sign-extension bugs. For example,
9712 without this change, (md5 "truc") would evaluate to
9713 45723a2aff78ff4fff7fff1114760e62 rather than the expected
9714 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
9715 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
9717 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9719 Integer overflow fixes.
9721 * dbusbind.c: Serial number integer overflow fixes.
9722 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
9723 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
9724 to hold a serial number that is too large for a fixnum.
9725 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9726 Check for serial numbers out of range. Decode any serial number
9727 that was so large that it became a float. (Bug#8722)
9729 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
9730 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9731 Use XFASTINT rather than XUINT when numbers are nonnegative.
9732 (xd_append_arg, Fdbus_method_return_internal):
9733 (Fdbus_method_error_internal): Likewise. Also, for unsigned
9734 arguments, check that Lisp number is nonnegative, rather than
9735 silently wrapping negative numbers around. (Bug#8722)
9736 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
9739 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
9741 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
9743 ccl: Add integer overflow checks.
9744 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
9745 (IN_INT_RANGE): New macros.
9746 (ccl_driver): Use them to check for integer overflow when
9747 decoding a CCL program. Many of the new checks are whether XINT (x)
9748 fits in int; it doesn't always, on 64-bit hosts. The new version
9749 doesn't catch all possible integer overflows, but it's an
9750 improvement. (Bug#8719)
9752 * alloc.c (make_event_array): Use XINT, not XUINT.
9753 There's no need for unsigned here.
9755 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
9756 This follows up to the 2011-05-06 change that substituted uintptr_t
9757 for EMACS_INT. This case wasn't caught back then.
9759 Rework Fformat to avoid integer overflow issues.
9760 * editfns.c: Include <float.h> unconditionally, as it's everywhere
9761 now (part of C89). Include <verify.h>.
9762 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
9763 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
9764 (Fformat): Avoid the prepass trying to compute sizes; it was only
9765 approximate and thus did not catch overflow reliably. Instead, walk
9766 through the format just once, formatting and computing sizes as we go,
9767 checking for integer overflow at every step, and allocating a larger
9768 buffer as needed. Keep track separately whether the format is
9769 multibyte. Keep only the most-recently calculated precision, rather
9770 than them all. Record whether each argument has been converted to
9771 string. Use EMACS_INT, not int, for byte and char and arg counts.
9772 Support field widths and precisions larger than INT_MAX. Avoid
9773 sprintf's undefined behavior with conversion specifications such as %#d
9774 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
9775 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
9776 formatting out-of-range floating point numbers with int
9779 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
9781 * data.c: Avoid integer truncation in expressions involving floats.
9782 * data.c: Include <intprops.h>.
9783 (arith_driver): When there's an integer overflow in an expression
9784 involving floating point, convert the integers to floating point
9785 so that the resulting value does not suffer from catastrophic
9786 integer truncation. For example, on a 64-bit host (* 4
9787 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
9788 Do not rely on undefined behavior after integer overflow.
9790 merge count_size_as_multibyte, parse_str_to_multibyte
9791 * character.c, character.h (count_size_as_multibyte):
9792 Rename from parse_str_to_multibyte; all uses changed.
9793 Check for integer overflow.
9794 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
9795 since it's now a duplicate of the other. This is more of
9796 a character than a buffer op, so better that it's in character.c.
9797 * fns.c, print.c: Adjust to above changes.
9799 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
9801 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
9803 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9805 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9806 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
9807 (x_clipboard_manager_save): Now static.
9808 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
9810 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9811 (crypto_hash_function): Now static.
9812 Fix pointer signedness problems. Avoid unnecessary initializations.
9814 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
9816 * termhooks.h (Vselection_alist): Make it terminal-local.
9818 * terminal.c (create_terminal): Initialize it.
9820 * xselect.c: Support for clipboard managers.
9821 (Vselection_alist): Move to termhooks.h as terminal-local var.
9822 (LOCAL_SELECTION): New macro.
9823 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
9824 (symbol_to_x_atom): Remove gratuitous arg.
9825 (x_handle_selection_request, lisp_data_to_selection_data)
9826 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
9827 (x_own_selection, x_get_local_selection, x_convert_selection):
9828 New arg, specifying work frame. Use terminal-local Vselection_alist.
9829 (some_frame_on_display): Delete unused function.
9830 (Fx_own_selection_internal, Fx_get_selection_internal)
9831 (Fx_disown_selection_internal, Fx_selection_owner_p)
9832 (Fx_selection_exists_p): New optional frame arg.
9833 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
9834 (x_handle_selection_clear): Don't treat other terminals with the
9835 same keyboard specially. Use the terminal-local Vselection_alist.
9836 (x_clear_frame_selections): Use Frun_hook_with_args.
9838 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
9840 * xterm.h: Add support for those atoms.
9842 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
9844 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
9845 (converted_selections, conversion_fail_tag): New global variables.
9846 (x_selection_request_lisp_error): Free the above.
9847 (x_get_local_selection): Remove unnecessary code.
9848 (x_reply_selection_request): Args changed; handle arbitrary array
9849 of converted selections stored in converted_selections.
9850 Separate the XChangeProperty and SelectionNotify steps.
9851 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
9852 (x_convert_selection): New function.
9853 (x_handle_selection_event): Simplify.
9854 (x_get_foreign_selection): Don't ignore incoming requests while
9855 waiting for an answer; this will fail when we implement
9856 SAVE_TARGETS, and seems unnecessary anyway.
9857 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
9858 (Vx_sent_selection_functions): Doc fix.
9860 2011-05-26 Leo Liu <sdl.web@gmail.com>
9862 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
9864 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9866 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
9868 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
9869 for fringe update if it has periodic bitmap.
9870 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
9871 and fringe_bitmap_periodic_p.
9873 * fringe.c (get_fringe_bitmap_data): New function.
9874 (draw_fringe_bitmap_1, update_window_fringes): Use it.
9875 (update_window_fringes): Record periodicity of fringe bitmap in glyph
9876 row. Mark glyph row for fringe update if periodicity changed.
9878 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
9879 for fringe update unless it has periodic bitmap.
9881 2011-05-25 Kenichi Handa <handa@m17n.org>
9883 * xdisp.c (get_next_display_element): Set correct it->face_id for
9884 a static composition.
9886 2011-05-24 Leo Liu <sdl.web@gmail.com>
9889 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
9891 * fns.c (crypto_hash_function, Fsha1): New function.
9892 (Fmd5): Use crypto_hash_function.
9893 (syms_of_fns): Add Ssha1.
9895 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9897 * gnutls.c: Remove unused macros.
9898 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
9899 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
9900 Remove macros that are defined and never used.
9901 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
9903 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
9905 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
9906 (Fx_get_selection_internal): Minor cleanup.
9907 (Fx_own_selection_internal): Rename arguments for consistency with
9910 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9912 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
9914 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
9916 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
9918 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9920 * dispnew.c (scrolling_window): Don't exclude the case that the
9921 last enabled row in the desired matrix touches the bottom boundary.
9923 2011-05-21 Glenn Morris <rgm@gnu.org>
9925 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
9926 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
9927 and add some more files.
9929 2011-05-20 Eli Zaretskii <eliz@gnu.org>
9931 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
9932 report_file_error introduced by the change from 2011-05-07.
9934 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
9936 * systime.h (Time): Define only if emacs is defined.
9937 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
9938 where the include path doesn't have X11/X.h by default. See
9939 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
9941 2011-05-20 Kenichi Handa <handa@m17n.org>
9943 * composite.c (find_automatic_composition): Fix previous change.
9945 2011-05-20 Glenn Morris <rgm@gnu.org>
9947 * lisp.mk: New file, split from Makefile.in.
9948 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
9949 (shortlisp): Remove.
9950 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
9952 2011-05-19 Glenn Morris <rgm@gnu.org>
9954 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
9955 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
9956 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
9957 (lisp): Set the order to that of loadup.el.
9958 (shortlisp): Make it a copy of $lisp.
9959 (SOME_MACHINE_LISP): Remove.
9960 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
9961 Use just $shortlisp, not $SOME_MACHINE_LISP too.
9963 2011-05-18 Kenichi Handa <handa@m17n.org>
9965 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
9966 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
9967 (find_automatic_composition): Mostly rewrite for efficiency.
9969 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
9971 * makefile.w32-in: Update dependencies.
9973 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
9975 * menu.c: Include limits.h (fixes the MS-Windows build broken by
9976 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
9978 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
9980 Fix some integer overflow issues, such as string length overflow.
9982 * insdel.c (count_size_as_multibyte): Check for string overflow.
9984 * character.c (lisp_string_width): Check for string overflow.
9985 Use EMACS_INT, not int, for string indexes and lengths; in
9986 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
9987 the resulting string length overflows an EMACS_INT; instead,
9988 report a string overflow if no precision given. When checking for
9989 precision exhaustion, use a check that cannot possibly have
9990 integer overflow. (Bug#8675)
9991 * character.h (lisp_string_width): Adjust to new signature.
9993 * alloc.c (string_overflow): New function.
9994 (Fmake_string): Use it. This doesn't change behavior, but saves
9995 a few bytes and will simplify future changes.
9996 * character.c (string_escape_byte8): Likewise.
9997 * lisp.h (string_overflow): New decl.
9999 Fixups, following up to the user-interface timestamp change.
10000 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
10001 for UI timestamps, instead of unsigned long.
10002 * msdos.c (mouse_get_pos): Likewise.
10003 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
10004 * w32gui.h (Time): Define by including "systime.h" rather than by
10005 declaring it ourselves. (Bug#8664)
10007 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
10008 * image.c (clear_image_cache): Likewise.
10010 * term.c (term_mouse_position): Don't assume time_t wraparound.
10012 Be more systematic about user-interface timestamps.
10013 Before, the code sometimes used 'Time', sometimes 'unsigned long',
10014 and sometimes 'EMACS_UINT', to represent these timestamps.
10015 This change causes it to use 'Time' uniformly, as that's what X uses.
10016 This makes the code easier to follow, and makes it easier to catch
10017 integer overflow bugs such as Bug#8664.
10018 * frame.c (Fmouse_position, Fmouse_pixel_position):
10019 Use Time, not unsigned long, for user-interface timestamps.
10020 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
10021 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
10022 * keyboard.h (last_event_timestamp): Likewise.
10023 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
10024 * menu.h (xmenu_show): Likewise.
10025 * term.c (term_mouse_position): Likewise.
10026 * termhooks.h (struct input_event.timestamp): Likewise.
10027 (struct terminal.mouse_position_hook): Likewise.
10028 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
10029 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
10030 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
10031 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
10032 what it was before.
10033 * menu.h, termhooks.h: Include "systime.h", for Time.
10035 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
10036 Don't assume that the difference between two unsigned long values
10037 can fit into an integer. At this point, we know button_down_time
10038 <= event->timestamp, so the difference must be nonnegative, so
10039 there's no need to cast the result if double-click-time is
10040 nonnegative, as it should be; check that it's nonnegative, just in
10041 case. This bug is triggered when events are more than 2**31 ms
10042 apart (about 25 days). (Bug#8664)
10044 * xselect.c (last_event_timestamp): Remove duplicate decl.
10045 (x_own_selection): Remove needless cast to unsigned long.
10047 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
10048 that always fit in int. Use a sentinel instead of a counter, to
10049 avoid a temp and to allay GCC's concerns about possible int overflow.
10050 * frame.h (struct frame): Use int for menu_bar_items_used
10051 instead of EMACS_INT, since it always fits in int.
10053 * menu.c (grow_menu_items): Check for int overflow.
10055 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
10057 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
10058 Before, the code was not consistent. These values cannot exceed
10059 2**31 - 1 so there's no need to make them unsigned.
10060 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
10061 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
10062 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
10064 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
10066 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
10067 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
10068 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
10069 presumably because the widths might not match.
10071 * window.c (size_window): Avoid needless test at loop start.
10073 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
10075 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
10077 2011-05-12 Drew Adams <drew.adams@oracle.com>
10079 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
10081 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10083 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
10084 `width' to `bar_area_x' and `bar_area_width', respectively.
10085 (x_scroll_run): Take account of fringe background extension.
10087 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
10088 Rename local vars `left' and `width' to `bar_area_x' and
10089 `bar_area_width', respectively.
10090 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
10091 background extension.
10093 2011-05-10 Jim Meyering <meyering@redhat.com>
10095 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
10097 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
10099 * image.c (Finit_image_library): Return t for built-in image types,
10100 like pbm and xbm. (Bug#8640)
10102 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
10104 * w32menu.c (set_frame_menubar): Fix submenu allocation.
10106 2011-05-07 Eli Zaretskii <eliz@gnu.org>
10108 * w32console.c (Fset_screen_color): Doc fix.
10109 (Fget_screen_color): New function.
10110 (syms_of_ntterm): Defsubr it.
10112 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
10113 unlink the temporary file if Fcall_process didn't create it in the
10115 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
10116 child process will be redirected to a file specified with `:file'.
10117 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
10118 cue to call_process_cleanup not to close that handle.
10120 2011-05-07 Ben Key <bkey76@gmail.com>
10122 * makefile.w32-in: The bootstrap-temacs rule now makes use of
10123 one of two shell specific rules, either bootstrap-temacs-CMD or
10124 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
10125 to the previous implementation of the bootstrap-temacs rule.
10126 The bootstrap-temacs-CMD rule is similar to the previous
10127 implementation of the bootstrap-temacs rule except that it
10128 makes use of the ESC_CFLAGS variable instead of the CFLAGS
10131 These changes, along with some changes to nt/configure.bat,
10132 nt/gmake.defs, and nt/nmake.defs, are required to extend my
10133 earlier fix to add support for --cflags and --ldflags options
10134 that include quotes so that it works whether make uses cmd or
10137 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
10139 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
10140 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
10142 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
10143 a string. Handle both cases.
10144 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
10145 (Fdbus_register_method): Use Qinvalid_function.
10147 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
10149 * makefile.w32-in: Update dependencies.
10150 (LISP_H): Add inttypes.h and stdin.h.
10151 (PROCESS_H): Add unistd.h.
10153 2011-05-06 Eli Zaretskii <eliz@gnu.org>
10155 * lread.c: Include limits.h (fixes the MS-Windows build broken by
10156 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
10158 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
10160 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
10162 * term.c (vfatal): Remove stray call to va_end.
10163 It's not needed and the C Standard doesn't allow it here anyway.
10165 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
10166 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
10168 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
10171 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
10173 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
10175 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
10177 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
10179 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
10181 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
10182 * charset.c (Fdefine_charset_internal): Don't initialize
10183 charset.code_space[15]. The value was garbage, on hosts with
10184 32-bit int (Bug#8600).
10186 * lread.c (read_integer): Be more consistent with string-to-number.
10187 Use string_to_number to do the actual conversion; this avoids
10188 rounding errors and fixes some other screwups. Without this fix,
10189 for example, #x1fffffffffffffff was misread as -2305843009213693952.
10190 (digit_to_number): Move earlier, for benefit of read_integer.
10191 Return -1 if the digit is out of range for the base, -2 if it is
10192 not a digit in any supported base. (Bug#8602)
10194 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
10196 * dispnew.c (scrolling_window): Return 1 if we scrolled,
10197 to match comment at start of function. This also removes a
10198 GCC warning about overflow in a 32+64-bit port.
10200 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
10202 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
10203 Reported by Stefan Monnier in
10204 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
10205 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10206 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
10208 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
10209 (EMACS_UINTPTR): Likewise, with uintptr_t.
10211 * lisp.h: Prefer 64-bit EMACS_INT if available.
10212 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
10213 on 32-bit hosts that have 64-bit int, so that they can access
10215 However, temporarily disable this change unless the temporary
10216 symbol WIDE_EMACS_INT is defined.
10218 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
10220 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
10221 This removes an assumption that EMACS_INT and long are the same
10222 width as pointers. The assumption is true for Emacs porting targets
10223 now, but we want to make other targets possible.
10224 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
10225 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
10226 In the rest of the code, change types of integers that hold casted
10227 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
10228 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
10229 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
10230 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
10231 No need to cast type when ORing.
10232 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
10233 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
10234 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
10235 assume EMACS_INT is the same width as char *.
10236 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
10237 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
10238 Remove no-longer-needed casts.
10239 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
10240 (xg_tool_bar_help_callback, xg_make_tool_item):
10241 Use EMACS_INTPTR to hold an integer
10242 that will be cast to void *; this can avoid a GCC warning
10243 if EMACS_INT is not the same width as void *.
10244 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
10245 * xdisp.c (display_echo_area_1, resize_mini_window_1):
10246 (current_message_1, set_message_1):
10247 Use a local to convert to proper width without a cast.
10248 * xmenu.c (dialog_selection_callback): Likewise.
10250 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
10251 Also, don't assume VALBITS / RAND_BITS is less than 5,
10252 and don't rely on undefined behavior when shifting a 1 left into
10254 * lisp.h (get_random): Change signature to match.
10256 * lread.c (hash_string): Use size_t, not int, for hash computation.
10257 Normally we prefer signed values; but hashing is special, because
10258 it's better to use unsigned division on hash table sizes so that
10259 the remainder is nonnegative. Also, size_t is the natural width
10260 for hashing into memory. The previous code used 'int', which doesn't
10261 retain enough info to hash well into very large tables.
10262 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
10264 * dbusbind.c: Don't possibly lose pointer info when converting.
10265 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10266 Use XPNTR rather than XHASH, so that the high-order bits of
10267 the pointer aren't lost when converting through void *.
10269 * eval.c (Fautoload): Don't double-shift a pointer.
10271 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
10273 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
10275 * gnutls.c (DEF_GNUTLS_FN):
10276 * image.c (DEF_IMGLIB_FN): Make function pointers static.
10278 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
10280 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
10283 2011-05-05 Eli Zaretskii <eliz@gnu.org>
10285 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
10286 New version that can reserve upto 2GB of heap space.
10288 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
10290 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
10292 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
10294 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
10295 `gnutls_certificate_set_x509_key_file'.
10297 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
10299 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
10300 Update dependencies.
10302 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
10304 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
10305 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
10306 Remove unused parameter `fildes'.
10307 * process.c (read_process_output, send_process): Don't pass it.
10309 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
10311 Fix previous change: the library cache is defined in w32.c.
10312 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
10313 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
10315 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
10317 Implement dynamic loading of GnuTLS on Windows.
10319 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
10320 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
10321 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10324 * gnutls.c (Qgnutls_dll): Define.
10325 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
10326 (gnutls_*): Declare function pointers.
10327 (init_gnutls_functions): New function to initialize function pointers.
10328 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
10329 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
10330 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10331 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
10332 (emacs_gnutls_write, emacs_gnutls_read)
10333 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
10334 (Fgnutls_available_p): New function.
10335 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
10336 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
10337 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
10339 * image.c: Include w32.h.
10340 (Vimage_type_cache): Delete.
10341 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
10342 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
10343 (w32_delayed_load): Move to w32.c.
10345 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
10347 * w32.c (QCloaded_from, Vlibrary_cache): Define.
10348 (w32_delayed_load): Move from image.c. When loading a library, record
10349 its filename in the :loaded-from property of the library id.
10350 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
10351 Initialize and staticpro them.
10352 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
10354 * process.c: Include lisp.h before w32.h, not after.
10355 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
10356 instead of gnutls_record_check_pending.
10358 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
10360 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
10362 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
10363 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
10366 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
10368 * xterm.c (x_set_frame_alpha): Do not set property on anything
10369 else than FRAME_X_OUTER_WINDOW (Bug#8608).
10371 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
10373 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
10375 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
10377 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
10378 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
10379 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
10380 (gnutls_global_initialized, Qgnutls_bootprop_priority)
10381 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
10382 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
10383 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
10384 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
10385 (Qgnutls_bootprop_callbacks_verify): Make static.
10387 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
10389 * callproc.c: Indentation fixup.
10391 * sysdep.c (wait_for_termination_1): Make static.
10392 (wait_for_termination, interruptible_wait_for_termination):
10393 Move after wait_for_termination_1.
10395 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
10397 * sysdep.c (interruptible_wait_for_termination): New function
10398 which is like wait_for_termination, but allows keyboard
10401 * callproc.c (Fcall_process): Add (:file "file") as an option for
10403 (Fcall_process_region): Ditto.
10405 2011-04-30 Eli Zaretskii <eliz@gnu.org>
10407 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
10408 rather than `XVECTOR (FOO)->size'.
10410 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
10411 inttypes.h, as a gnulib replacement is used if it not available in
10414 2011-04-21 Eli Zaretskii <eliz@gnu.org>
10416 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
10417 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
10418 of MOST_POSITIVE_FIXNUM. (Bug#8528)
10420 * coding.c (coding_alloc_by_realloc): Error out if destination
10421 will grow beyond MOST_POSITIVE_FIXNUM.
10422 (decode_coding_emacs_mule): Abort if there isn't enough place in
10423 charbuf for the composition carryover bytes. Reserve an extra
10424 space for up to 2 characters produced in a loop.
10425 (decode_coding_iso_2022): Abort if there isn't enough place in
10426 charbuf for the composition carryover bytes.
10428 2011-04-21 Eli Zaretskii <eliz@gnu.org>
10430 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
10431 aborting when %lld or %lll format is passed.
10432 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
10433 %llo or %llx format is passed. (Bug#8545)
10435 * window.c (window_scroll_line_based): Use a marker instead of
10436 simple variables to record original value of point. (Bug#7952)
10438 * doprnt.c (doprnt): Fix the case where a multibyte sequence
10439 produced by %s or %c overflows available buffer space. (Bug#8545)
10441 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
10443 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
10444 (SIZE_MAX): Move defn after all includes, as they might #define it.
10446 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
10448 * w32.c (init_environment): Warn about defaulting HOME to C:\.
10450 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
10452 * keyboard.c (Qdelayed_warnings_hook): Define.
10453 (command_loop_1): Run `delayed-warnings-hook'
10454 if Vdelayed_warnings_list is non-nil.
10455 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
10456 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
10458 2011-04-28 Eli Zaretskii <eliz@gnu.org>
10460 * doprnt.c (doprnt): Don't return value smaller than the buffer
10461 size if the message was truncated. (Bug#8545).
10463 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
10465 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
10466 (Fx_window_property): #if-0 the whole functions, not just the bodies.
10468 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10470 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
10472 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
10474 * makefile.w32-in: Update dependencies.
10476 2011-04-27 Eli Zaretskii <eliz@gnu.org>
10478 Improve `doprnt' and its usage. (Bug#8545)
10479 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
10480 `format_end'. Remove support for %l as a conversion specifier.
10481 Don't use xrealloc. Improve diagnostics when the %l size modifier
10482 is used. Update the commentary.
10484 * eval.c (verror): Simplify calculation of size_t.
10486 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
10489 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
10491 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
10494 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10496 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
10497 This makes this file independent of the recent pseudovector change.
10499 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
10501 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
10503 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
10504 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
10505 Remove unused local.
10506 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
10508 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
10509 GCC 4.6.0 optimizes based on type-based alias analysis.
10510 For example, if b is of type struct buffer * and v of type struct
10511 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
10512 != &v->size, and therefore "v->size = 1; b->size = 2; return
10513 v->size;" must therefore return 1. This assumption is incorrect
10514 for Emacs, since it type-puns struct Lisp_Vector * with many other
10515 types. To fix this problem, this patch adds a new type struct
10516 vectorlike_header that documents the constraints on layout of vectors
10517 and pseudovectors, and helps optimizing compilers not get fooled
10518 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
10519 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
10520 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
10522 (XSETPVECTYPE): Rewrite in terms of new macro.
10523 (XSETPVECTYPESIZE): New macro, specifying both type and size.
10524 This is a bit clearer, and further avoids the possibility of
10525 undesirable aliasing.
10526 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
10527 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
10528 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
10529 since Lisp_Subr is a special case (no "next" field).
10530 (ASIZE): Now uses header.size rather than size.
10531 All previous uses of XVECTOR (foo)->size replaced to use this macro,
10532 to avoid the hassle of writing XVECTOR (foo)->header.size.
10533 (struct vectorlike_header): New type.
10534 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
10535 object, to help avoid aliasing.
10536 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
10537 (SUBRP): Likewise, since Lisp_Subr is a special case.
10538 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
10539 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
10540 (struct Lisp_Hash_Table): Combine first two members into a single
10541 struct vectorlike_header member. All uses of "size" and "next" members
10542 changed to be "header.size" and "header.next".
10543 * buffer.h (struct buffer): Likewise.
10544 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
10545 * frame.h (struct frame): Likewise.
10546 * process.h (struct Lisp_Process): Likewise.
10547 * termhooks.h (struct terminal): Likewise.
10548 * window.c (struct save_window_data, struct saved_window): Likewise.
10549 * window.h (struct window): Likewise.
10550 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
10551 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
10552 * buffer.c (init_buffer_once): Likewise.
10553 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
10555 * process.c (Fformat_network_address): Use local var for size,
10558 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
10560 Make the Lisp reader and string-to-float more consistent (Bug#8525)
10561 * data.c (atof): Remove decl; no longer used or needed.
10562 (digit_to_number): Move to lread.c.
10563 (Fstring_to_number): Use new string_to_number function, to be
10564 consistent with how the Lisp reader treats infinities and NaNs.
10565 Do not assume that floating-point numbers represent EMACS_INT
10566 without losing information; this is not true on most 64-bit hosts.
10567 Avoid double-rounding errors, by insisting on integers when
10568 parsing non-base-10 numbers, as the documentation specifies.
10569 * lisp.h (string_to_number): New decl, replacing ...
10570 (isfloat_string): Remove.
10571 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
10572 (read1): Do not accept +. and -. as integers; this
10573 appears to have been a coding error. Similarly, do not accept
10574 strings like +-1e0 as floating point numbers. Do not report
10575 overflow for integer overflows unless the base is not 10 which
10576 means we have no simple and reliable way to continue.
10577 Break out the floating-point parsing into a new
10578 function string_to_number, so that Fstring_to_number parses
10579 floating point numbers consistently with the Lisp reader.
10580 (digit_to_number): Move here from data.c. Make it static inline.
10581 (E_CHAR, EXP_INT): Remove, replacing with ...
10582 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
10583 (string_to_number): New function, replacing isfloat_string.
10584 This function checks for valid syntax and produces the resulting
10585 Lisp float number too. Rework it so that string-to-number
10586 no longer mishandles examples like "1.0e+". Use strtoumax,
10587 so that overflow for non-base-10 numbers is reported only when
10588 there's no portable and simple way to convert to floating point.
10590 * textprop.c (set_text_properties_1): Rewrite for clarity,
10591 and to avoid GCC warning about integer overflow.
10593 * intervals.h (struct interval): Use EMACS_INT for members
10594 where EMACS_UINT might cause problems. See
10595 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
10596 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
10597 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
10599 (offset_intervals): Tell GCC not to worry about length overflow
10600 when negating a negative length.
10602 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
10603 (overrun_check_free): Likewise.
10605 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
10606 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
10609 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10610 (gnutls_make_error): Rename local to avoid shadowing.
10611 (gnutls_emacs_global_deinit): ifdef out; not used.
10612 (Fgnutls_boot): Use const for pointer to readonly storage.
10613 Comment out unused local. Fix pointer signedness problems.
10615 * lread.c (openp): Don't stuff size_t into an 'int'.
10616 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
10617 about possible signed overflow.
10619 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10620 (GDK_KEY_g): Don't define if already defined.
10621 (xg_prepare_tooltip): Avoid pointer signedness problem.
10622 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
10624 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
10625 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
10627 * xfns.c (Fx_window_property): Simplify a bit,
10628 to make a bit faster and to avoid GCC 4.6.0 warning.
10629 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
10631 * fns.c (internal_equal): Don't assume size_t fits in int.
10633 * alloc.c (compact_small_strings): Tighten assertion a little.
10635 Replace pEd with more-general pI, and fix some printf arg casts.
10636 * lisp.h (pI): New macro, generalizing old pEd macro to other
10637 conversion specifiers. For example, use "...%"pI"d..." rather
10638 than "...%"pEd"...".
10639 (pEd): Remove. All uses replaced with similar uses of pI.
10640 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
10641 * alloc.c (check_pure_size): Don't overflow by converting size to int.
10642 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
10643 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
10644 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
10645 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
10646 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
10648 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
10649 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
10650 * print.c (safe_debug_print, print_object): Likewise.
10651 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
10653 Use pI instead of if-then-else-abort. Use %p to avoid casts,
10654 avoiding the 0 flag, which is not portable.
10655 * process.c (Fmake_network_process): Use pI to avoid cast.
10656 * region-cache.c (pp_cache): Likewise.
10657 * xdisp.c (decode_mode_spec): Likewise.
10658 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
10659 behavior on 64-bit hosts with printf arg.
10660 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
10661 (x_stop_queuing_selection_requests): Likewise.
10662 (x_get_window_property): Don't truncate byte count to an 'int'
10665 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
10666 here, since it parses constructs like leading '-' and spaces,
10667 which are not wanted; and it overflows with large numbers.
10668 Instead, simply match F[0-9]+, which is what is wanted anyway.
10670 * alloc.c: Remove unportable assumptions about struct layout.
10671 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
10672 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
10673 (allocate_vectorlike, make_pure_vector): Use the new macros,
10674 plus offsetof, to remove unportable assumptions about struct layout.
10675 These assumptions hold on all porting targets that I know of, but
10676 they are not guaranteed, they're easy to remove, and removing them
10677 makes further changes easier.
10679 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
10680 This doesn't fix a bug but makes the code clearer.
10681 (string_overrun_cookie): Now const. Use initializers that
10682 don't formally overflow signed char, to avoid warnings.
10683 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
10684 can cause Emacs to crash when string overrun checking is enabled.
10685 (allocate_buffer): Don't assume sizeof (struct buffer) is a
10686 multiple of sizeof (EMACS_INT); it need not be, if
10687 alignof(EMACS_INT) < sizeof (EMACS_INT).
10688 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
10690 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
10692 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
10694 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
10696 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
10697 supposed to be handshaking. (Bug#8556)
10698 Reported by Paul Eggert <eggert@cs.ucla.edu>.
10700 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
10702 * lisp.h (Qdebug): List symbol.
10703 * eval.c (Qdebug): Restore global linkage.
10704 * keyboard.c (debug-on-event): New variable.
10705 (handle_user_signal): Break into debugger when debug-on-event
10706 matches the current signal symbol.
10708 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
10710 * alloc.c (check_sblock, check_string_bytes)
10711 (check_string_free_list): Convert to standard C.
10713 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
10715 * w32.c (emacs_gnutls_push): Fix typo.
10717 2011-04-25 Eli Zaretskii <eliz@gnu.org>
10719 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
10720 "cast to pointer from integer of different size".
10722 Improve doprnt and its use in verror. (Bug#8545)
10723 * doprnt.c (doprnt): Document the set of format control sequences
10724 supported by the function. Use SAFE_ALLOCA instead of always
10727 * eval.c (verror): Don't limit the buffer size at size_max-1, that
10728 is one byte too soon. Don't use xrealloc; instead xfree and
10731 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
10733 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
10736 * gnutls.c: Renamed global_initialized to
10737 gnutls_global_initialized. Added internals for the
10738 :verify-hostname-error, :verify-error, and :verify-flags
10739 parameters of `gnutls-boot' and documented those parameters in the
10740 docstring. Start callback support.
10741 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
10742 unless a fatal error occurred. Call gnutls_alert_send_appropriate
10743 on error. Return error code.
10744 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
10745 (emacs_gnutls_read): Likewise.
10746 (Fgnutls_boot): Return handshake error code.
10747 (emacs_gnutls_handle_error): New function.
10748 (wsaerror_to_errno): Likewise.
10750 * w32.h (emacs_gnutls_pull): Add prototype.
10751 (emacs_gnutls_push): Likewise.
10753 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
10754 (emacs_gnutls_push): Likewise.
10756 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
10758 * process.c (wait_reading_process_output): Check if GnuTLS
10759 buffered some data internally if no FDs are set for TLS
10762 * makefile.w32-in (OBJ2): Add gnutls.$(O).
10763 (LIBS): Link to USER_LIBS.
10764 ($(BLD)/gnutls.$(0)): New target.
10766 2011-04-24 Eli Zaretskii <eliz@gnu.org>
10768 * xdisp.c (handle_single_display_spec): Rename the
10769 display_replaced_before_p argument into display_replaced_p, to
10770 make it consistent with the commentary. Fix typos in the
10773 * textprop.c (syms_of_textprop): Remove dead code.
10774 (copy_text_properties): Delete obsolete commentary about an
10775 interface that was deleted long ago. Fix typos in the description
10778 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
10779 to changes in oldXMenu/XMenu.h from 2011-04-16.
10780 <menu_help_message, prev_menu_help_message>: Constify.
10781 (IT_menu_make_room): menu->help_text is now `const char **';
10784 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
10785 to changes in oldXMenu/XMenu.h from 2011-04-16.
10786 (struct XMenu): Declare `help_text' `const char **'.
10788 * xfaces.c <Qunspecified>: Make extern again.
10790 * syntax.c: Include sys/types.h before including regex.h, as
10793 * doc.c (get_doc_string): Improve the format passed to `error'.
10795 * doprnt.c (doprnt): Improve commentary.
10797 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
10799 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
10802 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
10803 changes in globals.h immediately force recompilation.
10804 (TAGS): Depend on $(CURDIR)/m/intel386.h and
10805 $(CURDIR)/s/ms-w32.h.
10806 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
10808 * character.c (Fchar_direction): Function deleted.
10809 (syms_of_character): Don't defsubr it.
10810 <char-direction-table>: Deleted.
10812 2011-04-23 Eli Zaretskii <eliz@gnu.org>
10814 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
10815 * doprnt.c: Include limits.h.
10816 (SIZE_MAX): New macro.
10817 (doprnt): Return a size_t value. 2nd arg is now size_t.
10818 Many local variables are now size_t instead of int or unsigned.
10819 Improve overflow protection. Support `l' modifier for integer
10820 conversions. Support %l conversion. Don't assume an EMACS_INT
10821 argument for integer conversions and for %c.
10823 * lisp.h (doprnt): Restore prototype.
10825 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
10826 $(SRC)/character.h.
10828 * Makefile.in (base_obj): Add back doprnt.o.
10830 * deps.mk (doprnt.o): Add back prerequisites.
10831 (callint.o): Depend on character.h.
10833 * eval.c (internal_lisp_condition_case): Include the handler
10834 representation in the error message.
10835 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
10836 when breaking from the loop.
10838 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
10840 * callint.c (Fcall_interactively): When displaying error message
10841 about invalid control letter, pass the character's codepoint, not
10842 a pointer to its multibyte form. Improve display of the character
10843 in octal and display also its hex code.
10845 * character.c (char_string): Use %x to display the (unsigned)
10846 codepoint of an invalid character, to avoid displaying a bogus
10849 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
10850 `error', not SYMBOL_NAME itself.
10852 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
10853 character arguments to `error'.
10855 * charset.c (check_iso_charset_parameter): Fix incorrect argument
10856 to `error' in error message about FINAL_CHAR argument. Make sure
10857 FINAL_CHAR is a character, and use %c when it is passed as
10858 argument to `error'.
10860 2011-04-23 Eli Zaretskii <eliz@gnu.org>
10862 * s/ms-w32.h (localtime): Redirect to sys_localtime.
10864 * w32.c: Include <time.h>.
10865 (sys_localtime): New function.
10867 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
10869 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
10871 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
10873 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
10875 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
10876 zombies (Bug#8467).
10878 2011-04-19 Eli Zaretskii <eliz@gnu.org>
10880 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
10881 gl_state.e_property when gl_state.object is Qt.
10883 * insdel.c (make_gap_larger): Remove limitation of buffer size
10886 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
10888 * xdisp.c (lookup_glyphless_char_display)
10889 (produce_glyphless_glyph): Handle cons cell entry in
10890 glyphless-char-display.
10891 (Vglyphless_char_display): Document it.
10893 * term.c (produce_glyphless_glyph): Handle cons cell entry in
10894 glyphless-char-display.
10896 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
10898 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
10900 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
10902 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
10903 definition for no-X builds.
10905 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
10907 Static checks with GCC 4.6.0 and non-default toolkits.
10909 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
10911 * process.c (keyboard_bit_set): Define only if SIGIO.
10912 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
10913 (send_process): Repair possible setjmp clobbering.
10915 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
10917 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
10919 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
10921 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
10922 Define only if needed.
10924 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
10925 by pacifying GCC about it. Maybe it's time to retire it?
10926 * xfaces.c (USG, __TIMEVAL__): Likewise.
10928 * dispextern.h (struct redisplay_interface): Rename param
10929 to avoid shadowing.
10930 * termhooks.h (struct terminal): Likewise.
10931 * xterm.c (xembed_send_message): Likewise.
10933 * insdel.c (make_gap_smaller): Define only if
10934 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
10936 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
10939 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
10940 so that we aren't warned about unused symbols.
10942 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
10944 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
10946 * xfns.c (x_real_positions): Mark locals as initialized.
10948 * xmenu.c (xmenu_show): Don't use uninitialized vars.
10950 * xterm.c: Fix problems found by static analysis with other toolkits.
10951 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
10952 (x_dispatch_event): Declare static if USE_GTK, and
10953 define if USE_GTK || USE_X_TOOLKIT.
10954 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
10955 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
10956 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
10957 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
10959 * xmenu.c (menu_help_callback): Pointer type fixes.
10960 Use const pointers when pointing at readonly data. Avoid pointer
10961 signedness clashes.
10962 (FALSE): Remove unused macro.
10963 (update_frame_menubar): Remove unused decl.
10965 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
10967 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
10968 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
10969 (single_menu_item): Rename local to avoid shadowing.
10971 * keyboard.c (make_lispy_event): Remove unused local var.
10973 * frame.c, frame.h (x_get_resource_string): Bring this back, but
10974 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
10976 * bitmaps: Change bitmaps from unsigned char back to the X11
10977 compatible char. Avoid the old compiler warnings about
10978 out-of-range initializers by using, for example, '\xab' rather
10981 * xgselect.c (xgselect_initialize): Check vs interface
10982 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
10984 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
10986 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
10987 to read-only memory.
10989 * fns.c (vector): Remove; this old hack is no longer needed.
10991 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
10993 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
10995 * xrdb.c (x_load_resources): Omit unused local.
10997 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
10998 (x_window): Rename locals to avoid shadowing.
10999 (USG): Use the kludged USG macro, to pacify gcc.
11001 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
11002 (x_term_init): Remove local to avoid shadowing.
11004 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
11006 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
11007 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
11009 2011-04-16 Eli Zaretskii <eliz@gnu.org>
11011 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
11013 Fix regex.c, syntax.c and friends for buffers > 2GB.
11014 * syntax.h (struct gl_state_s): Declare character position members
11017 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
11019 * textprop.c (verify_interval_modification, interval_of):
11020 Declare arguments EMACS_INT.
11022 * intervals.c (adjust_intervals_for_insertion): Declare arguments
11025 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
11027 * indent.c (Fvertical_motion): Local variable it_start is now
11030 * regex.c (re_match, re_match_2, re_match_2_internal)
11031 (bcmp_translate, regcomp, regexec, print_double_string)
11032 (group_in_compile_stack, re_search, re_search_2, regex_compile)
11033 (re_compile_pattern, re_exec): Declare arguments and local
11034 variables `size_t' and `ssize_t' and return values `regoff_t', as
11036 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
11037 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
11038 <compile_stack_type>: `size' and `avail' are now `size_t'.
11040 * regex.h <regoff_t>: Use ssize_t, not int.
11041 (re_search, re_search_2, re_match, re_match_2): Arguments that
11042 specify buffer/string position and length are now ssize_t and
11043 size_t. Return type is regoff_t.
11045 2011-04-16 Ben Key <bkey76@gmail.com>
11047 * nsfont.m: Fixed bugs in ns_get_family and
11048 ns_descriptor_to_entity that were caused by using free to
11049 deallocate memory blocks that were allocated by xmalloc (via
11050 xstrdup). This caused Emacs to crash when compiled with
11051 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
11052 --enable-checking=xmallocoverrun). xfree is now used to
11053 deallocate these memory blocks.
11055 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
11057 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
11059 emacs_write: Accept and return EMACS_INT for sizes.
11060 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
11062 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
11063 Accept and return EMACS_INT.
11064 (emacs_gnutls_write): Return the number of bytes written on
11066 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
11067 (emacs_read, emacs_write): Remove check for negative size, as the
11068 Emacs source code has been audited now.
11069 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
11070 (emacs_read, emacs_write): Use it.
11071 * process.c (send_process): Adjust to the new signatures of
11072 emacs_write and emacs_gnutls_write. Do not attempt to store
11073 a byte offset into an 'int'; it might overflow.
11074 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
11076 * sound.c: Don't assume sizes fit in 'int'.
11077 (struct sound_device.period_size, alsa_period_size):
11078 Return EMACS_INT, not int.
11079 (struct sound_device.write, vox_write, alsa_write):
11080 Accept EMACS_INT, not int.
11081 (wav_play, au_play): Use EMACS_INT to store sizes and to
11082 record read return values.
11084 2011-04-15 Ben Key <bkey76@gmail.com>
11086 * keyboard.c (Qundefined): Don't declare static since it is used
11088 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
11089 static since they are used in nsfont.m.
11091 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
11093 * process.c (Qprocessp): Don't declare static.
11094 * lisp.h (Qprocessp): Declare again.
11096 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
11098 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
11100 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
11102 Improve C-level modularity by making more things 'static'.
11104 Don't publish debugger-only interfaces to other modules.
11105 * lisp.h (safe_debug_print, debug_output_compilation_hack):
11106 (verify_bytepos, count_markers): Move decls to the only modules
11108 * region-cache.h (pp_cache): Likewise.
11109 * window.h (check_all_windows): Likewise.
11110 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
11112 * sysdep.c (croak): Now static, if
11113 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
11114 * syssignal.h (croak): Declare only if not static.
11116 * alloc.c (refill_memory_reserve): Now static if
11117 !defined REL_ALLOC || defined SYSTEM_MALLOC.
11118 * lisp.h (refill_memory_reserve): Declare only if not static.
11120 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
11121 Define only if USE_LUCID.
11123 * xrdb.c (x_customization_string, x_rm_string): Now static.
11125 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
11126 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
11128 * xdisp.c (draw_row_with_mouse_face): Now static.
11129 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
11131 * window.h (check_all_windows): Mark externally visible.
11133 * window.c (window_deletion_count): Now static.
11135 * undo.c: Make symbols static if they're not exported.
11136 (last_undo_buffer, last_boundary_position, pending_boundary):
11139 * textprop.c (interval_insert_behind_hooks): Now static.
11140 (interval_insert_in_front_hooks): Likewise.
11142 * term.c: Make symbols static if they're not exported.
11143 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
11144 (max_frame_lines, tty_set_terminal_modes):
11145 (tty_reset_terminal_modes, tty_turn_off_highlight):
11146 (get_tty_terminal): Now static.
11147 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
11148 * termhooks.h (term_mouse_moveto): Do not declare if
11149 HAVE_WINDOW_SYSTEM.
11150 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
11151 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
11153 * sysdep.c: Make symbols static if they're not exported.
11154 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
11156 (sigprocmask_set, full_mask): Remove; unused.
11157 (wait_debugging): Mark as visible.
11158 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
11159 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
11161 * syntax.c (syntax_temp): Define only if !__GNUC__.
11163 * sound.c (current_sound_device, current_sound): Now static.
11165 * search.c (searchbufs, searchbuf_head): Now static.
11167 * scroll.c (scroll_cost): Remove; unused.
11168 * dispextern.h (scroll_cost): Remove decl.
11170 * region-cache.h (pp_cache): Mark as externally visible.
11172 * process.c: Make symbols static if they're not exported.
11173 (process_tick, update_tick, create_process, chan_process):
11174 (Vprocess_alist, proc_buffered_char, datagram_access):
11175 (fd_callback_data, send_process_frame, process_sent_to): Now static.
11176 (deactivate_process): Mark defn as static, as well as decl.
11177 * lisp.h (create_process): Remove decl.
11178 * process.h (chan_process, Vprocess_alist): Remove decls.
11180 * print.c: Make symbols static if they're not exported.
11181 (print_depth, new_backquote_output, being_printed, print_buffer):
11182 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
11183 (print_interval, print_number_index, initial_stderr_stream):
11185 * lisp.h (Fprinc): Remove decl.
11186 (debug_output_compilation_hack): Mark as externally visible.
11188 * sysdep.c (croak): Move decl from here to syssignal.h.
11189 * syssignal.h (croak): Put it here, so the API can be checked when
11190 'croak' is called from dissociate_if_controlling_tty.
11192 * minibuf.c: Make symbols static if they're not exported.
11193 (minibuf_save_list, choose_minibuf_frame): Now static.
11194 * lisp.h (choose_minibuf_frame): Remove decl.
11196 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
11198 * lread.c: Make symbols static if they're not exported.
11199 (read_objects, initial_obarray, oblookup_last_bucket_number):
11201 (make_symbol): Remove; unused.
11202 * lisp.h (initial_obarray, make_symbol): Remove decls.
11204 * keyboard.c: Make symbols static if they're not exported.
11205 (single_kboard, recent_keys_index, total_keys, recent_keys):
11206 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
11207 (this_single_command_key_start, echoing, last_auto_save):
11208 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
11209 (command_loop, echo_now, keyboard_init_hook, help_char_p):
11210 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
11211 (Vlispy_mouse_stem, double_click_count):
11213 (force_auto_save_soon): Define only if SIGDANGER.
11214 (ignore_mouse_drag_p): Now static if
11215 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
11216 (print_help): Remove; unused.
11217 (stop_character, last_timer_event): Mark as externally visible.
11218 * keyboard.h (ignore_mouse_drag_p): Declare only if
11219 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
11220 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
11221 * lisp.h (echoing): Remove decl.
11222 (force_auto_save_soon): Declare only if SIGDANGER.
11223 * xdisp.c (redisplay_window): Simplify code, to make it more
11224 obvious that ignore_mouse_drag_p is not accessed if !defined
11225 USE_GTK && !defined HAVE_NS.
11227 * intervals.c: Make symbols static if they're not exported.
11228 (merge_properties_sticky, merge_interval_right, delete_interval):
11230 * intervals.h (merge_interval_right, delete_interval): Remove decls.
11232 * insdel.c: Make symbols static if they're not exported.
11233 However, leave prepare_to_modify_buffer alone. It's never
11234 called from outside this function, but that appears to be a bug.
11235 (combine_after_change_list, combine_after_change_buffer):
11236 (adjust_after_replace, signal_before_change): Now static.
11237 (adjust_after_replace_noundo): Remove; unused.
11238 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
11239 (signal_before_change): Remove decls.
11241 * indent.c (val_compute_motion, val_vmotion): Now static.
11243 * image.c: Make symbols static if they're not exported.
11244 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
11246 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
11247 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
11249 * fringe.c (standard_bitmaps): Now static.
11250 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
11252 * frame.c: Make symbols static if they're not exported.
11253 (x_report_frame_params, make_terminal_frame): Now static.
11254 (get_frame_param): Now static, unless HAVE_NS.
11255 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
11256 (x_get_resource_string): Remove; not used.
11257 * frame.h (make_terminal_frame, x_report_frame_params):
11258 (x_get_resource_string); Remove decls.
11259 (x_fullscreen_adjust): Declare only if WINDOWSNT.
11260 * lisp.h (get_frame_param): Declare only if HAVE_NS.
11262 * font.c, fontset.c: Make symbols static if they're not exported.
11263 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
11264 (FACE_SUITABLE_FOR_CHAR_P): Use it.
11265 * font.c (font_close_object): Now static.
11266 * font.h (font_close_object): Remove.
11267 * fontset.c (FONTSET_OBJLIST): Remove.
11268 (free_realized_fontset) #if-0 the body, which does nothing.
11269 (face_suitable_for_char_p): #if-0, as it's never called.
11270 * fontset.h (face_suitable_for_char_p): Remove decl.
11271 * xfaces.c (face_at_string_position):
11272 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
11273 since 0 is always ASCII.
11275 * fns.c (weak_hash_tables): Now static.
11277 * fileio.c: Make symbols static if they're not exported.
11278 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
11279 (Vwrite_region_annotation_buffers): Now static.
11281 * eval.c: Make symbols static if they're not exported.
11282 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
11283 * lisp.h (backtrace_list): Remove decl.
11285 * emacs.c: Make symbols static if they're not exported.
11286 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
11287 (fatal_error_code, fatal_error_signal_hook, standard_args):
11289 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
11290 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
11291 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
11292 * lisp.h (fatal_error_signal_hook): Remove decl.
11293 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
11295 * editfns.c: Move a (normally-unused) function to its only use.
11296 * editfns.c, lisp.h (get_operating_system_release): Remove.
11297 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
11298 worth the hassle of breaking this out.
11300 * xterm.c: Make symbols static if they're not exported.
11301 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
11302 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
11303 (x_destroy_window, x_delete_display):
11305 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
11306 (x_mouse_leave): Remove; unused.
11307 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
11308 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
11309 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
11311 (x_mouse_leave): Declare only if WINDOWSNT.
11312 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
11313 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
11316 * ftxfont.c: Make symbols static if they're not exported.
11317 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
11319 * font.h (ftxfont_driver): Likewise.
11321 * xfns.c: Make symbols static if they're not exported.
11322 (x_last_font_name, x_display_info_for_name):
11323 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
11324 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
11325 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
11326 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
11327 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
11328 (last_show_tip_args): Now static.
11329 (xic_defaut_fontset, xic_create_fontsetname): Define only if
11330 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
11331 (x_screen_planes): Remove; unused.
11332 * dispextern.h (x_screen_planes): Remove decl.
11334 * dispnew.c: Make symbols static if they're not exported.
11335 * dispextern.h (redraw_garbaged_frames, scrolling):
11336 (increment_row_positions): Remove.
11337 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
11338 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
11340 (redraw_garbaged_frames): Remove; unused.
11342 * xfaces.c: Make symbols static if they're not exported.
11343 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
11345 * xterm.h (defined_color): Remove decls.
11346 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
11347 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
11348 (menu_face_changed_default, defined_color, free_realized_face):
11349 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
11350 (ascii_face_of_lisp_face): Remove; unused.
11352 * xdisp.c: Make symbols static if they're not exported.
11353 * dispextern.h (scratch_glyph_row, window_box_edges):
11354 (glyph_to_pixel_coords, set_cursor_from_row):
11355 (get_next_display_element, set_iterator_to_next):
11356 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
11357 (show_mouse_face): Remove decls
11358 * frame.h (message_buf_print): Likewise.
11359 * lisp.h (pop_message, set_message, check_point_in_composition):
11361 * xterm.h (set_vertical_scroll_bar): Likewise.
11362 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
11363 (message_buf_print, scratch_glyph_row, displayed_buffer):
11364 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
11365 (get_next_display_element, show_mouse_face, window_box_edges):
11366 (frame_to_window_pixel_xy, check_point_in_composition):
11367 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
11368 (glyph_to_pixel_coords): Remove; unused.
11370 * dired.c (file_name_completion): Now static.
11372 * dbusbind.c (xd_in_read_queued_messages): Now static.
11374 * lisp.h (circular_list_error, FOREACH): Remove; unused.
11375 * data.c (circular_list_error): Remove.
11377 * commands.h (last_point_position, last_point_position_buffer):
11378 (last_point_position_window): Remove decls.
11379 * keyboard.c: Make these variables static.
11381 * coding.h (coding, code_convert_region, encode_coding_gap):
11383 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
11384 (iso_code_class, detect_coding, code_convert_region): Now static.
11385 (encode_coding_gap): Remove; unused.
11387 * chartab.c (chartab_chars, chartab_bits): Now static.
11389 * charset.h (charset_iso_8859_1): Remove decl.
11390 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
11393 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
11394 * ccl.c (Vccl_program_table): Now static.
11395 (check_ccl_update): Remove; unused.
11397 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
11398 * category.h: ... from here.
11399 * category.c (check_category_table, set_category_set): Now static.
11401 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
11402 * lisp.h: Remove these decls.
11404 * buffer.c (buffer_count): Remove unused var.
11406 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
11407 so that it's not optimized away.
11408 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
11409 * dispextern.h (bidi_dump_cached_states): Remove, since it's
11410 exported only to the debugger.
11412 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
11413 * atimer.h (run_all_atimers): Remove; not exported.
11415 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
11416 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
11417 was inaccessible from Lisp.
11418 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
11419 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
11421 alloc.c: Import and export fewer symbols, and remove unused items.
11422 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
11424 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
11425 it's not optimized away by whole-program optimization.
11426 (message_enable_multibyte, free_misc): Remove.
11427 (catchlist, handlerlist, mark_backtrace):
11428 Declare only if BYTE_MARK_STACK.
11429 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
11430 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
11431 (message_enable_multibyte): Remove decl.
11432 (free_misc, interval_free_list, float_block, float_block_index):
11433 (n_float_blocks, float_free_list, cons_block, cons_block_index):
11434 (cons_free_list, last_marked_index):
11436 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
11437 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
11438 (mark_backtrace): Define only if BYTE_MARK_STACK.
11439 * xdisp.c (message_enable_multibyte): Now static.
11441 Declare Lisp_Object Q* variables to be 'static' if not exported.
11442 This makes it easier for human readers (and static analyzers)
11443 to see whether these variables are used from other modules.
11444 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
11445 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
11446 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
11447 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
11448 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
11449 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
11450 * xmenu.c, xselect.c:
11451 Declare Q* vars static if they are not used in other modules.
11452 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
11453 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
11454 Remove decls of unexported vars.
11455 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
11457 * lisp.h (DEFINE_FUNC): Make sname 'static'.
11459 Make Emacs functions such as Fatom 'static' by default.
11460 This makes it easier for human readers (and static analyzers)
11461 to see whether these functions can be called from other modules.
11462 DEFUN now defines a static function. To make the function external
11463 so that it can be used in other C modules, use the new macro DEFUE.
11464 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
11465 (Finit_image_library):
11466 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
11467 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
11468 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
11469 Remove decls, since these functions are now static.
11470 (Funintern, Fget_internal_run_time): New decls, since these functions
11471 were already external.
11473 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
11474 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
11475 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
11476 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
11477 * keyboard.c, keymap.c, lread.c:
11478 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
11479 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
11480 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
11481 Mark functions with DEFUE instead of DEFUN,
11482 if they are used in other modules.
11483 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
11484 decls for now-static functions.
11485 * buffer.h (Fdelete_overlay): Remove decl.
11486 * callproc.c (Fgetenv_internal): Mark as internal.
11487 * composite.c (Fremove_list_of_text_properties): Remove decl.
11488 (Fcomposition_get_gstring): New forward static decl.
11489 * composite.h (Fcomposite_get_gstring): Remove decl.
11490 * dired.c (Ffile_attributes): New forward static decl.
11491 * doc.c (Fdocumntation_property): New forward static decl.
11492 * eval.c (Ffetch_bytecode): New forward static decl.
11493 (Funintern): Remove extern decl; now in .h file where it belongs.
11494 * fileio.c (Fmake_symbolic_link): New forward static decl.
11495 * image.c (Finit_image_library): New forward static decl.
11496 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
11497 * intervals.h (Fprevious_property_change):
11498 (Fremove_list_of_text_properties): Remove decls.
11499 * keyboard.c (Fthis_command_keys): Remove decl.
11500 (Fcommand_execute): New forward static decl.
11501 * keymap.c (Flookup_key): New forward static decl.
11502 (Fcopy_keymap): Now static.
11503 * keymap.h (Flookup_key): Remove decl.
11504 * process.c (Fget_process): New forward static decl.
11505 (Fprocess_datagram_address): Mark as internal.
11506 * syntax.c (Fsyntax_table_p): New forward static decl.
11507 (skip_chars): Remove duplicate decl.
11508 * textprop.c (Fprevious_property_change): New forward static decl.
11509 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
11511 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
11512 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
11514 * editfns.c (Fformat): Remove unreachable code.
11516 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
11518 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
11521 2011-04-13 Eli Zaretskii <eliz@gnu.org>
11523 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
11524 when at ZV. (Bug#8487)
11526 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
11528 * charset.c (Fclear_charset_maps): Use xfree instead of free.
11530 * keyboard.c (parse_tool_bar_item): Likewise.
11531 * sound.c (sound_cleanup, alsa_close): Likewise.
11532 * termcap.c (tgetent): Likewise.
11533 * xfns.c (x_default_font_parameter): Likewise.
11534 * xsettings.c (read_and_apply_settings): Likewise.
11536 * alloc.c (overrun_check_malloc, overrun_check_realloc)
11537 (overrun_check_free): Protoize.
11539 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
11541 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
11542 since callers should never pass a negative size.
11543 Change the signature to match that of plain 'read' and 'write'; see
11544 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
11545 * lisp.h: Update prototypes of emacs_write and emacs_read.
11547 2011-04-11 Eli Zaretskii <eliz@gnu.org>
11549 * xdisp.c (redisplay_window): Don't try to determine the character
11550 position of the scroll margin if the window start point w->startp
11551 is outside the buffer's accessible region. (Bug#8468)
11553 2011-04-10 Eli Zaretskii <eliz@gnu.org>
11555 Fix write-region and its subroutines for buffers > 2GB.
11556 * fileio.c (a_write, e_write): Modify declaration of arguments and
11557 local variables to support buffers larger than 2GB.
11558 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
11560 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
11561 argument, local variables, and return value.
11563 * lisp.h: Update prototypes of emacs_write and emacs_read.
11565 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
11567 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
11569 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
11571 Fix more problems found by GCC 4.6.0's static checks.
11573 * xdisp.c (vmessage): Use a better test for character truncation.
11575 * charset.c (load_charset_map): <, not <=, for optimization,
11576 and to avoid potential problems with integer overflow.
11577 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
11578 * casetab.c (set_identity, shuffle): Likewise.
11579 * editfns.c (Fformat): Likewise.
11580 * syntax.c (skip_chars): Likewise.
11582 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
11583 This also lets GCC 4.6.0 generate slightly better loop code.
11585 * callint.c (Fcall_interactively): <, not <=, for optimization.
11586 (Fcall_interactively): Count the number of arguments produced,
11587 not the number of arguments given. This is simpler and lets GCC
11588 4.6.0 generate slightly better code.
11590 * ftfont.c: Distingish more carefully between FcChar8 and char.
11591 The previous code passed unsigned char * to a functions like
11592 strlen and xstrcasecmp that expect char *, which does not
11593 conform to the C standard.
11594 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
11595 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
11596 char * when the C standard requires it.
11598 * keyboard.c (read_char): Remove unused var.
11600 * eval.c: Port to Windows vsnprintf (Bug#8435).
11601 Include <limits.h>.
11602 (SIZE_MAX): Define if the headers do not.
11603 (verror): Do not give up if vsnprintf returns a negative count.
11604 Instead, grow the buffer. This ports to Windows vsnprintf, which
11605 does not conform to C99. Problem reported by Eli Zaretskii.
11606 Also, simplify the allocation scheme, by avoiding the need for
11607 calling realloc, and removing the ALLOCATED variable.
11609 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
11611 Remove invocations of doprnt, as Emacs now uses vsnprintf.
11612 But keep the doprint source code for now, as we might revamp it
11613 and use it again (Bug#8435).
11614 * lisp.h (doprnt): Remove.
11615 * Makefile.in (base_obj): Remove doprnt.o.
11616 * deps.mk (doprnt.o): Remove.
11618 error: Print 32- and 64-bit integers portably (Bug#8435).
11619 Without this change, on typical 64-bit hosts error ("...%d...", N)
11620 was used to print both 32- and 64-bit integers N, which relied on
11621 undefined behavior.
11622 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
11623 * lisp.h (error, verror): Mark as printf-like functions.
11624 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
11625 Report overflow in size calculations when allocating printf buffer.
11626 Do not truncate output string at its first null byte.
11627 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
11628 Truncate the output at a character boundary, since vsnprintf does not
11630 * charset.c (check_iso_charset_parameter): Convert internal
11631 character to string before calling 'error', since %c now has the
11633 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
11634 overflow when computing char to be passed to 'error'. Do not
11635 pass Lisp_Object to 'error'; pass the integer instead.
11636 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
11637 formatted with plain %d.
11639 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
11641 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
11643 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
11645 * xterm.c (x_catch_errors): Remove duplicate declaration.
11647 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
11649 * xdisp.c, lisp.h (message_nolog): Remove; unused.
11651 2011-04-10 Jim Meyering <meyering@redhat.com>
11653 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
11654 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
11655 return ssize_t not "int", and use size_t as the buffer length.
11656 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
11657 * gnutls.h: Update declarations.
11658 * process.c (read_process_output): Use ssize_t, to match.
11659 (send_process): Likewise.
11661 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
11663 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
11665 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
11667 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
11668 Use unsigned char, to match FcChar8 type definition.
11670 * xterm.c (handle_one_xevent):
11671 * xmenu.c (create_and_show_popup_menu):
11672 * xselect.c (x_decline_selection_request)
11673 (x_reply_selection_request): Avoid type-punned deref of X events.
11675 2011-04-09 Eli Zaretskii <eliz@gnu.org>
11677 Fix some uses of `int' instead of EMACS_INT.
11678 * search.c (string_match_1, fast_string_match)
11679 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
11680 (scan_buffer, find_next_newline_no_quit)
11681 (find_before_next_newline, search_command, Freplace_match)
11682 (Fmatch_data): Make some `int' variables be EMACS_INT.
11684 * xdisp.c (display_count_lines): 3rd argument and return value now
11685 EMACS_INT. All callers changed.
11686 (pint2hrstr): Last argument is now EMACS_INT.
11688 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
11689 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
11690 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
11691 (decode_coding_utf_16, decode_coding_emacs_mule)
11692 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
11693 (decode_coding_ccl, decode_coding_charset)
11694 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
11695 (decode_coding_iso_2022, decode_coding_emacs_mule)
11696 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
11697 <char_offset, last_offset>: Declare EMACS_INT.
11698 (encode_coding_utf_8, encode_coding_utf_16)
11699 (encode_coding_emacs_mule, encode_invocation_designation)
11700 (encode_designation_at_bol, encode_coding_iso_2022)
11701 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
11702 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
11704 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
11705 (encode_invocation_designation): Last argument P_NCHARS is now
11707 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
11708 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
11710 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
11713 * ccl.c (Fccl_execute_on_string): Declare some variables
11716 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
11718 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
11720 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
11722 * process.c (Fformat_network_address): Doc fix.
11724 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
11726 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
11728 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
11730 * keyboard.c (read_char): Call Lisp function help-form-show,
11731 instead of using internal_with_output_to_temp_buffer.
11732 (Qhelp_form_show): New var.
11733 (syms_of_keyboard): Use DEFSYM macro.
11735 * print.c (internal_with_output_to_temp_buffer): Function deleted.
11737 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
11739 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
11741 * process.c (Flist_processes): Remove to Lisp.
11742 (list_processes_1): Delete.
11744 2011-04-06 Eli Zaretskii <eliz@gnu.org>
11746 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
11748 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
11750 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
11752 Fix more problems found by GCC 4.6.0's static checks.
11754 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
11756 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
11758 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
11760 * xdisp.c (vmessage): Mark as a printf-like function.
11762 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
11764 * sound.c (sound_warning): Don't crash if arg contains a printf format.
11766 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
11767 printf-like functions.
11768 (tiff_load): Add casts to remove these marks before passing them
11769 to system-supplied API.
11771 * eval.c (Fsignal): Remove excess argument to 'fatal'.
11773 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
11774 This avoids several warnings with gcc -Wstrict-overflow.
11775 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
11776 directly, rather than having caller test rule sign. This avoids
11777 some unnecessary tests.
11778 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
11779 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
11780 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
11782 * xfont.c (xfont_text_extents): Remove var that was set but not used.
11783 (xfont_open): Avoid unnecessary tests.
11785 * composite.c (composition_gstring_put_cache): Use unsigned integer.
11787 * composite.h, composite.c (composition_gstring_put_cache):
11788 Use EMACS_INT, not int, for length.
11790 * composite.h (COMPOSITION_DECODE_REFS): New macro,
11791 breaking out part of COMPOSITION_DECODE_RULE.
11792 (COMPOSITION_DECODE_RULE): Use it.
11793 * composite.c (get_composition_id): Remove unused local vars,
11794 by using the new macro.
11796 * textprop.c (set_text_properties_1): Change while to do-while,
11797 since the condition is always true at first.
11799 * intervals.c (graft_intervals_into_buffer): Mark var as used.
11800 (interval_deletion_adjustment): Return unsigned value.
11803 * process.c (list_processes_1, create_pty, read_process_output):
11804 (exec_sentinel): Remove vars that were set but not used.
11805 (create_pty): Remove unnecessary "volatile"s.
11806 (Fnetwork_interface_info): Avoid possibility of int overflow.
11807 (read_process_output): Do adaptive read buffering even if carryover.
11808 (read_process_output): Simplify nbytes computation if buffered.
11810 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
11812 * syntax.c (scan_words): Remove var that was set but not used.
11813 (update_syntax_table): Use unsigned instead of int.
11815 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
11816 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
11817 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
11819 * print.c (print_error_message): Avoid int overflow.
11821 * font.c (font_list_entities): Redo for clarity,
11822 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
11824 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
11825 (font_score): Avoid potential overflow in diff calculation.
11827 * fns.c (substring_both): Remove var that is set but not used.
11828 (sxhash): Redo loop for clarity and to avoid wraparound warning.
11830 * eval.c (funcall_lambda): Rename local to avoid shadowing.
11832 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
11833 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
11834 can always succeed if overflow has undefined behavior.
11836 * search.c (boyer_moore, wordify): Remove vars set but not used.
11837 (wordify): Omit three unnecessary tests.
11839 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
11840 All callers changed. This avoids the need for an unused var.
11842 * casefiddle.c (casify_region): Remove var that is set but not used.
11844 * dired.c (file_name_completion): Remove var that is set but not used.
11846 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
11848 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
11849 (Finsert_file_contents): Remove unnecessary code checking fd.
11851 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
11852 Check for integer overflow on size calculations.
11854 * buffer.c (Fprevious_overlay_change): Remove var that is set
11857 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
11858 Remove vars that are set but not used.
11859 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
11860 (timer_check_2): Mark vars as initialized.
11862 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
11864 * image.c (lookup_image): Remove var that is set but not used.
11865 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
11867 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
11868 that are set but not used.
11870 * xfns.c (make_invisible_cursor): Don't return garbage
11871 if XCreateBitmapFromData fails (Bug#8410).
11873 * xselect.c (x_get_local_selection, x_handle_property_notify):
11874 Remove vars that are set but not used.
11876 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
11877 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
11879 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
11880 Remove var that is set but not used.
11881 (scroll_bar_windows_size): Now size_t, not int.
11882 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
11883 Check for overflow.
11885 * xfaces.c (realize_named_face): Remove vars that are set but not used.
11886 (map_tty_color) [!defined MSDOS]: Likewise.
11888 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
11890 * coding.c: Remove vars that are set but not used.
11891 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
11892 All callers changed.
11893 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
11894 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
11895 (decode_coding_charset): Remove vars that are set but not used.
11897 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
11898 that is set but not used.
11900 * print.c (print_object): Remove var that is set but not used.
11902 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
11903 The gnulib version avoids calling malloc in the usual case,
11904 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
11905 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
11906 * filelock.c (current_lock_owner): Likewise.
11907 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
11908 * sysdep.c: Include allocator.h, careadlinkat.h.
11909 (emacs_no_realloc_allocator): New static constant.
11910 (emacs_readlink): New function.
11911 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
11912 ../lib/careadlinkat.h.
11914 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
11916 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
11917 first non-nil return value).
11919 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
11921 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
11922 if not defined (Bug#8403).
11924 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
11926 * xdisp.c (display_count_lines): Remove parameter `start',
11927 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11928 (get_char_face_and_encoding): Remove parameter `multibyte_p',
11929 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11930 (fill_stretch_glyph_string): Remove parameters `row' and `area',
11931 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
11932 and thereabouts. All callers changed.
11933 (get_per_char_metric): Remove parameter `f', unused since
11934 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11936 2011-04-02 Jim Meyering <meyering@redhat.com>
11938 do not dereference NULL upon failed strdup
11939 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
11940 (ns_get_family): Likewise.
11942 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
11944 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
11946 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
11948 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
11951 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
11953 Add lexical binding.
11955 * window.c (Ftemp_output_buffer_show): New fun.
11956 (Fsave_window_excursion):
11957 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
11959 * lread.c (lisp_file_lexically_bound_p): New function.
11960 (Fload): Bind Qlexical_binding.
11961 (readevalloop): Remove `evalfun' arg.
11962 Bind Qinternal_interpreter_environment.
11963 (Feval_buffer): Bind Qlexical_binding.
11964 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
11966 (syms_of_lread): Declare `lexical-binding'.
11968 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
11970 * keyboard.c (eval_dyn): New fun.
11971 (menu_item_eval_property): Use it.
11973 * image.c (parse_image_spec): Use Ffunctionp.
11975 * fns.c (concat, mapcar1): Accept byte-code-functions.
11977 * eval.c (Fsetq): Handle lexical vars.
11978 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
11979 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
11980 (FletX, Flet): Obey lexical binding.
11981 (Fcommandp): Handle closures.
11982 (Feval): New `lexical' arg.
11983 (eval_sub): New function extracted from Feval. Use it almost
11984 everywhere where Feval was used. Look up vars in lexical env.
11986 (Ffunctionp): Move from subr.el.
11987 (Ffuncall): Handle closures.
11988 (apply_lambda): Remove `eval_flags'.
11989 (funcall_lambda): Handle closures and new byte-code-functions.
11990 (Fspecial_variable_p): New function.
11991 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
11992 but without exporting it to Lisp.
11994 * doc.c (Fdocumentation, store_function_docstring):
11995 * data.c (Finteractive_form): Handle closures.
11997 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
12000 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
12002 (exec_byte_code): New function extracted from Fbyte_code to handle new
12003 calling convention for byte-code-functions. Add new byte-codes.
12005 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
12007 * alloc.c (Fmake_symbol): Init new `declared_special' field.
12009 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
12011 * xdisp.c (redisplay_internal): Fix prototype.
12013 2011-03-31 Eli Zaretskii <eliz@gnu.org>
12015 * xdisp.c (SCROLL_LIMIT): New macro.
12016 (try_scrolling): Use it when setting scroll_limit.
12017 Limit scrolling to 100 screen lines.
12018 (redisplay_window): Even when falling back on "recentering",
12019 position point in the window according to scroll-conservatively,
12020 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
12022 (try_scrolling): When point is above the window, allow searching
12023 as far as scroll_max, or one screenful, to compute vertical
12024 distance from PT to the scroll margin position. This prevents
12025 try_scrolling from unnecessarily failing when
12026 scroll-conservatively is set to a value slightly larger than the
12027 window height. Clean up the case of PT below the margin at bottom
12028 of window: scroll_max can no longer be INT_MAX. When aggressive
12029 scrolling is in use, don't let point enter the opposite scroll
12030 margin as result of the scroll.
12031 (syms_of_xdisp) <scroll-conservatively>: Document the
12032 threshold of 100 lines for never-recentering scrolling.
12034 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
12036 * dispextern.h (move_it_by_lines):
12037 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
12038 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
12039 (message_log_check_duplicate): Remove parameters `prev_bol' and
12040 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12041 (redisplay_internal): Remove parameter `preserve_echo_area',
12042 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
12044 * indent.c (Fvertical_motion):
12045 * window.c (window_scroll_pixel_based, Frecenter):
12046 Don't pass `need_y_p' to `move_it_by_lines'.
12048 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
12050 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
12051 steal a few bits to be more compact.
12052 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
12053 Remove unneeded casts.
12055 * bytecode.c (Fbyte_code): CAR and CDR can GC.
12057 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
12059 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
12060 binding" message (bug#7967).
12062 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
12064 Fix more problems found by GCC 4.6.0's static checks.
12066 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
12067 Remove unused local var.
12069 * editfns.c (Fmessage_box): Remove unused local var.
12071 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
12072 (note_mode_line_or_margin_highlight, note_mouse_highlight):
12073 Omit unused local vars.
12074 * window.c (shrink_windows): Omit unused local var.
12075 * menu.c (digest_single_submenu): Omit unused local var.
12076 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
12077 Omit unused local var.
12079 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
12080 Don't assume string length fits in int.
12081 (keyremap_step, read_key_sequence): Use size_t for sizes.
12082 (read_key_sequence): Don't check last_real_key_start redundantly.
12084 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
12085 instead of alloca (Bug#8344).
12087 * eval.c (Fbacktrace): Don't assume nargs fits in int.
12088 (Fbacktrace_frame): Don't assume nframes fits in int.
12090 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
12092 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
12095 * term.c (produce_glyphless_glyph): Remove unnecessary test.
12097 * cm.c (calccost): Turn while-do into do-while, for clarity.
12099 * keyboard.c (syms_of_keyboard): Use the same style as later
12100 in this function when indexing through an array. This also
12101 works around GCC bug 48267.
12103 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
12105 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
12107 * chartab.c (sub_char_table_ref_and_range): Redo for slight
12108 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
12110 * keyboard.c, keyboard.h (num_input_events): Now size_t.
12111 This avoids undefined behavior on integer overflow, and is a bit
12112 more convenient anyway since it is compared to a size_t variable.
12114 Variadic C functions now count arguments with size_t, not int.
12115 This avoids an unnecessary limitation on 64-bit machines, which
12116 caused (substring ...) to crash on large vectors (Bug#8344).
12117 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
12118 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
12119 All variadic functions and their callers changed accordingly.
12120 (struct gcpro.nvars): Now size_t, not int. All uses changed.
12121 * data.c (arith_driver, float_arith_driver): Likewise.
12122 * editfns.c (general_insert_function): Likewise.
12123 * eval.c (struct backtrace.nargs, interactive_p)
12124 (internal_condition_case_n, run_hook_with_args, apply_lambda)
12125 (funcall_lambda, mark_backtrace): Likewise.
12126 * fns.c (concat): Likewise.
12127 * frame.c (x_set_frame_parameters): Likewise.
12128 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
12129 0 if not found, not -1. All callers changed.
12131 * alloc.c (garbage_collect): Don't assume stack size fits in int.
12132 (stack_copy_size): Now size_t, not int.
12133 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
12135 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
12137 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
12138 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12139 All callers changed.
12141 * lisp.h (multibyte_char_to_unibyte):
12142 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
12143 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12144 * character.h (CHAR_TO_BYTE8):
12145 * cmds.c (internal_self_insert):
12146 * editfns.c (general_insert_function):
12147 * keymap.c (push_key_description):
12148 * search.c (Freplace_match):
12149 * xdisp.c (message_dolog, set_message_1): All callers changed.
12151 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
12153 * keyboard.c (safe_run_hook_funcall): New function.
12154 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
12155 don't set the hook to nil, but remove the offending function instead.
12156 (Qcommand_hook_internal): Remove, unused.
12157 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
12158 Vcommand_hook_internal.
12160 * eval.c (enum run_hooks_condition): Remove.
12161 (funcall_nil, funcall_not): New functions.
12162 (run_hook_with_args): Call each function through a `funcall' argument.
12163 Remove `cond' argument, now redundant.
12164 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
12165 (Frun_hook_with_args_until_failure): Adjust accordingly.
12166 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
12168 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
12170 * dispextern.h (string_buffer_position): Remove declaration.
12172 * print.c (strout): Remove parameter `multibyte', unused since
12173 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
12175 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
12176 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
12177 All callers changed.
12179 * w32.c (_wsa_errlist): Use braces for struct initializers.
12181 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
12182 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
12183 All callers changed.
12184 (string_buffer_position): Likewise. Also, make static (it's never
12185 used outside xdisp.c).
12186 (cursor_row_p): Remove parameter `w', unused since
12187 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
12188 (decode_mode_spec): Remove parameter `precision', introduced during
12189 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
12190 All callers changed.
12192 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12194 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
12196 2011-03-27 Anders Lindgren <andlind@gmail.com>
12198 * nsterm.m (ns_menu_bar_is_hidden): New variable.
12199 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
12200 (ns_update_auto_hide_menu_bar): New functions.
12201 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
12202 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
12203 ns_constrain_all_frames.
12204 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
12205 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
12207 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12209 * nsmenu.m (runDialogAt): Remove argument to timer_check.
12211 2011-03-27 Glenn Morris <rgm@gnu.org>
12213 * syssignal.h: Replace RETSIGTYPE with void.
12214 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
12215 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
12216 Replace SIGTYPE with void everywhere.
12217 * s/usg5-4-common.h (SIGTYPE): Remove definition.
12218 * s/template.h (SIGTYPE): Remove commented out definition.
12220 2011-03-26 Eli Zaretskii <eliz@gnu.org>
12222 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
12223 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
12225 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
12227 * w32.c (read_unc_volume): Use parameter `henum', instead of
12228 global variable `wget_enum_handle'.
12230 * keymap.c (describe_vector): Remove parameters `indices' and
12231 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
12232 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
12234 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
12236 * keyboard.c (timer_check): Remove parameter `do_it_now',
12237 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
12238 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
12239 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
12241 * keyboard.c (read_char):
12242 * w32menu.c (w32_menu_display_help):
12243 * xmenu.c (show_help_event, menu_help_callback):
12244 Adjust calls to `show_help_echo'.
12246 * gtkutil.c (xg_maybe_add_timer):
12247 * keyboard.c (readable_events):
12248 * process.c (wait_reading_process_output):
12249 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
12251 * insdel.c (adjust_markers_gap_motion):
12252 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
12253 (gap_left, gap_right): Don't call it.
12255 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
12257 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
12258 incurred during fontification.
12260 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
12262 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
12263 (DEFVAR_PER_BUFFER): Don't pass it.
12265 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
12266 (scrolling_window): Don't pass it.
12268 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
12270 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
12272 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
12274 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
12275 of variables specific to SELinux and computation of `encoded_absname'.
12277 * image.c (XPutPixel): Remove unused variable `height'.
12279 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
12281 * unexw32.c (get_section_info): Remove unused variable `section'.
12283 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
12284 (system_process_attributes): Remove unused variable `sess'.
12285 (sys_read): Remove unused variable `err'.
12287 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
12288 (w32_wnd_proc): Remove unused variable `isdead'.
12289 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
12290 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
12291 (x_create_tip_frame): Remove unused variable `tem'.
12293 * w32inevt.c (w32_console_read_socket):
12294 Remove unused variable `no_events'.
12296 * w32term.c (x_draw_composite_glyph_string_foreground):
12297 Remove unused variable `width'.
12299 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
12301 * w32term.c (x_set_glyph_string_clipping):
12302 Don't pass uninitialized region to CombineRgn.
12304 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
12306 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
12307 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
12308 (Fx_close_connection): Remove unused variable `i'.
12310 * w32font.c (w32font_draw): Return number of glyphs.
12311 (w32font_open_internal): Remove unused variable `i'.
12312 (w32font_driver): Add missing initializer.
12314 * w32menu.c (utf8to16): Remove unused variable `utf16'.
12315 (fill_in_menu): Remove unused variable `items_added'.
12317 * w32term.c (last_mouse_press_frame): Remove static global variable.
12318 (w32_clip_to_row): Remove unused variable `f'.
12319 (x_delete_terminal): Remove unused variable `i'.
12321 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
12322 (NOTHING): Remove unused static global variable.
12323 (uniscribe_check_otf): Remove unused variable `table'.
12324 (uniscribe_font_driver): Add missing initializers.
12326 2011-03-23 Julien Danjou <julien@danjou.info>
12328 * term.c (Fsuspend_tty, Fresume_tty):
12329 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
12330 * window.c (temp_output_buffer_show):
12331 * insdel.c (signal_before_change):
12332 * frame.c (Fhandle_switch_frame):
12333 * fileio.c (Fdo_auto_save):
12334 * emacs.c (Fkill_emacs):
12335 * editfns.c (save_excursion_restore):
12336 * cmds.c (internal_self_insert):
12337 * callint.c (Fcall_interactively):
12338 * buffer.c (Fkill_all_local_variables):
12339 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
12341 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
12342 unconditionally since it does the check itself.
12344 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
12346 Fix more problems found by GCC 4.5.2's static checks.
12348 * coding.c (encode_coding_raw_text): Avoid unnecessary test
12349 the first time through the loop, since we know p0 < p1 then.
12350 This also avoids a gcc -Wstrict-overflow warning.
12352 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
12353 leading to a memory leak, possible in functions like
12354 load_charset_map_from_file that can allocate an unbounded number
12355 of objects (Bug#8318).
12357 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
12358 that could (at least in theory) be that large.
12360 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
12361 This is less likely to overflow, and avoids undefined behavior if
12362 overflow does occur. All callers changed. Use strtoul to scan
12363 for the unsigned long integer.
12364 (pint2hrstr): Simplify and tune code slightly.
12365 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
12367 * scroll.c (do_scrolling): Work around GCC bug 48228.
12368 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
12370 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
12371 This also avoids a warning with gcc -Wstrict-overflow.
12372 (validate_x_resource_name): Simplify count usage.
12373 This also avoids a warning with gcc -Wstrict-overflow.
12375 * fileio.c (Fcopy_file): Report error if fchown or fchmod
12378 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
12380 * process.c (Fmake_network_process): Use socklen_t, not int,
12381 where POSIX says socklen_t is required in portable programs.
12382 This fixes a porting bug on hosts like 64-bit HP-UX, where
12383 socklen_t is wider than int (Bug#8277).
12384 (Fmake_network_process, server_accept_connection):
12385 (wait_reading_process_output, read_process_output):
12388 * process.c: Rename or move locals to avoid shadowing.
12389 (list_processes_1, Fmake_network_process):
12390 (read_process_output_error_handler, exec_sentinel_error_handler):
12391 Rename or move locals.
12392 (Fmake_network_process): Define label "retry_connect" only if needed.
12393 (Fnetwork_interface_info): Fix pointer signedness.
12394 (process_send_signal): Add cast to avoid pointer signedness problem.
12395 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
12396 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
12398 Make tparam.h and terminfo.c consistent.
12399 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
12400 Include tparam.h instead, since it declares them.
12401 * cm.h (PC): Remove extern decl; tparam.h now does this.
12402 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
12403 * terminfo.c: Include tparam.h, to check interfaces.
12404 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
12405 (tparam): Adjust signature to match interface in tparam.h;
12406 this removes some undefined behavior. Check that outstring and len
12407 are zero, which they always are with Emacs.
12408 * tparam.h (PC, BC, UP): New extern decls.
12410 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
12411 (xftfont_open): Rename locals to avoid shadowing.
12413 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
12414 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
12415 (OTF_TAG_SYM): Omit macro if not needed.
12416 (ftfont_list): Remove unused local.
12417 (get_adstyle_property, ftfont_pattern_entity):
12418 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
12419 Rename locals to avoid shadowing.
12421 * xfont.c (xfont_list_family): Mark var as initialized.
12423 * xml.c (make_dom): Now static.
12425 * composite.c (composition_compute_stop_pos): Rename local to
12427 (composition_reseat_it): Remove unused locals.
12428 (find_automatic_composition, composition_adjust_point): Likewise.
12429 (composition_update_it): Mark var as initialized.
12430 (find_automatic_composition): Mark vars as initialized,
12431 with a FIXME (Bug#8290).
12433 character.h: Rename locals to avoid shadowing.
12434 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
12435 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
12436 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
12437 (BUF_DEC_POS): Be more systematic about renaming local temporaries
12438 to avoid shadowing.
12440 * textprop.c (property_change_between_p): Remove; unused.
12442 * intervals.c (interval_start_pos): Now static.
12444 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
12446 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
12447 Rename locals to avoid shadowing.
12449 * sound.c (wav_play, au_play, Fplay_sound_internal):
12450 Fix pointer signedness.
12451 (alsa_choose_format): Remove unused local var.
12452 (wav_play): Initialize a variable to 0, to prevent undefined
12453 behavior (Bug#8278).
12455 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
12457 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
12459 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
12460 clobbering (Bug#8298).
12461 * sysdep.c (sys_subshell): Likewise.
12462 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
12464 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
12465 This should get cleaned up, so that child_setup has the
12466 same signature on all platforms.
12468 * callproc.c (call_process_cleanup): Now static.
12469 (relocate_fd): Rename locals to avoid shadowing.
12471 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
12473 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
12474 not to be necessary, and produces flickering.
12476 2011-03-20 Glenn Morris <rgm@gnu.org>
12478 * config.in: Remove file.
12480 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
12482 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
12483 are now in src/globals.h.
12484 (syms_of_minibuf): Remove spurious & from previous change.
12486 2011-03-20 Leo Liu <sdl.web@gmail.com>
12488 * minibuf.c (completing-read-function): New variable.
12489 (completing-read-default): Rename from completing-read.
12490 (completing-read): Call completing-read-function.
12492 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
12494 * xfaces.c (Fx_load_color_file):
12495 Read color file from absolute filename (bug#8250).
12497 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
12499 * makefile.w32-in: Update dependencies.
12501 2011-03-17 Eli Zaretskii <eliz@gnu.org>
12503 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
12505 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
12507 Fix more problems found by GCC 4.5.2's static checks.
12509 * process.c (make_serial_process_unwind, send_process_trap):
12510 (sigchld_handler): Now static.
12512 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
12513 That way, the code declares only the vars that it needs.
12514 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
12515 * s/cygwin.h (PTY_ITERATION): Likewise.
12516 * s/darwin.h (PTY_ITERATION): Likewise.
12517 * s/gnu-linux.h (PTY_ITERATION): Likewise.
12519 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
12520 * process.c (allocate_pty): Don't declare stb unless it's needed.
12522 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
12523 (CONSTANTLIM): Remove; unused.
12524 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
12525 Define only if needed.
12527 * unexelf.c (unexec): Name an expression,
12528 to avoid gcc -Wbad-function-cast warning.
12529 Use a different way to cause a compilation error if anyone uses
12530 n rather than nn, a way that does not involve shadowing.
12531 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
12533 * deps.mk (unexalpha.o): Remove; unused.
12535 New file unexec.h, the (simple) interface for unexec (Bug#8267).
12536 * unexec.h: New file.
12537 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
12538 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
12539 Depend on unexec.h.
12540 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
12541 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
12542 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
12543 Change as necessary to match prototype in unexec.h.
12545 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
12547 (back_comment, skip_chars): Mark vars as initialized.
12549 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
12550 Rename locals to avoid shadowing.
12552 * lread.c (read1): Rewrite so as not to use empty "else".
12553 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
12555 * print.c (Fredirect_debugging_output): Fix pointer signedess.
12557 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
12558 warning when compiling print.c.
12560 * font.c (font_unparse_fcname): Abort in an "impossible" situation
12561 instead of using an uninitialized var.
12562 (font_sort_entities): Mark var as initialized.
12564 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
12566 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
12567 pointers to constants.
12568 (font_parse_fcname): Remove unused vars.
12569 (font_delete_unmatched): Now static.
12570 (font_get_spec): Remove; unused.
12571 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
12572 (font_update_drivers, Ffont_get_glyphs, font_add_log):
12573 Rename or move locals to avoid shadowing.
12575 * fns.c (require_nesting_list, require_unwind): Now static.
12576 (Ffillarray): Rename locals to avoid shadowing.
12578 * floatfns.c (domain_error2): Define only if needed.
12579 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
12581 * alloc.c (mark_backtrace): Move decl from here ...
12582 * lisp.h: ... to here, so that it can be checked.
12584 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
12585 (Fdefvar): Rewrite so as not to use empty "else".
12586 (lisp_indirect_variable): Name an expression,
12587 to avoid gcc -Wbad-function-cast warning.
12588 (Fdefvar): Rename locals to avoid shadowing.
12590 * callint.c (quotify_arg, quotify_args): Now static.
12591 (Fcall_interactively): Rename locals to avoid shadowing.
12592 Use const pointer when appropriate.
12594 * lisp.h (get_system_name, get_operating_system_release):
12595 Move decls here, to check interfaces.
12596 * process.c (get_operating_system_release): Move decl to lisp.h.
12597 * xrdb.c (get_system_name): Likewise.
12598 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
12599 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
12600 some of which prompt warnings from gcc -Wbad-function-cast.
12601 (Fformat_time_string, Fencode_time, Finsert_char):
12602 (Ftranslate_region_internal, Fformat):
12603 Rename or remove local vars to avoid shadowing.
12604 (Ftranslate_region_internal): Mark var as initialized.
12606 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
12609 * lisp.h (eassert): Check that the argument compiles, even if
12610 ENABLE_CHECKING is not defined.
12612 * data.c (Findirect_variable): Name an expression, to avoid
12613 gcc -Wbad-function-cast warning.
12614 (default_value, arithcompare, arith_driver, arith_error): Now static.
12615 (store_symval_forwarding): Rename local to avoid shadowing.
12616 (Fmake_variable_buffer_local, Fmake_local_variable):
12617 Mark variables as initialized.
12618 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
12620 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
12621 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
12622 Rename locals to avoid shadowing.
12623 (mark_stack): Move local variables into the #ifdef region where
12625 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
12626 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
12628 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
12629 (GC_STRING_CHARS): Remove; not used.
12630 (Fmemory_limit): Cast sbrk's returned value to char *.
12632 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
12633 avoids undefined behavior in theory.
12635 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
12637 Use functions, not macros, for up- and down-casing (Bug#8254).
12638 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12639 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
12640 to use the following functions instead of these macros.
12641 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
12642 EMACS_INT, since callers assume the returned value fits in int.
12643 (upcase1): Likewise, for UPCASE_TABLE.
12644 (uppercasep, lowercasep, upcase): New static inline functions.
12645 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
12646 the race-condition problem in the old DOWNCASE.
12648 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
12649 Rename locals to avoid shadowing.
12650 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
12651 (regex_compile, re_search_2, re_match_2_internal):
12652 Remove unused local vars.
12653 (FREE_VAR): Rewrite so as not to use empty "else",
12654 which gcc can warn about.
12655 (regex_compile, re_match_2_internal): Mark locals as initialized.
12656 (RETALLOC_IF): Define only if needed.
12657 (WORDCHAR_P): Likewise. This one is never needed, but is used
12658 only in a comment talking about a compiler bug, so put inside
12659 the #if 0 of that comment.
12660 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
12661 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
12664 * search.c (boyer_moore): Rename locals to avoid shadowing.
12665 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
12666 (PREV_CHAR_BOUNDARY): Likewise.
12668 * search.c (simple_search): Remove unused var.
12670 * dired.c (compile_pattern): Move decl from here ...
12671 * lisp.h: ... to here, so that it can be checked.
12672 (struct re_registers): New forward decl.
12674 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
12676 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
12678 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
12679 Rename locals to avoid shadowing.
12680 (Fvertical_motion): Mark locals as initialized.
12682 * casefiddle.c (casify_object, casify_region): Now static.
12683 (casify_region): Mark local as initialized.
12685 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
12687 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
12688 New macros, so that the caller can use some names other than
12689 gcpro1, gcpro2, etc.
12690 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
12692 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
12693 argument, for consistency with GCPRO2_VAR, etc: it is now the
12694 prefix of the variable, not the variable itself. All uses
12696 * dired.c (directory_files_internal, file_name_completion):
12697 Rename locals to avoid shadowing.
12699 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
12700 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
12701 dired.c's scmp function, had undefined behavior.
12702 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12703 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
12704 * buffer.h: ... to here, because these macros use current_buffer,
12705 and the new implementation with inline functions needs to have
12706 current_buffer in scope now, rather than later when the macros
12708 (downcase, upcase1): New static inline functions.
12709 (DOWNCASE, UPCASE1): Reimplement using these functions.
12710 This avoids undefined behavior in expressions like
12711 DOWNCASE (x) == DOWNCASE (y), which previously suffered
12712 from race conditions in accessing the global variables
12713 case_temp1 and case_temp2.
12714 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
12715 * lisp.h (case_temp1, case_temp2): Remove their decls.
12716 * character.h (ASCII_CHAR_P): Move from here ...
12717 * lisp.h: ... to here, so that the inline functions mentioned
12718 above can use them.
12720 * dired.c (directory_files_internal_unwind): Now static.
12722 * fileio.c (file_name_as_directory, directory_file_name):
12723 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
12725 (file_name_as_directory): Use const pointers when appropriate.
12726 (Fexpand_file_name): Likewise. In particular, newdir might
12727 point at constant storage, so make it a const pointer.
12728 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
12729 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
12731 (Fset_file_times, Finsert_file_contents, auto_save_error):
12732 Rename locals to avoid shadowing.
12734 * minibuf.c (choose_minibuf_frame_1): Now static.
12735 (Ftry_completion, Fall_completions): Rename or remove locals
12736 to avoid shadowing.
12738 * marker.c (bytepos_to_charpos): Remove; unused.
12740 * lisp.h (verify_bytepos, count_markers): New decls,
12741 so that gcc does not warn that these functions aren't declared.
12743 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
12744 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
12745 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
12746 (copy_text): Remove unused local var.
12748 * filelock.c (within_one_second): Now static.
12749 (lock_file_1): Rename local to avoid shadowing.
12751 * buffer.c (fix_overlays_before): Mark locals as initialized.
12752 (fix_start_end_in_overlays): Likewise. This function should be
12753 simplified by using pointers-to-pointers, but that's a different
12755 (switch_to_buffer_1): Now static.
12756 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
12757 (report_overlay_modification): Rename locals to avoid shadowing.
12759 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
12760 Fix pointer signedness issue.
12761 (sys_subshell): Mark local as volatile if checking for lint,
12762 to suppress a gcc -Wclobbered warning that does not seem to be right.
12763 (MAXPATHLEN): Define only if needed.
12765 * process.c (serial_open, serial_configure): Move decls from here ...
12766 * systty.h: ... to here, so that they can be checked.
12768 * fns.c (get_random, seed_random): Move extern decls from here ...
12769 * lisp.h: ... to here, so that they can be checked.
12771 * sysdep.c (reset_io): Now static.
12772 (wait_for_termination_signal): Remove; unused.
12774 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
12775 (copy_keymap_item, append_key, push_text_char_description):
12777 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
12778 (DENSE_TABLE_SIZE): Remove; unused.
12779 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
12780 (describe_map_tree):
12781 Rename locals to avoid shadowing.
12783 * keyboard.c: Declare functions static if they are not used elsewhere.
12784 (echo_char, echo_dash, cmd_error, top_level_2):
12785 (poll_for_input, handle_async_input): Now static.
12786 (read_char, kbd_buffer_get_event, make_lispy_position):
12787 (make_lispy_event, make_lispy_movement, apply_modifiers):
12788 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
12789 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
12790 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
12791 (read_key_sequence, read_char): Mark locals as initialized.
12792 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
12794 * keyboard.h (make_ctrl_char): New decl.
12795 (mark_kboards): Move decl here ...
12796 * alloc.c (mark_kboards): ... from here.
12798 * lisp.h (force_auto_save_soon): New decl.
12800 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
12801 (DEFINE_DUMMY_FUNCTION): New macro.
12802 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
12804 (main): Add casts to avoid warnings
12805 if GCC considers string literals to be constants.
12807 * lisp.h (fatal_error_signal): Add decl, since it's exported.
12809 * dbusbind.c: Pointer signedness fixes.
12810 (xd_signature, xd_append_arg, xd_initialize):
12811 (Fdbus_call_method, Fdbus_call_method_asynchronously):
12812 (Fdbus_method_return_internal, Fdbus_method_error_internal):
12813 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
12814 (Fdbus_register_signal): Use SSDATA when the context wants char *.
12816 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
12817 if GCC considers string literals to be constants.
12818 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
12820 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
12822 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
12823 (print_preprocess, print_object): New macro to fix last change.
12825 * print.c (print_preprocess): Don't forget font objects.
12827 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
12829 * emacs.c (USAGE3): Doc fixes.
12831 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
12833 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
12836 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
12838 * lisp.h (VWindow_system, Qfile_name_history):
12839 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
12840 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
12841 (w32_system_caret_x, w32_system_caret_y): Declare extern.
12843 * w32select.c: Don't #include "keyboard.h".
12844 (run_protected): Add extern declaration for waiting_for_input.
12846 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
12847 * w32console.c (detect_input_pending, read_input_pending)
12848 (encode_terminal_code):
12849 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
12850 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
12851 (w32_system_caret_y, Qfile_name_history):
12852 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
12853 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
12854 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
12855 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
12856 * w32proc.c (Qlocal, report_file_error):
12857 * w32term.c (Vwindow_system, updating_frame):
12858 * w32uniscribe.c (initialized, uniscribe_font_driver):
12859 Remove unneeded extern declarations.
12861 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
12863 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
12865 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
12867 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
12868 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
12869 These macros can no longer be used for assignment.
12871 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
12872 Assign struct members directly, instead of using BUF_BEGV etc.
12873 (record_buffer_markers, fetch_buffer_markers): New functions for
12874 recording and fetching special buffer markers.
12875 (set_buffer_internal_1, set_buffer_temp): Use them.
12877 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
12879 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
12881 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
12882 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
12884 * xdisp.c (hscroll_window_tree):
12885 (reconsider_clip_changes): Use PT instead of BUF_PT.
12887 2011-03-13 Eli Zaretskii <eliz@gnu.org>
12889 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
12890 $(EMACS_ROOT)/lib/intprops.h.
12892 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
12894 Fix more problems found by GCC 4.5.2's static checks.
12896 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
12897 to unsigned char * to avoid compiler diagnostic.
12898 (xg_free_frame_widgets): Make it clear that a local variable is
12899 needed only if USE_GTK_TOOLTIP.
12900 (gdk_window_get_screen): Make it clear that this macro is needed
12901 only if USE_GTK_TOOLTIP.
12902 (int_gtk_range_get_value): New function, which avoids a diagnostic
12903 from gcc -Wbad-function-cast.
12904 (xg_set_toolkit_scroll_bar_thumb): Use it.
12905 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
12906 diagnostic from gcc -Wbad-function-cast.
12907 (get_utf8_string, xg_get_file_with_chooser):
12908 Rename locals to avoid shadowing.
12909 (create_dialog): Move locals to avoid shadowing.
12911 * xgselect.c (xg_select): Remove unused var.
12913 * image.c (four_corners_best): Mark locals as initialized.
12914 (gif_load): Initialize transparent_p to zero (Bug#8238).
12915 Mark another local as initialized.
12916 (my_png_error, my_error_exit): Mark with NO_RETURN.
12918 * image.c (clear_image_cache): Now static.
12919 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
12920 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
12921 (x_edge_detection): Remove unnecessary cast that
12922 gcc -Wbad-function-cast diagnoses.
12923 (gif_load): Fix pointer signedness.
12924 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
12925 (jpeg_load, gif_load): Rename locals to avoid shadowing.
12927 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
12929 Improve quality of tests for time stamp overflow.
12930 For example, without this patch (encode-time 0 0 0 1 1
12931 1152921504606846976) returns the obviously-bogus value (-948597
12932 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
12933 reports time overflow. See
12934 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
12935 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
12936 * editfns.c: Include limits.h and intprops.h.
12937 (TIME_T_MIN, TIME_T_MAX): New macros.
12938 (time_overflow): Move earlier, to before first use.
12939 (hi_time, lo_time): New functions, for an accurate test for
12940 out-of-range times.
12941 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
12942 (Fget_internal_run_time): Don't assume time_t fits in int.
12943 (make_time): Use list2 instead of Fcons twice.
12944 (Fdecode_time): More accurate test for out-of-range times.
12945 (check_tm_member): New function.
12946 (Fencode_time): Use it, to test for out-of-range times.
12947 (lisp_time_argument): Don't rely on undefined left-shift and
12948 right-shift behavior when checking for time stamp overflow.
12950 * editfns.c (time_overflow): New function, refactoring common code.
12951 (Fformat_time_string, Fdecode_time, Fencode_time):
12952 (Fcurrent_time_string): Use it.
12954 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
12955 * dired.c (make_time): Move to ...
12956 * editfns.c (make_time): ... here.
12957 * systime.h: Note the move.
12959 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
12961 * fringe.c (update_window_fringes): Remove unused variables.
12963 * unexmacosx.c (copy_data_segment): Also copy __got section.
12966 2011-03-12 Eli Zaretskii <eliz@gnu.org>
12968 * termcap.c [MSDOS]: Include "msdos.h".
12969 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
12970 Constify `char *' arguments and their references according to
12971 prototypes in tparam.h.
12973 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
12975 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
12976 Adapt all references accordingly.
12978 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
12980 2011-03-11 Tom Tromey <tromey@redhat.com>
12982 * buffer.c (syms_of_buffer): Remove obsolete comment.
12984 2011-03-11 Eli Zaretskii <eliz@gnu.org>
12986 * termhooks.h (encode_terminal_code): Declare prototype.
12988 * msdos.c (encode_terminal_code): Don't declare prototype.
12990 * term.c (encode_terminal_code): Now external again, used by
12991 w32console.c and msdos.c.
12993 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
12994 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
12996 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
12998 Fix some minor problems found by GCC 4.5.2's static checks.
13000 * fringe.c (update_window_fringes): Mark locals as initialized
13002 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
13004 * alloc.c (mark_fringe_data): Move decl from here ...
13005 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
13006 to check its interface.
13007 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
13009 * fontset.c (free_realized_fontset): Now static.
13010 (Fset_fontset_font): Rename local to avoid shadowing.
13011 (fontset_font): Mark local as initialized.
13012 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
13014 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
13016 * xselect.c (x_disown_buffer_selections): Remove; not used.
13017 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
13018 (x_own_selection, Fx_disown_selection_internal): Rename locals
13019 to avoid shadowing.
13020 (x_handle_dnd_message): Remove local to avoid shadowing.
13022 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
13023 so that the caller can use some name other than gcpro1.
13024 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
13025 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13026 (Fx_backspace_delete_keys_p):
13027 Use them to avoid shadowing, and rename vars to avoid shadowing.
13028 (x_decode_color, x_set_name, x_window): Now static.
13029 (Fx_create_frame): Add braces to silence GCC warning.
13030 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
13031 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
13032 Remove unused locals.
13033 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13034 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
13035 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
13038 * xterm.h (x_mouse_leave): New decl.
13040 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
13041 Remove unused functions.
13042 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
13043 (x_calc_absolute_position): Now static.
13044 (XTread_socket): Don't define label "out" unless it's used.
13045 Don't declare local "event" unless it's used.
13046 (x_iconify_frame, x_free_frame_resources): Don't declare locals
13047 unless they are used.
13048 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
13049 (x_fatal_error_signal): Remove; not used.
13050 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
13051 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
13052 (x_error_catcher, x_connection_closed, x_error_handler):
13053 (x_error_quitter, xembed_send_message, x_iconify_frame):
13054 (my_log_handler): Rename locals to avoid shadowing.
13055 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
13056 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
13058 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
13059 Rename or move locals to avoid shadowing.
13060 (tty_defined_color, merge_face_heights): Now static.
13061 (free_realized_faces_for_fontset): Remove; not used.
13062 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
13063 does not deduce is never used uninitialized.
13064 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
13065 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
13067 * terminal.c (store_terminal_param): Now static.
13069 * xmenu.c (menu_highlight_callback): Now static.
13070 (set_frame_menubar): Remove unused local.
13071 (xmenu_show): Rename parameter to avoid shadowing.
13072 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
13073 since they might point to immutable storage.
13074 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
13075 since it's unused otherwise.
13077 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
13078 Add a FIXME, since the code still doesn't look right. (Bug#8215)
13079 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
13080 avoids a gcc -Wuninitialized diagnostic.
13081 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
13082 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
13083 does not deduce are never used uninitialized.
13085 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
13087 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
13088 * window.c (window_loop, size_window):
13089 (run_window_configuration_change_hook, enlarge_window): Likewise.
13091 * window.c (display_buffer): Now static.
13092 (size_window): Mark variables that gcc -Wuninitialized
13093 does not deduce are never used uninitialized.
13094 * window.h (check_all_windows): New decl, to forestall
13095 gcc -Wmissing-prototypes diagnostic.
13096 * dispextern.h (bidi_dump_cached_states): Likewise.
13098 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
13100 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
13101 Include <limits.h>.
13102 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
13103 and to avoid gcc -Wuninitialized warning.
13104 (load_charset_map): Mark variables that gcc -Wuninitialized
13105 does not deduce are never used uninitialized.
13106 (load_charset): Abort instead of using uninitialized var (Bug#8229).
13108 * coding.c (coding_set_source, coding_set_destination):
13109 Use "else { /* comment */ }" rather than "else /* comment */;"
13110 for clarity, and to avoid gcc -Wempty-body warning.
13111 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
13112 a block, when the outer 'i' will do.
13113 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
13114 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
13115 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
13116 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
13117 (Fdecode_sjis_char, Fdefine_coding_system_internal):
13118 Rename locals to avoid shadowing.
13119 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
13120 * coding.c (emacs_mule_char, encode_invocation_designation):
13121 Now static, since they're not used elsewhere.
13122 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
13123 (decode_coding_object, encode_coding_object, detect_coding_system):
13124 (decode_coding_emacs_mule): Mark variables that gcc
13125 -Wuninitialized does not deduce are never used uninitialized.
13126 (detect_coding_iso_2022): Initialize a local variable that might
13127 be used uninitialized. Leave a FIXME because it's not clear that
13128 this initialization is needed. (Bug#8211)
13129 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
13130 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
13131 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
13132 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
13133 Remove unused macros.
13135 * category.c (hash_get_category_set): Remove unused local var.
13136 (copy_category_table): Now static, since it's not used elsewhere.
13137 * character.c (string_count_byte8): Likewise.
13139 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
13140 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
13142 * chartab.c (copy_sub_char_table): Now static, since it's not used
13144 (sub_char_table_ref_and_range, char_table_ref_and_range):
13145 Rename locals to avoid shadowing.
13146 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
13148 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
13149 (BIDI_BOB): Remove unused macro.
13151 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
13152 deduce are never used uninitialized.
13153 * term.c (encode_terminal_code): Likewise.
13155 * term.c (encode_terminal_code): Now static. Remove unused local.
13157 * tparam.h: New file.
13158 * term.c, tparam.h: Include it.
13159 * deps.mk (term.o, tparam.o): Depend on tparam.h.
13160 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
13161 Move these decls to tparam.h, and make them agree with what
13162 is actually in tparam.c. The previous trick of using incompatible
13163 decls in different modules does not conform to the C standard.
13164 All callers of tparam changed to use tparam's actual API.
13165 * tparam.c (tparam1, tparam, tgoto):
13166 Use const pointers where appropriate.
13168 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
13169 * cm.h (struct cm): Likewise.
13170 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
13171 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
13172 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
13173 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
13174 (turn_on_face, init_tty): Likewise.
13175 * termchar.h (struct tty_display_info): Likewise.
13177 * term.c (term_mouse_position): Rename local to avoid shadowing.
13179 * alloc.c (mark_ttys): Move decl from here ...
13180 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
13182 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
13184 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
13186 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
13188 * search.c (compile_pattern_1): Remove argument regp, unused since
13189 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
13190 (compile_pattern): Don't pass it.
13192 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
13194 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
13195 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
13197 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
13199 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
13201 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
13202 gdk_window_get_screen, gdk_window_get_geometry,
13203 gdk_x11_window_lookup_for_display and GDK_KEY_g.
13204 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
13205 (xg_get_pixbuf_from_pixmap): New function.
13206 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
13207 to Pixmap, take frame as parameter, remove GdkColormap parameter.
13208 Call xg_get_pixbuf_from_pixmap instead of
13209 gdk_pixbuf_get_from_drawable.
13210 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
13211 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
13212 (xg_check_special_colors): Use GtkStyleContext and its functions
13214 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
13215 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
13216 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
13217 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
13218 Call gtk_widget_get_preferred_size.
13219 (xg_frame_resized): gdk_window_get_geometry only takes 5
13221 (xg_win_to_widget, xg_event_is_for_menubar):
13222 Call gdk_x11_window_lookup_for_display.
13223 (xg_set_widget_bg): New function.
13224 (delete_cb): New function.
13225 (xg_create_frame_widgets): Connect delete-event to delete_cb.
13226 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
13227 (xg_set_background_color): Call xg_set_widget_bg.
13228 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
13229 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
13230 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
13231 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
13233 (update_frame_tool_bar): Call gtk_widget_hide.
13234 (xg_initialize): Use GDK_KEY_g.
13236 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
13238 (x_session_initialize): Call gdk_x11_set_sm_client_id.
13240 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
13241 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
13242 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
13244 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
13246 * w32xfns.c (select_palette): Check success of RealizePalette against
13247 GDI_ERROR, not zero.
13249 See ChangeLog.11 for earlier changes.
13251 ;; Local Variables:
13255 Copyright (C) 2011-2012 Free Software Foundation, Inc.
13257 This file is part of GNU Emacs.
13259 GNU Emacs is free software: you can redistribute it and/or modify
13260 it under the terms of the GNU General Public License as published by
13261 the Free Software Foundation, either version 3 of the License, or
13262 (at your option) any later version.
13264 GNU Emacs is distributed in the hope that it will be useful,
13265 but WITHOUT ANY WARRANTY; without even the implied warranty of
13266 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13267 GNU General Public License for more details.
13269 You should have received a copy of the GNU General Public License
13270 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.