1 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4 * data.c (circular_list_error): Remove.
6 2011-04-11 Paul Eggert <eggert@cs.ucla.edu>
8 * commands.h (last_point_position, last_point_position_buffer):
9 (last_point_position_window): Remove decls.
10 * keyboard.c: Make these variables static.
12 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
14 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
15 (iso_code_class, detect_coding, code_convert_region): Now static.
16 (encode_coding_gap): Remove; unused.
18 * chartab.c (chartab_chars, chartab_bits): Now static.
20 * charset.h (charset_iso_8859_1): Remove decl.
21 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
24 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
25 * ccl.c (Vccl_program_table): Now static.
26 (check_ccl_update): Remove; unused.
28 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
29 * category.h: ... from here.
30 * category.c (check_category_table, set_category_set): Now static.
32 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
33 * lisp.h: Remove these decls.
35 * buffer.c (buffer_count): Remove unused var.
37 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
38 so that it's not optimized away.
39 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
40 * dispextern.h (bidi_dump_cached_states): Remove, since it's
41 exported only to the debugger.
43 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
44 * atimer.h (run_all_atimers): Removed; not exported.
46 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
47 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
48 was inaccessible from Lisp.
49 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
50 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
52 alloc.c: Import and export fewer symbols, and remove unused items.
53 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
55 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
56 it's not optimized away by whole-program optimization.
57 (message_enable_multibyte, free_misc): Remove.
58 (catchlist, handlerlist, mark_backtrace):
59 Declare only if BYTE_MARK_STACK.
60 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
61 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
62 (message_enable_multibyte): Remove decl.
63 (free_misc, interval_free_list, float_block, float_block_index):
64 (n_float_blocks, float_free_list, cons_block, cons_block_index):
65 (cons_free_list, last_marked_index):
67 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
68 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
69 (mark_backtrace): Define only if BYTE_MARK_STACK.
70 * xdisp.c (message_enable_multibyte): Now static.
72 Declare Lisp_Object Q* variables to be 'static' if not exproted.
73 This makes it easier for human readers (and static analyzers)
74 to see whether these variables are used from other modules.
75 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
76 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
77 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
78 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
79 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
80 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
82 Declare Q* vars static if they are not used in other modules.
83 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
84 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
85 Remove decls of unexported vars.
86 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
88 * lisp.h (DEFINE_FUNC): Make sname 'static'.
90 Make Emacs functions such as Fatom 'static' by default.
91 This makes it easier for human readers (and static analyzers)
92 to see whether these functions can be called from other modules.
93 DEFUN now defines a static function. To make the function external
94 so that it can be used in other C modules, use the new macro DEFUE.
95 * lisp.h (DEFINE_FUNC): New macro, with the old contents of DEFUN.
96 (DEFUN): Rewrite in terms of DEFINE_FUNC. It now generates a
97 static function definition. Use DEFUE if you want an extern one.
98 (DEFUE, INFUN): New macros.
99 (Funibyte_char_to_multibyte, Fsyntax_table_p, Finit_image_library):
100 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
101 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
102 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
103 Remove decls, since these functions are now static.
104 (Funintern, Fget_internal_run_time): New decls, since these functions
105 were already external.
107 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
108 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
109 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
110 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
111 * keyboard.c, keymap.c, lread.c:
112 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
113 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
114 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
115 Mark functions with DEFUE instead of DEFUN,
116 if they are used in other modules.
117 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
118 decls for now-static functions.
119 * buffer.h (Fdelete_overlay): Remove decl.
120 * callproc.c (Fgetenv_internal): Mark as internal.
121 * composite.c (Fremove_list_of_text_properties): Remove decl.
122 (Fcomposition_get_gstring): New forward static decl.
123 * composite.h (Fcomposite_get_gstring): Remove decl.
124 * dired.c (Ffile_attributes): New forward static decl.
125 * doc.c (Fdocumntation_property): New forward static decl.
126 * eval.c (Ffetch_bytecode): New forward static decl.
127 (Funintern): Remove extern decl; now in .h file where it belongs.
128 * fileio.c (Fmake_symbolic_link): New forward static decl.
129 * image.c (Finit_image_library): New forward static decl.
130 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
131 * intervals.h (Fprevious_property_change):
132 (Fremove_list_of_text_properties): Remove decls.
133 * keyboard.c (Fthis_command_keys): Remove decl.
134 (Fcommand_execute): New forward static decl.
135 * keymap.c (Flookup_key): New forward static decl.
136 (Fcopy_keymap): Now static.
137 * keymap.h (Flookup_key): Remove decl.
138 * process.c (Fget_process): New forward static decl.
139 (Fprocess_datagram_address): Mark as internal.
140 * syntax.c (Fsyntax_table_p): New forward static decl.
141 (skip_chars): Remove duplicate decl.
142 * textprop.c (Fprevious_property_change): New forward static decl.
143 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
145 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
146 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
148 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
150 * editfns.c (Fformat): Remove unreachable code.
152 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
154 Fix more problems found by GCC 4.6.0's static checks.
156 * xdisp.c (vmessage): Use a better test for character truncation.
158 * charset.c (load_charset_map): <, not <=, for optimization,
159 and to avoid potential problems with integer overflow.
160 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
161 * casetab.c (set_identity, shuffle): Likewise.
162 * editfns.c (Fformat): Likewise.
163 * syntax.c (skip_chars): Likewise.
165 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
166 This also lets GCC 4.6.0 generate slightly better loop code.
168 * callint.c (Fcall_interactively): <, not <=, for optimization.
169 (Fcall_interactively): Count the number of arguments produced,
170 not the number of arguments given. This is simpler and lets GCC
171 4.6.0 generate slightly better code.
173 * ftfont.c: Distingish more carefully between FcChar8 and char.
174 The previous code passed unsigned char * to a functions like
175 strlen and xstrcasecmp that expect char *, which does not
176 conform to the C standard.
177 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
178 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
179 char * when the C standard requires it.
181 * keyboard.c (read_char): Remove unused var.
183 * eval.c: Port to Windows vsnprintf (Bug#8435).
185 (SIZE_MAX): Define if the headers do not.
186 (verror): Do not give up if vsnprintf returns a negative count.
187 Instead, grow the buffer. This ports to Windows vsnprintf, which
188 does not conform to C99. Problem reported by Eli Zaretskii.
189 Also, simplify the allocation scheme, by avoiding the need for
190 calling realloc, and removing the ALLOCATED variable.
192 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
194 Remove invocations of doprnt, as Emacs now uses vsnprintf.
195 But keep the doprint source code for now, as we might revamp it
196 and use it again (Bug#8435).
197 * lisp.h (doprnt): Remove.
198 * Makefile.in (base_obj): Remove doprnt.o.
199 * deps.mk (doprnt.o): Remove.
201 error: Print 32- and 64-bit integers portably (Bug#8435).
202 Without this change, on typical 64-bit hosts error ("...%d...", N)
203 was used to print both 32- and 64-bit integers N, which relied on
205 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
207 * lisp.h (error, verror): Mark as printf-like functions.
208 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
209 Report overflow in size calculations when allocating printf buffer.
210 Do not truncate output string at its first null byte.
211 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
212 Truncate the output at a character boundary, since vsnprintf does not
214 * charset.c (check_iso_charset_parameter): Convert internal
215 character to string before calling 'error', since %c now has the
217 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
218 overflow when computing char to be passed to 'error'. Do not
219 pass Lisp_Object to 'error'; pass the integer instead.
220 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
221 formatted with plain %d.
223 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
225 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
227 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
229 * xterm.c (x_catch_errors): Remove duplicate declaration.
231 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
233 * xdisp.c, lisp.h (message_nolog): Remove; unused.
235 2011-04-10 Jim Meyering <meyering@redhat.com>
237 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
238 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
239 return ssize_t not "int", and use size_t as the buffer length.
240 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
241 * gnutls.h: Update declarations.
242 * process.c (read_process_output): Use ssize_t, to match.
243 (send_process): Likewise.
245 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
247 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
249 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
251 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
252 unsigned char, to match FcChar8 type definition.
254 * xterm.c (handle_one_xevent):
255 * xmenu.c (create_and_show_popup_menu):
256 * xselect.c (x_decline_selection_request)
257 (x_reply_selection_request): Avoid type-punned deref of X events.
259 2011-04-09 Eli Zaretskii <eliz@emacstest.gnu.org>
261 Fix some uses of `int' instead of EMACS_INT.
262 * search.c (string_match_1, fast_string_match)
263 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
264 (scan_buffer, find_next_newline_no_quit)
265 (find_before_next_newline, search_command, Freplace_match)
266 (Fmatch_data): Make some `int' variables be EMACS_INT.
268 * xdisp.c (display_count_lines): 3rd argument and return value now
269 EMACS_INT. All callers changed.
270 (pint2hrstr): Last argument is now EMACS_INT.
272 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
273 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
274 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
275 (decode_coding_utf_16, decode_coding_emacs_mule)
276 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
277 (decode_coding_ccl, decode_coding_charset)
278 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
279 (decode_coding_iso_2022, decode_coding_emacs_mule)
280 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
281 <char_offset, last_offset>: Declare EMACS_INT.
282 (encode_coding_utf_8, encode_coding_utf_16)
283 (encode_coding_emacs_mule, encode_invocation_designation)
284 (encode_designation_at_bol, encode_coding_iso_2022)
285 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
286 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
288 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
289 (encode_invocation_designation): Last argument P_NCHARS is now
291 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
292 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
294 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
297 * ccl.c (Fccl_execute_on_string): Declare some variables
300 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
302 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
304 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
306 * process.c (Fformat_network_address): Doc fix.
308 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
310 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
312 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
314 * keyboard.c (read_char): Call Lisp function help-form-show,
315 instead of using internal_with_output_to_temp_buffer.
316 (Qhelp_form_show): New var.
317 (syms_of_keyboard): Use DEFSYM macro.
319 * print.c (internal_with_output_to_temp_buffer): Function deleted.
321 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
323 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
325 * process.c (Flist_processes): Removed to Lisp.
326 (list_processes_1): Deleted.
328 2011-04-06 Eli Zaretskii <eliz@gnu.org>
330 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
332 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
334 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
336 Fix more problems found by GCC 4.6.0's static checks.
338 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
340 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
342 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
344 * xdisp.c (vmessage): Mark as a printf-like function.
346 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
348 * sound.c (sound_warning): Don't crash if arg contains a printf format.
350 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
351 printf-like functions.
352 (tiff_load): Add casts to remove these marks before passing them
353 to system-supplied API.
355 * eval.c (Fsignal): Remove excess argument to 'fatal'.
357 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
358 This avoids several warnings with gcc -Wstrict-overflow.
359 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
360 directly, rather than having caller test rule sign. This avoids
361 some unnecessary tests.
362 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
363 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
364 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
366 * xfont.c (xfont_text_extents): Remove var that was set but not used.
367 (xfont_open): Avoid unnecessary tests.
369 * composite.c (composition_gstring_put_cache): Use unsigned integer.
371 * composite.h, composite.c (composition_gstring_put_cache):
372 Use EMACS_INT, not int, for length.
374 * composite.h (COMPOSITION_DECODE_REFS): New macro,
375 breaking out part of COMPOSITION_DECODE_RULE.
376 (COMPOSITION_DECODE_RULE): Use it.
377 * composite.c (get_composition_id): Remove unused local vars,
378 by using the new macro.
380 * textprop.c (set_text_properties_1): Change while to do-while,
381 since the condition is always true at first.
383 * intervals.c (graft_intervals_into_buffer): Mark var as used.
384 (interval_deletion_adjustment): Return unsigned value.
387 * process.c (list_processes_1, create_pty, read_process_output):
388 (exec_sentinel): Remove vars that were set but not used.
389 (create_pty): Remove unnecessary "volatile"s.
390 (Fnetwork_interface_info): Avoid possibility of int overflow.
391 (read_process_output): Do adaptive read buffering even if carryover.
392 (read_process_output): Simplify nbytes computation if buffered.
394 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
396 * syntax.c (scan_words): Remove var that was set but not used.
397 (update_syntax_table): Use unsigned instead of int.
399 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
400 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
401 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
403 * print.c (print_error_message): Avoid int overflow.
405 * font.c (font_list_entities): Redo for clarity,
406 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
408 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
409 (font_score): Avoid potential overflow in diff calculation.
411 * fns.c (substring_both): Remove var that is set but not used.
412 (sxhash): Redo loop for clarity and to avoid wraparound warning.
414 * eval.c (funcall_lambda): Rename local to avoid shadowing.
416 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
417 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
418 can always succeed if overflow has undefined behavior.
420 * search.c (boyer_moore, wordify): Remove vars set but not used.
421 (wordify): Omit three unnecessary tests.
423 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
424 All callers changed. This avoids the need for an unused var.
426 * casefiddle.c (casify_region): Remove var that is set but not used.
428 * dired.c (file_name_completion): Remove var that is set but not used.
430 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
432 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
433 (Finsert_file_contents): Remove unnecessary code checking fd.
435 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
436 Check for integer overflow on size calculations.
438 * buffer.c (Fprevious_overlay_change): Remove var that is set
441 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
442 Remove vars that are set but not used.
443 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
444 (timer_check_2): Mark vars as initialized.
446 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
448 * image.c (lookup_image): Remove var that is set but not used.
449 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
451 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
452 that are set but not used.
454 * xfns.c (make_invisible_cursor): Don't return garbage
455 if XCreateBitmapFromData fails (Bug#8410).
457 * xselect.c (x_get_local_selection, x_handle_property_notify):
458 Remove vars that are set but not used.
460 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
461 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
463 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
464 Remove var that is set but not used.
465 (scroll_bar_windows_size): Now size_t, not int.
466 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
469 * xfaces.c (realize_named_face): Remove vars that are set but not used.
470 (map_tty_color) [!defined MSDOS]: Likewise.
472 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
474 * coding.c: Remove vars that are set but not used.
475 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
477 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
478 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
479 (decode_coding_charset): Remove vars that are set but not used.
481 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
482 that is set but not used.
484 * print.c (print_object): Remove var that is set but not used.
486 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
487 The gnulib version avoids calling malloc in the usual case,
488 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
489 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
490 * filelock.c (current_lock_owner): Likewise.
491 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
492 * sysdep.c: Include allocator.h, careadlinkat.h.
493 (emacs_no_realloc_allocator): New static constant.
494 (emacs_readlink): New function.
495 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
496 ../lib/careadlinkat.h.
498 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
500 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
501 first non-nil return value).
503 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
505 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
506 if not defined (Bug#8403).
508 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
510 * xdisp.c (display_count_lines): Remove parameter `start',
511 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
512 (get_char_face_and_encoding): Remove parameter `multibyte_p',
513 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
514 (fill_stretch_glyph_string): Remove parameters `row' and `area',
515 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
516 and thereabouts. All callers changed.
517 (get_per_char_metric): Remove parameter `f', unused since
518 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
520 2011-04-02 Jim Meyering <meyering@redhat.com>
522 do not dereference NULL upon failed strdup
523 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
524 (ns_get_family): Likewise.
526 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
528 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
530 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
532 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
535 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
539 * window.c (Ftemp_output_buffer_show): New fun.
540 (Fsave_window_excursion):
541 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
543 * lread.c (lisp_file_lexically_bound_p): New function.
544 (Fload): Bind Qlexical_binding.
545 (readevalloop): Remove `evalfun' arg.
546 Bind Qinternal_interpreter_environment.
547 (Feval_buffer): Bind Qlexical_binding.
548 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
550 (syms_of_lread): Declare `lexical-binding'.
552 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
554 * keyboard.c (eval_dyn): New fun.
555 (menu_item_eval_property): Use it.
557 * image.c (parse_image_spec): Use Ffunctionp.
559 * fns.c (concat, mapcar1): Accept byte-code-functions.
561 * eval.c (Fsetq): Handle lexical vars.
562 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
563 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
564 (FletX, Flet): Obey lexical binding.
565 (Fcommandp): Handle closures.
566 (Feval): New `lexical' arg.
567 (eval_sub): New function extracted from Feval. Use it almost
568 everywhere where Feval was used. Look up vars in lexical env.
570 (Ffunctionp): Move from subr.el.
571 (Ffuncall): Handle closures.
572 (apply_lambda): Remove `eval_flags'.
573 (funcall_lambda): Handle closures and new byte-code-functions.
574 (Fspecial_variable_p): New function.
575 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
576 but without exporting it to Lisp.
578 * doc.c (Fdocumentation, store_function_docstring):
579 * data.c (Finteractive_form): Handle closures.
581 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
584 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
586 (exec_byte_code): New function extracted from Fbyte_code to handle new
587 calling convention for byte-code-functions. Add new byte-codes.
589 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
591 * alloc.c (Fmake_symbol): Init new `declared_special' field.
593 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
595 * xdisp.c (redisplay_internal): Fix prototype.
597 2011-03-31 Eli Zaretskii <eliz@gnu.org>
599 * xdisp.c (SCROLL_LIMIT): New macro.
600 (try_scrolling): Use it when setting scroll_limit. Limit
601 scrolling to 100 screen lines.
602 (redisplay_window): Even when falling back on "recentering",
603 position point in the window according to scroll-conservatively,
604 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
606 (try_scrolling): When point is above the window, allow searching
607 as far as scroll_max, or one screenful, to compute vertical
608 distance from PT to the scroll margin position. This prevents
609 try_scrolling from unnecessarily failing when
610 scroll-conservatively is set to a value slightly larger than the
611 window height. Clean up the case of PT below the margin at bottom
612 of window: scroll_max can no longer be INT_MAX. When aggressive
613 scrolling is in use, don't let point enter the opposite scroll
614 margin as result of the scroll.
615 (syms_of_xdisp) <scroll-conservatively>: Document the
616 threshold of 100 lines for never-recentering scrolling.
618 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
620 * dispextern.h (move_it_by_lines):
621 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
622 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
623 (message_log_check_duplicate): Remove parameters `prev_bol' and
624 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
625 (redisplay_internal): Remove parameter `preserve_echo_area',
626 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
628 * indent.c (Fvertical_motion):
629 * window.c (window_scroll_pixel_based, Frecenter):
630 Don't pass `need_y_p' to `move_it_by_lines'.
632 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
634 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
635 steal a few bits to be more compact.
636 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
637 Remove unneeded casts.
639 * bytecode.c (Fbyte_code): CAR and CDR can GC.
641 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
643 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
644 binding" message (bug#7967).
646 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
648 Fix more problems found by GCC 4.6.0's static checks.
650 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
651 Remove unused local var.
653 * editfns.c (Fmessage_box): Remove unused local var.
655 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
656 (note_mode_line_or_margin_highlight, note_mouse_highlight):
657 Omit unused local vars.
658 * window.c (shrink_windows): Omit unused local var.
659 * menu.c (digest_single_submenu): Omit unused local var.
660 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
661 Omit unused local var.
663 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
664 Don't assume string length fits in int.
665 (keyremap_step, read_key_sequence): Use size_t for sizes.
666 (read_key_sequence): Don't check last_real_key_start redundantly.
668 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
669 instead of alloca (Bug#8344).
671 * eval.c (Fbacktrace): Don't assume nargs fits in int.
672 (Fbacktrace_frame): Don't assume nframes fits in int.
674 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
676 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
679 * term.c (produce_glyphless_glyph): Remove unnecessary test.
681 * cm.c (calccost): Turn while-do into do-while, for clarity.
683 * keyboard.c (syms_of_keyboard): Use the same style as later
684 in this function when indexing through an array. This also
685 works around GCC bug 48267.
687 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
689 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
691 * chartab.c (sub_char_table_ref_and_range): Redo for slight
692 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
694 * keyboard.c, keyboard.h (num_input_events): Now size_t.
695 This avoids undefined behavior on integer overflow, and is a bit
696 more convenient anyway since it is compared to a size_t variable.
698 Variadic C functions now count arguments with size_t, not int.
699 This avoids an unnecessary limitation on 64-bit machines, which
700 caused (substring ...) to crash on large vectors (Bug#8344).
701 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
702 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
703 All variadic functions and their callers changed accordingly.
704 (struct gcpro.nvars): Now size_t, not int. All uses changed.
705 * data.c (arith_driver, float_arith_driver): Likewise.
706 * editfns.c (general_insert_function): Likewise.
707 * eval.c (struct backtrace.nargs, interactive_p)
708 (internal_condition_case_n, run_hook_with_args, apply_lambda)
709 (funcall_lambda, mark_backtrace): Likewise.
710 * fns.c (concat): Likewise.
711 * frame.c (x_set_frame_parameters): Likewise.
712 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
713 0 if not found, not -1. All callers changed.
715 * alloc.c (garbage_collect): Don't assume stack size fits in int.
716 (stack_copy_size): Now size_t, not int.
717 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
719 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
721 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
722 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
725 * lisp.h (multibyte_char_to_unibyte):
726 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
727 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
728 * character.h (CHAR_TO_BYTE8):
729 * cmds.c (internal_self_insert):
730 * editfns.c (general_insert_function):
731 * keymap.c (push_key_description):
732 * search.c (Freplace_match):
733 * xdisp.c (message_dolog, set_message_1): All callers changed.
735 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
737 * keyboard.c (safe_run_hook_funcall): New function.
738 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
739 don't set the hook to nil, but remove the offending function instead.
740 (Qcommand_hook_internal): Remove, unused.
741 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
742 Vcommand_hook_internal.
744 * eval.c (enum run_hooks_condition): Remove.
745 (funcall_nil, funcall_not): New functions.
746 (run_hook_with_args): Call each function through a `funcall' argument.
747 Remove `cond' argument, now redundant.
748 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
749 (Frun_hook_with_args_until_failure): Adjust accordingly.
750 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
752 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
754 * dispextern.h (string_buffer_position): Remove declaration.
756 * print.c (strout): Remove parameter `multibyte', unused since
757 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
759 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
760 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
763 * w32.c (_wsa_errlist): Use braces for struct initializers.
765 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
766 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
768 (string_buffer_position): Likewise. Also, make static (it's never
769 used outside xdisp.c).
770 (cursor_row_p): Remove parameter `w', unused since
771 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
772 (decode_mode_spec): Remove parameter `precision', introduced during
773 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
776 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
778 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
780 2011-03-27 Anders Lindgren <andlind@gmail.com>
782 * nsterm.m (ns_menu_bar_is_hidden): New variable.
783 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
784 (ns_update_auto_hide_menu_bar): New functions.
785 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
786 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
787 ns_constrain_all_frames.
788 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
789 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
791 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
793 * nsmenu.m (runDialogAt): Remove argument to timer_check.
795 2011-03-27 Glenn Morris <rgm@gnu.org>
797 * syssignal.h: Replace RETSIGTYPE with void.
798 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
799 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
800 Replace SIGTYPE with void everywhere.
801 * s/usg5-4-common.h (SIGTYPE): Remove definition.
802 * s/template.h (SIGTYPE): Remove commented out definition.
804 2011-03-26 Eli Zaretskii <eliz@gnu.org>
806 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
807 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
809 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
811 * w32.c (read_unc_volume): Use parameter `henum', instead of
812 global variable `wget_enum_handle'.
814 * keymap.c (describe_vector): Remove parameters `indices' and
815 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
816 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
818 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
820 * keyboard.c (timer_check): Remove parameter `do_it_now',
821 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
822 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
823 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
825 * keyboard.c (read_char):
826 * w32menu.c (w32_menu_display_help):
827 * xmenu.c (show_help_event, menu_help_callback):
828 Adjust calls to `show_help_echo'.
830 * gtkutil.c (xg_maybe_add_timer):
831 * keyboard.c (readable_events):
832 * process.c (wait_reading_process_output):
833 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
835 * insdel.c (adjust_markers_gap_motion):
836 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
837 (gap_left, gap_right): Don't call it.
839 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
841 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
842 incurred during fontification.
844 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
846 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
847 (DEFVAR_PER_BUFFER): Don't pass it.
849 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
850 (scrolling_window): Don't pass it.
852 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
854 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
856 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
858 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
859 of variables specific to SELinux and computation of `encoded_absname'.
861 * image.c (XPutPixel): Remove unused variable `height'.
863 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
865 * unexw32.c (get_section_info): Remove unused variable `section'.
867 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
868 (system_process_attributes): Remove unused variable `sess'.
869 (sys_read): Remove unused variable `err'.
871 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
872 (w32_wnd_proc): Remove unused variable `isdead'.
873 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
874 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
875 (x_create_tip_frame): Remove unused variable `tem'.
877 * w32inevt.c (w32_console_read_socket):
878 Remove unused variable `no_events'.
880 * w32term.c (x_draw_composite_glyph_string_foreground):
881 Remove unused variable `width'.
883 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
885 * w32term.c (x_set_glyph_string_clipping):
886 Don't pass uninitialized region to CombineRgn.
888 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
890 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
891 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
892 (Fx_close_connection): Remove unused variable `i'.
894 * w32font.c (w32font_draw): Return number of glyphs.
895 (w32font_open_internal): Remove unused variable `i'.
896 (w32font_driver): Add missing initializer.
898 * w32menu.c (utf8to16): Remove unused variable `utf16'.
899 (fill_in_menu): Remove unused variable `items_added'.
901 * w32term.c (last_mouse_press_frame): Remove static global variable.
902 (w32_clip_to_row): Remove unused variable `f'.
903 (x_delete_terminal): Remove unused variable `i'.
905 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
906 (NOTHING): Remove unused static global variable.
907 (uniscribe_check_otf): Remove unused variable `table'.
908 (uniscribe_font_driver): Add missing initializers.
910 2011-03-23 Julien Danjou <julien@danjou.info>
912 * term.c (Fsuspend_tty, Fresume_tty):
913 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
914 * window.c (temp_output_buffer_show):
915 * insdel.c (signal_before_change):
916 * frame.c (Fhandle_switch_frame):
917 * fileio.c (Fdo_auto_save):
918 * emacs.c (Fkill_emacs):
919 * editfns.c (save_excursion_restore):
920 * cmds.c (internal_self_insert):
921 * callint.c (Fcall_interactively):
922 * buffer.c (Fkill_all_local_variables):
923 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
925 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
926 unconditionnaly since it does the check itself.
928 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
930 Fix more problems found by GCC 4.5.2's static checks.
932 * coding.c (encode_coding_raw_text): Avoid unnecessary test
933 the first time through the loop, since we know p0 < p1 then.
934 This also avoids a gcc -Wstrict-overflow warning.
936 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
937 leading to a memory leak, possible in functions like
938 load_charset_map_from_file that can allocate an unbounded number
939 of objects (Bug#8318).
941 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
942 that could (at least in theory) be that large.
944 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
945 This is less likely to overflow, and avoids undefined behavior if
946 overflow does occur. All callers changed. Use strtoul to scan
947 for the unsigned long integer.
948 (pint2hrstr): Simplify and tune code slightly.
949 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
951 * scroll.c (do_scrolling): Work around GCC bug 48228.
952 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
954 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
955 This also avoids a warning with gcc -Wstrict-overflow.
956 (validate_x_resource_name): Simplify count usage.
957 This also avoids a warning with gcc -Wstrict-overflow.
959 * fileio.c (Fcopy_file): Report error if fchown or fchmod
962 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
964 * process.c (Fmake_network_process): Use socklen_t, not int,
965 where POSIX says socklen_t is required in portable programs.
966 This fixes a porting bug on hosts like 64-bit HP-UX, where
967 socklen_t is wider than int (Bug#8277).
968 (Fmake_network_process, server_accept_connection):
969 (wait_reading_process_output, read_process_output):
972 * process.c: Rename or move locals to avoid shadowing.
973 (list_processes_1, Fmake_network_process):
974 (read_process_output_error_handler, exec_sentinel_error_handler):
975 Rename or move locals.
976 (Fmake_network_process): Define label "retry_connect" only if needed.
977 (Fnetwork_interface_info): Fix pointer signedness.
978 (process_send_signal): Add cast to avoid pointer signedness problem.
979 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
980 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
982 Make tparam.h and terminfo.c consistent.
983 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
984 Include tparam.h instead, since it declares them.
985 * cm.h (PC): Remove extern decl; tparam.h now does this.
986 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
987 * terminfo.c: Include tparam.h, to check interfaces.
988 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
989 (tparam): Adjust signature to match interface in tparam.h;
990 this removes some undefined behavior. Check that outstring and len
991 are zero, which they always are with Emacs.
992 * tparam.h (PC, BC, UP): New extern decls.
994 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
995 (xftfont_open): Rename locals to avoid shadowing.
997 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
998 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
999 (OTF_TAG_SYM): Omit macro if not needed.
1000 (ftfont_list): Remove unused local.
1001 (get_adstyle_property, ftfont_pattern_entity):
1002 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
1003 Rename locals to avoid shadowing.
1005 * xfont.c (xfont_list_family): Mark var as initialized.
1007 * xml.c (make_dom): Now static.
1009 * composite.c (composition_compute_stop_pos): Rename local to
1011 (composition_reseat_it): Remove unused locals.
1012 (find_automatic_composition, composition_adjust_point): Likewise.
1013 (composition_update_it): Mark var as initialized.
1014 (find_automatic_composition): Mark vars as initialized,
1015 with a FIXME (Bug#8290).
1017 character.h: Rename locals to avoid shadowing.
1018 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
1019 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
1020 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
1021 (BUF_DEC_POS): Be more systematic about renaming local temporaries
1024 * textprop.c (property_change_between_p): Remove; unused.
1026 * intervals.c (interval_start_pos): Now static.
1028 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
1030 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
1031 Rename locals to avoid shadowing.
1033 * sound.c (wav_play, au_play, Fplay_sound_internal):
1034 Fix pointer signedness.
1035 (alsa_choose_format): Remove unused local var.
1036 (wav_play): Initialize a variable to 0, to prevent undefined
1037 behavior (Bug#8278).
1039 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
1041 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
1043 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
1044 clobbering (Bug#8298).
1045 * sysdep.c (sys_subshell): Likewise.
1046 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
1048 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
1049 This should get cleaned up, so that child_setup has the
1050 same signature on all platforms.
1052 * callproc.c (call_process_cleanup): Now static.
1053 (relocate_fd): Rename locals to avoid shadowing.
1055 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
1057 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
1058 not to be necessary, and produces flickering.
1060 2011-03-20 Glenn Morris <rgm@gnu.org>
1062 * config.in: Remove file.
1064 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
1066 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
1067 are now in src/globals.h.
1068 (syms_of_minibuf): Remove spurious & from previous change.
1070 2011-03-20 Leo <sdl.web@gmail.com>
1072 * minibuf.c (completing-read-function): New variable.
1073 (completing-read-default): Rename from completing-read.
1074 (completing-read): Call completing-read-function.
1076 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
1078 * xfaces.c (Fx_load_color_file):
1079 Read color file from absolute filename (bug#8250).
1081 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
1083 * makefile.w32-in: Update dependencies.
1085 2011-03-17 Eli Zaretskii <eliz@gnu.org>
1087 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
1089 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
1091 Fix more problems found by GCC 4.5.2's static checks.
1093 * process.c (make_serial_process_unwind, send_process_trap):
1094 (sigchld_handler): Now static.
1096 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
1097 That way, the code declares only the vars that it needs.
1098 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
1099 * s/cygwin.h (PTY_ITERATION): Likewise.
1100 * s/darwin.h (PTY_ITERATION): Likewise.
1101 * s/gnu-linux.h (PTY_ITERATION): Likewise.
1103 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
1104 * process.c (allocate_pty): Don't declare stb unless it's needed.
1106 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
1107 (CONSTANTLIM): Remove; unused.
1108 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
1109 Define only if needed.
1111 * unexelf.c (unexec): Name an expression,
1112 to avoid gcc -Wbad-function-cast warning.
1113 Use a different way to cause a compilation error if anyone uses
1114 n rather than nn, a way that does not involve shadowing.
1115 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
1117 * deps.mk (unexalpha.o): Remove; unused.
1119 New file unexec.h, the (simple) interface for unexec (Bug#8267).
1120 * unexec.h: New file.
1121 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
1122 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
1124 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
1125 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
1126 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
1127 Change as necessary to match prototype in unexec.h.
1129 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
1131 (back_comment, skip_chars): Mark vars as initialized.
1133 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
1134 Rename locals to avoid shadowing.
1136 * lread.c (read1): Rewrite so as not to use empty "else".
1137 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
1139 * print.c (Fredirect_debugging_output): Fix pointer signedess.
1141 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
1142 warning when compiling print.c.
1144 * font.c (font_unparse_fcname): Abort in an "impossible" situation
1145 instead of using an uninitialized var.
1146 (font_sort_entities): Mark var as initialized.
1148 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
1150 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
1151 pointers to constants.
1152 (font_parse_fcname): Remove unused vars.
1153 (font_delete_unmatched): Now static.
1154 (font_get_spec): Remove; unused.
1155 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
1156 (font_update_drivers, Ffont_get_glyphs, font_add_log):
1157 Rename or move locals to avoid shadowing.
1159 * fns.c (require_nesting_list, require_unwind): Now static.
1160 (Ffillarray): Rename locals to avoid shadowing.
1162 * floatfns.c (domain_error2): Define only if needed.
1163 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1165 * alloc.c (mark_backtrace): Move decl from here ...
1166 * lisp.h: ... to here, so that it can be checked.
1168 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
1169 (Fdefvar): Rewrite so as not to use empty "else".
1170 (lisp_indirect_variable): Name an expression,
1171 to avoid gcc -Wbad-function-cast warning.
1172 (Fdefvar): Rename locals to avoid shadowing.
1174 * callint.c (quotify_arg, quotify_args): Now static.
1175 (Fcall_interactively): Rename locals to avoid shadowing.
1176 Use const pointer when appropriate.
1178 * lisp.h (get_system_name, get_operating_system_release):
1179 Move decls here, to check interfaces.
1180 * process.c (get_operating_system_release): Move decl to lisp.h.
1181 * xrdb.c (get_system_name): Likewise.
1182 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
1183 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
1184 some of which prompt warnings from gcc -Wbad-function-cast.
1185 (Fformat_time_string, Fencode_time, Finsert_char):
1186 (Ftranslate_region_internal, Fformat):
1187 Rename or remove local vars to avoid shadowing.
1188 (Ftranslate_region_internal): Mark var as initialized.
1190 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
1193 * lisp.h (eassert): Check that the argument compiles, even if
1194 ENABLE_CHECKING is not defined.
1196 * data.c (Findirect_variable): Name an expression, to avoid
1197 gcc -Wbad-function-cast warning.
1198 (default_value, arithcompare, arith_driver, arith_error): Now static.
1199 (store_symval_forwarding): Rename local to avoid shadowing.
1200 (Fmake_variable_buffer_local, Fmake_local_variable):
1201 Mark variables as initialized.
1202 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
1204 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
1205 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
1206 Rename locals to avoid shadowing.
1207 (mark_stack): Move local variables into the #ifdef region where
1209 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
1210 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
1212 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
1213 (GC_STRING_CHARS): Remove; not used.
1214 (Fmemory_limit): Cast sbrk's returned value to char *.
1216 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
1217 avoids undefined behavior in theory.
1219 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
1221 Use functions, not macros, for up- and down-casing (Bug#8254).
1222 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1223 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
1224 to use the following functions instead of these macros.
1225 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
1226 EMACS_INT, since callers assume the returned value fits in int.
1227 (upcase1): Likewise, for UPCASE_TABLE.
1228 (uppercasep, lowercasep, upcase): New static inline functions.
1229 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
1230 the race-condition problem in the old DOWNCASE.
1232 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
1233 Rename locals to avoid shadowing.
1234 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
1235 (regex_compile, re_search_2, re_match_2_internal):
1236 Remove unused local vars.
1237 (FREE_VAR): Rewrite so as not to use empty "else",
1238 which gcc can warn about.
1239 (regex_compile, re_match_2_internal): Mark locals as initialized.
1240 (RETALLOC_IF): Define only if needed.
1241 (WORDCHAR_P): Likewise. This one is never needed, but is used
1242 only in a comment talking about a compiler bug, so put inside
1243 the #if 0 of that comment.
1244 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
1245 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
1248 * search.c (boyer_moore): Rename locals to avoid shadowing.
1249 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
1250 (PREV_CHAR_BOUNDARY): Likewise.
1252 * search.c (simple_search): Remove unused var.
1254 * dired.c (compile_pattern): Move decl from here ...
1255 * lisp.h: ... to here, so that it can be checked.
1256 (struct re_registers): New forward decl.
1258 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
1260 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
1262 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
1263 Rename locals to avoid shadowing.
1264 (Fvertical_motion): Mark locals as initialized.
1266 * casefiddle.c (casify_object, casify_region): Now static.
1267 (casify_region): Mark local as initialized.
1269 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
1271 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
1272 New macros, so that the caller can use some names other than
1273 gcpro1, gcpro2, etc.
1274 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
1276 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
1277 argument, for consistency with GCPRO2_VAR, etc: it is now the
1278 prefix of the variable, not the variable itself. All uses
1280 * dired.c (directory_files_internal, file_name_completion):
1281 Rename locals to avoid shadowing.
1283 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
1284 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
1285 dired.c's scmp function, had undefined behavior.
1286 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1287 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
1288 * buffer.h: ... to here, because these macros use current_buffer,
1289 and the new implementation with inline functions needs to have
1290 current_buffer in scope now, rather than later when the macros
1292 (downcase, upcase1): New static inline functions.
1293 (DOWNCASE, UPCASE1): Reimplement using these functions.
1294 This avoids undefined behavior in expressions like
1295 DOWNCASE (x) == DOWNCASE (y), which previously suffered
1296 from race conditions in accessing the global variables
1297 case_temp1 and case_temp2.
1298 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
1299 * lisp.h (case_temp1, case_temp2): Remove their decls.
1300 * character.h (ASCII_CHAR_P): Move from here ...
1301 * lisp.h: ... to here, so that the inline functions mentioned
1304 * dired.c (directory_files_internal_unwind): Now static.
1306 * fileio.c (file_name_as_directory, directory_file_name):
1307 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
1309 (file_name_as_directory): Use const pointers when appropriate.
1310 (Fexpand_file_name): Likewise. In particular, newdir might
1311 point at constant storage, so make it a const pointer.
1312 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
1313 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
1315 (Fset_file_times, Finsert_file_contents, auto_save_error):
1316 Rename locals to avoid shadowing.
1318 * minibuf.c (choose_minibuf_frame_1): Now static.
1319 (Ftry_completion, Fall_completions): Rename or remove locals
1322 * marker.c (bytepos_to_charpos): Remove; unused.
1324 * lisp.h (verify_bytepos, count_markers): New decls,
1325 so that gcc does not warn that these functions aren't declared.
1327 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
1328 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
1329 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
1330 (copy_text): Remove unused local var.
1332 * filelock.c (within_one_second): Now static.
1333 (lock_file_1): Rename local to avoid shadowing.
1335 * buffer.c (fix_overlays_before): Mark locals as initialized.
1336 (fix_start_end_in_overlays): Likewise. This function should be
1337 simplified by using pointers-to-pointers, but that's a different
1339 (switch_to_buffer_1): Now static.
1340 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
1341 (report_overlay_modification): Rename locals to avoid shadowing.
1343 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
1344 Fix pointer signedness issue.
1345 (sys_subshell): Mark local as volatile if checking for lint,
1346 to suppress a gcc -Wclobbered warning that does not seem to be right.
1347 (MAXPATHLEN): Define only if needed.
1349 * process.c (serial_open, serial_configure): Move decls from here ...
1350 * systty.h: ... to here, so that they can be checked.
1352 * fns.c (get_random, seed_random): Move extern decls from here ...
1353 * lisp.h: ... to here, so that they can be checked.
1355 * sysdep.c (reset_io): Now static.
1356 (wait_for_termination_signal): Remove; unused.
1358 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
1359 (copy_keymap_item, append_key, push_text_char_description):
1361 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
1362 (DENSE_TABLE_SIZE): Remove; unused.
1363 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
1364 (describe_map_tree):
1365 Rename locals to avoid shadowing.
1367 * keyboard.c: Declare functions static if they are not used elsewhere.
1368 (echo_char, echo_dash, cmd_error, top_level_2):
1369 (poll_for_input, handle_async_input): Now static.
1370 (read_char, kbd_buffer_get_event, make_lispy_position):
1371 (make_lispy_event, make_lispy_movement, apply_modifiers):
1372 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
1373 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
1374 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
1375 (read_key_sequence, read_char): Mark locals as initialized.
1376 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
1378 * keyboard.h (make_ctrl_char): New decl.
1379 (mark_kboards): Move decl here ...
1380 * alloc.c (mark_kboards): ... from here.
1382 * lisp.h (force_auto_save_soon): New decl.
1384 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
1385 (DEFINE_DUMMY_FUNCTION): New macro.
1386 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
1388 (main): Add casts to avoid warnings
1389 if GCC considers string literals to be constants.
1391 * lisp.h (fatal_error_signal): Add decl, since it's exported.
1393 * dbusbind.c: Pointer signedness fixes.
1394 (xd_signature, xd_append_arg, xd_initialize):
1395 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1396 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1397 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
1398 (Fdbus_register_signal): Use SSDATA when the context wants char *.
1400 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
1401 if GCC considers string literals to be constants.
1402 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
1404 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
1406 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
1407 (print_preprocess, print_object): New macro to fix last change.
1409 * print.c (print_preprocess): Don't forget font objects.
1411 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
1413 * emacs.c (USAGE3): Doc fixes.
1415 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
1417 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
1420 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
1422 * lisp.h (VWindow_system, Qfile_name_history):
1423 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
1424 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
1425 (w32_system_caret_x, w32_system_caret_y): Declare extern.
1427 * w32select.c: Don't #include "keyboard.h".
1428 (run_protected): Add extern declaration for waiting_for_input.
1430 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
1431 * w32console.c (detect_input_pending, read_input_pending)
1432 (encode_terminal_code):
1433 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
1434 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
1435 (w32_system_caret_y, Qfile_name_history):
1436 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
1437 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
1438 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
1439 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
1440 * w32proc.c (Qlocal, report_file_error):
1441 * w32term.c (Vwindow_system, updating_frame):
1442 * w32uniscribe.c (initialized, uniscribe_font_driver):
1443 Remove unneeded extern declarations.
1445 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
1447 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
1449 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
1451 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
1452 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
1453 These macros can no longer be used for assignment.
1455 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1456 Assign struct members directly, instead of using BUF_BEGV etc.
1457 (record_buffer_markers, fetch_buffer_markers): New functions for
1458 recording and fetching special buffer markers.
1459 (set_buffer_internal_1, set_buffer_temp): Use them.
1461 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
1463 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
1465 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
1466 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
1468 * xdisp.c (hscroll_window_tree):
1469 (reconsider_clip_changes): Use PT instead of BUF_PT.
1471 2011-03-13 Eli Zaretskii <eliz@gnu.org>
1473 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
1474 $(EMACS_ROOT)/lib/intprops.h.
1476 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
1478 Fix more problems found by GCC 4.5.2's static checks.
1480 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
1481 to unsigned char * to avoid compiler diagnostic.
1482 (xg_free_frame_widgets): Make it clear that a local variable is
1483 needed only if USE_GTK_TOOLTIP.
1484 (gdk_window_get_screen): Make it clear that this macro is needed
1485 only if USE_GTK_TOOLTIP.
1486 (int_gtk_range_get_value): New function, which avoids a diagnostic
1487 from gcc -Wbad-function-cast.
1488 (xg_set_toolkit_scroll_bar_thumb): Use it.
1489 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
1490 diagnostic from gcc -Wbad-function-cast.
1491 (get_utf8_string, xg_get_file_with_chooser):
1492 Rename locals to avoid shadowing.
1493 (create_dialog): Move locals to avoid shadowing.
1495 * xgselect.c (xg_select): Remove unused var.
1497 * image.c (four_corners_best): Mark locals as initialized.
1498 (gif_load): Initialize transparent_p to zero (Bug#8238).
1499 Mark another local as initialized.
1500 (my_png_error, my_error_exit): Mark with NO_RETURN.
1502 * image.c (clear_image_cache): Now static.
1503 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
1504 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
1505 (x_edge_detection): Remove unnecessary cast that
1506 gcc -Wbad-function-cast diagnoses.
1507 (gif_load): Fix pointer signedness.
1508 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
1509 (jpeg_load, gif_load): Rename locals to avoid shadowing.
1511 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
1513 Improve quality of tests for time stamp overflow.
1514 For example, without this patch (encode-time 0 0 0 1 1
1515 1152921504606846976) returns the obviously-bogus value (-948597
1516 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
1517 reports time overflow. See
1518 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
1519 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
1520 * editfns.c: Include limits.h and intprops.h.
1521 (TIME_T_MIN, TIME_T_MAX): New macros.
1522 (time_overflow): Move earlier, to before first use.
1523 (hi_time, lo_time): New functions, for an accurate test for
1525 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
1526 (Fget_internal_run_time): Don't assume time_t fits in int.
1527 (make_time): Use list2 instead of Fcons twice.
1528 (Fdecode_time): More accurate test for out-of-range times.
1529 (check_tm_member): New function.
1530 (Fencode_time): Use it, to test for out-of-range times.
1531 (lisp_time_argument): Don't rely on undefined left-shift and
1532 right-shift behavior when checking for time stamp overflow.
1534 * editfns.c (time_overflow): New function, refactoring common code.
1535 (Fformat_time_string, Fdecode_time, Fencode_time):
1536 (Fcurrent_time_string): Use it.
1538 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
1539 * dired.c (make_time): Move to ...
1540 * editfns.c (make_time): ... here.
1541 * systime.h: Note the move.
1543 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1545 * fringe.c (update_window_fringes): Remove unused variables.
1547 * unexmacosx.c (copy_data_segment): Also copy __got section.
1550 2011-03-12 Eli Zaretskii <eliz@gnu.org>
1552 * termcap.c [MSDOS]: Include "msdos.h".
1553 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
1554 Constify `char *' arguments and their references according to
1555 prototypes in tparam.h.
1557 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
1559 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
1560 Adapt all references accordingly.
1562 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
1564 2011-03-11 Tom Tromey <tromey@redhat.com>
1566 * buffer.c (syms_of_buffer): Remove obsolete comment.
1568 2011-03-11 Eli Zaretskii <eliz@gnu.org>
1570 * termhooks.h (encode_terminal_code): Declare prototype.
1572 * msdos.c (encode_terminal_code): Don't declare prototype.
1574 * term.c (encode_terminal_code): Now external again, used by
1575 w32console.c and msdos.c.
1577 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
1578 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
1580 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
1582 Fix some minor problems found by GCC 4.5.2's static checks.
1584 * fringe.c (update_window_fringes): Mark locals as initialized
1586 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
1588 * alloc.c (mark_fringe_data): Move decl from here ...
1589 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
1590 to check its interface.
1591 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
1593 * fontset.c (free_realized_fontset): Now static.
1594 (Fset_fontset_font): Rename local to avoid shadowing.
1595 (fontset_font): Mark local as initialized.
1596 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
1598 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
1600 * xselect.c (x_disown_buffer_selections): Remove; not used.
1601 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
1602 (x_own_selection, Fx_disown_selection_internal): Rename locals
1604 (x_handle_dnd_message): Remove local to avoid shadowing.
1606 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
1607 so that the caller can use some name other than gcpro1.
1608 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
1609 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1610 (Fx_backspace_delete_keys_p):
1611 Use them to avoid shadowing, and rename vars to avoid shadowing.
1612 (x_decode_color, x_set_name, x_window): Now static.
1613 (Fx_create_frame): Add braces to silence GCC warning.
1614 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
1615 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
1616 Remove unused locals.
1617 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1618 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
1619 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
1622 * xterm.h (x_mouse_leave): New decl.
1624 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
1625 Remove unused functions.
1626 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
1627 (x_calc_absolute_position): Now static.
1628 (XTread_socket): Don't define label "out" unless it's used.
1629 Don't declare local "event" unless it's used.
1630 (x_iconify_frame, x_free_frame_resources): Don't declare locals
1631 unless they are used.
1632 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
1633 (x_fatal_error_signal): Remove; not used.
1634 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
1635 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
1636 (x_error_catcher, x_connection_closed, x_error_handler):
1637 (x_error_quitter, xembed_send_message, x_iconify_frame):
1638 (my_log_handler): Rename locals to avoid shadowing.
1639 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
1640 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
1642 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
1643 Rename or move locals to avoid shadowing.
1644 (tty_defined_color, merge_face_heights): Now static.
1645 (free_realized_faces_for_fontset): Remove; not used.
1646 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
1647 does not deduce is never used uninitialized.
1648 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
1649 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
1651 * terminal.c (store_terminal_param): Now static.
1653 * xmenu.c (menu_highlight_callback): Now static.
1654 (set_frame_menubar): Remove unused local.
1655 (xmenu_show): Rename parameter to avoid shadowing.
1656 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
1657 since they might point to immutable storage.
1658 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
1659 since it's unused otherwise.
1661 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
1662 Add a FIXME, since the code still doesn't look right. (Bug#8215)
1663 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
1664 avoids a gcc -Wuninitialized diagnostic.
1665 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
1666 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
1667 does not deduce are never used uninitialized.
1669 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
1671 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
1672 * window.c (window_loop, size_window):
1673 (run_window_configuration_change_hook, enlarge_window): Likewise.
1675 * window.c (display_buffer): Now static.
1676 (size_window): Mark variables that gcc -Wuninitialized
1677 does not deduce are never used uninitialized.
1678 * window.h (check_all_windows): New decl, to forestall
1679 gcc -Wmissing-prototypes diagnostic.
1680 * dispextern.h (bidi_dump_cached_states): Likewise.
1682 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
1684 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
1686 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
1687 and to avoid gcc -Wuninitialized warning.
1688 (load_charset_map): Mark variables that gcc -Wuninitialized
1689 does not deduce are never used uninitialized.
1690 (load_charset): Abort instead of using uninitialized var (Bug#8229).
1692 * coding.c (coding_set_source, coding_set_destination):
1693 Use "else { /* comment */ }" rather than "else /* comment */;"
1694 for clarity, and to avoid gcc -Wempty-body warning.
1695 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
1696 a block, when the outer 'i' will do.
1697 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
1698 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
1699 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
1700 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
1701 (Fdecode_sjis_char, Fdefine_coding_system_internal):
1702 Rename locals to avoid shadowing.
1703 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
1704 * coding.c (emacs_mule_char, encode_invocation_designation):
1705 Now static, since they're not used elsewhere.
1706 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
1707 (decode_coding_object, encode_coding_object, detect_coding_system):
1708 (decode_coding_emacs_mule): Mark variables that gcc
1709 -Wuninitialized does not deduce are never used uninitialized.
1710 (detect_coding_iso_2022): Initialize a local variable that might
1711 be used uninitialized. Leave a FIXME because it's not clear that
1712 this initialization is needed. (Bug#8211)
1713 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
1714 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
1715 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
1716 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
1717 Remove unused macros.
1719 * category.c (hash_get_category_set): Remove unused local var.
1720 (copy_category_table): Now static, since it's not used elsewhere.
1721 * character.c (string_count_byte8): Likewise.
1723 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
1724 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
1726 * chartab.c (copy_sub_char_table): Now static, since it's not used
1728 (sub_char_table_ref_and_range, char_table_ref_and_range):
1729 Rename locals to avoid shadowing.
1730 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
1732 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
1733 (BIDI_BOB): Remove unused macro.
1735 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
1736 deduce are never used uninitialized.
1737 * term.c (encode_terminal_code): Likewise.
1739 * term.c (encode_terminal_code): Now static. Remove unused local.
1741 * tparam.h: New file.
1742 * term.c, tparam.h: Include it.
1743 * deps.mk (term.o, tparam.o): Depend on tparam.h.
1744 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
1745 Move these decls to tparam.h, and make them agree with what
1746 is actually in tparam.c. The previous trick of using incompatible
1747 decls in different modules does not conform to the C standard.
1748 All callers of tparam changed to use tparam's actual API.
1749 * tparam.c (tparam1, tparam, tgoto):
1750 Use const pointers where appropriate.
1752 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
1753 * cm.h (struct cm): Likewise.
1754 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
1755 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
1756 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
1757 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
1758 (turn_on_face, init_tty): Likewise.
1759 * termchar.h (struct tty_display_info): Likewise.
1761 * term.c (term_mouse_position): Rename local to avoid shadowing.
1763 * alloc.c (mark_ttys): Move decl from here ...
1764 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
1766 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
1768 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
1770 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
1772 * search.c (compile_pattern_1): Remove argument regp, unused since
1773 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
1774 (compile_pattern): Don't pass it.
1776 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
1778 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
1779 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
1781 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
1783 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
1785 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
1786 gdk_window_get_screen, gdk_window_get_geometry,
1787 gdk_x11_window_lookup_for_display and GDK_KEY_g.
1788 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
1789 (xg_get_pixbuf_from_pixmap): New function.
1790 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
1791 to Pixmap, take frame as parameter, remove GdkColormap parameter.
1792 Call xg_get_pixbuf_from_pixmap instead of
1793 gdk_pixbuf_get_from_drawable.
1794 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
1795 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
1796 (xg_check_special_colors): Use GtkStyleContext and its functions
1798 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
1799 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
1800 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
1801 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
1802 Call gtk_widget_get_preferred_size.
1803 (xg_frame_resized): gdk_window_get_geometry only takes 5
1805 (xg_win_to_widget, xg_event_is_for_menubar):
1806 Call gdk_x11_window_lookup_for_display.
1807 (xg_set_widget_bg): New function.
1808 (delete_cb): New function.
1809 (xg_create_frame_widgets): connect delete-event to delete_cb.
1810 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
1811 (xg_set_background_color): Call xg_set_widget_bg.
1812 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
1813 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
1814 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
1815 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
1817 (update_frame_tool_bar): Call gtk_widget_hide.
1818 (xg_initialize): Use GDK_KEY_g.
1820 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
1822 (x_session_initialize): Call gdk_x11_set_sm_client_id.
1824 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
1825 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
1826 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
1828 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
1830 * w32xfns.c (select_palette): Check success of RealizePalette against
1831 GDI_ERROR, not zero.
1833 See ChangeLog.11 for earlier changes.
1839 Copyright (C) 2011 Free Software Foundation, Inc.
1841 This file is part of GNU Emacs.
1843 GNU Emacs is free software: you can redistribute it and/or modify
1844 it under the terms of the GNU General Public License as published by
1845 the Free Software Foundation, either version 3 of the License, or
1846 (at your option) any later version.
1848 GNU Emacs is distributed in the hope that it will be useful,
1849 but WITHOUT ANY WARRANTY; without even the implied warranty of
1850 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
1851 GNU General Public License for more details.
1853 You should have received a copy of the GNU General Public License
1854 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.