]> code.delx.au - gnu-emacs/blob - src/ChangeLog
Merge from emacs-23; up to 2010-06-22T07:41:10Z!rgm@gnu.org
[gnu-emacs] / src / ChangeLog
1 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2
3 * xmenu.c (cleanup_widget_value_tree): New function.
4 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
5 calling free_menubar_widget_value_tree directly (Bug#9830).
6
7 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
8
9 Fix some portability problems with 'inline'.
10 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
11 (window_box_width, window_box_left, window_box_left_offset)
12 (window_box_right, window_box_right_offset): Declare extern.
13 Otherwise, these inline functions do not conform to C99 and
14 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
15 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
16 * intervals.c (adjust_intervals_for_insertion)
17 (adjust_intervals_for_deletion): Now extern, because otherwise the
18 extern inline functions 'offset_intervals' couldn't refer to it.
19 (static_offset_intervals): Remove.
20 (offset_intervals): Rewrite using the old contents of
21 static_offset_intervals. The old version didn't conform to C99
22 because an extern inline function contained a reference to an
23 identifier with static linkage.
24
25 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
26
27 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
28 GC.
29
30 2011-11-06 Eli Zaretskii <eliz@gnu.org>
31
32 * xdisp.c (init_iterator, reseat_to_string): Don't set the
33 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
34 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
35 return Qleft_to_right.
36
37 2011-11-06 Chong Yidong <cyd@gnu.org>
38
39 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
40 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
41 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
42 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
43 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
44 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
45 (Fwindow_vscroll): Doc fix.
46 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
47 argument, since it makes no sense to pass a live window and for
48 consistency with window-child.
49
50 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
51
52 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
53 support MSVC.
54
55 2011-11-05 Jason Rumney <jasonr@gnu.org>
56
57 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
58 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
59 fonts (Bug#6029).
60 (add_font_entity_to_list): Fix logic errors in mixed boolean and
61 bitwise arithmetic preventing use of unicode-sip and non-truetype
62 opentype fonts.
63
64 2011-11-05 Eli Zaretskii <eliz@gnu.org>
65
66 * s/ms-w32.h (fstat, stat, utime): Move redirections to
67 "emacs"-only part.
68
69 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
70 initialization code to keep similarity to xfns.c after changes
71 from 2011-11-05.
72
73 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
74
75 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
76 (unwind_create_frame): New function (Bug#9943).
77 (Fx_create_frame): Restructure code to be more similar to the one in
78 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
79 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
80 Move terminal->reference_count++ just before making the frame official
81 (Bug#9943).
82
83 * nsterm.m (x_free_frame_resources): New function.
84 (x_destroy_window): Move code to x_free_frame_resources.
85
86 * xfns.c (unwind_create_frame): Fix comment.
87 (Fx_create_frame, x_create_tip_frame): Move
88 terminal->reference_count++ just before making the frame
89 official. Move initialization of image_cache_refcount and
90 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
91
92 2011-11-05 Eli Zaretskii <eliz@gnu.org>
93
94 Support MSVC build with newer versions of Visual Studio.
95 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
96 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
97 nt/gmake.defs.
98
99 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
100 which are not supported by MSVC.
101 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
102 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
103 bitfields.
104 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
105 types in bitfields.
106 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
107
108 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
109
110 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
111
112 Support MSVC build with newer versions of Visual Studio.
113 * w32.c: Don't include w32api.h for MSVC.
114 (init_environment) [_MSC_VER]: Call sys_access, not _access.
115
116 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
117 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
118 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
119 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
120 e_* cousins.
121 (alloca) [_MSC_VER]: Define to _alloca.
122
123 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
124
125 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
126
127 2011-11-04 Eli Zaretskii <eliz@gnu.org>
128
129 * xdisp.c (note_mouse_highlight): If either of
130 previous/next-single-property-change returns nil, treat that as
131 the beginning or the end of the buffer. (Bug#9955)
132
133 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
134
135 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
136 label is not null (Bug#9951).
137 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
138 may be NULL.
139
140 2011-11-04 Eli Zaretskii <eliz@gnu.org>
141
142 * window.c (Fwindow_body_size): Mention in the doc string that the
143 return value is in frame's canonical units. (Bug#9949)
144
145 2011-11-03 Eli Zaretskii <eliz@gnu.org>
146
147 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
148
149 * w32fns.c (unwind_create_frame): If needed, free the glyph
150 matrices of the partially constructed frame. (Bug#9943)
151 * xfns.c (unwind_create_frame): Likewise.
152
153 2011-11-01 Eli Zaretskii <eliz@gnu.org>
154
155 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
156 Don't stop backward scan on the continuation glyph, even though
157 its CHARPOS is positive.
158 (mouse_face_from_buffer_pos, note_mouse_highlight): Rename
159 cover_string to disp_string.
160
161 2011-11-01 Martin Rudalics <rudalics@gmx.at>
162
163 * window.c (temp_output_buffer_show): Don't use
164 Vtemp_buffer_show_specifiers.
165 (Vtemp_buffer_show_specifiers): Remove unused variable.
166
167 2011-10-30 Eli Zaretskii <eliz@gnu.org>
168
169 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
170 past the beginning of the current glyph matrix.
171
172 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
173
174 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
175 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
176 HAVE_GTK3 (Bug#9869).
177
178 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
179 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
180
181 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
182
183 * xterm.c: Declare x_handle_net_wm_state to return int.
184 (handle_one_xevent): Check if we are iconified but don't have
185 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
186 (get_current_wm_state): Return non-zero if not hidden,
187 check for _NET_WM_STATE_HIDDEN (Bug#9893).
188 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
189 (x_handle_net_wm_state): Return what get_current_wm_state returns.
190 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
191
192 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
193
194 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
195 so that this new function doesn't get optimized away by a
196 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
197
198 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
199
200 * frame.h (MOUSE_HL_INFO): Remove excess parens.
201
202 2011-10-29 Eli Zaretskii <eliz@gnu.org>
203
204 Fix the `xbytecode' command.
205 * .gdbinit (xprintbytestr): New command.
206 (xwhichsymbols): Renamed from `which'; all callers changed.
207 (xbytecode): Print the byte-code string as well.
208
209 2011-10-29 Kim Storm <storm@cua.dk>
210
211 * alloc.c (which_symbols): New function.
212
213 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
214
215 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
216 line. (Bug#9903)
217
218 2011-10-29 Glenn Morris <rgm@gnu.org>
219
220 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
221 Not clear what it was for, and it causes various bugs. (Bug#9839)
222
223 2011-10-28 Eli Zaretskii <eliz@gnu.org>
224
225 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
226 possible random value that matches one of those tested as
227 condition to clear the mouse face.
228
229 2011-10-28 Chong Yidong <cyd@gnu.org>
230
231 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
232
233 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
234
235 * window.c (make_window): Initialize phys_cursor_on_p.
236
237 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
238
239 * lisp.h (struct Lisp_Symbol): Update comments.
240
241 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
242
243 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
244
245 2011-10-28 Eli Zaretskii <eliz@gnu.org>
246
247 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
248 <oslsachem@gmail.com> for helping to debug this.
249
250 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
251 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
252 (g_b_init_get_glyph_outline_w): New static variables.
253 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
254 (GetGlyphOutlineW_Proc): New typedefs.
255 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
256 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
257 New functions.
258 (w32font_open_internal, compute_metrics):
259 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
260 instead of calling the "wide" APIs directly.
261
262 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
263
264 * w32.h (syms_of_w32font): Add prototype.
265
266 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
267
268 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
269 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
270 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
271 (Fmove_to_window_line): Doc fix.
272
273 2011-10-27 Chong Yidong <cyd@gnu.org>
274
275 * process.c (make_process): Set gnutls_state to NULL.
276
277 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
278 non-NULL, regardless of GNUTLS_INITSTAGE.
279 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
280 an error. Set process slots as soon as we allocate them.
281
282 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
283
284 2011-10-27 Chong Yidong <cyd@gnu.org>
285
286 * gnutls.c (emacs_gnutls_deinit): New function.
287 Deallocate credentials structures as well as calling gnutls_deinit.
288 (Fgnutls_deinit, Fgnutls_boot): Use it.
289
290 * process.c (make_process): Initialize GnuTLS credentials to NULL.
291 (deactivate_process): Call emacs_gnutls_deinit.
292
293 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
294
295 * image.c (x_create_x_image_and_pixmap):
296 * w32.c (sys_rename, w32_delayed_load):
297 * w32font.c (fill_in_logfont):
298 * w32reg.c (x_get_string_resource): Silence compiler warnings.
299
300 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
301
302 * w32fns.c (w32_default_color_map): New function,
303 extracted from Fw32_default_color_map.
304 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
305
306 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
307
308 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
309
310 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
311
312 * keyboard.c (test_undefined): New function (bug#9751).
313 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
314
315 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
316
317 * sysdep.c (init_sys_modes): Fix the check for the controlling
318 terminal (Bug#6649).
319
320 2011-10-20 Eli Zaretskii <eliz@gnu.org>
321
322 * dispextern.h (struct bidi_it): New member next_en_type.
323
324 * bidi.c (bidi_line_init): Initialize the next_en_type member.
325 (bidi_resolve_explicit_1): When next_en_pos is valid for the
326 current character, check also for next_en_type being WEAK_EN.
327 (bidi_resolve_weak): Don't enter the expensive loop if the current
328 position is before next_en_pos. Record the bidi type of the first
329 non-ET, non-BN character we find, in addition to its position.
330 (bidi_level_of_next_char): Invalidate next_en_type when
331 next_en_pos is over-stepped.
332
333 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
334
335 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
336 * editfns.c: Rewrite current-time-zone so that it invokes
337 the equivalent of (format-time-string "%Z") to get the time zone name.
338 This fixes a bug when the time zone name contains characters that
339 need converting from the system time locale to Emacs internal format.
340 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
341 that patch fixed format-time-string to do the conversion, but
342 I forgot to fix current-time-zone.
343 (format_time_string): New function, containing most of
344 what Fformat_time_string used to contain.
345 (Fformat_time_string): Rewrite in terms of format_time_string.
346 This doesn't change this function's behavior.
347 (current-time-zone): Rewrite to use format_time_string.
348 This fixes the bug reported by Michael Schierl in
349 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
350 Jason Rumney's 2007-06-07 change worked around this bug, but
351 didn't fix it.
352 * systime.h (tzname, timezone): Remove no-longer-used declarations.
353
354 2011-10-19 Eli Zaretskii <eliz@gnu.org>
355
356 * xdisp.c (start_display): If the character at POS is displayed
357 via a display vector, reset IT->current.dpvec_index to zero.
358 (try_window_reusing_current_matrix): If a line ends in a display
359 vector or the next line starts in a display vector, continue
360 redrawing the window even though the character position of
361 start_row was reached.
362 (Bug#9771, part 2)
363
364 2011-10-18 Chong Yidong <cyd@gnu.org>
365
366 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
367 with nobreak-char-display too.
368
369 2011-10-18 Eli Zaretskii <eliz@gnu.org>
370
371 Fix part 3 of bug#9771.
372 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
373 (bidi_resolve_neutral): Don't enter the expensive loop looking for
374 non-neutral characters if the current character is a paragraph
375 separator (a.k.a. Newline). This avoids running the same
376 expensive loop twice, once when we consume the preceding newline
377 and the other time when the line actually needs to be displayed.
378 Avoid the loop when we see neutrals on the base embedding level
379 following a character whose directionality is the same as the
380 paragraph's. This avoids running the expensive loop when a line
381 ends in a long sequence of neutrals, like control characters.
382 Add assertion against STRONG_AL type. Slightly rearrange code
383 that determines the type of a neutral given the first non-neutral
384 that follows it.
385 (bidi_level_of_next_char): Set next_en_pos to zero when
386 invalidating its info.
387
388 2011-10-17 Eli Zaretskii <eliz@gnu.org>
389
390 * xdisp.c (push_display_prop): Determine whether to record string
391 or buffer position by IT->string, not by IT->method. Allow
392 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
393 (move_it_vertically_backward): Don't look for character position
394 immediately after the newline when in a continuation line.
395 (Bug#9771, part 1)
396
397 2011-10-15 Martin Rudalics <rudalics@gmx.at>
398
399 * window.c (coordinates_in_window): Rewrite and delabelize
400 vertical border check. (Bug#5357) (Bug#9618)
401
402 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
403
404 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
405 errors in XSetWindowBorder (bug#9310).
406
407 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
408
409 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
410 avoid crash when xmalloc overrun checking is enabled.
411
412 2011-10-13 Eli Zaretskii <eliz@gnu.org>
413
414 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
415 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
416 cursor motion with <left> and <right> arrow keys.
417
418 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
419 some callers set that themselves.
420
421 2011-10-12 Eli Zaretskii <eliz@gnu.org>
422
423 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
424 display string and the previous row comes from the same string and
425 is empty. (Bug#9739) (Bug#9738)
426
427 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
428
429 * doc.c (get_doc_string): Encode file name (bug#9735).
430
431 2011-10-12 Eli Zaretskii <eliz@gnu.org>
432
433 * bidi.c (bidi_level_of_next_char):
434 * xdisp.c (get_visually_first_element): Remove old incorrect
435 comments regarding the Unicode Line Separator character.
436
437 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
438
439 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
440
441 * alloc.c (Fgc_status): Do not access beyond zombies array
442 boundary if nzombies > MAX_ZOMBIES.
443 * alloc.c (dump_zombies): Add missing format specifier.
444
445 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
446
447 * xdisp.c (set_cursor_from_row): Simplify conditionals,
448 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
449
450 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
451 Some packages use them to denote characters with modifiers.
452
453 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
454
455 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
456 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
457 matching a pp-number. Rename parameter var to var1.
458
459 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
460
461 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
462
463 2011-10-08 Glenn Morris <rgm@gnu.org>
464
465 * callint.c (Fcall_interactively): Give a more explicit error for the
466 'c' case with a non-character input. (Bug#8479)
467
468 2011-10-08 Eli Zaretskii <eliz@gnu.org>
469
470 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
471 lines.
472 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
473 lines that are hscrolled on the left.
474
475 * dispnew.c (buffer_posn_from_coords): Account for a possible
476 presence of header-line. (Bug#4426)
477
478 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
479
480 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
481 Don't advertise functionality which we discourage or doesn't work.
482
483 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
484
485 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
486 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
487 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
488 this makes Emacs dump core during garbage collection on rare
489 occasions. sizeof is obviously inferior to offsetof here, so
490 stick with offsetof.
491 (GC_POINTER_ALIGNMENT): New macro.
492 (mark_memory): Omit 3rd (offset) arg; caller changed.
493 Don't assume EMACS_INT alignment is the same as pointer alignment.
494
495 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
496
497 * keyboard.c (read_key_sequence_remapped): New var.
498 (read_key_sequence): Compute remapping in the right buffer.
499 (command_loop_1): Use read_key_sequence's remapping directly.
500
501 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
502
503 * dired.c (file_name_completion): Don't expand file name.
504 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
505 before checking file name handler.
506
507 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
508 they've been requested explicitly (bug#9591).
509
510 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
511
512 * keymap.c (Fsingle_key_description): Use make_specified_string
513 instead of build_string to build string from push_key_description.
514 (Bug#5193)
515
516 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
517
518 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
519 This fixes a Y2038 bug on 64-bit hosts.
520 * buffer.c (reset_buffer):
521 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
522 (Fclear_buffer_auto_save_failure):
523 Use 0, not -1, to represent an unset failure time, since time_t
524 might not be signed.
525
526 Remove dependency on glibc malloc internals.
527 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
528 Move back here from lisp.h, but with their new implementations.
529 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
530 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
531 * charset.c (charset_table_init): New static var.
532 (syms_of_charset): Use it instead of xmalloc. This removes a
533 dependency on glibc malloc internals. See Eli Zaretskii's comment in
534 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
535 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
536 Move back to alloc.c.
537 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
538 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
539
540 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
541
542 * nsterm.m (windowDidResize): Call x_set_window_size only when
543 ns_in_resize is true. Otherwise set pixelwidth/height and
544 call change_frame_size (Bug#9628).
545
546 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
547
548 Port --enable-checking=all to Fedora 14 x86-64.
549 * charset.c (syms_of_charset): Also account for glibc malloc's
550 internal overhead when calculating the initial malloc maximum.
551
552 Port --enable-checking=all to Fedora 14 x86.
553 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
554 Move to lisp.h.
555 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
556 (overrun_check_realloc, overrun_check_free):
557 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
558 That way, xmalloc returns a properly-aligned pointer even if
559 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
560 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
561 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
562 into account when calculating the initial malloc maximum.
563 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
564 Move here from alloc.c, so that charset.c can use it too.
565 Properly align; the old code wasn't right for common 32-bit hosts
566 when configured with --enable-checking=all.
567 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
568 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
569
570 2011-09-29 Eli Zaretskii <eliz@gnu.org>
571
572 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
573 use EDOM.
574
575 2011-09-28 Eli Zaretskii <eliz@gnu.org>
576
577 * xdisp.c (compute_display_string_end): If there's no display
578 string at CHARPOS, return -1.
579
580 * bidi.c (bidi_fetch_char): When compute_display_string_end
581 returns a negative value, treat the character as a normal
582 character not covered by a display string. (Bug#9624)
583
584 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
585
586 * lread.c (Fread_from_string): Fix typo in docstring.
587
588 2011-09-27 Eli Zaretskii <eliz@gnu.org>
589
590 * xdisp.c (handle_invisible_prop): If invisible text ends on a
591 newline, reseat the iterator instead of bidi-iterating there one
592 character at a time. (Bug#9610)
593 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
594 TO_CHARPOS if the bidi iterator is at base embedding level.
595
596 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
597
598 * lread.c (readevalloop): Use correct code for NBSP.
599 (read1): Likewise. (Bug#9608)
600
601 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
602
603 * dbusbind.c (Fdbus_register_signal): When service is not
604 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
605
606 2011-09-25 Glenn Morris <rgm@gnu.org>
607
608 * buffer.c (truncate-lines): Doc fix.
609
610 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
611
612 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
613 (Fset_window_next_buffers): Doc fix.
614
615 2011-09-24 Glenn Morris <rgm@gnu.org>
616
617 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
618
619 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
620
621 Fix minor problems found by static checking.
622 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
623 * indent.c (Fvertical_motion): Fix == vs = typo.
624
625 2011-09-24 Eli Zaretskii <eliz@gnu.org>
626
627 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
628 Default value is now t. Doc fix.
629
630 * indent.c (Fvertical_motion): Compute and apply the overshoot
631 logic when moving up, not only when moving down. Fix the
632 confusing name and values of the it_overshoot_expected variable;
633 logic changes accordingly. (Bug#9254) (Bug#9549)
634
635 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
636 CHARPOS is covered by a display string which includes newlines.
637 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
638 is covered by a display string with embedded newlines.
639
640 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
641
642 * dbusbind.c (Fdbus_register_signal): Add match rule to
643 Vdbus_registered_objects_table. (Bug#9581)
644 (Fdbus_register_method, Vdbus_registered_objects_table):
645 Fix docstring.
646
647 2011-09-24 Jim Meyering <meyering@redhat.com>
648
649 do not ignore write error for any output size
650 The previous change was incomplete.
651 While it makes emacs --batch detect the vast majority of stdout
652 write failures, errors were still ignored whenever the output size is
653 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
654 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
655 && echo FAIL: ignored write error
656 FAIL: ignored write error
657 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
658 && echo FAIL: ignored write error
659 FAIL: ignored write error
660 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
661
662 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
663
664 * emacs.c (Fkill_emacs): In noninteractive mode exit
665 non-successfully if a write error occurred on stdout. (Bug#9574)
666
667 2011-09-21 Eli Zaretskii <eliz@gnu.org>
668
669 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
670 the xassert test.
671
672 * dispextern.h (struct it): Update the comment documenting what
673 can it->OBJECT be.
674
675 2011-09-20 Eli Zaretskii <eliz@gnu.org>
676
677 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
678 a display string, extend search for cursor position to end of row.
679 (find_row_edges): If the row ends in a newline from a display
680 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
681 Handle the case of a display string with multiple newlines.
682 (Fcurrent_bidi_paragraph_direction): Fix search for previous
683 non-empty line. Fixes confusing cursor motion with arrow keys at
684 the beginning of a line that starts with whitespace.
685
686 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
687
688 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
689 (bug#9493).
690
691 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
692
693 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
694 boolean (Bug#9154).
695
696 2011-09-18 Eli Zaretskii <eliz@gnu.org>
697
698 * xdisp.c (display_line): Record maximum and minimum buffer
699 positions even if no glyphs were produced (e.g., by a zero-width
700 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
701 buffer positions that will be removed from the glyph row because
702 they don't fit.
703 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
704 column is beyond frame width: don't subtract 1 "pixel" when
705 computing width of the stretch.
706 (reseat_at_next_visible_line_start): Undo the change made on
707 2011-09-17 that saved paragraph information and restored it after
708 the call to `reseat'. (Bug#9545)
709
710 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
711
712 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
713 and turn window cursor on if cleared (Bug#9415).
714
715 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
716
717 * search.c (boyer_moore): Take unibyte characters from pattern
718 literally. (Bug#9458)
719
720 2011-09-18 Eli Zaretskii <eliz@gnu.org>
721
722 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
723
724 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
725
726 Fix minor problem found by static checking.
727 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
728 initialized, to pacify gcc -Wuninitialized.
729
730 * fileio.c: Report proper errno when syscall falls.
731 (Finsert_file_contents): Save and restore errno,
732 so that report_file_error outputs the correct diagnostic.
733 (Fwrite_region) [CLASH_DETECTION]: Likewise.
734
735 2011-09-18 Eli Zaretskii <eliz@gnu.org>
736
737 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
738
739 2011-09-17 Eli Zaretskii <eliz@gnu.org>
740
741 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
742 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
743
744 2011-09-17 Eli Zaretskii <eliz@gnu.org>
745
746 * xdisp.c (reseat_at_next_visible_line_start): Keep information
747 about the current paragraph and restore it after the call to reseat.
748
749 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
750 (bidi_find_paragraph_start): Search back for paragraph beginning
751 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
752 (bidi_move_to_visually_next): Only trigger paragraph-related
753 computations when the last character is a newline or at EOB, not
754 just any NEUTRAL_B. (Bug#9470)
755
756 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
757 truncated lines if point is covered by a display string. (Bug#9524)
758
759 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
760
761 * xselect.c: Relax test for outgoing X longs (Bug#9498).
762 (cons_to_x_long): New function.
763 (lisp_data_to_selection_data): Use it. Correct the test for
764 short-versus-long data; it was negated. Break out of vector
765 loop, for efficiency, when a long datum is discovered.
766
767 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
768
769 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
770
771 2011-09-16 Eli Zaretskii <eliz@gnu.org>
772
773 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
774 GCC PR/17406) by declaring this function with external scope.
775
776 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
777
778 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
779 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
780
781 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
782
783 * editfns.c (Fformat): Correctly handle text properties on "%%".
784
785 2011-09-15 Eli Zaretskii <eliz@gnu.org>
786
787 * xterm.c (x_draw_composite_glyph_string_foreground):
788 * w32term.c (x_draw_composite_glyph_string_foreground):
789 * term.c (encode_terminal_code):
790 * composite.c (composition_update_it, get_composition_id):
791 * xdisp.c (get_next_display_element)
792 (fill_composite_glyph_string): Add comments about special meaning
793 of TAB characters in a composition.
794
795 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
796
797 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
798 This occurs when processing a multibyte format.
799 Problem reported by Wolfgang Jenker.
800
801 2011-09-15 Johan Bockgård <bojohan@gnu.org>
802
803 * xdisp.c (try_cursor_movement): Only check for exact match if
804 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
805
806 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
807
808 Remove unused external symbols.
809 * dispextern.h (calc_pixel_width_or_height): Remove decl.
810 * xdisp.c (calc_pixel_width_or_height): Now static.
811 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
812 * indent.c (check_display_width):
813 * w32term.c: Fix comment to match code.
814 * xterm.c, xterm.h (x_catching_errors): Remove.
815
816 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
817
818 * xselect.c: Use signed conversions more consistently (Bug#9498).
819 (selection_data_to_lisp_data): Assume incoming selection data are
820 signed integers, not unsigned. This is to be consistent with
821 outgoing selection data, which was modified to use signed integers
822 in as part of the fix to Bug#9196 in response to Jan D.'s comment
823 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
824 expects long, not unsigned long.
825
826 2011-09-14 Eli Zaretskii <eliz@gnu.org>
827
828 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
829 computation of loop end. Reported by Johan Bockgård
830 <bojohan@gnu.org>.
831
832 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
833
834 * frame.c (Fother_visible_frames_p): Function deleted.
835
836 2011-09-12 Eli Zaretskii <eliz@gnu.org>
837
838 * indent.c (compute_motion): Process display vector front to back
839 rather than the other way around. (Bug#2496)
840
841 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
842
843 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
844
845 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
846
847 * minibuf.c (Fread_from_minibuffer): Doc fix.
848
849 2011-09-11 Eli Zaretskii <eliz@gnu.org>
850
851 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
852 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
853
854 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
855
856 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
857 value for non-existent files.
858
859 2011-09-11 Eli Zaretskii <eliz@gnu.org>
860
861 * fileio.c (Finsert_file_contents): If the file cannot be opened,
862 set its "size" to -1. This will set the modtime_size field of
863 the corresponding buffer to -1, which is what
864 verify-visited-file-modtime expects for files that do not exist.
865 (Bug#9139)
866
867 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
868
869 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
870 here ...
871 * lisp.h: ... from here. push_key_description is no longer
872 defined in keyboard.c, so its declaration should not be in
873 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
874 logically belongs with push_key_description.
875
876 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
877
878 * buffer.h: Include <sys/types.h> instead of <time.h>.
879 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
880 Problem reported by Herbert J. Skuhra.
881
882 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
883
884 * xml.c (parse_region): Make the parsing work for
885 non-comment-starting XML files again (bug#9144).
886
887 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
888
889 * image.c (gif_load): Fix calculation of bottom and right corner.
890 (Bug#9468)
891
892 2011-09-10 Eli Zaretskii <eliz@gnu.org>
893
894 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
895 redisplay in small windows.
896
897 2011-09-09 Eli Zaretskii <eliz@gnu.org>
898
899 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
900
901 2011-09-08 Martin Rudalics <rudalics@gmx.at>
902
903 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
904 Operate on live windows only.
905
906 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
907
908 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
909
910 2011-09-07 Eli Zaretskii <eliz@gnu.org>
911
912 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
913 only under bidi iteration.
914
915 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
916
917 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
918
919 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
920
921 isnan: Fix porting problem to Solaris 10 with bundled gcc.
922 Without this fix, the command to link temacs failed due to an
923 undefined symbol __builtin_isnan. This is because
924 /usr/include/iso/math_c99.h #defines isnan(x) to
925 __builtin_isnan(x), but the bundled gcc, which identifies itself
926 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
927 a __builtin_isnan.
928 * floatfns.c (isnan): #undef, and then #define to a clone of
929 what's in data.c.
930 (Fisnan): Always define, since it's always available now.
931 (syms_of_floatfns): Always define isnan at the Lisp level.
932
933 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
934
935 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
936
937 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
938
939 * fileio.c: Fix bugs with large file offsets (Bug#9428).
940 The previous code assumed that file offsets (off_t values) fit in
941 EMACS_INT variables, which is not true on typical 32-bit hosts.
942 The code messed up by falsely reporting buffer overflow in cases
943 such as (insert-file-contents "big" nil 1 2) into an empty buffer
944 when "big" contains more than 2**29 bytes, even though this
945 inserts just one byte and does not overflow the buffer.
946 (Finsert_file_contents): Store file offsets as off_t
947 values, not as EMACS_INT values. Check for overflow when
948 converting between EMACS_INT and off_t. When checking for
949 buffer overflow or for overlap, take the offsets into account.
950 Don't use EMACS_INT for small values where int suffices.
951 When checking for overlap, fix a typo: ZV was used where
952 ZV_BYTE was intended.
953 (Fwrite_region): Don't assume off_t fits into 'long'.
954 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
955
956 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
957
958 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
959
960 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
961
962 sprintf-related integer and memory overflow issues (Bug#9412).
963
964 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
965 (esprintf, exprintf, evxprintf): New functions.
966 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
967 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
968 (modify_event_symbol): Do not assume that the length of
969 name_alist_or_stem is safe to alloca and fits in int.
970 (Fexecute_extended_command): Likewise for function name and binding.
971 (Frecursion_depth): Wrap around reliably on integer overflow.
972 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
973 since some callers pass EMACS_INT values.
974 (Fsingle_key_description): Don't crash if symbol name contains more
975 than MAX_ALLOCA bytes.
976 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
977 (get_minibuffer): Arg is now EMACS_INT, not int.
978 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
979 (esprintf, exprintf, evxprintf): New decls.
980 * window.h (command_loop_level, minibuf_level): Reflect API changes.
981
982 * dbusbind.c (signature_cat): New function.
983 (xd_signature, Fdbus_register_signal):
984 Do not overrun buffer; instead, report string overflow.
985
986 * dispnew.c (add_window_display_history): Don't overrun buffer.
987 Truncate instead; this is OK since it's just a log.
988
989 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
990 even if the time zone offset is outlandishly large.
991 Don't mishandle offset == INT_MIN.
992
993 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
994 when creating daemon; the previous buffer-overflow check was incorrect.
995
996 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
997 which has the guts of the old verror function.
998
999 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1000 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1001
1002 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1003 (font_unparse_xlfd): Don't blindly alloca long strings.
1004 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
1005 fits in int, when using sprintf. Use single snprintf to count
1006 length of string rather than counting it via multiple sprintfs;
1007 that's simpler and more reliable.
1008 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1009 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1010 sprintf, in case result does not fit in int.
1011
1012 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1013 (fontset_from_font): Print it.
1014
1015 * frame.c (tty_frame_count): Now printmax_t, not int.
1016 (make_terminal_frame, set_term_frame_name): Print it.
1017 (x_report_frame_params): In X, window IDs are unsigned long,
1018 not signed long, so print them as unsigned.
1019 (validate_x_resource_name): Check for implausibly long names,
1020 and don't assume name length fits in 'int'.
1021 (x_get_resource_string): Don't blindly alloca invocation name;
1022 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1023 not fit in int.
1024
1025 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1026 (xg_check_special_colors, xg_set_geometry):
1027 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1028
1029 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1030 Use esprintf, not sprintf, in case result does not fit in int.
1031
1032 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1033 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1034 it as a large positive number.
1035 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1036 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1037
1038 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1039 in case result does not fit in int.
1040
1041 * print.c (float_to_string): Detect width overflow more reliably.
1042 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1043 buffer overrun. Don't assume list length fits in 'int'. Treat
1044 print length of 0 as 0, not as infinity; to be consistent with other
1045 uses of print length in this function. Don't overflow print length
1046 index. Don't assume hash table size fits in 'long', or that
1047 vectorlike size fits in 'unsigned long'.
1048
1049 * process.c (make_process): Use printmax_t, not int, to format
1050 process-name gensyms.
1051
1052 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1053
1054 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1055 to avoid potential buffer overrun.
1056
1057 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1058 if X resource line is longer than 512 bytes.
1059
1060 * xfns.c (x_window): Make sprintf buffer a bit bigger
1061 to avoid potential buffer overrun.
1062
1063 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1064
1065 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1066
1067 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1068
1069 Integer overflow fixes for scrolling, etc.
1070 Without these, Emacs silently mishandles large integers sometimes.
1071 For example, "C-u 4294967297 M-x recenter" was treated as if
1072 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1073
1074 * xdisp.c (try_window_id): Check Emacs fixnum range before
1075 converting to 'int'.
1076
1077 * window.c (window_scroll_line_based, Frecenter):
1078 Check that an Emacs fixnum is in range before assigning it to 'int'.
1079 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1080 values converted from Emacs fixnums.
1081 (Frecenter): Don't wrap around a line count if it is out of 'int'
1082 range; instead, treat it as an extreme value.
1083 (Fset_window_configuration, compare_window_configurations):
1084 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1085
1086 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1087 that can exceed INT_MAX. Check that EMACS_INT value is in range
1088 before assigning it to the (possibly-narrower) index.
1089 (match_limit): Don't assume that a fixnum can fit in 'int'.
1090
1091 * print.c (print_object): Use ptrdiff_t, not int, for index that can
1092 exceed INT_MAX.
1093
1094 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
1095 (Fvertical_motion): Don't wrap around LINES values that don't fit
1096 in 'int'. Instead, treat them as extreme values. This is good
1097 enough for windows, which can't have more than INT_MAX lines anyway.
1098
1099 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1100
1101 * Require libxml/parser.h to avoid compilation warning.
1102
1103 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1104
1105 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1106 since this reportedly can destroy thread storage.
1107
1108 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
1109
1110 * syntax.c (find_defun_start): Update all cache variables if
1111 exiting early (Bug#9401).
1112
1113 2011-08-30 Eli Zaretskii <eliz@gnu.org>
1114
1115 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1116
1117 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1118 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1119 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1120
1121 * term.c (tty_append_glyph): New function.
1122 (produce_stretch_glyph): Static function and its prototype deleted.
1123
1124 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1125 Add prototypes.
1126
1127 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1128
1129 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1130 when checking :margin (Bug#9390).
1131 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
1132 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
1133 so that the name doesn't mislead. All uses changed.
1134
1135 2011-08-28 Johan Bockgård <bojohan@gnu.org>
1136
1137 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1138 set_tty_hooks.
1139
1140 2011-08-27 Eli Zaretskii <eliz@gnu.org>
1141
1142 * xdisp.c (move_it_to): Don't bail out early when reaching
1143 position beyond to_charpos, if we are scanning backwards.
1144 (move_it_vertically_backward): When DY == 0, make sure we get to
1145 the first character in the line after the newline.
1146
1147 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1148
1149 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1150 (ccl_driver): Do not generate an out-of-range pointer.
1151 (Fccl_execute_on_string): Remove unnecessary check for
1152 integer overflow, noted by Stefan Monnier in
1153 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1154 Remove a FIXME that didn't need fixing.
1155 Simplify the newly-introduced buffer reallocation code.
1156
1157 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
1158
1159 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1160
1161 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
1162
1163 Integer and memory overflow issues (Bug#9196).
1164
1165 * doc.c (get_doc_string): Rework so that
1166 get_doc_string_buffer_size is the actual buffer size, rather than
1167 being 1 less than the actual buffer size; this makes xpalloc more
1168 convenient.
1169
1170 * image.c (x_allocate_bitmap_record, cache_image):
1171 * xselect.c (Fx_register_dnd_atom):
1172 Simplify previous changes by using xpalloc.
1173
1174 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1175 since either will do and ptrdiff_t is convenient with xpalloc.
1176
1177 * charset.c (charset_table_size)
1178 (struct charset_sort_data.priority): Now ptrdiff_t.
1179 (charset_compare): Don't overflow if priorities differ greatly.
1180 (Fsort_charsets): Don't assume list length fits in int.
1181 Check for size-calculation overflow when allocating sort data.
1182 (syms_of_charset): Allocate an initial charset table that is
1183 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1184
1185 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1186
1187 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1188 The actual value is always <= INT_MAX, and leaving it unsigned made
1189 overflow checking harder.
1190
1191 * dispextern.h (struct glyph_matrix.rows_allocated)
1192 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1193 with xpalloc. The values are still always <= INT_MAX.
1194
1195 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1196
1197 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1198 (SAFE_NALLOCA): New macro.
1199
1200 * region-cache.c (struct boundary.pos, find_cache_boundary)
1201 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1202 (set_cache_region, invalidate_region_cache)
1203 (revalidate_region_cache, know_region_cache, region_cache_forward)
1204 (region_cache_backward, pp_cache):
1205 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1206 so that ptrdiff_t * can be passed to xpalloc.
1207 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1208 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1209 (pp_cache): Don't assume cache_len fits in int.
1210 * region-cache.h: Adjust extern decls to match.
1211
1212 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1213 EMACS_INT, since either will do, for xpalloc.
1214
1215 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1216 (xnmalloc, xnrealloc, xpalloc): New functions.
1217
1218 * bidi.c (bidi_shelve_header_size): New constant.
1219 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1220 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1221
1222 * bidi.c (bidi_cache_shrink):
1223 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1224 (overlay_strings):
1225 Don't update size of array until after memory allocation succeeds,
1226 because xmalloc/xrealloc may not return.
1227 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1228 now that we have proper integer overflow checking.
1229 (record_overlay_string, overlay_strings): Catch overflows when
1230 calculating size of overlay_str_buf.
1231
1232 * callproc.c (Fcall_process): Check for size overflow when
1233 calculating size of args2.
1234 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1235 Normally we prefer signed values, but sticking with ptrdiff_t would
1236 require adding more-complicated checks.
1237
1238 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1239 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1240 Redo buffer-overflow calculations to avoid integer overflow.
1241 Add a FIXME comment where memory seems to be over-allocated.
1242
1243 * character.c (Fstring): Check for size-calculation overflow.
1244
1245 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1246 unnecessary integer overflow. Check for size overflow.
1247 (encode_coding_object): Don't update size until xmalloc succeeds.
1248
1249 * composite.c (get_composition_id): Check for overflow in glyph
1250 length calculations.
1251
1252 Integer and memory overflow fixes for display code.
1253 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1254 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1255 (scrolling_window): Check for overflow in size calculations.
1256 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1257 Don't assume glyph table len fits in int.
1258 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1259 (row_table_size): Now ptrdiff_t, not int.
1260 (scrolling_window): Avoid overflow in size calculations.
1261 Don't update size until allocation succeeds.
1262 * fns.c (concat): Check for overflow in size calculations.
1263 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1264 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1265 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1266
1267 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1268 (get_doc_string): Check for size calculation overflow.
1269 Don't update size until allocation succeeds.
1270 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1271 EMACS_INT, where ptrdiff_t will do.
1272 (Fsubstitute_command_keys): Check for string overflow.
1273
1274 * editfns.c (set_time_zone_rule): Don't assume environment length
1275 fits in int.
1276 (message_length): Now ptrdiff_t, not int.
1277 (Fmessage_box): Don't update size until allocation succeeds.
1278 Don't assume message length fits in int.
1279 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1280
1281 * emacs.c (main): Do not reallocate argv, since there is a null at
1282 the end that can be overwritten, and this way there's no need to
1283 worry about size-calculation overflow.
1284 (sort_args): Check for size-calculation overflow.
1285
1286 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1287 alloc succeeds.
1288 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1289
1290 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1291 (x_set_scroll_bar_width, x_figure_window_size):
1292 Check for integer overflow.
1293 (x_set_alpha): Do not assume XINT fits in int.
1294
1295 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1296 This is for the members text_lines, text_cols, total_lines, total_cols,
1297 where the system imposes an 'int' limit.
1298
1299 * fringe.c (Fdefine_fringe_bitmap):
1300 Don't update size until alloc works.
1301
1302 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1303 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1304
1305 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1306 Check for size-calculation overflow.
1307 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1308 do, as we prefer signed integers.
1309 (id_to_widget.max_size, id_to_widget.used)
1310 (xg_store_widget_in_map, xg_remove_widget_from_map)
1311 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1312 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1313 Use and return ptrdiff_t, not int.
1314 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1315 * gtkutil.h: Change prototypes to match the above.
1316
1317 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1318 are duplicate now that they've been promoted to lisp.h.
1319 (x_allocate_bitmap_record, x_alloc_image_color)
1320 (make_image_cache, cache_image, xpm_load):
1321 Don't update size until alloc is done.
1322 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1323 (x_detect_edges):
1324 Check for size calculation overflow.
1325 (ct_colors_allocated_max): New constant.
1326 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1327 overflow.
1328
1329 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1330 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1331 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1332 Use ptrdiff_t, not int, to count maps.
1333 (read_char_minibuf_menu_prompt): Check for overflow in size
1334 calculations. Don't update size until allocation succeeds.
1335 Redo calculations to avoid overflow.
1336 * keyboard.h: Change prototypes to match the above.
1337
1338 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1339 to count maps.
1340 (current_minor_maps): Check for size calculation overflow.
1341 * keymap.h: Change prototypes to match the above.
1342
1343 * lread.c (read1, init_obarray): Don't update size until alloc done.
1344
1345 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1346 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1347
1348 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1349 Now ptrdiff_t, not int.
1350 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1351 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1352
1353 * process.c (Fnetwork_interface_list): Check for overflow
1354 in size calculation.
1355
1356 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1357
1358 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1359 overflow. Don't bother calling xmalloc when xrealloc will do.
1360
1361 * search.c (Freplace_match): Check for size calculation overflow.
1362 (Fset_match_data): Don't assume list lengths fit in 'int'.
1363
1364 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1365 for command line length. Do not attempt to address one before the
1366 beginning of an array, as that's not portable.
1367
1368 * term.c (max_frame_lines): Remove; unused.
1369 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1370 not int.
1371 (encode_terminal_code, calculate_costs): Check for size
1372 calculation overflow.
1373 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1374 table lengths and related sizes. Don't update size until alloc
1375 done. Redo calculations to avoid overflow.
1376 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1377
1378 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1379 subtracting pointers.
1380 (gobble_line): Check for overflow more carefully. Don't update size
1381 until alloc done.
1382
1383 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1384 Don't update size until alloc done.
1385 Redo size calculations to avoid overflow.
1386 Check for size calculation overflow.
1387 (main) [DEBUG]: Fix typo in invoking tparam1.
1388
1389 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1390 Use ptrdiff_t, not int, for sizes.
1391 (store_mode_line_noprop_char): Don't update size until alloc done.
1392
1393 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1394 Use ptrdiff_t, not int, for sizes.
1395 (Finternal_make_lisp_face, cache_face):
1396 Check for size calculation overflow.
1397 (cache_face): Treat size calculation overflows as if they were
1398 memory exhaustion (the usual treatment), rather than aborting.
1399
1400 * xfns.c (x_encode_text, x_set_name_internal)
1401 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1402 sizes, since they can exceed INT_MAX in size. Check for size
1403 calculation overflow.
1404
1405 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1406 (xg_select): Check for size calculation overflow.
1407 Don't update size until alloc done.
1408
1409 * xrdb.c (get_environ_db): Don't assume path length fits in int,
1410 as sprintf is limited to int lengths.
1411
1412 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1413 (X_LONG_MIN): New macros.
1414 Use them to make the following changes clearer.
1415 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1416 This change doesn't affect the value now, but it may help remind
1417 future maintainers not to raise the value too much later.
1418 (SELECTION_QUANTUM): Remove, replacing with ...
1419 (selection_quantum): ... new function, which avoids overflow.
1420 All uses changed.
1421 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1422 assumption that selection length fits in 'int'.
1423 (x_reply_selection_request, x_handle_selection_request)
1424 (x_get_window_property, receive_incremental_selection)
1425 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1426 (lisp_data_to_selection_data, clean_local_selection_data):
1427 Use ptrdiff_t, not int, to record length of selection.
1428 (x_reply_selection_request, x_get_window_property)
1429 (receive_incremental_selection, x_property_data_to_lisp):
1430 Redo calculations to avoid overflow.
1431 (x_reply_selection_request): When sending hint, ceiling it at
1432 X_LONG_MAX rather than relying on wraparound overflow to send
1433 something.
1434 (x_get_window_property, receive_incremental_selection)
1435 (lisp_data_to_selection_data, x_property_data_to_lisp):
1436 Check for size-calculation overflow.
1437 (x_get_window_property, receive_incremental_selection)
1438 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1439 Don't store size until memory allocation succeeds.
1440 (x_get_window_property): Plug memory leak on memory exhaustion.
1441 Don't double-block input; malloc is safe here. Don't assume 2**34
1442 - 4 fits in unsigned long. Add an xassert to check
1443 XGetWindowProperty overflow. Be more careful about overflow
1444 calculations, and distinguish size from memory overflow better.
1445 (receive_incremental_selection): When tracing, don't assume
1446 unsigned int is less than INT_MAX.
1447 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1448 harmful) conversions of unsigned short to int.
1449 (lisp_data_to_selection_data): Don't assume that integers
1450 in the range -65535 through -1 fit in an X unsigned short.
1451 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1452 result parameters unless successful. Rely on cons_to_unsigned
1453 to report problems with elements; the old code wasn't right anyway.
1454 (x_check_property_data): Check for int overflow; we cannot use
1455 a wider type due to X limits.
1456 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1457
1458 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
1459
1460 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1461 (x_term_init): Check for size calculation overflow.
1462 (x_color_cells): Don't store size until memory allocation succeeds.
1463 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
1464 Don't assume alloca size is less than MAX_ALLOCA.
1465 (x_term_init): Don't assume length fits in int (sprintf is limited
1466 to int size).
1467
1468 Use ptrdiff_t for composition IDs.
1469 * character.c (lisp_string_width):
1470 * composite.c (composition_table_size, n_compositions)
1471 (get_composition_id, composition_gstring_from_id):
1472 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1473 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1474 * window.c (Frecenter):
1475 Use ptrdiff_t, not int, for composition IDs.
1476 * composite.c (get_composition_id): Check for integer overflow.
1477 * composite.h: Adjust prototypes to match the above changes.
1478
1479 Use ptrdiff_t for hash table indexes.
1480 * category.c (hash_get_category_set):
1481 * ccl.c (ccl_driver):
1482 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1483 * coding.c (coding_system_charset_list, detect_coding_system):
1484 * coding.h (struct coding_system.id):
1485 * composite.c (get_composition_id, gstring_lookup_cache):
1486 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1487 * image.c (xpm_get_color_table_h):
1488 * lisp.h (hash_lookup, hash_put):
1489 * minibuf.c (Ftest_completion):
1490 Use ptrdiff_t for hash table indexes, not int (which is too
1491 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1492 32-bit --with-wide-int hosts).
1493
1494 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1495 Add a FIXME comment about memory leaks.
1496 (syms_of_charset): Don't assume xmalloc returns.
1497
1498 Don't assume that stated character widths fit in int.
1499 * character.c (Fchar_width, c_string_width, lisp_string_width):
1500 * character.h (CHAR_WIDTH):
1501 * indent.c (MULTIBYTE_BYTES_WIDTH):
1502 Use sanitize_char_width to avoid undefined and/or bad behavior
1503 with outlandish widths.
1504 * character.h (sanitize_tab_width): Rename from sanitize_width,
1505 now that we have two such functions. All uses changed.
1506 (sanitize_char_width): New inline function.
1507
1508 Don't assume that tab-width fits in int.
1509 * character.h (sanitize_width): New inline function.
1510 (SANE_TAB_WIDTH): New macro.
1511 (ASCII_CHAR_WIDTH): Use it.
1512 * indent.c (sane_tab_width): Remove. All uses replaced by
1513 SANE_TAB_WIDTH (current_buffer).
1514 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1515
1516 * fileio.c: Integer overflow issues with file modes.
1517 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1518
1519 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1520 Remove unreachable code.
1521 (read_hex, load_charset_map_from_file): Check for integer overflow.
1522
1523 * xterm.c: don't go over XClientMessageEvent limit
1524 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1525 (x_send_scroll_bar_event): Likewise. Check that the size does not
1526 exceed limits imposed by XClientMessageEvent, as well as the usual
1527 ptrdiff_t and size_t limits.
1528
1529 * keyboard.c: Overflow, signedness and related fixes.
1530 (make_lispy_movement): Use same integer type in forward decl
1531 that is used in the definition.
1532 (read_key_sequence, keyremap_step):
1533 Change bufsize argument back to int, undoing my 2011-03-30 change.
1534 We prefer signed types, and int is wide enough here.
1535 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1536 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1537 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1538 length, not size_t. Use ptrdiff_t for index, not int.
1539 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1540 possibility of integer overflow.
1541
1542 Overflow, signedness and related fixes for images.
1543
1544 * dispextern.h (struct it.stack[0].u.image.image_id)
1545 (struct_it.image_id, struct image.id, struct image_cache.size)
1546 (struct image_cache.used, struct image_cache.ref_count):
1547 * gtkutil.c (update_frame_tool_bar):
1548 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1549 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1550 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1551 * nsmenu.m (update_frame_tool_bar):
1552 * xdisp.c (calc_pixel_width_or_height):
1553 * xfns.c (image_cache_refcount):
1554 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1555 on typical 64-bit hosts.
1556
1557 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1558 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1559 Omit unnecessary casts to int.
1560 (parse_image_spec): Check that integers fall into 'int' range
1561 when the callers expect that.
1562 (image_ascent): Redo ascent calculation to avoid int overflow.
1563 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1564 (lookup_image): Remove unnecessary tests.
1565 (xbm_image_p): Locals are now of int, not EMACS_INT,
1566 since parse_image_check makes sure they fit into int.
1567 (png_load, gif_load, svg_load_image):
1568 Prefer int to unsigned where either will do.
1569 (tiff_handler): New function, combining the cores of the
1570 old tiff_error_handler and tiff_warning_handler.
1571 This function is rewritten to use vsnprintf and thereby avoid
1572 stack buffer overflows. It uses only the features of vsnprintf
1573 that are common to both POSIX and native Microsoft.
1574 (tiff_error_handler, tiff_warning_handler): Use it.
1575 (tiff_load, gif_load, imagemagick_load_image):
1576 Don't assume :index value fits in 'int'.
1577 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1578 (imagemagick_load_image): Check that crop parameters fit into
1579 the integer types that MagickCropImage accepts. Don't assume
1580 Vimagemagick_render_type has a nonnegative value. Don't assume
1581 size_t fits in 'long'.
1582 (gs_load): Use printmax_t to print the widest integers possible.
1583 Check for integer overflow when computing image height and width.
1584
1585 2011-08-26 Eli Zaretskii <eliz@gnu.org>
1586
1587 * xdisp.c (redisplay_window): Don't force window start if point
1588 will be invisible in the resulting window. (Bug#9324)
1589
1590 2011-08-25 Eli Zaretskii <eliz@gnu.org>
1591
1592 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1593 the display spec is of the form `(space ...)'.
1594 (handle_display_spec): Return the value returned by
1595 handle_single_display_spec, not just 1 or zero.
1596 (handle_single_display_spec): If the display spec is of the form
1597 `(space ...)', and specifies display in the text area, return 2
1598 rather than 1.
1599 (try_cursor_movement): Check for the need to scroll more
1600 accurately, and prefer exact match for point under bidi.
1601 Don't advance `row' beyond the last row of the window.
1602
1603 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1604 into disp_prop; all users changed.
1605
1606 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1607 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1608 for the text covered by the display property.
1609
1610 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
1611
1612 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1613 Change return value to nil.
1614 (Frecord_buffer): Delete unused function.
1615
1616 2011-08-24 Eli Zaretskii <eliz@gnu.org>
1617
1618 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1619 buffers, return left-to-right.
1620 (set_cursor_from_row): Consider candidate row a win if its glyph
1621 represents a newline and point is on that newline. Fixes cursor
1622 positioning on the newline at EOL of R2L text within L2R
1623 paragraph, and vice versa.
1624 (try_cursor_movement): Check continued rows, in addition to
1625 continuation rows. Fixes unwarranted scroll when point enters a
1626 continued line of R2L text within an L2R paragraph, or vice versa.
1627 (cursor_row_p): Consider the case of point being equal to
1628 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1629 from the end of a short line to the beginning of a continued line
1630 of R2L text within L2R paragraph.
1631 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1632 composed characters.
1633
1634 * bidi.c (bidi_check_type): Use xassert.
1635 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1636 members.
1637
1638 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1639
1640 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1641 a character.
1642
1643 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
1644
1645 * nsfont.m (ns_otf_to_script): Fix typo.
1646
1647 2011-08-22 Kenichi Handa <handa@m17n.org>
1648
1649 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1650 extra slot even if the purpose is char-code-property-table.
1651
1652 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1653
1654 * xdisp.c (redisplay_window): When computing centering_position,
1655 account for the height of the header line. (Bug#8874)
1656
1657 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1658 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1659 candidate is selected by the mouse, and that candidate has a
1660 composed character under the mouse.
1661
1662 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1663 coordinates reported by pos-visible-in-window-p for a composed
1664 character in column zero.
1665
1666 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1667
1668 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1669
1670 2011-08-22 Eli Zaretskii <eliz@gnu.org>
1671
1672 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1673 consider it a hit if to_charpos is anywhere in the range of the
1674 composed buffer positions.
1675
1676 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
1677
1678 * image.c (gif_load): Don't assume that each subimage has the same
1679 dimensions as the base image. Handle disposal method that is
1680 "undefined" by the gif spec (Bug#9335).
1681
1682 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
1683
1684 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
1685 (Fcondition_case): Document `debug' symbol in error handler.
1686
1687 2011-08-19 Eli Zaretskii <eliz@gnu.org>
1688
1689 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1690 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1691 from an Org mode buffer to a Speedbar frame.
1692
1693 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1694 a composition, take its buffer position from IT->cmp_it.charpos.
1695 Fixes cursor positioning at the beginning of a line that begins
1696 with a composed character.
1697
1698 2011-08-18 Eli Zaretskii <eliz@gnu.org>
1699
1700 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1701 character bidirectional type, use STRONG_L instead. Fixes crashes
1702 in a buffer produced by `describe-categories'.
1703
1704 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1705 members before the level stack, so they would be saved and
1706 restored when copying iterator state. Fixes incorrect reordering
1707 around TABs covered by display properties.
1708
1709 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1710
1711 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
1712
1713 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
1714
1715 * eval.c (internal_condition_case, internal_condition_case_1)
1716 (internal_condition_case_2, internal_condition_case_n):
1717 Remove unnecessary aborts (Bug#9081).
1718
1719 2011-08-17 Eli Zaretskii <eliz@gnu.org>
1720
1721 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1722 has no `load' handler, try opening the file locally. (Bug#9311)
1723
1724 2011-08-16 Ken Brown <kbrown@cornell.edu>
1725
1726 * gmalloc.c: Expand comment.
1727
1728 2011-08-16 Eli Zaretskii <eliz@gnu.org>
1729
1730 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1731 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1732
1733 2011-08-16 Ken Brown <kbrown@cornell.edu>
1734
1735 Fix memory allocation problems in Cygwin build (Bug#9273).
1736
1737 * unexcw.c ( __malloc_initialized): Declare external variable.
1738 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1739
1740 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1741 New variables.
1742 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1743 dumped emacs.
1744 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1745 in the static heap.
1746 [CYGWIN] (special_realloc): New function.
1747 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1748 requests to realloc storage in the static heap.
1749
1750 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1751
1752 * bidi.c (bidi_initialize): Remove unused local.
1753
1754 2011-08-15 Eli Zaretskii <eliz@gnu.org>
1755
1756 * bidimirror.h:
1757 * biditype.h: Remove file.
1758 * makefile.w32-in ($(BLD)/bidi.$(O)):
1759 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
1760
1761 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1762
1763 * chartab.c: Improve commentary for the uniprop_table API.
1764
1765 * bidi.c (bidi_paragraph_init): Support zero value of
1766 bidi_ignore_explicit_marks_for_paragraph_level.
1767 (bidi_initialize): Use uniprop_table instead of including
1768 biditype.h and bidimirror.h.
1769
1770 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1771 coordinates of the iterator when restoring from ppos_it.
1772 (Bug#9296)
1773
1774 2011-08-14 Kenichi Handa <handa@m17n.org>
1775
1776 * process.c (create_process): Call setup_process_coding_systems
1777 after the pid of the process is set to -1 (Bug#8162).
1778
1779 2011-08-14 Eli Zaretskii <eliz@gnu.org>
1780
1781 * xdisp.c (move_it_in_display_line_to): Don't invoke
1782 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1783 ppos_it. Fixes vertical cursor motion when line beginning is
1784 covered by an image. (Bug#9296)
1785
1786 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1787
1788 * nsterm.h (ns_run_ascript): Declare.
1789 (NSAPP_DATA2_RUNASSCRIPT): Define.
1790
1791 * nsfns.m (as_script, as_result, as_status): New static variables.
1792 (ns_run_ascript): New function.
1793 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
1794 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1795 the event loop. Get status from as_status (Bug#7276).
1796
1797 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1798 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1799 the event loop (Bug#7276).
1800
1801 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1802
1803 * gnutls.c (QCgnutls_bootprop_priority)
1804 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1805 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1806 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1807 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1808 (QCgnutls_bootprop_verify_hostname_error)
1809 (QCgnutls_bootprop_callbacks_verify): Rename from
1810 Qgnutls_bootprop_..., all uses changed.
1811
1812 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1813 uses changed.
1814
1815 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1816
1817 * xfaces.c (Qframe_set_background_mode): Now static.
1818 * dispextern.h (Qframe_set_background_mode): Remove decl.
1819
1820 * process.c (Fnetwork_interface_info): Declare local only if needed.
1821
1822 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1823
1824 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1825 (Fnetwork_interface_list): Allocate in increments of bytes instead
1826 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1827 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1828 sockaddr.
1829 (struct ifflag_def): notrailers is smart on OSX.
1830 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1831 Get hardware address with getifaddrs if available.
1832
1833 2011-08-12 Eli Zaretskii <eliz@gnu.org>
1834
1835 * xdisp.c (iterate_out_of_display_property): xassert that
1836 IT->position is set to within IT->object's boundaries. Break from
1837 the loop as soon as EOB is reached; avoids infloops in redisplay
1838 when IT->position is set up wrongly due to some bug.
1839 Set IT->current to match the bidi iterator unconditionally.
1840 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1841 entry. Force push_it to save on the stack the current
1842 buffer/string position, to be restored by pop_it. Fix flags in
1843 the iterator structure wrt the object coming from a display
1844 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1845 properties. (Bug#9284)
1846
1847 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
1848
1849 * fontset.c (fontset_get_font_group): Add proper type checks.
1850 (Bug#9172)
1851
1852 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1853
1854 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1855 and LC_VERSION_MIN_MACOSX.
1856 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1857 (dump_it) [LC_FUNCTION_STARTS]: Use it.
1858
1859 2011-08-08 Eli Zaretskii <eliz@gnu.org>
1860
1861 * xdisp.c (forward_to_next_line_start): Allow to use the
1862 no-display-properties-and-no-overlays under bidi display.
1863 Set disp_pos in the bidi iterator to avoid searches for display
1864 properties and overlays.
1865
1866 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
1867
1868 * editfns.c (Fset_time_zone_rule): Document relationship with the
1869 setenv function.
1870
1871 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1872 the font entity extracted from the cache (Bug#8109).
1873
1874 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
1875
1876 * composite.c (autocmp_chars): Don't reset point. That is done by
1877 restore_point_unwind (Bug#5984).
1878
1879 2011-08-07 Juri Linkov <juri@jurta.org>
1880
1881 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1882 to show the arg `TIME' instead of `TIMEVAL'.
1883
1884 2011-08-06 Eli Zaretskii <eliz@gnu.org>
1885
1886 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1887 display property strides EOL and includes a newline, as in
1888 longlines-mode. (Bug#9254)
1889 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1890 word-wrap under bidirectional display. (Bug#9224)
1891
1892 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1893 is non-zero, even if the data buffer is NULL. Fixes a crash in
1894 vertical-motion with longlines-mode. (Bug#9254)
1895
1896 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1897
1898 * bidi.c <bidi_cache_total_alloc>: Now static.
1899 (bidi_initialize): Initialize bidi_cache_total_alloc.
1900
1901 * xdisp.c (display_line): Release buffer allocated for shelved bidi
1902 cache. (Bug#9221)
1903
1904 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1905 amount allocated this far in `bidi_cache_total_alloc'.
1906 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1907 non-zero, only free the data buffer without restoring the cache
1908 contents. All callers changed.
1909
1910 * dispextern.h (bidi_unshelve_cache): Update prototype.
1911
1912 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1913 (move_it_in_display_line, move_it_to)
1914 (move_it_vertically_backward, move_it_by_lines): Replace the call
1915 to xfree to an equivalent call to bidi_unshelve_cache.
1916 (move_it_in_display_line_to): Fix logic of returning
1917 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
1918
1919 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1920
1921 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1922 came from a string character with a `cursor' property. (Bug#9229)
1923
1924 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1925
1926 * Makefile.in (LIB_PTHREAD): New variable.
1927 (LIBES): Add LIB_PTHREAD (Bug#9216).
1928
1929 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1930 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1931
1932 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1933
1934 * regex.c (re_iswctype): Remove some redundant boolean conversions.
1935
1936 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1937
1938 * xterm.c (x_find_topmost_parent): New function.
1939 (x_set_frame_alpha): Find topmost parent window with
1940 x_find_topmost_parent and set the property there also (bug#9181).
1941 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1942
1943 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1944
1945 * callproc.c (Fcall_process): Avoid vfork clobbering
1946 the local vars buffer, coding_systems, current_dir.
1947
1948 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1949
1950 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1951
1952 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1953
1954 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1955 so that it is not optimized away.
1956
1957 * xdisp.c (compute_display_string_pos): Remove unused local.
1958
1959 2011-08-02 Eli Zaretskii <eliz@gnu.org>
1960
1961 Fix slow cursor motion and scrolling in large buffers with
1962 selective display, like Org Mode buffers. (Bug#9218)
1963
1964 * dispextern.h (struct bidi_it): New member disp_prop_p.
1965
1966 * xdisp.c: Remove one-slot cache of display string positions.
1967 (compute_display_string_pos): Accept an additional argument
1968 DISP_PROP_P; callers changed. Scan at most 5K characters forward
1969 for a display string or property. If found, set DISP_PROP_P
1970 non-zero.
1971
1972 * bidi.c (bidi_fetch_char): Accept an additional argument
1973 DISP_PROP_P, and pass it to compute_display_string_pos.
1974 Only handle text covered by a display string if DISP_PROP_P is returned
1975 non-zero. All callers of bidi_fetch_char changed.
1976
1977 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1978
1979 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1980
1981 2010-12-03 Don March <don@ohspite.net>
1982
1983 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1984 last character M-[char] is translated to ESC [char] (bug#7541).
1985
1986 2011-08-02 Kenichi Handa <handa@m17n.org>
1987
1988 * lisp.h (uniprop_table): Extern it.
1989
1990 * chartab.c (uniprop_table): Make it non-static.
1991
1992 2011-08-01 Eli Zaretskii <eliz@gnu.org>
1993
1994 * xdisp.c (forward_to_next_line_start): Accept additional argument
1995 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1996 on the newline.
1997 (reseat_at_next_visible_line_start): Use the bidi iterator state
1998 returned by forward_to_next_line_start to restore the state of
1999 it->bidi_it after backing up to previous newline. (Bug#9212)
2000
2001 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2002
2003 * regex.c (re_comp): Protoize.
2004 (re_exec): Fix return type.
2005 (regexec): Fix type of `ret'. (Bug#9203)
2006
2007 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2008
2009 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2010 This is needed if max-image-size is a floating-point number.
2011
2012 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2013
2014 * print.c (print_object): Print empty symbol as ##.
2015
2016 * lread.c (read1): Read ## as empty symbol.
2017
2018 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2019
2020 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2021 setting frame foreground color (Bug#9175).
2022 (x_set_background_color): Likewise.
2023
2024 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2025 contents (Bug#9176).
2026 (EmacsTooltip -init): Remove bezels and add shadows to
2027 tooltip windows.
2028
2029 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2030 or scroll bar (Bug#8470).
2031
2032 * nsfont.m (nsfont_open): Remove assignment to voffset and
2033 unnecessary vars hshink, expand, hd, full_height, min_height.
2034 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2035
2036 * nsterm.h (nsfont_info): Remove voffset field.
2037
2038 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2039
2040 Implement strike-through and overline on NextStep (Bug#8863).
2041
2042 * nsfont.m (nsfont_open): Use underline position provided by font,
2043 instead of hard-coded value of 2.
2044 (nsfont_draw): Call ns_draw_text_decoration instead.
2045
2046 * nsterm.h: Add declaration for ns_draw_text_decoration.
2047
2048 * nsterm.m (ns_draw_text_decoration): New function for drawing
2049 underline, overline, and strike-through.
2050 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2051 ns_draw_text_decoration. Change treatment of cursor drawing to
2052 accommodate underlining, etc.
2053
2054 2011-07-28 Eli Zaretskii <eliz@gnu.org>
2055
2056 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2057 default.
2058
2059 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2060
2061 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2062 Without this fix, if a signal arrives just after memory fills up,
2063 'malloc' might be invoked reentrantly.
2064
2065 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2066 In other words, assume that every image size is allowed, on non-X
2067 hosts. This assumption is probably wrong, but it lets Emacs compile.
2068
2069 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2070
2071 * regex.c (re_iswctype): Convert return values to boolean.
2072
2073 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2074
2075 * xdisp.c (compute_display_string_pos): Don't use cached display
2076 string position if the buffer had its restriction changed.
2077 (Bug#9184)
2078
2079 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2080
2081 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2082
2083 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2084
2085 Integer signedness and overflow and related fixes. (Bug#9079)
2086
2087 * bidi.c: Integer size and overflow fixes.
2088 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2089 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2090 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2091 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2092 (bidi_find_other_level_edge):
2093 Use ptrdiff_t instead of EMACS_INT where either will do.
2094 This works better on 32-bit hosts configured --with-wide-int.
2095 (bidi_cache_ensure_space): Check for size-calculation overflow.
2096 Use % rather than repeated addition, for better worst-case speed.
2097 Don't set bidi_cache_size until after xrealloc returns, because it
2098 might not return.
2099 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
2100 (bidi_cache_ensure_space): Also check that the bidi cache size
2101 does not exceed that of the largest Lisp string or buffer. See Eli
2102 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
2103
2104 * alloc.c (__malloc_size_t): Remove.
2105 All uses replaced by size_t. See Andreas Schwab's note
2106 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2107
2108 * image.c: Improve checking for integer overflow.
2109 (check_image_size): Assume that f is nonnull, since
2110 it is always nonnull in practice. This is one less thing to
2111 worry about when checking for integer overflow later.
2112 (x_check_image_size): New function, which checks for integer
2113 overflow issues inside X.
2114 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2115 This removes the need for a memory_full check.
2116 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2117 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2118 (xbm_read_bitmap_data): Change locals back to 'int', since
2119 their values must fit in 'int'.
2120 (xpm_load_image, png_load, tiff_load):
2121 Invoke x_create_x_image_and_pixmap earlier,
2122 to avoid much needless work if the image is too large.
2123 (tiff_load): Treat overly large images as if
2124 x_create_x_image_and_pixmap failed, not as malloc failures.
2125 (gs_load): Use x_check_image_size.
2126
2127 * gtkutil.c: Omit integer casts.
2128 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2129 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2130
2131 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2132
2133 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2134 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2135 would wrongly return t on a 64-bit host.
2136
2137 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2138 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2139 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2140 and therefore cause GCC to emit a bogus diagnostic in some cases.
2141
2142 * image.c: Integer signedness and overflow and related fixes.
2143 This is not an exhaustive set of fixes, but it's time to
2144 record what I've got.
2145 (lookup_pixel_color, check_image_size): Remove redundant decls.
2146 (check_image_size): Don't assume that arbitrary EMACS_INT values
2147 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2148 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2149 (tiff_load, imagemagick_load_image):
2150 Check for overflow in size calculations.
2151 (x_create_x_image_and_pixmap): Remove unnecessary test for
2152 xmalloc returning NULL; that can't happen.
2153 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2154 (xpm_color_bucket): Use better integer hashing function.
2155 (xpm_cache_color): Don't possibly over-allocate memory.
2156 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2157 (gif_memory_source):
2158 Use ptrdiff_t, not int or size_t, to record sizes.
2159 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2160 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2161 either works, as we prefer signed integers.
2162 (tiff_read_from_memory, tiff_write_from_memory):
2163 Return tsize_t, not size_t, since that's what the TIFF API wants.
2164 (tiff_read_from_memory): Don't fail simply because the read would
2165 go past EOF; instead, return a short read.
2166 (tiff_load): Omit no-longer-needed casts.
2167 (Fimagemagick_types): Don't assume size fits into 'int'.
2168
2169 Improve hashing quality when configured --with-wide-int.
2170 * fns.c (hash_string): New function, taken from sxhash_string.
2171 Do not discard information about ASCII character case; this
2172 discarding is no longer needed.
2173 (sxhash-string): Use it. Change sig to match it. Caller changed.
2174 * lisp.h: Declare it.
2175 * lread.c (hash_string): Remove, since we now use fns.c's version.
2176 The fns.c version returns a wider integer if --with-wide-int is
2177 specified, so this should help the quality of the hashing a bit.
2178
2179 * emacs.c: Integer overflow minor fix.
2180 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2181 Define only if GNU_LINUX.
2182 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2183
2184 * dispnew.c: Integer signedness and overflow fixes.
2185 Remove unnecessary forward decls, that were a maintenance hassle.
2186 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2187 All uses changed.
2188 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2189 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2190 (prepare_desired_row, line_draw_cost):
2191 Use int, not unsigned, where either works.
2192 (save_current_matrix, restore_current_matrix):
2193 Use ptrdiff_t, not size_t, where either works.
2194 (init_display): Check for overflow more accurately, and without
2195 relying on undefined behavior.
2196
2197 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2198 Remove, replacing with the new symbols in lisp.h. All uses changed.
2199 * fileio.c (make_temp_name):
2200 * filelock.c (lock_file_1, lock_file):
2201 * xdisp.c (message_dolog):
2202 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2203 Use pMd etc. instead.
2204 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2205 replacing the pWIDE etc. symbols removed from editfns.c.
2206
2207 * keyboard.h (num_input_events): Now uintmax_t.
2208 This is (very slightly) less likely to mess up due to wraparound.
2209 All uses changed.
2210
2211 * buffer.c: Integer signedness fixes.
2212 (alloc_buffer_text, enlarge_buffer_text):
2213 Use ptrdiff_t rather than size_t when either will do, as we prefer
2214 signed integers.
2215
2216 * alloc.c: Integer signedness and overflow fixes.
2217 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2218 (__malloc_size_t): Default to size_t, not to int.
2219 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2220 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2221 Prefer ptrdiff_t to size_t when either would do, as we prefer
2222 signed integers.
2223 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2224 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2225 Now const. Initialize with values that are in range even if char
2226 is signed.
2227 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2228 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2229 These functions do the right thing with sizes > 2**32.
2230 (check_depth): Now ptrdiff_t, not int.
2231 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2232 Adjust to new way of storing sizes. Check for size overflow bugs
2233 in rest of code.
2234 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2235 slightly wrong anyway, as it missed one instance of
2236 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2237 (refill_memory_reserve): Omit needless cast to size_t.
2238 (mark_object_loop_halt): Mark as externally visible.
2239
2240 * xselect.c: Integer signedness and overflow fixes.
2241 (Fx_register_dnd_atom, x_handle_dnd_message):
2242 Use ptrdiff_t, not size_t, since we prefer signed.
2243 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2244 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2245 x_dnd_atoms_size and x_dnd_atoms_length.
2246
2247 * doprnt.c: Prefer signed to unsigned when either works.
2248 * eval.c (verror):
2249 * doprnt.c (doprnt):
2250 * lisp.h (doprnt):
2251 * xdisp.c (vmessage):
2252 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2253 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2254 prefer signed arithmetic to avoid comparison confusion.
2255 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2256 but is a bit tricky.
2257
2258 Assume freestanding C89 headers, string.h, stdlib.h.
2259 * data.c, doprnt.c, floatfns.c, print.c:
2260 Include float.h unconditionally.
2261 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2262 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2263 * regex.c: Likewise for stddef.h, string.h.
2264 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2265 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2266 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2267 (STDC_HEADERS): Remove obsolete defines.
2268 * sysdep.c: Include limits.h unconditionally.
2269
2270 Assume support for memcmp, memcpy, memmove, memset.
2271 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2272 * regex.c (memcmp, memcpy):
2273 Remove; we assume C89 now.
2274
2275 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2276 (__malloc_safe_bcopy): Remove; no longer needed.
2277
2278 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
2279 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2280 well either way, and we prefer signed to unsigned.
2281
2282 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2283
2284 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2285 closes the connection while we're reading (bug#9182).
2286
2287 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
2288
2289 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2290 are specified (Bug#9168).
2291
2292 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2293
2294 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2295 Found by GCC static checking and --with-wide-int on a 32-bit host.
2296
2297 2011-07-25 Eli Zaretskii <eliz@gnu.org>
2298
2299 * xdisp.c (compute_display_string_pos): Fix logic of caching
2300 previous display string position. Initialize cached_prev_pos to
2301 -1. Fixes slow-down at the beginning of a buffer.
2302
2303 2011-07-24 Eli Zaretskii <eliz@gnu.org>
2304
2305 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2306 for attrs[LFACE_FONTSET_INDEX].
2307
2308 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2309
2310 * xml.c (parse_region): Remove unused local
2311 that was recently introduced.
2312
2313 2011-07-23 Eli Zaretskii <eliz@gnu.org>
2314
2315 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2316 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2317
2318 * xdisp.c (move_it_in_display_line_to): Record the best matching
2319 position for TO_CHARPOS while scanning the line, and restore it on
2320 exit if none of the characters scanned was an exact match.
2321 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
2322 when exact match is impossible due to invisible text, and the
2323 lines are truncated.
2324
2325 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2326
2327 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2328 for OSX >= 10.7.
2329
2330 2011-07-22 Eli Zaretskii <eliz@gnu.org>
2331
2332 Fix a significant slow-down of cursor motion with C-n, C-p,
2333 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2334 auto-repeat under bidi redisplay in fontified buffers.
2335 * xdisp.c (compute_stop_pos_backwards): New function.
2336 (next_element_from_buffer): Call compute_stop_pos_backwards to
2337 find a suitable prev_stop when we find ourselves before
2338 base_level_stop.
2339 (reseat): Don't look for prev_stop, as that could mean a very long
2340 run.
2341 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2342 <cached_disp_overlay_modiff>: Cache for last found display string
2343 position.
2344 (compute_display_string_pos): Return the cached position if asked
2345 about the same buffer in the same area of character positions, and
2346 the buffer wasn't changed since the time the display string
2347 position was cached.
2348
2349 2011-07-22 Eli Zaretskii <eliz@gnu.org>
2350
2351 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2352 is an integer, which is important for empty lines. (Bug#9149)
2353
2354 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
2355
2356 * frame.c (Fmodify_frame_parameters): In tty case, update the
2357 default face if necessary (Bug#4238).
2358
2359 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
2360
2361 * editfns.c (Fstring_to_char): No need to explain what a character
2362 is in the docstring (Bug#6576).
2363
2364 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2365
2366 * xml.c (parse_region): Make sure we always return a tree.
2367
2368 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2369
2370 * xml.c (parse_region): If a document contains only comments,
2371 return that, too.
2372
2373 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2374
2375 * xml.c (make_dom): Return comments, too.
2376
2377 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2378
2379 Port to OpenBSD.
2380 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2381 and the surrounding thread.
2382 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2383 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2384 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2385 timer goes off.
2386 * s/openbsd.h (BROKEN_SIGIO): Define.
2387 * unexelf.c (unexec) [__OpenBSD__]:
2388 Don't update the .mdebug section of the Alpha COFF symbol table.
2389
2390 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2391
2392 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2393 (bug#8460).
2394
2395 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2396
2397 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2398 This fixes some race conditions on the permissions of any newly
2399 created file.
2400
2401 * alloc.c (valid_pointer_p): Use pipe, not open.
2402 This fixes some permissions issues when debugging.
2403
2404 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2405 If fchown fails to set both uid and gid, try to set just gid,
2406 as that is sometimes allowed. Adjust the file's mode to eliminate
2407 setuid or setgid bits that are inappropriate if fchown fails.
2408
2409 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2410
2411 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2412 to compare Lisp_Objects.
2413 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2414 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2415 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2416
2417 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2418
2419 * lread.c (read_integer): Unread even EOF character.
2420 (read1): Likewise. Properly record start position of symbol.
2421
2422 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2423 symbol character follows.
2424
2425 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2426
2427 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2428 This works around a problem with the previous change to Fcopy_file.
2429 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2430 and without this change, GCC might complain about discarding
2431 fchown's return value.
2432
2433 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
2434
2435 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2436
2437 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2438
2439 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2440
2441 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2442
2443 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2444 it's used from the C level.
2445
2446 * process.c: Use the same condition for POLL_FOR_INPUT in both
2447 keyboard.c and process.c (bug#1858).
2448
2449 2011-07-09 Lawrence Mitchell <wence@gmx.li>
2450
2451 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2452 (Fgnutls_boot): Use it.
2453
2454 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2455
2456 * doc.c (Fsubstitute_command_keys): Revert last change.
2457
2458 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2459
2460 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2461 quotes the next character, and doesn't affect other longer
2462 sequences (bug#8935).
2463
2464 * lread.c (syms_of_lread): Clarify that is isn't only
2465 `eval-buffer' and `eval-defun' that's affected by
2466 `lexical-binding' (bug#8460).
2467
2468 2011-07-15 Eli Zaretskii <eliz@gnu.org>
2469
2470 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
2471 bidi redisplay when a line includes both an image and is truncated.
2472
2473 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2474
2475 Fix minor problems found by static checking.
2476 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2477 (elsz): Now a signed constant, not a size_t var. We prefer signed
2478 types to unsigned, to avoid integer comparison confusion. Without
2479 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2480 "cannot optimize loop, the loop counter may overflow", a symptom
2481 of the confusion.
2482 * indent.c (Fvertical_motion): Mark locals as initialized.
2483 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2484
2485 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2486
2487 * search.c (Fre_search_backward): Mention `case-fold-search' in
2488 all the re_search_* functions (bug#8138).
2489
2490 * keyboard.c (Fopen_dribble_file): Document when the file is
2491 closed (bug#8056).
2492
2493 2011-07-14 Eli Zaretskii <eliz@gnu.org>
2494
2495 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2496 bidi_cache_idx.
2497
2498 Support bidi reordering of display and overlay strings.
2499 * xdisp.c (compute_display_string_pos)
2500 (compute_display_string_end): Accept additional argument STRING.
2501 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2502 (reseat_to_string): Initialize bidi_it->string.s and
2503 bidi_it->string.schars.
2504 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
2505 NULL (avoids a crash in bidi_paragraph_init).
2506 Initialize itb.string.lstring.
2507 (init_iterator): Call bidi_init_it only of a valid
2508 buffer position was specified. Initialize paragraph_embedding to
2509 L2R.
2510 (reseat_to_string): Initialize the bidi iterator.
2511 (display_string): If we need to ignore text properties of
2512 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2513 original value of -1 will not work with bidi.)
2514 (compute_display_string_pos): First arg is now struct
2515 `text_pos *'; all callers changed. Support display properties on
2516 Lisp strings.
2517 (compute_display_string_end): Support display properties on Lisp
2518 strings.
2519 (init_iterator, reseat_1, reseat_to_string): Initialize the
2520 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2521 when iterating on a string not from display properties).
2522 (compute_display_string_pos, compute_display_string_end):
2523 Fix calculation of the object to scan. Fixes an error when using
2524 arrow keys.
2525 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
2526 base_level_stop; instead, set base_level_stop to BEGV.
2527 Fixes crashes in vertical-motion.
2528 (next_element_from_buffer): Improve commentary for when
2529 the iterator is before prev_stop.
2530 (init_iterator): Initialize bidi_p from the default value of
2531 bidi-display-reordering, not from buffer-local value. Use the
2532 buffer-local value only if initializing for buffer iteration.
2533 (handle_invisible_prop): Support invisible properties on strings
2534 that are being bidi-reordered.
2535 (set_iterator_to_next): Support bidi reordering of C strings and
2536 Lisp strings.
2537 (next_element_from_string): Support bidi reordering of Lisp
2538 strings.
2539 (handle_stop_backwards): Support Lisp strings as well.
2540 (display_string): Support display of R2L glyph rows.
2541 Use IT_STRING_CHARPOS when displaying from a Lisp string.
2542 (init_iterator): Don't initialize it->bidi_p for strings
2543 here.
2544 (reseat_to_string): Initialize it->bidi_p for strings here.
2545 (next_element_from_string, next_element_from_c_string)
2546 (next_element_from_buffer): Add xassert's for correspondence
2547 between IT's object being iterated and it->bidi_it.string
2548 structure.
2549 (face_before_or_after_it_pos): Support bidi iteration.
2550 (next_element_from_c_string): Handle the case of the first string
2551 character that is not the first one in the visual order.
2552 (get_visually_first_element): New function, refactored from common
2553 parts of next_element_from_buffer, next_element_from_string, and
2554 next_element_from_c_string.
2555 (tool_bar_lines_needed, redisplay_tool_bar)
2556 (display_menu_bar): Force left-to-right direction. Add a FIXME
2557 comment for making that be controlled by a user option.
2558 (push_it, pop_it): Save and restore the state of the
2559 bidi iterator. Save and restore the bidi_p flag.
2560 (pop_it): Iterate out of display property for string iteration as
2561 well.
2562 (iterate_out_of_display_property): Support iteration over strings.
2563 (handle_single_display_spec): Set up it->bidi_it for iteration
2564 over a display string, and call bidi_init_it.
2565 (handle_single_display_spec, next_overlay_string)
2566 (get_overlay_strings_1, push_display_prop): Set up the bidi
2567 iterator for displaying display or overlay strings.
2568 (forward_to_next_line_start): Don't use the shortcut if
2569 bidi-iterating.
2570 (back_to_previous_visible_line_start): If handle_display_prop
2571 pushed the iterator stack, restore the internal state of the bidi
2572 iterator by calling bidi_pop_it same number of times.
2573 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2574 and we are bidi-iterating, don't decrement the iterator position;
2575 instead, set the first_elt flag in the bidi iterator, to produce
2576 the same effect.
2577 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2578 (push_display_prop): xassert that we are iterating a buffer.
2579 (push_it, pop_it): Save and restore paragraph_embedding member.
2580 (handle_single_display_spec, next_overlay_string)
2581 (get_overlay_strings_1, reseat_1, reseat_to_string)
2582 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2583 correctly. Don't assume unibyte strings are not bidi-reordered.
2584 (compute_display_string_pos)
2585 (compute_display_string_end): Fix handling the case of C string.
2586 (push_it, pop_it): Save and restore from_disp_prop_p.
2587 (handle_single_display_spec, push_display_prop): Set the
2588 from_disp_prop_p flag.
2589 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2590 (pop_it): Call iterate_out_of_display_property only if we are
2591 popping after iteration over a string that came from a display
2592 property. Fix a typo in popping stretch info. Add an assertion
2593 for verifying that the iterator position is in sync with the bidi
2594 iterator.
2595 (handle_single_display_spec, get_overlay_strings_1)
2596 (push_display_prop): Fix initialization of paragraph direction for
2597 string when that of the parent object is not yet determined.
2598 (reseat_1): Call bidi_init_it to resync the bidi
2599 iterator with IT's position. (Bug#7616)
2600 (find_row_edges): If ROW->start.pos gives position
2601 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2602 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2603 Reset the from_disp_prop_p flag.
2604 (SAVE_IT, RESTORE_IT): New macros.
2605 (pos_visible_p, face_before_or_after_it_pos)
2606 (back_to_previous_visible_line_start)
2607 (move_it_in_display_line_to, move_it_in_display_line)
2608 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2609 (try_scrolling, redisplay_window, display_line): Use them when
2610 saving a temporary copy of the iterator and restoring it back.
2611 (back_to_previous_visible_line_start, reseat_1)
2612 (init_iterator): Empty the bidi cache "stack".
2613 (move_it_in_display_line_to): If iterator ended up at
2614 EOL, but we never saw any buffer positions smaller than
2615 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2616 motion in bidi-reordered lines.
2617 (move_it_in_display_line_to): Record prev_method and prev_pos
2618 immediately before the call to set_iterator_to_next. Fixes cursor
2619 motion in bidi-reordered lines with stretch glyphs and strings
2620 displayed in margins. (Bug#8133) (Bug#8867)
2621 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2622 TO_CHARPOS.
2623 (pos_visible_p): Support positions in bidi-reordered lines.
2624 Save and restore bidi cache.
2625
2626 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2627 (bidi_paragraph_info): Delete unused struct.
2628 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2629 (bidi_cache_start): New variable.
2630 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2631 to zero.
2632 (bidi_cache_fetch_state, bidi_cache_search)
2633 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2634 (bidi_cache_find, bidi_peek_at_next_level)
2635 (bidi_level_of_next_char, bidi_find_other_level_edge)
2636 (bidi_move_to_visually_next): Compare cache index with
2637 bidi_cache_start rather than with zero.
2638 (bidi_fetch_char): Accept new argument STRING; all callers
2639 changed. Support iteration over a string. Support strings with
2640 display properties. Support unibyte strings. Fix the type of
2641 `len' according to what STRING_CHAR_AND_LENGTH expects.
2642 (bidi_paragraph_init, bidi_resolve_explicit_1)
2643 (bidi_resolve_explicit, bidi_resolve_weak)
2644 (bidi_level_of_next_char, bidi_move_to_visually_next):
2645 Support iteration over a string.
2646 (bidi_set_sor_type, bidi_resolve_explicit_1)
2647 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2648 can now be zero (for strings); special values 0 and -1 were
2649 changed to -1 and -2, respectively.
2650 (bidi_char_at_pos): New function.
2651 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2652 Call it instead of FETCH_MULTIBYTE_CHAR.
2653 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2654 initialized to valid values.
2655 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2656 values.
2657 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2658 the test for valid cached positions. Fix the logic for looking up
2659 the sentinel state in the cache. GCPRO the Lisp string we are
2660 iterating.
2661 (bidi_push_it, bidi_pop_it): New functions.
2662 (bidi_initialize): Initialize the bidi cache start stack pointer.
2663 (bidi_cache_ensure_space): New function, refactored from part of
2664 bidi_cache_iterator_state. Don't assume the required size is just
2665 one BIDI_CACHE_CHUNK away.
2666 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2667 (bidi_count_bytes, bidi_char_at_pos): New functions.
2668 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2669 always valid if bidi_cache_idx is valid.
2670 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2671 is valid if it's going to be used.
2672 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2673 (bidi_cache_fetch_state, bidi_cache_search)
2674 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2675 (bidi_cache_iterator_state, bidi_cache_find)
2676 (bidi_find_other_level_edge, bidi_cache_start_stack):
2677 All variables related to cache indices are now EMACS_INT.
2678
2679 * dispextern.h (struct bidi_string_data): New structure.
2680 (struct bidi_it): New member `string'. Make flag members be 1-bit
2681 fields, and put them last in the struct.
2682 (compute_display_string_pos, compute_display_string_end):
2683 Update prototypes.
2684 (bidi_push_it, bidi_pop_it): Add prototypes.
2685 (struct iterator_stack_entry): New members bidi_p,
2686 paragraph_embedding, and from_disp_prop_p.
2687 (struct it): Member bidi_p is now a bit field 1 bit wide.
2688 (bidi_shelve_cache, bidi_unshelve_cache):
2689 Declare prototypes.
2690
2691 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2692 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2693 and vector-like objects.
2694
2695 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2696 cache around display iteration.
2697
2698 * window.c (Fwindow_end, window_scroll_pixel_based)
2699 (displayed_window_lines, Frecenter): Save and restore the bidi
2700 cache around display iteration.
2701
2702 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2703
2704 * editfns.c (Fdelete_region): Clarify the use of the named
2705 parameters (bug#6788).
2706
2707 2011-07-14 Martin Rudalics <rudalics@gmx.at>
2708
2709 * indent.c (Fvertical_motion): Set and restore w->pointm when
2710 saving and restoring the window's buffer (Bug#9006).
2711
2712 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2713
2714 * editfns.c (Fstring_to_char): Clarify just what is returned
2715 (bug#6576). Text by Eli Zaretskii.
2716
2717 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
2718
2719 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2720
2721 2011-07-13 Eli Zaretskii <eliz@gnu.org>
2722
2723 * buffer.c (mmap_find): Fix a typo.
2724
2725 2011-07-13 Johan Bockgård <bojohan@gnu.org>
2726
2727 Fix execution of x selection hooks.
2728 * xselect.c (Qx_lost_selection_functions)
2729 (Qx_sent_selection_functions): New vars.
2730 (syms_of_xselect): DEFSYM them.
2731 (x_handle_selection_request): Pass Qx_sent_selection_functions
2732 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2733 (x_handle_selection_clear,x_clear_frame_selections):
2734 Pass Qx_lost_selection_functions rather than
2735 Vx_lost_selection_functions to Frun_hook_with_args.
2736
2737 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2738
2739 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2740 The old code sometimes used this field without initializing it.
2741
2742 * alloc.c (gc_sweep): Don't read past end of array.
2743 In theory, the old code could also have corrupted Emacs internals,
2744 though it'd be very unlikely.
2745
2746 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2747
2748 * character.c (Fcharacterp): Don't advertise optional ignored
2749 argument. (Bug#4026)
2750
2751 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2752
2753 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2754 key" (bug#4257).
2755
2756 * window.c (Fset_window_start): Doc fix (bug#4199).
2757 (Fset_window_hscroll): Ditto.
2758
2759 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2760
2761 Fix minor new problems caught by GCC 4.6.1.
2762 * term.c (init_tty): Remove unused local.
2763 * xsettings.c (store_monospaced_changed): Define this function only
2764 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
2765 not used otherwise.
2766
2767 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
2768
2769 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2770
2771 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2772
2773 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2774 are the mini-buffer and the echo area (bug#3320).
2775
2776 * term.c (init_tty): Remove support for supdup, c10 and perq
2777 terminals, which are no longer supported (bug#1482).
2778
2779 2011-07-10 Johan Bockgård <bojohan@gnu.org>
2780
2781 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2782
2783 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2784
2785 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2786 for non-popups (Bug#3642).
2787
2788 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2789
2790 * alloc.c (reset_malloc_hooks): Protoize.
2791 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
2792 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2793 * cm.c (losecursor): Likewise.
2794 * data.c (fmod): Likewise.
2795 * dispnew.c (swap_glyphs_in_rows): Likewise.
2796 * emacs.c (memory_warning_signal): Likewise.
2797 * floatfns.c (float_error): Likewise.
2798 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2799 (otf_open, font_otf_capability, generate_otf_features)
2800 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2801 Likewise.
2802 * image.c (pbm_read_file): Likewise.
2803 * indent.c (string_display_width): Likewise.
2804 * intervals.c (check_for_interval, search_for_interval)
2805 (inc_interval_count, count_intervals, root_interval)
2806 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2807 * lread.c (defalias): Likewise.
2808 * ralloc.c (r_alloc_check): Likewise.
2809 * regex.c (set_image_of_range_1, set_image_of_range)
2810 (regex_grow_registers): Likewise.
2811 * sysdep.c (strerror): Likewise.
2812 * termcap.c (valid_filename_p, tprint, main): Likewise.
2813 * tparam.c (main): Likewise.
2814 * unexhp9k800.c (run_time_remap, save_data_space)
2815 (update_file_ptrs, read_header, write_header, calculate_checksum)
2816 (copy_file, copy_rest, display_header): Likewise.
2817 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2818 Likewise.
2819 * xdisp.c (check_it): Likewise.
2820 * xfaces.c (register_color, unregister_color, unregister_colors):
2821 Likewise.
2822 * xfns.c (print_fontset_result): Likewise.
2823 * xrdb.c (member, fatal, main): Likewise.
2824
2825 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2826
2827 Fix minor problems found by static checking (Bug#9031).
2828 * chartab.c (char_table_set_range, map_sub_char_table):
2829 Remove unused locals.
2830 (uniprop_table): Now static.
2831 * composite.c (_work_char): Remove unused static var.
2832
2833 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
2834
2835 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2836
2837 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2838
2839 * gtkutil.c (qttip_cb): Remove code without function.
2840
2841 2011-07-09 Eli Zaretskii <eliz@gnu.org>
2842
2843 * w32.c (pthread_sigmask): New stub.
2844
2845 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
2846
2847 Use pthread_sigmask, not sigprocmask (Bug#9010).
2848 sigprocmask is portable only for single-threaded applications, and
2849 Emacs can be multi-threaded when it uses GTK.
2850 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2851 (LIBES): Use it.
2852 * callproc.c (Fcall_process):
2853 * process.c (create_process):
2854 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2855 Use pthread_sigmask, not sigprocmask.
2856
2857 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2858
2859 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2860 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2861 wrong (Bug#8591).
2862
2863 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2864
2865 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2866 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2867 (xg_hide_tooltip): Fix comment.
2868
2869 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2870 in registerServicesMenuSendTypes.
2871 (validRequestorForSendType): Don't check ns_return_types.
2872
2873 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2874 ns_return_type.
2875
2876 2011-07-08 Jason Rumney <jasonr@gnu.org>
2877
2878 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
2879 SH_SHOW for hidden windows (Bug#5482).
2880
2881 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2882 frame struct members of non-existent frames (Bug#6284).
2883
2884 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2885
2886 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2887 variable firstTime not needed on OSX >= 10.6.
2888 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2889 >= 10.5. Use setKnobProportion, setDoubleValue.
2890
2891 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2892 (MAC_OS_X_VERSION_10_5): Define if not defined.
2893 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2894 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2895 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2896
2897 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2898 cString and lossyCString on OSX >= 10.4
2899
2900 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2901 sizeToFit on OSX >= 10.2.
2902
2903 * nsimage.m (allocInitFromFile): Don't use deprecated method
2904 bestRepresentationForDevice on OSX >= 10.6.
2905
2906 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2907 to avoid warning.
2908
2909 * emacs.c: Declare unexec_init_emacs_zone.
2910
2911 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2912
2913 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2914
2915 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2916 on svcsMenu (Bug#8842).
2917
2918 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2919 ns_return_types.
2920 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2921
2922 * nsterm.m (QUTF8_STRING): Declare.
2923 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2924 (validRequestorForSendType): Return type is (id).
2925 Change indexOfObjectIdenticalTo to indexOfObject.
2926 Check if we have local selection before returning self (Bug#8842).
2927 (writeSelectionToPasteboard): Put local selection into paste board
2928 if we have a local selection (Bug#8842).
2929 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2930
2931 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2932 (ns_get_local_selection): Declare.
2933
2934 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2935
2936 * keymap.c (describe_map_tree): Don't insert a double newline at
2937 the end of the buffer (bug#1169) and return whether we inserted
2938 something.
2939
2940 * callint.c (Fcall_interactively): Change "reading args" to
2941 "providing args" to try to clarify what it does (bug#1010).
2942
2943 2011-07-07 Kenichi Handa <handa@m17n.org>
2944
2945 * composite.c (composition_compute_stop_pos): Ignore a static
2946 composition starting before CHARPOS (Bug#8915).
2947
2948 * xdisp.c (handle_composition_prop): Likewise.
2949
2950 2011-07-07 Eli Zaretskii <eliz@gnu.org>
2951
2952 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2953 (Bug#9015)
2954
2955 2011-07-07 Kenichi Handa <handa@m17n.org>
2956
2957 * character.h (unicode_category_t): New enum type.
2958
2959 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2960 (Qchar_code_property_table): New variable.
2961 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2962 (UNIPROP_COMPRESSED_FORM_P): New macros.
2963 (char_table_ascii): Uncompress the compressed values.
2964 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2965 Uncompress the compressed values.
2966 (sub_char_table_ref_and_range): Likewise.
2967 (char_table_ref_and_range): Uncompress the compressed values.
2968 (sub_char_table_set): New arg is_uniprop. Callers changed.
2969 Uncompress the compressed values.
2970 (sub_char_table_set_range): Args changed. Callers changed.
2971 (char_table_set_range): Adjuted for the above change.
2972 (map_sub_char_table): Delete args default_val and parent. Add arg
2973 top. Give decoded values to a Lisp function.
2974 (map_char_table): Adjust for the above change. Give decoded
2975 values to a Lisp function. Gcpro more variables.
2976 (uniprop_table_uncompress)
2977 (uniprop_decode_value_run_length): New functions.
2978 (uniprop_decoder, uniprop_decoder_count): New variables.
2979 (uniprop_get_decoder, uniprop_encode_value_character)
2980 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2981 New functions.
2982 (uniprop_encoder, uniprop_encoder_count): New variables.
2983 (uniprop_get_encoder, uniprop_table)
2984 (Funicode_property_table_internal, Fget_unicode_property_internal)
2985 (Fput_unicode_property_internal): New functions.
2986 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2987 Sunicode_property_table_internal, Sget_unicode_property_internal,
2988 and Sput_unicode_property_internal. Defvar_lisp
2989 char-code-property-alist.
2990
2991 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
2992 Vunicode_category_table.
2993
2994 * font.c (font_range): Adjust for the change of
2995 Vunicode_category_table.
2996
2997 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2998
2999 * m/iris4d.h: Remove file, move contents ...
3000 * s/irix6-5.h: ... here.
3001
3002 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3003
3004 Remove unportable assumption about struct layout (Bug#8884).
3005 * alloc.c (mark_buffer):
3006 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3007 (clone_per_buffer_values): Don't assume that
3008 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3009 This isn't true in general, and it's particularly not true
3010 if Emacs is configured with --with-wide-int.
3011 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3012 New macros, used in the buffer.c change.
3013
3014 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3015
3016 * xsettings.c: Use both GConf and GSettings if both are available.
3017 (store_config_changed_event): Add comment.
3018 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3019 (store_tool_bar_style_changed): New functions.
3020 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
3021 (struct xsettings): Move font inside HAVE_XFT.
3022 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
3023 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
3024 Move inside HAVE_XFT.
3025 (something_changed_gsettingsCB): Rename from something_changedCB.
3026 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3027 also.
3028 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
3029 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
3030 (something_changed_gconfCB): Rename from something_changedCB.
3031 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3032 (parse_settings): Move check for font inside HAVE_XFT.
3033 (read_settings, apply_xft_settings): Add comment.
3034 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3035 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3036 call store_font_name_changed.
3037 (xft_settings_event): Add comment.
3038 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3039 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3040 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3041 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3042 (xsettings_initialize): Call init_gsettings last.
3043 (xsettings_get_system_font, xsettings_get_system_normal_font):
3044 Add comment.
3045
3046 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3047
3048 Random fixes. E.g., (random) never returned negative values.
3049 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3050 subseconds part to the entropy, as that's a bit more random.
3051 Prefer signed to unsigned, since the signedness doesn't matter and
3052 in general we prefer signed. When given a limit, use a
3053 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3054 latter isn't right if USE_2_TAGS_FOR_INTS.
3055 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3056 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3057
3058 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3059
3060 * textprop.c (text_property_stickiness):
3061 Obey Vtext_property_default_nonsticky.
3062 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3063 * w32fns.c (syms_of_w32fns):
3064 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3065
3066 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3067
3068 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3069 This is more efficient than Ffile_directory_p and avoids a minor race.
3070
3071 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3072
3073 * buffer.c (Foverlay_put): Say what the return value is
3074 (bug#7835).
3075
3076 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3077 is a directory before asking whether to use the file name
3078 (bug#7564).
3079 (barf_or_query_if_file_exists): Make the "File is a directory"
3080 error be more correct.
3081
3082 * fns.c (Frequire): Remove the mention of the .gz files, since
3083 that's installation-specific, but keep the mention of
3084 `get-load-suffixes'.
3085
3086 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3087
3088 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3089 Report string overflow if the output is too long.
3090
3091 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
3092
3093 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3094 (syms_of_gnutls): Remove duplicate DEFSYM for
3095 Qgnutls_bootprop_verify_hostname_error, an error for
3096 Qgnutls_bootprop_verify_error (which is no longer used).
3097
3098 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3099 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3100 Also (re)move comments that are misplaced or no longer relevant.
3101
3102 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3103
3104 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3105
3106 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
3107
3108 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3109 and background color parameters if they have been changed.
3110
3111 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3112
3113 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3114
3115 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3116
3117 * xsettings.c (SYSTEM_FONT): Define only when used.
3118 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3119
3120 * keymap.c (access_keymap_1): Now static.
3121
3122 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
3123
3124 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3125 leave any prefix arg for the up event (Bug#1586).
3126
3127 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3128
3129 * lread.c (syms_of_lread): Mention single symbols defined by
3130 `defvar' or `defconst' (bug#7154).
3131
3132 * fns.c (Frequire): Mention .el.gz files (bug#7314).
3133 (Frequire): Mention get-load-suffixes.
3134
3135 2011-07-02 Martin Rudalics <rudalics@gmx.at>
3136
3137 * window.h (window): Remove clone_number slot.
3138 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3139 Remove.
3140 (make_parent_window, make_window, saved_window)
3141 (Fset_window_configuration, save_window_save): Don't deal with
3142 clone numbers.
3143 * buffer.c (Qclone_number): Remove declaration.
3144 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3145
3146 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3147
3148 Add multiple inheritance to keymaps.
3149 * keymap.c (Fmake_composed_keymap): New function.
3150 (Fset_keymap_parent): Simplify.
3151 (fix_submap_inheritance): Remove.
3152 (access_keymap_1): New function extracted from access_keymap to handle
3153 embedded parents and handle lists of maps.
3154 (access_keymap): Use it.
3155 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3156 (Fcopy_keymap): Handle embedded parents.
3157 (Fcommand_remapping, define_as_prefix): Simplify.
3158 (Fkey_binding): Simplify.
3159 (syms_of_keymap): Move minibuffer-local-completion-map,
3160 minibuffer-local-filename-completion-map,
3161 minibuffer-local-must-match-map, and
3162 minibuffer-local-filename-must-match-map to Elisp.
3163 (syms_of_keymap): Defsubr make-composed-keymap.
3164 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3165 (parse_menu_item): Trivial simplification.
3166
3167 2011-07-01 Glenn Morris <rgm@gnu.org>
3168
3169 * Makefile.in (SETTINGS_LIBS): Fix typo.
3170
3171 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3172
3173 * coding.c (Fencode_coding_string): Record the last coding system
3174 used, as the function doc string says (bug#8738).
3175
3176 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3177
3178 * xsettings.c (store_monospaced_changed): Take new font as arg and
3179 check for change against current_mono_font.
3180 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3181 (emacs_settings_constructor, emacs_settings_get_property)
3182 (emacs_settings_set_property, emacs_settings_class_init)
3183 (emacs_settings_init, gsettings_obj): Remove.
3184 (something_changedCB): New function for HAVE_GSETTINGS.
3185 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3186 with value as argument.
3187 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3188 g_settings_new (Bug#8967). Do not create gsettings_obj.
3189 Remove calls to g_settings_bind. Connect something_changedCB to
3190 "changed".
3191
3192 * xgselect.c: Add defined (HAVE_GSETTINGS).
3193 (xgselect_initialize): Ditto.
3194
3195 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3196 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3197 xg_select.
3198
3199 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3200
3201 * eval.c (struct backtrace): Simplify and port the data structure.
3202 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3203 signed bit field, as this assumption is not portable and it makes
3204 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3205 "char debug_on_exit : 1" as this is not portable either; instead,
3206 use the portable "unsigned int debug_on_exit : 1". Remove unused
3207 member evalargs. Remove obsolete comments about cc bombing out.
3208
3209 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3210
3211 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
3212 Let HAVE_GSETTINGS override HAVE_GCONF.
3213 (store_monospaced_changed): New function.
3214 (EMACS_SETTINGS): A new type derived from GObject to handle
3215 GSettings notifications.
3216 (emacs_settings_constructor, emacs_settings_get_property)
3217 (emacs_settings_set_property, emacs_settings_class_init):
3218 New functions.
3219 (gsettings_client, gsettings_obj): New variables.
3220 (GSETTINGS_SCHEMA): New define.
3221 (something_changedCB): Call store_monospaced_changed.
3222 (init_gsettings): New function.
3223 (xsettings_initialize): Call init_gsettings.
3224 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3225 to NULL.
3226
3227 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
3228 GCONF_CFLAGS/LIBS.
3229
3230 2011-06-29 Martin Rudalics <rudalics@gmx.at>
3231
3232 * window.c (resize_root_window, grow_mini_window)
3233 (shrink_mini_window): Rename Qresize_root_window to
3234 Qwindow_resize_root_window and Qresize_root_window_vertically to
3235 Qwindow_resize_root_window_vertically.
3236
3237 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3238
3239 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3240
3241 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
3242
3243 * makefile.w32-in: Redesign dependencies so they reflect more
3244 clearly which files are directly included by each source file,
3245 and not through other includes.
3246
3247 2011-06-27 Martin Rudalics <rudalics@gmx.at>
3248
3249 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3250 (sort_overlays, overlay_strings): When an overlay's clone number
3251 matches the window's clone number process the overlay even if
3252 the overlay's window property doesn't match the current window.
3253
3254 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3255 (Fwindow_hchild): Rename to Fwindow_left_child.
3256 (Fwindow_next): Rename to Fwindow_next_sibling.
3257 (Fwindow_prev): Rename to Fwindow_prev_sibling.
3258 (resize_window_check): Rename to window_resize_check.
3259 (resize_window_apply): Rename to window_resize_apply.
3260 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3261 (Fdelete_other_windows_internal, resize_frame_windows)
3262 (Fsplit_window_internal, Fdelete_window_internal)
3263 (grow_mini_window, shrink_mini_window)
3264 (Fresize_mini_window_internal): Fix callers accordingly.
3265
3266 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3267
3268 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3269 (emacs_fixed_set_min_size): Remove.
3270 (emacs_fixed_new): Take frame as argument.
3271
3272 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3273 (_EmacsFixedPrivate): Remove minwidth/height.
3274 Add struct frame *f.
3275 (emacs_fixed_init): Initialize priv->f.
3276 (get_parent_class, emacs_fixed_set_min_size): Remove.
3277 (emacs_fixed_new): Set priv->f to argument.
3278 (emacs_fixed_get_preferred_width)
3279 (emacs_fixed_get_preferred_height): Use min_width/height from
3280 frames size_hint to set minimum and natural (Bug#8919).
3281 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3282 and use min_width/height from frames size_hint to set
3283 min_width/height (Bug#8919).
3284
3285 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
3286 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3287 Fix indentation.
3288
3289 2011-06-26 Eli Zaretskii <eliz@gnu.org>
3290
3291 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3292 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3293 called at ZV.
3294
3295 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
3296
3297 * process.c (wait_reading_process_output): Bypass select if
3298 waiting for a cell while ignoring keyboard input, and input is
3299 pending. Suggested by Jan Djärv (Bug#8869).
3300
3301 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3302
3303 Use gnulib's dup2 module instead of rolling our own.
3304 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3305
3306 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3307
3308 * dispnew.c (scrolling_window): Before scrolling, turn off a
3309 mouse-highlight in the window being scrolled.
3310
3311 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
3312
3313 Move DEFSYM to lisp.h and use everywhere.
3314
3315 * character.h (DEFSYM): Move declaration...
3316 * lisp.h (DEFSYM): ...here.
3317
3318 * gnutls.c:
3319 * minibuf.c:
3320 * w32menu.c:
3321 * w32proc.c:
3322 * w32select.c: Don't include character.h.
3323
3324 * alloc.c (syms_of_alloc):
3325 * buffer.c (syms_of_buffer):
3326 * bytecode.c (syms_of_bytecode):
3327 * callint.c (syms_of_callint):
3328 * casefiddle.c (syms_of_casefiddle):
3329 * casetab.c (init_casetab_once):
3330 * category.c (init_category_once, syms_of_category):
3331 * ccl.c (syms_of_ccl):
3332 * cmds.c (syms_of_cmds):
3333 * composite.c (syms_of_composite):
3334 * dbusbind.c (syms_of_dbusbind):
3335 * dired.c (syms_of_dired):
3336 * dispnew.c (syms_of_display):
3337 * doc.c (syms_of_doc):
3338 * editfns.c (syms_of_editfns):
3339 * emacs.c (syms_of_emacs):
3340 * eval.c (syms_of_eval):
3341 * fileio.c (syms_of_fileio):
3342 * fns.c (syms_of_fns):
3343 * frame.c (syms_of_frame):
3344 * fringe.c (syms_of_fringe):
3345 * insdel.c (syms_of_insdel):
3346 * keymap.c (syms_of_keymap):
3347 * lread.c (init_obarray, syms_of_lread):
3348 * macros.c (syms_of_macros):
3349 * msdos.c (syms_of_msdos):
3350 * print.c (syms_of_print):
3351 * process.c (syms_of_process):
3352 * search.c (syms_of_search):
3353 * sound.c (syms_of_sound):
3354 * syntax.c (init_syntax_once, syms_of_syntax):
3355 * terminal.c (syms_of_terminal):
3356 * textprop.c (syms_of_textprop):
3357 * undo.c (syms_of_undo):
3358 * w32.c (globals_of_w32):
3359 * window.c (syms_of_window):
3360 * xdisp.c (syms_of_xdisp):
3361 * xfaces.c (syms_of_xfaces):
3362 * xfns.c (syms_of_xfns):
3363 * xmenu.c (syms_of_xmenu):
3364 * xsettings.c (syms_of_xsettings):
3365 * xterm.c (syms_of_xterm): Use DEFSYM.
3366
3367 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3368
3369 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
3370
3371 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3372
3373 Integer and buffer overflow fixes (Bug#8873).
3374
3375 * print.c (printchar, strout): Check for string overflow.
3376 (PRINTPREPARE, printchar, strout):
3377 Don't set size unless allocation succeeds.
3378
3379 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3380 for sizes. Check for string overflow more accurately.
3381 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3382
3383 * macros.c: Integer and buffer overflow fixes.
3384 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3385 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3386 Use ptrdiff_t, not int, for sizes.
3387 Don't increment bufsize until after realloc succeeds.
3388 Check for size-calculation overflow.
3389 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3390
3391 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3392
3393 * lread.c: Integer overflow fixes.
3394 (read_integer): Radix is now EMACS_INT, not int,
3395 to improve quality of diagnostics for out-of-range radices.
3396 Calculate buffer size correctly for out-of-range radices.
3397 (read1): Check for integer overflow in radices, and in
3398 read-circle numbers.
3399 (read_escape): Avoid int overflow.
3400 (Fload, openp, read_buffer_size, read1)
3401 (substitute_object_recurse, read_vector, read_list, map_obarray):
3402 Use ptrdiff_t, not int, for sizes.
3403 (read1): Use EMACS_INT, not int, for sizes.
3404 Check for size overflow.
3405
3406 * image.c (cache_image): Check for size arithmetic overflow.
3407
3408 * lread.c: Integer overflow issues.
3409 (saved_doc_string_size, saved_doc_string_length)
3410 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3411 Now ptrdiff_t, not int.
3412 (read1): Don't assume doc string length fits in int. Check for
3413 out-of-range doc string lengths.
3414 (read_list): Don't assume file position fits in int.
3415 (read_escape): Check for hex character overflow.
3416
3417 2011-06-22 Leo Liu <sdl.web@gmail.com>
3418
3419 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3420 Move to minibuffer.el.
3421
3422 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3423
3424 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
3425 The following patches are for when GLYPH_DEBUG && !XASSERT.
3426 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3427 * dispnew.c (flush_stdout):
3428 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3429 Mark as externally visible.
3430 * dispnew.c (check_window_matrix_pointers): Now static.
3431 * dispnew.c (window_to_frame_vpos):
3432 * xfns.c (unwind_create_frame):
3433 * xterm.c (x_check_font): Remove unused local.
3434 * scroll.c (CHECK_BOUNDS):
3435 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3436 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3437 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3438 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3439 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3440 Now static.
3441 (debug_method_add): Use va_list and vsprintf rather than relying
3442 on undefined behavior with wrong number of arguments.
3443 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3444 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3445 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3446 since we're not interested in debugging glyphs with old libraries.
3447 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3448 GCC 4.6.0's static checking.
3449
3450 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3451
3452 Integer overflow and signedness fixes (Bug#8873).
3453 A few related buffer overrun fixes, too.
3454
3455 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3456
3457 * dispextern.h (struct face.stipple):
3458 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3459 (x_bitmap_mask, x_allocate_bitmap_record)
3460 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3461 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3462 (x_create_bitmap_from_xpm_data):
3463 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3464 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3465 (.bitmaps_last):
3466 * xfaces.c (load_pixmap):
3467 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3468 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3469 (.bitmaps_last, struct x_output.icon_bitmap):
3470 Use ptrdiff_t, not int, for bitmap indexes.
3471 (x_allocate_bitmap_record): Check for size overflow.
3472 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3473
3474 Use ptrdiff_t, not int, for overlay counts.
3475 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3476 * editfns.c (overlays_around, get_pos_property):
3477 * textprop.c (get_char_property_and_overlay):
3478 * xdisp.c (next_overlay_change, note_mouse_highlight):
3479 * xfaces.c (face_at_buffer_position):
3480 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3481 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3482 (Fnext_overlay_change, Fprevious_overlay_change)
3483 (mouse_face_overlay_overlaps, Foverlays_in):
3484 Use ptrdiff_t, not int, for sizes.
3485 (overlays_at, overlays_in): Check for size-calculation overflow.
3486
3487 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3488
3489 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3490 (x_session_initialize): Do not assume string length fits in int.
3491
3492 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3493 This is unlikely, but can occur if DPI is outlandish.
3494
3495 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3496 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3497
3498 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3499 * xrdb.c (magic_file_p, search_magic_path):
3500 Omit last arg SUFFIX; it was always 0. All callers changed.
3501 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3502
3503 * xfont.c (xfont_match): Avoid need for strlen.
3504
3505 * xfns.c: Don't assume strlen fits in int.
3506 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3507
3508 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3509 not unsigned long, as we prefer signed integers. All callers changed.
3510 Detect integer overflow in repeat count.
3511 (message_dolog): Don't assume print length fits in 39 bytes.
3512 (display_mode_element): Don't assume strlen fits in int.
3513
3514 * termcap.c: Don't assume sizes fit in int and never overflow.
3515 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3516 (gobble_line): Check for size-calculation overflow.
3517
3518 * minibuf.c (Fread_buffer):
3519 * lread.c (intern, intern_c_string):
3520 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3521 Don't assume string length fits in int.
3522
3523 * keyboard.c (parse_tool_bar_item):
3524 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3525
3526 * font.c: Don't assume string length fits in int.
3527 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3528 Use ptrdiff_t, not int.
3529 (font_intern_prop): Don't assume string length fits in int.
3530 Don't assume integer property fits in fixnum.
3531 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
3532
3533 * filelock.c: Fix some buffer overrun and integer overflow issues.
3534 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
3535 Reformulate so as not to need the command string.
3536 Invoke gzip -cd rather than gunzip, as it's more portable.
3537 (lock_info_type, lock_file_1, lock_file):
3538 Don't assume pid_t and time_t fit in unsigned long.
3539 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3540 (current_lock_owner): Prefer signed type for sizes.
3541 Use memcpy, not strncpy, where memcpy is what is really wanted.
3542 Don't assume (via atoi) that time_t and pid_t fit in int.
3543 Check for time_t and/or pid_t out of range, e.g., via a network share.
3544 Don't alloca where an auto var works fine.
3545
3546 * fileio.c: Fix some integer overflow issues.
3547 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3548 Don't assume string length fits in int.
3549 (directory_file_name): Don't assume string length fits in long.
3550 (make_temp_name): Don't assume pid fits in int, or that its print
3551 length is less than 20.
3552
3553 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3554
3555 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3556
3557 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3558
3559 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3560 We prefer signed integers, even for size calculations.
3561
3562 * emacs.c: Don't assume string length fits in 'int'.
3563 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3564 (main): Don't invoke strlen when not needed.
3565
3566 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3567 (XD_DEBUG_MESSAGE): Don't waste a byte.
3568
3569 * callproc.c (getenv_internal_1, getenv_internal)
3570 (Fgetenv_internal):
3571 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3572
3573 * lread.c (invalid_syntax): Omit length argument.
3574 All uses changed. This doesn't fix a bug, but it simplifies the
3575 code away from its former Hollerith-constant appearance, and it's
3576 one less 'int' to worry about when looking at integer-overflow issues.
3577 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
3578
3579 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3580 This didn't break anything, but it didn't help either.
3581 It's confusing to put a bogus integer in a place where the actual
3582 value does not matter.
3583 (LIST_END_P): Remove unused macro and its bogus comment.
3584 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
3585
3586 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3587 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3588 implementation.
3589 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3590 We prefer signed types, and the value cannot exceed the EMACS_INT
3591 range anyway (because otherwise the length would not be representable).
3592 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3593 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3594 This avoids a GCC warning when WIDE_EMACS_INT.
3595
3596 * indent.c (sane_tab_width): New function.
3597 (current_column, scan_for_column, Findent_to, position_indentation)
3598 (compute_motion): Use it. This is just for clarity.
3599 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
3600
3601 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
3602
3603 * lisp.h (lint_assume): New macro.
3604 * composite.c (composition_gstring_put_cache):
3605 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3606
3607 * editfns.c, insdel.c:
3608 Omit unnecessary forward decls, to simplify future changes.
3609
3610 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3611
3612 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3613
3614 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
3615 Use much-faster test for byte-length change.
3616 Don't assume string byte-length fits in 'int'.
3617 Check that character arg fits in 'int'.
3618 (mapcar1): Declare byte as byte, for clarity.
3619
3620 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3621
3622 * fns.c (concat): Catch string overflow earlier.
3623 Do not rely on integer wraparound.
3624
3625 * dispextern.h (struct it.overlay_strings_charpos)
3626 (struct it.selective): Now EMACS_INT, not int.
3627 * xdisp.c (forward_to_next_line_start)
3628 (back_to_previous_visible_line_start)
3629 (reseat_at_next_visible_line_start, next_element_from_buffer):
3630 Don't arbitrarily truncate the value of 'selective' to int.
3631
3632 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3633
3634 * composite.c: Don't truncate sizes to 'int'.
3635 (composition_gstring_p, composition_reseat_it)
3636 (composition_adjust_point): Use EMACS_INT, not int.
3637 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3638 not EMACS_UINT, for indexes.
3639
3640 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3641
3642 * buffer.c: Include <verify.h>.
3643 (struct sortvec.priority, struct sortstr.priority):
3644 Now EMACS_INT, not int.
3645 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
3646 (struct sortstr.size, record_overlay_string)
3647 (struct sortstrlist.size, struct sortlist.used):
3648 Don't truncate size to int.
3649 (record_overlay_string): Check for size-calculation overflow.
3650 (init_buffer_once): Check at compile-time, not run-time.
3651
3652 2011-06-22 Jim Meyering <meyering@redhat.com>
3653
3654 Don't leak an XBM-image-sized buffer
3655 * image.c (xbm_load): Free the image buffer after using it.
3656
3657 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3658
3659 Port to Sun C.
3660 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3661 that Sun C diagnosed.
3662 * fns.c (secure_hash): Fix pointer signedness issue.
3663 * intervals.c (static_offset_intervals): New function.
3664 (offset_intervals): Use it.
3665
3666 2011-06-21 Leo Liu <sdl.web@gmail.com>
3667
3668 * deps.mk (fns.o):
3669 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3670 sha512.h.
3671
3672 * fns.c (secure_hash): Rename from crypto_hash_function and change
3673 the first arg to accept symbols.
3674 (Fsecure_hash): New primitive.
3675 (syms_of_fns): New symbols.
3676
3677 2011-06-20 Deniz Dogan <deniz@dogan.se>
3678
3679 * process.c (Fset_process_buffer): Clarify return value in
3680 docstring.
3681
3682 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
3683
3684 * dispnew.c (add_window_display_history): Use BVAR.
3685
3686 * xdisp.c (debug_method_add): Use BVAR.
3687 (check_window_end, dump_glyph_matrix, dump_glyph)
3688 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3689
3690 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3691 Likewise.
3692
3693 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3694 check till after the cache is created in init_frame_faces.
3695
3696 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3697
3698 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3699
3700 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3701
3702 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3703 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3704 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3705
3706 Improve buffer-overflow checking (Bug#8873).
3707 * fileio.c (Finsert_file_contents):
3708 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3709 Remove the old (too-loose) buffer overflow checks.
3710 They weren't needed, since make_gap checks for buffer overflow.
3711 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3712 The old code merely checked for Emacs fixnum overflow, and relied
3713 on undefined (wraparound) behavior. The new code avoids undefined
3714 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3715
3716 * editfns.c (Finsert_char): Don't dump core with very negative counts.
3717 Tune. Don't use wider integers than needed. Don't use alloca.
3718 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
3719
3720 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3721
3722 * insdel.c, lisp.h (buffer_overflow): New function.
3723 (insert_from_buffer_1, replace_range, replace_range_2):
3724 * insdel.c (make_gap_larger):
3725 * editfns.c (Finsert_char):
3726 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3727
3728 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3729
3730 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3731
3732 Integer overflow and signedness fixes (Bug#8873).
3733
3734 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3735 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3736
3737 * fileio.c: Don't assume EMACS_INT fits in off_t.
3738 (emacs_lseek): New static function.
3739 (Finsert_file_contents, Fwrite_region): Use it.
3740 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3741
3742 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3743
3744 * fns.c: Don't overflow int when computing a list length.
3745 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3746 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3747 truncation on 64-bit hosts. Check for QUIT every
3748 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3749 faster and is responsive enough.
3750 (Flength): Report an error instead of overflowing an integer.
3751 (Fsafe_length): Return a float if the value is not representable
3752 as a fixnum. This shouldn't happen except in contrived situations.
3753 (Fnthcdr, Fsort): Don't assume list length fits in int.
3754 (Fcopy_sequence): Don't assume vector length fits in int.
3755
3756 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3757 (header_size, word_size): New constants.
3758 (allocate_vectorlike): Don't check size overflow here.
3759 (allocate_vector): Check it here instead, since this is the only
3760 caller of allocate_vectorlike that could cause overflow.
3761 Check that the new vector's length is representable as a fixnum.
3762
3763 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3764 The previous code was bogus. For example, next_almost_prime (32)
3765 returned 39, which is undesirable as it is a multiple of 3; and
3766 next_almost_prime (24) returned 25, which is a multiple of 5 so
3767 why was the code bothering to check for multiples of 7?
3768
3769 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3770
3771 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3772
3773 Variadic C functions now count arguments with ptrdiff_t.
3774 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3775 Back then I didn't know that the Emacs coding style prefers signed int.
3776 Also, in the meantime I found a few more instances where arguments
3777 were being counted with int, which may truncate counts on 64-bit
3778 machines, or EMACS_INT, which may be unnecessarily wide.
3779 * lisp.h (struct Lisp_Subr.function.aMANY)
3780 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3781 Arg counts are now ptrdiff_t, not size_t.
3782 All variadic functions and their callers changed accordingly.
3783 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3784 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3785 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3786 * callint.c (Fcall_interactively): Check arg count for overflow,
3787 to avoid potential buffer overrun. Use signed char, not 'int',
3788 for 'varies' array, so that we needn't bother to check its size
3789 calculation for overflow.
3790 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3791 * eval.c (apply_lambda):
3792 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3793 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3794 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3795
3796 * callint.c (Fcall_interactively): Don't use index var as event count.
3797
3798 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3799 * mem-limits.h (SIZE): Remove; no longer used.
3800
3801 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
3802
3803 Remove unnecessary casts.
3804 * xterm.c (x_term_init):
3805 * xfns.c (x_set_border_pixel):
3806 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3807 These aren't needed now that we assume ANSI C.
3808
3809 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3810 It's more likely to cause problems (due to unsigned overflow)
3811 than to cure them.
3812
3813 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3814
3815 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3816
3817 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3818
3819 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3820
3821 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3822
3823 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3824
3825 GLYPH_CODE_FACE returns EMACS_INT, not int.
3826 * dispextern.h (merge_faces):
3827 * xfaces.c (merge_faces):
3828 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3829 Don't assume EMACS_INT fits in int.
3830
3831 * character.h (CHAR_VALID_P): Remove unused parameter.
3832 * fontset.c, lisp.h, xdisp.c: All uses changed.
3833
3834 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3835
3836 * fns.c (concat): Minor tuning based on overflow analysis.
3837 This doesn't fix any bugs. Use int to hold character, instead
3838 of constantly refetching from Emacs object. Use XFASTINT, not
3839 XINT, for value known to be a character. Don't bother comparing
3840 a single byte to 0400, as it's always less.
3841
3842 * floatfns.c (Fexpt):
3843 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3844
3845 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3846 for characters.
3847
3848 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3849
3850 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3851 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3852 incorrectly succeed when S was a string, because 4294967386 was
3853 truncated before it was used.
3854
3855 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3856 Otherwise, an out-of-range integer could cause undefined behavior
3857 on a 64-bit host.
3858
3859 * composite.c: Use int, not EMACS_INT, for characters.
3860 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3861 EMACS_INT, for values that are known to be in character range.
3862 This doesn't fix any bugs but is the usual style inside Emacs and
3863 may generate better code on 32-bit machines.
3864
3865 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3866 This is for reasons similar to the recent CHAR_STRING fix.
3867 * charset.c (Fencode_char): Check that character arg is actually
3868 a character. Pass an int to ENCODE_CHAR.
3869 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3870 wider than 'int', as a compile-time check to prevent future regressions
3871 in this area.
3872
3873 * character.c (char_string): Remove unnecessary casts.
3874
3875 Make sure a 64-bit char is never passed to CHAR_STRING.
3876 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3877 by silently ignoring the top 32 bits, allowing some values
3878 that were far too large to be valid characters.
3879 * character.h: Include <verify.h>.
3880 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3881 arguments are no wider than unsigned, as a compile-time check
3882 to prevent future regressions in this area.
3883 * data.c (Faset):
3884 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
3885 (Fsubst_char_in_region):
3886 * fns.c (concat):
3887 * xdisp.c (decode_mode_spec_coding):
3888 Adjust to CHAR_STRING's new requirement.
3889 * editfns.c (Finsert_char, Fsubst_char_in_region):
3890 * fns.c (concat): Check that character args are actually
3891 characters. Without this test, these functions did the wrong
3892 thing with wildly out-of-range values on 64-bit hosts.
3893
3894 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3895 These casts should not be needed on 32-bit hosts, either.
3896 * keyboard.c (read_char):
3897 * lread.c (Fload): Remove casts to unsigned.
3898
3899 * lisp.h (UNSIGNED_CMP): New macro.
3900 This fixes comparison bugs on 64-bit hosts.
3901 (ASCII_CHAR_P): Use it.
3902 * casefiddle.c (casify_object):
3903 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
3904 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3905 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3906 * dispextern.h (FACE_FROM_ID):
3907 * keyboard.c (read_char): Use UNSIGNED_CMP.
3908
3909 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3910 not to EMACS_INT, to avoid GCC warning.
3911
3912 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3913
3914 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3915 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3916 isn't needed on 32-bit machines.
3917
3918 * buffer.c (Fgenerate_new_buffer_name):
3919 Use EMACS_INT for count, not int.
3920 (advance_to_char_boundary): Return EMACS_INT, not int.
3921
3922 * data.c (Qcompiled_function): Now static.
3923
3924 * window.c (window_body_lines): Now static.
3925
3926 * image.c (gif_load): Rename local to avoid shadowing.
3927
3928 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3929 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3930 * alloc.c (make_save_value): Integer argument is now of type
3931 ptrdiff_t, not int.
3932 (mark_object): Use ptrdiff_t, not int.
3933 * lisp.h (pD): New macro.
3934 * print.c (print_object): Use it.
3935
3936 * alloc.c: Use EMACS_INT, not int, to count objects.
3937 (total_conses, total_markers, total_symbols, total_vector_size)
3938 (total_free_conses, total_free_markers, total_free_symbols)
3939 (total_free_floats, total_floats, total_free_intervals)
3940 (total_intervals, total_strings, total_free_strings):
3941 Now EMACS_INT, not int. All uses changed.
3942 (Fgarbage_collect): Compute overall total using a double, so that
3943 integer overflow is less likely to be a problem. Check for overflow
3944 when converting back to an integer.
3945 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3946 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3947 These were 'int' variables that could overflow on 64-bit hosts;
3948 they were never used, so remove them instead of repairing them.
3949 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
3950 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3951 Previously, this ceilinged at INT_MAX, but that doesn't work on
3952 64-bit machines.
3953 (allocate_pseudovector): Don't use EMACS_INT when int would do.
3954
3955 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
3956 (allocate_vectorlike): Check for ptrdiff_t overflow.
3957 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3958 when a (possibly-narrower) signed value would do just as well.
3959 We prefer using signed arithmetic, to avoid comparison confusion.
3960
3961 * alloc.c: Catch some string size overflows that we were missing.
3962 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3963 for convenience in STRING_BYTES_MAX.
3964 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3965 The definition here is exact; the one in lisp.h was approximate.
3966 (allocate_string_data): Check for string overflow. This catches
3967 some instances we weren't catching before. Also, it catches
3968 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3969 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3970 and ptrdiff_t and EMACS_INT are both 64 bits.
3971
3972 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3973 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
3974 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
3975
3976 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3977
3978 * alloc.c (Fmake_string): Check for out-of-range init.
3979
3980 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3981
3982 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3983
3984 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3985
3986 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3987 xg_get_default_scrollbar_width.
3988
3989 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3990 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3991 (style_changed_cb): Call update_theme_scrollbar_width and call
3992 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3993 all frames (Bug#8505).
3994 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3995 Call gtk_window_set_resizable if HAVE_GTK3.
3996 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3997 and height if HAVE_GTK3 (Bug#8505).
3998 (scroll_bar_width_for_theme): New variable.
3999 (update_theme_scrollbar_width): New function.
4000 (xg_get_default_scrollbar_width): Move code to
4001 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4002 (xg_initialize): Call update_theme_scrollbar_width.
4003
4004 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4005
4006 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4007
4008 2011-06-12 Martin Rudalics <rudalics@gmx.at>
4009
4010 * frame.c (make_frame): Call other_buffer_safely instead of
4011 other_buffer.
4012
4013 * window.c (temp_output_buffer_show): Call display_buffer with
4014 second argument Vtemp_buffer_show_specifiers and reset latter
4015 immediately after the call.
4016 (Vtemp_buffer_show_specifiers): New variable.
4017 (auto_window_vscroll_p, next_screen_context_lines)
4018 (Vscroll_preserve_screen_position): Remove leading asterisks from
4019 doc-strings.
4020
4021 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4022
4023 Fix minor problems found by GCC 4.6.0 static checking.
4024 * buffer.c (Qclone_number): Remove for now, as it's unused.
4025 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4026 (record_buffer): Remove unused local.
4027 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4028 (set_frame_buffer_list): Remove; unused.
4029 * frame.h (other_visible_frames): Remove decl.
4030 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4031 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4032 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4033 if HAVE_GPM.
4034 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4035 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4036 Define only if HAVE_GPM.
4037 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4038 (update_hints_inhibit): Remove; never set. All uses removed.
4039 * widgetprv.h (emacsFrameClassRec): Remove decl.
4040 * window.c (delete_deletable_window): Now returns void, since it
4041 wasn't returning anything.
4042 (compare_window_configurations): Remove unused locals.
4043 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4044 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4045 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4046 the same widths as pointers. This follows up on the 2011-05-06 patch.
4047 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4048 * xterm.h: Likewise.
4049 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4050
4051 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
4052
4053 * makefile.w32-in: Update dependencies.
4054 (LISP_H): Add lib/intprops.h.
4055
4056 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4057
4058 * image.c (gif_load): Add animation frame delay to the metadata.
4059 (syms_of_image): Use DEFSYM. New symbol `delay'.
4060
4061 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4062
4063 * window.c (delete_deletable_window): Re-add.
4064 (Fset_window_configuration): Rewrite to handle dead buffers and
4065 consequently deletable windows.
4066 (window_tree, Fwindow_tree): Remove. Supply functionality in
4067 window.el.
4068 (compare_window_configurations): Simplify code.
4069
4070 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4071
4072 * image.c (imagemagick_load_image): Fix type mismatch.
4073 (Fimagemagick_types): Likewise.
4074
4075 * window.h (replace_buffer_in_windows): Declare.
4076
4077 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4078
4079 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4080 Qclone_number. Remove external declaration of Qdelete_window.
4081 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4082 code.
4083 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4084 Run Qbuffer_list_update_hook if allowed.
4085 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4086 buffer list implementation.
4087 (other_buffer_safely): New function.
4088 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4089 calls to replace_buffer_in_windows and
4090 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4091 if allowed.
4092 (record_buffer): Inhibit quitting and rewrite using quittable
4093 functions. Run Qbuffer_list_update_hook if allowed.
4094 (Frecord_buffer, Funrecord_buffer): New functions.
4095 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4096 Move switch-to-buffer to window.el.
4097 (bury-buffer): Move to window.el.
4098 (Vbuffer_list_update_hook): New variable.
4099
4100 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4101 section.
4102
4103 * window.h (resize_frame_windows): Move up in code.
4104 (Fwindow_frame): Remove EXFUN.
4105 (replace_buffer_in_all_windows): Remove prototype.
4106 (replace_buffer_in_windows_safely): Add prototype.
4107
4108 * window.c: Declare Qdelete_window static again. Move down
4109 declaration of select_count.
4110 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4111 (Fother_window): Move to window.el.
4112 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4113 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4114 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4115 window.el.
4116 (replace_buffer_in_windows): Implement by calling
4117 Qreplace_buffer_in_windows.
4118 (replace_buffer_in_all_windows): Remove with some functionality
4119 moved into replace_buffer_in_windows_safely.
4120 (replace_buffer_in_windows_safely): New function.
4121 (select_window_norecord, select_frame_norecord): Move in front
4122 of run_window_configuration_change_hook. Remove now obsolete
4123 declarations.
4124 (Fset_window_buffer): Rewrite doc-string.
4125 Call Qrecord_window_buffer.
4126 (keys_of_window): Move binding for other-window to window.el.
4127
4128 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4129
4130 * dispextern.h (struct image): Replace data member, whose int_val
4131 and ptr_val fields were not used by anything, with a single
4132 lisp_val object.
4133
4134 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4135 (gif_clear_image, gif_load, imagemagick_load_image)
4136 (gs_clear_image, gs_load): Callers changed.
4137
4138 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4139
4140 * buffer.h: Include <time.h>, for time_t.
4141 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4142
4143 Fix minor problems found by static checking.
4144
4145 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4146
4147 Make identifiers static if they are not used in other modules.
4148 * data.c (Qcompiled_function, Qframe, Qvector):
4149 * image.c (QimageMagick, Qsvg):
4150 * minibuf.c (Qmetadata):
4151 * window.c (resize_window_check, resize_root_window): Now static.
4152 * window.h (resize_window_check, resize_root_window): Remove decls.
4153
4154 * window.c (window_deletion_count, delete_deletable_window):
4155 Remove; unused.
4156 (window_body_lines): Now static.
4157 (Fdelete_other_windows_internal): Mark vars as initialized.
4158 Make sure 'resize_failed' is initialized.
4159 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4160 (resize_window_apply): Remove unused local.
4161 * window.h (delete_deletable_window): Remove decl.
4162
4163 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
4164 (imagemagick_load_image): Fix pointer signedness problem by changing
4165 last arg from unsigned char * to char *. All uses changed.
4166 Also, fix a local for similar reasons.
4167 Remove unused locals. Remove locals to avoid shadowing.
4168 (fn_rsvg_handle_free): Remove; unused.
4169 (svg_load, svg_load_image): Fix pointer signedness problem.
4170 (imagemagick_load_image): Don't use garbage pointer image_wand.
4171
4172 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4173
4174 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
4175
4176 * image.c (gif_load): Fix omitted cast error introduced by
4177 2011-06-06 change.
4178
4179 2011-06-10 Martin Rudalics <rudalics@gmx.at>
4180
4181 * window.h (resize_proportionally, orig_total_lines)
4182 (orig_top_line): Remove from window structure.
4183 (set_window_height, set_window_width, change_window_heights)
4184 (Fdelete_window): Remove prototypes.
4185 (resize_frame_windows): Remove duplicate declaration.
4186
4187 2011-06-10 Eli Zaretskii <eliz@gnu.org>
4188
4189 * window.h (resize_frame_windows, resize_window_check)
4190 (delete_deletable_window, resize_root_window)
4191 (resize_frame_windows): Declare prototypes.
4192
4193 * window.c (resize_window_apply): Make definition be "static" to
4194 match the prototype.
4195
4196 2011-06-10 Martin Rudalics <rudalics@gmx.at>
4197
4198 * window.c: Remove declarations of Qwindow_size_fixed,
4199 window_min_size_1, window_min_size_2, window_min_size,
4200 size_window, window_fixed_size_p, enlarge_window, delete_window.
4201 Remove static from declaration of Qdelete_window, it's
4202 temporarily needed by Fbury_buffer.
4203 (replace_window): Don't assign orig_top_line and
4204 orig_total_lines.
4205 (Fdelete_window, delete_window): Remove. Window deletion is
4206 handled by window.el.
4207 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4208 Replace Fdelete_window calls with calls to Qdelete_window.
4209 (Fdelete_other_windows): Remove. Deleting other windows is
4210 handled by window.el.
4211 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4212 handled in window.el.
4213 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4214 Window minimum sizes are handled in window.el.
4215 (shrink_windows, size_window, set_window_height)
4216 (set_window_width, change_window_heights, window_height)
4217 (window_width, CURBEG, CURSIZE, enlarge_window)
4218 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4219 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4220 handled in window.el.
4221 (make_dummy_parent): Rename to make_parent_window and give it a
4222 second argument horflag.
4223 (make_window): Don't set resize_proportionally any more.
4224 (Fsplit_window): Remove. Windows are split in window.el.
4225 (save_restore_action, save_restore_orig_size)
4226 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4227 Resize mini windows in window.el.
4228 (grow_mini_window, shrink_mini_window): Implement by calling
4229 Qresize_root_window_vertically, resize_window_check and
4230 resize_window_apply.
4231 (saved_window, Fset_window_configuration, save_window_save):
4232 Do not handle orig_top_line, orig_total_lines, and
4233 resize_proportionally.
4234 (window_min_height, window_min_width): Move to window.el.
4235 (keys_of_window): Move bindings for delete-other-windows,
4236 split-window, delete-window and enlarge-window to window.el.
4237
4238 * buffer.c: Temporarily extern Qdelete_window.
4239 (Fbury_buffer): Temporarily call Qdelete_window instead of
4240 Fdelete_window (Fbury_buffer will move to window.el soon).
4241
4242 * frame.c (set_menu_bar_lines_1): Remove code handling
4243 orig_top_line and orig_total_lines.
4244
4245 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4246 set_window_height but set heights directly.
4247 (change_frame_size_1): Use resize_frame_windows.
4248
4249 * xdisp.c (init_xdisp): Don't use set_window_height but set
4250 heights directly.
4251
4252 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4253 Use resize_frame_windows instead of change_window_heights and run
4254 run_window_configuration_change_hook.
4255
4256 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4257 instead of change_window_heights and run
4258 run_window_configuration_change_hook.
4259
4260 2011-06-09 Martin Rudalics <rudalics@gmx.at>
4261
4262 * window.c (replace_window): Rename second argument REPLACEMENT to
4263 NEW. New third argument SETFLAG. Rewrite.
4264 (delete_window, make_dummy_parent): Call replace_window with
4265 third argument 1.
4266 (window_list_1): Move down in code.
4267 (run_window_configuration_change_hook): Move set_buffer part
4268 before select_frame_norecord part in order to unwind correctly.
4269 Rename count1 to count.
4270 (recombine_windows, delete_deletable_window, resize_root_window)
4271 (Fdelete_other_windows_internal)
4272 (Frun_window_configuration_change_hook, make_parent_window)
4273 (resize_window_check, resize_window_apply, Fresize_window_apply)
4274 (resize_frame_windows, Fsplit_window_internal)
4275 (Fdelete_window_internal, Fresize_mini_window_internal):
4276 New functions.
4277 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4278
4279 2011-06-08 Martin Rudalics <rudalics@gmx.at>
4280
4281 * window.h (window): Add some new members to window structure -
4282 normal_lines, normal_cols, new_total, new_normal, clone_number,
4283 splits, nest, prev_buffers, next_buffers.
4284 (WINDOW_TOTAL_SIZE): Move here from window.c.
4285 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
4286
4287 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4288 Remove.
4289 (make_dummy_parent): Set new members of windows structure.
4290 (make_window): Move down in code. Handle new members of window
4291 structure.
4292 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4293 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4294 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4295 (Fset_window_prev_buffers, Fwindow_next_buffers)
4296 (Fset_window_next_buffers, Fset_window_clone_number):
4297 New functions.
4298 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4299 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4300 Doc-string fixes.
4301 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4302 Argument WINDOW can be now internal window too.
4303 (Fwindow_use_time): Move up in code.
4304 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4305 Rewrite doc-string.
4306 (Fset_window_configuration, saved_window)
4307 (Fcurrent_window_configuration, save_window_save): Handle new
4308 members of window structure.
4309 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4310 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4311 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4312 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4313 Qget_mru_window, Qresize_root_window,
4314 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4315 Qauto_buffer_name; staticpro them.
4316
4317 2011-06-07 Martin Rudalics <rudalics@gmx.at>
4318
4319 * window.c (Fwindow_total_size, Fwindow_left_column)
4320 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4321 (Fwindow_list_1): New functions.
4322 (window_box_text_cols): Replace with window_body_cols.
4323 (Fwindow_width, Fscroll_left, Fscroll_right):
4324 Use window_body_cols instead of window_box_text_cols.
4325 (delete_window, Fset_window_configuration):
4326 Call delete_all_subwindows with window as argument.
4327 (delete_all_subwindows): Take a window as argument and not a
4328 structure. Rewrite.
4329 (window_loop): Remove handling of GET_LRU_WINDOW and
4330 GET_LARGEST_WINDOW.
4331 (Fget_lru_window, Fget_largest_window): Move to window.el.
4332
4333 * window.h: Extern window_body_cols instead of
4334 window_box_text_cols. delete_all_subwindows now takes a
4335 Lisp_Object as argument.
4336
4337 * indent.c (compute_motion, Fcompute_motion):
4338 Use window_body_cols instead of window_box_text_cols.
4339
4340 * frame.c (delete_frame): Call delete_all_subwindows with root
4341 window as argument.
4342
4343 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4344
4345 * fns.c (Fputhash): Document return value.
4346
4347 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
4348
4349 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4350
4351 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4352
4353 Cons<->int and similar integer overflow fixes (Bug#8794).
4354
4355 Check for overflow when converting integer to cons and back.
4356 * charset.c (Fdefine_charset_internal, Fdecode_char):
4357 Use cons_to_unsigned to catch overflow.
4358 (Fencode_char): Use INTEGER_TO_CONS.
4359 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4360 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4361 * data.c (long_to_cons, cons_to_long): Remove.
4362 (cons_to_unsigned, cons_to_signed): New functions.
4363 These signal an error for invalid or out-of-range values.
4364 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4365 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4366 * font.c (Ffont_variation_glyphs):
4367 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4368 * lisp.h: Include <intprops.h>.
4369 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4370 (cons_to_signed, cons_to_unsigned): New decls.
4371 (long_to_cons, cons_to_long): Remove decls.
4372 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4373 (Fprimitive_undo): Use CONS_TO_INTEGER.
4374 * xfns.c (Fx_window_property): Likewise.
4375 * xselect.c: Include <limits.h>.
4376 (x_own_selection, selection_data_to_lisp_data):
4377 Use INTEGER_TO_CONS.
4378 (x_handle_selection_request, x_handle_selection_clear)
4379 (x_get_foreign_selection, Fx_disown_selection_internal)
4380 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4381 (lisp_data_to_selection_data): Use cons_to_unsigned.
4382 (x_fill_property_data): Use cons_to_signed.
4383 Report values out of range.
4384
4385 Check for buffer and string overflow more precisely.
4386 * buffer.h (BUF_BYTES_MAX): New macro.
4387 * lisp.h (STRING_BYTES_MAX): New macro.
4388 * alloc.c (Fmake_string):
4389 * character.c (string_escape_byte8):
4390 * coding.c (coding_alloc_by_realloc):
4391 * doprnt.c (doprnt):
4392 * editfns.c (Fformat):
4393 * eval.c (verror):
4394 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4395 since they may not be the same number.
4396 * editfns.c (Finsert_char):
4397 * fileio.c (Finsert_file_contents):
4398 Likewise for BUF_BYTES_MAX.
4399
4400 * image.c: Use ptrdiff_t, not int, for sizes.
4401 (slurp_file): Switch from int to ptrdiff_t.
4402 All uses changed.
4403 (slurp_file): Check that file size fits in both size_t (for
4404 malloc) and ptrdiff_t (for sanity and safety).
4405
4406 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4407 if b->modtime has its maximal value.
4408
4409 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4410
4411 Don't assume time_t can fit into int.
4412 * buffer.h (struct buffer.modtime): Now time_t, not int.
4413 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4414 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4415
4416 Minor fixes for signed vs unsigned integers.
4417 * character.h (MAYBE_UNIFY_CHAR):
4418 * charset.c (maybe_unify_char):
4419 * keyboard.c (read_char, reorder_modifiers):
4420 XINT -> XFASTINT, since the integer must be nonnegative.
4421 * ftfont.c (ftfont_spec_pattern):
4422 * keymap.c (access_keymap, silly_event_symbol_error):
4423 XUINT -> XFASTINT, since the integer must be nonnegative.
4424 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4425 since it makes no difference and we prefer signed.
4426 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4427 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4428 nonnegative.
4429
4430 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4431
4432 * window.h (Fwindow_frame): Declare.
4433
4434 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4435
4436 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4437 (SPARE_MEMORY): Always define.
4438 (LARGE_REQUEST): Remove.
4439 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4440
4441 2011-06-06 Martin Rudalics <rudalics@gmx.at>
4442
4443 * lisp.h: Move EXFUNS for Fframe_root_window,
4444 Fframe_first_window and Fset_frame_selected_window to window.h.
4445
4446 * window.h: Move EXFUNS for Fframe_root_window,
4447 Fframe_first_window and Fset_frame_selected_window here from
4448 lisp.h.
4449
4450 * frame.c (Fwindow_frame, Fframe_first_window)
4451 (Fframe_root_window, Fframe_selected_window)
4452 (Fset_frame_selected_window): Move to window.c.
4453 (Factive_minibuffer_window): Move to minibuf.c.
4454 (Fother_visible_frames_p): New function.
4455
4456 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4457
4458 * window.c (decode_window, decode_any_window): Move up in code.
4459 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4460 (inhibit_frame_unsplittable): Remove unused variable.
4461 (Fwindow_buffer): Move up and rewrite doc-string.
4462 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4463 (Fwindow_prev): New functions.
4464 (Fwindow_frame): Move here from frame.c. Accept any window as
4465 argument.
4466 (Fframe_root_window, Fframe_first_window)
4467 (Fframe_selected_window): Move here from frame.c. Accept frame
4468 or arbitrary window as argument. Update doc-strings.
4469 (Fminibuffer_window): Move up in code.
4470 (Fwindow_minibuffer_p): Move up in code and simplify.
4471 (Fset_frame_selected_window): Move here from frame.c.
4472 Marginal rewrite.
4473 (Fselected_window, select_window, Fselect_window): Move up in
4474 code. Minor doc-string fixes.
4475
4476 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4477
4478 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4479 Do not assume that spare memory exists; that assumption is valid
4480 only if SYSTEM_MALLOC.
4481 (LARGE_REQUEST): New macro, so that the issue of large requests
4482 is separated from the issue of spare memory.
4483
4484 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4485
4486 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4487 format. (Bug#8806)
4488
4489 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4490
4491 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4492 before statements.
4493
4494 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4495
4496 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4497
4498 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4499
4500 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4501 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4502
4503 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
4504
4505 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4506
4507 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
4508
4509 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4510 (x_clipboard_manager_save): Add return value.
4511 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4512 New error handlers.
4513 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4514 Obey Vx_select_enable_clipboard_manager. Catch errors in
4515 x_clipboard_manager_save (Bug#8779).
4516 (Vx_select_enable_clipboard_manager): New variable.
4517 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4518
4519 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
4520
4521 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4522
4523 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4524
4525 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4526 in the current matrix if keep_current_p is non-zero.
4527
4528 2011-06-04 Eli Zaretskii <eliz@gnu.org>
4529
4530 * bidi.c (bidi_level_of_next_char): Fix last change.
4531
4532 2011-06-03 Eli Zaretskii <eliz@gnu.org>
4533
4534 Support bidi reordering of text covered by display properties.
4535
4536 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4537 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4538 (bidi_cache_search, bidi_cache_iterator_state)
4539 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
4540 (bidi_level_of_next_char, bidi_move_to_visually_next):
4541 Support character positions inside a run of characters covered by a
4542 display string.
4543 (bidi_paragraph_init, bidi_resolve_explicit_1)
4544 (bidi_level_of_next_char): Call bidi_fetch_char and
4545 bidi_fetch_char_advance instead of FETCH_CHAR and
4546 FETCH_CHAR_ADVANCE.
4547 (bidi_init_it): Initialize new members.
4548 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4549 definitions.
4550 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4551 instead of using explicit *_CHAR codes.
4552 (bidi_resolve_explicit, bidi_resolve_weak):
4553 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
4554 bidirectional text is supported only in multibyte buffers.
4555 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4556 it to initialize the frame_window_p member of struct bidi_it.
4557 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4558 (bidi_resolve_explicit, bidi_resolve_weak)
4559 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4560 bidi_it->nchars is non-positive.
4561 (bidi_level_of_next_char): Don't try to lookup the cache for the
4562 next/previous character if nothing is cached there yet, or if we
4563 were just reseat()'ed to a new position.
4564
4565 * xdisp.c (set_cursor_from_row): Set start and stop points
4566 according to the row's direction when priming the loop that looks
4567 for the glyph on which to display cursor.
4568 (single_display_spec_intangible_p): Function deleted.
4569 (display_prop_intangible_p): Reimplement to call
4570 handle_display_spec instead of single_display_spec_intangible_p.
4571 Accept 3 additional arguments needed by handle_display_spec.
4572 This fixes incorrect cursor motion across display property with complex
4573 values: lists, `(when COND...)' forms, etc.
4574 (single_display_spec_string_p): Support property values that are
4575 lists with the argument STRING its top-level element.
4576 (display_prop_string_p): Fix the condition for processing a
4577 property that is a list to be consistent with handle_display_spec.
4578 (handle_display_spec): New function, refactored from the
4579 last portion of handle_display_prop.
4580 (compute_display_string_pos): Accept additional argument
4581 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4582 value of a `display' property is a "replacing spec".
4583 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4584 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4585 the display property, but just return a value indicating whether
4586 the display property will replace the characters it covers.
4587 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4588 frame_window_p members of struct bidi_it.
4589 (compute_display_string_pos, compute_display_string_end):
4590 New functions.
4591 (push_it): Accept second argument POSITION, where pop_it should
4592 jump to continue iteration.
4593 (reseat_1): Initialize bidi_it.disp_pos.
4594
4595 * keyboard.c (adjust_point_for_property): Adjust the call to
4596 display_prop_intangible_p to its new signature.
4597
4598 * dispextern.h (struct bidi_it): New member frame_window_p.
4599 (bidi_init_it): Update prototypes.
4600 (display_prop_intangible_p): Update prototype.
4601 (compute_display_string_pos, compute_display_string_end):
4602 Declare prototypes.
4603 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4604 EMACS_INT.
4605
4606 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
4607
4608 Malloc failure behavior now depends on size of allocation.
4609 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4610 * lisp.h: Change signatures accordingly.
4611 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4612 All callers changed. (Bug#8762)
4613
4614 * gnutls.c: Use Emacs's memory allocators.
4615 Without this change, the gnutls library would invoke malloc etc.
4616 directly, which causes problems on non-SYNC_INPUT hosts, and which
4617 runs afoul of improving memory_full behavior. (Bug#8761)
4618 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4619 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4620 xfree instead of the default malloc, realloc, free.
4621 (Fgnutls_boot): No need to check for memory allocation failure,
4622 since xmalloc does that for us.
4623
4624 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
4625 * category.c (hash_get_category_set):
4626 * ccl.c (ccl_driver):
4627 * charset.c (Fdefine_charset_internal):
4628 * charset.h (struct charset.hash_index):
4629 * composite.c (get_composition_id, gstring_lookup_cache)
4630 (composition_gstring_put_cache):
4631 * composite.h (struct composition.hash_index):
4632 * dispextern.h (struct image.hash):
4633 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4634 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4635 (hashfn_equal, hashfn_user_defined, make_hash_table)
4636 (maybe_resize_hash_table, hash_lookup, hash_put)
4637 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4638 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4639 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4640 * image.c (make_image, search_image_cache, lookup_image)
4641 (xpm_put_color_table_h):
4642 * lisp.h (struct Lisp_Hash_Table):
4643 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
4644 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
4645 for hashes and hash indexes, instead of 'unsigned' and 'int'.
4646 * alloc.c (allocate_vectorlike):
4647 Check for overflow in vector size calculations.
4648 * ccl.c (ccl_driver):
4649 Check for overflow when converting EMACS_INT to int.
4650 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4651 need to be updated by these changes.
4652 * fns.c (make_hash_table, maybe_resize_hash_table):
4653 Check for integer overflow with large hash tables.
4654 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4655 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4656 (SXHASH_REDUCE): New macro.
4657 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4658 Use it instead of discarding useful hash info with large hash values.
4659 (sxhash_float): New function.
4660 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4661 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
4662 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4663 Rewrite to use FIXNUM_BITS, as this simplifies things.
4664 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4665 Adjust signatures to match updated version of code.
4666 (consing_since_gc): Now EMACS_INT, since a single hash table can
4667 use more than INT_MAX bytes.
4668
4669 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4670
4671 Make it possible to build with GCC-4.6+ -O2 -flto.
4672
4673 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4674
4675 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4676
4677 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4678 Call minibuffer-inactive-mode.
4679
4680 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
4681
4682 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4683 Update dependencies.
4684
4685 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4686
4687 * data.c (init_data): Remove code for UTS, this system is not
4688 supported anymore.
4689
4690 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4691
4692 Don't force ./temacs to start in terminal mode.
4693
4694 * frame.c (make_initial_frame): Initialize faces in all cases, not
4695 only when CANNOT_DUMP is defined.
4696 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4697
4698 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4699
4700 * dispnew.c (add_window_display_history): Use const for the string
4701 pointer. Remove declaration, not needed.
4702
4703 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4704
4705 Use 'inline', not 'INLINE'.
4706 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
4707 * alloc.c, fontset.c (INLINE): Remove.
4708 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4709 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4710 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4711 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4712 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4713
4714 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4715
4716 Make it possible to run ./temacs.
4717
4718 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4719 syms_of_callproc does the same thing. Remove test for
4720 "initialized", do it in the caller.
4721 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4722
4723 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4724
4725 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4726 (read_minibuf): Use get_minibuffer.
4727 (syms_of_minibuf): Use DEFSYM.
4728 (Qmetadata): New var.
4729 * data.c (Qbuffer): Don't make it static.
4730 (syms_of_data): Use DEFSYM.
4731
4732 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4733
4734 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4735 (CCL_CODE_MIN): New macro.
4736
4737 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4738
4739 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4740
4741 * eval.c (Qdebug): Now static.
4742 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4743 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4744 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4745
4746 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4747
4748 * image.c: Various fixes to ImageMagick code comments.
4749 (Fimagemagick_types): Doc fix.
4750
4751 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4752
4753 Minor fixes prompted by GCC 4.6.0 warnings.
4754
4755 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4756
4757 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4758 (x_clipboard_manager_save_all): Move extern decl to ...
4759 * xterm.h: ... here, so that it can be checked for consistency.
4760
4761 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4762
4763 * xselect.c (x_clipboard_manager_save_frame)
4764 (x_clipboard_manager_save_all): New functions.
4765 (Fx_clipboard_manager_save): Lisp function deleted.
4766
4767 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4768 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4769
4770 * xterm.h: Update prototype.
4771
4772 2011-05-28 William Xu <william.xwl@gmail.com>
4773
4774 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4775 exiting (Bug#8239).
4776
4777 2011-05-28 Jim Meyering <meyering@redhat.com>
4778
4779 Avoid a sign-extension bug in crypto_hash_function.
4780 * fns.c (to_uchar): Define.
4781 (crypto_hash_function): Use it to convert some newly-signed
4782 variables to unsigned, to avoid sign-extension bugs. For example,
4783 without this change, (md5 "truc") would evaluate to
4784 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4785 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
4786 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
4787
4788 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4789
4790 Integer overflow fixes.
4791
4792 * dbusbind.c: Serial number integer overflow fixes.
4793 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
4794 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4795 to hold a serial number that is too large for a fixnum.
4796 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4797 Check for serial numbers out of range. Decode any serial number
4798 that was so large that it became a float. (Bug#8722)
4799
4800 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4801 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4802 Use XFASTINT rather than XUINT when numbers are nonnegative.
4803 (xd_append_arg, Fdbus_method_return_internal):
4804 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4805 arguments, check that Lisp number is nonnegative, rather than
4806 silently wrapping negative numbers around. (Bug#8722)
4807 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
4808 (Bug#8722)
4809
4810 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4811
4812 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4813
4814 ccl: add integer overflow checks
4815 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4816 (IN_INT_RANGE): New macros.
4817 (ccl_driver): Use them to check for integer overflow when
4818 decoding a CCL program. Many of the new checks are whether XINT (x)
4819 fits in int; it doesn't always, on 64-bit hosts. The new version
4820 doesn't catch all possible integer overflows, but it's an
4821 improvement. (Bug#8719)
4822
4823 * alloc.c (make_event_array): Use XINT, not XUINT.
4824 There's no need for unsigned here.
4825
4826 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4827 This follows up to the 2011-05-06 change that substituted uintptr_t
4828 for EMACS_INT. This case wasn't caught back then.
4829
4830 Rework Fformat to avoid integer overflow issues.
4831 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4832 now (part of C89). Include <verify.h>.
4833 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4834 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4835 (Fformat): Avoid the prepass trying to compute sizes; it was only
4836 approximate and thus did not catch overflow reliably. Instead, walk
4837 through the format just once, formatting and computing sizes as we go,
4838 checking for integer overflow at every step, and allocating a larger
4839 buffer as needed. Keep track separately whether the format is
4840 multibyte. Keep only the most-recently calculated precision, rather
4841 than them all. Record whether each argument has been converted to
4842 string. Use EMACS_INT, not int, for byte and char and arg counts.
4843 Support field widths and precisions larger than INT_MAX. Avoid
4844 sprintf's undefined behavior with conversion specifications such as %#d
4845 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4846 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4847 formatting out-of-range floating point numbers with int
4848 formats. (Bug#8668)
4849
4850 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4851
4852 * data.c: Avoid integer truncation in expressions involving floats.
4853 * data.c: Include <intprops.h>.
4854 (arith_driver): When there's an integer overflow in an expression
4855 involving floating point, convert the integers to floating point
4856 so that the resulting value does not suffer from catastrophic
4857 integer truncation. For example, on a 64-bit host (* 4
4858 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4859 Do not rely on undefined behavior after integer overflow.
4860
4861 merge count_size_as_multibyte, parse_str_to_multibyte
4862 * character.c, character.h (count_size_as_multibyte):
4863 Rename from parse_str_to_multibyte; all uses changed.
4864 Check for integer overflow.
4865 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4866 since it's now a duplicate of the other. This is more of
4867 a character than a buffer op, so better that it's in character.c.
4868 * fns.c, print.c: Adjust to above changes.
4869
4870 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4871
4872 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4873
4874 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4875
4876 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4877 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4878 (x_clipboard_manager_save): Now static.
4879 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4880
4881 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4882 (crypto_hash_function): Now static.
4883 Fix pointer signedness problems. Avoid unnecessary initializations.
4884
4885 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
4886
4887 * termhooks.h (Vselection_alist): Make it terminal-local.
4888
4889 * terminal.c (create_terminal): Initialize it.
4890
4891 * xselect.c: Support for clipboard managers.
4892 (Vselection_alist): Move to termhooks.h as terminal-local var.
4893 (LOCAL_SELECTION): New macro.
4894 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4895 (symbol_to_x_atom): Remove gratuitous arg.
4896 (x_handle_selection_request, lisp_data_to_selection_data)
4897 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
4898 (x_own_selection, x_get_local_selection, x_convert_selection):
4899 New arg, specifying work frame. Use terminal-local Vselection_alist.
4900 (some_frame_on_display): Delete unused function.
4901 (Fx_own_selection_internal, Fx_get_selection_internal)
4902 (Fx_disown_selection_internal, Fx_selection_owner_p)
4903 (Fx_selection_exists_p): New optional frame arg.
4904 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4905 (x_handle_selection_clear): Don't treat other terminals with the
4906 same keyboard specially. Use the terminal-local Vselection_alist.
4907 (x_clear_frame_selections): Use Frun_hook_with_args.
4908
4909 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4910
4911 * xterm.h: Add support for those atoms.
4912
4913 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
4914
4915 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4916 (converted_selections, conversion_fail_tag): New global variables.
4917 (x_selection_request_lisp_error): Free the above.
4918 (x_get_local_selection): Remove unnecessary code.
4919 (x_reply_selection_request): Args changed; handle arbitrary array
4920 of converted selections stored in converted_selections.
4921 Separate the XChangeProperty and SelectionNotify steps.
4922 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4923 (x_convert_selection): New function.
4924 (x_handle_selection_event): Simplify.
4925 (x_get_foreign_selection): Don't ignore incoming requests while
4926 waiting for an answer; this will fail when we implement
4927 SAVE_TARGETS, and seems unnecessary anyway.
4928 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4929 (Vx_sent_selection_functions): Doc fix.
4930
4931 2011-05-26 Leo Liu <sdl.web@gmail.com>
4932
4933 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4934
4935 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4936
4937 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4938
4939 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4940 for fringe update if it has periodic bitmap.
4941 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
4942 and fringe_bitmap_periodic_p.
4943
4944 * fringe.c (get_fringe_bitmap_data): New function.
4945 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4946 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4947 row. Mark glyph row for fringe update if periodicity changed.
4948
4949 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4950 for fringe update unless it has periodic bitmap.
4951
4952 2011-05-25 Kenichi Handa <handa@m17n.org>
4953
4954 * xdisp.c (get_next_display_element): Set correct it->face_id for
4955 a static composition.
4956
4957 2011-05-24 Leo Liu <sdl.web@gmail.com>
4958
4959 * deps.mk (fns.o):
4960 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4961
4962 * fns.c (crypto_hash_function, Fsha1): New function.
4963 (Fmd5): Use crypto_hash_function.
4964 (syms_of_fns): Add Ssha1.
4965
4966 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4967
4968 * gnutls.c: Remove unused macros.
4969 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4970 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4971 Remove macros that are defined and never used.
4972 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4973
4974 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4975
4976 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4977 (Fx_get_selection_internal): Minor cleanup.
4978 (Fx_own_selection_internal): Rename arguments for consistency with
4979 select.el.
4980
4981 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4982
4983 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4984
4985 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4986
4987 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4988
4989 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4990
4991 * dispnew.c (scrolling_window): Don't exclude the case that the
4992 last enabled row in the desired matrix touches the bottom boundary.
4993
4994 2011-05-21 Glenn Morris <rgm@gnu.org>
4995
4996 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
4997 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4998 and add some more files.
4999
5000 2011-05-20 Eli Zaretskii <eliz@gnu.org>
5001
5002 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5003 report_file_error introduced by the change from 2011-05-07.
5004
5005 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5006
5007 * systime.h (Time): Define only if emacs is defined.
5008 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5009 where the include path doesn't have X11/X.h by default. See
5010 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5011
5012 2011-05-20 Kenichi Handa <handa@m17n.org>
5013
5014 * composite.c (find_automatic_composition): Fix previous change.
5015
5016 2011-05-20 Glenn Morris <rgm@gnu.org>
5017
5018 * lisp.mk: New file, split from Makefile.in.
5019 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5020 (shortlisp): Remove.
5021 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5022
5023 2011-05-19 Glenn Morris <rgm@gnu.org>
5024
5025 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5026 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5027 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5028 (lisp): Set the order to that of loadup.el.
5029 (shortlisp): Make it a copy of $lisp.
5030 (SOME_MACHINE_LISP): Remove.
5031 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5032 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5033
5034 2011-05-18 Kenichi Handa <handa@m17n.org>
5035
5036 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5037 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5038 (find_automatic_composition): Mostly rewrite for efficiency.
5039
5040 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
5041
5042 * makefile.w32-in: Update dependencies.
5043
5044 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5045
5046 * menu.c: Include limits.h (fixes the MS-Windows build broken by
5047 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
5048
5049 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
5050
5051 Fix some integer overflow issues, such as string length overflow.
5052
5053 * insdel.c (count_size_as_multibyte): Check for string overflow.
5054
5055 * character.c (lisp_string_width): Check for string overflow.
5056 Use EMACS_INT, not int, for string indexes and lengths; in
5057 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5058 the resulting string length overflows an EMACS_INT; instead,
5059 report a string overflow if no precision given. When checking for
5060 precision exhaustion, use a check that cannot possibly have
5061 integer overflow. (Bug#8675)
5062 * character.h (lisp_string_width): Adjust to new signature.
5063
5064 * alloc.c (string_overflow): New function.
5065 (Fmake_string): Use it. This doesn't change behavior, but saves
5066 a few bytes and will simplify future changes.
5067 * character.c (string_escape_byte8): Likewise.
5068 * lisp.h (string_overflow): New decl.
5069
5070 Fixups, following up to the user-interface timestamp change.
5071 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5072 for UI timestamps, instead of unsigned long.
5073 * msdos.c (mouse_get_pos): Likewise.
5074 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
5075 * w32gui.h (Time): Define by including "systime.h" rather than by
5076 declaring it ourselves. (Bug#8664)
5077
5078 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5079 * image.c (clear_image_cache): Likewise.
5080
5081 * term.c (term_mouse_position): Don't assume time_t wraparound.
5082
5083 Be more systematic about user-interface timestamps.
5084 Before, the code sometimes used 'Time', sometimes 'unsigned long',
5085 and sometimes 'EMACS_UINT', to represent these timestamps.
5086 This change causes it to use 'Time' uniformly, as that's what X uses.
5087 This makes the code easier to follow, and makes it easier to catch
5088 integer overflow bugs such as Bug#8664.
5089 * frame.c (Fmouse_position, Fmouse_pixel_position):
5090 Use Time, not unsigned long, for user-interface timestamps.
5091 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5092 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5093 * keyboard.h (last_event_timestamp): Likewise.
5094 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5095 * menu.h (xmenu_show): Likewise.
5096 * term.c (term_mouse_position): Likewise.
5097 * termhooks.h (struct input_event.timestamp): Likewise.
5098 (struct terminal.mouse_position_hook): Likewise.
5099 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5100 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5101 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5102 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5103 what it was before.
5104 * menu.h, termhooks.h: Include "systime.h", for Time.
5105
5106 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5107 Don't assume that the difference between two unsigned long values
5108 can fit into an integer. At this point, we know button_down_time
5109 <= event->timestamp, so the difference must be nonnegative, so
5110 there's no need to cast the result if double-click-time is
5111 nonnegative, as it should be; check that it's nonnegative, just in
5112 case. This bug is triggered when events are more than 2**31 ms
5113 apart (about 25 days). (Bug#8664)
5114
5115 * xselect.c (last_event_timestamp): Remove duplicate decl.
5116 (x_own_selection): Remove needless cast to unsigned long.
5117
5118 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5119 that always fit in int. Use a sentinel instead of a counter, to
5120 avoid a temp and to allay GCC's concerns about possible int overflow.
5121 * frame.h (struct frame): Use int for menu_bar_items_used
5122 instead of EMACS_INT, since it always fits in int.
5123
5124 * menu.c (grow_menu_items): Check for int overflow.
5125
5126 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5127
5128 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5129 Before, the code was not consistent. These values cannot exceed
5130 2**31 - 1 so there's no need to make them unsigned.
5131 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5132 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5133 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5134 as modifiers.
5135 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5136
5137 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5138 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5139 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5140 presumably because the widths might not match.
5141
5142 * window.c (size_window): Avoid needless test at loop start.
5143
5144 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5145
5146 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5147
5148 2011-05-12 Drew Adams <drew.adams@oracle.com>
5149
5150 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5151
5152 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5153
5154 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5155 `width' to `bar_area_x' and `bar_area_width', respectively.
5156 (x_scroll_run): Take account of fringe background extension.
5157
5158 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5159 Rename local vars `left' and `width' to `bar_area_x' and
5160 `bar_area_width', respectively.
5161 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5162 background extension.
5163
5164 2011-05-10 Jim Meyering <meyering@redhat.com>
5165
5166 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5167
5168 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
5169
5170 * image.c (Finit_image_library): Return t for built-in image types,
5171 like pbm and xbm. (Bug#8640)
5172
5173 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5174
5175 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5176
5177 2011-05-07 Eli Zaretskii <eliz@gnu.org>
5178
5179 * w32console.c (Fset_screen_color): Doc fix.
5180 (Fget_screen_color): New function.
5181 (syms_of_ntterm): Defsubr it.
5182
5183 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5184 unlink the temporary file if Fcall_process didn't create it in the
5185 first place.
5186 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5187 child process will be redirected to a file specified with `:file'.
5188 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5189 cue to call_process_cleanup not to close that handle.
5190
5191 2011-05-07 Ben Key <bkey76@gmail.com>
5192
5193 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5194 one of two shell specific rules, either bootstrap-temacs-CMD or
5195 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5196 to the previous implementation of the bootstrap-temacs rule.
5197 The bootstrap-temacs-CMD rule is similar to the previous
5198 implementation of the bootstrap-temacs rule except that it
5199 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5200 variable.
5201
5202 These changes, along with some changes to nt/configure.bat,
5203 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5204 earlier fix to add support for --cflags and --ldflags options
5205 that include quotes so that it works whether make uses cmd or
5206 sh as the shell.
5207
5208 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
5209
5210 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5211 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5212 is a constant.
5213 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5214 a string. Handle both cases.
5215 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5216 (Fdbus_register_method): Use Qinvalid_function.
5217
5218 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
5219
5220 * makefile.w32-in: Update dependencies.
5221 (LISP_H): Add inttypes.h and stdin.h.
5222 (PROCESS_H): Add unistd.h.
5223
5224 2011-05-06 Eli Zaretskii <eliz@gnu.org>
5225
5226 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5227 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5228
5229 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
5230
5231 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5232
5233 * term.c (vfatal): Remove stray call to va_end.
5234 It's not needed and the C Standard doesn't allow it here anyway.
5235
5236 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5237 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5238
5239 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5240 bytes.
5241
5242 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5243
5244 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5245
5246 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5247
5248 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5249
5250 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5251
5252 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5253 * charset.c (Fdefine_charset_internal): Don't initialize
5254 charset.code_space[15]. The value was garbage, on hosts with
5255 32-bit int (Bug#8600).
5256
5257 * lread.c (read_integer): Be more consistent with string-to-number.
5258 Use string_to_number to do the actual conversion; this avoids
5259 rounding errors and fixes some other screwups. Without this fix,
5260 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5261 (digit_to_number): Move earlier, for benefit of read_integer.
5262 Return -1 if the digit is out of range for the base, -2 if it is
5263 not a digit in any supported base. (Bug#8602)
5264
5265 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5266
5267 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5268 to match comment at start of function. This also removes a
5269 GCC warning about overflow in a 32+64-bit port.
5270
5271 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5272
5273 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5274 Reported by Stefan Monnier in
5275 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
5276 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5277 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
5278
5279 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5280 (EMACS_UINTPTR): Likewise, with uintptr_t.
5281
5282 * lisp.h: Prefer 64-bit EMACS_INT if available.
5283 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5284 on 32-bit hosts that have 64-bit int, so that they can access
5285 large files.
5286 However, temporarily disable this change unless the temporary
5287 symbol WIDE_EMACS_INT is defined.
5288
5289 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5290
5291 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5292 This removes an assumption that EMACS_INT and long are the same
5293 width as pointers. The assumption is true for Emacs porting targets
5294 now, but we want to make other targets possible.
5295 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5296 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5297 In the rest of the code, change types of integers that hold casted
5298 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5299 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5300 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5301 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5302 No need to cast type when ORing.
5303 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5304 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5305 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5306 assume EMACS_INT is the same width as char *.
5307 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5308 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5309 Remove no-longer-needed casts.
5310 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5311 (xg_tool_bar_help_callback, xg_make_tool_item):
5312 Use EMACS_INTPTR to hold an integer
5313 that will be cast to void *; this can avoid a GCC warning
5314 if EMACS_INT is not the same width as void *.
5315 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5316 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5317 (current_message_1, set_message_1):
5318 Use a local to convert to proper width without a cast.
5319 * xmenu.c (dialog_selection_callback): Likewise.
5320
5321 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5322 Also, don't assume VALBITS / RAND_BITS is less than 5,
5323 and don't rely on undefined behavior when shifting a 1 left into
5324 the sign bit.
5325 * lisp.h (get_random): Change signature to match.
5326
5327 * lread.c (hash_string): Use size_t, not int, for hash computation.
5328 Normally we prefer signed values; but hashing is special, because
5329 it's better to use unsigned division on hash table sizes so that
5330 the remainder is nonnegative. Also, size_t is the natural width
5331 for hashing into memory. The previous code used 'int', which doesn't
5332 retain enough info to hash well into very large tables.
5333 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5334
5335 * dbusbind.c: Don't possibly lose pointer info when converting.
5336 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5337 Use XPNTR rather than XHASH, so that the high-order bits of
5338 the pointer aren't lost when converting through void *.
5339
5340 * eval.c (Fautoload): Don't double-shift a pointer.
5341
5342 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5343
5344 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
5345
5346 * gnutls.c (DEF_GNUTLS_FN):
5347 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5348
5349 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5350
5351 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5352 marker. (Bug#8610)
5353
5354 2011-05-05 Eli Zaretskii <eliz@gnu.org>
5355
5356 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5357 New version that can reserve upto 2GB of heap space.
5358
5359 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
5360
5361 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5362
5363 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5364
5365 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5366 `gnutls_certificate_set_x509_key_file'.
5367
5368 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
5369
5370 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5371 Update dependencies.
5372
5373 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5374
5375 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5376 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5377 Remove unused parameter `fildes'.
5378 * process.c (read_process_output, send_process): Don't pass it.
5379
5380 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5381
5382 Fix previous change: the library cache is defined in w32.c.
5383 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5384 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5385
5386 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5387
5388 Implement dynamic loading of GnuTLS on Windows.
5389
5390 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5391 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5392 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5393 Declare.
5394
5395 * gnutls.c (Qgnutls_dll): Define.
5396 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5397 (gnutls_*): Declare function pointers.
5398 (init_gnutls_functions): New function to initialize function pointers.
5399 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5400 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5401 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5402 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5403 (emacs_gnutls_write, emacs_gnutls_read)
5404 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5405 (Fgnutls_available_p): New function.
5406 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5407 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5408 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5409
5410 * image.c: Include w32.h.
5411 (Vimage_type_cache): Delete.
5412 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5413 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5414 (w32_delayed_load): Move to w32.c.
5415
5416 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5417
5418 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5419 (w32_delayed_load): Move from image.c. When loading a library, record
5420 its filename in the :loaded-from property of the library id.
5421 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5422 Initialize and staticpro them.
5423 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5424
5425 * process.c: Include lisp.h before w32.h, not after.
5426 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5427 instead of gnutls_record_check_pending.
5428
5429 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5430
5431 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5432
5433 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5434 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5435 as passed in.
5436
5437 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5438
5439 * xterm.c (x_set_frame_alpha): Do not set property on anything
5440 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5441
5442 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
5443
5444 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5445
5446 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
5447
5448 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5449 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5450 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5451 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5452 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5453 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5454 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5455 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5456 (Qgnutls_bootprop_callbacks_verify): Make static.
5457
5458 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5459
5460 * callproc.c: Indentation fixup.
5461
5462 * sysdep.c (wait_for_termination_1): Make static.
5463 (wait_for_termination, interruptible_wait_for_termination):
5464 Move after wait_for_termination_1.
5465
5466 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5467
5468 * sysdep.c (interruptible_wait_for_termination): New function
5469 which is like wait_for_termination, but allows keyboard
5470 interruptions.
5471
5472 * callproc.c (Fcall_process): Add (:file "file") as an option for
5473 the STDOUT buffer.
5474 (Fcall_process_region): Ditto.
5475
5476 2011-04-30 Eli Zaretskii <eliz@gnu.org>
5477
5478 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5479 rather than `XVECTOR (FOO)->size'.
5480
5481 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5482 inttypes.h, as a gnulib replacement is used if it not available in
5483 system headers.
5484
5485 2011-04-21 Eli Zaretskii <eliz@gnu.org>
5486
5487 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5488 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5489 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5490
5491 * coding.c (coding_alloc_by_realloc): Error out if destination
5492 will grow beyond MOST_POSITIVE_FIXNUM.
5493 (decode_coding_emacs_mule): Abort if there isn't enough place in
5494 charbuf for the composition carryover bytes. Reserve an extra
5495 space for up to 2 characters produced in a loop.
5496 (decode_coding_iso_2022): Abort if there isn't enough place in
5497 charbuf for the composition carryover bytes.
5498
5499 2011-04-21 Eli Zaretskii <eliz@gnu.org>
5500
5501 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5502 aborting when %lld or %lll format is passed.
5503 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5504 %llo or %llx format is passed. (Bug#8545)
5505
5506 * window.c (window_scroll_line_based): Use a marker instead of
5507 simple variables to record original value of point. (Bug#7952)
5508
5509 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5510 produced by %s or %c overflows available buffer space. (Bug#8545)
5511
5512 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5513
5514 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
5515 (SIZE_MAX): Move defn after all includes, as they might #define it.
5516
5517 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5518
5519 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5520
5521 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5522
5523 * keyboard.c (Qdelayed_warnings_hook): Define.
5524 (command_loop_1): Run `delayed-warnings-hook'
5525 if Vdelayed_warnings_list is non-nil.
5526 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5527 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5528
5529 2011-04-28 Eli Zaretskii <eliz@gnu.org>
5530
5531 * doprnt.c (doprnt): Don't return value smaller than the buffer
5532 size if the message was truncated. (Bug#8545).
5533
5534 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5535
5536 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5537 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5538
5539 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5540
5541 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5542
5543 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
5544
5545 * makefile.w32-in: Update dependencies.
5546
5547 2011-04-27 Eli Zaretskii <eliz@gnu.org>
5548
5549 Improve `doprnt' and its usage. (Bug#8545)
5550 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5551 `format_end'. Remove support for %l as a conversion specifier.
5552 Don't use xrealloc. Improve diagnostics when the %l size modifier
5553 is used. Update the commentary.
5554
5555 * eval.c (verror): Simplify calculation of size_t.
5556
5557 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5558 messages.
5559
5560 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5561
5562 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5563 change.
5564
5565 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5566
5567 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5568 This makes this file independent of the recent pseudovector change.
5569
5570 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
5571
5572 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5573
5574 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
5575 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
5576 Remove unused local.
5577 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
5578
5579 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
5580 GCC 4.6.0 optimizes based on type-based alias analysis.
5581 For example, if b is of type struct buffer * and v of type struct
5582 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5583 != &v->size, and therefore "v->size = 1; b->size = 2; return
5584 v->size;" must therefore return 1. This assumption is incorrect
5585 for Emacs, since it type-puns struct Lisp_Vector * with many other
5586 types. To fix this problem, this patch adds a new type struct
5587 vectorlike_header that documents the constraints on layout of vectors
5588 and pseudovectors, and helps optimizing compilers not get fooled
5589 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5590 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
5591 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5592 the size member.
5593 (XSETPVECTYPE): Rewrite in terms of new macro.
5594 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5595 This is a bit clearer, and further avoids the possibility of
5596 undesirable aliasing.
5597 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
5598 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
5599 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5600 since Lisp_Subr is a special case (no "next" field).
5601 (ASIZE): Now uses header.size rather than size.
5602 All previous uses of XVECTOR (foo)->size replaced to use this macro,
5603 to avoid the hassle of writing XVECTOR (foo)->header.size.
5604 (struct vectorlike_header): New type.
5605 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5606 object, to help avoid aliasing.
5607 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5608 (SUBRP): Likewise, since Lisp_Subr is a special case.
5609 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5610 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5611 (struct Lisp_Hash_Table): Combine first two members into a single
5612 struct vectorlike_header member. All uses of "size" and "next" members
5613 changed to be "header.size" and "header.next".
5614 * buffer.h (struct buffer): Likewise.
5615 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5616 * frame.h (struct frame): Likewise.
5617 * process.h (struct Lisp_Process): Likewise.
5618 * termhooks.h (struct terminal): Likewise.
5619 * window.c (struct save_window_data, struct saved_window): Likewise.
5620 * window.h (struct window): Likewise.
5621 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5622 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5623 * buffer.c (init_buffer_once): Likewise.
5624 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5625 special case.
5626 * process.c (Fformat_network_address): Use local var for size,
5627 for brevity.
5628
5629 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5630
5631 Make the Lisp reader and string-to-float more consistent (Bug#8525)
5632 * data.c (atof): Remove decl; no longer used or needed.
5633 (digit_to_number): Move to lread.c.
5634 (Fstring_to_number): Use new string_to_number function, to be
5635 consistent with how the Lisp reader treats infinities and NaNs.
5636 Do not assume that floating-point numbers represent EMACS_INT
5637 without losing information; this is not true on most 64-bit hosts.
5638 Avoid double-rounding errors, by insisting on integers when
5639 parsing non-base-10 numbers, as the documentation specifies.
5640 * lisp.h (string_to_number): New decl, replacing ...
5641 (isfloat_string): Remove.
5642 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
5643 (read1): Do not accept +. and -. as integers; this
5644 appears to have been a coding error. Similarly, do not accept
5645 strings like +-1e0 as floating point numbers. Do not report
5646 overflow for integer overflows unless the base is not 10 which
5647 means we have no simple and reliable way to continue.
5648 Break out the floating-point parsing into a new
5649 function string_to_number, so that Fstring_to_number parses
5650 floating point numbers consistently with the Lisp reader.
5651 (digit_to_number): Move here from data.c. Make it static inline.
5652 (E_CHAR, EXP_INT): Remove, replacing with ...
5653 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5654 (string_to_number): New function, replacing isfloat_string.
5655 This function checks for valid syntax and produces the resulting
5656 Lisp float number too. Rework it so that string-to-number
5657 no longer mishandles examples like "1.0e+". Use strtoumax,
5658 so that overflow for non-base-10 numbers is reported only when
5659 there's no portable and simple way to convert to floating point.
5660
5661 * textprop.c (set_text_properties_1): Rewrite for clarity,
5662 and to avoid GCC warning about integer overflow.
5663
5664 * intervals.h (struct interval): Use EMACS_INT for members
5665 where EMACS_UINT might cause problems. See
5666 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5667 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5668 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5669 All uses changed.
5670 (offset_intervals): Tell GCC not to worry about length overflow
5671 when negating a negative length.
5672
5673 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5674 (overrun_check_free): Likewise.
5675
5676 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5677 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5678 word size.
5679
5680 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5681 (gnutls_make_error): Rename local to avoid shadowing.
5682 (gnutls_emacs_global_deinit): ifdef out; not used.
5683 (Fgnutls_boot): Use const for pointer to readonly storage.
5684 Comment out unused local. Fix pointer signedness problems.
5685
5686 * lread.c (openp): Don't stuff size_t into an 'int'.
5687 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5688 about possible signed overflow.
5689
5690 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5691 (GDK_KEY_g): Don't define if already defined.
5692 (xg_prepare_tooltip): Avoid pointer signedness problem.
5693 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5694
5695 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5696 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5697
5698 * xfns.c (Fx_window_property): Simplify a bit,
5699 to make a bit faster and to avoid GCC 4.6.0 warning.
5700 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5701
5702 * fns.c (internal_equal): Don't assume size_t fits in int.
5703
5704 * alloc.c (compact_small_strings): Tighten assertion a little.
5705
5706 Replace pEd with more-general pI, and fix some printf arg casts.
5707 * lisp.h (pI): New macro, generalizing old pEd macro to other
5708 conversion specifiers. For example, use "...%"pI"d..." rather
5709 than "...%"pEd"...".
5710 (pEd): Remove. All uses replaced with similar uses of pI.
5711 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5712 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5713 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5714 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5715 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5716 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5717 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5718 64-bit hosts.
5719 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5720 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5721 * print.c (safe_debug_print, print_object): Likewise.
5722 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5723 to int.
5724 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5725 avoiding the 0 flag, which is not portable.
5726 * process.c (Fmake_network_process): Use pI to avoid cast.
5727 * region-cache.c (pp_cache): Likewise.
5728 * xdisp.c (decode_mode_spec): Likewise.
5729 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5730 behavior on 64-bit hosts with printf arg.
5731 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
5732 (x_stop_queuing_selection_requests): Likewise.
5733 (x_get_window_property): Don't truncate byte count to an 'int'
5734 when tracing.
5735
5736 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5737 here, since it parses constructs like leading '-' and spaces,
5738 which are not wanted; and it overflows with large numbers.
5739 Instead, simply match F[0-9]+, which is what is wanted anyway.
5740
5741 * alloc.c: Remove unportable assumptions about struct layout.
5742 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5743 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5744 (allocate_vectorlike, make_pure_vector): Use the new macros,
5745 plus offsetof, to remove unportable assumptions about struct layout.
5746 These assumptions hold on all porting targets that I know of, but
5747 they are not guaranteed, they're easy to remove, and removing them
5748 makes further changes easier.
5749
5750 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5751 This doesn't fix a bug but makes the code clearer.
5752 (string_overrun_cookie): Now const. Use initializers that
5753 don't formally overflow signed char, to avoid warnings.
5754 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5755 can cause Emacs to crash when string overrun checking is enabled.
5756 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5757 multiple of sizeof (EMACS_INT); it need not be, if
5758 alignof(EMACS_INT) < sizeof (EMACS_INT).
5759 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
5760
5761 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
5762
5763 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5764
5765 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5766
5767 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
5768 supposed to be handshaking. (Bug#8556)
5769 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5770
5771 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
5772
5773 * lisp.h (Qdebug): List symbol.
5774 * eval.c (Qdebug): Restore global linkage.
5775 * keyboard.c (debug-on-event): New variable.
5776 (handle_user_signal): Break into debugger when debug-on-event
5777 matches the current signal symbol.
5778
5779 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5780
5781 * alloc.c (check_sblock, check_string_bytes)
5782 (check_string_free_list): Convert to standard C.
5783
5784 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5785
5786 * w32.c (emacs_gnutls_push): Fix typo.
5787
5788 2011-04-25 Eli Zaretskii <eliz@gnu.org>
5789
5790 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5791 "cast to pointer from integer of different size".
5792
5793 Improve doprnt and its use in verror. (Bug#8545)
5794 * doprnt.c (doprnt): Document the set of format control sequences
5795 supported by the function. Use SAFE_ALLOCA instead of always
5796 using `alloca'.
5797
5798 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5799 is one byte too soon. Don't use xrealloc; instead xfree and
5800 xmalloc anew.
5801
5802 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5803
5804 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5805 callbacks stage.
5806
5807 * gnutls.c: Renamed global_initialized to
5808 gnutls_global_initialized. Added internals for the
5809 :verify-hostname-error, :verify-error, and :verify-flags
5810 parameters of `gnutls-boot' and documented those parameters in the
5811 docstring. Start callback support.
5812 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5813 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5814 on error. Return error code.
5815 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5816 (emacs_gnutls_read): Likewise.
5817 (Fgnutls_boot): Return handshake error code.
5818 (emacs_gnutls_handle_error): New function.
5819 (wsaerror_to_errno): Likewise.
5820
5821 * w32.h (emacs_gnutls_pull): Add prototype.
5822 (emacs_gnutls_push): Likewise.
5823
5824 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5825 (emacs_gnutls_push): Likewise.
5826
5827 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5828
5829 * process.c (wait_reading_process_output): Check if GnuTLS
5830 buffered some data internally if no FDs are set for TLS
5831 connections.
5832
5833 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5834 (LIBS): Link to USER_LIBS.
5835 ($(BLD)/gnutls.$(0)): New target.
5836
5837 2011-04-24 Eli Zaretskii <eliz@gnu.org>
5838
5839 * xdisp.c (handle_single_display_spec): Rename the
5840 display_replaced_before_p argument into display_replaced_p, to
5841 make it consistent with the commentary. Fix typos in the
5842 commentary.
5843
5844 * textprop.c (syms_of_textprop): Remove dead code.
5845 (copy_text_properties): Delete obsolete commentary about an
5846 interface that was deleted long ago. Fix typos in the description
5847 of arguments.
5848
5849 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5850 to changes in oldXMenu/XMenu.h from 2011-04-16.
5851 <menu_help_message, prev_menu_help_message>: Constify.
5852 (IT_menu_make_room): menu->help_text is now `const char **';
5853 adjust.
5854
5855 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5856 to changes in oldXMenu/XMenu.h from 2011-04-16.
5857 (struct XMenu): Declare `help_text' `const char **'.
5858
5859 * xfaces.c <Qunspecified>: Make extern again.
5860
5861 * syntax.c: Include sys/types.h before including regex.h, as
5862 required by Posix.
5863
5864 * doc.c (get_doc_string): Improve the format passed to `error'.
5865
5866 * doprnt.c (doprnt): Improve commentary.
5867
5868 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5869
5870 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5871 them with etags.
5872
5873 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5874 changes in globals.h immediately force recompilation.
5875 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5876 $(CURDIR)/s/ms-w32.h.
5877 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
5878
5879 * character.c (Fchar_direction): Function deleted.
5880 (syms_of_character): Don't defsubr it.
5881 <char-direction-table>: Deleted.
5882
5883 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5884
5885 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5886 * doprnt.c: Include limits.h.
5887 (SIZE_MAX): New macro.
5888 (doprnt): Return a size_t value. 2nd arg is now size_t.
5889 Many local variables are now size_t instead of int or unsigned.
5890 Improve overflow protection. Support `l' modifier for integer
5891 conversions. Support %l conversion. Don't assume an EMACS_INT
5892 argument for integer conversions and for %c.
5893
5894 * lisp.h (doprnt): Restore prototype.
5895
5896 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5897 $(SRC)/character.h.
5898
5899 * Makefile.in (base_obj): Add back doprnt.o.
5900
5901 * deps.mk (doprnt.o): Add back prerequisites.
5902 (callint.o): Depend on character.h.
5903
5904 * eval.c (internal_lisp_condition_case): Include the handler
5905 representation in the error message.
5906 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5907 when breaking from the loop.
5908
5909 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5910
5911 * callint.c (Fcall_interactively): When displaying error message
5912 about invalid control letter, pass the character's codepoint, not
5913 a pointer to its multibyte form. Improve display of the character
5914 in octal and display also its hex code.
5915
5916 * character.c (char_string): Use %x to display the (unsigned)
5917 codepoint of an invalid character, to avoid displaying a bogus
5918 negative value.
5919
5920 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5921 `error', not SYMBOL_NAME itself.
5922
5923 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5924 character arguments to `error'.
5925
5926 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5927 to `error' in error message about FINAL_CHAR argument. Make sure
5928 FINAL_CHAR is a character, and use %c when it is passed as
5929 argument to `error'.
5930
5931 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5932
5933 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5934
5935 * w32.c: Include <time.h>.
5936 (sys_localtime): New function.
5937
5938 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
5939
5940 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5941
5942 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
5943
5944 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
5945
5946 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5947 zombies (Bug#8467).
5948
5949 2011-04-19 Eli Zaretskii <eliz@gnu.org>
5950
5951 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5952 gl_state.e_property when gl_state.object is Qt.
5953
5954 * insdel.c (make_gap_larger): Remove limitation of buffer size
5955 to <= INT_MAX.
5956
5957 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
5958
5959 * xdisp.c (lookup_glyphless_char_display)
5960 (produce_glyphless_glyph): Handle cons cell entry in
5961 glyphless-char-display.
5962 (Vglyphless_char_display): Document it.
5963
5964 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5965 glyphless-char-display.
5966
5967 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
5968
5969 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5970
5971 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5972
5973 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5974 definition for no-X builds.
5975
5976 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
5977
5978 Static checks with GCC 4.6.0 and non-default toolkits.
5979
5980 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5981
5982 * process.c (keyboard_bit_set): Define only if SIGIO.
5983 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5984 (send_process): Repair possible setjmp clobbering.
5985
5986 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5987
5988 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5989
5990 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5991
5992 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5993 Define only if needed.
5994
5995 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5996 by pacifying GCC about it. Maybe it's time to retire it?
5997 * xfaces.c (USG, __TIMEVAL__): Likewise.
5998
5999 * dispextern.h (struct redisplay_interface): Rename param
6000 to avoid shadowing.
6001 * termhooks.h (struct terminal): Likewise.
6002 * xterm.c (xembed_send_message): Likewise.
6003
6004 * insdel.c (make_gap_smaller): Define only if
6005 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6006
6007 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6008 it.
6009
6010 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6011 so that we aren't warned about unused symbols.
6012
6013 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6014
6015 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
6016
6017 * xfns.c (x_real_positions): Mark locals as initialized.
6018
6019 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6020
6021 * xterm.c: Fix problems found by static analysis with other toolkits.
6022 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
6023 (x_dispatch_event): Declare static if USE_GTK, and
6024 define if USE_GTK || USE_X_TOOLKIT.
6025 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
6026 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
6027 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6028 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
6029
6030 * xmenu.c (menu_help_callback): Pointer type fixes.
6031 Use const pointers when pointing at readonly data. Avoid pointer
6032 signedness clashes.
6033 (FALSE): Remove unused macro.
6034 (update_frame_menubar): Remove unused decl.
6035
6036 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6037
6038 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6039 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6040 (single_menu_item): Rename local to avoid shadowing.
6041
6042 * keyboard.c (make_lispy_event): Remove unused local var.
6043
6044 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6045 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6046
6047 * bitmaps: Change bitmaps from unsigned char back to the X11
6048 compatible char. Avoid the old compiler warnings about
6049 out-of-range initializers by using, for example, '\xab' rather
6050 than 0xab.
6051
6052 * xgselect.c (xgselect_initialize): Check vs interface
6053 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6054
6055 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6056
6057 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6058 to read-only memory.
6059
6060 * fns.c (vector): Remove; this old hack is no longer needed.
6061
6062 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
6063 Remove unused var.
6064 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
6065
6066 * xrdb.c (x_load_resources): Omit unused local.
6067
6068 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
6069 (x_window): Rename locals to avoid shadowing.
6070 (USG): Use the kludged USG macro, to pacify gcc.
6071
6072 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
6073 (x_term_init): Remove local to avoid shadowing.
6074
6075 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
6076
6077 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6078 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6079
6080 2011-04-16 Eli Zaretskii <eliz@gnu.org>
6081
6082 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6083
6084 Fix regex.c, syntax.c and friends for buffers > 2GB.
6085 * syntax.h (struct gl_state_s): Declare character position members
6086 EMACS_INT.
6087
6088 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6089
6090 * textprop.c (verify_interval_modification, interval_of):
6091 Declare arguments EMACS_INT.
6092
6093 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6094 EMACS_INT.
6095
6096 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6097
6098 * indent.c (Fvertical_motion): Local variable it_start is now
6099 EMACS_INT.
6100
6101 * regex.c (re_match, re_match_2, re_match_2_internal)
6102 (bcmp_translate, regcomp, regexec, print_double_string)
6103 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6104 (re_compile_pattern, re_exec): Declare arguments and local
6105 variables `size_t' and `ssize_t' and return values `regoff_t', as
6106 appropriate.
6107 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6108 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6109 <compile_stack_type>: `size' and `avail' are now `size_t'.
6110
6111 * regex.h <regoff_t>: Use ssize_t, not int.
6112 (re_search, re_search_2, re_match, re_match_2): Arguments that
6113 specify buffer/string position and length are now ssize_t and
6114 size_t. Return type is regoff_t.
6115
6116 2011-04-16 Ben Key <bkey76@gmail.com>
6117
6118 * nsfont.m: Fixed bugs in ns_get_family and
6119 ns_descriptor_to_entity that were caused by using free to
6120 deallocate memory blocks that were allocated by xmalloc (via
6121 xstrdup). This caused Emacs to crash when compiled with
6122 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6123 --enable-checking=xmallocoverrun). xfree is now used to
6124 deallocate these memory blocks.
6125
6126 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
6127
6128 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6129
6130 emacs_write: Accept and return EMACS_INT for sizes.
6131 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6132 et seq.
6133 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6134 Accept and return EMACS_INT.
6135 (emacs_gnutls_write): Return the number of bytes written on
6136 partial writes.
6137 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
6138 (emacs_read, emacs_write): Remove check for negative size, as the
6139 Emacs source code has been audited now.
6140 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6141 (emacs_read, emacs_write): Use it.
6142 * process.c (send_process): Adjust to the new signatures of
6143 emacs_write and emacs_gnutls_write. Do not attempt to store
6144 a byte offset into an 'int'; it might overflow.
6145 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
6146
6147 * sound.c: Don't assume sizes fit in 'int'.
6148 (struct sound_device.period_size, alsa_period_size):
6149 Return EMACS_INT, not int.
6150 (struct sound_device.write, vox_write, alsa_write):
6151 Accept EMACS_INT, not int.
6152 (wav_play, au_play): Use EMACS_INT to store sizes and to
6153 record read return values.
6154
6155 2011-04-15 Ben Key <bkey76@gmail.com>
6156
6157 * keyboard.c (Qundefined): Don't declare static since it is used
6158 in nsfns.m.
6159 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6160 static since they are used in nsfont.m.
6161
6162 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6163
6164 * process.c (Qprocessp): Don't declare static.
6165 * lisp.h (Qprocessp): Declare again.
6166
6167 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
6168
6169 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6170
6171 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6172
6173 Improve C-level modularity by making more things 'static'.
6174
6175 Don't publish debugger-only interfaces to other modules.
6176 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6177 (verify_bytepos, count_markers): Move decls to the only modules
6178 that need them.
6179 * region-cache.h (pp_cache): Likewise.
6180 * window.h (check_all_windows): Likewise.
6181 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6182
6183 * sysdep.c (croak): Now static, if
6184 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6185 * syssignal.h (croak): Declare only if not static.
6186
6187 * alloc.c (refill_memory_reserve): Now static if
6188 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6189 * lisp.h (refill_memory_reserve): Declare only if not static.
6190
6191 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6192 Define only if USE_LUCID.
6193
6194 * xrdb.c (x_customization_string, x_rm_string): Now static.
6195
6196 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6197 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6198
6199 * xdisp.c (draw_row_with_mouse_face): Now static.
6200 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6201
6202 * window.h (check_all_windows): Mark externally visible.
6203
6204 * window.c (window_deletion_count): Now static.
6205
6206 * undo.c: Make symbols static if they're not exported.
6207 (last_undo_buffer, last_boundary_position, pending_boundary):
6208 Now static.
6209
6210 * textprop.c (interval_insert_behind_hooks): Now static.
6211 (interval_insert_in_front_hooks): Likewise.
6212
6213 * term.c: Make symbols static if they're not exported.
6214 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6215 (max_frame_lines, tty_set_terminal_modes):
6216 (tty_reset_terminal_modes, tty_turn_off_highlight):
6217 (get_tty_terminal): Now static.
6218 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6219 * termhooks.h (term_mouse_moveto): Do not declare if
6220 HAVE_WINDOW_SYSTEM.
6221 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6222 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6223
6224 * sysdep.c: Make symbols static if they're not exported.
6225 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6226 Now static.
6227 (sigprocmask_set, full_mask): Remove; unused.
6228 (wait_debugging): Mark as visible.
6229 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6230 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6231
6232 * syntax.c (syntax_temp): Define only if !__GNUC__.
6233
6234 * sound.c (current_sound_device, current_sound): Now static.
6235
6236 * search.c (searchbufs, searchbuf_head): Now static.
6237
6238 * scroll.c (scroll_cost): Remove; unused.
6239 * dispextern.h (scroll_cost): Remove decl.
6240
6241 * region-cache.h (pp_cache): Mark as externally visible.
6242
6243 * process.c: Make symbols static if they're not exported.
6244 (process_tick, update_tick, create_process, chan_process):
6245 (Vprocess_alist, proc_buffered_char, datagram_access):
6246 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6247 (deactivate_process): Mark defn as static, as well as decl.
6248 * lisp.h (create_process): Remove decl.
6249 * process.h (chan_process, Vprocess_alist): Remove decls.
6250
6251 * print.c: Make symbols static if they're not exported.
6252 (print_depth, new_backquote_output, being_printed, print_buffer):
6253 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6254 (print_interval, print_number_index, initial_stderr_stream):
6255 Now static.
6256 * lisp.h (Fprinc): Remove decl.
6257 (debug_output_compilation_hack): Mark as externally visible.
6258
6259 * sysdep.c (croak): Move decl from here to syssignal.h.
6260 * syssignal.h (croak): Put it here, so the API can be checked when
6261 'croak' is called from dissociate_if_controlling_tty.
6262
6263 * minibuf.c: Make symbols static if they're not exported.
6264 (minibuf_save_list, choose_minibuf_frame): Now static.
6265 * lisp.h (choose_minibuf_frame): Remove decl.
6266
6267 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6268
6269 * lread.c: Make symbols static if they're not exported.
6270 (read_objects, initial_obarray, oblookup_last_bucket_number):
6271 Now static.
6272 (make_symbol): Remove; unused.
6273 * lisp.h (initial_obarray, make_symbol): Remove decls.
6274
6275 * keyboard.c: Make symbols static if they're not exported.
6276 (single_kboard, recent_keys_index, total_keys, recent_keys):
6277 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6278 (this_single_command_key_start, echoing, last_auto_save):
6279 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6280 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6281 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6282 (Vlispy_mouse_stem, double_click_count):
6283 Now static.
6284 (force_auto_save_soon): Define only if SIGDANGER.
6285 (ignore_mouse_drag_p): Now static if
6286 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6287 (print_help): Remove; unused.
6288 (stop_character, last_timer_event): Mark as externally visible.
6289 * keyboard.h (ignore_mouse_drag_p): Declare only if
6290 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6291 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6292 * lisp.h (echoing): Remove decl.
6293 (force_auto_save_soon): Declare only if SIGDANGER.
6294 * xdisp.c (redisplay_window): Simplify code, to make it more
6295 obvious that ignore_mouse_drag_p is not accessed if !defined
6296 USE_GTK && !defined HAVE_NS.
6297
6298 * intervals.c: Make symbols static if they're not exported.
6299 (merge_properties_sticky, merge_interval_right, delete_interval):
6300 Now static.
6301 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6302
6303 * insdel.c: Make symbols static if they're not exported.
6304 However, leave prepare_to_modify_buffer alone. It's never
6305 called from outside this function, but that appears to be a bug.
6306 (combine_after_change_list, combine_after_change_buffer):
6307 (adjust_after_replace, signal_before_change): Now static.
6308 (adjust_after_replace_noundo): Remove; unused.
6309 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
6310 (signal_before_change): Remove decls.
6311
6312 * indent.c (val_compute_motion, val_vmotion): Now static.
6313
6314 * image.c: Make symbols static if they're not exported.
6315 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6316 if USE_GTK.
6317 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6318 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6319
6320 * fringe.c (standard_bitmaps): Now static.
6321 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6322
6323 * frame.c: Make symbols static if they're not exported.
6324 (x_report_frame_params, make_terminal_frame): Now static.
6325 (get_frame_param): Now static, unless HAVE_NS.
6326 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6327 (x_get_resource_string): Remove; not used.
6328 * frame.h (make_terminal_frame, x_report_frame_params):
6329 (x_get_resource_string); Remove decls.
6330 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6331 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6332
6333 * font.c, fontset.c: Make symbols static if they're not exported.
6334 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6335 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6336 * font.c (font_close_object): Now static.
6337 * font.h (font_close_object): Remove.
6338 * fontset.c (FONTSET_OBJLIST): Remove.
6339 (free_realized_fontset) #if-0 the body, which does nothing.
6340 (face_suitable_for_char_p): #if-0, as it's never called.
6341 * fontset.h (face_suitable_for_char_p): Remove decl.
6342 * xfaces.c (face_at_string_position):
6343 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
6344 since 0 is always ASCII.
6345
6346 * fns.c (weak_hash_tables): Now static.
6347
6348 * fileio.c: Make symbols static if they're not exported.
6349 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6350 (Vwrite_region_annotation_buffers): Now static.
6351
6352 * eval.c: Make symbols static if they're not exported.
6353 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6354 * lisp.h (backtrace_list): Remove decl.
6355
6356 * emacs.c: Make symbols static if they're not exported.
6357 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6358 (fatal_error_code, fatal_error_signal_hook, standard_args):
6359 Now static.
6360 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6361 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6362 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6363 * lisp.h (fatal_error_signal_hook): Remove decl.
6364 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6365
6366 * editfns.c: Move a (normally-unused) function to its only use.
6367 * editfns.c, lisp.h (get_operating_system_release): Remove.
6368 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6369 worth the hassle of breaking this out.
6370
6371 * xterm.c: Make symbols static if they're not exported.
6372 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6373 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6374 (x_destroy_window, x_delete_display):
6375 Now static.
6376 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6377 (x_mouse_leave): Remove; unused.
6378 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6379 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6380 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6381 Remove decls.
6382 (x_mouse_leave): Declare only if WINDOWSNT.
6383 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6384 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6385 USE_X_TOOLKIT.
6386
6387 * ftxfont.c: Make symbols static if they're not exported.
6388 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6389 HAVE_FREETYPE.
6390 * font.h (ftxfont_driver): Likewise.
6391
6392 * xfns.c: Make symbols static if they're not exported.
6393 (x_last_font_name, x_display_info_for_name):
6394 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6395 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6396 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6397 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6398 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6399 (last_show_tip_args): Now static.
6400 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6401 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6402 (x_screen_planes): Remove; unused.
6403 * dispextern.h (x_screen_planes): Remove decl.
6404
6405 * dispnew.c: Make symbols static if they're not exported.
6406 * dispextern.h (redraw_garbaged_frames, scrolling):
6407 (increment_row_positions): Remove.
6408 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6409 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6410 Now static.
6411 (redraw_garbaged_frames): Remove; unused.
6412
6413 * xfaces.c: Make symbols static if they're not exported.
6414 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6415 Remove decls.
6416 * xterm.h (defined_color): Remove decls.
6417 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6418 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6419 (menu_face_changed_default, defined_color, free_realized_face):
6420 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6421 (ascii_face_of_lisp_face): Remove; unused.
6422
6423 * xdisp.c: Make symbols static if they're not exported.
6424 * dispextern.h (scratch_glyph_row, window_box_edges):
6425 (glyph_to_pixel_coords, set_cursor_from_row):
6426 (get_next_display_element, set_iterator_to_next):
6427 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6428 (show_mouse_face): Remove decls
6429 * frame.h (message_buf_print): Likewise.
6430 * lisp.h (pop_message, set_message, check_point_in_composition):
6431 Likewise.
6432 * xterm.h (set_vertical_scroll_bar): Likewise.
6433 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6434 (message_buf_print, scratch_glyph_row, displayed_buffer):
6435 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6436 (get_next_display_element, show_mouse_face, window_box_edges):
6437 (frame_to_window_pixel_xy, check_point_in_composition):
6438 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6439 (glyph_to_pixel_coords): Remove; unused.
6440
6441 * dired.c (file_name_completion): Now static.
6442
6443 * dbusbind.c (xd_in_read_queued_messages): Now static.
6444
6445 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6446 * data.c (circular_list_error): Remove.
6447
6448 * commands.h (last_point_position, last_point_position_buffer):
6449 (last_point_position_window): Remove decls.
6450 * keyboard.c: Make these variables static.
6451
6452 * coding.h (coding, code_convert_region, encode_coding_gap):
6453 Remove decls.
6454 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6455 (iso_code_class, detect_coding, code_convert_region): Now static.
6456 (encode_coding_gap): Remove; unused.
6457
6458 * chartab.c (chartab_chars, chartab_bits): Now static.
6459
6460 * charset.h (charset_iso_8859_1): Remove decl.
6461 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6462 Now static.
6463
6464 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6465 * ccl.c (Vccl_program_table): Now static.
6466 (check_ccl_update): Remove; unused.
6467
6468 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6469 * category.h: ... from here.
6470 * category.c (check_category_table, set_category_set): Now static.
6471
6472 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6473 * lisp.h: Remove these decls.
6474
6475 * buffer.c (buffer_count): Remove unused var.
6476
6477 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6478 so that it's not optimized away.
6479 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6480 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6481 exported only to the debugger.
6482
6483 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
6484 * atimer.h (run_all_atimers): Remove; not exported.
6485
6486 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6487 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6488 was inaccessible from Lisp.
6489 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6490 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6491
6492 alloc.c: Import and export fewer symbols, and remove unused items.
6493 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6494 is defined.
6495 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6496 it's not optimized away by whole-program optimization.
6497 (message_enable_multibyte, free_misc): Remove.
6498 (catchlist, handlerlist, mark_backtrace):
6499 Declare only if BYTE_MARK_STACK.
6500 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6501 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6502 (message_enable_multibyte): Remove decl.
6503 (free_misc, interval_free_list, float_block, float_block_index):
6504 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6505 (cons_free_list, last_marked_index):
6506 Now static.
6507 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6508 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6509 (mark_backtrace): Define only if BYTE_MARK_STACK.
6510 * xdisp.c (message_enable_multibyte): Now static.
6511
6512 Declare Lisp_Object Q* variables to be 'static' if not exported.
6513 This makes it easier for human readers (and static analyzers)
6514 to see whether these variables are used from other modules.
6515 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6516 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6517 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6518 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6519 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6520 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6521 * xmenu.c, xselect.c:
6522 Declare Q* vars static if they are not used in other modules.
6523 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6524 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6525 Remove decls of unexported vars.
6526 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6527
6528 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6529
6530 Make Emacs functions such as Fatom 'static' by default.
6531 This makes it easier for human readers (and static analyzers)
6532 to see whether these functions can be called from other modules.
6533 DEFUN now defines a static function. To make the function external
6534 so that it can be used in other C modules, use the new macro DEFUE.
6535 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6536 (Finit_image_library):
6537 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6538 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6539 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6540 Remove decls, since these functions are now static.
6541 (Funintern, Fget_internal_run_time): New decls, since these functions
6542 were already external.
6543
6544 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6545 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6546 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6547 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6548 * keyboard.c, keymap.c, lread.c:
6549 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6550 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6551 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6552 Mark functions with DEFUE instead of DEFUN,
6553 if they are used in other modules.
6554 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6555 decls for now-static functions.
6556 * buffer.h (Fdelete_overlay): Remove decl.
6557 * callproc.c (Fgetenv_internal): Mark as internal.
6558 * composite.c (Fremove_list_of_text_properties): Remove decl.
6559 (Fcomposition_get_gstring): New forward static decl.
6560 * composite.h (Fcomposite_get_gstring): Remove decl.
6561 * dired.c (Ffile_attributes): New forward static decl.
6562 * doc.c (Fdocumntation_property): New forward static decl.
6563 * eval.c (Ffetch_bytecode): New forward static decl.
6564 (Funintern): Remove extern decl; now in .h file where it belongs.
6565 * fileio.c (Fmake_symbolic_link): New forward static decl.
6566 * image.c (Finit_image_library): New forward static decl.
6567 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6568 * intervals.h (Fprevious_property_change):
6569 (Fremove_list_of_text_properties): Remove decls.
6570 * keyboard.c (Fthis_command_keys): Remove decl.
6571 (Fcommand_execute): New forward static decl.
6572 * keymap.c (Flookup_key): New forward static decl.
6573 (Fcopy_keymap): Now static.
6574 * keymap.h (Flookup_key): Remove decl.
6575 * process.c (Fget_process): New forward static decl.
6576 (Fprocess_datagram_address): Mark as internal.
6577 * syntax.c (Fsyntax_table_p): New forward static decl.
6578 (skip_chars): Remove duplicate decl.
6579 * textprop.c (Fprevious_property_change): New forward static decl.
6580 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6581 Now internal.
6582 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6583 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6584
6585 * editfns.c (Fformat): Remove unreachable code.
6586
6587 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6588
6589 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6590 change. (Bug#8496)
6591
6592 2011-04-13 Eli Zaretskii <eliz@gnu.org>
6593
6594 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6595 when at ZV. (Bug#8487)
6596
6597 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6598
6599 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6600 (Bug#8437)
6601 * keyboard.c (parse_tool_bar_item): Likewise.
6602 * sound.c (sound_cleanup, alsa_close): Likewise.
6603 * termcap.c (tgetent): Likewise.
6604 * xfns.c (x_default_font_parameter): Likewise.
6605 * xsettings.c (read_and_apply_settings): Likewise.
6606
6607 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6608 (overrun_check_free): Protoize.
6609
6610 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6611
6612 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6613 since callers should never pass a negative size.
6614 Change the signature to match that of plain 'read' and 'write'; see
6615 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6616 * lisp.h: Update prototypes of emacs_write and emacs_read.
6617
6618 2011-04-11 Eli Zaretskii <eliz@gnu.org>
6619
6620 * xdisp.c (redisplay_window): Don't try to determine the character
6621 position of the scroll margin if the window start point w->startp
6622 is outside the buffer's accessible region. (Bug#8468)
6623
6624 2011-04-10 Eli Zaretskii <eliz@gnu.org>
6625
6626 Fix write-region and its subroutines for buffers > 2GB.
6627 * fileio.c (a_write, e_write): Modify declaration of arguments and
6628 local variables to support buffers larger than 2GB.
6629 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6630
6631 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6632 argument, local variables, and return value.
6633
6634 * lisp.h: Update prototypes of emacs_write and emacs_read.
6635
6636 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6637
6638 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
6639
6640 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6641
6642 Fix more problems found by GCC 4.6.0's static checks.
6643
6644 * xdisp.c (vmessage): Use a better test for character truncation.
6645
6646 * charset.c (load_charset_map): <, not <=, for optimization,
6647 and to avoid potential problems with integer overflow.
6648 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
6649 * casetab.c (set_identity, shuffle): Likewise.
6650 * editfns.c (Fformat): Likewise.
6651 * syntax.c (skip_chars): Likewise.
6652
6653 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6654 This also lets GCC 4.6.0 generate slightly better loop code.
6655
6656 * callint.c (Fcall_interactively): <, not <=, for optimization.
6657 (Fcall_interactively): Count the number of arguments produced,
6658 not the number of arguments given. This is simpler and lets GCC
6659 4.6.0 generate slightly better code.
6660
6661 * ftfont.c: Distingish more carefully between FcChar8 and char.
6662 The previous code passed unsigned char * to a functions like
6663 strlen and xstrcasecmp that expect char *, which does not
6664 conform to the C standard.
6665 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6666 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6667 char * when the C standard requires it.
6668
6669 * keyboard.c (read_char): Remove unused var.
6670
6671 * eval.c: Port to Windows vsnprintf (Bug#8435).
6672 Include <limits.h>.
6673 (SIZE_MAX): Define if the headers do not.
6674 (verror): Do not give up if vsnprintf returns a negative count.
6675 Instead, grow the buffer. This ports to Windows vsnprintf, which
6676 does not conform to C99. Problem reported by Eli Zaretskii.
6677 Also, simplify the allocation scheme, by avoiding the need for
6678 calling realloc, and removing the ALLOCATED variable.
6679
6680 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6681
6682 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6683 But keep the doprint source code for now, as we might revamp it
6684 and use it again (Bug#8435).
6685 * lisp.h (doprnt): Remove.
6686 * Makefile.in (base_obj): Remove doprnt.o.
6687 * deps.mk (doprnt.o): Remove.
6688
6689 error: Print 32- and 64-bit integers portably (Bug#8435).
6690 Without this change, on typical 64-bit hosts error ("...%d...", N)
6691 was used to print both 32- and 64-bit integers N, which relied on
6692 undefined behavior.
6693 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6694 New macro.
6695 * lisp.h (error, verror): Mark as printf-like functions.
6696 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6697 Report overflow in size calculations when allocating printf buffer.
6698 Do not truncate output string at its first null byte.
6699 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6700 Truncate the output at a character boundary, since vsnprintf does not
6701 do that.
6702 * charset.c (check_iso_charset_parameter): Convert internal
6703 character to string before calling 'error', since %c now has the
6704 printf meaning.
6705 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6706 overflow when computing char to be passed to 'error'. Do not
6707 pass Lisp_Object to 'error'; pass the integer instead.
6708 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6709 formatted with plain %d.
6710
6711 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6712
6713 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6714
6715 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6716
6717 * xterm.c (x_catch_errors): Remove duplicate declaration.
6718
6719 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6720
6721 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6722
6723 2011-04-10 Jim Meyering <meyering@redhat.com>
6724
6725 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6726 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6727 return ssize_t not "int", and use size_t as the buffer length.
6728 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6729 * gnutls.h: Update declarations.
6730 * process.c (read_process_output): Use ssize_t, to match.
6731 (send_process): Likewise.
6732
6733 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6734
6735 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6736
6737 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6738
6739 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6740 Use unsigned char, to match FcChar8 type definition.
6741
6742 * xterm.c (handle_one_xevent):
6743 * xmenu.c (create_and_show_popup_menu):
6744 * xselect.c (x_decline_selection_request)
6745 (x_reply_selection_request): Avoid type-punned deref of X events.
6746
6747 2011-04-09 Eli Zaretskii <eliz@gnu.org>
6748
6749 Fix some uses of `int' instead of EMACS_INT.
6750 * search.c (string_match_1, fast_string_match)
6751 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6752 (scan_buffer, find_next_newline_no_quit)
6753 (find_before_next_newline, search_command, Freplace_match)
6754 (Fmatch_data): Make some `int' variables be EMACS_INT.
6755
6756 * xdisp.c (display_count_lines): 3rd argument and return value now
6757 EMACS_INT. All callers changed.
6758 (pint2hrstr): Last argument is now EMACS_INT.
6759
6760 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6761 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6762 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6763 (decode_coding_utf_16, decode_coding_emacs_mule)
6764 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6765 (decode_coding_ccl, decode_coding_charset)
6766 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6767 (decode_coding_iso_2022, decode_coding_emacs_mule)
6768 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6769 <char_offset, last_offset>: Declare EMACS_INT.
6770 (encode_coding_utf_8, encode_coding_utf_16)
6771 (encode_coding_emacs_mule, encode_invocation_designation)
6772 (encode_designation_at_bol, encode_coding_iso_2022)
6773 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6774 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6775 Declare EMACS_INT.
6776 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6777 (encode_invocation_designation): Last argument P_NCHARS is now
6778 EMACS_INT.
6779 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6780 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6781
6782 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6783 All users changed.
6784
6785 * ccl.c (Fccl_execute_on_string): Declare some variables
6786 EMACS_INT.
6787
6788 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
6789
6790 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6791
6792 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6793
6794 * process.c (Fformat_network_address): Doc fix.
6795
6796 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6797
6798 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6799
6800 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
6801
6802 * keyboard.c (read_char): Call Lisp function help-form-show,
6803 instead of using internal_with_output_to_temp_buffer.
6804 (Qhelp_form_show): New var.
6805 (syms_of_keyboard): Use DEFSYM macro.
6806
6807 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6808
6809 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6810
6811 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
6812
6813 * process.c (Flist_processes): Remove to Lisp.
6814 (list_processes_1): Delete.
6815
6816 2011-04-06 Eli Zaretskii <eliz@gnu.org>
6817
6818 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6819
6820 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6821
6822 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
6823
6824 Fix more problems found by GCC 4.6.0's static checks.
6825
6826 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6827
6828 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6829
6830 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
6831
6832 * xdisp.c (vmessage): Mark as a printf-like function.
6833
6834 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6835
6836 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6837
6838 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6839 printf-like functions.
6840 (tiff_load): Add casts to remove these marks before passing them
6841 to system-supplied API.
6842
6843 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6844
6845 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6846 This avoids several warnings with gcc -Wstrict-overflow.
6847 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6848 directly, rather than having caller test rule sign. This avoids
6849 some unnecessary tests.
6850 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6851 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6852 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
6853
6854 * xfont.c (xfont_text_extents): Remove var that was set but not used.
6855 (xfont_open): Avoid unnecessary tests.
6856
6857 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6858
6859 * composite.h, composite.c (composition_gstring_put_cache):
6860 Use EMACS_INT, not int, for length.
6861
6862 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6863 breaking out part of COMPOSITION_DECODE_RULE.
6864 (COMPOSITION_DECODE_RULE): Use it.
6865 * composite.c (get_composition_id): Remove unused local vars,
6866 by using the new macro.
6867
6868 * textprop.c (set_text_properties_1): Change while to do-while,
6869 since the condition is always true at first.
6870
6871 * intervals.c (graft_intervals_into_buffer): Mark var as used.
6872 (interval_deletion_adjustment): Return unsigned value.
6873 All uses changed.
6874
6875 * process.c (list_processes_1, create_pty, read_process_output):
6876 (exec_sentinel): Remove vars that were set but not used.
6877 (create_pty): Remove unnecessary "volatile"s.
6878 (Fnetwork_interface_info): Avoid possibility of int overflow.
6879 (read_process_output): Do adaptive read buffering even if carryover.
6880 (read_process_output): Simplify nbytes computation if buffered.
6881
6882 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6883
6884 * syntax.c (scan_words): Remove var that was set but not used.
6885 (update_syntax_table): Use unsigned instead of int.
6886
6887 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
6888 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
6889 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
6890
6891 * print.c (print_error_message): Avoid int overflow.
6892
6893 * font.c (font_list_entities): Redo for clarity,
6894 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6895
6896 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
6897 (font_score): Avoid potential overflow in diff calculation.
6898
6899 * fns.c (substring_both): Remove var that is set but not used.
6900 (sxhash): Redo loop for clarity and to avoid wraparound warning.
6901
6902 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6903
6904 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6905 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6906 can always succeed if overflow has undefined behavior.
6907
6908 * search.c (boyer_moore, wordify): Remove vars set but not used.
6909 (wordify): Omit three unnecessary tests.
6910
6911 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6912 All callers changed. This avoids the need for an unused var.
6913
6914 * casefiddle.c (casify_region): Remove var that is set but not used.
6915
6916 * dired.c (file_name_completion): Remove var that is set but not used.
6917
6918 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6919
6920 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
6921 (Finsert_file_contents): Remove unnecessary code checking fd.
6922
6923 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6924 Check for integer overflow on size calculations.
6925
6926 * buffer.c (Fprevious_overlay_change): Remove var that is set
6927 but not used.
6928
6929 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6930 Remove vars that are set but not used.
6931 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6932 (timer_check_2): Mark vars as initialized.
6933
6934 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6935
6936 * image.c (lookup_image): Remove var that is set but not used.
6937 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
6938
6939 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6940 that are set but not used.
6941
6942 * xfns.c (make_invisible_cursor): Don't return garbage
6943 if XCreateBitmapFromData fails (Bug#8410).
6944
6945 * xselect.c (x_get_local_selection, x_handle_property_notify):
6946 Remove vars that are set but not used.
6947
6948 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6949 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
6950
6951 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6952 Remove var that is set but not used.
6953 (scroll_bar_windows_size): Now size_t, not int.
6954 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6955 Check for overflow.
6956
6957 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6958 (map_tty_color) [!defined MSDOS]: Likewise.
6959
6960 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6961
6962 * coding.c: Remove vars that are set but not used.
6963 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6964 All callers changed.
6965 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6966 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6967 (decode_coding_charset): Remove vars that are set but not used.
6968
6969 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6970 that is set but not used.
6971
6972 * print.c (print_object): Remove var that is set but not used.
6973
6974 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
6975 The gnulib version avoids calling malloc in the usual case,
6976 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6977 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6978 * filelock.c (current_lock_owner): Likewise.
6979 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6980 * sysdep.c: Include allocator.h, careadlinkat.h.
6981 (emacs_no_realloc_allocator): New static constant.
6982 (emacs_readlink): New function.
6983 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6984 ../lib/careadlinkat.h.
6985
6986 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6987
6988 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6989 first non-nil return value).
6990
6991 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6992
6993 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6994 if not defined (Bug#8403).
6995
6996 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6997
6998 * xdisp.c (display_count_lines): Remove parameter `start',
6999 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7000 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7001 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7002 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7003 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7004 and thereabouts. All callers changed.
7005 (get_per_char_metric): Remove parameter `f', unused since
7006 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7007
7008 2011-04-02 Jim Meyering <meyering@redhat.com>
7009
7010 do not dereference NULL upon failed strdup
7011 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7012 (ns_get_family): Likewise.
7013
7014 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7015
7016 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7017
7018 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7019
7020 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7021 later (Bug#8403).
7022
7023 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7024
7025 Add lexical binding.
7026
7027 * window.c (Ftemp_output_buffer_show): New fun.
7028 (Fsave_window_excursion):
7029 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7030
7031 * lread.c (lisp_file_lexically_bound_p): New function.
7032 (Fload): Bind Qlexical_binding.
7033 (readevalloop): Remove `evalfun' arg.
7034 Bind Qinternal_interpreter_environment.
7035 (Feval_buffer): Bind Qlexical_binding.
7036 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7037 Mark as dynamic.
7038 (syms_of_lread): Declare `lexical-binding'.
7039
7040 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7041
7042 * keyboard.c (eval_dyn): New fun.
7043 (menu_item_eval_property): Use it.
7044
7045 * image.c (parse_image_spec): Use Ffunctionp.
7046
7047 * fns.c (concat, mapcar1): Accept byte-code-functions.
7048
7049 * eval.c (Fsetq): Handle lexical vars.
7050 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7051 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7052 (FletX, Flet): Obey lexical binding.
7053 (Fcommandp): Handle closures.
7054 (Feval): New `lexical' arg.
7055 (eval_sub): New function extracted from Feval. Use it almost
7056 everywhere where Feval was used. Look up vars in lexical env.
7057 Handle closures.
7058 (Ffunctionp): Move from subr.el.
7059 (Ffuncall): Handle closures.
7060 (apply_lambda): Remove `eval_flags'.
7061 (funcall_lambda): Handle closures and new byte-code-functions.
7062 (Fspecial_variable_p): New function.
7063 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7064 but without exporting it to Lisp.
7065
7066 * doc.c (Fdocumentation, store_function_docstring):
7067 * data.c (Finteractive_form): Handle closures.
7068
7069 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7070 interactive spec.
7071
7072 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7073 New byte-codes.
7074 (exec_byte_code): New function extracted from Fbyte_code to handle new
7075 calling convention for byte-code-functions. Add new byte-codes.
7076
7077 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
7078
7079 * alloc.c (Fmake_symbol): Init new `declared_special' field.
7080
7081 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7082
7083 * xdisp.c (redisplay_internal): Fix prototype.
7084
7085 2011-03-31 Eli Zaretskii <eliz@gnu.org>
7086
7087 * xdisp.c (SCROLL_LIMIT): New macro.
7088 (try_scrolling): Use it when setting scroll_limit.
7089 Limit scrolling to 100 screen lines.
7090 (redisplay_window): Even when falling back on "recentering",
7091 position point in the window according to scroll-conservatively,
7092 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7093
7094 (try_scrolling): When point is above the window, allow searching
7095 as far as scroll_max, or one screenful, to compute vertical
7096 distance from PT to the scroll margin position. This prevents
7097 try_scrolling from unnecessarily failing when
7098 scroll-conservatively is set to a value slightly larger than the
7099 window height. Clean up the case of PT below the margin at bottom
7100 of window: scroll_max can no longer be INT_MAX. When aggressive
7101 scrolling is in use, don't let point enter the opposite scroll
7102 margin as result of the scroll.
7103 (syms_of_xdisp) <scroll-conservatively>: Document the
7104 threshold of 100 lines for never-recentering scrolling.
7105
7106 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7107
7108 * dispextern.h (move_it_by_lines):
7109 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7110 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7111 (message_log_check_duplicate): Remove parameters `prev_bol' and
7112 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7113 (redisplay_internal): Remove parameter `preserve_echo_area',
7114 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7115
7116 * indent.c (Fvertical_motion):
7117 * window.c (window_scroll_pixel_based, Frecenter):
7118 Don't pass `need_y_p' to `move_it_by_lines'.
7119
7120 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7121
7122 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7123 steal a few bits to be more compact.
7124 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7125 Remove unneeded casts.
7126
7127 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7128
7129 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7130
7131 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7132 binding" message (bug#7967).
7133
7134 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7135
7136 Fix more problems found by GCC 4.6.0's static checks.
7137
7138 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7139 Remove unused local var.
7140
7141 * editfns.c (Fmessage_box): Remove unused local var.
7142
7143 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7144 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7145 Omit unused local vars.
7146 * window.c (shrink_windows): Omit unused local var.
7147 * menu.c (digest_single_submenu): Omit unused local var.
7148 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7149 Omit unused local var.
7150
7151 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7152 Don't assume string length fits in int.
7153 (keyremap_step, read_key_sequence): Use size_t for sizes.
7154 (read_key_sequence): Don't check last_real_key_start redundantly.
7155
7156 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7157 instead of alloca (Bug#8344).
7158
7159 * eval.c (Fbacktrace): Don't assume nargs fits in int.
7160 (Fbacktrace_frame): Don't assume nframes fits in int.
7161
7162 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7163
7164 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7165 concerns.
7166
7167 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7168
7169 * cm.c (calccost): Turn while-do into do-while, for clarity.
7170
7171 * keyboard.c (syms_of_keyboard): Use the same style as later
7172 in this function when indexing through an array. This also
7173 works around GCC bug 48267.
7174
7175 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7176
7177 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7178
7179 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7180 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7181
7182 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7183 This avoids undefined behavior on integer overflow, and is a bit
7184 more convenient anyway since it is compared to a size_t variable.
7185
7186 Variadic C functions now count arguments with size_t, not int.
7187 This avoids an unnecessary limitation on 64-bit machines, which
7188 caused (substring ...) to crash on large vectors (Bug#8344).
7189 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7190 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
7191 All variadic functions and their callers changed accordingly.
7192 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7193 * data.c (arith_driver, float_arith_driver): Likewise.
7194 * editfns.c (general_insert_function): Likewise.
7195 * eval.c (struct backtrace.nargs, interactive_p)
7196 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7197 (funcall_lambda, mark_backtrace): Likewise.
7198 * fns.c (concat): Likewise.
7199 * frame.c (x_set_frame_parameters): Likewise.
7200 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7201 0 if not found, not -1. All callers changed.
7202
7203 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7204 (stack_copy_size): Now size_t, not int.
7205 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7206
7207 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
7208
7209 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7210 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7211 All callers changed.
7212
7213 * lisp.h (multibyte_char_to_unibyte):
7214 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7215 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7216 * character.h (CHAR_TO_BYTE8):
7217 * cmds.c (internal_self_insert):
7218 * editfns.c (general_insert_function):
7219 * keymap.c (push_key_description):
7220 * search.c (Freplace_match):
7221 * xdisp.c (message_dolog, set_message_1): All callers changed.
7222
7223 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7224
7225 * keyboard.c (safe_run_hook_funcall): New function.
7226 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7227 don't set the hook to nil, but remove the offending function instead.
7228 (Qcommand_hook_internal): Remove, unused.
7229 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7230 Vcommand_hook_internal.
7231
7232 * eval.c (enum run_hooks_condition): Remove.
7233 (funcall_nil, funcall_not): New functions.
7234 (run_hook_with_args): Call each function through a `funcall' argument.
7235 Remove `cond' argument, now redundant.
7236 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7237 (Frun_hook_with_args_until_failure): Adjust accordingly.
7238 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7239
7240 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
7241
7242 * dispextern.h (string_buffer_position): Remove declaration.
7243
7244 * print.c (strout): Remove parameter `multibyte', unused since
7245 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7246
7247 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7248 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7249 All callers changed.
7250
7251 * w32.c (_wsa_errlist): Use braces for struct initializers.
7252
7253 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7254 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7255 All callers changed.
7256 (string_buffer_position): Likewise. Also, make static (it's never
7257 used outside xdisp.c).
7258 (cursor_row_p): Remove parameter `w', unused since
7259 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7260 (decode_mode_spec): Remove parameter `precision', introduced during
7261 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7262 All callers changed.
7263
7264 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7265
7266 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7267
7268 2011-03-27 Anders Lindgren <andlind@gmail.com>
7269
7270 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7271 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7272 (ns_update_auto_hide_menu_bar): New functions.
7273 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7274 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7275 ns_constrain_all_frames.
7276 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7277 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7278
7279 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7280
7281 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7282
7283 2011-03-27 Glenn Morris <rgm@gnu.org>
7284
7285 * syssignal.h: Replace RETSIGTYPE with void.
7286 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7287 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7288 Replace SIGTYPE with void everywhere.
7289 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7290 * s/template.h (SIGTYPE): Remove commented out definition.
7291
7292 2011-03-26 Eli Zaretskii <eliz@gnu.org>
7293
7294 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7295 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7296
7297 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
7298
7299 * w32.c (read_unc_volume): Use parameter `henum', instead of
7300 global variable `wget_enum_handle'.
7301
7302 * keymap.c (describe_vector): Remove parameters `indices' and
7303 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7304 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7305
7306 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7307
7308 * keyboard.c (timer_check): Remove parameter `do_it_now',
7309 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7310 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7311 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7312
7313 * keyboard.c (read_char):
7314 * w32menu.c (w32_menu_display_help):
7315 * xmenu.c (show_help_event, menu_help_callback):
7316 Adjust calls to `show_help_echo'.
7317
7318 * gtkutil.c (xg_maybe_add_timer):
7319 * keyboard.c (readable_events):
7320 * process.c (wait_reading_process_output):
7321 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7322
7323 * insdel.c (adjust_markers_gap_motion):
7324 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7325 (gap_left, gap_right): Don't call it.
7326
7327 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
7328
7329 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7330 incurred during fontification.
7331
7332 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
7333
7334 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7335 (DEFVAR_PER_BUFFER): Don't pass it.
7336
7337 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7338 (scrolling_window): Don't pass it.
7339
7340 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
7341
7342 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7343
7344 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7345 and `suffix'.
7346 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7347 of variables specific to SELinux and computation of `encoded_absname'.
7348
7349 * image.c (XPutPixel): Remove unused variable `height'.
7350
7351 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7352
7353 * unexw32.c (get_section_info): Remove unused variable `section'.
7354
7355 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7356 (system_process_attributes): Remove unused variable `sess'.
7357 (sys_read): Remove unused variable `err'.
7358
7359 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7360 (w32_wnd_proc): Remove unused variable `isdead'.
7361 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7362 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7363 (x_create_tip_frame): Remove unused variable `tem'.
7364
7365 * w32inevt.c (w32_console_read_socket):
7366 Remove unused variable `no_events'.
7367
7368 * w32term.c (x_draw_composite_glyph_string_foreground):
7369 Remove unused variable `width'.
7370
7371 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
7372
7373 * w32term.c (x_set_glyph_string_clipping):
7374 Don't pass uninitialized region to CombineRgn.
7375
7376 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
7377
7378 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7379 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7380 (Fx_close_connection): Remove unused variable `i'.
7381
7382 * w32font.c (w32font_draw): Return number of glyphs.
7383 (w32font_open_internal): Remove unused variable `i'.
7384 (w32font_driver): Add missing initializer.
7385
7386 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7387 (fill_in_menu): Remove unused variable `items_added'.
7388
7389 * w32term.c (last_mouse_press_frame): Remove static global variable.
7390 (w32_clip_to_row): Remove unused variable `f'.
7391 (x_delete_terminal): Remove unused variable `i'.
7392
7393 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7394 (NOTHING): Remove unused static global variable.
7395 (uniscribe_check_otf): Remove unused variable `table'.
7396 (uniscribe_font_driver): Add missing initializers.
7397
7398 2011-03-23 Julien Danjou <julien@danjou.info>
7399
7400 * term.c (Fsuspend_tty, Fresume_tty):
7401 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7402 * window.c (temp_output_buffer_show):
7403 * insdel.c (signal_before_change):
7404 * frame.c (Fhandle_switch_frame):
7405 * fileio.c (Fdo_auto_save):
7406 * emacs.c (Fkill_emacs):
7407 * editfns.c (save_excursion_restore):
7408 * cmds.c (internal_self_insert):
7409 * callint.c (Fcall_interactively):
7410 * buffer.c (Fkill_all_local_variables):
7411 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7412 Use Frun_hooks.
7413 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
7414 unconditionnaly since it does the check itself.
7415
7416 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
7417
7418 Fix more problems found by GCC 4.5.2's static checks.
7419
7420 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7421 the first time through the loop, since we know p0 < p1 then.
7422 This also avoids a gcc -Wstrict-overflow warning.
7423
7424 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7425 leading to a memory leak, possible in functions like
7426 load_charset_map_from_file that can allocate an unbounded number
7427 of objects (Bug#8318).
7428
7429 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7430 that could (at least in theory) be that large.
7431
7432 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7433 This is less likely to overflow, and avoids undefined behavior if
7434 overflow does occur. All callers changed. Use strtoul to scan
7435 for the unsigned long integer.
7436 (pint2hrstr): Simplify and tune code slightly.
7437 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
7438
7439 * scroll.c (do_scrolling): Work around GCC bug 48228.
7440 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7441
7442 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7443 This also avoids a warning with gcc -Wstrict-overflow.
7444 (validate_x_resource_name): Simplify count usage.
7445 This also avoids a warning with gcc -Wstrict-overflow.
7446
7447 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7448 fail (Bug#8306).
7449
7450 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
7451
7452 * process.c (Fmake_network_process): Use socklen_t, not int,
7453 where POSIX says socklen_t is required in portable programs.
7454 This fixes a porting bug on hosts like 64-bit HP-UX, where
7455 socklen_t is wider than int (Bug#8277).
7456 (Fmake_network_process, server_accept_connection):
7457 (wait_reading_process_output, read_process_output):
7458 Likewise.
7459
7460 * process.c: Rename or move locals to avoid shadowing.
7461 (list_processes_1, Fmake_network_process):
7462 (read_process_output_error_handler, exec_sentinel_error_handler):
7463 Rename or move locals.
7464 (Fmake_network_process): Define label "retry_connect" only if needed.
7465 (Fnetwork_interface_info): Fix pointer signedness.
7466 (process_send_signal): Add cast to avoid pointer signedness problem.
7467 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
7468 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
7469
7470 Make tparam.h and terminfo.c consistent.
7471 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7472 Include tparam.h instead, since it declares them.
7473 * cm.h (PC): Remove extern decl; tparam.h now does this.
7474 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7475 * terminfo.c: Include tparam.h, to check interfaces.
7476 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7477 (tparam): Adjust signature to match interface in tparam.h;
7478 this removes some undefined behavior. Check that outstring and len
7479 are zero, which they always are with Emacs.
7480 * tparam.h (PC, BC, UP): New extern decls.
7481
7482 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
7483 (xftfont_open): Rename locals to avoid shadowing.
7484
7485 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
7486 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7487 (OTF_TAG_SYM): Omit macro if not needed.
7488 (ftfont_list): Remove unused local.
7489 (get_adstyle_property, ftfont_pattern_entity):
7490 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7491 Rename locals to avoid shadowing.
7492
7493 * xfont.c (xfont_list_family): Mark var as initialized.
7494
7495 * xml.c (make_dom): Now static.
7496
7497 * composite.c (composition_compute_stop_pos): Rename local to
7498 avoid shadowing.
7499 (composition_reseat_it): Remove unused locals.
7500 (find_automatic_composition, composition_adjust_point): Likewise.
7501 (composition_update_it): Mark var as initialized.
7502 (find_automatic_composition): Mark vars as initialized,
7503 with a FIXME (Bug#8290).
7504
7505 character.h: Rename locals to avoid shadowing.
7506 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7507 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7508 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7509 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7510 to avoid shadowing.
7511
7512 * textprop.c (property_change_between_p): Remove; unused.
7513
7514 * intervals.c (interval_start_pos): Now static.
7515
7516 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7517
7518 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7519 Rename locals to avoid shadowing.
7520
7521 * sound.c (wav_play, au_play, Fplay_sound_internal):
7522 Fix pointer signedness.
7523 (alsa_choose_format): Remove unused local var.
7524 (wav_play): Initialize a variable to 0, to prevent undefined
7525 behavior (Bug#8278).
7526
7527 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7528
7529 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7530
7531 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7532 clobbering (Bug#8298).
7533 * sysdep.c (sys_subshell): Likewise.
7534 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7535
7536 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7537 This should get cleaned up, so that child_setup has the
7538 same signature on all platforms.
7539
7540 * callproc.c (call_process_cleanup): Now static.
7541 (relocate_fd): Rename locals to avoid shadowing.
7542
7543 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
7544
7545 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7546 not to be necessary, and produces flickering.
7547
7548 2011-03-20 Glenn Morris <rgm@gnu.org>
7549
7550 * config.in: Remove file.
7551
7552 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
7553
7554 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7555 are now in src/globals.h.
7556 (syms_of_minibuf): Remove spurious & from previous change.
7557
7558 2011-03-20 Leo <sdl.web@gmail.com>
7559
7560 * minibuf.c (completing-read-function): New variable.
7561 (completing-read-default): Rename from completing-read.
7562 (completing-read): Call completing-read-function.
7563
7564 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7565
7566 * xfaces.c (Fx_load_color_file):
7567 Read color file from absolute filename (bug#8250).
7568
7569 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7570
7571 * makefile.w32-in: Update dependencies.
7572
7573 2011-03-17 Eli Zaretskii <eliz@gnu.org>
7574
7575 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7576
7577 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7578
7579 Fix more problems found by GCC 4.5.2's static checks.
7580
7581 * process.c (make_serial_process_unwind, send_process_trap):
7582 (sigchld_handler): Now static.
7583
7584 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7585 That way, the code declares only the vars that it needs.
7586 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7587 * s/cygwin.h (PTY_ITERATION): Likewise.
7588 * s/darwin.h (PTY_ITERATION): Likewise.
7589 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7590
7591 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7592 * process.c (allocate_pty): Don't declare stb unless it's needed.
7593
7594 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
7595 (CONSTANTLIM): Remove; unused.
7596 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7597 Define only if needed.
7598
7599 * unexelf.c (unexec): Name an expression,
7600 to avoid gcc -Wbad-function-cast warning.
7601 Use a different way to cause a compilation error if anyone uses
7602 n rather than nn, a way that does not involve shadowing.
7603 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
7604
7605 * deps.mk (unexalpha.o): Remove; unused.
7606
7607 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7608 * unexec.h: New file.
7609 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7610 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7611 Depend on unexec.h.
7612 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7613 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7614 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
7615 Change as necessary to match prototype in unexec.h.
7616
7617 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7618 shadowing.
7619 (back_comment, skip_chars): Mark vars as initialized.
7620
7621 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7622 Rename locals to avoid shadowing.
7623
7624 * lread.c (read1): Rewrite so as not to use empty "else".
7625 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
7626
7627 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7628
7629 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7630 warning when compiling print.c.
7631
7632 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7633 instead of using an uninitialized var.
7634 (font_sort_entities): Mark var as initialized.
7635
7636 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7637
7638 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7639 pointers to constants.
7640 (font_parse_fcname): Remove unused vars.
7641 (font_delete_unmatched): Now static.
7642 (font_get_spec): Remove; unused.
7643 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7644 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7645 Rename or move locals to avoid shadowing.
7646
7647 * fns.c (require_nesting_list, require_unwind): Now static.
7648 (Ffillarray): Rename locals to avoid shadowing.
7649
7650 * floatfns.c (domain_error2): Define only if needed.
7651 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
7652
7653 * alloc.c (mark_backtrace): Move decl from here ...
7654 * lisp.h: ... to here, so that it can be checked.
7655
7656 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
7657 (Fdefvar): Rewrite so as not to use empty "else".
7658 (lisp_indirect_variable): Name an expression,
7659 to avoid gcc -Wbad-function-cast warning.
7660 (Fdefvar): Rename locals to avoid shadowing.
7661
7662 * callint.c (quotify_arg, quotify_args): Now static.
7663 (Fcall_interactively): Rename locals to avoid shadowing.
7664 Use const pointer when appropriate.
7665
7666 * lisp.h (get_system_name, get_operating_system_release):
7667 Move decls here, to check interfaces.
7668 * process.c (get_operating_system_release): Move decl to lisp.h.
7669 * xrdb.c (get_system_name): Likewise.
7670 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7671 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7672 some of which prompt warnings from gcc -Wbad-function-cast.
7673 (Fformat_time_string, Fencode_time, Finsert_char):
7674 (Ftranslate_region_internal, Fformat):
7675 Rename or remove local vars to avoid shadowing.
7676 (Ftranslate_region_internal): Mark var as initialized.
7677
7678 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7679 avoid shadowing.
7680
7681 * lisp.h (eassert): Check that the argument compiles, even if
7682 ENABLE_CHECKING is not defined.
7683
7684 * data.c (Findirect_variable): Name an expression, to avoid
7685 gcc -Wbad-function-cast warning.
7686 (default_value, arithcompare, arith_driver, arith_error): Now static.
7687 (store_symval_forwarding): Rename local to avoid shadowing.
7688 (Fmake_variable_buffer_local, Fmake_local_variable):
7689 Mark variables as initialized.
7690 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
7691
7692 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
7693 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7694 Rename locals to avoid shadowing.
7695 (mark_stack): Move local variables into the #ifdef region where
7696 they're used.
7697 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7698 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7699 needed otherwise.
7700 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7701 (GC_STRING_CHARS): Remove; not used.
7702 (Fmemory_limit): Cast sbrk's returned value to char *.
7703
7704 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7705 avoids undefined behavior in theory.
7706
7707 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7708
7709 Use functions, not macros, for up- and down-casing (Bug#8254).
7710 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7711 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7712 to use the following functions instead of these macros.
7713 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7714 EMACS_INT, since callers assume the returned value fits in int.
7715 (upcase1): Likewise, for UPCASE_TABLE.
7716 (uppercasep, lowercasep, upcase): New static inline functions.
7717 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
7718 the race-condition problem in the old DOWNCASE.
7719
7720 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7721 Rename locals to avoid shadowing.
7722 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
7723 (regex_compile, re_search_2, re_match_2_internal):
7724 Remove unused local vars.
7725 (FREE_VAR): Rewrite so as not to use empty "else",
7726 which gcc can warn about.
7727 (regex_compile, re_match_2_internal): Mark locals as initialized.
7728 (RETALLOC_IF): Define only if needed.
7729 (WORDCHAR_P): Likewise. This one is never needed, but is used
7730 only in a comment talking about a compiler bug, so put inside
7731 the #if 0 of that comment.
7732 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7733 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7734 Remove; unused.
7735
7736 * search.c (boyer_moore): Rename locals to avoid shadowing.
7737 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7738 (PREV_CHAR_BOUNDARY): Likewise.
7739
7740 * search.c (simple_search): Remove unused var.
7741
7742 * dired.c (compile_pattern): Move decl from here ...
7743 * lisp.h: ... to here, so that it can be checked.
7744 (struct re_registers): New forward decl.
7745
7746 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7747
7748 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7749 All uses changed.
7750 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7751 Rename locals to avoid shadowing.
7752 (Fvertical_motion): Mark locals as initialized.
7753
7754 * casefiddle.c (casify_object, casify_region): Now static.
7755 (casify_region): Mark local as initialized.
7756
7757 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7758
7759 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7760 New macros, so that the caller can use some names other than
7761 gcpro1, gcpro2, etc.
7762 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7763 of the new macros.
7764 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7765 argument, for consistency with GCPRO2_VAR, etc: it is now the
7766 prefix of the variable, not the variable itself. All uses
7767 changed.
7768 * dired.c (directory_files_internal, file_name_completion):
7769 Rename locals to avoid shadowing.
7770
7771 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7772 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7773 dired.c's scmp function, had undefined behavior.
7774 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7775 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7776 * buffer.h: ... to here, because these macros use current_buffer,
7777 and the new implementation with inline functions needs to have
7778 current_buffer in scope now, rather than later when the macros
7779 are used.
7780 (downcase, upcase1): New static inline functions.
7781 (DOWNCASE, UPCASE1): Reimplement using these functions.
7782 This avoids undefined behavior in expressions like
7783 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7784 from race conditions in accessing the global variables
7785 case_temp1 and case_temp2.
7786 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7787 * lisp.h (case_temp1, case_temp2): Remove their decls.
7788 * character.h (ASCII_CHAR_P): Move from here ...
7789 * lisp.h: ... to here, so that the inline functions mentioned
7790 above can use them.
7791
7792 * dired.c (directory_files_internal_unwind): Now static.
7793
7794 * fileio.c (file_name_as_directory, directory_file_name):
7795 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7796 Now static.
7797 (file_name_as_directory): Use const pointers when appropriate.
7798 (Fexpand_file_name): Likewise. In particular, newdir might
7799 point at constant storage, so make it a const pointer.
7800 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
7801 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7802 signedness issues.
7803 (Fset_file_times, Finsert_file_contents, auto_save_error):
7804 Rename locals to avoid shadowing.
7805
7806 * minibuf.c (choose_minibuf_frame_1): Now static.
7807 (Ftry_completion, Fall_completions): Rename or remove locals
7808 to avoid shadowing.
7809
7810 * marker.c (bytepos_to_charpos): Remove; unused.
7811
7812 * lisp.h (verify_bytepos, count_markers): New decls,
7813 so that gcc does not warn that these functions aren't declared.
7814
7815 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7816 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
7817 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
7818 (copy_text): Remove unused local var.
7819
7820 * filelock.c (within_one_second): Now static.
7821 (lock_file_1): Rename local to avoid shadowing.
7822
7823 * buffer.c (fix_overlays_before): Mark locals as initialized.
7824 (fix_start_end_in_overlays): Likewise. This function should be
7825 simplified by using pointers-to-pointers, but that's a different
7826 matter.
7827 (switch_to_buffer_1): Now static.
7828 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7829 (report_overlay_modification): Rename locals to avoid shadowing.
7830
7831 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
7832 Fix pointer signedness issue.
7833 (sys_subshell): Mark local as volatile if checking for lint,
7834 to suppress a gcc -Wclobbered warning that does not seem to be right.
7835 (MAXPATHLEN): Define only if needed.
7836
7837 * process.c (serial_open, serial_configure): Move decls from here ...
7838 * systty.h: ... to here, so that they can be checked.
7839
7840 * fns.c (get_random, seed_random): Move extern decls from here ...
7841 * lisp.h: ... to here, so that they can be checked.
7842
7843 * sysdep.c (reset_io): Now static.
7844 (wait_for_termination_signal): Remove; unused.
7845
7846 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7847 (copy_keymap_item, append_key, push_text_char_description):
7848 Now static.
7849 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
7850 (DENSE_TABLE_SIZE): Remove; unused.
7851 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7852 (describe_map_tree):
7853 Rename locals to avoid shadowing.
7854
7855 * keyboard.c: Declare functions static if they are not used elsewhere.
7856 (echo_char, echo_dash, cmd_error, top_level_2):
7857 (poll_for_input, handle_async_input): Now static.
7858 (read_char, kbd_buffer_get_event, make_lispy_position):
7859 (make_lispy_event, make_lispy_movement, apply_modifiers):
7860 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7861 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7862 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
7863 (read_key_sequence, read_char): Mark locals as initialized.
7864 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
7865
7866 * keyboard.h (make_ctrl_char): New decl.
7867 (mark_kboards): Move decl here ...
7868 * alloc.c (mark_kboards): ... from here.
7869
7870 * lisp.h (force_auto_save_soon): New decl.
7871
7872 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
7873 (DEFINE_DUMMY_FUNCTION): New macro.
7874 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7875 Use it.
7876 (main): Add casts to avoid warnings
7877 if GCC considers string literals to be constants.
7878
7879 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7880
7881 * dbusbind.c: Pointer signedness fixes.
7882 (xd_signature, xd_append_arg, xd_initialize):
7883 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7884 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7885 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7886 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7887
7888 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7889 if GCC considers string literals to be constants.
7890 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
7891
7892 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7893
7894 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7895 (print_preprocess, print_object): New macro to fix last change.
7896
7897 * print.c (print_preprocess): Don't forget font objects.
7898
7899 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
7900
7901 * emacs.c (USAGE3): Doc fixes.
7902
7903 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7904
7905 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7906 structure.
7907
7908 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
7909
7910 * lisp.h (VWindow_system, Qfile_name_history):
7911 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7912 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7913 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7914
7915 * w32select.c: Don't #include "keyboard.h".
7916 (run_protected): Add extern declaration for waiting_for_input.
7917
7918 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7919 * w32console.c (detect_input_pending, read_input_pending)
7920 (encode_terminal_code):
7921 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7922 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7923 (w32_system_caret_y, Qfile_name_history):
7924 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7925 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7926 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7927 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7928 * w32proc.c (Qlocal, report_file_error):
7929 * w32term.c (Vwindow_system, updating_frame):
7930 * w32uniscribe.c (initialized, uniscribe_font_driver):
7931 Remove unneeded extern declarations.
7932
7933 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
7934
7935 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
7936
7937 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
7938
7939 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7940 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7941 These macros can no longer be used for assignment.
7942
7943 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7944 Assign struct members directly, instead of using BUF_BEGV etc.
7945 (record_buffer_markers, fetch_buffer_markers): New functions for
7946 recording and fetching special buffer markers.
7947 (set_buffer_internal_1, set_buffer_temp): Use them.
7948
7949 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7950
7951 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7952
7953 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7954 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7955
7956 * xdisp.c (hscroll_window_tree):
7957 (reconsider_clip_changes): Use PT instead of BUF_PT.
7958
7959 2011-03-13 Eli Zaretskii <eliz@gnu.org>
7960
7961 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7962 $(EMACS_ROOT)/lib/intprops.h.
7963
7964 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7965
7966 Fix more problems found by GCC 4.5.2's static checks.
7967
7968 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7969 to unsigned char * to avoid compiler diagnostic.
7970 (xg_free_frame_widgets): Make it clear that a local variable is
7971 needed only if USE_GTK_TOOLTIP.
7972 (gdk_window_get_screen): Make it clear that this macro is needed
7973 only if USE_GTK_TOOLTIP.
7974 (int_gtk_range_get_value): New function, which avoids a diagnostic
7975 from gcc -Wbad-function-cast.
7976 (xg_set_toolkit_scroll_bar_thumb): Use it.
7977 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7978 diagnostic from gcc -Wbad-function-cast.
7979 (get_utf8_string, xg_get_file_with_chooser):
7980 Rename locals to avoid shadowing.
7981 (create_dialog): Move locals to avoid shadowing.
7982
7983 * xgselect.c (xg_select): Remove unused var.
7984
7985 * image.c (four_corners_best): Mark locals as initialized.
7986 (gif_load): Initialize transparent_p to zero (Bug#8238).
7987 Mark another local as initialized.
7988 (my_png_error, my_error_exit): Mark with NO_RETURN.
7989
7990 * image.c (clear_image_cache): Now static.
7991 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
7992 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
7993 (x_edge_detection): Remove unnecessary cast that
7994 gcc -Wbad-function-cast diagnoses.
7995 (gif_load): Fix pointer signedness.
7996 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7997 (jpeg_load, gif_load): Rename locals to avoid shadowing.
7998
7999 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
8000
8001 Improve quality of tests for time stamp overflow.
8002 For example, without this patch (encode-time 0 0 0 1 1
8003 1152921504606846976) returns the obviously-bogus value (-948597
8004 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8005 reports time overflow. See
8006 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
8007 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8008 * editfns.c: Include limits.h and intprops.h.
8009 (TIME_T_MIN, TIME_T_MAX): New macros.
8010 (time_overflow): Move earlier, to before first use.
8011 (hi_time, lo_time): New functions, for an accurate test for
8012 out-of-range times.
8013 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8014 (Fget_internal_run_time): Don't assume time_t fits in int.
8015 (make_time): Use list2 instead of Fcons twice.
8016 (Fdecode_time): More accurate test for out-of-range times.
8017 (check_tm_member): New function.
8018 (Fencode_time): Use it, to test for out-of-range times.
8019 (lisp_time_argument): Don't rely on undefined left-shift and
8020 right-shift behavior when checking for time stamp overflow.
8021
8022 * editfns.c (time_overflow): New function, refactoring common code.
8023 (Fformat_time_string, Fdecode_time, Fencode_time):
8024 (Fcurrent_time_string): Use it.
8025
8026 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8027 * dired.c (make_time): Move to ...
8028 * editfns.c (make_time): ... here.
8029 * systime.h: Note the move.
8030
8031 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8032
8033 * fringe.c (update_window_fringes): Remove unused variables.
8034
8035 * unexmacosx.c (copy_data_segment): Also copy __got section.
8036 (Bug#8223)
8037
8038 2011-03-12 Eli Zaretskii <eliz@gnu.org>
8039
8040 * termcap.c [MSDOS]: Include "msdos.h".
8041 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8042 Constify `char *' arguments and their references according to
8043 prototypes in tparam.h.
8044
8045 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
8046
8047 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8048 Adapt all references accordingly.
8049
8050 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8051
8052 2011-03-11 Tom Tromey <tromey@redhat.com>
8053
8054 * buffer.c (syms_of_buffer): Remove obsolete comment.
8055
8056 2011-03-11 Eli Zaretskii <eliz@gnu.org>
8057
8058 * termhooks.h (encode_terminal_code): Declare prototype.
8059
8060 * msdos.c (encode_terminal_code): Don't declare prototype.
8061
8062 * term.c (encode_terminal_code): Now external again, used by
8063 w32console.c and msdos.c.
8064
8065 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8066 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
8067
8068 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
8069
8070 Fix some minor problems found by GCC 4.5.2's static checks.
8071
8072 * fringe.c (update_window_fringes): Mark locals as initialized
8073 (Bug#8227).
8074 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
8075
8076 * alloc.c (mark_fringe_data): Move decl from here ...
8077 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8078 to check its interface.
8079 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8080
8081 * fontset.c (free_realized_fontset): Now static.
8082 (Fset_fontset_font): Rename local to avoid shadowing.
8083 (fontset_font): Mark local as initialized.
8084 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
8085
8086 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8087
8088 * xselect.c (x_disown_buffer_selections): Remove; not used.
8089 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
8090 (x_own_selection, Fx_disown_selection_internal): Rename locals
8091 to avoid shadowing.
8092 (x_handle_dnd_message): Remove local to avoid shadowing.
8093
8094 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8095 so that the caller can use some name other than gcpro1.
8096 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
8097 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8098 (Fx_backspace_delete_keys_p):
8099 Use them to avoid shadowing, and rename vars to avoid shadowing.
8100 (x_decode_color, x_set_name, x_window): Now static.
8101 (Fx_create_frame): Add braces to silence GCC warning.
8102 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
8103 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8104 Remove unused locals.
8105 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8106 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8107 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8108 macros.
8109
8110 * xterm.h (x_mouse_leave): New decl.
8111
8112 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8113 Remove unused functions.
8114 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8115 (x_calc_absolute_position): Now static.
8116 (XTread_socket): Don't define label "out" unless it's used.
8117 Don't declare local "event" unless it's used.
8118 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8119 unless they are used.
8120 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8121 (x_fatal_error_signal): Remove; not used.
8122 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8123 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8124 (x_error_catcher, x_connection_closed, x_error_handler):
8125 (x_error_quitter, xembed_send_message, x_iconify_frame):
8126 (my_log_handler): Rename locals to avoid shadowing.
8127 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
8128 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
8129
8130 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8131 Rename or move locals to avoid shadowing.
8132 (tty_defined_color, merge_face_heights): Now static.
8133 (free_realized_faces_for_fontset): Remove; not used.
8134 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8135 does not deduce is never used uninitialized.
8136 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8137 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
8138
8139 * terminal.c (store_terminal_param): Now static.
8140
8141 * xmenu.c (menu_highlight_callback): Now static.
8142 (set_frame_menubar): Remove unused local.
8143 (xmenu_show): Rename parameter to avoid shadowing.
8144 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8145 since they might point to immutable storage.
8146 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8147 since it's unused otherwise.
8148
8149 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
8150 Add a FIXME, since the code still doesn't look right. (Bug#8215)
8151 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8152 avoids a gcc -Wuninitialized diagnostic.
8153 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
8154 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8155 does not deduce are never used uninitialized.
8156
8157 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8158
8159 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
8160 * window.c (window_loop, size_window):
8161 (run_window_configuration_change_hook, enlarge_window): Likewise.
8162
8163 * window.c (display_buffer): Now static.
8164 (size_window): Mark variables that gcc -Wuninitialized
8165 does not deduce are never used uninitialized.
8166 * window.h (check_all_windows): New decl, to forestall
8167 gcc -Wmissing-prototypes diagnostic.
8168 * dispextern.h (bidi_dump_cached_states): Likewise.
8169
8170 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8171 shadowing.
8172 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
8173 Include <limits.h>.
8174 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8175 and to avoid gcc -Wuninitialized warning.
8176 (load_charset_map): Mark variables that gcc -Wuninitialized
8177 does not deduce are never used uninitialized.
8178 (load_charset): Abort instead of using uninitialized var (Bug#8229).
8179
8180 * coding.c (coding_set_source, coding_set_destination):
8181 Use "else { /* comment */ }" rather than "else /* comment */;"
8182 for clarity, and to avoid gcc -Wempty-body warning.
8183 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8184 a block, when the outer 'i' will do.
8185 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8186 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8187 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8188 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8189 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8190 Rename locals to avoid shadowing.
8191 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
8192 * coding.c (emacs_mule_char, encode_invocation_designation):
8193 Now static, since they're not used elsewhere.
8194 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
8195 (decode_coding_object, encode_coding_object, detect_coding_system):
8196 (decode_coding_emacs_mule): Mark variables that gcc
8197 -Wuninitialized does not deduce are never used uninitialized.
8198 (detect_coding_iso_2022): Initialize a local variable that might
8199 be used uninitialized. Leave a FIXME because it's not clear that
8200 this initialization is needed. (Bug#8211)
8201 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8202 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8203 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8204 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8205 Remove unused macros.
8206
8207 * category.c (hash_get_category_set): Remove unused local var.
8208 (copy_category_table): Now static, since it's not used elsewhere.
8209 * character.c (string_count_byte8): Likewise.
8210
8211 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8212 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8213
8214 * chartab.c (copy_sub_char_table): Now static, since it's not used
8215 elsewhere.
8216 (sub_char_table_ref_and_range, char_table_ref_and_range):
8217 Rename locals to avoid shadowing.
8218 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
8219
8220 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
8221 (BIDI_BOB): Remove unused macro.
8222
8223 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8224 deduce are never used uninitialized.
8225 * term.c (encode_terminal_code): Likewise.
8226
8227 * term.c (encode_terminal_code): Now static. Remove unused local.
8228
8229 * tparam.h: New file.
8230 * term.c, tparam.h: Include it.
8231 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8232 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8233 Move these decls to tparam.h, and make them agree with what
8234 is actually in tparam.c. The previous trick of using incompatible
8235 decls in different modules does not conform to the C standard.
8236 All callers of tparam changed to use tparam's actual API.
8237 * tparam.c (tparam1, tparam, tgoto):
8238 Use const pointers where appropriate.
8239
8240 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8241 * cm.h (struct cm): Likewise.
8242 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8243 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8244 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8245 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8246 (turn_on_face, init_tty): Likewise.
8247 * termchar.h (struct tty_display_info): Likewise.
8248
8249 * term.c (term_mouse_position): Rename local to avoid shadowing.
8250
8251 * alloc.c (mark_ttys): Move decl from here ...
8252 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8253
8254 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8255
8256 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8257
8258 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
8259
8260 * search.c (compile_pattern_1): Remove argument regp, unused since
8261 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8262 (compile_pattern): Don't pass it.
8263
8264 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8265
8266 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8267 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8268 for ! HAVE_GTK3.
8269 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8270
8271 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8272
8273 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8274 gdk_window_get_screen, gdk_window_get_geometry,
8275 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8276 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8277 (xg_get_pixbuf_from_pixmap): New function.
8278 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8279 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8280 Call xg_get_pixbuf_from_pixmap instead of
8281 gdk_pixbuf_get_from_drawable.
8282 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8283 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8284 (xg_check_special_colors): Use GtkStyleContext and its functions
8285 for HAVE_GTK3.
8286 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8287 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8288 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
8289 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8290 Call gtk_widget_get_preferred_size.
8291 (xg_frame_resized): gdk_window_get_geometry only takes 5
8292 parameters.
8293 (xg_win_to_widget, xg_event_is_for_menubar):
8294 Call gdk_x11_window_lookup_for_display.
8295 (xg_set_widget_bg): New function.
8296 (delete_cb): New function.
8297 (xg_create_frame_widgets): Connect delete-event to delete_cb.
8298 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
8299 (xg_set_background_color): Call xg_set_widget_bg.
8300 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8301 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8302 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8303 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8304 if ! HAVE_GTK3.
8305 (update_frame_tool_bar): Call gtk_widget_hide.
8306 (xg_initialize): Use GDK_KEY_g.
8307
8308 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8309 if ! HAVE_GTK3
8310 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8311
8312 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8313 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8314 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8315
8316 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
8317
8318 * w32xfns.c (select_palette): Check success of RealizePalette against
8319 GDI_ERROR, not zero.
8320
8321 See ChangeLog.11 for earlier changes.
8322
8323 ;; Local Variables:
8324 ;; coding: utf-8
8325 ;; End:
8326
8327 Copyright (C) 2011 Free Software Foundation, Inc.
8328
8329 This file is part of GNU Emacs.
8330
8331 GNU Emacs is free software: you can redistribute it and/or modify
8332 it under the terms of the GNU General Public License as published by
8333 the Free Software Foundation, either version 3 of the License, or
8334 (at your option) any later version.
8335
8336 GNU Emacs is distributed in the hope that it will be useful,
8337 but WITHOUT ANY WARRANTY; without even the implied warranty of
8338 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8339 GNU General Public License for more details.
8340
8341 You should have received a copy of the GNU General Public License
8342 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.