1 2012-07-12 Glenn Morris <rgm@gnu.org>
3 * s/gnu-linux.h, s/hpux10-20.h:
4 Do not unconditionally define HAVE_XRMSETDATABASE.
6 2012-07-12 Eli Zaretskii <eliz@gnu.org>
8 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
9 memmove call that removes glyphs covered by the left truncation
10 glyph. Improve commentary.
11 (display_line): Fix display of continuation glyphs on GUI frames
12 when the right fringe is turned off and variable-size fonts are
13 used in the window. Move the code that appends a stretch glyph to
14 produce_special_glyphs, so that it could be used for truncation
15 and continuation glyphs alike.
16 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
17 glyph of a suitably computed width, to align the special glyphs at
18 the window margin. Code moved from display_line. (Bug#11832)
20 2012-07-12 Glenn Morris <rgm@gnu.org>
22 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
24 2012-07-12 Paul Eggert <eggert@cs.ucla.edu>
26 Fix typos that broke OS X build.
27 Reported by Randal L. Schwartz in
28 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
29 * nsterm.m (ns_timeout): Add missing local decl.
30 (ns_get_color): snprintf -> sprintf, to fix typo.
32 2012-07-12 Glenn Morris <rgm@gnu.org>
34 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
35 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
36 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
37 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
39 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
40 Move PTY_OPEN to configure.
42 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
43 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
44 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
46 2012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
48 Use empty_unibyte_string where applicable.
49 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
50 * lread.c (read1): Likewise.
51 * xsettings.c (syms_of_xsettings): Likewise.
53 2012-07-12 Glenn Morris <rgm@gnu.org>
55 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
56 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
57 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
58 * s/hpux10-20.h (RUN_TIME_REMAP):
59 * s/bsd-common.h (TABDLY): Move to configure.
61 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
63 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
65 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
66 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
68 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
70 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
71 * s/template.h: Move NARROWPROTO to configure.
73 2012-07-11 Glenn Morris <rgm@gnu.org>
75 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
76 unused since 2011-01-17 change to systty.h.
78 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
79 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
80 Move HAVE_PTYS and HAVE_SOCKETS to configure.
82 2012-07-11 Paul Eggert <eggert@cs.ucla.edu>
84 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
86 2012-07-11 Glenn Morris <rgm@gnu.org>
88 * s/darwin.h, s/gnu-linux.h, s/template.h:
89 Move INTERRUPT_INPUT to configure.
91 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
93 Minor adjustments to interning code.
94 * lisp.h (intern, intern_c_string): Redefine as static inline
95 wrappers for intern_1 and intern_c_string_1, respectively.
96 (intern_1, intern_c_string_1): Rename prototypes.
97 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
99 * font.c (font_intern_prop): Likewise. Adjust comment.
100 * w32font.c (intern_font_name): Likewise.
102 2012-07-11 Andreas Schwab <schwab@linux-m68k.org>
104 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
106 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
107 of Fcar/Fcdr if possible.
108 * font.c (check_otf_features): Likewise.
109 * fontset.c (Fnew_fontset): Likewise.
110 * gnutls.c (Fgnutls_boot): Likewise.
111 * minibuf.c (read_minibuf): Likewise.
112 * msdos.c (IT_set_frame_parameters): Likewise.
113 * xmenu.c (Fx_popup_dialog): Likewise.
114 * w32menu.c (Fx_popup_dialog): Likewise.
116 2012-07-11 Glenn Morris <rgm@gnu.org>
118 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
119 since nothing has defined it on these platforms.
121 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
122 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
124 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
125 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
126 Move CLASH_DETECTION to configure.
128 * s/gnu.h: Remove file, which is now empty.
130 * s/gnu.h, s/gnu-linux.h:
131 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
133 2012-07-11 John Wiegley <johnw@newartisans.com>
135 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
136 function attribute, so we only use it if it exists in the
139 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
141 Avoid call to strlen in fast_c_string_match_ignore_case.
142 * search.c (fast_c_string_match_ignore_case): Change to use
143 length argument. Adjust users accordingly.
144 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
146 2012-07-11 Paul Eggert <eggert@cs.ucla.edu>
149 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
150 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
153 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
156 * s/hpux10-20.h (HAVE_PERROR): Remove.
157 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
158 Remove dummy definition, as this problem was obsolete long ago.
161 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
163 2012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
165 Avoid calls to strlen in font processing functions.
166 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
167 (font_open_by_name): Change to use length argument. Adjust
169 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
171 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
172 Change to return ptrdiff_t.
173 (xfont_list_pattern, xfont_match): Use length returned by
174 xfont_decode_coding_xlfd.
175 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
177 2012-07-11 Glenn Morris <rgm@gnu.org>
179 * s/darwin.h, s/freebsd.h, s/netbsd.h:
180 Move DONT_REOPEN_PTY to configure.
182 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
183 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
185 2012-07-10 Paul Eggert <eggert@cs.ucla.edu>
187 Remove "#define unix" that is no longer needed (Bug#11905).
188 * s/aix4-2.h (unix): Remove; no longer needed.
190 EMACS_TIME simplification (Bug#11875).
191 This replaces macros (which typically do not work in GDB)
192 with functions, typedefs and enums, making the code easier to debug.
193 The functional style also makes code easier to read and maintain.
194 * systime.h: Include <sys/time.h> on all hosts, not just if
195 WINDOWSNT, since 'struct timeval' is needed in general.
196 (EMACS_TIME): Now a typedef, not a macro.
197 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
199 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
200 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
201 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
202 (EMACS_TIME_LE): Now functions, not macros.
203 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
204 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
205 which are not functions. All uses rewritten to use:
206 (make_emacs_time): New function.
207 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
208 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
209 not functions. All uses rewritten to use the following, respectively:
210 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
211 (add_emacs_time, sub_emacs_time): New functions.
212 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
213 * fileio.c (Fcopy_file):
214 * xterm.c (XTflash): Get the current time closer to when it's used.
215 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
217 * bytecode.c (targets): Suppress -Woverride-init warnings.
219 Simplify by avoiding confusing use of strncpy etc.
220 * doc.c (Fsnarf_documentation):
221 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
222 * frame.c (Fmake_terminal_frame):
223 * gtkutil.c (get_utf8_string):
225 * nsmenu.m (ns_update_menubar):
226 * regex.c (regerror):
227 Prefer memcpy to strncpy and strncat when either will do.
228 * fileio.c (Fsubstitute_in_file_name):
229 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
230 (menu_separator_name_p):
231 * nsmenu.m (ns_update_menubar):
232 Prefer memcmp to strncmp when either will do.
233 * nsterm.m: Include <ftoastr.h>.
235 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
236 Prefer snprintf to strncpy.
237 * nsterm.m (ns_term_init):
238 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
239 * nsterm.m (ns_term_init):
240 Avoid the need for strncpy, by using build_string or
241 make_unibyte_string directly. Use dtoastr, not snprintf.
242 * process.c (Fmake_network_process): Diagnose service names that
243 are too long, rather than silently truncating them or creating
244 non-null-terminated names.
245 (Fnetwork_interface_info): Likewise, for interface names.
246 * sysdep.c (system_process_attributes) [GNU_LINUX]:
247 Prefer sprintf to strncat.
248 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
249 Prefer vsnprintf to vsprintf + strncpy.
251 2012-07-10 Glenn Morris <rgm@gnu.org>
253 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
254 Clarify fallback case.
256 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
258 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
259 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
260 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
261 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
262 where argument type is known to be a Lisp_Cons.
264 2012-07-10 Tom Tromey <tromey@redhat.com>
266 * bytecode.c (BYTE_CODE_THREADED): New macro.
267 (BYTE_CODES): New macro. Replaces all old byte-code defines.
268 (enum byte_code_op): New type.
269 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
270 (exec_byte_code): Use them. Use token threading when applicable.
272 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
274 Optimize pure C strings initialization.
275 * lisp.h (make_pure_string): Fix prototype.
276 (build_pure_c_string): New function, defined as static inline. This
277 provides a better opportunity to optimize away calls to strlen when
278 the function is called with compile-time constant argument.
279 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
280 argument, adjust users accordingly. Use build_pure_c_string where
282 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
283 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
284 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
286 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
288 Avoid calls to strlen in miscellaneous functions.
289 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
290 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
291 * lread.c (openp): Likewise.
293 2012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
295 Avoid calls to strlen in path processing functions.
296 * fileio.c (file_name_as_directory): Add comment. Change to add
297 srclen argument and return the length of result. Adjust users
299 (directory_file_name): Fix comment. Change to add srclen argument,
300 swap 1st and 2nd arguments to obey the common convention. Adjust
302 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
304 2012-07-10 Glenn Morris <rgm@gnu.org>
306 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
307 Move PENDING_OUTPUT_COUNT definition to configure.
309 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
310 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
311 * s/gnu.h (DATA_START): Move definitions to configure.
313 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
314 We include usg5-4-common.h, which defines them both.
316 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
317 O_RDONLY already includes it).
319 Stop ns builds setting the EMACSLOADPATH environment variable.
320 * nsterm.m (ns_load_path): Rename from ns_init_paths.
321 Now it does not set EMACSLOADPATH, just returns the load-path string.
322 * nsterm.h: Update accordingly.
323 * lread.c [HAVE_NS]: Include nsterm.h.
324 (init_lread) [HAVE_NS]: Use ns_load_path.
325 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
327 2012-07-09 Glenn Morris <rgm@gnu.org>
329 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
330 since the included bsd-common.h does so.
332 Stop ns builds setting the EMACSPATH environment variable.
333 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
334 (ns_init_paths): Do not set EMACSPATH.
335 * nsterm.h (ns_exec_path): Add it.
336 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
339 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
341 2012-07-09 Paul Eggert <eggert@cs.ucla.edu>
343 * process.c (wait_reading_process_output): 'waitchannels' was unset
344 when read_kbd || !NILP (wait_for_cell); fix this.
346 Add GCC-style 'const' attribute to functions that can use it.
347 * character.h (char_resolve_modifier_mask):
348 * keyboard.h (make_ctrl_char):
349 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
350 (init_character_once, next_almost_prime, init_fns, init_image)
351 (flush_pending_output, init_sound):
352 * mem-limits.h (start_of_data):
353 * menu.h (finish_menu_items):
355 * emacs.c (DEFINE_DUMMY_FUNCTION):
356 Declare the dummy function with ATTRIBUTE_CONST.
357 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
358 Add decls with ATTRIBUTE_CONST.
360 Minor improvements to make_formatted_string.
361 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
362 where int is good enough, as vsprintf returns an int.
363 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
365 2012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
367 Use make_formatted_string to avoid double length calculation.
368 * lisp.h (make_formatted_string): New prototype.
369 * alloc.c (make_formatted_string): New function.
370 * buffer.c (Fgenerate_new_buffer_name): Use it.
371 * dbus.c (syms_of_dbusbind): Likewise.
372 * editfns.c (Fcurrent_time_zone): Likewise.
373 * filelock.c (get_boot_time): Likewise.
374 * frame.c (make_terminal_frame, set_term_frame_name)
375 (x_report_frame_params): Likewise.
376 * image.c (gs_load): Likewise.
377 * minibuf.c (get_minibuffer): Likewise.
378 * msdos.c (dos_set_window_size): Likewise.
379 * process.c (make_process): Likewise.
380 * xdisp.c (ensure_echo_area_buffers): Likewise.
381 * xsettings.c (apply_xft_settings): Likewise.
383 2012-07-09 Glenn Morris <rgm@gnu.org>
385 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
386 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
387 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
388 * nsterm.h (ns_etc_directory): Add it.
389 * callproc.c [HAVE_NS]: Include nsterm.h.
390 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
392 2012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
394 Move marker debugging code under MARKER_DEBUG.
395 * marker.c (MARKER_DEBUG): Move marker debugging code under
396 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
397 for bootstrap with --enable-checking (~3x slowdown reported
398 by Juanma Barranquero <lekktu@gmail.com>).
399 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
401 2012-07-08 Paul Eggert <eggert@cs.ucla.edu>
403 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
404 See <http://bugs.gnu.org/11825#29>.
406 2012-07-08 Eli Zaretskii <eliz@gnu.org>
408 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
409 has no font, use the frame's font. (Bug#11813)
410 (display_line): Add commentary about displaying truncation glyphs
412 (produce_special_glyphs): Move here from term.c.
414 * term.c (produce_special_glyphs): Move to xdisp.c.
416 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
419 2012-07-07 Andreas Schwab <schwab@linux-m68k.org>
421 * xdisp.c (display_line): Avoid warning about implicit declaration
424 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
426 * lisp.h: Remove empty conditional.
428 2012-07-07 Paul Eggert <eggert@cs.ucla.edu>
430 * lread.c (load_path_check): Now static.
432 Fix some minor --with-ns problems found by static checking.
433 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
434 (x_set_font) [!HAVE_X_WINDOWS]:
435 * image.c (xpm_load_image) [HAVE_NS]:
436 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
437 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
439 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
440 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
441 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
442 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
443 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
444 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
445 Fix pointer signedness problem.
446 * xfaces.c (FRAME_X_FONT_TABLE):
447 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
449 2012-07-07 Glenn Morris <rgm@gnu.org>
451 * lread.c (load_path_check): New function, split from init_lread.
452 (init_lread): Reorganize. Motivation:
453 If EMACSLOADPATH is set, check/warn about that rather than the
454 defaults, which we are not going to use. Hence we can remove
455 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
456 Don't warn if site-lisp directories are missing.
457 If not installed, start from a blank load-path, since
458 PATH_LOADSEARCH refers to the eventual installation directories.
460 2012-07-07 Eli Zaretskii <eliz@gnu.org>
462 Support truncation and continuation glyphs on GUI frames, when
463 fringes are disabled. (Bug#11832)
464 * xdisp.c (init_iterator): Get dimensions of truncation and
465 continuation glyphs even if on GUI frames. Adjust
466 it->last_visible_x on GUI frames when the left or right fringes,
468 (start_display, move_it_in_display_line_to): Handle the case of a
469 GUI frame without a fringe to display continuation or truncation
471 (insert_left_trunc_glyphs): Support GUI frames: make sure
472 truncation glyphs overwrite enough glyphs from the current line to
473 have sufficient space in pixels.
474 (display_line): Support truncation and continuation glyphs on GUI
475 frames. If some spare pixels are left on the line after inserting
476 the truncation glyphs, fill that space with a stretch glyph of a
477 suitably computed width.
479 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
480 produce_glyphs, to support GUI sessions.
482 2012-07-07 Paul Eggert <eggert@cs.ucla.edu>
484 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
486 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
488 Do not require float-time's arg to fit in time_t (Bug#11825).
489 This works better on hosts where time_t is unsigned, and where
490 float-time is applied to the (negative) difference between two times.
491 * editfns.c (decode_time_components): Last arg is now double *,
492 not int *, and means to store all the result as a double, without
493 worrying about whether the seconds part fits in time_t.
495 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
497 (Ffloat_time): Do not fail merely because the specified time falls
498 outside of time_t range.
500 2012-07-07 Glenn Morris <rgm@gnu.org>
502 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
503 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
504 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
506 2012-07-07 Juanma Barranquero <lekktu@gmail.com>
508 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
511 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
513 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
515 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
516 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
517 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
518 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
519 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
520 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
522 * xfont.c (compare_font_names): Redo to omit the need for casts.
524 2012-07-06 Andreas Schwab <schwab@linux-m68k.org>
526 * xfns.c (Fx_change_window_property): Doc fix.
527 * w32fns.c (Fx_change_window_property): Doc fix.
529 * w32fns.c (Fx_window_property): Accept the same arguments as the
530 X Windows version. Doc fix.
531 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
533 2012-07-06 Juanma Barranquero <lekktu@gmail.com>
534 Eli Zaretskii <eliz@gnu.org>
536 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
537 Windows-specific code from nt/config.nt moved here.
538 Obsolete settings removed.
540 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
542 * process.c: Avoid unnecessary calls to gettime.
543 (wait_reading_process_output): Don't get the time of day
544 when gobbling data immediately and not waiting, as there's no need
545 for it in that case. This removes a FIXME.
547 2012-07-06 Jan Djärv <jan.h.d@swipnet.se>
549 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
550 is defined (Bug#11768).
552 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
554 Fix marker debugging code.
555 * marker.c (byte_char_debug_check): Do not perform the check
556 if buffer is not multibyte.
557 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
558 Call byte_char_debug_check with correct arguments.
560 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
562 Compile marker debugging code only if ENABLE_CHECKING is defined.
563 * marker.c (byte_char_debug_check, count_markers):
564 Use only if ENABLE_CHECKING is defined.
565 (byte_debug_flag): Remove.
566 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
567 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
569 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
571 Avoid code repetition in marker-related functions.
572 * marker.c (attach_marker): New function.
573 (Fset_marker, set_marker_restricted, set_marker_both)
574 (set_marker_restricted_both): Use it.
575 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
576 Consistently rename charno to charpos.
577 (marker_position): Add eassert.
578 (marker_byte_position): Convert to eassert.
580 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
582 Simplify list operations in unchain_overlay and unchain_marker.
583 * buffer.c (unchain_overlay): Simplify. Add comment.
584 * marker.c (unchain_marker): Simplify. Fix comments.
586 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
588 Introduce fast path for the widely used marker operation.
589 * alloc.c (build_marker): New function.
590 * lisp.h (build_marker): New prototype.
591 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
592 * composite.c (autocmp_chars): Likewise.
593 * editfns.c (buildmark): Remove.
594 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
595 (save_restriction_save): Use build_marker.
596 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
597 * window.c (save_window_save): Likewise.
599 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
601 Do not use Fdelete_overlay in delete_all_overlays
602 to avoid redundant calls to unchain_overlay.
603 * buffer.c (drop_overlay): New function.
604 (delete_all_overlays, Fdelete_overlay): Use it.
605 * minibuf.c (get_minibuffer): Fix comment.
607 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
609 Port to OpenBSD 5.1 amd64.
610 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
611 This is needed for OpenBSD, and should be harmless on all BSD systems.
612 Also, include <sys/sysctl.h>, as it should be available on all
613 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
614 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
615 use p_pid member, not kp_proc.pid.
617 2012-07-06 Glenn Morris <rgm@gnu.org>
619 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
621 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
623 More xmalloc and related cleanup.
624 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
625 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
626 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
627 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
628 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
629 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
630 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
631 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
632 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
634 Omit needless casts involving void * pointers and allocation.
635 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
636 as the former is more robust if P's type is changed.
637 Prefer xzalloc to xmalloc + memset 0.
638 Simplify malloc-or-realloc to realloc.
639 Don't worry about xmalloc returning a null pointer.
640 Prefer xstrdup to xmalloc + strcpy.
641 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
643 * keyboard.c (apply_modifiers_uncached): Prefer local array to
644 alloca of a constant.
646 2012-07-05 Eli Zaretskii <eliz@gnu.org>
648 * xdisp.c (display_line): Fix horizontal pixel coordinates when
649 hscroll is larger than the line width. Fixes long and futile
650 looping inside extend_face_to_end_of_line (on a TTY) producing
651 glyphs that are not needed and thrown away.
653 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
655 * marker.c (set_marker_restricted_both): Simplify by using
658 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
660 * editfns.c (region_limit): Simplify by using clip_to_bounds.
662 2012-07-05 Jan Djärv <jan.h.d@swipnet.se>
664 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
665 not defined (Bug#11768).
666 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
667 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
668 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
669 followed by gtk_box_set_homogeneous (Bug#11768).
670 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
671 (update_theme_scrollbar_width, xg_create_scroll_bar):
672 Use gtk_scrollbar_new (Bug#11768).
673 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
674 (is_box_type): New function (Bug#11768).
675 (xg_tool_item_stale_p): Call is_box_type.
676 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
677 with default display (Bug#11768).
679 2012-07-05 Eli Zaretskii <eliz@gnu.org>
681 * xdisp.c (window_hscroll_limited): New function.
682 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
683 coordinates when window's hscroll is set to insanely large
686 2012-07-05 Juanma Barranquero <lekktu@gmail.com>
688 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
689 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
691 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
694 * lisp.h (xzalloc): New prototype. Omit needless casts.
695 * alloc.c (xzalloc): New function. Omit needless casts.
696 * charset.c: Omit needless casts. Convert all calls to
697 xmalloc with following memset to xzalloc.
698 * dispnew.c: Likewise.
699 * fringe.c: Likewise.
703 * w32fns.c: Likewise.
704 * w32font.c: Likewise.
705 * w32term.c: Likewise.
706 * xfaces.c: Likewise.
709 * atimer.c: Omit needless casts.
710 * buffer.c: Likewise.
711 * callproc.c: Likewise.
713 * coding.c: Likewise.
714 * composite.c: Likewise.
716 * doprnt.c: Likewise.
717 * editfns.c: Likewise.
720 * filelock.c: Likewise.
722 * gtkutil.c: Likewise.
723 * keyboard.c: Likewise.
726 * minibuf.c: Likewise.
729 * process.c: Likewise.
730 * region-cache.c: Likewise.
731 * search.c: Likewise.
732 * sysdep.c: Likewise.
733 * termcap.c: Likewise.
734 * terminal.c: Likewise.
735 * tparam.c: Likewise.
736 * w16select.c: Likewise.
738 * w32reg.c: Likewise.
739 * w32select.c: Likewise.
740 * w32uniscribe.c: Likewise.
741 * widget.c: Likewise.
745 * xselect.c: Likewise.
747 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
749 * fileio.c (time_error_value): Check the right error number.
750 Problem reported by Troels Nielsen in
751 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
753 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
755 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
756 This should be fixed in a better way; see Eli Zaretskii in
757 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
758 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
760 * fileio.c (time_error_value): Rename from special_mtime.
761 The old name's problems were noted by Eli Zaretskii in
762 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
764 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
765 This variable's comment says Emacs needs at least one GDB-visible
766 symbol of type enum pvec_type, to work around GDB problems.
767 The symbol's value doesn't matter.
769 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
770 that causes compilation to fail on pre-C99 compilers.
772 2012-07-04 Juanma Barranquero <lekktu@gmail.com>
774 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
775 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
777 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
779 * buffer.c (init_buffer_once): Fix initialization of
780 headers for buffer_defaults and buffer_local_symbols.
781 Reported by Juanma Barranquero <lekktu@gmail.com>.
783 2012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
785 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
786 * lisp.h (enum pvec_type): Use fewer bits.
787 (PSEUDOVECTOR_SIZE_BITS): New constant.
788 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
789 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
791 (PSEUDOVECTOR_TYPEP): New macro.
792 (TYPED_PSEUDOVECTORP): Use it.
793 * fns.c (internal_equal): Adapt code to extract pvectype.
794 * emacs.c (gdb_pvec_type): Update type.
795 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
796 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
797 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
798 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
799 (sweep_vectors): Use it. Use local var `total_bytes' instead of
800 abusing vector->header.next.nbytes.
801 (live_vector_p): Use PVEC_TYPE.
802 (mark_object): Adapt code to extract pvectype. Use switch.
804 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
806 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
807 Tighten new eassert a bit.
809 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
811 Fix compilation with --enable-gcc-warnings and -O1
813 * doprnt.c (doprnt): Change type of tem to int, initialize
814 to avoid compiler warning. Add eassert.
815 * search.c (simple_search): Initialize match_byte to avoid
816 compiler warning. Add eassert.
818 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
820 Avoid weird behavior with large horizontal scrolls.
821 Without this change, for example, large hscroll values would
822 mess up Emacs's display on Fedora 15 x86, presumably due to
823 overflows in int calculations in the display code.
824 Also, if buffers had long lines, Emacs would freeze.
825 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
826 (set_window_hscroll): New function, containing the old guts of
827 Fset_window_hscroll. Return the clipped value.
828 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
829 This avoids the need to check against PTRDIFF_MAX.
831 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
833 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
835 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
837 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
839 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
840 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
841 since GCC 4.4.6 issues a bogus warning for them.
843 Fix bugs in file timestamp newness comparisons.
844 * fileio.c (Ffile_newer_than_file_p):
845 * lread.c (Fload): Use full timestamp resolution of files,
846 not just the 1-second resolution, so that files that are only
847 slightly newer still count as newer.
848 * fileio.c (Ffile_newer_than_file_p): Don't assume file
849 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
851 2012-07-03 Paul Eggert <eggert@cs.ucla.edu>
853 * fileio.c: Improve handling of file time marker. (Bug#11852)
854 (special_mtime): New function.
855 (Finsert_file_contents, Fverify_visited_file_modtime):
856 Use it to set special mtime values consistently.
858 2012-07-03 Andreas Schwab <schwab@linux-m68k.org>
860 * fileio.c (Finsert_file_contents): Properly handle st_mtime
861 marker for non-existing file. (Bug#11852)
863 2012-07-03 Glenn Morris <rgm@gnu.org>
865 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
866 and did not make it into globals.h).
868 2012-07-03 Tom Tromey <tromey@redhat.com>
870 * window.c (Fset_window_margins, Fset_window_fringes)
871 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
872 * textprop.c (Fprevious_property_change): No longer static.
873 * syntax.c (Fsyntax_table_p): No longer static.
874 * process.c (Fget_process, Fprocess_datagram_address): No longer
876 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
877 * keyboard.c (Fcommand_execute): No longer static.
879 * insdel.c (Fcombine_after_change_execute): No longer static.
880 * image.c (Finit_image_library): No longer static.
881 * fileio.c (Fmake_symbolic_link): No longer static.
882 * eval.c (Ffetch_bytecode): No longer static.
883 * editfns.c (Fuser_full_name): No longer static.
884 * doc.c (Fdocumentation_property, Fsnarf_documentation):
886 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
888 * dired.c (Ffile_attributes): No longer static.
889 * composite.c (Fcomposition_get_gstring): No longer static.
890 * callproc.c (Fgetenv_internal): No longer static.
892 * ccl.h: Remove EXFUNs.
893 * buffer.h: Remove EXFUNs.
894 * dispextern.h: Remove EXFUNs.
895 * intervals.h: Remove EXFUNs.
896 * fontset.h: Remove EXFUN.
897 * font.h: Remove EXFUNs.
898 * dosfns.c (system_process_attributes): Remove EXFUN.
899 * keymap.h: Remove EXFUNs.
900 * lisp.h: Remove EXFUNs.
901 * w32term.h: Remove EXFUNs.
902 * window.h: Remove EXFUNs.
903 * xsettings.h: Remove EXFUN.
904 * xterm.h: Remove EXFUN.
906 2012-07-03 Glenn Morris <rgm@gnu.org>
908 * lisp.h (Frandom): Make it visible to C.
909 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
910 buffer for invisible buffers. (Bug#1229)
912 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
914 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
915 values which aren't power of 2.
916 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
917 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
920 2012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
922 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
924 * alloc.c (mark_object): Revert part of last patch to use `switch'.
926 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
928 * alloc.c (allocate_vector_block): Remove redundant
929 calls to mallopt if DOUG_LEA_MALLOC is defined.
930 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
931 avoid calls to mallopt if zero_vector is returned.
933 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
935 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
936 is enabled, avoid dereferencing NULL current_sblock if
939 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
941 Cleanup basic buffer management.
942 * buffer.h (struct buffer): Change layout to use generic vector
943 marking code. Fix some comments. Change type of 'clip_changed'
944 to bitfield. Remove unused #ifndef old.
945 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
946 (GET_OVERLAYS_AT): Fix indentation.
947 (for_each_per_buffer_object_at): New macro.
948 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
949 (Fbuffer_local_variables): Use it.
950 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
951 * alloc.c (allocate_buffer): Adjust to match new layout of
952 struct buffer. Fix comment.
953 (mark_overlay): New function.
954 (mark_buffer): Use it. Use mark_vectorlike to mark normal
955 Lisp area of struct buffer.
956 (mark_object): Use it. Adjust marking of misc objects
957 and related comments.
959 2012-07-02 Paul Eggert <eggert@cs.ucla.edu>
961 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
962 wrapper that is not needed because the wrapped code is a no-op (zero
963 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
964 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
966 2012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
968 * alloc.c (mark_buffer): Simplify. Remove prototype.
969 (mark_object): Add comment. Reorganize marking of vector-like
970 objects. Use CHECK_LIVE for all vector-like objects except buffers
971 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
972 redundant calls to mark_vectorlike for bool vectors.
974 2012-06-30 Glenn Morris <rgm@gnu.org>
976 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
978 * epaths.in (PATH_SITELOADSEARCH): New.
979 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
980 This is rather than relying on --enable-locallisppath elements
981 having "site-lisp" in their names. (Bug#10208#25, 11658)
983 2012-06-30 Eli Zaretskii <eliz@gnu.org>
985 * w32proc.c (sys_select): Accept and ignore one more argument.
987 * w32.c (emacs_gnutls_pull): Call select with one more argument.
989 * sysselect.h [DOS_NT]: Don't include sys/select.h.
990 (pselect) [!MS_DOS]: Redirect to sys_select.
992 * sysdep.c: Don't include dos.h and dosfns.h.
994 * process.c (sys_select):
995 * msdos.c (sys_select): Accept one more argument and ignore it.
997 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
998 adapt data types and code to that.
1001 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
1002 which clashes with the gnulib function of the same name.
1004 2012-06-30 Andreas Schwab <schwab@linux-m68k.org>
1006 * font.c (font_style_to_value, font_style_symbolic)
1007 (font_prop_validate_style): Add type checks for values in
1010 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
1012 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
1015 2012-06-29 Eli Zaretskii <eliz@gnu.org>
1017 * xdisp.c (try_window_id): Undo last change.
1019 * w32.c (getwd): Adjust commentary about startup_dir.
1020 (init_environment): Always call sys_access, even in non-MSVC
1021 builds. Don't chdir to the directory of the Emacs executable.
1022 This undoes code from 1997 which was justified by the need to
1023 "avoid conflicts when removing and renaming directories". But its
1024 downside was that every relative file name was being interpreted
1025 relative to the directory of the Emacs executable, which can never
1026 be TRT. In particular, it broke sys_access when called with
1027 relative file names.
1028 (sys_access): Map GetLastError to errno.
1030 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1032 * window.h (struct window): Change type of 'fringes_outside_margins'
1033 to bitfield. Fix comment. Adjust users accordingly.
1034 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
1036 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
1039 2012-06-29 Andreas Schwab <schwab@linux-m68k.org>
1041 * gnutls.c (emacs_gnutls_handshake):
1042 Add QUIT to make the loop interruptible.
1044 2012-06-29 Glenn Morris <rgm@gnu.org>
1046 * charset.c (init_charset): Make lack of etc/charsets fatal.
1048 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1050 * editfns.c (region_limit): Fix type mismatch.
1052 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1054 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
1055 undefined. Convert from xassert to eassert.
1056 * nsmenu.m: Convert from xassert to eassert.
1057 * nsterm.m: Likewise.
1059 2012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
1061 * editfns.c (region_limit): Clip to narrowing (bug#11770).
1063 2012-06-28 Paul Eggert <eggert@cs.ucla.edu>
1065 Avoid integer overflow on scroll-left and scroll-right.
1066 * window.c (HSCROLL_MAX): New macro.
1067 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
1068 overflow when requested scroll falls outside ptrdiff_t range.
1070 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1072 * window.h (struct window): Change type of 'hscroll',
1073 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
1074 'last_modified' and 'last_overlay_modified' to EMACS_INT.
1075 Adjust users accordingly.
1076 * xdisp.c (try_cursor_movement): Replace type check with eassert.
1077 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
1078 from EMACS_INT to ptrdiff_t.
1079 (make_window): Omit redundant initialization.
1081 2012-06-28 Juanma Barranquero <lekktu@gmail.com>
1083 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
1085 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1087 * window.h (struct window): Change type of 'use_time' and
1088 'sequence_number' from Lisp_Object to int.
1089 * frame.c (make_frame): Adjust users accordingly.
1090 * print.c (print_object): Likewise.
1091 * window.c (select_window, Fwindow_use_time, make_parent_window)
1092 (make_window): Likewise.
1094 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1096 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
1097 enabled with --enable-checking=[all,glyphs] configure option.
1098 Fix GLYPH_DEBUG usage assuming that it may be undefined,
1099 adjust comments accordingly.
1100 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
1101 undefined, adjust comments accordingly.
1102 * image.c: Likewise.
1103 * scroll.c: Likewise.
1104 * w32fns.c: Likewise.
1105 * w32term.c: Likewise.
1106 * xdisp.c: Likewise.
1107 * xfaces.c: Likewise.
1109 * xterm.c: Likewise.
1111 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1113 Generalize run-time debugging checks.
1114 * dispextern.h (XASSERTS): Remove.
1115 * fontset.c (xassert): Remove.
1116 Convert from xassert to eassert.
1117 * alloc.c: Convert from xassert to eassert.
1119 * dispnew.c: Likewise.
1121 * fringe.c: Likewise.
1122 * ftfont.c: Likewise.
1123 * gtkutil.c: Likewise.
1124 * image.c: Likewise.
1125 * keyboard.c: Likewise.
1127 * process.c: Likewise.
1128 * scroll.c: Likewise.
1129 * sound.c: Likewise.
1131 * w32console.c: Likewise.
1132 * w32fns.c: Likewise.
1133 * w32term.c: Likewise.
1134 * window.c: Likewise.
1135 * xdisp.c: Likewise.
1136 * xfaces.c: Likewise.
1138 * xselect.c: Likewise.
1139 * xterm.c: Likewise.
1141 2012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
1143 * fns.c (maybe_resize_hash_table): Output message when growing the
1146 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1148 * alloc.c (allocate_string_data): Remove dead code.
1149 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
1150 avoid GCC warning about unused macro.
1152 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1154 * alloc.c (allocate_string): Omit intervals initialization.
1155 * alloc.c (make_uninit_multibyte_string): Initialize intervals
1156 as in make_pure_string and make_pure_c_string.
1158 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1160 * alloc.c (allocate_string): Fix last change.
1162 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1164 * alloc.c (allocate_string): Remove two redundant calls
1165 to memset, add explicit initialization where appropriate.
1167 2012-06-27 Glenn Morris <rgm@gnu.org>
1169 * lisp.mk (lisp): Remove paths.elc.
1171 2012-06-27 Chong Yidong <cyd@gnu.org>
1173 * doc.c (Fsubstitute_command_keys): Fix punctuation.
1175 2012-06-26 John Wiegley <johnw@newartisans.com>
1177 * unexmacosx.c (copy_data_segment): Add two section names used
1178 on Mac OS X Lion: __mod_init_func and __mod_term_func.
1180 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
1181 when building with Clang.
1183 2012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
1185 * eval.c (Fapply): Allow calling it with a single argument.
1187 2012-06-26 Eli Zaretskii <eliz@gnu.org>
1189 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
1190 _stricmp and _strnicmp.
1191 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
1193 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1195 * alloc.c (allocate_window): Zero out non-Lisp part of newly
1197 (allocate_process): Likewise for new process.
1198 (allocate_terminal): Change to use offsetof.
1199 (allocate_frame): Likewise.
1200 * frame.c (make_frame): Omit redundant initialization.
1201 * window.c (make_parent_window): Use memset.
1202 (make_window): Omit redundant initialization.
1203 * process.c (make_process): Omit redundant initialization.
1204 * terminal.c (create_terminal): Likewise.
1206 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1208 * term.c (delete_tty): Remove redundant call to memset.
1210 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1212 * alloc.c: Remove build_string.
1213 * lisp.h: Define build_string as static inline. This provides
1214 a better opportunity to optimize away calls to strlen when the
1215 function is called with compile-time constant argument.
1216 * image.c (imagemagick_error): Convert to build_string.
1217 * w32proc.c (sys_spawnve): Likewise.
1218 * xterm.c (x_term_init): Likewise.
1220 2012-06-26 Paul Eggert <eggert@cs.ucla.edu>
1222 Use sprintf return value instead of invoking strlen on result.
1223 In the old days this wasn't portable, since some sprintf
1224 implementations returned char *. But they died out years ago and
1225 Emacs already assumes sprintf returns int.
1226 Similarly for float_to_string.
1227 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
1228 * ccl.c (ccl_driver):
1229 * character.c (string_escape_byte8):
1230 * data.c (Fnumber_to_string):
1231 * doprnt.c (doprnt):
1232 * print.c (print_object):
1233 * xdisp.c (message_dolog):
1234 * xfns.c (syms_of_xfns):
1235 Use sprintf or float_to_string result to avoid need to call strlen.
1236 * data.c (Fnumber_to_string):
1237 Use make_unibyte_string, since the string must be ASCII.
1238 * lisp.h, print.c (float_to_string): Now returns int length.
1239 * term.c (produce_glyphless_glyph):
1240 Use sprintf result rather than recomputing it.
1242 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
1243 * Makefile.in (ALL_CFLAGS):
1244 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
1245 * gmalloc.c, regex.c: Include <config.h> unconditionally.
1247 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1249 * dispextern.h (xstrcasecmp): Define to library function
1250 strcasecmp if available.
1251 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
1253 2012-06-25 Andreas Schwab <schwab@linux-m68k.org>
1255 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
1256 Avoid comma operator.
1257 * menu.c (push_submenu_start, push_submenu_end)
1258 (push_left_right_boundary, push_menu_pane): Likewise.
1259 * msdos.c (dos_rawgetc): Likewise.
1261 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1263 * xfns.c (xic_create_fontsetname): Remove redundant calls
1266 2012-06-25 Paul Eggert <eggert@cs.ucla.edu>
1268 * gtkutil.c (get_utf8_string): Remove redundant assignment.
1269 sprintf already null-terminates its output.
1271 * xfns.c (x_window): Remove redundant cast.
1273 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
1275 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
1276 `const char *' to `char *' to avoid compiler warning.
1278 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1280 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
1281 instead of truncating it to 63 (admittedly a generous limit).
1283 * process.c: Fix spelling and caps in comments.
1285 2012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
1287 * emacs.c (setpgrp): Remove definition, unused.
1288 * sysdep.c (setpgrp): Remove definition, not used in this file.
1290 2012-06-24 Juanma Barranquero <lekktu@gmail.com>
1292 * makefile.w32-in: Update dependencies.
1294 2012-06-24 Eli Zaretskii <eliz@gnu.org>
1296 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
1297 (SYSTIME_H): Add nt/inc/sys/time.h.
1299 * systime.h [WINDOWSNT]: Include sys/time.h.
1301 * s/ms-w32.h (struct timespec): Definition moved from
1302 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
1304 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1306 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
1307 * buffer.h (buffer_slot_type_mismatch):
1308 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1309 * eval.c (unwind_to_catch):
1310 * image.c (my_png_error, my_error_exit):
1311 * keyboard.c (quit_throw_to_read_char, user_error)
1312 (Fexit_recursive_edit, Fabort_recursive_edit):
1313 * lisp.h (die, args_out_of_range, args_out_of_range_3)
1314 (wrong_type_argument, buffer_overflow, __executable_start)
1315 (memory_full, buffer_memory_full, string_overflow, Fthrow)
1316 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
1317 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
1319 (child_setup) [!DOS_NT]:
1320 * lread.c (end_of_file_error, invalid_syntax):
1321 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1322 * puresize.h (pure_write_error):
1323 * search.c (matcher_overflow):
1324 * sound.c (sound_perror, alsa_sound_perror):
1325 * sysdep.c, syssignal.h (croak):
1326 * term.c (maybe_fatal, vfatal):
1327 * textprop.c (text_read_only):
1328 * undo.c (user_error):
1329 * unexmacosx.c (unexec_error):
1330 * xterm.c (x_ins_del_lines, x_delete_glyphs):
1331 Use _Noreturn rather than NO_RETURN.
1332 No need for separate decl merely because of _Noreturn.
1333 * sound.c (sound_warning, parse_sound):
1334 Remove unnecessary forward decls.
1336 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1338 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
1339 * lisp.h (WAIT_READING_MAX): New macro.
1340 * dispnew.c (Fsleep_for, sit_for):
1341 * keyboard.c (kbd_buffer_get_event):
1342 * process.c (Faccept_process_output):
1343 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
1344 This improves on the previous patch, which introduced a bug
1345 when time_t is unsigned and as wide as intmax_t.
1346 See <http://bugs.gnu.org/9000#51>.
1348 2012-06-23 Eli Zaretskii <eliz@gnu.org>
1350 * dispnew.c (sit_for, Fsleep_for):
1351 * keyboard.c (kbd_buffer_get_event):
1352 * process.c (Faccept_process_output): Avoid compiler warnings when
1353 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
1355 2012-06-23 Juanma Barranquero <lekktu@gmail.com>
1357 * makefile.w32-in: Update dependencies.
1359 * w32.c (ltime): Add return type and declare static.
1360 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
1362 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1364 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
1365 Privately reported by Herbert J. Skuhra.
1366 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
1368 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
1369 not make_lisp_timeval, when the argument is of type EMACS_TIME.
1371 2012-06-23 Eli Zaretskii <eliz@gnu.org>
1373 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
1374 last argument of make_unibyte_string.
1376 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
1377 language ID in the event parameters.
1379 * w32term.c (w32_read_socket): Put the new keyboard codepage into
1380 event.code, not the obscure "character set ID".
1382 2012-06-23 Chong Yidong <cyd@gnu.org>
1384 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
1386 2012-06-23 Eli Zaretskii <eliz@gnu.org>
1388 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
1389 * w32.c (fdutimens): New function.
1391 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
1393 * s/ms-w32.h (pselect): Redirect to sys_select.
1395 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
1397 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
1398 in the logic of incrementing and decrementing the value of
1399 use_relocatable_buffers.
1401 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1403 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
1404 Privately reported by Herbert J. Skuhra.
1405 [__FreeBSD__]: Remove "*/" typo after "#include".
1406 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
1407 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
1408 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
1409 Don't assume EMACS_TIME and struct timeval are the same type.
1411 2012-06-22 Paul Eggert <eggert@cs.ucla.edu>
1413 Support higher-resolution time stamps (Bug#9000).
1414 The time stamps are only nanosecond-resolution at the C level,
1415 since that's the best that any real-world system supports now.
1416 But they are picosecond-resolution at the Lisp level, as that's
1417 easy, and leaves room for future OS improvements.
1419 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
1422 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
1423 Don't get current time unless it's needed.
1425 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
1426 now provides it if it's absent.
1427 (start_atimer): Port to higher-res time stamps.
1428 Check for time stamp overflow. Don't get current time more
1429 often than is needed.
1431 * buffer.h (struct buffer): Buffer modtime now has high resolution.
1432 Include systime.h, not time.h.
1433 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
1435 * dired.c: Include stat-time.h.
1436 (Ffile-attributes): File times now have higher resolution.
1438 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
1439 (struct image): Timestamp now has higher resolution.
1441 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
1442 has at least microseconds now. All uses removed.
1443 (update_frame, update_single_window, update_window, update_frame_1)
1444 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
1446 * editfns.c (time_overflow): Now extern.
1447 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
1448 (float-time, Fformat_time_string, Fcurrent_time_string)
1449 (Fcurrent_time_zone): Accept and generate higher-resolution
1451 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
1452 (decode_time_components, lisp_seconds_argument): New functions.
1453 (make_time): Now static.
1454 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
1455 Report an error if the time is invalid, rather than having the caller
1458 * fileio.c: Include <stat-time.h>
1459 (Fcopy_file): Copy higher-resolution time stamps.
1460 Prefer to set the time stamp via a file descriptor if that works.
1461 (Fset_file_times, Finsert_file_contents, Fwrite_region)
1462 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
1463 (Fvisited_file_modtime, Fset_visited_file_modtime):
1464 Support higher-resolution time stamps.
1466 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
1468 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
1470 * image.c (prepare_image_for_display, clear_image_cache)
1471 (lookup_image): Port to higer-resolution time stamps.
1473 * keyboard.c (start_polling, bind_polling_period):
1474 Check for time stamp overflow.
1475 (read_char, kbd_buffer_get_event, timer_start_idle)
1476 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
1477 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
1478 Port to higher-resolution time stamps. Do not assume time_t is signed.
1479 (decode_timer): New function. Timers are now vectors of length 9,
1480 not 8, to accommodate the picosecond component.
1481 (timer_check_2): Use it.
1483 * nsterm.m (select_timeout, timeval_subtract): Remove.
1484 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
1485 as they're a bit more accurate and handle overflow better.
1486 (ns_select): Change prototype to be compatible with pselect.
1487 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
1488 * nsterm.h (ns_select): Adjust prototype.
1490 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
1491 us-resolution time stamps.
1492 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
1494 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
1496 * lisp.h (time_overflow): New decl.
1497 (wait_reading_process_output): First arg is now intmax_t, not int,
1498 to accommodate larger waits.
1500 * process.h (struct Lisp_Process.read_output_delay):
1501 Now counts nanoseconds, not microseconds.
1502 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
1504 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
1505 (wait_reading_process_output):
1506 Port to ns-resolution time stamps.
1507 (Faccept_process_output, wait_reading_process_output):
1508 Check for time stamp overflow. Do not assume time_t is signed.
1509 (select_wrapper): Remove; we now use pselect.
1510 (Fprocess_attributes): Now generates ns-resolution time stamps.
1512 * sysdep.c: Include utimens.h. Don't include utime.h
1513 or worry about struct utimbuf; gnulib does that for us now.
1514 (gettimeofday): Remove; gnulib provides a substitute.
1515 (make_timeval): New function.
1516 (set_file_times): Now sets ns-resolution time stamps.
1517 New arg FD; all uses changed.
1518 (time_from_jiffies, ltime_from_jiffies, get_up_time)
1519 (system_process_attributes):
1520 Now returns ns-resolution time stamp. All uses changed.
1521 Check for time stamp overflow.
1523 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
1524 provides a substitute now.
1526 * systime.h: Include timespec.h rather than sys/time.h and time.h,
1527 since it guarantees struct timespec.
1528 (EMACS_TIME): Now struct timespec, so that we can support
1529 ns-resolution time stamps.
1530 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
1531 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
1532 (EMACS_USECS): Remove.
1533 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
1534 so multiply the arg by 1000 before storing it.
1535 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
1537 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
1538 Port to ns-resolution time stamps.
1539 (EMACS_TIME_NEG_P): Remove; replaced by....
1540 (EMACS_TIME_SIGN): New macro.
1541 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
1542 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
1543 (set_file_times, make_time, lisp_time_argument): Adjust signature.
1544 (make_timeval, make_lisp_time, decode_time_components): New decls.
1545 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
1546 that it mishandled time_t overflow. You can't compare by subtracting!
1547 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
1548 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
1550 * term.c: Include <sys/time.h>.
1551 (timeval_to_Time): New function, for proper overflow wraparound.
1552 (term_mouse_position, term_mouse_click): Use it.
1554 * undo.c (record_first_change): Support higher-resolution time stamps
1556 (Fprimitive_undo): Use them when restoring time stamps.
1558 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
1559 (w32_get_internal_run_time):
1560 Port to higher-resolution Emacs time stamps.
1561 (ltime): Now accepts single 64-bit integer, as that's more convenient
1564 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
1566 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
1567 for compatibility with pselect. Support ns-resolution time stamps.
1569 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
1571 * xselect.c (wait_for_property_change, x_get_foreign_selection):
1572 Check for time stamp overflow, and support ns-resolution time stamps.
1574 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
1575 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
1576 (timeval_subtract): Remove; no longer needed.
1577 (XTflash, XTring_bell, x_wait_for_event):
1578 Port to ns-resolution time stamps. Don't assume time_t is signed.
1580 2012-06-22 Chong Yidong <cyd@gnu.org>
1582 * xdisp.c (x_consider_frame_title): Revert last change.
1584 2012-06-22 Eli Zaretskii <eliz@gnu.org>
1586 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
1587 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
1588 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
1589 staticidx goes up to 1597 out of 1600 = 0x640.)
1591 2012-06-20 Paul Eggert <eggert@cs.ucla.edu>
1593 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
1594 Otherwise, the umask might be mistakenly 0 while handling input signals.
1596 2012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
1598 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
1600 2012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
1602 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
1603 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
1604 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
1605 access to `contents' member of Lisp_Vector objects with AREF and ASET
1608 2012-06-19 Chong Yidong <cyd@gnu.org>
1610 * frame.c (delete_frame): When selecting a frame on a different
1611 text terminal, do not alter the terminal's top-frame.
1613 * xdisp.c (format_mode_line_unwind_data): Record the target
1614 frame's selected window and its terminal's top-frame.
1615 (unwind_format_mode_line): Restore them.
1616 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
1618 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
1619 since tty frames can be explicitly named.
1620 (prepare_menu_bars): Likewise.
1622 * term.c (Ftty_top_frame): New function.
1624 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1626 Port byte-code-meter to modern targets.
1627 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
1628 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
1629 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
1630 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
1631 (METER_1, METER_2): Simplify.
1633 2012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
1635 * data.c (Fdefalias): Return `symbol' (bug#11686).
1637 2012-06-18 Martin Rudalics <rudalics@gmx.at>
1639 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1640 gets killed during executing of this function (Bug#11665).
1641 Try to always return Qt when the buffer has been actually killed.
1642 (Vkill_buffer_query_functions): In doc-string say that functions
1643 run by this hook should not change the current buffer.
1645 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1647 Fix recently-introduced process.c problems found by static checking.
1648 * process.c (write_queue_push, write_queue_pop, send_process):
1649 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
1650 (write_queue_pop): Fix pointer signedness problem.
1651 (send_process): Remove unused local.
1653 2012-06-17 Chong Yidong <cyd@gnu.org>
1655 * xdisp.c (redisplay_internal): No need to redisplay terminal
1656 frames that are not on top.
1658 2012-06-17 Troels Nielsen <bn.troels@gmail.com>
1660 * process.c (make_process): Initialize write_queue.
1661 (write_queue_push, write_queue_pop): New functions.
1662 (send_process): Use them to maintain correct ordering of process
1665 2012-06-17 Paul Eggert <eggert@cs.ucla.edu>
1667 * lisp.h (eassert): Assume C89 or later.
1668 This removes the need for CHECK.
1669 (CHECK): Remove. Its comments about always evaluating its
1670 argument were confusing, as 'eassert' typically does not evaluate
1673 * coding.c (produce_chars): Use ptrdiff_t, not int.
1675 * xterm.c (x_draw_underwave): Check for integer overflow.
1676 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
1678 2012-06-17 Jan Djärv <jan.h.d@swipnet.se>
1680 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
1681 referenced (Bug#11583).
1683 2012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
1685 Implement wave-style variant of underlining.
1686 * dispextern.h (face_underline_type): New enum.
1687 (face): Add field for underline type.
1688 * nsterm.m (ns_draw_underwave): New function.
1689 (ns_draw_text_decoration): Use it.
1690 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
1692 (x_draw_glyph_string): Use them.
1693 * xfaces.c (Qline, Qwave): New Lisp objects.
1694 (check_lface_attrs, merge_face_ref)
1695 (Finternal_set_lisp_face_attribute, realize_x_face):
1696 Handle wave-style underline face attributes.
1697 * xterm.c (x_draw_underwave): New function.
1698 (x_draw_glyph_string): Use it.
1700 2012-06-16 Juanma Barranquero <lekktu@gmail.com>
1702 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
1703 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
1704 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
1705 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
1706 ($(BLD)/w32select.$(O)): Update dependencies.
1708 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1710 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
1711 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
1712 * character.c (_fetch_multibyte_char_p): Remove.
1713 * alloc.c: Include "character.h" before "buffer.h".
1715 * buffer.c: Likewise.
1716 * bytecode.c: Likewise.
1717 * callint.c: Likewise.
1718 * callproc.c: Likewise.
1719 * casefiddle.c: Likewise.
1720 * casetab.c: Likewise.
1721 * category.c: Likewise.
1723 * coding.c: Likewise.
1724 * composite.c: Likewise.
1725 * dired.c: Likewise.
1726 * dispnew.c: Likewise.
1728 * dosfns.c: Likewise.
1729 * editfns.c: Likewise.
1730 * emacs.c: Likewise.
1731 * fileio.c: Likewise.
1732 * filelock.c: Likewise.
1734 * fontset.c: Likewise.
1735 * fringe.c: Likewise.
1736 * indent.c: Likewise.
1737 * insdel.c: Likewise.
1738 * intervals.c: Likewise.
1739 * keyboard.c: Likewise.
1740 * keymap.c: Likewise.
1741 * lread.c: Likewise.
1742 * macros.c: Likewise.
1743 * marker.c: Likewise.
1744 * minibuf.c: Likewise.
1745 * nsfns.m: Likewise.
1746 * nsmenu.m: Likewise.
1747 * print.c: Likewise.
1748 * process.c: Likewise.
1749 * regex.c: Likewise.
1750 * region-cache.c: Likewise.
1751 * search.c: Likewise.
1752 * syntax.c: Likewise.
1754 * textprop.c: Likewise.
1756 * unexsol.c: Likewise.
1757 * w16select.c: Likewise.
1758 * w32fns.c: Likewise.
1759 * w32menu.c: Likewise.
1760 * window.c: Likewise.
1761 * xdisp.c: Likewise.
1763 * xmenu.c: Likewise.
1765 * xselect.c: Likewise.
1767 2012-06-16 Eli Zaretskii <eliz@gnu.org>
1769 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
1770 If all the glyphs of the glyph row came from strings, and we have no
1771 cursor positioning clues, put the cursor on the first glyph of the
1773 (handle_face_prop): Use chunk-relative overlay string index when
1774 indexing into it->string_overlays array. (Bug#11653)
1775 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
1776 the rightmost. (Bug#11720)
1778 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1780 * category.h (CHAR_HAS_CATEGORY): Define as inline.
1781 (CATEGORY_MEMBER): Enforce 1/0 value.
1782 * category.c (_temp_category_set): Remove.
1784 2012-06-16 Eli Zaretskii <eliz@gnu.org>
1786 * window.c (Fdelete_other_windows_internal)
1787 (Fdelete_window_internal): Don't access frame's mouse highlight
1788 info of the initial frame. (Bug#11677)
1790 2012-06-14 Paul Eggert <eggert@cs.ucla.edu>
1792 * .gdbinit (xgetint): Fix recently-introduced paren typo.
1793 Assume USE_2_TAGS_FOR_INTS.
1794 (xreload): Adjust $tagmask width to match recent lisp.h change.
1796 Simplify lisp.h in minor ways that should not affect code.
1797 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
1798 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
1799 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
1800 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
1801 (INTTYPEBITS): New macro, for clarity.
1802 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1803 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
1804 Simplify now that USE_LSB_TAG is always defined.
1805 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
1806 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
1808 2012-06-13 Juanma Barranquero <lekktu@gmail.com>
1810 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
1812 2012-06-13 Glenn Morris <rgm@gnu.org>
1814 * s/bsd-common.h (BSD4_3):
1815 * s/usg5-4-common.h (USG5_4): No longer define; unused.
1817 2012-06-13 Andreas Schwab <schwab@linux-m68k.org>
1819 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
1822 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
1824 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
1825 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1826 * alloc.c (widen_to_Lisp_Object): Remove.
1827 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
1828 * frame.c (delete_frame): Remove outdated comment.
1829 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
1830 USE_LISP_UNION_TYPE.
1831 (Fw32_unregister_hot_key): Likewise.
1832 (Fw32_toggle_lock_key): Likewise.
1833 * w32menu.c (add_menu_item): Likewise.
1834 (w32_menu_display_help): Use XIL instead of checking
1835 USE_LISP_UNION_TYPE.
1836 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
1837 (init_heap): Likewise.
1838 * w32term.c (w32_read_socket): Update comment.
1840 2012-06-13 Glenn Morris <rgm@gnu.org>
1842 * s/usg5-4-common.h, src/s/unixware.h:
1843 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
1845 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
1847 2012-06-13 Paul Eggert <eggert@cs.ucla.edu>
1849 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
1850 * alloc.c (make_number) [!defined make_number]:
1851 Remove, as lisp.h always defines this now.
1852 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
1853 (roundup_size): Verify that it is a power of 2.
1854 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
1855 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
1856 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
1857 -DUSE_LSB_TAG=0, to override the automatically-selected default.
1858 USE_LSB_TAG now is always defined to be either 0 or 1.
1860 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
1861 code works fine either way, and efficiency is not a concern here,
1862 as the union type is for debugging, not for production.
1863 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
1864 Use an inline function on all platforms when using the union type,
1865 since this is simpler and 'static inline' can be used portably
1867 (LISP_INITIALLY_ZERO): New macro.
1868 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
1869 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
1871 2012-06-12 Glenn Morris <rgm@gnu.org>
1873 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
1875 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
1877 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
1878 Move BROKEN_SIGIO to configure.
1880 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
1881 Move NO_TERMIO to configure.
1883 2012-06-12 Chong Yidong <cyd@gnu.org>
1885 * image.c (imagemagick_load_image): Use MagickFlattenImage if
1886 MagickMergeImageLayers is undefined. Use pixel pusher loop if
1887 MagickExportImagePixels is undefined.
1889 2012-06-12 Paul Eggert <eggert@cs.ucla.edu>
1891 * image.c (imagemagick_load_image): Remove unused label.
1893 2012-06-11 Glenn Morris <rgm@gnu.org>
1895 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1896 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
1897 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
1898 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
1900 2012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
1902 * alloc.c (make_byte_code): New function.
1903 (Fmake_byte_code): Use it. Don't purify here.
1904 * lread.c (read1): Use it as well to avoid extra allocation.
1906 2012-06-11 Chong Yidong <cyd@gnu.org>
1908 * image.c (imagemagick_load_image): Implement transparency.
1910 2012-06-10 Andreas Schwab <schwab@linux-m68k.org>
1912 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
1913 account for preceding backslashes. (Bug#11663)
1915 2012-06-09 Chong Yidong <cyd@gnu.org>
1917 * term.c: Support italics in capable terminals (Bug#9652).
1918 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
1919 (turn_on_face): Output using TS_enter_italic_mode if available.
1920 Don't handle unused blinking and alt-charset cases.
1921 (turn_off_face): Handle italic case; discard unused tty_blinking_p
1922 and tty_alt_charset_p cases.
1923 (tty_capable_p, init_tty): Support italics.
1925 * termchar.h (struct tty_display_info): Add field for italics.
1926 Remove unused blink field.
1928 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
1931 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
1932 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
1933 tty_alt_charset_p. Add tty_italic_p.
1935 2012-06-09 Michael Albinus <michael.albinus@gmx.de>
1937 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
1938 dbus_type_is_basic if available.
1939 (xd_extract_signed, xd_extract_unsigned): Rename from
1940 extract_signed and extract_unsigned, respectively. Adapt callers.
1942 2012-06-09 Chong Yidong <cyd@gnu.org>
1944 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
1946 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
1949 2012-06-08 Paul Eggert <eggert@cs.ucla.edu>
1951 * xdisp.c (vmessage): Treat frame message as multibyte.
1952 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
1953 would generate the diagnostic "Making \302\247 buffer-local while
1956 2012-06-08 Eli Zaretskii <eliz@gnu.org>
1958 * dispnew.c (showing_window_margins_p): Undo last change, which
1959 was done due to an inadvertent commit.
1960 (adjust_frame_glyphs_for_frame_redisplay): Do call
1961 showing_window_margins_p.
1963 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1965 * eval.c (Fmake_var_non_special): New primitive.
1966 (syms_of_eval): Defsubr it.
1967 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
1969 2012-06-08 Juanma Barranquero <lekktu@gmail.com>
1971 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
1972 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
1974 2012-06-08 Eli Zaretskii <eliz@gnu.org>
1976 * alloc.c (allocate_vectorlike): Fix last change.
1978 2012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
1980 Block-based vector allocation of small vectors.
1981 * lisp.h (struct vectorlike_header): New field `nbytes',
1982 adjust comment accordingly.
1983 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
1984 to denote vector blocks. Adjust users (live_vector_p,
1985 mark_maybe_pointer, valid_lisp_object_p) accordingly.
1986 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
1987 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
1988 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
1989 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
1990 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
1991 (roundup_size): New constant.
1992 (struct vector_block): New data type.
1993 (vector_blocks, vector_free_lists, zero_vector): New variables.
1994 (all_vectors): Rename to `large_vectors'.
1995 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
1996 (sweep_vectors): New functions.
1997 (allocate_vectorlike): Return `zero_vector' as the only vector of
1998 0 items. Allocate new vector from block if vector size is less than
1999 or equal to VBLOCK_BYTES_MAX.
2000 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
2001 (init_alloc_once): Add call to init_vectors.
2003 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2005 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
2007 2012-06-07 Paul Eggert <eggert@cs.ucla.edu>
2009 * doprnt.c (doprnt): Truncate multibyte char correctly.
2010 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
2011 would mishandle a string argument "Xc" if X was a multibyte
2012 character of length 2: it would truncate after X's first byte
2013 rather than including all of X.
2015 2012-06-06 Chong Yidong <cyd@gnu.org>
2017 * buffer.c (word_wrap): Doc fix.
2019 2012-06-04 Paul Eggert <eggert@cs.ucla.edu>
2021 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
2023 2012-06-03 Glenn Morris <rgm@gnu.org>
2025 * xdisp.c (tool-bar-style): Doc fix.
2027 2012-06-03 Ulrich Müller <ulm@gentoo.org>
2029 * Makefile.in (PAXCTL): Define.
2030 (temacs$(EXEEXT)): Disable memory randomization for the temacs
2031 binary via PaX flags if the paxctl utility is available.
2032 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
2033 Restore PaX flags to their default. (Bug#11398)
2035 2012-06-03 Chong Yidong <cyd@gnu.org>
2037 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
2040 2012-06-03 Chong Yidong <cyd@gnu.org>
2042 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
2043 (note_mode_line_or_margin_highlight): If there is no help echo,
2044 use mode-line-default-help-echo. Handle the case where the mouse
2045 position is past the end of the mode line string.
2047 * buffer.c (buffer_local_value_1): New function, split from
2048 Fbuffer_local_value; can return Qunbound.
2049 (Fbuffer_local_value): Use it.
2050 (Vmode_line_format): Docstring tweaks.
2052 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2054 * sysdep.c (system_process_attributes): Improve comment.
2056 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
2058 * keyboard.c: Export real-this-command to Elisp.
2059 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
2060 and DEFVAR it. Update all users.
2062 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2064 * minibuf.c (Fassoc_string): Remove duplicate declaration.
2066 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
2067 Convert pctcpu and pctmem to Lisp float properly.
2068 Let the compiler fold better, as 100.0/0x8000 is exact.
2070 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
2072 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
2075 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
2077 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
2079 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
2081 For a 'struct window', replace some Lisp_Object fields to
2082 bitfields where appropriate, remove unused fields.
2083 * window.h (struct window): Remove unused 'last_mark_x' and
2084 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
2085 change it's type from Lisp_Object to bitfield.
2086 Change type of 'force_start', 'optional_new_start',
2087 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
2088 fields from Lisp_Object to bitfield. Adjust users accordingly.
2090 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2092 Pacify gcc -Wdouble-precision when using Xaw.
2093 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
2094 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
2095 Use 'float' consistently, rather than 'float' in most places
2096 and 'double' in a couple of places.
2098 2012-05-31 Eli Zaretskii <eliz@gnu.org>
2100 * xdisp.c (handle_stop): Detect whether we have overlay strings
2101 loaded by testing it->current.overlay_string_index to be
2102 non-negative, instead of checking whether n_overlay_strings is
2103 positive. (Bug#11587)
2105 2012-05-31 Chong Yidong <cyd@gnu.org>
2107 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
2109 * doc.c (Fsubstitute_command_keys): Doc fix.
2111 2012-05-31 Eli Zaretskii <eliz@gnu.org>
2113 * search.c (search_buffer): Remove calls to
2114 r_alloc_inhibit_buffer_relocation, as it is now called by
2115 maybe_unify_char, which was the cause of relocation of buffer text
2118 2012-05-31 Eli Zaretskii <eliz@gnu.org>
2120 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
2121 for the duration of call to load_charset, to avoid problems with
2122 callers of maybe_unify_char that access buffer text through C
2125 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
2126 decrement the inhibition flag, instead of just setting or
2129 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2131 Remove obsolete '#define static' cruft.
2132 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
2133 This #undef was "temporary" in 2000; it is no longer needed
2134 now that '#define static' has gone away.
2135 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
2136 (gray_bitmap_bits): Remove; no longer needed.
2137 All uses replaced with definiens.
2138 * xterm.c: Include "bitmaps/gray.xbm".
2140 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2142 Clean up __executable_start, monstartup when --enable-profiling.
2143 The following changes affect the code only when profiling.
2144 * dispnew.c (__executable_start): Rename from safe_bcopy.
2145 Define only on platforms that need it.
2146 * emacs.c: Include <sys/gmon.h> when profiling.
2147 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
2148 (__executable_start): Remove decl, since lisp.h does it now.
2149 (safe_bcopy): Remove decl; no longer has that name.
2150 (main): Coalesce #if into single bit of code, for simplicity.
2151 Cast pointers to uintptr_t, since standard libraries want integers
2153 * lisp.h (__executable_start): New decl.
2155 2012-05-31 Glenn Morris <rgm@gnu.org>
2157 * image.c (Fimagemagick_types): Doc fix.
2159 2012-05-30 Jim Meyering <meyering@redhat.com>
2161 * callproc.c (Fcall_process_region): Include directory component
2162 in mkstemp error message (Bug#11586).
2164 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2166 * alloc.c, lisp.h (make_pure_vector): Now static.
2168 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
2170 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
2171 Move to byte-run.el.
2172 (Fautoload): Do the hash-doc more carefully.
2173 * data.c (Fdefalias): Purify definition, except for keymaps.
2174 (Qdefun): Move from eval.c.
2175 * lisp.h (Qdefun): Remove.
2176 * lread.c (read1): Tiny simplification.
2178 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
2180 Do not create empty overlays with the evaporate property (Bug#9642).
2181 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
2182 Bug#9642, but explicitly check that the buffer the overlay would
2183 be moved to is live and rearrange lines to make sure that errors
2184 will not put the overlay in an inconsistent state.
2185 (Fdelete_overlay): Cosmetics.
2187 2012-05-28 Eli Zaretskii <eliz@gnu.org>
2189 * w32term.c (my_bring_window_to_top): New function.
2190 (x_raise_frame): Use handle returned by DeferWindowPos, which
2191 could be different from the original one.
2192 Call my_bring_window_to_top instead of my_set_foreground_window.
2195 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
2196 by calling BringWindowToTop.
2198 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
2199 (WM_EMACS_END): Increase by one.
2201 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
2203 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
2204 This avoids undefined behavior that might cause the eassert
2205 to not catch an out-of-range value.
2207 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
2209 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
2210 Update dependencies.
2212 2012-05-27 Eli Zaretskii <eliz@gnu.org>
2214 * bidi.c (bidi_mirror_char): Fix last change.
2216 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
2218 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
2219 when referring to sectname field in printf format.
2221 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
2223 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
2224 Only r_alloc_inhibit_buffer_relocation needed to be added;
2225 the others were already declared.
2227 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
2228 before checking whether it's out of range. Put the check inside
2230 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
2232 2012-05-27 Ken Brown <kbrown@cornell.edu>
2234 * callproc.c (Fcall_process): Restore a line that was accidentally
2235 commented out in the 2011-02-13 change (bug#11547).
2237 2012-05-27 Eli Zaretskii <eliz@gnu.org>
2239 * lisp.h [REL_ALLOC]: Add prototypes for external functions
2240 defined on ralloc.c.
2242 * buffer.c [REL_ALLOC]: Remove prototypes of
2243 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
2244 they are now on lisp.h.
2246 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
2248 * search.c (search_buffer): Use it to inhibit relocation of buffer
2249 text while re_search_2 is doing its job, because re_search_2 is
2250 passed C pointers to buffer text. (Bug#11519)
2252 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
2255 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
2256 state after an additional call to move_it_in_display_line_to, keep
2257 the values of it->max_ascent and it->max_descent found for the
2259 (pos_visible_p): Revert the comparison against bottom_y to what it
2260 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
2263 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2265 Fix coding-related core dumps with gcc -ftrapv.
2266 The code was computing A - B, where A and B are pointers, and B is
2267 random garbage. This can lead to core dumps on platforms that
2268 have special pointer registers, and it also leads to core dumps on
2269 x86-64 when compiled with gcc -ftrapv. The fix is to compute
2270 A - B only when B is initialized properly.
2271 * coding.c (coding_set_source, coding_set_destination): Return void.
2272 (coding_change_source, coding_change_destinations): New functions,
2273 with the old behaviors of coding_set_source and coding_set_destination.
2274 All callers that need an offset changed to use these new functions.
2276 2012-05-26 Glenn Morris <rgm@gnu.org>
2278 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
2280 2012-05-26 Eli Zaretskii <eliz@gnu.org>
2282 Extend mouse support on W32 text-mode console.
2283 * xdisp.c (draw_row_with_mouse_face):
2284 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
2286 * w32console.c: Include window.h.
2287 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
2289 (initialize_w32_display): Initialize mouse-highlight data.
2291 * w32inevt.c: Include termchar.h and window.h.
2292 (do_mouse_event): Support mouse-autoselect-window. When the mouse
2293 moves, call note_mouse_highlight. If help_echo changed, call
2294 gen_help_event to produce help-echo message in the echo area.
2295 Call clear_mouse_face if mouse_face_hidden is set in the mouse
2298 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
2300 * lread.c (read1): Simplify slightly to avoid an overflow warning
2301 with GCC 4.7.0 on x86-64.
2303 2012-05-26 Eli Zaretskii <eliz@gnu.org>
2305 * bidi.c (bidi_mirror_char): Revert last change: an int is
2306 definitely wide enough here.
2308 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
2310 Fix integer width and related bugs (Bug#9874).
2311 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
2312 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
2313 (string_bytes, check_sblock, allocate_string_data):
2314 (compact_small_strings, Fmake_bool_vector, make_string)
2315 (make_unibyte_string, make_multibyte_string)
2316 (make_string_from_bytes, make_specified_string)
2317 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
2318 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
2320 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2321 (allocate_pseudovector):
2322 Use int, not EMACS_INT, where int is wide enough.
2323 (inhibit_garbage_collection, Fgarbage_collect):
2324 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2325 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
2326 int might not be wide enough.
2327 (bidi_cache_search, bidi_cache_find, bidi_init_it)
2328 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
2329 (bidi_at_paragraph_end, bidi_find_paragraph_start)
2330 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2331 (bidi_level_of_next_char, bidi_move_to_visually_next):
2332 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2333 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
2334 (Fkill_buffer, Fset_buffer_major_mode)
2335 (advance_to_char_boundary, Fbuffer_swap_text)
2336 (Fset_buffer_multibyte, overlays_at, overlays_in)
2337 (overlay_touches_p, struct sortvec, record_overlay_string)
2338 (overlay_strings, recenter_overlay_lists)
2339 (adjust_overlays_for_insert, adjust_overlays_for_delete)
2340 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
2341 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
2342 (Foverlay_recenter, last_overlay_modification_hooks_used)
2343 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
2344 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2345 (validate_region): Omit unnecessary test for b <= e,
2346 since that's guaranteed by the previous test.
2347 (adjust_overlays_for_delete): Avoid pos + length overflow.
2348 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
2349 (report_overlay_modification):
2350 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2351 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
2352 Omit pointer cast, which isn't needed anyway, and doesn't work
2353 after the EMACS_INT -> ptrdiff_t change.
2354 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
2355 * buffer.h: Adjust decls to match defn changes elsewhere.
2356 (struct buffer_text, struct buffer):
2357 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2358 Use EMACS_INT, not int, where int might not be wide enough.
2359 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
2360 not int, to avoid needless 32-bit limit on 64-bit hosts.
2361 (exec_byte_code): Use tighter memory-full test, one that checks
2362 for alloca overflow. Don't compute the address of the object just
2363 before an array, as that's not portable. Use EMACS_INT, not
2364 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
2365 * callint.c (Fcall_interactively):
2366 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2367 * callproc.c (call_process_kill, Fcall_process):
2368 Don't assume pid_t fits into an Emacs fixnum.
2369 (call_process_cleanup, Fcall_process, child_setup):
2370 Don't assume pid_t fits into int.
2371 (call_process_cleanup, Fcall_process, delete_temp_file)
2372 (Fcall_process_region):
2373 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2374 (Fcall_process): Simplify handling of volatile integers.
2375 Use int, not EMACS_INT, where int will do.
2376 * casefiddle.c (casify_object, casify_region, operate_on_word)
2377 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
2378 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2379 (casify_object): Avoid integer overflow when overallocating buffer.
2380 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
2381 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
2382 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
2383 * category.h (CATEGORYP): Don't assume arg is nonnegative.
2384 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
2385 integers are now checked earlier. All uses replaced with XINT.
2387 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2388 For CCL_MapSingle, check that content and value are in int range.
2389 (ccl_driver, Fregister_code_conversion_map):
2390 Check that Vcode_version_map_vector is a vector.
2391 (resolve_symbol_ccl_program): Check that vector header is in range.
2392 Always copy the vector, so that we can check its contents reliably
2393 now rather than having to recheck each instruction as it's being
2394 executed. Check that vector words fit in 'int'.
2395 (ccl_get_compiled_code, Fregister_ccl_program)
2396 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
2397 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
2398 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
2399 contents are in range.
2400 (Fccl_execute_on_string): Check that status is in range.
2401 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
2402 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
2403 Accept and return EMACS_INT, not int, because callers can pass values
2405 (c_string_width, strwidth, lisp_string_width, chars_in_text)
2406 (multibyte_chars_in_text, parse_str_as_multibyte)
2407 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
2408 (str_as_unibyte, str_to_unibyte, string_count_byte8)
2409 (string_escape_byte8, Fget_byte):
2410 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2411 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
2412 avoid mishandling large integers.
2413 * character.h: Adjust decls to match defn changes elsewhere.
2414 * charset.c (load_charset_map_from_file, find_charsets_in_text)
2415 (Ffind_charset_region):
2416 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2417 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
2418 (load_charset_map_from_vector, Fdefine_charset_internal):
2419 Don't assume fixnum fits in int.
2420 (load_charset_map_from_vector, Fmap_charset_chars):
2421 Remove now-unnecessary CHECK_NATNUMs.
2422 (Fdefine_charset_internal): Check ranges here, more carefully.
2423 Don't rely on undefined behavior with signed left shift overflow.
2424 Don't assume unsigned int fits into fixnum, or that fixnum fits
2425 into unsigned int. Don't require max_code to be a valid fixnum;
2426 that's not true for gb10830 4-byte on a 32-bit host. Allow
2427 invalid_code to be a cons, for the same reason. Require code_offset
2428 to be a character. Avoid int overflow if max_char is close
2430 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
2431 this is intended anyway and avoids some undefined behavior.
2432 (load_charset_map): Pass unsigned, not int, as 2nd arg of
2433 INDEX_TO_CODE_POINT, as that's what it expects.
2434 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
2435 * charset.h (DECODE_CHAR): Return int, not unsigned;
2436 this is what was intended anyway, and it avoids undefined behavior.
2437 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
2438 integer-overflow issues.
2439 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
2440 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
2441 where the argument is EMACS_INT, and this behavior is not intended.
2442 * chartab.c (Fmake_char_table, Fset_char_table_range)
2443 (uniprop_get_decoder, uniprop_get_encoder):
2444 Don't assume fixnum fits in int.
2445 * cmds.c (move_point): New function, that does the gist of
2446 Fforward_char and Fbackward_char, but does so while checking
2447 for integer overflow more accurately.
2448 (Fforward_char, Fbackward_char): Use it.
2449 (Fforward_line, Fend_of_line, internal_self_insert)
2450 (internal_self_insert):
2451 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2452 Fix a FIXME, by checking for integer overflow when calculating
2453 target_clm and actual_clm.
2454 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
2455 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
2456 (ASSURE_DESTINATION, coding_alloc_by_realloc)
2457 (coding_alloc_by_making_gap, alloc_destination)
2458 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
2459 (encode_coding_utf_16, detect_coding_emacs_mule)
2460 (decode_coding_emacs_mule, encode_coding_emacs_mule)
2461 (detect_coding_iso_2022, decode_coding_iso_2022)
2462 (encode_invocation_designation, encode_designation_at_bol)
2463 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2464 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
2465 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
2466 (encode_coding_ccl, encode_coding_raw_text)
2467 (detect_coding_charset, decode_coding_charset)
2468 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
2469 (produce_composition, produce_charset, produce_annotation)
2470 (decode_coding, handle_composition_annotation)
2471 (handle_charset_annotation, consume_chars, decode_coding_gap)
2472 (decode_coding_object, encode_coding_object, detect_coding_system)
2473 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
2474 (code_convert_region, code_convert_string)
2475 (Fdefine_coding_system_internal)
2476 (coding_set_source, coding_set_destination):
2477 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2478 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
2479 (Fdefine_coding_system_internal):
2480 Don't assume fixnums fit in int.
2481 (decode_coding_gap, decode_coding_object, encode_coding_object)
2482 (Fread_coding_system, Fdetect_coding_region)
2483 (Funencodable_char_position, Fcheck_coding_systems_region)
2484 (get_translation, handle_composition_annotation, consume_chars):
2485 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2486 (consume_chars): Rewrite to not calculate an address outside buffer.
2487 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
2488 Don't access memory outside of the args array.
2489 (Fdefine_coding_system_internal): Check for charset-id overflow.
2490 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
2491 result of ENCODE_CHAR.
2492 * coding.h: Adjust decls to match defn changes elsewhere.
2493 (struct coding_system):
2494 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2495 * composite.c (get_composition_id, find_composition)
2496 (run_composition_function, update_compositions)
2497 (compose_text, composition_gstring_put_cache)
2498 (composition_gstring_p, composition_gstring_width)
2499 (fill_gstring_header, fill_gstring_body, autocmp_chars)
2500 (composition_compute_stop_pos, composition_reseat_it)
2501 (composition_update_it, struct position_record)
2502 (find_automatic_composition, composition_adjust_point)
2503 (Fcomposition_get_gstring, Ffind_composition_internal):
2504 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2505 (update_compositions):
2506 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2507 * composite.h: Adjust decls to match defn changes elsewhere.
2508 (struct composition):
2509 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2510 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
2511 Do not attempt to compute the address of the object just before a
2512 buffer; this is not portable.
2514 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2515 (Faset): Use int, not EMACS_INT, where int is wide enough.
2516 (Fstring_to_number): Don't assume fixnums fit in int.
2517 (Frem): Don't assume arg is nonnegative.
2518 * dbusbind.c (xd_append_arg): Check for integers out of range.
2519 (Fdbus_call_method): Don't overflow the timeout int.
2520 (extract_signed, extract_unsigned): New functions.
2521 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
2522 (xd_get_connection_references): Return ptrdiff_t, not int.
2524 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
2525 (xd_read_message_1):
2526 Use int, not unsigned, where the dbus API uses int.
2527 (Fdbus_message_internal): Don't overflow mtype.
2528 (syms_of_dbusbind): Allocate right-sized buffer for integers.
2529 * dired.c (directory_files_internal, file_name_completion, scmp)
2530 (file_name_completion_stat):
2531 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2532 (file_name_completion): Don't overflow matchcount.
2533 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
2534 * dispextern.h: Adjust decls to match defn changes elsewhere.
2535 (struct text_pos, struct glyph, struct bidi_saved_info)
2536 (struct bidi_string_data, struct bidi_it, struct composition_it)
2538 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2539 (struct display_pos, struct composition_it, struct it):
2540 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2541 * dispnew.c (increment_matrix_positions)
2542 (increment_row_positions, mode_line_string)
2543 (marginal_area_string):
2544 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2545 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
2546 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2547 (duration_to_sec_usec): New function, to check for overflow better.
2548 (Fsleep_for, sit_for): Use it.
2549 * doc.c (get_doc_string, store_function_docstring):
2550 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2551 (get_doc_string, Fsnarf_documentation):
2552 Use int, not EMACS_INT, where int is wide enough.
2554 Use SAFE_ALLOCA, not alloca.
2555 Check for overflow when converting EMACS_INT to off_t.
2556 * doprnt.c (doprnt):
2557 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2558 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
2559 Don't assume uid_t fits into fixnum.
2560 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
2561 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
2562 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
2563 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
2564 (general_insert_function)
2565 (Finsert_char, make_buffer_string, make_buffer_string_both)
2566 (update_buffer_properties, Fbuffer_substring)
2567 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
2568 (Fsubst_char_in_region, check_translation)
2569 (Ftranslate_region_internal, save_restriction_restore, Fformat)
2570 (transpose_markers, Ftranspose_regions):
2571 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2572 (clip_to_bounds): Move to lisp.h as an inline function).
2573 (Fconstrain_to_field): Don't assume integers are nonnegative.
2574 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
2575 (Fsubst_char_in_region, Fsave_restriction):
2576 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2577 (Femacs_pid): Don't assume pid_t fits into fixnum.
2578 (lo_time): Use int, not EMACS_INT, when int suffices.
2579 (lisp_time_argument): Check for usec out of range.
2580 (Fencode_time): Don't assume fixnum fits in int.
2581 (Fuser_login_name, Fuser_full_name): Signal an error
2582 if a uid argument is out of range, rather than relying on
2584 (Fformat_time_string): Remove now-unnecessary check.
2585 lisp_time_argument checks for out-of-range usec now.
2586 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
2587 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
2588 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
2589 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
2590 (init_cmdargs, Fdump_emacs):
2591 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2592 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
2593 the bottom (typically) 32 bits of the fixnum.
2594 * eval.c (specpdl_size, call_debugger):
2595 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2596 (when_entered_debugger, Fbacktrace_debug):
2597 Don't assume fixnum can fit in int.
2598 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
2599 the object just before a buffer; this is not portable.
2600 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
2601 (grow_specpdl, unbind_to):
2602 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2603 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
2604 (grow_specpdl): Simplify allocation by using xpalloc.
2605 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
2606 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
2607 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
2608 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2609 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
2611 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2612 (Fcopy_file, non_regular_nbytes, read_non_regular)
2613 (Finsert_file_contents):
2614 Use int, not EMACS_INT, where int is wide enough.
2615 (READ_BUF_SIZE): Verify that it fits in int.
2616 (Finsert_file_contents): Check that counts are in proper range,
2617 rather than assuming fixnums fit into ptrdiff_t etc.
2618 Don't assume fixnums fit into int.
2619 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
2620 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
2621 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
2622 (string_char_to_byte, string_byte_to_char)
2623 (string_make_multibyte, string_to_multibyte)
2624 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
2625 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
2626 (substring_both, Fdelete, internal_equal, Ffillarray)
2627 (Fclear_string, mapcar1)
2628 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
2629 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
2630 (larger_vector, make_hash_table, maybe_resize_hash_table)
2631 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
2632 (Fmaphash, secure_hash):
2633 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2634 (concat): Check for string index and length overflow.
2635 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
2637 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2638 (larger_vector): New API (vec, incr_min, size_max) replaces old
2639 one (vec, new_size, init). This catches size overflow.
2640 INIT was removed because it was always Qnil.
2641 All callers changed.
2642 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
2643 the upper bound on a hash table index size.
2644 (make_hash_table, maybe_resize_hash_table): Use it.
2645 (secure_hash): Computer start_byte and end_byte only after
2646 they're known to be in ptrdiff_t range.
2647 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
2648 (Ffont_get_glyphs, Ffont_at):
2649 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2650 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
2651 (Flist_fonts, Fopen_font):
2652 Don't assume fixnum can fit in int.
2653 (check_gstring): Don't assume index can fit in int.
2654 (font_match_p): Check that fixnum is a character, not a nonnegative
2655 fixnum, since the later code needs to stuff it into an int.
2656 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
2657 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
2658 conversion overflow issues.
2659 (Fopen_font): Check for integer out of range.
2660 (Ffont_get_glyphs): Don't assume index can fit in int.
2661 * font.h: Adjust decls to match defn changes elsewhere.
2662 * fontset.c (reorder_font_vector): Redo score calculation to avoid
2664 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
2665 printmax_t, where ptrdiff_t is wide enough.
2666 (Finternal_char_font):
2667 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2668 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
2669 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
2670 (Fset_frame_position, x_set_frame_parameters)
2671 (x_set_line_spacing, x_set_border_width)
2672 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
2673 Check that fixnums are in proper range for system types.
2674 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
2675 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2676 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
2677 Use SAFE_ALLOCA_LISP, not alloca.
2678 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
2679 intptr_t is wide enough.
2680 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
2681 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
2682 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
2683 Check for fixnum out of range.
2684 * ftfont.c (ftfont_list): Don't assume index fits in int.
2685 Check that fixnums are in proper range for system types.
2686 (ftfont_shape_by_flt):
2687 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2688 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2689 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2690 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
2691 Check that fixnums are in proper range for system types.
2692 * gnutls.h: Adjust decls to match defn changes elsewhere.
2693 * gtkutil.c (xg_dialog_run):
2694 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2695 (update_frame_tool_bar):
2696 Check that fixnums are in proper range for system types.
2697 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
2698 (lookup_image): Check that fixnums are in range for system types.
2699 * indent.c (last_known_column, last_known_column_point):
2700 (current_column_bol_cache):
2701 (skip_invisible, current_column, check_display_width):
2702 (check_display_width, scan_for_column, current_column_1)
2703 (Findent_to, Fcurrent_indentation, position_indentation)
2704 (indented_beyond_p, Fmove_to_column, compute_motion):
2705 (Fcompute_motion, Fvertical_motion):
2706 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2707 (last_known_column_modified): Use EMACS_INT, not int.
2708 (check_display_width):
2710 Check that fixnums and floats are in proper range for system types.
2711 (compute_motion): Don't assume index or fixnum fits in int.
2712 (compute_motion, Fcompute_motion):
2713 Use int, not EMACS_INT, when it is wide enough.
2714 (vmotion): Omit local var start_hpos that is always 0; that way
2715 we don't need to worry about overflow in expressions involving it.
2716 * indent.h: Adjust decls to match defn changes elsewhere.
2718 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2719 Use int, not EMACS_INT, where int is wide enough.
2720 Remove unused members ovstring_chars_done and tab_offset;
2722 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
2723 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
2724 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
2725 (make_gap, copy_text, insert, insert_and_inherit)
2726 (insert_before_markers, insert_before_markers_and_inherit)
2727 (insert_1, count_combining_before, count_combining_after)
2728 (insert_1_both, insert_from_string)
2729 (insert_from_string_before_markers, insert_from_string_1)
2730 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
2731 (adjust_after_replace, adjust_after_insert, replace_range)
2732 (replace_range_2, del_range, del_range_1, del_range_byte)
2733 (del_range_both, del_range_2, modify_region)
2734 (prepare_to_modify_buffer, signal_before_change)
2735 (signal_after_change, Fcombine_after_change_execute):
2736 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2737 * intervals.c (traverse_intervals, rotate_right, rotate_left)
2738 (balance_an_interval, split_interval_right, split_interval_left)
2739 (find_interval, next_interval, update_interval)
2740 (adjust_intervals_for_insertion, delete_node, delete_interval)
2741 (interval_deletion_adjustment, adjust_intervals_for_deletion)
2742 (static_offset_intervals, offset_intervals)
2743 (merge_interval_right, merge_interval_left, make_new_interval)
2744 (graft_intervals_into_buffer, temp_set_point_both)
2745 (temp_set_point, set_point, adjust_for_invis_intang)
2746 (set_point_both, move_if_not_intangible, get_property_and_range)
2747 (get_local_map, copy_intervals, copy_intervals_to_string)
2748 (compare_string_intervals, set_intervals_multibyte_1):
2749 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2750 * intervals.h: Adjust decls to match defn changes elsewhere.
2752 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2753 * keyboard.c (this_command_key_count, this_single_command_key_start)
2754 (before_command_key_count, before_command_echo_length, echo_now)
2755 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
2756 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
2757 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
2758 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
2759 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2760 (last_non_minibuf_size, last_point_position, echo_truncate)
2761 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
2762 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
2763 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
2764 (stuff_buffered_input):
2765 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2766 (last_auto_save, command_loop_1, read_char):
2767 Use EMACS_INT, not int, to avoid integer overflow.
2768 (record_char): Avoid overflow in total_keys computation.
2769 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
2770 * keyboard.h: Adjust decls to match defn changes elsewhere.
2771 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
2772 (Fkey_description, Fdescribe_vector, Flookup_key):
2773 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2774 (click_position): New function, to check that positions are in range.
2775 (Fcurrent_active_maps):
2777 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2778 (Faccessible_keymaps, Fkey_description):
2779 (preferred_sequence_p):
2780 Don't assume fixnum can fit into int.
2781 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
2782 Check for integer overflow in size calculations.
2783 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
2784 avoid mishandling large integers.
2785 * lisp.h: Adjust decls to match defn changes elsewhere.
2786 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
2787 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
2788 (struct Lisp_Marker):
2789 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2790 (clip_to_bounds): Now an inline function, moved here from editfns.c.
2791 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
2792 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
2793 All callers changed.
2794 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
2795 Assume the arg has valid form, since it always does.
2796 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
2797 unsigned integer system type.
2798 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
2799 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
2800 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2801 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
2802 (duration_to_sec_usec): New decl.
2803 * lread.c (read_from_string_index, read_from_string_index_byte)
2804 (read_from_string_limit, readchar, unreadchar, openp)
2805 (read_internal_start, read1, oblookup):
2806 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2807 (Fload, readevalloop, Feval_buffer, Feval_region):
2808 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2809 (openp): Check for out-of-range argument to 'access'.
2810 (read1): Use int, not EMACS_INT, where int is wide enough.
2811 Don't assume fixnum fits into int.
2812 Fix off-by-one error that can read outside a buffer.
2813 (read_filtered_event): Use duration_to_sec_usec
2814 to do proper overflow checking on durations.
2815 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
2816 in size calculation.
2817 (Fexecute_kbd_macro):
2818 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2819 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
2820 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
2821 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
2822 (set_marker_both, set_marker_restricted_both, marker_position)
2823 (marker_byte_position, Fbuffer_has_markers_at):
2824 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2825 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
2826 * menu.c (ensure_menu_items): Rename from grow_menu_items.
2827 It now merely ensures that the menu is large enough, without
2828 necessarily growing it, as this avoids some integer overflow issues.
2829 All callers changed.
2830 (keymap_panes, parse_single_submenu, Fx_popup_menu):
2831 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2832 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
2833 Use SAFE_ALLOCA_LISP, not alloca.
2834 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
2835 to EMACS_INT. Check that fixnums are in proper range for system types.
2836 * minibuf.c (minibuf_prompt_width, string_to_object)
2837 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
2838 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
2839 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2840 (get_minibuffer, read_minibuf_unwind):
2841 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2842 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
2843 this simplifies overflow checking. All callers changed.
2844 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
2846 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2847 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
2848 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
2849 Check that fixnums are in proper range for system types.
2850 (Fx_create_frame, Fx_show_tip):
2851 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2852 * nsfont.m (ns_findfonts, nsfont_list_family):
2853 Don't assume fixnum fits in long.
2854 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
2855 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2856 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
2858 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
2859 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2860 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
2861 (PRINTDECLARE, PRINTPREPARE):
2862 (strout, print_string):
2863 (print, print_preprocess, print_check_string_charset_prop)
2865 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2867 (temp_output_buffer_setup, Fprin1_to_string, print_object):
2868 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2869 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
2870 (printchar, strout): Use xpalloc to catch size calculation overflow.
2871 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
2872 (print_error_message): Use SAFE_ALLOCA, not alloca.
2873 (print_object): Use int, not EMACS_INT, where int is wide enough.
2874 (print_depth, new_backquote_output, print_number_index):
2875 Use ptrdiff_t, not int, where int might not be wide enough.
2876 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
2877 (Fset_process_window_size, Fformat_network_address)
2878 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
2880 Check that fixnums are in proper range for system types.
2881 (Fsignal_process): Simplify by avoiding a goto.
2882 Check for process-ids out of pid_t range rather than relying on
2884 (process_tick, update_tick): Use EMACS_INT, not int.
2885 (Fformat_network_address, read_process_output, send_process)
2886 (Fprocess_send_region, status_notify):
2887 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2888 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
2889 (wait_reading_process_output, read_process_output, exec_sentinel):
2890 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2891 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
2892 (Faccept_process_output): Use duration_to_sec_usec to do proper
2893 overflow checking on durations.
2894 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
2895 Don't assume pid_t fits in int.
2896 * process.h (struct Lisp_Process): Members tick and update_tick
2897 are now of type EMACS_INT, not int.
2898 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
2899 configured --with-wide-int.
2900 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
2901 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
2902 * search.c (looking_at_1, string_match_1):
2903 (fast_string_match, fast_c_string_match_ignore_case)
2904 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
2905 (scan_newline, find_before_next_newline, search_command)
2906 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
2907 (set_search_regs, wordify):
2910 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2911 (string_match_1, search_buffer, set_search_regs):
2913 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2914 (wordify): Check for overflow in size calculation.
2915 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
2916 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
2917 Check that fixnums are in proper range for system types.
2918 * sound.c (struct sound_device)
2919 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
2920 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2921 (Fplay_sound_internal):
2922 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2923 * syntax.c (struct lisp_parse_state, find_start_modiff)
2924 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
2925 (Fparse_partial_sexp):
2926 Don't assume fixnums can fit in int.
2927 (struct lisp_parse_state, find_start_pos, find_start_value)
2928 (find_start_value_byte, find_start_begv)
2929 (update_syntax_table, char_quoted, dec_bytepos)
2930 (find_defun_start, prev_char_comend_first, back_comment):
2931 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
2932 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
2933 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2934 (Finternal_describe_syntax_value): Check that match_lisp is a
2935 character, not an integer, since the code stuffs it into int.
2936 (scan_words, scan_sexps_forward):
2937 Check that fixnums are in proper range for system types.
2939 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2940 (scan_sexps_forward):
2941 Use CHARACTERP, not INTEGERP, since the value must fit into int.
2942 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
2943 * syntax.h: Adjust decls to match defn changes elsewhere.
2944 (struct gl_state_s):
2945 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2946 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
2947 MOST_POSITIVE_FIXNUM.
2948 * sysdep.c (wait_for_termination_1, wait_for_termination)
2949 (interruptible_wait_for_termination, mkdir):
2950 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
2951 (emacs_read, emacs_write):
2952 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2953 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
2954 and double all fit in int.
2955 * term.c (set_tty_color_mode):
2956 Check that fixnums are in proper range for system types.
2957 * termhooks.h (struct input_event):
2958 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2959 * textprop.c (validate_interval_range, interval_of)
2960 (Fadd_text_properties, set_text_properties_1)
2961 (Fremove_text_properties, Fremove_list_of_text_properties)
2962 (Ftext_property_any, Ftext_property_not_all)
2963 (copy_text_properties, text_property_list, extend_property_ranges)
2964 (verify_interval_modification):
2965 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2966 (Fnext_single_char_property_change)
2967 (Fprevious_single_char_property_change):
2968 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2969 (copy_text_properties):
2970 Check for integer overflow in index calculation.
2971 * undo.c (last_boundary_position, record_point, record_insert)
2972 (record_delete, record_marker_adjustment, record_change)
2973 (record_property_change):
2974 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2975 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
2976 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2977 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2978 (Fx_hide_tip, Fx_file_dialog):
2979 * w32menu.c (set_frame_menubar):
2980 Use ptrdiff_t, not int, for consistency with rest of code.
2981 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
2982 (select_window, Fdelete_other_windows_internal)
2983 (window_scroll_pixel_based, window_scroll_line_based)
2984 (Frecenter, Fset_window_configuration):
2985 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2986 (Fset_window_hscroll, run_window_configuration_change_hook)
2987 (set_window_buffer, temp_output_buffer_show, scroll_command)
2988 (Fscroll_other_window, Frecenter):
2989 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2990 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
2991 Don't assume fixnum fits in int.
2992 (Fset_window_scroll_bars):
2993 Check that fixnums are in proper range for system types.
2994 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
2995 (string_pos, c_string_pos, number_of_chars, init_iterator)
2996 (in_ellipses_for_invisible_text_p, init_from_display_pos)
2997 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
2998 (compute_display_string_end, handle_face_prop)
2999 (face_before_or_after_it_pos, handle_invisible_prop)
3000 (handle_display_prop, handle_display_spec, handle_single_display_spec)
3001 (display_prop_intangible_p, string_buffer_position_lim)
3002 (string_buffer_position, handle_composition_prop, load_overlay_strings)
3003 (get_overlay_strings_1, get_overlay_strings)
3004 (iterate_out_of_display_property, forward_to_next_line_start)
3005 (back_to_previous_visible_line_start, reseat, reseat_to_string)
3006 (get_next_display_element, set_iterator_to_next)
3007 (get_visually_first_element, compute_stop_pos_backwards)
3008 (handle_stop_backwards, next_element_from_buffer)
3009 (move_it_in_display_line_to, move_it_in_display_line)
3010 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3011 (add_to_log, message_dolog, message_log_check_duplicate)
3012 (message2, message2_nolog, message3, message3_nolog
3013 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
3014 (current_message_1, truncate_echo_area, truncate_message_1)
3015 (set_message, set_message_1, store_mode_line_noprop)
3016 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
3017 (text_outside_line_unchanged_p, check_point_in_composition)
3018 (reconsider_clip_changes)
3019 (redisplay_internal, set_cursor_from_row, try_scrolling)
3020 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
3021 (redisplay_window, find_last_unchanged_at_beg_row)
3022 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
3023 (trailing_whitespace_p, find_row_edges, display_line)
3024 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
3025 (display_mode_element, store_mode_line_string)
3026 (pint2str, pint2hrstr, decode_mode_spec)
3027 (display_count_lines, display_string, draw_glyphs)
3028 (x_produce_glyphs, x_insert_glyphs)
3029 (rows_from_pos_range, mouse_face_from_buffer_pos)
3030 (fast_find_string_pos, mouse_face_from_string_pos)
3031 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3032 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3033 (safe_call, init_from_display_pos, handle_fontified_prop)
3034 (handle_single_display_spec, load_overlay_strings)
3035 (with_echo_area_buffer, setup_echo_area_for_printing)
3036 (display_echo_area, echo_area_display)
3037 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
3038 (update_tool_bar, hscroll_window_tree, redisplay_internal)
3039 (redisplay_window, dump_glyph_row, display_mode_line)
3040 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
3041 (handle_display_spec, display_prop_string_p):
3042 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3043 (handle_single_display_spec, build_desired_tool_bar_string)
3044 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
3045 (get_specified_cursor_type):
3046 Check that fixnums are in proper range for system types.
3047 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
3048 (Flookup_image_map):
3049 Don't assume fixnums fit in int.
3050 (compare_overlay_entries):
3051 Avoid mishandling comparisons due to subtraction overflow.
3052 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
3053 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
3054 (handle_tool_bar_click):
3055 Use int, not unsigned, since we prefer signed and the signedness
3056 doesn't matter here.
3057 (get_next_display_element, next_element_from_display_vector):
3058 Use int, not EMACS_INT, when int is wide enough.
3059 (start_hourglass): Use duration_to_sec_usec to do proper
3060 overflow checking on durations.
3061 * xfaces.c (Fbitmap_spec_p):
3062 Check that fixnums are in proper range for system types.
3063 (compare_fonts_by_sort_order):
3064 Avoid mishandling comparisons due to subtraction overflow.
3065 (Fx_family_fonts, realize_basic_faces):
3066 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3068 Don't assume fixnum fits in int.
3069 Use SAFE_ALLOCA_LISP, not alloca.
3070 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
3071 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
3072 (face_at_buffer_position, face_for_overlay_string)
3073 (face_at_string_position):
3074 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3075 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
3076 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
3078 Check that fixnums are in proper range for system types.
3079 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3080 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
3081 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3082 (Fx_change_window_property): Don't assume fixnums fit in int.
3083 * xfont.c (xfont_chars_supported):
3084 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3085 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
3086 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
3087 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3088 * xml.c (parse_region):
3089 * xrdb.c (magic_file_p):
3090 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3091 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
3092 (x_get_local_selection, x_reply_selection_request)
3093 (x_handle_selection_request, wait_for_property_change):
3094 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3095 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
3096 short is wide enough.
3097 (x_send_client_event): Don't assume fixnum fits in int.
3098 * xterm.c (x_x_to_emacs_modifiers):
3099 Don't assume EMACS_INT overflows nicely into int.
3100 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
3102 (handle_one_xevent): NATNUMP can eval its arg twice.
3103 (x_connection_closed):
3104 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3105 * xterm.h: Adjust decls to match defn changes elsewhere.
3106 (struct scroll_bar): Use struct vectorlike_header
3107 rather than rolling our own approximation.
3108 (SCROLL_BAR_VEC_SIZE): Remove; not used.
3110 2012-05-25 Glenn Morris <rgm@gnu.org>
3112 * lisp.mk (lisp): Update for more files being compiled now.
3114 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
3116 * lread.c: Remove `read_pure' which makes no difference.
3117 (read_pure): Remove var.
3118 (unreadpure): Remove function.
3119 (readevalloop): Don't call read_list with -1 flag.
3120 (read1, read_vector): Don't test read_pure any more.
3121 (read_list): Simplify.
3123 * fileio.c, character.h: Minor style tweaks.
3125 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
3127 * window.h (clip_changed): Remove useless declaration.
3129 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
3131 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
3132 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
3134 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
3137 This directory predates autoconf and is no longer needed nowadays.
3138 Move its few remaining bits of functionality to where they're needed.
3139 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
3140 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
3141 * m/template.h: Remove.
3142 * Makefile.in (M_FILE): Remove. All uses removed.
3143 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
3144 * lisp.h (USE_LSB_TAG):
3145 * mem-limits.h (EXCEEDS_LISP_PTR):
3146 Use VAL_MAX, not VALBITS, in #if.
3147 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
3148 (EMACS_UINT): Define unconditionally now.
3149 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
3150 (BITS_PER_EMACS_INT): New constants, replacing
3151 what used to be in config.h, but not useful in #if.
3152 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
3153 define them any more.
3154 (VAL_MAX): New macro.
3156 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
3157 BITS_PER_EMACS_INT, in #if.
3158 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
3159 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
3160 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
3161 * s/ms-w32.h (DATA_START):
3162 Move here from removed file m/intel386.h.
3163 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
3164 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
3166 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
3168 Assume C89 or later.
3169 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
3170 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
3172 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
3173 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
3174 * textprop.c, tparam.c (NULL): Remove.
3175 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
3176 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
3177 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
3178 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
3179 * xterm.c (input_signal_count): Assume volatile works.
3181 2012-05-21 Ken Brown <kbrown@cornell.edu>
3183 * xgselect.c (xg_select): Fix first argument in call to 'select'
3186 2012-05-20 Ken Brown <kbrown@cornell.edu>
3188 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
3189 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
3191 2012-05-19 Ken Brown <kbrown@cornell.edu>
3193 * xfns.c (x_in_use): Remove `static' qualifier.
3194 * xterm.h (x_in_use): Declare.
3195 * xgselect.c: Include xterm.h.
3196 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
3197 and `display_arg' (bug#9754).
3199 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
3201 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
3203 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
3204 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
3206 2012-05-18 Eli Zaretskii <eliz@gnu.org>
3208 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
3210 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
3211 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
3213 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
3214 reference to image_cache->refcount.
3215 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
3217 2012-05-17 Juri Linkov <juri@jurta.org>
3219 * search.c (Fword_search_regexp, Fword_search_backward)
3220 (Fword_search_forward, Fword_search_backward_lax)
3221 (Fword_search_forward_lax): Move functions to isearch.el
3222 (bug#10145, bug#11381).
3224 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
3226 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
3228 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
3230 * lread.c (init_obarray): Declare Qt and Qnil as special.
3232 2012-05-14 Glenn Morris <rgm@gnu.org>
3234 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
3235 Put "libexec" before "bin", for the sake of init_callproc_1.
3237 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
3239 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
3241 * unexaix.c: Port to more-recent AIX compilers.
3242 (report_error, report_error_1, make_hdr, copy_sym)
3243 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
3244 Make arguments const char *, not char *, to avoid violations of C
3245 standard and to fix some AIX warnings reported by Gilles Pion.
3247 2012-05-14 Eli Zaretskii <eliz@gnu.org>
3249 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
3250 already have overlays loaded.
3251 (handle_single_display_spec): Before returning without displaying
3252 fringe bitmap, synchronize the bidi iterator with the main display
3253 iterator, by calling iterate_out_of_display_property.
3254 (iterate_out_of_display_property): Detect buffer iteration by
3255 testing that it->string is a Lisp string.
3256 (get_next_display_element): When the current object is exhausted,
3257 and there's something on it->stack, call set_iterator_to_next to
3258 proceed with what's on the stack, instead of returning zero.
3259 (set_iterator_to_next): If called at the end of a Lisp string,
3260 proceed to consider_string_end without incrementing string
3261 position. Don't increment display vector index past the end of
3262 the display vector. (Bug#11417)
3263 (pos_visible_p): Don't report a position visible when move_it_to
3264 stopped at the last line of window, which happens to be scanned
3265 backwards by the bidi iteration. (Bug#11464)
3267 2012-05-14 Eli Zaretskii <eliz@gnu.org>
3269 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
3270 and right-margin display specs even if the spec is invalid or we
3271 are on a TTY, and thus unable to display on the fringes.
3272 That's because the text with the property will not be displayed anyway,
3273 so we need to signal to the caller that this is a "replacing"
3274 display spec. This fixes display when the spec is invalid or we
3277 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
3279 * unexaix.c (make_hdr): Fix typo in prototype.
3280 This bug broke the build on AIX. Problem reported by Gilles Pion.
3282 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
3284 * keyboard.c (kbd_buffer_get_event): Read special events also in
3285 batch mode. (Bug#11415)
3287 2012-05-12 Glenn Morris <rgm@gnu.org>
3289 * ns.mk: Update for ns_appbindir no longer having trailing "/".
3291 2012-05-12 Eli Zaretskii <eliz@gnu.org>
3293 * lisp.mk (lisp): Add newcomment.elc.
3295 2012-05-12 Glenn Morris <rgm@gnu.org>
3297 * Makefile.in (MKDIR_P): New, set by configure.
3298 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
3300 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
3302 Remove unused function hourglass_started.
3303 * dispextern.h (hourglass_started):
3304 * w32fns.c (hourglass_started):
3305 * xdisp.c (hourglass_started): Remove.
3307 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
3309 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
3310 Update dependencies.
3312 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
3314 * xgselect.c (xg_select): Put maxfds+1 into a var.
3315 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
3317 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
3319 2012-05-10 Dave Abrahams <dave@boostpro.com>
3321 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
3322 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
3324 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
3326 * dbusbind.c (xd_registered_buses): New internal Lisp object.
3327 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
3328 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
3329 Initialize xd_registered_buses.
3331 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
3333 Untag more efficiently if USE_LSB_TAG.
3334 This is based on a proposal by YAMAMOTO Mitsuharu in
3335 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
3336 For an admittedly artificial (nth 8000 longlist) benchmark on
3337 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
3338 Emacs's overall text size by 1%.
3339 * lisp.h (XUNTAG): New macro.
3340 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
3341 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
3342 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
3343 * eval.c (Fautoload):
3344 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
3345 * frame.h (XFRAME): Use XUNTAG.
3347 Port recent dbusbind.c changes to 32-bit --with-wide-int.
3348 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
3349 Remove unportable assumptions about print widths of types like
3351 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
3352 intptr_t when converting between pointer and integer, to avoid GCC
3353 warnings about wrong width.
3355 2012-05-09 Eli Zaretskii <eliz@gnu.org>
3357 * w32proc.c (new_child): Force Windows to reserve only 64KB of
3358 stack for each reader_thread, instead of defaulting to 8MB
3359 determined by the linker. This avoids failures in creating
3360 subprocesses on Windows 7, see the discussion in this thread:
3361 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
3363 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
3365 Fix up display of the *Minibuf-0* buffer in the mini window.
3366 * keyboard.c (read_char): Don't clear the echo area if there's no
3368 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
3369 contents of *Minibuf-0*) if there's no message displayed in its stead.
3371 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
3373 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
3376 2012-05-06 Chong Yidong <cyd@gnu.org>
3378 * lisp.mk (lisp): Update.
3380 2012-05-05 Jim Meyering <meyering@redhat.com>
3382 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
3384 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3386 * data.c (PUT_ERROR): New macro.
3387 (syms_of_data): Use it. Add new error type `user-error'.
3388 * undo.c (user_error): New function.
3389 (Fprimitive_undo): Use it.
3390 * print.c (print_error_message): Adjust print style for `user-error'.
3391 * keyboard.c (user_error): New function.
3392 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
3394 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
3396 Do not limit current-time-string to years 1000..9999.
3397 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
3398 (Fcurrent_time_string): Support any year that is supported by the
3399 underlying localtime representation. Don't use asctime, as it
3400 has undefined behavior for years outside the range -999..9999.
3402 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
3404 Fix race conditions involving setenv, gmtime, localtime, asctime.
3405 Without this fix, interrupts could mess up code that uses these
3406 nonreentrant functions, since setting TZ invalidates existing
3407 tm_zone or tzname values, and since most of these functions return
3408 pointers to static storage.
3409 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
3410 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
3411 Grow the critical sections to include not just invoking
3412 localtime/gmtime, but also accessing these functions' results
3413 including their tm_zone values if any, and any related TZ setting.
3414 (format_time_string): Last arg is now struct tm *, not struct tm **,
3415 so that the struct tm is saved in the critical section.
3416 All callers changed. Simplify allocation of initial buffer, partly
3417 motivated by the fact that memory allocation needs to be outside
3418 the critical section.
3420 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
3422 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
3423 with RESET_INTERVAL.
3425 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3426 Remove duplicated buffer name initialization.
3428 2012-05-02 Jim Meyering <jim@meyering.net>
3430 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
3432 * xfns.c (x_window): Use xstrdup (Bug#11375).
3434 2012-05-02 Eli Zaretskii <eliz@gnu.org>
3436 * xdisp.c (pos_visible_p): If already at a newline from the
3437 display string before the 'while' loop, don't walk back the glyphs
3438 from it3.glyph_row. Solves assertion violation when the display
3439 string begins with a newline (egg.el). (Bug#11367)
3441 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
3443 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
3446 2012-05-01 Glenn Morris <rgm@gnu.org>
3448 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
3449 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
3450 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
3451 All were removed before 23.1.
3453 * dispnew.c: Remove HAVE_LIBNCURSES test;
3454 it is always true on relevant platforms.
3456 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
3457 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
3459 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
3461 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
3463 * .gdbinit (xpr): Remove checks for no longer existing misc types.
3464 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
3467 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
3469 Do not avoid creating empty evaporating overlays (Bug#9642).
3470 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
3471 That is, do not delete an evaporating overlay if it becomes
3472 empty after its bounds are adjusted to fit within its buffer.
3473 This fix caused other problems, and I'm reverting it until we get
3474 to the bottom of them.
3476 2012-04-27 Chong Yidong <cyd@gnu.org>
3478 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
3480 2012-04-27 Eli Zaretskii <eliz@gnu.org>
3482 * xdisp.c (pos_visible_p): If the window start position is beyond
3483 ZV, start the display from buffer beginning. Prevents assertion
3484 violation in init_iterator when the minibuffer window is scrolled
3487 * window.c (window_scroll_pixel_based): Likewise.
3489 2012-04-27 Chong Yidong <cyd@gnu.org>
3491 * keymap.c (where_is_internal): Doc fix (Bug#10872).
3493 2012-04-27 Glenn Morris <rgm@gnu.org>
3495 * fileio.c (Fcopy_file, Fset_file_selinux_context):
3496 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
3498 2012-04-27 Eli Zaretskii <eliz@gnu.org>
3500 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
3501 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
3503 2012-04-26 Eli Zaretskii <eliz@gnu.org>
3505 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
3506 display element, check also the underlying string or buffer
3507 character. (Bug#11341)
3509 * w32menu.c: Include w32heap.h.
3510 (add_menu_item): If the call to AppendMenuW (via
3511 unicode_append_menu) fails, disable Unicode menus only if we are
3512 running on Windows 9X/Me.
3514 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
3516 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
3517 (xgetint): Add missing shift for LSB tags.
3519 2012-04-24 Martin Rudalics <rudalics@gmx.at>
3521 * keyboard.c (read_char): Don't wipe echo area for select window
3522 events: These might get delayed via `mouse-autoselect-window'
3525 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
3527 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
3528 manipulation of :loaded-from data.
3530 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
3532 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
3533 now a cons (bug#11311).
3535 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
3537 Do not create empty overlays with the evaporate property (Bug#9642).
3538 * buffer.c (Fmove_overlay): Delete an evaporating overlay
3539 if it becomes empty after its bounds are adjusted to fit within
3540 its buffer. Without this fix, in a nonempty buffer (let ((o
3541 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
3542 yields an empty overlay that has the evaporate property, which is
3543 not supposed to happen.
3545 Fix minor GTK3 problems found by static checking.
3546 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3547 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3548 (struct _EmacsFixedClass, emacs_fixed_get_type):
3549 Move decls here from emacsgtkfixed.h, since they needn't be public.
3550 (emacs_fixed_get_type): Now static.
3551 (emacs_fixed_class_init): Omit unused local.
3552 (emacs_fixed_child_type): Remove; unused.
3553 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3554 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3555 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
3556 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
3557 (EMACS_FIXED_GET_CLASS): Remove; unused.
3558 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
3560 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
3561 Problem reported by Juanma Barranquero for Windows -Wunused-function.
3563 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3565 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
3566 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
3567 (__malloc_size_t, __malloc_ptrdiff_t):
3568 Remove. All uses removed, replaced by the definiens if needed,
3569 since we can assume C89 or better now.
3570 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
3571 (protect_malloc_state, align, get_contiguous_space)
3572 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
3573 (malloc_atfork_handler_child, malloc_enable_thread)
3574 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
3575 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
3576 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
3577 (special_realloc, _realloc_internal_nolock, _realloc_internal)
3578 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
3579 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
3580 Define using prototypes, not old style.
3581 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
3582 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
3583 (align): Don't assume that signed integer overflow wraps around.
3584 Omit unused local var.
3585 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
3586 (_free_internal_nolock, memalign, mallochook, reallochook):
3587 Omit no-longer-needed casts.
3588 (valloc): Use getpagesize, not __getpagesize.
3589 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
3590 (struct hdr): The 'magic' member is now size_t, not unsigned long.
3592 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
3594 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
3596 Move functions from C to Lisp. Make non-blocking method calls
3597 the default. Implement further D-Bus standard interfaces.
3599 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
3600 (QCdbus_request_name_allow_replacement)
3601 (QCdbus_request_name_replace_existing)
3602 (QCdbus_request_name_do_not_queue)
3603 (QCdbus_request_name_reply_primary_owner)
3604 (QCdbus_request_name_reply_in_queue)
3605 (QCdbus_request_name_reply_exists)
3606 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
3607 (QCdbus_registered_serial, QCdbus_registered_method)
3608 (QCdbus_registered_signal): New Lisp objects.
3609 (XD_DEBUG_MESSAGE): Use sizeof.
3610 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
3611 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
3612 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
3613 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
3614 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
3615 (xd_signature, xd_append_arg): Allow float for integer types.
3616 (xd_get_connection_references): New function.
3617 (xd_get_connection_address): Rename from xd_initialize.
3618 Return cached address.
3619 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
3620 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
3622 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
3623 Return number of refcounts.
3624 (Fdbus_get_unique_name): Make stronger parameter check.
3625 (Fdbus_message_internal): New defun.
3626 (Fdbus_call_method, Fdbus_call_method_asynchronously)
3627 (Fdbus_method_return_internal, Fdbus_method_error_internal)
3628 (Fdbus_send_signal, Fdbus_register_service)
3629 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
3630 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
3631 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
3632 (Vdbus_compiled_version, Vdbus_runtime_version)
3633 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
3634 (Vdbus_message_type_method_return, Vdbus_message_type_error)
3635 (Vdbus_message_type_signal): New defvars.
3636 (Vdbus_registered_buses, Vdbus_registered_objects_table):
3639 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3641 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
3642 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
3643 Do not assume ptrdiff_t is the same width as 'int'.
3645 * alloc.c: Handle unusual debugging option combinations.
3646 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
3647 since the two debugging options are incompatible.
3648 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
3650 (mem_init, mem_insert, mem_insert_fixup):
3651 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
3652 (NEED_MEM_INSERT): Remove; no longer needed.
3654 2012-04-22 Leo Liu <sdl.web@gmail.com>
3656 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
3658 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3660 * sysdep.c [__FreeBSD__]: Minor cleanups.
3661 (list_system_processes, system_process_attributes) [__FreeBSD__]:
3662 Use Emacs indenting style more consistently. Avoid some casts.
3663 Use 'double' consistently rather than mixing 'float' and 'double'.
3665 2012-04-21 Eduard Wiebe <usenet@pusto.de>
3667 * sysdep.c (list_system_processes, system_process_attributes):
3668 Add implementation for FreeBSD (Bug#5243).
3670 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
3672 * lisp.mk (lisp): Update.
3674 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
3676 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
3677 It is never used otherwise.
3679 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
3681 * print.c (print_preprocess): Only check print_depth if print-circle
3683 (print_object): Check for cycles even when print-circle is nil and
3684 print-gensym is t, but only check print_depth if print-circle is nil.
3686 2012-04-20 Chong Yidong <cyd@gnu.org>
3688 * process.c (wait_reading_process_output): If EIO occurs on a pty,
3689 set the status to "failed" and ensure that sentinel is run.
3691 2012-04-20 Glenn Morris <rgm@gnu.org>
3693 * process.c (Fset_process_inherit_coding_system_flag)
3694 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
3695 (Fmake_network_process, Fmake_serial_process): Doc fix.
3697 2012-04-20 Eli Zaretskii <eliz@gnu.org>
3699 * xdisp.c (string_buffer_position_lim): Limit starting position to
3701 (set_cursor_from_row): If called for a mode-line or header-line
3702 row, return zero immediately.
3703 (try_cursor_movement): If inside continuation line, don't back up
3704 farther than the first row after the header line, if any.
3705 Don't consider the header-line row as "partially visible", even if
3706 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
3708 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
3710 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
3713 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
3714 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
3716 configure: new option --enable-gcc-warnings (Bug#11207)
3717 * Makefile.in (C_WARNINGS_SWITCH): Remove.
3718 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
3719 (ALL_CFLAGS): Use new macros rather than old.
3720 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
3721 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
3722 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
3723 -Wunused-result, -Wunused-variable. This should go away once
3724 the Emacs and Gnulib regex code is merged.
3725 (xmalloc, xrealloc): Now static.
3727 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
3729 * dired.c (Fsystem_groups): Remove unused local.
3731 2012-04-17 Glenn Morris <rgm@gnu.org>
3733 * dired.c (Fsystem_users): Doc fix.
3735 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
3737 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
3738 (syms_of_dired): Add them.
3740 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
3742 Fix minor alloc.c problems found by static checking.
3743 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
3744 New extern decls, to avoid calling undeclared functions.
3745 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
3746 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
3747 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
3748 (NEED_MEM_INSERT): New macro.
3749 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
3750 Remove one incorrect comment and fix another.
3752 Fix minor ralloc.c problems found by static checking.
3753 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3754 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
3755 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
3756 (r_alloc_sbrk): Now static.
3758 Improve ralloc.c interface checking.
3759 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3760 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
3761 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
3762 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
3763 [REL_ALLOC]: ... to here, to check interface.
3764 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
3765 Remove decls. This fixes an "It stinks!".
3767 * alloc.c (which_symbols): Fix alignment issue / type clash.
3769 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
3771 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
3772 (struct Lisp_Misc_Any): Likewise.
3773 (struct Lisp_Free): Likewise.
3774 * alloc.c (union aligned_Lisp_Symbol): Define.
3775 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
3776 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
3777 (union aligned_Lisp_Misc): Define.
3778 (MARKER_BLOCK_SIZE, struct marker_block): Use union
3779 aligned_Lisp_Misc instead of union Lisp_Misc.
3780 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
3782 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
3784 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
3785 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
3786 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
3787 * s/netbsd.h, s/sol2-6.h:
3788 Remove definition of GC_MARK_STACK, since the default now works.
3789 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
3790 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
3791 no longer the default.
3792 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
3794 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
3796 * lread.c (lisp_file_lexically_bound_p):
3797 Fix hang at ";-*-\n" (bug#11238).
3799 2012-04-14 Eli Zaretskii <eliz@gnu.org>
3801 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
3802 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
3804 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
3806 * nsterm.m (constrainFrameRect): Always constrain when there is only
3807 one screen (Bug#10962).
3809 2012-04-13 Ken Brown <kbrown@cornell.edu>
3811 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
3813 2012-04-13 Reuben Thomas <rrt@sc3d.org>
3815 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
3817 2012-04-11 Daniel Colascione <dancol@dancol.org>
3819 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
3820 against is gone. It's better to use vfork now so that when Cygwin
3821 gains a new, working vfork, we use it automatically (bug#10398).
3823 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3825 * window.c (save_window_save): Obey window-point-insertion-type.
3827 2012-04-11 Glenn Morris <rgm@gnu.org>
3829 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
3831 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3833 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
3835 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
3837 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
3838 (force_quit_count): New var.
3839 (handle_interrupt): Use it.
3841 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
3843 * w32.c (w32_delayed_load): Record the full path of the library
3844 being loaded (bug#10424).
3846 2012-04-09 Glenn Morris <rgm@gnu.org>
3848 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
3849 not just in the obarray, before snarfing them. (Bug#11036)
3851 * Makefile.in ($(leimdir)/leim-list.el):
3852 Pass EMACS rather than BUILT_EMACS.
3854 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
3856 * process.c (make_process):
3857 * process.h: Add integer `gnutls_handshakes_tried' member to
3860 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
3861 Add convenience `GNUTLS_LOG2i' macro.
3863 * gnutls.c (gnutls_log_function2i): Convenience log function.
3864 (emacs_gnutls_read): Use new log functions,
3865 `gnutls_handshakes_tried' process member, and
3866 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
3867 attempts per process (connection).
3869 2012-04-09 Chong Yidong <cyd@gnu.org>
3871 * eval.c (Fuser_variable_p, user_variable_p_eh)
3872 (lisp_indirect_variable): Functions deleted.
3873 (Fdefvar): Caller changed.
3875 * callint.c (Finteractive, Fcall_interactively):
3876 * minibuf.c (Fread_variable): Callers changed.
3878 2012-04-09 Eli Zaretskii <eliz@gnu.org>
3880 * xdisp.c (set_cursor_from_row): If the display string appears in
3881 the buffer at position that is closer to point than the position
3882 after the display string, display the cursor on the first glyph of
3883 the display string. Fixes cursor display when a 'display' text
3884 property immediately follows invisible text. (Bug#11094)
3886 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
3888 composite.c: use 'double' consistently
3889 * composite.c (get_composition_id): Use 'double' consistently
3890 instead of converting 'float' to 'double' and vice versa; this is
3891 easier to understand and avoids a GCC warning.
3893 2012-04-09 Glenn Morris <rgm@gnu.org>
3895 * Makefile.in: Generate leim-list with bootstrap-emacs, in
3896 preparation for dumping it with emacs. (Bug#4789)
3897 (leimdir): New variable.
3898 ($(leimdir)/leim-list.el): New rule.
3899 (emacs$(EXEEXT)): Depend on leim-list.el.
3901 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
3902 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
3903 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
3905 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
3907 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
3910 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
3912 * xml.c (init_libxml2_functions) [WINDOWSNT]:
3913 Remove unused local variable.
3915 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3917 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
3918 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
3919 (mark_memory): Mark Lisp_Objects only if pointers might hide in
3920 objects, as mark_maybe_pointer will catch them otherwise.
3921 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
3922 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
3924 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3926 Fix typo that broke non-Windows builds.
3927 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
3929 2012-04-07 Eli Zaretskii <eliz@gnu.org>
3931 Support building on MS-Windows with libxml2.
3933 * makefile.w32-in (OBJ2): Add xml.$(O).
3934 (GLOBAL_SOURCES): Add xml.c.
3935 ($(BLD)/xml.$(O)): New dependency list.
3937 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
3938 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
3939 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
3940 [!WINDOWSNT]: New macros.
3941 (init_libxml2_functions, libxml2_loaded_p): New functions.
3942 (parse_region): Call fn_xmlCheckVersion instead of using the macro
3943 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
3944 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
3945 Calls xmlCleanupParser only if libxml2 was loaded (or statically
3947 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
3948 Call init_libxml2_functions before calling libxml2 functions.
3949 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
3951 * emacs.c: Don't include libxml/parser.h.
3952 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
3953 xmlCleanupParser directly.
3955 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
3957 2012-04-07 Eli Zaretskii <eliz@gnu.org>
3959 * indent.c (Fvertical_motion): If there is a display string at
3960 point, use it.vpos to compute how many lines to backtrack after
3961 move_it_to point. (Bug#11133)
3963 2012-04-06 Eli Zaretskii <eliz@gnu.org>
3965 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
3966 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
3967 about subtle differences between FETCH_CHAR* and STRING_CHAR*
3968 macros related to unification of CJK characters. For the details,
3969 see the discussion following the message here:
3970 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
3972 2012-04-04 Chong Yidong <cyd@gnu.org>
3974 * keyboard.c (Vdelayed_warnings_list): Doc fix.
3976 2012-04-01 Eli Zaretskii <eliz@gnu.org>
3978 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
3979 instead of alloca. (Bug#11138)
3981 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
3983 * w32menu.c (is_simple_dialog): Properly check lisp types.
3986 2012-03-31 Eli Zaretskii <eliz@gnu.org>
3988 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
3989 position we get to after a call to move_it_to fails the
3990 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
3991 only if we wind up in a string from display property. (Bug#11063)
3993 * window.c (Fdelete_other_windows_internal): Invalidate the row
3994 and column information about mouse highlight, so that redisplay
3995 restores it after reallocating the glyph matrices. (Bug#7464)
3997 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
3998 string comes from a `display' text property, use the buffer
3999 position of that property as if we actually saw that position in
4001 (move_it_by_lines): Remove the assertion that
4002 "it->current_x == 0 && it->hpos == 0" which can be legitimately
4003 violated when there's a before-string at the beginning of a line.
4006 2012-03-30 Eli Zaretskii <eliz@gnu.org>
4008 * xdisp.c (append_space_for_newline): If the default face was
4009 remapped, use the remapped face for the appended newline.
4010 (extend_face_to_end_of_line): Use the remapped default face for
4011 extending the face to the end of the line.
4012 (display_line): Call extend_face_to_end_of_line when the default
4013 face was remapped. (Bug#11068)
4015 2012-03-29 Eli Zaretskii <eliz@gnu.org>
4017 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
4019 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4021 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
4023 2012-03-27 Glenn Morris <rgm@gnu.org>
4025 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
4028 2012-03-26 Kenichi Handa <handa@m17n.org>
4030 * dispextern.h (struct glyph): Fix previous change. Change the
4031 bit length of glyphless.ch to 25 (Bug#11082).
4033 2012-03-26 Chong Yidong <cyd@gnu.org>
4035 * keyboard.c (Vselection_inhibit_update_commands): New variable.
4036 (command_loop_1): Use it; inhibit selection update for
4037 handle-select-window too (Bug#8996).
4039 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
4041 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
4043 2012-03-25 Kenichi Handa <handa@m17n.org>
4045 * dispextern.h (struct glyph): Change the bit length of
4046 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
4048 2012-03-24 Eli Zaretskii <eliz@gnu.org>
4050 * s/ms-w32.h (tzname): Include time.h before redirecting to
4051 _tzname. Fixes the MSVC build. (Bug#9960)
4053 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
4055 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
4058 * xterm.c (XTread_socket): Only modify handling_signal if
4059 !SYNC_INPUT. (Bug#11080)
4061 2012-03-23 Eli Zaretskii <eliz@gnu.org>
4063 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
4064 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
4065 when fetching a multibyte character consumes more bytes than
4066 CHAR_BYTES returns, due to unification of CJK characters in
4067 string_char. (Bug#11073)
4069 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
4071 * process.c (wait_reading_process_output): Handle pty disconnect
4072 by refraining from sending oneself a SIGCHLD (bug#10933).
4074 2012-03-22 Chong Yidong <cyd@gnu.org>
4076 * dispextern.h (struct it): New member string_from_prefix_prop_p.
4078 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
4079 Mark string as coming from a prefix property.
4080 (handle_face_prop): Use default face for prefix strings (Bug#4281).
4081 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
4083 2012-03-21 Chong Yidong <cyd@gnu.org>
4085 * xfaces.c (Vface_remapping_alist): Doc fix.
4087 2012-03-20 Eli Zaretskii <eliz@gnu.org>
4089 * w32proc.c (Fw32_set_console_codepage)
4090 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
4093 2012-03-20 Chong Yidong <cyd@gnu.org>
4095 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
4096 to reflect default non-nil value of redisplay-dont-pause.
4098 2012-03-19 Kenichi Handa <handa@m17n.org>
4100 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
4101 it fit in a valid range (Bug#11003).
4103 2012-03-18 Eli Zaretskii <eliz@gnu.org>
4105 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
4106 that is not from display property, accept the row as a "cursor
4107 row" if one of the string's character has a non-nil `cursor'
4108 property. Fixes cursor positioning when there are newlines in
4109 overlay strings, e.g. in icomplete.el. (Bug#11035)
4111 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
4113 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
4115 2012-03-12 Chong Yidong <cyd@gnu.org>
4117 * eval.c (inhibit_lisp_code): Rename from
4118 inhibit_window_configuration_change_hook; move from window.c.
4120 * xfns.c (unwind_create_frame_1, Fx_create_frame):
4121 * window.c (run_window_configuration_change_hook)
4122 (syms_of_window): Callers changed.
4124 2012-03-11 Chong Yidong <cyd@gnu.org>
4126 * keymap.c (Fkey_description): Doc fix (Bug#9700).
4128 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
4130 2012-03-10 Chong Yidong <cyd@gnu.org>
4132 * frame.c (other_visible_frames): Don't assume the selected frame
4133 is visible (Bug#10955).
4135 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
4137 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
4139 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
4141 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
4142 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
4145 2012-03-03 Glenn Morris <rgm@gnu.org>
4147 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
4149 2012-03-02 Eli Zaretskii <eliz@gnu.org>
4151 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
4152 position past the first glyph_row that ends at ZV. (Bug#10902)
4153 (redisplay_window, next_element_from_string): Fix typos in
4155 (redisplay_window): Pass to move_it_vertically the margin in
4156 pixels, not in screen lines.
4158 2012-03-02 Glenn Morris <rgm@gnu.org>
4160 * buffer.c (buffer-list-update-hook): Doc fix.
4162 2012-02-29 Eli Zaretskii <eliz@gnu.org>
4164 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
4165 push_it before setting up the iterator for the first overlay
4166 string, even if we have an empty string loaded.
4167 (next_overlay_string): If there's an empty string on the iterator
4168 stack, pop the stack. (Bug#10903)
4170 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
4172 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
4173 Suggested by Stefan Monnier in
4174 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
4175 * alloc.c (widen_to_Lisp_Object): New static function.
4176 (mark_memory): Also mark Lisp_Objects by fetching pointer words
4177 and widening them to Lisp_Objects. This would work even if
4178 USE_LSB_TAG is defined and wide integers are used, which might
4179 happen in a future version of Emacs.
4181 2012-02-25 Chong Yidong <cyd@gnu.org>
4183 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
4186 * xselect.c (Fx_selection_exists_p): Doc fix.
4187 (x_clipboard_manager_save_all): Print an informative message
4188 before saving to clipboard manager.
4190 2012-02-24 Chong Yidong <cyd@gnu.org>
4192 * keyboard.c (process_special_events): Handle all X selection
4193 requests in kbd_buffer, not just the next one (Bug#8869).
4195 2012-02-23 Chong Yidong <cyd@gnu.org>
4197 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
4198 call when setting menu-bar-lines and tool-bar-lines parameters.
4199 (unwind_create_frame_1): New helper function.
4201 * window.c (inhibit_window_configuration_change_hook): New var.
4202 (run_window_configuration_change_hook): Obey it.
4203 (syms_of_window): Initialize it.
4205 2012-02-22 Chong Yidong <cyd@gnu.org>
4207 * xterm.c (x_draw_image_relief): Add missing type check for
4208 Vtool_bar_button_margin (Bug#10743).
4210 2012-02-21 Chong Yidong <cyd@gnu.org>
4212 * fileio.c (Vfile_name_handler_alist): Doc fix.
4214 * buffer.c (Fget_file_buffer): Protect against invalid file
4215 handler return value.
4217 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
4219 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
4220 when computing $valmask.
4222 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
4223 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
4224 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
4225 It's useless in that case, and it can cause problems on hosts
4226 that allocate halves of EMACS_INT values separately.
4227 Reported by Dan Horák. Diagnosed by Andreas Schwab in
4228 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
4229 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
4230 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
4231 it avoids undefined behavior on hosts where shifting right by more
4232 than the word width has undefined behavior.
4234 2012-02-19 Chong Yidong <cyd@gnu.org>
4236 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
4237 (Funhandled_file_name_directory, Ffile_name_as_directory)
4238 (Fdirectory_file_name, Fexpand_file_name)
4239 (Fsubstitute_in_file_name): Protect against invalid file handler
4240 return values (Bug#10845).
4242 2012-02-18 Eli Zaretskii <eliz@gnu.org>
4244 * .gdbinit (pitx): Fix incorrect references to fields of the
4247 2012-02-17 Chong Yidong <cyd@gnu.org>
4249 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
4251 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
4253 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
4254 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
4256 2012-02-15 Chong Yidong <cyd@gnu.org>
4258 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
4259 marked as special. Also, starting docstrings with * is obsolete.
4261 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
4263 * gnutls.c (emacs_gnutls_write): Fix last change.
4265 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
4267 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
4270 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
4272 * keymap.c (Fsingle_key_description): Handle char ranges.
4274 2012-02-12 Chong Yidong <cyd@gnu.org>
4276 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
4277 as that creates a dangerous corner case.
4279 * window.c (Fdelete_window_internal): Invalidate the mouse
4280 highlight (Bug#9904).
4282 2012-02-12 Glenn Morris <rgm@gnu.org>
4284 * xselect.c (Fx_own_selection_internal)
4285 (Fx_get_selection_internal, Fx_disown_selection_internal)
4286 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
4287 * nsselect.m (Fx_own_selection_internal)
4288 (Fx_disown_selection_internal, Fx_selection_exists_p)
4289 (Fx_selection_owner_p, Fx_get_selection_internal):
4290 Sync docs and argument specs with the xselect.c versions.
4292 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
4294 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
4296 2012-02-11 Eli Zaretskii <eliz@gnu.org>
4298 * w32select.c (Fx_selection_exists_p): Sync doc string and
4299 argument list with xselect.c. (Bug#10783)
4301 * w16select.c (Fx_selection_exists_p): Sync doc string and
4302 argument list with xselect.c. (Bug#10783)
4304 2012-02-10 Glenn Morris <rgm@gnu.org>
4306 * fns.c (Fsecure_hash): Doc fix.
4308 2012-02-09 Kenichi Handa <handa@m17n.org>
4310 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
4312 2012-02-07 Chong Yidong <cyd@gnu.org>
4314 * buffer.c (Fbuffer_local_variables)
4315 (buffer_lisp_local_variables): Handle unbound vars correctly;
4316 don't let Qunbound leak into Lisp.
4318 2012-02-07 Glenn Morris <rgm@gnu.org>
4320 * image.c (Fimagemagick_types): Doc fix.
4322 * image.c (imagemagick-render-type): Change it from a lisp object
4323 to an integer. Move the doc here from the lisp manual.
4324 Treat all values not equal to 0 the same.
4326 2012-02-06 Chong Yidong <cyd@gnu.org>
4328 * doc.c (store_function_docstring): Avoid applying docstring of
4329 alias to base function (Bug#2603).
4331 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
4333 * .gdbinit (pp1, pv1): Remove redundant defines.
4336 2012-02-04 Chong Yidong <cyd@gnu.org>
4338 * nsterm.m: Declare a global (Bug#10694).
4340 2012-02-04 Eli Zaretskii <eliz@gnu.org>
4342 * w32.c (get_emacs_configuration_options):
4343 Include --enable-checking, if specified, in the return value.
4345 2012-02-04 Martin Rudalics <rudalics@gmx.at>
4347 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
4348 after rounding frame sizes. (Bug#9723)
4350 2012-02-04 Eli Zaretskii <eliz@gnu.org>
4352 * keyboard.c (adjust_point_for_property): Don't position point
4353 before BEGV. (Bug#10696)
4355 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
4357 Handle overflow when computing char display width (Bug#9496).
4358 * character.c (char_width): Return EMACS_INT, not int.
4359 (char_width, c_string_width): Check for overflow when
4360 computing the width; this is possible now that individual
4361 characters can have unbounded width. Problem introduced
4362 by merge from Emacs 23 on 2012-01-19.
4364 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
4366 * dbusbind.c (Fdbus_register_method): Mention the return value
4367 :ignore in the docstring.
4369 2012-02-02 Glenn Morris <rgm@gnu.org>
4371 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
4373 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4374 Unconditionally set to t. (Bug#10673)
4375 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4376 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4377 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
4379 2012-02-02 Kenichi Handa <handa@m17n.org>
4381 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
4382 0, do not call append_composite_glyph.
4384 2012-02-02 Kenichi Handa <handa@m17n.org>
4386 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
4388 (x_produce_glyphs): If the component of a composition is a null
4389 string, set it->pixel_width to 1 to avoid zero-width glyph.
4391 2012-02-01 Eli Zaretskii <eliz@gnu.org>
4393 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
4394 first 2 arguments are identical. This makes inserting large
4395 output from a subprocess an order of magnitude faster on
4396 MS-Windows, where all sbrk'ed memory is always contiguous.
4398 2012-01-31 Glenn Morris <rgm@gnu.org>
4400 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4401 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4402 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
4404 2012-01-29 Glenn Morris <rgm@gnu.org>
4406 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
4408 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
4410 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
4412 2012-01-28 Chong Yidong <cyd@gnu.org>
4414 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
4416 2012-01-26 Chong Yidong <cyd@gnu.org>
4418 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
4420 * search.c (Fsearch_forward, Fsearch_backward): Document negative
4421 repeat counts (Bug#10507).
4423 2012-01-26 Glenn Morris <rgm@gnu.org>
4425 * lread.c (syms_of_lread): Doc fix.
4427 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
4429 * coding.c (encode_designation_at_bol): Change return value to
4432 2012-01-25 Chong Yidong <cyd@gnu.org>
4434 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
4436 2012-01-21 Chong Yidong <cyd@gnu.org>
4438 * floatfns.c (Fcopysign): Make the second argument non-optional,
4439 since nil is not allowed anyway.
4441 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
4443 * process.c (read_process_output): Use p instead of XPROCESS (proc).
4444 (send_process): Likewise.
4446 2012-01-19 Martin Rudalics <rudalics@gmx.at>
4448 * window.c (save_window_save, Fcurrent_window_configuration)
4449 (Vwindow_persistent_parameters): Do not use Qstate.
4450 Rewrite doc-strings.
4452 2012-01-19 Kenichi Handa <handa@m17n.org>
4454 * character.c (char_width): New function.
4455 (Fchar_width, c_string_width, lisp_string_width):
4456 Use char_width (Bug#9496).
4458 2012-01-16 Martin Rudalics <rudalics@gmx.at>
4460 * window.c (Vwindow_persistent_parameters): New variable.
4461 (Fset_window_configuration, save_window_save): Handle persistent
4464 2012-01-14 Eli Zaretskii <eliz@gnu.org>
4466 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
4467 thrashing the stack of the thread. (Bug#9087)
4469 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
4471 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
4473 2012-01-11 Eli Zaretskii <eliz@gnu.org>
4475 * xdisp.c (rows_from_pos_range): Handle the case where the
4476 highlight ends on a newline. (Bug#10464)
4477 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
4478 he end column for display of highlight that ends on a newline
4481 2012-01-11 Glenn Morris <rgm@gnu.org>
4483 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
4484 from load-path also when installation-directory is nil. (Bug#10208)
4486 2012-01-10 Glenn Morris <rgm@gnu.org>
4488 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
4490 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
4491 Update template values to be closer to their typical values these days.
4493 2012-01-09 Eli Zaretskii <eliz@gnu.org>
4495 * xdisp.c (rows_from_pos_range): Accept additional argument
4496 DISP_STRING, and accept any glyph in a row whose object is that
4497 string as eligible for mouse highlight. Fixes mouse highlight of
4498 display strings from overlays. (Bug#10464)
4500 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
4502 emacs: fix an auto-save permissions race condition (Bug#10400)
4503 * fileio.c (auto_saving_dir_umask): New static var.
4504 (Fmake_directory_internal): Use it.
4505 (do_auto_save_make_dir): Set it, instead of invoking chmod after
4506 creating the directory. The old code temporarily assigns
4507 too-generous permissions to the directory.
4508 (do_auto_save_eh): Clear it.
4509 (Fdo_auto_save): Catch all errors, not just file errors, so
4510 that the var is always cleared.
4512 2012-01-07 Eli Zaretskii <eliz@gnu.org>
4514 * search.c (scan_buffer): Pass character positions to
4515 know_region_cache, not byte positions. (Bug#6540)
4517 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
4519 * w32.c (sys_rename): Report EXDEV when rename of a directory
4520 fails because the target is on another logical disk. (Bug#10284)
4522 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
4524 * xterm.c (x_embed_request_focus): New function.
4526 * xterm.h: Add prototype.
4528 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
4530 2012-01-05 Glenn Morris <rgm@gnu.org>
4532 * emacs.c (emacs_copyright): Update short copyright year to 2012.
4534 2012-01-01 Eli Zaretskii <eliz@gnu.org>
4536 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
4537 Load gnutls_transport_set_lowat only if GnuTLS version is below
4539 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
4540 GnuTLS versions below 2.11.1.
4542 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
4544 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
4545 to the doc string advising against its use for altering the way
4546 windows are scrolled.
4548 2011-12-28 Kenichi Handa <handa@m17n.org>
4550 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
4551 coding-system ASCII compatible only when it does not produce BOM
4552 on encoding (Bug#10383).
4554 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
4556 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
4558 (create_and_show_popup_menu): Always use menu_position_func for
4561 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
4563 * callint.c (Fcall_interactively): Don't truncate prompt string.
4565 2011-12-23 Eli Zaretskii <eliz@gnu.org>
4567 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
4568 property that ends at ZV, so that the bidi iteration could be
4569 resumed from there (after widening). (Bug#10360)
4571 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
4573 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
4575 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
4577 * nsterm.m (x_free_frame_resources):
4578 Release f->output_data.ns->miniimage.
4579 (ns_index_color): Fix indentation. Do not retain
4580 color_table->colors[i].
4582 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
4585 * nsfns.m (x_set_background_color): Assign return value from
4586 ns_index_color to face-background instead of NSColor*.
4587 (ns_implicitly_set_icon_type): Fix indentation.
4588 Change assignment in for loop to comparison.
4590 * emacs.c (ns_pool): New variable.
4591 (main): Assign ns_pool.
4592 (Fkill_emacs): Call ns_release_autorelease_pool.
4594 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
4595 autorelease fdesc, release fdAttrs and tdict.
4596 (ns_get_covering_families): Release charset.
4597 (ns_findfonts): Release NSFontDescriptor created with new.
4598 (ns_uni_to_glyphs): Fix indentation.
4599 (setString): Release attrStr before assigning new value.
4601 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4603 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
4605 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
4606 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
4608 2011-12-18 David Reitter <reitter@cmu.edu>
4610 * nsterm.m (ns_term_init): Subscribe for notifications
4611 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
4612 to method trackingNotification in EmacsMenu.
4614 * nsmenu.m (trackingMenu): New variable.
4615 (trackingNotification): New method (from Aquamacs).
4616 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
4617 from Aquamacs (Bug#7030).
4619 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4621 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
4622 (symbol_to_nsstring): Fix indentation.
4623 (ns_symbol_to_pb): New function.
4624 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
4625 (Fns_rotate_cut_buffers_internal): Remove.
4626 (Fns_store_selection_internal): Rename from
4627 Fns_store_cut_buffer_internal.
4628 (ns_get_foreign_selection, Fx_own_selection_internal)
4629 (Fx_disown_selection_internal, Fx_selection_exists_p)
4630 (Fns_get_selection_internal, Fns_store_selection_internal):
4631 Use ns_symbol_to_pb and check if return value is nil.
4632 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
4633 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
4634 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
4635 renamed to Sns_store_selection_internal.
4636 (ns_handle_selection_request): Move code to Fx_own_selection_internal
4637 and remove this function.
4638 (ns_handle_selection_clear): Remove, never used.
4639 (Fx_own_selection_internal): Move code from ns_handle_selection_request
4642 2011-12-17 Ken Brown <kbrown@cornell.edu>
4644 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
4645 GID is unknown (Bug#10257).
4647 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
4649 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
4650 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
4651 which caused a build failure on GNU/Linux IA-64. This problem was
4652 introduced by my 2011-10-07 patch.
4654 2011-12-15 Juri Linkov <juri@jurta.org>
4656 * image.c (imagemagick_error): New function. (Bug#10112)
4657 (imagemagick_load_image): Comment out `MagickSetResolution' call.
4658 Use `imagemagick_error' where ImageMagick functions return
4660 (Fimagemagick_types): Add `Fnreverse' to return the list in the
4663 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4665 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
4666 fill background (Bug#8992).
4668 2011-12-13 Martin Rudalics <rudalics@gmx.at>
4670 * window.c (Vwindow_combination_resize)
4671 (Vwindow_combination_limit): Use t instead of non-nil in
4673 (Vrecenter_redisplay): Add first sentence of doc-string on
4675 (Frecenter): Fix doc-string typo.
4677 2011-12-11 Kenichi Handa <handa@m17n.org>
4679 * coding.c (Funencodable_char_position): Pay attention to the
4680 buffer text relocation (Bug#9389).
4682 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4684 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
4685 gtk_init (Bug#10100).
4687 2011-12-10 Eli Zaretskii <eliz@gnu.org>
4689 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
4690 IT->string is nil. (Bug#10263)
4692 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4694 * nsterm.h (x_free_frame_resources): Declare.
4696 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
4697 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
4699 * nsterm.h (ns_get_defaults_value): Declare.
4701 * nsterm.m (ns_default): Call ns_get_defaults_value.
4703 2011-12-09 Eli Zaretskii <eliz@gnu.org>
4705 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
4708 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4710 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
4711 that where the value of an _OBJC_* symbol points to is in the .bss
4712 section (Bug#10240).
4714 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4716 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
4717 after the loop to call ccl_driver at least once (Bug#8619).
4719 2011-12-08 Kenichi Handa <handa@m17n.org>
4721 * ftfont.c (get_adstyle_property): Fix previous change
4724 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
4726 * w32.c (init_environment): If no_site_lisp, remove site-lisp
4727 dirs from the default value of EMACSLOADPATH (bug#10208).
4729 2011-12-07 Glenn Morris <rgm@gnu.org>
4731 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
4732 installation and source directories as well. (Bug#10208)
4734 2011-12-06 Chong Yidong <cyd@gnu.org>
4736 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
4738 2011-12-06 Glenn Morris <rgm@gnu.org>
4740 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
4741 as an error, not just -1. (Bug#10217)
4743 2011-12-05 Chong Yidong <cyd@gnu.org>
4745 * keyboard.c (process_special_events): New function.
4746 (swallow_events, Finput_pending_p): Use it (Bug#10195).
4748 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
4750 * coding.c (encode_designation_at_bol): Don't use uninitialized
4751 local variable (Bug#9318).
4753 2011-12-05 Kenichi Handa <handa@m17n.org>
4755 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
4756 return Qnil (Bug#8046, Bug#10193).
4758 2011-12-05 Kenichi Handa <handa@m17n.org>
4760 * coding.c (encode_designation_at_bol): New args charbuf_end and
4761 dst. Return the number of produced bytes. Callers changed.
4762 (coding_set_source): Return how many bytes coding->source was
4764 (coding_set_destination): Return how many bytes
4765 coding->destination was relocated.
4766 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
4767 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
4769 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4771 * coding.c (CODING_CHAR_CHARSET_P): New macro.
4772 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
4775 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
4777 The following changes are to fix Bug#9318.
4779 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
4780 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
4781 (encode_coding_iso_2022, encode_coding_sjis)
4782 (encode_coding_big5, encode_coding_charset): Use the above macros.
4784 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
4786 * lisp.h (process_quit_flag): Fix external declaration.
4788 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
4790 Don't macro-inline non-performance-critical code.
4791 * eval.c (process_quit_flag): New function.
4792 * lisp.h (QUIT): Use it.
4794 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
4796 * nsfns.m (get_geometry_from_preferences): New function.
4797 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
4799 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
4801 * emacs.c (Qkill_emacs): Define.
4802 (syms_of_emacs): Initialize it.
4803 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
4804 Qquit_flag to `kill-emacs' instead.
4805 (quit_throw_to_read_char): Add parameter `from_signal'.
4806 All callers changed. Call Fkill_emacs if requested and safe.
4807 * lisp.h (QUIT): Call Fkill_emacs if requested.
4809 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
4811 * widget.c (update_wm_hints): Return if wmshell is null.
4812 (widget_update_wm_size_hints): New function.
4814 * widget.h (widget_update_wm_size_hints): Declare.
4816 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
4817 widget_update_wm_size_hints (Bug#10104).
4819 2011-12-03 Eli Zaretskii <eliz@gnu.org>
4821 * xdisp.c (handle_invisible_prop): If the invisible text ends just
4822 before a newline, prepare the bidi iterator for consuming the
4823 newline, and keep the current paragraph direction. (Bug#10183)
4824 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
4826 2011-12-02 Juri Linkov <juri@jurta.org>
4828 * search.c (Fword_search_regexp): New Lisp function created from
4829 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
4830 (Fword_search_backward, Fword_search_forward)
4831 (Fword_search_backward_lax, Fword_search_forward_lax):
4832 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
4833 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
4835 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
4837 * fileio.c (Finsert_file_contents): Move after-change-function call
4838 to before the "handled:" label, since all "goto handled" appear in
4839 cases where the *-change-functions have already been properly called
4842 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
4844 * keyboard.c (interrupt_signal): Don't call kill-emacs when
4845 waiting for input. (Bug#10169)
4847 2011-11-30 Eli Zaretskii <eliz@gnu.org>
4849 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
4850 verifies glyph row's hash code--we have just reallocated the
4851 glyphs, so their contents can be complete garbage. (Bug#10164)
4853 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
4855 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
4857 2011-11-30 Eli Zaretskii <eliz@gnu.org>
4859 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
4860 attributes are tested _before_ calling verify_row_hash, to protect
4861 against GCC re-ordering of the tests. (Bug#10164)
4863 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
4865 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
4867 * xterm.c (handle_one_xevent): Only set async_visible and friends
4868 if net_wm_state_hidden_seen is non-zero (Bug#10002)
4869 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
4870 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
4872 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
4874 Remove GCPRO-related macros that exist only to avoid shadowing locals.
4875 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
4876 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
4877 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4878 All uses changed to use GCPRO1 etc.
4879 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
4880 Revert to old implementation (i.e., before 2011-03-11).
4882 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4884 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
4885 of scroll runs so as to avoid assigning disabled bogus rows and
4886 unnecessary graphics copy operations.
4888 2011-11-27 Eli Zaretskii <eliz@gnu.org>
4890 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
4891 (snprintf) [_MSC_VER]: Redirect to _snprintf.
4892 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
4893 (malloc, free, realloc, calloc): Redirect to e_* only when
4896 * lisp.h (GCTYPEBITS): Move before first use.
4897 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
4898 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
4899 this macro definition.
4901 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
4904 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
4906 * gtkutil.c (xg_create_frame_widgets):
4907 Call gtk_window_set_has_resize_grip (FALSE) if that function is
4908 present with Gtk+ 2.0.
4910 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4912 * fileio.c (Finsert_file_contents): Undo previous change; see
4913 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4915 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4917 Rename locals to avoid shadowing.
4918 * fileio.c (Finsert_file_contents):
4919 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
4920 * process.c (wait_reading_process_output):
4921 Rename inner 'proc' to 'p' to avoid shadowing.
4922 Indent for consistency with usual Emacs style.
4924 2011-11-25 Eli Zaretskii <eliz@gnu.org>
4926 * xdisp.c (redisplay_window): If cursor row is not fully visible
4927 after recentering, and scroll-conservatively is set to a large
4928 number, scroll window by a few more lines to make the cursor fully
4929 visible and out of scroll-margin. (Bug#10105)
4930 (start_display): Don't move to the next line if the display should
4931 start at a newline that is part of a display vector or an overlay
4934 2011-11-24 Juri Linkov <juri@jurta.org>
4936 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
4937 after the `MagickPingImage' call. (Bug#10112)
4939 2011-11-23 Chong Yidong <cyd@gnu.org>
4941 * window.c (Fcoordinates_in_window_p): Accept only live windows.
4943 2011-11-23 Martin Rudalics <rudalics@gmx.at>
4945 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
4946 making another buffer current. (Bug#10114)
4948 2011-11-23 Glenn Morris <rgm@gnu.org>
4950 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
4952 2011-11-23 Chong Yidong <cyd@gnu.org>
4954 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
4955 using it (Bug#5984).
4957 2011-11-22 Eli Zaretskii <eliz@gnu.org>
4959 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
4960 and header-lines, as they don't have one computed for them.
4963 * .gdbinit (prow): Make displayed values more self-explaining.
4964 Add row's hash code.
4966 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
4968 * process.c (wait_reading_process_output): Fix asynchrounous
4969 GnuTLS socket handling on some versions of the GnuTLS library.
4970 (wait_reading_process_output): Add comment and URL.
4972 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
4974 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
4976 2011-11-21 Chong Yidong <cyd@gnu.org>
4978 * window.c (Fnext_window, Fprevious_window): Doc fix.
4980 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4982 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
4984 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
4986 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
4988 2011-11-20 Martin Rudalics <rudalics@gmx.at>
4990 * window.c (Fset_window_combination_limit): Rename argument
4992 (Vwindow_combination_limit): Remove "status" from doc-string.
4994 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
4996 * m/ibms390.h: Remove.
4997 * m/ibms390x.h: Don't include "ibms390.h".
4999 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5001 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
5002 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
5004 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
5006 * casetab.c (Fset_case_table):
5007 * charset.c (Fcharset_after): Fix typos.
5009 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
5011 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
5012 Otherwise, valgrind does not work on some platforms.
5013 Problem reported by Andreas Schwab in
5014 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
5015 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
5016 is set, removing the need for VIRT_ADDRESS_VARIES.
5017 (PURE_P): Use a more-efficient implementation that needs just one
5018 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
5019 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
5020 to 4 (xorl, subq, cmpq, setbe).
5021 * alloc.c (pure): Always extern now, since that's the
5022 VIRT_ADDR_VARIES behavior.
5023 (PURE_POINTER_P): Use a single comparison, not two, for
5024 consistency with the new puresize.h.
5025 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
5026 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
5027 Remove VIRT_ADDR_VARIES no longer needed.
5029 2011-11-19 Eli Zaretskii <eliz@gnu.org>
5031 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
5032 (erase_phys_cursor, update_window_cursor, show_mouse_face)
5033 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
5034 behave as if the cursor position were at the window margin.
5036 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
5037 and the cursor position is out of bounds, behave as if the cursor
5038 position were at the window margin. (Bug#10075)
5040 2011-11-18 Chong Yidong <cyd@gnu.org>
5042 * window.c (Fwindow_combination_limit): Make first argument
5043 non-optional, since it is meaningless for live windows like the
5046 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
5048 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
5050 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
5052 * intervals.c: Fix grafting over the whole buffer (bug#10071).
5053 (graft_intervals_into_buffer): Simplify.
5055 2011-11-18 Eli Zaretskii <eliz@gnu.org>
5057 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
5058 hash values of the two rows.
5059 (copy_row_except_pointers): Preserve the used[] arrays and the
5060 hash values of the two rows. (Bug#10035)
5061 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
5063 * xdisp.c (row_hash): New function, body extracted from
5064 compute_line_metrics.
5065 (compute_line_metrics): Call row_hash, instead of computing the
5068 * dispnew.c (verify_row_hash): Call row_hash for computing the
5069 hash code of a row, instead of duplicating code from xdisp.c.
5071 * dispextern.h (row_hash): Add prototype.
5073 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
5075 * frame.c (delete_frame): Don't delete the terminal when the last
5076 X frame is closed if emacs is built with GTK toolkit.
5078 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
5080 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
5082 2011-11-17 Martin Rudalics <rudalics@gmx.at>
5084 * window.c (Vwindow_splits): Rename to
5085 Vwindow_combination_resize. Suggested by Juri Linkov.
5086 (Fsplit_window_internal): Use Vwindow_combination_resize instead
5089 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
5091 * nsfns.m (Fns_font_name):
5092 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
5094 2011-11-16 Martin Rudalics <rudalics@gmx.at>
5096 * window.h (window): Rename slot "nest" to "combination_limit".
5097 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
5098 (Fset_window_nest): Rename to Fset_window_combination_limit.
5099 (Vwindow_nest): Rename to Vwindow_combination_limit.
5100 (recombine_windows, make_parent_window, make_window)
5101 (Fsplit_window_internal, saved_window)
5102 (Fset_window_configuration, save_window_save): Rename all
5103 occurrences of window_nest to window_combination_limit.
5105 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
5107 * image.c (imagemagick_load_image): Fix typo.
5109 2011-11-14 Eli Zaretskii <eliz@gnu.org>
5111 * xdisp.c (display_line): Move the call to
5112 highlight_trailing_whitespace before the call to
5113 compute_line_metrics, since the latter needs to see the final
5114 faces of all the glyphs to compute ROW's hash value.
5115 Fixes assertion violations in row_equal_p. (Bug#10035)
5117 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
5119 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
5120 just return (bug#10044).
5122 2011-11-12 Eli Zaretskii <eliz@gnu.org>
5124 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
5125 with user-defined heap size. Bump the default size of the temacs
5126 heap to 27MB, to avoid memory warning when running temacs.
5127 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
5129 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
5130 current_matrix and desired_matrix. (Bug#9990)
5131 (verify_row_hash) [XASSERTS]: New function.
5132 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
5133 that the hash value of glyph rows is correct.
5135 2011-11-12 Martin Rudalics <rudalics@gmx.at>
5137 * window.h (window): Remove splits slot.
5138 * window.c (Fwindow_splits, Fset_window_splits): Remove.
5139 (Fdelete_other_windows_internal, make_parent_window)
5140 (make_window, Fsplit_window_internal, Fdelete_window_internal)
5141 (Fset_window_configuration, save_window_save): Don't deal with
5142 split status of windows.
5143 (saved_window): Remove splits slot.
5144 (Vwindow_splits): Rewrite doc-string.
5146 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
5148 * xfns.c (unwind_create_frame):
5149 * nsfns.m (unwind_create_frame):
5150 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
5151 Vframe_list (Bug#9999).
5153 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
5155 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
5157 2011-11-11 Kenichi Handa <handa@m17n.org>
5159 * callproc.c (Fcall_process): Set the member dst_multibyte of
5162 2011-11-11 Johan Bockgård <bojohan@gnu.org>
5164 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
5165 avoid a crash (bug#9496).
5167 2011-11-09 Chong Yidong <cyd@gnu.org>
5169 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
5170 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
5172 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5174 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
5176 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5178 Avoid some portability problems by eschewing 'extern inline' functions.
5179 The trivial performance wins aren't worth the portability hassles; see
5180 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
5182 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5183 (window_box_width, window_box_left, window_box_left_offset)
5184 (window_box_right, window_box_right_offset): Undo previous change,
5185 by removing the "extern"s.
5186 * intervals.c (adjust_intervals_for_insertion)
5187 (adjust_intervals_for_deletion): Undo previous change,
5188 making these static again.
5189 (offset_intervals, temp_set_point_both, temp_set_point)
5190 (copy_intervals_to_string): No longer inline.
5191 * xdisp.c (window_text_bottom_y, window_box_width)
5192 (window_box_height, window_box_left_offset)
5193 (window_box_right_offset, window_box_left, window_box_right)
5194 (window_box): No longer inline.
5196 2011-11-08 Chong Yidong <cyd@gnu.org>
5198 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
5199 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
5200 Signal an error if not a live window.
5201 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
5202 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
5204 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
5206 * lisp.h (syms_of_abbrev): Remove declaration.
5207 Reported by CHENG Gao <chenggao@royau.me>.
5209 2011-11-07 Eli Zaretskii <eliz@gnu.org>
5211 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
5212 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
5213 of temacs in GUI mode.
5215 2011-11-07 Martin Rudalics <rudalics@gmx.at>
5217 * window.h: Declare delete_all_child_windows instead of
5218 delete_all_subwindows.
5219 * window.c (Fwindow_nest, Fset_window_nest)
5220 (Fset_window_new_total, Fset_window_new_normal)
5221 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
5222 (delete_all_subwindows): Rename to delete_all_child_windows.
5223 (Fdelete_other_windows_internal, Fset_window_configuration):
5224 Call delete_all_child_windows instead of delete_all_subwindows.
5225 * frame.c (delete_frame): Call delete_all_child_windows instead
5226 of delete_all_subwindows.
5228 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
5230 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
5231 This is also needed for porting to any host where GC_MARK_STACK is
5232 not GC_MAKE_GCPROS_NOOPS.
5233 (which_symbols): Use it.
5235 2011-11-07 Kenichi Handa <handa@m17n.org>
5237 * coding.c (coding_set_destination): Check coding->src_pos only
5238 when coding->src_object is a buffer (bug#9910).
5240 * process.c (send_process): Set the member src_multibyte of coding
5241 to 0 (bug#9911) when sending a unibyte text.
5243 * callproc.c (Fcall_process): Set the member src_multibyte of
5244 process_coding to 0 (bug#9912).
5246 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5248 * xmenu.c (cleanup_widget_value_tree): New function.
5249 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
5250 calling free_menubar_widget_value_tree directly (Bug#9830).
5252 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
5254 Fix some portability problems with 'inline'.
5255 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5256 (window_box_width, window_box_left, window_box_left_offset)
5257 (window_box_right, window_box_right_offset): Declare extern.
5258 Otherwise, these inline functions do not conform to C99 and
5259 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
5260 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
5261 * intervals.c (adjust_intervals_for_insertion)
5262 (adjust_intervals_for_deletion): Now extern, because otherwise the
5263 extern inline functions 'offset_intervals' couldn't refer to it.
5264 (static_offset_intervals): Remove.
5265 (offset_intervals): Rewrite using the old contents of
5266 static_offset_intervals. The old version didn't conform to C99
5267 because an extern inline function contained a reference to an
5268 identifier with static linkage.
5270 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
5272 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
5275 2011-11-06 Eli Zaretskii <eliz@gnu.org>
5277 * xdisp.c (init_iterator, reseat_to_string): Don't set the
5278 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
5279 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
5280 return Qleft_to_right.
5282 2011-11-06 Chong Yidong <cyd@gnu.org>
5284 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
5285 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
5286 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
5287 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
5288 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
5289 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
5290 (Fwindow_vscroll): Doc fix.
5291 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
5292 argument, since it makes no sense to pass a live window and for
5293 consistency with window-child.
5295 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
5297 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
5300 2011-11-05 Jason Rumney <jasonr@gnu.org>
5302 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
5303 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
5305 (add_font_entity_to_list): Fix logic errors in mixed boolean and
5306 bitwise arithmetic preventing use of unicode-sip and non-truetype
5309 2011-11-05 Eli Zaretskii <eliz@gnu.org>
5311 * s/ms-w32.h (fstat, stat, utime): Move redirections to
5314 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
5315 initialization code to keep similarity to xfns.c after changes
5318 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
5320 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
5321 (unwind_create_frame): New function (Bug#9943).
5322 (Fx_create_frame): Restructure code to be more similar to the one in
5323 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
5324 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
5325 Move terminal->reference_count++ just before making the frame official
5328 * nsterm.m (x_free_frame_resources): New function.
5329 (x_destroy_window): Move code to x_free_frame_resources.
5331 * xfns.c (unwind_create_frame): Fix comment.
5332 (Fx_create_frame, x_create_tip_frame):
5333 Move terminal->reference_count++ just before making the frame
5334 official. Move initialization of image_cache_refcount and
5335 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
5337 2011-11-05 Eli Zaretskii <eliz@gnu.org>
5339 Support MSVC build with newer versions of Visual Studio.
5340 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
5341 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
5344 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
5345 which are not supported by MSVC.
5346 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
5347 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
5349 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
5351 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
5353 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
5355 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
5357 Support MSVC build with newer versions of Visual Studio.
5358 * w32.c: Don't include w32api.h for MSVC.
5359 (init_environment) [_MSC_VER]: Call sys_access, not _access.
5361 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
5362 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
5363 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
5364 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
5366 (alloca) [_MSC_VER]: Define to _alloca.
5368 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
5370 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
5372 2011-11-04 Eli Zaretskii <eliz@gnu.org>
5374 * xdisp.c (note_mouse_highlight): If either of
5375 previous/next-single-property-change returns nil, treat that as
5376 the beginning or the end of the buffer. (Bug#9955)
5378 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
5380 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
5381 label is not null (Bug#9951).
5382 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
5385 2011-11-04 Eli Zaretskii <eliz@gnu.org>
5387 * window.c (Fwindow_body_size): Mention in the doc string that the
5388 return value is in frame's canonical units. (Bug#9949)
5390 2011-11-03 Eli Zaretskii <eliz@gnu.org>
5392 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
5394 * w32fns.c (unwind_create_frame): If needed, free the glyph
5395 matrices of the partially constructed frame. (Bug#9943)
5396 * xfns.c (unwind_create_frame): Likewise.
5398 2011-11-01 Eli Zaretskii <eliz@gnu.org>
5400 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
5401 Don't stop backward scan on the continuation glyph, even though
5402 its CHARPOS is positive.
5403 (mouse_face_from_buffer_pos, note_mouse_highlight):
5404 Rename cover_string to disp_string.
5406 2011-11-01 Martin Rudalics <rudalics@gmx.at>
5408 * window.c (temp_output_buffer_show): Don't use
5409 Vtemp_buffer_show_specifiers.
5410 (Vtemp_buffer_show_specifiers): Remove unused variable.
5412 2011-10-30 Eli Zaretskii <eliz@gnu.org>
5414 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
5415 past the beginning of the current glyph matrix.
5417 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
5419 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
5420 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
5421 HAVE_GTK3 (Bug#9869).
5423 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
5424 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
5426 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
5428 * xterm.c: Declare x_handle_net_wm_state to return int.
5429 (handle_one_xevent): Check if we are iconified but don't have
5430 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
5431 (get_current_wm_state): Return non-zero if not hidden,
5432 check for _NET_WM_STATE_HIDDEN (Bug#9893).
5433 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
5434 (x_handle_net_wm_state): Return what get_current_wm_state returns.
5435 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
5437 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
5439 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
5440 so that this new function doesn't get optimized away by a
5441 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
5443 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5445 * frame.h (MOUSE_HL_INFO): Remove excess parens.
5447 2011-10-29 Eli Zaretskii <eliz@gnu.org>
5449 Fix the `xbytecode' command.
5450 * .gdbinit (xprintbytestr): New command.
5451 (xwhichsymbols): Rename from `which'; all callers changed.
5452 (xbytecode): Print the byte-code string as well.
5454 2011-10-29 Kim Storm <storm@cua.dk>
5456 * alloc.c (which_symbols): New function.
5458 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5460 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
5463 2011-10-29 Glenn Morris <rgm@gnu.org>
5465 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
5466 Not clear what it was for, and it causes various bugs. (Bug#9839)
5468 2011-10-28 Eli Zaretskii <eliz@gnu.org>
5470 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
5471 possible random value that matches one of those tested as
5472 condition to clear the mouse face.
5474 2011-10-28 Chong Yidong <cyd@gnu.org>
5476 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
5478 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
5480 * window.c (make_window): Initialize phys_cursor_on_p.
5482 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
5484 * lisp.h (struct Lisp_Symbol): Update comments.
5486 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
5488 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
5490 2011-10-28 Eli Zaretskii <eliz@gnu.org>
5492 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
5493 <oslsachem@gmail.com> for helping to debug this.
5495 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
5496 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
5497 (g_b_init_get_glyph_outline_w): New static variables.
5498 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
5499 (GetGlyphOutlineW_Proc): New typedefs.
5500 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
5501 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
5503 (w32font_open_internal, compute_metrics):
5504 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
5505 instead of calling the "wide" APIs directly.
5507 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
5509 * w32.h (syms_of_w32font): Add prototype.
5511 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
5513 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
5514 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
5515 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
5516 (Fmove_to_window_line): Doc fix.
5518 2011-10-27 Chong Yidong <cyd@gnu.org>
5520 * process.c (make_process): Set gnutls_state to NULL.
5522 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
5523 non-NULL, regardless of GNUTLS_INITSTAGE.
5524 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
5525 an error. Set process slots as soon as we allocate them.
5527 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
5529 2011-10-27 Chong Yidong <cyd@gnu.org>
5531 * gnutls.c (emacs_gnutls_deinit): New function.
5532 Deallocate credentials structures as well as calling gnutls_deinit.
5533 (Fgnutls_deinit, Fgnutls_boot): Use it.
5535 * process.c (make_process): Initialize GnuTLS credentials to NULL.
5536 (deactivate_process): Call emacs_gnutls_deinit.
5538 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
5540 * image.c (x_create_x_image_and_pixmap):
5541 * w32.c (sys_rename, w32_delayed_load):
5542 * w32font.c (fill_in_logfont):
5543 * w32reg.c (x_get_string_resource): Silence compiler warnings.
5545 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
5547 * w32fns.c (w32_default_color_map): New function,
5548 extracted from Fw32_default_color_map.
5549 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5551 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
5553 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
5555 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
5557 * keyboard.c (test_undefined): New function (bug#9751).
5558 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
5560 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
5562 * sysdep.c (init_sys_modes): Fix the check for the controlling
5563 terminal (Bug#6649).
5565 2011-10-20 Eli Zaretskii <eliz@gnu.org>
5567 * dispextern.h (struct bidi_it): New member next_en_type.
5569 * bidi.c (bidi_line_init): Initialize the next_en_type member.
5570 (bidi_resolve_explicit_1): When next_en_pos is valid for the
5571 current character, check also for next_en_type being WEAK_EN.
5572 (bidi_resolve_weak): Don't enter the expensive loop if the current
5573 position is before next_en_pos. Record the bidi type of the first
5574 non-ET, non-BN character we find, in addition to its position.
5575 (bidi_level_of_next_char): Invalidate next_en_type when
5576 next_en_pos is over-stepped.
5578 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
5580 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
5581 * editfns.c: Rewrite current-time-zone so that it invokes
5582 the equivalent of (format-time-string "%Z") to get the time zone name.
5583 This fixes a bug when the time zone name contains characters that
5584 need converting from the system time locale to Emacs internal format.
5585 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
5586 that patch fixed format-time-string to do the conversion, but
5587 I forgot to fix current-time-zone.
5588 (format_time_string): New function, containing most of
5589 what Fformat_time_string used to contain.
5590 (Fformat_time_string): Rewrite in terms of format_time_string.
5591 This doesn't change this function's behavior.
5592 (current-time-zone): Rewrite to use format_time_string.
5593 This fixes the bug reported by Michael Schierl in
5594 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
5595 Jason Rumney's 2007-06-07 change worked around this bug, but
5597 * systime.h (tzname, timezone): Remove no-longer-used declarations.
5599 2011-10-19 Eli Zaretskii <eliz@gnu.org>
5601 * xdisp.c (start_display): If the character at POS is displayed
5602 via a display vector, reset IT->current.dpvec_index to zero.
5603 (try_window_reusing_current_matrix): If a line ends in a display
5604 vector or the next line starts in a display vector, continue
5605 redrawing the window even though the character position of
5606 start_row was reached.
5609 2011-10-18 Chong Yidong <cyd@gnu.org>
5611 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
5612 with nobreak-char-display too.
5614 2011-10-18 Eli Zaretskii <eliz@gnu.org>
5616 Fix part 3 of bug#9771.
5617 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
5618 (bidi_resolve_neutral): Don't enter the expensive loop looking for
5619 non-neutral characters if the current character is a paragraph
5620 separator (a.k.a. Newline). This avoids running the same
5621 expensive loop twice, once when we consume the preceding newline
5622 and the other time when the line actually needs to be displayed.
5623 Avoid the loop when we see neutrals on the base embedding level
5624 following a character whose directionality is the same as the
5625 paragraph's. This avoids running the expensive loop when a line
5626 ends in a long sequence of neutrals, like control characters.
5627 Add assertion against STRONG_AL type. Slightly rearrange code
5628 that determines the type of a neutral given the first non-neutral
5630 (bidi_level_of_next_char): Set next_en_pos to zero when
5631 invalidating its info.
5633 2011-10-17 Eli Zaretskii <eliz@gnu.org>
5635 * xdisp.c (push_display_prop): Determine whether to record string
5636 or buffer position by IT->string, not by IT->method. Allow
5637 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
5638 (move_it_vertically_backward): Don't look for character position
5639 immediately after the newline when in a continuation line.
5642 2011-10-15 Martin Rudalics <rudalics@gmx.at>
5644 * window.c (coordinates_in_window): Rewrite and delabelize
5645 vertical border check. (Bug#5357) (Bug#9618)
5647 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
5649 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
5650 errors in XSetWindowBorder (bug#9310).
5652 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
5654 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
5655 avoid crash when xmalloc overrun checking is enabled.
5657 2011-10-13 Eli Zaretskii <eliz@gnu.org>
5659 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
5660 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
5661 cursor motion with <left> and <right> arrow keys.
5663 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
5664 some callers set that themselves.
5666 2011-10-12 Eli Zaretskii <eliz@gnu.org>
5668 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
5669 display string and the previous row comes from the same string and
5670 is empty. (Bug#9739) (Bug#9738)
5672 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
5674 * doc.c (get_doc_string): Encode file name (bug#9735).
5676 2011-10-12 Eli Zaretskii <eliz@gnu.org>
5678 * bidi.c (bidi_level_of_next_char):
5679 * xdisp.c (get_visually_first_element): Remove old incorrect
5680 comments regarding the Unicode Line Separator character.
5682 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
5684 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
5686 * alloc.c (Fgc_status): Do not access beyond zombies array
5687 boundary if nzombies > MAX_ZOMBIES.
5688 * alloc.c (dump_zombies): Add missing format specifier.
5690 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
5692 * xdisp.c (set_cursor_from_row): Simplify conditionals,
5693 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
5695 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
5696 Some packages use them to denote characters with modifiers.
5698 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
5700 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
5701 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
5702 matching a pp-number. Rename parameter var to var1.
5704 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
5706 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
5708 2011-10-08 Glenn Morris <rgm@gnu.org>
5710 * callint.c (Fcall_interactively): Give a more explicit error for the
5711 'c' case with a non-character input. (Bug#8479)
5713 2011-10-08 Eli Zaretskii <eliz@gnu.org>
5715 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
5717 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
5718 lines that are hscrolled on the left.
5720 * dispnew.c (buffer_posn_from_coords): Account for a possible
5721 presence of header-line. (Bug#4426)
5723 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
5725 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
5726 Don't advertise functionality which we discourage or doesn't work.
5728 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
5730 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
5731 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
5732 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
5733 this makes Emacs dump core during garbage collection on rare
5734 occasions. sizeof is obviously inferior to offsetof here, so
5735 stick with offsetof.
5736 (GC_POINTER_ALIGNMENT): New macro.
5737 (mark_memory): Omit 3rd (offset) arg; caller changed.
5738 Don't assume EMACS_INT alignment is the same as pointer alignment.
5740 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
5742 * keyboard.c (read_key_sequence_remapped): New var.
5743 (read_key_sequence): Compute remapping in the right buffer.
5744 (command_loop_1): Use read_key_sequence's remapping directly.
5746 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
5748 * dired.c (file_name_completion): Don't expand file name.
5749 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
5750 before checking file name handler.
5752 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
5753 they've been requested explicitly (bug#9591).
5755 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
5757 * keymap.c (Fsingle_key_description): Use make_specified_string
5758 instead of build_string to build string from push_key_description.
5761 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5763 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
5764 This fixes a Y2038 bug on 64-bit hosts.
5765 * buffer.c (reset_buffer):
5766 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
5767 (Fclear_buffer_auto_save_failure):
5768 Use 0, not -1, to represent an unset failure time, since time_t
5769 might not be signed.
5771 Remove dependency on glibc malloc internals.
5772 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5773 Move back here from lisp.h, but with their new implementations.
5774 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5775 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
5776 * charset.c (charset_table_init): New static var.
5777 (syms_of_charset): Use it instead of xmalloc. This removes a
5778 dependency on glibc malloc internals. See Eli Zaretskii's comment in
5779 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
5780 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5781 Move back to alloc.c.
5782 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5783 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
5785 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
5787 * nsterm.m (windowDidResize): Call x_set_window_size only when
5788 ns_in_resize is true. Otherwise set pixelwidth/height and
5789 call change_frame_size (Bug#9628).
5791 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5793 Port --enable-checking=all to Fedora 14 x86-64.
5794 * charset.c (syms_of_charset): Also account for glibc malloc's
5795 internal overhead when calculating the initial malloc maximum.
5797 Port --enable-checking=all to Fedora 14 x86.
5798 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5800 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
5801 (overrun_check_realloc, overrun_check_free):
5802 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
5803 That way, xmalloc returns a properly-aligned pointer even if
5804 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
5805 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
5806 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
5807 into account when calculating the initial malloc maximum.
5808 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5809 Move here from alloc.c, so that charset.c can use it too.
5810 Properly align; the old code wasn't right for common 32-bit hosts
5811 when configured with --enable-checking=all.
5812 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5813 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
5815 2011-09-29 Eli Zaretskii <eliz@gnu.org>
5817 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
5820 2011-09-28 Eli Zaretskii <eliz@gnu.org>
5822 * xdisp.c (compute_display_string_end): If there's no display
5823 string at CHARPOS, return -1.
5825 * bidi.c (bidi_fetch_char): When compute_display_string_end
5826 returns a negative value, treat the character as a normal
5827 character not covered by a display string. (Bug#9624)
5829 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
5831 * lread.c (Fread_from_string): Fix typo in docstring.
5833 2011-09-27 Eli Zaretskii <eliz@gnu.org>
5835 * xdisp.c (handle_invisible_prop): If invisible text ends on a
5836 newline, reseat the iterator instead of bidi-iterating there one
5837 character at a time. (Bug#9610)
5838 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
5839 TO_CHARPOS if the bidi iterator is at base embedding level.
5841 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
5843 * lread.c (readevalloop): Use correct code for NBSP.
5844 (read1): Likewise. (Bug#9608)
5846 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
5848 * dbusbind.c (Fdbus_register_signal): When service is not
5849 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
5851 2011-09-25 Glenn Morris <rgm@gnu.org>
5853 * buffer.c (truncate-lines): Doc fix.
5855 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
5857 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
5858 (Fset_window_next_buffers): Doc fix.
5860 2011-09-24 Glenn Morris <rgm@gnu.org>
5862 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
5864 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
5866 Fix minor problems found by static checking.
5867 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
5868 * indent.c (Fvertical_motion): Fix == vs = typo.
5870 2011-09-24 Eli Zaretskii <eliz@gnu.org>
5872 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
5873 Default value is now t. Doc fix.
5875 * indent.c (Fvertical_motion): Compute and apply the overshoot
5876 logic when moving up, not only when moving down. Fix the
5877 confusing name and values of the it_overshoot_expected variable;
5878 logic changes accordingly. (Bug#9254) (Bug#9549)
5880 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
5881 CHARPOS is covered by a display string which includes newlines.
5882 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
5883 is covered by a display string with embedded newlines.
5885 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
5887 * dbusbind.c (Fdbus_register_signal): Add match rule to
5888 Vdbus_registered_objects_table. (Bug#9581)
5889 (Fdbus_register_method, Vdbus_registered_objects_table):
5892 2011-09-24 Jim Meyering <meyering@redhat.com>
5894 do not ignore write error for any output size
5895 The previous change was incomplete.
5896 While it makes emacs --batch detect the vast majority of stdout
5897 write failures, errors were still ignored whenever the output size is
5898 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
5899 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
5900 && echo FAIL: ignored write error
5901 FAIL: ignored write error
5902 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
5903 && echo FAIL: ignored write error
5904 FAIL: ignored write error
5905 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
5907 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
5909 * emacs.c (Fkill_emacs): In noninteractive mode exit
5910 non-successfully if a write error occurred on stdout. (Bug#9574)
5912 2011-09-21 Eli Zaretskii <eliz@gnu.org>
5914 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
5917 * dispextern.h (struct it): Update the comment documenting what
5920 2011-09-20 Eli Zaretskii <eliz@gnu.org>
5922 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
5923 a display string, extend search for cursor position to end of row.
5924 (find_row_edges): If the row ends in a newline from a display
5925 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
5926 Handle the case of a display string with multiple newlines.
5927 (Fcurrent_bidi_paragraph_direction): Fix search for previous
5928 non-empty line. Fixes confusing cursor motion with arrow keys at
5929 the beginning of a line that starts with whitespace.
5931 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5933 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
5936 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
5938 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
5941 2011-09-18 Eli Zaretskii <eliz@gnu.org>
5943 * xdisp.c (display_line): Record maximum and minimum buffer
5944 positions even if no glyphs were produced (e.g., by a zero-width
5945 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
5946 buffer positions that will be removed from the glyph row because
5948 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
5949 column is beyond frame width: don't subtract 1 "pixel" when
5950 computing width of the stretch.
5951 (reseat_at_next_visible_line_start): Undo the change made on
5952 2011-09-17 that saved paragraph information and restored it after
5953 the call to `reseat'. (Bug#9545)
5955 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5957 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
5958 and turn window cursor on if cleared (Bug#9415).
5960 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
5962 * search.c (boyer_moore): Take unibyte characters from pattern
5963 literally. (Bug#9458)
5965 2011-09-18 Eli Zaretskii <eliz@gnu.org>
5967 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
5969 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
5971 Fix minor problem found by static checking.
5972 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
5973 initialized, to pacify gcc -Wuninitialized.
5975 * fileio.c: Report proper errno when syscall falls.
5976 (Finsert_file_contents): Save and restore errno,
5977 so that report_file_error outputs the correct diagnostic.
5978 (Fwrite_region) [CLASH_DETECTION]: Likewise.
5980 2011-09-18 Eli Zaretskii <eliz@gnu.org>
5982 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
5984 2011-09-17 Eli Zaretskii <eliz@gnu.org>
5986 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
5987 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
5989 2011-09-17 Eli Zaretskii <eliz@gnu.org>
5991 * xdisp.c (reseat_at_next_visible_line_start): Keep information
5992 about the current paragraph and restore it after the call to reseat.
5994 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
5995 (bidi_find_paragraph_start): Search back for paragraph beginning
5996 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
5997 (bidi_move_to_visually_next): Only trigger paragraph-related
5998 computations when the last character is a newline or at EOB, not
5999 just any NEUTRAL_B. (Bug#9470)
6001 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
6002 truncated lines if point is covered by a display string. (Bug#9524)
6004 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
6006 * xselect.c: Relax test for outgoing X longs (Bug#9498).
6007 (cons_to_x_long): New function.
6008 (lisp_data_to_selection_data): Use it. Correct the test for
6009 short-versus-long data; it was negated. Break out of vector
6010 loop, for efficiency, when a long datum is discovered.
6012 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
6014 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
6016 2011-09-16 Eli Zaretskii <eliz@gnu.org>
6018 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
6019 GCC PR/17406) by declaring this function with external scope.
6021 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6023 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
6024 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
6026 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
6028 * editfns.c (Fformat): Correctly handle text properties on "%%".
6030 2011-09-15 Eli Zaretskii <eliz@gnu.org>
6032 * xterm.c (x_draw_composite_glyph_string_foreground):
6033 * w32term.c (x_draw_composite_glyph_string_foreground):
6034 * term.c (encode_terminal_code):
6035 * composite.c (composition_update_it, get_composition_id):
6036 * xdisp.c (get_next_display_element)
6037 (fill_composite_glyph_string): Add comments about special meaning
6038 of TAB characters in a composition.
6040 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6042 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
6043 This occurs when processing a multibyte format.
6044 Problem reported by Wolfgang Jenker.
6046 2011-09-15 Johan Bockgård <bojohan@gnu.org>
6048 * xdisp.c (try_cursor_movement): Only check for exact match if
6049 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
6051 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6053 Remove unused external symbols.
6054 * dispextern.h (calc_pixel_width_or_height): Remove decl.
6055 * xdisp.c (calc_pixel_width_or_height): Now static.
6056 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
6057 * indent.c (check_display_width):
6058 * w32term.c: Fix comment to match code.
6059 * xterm.c, xterm.h (x_catching_errors): Remove.
6061 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6063 * xselect.c: Use signed conversions more consistently (Bug#9498).
6064 (selection_data_to_lisp_data): Assume incoming selection data are
6065 signed integers, not unsigned. This is to be consistent with
6066 outgoing selection data, which was modified to use signed integers
6067 in as part of the fix to Bug#9196 in response to Jan D.'s comment
6068 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
6069 expects long, not unsigned long.
6071 2011-09-14 Eli Zaretskii <eliz@gnu.org>
6073 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
6074 computation of loop end. Reported by Johan Bockgård
6077 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
6079 * frame.c (Fother_visible_frames_p): Function deleted.
6081 2011-09-12 Eli Zaretskii <eliz@gnu.org>
6083 * indent.c (compute_motion): Process display vector front to back
6084 rather than the other way around. (Bug#2496)
6086 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
6088 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
6090 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
6092 * minibuf.c (Fread_from_minibuffer): Doc fix.
6094 2011-09-11 Eli Zaretskii <eliz@gnu.org>
6096 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
6097 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
6099 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6101 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
6102 value for non-existent files.
6104 2011-09-11 Eli Zaretskii <eliz@gnu.org>
6106 * fileio.c (Finsert_file_contents): If the file cannot be opened,
6107 set its "size" to -1. This will set the modtime_size field of
6108 the corresponding buffer to -1, which is what
6109 verify-visited-file-modtime expects for files that do not exist.
6112 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
6114 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
6116 * lisp.h: ... from here. push_key_description is no longer
6117 defined in keyboard.c, so its declaration should not be in
6118 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
6119 logically belongs with push_key_description.
6121 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
6123 * buffer.h: Include <sys/types.h> instead of <time.h>.
6124 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
6125 Problem reported by Herbert J. Skuhra.
6127 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
6129 * xml.c (parse_region): Make the parsing work for
6130 non-comment-starting XML files again (bug#9144).
6132 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
6134 * image.c (gif_load): Fix calculation of bottom and right corner.
6137 2011-09-10 Eli Zaretskii <eliz@gnu.org>
6139 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
6140 redisplay in small windows.
6142 2011-09-09 Eli Zaretskii <eliz@gnu.org>
6144 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
6146 2011-09-08 Martin Rudalics <rudalics@gmx.at>
6148 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
6149 Operate on live windows only.
6151 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
6153 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
6155 2011-09-07 Eli Zaretskii <eliz@gnu.org>
6157 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
6158 only under bidi iteration.
6160 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
6162 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
6164 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6166 isnan: Fix porting problem to Solaris 10 with bundled gcc.
6167 Without this fix, the command to link temacs failed due to an
6168 undefined symbol __builtin_isnan. This is because
6169 /usr/include/iso/math_c99.h #defines isnan(x) to
6170 __builtin_isnan(x), but the bundled gcc, which identifies itself
6171 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
6173 * floatfns.c (isnan): #undef, and then #define to a clone of
6175 (Fisnan): Always define, since it's always available now.
6176 (syms_of_floatfns): Always define isnan at the Lisp level.
6178 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6180 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
6182 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6184 * fileio.c: Fix bugs with large file offsets (Bug#9428).
6185 The previous code assumed that file offsets (off_t values) fit in
6186 EMACS_INT variables, which is not true on typical 32-bit hosts.
6187 The code messed up by falsely reporting buffer overflow in cases
6188 such as (insert-file-contents "big" nil 1 2) into an empty buffer
6189 when "big" contains more than 2**29 bytes, even though this
6190 inserts just one byte and does not overflow the buffer.
6191 (Finsert_file_contents): Store file offsets as off_t
6192 values, not as EMACS_INT values. Check for overflow when
6193 converting between EMACS_INT and off_t. When checking for
6194 buffer overflow or for overlap, take the offsets into account.
6195 Don't use EMACS_INT for small values where int suffices.
6196 When checking for overlap, fix a typo: ZV was used where
6197 ZV_BYTE was intended.
6198 (Fwrite_region): Don't assume off_t fits into 'long'.
6199 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
6201 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
6203 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
6205 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
6207 sprintf-related integer and memory overflow issues (Bug#9412).
6209 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
6210 (esprintf, exprintf, evxprintf): New functions.
6211 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6212 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
6213 (modify_event_symbol): Do not assume that the length of
6214 name_alist_or_stem is safe to alloca and fits in int.
6215 (Fexecute_extended_command): Likewise for function name and binding.
6216 (Frecursion_depth): Wrap around reliably on integer overflow.
6217 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
6218 since some callers pass EMACS_INT values.
6219 (Fsingle_key_description): Don't crash if symbol name contains more
6220 than MAX_ALLOCA bytes.
6221 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
6222 (get_minibuffer): Arg is now EMACS_INT, not int.
6223 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
6224 (esprintf, exprintf, evxprintf): New decls.
6225 * window.h (command_loop_level, minibuf_level): Reflect API changes.
6227 * dbusbind.c (signature_cat): New function.
6228 (xd_signature, Fdbus_register_signal):
6229 Do not overrun buffer; instead, report string overflow.
6231 * dispnew.c (add_window_display_history): Don't overrun buffer.
6232 Truncate instead; this is OK since it's just a log.
6234 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
6235 even if the time zone offset is outlandishly large.
6236 Don't mishandle offset == INT_MIN.
6238 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
6239 when creating daemon; the previous buffer-overflow check was incorrect.
6241 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
6242 which has the guts of the old verror function.
6244 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
6245 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
6247 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
6248 (font_unparse_xlfd): Don't blindly alloca long strings.
6249 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
6250 fits in int, when using sprintf. Use single snprintf to count
6251 length of string rather than counting it via multiple sprintfs;
6252 that's simpler and more reliable.
6253 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
6254 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
6255 sprintf, in case result does not fit in int.
6257 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
6258 (fontset_from_font): Print it.
6260 * frame.c (tty_frame_count): Now printmax_t, not int.
6261 (make_terminal_frame, set_term_frame_name): Print it.
6262 (x_report_frame_params): In X, window IDs are unsigned long,
6263 not signed long, so print them as unsigned.
6264 (validate_x_resource_name): Check for implausibly long names,
6265 and don't assume name length fits in 'int'.
6266 (x_get_resource_string): Don't blindly alloca invocation name;
6267 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
6270 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
6271 (xg_check_special_colors, xg_set_geometry):
6272 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
6274 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
6275 Use esprintf, not sprintf, in case result does not fit in int.
6277 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6278 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
6279 it as a large positive number.
6280 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
6281 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
6283 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
6284 in case result does not fit in int.
6286 * print.c (float_to_string): Detect width overflow more reliably.
6287 (print_object): Make sprintf buffer a bit bigger, to avoid potential
6288 buffer overrun. Don't assume list length fits in 'int'. Treat
6289 print length of 0 as 0, not as infinity; to be consistent with other
6290 uses of print length in this function. Don't overflow print length
6291 index. Don't assume hash table size fits in 'long', or that
6292 vectorlike size fits in 'unsigned long'.
6294 * process.c (make_process): Use printmax_t, not int, to format
6295 process-name gensyms.
6297 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
6299 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
6300 to avoid potential buffer overrun.
6302 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
6303 if X resource line is longer than 512 bytes.
6305 * xfns.c (x_window): Make sprintf buffer a bit bigger
6306 to avoid potential buffer overrun.
6308 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
6310 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
6312 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
6314 Integer overflow fixes for scrolling, etc.
6315 Without these, Emacs silently mishandles large integers sometimes.
6316 For example, "C-u 4294967297 M-x recenter" was treated as if
6317 it were "C-u 1 M-x recenter" on a typical 64-bit host.
6319 * xdisp.c (try_window_id): Check Emacs fixnum range before
6320 converting to 'int'.
6322 * window.c (window_scroll_line_based, Frecenter):
6323 Check that an Emacs fixnum is in range before assigning it to 'int'.
6324 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
6325 values converted from Emacs fixnums.
6326 (Frecenter): Don't wrap around a line count if it is out of 'int'
6327 range; instead, treat it as an extreme value.
6328 (Fset_window_configuration, compare_window_configurations):
6329 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
6331 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
6332 that can exceed INT_MAX. Check that EMACS_INT value is in range
6333 before assigning it to the (possibly-narrower) index.
6334 (match_limit): Don't assume that a fixnum can fit in 'int'.
6336 * print.c (print_object): Use ptrdiff_t, not int, for index that can
6339 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
6340 (Fvertical_motion): Don't wrap around LINES values that don't fit
6341 in 'int'. Instead, treat them as extreme values. This is good
6342 enough for windows, which can't have more than INT_MAX lines anyway.
6344 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6346 * Require libxml/parser.h to avoid compilation warning.
6348 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
6350 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
6351 since this reportedly can destroy thread storage.
6353 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
6355 * syntax.c (find_defun_start): Update all cache variables if
6356 exiting early (Bug#9401).
6358 2011-08-30 Eli Zaretskii <eliz@gnu.org>
6360 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
6362 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
6363 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
6364 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
6366 * term.c (tty_append_glyph): New function.
6367 (produce_stretch_glyph): Static function and its prototype deleted.
6369 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
6372 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
6374 * image.c (parse_image_spec): Check for nonnegative, not for positive,
6375 when checking :margin (Bug#9390).
6376 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
6377 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
6378 so that the name doesn't mislead. All uses changed.
6380 2011-08-28 Johan Bockgård <bojohan@gnu.org>
6382 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
6385 2011-08-27 Eli Zaretskii <eliz@gnu.org>
6387 * xdisp.c (move_it_to): Don't bail out early when reaching
6388 position beyond to_charpos, if we are scanning backwards.
6389 (move_it_vertically_backward): When DY == 0, make sure we get to
6390 the first character in the line after the newline.
6392 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
6394 * ccl.c: Improve and simplify overflow checking (Bug#9196).
6395 (ccl_driver): Do not generate an out-of-range pointer.
6396 (Fccl_execute_on_string): Remove unnecessary check for
6397 integer overflow, noted by Stefan Monnier in
6398 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
6399 Remove a FIXME that didn't need fixing.
6400 Simplify the newly-introduced buffer reallocation code.
6402 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
6404 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
6406 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
6408 Integer and memory overflow issues (Bug#9196).
6410 * doc.c (get_doc_string): Rework so that
6411 get_doc_string_buffer_size is the actual buffer size, rather than
6412 being 1 less than the actual buffer size; this makes xpalloc more
6415 * image.c (x_allocate_bitmap_record, cache_image):
6416 * xselect.c (Fx_register_dnd_atom):
6417 Simplify previous changes by using xpalloc.
6419 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
6420 since either will do and ptrdiff_t is convenient with xpalloc.
6422 * charset.c (charset_table_size)
6423 (struct charset_sort_data.priority): Now ptrdiff_t.
6424 (charset_compare): Don't overflow if priorities differ greatly.
6425 (Fsort_charsets): Don't assume list length fits in int.
6426 Check for size-calculation overflow when allocating sort data.
6427 (syms_of_charset): Allocate an initial charset table that is
6428 just under 64 KiB, to avoid problems with glibc malloc and mmap.
6430 * cmds.c (internal_self_insert): Check for size-calculation overflow.
6432 * composite.h (struct composition.glyph_len): Now int, not unsigned.
6433 The actual value is always <= INT_MAX, and leaving it unsigned made
6434 overflow checking harder.
6436 * dispextern.h (struct glyph_matrix.rows_allocated)
6437 (struct face_cache.size): Now ptrdiff_t, for convenience in use
6438 with xpalloc. The values are still always <= INT_MAX.
6440 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
6442 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
6443 (SAFE_NALLOCA): New macro.
6445 * region-cache.c (struct boundary.pos, find_cache_boundary)
6446 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
6447 (set_cache_region, invalidate_region_cache)
6448 (revalidate_region_cache, know_region_cache, region_cache_forward)
6449 (region_cache_backward, pp_cache):
6450 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
6451 so that ptrdiff_t * can be passed to xpalloc.
6452 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
6453 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
6454 (pp_cache): Don't assume cache_len fits in int.
6455 * region-cache.h: Adjust extern decls to match.
6457 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
6458 EMACS_INT, since either will do, for xpalloc.
6460 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
6461 (xnmalloc, xnrealloc, xpalloc): New functions.
6463 * bidi.c (bidi_shelve_header_size): New constant.
6464 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
6465 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
6467 * bidi.c (bidi_cache_shrink):
6468 * buffer.c (overlays_at, overlays_in, record_overlay_string)
6470 Don't update size of array until after memory allocation succeeds,
6471 because xmalloc/xrealloc may not return.
6472 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
6473 now that we have proper integer overflow checking.
6474 (record_overlay_string, overlay_strings): Catch overflows when
6475 calculating size of overlay_str_buf.
6477 * callproc.c (Fcall_process): Check for size overflow when
6478 calculating size of args2.
6479 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
6480 Normally we prefer signed values, but sticking with ptrdiff_t would
6481 require adding more-complicated checks.
6483 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
6484 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
6485 Redo buffer-overflow calculations to avoid integer overflow.
6486 Add a FIXME comment where memory seems to be over-allocated.
6488 * character.c (Fstring): Check for size-calculation overflow.
6490 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
6491 unnecessary integer overflow. Check for size overflow.
6492 (encode_coding_object): Don't update size until xmalloc succeeds.
6494 * composite.c (get_composition_id): Check for overflow in glyph
6495 length calculations.
6497 Integer and memory overflow fixes for display code.
6498 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
6499 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
6500 (scrolling_window): Check for overflow in size calculations.
6501 (line_draw_cost, realloc_glyph_pool, add_row_entry):
6502 Don't assume glyph table len fits in int.
6503 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
6504 (row_table_size): Now ptrdiff_t, not int.
6505 (scrolling_window): Avoid overflow in size calculations.
6506 Don't update size until allocation succeeds.
6507 * fns.c (concat): Check for overflow in size calculations.
6508 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
6509 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6510 (NEXT_ALMOST_PRIME_LIMIT): New constant.
6512 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
6513 (get_doc_string): Check for size calculation overflow.
6514 Don't update size until allocation succeeds.
6515 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
6516 EMACS_INT, where ptrdiff_t will do.
6517 (Fsubstitute_command_keys): Check for string overflow.
6519 * editfns.c (set_time_zone_rule): Don't assume environment length
6521 (message_length): Now ptrdiff_t, not int.
6522 (Fmessage_box): Don't update size until allocation succeeds.
6523 Don't assume message length fits in int.
6524 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
6526 * emacs.c (main): Do not reallocate argv, since there is a null at
6527 the end that can be overwritten, and this way there's no need to
6528 worry about size-calculation overflow.
6529 (sort_args): Check for size-calculation overflow.
6531 * eval.c (init_eval_once, grow_specpdl): Don't update size until
6533 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
6535 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
6536 (x_set_scroll_bar_width, x_figure_window_size):
6537 Check for integer overflow.
6538 (x_set_alpha): Do not assume XINT fits in int.
6540 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
6541 This is for the members text_lines, text_cols, total_lines, total_cols,
6542 where the system imposes an 'int' limit.
6544 * fringe.c (Fdefine_fringe_bitmap):
6545 Don't update size until alloc works.
6547 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
6548 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
6550 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
6551 Check for size-calculation overflow.
6552 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
6553 do, as we prefer signed integers.
6554 (id_to_widget.max_size, id_to_widget.used)
6555 (xg_store_widget_in_map, xg_remove_widget_from_map)
6556 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
6557 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
6558 Use and return ptrdiff_t, not int.
6559 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
6560 * gtkutil.h: Change prototypes to match the above.
6562 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
6563 are duplicate now that they've been promoted to lisp.h.
6564 (x_allocate_bitmap_record, x_alloc_image_color)
6565 (make_image_cache, cache_image, xpm_load):
6566 Don't update size until alloc is done.
6567 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
6569 Check for size calculation overflow.
6570 (ct_colors_allocated_max): New constant.
6571 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
6574 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
6575 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
6576 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
6577 Use ptrdiff_t, not int, to count maps.
6578 (read_char_minibuf_menu_prompt): Check for overflow in size
6579 calculations. Don't update size until allocation succeeds.
6580 Redo calculations to avoid overflow.
6581 * keyboard.h: Change prototypes to match the above.
6583 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
6585 (current_minor_maps): Check for size calculation overflow.
6586 * keymap.h: Change prototypes to match the above.
6588 * lread.c (read1, init_obarray): Don't update size until alloc done.
6590 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
6591 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
6593 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
6594 Now ptrdiff_t, not int.
6595 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
6596 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
6598 * process.c (Fnetwork_interface_list): Check for overflow
6599 in size calculation.
6601 * region-cache.c (move_cache_gap): Check for size calculation overflow.
6603 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
6604 overflow. Don't bother calling xmalloc when xrealloc will do.
6606 * search.c (Freplace_match): Check for size calculation overflow.
6607 (Fset_match_data): Don't assume list lengths fit in 'int'.
6609 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
6610 for command line length. Do not attempt to address one before the
6611 beginning of an array, as that's not portable.
6613 * term.c (max_frame_lines): Remove; unused.
6614 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
6616 (encode_terminal_code, calculate_costs): Check for size
6617 calculation overflow.
6618 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
6619 table lengths and related sizes. Don't update size until alloc
6620 done. Redo calculations to avoid overflow.
6621 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
6623 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
6624 subtracting pointers.
6625 (gobble_line): Check for overflow more carefully. Don't update size
6628 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
6629 Don't update size until alloc done.
6630 Redo size calculations to avoid overflow.
6631 Check for size calculation overflow.
6632 (main) [DEBUG]: Fix typo in invoking tparam1.
6634 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
6635 Use ptrdiff_t, not int, for sizes.
6636 (store_mode_line_noprop_char): Don't update size until alloc done.
6638 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
6639 Use ptrdiff_t, not int, for sizes.
6640 (Finternal_make_lisp_face, cache_face):
6641 Check for size calculation overflow.
6642 (cache_face): Treat size calculation overflows as if they were
6643 memory exhaustion (the usual treatment), rather than aborting.
6645 * xfns.c (x_encode_text, x_set_name_internal)
6646 (Fx_change_window_property): Use ptrdiff_t, not int, to count
6647 sizes, since they can exceed INT_MAX in size. Check for size
6648 calculation overflow.
6650 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
6651 (xg_select): Check for size calculation overflow.
6652 Don't update size until alloc done.
6654 * xrdb.c (get_environ_db): Don't assume path length fits in int,
6655 as sprintf is limited to int lengths.
6657 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
6658 (X_LONG_MIN): New macros.
6659 Use them to make the following changes clearer.
6660 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
6661 This change doesn't affect the value now, but it may help remind
6662 future maintainers not to raise the value too much later.
6663 (SELECTION_QUANTUM): Remove, replacing with ...
6664 (selection_quantum): ... new function, which avoids overflow.
6666 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
6667 assumption that selection length fits in 'int'.
6668 (x_reply_selection_request, x_handle_selection_request)
6669 (x_get_window_property, receive_incremental_selection)
6670 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
6671 (lisp_data_to_selection_data, clean_local_selection_data):
6672 Use ptrdiff_t, not int, to record length of selection.
6673 (x_reply_selection_request, x_get_window_property)
6674 (receive_incremental_selection, x_property_data_to_lisp):
6675 Redo calculations to avoid overflow.
6676 (x_reply_selection_request): When sending hint, ceiling it at
6677 X_LONG_MAX rather than relying on wraparound overflow to send
6679 (x_get_window_property, receive_incremental_selection)
6680 (lisp_data_to_selection_data, x_property_data_to_lisp):
6681 Check for size-calculation overflow.
6682 (x_get_window_property, receive_incremental_selection)
6683 (lisp_data_to_selection_data, Fx_register_dnd_atom):
6684 Don't store size until memory allocation succeeds.
6685 (x_get_window_property): Plug memory leak on memory exhaustion.
6686 Don't double-block input; malloc is safe here. Don't assume 2**34
6687 - 4 fits in unsigned long. Add an xassert to check
6688 XGetWindowProperty overflow. Be more careful about overflow
6689 calculations, and distinguish size from memory overflow better.
6690 (receive_incremental_selection): When tracing, don't assume
6691 unsigned int is less than INT_MAX.
6692 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
6693 harmful) conversions of unsigned short to int.
6694 (lisp_data_to_selection_data): Don't assume that integers
6695 in the range -65535 through -1 fit in an X unsigned short.
6696 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
6697 result parameters unless successful. Rely on cons_to_unsigned
6698 to report problems with elements; the old code wasn't right anyway.
6699 (x_check_property_data): Check for int overflow; we cannot use
6700 a wider type due to X limits.
6701 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
6703 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
6705 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
6706 (x_term_init): Check for size calculation overflow.
6707 (x_color_cells): Don't store size until memory allocation succeeds.
6708 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
6709 Don't assume alloca size is less than MAX_ALLOCA.
6710 (x_term_init): Don't assume length fits in int (sprintf is limited
6713 Use ptrdiff_t for composition IDs.
6714 * character.c (lisp_string_width):
6715 * composite.c (composition_table_size, n_compositions)
6716 (get_composition_id, composition_gstring_from_id):
6717 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
6718 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
6719 * window.c (Frecenter):
6720 Use ptrdiff_t, not int, for composition IDs.
6721 * composite.c (get_composition_id): Check for integer overflow.
6722 * composite.h: Adjust prototypes to match the above changes.
6724 Use ptrdiff_t for hash table indexes.
6725 * category.c (hash_get_category_set):
6726 * ccl.c (ccl_driver):
6727 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
6728 * coding.c (coding_system_charset_list, detect_coding_system):
6729 * coding.h (struct coding_system.id):
6730 * composite.c (get_composition_id, gstring_lookup_cache):
6731 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
6732 * image.c (xpm_get_color_table_h):
6733 * lisp.h (hash_lookup, hash_put):
6734 * minibuf.c (Ftest_completion):
6735 Use ptrdiff_t for hash table indexes, not int (which is too
6736 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
6737 32-bit --with-wide-int hosts).
6739 * charset.c (Fdefine_charset_internal): Check for integer overflow.
6740 Add a FIXME comment about memory leaks.
6741 (syms_of_charset): Don't assume xmalloc returns.
6743 Don't assume that stated character widths fit in int.
6744 * character.c (Fchar_width, c_string_width, lisp_string_width):
6745 * character.h (CHAR_WIDTH):
6746 * indent.c (MULTIBYTE_BYTES_WIDTH):
6747 Use sanitize_char_width to avoid undefined and/or bad behavior
6748 with outlandish widths.
6749 * character.h (sanitize_tab_width): Rename from sanitize_width,
6750 now that we have two such functions. All uses changed.
6751 (sanitize_char_width): New inline function.
6753 Don't assume that tab-width fits in int.
6754 * character.h (sanitize_width): New inline function.
6755 (SANE_TAB_WIDTH): New macro.
6756 (ASCII_CHAR_WIDTH): Use it.
6757 * indent.c (sane_tab_width): Remove. All uses replaced by
6758 SANE_TAB_WIDTH (current_buffer).
6759 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
6761 * fileio.c: Integer overflow issues with file modes.
6762 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
6764 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
6765 Remove unreachable code.
6766 (read_hex, load_charset_map_from_file): Check for integer overflow.
6768 * xterm.c: Don't go over XClientMessageEvent limit.
6769 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
6770 (x_send_scroll_bar_event): Likewise. Check that the size does not
6771 exceed limits imposed by XClientMessageEvent, as well as the usual
6772 ptrdiff_t and size_t limits.
6774 * keyboard.c: Overflow, signedness and related fixes.
6775 (make_lispy_movement): Use same integer type in forward decl
6776 that is used in the definition.
6777 (read_key_sequence, keyremap_step):
6778 Change bufsize argument back to int, undoing my 2011-03-30 change.
6779 We prefer signed types, and int is wide enough here.
6780 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
6781 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
6782 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
6783 length, not size_t. Use ptrdiff_t for index, not int.
6784 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
6785 possibility of integer overflow.
6787 Overflow, signedness and related fixes for images.
6789 * dispextern.h (struct it.stack[0].u.image.image_id)
6790 (struct_it.image_id, struct image.id, struct image_cache.size)
6791 (struct image_cache.used, struct image_cache.ref_count):
6792 * gtkutil.c (update_frame_tool_bar):
6793 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
6794 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
6795 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
6796 * nsmenu.m (update_frame_tool_bar):
6797 * xdisp.c (calc_pixel_width_or_height):
6798 * xfns.c (image_cache_refcount):
6799 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
6800 on typical 64-bit hosts.
6802 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6803 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
6804 Omit unnecessary casts to int.
6805 (parse_image_spec): Check that integers fall into 'int' range
6806 when the callers expect that.
6807 (image_ascent): Redo ascent calculation to avoid int overflow.
6808 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
6809 (lookup_image): Remove unnecessary tests.
6810 (xbm_image_p): Locals are now of int, not EMACS_INT,
6811 since parse_image_check makes sure they fit into int.
6812 (png_load, gif_load, svg_load_image):
6813 Prefer int to unsigned where either will do.
6814 (tiff_handler): New function, combining the cores of the
6815 old tiff_error_handler and tiff_warning_handler.
6816 This function is rewritten to use vsnprintf and thereby avoid
6817 stack buffer overflows. It uses only the features of vsnprintf
6818 that are common to both POSIX and native Microsoft.
6819 (tiff_error_handler, tiff_warning_handler): Use it.
6820 (tiff_load, gif_load, imagemagick_load_image):
6821 Don't assume :index value fits in 'int'.
6822 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
6823 (imagemagick_load_image): Check that crop parameters fit into
6824 the integer types that MagickCropImage accepts. Don't assume
6825 Vimagemagick_render_type has a nonnegative value. Don't assume
6826 size_t fits in 'long'.
6827 (gs_load): Use printmax_t to print the widest integers possible.
6828 Check for integer overflow when computing image height and width.
6830 2011-08-26 Eli Zaretskii <eliz@gnu.org>
6832 * xdisp.c (redisplay_window): Don't force window start if point
6833 will be invisible in the resulting window. (Bug#9324)
6835 2011-08-25 Eli Zaretskii <eliz@gnu.org>
6837 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
6838 the display spec is of the form `(space ...)'.
6839 (handle_display_spec): Return the value returned by
6840 handle_single_display_spec, not just 1 or zero.
6841 (handle_single_display_spec): If the display spec is of the form
6842 `(space ...)', and specifies display in the text area, return 2
6844 (try_cursor_movement): Check for the need to scroll more
6845 accurately, and prefer exact match for point under bidi.
6846 Don't advance `row' beyond the last row of the window.
6848 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
6849 into disp_prop; all users changed.
6851 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
6852 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
6853 for the text covered by the display property.
6855 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
6857 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
6858 Change return value to nil.
6859 (Frecord_buffer): Delete unused function.
6861 2011-08-24 Eli Zaretskii <eliz@gnu.org>
6863 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
6864 buffers, return left-to-right.
6865 (set_cursor_from_row): Consider candidate row a win if its glyph
6866 represents a newline and point is on that newline. Fixes cursor
6867 positioning on the newline at EOL of R2L text within L2R
6868 paragraph, and vice versa.
6869 (try_cursor_movement): Check continued rows, in addition to
6870 continuation rows. Fixes unwarranted scroll when point enters a
6871 continued line of R2L text within an L2R paragraph, or vice versa.
6872 (cursor_row_p): Consider the case of point being equal to
6873 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
6874 from the end of a short line to the beginning of a continued line
6875 of R2L text within L2R paragraph.
6876 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
6877 composed characters.
6879 * bidi.c (bidi_check_type): Use xassert.
6880 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
6883 2011-08-23 Eli Zaretskii <eliz@gnu.org>
6885 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
6888 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
6890 * nsfont.m (ns_otf_to_script): Fix typo.
6892 2011-08-22 Kenichi Handa <handa@m17n.org>
6894 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
6895 extra slot even if the purpose is char-code-property-table.
6897 2011-08-23 Eli Zaretskii <eliz@gnu.org>
6899 * xdisp.c (redisplay_window): When computing centering_position,
6900 account for the height of the header line. (Bug#8874)
6902 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
6903 instead of CHAR_TO_BYTE. Fixes a crash when a completion
6904 candidate is selected by the mouse, and that candidate has a
6905 composed character under the mouse.
6907 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
6908 coordinates reported by pos-visible-in-window-p for a composed
6909 character in column zero.
6911 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
6913 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
6915 2011-08-22 Eli Zaretskii <eliz@gnu.org>
6917 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
6918 consider it a hit if to_charpos is anywhere in the range of the
6919 composed buffer positions.
6921 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
6923 * image.c (gif_load): Don't assume that each subimage has the same
6924 dimensions as the base image. Handle disposal method that is
6925 "undefined" by the gif spec (Bug#9335).
6927 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
6929 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
6930 (Fcondition_case): Document `debug' symbol in error handler.
6932 2011-08-19 Eli Zaretskii <eliz@gnu.org>
6934 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
6935 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
6936 from an Org mode buffer to a Speedbar frame.
6938 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
6939 a composition, take its buffer position from IT->cmp_it.charpos.
6940 Fixes cursor positioning at the beginning of a line that begins
6941 with a composed character.
6943 2011-08-18 Eli Zaretskii <eliz@gnu.org>
6945 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
6946 character bidirectional type, use STRONG_L instead. Fixes crashes
6947 in a buffer produced by `describe-categories'.
6949 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
6950 members before the level stack, so they would be saved and
6951 restored when copying iterator state. Fixes incorrect reordering
6952 around TABs covered by display properties.
6954 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
6956 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
6958 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
6960 * eval.c (internal_condition_case, internal_condition_case_1)
6961 (internal_condition_case_2, internal_condition_case_n):
6962 Remove unnecessary aborts (Bug#9081).
6964 2011-08-17 Eli Zaretskii <eliz@gnu.org>
6966 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
6967 has no `load' handler, try opening the file locally. (Bug#9311)
6969 2011-08-16 Ken Brown <kbrown@cornell.edu>
6971 * gmalloc.c: Expand comment.
6973 2011-08-16 Eli Zaretskii <eliz@gnu.org>
6975 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
6976 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
6978 2011-08-16 Ken Brown <kbrown@cornell.edu>
6980 Fix memory allocation problems in Cygwin build (Bug#9273).
6982 * unexcw.c ( __malloc_initialized): Declare external variable.
6983 (fixup_executable): Force the dumped emacs to reinitialize malloc.
6985 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
6987 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
6989 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
6991 [CYGWIN] (special_realloc): New function.
6992 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
6993 requests to realloc storage in the static heap.
6995 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
6997 * bidi.c (bidi_initialize): Remove unused local.
6999 2011-08-15 Eli Zaretskii <eliz@gnu.org>
7002 * biditype.h: Remove file.
7003 * makefile.w32-in ($(BLD)/bidi.$(O)):
7004 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
7006 * dispextern.h: Fix a typo in the comment to bidi_type_t.
7008 * chartab.c: Improve commentary for the uniprop_table API.
7010 * bidi.c (bidi_paragraph_init): Support zero value of
7011 bidi_ignore_explicit_marks_for_paragraph_level.
7012 (bidi_initialize): Use uniprop_table instead of including
7013 biditype.h and bidimirror.h.
7015 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
7016 coordinates of the iterator when restoring from ppos_it.
7019 2011-08-14 Kenichi Handa <handa@m17n.org>
7021 * process.c (create_process): Call setup_process_coding_systems
7022 after the pid of the process is set to -1 (Bug#8162).
7024 2011-08-14 Eli Zaretskii <eliz@gnu.org>
7026 * xdisp.c (move_it_in_display_line_to): Don't invoke
7027 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
7028 ppos_it. Fixes vertical cursor motion when line beginning is
7029 covered by an image. (Bug#9296)
7031 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
7033 * nsterm.h (ns_run_ascript): Declare.
7034 (NSAPP_DATA2_RUNASSCRIPT): Define.
7036 * nsfns.m (as_script, as_result, as_status): New static variables.
7037 (ns_run_ascript): New function.
7038 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
7039 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
7040 the event loop. Get status from as_status (Bug#7276).
7042 * nsterm.m (sendEvent): If event is NSApplicationDefined and
7043 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
7044 the event loop (Bug#7276).
7046 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
7048 * gnutls.c (QCgnutls_bootprop_priority)
7049 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
7050 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
7051 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
7052 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
7053 (QCgnutls_bootprop_verify_hostname_error)
7054 (QCgnutls_bootprop_callbacks_verify): Rename from
7055 Qgnutls_bootprop_..., all uses changed.
7057 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
7060 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
7062 * xfaces.c (Qframe_set_background_mode): Now static.
7063 * dispextern.h (Qframe_set_background_mode): Remove decl.
7065 * process.c (Fnetwork_interface_info): Declare local only if needed.
7067 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
7069 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
7070 (Fnetwork_interface_list): Allocate in increments of bytes instead
7071 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
7072 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
7074 (struct ifflag_def): notrailers is smart on OSX.
7075 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
7076 Get hardware address with getifaddrs if available.
7078 2011-08-12 Eli Zaretskii <eliz@gnu.org>
7080 * xdisp.c (iterate_out_of_display_property): xassert that
7081 IT->position is set to within IT->object's boundaries. Break from
7082 the loop as soon as EOB is reached; avoids infloops in redisplay
7083 when IT->position is set up wrongly due to some bug.
7084 Set IT->current to match the bidi iterator unconditionally.
7085 (push_display_prop): Allow GET_FROM_STRING as IT->method on
7086 entry. Force push_it to save on the stack the current
7087 buffer/string position, to be restored by pop_it. Fix flags in
7088 the iterator structure wrt the object coming from a display
7089 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
7090 properties. (Bug#9284)
7092 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
7094 * fontset.c (fontset_get_font_group): Add proper type checks.
7097 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7099 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
7100 and LC_VERSION_MIN_MACOSX.
7101 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
7102 (dump_it) [LC_FUNCTION_STARTS]: Use it.
7104 2011-08-08 Eli Zaretskii <eliz@gnu.org>
7106 * xdisp.c (forward_to_next_line_start): Allow to use the
7107 no-display-properties-and-no-overlays under bidi display.
7108 Set disp_pos in the bidi iterator to avoid searches for display
7109 properties and overlays.
7111 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
7113 * editfns.c (Fset_time_zone_rule): Document relationship with the
7116 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
7117 the font entity extracted from the cache (Bug#8109).
7119 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
7121 * composite.c (autocmp_chars): Don't reset point. That is done by
7122 restore_point_unwind (Bug#5984).
7124 2011-08-07 Juri Linkov <juri@jurta.org>
7126 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
7127 to show the arg `TIME' instead of `TIMEVAL'.
7129 2011-08-06 Eli Zaretskii <eliz@gnu.org>
7131 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
7132 display property strides EOL and includes a newline, as in
7133 longlines-mode. (Bug#9254)
7134 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
7135 word-wrap under bidirectional display. (Bug#9224)
7137 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
7138 is non-zero, even if the data buffer is NULL. Fixes a crash in
7139 vertical-motion with longlines-mode. (Bug#9254)
7141 2011-08-05 Eli Zaretskii <eliz@gnu.org>
7143 * bidi.c <bidi_cache_total_alloc>: Now static.
7144 (bidi_initialize): Initialize bidi_cache_total_alloc.
7146 * xdisp.c (display_line): Release buffer allocated for shelved bidi
7149 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
7150 amount allocated this far in `bidi_cache_total_alloc'.
7151 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
7152 non-zero, only free the data buffer without restoring the cache
7153 contents. All callers changed.
7155 * dispextern.h (bidi_unshelve_cache): Update prototype.
7157 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
7158 (move_it_in_display_line, move_it_to)
7159 (move_it_vertically_backward, move_it_by_lines): Replace the call
7160 to xfree to an equivalent call to bidi_unshelve_cache.
7161 (move_it_in_display_line_to): Fix logic of returning
7162 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
7164 2011-08-05 Eli Zaretskii <eliz@gnu.org>
7166 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
7167 came from a string character with a `cursor' property. (Bug#9229)
7169 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7171 * Makefile.in (LIB_PTHREAD): New variable.
7172 (LIBES): Add LIB_PTHREAD (Bug#9216).
7174 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
7175 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
7177 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
7179 * regex.c (re_iswctype): Remove some redundant boolean conversions.
7181 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7183 * xterm.c (x_find_topmost_parent): New function.
7184 (x_set_frame_alpha): Find topmost parent window with
7185 x_find_topmost_parent and set the property there also (bug#9181).
7186 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
7188 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
7190 * callproc.c (Fcall_process): Avoid vfork clobbering
7191 the local vars buffer, coding_systems, current_dir.
7193 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
7195 * keymap.c (Fmake_composed_keymap): Move to subr.el.
7197 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
7199 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
7200 so that it is not optimized away.
7202 * xdisp.c (compute_display_string_pos): Remove unused local.
7204 2011-08-02 Eli Zaretskii <eliz@gnu.org>
7206 Fix slow cursor motion and scrolling in large buffers with
7207 selective display, like Org Mode buffers. (Bug#9218)
7209 * dispextern.h (struct bidi_it): New member disp_prop_p.
7211 * xdisp.c: Remove one-slot cache of display string positions.
7212 (compute_display_string_pos): Accept an additional argument
7213 DISP_PROP_P; callers changed. Scan at most 5K characters forward
7214 for a display string or property. If found, set DISP_PROP_P
7217 * bidi.c (bidi_fetch_char): Accept an additional argument
7218 DISP_PROP_P, and pass it to compute_display_string_pos.
7219 Only handle text covered by a display string if DISP_PROP_P is returned
7220 non-zero. All callers of bidi_fetch_char changed.
7222 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
7224 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
7226 2010-12-03 Don March <don@ohspite.net>
7228 * keymap.c (Fdefine_key): Fix non-prefix key error message when
7229 last character M-[char] is translated to ESC [char] (bug#7541).
7231 2011-08-02 Kenichi Handa <handa@m17n.org>
7233 * lisp.h (uniprop_table): Extern it.
7235 * chartab.c (uniprop_table): Make it non-static.
7237 2011-08-01 Eli Zaretskii <eliz@gnu.org>
7239 * xdisp.c (forward_to_next_line_start): Accept additional argument
7240 BIDI_IT_PREV, and store into it the state of the bidi iterator had
7242 (reseat_at_next_visible_line_start): Use the bidi iterator state
7243 returned by forward_to_next_line_start to restore the state of
7244 it->bidi_it after backing up to previous newline. (Bug#9212)
7246 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
7248 * regex.c (re_comp): Protoize.
7249 (re_exec): Fix return type.
7250 (regexec): Fix type of `ret'. (Bug#9203)
7252 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7254 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
7255 This is needed if max-image-size is a floating-point number.
7257 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7259 * print.c (print_object): Print empty symbol as ##.
7261 * lread.c (read1): Read ## as empty symbol.
7263 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
7265 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
7266 setting frame foreground color (Bug#9175).
7267 (x_set_background_color): Likewise.
7269 * nsmenu.m (-setText): Size tooltip dimensions precisely to
7270 contents (Bug#9176).
7271 (EmacsTooltip -init): Remove bezels and add shadows to
7274 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
7275 or scroll bar (Bug#8470).
7277 * nsfont.m (nsfont_open): Remove assignment to voffset and
7278 unnecessary vars hshink, expand, hd, full_height, min_height.
7279 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
7281 * nsterm.h (nsfont_info): Remove voffset field.
7283 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
7285 Implement strike-through and overline on NextStep (Bug#8863).
7287 * nsfont.m (nsfont_open): Use underline position provided by font,
7288 instead of hard-coded value of 2.
7289 (nsfont_draw): Call ns_draw_text_decoration instead.
7291 * nsterm.h: Add declaration for ns_draw_text_decoration.
7293 * nsterm.m (ns_draw_text_decoration): New function for drawing
7294 underline, overline, and strike-through.
7295 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
7296 ns_draw_text_decoration. Change treatment of cursor drawing to
7297 accommodate underlining, etc.
7299 2011-07-28 Eli Zaretskii <eliz@gnu.org>
7301 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
7304 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7306 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
7307 Without this fix, if a signal arrives just after memory fills up,
7308 'malloc' might be invoked reentrantly.
7310 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
7311 In other words, assume that every image size is allowed, on non-X
7312 hosts. This assumption is probably wrong, but it lets Emacs compile.
7314 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7316 * regex.c (re_iswctype): Convert return values to boolean.
7318 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
7320 * xdisp.c (compute_display_string_pos): Don't use cached display
7321 string position if the buffer had its restriction changed.
7324 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7326 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7328 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7330 Integer signedness and overflow and related fixes. (Bug#9079)
7332 * bidi.c: Integer size and overflow fixes.
7333 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
7334 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
7335 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7336 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
7337 (bidi_find_other_level_edge):
7338 Use ptrdiff_t instead of EMACS_INT where either will do.
7339 This works better on 32-bit hosts configured --with-wide-int.
7340 (bidi_cache_ensure_space): Check for size-calculation overflow.
7341 Use % rather than repeated addition, for better worst-case speed.
7342 Don't set bidi_cache_size until after xrealloc returns, because it
7344 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
7345 (bidi_cache_ensure_space): Also check that the bidi cache size
7346 does not exceed that of the largest Lisp string or buffer. See Eli
7347 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
7349 * alloc.c (__malloc_size_t): Remove.
7350 All uses replaced by size_t. See Andreas Schwab's note
7351 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
7353 * image.c: Improve checking for integer overflow.
7354 (check_image_size): Assume that f is nonnull, since
7355 it is always nonnull in practice. This is one less thing to
7356 worry about when checking for integer overflow later.
7357 (x_check_image_size): New function, which checks for integer
7358 overflow issues inside X.
7359 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
7360 This removes the need for a memory_full check.
7361 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
7362 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
7363 (xbm_read_bitmap_data): Change locals back to 'int', since
7364 their values must fit in 'int'.
7365 (xpm_load_image, png_load, tiff_load):
7366 Invoke x_create_x_image_and_pixmap earlier,
7367 to avoid much needless work if the image is too large.
7368 (tiff_load): Treat overly large images as if
7369 x_create_x_image_and_pixmap failed, not as malloc failures.
7370 (gs_load): Use x_check_image_size.
7372 * gtkutil.c: Omit integer casts.
7373 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
7374 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
7376 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
7378 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
7379 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
7380 would wrongly return t on a 64-bit host.
7382 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
7383 The plain *_OVERFLOW macros run afoul of GCC bug 49705
7384 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
7385 and therefore cause GCC to emit a bogus diagnostic in some cases.
7387 * image.c: Integer signedness and overflow and related fixes.
7388 This is not an exhaustive set of fixes, but it's time to
7389 record what I've got.
7390 (lookup_pixel_color, check_image_size): Remove redundant decls.
7391 (check_image_size): Don't assume that arbitrary EMACS_INT values
7392 fit in 'int', or that arbitrary 'double' values fit in 'int'.
7393 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
7394 (tiff_load, imagemagick_load_image):
7395 Check for overflow in size calculations.
7396 (x_create_x_image_and_pixmap): Remove unnecessary test for
7397 xmalloc returning NULL; that can't happen.
7398 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
7399 (xpm_color_bucket): Use better integer hashing function.
7400 (xpm_cache_color): Don't possibly over-allocate memory.
7401 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
7402 (gif_memory_source):
7403 Use ptrdiff_t, not int or size_t, to record sizes.
7404 (png_load): Don't assume values greater than 2**31 fit in 'int'.
7405 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
7406 either works, as we prefer signed integers.
7407 (tiff_read_from_memory, tiff_write_from_memory):
7408 Return tsize_t, not size_t, since that's what the TIFF API wants.
7409 (tiff_read_from_memory): Don't fail simply because the read would
7410 go past EOF; instead, return a short read.
7411 (tiff_load): Omit no-longer-needed casts.
7412 (Fimagemagick_types): Don't assume size fits into 'int'.
7414 Improve hashing quality when configured --with-wide-int.
7415 * fns.c (hash_string): New function, taken from sxhash_string.
7416 Do not discard information about ASCII character case; this
7417 discarding is no longer needed.
7418 (sxhash-string): Use it. Change sig to match it. Caller changed.
7419 * lisp.h: Declare it.
7420 * lread.c (hash_string): Remove, since we now use fns.c's version.
7421 The fns.c version returns a wider integer if --with-wide-int is
7422 specified, so this should help the quality of the hashing a bit.
7424 * emacs.c: Integer overflow minor fix.
7425 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
7426 Define only if GNU_LINUX.
7427 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
7429 * dispnew.c: Integer signedness and overflow fixes.
7430 Remove unnecessary forward decls, that were a maintenance hassle.
7431 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
7433 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
7434 (scrolling_window): Use ptrdiff_t, not int, for byte count.
7435 (prepare_desired_row, line_draw_cost):
7436 Use int, not unsigned, where either works.
7437 (save_current_matrix, restore_current_matrix):
7438 Use ptrdiff_t, not size_t, where either works.
7439 (init_display): Check for overflow more accurately, and without
7440 relying on undefined behavior.
7442 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
7443 Remove, replacing with the new symbols in lisp.h. All uses changed.
7444 * fileio.c (make_temp_name):
7445 * filelock.c (lock_file_1, lock_file):
7446 * xdisp.c (message_dolog):
7447 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
7448 Use pMd etc. instead.
7449 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
7450 replacing the pWIDE etc. symbols removed from editfns.c.
7452 * keyboard.h (num_input_events): Now uintmax_t.
7453 This is (very slightly) less likely to mess up due to wraparound.
7456 * buffer.c: Integer signedness fixes.
7457 (alloc_buffer_text, enlarge_buffer_text):
7458 Use ptrdiff_t rather than size_t when either will do, as we prefer
7461 * alloc.c: Integer signedness and overflow fixes.
7462 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
7463 (__malloc_size_t): Default to size_t, not to int.
7464 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
7465 (Fgarbage_collect, mark_object_loop_halt, mark_object):
7466 Prefer ptrdiff_t to size_t when either would do, as we prefer
7468 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
7469 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
7470 Now const. Initialize with values that are in range even if char
7472 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
7473 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
7474 These functions do the right thing with sizes > 2**32.
7475 (check_depth): Now ptrdiff_t, not int.
7476 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
7477 Adjust to new way of storing sizes. Check for size overflow bugs
7479 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
7480 slightly wrong anyway, as it missed one instance of
7481 XMALLOC_OVERRUN_CHECK_OVERHEAD.
7482 (refill_memory_reserve): Omit needless cast to size_t.
7483 (mark_object_loop_halt): Mark as externally visible.
7485 * xselect.c: Integer signedness and overflow fixes.
7486 (Fx_register_dnd_atom, x_handle_dnd_message):
7487 Use ptrdiff_t, not size_t, since we prefer signed.
7488 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
7489 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
7490 x_dnd_atoms_size and x_dnd_atoms_length.
7492 * doprnt.c: Prefer signed to unsigned when either works.
7494 * doprnt.c (doprnt):
7496 * xdisp.c (vmessage):
7497 Use ptrdiff_t, not size_t, when using or implementing doprnt,
7498 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
7499 prefer signed arithmetic to avoid comparison confusion.
7500 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
7501 but is a bit tricky.
7503 Assume freestanding C89 headers, string.h, stdlib.h.
7504 * data.c, doprnt.c, floatfns.c, print.c:
7505 Include float.h unconditionally.
7506 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
7507 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
7508 * regex.c: Likewise for stddef.h, string.h.
7509 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
7510 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
7511 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
7512 (STDC_HEADERS): Remove obsolete defines.
7513 * sysdep.c: Include limits.h unconditionally.
7515 Assume support for memcmp, memcpy, memmove, memset.
7516 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
7517 * regex.c (memcmp, memcpy):
7518 Remove; we assume C89 now.
7520 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
7521 (__malloc_safe_bcopy): Remove; no longer needed.
7523 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
7524 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
7525 well either way, and we prefer signed to unsigned.
7527 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
7529 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
7530 closes the connection while we're reading (bug#9182).
7532 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
7534 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
7535 are specified (Bug#9168).
7537 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
7539 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
7540 Found by GCC static checking and --with-wide-int on a 32-bit host.
7542 2011-07-25 Eli Zaretskii <eliz@gnu.org>
7544 * xdisp.c (compute_display_string_pos): Fix logic of caching
7545 previous display string position. Initialize cached_prev_pos to
7546 -1. Fixes slow-down at the beginning of a buffer.
7548 2011-07-24 Eli Zaretskii <eliz@gnu.org>
7550 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
7551 for attrs[LFACE_FONTSET_INDEX].
7553 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
7555 * xml.c (parse_region): Remove unused local
7556 that was recently introduced.
7558 2011-07-23 Eli Zaretskii <eliz@gnu.org>
7560 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
7561 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
7563 * xdisp.c (move_it_in_display_line_to): Record the best matching
7564 position for TO_CHARPOS while scanning the line, and restore it on
7565 exit if none of the characters scanned was an exact match.
7566 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
7567 when exact match is impossible due to invisible text, and the
7568 lines are truncated.
7570 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
7572 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
7575 2011-07-22 Eli Zaretskii <eliz@gnu.org>
7577 Fix a significant slow-down of cursor motion with C-n, C-p,
7578 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
7579 auto-repeat under bidi redisplay in fontified buffers.
7580 * xdisp.c (compute_stop_pos_backwards): New function.
7581 (next_element_from_buffer): Call compute_stop_pos_backwards to
7582 find a suitable prev_stop when we find ourselves before
7584 (reseat): Don't look for prev_stop, as that could mean a very long
7586 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
7587 <cached_disp_overlay_modiff>: Cache for last found display string
7589 (compute_display_string_pos): Return the cached position if asked
7590 about the same buffer in the same area of character positions, and
7591 the buffer wasn't changed since the time the display string
7592 position was cached.
7594 2011-07-22 Eli Zaretskii <eliz@gnu.org>
7596 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
7597 is an integer, which is important for empty lines. (Bug#9149)
7599 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
7601 * frame.c (Fmodify_frame_parameters): In tty case, update the
7602 default face if necessary (Bug#4238).
7604 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
7606 * editfns.c (Fstring_to_char): No need to explain what a character
7607 is in the docstring (Bug#6576).
7609 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7611 * xml.c (parse_region): Make sure we always return a tree.
7613 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
7615 * xml.c (parse_region): If a document contains only comments,
7618 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7620 * xml.c (make_dom): Return comments, too.
7622 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
7625 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
7626 and the surrounding thread.
7627 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
7628 rather than fgets, and retry after EINTR. Otherwise, 'emacs
7629 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
7631 * s/openbsd.h (BROKEN_SIGIO): Define.
7632 * unexelf.c (unexec) [__OpenBSD__]:
7633 Don't update the .mdebug section of the Alpha COFF symbol table.
7635 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7637 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
7640 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
7642 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
7643 This fixes some race conditions on the permissions of any newly
7646 * alloc.c (valid_pointer_p): Use pipe, not open.
7647 This fixes some permissions issues when debugging.
7649 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
7650 If fchown fails to set both uid and gid, try to set just gid,
7651 as that is sometimes allowed. Adjust the file's mode to eliminate
7652 setuid or setgid bits that are inappropriate if fchown fails.
7654 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
7656 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
7657 to compare Lisp_Objects.
7658 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
7659 global_gnutls_log_level, don't mistake it for a Lisp_Object.
7660 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
7662 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
7664 * lread.c (read_integer): Unread even EOF character.
7665 (read1): Likewise. Properly record start position of symbol.
7667 * lread.c (read1): Read `#:' as empty uninterned symbol if no
7668 symbol character follows.
7670 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
7672 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
7673 This works around a problem with the previous change to Fcopy_file.
7674 Recent glibc declares fchown with __attribute__((warn_unused_result)),
7675 and without this change, GCC might complain about discarding
7676 fchown's return value.
7678 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
7680 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
7682 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
7684 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
7686 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
7688 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
7689 it's used from the C level.
7691 * process.c: Use the same condition for POLL_FOR_INPUT in both
7692 keyboard.c and process.c (bug#1858).
7694 2011-07-09 Lawrence Mitchell <wence@gmx.li>
7696 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
7697 (Fgnutls_boot): Use it.
7699 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
7701 * doc.c (Fsubstitute_command_keys): Revert last change.
7703 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
7705 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
7706 quotes the next character, and doesn't affect other longer
7707 sequences (bug#8935).
7709 * lread.c (syms_of_lread): Clarify that is isn't only
7710 `eval-buffer' and `eval-defun' that's affected by
7711 `lexical-binding' (bug#8460).
7713 2011-07-15 Eli Zaretskii <eliz@gnu.org>
7715 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
7716 bidi redisplay when a line includes both an image and is truncated.
7718 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
7720 Fix minor problems found by static checking.
7721 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
7722 (elsz): Now a signed constant, not a size_t var. We prefer signed
7723 types to unsigned, to avoid integer comparison confusion. Without
7724 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
7725 "cannot optimize loop, the loop counter may overflow", a symptom
7727 * indent.c (Fvertical_motion): Mark locals as initialized.
7728 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
7730 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7732 * search.c (Fre_search_backward): Mention `case-fold-search' in
7733 all the re_search_* functions (bug#8138).
7735 * keyboard.c (Fopen_dribble_file): Document when the file is
7738 2011-07-14 Eli Zaretskii <eliz@gnu.org>
7740 * bidi.c (bidi_dump_cached_states): Fix format of displaying
7743 Support bidi reordering of display and overlay strings.
7744 * xdisp.c (compute_display_string_pos)
7745 (compute_display_string_end): Accept additional argument STRING.
7746 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
7747 (reseat_to_string): Initialize bidi_it->string.s and
7748 bidi_it->string.schars.
7749 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
7750 NULL (avoids a crash in bidi_paragraph_init).
7751 Initialize itb.string.lstring.
7752 (init_iterator): Call bidi_init_it only of a valid
7753 buffer position was specified. Initialize paragraph_embedding to
7755 (reseat_to_string): Initialize the bidi iterator.
7756 (display_string): If we need to ignore text properties of
7757 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
7758 original value of -1 will not work with bidi.)
7759 (compute_display_string_pos): First arg is now struct
7760 `text_pos *'; all callers changed. Support display properties on
7762 (compute_display_string_end): Support display properties on Lisp
7764 (init_iterator, reseat_1, reseat_to_string): Initialize the
7765 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
7766 when iterating on a string not from display properties).
7767 (compute_display_string_pos, compute_display_string_end):
7768 Fix calculation of the object to scan. Fixes an error when using
7770 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
7771 base_level_stop; instead, set base_level_stop to BEGV.
7772 Fixes crashes in vertical-motion.
7773 (next_element_from_buffer): Improve commentary for when
7774 the iterator is before prev_stop.
7775 (init_iterator): Initialize bidi_p from the default value of
7776 bidi-display-reordering, not from buffer-local value. Use the
7777 buffer-local value only if initializing for buffer iteration.
7778 (handle_invisible_prop): Support invisible properties on strings
7779 that are being bidi-reordered.
7780 (set_iterator_to_next): Support bidi reordering of C strings and
7782 (next_element_from_string): Support bidi reordering of Lisp
7784 (handle_stop_backwards): Support Lisp strings as well.
7785 (display_string): Support display of R2L glyph rows.
7786 Use IT_STRING_CHARPOS when displaying from a Lisp string.
7787 (init_iterator): Don't initialize it->bidi_p for strings
7789 (reseat_to_string): Initialize it->bidi_p for strings here.
7790 (next_element_from_string, next_element_from_c_string)
7791 (next_element_from_buffer): Add xassert's for correspondence
7792 between IT's object being iterated and it->bidi_it.string
7794 (face_before_or_after_it_pos): Support bidi iteration.
7795 (next_element_from_c_string): Handle the case of the first string
7796 character that is not the first one in the visual order.
7797 (get_visually_first_element): New function, refactored from common
7798 parts of next_element_from_buffer, next_element_from_string, and
7799 next_element_from_c_string.
7800 (tool_bar_lines_needed, redisplay_tool_bar)
7801 (display_menu_bar): Force left-to-right direction. Add a FIXME
7802 comment for making that be controlled by a user option.
7803 (push_it, pop_it): Save and restore the state of the
7804 bidi iterator. Save and restore the bidi_p flag.
7805 (pop_it): Iterate out of display property for string iteration as
7807 (iterate_out_of_display_property): Support iteration over strings.
7808 (handle_single_display_spec): Set up it->bidi_it for iteration
7809 over a display string, and call bidi_init_it.
7810 (handle_single_display_spec, next_overlay_string)
7811 (get_overlay_strings_1, push_display_prop): Set up the bidi
7812 iterator for displaying display or overlay strings.
7813 (forward_to_next_line_start): Don't use the shortcut if
7815 (back_to_previous_visible_line_start): If handle_display_prop
7816 pushed the iterator stack, restore the internal state of the bidi
7817 iterator by calling bidi_pop_it same number of times.
7818 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
7819 and we are bidi-iterating, don't decrement the iterator position;
7820 instead, set the first_elt flag in the bidi iterator, to produce
7822 (reseat_1): Remove redundant setting of string_from_display_prop_p.
7823 (push_display_prop): xassert that we are iterating a buffer.
7824 (push_it, pop_it): Save and restore paragraph_embedding member.
7825 (handle_single_display_spec, next_overlay_string)
7826 (get_overlay_strings_1, reseat_1, reseat_to_string)
7827 (push_display_prop): Set up the `unibyte' member of bidi_it.string
7828 correctly. Don't assume unibyte strings are not bidi-reordered.
7829 (compute_display_string_pos)
7830 (compute_display_string_end): Fix handling the case of C string.
7831 (push_it, pop_it): Save and restore from_disp_prop_p.
7832 (handle_single_display_spec, push_display_prop): Set the
7833 from_disp_prop_p flag.
7834 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
7835 (pop_it): Call iterate_out_of_display_property only if we are
7836 popping after iteration over a string that came from a display
7837 property. Fix a typo in popping stretch info. Add an assertion
7838 for verifying that the iterator position is in sync with the bidi
7840 (handle_single_display_spec, get_overlay_strings_1)
7841 (push_display_prop): Fix initialization of paragraph direction for
7842 string when that of the parent object is not yet determined.
7843 (reseat_1): Call bidi_init_it to resync the bidi
7844 iterator with IT's position. (Bug#7616)
7845 (find_row_edges): If ROW->start.pos gives position
7846 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
7847 (handle_stop, back_to_previous_visible_line_start, reseat_1):
7848 Reset the from_disp_prop_p flag.
7849 (SAVE_IT, RESTORE_IT): New macros.
7850 (pos_visible_p, face_before_or_after_it_pos)
7851 (back_to_previous_visible_line_start)
7852 (move_it_in_display_line_to, move_it_in_display_line)
7853 (move_it_to, move_it_vertically_backward, move_it_by_lines)
7854 (try_scrolling, redisplay_window, display_line): Use them when
7855 saving a temporary copy of the iterator and restoring it back.
7856 (back_to_previous_visible_line_start, reseat_1)
7857 (init_iterator): Empty the bidi cache "stack".
7858 (move_it_in_display_line_to): If iterator ended up at
7859 EOL, but we never saw any buffer positions smaller than
7860 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
7861 motion in bidi-reordered lines.
7862 (move_it_in_display_line_to): Record prev_method and prev_pos
7863 immediately before the call to set_iterator_to_next. Fixes cursor
7864 motion in bidi-reordered lines with stretch glyphs and strings
7865 displayed in margins. (Bug#8133) (Bug#8867)
7866 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
7868 (pos_visible_p): Support positions in bidi-reordered lines.
7869 Save and restore bidi cache.
7871 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
7872 (bidi_paragraph_info): Delete unused struct.
7873 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
7874 (bidi_cache_start): New variable.
7875 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
7877 (bidi_cache_fetch_state, bidi_cache_search)
7878 (bidi_cache_find_level_change, bidi_cache_iterator_state)
7879 (bidi_cache_find, bidi_peek_at_next_level)
7880 (bidi_level_of_next_char, bidi_find_other_level_edge)
7881 (bidi_move_to_visually_next): Compare cache index with
7882 bidi_cache_start rather than with zero.
7883 (bidi_fetch_char): Accept new argument STRING; all callers
7884 changed. Support iteration over a string. Support strings with
7885 display properties. Support unibyte strings. Fix the type of
7886 `len' according to what STRING_CHAR_AND_LENGTH expects.
7887 (bidi_paragraph_init, bidi_resolve_explicit_1)
7888 (bidi_resolve_explicit, bidi_resolve_weak)
7889 (bidi_level_of_next_char, bidi_move_to_visually_next):
7890 Support iteration over a string.
7891 (bidi_set_sor_type, bidi_resolve_explicit_1)
7892 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
7893 can now be zero (for strings); special values 0 and -1 were
7894 changed to -1 and -2, respectively.
7895 (bidi_char_at_pos): New function.
7896 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
7897 Call it instead of FETCH_MULTIBYTE_CHAR.
7898 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
7899 initialized to valid values.
7900 (bidi_init_it): Don't initialize charpos and bytepos with invalid
7902 (bidi_level_of_next_char): Allow the sentinel "position" to pass
7903 the test for valid cached positions. Fix the logic for looking up
7904 the sentinel state in the cache. GCPRO the Lisp string we are
7906 (bidi_push_it, bidi_pop_it): New functions.
7907 (bidi_initialize): Initialize the bidi cache start stack pointer.
7908 (bidi_cache_ensure_space): New function, refactored from part of
7909 bidi_cache_iterator_state. Don't assume the required size is just
7910 one BIDI_CACHE_CHUNK away.
7911 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
7912 (bidi_count_bytes, bidi_char_at_pos): New functions.
7913 (bidi_cache_search): Don't assume bidi_cache_last_idx is
7914 always valid if bidi_cache_idx is valid.
7915 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
7916 is valid if it's going to be used.
7917 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
7918 (bidi_cache_fetch_state, bidi_cache_search)
7919 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7920 (bidi_cache_iterator_state, bidi_cache_find)
7921 (bidi_find_other_level_edge, bidi_cache_start_stack):
7922 All variables related to cache indices are now EMACS_INT.
7924 * dispextern.h (struct bidi_string_data): New structure.
7925 (struct bidi_it): New member `string'. Make flag members be 1-bit
7926 fields, and put them last in the struct.
7927 (compute_display_string_pos, compute_display_string_end):
7929 (bidi_push_it, bidi_pop_it): Add prototypes.
7930 (struct iterator_stack_entry): New members bidi_p,
7931 paragraph_embedding, and from_disp_prop_p.
7932 (struct it): Member bidi_p is now a bit field 1 bit wide.
7933 (bidi_shelve_cache, bidi_unshelve_cache):
7936 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
7937 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
7938 and vector-like objects.
7940 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
7941 cache around display iteration.
7943 * window.c (Fwindow_end, window_scroll_pixel_based)
7944 (displayed_window_lines, Frecenter): Save and restore the bidi
7945 cache around display iteration.
7947 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7949 * editfns.c (Fdelete_region): Clarify the use of the named
7950 parameters (bug#6788).
7952 2011-07-14 Martin Rudalics <rudalics@gmx.at>
7954 * indent.c (Fvertical_motion): Set and restore w->pointm when
7955 saving and restoring the window's buffer (Bug#9006).
7957 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
7959 * editfns.c (Fstring_to_char): Clarify just what is returned
7960 (bug#6576). Text by Eli Zaretskii.
7962 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
7964 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
7966 2011-07-13 Eli Zaretskii <eliz@gnu.org>
7968 * buffer.c (mmap_find): Fix a typo.
7970 2011-07-13 Johan Bockgård <bojohan@gnu.org>
7972 Fix execution of x selection hooks.
7973 * xselect.c (Qx_lost_selection_functions)
7974 (Qx_sent_selection_functions): New vars.
7975 (syms_of_xselect): DEFSYM them.
7976 (x_handle_selection_request): Pass Qx_sent_selection_functions
7977 rather than Vx_sent_selection_functions to Frun_hook_with_args.
7978 (x_handle_selection_clear,x_clear_frame_selections):
7979 Pass Qx_lost_selection_functions rather than
7980 Vx_lost_selection_functions to Frun_hook_with_args.
7982 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
7984 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
7985 The old code sometimes used this field without initializing it.
7987 * alloc.c (gc_sweep): Don't read past end of array.
7988 In theory, the old code could also have corrupted Emacs internals,
7989 though it'd be very unlikely.
7991 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
7993 * character.c (Fcharacterp): Don't advertise optional ignored
7994 argument. (Bug#4026)
7996 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
7998 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
8001 * window.c (Fset_window_start): Doc fix (bug#4199).
8002 (Fset_window_hscroll): Ditto.
8004 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
8006 Fix minor new problems caught by GCC 4.6.1.
8007 * term.c (init_tty): Remove unused local.
8008 * xsettings.c (store_monospaced_changed): Define this function only
8009 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
8012 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
8014 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
8016 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
8018 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
8019 are the mini-buffer and the echo area (bug#3320).
8021 * term.c (init_tty): Remove support for supdup, c10 and perq
8022 terminals, which are no longer supported (bug#1482).
8024 2011-07-10 Johan Bockgård <bojohan@gnu.org>
8026 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
8028 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
8030 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
8031 for non-popups (Bug#3642).
8033 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
8035 * alloc.c (reset_malloc_hooks): Protoize.
8036 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
8037 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
8038 * cm.c (losecursor): Likewise.
8039 * data.c (fmod): Likewise.
8040 * dispnew.c (swap_glyphs_in_rows): Likewise.
8041 * emacs.c (memory_warning_signal): Likewise.
8042 * floatfns.c (float_error): Likewise.
8043 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
8044 (otf_open, font_otf_capability, generate_otf_features)
8045 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
8047 * image.c (pbm_read_file): Likewise.
8048 * indent.c (string_display_width): Likewise.
8049 * intervals.c (check_for_interval, search_for_interval)
8050 (inc_interval_count, count_intervals, root_interval)
8051 (adjust_intervals_for_insertion, make_new_interval): Likewise.
8052 * lread.c (defalias): Likewise.
8053 * ralloc.c (r_alloc_check): Likewise.
8054 * regex.c (set_image_of_range_1, set_image_of_range)
8055 (regex_grow_registers): Likewise.
8056 * sysdep.c (strerror): Likewise.
8057 * termcap.c (valid_filename_p, tprint, main): Likewise.
8058 * tparam.c (main): Likewise.
8059 * unexhp9k800.c (run_time_remap, save_data_space)
8060 (update_file_ptrs, read_header, write_header, calculate_checksum)
8061 (copy_file, copy_rest, display_header): Likewise.
8062 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
8064 * xdisp.c (check_it): Likewise.
8065 * xfaces.c (register_color, unregister_color, unregister_colors):
8067 * xfns.c (print_fontset_result): Likewise.
8068 * xrdb.c (member, fatal, main): Likewise.
8070 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
8072 Fix minor problems found by static checking (Bug#9031).
8073 * chartab.c (char_table_set_range, map_sub_char_table):
8074 Remove unused locals.
8075 (uniprop_table): Now static.
8076 * composite.c (_work_char): Remove unused static var.
8078 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
8080 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
8082 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
8084 * gtkutil.c (qttip_cb): Remove code without function.
8086 2011-07-09 Eli Zaretskii <eliz@gnu.org>
8088 * w32.c (pthread_sigmask): New stub.
8090 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
8092 Use pthread_sigmask, not sigprocmask (Bug#9010).
8093 sigprocmask is portable only for single-threaded applications, and
8094 Emacs can be multi-threaded when it uses GTK.
8095 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
8097 * callproc.c (Fcall_process):
8098 * process.c (create_process):
8099 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
8100 Use pthread_sigmask, not sigprocmask.
8102 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8104 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
8105 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
8108 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8110 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
8111 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
8112 (xg_hide_tooltip): Fix comment.
8114 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
8115 in registerServicesMenuSendTypes.
8116 (validRequestorForSendType): Don't check ns_return_types.
8118 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
8121 2011-07-08 Jason Rumney <jasonr@gnu.org>
8123 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
8124 SH_SHOW for hidden windows (Bug#5482).
8126 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
8127 frame struct members of non-existent frames (Bug#6284).
8129 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8131 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
8132 variable firstTime not needed on OSX >= 10.6.
8133 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
8134 >= 10.5. Use setKnobProportion, setDoubleValue.
8136 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
8137 (MAC_OS_X_VERSION_10_5): Define if not defined.
8138 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
8139 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
8140 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
8142 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
8143 cString and lossyCString on OSX >= 10.4.
8145 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
8146 sizeToFit on OSX >= 10.2.
8148 * nsimage.m (allocInitFromFile): Don't use deprecated method
8149 bestRepresentationForDevice on OSX >= 10.6.
8151 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
8154 * emacs.c: Declare unexec_init_emacs_zone.
8156 * nsgui.h: Fix compiler warning about gnulib redefining verify.
8158 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
8160 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
8161 on svcsMenu (Bug#8842).
8163 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
8165 (Fns_list_services): Just return Qnil on 10.6, code not working there.
8167 * nsterm.m (QUTF8_STRING): Declare.
8168 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
8169 (validRequestorForSendType): Return type is (id).
8170 Change indexOfObjectIdenticalTo to indexOfObject.
8171 Check if we have local selection before returning self (Bug#8842).
8172 (writeSelectionToPasteboard): Put local selection into paste board
8173 if we have a local selection (Bug#8842).
8174 (syms_of_nsterm): DEFSYM QUTF8_STRING.
8176 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
8177 (ns_get_local_selection): Declare.
8179 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
8181 * keymap.c (describe_map_tree): Don't insert a double newline at
8182 the end of the buffer (bug#1169) and return whether we inserted
8185 * callint.c (Fcall_interactively): Change "reading args" to
8186 "providing args" to try to clarify what it does (bug#1010).
8188 2011-07-07 Kenichi Handa <handa@m17n.org>
8190 * composite.c (composition_compute_stop_pos): Ignore a static
8191 composition starting before CHARPOS (Bug#8915).
8193 * xdisp.c (handle_composition_prop): Likewise.
8195 2011-07-07 Eli Zaretskii <eliz@gnu.org>
8197 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
8200 2011-07-07 Kenichi Handa <handa@m17n.org>
8202 * character.h (unicode_category_t): New enum type.
8204 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
8205 (Qchar_code_property_table): New variable.
8206 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
8207 (UNIPROP_COMPRESSED_FORM_P): New macros.
8208 (char_table_ascii): Uncompress the compressed values.
8209 (sub_char_table_ref): New arg is_uniprop. Callers changed.
8210 Uncompress the compressed values.
8211 (sub_char_table_ref_and_range): Likewise.
8212 (char_table_ref_and_range): Uncompress the compressed values.
8213 (sub_char_table_set): New arg is_uniprop. Callers changed.
8214 Uncompress the compressed values.
8215 (sub_char_table_set_range): Args changed. Callers changed.
8216 (char_table_set_range): Adjuted for the above change.
8217 (map_sub_char_table): Delete args default_val and parent. Add arg
8218 top. Give decoded values to a Lisp function.
8219 (map_char_table): Adjust for the above change. Give decoded
8220 values to a Lisp function. Gcpro more variables.
8221 (uniprop_table_uncompress)
8222 (uniprop_decode_value_run_length): New functions.
8223 (uniprop_decoder, uniprop_decoder_count): New variables.
8224 (uniprop_get_decoder, uniprop_encode_value_character)
8225 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
8227 (uniprop_encoder, uniprop_encoder_count): New variables.
8228 (uniprop_get_encoder, uniprop_table)
8229 (Funicode_property_table_internal, Fget_unicode_property_internal)
8230 (Fput_unicode_property_internal): New functions.
8231 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
8232 Sunicode_property_table_internal, Sget_unicode_property_internal,
8233 and Sput_unicode_property_internal. Defvar_lisp
8234 char-code-property-alist.
8236 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
8237 Vunicode_category_table.
8239 * font.c (font_range): Adjust for the change of
8240 Vunicode_category_table.
8242 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
8244 * m/iris4d.h: Remove file, move contents ...
8245 * s/irix6-5.h: ... here.
8247 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
8249 Remove unportable assumption about struct layout (Bug#8884).
8250 * alloc.c (mark_buffer):
8251 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
8252 (clone_per_buffer_values): Don't assume that
8253 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
8254 This isn't true in general, and it's particularly not true
8255 if Emacs is configured with --with-wide-int.
8256 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
8257 New macros, used in the buffer.c change.
8259 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
8261 * xsettings.c: Use both GConf and GSettings if both are available.
8262 (store_config_changed_event): Add comment.
8263 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
8264 (store_tool_bar_style_changed): New functions.
8265 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
8266 (struct xsettings): Move font inside HAVE_XFT.
8267 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
8268 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
8269 Move inside HAVE_XFT.
8270 (something_changed_gsettingsCB): Rename from something_changedCB.
8271 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
8273 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
8274 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
8275 (something_changed_gconfCB): Rename from something_changedCB.
8276 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
8277 (parse_settings): Move check for font inside HAVE_XFT.
8278 (read_settings, apply_xft_settings): Add comment.
8279 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
8280 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
8281 call store_font_name_changed.
8282 (xft_settings_event): Add comment.
8283 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
8284 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
8285 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
8286 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
8287 (xsettings_initialize): Call init_gsettings last.
8288 (xsettings_get_system_font, xsettings_get_system_normal_font):
8291 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
8293 Random fixes. E.g., (random) never returned negative values.
8294 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
8295 subseconds part to the entropy, as that's a bit more random.
8296 Prefer signed to unsigned, since the signedness doesn't matter and
8297 in general we prefer signed. When given a limit, use a
8298 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
8299 latter isn't right if USE_2_TAGS_FOR_INTS.
8300 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
8301 not 0..VALMASK. Don't discard "excess" bits that random () returns.
8303 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
8305 * textprop.c (text_property_stickiness):
8306 Obey Vtext_property_default_nonsticky.
8307 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
8308 * w32fns.c (syms_of_w32fns):
8309 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
8311 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8313 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
8314 This is more efficient than Ffile_directory_p and avoids a minor race.
8316 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
8318 * buffer.c (Foverlay_put): Say what the return value is
8321 * fileio.c (barf_or_query_if_file_exists): Check first if the file
8322 is a directory before asking whether to use the file name
8324 (barf_or_query_if_file_exists): Make the "File is a directory"
8325 error be more correct.
8327 * fns.c (Frequire): Remove the mention of the .gz files, since
8328 that's installation-specific, but keep the mention of
8329 `get-load-suffixes'.
8331 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8333 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
8334 Report string overflow if the output is too long.
8336 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
8338 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
8339 (syms_of_gnutls): Remove duplicate DEFSYM for
8340 Qgnutls_bootprop_verify_hostname_error, an error for
8341 Qgnutls_bootprop_verify_error (which is no longer used).
8343 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
8344 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
8345 Also (re)move comments that are misplaced or no longer relevant.
8347 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8349 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
8351 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
8353 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
8354 and background color parameters if they have been changed.
8356 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8358 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
8360 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
8362 * xsettings.c (SYSTEM_FONT): Define only when used.
8363 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
8365 * keymap.c (access_keymap_1): Now static.
8367 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
8369 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
8370 leave any prefix arg for the up event (Bug#1586).
8372 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
8374 * lread.c (syms_of_lread): Mention single symbols defined by
8375 `defvar' or `defconst' (bug#7154).
8377 * fns.c (Frequire): Mention .el.gz files (bug#7314).
8378 (Frequire): Mention get-load-suffixes.
8380 2011-07-02 Martin Rudalics <rudalics@gmx.at>
8382 * window.h (window): Remove clone_number slot.
8383 * window.c (Fwindow_clone_number, Fset_window_clone_number):
8385 (make_parent_window, make_window, saved_window)
8386 (Fset_window_configuration, save_window_save): Don't deal with
8388 * buffer.c (Qclone_number): Remove declaration.
8389 (sort_overlays, overlay_strings): Don't deal with clone numbers.
8391 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
8393 Add multiple inheritance to keymaps.
8394 * keymap.c (Fmake_composed_keymap): New function.
8395 (Fset_keymap_parent): Simplify.
8396 (fix_submap_inheritance): Remove.
8397 (access_keymap_1): New function extracted from access_keymap to handle
8398 embedded parents and handle lists of maps.
8399 (access_keymap): Use it.
8400 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
8401 (Fcopy_keymap): Handle embedded parents.
8402 (Fcommand_remapping, define_as_prefix): Simplify.
8403 (Fkey_binding): Simplify.
8404 (syms_of_keymap): Move minibuffer-local-completion-map,
8405 minibuffer-local-filename-completion-map,
8406 minibuffer-local-must-match-map, and
8407 minibuffer-local-filename-must-match-map to Elisp.
8408 (syms_of_keymap): Defsubr make-composed-keymap.
8409 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
8410 (parse_menu_item): Trivial simplification.
8412 2011-07-01 Glenn Morris <rgm@gnu.org>
8414 * Makefile.in (SETTINGS_LIBS): Fix typo.
8416 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
8418 * coding.c (Fencode_coding_string): Record the last coding system
8419 used, as the function doc string says (bug#8738).
8421 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
8423 * xsettings.c (store_monospaced_changed): Take new font as arg and
8424 check for change against current_mono_font.
8425 (EMACS_TYPE_SETTINGS): Remove this and related defines.
8426 (emacs_settings_constructor, emacs_settings_get_property)
8427 (emacs_settings_set_property, emacs_settings_class_init)
8428 (emacs_settings_init, gsettings_obj): Remove.
8429 (something_changedCB): New function for HAVE_GSETTINGS.
8430 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
8431 with value as argument.
8432 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
8433 g_settings_new (Bug#8967). Do not create gsettings_obj.
8434 Remove calls to g_settings_bind. Connect something_changedCB to
8437 * xgselect.c: Add defined (HAVE_GSETTINGS).
8438 (xgselect_initialize): Ditto.
8440 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
8441 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
8444 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
8446 * eval.c (struct backtrace): Simplify and port the data structure.
8447 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
8448 signed bit field, as this assumption is not portable and it makes
8449 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
8450 "char debug_on_exit : 1" as this is not portable either; instead,
8451 use the portable "unsigned int debug_on_exit : 1". Remove unused
8452 member evalargs. Remove obsolete comments about cc bombing out.
8454 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
8456 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
8457 Let HAVE_GSETTINGS override HAVE_GCONF.
8458 (store_monospaced_changed): New function.
8459 (EMACS_SETTINGS): A new type derived from GObject to handle
8460 GSettings notifications.
8461 (emacs_settings_constructor, emacs_settings_get_property)
8462 (emacs_settings_set_property, emacs_settings_class_init):
8464 (gsettings_client, gsettings_obj): New variables.
8465 (GSETTINGS_SCHEMA): New define.
8466 (something_changedCB): Call store_monospaced_changed.
8467 (init_gsettings): New function.
8468 (xsettings_initialize): Call init_gsettings.
8469 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
8472 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
8475 2011-06-29 Martin Rudalics <rudalics@gmx.at>
8477 * window.c (resize_root_window, grow_mini_window)
8478 (shrink_mini_window): Rename Qresize_root_window to
8479 Qwindow_resize_root_window and Qresize_root_window_vertically to
8480 Qwindow_resize_root_window_vertically.
8482 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
8484 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
8486 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
8488 * makefile.w32-in: Redesign dependencies so they reflect more
8489 clearly which files are directly included by each source file,
8490 and not through other includes.
8492 2011-06-27 Martin Rudalics <rudalics@gmx.at>
8494 * buffer.c (Qclone_number): Declare static and DEFSYM it.
8495 (sort_overlays, overlay_strings): When an overlay's clone number
8496 matches the window's clone number process the overlay even if
8497 the overlay's window property doesn't match the current window.
8499 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
8500 (Fwindow_hchild): Rename to Fwindow_left_child.
8501 (Fwindow_next): Rename to Fwindow_next_sibling.
8502 (Fwindow_prev): Rename to Fwindow_prev_sibling.
8503 (resize_window_check): Rename to window_resize_check.
8504 (resize_window_apply): Rename to window_resize_apply.
8505 (Fresize_window_apply): Rename to Fwindow_resize_apply.
8506 (Fdelete_other_windows_internal, resize_frame_windows)
8507 (Fsplit_window_internal, Fdelete_window_internal)
8508 (grow_mini_window, shrink_mini_window)
8509 (Fresize_mini_window_internal): Fix callers accordingly.
8511 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
8513 * emacsgtkfixed.h: State that this is only used with Gtk+3.
8514 (emacs_fixed_set_min_size): Remove.
8515 (emacs_fixed_new): Take frame as argument.
8517 * emacsgtkfixed.c: State that this is only used with Gtk+3.
8518 (_EmacsFixedPrivate): Remove minwidth/height.
8519 Add struct frame *f.
8520 (emacs_fixed_init): Initialize priv->f.
8521 (get_parent_class, emacs_fixed_set_min_size): Remove.
8522 (emacs_fixed_new): Set priv->f to argument.
8523 (emacs_fixed_get_preferred_width)
8524 (emacs_fixed_get_preferred_height): Use min_width/height from
8525 frames size_hint to set minimum and natural (Bug#8919).
8526 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
8527 and use min_width/height from frames size_hint to set
8528 min_width/height (Bug#8919).
8530 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
8531 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
8534 2011-06-26 Eli Zaretskii <eliz@gnu.org>
8536 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
8537 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
8540 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
8542 * process.c (wait_reading_process_output): Bypass select if
8543 waiting for a cell while ignoring keyboard input, and input is
8544 pending. Suggested by Jan Djärv (Bug#8869).
8546 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
8548 Use gnulib's dup2 module instead of rolling our own.
8549 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
8551 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8553 * dispnew.c (scrolling_window): Before scrolling, turn off a
8554 mouse-highlight in the window being scrolled.
8556 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
8558 Move DEFSYM to lisp.h and use everywhere.
8560 * character.h (DEFSYM): Move declaration...
8561 * lisp.h (DEFSYM): ...here.
8567 * w32select.c: Don't include character.h.
8569 * alloc.c (syms_of_alloc):
8570 * buffer.c (syms_of_buffer):
8571 * bytecode.c (syms_of_bytecode):
8572 * callint.c (syms_of_callint):
8573 * casefiddle.c (syms_of_casefiddle):
8574 * casetab.c (init_casetab_once):
8575 * category.c (init_category_once, syms_of_category):
8576 * ccl.c (syms_of_ccl):
8577 * cmds.c (syms_of_cmds):
8578 * composite.c (syms_of_composite):
8579 * dbusbind.c (syms_of_dbusbind):
8580 * dired.c (syms_of_dired):
8581 * dispnew.c (syms_of_display):
8582 * doc.c (syms_of_doc):
8583 * editfns.c (syms_of_editfns):
8584 * emacs.c (syms_of_emacs):
8585 * eval.c (syms_of_eval):
8586 * fileio.c (syms_of_fileio):
8587 * fns.c (syms_of_fns):
8588 * frame.c (syms_of_frame):
8589 * fringe.c (syms_of_fringe):
8590 * insdel.c (syms_of_insdel):
8591 * keymap.c (syms_of_keymap):
8592 * lread.c (init_obarray, syms_of_lread):
8593 * macros.c (syms_of_macros):
8594 * msdos.c (syms_of_msdos):
8595 * print.c (syms_of_print):
8596 * process.c (syms_of_process):
8597 * search.c (syms_of_search):
8598 * sound.c (syms_of_sound):
8599 * syntax.c (init_syntax_once, syms_of_syntax):
8600 * terminal.c (syms_of_terminal):
8601 * textprop.c (syms_of_textprop):
8602 * undo.c (syms_of_undo):
8603 * w32.c (globals_of_w32):
8604 * window.c (syms_of_window):
8605 * xdisp.c (syms_of_xdisp):
8606 * xfaces.c (syms_of_xfaces):
8607 * xfns.c (syms_of_xfns):
8608 * xmenu.c (syms_of_xmenu):
8609 * xsettings.c (syms_of_xsettings):
8610 * xterm.c (syms_of_xterm): Use DEFSYM.
8612 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
8614 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
8616 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
8618 Integer and buffer overflow fixes (Bug#8873).
8620 * print.c (printchar, strout): Check for string overflow.
8621 (PRINTPREPARE, printchar, strout):
8622 Don't set size unless allocation succeeds.
8624 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
8625 for sizes. Check for string overflow more accurately.
8626 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
8628 * macros.c: Integer and buffer overflow fixes.
8629 * keyboard.h (struct keyboard.kbd_macro_bufsize):
8630 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
8631 Use ptrdiff_t, not int, for sizes.
8632 Don't increment bufsize until after realloc succeeds.
8633 Check for size-calculation overflow.
8634 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
8636 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
8638 * lread.c: Integer overflow fixes.
8639 (read_integer): Radix is now EMACS_INT, not int,
8640 to improve quality of diagnostics for out-of-range radices.
8641 Calculate buffer size correctly for out-of-range radices.
8642 (read1): Check for integer overflow in radices, and in
8643 read-circle numbers.
8644 (read_escape): Avoid int overflow.
8645 (Fload, openp, read_buffer_size, read1)
8646 (substitute_object_recurse, read_vector, read_list, map_obarray):
8647 Use ptrdiff_t, not int, for sizes.
8648 (read1): Use EMACS_INT, not int, for sizes.
8649 Check for size overflow.
8651 * image.c (cache_image): Check for size arithmetic overflow.
8653 * lread.c: Integer overflow issues.
8654 (saved_doc_string_size, saved_doc_string_length)
8655 (prev_saved_doc_string_size, prev_saved_doc_string_length):
8656 Now ptrdiff_t, not int.
8657 (read1): Don't assume doc string length fits in int. Check for
8658 out-of-range doc string lengths.
8659 (read_list): Don't assume file position fits in int.
8660 (read_escape): Check for hex character overflow.
8662 2011-06-22 Leo Liu <sdl.web@gmail.com>
8664 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
8665 Move to minibuffer.el.
8667 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8669 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
8670 The following patches are for when GLYPH_DEBUG && !XASSERT.
8671 * dispextern.h (trace_redisplay_p, dump_glyph_string):
8672 * dispnew.c (flush_stdout):
8673 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
8674 Mark as externally visible.
8675 * dispnew.c (check_window_matrix_pointers): Now static.
8676 * dispnew.c (window_to_frame_vpos):
8677 * xfns.c (unwind_create_frame):
8678 * xterm.c (x_check_font): Remove unused local.
8679 * scroll.c (CHECK_BOUNDS):
8680 * xfaces.c (cache_fache): Rename local to avoid shadowing.
8681 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
8682 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
8683 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
8684 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
8686 (debug_method_add): Use va_list and vsprintf rather than relying
8687 on undefined behavior with wrong number of arguments.
8688 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
8689 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
8690 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
8691 since we're not interested in debugging glyphs with old libraries.
8692 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
8693 GCC 4.6.0's static checking.
8695 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8697 Integer overflow and signedness fixes (Bug#8873).
8698 A few related buffer overrun fixes, too.
8700 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
8702 * dispextern.h (struct face.stipple):
8703 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
8704 (x_bitmap_mask, x_allocate_bitmap_record)
8705 (x_create_bitmap_from_data, x_create_bitmap_from_file)
8706 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
8707 (x_create_bitmap_from_xpm_data):
8708 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
8709 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
8711 * xfaces.c (load_pixmap):
8712 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
8713 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
8714 (.bitmaps_last, struct x_output.icon_bitmap):
8715 Use ptrdiff_t, not int, for bitmap indexes.
8716 (x_allocate_bitmap_record): Check for size overflow.
8717 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
8719 Use ptrdiff_t, not int, for overlay counts.
8720 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
8721 * editfns.c (overlays_around, get_pos_property):
8722 * textprop.c (get_char_property_and_overlay):
8723 * xdisp.c (next_overlay_change, note_mouse_highlight):
8724 * xfaces.c (face_at_buffer_position):
8725 * buffer.c (OVERLAY_COUNT_MAX): New macro.
8726 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
8727 (Fnext_overlay_change, Fprevious_overlay_change)
8728 (mouse_face_overlay_overlaps, Foverlays_in):
8729 Use ptrdiff_t, not int, for sizes.
8730 (overlays_at, overlays_in): Check for size-calculation overflow.
8732 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
8734 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
8735 (x_session_initialize): Do not assume string length fits in int.
8737 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
8738 This is unlikely, but can occur if DPI is outlandish.
8740 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
8741 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
8743 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
8744 * xrdb.c (magic_file_p, search_magic_path):
8745 Omit last arg SUFFIX; it was always 0. All callers changed.
8746 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
8748 * xfont.c (xfont_match): Avoid need for strlen.
8750 * xfns.c: Don't assume strlen fits in int.
8751 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
8753 * xdisp.c (message_log_check_duplicate): Return intmax_t,
8754 not unsigned long, as we prefer signed integers. All callers changed.
8755 Detect integer overflow in repeat count.
8756 (message_dolog): Don't assume print length fits in 39 bytes.
8757 (display_mode_element): Don't assume strlen fits in int.
8759 * termcap.c: Don't assume sizes fit in int and never overflow.
8760 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
8761 (gobble_line): Check for size-calculation overflow.
8763 * minibuf.c (Fread_buffer):
8764 * lread.c (intern, intern_c_string):
8765 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
8766 Don't assume string length fits in int.
8768 * keyboard.c (parse_tool_bar_item):
8769 * gtkutil.c (style_changed_cb): Avoid need for strlen.
8771 * font.c: Don't assume string length fits in int.
8772 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
8773 Use ptrdiff_t, not int.
8774 (font_intern_prop): Don't assume string length fits in int.
8775 Don't assume integer property fits in fixnum.
8776 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
8778 * filelock.c: Fix some buffer overrun and integer overflow issues.
8779 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
8780 Reformulate so as not to need the command string.
8781 Invoke gzip -cd rather than gunzip, as it's more portable.
8782 (lock_info_type, lock_file_1, lock_file):
8783 Don't assume pid_t and time_t fit in unsigned long.
8784 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
8785 (current_lock_owner): Prefer signed type for sizes.
8786 Use memcpy, not strncpy, where memcpy is what is really wanted.
8787 Don't assume (via atoi) that time_t and pid_t fit in int.
8788 Check for time_t and/or pid_t out of range, e.g., via a network share.
8789 Don't alloca where an auto var works fine.
8791 * fileio.c: Fix some integer overflow issues.
8792 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
8793 Don't assume string length fits in int.
8794 (directory_file_name): Don't assume string length fits in long.
8795 (make_temp_name): Don't assume pid fits in int, or that its print
8796 length is less than 20.
8798 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
8800 * coding.c (make_subsidiaries): Don't assume string length fits in int.
8802 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
8804 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
8805 We prefer signed integers, even for size calculations.
8807 * emacs.c: Don't assume string length fits in 'int'.
8808 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
8809 (main): Don't invoke strlen when not needed.
8811 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
8812 (XD_DEBUG_MESSAGE): Don't waste a byte.
8814 * callproc.c (getenv_internal_1, getenv_internal)
8816 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
8818 * lread.c (invalid_syntax): Omit length argument.
8819 All uses changed. This doesn't fix a bug, but it simplifies the
8820 code away from its former Hollerith-constant appearance, and it's
8821 one less 'int' to worry about when looking at integer-overflow issues.
8822 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
8824 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
8825 This didn't break anything, but it didn't help either.
8826 It's confusing to put a bogus integer in a place where the actual
8827 value does not matter.
8828 (LIST_END_P): Remove unused macro and its bogus comment.
8829 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
8831 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
8832 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
8834 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
8835 We prefer signed types, and the value cannot exceed the EMACS_INT
8836 range anyway (because otherwise the length would not be representable).
8837 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
8838 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
8839 This avoids a GCC warning when WIDE_EMACS_INT.
8841 * indent.c (sane_tab_width): New function.
8842 (current_column, scan_for_column, Findent_to, position_indentation)
8843 (compute_motion): Use it. This is just for clarity.
8844 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
8846 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
8848 * lisp.h (lint_assume): New macro.
8849 * composite.c (composition_gstring_put_cache):
8850 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
8852 * editfns.c, insdel.c:
8853 Omit unnecessary forward decls, to simplify future changes.
8855 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
8857 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
8859 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
8860 Use much-faster test for byte-length change.
8861 Don't assume string byte-length fits in 'int'.
8862 Check that character arg fits in 'int'.
8863 (mapcar1): Declare byte as byte, for clarity.
8865 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
8867 * fns.c (concat): Catch string overflow earlier.
8868 Do not rely on integer wraparound.
8870 * dispextern.h (struct it.overlay_strings_charpos)
8871 (struct it.selective): Now EMACS_INT, not int.
8872 * xdisp.c (forward_to_next_line_start)
8873 (back_to_previous_visible_line_start)
8874 (reseat_at_next_visible_line_start, next_element_from_buffer):
8875 Don't arbitrarily truncate the value of 'selective' to int.
8877 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
8879 * composite.c: Don't truncate sizes to 'int'.
8880 (composition_gstring_p, composition_reseat_it)
8881 (composition_adjust_point): Use EMACS_INT, not int.
8882 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
8883 not EMACS_UINT, for indexes.
8885 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
8887 * buffer.c: Include <verify.h>.
8888 (struct sortvec.priority, struct sortstr.priority):
8889 Now EMACS_INT, not int.
8890 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
8891 (struct sortstr.size, record_overlay_string)
8892 (struct sortstrlist.size, struct sortlist.used):
8893 Don't truncate size to int.
8894 (record_overlay_string): Check for size-calculation overflow.
8895 (init_buffer_once): Check at compile-time, not run-time.
8897 2011-06-22 Jim Meyering <meyering@redhat.com>
8899 Don't leak an XBM-image-sized buffer
8900 * image.c (xbm_load): Free the image buffer after using it.
8902 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
8905 * composite.c (find_automatic_composition): Omit needless 'return 0;'
8906 that Sun C diagnosed.
8907 * fns.c (secure_hash): Fix pointer signedness issue.
8908 * intervals.c (static_offset_intervals): New function.
8909 (offset_intervals): Use it.
8911 2011-06-21 Leo Liu <sdl.web@gmail.com>
8914 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
8917 * fns.c (secure_hash): Rename from crypto_hash_function and change
8918 the first arg to accept symbols.
8919 (Fsecure_hash): New primitive.
8920 (syms_of_fns): New symbols.
8922 2011-06-20 Deniz Dogan <deniz@dogan.se>
8924 * process.c (Fset_process_buffer): Clarify return value in
8927 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
8929 * dispnew.c (add_window_display_history): Use BVAR.
8931 * xdisp.c (debug_method_add): Use BVAR.
8932 (check_window_end, dump_glyph_matrix, dump_glyph)
8933 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
8935 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
8938 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
8939 check till after the cache is created in init_frame_faces.
8941 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
8943 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
8945 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
8947 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
8948 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
8949 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
8951 Improve buffer-overflow checking (Bug#8873).
8952 * fileio.c (Finsert_file_contents):
8953 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
8954 Remove the old (too-loose) buffer overflow checks.
8955 They weren't needed, since make_gap checks for buffer overflow.
8956 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
8957 The old code merely checked for Emacs fixnum overflow, and relied
8958 on undefined (wraparound) behavior. The new code avoids undefined
8959 behavior, and also checks for ptrdiff_t and/or size_t overflow.
8961 * editfns.c (Finsert_char): Don't dump core with very negative counts.
8962 Tune. Don't use wider integers than needed. Don't use alloca.
8963 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
8965 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
8967 * insdel.c, lisp.h (buffer_overflow): New function.
8968 (insert_from_buffer_1, replace_range, replace_range_2):
8969 * insdel.c (make_gap_larger):
8970 * editfns.c (Finsert_char):
8971 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
8973 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
8975 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
8977 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
8979 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
8980 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
8982 * fileio.c: Don't assume EMACS_INT fits in off_t.
8983 (emacs_lseek): New static function.
8984 (Finsert_file_contents, Fwrite_region): Use it.
8985 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
8987 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
8989 * fns.c: Don't overflow int when computing a list length.
8990 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
8991 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
8992 truncation on 64-bit hosts. Check for QUIT every
8993 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
8994 faster and is responsive enough.
8995 (Flength): Report an error instead of overflowing an integer.
8996 (Fsafe_length): Return a float if the value is not representable
8997 as a fixnum. This shouldn't happen except in contrived situations.
8998 (Fnthcdr, Fsort): Don't assume list length fits in int.
8999 (Fcopy_sequence): Don't assume vector length fits in int.
9001 * alloc.c: Check that resized vectors' lengths fit in fixnums.
9002 (header_size, word_size): New constants.
9003 (allocate_vectorlike): Don't check size overflow here.
9004 (allocate_vector): Check it here instead, since this is the only
9005 caller of allocate_vectorlike that could cause overflow.
9006 Check that the new vector's length is representable as a fixnum.
9008 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
9009 The previous code was bogus. For example, next_almost_prime (32)
9010 returned 39, which is undesirable as it is a multiple of 3; and
9011 next_almost_prime (24) returned 25, which is a multiple of 5 so
9012 why was the code bothering to check for multiples of 7?
9014 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
9016 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
9018 Variadic C functions now count arguments with ptrdiff_t.
9019 This partly undoes my 2011-03-30 change, which replaced int with size_t.
9020 Back then I didn't know that the Emacs coding style prefers signed int.
9021 Also, in the meantime I found a few more instances where arguments
9022 were being counted with int, which may truncate counts on 64-bit
9023 machines, or EMACS_INT, which may be unnecessarily wide.
9024 * lisp.h (struct Lisp_Subr.function.aMANY)
9025 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
9026 Arg counts are now ptrdiff_t, not size_t.
9027 All variadic functions and their callers changed accordingly.
9028 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
9029 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
9030 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
9031 * callint.c (Fcall_interactively): Check arg count for overflow,
9032 to avoid potential buffer overrun. Use signed char, not 'int',
9033 for 'varies' array, so that we needn't bother to check its size
9034 calculation for overflow.
9035 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
9036 * eval.c (apply_lambda):
9037 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
9038 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
9039 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
9041 * callint.c (Fcall_interactively): Don't use index var as event count.
9043 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
9044 * mem-limits.h (SIZE): Remove; no longer used.
9046 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
9048 Remove unnecessary casts.
9049 * xterm.c (x_term_init):
9050 * xfns.c (x_set_border_pixel):
9051 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
9052 These aren't needed now that we assume ANSI C.
9054 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
9055 It's more likely to cause problems (due to unsigned overflow)
9058 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
9060 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
9062 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
9064 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
9066 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
9068 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
9070 GLYPH_CODE_FACE returns EMACS_INT, not int.
9071 * dispextern.h (merge_faces):
9072 * xfaces.c (merge_faces):
9073 * xdisp.c (get_next_display_element, next_element_from_display_vector):
9074 Don't assume EMACS_INT fits in int.
9076 * character.h (CHAR_VALID_P): Remove unused parameter.
9077 * fontset.c, lisp.h, xdisp.c: All uses changed.
9079 * editfns.c (Ftranslate_region_internal): Omit redundant test.
9081 * fns.c (concat): Minor tuning based on overflow analysis.
9082 This doesn't fix any bugs. Use int to hold character, instead
9083 of constantly refetching from Emacs object. Use XFASTINT, not
9084 XINT, for value known to be a character. Don't bother comparing
9085 a single byte to 0400, as it's always less.
9087 * floatfns.c (Fexpt):
9088 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
9090 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
9093 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
9095 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
9096 Without this fix, on a 64-bit host (aset S 0 4294967386) would
9097 incorrectly succeed when S was a string, because 4294967386 was
9098 truncated before it was used.
9100 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
9101 Otherwise, an out-of-range integer could cause undefined behavior
9104 * composite.c: Use int, not EMACS_INT, for characters.
9105 (fill_gstring_body, composition_compute_stop_pos): Use int, not
9106 EMACS_INT, for values that are known to be in character range.
9107 This doesn't fix any bugs but is the usual style inside Emacs and
9108 may generate better code on 32-bit machines.
9110 Make sure a 64-bit char is never passed to ENCODE_CHAR.
9111 This is for reasons similar to the recent CHAR_STRING fix.
9112 * charset.c (Fencode_char): Check that character arg is actually
9113 a character. Pass an int to ENCODE_CHAR.
9114 * charset.h (ENCODE_CHAR): Verify that the character argument is no
9115 wider than 'int', as a compile-time check to prevent future regressions
9118 * character.c (char_string): Remove unnecessary casts.
9120 Make sure a 64-bit char is never passed to CHAR_STRING.
9121 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
9122 by silently ignoring the top 32 bits, allowing some values
9123 that were far too large to be valid characters.
9124 * character.h: Include <verify.h>.
9125 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
9126 arguments are no wider than unsigned, as a compile-time check
9127 to prevent future regressions in this area.
9129 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
9130 (Fsubst_char_in_region):
9132 * xdisp.c (decode_mode_spec_coding):
9133 Adjust to CHAR_STRING's new requirement.
9134 * editfns.c (Finsert_char, Fsubst_char_in_region):
9135 * fns.c (concat): Check that character args are actually
9136 characters. Without this test, these functions did the wrong
9137 thing with wildly out-of-range values on 64-bit hosts.
9139 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
9140 These casts should not be needed on 32-bit hosts, either.
9141 * keyboard.c (read_char):
9142 * lread.c (Fload): Remove casts to unsigned.
9144 * lisp.h (UNSIGNED_CMP): New macro.
9145 This fixes comparison bugs on 64-bit hosts.
9146 (ASCII_CHAR_P): Use it.
9147 * casefiddle.c (casify_object):
9148 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
9149 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
9150 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
9151 * dispextern.h (FACE_FROM_ID):
9152 * keyboard.c (read_char): Use UNSIGNED_CMP.
9154 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
9155 not to EMACS_INT, to avoid GCC warning.
9157 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
9159 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
9160 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
9161 isn't needed on 32-bit machines.
9163 * buffer.c (Fgenerate_new_buffer_name):
9164 Use EMACS_INT for count, not int.
9165 (advance_to_char_boundary): Return EMACS_INT, not int.
9167 * data.c (Qcompiled_function): Now static.
9169 * window.c (window_body_lines): Now static.
9171 * image.c (gif_load): Rename local to avoid shadowing.
9173 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
9174 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
9175 * alloc.c (make_save_value): Integer argument is now of type
9177 (mark_object): Use ptrdiff_t, not int.
9178 * lisp.h (pD): New macro.
9179 * print.c (print_object): Use it.
9181 * alloc.c: Use EMACS_INT, not int, to count objects.
9182 (total_conses, total_markers, total_symbols, total_vector_size)
9183 (total_free_conses, total_free_markers, total_free_symbols)
9184 (total_free_floats, total_floats, total_free_intervals)
9185 (total_intervals, total_strings, total_free_strings):
9186 Now EMACS_INT, not int. All uses changed.
9187 (Fgarbage_collect): Compute overall total using a double, so that
9188 integer overflow is less likely to be a problem. Check for overflow
9189 when converting back to an integer.
9190 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
9191 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
9192 These were 'int' variables that could overflow on 64-bit hosts;
9193 they were never used, so remove them instead of repairing them.
9194 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
9195 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
9196 Previously, this ceilinged at INT_MAX, but that doesn't work on
9198 (allocate_pseudovector): Don't use EMACS_INT when int would do.
9200 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
9201 (allocate_vectorlike): Check for ptrdiff_t overflow.
9202 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
9203 when a (possibly-narrower) signed value would do just as well.
9204 We prefer using signed arithmetic, to avoid comparison confusion.
9206 * alloc.c: Catch some string size overflows that we were missing.
9207 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
9208 for convenience in STRING_BYTES_MAX.
9209 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
9210 The definition here is exact; the one in lisp.h was approximate.
9211 (allocate_string_data): Check for string overflow. This catches
9212 some instances we weren't catching before. Also, it catches
9213 size_t overflow on (unusual) hosts where SIZE_MAX <= min
9214 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
9215 and ptrdiff_t and EMACS_INT are both 64 bits.
9217 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
9218 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
9219 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
9221 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
9223 * alloc.c (Fmake_string): Check for out-of-range init.
9225 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
9227 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
9229 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
9231 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
9232 xg_get_default_scrollbar_width.
9234 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
9235 (int_gtk_range_get_value): Move to the scroll bar part of the file.
9236 (style_changed_cb): Call update_theme_scrollbar_width and call
9237 x_set_scroll_bar_default_width and xg_frame_set_char_size for
9238 all frames (Bug#8505).
9239 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
9240 Call gtk_window_set_resizable if HAVE_GTK3.
9241 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
9242 and height if HAVE_GTK3 (Bug#8505).
9243 (scroll_bar_width_for_theme): New variable.
9244 (update_theme_scrollbar_width): New function.
9245 (xg_get_default_scrollbar_width): Move code to
9246 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
9247 (xg_initialize): Call update_theme_scrollbar_width.
9249 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
9251 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
9253 2011-06-12 Martin Rudalics <rudalics@gmx.at>
9255 * frame.c (make_frame): Call other_buffer_safely instead of
9258 * window.c (temp_output_buffer_show): Call display_buffer with
9259 second argument Vtemp_buffer_show_specifiers and reset latter
9260 immediately after the call.
9261 (Vtemp_buffer_show_specifiers): New variable.
9262 (auto_window_vscroll_p, next_screen_context_lines)
9263 (Vscroll_preserve_screen_position): Remove leading asterisks from
9266 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
9268 Fix minor problems found by GCC 4.6.0 static checking.
9269 * buffer.c (Qclone_number): Remove for now, as it's unused.
9270 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
9271 (record_buffer): Remove unused local.
9272 * frame.c (other_visible_frames, frame_buffer_list): Now static.
9273 (set_frame_buffer_list): Remove; unused.
9274 * frame.h (other_visible_frames): Remove decl.
9275 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
9276 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
9277 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
9279 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
9280 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
9281 Define only if HAVE_GPM.
9282 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
9283 (update_hints_inhibit): Remove; never set. All uses removed.
9284 * widgetprv.h (emacsFrameClassRec): Remove decl.
9285 * window.c (delete_deletable_window): Now returns void, since it
9286 wasn't returning anything.
9287 (compare_window_configurations): Remove unused locals.
9288 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
9289 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
9290 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
9291 the same widths as pointers. This follows up on the 2011-05-06 patch.
9292 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
9293 * xterm.h: Likewise.
9294 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
9296 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
9298 * makefile.w32-in: Update dependencies.
9299 (LISP_H): Add lib/intprops.h.
9301 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
9303 * image.c (gif_load): Add animation frame delay to the metadata.
9304 (syms_of_image): Use DEFSYM. New symbol `delay'.
9306 2011-06-11 Martin Rudalics <rudalics@gmx.at>
9308 * window.c (delete_deletable_window): Re-add.
9309 (Fset_window_configuration): Rewrite to handle dead buffers and
9310 consequently deletable windows.
9311 (window_tree, Fwindow_tree): Remove. Supply functionality in
9313 (compare_window_configurations): Simplify code.
9315 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
9317 * image.c (imagemagick_load_image): Fix type mismatch.
9318 (Fimagemagick_types): Likewise.
9320 * window.h (replace_buffer_in_windows): Declare.
9322 2011-06-11 Martin Rudalics <rudalics@gmx.at>
9324 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
9325 Qclone_number. Remove external declaration of Qdelete_window.
9326 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
9328 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
9329 Run Qbuffer_list_update_hook if allowed.
9330 (Fother_buffer): Rewrite doc-string. Major rewrite for new
9331 buffer list implementation.
9332 (other_buffer_safely): New function.
9333 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
9334 calls to replace_buffer_in_windows and
9335 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
9337 (record_buffer): Inhibit quitting and rewrite using quittable
9338 functions. Run Qbuffer_list_update_hook if allowed.
9339 (Frecord_buffer, Funrecord_buffer): New functions.
9340 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
9341 Move switch-to-buffer to window.el.
9342 (bury-buffer): Move to window.el.
9343 (Vbuffer_list_update_hook): New variable.
9345 * lisp.h (other_buffer_safely): Add prototype in buffer.c
9348 * window.h (resize_frame_windows): Move up in code.
9349 (Fwindow_frame): Remove EXFUN.
9350 (replace_buffer_in_all_windows): Remove prototype.
9351 (replace_buffer_in_windows_safely): Add prototype.
9353 * window.c: Declare Qdelete_window static again. Move down
9354 declaration of select_count.
9355 (Fnext_window, Fprevious_window): Rewrite doc-strings.
9356 (Fother_window): Move to window.el.
9357 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
9358 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
9359 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
9361 (replace_buffer_in_windows): Implement by calling
9362 Qreplace_buffer_in_windows.
9363 (replace_buffer_in_all_windows): Remove with some functionality
9364 moved into replace_buffer_in_windows_safely.
9365 (replace_buffer_in_windows_safely): New function.
9366 (select_window_norecord, select_frame_norecord): Move in front
9367 of run_window_configuration_change_hook. Remove now obsolete
9369 (Fset_window_buffer): Rewrite doc-string.
9370 Call Qrecord_window_buffer.
9371 (keys_of_window): Move binding for other-window to window.el.
9373 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
9375 * dispextern.h (struct image): Replace data member, whose int_val
9376 and ptr_val fields were not used by anything, with a single
9379 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
9380 (gif_clear_image, gif_load, imagemagick_load_image)
9381 (gs_clear_image, gs_load): Callers changed.
9383 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
9385 * buffer.h: Include <time.h>, for time_t.
9386 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
9388 Fix minor problems found by static checking.
9390 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
9392 Make identifiers static if they are not used in other modules.
9393 * data.c (Qcompiled_function, Qframe, Qvector):
9394 * image.c (QimageMagick, Qsvg):
9395 * minibuf.c (Qmetadata):
9396 * window.c (resize_window_check, resize_root_window): Now static.
9397 * window.h (resize_window_check, resize_root_window): Remove decls.
9399 * window.c (window_deletion_count, delete_deletable_window):
9401 (window_body_lines): Now static.
9402 (Fdelete_other_windows_internal): Mark vars as initialized.
9403 Make sure 'resize_failed' is initialized.
9404 (run_window_configuration_change_hook): Rename local to avoid shadowing.
9405 (resize_window_apply): Remove unused local.
9406 * window.h (delete_deletable_window): Remove decl.
9408 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
9409 (imagemagick_load_image): Fix pointer signedness problem by changing
9410 last arg from unsigned char * to char *. All uses changed.
9411 Also, fix a local for similar reasons.
9412 Remove unused locals. Remove locals to avoid shadowing.
9413 (fn_rsvg_handle_free): Remove; unused.
9414 (svg_load, svg_load_image): Fix pointer signedness problem.
9415 (imagemagick_load_image): Don't use garbage pointer image_wand.
9417 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
9419 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
9421 * image.c (gif_load): Fix omitted cast error introduced by
9424 2011-06-10 Martin Rudalics <rudalics@gmx.at>
9426 * window.h (resize_proportionally, orig_total_lines)
9427 (orig_top_line): Remove from window structure.
9428 (set_window_height, set_window_width, change_window_heights)
9429 (Fdelete_window): Remove prototypes.
9430 (resize_frame_windows): Remove duplicate declaration.
9432 2011-06-10 Eli Zaretskii <eliz@gnu.org>
9434 * window.h (resize_frame_windows, resize_window_check)
9435 (delete_deletable_window, resize_root_window)
9436 (resize_frame_windows): Declare prototypes.
9438 * window.c (resize_window_apply): Make definition be "static" to
9439 match the prototype.
9441 2011-06-10 Martin Rudalics <rudalics@gmx.at>
9443 * window.c: Remove declarations of Qwindow_size_fixed,
9444 window_min_size_1, window_min_size_2, window_min_size,
9445 size_window, window_fixed_size_p, enlarge_window, delete_window.
9446 Remove static from declaration of Qdelete_window, it's
9447 temporarily needed by Fbury_buffer.
9448 (replace_window): Don't assign orig_top_line and
9450 (Fdelete_window, delete_window): Remove. Window deletion is
9451 handled by window.el.
9452 (window_loop): Remove DELETE_OTHER_WINDOWS case.
9453 Replace Fdelete_window calls with calls to Qdelete_window.
9454 (Fdelete_other_windows): Remove. Deleting other windows is
9455 handled by window.el.
9456 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
9457 handled in window.el.
9458 (window_min_size_2, window_min_size_1, window_min_size): Remove.
9459 Window minimum sizes are handled in window.el.
9460 (shrink_windows, size_window, set_window_height)
9461 (set_window_width, change_window_heights, window_height)
9462 (window_width, CURBEG, CURSIZE, enlarge_window)
9463 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
9464 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
9465 handled in window.el.
9466 (make_dummy_parent): Rename to make_parent_window and give it a
9467 second argument horflag.
9468 (make_window): Don't set resize_proportionally any more.
9469 (Fsplit_window): Remove. Windows are split in window.el.
9470 (save_restore_action, save_restore_orig_size)
9471 (shrink_window_lowest_first, save_restore_orig_size): Remove.
9472 Resize mini windows in window.el.
9473 (grow_mini_window, shrink_mini_window): Implement by calling
9474 Qresize_root_window_vertically, resize_window_check and
9475 resize_window_apply.
9476 (saved_window, Fset_window_configuration, save_window_save):
9477 Do not handle orig_top_line, orig_total_lines, and
9478 resize_proportionally.
9479 (window_min_height, window_min_width): Move to window.el.
9480 (keys_of_window): Move bindings for delete-other-windows,
9481 split-window, delete-window and enlarge-window to window.el.
9483 * buffer.c: Temporarily extern Qdelete_window.
9484 (Fbury_buffer): Temporarily call Qdelete_window instead of
9485 Fdelete_window (Fbury_buffer will move to window.el soon).
9487 * frame.c (set_menu_bar_lines_1): Remove code handling
9488 orig_top_line and orig_total_lines.
9490 * dispnew.c (adjust_frame_glyphs_initially): Don't use
9491 set_window_height but set heights directly.
9492 (change_frame_size_1): Use resize_frame_windows.
9494 * xdisp.c (init_xdisp): Don't use set_window_height but set
9497 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
9498 Use resize_frame_windows instead of change_window_heights and run
9499 run_window_configuration_change_hook.
9501 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
9502 instead of change_window_heights and run
9503 run_window_configuration_change_hook.
9505 2011-06-09 Martin Rudalics <rudalics@gmx.at>
9507 * window.c (replace_window): Rename second argument REPLACEMENT to
9508 NEW. New third argument SETFLAG. Rewrite.
9509 (delete_window, make_dummy_parent): Call replace_window with
9511 (window_list_1): Move down in code.
9512 (run_window_configuration_change_hook): Move set_buffer part
9513 before select_frame_norecord part in order to unwind correctly.
9514 Rename count1 to count.
9515 (recombine_windows, delete_deletable_window, resize_root_window)
9516 (Fdelete_other_windows_internal)
9517 (Frun_window_configuration_change_hook, make_parent_window)
9518 (resize_window_check, resize_window_apply, Fresize_window_apply)
9519 (resize_frame_windows, Fsplit_window_internal)
9520 (Fdelete_window_internal, Fresize_mini_window_internal):
9522 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
9524 2011-06-08 Martin Rudalics <rudalics@gmx.at>
9526 * window.h (window): Add some new members to window structure -
9527 normal_lines, normal_cols, new_total, new_normal, clone_number,
9528 splits, nest, prev_buffers, next_buffers.
9529 (WINDOW_TOTAL_SIZE): Move here from window.c.
9530 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
9532 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
9534 (make_dummy_parent): Set new members of windows structure.
9535 (make_window): Move down in code. Handle new members of window
9537 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
9538 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
9539 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
9540 (Fset_window_prev_buffers, Fwindow_next_buffers)
9541 (Fset_window_next_buffers, Fset_window_clone_number):
9543 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
9544 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
9546 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
9547 Argument WINDOW can be now internal window too.
9548 (Fwindow_use_time): Move up in code.
9549 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
9551 (Fset_window_configuration, saved_window)
9552 (Fcurrent_window_configuration, save_window_save): Handle new
9553 members of window structure.
9554 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
9555 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
9556 (syms_of_window): New Lisp objects Qrecord_window_buffer,
9557 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
9558 Qget_mru_window, Qresize_root_window,
9559 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
9560 Qauto_buffer_name; staticpro them.
9562 2011-06-07 Martin Rudalics <rudalics@gmx.at>
9564 * window.c (Fwindow_total_size, Fwindow_left_column)
9565 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
9566 (Fwindow_list_1): New functions.
9567 (window_box_text_cols): Replace with window_body_cols.
9568 (Fwindow_width, Fscroll_left, Fscroll_right):
9569 Use window_body_cols instead of window_box_text_cols.
9570 (delete_window, Fset_window_configuration):
9571 Call delete_all_subwindows with window as argument.
9572 (delete_all_subwindows): Take a window as argument and not a
9574 (window_loop): Remove handling of GET_LRU_WINDOW and
9576 (Fget_lru_window, Fget_largest_window): Move to window.el.
9578 * window.h: Extern window_body_cols instead of
9579 window_box_text_cols. delete_all_subwindows now takes a
9580 Lisp_Object as argument.
9582 * indent.c (compute_motion, Fcompute_motion):
9583 Use window_body_cols instead of window_box_text_cols.
9585 * frame.c (delete_frame): Call delete_all_subwindows with root
9588 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
9590 * fns.c (Fputhash): Document return value.
9592 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
9594 * image.c (gif_load): Implement gif89a spec "no disposal" method.
9596 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9598 Cons<->int and similar integer overflow fixes (Bug#8794).
9600 Check for overflow when converting integer to cons and back.
9601 * charset.c (Fdefine_charset_internal, Fdecode_char):
9602 Use cons_to_unsigned to catch overflow.
9603 (Fencode_char): Use INTEGER_TO_CONS.
9604 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
9605 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
9606 * data.c (long_to_cons, cons_to_long): Remove.
9607 (cons_to_unsigned, cons_to_signed): New functions.
9608 These signal an error for invalid or out-of-range values.
9609 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
9610 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
9611 * font.c (Ffont_variation_glyphs):
9612 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
9613 * lisp.h: Include <intprops.h>.
9614 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
9615 (cons_to_signed, cons_to_unsigned): New decls.
9616 (long_to_cons, cons_to_long): Remove decls.
9617 * undo.c (record_first_change): Use INTEGER_TO_CONS.
9618 (Fprimitive_undo): Use CONS_TO_INTEGER.
9619 * xfns.c (Fx_window_property): Likewise.
9620 * xselect.c: Include <limits.h>.
9621 (x_own_selection, selection_data_to_lisp_data):
9622 Use INTEGER_TO_CONS.
9623 (x_handle_selection_request, x_handle_selection_clear)
9624 (x_get_foreign_selection, Fx_disown_selection_internal)
9625 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
9626 (lisp_data_to_selection_data): Use cons_to_unsigned.
9627 (x_fill_property_data): Use cons_to_signed.
9628 Report values out of range.
9630 Check for buffer and string overflow more precisely.
9631 * buffer.h (BUF_BYTES_MAX): New macro.
9632 * lisp.h (STRING_BYTES_MAX): New macro.
9633 * alloc.c (Fmake_string):
9634 * character.c (string_escape_byte8):
9635 * coding.c (coding_alloc_by_realloc):
9636 * doprnt.c (doprnt):
9637 * editfns.c (Fformat):
9639 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
9640 since they may not be the same number.
9641 * editfns.c (Finsert_char):
9642 * fileio.c (Finsert_file_contents):
9643 Likewise for BUF_BYTES_MAX.
9645 * image.c: Use ptrdiff_t, not int, for sizes.
9646 (slurp_file): Switch from int to ptrdiff_t.
9648 (slurp_file): Check that file size fits in both size_t (for
9649 malloc) and ptrdiff_t (for sanity and safety).
9651 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
9652 if b->modtime has its maximal value.
9654 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
9656 Don't assume time_t can fit into int.
9657 * buffer.h (struct buffer.modtime): Now time_t, not int.
9658 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
9659 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
9661 Minor fixes for signed vs unsigned integers.
9662 * character.h (MAYBE_UNIFY_CHAR):
9663 * charset.c (maybe_unify_char):
9664 * keyboard.c (read_char, reorder_modifiers):
9665 XINT -> XFASTINT, since the integer must be nonnegative.
9666 * ftfont.c (ftfont_spec_pattern):
9667 * keymap.c (access_keymap, silly_event_symbol_error):
9668 XUINT -> XFASTINT, since the integer must be nonnegative.
9669 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
9670 since it makes no difference and we prefer signed.
9671 * keyboard.c (record_char): Use XUINT when all the neighbors do.
9672 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
9675 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
9677 * window.h (Fwindow_frame): Declare.
9679 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9681 * alloc.c: Simplify handling of large-request failures (Bug#8800).
9682 (SPARE_MEMORY): Always define.
9683 (LARGE_REQUEST): Remove.
9684 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
9686 2011-06-06 Martin Rudalics <rudalics@gmx.at>
9688 * lisp.h: Move EXFUNS for Fframe_root_window,
9689 Fframe_first_window and Fset_frame_selected_window to window.h.
9691 * window.h: Move EXFUNS for Fframe_root_window,
9692 Fframe_first_window and Fset_frame_selected_window here from
9695 * frame.c (Fwindow_frame, Fframe_first_window)
9696 (Fframe_root_window, Fframe_selected_window)
9697 (Fset_frame_selected_window): Move to window.c.
9698 (Factive_minibuffer_window): Move to minibuf.c.
9699 (Fother_visible_frames_p): New function.
9701 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
9703 * window.c (decode_window, decode_any_window): Move up in code.
9704 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
9705 (inhibit_frame_unsplittable): Remove unused variable.
9706 (Fwindow_buffer): Move up and rewrite doc-string.
9707 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
9708 (Fwindow_prev): New functions.
9709 (Fwindow_frame): Move here from frame.c. Accept any window as
9711 (Fframe_root_window, Fframe_first_window)
9712 (Fframe_selected_window): Move here from frame.c. Accept frame
9713 or arbitrary window as argument. Update doc-strings.
9714 (Fminibuffer_window): Move up in code.
9715 (Fwindow_minibuffer_p): Move up in code and simplify.
9716 (Fset_frame_selected_window): Move here from frame.c.
9718 (Fselected_window, select_window, Fselect_window): Move up in
9719 code. Minor doc-string fixes.
9721 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9723 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
9724 Do not assume that spare memory exists; that assumption is valid
9725 only if SYSTEM_MALLOC.
9726 (LARGE_REQUEST): New macro, so that the issue of large requests
9727 is separated from the issue of spare memory.
9729 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
9731 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
9734 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
9736 * xfns.c (x_set_scroll_bar_default_width): Move declarations
9739 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
9741 * gtkutil.c (xg_get_default_scrollbar_width): New function.
9743 * gtkutil.h: Declare xg_get_default_scrollbar_width.
9745 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
9746 min width by calling x_set_scroll_bar_default_width (Bug#8505).
9748 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
9750 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
9752 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
9754 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
9755 (x_clipboard_manager_save): Add return value.
9756 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
9758 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
9759 Obey Vx_select_enable_clipboard_manager. Catch errors in
9760 x_clipboard_manager_save (Bug#8779).
9761 (Vx_select_enable_clipboard_manager): New variable.
9762 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
9764 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
9766 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
9768 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9770 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
9771 in the current matrix if keep_current_p is non-zero.
9773 2011-06-04 Eli Zaretskii <eliz@gnu.org>
9775 * bidi.c (bidi_level_of_next_char): Fix last change.
9777 2011-06-03 Eli Zaretskii <eliz@gnu.org>
9779 Support bidi reordering of text covered by display properties.
9781 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
9782 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
9783 (bidi_cache_search, bidi_cache_iterator_state)
9784 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
9785 (bidi_level_of_next_char, bidi_move_to_visually_next):
9786 Support character positions inside a run of characters covered by a
9788 (bidi_paragraph_init, bidi_resolve_explicit_1)
9789 (bidi_level_of_next_char): Call bidi_fetch_char and
9790 bidi_fetch_char_advance instead of FETCH_CHAR and
9792 (bidi_init_it): Initialize new members.
9793 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
9795 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
9796 instead of using explicit *_CHAR codes.
9797 (bidi_resolve_explicit, bidi_resolve_weak):
9798 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
9799 bidirectional text is supported only in multibyte buffers.
9800 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
9801 it to initialize the frame_window_p member of struct bidi_it.
9802 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
9803 (bidi_resolve_explicit, bidi_resolve_weak)
9804 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
9805 bidi_it->nchars is non-positive.
9806 (bidi_level_of_next_char): Don't try to lookup the cache for the
9807 next/previous character if nothing is cached there yet, or if we
9808 were just reseat()'ed to a new position.
9810 * xdisp.c (set_cursor_from_row): Set start and stop points
9811 according to the row's direction when priming the loop that looks
9812 for the glyph on which to display cursor.
9813 (single_display_spec_intangible_p): Function deleted.
9814 (display_prop_intangible_p): Reimplement to call
9815 handle_display_spec instead of single_display_spec_intangible_p.
9816 Accept 3 additional arguments needed by handle_display_spec.
9817 This fixes incorrect cursor motion across display property with complex
9818 values: lists, `(when COND...)' forms, etc.
9819 (single_display_spec_string_p): Support property values that are
9820 lists with the argument STRING its top-level element.
9821 (display_prop_string_p): Fix the condition for processing a
9822 property that is a list to be consistent with handle_display_spec.
9823 (handle_display_spec): New function, refactored from the
9824 last portion of handle_display_prop.
9825 (compute_display_string_pos): Accept additional argument
9826 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
9827 value of a `display' property is a "replacing spec".
9828 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
9829 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
9830 the display property, but just return a value indicating whether
9831 the display property will replace the characters it covers.
9832 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
9833 frame_window_p members of struct bidi_it.
9834 (compute_display_string_pos, compute_display_string_end):
9836 (push_it): Accept second argument POSITION, where pop_it should
9837 jump to continue iteration.
9838 (reseat_1): Initialize bidi_it.disp_pos.
9840 * keyboard.c (adjust_point_for_property): Adjust the call to
9841 display_prop_intangible_p to its new signature.
9843 * dispextern.h (struct bidi_it): New member frame_window_p.
9844 (bidi_init_it): Update prototypes.
9845 (display_prop_intangible_p): Update prototype.
9846 (compute_display_string_pos, compute_display_string_end):
9848 (struct bidi_it): New members nchars and disp_pos. ch_len is now
9851 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
9853 Malloc failure behavior now depends on size of allocation.
9854 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
9855 * lisp.h: Change signatures accordingly.
9856 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
9857 All callers changed. (Bug#8762)
9859 * gnutls.c: Use Emacs's memory allocators.
9860 Without this change, the gnutls library would invoke malloc etc.
9861 directly, which causes problems on non-SYNC_INPUT hosts, and which
9862 runs afoul of improving memory_full behavior. (Bug#8761)
9863 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
9864 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
9865 xfree instead of the default malloc, realloc, free.
9866 (Fgnutls_boot): No need to check for memory allocation failure,
9867 since xmalloc does that for us.
9869 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
9870 * category.c (hash_get_category_set):
9871 * ccl.c (ccl_driver):
9872 * charset.c (Fdefine_charset_internal):
9873 * charset.h (struct charset.hash_index):
9874 * composite.c (get_composition_id, gstring_lookup_cache)
9875 (composition_gstring_put_cache):
9876 * composite.h (struct composition.hash_index):
9877 * dispextern.h (struct image.hash):
9878 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
9879 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
9880 (hashfn_equal, hashfn_user_defined, make_hash_table)
9881 (maybe_resize_hash_table, hash_lookup, hash_put)
9882 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
9883 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
9884 (Fsxhash, Fgethash, Fputhash, Fmaphash):
9885 * image.c (make_image, search_image_cache, lookup_image)
9886 (xpm_put_color_table_h):
9887 * lisp.h (struct Lisp_Hash_Table):
9888 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
9889 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
9890 for hashes and hash indexes, instead of 'unsigned' and 'int'.
9891 * alloc.c (allocate_vectorlike):
9892 Check for overflow in vector size calculations.
9893 * ccl.c (ccl_driver):
9894 Check for overflow when converting EMACS_INT to int.
9895 * fns.c, image.c: Remove unnecessary static decls that would otherwise
9896 need to be updated by these changes.
9897 * fns.c (make_hash_table, maybe_resize_hash_table):
9898 Check for integer overflow with large hash tables.
9899 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
9900 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
9901 (SXHASH_REDUCE): New macro.
9902 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
9903 Use it instead of discarding useful hash info with large hash values.
9904 (sxhash_float): New function.
9905 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
9906 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
9907 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
9908 Rewrite to use FIXNUM_BITS, as this simplifies things.
9909 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
9910 Adjust signatures to match updated version of code.
9911 (consing_since_gc): Now EMACS_INT, since a single hash table can
9912 use more than INT_MAX bytes.
9914 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
9916 Make it possible to build with GCC-4.6+ -O2 -flto.
9918 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
9920 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
9922 * minibuf.c (get_minibuffer, read_minibuf_unwind):
9923 Call minibuffer-inactive-mode.
9925 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
9927 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
9928 Update dependencies.
9930 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9932 * data.c (init_data): Remove code for UTS, this system is not
9935 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9937 Don't force ./temacs to start in terminal mode.
9939 * frame.c (make_initial_frame): Initialize faces in all cases, not
9940 only when CANNOT_DUMP is defined.
9941 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
9943 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9945 * dispnew.c (add_window_display_history): Use const for the string
9946 pointer. Remove declaration, not needed.
9948 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9950 Use 'inline', not 'INLINE'.
9951 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
9952 * alloc.c, fontset.c (INLINE): Remove.
9953 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
9954 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
9955 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
9956 * gmalloc.c (register_heapinfo): Use inline unconditionally.
9957 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
9959 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9961 Make it possible to run ./temacs.
9963 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
9964 syms_of_callproc does the same thing. Remove test for
9965 "initialized", do it in the caller.
9966 * emacs.c (main): Avoid calling set_initial_environment when dumping.
9968 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
9970 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
9971 (read_minibuf): Use get_minibuffer.
9972 (syms_of_minibuf): Use DEFSYM.
9973 (Qmetadata): New var.
9974 * data.c (Qbuffer): Don't make it static.
9975 (syms_of_data): Use DEFSYM.
9977 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9979 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
9980 (CCL_CODE_MIN): New macro.
9982 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
9984 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
9986 * eval.c (Qdebug): Now static.
9987 * lisp.h (Qdebug): Remove decl. This reverts a part of the
9988 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
9989 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
9991 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
9993 * image.c: Various fixes to ImageMagick code comments.
9994 (Fimagemagick_types): Doc fix.
9996 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
9998 Minor fixes prompted by GCC 4.6.0 warnings.
10000 * xselect.c (converted_selections, conversion_fail_tag): Now static.
10002 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
10003 (x_clipboard_manager_save_all): Move extern decl to ...
10004 * xterm.h: ... here, so that it can be checked for consistency.
10006 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
10008 * xselect.c (x_clipboard_manager_save_frame)
10009 (x_clipboard_manager_save_all): New functions.
10010 (Fx_clipboard_manager_save): Lisp function deleted.
10012 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
10013 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
10015 * xterm.h: Update prototype.
10017 2011-05-28 William Xu <william.xwl@gmail.com>
10019 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
10020 exiting (Bug#8239).
10022 2011-05-28 Jim Meyering <meyering@redhat.com>
10024 Avoid a sign-extension bug in crypto_hash_function.
10025 * fns.c (to_uchar): Define.
10026 (crypto_hash_function): Use it to convert some newly-signed
10027 variables to unsigned, to avoid sign-extension bugs. For example,
10028 without this change, (md5 "truc") would evaluate to
10029 45723a2aff78ff4fff7fff1114760e62 rather than the expected
10030 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
10031 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
10033 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10035 Integer overflow fixes.
10037 * dbusbind.c: Serial number integer overflow fixes.
10038 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
10039 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
10040 to hold a serial number that is too large for a fixnum.
10041 (Fdbus_method_return_internal, Fdbus_method_error_internal):
10042 Check for serial numbers out of range. Decode any serial number
10043 that was so large that it became a float. (Bug#8722)
10045 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
10046 (Fdbus_call_method, Fdbus_call_method_asynchronously):
10047 Use XFASTINT rather than XUINT when numbers are nonnegative.
10048 (xd_append_arg, Fdbus_method_return_internal):
10049 (Fdbus_method_error_internal): Likewise. Also, for unsigned
10050 arguments, check that Lisp number is nonnegative, rather than
10051 silently wrapping negative numbers around. (Bug#8722)
10052 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
10055 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
10057 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
10059 ccl: Add integer overflow checks.
10060 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
10061 (IN_INT_RANGE): New macros.
10062 (ccl_driver): Use them to check for integer overflow when
10063 decoding a CCL program. Many of the new checks are whether XINT (x)
10064 fits in int; it doesn't always, on 64-bit hosts. The new version
10065 doesn't catch all possible integer overflows, but it's an
10066 improvement. (Bug#8719)
10068 * alloc.c (make_event_array): Use XINT, not XUINT.
10069 There's no need for unsigned here.
10071 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
10072 This follows up to the 2011-05-06 change that substituted uintptr_t
10073 for EMACS_INT. This case wasn't caught back then.
10075 Rework Fformat to avoid integer overflow issues.
10076 * editfns.c: Include <float.h> unconditionally, as it's everywhere
10077 now (part of C89). Include <verify.h>.
10078 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
10079 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
10080 (Fformat): Avoid the prepass trying to compute sizes; it was only
10081 approximate and thus did not catch overflow reliably. Instead, walk
10082 through the format just once, formatting and computing sizes as we go,
10083 checking for integer overflow at every step, and allocating a larger
10084 buffer as needed. Keep track separately whether the format is
10085 multibyte. Keep only the most-recently calculated precision, rather
10086 than them all. Record whether each argument has been converted to
10087 string. Use EMACS_INT, not int, for byte and char and arg counts.
10088 Support field widths and precisions larger than INT_MAX. Avoid
10089 sprintf's undefined behavior with conversion specifications such as %#d
10090 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
10091 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
10092 formatting out-of-range floating point numbers with int
10093 formats. (Bug#8668)
10095 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
10097 * data.c: Avoid integer truncation in expressions involving floats.
10098 * data.c: Include <intprops.h>.
10099 (arith_driver): When there's an integer overflow in an expression
10100 involving floating point, convert the integers to floating point
10101 so that the resulting value does not suffer from catastrophic
10102 integer truncation. For example, on a 64-bit host (* 4
10103 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
10104 Do not rely on undefined behavior after integer overflow.
10106 merge count_size_as_multibyte, parse_str_to_multibyte
10107 * character.c, character.h (count_size_as_multibyte):
10108 Rename from parse_str_to_multibyte; all uses changed.
10109 Check for integer overflow.
10110 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
10111 since it's now a duplicate of the other. This is more of
10112 a character than a buffer op, so better that it's in character.c.
10113 * fns.c, print.c: Adjust to above changes.
10115 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
10117 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
10119 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10121 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10122 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
10123 (x_clipboard_manager_save): Now static.
10124 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
10126 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10127 (crypto_hash_function): Now static.
10128 Fix pointer signedness problems. Avoid unnecessary initializations.
10130 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
10132 * termhooks.h (Vselection_alist): Make it terminal-local.
10134 * terminal.c (create_terminal): Initialize it.
10136 * xselect.c: Support for clipboard managers.
10137 (Vselection_alist): Move to termhooks.h as terminal-local var.
10138 (LOCAL_SELECTION): New macro.
10139 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
10140 (symbol_to_x_atom): Remove gratuitous arg.
10141 (x_handle_selection_request, lisp_data_to_selection_data)
10142 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
10143 (x_own_selection, x_get_local_selection, x_convert_selection):
10144 New arg, specifying work frame. Use terminal-local Vselection_alist.
10145 (some_frame_on_display): Delete unused function.
10146 (Fx_own_selection_internal, Fx_get_selection_internal)
10147 (Fx_disown_selection_internal, Fx_selection_owner_p)
10148 (Fx_selection_exists_p): New optional frame arg.
10149 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
10150 (x_handle_selection_clear): Don't treat other terminals with the
10151 same keyboard specially. Use the terminal-local Vselection_alist.
10152 (x_clear_frame_selections): Use Frun_hook_with_args.
10154 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
10156 * xterm.h: Add support for those atoms.
10158 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
10160 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
10161 (converted_selections, conversion_fail_tag): New global variables.
10162 (x_selection_request_lisp_error): Free the above.
10163 (x_get_local_selection): Remove unnecessary code.
10164 (x_reply_selection_request): Args changed; handle arbitrary array
10165 of converted selections stored in converted_selections.
10166 Separate the XChangeProperty and SelectionNotify steps.
10167 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
10168 (x_convert_selection): New function.
10169 (x_handle_selection_event): Simplify.
10170 (x_get_foreign_selection): Don't ignore incoming requests while
10171 waiting for an answer; this will fail when we implement
10172 SAVE_TARGETS, and seems unnecessary anyway.
10173 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
10174 (Vx_sent_selection_functions): Doc fix.
10176 2011-05-26 Leo Liu <sdl.web@gmail.com>
10178 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
10180 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10182 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
10184 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
10185 for fringe update if it has periodic bitmap.
10186 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
10187 and fringe_bitmap_periodic_p.
10189 * fringe.c (get_fringe_bitmap_data): New function.
10190 (draw_fringe_bitmap_1, update_window_fringes): Use it.
10191 (update_window_fringes): Record periodicity of fringe bitmap in glyph
10192 row. Mark glyph row for fringe update if periodicity changed.
10194 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
10195 for fringe update unless it has periodic bitmap.
10197 2011-05-25 Kenichi Handa <handa@m17n.org>
10199 * xdisp.c (get_next_display_element): Set correct it->face_id for
10200 a static composition.
10202 2011-05-24 Leo Liu <sdl.web@gmail.com>
10205 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
10207 * fns.c (crypto_hash_function, Fsha1): New function.
10208 (Fmd5): Use crypto_hash_function.
10209 (syms_of_fns): Add Ssha1.
10211 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10213 * gnutls.c: Remove unused macros.
10214 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
10215 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
10216 Remove macros that are defined and never used.
10217 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
10219 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
10221 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
10222 (Fx_get_selection_internal): Minor cleanup.
10223 (Fx_own_selection_internal): Rename arguments for consistency with
10226 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10228 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
10230 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
10232 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
10234 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10236 * dispnew.c (scrolling_window): Don't exclude the case that the
10237 last enabled row in the desired matrix touches the bottom boundary.
10239 2011-05-21 Glenn Morris <rgm@gnu.org>
10241 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
10242 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
10243 and add some more files.
10245 2011-05-20 Eli Zaretskii <eliz@gnu.org>
10247 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
10248 report_file_error introduced by the change from 2011-05-07.
10250 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
10252 * systime.h (Time): Define only if emacs is defined.
10253 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
10254 where the include path doesn't have X11/X.h by default. See
10255 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
10257 2011-05-20 Kenichi Handa <handa@m17n.org>
10259 * composite.c (find_automatic_composition): Fix previous change.
10261 2011-05-20 Glenn Morris <rgm@gnu.org>
10263 * lisp.mk: New file, split from Makefile.in.
10264 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
10265 (shortlisp): Remove.
10266 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
10268 2011-05-19 Glenn Morris <rgm@gnu.org>
10270 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
10271 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
10272 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
10273 (lisp): Set the order to that of loadup.el.
10274 (shortlisp): Make it a copy of $lisp.
10275 (SOME_MACHINE_LISP): Remove.
10276 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
10277 Use just $shortlisp, not $SOME_MACHINE_LISP too.
10279 2011-05-18 Kenichi Handa <handa@m17n.org>
10281 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
10282 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
10283 (find_automatic_composition): Mostly rewrite for efficiency.
10285 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
10287 * makefile.w32-in: Update dependencies.
10289 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
10291 * menu.c: Include limits.h (fixes the MS-Windows build broken by
10292 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
10294 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
10296 Fix some integer overflow issues, such as string length overflow.
10298 * insdel.c (count_size_as_multibyte): Check for string overflow.
10300 * character.c (lisp_string_width): Check for string overflow.
10301 Use EMACS_INT, not int, for string indexes and lengths; in
10302 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
10303 the resulting string length overflows an EMACS_INT; instead,
10304 report a string overflow if no precision given. When checking for
10305 precision exhaustion, use a check that cannot possibly have
10306 integer overflow. (Bug#8675)
10307 * character.h (lisp_string_width): Adjust to new signature.
10309 * alloc.c (string_overflow): New function.
10310 (Fmake_string): Use it. This doesn't change behavior, but saves
10311 a few bytes and will simplify future changes.
10312 * character.c (string_escape_byte8): Likewise.
10313 * lisp.h (string_overflow): New decl.
10315 Fixups, following up to the user-interface timestamp change.
10316 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
10317 for UI timestamps, instead of unsigned long.
10318 * msdos.c (mouse_get_pos): Likewise.
10319 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
10320 * w32gui.h (Time): Define by including "systime.h" rather than by
10321 declaring it ourselves. (Bug#8664)
10323 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
10324 * image.c (clear_image_cache): Likewise.
10326 * term.c (term_mouse_position): Don't assume time_t wraparound.
10328 Be more systematic about user-interface timestamps.
10329 Before, the code sometimes used 'Time', sometimes 'unsigned long',
10330 and sometimes 'EMACS_UINT', to represent these timestamps.
10331 This change causes it to use 'Time' uniformly, as that's what X uses.
10332 This makes the code easier to follow, and makes it easier to catch
10333 integer overflow bugs such as Bug#8664.
10334 * frame.c (Fmouse_position, Fmouse_pixel_position):
10335 Use Time, not unsigned long, for user-interface timestamps.
10336 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
10337 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
10338 * keyboard.h (last_event_timestamp): Likewise.
10339 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
10340 * menu.h (xmenu_show): Likewise.
10341 * term.c (term_mouse_position): Likewise.
10342 * termhooks.h (struct input_event.timestamp): Likewise.
10343 (struct terminal.mouse_position_hook): Likewise.
10344 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
10345 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
10346 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
10347 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
10348 what it was before.
10349 * menu.h, termhooks.h: Include "systime.h", for Time.
10351 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
10352 Don't assume that the difference between two unsigned long values
10353 can fit into an integer. At this point, we know button_down_time
10354 <= event->timestamp, so the difference must be nonnegative, so
10355 there's no need to cast the result if double-click-time is
10356 nonnegative, as it should be; check that it's nonnegative, just in
10357 case. This bug is triggered when events are more than 2**31 ms
10358 apart (about 25 days). (Bug#8664)
10360 * xselect.c (last_event_timestamp): Remove duplicate decl.
10361 (x_own_selection): Remove needless cast to unsigned long.
10363 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
10364 that always fit in int. Use a sentinel instead of a counter, to
10365 avoid a temp and to allay GCC's concerns about possible int overflow.
10366 * frame.h (struct frame): Use int for menu_bar_items_used
10367 instead of EMACS_INT, since it always fits in int.
10369 * menu.c (grow_menu_items): Check for int overflow.
10371 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
10373 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
10374 Before, the code was not consistent. These values cannot exceed
10375 2**31 - 1 so there's no need to make them unsigned.
10376 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
10377 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
10378 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
10380 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
10382 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
10383 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
10384 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
10385 presumably because the widths might not match.
10387 * window.c (size_window): Avoid needless test at loop start.
10389 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
10391 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
10393 2011-05-12 Drew Adams <drew.adams@oracle.com>
10395 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
10397 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10399 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
10400 `width' to `bar_area_x' and `bar_area_width', respectively.
10401 (x_scroll_run): Take account of fringe background extension.
10403 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
10404 Rename local vars `left' and `width' to `bar_area_x' and
10405 `bar_area_width', respectively.
10406 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
10407 background extension.
10409 2011-05-10 Jim Meyering <meyering@redhat.com>
10411 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
10413 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
10415 * image.c (Finit_image_library): Return t for built-in image types,
10416 like pbm and xbm. (Bug#8640)
10418 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
10420 * w32menu.c (set_frame_menubar): Fix submenu allocation.
10422 2011-05-07 Eli Zaretskii <eliz@gnu.org>
10424 * w32console.c (Fset_screen_color): Doc fix.
10425 (Fget_screen_color): New function.
10426 (syms_of_ntterm): Defsubr it.
10428 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
10429 unlink the temporary file if Fcall_process didn't create it in the
10431 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
10432 child process will be redirected to a file specified with `:file'.
10433 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
10434 cue to call_process_cleanup not to close that handle.
10436 2011-05-07 Ben Key <bkey76@gmail.com>
10438 * makefile.w32-in: The bootstrap-temacs rule now makes use of
10439 one of two shell specific rules, either bootstrap-temacs-CMD or
10440 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
10441 to the previous implementation of the bootstrap-temacs rule.
10442 The bootstrap-temacs-CMD rule is similar to the previous
10443 implementation of the bootstrap-temacs rule except that it
10444 makes use of the ESC_CFLAGS variable instead of the CFLAGS
10447 These changes, along with some changes to nt/configure.bat,
10448 nt/gmake.defs, and nt/nmake.defs, are required to extend my
10449 earlier fix to add support for --cflags and --ldflags options
10450 that include quotes so that it works whether make uses cmd or
10453 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
10455 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
10456 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
10458 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
10459 a string. Handle both cases.
10460 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
10461 (Fdbus_register_method): Use Qinvalid_function.
10463 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
10465 * makefile.w32-in: Update dependencies.
10466 (LISP_H): Add inttypes.h and stdin.h.
10467 (PROCESS_H): Add unistd.h.
10469 2011-05-06 Eli Zaretskii <eliz@gnu.org>
10471 * lread.c: Include limits.h (fixes the MS-Windows build broken by
10472 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
10474 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
10476 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
10478 * term.c (vfatal): Remove stray call to va_end.
10479 It's not needed and the C Standard doesn't allow it here anyway.
10481 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
10482 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
10484 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
10487 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
10489 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
10491 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
10493 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
10495 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
10497 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
10498 * charset.c (Fdefine_charset_internal): Don't initialize
10499 charset.code_space[15]. The value was garbage, on hosts with
10500 32-bit int (Bug#8600).
10502 * lread.c (read_integer): Be more consistent with string-to-number.
10503 Use string_to_number to do the actual conversion; this avoids
10504 rounding errors and fixes some other screwups. Without this fix,
10505 for example, #x1fffffffffffffff was misread as -2305843009213693952.
10506 (digit_to_number): Move earlier, for benefit of read_integer.
10507 Return -1 if the digit is out of range for the base, -2 if it is
10508 not a digit in any supported base. (Bug#8602)
10510 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
10512 * dispnew.c (scrolling_window): Return 1 if we scrolled,
10513 to match comment at start of function. This also removes a
10514 GCC warning about overflow in a 32+64-bit port.
10516 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
10518 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
10519 Reported by Stefan Monnier in
10520 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
10521 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10522 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
10524 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
10525 (EMACS_UINTPTR): Likewise, with uintptr_t.
10527 * lisp.h: Prefer 64-bit EMACS_INT if available.
10528 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
10529 on 32-bit hosts that have 64-bit int, so that they can access
10531 However, temporarily disable this change unless the temporary
10532 symbol WIDE_EMACS_INT is defined.
10534 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
10536 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
10537 This removes an assumption that EMACS_INT and long are the same
10538 width as pointers. The assumption is true for Emacs porting targets
10539 now, but we want to make other targets possible.
10540 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
10541 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
10542 In the rest of the code, change types of integers that hold casted
10543 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
10544 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
10545 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
10546 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
10547 No need to cast type when ORing.
10548 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
10549 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
10550 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
10551 assume EMACS_INT is the same width as char *.
10552 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
10553 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
10554 Remove no-longer-needed casts.
10555 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
10556 (xg_tool_bar_help_callback, xg_make_tool_item):
10557 Use EMACS_INTPTR to hold an integer
10558 that will be cast to void *; this can avoid a GCC warning
10559 if EMACS_INT is not the same width as void *.
10560 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
10561 * xdisp.c (display_echo_area_1, resize_mini_window_1):
10562 (current_message_1, set_message_1):
10563 Use a local to convert to proper width without a cast.
10564 * xmenu.c (dialog_selection_callback): Likewise.
10566 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
10567 Also, don't assume VALBITS / RAND_BITS is less than 5,
10568 and don't rely on undefined behavior when shifting a 1 left into
10570 * lisp.h (get_random): Change signature to match.
10572 * lread.c (hash_string): Use size_t, not int, for hash computation.
10573 Normally we prefer signed values; but hashing is special, because
10574 it's better to use unsigned division on hash table sizes so that
10575 the remainder is nonnegative. Also, size_t is the natural width
10576 for hashing into memory. The previous code used 'int', which doesn't
10577 retain enough info to hash well into very large tables.
10578 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
10580 * dbusbind.c: Don't possibly lose pointer info when converting.
10581 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10582 Use XPNTR rather than XHASH, so that the high-order bits of
10583 the pointer aren't lost when converting through void *.
10585 * eval.c (Fautoload): Don't double-shift a pointer.
10587 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
10589 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
10591 * gnutls.c (DEF_GNUTLS_FN):
10592 * image.c (DEF_IMGLIB_FN): Make function pointers static.
10594 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
10596 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
10599 2011-05-05 Eli Zaretskii <eliz@gnu.org>
10601 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
10602 New version that can reserve upto 2GB of heap space.
10604 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
10606 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
10608 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
10610 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
10611 `gnutls_certificate_set_x509_key_file'.
10613 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
10615 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
10616 Update dependencies.
10618 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
10620 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
10621 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
10622 Remove unused parameter `fildes'.
10623 * process.c (read_process_output, send_process): Don't pass it.
10625 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
10627 Fix previous change: the library cache is defined in w32.c.
10628 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
10629 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
10631 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
10633 Implement dynamic loading of GnuTLS on Windows.
10635 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
10636 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
10637 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10640 * gnutls.c (Qgnutls_dll): Define.
10641 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
10642 (gnutls_*): Declare function pointers.
10643 (init_gnutls_functions): New function to initialize function pointers.
10644 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
10645 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
10646 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10647 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
10648 (emacs_gnutls_write, emacs_gnutls_read)
10649 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
10650 (Fgnutls_available_p): New function.
10651 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
10652 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
10653 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
10655 * image.c: Include w32.h.
10656 (Vimage_type_cache): Delete.
10657 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
10658 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
10659 (w32_delayed_load): Move to w32.c.
10661 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
10663 * w32.c (QCloaded_from, Vlibrary_cache): Define.
10664 (w32_delayed_load): Move from image.c. When loading a library, record
10665 its filename in the :loaded-from property of the library id.
10666 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
10667 Initialize and staticpro them.
10668 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
10670 * process.c: Include lisp.h before w32.h, not after.
10671 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
10672 instead of gnutls_record_check_pending.
10674 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
10676 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
10678 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
10679 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
10682 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
10684 * xterm.c (x_set_frame_alpha): Do not set property on anything
10685 else than FRAME_X_OUTER_WINDOW (Bug#8608).
10687 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
10689 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
10691 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
10693 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
10694 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
10695 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
10696 (gnutls_global_initialized, Qgnutls_bootprop_priority)
10697 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
10698 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
10699 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
10700 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
10701 (Qgnutls_bootprop_callbacks_verify): Make static.
10703 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
10705 * callproc.c: Indentation fixup.
10707 * sysdep.c (wait_for_termination_1): Make static.
10708 (wait_for_termination, interruptible_wait_for_termination):
10709 Move after wait_for_termination_1.
10711 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
10713 * sysdep.c (interruptible_wait_for_termination): New function
10714 which is like wait_for_termination, but allows keyboard
10717 * callproc.c (Fcall_process): Add (:file "file") as an option for
10719 (Fcall_process_region): Ditto.
10721 2011-04-30 Eli Zaretskii <eliz@gnu.org>
10723 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
10724 rather than `XVECTOR (FOO)->size'.
10726 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
10727 inttypes.h, as a gnulib replacement is used if it not available in
10730 2011-04-21 Eli Zaretskii <eliz@gnu.org>
10732 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
10733 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
10734 of MOST_POSITIVE_FIXNUM. (Bug#8528)
10736 * coding.c (coding_alloc_by_realloc): Error out if destination
10737 will grow beyond MOST_POSITIVE_FIXNUM.
10738 (decode_coding_emacs_mule): Abort if there isn't enough place in
10739 charbuf for the composition carryover bytes. Reserve an extra
10740 space for up to 2 characters produced in a loop.
10741 (decode_coding_iso_2022): Abort if there isn't enough place in
10742 charbuf for the composition carryover bytes.
10744 2011-04-21 Eli Zaretskii <eliz@gnu.org>
10746 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
10747 aborting when %lld or %lll format is passed.
10748 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
10749 %llo or %llx format is passed. (Bug#8545)
10751 * window.c (window_scroll_line_based): Use a marker instead of
10752 simple variables to record original value of point. (Bug#7952)
10754 * doprnt.c (doprnt): Fix the case where a multibyte sequence
10755 produced by %s or %c overflows available buffer space. (Bug#8545)
10757 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
10759 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
10760 (SIZE_MAX): Move defn after all includes, as they might #define it.
10762 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
10764 * w32.c (init_environment): Warn about defaulting HOME to C:\.
10766 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
10768 * keyboard.c (Qdelayed_warnings_hook): Define.
10769 (command_loop_1): Run `delayed-warnings-hook'
10770 if Vdelayed_warnings_list is non-nil.
10771 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
10772 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
10774 2011-04-28 Eli Zaretskii <eliz@gnu.org>
10776 * doprnt.c (doprnt): Don't return value smaller than the buffer
10777 size if the message was truncated. (Bug#8545).
10779 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
10781 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
10782 (Fx_window_property): #if-0 the whole functions, not just the bodies.
10784 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10786 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
10788 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
10790 * makefile.w32-in: Update dependencies.
10792 2011-04-27 Eli Zaretskii <eliz@gnu.org>
10794 Improve `doprnt' and its usage. (Bug#8545)
10795 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
10796 `format_end'. Remove support for %l as a conversion specifier.
10797 Don't use xrealloc. Improve diagnostics when the %l size modifier
10798 is used. Update the commentary.
10800 * eval.c (verror): Simplify calculation of size_t.
10802 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
10805 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
10807 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
10810 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10812 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
10813 This makes this file independent of the recent pseudovector change.
10815 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
10817 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
10819 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
10820 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
10821 Remove unused local.
10822 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
10824 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
10825 GCC 4.6.0 optimizes based on type-based alias analysis.
10826 For example, if b is of type struct buffer * and v of type struct
10827 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
10828 != &v->size, and therefore "v->size = 1; b->size = 2; return
10829 v->size;" must therefore return 1. This assumption is incorrect
10830 for Emacs, since it type-puns struct Lisp_Vector * with many other
10831 types. To fix this problem, this patch adds a new type struct
10832 vectorlike_header that documents the constraints on layout of vectors
10833 and pseudovectors, and helps optimizing compilers not get fooled
10834 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
10835 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
10836 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
10838 (XSETPVECTYPE): Rewrite in terms of new macro.
10839 (XSETPVECTYPESIZE): New macro, specifying both type and size.
10840 This is a bit clearer, and further avoids the possibility of
10841 undesirable aliasing.
10842 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
10843 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
10844 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
10845 since Lisp_Subr is a special case (no "next" field).
10846 (ASIZE): Now uses header.size rather than size.
10847 All previous uses of XVECTOR (foo)->size replaced to use this macro,
10848 to avoid the hassle of writing XVECTOR (foo)->header.size.
10849 (struct vectorlike_header): New type.
10850 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
10851 object, to help avoid aliasing.
10852 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
10853 (SUBRP): Likewise, since Lisp_Subr is a special case.
10854 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
10855 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
10856 (struct Lisp_Hash_Table): Combine first two members into a single
10857 struct vectorlike_header member. All uses of "size" and "next" members
10858 changed to be "header.size" and "header.next".
10859 * buffer.h (struct buffer): Likewise.
10860 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
10861 * frame.h (struct frame): Likewise.
10862 * process.h (struct Lisp_Process): Likewise.
10863 * termhooks.h (struct terminal): Likewise.
10864 * window.c (struct save_window_data, struct saved_window): Likewise.
10865 * window.h (struct window): Likewise.
10866 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
10867 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
10868 * buffer.c (init_buffer_once): Likewise.
10869 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
10871 * process.c (Fformat_network_address): Use local var for size,
10874 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
10876 Make the Lisp reader and string-to-float more consistent (Bug#8525)
10877 * data.c (atof): Remove decl; no longer used or needed.
10878 (digit_to_number): Move to lread.c.
10879 (Fstring_to_number): Use new string_to_number function, to be
10880 consistent with how the Lisp reader treats infinities and NaNs.
10881 Do not assume that floating-point numbers represent EMACS_INT
10882 without losing information; this is not true on most 64-bit hosts.
10883 Avoid double-rounding errors, by insisting on integers when
10884 parsing non-base-10 numbers, as the documentation specifies.
10885 * lisp.h (string_to_number): New decl, replacing ...
10886 (isfloat_string): Remove.
10887 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
10888 (read1): Do not accept +. and -. as integers; this
10889 appears to have been a coding error. Similarly, do not accept
10890 strings like +-1e0 as floating point numbers. Do not report
10891 overflow for integer overflows unless the base is not 10 which
10892 means we have no simple and reliable way to continue.
10893 Break out the floating-point parsing into a new
10894 function string_to_number, so that Fstring_to_number parses
10895 floating point numbers consistently with the Lisp reader.
10896 (digit_to_number): Move here from data.c. Make it static inline.
10897 (E_CHAR, EXP_INT): Remove, replacing with ...
10898 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
10899 (string_to_number): New function, replacing isfloat_string.
10900 This function checks for valid syntax and produces the resulting
10901 Lisp float number too. Rework it so that string-to-number
10902 no longer mishandles examples like "1.0e+". Use strtoumax,
10903 so that overflow for non-base-10 numbers is reported only when
10904 there's no portable and simple way to convert to floating point.
10906 * textprop.c (set_text_properties_1): Rewrite for clarity,
10907 and to avoid GCC warning about integer overflow.
10909 * intervals.h (struct interval): Use EMACS_INT for members
10910 where EMACS_UINT might cause problems. See
10911 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
10912 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
10913 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
10915 (offset_intervals): Tell GCC not to worry about length overflow
10916 when negating a negative length.
10918 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
10919 (overrun_check_free): Likewise.
10921 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
10922 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
10925 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10926 (gnutls_make_error): Rename local to avoid shadowing.
10927 (gnutls_emacs_global_deinit): ifdef out; not used.
10928 (Fgnutls_boot): Use const for pointer to readonly storage.
10929 Comment out unused local. Fix pointer signedness problems.
10931 * lread.c (openp): Don't stuff size_t into an 'int'.
10932 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
10933 about possible signed overflow.
10935 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10936 (GDK_KEY_g): Don't define if already defined.
10937 (xg_prepare_tooltip): Avoid pointer signedness problem.
10938 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
10940 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
10941 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
10943 * xfns.c (Fx_window_property): Simplify a bit,
10944 to make a bit faster and to avoid GCC 4.6.0 warning.
10945 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
10947 * fns.c (internal_equal): Don't assume size_t fits in int.
10949 * alloc.c (compact_small_strings): Tighten assertion a little.
10951 Replace pEd with more-general pI, and fix some printf arg casts.
10952 * lisp.h (pI): New macro, generalizing old pEd macro to other
10953 conversion specifiers. For example, use "...%"pI"d..." rather
10954 than "...%"pEd"...".
10955 (pEd): Remove. All uses replaced with similar uses of pI.
10956 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
10957 * alloc.c (check_pure_size): Don't overflow by converting size to int.
10958 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
10959 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
10960 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
10961 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
10962 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
10964 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
10965 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
10966 * print.c (safe_debug_print, print_object): Likewise.
10967 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
10969 Use pI instead of if-then-else-abort. Use %p to avoid casts,
10970 avoiding the 0 flag, which is not portable.
10971 * process.c (Fmake_network_process): Use pI to avoid cast.
10972 * region-cache.c (pp_cache): Likewise.
10973 * xdisp.c (decode_mode_spec): Likewise.
10974 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
10975 behavior on 64-bit hosts with printf arg.
10976 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
10977 (x_stop_queuing_selection_requests): Likewise.
10978 (x_get_window_property): Don't truncate byte count to an 'int'
10981 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
10982 here, since it parses constructs like leading '-' and spaces,
10983 which are not wanted; and it overflows with large numbers.
10984 Instead, simply match F[0-9]+, which is what is wanted anyway.
10986 * alloc.c: Remove unportable assumptions about struct layout.
10987 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
10988 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
10989 (allocate_vectorlike, make_pure_vector): Use the new macros,
10990 plus offsetof, to remove unportable assumptions about struct layout.
10991 These assumptions hold on all porting targets that I know of, but
10992 they are not guaranteed, they're easy to remove, and removing them
10993 makes further changes easier.
10995 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
10996 This doesn't fix a bug but makes the code clearer.
10997 (string_overrun_cookie): Now const. Use initializers that
10998 don't formally overflow signed char, to avoid warnings.
10999 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
11000 can cause Emacs to crash when string overrun checking is enabled.
11001 (allocate_buffer): Don't assume sizeof (struct buffer) is a
11002 multiple of sizeof (EMACS_INT); it need not be, if
11003 alignof(EMACS_INT) < sizeof (EMACS_INT).
11004 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
11006 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
11008 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
11010 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
11012 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
11013 supposed to be handshaking. (Bug#8556)
11014 Reported by Paul Eggert <eggert@cs.ucla.edu>.
11016 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
11018 * lisp.h (Qdebug): List symbol.
11019 * eval.c (Qdebug): Restore global linkage.
11020 * keyboard.c (debug-on-event): New variable.
11021 (handle_user_signal): Break into debugger when debug-on-event
11022 matches the current signal symbol.
11024 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
11026 * alloc.c (check_sblock, check_string_bytes)
11027 (check_string_free_list): Convert to standard C.
11029 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
11031 * w32.c (emacs_gnutls_push): Fix typo.
11033 2011-04-25 Eli Zaretskii <eliz@gnu.org>
11035 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
11036 "cast to pointer from integer of different size".
11038 Improve doprnt and its use in verror. (Bug#8545)
11039 * doprnt.c (doprnt): Document the set of format control sequences
11040 supported by the function. Use SAFE_ALLOCA instead of always
11043 * eval.c (verror): Don't limit the buffer size at size_max-1, that
11044 is one byte too soon. Don't use xrealloc; instead xfree and
11047 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
11049 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
11052 * gnutls.c: Renamed global_initialized to
11053 gnutls_global_initialized. Added internals for the
11054 :verify-hostname-error, :verify-error, and :verify-flags
11055 parameters of `gnutls-boot' and documented those parameters in the
11056 docstring. Start callback support.
11057 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
11058 unless a fatal error occurred. Call gnutls_alert_send_appropriate
11059 on error. Return error code.
11060 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
11061 (emacs_gnutls_read): Likewise.
11062 (Fgnutls_boot): Return handshake error code.
11063 (emacs_gnutls_handle_error): New function.
11064 (wsaerror_to_errno): Likewise.
11066 * w32.h (emacs_gnutls_pull): Add prototype.
11067 (emacs_gnutls_push): Likewise.
11069 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
11070 (emacs_gnutls_push): Likewise.
11072 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
11074 * process.c (wait_reading_process_output): Check if GnuTLS
11075 buffered some data internally if no FDs are set for TLS
11078 * makefile.w32-in (OBJ2): Add gnutls.$(O).
11079 (LIBS): Link to USER_LIBS.
11080 ($(BLD)/gnutls.$(0)): New target.
11082 2011-04-24 Eli Zaretskii <eliz@gnu.org>
11084 * xdisp.c (handle_single_display_spec): Rename the
11085 display_replaced_before_p argument into display_replaced_p, to
11086 make it consistent with the commentary. Fix typos in the
11089 * textprop.c (syms_of_textprop): Remove dead code.
11090 (copy_text_properties): Delete obsolete commentary about an
11091 interface that was deleted long ago. Fix typos in the description
11094 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
11095 to changes in oldXMenu/XMenu.h from 2011-04-16.
11096 <menu_help_message, prev_menu_help_message>: Constify.
11097 (IT_menu_make_room): menu->help_text is now `const char **';
11100 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
11101 to changes in oldXMenu/XMenu.h from 2011-04-16.
11102 (struct XMenu): Declare `help_text' `const char **'.
11104 * xfaces.c <Qunspecified>: Make extern again.
11106 * syntax.c: Include sys/types.h before including regex.h, as
11109 * doc.c (get_doc_string): Improve the format passed to `error'.
11111 * doprnt.c (doprnt): Improve commentary.
11113 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
11115 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
11118 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
11119 changes in globals.h immediately force recompilation.
11120 (TAGS): Depend on $(CURDIR)/m/intel386.h and
11121 $(CURDIR)/s/ms-w32.h.
11122 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
11124 * character.c (Fchar_direction): Function deleted.
11125 (syms_of_character): Don't defsubr it.
11126 <char-direction-table>: Deleted.
11128 2011-04-23 Eli Zaretskii <eliz@gnu.org>
11130 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
11131 * doprnt.c: Include limits.h.
11132 (SIZE_MAX): New macro.
11133 (doprnt): Return a size_t value. 2nd arg is now size_t.
11134 Many local variables are now size_t instead of int or unsigned.
11135 Improve overflow protection. Support `l' modifier for integer
11136 conversions. Support %l conversion. Don't assume an EMACS_INT
11137 argument for integer conversions and for %c.
11139 * lisp.h (doprnt): Restore prototype.
11141 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
11142 $(SRC)/character.h.
11144 * Makefile.in (base_obj): Add back doprnt.o.
11146 * deps.mk (doprnt.o): Add back prerequisites.
11147 (callint.o): Depend on character.h.
11149 * eval.c (internal_lisp_condition_case): Include the handler
11150 representation in the error message.
11151 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
11152 when breaking from the loop.
11154 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
11156 * callint.c (Fcall_interactively): When displaying error message
11157 about invalid control letter, pass the character's codepoint, not
11158 a pointer to its multibyte form. Improve display of the character
11159 in octal and display also its hex code.
11161 * character.c (char_string): Use %x to display the (unsigned)
11162 codepoint of an invalid character, to avoid displaying a bogus
11165 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
11166 `error', not SYMBOL_NAME itself.
11168 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
11169 character arguments to `error'.
11171 * charset.c (check_iso_charset_parameter): Fix incorrect argument
11172 to `error' in error message about FINAL_CHAR argument. Make sure
11173 FINAL_CHAR is a character, and use %c when it is passed as
11174 argument to `error'.
11176 2011-04-23 Eli Zaretskii <eliz@gnu.org>
11178 * s/ms-w32.h (localtime): Redirect to sys_localtime.
11180 * w32.c: Include <time.h>.
11181 (sys_localtime): New function.
11183 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
11185 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
11187 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
11189 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
11191 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
11192 zombies (Bug#8467).
11194 2011-04-19 Eli Zaretskii <eliz@gnu.org>
11196 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
11197 gl_state.e_property when gl_state.object is Qt.
11199 * insdel.c (make_gap_larger): Remove limitation of buffer size
11202 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
11204 * xdisp.c (lookup_glyphless_char_display)
11205 (produce_glyphless_glyph): Handle cons cell entry in
11206 glyphless-char-display.
11207 (Vglyphless_char_display): Document it.
11209 * term.c (produce_glyphless_glyph): Handle cons cell entry in
11210 glyphless-char-display.
11212 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
11214 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
11216 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
11218 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
11219 definition for no-X builds.
11221 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
11223 Static checks with GCC 4.6.0 and non-default toolkits.
11225 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
11227 * process.c (keyboard_bit_set): Define only if SIGIO.
11228 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
11229 (send_process): Repair possible setjmp clobbering.
11231 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
11233 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
11235 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
11237 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
11238 Define only if needed.
11240 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
11241 by pacifying GCC about it. Maybe it's time to retire it?
11242 * xfaces.c (USG, __TIMEVAL__): Likewise.
11244 * dispextern.h (struct redisplay_interface): Rename param
11245 to avoid shadowing.
11246 * termhooks.h (struct terminal): Likewise.
11247 * xterm.c (xembed_send_message): Likewise.
11249 * insdel.c (make_gap_smaller): Define only if
11250 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
11252 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
11255 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
11256 so that we aren't warned about unused symbols.
11258 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
11260 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
11262 * xfns.c (x_real_positions): Mark locals as initialized.
11264 * xmenu.c (xmenu_show): Don't use uninitialized vars.
11266 * xterm.c: Fix problems found by static analysis with other toolkits.
11267 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
11268 (x_dispatch_event): Declare static if USE_GTK, and
11269 define if USE_GTK || USE_X_TOOLKIT.
11270 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
11271 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
11272 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
11273 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
11275 * xmenu.c (menu_help_callback): Pointer type fixes.
11276 Use const pointers when pointing at readonly data. Avoid pointer
11277 signedness clashes.
11278 (FALSE): Remove unused macro.
11279 (update_frame_menubar): Remove unused decl.
11281 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
11283 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
11284 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
11285 (single_menu_item): Rename local to avoid shadowing.
11287 * keyboard.c (make_lispy_event): Remove unused local var.
11289 * frame.c, frame.h (x_get_resource_string): Bring this back, but
11290 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
11292 * bitmaps: Change bitmaps from unsigned char back to the X11
11293 compatible char. Avoid the old compiler warnings about
11294 out-of-range initializers by using, for example, '\xab' rather
11297 * xgselect.c (xgselect_initialize): Check vs interface
11298 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
11300 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
11302 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
11303 to read-only memory.
11305 * fns.c (vector): Remove; this old hack is no longer needed.
11307 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
11309 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
11311 * xrdb.c (x_load_resources): Omit unused local.
11313 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
11314 (x_window): Rename locals to avoid shadowing.
11315 (USG): Use the kludged USG macro, to pacify gcc.
11317 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
11318 (x_term_init): Remove local to avoid shadowing.
11320 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
11322 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
11323 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
11325 2011-04-16 Eli Zaretskii <eliz@gnu.org>
11327 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
11329 Fix regex.c, syntax.c and friends for buffers > 2GB.
11330 * syntax.h (struct gl_state_s): Declare character position members
11333 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
11335 * textprop.c (verify_interval_modification, interval_of):
11336 Declare arguments EMACS_INT.
11338 * intervals.c (adjust_intervals_for_insertion): Declare arguments
11341 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
11343 * indent.c (Fvertical_motion): Local variable it_start is now
11346 * regex.c (re_match, re_match_2, re_match_2_internal)
11347 (bcmp_translate, regcomp, regexec, print_double_string)
11348 (group_in_compile_stack, re_search, re_search_2, regex_compile)
11349 (re_compile_pattern, re_exec): Declare arguments and local
11350 variables `size_t' and `ssize_t' and return values `regoff_t', as
11352 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
11353 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
11354 <compile_stack_type>: `size' and `avail' are now `size_t'.
11356 * regex.h <regoff_t>: Use ssize_t, not int.
11357 (re_search, re_search_2, re_match, re_match_2): Arguments that
11358 specify buffer/string position and length are now ssize_t and
11359 size_t. Return type is regoff_t.
11361 2011-04-16 Ben Key <bkey76@gmail.com>
11363 * nsfont.m: Fixed bugs in ns_get_family and
11364 ns_descriptor_to_entity that were caused by using free to
11365 deallocate memory blocks that were allocated by xmalloc (via
11366 xstrdup). This caused Emacs to crash when compiled with
11367 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
11368 --enable-checking=xmallocoverrun). xfree is now used to
11369 deallocate these memory blocks.
11371 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
11373 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
11375 emacs_write: Accept and return EMACS_INT for sizes.
11376 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
11378 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
11379 Accept and return EMACS_INT.
11380 (emacs_gnutls_write): Return the number of bytes written on
11382 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
11383 (emacs_read, emacs_write): Remove check for negative size, as the
11384 Emacs source code has been audited now.
11385 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
11386 (emacs_read, emacs_write): Use it.
11387 * process.c (send_process): Adjust to the new signatures of
11388 emacs_write and emacs_gnutls_write. Do not attempt to store
11389 a byte offset into an 'int'; it might overflow.
11390 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
11392 * sound.c: Don't assume sizes fit in 'int'.
11393 (struct sound_device.period_size, alsa_period_size):
11394 Return EMACS_INT, not int.
11395 (struct sound_device.write, vox_write, alsa_write):
11396 Accept EMACS_INT, not int.
11397 (wav_play, au_play): Use EMACS_INT to store sizes and to
11398 record read return values.
11400 2011-04-15 Ben Key <bkey76@gmail.com>
11402 * keyboard.c (Qundefined): Don't declare static since it is used
11404 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
11405 static since they are used in nsfont.m.
11407 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
11409 * process.c (Qprocessp): Don't declare static.
11410 * lisp.h (Qprocessp): Declare again.
11412 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
11414 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
11416 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
11418 Improve C-level modularity by making more things 'static'.
11420 Don't publish debugger-only interfaces to other modules.
11421 * lisp.h (safe_debug_print, debug_output_compilation_hack):
11422 (verify_bytepos, count_markers): Move decls to the only modules
11424 * region-cache.h (pp_cache): Likewise.
11425 * window.h (check_all_windows): Likewise.
11426 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
11428 * sysdep.c (croak): Now static, if
11429 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
11430 * syssignal.h (croak): Declare only if not static.
11432 * alloc.c (refill_memory_reserve): Now static if
11433 !defined REL_ALLOC || defined SYSTEM_MALLOC.
11434 * lisp.h (refill_memory_reserve): Declare only if not static.
11436 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
11437 Define only if USE_LUCID.
11439 * xrdb.c (x_customization_string, x_rm_string): Now static.
11441 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
11442 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
11444 * xdisp.c (draw_row_with_mouse_face): Now static.
11445 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
11447 * window.h (check_all_windows): Mark externally visible.
11449 * window.c (window_deletion_count): Now static.
11451 * undo.c: Make symbols static if they're not exported.
11452 (last_undo_buffer, last_boundary_position, pending_boundary):
11455 * textprop.c (interval_insert_behind_hooks): Now static.
11456 (interval_insert_in_front_hooks): Likewise.
11458 * term.c: Make symbols static if they're not exported.
11459 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
11460 (max_frame_lines, tty_set_terminal_modes):
11461 (tty_reset_terminal_modes, tty_turn_off_highlight):
11462 (get_tty_terminal): Now static.
11463 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
11464 * termhooks.h (term_mouse_moveto): Do not declare if
11465 HAVE_WINDOW_SYSTEM.
11466 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
11467 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
11469 * sysdep.c: Make symbols static if they're not exported.
11470 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
11472 (sigprocmask_set, full_mask): Remove; unused.
11473 (wait_debugging): Mark as visible.
11474 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
11475 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
11477 * syntax.c (syntax_temp): Define only if !__GNUC__.
11479 * sound.c (current_sound_device, current_sound): Now static.
11481 * search.c (searchbufs, searchbuf_head): Now static.
11483 * scroll.c (scroll_cost): Remove; unused.
11484 * dispextern.h (scroll_cost): Remove decl.
11486 * region-cache.h (pp_cache): Mark as externally visible.
11488 * process.c: Make symbols static if they're not exported.
11489 (process_tick, update_tick, create_process, chan_process):
11490 (Vprocess_alist, proc_buffered_char, datagram_access):
11491 (fd_callback_data, send_process_frame, process_sent_to): Now static.
11492 (deactivate_process): Mark defn as static, as well as decl.
11493 * lisp.h (create_process): Remove decl.
11494 * process.h (chan_process, Vprocess_alist): Remove decls.
11496 * print.c: Make symbols static if they're not exported.
11497 (print_depth, new_backquote_output, being_printed, print_buffer):
11498 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
11499 (print_interval, print_number_index, initial_stderr_stream):
11501 * lisp.h (Fprinc): Remove decl.
11502 (debug_output_compilation_hack): Mark as externally visible.
11504 * sysdep.c (croak): Move decl from here to syssignal.h.
11505 * syssignal.h (croak): Put it here, so the API can be checked when
11506 'croak' is called from dissociate_if_controlling_tty.
11508 * minibuf.c: Make symbols static if they're not exported.
11509 (minibuf_save_list, choose_minibuf_frame): Now static.
11510 * lisp.h (choose_minibuf_frame): Remove decl.
11512 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
11514 * lread.c: Make symbols static if they're not exported.
11515 (read_objects, initial_obarray, oblookup_last_bucket_number):
11517 (make_symbol): Remove; unused.
11518 * lisp.h (initial_obarray, make_symbol): Remove decls.
11520 * keyboard.c: Make symbols static if they're not exported.
11521 (single_kboard, recent_keys_index, total_keys, recent_keys):
11522 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
11523 (this_single_command_key_start, echoing, last_auto_save):
11524 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
11525 (command_loop, echo_now, keyboard_init_hook, help_char_p):
11526 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
11527 (Vlispy_mouse_stem, double_click_count):
11529 (force_auto_save_soon): Define only if SIGDANGER.
11530 (ignore_mouse_drag_p): Now static if
11531 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
11532 (print_help): Remove; unused.
11533 (stop_character, last_timer_event): Mark as externally visible.
11534 * keyboard.h (ignore_mouse_drag_p): Declare only if
11535 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
11536 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
11537 * lisp.h (echoing): Remove decl.
11538 (force_auto_save_soon): Declare only if SIGDANGER.
11539 * xdisp.c (redisplay_window): Simplify code, to make it more
11540 obvious that ignore_mouse_drag_p is not accessed if !defined
11541 USE_GTK && !defined HAVE_NS.
11543 * intervals.c: Make symbols static if they're not exported.
11544 (merge_properties_sticky, merge_interval_right, delete_interval):
11546 * intervals.h (merge_interval_right, delete_interval): Remove decls.
11548 * insdel.c: Make symbols static if they're not exported.
11549 However, leave prepare_to_modify_buffer alone. It's never
11550 called from outside this function, but that appears to be a bug.
11551 (combine_after_change_list, combine_after_change_buffer):
11552 (adjust_after_replace, signal_before_change): Now static.
11553 (adjust_after_replace_noundo): Remove; unused.
11554 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
11555 (signal_before_change): Remove decls.
11557 * indent.c (val_compute_motion, val_vmotion): Now static.
11559 * image.c: Make symbols static if they're not exported.
11560 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
11562 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
11563 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
11565 * fringe.c (standard_bitmaps): Now static.
11566 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
11568 * frame.c: Make symbols static if they're not exported.
11569 (x_report_frame_params, make_terminal_frame): Now static.
11570 (get_frame_param): Now static, unless HAVE_NS.
11571 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
11572 (x_get_resource_string): Remove; not used.
11573 * frame.h (make_terminal_frame, x_report_frame_params):
11574 (x_get_resource_string); Remove decls.
11575 (x_fullscreen_adjust): Declare only if WINDOWSNT.
11576 * lisp.h (get_frame_param): Declare only if HAVE_NS.
11578 * font.c, fontset.c: Make symbols static if they're not exported.
11579 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
11580 (FACE_SUITABLE_FOR_CHAR_P): Use it.
11581 * font.c (font_close_object): Now static.
11582 * font.h (font_close_object): Remove.
11583 * fontset.c (FONTSET_OBJLIST): Remove.
11584 (free_realized_fontset) #if-0 the body, which does nothing.
11585 (face_suitable_for_char_p): #if-0, as it's never called.
11586 * fontset.h (face_suitable_for_char_p): Remove decl.
11587 * xfaces.c (face_at_string_position):
11588 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
11589 since 0 is always ASCII.
11591 * fns.c (weak_hash_tables): Now static.
11593 * fileio.c: Make symbols static if they're not exported.
11594 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
11595 (Vwrite_region_annotation_buffers): Now static.
11597 * eval.c: Make symbols static if they're not exported.
11598 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
11599 * lisp.h (backtrace_list): Remove decl.
11601 * emacs.c: Make symbols static if they're not exported.
11602 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
11603 (fatal_error_code, fatal_error_signal_hook, standard_args):
11605 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
11606 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
11607 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
11608 * lisp.h (fatal_error_signal_hook): Remove decl.
11609 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
11611 * editfns.c: Move a (normally-unused) function to its only use.
11612 * editfns.c, lisp.h (get_operating_system_release): Remove.
11613 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
11614 worth the hassle of breaking this out.
11616 * xterm.c: Make symbols static if they're not exported.
11617 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
11618 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
11619 (x_destroy_window, x_delete_display):
11621 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
11622 (x_mouse_leave): Remove; unused.
11623 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
11624 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
11625 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
11627 (x_mouse_leave): Declare only if WINDOWSNT.
11628 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
11629 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
11632 * ftxfont.c: Make symbols static if they're not exported.
11633 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
11635 * font.h (ftxfont_driver): Likewise.
11637 * xfns.c: Make symbols static if they're not exported.
11638 (x_last_font_name, x_display_info_for_name):
11639 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
11640 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
11641 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
11642 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
11643 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
11644 (last_show_tip_args): Now static.
11645 (xic_defaut_fontset, xic_create_fontsetname): Define only if
11646 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
11647 (x_screen_planes): Remove; unused.
11648 * dispextern.h (x_screen_planes): Remove decl.
11650 * dispnew.c: Make symbols static if they're not exported.
11651 * dispextern.h (redraw_garbaged_frames, scrolling):
11652 (increment_row_positions): Remove.
11653 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
11654 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
11656 (redraw_garbaged_frames): Remove; unused.
11658 * xfaces.c: Make symbols static if they're not exported.
11659 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
11661 * xterm.h (defined_color): Remove decls.
11662 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
11663 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
11664 (menu_face_changed_default, defined_color, free_realized_face):
11665 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
11666 (ascii_face_of_lisp_face): Remove; unused.
11668 * xdisp.c: Make symbols static if they're not exported.
11669 * dispextern.h (scratch_glyph_row, window_box_edges):
11670 (glyph_to_pixel_coords, set_cursor_from_row):
11671 (get_next_display_element, set_iterator_to_next):
11672 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
11673 (show_mouse_face): Remove decls
11674 * frame.h (message_buf_print): Likewise.
11675 * lisp.h (pop_message, set_message, check_point_in_composition):
11677 * xterm.h (set_vertical_scroll_bar): Likewise.
11678 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
11679 (message_buf_print, scratch_glyph_row, displayed_buffer):
11680 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
11681 (get_next_display_element, show_mouse_face, window_box_edges):
11682 (frame_to_window_pixel_xy, check_point_in_composition):
11683 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
11684 (glyph_to_pixel_coords): Remove; unused.
11686 * dired.c (file_name_completion): Now static.
11688 * dbusbind.c (xd_in_read_queued_messages): Now static.
11690 * lisp.h (circular_list_error, FOREACH): Remove; unused.
11691 * data.c (circular_list_error): Remove.
11693 * commands.h (last_point_position, last_point_position_buffer):
11694 (last_point_position_window): Remove decls.
11695 * keyboard.c: Make these variables static.
11697 * coding.h (coding, code_convert_region, encode_coding_gap):
11699 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
11700 (iso_code_class, detect_coding, code_convert_region): Now static.
11701 (encode_coding_gap): Remove; unused.
11703 * chartab.c (chartab_chars, chartab_bits): Now static.
11705 * charset.h (charset_iso_8859_1): Remove decl.
11706 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
11709 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
11710 * ccl.c (Vccl_program_table): Now static.
11711 (check_ccl_update): Remove; unused.
11713 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
11714 * category.h: ... from here.
11715 * category.c (check_category_table, set_category_set): Now static.
11717 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
11718 * lisp.h: Remove these decls.
11720 * buffer.c (buffer_count): Remove unused var.
11722 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
11723 so that it's not optimized away.
11724 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
11725 * dispextern.h (bidi_dump_cached_states): Remove, since it's
11726 exported only to the debugger.
11728 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
11729 * atimer.h (run_all_atimers): Remove; not exported.
11731 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
11732 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
11733 was inaccessible from Lisp.
11734 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
11735 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
11737 alloc.c: Import and export fewer symbols, and remove unused items.
11738 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
11740 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
11741 it's not optimized away by whole-program optimization.
11742 (message_enable_multibyte, free_misc): Remove.
11743 (catchlist, handlerlist, mark_backtrace):
11744 Declare only if BYTE_MARK_STACK.
11745 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
11746 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
11747 (message_enable_multibyte): Remove decl.
11748 (free_misc, interval_free_list, float_block, float_block_index):
11749 (n_float_blocks, float_free_list, cons_block, cons_block_index):
11750 (cons_free_list, last_marked_index):
11752 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
11753 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
11754 (mark_backtrace): Define only if BYTE_MARK_STACK.
11755 * xdisp.c (message_enable_multibyte): Now static.
11757 Declare Lisp_Object Q* variables to be 'static' if not exported.
11758 This makes it easier for human readers (and static analyzers)
11759 to see whether these variables are used from other modules.
11760 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
11761 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
11762 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
11763 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
11764 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
11765 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
11766 * xmenu.c, xselect.c:
11767 Declare Q* vars static if they are not used in other modules.
11768 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
11769 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
11770 Remove decls of unexported vars.
11771 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
11773 * lisp.h (DEFINE_FUNC): Make sname 'static'.
11775 Make Emacs functions such as Fatom 'static' by default.
11776 This makes it easier for human readers (and static analyzers)
11777 to see whether these functions can be called from other modules.
11778 DEFUN now defines a static function. To make the function external
11779 so that it can be used in other C modules, use the new macro DEFUE.
11780 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
11781 (Finit_image_library):
11782 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
11783 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
11784 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
11785 Remove decls, since these functions are now static.
11786 (Funintern, Fget_internal_run_time): New decls, since these functions
11787 were already external.
11789 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
11790 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
11791 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
11792 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
11793 * keyboard.c, keymap.c, lread.c:
11794 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
11795 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
11796 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
11797 Mark functions with DEFUE instead of DEFUN,
11798 if they are used in other modules.
11799 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
11800 decls for now-static functions.
11801 * buffer.h (Fdelete_overlay): Remove decl.
11802 * callproc.c (Fgetenv_internal): Mark as internal.
11803 * composite.c (Fremove_list_of_text_properties): Remove decl.
11804 (Fcomposition_get_gstring): New forward static decl.
11805 * composite.h (Fcomposite_get_gstring): Remove decl.
11806 * dired.c (Ffile_attributes): New forward static decl.
11807 * doc.c (Fdocumntation_property): New forward static decl.
11808 * eval.c (Ffetch_bytecode): New forward static decl.
11809 (Funintern): Remove extern decl; now in .h file where it belongs.
11810 * fileio.c (Fmake_symbolic_link): New forward static decl.
11811 * image.c (Finit_image_library): New forward static decl.
11812 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
11813 * intervals.h (Fprevious_property_change):
11814 (Fremove_list_of_text_properties): Remove decls.
11815 * keyboard.c (Fthis_command_keys): Remove decl.
11816 (Fcommand_execute): New forward static decl.
11817 * keymap.c (Flookup_key): New forward static decl.
11818 (Fcopy_keymap): Now static.
11819 * keymap.h (Flookup_key): Remove decl.
11820 * process.c (Fget_process): New forward static decl.
11821 (Fprocess_datagram_address): Mark as internal.
11822 * syntax.c (Fsyntax_table_p): New forward static decl.
11823 (skip_chars): Remove duplicate decl.
11824 * textprop.c (Fprevious_property_change): New forward static decl.
11825 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
11827 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
11828 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
11830 * editfns.c (Fformat): Remove unreachable code.
11832 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
11834 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
11837 2011-04-13 Eli Zaretskii <eliz@gnu.org>
11839 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
11840 when at ZV. (Bug#8487)
11842 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
11844 * charset.c (Fclear_charset_maps): Use xfree instead of free.
11846 * keyboard.c (parse_tool_bar_item): Likewise.
11847 * sound.c (sound_cleanup, alsa_close): Likewise.
11848 * termcap.c (tgetent): Likewise.
11849 * xfns.c (x_default_font_parameter): Likewise.
11850 * xsettings.c (read_and_apply_settings): Likewise.
11852 * alloc.c (overrun_check_malloc, overrun_check_realloc)
11853 (overrun_check_free): Protoize.
11855 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
11857 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
11858 since callers should never pass a negative size.
11859 Change the signature to match that of plain 'read' and 'write'; see
11860 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
11861 * lisp.h: Update prototypes of emacs_write and emacs_read.
11863 2011-04-11 Eli Zaretskii <eliz@gnu.org>
11865 * xdisp.c (redisplay_window): Don't try to determine the character
11866 position of the scroll margin if the window start point w->startp
11867 is outside the buffer's accessible region. (Bug#8468)
11869 2011-04-10 Eli Zaretskii <eliz@gnu.org>
11871 Fix write-region and its subroutines for buffers > 2GB.
11872 * fileio.c (a_write, e_write): Modify declaration of arguments and
11873 local variables to support buffers larger than 2GB.
11874 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
11876 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
11877 argument, local variables, and return value.
11879 * lisp.h: Update prototypes of emacs_write and emacs_read.
11881 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
11883 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
11885 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
11887 Fix more problems found by GCC 4.6.0's static checks.
11889 * xdisp.c (vmessage): Use a better test for character truncation.
11891 * charset.c (load_charset_map): <, not <=, for optimization,
11892 and to avoid potential problems with integer overflow.
11893 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
11894 * casetab.c (set_identity, shuffle): Likewise.
11895 * editfns.c (Fformat): Likewise.
11896 * syntax.c (skip_chars): Likewise.
11898 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
11899 This also lets GCC 4.6.0 generate slightly better loop code.
11901 * callint.c (Fcall_interactively): <, not <=, for optimization.
11902 (Fcall_interactively): Count the number of arguments produced,
11903 not the number of arguments given. This is simpler and lets GCC
11904 4.6.0 generate slightly better code.
11906 * ftfont.c: Distingish more carefully between FcChar8 and char.
11907 The previous code passed unsigned char * to a functions like
11908 strlen and xstrcasecmp that expect char *, which does not
11909 conform to the C standard.
11910 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
11911 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
11912 char * when the C standard requires it.
11914 * keyboard.c (read_char): Remove unused var.
11916 * eval.c: Port to Windows vsnprintf (Bug#8435).
11917 Include <limits.h>.
11918 (SIZE_MAX): Define if the headers do not.
11919 (verror): Do not give up if vsnprintf returns a negative count.
11920 Instead, grow the buffer. This ports to Windows vsnprintf, which
11921 does not conform to C99. Problem reported by Eli Zaretskii.
11922 Also, simplify the allocation scheme, by avoiding the need for
11923 calling realloc, and removing the ALLOCATED variable.
11925 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
11927 Remove invocations of doprnt, as Emacs now uses vsnprintf.
11928 But keep the doprint source code for now, as we might revamp it
11929 and use it again (Bug#8435).
11930 * lisp.h (doprnt): Remove.
11931 * Makefile.in (base_obj): Remove doprnt.o.
11932 * deps.mk (doprnt.o): Remove.
11934 error: Print 32- and 64-bit integers portably (Bug#8435).
11935 Without this change, on typical 64-bit hosts error ("...%d...", N)
11936 was used to print both 32- and 64-bit integers N, which relied on
11937 undefined behavior.
11938 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
11939 * lisp.h (error, verror): Mark as printf-like functions.
11940 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
11941 Report overflow in size calculations when allocating printf buffer.
11942 Do not truncate output string at its first null byte.
11943 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
11944 Truncate the output at a character boundary, since vsnprintf does not
11946 * charset.c (check_iso_charset_parameter): Convert internal
11947 character to string before calling 'error', since %c now has the
11949 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
11950 overflow when computing char to be passed to 'error'. Do not
11951 pass Lisp_Object to 'error'; pass the integer instead.
11952 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
11953 formatted with plain %d.
11955 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
11957 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
11959 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
11961 * xterm.c (x_catch_errors): Remove duplicate declaration.
11963 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
11965 * xdisp.c, lisp.h (message_nolog): Remove; unused.
11967 2011-04-10 Jim Meyering <meyering@redhat.com>
11969 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
11970 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
11971 return ssize_t not "int", and use size_t as the buffer length.
11972 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
11973 * gnutls.h: Update declarations.
11974 * process.c (read_process_output): Use ssize_t, to match.
11975 (send_process): Likewise.
11977 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
11979 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
11981 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
11983 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
11984 Use unsigned char, to match FcChar8 type definition.
11986 * xterm.c (handle_one_xevent):
11987 * xmenu.c (create_and_show_popup_menu):
11988 * xselect.c (x_decline_selection_request)
11989 (x_reply_selection_request): Avoid type-punned deref of X events.
11991 2011-04-09 Eli Zaretskii <eliz@gnu.org>
11993 Fix some uses of `int' instead of EMACS_INT.
11994 * search.c (string_match_1, fast_string_match)
11995 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
11996 (scan_buffer, find_next_newline_no_quit)
11997 (find_before_next_newline, search_command, Freplace_match)
11998 (Fmatch_data): Make some `int' variables be EMACS_INT.
12000 * xdisp.c (display_count_lines): 3rd argument and return value now
12001 EMACS_INT. All callers changed.
12002 (pint2hrstr): Last argument is now EMACS_INT.
12004 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
12005 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
12006 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
12007 (decode_coding_utf_16, decode_coding_emacs_mule)
12008 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
12009 (decode_coding_ccl, decode_coding_charset)
12010 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
12011 (decode_coding_iso_2022, decode_coding_emacs_mule)
12012 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
12013 <char_offset, last_offset>: Declare EMACS_INT.
12014 (encode_coding_utf_8, encode_coding_utf_16)
12015 (encode_coding_emacs_mule, encode_invocation_designation)
12016 (encode_designation_at_bol, encode_coding_iso_2022)
12017 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
12018 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
12020 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
12021 (encode_invocation_designation): Last argument P_NCHARS is now
12023 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
12024 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
12026 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
12029 * ccl.c (Fccl_execute_on_string): Declare some variables
12032 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
12034 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
12036 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
12038 * process.c (Fformat_network_address): Doc fix.
12040 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
12042 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
12044 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
12046 * keyboard.c (read_char): Call Lisp function help-form-show,
12047 instead of using internal_with_output_to_temp_buffer.
12048 (Qhelp_form_show): New var.
12049 (syms_of_keyboard): Use DEFSYM macro.
12051 * print.c (internal_with_output_to_temp_buffer): Function deleted.
12053 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
12055 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
12057 * process.c (Flist_processes): Remove to Lisp.
12058 (list_processes_1): Delete.
12060 2011-04-06 Eli Zaretskii <eliz@gnu.org>
12062 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
12064 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
12066 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
12068 Fix more problems found by GCC 4.6.0's static checks.
12070 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
12072 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
12074 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
12076 * xdisp.c (vmessage): Mark as a printf-like function.
12078 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
12080 * sound.c (sound_warning): Don't crash if arg contains a printf format.
12082 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
12083 printf-like functions.
12084 (tiff_load): Add casts to remove these marks before passing them
12085 to system-supplied API.
12087 * eval.c (Fsignal): Remove excess argument to 'fatal'.
12089 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
12090 This avoids several warnings with gcc -Wstrict-overflow.
12091 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
12092 directly, rather than having caller test rule sign. This avoids
12093 some unnecessary tests.
12094 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
12095 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
12096 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
12098 * xfont.c (xfont_text_extents): Remove var that was set but not used.
12099 (xfont_open): Avoid unnecessary tests.
12101 * composite.c (composition_gstring_put_cache): Use unsigned integer.
12103 * composite.h, composite.c (composition_gstring_put_cache):
12104 Use EMACS_INT, not int, for length.
12106 * composite.h (COMPOSITION_DECODE_REFS): New macro,
12107 breaking out part of COMPOSITION_DECODE_RULE.
12108 (COMPOSITION_DECODE_RULE): Use it.
12109 * composite.c (get_composition_id): Remove unused local vars,
12110 by using the new macro.
12112 * textprop.c (set_text_properties_1): Change while to do-while,
12113 since the condition is always true at first.
12115 * intervals.c (graft_intervals_into_buffer): Mark var as used.
12116 (interval_deletion_adjustment): Return unsigned value.
12119 * process.c (list_processes_1, create_pty, read_process_output):
12120 (exec_sentinel): Remove vars that were set but not used.
12121 (create_pty): Remove unnecessary "volatile"s.
12122 (Fnetwork_interface_info): Avoid possibility of int overflow.
12123 (read_process_output): Do adaptive read buffering even if carryover.
12124 (read_process_output): Simplify nbytes computation if buffered.
12126 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
12128 * syntax.c (scan_words): Remove var that was set but not used.
12129 (update_syntax_table): Use unsigned instead of int.
12131 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
12132 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
12133 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
12135 * print.c (print_error_message): Avoid int overflow.
12137 * font.c (font_list_entities): Redo for clarity,
12138 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
12140 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
12141 (font_score): Avoid potential overflow in diff calculation.
12143 * fns.c (substring_both): Remove var that is set but not used.
12144 (sxhash): Redo loop for clarity and to avoid wraparound warning.
12146 * eval.c (funcall_lambda): Rename local to avoid shadowing.
12148 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
12149 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
12150 can always succeed if overflow has undefined behavior.
12152 * search.c (boyer_moore, wordify): Remove vars set but not used.
12153 (wordify): Omit three unnecessary tests.
12155 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
12156 All callers changed. This avoids the need for an unused var.
12158 * casefiddle.c (casify_region): Remove var that is set but not used.
12160 * dired.c (file_name_completion): Remove var that is set but not used.
12162 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
12164 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
12165 (Finsert_file_contents): Remove unnecessary code checking fd.
12167 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
12168 Check for integer overflow on size calculations.
12170 * buffer.c (Fprevious_overlay_change): Remove var that is set
12173 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
12174 Remove vars that are set but not used.
12175 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
12176 (timer_check_2): Mark vars as initialized.
12178 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
12180 * image.c (lookup_image): Remove var that is set but not used.
12181 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
12183 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
12184 that are set but not used.
12186 * xfns.c (make_invisible_cursor): Don't return garbage
12187 if XCreateBitmapFromData fails (Bug#8410).
12189 * xselect.c (x_get_local_selection, x_handle_property_notify):
12190 Remove vars that are set but not used.
12192 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
12193 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
12195 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
12196 Remove var that is set but not used.
12197 (scroll_bar_windows_size): Now size_t, not int.
12198 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
12199 Check for overflow.
12201 * xfaces.c (realize_named_face): Remove vars that are set but not used.
12202 (map_tty_color) [!defined MSDOS]: Likewise.
12204 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
12206 * coding.c: Remove vars that are set but not used.
12207 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
12208 All callers changed.
12209 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
12210 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
12211 (decode_coding_charset): Remove vars that are set but not used.
12213 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
12214 that is set but not used.
12216 * print.c (print_object): Remove var that is set but not used.
12218 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
12219 The gnulib version avoids calling malloc in the usual case,
12220 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
12221 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
12222 * filelock.c (current_lock_owner): Likewise.
12223 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
12224 * sysdep.c: Include allocator.h, careadlinkat.h.
12225 (emacs_no_realloc_allocator): New static constant.
12226 (emacs_readlink): New function.
12227 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
12228 ../lib/careadlinkat.h.
12230 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
12232 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
12233 first non-nil return value).
12235 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
12237 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
12238 if not defined (Bug#8403).
12240 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
12242 * xdisp.c (display_count_lines): Remove parameter `start',
12243 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12244 (get_char_face_and_encoding): Remove parameter `multibyte_p',
12245 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12246 (fill_stretch_glyph_string): Remove parameters `row' and `area',
12247 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
12248 and thereabouts. All callers changed.
12249 (get_per_char_metric): Remove parameter `f', unused since
12250 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
12252 2011-04-02 Jim Meyering <meyering@redhat.com>
12254 do not dereference NULL upon failed strdup
12255 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
12256 (ns_get_family): Likewise.
12258 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
12260 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
12262 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
12264 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
12267 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
12269 Add lexical binding.
12271 * window.c (Ftemp_output_buffer_show): New fun.
12272 (Fsave_window_excursion):
12273 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
12275 * lread.c (lisp_file_lexically_bound_p): New function.
12276 (Fload): Bind Qlexical_binding.
12277 (readevalloop): Remove `evalfun' arg.
12278 Bind Qinternal_interpreter_environment.
12279 (Feval_buffer): Bind Qlexical_binding.
12280 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
12282 (syms_of_lread): Declare `lexical-binding'.
12284 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
12286 * keyboard.c (eval_dyn): New fun.
12287 (menu_item_eval_property): Use it.
12289 * image.c (parse_image_spec): Use Ffunctionp.
12291 * fns.c (concat, mapcar1): Accept byte-code-functions.
12293 * eval.c (Fsetq): Handle lexical vars.
12294 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
12295 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
12296 (FletX, Flet): Obey lexical binding.
12297 (Fcommandp): Handle closures.
12298 (Feval): New `lexical' arg.
12299 (eval_sub): New function extracted from Feval. Use it almost
12300 everywhere where Feval was used. Look up vars in lexical env.
12302 (Ffunctionp): Move from subr.el.
12303 (Ffuncall): Handle closures.
12304 (apply_lambda): Remove `eval_flags'.
12305 (funcall_lambda): Handle closures and new byte-code-functions.
12306 (Fspecial_variable_p): New function.
12307 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
12308 but without exporting it to Lisp.
12310 * doc.c (Fdocumentation, store_function_docstring):
12311 * data.c (Finteractive_form): Handle closures.
12313 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
12316 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
12318 (exec_byte_code): New function extracted from Fbyte_code to handle new
12319 calling convention for byte-code-functions. Add new byte-codes.
12321 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
12323 * alloc.c (Fmake_symbol): Init new `declared_special' field.
12325 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
12327 * xdisp.c (redisplay_internal): Fix prototype.
12329 2011-03-31 Eli Zaretskii <eliz@gnu.org>
12331 * xdisp.c (SCROLL_LIMIT): New macro.
12332 (try_scrolling): Use it when setting scroll_limit.
12333 Limit scrolling to 100 screen lines.
12334 (redisplay_window): Even when falling back on "recentering",
12335 position point in the window according to scroll-conservatively,
12336 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
12338 (try_scrolling): When point is above the window, allow searching
12339 as far as scroll_max, or one screenful, to compute vertical
12340 distance from PT to the scroll margin position. This prevents
12341 try_scrolling from unnecessarily failing when
12342 scroll-conservatively is set to a value slightly larger than the
12343 window height. Clean up the case of PT below the margin at bottom
12344 of window: scroll_max can no longer be INT_MAX. When aggressive
12345 scrolling is in use, don't let point enter the opposite scroll
12346 margin as result of the scroll.
12347 (syms_of_xdisp) <scroll-conservatively>: Document the
12348 threshold of 100 lines for never-recentering scrolling.
12350 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
12352 * dispextern.h (move_it_by_lines):
12353 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
12354 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
12355 (message_log_check_duplicate): Remove parameters `prev_bol' and
12356 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12357 (redisplay_internal): Remove parameter `preserve_echo_area',
12358 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
12360 * indent.c (Fvertical_motion):
12361 * window.c (window_scroll_pixel_based, Frecenter):
12362 Don't pass `need_y_p' to `move_it_by_lines'.
12364 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
12366 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
12367 steal a few bits to be more compact.
12368 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
12369 Remove unneeded casts.
12371 * bytecode.c (Fbyte_code): CAR and CDR can GC.
12373 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
12375 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
12376 binding" message (bug#7967).
12378 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
12380 Fix more problems found by GCC 4.6.0's static checks.
12382 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
12383 Remove unused local var.
12385 * editfns.c (Fmessage_box): Remove unused local var.
12387 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
12388 (note_mode_line_or_margin_highlight, note_mouse_highlight):
12389 Omit unused local vars.
12390 * window.c (shrink_windows): Omit unused local var.
12391 * menu.c (digest_single_submenu): Omit unused local var.
12392 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
12393 Omit unused local var.
12395 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
12396 Don't assume string length fits in int.
12397 (keyremap_step, read_key_sequence): Use size_t for sizes.
12398 (read_key_sequence): Don't check last_real_key_start redundantly.
12400 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
12401 instead of alloca (Bug#8344).
12403 * eval.c (Fbacktrace): Don't assume nargs fits in int.
12404 (Fbacktrace_frame): Don't assume nframes fits in int.
12406 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
12408 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
12411 * term.c (produce_glyphless_glyph): Remove unnecessary test.
12413 * cm.c (calccost): Turn while-do into do-while, for clarity.
12415 * keyboard.c (syms_of_keyboard): Use the same style as later
12416 in this function when indexing through an array. This also
12417 works around GCC bug 48267.
12419 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
12421 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
12423 * chartab.c (sub_char_table_ref_and_range): Redo for slight
12424 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
12426 * keyboard.c, keyboard.h (num_input_events): Now size_t.
12427 This avoids undefined behavior on integer overflow, and is a bit
12428 more convenient anyway since it is compared to a size_t variable.
12430 Variadic C functions now count arguments with size_t, not int.
12431 This avoids an unnecessary limitation on 64-bit machines, which
12432 caused (substring ...) to crash on large vectors (Bug#8344).
12433 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
12434 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
12435 All variadic functions and their callers changed accordingly.
12436 (struct gcpro.nvars): Now size_t, not int. All uses changed.
12437 * data.c (arith_driver, float_arith_driver): Likewise.
12438 * editfns.c (general_insert_function): Likewise.
12439 * eval.c (struct backtrace.nargs, interactive_p)
12440 (internal_condition_case_n, run_hook_with_args, apply_lambda)
12441 (funcall_lambda, mark_backtrace): Likewise.
12442 * fns.c (concat): Likewise.
12443 * frame.c (x_set_frame_parameters): Likewise.
12444 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
12445 0 if not found, not -1. All callers changed.
12447 * alloc.c (garbage_collect): Don't assume stack size fits in int.
12448 (stack_copy_size): Now size_t, not int.
12449 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
12451 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
12453 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
12454 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12455 All callers changed.
12457 * lisp.h (multibyte_char_to_unibyte):
12458 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
12459 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12460 * character.h (CHAR_TO_BYTE8):
12461 * cmds.c (internal_self_insert):
12462 * editfns.c (general_insert_function):
12463 * keymap.c (push_key_description):
12464 * search.c (Freplace_match):
12465 * xdisp.c (message_dolog, set_message_1): All callers changed.
12467 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
12469 * keyboard.c (safe_run_hook_funcall): New function.
12470 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
12471 don't set the hook to nil, but remove the offending function instead.
12472 (Qcommand_hook_internal): Remove, unused.
12473 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
12474 Vcommand_hook_internal.
12476 * eval.c (enum run_hooks_condition): Remove.
12477 (funcall_nil, funcall_not): New functions.
12478 (run_hook_with_args): Call each function through a `funcall' argument.
12479 Remove `cond' argument, now redundant.
12480 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
12481 (Frun_hook_with_args_until_failure): Adjust accordingly.
12482 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
12484 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
12486 * dispextern.h (string_buffer_position): Remove declaration.
12488 * print.c (strout): Remove parameter `multibyte', unused since
12489 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
12491 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
12492 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
12493 All callers changed.
12495 * w32.c (_wsa_errlist): Use braces for struct initializers.
12497 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
12498 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
12499 All callers changed.
12500 (string_buffer_position): Likewise. Also, make static (it's never
12501 used outside xdisp.c).
12502 (cursor_row_p): Remove parameter `w', unused since
12503 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
12504 (decode_mode_spec): Remove parameter `precision', introduced during
12505 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
12506 All callers changed.
12508 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12510 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
12512 2011-03-27 Anders Lindgren <andlind@gmail.com>
12514 * nsterm.m (ns_menu_bar_is_hidden): New variable.
12515 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
12516 (ns_update_auto_hide_menu_bar): New functions.
12517 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
12518 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
12519 ns_constrain_all_frames.
12520 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
12521 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
12523 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12525 * nsmenu.m (runDialogAt): Remove argument to timer_check.
12527 2011-03-27 Glenn Morris <rgm@gnu.org>
12529 * syssignal.h: Replace RETSIGTYPE with void.
12530 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
12531 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
12532 Replace SIGTYPE with void everywhere.
12533 * s/usg5-4-common.h (SIGTYPE): Remove definition.
12534 * s/template.h (SIGTYPE): Remove commented out definition.
12536 2011-03-26 Eli Zaretskii <eliz@gnu.org>
12538 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
12539 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
12541 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
12543 * w32.c (read_unc_volume): Use parameter `henum', instead of
12544 global variable `wget_enum_handle'.
12546 * keymap.c (describe_vector): Remove parameters `indices' and
12547 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
12548 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
12550 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
12552 * keyboard.c (timer_check): Remove parameter `do_it_now',
12553 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
12554 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
12555 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
12557 * keyboard.c (read_char):
12558 * w32menu.c (w32_menu_display_help):
12559 * xmenu.c (show_help_event, menu_help_callback):
12560 Adjust calls to `show_help_echo'.
12562 * gtkutil.c (xg_maybe_add_timer):
12563 * keyboard.c (readable_events):
12564 * process.c (wait_reading_process_output):
12565 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
12567 * insdel.c (adjust_markers_gap_motion):
12568 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
12569 (gap_left, gap_right): Don't call it.
12571 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
12573 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
12574 incurred during fontification.
12576 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
12578 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
12579 (DEFVAR_PER_BUFFER): Don't pass it.
12581 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
12582 (scrolling_window): Don't pass it.
12584 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
12586 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
12588 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
12590 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
12591 of variables specific to SELinux and computation of `encoded_absname'.
12593 * image.c (XPutPixel): Remove unused variable `height'.
12595 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
12597 * unexw32.c (get_section_info): Remove unused variable `section'.
12599 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
12600 (system_process_attributes): Remove unused variable `sess'.
12601 (sys_read): Remove unused variable `err'.
12603 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
12604 (w32_wnd_proc): Remove unused variable `isdead'.
12605 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
12606 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
12607 (x_create_tip_frame): Remove unused variable `tem'.
12609 * w32inevt.c (w32_console_read_socket):
12610 Remove unused variable `no_events'.
12612 * w32term.c (x_draw_composite_glyph_string_foreground):
12613 Remove unused variable `width'.
12615 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
12617 * w32term.c (x_set_glyph_string_clipping):
12618 Don't pass uninitialized region to CombineRgn.
12620 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
12622 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
12623 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
12624 (Fx_close_connection): Remove unused variable `i'.
12626 * w32font.c (w32font_draw): Return number of glyphs.
12627 (w32font_open_internal): Remove unused variable `i'.
12628 (w32font_driver): Add missing initializer.
12630 * w32menu.c (utf8to16): Remove unused variable `utf16'.
12631 (fill_in_menu): Remove unused variable `items_added'.
12633 * w32term.c (last_mouse_press_frame): Remove static global variable.
12634 (w32_clip_to_row): Remove unused variable `f'.
12635 (x_delete_terminal): Remove unused variable `i'.
12637 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
12638 (NOTHING): Remove unused static global variable.
12639 (uniscribe_check_otf): Remove unused variable `table'.
12640 (uniscribe_font_driver): Add missing initializers.
12642 2011-03-23 Julien Danjou <julien@danjou.info>
12644 * term.c (Fsuspend_tty, Fresume_tty):
12645 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
12646 * window.c (temp_output_buffer_show):
12647 * insdel.c (signal_before_change):
12648 * frame.c (Fhandle_switch_frame):
12649 * fileio.c (Fdo_auto_save):
12650 * emacs.c (Fkill_emacs):
12651 * editfns.c (save_excursion_restore):
12652 * cmds.c (internal_self_insert):
12653 * callint.c (Fcall_interactively):
12654 * buffer.c (Fkill_all_local_variables):
12655 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
12657 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
12658 unconditionally since it does the check itself.
12660 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
12662 Fix more problems found by GCC 4.5.2's static checks.
12664 * coding.c (encode_coding_raw_text): Avoid unnecessary test
12665 the first time through the loop, since we know p0 < p1 then.
12666 This also avoids a gcc -Wstrict-overflow warning.
12668 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
12669 leading to a memory leak, possible in functions like
12670 load_charset_map_from_file that can allocate an unbounded number
12671 of objects (Bug#8318).
12673 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
12674 that could (at least in theory) be that large.
12676 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
12677 This is less likely to overflow, and avoids undefined behavior if
12678 overflow does occur. All callers changed. Use strtoul to scan
12679 for the unsigned long integer.
12680 (pint2hrstr): Simplify and tune code slightly.
12681 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
12683 * scroll.c (do_scrolling): Work around GCC bug 48228.
12684 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
12686 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
12687 This also avoids a warning with gcc -Wstrict-overflow.
12688 (validate_x_resource_name): Simplify count usage.
12689 This also avoids a warning with gcc -Wstrict-overflow.
12691 * fileio.c (Fcopy_file): Report error if fchown or fchmod
12694 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
12696 * process.c (Fmake_network_process): Use socklen_t, not int,
12697 where POSIX says socklen_t is required in portable programs.
12698 This fixes a porting bug on hosts like 64-bit HP-UX, where
12699 socklen_t is wider than int (Bug#8277).
12700 (Fmake_network_process, server_accept_connection):
12701 (wait_reading_process_output, read_process_output):
12704 * process.c: Rename or move locals to avoid shadowing.
12705 (list_processes_1, Fmake_network_process):
12706 (read_process_output_error_handler, exec_sentinel_error_handler):
12707 Rename or move locals.
12708 (Fmake_network_process): Define label "retry_connect" only if needed.
12709 (Fnetwork_interface_info): Fix pointer signedness.
12710 (process_send_signal): Add cast to avoid pointer signedness problem.
12711 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
12712 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
12714 Make tparam.h and terminfo.c consistent.
12715 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
12716 Include tparam.h instead, since it declares them.
12717 * cm.h (PC): Remove extern decl; tparam.h now does this.
12718 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
12719 * terminfo.c: Include tparam.h, to check interfaces.
12720 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
12721 (tparam): Adjust signature to match interface in tparam.h;
12722 this removes some undefined behavior. Check that outstring and len
12723 are zero, which they always are with Emacs.
12724 * tparam.h (PC, BC, UP): New extern decls.
12726 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
12727 (xftfont_open): Rename locals to avoid shadowing.
12729 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
12730 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
12731 (OTF_TAG_SYM): Omit macro if not needed.
12732 (ftfont_list): Remove unused local.
12733 (get_adstyle_property, ftfont_pattern_entity):
12734 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
12735 Rename locals to avoid shadowing.
12737 * xfont.c (xfont_list_family): Mark var as initialized.
12739 * xml.c (make_dom): Now static.
12741 * composite.c (composition_compute_stop_pos): Rename local to
12743 (composition_reseat_it): Remove unused locals.
12744 (find_automatic_composition, composition_adjust_point): Likewise.
12745 (composition_update_it): Mark var as initialized.
12746 (find_automatic_composition): Mark vars as initialized,
12747 with a FIXME (Bug#8290).
12749 character.h: Rename locals to avoid shadowing.
12750 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
12751 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
12752 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
12753 (BUF_DEC_POS): Be more systematic about renaming local temporaries
12754 to avoid shadowing.
12756 * textprop.c (property_change_between_p): Remove; unused.
12758 * intervals.c (interval_start_pos): Now static.
12760 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
12762 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
12763 Rename locals to avoid shadowing.
12765 * sound.c (wav_play, au_play, Fplay_sound_internal):
12766 Fix pointer signedness.
12767 (alsa_choose_format): Remove unused local var.
12768 (wav_play): Initialize a variable to 0, to prevent undefined
12769 behavior (Bug#8278).
12771 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
12773 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
12775 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
12776 clobbering (Bug#8298).
12777 * sysdep.c (sys_subshell): Likewise.
12778 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
12780 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
12781 This should get cleaned up, so that child_setup has the
12782 same signature on all platforms.
12784 * callproc.c (call_process_cleanup): Now static.
12785 (relocate_fd): Rename locals to avoid shadowing.
12787 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
12789 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
12790 not to be necessary, and produces flickering.
12792 2011-03-20 Glenn Morris <rgm@gnu.org>
12794 * config.in: Remove file.
12796 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
12798 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
12799 are now in src/globals.h.
12800 (syms_of_minibuf): Remove spurious & from previous change.
12802 2011-03-20 Leo Liu <sdl.web@gmail.com>
12804 * minibuf.c (completing-read-function): New variable.
12805 (completing-read-default): Rename from completing-read.
12806 (completing-read): Call completing-read-function.
12808 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
12810 * xfaces.c (Fx_load_color_file):
12811 Read color file from absolute filename (bug#8250).
12813 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
12815 * makefile.w32-in: Update dependencies.
12817 2011-03-17 Eli Zaretskii <eliz@gnu.org>
12819 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
12821 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
12823 Fix more problems found by GCC 4.5.2's static checks.
12825 * process.c (make_serial_process_unwind, send_process_trap):
12826 (sigchld_handler): Now static.
12828 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
12829 That way, the code declares only the vars that it needs.
12830 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
12831 * s/cygwin.h (PTY_ITERATION): Likewise.
12832 * s/darwin.h (PTY_ITERATION): Likewise.
12833 * s/gnu-linux.h (PTY_ITERATION): Likewise.
12835 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
12836 * process.c (allocate_pty): Don't declare stb unless it's needed.
12838 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
12839 (CONSTANTLIM): Remove; unused.
12840 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
12841 Define only if needed.
12843 * unexelf.c (unexec): Name an expression,
12844 to avoid gcc -Wbad-function-cast warning.
12845 Use a different way to cause a compilation error if anyone uses
12846 n rather than nn, a way that does not involve shadowing.
12847 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
12849 * deps.mk (unexalpha.o): Remove; unused.
12851 New file unexec.h, the (simple) interface for unexec (Bug#8267).
12852 * unexec.h: New file.
12853 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
12854 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
12855 Depend on unexec.h.
12856 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
12857 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
12858 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
12859 Change as necessary to match prototype in unexec.h.
12861 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
12863 (back_comment, skip_chars): Mark vars as initialized.
12865 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
12866 Rename locals to avoid shadowing.
12868 * lread.c (read1): Rewrite so as not to use empty "else".
12869 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
12871 * print.c (Fredirect_debugging_output): Fix pointer signedess.
12873 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
12874 warning when compiling print.c.
12876 * font.c (font_unparse_fcname): Abort in an "impossible" situation
12877 instead of using an uninitialized var.
12878 (font_sort_entities): Mark var as initialized.
12880 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
12882 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
12883 pointers to constants.
12884 (font_parse_fcname): Remove unused vars.
12885 (font_delete_unmatched): Now static.
12886 (font_get_spec): Remove; unused.
12887 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
12888 (font_update_drivers, Ffont_get_glyphs, font_add_log):
12889 Rename or move locals to avoid shadowing.
12891 * fns.c (require_nesting_list, require_unwind): Now static.
12892 (Ffillarray): Rename locals to avoid shadowing.
12894 * floatfns.c (domain_error2): Define only if needed.
12895 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
12897 * alloc.c (mark_backtrace): Move decl from here ...
12898 * lisp.h: ... to here, so that it can be checked.
12900 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
12901 (Fdefvar): Rewrite so as not to use empty "else".
12902 (lisp_indirect_variable): Name an expression,
12903 to avoid gcc -Wbad-function-cast warning.
12904 (Fdefvar): Rename locals to avoid shadowing.
12906 * callint.c (quotify_arg, quotify_args): Now static.
12907 (Fcall_interactively): Rename locals to avoid shadowing.
12908 Use const pointer when appropriate.
12910 * lisp.h (get_system_name, get_operating_system_release):
12911 Move decls here, to check interfaces.
12912 * process.c (get_operating_system_release): Move decl to lisp.h.
12913 * xrdb.c (get_system_name): Likewise.
12914 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
12915 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
12916 some of which prompt warnings from gcc -Wbad-function-cast.
12917 (Fformat_time_string, Fencode_time, Finsert_char):
12918 (Ftranslate_region_internal, Fformat):
12919 Rename or remove local vars to avoid shadowing.
12920 (Ftranslate_region_internal): Mark var as initialized.
12922 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
12925 * lisp.h (eassert): Check that the argument compiles, even if
12926 ENABLE_CHECKING is not defined.
12928 * data.c (Findirect_variable): Name an expression, to avoid
12929 gcc -Wbad-function-cast warning.
12930 (default_value, arithcompare, arith_driver, arith_error): Now static.
12931 (store_symval_forwarding): Rename local to avoid shadowing.
12932 (Fmake_variable_buffer_local, Fmake_local_variable):
12933 Mark variables as initialized.
12934 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
12936 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
12937 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
12938 Rename locals to avoid shadowing.
12939 (mark_stack): Move local variables into the #ifdef region where
12941 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
12942 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
12944 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
12945 (GC_STRING_CHARS): Remove; not used.
12946 (Fmemory_limit): Cast sbrk's returned value to char *.
12948 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
12949 avoids undefined behavior in theory.
12951 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
12953 Use functions, not macros, for up- and down-casing (Bug#8254).
12954 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12955 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
12956 to use the following functions instead of these macros.
12957 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
12958 EMACS_INT, since callers assume the returned value fits in int.
12959 (upcase1): Likewise, for UPCASE_TABLE.
12960 (uppercasep, lowercasep, upcase): New static inline functions.
12961 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
12962 the race-condition problem in the old DOWNCASE.
12964 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
12965 Rename locals to avoid shadowing.
12966 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
12967 (regex_compile, re_search_2, re_match_2_internal):
12968 Remove unused local vars.
12969 (FREE_VAR): Rewrite so as not to use empty "else",
12970 which gcc can warn about.
12971 (regex_compile, re_match_2_internal): Mark locals as initialized.
12972 (RETALLOC_IF): Define only if needed.
12973 (WORDCHAR_P): Likewise. This one is never needed, but is used
12974 only in a comment talking about a compiler bug, so put inside
12975 the #if 0 of that comment.
12976 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
12977 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
12980 * search.c (boyer_moore): Rename locals to avoid shadowing.
12981 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
12982 (PREV_CHAR_BOUNDARY): Likewise.
12984 * search.c (simple_search): Remove unused var.
12986 * dired.c (compile_pattern): Move decl from here ...
12987 * lisp.h: ... to here, so that it can be checked.
12988 (struct re_registers): New forward decl.
12990 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
12992 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
12994 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
12995 Rename locals to avoid shadowing.
12996 (Fvertical_motion): Mark locals as initialized.
12998 * casefiddle.c (casify_object, casify_region): Now static.
12999 (casify_region): Mark local as initialized.
13001 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
13003 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
13004 New macros, so that the caller can use some names other than
13005 gcpro1, gcpro2, etc.
13006 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
13008 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
13009 argument, for consistency with GCPRO2_VAR, etc: it is now the
13010 prefix of the variable, not the variable itself. All uses
13012 * dired.c (directory_files_internal, file_name_completion):
13013 Rename locals to avoid shadowing.
13015 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
13016 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
13017 dired.c's scmp function, had undefined behavior.
13018 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13019 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
13020 * buffer.h: ... to here, because these macros use current_buffer,
13021 and the new implementation with inline functions needs to have
13022 current_buffer in scope now, rather than later when the macros
13024 (downcase, upcase1): New static inline functions.
13025 (DOWNCASE, UPCASE1): Reimplement using these functions.
13026 This avoids undefined behavior in expressions like
13027 DOWNCASE (x) == DOWNCASE (y), which previously suffered
13028 from race conditions in accessing the global variables
13029 case_temp1 and case_temp2.
13030 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
13031 * lisp.h (case_temp1, case_temp2): Remove their decls.
13032 * character.h (ASCII_CHAR_P): Move from here ...
13033 * lisp.h: ... to here, so that the inline functions mentioned
13034 above can use them.
13036 * dired.c (directory_files_internal_unwind): Now static.
13038 * fileio.c (file_name_as_directory, directory_file_name):
13039 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
13041 (file_name_as_directory): Use const pointers when appropriate.
13042 (Fexpand_file_name): Likewise. In particular, newdir might
13043 point at constant storage, so make it a const pointer.
13044 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
13045 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
13047 (Fset_file_times, Finsert_file_contents, auto_save_error):
13048 Rename locals to avoid shadowing.
13050 * minibuf.c (choose_minibuf_frame_1): Now static.
13051 (Ftry_completion, Fall_completions): Rename or remove locals
13052 to avoid shadowing.
13054 * marker.c (bytepos_to_charpos): Remove; unused.
13056 * lisp.h (verify_bytepos, count_markers): New decls,
13057 so that gcc does not warn that these functions aren't declared.
13059 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
13060 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
13061 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
13062 (copy_text): Remove unused local var.
13064 * filelock.c (within_one_second): Now static.
13065 (lock_file_1): Rename local to avoid shadowing.
13067 * buffer.c (fix_overlays_before): Mark locals as initialized.
13068 (fix_start_end_in_overlays): Likewise. This function should be
13069 simplified by using pointers-to-pointers, but that's a different
13071 (switch_to_buffer_1): Now static.
13072 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
13073 (report_overlay_modification): Rename locals to avoid shadowing.
13075 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
13076 Fix pointer signedness issue.
13077 (sys_subshell): Mark local as volatile if checking for lint,
13078 to suppress a gcc -Wclobbered warning that does not seem to be right.
13079 (MAXPATHLEN): Define only if needed.
13081 * process.c (serial_open, serial_configure): Move decls from here ...
13082 * systty.h: ... to here, so that they can be checked.
13084 * fns.c (get_random, seed_random): Move extern decls from here ...
13085 * lisp.h: ... to here, so that they can be checked.
13087 * sysdep.c (reset_io): Now static.
13088 (wait_for_termination_signal): Remove; unused.
13090 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
13091 (copy_keymap_item, append_key, push_text_char_description):
13093 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
13094 (DENSE_TABLE_SIZE): Remove; unused.
13095 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
13096 (describe_map_tree):
13097 Rename locals to avoid shadowing.
13099 * keyboard.c: Declare functions static if they are not used elsewhere.
13100 (echo_char, echo_dash, cmd_error, top_level_2):
13101 (poll_for_input, handle_async_input): Now static.
13102 (read_char, kbd_buffer_get_event, make_lispy_position):
13103 (make_lispy_event, make_lispy_movement, apply_modifiers):
13104 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
13105 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
13106 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
13107 (read_key_sequence, read_char): Mark locals as initialized.
13108 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
13110 * keyboard.h (make_ctrl_char): New decl.
13111 (mark_kboards): Move decl here ...
13112 * alloc.c (mark_kboards): ... from here.
13114 * lisp.h (force_auto_save_soon): New decl.
13116 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
13117 (DEFINE_DUMMY_FUNCTION): New macro.
13118 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
13120 (main): Add casts to avoid warnings
13121 if GCC considers string literals to be constants.
13123 * lisp.h (fatal_error_signal): Add decl, since it's exported.
13125 * dbusbind.c: Pointer signedness fixes.
13126 (xd_signature, xd_append_arg, xd_initialize):
13127 (Fdbus_call_method, Fdbus_call_method_asynchronously):
13128 (Fdbus_method_return_internal, Fdbus_method_error_internal):
13129 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
13130 (Fdbus_register_signal): Use SSDATA when the context wants char *.
13132 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
13133 if GCC considers string literals to be constants.
13134 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
13136 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
13138 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
13139 (print_preprocess, print_object): New macro to fix last change.
13141 * print.c (print_preprocess): Don't forget font objects.
13143 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
13145 * emacs.c (USAGE3): Doc fixes.
13147 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
13149 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
13152 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
13154 * lisp.h (VWindow_system, Qfile_name_history):
13155 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
13156 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
13157 (w32_system_caret_x, w32_system_caret_y): Declare extern.
13159 * w32select.c: Don't #include "keyboard.h".
13160 (run_protected): Add extern declaration for waiting_for_input.
13162 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
13163 * w32console.c (detect_input_pending, read_input_pending)
13164 (encode_terminal_code):
13165 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
13166 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
13167 (w32_system_caret_y, Qfile_name_history):
13168 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
13169 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
13170 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
13171 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
13172 * w32proc.c (Qlocal, report_file_error):
13173 * w32term.c (Vwindow_system, updating_frame):
13174 * w32uniscribe.c (initialized, uniscribe_font_driver):
13175 Remove unneeded extern declarations.
13177 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
13179 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
13181 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
13183 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
13184 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
13185 These macros can no longer be used for assignment.
13187 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
13188 Assign struct members directly, instead of using BUF_BEGV etc.
13189 (record_buffer_markers, fetch_buffer_markers): New functions for
13190 recording and fetching special buffer markers.
13191 (set_buffer_internal_1, set_buffer_temp): Use them.
13193 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
13195 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
13197 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
13198 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
13200 * xdisp.c (hscroll_window_tree):
13201 (reconsider_clip_changes): Use PT instead of BUF_PT.
13203 2011-03-13 Eli Zaretskii <eliz@gnu.org>
13205 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
13206 $(EMACS_ROOT)/lib/intprops.h.
13208 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
13210 Fix more problems found by GCC 4.5.2's static checks.
13212 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
13213 to unsigned char * to avoid compiler diagnostic.
13214 (xg_free_frame_widgets): Make it clear that a local variable is
13215 needed only if USE_GTK_TOOLTIP.
13216 (gdk_window_get_screen): Make it clear that this macro is needed
13217 only if USE_GTK_TOOLTIP.
13218 (int_gtk_range_get_value): New function, which avoids a diagnostic
13219 from gcc -Wbad-function-cast.
13220 (xg_set_toolkit_scroll_bar_thumb): Use it.
13221 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
13222 diagnostic from gcc -Wbad-function-cast.
13223 (get_utf8_string, xg_get_file_with_chooser):
13224 Rename locals to avoid shadowing.
13225 (create_dialog): Move locals to avoid shadowing.
13227 * xgselect.c (xg_select): Remove unused var.
13229 * image.c (four_corners_best): Mark locals as initialized.
13230 (gif_load): Initialize transparent_p to zero (Bug#8238).
13231 Mark another local as initialized.
13232 (my_png_error, my_error_exit): Mark with NO_RETURN.
13234 * image.c (clear_image_cache): Now static.
13235 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
13236 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
13237 (x_edge_detection): Remove unnecessary cast that
13238 gcc -Wbad-function-cast diagnoses.
13239 (gif_load): Fix pointer signedness.
13240 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
13241 (jpeg_load, gif_load): Rename locals to avoid shadowing.
13243 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
13245 Improve quality of tests for time stamp overflow.
13246 For example, without this patch (encode-time 0 0 0 1 1
13247 1152921504606846976) returns the obviously-bogus value (-948597
13248 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
13249 reports time overflow. See
13250 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
13251 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
13252 * editfns.c: Include limits.h and intprops.h.
13253 (TIME_T_MIN, TIME_T_MAX): New macros.
13254 (time_overflow): Move earlier, to before first use.
13255 (hi_time, lo_time): New functions, for an accurate test for
13256 out-of-range times.
13257 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
13258 (Fget_internal_run_time): Don't assume time_t fits in int.
13259 (make_time): Use list2 instead of Fcons twice.
13260 (Fdecode_time): More accurate test for out-of-range times.
13261 (check_tm_member): New function.
13262 (Fencode_time): Use it, to test for out-of-range times.
13263 (lisp_time_argument): Don't rely on undefined left-shift and
13264 right-shift behavior when checking for time stamp overflow.
13266 * editfns.c (time_overflow): New function, refactoring common code.
13267 (Fformat_time_string, Fdecode_time, Fencode_time):
13268 (Fcurrent_time_string): Use it.
13270 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
13271 * dired.c (make_time): Move to ...
13272 * editfns.c (make_time): ... here.
13273 * systime.h: Note the move.
13275 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
13277 * fringe.c (update_window_fringes): Remove unused variables.
13279 * unexmacosx.c (copy_data_segment): Also copy __got section.
13282 2011-03-12 Eli Zaretskii <eliz@gnu.org>
13284 * termcap.c [MSDOS]: Include "msdos.h".
13285 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
13286 Constify `char *' arguments and their references according to
13287 prototypes in tparam.h.
13289 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
13291 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
13292 Adapt all references accordingly.
13294 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
13296 2011-03-11 Tom Tromey <tromey@redhat.com>
13298 * buffer.c (syms_of_buffer): Remove obsolete comment.
13300 2011-03-11 Eli Zaretskii <eliz@gnu.org>
13302 * termhooks.h (encode_terminal_code): Declare prototype.
13304 * msdos.c (encode_terminal_code): Don't declare prototype.
13306 * term.c (encode_terminal_code): Now external again, used by
13307 w32console.c and msdos.c.
13309 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
13310 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
13312 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
13314 Fix some minor problems found by GCC 4.5.2's static checks.
13316 * fringe.c (update_window_fringes): Mark locals as initialized
13318 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
13320 * alloc.c (mark_fringe_data): Move decl from here ...
13321 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
13322 to check its interface.
13323 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
13325 * fontset.c (free_realized_fontset): Now static.
13326 (Fset_fontset_font): Rename local to avoid shadowing.
13327 (fontset_font): Mark local as initialized.
13328 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
13330 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
13332 * xselect.c (x_disown_buffer_selections): Remove; not used.
13333 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
13334 (x_own_selection, Fx_disown_selection_internal): Rename locals
13335 to avoid shadowing.
13336 (x_handle_dnd_message): Remove local to avoid shadowing.
13338 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
13339 so that the caller can use some name other than gcpro1.
13340 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
13341 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13342 (Fx_backspace_delete_keys_p):
13343 Use them to avoid shadowing, and rename vars to avoid shadowing.
13344 (x_decode_color, x_set_name, x_window): Now static.
13345 (Fx_create_frame): Add braces to silence GCC warning.
13346 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
13347 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
13348 Remove unused locals.
13349 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13350 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
13351 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
13354 * xterm.h (x_mouse_leave): New decl.
13356 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
13357 Remove unused functions.
13358 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
13359 (x_calc_absolute_position): Now static.
13360 (XTread_socket): Don't define label "out" unless it's used.
13361 Don't declare local "event" unless it's used.
13362 (x_iconify_frame, x_free_frame_resources): Don't declare locals
13363 unless they are used.
13364 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
13365 (x_fatal_error_signal): Remove; not used.
13366 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
13367 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
13368 (x_error_catcher, x_connection_closed, x_error_handler):
13369 (x_error_quitter, xembed_send_message, x_iconify_frame):
13370 (my_log_handler): Rename locals to avoid shadowing.
13371 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
13372 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
13374 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
13375 Rename or move locals to avoid shadowing.
13376 (tty_defined_color, merge_face_heights): Now static.
13377 (free_realized_faces_for_fontset): Remove; not used.
13378 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
13379 does not deduce is never used uninitialized.
13380 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
13381 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
13383 * terminal.c (store_terminal_param): Now static.
13385 * xmenu.c (menu_highlight_callback): Now static.
13386 (set_frame_menubar): Remove unused local.
13387 (xmenu_show): Rename parameter to avoid shadowing.
13388 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
13389 since they might point to immutable storage.
13390 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
13391 since it's unused otherwise.
13393 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
13394 Add a FIXME, since the code still doesn't look right. (Bug#8215)
13395 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
13396 avoids a gcc -Wuninitialized diagnostic.
13397 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
13398 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
13399 does not deduce are never used uninitialized.
13401 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
13403 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
13404 * window.c (window_loop, size_window):
13405 (run_window_configuration_change_hook, enlarge_window): Likewise.
13407 * window.c (display_buffer): Now static.
13408 (size_window): Mark variables that gcc -Wuninitialized
13409 does not deduce are never used uninitialized.
13410 * window.h (check_all_windows): New decl, to forestall
13411 gcc -Wmissing-prototypes diagnostic.
13412 * dispextern.h (bidi_dump_cached_states): Likewise.
13414 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
13416 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
13417 Include <limits.h>.
13418 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
13419 and to avoid gcc -Wuninitialized warning.
13420 (load_charset_map): Mark variables that gcc -Wuninitialized
13421 does not deduce are never used uninitialized.
13422 (load_charset): Abort instead of using uninitialized var (Bug#8229).
13424 * coding.c (coding_set_source, coding_set_destination):
13425 Use "else { /* comment */ }" rather than "else /* comment */;"
13426 for clarity, and to avoid gcc -Wempty-body warning.
13427 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
13428 a block, when the outer 'i' will do.
13429 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
13430 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
13431 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
13432 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
13433 (Fdecode_sjis_char, Fdefine_coding_system_internal):
13434 Rename locals to avoid shadowing.
13435 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
13436 * coding.c (emacs_mule_char, encode_invocation_designation):
13437 Now static, since they're not used elsewhere.
13438 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
13439 (decode_coding_object, encode_coding_object, detect_coding_system):
13440 (decode_coding_emacs_mule): Mark variables that gcc
13441 -Wuninitialized does not deduce are never used uninitialized.
13442 (detect_coding_iso_2022): Initialize a local variable that might
13443 be used uninitialized. Leave a FIXME because it's not clear that
13444 this initialization is needed. (Bug#8211)
13445 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
13446 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
13447 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
13448 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
13449 Remove unused macros.
13451 * category.c (hash_get_category_set): Remove unused local var.
13452 (copy_category_table): Now static, since it's not used elsewhere.
13453 * character.c (string_count_byte8): Likewise.
13455 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
13456 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
13458 * chartab.c (copy_sub_char_table): Now static, since it's not used
13460 (sub_char_table_ref_and_range, char_table_ref_and_range):
13461 Rename locals to avoid shadowing.
13462 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
13464 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
13465 (BIDI_BOB): Remove unused macro.
13467 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
13468 deduce are never used uninitialized.
13469 * term.c (encode_terminal_code): Likewise.
13471 * term.c (encode_terminal_code): Now static. Remove unused local.
13473 * tparam.h: New file.
13474 * term.c, tparam.h: Include it.
13475 * deps.mk (term.o, tparam.o): Depend on tparam.h.
13476 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
13477 Move these decls to tparam.h, and make them agree with what
13478 is actually in tparam.c. The previous trick of using incompatible
13479 decls in different modules does not conform to the C standard.
13480 All callers of tparam changed to use tparam's actual API.
13481 * tparam.c (tparam1, tparam, tgoto):
13482 Use const pointers where appropriate.
13484 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
13485 * cm.h (struct cm): Likewise.
13486 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
13487 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
13488 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
13489 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
13490 (turn_on_face, init_tty): Likewise.
13491 * termchar.h (struct tty_display_info): Likewise.
13493 * term.c (term_mouse_position): Rename local to avoid shadowing.
13495 * alloc.c (mark_ttys): Move decl from here ...
13496 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
13498 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
13500 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
13502 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
13504 * search.c (compile_pattern_1): Remove argument regp, unused since
13505 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
13506 (compile_pattern): Don't pass it.
13508 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
13510 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
13511 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
13513 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
13515 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
13517 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
13518 gdk_window_get_screen, gdk_window_get_geometry,
13519 gdk_x11_window_lookup_for_display and GDK_KEY_g.
13520 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
13521 (xg_get_pixbuf_from_pixmap): New function.
13522 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
13523 to Pixmap, take frame as parameter, remove GdkColormap parameter.
13524 Call xg_get_pixbuf_from_pixmap instead of
13525 gdk_pixbuf_get_from_drawable.
13526 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
13527 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
13528 (xg_check_special_colors): Use GtkStyleContext and its functions
13530 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
13531 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
13532 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
13533 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
13534 Call gtk_widget_get_preferred_size.
13535 (xg_frame_resized): gdk_window_get_geometry only takes 5
13537 (xg_win_to_widget, xg_event_is_for_menubar):
13538 Call gdk_x11_window_lookup_for_display.
13539 (xg_set_widget_bg): New function.
13540 (delete_cb): New function.
13541 (xg_create_frame_widgets): Connect delete-event to delete_cb.
13542 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
13543 (xg_set_background_color): Call xg_set_widget_bg.
13544 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
13545 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
13546 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
13547 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
13549 (update_frame_tool_bar): Call gtk_widget_hide.
13550 (xg_initialize): Use GDK_KEY_g.
13552 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
13554 (x_session_initialize): Call gdk_x11_set_sm_client_id.
13556 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
13557 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
13558 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
13560 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
13562 * w32xfns.c (select_palette): Check success of RealizePalette against
13563 GDI_ERROR, not zero.
13565 See ChangeLog.11 for earlier changes.
13567 ;; Local Variables:
13571 Copyright (C) 2011-2012 Free Software Foundation, Inc.
13573 This file is part of GNU Emacs.
13575 GNU Emacs is free software: you can redistribute it and/or modify
13576 it under the terms of the GNU General Public License as published by
13577 the Free Software Foundation, either version 3 of the License, or
13578 (at your option) any later version.
13580 GNU Emacs is distributed in the hope that it will be useful,
13581 but WITHOUT ANY WARRANTY; without even the implied warranty of
13582 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13583 GNU General Public License for more details.
13585 You should have received a copy of the GNU General Public License
13586 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.