1 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
3 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
4 (unwind_create_frame): New function (Bug#9943).
5 (Fx_create_frame): Restructure code to be more similar to the one in
6 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
7 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
8 Move terminal->reference_count++ just before making the frame official
11 * nsterm.m (x_free_frame_resources): New function.
12 (x_destroy_window): Move code to x_free_frame_resources.
14 * xfns.c (unwind_create_frame): Fix comment.
15 (Fx_create_frame, x_create_tip_frame): Move
16 terminal->reference_count++ just before making the frame
17 official. Move initialization of image_cache_refcount and
18 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
20 2011-11-05 Eli Zaretskii <eliz@gnu.org>
22 Support MSVC build with newer versions of Visual Studio.
23 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
24 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
27 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
28 which are not supported by MSVC.
29 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
30 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
32 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
34 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
36 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
38 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
40 Support MSVC build with newer versions of Visual Studio.
41 * w32.c: Don't include w32api.h for MSVC.
42 (init_environment) [_MSC_VER]: Call sys_access, not _access.
44 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
45 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
46 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
47 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
49 (alloca) [_MSC_VER]: Define to _alloca.
51 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
53 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
55 2011-11-04 Eli Zaretskii <eliz@gnu.org>
57 * xdisp.c (note_mouse_highlight): If either of
58 previous/next-single-property-change returns nil, treat that as
59 the beginning or the end of the buffer. (Bug#9955)
61 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
63 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
64 label is not null (Bug#9951).
65 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
68 2011-11-04 Eli Zaretskii <eliz@gnu.org>
70 * window.c (Fwindow_body_size): Mention in the doc string that the
71 return value is in frame's canonical units. (Bug#9949)
73 2011-11-03 Eli Zaretskii <eliz@gnu.org>
75 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
77 * w32fns.c (unwind_create_frame): If needed, free the glyph
78 matrices of the partially constructed frame. (Bug#9943)
79 * xfns.c (unwind_create_frame): Likewise.
81 2011-11-01 Eli Zaretskii <eliz@gnu.org>
83 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
84 Don't stop backward scan on the continuation glyph, even though
85 its CHARPOS is positive.
86 (mouse_face_from_buffer_pos, note_mouse_highlight): Rename
87 cover_string to disp_string.
89 2011-11-01 Martin Rudalics <rudalics@gmx.at>
91 * window.c (temp_output_buffer_show): Don't use
92 Vtemp_buffer_show_specifiers.
93 (Vtemp_buffer_show_specifiers): Remove unused variable.
95 2011-10-30 Eli Zaretskii <eliz@gnu.org>
97 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
98 past the beginning of the current glyph matrix.
100 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
102 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
103 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
104 HAVE_GTK3 (Bug#9869).
106 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
107 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
109 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
111 * xterm.c: Declare x_handle_net_wm_state to return int.
112 (handle_one_xevent): Check if we are iconified but don't have
113 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
114 (get_current_wm_state): Return non-zero if not hidden,
115 check for _NET_WM_STATE_HIDDEN (Bug#9893).
116 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
117 (x_handle_net_wm_state): Return what get_current_wm_state returns.
118 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
120 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
122 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
123 so that this new function doesn't get optimized away by a
124 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
126 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
128 * frame.h (MOUSE_HL_INFO): Remove excess parens.
130 2011-10-29 Eli Zaretskii <eliz@gnu.org>
132 Fix the `xbytecode' command.
133 * .gdbinit (xprintbytestr): New command.
134 (xwhichsymbols): Renamed from `which'; all callers changed.
135 (xbytecode): Print the byte-code string as well.
137 2011-10-29 Kim Storm <storm@cua.dk>
139 * alloc.c (which_symbols): New function.
141 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
143 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
146 2011-10-29 Glenn Morris <rgm@gnu.org>
148 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
149 Not clear what it was for, and it causes various bugs. (Bug#9839)
151 2011-10-28 Eli Zaretskii <eliz@gnu.org>
153 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
154 possible random value that matches one of those tested as
155 condition to clear the mouse face.
157 2011-10-28 Chong Yidong <cyd@gnu.org>
159 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
161 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
163 * window.c (make_window): Initialize phys_cursor_on_p.
165 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
167 * lisp.h (struct Lisp_Symbol): Update comments.
169 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
171 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
173 2011-10-28 Eli Zaretskii <eliz@gnu.org>
175 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
176 <oslsachem@gmail.com> for helping to debug this.
178 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
179 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
180 (g_b_init_get_glyph_outline_w): New static variables.
181 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
182 (GetGlyphOutlineW_Proc): New typedefs.
183 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
184 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
186 (w32font_open_internal, compute_metrics):
187 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
188 instead of calling the "wide" APIs directly.
190 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
192 * w32.h (syms_of_w32font): Add prototype.
194 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
196 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
197 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
198 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
199 (Fmove_to_window_line): Doc fix.
201 2011-10-27 Chong Yidong <cyd@gnu.org>
203 * process.c (make_process): Set gnutls_state to NULL.
205 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
206 non-NULL, regardless of GNUTLS_INITSTAGE.
207 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
208 an error. Set process slots as soon as we allocate them.
210 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
212 2011-10-27 Chong Yidong <cyd@gnu.org>
214 * gnutls.c (emacs_gnutls_deinit): New function.
215 Deallocate credentials structures as well as calling gnutls_deinit.
216 (Fgnutls_deinit, Fgnutls_boot): Use it.
218 * process.c (make_process): Initialize GnuTLS credentials to NULL.
219 (deactivate_process): Call emacs_gnutls_deinit.
221 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
223 * image.c (x_create_x_image_and_pixmap):
224 * w32.c (sys_rename, w32_delayed_load):
225 * w32font.c (fill_in_logfont):
226 * w32reg.c (x_get_string_resource): Silence compiler warnings.
228 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
230 * w32fns.c (w32_default_color_map): New function,
231 extracted from Fw32_default_color_map.
232 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
234 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
236 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
238 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
240 * keyboard.c (test_undefined): New function (bug#9751).
241 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
243 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
245 * sysdep.c (init_sys_modes): Fix the check for the controlling
248 2011-10-20 Eli Zaretskii <eliz@gnu.org>
250 * dispextern.h (struct bidi_it): New member next_en_type.
252 * bidi.c (bidi_line_init): Initialize the next_en_type member.
253 (bidi_resolve_explicit_1): When next_en_pos is valid for the
254 current character, check also for next_en_type being WEAK_EN.
255 (bidi_resolve_weak): Don't enter the expensive loop if the current
256 position is before next_en_pos. Record the bidi type of the first
257 non-ET, non-BN character we find, in addition to its position.
258 (bidi_level_of_next_char): Invalidate next_en_type when
259 next_en_pos is over-stepped.
261 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
263 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
264 * editfns.c: Rewrite current-time-zone so that it invokes
265 the equivalent of (format-time-string "%Z") to get the time zone name.
266 This fixes a bug when the time zone name contains characters that
267 need converting from the system time locale to Emacs internal format.
268 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
269 that patch fixed format-time-string to do the conversion, but
270 I forgot to fix current-time-zone.
271 (format_time_string): New function, containing most of
272 what Fformat_time_string used to contain.
273 (Fformat_time_string): Rewrite in terms of format_time_string.
274 This doesn't change this function's behavior.
275 (current-time-zone): Rewrite to use format_time_string.
276 This fixes the bug reported by Michael Schierl in
277 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
278 Jason Rumney's 2007-06-07 change worked around this bug, but
280 * systime.h (tzname, timezone): Remove no-longer-used declarations.
282 2011-10-19 Eli Zaretskii <eliz@gnu.org>
284 * xdisp.c (start_display): If the character at POS is displayed
285 via a display vector, reset IT->current.dpvec_index to zero.
286 (try_window_reusing_current_matrix): If a line ends in a display
287 vector or the next line starts in a display vector, continue
288 redrawing the window even though the character position of
289 start_row was reached.
292 2011-10-18 Chong Yidong <cyd@gnu.org>
294 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
295 with nobreak-char-display too.
297 2011-10-18 Eli Zaretskii <eliz@gnu.org>
299 Fix part 3 of bug#9771.
300 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
301 (bidi_resolve_neutral): Don't enter the expensive loop looking for
302 non-neutral characters if the current character is a paragraph
303 separator (a.k.a. Newline). This avoids running the same
304 expensive loop twice, once when we consume the preceding newline
305 and the other time when the line actually needs to be displayed.
306 Avoid the loop when we see neutrals on the base embedding level
307 following a character whose directionality is the same as the
308 paragraph's. This avoids running the expensive loop when a line
309 ends in a long sequence of neutrals, like control characters.
310 Add assertion against STRONG_AL type. Slightly rearrange code
311 that determines the type of a neutral given the first non-neutral
313 (bidi_level_of_next_char): Set next_en_pos to zero when
314 invalidating its info.
316 2011-10-17 Eli Zaretskii <eliz@gnu.org>
318 * xdisp.c (push_display_prop): Determine whether to record string
319 or buffer position by IT->string, not by IT->method. Allow
320 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
321 (move_it_vertically_backward): Don't look for character position
322 immediately after the newline when in a continuation line.
325 2011-10-15 Martin Rudalics <rudalics@gmx.at>
327 * window.c (coordinates_in_window): Rewrite and delabelize
328 vertical border check. (Bug#5357) (Bug#9618)
330 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
332 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
333 errors in XSetWindowBorder (bug#9310).
335 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
337 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
338 avoid crash when xmalloc overrun checking is enabled.
340 2011-10-13 Eli Zaretskii <eliz@gnu.org>
342 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
343 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
344 cursor motion with <left> and <right> arrow keys.
346 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
347 some callers set that themselves.
349 2011-10-12 Eli Zaretskii <eliz@gnu.org>
351 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
352 display string and the previous row comes from the same string and
353 is empty. (Bug#9739) (Bug#9738)
355 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
357 * doc.c (get_doc_string): Encode file name (bug#9735).
359 2011-10-12 Eli Zaretskii <eliz@gnu.org>
361 * bidi.c (bidi_level_of_next_char):
362 * xdisp.c (get_visually_first_element): Remove old incorrect
363 comments regarding the Unicode Line Separator character.
365 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
367 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
369 * alloc.c (Fgc_status): Do not access beyond zombies array
370 boundary if nzombies > MAX_ZOMBIES.
371 * alloc.c (dump_zombies): Add missing format specifier.
373 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
375 * xdisp.c (set_cursor_from_row): Simplify conditionals,
376 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
378 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
379 Some packages use them to denote characters with modifiers.
381 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
383 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
384 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
385 matching a pp-number. Rename parameter var to var1.
387 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
389 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
391 2011-10-08 Glenn Morris <rgm@gnu.org>
393 * callint.c (Fcall_interactively): Give a more explicit error for the
394 'c' case with a non-character input. (Bug#8479)
396 2011-10-08 Eli Zaretskii <eliz@gnu.org>
398 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
400 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
401 lines that are hscrolled on the left.
403 * dispnew.c (buffer_posn_from_coords): Account for a possible
404 presence of header-line. (Bug#4426)
406 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
408 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
409 Don't advertise functionality which we discourage or doesn't work.
411 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
413 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
414 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
415 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
416 this makes Emacs dump core during garbage collection on rare
417 occasions. sizeof is obviously inferior to offsetof here, so
419 (GC_POINTER_ALIGNMENT): New macro.
420 (mark_memory): Omit 3rd (offset) arg; caller changed.
421 Don't assume EMACS_INT alignment is the same as pointer alignment.
423 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
425 * keyboard.c (read_key_sequence_remapped): New var.
426 (read_key_sequence): Compute remapping in the right buffer.
427 (command_loop_1): Use read_key_sequence's remapping directly.
429 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
431 * dired.c (file_name_completion): Don't expand file name.
432 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
433 before checking file name handler.
435 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
436 they've been requested explicitly (bug#9591).
438 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
440 * keymap.c (Fsingle_key_description): Use make_specified_string
441 instead of build_string to build string from push_key_description.
444 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
446 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
447 This fixes a Y2038 bug on 64-bit hosts.
448 * buffer.c (reset_buffer):
449 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
450 (Fclear_buffer_auto_save_failure):
451 Use 0, not -1, to represent an unset failure time, since time_t
454 Remove dependency on glibc malloc internals.
455 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
456 Move back here from lisp.h, but with their new implementations.
457 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
458 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
459 * charset.c (charset_table_init): New static var.
460 (syms_of_charset): Use it instead of xmalloc. This removes a
461 dependency on glibc malloc internals. See Eli Zaretskii's comment in
462 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
463 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
464 Move back to alloc.c.
465 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
466 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
468 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
470 * nsterm.m (windowDidResize): Call x_set_window_size only when
471 ns_in_resize is true. Otherwise set pixelwidth/height and
472 call change_frame_size (Bug#9628).
474 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
476 Port --enable-checking=all to Fedora 14 x86-64.
477 * charset.c (syms_of_charset): Also account for glibc malloc's
478 internal overhead when calculating the initial malloc maximum.
480 Port --enable-checking=all to Fedora 14 x86.
481 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
483 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
484 (overrun_check_realloc, overrun_check_free):
485 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
486 That way, xmalloc returns a properly-aligned pointer even if
487 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
488 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
489 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
490 into account when calculating the initial malloc maximum.
491 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
492 Move here from alloc.c, so that charset.c can use it too.
493 Properly align; the old code wasn't right for common 32-bit hosts
494 when configured with --enable-checking=all.
495 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
496 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
498 2011-09-29 Eli Zaretskii <eliz@gnu.org>
500 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
503 2011-09-28 Eli Zaretskii <eliz@gnu.org>
505 * xdisp.c (compute_display_string_end): If there's no display
506 string at CHARPOS, return -1.
508 * bidi.c (bidi_fetch_char): When compute_display_string_end
509 returns a negative value, treat the character as a normal
510 character not covered by a display string. (Bug#9624)
512 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
514 * lread.c (Fread_from_string): Fix typo in docstring.
516 2011-09-27 Eli Zaretskii <eliz@gnu.org>
518 * xdisp.c (handle_invisible_prop): If invisible text ends on a
519 newline, reseat the iterator instead of bidi-iterating there one
520 character at a time. (Bug#9610)
521 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
522 TO_CHARPOS if the bidi iterator is at base embedding level.
524 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
526 * lread.c (readevalloop): Use correct code for NBSP.
527 (read1): Likewise. (Bug#9608)
529 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
531 * dbusbind.c (Fdbus_register_signal): When service is not
532 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
534 2011-09-25 Glenn Morris <rgm@gnu.org>
536 * buffer.c (truncate-lines): Doc fix.
538 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
540 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
541 (Fset_window_next_buffers): Doc fix.
543 2011-09-24 Glenn Morris <rgm@gnu.org>
545 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
547 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
549 Fix minor problems found by static checking.
550 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
551 * indent.c (Fvertical_motion): Fix == vs = typo.
553 2011-09-24 Eli Zaretskii <eliz@gnu.org>
555 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
556 Default value is now t. Doc fix.
558 * indent.c (Fvertical_motion): Compute and apply the overshoot
559 logic when moving up, not only when moving down. Fix the
560 confusing name and values of the it_overshoot_expected variable;
561 logic changes accordingly. (Bug#9254) (Bug#9549)
563 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
564 CHARPOS is covered by a display string which includes newlines.
565 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
566 is covered by a display string with embedded newlines.
568 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
570 * dbusbind.c (Fdbus_register_signal): Add match rule to
571 Vdbus_registered_objects_table. (Bug#9581)
572 (Fdbus_register_method, Vdbus_registered_objects_table):
575 2011-09-24 Jim Meyering <meyering@redhat.com>
577 do not ignore write error for any output size
578 The previous change was incomplete.
579 While it makes emacs --batch detect the vast majority of stdout
580 write failures, errors were still ignored whenever the output size is
581 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
582 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
583 && echo FAIL: ignored write error
584 FAIL: ignored write error
585 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
586 && echo FAIL: ignored write error
587 FAIL: ignored write error
588 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
590 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
592 * emacs.c (Fkill_emacs): In noninteractive mode exit
593 non-successfully if a write error occurred on stdout. (Bug#9574)
595 2011-09-21 Eli Zaretskii <eliz@gnu.org>
597 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
600 * dispextern.h (struct it): Update the comment documenting what
603 2011-09-20 Eli Zaretskii <eliz@gnu.org>
605 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
606 a display string, extend search for cursor position to end of row.
607 (find_row_edges): If the row ends in a newline from a display
608 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
609 Handle the case of a display string with multiple newlines.
610 (Fcurrent_bidi_paragraph_direction): Fix search for previous
611 non-empty line. Fixes confusing cursor motion with arrow keys at
612 the beginning of a line that starts with whitespace.
614 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
616 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
619 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
621 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
624 2011-09-18 Eli Zaretskii <eliz@gnu.org>
626 * xdisp.c (display_line): Record maximum and minimum buffer
627 positions even if no glyphs were produced (e.g., by a zero-width
628 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
629 buffer positions that will be removed from the glyph row because
631 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
632 column is beyond frame width: don't subtract 1 "pixel" when
633 computing width of the stretch.
634 (reseat_at_next_visible_line_start): Undo the change made on
635 2011-09-17 that saved paragraph information and restored it after
636 the call to `reseat'. (Bug#9545)
638 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
640 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
641 and turn window cursor on if cleared (Bug#9415).
643 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
645 * search.c (boyer_moore): Take unibyte characters from pattern
646 literally. (Bug#9458)
648 2011-09-18 Eli Zaretskii <eliz@gnu.org>
650 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
652 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
654 Fix minor problem found by static checking.
655 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
656 initialized, to pacify gcc -Wuninitialized.
658 * fileio.c: Report proper errno when syscall falls.
659 (Finsert_file_contents): Save and restore errno,
660 so that report_file_error outputs the correct diagnostic.
661 (Fwrite_region) [CLASH_DETECTION]: Likewise.
663 2011-09-18 Eli Zaretskii <eliz@gnu.org>
665 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
667 2011-09-17 Eli Zaretskii <eliz@gnu.org>
669 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
670 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
672 2011-09-17 Eli Zaretskii <eliz@gnu.org>
674 * xdisp.c (reseat_at_next_visible_line_start): Keep information
675 about the current paragraph and restore it after the call to reseat.
677 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
678 (bidi_find_paragraph_start): Search back for paragraph beginning
679 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
680 (bidi_move_to_visually_next): Only trigger paragraph-related
681 computations when the last character is a newline or at EOB, not
682 just any NEUTRAL_B. (Bug#9470)
684 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
685 truncated lines if point is covered by a display string. (Bug#9524)
687 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
689 * xselect.c: Relax test for outgoing X longs (Bug#9498).
690 (cons_to_x_long): New function.
691 (lisp_data_to_selection_data): Use it. Correct the test for
692 short-versus-long data; it was negated. Break out of vector
693 loop, for efficiency, when a long datum is discovered.
695 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
697 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
699 2011-09-16 Eli Zaretskii <eliz@gnu.org>
701 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
702 GCC PR/17406) by declaring this function with external scope.
704 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
706 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
707 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
709 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
711 * editfns.c (Fformat): Correctly handle text properties on "%%".
713 2011-09-15 Eli Zaretskii <eliz@gnu.org>
715 * xterm.c (x_draw_composite_glyph_string_foreground):
716 * w32term.c (x_draw_composite_glyph_string_foreground):
717 * term.c (encode_terminal_code):
718 * composite.c (composition_update_it, get_composition_id):
719 * xdisp.c (get_next_display_element)
720 (fill_composite_glyph_string): Add comments about special meaning
721 of TAB characters in a composition.
723 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
725 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
726 This occurs when processing a multibyte format.
727 Problem reported by Wolfgang Jenker.
729 2011-09-15 Johan Bockgård <bojohan@gnu.org>
731 * xdisp.c (try_cursor_movement): Only check for exact match if
732 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
734 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
736 Remove unused external symbols.
737 * dispextern.h (calc_pixel_width_or_height): Remove decl.
738 * xdisp.c (calc_pixel_width_or_height): Now static.
739 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
740 * indent.c (check_display_width):
741 * w32term.c: Fix comment to match code.
742 * xterm.c, xterm.h (x_catching_errors): Remove.
744 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
746 * xselect.c: Use signed conversions more consistently (Bug#9498).
747 (selection_data_to_lisp_data): Assume incoming selection data are
748 signed integers, not unsigned. This is to be consistent with
749 outgoing selection data, which was modified to use signed integers
750 in as part of the fix to Bug#9196 in response to Jan D.'s comment
751 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
752 expects long, not unsigned long.
754 2011-09-14 Eli Zaretskii <eliz@gnu.org>
756 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
757 computation of loop end. Reported by Johan Bockgård
760 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
762 * frame.c (Fother_visible_frames_p): Function deleted.
764 2011-09-12 Eli Zaretskii <eliz@gnu.org>
766 * indent.c (compute_motion): Process display vector front to back
767 rather than the other way around. (Bug#2496)
769 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
771 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
773 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
775 * minibuf.c (Fread_from_minibuffer): Doc fix.
777 2011-09-11 Eli Zaretskii <eliz@gnu.org>
779 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
780 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
782 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
784 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
785 value for non-existent files.
787 2011-09-11 Eli Zaretskii <eliz@gnu.org>
789 * fileio.c (Finsert_file_contents): If the file cannot be opened,
790 set its "size" to -1. This will set the modtime_size field of
791 the corresponding buffer to -1, which is what
792 verify-visited-file-modtime expects for files that do not exist.
795 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
797 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
799 * lisp.h: ... from here. push_key_description is no longer
800 defined in keyboard.c, so its declaration should not be in
801 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
802 logically belongs with push_key_description.
804 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
806 * buffer.h: Include <sys/types.h> instead of <time.h>.
807 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
808 Problem reported by Herbert J. Skuhra.
810 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
812 * xml.c (parse_region): Make the parsing work for
813 non-comment-starting XML files again (bug#9144).
815 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
817 * image.c (gif_load): Fix calculation of bottom and right corner.
820 2011-09-10 Eli Zaretskii <eliz@gnu.org>
822 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
823 redisplay in small windows.
825 2011-09-09 Eli Zaretskii <eliz@gnu.org>
827 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
829 2011-09-08 Martin Rudalics <rudalics@gmx.at>
831 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
832 Operate on live windows only.
834 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
836 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
838 2011-09-07 Eli Zaretskii <eliz@gnu.org>
840 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
841 only under bidi iteration.
843 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
845 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
847 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
849 isnan: Fix porting problem to Solaris 10 with bundled gcc.
850 Without this fix, the command to link temacs failed due to an
851 undefined symbol __builtin_isnan. This is because
852 /usr/include/iso/math_c99.h #defines isnan(x) to
853 __builtin_isnan(x), but the bundled gcc, which identifies itself
854 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
856 * floatfns.c (isnan): #undef, and then #define to a clone of
858 (Fisnan): Always define, since it's always available now.
859 (syms_of_floatfns): Always define isnan at the Lisp level.
861 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
863 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
865 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
867 * fileio.c: Fix bugs with large file offsets (Bug#9428).
868 The previous code assumed that file offsets (off_t values) fit in
869 EMACS_INT variables, which is not true on typical 32-bit hosts.
870 The code messed up by falsely reporting buffer overflow in cases
871 such as (insert-file-contents "big" nil 1 2) into an empty buffer
872 when "big" contains more than 2**29 bytes, even though this
873 inserts just one byte and does not overflow the buffer.
874 (Finsert_file_contents): Store file offsets as off_t
875 values, not as EMACS_INT values. Check for overflow when
876 converting between EMACS_INT and off_t. When checking for
877 buffer overflow or for overlap, take the offsets into account.
878 Don't use EMACS_INT for small values where int suffices.
879 When checking for overlap, fix a typo: ZV was used where
880 ZV_BYTE was intended.
881 (Fwrite_region): Don't assume off_t fits into 'long'.
882 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
884 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
886 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
888 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
890 sprintf-related integer and memory overflow issues (Bug#9412).
892 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
893 (esprintf, exprintf, evxprintf): New functions.
894 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
895 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
896 (modify_event_symbol): Do not assume that the length of
897 name_alist_or_stem is safe to alloca and fits in int.
898 (Fexecute_extended_command): Likewise for function name and binding.
899 (Frecursion_depth): Wrap around reliably on integer overflow.
900 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
901 since some callers pass EMACS_INT values.
902 (Fsingle_key_description): Don't crash if symbol name contains more
903 than MAX_ALLOCA bytes.
904 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
905 (get_minibuffer): Arg is now EMACS_INT, not int.
906 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
907 (esprintf, exprintf, evxprintf): New decls.
908 * window.h (command_loop_level, minibuf_level): Reflect API changes.
910 * dbusbind.c (signature_cat): New function.
911 (xd_signature, Fdbus_register_signal):
912 Do not overrun buffer; instead, report string overflow.
914 * dispnew.c (add_window_display_history): Don't overrun buffer.
915 Truncate instead; this is OK since it's just a log.
917 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
918 even if the time zone offset is outlandishly large.
919 Don't mishandle offset == INT_MIN.
921 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
922 when creating daemon; the previous buffer-overflow check was incorrect.
924 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
925 which has the guts of the old verror function.
927 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
928 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
930 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
931 (font_unparse_xlfd): Don't blindly alloca long strings.
932 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
933 fits in int, when using sprintf. Use single snprintf to count
934 length of string rather than counting it via multiple sprintfs;
935 that's simpler and more reliable.
936 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
937 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
938 sprintf, in case result does not fit in int.
940 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
941 (fontset_from_font): Print it.
943 * frame.c (tty_frame_count): Now printmax_t, not int.
944 (make_terminal_frame, set_term_frame_name): Print it.
945 (x_report_frame_params): In X, window IDs are unsigned long,
946 not signed long, so print them as unsigned.
947 (validate_x_resource_name): Check for implausibly long names,
948 and don't assume name length fits in 'int'.
949 (x_get_resource_string): Don't blindly alloca invocation name;
950 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
953 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
954 (xg_check_special_colors, xg_set_geometry):
955 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
957 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
958 Use esprintf, not sprintf, in case result does not fit in int.
960 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
961 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
962 it as a large positive number.
963 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
964 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
966 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
967 in case result does not fit in int.
969 * print.c (float_to_string): Detect width overflow more reliably.
970 (print_object): Make sprintf buffer a bit bigger, to avoid potential
971 buffer overrun. Don't assume list length fits in 'int'. Treat
972 print length of 0 as 0, not as infinity; to be consistent with other
973 uses of print length in this function. Don't overflow print length
974 index. Don't assume hash table size fits in 'long', or that
975 vectorlike size fits in 'unsigned long'.
977 * process.c (make_process): Use printmax_t, not int, to format
978 process-name gensyms.
980 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
982 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
983 to avoid potential buffer overrun.
985 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
986 if X resource line is longer than 512 bytes.
988 * xfns.c (x_window): Make sprintf buffer a bit bigger
989 to avoid potential buffer overrun.
991 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
993 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
995 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
997 Integer overflow fixes for scrolling, etc.
998 Without these, Emacs silently mishandles large integers sometimes.
999 For example, "C-u 4294967297 M-x recenter" was treated as if
1000 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1002 * xdisp.c (try_window_id): Check Emacs fixnum range before
1003 converting to 'int'.
1005 * window.c (window_scroll_line_based, Frecenter):
1006 Check that an Emacs fixnum is in range before assigning it to 'int'.
1007 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1008 values converted from Emacs fixnums.
1009 (Frecenter): Don't wrap around a line count if it is out of 'int'
1010 range; instead, treat it as an extreme value.
1011 (Fset_window_configuration, compare_window_configurations):
1012 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1014 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1015 that can exceed INT_MAX. Check that EMACS_INT value is in range
1016 before assigning it to the (possibly-narrower) index.
1017 (match_limit): Don't assume that a fixnum can fit in 'int'.
1019 * print.c (print_object): Use ptrdiff_t, not int, for index that can
1022 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
1023 (Fvertical_motion): Don't wrap around LINES values that don't fit
1024 in 'int'. Instead, treat them as extreme values. This is good
1025 enough for windows, which can't have more than INT_MAX lines anyway.
1027 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1029 * Require libxml/parser.h to avoid compilation warning.
1031 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1033 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1034 since this reportedly can destroy thread storage.
1036 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
1038 * syntax.c (find_defun_start): Update all cache variables if
1039 exiting early (Bug#9401).
1041 2011-08-30 Eli Zaretskii <eliz@gnu.org>
1043 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1045 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1046 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1047 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1049 * term.c (tty_append_glyph): New function.
1050 (produce_stretch_glyph): Static function and its prototype deleted.
1052 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1055 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1057 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1058 when checking :margin (Bug#9390).
1059 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
1060 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
1061 so that the name doesn't mislead. All uses changed.
1063 2011-08-28 Johan Bockgård <bojohan@gnu.org>
1065 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1068 2011-08-27 Eli Zaretskii <eliz@gnu.org>
1070 * xdisp.c (move_it_to): Don't bail out early when reaching
1071 position beyond to_charpos, if we are scanning backwards.
1072 (move_it_vertically_backward): When DY == 0, make sure we get to
1073 the first character in the line after the newline.
1075 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1077 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1078 (ccl_driver): Do not generate an out-of-range pointer.
1079 (Fccl_execute_on_string): Remove unnecessary check for
1080 integer overflow, noted by Stefan Monnier in
1081 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1082 Remove a FIXME that didn't need fixing.
1083 Simplify the newly-introduced buffer reallocation code.
1085 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
1087 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1089 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
1091 Integer and memory overflow issues (Bug#9196).
1093 * doc.c (get_doc_string): Rework so that
1094 get_doc_string_buffer_size is the actual buffer size, rather than
1095 being 1 less than the actual buffer size; this makes xpalloc more
1098 * image.c (x_allocate_bitmap_record, cache_image):
1099 * xselect.c (Fx_register_dnd_atom):
1100 Simplify previous changes by using xpalloc.
1102 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1103 since either will do and ptrdiff_t is convenient with xpalloc.
1105 * charset.c (charset_table_size)
1106 (struct charset_sort_data.priority): Now ptrdiff_t.
1107 (charset_compare): Don't overflow if priorities differ greatly.
1108 (Fsort_charsets): Don't assume list length fits in int.
1109 Check for size-calculation overflow when allocating sort data.
1110 (syms_of_charset): Allocate an initial charset table that is
1111 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1113 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1115 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1116 The actual value is always <= INT_MAX, and leaving it unsigned made
1117 overflow checking harder.
1119 * dispextern.h (struct glyph_matrix.rows_allocated)
1120 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1121 with xpalloc. The values are still always <= INT_MAX.
1123 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1125 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1126 (SAFE_NALLOCA): New macro.
1128 * region-cache.c (struct boundary.pos, find_cache_boundary)
1129 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1130 (set_cache_region, invalidate_region_cache)
1131 (revalidate_region_cache, know_region_cache, region_cache_forward)
1132 (region_cache_backward, pp_cache):
1133 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1134 so that ptrdiff_t * can be passed to xpalloc.
1135 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1136 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1137 (pp_cache): Don't assume cache_len fits in int.
1138 * region-cache.h: Adjust extern decls to match.
1140 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1141 EMACS_INT, since either will do, for xpalloc.
1143 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1144 (xnmalloc, xnrealloc, xpalloc): New functions.
1146 * bidi.c (bidi_shelve_header_size): New constant.
1147 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1148 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1150 * bidi.c (bidi_cache_shrink):
1151 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1153 Don't update size of array until after memory allocation succeeds,
1154 because xmalloc/xrealloc may not return.
1155 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1156 now that we have proper integer overflow checking.
1157 (record_overlay_string, overlay_strings): Catch overflows when
1158 calculating size of overlay_str_buf.
1160 * callproc.c (Fcall_process): Check for size overflow when
1161 calculating size of args2.
1162 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1163 Normally we prefer signed values, but sticking with ptrdiff_t would
1164 require adding more-complicated checks.
1166 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1167 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1168 Redo buffer-overflow calculations to avoid integer overflow.
1169 Add a FIXME comment where memory seems to be over-allocated.
1171 * character.c (Fstring): Check for size-calculation overflow.
1173 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1174 unnecessary integer overflow. Check for size overflow.
1175 (encode_coding_object): Don't update size until xmalloc succeeds.
1177 * composite.c (get_composition_id): Check for overflow in glyph
1178 length calculations.
1180 Integer and memory overflow fixes for display code.
1181 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1182 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1183 (scrolling_window): Check for overflow in size calculations.
1184 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1185 Don't assume glyph table len fits in int.
1186 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1187 (row_table_size): Now ptrdiff_t, not int.
1188 (scrolling_window): Avoid overflow in size calculations.
1189 Don't update size until allocation succeeds.
1190 * fns.c (concat): Check for overflow in size calculations.
1191 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1192 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1193 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1195 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1196 (get_doc_string): Check for size calculation overflow.
1197 Don't update size until allocation succeeds.
1198 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1199 EMACS_INT, where ptrdiff_t will do.
1200 (Fsubstitute_command_keys): Check for string overflow.
1202 * editfns.c (set_time_zone_rule): Don't assume environment length
1204 (message_length): Now ptrdiff_t, not int.
1205 (Fmessage_box): Don't update size until allocation succeeds.
1206 Don't assume message length fits in int.
1207 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1209 * emacs.c (main): Do not reallocate argv, since there is a null at
1210 the end that can be overwritten, and this way there's no need to
1211 worry about size-calculation overflow.
1212 (sort_args): Check for size-calculation overflow.
1214 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1216 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1218 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1219 (x_set_scroll_bar_width, x_figure_window_size):
1220 Check for integer overflow.
1221 (x_set_alpha): Do not assume XINT fits in int.
1223 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1224 This is for the members text_lines, text_cols, total_lines, total_cols,
1225 where the system imposes an 'int' limit.
1227 * fringe.c (Fdefine_fringe_bitmap):
1228 Don't update size until alloc works.
1230 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1231 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1233 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1234 Check for size-calculation overflow.
1235 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1236 do, as we prefer signed integers.
1237 (id_to_widget.max_size, id_to_widget.used)
1238 (xg_store_widget_in_map, xg_remove_widget_from_map)
1239 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1240 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1241 Use and return ptrdiff_t, not int.
1242 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1243 * gtkutil.h: Change prototypes to match the above.
1245 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1246 are duplicate now that they've been promoted to lisp.h.
1247 (x_allocate_bitmap_record, x_alloc_image_color)
1248 (make_image_cache, cache_image, xpm_load):
1249 Don't update size until alloc is done.
1250 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1252 Check for size calculation overflow.
1253 (ct_colors_allocated_max): New constant.
1254 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1257 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1258 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1259 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1260 Use ptrdiff_t, not int, to count maps.
1261 (read_char_minibuf_menu_prompt): Check for overflow in size
1262 calculations. Don't update size until allocation succeeds.
1263 Redo calculations to avoid overflow.
1264 * keyboard.h: Change prototypes to match the above.
1266 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1268 (current_minor_maps): Check for size calculation overflow.
1269 * keymap.h: Change prototypes to match the above.
1271 * lread.c (read1, init_obarray): Don't update size until alloc done.
1273 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1274 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1276 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1277 Now ptrdiff_t, not int.
1278 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1279 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1281 * process.c (Fnetwork_interface_list): Check for overflow
1282 in size calculation.
1284 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1286 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1287 overflow. Don't bother calling xmalloc when xrealloc will do.
1289 * search.c (Freplace_match): Check for size calculation overflow.
1290 (Fset_match_data): Don't assume list lengths fit in 'int'.
1292 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1293 for command line length. Do not attempt to address one before the
1294 beginning of an array, as that's not portable.
1296 * term.c (max_frame_lines): Remove; unused.
1297 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1299 (encode_terminal_code, calculate_costs): Check for size
1300 calculation overflow.
1301 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1302 table lengths and related sizes. Don't update size until alloc
1303 done. Redo calculations to avoid overflow.
1304 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1306 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1307 subtracting pointers.
1308 (gobble_line): Check for overflow more carefully. Don't update size
1311 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1312 Don't update size until alloc done.
1313 Redo size calculations to avoid overflow.
1314 Check for size calculation overflow.
1315 (main) [DEBUG]: Fix typo in invoking tparam1.
1317 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1318 Use ptrdiff_t, not int, for sizes.
1319 (store_mode_line_noprop_char): Don't update size until alloc done.
1321 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1322 Use ptrdiff_t, not int, for sizes.
1323 (Finternal_make_lisp_face, cache_face):
1324 Check for size calculation overflow.
1325 (cache_face): Treat size calculation overflows as if they were
1326 memory exhaustion (the usual treatment), rather than aborting.
1328 * xfns.c (x_encode_text, x_set_name_internal)
1329 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1330 sizes, since they can exceed INT_MAX in size. Check for size
1331 calculation overflow.
1333 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1334 (xg_select): Check for size calculation overflow.
1335 Don't update size until alloc done.
1337 * xrdb.c (get_environ_db): Don't assume path length fits in int,
1338 as sprintf is limited to int lengths.
1340 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1341 (X_LONG_MIN): New macros.
1342 Use them to make the following changes clearer.
1343 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1344 This change doesn't affect the value now, but it may help remind
1345 future maintainers not to raise the value too much later.
1346 (SELECTION_QUANTUM): Remove, replacing with ...
1347 (selection_quantum): ... new function, which avoids overflow.
1349 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1350 assumption that selection length fits in 'int'.
1351 (x_reply_selection_request, x_handle_selection_request)
1352 (x_get_window_property, receive_incremental_selection)
1353 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1354 (lisp_data_to_selection_data, clean_local_selection_data):
1355 Use ptrdiff_t, not int, to record length of selection.
1356 (x_reply_selection_request, x_get_window_property)
1357 (receive_incremental_selection, x_property_data_to_lisp):
1358 Redo calculations to avoid overflow.
1359 (x_reply_selection_request): When sending hint, ceiling it at
1360 X_LONG_MAX rather than relying on wraparound overflow to send
1362 (x_get_window_property, receive_incremental_selection)
1363 (lisp_data_to_selection_data, x_property_data_to_lisp):
1364 Check for size-calculation overflow.
1365 (x_get_window_property, receive_incremental_selection)
1366 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1367 Don't store size until memory allocation succeeds.
1368 (x_get_window_property): Plug memory leak on memory exhaustion.
1369 Don't double-block input; malloc is safe here. Don't assume 2**34
1370 - 4 fits in unsigned long. Add an xassert to check
1371 XGetWindowProperty overflow. Be more careful about overflow
1372 calculations, and distinguish size from memory overflow better.
1373 (receive_incremental_selection): When tracing, don't assume
1374 unsigned int is less than INT_MAX.
1375 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1376 harmful) conversions of unsigned short to int.
1377 (lisp_data_to_selection_data): Don't assume that integers
1378 in the range -65535 through -1 fit in an X unsigned short.
1379 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1380 result parameters unless successful. Rely on cons_to_unsigned
1381 to report problems with elements; the old code wasn't right anyway.
1382 (x_check_property_data): Check for int overflow; we cannot use
1383 a wider type due to X limits.
1384 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1386 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
1388 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1389 (x_term_init): Check for size calculation overflow.
1390 (x_color_cells): Don't store size until memory allocation succeeds.
1391 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
1392 Don't assume alloca size is less than MAX_ALLOCA.
1393 (x_term_init): Don't assume length fits in int (sprintf is limited
1396 Use ptrdiff_t for composition IDs.
1397 * character.c (lisp_string_width):
1398 * composite.c (composition_table_size, n_compositions)
1399 (get_composition_id, composition_gstring_from_id):
1400 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1401 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1402 * window.c (Frecenter):
1403 Use ptrdiff_t, not int, for composition IDs.
1404 * composite.c (get_composition_id): Check for integer overflow.
1405 * composite.h: Adjust prototypes to match the above changes.
1407 Use ptrdiff_t for hash table indexes.
1408 * category.c (hash_get_category_set):
1409 * ccl.c (ccl_driver):
1410 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1411 * coding.c (coding_system_charset_list, detect_coding_system):
1412 * coding.h (struct coding_system.id):
1413 * composite.c (get_composition_id, gstring_lookup_cache):
1414 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1415 * image.c (xpm_get_color_table_h):
1416 * lisp.h (hash_lookup, hash_put):
1417 * minibuf.c (Ftest_completion):
1418 Use ptrdiff_t for hash table indexes, not int (which is too
1419 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1420 32-bit --with-wide-int hosts).
1422 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1423 Add a FIXME comment about memory leaks.
1424 (syms_of_charset): Don't assume xmalloc returns.
1426 Don't assume that stated character widths fit in int.
1427 * character.c (Fchar_width, c_string_width, lisp_string_width):
1428 * character.h (CHAR_WIDTH):
1429 * indent.c (MULTIBYTE_BYTES_WIDTH):
1430 Use sanitize_char_width to avoid undefined and/or bad behavior
1431 with outlandish widths.
1432 * character.h (sanitize_tab_width): Rename from sanitize_width,
1433 now that we have two such functions. All uses changed.
1434 (sanitize_char_width): New inline function.
1436 Don't assume that tab-width fits in int.
1437 * character.h (sanitize_width): New inline function.
1438 (SANE_TAB_WIDTH): New macro.
1439 (ASCII_CHAR_WIDTH): Use it.
1440 * indent.c (sane_tab_width): Remove. All uses replaced by
1441 SANE_TAB_WIDTH (current_buffer).
1442 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1444 * fileio.c: Integer overflow issues with file modes.
1445 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1447 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1448 Remove unreachable code.
1449 (read_hex, load_charset_map_from_file): Check for integer overflow.
1451 * xterm.c: don't go over XClientMessageEvent limit
1452 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1453 (x_send_scroll_bar_event): Likewise. Check that the size does not
1454 exceed limits imposed by XClientMessageEvent, as well as the usual
1455 ptrdiff_t and size_t limits.
1457 * keyboard.c: Overflow, signedness and related fixes.
1458 (make_lispy_movement): Use same integer type in forward decl
1459 that is used in the definition.
1460 (read_key_sequence, keyremap_step):
1461 Change bufsize argument back to int, undoing my 2011-03-30 change.
1462 We prefer signed types, and int is wide enough here.
1463 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1464 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1465 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1466 length, not size_t. Use ptrdiff_t for index, not int.
1467 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1468 possibility of integer overflow.
1470 Overflow, signedness and related fixes for images.
1472 * dispextern.h (struct it.stack[0].u.image.image_id)
1473 (struct_it.image_id, struct image.id, struct image_cache.size)
1474 (struct image_cache.used, struct image_cache.ref_count):
1475 * gtkutil.c (update_frame_tool_bar):
1476 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1477 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1478 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1479 * nsmenu.m (update_frame_tool_bar):
1480 * xdisp.c (calc_pixel_width_or_height):
1481 * xfns.c (image_cache_refcount):
1482 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1483 on typical 64-bit hosts.
1485 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1486 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1487 Omit unnecessary casts to int.
1488 (parse_image_spec): Check that integers fall into 'int' range
1489 when the callers expect that.
1490 (image_ascent): Redo ascent calculation to avoid int overflow.
1491 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1492 (lookup_image): Remove unnecessary tests.
1493 (xbm_image_p): Locals are now of int, not EMACS_INT,
1494 since parse_image_check makes sure they fit into int.
1495 (png_load, gif_load, svg_load_image):
1496 Prefer int to unsigned where either will do.
1497 (tiff_handler): New function, combining the cores of the
1498 old tiff_error_handler and tiff_warning_handler.
1499 This function is rewritten to use vsnprintf and thereby avoid
1500 stack buffer overflows. It uses only the features of vsnprintf
1501 that are common to both POSIX and native Microsoft.
1502 (tiff_error_handler, tiff_warning_handler): Use it.
1503 (tiff_load, gif_load, imagemagick_load_image):
1504 Don't assume :index value fits in 'int'.
1505 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1506 (imagemagick_load_image): Check that crop parameters fit into
1507 the integer types that MagickCropImage accepts. Don't assume
1508 Vimagemagick_render_type has a nonnegative value. Don't assume
1509 size_t fits in 'long'.
1510 (gs_load): Use printmax_t to print the widest integers possible.
1511 Check for integer overflow when computing image height and width.
1513 2011-08-26 Eli Zaretskii <eliz@gnu.org>
1515 * xdisp.c (redisplay_window): Don't force window start if point
1516 will be invisible in the resulting window. (Bug#9324)
1518 2011-08-25 Eli Zaretskii <eliz@gnu.org>
1520 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1521 the display spec is of the form `(space ...)'.
1522 (handle_display_spec): Return the value returned by
1523 handle_single_display_spec, not just 1 or zero.
1524 (handle_single_display_spec): If the display spec is of the form
1525 `(space ...)', and specifies display in the text area, return 2
1527 (try_cursor_movement): Check for the need to scroll more
1528 accurately, and prefer exact match for point under bidi.
1529 Don't advance `row' beyond the last row of the window.
1531 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1532 into disp_prop; all users changed.
1534 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1535 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1536 for the text covered by the display property.
1538 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
1540 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1541 Change return value to nil.
1542 (Frecord_buffer): Delete unused function.
1544 2011-08-24 Eli Zaretskii <eliz@gnu.org>
1546 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1547 buffers, return left-to-right.
1548 (set_cursor_from_row): Consider candidate row a win if its glyph
1549 represents a newline and point is on that newline. Fixes cursor
1550 positioning on the newline at EOL of R2L text within L2R
1551 paragraph, and vice versa.
1552 (try_cursor_movement): Check continued rows, in addition to
1553 continuation rows. Fixes unwarranted scroll when point enters a
1554 continued line of R2L text within an L2R paragraph, or vice versa.
1555 (cursor_row_p): Consider the case of point being equal to
1556 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1557 from the end of a short line to the beginning of a continued line
1558 of R2L text within L2R paragraph.
1559 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1560 composed characters.
1562 * bidi.c (bidi_check_type): Use xassert.
1563 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1566 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1568 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1571 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
1573 * nsfont.m (ns_otf_to_script): Fix typo.
1575 2011-08-22 Kenichi Handa <handa@m17n.org>
1577 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1578 extra slot even if the purpose is char-code-property-table.
1580 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1582 * xdisp.c (redisplay_window): When computing centering_position,
1583 account for the height of the header line. (Bug#8874)
1585 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1586 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1587 candidate is selected by the mouse, and that candidate has a
1588 composed character under the mouse.
1590 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1591 coordinates reported by pos-visible-in-window-p for a composed
1592 character in column zero.
1594 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1596 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1598 2011-08-22 Eli Zaretskii <eliz@gnu.org>
1600 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1601 consider it a hit if to_charpos is anywhere in the range of the
1602 composed buffer positions.
1604 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
1606 * image.c (gif_load): Don't assume that each subimage has the same
1607 dimensions as the base image. Handle disposal method that is
1608 "undefined" by the gif spec (Bug#9335).
1610 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
1612 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
1613 (Fcondition_case): Document `debug' symbol in error handler.
1615 2011-08-19 Eli Zaretskii <eliz@gnu.org>
1617 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1618 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1619 from an Org mode buffer to a Speedbar frame.
1621 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1622 a composition, take its buffer position from IT->cmp_it.charpos.
1623 Fixes cursor positioning at the beginning of a line that begins
1624 with a composed character.
1626 2011-08-18 Eli Zaretskii <eliz@gnu.org>
1628 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1629 character bidirectional type, use STRONG_L instead. Fixes crashes
1630 in a buffer produced by `describe-categories'.
1632 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1633 members before the level stack, so they would be saved and
1634 restored when copying iterator state. Fixes incorrect reordering
1635 around TABs covered by display properties.
1637 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1639 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
1641 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
1643 * eval.c (internal_condition_case, internal_condition_case_1)
1644 (internal_condition_case_2, internal_condition_case_n):
1645 Remove unnecessary aborts (Bug#9081).
1647 2011-08-17 Eli Zaretskii <eliz@gnu.org>
1649 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1650 has no `load' handler, try opening the file locally. (Bug#9311)
1652 2011-08-16 Ken Brown <kbrown@cornell.edu>
1654 * gmalloc.c: Expand comment.
1656 2011-08-16 Eli Zaretskii <eliz@gnu.org>
1658 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1659 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1661 2011-08-16 Ken Brown <kbrown@cornell.edu>
1663 Fix memory allocation problems in Cygwin build (Bug#9273).
1665 * unexcw.c ( __malloc_initialized): Declare external variable.
1666 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1668 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1670 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1672 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1674 [CYGWIN] (special_realloc): New function.
1675 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1676 requests to realloc storage in the static heap.
1678 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1680 * bidi.c (bidi_initialize): Remove unused local.
1682 2011-08-15 Eli Zaretskii <eliz@gnu.org>
1685 * biditype.h: Remove file.
1686 * makefile.w32-in ($(BLD)/bidi.$(O)):
1687 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
1689 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1691 * chartab.c: Improve commentary for the uniprop_table API.
1693 * bidi.c (bidi_paragraph_init): Support zero value of
1694 bidi_ignore_explicit_marks_for_paragraph_level.
1695 (bidi_initialize): Use uniprop_table instead of including
1696 biditype.h and bidimirror.h.
1698 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1699 coordinates of the iterator when restoring from ppos_it.
1702 2011-08-14 Kenichi Handa <handa@m17n.org>
1704 * process.c (create_process): Call setup_process_coding_systems
1705 after the pid of the process is set to -1 (Bug#8162).
1707 2011-08-14 Eli Zaretskii <eliz@gnu.org>
1709 * xdisp.c (move_it_in_display_line_to): Don't invoke
1710 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1711 ppos_it. Fixes vertical cursor motion when line beginning is
1712 covered by an image. (Bug#9296)
1714 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1716 * nsterm.h (ns_run_ascript): Declare.
1717 (NSAPP_DATA2_RUNASSCRIPT): Define.
1719 * nsfns.m (as_script, as_result, as_status): New static variables.
1720 (ns_run_ascript): New function.
1721 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
1722 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1723 the event loop. Get status from as_status (Bug#7276).
1725 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1726 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1727 the event loop (Bug#7276).
1729 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1731 * gnutls.c (QCgnutls_bootprop_priority)
1732 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1733 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1734 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1735 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1736 (QCgnutls_bootprop_verify_hostname_error)
1737 (QCgnutls_bootprop_callbacks_verify): Rename from
1738 Qgnutls_bootprop_..., all uses changed.
1740 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1743 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1745 * xfaces.c (Qframe_set_background_mode): Now static.
1746 * dispextern.h (Qframe_set_background_mode): Remove decl.
1748 * process.c (Fnetwork_interface_info): Declare local only if needed.
1750 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1752 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1753 (Fnetwork_interface_list): Allocate in increments of bytes instead
1754 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1755 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1757 (struct ifflag_def): notrailers is smart on OSX.
1758 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1759 Get hardware address with getifaddrs if available.
1761 2011-08-12 Eli Zaretskii <eliz@gnu.org>
1763 * xdisp.c (iterate_out_of_display_property): xassert that
1764 IT->position is set to within IT->object's boundaries. Break from
1765 the loop as soon as EOB is reached; avoids infloops in redisplay
1766 when IT->position is set up wrongly due to some bug.
1767 Set IT->current to match the bidi iterator unconditionally.
1768 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1769 entry. Force push_it to save on the stack the current
1770 buffer/string position, to be restored by pop_it. Fix flags in
1771 the iterator structure wrt the object coming from a display
1772 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1773 properties. (Bug#9284)
1775 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
1777 * fontset.c (fontset_get_font_group): Add proper type checks.
1780 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1782 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1783 and LC_VERSION_MIN_MACOSX.
1784 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1785 (dump_it) [LC_FUNCTION_STARTS]: Use it.
1787 2011-08-08 Eli Zaretskii <eliz@gnu.org>
1789 * xdisp.c (forward_to_next_line_start): Allow to use the
1790 no-display-properties-and-no-overlays under bidi display.
1791 Set disp_pos in the bidi iterator to avoid searches for display
1792 properties and overlays.
1794 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
1796 * editfns.c (Fset_time_zone_rule): Document relationship with the
1799 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1800 the font entity extracted from the cache (Bug#8109).
1802 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
1804 * composite.c (autocmp_chars): Don't reset point. That is done by
1805 restore_point_unwind (Bug#5984).
1807 2011-08-07 Juri Linkov <juri@jurta.org>
1809 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1810 to show the arg `TIME' instead of `TIMEVAL'.
1812 2011-08-06 Eli Zaretskii <eliz@gnu.org>
1814 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1815 display property strides EOL and includes a newline, as in
1816 longlines-mode. (Bug#9254)
1817 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1818 word-wrap under bidirectional display. (Bug#9224)
1820 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1821 is non-zero, even if the data buffer is NULL. Fixes a crash in
1822 vertical-motion with longlines-mode. (Bug#9254)
1824 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1826 * bidi.c <bidi_cache_total_alloc>: Now static.
1827 (bidi_initialize): Initialize bidi_cache_total_alloc.
1829 * xdisp.c (display_line): Release buffer allocated for shelved bidi
1832 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1833 amount allocated this far in `bidi_cache_total_alloc'.
1834 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1835 non-zero, only free the data buffer without restoring the cache
1836 contents. All callers changed.
1838 * dispextern.h (bidi_unshelve_cache): Update prototype.
1840 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1841 (move_it_in_display_line, move_it_to)
1842 (move_it_vertically_backward, move_it_by_lines): Replace the call
1843 to xfree to an equivalent call to bidi_unshelve_cache.
1844 (move_it_in_display_line_to): Fix logic of returning
1845 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
1847 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1849 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1850 came from a string character with a `cursor' property. (Bug#9229)
1852 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1854 * Makefile.in (LIB_PTHREAD): New variable.
1855 (LIBES): Add LIB_PTHREAD (Bug#9216).
1857 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1858 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1860 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1862 * regex.c (re_iswctype): Remove some redundant boolean conversions.
1864 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1866 * xterm.c (x_find_topmost_parent): New function.
1867 (x_set_frame_alpha): Find topmost parent window with
1868 x_find_topmost_parent and set the property there also (bug#9181).
1869 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1871 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1873 * callproc.c (Fcall_process): Avoid vfork clobbering
1874 the local vars buffer, coding_systems, current_dir.
1876 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1878 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1880 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1882 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1883 so that it is not optimized away.
1885 * xdisp.c (compute_display_string_pos): Remove unused local.
1887 2011-08-02 Eli Zaretskii <eliz@gnu.org>
1889 Fix slow cursor motion and scrolling in large buffers with
1890 selective display, like Org Mode buffers. (Bug#9218)
1892 * dispextern.h (struct bidi_it): New member disp_prop_p.
1894 * xdisp.c: Remove one-slot cache of display string positions.
1895 (compute_display_string_pos): Accept an additional argument
1896 DISP_PROP_P; callers changed. Scan at most 5K characters forward
1897 for a display string or property. If found, set DISP_PROP_P
1900 * bidi.c (bidi_fetch_char): Accept an additional argument
1901 DISP_PROP_P, and pass it to compute_display_string_pos.
1902 Only handle text covered by a display string if DISP_PROP_P is returned
1903 non-zero. All callers of bidi_fetch_char changed.
1905 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1907 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1909 2010-12-03 Don March <don@ohspite.net>
1911 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1912 last character M-[char] is translated to ESC [char] (bug#7541).
1914 2011-08-02 Kenichi Handa <handa@m17n.org>
1916 * lisp.h (uniprop_table): Extern it.
1918 * chartab.c (uniprop_table): Make it non-static.
1920 2011-08-01 Eli Zaretskii <eliz@gnu.org>
1922 * xdisp.c (forward_to_next_line_start): Accept additional argument
1923 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1925 (reseat_at_next_visible_line_start): Use the bidi iterator state
1926 returned by forward_to_next_line_start to restore the state of
1927 it->bidi_it after backing up to previous newline. (Bug#9212)
1929 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1931 * regex.c (re_comp): Protoize.
1932 (re_exec): Fix return type.
1933 (regexec): Fix type of `ret'. (Bug#9203)
1935 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1937 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1938 This is needed if max-image-size is a floating-point number.
1940 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1942 * print.c (print_object): Print empty symbol as ##.
1944 * lread.c (read1): Read ## as empty symbol.
1946 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1948 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1949 setting frame foreground color (Bug#9175).
1950 (x_set_background_color): Likewise.
1952 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1953 contents (Bug#9176).
1954 (EmacsTooltip -init): Remove bezels and add shadows to
1957 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1958 or scroll bar (Bug#8470).
1960 * nsfont.m (nsfont_open): Remove assignment to voffset and
1961 unnecessary vars hshink, expand, hd, full_height, min_height.
1962 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1964 * nsterm.h (nsfont_info): Remove voffset field.
1966 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1968 Implement strike-through and overline on NextStep (Bug#8863).
1970 * nsfont.m (nsfont_open): Use underline position provided by font,
1971 instead of hard-coded value of 2.
1972 (nsfont_draw): Call ns_draw_text_decoration instead.
1974 * nsterm.h: Add declaration for ns_draw_text_decoration.
1976 * nsterm.m (ns_draw_text_decoration): New function for drawing
1977 underline, overline, and strike-through.
1978 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1979 ns_draw_text_decoration. Change treatment of cursor drawing to
1980 accommodate underlining, etc.
1982 2011-07-28 Eli Zaretskii <eliz@gnu.org>
1984 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1987 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1989 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1990 Without this fix, if a signal arrives just after memory fills up,
1991 'malloc' might be invoked reentrantly.
1993 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1994 In other words, assume that every image size is allowed, on non-X
1995 hosts. This assumption is probably wrong, but it lets Emacs compile.
1997 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1999 * regex.c (re_iswctype): Convert return values to boolean.
2001 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2003 * xdisp.c (compute_display_string_pos): Don't use cached display
2004 string position if the buffer had its restriction changed.
2007 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2009 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2011 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2013 Integer signedness and overflow and related fixes. (Bug#9079)
2015 * bidi.c: Integer size and overflow fixes.
2016 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2017 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2018 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2019 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2020 (bidi_find_other_level_edge):
2021 Use ptrdiff_t instead of EMACS_INT where either will do.
2022 This works better on 32-bit hosts configured --with-wide-int.
2023 (bidi_cache_ensure_space): Check for size-calculation overflow.
2024 Use % rather than repeated addition, for better worst-case speed.
2025 Don't set bidi_cache_size until after xrealloc returns, because it
2027 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
2028 (bidi_cache_ensure_space): Also check that the bidi cache size
2029 does not exceed that of the largest Lisp string or buffer. See Eli
2030 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
2032 * alloc.c (__malloc_size_t): Remove.
2033 All uses replaced by size_t. See Andreas Schwab's note
2034 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2036 * image.c: Improve checking for integer overflow.
2037 (check_image_size): Assume that f is nonnull, since
2038 it is always nonnull in practice. This is one less thing to
2039 worry about when checking for integer overflow later.
2040 (x_check_image_size): New function, which checks for integer
2041 overflow issues inside X.
2042 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2043 This removes the need for a memory_full check.
2044 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2045 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2046 (xbm_read_bitmap_data): Change locals back to 'int', since
2047 their values must fit in 'int'.
2048 (xpm_load_image, png_load, tiff_load):
2049 Invoke x_create_x_image_and_pixmap earlier,
2050 to avoid much needless work if the image is too large.
2051 (tiff_load): Treat overly large images as if
2052 x_create_x_image_and_pixmap failed, not as malloc failures.
2053 (gs_load): Use x_check_image_size.
2055 * gtkutil.c: Omit integer casts.
2056 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2057 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2059 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2061 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2062 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2063 would wrongly return t on a 64-bit host.
2065 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2066 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2067 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2068 and therefore cause GCC to emit a bogus diagnostic in some cases.
2070 * image.c: Integer signedness and overflow and related fixes.
2071 This is not an exhaustive set of fixes, but it's time to
2072 record what I've got.
2073 (lookup_pixel_color, check_image_size): Remove redundant decls.
2074 (check_image_size): Don't assume that arbitrary EMACS_INT values
2075 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2076 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2077 (tiff_load, imagemagick_load_image):
2078 Check for overflow in size calculations.
2079 (x_create_x_image_and_pixmap): Remove unnecessary test for
2080 xmalloc returning NULL; that can't happen.
2081 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2082 (xpm_color_bucket): Use better integer hashing function.
2083 (xpm_cache_color): Don't possibly over-allocate memory.
2084 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2085 (gif_memory_source):
2086 Use ptrdiff_t, not int or size_t, to record sizes.
2087 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2088 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2089 either works, as we prefer signed integers.
2090 (tiff_read_from_memory, tiff_write_from_memory):
2091 Return tsize_t, not size_t, since that's what the TIFF API wants.
2092 (tiff_read_from_memory): Don't fail simply because the read would
2093 go past EOF; instead, return a short read.
2094 (tiff_load): Omit no-longer-needed casts.
2095 (Fimagemagick_types): Don't assume size fits into 'int'.
2097 Improve hashing quality when configured --with-wide-int.
2098 * fns.c (hash_string): New function, taken from sxhash_string.
2099 Do not discard information about ASCII character case; this
2100 discarding is no longer needed.
2101 (sxhash-string): Use it. Change sig to match it. Caller changed.
2102 * lisp.h: Declare it.
2103 * lread.c (hash_string): Remove, since we now use fns.c's version.
2104 The fns.c version returns a wider integer if --with-wide-int is
2105 specified, so this should help the quality of the hashing a bit.
2107 * emacs.c: Integer overflow minor fix.
2108 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2109 Define only if GNU_LINUX.
2110 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2112 * dispnew.c: Integer signedness and overflow fixes.
2113 Remove unnecessary forward decls, that were a maintenance hassle.
2114 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2116 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2117 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2118 (prepare_desired_row, line_draw_cost):
2119 Use int, not unsigned, where either works.
2120 (save_current_matrix, restore_current_matrix):
2121 Use ptrdiff_t, not size_t, where either works.
2122 (init_display): Check for overflow more accurately, and without
2123 relying on undefined behavior.
2125 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2126 Remove, replacing with the new symbols in lisp.h. All uses changed.
2127 * fileio.c (make_temp_name):
2128 * filelock.c (lock_file_1, lock_file):
2129 * xdisp.c (message_dolog):
2130 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2131 Use pMd etc. instead.
2132 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2133 replacing the pWIDE etc. symbols removed from editfns.c.
2135 * keyboard.h (num_input_events): Now uintmax_t.
2136 This is (very slightly) less likely to mess up due to wraparound.
2139 * buffer.c: Integer signedness fixes.
2140 (alloc_buffer_text, enlarge_buffer_text):
2141 Use ptrdiff_t rather than size_t when either will do, as we prefer
2144 * alloc.c: Integer signedness and overflow fixes.
2145 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2146 (__malloc_size_t): Default to size_t, not to int.
2147 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2148 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2149 Prefer ptrdiff_t to size_t when either would do, as we prefer
2151 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2152 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2153 Now const. Initialize with values that are in range even if char
2155 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2156 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2157 These functions do the right thing with sizes > 2**32.
2158 (check_depth): Now ptrdiff_t, not int.
2159 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2160 Adjust to new way of storing sizes. Check for size overflow bugs
2162 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2163 slightly wrong anyway, as it missed one instance of
2164 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2165 (refill_memory_reserve): Omit needless cast to size_t.
2166 (mark_object_loop_halt): Mark as externally visible.
2168 * xselect.c: Integer signedness and overflow fixes.
2169 (Fx_register_dnd_atom, x_handle_dnd_message):
2170 Use ptrdiff_t, not size_t, since we prefer signed.
2171 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2172 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2173 x_dnd_atoms_size and x_dnd_atoms_length.
2175 * doprnt.c: Prefer signed to unsigned when either works.
2177 * doprnt.c (doprnt):
2179 * xdisp.c (vmessage):
2180 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2181 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2182 prefer signed arithmetic to avoid comparison confusion.
2183 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2184 but is a bit tricky.
2186 Assume freestanding C89 headers, string.h, stdlib.h.
2187 * data.c, doprnt.c, floatfns.c, print.c:
2188 Include float.h unconditionally.
2189 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2190 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2191 * regex.c: Likewise for stddef.h, string.h.
2192 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2193 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2194 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2195 (STDC_HEADERS): Remove obsolete defines.
2196 * sysdep.c: Include limits.h unconditionally.
2198 Assume support for memcmp, memcpy, memmove, memset.
2199 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2200 * regex.c (memcmp, memcpy):
2201 Remove; we assume C89 now.
2203 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2204 (__malloc_safe_bcopy): Remove; no longer needed.
2206 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
2207 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2208 well either way, and we prefer signed to unsigned.
2210 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2212 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2213 closes the connection while we're reading (bug#9182).
2215 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
2217 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2218 are specified (Bug#9168).
2220 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2222 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2223 Found by GCC static checking and --with-wide-int on a 32-bit host.
2225 2011-07-25 Eli Zaretskii <eliz@gnu.org>
2227 * xdisp.c (compute_display_string_pos): Fix logic of caching
2228 previous display string position. Initialize cached_prev_pos to
2229 -1. Fixes slow-down at the beginning of a buffer.
2231 2011-07-24 Eli Zaretskii <eliz@gnu.org>
2233 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2234 for attrs[LFACE_FONTSET_INDEX].
2236 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2238 * xml.c (parse_region): Remove unused local
2239 that was recently introduced.
2241 2011-07-23 Eli Zaretskii <eliz@gnu.org>
2243 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2244 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2246 * xdisp.c (move_it_in_display_line_to): Record the best matching
2247 position for TO_CHARPOS while scanning the line, and restore it on
2248 exit if none of the characters scanned was an exact match.
2249 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
2250 when exact match is impossible due to invisible text, and the
2251 lines are truncated.
2253 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2255 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2258 2011-07-22 Eli Zaretskii <eliz@gnu.org>
2260 Fix a significant slow-down of cursor motion with C-n, C-p,
2261 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2262 auto-repeat under bidi redisplay in fontified buffers.
2263 * xdisp.c (compute_stop_pos_backwards): New function.
2264 (next_element_from_buffer): Call compute_stop_pos_backwards to
2265 find a suitable prev_stop when we find ourselves before
2267 (reseat): Don't look for prev_stop, as that could mean a very long
2269 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2270 <cached_disp_overlay_modiff>: Cache for last found display string
2272 (compute_display_string_pos): Return the cached position if asked
2273 about the same buffer in the same area of character positions, and
2274 the buffer wasn't changed since the time the display string
2275 position was cached.
2277 2011-07-22 Eli Zaretskii <eliz@gnu.org>
2279 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2280 is an integer, which is important for empty lines. (Bug#9149)
2282 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
2284 * frame.c (Fmodify_frame_parameters): In tty case, update the
2285 default face if necessary (Bug#4238).
2287 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
2289 * editfns.c (Fstring_to_char): No need to explain what a character
2290 is in the docstring (Bug#6576).
2292 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2294 * xml.c (parse_region): Make sure we always return a tree.
2296 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2298 * xml.c (parse_region): If a document contains only comments,
2301 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2303 * xml.c (make_dom): Return comments, too.
2305 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2308 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2309 and the surrounding thread.
2310 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2311 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2312 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2314 * s/openbsd.h (BROKEN_SIGIO): Define.
2315 * unexelf.c (unexec) [__OpenBSD__]:
2316 Don't update the .mdebug section of the Alpha COFF symbol table.
2318 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2320 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2323 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2325 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2326 This fixes some race conditions on the permissions of any newly
2329 * alloc.c (valid_pointer_p): Use pipe, not open.
2330 This fixes some permissions issues when debugging.
2332 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2333 If fchown fails to set both uid and gid, try to set just gid,
2334 as that is sometimes allowed. Adjust the file's mode to eliminate
2335 setuid or setgid bits that are inappropriate if fchown fails.
2337 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2339 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2340 to compare Lisp_Objects.
2341 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2342 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2343 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2345 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2347 * lread.c (read_integer): Unread even EOF character.
2348 (read1): Likewise. Properly record start position of symbol.
2350 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2351 symbol character follows.
2353 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2355 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2356 This works around a problem with the previous change to Fcopy_file.
2357 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2358 and without this change, GCC might complain about discarding
2359 fchown's return value.
2361 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
2363 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2365 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2367 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2369 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2371 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2372 it's used from the C level.
2374 * process.c: Use the same condition for POLL_FOR_INPUT in both
2375 keyboard.c and process.c (bug#1858).
2377 2011-07-09 Lawrence Mitchell <wence@gmx.li>
2379 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2380 (Fgnutls_boot): Use it.
2382 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2384 * doc.c (Fsubstitute_command_keys): Revert last change.
2386 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2388 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2389 quotes the next character, and doesn't affect other longer
2390 sequences (bug#8935).
2392 * lread.c (syms_of_lread): Clarify that is isn't only
2393 `eval-buffer' and `eval-defun' that's affected by
2394 `lexical-binding' (bug#8460).
2396 2011-07-15 Eli Zaretskii <eliz@gnu.org>
2398 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
2399 bidi redisplay when a line includes both an image and is truncated.
2401 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2403 Fix minor problems found by static checking.
2404 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2405 (elsz): Now a signed constant, not a size_t var. We prefer signed
2406 types to unsigned, to avoid integer comparison confusion. Without
2407 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2408 "cannot optimize loop, the loop counter may overflow", a symptom
2410 * indent.c (Fvertical_motion): Mark locals as initialized.
2411 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2413 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2415 * search.c (Fre_search_backward): Mention `case-fold-search' in
2416 all the re_search_* functions (bug#8138).
2418 * keyboard.c (Fopen_dribble_file): Document when the file is
2421 2011-07-14 Eli Zaretskii <eliz@gnu.org>
2423 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2426 Support bidi reordering of display and overlay strings.
2427 * xdisp.c (compute_display_string_pos)
2428 (compute_display_string_end): Accept additional argument STRING.
2429 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2430 (reseat_to_string): Initialize bidi_it->string.s and
2431 bidi_it->string.schars.
2432 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
2433 NULL (avoids a crash in bidi_paragraph_init).
2434 Initialize itb.string.lstring.
2435 (init_iterator): Call bidi_init_it only of a valid
2436 buffer position was specified. Initialize paragraph_embedding to
2438 (reseat_to_string): Initialize the bidi iterator.
2439 (display_string): If we need to ignore text properties of
2440 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2441 original value of -1 will not work with bidi.)
2442 (compute_display_string_pos): First arg is now struct
2443 `text_pos *'; all callers changed. Support display properties on
2445 (compute_display_string_end): Support display properties on Lisp
2447 (init_iterator, reseat_1, reseat_to_string): Initialize the
2448 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2449 when iterating on a string not from display properties).
2450 (compute_display_string_pos, compute_display_string_end):
2451 Fix calculation of the object to scan. Fixes an error when using
2453 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
2454 base_level_stop; instead, set base_level_stop to BEGV.
2455 Fixes crashes in vertical-motion.
2456 (next_element_from_buffer): Improve commentary for when
2457 the iterator is before prev_stop.
2458 (init_iterator): Initialize bidi_p from the default value of
2459 bidi-display-reordering, not from buffer-local value. Use the
2460 buffer-local value only if initializing for buffer iteration.
2461 (handle_invisible_prop): Support invisible properties on strings
2462 that are being bidi-reordered.
2463 (set_iterator_to_next): Support bidi reordering of C strings and
2465 (next_element_from_string): Support bidi reordering of Lisp
2467 (handle_stop_backwards): Support Lisp strings as well.
2468 (display_string): Support display of R2L glyph rows.
2469 Use IT_STRING_CHARPOS when displaying from a Lisp string.
2470 (init_iterator): Don't initialize it->bidi_p for strings
2472 (reseat_to_string): Initialize it->bidi_p for strings here.
2473 (next_element_from_string, next_element_from_c_string)
2474 (next_element_from_buffer): Add xassert's for correspondence
2475 between IT's object being iterated and it->bidi_it.string
2477 (face_before_or_after_it_pos): Support bidi iteration.
2478 (next_element_from_c_string): Handle the case of the first string
2479 character that is not the first one in the visual order.
2480 (get_visually_first_element): New function, refactored from common
2481 parts of next_element_from_buffer, next_element_from_string, and
2482 next_element_from_c_string.
2483 (tool_bar_lines_needed, redisplay_tool_bar)
2484 (display_menu_bar): Force left-to-right direction. Add a FIXME
2485 comment for making that be controlled by a user option.
2486 (push_it, pop_it): Save and restore the state of the
2487 bidi iterator. Save and restore the bidi_p flag.
2488 (pop_it): Iterate out of display property for string iteration as
2490 (iterate_out_of_display_property): Support iteration over strings.
2491 (handle_single_display_spec): Set up it->bidi_it for iteration
2492 over a display string, and call bidi_init_it.
2493 (handle_single_display_spec, next_overlay_string)
2494 (get_overlay_strings_1, push_display_prop): Set up the bidi
2495 iterator for displaying display or overlay strings.
2496 (forward_to_next_line_start): Don't use the shortcut if
2498 (back_to_previous_visible_line_start): If handle_display_prop
2499 pushed the iterator stack, restore the internal state of the bidi
2500 iterator by calling bidi_pop_it same number of times.
2501 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2502 and we are bidi-iterating, don't decrement the iterator position;
2503 instead, set the first_elt flag in the bidi iterator, to produce
2505 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2506 (push_display_prop): xassert that we are iterating a buffer.
2507 (push_it, pop_it): Save and restore paragraph_embedding member.
2508 (handle_single_display_spec, next_overlay_string)
2509 (get_overlay_strings_1, reseat_1, reseat_to_string)
2510 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2511 correctly. Don't assume unibyte strings are not bidi-reordered.
2512 (compute_display_string_pos)
2513 (compute_display_string_end): Fix handling the case of C string.
2514 (push_it, pop_it): Save and restore from_disp_prop_p.
2515 (handle_single_display_spec, push_display_prop): Set the
2516 from_disp_prop_p flag.
2517 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2518 (pop_it): Call iterate_out_of_display_property only if we are
2519 popping after iteration over a string that came from a display
2520 property. Fix a typo in popping stretch info. Add an assertion
2521 for verifying that the iterator position is in sync with the bidi
2523 (handle_single_display_spec, get_overlay_strings_1)
2524 (push_display_prop): Fix initialization of paragraph direction for
2525 string when that of the parent object is not yet determined.
2526 (reseat_1): Call bidi_init_it to resync the bidi
2527 iterator with IT's position. (Bug#7616)
2528 (find_row_edges): If ROW->start.pos gives position
2529 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2530 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2531 Reset the from_disp_prop_p flag.
2532 (SAVE_IT, RESTORE_IT): New macros.
2533 (pos_visible_p, face_before_or_after_it_pos)
2534 (back_to_previous_visible_line_start)
2535 (move_it_in_display_line_to, move_it_in_display_line)
2536 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2537 (try_scrolling, redisplay_window, display_line): Use them when
2538 saving a temporary copy of the iterator and restoring it back.
2539 (back_to_previous_visible_line_start, reseat_1)
2540 (init_iterator): Empty the bidi cache "stack".
2541 (move_it_in_display_line_to): If iterator ended up at
2542 EOL, but we never saw any buffer positions smaller than
2543 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2544 motion in bidi-reordered lines.
2545 (move_it_in_display_line_to): Record prev_method and prev_pos
2546 immediately before the call to set_iterator_to_next. Fixes cursor
2547 motion in bidi-reordered lines with stretch glyphs and strings
2548 displayed in margins. (Bug#8133) (Bug#8867)
2549 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2551 (pos_visible_p): Support positions in bidi-reordered lines.
2552 Save and restore bidi cache.
2554 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2555 (bidi_paragraph_info): Delete unused struct.
2556 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2557 (bidi_cache_start): New variable.
2558 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2560 (bidi_cache_fetch_state, bidi_cache_search)
2561 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2562 (bidi_cache_find, bidi_peek_at_next_level)
2563 (bidi_level_of_next_char, bidi_find_other_level_edge)
2564 (bidi_move_to_visually_next): Compare cache index with
2565 bidi_cache_start rather than with zero.
2566 (bidi_fetch_char): Accept new argument STRING; all callers
2567 changed. Support iteration over a string. Support strings with
2568 display properties. Support unibyte strings. Fix the type of
2569 `len' according to what STRING_CHAR_AND_LENGTH expects.
2570 (bidi_paragraph_init, bidi_resolve_explicit_1)
2571 (bidi_resolve_explicit, bidi_resolve_weak)
2572 (bidi_level_of_next_char, bidi_move_to_visually_next):
2573 Support iteration over a string.
2574 (bidi_set_sor_type, bidi_resolve_explicit_1)
2575 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2576 can now be zero (for strings); special values 0 and -1 were
2577 changed to -1 and -2, respectively.
2578 (bidi_char_at_pos): New function.
2579 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2580 Call it instead of FETCH_MULTIBYTE_CHAR.
2581 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2582 initialized to valid values.
2583 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2585 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2586 the test for valid cached positions. Fix the logic for looking up
2587 the sentinel state in the cache. GCPRO the Lisp string we are
2589 (bidi_push_it, bidi_pop_it): New functions.
2590 (bidi_initialize): Initialize the bidi cache start stack pointer.
2591 (bidi_cache_ensure_space): New function, refactored from part of
2592 bidi_cache_iterator_state. Don't assume the required size is just
2593 one BIDI_CACHE_CHUNK away.
2594 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2595 (bidi_count_bytes, bidi_char_at_pos): New functions.
2596 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2597 always valid if bidi_cache_idx is valid.
2598 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2599 is valid if it's going to be used.
2600 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2601 (bidi_cache_fetch_state, bidi_cache_search)
2602 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2603 (bidi_cache_iterator_state, bidi_cache_find)
2604 (bidi_find_other_level_edge, bidi_cache_start_stack):
2605 All variables related to cache indices are now EMACS_INT.
2607 * dispextern.h (struct bidi_string_data): New structure.
2608 (struct bidi_it): New member `string'. Make flag members be 1-bit
2609 fields, and put them last in the struct.
2610 (compute_display_string_pos, compute_display_string_end):
2612 (bidi_push_it, bidi_pop_it): Add prototypes.
2613 (struct iterator_stack_entry): New members bidi_p,
2614 paragraph_embedding, and from_disp_prop_p.
2615 (struct it): Member bidi_p is now a bit field 1 bit wide.
2616 (bidi_shelve_cache, bidi_unshelve_cache):
2619 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2620 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2621 and vector-like objects.
2623 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2624 cache around display iteration.
2626 * window.c (Fwindow_end, window_scroll_pixel_based)
2627 (displayed_window_lines, Frecenter): Save and restore the bidi
2628 cache around display iteration.
2630 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2632 * editfns.c (Fdelete_region): Clarify the use of the named
2633 parameters (bug#6788).
2635 2011-07-14 Martin Rudalics <rudalics@gmx.at>
2637 * indent.c (Fvertical_motion): Set and restore w->pointm when
2638 saving and restoring the window's buffer (Bug#9006).
2640 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2642 * editfns.c (Fstring_to_char): Clarify just what is returned
2643 (bug#6576). Text by Eli Zaretskii.
2645 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
2647 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2649 2011-07-13 Eli Zaretskii <eliz@gnu.org>
2651 * buffer.c (mmap_find): Fix a typo.
2653 2011-07-13 Johan Bockgård <bojohan@gnu.org>
2655 Fix execution of x selection hooks.
2656 * xselect.c (Qx_lost_selection_functions)
2657 (Qx_sent_selection_functions): New vars.
2658 (syms_of_xselect): DEFSYM them.
2659 (x_handle_selection_request): Pass Qx_sent_selection_functions
2660 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2661 (x_handle_selection_clear,x_clear_frame_selections):
2662 Pass Qx_lost_selection_functions rather than
2663 Vx_lost_selection_functions to Frun_hook_with_args.
2665 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2667 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2668 The old code sometimes used this field without initializing it.
2670 * alloc.c (gc_sweep): Don't read past end of array.
2671 In theory, the old code could also have corrupted Emacs internals,
2672 though it'd be very unlikely.
2674 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2676 * character.c (Fcharacterp): Don't advertise optional ignored
2677 argument. (Bug#4026)
2679 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2681 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2684 * window.c (Fset_window_start): Doc fix (bug#4199).
2685 (Fset_window_hscroll): Ditto.
2687 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2689 Fix minor new problems caught by GCC 4.6.1.
2690 * term.c (init_tty): Remove unused local.
2691 * xsettings.c (store_monospaced_changed): Define this function only
2692 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
2695 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
2697 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2699 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2701 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2702 are the mini-buffer and the echo area (bug#3320).
2704 * term.c (init_tty): Remove support for supdup, c10 and perq
2705 terminals, which are no longer supported (bug#1482).
2707 2011-07-10 Johan Bockgård <bojohan@gnu.org>
2709 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2711 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2713 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2714 for non-popups (Bug#3642).
2716 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2718 * alloc.c (reset_malloc_hooks): Protoize.
2719 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
2720 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2721 * cm.c (losecursor): Likewise.
2722 * data.c (fmod): Likewise.
2723 * dispnew.c (swap_glyphs_in_rows): Likewise.
2724 * emacs.c (memory_warning_signal): Likewise.
2725 * floatfns.c (float_error): Likewise.
2726 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2727 (otf_open, font_otf_capability, generate_otf_features)
2728 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2730 * image.c (pbm_read_file): Likewise.
2731 * indent.c (string_display_width): Likewise.
2732 * intervals.c (check_for_interval, search_for_interval)
2733 (inc_interval_count, count_intervals, root_interval)
2734 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2735 * lread.c (defalias): Likewise.
2736 * ralloc.c (r_alloc_check): Likewise.
2737 * regex.c (set_image_of_range_1, set_image_of_range)
2738 (regex_grow_registers): Likewise.
2739 * sysdep.c (strerror): Likewise.
2740 * termcap.c (valid_filename_p, tprint, main): Likewise.
2741 * tparam.c (main): Likewise.
2742 * unexhp9k800.c (run_time_remap, save_data_space)
2743 (update_file_ptrs, read_header, write_header, calculate_checksum)
2744 (copy_file, copy_rest, display_header): Likewise.
2745 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2747 * xdisp.c (check_it): Likewise.
2748 * xfaces.c (register_color, unregister_color, unregister_colors):
2750 * xfns.c (print_fontset_result): Likewise.
2751 * xrdb.c (member, fatal, main): Likewise.
2753 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2755 Fix minor problems found by static checking (Bug#9031).
2756 * chartab.c (char_table_set_range, map_sub_char_table):
2757 Remove unused locals.
2758 (uniprop_table): Now static.
2759 * composite.c (_work_char): Remove unused static var.
2761 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
2763 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2765 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2767 * gtkutil.c (qttip_cb): Remove code without function.
2769 2011-07-09 Eli Zaretskii <eliz@gnu.org>
2771 * w32.c (pthread_sigmask): New stub.
2773 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
2775 Use pthread_sigmask, not sigprocmask (Bug#9010).
2776 sigprocmask is portable only for single-threaded applications, and
2777 Emacs can be multi-threaded when it uses GTK.
2778 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2780 * callproc.c (Fcall_process):
2781 * process.c (create_process):
2782 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2783 Use pthread_sigmask, not sigprocmask.
2785 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2787 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2788 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2791 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2793 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2794 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2795 (xg_hide_tooltip): Fix comment.
2797 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2798 in registerServicesMenuSendTypes.
2799 (validRequestorForSendType): Don't check ns_return_types.
2801 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2804 2011-07-08 Jason Rumney <jasonr@gnu.org>
2806 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2807 frame struct members of non-existent frames (Bug#6284).
2809 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2811 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2812 variable firstTime not needed on OSX >= 10.6.
2813 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2814 >= 10.5. Use setKnobProportion, setDoubleValue.
2816 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2817 (MAC_OS_X_VERSION_10_5): Define if not defined.
2818 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2819 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2820 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2822 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2823 cString and lossyCString on OSX >= 10.4
2825 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2826 sizeToFit on OSX >= 10.2.
2828 * nsimage.m (allocInitFromFile): Don't use deprecated method
2829 bestRepresentationForDevice on OSX >= 10.6.
2831 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2834 * emacs.c: Declare unexec_init_emacs_zone.
2836 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2838 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2840 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2841 on svcsMenu (Bug#8842).
2843 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2845 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2847 * nsterm.m (QUTF8_STRING): Declare.
2848 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2849 (validRequestorForSendType): Return type is (id).
2850 Change indexOfObjectIdenticalTo to indexOfObject.
2851 Check if we have local selection before returning self (Bug#8842).
2852 (writeSelectionToPasteboard): Put local selection into paste board
2853 if we have a local selection (Bug#8842).
2854 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2856 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2857 (ns_get_local_selection): Declare.
2859 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2861 * keymap.c (describe_map_tree): Don't insert a double newline at
2862 the end of the buffer (bug#1169) and return whether we inserted
2865 * callint.c (Fcall_interactively): Change "reading args" to
2866 "providing args" to try to clarify what it does (bug#1010).
2868 2011-07-07 Kenichi Handa <handa@m17n.org>
2870 * composite.c (composition_compute_stop_pos): Ignore a static
2871 composition starting before CHARPOS (Bug#8915).
2873 * xdisp.c (handle_composition_prop): Likewise.
2875 2011-07-07 Eli Zaretskii <eliz@gnu.org>
2877 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2880 2011-07-07 Kenichi Handa <handa@m17n.org>
2882 * character.h (unicode_category_t): New enum type.
2884 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2885 (Qchar_code_property_table): New variable.
2886 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2887 (UNIPROP_COMPRESSED_FORM_P): New macros.
2888 (char_table_ascii): Uncompress the compressed values.
2889 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2890 Uncompress the compressed values.
2891 (sub_char_table_ref_and_range): Likewise.
2892 (char_table_ref_and_range): Uncompress the compressed values.
2893 (sub_char_table_set): New arg is_uniprop. Callers changed.
2894 Uncompress the compressed values.
2895 (sub_char_table_set_range): Args changed. Callers changed.
2896 (char_table_set_range): Adjuted for the above change.
2897 (map_sub_char_table): Delete args default_val and parent. Add arg
2898 top. Give decoded values to a Lisp function.
2899 (map_char_table): Adjust for the above change. Give decoded
2900 values to a Lisp function. Gcpro more variables.
2901 (uniprop_table_uncompress)
2902 (uniprop_decode_value_run_length): New functions.
2903 (uniprop_decoder, uniprop_decoder_count): New variables.
2904 (uniprop_get_decoder, uniprop_encode_value_character)
2905 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2907 (uniprop_encoder, uniprop_encoder_count): New variables.
2908 (uniprop_get_encoder, uniprop_table)
2909 (Funicode_property_table_internal, Fget_unicode_property_internal)
2910 (Fput_unicode_property_internal): New functions.
2911 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2912 Sunicode_property_table_internal, Sget_unicode_property_internal,
2913 and Sput_unicode_property_internal. Defvar_lisp
2914 char-code-property-alist.
2916 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
2917 Vunicode_category_table.
2919 * font.c (font_range): Adjust for the change of
2920 Vunicode_category_table.
2922 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2924 * m/iris4d.h: Remove file, move contents ...
2925 * s/irix6-5.h: ... here.
2927 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2929 Remove unportable assumption about struct layout (Bug#8884).
2930 * alloc.c (mark_buffer):
2931 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2932 (clone_per_buffer_values): Don't assume that
2933 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2934 This isn't true in general, and it's particularly not true
2935 if Emacs is configured with --with-wide-int.
2936 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2937 New macros, used in the buffer.c change.
2939 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2941 * xsettings.c: Use both GConf and GSettings if both are available.
2942 (store_config_changed_event): Add comment.
2943 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2944 (store_tool_bar_style_changed): New functions.
2945 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
2946 (struct xsettings): Move font inside HAVE_XFT.
2947 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
2948 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
2949 Move inside HAVE_XFT.
2950 (something_changed_gsettingsCB): Rename from something_changedCB.
2951 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2953 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
2954 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
2955 (something_changed_gconfCB): Rename from something_changedCB.
2956 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2957 (parse_settings): Move check for font inside HAVE_XFT.
2958 (read_settings, apply_xft_settings): Add comment.
2959 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2960 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2961 call store_font_name_changed.
2962 (xft_settings_event): Add comment.
2963 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2964 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2965 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2966 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2967 (xsettings_initialize): Call init_gsettings last.
2968 (xsettings_get_system_font, xsettings_get_system_normal_font):
2971 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2973 Random fixes. E.g., (random) never returned negative values.
2974 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2975 subseconds part to the entropy, as that's a bit more random.
2976 Prefer signed to unsigned, since the signedness doesn't matter and
2977 in general we prefer signed. When given a limit, use a
2978 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2979 latter isn't right if USE_2_TAGS_FOR_INTS.
2980 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2981 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2983 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2985 * textprop.c (text_property_stickiness):
2986 Obey Vtext_property_default_nonsticky.
2987 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2988 * w32fns.c (syms_of_w32fns):
2989 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2991 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2993 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2994 This is more efficient than Ffile_directory_p and avoids a minor race.
2996 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2998 * buffer.c (Foverlay_put): Say what the return value is
3001 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3002 is a directory before asking whether to use the file name
3004 (barf_or_query_if_file_exists): Make the "File is a directory"
3005 error be more correct.
3007 * fns.c (Frequire): Remove the mention of the .gz files, since
3008 that's installation-specific, but keep the mention of
3009 `get-load-suffixes'.
3011 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3013 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3014 Report string overflow if the output is too long.
3016 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
3018 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3019 (syms_of_gnutls): Remove duplicate DEFSYM for
3020 Qgnutls_bootprop_verify_hostname_error, an error for
3021 Qgnutls_bootprop_verify_error (which is no longer used).
3023 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3024 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3025 Also (re)move comments that are misplaced or no longer relevant.
3027 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3029 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3031 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
3033 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3034 and background color parameters if they have been changed.
3036 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3038 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3040 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3042 * xsettings.c (SYSTEM_FONT): Define only when used.
3043 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3045 * keymap.c (access_keymap_1): Now static.
3047 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
3049 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3050 leave any prefix arg for the up event (Bug#1586).
3052 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3054 * lread.c (syms_of_lread): Mention single symbols defined by
3055 `defvar' or `defconst' (bug#7154).
3057 * fns.c (Frequire): Mention .el.gz files (bug#7314).
3058 (Frequire): Mention get-load-suffixes.
3060 2011-07-02 Martin Rudalics <rudalics@gmx.at>
3062 * window.h (window): Remove clone_number slot.
3063 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3065 (make_parent_window, make_window, saved_window)
3066 (Fset_window_configuration, save_window_save): Don't deal with
3068 * buffer.c (Qclone_number): Remove declaration.
3069 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3071 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3073 Add multiple inheritance to keymaps.
3074 * keymap.c (Fmake_composed_keymap): New function.
3075 (Fset_keymap_parent): Simplify.
3076 (fix_submap_inheritance): Remove.
3077 (access_keymap_1): New function extracted from access_keymap to handle
3078 embedded parents and handle lists of maps.
3079 (access_keymap): Use it.
3080 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3081 (Fcopy_keymap): Handle embedded parents.
3082 (Fcommand_remapping, define_as_prefix): Simplify.
3083 (Fkey_binding): Simplify.
3084 (syms_of_keymap): Move minibuffer-local-completion-map,
3085 minibuffer-local-filename-completion-map,
3086 minibuffer-local-must-match-map, and
3087 minibuffer-local-filename-must-match-map to Elisp.
3088 (syms_of_keymap): Defsubr make-composed-keymap.
3089 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3090 (parse_menu_item): Trivial simplification.
3092 2011-07-01 Glenn Morris <rgm@gnu.org>
3094 * Makefile.in (SETTINGS_LIBS): Fix typo.
3096 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3098 * coding.c (Fencode_coding_string): Record the last coding system
3099 used, as the function doc string says (bug#8738).
3101 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3103 * xsettings.c (store_monospaced_changed): Take new font as arg and
3104 check for change against current_mono_font.
3105 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3106 (emacs_settings_constructor, emacs_settings_get_property)
3107 (emacs_settings_set_property, emacs_settings_class_init)
3108 (emacs_settings_init, gsettings_obj): Remove.
3109 (something_changedCB): New function for HAVE_GSETTINGS.
3110 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3111 with value as argument.
3112 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3113 g_settings_new (Bug#8967). Do not create gsettings_obj.
3114 Remove calls to g_settings_bind. Connect something_changedCB to
3117 * xgselect.c: Add defined (HAVE_GSETTINGS).
3118 (xgselect_initialize): Ditto.
3120 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3121 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3124 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3126 * eval.c (struct backtrace): Simplify and port the data structure.
3127 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3128 signed bit field, as this assumption is not portable and it makes
3129 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3130 "char debug_on_exit : 1" as this is not portable either; instead,
3131 use the portable "unsigned int debug_on_exit : 1". Remove unused
3132 member evalargs. Remove obsolete comments about cc bombing out.
3134 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3136 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
3137 Let HAVE_GSETTINGS override HAVE_GCONF.
3138 (store_monospaced_changed): New function.
3139 (EMACS_SETTINGS): A new type derived from GObject to handle
3140 GSettings notifications.
3141 (emacs_settings_constructor, emacs_settings_get_property)
3142 (emacs_settings_set_property, emacs_settings_class_init):
3144 (gsettings_client, gsettings_obj): New variables.
3145 (GSETTINGS_SCHEMA): New define.
3146 (something_changedCB): Call store_monospaced_changed.
3147 (init_gsettings): New function.
3148 (xsettings_initialize): Call init_gsettings.
3149 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3152 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
3155 2011-06-29 Martin Rudalics <rudalics@gmx.at>
3157 * window.c (resize_root_window, grow_mini_window)
3158 (shrink_mini_window): Rename Qresize_root_window to
3159 Qwindow_resize_root_window and Qresize_root_window_vertically to
3160 Qwindow_resize_root_window_vertically.
3162 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3164 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3166 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
3168 * makefile.w32-in: Redesign dependencies so they reflect more
3169 clearly which files are directly included by each source file,
3170 and not through other includes.
3172 2011-06-27 Martin Rudalics <rudalics@gmx.at>
3174 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3175 (sort_overlays, overlay_strings): When an overlay's clone number
3176 matches the window's clone number process the overlay even if
3177 the overlay's window property doesn't match the current window.
3179 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3180 (Fwindow_hchild): Rename to Fwindow_left_child.
3181 (Fwindow_next): Rename to Fwindow_next_sibling.
3182 (Fwindow_prev): Rename to Fwindow_prev_sibling.
3183 (resize_window_check): Rename to window_resize_check.
3184 (resize_window_apply): Rename to window_resize_apply.
3185 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3186 (Fdelete_other_windows_internal, resize_frame_windows)
3187 (Fsplit_window_internal, Fdelete_window_internal)
3188 (grow_mini_window, shrink_mini_window)
3189 (Fresize_mini_window_internal): Fix callers accordingly.
3191 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3193 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3194 (emacs_fixed_set_min_size): Remove.
3195 (emacs_fixed_new): Take frame as argument.
3197 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3198 (_EmacsFixedPrivate): Remove minwidth/height.
3199 Add struct frame *f.
3200 (emacs_fixed_init): Initialize priv->f.
3201 (get_parent_class, emacs_fixed_set_min_size): Remove.
3202 (emacs_fixed_new): Set priv->f to argument.
3203 (emacs_fixed_get_preferred_width)
3204 (emacs_fixed_get_preferred_height): Use min_width/height from
3205 frames size_hint to set minimum and natural (Bug#8919).
3206 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3207 and use min_width/height from frames size_hint to set
3208 min_width/height (Bug#8919).
3210 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
3211 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3214 2011-06-26 Eli Zaretskii <eliz@gnu.org>
3216 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3217 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3220 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
3222 * process.c (wait_reading_process_output): Bypass select if
3223 waiting for a cell while ignoring keyboard input, and input is
3224 pending. Suggested by Jan Djärv (Bug#8869).
3226 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3228 Use gnulib's dup2 module instead of rolling our own.
3229 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3231 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3233 * dispnew.c (scrolling_window): Before scrolling, turn off a
3234 mouse-highlight in the window being scrolled.
3236 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
3238 Move DEFSYM to lisp.h and use everywhere.
3240 * character.h (DEFSYM): Move declaration...
3241 * lisp.h (DEFSYM): ...here.
3247 * w32select.c: Don't include character.h.
3249 * alloc.c (syms_of_alloc):
3250 * buffer.c (syms_of_buffer):
3251 * bytecode.c (syms_of_bytecode):
3252 * callint.c (syms_of_callint):
3253 * casefiddle.c (syms_of_casefiddle):
3254 * casetab.c (init_casetab_once):
3255 * category.c (init_category_once, syms_of_category):
3256 * ccl.c (syms_of_ccl):
3257 * cmds.c (syms_of_cmds):
3258 * composite.c (syms_of_composite):
3259 * dbusbind.c (syms_of_dbusbind):
3260 * dired.c (syms_of_dired):
3261 * dispnew.c (syms_of_display):
3262 * doc.c (syms_of_doc):
3263 * editfns.c (syms_of_editfns):
3264 * emacs.c (syms_of_emacs):
3265 * eval.c (syms_of_eval):
3266 * fileio.c (syms_of_fileio):
3267 * fns.c (syms_of_fns):
3268 * frame.c (syms_of_frame):
3269 * fringe.c (syms_of_fringe):
3270 * insdel.c (syms_of_insdel):
3271 * keymap.c (syms_of_keymap):
3272 * lread.c (init_obarray, syms_of_lread):
3273 * macros.c (syms_of_macros):
3274 * msdos.c (syms_of_msdos):
3275 * print.c (syms_of_print):
3276 * process.c (syms_of_process):
3277 * search.c (syms_of_search):
3278 * sound.c (syms_of_sound):
3279 * syntax.c (init_syntax_once, syms_of_syntax):
3280 * terminal.c (syms_of_terminal):
3281 * textprop.c (syms_of_textprop):
3282 * undo.c (syms_of_undo):
3283 * w32.c (globals_of_w32):
3284 * window.c (syms_of_window):
3285 * xdisp.c (syms_of_xdisp):
3286 * xfaces.c (syms_of_xfaces):
3287 * xfns.c (syms_of_xfns):
3288 * xmenu.c (syms_of_xmenu):
3289 * xsettings.c (syms_of_xsettings):
3290 * xterm.c (syms_of_xterm): Use DEFSYM.
3292 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3294 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
3296 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3298 Integer and buffer overflow fixes (Bug#8873).
3300 * print.c (printchar, strout): Check for string overflow.
3301 (PRINTPREPARE, printchar, strout):
3302 Don't set size unless allocation succeeds.
3304 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3305 for sizes. Check for string overflow more accurately.
3306 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3308 * macros.c: Integer and buffer overflow fixes.
3309 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3310 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3311 Use ptrdiff_t, not int, for sizes.
3312 Don't increment bufsize until after realloc succeeds.
3313 Check for size-calculation overflow.
3314 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3316 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3318 * lread.c: Integer overflow fixes.
3319 (read_integer): Radix is now EMACS_INT, not int,
3320 to improve quality of diagnostics for out-of-range radices.
3321 Calculate buffer size correctly for out-of-range radices.
3322 (read1): Check for integer overflow in radices, and in
3323 read-circle numbers.
3324 (read_escape): Avoid int overflow.
3325 (Fload, openp, read_buffer_size, read1)
3326 (substitute_object_recurse, read_vector, read_list, map_obarray):
3327 Use ptrdiff_t, not int, for sizes.
3328 (read1): Use EMACS_INT, not int, for sizes.
3329 Check for size overflow.
3331 * image.c (cache_image): Check for size arithmetic overflow.
3333 * lread.c: Integer overflow issues.
3334 (saved_doc_string_size, saved_doc_string_length)
3335 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3336 Now ptrdiff_t, not int.
3337 (read1): Don't assume doc string length fits in int. Check for
3338 out-of-range doc string lengths.
3339 (read_list): Don't assume file position fits in int.
3340 (read_escape): Check for hex character overflow.
3342 2011-06-22 Leo Liu <sdl.web@gmail.com>
3344 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3345 Move to minibuffer.el.
3347 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3349 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
3350 The following patches are for when GLYPH_DEBUG && !XASSERT.
3351 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3352 * dispnew.c (flush_stdout):
3353 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3354 Mark as externally visible.
3355 * dispnew.c (check_window_matrix_pointers): Now static.
3356 * dispnew.c (window_to_frame_vpos):
3357 * xfns.c (unwind_create_frame):
3358 * xterm.c (x_check_font): Remove unused local.
3359 * scroll.c (CHECK_BOUNDS):
3360 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3361 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3362 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3363 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3364 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3366 (debug_method_add): Use va_list and vsprintf rather than relying
3367 on undefined behavior with wrong number of arguments.
3368 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3369 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3370 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3371 since we're not interested in debugging glyphs with old libraries.
3372 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3373 GCC 4.6.0's static checking.
3375 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3377 Integer overflow and signedness fixes (Bug#8873).
3378 A few related buffer overrun fixes, too.
3380 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3382 * dispextern.h (struct face.stipple):
3383 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3384 (x_bitmap_mask, x_allocate_bitmap_record)
3385 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3386 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3387 (x_create_bitmap_from_xpm_data):
3388 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3389 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3391 * xfaces.c (load_pixmap):
3392 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3393 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3394 (.bitmaps_last, struct x_output.icon_bitmap):
3395 Use ptrdiff_t, not int, for bitmap indexes.
3396 (x_allocate_bitmap_record): Check for size overflow.
3397 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3399 Use ptrdiff_t, not int, for overlay counts.
3400 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3401 * editfns.c (overlays_around, get_pos_property):
3402 * textprop.c (get_char_property_and_overlay):
3403 * xdisp.c (next_overlay_change, note_mouse_highlight):
3404 * xfaces.c (face_at_buffer_position):
3405 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3406 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3407 (Fnext_overlay_change, Fprevious_overlay_change)
3408 (mouse_face_overlay_overlaps, Foverlays_in):
3409 Use ptrdiff_t, not int, for sizes.
3410 (overlays_at, overlays_in): Check for size-calculation overflow.
3412 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3414 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3415 (x_session_initialize): Do not assume string length fits in int.
3417 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3418 This is unlikely, but can occur if DPI is outlandish.
3420 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3421 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3423 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3424 * xrdb.c (magic_file_p, search_magic_path):
3425 Omit last arg SUFFIX; it was always 0. All callers changed.
3426 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3428 * xfont.c (xfont_match): Avoid need for strlen.
3430 * xfns.c: Don't assume strlen fits in int.
3431 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3433 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3434 not unsigned long, as we prefer signed integers. All callers changed.
3435 Detect integer overflow in repeat count.
3436 (message_dolog): Don't assume print length fits in 39 bytes.
3437 (display_mode_element): Don't assume strlen fits in int.
3439 * termcap.c: Don't assume sizes fit in int and never overflow.
3440 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3441 (gobble_line): Check for size-calculation overflow.
3443 * minibuf.c (Fread_buffer):
3444 * lread.c (intern, intern_c_string):
3445 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3446 Don't assume string length fits in int.
3448 * keyboard.c (parse_tool_bar_item):
3449 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3451 * font.c: Don't assume string length fits in int.
3452 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3453 Use ptrdiff_t, not int.
3454 (font_intern_prop): Don't assume string length fits in int.
3455 Don't assume integer property fits in fixnum.
3456 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
3458 * filelock.c: Fix some buffer overrun and integer overflow issues.
3459 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
3460 Reformulate so as not to need the command string.
3461 Invoke gzip -cd rather than gunzip, as it's more portable.
3462 (lock_info_type, lock_file_1, lock_file):
3463 Don't assume pid_t and time_t fit in unsigned long.
3464 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3465 (current_lock_owner): Prefer signed type for sizes.
3466 Use memcpy, not strncpy, where memcpy is what is really wanted.
3467 Don't assume (via atoi) that time_t and pid_t fit in int.
3468 Check for time_t and/or pid_t out of range, e.g., via a network share.
3469 Don't alloca where an auto var works fine.
3471 * fileio.c: Fix some integer overflow issues.
3472 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3473 Don't assume string length fits in int.
3474 (directory_file_name): Don't assume string length fits in long.
3475 (make_temp_name): Don't assume pid fits in int, or that its print
3476 length is less than 20.
3478 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3480 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3482 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3484 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3485 We prefer signed integers, even for size calculations.
3487 * emacs.c: Don't assume string length fits in 'int'.
3488 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3489 (main): Don't invoke strlen when not needed.
3491 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3492 (XD_DEBUG_MESSAGE): Don't waste a byte.
3494 * callproc.c (getenv_internal_1, getenv_internal)
3496 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3498 * lread.c (invalid_syntax): Omit length argument.
3499 All uses changed. This doesn't fix a bug, but it simplifies the
3500 code away from its former Hollerith-constant appearance, and it's
3501 one less 'int' to worry about when looking at integer-overflow issues.
3502 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
3504 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3505 This didn't break anything, but it didn't help either.
3506 It's confusing to put a bogus integer in a place where the actual
3507 value does not matter.
3508 (LIST_END_P): Remove unused macro and its bogus comment.
3509 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
3511 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3512 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3514 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3515 We prefer signed types, and the value cannot exceed the EMACS_INT
3516 range anyway (because otherwise the length would not be representable).
3517 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3518 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3519 This avoids a GCC warning when WIDE_EMACS_INT.
3521 * indent.c (sane_tab_width): New function.
3522 (current_column, scan_for_column, Findent_to, position_indentation)
3523 (compute_motion): Use it. This is just for clarity.
3524 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
3526 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
3528 * lisp.h (lint_assume): New macro.
3529 * composite.c (composition_gstring_put_cache):
3530 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3532 * editfns.c, insdel.c:
3533 Omit unnecessary forward decls, to simplify future changes.
3535 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3537 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3539 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
3540 Use much-faster test for byte-length change.
3541 Don't assume string byte-length fits in 'int'.
3542 Check that character arg fits in 'int'.
3543 (mapcar1): Declare byte as byte, for clarity.
3545 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3547 * fns.c (concat): Catch string overflow earlier.
3548 Do not rely on integer wraparound.
3550 * dispextern.h (struct it.overlay_strings_charpos)
3551 (struct it.selective): Now EMACS_INT, not int.
3552 * xdisp.c (forward_to_next_line_start)
3553 (back_to_previous_visible_line_start)
3554 (reseat_at_next_visible_line_start, next_element_from_buffer):
3555 Don't arbitrarily truncate the value of 'selective' to int.
3557 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3559 * composite.c: Don't truncate sizes to 'int'.
3560 (composition_gstring_p, composition_reseat_it)
3561 (composition_adjust_point): Use EMACS_INT, not int.
3562 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3563 not EMACS_UINT, for indexes.
3565 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3567 * buffer.c: Include <verify.h>.
3568 (struct sortvec.priority, struct sortstr.priority):
3569 Now EMACS_INT, not int.
3570 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
3571 (struct sortstr.size, record_overlay_string)
3572 (struct sortstrlist.size, struct sortlist.used):
3573 Don't truncate size to int.
3574 (record_overlay_string): Check for size-calculation overflow.
3575 (init_buffer_once): Check at compile-time, not run-time.
3577 2011-06-22 Jim Meyering <meyering@redhat.com>
3579 Don't leak an XBM-image-sized buffer
3580 * image.c (xbm_load): Free the image buffer after using it.
3582 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3585 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3586 that Sun C diagnosed.
3587 * fns.c (secure_hash): Fix pointer signedness issue.
3588 * intervals.c (static_offset_intervals): New function.
3589 (offset_intervals): Use it.
3591 2011-06-21 Leo Liu <sdl.web@gmail.com>
3594 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3597 * fns.c (secure_hash): Rename from crypto_hash_function and change
3598 the first arg to accept symbols.
3599 (Fsecure_hash): New primitive.
3600 (syms_of_fns): New symbols.
3602 2011-06-20 Deniz Dogan <deniz@dogan.se>
3604 * process.c (Fset_process_buffer): Clarify return value in
3607 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
3609 * dispnew.c (add_window_display_history): Use BVAR.
3611 * xdisp.c (debug_method_add): Use BVAR.
3612 (check_window_end, dump_glyph_matrix, dump_glyph)
3613 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3615 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3618 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3619 check till after the cache is created in init_frame_faces.
3621 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3623 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3625 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3627 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3628 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3629 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3631 Improve buffer-overflow checking (Bug#8873).
3632 * fileio.c (Finsert_file_contents):
3633 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3634 Remove the old (too-loose) buffer overflow checks.
3635 They weren't needed, since make_gap checks for buffer overflow.
3636 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3637 The old code merely checked for Emacs fixnum overflow, and relied
3638 on undefined (wraparound) behavior. The new code avoids undefined
3639 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3641 * editfns.c (Finsert_char): Don't dump core with very negative counts.
3642 Tune. Don't use wider integers than needed. Don't use alloca.
3643 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
3645 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3647 * insdel.c, lisp.h (buffer_overflow): New function.
3648 (insert_from_buffer_1, replace_range, replace_range_2):
3649 * insdel.c (make_gap_larger):
3650 * editfns.c (Finsert_char):
3651 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3653 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3655 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3657 Integer overflow and signedness fixes (Bug#8873).
3659 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3660 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3662 * fileio.c: Don't assume EMACS_INT fits in off_t.
3663 (emacs_lseek): New static function.
3664 (Finsert_file_contents, Fwrite_region): Use it.
3665 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3667 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3669 * fns.c: Don't overflow int when computing a list length.
3670 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3671 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3672 truncation on 64-bit hosts. Check for QUIT every
3673 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3674 faster and is responsive enough.
3675 (Flength): Report an error instead of overflowing an integer.
3676 (Fsafe_length): Return a float if the value is not representable
3677 as a fixnum. This shouldn't happen except in contrived situations.
3678 (Fnthcdr, Fsort): Don't assume list length fits in int.
3679 (Fcopy_sequence): Don't assume vector length fits in int.
3681 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3682 (header_size, word_size): New constants.
3683 (allocate_vectorlike): Don't check size overflow here.
3684 (allocate_vector): Check it here instead, since this is the only
3685 caller of allocate_vectorlike that could cause overflow.
3686 Check that the new vector's length is representable as a fixnum.
3688 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3689 The previous code was bogus. For example, next_almost_prime (32)
3690 returned 39, which is undesirable as it is a multiple of 3; and
3691 next_almost_prime (24) returned 25, which is a multiple of 5 so
3692 why was the code bothering to check for multiples of 7?
3694 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3696 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3698 Variadic C functions now count arguments with ptrdiff_t.
3699 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3700 Back then I didn't know that the Emacs coding style prefers signed int.
3701 Also, in the meantime I found a few more instances where arguments
3702 were being counted with int, which may truncate counts on 64-bit
3703 machines, or EMACS_INT, which may be unnecessarily wide.
3704 * lisp.h (struct Lisp_Subr.function.aMANY)
3705 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3706 Arg counts are now ptrdiff_t, not size_t.
3707 All variadic functions and their callers changed accordingly.
3708 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3709 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3710 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3711 * callint.c (Fcall_interactively): Check arg count for overflow,
3712 to avoid potential buffer overrun. Use signed char, not 'int',
3713 for 'varies' array, so that we needn't bother to check its size
3714 calculation for overflow.
3715 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3716 * eval.c (apply_lambda):
3717 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3718 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3719 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3721 * callint.c (Fcall_interactively): Don't use index var as event count.
3723 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3724 * mem-limits.h (SIZE): Remove; no longer used.
3726 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
3728 Remove unnecessary casts.
3729 * xterm.c (x_term_init):
3730 * xfns.c (x_set_border_pixel):
3731 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3732 These aren't needed now that we assume ANSI C.
3734 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3735 It's more likely to cause problems (due to unsigned overflow)
3738 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3740 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3742 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3744 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3746 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3748 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3750 GLYPH_CODE_FACE returns EMACS_INT, not int.
3751 * dispextern.h (merge_faces):
3752 * xfaces.c (merge_faces):
3753 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3754 Don't assume EMACS_INT fits in int.
3756 * character.h (CHAR_VALID_P): Remove unused parameter.
3757 * fontset.c, lisp.h, xdisp.c: All uses changed.
3759 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3761 * fns.c (concat): Minor tuning based on overflow analysis.
3762 This doesn't fix any bugs. Use int to hold character, instead
3763 of constantly refetching from Emacs object. Use XFASTINT, not
3764 XINT, for value known to be a character. Don't bother comparing
3765 a single byte to 0400, as it's always less.
3767 * floatfns.c (Fexpt):
3768 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3770 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3773 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3775 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3776 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3777 incorrectly succeed when S was a string, because 4294967386 was
3778 truncated before it was used.
3780 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3781 Otherwise, an out-of-range integer could cause undefined behavior
3784 * composite.c: Use int, not EMACS_INT, for characters.
3785 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3786 EMACS_INT, for values that are known to be in character range.
3787 This doesn't fix any bugs but is the usual style inside Emacs and
3788 may generate better code on 32-bit machines.
3790 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3791 This is for reasons similar to the recent CHAR_STRING fix.
3792 * charset.c (Fencode_char): Check that character arg is actually
3793 a character. Pass an int to ENCODE_CHAR.
3794 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3795 wider than 'int', as a compile-time check to prevent future regressions
3798 * character.c (char_string): Remove unnecessary casts.
3800 Make sure a 64-bit char is never passed to CHAR_STRING.
3801 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3802 by silently ignoring the top 32 bits, allowing some values
3803 that were far too large to be valid characters.
3804 * character.h: Include <verify.h>.
3805 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3806 arguments are no wider than unsigned, as a compile-time check
3807 to prevent future regressions in this area.
3809 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
3810 (Fsubst_char_in_region):
3812 * xdisp.c (decode_mode_spec_coding):
3813 Adjust to CHAR_STRING's new requirement.
3814 * editfns.c (Finsert_char, Fsubst_char_in_region):
3815 * fns.c (concat): Check that character args are actually
3816 characters. Without this test, these functions did the wrong
3817 thing with wildly out-of-range values on 64-bit hosts.
3819 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3820 These casts should not be needed on 32-bit hosts, either.
3821 * keyboard.c (read_char):
3822 * lread.c (Fload): Remove casts to unsigned.
3824 * lisp.h (UNSIGNED_CMP): New macro.
3825 This fixes comparison bugs on 64-bit hosts.
3826 (ASCII_CHAR_P): Use it.
3827 * casefiddle.c (casify_object):
3828 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
3829 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3830 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3831 * dispextern.h (FACE_FROM_ID):
3832 * keyboard.c (read_char): Use UNSIGNED_CMP.
3834 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3835 not to EMACS_INT, to avoid GCC warning.
3837 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3839 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3840 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3841 isn't needed on 32-bit machines.
3843 * buffer.c (Fgenerate_new_buffer_name):
3844 Use EMACS_INT for count, not int.
3845 (advance_to_char_boundary): Return EMACS_INT, not int.
3847 * data.c (Qcompiled_function): Now static.
3849 * window.c (window_body_lines): Now static.
3851 * image.c (gif_load): Rename local to avoid shadowing.
3853 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3854 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3855 * alloc.c (make_save_value): Integer argument is now of type
3857 (mark_object): Use ptrdiff_t, not int.
3858 * lisp.h (pD): New macro.
3859 * print.c (print_object): Use it.
3861 * alloc.c: Use EMACS_INT, not int, to count objects.
3862 (total_conses, total_markers, total_symbols, total_vector_size)
3863 (total_free_conses, total_free_markers, total_free_symbols)
3864 (total_free_floats, total_floats, total_free_intervals)
3865 (total_intervals, total_strings, total_free_strings):
3866 Now EMACS_INT, not int. All uses changed.
3867 (Fgarbage_collect): Compute overall total using a double, so that
3868 integer overflow is less likely to be a problem. Check for overflow
3869 when converting back to an integer.
3870 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3871 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3872 These were 'int' variables that could overflow on 64-bit hosts;
3873 they were never used, so remove them instead of repairing them.
3874 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
3875 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3876 Previously, this ceilinged at INT_MAX, but that doesn't work on
3878 (allocate_pseudovector): Don't use EMACS_INT when int would do.
3880 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
3881 (allocate_vectorlike): Check for ptrdiff_t overflow.
3882 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3883 when a (possibly-narrower) signed value would do just as well.
3884 We prefer using signed arithmetic, to avoid comparison confusion.
3886 * alloc.c: Catch some string size overflows that we were missing.
3887 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3888 for convenience in STRING_BYTES_MAX.
3889 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3890 The definition here is exact; the one in lisp.h was approximate.
3891 (allocate_string_data): Check for string overflow. This catches
3892 some instances we weren't catching before. Also, it catches
3893 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3894 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3895 and ptrdiff_t and EMACS_INT are both 64 bits.
3897 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3898 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
3899 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
3901 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3903 * alloc.c (Fmake_string): Check for out-of-range init.
3905 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3907 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3909 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3911 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3912 xg_get_default_scrollbar_width.
3914 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3915 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3916 (style_changed_cb): Call update_theme_scrollbar_width and call
3917 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3918 all frames (Bug#8505).
3919 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3920 Call gtk_window_set_resizable if HAVE_GTK3.
3921 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3922 and height if HAVE_GTK3 (Bug#8505).
3923 (scroll_bar_width_for_theme): New variable.
3924 (update_theme_scrollbar_width): New function.
3925 (xg_get_default_scrollbar_width): Move code to
3926 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3927 (xg_initialize): Call update_theme_scrollbar_width.
3929 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3931 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3933 2011-06-12 Martin Rudalics <rudalics@gmx.at>
3935 * frame.c (make_frame): Call other_buffer_safely instead of
3938 * window.c (temp_output_buffer_show): Call display_buffer with
3939 second argument Vtemp_buffer_show_specifiers and reset latter
3940 immediately after the call.
3941 (Vtemp_buffer_show_specifiers): New variable.
3942 (auto_window_vscroll_p, next_screen_context_lines)
3943 (Vscroll_preserve_screen_position): Remove leading asterisks from
3946 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
3948 Fix minor problems found by GCC 4.6.0 static checking.
3949 * buffer.c (Qclone_number): Remove for now, as it's unused.
3950 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3951 (record_buffer): Remove unused local.
3952 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3953 (set_frame_buffer_list): Remove; unused.
3954 * frame.h (other_visible_frames): Remove decl.
3955 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3956 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3957 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3959 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3960 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3961 Define only if HAVE_GPM.
3962 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3963 (update_hints_inhibit): Remove; never set. All uses removed.
3964 * widgetprv.h (emacsFrameClassRec): Remove decl.
3965 * window.c (delete_deletable_window): Now returns void, since it
3966 wasn't returning anything.
3967 (compare_window_configurations): Remove unused locals.
3968 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3969 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
3970 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3971 the same widths as pointers. This follows up on the 2011-05-06 patch.
3972 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3973 * xterm.h: Likewise.
3974 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3976 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
3978 * makefile.w32-in: Update dependencies.
3979 (LISP_H): Add lib/intprops.h.
3981 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3983 * image.c (gif_load): Add animation frame delay to the metadata.
3984 (syms_of_image): Use DEFSYM. New symbol `delay'.
3986 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3988 * window.c (delete_deletable_window): Re-add.
3989 (Fset_window_configuration): Rewrite to handle dead buffers and
3990 consequently deletable windows.
3991 (window_tree, Fwindow_tree): Remove. Supply functionality in
3993 (compare_window_configurations): Simplify code.
3995 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3997 * image.c (imagemagick_load_image): Fix type mismatch.
3998 (Fimagemagick_types): Likewise.
4000 * window.h (replace_buffer_in_windows): Declare.
4002 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4004 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4005 Qclone_number. Remove external declaration of Qdelete_window.
4006 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4008 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4009 Run Qbuffer_list_update_hook if allowed.
4010 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4011 buffer list implementation.
4012 (other_buffer_safely): New function.
4013 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4014 calls to replace_buffer_in_windows and
4015 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4017 (record_buffer): Inhibit quitting and rewrite using quittable
4018 functions. Run Qbuffer_list_update_hook if allowed.
4019 (Frecord_buffer, Funrecord_buffer): New functions.
4020 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4021 Move switch-to-buffer to window.el.
4022 (bury-buffer): Move to window.el.
4023 (Vbuffer_list_update_hook): New variable.
4025 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4028 * window.h (resize_frame_windows): Move up in code.
4029 (Fwindow_frame): Remove EXFUN.
4030 (replace_buffer_in_all_windows): Remove prototype.
4031 (replace_buffer_in_windows_safely): Add prototype.
4033 * window.c: Declare Qdelete_window static again. Move down
4034 declaration of select_count.
4035 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4036 (Fother_window): Move to window.el.
4037 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4038 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4039 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4041 (replace_buffer_in_windows): Implement by calling
4042 Qreplace_buffer_in_windows.
4043 (replace_buffer_in_all_windows): Remove with some functionality
4044 moved into replace_buffer_in_windows_safely.
4045 (replace_buffer_in_windows_safely): New function.
4046 (select_window_norecord, select_frame_norecord): Move in front
4047 of run_window_configuration_change_hook. Remove now obsolete
4049 (Fset_window_buffer): Rewrite doc-string.
4050 Call Qrecord_window_buffer.
4051 (keys_of_window): Move binding for other-window to window.el.
4053 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4055 * dispextern.h (struct image): Replace data member, whose int_val
4056 and ptr_val fields were not used by anything, with a single
4059 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4060 (gif_clear_image, gif_load, imagemagick_load_image)
4061 (gs_clear_image, gs_load): Callers changed.
4063 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4065 * buffer.h: Include <time.h>, for time_t.
4066 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4068 Fix minor problems found by static checking.
4070 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4072 Make identifiers static if they are not used in other modules.
4073 * data.c (Qcompiled_function, Qframe, Qvector):
4074 * image.c (QimageMagick, Qsvg):
4075 * minibuf.c (Qmetadata):
4076 * window.c (resize_window_check, resize_root_window): Now static.
4077 * window.h (resize_window_check, resize_root_window): Remove decls.
4079 * window.c (window_deletion_count, delete_deletable_window):
4081 (window_body_lines): Now static.
4082 (Fdelete_other_windows_internal): Mark vars as initialized.
4083 Make sure 'resize_failed' is initialized.
4084 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4085 (resize_window_apply): Remove unused local.
4086 * window.h (delete_deletable_window): Remove decl.
4088 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
4089 (imagemagick_load_image): Fix pointer signedness problem by changing
4090 last arg from unsigned char * to char *. All uses changed.
4091 Also, fix a local for similar reasons.
4092 Remove unused locals. Remove locals to avoid shadowing.
4093 (fn_rsvg_handle_free): Remove; unused.
4094 (svg_load, svg_load_image): Fix pointer signedness problem.
4095 (imagemagick_load_image): Don't use garbage pointer image_wand.
4097 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4099 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
4101 * image.c (gif_load): Fix omitted cast error introduced by
4104 2011-06-10 Martin Rudalics <rudalics@gmx.at>
4106 * window.h (resize_proportionally, orig_total_lines)
4107 (orig_top_line): Remove from window structure.
4108 (set_window_height, set_window_width, change_window_heights)
4109 (Fdelete_window): Remove prototypes.
4110 (resize_frame_windows): Remove duplicate declaration.
4112 2011-06-10 Eli Zaretskii <eliz@gnu.org>
4114 * window.h (resize_frame_windows, resize_window_check)
4115 (delete_deletable_window, resize_root_window)
4116 (resize_frame_windows): Declare prototypes.
4118 * window.c (resize_window_apply): Make definition be "static" to
4119 match the prototype.
4121 2011-06-10 Martin Rudalics <rudalics@gmx.at>
4123 * window.c: Remove declarations of Qwindow_size_fixed,
4124 window_min_size_1, window_min_size_2, window_min_size,
4125 size_window, window_fixed_size_p, enlarge_window, delete_window.
4126 Remove static from declaration of Qdelete_window, it's
4127 temporarily needed by Fbury_buffer.
4128 (replace_window): Don't assign orig_top_line and
4130 (Fdelete_window, delete_window): Remove. Window deletion is
4131 handled by window.el.
4132 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4133 Replace Fdelete_window calls with calls to Qdelete_window.
4134 (Fdelete_other_windows): Remove. Deleting other windows is
4135 handled by window.el.
4136 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4137 handled in window.el.
4138 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4139 Window minimum sizes are handled in window.el.
4140 (shrink_windows, size_window, set_window_height)
4141 (set_window_width, change_window_heights, window_height)
4142 (window_width, CURBEG, CURSIZE, enlarge_window)
4143 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4144 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4145 handled in window.el.
4146 (make_dummy_parent): Rename to make_parent_window and give it a
4147 second argument horflag.
4148 (make_window): Don't set resize_proportionally any more.
4149 (Fsplit_window): Remove. Windows are split in window.el.
4150 (save_restore_action, save_restore_orig_size)
4151 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4152 Resize mini windows in window.el.
4153 (grow_mini_window, shrink_mini_window): Implement by calling
4154 Qresize_root_window_vertically, resize_window_check and
4155 resize_window_apply.
4156 (saved_window, Fset_window_configuration, save_window_save):
4157 Do not handle orig_top_line, orig_total_lines, and
4158 resize_proportionally.
4159 (window_min_height, window_min_width): Move to window.el.
4160 (keys_of_window): Move bindings for delete-other-windows,
4161 split-window, delete-window and enlarge-window to window.el.
4163 * buffer.c: Temporarily extern Qdelete_window.
4164 (Fbury_buffer): Temporarily call Qdelete_window instead of
4165 Fdelete_window (Fbury_buffer will move to window.el soon).
4167 * frame.c (set_menu_bar_lines_1): Remove code handling
4168 orig_top_line and orig_total_lines.
4170 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4171 set_window_height but set heights directly.
4172 (change_frame_size_1): Use resize_frame_windows.
4174 * xdisp.c (init_xdisp): Don't use set_window_height but set
4177 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4178 Use resize_frame_windows instead of change_window_heights and run
4179 run_window_configuration_change_hook.
4181 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4182 instead of change_window_heights and run
4183 run_window_configuration_change_hook.
4185 2011-06-09 Martin Rudalics <rudalics@gmx.at>
4187 * window.c (replace_window): Rename second argument REPLACEMENT to
4188 NEW. New third argument SETFLAG. Rewrite.
4189 (delete_window, make_dummy_parent): Call replace_window with
4191 (window_list_1): Move down in code.
4192 (run_window_configuration_change_hook): Move set_buffer part
4193 before select_frame_norecord part in order to unwind correctly.
4194 Rename count1 to count.
4195 (recombine_windows, delete_deletable_window, resize_root_window)
4196 (Fdelete_other_windows_internal)
4197 (Frun_window_configuration_change_hook, make_parent_window)
4198 (resize_window_check, resize_window_apply, Fresize_window_apply)
4199 (resize_frame_windows, Fsplit_window_internal)
4200 (Fdelete_window_internal, Fresize_mini_window_internal):
4202 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4204 2011-06-08 Martin Rudalics <rudalics@gmx.at>
4206 * window.h (window): Add some new members to window structure -
4207 normal_lines, normal_cols, new_total, new_normal, clone_number,
4208 splits, nest, prev_buffers, next_buffers.
4209 (WINDOW_TOTAL_SIZE): Move here from window.c.
4210 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
4212 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4214 (make_dummy_parent): Set new members of windows structure.
4215 (make_window): Move down in code. Handle new members of window
4217 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4218 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4219 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4220 (Fset_window_prev_buffers, Fwindow_next_buffers)
4221 (Fset_window_next_buffers, Fset_window_clone_number):
4223 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4224 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4226 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4227 Argument WINDOW can be now internal window too.
4228 (Fwindow_use_time): Move up in code.
4229 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4231 (Fset_window_configuration, saved_window)
4232 (Fcurrent_window_configuration, save_window_save): Handle new
4233 members of window structure.
4234 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4235 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4236 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4237 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4238 Qget_mru_window, Qresize_root_window,
4239 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4240 Qauto_buffer_name; staticpro them.
4242 2011-06-07 Martin Rudalics <rudalics@gmx.at>
4244 * window.c (Fwindow_total_size, Fwindow_left_column)
4245 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4246 (Fwindow_list_1): New functions.
4247 (window_box_text_cols): Replace with window_body_cols.
4248 (Fwindow_width, Fscroll_left, Fscroll_right):
4249 Use window_body_cols instead of window_box_text_cols.
4250 (delete_window, Fset_window_configuration):
4251 Call delete_all_subwindows with window as argument.
4252 (delete_all_subwindows): Take a window as argument and not a
4254 (window_loop): Remove handling of GET_LRU_WINDOW and
4256 (Fget_lru_window, Fget_largest_window): Move to window.el.
4258 * window.h: Extern window_body_cols instead of
4259 window_box_text_cols. delete_all_subwindows now takes a
4260 Lisp_Object as argument.
4262 * indent.c (compute_motion, Fcompute_motion):
4263 Use window_body_cols instead of window_box_text_cols.
4265 * frame.c (delete_frame): Call delete_all_subwindows with root
4268 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4270 * fns.c (Fputhash): Document return value.
4272 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
4274 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4276 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4278 Cons<->int and similar integer overflow fixes (Bug#8794).
4280 Check for overflow when converting integer to cons and back.
4281 * charset.c (Fdefine_charset_internal, Fdecode_char):
4282 Use cons_to_unsigned to catch overflow.
4283 (Fencode_char): Use INTEGER_TO_CONS.
4284 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4285 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4286 * data.c (long_to_cons, cons_to_long): Remove.
4287 (cons_to_unsigned, cons_to_signed): New functions.
4288 These signal an error for invalid or out-of-range values.
4289 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4290 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4291 * font.c (Ffont_variation_glyphs):
4292 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4293 * lisp.h: Include <intprops.h>.
4294 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4295 (cons_to_signed, cons_to_unsigned): New decls.
4296 (long_to_cons, cons_to_long): Remove decls.
4297 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4298 (Fprimitive_undo): Use CONS_TO_INTEGER.
4299 * xfns.c (Fx_window_property): Likewise.
4300 * xselect.c: Include <limits.h>.
4301 (x_own_selection, selection_data_to_lisp_data):
4302 Use INTEGER_TO_CONS.
4303 (x_handle_selection_request, x_handle_selection_clear)
4304 (x_get_foreign_selection, Fx_disown_selection_internal)
4305 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4306 (lisp_data_to_selection_data): Use cons_to_unsigned.
4307 (x_fill_property_data): Use cons_to_signed.
4308 Report values out of range.
4310 Check for buffer and string overflow more precisely.
4311 * buffer.h (BUF_BYTES_MAX): New macro.
4312 * lisp.h (STRING_BYTES_MAX): New macro.
4313 * alloc.c (Fmake_string):
4314 * character.c (string_escape_byte8):
4315 * coding.c (coding_alloc_by_realloc):
4316 * doprnt.c (doprnt):
4317 * editfns.c (Fformat):
4319 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4320 since they may not be the same number.
4321 * editfns.c (Finsert_char):
4322 * fileio.c (Finsert_file_contents):
4323 Likewise for BUF_BYTES_MAX.
4325 * image.c: Use ptrdiff_t, not int, for sizes.
4326 (slurp_file): Switch from int to ptrdiff_t.
4328 (slurp_file): Check that file size fits in both size_t (for
4329 malloc) and ptrdiff_t (for sanity and safety).
4331 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4332 if b->modtime has its maximal value.
4334 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4336 Don't assume time_t can fit into int.
4337 * buffer.h (struct buffer.modtime): Now time_t, not int.
4338 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4339 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4341 Minor fixes for signed vs unsigned integers.
4342 * character.h (MAYBE_UNIFY_CHAR):
4343 * charset.c (maybe_unify_char):
4344 * keyboard.c (read_char, reorder_modifiers):
4345 XINT -> XFASTINT, since the integer must be nonnegative.
4346 * ftfont.c (ftfont_spec_pattern):
4347 * keymap.c (access_keymap, silly_event_symbol_error):
4348 XUINT -> XFASTINT, since the integer must be nonnegative.
4349 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4350 since it makes no difference and we prefer signed.
4351 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4352 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4355 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4357 * window.h (Fwindow_frame): Declare.
4359 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4361 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4362 (SPARE_MEMORY): Always define.
4363 (LARGE_REQUEST): Remove.
4364 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4366 2011-06-06 Martin Rudalics <rudalics@gmx.at>
4368 * lisp.h: Move EXFUNS for Fframe_root_window,
4369 Fframe_first_window and Fset_frame_selected_window to window.h.
4371 * window.h: Move EXFUNS for Fframe_root_window,
4372 Fframe_first_window and Fset_frame_selected_window here from
4375 * frame.c (Fwindow_frame, Fframe_first_window)
4376 (Fframe_root_window, Fframe_selected_window)
4377 (Fset_frame_selected_window): Move to window.c.
4378 (Factive_minibuffer_window): Move to minibuf.c.
4379 (Fother_visible_frames_p): New function.
4381 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4383 * window.c (decode_window, decode_any_window): Move up in code.
4384 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4385 (inhibit_frame_unsplittable): Remove unused variable.
4386 (Fwindow_buffer): Move up and rewrite doc-string.
4387 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4388 (Fwindow_prev): New functions.
4389 (Fwindow_frame): Move here from frame.c. Accept any window as
4391 (Fframe_root_window, Fframe_first_window)
4392 (Fframe_selected_window): Move here from frame.c. Accept frame
4393 or arbitrary window as argument. Update doc-strings.
4394 (Fminibuffer_window): Move up in code.
4395 (Fwindow_minibuffer_p): Move up in code and simplify.
4396 (Fset_frame_selected_window): Move here from frame.c.
4398 (Fselected_window, select_window, Fselect_window): Move up in
4399 code. Minor doc-string fixes.
4401 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4403 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4404 Do not assume that spare memory exists; that assumption is valid
4405 only if SYSTEM_MALLOC.
4406 (LARGE_REQUEST): New macro, so that the issue of large requests
4407 is separated from the issue of spare memory.
4409 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4411 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4414 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4416 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4419 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4421 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4423 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4425 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4426 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4428 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
4430 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4432 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
4434 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4435 (x_clipboard_manager_save): Add return value.
4436 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4438 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4439 Obey Vx_select_enable_clipboard_manager. Catch errors in
4440 x_clipboard_manager_save (Bug#8779).
4441 (Vx_select_enable_clipboard_manager): New variable.
4442 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4444 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
4446 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4448 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4450 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4451 in the current matrix if keep_current_p is non-zero.
4453 2011-06-04 Eli Zaretskii <eliz@gnu.org>
4455 * bidi.c (bidi_level_of_next_char): Fix last change.
4457 2011-06-03 Eli Zaretskii <eliz@gnu.org>
4459 Support bidi reordering of text covered by display properties.
4461 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4462 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4463 (bidi_cache_search, bidi_cache_iterator_state)
4464 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
4465 (bidi_level_of_next_char, bidi_move_to_visually_next):
4466 Support character positions inside a run of characters covered by a
4468 (bidi_paragraph_init, bidi_resolve_explicit_1)
4469 (bidi_level_of_next_char): Call bidi_fetch_char and
4470 bidi_fetch_char_advance instead of FETCH_CHAR and
4472 (bidi_init_it): Initialize new members.
4473 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4475 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4476 instead of using explicit *_CHAR codes.
4477 (bidi_resolve_explicit, bidi_resolve_weak):
4478 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
4479 bidirectional text is supported only in multibyte buffers.
4480 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4481 it to initialize the frame_window_p member of struct bidi_it.
4482 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4483 (bidi_resolve_explicit, bidi_resolve_weak)
4484 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4485 bidi_it->nchars is non-positive.
4486 (bidi_level_of_next_char): Don't try to lookup the cache for the
4487 next/previous character if nothing is cached there yet, or if we
4488 were just reseat()'ed to a new position.
4490 * xdisp.c (set_cursor_from_row): Set start and stop points
4491 according to the row's direction when priming the loop that looks
4492 for the glyph on which to display cursor.
4493 (single_display_spec_intangible_p): Function deleted.
4494 (display_prop_intangible_p): Reimplement to call
4495 handle_display_spec instead of single_display_spec_intangible_p.
4496 Accept 3 additional arguments needed by handle_display_spec.
4497 This fixes incorrect cursor motion across display property with complex
4498 values: lists, `(when COND...)' forms, etc.
4499 (single_display_spec_string_p): Support property values that are
4500 lists with the argument STRING its top-level element.
4501 (display_prop_string_p): Fix the condition for processing a
4502 property that is a list to be consistent with handle_display_spec.
4503 (handle_display_spec): New function, refactored from the
4504 last portion of handle_display_prop.
4505 (compute_display_string_pos): Accept additional argument
4506 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4507 value of a `display' property is a "replacing spec".
4508 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4509 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4510 the display property, but just return a value indicating whether
4511 the display property will replace the characters it covers.
4512 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4513 frame_window_p members of struct bidi_it.
4514 (compute_display_string_pos, compute_display_string_end):
4516 (push_it): Accept second argument POSITION, where pop_it should
4517 jump to continue iteration.
4518 (reseat_1): Initialize bidi_it.disp_pos.
4520 * keyboard.c (adjust_point_for_property): Adjust the call to
4521 display_prop_intangible_p to its new signature.
4523 * dispextern.h (struct bidi_it): New member frame_window_p.
4524 (bidi_init_it): Update prototypes.
4525 (display_prop_intangible_p): Update prototype.
4526 (compute_display_string_pos, compute_display_string_end):
4528 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4531 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
4533 Malloc failure behavior now depends on size of allocation.
4534 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4535 * lisp.h: Change signatures accordingly.
4536 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4537 All callers changed. (Bug#8762)
4539 * gnutls.c: Use Emacs's memory allocators.
4540 Without this change, the gnutls library would invoke malloc etc.
4541 directly, which causes problems on non-SYNC_INPUT hosts, and which
4542 runs afoul of improving memory_full behavior. (Bug#8761)
4543 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4544 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4545 xfree instead of the default malloc, realloc, free.
4546 (Fgnutls_boot): No need to check for memory allocation failure,
4547 since xmalloc does that for us.
4549 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
4550 * category.c (hash_get_category_set):
4551 * ccl.c (ccl_driver):
4552 * charset.c (Fdefine_charset_internal):
4553 * charset.h (struct charset.hash_index):
4554 * composite.c (get_composition_id, gstring_lookup_cache)
4555 (composition_gstring_put_cache):
4556 * composite.h (struct composition.hash_index):
4557 * dispextern.h (struct image.hash):
4558 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4559 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4560 (hashfn_equal, hashfn_user_defined, make_hash_table)
4561 (maybe_resize_hash_table, hash_lookup, hash_put)
4562 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4563 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4564 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4565 * image.c (make_image, search_image_cache, lookup_image)
4566 (xpm_put_color_table_h):
4567 * lisp.h (struct Lisp_Hash_Table):
4568 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
4569 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
4570 for hashes and hash indexes, instead of 'unsigned' and 'int'.
4571 * alloc.c (allocate_vectorlike):
4572 Check for overflow in vector size calculations.
4573 * ccl.c (ccl_driver):
4574 Check for overflow when converting EMACS_INT to int.
4575 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4576 need to be updated by these changes.
4577 * fns.c (make_hash_table, maybe_resize_hash_table):
4578 Check for integer overflow with large hash tables.
4579 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4580 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4581 (SXHASH_REDUCE): New macro.
4582 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4583 Use it instead of discarding useful hash info with large hash values.
4584 (sxhash_float): New function.
4585 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4586 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
4587 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4588 Rewrite to use FIXNUM_BITS, as this simplifies things.
4589 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4590 Adjust signatures to match updated version of code.
4591 (consing_since_gc): Now EMACS_INT, since a single hash table can
4592 use more than INT_MAX bytes.
4594 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4596 Make it possible to build with GCC-4.6+ -O2 -flto.
4598 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4600 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4602 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4603 Call minibuffer-inactive-mode.
4605 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
4607 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4608 Update dependencies.
4610 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4612 * data.c (init_data): Remove code for UTS, this system is not
4615 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4617 Don't force ./temacs to start in terminal mode.
4619 * frame.c (make_initial_frame): Initialize faces in all cases, not
4620 only when CANNOT_DUMP is defined.
4621 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4623 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4625 * dispnew.c (add_window_display_history): Use const for the string
4626 pointer. Remove declaration, not needed.
4628 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4630 Use 'inline', not 'INLINE'.
4631 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
4632 * alloc.c, fontset.c (INLINE): Remove.
4633 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4634 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4635 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4636 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4637 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4639 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4641 Make it possible to run ./temacs.
4643 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4644 syms_of_callproc does the same thing. Remove test for
4645 "initialized", do it in the caller.
4646 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4648 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4650 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4651 (read_minibuf): Use get_minibuffer.
4652 (syms_of_minibuf): Use DEFSYM.
4653 (Qmetadata): New var.
4654 * data.c (Qbuffer): Don't make it static.
4655 (syms_of_data): Use DEFSYM.
4657 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4659 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4660 (CCL_CODE_MIN): New macro.
4662 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4664 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4666 * eval.c (Qdebug): Now static.
4667 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4668 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4669 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4671 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4673 * image.c: Various fixes to ImageMagick code comments.
4674 (Fimagemagick_types): Doc fix.
4676 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4678 Minor fixes prompted by GCC 4.6.0 warnings.
4680 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4682 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4683 (x_clipboard_manager_save_all): Move extern decl to ...
4684 * xterm.h: ... here, so that it can be checked for consistency.
4686 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4688 * xselect.c (x_clipboard_manager_save_frame)
4689 (x_clipboard_manager_save_all): New functions.
4690 (Fx_clipboard_manager_save): Lisp function deleted.
4692 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4693 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4695 * xterm.h: Update prototype.
4697 2011-05-28 William Xu <william.xwl@gmail.com>
4699 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4702 2011-05-28 Jim Meyering <meyering@redhat.com>
4704 Avoid a sign-extension bug in crypto_hash_function.
4705 * fns.c (to_uchar): Define.
4706 (crypto_hash_function): Use it to convert some newly-signed
4707 variables to unsigned, to avoid sign-extension bugs. For example,
4708 without this change, (md5 "truc") would evaluate to
4709 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4710 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
4711 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
4713 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4715 Integer overflow fixes.
4717 * dbusbind.c: Serial number integer overflow fixes.
4718 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
4719 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4720 to hold a serial number that is too large for a fixnum.
4721 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4722 Check for serial numbers out of range. Decode any serial number
4723 that was so large that it became a float. (Bug#8722)
4725 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4726 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4727 Use XFASTINT rather than XUINT when numbers are nonnegative.
4728 (xd_append_arg, Fdbus_method_return_internal):
4729 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4730 arguments, check that Lisp number is nonnegative, rather than
4731 silently wrapping negative numbers around. (Bug#8722)
4732 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
4735 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4737 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4739 ccl: add integer overflow checks
4740 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4741 (IN_INT_RANGE): New macros.
4742 (ccl_driver): Use them to check for integer overflow when
4743 decoding a CCL program. Many of the new checks are whether XINT (x)
4744 fits in int; it doesn't always, on 64-bit hosts. The new version
4745 doesn't catch all possible integer overflows, but it's an
4746 improvement. (Bug#8719)
4748 * alloc.c (make_event_array): Use XINT, not XUINT.
4749 There's no need for unsigned here.
4751 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4752 This follows up to the 2011-05-06 change that substituted uintptr_t
4753 for EMACS_INT. This case wasn't caught back then.
4755 Rework Fformat to avoid integer overflow issues.
4756 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4757 now (part of C89). Include <verify.h>.
4758 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4759 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4760 (Fformat): Avoid the prepass trying to compute sizes; it was only
4761 approximate and thus did not catch overflow reliably. Instead, walk
4762 through the format just once, formatting and computing sizes as we go,
4763 checking for integer overflow at every step, and allocating a larger
4764 buffer as needed. Keep track separately whether the format is
4765 multibyte. Keep only the most-recently calculated precision, rather
4766 than them all. Record whether each argument has been converted to
4767 string. Use EMACS_INT, not int, for byte and char and arg counts.
4768 Support field widths and precisions larger than INT_MAX. Avoid
4769 sprintf's undefined behavior with conversion specifications such as %#d
4770 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4771 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4772 formatting out-of-range floating point numbers with int
4775 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4777 * data.c: Avoid integer truncation in expressions involving floats.
4778 * data.c: Include <intprops.h>.
4779 (arith_driver): When there's an integer overflow in an expression
4780 involving floating point, convert the integers to floating point
4781 so that the resulting value does not suffer from catastrophic
4782 integer truncation. For example, on a 64-bit host (* 4
4783 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4784 Do not rely on undefined behavior after integer overflow.
4786 merge count_size_as_multibyte, parse_str_to_multibyte
4787 * character.c, character.h (count_size_as_multibyte):
4788 Rename from parse_str_to_multibyte; all uses changed.
4789 Check for integer overflow.
4790 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4791 since it's now a duplicate of the other. This is more of
4792 a character than a buffer op, so better that it's in character.c.
4793 * fns.c, print.c: Adjust to above changes.
4795 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4797 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4799 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4801 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4802 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4803 (x_clipboard_manager_save): Now static.
4804 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4806 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4807 (crypto_hash_function): Now static.
4808 Fix pointer signedness problems. Avoid unnecessary initializations.
4810 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
4812 * termhooks.h (Vselection_alist): Make it terminal-local.
4814 * terminal.c (create_terminal): Initialize it.
4816 * xselect.c: Support for clipboard managers.
4817 (Vselection_alist): Move to termhooks.h as terminal-local var.
4818 (LOCAL_SELECTION): New macro.
4819 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4820 (symbol_to_x_atom): Remove gratuitous arg.
4821 (x_handle_selection_request, lisp_data_to_selection_data)
4822 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
4823 (x_own_selection, x_get_local_selection, x_convert_selection):
4824 New arg, specifying work frame. Use terminal-local Vselection_alist.
4825 (some_frame_on_display): Delete unused function.
4826 (Fx_own_selection_internal, Fx_get_selection_internal)
4827 (Fx_disown_selection_internal, Fx_selection_owner_p)
4828 (Fx_selection_exists_p): New optional frame arg.
4829 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4830 (x_handle_selection_clear): Don't treat other terminals with the
4831 same keyboard specially. Use the terminal-local Vselection_alist.
4832 (x_clear_frame_selections): Use Frun_hook_with_args.
4834 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4836 * xterm.h: Add support for those atoms.
4838 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
4840 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4841 (converted_selections, conversion_fail_tag): New global variables.
4842 (x_selection_request_lisp_error): Free the above.
4843 (x_get_local_selection): Remove unnecessary code.
4844 (x_reply_selection_request): Args changed; handle arbitrary array
4845 of converted selections stored in converted_selections.
4846 Separate the XChangeProperty and SelectionNotify steps.
4847 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4848 (x_convert_selection): New function.
4849 (x_handle_selection_event): Simplify.
4850 (x_get_foreign_selection): Don't ignore incoming requests while
4851 waiting for an answer; this will fail when we implement
4852 SAVE_TARGETS, and seems unnecessary anyway.
4853 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4854 (Vx_sent_selection_functions): Doc fix.
4856 2011-05-26 Leo Liu <sdl.web@gmail.com>
4858 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4860 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4862 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4864 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4865 for fringe update if it has periodic bitmap.
4866 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
4867 and fringe_bitmap_periodic_p.
4869 * fringe.c (get_fringe_bitmap_data): New function.
4870 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4871 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4872 row. Mark glyph row for fringe update if periodicity changed.
4874 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4875 for fringe update unless it has periodic bitmap.
4877 2011-05-25 Kenichi Handa <handa@m17n.org>
4879 * xdisp.c (get_next_display_element): Set correct it->face_id for
4880 a static composition.
4882 2011-05-24 Leo Liu <sdl.web@gmail.com>
4885 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4887 * fns.c (crypto_hash_function, Fsha1): New function.
4888 (Fmd5): Use crypto_hash_function.
4889 (syms_of_fns): Add Ssha1.
4891 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4893 * gnutls.c: Remove unused macros.
4894 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4895 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4896 Remove macros that are defined and never used.
4897 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4899 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4901 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4902 (Fx_get_selection_internal): Minor cleanup.
4903 (Fx_own_selection_internal): Rename arguments for consistency with
4906 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4908 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4910 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4912 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4914 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4916 * dispnew.c (scrolling_window): Don't exclude the case that the
4917 last enabled row in the desired matrix touches the bottom boundary.
4919 2011-05-21 Glenn Morris <rgm@gnu.org>
4921 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
4922 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4923 and add some more files.
4925 2011-05-20 Eli Zaretskii <eliz@gnu.org>
4927 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4928 report_file_error introduced by the change from 2011-05-07.
4930 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4932 * systime.h (Time): Define only if emacs is defined.
4933 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4934 where the include path doesn't have X11/X.h by default. See
4935 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4937 2011-05-20 Kenichi Handa <handa@m17n.org>
4939 * composite.c (find_automatic_composition): Fix previous change.
4941 2011-05-20 Glenn Morris <rgm@gnu.org>
4943 * lisp.mk: New file, split from Makefile.in.
4944 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4945 (shortlisp): Remove.
4946 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4948 2011-05-19 Glenn Morris <rgm@gnu.org>
4950 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4951 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4952 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4953 (lisp): Set the order to that of loadup.el.
4954 (shortlisp): Make it a copy of $lisp.
4955 (SOME_MACHINE_LISP): Remove.
4956 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4957 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4959 2011-05-18 Kenichi Handa <handa@m17n.org>
4961 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4962 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4963 (find_automatic_composition): Mostly rewrite for efficiency.
4965 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
4967 * makefile.w32-in: Update dependencies.
4969 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4971 * menu.c: Include limits.h (fixes the MS-Windows build broken by
4972 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
4974 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
4976 Fix some integer overflow issues, such as string length overflow.
4978 * insdel.c (count_size_as_multibyte): Check for string overflow.
4980 * character.c (lisp_string_width): Check for string overflow.
4981 Use EMACS_INT, not int, for string indexes and lengths; in
4982 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4983 the resulting string length overflows an EMACS_INT; instead,
4984 report a string overflow if no precision given. When checking for
4985 precision exhaustion, use a check that cannot possibly have
4986 integer overflow. (Bug#8675)
4987 * character.h (lisp_string_width): Adjust to new signature.
4989 * alloc.c (string_overflow): New function.
4990 (Fmake_string): Use it. This doesn't change behavior, but saves
4991 a few bytes and will simplify future changes.
4992 * character.c (string_escape_byte8): Likewise.
4993 * lisp.h (string_overflow): New decl.
4995 Fixups, following up to the user-interface timestamp change.
4996 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4997 for UI timestamps, instead of unsigned long.
4998 * msdos.c (mouse_get_pos): Likewise.
4999 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
5000 * w32gui.h (Time): Define by including "systime.h" rather than by
5001 declaring it ourselves. (Bug#8664)
5003 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5004 * image.c (clear_image_cache): Likewise.
5006 * term.c (term_mouse_position): Don't assume time_t wraparound.
5008 Be more systematic about user-interface timestamps.
5009 Before, the code sometimes used 'Time', sometimes 'unsigned long',
5010 and sometimes 'EMACS_UINT', to represent these timestamps.
5011 This change causes it to use 'Time' uniformly, as that's what X uses.
5012 This makes the code easier to follow, and makes it easier to catch
5013 integer overflow bugs such as Bug#8664.
5014 * frame.c (Fmouse_position, Fmouse_pixel_position):
5015 Use Time, not unsigned long, for user-interface timestamps.
5016 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5017 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5018 * keyboard.h (last_event_timestamp): Likewise.
5019 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5020 * menu.h (xmenu_show): Likewise.
5021 * term.c (term_mouse_position): Likewise.
5022 * termhooks.h (struct input_event.timestamp): Likewise.
5023 (struct terminal.mouse_position_hook): Likewise.
5024 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5025 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5026 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5027 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5029 * menu.h, termhooks.h: Include "systime.h", for Time.
5031 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5032 Don't assume that the difference between two unsigned long values
5033 can fit into an integer. At this point, we know button_down_time
5034 <= event->timestamp, so the difference must be nonnegative, so
5035 there's no need to cast the result if double-click-time is
5036 nonnegative, as it should be; check that it's nonnegative, just in
5037 case. This bug is triggered when events are more than 2**31 ms
5038 apart (about 25 days). (Bug#8664)
5040 * xselect.c (last_event_timestamp): Remove duplicate decl.
5041 (x_own_selection): Remove needless cast to unsigned long.
5043 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5044 that always fit in int. Use a sentinel instead of a counter, to
5045 avoid a temp and to allay GCC's concerns about possible int overflow.
5046 * frame.h (struct frame): Use int for menu_bar_items_used
5047 instead of EMACS_INT, since it always fits in int.
5049 * menu.c (grow_menu_items): Check for int overflow.
5051 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5053 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5054 Before, the code was not consistent. These values cannot exceed
5055 2**31 - 1 so there's no need to make them unsigned.
5056 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5057 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5058 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5060 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5062 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5063 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5064 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5065 presumably because the widths might not match.
5067 * window.c (size_window): Avoid needless test at loop start.
5069 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5071 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5073 2011-05-12 Drew Adams <drew.adams@oracle.com>
5075 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5077 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5079 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5080 `width' to `bar_area_x' and `bar_area_width', respectively.
5081 (x_scroll_run): Take account of fringe background extension.
5083 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5084 Rename local vars `left' and `width' to `bar_area_x' and
5085 `bar_area_width', respectively.
5086 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5087 background extension.
5089 2011-05-10 Jim Meyering <meyering@redhat.com>
5091 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5093 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
5095 * image.c (Finit_image_library): Return t for built-in image types,
5096 like pbm and xbm. (Bug#8640)
5098 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5100 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5102 2011-05-07 Eli Zaretskii <eliz@gnu.org>
5104 * w32console.c (Fset_screen_color): Doc fix.
5105 (Fget_screen_color): New function.
5106 (syms_of_ntterm): Defsubr it.
5108 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5109 unlink the temporary file if Fcall_process didn't create it in the
5111 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5112 child process will be redirected to a file specified with `:file'.
5113 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5114 cue to call_process_cleanup not to close that handle.
5116 2011-05-07 Ben Key <bkey76@gmail.com>
5118 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5119 one of two shell specific rules, either bootstrap-temacs-CMD or
5120 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5121 to the previous implementation of the bootstrap-temacs rule.
5122 The bootstrap-temacs-CMD rule is similar to the previous
5123 implementation of the bootstrap-temacs rule except that it
5124 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5127 These changes, along with some changes to nt/configure.bat,
5128 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5129 earlier fix to add support for --cflags and --ldflags options
5130 that include quotes so that it works whether make uses cmd or
5133 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
5135 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5136 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5138 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5139 a string. Handle both cases.
5140 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5141 (Fdbus_register_method): Use Qinvalid_function.
5143 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
5145 * makefile.w32-in: Update dependencies.
5146 (LISP_H): Add inttypes.h and stdin.h.
5147 (PROCESS_H): Add unistd.h.
5149 2011-05-06 Eli Zaretskii <eliz@gnu.org>
5151 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5152 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5154 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
5156 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5158 * term.c (vfatal): Remove stray call to va_end.
5159 It's not needed and the C Standard doesn't allow it here anyway.
5161 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5162 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5164 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5167 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5169 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5171 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5173 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5175 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5177 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5178 * charset.c (Fdefine_charset_internal): Don't initialize
5179 charset.code_space[15]. The value was garbage, on hosts with
5180 32-bit int (Bug#8600).
5182 * lread.c (read_integer): Be more consistent with string-to-number.
5183 Use string_to_number to do the actual conversion; this avoids
5184 rounding errors and fixes some other screwups. Without this fix,
5185 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5186 (digit_to_number): Move earlier, for benefit of read_integer.
5187 Return -1 if the digit is out of range for the base, -2 if it is
5188 not a digit in any supported base. (Bug#8602)
5190 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5192 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5193 to match comment at start of function. This also removes a
5194 GCC warning about overflow in a 32+64-bit port.
5196 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5198 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5199 Reported by Stefan Monnier in
5200 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
5201 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5202 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
5204 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5205 (EMACS_UINTPTR): Likewise, with uintptr_t.
5207 * lisp.h: Prefer 64-bit EMACS_INT if available.
5208 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5209 on 32-bit hosts that have 64-bit int, so that they can access
5211 However, temporarily disable this change unless the temporary
5212 symbol WIDE_EMACS_INT is defined.
5214 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5216 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5217 This removes an assumption that EMACS_INT and long are the same
5218 width as pointers. The assumption is true for Emacs porting targets
5219 now, but we want to make other targets possible.
5220 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5221 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5222 In the rest of the code, change types of integers that hold casted
5223 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5224 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5225 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5226 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5227 No need to cast type when ORing.
5228 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5229 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5230 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5231 assume EMACS_INT is the same width as char *.
5232 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5233 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5234 Remove no-longer-needed casts.
5235 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5236 (xg_tool_bar_help_callback, xg_make_tool_item):
5237 Use EMACS_INTPTR to hold an integer
5238 that will be cast to void *; this can avoid a GCC warning
5239 if EMACS_INT is not the same width as void *.
5240 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5241 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5242 (current_message_1, set_message_1):
5243 Use a local to convert to proper width without a cast.
5244 * xmenu.c (dialog_selection_callback): Likewise.
5246 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5247 Also, don't assume VALBITS / RAND_BITS is less than 5,
5248 and don't rely on undefined behavior when shifting a 1 left into
5250 * lisp.h (get_random): Change signature to match.
5252 * lread.c (hash_string): Use size_t, not int, for hash computation.
5253 Normally we prefer signed values; but hashing is special, because
5254 it's better to use unsigned division on hash table sizes so that
5255 the remainder is nonnegative. Also, size_t is the natural width
5256 for hashing into memory. The previous code used 'int', which doesn't
5257 retain enough info to hash well into very large tables.
5258 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5260 * dbusbind.c: Don't possibly lose pointer info when converting.
5261 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5262 Use XPNTR rather than XHASH, so that the high-order bits of
5263 the pointer aren't lost when converting through void *.
5265 * eval.c (Fautoload): Don't double-shift a pointer.
5267 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5269 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
5271 * gnutls.c (DEF_GNUTLS_FN):
5272 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5274 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5276 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5279 2011-05-05 Eli Zaretskii <eliz@gnu.org>
5281 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5282 New version that can reserve upto 2GB of heap space.
5284 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
5286 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5288 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5290 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5291 `gnutls_certificate_set_x509_key_file'.
5293 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
5295 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5296 Update dependencies.
5298 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5300 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5301 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5302 Remove unused parameter `fildes'.
5303 * process.c (read_process_output, send_process): Don't pass it.
5305 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5307 Fix previous change: the library cache is defined in w32.c.
5308 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5309 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5311 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5313 Implement dynamic loading of GnuTLS on Windows.
5315 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5316 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5317 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5320 * gnutls.c (Qgnutls_dll): Define.
5321 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5322 (gnutls_*): Declare function pointers.
5323 (init_gnutls_functions): New function to initialize function pointers.
5324 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5325 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5326 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5327 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5328 (emacs_gnutls_write, emacs_gnutls_read)
5329 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5330 (Fgnutls_available_p): New function.
5331 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5332 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5333 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5335 * image.c: Include w32.h.
5336 (Vimage_type_cache): Delete.
5337 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5338 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5339 (w32_delayed_load): Move to w32.c.
5341 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5343 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5344 (w32_delayed_load): Move from image.c. When loading a library, record
5345 its filename in the :loaded-from property of the library id.
5346 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5347 Initialize and staticpro them.
5348 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5350 * process.c: Include lisp.h before w32.h, not after.
5351 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5352 instead of gnutls_record_check_pending.
5354 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5356 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5358 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5359 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5362 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5364 * xterm.c (x_set_frame_alpha): Do not set property on anything
5365 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5367 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
5369 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5371 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
5373 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5374 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5375 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5376 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5377 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5378 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5379 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5380 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5381 (Qgnutls_bootprop_callbacks_verify): Make static.
5383 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5385 * callproc.c: Indentation fixup.
5387 * sysdep.c (wait_for_termination_1): Make static.
5388 (wait_for_termination, interruptible_wait_for_termination):
5389 Move after wait_for_termination_1.
5391 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5393 * sysdep.c (interruptible_wait_for_termination): New function
5394 which is like wait_for_termination, but allows keyboard
5397 * callproc.c (Fcall_process): Add (:file "file") as an option for
5399 (Fcall_process_region): Ditto.
5401 2011-04-30 Eli Zaretskii <eliz@gnu.org>
5403 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5404 rather than `XVECTOR (FOO)->size'.
5406 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5407 inttypes.h, as a gnulib replacement is used if it not available in
5410 2011-04-21 Eli Zaretskii <eliz@gnu.org>
5412 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5413 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5414 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5416 * coding.c (coding_alloc_by_realloc): Error out if destination
5417 will grow beyond MOST_POSITIVE_FIXNUM.
5418 (decode_coding_emacs_mule): Abort if there isn't enough place in
5419 charbuf for the composition carryover bytes. Reserve an extra
5420 space for up to 2 characters produced in a loop.
5421 (decode_coding_iso_2022): Abort if there isn't enough place in
5422 charbuf for the composition carryover bytes.
5424 2011-04-21 Eli Zaretskii <eliz@gnu.org>
5426 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5427 aborting when %lld or %lll format is passed.
5428 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5429 %llo or %llx format is passed. (Bug#8545)
5431 * window.c (window_scroll_line_based): Use a marker instead of
5432 simple variables to record original value of point. (Bug#7952)
5434 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5435 produced by %s or %c overflows available buffer space. (Bug#8545)
5437 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5439 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
5440 (SIZE_MAX): Move defn after all includes, as they might #define it.
5442 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5444 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5446 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5448 * keyboard.c (Qdelayed_warnings_hook): Define.
5449 (command_loop_1): Run `delayed-warnings-hook'
5450 if Vdelayed_warnings_list is non-nil.
5451 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5452 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5454 2011-04-28 Eli Zaretskii <eliz@gnu.org>
5456 * doprnt.c (doprnt): Don't return value smaller than the buffer
5457 size if the message was truncated. (Bug#8545).
5459 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5461 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5462 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5464 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5466 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5468 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
5470 * makefile.w32-in: Update dependencies.
5472 2011-04-27 Eli Zaretskii <eliz@gnu.org>
5474 Improve `doprnt' and its usage. (Bug#8545)
5475 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5476 `format_end'. Remove support for %l as a conversion specifier.
5477 Don't use xrealloc. Improve diagnostics when the %l size modifier
5478 is used. Update the commentary.
5480 * eval.c (verror): Simplify calculation of size_t.
5482 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5485 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5487 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5490 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5492 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5493 This makes this file independent of the recent pseudovector change.
5495 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
5497 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5499 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
5500 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
5501 Remove unused local.
5502 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
5504 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
5505 GCC 4.6.0 optimizes based on type-based alias analysis.
5506 For example, if b is of type struct buffer * and v of type struct
5507 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5508 != &v->size, and therefore "v->size = 1; b->size = 2; return
5509 v->size;" must therefore return 1. This assumption is incorrect
5510 for Emacs, since it type-puns struct Lisp_Vector * with many other
5511 types. To fix this problem, this patch adds a new type struct
5512 vectorlike_header that documents the constraints on layout of vectors
5513 and pseudovectors, and helps optimizing compilers not get fooled
5514 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5515 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
5516 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5518 (XSETPVECTYPE): Rewrite in terms of new macro.
5519 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5520 This is a bit clearer, and further avoids the possibility of
5521 undesirable aliasing.
5522 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
5523 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
5524 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5525 since Lisp_Subr is a special case (no "next" field).
5526 (ASIZE): Now uses header.size rather than size.
5527 All previous uses of XVECTOR (foo)->size replaced to use this macro,
5528 to avoid the hassle of writing XVECTOR (foo)->header.size.
5529 (struct vectorlike_header): New type.
5530 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5531 object, to help avoid aliasing.
5532 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5533 (SUBRP): Likewise, since Lisp_Subr is a special case.
5534 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5535 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5536 (struct Lisp_Hash_Table): Combine first two members into a single
5537 struct vectorlike_header member. All uses of "size" and "next" members
5538 changed to be "header.size" and "header.next".
5539 * buffer.h (struct buffer): Likewise.
5540 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5541 * frame.h (struct frame): Likewise.
5542 * process.h (struct Lisp_Process): Likewise.
5543 * termhooks.h (struct terminal): Likewise.
5544 * window.c (struct save_window_data, struct saved_window): Likewise.
5545 * window.h (struct window): Likewise.
5546 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5547 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5548 * buffer.c (init_buffer_once): Likewise.
5549 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5551 * process.c (Fformat_network_address): Use local var for size,
5554 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5556 Make the Lisp reader and string-to-float more consistent (Bug#8525)
5557 * data.c (atof): Remove decl; no longer used or needed.
5558 (digit_to_number): Move to lread.c.
5559 (Fstring_to_number): Use new string_to_number function, to be
5560 consistent with how the Lisp reader treats infinities and NaNs.
5561 Do not assume that floating-point numbers represent EMACS_INT
5562 without losing information; this is not true on most 64-bit hosts.
5563 Avoid double-rounding errors, by insisting on integers when
5564 parsing non-base-10 numbers, as the documentation specifies.
5565 * lisp.h (string_to_number): New decl, replacing ...
5566 (isfloat_string): Remove.
5567 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
5568 (read1): Do not accept +. and -. as integers; this
5569 appears to have been a coding error. Similarly, do not accept
5570 strings like +-1e0 as floating point numbers. Do not report
5571 overflow for integer overflows unless the base is not 10 which
5572 means we have no simple and reliable way to continue.
5573 Break out the floating-point parsing into a new
5574 function string_to_number, so that Fstring_to_number parses
5575 floating point numbers consistently with the Lisp reader.
5576 (digit_to_number): Move here from data.c. Make it static inline.
5577 (E_CHAR, EXP_INT): Remove, replacing with ...
5578 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5579 (string_to_number): New function, replacing isfloat_string.
5580 This function checks for valid syntax and produces the resulting
5581 Lisp float number too. Rework it so that string-to-number
5582 no longer mishandles examples like "1.0e+". Use strtoumax,
5583 so that overflow for non-base-10 numbers is reported only when
5584 there's no portable and simple way to convert to floating point.
5586 * textprop.c (set_text_properties_1): Rewrite for clarity,
5587 and to avoid GCC warning about integer overflow.
5589 * intervals.h (struct interval): Use EMACS_INT for members
5590 where EMACS_UINT might cause problems. See
5591 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5592 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5593 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5595 (offset_intervals): Tell GCC not to worry about length overflow
5596 when negating a negative length.
5598 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5599 (overrun_check_free): Likewise.
5601 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5602 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5605 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5606 (gnutls_make_error): Rename local to avoid shadowing.
5607 (gnutls_emacs_global_deinit): ifdef out; not used.
5608 (Fgnutls_boot): Use const for pointer to readonly storage.
5609 Comment out unused local. Fix pointer signedness problems.
5611 * lread.c (openp): Don't stuff size_t into an 'int'.
5612 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5613 about possible signed overflow.
5615 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5616 (GDK_KEY_g): Don't define if already defined.
5617 (xg_prepare_tooltip): Avoid pointer signedness problem.
5618 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5620 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5621 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5623 * xfns.c (Fx_window_property): Simplify a bit,
5624 to make a bit faster and to avoid GCC 4.6.0 warning.
5625 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5627 * fns.c (internal_equal): Don't assume size_t fits in int.
5629 * alloc.c (compact_small_strings): Tighten assertion a little.
5631 Replace pEd with more-general pI, and fix some printf arg casts.
5632 * lisp.h (pI): New macro, generalizing old pEd macro to other
5633 conversion specifiers. For example, use "...%"pI"d..." rather
5634 than "...%"pEd"...".
5635 (pEd): Remove. All uses replaced with similar uses of pI.
5636 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5637 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5638 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5639 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5640 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5641 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5642 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5644 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5645 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5646 * print.c (safe_debug_print, print_object): Likewise.
5647 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5649 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5650 avoiding the 0 flag, which is not portable.
5651 * process.c (Fmake_network_process): Use pI to avoid cast.
5652 * region-cache.c (pp_cache): Likewise.
5653 * xdisp.c (decode_mode_spec): Likewise.
5654 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5655 behavior on 64-bit hosts with printf arg.
5656 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
5657 (x_stop_queuing_selection_requests): Likewise.
5658 (x_get_window_property): Don't truncate byte count to an 'int'
5661 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5662 here, since it parses constructs like leading '-' and spaces,
5663 which are not wanted; and it overflows with large numbers.
5664 Instead, simply match F[0-9]+, which is what is wanted anyway.
5666 * alloc.c: Remove unportable assumptions about struct layout.
5667 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5668 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5669 (allocate_vectorlike, make_pure_vector): Use the new macros,
5670 plus offsetof, to remove unportable assumptions about struct layout.
5671 These assumptions hold on all porting targets that I know of, but
5672 they are not guaranteed, they're easy to remove, and removing them
5673 makes further changes easier.
5675 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5676 This doesn't fix a bug but makes the code clearer.
5677 (string_overrun_cookie): Now const. Use initializers that
5678 don't formally overflow signed char, to avoid warnings.
5679 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5680 can cause Emacs to crash when string overrun checking is enabled.
5681 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5682 multiple of sizeof (EMACS_INT); it need not be, if
5683 alignof(EMACS_INT) < sizeof (EMACS_INT).
5684 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
5686 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
5688 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5690 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5692 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
5693 supposed to be handshaking. (Bug#8556)
5694 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5696 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
5698 * lisp.h (Qdebug): List symbol.
5699 * eval.c (Qdebug): Restore global linkage.
5700 * keyboard.c (debug-on-event): New variable.
5701 (handle_user_signal): Break into debugger when debug-on-event
5702 matches the current signal symbol.
5704 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5706 * alloc.c (check_sblock, check_string_bytes)
5707 (check_string_free_list): Convert to standard C.
5709 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5711 * w32.c (emacs_gnutls_push): Fix typo.
5713 2011-04-25 Eli Zaretskii <eliz@gnu.org>
5715 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5716 "cast to pointer from integer of different size".
5718 Improve doprnt and its use in verror. (Bug#8545)
5719 * doprnt.c (doprnt): Document the set of format control sequences
5720 supported by the function. Use SAFE_ALLOCA instead of always
5723 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5724 is one byte too soon. Don't use xrealloc; instead xfree and
5727 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5729 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5732 * gnutls.c: Renamed global_initialized to
5733 gnutls_global_initialized. Added internals for the
5734 :verify-hostname-error, :verify-error, and :verify-flags
5735 parameters of `gnutls-boot' and documented those parameters in the
5736 docstring. Start callback support.
5737 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5738 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5739 on error. Return error code.
5740 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5741 (emacs_gnutls_read): Likewise.
5742 (Fgnutls_boot): Return handshake error code.
5743 (emacs_gnutls_handle_error): New function.
5744 (wsaerror_to_errno): Likewise.
5746 * w32.h (emacs_gnutls_pull): Add prototype.
5747 (emacs_gnutls_push): Likewise.
5749 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5750 (emacs_gnutls_push): Likewise.
5752 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5754 * process.c (wait_reading_process_output): Check if GnuTLS
5755 buffered some data internally if no FDs are set for TLS
5758 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5759 (LIBS): Link to USER_LIBS.
5760 ($(BLD)/gnutls.$(0)): New target.
5762 2011-04-24 Eli Zaretskii <eliz@gnu.org>
5764 * xdisp.c (handle_single_display_spec): Rename the
5765 display_replaced_before_p argument into display_replaced_p, to
5766 make it consistent with the commentary. Fix typos in the
5769 * textprop.c (syms_of_textprop): Remove dead code.
5770 (copy_text_properties): Delete obsolete commentary about an
5771 interface that was deleted long ago. Fix typos in the description
5774 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5775 to changes in oldXMenu/XMenu.h from 2011-04-16.
5776 <menu_help_message, prev_menu_help_message>: Constify.
5777 (IT_menu_make_room): menu->help_text is now `const char **';
5780 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5781 to changes in oldXMenu/XMenu.h from 2011-04-16.
5782 (struct XMenu): Declare `help_text' `const char **'.
5784 * xfaces.c <Qunspecified>: Make extern again.
5786 * syntax.c: Include sys/types.h before including regex.h, as
5789 * doc.c (get_doc_string): Improve the format passed to `error'.
5791 * doprnt.c (doprnt): Improve commentary.
5793 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5795 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5798 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5799 changes in globals.h immediately force recompilation.
5800 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5801 $(CURDIR)/s/ms-w32.h.
5802 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
5804 * character.c (Fchar_direction): Function deleted.
5805 (syms_of_character): Don't defsubr it.
5806 <char-direction-table>: Deleted.
5808 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5810 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5811 * doprnt.c: Include limits.h.
5812 (SIZE_MAX): New macro.
5813 (doprnt): Return a size_t value. 2nd arg is now size_t.
5814 Many local variables are now size_t instead of int or unsigned.
5815 Improve overflow protection. Support `l' modifier for integer
5816 conversions. Support %l conversion. Don't assume an EMACS_INT
5817 argument for integer conversions and for %c.
5819 * lisp.h (doprnt): Restore prototype.
5821 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5824 * Makefile.in (base_obj): Add back doprnt.o.
5826 * deps.mk (doprnt.o): Add back prerequisites.
5827 (callint.o): Depend on character.h.
5829 * eval.c (internal_lisp_condition_case): Include the handler
5830 representation in the error message.
5831 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5832 when breaking from the loop.
5834 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5836 * callint.c (Fcall_interactively): When displaying error message
5837 about invalid control letter, pass the character's codepoint, not
5838 a pointer to its multibyte form. Improve display of the character
5839 in octal and display also its hex code.
5841 * character.c (char_string): Use %x to display the (unsigned)
5842 codepoint of an invalid character, to avoid displaying a bogus
5845 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5846 `error', not SYMBOL_NAME itself.
5848 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5849 character arguments to `error'.
5851 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5852 to `error' in error message about FINAL_CHAR argument. Make sure
5853 FINAL_CHAR is a character, and use %c when it is passed as
5854 argument to `error'.
5856 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5858 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5860 * w32.c: Include <time.h>.
5861 (sys_localtime): New function.
5863 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
5865 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5867 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
5869 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
5871 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5874 2011-04-19 Eli Zaretskii <eliz@gnu.org>
5876 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5877 gl_state.e_property when gl_state.object is Qt.
5879 * insdel.c (make_gap_larger): Remove limitation of buffer size
5882 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
5884 * xdisp.c (lookup_glyphless_char_display)
5885 (produce_glyphless_glyph): Handle cons cell entry in
5886 glyphless-char-display.
5887 (Vglyphless_char_display): Document it.
5889 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5890 glyphless-char-display.
5892 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
5894 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5896 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5898 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5899 definition for no-X builds.
5901 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
5903 Static checks with GCC 4.6.0 and non-default toolkits.
5905 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5907 * process.c (keyboard_bit_set): Define only if SIGIO.
5908 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5909 (send_process): Repair possible setjmp clobbering.
5911 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5913 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5915 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5917 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5918 Define only if needed.
5920 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5921 by pacifying GCC about it. Maybe it's time to retire it?
5922 * xfaces.c (USG, __TIMEVAL__): Likewise.
5924 * dispextern.h (struct redisplay_interface): Rename param
5926 * termhooks.h (struct terminal): Likewise.
5927 * xterm.c (xembed_send_message): Likewise.
5929 * insdel.c (make_gap_smaller): Define only if
5930 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5932 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5935 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5936 so that we aren't warned about unused symbols.
5938 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5940 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
5942 * xfns.c (x_real_positions): Mark locals as initialized.
5944 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5946 * xterm.c: Fix problems found by static analysis with other toolkits.
5947 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
5948 (x_dispatch_event): Declare static if USE_GTK, and
5949 define if USE_GTK || USE_X_TOOLKIT.
5950 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
5951 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
5952 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5953 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
5955 * xmenu.c (menu_help_callback): Pointer type fixes.
5956 Use const pointers when pointing at readonly data. Avoid pointer
5958 (FALSE): Remove unused macro.
5959 (update_frame_menubar): Remove unused decl.
5961 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5963 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5964 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5965 (single_menu_item): Rename local to avoid shadowing.
5967 * keyboard.c (make_lispy_event): Remove unused local var.
5969 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5970 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5972 * bitmaps: Change bitmaps from unsigned char back to the X11
5973 compatible char. Avoid the old compiler warnings about
5974 out-of-range initializers by using, for example, '\xab' rather
5977 * xgselect.c (xgselect_initialize): Check vs interface
5978 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5980 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5982 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5983 to read-only memory.
5985 * fns.c (vector): Remove; this old hack is no longer needed.
5987 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
5989 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
5991 * xrdb.c (x_load_resources): Omit unused local.
5993 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
5994 (x_window): Rename locals to avoid shadowing.
5995 (USG): Use the kludged USG macro, to pacify gcc.
5997 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
5998 (x_term_init): Remove local to avoid shadowing.
6000 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
6002 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6003 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6005 2011-04-16 Eli Zaretskii <eliz@gnu.org>
6007 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6009 Fix regex.c, syntax.c and friends for buffers > 2GB.
6010 * syntax.h (struct gl_state_s): Declare character position members
6013 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6015 * textprop.c (verify_interval_modification, interval_of):
6016 Declare arguments EMACS_INT.
6018 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6021 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6023 * indent.c (Fvertical_motion): Local variable it_start is now
6026 * regex.c (re_match, re_match_2, re_match_2_internal)
6027 (bcmp_translate, regcomp, regexec, print_double_string)
6028 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6029 (re_compile_pattern, re_exec): Declare arguments and local
6030 variables `size_t' and `ssize_t' and return values `regoff_t', as
6032 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6033 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6034 <compile_stack_type>: `size' and `avail' are now `size_t'.
6036 * regex.h <regoff_t>: Use ssize_t, not int.
6037 (re_search, re_search_2, re_match, re_match_2): Arguments that
6038 specify buffer/string position and length are now ssize_t and
6039 size_t. Return type is regoff_t.
6041 2011-04-16 Ben Key <bkey76@gmail.com>
6043 * nsfont.m: Fixed bugs in ns_get_family and
6044 ns_descriptor_to_entity that were caused by using free to
6045 deallocate memory blocks that were allocated by xmalloc (via
6046 xstrdup). This caused Emacs to crash when compiled with
6047 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6048 --enable-checking=xmallocoverrun). xfree is now used to
6049 deallocate these memory blocks.
6051 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
6053 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6055 emacs_write: Accept and return EMACS_INT for sizes.
6056 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6058 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6059 Accept and return EMACS_INT.
6060 (emacs_gnutls_write): Return the number of bytes written on
6062 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
6063 (emacs_read, emacs_write): Remove check for negative size, as the
6064 Emacs source code has been audited now.
6065 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6066 (emacs_read, emacs_write): Use it.
6067 * process.c (send_process): Adjust to the new signatures of
6068 emacs_write and emacs_gnutls_write. Do not attempt to store
6069 a byte offset into an 'int'; it might overflow.
6070 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
6072 * sound.c: Don't assume sizes fit in 'int'.
6073 (struct sound_device.period_size, alsa_period_size):
6074 Return EMACS_INT, not int.
6075 (struct sound_device.write, vox_write, alsa_write):
6076 Accept EMACS_INT, not int.
6077 (wav_play, au_play): Use EMACS_INT to store sizes and to
6078 record read return values.
6080 2011-04-15 Ben Key <bkey76@gmail.com>
6082 * keyboard.c (Qundefined): Don't declare static since it is used
6084 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6085 static since they are used in nsfont.m.
6087 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6089 * process.c (Qprocessp): Don't declare static.
6090 * lisp.h (Qprocessp): Declare again.
6092 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
6094 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6096 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6098 Improve C-level modularity by making more things 'static'.
6100 Don't publish debugger-only interfaces to other modules.
6101 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6102 (verify_bytepos, count_markers): Move decls to the only modules
6104 * region-cache.h (pp_cache): Likewise.
6105 * window.h (check_all_windows): Likewise.
6106 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6108 * sysdep.c (croak): Now static, if
6109 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6110 * syssignal.h (croak): Declare only if not static.
6112 * alloc.c (refill_memory_reserve): Now static if
6113 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6114 * lisp.h (refill_memory_reserve): Declare only if not static.
6116 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6117 Define only if USE_LUCID.
6119 * xrdb.c (x_customization_string, x_rm_string): Now static.
6121 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6122 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6124 * xdisp.c (draw_row_with_mouse_face): Now static.
6125 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6127 * window.h (check_all_windows): Mark externally visible.
6129 * window.c (window_deletion_count): Now static.
6131 * undo.c: Make symbols static if they're not exported.
6132 (last_undo_buffer, last_boundary_position, pending_boundary):
6135 * textprop.c (interval_insert_behind_hooks): Now static.
6136 (interval_insert_in_front_hooks): Likewise.
6138 * term.c: Make symbols static if they're not exported.
6139 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6140 (max_frame_lines, tty_set_terminal_modes):
6141 (tty_reset_terminal_modes, tty_turn_off_highlight):
6142 (get_tty_terminal): Now static.
6143 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6144 * termhooks.h (term_mouse_moveto): Do not declare if
6146 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6147 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6149 * sysdep.c: Make symbols static if they're not exported.
6150 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6152 (sigprocmask_set, full_mask): Remove; unused.
6153 (wait_debugging): Mark as visible.
6154 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6155 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6157 * syntax.c (syntax_temp): Define only if !__GNUC__.
6159 * sound.c (current_sound_device, current_sound): Now static.
6161 * search.c (searchbufs, searchbuf_head): Now static.
6163 * scroll.c (scroll_cost): Remove; unused.
6164 * dispextern.h (scroll_cost): Remove decl.
6166 * region-cache.h (pp_cache): Mark as externally visible.
6168 * process.c: Make symbols static if they're not exported.
6169 (process_tick, update_tick, create_process, chan_process):
6170 (Vprocess_alist, proc_buffered_char, datagram_access):
6171 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6172 (deactivate_process): Mark defn as static, as well as decl.
6173 * lisp.h (create_process): Remove decl.
6174 * process.h (chan_process, Vprocess_alist): Remove decls.
6176 * print.c: Make symbols static if they're not exported.
6177 (print_depth, new_backquote_output, being_printed, print_buffer):
6178 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6179 (print_interval, print_number_index, initial_stderr_stream):
6181 * lisp.h (Fprinc): Remove decl.
6182 (debug_output_compilation_hack): Mark as externally visible.
6184 * sysdep.c (croak): Move decl from here to syssignal.h.
6185 * syssignal.h (croak): Put it here, so the API can be checked when
6186 'croak' is called from dissociate_if_controlling_tty.
6188 * minibuf.c: Make symbols static if they're not exported.
6189 (minibuf_save_list, choose_minibuf_frame): Now static.
6190 * lisp.h (choose_minibuf_frame): Remove decl.
6192 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6194 * lread.c: Make symbols static if they're not exported.
6195 (read_objects, initial_obarray, oblookup_last_bucket_number):
6197 (make_symbol): Remove; unused.
6198 * lisp.h (initial_obarray, make_symbol): Remove decls.
6200 * keyboard.c: Make symbols static if they're not exported.
6201 (single_kboard, recent_keys_index, total_keys, recent_keys):
6202 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6203 (this_single_command_key_start, echoing, last_auto_save):
6204 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6205 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6206 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6207 (Vlispy_mouse_stem, double_click_count):
6209 (force_auto_save_soon): Define only if SIGDANGER.
6210 (ignore_mouse_drag_p): Now static if
6211 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6212 (print_help): Remove; unused.
6213 (stop_character, last_timer_event): Mark as externally visible.
6214 * keyboard.h (ignore_mouse_drag_p): Declare only if
6215 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6216 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6217 * lisp.h (echoing): Remove decl.
6218 (force_auto_save_soon): Declare only if SIGDANGER.
6219 * xdisp.c (redisplay_window): Simplify code, to make it more
6220 obvious that ignore_mouse_drag_p is not accessed if !defined
6221 USE_GTK && !defined HAVE_NS.
6223 * intervals.c: Make symbols static if they're not exported.
6224 (merge_properties_sticky, merge_interval_right, delete_interval):
6226 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6228 * insdel.c: Make symbols static if they're not exported.
6229 However, leave prepare_to_modify_buffer alone. It's never
6230 called from outside this function, but that appears to be a bug.
6231 (combine_after_change_list, combine_after_change_buffer):
6232 (adjust_after_replace, signal_before_change): Now static.
6233 (adjust_after_replace_noundo): Remove; unused.
6234 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
6235 (signal_before_change): Remove decls.
6237 * indent.c (val_compute_motion, val_vmotion): Now static.
6239 * image.c: Make symbols static if they're not exported.
6240 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6242 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6243 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6245 * fringe.c (standard_bitmaps): Now static.
6246 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6248 * frame.c: Make symbols static if they're not exported.
6249 (x_report_frame_params, make_terminal_frame): Now static.
6250 (get_frame_param): Now static, unless HAVE_NS.
6251 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6252 (x_get_resource_string): Remove; not used.
6253 * frame.h (make_terminal_frame, x_report_frame_params):
6254 (x_get_resource_string); Remove decls.
6255 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6256 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6258 * font.c, fontset.c: Make symbols static if they're not exported.
6259 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6260 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6261 * font.c (font_close_object): Now static.
6262 * font.h (font_close_object): Remove.
6263 * fontset.c (FONTSET_OBJLIST): Remove.
6264 (free_realized_fontset) #if-0 the body, which does nothing.
6265 (face_suitable_for_char_p): #if-0, as it's never called.
6266 * fontset.h (face_suitable_for_char_p): Remove decl.
6267 * xfaces.c (face_at_string_position):
6268 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
6269 since 0 is always ASCII.
6271 * fns.c (weak_hash_tables): Now static.
6273 * fileio.c: Make symbols static if they're not exported.
6274 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6275 (Vwrite_region_annotation_buffers): Now static.
6277 * eval.c: Make symbols static if they're not exported.
6278 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6279 * lisp.h (backtrace_list): Remove decl.
6281 * emacs.c: Make symbols static if they're not exported.
6282 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6283 (fatal_error_code, fatal_error_signal_hook, standard_args):
6285 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6286 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6287 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6288 * lisp.h (fatal_error_signal_hook): Remove decl.
6289 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6291 * editfns.c: Move a (normally-unused) function to its only use.
6292 * editfns.c, lisp.h (get_operating_system_release): Remove.
6293 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6294 worth the hassle of breaking this out.
6296 * xterm.c: Make symbols static if they're not exported.
6297 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6298 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6299 (x_destroy_window, x_delete_display):
6301 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6302 (x_mouse_leave): Remove; unused.
6303 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6304 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6305 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6307 (x_mouse_leave): Declare only if WINDOWSNT.
6308 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6309 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6312 * ftxfont.c: Make symbols static if they're not exported.
6313 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6315 * font.h (ftxfont_driver): Likewise.
6317 * xfns.c: Make symbols static if they're not exported.
6318 (x_last_font_name, x_display_info_for_name):
6319 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6320 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6321 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6322 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6323 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6324 (last_show_tip_args): Now static.
6325 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6326 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6327 (x_screen_planes): Remove; unused.
6328 * dispextern.h (x_screen_planes): Remove decl.
6330 * dispnew.c: Make symbols static if they're not exported.
6331 * dispextern.h (redraw_garbaged_frames, scrolling):
6332 (increment_row_positions): Remove.
6333 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6334 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6336 (redraw_garbaged_frames): Remove; unused.
6338 * xfaces.c: Make symbols static if they're not exported.
6339 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6341 * xterm.h (defined_color): Remove decls.
6342 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6343 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6344 (menu_face_changed_default, defined_color, free_realized_face):
6345 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6346 (ascii_face_of_lisp_face): Remove; unused.
6348 * xdisp.c: Make symbols static if they're not exported.
6349 * dispextern.h (scratch_glyph_row, window_box_edges):
6350 (glyph_to_pixel_coords, set_cursor_from_row):
6351 (get_next_display_element, set_iterator_to_next):
6352 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6353 (show_mouse_face): Remove decls
6354 * frame.h (message_buf_print): Likewise.
6355 * lisp.h (pop_message, set_message, check_point_in_composition):
6357 * xterm.h (set_vertical_scroll_bar): Likewise.
6358 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6359 (message_buf_print, scratch_glyph_row, displayed_buffer):
6360 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6361 (get_next_display_element, show_mouse_face, window_box_edges):
6362 (frame_to_window_pixel_xy, check_point_in_composition):
6363 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6364 (glyph_to_pixel_coords): Remove; unused.
6366 * dired.c (file_name_completion): Now static.
6368 * dbusbind.c (xd_in_read_queued_messages): Now static.
6370 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6371 * data.c (circular_list_error): Remove.
6373 * commands.h (last_point_position, last_point_position_buffer):
6374 (last_point_position_window): Remove decls.
6375 * keyboard.c: Make these variables static.
6377 * coding.h (coding, code_convert_region, encode_coding_gap):
6379 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6380 (iso_code_class, detect_coding, code_convert_region): Now static.
6381 (encode_coding_gap): Remove; unused.
6383 * chartab.c (chartab_chars, chartab_bits): Now static.
6385 * charset.h (charset_iso_8859_1): Remove decl.
6386 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6389 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6390 * ccl.c (Vccl_program_table): Now static.
6391 (check_ccl_update): Remove; unused.
6393 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6394 * category.h: ... from here.
6395 * category.c (check_category_table, set_category_set): Now static.
6397 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6398 * lisp.h: Remove these decls.
6400 * buffer.c (buffer_count): Remove unused var.
6402 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6403 so that it's not optimized away.
6404 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6405 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6406 exported only to the debugger.
6408 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
6409 * atimer.h (run_all_atimers): Remove; not exported.
6411 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6412 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6413 was inaccessible from Lisp.
6414 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6415 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6417 alloc.c: Import and export fewer symbols, and remove unused items.
6418 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6420 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6421 it's not optimized away by whole-program optimization.
6422 (message_enable_multibyte, free_misc): Remove.
6423 (catchlist, handlerlist, mark_backtrace):
6424 Declare only if BYTE_MARK_STACK.
6425 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6426 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6427 (message_enable_multibyte): Remove decl.
6428 (free_misc, interval_free_list, float_block, float_block_index):
6429 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6430 (cons_free_list, last_marked_index):
6432 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6433 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6434 (mark_backtrace): Define only if BYTE_MARK_STACK.
6435 * xdisp.c (message_enable_multibyte): Now static.
6437 Declare Lisp_Object Q* variables to be 'static' if not exported.
6438 This makes it easier for human readers (and static analyzers)
6439 to see whether these variables are used from other modules.
6440 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6441 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6442 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6443 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6444 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6445 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6446 * xmenu.c, xselect.c:
6447 Declare Q* vars static if they are not used in other modules.
6448 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6449 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6450 Remove decls of unexported vars.
6451 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6453 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6455 Make Emacs functions such as Fatom 'static' by default.
6456 This makes it easier for human readers (and static analyzers)
6457 to see whether these functions can be called from other modules.
6458 DEFUN now defines a static function. To make the function external
6459 so that it can be used in other C modules, use the new macro DEFUE.
6460 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6461 (Finit_image_library):
6462 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6463 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6464 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6465 Remove decls, since these functions are now static.
6466 (Funintern, Fget_internal_run_time): New decls, since these functions
6467 were already external.
6469 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6470 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6471 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6472 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6473 * keyboard.c, keymap.c, lread.c:
6474 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6475 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6476 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6477 Mark functions with DEFUE instead of DEFUN,
6478 if they are used in other modules.
6479 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6480 decls for now-static functions.
6481 * buffer.h (Fdelete_overlay): Remove decl.
6482 * callproc.c (Fgetenv_internal): Mark as internal.
6483 * composite.c (Fremove_list_of_text_properties): Remove decl.
6484 (Fcomposition_get_gstring): New forward static decl.
6485 * composite.h (Fcomposite_get_gstring): Remove decl.
6486 * dired.c (Ffile_attributes): New forward static decl.
6487 * doc.c (Fdocumntation_property): New forward static decl.
6488 * eval.c (Ffetch_bytecode): New forward static decl.
6489 (Funintern): Remove extern decl; now in .h file where it belongs.
6490 * fileio.c (Fmake_symbolic_link): New forward static decl.
6491 * image.c (Finit_image_library): New forward static decl.
6492 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6493 * intervals.h (Fprevious_property_change):
6494 (Fremove_list_of_text_properties): Remove decls.
6495 * keyboard.c (Fthis_command_keys): Remove decl.
6496 (Fcommand_execute): New forward static decl.
6497 * keymap.c (Flookup_key): New forward static decl.
6498 (Fcopy_keymap): Now static.
6499 * keymap.h (Flookup_key): Remove decl.
6500 * process.c (Fget_process): New forward static decl.
6501 (Fprocess_datagram_address): Mark as internal.
6502 * syntax.c (Fsyntax_table_p): New forward static decl.
6503 (skip_chars): Remove duplicate decl.
6504 * textprop.c (Fprevious_property_change): New forward static decl.
6505 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6507 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6508 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6510 * editfns.c (Fformat): Remove unreachable code.
6512 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6514 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6517 2011-04-13 Eli Zaretskii <eliz@gnu.org>
6519 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6520 when at ZV. (Bug#8487)
6522 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6524 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6526 * keyboard.c (parse_tool_bar_item): Likewise.
6527 * sound.c (sound_cleanup, alsa_close): Likewise.
6528 * termcap.c (tgetent): Likewise.
6529 * xfns.c (x_default_font_parameter): Likewise.
6530 * xsettings.c (read_and_apply_settings): Likewise.
6532 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6533 (overrun_check_free): Protoize.
6535 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6537 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6538 since callers should never pass a negative size.
6539 Change the signature to match that of plain 'read' and 'write'; see
6540 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6541 * lisp.h: Update prototypes of emacs_write and emacs_read.
6543 2011-04-11 Eli Zaretskii <eliz@gnu.org>
6545 * xdisp.c (redisplay_window): Don't try to determine the character
6546 position of the scroll margin if the window start point w->startp
6547 is outside the buffer's accessible region. (Bug#8468)
6549 2011-04-10 Eli Zaretskii <eliz@gnu.org>
6551 Fix write-region and its subroutines for buffers > 2GB.
6552 * fileio.c (a_write, e_write): Modify declaration of arguments and
6553 local variables to support buffers larger than 2GB.
6554 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6556 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6557 argument, local variables, and return value.
6559 * lisp.h: Update prototypes of emacs_write and emacs_read.
6561 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6563 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
6565 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6567 Fix more problems found by GCC 4.6.0's static checks.
6569 * xdisp.c (vmessage): Use a better test for character truncation.
6571 * charset.c (load_charset_map): <, not <=, for optimization,
6572 and to avoid potential problems with integer overflow.
6573 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
6574 * casetab.c (set_identity, shuffle): Likewise.
6575 * editfns.c (Fformat): Likewise.
6576 * syntax.c (skip_chars): Likewise.
6578 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6579 This also lets GCC 4.6.0 generate slightly better loop code.
6581 * callint.c (Fcall_interactively): <, not <=, for optimization.
6582 (Fcall_interactively): Count the number of arguments produced,
6583 not the number of arguments given. This is simpler and lets GCC
6584 4.6.0 generate slightly better code.
6586 * ftfont.c: Distingish more carefully between FcChar8 and char.
6587 The previous code passed unsigned char * to a functions like
6588 strlen and xstrcasecmp that expect char *, which does not
6589 conform to the C standard.
6590 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6591 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6592 char * when the C standard requires it.
6594 * keyboard.c (read_char): Remove unused var.
6596 * eval.c: Port to Windows vsnprintf (Bug#8435).
6598 (SIZE_MAX): Define if the headers do not.
6599 (verror): Do not give up if vsnprintf returns a negative count.
6600 Instead, grow the buffer. This ports to Windows vsnprintf, which
6601 does not conform to C99. Problem reported by Eli Zaretskii.
6602 Also, simplify the allocation scheme, by avoiding the need for
6603 calling realloc, and removing the ALLOCATED variable.
6605 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6607 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6608 But keep the doprint source code for now, as we might revamp it
6609 and use it again (Bug#8435).
6610 * lisp.h (doprnt): Remove.
6611 * Makefile.in (base_obj): Remove doprnt.o.
6612 * deps.mk (doprnt.o): Remove.
6614 error: Print 32- and 64-bit integers portably (Bug#8435).
6615 Without this change, on typical 64-bit hosts error ("...%d...", N)
6616 was used to print both 32- and 64-bit integers N, which relied on
6618 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6620 * lisp.h (error, verror): Mark as printf-like functions.
6621 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6622 Report overflow in size calculations when allocating printf buffer.
6623 Do not truncate output string at its first null byte.
6624 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6625 Truncate the output at a character boundary, since vsnprintf does not
6627 * charset.c (check_iso_charset_parameter): Convert internal
6628 character to string before calling 'error', since %c now has the
6630 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6631 overflow when computing char to be passed to 'error'. Do not
6632 pass Lisp_Object to 'error'; pass the integer instead.
6633 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6634 formatted with plain %d.
6636 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6638 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6640 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6642 * xterm.c (x_catch_errors): Remove duplicate declaration.
6644 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6646 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6648 2011-04-10 Jim Meyering <meyering@redhat.com>
6650 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6651 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6652 return ssize_t not "int", and use size_t as the buffer length.
6653 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6654 * gnutls.h: Update declarations.
6655 * process.c (read_process_output): Use ssize_t, to match.
6656 (send_process): Likewise.
6658 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6660 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6662 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6664 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6665 Use unsigned char, to match FcChar8 type definition.
6667 * xterm.c (handle_one_xevent):
6668 * xmenu.c (create_and_show_popup_menu):
6669 * xselect.c (x_decline_selection_request)
6670 (x_reply_selection_request): Avoid type-punned deref of X events.
6672 2011-04-09 Eli Zaretskii <eliz@gnu.org>
6674 Fix some uses of `int' instead of EMACS_INT.
6675 * search.c (string_match_1, fast_string_match)
6676 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6677 (scan_buffer, find_next_newline_no_quit)
6678 (find_before_next_newline, search_command, Freplace_match)
6679 (Fmatch_data): Make some `int' variables be EMACS_INT.
6681 * xdisp.c (display_count_lines): 3rd argument and return value now
6682 EMACS_INT. All callers changed.
6683 (pint2hrstr): Last argument is now EMACS_INT.
6685 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6686 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6687 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6688 (decode_coding_utf_16, decode_coding_emacs_mule)
6689 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6690 (decode_coding_ccl, decode_coding_charset)
6691 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6692 (decode_coding_iso_2022, decode_coding_emacs_mule)
6693 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6694 <char_offset, last_offset>: Declare EMACS_INT.
6695 (encode_coding_utf_8, encode_coding_utf_16)
6696 (encode_coding_emacs_mule, encode_invocation_designation)
6697 (encode_designation_at_bol, encode_coding_iso_2022)
6698 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6699 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6701 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6702 (encode_invocation_designation): Last argument P_NCHARS is now
6704 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6705 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6707 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6710 * ccl.c (Fccl_execute_on_string): Declare some variables
6713 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
6715 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6717 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6719 * process.c (Fformat_network_address): Doc fix.
6721 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6723 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6725 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
6727 * keyboard.c (read_char): Call Lisp function help-form-show,
6728 instead of using internal_with_output_to_temp_buffer.
6729 (Qhelp_form_show): New var.
6730 (syms_of_keyboard): Use DEFSYM macro.
6732 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6734 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6736 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
6738 * process.c (Flist_processes): Remove to Lisp.
6739 (list_processes_1): Delete.
6741 2011-04-06 Eli Zaretskii <eliz@gnu.org>
6743 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6745 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6747 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
6749 Fix more problems found by GCC 4.6.0's static checks.
6751 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6753 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6755 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
6757 * xdisp.c (vmessage): Mark as a printf-like function.
6759 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6761 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6763 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6764 printf-like functions.
6765 (tiff_load): Add casts to remove these marks before passing them
6766 to system-supplied API.
6768 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6770 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6771 This avoids several warnings with gcc -Wstrict-overflow.
6772 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6773 directly, rather than having caller test rule sign. This avoids
6774 some unnecessary tests.
6775 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6776 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6777 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
6779 * xfont.c (xfont_text_extents): Remove var that was set but not used.
6780 (xfont_open): Avoid unnecessary tests.
6782 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6784 * composite.h, composite.c (composition_gstring_put_cache):
6785 Use EMACS_INT, not int, for length.
6787 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6788 breaking out part of COMPOSITION_DECODE_RULE.
6789 (COMPOSITION_DECODE_RULE): Use it.
6790 * composite.c (get_composition_id): Remove unused local vars,
6791 by using the new macro.
6793 * textprop.c (set_text_properties_1): Change while to do-while,
6794 since the condition is always true at first.
6796 * intervals.c (graft_intervals_into_buffer): Mark var as used.
6797 (interval_deletion_adjustment): Return unsigned value.
6800 * process.c (list_processes_1, create_pty, read_process_output):
6801 (exec_sentinel): Remove vars that were set but not used.
6802 (create_pty): Remove unnecessary "volatile"s.
6803 (Fnetwork_interface_info): Avoid possibility of int overflow.
6804 (read_process_output): Do adaptive read buffering even if carryover.
6805 (read_process_output): Simplify nbytes computation if buffered.
6807 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6809 * syntax.c (scan_words): Remove var that was set but not used.
6810 (update_syntax_table): Use unsigned instead of int.
6812 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
6813 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
6814 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
6816 * print.c (print_error_message): Avoid int overflow.
6818 * font.c (font_list_entities): Redo for clarity,
6819 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6821 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
6822 (font_score): Avoid potential overflow in diff calculation.
6824 * fns.c (substring_both): Remove var that is set but not used.
6825 (sxhash): Redo loop for clarity and to avoid wraparound warning.
6827 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6829 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6830 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6831 can always succeed if overflow has undefined behavior.
6833 * search.c (boyer_moore, wordify): Remove vars set but not used.
6834 (wordify): Omit three unnecessary tests.
6836 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6837 All callers changed. This avoids the need for an unused var.
6839 * casefiddle.c (casify_region): Remove var that is set but not used.
6841 * dired.c (file_name_completion): Remove var that is set but not used.
6843 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6845 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
6846 (Finsert_file_contents): Remove unnecessary code checking fd.
6848 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6849 Check for integer overflow on size calculations.
6851 * buffer.c (Fprevious_overlay_change): Remove var that is set
6854 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6855 Remove vars that are set but not used.
6856 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6857 (timer_check_2): Mark vars as initialized.
6859 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6861 * image.c (lookup_image): Remove var that is set but not used.
6862 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
6864 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6865 that are set but not used.
6867 * xfns.c (make_invisible_cursor): Don't return garbage
6868 if XCreateBitmapFromData fails (Bug#8410).
6870 * xselect.c (x_get_local_selection, x_handle_property_notify):
6871 Remove vars that are set but not used.
6873 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6874 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
6876 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6877 Remove var that is set but not used.
6878 (scroll_bar_windows_size): Now size_t, not int.
6879 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6882 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6883 (map_tty_color) [!defined MSDOS]: Likewise.
6885 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6887 * coding.c: Remove vars that are set but not used.
6888 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6889 All callers changed.
6890 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6891 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6892 (decode_coding_charset): Remove vars that are set but not used.
6894 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6895 that is set but not used.
6897 * print.c (print_object): Remove var that is set but not used.
6899 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
6900 The gnulib version avoids calling malloc in the usual case,
6901 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6902 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6903 * filelock.c (current_lock_owner): Likewise.
6904 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6905 * sysdep.c: Include allocator.h, careadlinkat.h.
6906 (emacs_no_realloc_allocator): New static constant.
6907 (emacs_readlink): New function.
6908 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6909 ../lib/careadlinkat.h.
6911 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6913 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6914 first non-nil return value).
6916 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6918 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6919 if not defined (Bug#8403).
6921 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6923 * xdisp.c (display_count_lines): Remove parameter `start',
6924 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6925 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6926 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6927 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6928 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6929 and thereabouts. All callers changed.
6930 (get_per_char_metric): Remove parameter `f', unused since
6931 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6933 2011-04-02 Jim Meyering <meyering@redhat.com>
6935 do not dereference NULL upon failed strdup
6936 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6937 (ns_get_family): Likewise.
6939 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6941 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6943 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6945 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6948 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6950 Add lexical binding.
6952 * window.c (Ftemp_output_buffer_show): New fun.
6953 (Fsave_window_excursion):
6954 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6956 * lread.c (lisp_file_lexically_bound_p): New function.
6957 (Fload): Bind Qlexical_binding.
6958 (readevalloop): Remove `evalfun' arg.
6959 Bind Qinternal_interpreter_environment.
6960 (Feval_buffer): Bind Qlexical_binding.
6961 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6963 (syms_of_lread): Declare `lexical-binding'.
6965 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6967 * keyboard.c (eval_dyn): New fun.
6968 (menu_item_eval_property): Use it.
6970 * image.c (parse_image_spec): Use Ffunctionp.
6972 * fns.c (concat, mapcar1): Accept byte-code-functions.
6974 * eval.c (Fsetq): Handle lexical vars.
6975 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6976 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6977 (FletX, Flet): Obey lexical binding.
6978 (Fcommandp): Handle closures.
6979 (Feval): New `lexical' arg.
6980 (eval_sub): New function extracted from Feval. Use it almost
6981 everywhere where Feval was used. Look up vars in lexical env.
6983 (Ffunctionp): Move from subr.el.
6984 (Ffuncall): Handle closures.
6985 (apply_lambda): Remove `eval_flags'.
6986 (funcall_lambda): Handle closures and new byte-code-functions.
6987 (Fspecial_variable_p): New function.
6988 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6989 but without exporting it to Lisp.
6991 * doc.c (Fdocumentation, store_function_docstring):
6992 * data.c (Finteractive_form): Handle closures.
6994 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6997 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6999 (exec_byte_code): New function extracted from Fbyte_code to handle new
7000 calling convention for byte-code-functions. Add new byte-codes.
7002 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
7004 * alloc.c (Fmake_symbol): Init new `declared_special' field.
7006 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7008 * xdisp.c (redisplay_internal): Fix prototype.
7010 2011-03-31 Eli Zaretskii <eliz@gnu.org>
7012 * xdisp.c (SCROLL_LIMIT): New macro.
7013 (try_scrolling): Use it when setting scroll_limit.
7014 Limit scrolling to 100 screen lines.
7015 (redisplay_window): Even when falling back on "recentering",
7016 position point in the window according to scroll-conservatively,
7017 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7019 (try_scrolling): When point is above the window, allow searching
7020 as far as scroll_max, or one screenful, to compute vertical
7021 distance from PT to the scroll margin position. This prevents
7022 try_scrolling from unnecessarily failing when
7023 scroll-conservatively is set to a value slightly larger than the
7024 window height. Clean up the case of PT below the margin at bottom
7025 of window: scroll_max can no longer be INT_MAX. When aggressive
7026 scrolling is in use, don't let point enter the opposite scroll
7027 margin as result of the scroll.
7028 (syms_of_xdisp) <scroll-conservatively>: Document the
7029 threshold of 100 lines for never-recentering scrolling.
7031 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7033 * dispextern.h (move_it_by_lines):
7034 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7035 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7036 (message_log_check_duplicate): Remove parameters `prev_bol' and
7037 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7038 (redisplay_internal): Remove parameter `preserve_echo_area',
7039 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7041 * indent.c (Fvertical_motion):
7042 * window.c (window_scroll_pixel_based, Frecenter):
7043 Don't pass `need_y_p' to `move_it_by_lines'.
7045 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7047 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7048 steal a few bits to be more compact.
7049 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7050 Remove unneeded casts.
7052 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7054 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7056 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7057 binding" message (bug#7967).
7059 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7061 Fix more problems found by GCC 4.6.0's static checks.
7063 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7064 Remove unused local var.
7066 * editfns.c (Fmessage_box): Remove unused local var.
7068 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7069 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7070 Omit unused local vars.
7071 * window.c (shrink_windows): Omit unused local var.
7072 * menu.c (digest_single_submenu): Omit unused local var.
7073 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7074 Omit unused local var.
7076 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7077 Don't assume string length fits in int.
7078 (keyremap_step, read_key_sequence): Use size_t for sizes.
7079 (read_key_sequence): Don't check last_real_key_start redundantly.
7081 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7082 instead of alloca (Bug#8344).
7084 * eval.c (Fbacktrace): Don't assume nargs fits in int.
7085 (Fbacktrace_frame): Don't assume nframes fits in int.
7087 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7089 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7092 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7094 * cm.c (calccost): Turn while-do into do-while, for clarity.
7096 * keyboard.c (syms_of_keyboard): Use the same style as later
7097 in this function when indexing through an array. This also
7098 works around GCC bug 48267.
7100 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7102 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7104 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7105 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7107 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7108 This avoids undefined behavior on integer overflow, and is a bit
7109 more convenient anyway since it is compared to a size_t variable.
7111 Variadic C functions now count arguments with size_t, not int.
7112 This avoids an unnecessary limitation on 64-bit machines, which
7113 caused (substring ...) to crash on large vectors (Bug#8344).
7114 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7115 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
7116 All variadic functions and their callers changed accordingly.
7117 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7118 * data.c (arith_driver, float_arith_driver): Likewise.
7119 * editfns.c (general_insert_function): Likewise.
7120 * eval.c (struct backtrace.nargs, interactive_p)
7121 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7122 (funcall_lambda, mark_backtrace): Likewise.
7123 * fns.c (concat): Likewise.
7124 * frame.c (x_set_frame_parameters): Likewise.
7125 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7126 0 if not found, not -1. All callers changed.
7128 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7129 (stack_copy_size): Now size_t, not int.
7130 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7132 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
7134 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7135 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7136 All callers changed.
7138 * lisp.h (multibyte_char_to_unibyte):
7139 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7140 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7141 * character.h (CHAR_TO_BYTE8):
7142 * cmds.c (internal_self_insert):
7143 * editfns.c (general_insert_function):
7144 * keymap.c (push_key_description):
7145 * search.c (Freplace_match):
7146 * xdisp.c (message_dolog, set_message_1): All callers changed.
7148 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7150 * keyboard.c (safe_run_hook_funcall): New function.
7151 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7152 don't set the hook to nil, but remove the offending function instead.
7153 (Qcommand_hook_internal): Remove, unused.
7154 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7155 Vcommand_hook_internal.
7157 * eval.c (enum run_hooks_condition): Remove.
7158 (funcall_nil, funcall_not): New functions.
7159 (run_hook_with_args): Call each function through a `funcall' argument.
7160 Remove `cond' argument, now redundant.
7161 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7162 (Frun_hook_with_args_until_failure): Adjust accordingly.
7163 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7165 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
7167 * dispextern.h (string_buffer_position): Remove declaration.
7169 * print.c (strout): Remove parameter `multibyte', unused since
7170 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7172 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7173 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7174 All callers changed.
7176 * w32.c (_wsa_errlist): Use braces for struct initializers.
7178 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7179 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7180 All callers changed.
7181 (string_buffer_position): Likewise. Also, make static (it's never
7182 used outside xdisp.c).
7183 (cursor_row_p): Remove parameter `w', unused since
7184 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7185 (decode_mode_spec): Remove parameter `precision', introduced during
7186 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7187 All callers changed.
7189 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7191 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7193 2011-03-27 Anders Lindgren <andlind@gmail.com>
7195 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7196 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7197 (ns_update_auto_hide_menu_bar): New functions.
7198 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7199 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7200 ns_constrain_all_frames.
7201 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7202 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7204 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7206 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7208 2011-03-27 Glenn Morris <rgm@gnu.org>
7210 * syssignal.h: Replace RETSIGTYPE with void.
7211 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7212 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7213 Replace SIGTYPE with void everywhere.
7214 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7215 * s/template.h (SIGTYPE): Remove commented out definition.
7217 2011-03-26 Eli Zaretskii <eliz@gnu.org>
7219 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7220 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7222 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
7224 * w32.c (read_unc_volume): Use parameter `henum', instead of
7225 global variable `wget_enum_handle'.
7227 * keymap.c (describe_vector): Remove parameters `indices' and
7228 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7229 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7231 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7233 * keyboard.c (timer_check): Remove parameter `do_it_now',
7234 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7235 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7236 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7238 * keyboard.c (read_char):
7239 * w32menu.c (w32_menu_display_help):
7240 * xmenu.c (show_help_event, menu_help_callback):
7241 Adjust calls to `show_help_echo'.
7243 * gtkutil.c (xg_maybe_add_timer):
7244 * keyboard.c (readable_events):
7245 * process.c (wait_reading_process_output):
7246 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7248 * insdel.c (adjust_markers_gap_motion):
7249 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7250 (gap_left, gap_right): Don't call it.
7252 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
7254 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7255 incurred during fontification.
7257 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
7259 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7260 (DEFVAR_PER_BUFFER): Don't pass it.
7262 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7263 (scrolling_window): Don't pass it.
7265 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
7267 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7269 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7271 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7272 of variables specific to SELinux and computation of `encoded_absname'.
7274 * image.c (XPutPixel): Remove unused variable `height'.
7276 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7278 * unexw32.c (get_section_info): Remove unused variable `section'.
7280 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7281 (system_process_attributes): Remove unused variable `sess'.
7282 (sys_read): Remove unused variable `err'.
7284 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7285 (w32_wnd_proc): Remove unused variable `isdead'.
7286 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7287 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7288 (x_create_tip_frame): Remove unused variable `tem'.
7290 * w32inevt.c (w32_console_read_socket):
7291 Remove unused variable `no_events'.
7293 * w32term.c (x_draw_composite_glyph_string_foreground):
7294 Remove unused variable `width'.
7296 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
7298 * w32term.c (x_set_glyph_string_clipping):
7299 Don't pass uninitialized region to CombineRgn.
7301 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
7303 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7304 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7305 (Fx_close_connection): Remove unused variable `i'.
7307 * w32font.c (w32font_draw): Return number of glyphs.
7308 (w32font_open_internal): Remove unused variable `i'.
7309 (w32font_driver): Add missing initializer.
7311 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7312 (fill_in_menu): Remove unused variable `items_added'.
7314 * w32term.c (last_mouse_press_frame): Remove static global variable.
7315 (w32_clip_to_row): Remove unused variable `f'.
7316 (x_delete_terminal): Remove unused variable `i'.
7318 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7319 (NOTHING): Remove unused static global variable.
7320 (uniscribe_check_otf): Remove unused variable `table'.
7321 (uniscribe_font_driver): Add missing initializers.
7323 2011-03-23 Julien Danjou <julien@danjou.info>
7325 * term.c (Fsuspend_tty, Fresume_tty):
7326 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7327 * window.c (temp_output_buffer_show):
7328 * insdel.c (signal_before_change):
7329 * frame.c (Fhandle_switch_frame):
7330 * fileio.c (Fdo_auto_save):
7331 * emacs.c (Fkill_emacs):
7332 * editfns.c (save_excursion_restore):
7333 * cmds.c (internal_self_insert):
7334 * callint.c (Fcall_interactively):
7335 * buffer.c (Fkill_all_local_variables):
7336 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7338 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
7339 unconditionnaly since it does the check itself.
7341 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
7343 Fix more problems found by GCC 4.5.2's static checks.
7345 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7346 the first time through the loop, since we know p0 < p1 then.
7347 This also avoids a gcc -Wstrict-overflow warning.
7349 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7350 leading to a memory leak, possible in functions like
7351 load_charset_map_from_file that can allocate an unbounded number
7352 of objects (Bug#8318).
7354 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7355 that could (at least in theory) be that large.
7357 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7358 This is less likely to overflow, and avoids undefined behavior if
7359 overflow does occur. All callers changed. Use strtoul to scan
7360 for the unsigned long integer.
7361 (pint2hrstr): Simplify and tune code slightly.
7362 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
7364 * scroll.c (do_scrolling): Work around GCC bug 48228.
7365 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7367 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7368 This also avoids a warning with gcc -Wstrict-overflow.
7369 (validate_x_resource_name): Simplify count usage.
7370 This also avoids a warning with gcc -Wstrict-overflow.
7372 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7375 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
7377 * process.c (Fmake_network_process): Use socklen_t, not int,
7378 where POSIX says socklen_t is required in portable programs.
7379 This fixes a porting bug on hosts like 64-bit HP-UX, where
7380 socklen_t is wider than int (Bug#8277).
7381 (Fmake_network_process, server_accept_connection):
7382 (wait_reading_process_output, read_process_output):
7385 * process.c: Rename or move locals to avoid shadowing.
7386 (list_processes_1, Fmake_network_process):
7387 (read_process_output_error_handler, exec_sentinel_error_handler):
7388 Rename or move locals.
7389 (Fmake_network_process): Define label "retry_connect" only if needed.
7390 (Fnetwork_interface_info): Fix pointer signedness.
7391 (process_send_signal): Add cast to avoid pointer signedness problem.
7392 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
7393 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
7395 Make tparam.h and terminfo.c consistent.
7396 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7397 Include tparam.h instead, since it declares them.
7398 * cm.h (PC): Remove extern decl; tparam.h now does this.
7399 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7400 * terminfo.c: Include tparam.h, to check interfaces.
7401 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7402 (tparam): Adjust signature to match interface in tparam.h;
7403 this removes some undefined behavior. Check that outstring and len
7404 are zero, which they always are with Emacs.
7405 * tparam.h (PC, BC, UP): New extern decls.
7407 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
7408 (xftfont_open): Rename locals to avoid shadowing.
7410 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
7411 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7412 (OTF_TAG_SYM): Omit macro if not needed.
7413 (ftfont_list): Remove unused local.
7414 (get_adstyle_property, ftfont_pattern_entity):
7415 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7416 Rename locals to avoid shadowing.
7418 * xfont.c (xfont_list_family): Mark var as initialized.
7420 * xml.c (make_dom): Now static.
7422 * composite.c (composition_compute_stop_pos): Rename local to
7424 (composition_reseat_it): Remove unused locals.
7425 (find_automatic_composition, composition_adjust_point): Likewise.
7426 (composition_update_it): Mark var as initialized.
7427 (find_automatic_composition): Mark vars as initialized,
7428 with a FIXME (Bug#8290).
7430 character.h: Rename locals to avoid shadowing.
7431 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7432 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7433 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7434 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7437 * textprop.c (property_change_between_p): Remove; unused.
7439 * intervals.c (interval_start_pos): Now static.
7441 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7443 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7444 Rename locals to avoid shadowing.
7446 * sound.c (wav_play, au_play, Fplay_sound_internal):
7447 Fix pointer signedness.
7448 (alsa_choose_format): Remove unused local var.
7449 (wav_play): Initialize a variable to 0, to prevent undefined
7450 behavior (Bug#8278).
7452 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7454 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7456 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7457 clobbering (Bug#8298).
7458 * sysdep.c (sys_subshell): Likewise.
7459 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7461 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7462 This should get cleaned up, so that child_setup has the
7463 same signature on all platforms.
7465 * callproc.c (call_process_cleanup): Now static.
7466 (relocate_fd): Rename locals to avoid shadowing.
7468 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
7470 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7471 not to be necessary, and produces flickering.
7473 2011-03-20 Glenn Morris <rgm@gnu.org>
7475 * config.in: Remove file.
7477 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
7479 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7480 are now in src/globals.h.
7481 (syms_of_minibuf): Remove spurious & from previous change.
7483 2011-03-20 Leo <sdl.web@gmail.com>
7485 * minibuf.c (completing-read-function): New variable.
7486 (completing-read-default): Rename from completing-read.
7487 (completing-read): Call completing-read-function.
7489 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7491 * xfaces.c (Fx_load_color_file):
7492 Read color file from absolute filename (bug#8250).
7494 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7496 * makefile.w32-in: Update dependencies.
7498 2011-03-17 Eli Zaretskii <eliz@gnu.org>
7500 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7502 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7504 Fix more problems found by GCC 4.5.2's static checks.
7506 * process.c (make_serial_process_unwind, send_process_trap):
7507 (sigchld_handler): Now static.
7509 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7510 That way, the code declares only the vars that it needs.
7511 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7512 * s/cygwin.h (PTY_ITERATION): Likewise.
7513 * s/darwin.h (PTY_ITERATION): Likewise.
7514 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7516 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7517 * process.c (allocate_pty): Don't declare stb unless it's needed.
7519 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
7520 (CONSTANTLIM): Remove; unused.
7521 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7522 Define only if needed.
7524 * unexelf.c (unexec): Name an expression,
7525 to avoid gcc -Wbad-function-cast warning.
7526 Use a different way to cause a compilation error if anyone uses
7527 n rather than nn, a way that does not involve shadowing.
7528 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
7530 * deps.mk (unexalpha.o): Remove; unused.
7532 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7533 * unexec.h: New file.
7534 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7535 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7537 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7538 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7539 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
7540 Change as necessary to match prototype in unexec.h.
7542 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7544 (back_comment, skip_chars): Mark vars as initialized.
7546 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7547 Rename locals to avoid shadowing.
7549 * lread.c (read1): Rewrite so as not to use empty "else".
7550 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
7552 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7554 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7555 warning when compiling print.c.
7557 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7558 instead of using an uninitialized var.
7559 (font_sort_entities): Mark var as initialized.
7561 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7563 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7564 pointers to constants.
7565 (font_parse_fcname): Remove unused vars.
7566 (font_delete_unmatched): Now static.
7567 (font_get_spec): Remove; unused.
7568 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7569 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7570 Rename or move locals to avoid shadowing.
7572 * fns.c (require_nesting_list, require_unwind): Now static.
7573 (Ffillarray): Rename locals to avoid shadowing.
7575 * floatfns.c (domain_error2): Define only if needed.
7576 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
7578 * alloc.c (mark_backtrace): Move decl from here ...
7579 * lisp.h: ... to here, so that it can be checked.
7581 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
7582 (Fdefvar): Rewrite so as not to use empty "else".
7583 (lisp_indirect_variable): Name an expression,
7584 to avoid gcc -Wbad-function-cast warning.
7585 (Fdefvar): Rename locals to avoid shadowing.
7587 * callint.c (quotify_arg, quotify_args): Now static.
7588 (Fcall_interactively): Rename locals to avoid shadowing.
7589 Use const pointer when appropriate.
7591 * lisp.h (get_system_name, get_operating_system_release):
7592 Move decls here, to check interfaces.
7593 * process.c (get_operating_system_release): Move decl to lisp.h.
7594 * xrdb.c (get_system_name): Likewise.
7595 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7596 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7597 some of which prompt warnings from gcc -Wbad-function-cast.
7598 (Fformat_time_string, Fencode_time, Finsert_char):
7599 (Ftranslate_region_internal, Fformat):
7600 Rename or remove local vars to avoid shadowing.
7601 (Ftranslate_region_internal): Mark var as initialized.
7603 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7606 * lisp.h (eassert): Check that the argument compiles, even if
7607 ENABLE_CHECKING is not defined.
7609 * data.c (Findirect_variable): Name an expression, to avoid
7610 gcc -Wbad-function-cast warning.
7611 (default_value, arithcompare, arith_driver, arith_error): Now static.
7612 (store_symval_forwarding): Rename local to avoid shadowing.
7613 (Fmake_variable_buffer_local, Fmake_local_variable):
7614 Mark variables as initialized.
7615 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
7617 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
7618 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7619 Rename locals to avoid shadowing.
7620 (mark_stack): Move local variables into the #ifdef region where
7622 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7623 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7625 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7626 (GC_STRING_CHARS): Remove; not used.
7627 (Fmemory_limit): Cast sbrk's returned value to char *.
7629 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7630 avoids undefined behavior in theory.
7632 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7634 Use functions, not macros, for up- and down-casing (Bug#8254).
7635 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7636 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7637 to use the following functions instead of these macros.
7638 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7639 EMACS_INT, since callers assume the returned value fits in int.
7640 (upcase1): Likewise, for UPCASE_TABLE.
7641 (uppercasep, lowercasep, upcase): New static inline functions.
7642 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
7643 the race-condition problem in the old DOWNCASE.
7645 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7646 Rename locals to avoid shadowing.
7647 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
7648 (regex_compile, re_search_2, re_match_2_internal):
7649 Remove unused local vars.
7650 (FREE_VAR): Rewrite so as not to use empty "else",
7651 which gcc can warn about.
7652 (regex_compile, re_match_2_internal): Mark locals as initialized.
7653 (RETALLOC_IF): Define only if needed.
7654 (WORDCHAR_P): Likewise. This one is never needed, but is used
7655 only in a comment talking about a compiler bug, so put inside
7656 the #if 0 of that comment.
7657 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7658 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7661 * search.c (boyer_moore): Rename locals to avoid shadowing.
7662 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7663 (PREV_CHAR_BOUNDARY): Likewise.
7665 * search.c (simple_search): Remove unused var.
7667 * dired.c (compile_pattern): Move decl from here ...
7668 * lisp.h: ... to here, so that it can be checked.
7669 (struct re_registers): New forward decl.
7671 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7673 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7675 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7676 Rename locals to avoid shadowing.
7677 (Fvertical_motion): Mark locals as initialized.
7679 * casefiddle.c (casify_object, casify_region): Now static.
7680 (casify_region): Mark local as initialized.
7682 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7684 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7685 New macros, so that the caller can use some names other than
7686 gcpro1, gcpro2, etc.
7687 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7689 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7690 argument, for consistency with GCPRO2_VAR, etc: it is now the
7691 prefix of the variable, not the variable itself. All uses
7693 * dired.c (directory_files_internal, file_name_completion):
7694 Rename locals to avoid shadowing.
7696 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7697 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7698 dired.c's scmp function, had undefined behavior.
7699 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7700 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7701 * buffer.h: ... to here, because these macros use current_buffer,
7702 and the new implementation with inline functions needs to have
7703 current_buffer in scope now, rather than later when the macros
7705 (downcase, upcase1): New static inline functions.
7706 (DOWNCASE, UPCASE1): Reimplement using these functions.
7707 This avoids undefined behavior in expressions like
7708 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7709 from race conditions in accessing the global variables
7710 case_temp1 and case_temp2.
7711 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7712 * lisp.h (case_temp1, case_temp2): Remove their decls.
7713 * character.h (ASCII_CHAR_P): Move from here ...
7714 * lisp.h: ... to here, so that the inline functions mentioned
7717 * dired.c (directory_files_internal_unwind): Now static.
7719 * fileio.c (file_name_as_directory, directory_file_name):
7720 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7722 (file_name_as_directory): Use const pointers when appropriate.
7723 (Fexpand_file_name): Likewise. In particular, newdir might
7724 point at constant storage, so make it a const pointer.
7725 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
7726 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7728 (Fset_file_times, Finsert_file_contents, auto_save_error):
7729 Rename locals to avoid shadowing.
7731 * minibuf.c (choose_minibuf_frame_1): Now static.
7732 (Ftry_completion, Fall_completions): Rename or remove locals
7735 * marker.c (bytepos_to_charpos): Remove; unused.
7737 * lisp.h (verify_bytepos, count_markers): New decls,
7738 so that gcc does not warn that these functions aren't declared.
7740 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7741 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
7742 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
7743 (copy_text): Remove unused local var.
7745 * filelock.c (within_one_second): Now static.
7746 (lock_file_1): Rename local to avoid shadowing.
7748 * buffer.c (fix_overlays_before): Mark locals as initialized.
7749 (fix_start_end_in_overlays): Likewise. This function should be
7750 simplified by using pointers-to-pointers, but that's a different
7752 (switch_to_buffer_1): Now static.
7753 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7754 (report_overlay_modification): Rename locals to avoid shadowing.
7756 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
7757 Fix pointer signedness issue.
7758 (sys_subshell): Mark local as volatile if checking for lint,
7759 to suppress a gcc -Wclobbered warning that does not seem to be right.
7760 (MAXPATHLEN): Define only if needed.
7762 * process.c (serial_open, serial_configure): Move decls from here ...
7763 * systty.h: ... to here, so that they can be checked.
7765 * fns.c (get_random, seed_random): Move extern decls from here ...
7766 * lisp.h: ... to here, so that they can be checked.
7768 * sysdep.c (reset_io): Now static.
7769 (wait_for_termination_signal): Remove; unused.
7771 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7772 (copy_keymap_item, append_key, push_text_char_description):
7774 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
7775 (DENSE_TABLE_SIZE): Remove; unused.
7776 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7777 (describe_map_tree):
7778 Rename locals to avoid shadowing.
7780 * keyboard.c: Declare functions static if they are not used elsewhere.
7781 (echo_char, echo_dash, cmd_error, top_level_2):
7782 (poll_for_input, handle_async_input): Now static.
7783 (read_char, kbd_buffer_get_event, make_lispy_position):
7784 (make_lispy_event, make_lispy_movement, apply_modifiers):
7785 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7786 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7787 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
7788 (read_key_sequence, read_char): Mark locals as initialized.
7789 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
7791 * keyboard.h (make_ctrl_char): New decl.
7792 (mark_kboards): Move decl here ...
7793 * alloc.c (mark_kboards): ... from here.
7795 * lisp.h (force_auto_save_soon): New decl.
7797 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
7798 (DEFINE_DUMMY_FUNCTION): New macro.
7799 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7801 (main): Add casts to avoid warnings
7802 if GCC considers string literals to be constants.
7804 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7806 * dbusbind.c: Pointer signedness fixes.
7807 (xd_signature, xd_append_arg, xd_initialize):
7808 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7809 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7810 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7811 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7813 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7814 if GCC considers string literals to be constants.
7815 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
7817 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7819 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7820 (print_preprocess, print_object): New macro to fix last change.
7822 * print.c (print_preprocess): Don't forget font objects.
7824 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
7826 * emacs.c (USAGE3): Doc fixes.
7828 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7830 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7833 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
7835 * lisp.h (VWindow_system, Qfile_name_history):
7836 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7837 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7838 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7840 * w32select.c: Don't #include "keyboard.h".
7841 (run_protected): Add extern declaration for waiting_for_input.
7843 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7844 * w32console.c (detect_input_pending, read_input_pending)
7845 (encode_terminal_code):
7846 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7847 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7848 (w32_system_caret_y, Qfile_name_history):
7849 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7850 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7851 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7852 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7853 * w32proc.c (Qlocal, report_file_error):
7854 * w32term.c (Vwindow_system, updating_frame):
7855 * w32uniscribe.c (initialized, uniscribe_font_driver):
7856 Remove unneeded extern declarations.
7858 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
7860 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
7862 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
7864 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7865 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7866 These macros can no longer be used for assignment.
7868 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7869 Assign struct members directly, instead of using BUF_BEGV etc.
7870 (record_buffer_markers, fetch_buffer_markers): New functions for
7871 recording and fetching special buffer markers.
7872 (set_buffer_internal_1, set_buffer_temp): Use them.
7874 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7876 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7878 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7879 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7881 * xdisp.c (hscroll_window_tree):
7882 (reconsider_clip_changes): Use PT instead of BUF_PT.
7884 2011-03-13 Eli Zaretskii <eliz@gnu.org>
7886 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7887 $(EMACS_ROOT)/lib/intprops.h.
7889 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7891 Fix more problems found by GCC 4.5.2's static checks.
7893 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7894 to unsigned char * to avoid compiler diagnostic.
7895 (xg_free_frame_widgets): Make it clear that a local variable is
7896 needed only if USE_GTK_TOOLTIP.
7897 (gdk_window_get_screen): Make it clear that this macro is needed
7898 only if USE_GTK_TOOLTIP.
7899 (int_gtk_range_get_value): New function, which avoids a diagnostic
7900 from gcc -Wbad-function-cast.
7901 (xg_set_toolkit_scroll_bar_thumb): Use it.
7902 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7903 diagnostic from gcc -Wbad-function-cast.
7904 (get_utf8_string, xg_get_file_with_chooser):
7905 Rename locals to avoid shadowing.
7906 (create_dialog): Move locals to avoid shadowing.
7908 * xgselect.c (xg_select): Remove unused var.
7910 * image.c (four_corners_best): Mark locals as initialized.
7911 (gif_load): Initialize transparent_p to zero (Bug#8238).
7912 Mark another local as initialized.
7913 (my_png_error, my_error_exit): Mark with NO_RETURN.
7915 * image.c (clear_image_cache): Now static.
7916 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
7917 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
7918 (x_edge_detection): Remove unnecessary cast that
7919 gcc -Wbad-function-cast diagnoses.
7920 (gif_load): Fix pointer signedness.
7921 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7922 (jpeg_load, gif_load): Rename locals to avoid shadowing.
7924 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
7926 Improve quality of tests for time stamp overflow.
7927 For example, without this patch (encode-time 0 0 0 1 1
7928 1152921504606846976) returns the obviously-bogus value (-948597
7929 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7930 reports time overflow. See
7931 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
7932 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7933 * editfns.c: Include limits.h and intprops.h.
7934 (TIME_T_MIN, TIME_T_MAX): New macros.
7935 (time_overflow): Move earlier, to before first use.
7936 (hi_time, lo_time): New functions, for an accurate test for
7938 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7939 (Fget_internal_run_time): Don't assume time_t fits in int.
7940 (make_time): Use list2 instead of Fcons twice.
7941 (Fdecode_time): More accurate test for out-of-range times.
7942 (check_tm_member): New function.
7943 (Fencode_time): Use it, to test for out-of-range times.
7944 (lisp_time_argument): Don't rely on undefined left-shift and
7945 right-shift behavior when checking for time stamp overflow.
7947 * editfns.c (time_overflow): New function, refactoring common code.
7948 (Fformat_time_string, Fdecode_time, Fencode_time):
7949 (Fcurrent_time_string): Use it.
7951 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7952 * dired.c (make_time): Move to ...
7953 * editfns.c (make_time): ... here.
7954 * systime.h: Note the move.
7956 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7958 * fringe.c (update_window_fringes): Remove unused variables.
7960 * unexmacosx.c (copy_data_segment): Also copy __got section.
7963 2011-03-12 Eli Zaretskii <eliz@gnu.org>
7965 * termcap.c [MSDOS]: Include "msdos.h".
7966 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7967 Constify `char *' arguments and their references according to
7968 prototypes in tparam.h.
7970 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
7972 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7973 Adapt all references accordingly.
7975 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7977 2011-03-11 Tom Tromey <tromey@redhat.com>
7979 * buffer.c (syms_of_buffer): Remove obsolete comment.
7981 2011-03-11 Eli Zaretskii <eliz@gnu.org>
7983 * termhooks.h (encode_terminal_code): Declare prototype.
7985 * msdos.c (encode_terminal_code): Don't declare prototype.
7987 * term.c (encode_terminal_code): Now external again, used by
7988 w32console.c and msdos.c.
7990 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7991 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7993 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
7995 Fix some minor problems found by GCC 4.5.2's static checks.
7997 * fringe.c (update_window_fringes): Mark locals as initialized
7999 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
8001 * alloc.c (mark_fringe_data): Move decl from here ...
8002 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8003 to check its interface.
8004 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8006 * fontset.c (free_realized_fontset): Now static.
8007 (Fset_fontset_font): Rename local to avoid shadowing.
8008 (fontset_font): Mark local as initialized.
8009 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
8011 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8013 * xselect.c (x_disown_buffer_selections): Remove; not used.
8014 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
8015 (x_own_selection, Fx_disown_selection_internal): Rename locals
8017 (x_handle_dnd_message): Remove local to avoid shadowing.
8019 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8020 so that the caller can use some name other than gcpro1.
8021 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
8022 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8023 (Fx_backspace_delete_keys_p):
8024 Use them to avoid shadowing, and rename vars to avoid shadowing.
8025 (x_decode_color, x_set_name, x_window): Now static.
8026 (Fx_create_frame): Add braces to silence GCC warning.
8027 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
8028 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8029 Remove unused locals.
8030 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8031 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8032 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8035 * xterm.h (x_mouse_leave): New decl.
8037 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8038 Remove unused functions.
8039 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8040 (x_calc_absolute_position): Now static.
8041 (XTread_socket): Don't define label "out" unless it's used.
8042 Don't declare local "event" unless it's used.
8043 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8044 unless they are used.
8045 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8046 (x_fatal_error_signal): Remove; not used.
8047 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8048 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8049 (x_error_catcher, x_connection_closed, x_error_handler):
8050 (x_error_quitter, xembed_send_message, x_iconify_frame):
8051 (my_log_handler): Rename locals to avoid shadowing.
8052 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
8053 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
8055 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8056 Rename or move locals to avoid shadowing.
8057 (tty_defined_color, merge_face_heights): Now static.
8058 (free_realized_faces_for_fontset): Remove; not used.
8059 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8060 does not deduce is never used uninitialized.
8061 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8062 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
8064 * terminal.c (store_terminal_param): Now static.
8066 * xmenu.c (menu_highlight_callback): Now static.
8067 (set_frame_menubar): Remove unused local.
8068 (xmenu_show): Rename parameter to avoid shadowing.
8069 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8070 since they might point to immutable storage.
8071 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8072 since it's unused otherwise.
8074 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
8075 Add a FIXME, since the code still doesn't look right. (Bug#8215)
8076 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8077 avoids a gcc -Wuninitialized diagnostic.
8078 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
8079 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8080 does not deduce are never used uninitialized.
8082 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8084 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
8085 * window.c (window_loop, size_window):
8086 (run_window_configuration_change_hook, enlarge_window): Likewise.
8088 * window.c (display_buffer): Now static.
8089 (size_window): Mark variables that gcc -Wuninitialized
8090 does not deduce are never used uninitialized.
8091 * window.h (check_all_windows): New decl, to forestall
8092 gcc -Wmissing-prototypes diagnostic.
8093 * dispextern.h (bidi_dump_cached_states): Likewise.
8095 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8097 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
8099 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8100 and to avoid gcc -Wuninitialized warning.
8101 (load_charset_map): Mark variables that gcc -Wuninitialized
8102 does not deduce are never used uninitialized.
8103 (load_charset): Abort instead of using uninitialized var (Bug#8229).
8105 * coding.c (coding_set_source, coding_set_destination):
8106 Use "else { /* comment */ }" rather than "else /* comment */;"
8107 for clarity, and to avoid gcc -Wempty-body warning.
8108 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8109 a block, when the outer 'i' will do.
8110 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8111 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8112 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8113 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8114 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8115 Rename locals to avoid shadowing.
8116 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
8117 * coding.c (emacs_mule_char, encode_invocation_designation):
8118 Now static, since they're not used elsewhere.
8119 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
8120 (decode_coding_object, encode_coding_object, detect_coding_system):
8121 (decode_coding_emacs_mule): Mark variables that gcc
8122 -Wuninitialized does not deduce are never used uninitialized.
8123 (detect_coding_iso_2022): Initialize a local variable that might
8124 be used uninitialized. Leave a FIXME because it's not clear that
8125 this initialization is needed. (Bug#8211)
8126 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8127 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8128 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8129 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8130 Remove unused macros.
8132 * category.c (hash_get_category_set): Remove unused local var.
8133 (copy_category_table): Now static, since it's not used elsewhere.
8134 * character.c (string_count_byte8): Likewise.
8136 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8137 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8139 * chartab.c (copy_sub_char_table): Now static, since it's not used
8141 (sub_char_table_ref_and_range, char_table_ref_and_range):
8142 Rename locals to avoid shadowing.
8143 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
8145 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
8146 (BIDI_BOB): Remove unused macro.
8148 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8149 deduce are never used uninitialized.
8150 * term.c (encode_terminal_code): Likewise.
8152 * term.c (encode_terminal_code): Now static. Remove unused local.
8154 * tparam.h: New file.
8155 * term.c, tparam.h: Include it.
8156 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8157 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8158 Move these decls to tparam.h, and make them agree with what
8159 is actually in tparam.c. The previous trick of using incompatible
8160 decls in different modules does not conform to the C standard.
8161 All callers of tparam changed to use tparam's actual API.
8162 * tparam.c (tparam1, tparam, tgoto):
8163 Use const pointers where appropriate.
8165 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8166 * cm.h (struct cm): Likewise.
8167 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8168 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8169 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8170 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8171 (turn_on_face, init_tty): Likewise.
8172 * termchar.h (struct tty_display_info): Likewise.
8174 * term.c (term_mouse_position): Rename local to avoid shadowing.
8176 * alloc.c (mark_ttys): Move decl from here ...
8177 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8179 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8181 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8183 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
8185 * search.c (compile_pattern_1): Remove argument regp, unused since
8186 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8187 (compile_pattern): Don't pass it.
8189 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8191 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8192 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8194 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8196 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8198 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8199 gdk_window_get_screen, gdk_window_get_geometry,
8200 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8201 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8202 (xg_get_pixbuf_from_pixmap): New function.
8203 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8204 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8205 Call xg_get_pixbuf_from_pixmap instead of
8206 gdk_pixbuf_get_from_drawable.
8207 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8208 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8209 (xg_check_special_colors): Use GtkStyleContext and its functions
8211 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8212 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8213 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
8214 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8215 Call gtk_widget_get_preferred_size.
8216 (xg_frame_resized): gdk_window_get_geometry only takes 5
8218 (xg_win_to_widget, xg_event_is_for_menubar):
8219 Call gdk_x11_window_lookup_for_display.
8220 (xg_set_widget_bg): New function.
8221 (delete_cb): New function.
8222 (xg_create_frame_widgets): Connect delete-event to delete_cb.
8223 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
8224 (xg_set_background_color): Call xg_set_widget_bg.
8225 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8226 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8227 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8228 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8230 (update_frame_tool_bar): Call gtk_widget_hide.
8231 (xg_initialize): Use GDK_KEY_g.
8233 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8235 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8237 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8238 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8239 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8241 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
8243 * w32xfns.c (select_palette): Check success of RealizePalette against
8244 GDI_ERROR, not zero.
8246 See ChangeLog.11 for earlier changes.
8252 Copyright (C) 2011 Free Software Foundation, Inc.
8254 This file is part of GNU Emacs.
8256 GNU Emacs is free software: you can redistribute it and/or modify
8257 it under the terms of the GNU General Public License as published by
8258 the Free Software Foundation, either version 3 of the License, or
8259 (at your option) any later version.
8261 GNU Emacs is distributed in the hope that it will be useful,
8262 but WITHOUT ANY WARRANTY; without even the implied warranty of
8263 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8264 GNU General Public License for more details.
8266 You should have received a copy of the GNU General Public License
8267 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.