1 2011-11-21 Chong Yidong <cyd@gnu.org>
3 * window.c (Fnext_window, Fprevious_window): Doc fix.
5 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
7 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
9 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
11 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
13 2011-11-20 Martin Rudalics <rudalics@gmx.at>
15 * window.c (Fset_window_combination_limit): Rename argument
17 (Vwindow_combination_limit): Remove "status" from doc-string.
19 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
21 * m/ibms390.h: Remove.
22 * m/ibms390x.h: Don't include "ibms390.h".
24 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
26 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
27 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
29 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
31 * casetab.c (Fset_case_table):
32 * charset.c (Fcharset_after): Fix typos.
34 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
36 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
37 Otherwise, valgrind does not work on some platforms.
38 Problem reported by Andreas Schwab in
39 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
40 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
41 is set, removing the need for VIRT_ADDRESS_VARIES.
42 (PURE_P): Use a more-efficient implementation that needs just one
43 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
44 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
45 to 4 (xorl, subq, cmpq, setbe).
46 * alloc.c (pure): Always extern now, since that's the
47 VIRT_ADDR_VARIES behavior.
48 (PURE_POINTER_P): Use a single comparison, not two, for
49 consistency with the new puresize.h.
50 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
51 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
52 Remove VIRT_ADDR_VARIES no longer needed.
54 2011-11-19 Eli Zaretskii <eliz@gnu.org>
56 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
57 (erase_phys_cursor, update_window_cursor, show_mouse_face)
58 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
59 behave as if the cursor position were at the window margin.
61 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
62 and the cursor position is out of bounds, behave as if the cursor
63 position were at the window margin. (Bug#10075)
65 2011-11-18 Chong Yidong <cyd@gnu.org>
67 * window.c (Fwindow_combination_limit): Make first argument
68 non-optional, since it is meaningless for live windows like the
71 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
73 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
75 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
77 * intervals.c: Fix grafting over the whole buffer (bug#10071).
78 (graft_intervals_into_buffer): Simplify.
80 2011-11-18 Eli Zaretskii <eliz@gnu.org>
82 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
83 hash values of the two rows.
84 (copy_row_except_pointers): Preserve the used[] arrays and the
85 hash values of the two rows. (Bug#10035)
86 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
88 * xdisp.c (row_hash): New function, body extracted from
90 (compute_line_metrics): Call row_hash, instead of computing the
93 * dispnew.c (verify_row_hash): Call row_hash for computing the
94 hash code of a row, instead of duplicating code from xdisp.c.
96 * dispextern.h (row_hash): Add prototype.
98 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
100 * frame.c (delete_frame): Don't delete the terminal when the last
101 X frame is closed if emacs is built with GTK toolkit.
103 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
105 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
107 2011-11-17 Martin Rudalics <rudalics@gmx.at>
109 * window.c (Vwindow_splits): Rename to
110 Vwindow_combination_resize. Suggested by Juri Linkov.
111 (Fsplit_window_internal): Use Vwindow_combination_resize instead
114 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
116 * nsfns.m (Fns_font_name):
117 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
119 2011-11-16 Martin Rudalics <rudalics@gmx.at>
121 * window.h (window): Rename slot "nest" to "combination_limit".
122 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
123 (Fset_window_nest): Rename to Fset_window_combination_limit.
124 (Vwindow_nest): Rename to Vwindow_combination_limit.
125 (recombine_windows, make_parent_window, make_window)
126 (Fsplit_window_internal, saved_window)
127 (Fset_window_configuration, save_window_save): Rename all
128 occurrences of window_nest to window_combination_limit.
130 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
132 * image.c (imagemagick_load_image): Fix typo.
134 2011-11-14 Eli Zaretskii <eliz@gnu.org>
136 * xdisp.c (display_line): Move the call to
137 highlight_trailing_whitespace before the call to
138 compute_line_metrics, since the latter needs to see the final
139 faces of all the glyphs to compute ROW's hash value. Fixes
140 assertion violations in row_equal_p. (Bug#10035)
142 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
144 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
145 just return (bug#10044).
147 2011-11-12 Eli Zaretskii <eliz@gnu.org>
149 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
150 with user-defined heap size. Bump the default size of the temacs
151 heap to 27MB, to avoid memory warning when running temacs.
152 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
154 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
155 current_matrix and desired_matrix. (Bug#9990)
156 (verify_row_hash) [XASSERTS]: New function.
157 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
158 that the hash value of glyph rows is correct.
160 2011-11-12 Martin Rudalics <rudalics@gmx.at>
162 * window.h (window): Remove splits slot.
163 * window.c (Fwindow_splits, Fset_window_splits): Remove.
164 (Fdelete_other_windows_internal, make_parent_window)
165 (make_window, Fsplit_window_internal, Fdelete_window_internal)
166 (Fset_window_configuration, save_window_save): Don't deal with
167 split status of windows.
168 (saved_window): Remove splits slot.
169 (Vwindow_splits): Rewrite doc-string.
171 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
173 * xfns.c (unwind_create_frame):
174 * nsfns.m (unwind_create_frame):
175 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
176 Vframe_list (Bug#9999).
178 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
180 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
182 2011-11-11 Kenichi Handa <handa@m17n.org>
184 * callproc.c (Fcall_process): Set the member dst_multibyte of
187 2011-11-11 Johan Bockgård <bojohan@gnu.org>
189 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
190 avoid a crash (bug#9496).
192 2011-11-09 Chong Yidong <cyd@gnu.org>
194 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
195 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
197 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
199 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
201 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
203 Avoid some portability problems by eschewing 'extern inline' functions.
204 The trivial performance wins aren't worth the portability hassles; see
205 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
207 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
208 (window_box_width, window_box_left, window_box_left_offset)
209 (window_box_right, window_box_right_offset): Undo previous change,
210 by removing the "extern"s.
211 * intervals.c (adjust_intervals_for_insertion)
212 (adjust_intervals_for_deletion): Undo previous change,
213 making these static again.
214 (offset_intervals, temp_set_point_both, temp_set_point)
215 (copy_intervals_to_string): No longer inline.
216 * xdisp.c (window_text_bottom_y, window_box_width)
217 (window_box_height, window_box_left_offset)
218 (window_box_right_offset, window_box_left, window_box_right)
219 (window_box): No longer inline.
221 2011-11-08 Chong Yidong <cyd@gnu.org>
223 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
224 (Fwindow_body_height, Fwindow_body_width): Move from Lisp. Signal
225 an error if not a live window.
226 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
227 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
229 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
231 * lisp.h (syms_of_abbrev): Remove declaration.
232 Reported by CHENG Gao <chenggao@royau.me>.
234 2011-11-07 Eli Zaretskii <eliz@gnu.org>
236 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
237 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
238 of temacs in GUI mode.
240 2011-11-07 Martin Rudalics <rudalics@gmx.at>
242 * window.h: Declare delete_all_child_windows instead of
243 delete_all_subwindows.
244 * window.c (Fwindow_nest, Fset_window_nest)
245 (Fset_window_new_total, Fset_window_new_normal)
246 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
247 (delete_all_subwindows): Rename to delete_all_child_windows.
248 (Fdelete_other_windows_internal, Fset_window_configuration):
249 Call delete_all_child_windows instead of delete_all_subwindows.
250 * frame.c (delete_frame): Call delete_all_child_windows instead
251 of delete_all_subwindows.
253 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
255 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
256 This is also needed for porting to any host where GC_MARK_STACK is
257 not GC_MAKE_GCPROS_NOOPS.
258 (which_symbols): Use it.
260 2011-11-07 Kenichi Handa <handa@m17n.org>
262 * coding.c (coding_set_destination): Check coding->src_pos only
263 when coding->src_object is a buffer (bug#9910).
265 * process.c (send_process): Set the member src_multibyte of coding
266 to 0 (bug#9911) when sending a unibyte text.
268 * callproc.c (Fcall_process): Set the member src_multibyte of
269 process_coding to 0 (bug#9912).
271 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
273 * xmenu.c (cleanup_widget_value_tree): New function.
274 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
275 calling free_menubar_widget_value_tree directly (Bug#9830).
277 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
279 Fix some portability problems with 'inline'.
280 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
281 (window_box_width, window_box_left, window_box_left_offset)
282 (window_box_right, window_box_right_offset): Declare extern.
283 Otherwise, these inline functions do not conform to C99 and
284 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
285 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
286 * intervals.c (adjust_intervals_for_insertion)
287 (adjust_intervals_for_deletion): Now extern, because otherwise the
288 extern inline functions 'offset_intervals' couldn't refer to it.
289 (static_offset_intervals): Remove.
290 (offset_intervals): Rewrite using the old contents of
291 static_offset_intervals. The old version didn't conform to C99
292 because an extern inline function contained a reference to an
293 identifier with static linkage.
295 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
297 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
300 2011-11-06 Eli Zaretskii <eliz@gnu.org>
302 * xdisp.c (init_iterator, reseat_to_string): Don't set the
303 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
304 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
305 return Qleft_to_right.
307 2011-11-06 Chong Yidong <cyd@gnu.org>
309 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
310 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
311 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
312 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
313 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
314 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
315 (Fwindow_vscroll): Doc fix.
316 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
317 argument, since it makes no sense to pass a live window and for
318 consistency with window-child.
320 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
322 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
325 2011-11-05 Jason Rumney <jasonr@gnu.org>
327 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
328 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
330 (add_font_entity_to_list): Fix logic errors in mixed boolean and
331 bitwise arithmetic preventing use of unicode-sip and non-truetype
334 2011-11-05 Eli Zaretskii <eliz@gnu.org>
336 * s/ms-w32.h (fstat, stat, utime): Move redirections to
339 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
340 initialization code to keep similarity to xfns.c after changes
343 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
345 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
346 (unwind_create_frame): New function (Bug#9943).
347 (Fx_create_frame): Restructure code to be more similar to the one in
348 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
349 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
350 Move terminal->reference_count++ just before making the frame official
353 * nsterm.m (x_free_frame_resources): New function.
354 (x_destroy_window): Move code to x_free_frame_resources.
356 * xfns.c (unwind_create_frame): Fix comment.
357 (Fx_create_frame, x_create_tip_frame): Move
358 terminal->reference_count++ just before making the frame
359 official. Move initialization of image_cache_refcount and
360 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
362 2011-11-05 Eli Zaretskii <eliz@gnu.org>
364 Support MSVC build with newer versions of Visual Studio.
365 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
366 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
369 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
370 which are not supported by MSVC.
371 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
372 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
374 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
376 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
378 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
380 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
382 Support MSVC build with newer versions of Visual Studio.
383 * w32.c: Don't include w32api.h for MSVC.
384 (init_environment) [_MSC_VER]: Call sys_access, not _access.
386 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
387 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
388 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
389 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
391 (alloca) [_MSC_VER]: Define to _alloca.
393 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
395 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
397 2011-11-04 Eli Zaretskii <eliz@gnu.org>
399 * xdisp.c (note_mouse_highlight): If either of
400 previous/next-single-property-change returns nil, treat that as
401 the beginning or the end of the buffer. (Bug#9955)
403 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
405 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
406 label is not null (Bug#9951).
407 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
410 2011-11-04 Eli Zaretskii <eliz@gnu.org>
412 * window.c (Fwindow_body_size): Mention in the doc string that the
413 return value is in frame's canonical units. (Bug#9949)
415 2011-11-03 Eli Zaretskii <eliz@gnu.org>
417 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
419 * w32fns.c (unwind_create_frame): If needed, free the glyph
420 matrices of the partially constructed frame. (Bug#9943)
421 * xfns.c (unwind_create_frame): Likewise.
423 2011-11-01 Eli Zaretskii <eliz@gnu.org>
425 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
426 Don't stop backward scan on the continuation glyph, even though
427 its CHARPOS is positive.
428 (mouse_face_from_buffer_pos, note_mouse_highlight): Rename
429 cover_string to disp_string.
431 2011-11-01 Martin Rudalics <rudalics@gmx.at>
433 * window.c (temp_output_buffer_show): Don't use
434 Vtemp_buffer_show_specifiers.
435 (Vtemp_buffer_show_specifiers): Remove unused variable.
437 2011-10-30 Eli Zaretskii <eliz@gnu.org>
439 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
440 past the beginning of the current glyph matrix.
442 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
444 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
445 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
446 HAVE_GTK3 (Bug#9869).
448 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
449 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
451 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
453 * xterm.c: Declare x_handle_net_wm_state to return int.
454 (handle_one_xevent): Check if we are iconified but don't have
455 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
456 (get_current_wm_state): Return non-zero if not hidden,
457 check for _NET_WM_STATE_HIDDEN (Bug#9893).
458 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
459 (x_handle_net_wm_state): Return what get_current_wm_state returns.
460 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
462 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
464 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
465 so that this new function doesn't get optimized away by a
466 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
468 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
470 * frame.h (MOUSE_HL_INFO): Remove excess parens.
472 2011-10-29 Eli Zaretskii <eliz@gnu.org>
474 Fix the `xbytecode' command.
475 * .gdbinit (xprintbytestr): New command.
476 (xwhichsymbols): Rename from `which'; all callers changed.
477 (xbytecode): Print the byte-code string as well.
479 2011-10-29 Kim Storm <storm@cua.dk>
481 * alloc.c (which_symbols): New function.
483 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
485 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
488 2011-10-29 Glenn Morris <rgm@gnu.org>
490 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
491 Not clear what it was for, and it causes various bugs. (Bug#9839)
493 2011-10-28 Eli Zaretskii <eliz@gnu.org>
495 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
496 possible random value that matches one of those tested as
497 condition to clear the mouse face.
499 2011-10-28 Chong Yidong <cyd@gnu.org>
501 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
503 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
505 * window.c (make_window): Initialize phys_cursor_on_p.
507 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
509 * lisp.h (struct Lisp_Symbol): Update comments.
511 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
513 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
515 2011-10-28 Eli Zaretskii <eliz@gnu.org>
517 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
518 <oslsachem@gmail.com> for helping to debug this.
520 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
521 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
522 (g_b_init_get_glyph_outline_w): New static variables.
523 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
524 (GetGlyphOutlineW_Proc): New typedefs.
525 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
526 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
528 (w32font_open_internal, compute_metrics):
529 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
530 instead of calling the "wide" APIs directly.
532 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
534 * w32.h (syms_of_w32font): Add prototype.
536 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
538 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
539 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
540 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
541 (Fmove_to_window_line): Doc fix.
543 2011-10-27 Chong Yidong <cyd@gnu.org>
545 * process.c (make_process): Set gnutls_state to NULL.
547 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
548 non-NULL, regardless of GNUTLS_INITSTAGE.
549 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
550 an error. Set process slots as soon as we allocate them.
552 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
554 2011-10-27 Chong Yidong <cyd@gnu.org>
556 * gnutls.c (emacs_gnutls_deinit): New function.
557 Deallocate credentials structures as well as calling gnutls_deinit.
558 (Fgnutls_deinit, Fgnutls_boot): Use it.
560 * process.c (make_process): Initialize GnuTLS credentials to NULL.
561 (deactivate_process): Call emacs_gnutls_deinit.
563 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
565 * image.c (x_create_x_image_and_pixmap):
566 * w32.c (sys_rename, w32_delayed_load):
567 * w32font.c (fill_in_logfont):
568 * w32reg.c (x_get_string_resource): Silence compiler warnings.
570 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
572 * w32fns.c (w32_default_color_map): New function,
573 extracted from Fw32_default_color_map.
574 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
576 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
578 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
580 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
582 * keyboard.c (test_undefined): New function (bug#9751).
583 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
585 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
587 * sysdep.c (init_sys_modes): Fix the check for the controlling
590 2011-10-20 Eli Zaretskii <eliz@gnu.org>
592 * dispextern.h (struct bidi_it): New member next_en_type.
594 * bidi.c (bidi_line_init): Initialize the next_en_type member.
595 (bidi_resolve_explicit_1): When next_en_pos is valid for the
596 current character, check also for next_en_type being WEAK_EN.
597 (bidi_resolve_weak): Don't enter the expensive loop if the current
598 position is before next_en_pos. Record the bidi type of the first
599 non-ET, non-BN character we find, in addition to its position.
600 (bidi_level_of_next_char): Invalidate next_en_type when
601 next_en_pos is over-stepped.
603 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
605 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
606 * editfns.c: Rewrite current-time-zone so that it invokes
607 the equivalent of (format-time-string "%Z") to get the time zone name.
608 This fixes a bug when the time zone name contains characters that
609 need converting from the system time locale to Emacs internal format.
610 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
611 that patch fixed format-time-string to do the conversion, but
612 I forgot to fix current-time-zone.
613 (format_time_string): New function, containing most of
614 what Fformat_time_string used to contain.
615 (Fformat_time_string): Rewrite in terms of format_time_string.
616 This doesn't change this function's behavior.
617 (current-time-zone): Rewrite to use format_time_string.
618 This fixes the bug reported by Michael Schierl in
619 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
620 Jason Rumney's 2007-06-07 change worked around this bug, but
622 * systime.h (tzname, timezone): Remove no-longer-used declarations.
624 2011-10-19 Eli Zaretskii <eliz@gnu.org>
626 * xdisp.c (start_display): If the character at POS is displayed
627 via a display vector, reset IT->current.dpvec_index to zero.
628 (try_window_reusing_current_matrix): If a line ends in a display
629 vector or the next line starts in a display vector, continue
630 redrawing the window even though the character position of
631 start_row was reached.
634 2011-10-18 Chong Yidong <cyd@gnu.org>
636 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
637 with nobreak-char-display too.
639 2011-10-18 Eli Zaretskii <eliz@gnu.org>
641 Fix part 3 of bug#9771.
642 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
643 (bidi_resolve_neutral): Don't enter the expensive loop looking for
644 non-neutral characters if the current character is a paragraph
645 separator (a.k.a. Newline). This avoids running the same
646 expensive loop twice, once when we consume the preceding newline
647 and the other time when the line actually needs to be displayed.
648 Avoid the loop when we see neutrals on the base embedding level
649 following a character whose directionality is the same as the
650 paragraph's. This avoids running the expensive loop when a line
651 ends in a long sequence of neutrals, like control characters.
652 Add assertion against STRONG_AL type. Slightly rearrange code
653 that determines the type of a neutral given the first non-neutral
655 (bidi_level_of_next_char): Set next_en_pos to zero when
656 invalidating its info.
658 2011-10-17 Eli Zaretskii <eliz@gnu.org>
660 * xdisp.c (push_display_prop): Determine whether to record string
661 or buffer position by IT->string, not by IT->method. Allow
662 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
663 (move_it_vertically_backward): Don't look for character position
664 immediately after the newline when in a continuation line.
667 2011-10-15 Martin Rudalics <rudalics@gmx.at>
669 * window.c (coordinates_in_window): Rewrite and delabelize
670 vertical border check. (Bug#5357) (Bug#9618)
672 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
674 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
675 errors in XSetWindowBorder (bug#9310).
677 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
679 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
680 avoid crash when xmalloc overrun checking is enabled.
682 2011-10-13 Eli Zaretskii <eliz@gnu.org>
684 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
685 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
686 cursor motion with <left> and <right> arrow keys.
688 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
689 some callers set that themselves.
691 2011-10-12 Eli Zaretskii <eliz@gnu.org>
693 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
694 display string and the previous row comes from the same string and
695 is empty. (Bug#9739) (Bug#9738)
697 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
699 * doc.c (get_doc_string): Encode file name (bug#9735).
701 2011-10-12 Eli Zaretskii <eliz@gnu.org>
703 * bidi.c (bidi_level_of_next_char):
704 * xdisp.c (get_visually_first_element): Remove old incorrect
705 comments regarding the Unicode Line Separator character.
707 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
709 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
711 * alloc.c (Fgc_status): Do not access beyond zombies array
712 boundary if nzombies > MAX_ZOMBIES.
713 * alloc.c (dump_zombies): Add missing format specifier.
715 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
717 * xdisp.c (set_cursor_from_row): Simplify conditionals,
718 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
720 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
721 Some packages use them to denote characters with modifiers.
723 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
725 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
726 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
727 matching a pp-number. Rename parameter var to var1.
729 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
731 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
733 2011-10-08 Glenn Morris <rgm@gnu.org>
735 * callint.c (Fcall_interactively): Give a more explicit error for the
736 'c' case with a non-character input. (Bug#8479)
738 2011-10-08 Eli Zaretskii <eliz@gnu.org>
740 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
742 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
743 lines that are hscrolled on the left.
745 * dispnew.c (buffer_posn_from_coords): Account for a possible
746 presence of header-line. (Bug#4426)
748 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
750 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
751 Don't advertise functionality which we discourage or doesn't work.
753 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
755 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
756 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
757 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
758 this makes Emacs dump core during garbage collection on rare
759 occasions. sizeof is obviously inferior to offsetof here, so
761 (GC_POINTER_ALIGNMENT): New macro.
762 (mark_memory): Omit 3rd (offset) arg; caller changed.
763 Don't assume EMACS_INT alignment is the same as pointer alignment.
765 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
767 * keyboard.c (read_key_sequence_remapped): New var.
768 (read_key_sequence): Compute remapping in the right buffer.
769 (command_loop_1): Use read_key_sequence's remapping directly.
771 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
773 * dired.c (file_name_completion): Don't expand file name.
774 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
775 before checking file name handler.
777 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
778 they've been requested explicitly (bug#9591).
780 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
782 * keymap.c (Fsingle_key_description): Use make_specified_string
783 instead of build_string to build string from push_key_description.
786 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
788 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
789 This fixes a Y2038 bug on 64-bit hosts.
790 * buffer.c (reset_buffer):
791 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
792 (Fclear_buffer_auto_save_failure):
793 Use 0, not -1, to represent an unset failure time, since time_t
796 Remove dependency on glibc malloc internals.
797 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
798 Move back here from lisp.h, but with their new implementations.
799 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
800 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
801 * charset.c (charset_table_init): New static var.
802 (syms_of_charset): Use it instead of xmalloc. This removes a
803 dependency on glibc malloc internals. See Eli Zaretskii's comment in
804 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
805 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
806 Move back to alloc.c.
807 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
808 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
810 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
812 * nsterm.m (windowDidResize): Call x_set_window_size only when
813 ns_in_resize is true. Otherwise set pixelwidth/height and
814 call change_frame_size (Bug#9628).
816 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
818 Port --enable-checking=all to Fedora 14 x86-64.
819 * charset.c (syms_of_charset): Also account for glibc malloc's
820 internal overhead when calculating the initial malloc maximum.
822 Port --enable-checking=all to Fedora 14 x86.
823 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
825 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
826 (overrun_check_realloc, overrun_check_free):
827 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
828 That way, xmalloc returns a properly-aligned pointer even if
829 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
830 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
831 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
832 into account when calculating the initial malloc maximum.
833 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
834 Move here from alloc.c, so that charset.c can use it too.
835 Properly align; the old code wasn't right for common 32-bit hosts
836 when configured with --enable-checking=all.
837 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
838 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
840 2011-09-29 Eli Zaretskii <eliz@gnu.org>
842 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
845 2011-09-28 Eli Zaretskii <eliz@gnu.org>
847 * xdisp.c (compute_display_string_end): If there's no display
848 string at CHARPOS, return -1.
850 * bidi.c (bidi_fetch_char): When compute_display_string_end
851 returns a negative value, treat the character as a normal
852 character not covered by a display string. (Bug#9624)
854 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
856 * lread.c (Fread_from_string): Fix typo in docstring.
858 2011-09-27 Eli Zaretskii <eliz@gnu.org>
860 * xdisp.c (handle_invisible_prop): If invisible text ends on a
861 newline, reseat the iterator instead of bidi-iterating there one
862 character at a time. (Bug#9610)
863 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
864 TO_CHARPOS if the bidi iterator is at base embedding level.
866 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
868 * lread.c (readevalloop): Use correct code for NBSP.
869 (read1): Likewise. (Bug#9608)
871 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
873 * dbusbind.c (Fdbus_register_signal): When service is not
874 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
876 2011-09-25 Glenn Morris <rgm@gnu.org>
878 * buffer.c (truncate-lines): Doc fix.
880 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
882 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
883 (Fset_window_next_buffers): Doc fix.
885 2011-09-24 Glenn Morris <rgm@gnu.org>
887 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
889 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
891 Fix minor problems found by static checking.
892 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
893 * indent.c (Fvertical_motion): Fix == vs = typo.
895 2011-09-24 Eli Zaretskii <eliz@gnu.org>
897 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
898 Default value is now t. Doc fix.
900 * indent.c (Fvertical_motion): Compute and apply the overshoot
901 logic when moving up, not only when moving down. Fix the
902 confusing name and values of the it_overshoot_expected variable;
903 logic changes accordingly. (Bug#9254) (Bug#9549)
905 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
906 CHARPOS is covered by a display string which includes newlines.
907 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
908 is covered by a display string with embedded newlines.
910 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
912 * dbusbind.c (Fdbus_register_signal): Add match rule to
913 Vdbus_registered_objects_table. (Bug#9581)
914 (Fdbus_register_method, Vdbus_registered_objects_table):
917 2011-09-24 Jim Meyering <meyering@redhat.com>
919 do not ignore write error for any output size
920 The previous change was incomplete.
921 While it makes emacs --batch detect the vast majority of stdout
922 write failures, errors were still ignored whenever the output size is
923 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
924 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
925 && echo FAIL: ignored write error
926 FAIL: ignored write error
927 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
928 && echo FAIL: ignored write error
929 FAIL: ignored write error
930 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
932 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
934 * emacs.c (Fkill_emacs): In noninteractive mode exit
935 non-successfully if a write error occurred on stdout. (Bug#9574)
937 2011-09-21 Eli Zaretskii <eliz@gnu.org>
939 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
942 * dispextern.h (struct it): Update the comment documenting what
945 2011-09-20 Eli Zaretskii <eliz@gnu.org>
947 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
948 a display string, extend search for cursor position to end of row.
949 (find_row_edges): If the row ends in a newline from a display
950 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
951 Handle the case of a display string with multiple newlines.
952 (Fcurrent_bidi_paragraph_direction): Fix search for previous
953 non-empty line. Fixes confusing cursor motion with arrow keys at
954 the beginning of a line that starts with whitespace.
956 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
958 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
961 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
963 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
966 2011-09-18 Eli Zaretskii <eliz@gnu.org>
968 * xdisp.c (display_line): Record maximum and minimum buffer
969 positions even if no glyphs were produced (e.g., by a zero-width
970 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
971 buffer positions that will be removed from the glyph row because
973 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
974 column is beyond frame width: don't subtract 1 "pixel" when
975 computing width of the stretch.
976 (reseat_at_next_visible_line_start): Undo the change made on
977 2011-09-17 that saved paragraph information and restored it after
978 the call to `reseat'. (Bug#9545)
980 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
982 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
983 and turn window cursor on if cleared (Bug#9415).
985 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
987 * search.c (boyer_moore): Take unibyte characters from pattern
988 literally. (Bug#9458)
990 2011-09-18 Eli Zaretskii <eliz@gnu.org>
992 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
994 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
996 Fix minor problem found by static checking.
997 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
998 initialized, to pacify gcc -Wuninitialized.
1000 * fileio.c: Report proper errno when syscall falls.
1001 (Finsert_file_contents): Save and restore errno,
1002 so that report_file_error outputs the correct diagnostic.
1003 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1005 2011-09-18 Eli Zaretskii <eliz@gnu.org>
1007 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1009 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1011 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1012 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1014 2011-09-17 Eli Zaretskii <eliz@gnu.org>
1016 * xdisp.c (reseat_at_next_visible_line_start): Keep information
1017 about the current paragraph and restore it after the call to reseat.
1019 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1020 (bidi_find_paragraph_start): Search back for paragraph beginning
1021 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1022 (bidi_move_to_visually_next): Only trigger paragraph-related
1023 computations when the last character is a newline or at EOB, not
1024 just any NEUTRAL_B. (Bug#9470)
1026 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1027 truncated lines if point is covered by a display string. (Bug#9524)
1029 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1031 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1032 (cons_to_x_long): New function.
1033 (lisp_data_to_selection_data): Use it. Correct the test for
1034 short-versus-long data; it was negated. Break out of vector
1035 loop, for efficiency, when a long datum is discovered.
1037 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1039 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1041 2011-09-16 Eli Zaretskii <eliz@gnu.org>
1043 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1044 GCC PR/17406) by declaring this function with external scope.
1046 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1048 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1049 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1051 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1053 * editfns.c (Fformat): Correctly handle text properties on "%%".
1055 2011-09-15 Eli Zaretskii <eliz@gnu.org>
1057 * xterm.c (x_draw_composite_glyph_string_foreground):
1058 * w32term.c (x_draw_composite_glyph_string_foreground):
1059 * term.c (encode_terminal_code):
1060 * composite.c (composition_update_it, get_composition_id):
1061 * xdisp.c (get_next_display_element)
1062 (fill_composite_glyph_string): Add comments about special meaning
1063 of TAB characters in a composition.
1065 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1067 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
1068 This occurs when processing a multibyte format.
1069 Problem reported by Wolfgang Jenker.
1071 2011-09-15 Johan Bockgård <bojohan@gnu.org>
1073 * xdisp.c (try_cursor_movement): Only check for exact match if
1074 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1076 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1078 Remove unused external symbols.
1079 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1080 * xdisp.c (calc_pixel_width_or_height): Now static.
1081 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1082 * indent.c (check_display_width):
1083 * w32term.c: Fix comment to match code.
1084 * xterm.c, xterm.h (x_catching_errors): Remove.
1086 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1088 * xselect.c: Use signed conversions more consistently (Bug#9498).
1089 (selection_data_to_lisp_data): Assume incoming selection data are
1090 signed integers, not unsigned. This is to be consistent with
1091 outgoing selection data, which was modified to use signed integers
1092 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1093 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1094 expects long, not unsigned long.
1096 2011-09-14 Eli Zaretskii <eliz@gnu.org>
1098 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1099 computation of loop end. Reported by Johan Bockgård
1102 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
1104 * frame.c (Fother_visible_frames_p): Function deleted.
1106 2011-09-12 Eli Zaretskii <eliz@gnu.org>
1108 * indent.c (compute_motion): Process display vector front to back
1109 rather than the other way around. (Bug#2496)
1111 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1113 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1115 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
1117 * minibuf.c (Fread_from_minibuffer): Doc fix.
1119 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1121 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1122 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1124 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1126 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1127 value for non-existent files.
1129 2011-09-11 Eli Zaretskii <eliz@gnu.org>
1131 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1132 set its "size" to -1. This will set the modtime_size field of
1133 the corresponding buffer to -1, which is what
1134 verify-visited-file-modtime expects for files that do not exist.
1137 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1139 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1141 * lisp.h: ... from here. push_key_description is no longer
1142 defined in keyboard.c, so its declaration should not be in
1143 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1144 logically belongs with push_key_description.
1146 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1148 * buffer.h: Include <sys/types.h> instead of <time.h>.
1149 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1150 Problem reported by Herbert J. Skuhra.
1152 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1154 * xml.c (parse_region): Make the parsing work for
1155 non-comment-starting XML files again (bug#9144).
1157 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1159 * image.c (gif_load): Fix calculation of bottom and right corner.
1162 2011-09-10 Eli Zaretskii <eliz@gnu.org>
1164 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1165 redisplay in small windows.
1167 2011-09-09 Eli Zaretskii <eliz@gnu.org>
1169 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1171 2011-09-08 Martin Rudalics <rudalics@gmx.at>
1173 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1174 Operate on live windows only.
1176 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
1178 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1180 2011-09-07 Eli Zaretskii <eliz@gnu.org>
1182 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1183 only under bidi iteration.
1185 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1187 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1189 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1191 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1192 Without this fix, the command to link temacs failed due to an
1193 undefined symbol __builtin_isnan. This is because
1194 /usr/include/iso/math_c99.h #defines isnan(x) to
1195 __builtin_isnan(x), but the bundled gcc, which identifies itself
1196 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1198 * floatfns.c (isnan): #undef, and then #define to a clone of
1200 (Fisnan): Always define, since it's always available now.
1201 (syms_of_floatfns): Always define isnan at the Lisp level.
1203 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1205 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1207 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1209 * fileio.c: Fix bugs with large file offsets (Bug#9428).
1210 The previous code assumed that file offsets (off_t values) fit in
1211 EMACS_INT variables, which is not true on typical 32-bit hosts.
1212 The code messed up by falsely reporting buffer overflow in cases
1213 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1214 when "big" contains more than 2**29 bytes, even though this
1215 inserts just one byte and does not overflow the buffer.
1216 (Finsert_file_contents): Store file offsets as off_t
1217 values, not as EMACS_INT values. Check for overflow when
1218 converting between EMACS_INT and off_t. When checking for
1219 buffer overflow or for overlap, take the offsets into account.
1220 Don't use EMACS_INT for small values where int suffices.
1221 When checking for overlap, fix a typo: ZV was used where
1222 ZV_BYTE was intended.
1223 (Fwrite_region): Don't assume off_t fits into 'long'.
1224 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1226 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
1228 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1230 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1232 sprintf-related integer and memory overflow issues (Bug#9412).
1234 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
1235 (esprintf, exprintf, evxprintf): New functions.
1236 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
1237 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
1238 (modify_event_symbol): Do not assume that the length of
1239 name_alist_or_stem is safe to alloca and fits in int.
1240 (Fexecute_extended_command): Likewise for function name and binding.
1241 (Frecursion_depth): Wrap around reliably on integer overflow.
1242 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1243 since some callers pass EMACS_INT values.
1244 (Fsingle_key_description): Don't crash if symbol name contains more
1245 than MAX_ALLOCA bytes.
1246 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1247 (get_minibuffer): Arg is now EMACS_INT, not int.
1248 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
1249 (esprintf, exprintf, evxprintf): New decls.
1250 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1252 * dbusbind.c (signature_cat): New function.
1253 (xd_signature, Fdbus_register_signal):
1254 Do not overrun buffer; instead, report string overflow.
1256 * dispnew.c (add_window_display_history): Don't overrun buffer.
1257 Truncate instead; this is OK since it's just a log.
1259 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1260 even if the time zone offset is outlandishly large.
1261 Don't mishandle offset == INT_MIN.
1263 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1264 when creating daemon; the previous buffer-overflow check was incorrect.
1266 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1267 which has the guts of the old verror function.
1269 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1270 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1272 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1273 (font_unparse_xlfd): Don't blindly alloca long strings.
1274 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
1275 fits in int, when using sprintf. Use single snprintf to count
1276 length of string rather than counting it via multiple sprintfs;
1277 that's simpler and more reliable.
1278 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1279 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1280 sprintf, in case result does not fit in int.
1282 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1283 (fontset_from_font): Print it.
1285 * frame.c (tty_frame_count): Now printmax_t, not int.
1286 (make_terminal_frame, set_term_frame_name): Print it.
1287 (x_report_frame_params): In X, window IDs are unsigned long,
1288 not signed long, so print them as unsigned.
1289 (validate_x_resource_name): Check for implausibly long names,
1290 and don't assume name length fits in 'int'.
1291 (x_get_resource_string): Don't blindly alloca invocation name;
1292 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1295 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1296 (xg_check_special_colors, xg_set_geometry):
1297 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1299 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1300 Use esprintf, not sprintf, in case result does not fit in int.
1302 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1303 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1304 it as a large positive number.
1305 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1306 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1308 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1309 in case result does not fit in int.
1311 * print.c (float_to_string): Detect width overflow more reliably.
1312 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1313 buffer overrun. Don't assume list length fits in 'int'. Treat
1314 print length of 0 as 0, not as infinity; to be consistent with other
1315 uses of print length in this function. Don't overflow print length
1316 index. Don't assume hash table size fits in 'long', or that
1317 vectorlike size fits in 'unsigned long'.
1319 * process.c (make_process): Use printmax_t, not int, to format
1320 process-name gensyms.
1322 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1324 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1325 to avoid potential buffer overrun.
1327 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1328 if X resource line is longer than 512 bytes.
1330 * xfns.c (x_window): Make sprintf buffer a bit bigger
1331 to avoid potential buffer overrun.
1333 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1335 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1337 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1339 Integer overflow fixes for scrolling, etc.
1340 Without these, Emacs silently mishandles large integers sometimes.
1341 For example, "C-u 4294967297 M-x recenter" was treated as if
1342 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1344 * xdisp.c (try_window_id): Check Emacs fixnum range before
1345 converting to 'int'.
1347 * window.c (window_scroll_line_based, Frecenter):
1348 Check that an Emacs fixnum is in range before assigning it to 'int'.
1349 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1350 values converted from Emacs fixnums.
1351 (Frecenter): Don't wrap around a line count if it is out of 'int'
1352 range; instead, treat it as an extreme value.
1353 (Fset_window_configuration, compare_window_configurations):
1354 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1356 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1357 that can exceed INT_MAX. Check that EMACS_INT value is in range
1358 before assigning it to the (possibly-narrower) index.
1359 (match_limit): Don't assume that a fixnum can fit in 'int'.
1361 * print.c (print_object): Use ptrdiff_t, not int, for index that can
1364 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
1365 (Fvertical_motion): Don't wrap around LINES values that don't fit
1366 in 'int'. Instead, treat them as extreme values. This is good
1367 enough for windows, which can't have more than INT_MAX lines anyway.
1369 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1371 * Require libxml/parser.h to avoid compilation warning.
1373 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1375 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1376 since this reportedly can destroy thread storage.
1378 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
1380 * syntax.c (find_defun_start): Update all cache variables if
1381 exiting early (Bug#9401).
1383 2011-08-30 Eli Zaretskii <eliz@gnu.org>
1385 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1387 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1388 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1389 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1391 * term.c (tty_append_glyph): New function.
1392 (produce_stretch_glyph): Static function and its prototype deleted.
1394 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1397 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1399 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1400 when checking :margin (Bug#9390).
1401 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
1402 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
1403 so that the name doesn't mislead. All uses changed.
1405 2011-08-28 Johan Bockgård <bojohan@gnu.org>
1407 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1410 2011-08-27 Eli Zaretskii <eliz@gnu.org>
1412 * xdisp.c (move_it_to): Don't bail out early when reaching
1413 position beyond to_charpos, if we are scanning backwards.
1414 (move_it_vertically_backward): When DY == 0, make sure we get to
1415 the first character in the line after the newline.
1417 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1419 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1420 (ccl_driver): Do not generate an out-of-range pointer.
1421 (Fccl_execute_on_string): Remove unnecessary check for
1422 integer overflow, noted by Stefan Monnier in
1423 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1424 Remove a FIXME that didn't need fixing.
1425 Simplify the newly-introduced buffer reallocation code.
1427 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
1429 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1431 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
1433 Integer and memory overflow issues (Bug#9196).
1435 * doc.c (get_doc_string): Rework so that
1436 get_doc_string_buffer_size is the actual buffer size, rather than
1437 being 1 less than the actual buffer size; this makes xpalloc more
1440 * image.c (x_allocate_bitmap_record, cache_image):
1441 * xselect.c (Fx_register_dnd_atom):
1442 Simplify previous changes by using xpalloc.
1444 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1445 since either will do and ptrdiff_t is convenient with xpalloc.
1447 * charset.c (charset_table_size)
1448 (struct charset_sort_data.priority): Now ptrdiff_t.
1449 (charset_compare): Don't overflow if priorities differ greatly.
1450 (Fsort_charsets): Don't assume list length fits in int.
1451 Check for size-calculation overflow when allocating sort data.
1452 (syms_of_charset): Allocate an initial charset table that is
1453 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1455 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1457 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1458 The actual value is always <= INT_MAX, and leaving it unsigned made
1459 overflow checking harder.
1461 * dispextern.h (struct glyph_matrix.rows_allocated)
1462 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1463 with xpalloc. The values are still always <= INT_MAX.
1465 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1467 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1468 (SAFE_NALLOCA): New macro.
1470 * region-cache.c (struct boundary.pos, find_cache_boundary)
1471 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1472 (set_cache_region, invalidate_region_cache)
1473 (revalidate_region_cache, know_region_cache, region_cache_forward)
1474 (region_cache_backward, pp_cache):
1475 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1476 so that ptrdiff_t * can be passed to xpalloc.
1477 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1478 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1479 (pp_cache): Don't assume cache_len fits in int.
1480 * region-cache.h: Adjust extern decls to match.
1482 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1483 EMACS_INT, since either will do, for xpalloc.
1485 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1486 (xnmalloc, xnrealloc, xpalloc): New functions.
1488 * bidi.c (bidi_shelve_header_size): New constant.
1489 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1490 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1492 * bidi.c (bidi_cache_shrink):
1493 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1495 Don't update size of array until after memory allocation succeeds,
1496 because xmalloc/xrealloc may not return.
1497 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1498 now that we have proper integer overflow checking.
1499 (record_overlay_string, overlay_strings): Catch overflows when
1500 calculating size of overlay_str_buf.
1502 * callproc.c (Fcall_process): Check for size overflow when
1503 calculating size of args2.
1504 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1505 Normally we prefer signed values, but sticking with ptrdiff_t would
1506 require adding more-complicated checks.
1508 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1509 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1510 Redo buffer-overflow calculations to avoid integer overflow.
1511 Add a FIXME comment where memory seems to be over-allocated.
1513 * character.c (Fstring): Check for size-calculation overflow.
1515 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1516 unnecessary integer overflow. Check for size overflow.
1517 (encode_coding_object): Don't update size until xmalloc succeeds.
1519 * composite.c (get_composition_id): Check for overflow in glyph
1520 length calculations.
1522 Integer and memory overflow fixes for display code.
1523 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1524 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1525 (scrolling_window): Check for overflow in size calculations.
1526 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1527 Don't assume glyph table len fits in int.
1528 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1529 (row_table_size): Now ptrdiff_t, not int.
1530 (scrolling_window): Avoid overflow in size calculations.
1531 Don't update size until allocation succeeds.
1532 * fns.c (concat): Check for overflow in size calculations.
1533 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1534 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1535 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1537 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1538 (get_doc_string): Check for size calculation overflow.
1539 Don't update size until allocation succeeds.
1540 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1541 EMACS_INT, where ptrdiff_t will do.
1542 (Fsubstitute_command_keys): Check for string overflow.
1544 * editfns.c (set_time_zone_rule): Don't assume environment length
1546 (message_length): Now ptrdiff_t, not int.
1547 (Fmessage_box): Don't update size until allocation succeeds.
1548 Don't assume message length fits in int.
1549 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1551 * emacs.c (main): Do not reallocate argv, since there is a null at
1552 the end that can be overwritten, and this way there's no need to
1553 worry about size-calculation overflow.
1554 (sort_args): Check for size-calculation overflow.
1556 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1558 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1560 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1561 (x_set_scroll_bar_width, x_figure_window_size):
1562 Check for integer overflow.
1563 (x_set_alpha): Do not assume XINT fits in int.
1565 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1566 This is for the members text_lines, text_cols, total_lines, total_cols,
1567 where the system imposes an 'int' limit.
1569 * fringe.c (Fdefine_fringe_bitmap):
1570 Don't update size until alloc works.
1572 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1573 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1575 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1576 Check for size-calculation overflow.
1577 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1578 do, as we prefer signed integers.
1579 (id_to_widget.max_size, id_to_widget.used)
1580 (xg_store_widget_in_map, xg_remove_widget_from_map)
1581 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1582 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1583 Use and return ptrdiff_t, not int.
1584 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1585 * gtkutil.h: Change prototypes to match the above.
1587 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1588 are duplicate now that they've been promoted to lisp.h.
1589 (x_allocate_bitmap_record, x_alloc_image_color)
1590 (make_image_cache, cache_image, xpm_load):
1591 Don't update size until alloc is done.
1592 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1594 Check for size calculation overflow.
1595 (ct_colors_allocated_max): New constant.
1596 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1599 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1600 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1601 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1602 Use ptrdiff_t, not int, to count maps.
1603 (read_char_minibuf_menu_prompt): Check for overflow in size
1604 calculations. Don't update size until allocation succeeds.
1605 Redo calculations to avoid overflow.
1606 * keyboard.h: Change prototypes to match the above.
1608 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1610 (current_minor_maps): Check for size calculation overflow.
1611 * keymap.h: Change prototypes to match the above.
1613 * lread.c (read1, init_obarray): Don't update size until alloc done.
1615 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1616 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1618 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1619 Now ptrdiff_t, not int.
1620 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1621 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1623 * process.c (Fnetwork_interface_list): Check for overflow
1624 in size calculation.
1626 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1628 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1629 overflow. Don't bother calling xmalloc when xrealloc will do.
1631 * search.c (Freplace_match): Check for size calculation overflow.
1632 (Fset_match_data): Don't assume list lengths fit in 'int'.
1634 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1635 for command line length. Do not attempt to address one before the
1636 beginning of an array, as that's not portable.
1638 * term.c (max_frame_lines): Remove; unused.
1639 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1641 (encode_terminal_code, calculate_costs): Check for size
1642 calculation overflow.
1643 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1644 table lengths and related sizes. Don't update size until alloc
1645 done. Redo calculations to avoid overflow.
1646 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1648 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1649 subtracting pointers.
1650 (gobble_line): Check for overflow more carefully. Don't update size
1653 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1654 Don't update size until alloc done.
1655 Redo size calculations to avoid overflow.
1656 Check for size calculation overflow.
1657 (main) [DEBUG]: Fix typo in invoking tparam1.
1659 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1660 Use ptrdiff_t, not int, for sizes.
1661 (store_mode_line_noprop_char): Don't update size until alloc done.
1663 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1664 Use ptrdiff_t, not int, for sizes.
1665 (Finternal_make_lisp_face, cache_face):
1666 Check for size calculation overflow.
1667 (cache_face): Treat size calculation overflows as if they were
1668 memory exhaustion (the usual treatment), rather than aborting.
1670 * xfns.c (x_encode_text, x_set_name_internal)
1671 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1672 sizes, since they can exceed INT_MAX in size. Check for size
1673 calculation overflow.
1675 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1676 (xg_select): Check for size calculation overflow.
1677 Don't update size until alloc done.
1679 * xrdb.c (get_environ_db): Don't assume path length fits in int,
1680 as sprintf is limited to int lengths.
1682 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1683 (X_LONG_MIN): New macros.
1684 Use them to make the following changes clearer.
1685 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1686 This change doesn't affect the value now, but it may help remind
1687 future maintainers not to raise the value too much later.
1688 (SELECTION_QUANTUM): Remove, replacing with ...
1689 (selection_quantum): ... new function, which avoids overflow.
1691 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1692 assumption that selection length fits in 'int'.
1693 (x_reply_selection_request, x_handle_selection_request)
1694 (x_get_window_property, receive_incremental_selection)
1695 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1696 (lisp_data_to_selection_data, clean_local_selection_data):
1697 Use ptrdiff_t, not int, to record length of selection.
1698 (x_reply_selection_request, x_get_window_property)
1699 (receive_incremental_selection, x_property_data_to_lisp):
1700 Redo calculations to avoid overflow.
1701 (x_reply_selection_request): When sending hint, ceiling it at
1702 X_LONG_MAX rather than relying on wraparound overflow to send
1704 (x_get_window_property, receive_incremental_selection)
1705 (lisp_data_to_selection_data, x_property_data_to_lisp):
1706 Check for size-calculation overflow.
1707 (x_get_window_property, receive_incremental_selection)
1708 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1709 Don't store size until memory allocation succeeds.
1710 (x_get_window_property): Plug memory leak on memory exhaustion.
1711 Don't double-block input; malloc is safe here. Don't assume 2**34
1712 - 4 fits in unsigned long. Add an xassert to check
1713 XGetWindowProperty overflow. Be more careful about overflow
1714 calculations, and distinguish size from memory overflow better.
1715 (receive_incremental_selection): When tracing, don't assume
1716 unsigned int is less than INT_MAX.
1717 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1718 harmful) conversions of unsigned short to int.
1719 (lisp_data_to_selection_data): Don't assume that integers
1720 in the range -65535 through -1 fit in an X unsigned short.
1721 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1722 result parameters unless successful. Rely on cons_to_unsigned
1723 to report problems with elements; the old code wasn't right anyway.
1724 (x_check_property_data): Check for int overflow; we cannot use
1725 a wider type due to X limits.
1726 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1728 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
1730 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1731 (x_term_init): Check for size calculation overflow.
1732 (x_color_cells): Don't store size until memory allocation succeeds.
1733 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
1734 Don't assume alloca size is less than MAX_ALLOCA.
1735 (x_term_init): Don't assume length fits in int (sprintf is limited
1738 Use ptrdiff_t for composition IDs.
1739 * character.c (lisp_string_width):
1740 * composite.c (composition_table_size, n_compositions)
1741 (get_composition_id, composition_gstring_from_id):
1742 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1743 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1744 * window.c (Frecenter):
1745 Use ptrdiff_t, not int, for composition IDs.
1746 * composite.c (get_composition_id): Check for integer overflow.
1747 * composite.h: Adjust prototypes to match the above changes.
1749 Use ptrdiff_t for hash table indexes.
1750 * category.c (hash_get_category_set):
1751 * ccl.c (ccl_driver):
1752 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1753 * coding.c (coding_system_charset_list, detect_coding_system):
1754 * coding.h (struct coding_system.id):
1755 * composite.c (get_composition_id, gstring_lookup_cache):
1756 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1757 * image.c (xpm_get_color_table_h):
1758 * lisp.h (hash_lookup, hash_put):
1759 * minibuf.c (Ftest_completion):
1760 Use ptrdiff_t for hash table indexes, not int (which is too
1761 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1762 32-bit --with-wide-int hosts).
1764 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1765 Add a FIXME comment about memory leaks.
1766 (syms_of_charset): Don't assume xmalloc returns.
1768 Don't assume that stated character widths fit in int.
1769 * character.c (Fchar_width, c_string_width, lisp_string_width):
1770 * character.h (CHAR_WIDTH):
1771 * indent.c (MULTIBYTE_BYTES_WIDTH):
1772 Use sanitize_char_width to avoid undefined and/or bad behavior
1773 with outlandish widths.
1774 * character.h (sanitize_tab_width): Rename from sanitize_width,
1775 now that we have two such functions. All uses changed.
1776 (sanitize_char_width): New inline function.
1778 Don't assume that tab-width fits in int.
1779 * character.h (sanitize_width): New inline function.
1780 (SANE_TAB_WIDTH): New macro.
1781 (ASCII_CHAR_WIDTH): Use it.
1782 * indent.c (sane_tab_width): Remove. All uses replaced by
1783 SANE_TAB_WIDTH (current_buffer).
1784 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1786 * fileio.c: Integer overflow issues with file modes.
1787 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1789 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1790 Remove unreachable code.
1791 (read_hex, load_charset_map_from_file): Check for integer overflow.
1793 * xterm.c: don't go over XClientMessageEvent limit
1794 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1795 (x_send_scroll_bar_event): Likewise. Check that the size does not
1796 exceed limits imposed by XClientMessageEvent, as well as the usual
1797 ptrdiff_t and size_t limits.
1799 * keyboard.c: Overflow, signedness and related fixes.
1800 (make_lispy_movement): Use same integer type in forward decl
1801 that is used in the definition.
1802 (read_key_sequence, keyremap_step):
1803 Change bufsize argument back to int, undoing my 2011-03-30 change.
1804 We prefer signed types, and int is wide enough here.
1805 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1806 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1807 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1808 length, not size_t. Use ptrdiff_t for index, not int.
1809 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1810 possibility of integer overflow.
1812 Overflow, signedness and related fixes for images.
1814 * dispextern.h (struct it.stack[0].u.image.image_id)
1815 (struct_it.image_id, struct image.id, struct image_cache.size)
1816 (struct image_cache.used, struct image_cache.ref_count):
1817 * gtkutil.c (update_frame_tool_bar):
1818 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1819 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1820 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1821 * nsmenu.m (update_frame_tool_bar):
1822 * xdisp.c (calc_pixel_width_or_height):
1823 * xfns.c (image_cache_refcount):
1824 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1825 on typical 64-bit hosts.
1827 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1828 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1829 Omit unnecessary casts to int.
1830 (parse_image_spec): Check that integers fall into 'int' range
1831 when the callers expect that.
1832 (image_ascent): Redo ascent calculation to avoid int overflow.
1833 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1834 (lookup_image): Remove unnecessary tests.
1835 (xbm_image_p): Locals are now of int, not EMACS_INT,
1836 since parse_image_check makes sure they fit into int.
1837 (png_load, gif_load, svg_load_image):
1838 Prefer int to unsigned where either will do.
1839 (tiff_handler): New function, combining the cores of the
1840 old tiff_error_handler and tiff_warning_handler.
1841 This function is rewritten to use vsnprintf and thereby avoid
1842 stack buffer overflows. It uses only the features of vsnprintf
1843 that are common to both POSIX and native Microsoft.
1844 (tiff_error_handler, tiff_warning_handler): Use it.
1845 (tiff_load, gif_load, imagemagick_load_image):
1846 Don't assume :index value fits in 'int'.
1847 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1848 (imagemagick_load_image): Check that crop parameters fit into
1849 the integer types that MagickCropImage accepts. Don't assume
1850 Vimagemagick_render_type has a nonnegative value. Don't assume
1851 size_t fits in 'long'.
1852 (gs_load): Use printmax_t to print the widest integers possible.
1853 Check for integer overflow when computing image height and width.
1855 2011-08-26 Eli Zaretskii <eliz@gnu.org>
1857 * xdisp.c (redisplay_window): Don't force window start if point
1858 will be invisible in the resulting window. (Bug#9324)
1860 2011-08-25 Eli Zaretskii <eliz@gnu.org>
1862 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1863 the display spec is of the form `(space ...)'.
1864 (handle_display_spec): Return the value returned by
1865 handle_single_display_spec, not just 1 or zero.
1866 (handle_single_display_spec): If the display spec is of the form
1867 `(space ...)', and specifies display in the text area, return 2
1869 (try_cursor_movement): Check for the need to scroll more
1870 accurately, and prefer exact match for point under bidi.
1871 Don't advance `row' beyond the last row of the window.
1873 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1874 into disp_prop; all users changed.
1876 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1877 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1878 for the text covered by the display property.
1880 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
1882 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1883 Change return value to nil.
1884 (Frecord_buffer): Delete unused function.
1886 2011-08-24 Eli Zaretskii <eliz@gnu.org>
1888 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1889 buffers, return left-to-right.
1890 (set_cursor_from_row): Consider candidate row a win if its glyph
1891 represents a newline and point is on that newline. Fixes cursor
1892 positioning on the newline at EOL of R2L text within L2R
1893 paragraph, and vice versa.
1894 (try_cursor_movement): Check continued rows, in addition to
1895 continuation rows. Fixes unwarranted scroll when point enters a
1896 continued line of R2L text within an L2R paragraph, or vice versa.
1897 (cursor_row_p): Consider the case of point being equal to
1898 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1899 from the end of a short line to the beginning of a continued line
1900 of R2L text within L2R paragraph.
1901 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1902 composed characters.
1904 * bidi.c (bidi_check_type): Use xassert.
1905 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1908 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1910 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1913 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
1915 * nsfont.m (ns_otf_to_script): Fix typo.
1917 2011-08-22 Kenichi Handa <handa@m17n.org>
1919 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1920 extra slot even if the purpose is char-code-property-table.
1922 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1924 * xdisp.c (redisplay_window): When computing centering_position,
1925 account for the height of the header line. (Bug#8874)
1927 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1928 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1929 candidate is selected by the mouse, and that candidate has a
1930 composed character under the mouse.
1932 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1933 coordinates reported by pos-visible-in-window-p for a composed
1934 character in column zero.
1936 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1938 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1940 2011-08-22 Eli Zaretskii <eliz@gnu.org>
1942 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1943 consider it a hit if to_charpos is anywhere in the range of the
1944 composed buffer positions.
1946 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
1948 * image.c (gif_load): Don't assume that each subimage has the same
1949 dimensions as the base image. Handle disposal method that is
1950 "undefined" by the gif spec (Bug#9335).
1952 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
1954 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
1955 (Fcondition_case): Document `debug' symbol in error handler.
1957 2011-08-19 Eli Zaretskii <eliz@gnu.org>
1959 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1960 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1961 from an Org mode buffer to a Speedbar frame.
1963 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1964 a composition, take its buffer position from IT->cmp_it.charpos.
1965 Fixes cursor positioning at the beginning of a line that begins
1966 with a composed character.
1968 2011-08-18 Eli Zaretskii <eliz@gnu.org>
1970 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1971 character bidirectional type, use STRONG_L instead. Fixes crashes
1972 in a buffer produced by `describe-categories'.
1974 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1975 members before the level stack, so they would be saved and
1976 restored when copying iterator state. Fixes incorrect reordering
1977 around TABs covered by display properties.
1979 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1981 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
1983 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
1985 * eval.c (internal_condition_case, internal_condition_case_1)
1986 (internal_condition_case_2, internal_condition_case_n):
1987 Remove unnecessary aborts (Bug#9081).
1989 2011-08-17 Eli Zaretskii <eliz@gnu.org>
1991 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1992 has no `load' handler, try opening the file locally. (Bug#9311)
1994 2011-08-16 Ken Brown <kbrown@cornell.edu>
1996 * gmalloc.c: Expand comment.
1998 2011-08-16 Eli Zaretskii <eliz@gnu.org>
2000 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2001 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2003 2011-08-16 Ken Brown <kbrown@cornell.edu>
2005 Fix memory allocation problems in Cygwin build (Bug#9273).
2007 * unexcw.c ( __malloc_initialized): Declare external variable.
2008 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2010 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2012 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2014 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2016 [CYGWIN] (special_realloc): New function.
2017 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2018 requests to realloc storage in the static heap.
2020 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2022 * bidi.c (bidi_initialize): Remove unused local.
2024 2011-08-15 Eli Zaretskii <eliz@gnu.org>
2027 * biditype.h: Remove file.
2028 * makefile.w32-in ($(BLD)/bidi.$(O)):
2029 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
2031 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2033 * chartab.c: Improve commentary for the uniprop_table API.
2035 * bidi.c (bidi_paragraph_init): Support zero value of
2036 bidi_ignore_explicit_marks_for_paragraph_level.
2037 (bidi_initialize): Use uniprop_table instead of including
2038 biditype.h and bidimirror.h.
2040 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2041 coordinates of the iterator when restoring from ppos_it.
2044 2011-08-14 Kenichi Handa <handa@m17n.org>
2046 * process.c (create_process): Call setup_process_coding_systems
2047 after the pid of the process is set to -1 (Bug#8162).
2049 2011-08-14 Eli Zaretskii <eliz@gnu.org>
2051 * xdisp.c (move_it_in_display_line_to): Don't invoke
2052 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2053 ppos_it. Fixes vertical cursor motion when line beginning is
2054 covered by an image. (Bug#9296)
2056 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2058 * nsterm.h (ns_run_ascript): Declare.
2059 (NSAPP_DATA2_RUNASSCRIPT): Define.
2061 * nsfns.m (as_script, as_result, as_status): New static variables.
2062 (ns_run_ascript): New function.
2063 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
2064 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2065 the event loop. Get status from as_status (Bug#7276).
2067 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2068 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2069 the event loop (Bug#7276).
2071 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2073 * gnutls.c (QCgnutls_bootprop_priority)
2074 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2075 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2076 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2077 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2078 (QCgnutls_bootprop_verify_hostname_error)
2079 (QCgnutls_bootprop_callbacks_verify): Rename from
2080 Qgnutls_bootprop_..., all uses changed.
2082 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2085 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2087 * xfaces.c (Qframe_set_background_mode): Now static.
2088 * dispextern.h (Qframe_set_background_mode): Remove decl.
2090 * process.c (Fnetwork_interface_info): Declare local only if needed.
2092 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2094 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2095 (Fnetwork_interface_list): Allocate in increments of bytes instead
2096 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2097 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2099 (struct ifflag_def): notrailers is smart on OSX.
2100 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2101 Get hardware address with getifaddrs if available.
2103 2011-08-12 Eli Zaretskii <eliz@gnu.org>
2105 * xdisp.c (iterate_out_of_display_property): xassert that
2106 IT->position is set to within IT->object's boundaries. Break from
2107 the loop as soon as EOB is reached; avoids infloops in redisplay
2108 when IT->position is set up wrongly due to some bug.
2109 Set IT->current to match the bidi iterator unconditionally.
2110 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2111 entry. Force push_it to save on the stack the current
2112 buffer/string position, to be restored by pop_it. Fix flags in
2113 the iterator structure wrt the object coming from a display
2114 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2115 properties. (Bug#9284)
2117 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
2119 * fontset.c (fontset_get_font_group): Add proper type checks.
2122 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2124 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2125 and LC_VERSION_MIN_MACOSX.
2126 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2127 (dump_it) [LC_FUNCTION_STARTS]: Use it.
2129 2011-08-08 Eli Zaretskii <eliz@gnu.org>
2131 * xdisp.c (forward_to_next_line_start): Allow to use the
2132 no-display-properties-and-no-overlays under bidi display.
2133 Set disp_pos in the bidi iterator to avoid searches for display
2134 properties and overlays.
2136 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
2138 * editfns.c (Fset_time_zone_rule): Document relationship with the
2141 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2142 the font entity extracted from the cache (Bug#8109).
2144 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
2146 * composite.c (autocmp_chars): Don't reset point. That is done by
2147 restore_point_unwind (Bug#5984).
2149 2011-08-07 Juri Linkov <juri@jurta.org>
2151 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2152 to show the arg `TIME' instead of `TIMEVAL'.
2154 2011-08-06 Eli Zaretskii <eliz@gnu.org>
2156 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2157 display property strides EOL and includes a newline, as in
2158 longlines-mode. (Bug#9254)
2159 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2160 word-wrap under bidirectional display. (Bug#9224)
2162 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2163 is non-zero, even if the data buffer is NULL. Fixes a crash in
2164 vertical-motion with longlines-mode. (Bug#9254)
2166 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2168 * bidi.c <bidi_cache_total_alloc>: Now static.
2169 (bidi_initialize): Initialize bidi_cache_total_alloc.
2171 * xdisp.c (display_line): Release buffer allocated for shelved bidi
2174 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2175 amount allocated this far in `bidi_cache_total_alloc'.
2176 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2177 non-zero, only free the data buffer without restoring the cache
2178 contents. All callers changed.
2180 * dispextern.h (bidi_unshelve_cache): Update prototype.
2182 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2183 (move_it_in_display_line, move_it_to)
2184 (move_it_vertically_backward, move_it_by_lines): Replace the call
2185 to xfree to an equivalent call to bidi_unshelve_cache.
2186 (move_it_in_display_line_to): Fix logic of returning
2187 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
2189 2011-08-05 Eli Zaretskii <eliz@gnu.org>
2191 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2192 came from a string character with a `cursor' property. (Bug#9229)
2194 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2196 * Makefile.in (LIB_PTHREAD): New variable.
2197 (LIBES): Add LIB_PTHREAD (Bug#9216).
2199 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2200 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2202 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2204 * regex.c (re_iswctype): Remove some redundant boolean conversions.
2206 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2208 * xterm.c (x_find_topmost_parent): New function.
2209 (x_set_frame_alpha): Find topmost parent window with
2210 x_find_topmost_parent and set the property there also (bug#9181).
2211 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2213 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2215 * callproc.c (Fcall_process): Avoid vfork clobbering
2216 the local vars buffer, coding_systems, current_dir.
2218 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2220 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2222 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2224 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2225 so that it is not optimized away.
2227 * xdisp.c (compute_display_string_pos): Remove unused local.
2229 2011-08-02 Eli Zaretskii <eliz@gnu.org>
2231 Fix slow cursor motion and scrolling in large buffers with
2232 selective display, like Org Mode buffers. (Bug#9218)
2234 * dispextern.h (struct bidi_it): New member disp_prop_p.
2236 * xdisp.c: Remove one-slot cache of display string positions.
2237 (compute_display_string_pos): Accept an additional argument
2238 DISP_PROP_P; callers changed. Scan at most 5K characters forward
2239 for a display string or property. If found, set DISP_PROP_P
2242 * bidi.c (bidi_fetch_char): Accept an additional argument
2243 DISP_PROP_P, and pass it to compute_display_string_pos.
2244 Only handle text covered by a display string if DISP_PROP_P is returned
2245 non-zero. All callers of bidi_fetch_char changed.
2247 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2249 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2251 2010-12-03 Don March <don@ohspite.net>
2253 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2254 last character M-[char] is translated to ESC [char] (bug#7541).
2256 2011-08-02 Kenichi Handa <handa@m17n.org>
2258 * lisp.h (uniprop_table): Extern it.
2260 * chartab.c (uniprop_table): Make it non-static.
2262 2011-08-01 Eli Zaretskii <eliz@gnu.org>
2264 * xdisp.c (forward_to_next_line_start): Accept additional argument
2265 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2267 (reseat_at_next_visible_line_start): Use the bidi iterator state
2268 returned by forward_to_next_line_start to restore the state of
2269 it->bidi_it after backing up to previous newline. (Bug#9212)
2271 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2273 * regex.c (re_comp): Protoize.
2274 (re_exec): Fix return type.
2275 (regexec): Fix type of `ret'. (Bug#9203)
2277 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2279 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2280 This is needed if max-image-size is a floating-point number.
2282 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2284 * print.c (print_object): Print empty symbol as ##.
2286 * lread.c (read1): Read ## as empty symbol.
2288 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2290 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2291 setting frame foreground color (Bug#9175).
2292 (x_set_background_color): Likewise.
2294 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2295 contents (Bug#9176).
2296 (EmacsTooltip -init): Remove bezels and add shadows to
2299 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2300 or scroll bar (Bug#8470).
2302 * nsfont.m (nsfont_open): Remove assignment to voffset and
2303 unnecessary vars hshink, expand, hd, full_height, min_height.
2304 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2306 * nsterm.h (nsfont_info): Remove voffset field.
2308 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2310 Implement strike-through and overline on NextStep (Bug#8863).
2312 * nsfont.m (nsfont_open): Use underline position provided by font,
2313 instead of hard-coded value of 2.
2314 (nsfont_draw): Call ns_draw_text_decoration instead.
2316 * nsterm.h: Add declaration for ns_draw_text_decoration.
2318 * nsterm.m (ns_draw_text_decoration): New function for drawing
2319 underline, overline, and strike-through.
2320 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2321 ns_draw_text_decoration. Change treatment of cursor drawing to
2322 accommodate underlining, etc.
2324 2011-07-28 Eli Zaretskii <eliz@gnu.org>
2326 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2329 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2331 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2332 Without this fix, if a signal arrives just after memory fills up,
2333 'malloc' might be invoked reentrantly.
2335 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2336 In other words, assume that every image size is allowed, on non-X
2337 hosts. This assumption is probably wrong, but it lets Emacs compile.
2339 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2341 * regex.c (re_iswctype): Convert return values to boolean.
2343 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2345 * xdisp.c (compute_display_string_pos): Don't use cached display
2346 string position if the buffer had its restriction changed.
2349 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2351 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2353 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2355 Integer signedness and overflow and related fixes. (Bug#9079)
2357 * bidi.c: Integer size and overflow fixes.
2358 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2359 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2360 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2361 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2362 (bidi_find_other_level_edge):
2363 Use ptrdiff_t instead of EMACS_INT where either will do.
2364 This works better on 32-bit hosts configured --with-wide-int.
2365 (bidi_cache_ensure_space): Check for size-calculation overflow.
2366 Use % rather than repeated addition, for better worst-case speed.
2367 Don't set bidi_cache_size until after xrealloc returns, because it
2369 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
2370 (bidi_cache_ensure_space): Also check that the bidi cache size
2371 does not exceed that of the largest Lisp string or buffer. See Eli
2372 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
2374 * alloc.c (__malloc_size_t): Remove.
2375 All uses replaced by size_t. See Andreas Schwab's note
2376 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2378 * image.c: Improve checking for integer overflow.
2379 (check_image_size): Assume that f is nonnull, since
2380 it is always nonnull in practice. This is one less thing to
2381 worry about when checking for integer overflow later.
2382 (x_check_image_size): New function, which checks for integer
2383 overflow issues inside X.
2384 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2385 This removes the need for a memory_full check.
2386 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2387 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2388 (xbm_read_bitmap_data): Change locals back to 'int', since
2389 their values must fit in 'int'.
2390 (xpm_load_image, png_load, tiff_load):
2391 Invoke x_create_x_image_and_pixmap earlier,
2392 to avoid much needless work if the image is too large.
2393 (tiff_load): Treat overly large images as if
2394 x_create_x_image_and_pixmap failed, not as malloc failures.
2395 (gs_load): Use x_check_image_size.
2397 * gtkutil.c: Omit integer casts.
2398 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2399 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2401 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2403 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2404 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2405 would wrongly return t on a 64-bit host.
2407 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2408 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2409 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2410 and therefore cause GCC to emit a bogus diagnostic in some cases.
2412 * image.c: Integer signedness and overflow and related fixes.
2413 This is not an exhaustive set of fixes, but it's time to
2414 record what I've got.
2415 (lookup_pixel_color, check_image_size): Remove redundant decls.
2416 (check_image_size): Don't assume that arbitrary EMACS_INT values
2417 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2418 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2419 (tiff_load, imagemagick_load_image):
2420 Check for overflow in size calculations.
2421 (x_create_x_image_and_pixmap): Remove unnecessary test for
2422 xmalloc returning NULL; that can't happen.
2423 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2424 (xpm_color_bucket): Use better integer hashing function.
2425 (xpm_cache_color): Don't possibly over-allocate memory.
2426 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2427 (gif_memory_source):
2428 Use ptrdiff_t, not int or size_t, to record sizes.
2429 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2430 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2431 either works, as we prefer signed integers.
2432 (tiff_read_from_memory, tiff_write_from_memory):
2433 Return tsize_t, not size_t, since that's what the TIFF API wants.
2434 (tiff_read_from_memory): Don't fail simply because the read would
2435 go past EOF; instead, return a short read.
2436 (tiff_load): Omit no-longer-needed casts.
2437 (Fimagemagick_types): Don't assume size fits into 'int'.
2439 Improve hashing quality when configured --with-wide-int.
2440 * fns.c (hash_string): New function, taken from sxhash_string.
2441 Do not discard information about ASCII character case; this
2442 discarding is no longer needed.
2443 (sxhash-string): Use it. Change sig to match it. Caller changed.
2444 * lisp.h: Declare it.
2445 * lread.c (hash_string): Remove, since we now use fns.c's version.
2446 The fns.c version returns a wider integer if --with-wide-int is
2447 specified, so this should help the quality of the hashing a bit.
2449 * emacs.c: Integer overflow minor fix.
2450 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2451 Define only if GNU_LINUX.
2452 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2454 * dispnew.c: Integer signedness and overflow fixes.
2455 Remove unnecessary forward decls, that were a maintenance hassle.
2456 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2458 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2459 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2460 (prepare_desired_row, line_draw_cost):
2461 Use int, not unsigned, where either works.
2462 (save_current_matrix, restore_current_matrix):
2463 Use ptrdiff_t, not size_t, where either works.
2464 (init_display): Check for overflow more accurately, and without
2465 relying on undefined behavior.
2467 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2468 Remove, replacing with the new symbols in lisp.h. All uses changed.
2469 * fileio.c (make_temp_name):
2470 * filelock.c (lock_file_1, lock_file):
2471 * xdisp.c (message_dolog):
2472 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2473 Use pMd etc. instead.
2474 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2475 replacing the pWIDE etc. symbols removed from editfns.c.
2477 * keyboard.h (num_input_events): Now uintmax_t.
2478 This is (very slightly) less likely to mess up due to wraparound.
2481 * buffer.c: Integer signedness fixes.
2482 (alloc_buffer_text, enlarge_buffer_text):
2483 Use ptrdiff_t rather than size_t when either will do, as we prefer
2486 * alloc.c: Integer signedness and overflow fixes.
2487 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2488 (__malloc_size_t): Default to size_t, not to int.
2489 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2490 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2491 Prefer ptrdiff_t to size_t when either would do, as we prefer
2493 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2494 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2495 Now const. Initialize with values that are in range even if char
2497 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2498 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2499 These functions do the right thing with sizes > 2**32.
2500 (check_depth): Now ptrdiff_t, not int.
2501 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2502 Adjust to new way of storing sizes. Check for size overflow bugs
2504 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2505 slightly wrong anyway, as it missed one instance of
2506 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2507 (refill_memory_reserve): Omit needless cast to size_t.
2508 (mark_object_loop_halt): Mark as externally visible.
2510 * xselect.c: Integer signedness and overflow fixes.
2511 (Fx_register_dnd_atom, x_handle_dnd_message):
2512 Use ptrdiff_t, not size_t, since we prefer signed.
2513 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2514 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2515 x_dnd_atoms_size and x_dnd_atoms_length.
2517 * doprnt.c: Prefer signed to unsigned when either works.
2519 * doprnt.c (doprnt):
2521 * xdisp.c (vmessage):
2522 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2523 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2524 prefer signed arithmetic to avoid comparison confusion.
2525 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2526 but is a bit tricky.
2528 Assume freestanding C89 headers, string.h, stdlib.h.
2529 * data.c, doprnt.c, floatfns.c, print.c:
2530 Include float.h unconditionally.
2531 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2532 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2533 * regex.c: Likewise for stddef.h, string.h.
2534 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2535 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2536 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2537 (STDC_HEADERS): Remove obsolete defines.
2538 * sysdep.c: Include limits.h unconditionally.
2540 Assume support for memcmp, memcpy, memmove, memset.
2541 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2542 * regex.c (memcmp, memcpy):
2543 Remove; we assume C89 now.
2545 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2546 (__malloc_safe_bcopy): Remove; no longer needed.
2548 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
2549 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2550 well either way, and we prefer signed to unsigned.
2552 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2554 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2555 closes the connection while we're reading (bug#9182).
2557 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
2559 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2560 are specified (Bug#9168).
2562 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2564 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2565 Found by GCC static checking and --with-wide-int on a 32-bit host.
2567 2011-07-25 Eli Zaretskii <eliz@gnu.org>
2569 * xdisp.c (compute_display_string_pos): Fix logic of caching
2570 previous display string position. Initialize cached_prev_pos to
2571 -1. Fixes slow-down at the beginning of a buffer.
2573 2011-07-24 Eli Zaretskii <eliz@gnu.org>
2575 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2576 for attrs[LFACE_FONTSET_INDEX].
2578 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2580 * xml.c (parse_region): Remove unused local
2581 that was recently introduced.
2583 2011-07-23 Eli Zaretskii <eliz@gnu.org>
2585 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2586 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2588 * xdisp.c (move_it_in_display_line_to): Record the best matching
2589 position for TO_CHARPOS while scanning the line, and restore it on
2590 exit if none of the characters scanned was an exact match.
2591 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
2592 when exact match is impossible due to invisible text, and the
2593 lines are truncated.
2595 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2597 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2600 2011-07-22 Eli Zaretskii <eliz@gnu.org>
2602 Fix a significant slow-down of cursor motion with C-n, C-p,
2603 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2604 auto-repeat under bidi redisplay in fontified buffers.
2605 * xdisp.c (compute_stop_pos_backwards): New function.
2606 (next_element_from_buffer): Call compute_stop_pos_backwards to
2607 find a suitable prev_stop when we find ourselves before
2609 (reseat): Don't look for prev_stop, as that could mean a very long
2611 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2612 <cached_disp_overlay_modiff>: Cache for last found display string
2614 (compute_display_string_pos): Return the cached position if asked
2615 about the same buffer in the same area of character positions, and
2616 the buffer wasn't changed since the time the display string
2617 position was cached.
2619 2011-07-22 Eli Zaretskii <eliz@gnu.org>
2621 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2622 is an integer, which is important for empty lines. (Bug#9149)
2624 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
2626 * frame.c (Fmodify_frame_parameters): In tty case, update the
2627 default face if necessary (Bug#4238).
2629 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
2631 * editfns.c (Fstring_to_char): No need to explain what a character
2632 is in the docstring (Bug#6576).
2634 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2636 * xml.c (parse_region): Make sure we always return a tree.
2638 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2640 * xml.c (parse_region): If a document contains only comments,
2643 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2645 * xml.c (make_dom): Return comments, too.
2647 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2650 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2651 and the surrounding thread.
2652 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2653 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2654 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2656 * s/openbsd.h (BROKEN_SIGIO): Define.
2657 * unexelf.c (unexec) [__OpenBSD__]:
2658 Don't update the .mdebug section of the Alpha COFF symbol table.
2660 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2662 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2665 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2667 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2668 This fixes some race conditions on the permissions of any newly
2671 * alloc.c (valid_pointer_p): Use pipe, not open.
2672 This fixes some permissions issues when debugging.
2674 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2675 If fchown fails to set both uid and gid, try to set just gid,
2676 as that is sometimes allowed. Adjust the file's mode to eliminate
2677 setuid or setgid bits that are inappropriate if fchown fails.
2679 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2681 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2682 to compare Lisp_Objects.
2683 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2684 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2685 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2687 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2689 * lread.c (read_integer): Unread even EOF character.
2690 (read1): Likewise. Properly record start position of symbol.
2692 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2693 symbol character follows.
2695 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2697 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2698 This works around a problem with the previous change to Fcopy_file.
2699 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2700 and without this change, GCC might complain about discarding
2701 fchown's return value.
2703 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
2705 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2707 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2709 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2711 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2713 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2714 it's used from the C level.
2716 * process.c: Use the same condition for POLL_FOR_INPUT in both
2717 keyboard.c and process.c (bug#1858).
2719 2011-07-09 Lawrence Mitchell <wence@gmx.li>
2721 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2722 (Fgnutls_boot): Use it.
2724 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2726 * doc.c (Fsubstitute_command_keys): Revert last change.
2728 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2730 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2731 quotes the next character, and doesn't affect other longer
2732 sequences (bug#8935).
2734 * lread.c (syms_of_lread): Clarify that is isn't only
2735 `eval-buffer' and `eval-defun' that's affected by
2736 `lexical-binding' (bug#8460).
2738 2011-07-15 Eli Zaretskii <eliz@gnu.org>
2740 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
2741 bidi redisplay when a line includes both an image and is truncated.
2743 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2745 Fix minor problems found by static checking.
2746 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2747 (elsz): Now a signed constant, not a size_t var. We prefer signed
2748 types to unsigned, to avoid integer comparison confusion. Without
2749 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2750 "cannot optimize loop, the loop counter may overflow", a symptom
2752 * indent.c (Fvertical_motion): Mark locals as initialized.
2753 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2755 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2757 * search.c (Fre_search_backward): Mention `case-fold-search' in
2758 all the re_search_* functions (bug#8138).
2760 * keyboard.c (Fopen_dribble_file): Document when the file is
2763 2011-07-14 Eli Zaretskii <eliz@gnu.org>
2765 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2768 Support bidi reordering of display and overlay strings.
2769 * xdisp.c (compute_display_string_pos)
2770 (compute_display_string_end): Accept additional argument STRING.
2771 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2772 (reseat_to_string): Initialize bidi_it->string.s and
2773 bidi_it->string.schars.
2774 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
2775 NULL (avoids a crash in bidi_paragraph_init).
2776 Initialize itb.string.lstring.
2777 (init_iterator): Call bidi_init_it only of a valid
2778 buffer position was specified. Initialize paragraph_embedding to
2780 (reseat_to_string): Initialize the bidi iterator.
2781 (display_string): If we need to ignore text properties of
2782 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2783 original value of -1 will not work with bidi.)
2784 (compute_display_string_pos): First arg is now struct
2785 `text_pos *'; all callers changed. Support display properties on
2787 (compute_display_string_end): Support display properties on Lisp
2789 (init_iterator, reseat_1, reseat_to_string): Initialize the
2790 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2791 when iterating on a string not from display properties).
2792 (compute_display_string_pos, compute_display_string_end):
2793 Fix calculation of the object to scan. Fixes an error when using
2795 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
2796 base_level_stop; instead, set base_level_stop to BEGV.
2797 Fixes crashes in vertical-motion.
2798 (next_element_from_buffer): Improve commentary for when
2799 the iterator is before prev_stop.
2800 (init_iterator): Initialize bidi_p from the default value of
2801 bidi-display-reordering, not from buffer-local value. Use the
2802 buffer-local value only if initializing for buffer iteration.
2803 (handle_invisible_prop): Support invisible properties on strings
2804 that are being bidi-reordered.
2805 (set_iterator_to_next): Support bidi reordering of C strings and
2807 (next_element_from_string): Support bidi reordering of Lisp
2809 (handle_stop_backwards): Support Lisp strings as well.
2810 (display_string): Support display of R2L glyph rows.
2811 Use IT_STRING_CHARPOS when displaying from a Lisp string.
2812 (init_iterator): Don't initialize it->bidi_p for strings
2814 (reseat_to_string): Initialize it->bidi_p for strings here.
2815 (next_element_from_string, next_element_from_c_string)
2816 (next_element_from_buffer): Add xassert's for correspondence
2817 between IT's object being iterated and it->bidi_it.string
2819 (face_before_or_after_it_pos): Support bidi iteration.
2820 (next_element_from_c_string): Handle the case of the first string
2821 character that is not the first one in the visual order.
2822 (get_visually_first_element): New function, refactored from common
2823 parts of next_element_from_buffer, next_element_from_string, and
2824 next_element_from_c_string.
2825 (tool_bar_lines_needed, redisplay_tool_bar)
2826 (display_menu_bar): Force left-to-right direction. Add a FIXME
2827 comment for making that be controlled by a user option.
2828 (push_it, pop_it): Save and restore the state of the
2829 bidi iterator. Save and restore the bidi_p flag.
2830 (pop_it): Iterate out of display property for string iteration as
2832 (iterate_out_of_display_property): Support iteration over strings.
2833 (handle_single_display_spec): Set up it->bidi_it for iteration
2834 over a display string, and call bidi_init_it.
2835 (handle_single_display_spec, next_overlay_string)
2836 (get_overlay_strings_1, push_display_prop): Set up the bidi
2837 iterator for displaying display or overlay strings.
2838 (forward_to_next_line_start): Don't use the shortcut if
2840 (back_to_previous_visible_line_start): If handle_display_prop
2841 pushed the iterator stack, restore the internal state of the bidi
2842 iterator by calling bidi_pop_it same number of times.
2843 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2844 and we are bidi-iterating, don't decrement the iterator position;
2845 instead, set the first_elt flag in the bidi iterator, to produce
2847 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2848 (push_display_prop): xassert that we are iterating a buffer.
2849 (push_it, pop_it): Save and restore paragraph_embedding member.
2850 (handle_single_display_spec, next_overlay_string)
2851 (get_overlay_strings_1, reseat_1, reseat_to_string)
2852 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2853 correctly. Don't assume unibyte strings are not bidi-reordered.
2854 (compute_display_string_pos)
2855 (compute_display_string_end): Fix handling the case of C string.
2856 (push_it, pop_it): Save and restore from_disp_prop_p.
2857 (handle_single_display_spec, push_display_prop): Set the
2858 from_disp_prop_p flag.
2859 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2860 (pop_it): Call iterate_out_of_display_property only if we are
2861 popping after iteration over a string that came from a display
2862 property. Fix a typo in popping stretch info. Add an assertion
2863 for verifying that the iterator position is in sync with the bidi
2865 (handle_single_display_spec, get_overlay_strings_1)
2866 (push_display_prop): Fix initialization of paragraph direction for
2867 string when that of the parent object is not yet determined.
2868 (reseat_1): Call bidi_init_it to resync the bidi
2869 iterator with IT's position. (Bug#7616)
2870 (find_row_edges): If ROW->start.pos gives position
2871 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2872 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2873 Reset the from_disp_prop_p flag.
2874 (SAVE_IT, RESTORE_IT): New macros.
2875 (pos_visible_p, face_before_or_after_it_pos)
2876 (back_to_previous_visible_line_start)
2877 (move_it_in_display_line_to, move_it_in_display_line)
2878 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2879 (try_scrolling, redisplay_window, display_line): Use them when
2880 saving a temporary copy of the iterator and restoring it back.
2881 (back_to_previous_visible_line_start, reseat_1)
2882 (init_iterator): Empty the bidi cache "stack".
2883 (move_it_in_display_line_to): If iterator ended up at
2884 EOL, but we never saw any buffer positions smaller than
2885 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2886 motion in bidi-reordered lines.
2887 (move_it_in_display_line_to): Record prev_method and prev_pos
2888 immediately before the call to set_iterator_to_next. Fixes cursor
2889 motion in bidi-reordered lines with stretch glyphs and strings
2890 displayed in margins. (Bug#8133) (Bug#8867)
2891 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2893 (pos_visible_p): Support positions in bidi-reordered lines.
2894 Save and restore bidi cache.
2896 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2897 (bidi_paragraph_info): Delete unused struct.
2898 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2899 (bidi_cache_start): New variable.
2900 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2902 (bidi_cache_fetch_state, bidi_cache_search)
2903 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2904 (bidi_cache_find, bidi_peek_at_next_level)
2905 (bidi_level_of_next_char, bidi_find_other_level_edge)
2906 (bidi_move_to_visually_next): Compare cache index with
2907 bidi_cache_start rather than with zero.
2908 (bidi_fetch_char): Accept new argument STRING; all callers
2909 changed. Support iteration over a string. Support strings with
2910 display properties. Support unibyte strings. Fix the type of
2911 `len' according to what STRING_CHAR_AND_LENGTH expects.
2912 (bidi_paragraph_init, bidi_resolve_explicit_1)
2913 (bidi_resolve_explicit, bidi_resolve_weak)
2914 (bidi_level_of_next_char, bidi_move_to_visually_next):
2915 Support iteration over a string.
2916 (bidi_set_sor_type, bidi_resolve_explicit_1)
2917 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2918 can now be zero (for strings); special values 0 and -1 were
2919 changed to -1 and -2, respectively.
2920 (bidi_char_at_pos): New function.
2921 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2922 Call it instead of FETCH_MULTIBYTE_CHAR.
2923 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2924 initialized to valid values.
2925 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2927 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2928 the test for valid cached positions. Fix the logic for looking up
2929 the sentinel state in the cache. GCPRO the Lisp string we are
2931 (bidi_push_it, bidi_pop_it): New functions.
2932 (bidi_initialize): Initialize the bidi cache start stack pointer.
2933 (bidi_cache_ensure_space): New function, refactored from part of
2934 bidi_cache_iterator_state. Don't assume the required size is just
2935 one BIDI_CACHE_CHUNK away.
2936 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2937 (bidi_count_bytes, bidi_char_at_pos): New functions.
2938 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2939 always valid if bidi_cache_idx is valid.
2940 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2941 is valid if it's going to be used.
2942 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2943 (bidi_cache_fetch_state, bidi_cache_search)
2944 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2945 (bidi_cache_iterator_state, bidi_cache_find)
2946 (bidi_find_other_level_edge, bidi_cache_start_stack):
2947 All variables related to cache indices are now EMACS_INT.
2949 * dispextern.h (struct bidi_string_data): New structure.
2950 (struct bidi_it): New member `string'. Make flag members be 1-bit
2951 fields, and put them last in the struct.
2952 (compute_display_string_pos, compute_display_string_end):
2954 (bidi_push_it, bidi_pop_it): Add prototypes.
2955 (struct iterator_stack_entry): New members bidi_p,
2956 paragraph_embedding, and from_disp_prop_p.
2957 (struct it): Member bidi_p is now a bit field 1 bit wide.
2958 (bidi_shelve_cache, bidi_unshelve_cache):
2961 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2962 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2963 and vector-like objects.
2965 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2966 cache around display iteration.
2968 * window.c (Fwindow_end, window_scroll_pixel_based)
2969 (displayed_window_lines, Frecenter): Save and restore the bidi
2970 cache around display iteration.
2972 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2974 * editfns.c (Fdelete_region): Clarify the use of the named
2975 parameters (bug#6788).
2977 2011-07-14 Martin Rudalics <rudalics@gmx.at>
2979 * indent.c (Fvertical_motion): Set and restore w->pointm when
2980 saving and restoring the window's buffer (Bug#9006).
2982 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2984 * editfns.c (Fstring_to_char): Clarify just what is returned
2985 (bug#6576). Text by Eli Zaretskii.
2987 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
2989 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2991 2011-07-13 Eli Zaretskii <eliz@gnu.org>
2993 * buffer.c (mmap_find): Fix a typo.
2995 2011-07-13 Johan Bockgård <bojohan@gnu.org>
2997 Fix execution of x selection hooks.
2998 * xselect.c (Qx_lost_selection_functions)
2999 (Qx_sent_selection_functions): New vars.
3000 (syms_of_xselect): DEFSYM them.
3001 (x_handle_selection_request): Pass Qx_sent_selection_functions
3002 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3003 (x_handle_selection_clear,x_clear_frame_selections):
3004 Pass Qx_lost_selection_functions rather than
3005 Vx_lost_selection_functions to Frun_hook_with_args.
3007 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3009 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
3010 The old code sometimes used this field without initializing it.
3012 * alloc.c (gc_sweep): Don't read past end of array.
3013 In theory, the old code could also have corrupted Emacs internals,
3014 though it'd be very unlikely.
3016 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3018 * character.c (Fcharacterp): Don't advertise optional ignored
3019 argument. (Bug#4026)
3021 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3023 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3026 * window.c (Fset_window_start): Doc fix (bug#4199).
3027 (Fset_window_hscroll): Ditto.
3029 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3031 Fix minor new problems caught by GCC 4.6.1.
3032 * term.c (init_tty): Remove unused local.
3033 * xsettings.c (store_monospaced_changed): Define this function only
3034 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
3037 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
3039 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3041 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3043 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3044 are the mini-buffer and the echo area (bug#3320).
3046 * term.c (init_tty): Remove support for supdup, c10 and perq
3047 terminals, which are no longer supported (bug#1482).
3049 2011-07-10 Johan Bockgård <bojohan@gnu.org>
3051 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3053 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3055 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3056 for non-popups (Bug#3642).
3058 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3060 * alloc.c (reset_malloc_hooks): Protoize.
3061 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
3062 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3063 * cm.c (losecursor): Likewise.
3064 * data.c (fmod): Likewise.
3065 * dispnew.c (swap_glyphs_in_rows): Likewise.
3066 * emacs.c (memory_warning_signal): Likewise.
3067 * floatfns.c (float_error): Likewise.
3068 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3069 (otf_open, font_otf_capability, generate_otf_features)
3070 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3072 * image.c (pbm_read_file): Likewise.
3073 * indent.c (string_display_width): Likewise.
3074 * intervals.c (check_for_interval, search_for_interval)
3075 (inc_interval_count, count_intervals, root_interval)
3076 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3077 * lread.c (defalias): Likewise.
3078 * ralloc.c (r_alloc_check): Likewise.
3079 * regex.c (set_image_of_range_1, set_image_of_range)
3080 (regex_grow_registers): Likewise.
3081 * sysdep.c (strerror): Likewise.
3082 * termcap.c (valid_filename_p, tprint, main): Likewise.
3083 * tparam.c (main): Likewise.
3084 * unexhp9k800.c (run_time_remap, save_data_space)
3085 (update_file_ptrs, read_header, write_header, calculate_checksum)
3086 (copy_file, copy_rest, display_header): Likewise.
3087 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3089 * xdisp.c (check_it): Likewise.
3090 * xfaces.c (register_color, unregister_color, unregister_colors):
3092 * xfns.c (print_fontset_result): Likewise.
3093 * xrdb.c (member, fatal, main): Likewise.
3095 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3097 Fix minor problems found by static checking (Bug#9031).
3098 * chartab.c (char_table_set_range, map_sub_char_table):
3099 Remove unused locals.
3100 (uniprop_table): Now static.
3101 * composite.c (_work_char): Remove unused static var.
3103 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
3105 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3107 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3109 * gtkutil.c (qttip_cb): Remove code without function.
3111 2011-07-09 Eli Zaretskii <eliz@gnu.org>
3113 * w32.c (pthread_sigmask): New stub.
3115 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
3117 Use pthread_sigmask, not sigprocmask (Bug#9010).
3118 sigprocmask is portable only for single-threaded applications, and
3119 Emacs can be multi-threaded when it uses GTK.
3120 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3122 * callproc.c (Fcall_process):
3123 * process.c (create_process):
3124 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3125 Use pthread_sigmask, not sigprocmask.
3127 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3129 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3130 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3133 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3135 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3136 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3137 (xg_hide_tooltip): Fix comment.
3139 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3140 in registerServicesMenuSendTypes.
3141 (validRequestorForSendType): Don't check ns_return_types.
3143 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3146 2011-07-08 Jason Rumney <jasonr@gnu.org>
3148 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3149 SH_SHOW for hidden windows (Bug#5482).
3151 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3152 frame struct members of non-existent frames (Bug#6284).
3154 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3156 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3157 variable firstTime not needed on OSX >= 10.6.
3158 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3159 >= 10.5. Use setKnobProportion, setDoubleValue.
3161 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3162 (MAC_OS_X_VERSION_10_5): Define if not defined.
3163 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3164 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3165 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3167 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3168 cString and lossyCString on OSX >= 10.4
3170 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
3171 sizeToFit on OSX >= 10.2.
3173 * nsimage.m (allocInitFromFile): Don't use deprecated method
3174 bestRepresentationForDevice on OSX >= 10.6.
3176 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3179 * emacs.c: Declare unexec_init_emacs_zone.
3181 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3183 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3185 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3186 on svcsMenu (Bug#8842).
3188 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3190 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3192 * nsterm.m (QUTF8_STRING): Declare.
3193 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3194 (validRequestorForSendType): Return type is (id).
3195 Change indexOfObjectIdenticalTo to indexOfObject.
3196 Check if we have local selection before returning self (Bug#8842).
3197 (writeSelectionToPasteboard): Put local selection into paste board
3198 if we have a local selection (Bug#8842).
3199 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3201 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3202 (ns_get_local_selection): Declare.
3204 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3206 * keymap.c (describe_map_tree): Don't insert a double newline at
3207 the end of the buffer (bug#1169) and return whether we inserted
3210 * callint.c (Fcall_interactively): Change "reading args" to
3211 "providing args" to try to clarify what it does (bug#1010).
3213 2011-07-07 Kenichi Handa <handa@m17n.org>
3215 * composite.c (composition_compute_stop_pos): Ignore a static
3216 composition starting before CHARPOS (Bug#8915).
3218 * xdisp.c (handle_composition_prop): Likewise.
3220 2011-07-07 Eli Zaretskii <eliz@gnu.org>
3222 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3225 2011-07-07 Kenichi Handa <handa@m17n.org>
3227 * character.h (unicode_category_t): New enum type.
3229 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3230 (Qchar_code_property_table): New variable.
3231 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3232 (UNIPROP_COMPRESSED_FORM_P): New macros.
3233 (char_table_ascii): Uncompress the compressed values.
3234 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3235 Uncompress the compressed values.
3236 (sub_char_table_ref_and_range): Likewise.
3237 (char_table_ref_and_range): Uncompress the compressed values.
3238 (sub_char_table_set): New arg is_uniprop. Callers changed.
3239 Uncompress the compressed values.
3240 (sub_char_table_set_range): Args changed. Callers changed.
3241 (char_table_set_range): Adjuted for the above change.
3242 (map_sub_char_table): Delete args default_val and parent. Add arg
3243 top. Give decoded values to a Lisp function.
3244 (map_char_table): Adjust for the above change. Give decoded
3245 values to a Lisp function. Gcpro more variables.
3246 (uniprop_table_uncompress)
3247 (uniprop_decode_value_run_length): New functions.
3248 (uniprop_decoder, uniprop_decoder_count): New variables.
3249 (uniprop_get_decoder, uniprop_encode_value_character)
3250 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3252 (uniprop_encoder, uniprop_encoder_count): New variables.
3253 (uniprop_get_encoder, uniprop_table)
3254 (Funicode_property_table_internal, Fget_unicode_property_internal)
3255 (Fput_unicode_property_internal): New functions.
3256 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3257 Sunicode_property_table_internal, Sget_unicode_property_internal,
3258 and Sput_unicode_property_internal. Defvar_lisp
3259 char-code-property-alist.
3261 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
3262 Vunicode_category_table.
3264 * font.c (font_range): Adjust for the change of
3265 Vunicode_category_table.
3267 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3269 * m/iris4d.h: Remove file, move contents ...
3270 * s/irix6-5.h: ... here.
3272 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3274 Remove unportable assumption about struct layout (Bug#8884).
3275 * alloc.c (mark_buffer):
3276 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3277 (clone_per_buffer_values): Don't assume that
3278 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3279 This isn't true in general, and it's particularly not true
3280 if Emacs is configured with --with-wide-int.
3281 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3282 New macros, used in the buffer.c change.
3284 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3286 * xsettings.c: Use both GConf and GSettings if both are available.
3287 (store_config_changed_event): Add comment.
3288 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3289 (store_tool_bar_style_changed): New functions.
3290 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
3291 (struct xsettings): Move font inside HAVE_XFT.
3292 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
3293 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
3294 Move inside HAVE_XFT.
3295 (something_changed_gsettingsCB): Rename from something_changedCB.
3296 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3298 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
3299 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
3300 (something_changed_gconfCB): Rename from something_changedCB.
3301 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3302 (parse_settings): Move check for font inside HAVE_XFT.
3303 (read_settings, apply_xft_settings): Add comment.
3304 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3305 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3306 call store_font_name_changed.
3307 (xft_settings_event): Add comment.
3308 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3309 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3310 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3311 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3312 (xsettings_initialize): Call init_gsettings last.
3313 (xsettings_get_system_font, xsettings_get_system_normal_font):
3316 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3318 Random fixes. E.g., (random) never returned negative values.
3319 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3320 subseconds part to the entropy, as that's a bit more random.
3321 Prefer signed to unsigned, since the signedness doesn't matter and
3322 in general we prefer signed. When given a limit, use a
3323 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3324 latter isn't right if USE_2_TAGS_FOR_INTS.
3325 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3326 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3328 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3330 * textprop.c (text_property_stickiness):
3331 Obey Vtext_property_default_nonsticky.
3332 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3333 * w32fns.c (syms_of_w32fns):
3334 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3336 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3338 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3339 This is more efficient than Ffile_directory_p and avoids a minor race.
3341 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3343 * buffer.c (Foverlay_put): Say what the return value is
3346 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3347 is a directory before asking whether to use the file name
3349 (barf_or_query_if_file_exists): Make the "File is a directory"
3350 error be more correct.
3352 * fns.c (Frequire): Remove the mention of the .gz files, since
3353 that's installation-specific, but keep the mention of
3354 `get-load-suffixes'.
3356 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3358 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3359 Report string overflow if the output is too long.
3361 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
3363 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3364 (syms_of_gnutls): Remove duplicate DEFSYM for
3365 Qgnutls_bootprop_verify_hostname_error, an error for
3366 Qgnutls_bootprop_verify_error (which is no longer used).
3368 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3369 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3370 Also (re)move comments that are misplaced or no longer relevant.
3372 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3374 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3376 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
3378 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3379 and background color parameters if they have been changed.
3381 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3383 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3385 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3387 * xsettings.c (SYSTEM_FONT): Define only when used.
3388 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3390 * keymap.c (access_keymap_1): Now static.
3392 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
3394 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3395 leave any prefix arg for the up event (Bug#1586).
3397 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3399 * lread.c (syms_of_lread): Mention single symbols defined by
3400 `defvar' or `defconst' (bug#7154).
3402 * fns.c (Frequire): Mention .el.gz files (bug#7314).
3403 (Frequire): Mention get-load-suffixes.
3405 2011-07-02 Martin Rudalics <rudalics@gmx.at>
3407 * window.h (window): Remove clone_number slot.
3408 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3410 (make_parent_window, make_window, saved_window)
3411 (Fset_window_configuration, save_window_save): Don't deal with
3413 * buffer.c (Qclone_number): Remove declaration.
3414 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3416 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3418 Add multiple inheritance to keymaps.
3419 * keymap.c (Fmake_composed_keymap): New function.
3420 (Fset_keymap_parent): Simplify.
3421 (fix_submap_inheritance): Remove.
3422 (access_keymap_1): New function extracted from access_keymap to handle
3423 embedded parents and handle lists of maps.
3424 (access_keymap): Use it.
3425 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3426 (Fcopy_keymap): Handle embedded parents.
3427 (Fcommand_remapping, define_as_prefix): Simplify.
3428 (Fkey_binding): Simplify.
3429 (syms_of_keymap): Move minibuffer-local-completion-map,
3430 minibuffer-local-filename-completion-map,
3431 minibuffer-local-must-match-map, and
3432 minibuffer-local-filename-must-match-map to Elisp.
3433 (syms_of_keymap): Defsubr make-composed-keymap.
3434 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3435 (parse_menu_item): Trivial simplification.
3437 2011-07-01 Glenn Morris <rgm@gnu.org>
3439 * Makefile.in (SETTINGS_LIBS): Fix typo.
3441 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3443 * coding.c (Fencode_coding_string): Record the last coding system
3444 used, as the function doc string says (bug#8738).
3446 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3448 * xsettings.c (store_monospaced_changed): Take new font as arg and
3449 check for change against current_mono_font.
3450 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3451 (emacs_settings_constructor, emacs_settings_get_property)
3452 (emacs_settings_set_property, emacs_settings_class_init)
3453 (emacs_settings_init, gsettings_obj): Remove.
3454 (something_changedCB): New function for HAVE_GSETTINGS.
3455 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3456 with value as argument.
3457 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3458 g_settings_new (Bug#8967). Do not create gsettings_obj.
3459 Remove calls to g_settings_bind. Connect something_changedCB to
3462 * xgselect.c: Add defined (HAVE_GSETTINGS).
3463 (xgselect_initialize): Ditto.
3465 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3466 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3469 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3471 * eval.c (struct backtrace): Simplify and port the data structure.
3472 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3473 signed bit field, as this assumption is not portable and it makes
3474 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3475 "char debug_on_exit : 1" as this is not portable either; instead,
3476 use the portable "unsigned int debug_on_exit : 1". Remove unused
3477 member evalargs. Remove obsolete comments about cc bombing out.
3479 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3481 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
3482 Let HAVE_GSETTINGS override HAVE_GCONF.
3483 (store_monospaced_changed): New function.
3484 (EMACS_SETTINGS): A new type derived from GObject to handle
3485 GSettings notifications.
3486 (emacs_settings_constructor, emacs_settings_get_property)
3487 (emacs_settings_set_property, emacs_settings_class_init):
3489 (gsettings_client, gsettings_obj): New variables.
3490 (GSETTINGS_SCHEMA): New define.
3491 (something_changedCB): Call store_monospaced_changed.
3492 (init_gsettings): New function.
3493 (xsettings_initialize): Call init_gsettings.
3494 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3497 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
3500 2011-06-29 Martin Rudalics <rudalics@gmx.at>
3502 * window.c (resize_root_window, grow_mini_window)
3503 (shrink_mini_window): Rename Qresize_root_window to
3504 Qwindow_resize_root_window and Qresize_root_window_vertically to
3505 Qwindow_resize_root_window_vertically.
3507 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3509 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3511 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
3513 * makefile.w32-in: Redesign dependencies so they reflect more
3514 clearly which files are directly included by each source file,
3515 and not through other includes.
3517 2011-06-27 Martin Rudalics <rudalics@gmx.at>
3519 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3520 (sort_overlays, overlay_strings): When an overlay's clone number
3521 matches the window's clone number process the overlay even if
3522 the overlay's window property doesn't match the current window.
3524 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3525 (Fwindow_hchild): Rename to Fwindow_left_child.
3526 (Fwindow_next): Rename to Fwindow_next_sibling.
3527 (Fwindow_prev): Rename to Fwindow_prev_sibling.
3528 (resize_window_check): Rename to window_resize_check.
3529 (resize_window_apply): Rename to window_resize_apply.
3530 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3531 (Fdelete_other_windows_internal, resize_frame_windows)
3532 (Fsplit_window_internal, Fdelete_window_internal)
3533 (grow_mini_window, shrink_mini_window)
3534 (Fresize_mini_window_internal): Fix callers accordingly.
3536 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3538 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3539 (emacs_fixed_set_min_size): Remove.
3540 (emacs_fixed_new): Take frame as argument.
3542 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3543 (_EmacsFixedPrivate): Remove minwidth/height.
3544 Add struct frame *f.
3545 (emacs_fixed_init): Initialize priv->f.
3546 (get_parent_class, emacs_fixed_set_min_size): Remove.
3547 (emacs_fixed_new): Set priv->f to argument.
3548 (emacs_fixed_get_preferred_width)
3549 (emacs_fixed_get_preferred_height): Use min_width/height from
3550 frames size_hint to set minimum and natural (Bug#8919).
3551 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3552 and use min_width/height from frames size_hint to set
3553 min_width/height (Bug#8919).
3555 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
3556 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3559 2011-06-26 Eli Zaretskii <eliz@gnu.org>
3561 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3562 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3565 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
3567 * process.c (wait_reading_process_output): Bypass select if
3568 waiting for a cell while ignoring keyboard input, and input is
3569 pending. Suggested by Jan Djärv (Bug#8869).
3571 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3573 Use gnulib's dup2 module instead of rolling our own.
3574 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3576 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3578 * dispnew.c (scrolling_window): Before scrolling, turn off a
3579 mouse-highlight in the window being scrolled.
3581 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
3583 Move DEFSYM to lisp.h and use everywhere.
3585 * character.h (DEFSYM): Move declaration...
3586 * lisp.h (DEFSYM): ...here.
3592 * w32select.c: Don't include character.h.
3594 * alloc.c (syms_of_alloc):
3595 * buffer.c (syms_of_buffer):
3596 * bytecode.c (syms_of_bytecode):
3597 * callint.c (syms_of_callint):
3598 * casefiddle.c (syms_of_casefiddle):
3599 * casetab.c (init_casetab_once):
3600 * category.c (init_category_once, syms_of_category):
3601 * ccl.c (syms_of_ccl):
3602 * cmds.c (syms_of_cmds):
3603 * composite.c (syms_of_composite):
3604 * dbusbind.c (syms_of_dbusbind):
3605 * dired.c (syms_of_dired):
3606 * dispnew.c (syms_of_display):
3607 * doc.c (syms_of_doc):
3608 * editfns.c (syms_of_editfns):
3609 * emacs.c (syms_of_emacs):
3610 * eval.c (syms_of_eval):
3611 * fileio.c (syms_of_fileio):
3612 * fns.c (syms_of_fns):
3613 * frame.c (syms_of_frame):
3614 * fringe.c (syms_of_fringe):
3615 * insdel.c (syms_of_insdel):
3616 * keymap.c (syms_of_keymap):
3617 * lread.c (init_obarray, syms_of_lread):
3618 * macros.c (syms_of_macros):
3619 * msdos.c (syms_of_msdos):
3620 * print.c (syms_of_print):
3621 * process.c (syms_of_process):
3622 * search.c (syms_of_search):
3623 * sound.c (syms_of_sound):
3624 * syntax.c (init_syntax_once, syms_of_syntax):
3625 * terminal.c (syms_of_terminal):
3626 * textprop.c (syms_of_textprop):
3627 * undo.c (syms_of_undo):
3628 * w32.c (globals_of_w32):
3629 * window.c (syms_of_window):
3630 * xdisp.c (syms_of_xdisp):
3631 * xfaces.c (syms_of_xfaces):
3632 * xfns.c (syms_of_xfns):
3633 * xmenu.c (syms_of_xmenu):
3634 * xsettings.c (syms_of_xsettings):
3635 * xterm.c (syms_of_xterm): Use DEFSYM.
3637 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3639 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
3641 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3643 Integer and buffer overflow fixes (Bug#8873).
3645 * print.c (printchar, strout): Check for string overflow.
3646 (PRINTPREPARE, printchar, strout):
3647 Don't set size unless allocation succeeds.
3649 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3650 for sizes. Check for string overflow more accurately.
3651 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3653 * macros.c: Integer and buffer overflow fixes.
3654 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3655 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3656 Use ptrdiff_t, not int, for sizes.
3657 Don't increment bufsize until after realloc succeeds.
3658 Check for size-calculation overflow.
3659 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3661 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3663 * lread.c: Integer overflow fixes.
3664 (read_integer): Radix is now EMACS_INT, not int,
3665 to improve quality of diagnostics for out-of-range radices.
3666 Calculate buffer size correctly for out-of-range radices.
3667 (read1): Check for integer overflow in radices, and in
3668 read-circle numbers.
3669 (read_escape): Avoid int overflow.
3670 (Fload, openp, read_buffer_size, read1)
3671 (substitute_object_recurse, read_vector, read_list, map_obarray):
3672 Use ptrdiff_t, not int, for sizes.
3673 (read1): Use EMACS_INT, not int, for sizes.
3674 Check for size overflow.
3676 * image.c (cache_image): Check for size arithmetic overflow.
3678 * lread.c: Integer overflow issues.
3679 (saved_doc_string_size, saved_doc_string_length)
3680 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3681 Now ptrdiff_t, not int.
3682 (read1): Don't assume doc string length fits in int. Check for
3683 out-of-range doc string lengths.
3684 (read_list): Don't assume file position fits in int.
3685 (read_escape): Check for hex character overflow.
3687 2011-06-22 Leo Liu <sdl.web@gmail.com>
3689 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3690 Move to minibuffer.el.
3692 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3694 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
3695 The following patches are for when GLYPH_DEBUG && !XASSERT.
3696 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3697 * dispnew.c (flush_stdout):
3698 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3699 Mark as externally visible.
3700 * dispnew.c (check_window_matrix_pointers): Now static.
3701 * dispnew.c (window_to_frame_vpos):
3702 * xfns.c (unwind_create_frame):
3703 * xterm.c (x_check_font): Remove unused local.
3704 * scroll.c (CHECK_BOUNDS):
3705 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3706 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3707 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3708 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3709 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3711 (debug_method_add): Use va_list and vsprintf rather than relying
3712 on undefined behavior with wrong number of arguments.
3713 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3714 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3715 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3716 since we're not interested in debugging glyphs with old libraries.
3717 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3718 GCC 4.6.0's static checking.
3720 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3722 Integer overflow and signedness fixes (Bug#8873).
3723 A few related buffer overrun fixes, too.
3725 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3727 * dispextern.h (struct face.stipple):
3728 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3729 (x_bitmap_mask, x_allocate_bitmap_record)
3730 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3731 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3732 (x_create_bitmap_from_xpm_data):
3733 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3734 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3736 * xfaces.c (load_pixmap):
3737 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3738 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3739 (.bitmaps_last, struct x_output.icon_bitmap):
3740 Use ptrdiff_t, not int, for bitmap indexes.
3741 (x_allocate_bitmap_record): Check for size overflow.
3742 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3744 Use ptrdiff_t, not int, for overlay counts.
3745 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3746 * editfns.c (overlays_around, get_pos_property):
3747 * textprop.c (get_char_property_and_overlay):
3748 * xdisp.c (next_overlay_change, note_mouse_highlight):
3749 * xfaces.c (face_at_buffer_position):
3750 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3751 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3752 (Fnext_overlay_change, Fprevious_overlay_change)
3753 (mouse_face_overlay_overlaps, Foverlays_in):
3754 Use ptrdiff_t, not int, for sizes.
3755 (overlays_at, overlays_in): Check for size-calculation overflow.
3757 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3759 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3760 (x_session_initialize): Do not assume string length fits in int.
3762 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3763 This is unlikely, but can occur if DPI is outlandish.
3765 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3766 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3768 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3769 * xrdb.c (magic_file_p, search_magic_path):
3770 Omit last arg SUFFIX; it was always 0. All callers changed.
3771 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3773 * xfont.c (xfont_match): Avoid need for strlen.
3775 * xfns.c: Don't assume strlen fits in int.
3776 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3778 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3779 not unsigned long, as we prefer signed integers. All callers changed.
3780 Detect integer overflow in repeat count.
3781 (message_dolog): Don't assume print length fits in 39 bytes.
3782 (display_mode_element): Don't assume strlen fits in int.
3784 * termcap.c: Don't assume sizes fit in int and never overflow.
3785 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3786 (gobble_line): Check for size-calculation overflow.
3788 * minibuf.c (Fread_buffer):
3789 * lread.c (intern, intern_c_string):
3790 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3791 Don't assume string length fits in int.
3793 * keyboard.c (parse_tool_bar_item):
3794 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3796 * font.c: Don't assume string length fits in int.
3797 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3798 Use ptrdiff_t, not int.
3799 (font_intern_prop): Don't assume string length fits in int.
3800 Don't assume integer property fits in fixnum.
3801 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
3803 * filelock.c: Fix some buffer overrun and integer overflow issues.
3804 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
3805 Reformulate so as not to need the command string.
3806 Invoke gzip -cd rather than gunzip, as it's more portable.
3807 (lock_info_type, lock_file_1, lock_file):
3808 Don't assume pid_t and time_t fit in unsigned long.
3809 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3810 (current_lock_owner): Prefer signed type for sizes.
3811 Use memcpy, not strncpy, where memcpy is what is really wanted.
3812 Don't assume (via atoi) that time_t and pid_t fit in int.
3813 Check for time_t and/or pid_t out of range, e.g., via a network share.
3814 Don't alloca where an auto var works fine.
3816 * fileio.c: Fix some integer overflow issues.
3817 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3818 Don't assume string length fits in int.
3819 (directory_file_name): Don't assume string length fits in long.
3820 (make_temp_name): Don't assume pid fits in int, or that its print
3821 length is less than 20.
3823 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3825 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3827 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3829 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3830 We prefer signed integers, even for size calculations.
3832 * emacs.c: Don't assume string length fits in 'int'.
3833 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3834 (main): Don't invoke strlen when not needed.
3836 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3837 (XD_DEBUG_MESSAGE): Don't waste a byte.
3839 * callproc.c (getenv_internal_1, getenv_internal)
3841 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3843 * lread.c (invalid_syntax): Omit length argument.
3844 All uses changed. This doesn't fix a bug, but it simplifies the
3845 code away from its former Hollerith-constant appearance, and it's
3846 one less 'int' to worry about when looking at integer-overflow issues.
3847 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
3849 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3850 This didn't break anything, but it didn't help either.
3851 It's confusing to put a bogus integer in a place where the actual
3852 value does not matter.
3853 (LIST_END_P): Remove unused macro and its bogus comment.
3854 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
3856 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3857 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3859 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3860 We prefer signed types, and the value cannot exceed the EMACS_INT
3861 range anyway (because otherwise the length would not be representable).
3862 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3863 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3864 This avoids a GCC warning when WIDE_EMACS_INT.
3866 * indent.c (sane_tab_width): New function.
3867 (current_column, scan_for_column, Findent_to, position_indentation)
3868 (compute_motion): Use it. This is just for clarity.
3869 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
3871 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
3873 * lisp.h (lint_assume): New macro.
3874 * composite.c (composition_gstring_put_cache):
3875 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3877 * editfns.c, insdel.c:
3878 Omit unnecessary forward decls, to simplify future changes.
3880 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3882 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3884 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
3885 Use much-faster test for byte-length change.
3886 Don't assume string byte-length fits in 'int'.
3887 Check that character arg fits in 'int'.
3888 (mapcar1): Declare byte as byte, for clarity.
3890 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3892 * fns.c (concat): Catch string overflow earlier.
3893 Do not rely on integer wraparound.
3895 * dispextern.h (struct it.overlay_strings_charpos)
3896 (struct it.selective): Now EMACS_INT, not int.
3897 * xdisp.c (forward_to_next_line_start)
3898 (back_to_previous_visible_line_start)
3899 (reseat_at_next_visible_line_start, next_element_from_buffer):
3900 Don't arbitrarily truncate the value of 'selective' to int.
3902 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3904 * composite.c: Don't truncate sizes to 'int'.
3905 (composition_gstring_p, composition_reseat_it)
3906 (composition_adjust_point): Use EMACS_INT, not int.
3907 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3908 not EMACS_UINT, for indexes.
3910 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3912 * buffer.c: Include <verify.h>.
3913 (struct sortvec.priority, struct sortstr.priority):
3914 Now EMACS_INT, not int.
3915 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
3916 (struct sortstr.size, record_overlay_string)
3917 (struct sortstrlist.size, struct sortlist.used):
3918 Don't truncate size to int.
3919 (record_overlay_string): Check for size-calculation overflow.
3920 (init_buffer_once): Check at compile-time, not run-time.
3922 2011-06-22 Jim Meyering <meyering@redhat.com>
3924 Don't leak an XBM-image-sized buffer
3925 * image.c (xbm_load): Free the image buffer after using it.
3927 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3930 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3931 that Sun C diagnosed.
3932 * fns.c (secure_hash): Fix pointer signedness issue.
3933 * intervals.c (static_offset_intervals): New function.
3934 (offset_intervals): Use it.
3936 2011-06-21 Leo Liu <sdl.web@gmail.com>
3939 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3942 * fns.c (secure_hash): Rename from crypto_hash_function and change
3943 the first arg to accept symbols.
3944 (Fsecure_hash): New primitive.
3945 (syms_of_fns): New symbols.
3947 2011-06-20 Deniz Dogan <deniz@dogan.se>
3949 * process.c (Fset_process_buffer): Clarify return value in
3952 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
3954 * dispnew.c (add_window_display_history): Use BVAR.
3956 * xdisp.c (debug_method_add): Use BVAR.
3957 (check_window_end, dump_glyph_matrix, dump_glyph)
3958 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3960 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3963 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3964 check till after the cache is created in init_frame_faces.
3966 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3968 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3970 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3972 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3973 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3974 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3976 Improve buffer-overflow checking (Bug#8873).
3977 * fileio.c (Finsert_file_contents):
3978 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3979 Remove the old (too-loose) buffer overflow checks.
3980 They weren't needed, since make_gap checks for buffer overflow.
3981 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3982 The old code merely checked for Emacs fixnum overflow, and relied
3983 on undefined (wraparound) behavior. The new code avoids undefined
3984 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3986 * editfns.c (Finsert_char): Don't dump core with very negative counts.
3987 Tune. Don't use wider integers than needed. Don't use alloca.
3988 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
3990 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3992 * insdel.c, lisp.h (buffer_overflow): New function.
3993 (insert_from_buffer_1, replace_range, replace_range_2):
3994 * insdel.c (make_gap_larger):
3995 * editfns.c (Finsert_char):
3996 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3998 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4000 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4002 Integer overflow and signedness fixes (Bug#8873).
4004 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4005 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4007 * fileio.c: Don't assume EMACS_INT fits in off_t.
4008 (emacs_lseek): New static function.
4009 (Finsert_file_contents, Fwrite_region): Use it.
4010 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4012 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4014 * fns.c: Don't overflow int when computing a list length.
4015 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4016 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4017 truncation on 64-bit hosts. Check for QUIT every
4018 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4019 faster and is responsive enough.
4020 (Flength): Report an error instead of overflowing an integer.
4021 (Fsafe_length): Return a float if the value is not representable
4022 as a fixnum. This shouldn't happen except in contrived situations.
4023 (Fnthcdr, Fsort): Don't assume list length fits in int.
4024 (Fcopy_sequence): Don't assume vector length fits in int.
4026 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4027 (header_size, word_size): New constants.
4028 (allocate_vectorlike): Don't check size overflow here.
4029 (allocate_vector): Check it here instead, since this is the only
4030 caller of allocate_vectorlike that could cause overflow.
4031 Check that the new vector's length is representable as a fixnum.
4033 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4034 The previous code was bogus. For example, next_almost_prime (32)
4035 returned 39, which is undesirable as it is a multiple of 3; and
4036 next_almost_prime (24) returned 25, which is a multiple of 5 so
4037 why was the code bothering to check for multiples of 7?
4039 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4041 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4043 Variadic C functions now count arguments with ptrdiff_t.
4044 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4045 Back then I didn't know that the Emacs coding style prefers signed int.
4046 Also, in the meantime I found a few more instances where arguments
4047 were being counted with int, which may truncate counts on 64-bit
4048 machines, or EMACS_INT, which may be unnecessarily wide.
4049 * lisp.h (struct Lisp_Subr.function.aMANY)
4050 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4051 Arg counts are now ptrdiff_t, not size_t.
4052 All variadic functions and their callers changed accordingly.
4053 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4054 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4055 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4056 * callint.c (Fcall_interactively): Check arg count for overflow,
4057 to avoid potential buffer overrun. Use signed char, not 'int',
4058 for 'varies' array, so that we needn't bother to check its size
4059 calculation for overflow.
4060 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4061 * eval.c (apply_lambda):
4062 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4063 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4064 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4066 * callint.c (Fcall_interactively): Don't use index var as event count.
4068 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4069 * mem-limits.h (SIZE): Remove; no longer used.
4071 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
4073 Remove unnecessary casts.
4074 * xterm.c (x_term_init):
4075 * xfns.c (x_set_border_pixel):
4076 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4077 These aren't needed now that we assume ANSI C.
4079 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4080 It's more likely to cause problems (due to unsigned overflow)
4083 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4085 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4087 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4089 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4091 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4093 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4095 GLYPH_CODE_FACE returns EMACS_INT, not int.
4096 * dispextern.h (merge_faces):
4097 * xfaces.c (merge_faces):
4098 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4099 Don't assume EMACS_INT fits in int.
4101 * character.h (CHAR_VALID_P): Remove unused parameter.
4102 * fontset.c, lisp.h, xdisp.c: All uses changed.
4104 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4106 * fns.c (concat): Minor tuning based on overflow analysis.
4107 This doesn't fix any bugs. Use int to hold character, instead
4108 of constantly refetching from Emacs object. Use XFASTINT, not
4109 XINT, for value known to be a character. Don't bother comparing
4110 a single byte to 0400, as it's always less.
4112 * floatfns.c (Fexpt):
4113 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4115 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4118 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4120 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4121 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4122 incorrectly succeed when S was a string, because 4294967386 was
4123 truncated before it was used.
4125 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4126 Otherwise, an out-of-range integer could cause undefined behavior
4129 * composite.c: Use int, not EMACS_INT, for characters.
4130 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4131 EMACS_INT, for values that are known to be in character range.
4132 This doesn't fix any bugs but is the usual style inside Emacs and
4133 may generate better code on 32-bit machines.
4135 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4136 This is for reasons similar to the recent CHAR_STRING fix.
4137 * charset.c (Fencode_char): Check that character arg is actually
4138 a character. Pass an int to ENCODE_CHAR.
4139 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4140 wider than 'int', as a compile-time check to prevent future regressions
4143 * character.c (char_string): Remove unnecessary casts.
4145 Make sure a 64-bit char is never passed to CHAR_STRING.
4146 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4147 by silently ignoring the top 32 bits, allowing some values
4148 that were far too large to be valid characters.
4149 * character.h: Include <verify.h>.
4150 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4151 arguments are no wider than unsigned, as a compile-time check
4152 to prevent future regressions in this area.
4154 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
4155 (Fsubst_char_in_region):
4157 * xdisp.c (decode_mode_spec_coding):
4158 Adjust to CHAR_STRING's new requirement.
4159 * editfns.c (Finsert_char, Fsubst_char_in_region):
4160 * fns.c (concat): Check that character args are actually
4161 characters. Without this test, these functions did the wrong
4162 thing with wildly out-of-range values on 64-bit hosts.
4164 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4165 These casts should not be needed on 32-bit hosts, either.
4166 * keyboard.c (read_char):
4167 * lread.c (Fload): Remove casts to unsigned.
4169 * lisp.h (UNSIGNED_CMP): New macro.
4170 This fixes comparison bugs on 64-bit hosts.
4171 (ASCII_CHAR_P): Use it.
4172 * casefiddle.c (casify_object):
4173 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
4174 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4175 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4176 * dispextern.h (FACE_FROM_ID):
4177 * keyboard.c (read_char): Use UNSIGNED_CMP.
4179 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4180 not to EMACS_INT, to avoid GCC warning.
4182 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4184 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4185 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4186 isn't needed on 32-bit machines.
4188 * buffer.c (Fgenerate_new_buffer_name):
4189 Use EMACS_INT for count, not int.
4190 (advance_to_char_boundary): Return EMACS_INT, not int.
4192 * data.c (Qcompiled_function): Now static.
4194 * window.c (window_body_lines): Now static.
4196 * image.c (gif_load): Rename local to avoid shadowing.
4198 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4199 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4200 * alloc.c (make_save_value): Integer argument is now of type
4202 (mark_object): Use ptrdiff_t, not int.
4203 * lisp.h (pD): New macro.
4204 * print.c (print_object): Use it.
4206 * alloc.c: Use EMACS_INT, not int, to count objects.
4207 (total_conses, total_markers, total_symbols, total_vector_size)
4208 (total_free_conses, total_free_markers, total_free_symbols)
4209 (total_free_floats, total_floats, total_free_intervals)
4210 (total_intervals, total_strings, total_free_strings):
4211 Now EMACS_INT, not int. All uses changed.
4212 (Fgarbage_collect): Compute overall total using a double, so that
4213 integer overflow is less likely to be a problem. Check for overflow
4214 when converting back to an integer.
4215 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4216 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4217 These were 'int' variables that could overflow on 64-bit hosts;
4218 they were never used, so remove them instead of repairing them.
4219 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
4220 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4221 Previously, this ceilinged at INT_MAX, but that doesn't work on
4223 (allocate_pseudovector): Don't use EMACS_INT when int would do.
4225 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
4226 (allocate_vectorlike): Check for ptrdiff_t overflow.
4227 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4228 when a (possibly-narrower) signed value would do just as well.
4229 We prefer using signed arithmetic, to avoid comparison confusion.
4231 * alloc.c: Catch some string size overflows that we were missing.
4232 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4233 for convenience in STRING_BYTES_MAX.
4234 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4235 The definition here is exact; the one in lisp.h was approximate.
4236 (allocate_string_data): Check for string overflow. This catches
4237 some instances we weren't catching before. Also, it catches
4238 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4239 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4240 and ptrdiff_t and EMACS_INT are both 64 bits.
4242 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4243 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
4244 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
4246 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4248 * alloc.c (Fmake_string): Check for out-of-range init.
4250 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4252 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4254 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4256 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4257 xg_get_default_scrollbar_width.
4259 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4260 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4261 (style_changed_cb): Call update_theme_scrollbar_width and call
4262 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4263 all frames (Bug#8505).
4264 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4265 Call gtk_window_set_resizable if HAVE_GTK3.
4266 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4267 and height if HAVE_GTK3 (Bug#8505).
4268 (scroll_bar_width_for_theme): New variable.
4269 (update_theme_scrollbar_width): New function.
4270 (xg_get_default_scrollbar_width): Move code to
4271 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4272 (xg_initialize): Call update_theme_scrollbar_width.
4274 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4276 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4278 2011-06-12 Martin Rudalics <rudalics@gmx.at>
4280 * frame.c (make_frame): Call other_buffer_safely instead of
4283 * window.c (temp_output_buffer_show): Call display_buffer with
4284 second argument Vtemp_buffer_show_specifiers and reset latter
4285 immediately after the call.
4286 (Vtemp_buffer_show_specifiers): New variable.
4287 (auto_window_vscroll_p, next_screen_context_lines)
4288 (Vscroll_preserve_screen_position): Remove leading asterisks from
4291 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4293 Fix minor problems found by GCC 4.6.0 static checking.
4294 * buffer.c (Qclone_number): Remove for now, as it's unused.
4295 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4296 (record_buffer): Remove unused local.
4297 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4298 (set_frame_buffer_list): Remove; unused.
4299 * frame.h (other_visible_frames): Remove decl.
4300 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4301 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4302 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4304 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4305 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4306 Define only if HAVE_GPM.
4307 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4308 (update_hints_inhibit): Remove; never set. All uses removed.
4309 * widgetprv.h (emacsFrameClassRec): Remove decl.
4310 * window.c (delete_deletable_window): Now returns void, since it
4311 wasn't returning anything.
4312 (compare_window_configurations): Remove unused locals.
4313 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4314 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4315 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4316 the same widths as pointers. This follows up on the 2011-05-06 patch.
4317 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4318 * xterm.h: Likewise.
4319 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4321 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
4323 * makefile.w32-in: Update dependencies.
4324 (LISP_H): Add lib/intprops.h.
4326 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4328 * image.c (gif_load): Add animation frame delay to the metadata.
4329 (syms_of_image): Use DEFSYM. New symbol `delay'.
4331 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4333 * window.c (delete_deletable_window): Re-add.
4334 (Fset_window_configuration): Rewrite to handle dead buffers and
4335 consequently deletable windows.
4336 (window_tree, Fwindow_tree): Remove. Supply functionality in
4338 (compare_window_configurations): Simplify code.
4340 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4342 * image.c (imagemagick_load_image): Fix type mismatch.
4343 (Fimagemagick_types): Likewise.
4345 * window.h (replace_buffer_in_windows): Declare.
4347 2011-06-11 Martin Rudalics <rudalics@gmx.at>
4349 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4350 Qclone_number. Remove external declaration of Qdelete_window.
4351 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4353 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4354 Run Qbuffer_list_update_hook if allowed.
4355 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4356 buffer list implementation.
4357 (other_buffer_safely): New function.
4358 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4359 calls to replace_buffer_in_windows and
4360 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4362 (record_buffer): Inhibit quitting and rewrite using quittable
4363 functions. Run Qbuffer_list_update_hook if allowed.
4364 (Frecord_buffer, Funrecord_buffer): New functions.
4365 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4366 Move switch-to-buffer to window.el.
4367 (bury-buffer): Move to window.el.
4368 (Vbuffer_list_update_hook): New variable.
4370 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4373 * window.h (resize_frame_windows): Move up in code.
4374 (Fwindow_frame): Remove EXFUN.
4375 (replace_buffer_in_all_windows): Remove prototype.
4376 (replace_buffer_in_windows_safely): Add prototype.
4378 * window.c: Declare Qdelete_window static again. Move down
4379 declaration of select_count.
4380 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4381 (Fother_window): Move to window.el.
4382 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4383 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4384 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4386 (replace_buffer_in_windows): Implement by calling
4387 Qreplace_buffer_in_windows.
4388 (replace_buffer_in_all_windows): Remove with some functionality
4389 moved into replace_buffer_in_windows_safely.
4390 (replace_buffer_in_windows_safely): New function.
4391 (select_window_norecord, select_frame_norecord): Move in front
4392 of run_window_configuration_change_hook. Remove now obsolete
4394 (Fset_window_buffer): Rewrite doc-string.
4395 Call Qrecord_window_buffer.
4396 (keys_of_window): Move binding for other-window to window.el.
4398 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
4400 * dispextern.h (struct image): Replace data member, whose int_val
4401 and ptr_val fields were not used by anything, with a single
4404 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4405 (gif_clear_image, gif_load, imagemagick_load_image)
4406 (gs_clear_image, gs_load): Callers changed.
4408 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4410 * buffer.h: Include <time.h>, for time_t.
4411 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4413 Fix minor problems found by static checking.
4415 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4417 Make identifiers static if they are not used in other modules.
4418 * data.c (Qcompiled_function, Qframe, Qvector):
4419 * image.c (QimageMagick, Qsvg):
4420 * minibuf.c (Qmetadata):
4421 * window.c (resize_window_check, resize_root_window): Now static.
4422 * window.h (resize_window_check, resize_root_window): Remove decls.
4424 * window.c (window_deletion_count, delete_deletable_window):
4426 (window_body_lines): Now static.
4427 (Fdelete_other_windows_internal): Mark vars as initialized.
4428 Make sure 'resize_failed' is initialized.
4429 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4430 (resize_window_apply): Remove unused local.
4431 * window.h (delete_deletable_window): Remove decl.
4433 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
4434 (imagemagick_load_image): Fix pointer signedness problem by changing
4435 last arg from unsigned char * to char *. All uses changed.
4436 Also, fix a local for similar reasons.
4437 Remove unused locals. Remove locals to avoid shadowing.
4438 (fn_rsvg_handle_free): Remove; unused.
4439 (svg_load, svg_load_image): Fix pointer signedness problem.
4440 (imagemagick_load_image): Don't use garbage pointer image_wand.
4442 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4444 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
4446 * image.c (gif_load): Fix omitted cast error introduced by
4449 2011-06-10 Martin Rudalics <rudalics@gmx.at>
4451 * window.h (resize_proportionally, orig_total_lines)
4452 (orig_top_line): Remove from window structure.
4453 (set_window_height, set_window_width, change_window_heights)
4454 (Fdelete_window): Remove prototypes.
4455 (resize_frame_windows): Remove duplicate declaration.
4457 2011-06-10 Eli Zaretskii <eliz@gnu.org>
4459 * window.h (resize_frame_windows, resize_window_check)
4460 (delete_deletable_window, resize_root_window)
4461 (resize_frame_windows): Declare prototypes.
4463 * window.c (resize_window_apply): Make definition be "static" to
4464 match the prototype.
4466 2011-06-10 Martin Rudalics <rudalics@gmx.at>
4468 * window.c: Remove declarations of Qwindow_size_fixed,
4469 window_min_size_1, window_min_size_2, window_min_size,
4470 size_window, window_fixed_size_p, enlarge_window, delete_window.
4471 Remove static from declaration of Qdelete_window, it's
4472 temporarily needed by Fbury_buffer.
4473 (replace_window): Don't assign orig_top_line and
4475 (Fdelete_window, delete_window): Remove. Window deletion is
4476 handled by window.el.
4477 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4478 Replace Fdelete_window calls with calls to Qdelete_window.
4479 (Fdelete_other_windows): Remove. Deleting other windows is
4480 handled by window.el.
4481 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4482 handled in window.el.
4483 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4484 Window minimum sizes are handled in window.el.
4485 (shrink_windows, size_window, set_window_height)
4486 (set_window_width, change_window_heights, window_height)
4487 (window_width, CURBEG, CURSIZE, enlarge_window)
4488 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4489 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4490 handled in window.el.
4491 (make_dummy_parent): Rename to make_parent_window and give it a
4492 second argument horflag.
4493 (make_window): Don't set resize_proportionally any more.
4494 (Fsplit_window): Remove. Windows are split in window.el.
4495 (save_restore_action, save_restore_orig_size)
4496 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4497 Resize mini windows in window.el.
4498 (grow_mini_window, shrink_mini_window): Implement by calling
4499 Qresize_root_window_vertically, resize_window_check and
4500 resize_window_apply.
4501 (saved_window, Fset_window_configuration, save_window_save):
4502 Do not handle orig_top_line, orig_total_lines, and
4503 resize_proportionally.
4504 (window_min_height, window_min_width): Move to window.el.
4505 (keys_of_window): Move bindings for delete-other-windows,
4506 split-window, delete-window and enlarge-window to window.el.
4508 * buffer.c: Temporarily extern Qdelete_window.
4509 (Fbury_buffer): Temporarily call Qdelete_window instead of
4510 Fdelete_window (Fbury_buffer will move to window.el soon).
4512 * frame.c (set_menu_bar_lines_1): Remove code handling
4513 orig_top_line and orig_total_lines.
4515 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4516 set_window_height but set heights directly.
4517 (change_frame_size_1): Use resize_frame_windows.
4519 * xdisp.c (init_xdisp): Don't use set_window_height but set
4522 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4523 Use resize_frame_windows instead of change_window_heights and run
4524 run_window_configuration_change_hook.
4526 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4527 instead of change_window_heights and run
4528 run_window_configuration_change_hook.
4530 2011-06-09 Martin Rudalics <rudalics@gmx.at>
4532 * window.c (replace_window): Rename second argument REPLACEMENT to
4533 NEW. New third argument SETFLAG. Rewrite.
4534 (delete_window, make_dummy_parent): Call replace_window with
4536 (window_list_1): Move down in code.
4537 (run_window_configuration_change_hook): Move set_buffer part
4538 before select_frame_norecord part in order to unwind correctly.
4539 Rename count1 to count.
4540 (recombine_windows, delete_deletable_window, resize_root_window)
4541 (Fdelete_other_windows_internal)
4542 (Frun_window_configuration_change_hook, make_parent_window)
4543 (resize_window_check, resize_window_apply, Fresize_window_apply)
4544 (resize_frame_windows, Fsplit_window_internal)
4545 (Fdelete_window_internal, Fresize_mini_window_internal):
4547 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4549 2011-06-08 Martin Rudalics <rudalics@gmx.at>
4551 * window.h (window): Add some new members to window structure -
4552 normal_lines, normal_cols, new_total, new_normal, clone_number,
4553 splits, nest, prev_buffers, next_buffers.
4554 (WINDOW_TOTAL_SIZE): Move here from window.c.
4555 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
4557 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4559 (make_dummy_parent): Set new members of windows structure.
4560 (make_window): Move down in code. Handle new members of window
4562 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4563 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4564 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4565 (Fset_window_prev_buffers, Fwindow_next_buffers)
4566 (Fset_window_next_buffers, Fset_window_clone_number):
4568 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4569 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4571 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4572 Argument WINDOW can be now internal window too.
4573 (Fwindow_use_time): Move up in code.
4574 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4576 (Fset_window_configuration, saved_window)
4577 (Fcurrent_window_configuration, save_window_save): Handle new
4578 members of window structure.
4579 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4580 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4581 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4582 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4583 Qget_mru_window, Qresize_root_window,
4584 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4585 Qauto_buffer_name; staticpro them.
4587 2011-06-07 Martin Rudalics <rudalics@gmx.at>
4589 * window.c (Fwindow_total_size, Fwindow_left_column)
4590 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4591 (Fwindow_list_1): New functions.
4592 (window_box_text_cols): Replace with window_body_cols.
4593 (Fwindow_width, Fscroll_left, Fscroll_right):
4594 Use window_body_cols instead of window_box_text_cols.
4595 (delete_window, Fset_window_configuration):
4596 Call delete_all_subwindows with window as argument.
4597 (delete_all_subwindows): Take a window as argument and not a
4599 (window_loop): Remove handling of GET_LRU_WINDOW and
4601 (Fget_lru_window, Fget_largest_window): Move to window.el.
4603 * window.h: Extern window_body_cols instead of
4604 window_box_text_cols. delete_all_subwindows now takes a
4605 Lisp_Object as argument.
4607 * indent.c (compute_motion, Fcompute_motion):
4608 Use window_body_cols instead of window_box_text_cols.
4610 * frame.c (delete_frame): Call delete_all_subwindows with root
4613 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4615 * fns.c (Fputhash): Document return value.
4617 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
4619 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4621 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4623 Cons<->int and similar integer overflow fixes (Bug#8794).
4625 Check for overflow when converting integer to cons and back.
4626 * charset.c (Fdefine_charset_internal, Fdecode_char):
4627 Use cons_to_unsigned to catch overflow.
4628 (Fencode_char): Use INTEGER_TO_CONS.
4629 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4630 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4631 * data.c (long_to_cons, cons_to_long): Remove.
4632 (cons_to_unsigned, cons_to_signed): New functions.
4633 These signal an error for invalid or out-of-range values.
4634 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4635 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4636 * font.c (Ffont_variation_glyphs):
4637 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4638 * lisp.h: Include <intprops.h>.
4639 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4640 (cons_to_signed, cons_to_unsigned): New decls.
4641 (long_to_cons, cons_to_long): Remove decls.
4642 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4643 (Fprimitive_undo): Use CONS_TO_INTEGER.
4644 * xfns.c (Fx_window_property): Likewise.
4645 * xselect.c: Include <limits.h>.
4646 (x_own_selection, selection_data_to_lisp_data):
4647 Use INTEGER_TO_CONS.
4648 (x_handle_selection_request, x_handle_selection_clear)
4649 (x_get_foreign_selection, Fx_disown_selection_internal)
4650 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4651 (lisp_data_to_selection_data): Use cons_to_unsigned.
4652 (x_fill_property_data): Use cons_to_signed.
4653 Report values out of range.
4655 Check for buffer and string overflow more precisely.
4656 * buffer.h (BUF_BYTES_MAX): New macro.
4657 * lisp.h (STRING_BYTES_MAX): New macro.
4658 * alloc.c (Fmake_string):
4659 * character.c (string_escape_byte8):
4660 * coding.c (coding_alloc_by_realloc):
4661 * doprnt.c (doprnt):
4662 * editfns.c (Fformat):
4664 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4665 since they may not be the same number.
4666 * editfns.c (Finsert_char):
4667 * fileio.c (Finsert_file_contents):
4668 Likewise for BUF_BYTES_MAX.
4670 * image.c: Use ptrdiff_t, not int, for sizes.
4671 (slurp_file): Switch from int to ptrdiff_t.
4673 (slurp_file): Check that file size fits in both size_t (for
4674 malloc) and ptrdiff_t (for sanity and safety).
4676 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4677 if b->modtime has its maximal value.
4679 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4681 Don't assume time_t can fit into int.
4682 * buffer.h (struct buffer.modtime): Now time_t, not int.
4683 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4684 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4686 Minor fixes for signed vs unsigned integers.
4687 * character.h (MAYBE_UNIFY_CHAR):
4688 * charset.c (maybe_unify_char):
4689 * keyboard.c (read_char, reorder_modifiers):
4690 XINT -> XFASTINT, since the integer must be nonnegative.
4691 * ftfont.c (ftfont_spec_pattern):
4692 * keymap.c (access_keymap, silly_event_symbol_error):
4693 XUINT -> XFASTINT, since the integer must be nonnegative.
4694 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4695 since it makes no difference and we prefer signed.
4696 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4697 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4700 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4702 * window.h (Fwindow_frame): Declare.
4704 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4706 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4707 (SPARE_MEMORY): Always define.
4708 (LARGE_REQUEST): Remove.
4709 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4711 2011-06-06 Martin Rudalics <rudalics@gmx.at>
4713 * lisp.h: Move EXFUNS for Fframe_root_window,
4714 Fframe_first_window and Fset_frame_selected_window to window.h.
4716 * window.h: Move EXFUNS for Fframe_root_window,
4717 Fframe_first_window and Fset_frame_selected_window here from
4720 * frame.c (Fwindow_frame, Fframe_first_window)
4721 (Fframe_root_window, Fframe_selected_window)
4722 (Fset_frame_selected_window): Move to window.c.
4723 (Factive_minibuffer_window): Move to minibuf.c.
4724 (Fother_visible_frames_p): New function.
4726 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4728 * window.c (decode_window, decode_any_window): Move up in code.
4729 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4730 (inhibit_frame_unsplittable): Remove unused variable.
4731 (Fwindow_buffer): Move up and rewrite doc-string.
4732 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4733 (Fwindow_prev): New functions.
4734 (Fwindow_frame): Move here from frame.c. Accept any window as
4736 (Fframe_root_window, Fframe_first_window)
4737 (Fframe_selected_window): Move here from frame.c. Accept frame
4738 or arbitrary window as argument. Update doc-strings.
4739 (Fminibuffer_window): Move up in code.
4740 (Fwindow_minibuffer_p): Move up in code and simplify.
4741 (Fset_frame_selected_window): Move here from frame.c.
4743 (Fselected_window, select_window, Fselect_window): Move up in
4744 code. Minor doc-string fixes.
4746 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4748 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4749 Do not assume that spare memory exists; that assumption is valid
4750 only if SYSTEM_MALLOC.
4751 (LARGE_REQUEST): New macro, so that the issue of large requests
4752 is separated from the issue of spare memory.
4754 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4756 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4759 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4761 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4764 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4766 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4768 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4770 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4771 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4773 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
4775 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4777 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
4779 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4780 (x_clipboard_manager_save): Add return value.
4781 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4783 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4784 Obey Vx_select_enable_clipboard_manager. Catch errors in
4785 x_clipboard_manager_save (Bug#8779).
4786 (Vx_select_enable_clipboard_manager): New variable.
4787 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4789 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
4791 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4793 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4795 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4796 in the current matrix if keep_current_p is non-zero.
4798 2011-06-04 Eli Zaretskii <eliz@gnu.org>
4800 * bidi.c (bidi_level_of_next_char): Fix last change.
4802 2011-06-03 Eli Zaretskii <eliz@gnu.org>
4804 Support bidi reordering of text covered by display properties.
4806 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4807 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4808 (bidi_cache_search, bidi_cache_iterator_state)
4809 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
4810 (bidi_level_of_next_char, bidi_move_to_visually_next):
4811 Support character positions inside a run of characters covered by a
4813 (bidi_paragraph_init, bidi_resolve_explicit_1)
4814 (bidi_level_of_next_char): Call bidi_fetch_char and
4815 bidi_fetch_char_advance instead of FETCH_CHAR and
4817 (bidi_init_it): Initialize new members.
4818 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4820 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4821 instead of using explicit *_CHAR codes.
4822 (bidi_resolve_explicit, bidi_resolve_weak):
4823 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
4824 bidirectional text is supported only in multibyte buffers.
4825 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4826 it to initialize the frame_window_p member of struct bidi_it.
4827 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4828 (bidi_resolve_explicit, bidi_resolve_weak)
4829 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4830 bidi_it->nchars is non-positive.
4831 (bidi_level_of_next_char): Don't try to lookup the cache for the
4832 next/previous character if nothing is cached there yet, or if we
4833 were just reseat()'ed to a new position.
4835 * xdisp.c (set_cursor_from_row): Set start and stop points
4836 according to the row's direction when priming the loop that looks
4837 for the glyph on which to display cursor.
4838 (single_display_spec_intangible_p): Function deleted.
4839 (display_prop_intangible_p): Reimplement to call
4840 handle_display_spec instead of single_display_spec_intangible_p.
4841 Accept 3 additional arguments needed by handle_display_spec.
4842 This fixes incorrect cursor motion across display property with complex
4843 values: lists, `(when COND...)' forms, etc.
4844 (single_display_spec_string_p): Support property values that are
4845 lists with the argument STRING its top-level element.
4846 (display_prop_string_p): Fix the condition for processing a
4847 property that is a list to be consistent with handle_display_spec.
4848 (handle_display_spec): New function, refactored from the
4849 last portion of handle_display_prop.
4850 (compute_display_string_pos): Accept additional argument
4851 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4852 value of a `display' property is a "replacing spec".
4853 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4854 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4855 the display property, but just return a value indicating whether
4856 the display property will replace the characters it covers.
4857 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4858 frame_window_p members of struct bidi_it.
4859 (compute_display_string_pos, compute_display_string_end):
4861 (push_it): Accept second argument POSITION, where pop_it should
4862 jump to continue iteration.
4863 (reseat_1): Initialize bidi_it.disp_pos.
4865 * keyboard.c (adjust_point_for_property): Adjust the call to
4866 display_prop_intangible_p to its new signature.
4868 * dispextern.h (struct bidi_it): New member frame_window_p.
4869 (bidi_init_it): Update prototypes.
4870 (display_prop_intangible_p): Update prototype.
4871 (compute_display_string_pos, compute_display_string_end):
4873 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4876 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
4878 Malloc failure behavior now depends on size of allocation.
4879 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4880 * lisp.h: Change signatures accordingly.
4881 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4882 All callers changed. (Bug#8762)
4884 * gnutls.c: Use Emacs's memory allocators.
4885 Without this change, the gnutls library would invoke malloc etc.
4886 directly, which causes problems on non-SYNC_INPUT hosts, and which
4887 runs afoul of improving memory_full behavior. (Bug#8761)
4888 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4889 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4890 xfree instead of the default malloc, realloc, free.
4891 (Fgnutls_boot): No need to check for memory allocation failure,
4892 since xmalloc does that for us.
4894 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
4895 * category.c (hash_get_category_set):
4896 * ccl.c (ccl_driver):
4897 * charset.c (Fdefine_charset_internal):
4898 * charset.h (struct charset.hash_index):
4899 * composite.c (get_composition_id, gstring_lookup_cache)
4900 (composition_gstring_put_cache):
4901 * composite.h (struct composition.hash_index):
4902 * dispextern.h (struct image.hash):
4903 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4904 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4905 (hashfn_equal, hashfn_user_defined, make_hash_table)
4906 (maybe_resize_hash_table, hash_lookup, hash_put)
4907 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4908 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4909 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4910 * image.c (make_image, search_image_cache, lookup_image)
4911 (xpm_put_color_table_h):
4912 * lisp.h (struct Lisp_Hash_Table):
4913 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
4914 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
4915 for hashes and hash indexes, instead of 'unsigned' and 'int'.
4916 * alloc.c (allocate_vectorlike):
4917 Check for overflow in vector size calculations.
4918 * ccl.c (ccl_driver):
4919 Check for overflow when converting EMACS_INT to int.
4920 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4921 need to be updated by these changes.
4922 * fns.c (make_hash_table, maybe_resize_hash_table):
4923 Check for integer overflow with large hash tables.
4924 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4925 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4926 (SXHASH_REDUCE): New macro.
4927 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4928 Use it instead of discarding useful hash info with large hash values.
4929 (sxhash_float): New function.
4930 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4931 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
4932 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4933 Rewrite to use FIXNUM_BITS, as this simplifies things.
4934 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4935 Adjust signatures to match updated version of code.
4936 (consing_since_gc): Now EMACS_INT, since a single hash table can
4937 use more than INT_MAX bytes.
4939 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4941 Make it possible to build with GCC-4.6+ -O2 -flto.
4943 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4945 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4947 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4948 Call minibuffer-inactive-mode.
4950 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
4952 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4953 Update dependencies.
4955 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4957 * data.c (init_data): Remove code for UTS, this system is not
4960 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4962 Don't force ./temacs to start in terminal mode.
4964 * frame.c (make_initial_frame): Initialize faces in all cases, not
4965 only when CANNOT_DUMP is defined.
4966 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4968 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4970 * dispnew.c (add_window_display_history): Use const for the string
4971 pointer. Remove declaration, not needed.
4973 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4975 Use 'inline', not 'INLINE'.
4976 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
4977 * alloc.c, fontset.c (INLINE): Remove.
4978 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4979 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4980 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4981 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4982 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4984 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4986 Make it possible to run ./temacs.
4988 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4989 syms_of_callproc does the same thing. Remove test for
4990 "initialized", do it in the caller.
4991 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4993 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4995 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4996 (read_minibuf): Use get_minibuffer.
4997 (syms_of_minibuf): Use DEFSYM.
4998 (Qmetadata): New var.
4999 * data.c (Qbuffer): Don't make it static.
5000 (syms_of_data): Use DEFSYM.
5002 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5004 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5005 (CCL_CODE_MIN): New macro.
5007 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5009 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5011 * eval.c (Qdebug): Now static.
5012 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5013 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5014 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5016 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5018 * image.c: Various fixes to ImageMagick code comments.
5019 (Fimagemagick_types): Doc fix.
5021 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5023 Minor fixes prompted by GCC 4.6.0 warnings.
5025 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5027 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5028 (x_clipboard_manager_save_all): Move extern decl to ...
5029 * xterm.h: ... here, so that it can be checked for consistency.
5031 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
5033 * xselect.c (x_clipboard_manager_save_frame)
5034 (x_clipboard_manager_save_all): New functions.
5035 (Fx_clipboard_manager_save): Lisp function deleted.
5037 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5038 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5040 * xterm.h: Update prototype.
5042 2011-05-28 William Xu <william.xwl@gmail.com>
5044 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5047 2011-05-28 Jim Meyering <meyering@redhat.com>
5049 Avoid a sign-extension bug in crypto_hash_function.
5050 * fns.c (to_uchar): Define.
5051 (crypto_hash_function): Use it to convert some newly-signed
5052 variables to unsigned, to avoid sign-extension bugs. For example,
5053 without this change, (md5 "truc") would evaluate to
5054 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5055 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
5056 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
5058 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5060 Integer overflow fixes.
5062 * dbusbind.c: Serial number integer overflow fixes.
5063 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
5064 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5065 to hold a serial number that is too large for a fixnum.
5066 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5067 Check for serial numbers out of range. Decode any serial number
5068 that was so large that it became a float. (Bug#8722)
5070 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5071 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5072 Use XFASTINT rather than XUINT when numbers are nonnegative.
5073 (xd_append_arg, Fdbus_method_return_internal):
5074 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5075 arguments, check that Lisp number is nonnegative, rather than
5076 silently wrapping negative numbers around. (Bug#8722)
5077 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
5080 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5082 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5084 ccl: add integer overflow checks
5085 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5086 (IN_INT_RANGE): New macros.
5087 (ccl_driver): Use them to check for integer overflow when
5088 decoding a CCL program. Many of the new checks are whether XINT (x)
5089 fits in int; it doesn't always, on 64-bit hosts. The new version
5090 doesn't catch all possible integer overflows, but it's an
5091 improvement. (Bug#8719)
5093 * alloc.c (make_event_array): Use XINT, not XUINT.
5094 There's no need for unsigned here.
5096 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5097 This follows up to the 2011-05-06 change that substituted uintptr_t
5098 for EMACS_INT. This case wasn't caught back then.
5100 Rework Fformat to avoid integer overflow issues.
5101 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5102 now (part of C89). Include <verify.h>.
5103 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5104 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5105 (Fformat): Avoid the prepass trying to compute sizes; it was only
5106 approximate and thus did not catch overflow reliably. Instead, walk
5107 through the format just once, formatting and computing sizes as we go,
5108 checking for integer overflow at every step, and allocating a larger
5109 buffer as needed. Keep track separately whether the format is
5110 multibyte. Keep only the most-recently calculated precision, rather
5111 than them all. Record whether each argument has been converted to
5112 string. Use EMACS_INT, not int, for byte and char and arg counts.
5113 Support field widths and precisions larger than INT_MAX. Avoid
5114 sprintf's undefined behavior with conversion specifications such as %#d
5115 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5116 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5117 formatting out-of-range floating point numbers with int
5120 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5122 * data.c: Avoid integer truncation in expressions involving floats.
5123 * data.c: Include <intprops.h>.
5124 (arith_driver): When there's an integer overflow in an expression
5125 involving floating point, convert the integers to floating point
5126 so that the resulting value does not suffer from catastrophic
5127 integer truncation. For example, on a 64-bit host (* 4
5128 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5129 Do not rely on undefined behavior after integer overflow.
5131 merge count_size_as_multibyte, parse_str_to_multibyte
5132 * character.c, character.h (count_size_as_multibyte):
5133 Rename from parse_str_to_multibyte; all uses changed.
5134 Check for integer overflow.
5135 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5136 since it's now a duplicate of the other. This is more of
5137 a character than a buffer op, so better that it's in character.c.
5138 * fns.c, print.c: Adjust to above changes.
5140 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5142 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5144 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5146 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5147 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5148 (x_clipboard_manager_save): Now static.
5149 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5151 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5152 (crypto_hash_function): Now static.
5153 Fix pointer signedness problems. Avoid unnecessary initializations.
5155 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
5157 * termhooks.h (Vselection_alist): Make it terminal-local.
5159 * terminal.c (create_terminal): Initialize it.
5161 * xselect.c: Support for clipboard managers.
5162 (Vselection_alist): Move to termhooks.h as terminal-local var.
5163 (LOCAL_SELECTION): New macro.
5164 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5165 (symbol_to_x_atom): Remove gratuitous arg.
5166 (x_handle_selection_request, lisp_data_to_selection_data)
5167 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
5168 (x_own_selection, x_get_local_selection, x_convert_selection):
5169 New arg, specifying work frame. Use terminal-local Vselection_alist.
5170 (some_frame_on_display): Delete unused function.
5171 (Fx_own_selection_internal, Fx_get_selection_internal)
5172 (Fx_disown_selection_internal, Fx_selection_owner_p)
5173 (Fx_selection_exists_p): New optional frame arg.
5174 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5175 (x_handle_selection_clear): Don't treat other terminals with the
5176 same keyboard specially. Use the terminal-local Vselection_alist.
5177 (x_clear_frame_selections): Use Frun_hook_with_args.
5179 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5181 * xterm.h: Add support for those atoms.
5183 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
5185 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5186 (converted_selections, conversion_fail_tag): New global variables.
5187 (x_selection_request_lisp_error): Free the above.
5188 (x_get_local_selection): Remove unnecessary code.
5189 (x_reply_selection_request): Args changed; handle arbitrary array
5190 of converted selections stored in converted_selections.
5191 Separate the XChangeProperty and SelectionNotify steps.
5192 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5193 (x_convert_selection): New function.
5194 (x_handle_selection_event): Simplify.
5195 (x_get_foreign_selection): Don't ignore incoming requests while
5196 waiting for an answer; this will fail when we implement
5197 SAVE_TARGETS, and seems unnecessary anyway.
5198 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5199 (Vx_sent_selection_functions): Doc fix.
5201 2011-05-26 Leo Liu <sdl.web@gmail.com>
5203 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5205 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5207 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5209 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5210 for fringe update if it has periodic bitmap.
5211 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
5212 and fringe_bitmap_periodic_p.
5214 * fringe.c (get_fringe_bitmap_data): New function.
5215 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5216 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5217 row. Mark glyph row for fringe update if periodicity changed.
5219 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5220 for fringe update unless it has periodic bitmap.
5222 2011-05-25 Kenichi Handa <handa@m17n.org>
5224 * xdisp.c (get_next_display_element): Set correct it->face_id for
5225 a static composition.
5227 2011-05-24 Leo Liu <sdl.web@gmail.com>
5230 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5232 * fns.c (crypto_hash_function, Fsha1): New function.
5233 (Fmd5): Use crypto_hash_function.
5234 (syms_of_fns): Add Ssha1.
5236 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5238 * gnutls.c: Remove unused macros.
5239 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5240 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5241 Remove macros that are defined and never used.
5242 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5244 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5246 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5247 (Fx_get_selection_internal): Minor cleanup.
5248 (Fx_own_selection_internal): Rename arguments for consistency with
5251 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5253 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5255 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
5257 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5259 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5261 * dispnew.c (scrolling_window): Don't exclude the case that the
5262 last enabled row in the desired matrix touches the bottom boundary.
5264 2011-05-21 Glenn Morris <rgm@gnu.org>
5266 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
5267 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5268 and add some more files.
5270 2011-05-20 Eli Zaretskii <eliz@gnu.org>
5272 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5273 report_file_error introduced by the change from 2011-05-07.
5275 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5277 * systime.h (Time): Define only if emacs is defined.
5278 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5279 where the include path doesn't have X11/X.h by default. See
5280 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5282 2011-05-20 Kenichi Handa <handa@m17n.org>
5284 * composite.c (find_automatic_composition): Fix previous change.
5286 2011-05-20 Glenn Morris <rgm@gnu.org>
5288 * lisp.mk: New file, split from Makefile.in.
5289 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5290 (shortlisp): Remove.
5291 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5293 2011-05-19 Glenn Morris <rgm@gnu.org>
5295 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5296 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5297 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5298 (lisp): Set the order to that of loadup.el.
5299 (shortlisp): Make it a copy of $lisp.
5300 (SOME_MACHINE_LISP): Remove.
5301 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5302 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5304 2011-05-18 Kenichi Handa <handa@m17n.org>
5306 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5307 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5308 (find_automatic_composition): Mostly rewrite for efficiency.
5310 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
5312 * makefile.w32-in: Update dependencies.
5314 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5316 * menu.c: Include limits.h (fixes the MS-Windows build broken by
5317 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
5319 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
5321 Fix some integer overflow issues, such as string length overflow.
5323 * insdel.c (count_size_as_multibyte): Check for string overflow.
5325 * character.c (lisp_string_width): Check for string overflow.
5326 Use EMACS_INT, not int, for string indexes and lengths; in
5327 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5328 the resulting string length overflows an EMACS_INT; instead,
5329 report a string overflow if no precision given. When checking for
5330 precision exhaustion, use a check that cannot possibly have
5331 integer overflow. (Bug#8675)
5332 * character.h (lisp_string_width): Adjust to new signature.
5334 * alloc.c (string_overflow): New function.
5335 (Fmake_string): Use it. This doesn't change behavior, but saves
5336 a few bytes and will simplify future changes.
5337 * character.c (string_escape_byte8): Likewise.
5338 * lisp.h (string_overflow): New decl.
5340 Fixups, following up to the user-interface timestamp change.
5341 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5342 for UI timestamps, instead of unsigned long.
5343 * msdos.c (mouse_get_pos): Likewise.
5344 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
5345 * w32gui.h (Time): Define by including "systime.h" rather than by
5346 declaring it ourselves. (Bug#8664)
5348 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5349 * image.c (clear_image_cache): Likewise.
5351 * term.c (term_mouse_position): Don't assume time_t wraparound.
5353 Be more systematic about user-interface timestamps.
5354 Before, the code sometimes used 'Time', sometimes 'unsigned long',
5355 and sometimes 'EMACS_UINT', to represent these timestamps.
5356 This change causes it to use 'Time' uniformly, as that's what X uses.
5357 This makes the code easier to follow, and makes it easier to catch
5358 integer overflow bugs such as Bug#8664.
5359 * frame.c (Fmouse_position, Fmouse_pixel_position):
5360 Use Time, not unsigned long, for user-interface timestamps.
5361 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5362 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5363 * keyboard.h (last_event_timestamp): Likewise.
5364 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5365 * menu.h (xmenu_show): Likewise.
5366 * term.c (term_mouse_position): Likewise.
5367 * termhooks.h (struct input_event.timestamp): Likewise.
5368 (struct terminal.mouse_position_hook): Likewise.
5369 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5370 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5371 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5372 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5374 * menu.h, termhooks.h: Include "systime.h", for Time.
5376 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5377 Don't assume that the difference between two unsigned long values
5378 can fit into an integer. At this point, we know button_down_time
5379 <= event->timestamp, so the difference must be nonnegative, so
5380 there's no need to cast the result if double-click-time is
5381 nonnegative, as it should be; check that it's nonnegative, just in
5382 case. This bug is triggered when events are more than 2**31 ms
5383 apart (about 25 days). (Bug#8664)
5385 * xselect.c (last_event_timestamp): Remove duplicate decl.
5386 (x_own_selection): Remove needless cast to unsigned long.
5388 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5389 that always fit in int. Use a sentinel instead of a counter, to
5390 avoid a temp and to allay GCC's concerns about possible int overflow.
5391 * frame.h (struct frame): Use int for menu_bar_items_used
5392 instead of EMACS_INT, since it always fits in int.
5394 * menu.c (grow_menu_items): Check for int overflow.
5396 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5398 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5399 Before, the code was not consistent. These values cannot exceed
5400 2**31 - 1 so there's no need to make them unsigned.
5401 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5402 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5403 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5405 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5407 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5408 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5409 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5410 presumably because the widths might not match.
5412 * window.c (size_window): Avoid needless test at loop start.
5414 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5416 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5418 2011-05-12 Drew Adams <drew.adams@oracle.com>
5420 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5422 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5424 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5425 `width' to `bar_area_x' and `bar_area_width', respectively.
5426 (x_scroll_run): Take account of fringe background extension.
5428 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5429 Rename local vars `left' and `width' to `bar_area_x' and
5430 `bar_area_width', respectively.
5431 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5432 background extension.
5434 2011-05-10 Jim Meyering <meyering@redhat.com>
5436 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5438 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
5440 * image.c (Finit_image_library): Return t for built-in image types,
5441 like pbm and xbm. (Bug#8640)
5443 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5445 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5447 2011-05-07 Eli Zaretskii <eliz@gnu.org>
5449 * w32console.c (Fset_screen_color): Doc fix.
5450 (Fget_screen_color): New function.
5451 (syms_of_ntterm): Defsubr it.
5453 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5454 unlink the temporary file if Fcall_process didn't create it in the
5456 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5457 child process will be redirected to a file specified with `:file'.
5458 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5459 cue to call_process_cleanup not to close that handle.
5461 2011-05-07 Ben Key <bkey76@gmail.com>
5463 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5464 one of two shell specific rules, either bootstrap-temacs-CMD or
5465 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5466 to the previous implementation of the bootstrap-temacs rule.
5467 The bootstrap-temacs-CMD rule is similar to the previous
5468 implementation of the bootstrap-temacs rule except that it
5469 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5472 These changes, along with some changes to nt/configure.bat,
5473 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5474 earlier fix to add support for --cflags and --ldflags options
5475 that include quotes so that it works whether make uses cmd or
5478 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
5480 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5481 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5483 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5484 a string. Handle both cases.
5485 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5486 (Fdbus_register_method): Use Qinvalid_function.
5488 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
5490 * makefile.w32-in: Update dependencies.
5491 (LISP_H): Add inttypes.h and stdin.h.
5492 (PROCESS_H): Add unistd.h.
5494 2011-05-06 Eli Zaretskii <eliz@gnu.org>
5496 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5497 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5499 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
5501 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5503 * term.c (vfatal): Remove stray call to va_end.
5504 It's not needed and the C Standard doesn't allow it here anyway.
5506 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5507 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5509 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5512 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5514 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5516 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5518 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5520 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5522 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5523 * charset.c (Fdefine_charset_internal): Don't initialize
5524 charset.code_space[15]. The value was garbage, on hosts with
5525 32-bit int (Bug#8600).
5527 * lread.c (read_integer): Be more consistent with string-to-number.
5528 Use string_to_number to do the actual conversion; this avoids
5529 rounding errors and fixes some other screwups. Without this fix,
5530 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5531 (digit_to_number): Move earlier, for benefit of read_integer.
5532 Return -1 if the digit is out of range for the base, -2 if it is
5533 not a digit in any supported base. (Bug#8602)
5535 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5537 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5538 to match comment at start of function. This also removes a
5539 GCC warning about overflow in a 32+64-bit port.
5541 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5543 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5544 Reported by Stefan Monnier in
5545 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
5546 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5547 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
5549 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5550 (EMACS_UINTPTR): Likewise, with uintptr_t.
5552 * lisp.h: Prefer 64-bit EMACS_INT if available.
5553 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5554 on 32-bit hosts that have 64-bit int, so that they can access
5556 However, temporarily disable this change unless the temporary
5557 symbol WIDE_EMACS_INT is defined.
5559 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5561 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5562 This removes an assumption that EMACS_INT and long are the same
5563 width as pointers. The assumption is true for Emacs porting targets
5564 now, but we want to make other targets possible.
5565 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5566 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5567 In the rest of the code, change types of integers that hold casted
5568 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5569 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5570 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5571 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5572 No need to cast type when ORing.
5573 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5574 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5575 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5576 assume EMACS_INT is the same width as char *.
5577 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5578 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5579 Remove no-longer-needed casts.
5580 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5581 (xg_tool_bar_help_callback, xg_make_tool_item):
5582 Use EMACS_INTPTR to hold an integer
5583 that will be cast to void *; this can avoid a GCC warning
5584 if EMACS_INT is not the same width as void *.
5585 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5586 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5587 (current_message_1, set_message_1):
5588 Use a local to convert to proper width without a cast.
5589 * xmenu.c (dialog_selection_callback): Likewise.
5591 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5592 Also, don't assume VALBITS / RAND_BITS is less than 5,
5593 and don't rely on undefined behavior when shifting a 1 left into
5595 * lisp.h (get_random): Change signature to match.
5597 * lread.c (hash_string): Use size_t, not int, for hash computation.
5598 Normally we prefer signed values; but hashing is special, because
5599 it's better to use unsigned division on hash table sizes so that
5600 the remainder is nonnegative. Also, size_t is the natural width
5601 for hashing into memory. The previous code used 'int', which doesn't
5602 retain enough info to hash well into very large tables.
5603 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5605 * dbusbind.c: Don't possibly lose pointer info when converting.
5606 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5607 Use XPNTR rather than XHASH, so that the high-order bits of
5608 the pointer aren't lost when converting through void *.
5610 * eval.c (Fautoload): Don't double-shift a pointer.
5612 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5614 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
5616 * gnutls.c (DEF_GNUTLS_FN):
5617 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5619 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5621 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5624 2011-05-05 Eli Zaretskii <eliz@gnu.org>
5626 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5627 New version that can reserve upto 2GB of heap space.
5629 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
5631 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5633 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5635 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5636 `gnutls_certificate_set_x509_key_file'.
5638 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
5640 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5641 Update dependencies.
5643 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5645 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5646 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5647 Remove unused parameter `fildes'.
5648 * process.c (read_process_output, send_process): Don't pass it.
5650 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5652 Fix previous change: the library cache is defined in w32.c.
5653 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5654 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5656 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5658 Implement dynamic loading of GnuTLS on Windows.
5660 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5661 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5662 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5665 * gnutls.c (Qgnutls_dll): Define.
5666 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5667 (gnutls_*): Declare function pointers.
5668 (init_gnutls_functions): New function to initialize function pointers.
5669 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5670 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5671 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5672 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5673 (emacs_gnutls_write, emacs_gnutls_read)
5674 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5675 (Fgnutls_available_p): New function.
5676 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5677 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5678 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5680 * image.c: Include w32.h.
5681 (Vimage_type_cache): Delete.
5682 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5683 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5684 (w32_delayed_load): Move to w32.c.
5686 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5688 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5689 (w32_delayed_load): Move from image.c. When loading a library, record
5690 its filename in the :loaded-from property of the library id.
5691 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5692 Initialize and staticpro them.
5693 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5695 * process.c: Include lisp.h before w32.h, not after.
5696 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5697 instead of gnutls_record_check_pending.
5699 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5701 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5703 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5704 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5707 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5709 * xterm.c (x_set_frame_alpha): Do not set property on anything
5710 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5712 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
5714 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5716 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
5718 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5719 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5720 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5721 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5722 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5723 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5724 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5725 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5726 (Qgnutls_bootprop_callbacks_verify): Make static.
5728 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5730 * callproc.c: Indentation fixup.
5732 * sysdep.c (wait_for_termination_1): Make static.
5733 (wait_for_termination, interruptible_wait_for_termination):
5734 Move after wait_for_termination_1.
5736 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5738 * sysdep.c (interruptible_wait_for_termination): New function
5739 which is like wait_for_termination, but allows keyboard
5742 * callproc.c (Fcall_process): Add (:file "file") as an option for
5744 (Fcall_process_region): Ditto.
5746 2011-04-30 Eli Zaretskii <eliz@gnu.org>
5748 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5749 rather than `XVECTOR (FOO)->size'.
5751 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5752 inttypes.h, as a gnulib replacement is used if it not available in
5755 2011-04-21 Eli Zaretskii <eliz@gnu.org>
5757 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5758 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5759 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5761 * coding.c (coding_alloc_by_realloc): Error out if destination
5762 will grow beyond MOST_POSITIVE_FIXNUM.
5763 (decode_coding_emacs_mule): Abort if there isn't enough place in
5764 charbuf for the composition carryover bytes. Reserve an extra
5765 space for up to 2 characters produced in a loop.
5766 (decode_coding_iso_2022): Abort if there isn't enough place in
5767 charbuf for the composition carryover bytes.
5769 2011-04-21 Eli Zaretskii <eliz@gnu.org>
5771 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5772 aborting when %lld or %lll format is passed.
5773 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5774 %llo or %llx format is passed. (Bug#8545)
5776 * window.c (window_scroll_line_based): Use a marker instead of
5777 simple variables to record original value of point. (Bug#7952)
5779 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5780 produced by %s or %c overflows available buffer space. (Bug#8545)
5782 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5784 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
5785 (SIZE_MAX): Move defn after all includes, as they might #define it.
5787 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5789 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5791 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5793 * keyboard.c (Qdelayed_warnings_hook): Define.
5794 (command_loop_1): Run `delayed-warnings-hook'
5795 if Vdelayed_warnings_list is non-nil.
5796 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5797 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5799 2011-04-28 Eli Zaretskii <eliz@gnu.org>
5801 * doprnt.c (doprnt): Don't return value smaller than the buffer
5802 size if the message was truncated. (Bug#8545).
5804 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5806 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5807 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5809 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5811 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5813 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
5815 * makefile.w32-in: Update dependencies.
5817 2011-04-27 Eli Zaretskii <eliz@gnu.org>
5819 Improve `doprnt' and its usage. (Bug#8545)
5820 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5821 `format_end'. Remove support for %l as a conversion specifier.
5822 Don't use xrealloc. Improve diagnostics when the %l size modifier
5823 is used. Update the commentary.
5825 * eval.c (verror): Simplify calculation of size_t.
5827 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5830 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5832 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5835 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5837 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5838 This makes this file independent of the recent pseudovector change.
5840 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
5842 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5844 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
5845 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
5846 Remove unused local.
5847 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
5849 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
5850 GCC 4.6.0 optimizes based on type-based alias analysis.
5851 For example, if b is of type struct buffer * and v of type struct
5852 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5853 != &v->size, and therefore "v->size = 1; b->size = 2; return
5854 v->size;" must therefore return 1. This assumption is incorrect
5855 for Emacs, since it type-puns struct Lisp_Vector * with many other
5856 types. To fix this problem, this patch adds a new type struct
5857 vectorlike_header that documents the constraints on layout of vectors
5858 and pseudovectors, and helps optimizing compilers not get fooled
5859 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5860 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
5861 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5863 (XSETPVECTYPE): Rewrite in terms of new macro.
5864 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5865 This is a bit clearer, and further avoids the possibility of
5866 undesirable aliasing.
5867 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
5868 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
5869 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5870 since Lisp_Subr is a special case (no "next" field).
5871 (ASIZE): Now uses header.size rather than size.
5872 All previous uses of XVECTOR (foo)->size replaced to use this macro,
5873 to avoid the hassle of writing XVECTOR (foo)->header.size.
5874 (struct vectorlike_header): New type.
5875 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5876 object, to help avoid aliasing.
5877 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5878 (SUBRP): Likewise, since Lisp_Subr is a special case.
5879 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5880 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5881 (struct Lisp_Hash_Table): Combine first two members into a single
5882 struct vectorlike_header member. All uses of "size" and "next" members
5883 changed to be "header.size" and "header.next".
5884 * buffer.h (struct buffer): Likewise.
5885 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5886 * frame.h (struct frame): Likewise.
5887 * process.h (struct Lisp_Process): Likewise.
5888 * termhooks.h (struct terminal): Likewise.
5889 * window.c (struct save_window_data, struct saved_window): Likewise.
5890 * window.h (struct window): Likewise.
5891 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5892 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5893 * buffer.c (init_buffer_once): Likewise.
5894 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5896 * process.c (Fformat_network_address): Use local var for size,
5899 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5901 Make the Lisp reader and string-to-float more consistent (Bug#8525)
5902 * data.c (atof): Remove decl; no longer used or needed.
5903 (digit_to_number): Move to lread.c.
5904 (Fstring_to_number): Use new string_to_number function, to be
5905 consistent with how the Lisp reader treats infinities and NaNs.
5906 Do not assume that floating-point numbers represent EMACS_INT
5907 without losing information; this is not true on most 64-bit hosts.
5908 Avoid double-rounding errors, by insisting on integers when
5909 parsing non-base-10 numbers, as the documentation specifies.
5910 * lisp.h (string_to_number): New decl, replacing ...
5911 (isfloat_string): Remove.
5912 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
5913 (read1): Do not accept +. and -. as integers; this
5914 appears to have been a coding error. Similarly, do not accept
5915 strings like +-1e0 as floating point numbers. Do not report
5916 overflow for integer overflows unless the base is not 10 which
5917 means we have no simple and reliable way to continue.
5918 Break out the floating-point parsing into a new
5919 function string_to_number, so that Fstring_to_number parses
5920 floating point numbers consistently with the Lisp reader.
5921 (digit_to_number): Move here from data.c. Make it static inline.
5922 (E_CHAR, EXP_INT): Remove, replacing with ...
5923 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5924 (string_to_number): New function, replacing isfloat_string.
5925 This function checks for valid syntax and produces the resulting
5926 Lisp float number too. Rework it so that string-to-number
5927 no longer mishandles examples like "1.0e+". Use strtoumax,
5928 so that overflow for non-base-10 numbers is reported only when
5929 there's no portable and simple way to convert to floating point.
5931 * textprop.c (set_text_properties_1): Rewrite for clarity,
5932 and to avoid GCC warning about integer overflow.
5934 * intervals.h (struct interval): Use EMACS_INT for members
5935 where EMACS_UINT might cause problems. See
5936 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5937 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5938 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5940 (offset_intervals): Tell GCC not to worry about length overflow
5941 when negating a negative length.
5943 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5944 (overrun_check_free): Likewise.
5946 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5947 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5950 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5951 (gnutls_make_error): Rename local to avoid shadowing.
5952 (gnutls_emacs_global_deinit): ifdef out; not used.
5953 (Fgnutls_boot): Use const for pointer to readonly storage.
5954 Comment out unused local. Fix pointer signedness problems.
5956 * lread.c (openp): Don't stuff size_t into an 'int'.
5957 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5958 about possible signed overflow.
5960 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5961 (GDK_KEY_g): Don't define if already defined.
5962 (xg_prepare_tooltip): Avoid pointer signedness problem.
5963 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5965 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5966 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5968 * xfns.c (Fx_window_property): Simplify a bit,
5969 to make a bit faster and to avoid GCC 4.6.0 warning.
5970 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5972 * fns.c (internal_equal): Don't assume size_t fits in int.
5974 * alloc.c (compact_small_strings): Tighten assertion a little.
5976 Replace pEd with more-general pI, and fix some printf arg casts.
5977 * lisp.h (pI): New macro, generalizing old pEd macro to other
5978 conversion specifiers. For example, use "...%"pI"d..." rather
5979 than "...%"pEd"...".
5980 (pEd): Remove. All uses replaced with similar uses of pI.
5981 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5982 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5983 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5984 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5985 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5986 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5987 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5989 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5990 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5991 * print.c (safe_debug_print, print_object): Likewise.
5992 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5994 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5995 avoiding the 0 flag, which is not portable.
5996 * process.c (Fmake_network_process): Use pI to avoid cast.
5997 * region-cache.c (pp_cache): Likewise.
5998 * xdisp.c (decode_mode_spec): Likewise.
5999 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6000 behavior on 64-bit hosts with printf arg.
6001 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
6002 (x_stop_queuing_selection_requests): Likewise.
6003 (x_get_window_property): Don't truncate byte count to an 'int'
6006 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6007 here, since it parses constructs like leading '-' and spaces,
6008 which are not wanted; and it overflows with large numbers.
6009 Instead, simply match F[0-9]+, which is what is wanted anyway.
6011 * alloc.c: Remove unportable assumptions about struct layout.
6012 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6013 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6014 (allocate_vectorlike, make_pure_vector): Use the new macros,
6015 plus offsetof, to remove unportable assumptions about struct layout.
6016 These assumptions hold on all porting targets that I know of, but
6017 they are not guaranteed, they're easy to remove, and removing them
6018 makes further changes easier.
6020 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6021 This doesn't fix a bug but makes the code clearer.
6022 (string_overrun_cookie): Now const. Use initializers that
6023 don't formally overflow signed char, to avoid warnings.
6024 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6025 can cause Emacs to crash when string overrun checking is enabled.
6026 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6027 multiple of sizeof (EMACS_INT); it need not be, if
6028 alignof(EMACS_INT) < sizeof (EMACS_INT).
6029 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
6031 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
6033 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6035 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6037 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
6038 supposed to be handshaking. (Bug#8556)
6039 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6041 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
6043 * lisp.h (Qdebug): List symbol.
6044 * eval.c (Qdebug): Restore global linkage.
6045 * keyboard.c (debug-on-event): New variable.
6046 (handle_user_signal): Break into debugger when debug-on-event
6047 matches the current signal symbol.
6049 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6051 * alloc.c (check_sblock, check_string_bytes)
6052 (check_string_free_list): Convert to standard C.
6054 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6056 * w32.c (emacs_gnutls_push): Fix typo.
6058 2011-04-25 Eli Zaretskii <eliz@gnu.org>
6060 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6061 "cast to pointer from integer of different size".
6063 Improve doprnt and its use in verror. (Bug#8545)
6064 * doprnt.c (doprnt): Document the set of format control sequences
6065 supported by the function. Use SAFE_ALLOCA instead of always
6068 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6069 is one byte too soon. Don't use xrealloc; instead xfree and
6072 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6074 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6077 * gnutls.c: Renamed global_initialized to
6078 gnutls_global_initialized. Added internals for the
6079 :verify-hostname-error, :verify-error, and :verify-flags
6080 parameters of `gnutls-boot' and documented those parameters in the
6081 docstring. Start callback support.
6082 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6083 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6084 on error. Return error code.
6085 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6086 (emacs_gnutls_read): Likewise.
6087 (Fgnutls_boot): Return handshake error code.
6088 (emacs_gnutls_handle_error): New function.
6089 (wsaerror_to_errno): Likewise.
6091 * w32.h (emacs_gnutls_pull): Add prototype.
6092 (emacs_gnutls_push): Likewise.
6094 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6095 (emacs_gnutls_push): Likewise.
6097 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6099 * process.c (wait_reading_process_output): Check if GnuTLS
6100 buffered some data internally if no FDs are set for TLS
6103 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6104 (LIBS): Link to USER_LIBS.
6105 ($(BLD)/gnutls.$(0)): New target.
6107 2011-04-24 Eli Zaretskii <eliz@gnu.org>
6109 * xdisp.c (handle_single_display_spec): Rename the
6110 display_replaced_before_p argument into display_replaced_p, to
6111 make it consistent with the commentary. Fix typos in the
6114 * textprop.c (syms_of_textprop): Remove dead code.
6115 (copy_text_properties): Delete obsolete commentary about an
6116 interface that was deleted long ago. Fix typos in the description
6119 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6120 to changes in oldXMenu/XMenu.h from 2011-04-16.
6121 <menu_help_message, prev_menu_help_message>: Constify.
6122 (IT_menu_make_room): menu->help_text is now `const char **';
6125 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6126 to changes in oldXMenu/XMenu.h from 2011-04-16.
6127 (struct XMenu): Declare `help_text' `const char **'.
6129 * xfaces.c <Qunspecified>: Make extern again.
6131 * syntax.c: Include sys/types.h before including regex.h, as
6134 * doc.c (get_doc_string): Improve the format passed to `error'.
6136 * doprnt.c (doprnt): Improve commentary.
6138 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6140 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6143 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6144 changes in globals.h immediately force recompilation.
6145 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6146 $(CURDIR)/s/ms-w32.h.
6147 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
6149 * character.c (Fchar_direction): Function deleted.
6150 (syms_of_character): Don't defsubr it.
6151 <char-direction-table>: Deleted.
6153 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6155 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6156 * doprnt.c: Include limits.h.
6157 (SIZE_MAX): New macro.
6158 (doprnt): Return a size_t value. 2nd arg is now size_t.
6159 Many local variables are now size_t instead of int or unsigned.
6160 Improve overflow protection. Support `l' modifier for integer
6161 conversions. Support %l conversion. Don't assume an EMACS_INT
6162 argument for integer conversions and for %c.
6164 * lisp.h (doprnt): Restore prototype.
6166 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6169 * Makefile.in (base_obj): Add back doprnt.o.
6171 * deps.mk (doprnt.o): Add back prerequisites.
6172 (callint.o): Depend on character.h.
6174 * eval.c (internal_lisp_condition_case): Include the handler
6175 representation in the error message.
6176 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6177 when breaking from the loop.
6179 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6181 * callint.c (Fcall_interactively): When displaying error message
6182 about invalid control letter, pass the character's codepoint, not
6183 a pointer to its multibyte form. Improve display of the character
6184 in octal and display also its hex code.
6186 * character.c (char_string): Use %x to display the (unsigned)
6187 codepoint of an invalid character, to avoid displaying a bogus
6190 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6191 `error', not SYMBOL_NAME itself.
6193 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6194 character arguments to `error'.
6196 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6197 to `error' in error message about FINAL_CHAR argument. Make sure
6198 FINAL_CHAR is a character, and use %c when it is passed as
6199 argument to `error'.
6201 2011-04-23 Eli Zaretskii <eliz@gnu.org>
6203 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6205 * w32.c: Include <time.h>.
6206 (sys_localtime): New function.
6208 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
6210 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6212 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
6214 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
6216 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6219 2011-04-19 Eli Zaretskii <eliz@gnu.org>
6221 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6222 gl_state.e_property when gl_state.object is Qt.
6224 * insdel.c (make_gap_larger): Remove limitation of buffer size
6227 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
6229 * xdisp.c (lookup_glyphless_char_display)
6230 (produce_glyphless_glyph): Handle cons cell entry in
6231 glyphless-char-display.
6232 (Vglyphless_char_display): Document it.
6234 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6235 glyphless-char-display.
6237 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
6239 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6241 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6243 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6244 definition for no-X builds.
6246 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
6248 Static checks with GCC 4.6.0 and non-default toolkits.
6250 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6252 * process.c (keyboard_bit_set): Define only if SIGIO.
6253 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6254 (send_process): Repair possible setjmp clobbering.
6256 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6258 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6260 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6262 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6263 Define only if needed.
6265 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6266 by pacifying GCC about it. Maybe it's time to retire it?
6267 * xfaces.c (USG, __TIMEVAL__): Likewise.
6269 * dispextern.h (struct redisplay_interface): Rename param
6271 * termhooks.h (struct terminal): Likewise.
6272 * xterm.c (xembed_send_message): Likewise.
6274 * insdel.c (make_gap_smaller): Define only if
6275 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6277 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6280 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6281 so that we aren't warned about unused symbols.
6283 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6285 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
6287 * xfns.c (x_real_positions): Mark locals as initialized.
6289 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6291 * xterm.c: Fix problems found by static analysis with other toolkits.
6292 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
6293 (x_dispatch_event): Declare static if USE_GTK, and
6294 define if USE_GTK || USE_X_TOOLKIT.
6295 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
6296 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
6297 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6298 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
6300 * xmenu.c (menu_help_callback): Pointer type fixes.
6301 Use const pointers when pointing at readonly data. Avoid pointer
6303 (FALSE): Remove unused macro.
6304 (update_frame_menubar): Remove unused decl.
6306 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6308 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6309 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6310 (single_menu_item): Rename local to avoid shadowing.
6312 * keyboard.c (make_lispy_event): Remove unused local var.
6314 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6315 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6317 * bitmaps: Change bitmaps from unsigned char back to the X11
6318 compatible char. Avoid the old compiler warnings about
6319 out-of-range initializers by using, for example, '\xab' rather
6322 * xgselect.c (xgselect_initialize): Check vs interface
6323 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6325 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6327 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6328 to read-only memory.
6330 * fns.c (vector): Remove; this old hack is no longer needed.
6332 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
6334 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
6336 * xrdb.c (x_load_resources): Omit unused local.
6338 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
6339 (x_window): Rename locals to avoid shadowing.
6340 (USG): Use the kludged USG macro, to pacify gcc.
6342 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
6343 (x_term_init): Remove local to avoid shadowing.
6345 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
6347 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6348 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6350 2011-04-16 Eli Zaretskii <eliz@gnu.org>
6352 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6354 Fix regex.c, syntax.c and friends for buffers > 2GB.
6355 * syntax.h (struct gl_state_s): Declare character position members
6358 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6360 * textprop.c (verify_interval_modification, interval_of):
6361 Declare arguments EMACS_INT.
6363 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6366 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6368 * indent.c (Fvertical_motion): Local variable it_start is now
6371 * regex.c (re_match, re_match_2, re_match_2_internal)
6372 (bcmp_translate, regcomp, regexec, print_double_string)
6373 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6374 (re_compile_pattern, re_exec): Declare arguments and local
6375 variables `size_t' and `ssize_t' and return values `regoff_t', as
6377 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6378 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6379 <compile_stack_type>: `size' and `avail' are now `size_t'.
6381 * regex.h <regoff_t>: Use ssize_t, not int.
6382 (re_search, re_search_2, re_match, re_match_2): Arguments that
6383 specify buffer/string position and length are now ssize_t and
6384 size_t. Return type is regoff_t.
6386 2011-04-16 Ben Key <bkey76@gmail.com>
6388 * nsfont.m: Fixed bugs in ns_get_family and
6389 ns_descriptor_to_entity that were caused by using free to
6390 deallocate memory blocks that were allocated by xmalloc (via
6391 xstrdup). This caused Emacs to crash when compiled with
6392 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6393 --enable-checking=xmallocoverrun). xfree is now used to
6394 deallocate these memory blocks.
6396 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
6398 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6400 emacs_write: Accept and return EMACS_INT for sizes.
6401 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6403 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6404 Accept and return EMACS_INT.
6405 (emacs_gnutls_write): Return the number of bytes written on
6407 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
6408 (emacs_read, emacs_write): Remove check for negative size, as the
6409 Emacs source code has been audited now.
6410 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6411 (emacs_read, emacs_write): Use it.
6412 * process.c (send_process): Adjust to the new signatures of
6413 emacs_write and emacs_gnutls_write. Do not attempt to store
6414 a byte offset into an 'int'; it might overflow.
6415 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
6417 * sound.c: Don't assume sizes fit in 'int'.
6418 (struct sound_device.period_size, alsa_period_size):
6419 Return EMACS_INT, not int.
6420 (struct sound_device.write, vox_write, alsa_write):
6421 Accept EMACS_INT, not int.
6422 (wav_play, au_play): Use EMACS_INT to store sizes and to
6423 record read return values.
6425 2011-04-15 Ben Key <bkey76@gmail.com>
6427 * keyboard.c (Qundefined): Don't declare static since it is used
6429 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6430 static since they are used in nsfont.m.
6432 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6434 * process.c (Qprocessp): Don't declare static.
6435 * lisp.h (Qprocessp): Declare again.
6437 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
6439 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6441 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6443 Improve C-level modularity by making more things 'static'.
6445 Don't publish debugger-only interfaces to other modules.
6446 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6447 (verify_bytepos, count_markers): Move decls to the only modules
6449 * region-cache.h (pp_cache): Likewise.
6450 * window.h (check_all_windows): Likewise.
6451 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6453 * sysdep.c (croak): Now static, if
6454 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6455 * syssignal.h (croak): Declare only if not static.
6457 * alloc.c (refill_memory_reserve): Now static if
6458 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6459 * lisp.h (refill_memory_reserve): Declare only if not static.
6461 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6462 Define only if USE_LUCID.
6464 * xrdb.c (x_customization_string, x_rm_string): Now static.
6466 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6467 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6469 * xdisp.c (draw_row_with_mouse_face): Now static.
6470 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6472 * window.h (check_all_windows): Mark externally visible.
6474 * window.c (window_deletion_count): Now static.
6476 * undo.c: Make symbols static if they're not exported.
6477 (last_undo_buffer, last_boundary_position, pending_boundary):
6480 * textprop.c (interval_insert_behind_hooks): Now static.
6481 (interval_insert_in_front_hooks): Likewise.
6483 * term.c: Make symbols static if they're not exported.
6484 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6485 (max_frame_lines, tty_set_terminal_modes):
6486 (tty_reset_terminal_modes, tty_turn_off_highlight):
6487 (get_tty_terminal): Now static.
6488 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6489 * termhooks.h (term_mouse_moveto): Do not declare if
6491 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6492 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6494 * sysdep.c: Make symbols static if they're not exported.
6495 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6497 (sigprocmask_set, full_mask): Remove; unused.
6498 (wait_debugging): Mark as visible.
6499 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6500 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6502 * syntax.c (syntax_temp): Define only if !__GNUC__.
6504 * sound.c (current_sound_device, current_sound): Now static.
6506 * search.c (searchbufs, searchbuf_head): Now static.
6508 * scroll.c (scroll_cost): Remove; unused.
6509 * dispextern.h (scroll_cost): Remove decl.
6511 * region-cache.h (pp_cache): Mark as externally visible.
6513 * process.c: Make symbols static if they're not exported.
6514 (process_tick, update_tick, create_process, chan_process):
6515 (Vprocess_alist, proc_buffered_char, datagram_access):
6516 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6517 (deactivate_process): Mark defn as static, as well as decl.
6518 * lisp.h (create_process): Remove decl.
6519 * process.h (chan_process, Vprocess_alist): Remove decls.
6521 * print.c: Make symbols static if they're not exported.
6522 (print_depth, new_backquote_output, being_printed, print_buffer):
6523 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6524 (print_interval, print_number_index, initial_stderr_stream):
6526 * lisp.h (Fprinc): Remove decl.
6527 (debug_output_compilation_hack): Mark as externally visible.
6529 * sysdep.c (croak): Move decl from here to syssignal.h.
6530 * syssignal.h (croak): Put it here, so the API can be checked when
6531 'croak' is called from dissociate_if_controlling_tty.
6533 * minibuf.c: Make symbols static if they're not exported.
6534 (minibuf_save_list, choose_minibuf_frame): Now static.
6535 * lisp.h (choose_minibuf_frame): Remove decl.
6537 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6539 * lread.c: Make symbols static if they're not exported.
6540 (read_objects, initial_obarray, oblookup_last_bucket_number):
6542 (make_symbol): Remove; unused.
6543 * lisp.h (initial_obarray, make_symbol): Remove decls.
6545 * keyboard.c: Make symbols static if they're not exported.
6546 (single_kboard, recent_keys_index, total_keys, recent_keys):
6547 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6548 (this_single_command_key_start, echoing, last_auto_save):
6549 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6550 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6551 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6552 (Vlispy_mouse_stem, double_click_count):
6554 (force_auto_save_soon): Define only if SIGDANGER.
6555 (ignore_mouse_drag_p): Now static if
6556 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6557 (print_help): Remove; unused.
6558 (stop_character, last_timer_event): Mark as externally visible.
6559 * keyboard.h (ignore_mouse_drag_p): Declare only if
6560 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6561 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6562 * lisp.h (echoing): Remove decl.
6563 (force_auto_save_soon): Declare only if SIGDANGER.
6564 * xdisp.c (redisplay_window): Simplify code, to make it more
6565 obvious that ignore_mouse_drag_p is not accessed if !defined
6566 USE_GTK && !defined HAVE_NS.
6568 * intervals.c: Make symbols static if they're not exported.
6569 (merge_properties_sticky, merge_interval_right, delete_interval):
6571 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6573 * insdel.c: Make symbols static if they're not exported.
6574 However, leave prepare_to_modify_buffer alone. It's never
6575 called from outside this function, but that appears to be a bug.
6576 (combine_after_change_list, combine_after_change_buffer):
6577 (adjust_after_replace, signal_before_change): Now static.
6578 (adjust_after_replace_noundo): Remove; unused.
6579 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
6580 (signal_before_change): Remove decls.
6582 * indent.c (val_compute_motion, val_vmotion): Now static.
6584 * image.c: Make symbols static if they're not exported.
6585 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6587 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6588 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6590 * fringe.c (standard_bitmaps): Now static.
6591 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6593 * frame.c: Make symbols static if they're not exported.
6594 (x_report_frame_params, make_terminal_frame): Now static.
6595 (get_frame_param): Now static, unless HAVE_NS.
6596 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6597 (x_get_resource_string): Remove; not used.
6598 * frame.h (make_terminal_frame, x_report_frame_params):
6599 (x_get_resource_string); Remove decls.
6600 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6601 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6603 * font.c, fontset.c: Make symbols static if they're not exported.
6604 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6605 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6606 * font.c (font_close_object): Now static.
6607 * font.h (font_close_object): Remove.
6608 * fontset.c (FONTSET_OBJLIST): Remove.
6609 (free_realized_fontset) #if-0 the body, which does nothing.
6610 (face_suitable_for_char_p): #if-0, as it's never called.
6611 * fontset.h (face_suitable_for_char_p): Remove decl.
6612 * xfaces.c (face_at_string_position):
6613 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
6614 since 0 is always ASCII.
6616 * fns.c (weak_hash_tables): Now static.
6618 * fileio.c: Make symbols static if they're not exported.
6619 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6620 (Vwrite_region_annotation_buffers): Now static.
6622 * eval.c: Make symbols static if they're not exported.
6623 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6624 * lisp.h (backtrace_list): Remove decl.
6626 * emacs.c: Make symbols static if they're not exported.
6627 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6628 (fatal_error_code, fatal_error_signal_hook, standard_args):
6630 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6631 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6632 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6633 * lisp.h (fatal_error_signal_hook): Remove decl.
6634 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6636 * editfns.c: Move a (normally-unused) function to its only use.
6637 * editfns.c, lisp.h (get_operating_system_release): Remove.
6638 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6639 worth the hassle of breaking this out.
6641 * xterm.c: Make symbols static if they're not exported.
6642 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6643 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6644 (x_destroy_window, x_delete_display):
6646 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6647 (x_mouse_leave): Remove; unused.
6648 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6649 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6650 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6652 (x_mouse_leave): Declare only if WINDOWSNT.
6653 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6654 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6657 * ftxfont.c: Make symbols static if they're not exported.
6658 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6660 * font.h (ftxfont_driver): Likewise.
6662 * xfns.c: Make symbols static if they're not exported.
6663 (x_last_font_name, x_display_info_for_name):
6664 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6665 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6666 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6667 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6668 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6669 (last_show_tip_args): Now static.
6670 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6671 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6672 (x_screen_planes): Remove; unused.
6673 * dispextern.h (x_screen_planes): Remove decl.
6675 * dispnew.c: Make symbols static if they're not exported.
6676 * dispextern.h (redraw_garbaged_frames, scrolling):
6677 (increment_row_positions): Remove.
6678 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6679 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6681 (redraw_garbaged_frames): Remove; unused.
6683 * xfaces.c: Make symbols static if they're not exported.
6684 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6686 * xterm.h (defined_color): Remove decls.
6687 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6688 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6689 (menu_face_changed_default, defined_color, free_realized_face):
6690 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6691 (ascii_face_of_lisp_face): Remove; unused.
6693 * xdisp.c: Make symbols static if they're not exported.
6694 * dispextern.h (scratch_glyph_row, window_box_edges):
6695 (glyph_to_pixel_coords, set_cursor_from_row):
6696 (get_next_display_element, set_iterator_to_next):
6697 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6698 (show_mouse_face): Remove decls
6699 * frame.h (message_buf_print): Likewise.
6700 * lisp.h (pop_message, set_message, check_point_in_composition):
6702 * xterm.h (set_vertical_scroll_bar): Likewise.
6703 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6704 (message_buf_print, scratch_glyph_row, displayed_buffer):
6705 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6706 (get_next_display_element, show_mouse_face, window_box_edges):
6707 (frame_to_window_pixel_xy, check_point_in_composition):
6708 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6709 (glyph_to_pixel_coords): Remove; unused.
6711 * dired.c (file_name_completion): Now static.
6713 * dbusbind.c (xd_in_read_queued_messages): Now static.
6715 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6716 * data.c (circular_list_error): Remove.
6718 * commands.h (last_point_position, last_point_position_buffer):
6719 (last_point_position_window): Remove decls.
6720 * keyboard.c: Make these variables static.
6722 * coding.h (coding, code_convert_region, encode_coding_gap):
6724 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6725 (iso_code_class, detect_coding, code_convert_region): Now static.
6726 (encode_coding_gap): Remove; unused.
6728 * chartab.c (chartab_chars, chartab_bits): Now static.
6730 * charset.h (charset_iso_8859_1): Remove decl.
6731 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6734 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6735 * ccl.c (Vccl_program_table): Now static.
6736 (check_ccl_update): Remove; unused.
6738 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6739 * category.h: ... from here.
6740 * category.c (check_category_table, set_category_set): Now static.
6742 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6743 * lisp.h: Remove these decls.
6745 * buffer.c (buffer_count): Remove unused var.
6747 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6748 so that it's not optimized away.
6749 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6750 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6751 exported only to the debugger.
6753 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
6754 * atimer.h (run_all_atimers): Remove; not exported.
6756 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6757 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6758 was inaccessible from Lisp.
6759 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6760 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6762 alloc.c: Import and export fewer symbols, and remove unused items.
6763 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6765 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6766 it's not optimized away by whole-program optimization.
6767 (message_enable_multibyte, free_misc): Remove.
6768 (catchlist, handlerlist, mark_backtrace):
6769 Declare only if BYTE_MARK_STACK.
6770 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6771 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6772 (message_enable_multibyte): Remove decl.
6773 (free_misc, interval_free_list, float_block, float_block_index):
6774 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6775 (cons_free_list, last_marked_index):
6777 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6778 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6779 (mark_backtrace): Define only if BYTE_MARK_STACK.
6780 * xdisp.c (message_enable_multibyte): Now static.
6782 Declare Lisp_Object Q* variables to be 'static' if not exported.
6783 This makes it easier for human readers (and static analyzers)
6784 to see whether these variables are used from other modules.
6785 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6786 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6787 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6788 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6789 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6790 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6791 * xmenu.c, xselect.c:
6792 Declare Q* vars static if they are not used in other modules.
6793 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6794 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6795 Remove decls of unexported vars.
6796 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6798 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6800 Make Emacs functions such as Fatom 'static' by default.
6801 This makes it easier for human readers (and static analyzers)
6802 to see whether these functions can be called from other modules.
6803 DEFUN now defines a static function. To make the function external
6804 so that it can be used in other C modules, use the new macro DEFUE.
6805 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6806 (Finit_image_library):
6807 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6808 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6809 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6810 Remove decls, since these functions are now static.
6811 (Funintern, Fget_internal_run_time): New decls, since these functions
6812 were already external.
6814 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6815 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6816 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6817 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6818 * keyboard.c, keymap.c, lread.c:
6819 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6820 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6821 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6822 Mark functions with DEFUE instead of DEFUN,
6823 if they are used in other modules.
6824 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6825 decls for now-static functions.
6826 * buffer.h (Fdelete_overlay): Remove decl.
6827 * callproc.c (Fgetenv_internal): Mark as internal.
6828 * composite.c (Fremove_list_of_text_properties): Remove decl.
6829 (Fcomposition_get_gstring): New forward static decl.
6830 * composite.h (Fcomposite_get_gstring): Remove decl.
6831 * dired.c (Ffile_attributes): New forward static decl.
6832 * doc.c (Fdocumntation_property): New forward static decl.
6833 * eval.c (Ffetch_bytecode): New forward static decl.
6834 (Funintern): Remove extern decl; now in .h file where it belongs.
6835 * fileio.c (Fmake_symbolic_link): New forward static decl.
6836 * image.c (Finit_image_library): New forward static decl.
6837 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6838 * intervals.h (Fprevious_property_change):
6839 (Fremove_list_of_text_properties): Remove decls.
6840 * keyboard.c (Fthis_command_keys): Remove decl.
6841 (Fcommand_execute): New forward static decl.
6842 * keymap.c (Flookup_key): New forward static decl.
6843 (Fcopy_keymap): Now static.
6844 * keymap.h (Flookup_key): Remove decl.
6845 * process.c (Fget_process): New forward static decl.
6846 (Fprocess_datagram_address): Mark as internal.
6847 * syntax.c (Fsyntax_table_p): New forward static decl.
6848 (skip_chars): Remove duplicate decl.
6849 * textprop.c (Fprevious_property_change): New forward static decl.
6850 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6852 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6853 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6855 * editfns.c (Fformat): Remove unreachable code.
6857 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6859 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6862 2011-04-13 Eli Zaretskii <eliz@gnu.org>
6864 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6865 when at ZV. (Bug#8487)
6867 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6869 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6871 * keyboard.c (parse_tool_bar_item): Likewise.
6872 * sound.c (sound_cleanup, alsa_close): Likewise.
6873 * termcap.c (tgetent): Likewise.
6874 * xfns.c (x_default_font_parameter): Likewise.
6875 * xsettings.c (read_and_apply_settings): Likewise.
6877 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6878 (overrun_check_free): Protoize.
6880 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6882 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6883 since callers should never pass a negative size.
6884 Change the signature to match that of plain 'read' and 'write'; see
6885 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6886 * lisp.h: Update prototypes of emacs_write and emacs_read.
6888 2011-04-11 Eli Zaretskii <eliz@gnu.org>
6890 * xdisp.c (redisplay_window): Don't try to determine the character
6891 position of the scroll margin if the window start point w->startp
6892 is outside the buffer's accessible region. (Bug#8468)
6894 2011-04-10 Eli Zaretskii <eliz@gnu.org>
6896 Fix write-region and its subroutines for buffers > 2GB.
6897 * fileio.c (a_write, e_write): Modify declaration of arguments and
6898 local variables to support buffers larger than 2GB.
6899 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6901 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6902 argument, local variables, and return value.
6904 * lisp.h: Update prototypes of emacs_write and emacs_read.
6906 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6908 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
6910 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6912 Fix more problems found by GCC 4.6.0's static checks.
6914 * xdisp.c (vmessage): Use a better test for character truncation.
6916 * charset.c (load_charset_map): <, not <=, for optimization,
6917 and to avoid potential problems with integer overflow.
6918 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
6919 * casetab.c (set_identity, shuffle): Likewise.
6920 * editfns.c (Fformat): Likewise.
6921 * syntax.c (skip_chars): Likewise.
6923 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6924 This also lets GCC 4.6.0 generate slightly better loop code.
6926 * callint.c (Fcall_interactively): <, not <=, for optimization.
6927 (Fcall_interactively): Count the number of arguments produced,
6928 not the number of arguments given. This is simpler and lets GCC
6929 4.6.0 generate slightly better code.
6931 * ftfont.c: Distingish more carefully between FcChar8 and char.
6932 The previous code passed unsigned char * to a functions like
6933 strlen and xstrcasecmp that expect char *, which does not
6934 conform to the C standard.
6935 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6936 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6937 char * when the C standard requires it.
6939 * keyboard.c (read_char): Remove unused var.
6941 * eval.c: Port to Windows vsnprintf (Bug#8435).
6943 (SIZE_MAX): Define if the headers do not.
6944 (verror): Do not give up if vsnprintf returns a negative count.
6945 Instead, grow the buffer. This ports to Windows vsnprintf, which
6946 does not conform to C99. Problem reported by Eli Zaretskii.
6947 Also, simplify the allocation scheme, by avoiding the need for
6948 calling realloc, and removing the ALLOCATED variable.
6950 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6952 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6953 But keep the doprint source code for now, as we might revamp it
6954 and use it again (Bug#8435).
6955 * lisp.h (doprnt): Remove.
6956 * Makefile.in (base_obj): Remove doprnt.o.
6957 * deps.mk (doprnt.o): Remove.
6959 error: Print 32- and 64-bit integers portably (Bug#8435).
6960 Without this change, on typical 64-bit hosts error ("...%d...", N)
6961 was used to print both 32- and 64-bit integers N, which relied on
6963 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6965 * lisp.h (error, verror): Mark as printf-like functions.
6966 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6967 Report overflow in size calculations when allocating printf buffer.
6968 Do not truncate output string at its first null byte.
6969 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6970 Truncate the output at a character boundary, since vsnprintf does not
6972 * charset.c (check_iso_charset_parameter): Convert internal
6973 character to string before calling 'error', since %c now has the
6975 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6976 overflow when computing char to be passed to 'error'. Do not
6977 pass Lisp_Object to 'error'; pass the integer instead.
6978 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6979 formatted with plain %d.
6981 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6983 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6985 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6987 * xterm.c (x_catch_errors): Remove duplicate declaration.
6989 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6991 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6993 2011-04-10 Jim Meyering <meyering@redhat.com>
6995 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6996 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6997 return ssize_t not "int", and use size_t as the buffer length.
6998 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6999 * gnutls.h: Update declarations.
7000 * process.c (read_process_output): Use ssize_t, to match.
7001 (send_process): Likewise.
7003 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7005 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7007 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
7009 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7010 Use unsigned char, to match FcChar8 type definition.
7012 * xterm.c (handle_one_xevent):
7013 * xmenu.c (create_and_show_popup_menu):
7014 * xselect.c (x_decline_selection_request)
7015 (x_reply_selection_request): Avoid type-punned deref of X events.
7017 2011-04-09 Eli Zaretskii <eliz@gnu.org>
7019 Fix some uses of `int' instead of EMACS_INT.
7020 * search.c (string_match_1, fast_string_match)
7021 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7022 (scan_buffer, find_next_newline_no_quit)
7023 (find_before_next_newline, search_command, Freplace_match)
7024 (Fmatch_data): Make some `int' variables be EMACS_INT.
7026 * xdisp.c (display_count_lines): 3rd argument and return value now
7027 EMACS_INT. All callers changed.
7028 (pint2hrstr): Last argument is now EMACS_INT.
7030 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7031 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7032 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7033 (decode_coding_utf_16, decode_coding_emacs_mule)
7034 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7035 (decode_coding_ccl, decode_coding_charset)
7036 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7037 (decode_coding_iso_2022, decode_coding_emacs_mule)
7038 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7039 <char_offset, last_offset>: Declare EMACS_INT.
7040 (encode_coding_utf_8, encode_coding_utf_16)
7041 (encode_coding_emacs_mule, encode_invocation_designation)
7042 (encode_designation_at_bol, encode_coding_iso_2022)
7043 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7044 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7046 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7047 (encode_invocation_designation): Last argument P_NCHARS is now
7049 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7050 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7052 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7055 * ccl.c (Fccl_execute_on_string): Declare some variables
7058 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
7060 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7062 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7064 * process.c (Fformat_network_address): Doc fix.
7066 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7068 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
7070 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
7072 * keyboard.c (read_char): Call Lisp function help-form-show,
7073 instead of using internal_with_output_to_temp_buffer.
7074 (Qhelp_form_show): New var.
7075 (syms_of_keyboard): Use DEFSYM macro.
7077 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7079 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7081 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
7083 * process.c (Flist_processes): Remove to Lisp.
7084 (list_processes_1): Delete.
7086 2011-04-06 Eli Zaretskii <eliz@gnu.org>
7088 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7090 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7092 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
7094 Fix more problems found by GCC 4.6.0's static checks.
7096 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7098 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7100 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
7102 * xdisp.c (vmessage): Mark as a printf-like function.
7104 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7106 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7108 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7109 printf-like functions.
7110 (tiff_load): Add casts to remove these marks before passing them
7111 to system-supplied API.
7113 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7115 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7116 This avoids several warnings with gcc -Wstrict-overflow.
7117 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7118 directly, rather than having caller test rule sign. This avoids
7119 some unnecessary tests.
7120 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7121 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7122 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
7124 * xfont.c (xfont_text_extents): Remove var that was set but not used.
7125 (xfont_open): Avoid unnecessary tests.
7127 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7129 * composite.h, composite.c (composition_gstring_put_cache):
7130 Use EMACS_INT, not int, for length.
7132 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7133 breaking out part of COMPOSITION_DECODE_RULE.
7134 (COMPOSITION_DECODE_RULE): Use it.
7135 * composite.c (get_composition_id): Remove unused local vars,
7136 by using the new macro.
7138 * textprop.c (set_text_properties_1): Change while to do-while,
7139 since the condition is always true at first.
7141 * intervals.c (graft_intervals_into_buffer): Mark var as used.
7142 (interval_deletion_adjustment): Return unsigned value.
7145 * process.c (list_processes_1, create_pty, read_process_output):
7146 (exec_sentinel): Remove vars that were set but not used.
7147 (create_pty): Remove unnecessary "volatile"s.
7148 (Fnetwork_interface_info): Avoid possibility of int overflow.
7149 (read_process_output): Do adaptive read buffering even if carryover.
7150 (read_process_output): Simplify nbytes computation if buffered.
7152 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7154 * syntax.c (scan_words): Remove var that was set but not used.
7155 (update_syntax_table): Use unsigned instead of int.
7157 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
7158 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
7159 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
7161 * print.c (print_error_message): Avoid int overflow.
7163 * font.c (font_list_entities): Redo for clarity,
7164 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7166 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
7167 (font_score): Avoid potential overflow in diff calculation.
7169 * fns.c (substring_both): Remove var that is set but not used.
7170 (sxhash): Redo loop for clarity and to avoid wraparound warning.
7172 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7174 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7175 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7176 can always succeed if overflow has undefined behavior.
7178 * search.c (boyer_moore, wordify): Remove vars set but not used.
7179 (wordify): Omit three unnecessary tests.
7181 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7182 All callers changed. This avoids the need for an unused var.
7184 * casefiddle.c (casify_region): Remove var that is set but not used.
7186 * dired.c (file_name_completion): Remove var that is set but not used.
7188 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7190 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
7191 (Finsert_file_contents): Remove unnecessary code checking fd.
7193 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7194 Check for integer overflow on size calculations.
7196 * buffer.c (Fprevious_overlay_change): Remove var that is set
7199 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7200 Remove vars that are set but not used.
7201 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
7202 (timer_check_2): Mark vars as initialized.
7204 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7206 * image.c (lookup_image): Remove var that is set but not used.
7207 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
7209 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7210 that are set but not used.
7212 * xfns.c (make_invisible_cursor): Don't return garbage
7213 if XCreateBitmapFromData fails (Bug#8410).
7215 * xselect.c (x_get_local_selection, x_handle_property_notify):
7216 Remove vars that are set but not used.
7218 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
7219 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
7221 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7222 Remove var that is set but not used.
7223 (scroll_bar_windows_size): Now size_t, not int.
7224 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7227 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7228 (map_tty_color) [!defined MSDOS]: Likewise.
7230 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7232 * coding.c: Remove vars that are set but not used.
7233 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7234 All callers changed.
7235 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7236 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7237 (decode_coding_charset): Remove vars that are set but not used.
7239 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7240 that is set but not used.
7242 * print.c (print_object): Remove var that is set but not used.
7244 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
7245 The gnulib version avoids calling malloc in the usual case,
7246 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7247 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7248 * filelock.c (current_lock_owner): Likewise.
7249 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7250 * sysdep.c: Include allocator.h, careadlinkat.h.
7251 (emacs_no_realloc_allocator): New static constant.
7252 (emacs_readlink): New function.
7253 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7254 ../lib/careadlinkat.h.
7256 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7258 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7259 first non-nil return value).
7261 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7263 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7264 if not defined (Bug#8403).
7266 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7268 * xdisp.c (display_count_lines): Remove parameter `start',
7269 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7270 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7271 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7272 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7273 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7274 and thereabouts. All callers changed.
7275 (get_per_char_metric): Remove parameter `f', unused since
7276 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7278 2011-04-02 Jim Meyering <meyering@redhat.com>
7280 do not dereference NULL upon failed strdup
7281 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7282 (ns_get_family): Likewise.
7284 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
7286 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7288 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7290 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7293 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7295 Add lexical binding.
7297 * window.c (Ftemp_output_buffer_show): New fun.
7298 (Fsave_window_excursion):
7299 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7301 * lread.c (lisp_file_lexically_bound_p): New function.
7302 (Fload): Bind Qlexical_binding.
7303 (readevalloop): Remove `evalfun' arg.
7304 Bind Qinternal_interpreter_environment.
7305 (Feval_buffer): Bind Qlexical_binding.
7306 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7308 (syms_of_lread): Declare `lexical-binding'.
7310 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7312 * keyboard.c (eval_dyn): New fun.
7313 (menu_item_eval_property): Use it.
7315 * image.c (parse_image_spec): Use Ffunctionp.
7317 * fns.c (concat, mapcar1): Accept byte-code-functions.
7319 * eval.c (Fsetq): Handle lexical vars.
7320 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7321 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7322 (FletX, Flet): Obey lexical binding.
7323 (Fcommandp): Handle closures.
7324 (Feval): New `lexical' arg.
7325 (eval_sub): New function extracted from Feval. Use it almost
7326 everywhere where Feval was used. Look up vars in lexical env.
7328 (Ffunctionp): Move from subr.el.
7329 (Ffuncall): Handle closures.
7330 (apply_lambda): Remove `eval_flags'.
7331 (funcall_lambda): Handle closures and new byte-code-functions.
7332 (Fspecial_variable_p): New function.
7333 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7334 but without exporting it to Lisp.
7336 * doc.c (Fdocumentation, store_function_docstring):
7337 * data.c (Finteractive_form): Handle closures.
7339 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7342 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7344 (exec_byte_code): New function extracted from Fbyte_code to handle new
7345 calling convention for byte-code-functions. Add new byte-codes.
7347 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
7349 * alloc.c (Fmake_symbol): Init new `declared_special' field.
7351 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7353 * xdisp.c (redisplay_internal): Fix prototype.
7355 2011-03-31 Eli Zaretskii <eliz@gnu.org>
7357 * xdisp.c (SCROLL_LIMIT): New macro.
7358 (try_scrolling): Use it when setting scroll_limit.
7359 Limit scrolling to 100 screen lines.
7360 (redisplay_window): Even when falling back on "recentering",
7361 position point in the window according to scroll-conservatively,
7362 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7364 (try_scrolling): When point is above the window, allow searching
7365 as far as scroll_max, or one screenful, to compute vertical
7366 distance from PT to the scroll margin position. This prevents
7367 try_scrolling from unnecessarily failing when
7368 scroll-conservatively is set to a value slightly larger than the
7369 window height. Clean up the case of PT below the margin at bottom
7370 of window: scroll_max can no longer be INT_MAX. When aggressive
7371 scrolling is in use, don't let point enter the opposite scroll
7372 margin as result of the scroll.
7373 (syms_of_xdisp) <scroll-conservatively>: Document the
7374 threshold of 100 lines for never-recentering scrolling.
7376 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
7378 * dispextern.h (move_it_by_lines):
7379 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7380 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7381 (message_log_check_duplicate): Remove parameters `prev_bol' and
7382 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7383 (redisplay_internal): Remove parameter `preserve_echo_area',
7384 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7386 * indent.c (Fvertical_motion):
7387 * window.c (window_scroll_pixel_based, Frecenter):
7388 Don't pass `need_y_p' to `move_it_by_lines'.
7390 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7392 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7393 steal a few bits to be more compact.
7394 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7395 Remove unneeded casts.
7397 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7399 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7401 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7402 binding" message (bug#7967).
7404 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7406 Fix more problems found by GCC 4.6.0's static checks.
7408 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7409 Remove unused local var.
7411 * editfns.c (Fmessage_box): Remove unused local var.
7413 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7414 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7415 Omit unused local vars.
7416 * window.c (shrink_windows): Omit unused local var.
7417 * menu.c (digest_single_submenu): Omit unused local var.
7418 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7419 Omit unused local var.
7421 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7422 Don't assume string length fits in int.
7423 (keyremap_step, read_key_sequence): Use size_t for sizes.
7424 (read_key_sequence): Don't check last_real_key_start redundantly.
7426 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7427 instead of alloca (Bug#8344).
7429 * eval.c (Fbacktrace): Don't assume nargs fits in int.
7430 (Fbacktrace_frame): Don't assume nframes fits in int.
7432 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7434 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7437 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7439 * cm.c (calccost): Turn while-do into do-while, for clarity.
7441 * keyboard.c (syms_of_keyboard): Use the same style as later
7442 in this function when indexing through an array. This also
7443 works around GCC bug 48267.
7445 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7447 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7449 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7450 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7452 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7453 This avoids undefined behavior on integer overflow, and is a bit
7454 more convenient anyway since it is compared to a size_t variable.
7456 Variadic C functions now count arguments with size_t, not int.
7457 This avoids an unnecessary limitation on 64-bit machines, which
7458 caused (substring ...) to crash on large vectors (Bug#8344).
7459 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7460 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
7461 All variadic functions and their callers changed accordingly.
7462 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7463 * data.c (arith_driver, float_arith_driver): Likewise.
7464 * editfns.c (general_insert_function): Likewise.
7465 * eval.c (struct backtrace.nargs, interactive_p)
7466 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7467 (funcall_lambda, mark_backtrace): Likewise.
7468 * fns.c (concat): Likewise.
7469 * frame.c (x_set_frame_parameters): Likewise.
7470 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7471 0 if not found, not -1. All callers changed.
7473 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7474 (stack_copy_size): Now size_t, not int.
7475 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7477 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
7479 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7480 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7481 All callers changed.
7483 * lisp.h (multibyte_char_to_unibyte):
7484 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7485 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7486 * character.h (CHAR_TO_BYTE8):
7487 * cmds.c (internal_self_insert):
7488 * editfns.c (general_insert_function):
7489 * keymap.c (push_key_description):
7490 * search.c (Freplace_match):
7491 * xdisp.c (message_dolog, set_message_1): All callers changed.
7493 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7495 * keyboard.c (safe_run_hook_funcall): New function.
7496 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7497 don't set the hook to nil, but remove the offending function instead.
7498 (Qcommand_hook_internal): Remove, unused.
7499 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7500 Vcommand_hook_internal.
7502 * eval.c (enum run_hooks_condition): Remove.
7503 (funcall_nil, funcall_not): New functions.
7504 (run_hook_with_args): Call each function through a `funcall' argument.
7505 Remove `cond' argument, now redundant.
7506 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7507 (Frun_hook_with_args_until_failure): Adjust accordingly.
7508 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7510 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
7512 * dispextern.h (string_buffer_position): Remove declaration.
7514 * print.c (strout): Remove parameter `multibyte', unused since
7515 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7517 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7518 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7519 All callers changed.
7521 * w32.c (_wsa_errlist): Use braces for struct initializers.
7523 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7524 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7525 All callers changed.
7526 (string_buffer_position): Likewise. Also, make static (it's never
7527 used outside xdisp.c).
7528 (cursor_row_p): Remove parameter `w', unused since
7529 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7530 (decode_mode_spec): Remove parameter `precision', introduced during
7531 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7532 All callers changed.
7534 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7536 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7538 2011-03-27 Anders Lindgren <andlind@gmail.com>
7540 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7541 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7542 (ns_update_auto_hide_menu_bar): New functions.
7543 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7544 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7545 ns_constrain_all_frames.
7546 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7547 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7549 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7551 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7553 2011-03-27 Glenn Morris <rgm@gnu.org>
7555 * syssignal.h: Replace RETSIGTYPE with void.
7556 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7557 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7558 Replace SIGTYPE with void everywhere.
7559 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7560 * s/template.h (SIGTYPE): Remove commented out definition.
7562 2011-03-26 Eli Zaretskii <eliz@gnu.org>
7564 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7565 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7567 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
7569 * w32.c (read_unc_volume): Use parameter `henum', instead of
7570 global variable `wget_enum_handle'.
7572 * keymap.c (describe_vector): Remove parameters `indices' and
7573 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7574 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7576 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7578 * keyboard.c (timer_check): Remove parameter `do_it_now',
7579 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7580 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7581 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7583 * keyboard.c (read_char):
7584 * w32menu.c (w32_menu_display_help):
7585 * xmenu.c (show_help_event, menu_help_callback):
7586 Adjust calls to `show_help_echo'.
7588 * gtkutil.c (xg_maybe_add_timer):
7589 * keyboard.c (readable_events):
7590 * process.c (wait_reading_process_output):
7591 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7593 * insdel.c (adjust_markers_gap_motion):
7594 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7595 (gap_left, gap_right): Don't call it.
7597 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
7599 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7600 incurred during fontification.
7602 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
7604 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7605 (DEFVAR_PER_BUFFER): Don't pass it.
7607 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7608 (scrolling_window): Don't pass it.
7610 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
7612 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7614 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7616 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7617 of variables specific to SELinux and computation of `encoded_absname'.
7619 * image.c (XPutPixel): Remove unused variable `height'.
7621 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7623 * unexw32.c (get_section_info): Remove unused variable `section'.
7625 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7626 (system_process_attributes): Remove unused variable `sess'.
7627 (sys_read): Remove unused variable `err'.
7629 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7630 (w32_wnd_proc): Remove unused variable `isdead'.
7631 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7632 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7633 (x_create_tip_frame): Remove unused variable `tem'.
7635 * w32inevt.c (w32_console_read_socket):
7636 Remove unused variable `no_events'.
7638 * w32term.c (x_draw_composite_glyph_string_foreground):
7639 Remove unused variable `width'.
7641 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
7643 * w32term.c (x_set_glyph_string_clipping):
7644 Don't pass uninitialized region to CombineRgn.
7646 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
7648 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7649 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7650 (Fx_close_connection): Remove unused variable `i'.
7652 * w32font.c (w32font_draw): Return number of glyphs.
7653 (w32font_open_internal): Remove unused variable `i'.
7654 (w32font_driver): Add missing initializer.
7656 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7657 (fill_in_menu): Remove unused variable `items_added'.
7659 * w32term.c (last_mouse_press_frame): Remove static global variable.
7660 (w32_clip_to_row): Remove unused variable `f'.
7661 (x_delete_terminal): Remove unused variable `i'.
7663 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7664 (NOTHING): Remove unused static global variable.
7665 (uniscribe_check_otf): Remove unused variable `table'.
7666 (uniscribe_font_driver): Add missing initializers.
7668 2011-03-23 Julien Danjou <julien@danjou.info>
7670 * term.c (Fsuspend_tty, Fresume_tty):
7671 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7672 * window.c (temp_output_buffer_show):
7673 * insdel.c (signal_before_change):
7674 * frame.c (Fhandle_switch_frame):
7675 * fileio.c (Fdo_auto_save):
7676 * emacs.c (Fkill_emacs):
7677 * editfns.c (save_excursion_restore):
7678 * cmds.c (internal_self_insert):
7679 * callint.c (Fcall_interactively):
7680 * buffer.c (Fkill_all_local_variables):
7681 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7683 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
7684 unconditionnaly since it does the check itself.
7686 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
7688 Fix more problems found by GCC 4.5.2's static checks.
7690 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7691 the first time through the loop, since we know p0 < p1 then.
7692 This also avoids a gcc -Wstrict-overflow warning.
7694 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7695 leading to a memory leak, possible in functions like
7696 load_charset_map_from_file that can allocate an unbounded number
7697 of objects (Bug#8318).
7699 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7700 that could (at least in theory) be that large.
7702 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7703 This is less likely to overflow, and avoids undefined behavior if
7704 overflow does occur. All callers changed. Use strtoul to scan
7705 for the unsigned long integer.
7706 (pint2hrstr): Simplify and tune code slightly.
7707 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
7709 * scroll.c (do_scrolling): Work around GCC bug 48228.
7710 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7712 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7713 This also avoids a warning with gcc -Wstrict-overflow.
7714 (validate_x_resource_name): Simplify count usage.
7715 This also avoids a warning with gcc -Wstrict-overflow.
7717 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7720 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
7722 * process.c (Fmake_network_process): Use socklen_t, not int,
7723 where POSIX says socklen_t is required in portable programs.
7724 This fixes a porting bug on hosts like 64-bit HP-UX, where
7725 socklen_t is wider than int (Bug#8277).
7726 (Fmake_network_process, server_accept_connection):
7727 (wait_reading_process_output, read_process_output):
7730 * process.c: Rename or move locals to avoid shadowing.
7731 (list_processes_1, Fmake_network_process):
7732 (read_process_output_error_handler, exec_sentinel_error_handler):
7733 Rename or move locals.
7734 (Fmake_network_process): Define label "retry_connect" only if needed.
7735 (Fnetwork_interface_info): Fix pointer signedness.
7736 (process_send_signal): Add cast to avoid pointer signedness problem.
7737 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
7738 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
7740 Make tparam.h and terminfo.c consistent.
7741 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7742 Include tparam.h instead, since it declares them.
7743 * cm.h (PC): Remove extern decl; tparam.h now does this.
7744 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7745 * terminfo.c: Include tparam.h, to check interfaces.
7746 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7747 (tparam): Adjust signature to match interface in tparam.h;
7748 this removes some undefined behavior. Check that outstring and len
7749 are zero, which they always are with Emacs.
7750 * tparam.h (PC, BC, UP): New extern decls.
7752 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
7753 (xftfont_open): Rename locals to avoid shadowing.
7755 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
7756 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7757 (OTF_TAG_SYM): Omit macro if not needed.
7758 (ftfont_list): Remove unused local.
7759 (get_adstyle_property, ftfont_pattern_entity):
7760 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7761 Rename locals to avoid shadowing.
7763 * xfont.c (xfont_list_family): Mark var as initialized.
7765 * xml.c (make_dom): Now static.
7767 * composite.c (composition_compute_stop_pos): Rename local to
7769 (composition_reseat_it): Remove unused locals.
7770 (find_automatic_composition, composition_adjust_point): Likewise.
7771 (composition_update_it): Mark var as initialized.
7772 (find_automatic_composition): Mark vars as initialized,
7773 with a FIXME (Bug#8290).
7775 character.h: Rename locals to avoid shadowing.
7776 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7777 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7778 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7779 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7782 * textprop.c (property_change_between_p): Remove; unused.
7784 * intervals.c (interval_start_pos): Now static.
7786 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7788 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7789 Rename locals to avoid shadowing.
7791 * sound.c (wav_play, au_play, Fplay_sound_internal):
7792 Fix pointer signedness.
7793 (alsa_choose_format): Remove unused local var.
7794 (wav_play): Initialize a variable to 0, to prevent undefined
7795 behavior (Bug#8278).
7797 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7799 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7801 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7802 clobbering (Bug#8298).
7803 * sysdep.c (sys_subshell): Likewise.
7804 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7806 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7807 This should get cleaned up, so that child_setup has the
7808 same signature on all platforms.
7810 * callproc.c (call_process_cleanup): Now static.
7811 (relocate_fd): Rename locals to avoid shadowing.
7813 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
7815 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7816 not to be necessary, and produces flickering.
7818 2011-03-20 Glenn Morris <rgm@gnu.org>
7820 * config.in: Remove file.
7822 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
7824 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7825 are now in src/globals.h.
7826 (syms_of_minibuf): Remove spurious & from previous change.
7828 2011-03-20 Leo <sdl.web@gmail.com>
7830 * minibuf.c (completing-read-function): New variable.
7831 (completing-read-default): Rename from completing-read.
7832 (completing-read): Call completing-read-function.
7834 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7836 * xfaces.c (Fx_load_color_file):
7837 Read color file from absolute filename (bug#8250).
7839 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7841 * makefile.w32-in: Update dependencies.
7843 2011-03-17 Eli Zaretskii <eliz@gnu.org>
7845 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7847 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7849 Fix more problems found by GCC 4.5.2's static checks.
7851 * process.c (make_serial_process_unwind, send_process_trap):
7852 (sigchld_handler): Now static.
7854 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7855 That way, the code declares only the vars that it needs.
7856 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7857 * s/cygwin.h (PTY_ITERATION): Likewise.
7858 * s/darwin.h (PTY_ITERATION): Likewise.
7859 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7861 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7862 * process.c (allocate_pty): Don't declare stb unless it's needed.
7864 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
7865 (CONSTANTLIM): Remove; unused.
7866 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7867 Define only if needed.
7869 * unexelf.c (unexec): Name an expression,
7870 to avoid gcc -Wbad-function-cast warning.
7871 Use a different way to cause a compilation error if anyone uses
7872 n rather than nn, a way that does not involve shadowing.
7873 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
7875 * deps.mk (unexalpha.o): Remove; unused.
7877 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7878 * unexec.h: New file.
7879 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7880 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7882 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7883 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7884 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
7885 Change as necessary to match prototype in unexec.h.
7887 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7889 (back_comment, skip_chars): Mark vars as initialized.
7891 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7892 Rename locals to avoid shadowing.
7894 * lread.c (read1): Rewrite so as not to use empty "else".
7895 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
7897 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7899 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7900 warning when compiling print.c.
7902 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7903 instead of using an uninitialized var.
7904 (font_sort_entities): Mark var as initialized.
7906 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7908 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7909 pointers to constants.
7910 (font_parse_fcname): Remove unused vars.
7911 (font_delete_unmatched): Now static.
7912 (font_get_spec): Remove; unused.
7913 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7914 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7915 Rename or move locals to avoid shadowing.
7917 * fns.c (require_nesting_list, require_unwind): Now static.
7918 (Ffillarray): Rename locals to avoid shadowing.
7920 * floatfns.c (domain_error2): Define only if needed.
7921 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
7923 * alloc.c (mark_backtrace): Move decl from here ...
7924 * lisp.h: ... to here, so that it can be checked.
7926 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
7927 (Fdefvar): Rewrite so as not to use empty "else".
7928 (lisp_indirect_variable): Name an expression,
7929 to avoid gcc -Wbad-function-cast warning.
7930 (Fdefvar): Rename locals to avoid shadowing.
7932 * callint.c (quotify_arg, quotify_args): Now static.
7933 (Fcall_interactively): Rename locals to avoid shadowing.
7934 Use const pointer when appropriate.
7936 * lisp.h (get_system_name, get_operating_system_release):
7937 Move decls here, to check interfaces.
7938 * process.c (get_operating_system_release): Move decl to lisp.h.
7939 * xrdb.c (get_system_name): Likewise.
7940 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7941 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7942 some of which prompt warnings from gcc -Wbad-function-cast.
7943 (Fformat_time_string, Fencode_time, Finsert_char):
7944 (Ftranslate_region_internal, Fformat):
7945 Rename or remove local vars to avoid shadowing.
7946 (Ftranslate_region_internal): Mark var as initialized.
7948 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7951 * lisp.h (eassert): Check that the argument compiles, even if
7952 ENABLE_CHECKING is not defined.
7954 * data.c (Findirect_variable): Name an expression, to avoid
7955 gcc -Wbad-function-cast warning.
7956 (default_value, arithcompare, arith_driver, arith_error): Now static.
7957 (store_symval_forwarding): Rename local to avoid shadowing.
7958 (Fmake_variable_buffer_local, Fmake_local_variable):
7959 Mark variables as initialized.
7960 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
7962 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
7963 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7964 Rename locals to avoid shadowing.
7965 (mark_stack): Move local variables into the #ifdef region where
7967 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7968 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7970 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7971 (GC_STRING_CHARS): Remove; not used.
7972 (Fmemory_limit): Cast sbrk's returned value to char *.
7974 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7975 avoids undefined behavior in theory.
7977 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7979 Use functions, not macros, for up- and down-casing (Bug#8254).
7980 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7981 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7982 to use the following functions instead of these macros.
7983 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7984 EMACS_INT, since callers assume the returned value fits in int.
7985 (upcase1): Likewise, for UPCASE_TABLE.
7986 (uppercasep, lowercasep, upcase): New static inline functions.
7987 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
7988 the race-condition problem in the old DOWNCASE.
7990 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7991 Rename locals to avoid shadowing.
7992 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
7993 (regex_compile, re_search_2, re_match_2_internal):
7994 Remove unused local vars.
7995 (FREE_VAR): Rewrite so as not to use empty "else",
7996 which gcc can warn about.
7997 (regex_compile, re_match_2_internal): Mark locals as initialized.
7998 (RETALLOC_IF): Define only if needed.
7999 (WORDCHAR_P): Likewise. This one is never needed, but is used
8000 only in a comment talking about a compiler bug, so put inside
8001 the #if 0 of that comment.
8002 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8003 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8006 * search.c (boyer_moore): Rename locals to avoid shadowing.
8007 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8008 (PREV_CHAR_BOUNDARY): Likewise.
8010 * search.c (simple_search): Remove unused var.
8012 * dired.c (compile_pattern): Move decl from here ...
8013 * lisp.h: ... to here, so that it can be checked.
8014 (struct re_registers): New forward decl.
8016 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8018 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8020 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8021 Rename locals to avoid shadowing.
8022 (Fvertical_motion): Mark locals as initialized.
8024 * casefiddle.c (casify_object, casify_region): Now static.
8025 (casify_region): Mark local as initialized.
8027 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8029 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8030 New macros, so that the caller can use some names other than
8031 gcpro1, gcpro2, etc.
8032 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8034 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8035 argument, for consistency with GCPRO2_VAR, etc: it is now the
8036 prefix of the variable, not the variable itself. All uses
8038 * dired.c (directory_files_internal, file_name_completion):
8039 Rename locals to avoid shadowing.
8041 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8042 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8043 dired.c's scmp function, had undefined behavior.
8044 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8045 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8046 * buffer.h: ... to here, because these macros use current_buffer,
8047 and the new implementation with inline functions needs to have
8048 current_buffer in scope now, rather than later when the macros
8050 (downcase, upcase1): New static inline functions.
8051 (DOWNCASE, UPCASE1): Reimplement using these functions.
8052 This avoids undefined behavior in expressions like
8053 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8054 from race conditions in accessing the global variables
8055 case_temp1 and case_temp2.
8056 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8057 * lisp.h (case_temp1, case_temp2): Remove their decls.
8058 * character.h (ASCII_CHAR_P): Move from here ...
8059 * lisp.h: ... to here, so that the inline functions mentioned
8062 * dired.c (directory_files_internal_unwind): Now static.
8064 * fileio.c (file_name_as_directory, directory_file_name):
8065 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8067 (file_name_as_directory): Use const pointers when appropriate.
8068 (Fexpand_file_name): Likewise. In particular, newdir might
8069 point at constant storage, so make it a const pointer.
8070 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
8071 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8073 (Fset_file_times, Finsert_file_contents, auto_save_error):
8074 Rename locals to avoid shadowing.
8076 * minibuf.c (choose_minibuf_frame_1): Now static.
8077 (Ftry_completion, Fall_completions): Rename or remove locals
8080 * marker.c (bytepos_to_charpos): Remove; unused.
8082 * lisp.h (verify_bytepos, count_markers): New decls,
8083 so that gcc does not warn that these functions aren't declared.
8085 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8086 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
8087 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
8088 (copy_text): Remove unused local var.
8090 * filelock.c (within_one_second): Now static.
8091 (lock_file_1): Rename local to avoid shadowing.
8093 * buffer.c (fix_overlays_before): Mark locals as initialized.
8094 (fix_start_end_in_overlays): Likewise. This function should be
8095 simplified by using pointers-to-pointers, but that's a different
8097 (switch_to_buffer_1): Now static.
8098 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8099 (report_overlay_modification): Rename locals to avoid shadowing.
8101 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
8102 Fix pointer signedness issue.
8103 (sys_subshell): Mark local as volatile if checking for lint,
8104 to suppress a gcc -Wclobbered warning that does not seem to be right.
8105 (MAXPATHLEN): Define only if needed.
8107 * process.c (serial_open, serial_configure): Move decls from here ...
8108 * systty.h: ... to here, so that they can be checked.
8110 * fns.c (get_random, seed_random): Move extern decls from here ...
8111 * lisp.h: ... to here, so that they can be checked.
8113 * sysdep.c (reset_io): Now static.
8114 (wait_for_termination_signal): Remove; unused.
8116 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8117 (copy_keymap_item, append_key, push_text_char_description):
8119 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
8120 (DENSE_TABLE_SIZE): Remove; unused.
8121 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8122 (describe_map_tree):
8123 Rename locals to avoid shadowing.
8125 * keyboard.c: Declare functions static if they are not used elsewhere.
8126 (echo_char, echo_dash, cmd_error, top_level_2):
8127 (poll_for_input, handle_async_input): Now static.
8128 (read_char, kbd_buffer_get_event, make_lispy_position):
8129 (make_lispy_event, make_lispy_movement, apply_modifiers):
8130 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8131 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8132 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
8133 (read_key_sequence, read_char): Mark locals as initialized.
8134 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
8136 * keyboard.h (make_ctrl_char): New decl.
8137 (mark_kboards): Move decl here ...
8138 * alloc.c (mark_kboards): ... from here.
8140 * lisp.h (force_auto_save_soon): New decl.
8142 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
8143 (DEFINE_DUMMY_FUNCTION): New macro.
8144 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8146 (main): Add casts to avoid warnings
8147 if GCC considers string literals to be constants.
8149 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8151 * dbusbind.c: Pointer signedness fixes.
8152 (xd_signature, xd_append_arg, xd_initialize):
8153 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8154 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8155 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8156 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8158 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8159 if GCC considers string literals to be constants.
8160 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
8162 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8164 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8165 (print_preprocess, print_object): New macro to fix last change.
8167 * print.c (print_preprocess): Don't forget font objects.
8169 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
8171 * emacs.c (USAGE3): Doc fixes.
8173 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8175 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8178 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
8180 * lisp.h (VWindow_system, Qfile_name_history):
8181 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8182 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8183 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8185 * w32select.c: Don't #include "keyboard.h".
8186 (run_protected): Add extern declaration for waiting_for_input.
8188 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8189 * w32console.c (detect_input_pending, read_input_pending)
8190 (encode_terminal_code):
8191 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8192 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8193 (w32_system_caret_y, Qfile_name_history):
8194 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8195 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8196 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8197 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8198 * w32proc.c (Qlocal, report_file_error):
8199 * w32term.c (Vwindow_system, updating_frame):
8200 * w32uniscribe.c (initialized, uniscribe_font_driver):
8201 Remove unneeded extern declarations.
8203 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
8205 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
8207 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
8209 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8210 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8211 These macros can no longer be used for assignment.
8213 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8214 Assign struct members directly, instead of using BUF_BEGV etc.
8215 (record_buffer_markers, fetch_buffer_markers): New functions for
8216 recording and fetching special buffer markers.
8217 (set_buffer_internal_1, set_buffer_temp): Use them.
8219 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8221 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8223 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8224 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8226 * xdisp.c (hscroll_window_tree):
8227 (reconsider_clip_changes): Use PT instead of BUF_PT.
8229 2011-03-13 Eli Zaretskii <eliz@gnu.org>
8231 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8232 $(EMACS_ROOT)/lib/intprops.h.
8234 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8236 Fix more problems found by GCC 4.5.2's static checks.
8238 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8239 to unsigned char * to avoid compiler diagnostic.
8240 (xg_free_frame_widgets): Make it clear that a local variable is
8241 needed only if USE_GTK_TOOLTIP.
8242 (gdk_window_get_screen): Make it clear that this macro is needed
8243 only if USE_GTK_TOOLTIP.
8244 (int_gtk_range_get_value): New function, which avoids a diagnostic
8245 from gcc -Wbad-function-cast.
8246 (xg_set_toolkit_scroll_bar_thumb): Use it.
8247 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8248 diagnostic from gcc -Wbad-function-cast.
8249 (get_utf8_string, xg_get_file_with_chooser):
8250 Rename locals to avoid shadowing.
8251 (create_dialog): Move locals to avoid shadowing.
8253 * xgselect.c (xg_select): Remove unused var.
8255 * image.c (four_corners_best): Mark locals as initialized.
8256 (gif_load): Initialize transparent_p to zero (Bug#8238).
8257 Mark another local as initialized.
8258 (my_png_error, my_error_exit): Mark with NO_RETURN.
8260 * image.c (clear_image_cache): Now static.
8261 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
8262 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
8263 (x_edge_detection): Remove unnecessary cast that
8264 gcc -Wbad-function-cast diagnoses.
8265 (gif_load): Fix pointer signedness.
8266 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8267 (jpeg_load, gif_load): Rename locals to avoid shadowing.
8269 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
8271 Improve quality of tests for time stamp overflow.
8272 For example, without this patch (encode-time 0 0 0 1 1
8273 1152921504606846976) returns the obviously-bogus value (-948597
8274 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8275 reports time overflow. See
8276 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
8277 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8278 * editfns.c: Include limits.h and intprops.h.
8279 (TIME_T_MIN, TIME_T_MAX): New macros.
8280 (time_overflow): Move earlier, to before first use.
8281 (hi_time, lo_time): New functions, for an accurate test for
8283 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8284 (Fget_internal_run_time): Don't assume time_t fits in int.
8285 (make_time): Use list2 instead of Fcons twice.
8286 (Fdecode_time): More accurate test for out-of-range times.
8287 (check_tm_member): New function.
8288 (Fencode_time): Use it, to test for out-of-range times.
8289 (lisp_time_argument): Don't rely on undefined left-shift and
8290 right-shift behavior when checking for time stamp overflow.
8292 * editfns.c (time_overflow): New function, refactoring common code.
8293 (Fformat_time_string, Fdecode_time, Fencode_time):
8294 (Fcurrent_time_string): Use it.
8296 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8297 * dired.c (make_time): Move to ...
8298 * editfns.c (make_time): ... here.
8299 * systime.h: Note the move.
8301 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8303 * fringe.c (update_window_fringes): Remove unused variables.
8305 * unexmacosx.c (copy_data_segment): Also copy __got section.
8308 2011-03-12 Eli Zaretskii <eliz@gnu.org>
8310 * termcap.c [MSDOS]: Include "msdos.h".
8311 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8312 Constify `char *' arguments and their references according to
8313 prototypes in tparam.h.
8315 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
8317 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8318 Adapt all references accordingly.
8320 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8322 2011-03-11 Tom Tromey <tromey@redhat.com>
8324 * buffer.c (syms_of_buffer): Remove obsolete comment.
8326 2011-03-11 Eli Zaretskii <eliz@gnu.org>
8328 * termhooks.h (encode_terminal_code): Declare prototype.
8330 * msdos.c (encode_terminal_code): Don't declare prototype.
8332 * term.c (encode_terminal_code): Now external again, used by
8333 w32console.c and msdos.c.
8335 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8336 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
8338 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
8340 Fix some minor problems found by GCC 4.5.2's static checks.
8342 * fringe.c (update_window_fringes): Mark locals as initialized
8344 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
8346 * alloc.c (mark_fringe_data): Move decl from here ...
8347 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8348 to check its interface.
8349 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8351 * fontset.c (free_realized_fontset): Now static.
8352 (Fset_fontset_font): Rename local to avoid shadowing.
8353 (fontset_font): Mark local as initialized.
8354 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
8356 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8358 * xselect.c (x_disown_buffer_selections): Remove; not used.
8359 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
8360 (x_own_selection, Fx_disown_selection_internal): Rename locals
8362 (x_handle_dnd_message): Remove local to avoid shadowing.
8364 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8365 so that the caller can use some name other than gcpro1.
8366 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
8367 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8368 (Fx_backspace_delete_keys_p):
8369 Use them to avoid shadowing, and rename vars to avoid shadowing.
8370 (x_decode_color, x_set_name, x_window): Now static.
8371 (Fx_create_frame): Add braces to silence GCC warning.
8372 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
8373 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8374 Remove unused locals.
8375 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8376 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8377 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8380 * xterm.h (x_mouse_leave): New decl.
8382 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8383 Remove unused functions.
8384 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8385 (x_calc_absolute_position): Now static.
8386 (XTread_socket): Don't define label "out" unless it's used.
8387 Don't declare local "event" unless it's used.
8388 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8389 unless they are used.
8390 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8391 (x_fatal_error_signal): Remove; not used.
8392 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8393 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8394 (x_error_catcher, x_connection_closed, x_error_handler):
8395 (x_error_quitter, xembed_send_message, x_iconify_frame):
8396 (my_log_handler): Rename locals to avoid shadowing.
8397 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
8398 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
8400 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8401 Rename or move locals to avoid shadowing.
8402 (tty_defined_color, merge_face_heights): Now static.
8403 (free_realized_faces_for_fontset): Remove; not used.
8404 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8405 does not deduce is never used uninitialized.
8406 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8407 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
8409 * terminal.c (store_terminal_param): Now static.
8411 * xmenu.c (menu_highlight_callback): Now static.
8412 (set_frame_menubar): Remove unused local.
8413 (xmenu_show): Rename parameter to avoid shadowing.
8414 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8415 since they might point to immutable storage.
8416 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8417 since it's unused otherwise.
8419 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
8420 Add a FIXME, since the code still doesn't look right. (Bug#8215)
8421 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8422 avoids a gcc -Wuninitialized diagnostic.
8423 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
8424 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8425 does not deduce are never used uninitialized.
8427 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8429 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
8430 * window.c (window_loop, size_window):
8431 (run_window_configuration_change_hook, enlarge_window): Likewise.
8433 * window.c (display_buffer): Now static.
8434 (size_window): Mark variables that gcc -Wuninitialized
8435 does not deduce are never used uninitialized.
8436 * window.h (check_all_windows): New decl, to forestall
8437 gcc -Wmissing-prototypes diagnostic.
8438 * dispextern.h (bidi_dump_cached_states): Likewise.
8440 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8442 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
8444 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8445 and to avoid gcc -Wuninitialized warning.
8446 (load_charset_map): Mark variables that gcc -Wuninitialized
8447 does not deduce are never used uninitialized.
8448 (load_charset): Abort instead of using uninitialized var (Bug#8229).
8450 * coding.c (coding_set_source, coding_set_destination):
8451 Use "else { /* comment */ }" rather than "else /* comment */;"
8452 for clarity, and to avoid gcc -Wempty-body warning.
8453 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8454 a block, when the outer 'i' will do.
8455 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8456 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8457 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8458 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8459 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8460 Rename locals to avoid shadowing.
8461 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
8462 * coding.c (emacs_mule_char, encode_invocation_designation):
8463 Now static, since they're not used elsewhere.
8464 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
8465 (decode_coding_object, encode_coding_object, detect_coding_system):
8466 (decode_coding_emacs_mule): Mark variables that gcc
8467 -Wuninitialized does not deduce are never used uninitialized.
8468 (detect_coding_iso_2022): Initialize a local variable that might
8469 be used uninitialized. Leave a FIXME because it's not clear that
8470 this initialization is needed. (Bug#8211)
8471 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8472 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8473 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8474 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8475 Remove unused macros.
8477 * category.c (hash_get_category_set): Remove unused local var.
8478 (copy_category_table): Now static, since it's not used elsewhere.
8479 * character.c (string_count_byte8): Likewise.
8481 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8482 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8484 * chartab.c (copy_sub_char_table): Now static, since it's not used
8486 (sub_char_table_ref_and_range, char_table_ref_and_range):
8487 Rename locals to avoid shadowing.
8488 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
8490 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
8491 (BIDI_BOB): Remove unused macro.
8493 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8494 deduce are never used uninitialized.
8495 * term.c (encode_terminal_code): Likewise.
8497 * term.c (encode_terminal_code): Now static. Remove unused local.
8499 * tparam.h: New file.
8500 * term.c, tparam.h: Include it.
8501 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8502 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8503 Move these decls to tparam.h, and make them agree with what
8504 is actually in tparam.c. The previous trick of using incompatible
8505 decls in different modules does not conform to the C standard.
8506 All callers of tparam changed to use tparam's actual API.
8507 * tparam.c (tparam1, tparam, tgoto):
8508 Use const pointers where appropriate.
8510 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8511 * cm.h (struct cm): Likewise.
8512 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8513 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8514 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8515 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8516 (turn_on_face, init_tty): Likewise.
8517 * termchar.h (struct tty_display_info): Likewise.
8519 * term.c (term_mouse_position): Rename local to avoid shadowing.
8521 * alloc.c (mark_ttys): Move decl from here ...
8522 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8524 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8526 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8528 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
8530 * search.c (compile_pattern_1): Remove argument regp, unused since
8531 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8532 (compile_pattern): Don't pass it.
8534 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8536 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8537 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8539 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8541 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8543 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8544 gdk_window_get_screen, gdk_window_get_geometry,
8545 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8546 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8547 (xg_get_pixbuf_from_pixmap): New function.
8548 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8549 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8550 Call xg_get_pixbuf_from_pixmap instead of
8551 gdk_pixbuf_get_from_drawable.
8552 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8553 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8554 (xg_check_special_colors): Use GtkStyleContext and its functions
8556 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8557 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8558 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
8559 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8560 Call gtk_widget_get_preferred_size.
8561 (xg_frame_resized): gdk_window_get_geometry only takes 5
8563 (xg_win_to_widget, xg_event_is_for_menubar):
8564 Call gdk_x11_window_lookup_for_display.
8565 (xg_set_widget_bg): New function.
8566 (delete_cb): New function.
8567 (xg_create_frame_widgets): Connect delete-event to delete_cb.
8568 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
8569 (xg_set_background_color): Call xg_set_widget_bg.
8570 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8571 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8572 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8573 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8575 (update_frame_tool_bar): Call gtk_widget_hide.
8576 (xg_initialize): Use GDK_KEY_g.
8578 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8580 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8582 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8583 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8584 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8586 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
8588 * w32xfns.c (select_palette): Check success of RealizePalette against
8589 GDI_ERROR, not zero.
8591 See ChangeLog.11 for earlier changes.
8597 Copyright (C) 2011 Free Software Foundation, Inc.
8599 This file is part of GNU Emacs.
8601 GNU Emacs is free software: you can redistribute it and/or modify
8602 it under the terms of the GNU General Public License as published by
8603 the Free Software Foundation, either version 3 of the License, or
8604 (at your option) any later version.
8606 GNU Emacs is distributed in the hope that it will be useful,
8607 but WITHOUT ANY WARRANTY; without even the implied warranty of
8608 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8609 GNU General Public License for more details.
8611 You should have received a copy of the GNU General Public License
8612 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.