]> code.delx.au - gnu-emacs/blob - src/ChangeLog
Revert last commit.
[gnu-emacs] / src / ChangeLog
1 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
2
3 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
4 line. (Bug#9903)
5
6 2011-10-29 Glenn Morris <rgm@gnu.org>
7
8 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
9 Not clear what it was for, and it causes various bugs. (Bug#9839)
10
11 2011-10-28 Eli Zaretskii <eliz@gnu.org>
12
13 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
14 possible random value that matches one of those tested as
15 condition to clear the mouse face.
16
17 2011-10-28 Chong Yidong <cyd@gnu.org>
18
19 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
20
21 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
22
23 * window.c (make_window): Initialize phys_cursor_on_p.
24
25 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
26
27 * lisp.h (struct Lisp_Symbol): Update comments.
28
29 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
30
31 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
32
33 2011-10-28 Eli Zaretskii <eliz@gnu.org>
34
35 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
36 <oslsachem@gmail.com> for helping to debug this.
37
38 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
39 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
40 (g_b_init_get_glyph_outline_w): New static variables.
41 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
42 (GetGlyphOutlineW_Proc): New typedefs.
43 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
44 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
45 New functions.
46 (w32font_open_internal, compute_metrics):
47 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
48 instead of calling the "wide" APIs directly.
49
50 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
51
52 * w32.h (syms_of_w32font): Add prototype.
53
54 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
55
56 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
57 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
58 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
59 (Fmove_to_window_line): Doc fix.
60
61 2011-10-27 Chong Yidong <cyd@gnu.org>
62
63 * process.c (make_process): Set gnutls_state to NULL.
64
65 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
66 non-NULL, regardless of GNUTLS_INITSTAGE.
67 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
68 an error. Set process slots as soon as we allocate them.
69
70 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
71
72 2011-10-27 Chong Yidong <cyd@gnu.org>
73
74 * gnutls.c (emacs_gnutls_deinit): New function.
75 Deallocate credentials structures as well as calling gnutls_deinit.
76 (Fgnutls_deinit, Fgnutls_boot): Use it.
77
78 * process.c (make_process): Initialize GnuTLS credentials to NULL.
79 (deactivate_process): Call emacs_gnutls_deinit.
80
81 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
82
83 * image.c (x_create_x_image_and_pixmap):
84 * w32.c (sys_rename, w32_delayed_load):
85 * w32font.c (fill_in_logfont):
86 * w32reg.c (x_get_string_resource): Silence compiler warnings.
87
88 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
89
90 * w32fns.c (w32_default_color_map): New function,
91 extracted from Fw32_default_color_map.
92 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
93
94 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
95
96 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
97
98 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
99
100 * keyboard.c (test_undefined): New function (bug#9751).
101 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
102
103 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
104
105 * sysdep.c (init_sys_modes): Fix the check for the controlling
106 terminal (Bug#6649).
107
108 2011-10-20 Eli Zaretskii <eliz@gnu.org>
109
110 * dispextern.h (struct bidi_it): New member next_en_type.
111
112 * bidi.c (bidi_line_init): Initialize the next_en_type member.
113 (bidi_resolve_explicit_1): When next_en_pos is valid for the
114 current character, check also for next_en_type being WEAK_EN.
115 (bidi_resolve_weak): Don't enter the expensive loop if the current
116 position is before next_en_pos. Record the bidi type of the first
117 non-ET, non-BN character we find, in addition to its position.
118 (bidi_level_of_next_char): Invalidate next_en_type when
119 next_en_pos is over-stepped.
120
121 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
122
123 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
124 * editfns.c: Rewrite current-time-zone so that it invokes
125 the equivalent of (format-time-string "%Z") to get the time zone name.
126 This fixes a bug when the time zone name contains characters that
127 need converting from the system time locale to Emacs internal format.
128 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
129 that patch fixed format-time-string to do the conversion, but
130 I forgot to fix current-time-zone.
131 (format_time_string): New function, containing most of
132 what Fformat_time_string used to contain.
133 (Fformat_time_string): Rewrite in terms of format_time_string.
134 This doesn't change this function's behavior.
135 (current-time-zone): Rewrite to use format_time_string.
136 This fixes the bug reported by Michael Schierl in
137 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
138 Jason Rumney's 2007-06-07 change worked around this bug, but
139 didn't fix it.
140 * systime.h (tzname, timezone): Remove no-longer-used declarations.
141
142 2011-10-19 Eli Zaretskii <eliz@gnu.org>
143
144 * xdisp.c (start_display): If the character at POS is displayed
145 via a display vector, reset IT->current.dpvec_index to zero.
146 (try_window_reusing_current_matrix): If a line ends in a display
147 vector or the next line starts in a display vector, continue
148 redrawing the window even though the character position of
149 start_row was reached.
150 (Bug#9771, part 2)
151
152 2011-10-18 Chong Yidong <cyd@gnu.org>
153
154 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
155 with nobreak-char-display too.
156
157 2011-10-18 Eli Zaretskii <eliz@gnu.org>
158
159 Fix part 3 of bug#9771.
160 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
161 (bidi_resolve_neutral): Don't enter the expensive loop looking for
162 non-neutral characters if the current character is a paragraph
163 separator (a.k.a. Newline). This avoids running the same
164 expensive loop twice, once when we consume the preceding newline
165 and the other time when the line actually needs to be displayed.
166 Avoid the loop when we see neutrals on the base embedding level
167 following a character whose directionality is the same as the
168 paragraph's. This avoids running the expensive loop when a line
169 ends in a long sequence of neutrals, like control characters.
170 Add assertion against STRONG_AL type. Slightly rearrange code
171 that determines the type of a neutral given the first non-neutral
172 that follows it.
173 (bidi_level_of_next_char): Set next_en_pos to zero when
174 invalidating its info.
175
176 2011-10-17 Eli Zaretskii <eliz@gnu.org>
177
178 * xdisp.c (push_display_prop): Determine whether to record string
179 or buffer position by IT->string, not by IT->method. Allow
180 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
181 (move_it_vertically_backward): Don't look for character position
182 immediately after the newline when in a continuation line.
183 (Bug#9771, part 1)
184
185 2011-10-15 Martin Rudalics <rudalics@gmx.at>
186
187 * window.c (coordinates_in_window): Rewrite and delabelize
188 vertical border check. (Bug#5357) (Bug#9618)
189
190 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
191
192 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
193 errors in XSetWindowBorder (bug#9310).
194
195 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
196
197 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
198 avoid crash when xmalloc overrun checking is enabled.
199
200 2011-10-13 Eli Zaretskii <eliz@gnu.org>
201
202 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
203 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
204 cursor motion with <left> and <right> arrow keys.
205
206 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
207 some callers set that themselves.
208
209 2011-10-12 Eli Zaretskii <eliz@gnu.org>
210
211 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
212 display string and the previous row comes from the same string and
213 is empty. (Bug#9739) (Bug#9738)
214
215 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
216
217 * doc.c (get_doc_string): Encode file name (bug#9735).
218
219 2011-10-12 Eli Zaretskii <eliz@gnu.org>
220
221 * bidi.c (bidi_level_of_next_char):
222 * xdisp.c (get_visually_first_element): Remove old incorrect
223 comments regarding the Unicode Line Separator character.
224
225 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
226
227 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
228
229 * alloc.c (Fgc_status): Do not access beyond zombies array
230 boundary if nzombies > MAX_ZOMBIES.
231 * alloc.c (dump_zombies): Add missing format specifier.
232
233 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
234
235 * xdisp.c (set_cursor_from_row): Simplify conditionals,
236 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
237
238 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
239 Some packages use them to denote characters with modifiers.
240
241 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
242
243 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
244 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
245 matching a pp-number. Rename parameter var to var1.
246
247 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
248
249 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
250
251 2011-10-08 Glenn Morris <rgm@gnu.org>
252
253 * callint.c (Fcall_interactively): Give a more explicit error for the
254 'c' case with a non-character input. (Bug#8479)
255
256 2011-10-08 Eli Zaretskii <eliz@gnu.org>
257
258 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
259 lines.
260 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
261 lines that are hscrolled on the left.
262
263 * dispnew.c (buffer_posn_from_coords): Account for a possible
264 presence of header-line. (Bug#4426)
265
266 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
267
268 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
269 Don't advertise functionality which we discourage or doesn't work.
270
271 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
272
273 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
274 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
275 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
276 this makes Emacs dump core during garbage collection on rare
277 occasions. sizeof is obviously inferior to offsetof here, so
278 stick with offsetof.
279 (GC_POINTER_ALIGNMENT): New macro.
280 (mark_memory): Omit 3rd (offset) arg; caller changed.
281 Don't assume EMACS_INT alignment is the same as pointer alignment.
282
283 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
284
285 * keyboard.c (read_key_sequence_remapped): New var.
286 (read_key_sequence): Compute remapping in the right buffer.
287 (command_loop_1): Use read_key_sequence's remapping directly.
288
289 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
290
291 * dired.c (file_name_completion): Don't expand file name.
292 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
293 before checking file name handler.
294
295 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
296 they've been requested explicitly (bug#9591).
297
298 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
299
300 * keymap.c (Fsingle_key_description): Use make_specified_string
301 instead of build_string to build string from push_key_description.
302 (Bug#5193)
303
304 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
305
306 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
307 This fixes a Y2038 bug on 64-bit hosts.
308 * buffer.c (reset_buffer):
309 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
310 (Fclear_buffer_auto_save_failure):
311 Use 0, not -1, to represent an unset failure time, since time_t
312 might not be signed.
313
314 Remove dependency on glibc malloc internals.
315 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
316 Move back here from lisp.h, but with their new implementations.
317 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
318 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
319 * charset.c (charset_table_init): New static var.
320 (syms_of_charset): Use it instead of xmalloc. This removes a
321 dependency on glibc malloc internals. See Eli Zaretskii's comment in
322 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
323 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
324 Move back to alloc.c.
325 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
326 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
327
328 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
329
330 * nsterm.m (windowDidResize): Call x_set_window_size only when
331 ns_in_resize is true. Otherwise set pixelwidth/height and
332 call change_frame_size (Bug#9628).
333
334 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
335
336 Port --enable-checking=all to Fedora 14 x86-64.
337 * charset.c (syms_of_charset): Also account for glibc malloc's
338 internal overhead when calculating the initial malloc maximum.
339
340 Port --enable-checking=all to Fedora 14 x86.
341 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
342 Move to lisp.h.
343 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
344 (overrun_check_realloc, overrun_check_free):
345 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
346 That way, xmalloc returns a properly-aligned pointer even if
347 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
348 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
349 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
350 into account when calculating the initial malloc maximum.
351 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
352 Move here from alloc.c, so that charset.c can use it too.
353 Properly align; the old code wasn't right for common 32-bit hosts
354 when configured with --enable-checking=all.
355 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
356 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
357
358 2011-09-29 Eli Zaretskii <eliz@gnu.org>
359
360 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
361 use EDOM.
362
363 2011-09-28 Eli Zaretskii <eliz@gnu.org>
364
365 * xdisp.c (compute_display_string_end): If there's no display
366 string at CHARPOS, return -1.
367
368 * bidi.c (bidi_fetch_char): When compute_display_string_end
369 returns a negative value, treat the character as a normal
370 character not covered by a display string. (Bug#9624)
371
372 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
373
374 * lread.c (Fread_from_string): Fix typo in docstring.
375
376 2011-09-27 Eli Zaretskii <eliz@gnu.org>
377
378 * xdisp.c (handle_invisible_prop): If invisible text ends on a
379 newline, reseat the iterator instead of bidi-iterating there one
380 character at a time. (Bug#9610)
381 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
382 TO_CHARPOS if the bidi iterator is at base embedding level.
383
384 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
385
386 * lread.c (readevalloop): Use correct code for NBSP.
387 (read1): Likewise. (Bug#9608)
388
389 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
390
391 * dbusbind.c (Fdbus_register_signal): When service is not
392 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
393
394 2011-09-25 Glenn Morris <rgm@gnu.org>
395
396 * buffer.c (truncate-lines): Doc fix.
397
398 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
399
400 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
401 (Fset_window_next_buffers): Doc fix.
402
403 2011-09-24 Glenn Morris <rgm@gnu.org>
404
405 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
406
407 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
408
409 Fix minor problems found by static checking.
410 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
411 * indent.c (Fvertical_motion): Fix == vs = typo.
412
413 2011-09-24 Eli Zaretskii <eliz@gnu.org>
414
415 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
416 Default value is now t. Doc fix.
417
418 * indent.c (Fvertical_motion): Compute and apply the overshoot
419 logic when moving up, not only when moving down. Fix the
420 confusing name and values of the it_overshoot_expected variable;
421 logic changes accordingly. (Bug#9254) (Bug#9549)
422
423 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
424 CHARPOS is covered by a display string which includes newlines.
425 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
426 is covered by a display string with embedded newlines.
427
428 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
429
430 * dbusbind.c (Fdbus_register_signal): Add match rule to
431 Vdbus_registered_objects_table. (Bug#9581)
432 (Fdbus_register_method, Vdbus_registered_objects_table):
433 Fix docstring.
434
435 2011-09-24 Jim Meyering <meyering@redhat.com>
436
437 do not ignore write error for any output size
438 The previous change was incomplete.
439 While it makes emacs --batch detect the vast majority of stdout
440 write failures, errors were still ignored whenever the output size is
441 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
442 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
443 && echo FAIL: ignored write error
444 FAIL: ignored write error
445 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
446 && echo FAIL: ignored write error
447 FAIL: ignored write error
448 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
449
450 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
451
452 * emacs.c (Fkill_emacs): In noninteractive mode exit
453 non-successfully if a write error occurred on stdout. (Bug#9574)
454
455 2011-09-21 Eli Zaretskii <eliz@gnu.org>
456
457 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
458 the xassert test.
459
460 * dispextern.h (struct it): Update the comment documenting what
461 can it->OBJECT be.
462
463 2011-09-20 Eli Zaretskii <eliz@gnu.org>
464
465 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
466 a display string, extend search for cursor position to end of row.
467 (find_row_edges): If the row ends in a newline from a display
468 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
469 Handle the case of a display string with multiple newlines.
470 (Fcurrent_bidi_paragraph_direction): Fix search for previous
471 non-empty line. Fixes confusing cursor motion with arrow keys at
472 the beginning of a line that starts with whitespace.
473
474 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
475
476 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
477 (bug#9493).
478
479 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
480
481 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
482 boolean (Bug#9154).
483
484 2011-09-18 Eli Zaretskii <eliz@gnu.org>
485
486 * xdisp.c (display_line): Record maximum and minimum buffer
487 positions even if no glyphs were produced (e.g., by a zero-width
488 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
489 buffer positions that will be removed from the glyph row because
490 they don't fit.
491 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
492 column is beyond frame width: don't subtract 1 "pixel" when
493 computing width of the stretch.
494 (reseat_at_next_visible_line_start): Undo the change made on
495 2011-09-17 that saved paragraph information and restored it after
496 the call to `reseat'. (Bug#9545)
497
498 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
499
500 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
501 and turn window cursor on if cleared (Bug#9415).
502
503 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
504
505 * search.c (boyer_moore): Take unibyte characters from pattern
506 literally. (Bug#9458)
507
508 2011-09-18 Eli Zaretskii <eliz@gnu.org>
509
510 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
511
512 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
513
514 Fix minor problem found by static checking.
515 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
516 initialized, to pacify gcc -Wuninitialized.
517
518 * fileio.c: Report proper errno when syscall falls.
519 (Finsert_file_contents): Save and restore errno,
520 so that report_file_error outputs the correct diagnostic.
521 (Fwrite_region) [CLASH_DETECTION]: Likewise.
522
523 2011-09-18 Eli Zaretskii <eliz@gnu.org>
524
525 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
526
527 2011-09-17 Eli Zaretskii <eliz@gnu.org>
528
529 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
530 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
531
532 2011-09-17 Eli Zaretskii <eliz@gnu.org>
533
534 * xdisp.c (reseat_at_next_visible_line_start): Keep information
535 about the current paragraph and restore it after the call to reseat.
536
537 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
538 (bidi_find_paragraph_start): Search back for paragraph beginning
539 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
540 (bidi_move_to_visually_next): Only trigger paragraph-related
541 computations when the last character is a newline or at EOB, not
542 just any NEUTRAL_B. (Bug#9470)
543
544 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
545 truncated lines if point is covered by a display string. (Bug#9524)
546
547 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
548
549 * xselect.c: Relax test for outgoing X longs (Bug#9498).
550 (cons_to_x_long): New function.
551 (lisp_data_to_selection_data): Use it. Correct the test for
552 short-versus-long data; it was negated. Break out of vector
553 loop, for efficiency, when a long datum is discovered.
554
555 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
556
557 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
558
559 2011-09-16 Eli Zaretskii <eliz@gnu.org>
560
561 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
562 GCC PR/17406) by declaring this function with external scope.
563
564 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
565
566 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
567 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
568
569 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
570
571 * editfns.c (Fformat): Correctly handle text properties on "%%".
572
573 2011-09-15 Eli Zaretskii <eliz@gnu.org>
574
575 * xterm.c (x_draw_composite_glyph_string_foreground):
576 * w32term.c (x_draw_composite_glyph_string_foreground):
577 * term.c (encode_terminal_code):
578 * composite.c (composition_update_it, get_composition_id):
579 * xdisp.c (get_next_display_element)
580 (fill_composite_glyph_string): Add comments about special meaning
581 of TAB characters in a composition.
582
583 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
584
585 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
586 This occurs when processing a multibyte format.
587 Problem reported by Wolfgang Jenker.
588
589 2011-09-15 Johan Bockgård <bojohan@gnu.org>
590
591 * xdisp.c (try_cursor_movement): Only check for exact match if
592 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
593
594 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
595
596 Remove unused external symbols.
597 * dispextern.h (calc_pixel_width_or_height): Remove decl.
598 * xdisp.c (calc_pixel_width_or_height): Now static.
599 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
600 * indent.c (check_display_width):
601 * w32term.c: Fix comment to match code.
602 * xterm.c, xterm.h (x_catching_errors): Remove.
603
604 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
605
606 * xselect.c: Use signed conversions more consistently (Bug#9498).
607 (selection_data_to_lisp_data): Assume incoming selection data are
608 signed integers, not unsigned. This is to be consistent with
609 outgoing selection data, which was modified to use signed integers
610 in as part of the fix to Bug#9196 in response to Jan D.'s comment
611 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
612 expects long, not unsigned long.
613
614 2011-09-14 Eli Zaretskii <eliz@gnu.org>
615
616 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
617 computation of loop end. Reported by Johan Bockgård
618 <bojohan@gnu.org>.
619
620 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
621
622 * frame.c (Fother_visible_frames_p): Function deleted.
623
624 2011-09-12 Eli Zaretskii <eliz@gnu.org>
625
626 * indent.c (compute_motion): Process display vector front to back
627 rather than the other way around. (Bug#2496)
628
629 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
630
631 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
632
633 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
634
635 * minibuf.c (Fread_from_minibuffer): Doc fix.
636
637 2011-09-11 Eli Zaretskii <eliz@gnu.org>
638
639 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
640 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
641
642 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
643
644 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
645 value for non-existent files.
646
647 2011-09-11 Eli Zaretskii <eliz@gnu.org>
648
649 * fileio.c (Finsert_file_contents): If the file cannot be opened,
650 set its "size" to -1. This will set the modtime_size field of
651 the corresponding buffer to -1, which is what
652 verify-visited-file-modtime expects for files that do not exist.
653 (Bug#9139)
654
655 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
656
657 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
658 here ...
659 * lisp.h: ... from here. push_key_description is no longer
660 defined in keyboard.c, so its declaration should not be in
661 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
662 logically belongs with push_key_description.
663
664 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
665
666 * buffer.h: Include <sys/types.h> instead of <time.h>.
667 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
668 Problem reported by Herbert J. Skuhra.
669
670 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
671
672 * xml.c (parse_region): Make the parsing work for
673 non-comment-starting XML files again (bug#9144).
674
675 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
676
677 * image.c (gif_load): Fix calculation of bottom and right corner.
678 (Bug#9468)
679
680 2011-09-10 Eli Zaretskii <eliz@gnu.org>
681
682 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
683 redisplay in small windows.
684
685 2011-09-09 Eli Zaretskii <eliz@gnu.org>
686
687 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
688
689 2011-09-08 Martin Rudalics <rudalics@gmx.at>
690
691 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
692 Operate on live windows only.
693
694 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
695
696 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
697
698 2011-09-07 Eli Zaretskii <eliz@gnu.org>
699
700 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
701 only under bidi iteration.
702
703 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
704
705 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
706
707 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
708
709 isnan: Fix porting problem to Solaris 10 with bundled gcc.
710 Without this fix, the command to link temacs failed due to an
711 undefined symbol __builtin_isnan. This is because
712 /usr/include/iso/math_c99.h #defines isnan(x) to
713 __builtin_isnan(x), but the bundled gcc, which identifies itself
714 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
715 a __builtin_isnan.
716 * floatfns.c (isnan): #undef, and then #define to a clone of
717 what's in data.c.
718 (Fisnan): Always define, since it's always available now.
719 (syms_of_floatfns): Always define isnan at the Lisp level.
720
721 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
722
723 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
724
725 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
726
727 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728 The previous code assumed that file offsets (off_t values) fit in
729 EMACS_INT variables, which is not true on typical 32-bit hosts.
730 The code messed up by falsely reporting buffer overflow in cases
731 such as (insert-file-contents "big" nil 1 2) into an empty buffer
732 when "big" contains more than 2**29 bytes, even though this
733 inserts just one byte and does not overflow the buffer.
734 (Finsert_file_contents): Store file offsets as off_t
735 values, not as EMACS_INT values. Check for overflow when
736 converting between EMACS_INT and off_t. When checking for
737 buffer overflow or for overlap, take the offsets into account.
738 Don't use EMACS_INT for small values where int suffices.
739 When checking for overlap, fix a typo: ZV was used where
740 ZV_BYTE was intended.
741 (Fwrite_region): Don't assume off_t fits into 'long'.
742 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
743
744 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
745
746 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
747
748 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
749
750 sprintf-related integer and memory overflow issues (Bug#9412).
751
752 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
753 (esprintf, exprintf, evxprintf): New functions.
754 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
755 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
756 (modify_event_symbol): Do not assume that the length of
757 name_alist_or_stem is safe to alloca and fits in int.
758 (Fexecute_extended_command): Likewise for function name and binding.
759 (Frecursion_depth): Wrap around reliably on integer overflow.
760 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
761 since some callers pass EMACS_INT values.
762 (Fsingle_key_description): Don't crash if symbol name contains more
763 than MAX_ALLOCA bytes.
764 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
765 (get_minibuffer): Arg is now EMACS_INT, not int.
766 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
767 (esprintf, exprintf, evxprintf): New decls.
768 * window.h (command_loop_level, minibuf_level): Reflect API changes.
769
770 * dbusbind.c (signature_cat): New function.
771 (xd_signature, Fdbus_register_signal):
772 Do not overrun buffer; instead, report string overflow.
773
774 * dispnew.c (add_window_display_history): Don't overrun buffer.
775 Truncate instead; this is OK since it's just a log.
776
777 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
778 even if the time zone offset is outlandishly large.
779 Don't mishandle offset == INT_MIN.
780
781 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
782 when creating daemon; the previous buffer-overflow check was incorrect.
783
784 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
785 which has the guts of the old verror function.
786
787 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
788 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
789
790 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
791 (font_unparse_xlfd): Don't blindly alloca long strings.
792 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
793 fits in int, when using sprintf. Use single snprintf to count
794 length of string rather than counting it via multiple sprintfs;
795 that's simpler and more reliable.
796 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
797 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
798 sprintf, in case result does not fit in int.
799
800 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
801 (fontset_from_font): Print it.
802
803 * frame.c (tty_frame_count): Now printmax_t, not int.
804 (make_terminal_frame, set_term_frame_name): Print it.
805 (x_report_frame_params): In X, window IDs are unsigned long,
806 not signed long, so print them as unsigned.
807 (validate_x_resource_name): Check for implausibly long names,
808 and don't assume name length fits in 'int'.
809 (x_get_resource_string): Don't blindly alloca invocation name;
810 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
811 not fit in int.
812
813 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
814 (xg_check_special_colors, xg_set_geometry):
815 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
816
817 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
818 Use esprintf, not sprintf, in case result does not fit in int.
819
820 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
821 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
822 it as a large positive number.
823 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
824 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
825
826 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
827 in case result does not fit in int.
828
829 * print.c (float_to_string): Detect width overflow more reliably.
830 (print_object): Make sprintf buffer a bit bigger, to avoid potential
831 buffer overrun. Don't assume list length fits in 'int'. Treat
832 print length of 0 as 0, not as infinity; to be consistent with other
833 uses of print length in this function. Don't overflow print length
834 index. Don't assume hash table size fits in 'long', or that
835 vectorlike size fits in 'unsigned long'.
836
837 * process.c (make_process): Use printmax_t, not int, to format
838 process-name gensyms.
839
840 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
841
842 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
843 to avoid potential buffer overrun.
844
845 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
846 if X resource line is longer than 512 bytes.
847
848 * xfns.c (x_window): Make sprintf buffer a bit bigger
849 to avoid potential buffer overrun.
850
851 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
852
853 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
854
855 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
856
857 Integer overflow fixes for scrolling, etc.
858 Without these, Emacs silently mishandles large integers sometimes.
859 For example, "C-u 4294967297 M-x recenter" was treated as if
860 it were "C-u 1 M-x recenter" on a typical 64-bit host.
861
862 * xdisp.c (try_window_id): Check Emacs fixnum range before
863 converting to 'int'.
864
865 * window.c (window_scroll_line_based, Frecenter):
866 Check that an Emacs fixnum is in range before assigning it to 'int'.
867 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
868 values converted from Emacs fixnums.
869 (Frecenter): Don't wrap around a line count if it is out of 'int'
870 range; instead, treat it as an extreme value.
871 (Fset_window_configuration, compare_window_configurations):
872 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
873
874 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
875 that can exceed INT_MAX. Check that EMACS_INT value is in range
876 before assigning it to the (possibly-narrower) index.
877 (match_limit): Don't assume that a fixnum can fit in 'int'.
878
879 * print.c (print_object): Use ptrdiff_t, not int, for index that can
880 exceed INT_MAX.
881
882 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
883 (Fvertical_motion): Don't wrap around LINES values that don't fit
884 in 'int'. Instead, treat them as extreme values. This is good
885 enough for windows, which can't have more than INT_MAX lines anyway.
886
887 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
888
889 * Require libxml/parser.h to avoid compilation warning.
890
891 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
892
893 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
894 since this reportedly can destroy thread storage.
895
896 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
897
898 * syntax.c (find_defun_start): Update all cache variables if
899 exiting early (Bug#9401).
900
901 2011-08-30 Eli Zaretskii <eliz@gnu.org>
902
903 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
904
905 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
906 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
907 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
908
909 * term.c (tty_append_glyph): New function.
910 (produce_stretch_glyph): Static function and its prototype deleted.
911
912 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
913 Add prototypes.
914
915 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
916
917 * image.c (parse_image_spec): Check for nonnegative, not for positive,
918 when checking :margin (Bug#9390).
919 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
920 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
921 so that the name doesn't mislead. All uses changed.
922
923 2011-08-28 Johan Bockgård <bojohan@gnu.org>
924
925 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
926 set_tty_hooks.
927
928 2011-08-27 Eli Zaretskii <eliz@gnu.org>
929
930 * xdisp.c (move_it_to): Don't bail out early when reaching
931 position beyond to_charpos, if we are scanning backwards.
932 (move_it_vertically_backward): When DY == 0, make sure we get to
933 the first character in the line after the newline.
934
935 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
936
937 * ccl.c: Improve and simplify overflow checking (Bug#9196).
938 (ccl_driver): Do not generate an out-of-range pointer.
939 (Fccl_execute_on_string): Remove unnecessary check for
940 integer overflow, noted by Stefan Monnier in
941 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
942 Remove a FIXME that didn't need fixing.
943 Simplify the newly-introduced buffer reallocation code.
944
945 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
946
947 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
948
949 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
950
951 Integer and memory overflow issues (Bug#9196).
952
953 * doc.c (get_doc_string): Rework so that
954 get_doc_string_buffer_size is the actual buffer size, rather than
955 being 1 less than the actual buffer size; this makes xpalloc more
956 convenient.
957
958 * image.c (x_allocate_bitmap_record, cache_image):
959 * xselect.c (Fx_register_dnd_atom):
960 Simplify previous changes by using xpalloc.
961
962 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
963 since either will do and ptrdiff_t is convenient with xpalloc.
964
965 * charset.c (charset_table_size)
966 (struct charset_sort_data.priority): Now ptrdiff_t.
967 (charset_compare): Don't overflow if priorities differ greatly.
968 (Fsort_charsets): Don't assume list length fits in int.
969 Check for size-calculation overflow when allocating sort data.
970 (syms_of_charset): Allocate an initial charset table that is
971 just under 64 KiB, to avoid problems with glibc malloc and mmap.
972
973 * cmds.c (internal_self_insert): Check for size-calculation overflow.
974
975 * composite.h (struct composition.glyph_len): Now int, not unsigned.
976 The actual value is always <= INT_MAX, and leaving it unsigned made
977 overflow checking harder.
978
979 * dispextern.h (struct glyph_matrix.rows_allocated)
980 (struct face_cache.size): Now ptrdiff_t, for convenience in use
981 with xpalloc. The values are still always <= INT_MAX.
982
983 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
984
985 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
986 (SAFE_NALLOCA): New macro.
987
988 * region-cache.c (struct boundary.pos, find_cache_boundary)
989 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
990 (set_cache_region, invalidate_region_cache)
991 (revalidate_region_cache, know_region_cache, region_cache_forward)
992 (region_cache_backward, pp_cache):
993 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
994 so that ptrdiff_t * can be passed to xpalloc.
995 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
996 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
997 (pp_cache): Don't assume cache_len fits in int.
998 * region-cache.h: Adjust extern decls to match.
999
1000 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1001 EMACS_INT, since either will do, for xpalloc.
1002
1003 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1004 (xnmalloc, xnrealloc, xpalloc): New functions.
1005
1006 * bidi.c (bidi_shelve_header_size): New constant.
1007 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1008 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1009
1010 * bidi.c (bidi_cache_shrink):
1011 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1012 (overlay_strings):
1013 Don't update size of array until after memory allocation succeeds,
1014 because xmalloc/xrealloc may not return.
1015 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1016 now that we have proper integer overflow checking.
1017 (record_overlay_string, overlay_strings): Catch overflows when
1018 calculating size of overlay_str_buf.
1019
1020 * callproc.c (Fcall_process): Check for size overflow when
1021 calculating size of args2.
1022 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1023 Normally we prefer signed values, but sticking with ptrdiff_t would
1024 require adding more-complicated checks.
1025
1026 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1027 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1028 Redo buffer-overflow calculations to avoid integer overflow.
1029 Add a FIXME comment where memory seems to be over-allocated.
1030
1031 * character.c (Fstring): Check for size-calculation overflow.
1032
1033 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1034 unnecessary integer overflow. Check for size overflow.
1035 (encode_coding_object): Don't update size until xmalloc succeeds.
1036
1037 * composite.c (get_composition_id): Check for overflow in glyph
1038 length calculations.
1039
1040 Integer and memory overflow fixes for display code.
1041 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1042 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1043 (scrolling_window): Check for overflow in size calculations.
1044 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1045 Don't assume glyph table len fits in int.
1046 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1047 (row_table_size): Now ptrdiff_t, not int.
1048 (scrolling_window): Avoid overflow in size calculations.
1049 Don't update size until allocation succeeds.
1050 * fns.c (concat): Check for overflow in size calculations.
1051 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1052 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1053 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1054
1055 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1056 (get_doc_string): Check for size calculation overflow.
1057 Don't update size until allocation succeeds.
1058 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1059 EMACS_INT, where ptrdiff_t will do.
1060 (Fsubstitute_command_keys): Check for string overflow.
1061
1062 * editfns.c (set_time_zone_rule): Don't assume environment length
1063 fits in int.
1064 (message_length): Now ptrdiff_t, not int.
1065 (Fmessage_box): Don't update size until allocation succeeds.
1066 Don't assume message length fits in int.
1067 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1068
1069 * emacs.c (main): Do not reallocate argv, since there is a null at
1070 the end that can be overwritten, and this way there's no need to
1071 worry about size-calculation overflow.
1072 (sort_args): Check for size-calculation overflow.
1073
1074 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1075 alloc succeeds.
1076 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1077
1078 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1079 (x_set_scroll_bar_width, x_figure_window_size):
1080 Check for integer overflow.
1081 (x_set_alpha): Do not assume XINT fits in int.
1082
1083 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1084 This is for the members text_lines, text_cols, total_lines, total_cols,
1085 where the system imposes an 'int' limit.
1086
1087 * fringe.c (Fdefine_fringe_bitmap):
1088 Don't update size until alloc works.
1089
1090 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1091 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1092
1093 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1094 Check for size-calculation overflow.
1095 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1096 do, as we prefer signed integers.
1097 (id_to_widget.max_size, id_to_widget.used)
1098 (xg_store_widget_in_map, xg_remove_widget_from_map)
1099 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1100 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1101 Use and return ptrdiff_t, not int.
1102 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1103 * gtkutil.h: Change prototypes to match the above.
1104
1105 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1106 are duplicate now that they've been promoted to lisp.h.
1107 (x_allocate_bitmap_record, x_alloc_image_color)
1108 (make_image_cache, cache_image, xpm_load):
1109 Don't update size until alloc is done.
1110 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1111 (x_detect_edges):
1112 Check for size calculation overflow.
1113 (ct_colors_allocated_max): New constant.
1114 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1115 overflow.
1116
1117 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1118 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1119 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1120 Use ptrdiff_t, not int, to count maps.
1121 (read_char_minibuf_menu_prompt): Check for overflow in size
1122 calculations. Don't update size until allocation succeeds.
1123 Redo calculations to avoid overflow.
1124 * keyboard.h: Change prototypes to match the above.
1125
1126 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1127 to count maps.
1128 (current_minor_maps): Check for size calculation overflow.
1129 * keymap.h: Change prototypes to match the above.
1130
1131 * lread.c (read1, init_obarray): Don't update size until alloc done.
1132
1133 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1134 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1135
1136 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1137 Now ptrdiff_t, not int.
1138 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1139 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1140
1141 * process.c (Fnetwork_interface_list): Check for overflow
1142 in size calculation.
1143
1144 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1145
1146 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1147 overflow. Don't bother calling xmalloc when xrealloc will do.
1148
1149 * search.c (Freplace_match): Check for size calculation overflow.
1150 (Fset_match_data): Don't assume list lengths fit in 'int'.
1151
1152 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1153 for command line length. Do not attempt to address one before the
1154 beginning of an array, as that's not portable.
1155
1156 * term.c (max_frame_lines): Remove; unused.
1157 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1158 not int.
1159 (encode_terminal_code, calculate_costs): Check for size
1160 calculation overflow.
1161 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1162 table lengths and related sizes. Don't update size until alloc
1163 done. Redo calculations to avoid overflow.
1164 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1165
1166 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1167 subtracting pointers.
1168 (gobble_line): Check for overflow more carefully. Don't update size
1169 until alloc done.
1170
1171 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1172 Don't update size until alloc done.
1173 Redo size calculations to avoid overflow.
1174 Check for size calculation overflow.
1175 (main) [DEBUG]: Fix typo in invoking tparam1.
1176
1177 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1178 Use ptrdiff_t, not int, for sizes.
1179 (store_mode_line_noprop_char): Don't update size until alloc done.
1180
1181 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1182 Use ptrdiff_t, not int, for sizes.
1183 (Finternal_make_lisp_face, cache_face):
1184 Check for size calculation overflow.
1185 (cache_face): Treat size calculation overflows as if they were
1186 memory exhaustion (the usual treatment), rather than aborting.
1187
1188 * xfns.c (x_encode_text, x_set_name_internal)
1189 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1190 sizes, since they can exceed INT_MAX in size. Check for size
1191 calculation overflow.
1192
1193 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1194 (xg_select): Check for size calculation overflow.
1195 Don't update size until alloc done.
1196
1197 * xrdb.c (get_environ_db): Don't assume path length fits in int,
1198 as sprintf is limited to int lengths.
1199
1200 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1201 (X_LONG_MIN): New macros.
1202 Use them to make the following changes clearer.
1203 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1204 This change doesn't affect the value now, but it may help remind
1205 future maintainers not to raise the value too much later.
1206 (SELECTION_QUANTUM): Remove, replacing with ...
1207 (selection_quantum): ... new function, which avoids overflow.
1208 All uses changed.
1209 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1210 assumption that selection length fits in 'int'.
1211 (x_reply_selection_request, x_handle_selection_request)
1212 (x_get_window_property, receive_incremental_selection)
1213 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1214 (lisp_data_to_selection_data, clean_local_selection_data):
1215 Use ptrdiff_t, not int, to record length of selection.
1216 (x_reply_selection_request, x_get_window_property)
1217 (receive_incremental_selection, x_property_data_to_lisp):
1218 Redo calculations to avoid overflow.
1219 (x_reply_selection_request): When sending hint, ceiling it at
1220 X_LONG_MAX rather than relying on wraparound overflow to send
1221 something.
1222 (x_get_window_property, receive_incremental_selection)
1223 (lisp_data_to_selection_data, x_property_data_to_lisp):
1224 Check for size-calculation overflow.
1225 (x_get_window_property, receive_incremental_selection)
1226 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1227 Don't store size until memory allocation succeeds.
1228 (x_get_window_property): Plug memory leak on memory exhaustion.
1229 Don't double-block input; malloc is safe here. Don't assume 2**34
1230 - 4 fits in unsigned long. Add an xassert to check
1231 XGetWindowProperty overflow. Be more careful about overflow
1232 calculations, and distinguish size from memory overflow better.
1233 (receive_incremental_selection): When tracing, don't assume
1234 unsigned int is less than INT_MAX.
1235 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1236 harmful) conversions of unsigned short to int.
1237 (lisp_data_to_selection_data): Don't assume that integers
1238 in the range -65535 through -1 fit in an X unsigned short.
1239 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1240 result parameters unless successful. Rely on cons_to_unsigned
1241 to report problems with elements; the old code wasn't right anyway.
1242 (x_check_property_data): Check for int overflow; we cannot use
1243 a wider type due to X limits.
1244 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1245
1246 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
1247
1248 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1249 (x_term_init): Check for size calculation overflow.
1250 (x_color_cells): Don't store size until memory allocation succeeds.
1251 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
1252 Don't assume alloca size is less than MAX_ALLOCA.
1253 (x_term_init): Don't assume length fits in int (sprintf is limited
1254 to int size).
1255
1256 Use ptrdiff_t for composition IDs.
1257 * character.c (lisp_string_width):
1258 * composite.c (composition_table_size, n_compositions)
1259 (get_composition_id, composition_gstring_from_id):
1260 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1261 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1262 * window.c (Frecenter):
1263 Use ptrdiff_t, not int, for composition IDs.
1264 * composite.c (get_composition_id): Check for integer overflow.
1265 * composite.h: Adjust prototypes to match the above changes.
1266
1267 Use ptrdiff_t for hash table indexes.
1268 * category.c (hash_get_category_set):
1269 * ccl.c (ccl_driver):
1270 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1271 * coding.c (coding_system_charset_list, detect_coding_system):
1272 * coding.h (struct coding_system.id):
1273 * composite.c (get_composition_id, gstring_lookup_cache):
1274 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1275 * image.c (xpm_get_color_table_h):
1276 * lisp.h (hash_lookup, hash_put):
1277 * minibuf.c (Ftest_completion):
1278 Use ptrdiff_t for hash table indexes, not int (which is too
1279 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1280 32-bit --with-wide-int hosts).
1281
1282 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1283 Add a FIXME comment about memory leaks.
1284 (syms_of_charset): Don't assume xmalloc returns.
1285
1286 Don't assume that stated character widths fit in int.
1287 * character.c (Fchar_width, c_string_width, lisp_string_width):
1288 * character.h (CHAR_WIDTH):
1289 * indent.c (MULTIBYTE_BYTES_WIDTH):
1290 Use sanitize_char_width to avoid undefined and/or bad behavior
1291 with outlandish widths.
1292 * character.h (sanitize_tab_width): Rename from sanitize_width,
1293 now that we have two such functions. All uses changed.
1294 (sanitize_char_width): New inline function.
1295
1296 Don't assume that tab-width fits in int.
1297 * character.h (sanitize_width): New inline function.
1298 (SANE_TAB_WIDTH): New macro.
1299 (ASCII_CHAR_WIDTH): Use it.
1300 * indent.c (sane_tab_width): Remove. All uses replaced by
1301 SANE_TAB_WIDTH (current_buffer).
1302 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1303
1304 * fileio.c: Integer overflow issues with file modes.
1305 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1306
1307 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1308 Remove unreachable code.
1309 (read_hex, load_charset_map_from_file): Check for integer overflow.
1310
1311 * xterm.c: don't go over XClientMessageEvent limit
1312 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1313 (x_send_scroll_bar_event): Likewise. Check that the size does not
1314 exceed limits imposed by XClientMessageEvent, as well as the usual
1315 ptrdiff_t and size_t limits.
1316
1317 * keyboard.c: Overflow, signedness and related fixes.
1318 (make_lispy_movement): Use same integer type in forward decl
1319 that is used in the definition.
1320 (read_key_sequence, keyremap_step):
1321 Change bufsize argument back to int, undoing my 2011-03-30 change.
1322 We prefer signed types, and int is wide enough here.
1323 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1324 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1325 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1326 length, not size_t. Use ptrdiff_t for index, not int.
1327 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1328 possibility of integer overflow.
1329
1330 Overflow, signedness and related fixes for images.
1331
1332 * dispextern.h (struct it.stack[0].u.image.image_id)
1333 (struct_it.image_id, struct image.id, struct image_cache.size)
1334 (struct image_cache.used, struct image_cache.ref_count):
1335 * gtkutil.c (update_frame_tool_bar):
1336 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1337 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1338 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1339 * nsmenu.m (update_frame_tool_bar):
1340 * xdisp.c (calc_pixel_width_or_height):
1341 * xfns.c (image_cache_refcount):
1342 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1343 on typical 64-bit hosts.
1344
1345 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1346 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1347 Omit unnecessary casts to int.
1348 (parse_image_spec): Check that integers fall into 'int' range
1349 when the callers expect that.
1350 (image_ascent): Redo ascent calculation to avoid int overflow.
1351 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1352 (lookup_image): Remove unnecessary tests.
1353 (xbm_image_p): Locals are now of int, not EMACS_INT,
1354 since parse_image_check makes sure they fit into int.
1355 (png_load, gif_load, svg_load_image):
1356 Prefer int to unsigned where either will do.
1357 (tiff_handler): New function, combining the cores of the
1358 old tiff_error_handler and tiff_warning_handler.
1359 This function is rewritten to use vsnprintf and thereby avoid
1360 stack buffer overflows. It uses only the features of vsnprintf
1361 that are common to both POSIX and native Microsoft.
1362 (tiff_error_handler, tiff_warning_handler): Use it.
1363 (tiff_load, gif_load, imagemagick_load_image):
1364 Don't assume :index value fits in 'int'.
1365 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1366 (imagemagick_load_image): Check that crop parameters fit into
1367 the integer types that MagickCropImage accepts. Don't assume
1368 Vimagemagick_render_type has a nonnegative value. Don't assume
1369 size_t fits in 'long'.
1370 (gs_load): Use printmax_t to print the widest integers possible.
1371 Check for integer overflow when computing image height and width.
1372
1373 2011-08-26 Eli Zaretskii <eliz@gnu.org>
1374
1375 * xdisp.c (redisplay_window): Don't force window start if point
1376 will be invisible in the resulting window. (Bug#9324)
1377
1378 2011-08-25 Eli Zaretskii <eliz@gnu.org>
1379
1380 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1381 the display spec is of the form `(space ...)'.
1382 (handle_display_spec): Return the value returned by
1383 handle_single_display_spec, not just 1 or zero.
1384 (handle_single_display_spec): If the display spec is of the form
1385 `(space ...)', and specifies display in the text area, return 2
1386 rather than 1.
1387 (try_cursor_movement): Check for the need to scroll more
1388 accurately, and prefer exact match for point under bidi.
1389 Don't advance `row' beyond the last row of the window.
1390
1391 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1392 into disp_prop; all users changed.
1393
1394 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1395 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1396 for the text covered by the display property.
1397
1398 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
1399
1400 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1401 Change return value to nil.
1402 (Frecord_buffer): Delete unused function.
1403
1404 2011-08-24 Eli Zaretskii <eliz@gnu.org>
1405
1406 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1407 buffers, return left-to-right.
1408 (set_cursor_from_row): Consider candidate row a win if its glyph
1409 represents a newline and point is on that newline. Fixes cursor
1410 positioning on the newline at EOL of R2L text within L2R
1411 paragraph, and vice versa.
1412 (try_cursor_movement): Check continued rows, in addition to
1413 continuation rows. Fixes unwarranted scroll when point enters a
1414 continued line of R2L text within an L2R paragraph, or vice versa.
1415 (cursor_row_p): Consider the case of point being equal to
1416 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
1417 from the end of a short line to the beginning of a continued line
1418 of R2L text within L2R paragraph.
1419 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
1420 composed characters.
1421
1422 * bidi.c (bidi_check_type): Use xassert.
1423 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
1424 members.
1425
1426 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1427
1428 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
1429 a character.
1430
1431 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
1432
1433 * nsfont.m (ns_otf_to_script): Fix typo.
1434
1435 2011-08-22 Kenichi Handa <handa@m17n.org>
1436
1437 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
1438 extra slot even if the purpose is char-code-property-table.
1439
1440 2011-08-23 Eli Zaretskii <eliz@gnu.org>
1441
1442 * xdisp.c (redisplay_window): When computing centering_position,
1443 account for the height of the header line. (Bug#8874)
1444
1445 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
1446 instead of CHAR_TO_BYTE. Fixes a crash when a completion
1447 candidate is selected by the mouse, and that candidate has a
1448 composed character under the mouse.
1449
1450 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
1451 coordinates reported by pos-visible-in-window-p for a composed
1452 character in column zero.
1453
1454 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
1455
1456 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
1457
1458 2011-08-22 Eli Zaretskii <eliz@gnu.org>
1459
1460 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
1461 consider it a hit if to_charpos is anywhere in the range of the
1462 composed buffer positions.
1463
1464 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
1465
1466 * image.c (gif_load): Don't assume that each subimage has the same
1467 dimensions as the base image. Handle disposal method that is
1468 "undefined" by the gif spec (Bug#9335).
1469
1470 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
1471
1472 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
1473 (Fcondition_case): Document `debug' symbol in error handler.
1474
1475 2011-08-19 Eli Zaretskii <eliz@gnu.org>
1476
1477 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
1478 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
1479 from an Org mode buffer to a Speedbar frame.
1480
1481 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
1482 a composition, take its buffer position from IT->cmp_it.charpos.
1483 Fixes cursor positioning at the beginning of a line that begins
1484 with a composed character.
1485
1486 2011-08-18 Eli Zaretskii <eliz@gnu.org>
1487
1488 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
1489 character bidirectional type, use STRONG_L instead. Fixes crashes
1490 in a buffer produced by `describe-categories'.
1491
1492 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
1493 members before the level stack, so they would be saved and
1494 restored when copying iterator state. Fixes incorrect reordering
1495 around TABs covered by display properties.
1496
1497 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
1498
1499 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
1500
1501 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
1502
1503 * eval.c (internal_condition_case, internal_condition_case_1)
1504 (internal_condition_case_2, internal_condition_case_n):
1505 Remove unnecessary aborts (Bug#9081).
1506
1507 2011-08-17 Eli Zaretskii <eliz@gnu.org>
1508
1509 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
1510 has no `load' handler, try opening the file locally. (Bug#9311)
1511
1512 2011-08-16 Ken Brown <kbrown@cornell.edu>
1513
1514 * gmalloc.c: Expand comment.
1515
1516 2011-08-16 Eli Zaretskii <eliz@gnu.org>
1517
1518 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
1519 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
1520
1521 2011-08-16 Ken Brown <kbrown@cornell.edu>
1522
1523 Fix memory allocation problems in Cygwin build (Bug#9273).
1524
1525 * unexcw.c ( __malloc_initialized): Declare external variable.
1526 (fixup_executable): Force the dumped emacs to reinitialize malloc.
1527
1528 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
1529 New variables.
1530 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
1531 dumped emacs.
1532 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
1533 in the static heap.
1534 [CYGWIN] (special_realloc): New function.
1535 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
1536 requests to realloc storage in the static heap.
1537
1538 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
1539
1540 * bidi.c (bidi_initialize): Remove unused local.
1541
1542 2011-08-15 Eli Zaretskii <eliz@gnu.org>
1543
1544 * bidimirror.h:
1545 * biditype.h: Remove file.
1546 * makefile.w32-in ($(BLD)/bidi.$(O)):
1547 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
1548
1549 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1550
1551 * chartab.c: Improve commentary for the uniprop_table API.
1552
1553 * bidi.c (bidi_paragraph_init): Support zero value of
1554 bidi_ignore_explicit_marks_for_paragraph_level.
1555 (bidi_initialize): Use uniprop_table instead of including
1556 biditype.h and bidimirror.h.
1557
1558 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1559 coordinates of the iterator when restoring from ppos_it.
1560 (Bug#9296)
1561
1562 2011-08-14 Kenichi Handa <handa@m17n.org>
1563
1564 * process.c (create_process): Call setup_process_coding_systems
1565 after the pid of the process is set to -1 (Bug#8162).
1566
1567 2011-08-14 Eli Zaretskii <eliz@gnu.org>
1568
1569 * xdisp.c (move_it_in_display_line_to): Don't invoke
1570 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1571 ppos_it. Fixes vertical cursor motion when line beginning is
1572 covered by an image. (Bug#9296)
1573
1574 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1575
1576 * nsterm.h (ns_run_ascript): Declare.
1577 (NSAPP_DATA2_RUNASSCRIPT): Define.
1578
1579 * nsfns.m (as_script, as_result, as_status): New static variables.
1580 (ns_run_ascript): New function.
1581 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
1582 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1583 the event loop. Get status from as_status (Bug#7276).
1584
1585 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1586 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1587 the event loop (Bug#7276).
1588
1589 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1590
1591 * gnutls.c (QCgnutls_bootprop_priority)
1592 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1593 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1594 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1595 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1596 (QCgnutls_bootprop_verify_hostname_error)
1597 (QCgnutls_bootprop_callbacks_verify): Rename from
1598 Qgnutls_bootprop_..., all uses changed.
1599
1600 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1601 uses changed.
1602
1603 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1604
1605 * xfaces.c (Qframe_set_background_mode): Now static.
1606 * dispextern.h (Qframe_set_background_mode): Remove decl.
1607
1608 * process.c (Fnetwork_interface_info): Declare local only if needed.
1609
1610 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1611
1612 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1613 (Fnetwork_interface_list): Allocate in increments of bytes instead
1614 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1615 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1616 sockaddr.
1617 (struct ifflag_def): notrailers is smart on OSX.
1618 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1619 Get hardware address with getifaddrs if available.
1620
1621 2011-08-12 Eli Zaretskii <eliz@gnu.org>
1622
1623 * xdisp.c (iterate_out_of_display_property): xassert that
1624 IT->position is set to within IT->object's boundaries. Break from
1625 the loop as soon as EOB is reached; avoids infloops in redisplay
1626 when IT->position is set up wrongly due to some bug.
1627 Set IT->current to match the bidi iterator unconditionally.
1628 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1629 entry. Force push_it to save on the stack the current
1630 buffer/string position, to be restored by pop_it. Fix flags in
1631 the iterator structure wrt the object coming from a display
1632 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1633 properties. (Bug#9284)
1634
1635 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
1636
1637 * fontset.c (fontset_get_font_group): Add proper type checks.
1638 (Bug#9172)
1639
1640 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1641
1642 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1643 and LC_VERSION_MIN_MACOSX.
1644 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1645 (dump_it) [LC_FUNCTION_STARTS]: Use it.
1646
1647 2011-08-08 Eli Zaretskii <eliz@gnu.org>
1648
1649 * xdisp.c (forward_to_next_line_start): Allow to use the
1650 no-display-properties-and-no-overlays under bidi display.
1651 Set disp_pos in the bidi iterator to avoid searches for display
1652 properties and overlays.
1653
1654 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
1655
1656 * editfns.c (Fset_time_zone_rule): Document relationship with the
1657 setenv function.
1658
1659 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1660 the font entity extracted from the cache (Bug#8109).
1661
1662 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
1663
1664 * composite.c (autocmp_chars): Don't reset point. That is done by
1665 restore_point_unwind (Bug#5984).
1666
1667 2011-08-07 Juri Linkov <juri@jurta.org>
1668
1669 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1670 to show the arg `TIME' instead of `TIMEVAL'.
1671
1672 2011-08-06 Eli Zaretskii <eliz@gnu.org>
1673
1674 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1675 display property strides EOL and includes a newline, as in
1676 longlines-mode. (Bug#9254)
1677 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1678 word-wrap under bidirectional display. (Bug#9224)
1679
1680 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1681 is non-zero, even if the data buffer is NULL. Fixes a crash in
1682 vertical-motion with longlines-mode. (Bug#9254)
1683
1684 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1685
1686 * bidi.c <bidi_cache_total_alloc>: Now static.
1687 (bidi_initialize): Initialize bidi_cache_total_alloc.
1688
1689 * xdisp.c (display_line): Release buffer allocated for shelved bidi
1690 cache. (Bug#9221)
1691
1692 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1693 amount allocated this far in `bidi_cache_total_alloc'.
1694 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1695 non-zero, only free the data buffer without restoring the cache
1696 contents. All callers changed.
1697
1698 * dispextern.h (bidi_unshelve_cache): Update prototype.
1699
1700 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1701 (move_it_in_display_line, move_it_to)
1702 (move_it_vertically_backward, move_it_by_lines): Replace the call
1703 to xfree to an equivalent call to bidi_unshelve_cache.
1704 (move_it_in_display_line_to): Fix logic of returning
1705 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
1706
1707 2011-08-05 Eli Zaretskii <eliz@gnu.org>
1708
1709 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1710 came from a string character with a `cursor' property. (Bug#9229)
1711
1712 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1713
1714 * Makefile.in (LIB_PTHREAD): New variable.
1715 (LIBES): Add LIB_PTHREAD (Bug#9216).
1716
1717 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1718 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1719
1720 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1721
1722 * regex.c (re_iswctype): Remove some redundant boolean conversions.
1723
1724 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1725
1726 * xterm.c (x_find_topmost_parent): New function.
1727 (x_set_frame_alpha): Find topmost parent window with
1728 x_find_topmost_parent and set the property there also (bug#9181).
1729 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1730
1731 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1732
1733 * callproc.c (Fcall_process): Avoid vfork clobbering
1734 the local vars buffer, coding_systems, current_dir.
1735
1736 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1737
1738 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1739
1740 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1741
1742 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1743 so that it is not optimized away.
1744
1745 * xdisp.c (compute_display_string_pos): Remove unused local.
1746
1747 2011-08-02 Eli Zaretskii <eliz@gnu.org>
1748
1749 Fix slow cursor motion and scrolling in large buffers with
1750 selective display, like Org Mode buffers. (Bug#9218)
1751
1752 * dispextern.h (struct bidi_it): New member disp_prop_p.
1753
1754 * xdisp.c: Remove one-slot cache of display string positions.
1755 (compute_display_string_pos): Accept an additional argument
1756 DISP_PROP_P; callers changed. Scan at most 5K characters forward
1757 for a display string or property. If found, set DISP_PROP_P
1758 non-zero.
1759
1760 * bidi.c (bidi_fetch_char): Accept an additional argument
1761 DISP_PROP_P, and pass it to compute_display_string_pos.
1762 Only handle text covered by a display string if DISP_PROP_P is returned
1763 non-zero. All callers of bidi_fetch_char changed.
1764
1765 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1766
1767 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1768
1769 2010-12-03 Don March <don@ohspite.net>
1770
1771 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1772 last character M-[char] is translated to ESC [char] (bug#7541).
1773
1774 2011-08-02 Kenichi Handa <handa@m17n.org>
1775
1776 * lisp.h (uniprop_table): Extern it.
1777
1778 * chartab.c (uniprop_table): Make it non-static.
1779
1780 2011-08-01 Eli Zaretskii <eliz@gnu.org>
1781
1782 * xdisp.c (forward_to_next_line_start): Accept additional argument
1783 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1784 on the newline.
1785 (reseat_at_next_visible_line_start): Use the bidi iterator state
1786 returned by forward_to_next_line_start to restore the state of
1787 it->bidi_it after backing up to previous newline. (Bug#9212)
1788
1789 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1790
1791 * regex.c (re_comp): Protoize.
1792 (re_exec): Fix return type.
1793 (regexec): Fix type of `ret'. (Bug#9203)
1794
1795 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1796
1797 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1798 This is needed if max-image-size is a floating-point number.
1799
1800 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1801
1802 * print.c (print_object): Print empty symbol as ##.
1803
1804 * lread.c (read1): Read ## as empty symbol.
1805
1806 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1807
1808 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1809 setting frame foreground color (Bug#9175).
1810 (x_set_background_color): Likewise.
1811
1812 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1813 contents (Bug#9176).
1814 (EmacsTooltip -init): Remove bezels and add shadows to
1815 tooltip windows.
1816
1817 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1818 or scroll bar (Bug#8470).
1819
1820 * nsfont.m (nsfont_open): Remove assignment to voffset and
1821 unnecessary vars hshink, expand, hd, full_height, min_height.
1822 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1823
1824 * nsterm.h (nsfont_info): Remove voffset field.
1825
1826 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1827
1828 Implement strike-through and overline on NextStep (Bug#8863).
1829
1830 * nsfont.m (nsfont_open): Use underline position provided by font,
1831 instead of hard-coded value of 2.
1832 (nsfont_draw): Call ns_draw_text_decoration instead.
1833
1834 * nsterm.h: Add declaration for ns_draw_text_decoration.
1835
1836 * nsterm.m (ns_draw_text_decoration): New function for drawing
1837 underline, overline, and strike-through.
1838 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1839 ns_draw_text_decoration. Change treatment of cursor drawing to
1840 accommodate underlining, etc.
1841
1842 2011-07-28 Eli Zaretskii <eliz@gnu.org>
1843
1844 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1845 default.
1846
1847 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1848
1849 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1850 Without this fix, if a signal arrives just after memory fills up,
1851 'malloc' might be invoked reentrantly.
1852
1853 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1854 In other words, assume that every image size is allowed, on non-X
1855 hosts. This assumption is probably wrong, but it lets Emacs compile.
1856
1857 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1858
1859 * regex.c (re_iswctype): Convert return values to boolean.
1860
1861 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1862
1863 * xdisp.c (compute_display_string_pos): Don't use cached display
1864 string position if the buffer had its restriction changed.
1865 (Bug#9184)
1866
1867 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1868
1869 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1870
1871 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1872
1873 Integer signedness and overflow and related fixes. (Bug#9079)
1874
1875 * bidi.c: Integer size and overflow fixes.
1876 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1877 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1878 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1879 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1880 (bidi_find_other_level_edge):
1881 Use ptrdiff_t instead of EMACS_INT where either will do.
1882 This works better on 32-bit hosts configured --with-wide-int.
1883 (bidi_cache_ensure_space): Check for size-calculation overflow.
1884 Use % rather than repeated addition, for better worst-case speed.
1885 Don't set bidi_cache_size until after xrealloc returns, because it
1886 might not return.
1887 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
1888 (bidi_cache_ensure_space): Also check that the bidi cache size
1889 does not exceed that of the largest Lisp string or buffer. See Eli
1890 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
1891
1892 * alloc.c (__malloc_size_t): Remove.
1893 All uses replaced by size_t. See Andreas Schwab's note
1894 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1895
1896 * image.c: Improve checking for integer overflow.
1897 (check_image_size): Assume that f is nonnull, since
1898 it is always nonnull in practice. This is one less thing to
1899 worry about when checking for integer overflow later.
1900 (x_check_image_size): New function, which checks for integer
1901 overflow issues inside X.
1902 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1903 This removes the need for a memory_full check.
1904 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1905 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1906 (xbm_read_bitmap_data): Change locals back to 'int', since
1907 their values must fit in 'int'.
1908 (xpm_load_image, png_load, tiff_load):
1909 Invoke x_create_x_image_and_pixmap earlier,
1910 to avoid much needless work if the image is too large.
1911 (tiff_load): Treat overly large images as if
1912 x_create_x_image_and_pixmap failed, not as malloc failures.
1913 (gs_load): Use x_check_image_size.
1914
1915 * gtkutil.c: Omit integer casts.
1916 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1917 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1918
1919 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1920
1921 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1922 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1923 would wrongly return t on a 64-bit host.
1924
1925 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1926 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1927 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1928 and therefore cause GCC to emit a bogus diagnostic in some cases.
1929
1930 * image.c: Integer signedness and overflow and related fixes.
1931 This is not an exhaustive set of fixes, but it's time to
1932 record what I've got.
1933 (lookup_pixel_color, check_image_size): Remove redundant decls.
1934 (check_image_size): Don't assume that arbitrary EMACS_INT values
1935 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1936 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1937 (tiff_load, imagemagick_load_image):
1938 Check for overflow in size calculations.
1939 (x_create_x_image_and_pixmap): Remove unnecessary test for
1940 xmalloc returning NULL; that can't happen.
1941 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1942 (xpm_color_bucket): Use better integer hashing function.
1943 (xpm_cache_color): Don't possibly over-allocate memory.
1944 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1945 (gif_memory_source):
1946 Use ptrdiff_t, not int or size_t, to record sizes.
1947 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1948 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1949 either works, as we prefer signed integers.
1950 (tiff_read_from_memory, tiff_write_from_memory):
1951 Return tsize_t, not size_t, since that's what the TIFF API wants.
1952 (tiff_read_from_memory): Don't fail simply because the read would
1953 go past EOF; instead, return a short read.
1954 (tiff_load): Omit no-longer-needed casts.
1955 (Fimagemagick_types): Don't assume size fits into 'int'.
1956
1957 Improve hashing quality when configured --with-wide-int.
1958 * fns.c (hash_string): New function, taken from sxhash_string.
1959 Do not discard information about ASCII character case; this
1960 discarding is no longer needed.
1961 (sxhash-string): Use it. Change sig to match it. Caller changed.
1962 * lisp.h: Declare it.
1963 * lread.c (hash_string): Remove, since we now use fns.c's version.
1964 The fns.c version returns a wider integer if --with-wide-int is
1965 specified, so this should help the quality of the hashing a bit.
1966
1967 * emacs.c: Integer overflow minor fix.
1968 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1969 Define only if GNU_LINUX.
1970 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1971
1972 * dispnew.c: Integer signedness and overflow fixes.
1973 Remove unnecessary forward decls, that were a maintenance hassle.
1974 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1975 All uses changed.
1976 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1977 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1978 (prepare_desired_row, line_draw_cost):
1979 Use int, not unsigned, where either works.
1980 (save_current_matrix, restore_current_matrix):
1981 Use ptrdiff_t, not size_t, where either works.
1982 (init_display): Check for overflow more accurately, and without
1983 relying on undefined behavior.
1984
1985 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1986 Remove, replacing with the new symbols in lisp.h. All uses changed.
1987 * fileio.c (make_temp_name):
1988 * filelock.c (lock_file_1, lock_file):
1989 * xdisp.c (message_dolog):
1990 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1991 Use pMd etc. instead.
1992 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1993 replacing the pWIDE etc. symbols removed from editfns.c.
1994
1995 * keyboard.h (num_input_events): Now uintmax_t.
1996 This is (very slightly) less likely to mess up due to wraparound.
1997 All uses changed.
1998
1999 * buffer.c: Integer signedness fixes.
2000 (alloc_buffer_text, enlarge_buffer_text):
2001 Use ptrdiff_t rather than size_t when either will do, as we prefer
2002 signed integers.
2003
2004 * alloc.c: Integer signedness and overflow fixes.
2005 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2006 (__malloc_size_t): Default to size_t, not to int.
2007 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2008 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2009 Prefer ptrdiff_t to size_t when either would do, as we prefer
2010 signed integers.
2011 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2012 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2013 Now const. Initialize with values that are in range even if char
2014 is signed.
2015 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2016 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2017 These functions do the right thing with sizes > 2**32.
2018 (check_depth): Now ptrdiff_t, not int.
2019 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2020 Adjust to new way of storing sizes. Check for size overflow bugs
2021 in rest of code.
2022 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2023 slightly wrong anyway, as it missed one instance of
2024 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2025 (refill_memory_reserve): Omit needless cast to size_t.
2026 (mark_object_loop_halt): Mark as externally visible.
2027
2028 * xselect.c: Integer signedness and overflow fixes.
2029 (Fx_register_dnd_atom, x_handle_dnd_message):
2030 Use ptrdiff_t, not size_t, since we prefer signed.
2031 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2032 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2033 x_dnd_atoms_size and x_dnd_atoms_length.
2034
2035 * doprnt.c: Prefer signed to unsigned when either works.
2036 * eval.c (verror):
2037 * doprnt.c (doprnt):
2038 * lisp.h (doprnt):
2039 * xdisp.c (vmessage):
2040 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2041 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2042 prefer signed arithmetic to avoid comparison confusion.
2043 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2044 but is a bit tricky.
2045
2046 Assume freestanding C89 headers, string.h, stdlib.h.
2047 * data.c, doprnt.c, floatfns.c, print.c:
2048 Include float.h unconditionally.
2049 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2050 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2051 * regex.c: Likewise for stddef.h, string.h.
2052 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2053 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2054 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2055 (STDC_HEADERS): Remove obsolete defines.
2056 * sysdep.c: Include limits.h unconditionally.
2057
2058 Assume support for memcmp, memcpy, memmove, memset.
2059 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2060 * regex.c (memcmp, memcpy):
2061 Remove; we assume C89 now.
2062
2063 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2064 (__malloc_safe_bcopy): Remove; no longer needed.
2065
2066 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
2067 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2068 well either way, and we prefer signed to unsigned.
2069
2070 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2071
2072 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2073 closes the connection while we're reading (bug#9182).
2074
2075 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
2076
2077 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2078 are specified (Bug#9168).
2079
2080 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2081
2082 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2083 Found by GCC static checking and --with-wide-int on a 32-bit host.
2084
2085 2011-07-25 Eli Zaretskii <eliz@gnu.org>
2086
2087 * xdisp.c (compute_display_string_pos): Fix logic of caching
2088 previous display string position. Initialize cached_prev_pos to
2089 -1. Fixes slow-down at the beginning of a buffer.
2090
2091 2011-07-24 Eli Zaretskii <eliz@gnu.org>
2092
2093 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2094 for attrs[LFACE_FONTSET_INDEX].
2095
2096 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2097
2098 * xml.c (parse_region): Remove unused local
2099 that was recently introduced.
2100
2101 2011-07-23 Eli Zaretskii <eliz@gnu.org>
2102
2103 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2104 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2105
2106 * xdisp.c (move_it_in_display_line_to): Record the best matching
2107 position for TO_CHARPOS while scanning the line, and restore it on
2108 exit if none of the characters scanned was an exact match.
2109 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
2110 when exact match is impossible due to invisible text, and the
2111 lines are truncated.
2112
2113 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2114
2115 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2116 for OSX >= 10.7.
2117
2118 2011-07-22 Eli Zaretskii <eliz@gnu.org>
2119
2120 Fix a significant slow-down of cursor motion with C-n, C-p,
2121 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2122 auto-repeat under bidi redisplay in fontified buffers.
2123 * xdisp.c (compute_stop_pos_backwards): New function.
2124 (next_element_from_buffer): Call compute_stop_pos_backwards to
2125 find a suitable prev_stop when we find ourselves before
2126 base_level_stop.
2127 (reseat): Don't look for prev_stop, as that could mean a very long
2128 run.
2129 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2130 <cached_disp_overlay_modiff>: Cache for last found display string
2131 position.
2132 (compute_display_string_pos): Return the cached position if asked
2133 about the same buffer in the same area of character positions, and
2134 the buffer wasn't changed since the time the display string
2135 position was cached.
2136
2137 2011-07-22 Eli Zaretskii <eliz@gnu.org>
2138
2139 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2140 is an integer, which is important for empty lines. (Bug#9149)
2141
2142 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
2143
2144 * frame.c (Fmodify_frame_parameters): In tty case, update the
2145 default face if necessary (Bug#4238).
2146
2147 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
2148
2149 * editfns.c (Fstring_to_char): No need to explain what a character
2150 is in the docstring (Bug#6576).
2151
2152 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2153
2154 * xml.c (parse_region): Make sure we always return a tree.
2155
2156 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2157
2158 * xml.c (parse_region): If a document contains only comments,
2159 return that, too.
2160
2161 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2162
2163 * xml.c (make_dom): Return comments, too.
2164
2165 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2166
2167 Port to OpenBSD.
2168 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2169 and the surrounding thread.
2170 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2171 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2172 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2173 timer goes off.
2174 * s/openbsd.h (BROKEN_SIGIO): Define.
2175 * unexelf.c (unexec) [__OpenBSD__]:
2176 Don't update the .mdebug section of the Alpha COFF symbol table.
2177
2178 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2179
2180 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2181 (bug#8460).
2182
2183 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2184
2185 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2186 This fixes some race conditions on the permissions of any newly
2187 created file.
2188
2189 * alloc.c (valid_pointer_p): Use pipe, not open.
2190 This fixes some permissions issues when debugging.
2191
2192 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2193 If fchown fails to set both uid and gid, try to set just gid,
2194 as that is sometimes allowed. Adjust the file's mode to eliminate
2195 setuid or setgid bits that are inappropriate if fchown fails.
2196
2197 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2198
2199 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2200 to compare Lisp_Objects.
2201 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2202 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2203 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2204
2205 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2206
2207 * lread.c (read_integer): Unread even EOF character.
2208 (read1): Likewise. Properly record start position of symbol.
2209
2210 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2211 symbol character follows.
2212
2213 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2214
2215 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2216 This works around a problem with the previous change to Fcopy_file.
2217 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2218 and without this change, GCC might complain about discarding
2219 fchown's return value.
2220
2221 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
2222
2223 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2224
2225 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2226
2227 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2228
2229 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2230
2231 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2232 it's used from the C level.
2233
2234 * process.c: Use the same condition for POLL_FOR_INPUT in both
2235 keyboard.c and process.c (bug#1858).
2236
2237 2011-07-09 Lawrence Mitchell <wence@gmx.li>
2238
2239 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2240 (Fgnutls_boot): Use it.
2241
2242 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2243
2244 * doc.c (Fsubstitute_command_keys): Revert last change.
2245
2246 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2247
2248 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2249 quotes the next character, and doesn't affect other longer
2250 sequences (bug#8935).
2251
2252 * lread.c (syms_of_lread): Clarify that is isn't only
2253 `eval-buffer' and `eval-defun' that's affected by
2254 `lexical-binding' (bug#8460).
2255
2256 2011-07-15 Eli Zaretskii <eliz@gnu.org>
2257
2258 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
2259 bidi redisplay when a line includes both an image and is truncated.
2260
2261 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2262
2263 Fix minor problems found by static checking.
2264 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2265 (elsz): Now a signed constant, not a size_t var. We prefer signed
2266 types to unsigned, to avoid integer comparison confusion. Without
2267 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2268 "cannot optimize loop, the loop counter may overflow", a symptom
2269 of the confusion.
2270 * indent.c (Fvertical_motion): Mark locals as initialized.
2271 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2272
2273 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2274
2275 * search.c (Fre_search_backward): Mention `case-fold-search' in
2276 all the re_search_* functions (bug#8138).
2277
2278 * keyboard.c (Fopen_dribble_file): Document when the file is
2279 closed (bug#8056).
2280
2281 2011-07-14 Eli Zaretskii <eliz@gnu.org>
2282
2283 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2284 bidi_cache_idx.
2285
2286 Support bidi reordering of display and overlay strings.
2287 * xdisp.c (compute_display_string_pos)
2288 (compute_display_string_end): Accept additional argument STRING.
2289 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2290 (reseat_to_string): Initialize bidi_it->string.s and
2291 bidi_it->string.schars.
2292 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
2293 NULL (avoids a crash in bidi_paragraph_init).
2294 Initialize itb.string.lstring.
2295 (init_iterator): Call bidi_init_it only of a valid
2296 buffer position was specified. Initialize paragraph_embedding to
2297 L2R.
2298 (reseat_to_string): Initialize the bidi iterator.
2299 (display_string): If we need to ignore text properties of
2300 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2301 original value of -1 will not work with bidi.)
2302 (compute_display_string_pos): First arg is now struct
2303 `text_pos *'; all callers changed. Support display properties on
2304 Lisp strings.
2305 (compute_display_string_end): Support display properties on Lisp
2306 strings.
2307 (init_iterator, reseat_1, reseat_to_string): Initialize the
2308 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2309 when iterating on a string not from display properties).
2310 (compute_display_string_pos, compute_display_string_end):
2311 Fix calculation of the object to scan. Fixes an error when using
2312 arrow keys.
2313 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
2314 base_level_stop; instead, set base_level_stop to BEGV.
2315 Fixes crashes in vertical-motion.
2316 (next_element_from_buffer): Improve commentary for when
2317 the iterator is before prev_stop.
2318 (init_iterator): Initialize bidi_p from the default value of
2319 bidi-display-reordering, not from buffer-local value. Use the
2320 buffer-local value only if initializing for buffer iteration.
2321 (handle_invisible_prop): Support invisible properties on strings
2322 that are being bidi-reordered.
2323 (set_iterator_to_next): Support bidi reordering of C strings and
2324 Lisp strings.
2325 (next_element_from_string): Support bidi reordering of Lisp
2326 strings.
2327 (handle_stop_backwards): Support Lisp strings as well.
2328 (display_string): Support display of R2L glyph rows.
2329 Use IT_STRING_CHARPOS when displaying from a Lisp string.
2330 (init_iterator): Don't initialize it->bidi_p for strings
2331 here.
2332 (reseat_to_string): Initialize it->bidi_p for strings here.
2333 (next_element_from_string, next_element_from_c_string)
2334 (next_element_from_buffer): Add xassert's for correspondence
2335 between IT's object being iterated and it->bidi_it.string
2336 structure.
2337 (face_before_or_after_it_pos): Support bidi iteration.
2338 (next_element_from_c_string): Handle the case of the first string
2339 character that is not the first one in the visual order.
2340 (get_visually_first_element): New function, refactored from common
2341 parts of next_element_from_buffer, next_element_from_string, and
2342 next_element_from_c_string.
2343 (tool_bar_lines_needed, redisplay_tool_bar)
2344 (display_menu_bar): Force left-to-right direction. Add a FIXME
2345 comment for making that be controlled by a user option.
2346 (push_it, pop_it): Save and restore the state of the
2347 bidi iterator. Save and restore the bidi_p flag.
2348 (pop_it): Iterate out of display property for string iteration as
2349 well.
2350 (iterate_out_of_display_property): Support iteration over strings.
2351 (handle_single_display_spec): Set up it->bidi_it for iteration
2352 over a display string, and call bidi_init_it.
2353 (handle_single_display_spec, next_overlay_string)
2354 (get_overlay_strings_1, push_display_prop): Set up the bidi
2355 iterator for displaying display or overlay strings.
2356 (forward_to_next_line_start): Don't use the shortcut if
2357 bidi-iterating.
2358 (back_to_previous_visible_line_start): If handle_display_prop
2359 pushed the iterator stack, restore the internal state of the bidi
2360 iterator by calling bidi_pop_it same number of times.
2361 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2362 and we are bidi-iterating, don't decrement the iterator position;
2363 instead, set the first_elt flag in the bidi iterator, to produce
2364 the same effect.
2365 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2366 (push_display_prop): xassert that we are iterating a buffer.
2367 (push_it, pop_it): Save and restore paragraph_embedding member.
2368 (handle_single_display_spec, next_overlay_string)
2369 (get_overlay_strings_1, reseat_1, reseat_to_string)
2370 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2371 correctly. Don't assume unibyte strings are not bidi-reordered.
2372 (compute_display_string_pos)
2373 (compute_display_string_end): Fix handling the case of C string.
2374 (push_it, pop_it): Save and restore from_disp_prop_p.
2375 (handle_single_display_spec, push_display_prop): Set the
2376 from_disp_prop_p flag.
2377 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2378 (pop_it): Call iterate_out_of_display_property only if we are
2379 popping after iteration over a string that came from a display
2380 property. Fix a typo in popping stretch info. Add an assertion
2381 for verifying that the iterator position is in sync with the bidi
2382 iterator.
2383 (handle_single_display_spec, get_overlay_strings_1)
2384 (push_display_prop): Fix initialization of paragraph direction for
2385 string when that of the parent object is not yet determined.
2386 (reseat_1): Call bidi_init_it to resync the bidi
2387 iterator with IT's position. (Bug#7616)
2388 (find_row_edges): If ROW->start.pos gives position
2389 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2390 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2391 Reset the from_disp_prop_p flag.
2392 (SAVE_IT, RESTORE_IT): New macros.
2393 (pos_visible_p, face_before_or_after_it_pos)
2394 (back_to_previous_visible_line_start)
2395 (move_it_in_display_line_to, move_it_in_display_line)
2396 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2397 (try_scrolling, redisplay_window, display_line): Use them when
2398 saving a temporary copy of the iterator and restoring it back.
2399 (back_to_previous_visible_line_start, reseat_1)
2400 (init_iterator): Empty the bidi cache "stack".
2401 (move_it_in_display_line_to): If iterator ended up at
2402 EOL, but we never saw any buffer positions smaller than
2403 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2404 motion in bidi-reordered lines.
2405 (move_it_in_display_line_to): Record prev_method and prev_pos
2406 immediately before the call to set_iterator_to_next. Fixes cursor
2407 motion in bidi-reordered lines with stretch glyphs and strings
2408 displayed in margins. (Bug#8133) (Bug#8867)
2409 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2410 TO_CHARPOS.
2411 (pos_visible_p): Support positions in bidi-reordered lines.
2412 Save and restore bidi cache.
2413
2414 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
2415 (bidi_paragraph_info): Delete unused struct.
2416 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
2417 (bidi_cache_start): New variable.
2418 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
2419 to zero.
2420 (bidi_cache_fetch_state, bidi_cache_search)
2421 (bidi_cache_find_level_change, bidi_cache_iterator_state)
2422 (bidi_cache_find, bidi_peek_at_next_level)
2423 (bidi_level_of_next_char, bidi_find_other_level_edge)
2424 (bidi_move_to_visually_next): Compare cache index with
2425 bidi_cache_start rather than with zero.
2426 (bidi_fetch_char): Accept new argument STRING; all callers
2427 changed. Support iteration over a string. Support strings with
2428 display properties. Support unibyte strings. Fix the type of
2429 `len' according to what STRING_CHAR_AND_LENGTH expects.
2430 (bidi_paragraph_init, bidi_resolve_explicit_1)
2431 (bidi_resolve_explicit, bidi_resolve_weak)
2432 (bidi_level_of_next_char, bidi_move_to_visually_next):
2433 Support iteration over a string.
2434 (bidi_set_sor_type, bidi_resolve_explicit_1)
2435 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
2436 can now be zero (for strings); special values 0 and -1 were
2437 changed to -1 and -2, respectively.
2438 (bidi_char_at_pos): New function.
2439 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
2440 Call it instead of FETCH_MULTIBYTE_CHAR.
2441 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
2442 initialized to valid values.
2443 (bidi_init_it): Don't initialize charpos and bytepos with invalid
2444 values.
2445 (bidi_level_of_next_char): Allow the sentinel "position" to pass
2446 the test for valid cached positions. Fix the logic for looking up
2447 the sentinel state in the cache. GCPRO the Lisp string we are
2448 iterating.
2449 (bidi_push_it, bidi_pop_it): New functions.
2450 (bidi_initialize): Initialize the bidi cache start stack pointer.
2451 (bidi_cache_ensure_space): New function, refactored from part of
2452 bidi_cache_iterator_state. Don't assume the required size is just
2453 one BIDI_CACHE_CHUNK away.
2454 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
2455 (bidi_count_bytes, bidi_char_at_pos): New functions.
2456 (bidi_cache_search): Don't assume bidi_cache_last_idx is
2457 always valid if bidi_cache_idx is valid.
2458 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
2459 is valid if it's going to be used.
2460 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
2461 (bidi_cache_fetch_state, bidi_cache_search)
2462 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2463 (bidi_cache_iterator_state, bidi_cache_find)
2464 (bidi_find_other_level_edge, bidi_cache_start_stack):
2465 All variables related to cache indices are now EMACS_INT.
2466
2467 * dispextern.h (struct bidi_string_data): New structure.
2468 (struct bidi_it): New member `string'. Make flag members be 1-bit
2469 fields, and put them last in the struct.
2470 (compute_display_string_pos, compute_display_string_end):
2471 Update prototypes.
2472 (bidi_push_it, bidi_pop_it): Add prototypes.
2473 (struct iterator_stack_entry): New members bidi_p,
2474 paragraph_embedding, and from_disp_prop_p.
2475 (struct it): Member bidi_p is now a bit field 1 bit wide.
2476 (bidi_shelve_cache, bidi_unshelve_cache):
2477 Declare prototypes.
2478
2479 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
2480 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
2481 and vector-like objects.
2482
2483 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
2484 cache around display iteration.
2485
2486 * window.c (Fwindow_end, window_scroll_pixel_based)
2487 (displayed_window_lines, Frecenter): Save and restore the bidi
2488 cache around display iteration.
2489
2490 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2491
2492 * editfns.c (Fdelete_region): Clarify the use of the named
2493 parameters (bug#6788).
2494
2495 2011-07-14 Martin Rudalics <rudalics@gmx.at>
2496
2497 * indent.c (Fvertical_motion): Set and restore w->pointm when
2498 saving and restoring the window's buffer (Bug#9006).
2499
2500 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
2501
2502 * editfns.c (Fstring_to_char): Clarify just what is returned
2503 (bug#6576). Text by Eli Zaretskii.
2504
2505 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
2506
2507 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
2508
2509 2011-07-13 Eli Zaretskii <eliz@gnu.org>
2510
2511 * buffer.c (mmap_find): Fix a typo.
2512
2513 2011-07-13 Johan Bockgård <bojohan@gnu.org>
2514
2515 Fix execution of x selection hooks.
2516 * xselect.c (Qx_lost_selection_functions)
2517 (Qx_sent_selection_functions): New vars.
2518 (syms_of_xselect): DEFSYM them.
2519 (x_handle_selection_request): Pass Qx_sent_selection_functions
2520 rather than Vx_sent_selection_functions to Frun_hook_with_args.
2521 (x_handle_selection_clear,x_clear_frame_selections):
2522 Pass Qx_lost_selection_functions rather than
2523 Vx_lost_selection_functions to Frun_hook_with_args.
2524
2525 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
2526
2527 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2528 The old code sometimes used this field without initializing it.
2529
2530 * alloc.c (gc_sweep): Don't read past end of array.
2531 In theory, the old code could also have corrupted Emacs internals,
2532 though it'd be very unlikely.
2533
2534 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2535
2536 * character.c (Fcharacterp): Don't advertise optional ignored
2537 argument. (Bug#4026)
2538
2539 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2540
2541 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2542 key" (bug#4257).
2543
2544 * window.c (Fset_window_start): Doc fix (bug#4199).
2545 (Fset_window_hscroll): Ditto.
2546
2547 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2548
2549 Fix minor new problems caught by GCC 4.6.1.
2550 * term.c (init_tty): Remove unused local.
2551 * xsettings.c (store_monospaced_changed): Define this function only
2552 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
2553 not used otherwise.
2554
2555 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
2556
2557 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2558
2559 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2560
2561 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2562 are the mini-buffer and the echo area (bug#3320).
2563
2564 * term.c (init_tty): Remove support for supdup, c10 and perq
2565 terminals, which are no longer supported (bug#1482).
2566
2567 2011-07-10 Johan Bockgård <bojohan@gnu.org>
2568
2569 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2570
2571 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2572
2573 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2574 for non-popups (Bug#3642).
2575
2576 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2577
2578 * alloc.c (reset_malloc_hooks): Protoize.
2579 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
2580 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2581 * cm.c (losecursor): Likewise.
2582 * data.c (fmod): Likewise.
2583 * dispnew.c (swap_glyphs_in_rows): Likewise.
2584 * emacs.c (memory_warning_signal): Likewise.
2585 * floatfns.c (float_error): Likewise.
2586 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2587 (otf_open, font_otf_capability, generate_otf_features)
2588 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2589 Likewise.
2590 * image.c (pbm_read_file): Likewise.
2591 * indent.c (string_display_width): Likewise.
2592 * intervals.c (check_for_interval, search_for_interval)
2593 (inc_interval_count, count_intervals, root_interval)
2594 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2595 * lread.c (defalias): Likewise.
2596 * ralloc.c (r_alloc_check): Likewise.
2597 * regex.c (set_image_of_range_1, set_image_of_range)
2598 (regex_grow_registers): Likewise.
2599 * sysdep.c (strerror): Likewise.
2600 * termcap.c (valid_filename_p, tprint, main): Likewise.
2601 * tparam.c (main): Likewise.
2602 * unexhp9k800.c (run_time_remap, save_data_space)
2603 (update_file_ptrs, read_header, write_header, calculate_checksum)
2604 (copy_file, copy_rest, display_header): Likewise.
2605 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2606 Likewise.
2607 * xdisp.c (check_it): Likewise.
2608 * xfaces.c (register_color, unregister_color, unregister_colors):
2609 Likewise.
2610 * xfns.c (print_fontset_result): Likewise.
2611 * xrdb.c (member, fatal, main): Likewise.
2612
2613 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2614
2615 Fix minor problems found by static checking (Bug#9031).
2616 * chartab.c (char_table_set_range, map_sub_char_table):
2617 Remove unused locals.
2618 (uniprop_table): Now static.
2619 * composite.c (_work_char): Remove unused static var.
2620
2621 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
2622
2623 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2624
2625 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2626
2627 * gtkutil.c (qttip_cb): Remove code without function.
2628
2629 2011-07-09 Eli Zaretskii <eliz@gnu.org>
2630
2631 * w32.c (pthread_sigmask): New stub.
2632
2633 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
2634
2635 Use pthread_sigmask, not sigprocmask (Bug#9010).
2636 sigprocmask is portable only for single-threaded applications, and
2637 Emacs can be multi-threaded when it uses GTK.
2638 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2639 (LIBES): Use it.
2640 * callproc.c (Fcall_process):
2641 * process.c (create_process):
2642 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2643 Use pthread_sigmask, not sigprocmask.
2644
2645 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2646
2647 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2648 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2649 wrong (Bug#8591).
2650
2651 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2652
2653 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2654 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2655 (xg_hide_tooltip): Fix comment.
2656
2657 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2658 in registerServicesMenuSendTypes.
2659 (validRequestorForSendType): Don't check ns_return_types.
2660
2661 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2662 ns_return_type.
2663
2664 2011-07-08 Jason Rumney <jasonr@gnu.org>
2665
2666 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2667 frame struct members of non-existent frames (Bug#6284).
2668
2669 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2670
2671 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2672 variable firstTime not needed on OSX >= 10.6.
2673 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2674 >= 10.5. Use setKnobProportion, setDoubleValue.
2675
2676 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2677 (MAC_OS_X_VERSION_10_5): Define if not defined.
2678 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2679 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2680 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2681
2682 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2683 cString and lossyCString on OSX >= 10.4
2684
2685 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2686 sizeToFit on OSX >= 10.2.
2687
2688 * nsimage.m (allocInitFromFile): Don't use deprecated method
2689 bestRepresentationForDevice on OSX >= 10.6.
2690
2691 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2692 to avoid warning.
2693
2694 * emacs.c: Declare unexec_init_emacs_zone.
2695
2696 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2697
2698 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2699
2700 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2701 on svcsMenu (Bug#8842).
2702
2703 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2704 ns_return_types.
2705 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2706
2707 * nsterm.m (QUTF8_STRING): Declare.
2708 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2709 (validRequestorForSendType): Return type is (id).
2710 Change indexOfObjectIdenticalTo to indexOfObject.
2711 Check if we have local selection before returning self (Bug#8842).
2712 (writeSelectionToPasteboard): Put local selection into paste board
2713 if we have a local selection (Bug#8842).
2714 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2715
2716 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2717 (ns_get_local_selection): Declare.
2718
2719 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2720
2721 * keymap.c (describe_map_tree): Don't insert a double newline at
2722 the end of the buffer (bug#1169) and return whether we inserted
2723 something.
2724
2725 * callint.c (Fcall_interactively): Change "reading args" to
2726 "providing args" to try to clarify what it does (bug#1010).
2727
2728 2011-07-07 Kenichi Handa <handa@m17n.org>
2729
2730 * composite.c (composition_compute_stop_pos): Ignore a static
2731 composition starting before CHARPOS (Bug#8915).
2732
2733 * xdisp.c (handle_composition_prop): Likewise.
2734
2735 2011-07-07 Eli Zaretskii <eliz@gnu.org>
2736
2737 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2738 (Bug#9015)
2739
2740 2011-07-07 Kenichi Handa <handa@m17n.org>
2741
2742 * character.h (unicode_category_t): New enum type.
2743
2744 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2745 (Qchar_code_property_table): New variable.
2746 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2747 (UNIPROP_COMPRESSED_FORM_P): New macros.
2748 (char_table_ascii): Uncompress the compressed values.
2749 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2750 Uncompress the compressed values.
2751 (sub_char_table_ref_and_range): Likewise.
2752 (char_table_ref_and_range): Uncompress the compressed values.
2753 (sub_char_table_set): New arg is_uniprop. Callers changed.
2754 Uncompress the compressed values.
2755 (sub_char_table_set_range): Args changed. Callers changed.
2756 (char_table_set_range): Adjuted for the above change.
2757 (map_sub_char_table): Delete args default_val and parent. Add arg
2758 top. Give decoded values to a Lisp function.
2759 (map_char_table): Adjust for the above change. Give decoded
2760 values to a Lisp function. Gcpro more variables.
2761 (uniprop_table_uncompress)
2762 (uniprop_decode_value_run_length): New functions.
2763 (uniprop_decoder, uniprop_decoder_count): New variables.
2764 (uniprop_get_decoder, uniprop_encode_value_character)
2765 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2766 New functions.
2767 (uniprop_encoder, uniprop_encoder_count): New variables.
2768 (uniprop_get_encoder, uniprop_table)
2769 (Funicode_property_table_internal, Fget_unicode_property_internal)
2770 (Fput_unicode_property_internal): New functions.
2771 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2772 Sunicode_property_table_internal, Sget_unicode_property_internal,
2773 and Sput_unicode_property_internal. Defvar_lisp
2774 char-code-property-alist.
2775
2776 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
2777 Vunicode_category_table.
2778
2779 * font.c (font_range): Adjust for the change of
2780 Vunicode_category_table.
2781
2782 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2783
2784 * m/iris4d.h: Remove file, move contents ...
2785 * s/irix6-5.h: ... here.
2786
2787 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2788
2789 Remove unportable assumption about struct layout (Bug#8884).
2790 * alloc.c (mark_buffer):
2791 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2792 (clone_per_buffer_values): Don't assume that
2793 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2794 This isn't true in general, and it's particularly not true
2795 if Emacs is configured with --with-wide-int.
2796 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2797 New macros, used in the buffer.c change.
2798
2799 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2800
2801 * xsettings.c: Use both GConf and GSettings if both are available.
2802 (store_config_changed_event): Add comment.
2803 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2804 (store_tool_bar_style_changed): New functions.
2805 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
2806 (struct xsettings): Move font inside HAVE_XFT.
2807 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
2808 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
2809 Move inside HAVE_XFT.
2810 (something_changed_gsettingsCB): Rename from something_changedCB.
2811 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2812 also.
2813 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
2814 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
2815 (something_changed_gconfCB): Rename from something_changedCB.
2816 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2817 (parse_settings): Move check for font inside HAVE_XFT.
2818 (read_settings, apply_xft_settings): Add comment.
2819 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2820 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2821 call store_font_name_changed.
2822 (xft_settings_event): Add comment.
2823 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2824 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2825 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2826 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2827 (xsettings_initialize): Call init_gsettings last.
2828 (xsettings_get_system_font, xsettings_get_system_normal_font):
2829 Add comment.
2830
2831 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2832
2833 Random fixes. E.g., (random) never returned negative values.
2834 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2835 subseconds part to the entropy, as that's a bit more random.
2836 Prefer signed to unsigned, since the signedness doesn't matter and
2837 in general we prefer signed. When given a limit, use a
2838 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2839 latter isn't right if USE_2_TAGS_FOR_INTS.
2840 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2841 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2842
2843 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2844
2845 * textprop.c (text_property_stickiness):
2846 Obey Vtext_property_default_nonsticky.
2847 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2848 * w32fns.c (syms_of_w32fns):
2849 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2850
2851 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2852
2853 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2854 This is more efficient than Ffile_directory_p and avoids a minor race.
2855
2856 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2857
2858 * buffer.c (Foverlay_put): Say what the return value is
2859 (bug#7835).
2860
2861 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2862 is a directory before asking whether to use the file name
2863 (bug#7564).
2864 (barf_or_query_if_file_exists): Make the "File is a directory"
2865 error be more correct.
2866
2867 * fns.c (Frequire): Remove the mention of the .gz files, since
2868 that's installation-specific, but keep the mention of
2869 `get-load-suffixes'.
2870
2871 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2872
2873 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2874 Report string overflow if the output is too long.
2875
2876 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
2877
2878 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2879 (syms_of_gnutls): Remove duplicate DEFSYM for
2880 Qgnutls_bootprop_verify_hostname_error, an error for
2881 Qgnutls_bootprop_verify_error (which is no longer used).
2882
2883 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2884 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2885 Also (re)move comments that are misplaced or no longer relevant.
2886
2887 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2888
2889 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2890
2891 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
2892
2893 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2894 and background color parameters if they have been changed.
2895
2896 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2897
2898 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2899
2900 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2901
2902 * xsettings.c (SYSTEM_FONT): Define only when used.
2903 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2904
2905 * keymap.c (access_keymap_1): Now static.
2906
2907 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
2908
2909 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2910 leave any prefix arg for the up event (Bug#1586).
2911
2912 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2913
2914 * lread.c (syms_of_lread): Mention single symbols defined by
2915 `defvar' or `defconst' (bug#7154).
2916
2917 * fns.c (Frequire): Mention .el.gz files (bug#7314).
2918 (Frequire): Mention get-load-suffixes.
2919
2920 2011-07-02 Martin Rudalics <rudalics@gmx.at>
2921
2922 * window.h (window): Remove clone_number slot.
2923 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2924 Remove.
2925 (make_parent_window, make_window, saved_window)
2926 (Fset_window_configuration, save_window_save): Don't deal with
2927 clone numbers.
2928 * buffer.c (Qclone_number): Remove declaration.
2929 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2930
2931 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2932
2933 Add multiple inheritance to keymaps.
2934 * keymap.c (Fmake_composed_keymap): New function.
2935 (Fset_keymap_parent): Simplify.
2936 (fix_submap_inheritance): Remove.
2937 (access_keymap_1): New function extracted from access_keymap to handle
2938 embedded parents and handle lists of maps.
2939 (access_keymap): Use it.
2940 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2941 (Fcopy_keymap): Handle embedded parents.
2942 (Fcommand_remapping, define_as_prefix): Simplify.
2943 (Fkey_binding): Simplify.
2944 (syms_of_keymap): Move minibuffer-local-completion-map,
2945 minibuffer-local-filename-completion-map,
2946 minibuffer-local-must-match-map, and
2947 minibuffer-local-filename-must-match-map to Elisp.
2948 (syms_of_keymap): Defsubr make-composed-keymap.
2949 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2950 (parse_menu_item): Trivial simplification.
2951
2952 2011-07-01 Glenn Morris <rgm@gnu.org>
2953
2954 * Makefile.in (SETTINGS_LIBS): Fix typo.
2955
2956 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2957
2958 * coding.c (Fencode_coding_string): Record the last coding system
2959 used, as the function doc string says (bug#8738).
2960
2961 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2962
2963 * xsettings.c (store_monospaced_changed): Take new font as arg and
2964 check for change against current_mono_font.
2965 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2966 (emacs_settings_constructor, emacs_settings_get_property)
2967 (emacs_settings_set_property, emacs_settings_class_init)
2968 (emacs_settings_init, gsettings_obj): Remove.
2969 (something_changedCB): New function for HAVE_GSETTINGS.
2970 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2971 with value as argument.
2972 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2973 g_settings_new (Bug#8967). Do not create gsettings_obj.
2974 Remove calls to g_settings_bind. Connect something_changedCB to
2975 "changed".
2976
2977 * xgselect.c: Add defined (HAVE_GSETTINGS).
2978 (xgselect_initialize): Ditto.
2979
2980 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2981 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2982 xg_select.
2983
2984 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2985
2986 * eval.c (struct backtrace): Simplify and port the data structure.
2987 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2988 signed bit field, as this assumption is not portable and it makes
2989 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2990 "char debug_on_exit : 1" as this is not portable either; instead,
2991 use the portable "unsigned int debug_on_exit : 1". Remove unused
2992 member evalargs. Remove obsolete comments about cc bombing out.
2993
2994 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2995
2996 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
2997 Let HAVE_GSETTINGS override HAVE_GCONF.
2998 (store_monospaced_changed): New function.
2999 (EMACS_SETTINGS): A new type derived from GObject to handle
3000 GSettings notifications.
3001 (emacs_settings_constructor, emacs_settings_get_property)
3002 (emacs_settings_set_property, emacs_settings_class_init):
3003 New functions.
3004 (gsettings_client, gsettings_obj): New variables.
3005 (GSETTINGS_SCHEMA): New define.
3006 (something_changedCB): Call store_monospaced_changed.
3007 (init_gsettings): New function.
3008 (xsettings_initialize): Call init_gsettings.
3009 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3010 to NULL.
3011
3012 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
3013 GCONF_CFLAGS/LIBS.
3014
3015 2011-06-29 Martin Rudalics <rudalics@gmx.at>
3016
3017 * window.c (resize_root_window, grow_mini_window)
3018 (shrink_mini_window): Rename Qresize_root_window to
3019 Qwindow_resize_root_window and Qresize_root_window_vertically to
3020 Qwindow_resize_root_window_vertically.
3021
3022 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3023
3024 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3025
3026 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
3027
3028 * makefile.w32-in: Redesign dependencies so they reflect more
3029 clearly which files are directly included by each source file,
3030 and not through other includes.
3031
3032 2011-06-27 Martin Rudalics <rudalics@gmx.at>
3033
3034 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3035 (sort_overlays, overlay_strings): When an overlay's clone number
3036 matches the window's clone number process the overlay even if
3037 the overlay's window property doesn't match the current window.
3038
3039 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3040 (Fwindow_hchild): Rename to Fwindow_left_child.
3041 (Fwindow_next): Rename to Fwindow_next_sibling.
3042 (Fwindow_prev): Rename to Fwindow_prev_sibling.
3043 (resize_window_check): Rename to window_resize_check.
3044 (resize_window_apply): Rename to window_resize_apply.
3045 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3046 (Fdelete_other_windows_internal, resize_frame_windows)
3047 (Fsplit_window_internal, Fdelete_window_internal)
3048 (grow_mini_window, shrink_mini_window)
3049 (Fresize_mini_window_internal): Fix callers accordingly.
3050
3051 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3052
3053 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3054 (emacs_fixed_set_min_size): Remove.
3055 (emacs_fixed_new): Take frame as argument.
3056
3057 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3058 (_EmacsFixedPrivate): Remove minwidth/height.
3059 Add struct frame *f.
3060 (emacs_fixed_init): Initialize priv->f.
3061 (get_parent_class, emacs_fixed_set_min_size): Remove.
3062 (emacs_fixed_new): Set priv->f to argument.
3063 (emacs_fixed_get_preferred_width)
3064 (emacs_fixed_get_preferred_height): Use min_width/height from
3065 frames size_hint to set minimum and natural (Bug#8919).
3066 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3067 and use min_width/height from frames size_hint to set
3068 min_width/height (Bug#8919).
3069
3070 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
3071 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3072 Fix indentation.
3073
3074 2011-06-26 Eli Zaretskii <eliz@gnu.org>
3075
3076 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3077 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3078 called at ZV.
3079
3080 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
3081
3082 * process.c (wait_reading_process_output): Bypass select if
3083 waiting for a cell while ignoring keyboard input, and input is
3084 pending. Suggested by Jan Djärv (Bug#8869).
3085
3086 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3087
3088 Use gnulib's dup2 module instead of rolling our own.
3089 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3090
3091 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3092
3093 * dispnew.c (scrolling_window): Before scrolling, turn off a
3094 mouse-highlight in the window being scrolled.
3095
3096 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
3097
3098 Move DEFSYM to lisp.h and use everywhere.
3099
3100 * character.h (DEFSYM): Move declaration...
3101 * lisp.h (DEFSYM): ...here.
3102
3103 * gnutls.c:
3104 * minibuf.c:
3105 * w32menu.c:
3106 * w32proc.c:
3107 * w32select.c: Don't include character.h.
3108
3109 * alloc.c (syms_of_alloc):
3110 * buffer.c (syms_of_buffer):
3111 * bytecode.c (syms_of_bytecode):
3112 * callint.c (syms_of_callint):
3113 * casefiddle.c (syms_of_casefiddle):
3114 * casetab.c (init_casetab_once):
3115 * category.c (init_category_once, syms_of_category):
3116 * ccl.c (syms_of_ccl):
3117 * cmds.c (syms_of_cmds):
3118 * composite.c (syms_of_composite):
3119 * dbusbind.c (syms_of_dbusbind):
3120 * dired.c (syms_of_dired):
3121 * dispnew.c (syms_of_display):
3122 * doc.c (syms_of_doc):
3123 * editfns.c (syms_of_editfns):
3124 * emacs.c (syms_of_emacs):
3125 * eval.c (syms_of_eval):
3126 * fileio.c (syms_of_fileio):
3127 * fns.c (syms_of_fns):
3128 * frame.c (syms_of_frame):
3129 * fringe.c (syms_of_fringe):
3130 * insdel.c (syms_of_insdel):
3131 * keymap.c (syms_of_keymap):
3132 * lread.c (init_obarray, syms_of_lread):
3133 * macros.c (syms_of_macros):
3134 * msdos.c (syms_of_msdos):
3135 * print.c (syms_of_print):
3136 * process.c (syms_of_process):
3137 * search.c (syms_of_search):
3138 * sound.c (syms_of_sound):
3139 * syntax.c (init_syntax_once, syms_of_syntax):
3140 * terminal.c (syms_of_terminal):
3141 * textprop.c (syms_of_textprop):
3142 * undo.c (syms_of_undo):
3143 * w32.c (globals_of_w32):
3144 * window.c (syms_of_window):
3145 * xdisp.c (syms_of_xdisp):
3146 * xfaces.c (syms_of_xfaces):
3147 * xfns.c (syms_of_xfns):
3148 * xmenu.c (syms_of_xmenu):
3149 * xsettings.c (syms_of_xsettings):
3150 * xterm.c (syms_of_xterm): Use DEFSYM.
3151
3152 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3153
3154 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
3155
3156 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3157
3158 Integer and buffer overflow fixes (Bug#8873).
3159
3160 * print.c (printchar, strout): Check for string overflow.
3161 (PRINTPREPARE, printchar, strout):
3162 Don't set size unless allocation succeeds.
3163
3164 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3165 for sizes. Check for string overflow more accurately.
3166 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3167
3168 * macros.c: Integer and buffer overflow fixes.
3169 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3170 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3171 Use ptrdiff_t, not int, for sizes.
3172 Don't increment bufsize until after realloc succeeds.
3173 Check for size-calculation overflow.
3174 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3175
3176 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3177
3178 * lread.c: Integer overflow fixes.
3179 (read_integer): Radix is now EMACS_INT, not int,
3180 to improve quality of diagnostics for out-of-range radices.
3181 Calculate buffer size correctly for out-of-range radices.
3182 (read1): Check for integer overflow in radices, and in
3183 read-circle numbers.
3184 (read_escape): Avoid int overflow.
3185 (Fload, openp, read_buffer_size, read1)
3186 (substitute_object_recurse, read_vector, read_list, map_obarray):
3187 Use ptrdiff_t, not int, for sizes.
3188 (read1): Use EMACS_INT, not int, for sizes.
3189 Check for size overflow.
3190
3191 * image.c (cache_image): Check for size arithmetic overflow.
3192
3193 * lread.c: Integer overflow issues.
3194 (saved_doc_string_size, saved_doc_string_length)
3195 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3196 Now ptrdiff_t, not int.
3197 (read1): Don't assume doc string length fits in int. Check for
3198 out-of-range doc string lengths.
3199 (read_list): Don't assume file position fits in int.
3200 (read_escape): Check for hex character overflow.
3201
3202 2011-06-22 Leo Liu <sdl.web@gmail.com>
3203
3204 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3205 Move to minibuffer.el.
3206
3207 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3208
3209 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
3210 The following patches are for when GLYPH_DEBUG && !XASSERT.
3211 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3212 * dispnew.c (flush_stdout):
3213 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3214 Mark as externally visible.
3215 * dispnew.c (check_window_matrix_pointers): Now static.
3216 * dispnew.c (window_to_frame_vpos):
3217 * xfns.c (unwind_create_frame):
3218 * xterm.c (x_check_font): Remove unused local.
3219 * scroll.c (CHECK_BOUNDS):
3220 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3221 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3222 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3223 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3224 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3225 Now static.
3226 (debug_method_add): Use va_list and vsprintf rather than relying
3227 on undefined behavior with wrong number of arguments.
3228 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3229 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3230 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3231 since we're not interested in debugging glyphs with old libraries.
3232 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3233 GCC 4.6.0's static checking.
3234
3235 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3236
3237 Integer overflow and signedness fixes (Bug#8873).
3238 A few related buffer overrun fixes, too.
3239
3240 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3241
3242 * dispextern.h (struct face.stipple):
3243 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3244 (x_bitmap_mask, x_allocate_bitmap_record)
3245 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3246 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3247 (x_create_bitmap_from_xpm_data):
3248 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3249 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3250 (.bitmaps_last):
3251 * xfaces.c (load_pixmap):
3252 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3253 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3254 (.bitmaps_last, struct x_output.icon_bitmap):
3255 Use ptrdiff_t, not int, for bitmap indexes.
3256 (x_allocate_bitmap_record): Check for size overflow.
3257 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3258
3259 Use ptrdiff_t, not int, for overlay counts.
3260 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3261 * editfns.c (overlays_around, get_pos_property):
3262 * textprop.c (get_char_property_and_overlay):
3263 * xdisp.c (next_overlay_change, note_mouse_highlight):
3264 * xfaces.c (face_at_buffer_position):
3265 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3266 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3267 (Fnext_overlay_change, Fprevious_overlay_change)
3268 (mouse_face_overlay_overlaps, Foverlays_in):
3269 Use ptrdiff_t, not int, for sizes.
3270 (overlays_at, overlays_in): Check for size-calculation overflow.
3271
3272 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3273
3274 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3275 (x_session_initialize): Do not assume string length fits in int.
3276
3277 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3278 This is unlikely, but can occur if DPI is outlandish.
3279
3280 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3281 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3282
3283 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3284 * xrdb.c (magic_file_p, search_magic_path):
3285 Omit last arg SUFFIX; it was always 0. All callers changed.
3286 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3287
3288 * xfont.c (xfont_match): Avoid need for strlen.
3289
3290 * xfns.c: Don't assume strlen fits in int.
3291 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3292
3293 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3294 not unsigned long, as we prefer signed integers. All callers changed.
3295 Detect integer overflow in repeat count.
3296 (message_dolog): Don't assume print length fits in 39 bytes.
3297 (display_mode_element): Don't assume strlen fits in int.
3298
3299 * termcap.c: Don't assume sizes fit in int and never overflow.
3300 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3301 (gobble_line): Check for size-calculation overflow.
3302
3303 * minibuf.c (Fread_buffer):
3304 * lread.c (intern, intern_c_string):
3305 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3306 Don't assume string length fits in int.
3307
3308 * keyboard.c (parse_tool_bar_item):
3309 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3310
3311 * font.c: Don't assume string length fits in int.
3312 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3313 Use ptrdiff_t, not int.
3314 (font_intern_prop): Don't assume string length fits in int.
3315 Don't assume integer property fits in fixnum.
3316 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
3317
3318 * filelock.c: Fix some buffer overrun and integer overflow issues.
3319 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
3320 Reformulate so as not to need the command string.
3321 Invoke gzip -cd rather than gunzip, as it's more portable.
3322 (lock_info_type, lock_file_1, lock_file):
3323 Don't assume pid_t and time_t fit in unsigned long.
3324 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3325 (current_lock_owner): Prefer signed type for sizes.
3326 Use memcpy, not strncpy, where memcpy is what is really wanted.
3327 Don't assume (via atoi) that time_t and pid_t fit in int.
3328 Check for time_t and/or pid_t out of range, e.g., via a network share.
3329 Don't alloca where an auto var works fine.
3330
3331 * fileio.c: Fix some integer overflow issues.
3332 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3333 Don't assume string length fits in int.
3334 (directory_file_name): Don't assume string length fits in long.
3335 (make_temp_name): Don't assume pid fits in int, or that its print
3336 length is less than 20.
3337
3338 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3339
3340 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3341
3342 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3343
3344 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3345 We prefer signed integers, even for size calculations.
3346
3347 * emacs.c: Don't assume string length fits in 'int'.
3348 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3349 (main): Don't invoke strlen when not needed.
3350
3351 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3352 (XD_DEBUG_MESSAGE): Don't waste a byte.
3353
3354 * callproc.c (getenv_internal_1, getenv_internal)
3355 (Fgetenv_internal):
3356 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3357
3358 * lread.c (invalid_syntax): Omit length argument.
3359 All uses changed. This doesn't fix a bug, but it simplifies the
3360 code away from its former Hollerith-constant appearance, and it's
3361 one less 'int' to worry about when looking at integer-overflow issues.
3362 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
3363
3364 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3365 This didn't break anything, but it didn't help either.
3366 It's confusing to put a bogus integer in a place where the actual
3367 value does not matter.
3368 (LIST_END_P): Remove unused macro and its bogus comment.
3369 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
3370
3371 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3372 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3373 implementation.
3374 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3375 We prefer signed types, and the value cannot exceed the EMACS_INT
3376 range anyway (because otherwise the length would not be representable).
3377 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3378 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3379 This avoids a GCC warning when WIDE_EMACS_INT.
3380
3381 * indent.c (sane_tab_width): New function.
3382 (current_column, scan_for_column, Findent_to, position_indentation)
3383 (compute_motion): Use it. This is just for clarity.
3384 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
3385
3386 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
3387
3388 * lisp.h (lint_assume): New macro.
3389 * composite.c (composition_gstring_put_cache):
3390 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3391
3392 * editfns.c, insdel.c:
3393 Omit unnecessary forward decls, to simplify future changes.
3394
3395 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3396
3397 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3398
3399 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
3400 Use much-faster test for byte-length change.
3401 Don't assume string byte-length fits in 'int'.
3402 Check that character arg fits in 'int'.
3403 (mapcar1): Declare byte as byte, for clarity.
3404
3405 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3406
3407 * fns.c (concat): Catch string overflow earlier.
3408 Do not rely on integer wraparound.
3409
3410 * dispextern.h (struct it.overlay_strings_charpos)
3411 (struct it.selective): Now EMACS_INT, not int.
3412 * xdisp.c (forward_to_next_line_start)
3413 (back_to_previous_visible_line_start)
3414 (reseat_at_next_visible_line_start, next_element_from_buffer):
3415 Don't arbitrarily truncate the value of 'selective' to int.
3416
3417 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
3418
3419 * composite.c: Don't truncate sizes to 'int'.
3420 (composition_gstring_p, composition_reseat_it)
3421 (composition_adjust_point): Use EMACS_INT, not int.
3422 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
3423 not EMACS_UINT, for indexes.
3424
3425 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
3426
3427 * buffer.c: Include <verify.h>.
3428 (struct sortvec.priority, struct sortstr.priority):
3429 Now EMACS_INT, not int.
3430 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
3431 (struct sortstr.size, record_overlay_string)
3432 (struct sortstrlist.size, struct sortlist.used):
3433 Don't truncate size to int.
3434 (record_overlay_string): Check for size-calculation overflow.
3435 (init_buffer_once): Check at compile-time, not run-time.
3436
3437 2011-06-22 Jim Meyering <meyering@redhat.com>
3438
3439 Don't leak an XBM-image-sized buffer
3440 * image.c (xbm_load): Free the image buffer after using it.
3441
3442 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
3443
3444 Port to Sun C.
3445 * composite.c (find_automatic_composition): Omit needless 'return 0;'
3446 that Sun C diagnosed.
3447 * fns.c (secure_hash): Fix pointer signedness issue.
3448 * intervals.c (static_offset_intervals): New function.
3449 (offset_intervals): Use it.
3450
3451 2011-06-21 Leo Liu <sdl.web@gmail.com>
3452
3453 * deps.mk (fns.o):
3454 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
3455 sha512.h.
3456
3457 * fns.c (secure_hash): Rename from crypto_hash_function and change
3458 the first arg to accept symbols.
3459 (Fsecure_hash): New primitive.
3460 (syms_of_fns): New symbols.
3461
3462 2011-06-20 Deniz Dogan <deniz@dogan.se>
3463
3464 * process.c (Fset_process_buffer): Clarify return value in
3465 docstring.
3466
3467 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
3468
3469 * dispnew.c (add_window_display_history): Use BVAR.
3470
3471 * xdisp.c (debug_method_add): Use BVAR.
3472 (check_window_end, dump_glyph_matrix, dump_glyph)
3473 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
3474
3475 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
3476 Likewise.
3477
3478 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
3479 check till after the cache is created in init_frame_faces.
3480
3481 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
3482
3483 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
3484
3485 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
3486
3487 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
3488 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
3489 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
3490
3491 Improve buffer-overflow checking (Bug#8873).
3492 * fileio.c (Finsert_file_contents):
3493 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
3494 Remove the old (too-loose) buffer overflow checks.
3495 They weren't needed, since make_gap checks for buffer overflow.
3496 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
3497 The old code merely checked for Emacs fixnum overflow, and relied
3498 on undefined (wraparound) behavior. The new code avoids undefined
3499 behavior, and also checks for ptrdiff_t and/or size_t overflow.
3500
3501 * editfns.c (Finsert_char): Don't dump core with very negative counts.
3502 Tune. Don't use wider integers than needed. Don't use alloca.
3503 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
3504
3505 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
3506
3507 * insdel.c, lisp.h (buffer_overflow): New function.
3508 (insert_from_buffer_1, replace_range, replace_range_2):
3509 * insdel.c (make_gap_larger):
3510 * editfns.c (Finsert_char):
3511 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
3512
3513 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
3514
3515 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
3516
3517 Integer overflow and signedness fixes (Bug#8873).
3518
3519 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
3520 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
3521
3522 * fileio.c: Don't assume EMACS_INT fits in off_t.
3523 (emacs_lseek): New static function.
3524 (Finsert_file_contents, Fwrite_region): Use it.
3525 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
3526
3527 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
3528
3529 * fns.c: Don't overflow int when computing a list length.
3530 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
3531 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
3532 truncation on 64-bit hosts. Check for QUIT every
3533 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3534 faster and is responsive enough.
3535 (Flength): Report an error instead of overflowing an integer.
3536 (Fsafe_length): Return a float if the value is not representable
3537 as a fixnum. This shouldn't happen except in contrived situations.
3538 (Fnthcdr, Fsort): Don't assume list length fits in int.
3539 (Fcopy_sequence): Don't assume vector length fits in int.
3540
3541 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3542 (header_size, word_size): New constants.
3543 (allocate_vectorlike): Don't check size overflow here.
3544 (allocate_vector): Check it here instead, since this is the only
3545 caller of allocate_vectorlike that could cause overflow.
3546 Check that the new vector's length is representable as a fixnum.
3547
3548 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3549 The previous code was bogus. For example, next_almost_prime (32)
3550 returned 39, which is undesirable as it is a multiple of 3; and
3551 next_almost_prime (24) returned 25, which is a multiple of 5 so
3552 why was the code bothering to check for multiples of 7?
3553
3554 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3555
3556 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3557
3558 Variadic C functions now count arguments with ptrdiff_t.
3559 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3560 Back then I didn't know that the Emacs coding style prefers signed int.
3561 Also, in the meantime I found a few more instances where arguments
3562 were being counted with int, which may truncate counts on 64-bit
3563 machines, or EMACS_INT, which may be unnecessarily wide.
3564 * lisp.h (struct Lisp_Subr.function.aMANY)
3565 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3566 Arg counts are now ptrdiff_t, not size_t.
3567 All variadic functions and their callers changed accordingly.
3568 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3569 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3570 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3571 * callint.c (Fcall_interactively): Check arg count for overflow,
3572 to avoid potential buffer overrun. Use signed char, not 'int',
3573 for 'varies' array, so that we needn't bother to check its size
3574 calculation for overflow.
3575 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3576 * eval.c (apply_lambda):
3577 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3578 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3579 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3580
3581 * callint.c (Fcall_interactively): Don't use index var as event count.
3582
3583 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3584 * mem-limits.h (SIZE): Remove; no longer used.
3585
3586 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
3587
3588 Remove unnecessary casts.
3589 * xterm.c (x_term_init):
3590 * xfns.c (x_set_border_pixel):
3591 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3592 These aren't needed now that we assume ANSI C.
3593
3594 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3595 It's more likely to cause problems (due to unsigned overflow)
3596 than to cure them.
3597
3598 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3599
3600 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3601
3602 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3603
3604 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3605
3606 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3607
3608 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3609
3610 GLYPH_CODE_FACE returns EMACS_INT, not int.
3611 * dispextern.h (merge_faces):
3612 * xfaces.c (merge_faces):
3613 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3614 Don't assume EMACS_INT fits in int.
3615
3616 * character.h (CHAR_VALID_P): Remove unused parameter.
3617 * fontset.c, lisp.h, xdisp.c: All uses changed.
3618
3619 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3620
3621 * fns.c (concat): Minor tuning based on overflow analysis.
3622 This doesn't fix any bugs. Use int to hold character, instead
3623 of constantly refetching from Emacs object. Use XFASTINT, not
3624 XINT, for value known to be a character. Don't bother comparing
3625 a single byte to 0400, as it's always less.
3626
3627 * floatfns.c (Fexpt):
3628 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3629
3630 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3631 for characters.
3632
3633 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3634
3635 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3636 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3637 incorrectly succeed when S was a string, because 4294967386 was
3638 truncated before it was used.
3639
3640 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3641 Otherwise, an out-of-range integer could cause undefined behavior
3642 on a 64-bit host.
3643
3644 * composite.c: Use int, not EMACS_INT, for characters.
3645 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3646 EMACS_INT, for values that are known to be in character range.
3647 This doesn't fix any bugs but is the usual style inside Emacs and
3648 may generate better code on 32-bit machines.
3649
3650 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3651 This is for reasons similar to the recent CHAR_STRING fix.
3652 * charset.c (Fencode_char): Check that character arg is actually
3653 a character. Pass an int to ENCODE_CHAR.
3654 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3655 wider than 'int', as a compile-time check to prevent future regressions
3656 in this area.
3657
3658 * character.c (char_string): Remove unnecessary casts.
3659
3660 Make sure a 64-bit char is never passed to CHAR_STRING.
3661 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3662 by silently ignoring the top 32 bits, allowing some values
3663 that were far too large to be valid characters.
3664 * character.h: Include <verify.h>.
3665 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3666 arguments are no wider than unsigned, as a compile-time check
3667 to prevent future regressions in this area.
3668 * data.c (Faset):
3669 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
3670 (Fsubst_char_in_region):
3671 * fns.c (concat):
3672 * xdisp.c (decode_mode_spec_coding):
3673 Adjust to CHAR_STRING's new requirement.
3674 * editfns.c (Finsert_char, Fsubst_char_in_region):
3675 * fns.c (concat): Check that character args are actually
3676 characters. Without this test, these functions did the wrong
3677 thing with wildly out-of-range values on 64-bit hosts.
3678
3679 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3680 These casts should not be needed on 32-bit hosts, either.
3681 * keyboard.c (read_char):
3682 * lread.c (Fload): Remove casts to unsigned.
3683
3684 * lisp.h (UNSIGNED_CMP): New macro.
3685 This fixes comparison bugs on 64-bit hosts.
3686 (ASCII_CHAR_P): Use it.
3687 * casefiddle.c (casify_object):
3688 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
3689 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3690 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3691 * dispextern.h (FACE_FROM_ID):
3692 * keyboard.c (read_char): Use UNSIGNED_CMP.
3693
3694 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3695 not to EMACS_INT, to avoid GCC warning.
3696
3697 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3698
3699 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3700 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3701 isn't needed on 32-bit machines.
3702
3703 * buffer.c (Fgenerate_new_buffer_name):
3704 Use EMACS_INT for count, not int.
3705 (advance_to_char_boundary): Return EMACS_INT, not int.
3706
3707 * data.c (Qcompiled_function): Now static.
3708
3709 * window.c (window_body_lines): Now static.
3710
3711 * image.c (gif_load): Rename local to avoid shadowing.
3712
3713 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3714 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3715 * alloc.c (make_save_value): Integer argument is now of type
3716 ptrdiff_t, not int.
3717 (mark_object): Use ptrdiff_t, not int.
3718 * lisp.h (pD): New macro.
3719 * print.c (print_object): Use it.
3720
3721 * alloc.c: Use EMACS_INT, not int, to count objects.
3722 (total_conses, total_markers, total_symbols, total_vector_size)
3723 (total_free_conses, total_free_markers, total_free_symbols)
3724 (total_free_floats, total_floats, total_free_intervals)
3725 (total_intervals, total_strings, total_free_strings):
3726 Now EMACS_INT, not int. All uses changed.
3727 (Fgarbage_collect): Compute overall total using a double, so that
3728 integer overflow is less likely to be a problem. Check for overflow
3729 when converting back to an integer.
3730 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3731 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3732 These were 'int' variables that could overflow on 64-bit hosts;
3733 they were never used, so remove them instead of repairing them.
3734 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
3735 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3736 Previously, this ceilinged at INT_MAX, but that doesn't work on
3737 64-bit machines.
3738 (allocate_pseudovector): Don't use EMACS_INT when int would do.
3739
3740 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
3741 (allocate_vectorlike): Check for ptrdiff_t overflow.
3742 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3743 when a (possibly-narrower) signed value would do just as well.
3744 We prefer using signed arithmetic, to avoid comparison confusion.
3745
3746 * alloc.c: Catch some string size overflows that we were missing.
3747 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3748 for convenience in STRING_BYTES_MAX.
3749 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3750 The definition here is exact; the one in lisp.h was approximate.
3751 (allocate_string_data): Check for string overflow. This catches
3752 some instances we weren't catching before. Also, it catches
3753 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3754 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3755 and ptrdiff_t and EMACS_INT are both 64 bits.
3756
3757 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3758 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
3759 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
3760
3761 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3762
3763 * alloc.c (Fmake_string): Check for out-of-range init.
3764
3765 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3766
3767 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3768
3769 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3770
3771 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3772 xg_get_default_scrollbar_width.
3773
3774 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3775 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3776 (style_changed_cb): Call update_theme_scrollbar_width and call
3777 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3778 all frames (Bug#8505).
3779 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3780 Call gtk_window_set_resizable if HAVE_GTK3.
3781 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3782 and height if HAVE_GTK3 (Bug#8505).
3783 (scroll_bar_width_for_theme): New variable.
3784 (update_theme_scrollbar_width): New function.
3785 (xg_get_default_scrollbar_width): Move code to
3786 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3787 (xg_initialize): Call update_theme_scrollbar_width.
3788
3789 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3790
3791 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3792
3793 2011-06-12 Martin Rudalics <rudalics@gmx.at>
3794
3795 * frame.c (make_frame): Call other_buffer_safely instead of
3796 other_buffer.
3797
3798 * window.c (temp_output_buffer_show): Call display_buffer with
3799 second argument Vtemp_buffer_show_specifiers and reset latter
3800 immediately after the call.
3801 (Vtemp_buffer_show_specifiers): New variable.
3802 (auto_window_vscroll_p, next_screen_context_lines)
3803 (Vscroll_preserve_screen_position): Remove leading asterisks from
3804 doc-strings.
3805
3806 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
3807
3808 Fix minor problems found by GCC 4.6.0 static checking.
3809 * buffer.c (Qclone_number): Remove for now, as it's unused.
3810 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3811 (record_buffer): Remove unused local.
3812 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3813 (set_frame_buffer_list): Remove; unused.
3814 * frame.h (other_visible_frames): Remove decl.
3815 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3816 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3817 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3818 if HAVE_GPM.
3819 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3820 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3821 Define only if HAVE_GPM.
3822 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3823 (update_hints_inhibit): Remove; never set. All uses removed.
3824 * widgetprv.h (emacsFrameClassRec): Remove decl.
3825 * window.c (delete_deletable_window): Now returns void, since it
3826 wasn't returning anything.
3827 (compare_window_configurations): Remove unused locals.
3828 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3829 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
3830 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3831 the same widths as pointers. This follows up on the 2011-05-06 patch.
3832 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3833 * xterm.h: Likewise.
3834 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3835
3836 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
3837
3838 * makefile.w32-in: Update dependencies.
3839 (LISP_H): Add lib/intprops.h.
3840
3841 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3842
3843 * image.c (gif_load): Add animation frame delay to the metadata.
3844 (syms_of_image): Use DEFSYM. New symbol `delay'.
3845
3846 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3847
3848 * window.c (delete_deletable_window): Re-add.
3849 (Fset_window_configuration): Rewrite to handle dead buffers and
3850 consequently deletable windows.
3851 (window_tree, Fwindow_tree): Remove. Supply functionality in
3852 window.el.
3853 (compare_window_configurations): Simplify code.
3854
3855 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3856
3857 * image.c (imagemagick_load_image): Fix type mismatch.
3858 (Fimagemagick_types): Likewise.
3859
3860 * window.h (replace_buffer_in_windows): Declare.
3861
3862 2011-06-11 Martin Rudalics <rudalics@gmx.at>
3863
3864 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3865 Qclone_number. Remove external declaration of Qdelete_window.
3866 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3867 code.
3868 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3869 Run Qbuffer_list_update_hook if allowed.
3870 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3871 buffer list implementation.
3872 (other_buffer_safely): New function.
3873 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3874 calls to replace_buffer_in_windows and
3875 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3876 if allowed.
3877 (record_buffer): Inhibit quitting and rewrite using quittable
3878 functions. Run Qbuffer_list_update_hook if allowed.
3879 (Frecord_buffer, Funrecord_buffer): New functions.
3880 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3881 Move switch-to-buffer to window.el.
3882 (bury-buffer): Move to window.el.
3883 (Vbuffer_list_update_hook): New variable.
3884
3885 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3886 section.
3887
3888 * window.h (resize_frame_windows): Move up in code.
3889 (Fwindow_frame): Remove EXFUN.
3890 (replace_buffer_in_all_windows): Remove prototype.
3891 (replace_buffer_in_windows_safely): Add prototype.
3892
3893 * window.c: Declare Qdelete_window static again. Move down
3894 declaration of select_count.
3895 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3896 (Fother_window): Move to window.el.
3897 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3898 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3899 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3900 window.el.
3901 (replace_buffer_in_windows): Implement by calling
3902 Qreplace_buffer_in_windows.
3903 (replace_buffer_in_all_windows): Remove with some functionality
3904 moved into replace_buffer_in_windows_safely.
3905 (replace_buffer_in_windows_safely): New function.
3906 (select_window_norecord, select_frame_norecord): Move in front
3907 of run_window_configuration_change_hook. Remove now obsolete
3908 declarations.
3909 (Fset_window_buffer): Rewrite doc-string.
3910 Call Qrecord_window_buffer.
3911 (keys_of_window): Move binding for other-window to window.el.
3912
3913 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3914
3915 * dispextern.h (struct image): Replace data member, whose int_val
3916 and ptr_val fields were not used by anything, with a single
3917 lisp_val object.
3918
3919 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3920 (gif_clear_image, gif_load, imagemagick_load_image)
3921 (gs_clear_image, gs_load): Callers changed.
3922
3923 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3924
3925 * buffer.h: Include <time.h>, for time_t.
3926 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3927
3928 Fix minor problems found by static checking.
3929
3930 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3931
3932 Make identifiers static if they are not used in other modules.
3933 * data.c (Qcompiled_function, Qframe, Qvector):
3934 * image.c (QimageMagick, Qsvg):
3935 * minibuf.c (Qmetadata):
3936 * window.c (resize_window_check, resize_root_window): Now static.
3937 * window.h (resize_window_check, resize_root_window): Remove decls.
3938
3939 * window.c (window_deletion_count, delete_deletable_window):
3940 Remove; unused.
3941 (window_body_lines): Now static.
3942 (Fdelete_other_windows_internal): Mark vars as initialized.
3943 Make sure 'resize_failed' is initialized.
3944 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3945 (resize_window_apply): Remove unused local.
3946 * window.h (delete_deletable_window): Remove decl.
3947
3948 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
3949 (imagemagick_load_image): Fix pointer signedness problem by changing
3950 last arg from unsigned char * to char *. All uses changed.
3951 Also, fix a local for similar reasons.
3952 Remove unused locals. Remove locals to avoid shadowing.
3953 (fn_rsvg_handle_free): Remove; unused.
3954 (svg_load, svg_load_image): Fix pointer signedness problem.
3955 (imagemagick_load_image): Don't use garbage pointer image_wand.
3956
3957 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3958
3959 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
3960
3961 * image.c (gif_load): Fix omitted cast error introduced by
3962 2011-06-06 change.
3963
3964 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3965
3966 * window.h (resize_proportionally, orig_total_lines)
3967 (orig_top_line): Remove from window structure.
3968 (set_window_height, set_window_width, change_window_heights)
3969 (Fdelete_window): Remove prototypes.
3970 (resize_frame_windows): Remove duplicate declaration.
3971
3972 2011-06-10 Eli Zaretskii <eliz@gnu.org>
3973
3974 * window.h (resize_frame_windows, resize_window_check)
3975 (delete_deletable_window, resize_root_window)
3976 (resize_frame_windows): Declare prototypes.
3977
3978 * window.c (resize_window_apply): Make definition be "static" to
3979 match the prototype.
3980
3981 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3982
3983 * window.c: Remove declarations of Qwindow_size_fixed,
3984 window_min_size_1, window_min_size_2, window_min_size,
3985 size_window, window_fixed_size_p, enlarge_window, delete_window.
3986 Remove static from declaration of Qdelete_window, it's
3987 temporarily needed by Fbury_buffer.
3988 (replace_window): Don't assign orig_top_line and
3989 orig_total_lines.
3990 (Fdelete_window, delete_window): Remove. Window deletion is
3991 handled by window.el.
3992 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3993 Replace Fdelete_window calls with calls to Qdelete_window.
3994 (Fdelete_other_windows): Remove. Deleting other windows is
3995 handled by window.el.
3996 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3997 handled in window.el.
3998 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3999 Window minimum sizes are handled in window.el.
4000 (shrink_windows, size_window, set_window_height)
4001 (set_window_width, change_window_heights, window_height)
4002 (window_width, CURBEG, CURSIZE, enlarge_window)
4003 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4004 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4005 handled in window.el.
4006 (make_dummy_parent): Rename to make_parent_window and give it a
4007 second argument horflag.
4008 (make_window): Don't set resize_proportionally any more.
4009 (Fsplit_window): Remove. Windows are split in window.el.
4010 (save_restore_action, save_restore_orig_size)
4011 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4012 Resize mini windows in window.el.
4013 (grow_mini_window, shrink_mini_window): Implement by calling
4014 Qresize_root_window_vertically, resize_window_check and
4015 resize_window_apply.
4016 (saved_window, Fset_window_configuration, save_window_save):
4017 Do not handle orig_top_line, orig_total_lines, and
4018 resize_proportionally.
4019 (window_min_height, window_min_width): Move to window.el.
4020 (keys_of_window): Move bindings for delete-other-windows,
4021 split-window, delete-window and enlarge-window to window.el.
4022
4023 * buffer.c: Temporarily extern Qdelete_window.
4024 (Fbury_buffer): Temporarily call Qdelete_window instead of
4025 Fdelete_window (Fbury_buffer will move to window.el soon).
4026
4027 * frame.c (set_menu_bar_lines_1): Remove code handling
4028 orig_top_line and orig_total_lines.
4029
4030 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4031 set_window_height but set heights directly.
4032 (change_frame_size_1): Use resize_frame_windows.
4033
4034 * xdisp.c (init_xdisp): Don't use set_window_height but set
4035 heights directly.
4036
4037 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4038 Use resize_frame_windows instead of change_window_heights and run
4039 run_window_configuration_change_hook.
4040
4041 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4042 instead of change_window_heights and run
4043 run_window_configuration_change_hook.
4044
4045 2011-06-09 Martin Rudalics <rudalics@gmx.at>
4046
4047 * window.c (replace_window): Rename second argument REPLACEMENT to
4048 NEW. New third argument SETFLAG. Rewrite.
4049 (delete_window, make_dummy_parent): Call replace_window with
4050 third argument 1.
4051 (window_list_1): Move down in code.
4052 (run_window_configuration_change_hook): Move set_buffer part
4053 before select_frame_norecord part in order to unwind correctly.
4054 Rename count1 to count.
4055 (recombine_windows, delete_deletable_window, resize_root_window)
4056 (Fdelete_other_windows_internal)
4057 (Frun_window_configuration_change_hook, make_parent_window)
4058 (resize_window_check, resize_window_apply, Fresize_window_apply)
4059 (resize_frame_windows, Fsplit_window_internal)
4060 (Fdelete_window_internal, Fresize_mini_window_internal):
4061 New functions.
4062 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4063
4064 2011-06-08 Martin Rudalics <rudalics@gmx.at>
4065
4066 * window.h (window): Add some new members to window structure -
4067 normal_lines, normal_cols, new_total, new_normal, clone_number,
4068 splits, nest, prev_buffers, next_buffers.
4069 (WINDOW_TOTAL_SIZE): Move here from window.c.
4070 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
4071
4072 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4073 Remove.
4074 (make_dummy_parent): Set new members of windows structure.
4075 (make_window): Move down in code. Handle new members of window
4076 structure.
4077 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4078 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4079 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4080 (Fset_window_prev_buffers, Fwindow_next_buffers)
4081 (Fset_window_next_buffers, Fset_window_clone_number):
4082 New functions.
4083 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4084 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4085 Doc-string fixes.
4086 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4087 Argument WINDOW can be now internal window too.
4088 (Fwindow_use_time): Move up in code.
4089 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4090 Rewrite doc-string.
4091 (Fset_window_configuration, saved_window)
4092 (Fcurrent_window_configuration, save_window_save): Handle new
4093 members of window structure.
4094 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4095 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4096 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4097 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4098 Qget_mru_window, Qresize_root_window,
4099 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4100 Qauto_buffer_name; staticpro them.
4101
4102 2011-06-07 Martin Rudalics <rudalics@gmx.at>
4103
4104 * window.c (Fwindow_total_size, Fwindow_left_column)
4105 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4106 (Fwindow_list_1): New functions.
4107 (window_box_text_cols): Replace with window_body_cols.
4108 (Fwindow_width, Fscroll_left, Fscroll_right):
4109 Use window_body_cols instead of window_box_text_cols.
4110 (delete_window, Fset_window_configuration):
4111 Call delete_all_subwindows with window as argument.
4112 (delete_all_subwindows): Take a window as argument and not a
4113 structure. Rewrite.
4114 (window_loop): Remove handling of GET_LRU_WINDOW and
4115 GET_LARGEST_WINDOW.
4116 (Fget_lru_window, Fget_largest_window): Move to window.el.
4117
4118 * window.h: Extern window_body_cols instead of
4119 window_box_text_cols. delete_all_subwindows now takes a
4120 Lisp_Object as argument.
4121
4122 * indent.c (compute_motion, Fcompute_motion):
4123 Use window_body_cols instead of window_box_text_cols.
4124
4125 * frame.c (delete_frame): Call delete_all_subwindows with root
4126 window as argument.
4127
4128 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4129
4130 * fns.c (Fputhash): Document return value.
4131
4132 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
4133
4134 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4135
4136 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4137
4138 Cons<->int and similar integer overflow fixes (Bug#8794).
4139
4140 Check for overflow when converting integer to cons and back.
4141 * charset.c (Fdefine_charset_internal, Fdecode_char):
4142 Use cons_to_unsigned to catch overflow.
4143 (Fencode_char): Use INTEGER_TO_CONS.
4144 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4145 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4146 * data.c (long_to_cons, cons_to_long): Remove.
4147 (cons_to_unsigned, cons_to_signed): New functions.
4148 These signal an error for invalid or out-of-range values.
4149 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4150 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4151 * font.c (Ffont_variation_glyphs):
4152 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4153 * lisp.h: Include <intprops.h>.
4154 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4155 (cons_to_signed, cons_to_unsigned): New decls.
4156 (long_to_cons, cons_to_long): Remove decls.
4157 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4158 (Fprimitive_undo): Use CONS_TO_INTEGER.
4159 * xfns.c (Fx_window_property): Likewise.
4160 * xselect.c: Include <limits.h>.
4161 (x_own_selection, selection_data_to_lisp_data):
4162 Use INTEGER_TO_CONS.
4163 (x_handle_selection_request, x_handle_selection_clear)
4164 (x_get_foreign_selection, Fx_disown_selection_internal)
4165 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4166 (lisp_data_to_selection_data): Use cons_to_unsigned.
4167 (x_fill_property_data): Use cons_to_signed.
4168 Report values out of range.
4169
4170 Check for buffer and string overflow more precisely.
4171 * buffer.h (BUF_BYTES_MAX): New macro.
4172 * lisp.h (STRING_BYTES_MAX): New macro.
4173 * alloc.c (Fmake_string):
4174 * character.c (string_escape_byte8):
4175 * coding.c (coding_alloc_by_realloc):
4176 * doprnt.c (doprnt):
4177 * editfns.c (Fformat):
4178 * eval.c (verror):
4179 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4180 since they may not be the same number.
4181 * editfns.c (Finsert_char):
4182 * fileio.c (Finsert_file_contents):
4183 Likewise for BUF_BYTES_MAX.
4184
4185 * image.c: Use ptrdiff_t, not int, for sizes.
4186 (slurp_file): Switch from int to ptrdiff_t.
4187 All uses changed.
4188 (slurp_file): Check that file size fits in both size_t (for
4189 malloc) and ptrdiff_t (for sanity and safety).
4190
4191 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4192 if b->modtime has its maximal value.
4193
4194 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4195
4196 Don't assume time_t can fit into int.
4197 * buffer.h (struct buffer.modtime): Now time_t, not int.
4198 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4199 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4200
4201 Minor fixes for signed vs unsigned integers.
4202 * character.h (MAYBE_UNIFY_CHAR):
4203 * charset.c (maybe_unify_char):
4204 * keyboard.c (read_char, reorder_modifiers):
4205 XINT -> XFASTINT, since the integer must be nonnegative.
4206 * ftfont.c (ftfont_spec_pattern):
4207 * keymap.c (access_keymap, silly_event_symbol_error):
4208 XUINT -> XFASTINT, since the integer must be nonnegative.
4209 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4210 since it makes no difference and we prefer signed.
4211 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4212 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4213 nonnegative.
4214
4215 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4216
4217 * window.h (Fwindow_frame): Declare.
4218
4219 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4220
4221 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4222 (SPARE_MEMORY): Always define.
4223 (LARGE_REQUEST): Remove.
4224 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4225
4226 2011-06-06 Martin Rudalics <rudalics@gmx.at>
4227
4228 * lisp.h: Move EXFUNS for Fframe_root_window,
4229 Fframe_first_window and Fset_frame_selected_window to window.h.
4230
4231 * window.h: Move EXFUNS for Fframe_root_window,
4232 Fframe_first_window and Fset_frame_selected_window here from
4233 lisp.h.
4234
4235 * frame.c (Fwindow_frame, Fframe_first_window)
4236 (Fframe_root_window, Fframe_selected_window)
4237 (Fset_frame_selected_window): Move to window.c.
4238 (Factive_minibuffer_window): Move to minibuf.c.
4239 (Fother_visible_frames_p): New function.
4240
4241 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4242
4243 * window.c (decode_window, decode_any_window): Move up in code.
4244 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4245 (inhibit_frame_unsplittable): Remove unused variable.
4246 (Fwindow_buffer): Move up and rewrite doc-string.
4247 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4248 (Fwindow_prev): New functions.
4249 (Fwindow_frame): Move here from frame.c. Accept any window as
4250 argument.
4251 (Fframe_root_window, Fframe_first_window)
4252 (Fframe_selected_window): Move here from frame.c. Accept frame
4253 or arbitrary window as argument. Update doc-strings.
4254 (Fminibuffer_window): Move up in code.
4255 (Fwindow_minibuffer_p): Move up in code and simplify.
4256 (Fset_frame_selected_window): Move here from frame.c.
4257 Marginal rewrite.
4258 (Fselected_window, select_window, Fselect_window): Move up in
4259 code. Minor doc-string fixes.
4260
4261 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4262
4263 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4264 Do not assume that spare memory exists; that assumption is valid
4265 only if SYSTEM_MALLOC.
4266 (LARGE_REQUEST): New macro, so that the issue of large requests
4267 is separated from the issue of spare memory.
4268
4269 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4270
4271 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4272 format. (Bug#8806)
4273
4274 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4275
4276 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4277 before statements.
4278
4279 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4280
4281 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4282
4283 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4284
4285 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4286 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4287
4288 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
4289
4290 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4291
4292 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
4293
4294 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4295 (x_clipboard_manager_save): Add return value.
4296 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4297 New error handlers.
4298 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4299 Obey Vx_select_enable_clipboard_manager. Catch errors in
4300 x_clipboard_manager_save (Bug#8779).
4301 (Vx_select_enable_clipboard_manager): New variable.
4302 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4303
4304 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
4305
4306 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4307
4308 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4309
4310 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4311 in the current matrix if keep_current_p is non-zero.
4312
4313 2011-06-04 Eli Zaretskii <eliz@gnu.org>
4314
4315 * bidi.c (bidi_level_of_next_char): Fix last change.
4316
4317 2011-06-03 Eli Zaretskii <eliz@gnu.org>
4318
4319 Support bidi reordering of text covered by display properties.
4320
4321 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4322 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4323 (bidi_cache_search, bidi_cache_iterator_state)
4324 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
4325 (bidi_level_of_next_char, bidi_move_to_visually_next):
4326 Support character positions inside a run of characters covered by a
4327 display string.
4328 (bidi_paragraph_init, bidi_resolve_explicit_1)
4329 (bidi_level_of_next_char): Call bidi_fetch_char and
4330 bidi_fetch_char_advance instead of FETCH_CHAR and
4331 FETCH_CHAR_ADVANCE.
4332 (bidi_init_it): Initialize new members.
4333 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4334 definitions.
4335 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4336 instead of using explicit *_CHAR codes.
4337 (bidi_resolve_explicit, bidi_resolve_weak):
4338 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
4339 bidirectional text is supported only in multibyte buffers.
4340 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4341 it to initialize the frame_window_p member of struct bidi_it.
4342 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4343 (bidi_resolve_explicit, bidi_resolve_weak)
4344 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4345 bidi_it->nchars is non-positive.
4346 (bidi_level_of_next_char): Don't try to lookup the cache for the
4347 next/previous character if nothing is cached there yet, or if we
4348 were just reseat()'ed to a new position.
4349
4350 * xdisp.c (set_cursor_from_row): Set start and stop points
4351 according to the row's direction when priming the loop that looks
4352 for the glyph on which to display cursor.
4353 (single_display_spec_intangible_p): Function deleted.
4354 (display_prop_intangible_p): Reimplement to call
4355 handle_display_spec instead of single_display_spec_intangible_p.
4356 Accept 3 additional arguments needed by handle_display_spec.
4357 This fixes incorrect cursor motion across display property with complex
4358 values: lists, `(when COND...)' forms, etc.
4359 (single_display_spec_string_p): Support property values that are
4360 lists with the argument STRING its top-level element.
4361 (display_prop_string_p): Fix the condition for processing a
4362 property that is a list to be consistent with handle_display_spec.
4363 (handle_display_spec): New function, refactored from the
4364 last portion of handle_display_prop.
4365 (compute_display_string_pos): Accept additional argument
4366 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4367 value of a `display' property is a "replacing spec".
4368 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4369 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4370 the display property, but just return a value indicating whether
4371 the display property will replace the characters it covers.
4372 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4373 frame_window_p members of struct bidi_it.
4374 (compute_display_string_pos, compute_display_string_end):
4375 New functions.
4376 (push_it): Accept second argument POSITION, where pop_it should
4377 jump to continue iteration.
4378 (reseat_1): Initialize bidi_it.disp_pos.
4379
4380 * keyboard.c (adjust_point_for_property): Adjust the call to
4381 display_prop_intangible_p to its new signature.
4382
4383 * dispextern.h (struct bidi_it): New member frame_window_p.
4384 (bidi_init_it): Update prototypes.
4385 (display_prop_intangible_p): Update prototype.
4386 (compute_display_string_pos, compute_display_string_end):
4387 Declare prototypes.
4388 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4389 EMACS_INT.
4390
4391 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
4392
4393 Malloc failure behavior now depends on size of allocation.
4394 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4395 * lisp.h: Change signatures accordingly.
4396 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4397 All callers changed. (Bug#8762)
4398
4399 * gnutls.c: Use Emacs's memory allocators.
4400 Without this change, the gnutls library would invoke malloc etc.
4401 directly, which causes problems on non-SYNC_INPUT hosts, and which
4402 runs afoul of improving memory_full behavior. (Bug#8761)
4403 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4404 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4405 xfree instead of the default malloc, realloc, free.
4406 (Fgnutls_boot): No need to check for memory allocation failure,
4407 since xmalloc does that for us.
4408
4409 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
4410 * category.c (hash_get_category_set):
4411 * ccl.c (ccl_driver):
4412 * charset.c (Fdefine_charset_internal):
4413 * charset.h (struct charset.hash_index):
4414 * composite.c (get_composition_id, gstring_lookup_cache)
4415 (composition_gstring_put_cache):
4416 * composite.h (struct composition.hash_index):
4417 * dispextern.h (struct image.hash):
4418 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
4419 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
4420 (hashfn_equal, hashfn_user_defined, make_hash_table)
4421 (maybe_resize_hash_table, hash_lookup, hash_put)
4422 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
4423 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
4424 (Fsxhash, Fgethash, Fputhash, Fmaphash):
4425 * image.c (make_image, search_image_cache, lookup_image)
4426 (xpm_put_color_table_h):
4427 * lisp.h (struct Lisp_Hash_Table):
4428 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
4429 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
4430 for hashes and hash indexes, instead of 'unsigned' and 'int'.
4431 * alloc.c (allocate_vectorlike):
4432 Check for overflow in vector size calculations.
4433 * ccl.c (ccl_driver):
4434 Check for overflow when converting EMACS_INT to int.
4435 * fns.c, image.c: Remove unnecessary static decls that would otherwise
4436 need to be updated by these changes.
4437 * fns.c (make_hash_table, maybe_resize_hash_table):
4438 Check for integer overflow with large hash tables.
4439 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
4440 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
4441 (SXHASH_REDUCE): New macro.
4442 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
4443 Use it instead of discarding useful hash info with large hash values.
4444 (sxhash_float): New function.
4445 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
4446 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
4447 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
4448 Rewrite to use FIXNUM_BITS, as this simplifies things.
4449 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
4450 Adjust signatures to match updated version of code.
4451 (consing_since_gc): Now EMACS_INT, since a single hash table can
4452 use more than INT_MAX bytes.
4453
4454 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
4455
4456 Make it possible to build with GCC-4.6+ -O2 -flto.
4457
4458 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
4459
4460 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
4461
4462 * minibuf.c (get_minibuffer, read_minibuf_unwind):
4463 Call minibuffer-inactive-mode.
4464
4465 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
4466
4467 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
4468 Update dependencies.
4469
4470 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4471
4472 * data.c (init_data): Remove code for UTS, this system is not
4473 supported anymore.
4474
4475 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4476
4477 Don't force ./temacs to start in terminal mode.
4478
4479 * frame.c (make_initial_frame): Initialize faces in all cases, not
4480 only when CANNOT_DUMP is defined.
4481 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
4482
4483 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4484
4485 * dispnew.c (add_window_display_history): Use const for the string
4486 pointer. Remove declaration, not needed.
4487
4488 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4489
4490 Use 'inline', not 'INLINE'.
4491 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
4492 * alloc.c, fontset.c (INLINE): Remove.
4493 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
4494 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
4495 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
4496 * gmalloc.c (register_heapinfo): Use inline unconditionally.
4497 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
4498
4499 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
4500
4501 Make it possible to run ./temacs.
4502
4503 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
4504 syms_of_callproc does the same thing. Remove test for
4505 "initialized", do it in the caller.
4506 * emacs.c (main): Avoid calling set_initial_environment when dumping.
4507
4508 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
4509
4510 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
4511 (read_minibuf): Use get_minibuffer.
4512 (syms_of_minibuf): Use DEFSYM.
4513 (Qmetadata): New var.
4514 * data.c (Qbuffer): Don't make it static.
4515 (syms_of_data): Use DEFSYM.
4516
4517 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
4518
4519 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
4520 (CCL_CODE_MIN): New macro.
4521
4522 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
4523
4524 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
4525
4526 * eval.c (Qdebug): Now static.
4527 * lisp.h (Qdebug): Remove decl. This reverts a part of the
4528 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
4529 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
4530
4531 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4532
4533 * image.c: Various fixes to ImageMagick code comments.
4534 (Fimagemagick_types): Doc fix.
4535
4536 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4537
4538 Minor fixes prompted by GCC 4.6.0 warnings.
4539
4540 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4541
4542 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4543 (x_clipboard_manager_save_all): Move extern decl to ...
4544 * xterm.h: ... here, so that it can be checked for consistency.
4545
4546 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
4547
4548 * xselect.c (x_clipboard_manager_save_frame)
4549 (x_clipboard_manager_save_all): New functions.
4550 (Fx_clipboard_manager_save): Lisp function deleted.
4551
4552 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4553 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4554
4555 * xterm.h: Update prototype.
4556
4557 2011-05-28 William Xu <william.xwl@gmail.com>
4558
4559 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4560 exiting (Bug#8239).
4561
4562 2011-05-28 Jim Meyering <meyering@redhat.com>
4563
4564 Avoid a sign-extension bug in crypto_hash_function.
4565 * fns.c (to_uchar): Define.
4566 (crypto_hash_function): Use it to convert some newly-signed
4567 variables to unsigned, to avoid sign-extension bugs. For example,
4568 without this change, (md5 "truc") would evaluate to
4569 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4570 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
4571 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
4572
4573 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4574
4575 Integer overflow fixes.
4576
4577 * dbusbind.c: Serial number integer overflow fixes.
4578 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
4579 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4580 to hold a serial number that is too large for a fixnum.
4581 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4582 Check for serial numbers out of range. Decode any serial number
4583 that was so large that it became a float. (Bug#8722)
4584
4585 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4586 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4587 Use XFASTINT rather than XUINT when numbers are nonnegative.
4588 (xd_append_arg, Fdbus_method_return_internal):
4589 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4590 arguments, check that Lisp number is nonnegative, rather than
4591 silently wrapping negative numbers around. (Bug#8722)
4592 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
4593 (Bug#8722)
4594
4595 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4596
4597 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4598
4599 ccl: add integer overflow checks
4600 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4601 (IN_INT_RANGE): New macros.
4602 (ccl_driver): Use them to check for integer overflow when
4603 decoding a CCL program. Many of the new checks are whether XINT (x)
4604 fits in int; it doesn't always, on 64-bit hosts. The new version
4605 doesn't catch all possible integer overflows, but it's an
4606 improvement. (Bug#8719)
4607
4608 * alloc.c (make_event_array): Use XINT, not XUINT.
4609 There's no need for unsigned here.
4610
4611 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4612 This follows up to the 2011-05-06 change that substituted uintptr_t
4613 for EMACS_INT. This case wasn't caught back then.
4614
4615 Rework Fformat to avoid integer overflow issues.
4616 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4617 now (part of C89). Include <verify.h>.
4618 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4619 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4620 (Fformat): Avoid the prepass trying to compute sizes; it was only
4621 approximate and thus did not catch overflow reliably. Instead, walk
4622 through the format just once, formatting and computing sizes as we go,
4623 checking for integer overflow at every step, and allocating a larger
4624 buffer as needed. Keep track separately whether the format is
4625 multibyte. Keep only the most-recently calculated precision, rather
4626 than them all. Record whether each argument has been converted to
4627 string. Use EMACS_INT, not int, for byte and char and arg counts.
4628 Support field widths and precisions larger than INT_MAX. Avoid
4629 sprintf's undefined behavior with conversion specifications such as %#d
4630 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4631 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4632 formatting out-of-range floating point numbers with int
4633 formats. (Bug#8668)
4634
4635 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4636
4637 * data.c: Avoid integer truncation in expressions involving floats.
4638 * data.c: Include <intprops.h>.
4639 (arith_driver): When there's an integer overflow in an expression
4640 involving floating point, convert the integers to floating point
4641 so that the resulting value does not suffer from catastrophic
4642 integer truncation. For example, on a 64-bit host (* 4
4643 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4644 Do not rely on undefined behavior after integer overflow.
4645
4646 merge count_size_as_multibyte, parse_str_to_multibyte
4647 * character.c, character.h (count_size_as_multibyte):
4648 Rename from parse_str_to_multibyte; all uses changed.
4649 Check for integer overflow.
4650 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4651 since it's now a duplicate of the other. This is more of
4652 a character than a buffer op, so better that it's in character.c.
4653 * fns.c, print.c: Adjust to above changes.
4654
4655 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4656
4657 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4658
4659 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4660
4661 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4662 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4663 (x_clipboard_manager_save): Now static.
4664 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4665
4666 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4667 (crypto_hash_function): Now static.
4668 Fix pointer signedness problems. Avoid unnecessary initializations.
4669
4670 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
4671
4672 * termhooks.h (Vselection_alist): Make it terminal-local.
4673
4674 * terminal.c (create_terminal): Initialize it.
4675
4676 * xselect.c: Support for clipboard managers.
4677 (Vselection_alist): Move to termhooks.h as terminal-local var.
4678 (LOCAL_SELECTION): New macro.
4679 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4680 (symbol_to_x_atom): Remove gratuitous arg.
4681 (x_handle_selection_request, lisp_data_to_selection_data)
4682 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
4683 (x_own_selection, x_get_local_selection, x_convert_selection):
4684 New arg, specifying work frame. Use terminal-local Vselection_alist.
4685 (some_frame_on_display): Delete unused function.
4686 (Fx_own_selection_internal, Fx_get_selection_internal)
4687 (Fx_disown_selection_internal, Fx_selection_owner_p)
4688 (Fx_selection_exists_p): New optional frame arg.
4689 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4690 (x_handle_selection_clear): Don't treat other terminals with the
4691 same keyboard specially. Use the terminal-local Vselection_alist.
4692 (x_clear_frame_selections): Use Frun_hook_with_args.
4693
4694 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4695
4696 * xterm.h: Add support for those atoms.
4697
4698 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
4699
4700 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4701 (converted_selections, conversion_fail_tag): New global variables.
4702 (x_selection_request_lisp_error): Free the above.
4703 (x_get_local_selection): Remove unnecessary code.
4704 (x_reply_selection_request): Args changed; handle arbitrary array
4705 of converted selections stored in converted_selections.
4706 Separate the XChangeProperty and SelectionNotify steps.
4707 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4708 (x_convert_selection): New function.
4709 (x_handle_selection_event): Simplify.
4710 (x_get_foreign_selection): Don't ignore incoming requests while
4711 waiting for an answer; this will fail when we implement
4712 SAVE_TARGETS, and seems unnecessary anyway.
4713 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4714 (Vx_sent_selection_functions): Doc fix.
4715
4716 2011-05-26 Leo Liu <sdl.web@gmail.com>
4717
4718 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4719
4720 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4721
4722 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4723
4724 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4725 for fringe update if it has periodic bitmap.
4726 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
4727 and fringe_bitmap_periodic_p.
4728
4729 * fringe.c (get_fringe_bitmap_data): New function.
4730 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4731 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4732 row. Mark glyph row for fringe update if periodicity changed.
4733
4734 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4735 for fringe update unless it has periodic bitmap.
4736
4737 2011-05-25 Kenichi Handa <handa@m17n.org>
4738
4739 * xdisp.c (get_next_display_element): Set correct it->face_id for
4740 a static composition.
4741
4742 2011-05-24 Leo Liu <sdl.web@gmail.com>
4743
4744 * deps.mk (fns.o):
4745 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4746
4747 * fns.c (crypto_hash_function, Fsha1): New function.
4748 (Fmd5): Use crypto_hash_function.
4749 (syms_of_fns): Add Ssha1.
4750
4751 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4752
4753 * gnutls.c: Remove unused macros.
4754 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4755 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4756 Remove macros that are defined and never used.
4757 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4758
4759 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4760
4761 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4762 (Fx_get_selection_internal): Minor cleanup.
4763 (Fx_own_selection_internal): Rename arguments for consistency with
4764 select.el.
4765
4766 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4767
4768 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4769
4770 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
4771
4772 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4773
4774 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4775
4776 * dispnew.c (scrolling_window): Don't exclude the case that the
4777 last enabled row in the desired matrix touches the bottom boundary.
4778
4779 2011-05-21 Glenn Morris <rgm@gnu.org>
4780
4781 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
4782 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4783 and add some more files.
4784
4785 2011-05-20 Eli Zaretskii <eliz@gnu.org>
4786
4787 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4788 report_file_error introduced by the change from 2011-05-07.
4789
4790 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4791
4792 * systime.h (Time): Define only if emacs is defined.
4793 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4794 where the include path doesn't have X11/X.h by default. See
4795 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4796
4797 2011-05-20 Kenichi Handa <handa@m17n.org>
4798
4799 * composite.c (find_automatic_composition): Fix previous change.
4800
4801 2011-05-20 Glenn Morris <rgm@gnu.org>
4802
4803 * lisp.mk: New file, split from Makefile.in.
4804 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4805 (shortlisp): Remove.
4806 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4807
4808 2011-05-19 Glenn Morris <rgm@gnu.org>
4809
4810 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4811 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4812 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4813 (lisp): Set the order to that of loadup.el.
4814 (shortlisp): Make it a copy of $lisp.
4815 (SOME_MACHINE_LISP): Remove.
4816 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4817 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4818
4819 2011-05-18 Kenichi Handa <handa@m17n.org>
4820
4821 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4822 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4823 (find_automatic_composition): Mostly rewrite for efficiency.
4824
4825 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
4826
4827 * makefile.w32-in: Update dependencies.
4828
4829 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4830
4831 * menu.c: Include limits.h (fixes the MS-Windows build broken by
4832 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
4833
4834 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
4835
4836 Fix some integer overflow issues, such as string length overflow.
4837
4838 * insdel.c (count_size_as_multibyte): Check for string overflow.
4839
4840 * character.c (lisp_string_width): Check for string overflow.
4841 Use EMACS_INT, not int, for string indexes and lengths; in
4842 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4843 the resulting string length overflows an EMACS_INT; instead,
4844 report a string overflow if no precision given. When checking for
4845 precision exhaustion, use a check that cannot possibly have
4846 integer overflow. (Bug#8675)
4847 * character.h (lisp_string_width): Adjust to new signature.
4848
4849 * alloc.c (string_overflow): New function.
4850 (Fmake_string): Use it. This doesn't change behavior, but saves
4851 a few bytes and will simplify future changes.
4852 * character.c (string_escape_byte8): Likewise.
4853 * lisp.h (string_overflow): New decl.
4854
4855 Fixups, following up to the user-interface timestamp change.
4856 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4857 for UI timestamps, instead of unsigned long.
4858 * msdos.c (mouse_get_pos): Likewise.
4859 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
4860 * w32gui.h (Time): Define by including "systime.h" rather than by
4861 declaring it ourselves. (Bug#8664)
4862
4863 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4864 * image.c (clear_image_cache): Likewise.
4865
4866 * term.c (term_mouse_position): Don't assume time_t wraparound.
4867
4868 Be more systematic about user-interface timestamps.
4869 Before, the code sometimes used 'Time', sometimes 'unsigned long',
4870 and sometimes 'EMACS_UINT', to represent these timestamps.
4871 This change causes it to use 'Time' uniformly, as that's what X uses.
4872 This makes the code easier to follow, and makes it easier to catch
4873 integer overflow bugs such as Bug#8664.
4874 * frame.c (Fmouse_position, Fmouse_pixel_position):
4875 Use Time, not unsigned long, for user-interface timestamps.
4876 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4877 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4878 * keyboard.h (last_event_timestamp): Likewise.
4879 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4880 * menu.h (xmenu_show): Likewise.
4881 * term.c (term_mouse_position): Likewise.
4882 * termhooks.h (struct input_event.timestamp): Likewise.
4883 (struct terminal.mouse_position_hook): Likewise.
4884 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4885 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4886 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4887 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4888 what it was before.
4889 * menu.h, termhooks.h: Include "systime.h", for Time.
4890
4891 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4892 Don't assume that the difference between two unsigned long values
4893 can fit into an integer. At this point, we know button_down_time
4894 <= event->timestamp, so the difference must be nonnegative, so
4895 there's no need to cast the result if double-click-time is
4896 nonnegative, as it should be; check that it's nonnegative, just in
4897 case. This bug is triggered when events are more than 2**31 ms
4898 apart (about 25 days). (Bug#8664)
4899
4900 * xselect.c (last_event_timestamp): Remove duplicate decl.
4901 (x_own_selection): Remove needless cast to unsigned long.
4902
4903 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4904 that always fit in int. Use a sentinel instead of a counter, to
4905 avoid a temp and to allay GCC's concerns about possible int overflow.
4906 * frame.h (struct frame): Use int for menu_bar_items_used
4907 instead of EMACS_INT, since it always fits in int.
4908
4909 * menu.c (grow_menu_items): Check for int overflow.
4910
4911 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4912
4913 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4914 Before, the code was not consistent. These values cannot exceed
4915 2**31 - 1 so there's no need to make them unsigned.
4916 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4917 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4918 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4919 as modifiers.
4920 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4921
4922 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4923 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4924 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4925 presumably because the widths might not match.
4926
4927 * window.c (size_window): Avoid needless test at loop start.
4928
4929 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4930
4931 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4932
4933 2011-05-12 Drew Adams <drew.adams@oracle.com>
4934
4935 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4936
4937 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4938
4939 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4940 `width' to `bar_area_x' and `bar_area_width', respectively.
4941 (x_scroll_run): Take account of fringe background extension.
4942
4943 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4944 Rename local vars `left' and `width' to `bar_area_x' and
4945 `bar_area_width', respectively.
4946 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4947 background extension.
4948
4949 2011-05-10 Jim Meyering <meyering@redhat.com>
4950
4951 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4952
4953 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
4954
4955 * image.c (Finit_image_library): Return t for built-in image types,
4956 like pbm and xbm. (Bug#8640)
4957
4958 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4959
4960 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4961
4962 2011-05-07 Eli Zaretskii <eliz@gnu.org>
4963
4964 * w32console.c (Fset_screen_color): Doc fix.
4965 (Fget_screen_color): New function.
4966 (syms_of_ntterm): Defsubr it.
4967
4968 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4969 unlink the temporary file if Fcall_process didn't create it in the
4970 first place.
4971 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4972 child process will be redirected to a file specified with `:file'.
4973 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4974 cue to call_process_cleanup not to close that handle.
4975
4976 2011-05-07 Ben Key <bkey76@gmail.com>
4977
4978 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4979 one of two shell specific rules, either bootstrap-temacs-CMD or
4980 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4981 to the previous implementation of the bootstrap-temacs rule.
4982 The bootstrap-temacs-CMD rule is similar to the previous
4983 implementation of the bootstrap-temacs rule except that it
4984 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4985 variable.
4986
4987 These changes, along with some changes to nt/configure.bat,
4988 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4989 earlier fix to add support for --cflags and --ldflags options
4990 that include quotes so that it works whether make uses cmd or
4991 sh as the shell.
4992
4993 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
4994
4995 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4996 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4997 is a constant.
4998 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4999 a string. Handle both cases.
5000 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5001 (Fdbus_register_method): Use Qinvalid_function.
5002
5003 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
5004
5005 * makefile.w32-in: Update dependencies.
5006 (LISP_H): Add inttypes.h and stdin.h.
5007 (PROCESS_H): Add unistd.h.
5008
5009 2011-05-06 Eli Zaretskii <eliz@gnu.org>
5010
5011 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5012 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5013
5014 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
5015
5016 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5017
5018 * term.c (vfatal): Remove stray call to va_end.
5019 It's not needed and the C Standard doesn't allow it here anyway.
5020
5021 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5022 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5023
5024 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5025 bytes.
5026
5027 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5028
5029 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5030
5031 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5032
5033 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5034
5035 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5036
5037 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5038 * charset.c (Fdefine_charset_internal): Don't initialize
5039 charset.code_space[15]. The value was garbage, on hosts with
5040 32-bit int (Bug#8600).
5041
5042 * lread.c (read_integer): Be more consistent with string-to-number.
5043 Use string_to_number to do the actual conversion; this avoids
5044 rounding errors and fixes some other screwups. Without this fix,
5045 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5046 (digit_to_number): Move earlier, for benefit of read_integer.
5047 Return -1 if the digit is out of range for the base, -2 if it is
5048 not a digit in any supported base. (Bug#8602)
5049
5050 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5051
5052 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5053 to match comment at start of function. This also removes a
5054 GCC warning about overflow in a 32+64-bit port.
5055
5056 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5057
5058 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5059 Reported by Stefan Monnier in
5060 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
5061 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5062 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
5063
5064 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5065 (EMACS_UINTPTR): Likewise, with uintptr_t.
5066
5067 * lisp.h: Prefer 64-bit EMACS_INT if available.
5068 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5069 on 32-bit hosts that have 64-bit int, so that they can access
5070 large files.
5071 However, temporarily disable this change unless the temporary
5072 symbol WIDE_EMACS_INT is defined.
5073
5074 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5075
5076 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5077 This removes an assumption that EMACS_INT and long are the same
5078 width as pointers. The assumption is true for Emacs porting targets
5079 now, but we want to make other targets possible.
5080 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5081 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5082 In the rest of the code, change types of integers that hold casted
5083 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5084 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5085 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5086 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5087 No need to cast type when ORing.
5088 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5089 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5090 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5091 assume EMACS_INT is the same width as char *.
5092 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5093 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5094 Remove no-longer-needed casts.
5095 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5096 (xg_tool_bar_help_callback, xg_make_tool_item):
5097 Use EMACS_INTPTR to hold an integer
5098 that will be cast to void *; this can avoid a GCC warning
5099 if EMACS_INT is not the same width as void *.
5100 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5101 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5102 (current_message_1, set_message_1):
5103 Use a local to convert to proper width without a cast.
5104 * xmenu.c (dialog_selection_callback): Likewise.
5105
5106 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5107 Also, don't assume VALBITS / RAND_BITS is less than 5,
5108 and don't rely on undefined behavior when shifting a 1 left into
5109 the sign bit.
5110 * lisp.h (get_random): Change signature to match.
5111
5112 * lread.c (hash_string): Use size_t, not int, for hash computation.
5113 Normally we prefer signed values; but hashing is special, because
5114 it's better to use unsigned division on hash table sizes so that
5115 the remainder is nonnegative. Also, size_t is the natural width
5116 for hashing into memory. The previous code used 'int', which doesn't
5117 retain enough info to hash well into very large tables.
5118 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5119
5120 * dbusbind.c: Don't possibly lose pointer info when converting.
5121 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5122 Use XPNTR rather than XHASH, so that the high-order bits of
5123 the pointer aren't lost when converting through void *.
5124
5125 * eval.c (Fautoload): Don't double-shift a pointer.
5126
5127 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5128
5129 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
5130
5131 * gnutls.c (DEF_GNUTLS_FN):
5132 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5133
5134 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5135
5136 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5137 marker. (Bug#8610)
5138
5139 2011-05-05 Eli Zaretskii <eliz@gnu.org>
5140
5141 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5142 New version that can reserve upto 2GB of heap space.
5143
5144 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
5145
5146 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5147
5148 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5149
5150 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5151 `gnutls_certificate_set_x509_key_file'.
5152
5153 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
5154
5155 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5156 Update dependencies.
5157
5158 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5159
5160 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5161 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5162 Remove unused parameter `fildes'.
5163 * process.c (read_process_output, send_process): Don't pass it.
5164
5165 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5166
5167 Fix previous change: the library cache is defined in w32.c.
5168 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5169 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5170
5171 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
5172
5173 Implement dynamic loading of GnuTLS on Windows.
5174
5175 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5176 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5177 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5178 Declare.
5179
5180 * gnutls.c (Qgnutls_dll): Define.
5181 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5182 (gnutls_*): Declare function pointers.
5183 (init_gnutls_functions): New function to initialize function pointers.
5184 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5185 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5186 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5187 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5188 (emacs_gnutls_write, emacs_gnutls_read)
5189 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5190 (Fgnutls_available_p): New function.
5191 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5192 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5193 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5194
5195 * image.c: Include w32.h.
5196 (Vimage_type_cache): Delete.
5197 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5198 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5199 (w32_delayed_load): Move to w32.c.
5200
5201 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5202
5203 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5204 (w32_delayed_load): Move from image.c. When loading a library, record
5205 its filename in the :loaded-from property of the library id.
5206 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5207 Initialize and staticpro them.
5208 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5209
5210 * process.c: Include lisp.h before w32.h, not after.
5211 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5212 instead of gnutls_record_check_pending.
5213
5214 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5215
5216 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5217
5218 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5219 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5220 as passed in.
5221
5222 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5223
5224 * xterm.c (x_set_frame_alpha): Do not set property on anything
5225 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5226
5227 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
5228
5229 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5230
5231 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
5232
5233 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5234 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5235 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5236 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5237 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5238 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5239 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5240 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5241 (Qgnutls_bootprop_callbacks_verify): Make static.
5242
5243 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5244
5245 * callproc.c: Indentation fixup.
5246
5247 * sysdep.c (wait_for_termination_1): Make static.
5248 (wait_for_termination, interruptible_wait_for_termination):
5249 Move after wait_for_termination_1.
5250
5251 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5252
5253 * sysdep.c (interruptible_wait_for_termination): New function
5254 which is like wait_for_termination, but allows keyboard
5255 interruptions.
5256
5257 * callproc.c (Fcall_process): Add (:file "file") as an option for
5258 the STDOUT buffer.
5259 (Fcall_process_region): Ditto.
5260
5261 2011-04-30 Eli Zaretskii <eliz@gnu.org>
5262
5263 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5264 rather than `XVECTOR (FOO)->size'.
5265
5266 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5267 inttypes.h, as a gnulib replacement is used if it not available in
5268 system headers.
5269
5270 2011-04-21 Eli Zaretskii <eliz@gnu.org>
5271
5272 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5273 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5274 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5275
5276 * coding.c (coding_alloc_by_realloc): Error out if destination
5277 will grow beyond MOST_POSITIVE_FIXNUM.
5278 (decode_coding_emacs_mule): Abort if there isn't enough place in
5279 charbuf for the composition carryover bytes. Reserve an extra
5280 space for up to 2 characters produced in a loop.
5281 (decode_coding_iso_2022): Abort if there isn't enough place in
5282 charbuf for the composition carryover bytes.
5283
5284 2011-04-21 Eli Zaretskii <eliz@gnu.org>
5285
5286 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5287 aborting when %lld or %lll format is passed.
5288 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5289 %llo or %llx format is passed. (Bug#8545)
5290
5291 * window.c (window_scroll_line_based): Use a marker instead of
5292 simple variables to record original value of point. (Bug#7952)
5293
5294 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5295 produced by %s or %c overflows available buffer space. (Bug#8545)
5296
5297 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5298
5299 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
5300 (SIZE_MAX): Move defn after all includes, as they might #define it.
5301
5302 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5303
5304 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5305
5306 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5307
5308 * keyboard.c (Qdelayed_warnings_hook): Define.
5309 (command_loop_1): Run `delayed-warnings-hook'
5310 if Vdelayed_warnings_list is non-nil.
5311 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5312 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5313
5314 2011-04-28 Eli Zaretskii <eliz@gnu.org>
5315
5316 * doprnt.c (doprnt): Don't return value smaller than the buffer
5317 size if the message was truncated. (Bug#8545).
5318
5319 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
5320
5321 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5322 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5323
5324 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5325
5326 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5327
5328 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
5329
5330 * makefile.w32-in: Update dependencies.
5331
5332 2011-04-27 Eli Zaretskii <eliz@gnu.org>
5333
5334 Improve `doprnt' and its usage. (Bug#8545)
5335 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5336 `format_end'. Remove support for %l as a conversion specifier.
5337 Don't use xrealloc. Improve diagnostics when the %l size modifier
5338 is used. Update the commentary.
5339
5340 * eval.c (verror): Simplify calculation of size_t.
5341
5342 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5343 messages.
5344
5345 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5346
5347 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5348 change.
5349
5350 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5351
5352 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5353 This makes this file independent of the recent pseudovector change.
5354
5355 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
5356
5357 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5358
5359 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
5360 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
5361 Remove unused local.
5362 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
5363
5364 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
5365 GCC 4.6.0 optimizes based on type-based alias analysis.
5366 For example, if b is of type struct buffer * and v of type struct
5367 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5368 != &v->size, and therefore "v->size = 1; b->size = 2; return
5369 v->size;" must therefore return 1. This assumption is incorrect
5370 for Emacs, since it type-puns struct Lisp_Vector * with many other
5371 types. To fix this problem, this patch adds a new type struct
5372 vectorlike_header that documents the constraints on layout of vectors
5373 and pseudovectors, and helps optimizing compilers not get fooled
5374 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5375 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
5376 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5377 the size member.
5378 (XSETPVECTYPE): Rewrite in terms of new macro.
5379 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5380 This is a bit clearer, and further avoids the possibility of
5381 undesirable aliasing.
5382 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
5383 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
5384 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5385 since Lisp_Subr is a special case (no "next" field).
5386 (ASIZE): Now uses header.size rather than size.
5387 All previous uses of XVECTOR (foo)->size replaced to use this macro,
5388 to avoid the hassle of writing XVECTOR (foo)->header.size.
5389 (struct vectorlike_header): New type.
5390 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5391 object, to help avoid aliasing.
5392 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5393 (SUBRP): Likewise, since Lisp_Subr is a special case.
5394 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5395 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5396 (struct Lisp_Hash_Table): Combine first two members into a single
5397 struct vectorlike_header member. All uses of "size" and "next" members
5398 changed to be "header.size" and "header.next".
5399 * buffer.h (struct buffer): Likewise.
5400 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5401 * frame.h (struct frame): Likewise.
5402 * process.h (struct Lisp_Process): Likewise.
5403 * termhooks.h (struct terminal): Likewise.
5404 * window.c (struct save_window_data, struct saved_window): Likewise.
5405 * window.h (struct window): Likewise.
5406 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5407 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5408 * buffer.c (init_buffer_once): Likewise.
5409 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5410 special case.
5411 * process.c (Fformat_network_address): Use local var for size,
5412 for brevity.
5413
5414 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
5415
5416 Make the Lisp reader and string-to-float more consistent (Bug#8525)
5417 * data.c (atof): Remove decl; no longer used or needed.
5418 (digit_to_number): Move to lread.c.
5419 (Fstring_to_number): Use new string_to_number function, to be
5420 consistent with how the Lisp reader treats infinities and NaNs.
5421 Do not assume that floating-point numbers represent EMACS_INT
5422 without losing information; this is not true on most 64-bit hosts.
5423 Avoid double-rounding errors, by insisting on integers when
5424 parsing non-base-10 numbers, as the documentation specifies.
5425 * lisp.h (string_to_number): New decl, replacing ...
5426 (isfloat_string): Remove.
5427 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
5428 (read1): Do not accept +. and -. as integers; this
5429 appears to have been a coding error. Similarly, do not accept
5430 strings like +-1e0 as floating point numbers. Do not report
5431 overflow for integer overflows unless the base is not 10 which
5432 means we have no simple and reliable way to continue.
5433 Break out the floating-point parsing into a new
5434 function string_to_number, so that Fstring_to_number parses
5435 floating point numbers consistently with the Lisp reader.
5436 (digit_to_number): Move here from data.c. Make it static inline.
5437 (E_CHAR, EXP_INT): Remove, replacing with ...
5438 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
5439 (string_to_number): New function, replacing isfloat_string.
5440 This function checks for valid syntax and produces the resulting
5441 Lisp float number too. Rework it so that string-to-number
5442 no longer mishandles examples like "1.0e+". Use strtoumax,
5443 so that overflow for non-base-10 numbers is reported only when
5444 there's no portable and simple way to convert to floating point.
5445
5446 * textprop.c (set_text_properties_1): Rewrite for clarity,
5447 and to avoid GCC warning about integer overflow.
5448
5449 * intervals.h (struct interval): Use EMACS_INT for members
5450 where EMACS_UINT might cause problems. See
5451 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
5452 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
5453 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
5454 All uses changed.
5455 (offset_intervals): Tell GCC not to worry about length overflow
5456 when negating a negative length.
5457
5458 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
5459 (overrun_check_free): Likewise.
5460
5461 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
5462 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
5463 word size.
5464
5465 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5466 (gnutls_make_error): Rename local to avoid shadowing.
5467 (gnutls_emacs_global_deinit): ifdef out; not used.
5468 (Fgnutls_boot): Use const for pointer to readonly storage.
5469 Comment out unused local. Fix pointer signedness problems.
5470
5471 * lread.c (openp): Don't stuff size_t into an 'int'.
5472 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
5473 about possible signed overflow.
5474
5475 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
5476 (GDK_KEY_g): Don't define if already defined.
5477 (xg_prepare_tooltip): Avoid pointer signedness problem.
5478 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
5479
5480 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
5481 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
5482
5483 * xfns.c (Fx_window_property): Simplify a bit,
5484 to make a bit faster and to avoid GCC 4.6.0 warning.
5485 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
5486
5487 * fns.c (internal_equal): Don't assume size_t fits in int.
5488
5489 * alloc.c (compact_small_strings): Tighten assertion a little.
5490
5491 Replace pEd with more-general pI, and fix some printf arg casts.
5492 * lisp.h (pI): New macro, generalizing old pEd macro to other
5493 conversion specifiers. For example, use "...%"pI"d..." rather
5494 than "...%"pEd"...".
5495 (pEd): Remove. All uses replaced with similar uses of pI.
5496 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
5497 * alloc.c (check_pure_size): Don't overflow by converting size to int.
5498 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
5499 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
5500 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
5501 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
5502 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
5503 64-bit hosts.
5504 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
5505 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
5506 * print.c (safe_debug_print, print_object): Likewise.
5507 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
5508 to int.
5509 Use pI instead of if-then-else-abort. Use %p to avoid casts,
5510 avoiding the 0 flag, which is not portable.
5511 * process.c (Fmake_network_process): Use pI to avoid cast.
5512 * region-cache.c (pp_cache): Likewise.
5513 * xdisp.c (decode_mode_spec): Likewise.
5514 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
5515 behavior on 64-bit hosts with printf arg.
5516 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
5517 (x_stop_queuing_selection_requests): Likewise.
5518 (x_get_window_property): Don't truncate byte count to an 'int'
5519 when tracing.
5520
5521 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
5522 here, since it parses constructs like leading '-' and spaces,
5523 which are not wanted; and it overflows with large numbers.
5524 Instead, simply match F[0-9]+, which is what is wanted anyway.
5525
5526 * alloc.c: Remove unportable assumptions about struct layout.
5527 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
5528 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
5529 (allocate_vectorlike, make_pure_vector): Use the new macros,
5530 plus offsetof, to remove unportable assumptions about struct layout.
5531 These assumptions hold on all porting targets that I know of, but
5532 they are not guaranteed, they're easy to remove, and removing them
5533 makes further changes easier.
5534
5535 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5536 This doesn't fix a bug but makes the code clearer.
5537 (string_overrun_cookie): Now const. Use initializers that
5538 don't formally overflow signed char, to avoid warnings.
5539 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5540 can cause Emacs to crash when string overrun checking is enabled.
5541 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5542 multiple of sizeof (EMACS_INT); it need not be, if
5543 alignof(EMACS_INT) < sizeof (EMACS_INT).
5544 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
5545
5546 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
5547
5548 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5549
5550 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5551
5552 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
5553 supposed to be handshaking. (Bug#8556)
5554 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5555
5556 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
5557
5558 * lisp.h (Qdebug): List symbol.
5559 * eval.c (Qdebug): Restore global linkage.
5560 * keyboard.c (debug-on-event): New variable.
5561 (handle_user_signal): Break into debugger when debug-on-event
5562 matches the current signal symbol.
5563
5564 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5565
5566 * alloc.c (check_sblock, check_string_bytes)
5567 (check_string_free_list): Convert to standard C.
5568
5569 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5570
5571 * w32.c (emacs_gnutls_push): Fix typo.
5572
5573 2011-04-25 Eli Zaretskii <eliz@gnu.org>
5574
5575 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5576 "cast to pointer from integer of different size".
5577
5578 Improve doprnt and its use in verror. (Bug#8545)
5579 * doprnt.c (doprnt): Document the set of format control sequences
5580 supported by the function. Use SAFE_ALLOCA instead of always
5581 using `alloca'.
5582
5583 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5584 is one byte too soon. Don't use xrealloc; instead xfree and
5585 xmalloc anew.
5586
5587 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5588
5589 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5590 callbacks stage.
5591
5592 * gnutls.c: Renamed global_initialized to
5593 gnutls_global_initialized. Added internals for the
5594 :verify-hostname-error, :verify-error, and :verify-flags
5595 parameters of `gnutls-boot' and documented those parameters in the
5596 docstring. Start callback support.
5597 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5598 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5599 on error. Return error code.
5600 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5601 (emacs_gnutls_read): Likewise.
5602 (Fgnutls_boot): Return handshake error code.
5603 (emacs_gnutls_handle_error): New function.
5604 (wsaerror_to_errno): Likewise.
5605
5606 * w32.h (emacs_gnutls_pull): Add prototype.
5607 (emacs_gnutls_push): Likewise.
5608
5609 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5610 (emacs_gnutls_push): Likewise.
5611
5612 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5613
5614 * process.c (wait_reading_process_output): Check if GnuTLS
5615 buffered some data internally if no FDs are set for TLS
5616 connections.
5617
5618 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5619 (LIBS): Link to USER_LIBS.
5620 ($(BLD)/gnutls.$(0)): New target.
5621
5622 2011-04-24 Eli Zaretskii <eliz@gnu.org>
5623
5624 * xdisp.c (handle_single_display_spec): Rename the
5625 display_replaced_before_p argument into display_replaced_p, to
5626 make it consistent with the commentary. Fix typos in the
5627 commentary.
5628
5629 * textprop.c (syms_of_textprop): Remove dead code.
5630 (copy_text_properties): Delete obsolete commentary about an
5631 interface that was deleted long ago. Fix typos in the description
5632 of arguments.
5633
5634 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5635 to changes in oldXMenu/XMenu.h from 2011-04-16.
5636 <menu_help_message, prev_menu_help_message>: Constify.
5637 (IT_menu_make_room): menu->help_text is now `const char **';
5638 adjust.
5639
5640 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5641 to changes in oldXMenu/XMenu.h from 2011-04-16.
5642 (struct XMenu): Declare `help_text' `const char **'.
5643
5644 * xfaces.c <Qunspecified>: Make extern again.
5645
5646 * syntax.c: Include sys/types.h before including regex.h, as
5647 required by Posix.
5648
5649 * doc.c (get_doc_string): Improve the format passed to `error'.
5650
5651 * doprnt.c (doprnt): Improve commentary.
5652
5653 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5654
5655 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5656 them with etags.
5657
5658 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5659 changes in globals.h immediately force recompilation.
5660 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5661 $(CURDIR)/s/ms-w32.h.
5662 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
5663
5664 * character.c (Fchar_direction): Function deleted.
5665 (syms_of_character): Don't defsubr it.
5666 <char-direction-table>: Deleted.
5667
5668 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5669
5670 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5671 * doprnt.c: Include limits.h.
5672 (SIZE_MAX): New macro.
5673 (doprnt): Return a size_t value. 2nd arg is now size_t.
5674 Many local variables are now size_t instead of int or unsigned.
5675 Improve overflow protection. Support `l' modifier for integer
5676 conversions. Support %l conversion. Don't assume an EMACS_INT
5677 argument for integer conversions and for %c.
5678
5679 * lisp.h (doprnt): Restore prototype.
5680
5681 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5682 $(SRC)/character.h.
5683
5684 * Makefile.in (base_obj): Add back doprnt.o.
5685
5686 * deps.mk (doprnt.o): Add back prerequisites.
5687 (callint.o): Depend on character.h.
5688
5689 * eval.c (internal_lisp_condition_case): Include the handler
5690 representation in the error message.
5691 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5692 when breaking from the loop.
5693
5694 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5695
5696 * callint.c (Fcall_interactively): When displaying error message
5697 about invalid control letter, pass the character's codepoint, not
5698 a pointer to its multibyte form. Improve display of the character
5699 in octal and display also its hex code.
5700
5701 * character.c (char_string): Use %x to display the (unsigned)
5702 codepoint of an invalid character, to avoid displaying a bogus
5703 negative value.
5704
5705 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5706 `error', not SYMBOL_NAME itself.
5707
5708 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5709 character arguments to `error'.
5710
5711 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5712 to `error' in error message about FINAL_CHAR argument. Make sure
5713 FINAL_CHAR is a character, and use %c when it is passed as
5714 argument to `error'.
5715
5716 2011-04-23 Eli Zaretskii <eliz@gnu.org>
5717
5718 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5719
5720 * w32.c: Include <time.h>.
5721 (sys_localtime): New function.
5722
5723 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
5724
5725 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5726
5727 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
5728
5729 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
5730
5731 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5732 zombies (Bug#8467).
5733
5734 2011-04-19 Eli Zaretskii <eliz@gnu.org>
5735
5736 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5737 gl_state.e_property when gl_state.object is Qt.
5738
5739 * insdel.c (make_gap_larger): Remove limitation of buffer size
5740 to <= INT_MAX.
5741
5742 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
5743
5744 * xdisp.c (lookup_glyphless_char_display)
5745 (produce_glyphless_glyph): Handle cons cell entry in
5746 glyphless-char-display.
5747 (Vglyphless_char_display): Document it.
5748
5749 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5750 glyphless-char-display.
5751
5752 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
5753
5754 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5755
5756 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5757
5758 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5759 definition for no-X builds.
5760
5761 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
5762
5763 Static checks with GCC 4.6.0 and non-default toolkits.
5764
5765 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5766
5767 * process.c (keyboard_bit_set): Define only if SIGIO.
5768 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5769 (send_process): Repair possible setjmp clobbering.
5770
5771 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5772
5773 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5774
5775 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5776
5777 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5778 Define only if needed.
5779
5780 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5781 by pacifying GCC about it. Maybe it's time to retire it?
5782 * xfaces.c (USG, __TIMEVAL__): Likewise.
5783
5784 * dispextern.h (struct redisplay_interface): Rename param
5785 to avoid shadowing.
5786 * termhooks.h (struct terminal): Likewise.
5787 * xterm.c (xembed_send_message): Likewise.
5788
5789 * insdel.c (make_gap_smaller): Define only if
5790 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5791
5792 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5793 it.
5794
5795 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5796 so that we aren't warned about unused symbols.
5797
5798 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5799
5800 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
5801
5802 * xfns.c (x_real_positions): Mark locals as initialized.
5803
5804 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5805
5806 * xterm.c: Fix problems found by static analysis with other toolkits.
5807 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
5808 (x_dispatch_event): Declare static if USE_GTK, and
5809 define if USE_GTK || USE_X_TOOLKIT.
5810 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
5811 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
5812 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5813 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
5814
5815 * xmenu.c (menu_help_callback): Pointer type fixes.
5816 Use const pointers when pointing at readonly data. Avoid pointer
5817 signedness clashes.
5818 (FALSE): Remove unused macro.
5819 (update_frame_menubar): Remove unused decl.
5820
5821 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5822
5823 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5824 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5825 (single_menu_item): Rename local to avoid shadowing.
5826
5827 * keyboard.c (make_lispy_event): Remove unused local var.
5828
5829 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5830 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5831
5832 * bitmaps: Change bitmaps from unsigned char back to the X11
5833 compatible char. Avoid the old compiler warnings about
5834 out-of-range initializers by using, for example, '\xab' rather
5835 than 0xab.
5836
5837 * xgselect.c (xgselect_initialize): Check vs interface
5838 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5839
5840 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5841
5842 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5843 to read-only memory.
5844
5845 * fns.c (vector): Remove; this old hack is no longer needed.
5846
5847 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
5848 Remove unused var.
5849 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
5850
5851 * xrdb.c (x_load_resources): Omit unused local.
5852
5853 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
5854 (x_window): Rename locals to avoid shadowing.
5855 (USG): Use the kludged USG macro, to pacify gcc.
5856
5857 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
5858 (x_term_init): Remove local to avoid shadowing.
5859
5860 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
5861
5862 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5863 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5864
5865 2011-04-16 Eli Zaretskii <eliz@gnu.org>
5866
5867 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5868
5869 Fix regex.c, syntax.c and friends for buffers > 2GB.
5870 * syntax.h (struct gl_state_s): Declare character position members
5871 EMACS_INT.
5872
5873 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5874
5875 * textprop.c (verify_interval_modification, interval_of):
5876 Declare arguments EMACS_INT.
5877
5878 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5879 EMACS_INT.
5880
5881 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5882
5883 * indent.c (Fvertical_motion): Local variable it_start is now
5884 EMACS_INT.
5885
5886 * regex.c (re_match, re_match_2, re_match_2_internal)
5887 (bcmp_translate, regcomp, regexec, print_double_string)
5888 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5889 (re_compile_pattern, re_exec): Declare arguments and local
5890 variables `size_t' and `ssize_t' and return values `regoff_t', as
5891 appropriate.
5892 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5893 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5894 <compile_stack_type>: `size' and `avail' are now `size_t'.
5895
5896 * regex.h <regoff_t>: Use ssize_t, not int.
5897 (re_search, re_search_2, re_match, re_match_2): Arguments that
5898 specify buffer/string position and length are now ssize_t and
5899 size_t. Return type is regoff_t.
5900
5901 2011-04-16 Ben Key <bkey76@gmail.com>
5902
5903 * nsfont.m: Fixed bugs in ns_get_family and
5904 ns_descriptor_to_entity that were caused by using free to
5905 deallocate memory blocks that were allocated by xmalloc (via
5906 xstrdup). This caused Emacs to crash when compiled with
5907 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5908 --enable-checking=xmallocoverrun). xfree is now used to
5909 deallocate these memory blocks.
5910
5911 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
5912
5913 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5914
5915 emacs_write: Accept and return EMACS_INT for sizes.
5916 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5917 et seq.
5918 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5919 Accept and return EMACS_INT.
5920 (emacs_gnutls_write): Return the number of bytes written on
5921 partial writes.
5922 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
5923 (emacs_read, emacs_write): Remove check for negative size, as the
5924 Emacs source code has been audited now.
5925 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5926 (emacs_read, emacs_write): Use it.
5927 * process.c (send_process): Adjust to the new signatures of
5928 emacs_write and emacs_gnutls_write. Do not attempt to store
5929 a byte offset into an 'int'; it might overflow.
5930 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
5931
5932 * sound.c: Don't assume sizes fit in 'int'.
5933 (struct sound_device.period_size, alsa_period_size):
5934 Return EMACS_INT, not int.
5935 (struct sound_device.write, vox_write, alsa_write):
5936 Accept EMACS_INT, not int.
5937 (wav_play, au_play): Use EMACS_INT to store sizes and to
5938 record read return values.
5939
5940 2011-04-15 Ben Key <bkey76@gmail.com>
5941
5942 * keyboard.c (Qundefined): Don't declare static since it is used
5943 in nsfns.m.
5944 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5945 static since they are used in nsfont.m.
5946
5947 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5948
5949 * process.c (Qprocessp): Don't declare static.
5950 * lisp.h (Qprocessp): Declare again.
5951
5952 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
5953
5954 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5955
5956 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5957
5958 Improve C-level modularity by making more things 'static'.
5959
5960 Don't publish debugger-only interfaces to other modules.
5961 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5962 (verify_bytepos, count_markers): Move decls to the only modules
5963 that need them.
5964 * region-cache.h (pp_cache): Likewise.
5965 * window.h (check_all_windows): Likewise.
5966 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5967
5968 * sysdep.c (croak): Now static, if
5969 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5970 * syssignal.h (croak): Declare only if not static.
5971
5972 * alloc.c (refill_memory_reserve): Now static if
5973 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5974 * lisp.h (refill_memory_reserve): Declare only if not static.
5975
5976 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5977 Define only if USE_LUCID.
5978
5979 * xrdb.c (x_customization_string, x_rm_string): Now static.
5980
5981 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5982 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5983
5984 * xdisp.c (draw_row_with_mouse_face): Now static.
5985 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5986
5987 * window.h (check_all_windows): Mark externally visible.
5988
5989 * window.c (window_deletion_count): Now static.
5990
5991 * undo.c: Make symbols static if they're not exported.
5992 (last_undo_buffer, last_boundary_position, pending_boundary):
5993 Now static.
5994
5995 * textprop.c (interval_insert_behind_hooks): Now static.
5996 (interval_insert_in_front_hooks): Likewise.
5997
5998 * term.c: Make symbols static if they're not exported.
5999 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6000 (max_frame_lines, tty_set_terminal_modes):
6001 (tty_reset_terminal_modes, tty_turn_off_highlight):
6002 (get_tty_terminal): Now static.
6003 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6004 * termhooks.h (term_mouse_moveto): Do not declare if
6005 HAVE_WINDOW_SYSTEM.
6006 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6007 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6008
6009 * sysdep.c: Make symbols static if they're not exported.
6010 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6011 Now static.
6012 (sigprocmask_set, full_mask): Remove; unused.
6013 (wait_debugging): Mark as visible.
6014 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6015 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6016
6017 * syntax.c (syntax_temp): Define only if !__GNUC__.
6018
6019 * sound.c (current_sound_device, current_sound): Now static.
6020
6021 * search.c (searchbufs, searchbuf_head): Now static.
6022
6023 * scroll.c (scroll_cost): Remove; unused.
6024 * dispextern.h (scroll_cost): Remove decl.
6025
6026 * region-cache.h (pp_cache): Mark as externally visible.
6027
6028 * process.c: Make symbols static if they're not exported.
6029 (process_tick, update_tick, create_process, chan_process):
6030 (Vprocess_alist, proc_buffered_char, datagram_access):
6031 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6032 (deactivate_process): Mark defn as static, as well as decl.
6033 * lisp.h (create_process): Remove decl.
6034 * process.h (chan_process, Vprocess_alist): Remove decls.
6035
6036 * print.c: Make symbols static if they're not exported.
6037 (print_depth, new_backquote_output, being_printed, print_buffer):
6038 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6039 (print_interval, print_number_index, initial_stderr_stream):
6040 Now static.
6041 * lisp.h (Fprinc): Remove decl.
6042 (debug_output_compilation_hack): Mark as externally visible.
6043
6044 * sysdep.c (croak): Move decl from here to syssignal.h.
6045 * syssignal.h (croak): Put it here, so the API can be checked when
6046 'croak' is called from dissociate_if_controlling_tty.
6047
6048 * minibuf.c: Make symbols static if they're not exported.
6049 (minibuf_save_list, choose_minibuf_frame): Now static.
6050 * lisp.h (choose_minibuf_frame): Remove decl.
6051
6052 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6053
6054 * lread.c: Make symbols static if they're not exported.
6055 (read_objects, initial_obarray, oblookup_last_bucket_number):
6056 Now static.
6057 (make_symbol): Remove; unused.
6058 * lisp.h (initial_obarray, make_symbol): Remove decls.
6059
6060 * keyboard.c: Make symbols static if they're not exported.
6061 (single_kboard, recent_keys_index, total_keys, recent_keys):
6062 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6063 (this_single_command_key_start, echoing, last_auto_save):
6064 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6065 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6066 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6067 (Vlispy_mouse_stem, double_click_count):
6068 Now static.
6069 (force_auto_save_soon): Define only if SIGDANGER.
6070 (ignore_mouse_drag_p): Now static if
6071 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6072 (print_help): Remove; unused.
6073 (stop_character, last_timer_event): Mark as externally visible.
6074 * keyboard.h (ignore_mouse_drag_p): Declare only if
6075 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6076 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6077 * lisp.h (echoing): Remove decl.
6078 (force_auto_save_soon): Declare only if SIGDANGER.
6079 * xdisp.c (redisplay_window): Simplify code, to make it more
6080 obvious that ignore_mouse_drag_p is not accessed if !defined
6081 USE_GTK && !defined HAVE_NS.
6082
6083 * intervals.c: Make symbols static if they're not exported.
6084 (merge_properties_sticky, merge_interval_right, delete_interval):
6085 Now static.
6086 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6087
6088 * insdel.c: Make symbols static if they're not exported.
6089 However, leave prepare_to_modify_buffer alone. It's never
6090 called from outside this function, but that appears to be a bug.
6091 (combine_after_change_list, combine_after_change_buffer):
6092 (adjust_after_replace, signal_before_change): Now static.
6093 (adjust_after_replace_noundo): Remove; unused.
6094 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
6095 (signal_before_change): Remove decls.
6096
6097 * indent.c (val_compute_motion, val_vmotion): Now static.
6098
6099 * image.c: Make symbols static if they're not exported.
6100 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6101 if USE_GTK.
6102 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6103 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6104
6105 * fringe.c (standard_bitmaps): Now static.
6106 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6107
6108 * frame.c: Make symbols static if they're not exported.
6109 (x_report_frame_params, make_terminal_frame): Now static.
6110 (get_frame_param): Now static, unless HAVE_NS.
6111 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6112 (x_get_resource_string): Remove; not used.
6113 * frame.h (make_terminal_frame, x_report_frame_params):
6114 (x_get_resource_string); Remove decls.
6115 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6116 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6117
6118 * font.c, fontset.c: Make symbols static if they're not exported.
6119 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6120 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6121 * font.c (font_close_object): Now static.
6122 * font.h (font_close_object): Remove.
6123 * fontset.c (FONTSET_OBJLIST): Remove.
6124 (free_realized_fontset) #if-0 the body, which does nothing.
6125 (face_suitable_for_char_p): #if-0, as it's never called.
6126 * fontset.h (face_suitable_for_char_p): Remove decl.
6127 * xfaces.c (face_at_string_position):
6128 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
6129 since 0 is always ASCII.
6130
6131 * fns.c (weak_hash_tables): Now static.
6132
6133 * fileio.c: Make symbols static if they're not exported.
6134 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6135 (Vwrite_region_annotation_buffers): Now static.
6136
6137 * eval.c: Make symbols static if they're not exported.
6138 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6139 * lisp.h (backtrace_list): Remove decl.
6140
6141 * emacs.c: Make symbols static if they're not exported.
6142 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6143 (fatal_error_code, fatal_error_signal_hook, standard_args):
6144 Now static.
6145 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6146 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6147 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6148 * lisp.h (fatal_error_signal_hook): Remove decl.
6149 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6150
6151 * editfns.c: Move a (normally-unused) function to its only use.
6152 * editfns.c, lisp.h (get_operating_system_release): Remove.
6153 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6154 worth the hassle of breaking this out.
6155
6156 * xterm.c: Make symbols static if they're not exported.
6157 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6158 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6159 (x_destroy_window, x_delete_display):
6160 Now static.
6161 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6162 (x_mouse_leave): Remove; unused.
6163 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6164 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6165 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6166 Remove decls.
6167 (x_mouse_leave): Declare only if WINDOWSNT.
6168 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6169 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6170 USE_X_TOOLKIT.
6171
6172 * ftxfont.c: Make symbols static if they're not exported.
6173 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6174 HAVE_FREETYPE.
6175 * font.h (ftxfont_driver): Likewise.
6176
6177 * xfns.c: Make symbols static if they're not exported.
6178 (x_last_font_name, x_display_info_for_name):
6179 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6180 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6181 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6182 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6183 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6184 (last_show_tip_args): Now static.
6185 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6186 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6187 (x_screen_planes): Remove; unused.
6188 * dispextern.h (x_screen_planes): Remove decl.
6189
6190 * dispnew.c: Make symbols static if they're not exported.
6191 * dispextern.h (redraw_garbaged_frames, scrolling):
6192 (increment_row_positions): Remove.
6193 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6194 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6195 Now static.
6196 (redraw_garbaged_frames): Remove; unused.
6197
6198 * xfaces.c: Make symbols static if they're not exported.
6199 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6200 Remove decls.
6201 * xterm.h (defined_color): Remove decls.
6202 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6203 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6204 (menu_face_changed_default, defined_color, free_realized_face):
6205 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6206 (ascii_face_of_lisp_face): Remove; unused.
6207
6208 * xdisp.c: Make symbols static if they're not exported.
6209 * dispextern.h (scratch_glyph_row, window_box_edges):
6210 (glyph_to_pixel_coords, set_cursor_from_row):
6211 (get_next_display_element, set_iterator_to_next):
6212 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6213 (show_mouse_face): Remove decls
6214 * frame.h (message_buf_print): Likewise.
6215 * lisp.h (pop_message, set_message, check_point_in_composition):
6216 Likewise.
6217 * xterm.h (set_vertical_scroll_bar): Likewise.
6218 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6219 (message_buf_print, scratch_glyph_row, displayed_buffer):
6220 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6221 (get_next_display_element, show_mouse_face, window_box_edges):
6222 (frame_to_window_pixel_xy, check_point_in_composition):
6223 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6224 (glyph_to_pixel_coords): Remove; unused.
6225
6226 * dired.c (file_name_completion): Now static.
6227
6228 * dbusbind.c (xd_in_read_queued_messages): Now static.
6229
6230 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6231 * data.c (circular_list_error): Remove.
6232
6233 * commands.h (last_point_position, last_point_position_buffer):
6234 (last_point_position_window): Remove decls.
6235 * keyboard.c: Make these variables static.
6236
6237 * coding.h (coding, code_convert_region, encode_coding_gap):
6238 Remove decls.
6239 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6240 (iso_code_class, detect_coding, code_convert_region): Now static.
6241 (encode_coding_gap): Remove; unused.
6242
6243 * chartab.c (chartab_chars, chartab_bits): Now static.
6244
6245 * charset.h (charset_iso_8859_1): Remove decl.
6246 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6247 Now static.
6248
6249 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6250 * ccl.c (Vccl_program_table): Now static.
6251 (check_ccl_update): Remove; unused.
6252
6253 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6254 * category.h: ... from here.
6255 * category.c (check_category_table, set_category_set): Now static.
6256
6257 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6258 * lisp.h: Remove these decls.
6259
6260 * buffer.c (buffer_count): Remove unused var.
6261
6262 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6263 so that it's not optimized away.
6264 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6265 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6266 exported only to the debugger.
6267
6268 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
6269 * atimer.h (run_all_atimers): Remove; not exported.
6270
6271 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6272 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6273 was inaccessible from Lisp.
6274 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6275 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6276
6277 alloc.c: Import and export fewer symbols, and remove unused items.
6278 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6279 is defined.
6280 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6281 it's not optimized away by whole-program optimization.
6282 (message_enable_multibyte, free_misc): Remove.
6283 (catchlist, handlerlist, mark_backtrace):
6284 Declare only if BYTE_MARK_STACK.
6285 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6286 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6287 (message_enable_multibyte): Remove decl.
6288 (free_misc, interval_free_list, float_block, float_block_index):
6289 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6290 (cons_free_list, last_marked_index):
6291 Now static.
6292 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6293 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6294 (mark_backtrace): Define only if BYTE_MARK_STACK.
6295 * xdisp.c (message_enable_multibyte): Now static.
6296
6297 Declare Lisp_Object Q* variables to be 'static' if not exported.
6298 This makes it easier for human readers (and static analyzers)
6299 to see whether these variables are used from other modules.
6300 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6301 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6302 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6303 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6304 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6305 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6306 * xmenu.c, xselect.c:
6307 Declare Q* vars static if they are not used in other modules.
6308 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6309 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6310 Remove decls of unexported vars.
6311 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6312
6313 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6314
6315 Make Emacs functions such as Fatom 'static' by default.
6316 This makes it easier for human readers (and static analyzers)
6317 to see whether these functions can be called from other modules.
6318 DEFUN now defines a static function. To make the function external
6319 so that it can be used in other C modules, use the new macro DEFUE.
6320 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6321 (Finit_image_library):
6322 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6323 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6324 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6325 Remove decls, since these functions are now static.
6326 (Funintern, Fget_internal_run_time): New decls, since these functions
6327 were already external.
6328
6329 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6330 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6331 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6332 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6333 * keyboard.c, keymap.c, lread.c:
6334 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6335 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6336 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6337 Mark functions with DEFUE instead of DEFUN,
6338 if they are used in other modules.
6339 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6340 decls for now-static functions.
6341 * buffer.h (Fdelete_overlay): Remove decl.
6342 * callproc.c (Fgetenv_internal): Mark as internal.
6343 * composite.c (Fremove_list_of_text_properties): Remove decl.
6344 (Fcomposition_get_gstring): New forward static decl.
6345 * composite.h (Fcomposite_get_gstring): Remove decl.
6346 * dired.c (Ffile_attributes): New forward static decl.
6347 * doc.c (Fdocumntation_property): New forward static decl.
6348 * eval.c (Ffetch_bytecode): New forward static decl.
6349 (Funintern): Remove extern decl; now in .h file where it belongs.
6350 * fileio.c (Fmake_symbolic_link): New forward static decl.
6351 * image.c (Finit_image_library): New forward static decl.
6352 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6353 * intervals.h (Fprevious_property_change):
6354 (Fremove_list_of_text_properties): Remove decls.
6355 * keyboard.c (Fthis_command_keys): Remove decl.
6356 (Fcommand_execute): New forward static decl.
6357 * keymap.c (Flookup_key): New forward static decl.
6358 (Fcopy_keymap): Now static.
6359 * keymap.h (Flookup_key): Remove decl.
6360 * process.c (Fget_process): New forward static decl.
6361 (Fprocess_datagram_address): Mark as internal.
6362 * syntax.c (Fsyntax_table_p): New forward static decl.
6363 (skip_chars): Remove duplicate decl.
6364 * textprop.c (Fprevious_property_change): New forward static decl.
6365 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6366 Now internal.
6367 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6368 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6369
6370 * editfns.c (Fformat): Remove unreachable code.
6371
6372 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6373
6374 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6375 change. (Bug#8496)
6376
6377 2011-04-13 Eli Zaretskii <eliz@gnu.org>
6378
6379 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6380 when at ZV. (Bug#8487)
6381
6382 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6383
6384 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6385 (Bug#8437)
6386 * keyboard.c (parse_tool_bar_item): Likewise.
6387 * sound.c (sound_cleanup, alsa_close): Likewise.
6388 * termcap.c (tgetent): Likewise.
6389 * xfns.c (x_default_font_parameter): Likewise.
6390 * xsettings.c (read_and_apply_settings): Likewise.
6391
6392 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6393 (overrun_check_free): Protoize.
6394
6395 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6396
6397 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6398 since callers should never pass a negative size.
6399 Change the signature to match that of plain 'read' and 'write'; see
6400 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6401 * lisp.h: Update prototypes of emacs_write and emacs_read.
6402
6403 2011-04-11 Eli Zaretskii <eliz@gnu.org>
6404
6405 * xdisp.c (redisplay_window): Don't try to determine the character
6406 position of the scroll margin if the window start point w->startp
6407 is outside the buffer's accessible region. (Bug#8468)
6408
6409 2011-04-10 Eli Zaretskii <eliz@gnu.org>
6410
6411 Fix write-region and its subroutines for buffers > 2GB.
6412 * fileio.c (a_write, e_write): Modify declaration of arguments and
6413 local variables to support buffers larger than 2GB.
6414 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
6415
6416 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
6417 argument, local variables, and return value.
6418
6419 * lisp.h: Update prototypes of emacs_write and emacs_read.
6420
6421 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
6422
6423 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
6424
6425 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
6426
6427 Fix more problems found by GCC 4.6.0's static checks.
6428
6429 * xdisp.c (vmessage): Use a better test for character truncation.
6430
6431 * charset.c (load_charset_map): <, not <=, for optimization,
6432 and to avoid potential problems with integer overflow.
6433 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
6434 * casetab.c (set_identity, shuffle): Likewise.
6435 * editfns.c (Fformat): Likewise.
6436 * syntax.c (skip_chars): Likewise.
6437
6438 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
6439 This also lets GCC 4.6.0 generate slightly better loop code.
6440
6441 * callint.c (Fcall_interactively): <, not <=, for optimization.
6442 (Fcall_interactively): Count the number of arguments produced,
6443 not the number of arguments given. This is simpler and lets GCC
6444 4.6.0 generate slightly better code.
6445
6446 * ftfont.c: Distingish more carefully between FcChar8 and char.
6447 The previous code passed unsigned char * to a functions like
6448 strlen and xstrcasecmp that expect char *, which does not
6449 conform to the C standard.
6450 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
6451 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
6452 char * when the C standard requires it.
6453
6454 * keyboard.c (read_char): Remove unused var.
6455
6456 * eval.c: Port to Windows vsnprintf (Bug#8435).
6457 Include <limits.h>.
6458 (SIZE_MAX): Define if the headers do not.
6459 (verror): Do not give up if vsnprintf returns a negative count.
6460 Instead, grow the buffer. This ports to Windows vsnprintf, which
6461 does not conform to C99. Problem reported by Eli Zaretskii.
6462 Also, simplify the allocation scheme, by avoiding the need for
6463 calling realloc, and removing the ALLOCATED variable.
6464
6465 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
6466
6467 Remove invocations of doprnt, as Emacs now uses vsnprintf.
6468 But keep the doprint source code for now, as we might revamp it
6469 and use it again (Bug#8435).
6470 * lisp.h (doprnt): Remove.
6471 * Makefile.in (base_obj): Remove doprnt.o.
6472 * deps.mk (doprnt.o): Remove.
6473
6474 error: Print 32- and 64-bit integers portably (Bug#8435).
6475 Without this change, on typical 64-bit hosts error ("...%d...", N)
6476 was used to print both 32- and 64-bit integers N, which relied on
6477 undefined behavior.
6478 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
6479 New macro.
6480 * lisp.h (error, verror): Mark as printf-like functions.
6481 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
6482 Report overflow in size calculations when allocating printf buffer.
6483 Do not truncate output string at its first null byte.
6484 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
6485 Truncate the output at a character boundary, since vsnprintf does not
6486 do that.
6487 * charset.c (check_iso_charset_parameter): Convert internal
6488 character to string before calling 'error', since %c now has the
6489 printf meaning.
6490 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
6491 overflow when computing char to be passed to 'error'. Do not
6492 pass Lisp_Object to 'error'; pass the integer instead.
6493 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
6494 formatted with plain %d.
6495
6496 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
6497
6498 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
6499
6500 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
6501
6502 * xterm.c (x_catch_errors): Remove duplicate declaration.
6503
6504 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
6505
6506 * xdisp.c, lisp.h (message_nolog): Remove; unused.
6507
6508 2011-04-10 Jim Meyering <meyering@redhat.com>
6509
6510 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
6511 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
6512 return ssize_t not "int", and use size_t as the buffer length.
6513 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
6514 * gnutls.h: Update declarations.
6515 * process.c (read_process_output): Use ssize_t, to match.
6516 (send_process): Likewise.
6517
6518 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6519
6520 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
6521
6522 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
6523
6524 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
6525 Use unsigned char, to match FcChar8 type definition.
6526
6527 * xterm.c (handle_one_xevent):
6528 * xmenu.c (create_and_show_popup_menu):
6529 * xselect.c (x_decline_selection_request)
6530 (x_reply_selection_request): Avoid type-punned deref of X events.
6531
6532 2011-04-09 Eli Zaretskii <eliz@gnu.org>
6533
6534 Fix some uses of `int' instead of EMACS_INT.
6535 * search.c (string_match_1, fast_string_match)
6536 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6537 (scan_buffer, find_next_newline_no_quit)
6538 (find_before_next_newline, search_command, Freplace_match)
6539 (Fmatch_data): Make some `int' variables be EMACS_INT.
6540
6541 * xdisp.c (display_count_lines): 3rd argument and return value now
6542 EMACS_INT. All callers changed.
6543 (pint2hrstr): Last argument is now EMACS_INT.
6544
6545 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6546 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6547 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6548 (decode_coding_utf_16, decode_coding_emacs_mule)
6549 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6550 (decode_coding_ccl, decode_coding_charset)
6551 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6552 (decode_coding_iso_2022, decode_coding_emacs_mule)
6553 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6554 <char_offset, last_offset>: Declare EMACS_INT.
6555 (encode_coding_utf_8, encode_coding_utf_16)
6556 (encode_coding_emacs_mule, encode_invocation_designation)
6557 (encode_designation_at_bol, encode_coding_iso_2022)
6558 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6559 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6560 Declare EMACS_INT.
6561 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6562 (encode_invocation_designation): Last argument P_NCHARS is now
6563 EMACS_INT.
6564 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6565 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6566
6567 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6568 All users changed.
6569
6570 * ccl.c (Fccl_execute_on_string): Declare some variables
6571 EMACS_INT.
6572
6573 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
6574
6575 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6576
6577 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6578
6579 * process.c (Fformat_network_address): Doc fix.
6580
6581 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6582
6583 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6584
6585 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
6586
6587 * keyboard.c (read_char): Call Lisp function help-form-show,
6588 instead of using internal_with_output_to_temp_buffer.
6589 (Qhelp_form_show): New var.
6590 (syms_of_keyboard): Use DEFSYM macro.
6591
6592 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6593
6594 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6595
6596 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
6597
6598 * process.c (Flist_processes): Remove to Lisp.
6599 (list_processes_1): Delete.
6600
6601 2011-04-06 Eli Zaretskii <eliz@gnu.org>
6602
6603 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6604
6605 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6606
6607 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
6608
6609 Fix more problems found by GCC 4.6.0's static checks.
6610
6611 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6612
6613 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6614
6615 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
6616
6617 * xdisp.c (vmessage): Mark as a printf-like function.
6618
6619 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6620
6621 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6622
6623 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6624 printf-like functions.
6625 (tiff_load): Add casts to remove these marks before passing them
6626 to system-supplied API.
6627
6628 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6629
6630 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6631 This avoids several warnings with gcc -Wstrict-overflow.
6632 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6633 directly, rather than having caller test rule sign. This avoids
6634 some unnecessary tests.
6635 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6636 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6637 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
6638
6639 * xfont.c (xfont_text_extents): Remove var that was set but not used.
6640 (xfont_open): Avoid unnecessary tests.
6641
6642 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6643
6644 * composite.h, composite.c (composition_gstring_put_cache):
6645 Use EMACS_INT, not int, for length.
6646
6647 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6648 breaking out part of COMPOSITION_DECODE_RULE.
6649 (COMPOSITION_DECODE_RULE): Use it.
6650 * composite.c (get_composition_id): Remove unused local vars,
6651 by using the new macro.
6652
6653 * textprop.c (set_text_properties_1): Change while to do-while,
6654 since the condition is always true at first.
6655
6656 * intervals.c (graft_intervals_into_buffer): Mark var as used.
6657 (interval_deletion_adjustment): Return unsigned value.
6658 All uses changed.
6659
6660 * process.c (list_processes_1, create_pty, read_process_output):
6661 (exec_sentinel): Remove vars that were set but not used.
6662 (create_pty): Remove unnecessary "volatile"s.
6663 (Fnetwork_interface_info): Avoid possibility of int overflow.
6664 (read_process_output): Do adaptive read buffering even if carryover.
6665 (read_process_output): Simplify nbytes computation if buffered.
6666
6667 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6668
6669 * syntax.c (scan_words): Remove var that was set but not used.
6670 (update_syntax_table): Use unsigned instead of int.
6671
6672 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
6673 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
6674 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
6675
6676 * print.c (print_error_message): Avoid int overflow.
6677
6678 * font.c (font_list_entities): Redo for clarity,
6679 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6680
6681 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
6682 (font_score): Avoid potential overflow in diff calculation.
6683
6684 * fns.c (substring_both): Remove var that is set but not used.
6685 (sxhash): Redo loop for clarity and to avoid wraparound warning.
6686
6687 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6688
6689 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6690 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6691 can always succeed if overflow has undefined behavior.
6692
6693 * search.c (boyer_moore, wordify): Remove vars set but not used.
6694 (wordify): Omit three unnecessary tests.
6695
6696 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6697 All callers changed. This avoids the need for an unused var.
6698
6699 * casefiddle.c (casify_region): Remove var that is set but not used.
6700
6701 * dired.c (file_name_completion): Remove var that is set but not used.
6702
6703 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6704
6705 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
6706 (Finsert_file_contents): Remove unnecessary code checking fd.
6707
6708 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6709 Check for integer overflow on size calculations.
6710
6711 * buffer.c (Fprevious_overlay_change): Remove var that is set
6712 but not used.
6713
6714 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6715 Remove vars that are set but not used.
6716 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6717 (timer_check_2): Mark vars as initialized.
6718
6719 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6720
6721 * image.c (lookup_image): Remove var that is set but not used.
6722 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
6723
6724 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6725 that are set but not used.
6726
6727 * xfns.c (make_invisible_cursor): Don't return garbage
6728 if XCreateBitmapFromData fails (Bug#8410).
6729
6730 * xselect.c (x_get_local_selection, x_handle_property_notify):
6731 Remove vars that are set but not used.
6732
6733 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6734 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
6735
6736 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6737 Remove var that is set but not used.
6738 (scroll_bar_windows_size): Now size_t, not int.
6739 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6740 Check for overflow.
6741
6742 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6743 (map_tty_color) [!defined MSDOS]: Likewise.
6744
6745 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6746
6747 * coding.c: Remove vars that are set but not used.
6748 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6749 All callers changed.
6750 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6751 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6752 (decode_coding_charset): Remove vars that are set but not used.
6753
6754 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6755 that is set but not used.
6756
6757 * print.c (print_object): Remove var that is set but not used.
6758
6759 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
6760 The gnulib version avoids calling malloc in the usual case,
6761 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6762 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6763 * filelock.c (current_lock_owner): Likewise.
6764 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6765 * sysdep.c: Include allocator.h, careadlinkat.h.
6766 (emacs_no_realloc_allocator): New static constant.
6767 (emacs_readlink): New function.
6768 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6769 ../lib/careadlinkat.h.
6770
6771 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6772
6773 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6774 first non-nil return value).
6775
6776 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6777
6778 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6779 if not defined (Bug#8403).
6780
6781 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6782
6783 * xdisp.c (display_count_lines): Remove parameter `start',
6784 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6785 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6786 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6787 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6788 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6789 and thereabouts. All callers changed.
6790 (get_per_char_metric): Remove parameter `f', unused since
6791 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6792
6793 2011-04-02 Jim Meyering <meyering@redhat.com>
6794
6795 do not dereference NULL upon failed strdup
6796 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6797 (ns_get_family): Likewise.
6798
6799 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
6800
6801 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6802
6803 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6804
6805 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6806 later (Bug#8403).
6807
6808 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6809
6810 Add lexical binding.
6811
6812 * window.c (Ftemp_output_buffer_show): New fun.
6813 (Fsave_window_excursion):
6814 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6815
6816 * lread.c (lisp_file_lexically_bound_p): New function.
6817 (Fload): Bind Qlexical_binding.
6818 (readevalloop): Remove `evalfun' arg.
6819 Bind Qinternal_interpreter_environment.
6820 (Feval_buffer): Bind Qlexical_binding.
6821 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6822 Mark as dynamic.
6823 (syms_of_lread): Declare `lexical-binding'.
6824
6825 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6826
6827 * keyboard.c (eval_dyn): New fun.
6828 (menu_item_eval_property): Use it.
6829
6830 * image.c (parse_image_spec): Use Ffunctionp.
6831
6832 * fns.c (concat, mapcar1): Accept byte-code-functions.
6833
6834 * eval.c (Fsetq): Handle lexical vars.
6835 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6836 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6837 (FletX, Flet): Obey lexical binding.
6838 (Fcommandp): Handle closures.
6839 (Feval): New `lexical' arg.
6840 (eval_sub): New function extracted from Feval. Use it almost
6841 everywhere where Feval was used. Look up vars in lexical env.
6842 Handle closures.
6843 (Ffunctionp): Move from subr.el.
6844 (Ffuncall): Handle closures.
6845 (apply_lambda): Remove `eval_flags'.
6846 (funcall_lambda): Handle closures and new byte-code-functions.
6847 (Fspecial_variable_p): New function.
6848 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6849 but without exporting it to Lisp.
6850
6851 * doc.c (Fdocumentation, store_function_docstring):
6852 * data.c (Finteractive_form): Handle closures.
6853
6854 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6855 interactive spec.
6856
6857 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6858 New byte-codes.
6859 (exec_byte_code): New function extracted from Fbyte_code to handle new
6860 calling convention for byte-code-functions. Add new byte-codes.
6861
6862 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
6863
6864 * alloc.c (Fmake_symbol): Init new `declared_special' field.
6865
6866 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6867
6868 * xdisp.c (redisplay_internal): Fix prototype.
6869
6870 2011-03-31 Eli Zaretskii <eliz@gnu.org>
6871
6872 * xdisp.c (SCROLL_LIMIT): New macro.
6873 (try_scrolling): Use it when setting scroll_limit.
6874 Limit scrolling to 100 screen lines.
6875 (redisplay_window): Even when falling back on "recentering",
6876 position point in the window according to scroll-conservatively,
6877 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6878
6879 (try_scrolling): When point is above the window, allow searching
6880 as far as scroll_max, or one screenful, to compute vertical
6881 distance from PT to the scroll margin position. This prevents
6882 try_scrolling from unnecessarily failing when
6883 scroll-conservatively is set to a value slightly larger than the
6884 window height. Clean up the case of PT below the margin at bottom
6885 of window: scroll_max can no longer be INT_MAX. When aggressive
6886 scrolling is in use, don't let point enter the opposite scroll
6887 margin as result of the scroll.
6888 (syms_of_xdisp) <scroll-conservatively>: Document the
6889 threshold of 100 lines for never-recentering scrolling.
6890
6891 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6892
6893 * dispextern.h (move_it_by_lines):
6894 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6895 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6896 (message_log_check_duplicate): Remove parameters `prev_bol' and
6897 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6898 (redisplay_internal): Remove parameter `preserve_echo_area',
6899 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6900
6901 * indent.c (Fvertical_motion):
6902 * window.c (window_scroll_pixel_based, Frecenter):
6903 Don't pass `need_y_p' to `move_it_by_lines'.
6904
6905 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6906
6907 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6908 steal a few bits to be more compact.
6909 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6910 Remove unneeded casts.
6911
6912 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6913
6914 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6915
6916 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6917 binding" message (bug#7967).
6918
6919 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6920
6921 Fix more problems found by GCC 4.6.0's static checks.
6922
6923 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6924 Remove unused local var.
6925
6926 * editfns.c (Fmessage_box): Remove unused local var.
6927
6928 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6929 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6930 Omit unused local vars.
6931 * window.c (shrink_windows): Omit unused local var.
6932 * menu.c (digest_single_submenu): Omit unused local var.
6933 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6934 Omit unused local var.
6935
6936 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6937 Don't assume string length fits in int.
6938 (keyremap_step, read_key_sequence): Use size_t for sizes.
6939 (read_key_sequence): Don't check last_real_key_start redundantly.
6940
6941 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6942 instead of alloca (Bug#8344).
6943
6944 * eval.c (Fbacktrace): Don't assume nargs fits in int.
6945 (Fbacktrace_frame): Don't assume nframes fits in int.
6946
6947 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6948
6949 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6950 concerns.
6951
6952 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6953
6954 * cm.c (calccost): Turn while-do into do-while, for clarity.
6955
6956 * keyboard.c (syms_of_keyboard): Use the same style as later
6957 in this function when indexing through an array. This also
6958 works around GCC bug 48267.
6959
6960 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6961
6962 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6963
6964 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6965 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6966
6967 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6968 This avoids undefined behavior on integer overflow, and is a bit
6969 more convenient anyway since it is compared to a size_t variable.
6970
6971 Variadic C functions now count arguments with size_t, not int.
6972 This avoids an unnecessary limitation on 64-bit machines, which
6973 caused (substring ...) to crash on large vectors (Bug#8344).
6974 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6975 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
6976 All variadic functions and their callers changed accordingly.
6977 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6978 * data.c (arith_driver, float_arith_driver): Likewise.
6979 * editfns.c (general_insert_function): Likewise.
6980 * eval.c (struct backtrace.nargs, interactive_p)
6981 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6982 (funcall_lambda, mark_backtrace): Likewise.
6983 * fns.c (concat): Likewise.
6984 * frame.c (x_set_frame_parameters): Likewise.
6985 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6986 0 if not found, not -1. All callers changed.
6987
6988 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6989 (stack_copy_size): Now size_t, not int.
6990 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6991
6992 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6993
6994 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6995 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6996 All callers changed.
6997
6998 * lisp.h (multibyte_char_to_unibyte):
6999 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7000 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7001 * character.h (CHAR_TO_BYTE8):
7002 * cmds.c (internal_self_insert):
7003 * editfns.c (general_insert_function):
7004 * keymap.c (push_key_description):
7005 * search.c (Freplace_match):
7006 * xdisp.c (message_dolog, set_message_1): All callers changed.
7007
7008 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7009
7010 * keyboard.c (safe_run_hook_funcall): New function.
7011 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7012 don't set the hook to nil, but remove the offending function instead.
7013 (Qcommand_hook_internal): Remove, unused.
7014 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7015 Vcommand_hook_internal.
7016
7017 * eval.c (enum run_hooks_condition): Remove.
7018 (funcall_nil, funcall_not): New functions.
7019 (run_hook_with_args): Call each function through a `funcall' argument.
7020 Remove `cond' argument, now redundant.
7021 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7022 (Frun_hook_with_args_until_failure): Adjust accordingly.
7023 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7024
7025 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
7026
7027 * dispextern.h (string_buffer_position): Remove declaration.
7028
7029 * print.c (strout): Remove parameter `multibyte', unused since
7030 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7031
7032 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7033 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7034 All callers changed.
7035
7036 * w32.c (_wsa_errlist): Use braces for struct initializers.
7037
7038 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7039 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7040 All callers changed.
7041 (string_buffer_position): Likewise. Also, make static (it's never
7042 used outside xdisp.c).
7043 (cursor_row_p): Remove parameter `w', unused since
7044 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7045 (decode_mode_spec): Remove parameter `precision', introduced during
7046 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7047 All callers changed.
7048
7049 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7050
7051 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7052
7053 2011-03-27 Anders Lindgren <andlind@gmail.com>
7054
7055 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7056 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7057 (ns_update_auto_hide_menu_bar): New functions.
7058 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7059 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7060 ns_constrain_all_frames.
7061 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7062 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7063
7064 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7065
7066 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7067
7068 2011-03-27 Glenn Morris <rgm@gnu.org>
7069
7070 * syssignal.h: Replace RETSIGTYPE with void.
7071 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7072 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7073 Replace SIGTYPE with void everywhere.
7074 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7075 * s/template.h (SIGTYPE): Remove commented out definition.
7076
7077 2011-03-26 Eli Zaretskii <eliz@gnu.org>
7078
7079 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7080 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7081
7082 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
7083
7084 * w32.c (read_unc_volume): Use parameter `henum', instead of
7085 global variable `wget_enum_handle'.
7086
7087 * keymap.c (describe_vector): Remove parameters `indices' and
7088 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7089 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7090
7091 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7092
7093 * keyboard.c (timer_check): Remove parameter `do_it_now',
7094 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7095 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7096 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7097
7098 * keyboard.c (read_char):
7099 * w32menu.c (w32_menu_display_help):
7100 * xmenu.c (show_help_event, menu_help_callback):
7101 Adjust calls to `show_help_echo'.
7102
7103 * gtkutil.c (xg_maybe_add_timer):
7104 * keyboard.c (readable_events):
7105 * process.c (wait_reading_process_output):
7106 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7107
7108 * insdel.c (adjust_markers_gap_motion):
7109 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7110 (gap_left, gap_right): Don't call it.
7111
7112 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
7113
7114 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7115 incurred during fontification.
7116
7117 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
7118
7119 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7120 (DEFVAR_PER_BUFFER): Don't pass it.
7121
7122 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7123 (scrolling_window): Don't pass it.
7124
7125 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
7126
7127 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7128
7129 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7130 and `suffix'.
7131 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7132 of variables specific to SELinux and computation of `encoded_absname'.
7133
7134 * image.c (XPutPixel): Remove unused variable `height'.
7135
7136 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7137
7138 * unexw32.c (get_section_info): Remove unused variable `section'.
7139
7140 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7141 (system_process_attributes): Remove unused variable `sess'.
7142 (sys_read): Remove unused variable `err'.
7143
7144 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7145 (w32_wnd_proc): Remove unused variable `isdead'.
7146 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7147 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7148 (x_create_tip_frame): Remove unused variable `tem'.
7149
7150 * w32inevt.c (w32_console_read_socket):
7151 Remove unused variable `no_events'.
7152
7153 * w32term.c (x_draw_composite_glyph_string_foreground):
7154 Remove unused variable `width'.
7155
7156 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
7157
7158 * w32term.c (x_set_glyph_string_clipping):
7159 Don't pass uninitialized region to CombineRgn.
7160
7161 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
7162
7163 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7164 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7165 (Fx_close_connection): Remove unused variable `i'.
7166
7167 * w32font.c (w32font_draw): Return number of glyphs.
7168 (w32font_open_internal): Remove unused variable `i'.
7169 (w32font_driver): Add missing initializer.
7170
7171 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7172 (fill_in_menu): Remove unused variable `items_added'.
7173
7174 * w32term.c (last_mouse_press_frame): Remove static global variable.
7175 (w32_clip_to_row): Remove unused variable `f'.
7176 (x_delete_terminal): Remove unused variable `i'.
7177
7178 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7179 (NOTHING): Remove unused static global variable.
7180 (uniscribe_check_otf): Remove unused variable `table'.
7181 (uniscribe_font_driver): Add missing initializers.
7182
7183 2011-03-23 Julien Danjou <julien@danjou.info>
7184
7185 * term.c (Fsuspend_tty, Fresume_tty):
7186 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7187 * window.c (temp_output_buffer_show):
7188 * insdel.c (signal_before_change):
7189 * frame.c (Fhandle_switch_frame):
7190 * fileio.c (Fdo_auto_save):
7191 * emacs.c (Fkill_emacs):
7192 * editfns.c (save_excursion_restore):
7193 * cmds.c (internal_self_insert):
7194 * callint.c (Fcall_interactively):
7195 * buffer.c (Fkill_all_local_variables):
7196 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7197 Use Frun_hooks.
7198 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
7199 unconditionnaly since it does the check itself.
7200
7201 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
7202
7203 Fix more problems found by GCC 4.5.2's static checks.
7204
7205 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7206 the first time through the loop, since we know p0 < p1 then.
7207 This also avoids a gcc -Wstrict-overflow warning.
7208
7209 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7210 leading to a memory leak, possible in functions like
7211 load_charset_map_from_file that can allocate an unbounded number
7212 of objects (Bug#8318).
7213
7214 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7215 that could (at least in theory) be that large.
7216
7217 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7218 This is less likely to overflow, and avoids undefined behavior if
7219 overflow does occur. All callers changed. Use strtoul to scan
7220 for the unsigned long integer.
7221 (pint2hrstr): Simplify and tune code slightly.
7222 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
7223
7224 * scroll.c (do_scrolling): Work around GCC bug 48228.
7225 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7226
7227 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7228 This also avoids a warning with gcc -Wstrict-overflow.
7229 (validate_x_resource_name): Simplify count usage.
7230 This also avoids a warning with gcc -Wstrict-overflow.
7231
7232 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7233 fail (Bug#8306).
7234
7235 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
7236
7237 * process.c (Fmake_network_process): Use socklen_t, not int,
7238 where POSIX says socklen_t is required in portable programs.
7239 This fixes a porting bug on hosts like 64-bit HP-UX, where
7240 socklen_t is wider than int (Bug#8277).
7241 (Fmake_network_process, server_accept_connection):
7242 (wait_reading_process_output, read_process_output):
7243 Likewise.
7244
7245 * process.c: Rename or move locals to avoid shadowing.
7246 (list_processes_1, Fmake_network_process):
7247 (read_process_output_error_handler, exec_sentinel_error_handler):
7248 Rename or move locals.
7249 (Fmake_network_process): Define label "retry_connect" only if needed.
7250 (Fnetwork_interface_info): Fix pointer signedness.
7251 (process_send_signal): Add cast to avoid pointer signedness problem.
7252 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
7253 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
7254
7255 Make tparam.h and terminfo.c consistent.
7256 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7257 Include tparam.h instead, since it declares them.
7258 * cm.h (PC): Remove extern decl; tparam.h now does this.
7259 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7260 * terminfo.c: Include tparam.h, to check interfaces.
7261 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7262 (tparam): Adjust signature to match interface in tparam.h;
7263 this removes some undefined behavior. Check that outstring and len
7264 are zero, which they always are with Emacs.
7265 * tparam.h (PC, BC, UP): New extern decls.
7266
7267 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
7268 (xftfont_open): Rename locals to avoid shadowing.
7269
7270 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
7271 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7272 (OTF_TAG_SYM): Omit macro if not needed.
7273 (ftfont_list): Remove unused local.
7274 (get_adstyle_property, ftfont_pattern_entity):
7275 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7276 Rename locals to avoid shadowing.
7277
7278 * xfont.c (xfont_list_family): Mark var as initialized.
7279
7280 * xml.c (make_dom): Now static.
7281
7282 * composite.c (composition_compute_stop_pos): Rename local to
7283 avoid shadowing.
7284 (composition_reseat_it): Remove unused locals.
7285 (find_automatic_composition, composition_adjust_point): Likewise.
7286 (composition_update_it): Mark var as initialized.
7287 (find_automatic_composition): Mark vars as initialized,
7288 with a FIXME (Bug#8290).
7289
7290 character.h: Rename locals to avoid shadowing.
7291 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7292 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7293 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7294 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7295 to avoid shadowing.
7296
7297 * textprop.c (property_change_between_p): Remove; unused.
7298
7299 * intervals.c (interval_start_pos): Now static.
7300
7301 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7302
7303 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7304 Rename locals to avoid shadowing.
7305
7306 * sound.c (wav_play, au_play, Fplay_sound_internal):
7307 Fix pointer signedness.
7308 (alsa_choose_format): Remove unused local var.
7309 (wav_play): Initialize a variable to 0, to prevent undefined
7310 behavior (Bug#8278).
7311
7312 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7313
7314 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7315
7316 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7317 clobbering (Bug#8298).
7318 * sysdep.c (sys_subshell): Likewise.
7319 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7320
7321 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7322 This should get cleaned up, so that child_setup has the
7323 same signature on all platforms.
7324
7325 * callproc.c (call_process_cleanup): Now static.
7326 (relocate_fd): Rename locals to avoid shadowing.
7327
7328 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
7329
7330 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7331 not to be necessary, and produces flickering.
7332
7333 2011-03-20 Glenn Morris <rgm@gnu.org>
7334
7335 * config.in: Remove file.
7336
7337 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
7338
7339 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7340 are now in src/globals.h.
7341 (syms_of_minibuf): Remove spurious & from previous change.
7342
7343 2011-03-20 Leo <sdl.web@gmail.com>
7344
7345 * minibuf.c (completing-read-function): New variable.
7346 (completing-read-default): Rename from completing-read.
7347 (completing-read): Call completing-read-function.
7348
7349 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7350
7351 * xfaces.c (Fx_load_color_file):
7352 Read color file from absolute filename (bug#8250).
7353
7354 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
7355
7356 * makefile.w32-in: Update dependencies.
7357
7358 2011-03-17 Eli Zaretskii <eliz@gnu.org>
7359
7360 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7361
7362 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7363
7364 Fix more problems found by GCC 4.5.2's static checks.
7365
7366 * process.c (make_serial_process_unwind, send_process_trap):
7367 (sigchld_handler): Now static.
7368
7369 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7370 That way, the code declares only the vars that it needs.
7371 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7372 * s/cygwin.h (PTY_ITERATION): Likewise.
7373 * s/darwin.h (PTY_ITERATION): Likewise.
7374 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7375
7376 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7377 * process.c (allocate_pty): Don't declare stb unless it's needed.
7378
7379 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
7380 (CONSTANTLIM): Remove; unused.
7381 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7382 Define only if needed.
7383
7384 * unexelf.c (unexec): Name an expression,
7385 to avoid gcc -Wbad-function-cast warning.
7386 Use a different way to cause a compilation error if anyone uses
7387 n rather than nn, a way that does not involve shadowing.
7388 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
7389
7390 * deps.mk (unexalpha.o): Remove; unused.
7391
7392 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7393 * unexec.h: New file.
7394 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7395 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7396 Depend on unexec.h.
7397 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7398 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7399 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
7400 Change as necessary to match prototype in unexec.h.
7401
7402 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7403 shadowing.
7404 (back_comment, skip_chars): Mark vars as initialized.
7405
7406 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7407 Rename locals to avoid shadowing.
7408
7409 * lread.c (read1): Rewrite so as not to use empty "else".
7410 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
7411
7412 * print.c (Fredirect_debugging_output): Fix pointer signedess.
7413
7414 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
7415 warning when compiling print.c.
7416
7417 * font.c (font_unparse_fcname): Abort in an "impossible" situation
7418 instead of using an uninitialized var.
7419 (font_sort_entities): Mark var as initialized.
7420
7421 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
7422
7423 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
7424 pointers to constants.
7425 (font_parse_fcname): Remove unused vars.
7426 (font_delete_unmatched): Now static.
7427 (font_get_spec): Remove; unused.
7428 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
7429 (font_update_drivers, Ffont_get_glyphs, font_add_log):
7430 Rename or move locals to avoid shadowing.
7431
7432 * fns.c (require_nesting_list, require_unwind): Now static.
7433 (Ffillarray): Rename locals to avoid shadowing.
7434
7435 * floatfns.c (domain_error2): Define only if needed.
7436 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
7437
7438 * alloc.c (mark_backtrace): Move decl from here ...
7439 * lisp.h: ... to here, so that it can be checked.
7440
7441 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
7442 (Fdefvar): Rewrite so as not to use empty "else".
7443 (lisp_indirect_variable): Name an expression,
7444 to avoid gcc -Wbad-function-cast warning.
7445 (Fdefvar): Rename locals to avoid shadowing.
7446
7447 * callint.c (quotify_arg, quotify_args): Now static.
7448 (Fcall_interactively): Rename locals to avoid shadowing.
7449 Use const pointer when appropriate.
7450
7451 * lisp.h (get_system_name, get_operating_system_release):
7452 Move decls here, to check interfaces.
7453 * process.c (get_operating_system_release): Move decl to lisp.h.
7454 * xrdb.c (get_system_name): Likewise.
7455 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
7456 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
7457 some of which prompt warnings from gcc -Wbad-function-cast.
7458 (Fformat_time_string, Fencode_time, Finsert_char):
7459 (Ftranslate_region_internal, Fformat):
7460 Rename or remove local vars to avoid shadowing.
7461 (Ftranslate_region_internal): Mark var as initialized.
7462
7463 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
7464 avoid shadowing.
7465
7466 * lisp.h (eassert): Check that the argument compiles, even if
7467 ENABLE_CHECKING is not defined.
7468
7469 * data.c (Findirect_variable): Name an expression, to avoid
7470 gcc -Wbad-function-cast warning.
7471 (default_value, arithcompare, arith_driver, arith_error): Now static.
7472 (store_symval_forwarding): Rename local to avoid shadowing.
7473 (Fmake_variable_buffer_local, Fmake_local_variable):
7474 Mark variables as initialized.
7475 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
7476
7477 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
7478 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
7479 Rename locals to avoid shadowing.
7480 (mark_stack): Move local variables into the #ifdef region where
7481 they're used.
7482 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
7483 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
7484 needed otherwise.
7485 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
7486 (GC_STRING_CHARS): Remove; not used.
7487 (Fmemory_limit): Cast sbrk's returned value to char *.
7488
7489 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
7490 avoids undefined behavior in theory.
7491
7492 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
7493
7494 Use functions, not macros, for up- and down-casing (Bug#8254).
7495 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7496 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
7497 to use the following functions instead of these macros.
7498 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
7499 EMACS_INT, since callers assume the returned value fits in int.
7500 (upcase1): Likewise, for UPCASE_TABLE.
7501 (uppercasep, lowercasep, upcase): New static inline functions.
7502 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
7503 the race-condition problem in the old DOWNCASE.
7504
7505 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
7506 Rename locals to avoid shadowing.
7507 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
7508 (regex_compile, re_search_2, re_match_2_internal):
7509 Remove unused local vars.
7510 (FREE_VAR): Rewrite so as not to use empty "else",
7511 which gcc can warn about.
7512 (regex_compile, re_match_2_internal): Mark locals as initialized.
7513 (RETALLOC_IF): Define only if needed.
7514 (WORDCHAR_P): Likewise. This one is never needed, but is used
7515 only in a comment talking about a compiler bug, so put inside
7516 the #if 0 of that comment.
7517 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
7518 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
7519 Remove; unused.
7520
7521 * search.c (boyer_moore): Rename locals to avoid shadowing.
7522 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
7523 (PREV_CHAR_BOUNDARY): Likewise.
7524
7525 * search.c (simple_search): Remove unused var.
7526
7527 * dired.c (compile_pattern): Move decl from here ...
7528 * lisp.h: ... to here, so that it can be checked.
7529 (struct re_registers): New forward decl.
7530
7531 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
7532
7533 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7534 All uses changed.
7535 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7536 Rename locals to avoid shadowing.
7537 (Fvertical_motion): Mark locals as initialized.
7538
7539 * casefiddle.c (casify_object, casify_region): Now static.
7540 (casify_region): Mark local as initialized.
7541
7542 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7543
7544 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7545 New macros, so that the caller can use some names other than
7546 gcpro1, gcpro2, etc.
7547 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7548 of the new macros.
7549 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7550 argument, for consistency with GCPRO2_VAR, etc: it is now the
7551 prefix of the variable, not the variable itself. All uses
7552 changed.
7553 * dired.c (directory_files_internal, file_name_completion):
7554 Rename locals to avoid shadowing.
7555
7556 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7557 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7558 dired.c's scmp function, had undefined behavior.
7559 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7560 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7561 * buffer.h: ... to here, because these macros use current_buffer,
7562 and the new implementation with inline functions needs to have
7563 current_buffer in scope now, rather than later when the macros
7564 are used.
7565 (downcase, upcase1): New static inline functions.
7566 (DOWNCASE, UPCASE1): Reimplement using these functions.
7567 This avoids undefined behavior in expressions like
7568 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7569 from race conditions in accessing the global variables
7570 case_temp1 and case_temp2.
7571 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7572 * lisp.h (case_temp1, case_temp2): Remove their decls.
7573 * character.h (ASCII_CHAR_P): Move from here ...
7574 * lisp.h: ... to here, so that the inline functions mentioned
7575 above can use them.
7576
7577 * dired.c (directory_files_internal_unwind): Now static.
7578
7579 * fileio.c (file_name_as_directory, directory_file_name):
7580 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7581 Now static.
7582 (file_name_as_directory): Use const pointers when appropriate.
7583 (Fexpand_file_name): Likewise. In particular, newdir might
7584 point at constant storage, so make it a const pointer.
7585 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
7586 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7587 signedness issues.
7588 (Fset_file_times, Finsert_file_contents, auto_save_error):
7589 Rename locals to avoid shadowing.
7590
7591 * minibuf.c (choose_minibuf_frame_1): Now static.
7592 (Ftry_completion, Fall_completions): Rename or remove locals
7593 to avoid shadowing.
7594
7595 * marker.c (bytepos_to_charpos): Remove; unused.
7596
7597 * lisp.h (verify_bytepos, count_markers): New decls,
7598 so that gcc does not warn that these functions aren't declared.
7599
7600 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7601 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
7602 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
7603 (copy_text): Remove unused local var.
7604
7605 * filelock.c (within_one_second): Now static.
7606 (lock_file_1): Rename local to avoid shadowing.
7607
7608 * buffer.c (fix_overlays_before): Mark locals as initialized.
7609 (fix_start_end_in_overlays): Likewise. This function should be
7610 simplified by using pointers-to-pointers, but that's a different
7611 matter.
7612 (switch_to_buffer_1): Now static.
7613 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7614 (report_overlay_modification): Rename locals to avoid shadowing.
7615
7616 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
7617 Fix pointer signedness issue.
7618 (sys_subshell): Mark local as volatile if checking for lint,
7619 to suppress a gcc -Wclobbered warning that does not seem to be right.
7620 (MAXPATHLEN): Define only if needed.
7621
7622 * process.c (serial_open, serial_configure): Move decls from here ...
7623 * systty.h: ... to here, so that they can be checked.
7624
7625 * fns.c (get_random, seed_random): Move extern decls from here ...
7626 * lisp.h: ... to here, so that they can be checked.
7627
7628 * sysdep.c (reset_io): Now static.
7629 (wait_for_termination_signal): Remove; unused.
7630
7631 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7632 (copy_keymap_item, append_key, push_text_char_description):
7633 Now static.
7634 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
7635 (DENSE_TABLE_SIZE): Remove; unused.
7636 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7637 (describe_map_tree):
7638 Rename locals to avoid shadowing.
7639
7640 * keyboard.c: Declare functions static if they are not used elsewhere.
7641 (echo_char, echo_dash, cmd_error, top_level_2):
7642 (poll_for_input, handle_async_input): Now static.
7643 (read_char, kbd_buffer_get_event, make_lispy_position):
7644 (make_lispy_event, make_lispy_movement, apply_modifiers):
7645 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7646 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7647 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
7648 (read_key_sequence, read_char): Mark locals as initialized.
7649 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
7650
7651 * keyboard.h (make_ctrl_char): New decl.
7652 (mark_kboards): Move decl here ...
7653 * alloc.c (mark_kboards): ... from here.
7654
7655 * lisp.h (force_auto_save_soon): New decl.
7656
7657 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
7658 (DEFINE_DUMMY_FUNCTION): New macro.
7659 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7660 Use it.
7661 (main): Add casts to avoid warnings
7662 if GCC considers string literals to be constants.
7663
7664 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7665
7666 * dbusbind.c: Pointer signedness fixes.
7667 (xd_signature, xd_append_arg, xd_initialize):
7668 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7669 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7670 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7671 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7672
7673 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7674 if GCC considers string literals to be constants.
7675 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
7676
7677 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7678
7679 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7680 (print_preprocess, print_object): New macro to fix last change.
7681
7682 * print.c (print_preprocess): Don't forget font objects.
7683
7684 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
7685
7686 * emacs.c (USAGE3): Doc fixes.
7687
7688 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7689
7690 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7691 structure.
7692
7693 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
7694
7695 * lisp.h (VWindow_system, Qfile_name_history):
7696 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7697 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7698 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7699
7700 * w32select.c: Don't #include "keyboard.h".
7701 (run_protected): Add extern declaration for waiting_for_input.
7702
7703 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7704 * w32console.c (detect_input_pending, read_input_pending)
7705 (encode_terminal_code):
7706 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7707 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7708 (w32_system_caret_y, Qfile_name_history):
7709 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7710 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7711 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7712 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7713 * w32proc.c (Qlocal, report_file_error):
7714 * w32term.c (Vwindow_system, updating_frame):
7715 * w32uniscribe.c (initialized, uniscribe_font_driver):
7716 Remove unneeded extern declarations.
7717
7718 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
7719
7720 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
7721
7722 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
7723
7724 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7725 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7726 These macros can no longer be used for assignment.
7727
7728 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7729 Assign struct members directly, instead of using BUF_BEGV etc.
7730 (record_buffer_markers, fetch_buffer_markers): New functions for
7731 recording and fetching special buffer markers.
7732 (set_buffer_internal_1, set_buffer_temp): Use them.
7733
7734 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7735
7736 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7737
7738 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7739 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7740
7741 * xdisp.c (hscroll_window_tree):
7742 (reconsider_clip_changes): Use PT instead of BUF_PT.
7743
7744 2011-03-13 Eli Zaretskii <eliz@gnu.org>
7745
7746 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7747 $(EMACS_ROOT)/lib/intprops.h.
7748
7749 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7750
7751 Fix more problems found by GCC 4.5.2's static checks.
7752
7753 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7754 to unsigned char * to avoid compiler diagnostic.
7755 (xg_free_frame_widgets): Make it clear that a local variable is
7756 needed only if USE_GTK_TOOLTIP.
7757 (gdk_window_get_screen): Make it clear that this macro is needed
7758 only if USE_GTK_TOOLTIP.
7759 (int_gtk_range_get_value): New function, which avoids a diagnostic
7760 from gcc -Wbad-function-cast.
7761 (xg_set_toolkit_scroll_bar_thumb): Use it.
7762 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7763 diagnostic from gcc -Wbad-function-cast.
7764 (get_utf8_string, xg_get_file_with_chooser):
7765 Rename locals to avoid shadowing.
7766 (create_dialog): Move locals to avoid shadowing.
7767
7768 * xgselect.c (xg_select): Remove unused var.
7769
7770 * image.c (four_corners_best): Mark locals as initialized.
7771 (gif_load): Initialize transparent_p to zero (Bug#8238).
7772 Mark another local as initialized.
7773 (my_png_error, my_error_exit): Mark with NO_RETURN.
7774
7775 * image.c (clear_image_cache): Now static.
7776 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
7777 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
7778 (x_edge_detection): Remove unnecessary cast that
7779 gcc -Wbad-function-cast diagnoses.
7780 (gif_load): Fix pointer signedness.
7781 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7782 (jpeg_load, gif_load): Rename locals to avoid shadowing.
7783
7784 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
7785
7786 Improve quality of tests for time stamp overflow.
7787 For example, without this patch (encode-time 0 0 0 1 1
7788 1152921504606846976) returns the obviously-bogus value (-948597
7789 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7790 reports time overflow. See
7791 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
7792 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7793 * editfns.c: Include limits.h and intprops.h.
7794 (TIME_T_MIN, TIME_T_MAX): New macros.
7795 (time_overflow): Move earlier, to before first use.
7796 (hi_time, lo_time): New functions, for an accurate test for
7797 out-of-range times.
7798 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7799 (Fget_internal_run_time): Don't assume time_t fits in int.
7800 (make_time): Use list2 instead of Fcons twice.
7801 (Fdecode_time): More accurate test for out-of-range times.
7802 (check_tm_member): New function.
7803 (Fencode_time): Use it, to test for out-of-range times.
7804 (lisp_time_argument): Don't rely on undefined left-shift and
7805 right-shift behavior when checking for time stamp overflow.
7806
7807 * editfns.c (time_overflow): New function, refactoring common code.
7808 (Fformat_time_string, Fdecode_time, Fencode_time):
7809 (Fcurrent_time_string): Use it.
7810
7811 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7812 * dired.c (make_time): Move to ...
7813 * editfns.c (make_time): ... here.
7814 * systime.h: Note the move.
7815
7816 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7817
7818 * fringe.c (update_window_fringes): Remove unused variables.
7819
7820 * unexmacosx.c (copy_data_segment): Also copy __got section.
7821 (Bug#8223)
7822
7823 2011-03-12 Eli Zaretskii <eliz@gnu.org>
7824
7825 * termcap.c [MSDOS]: Include "msdos.h".
7826 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7827 Constify `char *' arguments and their references according to
7828 prototypes in tparam.h.
7829
7830 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
7831
7832 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7833 Adapt all references accordingly.
7834
7835 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7836
7837 2011-03-11 Tom Tromey <tromey@redhat.com>
7838
7839 * buffer.c (syms_of_buffer): Remove obsolete comment.
7840
7841 2011-03-11 Eli Zaretskii <eliz@gnu.org>
7842
7843 * termhooks.h (encode_terminal_code): Declare prototype.
7844
7845 * msdos.c (encode_terminal_code): Don't declare prototype.
7846
7847 * term.c (encode_terminal_code): Now external again, used by
7848 w32console.c and msdos.c.
7849
7850 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7851 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7852
7853 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
7854
7855 Fix some minor problems found by GCC 4.5.2's static checks.
7856
7857 * fringe.c (update_window_fringes): Mark locals as initialized
7858 (Bug#8227).
7859 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
7860
7861 * alloc.c (mark_fringe_data): Move decl from here ...
7862 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7863 to check its interface.
7864 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7865
7866 * fontset.c (free_realized_fontset): Now static.
7867 (Fset_fontset_font): Rename local to avoid shadowing.
7868 (fontset_font): Mark local as initialized.
7869 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
7870
7871 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7872
7873 * xselect.c (x_disown_buffer_selections): Remove; not used.
7874 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
7875 (x_own_selection, Fx_disown_selection_internal): Rename locals
7876 to avoid shadowing.
7877 (x_handle_dnd_message): Remove local to avoid shadowing.
7878
7879 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7880 so that the caller can use some name other than gcpro1.
7881 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
7882 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7883 (Fx_backspace_delete_keys_p):
7884 Use them to avoid shadowing, and rename vars to avoid shadowing.
7885 (x_decode_color, x_set_name, x_window): Now static.
7886 (Fx_create_frame): Add braces to silence GCC warning.
7887 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
7888 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7889 Remove unused locals.
7890 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7891 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7892 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7893 macros.
7894
7895 * xterm.h (x_mouse_leave): New decl.
7896
7897 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7898 Remove unused functions.
7899 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7900 (x_calc_absolute_position): Now static.
7901 (XTread_socket): Don't define label "out" unless it's used.
7902 Don't declare local "event" unless it's used.
7903 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7904 unless they are used.
7905 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7906 (x_fatal_error_signal): Remove; not used.
7907 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7908 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7909 (x_error_catcher, x_connection_closed, x_error_handler):
7910 (x_error_quitter, xembed_send_message, x_iconify_frame):
7911 (my_log_handler): Rename locals to avoid shadowing.
7912 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
7913 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
7914
7915 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7916 Rename or move locals to avoid shadowing.
7917 (tty_defined_color, merge_face_heights): Now static.
7918 (free_realized_faces_for_fontset): Remove; not used.
7919 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7920 does not deduce is never used uninitialized.
7921 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7922 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
7923
7924 * terminal.c (store_terminal_param): Now static.
7925
7926 * xmenu.c (menu_highlight_callback): Now static.
7927 (set_frame_menubar): Remove unused local.
7928 (xmenu_show): Rename parameter to avoid shadowing.
7929 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7930 since they might point to immutable storage.
7931 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7932 since it's unused otherwise.
7933
7934 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
7935 Add a FIXME, since the code still doesn't look right. (Bug#8215)
7936 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7937 avoids a gcc -Wuninitialized diagnostic.
7938 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
7939 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7940 does not deduce are never used uninitialized.
7941
7942 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7943
7944 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
7945 * window.c (window_loop, size_window):
7946 (run_window_configuration_change_hook, enlarge_window): Likewise.
7947
7948 * window.c (display_buffer): Now static.
7949 (size_window): Mark variables that gcc -Wuninitialized
7950 does not deduce are never used uninitialized.
7951 * window.h (check_all_windows): New decl, to forestall
7952 gcc -Wmissing-prototypes diagnostic.
7953 * dispextern.h (bidi_dump_cached_states): Likewise.
7954
7955 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7956 shadowing.
7957 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
7958 Include <limits.h>.
7959 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7960 and to avoid gcc -Wuninitialized warning.
7961 (load_charset_map): Mark variables that gcc -Wuninitialized
7962 does not deduce are never used uninitialized.
7963 (load_charset): Abort instead of using uninitialized var (Bug#8229).
7964
7965 * coding.c (coding_set_source, coding_set_destination):
7966 Use "else { /* comment */ }" rather than "else /* comment */;"
7967 for clarity, and to avoid gcc -Wempty-body warning.
7968 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7969 a block, when the outer 'i' will do.
7970 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7971 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7972 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7973 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7974 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7975 Rename locals to avoid shadowing.
7976 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
7977 * coding.c (emacs_mule_char, encode_invocation_designation):
7978 Now static, since they're not used elsewhere.
7979 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
7980 (decode_coding_object, encode_coding_object, detect_coding_system):
7981 (decode_coding_emacs_mule): Mark variables that gcc
7982 -Wuninitialized does not deduce are never used uninitialized.
7983 (detect_coding_iso_2022): Initialize a local variable that might
7984 be used uninitialized. Leave a FIXME because it's not clear that
7985 this initialization is needed. (Bug#8211)
7986 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7987 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7988 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7989 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7990 Remove unused macros.
7991
7992 * category.c (hash_get_category_set): Remove unused local var.
7993 (copy_category_table): Now static, since it's not used elsewhere.
7994 * character.c (string_count_byte8): Likewise.
7995
7996 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7997 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7998
7999 * chartab.c (copy_sub_char_table): Now static, since it's not used
8000 elsewhere.
8001 (sub_char_table_ref_and_range, char_table_ref_and_range):
8002 Rename locals to avoid shadowing.
8003 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
8004
8005 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
8006 (BIDI_BOB): Remove unused macro.
8007
8008 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8009 deduce are never used uninitialized.
8010 * term.c (encode_terminal_code): Likewise.
8011
8012 * term.c (encode_terminal_code): Now static. Remove unused local.
8013
8014 * tparam.h: New file.
8015 * term.c, tparam.h: Include it.
8016 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8017 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8018 Move these decls to tparam.h, and make them agree with what
8019 is actually in tparam.c. The previous trick of using incompatible
8020 decls in different modules does not conform to the C standard.
8021 All callers of tparam changed to use tparam's actual API.
8022 * tparam.c (tparam1, tparam, tgoto):
8023 Use const pointers where appropriate.
8024
8025 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8026 * cm.h (struct cm): Likewise.
8027 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8028 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8029 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8030 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8031 (turn_on_face, init_tty): Likewise.
8032 * termchar.h (struct tty_display_info): Likewise.
8033
8034 * term.c (term_mouse_position): Rename local to avoid shadowing.
8035
8036 * alloc.c (mark_ttys): Move decl from here ...
8037 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8038
8039 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8040
8041 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8042
8043 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
8044
8045 * search.c (compile_pattern_1): Remove argument regp, unused since
8046 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8047 (compile_pattern): Don't pass it.
8048
8049 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8050
8051 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8052 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8053 for ! HAVE_GTK3.
8054 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8055
8056 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8057
8058 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8059 gdk_window_get_screen, gdk_window_get_geometry,
8060 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8061 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8062 (xg_get_pixbuf_from_pixmap): New function.
8063 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8064 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8065 Call xg_get_pixbuf_from_pixmap instead of
8066 gdk_pixbuf_get_from_drawable.
8067 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8068 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8069 (xg_check_special_colors): Use GtkStyleContext and its functions
8070 for HAVE_GTK3.
8071 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8072 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8073 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
8074 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8075 Call gtk_widget_get_preferred_size.
8076 (xg_frame_resized): gdk_window_get_geometry only takes 5
8077 parameters.
8078 (xg_win_to_widget, xg_event_is_for_menubar):
8079 Call gdk_x11_window_lookup_for_display.
8080 (xg_set_widget_bg): New function.
8081 (delete_cb): New function.
8082 (xg_create_frame_widgets): Connect delete-event to delete_cb.
8083 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
8084 (xg_set_background_color): Call xg_set_widget_bg.
8085 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8086 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8087 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8088 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8089 if ! HAVE_GTK3.
8090 (update_frame_tool_bar): Call gtk_widget_hide.
8091 (xg_initialize): Use GDK_KEY_g.
8092
8093 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8094 if ! HAVE_GTK3
8095 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8096
8097 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8098 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8099 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8100
8101 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
8102
8103 * w32xfns.c (select_palette): Check success of RealizePalette against
8104 GDI_ERROR, not zero.
8105
8106 See ChangeLog.11 for earlier changes.
8107
8108 ;; Local Variables:
8109 ;; coding: utf-8
8110 ;; End:
8111
8112 Copyright (C) 2011 Free Software Foundation, Inc.
8113
8114 This file is part of GNU Emacs.
8115
8116 GNU Emacs is free software: you can redistribute it and/or modify
8117 it under the terms of the GNU General Public License as published by
8118 the Free Software Foundation, either version 3 of the License, or
8119 (at your option) any later version.
8120
8121 GNU Emacs is distributed in the hope that it will be useful,
8122 but WITHOUT ANY WARRANTY; without even the implied warranty of
8123 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8124 GNU General Public License for more details.
8125
8126 You should have received a copy of the GNU General Public License
8127 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.