1 2011-06-03 Paul Eggert <eggert@cs.ucla.edu>
3 Check for overflow when converting integer to cons and back.
4 * charset.c (Fdefine_charset_internal, Fdecode_char):
5 Use cons_to_unsigned to catch overflow.
6 (Fencode_char): Use INTEGER_TO_CONS.
7 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
8 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
9 * data.c (long_to_cons, cons_to_long): Remove.
10 (cons_to_unsigned, cons_to_signed): New functions.
11 These signal an error for invalid or out-of-range values.
12 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
13 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
14 * font.c (Ffont_variation_glyphs):
15 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
16 * lisp.h (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
17 (cons_to_signed, cons_to_unsigned): New decls.
18 (long_to_cons, cons_to_long): Remove decls.
19 * undo.c (record_first_change): Use INTEGER_TO_CONS.
20 (Fprimitive_undo): Use CONS_TO_INTEGER.
21 * xfns.c (Fx_window_property): Likewise.
22 * xselect.c: Include <limits.h>.
23 (x_own_selection, selection_data_to_lisp_data):
25 (x_handle_selection_request, x_handle_selection_clear)
26 (x_get_foreign_selection, Fx_disown_selection_internal)
27 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
28 (lisp_data_to_selection_data): Use cons_to_unsigned.
29 (x_fill_property_data): Use cons_to_signed. Report values out of range.
31 Fix doc for machines with wider system times such as time_t.
32 On such machines, it's now safe to assume that EMACS_INT is as
33 wide as the system times, so that shifting right by 16 will
34 result in an integer that always fits in EMACS_INT.
35 * dired.c (Ffile_attributes): Document large inode number handling.
36 * termhooks.h: Fix comment for large time stamp handling.
38 * lisp.h (WIDE_EMACS_INT): Now defaults to 1.
40 * xselect.c: Use 'unsigned' more consistently.
41 (selection_data_to_lisp_data, lisp_data_to_selection_data):
42 Use 'unsigned' consistently when computing sizes of unsigned objects.
44 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
45 if b->modtime has its maximal value.
47 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
49 * lisp.h: Include <intprops.h>, as it'll useful in later changes.
50 * character.c, data.c, editfns.c, insdel.c, intervals.c:
51 Don't include <intprops.h>, since lisp.h does.
53 Don't assume time_t can fit into int.
54 * buffer.h (struct buffer.modtime): Now time_t, not int.
55 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
56 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
58 Minor fixes for signed vs unsigned integers.
59 * character.h (MAYBE_UNIFY_CHAR):
60 * charset.c (maybe_unify_char):
61 * keyboard.c (read_char, reorder_modifiers):
62 XINT -> XFASTINT, since the integer must be nonnegative.
63 * ftfont.c (ftfont_spec_pattern):
64 * keymap.c (access_keymap, silly_event_symbol_error):
65 XUINT -> XFASTINT, since the integer must be nonnegative.
66 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
67 since it makes no difference and we prefer signed.
68 * keyboard.c (record_char): Use XUINT when all the neighbors do.
69 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
72 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
74 Malloc failure behavior now depends on size of allocation.
75 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
76 * lisp.h: Change signatures accordingly.
77 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
78 All callers changed. (Bug#8762)
80 * gnutls.c: Use Emacs's memory allocators.
81 Without this change, the gnutls library would invoke malloc etc.
82 directly, which causes problems on non-SYNC_INPUT hosts, and which
83 runs afoul of improving memory_full behavior. (Bug#8761)
84 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
85 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
86 xfree instead of the default malloc, realloc, free.
87 (Fgnutls_boot): No need to check for memory allocation failure,
88 since xmalloc does that for us.
90 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
91 * category.c (hash_get_category_set):
93 * charset.c (Fdefine_charset_internal):
94 * charset.h (struct charset.hash_index):
95 * composite.c (get_composition_id, gstring_lookup_cache)
96 (composition_gstring_put_cache):
97 * composite.h (struct composition.hash_index):
98 * dispextern.h (struct image.hash):
99 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
100 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
101 (hashfn_equal, hashfn_user_defined, make_hash_table)
102 (maybe_resize_hash_table, hash_lookup, hash_put)
103 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
104 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
105 (Fsxhash, Fgethash, Fputhash, Fmaphash):
106 * image.c (make_image, search_image_cache, lookup_image)
107 (xpm_put_color_table_h):
108 * lisp.h (struct Lisp_Hash_Table):
109 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
110 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
111 for hashes and hash indexes, instead of 'unsigned' and 'int'.
112 * alloc.c (allocate_vectorlike):
113 Check for overflow in vector size calculations.
114 * ccl.c (ccl_driver):
115 Check for overflow when converting EMACS_INT to int.
116 * fns.c, image.c: Remove unnecessary static decls that would otherwise
117 need to be updated by these changes.
118 * fns.c (make_hash_table, maybe_resize_hash_table):
119 Check for integer overflow with large hash tables.
120 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
121 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
122 (SXHASH_REDUCE): New macro.
123 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
124 Use it instead of discarding useful hash info with large hash values.
125 (sxhash_float): New function.
126 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
127 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
128 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
129 Rewrite to use FIXNUM_BITS, as this simplifies things.
130 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
131 Adjust signatures to match updated version of code.
132 (consing_since_gc): Now EMACS_INT, since a single hash table can
133 use more than INT_MAX bytes.
135 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
137 Make it possible to build with GCC-4.6+ -O2 -flto.
139 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
141 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
143 * minibuf.c (get_minibuffer, read_minibuf_unwind):
144 Call minibuffer-inactive-mode.
146 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
148 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
151 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
153 * data.c (init_data): Remove code for UTS, this system is not
156 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
158 Don't force ./temacs to start in terminal mode.
160 * frame.c (make_initial_frame): Initialize faces in all cases, not
161 only when CANNOT_DUMP is defined.
162 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
164 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
166 * dispnew.c (add_window_display_history): Use const for the string
167 pointer. Remove declaration, not needed.
169 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
171 Use 'inline', not 'INLINE'.
172 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
173 * alloc.c, fontset.c (INLINE): Remove.
174 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
175 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
176 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
177 * gmalloc.c (register_heapinfo): Use inline unconditionally.
178 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
180 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
182 Make it possible to run ./temacs.
184 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
185 syms_of_callproc does the same thing. Remove test for
186 "initialized", do it in the caller.
187 * emacs.c (main): Avoid calling set_initial_environment when dumping.
189 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
191 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
192 (read_minibuf): Use get_minibuffer.
193 (syms_of_minibuf): Use DEFSYM.
194 (Qmetadata): New var.
195 * data.c (Qbuffer): Don't make it static.
196 (syms_of_data): Use DEFSYM.
198 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
200 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
201 (CCL_CODE_MIN): New macro.
203 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
205 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
207 * eval.c (Qdebug): Now static.
208 * lisp.h (Qdebug): Remove decl. This reverts a part of the
209 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
210 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
212 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
214 * image.c: Various fixes to ImageMagick code comments.
215 (Fimagemagick_types): Doc fix.
217 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
219 Minor fixes prompted by GCC 4.6.0 warnings.
221 * xselect.c (converted_selections, conversion_fail_tag): Now static.
223 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
224 (x_clipboard_manager_save_all): Move extern decl to ...
225 * xterm.h: ... here, so that it can be checked for consistency.
227 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
229 * xselect.c (x_clipboard_manager_save_frame)
230 (x_clipboard_manager_save_all): New functions.
231 (Fx_clipboard_manager_save): Lisp function deleted.
233 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
234 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
236 * xterm.h: Update prototype.
238 2011-05-28 William Xu <william.xwl@gmail.com>
240 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
243 2011-05-28 Jim Meyering <meyering@redhat.com>
245 Avoid a sign-extension bug in crypto_hash_function.
246 * fns.c (to_uchar): Define.
247 (crypto_hash_function): Use it to convert some newly-signed
248 variables to unsigned, to avoid sign-extension bugs. For example,
249 without this change, (md5 "truc") would evaluate to
250 45723a2aff78ff4fff7fff1114760e62 rather than the expected
251 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
252 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
254 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
256 Integer overflow fixes.
258 * dbusbind.c: Serial number integer overflow fixes.
259 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
260 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
261 to hold a serial number that is too large for a fixnum.
262 (Fdbus_method_return_internal, Fdbus_method_error_internal):
263 Check for serial numbers out of range. Decode any serial number
264 that was so large that it became a float. (Bug#8722)
266 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
267 (Fdbus_call_method, Fdbus_call_method_asynchronously):
268 Use XFASTINT rather than XUINT when numbers are nonnegative.
269 (xd_append_arg, Fdbus_method_return_internal):
270 (Fdbus_method_error_internal): Likewise. Also, for unsigned
271 arguments, check that Lisp number is nonnegative, rather than
272 silently wrapping negative numbers around. (Bug#8722)
273 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
276 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
278 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
280 ccl: add integer overflow checks
281 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
282 (IN_INT_RANGE): New macros.
283 (ccl_driver): Use them to check for integer overflow when
284 decoding a CCL program. Many of the new checks are whether XINT (x)
285 fits in int; it doesn't always, on 64-bit hosts. The new version
286 doesn't catch all possible integer overflows, but it's an
287 improvement. (Bug#8719)
289 * alloc.c (make_event_array): Use XINT, not XUINT.
290 There's no need for unsigned here.
292 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
293 This follows up to the 2011-05-06 change that substituted uintptr_t
294 for EMACS_INT. This case wasn't caught back then.
296 Rework Fformat to avoid integer overflow issues.
297 * editfns.c: Include <float.h> unconditionally, as it's everywhere
298 now (part of C89). Include <verify.h>.
299 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
300 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
301 (Fformat): Avoid the prepass trying to compute sizes; it was only
302 approximate and thus did not catch overflow reliably. Instead, walk
303 through the format just once, formatting and computing sizes as we go,
304 checking for integer overflow at every step, and allocating a larger
305 buffer as needed. Keep track separately whether the format is
306 multibyte. Keep only the most-recently calculated precision, rather
307 than them all. Record whether each argument has been converted to
308 string. Use EMACS_INT, not int, for byte and char and arg counts.
309 Support field widths and precisions larger than INT_MAX. Avoid
310 sprintf's undefined behavior with conversion specifications such as %#d
311 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
312 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
313 formatting out-of-range floating point numbers with int
316 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
318 * data.c: Avoid integer truncation in expressions involving floats.
319 * data.c: Include <intprops.h>.
320 (arith_driver): When there's an integer overflow in an expression
321 involving floating point, convert the integers to floating point
322 so that the resulting value does not suffer from catastrophic
323 integer truncation. For example, on a 64-bit host (* 4
324 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
325 Do not rely on undefined behavior after integer overflow.
327 merge count_size_as_multibyte, parse_str_to_multibyte
328 * character.c, character.h (count_size_as_multibyte):
329 Rename from parse_str_to_multibyte; all uses changed.
330 Check for integer overflow.
331 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
332 since it's now a duplicate of the other. This is more of
333 a character than a buffer op, so better that it's in character.c.
334 * fns.c, print.c: Adjust to above changes.
336 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
338 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
340 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
342 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
343 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
344 (x_clipboard_manager_save): Now static.
345 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
347 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
348 (crypto_hash_function): Now static.
349 Fix pointer signedness problems. Avoid unnecessary initializations.
351 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
353 * termhooks.h (Vselection_alist): Make it terminal-local.
355 * terminal.c (create_terminal): Initialize it.
357 * xselect.c: Support for clipboard managers.
358 (Vselection_alist): Move to termhooks.h as terminal-local var.
359 (LOCAL_SELECTION): New macro.
360 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
361 (symbol_to_x_atom): Remove gratuitous arg.
362 (x_handle_selection_request, lisp_data_to_selection_data)
363 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
364 (x_own_selection, x_get_local_selection, x_convert_selection):
365 New arg, specifying work frame. Use terminal-local Vselection_alist.
366 (some_frame_on_display): Delete unused function.
367 (Fx_own_selection_internal, Fx_get_selection_internal)
368 (Fx_disown_selection_internal, Fx_selection_owner_p)
369 (Fx_selection_exists_p): New optional frame arg.
370 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
371 (x_handle_selection_clear): Don't treat other terminals with the
372 same keyboard specially. Use the terminal-local Vselection_alist.
373 (x_clear_frame_selections): Use Frun_hook_with_args.
375 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
377 * xterm.h: Add support for those atoms.
379 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
381 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
382 (converted_selections, conversion_fail_tag): New global variables.
383 (x_selection_request_lisp_error): Free the above.
384 (x_get_local_selection): Remove unnecessary code.
385 (x_reply_selection_request): Args changed; handle arbitrary array
386 of converted selections stored in converted_selections.
387 Separate the XChangeProperty and SelectionNotify steps.
388 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
389 (x_convert_selection): New function.
390 (x_handle_selection_event): Simplify.
391 (x_get_foreign_selection): Don't ignore incoming requests while
392 waiting for an answer; this will fail when we implement
393 SAVE_TARGETS, and seems unnecessary anyway.
394 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
395 (Vx_sent_selection_functions): Doc fix.
397 2011-05-26 Leo Liu <sdl.web@gmail.com>
399 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
401 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
403 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
405 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
406 for fringe update if it has periodic bitmap.
407 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
408 and fringe_bitmap_periodic_p.
410 * fringe.c (get_fringe_bitmap_data): New function.
411 (draw_fringe_bitmap_1, update_window_fringes): Use it.
412 (update_window_fringes): Record periodicity of fringe bitmap in glyph
413 row. Mark glyph row for fringe update if periodicity changed.
415 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
416 for fringe update unless it has periodic bitmap.
418 2011-05-25 Kenichi Handa <handa@m17n.org>
420 * xdisp.c (get_next_display_element): Set correct it->face_id for
421 a static composition.
423 2011-05-24 Leo Liu <sdl.web@gmail.com>
426 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
428 * fns.c (crypto_hash_function, Fsha1): New function.
429 (Fmd5): Use crypto_hash_function.
430 (syms_of_fns): Add Ssha1.
432 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
434 * gnutls.c: Remove unused macros.
435 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
436 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
437 Remove macros that are defined and never used.
438 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
440 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
442 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
443 (Fx_get_selection_internal): Minor cleanup.
444 (Fx_own_selection_internal): Rename arguments for consistency with
447 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
449 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
451 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
453 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
455 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
457 * dispnew.c (scrolling_window): Don't exclude the case that the
458 last enabled row in the desired matrix touches the bottom boundary.
460 2011-05-21 Glenn Morris <rgm@gnu.org>
462 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
463 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
464 and add some more files.
466 2011-05-20 Eli Zaretskii <eliz@gnu.org>
468 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
469 report_file_error introduced by the change from 2011-05-07.
471 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
473 * systime.h (Time): Define only if emacs is defined.
474 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
475 where the include path doesn't have X11/X.h by default. See
476 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
478 2011-05-20 Kenichi Handa <handa@m17n.org>
480 * composite.c (find_automatic_composition): Fix previous change.
482 2011-05-20 Glenn Morris <rgm@gnu.org>
484 * lisp.mk: New file, split from Makefile.in.
485 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
487 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
489 2011-05-19 Glenn Morris <rgm@gnu.org>
491 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
492 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
493 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
494 (lisp): Set the order to that of loadup.el.
495 (shortlisp): Make it a copy of $lisp.
496 (SOME_MACHINE_LISP): Remove.
497 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
498 Use just $shortlisp, not $SOME_MACHINE_LISP too.
500 2011-05-18 Kenichi Handa <handa@m17n.org>
502 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
503 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
504 (find_automatic_composition): Mostly rewrite for efficiency.
506 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
508 * makefile.w32-in: Update dependencies.
510 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
512 * menu.c: Include limits.h (fixes the MS-Windows build broken by
515 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
517 Fix some integer overflow issues, such as string length overflow.
519 * insdel.c (count_size_as_multibyte): Check for string overflow.
521 * character.c (lisp_string_width): Check for string overflow.
522 Use EMACS_INT, not int, for string indexes and lengths; in
523 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
524 the resulting string length overflows an EMACS_INT; instead,
525 report a string overflow if no precision given. When checking for
526 precision exhaustion, use a check that cannot possibly have
527 integer overflow. (Bug#8675)
528 * character.h (lisp_string_width): Adjust to new signature.
530 * alloc.c (string_overflow): New function.
531 (Fmake_string): Use it. This doesn't change behavior, but saves
532 a few bytes and will simplify future changes.
533 * character.c (string_escape_byte8): Likewise.
534 * lisp.h (string_overflow): New decl.
536 Fixups, following up to the user-interface timestamp change.
537 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
538 for UI timestamps, instead of unsigned long.
539 * msdos.c (mouse_get_pos): Likewise.
540 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
541 * w32gui.h (Time): Define by including "systime.h" rather than by
542 declaring it ourselves. (Bug#8664)
544 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
545 * image.c (clear_image_cache): Likewise.
547 * term.c (term_mouse_position): Don't assume time_t wraparound.
549 Be more systematic about user-interface timestamps.
550 Before, the code sometimes used 'Time', sometimes 'unsigned long',
551 and sometimes 'EMACS_UINT', to represent these timestamps.
552 This change causes it to use 'Time' uniformly, as that's what X uses.
553 This makes the code easier to follow, and makes it easier to catch
554 integer overflow bugs such as Bug#8664.
555 * frame.c (Fmouse_position, Fmouse_pixel_position):
556 Use Time, not unsigned long, for user-interface timestamps.
557 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
558 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
559 * keyboard.h (last_event_timestamp): Likewise.
560 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
561 * menu.h (xmenu_show): Likewise.
562 * term.c (term_mouse_position): Likewise.
563 * termhooks.h (struct input_event.timestamp): Likewise.
564 (struct terminal.mouse_position_hook): Likewise.
565 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
566 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
567 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
568 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
570 * menu.h, termhooks.h: Include "systime.h", for Time.
572 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
573 Don't assume that the difference between two unsigned long values
574 can fit into an integer. At this point, we know button_down_time
575 <= event->timestamp, so the difference must be nonnegative, so
576 there's no need to cast the result if double-click-time is
577 nonnegative, as it should be; check that it's nonnegative, just in
578 case. This bug is triggered when events are more than 2**31 ms
579 apart (about 25 days). (Bug#8664)
581 * xselect.c (last_event_timestamp): Remove duplicate decl.
582 (x_own_selection): Remove needless cast to unsigned long.
584 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
585 that always fit in int. Use a sentinel instead of a counter, to
586 avoid a temp and to allay GCC's concerns about possible int overflow.
587 * frame.h (struct frame): Use int for menu_bar_items_used
588 instead of EMACS_INT, since it always fits in int.
590 * menu.c (grow_menu_items): Check for int overflow.
592 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
594 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
595 Before, the code was not consistent. These values cannot exceed
596 2**31 - 1 so there's no need to make them unsigned.
597 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
598 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
599 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
601 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
603 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
604 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
605 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
606 presumably because the widths might not match.
608 * window.c (size_window): Avoid needless test at loop start.
610 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
612 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
614 2011-05-12 Drew Adams <drew.adams@oracle.com>
616 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
618 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
620 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
621 `width' to `bar_area_x' and `bar_area_width', respectively.
622 (x_scroll_run): Take account of fringe background extension.
624 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
625 Rename local vars `left' and `width' to `bar_area_x' and
626 `bar_area_width', respectively.
627 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
628 background extension.
630 2011-05-10 Jim Meyering <meyering@redhat.com>
632 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
634 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
636 * image.c (Finit_image_library): Return t for built-in image types,
637 like pbm and xbm. (Bug#8640)
639 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
641 * w32menu.c (set_frame_menubar): Fix submenu allocation.
643 2011-05-07 Eli Zaretskii <eliz@gnu.org>
645 * w32console.c (Fset_screen_color): Doc fix.
646 (Fget_screen_color): New function.
647 (syms_of_ntterm): Defsubr it.
649 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
650 unlink the temporary file if Fcall_process didn't create it in the
652 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
653 child process will be redirected to a file specified with `:file'.
654 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
655 cue to call_process_cleanup not to close that handle.
657 2011-05-07 Ben Key <bkey76@gmail.com>
659 * makefile.w32-in: The bootstrap-temacs rule now makes use of
660 one of two shell specific rules, either bootstrap-temacs-CMD or
661 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
662 to the previous implementation of the bootstrap-temacs rule.
663 The bootstrap-temacs-CMD rule is similar to the previous
664 implementation of the bootstrap-temacs rule except that it
665 makes use of the ESC_CFLAGS variable instead of the CFLAGS
668 These changes, along with some changes to nt/configure.bat,
669 nt/gmake.defs, and nt/nmake.defs, are required to extend my
670 earlier fix to add support for --cflags and --ldflags options
671 that include quotes so that it works whether make uses cmd or
674 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
676 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
677 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
679 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
680 a string. Handle both cases.
681 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
682 (Fdbus_register_method): Use Qinvalid_function.
684 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
686 * makefile.w32-in: Update dependencies.
687 (LISP_H): Add inttypes.h and stdin.h.
688 (PROCESS_H): Add unistd.h.
690 2011-05-06 Eli Zaretskii <eliz@gnu.org>
692 * lread.c: Include limits.h (fixes the MS-Windows build broken by
693 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
695 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
697 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
699 * term.c (vfatal): Remove stray call to va_end.
700 It's not needed and the C Standard doesn't allow it here anyway.
702 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
703 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
705 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
708 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
710 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
712 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
714 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
716 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
718 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
719 * charset.c (Fdefine_charset_internal): Don't initialize
720 charset.code_space[15]. The value was garbage, on hosts with
721 32-bit int (Bug#8600).
723 * lread.c (read_integer): Be more consistent with string-to-number.
724 Use string_to_number to do the actual conversion; this avoids
725 rounding errors and fixes some other screwups. Without this fix,
726 for example, #x1fffffffffffffff was misread as -2305843009213693952.
727 (digit_to_number): Move earlier, for benefit of read_integer.
728 Return -1 if the digit is out of range for the base, -2 if it is
729 not a digit in any supported base. (Bug#8602)
731 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
733 * dispnew.c (scrolling_window): Return 1 if we scrolled,
734 to match comment at start of function. This also removes a
735 GCC warning about overflow in a 32+64-bit port.
737 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
739 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
740 Reported by Stefan Monnier in
741 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
742 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
743 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
745 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
746 (EMACS_UINTPTR): Likewise, with uintptr_t.
748 * lisp.h: Prefer 64-bit EMACS_INT if available.
749 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
750 on 32-bit hosts that have 64-bit int, so that they can access
752 However, temporarily disable this change unless the temporary
753 symbol WIDE_EMACS_INT is defined.
755 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
757 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
758 This removes an assumption that EMACS_INT and long are the same
759 width as pointers. The assumption is true for Emacs porting targets
760 now, but we want to make other targets possible.
761 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
762 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
763 In the rest of the code, change types of integers that hold casted
764 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
765 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
766 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
767 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
768 No need to cast type when ORing.
769 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
770 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
771 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
772 assume EMACS_INT is the same width as char *.
773 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
774 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
775 Remove no-longer-needed casts.
776 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
777 (xg_tool_bar_help_callback, xg_make_tool_item):
778 Use EMACS_INTPTR to hold an integer
779 that will be cast to void *; this can avoid a GCC warning
780 if EMACS_INT is not the same width as void *.
781 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
782 * xdisp.c (display_echo_area_1, resize_mini_window_1):
783 (current_message_1, set_message_1):
784 Use a local to convert to proper width without a cast.
785 * xmenu.c (dialog_selection_callback): Likewise.
787 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
788 Also, don't assume VALBITS / RAND_BITS is less than 5,
789 and don't rely on undefined behavior when shifting a 1 left into
791 * lisp.h (get_random): Change signature to match.
793 * lread.c (hash_string): Use size_t, not int, for hash computation.
794 Normally we prefer signed values; but hashing is special, because
795 it's better to use unsigned division on hash table sizes so that
796 the remainder is nonnegative. Also, size_t is the natural width
797 for hashing into memory. The previous code used 'int', which doesn't
798 retain enough info to hash well into very large tables.
799 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
801 * dbusbind.c: Don't possibly lose pointer info when converting.
802 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
803 Use XPNTR rather than XHASH, so that the high-order bits of
804 the pointer aren't lost when converting through void *.
806 * eval.c (Fautoload): Don't double-shift a pointer.
808 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
810 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
812 * gnutls.c (DEF_GNUTLS_FN):
813 * image.c (DEF_IMGLIB_FN): Make function pointers static.
815 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
817 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
820 2011-05-05 Eli Zaretskii <eliz@gnu.org>
822 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
823 New version that can reserve upto 2GB of heap space.
825 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
827 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
829 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
831 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
832 `gnutls_certificate_set_x509_key_file'.
834 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
836 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
839 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
841 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
842 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
843 Remove unused parameter `fildes'.
844 * process.c (read_process_output, send_process): Don't pass it.
846 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
848 Fix previous change: the library cache is defined in w32.c.
849 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
850 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
852 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
854 Implement dynamic loading of GnuTLS on Windows.
856 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
857 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
858 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
861 * gnutls.c (Qgnutls_dll): Define.
862 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
863 (gnutls_*): Declare function pointers.
864 (init_gnutls_functions): New function to initialize function pointers.
865 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
866 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
867 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
868 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
869 (emacs_gnutls_write, emacs_gnutls_read)
870 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
871 (Fgnutls_available_p): New function.
872 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
873 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
874 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
876 * image.c: Include w32.h.
877 (Vimage_type_cache): Delete.
878 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
879 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
880 (w32_delayed_load): Move to w32.c.
882 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
884 * w32.c (QCloaded_from, Vlibrary_cache): Define.
885 (w32_delayed_load): Move from image.c. When loading a library, record
886 its filename in the :loaded-from property of the library id.
887 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
888 Initialize and staticpro them.
889 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
891 * process.c: Include lisp.h before w32.h, not after.
892 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
893 instead of gnutls_record_check_pending.
895 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
897 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
899 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
900 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
903 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
905 * xterm.c (x_set_frame_alpha): Do not set property on anything
906 else than FRAME_X_OUTER_WINDOW (Bug#8608).
908 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
910 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
912 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
914 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
915 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
916 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
917 (gnutls_global_initialized, Qgnutls_bootprop_priority)
918 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
919 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
920 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
921 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
922 (Qgnutls_bootprop_callbacks_verify): Make static.
924 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
926 * callproc.c: Indentation fixup.
928 * sysdep.c (wait_for_termination_1): Make static.
929 (wait_for_termination, interruptible_wait_for_termination):
930 Move after wait_for_termination_1.
932 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
934 * sysdep.c (interruptible_wait_for_termination): New function
935 which is like wait_for_termination, but allows keyboard
938 * callproc.c (Fcall_process): Add (:file "file") as an option for
940 (Fcall_process_region): Ditto.
942 2011-04-30 Eli Zaretskii <eliz@gnu.org>
944 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
945 rather than `XVECTOR (FOO)->size'.
947 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
948 inttypes.h, as a gnulib replacement is used if it not available in
951 2011-04-21 Eli Zaretskii <eliz@gnu.org>
953 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
954 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
955 of MOST_POSITIVE_FIXNUM. (Bug#8528)
957 * coding.c (coding_alloc_by_realloc): Error out if destination
958 will grow beyond MOST_POSITIVE_FIXNUM.
959 (decode_coding_emacs_mule): Abort if there isn't enough place in
960 charbuf for the composition carryover bytes. Reserve an extra
961 space for up to 2 characters produced in a loop.
962 (decode_coding_iso_2022): Abort if there isn't enough place in
963 charbuf for the composition carryover bytes.
965 2011-04-21 Eli Zaretskii <eliz@gnu.org>
967 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
968 aborting when %lld or %lll format is passed.
969 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
970 %llo or %llx format is passed. (Bug#8545)
972 * window.c (window_scroll_line_based): Use a marker instead of
973 simple variables to record original value of point. (Bug#7952)
975 * doprnt.c (doprnt): Fix the case where a multibyte sequence
976 produced by %s or %c overflows available buffer space. (Bug#8545)
978 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
980 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
981 (SIZE_MAX): Move defn after all includes, as they might #define it.
983 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
985 * w32.c (init_environment): Warn about defaulting HOME to C:\.
987 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
989 * keyboard.c (Qdelayed_warnings_hook): Define.
990 (command_loop_1): Run `delayed-warnings-hook'
991 if Vdelayed_warnings_list is non-nil.
992 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
993 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
995 2011-04-28 Eli Zaretskii <eliz@gnu.org>
997 * doprnt.c (doprnt): Don't return value smaller than the buffer
998 size if the message was truncated. (Bug#8545).
1000 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1002 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1003 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1005 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1007 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1009 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
1011 * makefile.w32-in: Update dependencies.
1013 2011-04-27 Eli Zaretskii <eliz@gnu.org>
1015 Improve `doprnt' and its usage. (Bug#8545)
1016 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1017 `format_end'. Remove support for %l as a conversion specifier.
1018 Don't use xrealloc. Improve diagnostics when the %l size modifier
1019 is used. Update the commentary.
1021 * eval.c (verror): Simplify calculation of size_t.
1023 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1026 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1028 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1031 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1033 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1034 This makes this file independent of the recent pseudovector change.
1036 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
1038 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1040 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
1041 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
1042 Remove unused local.
1043 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
1045 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
1046 GCC 4.6.0 optimizes based on type-based alias analysis.
1047 For example, if b is of type struct buffer * and v of type struct
1048 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1049 != &v->size, and therefore "v->size = 1; b->size = 2; return
1050 v->size;" must therefore return 1. This assumption is incorrect
1051 for Emacs, since it type-puns struct Lisp_Vector * with many other
1052 types. To fix this problem, this patch adds a new type struct
1053 vectorlike_header that documents the constraints on layout of vectors
1054 and pseudovectors, and helps optimizing compilers not get fooled
1055 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1056 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
1057 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1059 (XSETPVECTYPE): Rewrite in terms of new macro.
1060 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1061 This is a bit clearer, and further avoids the possibility of
1062 undesirable aliasing.
1063 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
1064 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
1065 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1066 since Lisp_Subr is a special case (no "next" field).
1067 (ASIZE): Now uses header.size rather than size.
1068 All previous uses of XVECTOR (foo)->size replaced to use this macro,
1069 to avoid the hassle of writing XVECTOR (foo)->header.size.
1070 (struct vectorlike_header): New type.
1071 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1072 object, to help avoid aliasing.
1073 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1074 (SUBRP): Likewise, since Lisp_Subr is a special case.
1075 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1076 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1077 (struct Lisp_Hash_Table): Combine first two members into a single
1078 struct vectorlike_header member. All uses of "size" and "next" members
1079 changed to be "header.size" and "header.next".
1080 * buffer.h (struct buffer): Likewise.
1081 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1082 * frame.h (struct frame): Likewise.
1083 * process.h (struct Lisp_Process): Likewise.
1084 * termhooks.h (struct terminal): Likewise.
1085 * window.c (struct save_window_data, struct saved_window): Likewise.
1086 * window.h (struct window): Likewise.
1087 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1088 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1089 * buffer.c (init_buffer_once): Likewise.
1090 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1092 * process.c (Fformat_network_address): Use local var for size,
1095 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1097 Make the Lisp reader and string-to-float more consistent (Bug#8525)
1098 * data.c (atof): Remove decl; no longer used or needed.
1099 (digit_to_number): Move to lread.c.
1100 (Fstring_to_number): Use new string_to_number function, to be
1101 consistent with how the Lisp reader treats infinities and NaNs.
1102 Do not assume that floating-point numbers represent EMACS_INT
1103 without losing information; this is not true on most 64-bit hosts.
1104 Avoid double-rounding errors, by insisting on integers when
1105 parsing non-base-10 numbers, as the documentation specifies.
1106 * lisp.h (string_to_number): New decl, replacing ...
1107 (isfloat_string): Remove.
1108 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
1109 (read1): Do not accept +. and -. as integers; this
1110 appears to have been a coding error. Similarly, do not accept
1111 strings like +-1e0 as floating point numbers. Do not report
1112 overflow for integer overflows unless the base is not 10 which
1113 means we have no simple and reliable way to continue.
1114 Break out the floating-point parsing into a new
1115 function string_to_number, so that Fstring_to_number parses
1116 floating point numbers consistently with the Lisp reader.
1117 (digit_to_number): Move here from data.c. Make it static inline.
1118 (E_CHAR, EXP_INT): Remove, replacing with ...
1119 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1120 (string_to_number): New function, replacing isfloat_string.
1121 This function checks for valid syntax and produces the resulting
1122 Lisp float number too. Rework it so that string-to-number
1123 no longer mishandles examples like "1.0e+". Use strtoumax,
1124 so that overflow for non-base-10 numbers is reported only when
1125 there's no portable and simple way to convert to floating point.
1127 * textprop.c (set_text_properties_1): Rewrite for clarity,
1128 and to avoid GCC warning about integer overflow.
1130 * intervals.h (struct interval): Use EMACS_INT for members
1131 where EMACS_UINT might cause problems. See
1132 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
1133 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
1134 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
1136 (offset_intervals): Tell GCC not to worry about length overflow
1137 when negating a negative length.
1139 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
1140 (overrun_check_free): Likewise.
1142 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
1143 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
1146 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1147 (gnutls_make_error): Rename local to avoid shadowing.
1148 (gnutls_emacs_global_deinit): ifdef out; not used.
1149 (Fgnutls_boot): Use const for pointer to readonly storage.
1150 Comment out unused local. Fix pointer signedness problems.
1152 * lread.c (openp): Don't stuff size_t into an 'int'.
1153 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
1154 about possible signed overflow.
1156 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1157 (GDK_KEY_g): Don't define if already defined.
1158 (xg_prepare_tooltip): Avoid pointer signedness problem.
1159 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
1161 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
1162 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
1164 * xfns.c (Fx_window_property): Simplify a bit,
1165 to make a bit faster and to avoid GCC 4.6.0 warning.
1166 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
1168 * fns.c (internal_equal): Don't assume size_t fits in int.
1170 * alloc.c (compact_small_strings): Tighten assertion a little.
1172 Replace pEd with more-general pI, and fix some printf arg casts.
1173 * lisp.h (pI): New macro, generalizing old pEd macro to other
1174 conversion specifiers. For example, use "...%"pI"d..." rather
1175 than "...%"pEd"...".
1176 (pEd): Remove. All uses replaced with similar uses of pI.
1177 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
1178 * alloc.c (check_pure_size): Don't overflow by converting size to int.
1179 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
1180 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
1181 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
1182 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
1183 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
1185 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
1186 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
1187 * print.c (safe_debug_print, print_object): Likewise.
1188 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
1190 Use pI instead of if-then-else-abort. Use %p to avoid casts,
1191 avoiding the 0 flag, which is not portable.
1192 * process.c (Fmake_network_process): Use pI to avoid cast.
1193 * region-cache.c (pp_cache): Likewise.
1194 * xdisp.c (decode_mode_spec): Likewise.
1195 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
1196 behavior on 64-bit hosts with printf arg.
1197 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
1198 (x_stop_queuing_selection_requests): Likewise.
1199 (x_get_window_property): Don't truncate byte count to an 'int'
1202 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
1203 here, since it parses constructs like leading '-' and spaces,
1204 which are not wanted; and it overflows with large numbers.
1205 Instead, simply match F[0-9]+, which is what is wanted anyway.
1207 * alloc.c: Remove unportable assumptions about struct layout.
1208 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
1209 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
1210 (allocate_vectorlike, make_pure_vector): Use the new macros,
1211 plus offsetof, to remove unportable assumptions about struct layout.
1212 These assumptions hold on all porting targets that I know of, but
1213 they are not guaranteed, they're easy to remove, and removing them
1214 makes further changes easier.
1216 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
1217 This doesn't fix a bug but makes the code clearer.
1218 (string_overrun_cookie): Now const. Use initializers that
1219 don't formally overflow signed char, to avoid warnings.
1220 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
1221 can cause Emacs to crash when string overrun checking is enabled.
1222 (allocate_buffer): Don't assume sizeof (struct buffer) is a
1223 multiple of sizeof (EMACS_INT); it need not be, if
1224 alignof(EMACS_INT) < sizeof (EMACS_INT).
1225 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
1227 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
1229 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1231 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1233 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
1234 supposed to be handshaking. (Bug#8556)
1235 Reported by Paul Eggert <eggert@cs.ucla.edu>.
1237 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
1239 * lisp.h (Qdebug): List symbol.
1240 * eval.c (Qdebug): Restore global linkage.
1241 * keyboard.c (debug-on-event): New variable.
1242 (handle_user_signal): Break into debugger when debug-on-event
1243 matches the current signal symbol.
1245 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
1247 * alloc.c (check_sblock, check_string_bytes)
1248 (check_string_free_list): Convert to standard C.
1250 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
1252 * w32.c (emacs_gnutls_push): Fix typo.
1254 2011-04-25 Eli Zaretskii <eliz@gnu.org>
1256 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
1257 "cast to pointer from integer of different size".
1259 Improve doprnt and its use in verror. (Bug#8545)
1260 * doprnt.c (doprnt): Document the set of format control sequences
1261 supported by the function. Use SAFE_ALLOCA instead of always
1264 * eval.c (verror): Don't limit the buffer size at size_max-1, that
1265 is one byte too soon. Don't use xrealloc; instead xfree and
1268 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
1270 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
1273 * gnutls.c: Renamed global_initialized to
1274 gnutls_global_initialized. Added internals for the
1275 :verify-hostname-error, :verify-error, and :verify-flags
1276 parameters of `gnutls-boot' and documented those parameters in the
1277 docstring. Start callback support.
1278 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
1279 unless a fatal error occured. Call gnutls_alert_send_appropriate
1280 on error. Return error code.
1281 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
1282 (emacs_gnutls_read): Likewise.
1283 (Fgnutls_boot): Return handshake error code.
1284 (emacs_gnutls_handle_error): New function.
1285 (wsaerror_to_errno): Likewise.
1287 * w32.h (emacs_gnutls_pull): Add prototype.
1288 (emacs_gnutls_push): Likewise.
1290 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
1291 (emacs_gnutls_push): Likewise.
1293 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
1295 * process.c (wait_reading_process_output): Check if GnuTLS
1296 buffered some data internally if no FDs are set for TLS
1299 * makefile.w32-in (OBJ2): Add gnutls.$(O).
1300 (LIBS): Link to USER_LIBS.
1301 ($(BLD)/gnutls.$(0)): New target.
1303 2011-04-24 Eli Zaretskii <eliz@gnu.org>
1305 * xdisp.c (handle_single_display_spec): Rename the
1306 display_replaced_before_p argument into display_replaced_p, to
1307 make it consistent with the commentary. Fix typos in the
1310 * textprop.c (syms_of_textprop): Remove dead code.
1311 (copy_text_properties): Delete obsolete commentary about an
1312 interface that was deleted long ago. Fix typos in the description
1315 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
1316 to changes in oldXMenu/XMenu.h from 2011-04-16.
1317 <menu_help_message, prev_menu_help_message>: Constify.
1318 (IT_menu_make_room): menu->help_text is now `const char **';
1321 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
1322 to changes in oldXMenu/XMenu.h from 2011-04-16.
1323 (struct XMenu): Declare `help_text' `const char **'.
1325 * xfaces.c <Qunspecified>: Make extern again.
1327 * syntax.c: Include sys/types.h before including regex.h, as
1330 * doc.c (get_doc_string): Improve the format passed to `error'.
1332 * doprnt.c (doprnt): Improve commentary.
1334 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
1336 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
1339 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
1340 changes in globals.h immediately force recompilation.
1341 (TAGS): Depend on $(CURDIR)/m/intel386.h and
1342 $(CURDIR)/s/ms-w32.h.
1343 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
1345 * character.c (Fchar_direction): Function deleted.
1346 (syms_of_character): Don't defsubr it.
1347 <char-direction-table>: Deleted.
1349 2011-04-23 Eli Zaretskii <eliz@gnu.org>
1351 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
1352 * doprnt.c: Include limits.h.
1353 (SIZE_MAX): New macro.
1354 (doprnt): Return a size_t value. 2nd arg is now size_t.
1355 Many local variables are now size_t instead of int or unsigned.
1356 Improve overflow protection. Support `l' modifier for integer
1357 conversions. Support %l conversion. Don't assume an EMACS_INT
1358 argument for integer conversions and for %c.
1360 * lisp.h (doprnt): Restore prototype.
1362 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
1365 * Makefile.in (base_obj): Add back doprnt.o.
1367 * deps.mk (doprnt.o): Add back prerequisites.
1368 (callint.o): Depend on character.h.
1370 * eval.c (internal_lisp_condition_case): Include the handler
1371 representation in the error message.
1372 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1373 when breaking from the loop.
1375 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1377 * callint.c (Fcall_interactively): When displaying error message
1378 about invalid control letter, pass the character's codepoint, not
1379 a pointer to its multibyte form. Improve display of the character
1380 in octal and display also its hex code.
1382 * character.c (char_string): Use %x to display the (unsigned)
1383 codepoint of an invalid character, to avoid displaying a bogus
1386 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1387 `error', not SYMBOL_NAME itself.
1389 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1390 character arguments to `error'.
1392 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1393 to `error' in error message about FINAL_CHAR argument. Make sure
1394 FINAL_CHAR is a character, and use %c when it is passed as
1395 argument to `error'.
1397 2011-04-23 Eli Zaretskii <eliz@gnu.org>
1399 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1401 * w32.c: Include <time.h>.
1402 (sys_localtime): New function.
1404 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
1406 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1408 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
1410 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
1412 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1415 2011-04-19 Eli Zaretskii <eliz@gnu.org>
1417 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1418 gl_state.e_property when gl_state.object is Qt.
1420 * insdel.c (make_gap_larger): Remove limitation of buffer size
1423 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
1425 * xdisp.c (lookup_glyphless_char_display)
1426 (produce_glyphless_glyph): Handle cons cell entry in
1427 glyphless-char-display.
1428 (Vglyphless_char_display): Document it.
1430 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1431 glyphless-char-display.
1433 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
1435 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
1437 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1439 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
1440 definition for no-X builds.
1442 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
1444 Static checks with GCC 4.6.0 and non-default toolkits.
1446 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1448 * process.c (keyboard_bit_set): Define only if SIGIO.
1449 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
1450 (send_process): Repair possible setjmp clobbering.
1452 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
1454 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1456 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
1458 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
1459 Define only if needed.
1461 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
1462 by pacifying GCC about it. Maybe it's time to retire it?
1463 * xfaces.c (USG, __TIMEVAL__): Likewise.
1465 * dispextern.h (struct redisplay_interface): Rename param
1467 * termhooks.h (struct terminal): Likewise.
1468 * xterm.c (xembed_send_message): Likewise.
1470 * insdel.c (make_gap_smaller): Define only if
1471 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
1473 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
1476 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
1477 so that we aren't warned about unused symbols.
1479 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
1481 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
1483 * xfns.c (x_real_positions): Mark locals as initialized.
1485 * xmenu.c (xmenu_show): Don't use uninitialized vars.
1487 * xterm.c: Fix problems found by static analysis with other toolkits.
1488 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
1489 (x_dispatch_event): Declare static if USE_GTK, and
1490 define if USE_GTK || USE_X_TOOLKIT.
1491 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
1492 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
1493 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
1494 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
1496 * xmenu.c (menu_help_callback): Pointer type fixes.
1497 Use const pointers when pointing at readonly data. Avoid pointer
1499 (FALSE): Remove unused macro.
1500 (update_frame_menubar): Remove unused decl.
1502 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
1504 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
1505 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
1506 (single_menu_item): Rename local to avoid shadowing.
1508 * keyboard.c (make_lispy_event): Remove unused local var.
1510 * frame.c, frame.h (x_get_resource_string): Bring this back, but
1511 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
1513 * bitmaps: Change bitmaps from unsigned char back to the X11
1514 compatible char. Avoid the old compiler warnings about
1515 out-of-range initializers by using, for example, '\xab' rather
1518 * xgselect.c (xgselect_initialize): Check vs interface
1519 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
1521 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
1523 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
1524 to read-only memory.
1526 * fns.c (vector): Remove; this old hack is no longer needed.
1528 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
1530 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
1532 * xrdb.c (x_load_resources): Omit unused local.
1534 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
1535 (x_window): Rename locals to avoid shadowing.
1536 (USG): Use the kludged USG macro, to pacify gcc.
1538 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
1539 (x_term_init): Remove local to avoid shadowing.
1541 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
1543 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
1544 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
1546 2011-04-16 Eli Zaretskii <eliz@gnu.org>
1548 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
1550 Fix regex.c, syntax.c and friends for buffers > 2GB.
1551 * syntax.h (struct gl_state_s): Declare character position members
1554 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
1556 * textprop.c (verify_interval_modification, interval_of):
1557 Declare arguments EMACS_INT.
1559 * intervals.c (adjust_intervals_for_insertion): Declare arguments
1562 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
1564 * indent.c (Fvertical_motion): Local variable it_start is now
1567 * regex.c (re_match, re_match_2, re_match_2_internal)
1568 (bcmp_translate, regcomp, regexec, print_double_string)
1569 (group_in_compile_stack, re_search, re_search_2, regex_compile)
1570 (re_compile_pattern, re_exec): Declare arguments and local
1571 variables `size_t' and `ssize_t' and return values `regoff_t', as
1573 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
1574 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
1575 <compile_stack_type>: `size' and `avail' are now `size_t'.
1577 * regex.h <regoff_t>: Use ssize_t, not int.
1578 (re_search, re_search_2, re_match, re_match_2): Arguments that
1579 specify buffer/string position and length are now ssize_t and
1580 size_t. Return type is regoff_t.
1582 2011-04-16 Ben Key <bkey76@gmail.com>
1584 * nsfont.m: Fixed bugs in ns_get_family and
1585 ns_descriptor_to_entity that were caused by using free to
1586 deallocate memory blocks that were allocated by xmalloc (via
1587 xstrdup). This caused Emacs to crash when compiled with
1588 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
1589 --enable-checking=xmallocoverrun). xfree is now used to
1590 deallocate these memory blocks.
1592 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
1594 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1596 emacs_write: Accept and return EMACS_INT for sizes.
1597 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1599 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1600 Accept and return EMACS_INT.
1601 (emacs_gnutls_write): Return the number of bytes written on
1603 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
1604 (emacs_read, emacs_write): Remove check for negative size, as the
1605 Emacs source code has been audited now.
1606 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1607 (emacs_read, emacs_write): Use it.
1608 * process.c (send_process): Adjust to the new signatures of
1609 emacs_write and emacs_gnutls_write. Do not attempt to store
1610 a byte offset into an 'int'; it might overflow.
1611 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
1613 * sound.c: Don't assume sizes fit in 'int'.
1614 (struct sound_device.period_size, alsa_period_size):
1615 Return EMACS_INT, not int.
1616 (struct sound_device.write, vox_write, alsa_write):
1617 Accept EMACS_INT, not int.
1618 (wav_play, au_play): Use EMACS_INT to store sizes and to
1619 record read return values.
1621 2011-04-15 Ben Key <bkey76@gmail.com>
1623 * keyboard.c (Qundefined): Don't declare static since it is used
1625 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1626 static since they are used in nsfont.m.
1628 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1630 * process.c (Qprocessp): Don't declare static.
1631 * lisp.h (Qprocessp): Declare again.
1633 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
1635 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1637 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1639 Improve C-level modularity by making more things 'static'.
1641 Don't publish debugger-only interfaces to other modules.
1642 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1643 (verify_bytepos, count_markers): Move decls to the only modules
1645 * region-cache.h (pp_cache): Likewise.
1646 * window.h (check_all_windows): Likewise.
1647 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1649 * sysdep.c (croak): Now static, if
1650 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1651 * syssignal.h (croak): Declare only if not static.
1653 * alloc.c (refill_memory_reserve): Now static if
1654 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1655 * lisp.h (refill_memory_reserve): Declare only if not static.
1657 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1658 Define only if USE_LUCID.
1660 * xrdb.c (x_customization_string, x_rm_string): Now static.
1662 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1663 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1665 * xdisp.c (draw_row_with_mouse_face): Now static.
1666 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1668 * window.h (check_all_windows): Mark externally visible.
1670 * window.c (window_deletion_count): Now static.
1672 * undo.c: Make symbols static if they're not exported.
1673 (last_undo_buffer, last_boundary_position, pending_boundary):
1676 * textprop.c (interval_insert_behind_hooks): Now static.
1677 (interval_insert_in_front_hooks): Likewise.
1679 * term.c: Make symbols static if they're not exported.
1680 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
1681 (max_frame_lines, tty_set_terminal_modes):
1682 (tty_reset_terminal_modes, tty_turn_off_highlight):
1683 (get_tty_terminal): Now static.
1684 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
1685 * termhooks.h (term_mouse_moveto): Do not declare if
1687 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
1688 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
1690 * sysdep.c: Make symbols static if they're not exported.
1691 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
1693 (sigprocmask_set, full_mask): Remove; unused.
1694 (wait_debugging): Mark as visible.
1695 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
1696 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
1698 * syntax.c (syntax_temp): Define only if !__GNUC__.
1700 * sound.c (current_sound_device, current_sound): Now static.
1702 * search.c (searchbufs, searchbuf_head): Now static.
1704 * scroll.c (scroll_cost): Remove; unused.
1705 * dispextern.h (scroll_cost): Remove decl.
1707 * region-cache.h (pp_cache): Mark as externally visible.
1709 * process.c: Make symbols static if they're not exported.
1710 (process_tick, update_tick, create_process, chan_process):
1711 (Vprocess_alist, proc_buffered_char, datagram_access):
1712 (fd_callback_data, send_process_frame, process_sent_to): Now static.
1713 (deactivate_process): Mark defn as static, as well as decl.
1714 * lisp.h (create_process): Remove decl.
1715 * process.h (chan_process, Vprocess_alist): Remove decls.
1717 * print.c: Make symbols static if they're not exported.
1718 (print_depth, new_backquote_output, being_printed, print_buffer):
1719 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
1720 (print_interval, print_number_index, initial_stderr_stream):
1722 * lisp.h (Fprinc): Remove decl.
1723 (debug_output_compilation_hack): Mark as externally visible.
1725 * sysdep.c (croak): Move decl from here to syssignal.h.
1726 * syssignal.h (croak): Put it here, so the API can be checked when
1727 'croak' is called from dissociate_if_controlling_tty.
1729 * minibuf.c: Make symbols static if they're not exported.
1730 (minibuf_save_list, choose_minibuf_frame): Now static.
1731 * lisp.h (choose_minibuf_frame): Remove decl.
1733 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
1735 * lread.c: Make symbols static if they're not exported.
1736 (read_objects, initial_obarray, oblookup_last_bucket_number):
1738 (make_symbol): Remove; unused.
1739 * lisp.h (initial_obarray, make_symbol): Remove decls.
1741 * keyboard.c: Make symbols static if they're not exported.
1742 (single_kboard, recent_keys_index, total_keys, recent_keys):
1743 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
1744 (this_single_command_key_start, echoing, last_auto_save):
1745 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
1746 (command_loop, echo_now, keyboard_init_hook, help_char_p):
1747 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
1748 (Vlispy_mouse_stem, double_click_count):
1750 (force_auto_save_soon): Define only if SIGDANGER.
1751 (ignore_mouse_drag_p): Now static if
1752 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
1753 (print_help): Remove; unused.
1754 (stop_character, last_timer_event): Mark as externally visible.
1755 * keyboard.h (ignore_mouse_drag_p): Declare only if
1756 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
1757 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
1758 * lisp.h (echoing): Remove decl.
1759 (force_auto_save_soon): Declare only if SIGDANGER.
1760 * xdisp.c (redisplay_window): Simplify code, to make it more
1761 obvious that ignore_mouse_drag_p is not accessed if !defined
1762 USE_GTK && !defined HAVE_NS.
1764 * intervals.c: Make symbols static if they're not exported.
1765 (merge_properties_sticky, merge_interval_right, delete_interval):
1767 * intervals.h (merge_interval_right, delete_interval): Remove decls.
1769 * insdel.c: Make symbols static if they're not exported.
1770 However, leave prepare_to_modify_buffer alone. It's never
1771 called from outside this function, but that appears to be a bug.
1772 (combine_after_change_list, combine_after_change_buffer):
1773 (adjust_after_replace, signal_before_change): Now static.
1774 (adjust_after_replace_noundo): Remove; unused.
1775 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
1776 (signal_before_change): Remove decls.
1778 * indent.c (val_compute_motion, val_vmotion): Now static.
1780 * image.c: Make symbols static if they're not exported.
1781 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
1783 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
1784 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
1786 * fringe.c (standard_bitmaps): Now static.
1787 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
1789 * frame.c: Make symbols static if they're not exported.
1790 (x_report_frame_params, make_terminal_frame): Now static.
1791 (get_frame_param): Now static, unless HAVE_NS.
1792 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
1793 (x_get_resource_string): Remove; not used.
1794 * frame.h (make_terminal_frame, x_report_frame_params):
1795 (x_get_resource_string); Remove decls.
1796 (x_fullscreen_adjust): Declare only if WINDOWSNT.
1797 * lisp.h (get_frame_param): Declare only if HAVE_NS.
1799 * font.c, fontset.c: Make symbols static if they're not exported.
1800 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
1801 (FACE_SUITABLE_FOR_CHAR_P): Use it.
1802 * font.c (font_close_object): Now static.
1803 * font.h (font_close_object): Remove.
1804 * fontset.c (FONTSET_OBJLIST): Remove.
1805 (free_realized_fontset) #if-0 the body, which does nothing.
1806 (face_suitable_for_char_p): #if-0, as it's never called.
1807 * fontset.h (face_suitable_for_char_p): Remove decl.
1808 * xfaces.c (face_at_string_position):
1809 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
1810 since 0 is always ASCII.
1812 * fns.c (weak_hash_tables): Now static.
1814 * fileio.c: Make symbols static if they're not exported.
1815 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
1816 (Vwrite_region_annotation_buffers): Now static.
1818 * eval.c: Make symbols static if they're not exported.
1819 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
1820 * lisp.h (backtrace_list): Remove decl.
1822 * emacs.c: Make symbols static if they're not exported.
1823 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
1824 (fatal_error_code, fatal_error_signal_hook, standard_args):
1826 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
1827 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
1828 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
1829 * lisp.h (fatal_error_signal_hook): Remove decl.
1830 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
1832 * editfns.c: Move a (normally-unused) function to its only use.
1833 * editfns.c, lisp.h (get_operating_system_release): Remove.
1834 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
1835 worth the hassle of breaking this out.
1837 * xterm.c: Make symbols static if they're not exported.
1838 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
1839 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
1840 (x_destroy_window, x_delete_display):
1842 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
1843 (x_mouse_leave): Remove; unused.
1844 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
1845 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
1846 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
1848 (x_mouse_leave): Declare only if WINDOWSNT.
1849 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
1850 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
1853 * ftxfont.c: Make symbols static if they're not exported.
1854 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
1856 * font.h (ftxfont_driver): Likewise.
1858 * xfns.c: Make symbols static if they're not exported.
1859 (x_last_font_name, x_display_info_for_name):
1860 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
1861 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
1862 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
1863 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
1864 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
1865 (last_show_tip_args): Now static.
1866 (xic_defaut_fontset, xic_create_fontsetname): Define only if
1867 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
1868 (x_screen_planes): Remove; unused.
1869 * dispextern.h (x_screen_planes): Remove decl.
1871 * dispnew.c: Make symbols static if they're not exported.
1872 * dispextern.h (redraw_garbaged_frames, scrolling):
1873 (increment_row_positions): Remove.
1874 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
1875 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
1877 (redraw_garbaged_frames): Remove; unused.
1879 * xfaces.c: Make symbols static if they're not exported.
1880 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
1882 * xterm.h (defined_color): Remove decls.
1883 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
1884 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
1885 (menu_face_changed_default, defined_color, free_realized_face):
1886 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
1887 (ascii_face_of_lisp_face): Remove; unused.
1889 * xdisp.c: Make symbols static if they're not exported.
1890 * dispextern.h (scratch_glyph_row, window_box_edges):
1891 (glyph_to_pixel_coords, set_cursor_from_row):
1892 (get_next_display_element, set_iterator_to_next):
1893 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
1894 (show_mouse_face): Remove decls
1895 * frame.h (message_buf_print): Likewise.
1896 * lisp.h (pop_message, set_message, check_point_in_composition):
1898 * xterm.h (set_vertical_scroll_bar): Likewise.
1899 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
1900 (message_buf_print, scratch_glyph_row, displayed_buffer):
1901 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
1902 (get_next_display_element, show_mouse_face, window_box_edges):
1903 (frame_to_window_pixel_xy, check_point_in_composition):
1904 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
1905 (glyph_to_pixel_coords): Remove; unused.
1907 * dired.c (file_name_completion): Now static.
1909 * dbusbind.c (xd_in_read_queued_messages): Now static.
1911 * lisp.h (circular_list_error, FOREACH): Remove; unused.
1912 * data.c (circular_list_error): Remove.
1914 * commands.h (last_point_position, last_point_position_buffer):
1915 (last_point_position_window): Remove decls.
1916 * keyboard.c: Make these variables static.
1918 * coding.h (coding, code_convert_region, encode_coding_gap):
1920 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
1921 (iso_code_class, detect_coding, code_convert_region): Now static.
1922 (encode_coding_gap): Remove; unused.
1924 * chartab.c (chartab_chars, chartab_bits): Now static.
1926 * charset.h (charset_iso_8859_1): Remove decl.
1927 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
1930 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
1931 * ccl.c (Vccl_program_table): Now static.
1932 (check_ccl_update): Remove; unused.
1934 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
1935 * category.h: ... from here.
1936 * category.c (check_category_table, set_category_set): Now static.
1938 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
1939 * lisp.h: Remove these decls.
1941 * buffer.c (buffer_count): Remove unused var.
1943 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
1944 so that it's not optimized away.
1945 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
1946 * dispextern.h (bidi_dump_cached_states): Remove, since it's
1947 exported only to the debugger.
1949 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
1950 * atimer.h (run_all_atimers): Remove; not exported.
1952 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
1953 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
1954 was inaccessible from Lisp.
1955 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
1956 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
1958 alloc.c: Import and export fewer symbols, and remove unused items.
1959 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
1961 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
1962 it's not optimized away by whole-program optimization.
1963 (message_enable_multibyte, free_misc): Remove.
1964 (catchlist, handlerlist, mark_backtrace):
1965 Declare only if BYTE_MARK_STACK.
1966 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
1967 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
1968 (message_enable_multibyte): Remove decl.
1969 (free_misc, interval_free_list, float_block, float_block_index):
1970 (n_float_blocks, float_free_list, cons_block, cons_block_index):
1971 (cons_free_list, last_marked_index):
1973 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
1974 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
1975 (mark_backtrace): Define only if BYTE_MARK_STACK.
1976 * xdisp.c (message_enable_multibyte): Now static.
1978 Declare Lisp_Object Q* variables to be 'static' if not exported.
1979 This makes it easier for human readers (and static analyzers)
1980 to see whether these variables are used from other modules.
1981 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
1982 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
1983 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
1984 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
1985 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
1986 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
1987 * xmenu.c, xselect.c:
1988 Declare Q* vars static if they are not used in other modules.
1989 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
1990 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
1991 Remove decls of unexported vars.
1992 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
1994 * lisp.h (DEFINE_FUNC): Make sname 'static'.
1996 Make Emacs functions such as Fatom 'static' by default.
1997 This makes it easier for human readers (and static analyzers)
1998 to see whether these functions can be called from other modules.
1999 DEFUN now defines a static function. To make the function external
2000 so that it can be used in other C modules, use the new macro DEFUE.
2001 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2002 (Finit_image_library):
2003 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2004 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2005 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2006 Remove decls, since these functions are now static.
2007 (Funintern, Fget_internal_run_time): New decls, since these functions
2008 were already external.
2010 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2011 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2012 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2013 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2014 * keyboard.c, keymap.c, lread.c:
2015 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2016 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2017 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2018 Mark functions with DEFUE instead of DEFUN,
2019 if they are used in other modules.
2020 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2021 decls for now-static functions.
2022 * buffer.h (Fdelete_overlay): Remove decl.
2023 * callproc.c (Fgetenv_internal): Mark as internal.
2024 * composite.c (Fremove_list_of_text_properties): Remove decl.
2025 (Fcomposition_get_gstring): New forward static decl.
2026 * composite.h (Fcomposite_get_gstring): Remove decl.
2027 * dired.c (Ffile_attributes): New forward static decl.
2028 * doc.c (Fdocumntation_property): New forward static decl.
2029 * eval.c (Ffetch_bytecode): New forward static decl.
2030 (Funintern): Remove extern decl; now in .h file where it belongs.
2031 * fileio.c (Fmake_symbolic_link): New forward static decl.
2032 * image.c (Finit_image_library): New forward static decl.
2033 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2034 * intervals.h (Fprevious_property_change):
2035 (Fremove_list_of_text_properties): Remove decls.
2036 * keyboard.c (Fthis_command_keys): Remove decl.
2037 (Fcommand_execute): New forward static decl.
2038 * keymap.c (Flookup_key): New forward static decl.
2039 (Fcopy_keymap): Now static.
2040 * keymap.h (Flookup_key): Remove decl.
2041 * process.c (Fget_process): New forward static decl.
2042 (Fprocess_datagram_address): Mark as internal.
2043 * syntax.c (Fsyntax_table_p): New forward static decl.
2044 (skip_chars): Remove duplicate decl.
2045 * textprop.c (Fprevious_property_change): New forward static decl.
2046 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2048 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2049 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2051 * editfns.c (Fformat): Remove unreachable code.
2053 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2055 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2058 2011-04-13 Eli Zaretskii <eliz@gnu.org>
2060 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2061 when at ZV. (Bug#8487)
2063 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2065 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2067 * keyboard.c (parse_tool_bar_item): Likewise.
2068 * sound.c (sound_cleanup, alsa_close): Likewise.
2069 * termcap.c (tgetent): Likewise.
2070 * xfns.c (x_default_font_parameter): Likewise.
2071 * xsettings.c (read_and_apply_settings): Likewise.
2073 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2074 (overrun_check_free): Protoize.
2076 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2078 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2079 since callers should never pass a negative size.
2080 Change the signature to match that of plain 'read' and 'write'; see
2081 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2082 * lisp.h: Update prototypes of emacs_write and emacs_read.
2084 2011-04-11 Eli Zaretskii <eliz@gnu.org>
2086 * xdisp.c (redisplay_window): Don't try to determine the character
2087 position of the scroll margin if the window start point w->startp
2088 is outside the buffer's accessible region. (Bug#8468)
2090 2011-04-10 Eli Zaretskii <eliz@gnu.org>
2092 Fix write-region and its subroutines for buffers > 2GB.
2093 * fileio.c (a_write, e_write): Modify declaration of arguments and
2094 local variables to support buffers larger than 2GB.
2095 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2097 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2098 argument, local variables, and return value.
2100 * lisp.h: Update prototypes of emacs_write and emacs_read.
2102 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2104 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
2106 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2108 Fix more problems found by GCC 4.6.0's static checks.
2110 * xdisp.c (vmessage): Use a better test for character truncation.
2112 * charset.c (load_charset_map): <, not <=, for optimization,
2113 and to avoid potential problems with integer overflow.
2114 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
2115 * casetab.c (set_identity, shuffle): Likewise.
2116 * editfns.c (Fformat): Likewise.
2117 * syntax.c (skip_chars): Likewise.
2119 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2120 This also lets GCC 4.6.0 generate slightly better loop code.
2122 * callint.c (Fcall_interactively): <, not <=, for optimization.
2123 (Fcall_interactively): Count the number of arguments produced,
2124 not the number of arguments given. This is simpler and lets GCC
2125 4.6.0 generate slightly better code.
2127 * ftfont.c: Distingish more carefully between FcChar8 and char.
2128 The previous code passed unsigned char * to a functions like
2129 strlen and xstrcasecmp that expect char *, which does not
2130 conform to the C standard.
2131 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
2132 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
2133 char * when the C standard requires it.
2135 * keyboard.c (read_char): Remove unused var.
2137 * eval.c: Port to Windows vsnprintf (Bug#8435).
2139 (SIZE_MAX): Define if the headers do not.
2140 (verror): Do not give up if vsnprintf returns a negative count.
2141 Instead, grow the buffer. This ports to Windows vsnprintf, which
2142 does not conform to C99. Problem reported by Eli Zaretskii.
2143 Also, simplify the allocation scheme, by avoiding the need for
2144 calling realloc, and removing the ALLOCATED variable.
2146 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
2148 Remove invocations of doprnt, as Emacs now uses vsnprintf.
2149 But keep the doprint source code for now, as we might revamp it
2150 and use it again (Bug#8435).
2151 * lisp.h (doprnt): Remove.
2152 * Makefile.in (base_obj): Remove doprnt.o.
2153 * deps.mk (doprnt.o): Remove.
2155 error: Print 32- and 64-bit integers portably (Bug#8435).
2156 Without this change, on typical 64-bit hosts error ("...%d...", N)
2157 was used to print both 32- and 64-bit integers N, which relied on
2159 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
2161 * lisp.h (error, verror): Mark as printf-like functions.
2162 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
2163 Report overflow in size calculations when allocating printf buffer.
2164 Do not truncate output string at its first null byte.
2165 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
2166 Truncate the output at a character boundary, since vsnprintf does not
2168 * charset.c (check_iso_charset_parameter): Convert internal
2169 character to string before calling 'error', since %c now has the
2171 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
2172 overflow when computing char to be passed to 'error'. Do not
2173 pass Lisp_Object to 'error'; pass the integer instead.
2174 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
2175 formatted with plain %d.
2177 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
2179 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
2181 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
2183 * xterm.c (x_catch_errors): Remove duplicate declaration.
2185 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
2187 * xdisp.c, lisp.h (message_nolog): Remove; unused.
2189 2011-04-10 Jim Meyering <meyering@redhat.com>
2191 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
2192 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
2193 return ssize_t not "int", and use size_t as the buffer length.
2194 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
2195 * gnutls.h: Update declarations.
2196 * process.c (read_process_output): Use ssize_t, to match.
2197 (send_process): Likewise.
2199 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
2201 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
2203 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
2205 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
2206 Use unsigned char, to match FcChar8 type definition.
2208 * xterm.c (handle_one_xevent):
2209 * xmenu.c (create_and_show_popup_menu):
2210 * xselect.c (x_decline_selection_request)
2211 (x_reply_selection_request): Avoid type-punned deref of X events.
2213 2011-04-09 Eli Zaretskii <eliz@gnu.org>
2215 Fix some uses of `int' instead of EMACS_INT.
2216 * search.c (string_match_1, fast_string_match)
2217 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
2218 (scan_buffer, find_next_newline_no_quit)
2219 (find_before_next_newline, search_command, Freplace_match)
2220 (Fmatch_data): Make some `int' variables be EMACS_INT.
2222 * xdisp.c (display_count_lines): 3rd argument and return value now
2223 EMACS_INT. All callers changed.
2224 (pint2hrstr): Last argument is now EMACS_INT.
2226 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2227 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2228 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2229 (decode_coding_utf_16, decode_coding_emacs_mule)
2230 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2231 (decode_coding_ccl, decode_coding_charset)
2232 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
2233 (decode_coding_iso_2022, decode_coding_emacs_mule)
2234 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
2235 <char_offset, last_offset>: Declare EMACS_INT.
2236 (encode_coding_utf_8, encode_coding_utf_16)
2237 (encode_coding_emacs_mule, encode_invocation_designation)
2238 (encode_designation_at_bol, encode_coding_iso_2022)
2239 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
2240 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
2242 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
2243 (encode_invocation_designation): Last argument P_NCHARS is now
2245 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
2246 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
2248 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
2251 * ccl.c (Fccl_execute_on_string): Declare some variables
2254 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
2256 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
2258 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
2260 * process.c (Fformat_network_address): Doc fix.
2262 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
2264 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
2266 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
2268 * keyboard.c (read_char): Call Lisp function help-form-show,
2269 instead of using internal_with_output_to_temp_buffer.
2270 (Qhelp_form_show): New var.
2271 (syms_of_keyboard): Use DEFSYM macro.
2273 * print.c (internal_with_output_to_temp_buffer): Function deleted.
2275 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
2277 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
2279 * process.c (Flist_processes): Remove to Lisp.
2280 (list_processes_1): Delete.
2282 2011-04-06 Eli Zaretskii <eliz@gnu.org>
2284 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
2286 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
2288 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
2290 Fix more problems found by GCC 4.6.0's static checks.
2292 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
2294 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
2296 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
2298 * xdisp.c (vmessage): Mark as a printf-like function.
2300 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
2302 * sound.c (sound_warning): Don't crash if arg contains a printf format.
2304 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
2305 printf-like functions.
2306 (tiff_load): Add casts to remove these marks before passing them
2307 to system-supplied API.
2309 * eval.c (Fsignal): Remove excess argument to 'fatal'.
2311 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
2312 This avoids several warnings with gcc -Wstrict-overflow.
2313 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
2314 directly, rather than having caller test rule sign. This avoids
2315 some unnecessary tests.
2316 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
2317 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
2318 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
2320 * xfont.c (xfont_text_extents): Remove var that was set but not used.
2321 (xfont_open): Avoid unnecessary tests.
2323 * composite.c (composition_gstring_put_cache): Use unsigned integer.
2325 * composite.h, composite.c (composition_gstring_put_cache):
2326 Use EMACS_INT, not int, for length.
2328 * composite.h (COMPOSITION_DECODE_REFS): New macro,
2329 breaking out part of COMPOSITION_DECODE_RULE.
2330 (COMPOSITION_DECODE_RULE): Use it.
2331 * composite.c (get_composition_id): Remove unused local vars,
2332 by using the new macro.
2334 * textprop.c (set_text_properties_1): Change while to do-while,
2335 since the condition is always true at first.
2337 * intervals.c (graft_intervals_into_buffer): Mark var as used.
2338 (interval_deletion_adjustment): Return unsigned value.
2341 * process.c (list_processes_1, create_pty, read_process_output):
2342 (exec_sentinel): Remove vars that were set but not used.
2343 (create_pty): Remove unnecessary "volatile"s.
2344 (Fnetwork_interface_info): Avoid possibility of int overflow.
2345 (read_process_output): Do adaptive read buffering even if carryover.
2346 (read_process_output): Simplify nbytes computation if buffered.
2348 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
2350 * syntax.c (scan_words): Remove var that was set but not used.
2351 (update_syntax_table): Use unsigned instead of int.
2353 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
2354 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
2355 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
2357 * print.c (print_error_message): Avoid int overflow.
2359 * font.c (font_list_entities): Redo for clarity,
2360 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
2362 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
2363 (font_score): Avoid potential overflow in diff calculation.
2365 * fns.c (substring_both): Remove var that is set but not used.
2366 (sxhash): Redo loop for clarity and to avoid wraparound warning.
2368 * eval.c (funcall_lambda): Rename local to avoid shadowing.
2370 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2371 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2372 can always succeed if overflow has undefined behavior.
2374 * search.c (boyer_moore, wordify): Remove vars set but not used.
2375 (wordify): Omit three unnecessary tests.
2377 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2378 All callers changed. This avoids the need for an unused var.
2380 * casefiddle.c (casify_region): Remove var that is set but not used.
2382 * dired.c (file_name_completion): Remove var that is set but not used.
2384 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2386 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
2387 (Finsert_file_contents): Remove unnecessary code checking fd.
2389 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2390 Check for integer overflow on size calculations.
2392 * buffer.c (Fprevious_overlay_change): Remove var that is set
2395 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2396 Remove vars that are set but not used.
2397 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
2398 (timer_check_2): Mark vars as initialized.
2400 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2402 * image.c (lookup_image): Remove var that is set but not used.
2403 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
2405 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2406 that are set but not used.
2408 * xfns.c (make_invisible_cursor): Don't return garbage
2409 if XCreateBitmapFromData fails (Bug#8410).
2411 * xselect.c (x_get_local_selection, x_handle_property_notify):
2412 Remove vars that are set but not used.
2414 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
2415 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
2417 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2418 Remove var that is set but not used.
2419 (scroll_bar_windows_size): Now size_t, not int.
2420 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2423 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2424 (map_tty_color) [!defined MSDOS]: Likewise.
2426 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2428 * coding.c: Remove vars that are set but not used.
2429 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2430 All callers changed.
2431 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2432 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
2433 (decode_coding_charset): Remove vars that are set but not used.
2435 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
2436 that is set but not used.
2438 * print.c (print_object): Remove var that is set but not used.
2440 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
2441 The gnulib version avoids calling malloc in the usual case,
2442 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2443 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
2444 * filelock.c (current_lock_owner): Likewise.
2445 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2446 * sysdep.c: Include allocator.h, careadlinkat.h.
2447 (emacs_no_realloc_allocator): New static constant.
2448 (emacs_readlink): New function.
2449 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
2450 ../lib/careadlinkat.h.
2452 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
2454 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2455 first non-nil return value).
2457 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
2459 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
2460 if not defined (Bug#8403).
2462 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
2464 * xdisp.c (display_count_lines): Remove parameter `start',
2465 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2466 (get_char_face_and_encoding): Remove parameter `multibyte_p',
2467 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2468 (fill_stretch_glyph_string): Remove parameters `row' and `area',
2469 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
2470 and thereabouts. All callers changed.
2471 (get_per_char_metric): Remove parameter `f', unused since
2472 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2474 2011-04-02 Jim Meyering <meyering@redhat.com>
2476 do not dereference NULL upon failed strdup
2477 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
2478 (ns_get_family): Likewise.
2480 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
2482 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
2484 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
2486 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
2489 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
2491 Add lexical binding.
2493 * window.c (Ftemp_output_buffer_show): New fun.
2494 (Fsave_window_excursion):
2495 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
2497 * lread.c (lisp_file_lexically_bound_p): New function.
2498 (Fload): Bind Qlexical_binding.
2499 (readevalloop): Remove `evalfun' arg.
2500 Bind Qinternal_interpreter_environment.
2501 (Feval_buffer): Bind Qlexical_binding.
2502 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
2504 (syms_of_lread): Declare `lexical-binding'.
2506 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
2508 * keyboard.c (eval_dyn): New fun.
2509 (menu_item_eval_property): Use it.
2511 * image.c (parse_image_spec): Use Ffunctionp.
2513 * fns.c (concat, mapcar1): Accept byte-code-functions.
2515 * eval.c (Fsetq): Handle lexical vars.
2516 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
2517 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
2518 (FletX, Flet): Obey lexical binding.
2519 (Fcommandp): Handle closures.
2520 (Feval): New `lexical' arg.
2521 (eval_sub): New function extracted from Feval. Use it almost
2522 everywhere where Feval was used. Look up vars in lexical env.
2524 (Ffunctionp): Move from subr.el.
2525 (Ffuncall): Handle closures.
2526 (apply_lambda): Remove `eval_flags'.
2527 (funcall_lambda): Handle closures and new byte-code-functions.
2528 (Fspecial_variable_p): New function.
2529 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
2530 but without exporting it to Lisp.
2532 * doc.c (Fdocumentation, store_function_docstring):
2533 * data.c (Finteractive_form): Handle closures.
2535 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
2538 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
2540 (exec_byte_code): New function extracted from Fbyte_code to handle new
2541 calling convention for byte-code-functions. Add new byte-codes.
2543 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
2545 * alloc.c (Fmake_symbol): Init new `declared_special' field.
2547 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
2549 * xdisp.c (redisplay_internal): Fix prototype.
2551 2011-03-31 Eli Zaretskii <eliz@gnu.org>
2553 * xdisp.c (SCROLL_LIMIT): New macro.
2554 (try_scrolling): Use it when setting scroll_limit.
2555 Limit scrolling to 100 screen lines.
2556 (redisplay_window): Even when falling back on "recentering",
2557 position point in the window according to scroll-conservatively,
2558 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
2560 (try_scrolling): When point is above the window, allow searching
2561 as far as scroll_max, or one screenful, to compute vertical
2562 distance from PT to the scroll margin position. This prevents
2563 try_scrolling from unnecessarily failing when
2564 scroll-conservatively is set to a value slightly larger than the
2565 window height. Clean up the case of PT below the margin at bottom
2566 of window: scroll_max can no longer be INT_MAX. When aggressive
2567 scrolling is in use, don't let point enter the opposite scroll
2568 margin as result of the scroll.
2569 (syms_of_xdisp) <scroll-conservatively>: Document the
2570 threshold of 100 lines for never-recentering scrolling.
2572 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
2574 * dispextern.h (move_it_by_lines):
2575 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
2576 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
2577 (message_log_check_duplicate): Remove parameters `prev_bol' and
2578 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2579 (redisplay_internal): Remove parameter `preserve_echo_area',
2580 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
2582 * indent.c (Fvertical_motion):
2583 * window.c (window_scroll_pixel_based, Frecenter):
2584 Don't pass `need_y_p' to `move_it_by_lines'.
2586 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
2588 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
2589 steal a few bits to be more compact.
2590 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2591 Remove unneeded casts.
2593 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2595 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2597 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2598 binding" message (bug#7967).
2600 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2602 Fix more problems found by GCC 4.6.0's static checks.
2604 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2605 Remove unused local var.
2607 * editfns.c (Fmessage_box): Remove unused local var.
2609 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2610 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2611 Omit unused local vars.
2612 * window.c (shrink_windows): Omit unused local var.
2613 * menu.c (digest_single_submenu): Omit unused local var.
2614 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2615 Omit unused local var.
2617 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2618 Don't assume string length fits in int.
2619 (keyremap_step, read_key_sequence): Use size_t for sizes.
2620 (read_key_sequence): Don't check last_real_key_start redundantly.
2622 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2623 instead of alloca (Bug#8344).
2625 * eval.c (Fbacktrace): Don't assume nargs fits in int.
2626 (Fbacktrace_frame): Don't assume nframes fits in int.
2628 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2630 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2633 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2635 * cm.c (calccost): Turn while-do into do-while, for clarity.
2637 * keyboard.c (syms_of_keyboard): Use the same style as later
2638 in this function when indexing through an array. This also
2639 works around GCC bug 48267.
2641 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2643 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2645 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2646 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2648 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2649 This avoids undefined behavior on integer overflow, and is a bit
2650 more convenient anyway since it is compared to a size_t variable.
2652 Variadic C functions now count arguments with size_t, not int.
2653 This avoids an unnecessary limitation on 64-bit machines, which
2654 caused (substring ...) to crash on large vectors (Bug#8344).
2655 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2656 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
2657 All variadic functions and their callers changed accordingly.
2658 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2659 * data.c (arith_driver, float_arith_driver): Likewise.
2660 * editfns.c (general_insert_function): Likewise.
2661 * eval.c (struct backtrace.nargs, interactive_p)
2662 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2663 (funcall_lambda, mark_backtrace): Likewise.
2664 * fns.c (concat): Likewise.
2665 * frame.c (x_set_frame_parameters): Likewise.
2666 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2667 0 if not found, not -1. All callers changed.
2669 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2670 (stack_copy_size): Now size_t, not int.
2671 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2673 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
2675 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2676 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2677 All callers changed.
2679 * lisp.h (multibyte_char_to_unibyte):
2680 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
2681 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2682 * character.h (CHAR_TO_BYTE8):
2683 * cmds.c (internal_self_insert):
2684 * editfns.c (general_insert_function):
2685 * keymap.c (push_key_description):
2686 * search.c (Freplace_match):
2687 * xdisp.c (message_dolog, set_message_1): All callers changed.
2689 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2691 * keyboard.c (safe_run_hook_funcall): New function.
2692 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
2693 don't set the hook to nil, but remove the offending function instead.
2694 (Qcommand_hook_internal): Remove, unused.
2695 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
2696 Vcommand_hook_internal.
2698 * eval.c (enum run_hooks_condition): Remove.
2699 (funcall_nil, funcall_not): New functions.
2700 (run_hook_with_args): Call each function through a `funcall' argument.
2701 Remove `cond' argument, now redundant.
2702 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
2703 (Frun_hook_with_args_until_failure): Adjust accordingly.
2704 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
2706 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
2708 * dispextern.h (string_buffer_position): Remove declaration.
2710 * print.c (strout): Remove parameter `multibyte', unused since
2711 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
2713 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
2714 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
2715 All callers changed.
2717 * w32.c (_wsa_errlist): Use braces for struct initializers.
2719 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
2720 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
2721 All callers changed.
2722 (string_buffer_position): Likewise. Also, make static (it's never
2723 used outside xdisp.c).
2724 (cursor_row_p): Remove parameter `w', unused since
2725 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
2726 (decode_mode_spec): Remove parameter `precision', introduced during
2727 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
2728 All callers changed.
2730 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2732 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
2734 2011-03-27 Anders Lindgren <andlind@gmail.com>
2736 * nsterm.m (ns_menu_bar_is_hidden): New variable.
2737 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
2738 (ns_update_auto_hide_menu_bar): New functions.
2739 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
2740 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
2741 ns_constrain_all_frames.
2742 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
2743 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
2745 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2747 * nsmenu.m (runDialogAt): Remove argument to timer_check.
2749 2011-03-27 Glenn Morris <rgm@gnu.org>
2751 * syssignal.h: Replace RETSIGTYPE with void.
2752 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
2753 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
2754 Replace SIGTYPE with void everywhere.
2755 * s/usg5-4-common.h (SIGTYPE): Remove definition.
2756 * s/template.h (SIGTYPE): Remove commented out definition.
2758 2011-03-26 Eli Zaretskii <eliz@gnu.org>
2760 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
2761 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
2763 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
2765 * w32.c (read_unc_volume): Use parameter `henum', instead of
2766 global variable `wget_enum_handle'.
2768 * keymap.c (describe_vector): Remove parameters `indices' and
2769 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
2770 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
2772 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
2774 * keyboard.c (timer_check): Remove parameter `do_it_now',
2775 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
2776 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
2777 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
2779 * keyboard.c (read_char):
2780 * w32menu.c (w32_menu_display_help):
2781 * xmenu.c (show_help_event, menu_help_callback):
2782 Adjust calls to `show_help_echo'.
2784 * gtkutil.c (xg_maybe_add_timer):
2785 * keyboard.c (readable_events):
2786 * process.c (wait_reading_process_output):
2787 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
2789 * insdel.c (adjust_markers_gap_motion):
2790 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
2791 (gap_left, gap_right): Don't call it.
2793 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
2795 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
2796 incurred during fontification.
2798 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
2800 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
2801 (DEFVAR_PER_BUFFER): Don't pass it.
2803 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
2804 (scrolling_window): Don't pass it.
2806 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
2808 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
2810 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
2812 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
2813 of variables specific to SELinux and computation of `encoded_absname'.
2815 * image.c (XPutPixel): Remove unused variable `height'.
2817 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
2819 * unexw32.c (get_section_info): Remove unused variable `section'.
2821 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
2822 (system_process_attributes): Remove unused variable `sess'.
2823 (sys_read): Remove unused variable `err'.
2825 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
2826 (w32_wnd_proc): Remove unused variable `isdead'.
2827 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
2828 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
2829 (x_create_tip_frame): Remove unused variable `tem'.
2831 * w32inevt.c (w32_console_read_socket):
2832 Remove unused variable `no_events'.
2834 * w32term.c (x_draw_composite_glyph_string_foreground):
2835 Remove unused variable `width'.
2837 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
2839 * w32term.c (x_set_glyph_string_clipping):
2840 Don't pass uninitialized region to CombineRgn.
2842 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
2844 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
2845 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
2846 (Fx_close_connection): Remove unused variable `i'.
2848 * w32font.c (w32font_draw): Return number of glyphs.
2849 (w32font_open_internal): Remove unused variable `i'.
2850 (w32font_driver): Add missing initializer.
2852 * w32menu.c (utf8to16): Remove unused variable `utf16'.
2853 (fill_in_menu): Remove unused variable `items_added'.
2855 * w32term.c (last_mouse_press_frame): Remove static global variable.
2856 (w32_clip_to_row): Remove unused variable `f'.
2857 (x_delete_terminal): Remove unused variable `i'.
2859 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
2860 (NOTHING): Remove unused static global variable.
2861 (uniscribe_check_otf): Remove unused variable `table'.
2862 (uniscribe_font_driver): Add missing initializers.
2864 2011-03-23 Julien Danjou <julien@danjou.info>
2866 * term.c (Fsuspend_tty, Fresume_tty):
2867 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
2868 * window.c (temp_output_buffer_show):
2869 * insdel.c (signal_before_change):
2870 * frame.c (Fhandle_switch_frame):
2871 * fileio.c (Fdo_auto_save):
2872 * emacs.c (Fkill_emacs):
2873 * editfns.c (save_excursion_restore):
2874 * cmds.c (internal_self_insert):
2875 * callint.c (Fcall_interactively):
2876 * buffer.c (Fkill_all_local_variables):
2877 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
2879 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
2880 unconditionnaly since it does the check itself.
2882 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
2884 Fix more problems found by GCC 4.5.2's static checks.
2886 * coding.c (encode_coding_raw_text): Avoid unnecessary test
2887 the first time through the loop, since we know p0 < p1 then.
2888 This also avoids a gcc -Wstrict-overflow warning.
2890 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
2891 leading to a memory leak, possible in functions like
2892 load_charset_map_from_file that can allocate an unbounded number
2893 of objects (Bug#8318).
2895 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
2896 that could (at least in theory) be that large.
2898 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
2899 This is less likely to overflow, and avoids undefined behavior if
2900 overflow does occur. All callers changed. Use strtoul to scan
2901 for the unsigned long integer.
2902 (pint2hrstr): Simplify and tune code slightly.
2903 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
2905 * scroll.c (do_scrolling): Work around GCC bug 48228.
2906 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
2908 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
2909 This also avoids a warning with gcc -Wstrict-overflow.
2910 (validate_x_resource_name): Simplify count usage.
2911 This also avoids a warning with gcc -Wstrict-overflow.
2913 * fileio.c (Fcopy_file): Report error if fchown or fchmod
2916 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
2918 * process.c (Fmake_network_process): Use socklen_t, not int,
2919 where POSIX says socklen_t is required in portable programs.
2920 This fixes a porting bug on hosts like 64-bit HP-UX, where
2921 socklen_t is wider than int (Bug#8277).
2922 (Fmake_network_process, server_accept_connection):
2923 (wait_reading_process_output, read_process_output):
2926 * process.c: Rename or move locals to avoid shadowing.
2927 (list_processes_1, Fmake_network_process):
2928 (read_process_output_error_handler, exec_sentinel_error_handler):
2929 Rename or move locals.
2930 (Fmake_network_process): Define label "retry_connect" only if needed.
2931 (Fnetwork_interface_info): Fix pointer signedness.
2932 (process_send_signal): Add cast to avoid pointer signedness problem.
2933 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
2934 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
2936 Make tparam.h and terminfo.c consistent.
2937 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
2938 Include tparam.h instead, since it declares them.
2939 * cm.h (PC): Remove extern decl; tparam.h now does this.
2940 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
2941 * terminfo.c: Include tparam.h, to check interfaces.
2942 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
2943 (tparam): Adjust signature to match interface in tparam.h;
2944 this removes some undefined behavior. Check that outstring and len
2945 are zero, which they always are with Emacs.
2946 * tparam.h (PC, BC, UP): New extern decls.
2948 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
2949 (xftfont_open): Rename locals to avoid shadowing.
2951 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
2952 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
2953 (OTF_TAG_SYM): Omit macro if not needed.
2954 (ftfont_list): Remove unused local.
2955 (get_adstyle_property, ftfont_pattern_entity):
2956 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
2957 Rename locals to avoid shadowing.
2959 * xfont.c (xfont_list_family): Mark var as initialized.
2961 * xml.c (make_dom): Now static.
2963 * composite.c (composition_compute_stop_pos): Rename local to
2965 (composition_reseat_it): Remove unused locals.
2966 (find_automatic_composition, composition_adjust_point): Likewise.
2967 (composition_update_it): Mark var as initialized.
2968 (find_automatic_composition): Mark vars as initialized,
2969 with a FIXME (Bug#8290).
2971 character.h: Rename locals to avoid shadowing.
2972 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
2973 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
2974 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
2975 (BUF_DEC_POS): Be more systematic about renaming local temporaries
2978 * textprop.c (property_change_between_p): Remove; unused.
2980 * intervals.c (interval_start_pos): Now static.
2982 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
2984 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
2985 Rename locals to avoid shadowing.
2987 * sound.c (wav_play, au_play, Fplay_sound_internal):
2988 Fix pointer signedness.
2989 (alsa_choose_format): Remove unused local var.
2990 (wav_play): Initialize a variable to 0, to prevent undefined
2991 behavior (Bug#8278).
2993 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
2995 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
2997 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
2998 clobbering (Bug#8298).
2999 * sysdep.c (sys_subshell): Likewise.
3000 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
3002 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3003 This should get cleaned up, so that child_setup has the
3004 same signature on all platforms.
3006 * callproc.c (call_process_cleanup): Now static.
3007 (relocate_fd): Rename locals to avoid shadowing.
3009 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
3011 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3012 not to be necessary, and produces flickering.
3014 2011-03-20 Glenn Morris <rgm@gnu.org>
3016 * config.in: Remove file.
3018 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
3020 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3021 are now in src/globals.h.
3022 (syms_of_minibuf): Remove spurious & from previous change.
3024 2011-03-20 Leo <sdl.web@gmail.com>
3026 * minibuf.c (completing-read-function): New variable.
3027 (completing-read-default): Rename from completing-read.
3028 (completing-read): Call completing-read-function.
3030 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3032 * xfaces.c (Fx_load_color_file):
3033 Read color file from absolute filename (bug#8250).
3035 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3037 * makefile.w32-in: Update dependencies.
3039 2011-03-17 Eli Zaretskii <eliz@gnu.org>
3041 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3043 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3045 Fix more problems found by GCC 4.5.2's static checks.
3047 * process.c (make_serial_process_unwind, send_process_trap):
3048 (sigchld_handler): Now static.
3050 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3051 That way, the code declares only the vars that it needs.
3052 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3053 * s/cygwin.h (PTY_ITERATION): Likewise.
3054 * s/darwin.h (PTY_ITERATION): Likewise.
3055 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3057 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3058 * process.c (allocate_pty): Don't declare stb unless it's needed.
3060 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
3061 (CONSTANTLIM): Remove; unused.
3062 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3063 Define only if needed.
3065 * unexelf.c (unexec): Name an expression,
3066 to avoid gcc -Wbad-function-cast warning.
3067 Use a different way to cause a compilation error if anyone uses
3068 n rather than nn, a way that does not involve shadowing.
3069 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
3071 * deps.mk (unexalpha.o): Remove; unused.
3073 New file unexec.h, the (simple) interface for unexec (Bug#8267).
3074 * unexec.h: New file.
3075 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3076 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3078 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3079 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3080 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
3081 Change as necessary to match prototype in unexec.h.
3083 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3085 (back_comment, skip_chars): Mark vars as initialized.
3087 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3088 Rename locals to avoid shadowing.
3090 * lread.c (read1): Rewrite so as not to use empty "else".
3091 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
3093 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3095 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3096 warning when compiling print.c.
3098 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3099 instead of using an uninitialized var.
3100 (font_sort_entities): Mark var as initialized.
3102 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3104 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3105 pointers to constants.
3106 (font_parse_fcname): Remove unused vars.
3107 (font_delete_unmatched): Now static.
3108 (font_get_spec): Remove; unused.
3109 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3110 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3111 Rename or move locals to avoid shadowing.
3113 * fns.c (require_nesting_list, require_unwind): Now static.
3114 (Ffillarray): Rename locals to avoid shadowing.
3116 * floatfns.c (domain_error2): Define only if needed.
3117 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
3119 * alloc.c (mark_backtrace): Move decl from here ...
3120 * lisp.h: ... to here, so that it can be checked.
3122 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
3123 (Fdefvar): Rewrite so as not to use empty "else".
3124 (lisp_indirect_variable): Name an expression,
3125 to avoid gcc -Wbad-function-cast warning.
3126 (Fdefvar): Rename locals to avoid shadowing.
3128 * callint.c (quotify_arg, quotify_args): Now static.
3129 (Fcall_interactively): Rename locals to avoid shadowing.
3130 Use const pointer when appropriate.
3132 * lisp.h (get_system_name, get_operating_system_release):
3133 Move decls here, to check interfaces.
3134 * process.c (get_operating_system_release): Move decl to lisp.h.
3135 * xrdb.c (get_system_name): Likewise.
3136 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
3137 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
3138 some of which prompt warnings from gcc -Wbad-function-cast.
3139 (Fformat_time_string, Fencode_time, Finsert_char):
3140 (Ftranslate_region_internal, Fformat):
3141 Rename or remove local vars to avoid shadowing.
3142 (Ftranslate_region_internal): Mark var as initialized.
3144 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
3147 * lisp.h (eassert): Check that the argument compiles, even if
3148 ENABLE_CHECKING is not defined.
3150 * data.c (Findirect_variable): Name an expression, to avoid
3151 gcc -Wbad-function-cast warning.
3152 (default_value, arithcompare, arith_driver, arith_error): Now static.
3153 (store_symval_forwarding): Rename local to avoid shadowing.
3154 (Fmake_variable_buffer_local, Fmake_local_variable):
3155 Mark variables as initialized.
3156 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
3158 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
3159 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
3160 Rename locals to avoid shadowing.
3161 (mark_stack): Move local variables into the #ifdef region where
3163 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
3164 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
3166 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
3167 (GC_STRING_CHARS): Remove; not used.
3168 (Fmemory_limit): Cast sbrk's returned value to char *.
3170 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
3171 avoids undefined behavior in theory.
3173 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
3175 Use functions, not macros, for up- and down-casing (Bug#8254).
3176 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3177 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
3178 to use the following functions instead of these macros.
3179 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
3180 EMACS_INT, since callers assume the returned value fits in int.
3181 (upcase1): Likewise, for UPCASE_TABLE.
3182 (uppercasep, lowercasep, upcase): New static inline functions.
3183 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
3184 the race-condition problem in the old DOWNCASE.
3186 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
3187 Rename locals to avoid shadowing.
3188 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
3189 (regex_compile, re_search_2, re_match_2_internal):
3190 Remove unused local vars.
3191 (FREE_VAR): Rewrite so as not to use empty "else",
3192 which gcc can warn about.
3193 (regex_compile, re_match_2_internal): Mark locals as initialized.
3194 (RETALLOC_IF): Define only if needed.
3195 (WORDCHAR_P): Likewise. This one is never needed, but is used
3196 only in a comment talking about a compiler bug, so put inside
3197 the #if 0 of that comment.
3198 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
3199 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
3202 * search.c (boyer_moore): Rename locals to avoid shadowing.
3203 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
3204 (PREV_CHAR_BOUNDARY): Likewise.
3206 * search.c (simple_search): Remove unused var.
3208 * dired.c (compile_pattern): Move decl from here ...
3209 * lisp.h: ... to here, so that it can be checked.
3210 (struct re_registers): New forward decl.
3212 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
3214 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
3216 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
3217 Rename locals to avoid shadowing.
3218 (Fvertical_motion): Mark locals as initialized.
3220 * casefiddle.c (casify_object, casify_region): Now static.
3221 (casify_region): Mark local as initialized.
3223 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
3225 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3226 New macros, so that the caller can use some names other than
3227 gcpro1, gcpro2, etc.
3228 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3230 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3231 argument, for consistency with GCPRO2_VAR, etc: it is now the
3232 prefix of the variable, not the variable itself. All uses
3234 * dired.c (directory_files_internal, file_name_completion):
3235 Rename locals to avoid shadowing.
3237 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
3238 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
3239 dired.c's scmp function, had undefined behavior.
3240 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3241 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
3242 * buffer.h: ... to here, because these macros use current_buffer,
3243 and the new implementation with inline functions needs to have
3244 current_buffer in scope now, rather than later when the macros
3246 (downcase, upcase1): New static inline functions.
3247 (DOWNCASE, UPCASE1): Reimplement using these functions.
3248 This avoids undefined behavior in expressions like
3249 DOWNCASE (x) == DOWNCASE (y), which previously suffered
3250 from race conditions in accessing the global variables
3251 case_temp1 and case_temp2.
3252 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
3253 * lisp.h (case_temp1, case_temp2): Remove their decls.
3254 * character.h (ASCII_CHAR_P): Move from here ...
3255 * lisp.h: ... to here, so that the inline functions mentioned
3258 * dired.c (directory_files_internal_unwind): Now static.
3260 * fileio.c (file_name_as_directory, directory_file_name):
3261 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
3263 (file_name_as_directory): Use const pointers when appropriate.
3264 (Fexpand_file_name): Likewise. In particular, newdir might
3265 point at constant storage, so make it a const pointer.
3266 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
3267 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
3269 (Fset_file_times, Finsert_file_contents, auto_save_error):
3270 Rename locals to avoid shadowing.
3272 * minibuf.c (choose_minibuf_frame_1): Now static.
3273 (Ftry_completion, Fall_completions): Rename or remove locals
3276 * marker.c (bytepos_to_charpos): Remove; unused.
3278 * lisp.h (verify_bytepos, count_markers): New decls,
3279 so that gcc does not warn that these functions aren't declared.
3281 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
3282 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
3283 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
3284 (copy_text): Remove unused local var.
3286 * filelock.c (within_one_second): Now static.
3287 (lock_file_1): Rename local to avoid shadowing.
3289 * buffer.c (fix_overlays_before): Mark locals as initialized.
3290 (fix_start_end_in_overlays): Likewise. This function should be
3291 simplified by using pointers-to-pointers, but that's a different
3293 (switch_to_buffer_1): Now static.
3294 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
3295 (report_overlay_modification): Rename locals to avoid shadowing.
3297 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
3298 Fix pointer signedness issue.
3299 (sys_subshell): Mark local as volatile if checking for lint,
3300 to suppress a gcc -Wclobbered warning that does not seem to be right.
3301 (MAXPATHLEN): Define only if needed.
3303 * process.c (serial_open, serial_configure): Move decls from here ...
3304 * systty.h: ... to here, so that they can be checked.
3306 * fns.c (get_random, seed_random): Move extern decls from here ...
3307 * lisp.h: ... to here, so that they can be checked.
3309 * sysdep.c (reset_io): Now static.
3310 (wait_for_termination_signal): Remove; unused.
3312 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
3313 (copy_keymap_item, append_key, push_text_char_description):
3315 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
3316 (DENSE_TABLE_SIZE): Remove; unused.
3317 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
3318 (describe_map_tree):
3319 Rename locals to avoid shadowing.
3321 * keyboard.c: Declare functions static if they are not used elsewhere.
3322 (echo_char, echo_dash, cmd_error, top_level_2):
3323 (poll_for_input, handle_async_input): Now static.
3324 (read_char, kbd_buffer_get_event, make_lispy_position):
3325 (make_lispy_event, make_lispy_movement, apply_modifiers):
3326 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
3327 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
3328 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
3329 (read_key_sequence, read_char): Mark locals as initialized.
3330 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
3332 * keyboard.h (make_ctrl_char): New decl.
3333 (mark_kboards): Move decl here ...
3334 * alloc.c (mark_kboards): ... from here.
3336 * lisp.h (force_auto_save_soon): New decl.
3338 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
3339 (DEFINE_DUMMY_FUNCTION): New macro.
3340 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
3342 (main): Add casts to avoid warnings
3343 if GCC considers string literals to be constants.
3345 * lisp.h (fatal_error_signal): Add decl, since it's exported.
3347 * dbusbind.c: Pointer signedness fixes.
3348 (xd_signature, xd_append_arg, xd_initialize):
3349 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3350 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3351 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
3352 (Fdbus_register_signal): Use SSDATA when the context wants char *.
3354 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
3355 if GCC considers string literals to be constants.
3356 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
3358 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
3360 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
3361 (print_preprocess, print_object): New macro to fix last change.
3363 * print.c (print_preprocess): Don't forget font objects.
3365 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
3367 * emacs.c (USAGE3): Doc fixes.
3369 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
3371 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3374 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
3376 * lisp.h (VWindow_system, Qfile_name_history):
3377 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3378 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3379 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3381 * w32select.c: Don't #include "keyboard.h".
3382 (run_protected): Add extern declaration for waiting_for_input.
3384 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3385 * w32console.c (detect_input_pending, read_input_pending)
3386 (encode_terminal_code):
3387 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3388 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3389 (w32_system_caret_y, Qfile_name_history):
3390 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3391 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3392 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3393 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3394 * w32proc.c (Qlocal, report_file_error):
3395 * w32term.c (Vwindow_system, updating_frame):
3396 * w32uniscribe.c (initialized, uniscribe_font_driver):
3397 Remove unneeded extern declarations.
3399 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
3401 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
3403 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
3405 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3406 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3407 These macros can no longer be used for assignment.
3409 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3410 Assign struct members directly, instead of using BUF_BEGV etc.
3411 (record_buffer_markers, fetch_buffer_markers): New functions for
3412 recording and fetching special buffer markers.
3413 (set_buffer_internal_1, set_buffer_temp): Use them.
3415 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3417 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3419 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3420 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3422 * xdisp.c (hscroll_window_tree):
3423 (reconsider_clip_changes): Use PT instead of BUF_PT.
3425 2011-03-13 Eli Zaretskii <eliz@gnu.org>
3427 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3428 $(EMACS_ROOT)/lib/intprops.h.
3430 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3432 Fix more problems found by GCC 4.5.2's static checks.
3434 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
3435 to unsigned char * to avoid compiler diagnostic.
3436 (xg_free_frame_widgets): Make it clear that a local variable is
3437 needed only if USE_GTK_TOOLTIP.
3438 (gdk_window_get_screen): Make it clear that this macro is needed
3439 only if USE_GTK_TOOLTIP.
3440 (int_gtk_range_get_value): New function, which avoids a diagnostic
3441 from gcc -Wbad-function-cast.
3442 (xg_set_toolkit_scroll_bar_thumb): Use it.
3443 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
3444 diagnostic from gcc -Wbad-function-cast.
3445 (get_utf8_string, xg_get_file_with_chooser):
3446 Rename locals to avoid shadowing.
3447 (create_dialog): Move locals to avoid shadowing.
3449 * xgselect.c (xg_select): Remove unused var.
3451 * image.c (four_corners_best): Mark locals as initialized.
3452 (gif_load): Initialize transparent_p to zero (Bug#8238).
3453 Mark another local as initialized.
3454 (my_png_error, my_error_exit): Mark with NO_RETURN.
3456 * image.c (clear_image_cache): Now static.
3457 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
3458 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
3459 (x_edge_detection): Remove unnecessary cast that
3460 gcc -Wbad-function-cast diagnoses.
3461 (gif_load): Fix pointer signedness.
3462 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
3463 (jpeg_load, gif_load): Rename locals to avoid shadowing.
3465 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3467 Improve quality of tests for time stamp overflow.
3468 For example, without this patch (encode-time 0 0 0 1 1
3469 1152921504606846976) returns the obviously-bogus value (-948597
3470 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
3471 reports time overflow. See
3472 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
3473 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
3474 * editfns.c: Include limits.h and intprops.h.
3475 (TIME_T_MIN, TIME_T_MAX): New macros.
3476 (time_overflow): Move earlier, to before first use.
3477 (hi_time, lo_time): New functions, for an accurate test for
3479 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
3480 (Fget_internal_run_time): Don't assume time_t fits in int.
3481 (make_time): Use list2 instead of Fcons twice.
3482 (Fdecode_time): More accurate test for out-of-range times.
3483 (check_tm_member): New function.
3484 (Fencode_time): Use it, to test for out-of-range times.
3485 (lisp_time_argument): Don't rely on undefined left-shift and
3486 right-shift behavior when checking for time stamp overflow.
3488 * editfns.c (time_overflow): New function, refactoring common code.
3489 (Fformat_time_string, Fdecode_time, Fencode_time):
3490 (Fcurrent_time_string): Use it.
3492 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
3493 * dired.c (make_time): Move to ...
3494 * editfns.c (make_time): ... here.
3495 * systime.h: Note the move.
3497 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3499 * fringe.c (update_window_fringes): Remove unused variables.
3501 * unexmacosx.c (copy_data_segment): Also copy __got section.
3504 2011-03-12 Eli Zaretskii <eliz@gnu.org>
3506 * termcap.c [MSDOS]: Include "msdos.h".
3507 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
3508 Constify `char *' arguments and their references according to
3509 prototypes in tparam.h.
3511 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
3513 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
3514 Adapt all references accordingly.
3516 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
3518 2011-03-11 Tom Tromey <tromey@redhat.com>
3520 * buffer.c (syms_of_buffer): Remove obsolete comment.
3522 2011-03-11 Eli Zaretskii <eliz@gnu.org>
3524 * termhooks.h (encode_terminal_code): Declare prototype.
3526 * msdos.c (encode_terminal_code): Don't declare prototype.
3528 * term.c (encode_terminal_code): Now external again, used by
3529 w32console.c and msdos.c.
3531 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
3532 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
3534 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
3536 Fix some minor problems found by GCC 4.5.2's static checks.
3538 * fringe.c (update_window_fringes): Mark locals as initialized
3540 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
3542 * alloc.c (mark_fringe_data): Move decl from here ...
3543 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
3544 to check its interface.
3545 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
3547 * fontset.c (free_realized_fontset): Now static.
3548 (Fset_fontset_font): Rename local to avoid shadowing.
3549 (fontset_font): Mark local as initialized.
3550 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
3552 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
3554 * xselect.c (x_disown_buffer_selections): Remove; not used.
3555 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
3556 (x_own_selection, Fx_disown_selection_internal): Rename locals
3558 (x_handle_dnd_message): Remove local to avoid shadowing.
3560 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
3561 so that the caller can use some name other than gcpro1.
3562 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
3563 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3564 (Fx_backspace_delete_keys_p):
3565 Use them to avoid shadowing, and rename vars to avoid shadowing.
3566 (x_decode_color, x_set_name, x_window): Now static.
3567 (Fx_create_frame): Add braces to silence GCC warning.
3568 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
3569 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
3570 Remove unused locals.
3571 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3572 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
3573 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
3576 * xterm.h (x_mouse_leave): New decl.
3578 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
3579 Remove unused functions.
3580 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
3581 (x_calc_absolute_position): Now static.
3582 (XTread_socket): Don't define label "out" unless it's used.
3583 Don't declare local "event" unless it's used.
3584 (x_iconify_frame, x_free_frame_resources): Don't declare locals
3585 unless they are used.
3586 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
3587 (x_fatal_error_signal): Remove; not used.
3588 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
3589 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
3590 (x_error_catcher, x_connection_closed, x_error_handler):
3591 (x_error_quitter, xembed_send_message, x_iconify_frame):
3592 (my_log_handler): Rename locals to avoid shadowing.
3593 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
3594 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
3596 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3597 Rename or move locals to avoid shadowing.
3598 (tty_defined_color, merge_face_heights): Now static.
3599 (free_realized_faces_for_fontset): Remove; not used.
3600 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3601 does not deduce is never used uninitialized.
3602 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3603 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
3605 * terminal.c (store_terminal_param): Now static.
3607 * xmenu.c (menu_highlight_callback): Now static.
3608 (set_frame_menubar): Remove unused local.
3609 (xmenu_show): Rename parameter to avoid shadowing.
3610 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3611 since they might point to immutable storage.
3612 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3613 since it's unused otherwise.
3615 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
3616 Add a FIXME, since the code still doesn't look right. (Bug#8215)
3617 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3618 avoids a gcc -Wuninitialized diagnostic.
3619 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
3620 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3621 does not deduce are never used uninitialized.
3623 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3625 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
3626 * window.c (window_loop, size_window):
3627 (run_window_configuration_change_hook, enlarge_window): Likewise.
3629 * window.c (display_buffer): Now static.
3630 (size_window): Mark variables that gcc -Wuninitialized
3631 does not deduce are never used uninitialized.
3632 * window.h (check_all_windows): New decl, to forestall
3633 gcc -Wmissing-prototypes diagnostic.
3634 * dispextern.h (bidi_dump_cached_states): Likewise.
3636 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3638 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
3640 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3641 and to avoid gcc -Wuninitialized warning.
3642 (load_charset_map): Mark variables that gcc -Wuninitialized
3643 does not deduce are never used uninitialized.
3644 (load_charset): Abort instead of using uninitialized var (Bug#8229).
3646 * coding.c (coding_set_source, coding_set_destination):
3647 Use "else { /* comment */ }" rather than "else /* comment */;"
3648 for clarity, and to avoid gcc -Wempty-body warning.
3649 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3650 a block, when the outer 'i' will do.
3651 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3652 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3653 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3654 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3655 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3656 Rename locals to avoid shadowing.
3657 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
3658 * coding.c (emacs_mule_char, encode_invocation_designation):
3659 Now static, since they're not used elsewhere.
3660 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
3661 (decode_coding_object, encode_coding_object, detect_coding_system):
3662 (decode_coding_emacs_mule): Mark variables that gcc
3663 -Wuninitialized does not deduce are never used uninitialized.
3664 (detect_coding_iso_2022): Initialize a local variable that might
3665 be used uninitialized. Leave a FIXME because it's not clear that
3666 this initialization is needed. (Bug#8211)
3667 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3668 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3669 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3670 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3671 Remove unused macros.
3673 * category.c (hash_get_category_set): Remove unused local var.
3674 (copy_category_table): Now static, since it's not used elsewhere.
3675 * character.c (string_count_byte8): Likewise.
3677 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
3678 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
3680 * chartab.c (copy_sub_char_table): Now static, since it's not used
3682 (sub_char_table_ref_and_range, char_table_ref_and_range):
3683 Rename locals to avoid shadowing.
3684 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
3686 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
3687 (BIDI_BOB): Remove unused macro.
3689 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
3690 deduce are never used uninitialized.
3691 * term.c (encode_terminal_code): Likewise.
3693 * term.c (encode_terminal_code): Now static. Remove unused local.
3695 * tparam.h: New file.
3696 * term.c, tparam.h: Include it.
3697 * deps.mk (term.o, tparam.o): Depend on tparam.h.
3698 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
3699 Move these decls to tparam.h, and make them agree with what
3700 is actually in tparam.c. The previous trick of using incompatible
3701 decls in different modules does not conform to the C standard.
3702 All callers of tparam changed to use tparam's actual API.
3703 * tparam.c (tparam1, tparam, tgoto):
3704 Use const pointers where appropriate.
3706 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
3707 * cm.h (struct cm): Likewise.
3708 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
3709 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
3710 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
3711 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
3712 (turn_on_face, init_tty): Likewise.
3713 * termchar.h (struct tty_display_info): Likewise.
3715 * term.c (term_mouse_position): Rename local to avoid shadowing.
3717 * alloc.c (mark_ttys): Move decl from here ...
3718 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
3720 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
3722 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
3724 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
3726 * search.c (compile_pattern_1): Remove argument regp, unused since
3727 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
3728 (compile_pattern): Don't pass it.
3730 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
3732 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
3733 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
3735 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
3737 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
3739 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
3740 gdk_window_get_screen, gdk_window_get_geometry,
3741 gdk_x11_window_lookup_for_display and GDK_KEY_g.
3742 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
3743 (xg_get_pixbuf_from_pixmap): New function.
3744 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
3745 to Pixmap, take frame as parameter, remove GdkColormap parameter.
3746 Call xg_get_pixbuf_from_pixmap instead of
3747 gdk_pixbuf_get_from_drawable.
3748 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
3749 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
3750 (xg_check_special_colors): Use GtkStyleContext and its functions
3752 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
3753 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
3754 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
3755 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
3756 Call gtk_widget_get_preferred_size.
3757 (xg_frame_resized): gdk_window_get_geometry only takes 5
3759 (xg_win_to_widget, xg_event_is_for_menubar):
3760 Call gdk_x11_window_lookup_for_display.
3761 (xg_set_widget_bg): New function.
3762 (delete_cb): New function.
3763 (xg_create_frame_widgets): Connect delete-event to delete_cb.
3764 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
3765 (xg_set_background_color): Call xg_set_widget_bg.
3766 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
3767 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
3768 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
3769 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
3771 (update_frame_tool_bar): Call gtk_widget_hide.
3772 (xg_initialize): Use GDK_KEY_g.
3774 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
3776 (x_session_initialize): Call gdk_x11_set_sm_client_id.
3778 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
3779 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
3780 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
3782 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
3784 * w32xfns.c (select_palette): Check success of RealizePalette against
3785 GDI_ERROR, not zero.
3787 See ChangeLog.11 for earlier changes.
3793 Copyright (C) 2011 Free Software Foundation, Inc.
3795 This file is part of GNU Emacs.
3797 GNU Emacs is free software: you can redistribute it and/or modify
3798 it under the terms of the GNU General Public License as published by
3799 the Free Software Foundation, either version 3 of the License, or
3800 (at your option) any later version.
3802 GNU Emacs is distributed in the hope that it will be useful,
3803 but WITHOUT ANY WARRANTY; without even the implied warranty of
3804 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
3805 GNU General Public License for more details.
3807 You should have received a copy of the GNU General Public License
3808 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.