]> code.delx.au - gnu-emacs/blob - src/ChangeLog
Install some window-size related functions and window-list-1.
[gnu-emacs] / src / ChangeLog
1 2011-06-07 Martin Rudalics <rudalics@gmx.at>
2
3 * window.c (Fwindow_total_size, Fwindow_left_column)
4 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5 (Fwindow_list_1): New functions.
6 (window_box_text_cols): Replace with window_body_cols.
7 (Fwindow_width, Fscroll_left, Fscroll_right): Use
8 window_body_cols instead of window_box_text_cols.
9
10 * window.h: Extern window_body_cols instead of
11 window_box_text_cols.
12
13 * indent.c (compute_motion, Fcompute_motion): Use
14 window_body_cols instead of window_box_text_cols.
15
16 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
17
18 * fns.c (Fputhash): Document return value.
19
20 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
21
22 * image.c (gif_load): Implement gif89a spec "no disposal" method.
23
24 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
25
26 Cons<->int and similar integer overflow fixes (Bug#8794).
27
28 Check for overflow when converting integer to cons and back.
29 * charset.c (Fdefine_charset_internal, Fdecode_char):
30 Use cons_to_unsigned to catch overflow.
31 (Fencode_char): Use INTEGER_TO_CONS.
32 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
33 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
34 * data.c (long_to_cons, cons_to_long): Remove.
35 (cons_to_unsigned, cons_to_signed): New functions.
36 These signal an error for invalid or out-of-range values.
37 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
38 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
39 * font.c (Ffont_variation_glyphs):
40 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
41 * lisp.h: Include <intprops.h>.
42 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
43 (cons_to_signed, cons_to_unsigned): New decls.
44 (long_to_cons, cons_to_long): Remove decls.
45 * undo.c (record_first_change): Use INTEGER_TO_CONS.
46 (Fprimitive_undo): Use CONS_TO_INTEGER.
47 * xfns.c (Fx_window_property): Likewise.
48 * xselect.c: Include <limits.h>.
49 (x_own_selection, selection_data_to_lisp_data):
50 Use INTEGER_TO_CONS.
51 (x_handle_selection_request, x_handle_selection_clear)
52 (x_get_foreign_selection, Fx_disown_selection_internal)
53 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
54 (lisp_data_to_selection_data): Use cons_to_unsigned.
55 (x_fill_property_data): Use cons_to_signed.
56 Report values out of range.
57
58 Check for buffer and string overflow more precisely.
59 * buffer.h (BUF_BYTES_MAX): New macro.
60 * lisp.h (STRING_BYTES_MAX): New macro.
61 * alloc.c (Fmake_string):
62 * character.c (string_escape_byte8):
63 * coding.c (coding_alloc_by_realloc):
64 * doprnt.c (doprnt):
65 * editfns.c (Fformat):
66 * eval.c (verror):
67 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
68 since they may not be the same number.
69 * editfns.c (Finsert_char):
70 * fileio.c (Finsert_file_contents):
71 Likewise for BUF_BYTES_MAX.
72
73 * image.c: Use ptrdiff_t, not int, for sizes.
74 (slurp_file): Switch from int to ptrdiff_t.
75 All uses changed.
76 (slurp_file): Check that file size fits in both size_t (for
77 malloc) and ptrdiff_t (for sanity and safety).
78
79 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
80 if b->modtime has its maximal value.
81
82 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
83
84 Don't assume time_t can fit into int.
85 * buffer.h (struct buffer.modtime): Now time_t, not int.
86 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
87 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
88
89 Minor fixes for signed vs unsigned integers.
90 * character.h (MAYBE_UNIFY_CHAR):
91 * charset.c (maybe_unify_char):
92 * keyboard.c (read_char, reorder_modifiers):
93 XINT -> XFASTINT, since the integer must be nonnegative.
94 * ftfont.c (ftfont_spec_pattern):
95 * keymap.c (access_keymap, silly_event_symbol_error):
96 XUINT -> XFASTINT, since the integer must be nonnegative.
97 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
98 since it makes no difference and we prefer signed.
99 * keyboard.c (record_char): Use XUINT when all the neighbors do.
100 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
101 nonnegative.
102
103 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
104
105 * window.h (Fwindow_frame): Declare.
106
107 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
108
109 * alloc.c: Simplify handling of large-request failures (Bug#8800).
110 (SPARE_MEMORY): Always define.
111 (LARGE_REQUEST): Remove.
112 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
113
114 2011-06-06 Martin Rudalics <rudalics@gmx.at>
115
116 * lisp.h: Move EXFUNS for Fframe_root_window,
117 Fframe_first_window and Fset_frame_selected_window to window.h.
118
119 * window.h: Move EXFUNS for Fframe_root_window,
120 Fframe_first_window and Fset_frame_selected_window here from
121 lisp.h.
122
123 * frame.c (Fwindow_frame, Fframe_first_window)
124 (Fframe_root_window, Fframe_selected_window)
125 (Fset_frame_selected_window): Move to window.c.
126 (Factive_minibuffer_window): Move to minibuf.c.
127 (Fother_visible_frames_p): New function.
128
129 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
130
131 * window.c (decode_window, decode_any_window): Move up in code.
132 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
133 (inhibit_frame_unsplittable): Remove unused variable.
134 (Fwindow_buffer): Move up and rewrite doc-string.
135 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
136 (Fwindow_prev): New functions.
137 (Fwindow_frame): Move here from frame.c. Accept any window as
138 argument.
139 (Fframe_root_window, Fframe_first_window)
140 (Fframe_selected_window): Move here from frame.c. Accept frame
141 or arbitrary window as argument. Update doc-strings.
142 (Fminibuffer_window): Move up in code.
143 (Fwindow_minibuffer_p): Move up in code and simplify.
144 (Fset_frame_selected_window): Move here from frame.c.
145 Marginal rewrite.
146 (Fselected_window, select_window, Fselect_window): Move up in
147 code. Minor doc-string fixes.
148
149 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
150
151 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
152 Do not assume that spare memory exists; that assumption is valid
153 only if SYSTEM_MALLOC.
154 (LARGE_REQUEST): New macro, so that the issue of large requests
155 is separated from the issue of spare memory.
156
157 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
158
159 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
160 format. (Bug#8806)
161
162 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
163
164 * xfns.c (x_set_scroll_bar_default_width): Move declarations
165 before statements.
166
167 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
168
169 * gtkutil.c (xg_get_default_scrollbar_width): New function.
170
171 * gtkutil.h: Declare xg_get_default_scrollbar_width.
172
173 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
174 min width by calling x_set_scroll_bar_default_width (Bug#8505).
175
176 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
177
178 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
179
180 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
181
182 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
183 (x_clipboard_manager_save): Add return value.
184 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
185 New error handlers.
186 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
187 Obey Vx_select_enable_clipboard_manager. Catch errors in
188 x_clipboard_manager_save (Bug#8779).
189 (Vx_select_enable_clipboard_manager): New variable.
190 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
191
192 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
193
194 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
195
196 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
197
198 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
199 in the current matrix if keep_current_p is non-zero.
200
201 2011-06-04 Eli Zaretskii <eliz@gnu.org>
202
203 * bidi.c (bidi_level_of_next_char): Fix last change.
204
205 2011-06-03 Eli Zaretskii <eliz@gnu.org>
206
207 Support bidi reordering of text covered by display properties.
208
209 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
210 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
211 (bidi_cache_search, bidi_cache_iterator_state)
212 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
213 (bidi_level_of_next_char, bidi_move_to_visually_next):
214 Support character positions inside a run of characters covered by a
215 display string.
216 (bidi_paragraph_init, bidi_resolve_explicit_1)
217 (bidi_level_of_next_char): Call bidi_fetch_char and
218 bidi_fetch_char_advance instead of FETCH_CHAR and
219 FETCH_CHAR_ADVANCE.
220 (bidi_init_it): Initialize new members.
221 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
222 definitions.
223 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
224 instead of using explicit *_CHAR codes.
225 (bidi_resolve_explicit, bidi_resolve_weak):
226 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
227 bidirectional text is supported only in multibyte buffers.
228 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
229 it to initialize the frame_window_p member of struct bidi_it.
230 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
231 (bidi_resolve_explicit, bidi_resolve_weak)
232 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
233 bidi_it->nchars is non-positive.
234 (bidi_level_of_next_char): Don't try to lookup the cache for the
235 next/previous character if nothing is cached there yet, or if we
236 were just reseat()'ed to a new position.
237
238 * xdisp.c (set_cursor_from_row): Set start and stop points
239 according to the row's direction when priming the loop that looks
240 for the glyph on which to display cursor.
241 (single_display_spec_intangible_p): Function deleted.
242 (display_prop_intangible_p): Reimplement to call
243 handle_display_spec instead of single_display_spec_intangible_p.
244 Accept 3 additional arguments needed by handle_display_spec.
245 This fixes incorrect cursor motion across display property with complex
246 values: lists, `(when COND...)' forms, etc.
247 (single_display_spec_string_p): Support property values that are
248 lists with the argument STRING its top-level element.
249 (display_prop_string_p): Fix the condition for processing a
250 property that is a list to be consistent with handle_display_spec.
251 (handle_display_spec): New function, refactored from the
252 last portion of handle_display_prop.
253 (compute_display_string_pos): Accept additional argument
254 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
255 value of a `display' property is a "replacing spec".
256 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
257 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
258 the display property, but just return a value indicating whether
259 the display property will replace the characters it covers.
260 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
261 frame_window_p members of struct bidi_it.
262 (compute_display_string_pos, compute_display_string_end):
263 New functions.
264 (push_it): Accept second argument POSITION, where pop_it should
265 jump to continue iteration.
266 (reseat_1): Initialize bidi_it.disp_pos.
267
268 * keyboard.c (adjust_point_for_property): Adjust the call to
269 display_prop_intangible_p to its new signature.
270
271 * dispextern.h (struct bidi_it): New member frame_window_p.
272 (bidi_init_it): Update prototypes.
273 (display_prop_intangible_p): Update prototype.
274 (compute_display_string_pos, compute_display_string_end):
275 Declare prototypes.
276 (struct bidi_it): New members nchars and disp_pos. ch_len is now
277 EMACS_INT.
278
279 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
280
281 Malloc failure behavior now depends on size of allocation.
282 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
283 * lisp.h: Change signatures accordingly.
284 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
285 All callers changed. (Bug#8762)
286
287 * gnutls.c: Use Emacs's memory allocators.
288 Without this change, the gnutls library would invoke malloc etc.
289 directly, which causes problems on non-SYNC_INPUT hosts, and which
290 runs afoul of improving memory_full behavior. (Bug#8761)
291 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
292 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
293 xfree instead of the default malloc, realloc, free.
294 (Fgnutls_boot): No need to check for memory allocation failure,
295 since xmalloc does that for us.
296
297 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
298 * category.c (hash_get_category_set):
299 * ccl.c (ccl_driver):
300 * charset.c (Fdefine_charset_internal):
301 * charset.h (struct charset.hash_index):
302 * composite.c (get_composition_id, gstring_lookup_cache)
303 (composition_gstring_put_cache):
304 * composite.h (struct composition.hash_index):
305 * dispextern.h (struct image.hash):
306 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
307 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
308 (hashfn_equal, hashfn_user_defined, make_hash_table)
309 (maybe_resize_hash_table, hash_lookup, hash_put)
310 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
311 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
312 (Fsxhash, Fgethash, Fputhash, Fmaphash):
313 * image.c (make_image, search_image_cache, lookup_image)
314 (xpm_put_color_table_h):
315 * lisp.h (struct Lisp_Hash_Table):
316 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
317 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
318 for hashes and hash indexes, instead of 'unsigned' and 'int'.
319 * alloc.c (allocate_vectorlike):
320 Check for overflow in vector size calculations.
321 * ccl.c (ccl_driver):
322 Check for overflow when converting EMACS_INT to int.
323 * fns.c, image.c: Remove unnecessary static decls that would otherwise
324 need to be updated by these changes.
325 * fns.c (make_hash_table, maybe_resize_hash_table):
326 Check for integer overflow with large hash tables.
327 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
328 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
329 (SXHASH_REDUCE): New macro.
330 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
331 Use it instead of discarding useful hash info with large hash values.
332 (sxhash_float): New function.
333 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
334 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
335 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
336 Rewrite to use FIXNUM_BITS, as this simplifies things.
337 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
338 Adjust signatures to match updated version of code.
339 (consing_since_gc): Now EMACS_INT, since a single hash table can
340 use more than INT_MAX bytes.
341
342 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
343
344 Make it possible to build with GCC-4.6+ -O2 -flto.
345
346 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
347
348 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
349
350 * minibuf.c (get_minibuffer, read_minibuf_unwind):
351 Call minibuffer-inactive-mode.
352
353 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
354
355 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
356 Update dependencies.
357
358 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
359
360 * data.c (init_data): Remove code for UTS, this system is not
361 supported anymore.
362
363 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
364
365 Don't force ./temacs to start in terminal mode.
366
367 * frame.c (make_initial_frame): Initialize faces in all cases, not
368 only when CANNOT_DUMP is defined.
369 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
370
371 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
372
373 * dispnew.c (add_window_display_history): Use const for the string
374 pointer. Remove declaration, not needed.
375
376 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
377
378 Use 'inline', not 'INLINE'.
379 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
380 * alloc.c, fontset.c (INLINE): Remove.
381 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
382 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
383 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
384 * gmalloc.c (register_heapinfo): Use inline unconditionally.
385 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
386
387 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
388
389 Make it possible to run ./temacs.
390
391 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
392 syms_of_callproc does the same thing. Remove test for
393 "initialized", do it in the caller.
394 * emacs.c (main): Avoid calling set_initial_environment when dumping.
395
396 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
397
398 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
399 (read_minibuf): Use get_minibuffer.
400 (syms_of_minibuf): Use DEFSYM.
401 (Qmetadata): New var.
402 * data.c (Qbuffer): Don't make it static.
403 (syms_of_data): Use DEFSYM.
404
405 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
406
407 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
408 (CCL_CODE_MIN): New macro.
409
410 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
411
412 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
413
414 * eval.c (Qdebug): Now static.
415 * lisp.h (Qdebug): Remove decl. This reverts a part of the
416 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
417 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
418
419 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
420
421 * image.c: Various fixes to ImageMagick code comments.
422 (Fimagemagick_types): Doc fix.
423
424 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
425
426 Minor fixes prompted by GCC 4.6.0 warnings.
427
428 * xselect.c (converted_selections, conversion_fail_tag): Now static.
429
430 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
431 (x_clipboard_manager_save_all): Move extern decl to ...
432 * xterm.h: ... here, so that it can be checked for consistency.
433
434 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
435
436 * xselect.c (x_clipboard_manager_save_frame)
437 (x_clipboard_manager_save_all): New functions.
438 (Fx_clipboard_manager_save): Lisp function deleted.
439
440 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
441 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
442
443 * xterm.h: Update prototype.
444
445 2011-05-28 William Xu <william.xwl@gmail.com>
446
447 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
448 exiting (Bug#8239).
449
450 2011-05-28 Jim Meyering <meyering@redhat.com>
451
452 Avoid a sign-extension bug in crypto_hash_function.
453 * fns.c (to_uchar): Define.
454 (crypto_hash_function): Use it to convert some newly-signed
455 variables to unsigned, to avoid sign-extension bugs. For example,
456 without this change, (md5 "truc") would evaluate to
457 45723a2aff78ff4fff7fff1114760e62 rather than the expected
458 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
459 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
460
461 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
462
463 Integer overflow fixes.
464
465 * dbusbind.c: Serial number integer overflow fixes.
466 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
467 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
468 to hold a serial number that is too large for a fixnum.
469 (Fdbus_method_return_internal, Fdbus_method_error_internal):
470 Check for serial numbers out of range. Decode any serial number
471 that was so large that it became a float. (Bug#8722)
472
473 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
474 (Fdbus_call_method, Fdbus_call_method_asynchronously):
475 Use XFASTINT rather than XUINT when numbers are nonnegative.
476 (xd_append_arg, Fdbus_method_return_internal):
477 (Fdbus_method_error_internal): Likewise. Also, for unsigned
478 arguments, check that Lisp number is nonnegative, rather than
479 silently wrapping negative numbers around. (Bug#8722)
480 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
481 (Bug#8722)
482
483 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
484
485 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
486
487 ccl: add integer overflow checks
488 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
489 (IN_INT_RANGE): New macros.
490 (ccl_driver): Use them to check for integer overflow when
491 decoding a CCL program. Many of the new checks are whether XINT (x)
492 fits in int; it doesn't always, on 64-bit hosts. The new version
493 doesn't catch all possible integer overflows, but it's an
494 improvement. (Bug#8719)
495
496 * alloc.c (make_event_array): Use XINT, not XUINT.
497 There's no need for unsigned here.
498
499 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
500 This follows up to the 2011-05-06 change that substituted uintptr_t
501 for EMACS_INT. This case wasn't caught back then.
502
503 Rework Fformat to avoid integer overflow issues.
504 * editfns.c: Include <float.h> unconditionally, as it's everywhere
505 now (part of C89). Include <verify.h>.
506 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
507 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
508 (Fformat): Avoid the prepass trying to compute sizes; it was only
509 approximate and thus did not catch overflow reliably. Instead, walk
510 through the format just once, formatting and computing sizes as we go,
511 checking for integer overflow at every step, and allocating a larger
512 buffer as needed. Keep track separately whether the format is
513 multibyte. Keep only the most-recently calculated precision, rather
514 than them all. Record whether each argument has been converted to
515 string. Use EMACS_INT, not int, for byte and char and arg counts.
516 Support field widths and precisions larger than INT_MAX. Avoid
517 sprintf's undefined behavior with conversion specifications such as %#d
518 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
519 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
520 formatting out-of-range floating point numbers with int
521 formats. (Bug#8668)
522
523 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
524
525 * data.c: Avoid integer truncation in expressions involving floats.
526 * data.c: Include <intprops.h>.
527 (arith_driver): When there's an integer overflow in an expression
528 involving floating point, convert the integers to floating point
529 so that the resulting value does not suffer from catastrophic
530 integer truncation. For example, on a 64-bit host (* 4
531 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
532 Do not rely on undefined behavior after integer overflow.
533
534 merge count_size_as_multibyte, parse_str_to_multibyte
535 * character.c, character.h (count_size_as_multibyte):
536 Rename from parse_str_to_multibyte; all uses changed.
537 Check for integer overflow.
538 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
539 since it's now a duplicate of the other. This is more of
540 a character than a buffer op, so better that it's in character.c.
541 * fns.c, print.c: Adjust to above changes.
542
543 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
544
545 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
546
547 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
548
549 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
550 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
551 (x_clipboard_manager_save): Now static.
552 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
553
554 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
555 (crypto_hash_function): Now static.
556 Fix pointer signedness problems. Avoid unnecessary initializations.
557
558 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
559
560 * termhooks.h (Vselection_alist): Make it terminal-local.
561
562 * terminal.c (create_terminal): Initialize it.
563
564 * xselect.c: Support for clipboard managers.
565 (Vselection_alist): Move to termhooks.h as terminal-local var.
566 (LOCAL_SELECTION): New macro.
567 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
568 (symbol_to_x_atom): Remove gratuitous arg.
569 (x_handle_selection_request, lisp_data_to_selection_data)
570 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
571 (x_own_selection, x_get_local_selection, x_convert_selection):
572 New arg, specifying work frame. Use terminal-local Vselection_alist.
573 (some_frame_on_display): Delete unused function.
574 (Fx_own_selection_internal, Fx_get_selection_internal)
575 (Fx_disown_selection_internal, Fx_selection_owner_p)
576 (Fx_selection_exists_p): New optional frame arg.
577 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
578 (x_handle_selection_clear): Don't treat other terminals with the
579 same keyboard specially. Use the terminal-local Vselection_alist.
580 (x_clear_frame_selections): Use Frun_hook_with_args.
581
582 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
583
584 * xterm.h: Add support for those atoms.
585
586 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
587
588 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
589 (converted_selections, conversion_fail_tag): New global variables.
590 (x_selection_request_lisp_error): Free the above.
591 (x_get_local_selection): Remove unnecessary code.
592 (x_reply_selection_request): Args changed; handle arbitrary array
593 of converted selections stored in converted_selections.
594 Separate the XChangeProperty and SelectionNotify steps.
595 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
596 (x_convert_selection): New function.
597 (x_handle_selection_event): Simplify.
598 (x_get_foreign_selection): Don't ignore incoming requests while
599 waiting for an answer; this will fail when we implement
600 SAVE_TARGETS, and seems unnecessary anyway.
601 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
602 (Vx_sent_selection_functions): Doc fix.
603
604 2011-05-26 Leo Liu <sdl.web@gmail.com>
605
606 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
607
608 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
609
610 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
611
612 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
613 for fringe update if it has periodic bitmap.
614 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
615 and fringe_bitmap_periodic_p.
616
617 * fringe.c (get_fringe_bitmap_data): New function.
618 (draw_fringe_bitmap_1, update_window_fringes): Use it.
619 (update_window_fringes): Record periodicity of fringe bitmap in glyph
620 row. Mark glyph row for fringe update if periodicity changed.
621
622 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
623 for fringe update unless it has periodic bitmap.
624
625 2011-05-25 Kenichi Handa <handa@m17n.org>
626
627 * xdisp.c (get_next_display_element): Set correct it->face_id for
628 a static composition.
629
630 2011-05-24 Leo Liu <sdl.web@gmail.com>
631
632 * deps.mk (fns.o):
633 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
634
635 * fns.c (crypto_hash_function, Fsha1): New function.
636 (Fmd5): Use crypto_hash_function.
637 (syms_of_fns): Add Ssha1.
638
639 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
640
641 * gnutls.c: Remove unused macros.
642 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
643 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
644 Remove macros that are defined and never used.
645 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
646
647 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
648
649 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
650 (Fx_get_selection_internal): Minor cleanup.
651 (Fx_own_selection_internal): Rename arguments for consistency with
652 select.el.
653
654 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
655
656 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
657
658 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
659
660 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
661
662 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
663
664 * dispnew.c (scrolling_window): Don't exclude the case that the
665 last enabled row in the desired matrix touches the bottom boundary.
666
667 2011-05-21 Glenn Morris <rgm@gnu.org>
668
669 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
670 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
671 and add some more files.
672
673 2011-05-20 Eli Zaretskii <eliz@gnu.org>
674
675 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
676 report_file_error introduced by the change from 2011-05-07.
677
678 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
679
680 * systime.h (Time): Define only if emacs is defined.
681 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
682 where the include path doesn't have X11/X.h by default. See
683 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
684
685 2011-05-20 Kenichi Handa <handa@m17n.org>
686
687 * composite.c (find_automatic_composition): Fix previous change.
688
689 2011-05-20 Glenn Morris <rgm@gnu.org>
690
691 * lisp.mk: New file, split from Makefile.in.
692 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
693 (shortlisp): Remove.
694 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
695
696 2011-05-19 Glenn Morris <rgm@gnu.org>
697
698 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
699 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
700 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
701 (lisp): Set the order to that of loadup.el.
702 (shortlisp): Make it a copy of $lisp.
703 (SOME_MACHINE_LISP): Remove.
704 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
705 Use just $shortlisp, not $SOME_MACHINE_LISP too.
706
707 2011-05-18 Kenichi Handa <handa@m17n.org>
708
709 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
710 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
711 (find_automatic_composition): Mostly rewrite for efficiency.
712
713 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
714
715 * makefile.w32-in: Update dependencies.
716
717 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
718
719 * menu.c: Include limits.h (fixes the MS-Windows build broken by
720 revision 104625).
721
722 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
723
724 Fix some integer overflow issues, such as string length overflow.
725
726 * insdel.c (count_size_as_multibyte): Check for string overflow.
727
728 * character.c (lisp_string_width): Check for string overflow.
729 Use EMACS_INT, not int, for string indexes and lengths; in
730 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
731 the resulting string length overflows an EMACS_INT; instead,
732 report a string overflow if no precision given. When checking for
733 precision exhaustion, use a check that cannot possibly have
734 integer overflow. (Bug#8675)
735 * character.h (lisp_string_width): Adjust to new signature.
736
737 * alloc.c (string_overflow): New function.
738 (Fmake_string): Use it. This doesn't change behavior, but saves
739 a few bytes and will simplify future changes.
740 * character.c (string_escape_byte8): Likewise.
741 * lisp.h (string_overflow): New decl.
742
743 Fixups, following up to the user-interface timestamp change.
744 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
745 for UI timestamps, instead of unsigned long.
746 * msdos.c (mouse_get_pos): Likewise.
747 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
748 * w32gui.h (Time): Define by including "systime.h" rather than by
749 declaring it ourselves. (Bug#8664)
750
751 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
752 * image.c (clear_image_cache): Likewise.
753
754 * term.c (term_mouse_position): Don't assume time_t wraparound.
755
756 Be more systematic about user-interface timestamps.
757 Before, the code sometimes used 'Time', sometimes 'unsigned long',
758 and sometimes 'EMACS_UINT', to represent these timestamps.
759 This change causes it to use 'Time' uniformly, as that's what X uses.
760 This makes the code easier to follow, and makes it easier to catch
761 integer overflow bugs such as Bug#8664.
762 * frame.c (Fmouse_position, Fmouse_pixel_position):
763 Use Time, not unsigned long, for user-interface timestamps.
764 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
765 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
766 * keyboard.h (last_event_timestamp): Likewise.
767 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
768 * menu.h (xmenu_show): Likewise.
769 * term.c (term_mouse_position): Likewise.
770 * termhooks.h (struct input_event.timestamp): Likewise.
771 (struct terminal.mouse_position_hook): Likewise.
772 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
773 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
774 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
775 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
776 what it was before.
777 * menu.h, termhooks.h: Include "systime.h", for Time.
778
779 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
780 Don't assume that the difference between two unsigned long values
781 can fit into an integer. At this point, we know button_down_time
782 <= event->timestamp, so the difference must be nonnegative, so
783 there's no need to cast the result if double-click-time is
784 nonnegative, as it should be; check that it's nonnegative, just in
785 case. This bug is triggered when events are more than 2**31 ms
786 apart (about 25 days). (Bug#8664)
787
788 * xselect.c (last_event_timestamp): Remove duplicate decl.
789 (x_own_selection): Remove needless cast to unsigned long.
790
791 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
792 that always fit in int. Use a sentinel instead of a counter, to
793 avoid a temp and to allay GCC's concerns about possible int overflow.
794 * frame.h (struct frame): Use int for menu_bar_items_used
795 instead of EMACS_INT, since it always fits in int.
796
797 * menu.c (grow_menu_items): Check for int overflow.
798
799 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
800
801 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
802 Before, the code was not consistent. These values cannot exceed
803 2**31 - 1 so there's no need to make them unsigned.
804 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
805 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
806 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
807 as modifiers.
808 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
809
810 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
811 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
812 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
813 presumably because the widths might not match.
814
815 * window.c (size_window): Avoid needless test at loop start.
816
817 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
818
819 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
820
821 2011-05-12 Drew Adams <drew.adams@oracle.com>
822
823 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
824
825 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
826
827 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
828 `width' to `bar_area_x' and `bar_area_width', respectively.
829 (x_scroll_run): Take account of fringe background extension.
830
831 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
832 Rename local vars `left' and `width' to `bar_area_x' and
833 `bar_area_width', respectively.
834 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
835 background extension.
836
837 2011-05-10 Jim Meyering <meyering@redhat.com>
838
839 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
840
841 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
842
843 * image.c (Finit_image_library): Return t for built-in image types,
844 like pbm and xbm. (Bug#8640)
845
846 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
847
848 * w32menu.c (set_frame_menubar): Fix submenu allocation.
849
850 2011-05-07 Eli Zaretskii <eliz@gnu.org>
851
852 * w32console.c (Fset_screen_color): Doc fix.
853 (Fget_screen_color): New function.
854 (syms_of_ntterm): Defsubr it.
855
856 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
857 unlink the temporary file if Fcall_process didn't create it in the
858 first place.
859 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
860 child process will be redirected to a file specified with `:file'.
861 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
862 cue to call_process_cleanup not to close that handle.
863
864 2011-05-07 Ben Key <bkey76@gmail.com>
865
866 * makefile.w32-in: The bootstrap-temacs rule now makes use of
867 one of two shell specific rules, either bootstrap-temacs-CMD or
868 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
869 to the previous implementation of the bootstrap-temacs rule.
870 The bootstrap-temacs-CMD rule is similar to the previous
871 implementation of the bootstrap-temacs rule except that it
872 makes use of the ESC_CFLAGS variable instead of the CFLAGS
873 variable.
874
875 These changes, along with some changes to nt/configure.bat,
876 nt/gmake.defs, and nt/nmake.defs, are required to extend my
877 earlier fix to add support for --cflags and --ldflags options
878 that include quotes so that it works whether make uses cmd or
879 sh as the shell.
880
881 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
882
883 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
884 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
885 is a constant.
886 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
887 a string. Handle both cases.
888 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
889 (Fdbus_register_method): Use Qinvalid_function.
890
891 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
892
893 * makefile.w32-in: Update dependencies.
894 (LISP_H): Add inttypes.h and stdin.h.
895 (PROCESS_H): Add unistd.h.
896
897 2011-05-06 Eli Zaretskii <eliz@gnu.org>
898
899 * lread.c: Include limits.h (fixes the MS-Windows build broken by
900 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
901
902 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
903
904 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
905
906 * term.c (vfatal): Remove stray call to va_end.
907 It's not needed and the C Standard doesn't allow it here anyway.
908
909 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
910 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
911
912 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
913 bytes.
914
915 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
916
917 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
918
919 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
920
921 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
922
923 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
924
925 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
926 * charset.c (Fdefine_charset_internal): Don't initialize
927 charset.code_space[15]. The value was garbage, on hosts with
928 32-bit int (Bug#8600).
929
930 * lread.c (read_integer): Be more consistent with string-to-number.
931 Use string_to_number to do the actual conversion; this avoids
932 rounding errors and fixes some other screwups. Without this fix,
933 for example, #x1fffffffffffffff was misread as -2305843009213693952.
934 (digit_to_number): Move earlier, for benefit of read_integer.
935 Return -1 if the digit is out of range for the base, -2 if it is
936 not a digit in any supported base. (Bug#8602)
937
938 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
939
940 * dispnew.c (scrolling_window): Return 1 if we scrolled,
941 to match comment at start of function. This also removes a
942 GCC warning about overflow in a 32+64-bit port.
943
944 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
945
946 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
947 Reported by Stefan Monnier in
948 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
949 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
950 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
951
952 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
953 (EMACS_UINTPTR): Likewise, with uintptr_t.
954
955 * lisp.h: Prefer 64-bit EMACS_INT if available.
956 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
957 on 32-bit hosts that have 64-bit int, so that they can access
958 large files.
959 However, temporarily disable this change unless the temporary
960 symbol WIDE_EMACS_INT is defined.
961
962 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
963
964 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
965 This removes an assumption that EMACS_INT and long are the same
966 width as pointers. The assumption is true for Emacs porting targets
967 now, but we want to make other targets possible.
968 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
969 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
970 In the rest of the code, change types of integers that hold casted
971 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
972 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
973 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
974 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
975 No need to cast type when ORing.
976 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
977 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
978 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
979 assume EMACS_INT is the same width as char *.
980 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
981 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
982 Remove no-longer-needed casts.
983 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
984 (xg_tool_bar_help_callback, xg_make_tool_item):
985 Use EMACS_INTPTR to hold an integer
986 that will be cast to void *; this can avoid a GCC warning
987 if EMACS_INT is not the same width as void *.
988 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
989 * xdisp.c (display_echo_area_1, resize_mini_window_1):
990 (current_message_1, set_message_1):
991 Use a local to convert to proper width without a cast.
992 * xmenu.c (dialog_selection_callback): Likewise.
993
994 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
995 Also, don't assume VALBITS / RAND_BITS is less than 5,
996 and don't rely on undefined behavior when shifting a 1 left into
997 the sign bit.
998 * lisp.h (get_random): Change signature to match.
999
1000 * lread.c (hash_string): Use size_t, not int, for hash computation.
1001 Normally we prefer signed values; but hashing is special, because
1002 it's better to use unsigned division on hash table sizes so that
1003 the remainder is nonnegative. Also, size_t is the natural width
1004 for hashing into memory. The previous code used 'int', which doesn't
1005 retain enough info to hash well into very large tables.
1006 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1007
1008 * dbusbind.c: Don't possibly lose pointer info when converting.
1009 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1010 Use XPNTR rather than XHASH, so that the high-order bits of
1011 the pointer aren't lost when converting through void *.
1012
1013 * eval.c (Fautoload): Don't double-shift a pointer.
1014
1015 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1016
1017 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1018
1019 * gnutls.c (DEF_GNUTLS_FN):
1020 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1021
1022 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1023
1024 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1025 marker. (Bug#8610)
1026
1027 2011-05-05 Eli Zaretskii <eliz@gnu.org>
1028
1029 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1030 New version that can reserve upto 2GB of heap space.
1031
1032 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
1033
1034 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1035
1036 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1037
1038 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1039 `gnutls_certificate_set_x509_key_file'.
1040
1041 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
1042
1043 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1044 Update dependencies.
1045
1046 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1047
1048 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1049 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1050 Remove unused parameter `fildes'.
1051 * process.c (read_process_output, send_process): Don't pass it.
1052
1053 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1054
1055 Fix previous change: the library cache is defined in w32.c.
1056 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1057 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1058
1059 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1060
1061 Implement dynamic loading of GnuTLS on Windows.
1062
1063 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1064 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1065 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1066 Declare.
1067
1068 * gnutls.c (Qgnutls_dll): Define.
1069 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1070 (gnutls_*): Declare function pointers.
1071 (init_gnutls_functions): New function to initialize function pointers.
1072 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1073 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1074 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1075 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1076 (emacs_gnutls_write, emacs_gnutls_read)
1077 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1078 (Fgnutls_available_p): New function.
1079 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1080 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1081 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1082
1083 * image.c: Include w32.h.
1084 (Vimage_type_cache): Delete.
1085 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1086 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1087 (w32_delayed_load): Move to w32.c.
1088
1089 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1090
1091 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1092 (w32_delayed_load): Move from image.c. When loading a library, record
1093 its filename in the :loaded-from property of the library id.
1094 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1095 Initialize and staticpro them.
1096 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1097
1098 * process.c: Include lisp.h before w32.h, not after.
1099 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1100 instead of gnutls_record_check_pending.
1101
1102 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1103
1104 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1105
1106 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1107 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1108 as passed in.
1109
1110 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1111
1112 * xterm.c (x_set_frame_alpha): Do not set property on anything
1113 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1114
1115 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1116
1117 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1118
1119 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1120
1121 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1122 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1123 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1124 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1125 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1126 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1127 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1128 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1129 (Qgnutls_bootprop_callbacks_verify): Make static.
1130
1131 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1132
1133 * callproc.c: Indentation fixup.
1134
1135 * sysdep.c (wait_for_termination_1): Make static.
1136 (wait_for_termination, interruptible_wait_for_termination):
1137 Move after wait_for_termination_1.
1138
1139 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1140
1141 * sysdep.c (interruptible_wait_for_termination): New function
1142 which is like wait_for_termination, but allows keyboard
1143 interruptions.
1144
1145 * callproc.c (Fcall_process): Add (:file "file") as an option for
1146 the STDOUT buffer.
1147 (Fcall_process_region): Ditto.
1148
1149 2011-04-30 Eli Zaretskii <eliz@gnu.org>
1150
1151 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1152 rather than `XVECTOR (FOO)->size'.
1153
1154 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1155 inttypes.h, as a gnulib replacement is used if it not available in
1156 system headers.
1157
1158 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1159
1160 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1161 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1162 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1163
1164 * coding.c (coding_alloc_by_realloc): Error out if destination
1165 will grow beyond MOST_POSITIVE_FIXNUM.
1166 (decode_coding_emacs_mule): Abort if there isn't enough place in
1167 charbuf for the composition carryover bytes. Reserve an extra
1168 space for up to 2 characters produced in a loop.
1169 (decode_coding_iso_2022): Abort if there isn't enough place in
1170 charbuf for the composition carryover bytes.
1171
1172 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1173
1174 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1175 aborting when %lld or %lll format is passed.
1176 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1177 %llo or %llx format is passed. (Bug#8545)
1178
1179 * window.c (window_scroll_line_based): Use a marker instead of
1180 simple variables to record original value of point. (Bug#7952)
1181
1182 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1183 produced by %s or %c overflows available buffer space. (Bug#8545)
1184
1185 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1186
1187 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
1188 (SIZE_MAX): Move defn after all includes, as they might #define it.
1189
1190 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1191
1192 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1193
1194 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1195
1196 * keyboard.c (Qdelayed_warnings_hook): Define.
1197 (command_loop_1): Run `delayed-warnings-hook'
1198 if Vdelayed_warnings_list is non-nil.
1199 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1200 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1201
1202 2011-04-28 Eli Zaretskii <eliz@gnu.org>
1203
1204 * doprnt.c (doprnt): Don't return value smaller than the buffer
1205 size if the message was truncated. (Bug#8545).
1206
1207 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1208
1209 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1210 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1211
1212 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1213
1214 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1215
1216 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
1217
1218 * makefile.w32-in: Update dependencies.
1219
1220 2011-04-27 Eli Zaretskii <eliz@gnu.org>
1221
1222 Improve `doprnt' and its usage. (Bug#8545)
1223 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1224 `format_end'. Remove support for %l as a conversion specifier.
1225 Don't use xrealloc. Improve diagnostics when the %l size modifier
1226 is used. Update the commentary.
1227
1228 * eval.c (verror): Simplify calculation of size_t.
1229
1230 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1231 messages.
1232
1233 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1234
1235 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1236 change.
1237
1238 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1239
1240 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1241 This makes this file independent of the recent pseudovector change.
1242
1243 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
1244
1245 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1246
1247 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
1248 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
1249 Remove unused local.
1250 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
1251
1252 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
1253 GCC 4.6.0 optimizes based on type-based alias analysis.
1254 For example, if b is of type struct buffer * and v of type struct
1255 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1256 != &v->size, and therefore "v->size = 1; b->size = 2; return
1257 v->size;" must therefore return 1. This assumption is incorrect
1258 for Emacs, since it type-puns struct Lisp_Vector * with many other
1259 types. To fix this problem, this patch adds a new type struct
1260 vectorlike_header that documents the constraints on layout of vectors
1261 and pseudovectors, and helps optimizing compilers not get fooled
1262 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1263 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
1264 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1265 the size member.
1266 (XSETPVECTYPE): Rewrite in terms of new macro.
1267 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1268 This is a bit clearer, and further avoids the possibility of
1269 undesirable aliasing.
1270 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
1271 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
1272 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1273 since Lisp_Subr is a special case (no "next" field).
1274 (ASIZE): Now uses header.size rather than size.
1275 All previous uses of XVECTOR (foo)->size replaced to use this macro,
1276 to avoid the hassle of writing XVECTOR (foo)->header.size.
1277 (struct vectorlike_header): New type.
1278 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1279 object, to help avoid aliasing.
1280 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1281 (SUBRP): Likewise, since Lisp_Subr is a special case.
1282 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1283 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1284 (struct Lisp_Hash_Table): Combine first two members into a single
1285 struct vectorlike_header member. All uses of "size" and "next" members
1286 changed to be "header.size" and "header.next".
1287 * buffer.h (struct buffer): Likewise.
1288 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1289 * frame.h (struct frame): Likewise.
1290 * process.h (struct Lisp_Process): Likewise.
1291 * termhooks.h (struct terminal): Likewise.
1292 * window.c (struct save_window_data, struct saved_window): Likewise.
1293 * window.h (struct window): Likewise.
1294 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1295 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1296 * buffer.c (init_buffer_once): Likewise.
1297 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1298 special case.
1299 * process.c (Fformat_network_address): Use local var for size,
1300 for brevity.
1301
1302 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1303
1304 Make the Lisp reader and string-to-float more consistent (Bug#8525)
1305 * data.c (atof): Remove decl; no longer used or needed.
1306 (digit_to_number): Move to lread.c.
1307 (Fstring_to_number): Use new string_to_number function, to be
1308 consistent with how the Lisp reader treats infinities and NaNs.
1309 Do not assume that floating-point numbers represent EMACS_INT
1310 without losing information; this is not true on most 64-bit hosts.
1311 Avoid double-rounding errors, by insisting on integers when
1312 parsing non-base-10 numbers, as the documentation specifies.
1313 * lisp.h (string_to_number): New decl, replacing ...
1314 (isfloat_string): Remove.
1315 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
1316 (read1): Do not accept +. and -. as integers; this
1317 appears to have been a coding error. Similarly, do not accept
1318 strings like +-1e0 as floating point numbers. Do not report
1319 overflow for integer overflows unless the base is not 10 which
1320 means we have no simple and reliable way to continue.
1321 Break out the floating-point parsing into a new
1322 function string_to_number, so that Fstring_to_number parses
1323 floating point numbers consistently with the Lisp reader.
1324 (digit_to_number): Move here from data.c. Make it static inline.
1325 (E_CHAR, EXP_INT): Remove, replacing with ...
1326 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1327 (string_to_number): New function, replacing isfloat_string.
1328 This function checks for valid syntax and produces the resulting
1329 Lisp float number too. Rework it so that string-to-number
1330 no longer mishandles examples like "1.0e+". Use strtoumax,
1331 so that overflow for non-base-10 numbers is reported only when
1332 there's no portable and simple way to convert to floating point.
1333
1334 * textprop.c (set_text_properties_1): Rewrite for clarity,
1335 and to avoid GCC warning about integer overflow.
1336
1337 * intervals.h (struct interval): Use EMACS_INT for members
1338 where EMACS_UINT might cause problems. See
1339 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
1340 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
1341 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
1342 All uses changed.
1343 (offset_intervals): Tell GCC not to worry about length overflow
1344 when negating a negative length.
1345
1346 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
1347 (overrun_check_free): Likewise.
1348
1349 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
1350 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
1351 word size.
1352
1353 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1354 (gnutls_make_error): Rename local to avoid shadowing.
1355 (gnutls_emacs_global_deinit): ifdef out; not used.
1356 (Fgnutls_boot): Use const for pointer to readonly storage.
1357 Comment out unused local. Fix pointer signedness problems.
1358
1359 * lread.c (openp): Don't stuff size_t into an 'int'.
1360 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
1361 about possible signed overflow.
1362
1363 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1364 (GDK_KEY_g): Don't define if already defined.
1365 (xg_prepare_tooltip): Avoid pointer signedness problem.
1366 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
1367
1368 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
1369 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
1370
1371 * xfns.c (Fx_window_property): Simplify a bit,
1372 to make a bit faster and to avoid GCC 4.6.0 warning.
1373 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
1374
1375 * fns.c (internal_equal): Don't assume size_t fits in int.
1376
1377 * alloc.c (compact_small_strings): Tighten assertion a little.
1378
1379 Replace pEd with more-general pI, and fix some printf arg casts.
1380 * lisp.h (pI): New macro, generalizing old pEd macro to other
1381 conversion specifiers. For example, use "...%"pI"d..." rather
1382 than "...%"pEd"...".
1383 (pEd): Remove. All uses replaced with similar uses of pI.
1384 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
1385 * alloc.c (check_pure_size): Don't overflow by converting size to int.
1386 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
1387 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
1388 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
1389 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
1390 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
1391 64-bit hosts.
1392 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
1393 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
1394 * print.c (safe_debug_print, print_object): Likewise.
1395 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
1396 to int.
1397 Use pI instead of if-then-else-abort. Use %p to avoid casts,
1398 avoiding the 0 flag, which is not portable.
1399 * process.c (Fmake_network_process): Use pI to avoid cast.
1400 * region-cache.c (pp_cache): Likewise.
1401 * xdisp.c (decode_mode_spec): Likewise.
1402 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
1403 behavior on 64-bit hosts with printf arg.
1404 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
1405 (x_stop_queuing_selection_requests): Likewise.
1406 (x_get_window_property): Don't truncate byte count to an 'int'
1407 when tracing.
1408
1409 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
1410 here, since it parses constructs like leading '-' and spaces,
1411 which are not wanted; and it overflows with large numbers.
1412 Instead, simply match F[0-9]+, which is what is wanted anyway.
1413
1414 * alloc.c: Remove unportable assumptions about struct layout.
1415 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
1416 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
1417 (allocate_vectorlike, make_pure_vector): Use the new macros,
1418 plus offsetof, to remove unportable assumptions about struct layout.
1419 These assumptions hold on all porting targets that I know of, but
1420 they are not guaranteed, they're easy to remove, and removing them
1421 makes further changes easier.
1422
1423 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
1424 This doesn't fix a bug but makes the code clearer.
1425 (string_overrun_cookie): Now const. Use initializers that
1426 don't formally overflow signed char, to avoid warnings.
1427 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
1428 can cause Emacs to crash when string overrun checking is enabled.
1429 (allocate_buffer): Don't assume sizeof (struct buffer) is a
1430 multiple of sizeof (EMACS_INT); it need not be, if
1431 alignof(EMACS_INT) < sizeof (EMACS_INT).
1432 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
1433
1434 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
1435
1436 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1437
1438 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1439
1440 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
1441 supposed to be handshaking. (Bug#8556)
1442 Reported by Paul Eggert <eggert@cs.ucla.edu>.
1443
1444 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
1445
1446 * lisp.h (Qdebug): List symbol.
1447 * eval.c (Qdebug): Restore global linkage.
1448 * keyboard.c (debug-on-event): New variable.
1449 (handle_user_signal): Break into debugger when debug-on-event
1450 matches the current signal symbol.
1451
1452 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
1453
1454 * alloc.c (check_sblock, check_string_bytes)
1455 (check_string_free_list): Convert to standard C.
1456
1457 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
1458
1459 * w32.c (emacs_gnutls_push): Fix typo.
1460
1461 2011-04-25 Eli Zaretskii <eliz@gnu.org>
1462
1463 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
1464 "cast to pointer from integer of different size".
1465
1466 Improve doprnt and its use in verror. (Bug#8545)
1467 * doprnt.c (doprnt): Document the set of format control sequences
1468 supported by the function. Use SAFE_ALLOCA instead of always
1469 using `alloca'.
1470
1471 * eval.c (verror): Don't limit the buffer size at size_max-1, that
1472 is one byte too soon. Don't use xrealloc; instead xfree and
1473 xmalloc anew.
1474
1475 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
1476
1477 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
1478 callbacks stage.
1479
1480 * gnutls.c: Renamed global_initialized to
1481 gnutls_global_initialized. Added internals for the
1482 :verify-hostname-error, :verify-error, and :verify-flags
1483 parameters of `gnutls-boot' and documented those parameters in the
1484 docstring. Start callback support.
1485 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
1486 unless a fatal error occured. Call gnutls_alert_send_appropriate
1487 on error. Return error code.
1488 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
1489 (emacs_gnutls_read): Likewise.
1490 (Fgnutls_boot): Return handshake error code.
1491 (emacs_gnutls_handle_error): New function.
1492 (wsaerror_to_errno): Likewise.
1493
1494 * w32.h (emacs_gnutls_pull): Add prototype.
1495 (emacs_gnutls_push): Likewise.
1496
1497 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
1498 (emacs_gnutls_push): Likewise.
1499
1500 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
1501
1502 * process.c (wait_reading_process_output): Check if GnuTLS
1503 buffered some data internally if no FDs are set for TLS
1504 connections.
1505
1506 * makefile.w32-in (OBJ2): Add gnutls.$(O).
1507 (LIBS): Link to USER_LIBS.
1508 ($(BLD)/gnutls.$(0)): New target.
1509
1510 2011-04-24 Eli Zaretskii <eliz@gnu.org>
1511
1512 * xdisp.c (handle_single_display_spec): Rename the
1513 display_replaced_before_p argument into display_replaced_p, to
1514 make it consistent with the commentary. Fix typos in the
1515 commentary.
1516
1517 * textprop.c (syms_of_textprop): Remove dead code.
1518 (copy_text_properties): Delete obsolete commentary about an
1519 interface that was deleted long ago. Fix typos in the description
1520 of arguments.
1521
1522 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
1523 to changes in oldXMenu/XMenu.h from 2011-04-16.
1524 <menu_help_message, prev_menu_help_message>: Constify.
1525 (IT_menu_make_room): menu->help_text is now `const char **';
1526 adjust.
1527
1528 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
1529 to changes in oldXMenu/XMenu.h from 2011-04-16.
1530 (struct XMenu): Declare `help_text' `const char **'.
1531
1532 * xfaces.c <Qunspecified>: Make extern again.
1533
1534 * syntax.c: Include sys/types.h before including regex.h, as
1535 required by Posix.
1536
1537 * doc.c (get_doc_string): Improve the format passed to `error'.
1538
1539 * doprnt.c (doprnt): Improve commentary.
1540
1541 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
1542
1543 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
1544 them with etags.
1545
1546 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
1547 changes in globals.h immediately force recompilation.
1548 (TAGS): Depend on $(CURDIR)/m/intel386.h and
1549 $(CURDIR)/s/ms-w32.h.
1550 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
1551
1552 * character.c (Fchar_direction): Function deleted.
1553 (syms_of_character): Don't defsubr it.
1554 <char-direction-table>: Deleted.
1555
1556 2011-04-23 Eli Zaretskii <eliz@gnu.org>
1557
1558 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
1559 * doprnt.c: Include limits.h.
1560 (SIZE_MAX): New macro.
1561 (doprnt): Return a size_t value. 2nd arg is now size_t.
1562 Many local variables are now size_t instead of int or unsigned.
1563 Improve overflow protection. Support `l' modifier for integer
1564 conversions. Support %l conversion. Don't assume an EMACS_INT
1565 argument for integer conversions and for %c.
1566
1567 * lisp.h (doprnt): Restore prototype.
1568
1569 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
1570 $(SRC)/character.h.
1571
1572 * Makefile.in (base_obj): Add back doprnt.o.
1573
1574 * deps.mk (doprnt.o): Add back prerequisites.
1575 (callint.o): Depend on character.h.
1576
1577 * eval.c (internal_lisp_condition_case): Include the handler
1578 representation in the error message.
1579 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1580 when breaking from the loop.
1581
1582 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1583
1584 * callint.c (Fcall_interactively): When displaying error message
1585 about invalid control letter, pass the character's codepoint, not
1586 a pointer to its multibyte form. Improve display of the character
1587 in octal and display also its hex code.
1588
1589 * character.c (char_string): Use %x to display the (unsigned)
1590 codepoint of an invalid character, to avoid displaying a bogus
1591 negative value.
1592
1593 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1594 `error', not SYMBOL_NAME itself.
1595
1596 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1597 character arguments to `error'.
1598
1599 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1600 to `error' in error message about FINAL_CHAR argument. Make sure
1601 FINAL_CHAR is a character, and use %c when it is passed as
1602 argument to `error'.
1603
1604 2011-04-23 Eli Zaretskii <eliz@gnu.org>
1605
1606 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1607
1608 * w32.c: Include <time.h>.
1609 (sys_localtime): New function.
1610
1611 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
1612
1613 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1614
1615 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
1616
1617 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
1618
1619 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1620 zombies (Bug#8467).
1621
1622 2011-04-19 Eli Zaretskii <eliz@gnu.org>
1623
1624 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1625 gl_state.e_property when gl_state.object is Qt.
1626
1627 * insdel.c (make_gap_larger): Remove limitation of buffer size
1628 to <= INT_MAX.
1629
1630 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
1631
1632 * xdisp.c (lookup_glyphless_char_display)
1633 (produce_glyphless_glyph): Handle cons cell entry in
1634 glyphless-char-display.
1635 (Vglyphless_char_display): Document it.
1636
1637 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1638 glyphless-char-display.
1639
1640 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
1641
1642 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
1643
1644 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1645
1646 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
1647 definition for no-X builds.
1648
1649 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
1650
1651 Static checks with GCC 4.6.0 and non-default toolkits.
1652
1653 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1654
1655 * process.c (keyboard_bit_set): Define only if SIGIO.
1656 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
1657 (send_process): Repair possible setjmp clobbering.
1658
1659 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
1660
1661 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1662
1663 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
1664
1665 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
1666 Define only if needed.
1667
1668 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
1669 by pacifying GCC about it. Maybe it's time to retire it?
1670 * xfaces.c (USG, __TIMEVAL__): Likewise.
1671
1672 * dispextern.h (struct redisplay_interface): Rename param
1673 to avoid shadowing.
1674 * termhooks.h (struct terminal): Likewise.
1675 * xterm.c (xembed_send_message): Likewise.
1676
1677 * insdel.c (make_gap_smaller): Define only if
1678 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
1679
1680 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
1681 it.
1682
1683 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
1684 so that we aren't warned about unused symbols.
1685
1686 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
1687
1688 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
1689
1690 * xfns.c (x_real_positions): Mark locals as initialized.
1691
1692 * xmenu.c (xmenu_show): Don't use uninitialized vars.
1693
1694 * xterm.c: Fix problems found by static analysis with other toolkits.
1695 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
1696 (x_dispatch_event): Declare static if USE_GTK, and
1697 define if USE_GTK || USE_X_TOOLKIT.
1698 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
1699 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
1700 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
1701 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
1702
1703 * xmenu.c (menu_help_callback): Pointer type fixes.
1704 Use const pointers when pointing at readonly data. Avoid pointer
1705 signedness clashes.
1706 (FALSE): Remove unused macro.
1707 (update_frame_menubar): Remove unused decl.
1708
1709 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
1710
1711 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
1712 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
1713 (single_menu_item): Rename local to avoid shadowing.
1714
1715 * keyboard.c (make_lispy_event): Remove unused local var.
1716
1717 * frame.c, frame.h (x_get_resource_string): Bring this back, but
1718 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
1719
1720 * bitmaps: Change bitmaps from unsigned char back to the X11
1721 compatible char. Avoid the old compiler warnings about
1722 out-of-range initializers by using, for example, '\xab' rather
1723 than 0xab.
1724
1725 * xgselect.c (xgselect_initialize): Check vs interface
1726 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
1727
1728 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
1729
1730 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
1731 to read-only memory.
1732
1733 * fns.c (vector): Remove; this old hack is no longer needed.
1734
1735 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
1736 Remove unused var.
1737 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
1738
1739 * xrdb.c (x_load_resources): Omit unused local.
1740
1741 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
1742 (x_window): Rename locals to avoid shadowing.
1743 (USG): Use the kludged USG macro, to pacify gcc.
1744
1745 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
1746 (x_term_init): Remove local to avoid shadowing.
1747
1748 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
1749
1750 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
1751 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
1752
1753 2011-04-16 Eli Zaretskii <eliz@gnu.org>
1754
1755 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
1756
1757 Fix regex.c, syntax.c and friends for buffers > 2GB.
1758 * syntax.h (struct gl_state_s): Declare character position members
1759 EMACS_INT.
1760
1761 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
1762
1763 * textprop.c (verify_interval_modification, interval_of):
1764 Declare arguments EMACS_INT.
1765
1766 * intervals.c (adjust_intervals_for_insertion): Declare arguments
1767 EMACS_INT.
1768
1769 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
1770
1771 * indent.c (Fvertical_motion): Local variable it_start is now
1772 EMACS_INT.
1773
1774 * regex.c (re_match, re_match_2, re_match_2_internal)
1775 (bcmp_translate, regcomp, regexec, print_double_string)
1776 (group_in_compile_stack, re_search, re_search_2, regex_compile)
1777 (re_compile_pattern, re_exec): Declare arguments and local
1778 variables `size_t' and `ssize_t' and return values `regoff_t', as
1779 appropriate.
1780 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
1781 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
1782 <compile_stack_type>: `size' and `avail' are now `size_t'.
1783
1784 * regex.h <regoff_t>: Use ssize_t, not int.
1785 (re_search, re_search_2, re_match, re_match_2): Arguments that
1786 specify buffer/string position and length are now ssize_t and
1787 size_t. Return type is regoff_t.
1788
1789 2011-04-16 Ben Key <bkey76@gmail.com>
1790
1791 * nsfont.m: Fixed bugs in ns_get_family and
1792 ns_descriptor_to_entity that were caused by using free to
1793 deallocate memory blocks that were allocated by xmalloc (via
1794 xstrdup). This caused Emacs to crash when compiled with
1795 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
1796 --enable-checking=xmallocoverrun). xfree is now used to
1797 deallocate these memory blocks.
1798
1799 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
1800
1801 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
1802
1803 emacs_write: Accept and return EMACS_INT for sizes.
1804 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
1805 et seq.
1806 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
1807 Accept and return EMACS_INT.
1808 (emacs_gnutls_write): Return the number of bytes written on
1809 partial writes.
1810 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
1811 (emacs_read, emacs_write): Remove check for negative size, as the
1812 Emacs source code has been audited now.
1813 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
1814 (emacs_read, emacs_write): Use it.
1815 * process.c (send_process): Adjust to the new signatures of
1816 emacs_write and emacs_gnutls_write. Do not attempt to store
1817 a byte offset into an 'int'; it might overflow.
1818 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
1819
1820 * sound.c: Don't assume sizes fit in 'int'.
1821 (struct sound_device.period_size, alsa_period_size):
1822 Return EMACS_INT, not int.
1823 (struct sound_device.write, vox_write, alsa_write):
1824 Accept EMACS_INT, not int.
1825 (wav_play, au_play): Use EMACS_INT to store sizes and to
1826 record read return values.
1827
1828 2011-04-15 Ben Key <bkey76@gmail.com>
1829
1830 * keyboard.c (Qundefined): Don't declare static since it is used
1831 in nsfns.m.
1832 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
1833 static since they are used in nsfont.m.
1834
1835 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
1836
1837 * process.c (Qprocessp): Don't declare static.
1838 * lisp.h (Qprocessp): Declare again.
1839
1840 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
1841
1842 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
1843
1844 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
1845
1846 Improve C-level modularity by making more things 'static'.
1847
1848 Don't publish debugger-only interfaces to other modules.
1849 * lisp.h (safe_debug_print, debug_output_compilation_hack):
1850 (verify_bytepos, count_markers): Move decls to the only modules
1851 that need them.
1852 * region-cache.h (pp_cache): Likewise.
1853 * window.h (check_all_windows): Likewise.
1854 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
1855
1856 * sysdep.c (croak): Now static, if
1857 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
1858 * syssignal.h (croak): Declare only if not static.
1859
1860 * alloc.c (refill_memory_reserve): Now static if
1861 !defined REL_ALLOC || defined SYSTEM_MALLOC.
1862 * lisp.h (refill_memory_reserve): Declare only if not static.
1863
1864 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
1865 Define only if USE_LUCID.
1866
1867 * xrdb.c (x_customization_string, x_rm_string): Now static.
1868
1869 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
1870 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
1871
1872 * xdisp.c (draw_row_with_mouse_face): Now static.
1873 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
1874
1875 * window.h (check_all_windows): Mark externally visible.
1876
1877 * window.c (window_deletion_count): Now static.
1878
1879 * undo.c: Make symbols static if they're not exported.
1880 (last_undo_buffer, last_boundary_position, pending_boundary):
1881 Now static.
1882
1883 * textprop.c (interval_insert_behind_hooks): Now static.
1884 (interval_insert_in_front_hooks): Likewise.
1885
1886 * term.c: Make symbols static if they're not exported.
1887 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
1888 (max_frame_lines, tty_set_terminal_modes):
1889 (tty_reset_terminal_modes, tty_turn_off_highlight):
1890 (get_tty_terminal): Now static.
1891 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
1892 * termhooks.h (term_mouse_moveto): Do not declare if
1893 HAVE_WINDOW_SYSTEM.
1894 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
1895 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
1896
1897 * sysdep.c: Make symbols static if they're not exported.
1898 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
1899 Now static.
1900 (sigprocmask_set, full_mask): Remove; unused.
1901 (wait_debugging): Mark as visible.
1902 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
1903 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
1904
1905 * syntax.c (syntax_temp): Define only if !__GNUC__.
1906
1907 * sound.c (current_sound_device, current_sound): Now static.
1908
1909 * search.c (searchbufs, searchbuf_head): Now static.
1910
1911 * scroll.c (scroll_cost): Remove; unused.
1912 * dispextern.h (scroll_cost): Remove decl.
1913
1914 * region-cache.h (pp_cache): Mark as externally visible.
1915
1916 * process.c: Make symbols static if they're not exported.
1917 (process_tick, update_tick, create_process, chan_process):
1918 (Vprocess_alist, proc_buffered_char, datagram_access):
1919 (fd_callback_data, send_process_frame, process_sent_to): Now static.
1920 (deactivate_process): Mark defn as static, as well as decl.
1921 * lisp.h (create_process): Remove decl.
1922 * process.h (chan_process, Vprocess_alist): Remove decls.
1923
1924 * print.c: Make symbols static if they're not exported.
1925 (print_depth, new_backquote_output, being_printed, print_buffer):
1926 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
1927 (print_interval, print_number_index, initial_stderr_stream):
1928 Now static.
1929 * lisp.h (Fprinc): Remove decl.
1930 (debug_output_compilation_hack): Mark as externally visible.
1931
1932 * sysdep.c (croak): Move decl from here to syssignal.h.
1933 * syssignal.h (croak): Put it here, so the API can be checked when
1934 'croak' is called from dissociate_if_controlling_tty.
1935
1936 * minibuf.c: Make symbols static if they're not exported.
1937 (minibuf_save_list, choose_minibuf_frame): Now static.
1938 * lisp.h (choose_minibuf_frame): Remove decl.
1939
1940 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
1941
1942 * lread.c: Make symbols static if they're not exported.
1943 (read_objects, initial_obarray, oblookup_last_bucket_number):
1944 Now static.
1945 (make_symbol): Remove; unused.
1946 * lisp.h (initial_obarray, make_symbol): Remove decls.
1947
1948 * keyboard.c: Make symbols static if they're not exported.
1949 (single_kboard, recent_keys_index, total_keys, recent_keys):
1950 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
1951 (this_single_command_key_start, echoing, last_auto_save):
1952 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
1953 (command_loop, echo_now, keyboard_init_hook, help_char_p):
1954 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
1955 (Vlispy_mouse_stem, double_click_count):
1956 Now static.
1957 (force_auto_save_soon): Define only if SIGDANGER.
1958 (ignore_mouse_drag_p): Now static if
1959 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
1960 (print_help): Remove; unused.
1961 (stop_character, last_timer_event): Mark as externally visible.
1962 * keyboard.h (ignore_mouse_drag_p): Declare only if
1963 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
1964 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
1965 * lisp.h (echoing): Remove decl.
1966 (force_auto_save_soon): Declare only if SIGDANGER.
1967 * xdisp.c (redisplay_window): Simplify code, to make it more
1968 obvious that ignore_mouse_drag_p is not accessed if !defined
1969 USE_GTK && !defined HAVE_NS.
1970
1971 * intervals.c: Make symbols static if they're not exported.
1972 (merge_properties_sticky, merge_interval_right, delete_interval):
1973 Now static.
1974 * intervals.h (merge_interval_right, delete_interval): Remove decls.
1975
1976 * insdel.c: Make symbols static if they're not exported.
1977 However, leave prepare_to_modify_buffer alone. It's never
1978 called from outside this function, but that appears to be a bug.
1979 (combine_after_change_list, combine_after_change_buffer):
1980 (adjust_after_replace, signal_before_change): Now static.
1981 (adjust_after_replace_noundo): Remove; unused.
1982 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
1983 (signal_before_change): Remove decls.
1984
1985 * indent.c (val_compute_motion, val_vmotion): Now static.
1986
1987 * image.c: Make symbols static if they're not exported.
1988 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
1989 if USE_GTK.
1990 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
1991 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
1992
1993 * fringe.c (standard_bitmaps): Now static.
1994 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
1995
1996 * frame.c: Make symbols static if they're not exported.
1997 (x_report_frame_params, make_terminal_frame): Now static.
1998 (get_frame_param): Now static, unless HAVE_NS.
1999 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2000 (x_get_resource_string): Remove; not used.
2001 * frame.h (make_terminal_frame, x_report_frame_params):
2002 (x_get_resource_string); Remove decls.
2003 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2004 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2005
2006 * font.c, fontset.c: Make symbols static if they're not exported.
2007 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2008 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2009 * font.c (font_close_object): Now static.
2010 * font.h (font_close_object): Remove.
2011 * fontset.c (FONTSET_OBJLIST): Remove.
2012 (free_realized_fontset) #if-0 the body, which does nothing.
2013 (face_suitable_for_char_p): #if-0, as it's never called.
2014 * fontset.h (face_suitable_for_char_p): Remove decl.
2015 * xfaces.c (face_at_string_position):
2016 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
2017 since 0 is always ASCII.
2018
2019 * fns.c (weak_hash_tables): Now static.
2020
2021 * fileio.c: Make symbols static if they're not exported.
2022 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2023 (Vwrite_region_annotation_buffers): Now static.
2024
2025 * eval.c: Make symbols static if they're not exported.
2026 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2027 * lisp.h (backtrace_list): Remove decl.
2028
2029 * emacs.c: Make symbols static if they're not exported.
2030 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2031 (fatal_error_code, fatal_error_signal_hook, standard_args):
2032 Now static.
2033 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2034 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2035 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2036 * lisp.h (fatal_error_signal_hook): Remove decl.
2037 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2038
2039 * editfns.c: Move a (normally-unused) function to its only use.
2040 * editfns.c, lisp.h (get_operating_system_release): Remove.
2041 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2042 worth the hassle of breaking this out.
2043
2044 * xterm.c: Make symbols static if they're not exported.
2045 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2046 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2047 (x_destroy_window, x_delete_display):
2048 Now static.
2049 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2050 (x_mouse_leave): Remove; unused.
2051 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2052 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2053 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2054 Remove decls.
2055 (x_mouse_leave): Declare only if WINDOWSNT.
2056 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2057 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2058 USE_X_TOOLKIT.
2059
2060 * ftxfont.c: Make symbols static if they're not exported.
2061 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2062 HAVE_FREETYPE.
2063 * font.h (ftxfont_driver): Likewise.
2064
2065 * xfns.c: Make symbols static if they're not exported.
2066 (x_last_font_name, x_display_info_for_name):
2067 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2068 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2069 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2070 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2071 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2072 (last_show_tip_args): Now static.
2073 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2074 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2075 (x_screen_planes): Remove; unused.
2076 * dispextern.h (x_screen_planes): Remove decl.
2077
2078 * dispnew.c: Make symbols static if they're not exported.
2079 * dispextern.h (redraw_garbaged_frames, scrolling):
2080 (increment_row_positions): Remove.
2081 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2082 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2083 Now static.
2084 (redraw_garbaged_frames): Remove; unused.
2085
2086 * xfaces.c: Make symbols static if they're not exported.
2087 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2088 Remove decls.
2089 * xterm.h (defined_color): Remove decls.
2090 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2091 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2092 (menu_face_changed_default, defined_color, free_realized_face):
2093 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2094 (ascii_face_of_lisp_face): Remove; unused.
2095
2096 * xdisp.c: Make symbols static if they're not exported.
2097 * dispextern.h (scratch_glyph_row, window_box_edges):
2098 (glyph_to_pixel_coords, set_cursor_from_row):
2099 (get_next_display_element, set_iterator_to_next):
2100 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2101 (show_mouse_face): Remove decls
2102 * frame.h (message_buf_print): Likewise.
2103 * lisp.h (pop_message, set_message, check_point_in_composition):
2104 Likewise.
2105 * xterm.h (set_vertical_scroll_bar): Likewise.
2106 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2107 (message_buf_print, scratch_glyph_row, displayed_buffer):
2108 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2109 (get_next_display_element, show_mouse_face, window_box_edges):
2110 (frame_to_window_pixel_xy, check_point_in_composition):
2111 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2112 (glyph_to_pixel_coords): Remove; unused.
2113
2114 * dired.c (file_name_completion): Now static.
2115
2116 * dbusbind.c (xd_in_read_queued_messages): Now static.
2117
2118 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2119 * data.c (circular_list_error): Remove.
2120
2121 * commands.h (last_point_position, last_point_position_buffer):
2122 (last_point_position_window): Remove decls.
2123 * keyboard.c: Make these variables static.
2124
2125 * coding.h (coding, code_convert_region, encode_coding_gap):
2126 Remove decls.
2127 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2128 (iso_code_class, detect_coding, code_convert_region): Now static.
2129 (encode_coding_gap): Remove; unused.
2130
2131 * chartab.c (chartab_chars, chartab_bits): Now static.
2132
2133 * charset.h (charset_iso_8859_1): Remove decl.
2134 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2135 Now static.
2136
2137 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2138 * ccl.c (Vccl_program_table): Now static.
2139 (check_ccl_update): Remove; unused.
2140
2141 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2142 * category.h: ... from here.
2143 * category.c (check_category_table, set_category_set): Now static.
2144
2145 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2146 * lisp.h: Remove these decls.
2147
2148 * buffer.c (buffer_count): Remove unused var.
2149
2150 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2151 so that it's not optimized away.
2152 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2153 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2154 exported only to the debugger.
2155
2156 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
2157 * atimer.h (run_all_atimers): Remove; not exported.
2158
2159 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2160 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2161 was inaccessible from Lisp.
2162 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2163 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2164
2165 alloc.c: Import and export fewer symbols, and remove unused items.
2166 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2167 is defined.
2168 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2169 it's not optimized away by whole-program optimization.
2170 (message_enable_multibyte, free_misc): Remove.
2171 (catchlist, handlerlist, mark_backtrace):
2172 Declare only if BYTE_MARK_STACK.
2173 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2174 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2175 (message_enable_multibyte): Remove decl.
2176 (free_misc, interval_free_list, float_block, float_block_index):
2177 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2178 (cons_free_list, last_marked_index):
2179 Now static.
2180 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2181 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2182 (mark_backtrace): Define only if BYTE_MARK_STACK.
2183 * xdisp.c (message_enable_multibyte): Now static.
2184
2185 Declare Lisp_Object Q* variables to be 'static' if not exported.
2186 This makes it easier for human readers (and static analyzers)
2187 to see whether these variables are used from other modules.
2188 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2189 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2190 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2191 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2192 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2193 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2194 * xmenu.c, xselect.c:
2195 Declare Q* vars static if they are not used in other modules.
2196 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2197 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2198 Remove decls of unexported vars.
2199 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2200
2201 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2202
2203 Make Emacs functions such as Fatom 'static' by default.
2204 This makes it easier for human readers (and static analyzers)
2205 to see whether these functions can be called from other modules.
2206 DEFUN now defines a static function. To make the function external
2207 so that it can be used in other C modules, use the new macro DEFUE.
2208 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2209 (Finit_image_library):
2210 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2211 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2212 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2213 Remove decls, since these functions are now static.
2214 (Funintern, Fget_internal_run_time): New decls, since these functions
2215 were already external.
2216
2217 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2218 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2219 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2220 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2221 * keyboard.c, keymap.c, lread.c:
2222 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2223 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2224 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2225 Mark functions with DEFUE instead of DEFUN,
2226 if they are used in other modules.
2227 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2228 decls for now-static functions.
2229 * buffer.h (Fdelete_overlay): Remove decl.
2230 * callproc.c (Fgetenv_internal): Mark as internal.
2231 * composite.c (Fremove_list_of_text_properties): Remove decl.
2232 (Fcomposition_get_gstring): New forward static decl.
2233 * composite.h (Fcomposite_get_gstring): Remove decl.
2234 * dired.c (Ffile_attributes): New forward static decl.
2235 * doc.c (Fdocumntation_property): New forward static decl.
2236 * eval.c (Ffetch_bytecode): New forward static decl.
2237 (Funintern): Remove extern decl; now in .h file where it belongs.
2238 * fileio.c (Fmake_symbolic_link): New forward static decl.
2239 * image.c (Finit_image_library): New forward static decl.
2240 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2241 * intervals.h (Fprevious_property_change):
2242 (Fremove_list_of_text_properties): Remove decls.
2243 * keyboard.c (Fthis_command_keys): Remove decl.
2244 (Fcommand_execute): New forward static decl.
2245 * keymap.c (Flookup_key): New forward static decl.
2246 (Fcopy_keymap): Now static.
2247 * keymap.h (Flookup_key): Remove decl.
2248 * process.c (Fget_process): New forward static decl.
2249 (Fprocess_datagram_address): Mark as internal.
2250 * syntax.c (Fsyntax_table_p): New forward static decl.
2251 (skip_chars): Remove duplicate decl.
2252 * textprop.c (Fprevious_property_change): New forward static decl.
2253 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2254 Now internal.
2255 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2256 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2257
2258 * editfns.c (Fformat): Remove unreachable code.
2259
2260 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2261
2262 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2263 change. (Bug#8496)
2264
2265 2011-04-13 Eli Zaretskii <eliz@gnu.org>
2266
2267 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2268 when at ZV. (Bug#8487)
2269
2270 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2271
2272 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2273 (Bug#8437)
2274 * keyboard.c (parse_tool_bar_item): Likewise.
2275 * sound.c (sound_cleanup, alsa_close): Likewise.
2276 * termcap.c (tgetent): Likewise.
2277 * xfns.c (x_default_font_parameter): Likewise.
2278 * xsettings.c (read_and_apply_settings): Likewise.
2279
2280 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2281 (overrun_check_free): Protoize.
2282
2283 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2284
2285 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2286 since callers should never pass a negative size.
2287 Change the signature to match that of plain 'read' and 'write'; see
2288 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2289 * lisp.h: Update prototypes of emacs_write and emacs_read.
2290
2291 2011-04-11 Eli Zaretskii <eliz@gnu.org>
2292
2293 * xdisp.c (redisplay_window): Don't try to determine the character
2294 position of the scroll margin if the window start point w->startp
2295 is outside the buffer's accessible region. (Bug#8468)
2296
2297 2011-04-10 Eli Zaretskii <eliz@gnu.org>
2298
2299 Fix write-region and its subroutines for buffers > 2GB.
2300 * fileio.c (a_write, e_write): Modify declaration of arguments and
2301 local variables to support buffers larger than 2GB.
2302 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2303
2304 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2305 argument, local variables, and return value.
2306
2307 * lisp.h: Update prototypes of emacs_write and emacs_read.
2308
2309 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2310
2311 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
2312
2313 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2314
2315 Fix more problems found by GCC 4.6.0's static checks.
2316
2317 * xdisp.c (vmessage): Use a better test for character truncation.
2318
2319 * charset.c (load_charset_map): <, not <=, for optimization,
2320 and to avoid potential problems with integer overflow.
2321 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
2322 * casetab.c (set_identity, shuffle): Likewise.
2323 * editfns.c (Fformat): Likewise.
2324 * syntax.c (skip_chars): Likewise.
2325
2326 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2327 This also lets GCC 4.6.0 generate slightly better loop code.
2328
2329 * callint.c (Fcall_interactively): <, not <=, for optimization.
2330 (Fcall_interactively): Count the number of arguments produced,
2331 not the number of arguments given. This is simpler and lets GCC
2332 4.6.0 generate slightly better code.
2333
2334 * ftfont.c: Distingish more carefully between FcChar8 and char.
2335 The previous code passed unsigned char * to a functions like
2336 strlen and xstrcasecmp that expect char *, which does not
2337 conform to the C standard.
2338 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
2339 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
2340 char * when the C standard requires it.
2341
2342 * keyboard.c (read_char): Remove unused var.
2343
2344 * eval.c: Port to Windows vsnprintf (Bug#8435).
2345 Include <limits.h>.
2346 (SIZE_MAX): Define if the headers do not.
2347 (verror): Do not give up if vsnprintf returns a negative count.
2348 Instead, grow the buffer. This ports to Windows vsnprintf, which
2349 does not conform to C99. Problem reported by Eli Zaretskii.
2350 Also, simplify the allocation scheme, by avoiding the need for
2351 calling realloc, and removing the ALLOCATED variable.
2352
2353 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
2354
2355 Remove invocations of doprnt, as Emacs now uses vsnprintf.
2356 But keep the doprint source code for now, as we might revamp it
2357 and use it again (Bug#8435).
2358 * lisp.h (doprnt): Remove.
2359 * Makefile.in (base_obj): Remove doprnt.o.
2360 * deps.mk (doprnt.o): Remove.
2361
2362 error: Print 32- and 64-bit integers portably (Bug#8435).
2363 Without this change, on typical 64-bit hosts error ("...%d...", N)
2364 was used to print both 32- and 64-bit integers N, which relied on
2365 undefined behavior.
2366 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
2367 New macro.
2368 * lisp.h (error, verror): Mark as printf-like functions.
2369 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
2370 Report overflow in size calculations when allocating printf buffer.
2371 Do not truncate output string at its first null byte.
2372 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
2373 Truncate the output at a character boundary, since vsnprintf does not
2374 do that.
2375 * charset.c (check_iso_charset_parameter): Convert internal
2376 character to string before calling 'error', since %c now has the
2377 printf meaning.
2378 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
2379 overflow when computing char to be passed to 'error'. Do not
2380 pass Lisp_Object to 'error'; pass the integer instead.
2381 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
2382 formatted with plain %d.
2383
2384 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
2385
2386 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
2387
2388 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
2389
2390 * xterm.c (x_catch_errors): Remove duplicate declaration.
2391
2392 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
2393
2394 * xdisp.c, lisp.h (message_nolog): Remove; unused.
2395
2396 2011-04-10 Jim Meyering <meyering@redhat.com>
2397
2398 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
2399 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
2400 return ssize_t not "int", and use size_t as the buffer length.
2401 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
2402 * gnutls.h: Update declarations.
2403 * process.c (read_process_output): Use ssize_t, to match.
2404 (send_process): Likewise.
2405
2406 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
2407
2408 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
2409
2410 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
2411
2412 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
2413 Use unsigned char, to match FcChar8 type definition.
2414
2415 * xterm.c (handle_one_xevent):
2416 * xmenu.c (create_and_show_popup_menu):
2417 * xselect.c (x_decline_selection_request)
2418 (x_reply_selection_request): Avoid type-punned deref of X events.
2419
2420 2011-04-09 Eli Zaretskii <eliz@gnu.org>
2421
2422 Fix some uses of `int' instead of EMACS_INT.
2423 * search.c (string_match_1, fast_string_match)
2424 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
2425 (scan_buffer, find_next_newline_no_quit)
2426 (find_before_next_newline, search_command, Freplace_match)
2427 (Fmatch_data): Make some `int' variables be EMACS_INT.
2428
2429 * xdisp.c (display_count_lines): 3rd argument and return value now
2430 EMACS_INT. All callers changed.
2431 (pint2hrstr): Last argument is now EMACS_INT.
2432
2433 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2434 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2435 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2436 (decode_coding_utf_16, decode_coding_emacs_mule)
2437 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2438 (decode_coding_ccl, decode_coding_charset)
2439 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
2440 (decode_coding_iso_2022, decode_coding_emacs_mule)
2441 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
2442 <char_offset, last_offset>: Declare EMACS_INT.
2443 (encode_coding_utf_8, encode_coding_utf_16)
2444 (encode_coding_emacs_mule, encode_invocation_designation)
2445 (encode_designation_at_bol, encode_coding_iso_2022)
2446 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
2447 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
2448 Declare EMACS_INT.
2449 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
2450 (encode_invocation_designation): Last argument P_NCHARS is now
2451 EMACS_INT.
2452 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
2453 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
2454
2455 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
2456 All users changed.
2457
2458 * ccl.c (Fccl_execute_on_string): Declare some variables
2459 EMACS_INT.
2460
2461 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
2462
2463 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
2464
2465 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
2466
2467 * process.c (Fformat_network_address): Doc fix.
2468
2469 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
2470
2471 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
2472
2473 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
2474
2475 * keyboard.c (read_char): Call Lisp function help-form-show,
2476 instead of using internal_with_output_to_temp_buffer.
2477 (Qhelp_form_show): New var.
2478 (syms_of_keyboard): Use DEFSYM macro.
2479
2480 * print.c (internal_with_output_to_temp_buffer): Function deleted.
2481
2482 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
2483
2484 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
2485
2486 * process.c (Flist_processes): Remove to Lisp.
2487 (list_processes_1): Delete.
2488
2489 2011-04-06 Eli Zaretskii <eliz@gnu.org>
2490
2491 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
2492
2493 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
2494
2495 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
2496
2497 Fix more problems found by GCC 4.6.0's static checks.
2498
2499 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
2500
2501 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
2502
2503 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
2504
2505 * xdisp.c (vmessage): Mark as a printf-like function.
2506
2507 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
2508
2509 * sound.c (sound_warning): Don't crash if arg contains a printf format.
2510
2511 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
2512 printf-like functions.
2513 (tiff_load): Add casts to remove these marks before passing them
2514 to system-supplied API.
2515
2516 * eval.c (Fsignal): Remove excess argument to 'fatal'.
2517
2518 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
2519 This avoids several warnings with gcc -Wstrict-overflow.
2520 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
2521 directly, rather than having caller test rule sign. This avoids
2522 some unnecessary tests.
2523 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
2524 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
2525 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
2526
2527 * xfont.c (xfont_text_extents): Remove var that was set but not used.
2528 (xfont_open): Avoid unnecessary tests.
2529
2530 * composite.c (composition_gstring_put_cache): Use unsigned integer.
2531
2532 * composite.h, composite.c (composition_gstring_put_cache):
2533 Use EMACS_INT, not int, for length.
2534
2535 * composite.h (COMPOSITION_DECODE_REFS): New macro,
2536 breaking out part of COMPOSITION_DECODE_RULE.
2537 (COMPOSITION_DECODE_RULE): Use it.
2538 * composite.c (get_composition_id): Remove unused local vars,
2539 by using the new macro.
2540
2541 * textprop.c (set_text_properties_1): Change while to do-while,
2542 since the condition is always true at first.
2543
2544 * intervals.c (graft_intervals_into_buffer): Mark var as used.
2545 (interval_deletion_adjustment): Return unsigned value.
2546 All uses changed.
2547
2548 * process.c (list_processes_1, create_pty, read_process_output):
2549 (exec_sentinel): Remove vars that were set but not used.
2550 (create_pty): Remove unnecessary "volatile"s.
2551 (Fnetwork_interface_info): Avoid possibility of int overflow.
2552 (read_process_output): Do adaptive read buffering even if carryover.
2553 (read_process_output): Simplify nbytes computation if buffered.
2554
2555 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
2556
2557 * syntax.c (scan_words): Remove var that was set but not used.
2558 (update_syntax_table): Use unsigned instead of int.
2559
2560 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
2561 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
2562 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
2563
2564 * print.c (print_error_message): Avoid int overflow.
2565
2566 * font.c (font_list_entities): Redo for clarity,
2567 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
2568
2569 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
2570 (font_score): Avoid potential overflow in diff calculation.
2571
2572 * fns.c (substring_both): Remove var that is set but not used.
2573 (sxhash): Redo loop for clarity and to avoid wraparound warning.
2574
2575 * eval.c (funcall_lambda): Rename local to avoid shadowing.
2576
2577 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2578 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2579 can always succeed if overflow has undefined behavior.
2580
2581 * search.c (boyer_moore, wordify): Remove vars set but not used.
2582 (wordify): Omit three unnecessary tests.
2583
2584 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2585 All callers changed. This avoids the need for an unused var.
2586
2587 * casefiddle.c (casify_region): Remove var that is set but not used.
2588
2589 * dired.c (file_name_completion): Remove var that is set but not used.
2590
2591 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2592
2593 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
2594 (Finsert_file_contents): Remove unnecessary code checking fd.
2595
2596 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2597 Check for integer overflow on size calculations.
2598
2599 * buffer.c (Fprevious_overlay_change): Remove var that is set
2600 but not used.
2601
2602 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2603 Remove vars that are set but not used.
2604 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
2605 (timer_check_2): Mark vars as initialized.
2606
2607 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2608
2609 * image.c (lookup_image): Remove var that is set but not used.
2610 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
2611
2612 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2613 that are set but not used.
2614
2615 * xfns.c (make_invisible_cursor): Don't return garbage
2616 if XCreateBitmapFromData fails (Bug#8410).
2617
2618 * xselect.c (x_get_local_selection, x_handle_property_notify):
2619 Remove vars that are set but not used.
2620
2621 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
2622 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
2623
2624 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2625 Remove var that is set but not used.
2626 (scroll_bar_windows_size): Now size_t, not int.
2627 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2628 Check for overflow.
2629
2630 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2631 (map_tty_color) [!defined MSDOS]: Likewise.
2632
2633 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2634
2635 * coding.c: Remove vars that are set but not used.
2636 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2637 All callers changed.
2638 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2639 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
2640 (decode_coding_charset): Remove vars that are set but not used.
2641
2642 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
2643 that is set but not used.
2644
2645 * print.c (print_object): Remove var that is set but not used.
2646
2647 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
2648 The gnulib version avoids calling malloc in the usual case,
2649 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2650 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
2651 * filelock.c (current_lock_owner): Likewise.
2652 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2653 * sysdep.c: Include allocator.h, careadlinkat.h.
2654 (emacs_no_realloc_allocator): New static constant.
2655 (emacs_readlink): New function.
2656 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
2657 ../lib/careadlinkat.h.
2658
2659 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
2660
2661 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2662 first non-nil return value).
2663
2664 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
2665
2666 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
2667 if not defined (Bug#8403).
2668
2669 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
2670
2671 * xdisp.c (display_count_lines): Remove parameter `start',
2672 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2673 (get_char_face_and_encoding): Remove parameter `multibyte_p',
2674 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2675 (fill_stretch_glyph_string): Remove parameters `row' and `area',
2676 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
2677 and thereabouts. All callers changed.
2678 (get_per_char_metric): Remove parameter `f', unused since
2679 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2680
2681 2011-04-02 Jim Meyering <meyering@redhat.com>
2682
2683 do not dereference NULL upon failed strdup
2684 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
2685 (ns_get_family): Likewise.
2686
2687 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
2688
2689 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
2690
2691 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
2692
2693 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
2694 later (Bug#8403).
2695
2696 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
2697
2698 Add lexical binding.
2699
2700 * window.c (Ftemp_output_buffer_show): New fun.
2701 (Fsave_window_excursion):
2702 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
2703
2704 * lread.c (lisp_file_lexically_bound_p): New function.
2705 (Fload): Bind Qlexical_binding.
2706 (readevalloop): Remove `evalfun' arg.
2707 Bind Qinternal_interpreter_environment.
2708 (Feval_buffer): Bind Qlexical_binding.
2709 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
2710 Mark as dynamic.
2711 (syms_of_lread): Declare `lexical-binding'.
2712
2713 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
2714
2715 * keyboard.c (eval_dyn): New fun.
2716 (menu_item_eval_property): Use it.
2717
2718 * image.c (parse_image_spec): Use Ffunctionp.
2719
2720 * fns.c (concat, mapcar1): Accept byte-code-functions.
2721
2722 * eval.c (Fsetq): Handle lexical vars.
2723 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
2724 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
2725 (FletX, Flet): Obey lexical binding.
2726 (Fcommandp): Handle closures.
2727 (Feval): New `lexical' arg.
2728 (eval_sub): New function extracted from Feval. Use it almost
2729 everywhere where Feval was used. Look up vars in lexical env.
2730 Handle closures.
2731 (Ffunctionp): Move from subr.el.
2732 (Ffuncall): Handle closures.
2733 (apply_lambda): Remove `eval_flags'.
2734 (funcall_lambda): Handle closures and new byte-code-functions.
2735 (Fspecial_variable_p): New function.
2736 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
2737 but without exporting it to Lisp.
2738
2739 * doc.c (Fdocumentation, store_function_docstring):
2740 * data.c (Finteractive_form): Handle closures.
2741
2742 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
2743 interactive spec.
2744
2745 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
2746 New byte-codes.
2747 (exec_byte_code): New function extracted from Fbyte_code to handle new
2748 calling convention for byte-code-functions. Add new byte-codes.
2749
2750 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
2751
2752 * alloc.c (Fmake_symbol): Init new `declared_special' field.
2753
2754 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
2755
2756 * xdisp.c (redisplay_internal): Fix prototype.
2757
2758 2011-03-31 Eli Zaretskii <eliz@gnu.org>
2759
2760 * xdisp.c (SCROLL_LIMIT): New macro.
2761 (try_scrolling): Use it when setting scroll_limit.
2762 Limit scrolling to 100 screen lines.
2763 (redisplay_window): Even when falling back on "recentering",
2764 position point in the window according to scroll-conservatively,
2765 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
2766
2767 (try_scrolling): When point is above the window, allow searching
2768 as far as scroll_max, or one screenful, to compute vertical
2769 distance from PT to the scroll margin position. This prevents
2770 try_scrolling from unnecessarily failing when
2771 scroll-conservatively is set to a value slightly larger than the
2772 window height. Clean up the case of PT below the margin at bottom
2773 of window: scroll_max can no longer be INT_MAX. When aggressive
2774 scrolling is in use, don't let point enter the opposite scroll
2775 margin as result of the scroll.
2776 (syms_of_xdisp) <scroll-conservatively>: Document the
2777 threshold of 100 lines for never-recentering scrolling.
2778
2779 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
2780
2781 * dispextern.h (move_it_by_lines):
2782 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
2783 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
2784 (message_log_check_duplicate): Remove parameters `prev_bol' and
2785 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2786 (redisplay_internal): Remove parameter `preserve_echo_area',
2787 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
2788
2789 * indent.c (Fvertical_motion):
2790 * window.c (window_scroll_pixel_based, Frecenter):
2791 Don't pass `need_y_p' to `move_it_by_lines'.
2792
2793 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
2794
2795 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
2796 steal a few bits to be more compact.
2797 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2798 Remove unneeded casts.
2799
2800 * bytecode.c (Fbyte_code): CAR and CDR can GC.
2801
2802 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
2803
2804 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
2805 binding" message (bug#7967).
2806
2807 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
2808
2809 Fix more problems found by GCC 4.6.0's static checks.
2810
2811 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
2812 Remove unused local var.
2813
2814 * editfns.c (Fmessage_box): Remove unused local var.
2815
2816 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
2817 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2818 Omit unused local vars.
2819 * window.c (shrink_windows): Omit unused local var.
2820 * menu.c (digest_single_submenu): Omit unused local var.
2821 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
2822 Omit unused local var.
2823
2824 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
2825 Don't assume string length fits in int.
2826 (keyremap_step, read_key_sequence): Use size_t for sizes.
2827 (read_key_sequence): Don't check last_real_key_start redundantly.
2828
2829 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
2830 instead of alloca (Bug#8344).
2831
2832 * eval.c (Fbacktrace): Don't assume nargs fits in int.
2833 (Fbacktrace_frame): Don't assume nframes fits in int.
2834
2835 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
2836
2837 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
2838 concerns.
2839
2840 * term.c (produce_glyphless_glyph): Remove unnecessary test.
2841
2842 * cm.c (calccost): Turn while-do into do-while, for clarity.
2843
2844 * keyboard.c (syms_of_keyboard): Use the same style as later
2845 in this function when indexing through an array. This also
2846 works around GCC bug 48267.
2847
2848 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
2849
2850 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
2851
2852 * chartab.c (sub_char_table_ref_and_range): Redo for slight
2853 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
2854
2855 * keyboard.c, keyboard.h (num_input_events): Now size_t.
2856 This avoids undefined behavior on integer overflow, and is a bit
2857 more convenient anyway since it is compared to a size_t variable.
2858
2859 Variadic C functions now count arguments with size_t, not int.
2860 This avoids an unnecessary limitation on 64-bit machines, which
2861 caused (substring ...) to crash on large vectors (Bug#8344).
2862 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
2863 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
2864 All variadic functions and their callers changed accordingly.
2865 (struct gcpro.nvars): Now size_t, not int. All uses changed.
2866 * data.c (arith_driver, float_arith_driver): Likewise.
2867 * editfns.c (general_insert_function): Likewise.
2868 * eval.c (struct backtrace.nargs, interactive_p)
2869 (internal_condition_case_n, run_hook_with_args, apply_lambda)
2870 (funcall_lambda, mark_backtrace): Likewise.
2871 * fns.c (concat): Likewise.
2872 * frame.c (x_set_frame_parameters): Likewise.
2873 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
2874 0 if not found, not -1. All callers changed.
2875
2876 * alloc.c (garbage_collect): Don't assume stack size fits in int.
2877 (stack_copy_size): Now size_t, not int.
2878 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
2879
2880 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
2881
2882 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
2883 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2884 All callers changed.
2885
2886 * lisp.h (multibyte_char_to_unibyte):
2887 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
2888 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
2889 * character.h (CHAR_TO_BYTE8):
2890 * cmds.c (internal_self_insert):
2891 * editfns.c (general_insert_function):
2892 * keymap.c (push_key_description):
2893 * search.c (Freplace_match):
2894 * xdisp.c (message_dolog, set_message_1): All callers changed.
2895
2896 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2897
2898 * keyboard.c (safe_run_hook_funcall): New function.
2899 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
2900 don't set the hook to nil, but remove the offending function instead.
2901 (Qcommand_hook_internal): Remove, unused.
2902 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
2903 Vcommand_hook_internal.
2904
2905 * eval.c (enum run_hooks_condition): Remove.
2906 (funcall_nil, funcall_not): New functions.
2907 (run_hook_with_args): Call each function through a `funcall' argument.
2908 Remove `cond' argument, now redundant.
2909 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
2910 (Frun_hook_with_args_until_failure): Adjust accordingly.
2911 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
2912
2913 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
2914
2915 * dispextern.h (string_buffer_position): Remove declaration.
2916
2917 * print.c (strout): Remove parameter `multibyte', unused since
2918 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
2919
2920 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
2921 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
2922 All callers changed.
2923
2924 * w32.c (_wsa_errlist): Use braces for struct initializers.
2925
2926 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
2927 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
2928 All callers changed.
2929 (string_buffer_position): Likewise. Also, make static (it's never
2930 used outside xdisp.c).
2931 (cursor_row_p): Remove parameter `w', unused since
2932 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
2933 (decode_mode_spec): Remove parameter `precision', introduced during
2934 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
2935 All callers changed.
2936
2937 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2938
2939 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
2940
2941 2011-03-27 Anders Lindgren <andlind@gmail.com>
2942
2943 * nsterm.m (ns_menu_bar_is_hidden): New variable.
2944 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
2945 (ns_update_auto_hide_menu_bar): New functions.
2946 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
2947 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
2948 ns_constrain_all_frames.
2949 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
2950 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
2951
2952 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
2953
2954 * nsmenu.m (runDialogAt): Remove argument to timer_check.
2955
2956 2011-03-27 Glenn Morris <rgm@gnu.org>
2957
2958 * syssignal.h: Replace RETSIGTYPE with void.
2959 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
2960 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
2961 Replace SIGTYPE with void everywhere.
2962 * s/usg5-4-common.h (SIGTYPE): Remove definition.
2963 * s/template.h (SIGTYPE): Remove commented out definition.
2964
2965 2011-03-26 Eli Zaretskii <eliz@gnu.org>
2966
2967 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
2968 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
2969
2970 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
2971
2972 * w32.c (read_unc_volume): Use parameter `henum', instead of
2973 global variable `wget_enum_handle'.
2974
2975 * keymap.c (describe_vector): Remove parameters `indices' and
2976 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
2977 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
2978
2979 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
2980
2981 * keyboard.c (timer_check): Remove parameter `do_it_now',
2982 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
2983 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
2984 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
2985
2986 * keyboard.c (read_char):
2987 * w32menu.c (w32_menu_display_help):
2988 * xmenu.c (show_help_event, menu_help_callback):
2989 Adjust calls to `show_help_echo'.
2990
2991 * gtkutil.c (xg_maybe_add_timer):
2992 * keyboard.c (readable_events):
2993 * process.c (wait_reading_process_output):
2994 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
2995
2996 * insdel.c (adjust_markers_gap_motion):
2997 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
2998 (gap_left, gap_right): Don't call it.
2999
3000 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
3001
3002 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3003 incurred during fontification.
3004
3005 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3006
3007 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3008 (DEFVAR_PER_BUFFER): Don't pass it.
3009
3010 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3011 (scrolling_window): Don't pass it.
3012
3013 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3014
3015 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3016
3017 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3018 and `suffix'.
3019 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3020 of variables specific to SELinux and computation of `encoded_absname'.
3021
3022 * image.c (XPutPixel): Remove unused variable `height'.
3023
3024 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3025
3026 * unexw32.c (get_section_info): Remove unused variable `section'.
3027
3028 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3029 (system_process_attributes): Remove unused variable `sess'.
3030 (sys_read): Remove unused variable `err'.
3031
3032 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3033 (w32_wnd_proc): Remove unused variable `isdead'.
3034 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3035 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3036 (x_create_tip_frame): Remove unused variable `tem'.
3037
3038 * w32inevt.c (w32_console_read_socket):
3039 Remove unused variable `no_events'.
3040
3041 * w32term.c (x_draw_composite_glyph_string_foreground):
3042 Remove unused variable `width'.
3043
3044 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
3045
3046 * w32term.c (x_set_glyph_string_clipping):
3047 Don't pass uninitialized region to CombineRgn.
3048
3049 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
3050
3051 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3052 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3053 (Fx_close_connection): Remove unused variable `i'.
3054
3055 * w32font.c (w32font_draw): Return number of glyphs.
3056 (w32font_open_internal): Remove unused variable `i'.
3057 (w32font_driver): Add missing initializer.
3058
3059 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3060 (fill_in_menu): Remove unused variable `items_added'.
3061
3062 * w32term.c (last_mouse_press_frame): Remove static global variable.
3063 (w32_clip_to_row): Remove unused variable `f'.
3064 (x_delete_terminal): Remove unused variable `i'.
3065
3066 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3067 (NOTHING): Remove unused static global variable.
3068 (uniscribe_check_otf): Remove unused variable `table'.
3069 (uniscribe_font_driver): Add missing initializers.
3070
3071 2011-03-23 Julien Danjou <julien@danjou.info>
3072
3073 * term.c (Fsuspend_tty, Fresume_tty):
3074 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3075 * window.c (temp_output_buffer_show):
3076 * insdel.c (signal_before_change):
3077 * frame.c (Fhandle_switch_frame):
3078 * fileio.c (Fdo_auto_save):
3079 * emacs.c (Fkill_emacs):
3080 * editfns.c (save_excursion_restore):
3081 * cmds.c (internal_self_insert):
3082 * callint.c (Fcall_interactively):
3083 * buffer.c (Fkill_all_local_variables):
3084 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3085 Use Frun_hooks.
3086 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
3087 unconditionnaly since it does the check itself.
3088
3089 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
3090
3091 Fix more problems found by GCC 4.5.2's static checks.
3092
3093 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3094 the first time through the loop, since we know p0 < p1 then.
3095 This also avoids a gcc -Wstrict-overflow warning.
3096
3097 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3098 leading to a memory leak, possible in functions like
3099 load_charset_map_from_file that can allocate an unbounded number
3100 of objects (Bug#8318).
3101
3102 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3103 that could (at least in theory) be that large.
3104
3105 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3106 This is less likely to overflow, and avoids undefined behavior if
3107 overflow does occur. All callers changed. Use strtoul to scan
3108 for the unsigned long integer.
3109 (pint2hrstr): Simplify and tune code slightly.
3110 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
3111
3112 * scroll.c (do_scrolling): Work around GCC bug 48228.
3113 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3114
3115 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3116 This also avoids a warning with gcc -Wstrict-overflow.
3117 (validate_x_resource_name): Simplify count usage.
3118 This also avoids a warning with gcc -Wstrict-overflow.
3119
3120 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3121 fail (Bug#8306).
3122
3123 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
3124
3125 * process.c (Fmake_network_process): Use socklen_t, not int,
3126 where POSIX says socklen_t is required in portable programs.
3127 This fixes a porting bug on hosts like 64-bit HP-UX, where
3128 socklen_t is wider than int (Bug#8277).
3129 (Fmake_network_process, server_accept_connection):
3130 (wait_reading_process_output, read_process_output):
3131 Likewise.
3132
3133 * process.c: Rename or move locals to avoid shadowing.
3134 (list_processes_1, Fmake_network_process):
3135 (read_process_output_error_handler, exec_sentinel_error_handler):
3136 Rename or move locals.
3137 (Fmake_network_process): Define label "retry_connect" only if needed.
3138 (Fnetwork_interface_info): Fix pointer signedness.
3139 (process_send_signal): Add cast to avoid pointer signedness problem.
3140 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
3141 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
3142
3143 Make tparam.h and terminfo.c consistent.
3144 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3145 Include tparam.h instead, since it declares them.
3146 * cm.h (PC): Remove extern decl; tparam.h now does this.
3147 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3148 * terminfo.c: Include tparam.h, to check interfaces.
3149 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3150 (tparam): Adjust signature to match interface in tparam.h;
3151 this removes some undefined behavior. Check that outstring and len
3152 are zero, which they always are with Emacs.
3153 * tparam.h (PC, BC, UP): New extern decls.
3154
3155 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
3156 (xftfont_open): Rename locals to avoid shadowing.
3157
3158 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
3159 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3160 (OTF_TAG_SYM): Omit macro if not needed.
3161 (ftfont_list): Remove unused local.
3162 (get_adstyle_property, ftfont_pattern_entity):
3163 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3164 Rename locals to avoid shadowing.
3165
3166 * xfont.c (xfont_list_family): Mark var as initialized.
3167
3168 * xml.c (make_dom): Now static.
3169
3170 * composite.c (composition_compute_stop_pos): Rename local to
3171 avoid shadowing.
3172 (composition_reseat_it): Remove unused locals.
3173 (find_automatic_composition, composition_adjust_point): Likewise.
3174 (composition_update_it): Mark var as initialized.
3175 (find_automatic_composition): Mark vars as initialized,
3176 with a FIXME (Bug#8290).
3177
3178 character.h: Rename locals to avoid shadowing.
3179 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3180 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3181 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3182 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3183 to avoid shadowing.
3184
3185 * textprop.c (property_change_between_p): Remove; unused.
3186
3187 * intervals.c (interval_start_pos): Now static.
3188
3189 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3190
3191 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3192 Rename locals to avoid shadowing.
3193
3194 * sound.c (wav_play, au_play, Fplay_sound_internal):
3195 Fix pointer signedness.
3196 (alsa_choose_format): Remove unused local var.
3197 (wav_play): Initialize a variable to 0, to prevent undefined
3198 behavior (Bug#8278).
3199
3200 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3201
3202 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3203
3204 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3205 clobbering (Bug#8298).
3206 * sysdep.c (sys_subshell): Likewise.
3207 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
3208
3209 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3210 This should get cleaned up, so that child_setup has the
3211 same signature on all platforms.
3212
3213 * callproc.c (call_process_cleanup): Now static.
3214 (relocate_fd): Rename locals to avoid shadowing.
3215
3216 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
3217
3218 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3219 not to be necessary, and produces flickering.
3220
3221 2011-03-20 Glenn Morris <rgm@gnu.org>
3222
3223 * config.in: Remove file.
3224
3225 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
3226
3227 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3228 are now in src/globals.h.
3229 (syms_of_minibuf): Remove spurious & from previous change.
3230
3231 2011-03-20 Leo <sdl.web@gmail.com>
3232
3233 * minibuf.c (completing-read-function): New variable.
3234 (completing-read-default): Rename from completing-read.
3235 (completing-read): Call completing-read-function.
3236
3237 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3238
3239 * xfaces.c (Fx_load_color_file):
3240 Read color file from absolute filename (bug#8250).
3241
3242 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3243
3244 * makefile.w32-in: Update dependencies.
3245
3246 2011-03-17 Eli Zaretskii <eliz@gnu.org>
3247
3248 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3249
3250 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3251
3252 Fix more problems found by GCC 4.5.2's static checks.
3253
3254 * process.c (make_serial_process_unwind, send_process_trap):
3255 (sigchld_handler): Now static.
3256
3257 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3258 That way, the code declares only the vars that it needs.
3259 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3260 * s/cygwin.h (PTY_ITERATION): Likewise.
3261 * s/darwin.h (PTY_ITERATION): Likewise.
3262 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3263
3264 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3265 * process.c (allocate_pty): Don't declare stb unless it's needed.
3266
3267 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
3268 (CONSTANTLIM): Remove; unused.
3269 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3270 Define only if needed.
3271
3272 * unexelf.c (unexec): Name an expression,
3273 to avoid gcc -Wbad-function-cast warning.
3274 Use a different way to cause a compilation error if anyone uses
3275 n rather than nn, a way that does not involve shadowing.
3276 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
3277
3278 * deps.mk (unexalpha.o): Remove; unused.
3279
3280 New file unexec.h, the (simple) interface for unexec (Bug#8267).
3281 * unexec.h: New file.
3282 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3283 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3284 Depend on unexec.h.
3285 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3286 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3287 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
3288 Change as necessary to match prototype in unexec.h.
3289
3290 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3291 shadowing.
3292 (back_comment, skip_chars): Mark vars as initialized.
3293
3294 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3295 Rename locals to avoid shadowing.
3296
3297 * lread.c (read1): Rewrite so as not to use empty "else".
3298 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
3299
3300 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3301
3302 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3303 warning when compiling print.c.
3304
3305 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3306 instead of using an uninitialized var.
3307 (font_sort_entities): Mark var as initialized.
3308
3309 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3310
3311 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3312 pointers to constants.
3313 (font_parse_fcname): Remove unused vars.
3314 (font_delete_unmatched): Now static.
3315 (font_get_spec): Remove; unused.
3316 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3317 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3318 Rename or move locals to avoid shadowing.
3319
3320 * fns.c (require_nesting_list, require_unwind): Now static.
3321 (Ffillarray): Rename locals to avoid shadowing.
3322
3323 * floatfns.c (domain_error2): Define only if needed.
3324 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
3325
3326 * alloc.c (mark_backtrace): Move decl from here ...
3327 * lisp.h: ... to here, so that it can be checked.
3328
3329 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
3330 (Fdefvar): Rewrite so as not to use empty "else".
3331 (lisp_indirect_variable): Name an expression,
3332 to avoid gcc -Wbad-function-cast warning.
3333 (Fdefvar): Rename locals to avoid shadowing.
3334
3335 * callint.c (quotify_arg, quotify_args): Now static.
3336 (Fcall_interactively): Rename locals to avoid shadowing.
3337 Use const pointer when appropriate.
3338
3339 * lisp.h (get_system_name, get_operating_system_release):
3340 Move decls here, to check interfaces.
3341 * process.c (get_operating_system_release): Move decl to lisp.h.
3342 * xrdb.c (get_system_name): Likewise.
3343 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
3344 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
3345 some of which prompt warnings from gcc -Wbad-function-cast.
3346 (Fformat_time_string, Fencode_time, Finsert_char):
3347 (Ftranslate_region_internal, Fformat):
3348 Rename or remove local vars to avoid shadowing.
3349 (Ftranslate_region_internal): Mark var as initialized.
3350
3351 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
3352 avoid shadowing.
3353
3354 * lisp.h (eassert): Check that the argument compiles, even if
3355 ENABLE_CHECKING is not defined.
3356
3357 * data.c (Findirect_variable): Name an expression, to avoid
3358 gcc -Wbad-function-cast warning.
3359 (default_value, arithcompare, arith_driver, arith_error): Now static.
3360 (store_symval_forwarding): Rename local to avoid shadowing.
3361 (Fmake_variable_buffer_local, Fmake_local_variable):
3362 Mark variables as initialized.
3363 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
3364
3365 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
3366 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
3367 Rename locals to avoid shadowing.
3368 (mark_stack): Move local variables into the #ifdef region where
3369 they're used.
3370 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
3371 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
3372 needed otherwise.
3373 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
3374 (GC_STRING_CHARS): Remove; not used.
3375 (Fmemory_limit): Cast sbrk's returned value to char *.
3376
3377 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
3378 avoids undefined behavior in theory.
3379
3380 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
3381
3382 Use functions, not macros, for up- and down-casing (Bug#8254).
3383 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3384 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
3385 to use the following functions instead of these macros.
3386 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
3387 EMACS_INT, since callers assume the returned value fits in int.
3388 (upcase1): Likewise, for UPCASE_TABLE.
3389 (uppercasep, lowercasep, upcase): New static inline functions.
3390 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
3391 the race-condition problem in the old DOWNCASE.
3392
3393 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
3394 Rename locals to avoid shadowing.
3395 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
3396 (regex_compile, re_search_2, re_match_2_internal):
3397 Remove unused local vars.
3398 (FREE_VAR): Rewrite so as not to use empty "else",
3399 which gcc can warn about.
3400 (regex_compile, re_match_2_internal): Mark locals as initialized.
3401 (RETALLOC_IF): Define only if needed.
3402 (WORDCHAR_P): Likewise. This one is never needed, but is used
3403 only in a comment talking about a compiler bug, so put inside
3404 the #if 0 of that comment.
3405 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
3406 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
3407 Remove; unused.
3408
3409 * search.c (boyer_moore): Rename locals to avoid shadowing.
3410 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
3411 (PREV_CHAR_BOUNDARY): Likewise.
3412
3413 * search.c (simple_search): Remove unused var.
3414
3415 * dired.c (compile_pattern): Move decl from here ...
3416 * lisp.h: ... to here, so that it can be checked.
3417 (struct re_registers): New forward decl.
3418
3419 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
3420
3421 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
3422 All uses changed.
3423 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
3424 Rename locals to avoid shadowing.
3425 (Fvertical_motion): Mark locals as initialized.
3426
3427 * casefiddle.c (casify_object, casify_region): Now static.
3428 (casify_region): Mark local as initialized.
3429
3430 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
3431
3432 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3433 New macros, so that the caller can use some names other than
3434 gcpro1, gcpro2, etc.
3435 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3436 of the new macros.
3437 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3438 argument, for consistency with GCPRO2_VAR, etc: it is now the
3439 prefix of the variable, not the variable itself. All uses
3440 changed.
3441 * dired.c (directory_files_internal, file_name_completion):
3442 Rename locals to avoid shadowing.
3443
3444 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
3445 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
3446 dired.c's scmp function, had undefined behavior.
3447 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3448 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
3449 * buffer.h: ... to here, because these macros use current_buffer,
3450 and the new implementation with inline functions needs to have
3451 current_buffer in scope now, rather than later when the macros
3452 are used.
3453 (downcase, upcase1): New static inline functions.
3454 (DOWNCASE, UPCASE1): Reimplement using these functions.
3455 This avoids undefined behavior in expressions like
3456 DOWNCASE (x) == DOWNCASE (y), which previously suffered
3457 from race conditions in accessing the global variables
3458 case_temp1 and case_temp2.
3459 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
3460 * lisp.h (case_temp1, case_temp2): Remove their decls.
3461 * character.h (ASCII_CHAR_P): Move from here ...
3462 * lisp.h: ... to here, so that the inline functions mentioned
3463 above can use them.
3464
3465 * dired.c (directory_files_internal_unwind): Now static.
3466
3467 * fileio.c (file_name_as_directory, directory_file_name):
3468 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
3469 Now static.
3470 (file_name_as_directory): Use const pointers when appropriate.
3471 (Fexpand_file_name): Likewise. In particular, newdir might
3472 point at constant storage, so make it a const pointer.
3473 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
3474 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
3475 signedness issues.
3476 (Fset_file_times, Finsert_file_contents, auto_save_error):
3477 Rename locals to avoid shadowing.
3478
3479 * minibuf.c (choose_minibuf_frame_1): Now static.
3480 (Ftry_completion, Fall_completions): Rename or remove locals
3481 to avoid shadowing.
3482
3483 * marker.c (bytepos_to_charpos): Remove; unused.
3484
3485 * lisp.h (verify_bytepos, count_markers): New decls,
3486 so that gcc does not warn that these functions aren't declared.
3487
3488 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
3489 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
3490 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
3491 (copy_text): Remove unused local var.
3492
3493 * filelock.c (within_one_second): Now static.
3494 (lock_file_1): Rename local to avoid shadowing.
3495
3496 * buffer.c (fix_overlays_before): Mark locals as initialized.
3497 (fix_start_end_in_overlays): Likewise. This function should be
3498 simplified by using pointers-to-pointers, but that's a different
3499 matter.
3500 (switch_to_buffer_1): Now static.
3501 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
3502 (report_overlay_modification): Rename locals to avoid shadowing.
3503
3504 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
3505 Fix pointer signedness issue.
3506 (sys_subshell): Mark local as volatile if checking for lint,
3507 to suppress a gcc -Wclobbered warning that does not seem to be right.
3508 (MAXPATHLEN): Define only if needed.
3509
3510 * process.c (serial_open, serial_configure): Move decls from here ...
3511 * systty.h: ... to here, so that they can be checked.
3512
3513 * fns.c (get_random, seed_random): Move extern decls from here ...
3514 * lisp.h: ... to here, so that they can be checked.
3515
3516 * sysdep.c (reset_io): Now static.
3517 (wait_for_termination_signal): Remove; unused.
3518
3519 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
3520 (copy_keymap_item, append_key, push_text_char_description):
3521 Now static.
3522 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
3523 (DENSE_TABLE_SIZE): Remove; unused.
3524 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
3525 (describe_map_tree):
3526 Rename locals to avoid shadowing.
3527
3528 * keyboard.c: Declare functions static if they are not used elsewhere.
3529 (echo_char, echo_dash, cmd_error, top_level_2):
3530 (poll_for_input, handle_async_input): Now static.
3531 (read_char, kbd_buffer_get_event, make_lispy_position):
3532 (make_lispy_event, make_lispy_movement, apply_modifiers):
3533 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
3534 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
3535 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
3536 (read_key_sequence, read_char): Mark locals as initialized.
3537 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
3538
3539 * keyboard.h (make_ctrl_char): New decl.
3540 (mark_kboards): Move decl here ...
3541 * alloc.c (mark_kboards): ... from here.
3542
3543 * lisp.h (force_auto_save_soon): New decl.
3544
3545 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
3546 (DEFINE_DUMMY_FUNCTION): New macro.
3547 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
3548 Use it.
3549 (main): Add casts to avoid warnings
3550 if GCC considers string literals to be constants.
3551
3552 * lisp.h (fatal_error_signal): Add decl, since it's exported.
3553
3554 * dbusbind.c: Pointer signedness fixes.
3555 (xd_signature, xd_append_arg, xd_initialize):
3556 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3557 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3558 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
3559 (Fdbus_register_signal): Use SSDATA when the context wants char *.
3560
3561 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
3562 if GCC considers string literals to be constants.
3563 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
3564
3565 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
3566
3567 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
3568 (print_preprocess, print_object): New macro to fix last change.
3569
3570 * print.c (print_preprocess): Don't forget font objects.
3571
3572 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
3573
3574 * emacs.c (USAGE3): Doc fixes.
3575
3576 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
3577
3578 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3579 structure.
3580
3581 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
3582
3583 * lisp.h (VWindow_system, Qfile_name_history):
3584 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3585 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3586 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3587
3588 * w32select.c: Don't #include "keyboard.h".
3589 (run_protected): Add extern declaration for waiting_for_input.
3590
3591 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3592 * w32console.c (detect_input_pending, read_input_pending)
3593 (encode_terminal_code):
3594 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3595 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3596 (w32_system_caret_y, Qfile_name_history):
3597 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3598 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3599 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3600 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3601 * w32proc.c (Qlocal, report_file_error):
3602 * w32term.c (Vwindow_system, updating_frame):
3603 * w32uniscribe.c (initialized, uniscribe_font_driver):
3604 Remove unneeded extern declarations.
3605
3606 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
3607
3608 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
3609
3610 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
3611
3612 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3613 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3614 These macros can no longer be used for assignment.
3615
3616 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3617 Assign struct members directly, instead of using BUF_BEGV etc.
3618 (record_buffer_markers, fetch_buffer_markers): New functions for
3619 recording and fetching special buffer markers.
3620 (set_buffer_internal_1, set_buffer_temp): Use them.
3621
3622 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3623
3624 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3625
3626 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3627 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3628
3629 * xdisp.c (hscroll_window_tree):
3630 (reconsider_clip_changes): Use PT instead of BUF_PT.
3631
3632 2011-03-13 Eli Zaretskii <eliz@gnu.org>
3633
3634 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3635 $(EMACS_ROOT)/lib/intprops.h.
3636
3637 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3638
3639 Fix more problems found by GCC 4.5.2's static checks.
3640
3641 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
3642 to unsigned char * to avoid compiler diagnostic.
3643 (xg_free_frame_widgets): Make it clear that a local variable is
3644 needed only if USE_GTK_TOOLTIP.
3645 (gdk_window_get_screen): Make it clear that this macro is needed
3646 only if USE_GTK_TOOLTIP.
3647 (int_gtk_range_get_value): New function, which avoids a diagnostic
3648 from gcc -Wbad-function-cast.
3649 (xg_set_toolkit_scroll_bar_thumb): Use it.
3650 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
3651 diagnostic from gcc -Wbad-function-cast.
3652 (get_utf8_string, xg_get_file_with_chooser):
3653 Rename locals to avoid shadowing.
3654 (create_dialog): Move locals to avoid shadowing.
3655
3656 * xgselect.c (xg_select): Remove unused var.
3657
3658 * image.c (four_corners_best): Mark locals as initialized.
3659 (gif_load): Initialize transparent_p to zero (Bug#8238).
3660 Mark another local as initialized.
3661 (my_png_error, my_error_exit): Mark with NO_RETURN.
3662
3663 * image.c (clear_image_cache): Now static.
3664 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
3665 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
3666 (x_edge_detection): Remove unnecessary cast that
3667 gcc -Wbad-function-cast diagnoses.
3668 (gif_load): Fix pointer signedness.
3669 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
3670 (jpeg_load, gif_load): Rename locals to avoid shadowing.
3671
3672 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3673
3674 Improve quality of tests for time stamp overflow.
3675 For example, without this patch (encode-time 0 0 0 1 1
3676 1152921504606846976) returns the obviously-bogus value (-948597
3677 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
3678 reports time overflow. See
3679 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
3680 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
3681 * editfns.c: Include limits.h and intprops.h.
3682 (TIME_T_MIN, TIME_T_MAX): New macros.
3683 (time_overflow): Move earlier, to before first use.
3684 (hi_time, lo_time): New functions, for an accurate test for
3685 out-of-range times.
3686 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
3687 (Fget_internal_run_time): Don't assume time_t fits in int.
3688 (make_time): Use list2 instead of Fcons twice.
3689 (Fdecode_time): More accurate test for out-of-range times.
3690 (check_tm_member): New function.
3691 (Fencode_time): Use it, to test for out-of-range times.
3692 (lisp_time_argument): Don't rely on undefined left-shift and
3693 right-shift behavior when checking for time stamp overflow.
3694
3695 * editfns.c (time_overflow): New function, refactoring common code.
3696 (Fformat_time_string, Fdecode_time, Fencode_time):
3697 (Fcurrent_time_string): Use it.
3698
3699 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
3700 * dired.c (make_time): Move to ...
3701 * editfns.c (make_time): ... here.
3702 * systime.h: Note the move.
3703
3704 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3705
3706 * fringe.c (update_window_fringes): Remove unused variables.
3707
3708 * unexmacosx.c (copy_data_segment): Also copy __got section.
3709 (Bug#8223)
3710
3711 2011-03-12 Eli Zaretskii <eliz@gnu.org>
3712
3713 * termcap.c [MSDOS]: Include "msdos.h".
3714 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
3715 Constify `char *' arguments and their references according to
3716 prototypes in tparam.h.
3717
3718 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
3719
3720 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
3721 Adapt all references accordingly.
3722
3723 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
3724
3725 2011-03-11 Tom Tromey <tromey@redhat.com>
3726
3727 * buffer.c (syms_of_buffer): Remove obsolete comment.
3728
3729 2011-03-11 Eli Zaretskii <eliz@gnu.org>
3730
3731 * termhooks.h (encode_terminal_code): Declare prototype.
3732
3733 * msdos.c (encode_terminal_code): Don't declare prototype.
3734
3735 * term.c (encode_terminal_code): Now external again, used by
3736 w32console.c and msdos.c.
3737
3738 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
3739 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
3740
3741 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
3742
3743 Fix some minor problems found by GCC 4.5.2's static checks.
3744
3745 * fringe.c (update_window_fringes): Mark locals as initialized
3746 (Bug#8227).
3747 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
3748
3749 * alloc.c (mark_fringe_data): Move decl from here ...
3750 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
3751 to check its interface.
3752 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
3753
3754 * fontset.c (free_realized_fontset): Now static.
3755 (Fset_fontset_font): Rename local to avoid shadowing.
3756 (fontset_font): Mark local as initialized.
3757 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
3758
3759 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
3760
3761 * xselect.c (x_disown_buffer_selections): Remove; not used.
3762 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
3763 (x_own_selection, Fx_disown_selection_internal): Rename locals
3764 to avoid shadowing.
3765 (x_handle_dnd_message): Remove local to avoid shadowing.
3766
3767 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
3768 so that the caller can use some name other than gcpro1.
3769 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
3770 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3771 (Fx_backspace_delete_keys_p):
3772 Use them to avoid shadowing, and rename vars to avoid shadowing.
3773 (x_decode_color, x_set_name, x_window): Now static.
3774 (Fx_create_frame): Add braces to silence GCC warning.
3775 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
3776 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
3777 Remove unused locals.
3778 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3779 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
3780 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
3781 macros.
3782
3783 * xterm.h (x_mouse_leave): New decl.
3784
3785 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
3786 Remove unused functions.
3787 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
3788 (x_calc_absolute_position): Now static.
3789 (XTread_socket): Don't define label "out" unless it's used.
3790 Don't declare local "event" unless it's used.
3791 (x_iconify_frame, x_free_frame_resources): Don't declare locals
3792 unless they are used.
3793 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
3794 (x_fatal_error_signal): Remove; not used.
3795 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
3796 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
3797 (x_error_catcher, x_connection_closed, x_error_handler):
3798 (x_error_quitter, xembed_send_message, x_iconify_frame):
3799 (my_log_handler): Rename locals to avoid shadowing.
3800 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
3801 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
3802
3803 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
3804 Rename or move locals to avoid shadowing.
3805 (tty_defined_color, merge_face_heights): Now static.
3806 (free_realized_faces_for_fontset): Remove; not used.
3807 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
3808 does not deduce is never used uninitialized.
3809 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
3810 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
3811
3812 * terminal.c (store_terminal_param): Now static.
3813
3814 * xmenu.c (menu_highlight_callback): Now static.
3815 (set_frame_menubar): Remove unused local.
3816 (xmenu_show): Rename parameter to avoid shadowing.
3817 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
3818 since they might point to immutable storage.
3819 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
3820 since it's unused otherwise.
3821
3822 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
3823 Add a FIXME, since the code still doesn't look right. (Bug#8215)
3824 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
3825 avoids a gcc -Wuninitialized diagnostic.
3826 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
3827 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
3828 does not deduce are never used uninitialized.
3829
3830 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
3831
3832 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
3833 * window.c (window_loop, size_window):
3834 (run_window_configuration_change_hook, enlarge_window): Likewise.
3835
3836 * window.c (display_buffer): Now static.
3837 (size_window): Mark variables that gcc -Wuninitialized
3838 does not deduce are never used uninitialized.
3839 * window.h (check_all_windows): New decl, to forestall
3840 gcc -Wmissing-prototypes diagnostic.
3841 * dispextern.h (bidi_dump_cached_states): Likewise.
3842
3843 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
3844 shadowing.
3845 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
3846 Include <limits.h>.
3847 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
3848 and to avoid gcc -Wuninitialized warning.
3849 (load_charset_map): Mark variables that gcc -Wuninitialized
3850 does not deduce are never used uninitialized.
3851 (load_charset): Abort instead of using uninitialized var (Bug#8229).
3852
3853 * coding.c (coding_set_source, coding_set_destination):
3854 Use "else { /* comment */ }" rather than "else /* comment */;"
3855 for clarity, and to avoid gcc -Wempty-body warning.
3856 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
3857 a block, when the outer 'i' will do.
3858 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
3859 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
3860 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
3861 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
3862 (Fdecode_sjis_char, Fdefine_coding_system_internal):
3863 Rename locals to avoid shadowing.
3864 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
3865 * coding.c (emacs_mule_char, encode_invocation_designation):
3866 Now static, since they're not used elsewhere.
3867 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
3868 (decode_coding_object, encode_coding_object, detect_coding_system):
3869 (decode_coding_emacs_mule): Mark variables that gcc
3870 -Wuninitialized does not deduce are never used uninitialized.
3871 (detect_coding_iso_2022): Initialize a local variable that might
3872 be used uninitialized. Leave a FIXME because it's not clear that
3873 this initialization is needed. (Bug#8211)
3874 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
3875 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
3876 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
3877 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
3878 Remove unused macros.
3879
3880 * category.c (hash_get_category_set): Remove unused local var.
3881 (copy_category_table): Now static, since it's not used elsewhere.
3882 * character.c (string_count_byte8): Likewise.
3883
3884 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
3885 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
3886
3887 * chartab.c (copy_sub_char_table): Now static, since it's not used
3888 elsewhere.
3889 (sub_char_table_ref_and_range, char_table_ref_and_range):
3890 Rename locals to avoid shadowing.
3891 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
3892
3893 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
3894 (BIDI_BOB): Remove unused macro.
3895
3896 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
3897 deduce are never used uninitialized.
3898 * term.c (encode_terminal_code): Likewise.
3899
3900 * term.c (encode_terminal_code): Now static. Remove unused local.
3901
3902 * tparam.h: New file.
3903 * term.c, tparam.h: Include it.
3904 * deps.mk (term.o, tparam.o): Depend on tparam.h.
3905 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
3906 Move these decls to tparam.h, and make them agree with what
3907 is actually in tparam.c. The previous trick of using incompatible
3908 decls in different modules does not conform to the C standard.
3909 All callers of tparam changed to use tparam's actual API.
3910 * tparam.c (tparam1, tparam, tgoto):
3911 Use const pointers where appropriate.
3912
3913 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
3914 * cm.h (struct cm): Likewise.
3915 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
3916 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
3917 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
3918 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
3919 (turn_on_face, init_tty): Likewise.
3920 * termchar.h (struct tty_display_info): Likewise.
3921
3922 * term.c (term_mouse_position): Rename local to avoid shadowing.
3923
3924 * alloc.c (mark_ttys): Move decl from here ...
3925 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
3926
3927 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
3928
3929 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
3930
3931 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
3932
3933 * search.c (compile_pattern_1): Remove argument regp, unused since
3934 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
3935 (compile_pattern): Don't pass it.
3936
3937 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
3938
3939 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
3940 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
3941 for ! HAVE_GTK3.
3942 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
3943
3944 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
3945
3946 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
3947 gdk_window_get_screen, gdk_window_get_geometry,
3948 gdk_x11_window_lookup_for_display and GDK_KEY_g.
3949 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
3950 (xg_get_pixbuf_from_pixmap): New function.
3951 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
3952 to Pixmap, take frame as parameter, remove GdkColormap parameter.
3953 Call xg_get_pixbuf_from_pixmap instead of
3954 gdk_pixbuf_get_from_drawable.
3955 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
3956 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
3957 (xg_check_special_colors): Use GtkStyleContext and its functions
3958 for HAVE_GTK3.
3959 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
3960 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
3961 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
3962 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
3963 Call gtk_widget_get_preferred_size.
3964 (xg_frame_resized): gdk_window_get_geometry only takes 5
3965 parameters.
3966 (xg_win_to_widget, xg_event_is_for_menubar):
3967 Call gdk_x11_window_lookup_for_display.
3968 (xg_set_widget_bg): New function.
3969 (delete_cb): New function.
3970 (xg_create_frame_widgets): Connect delete-event to delete_cb.
3971 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
3972 (xg_set_background_color): Call xg_set_widget_bg.
3973 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
3974 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
3975 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
3976 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
3977 if ! HAVE_GTK3.
3978 (update_frame_tool_bar): Call gtk_widget_hide.
3979 (xg_initialize): Use GDK_KEY_g.
3980
3981 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
3982 if ! HAVE_GTK3
3983 (x_session_initialize): Call gdk_x11_set_sm_client_id.
3984
3985 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
3986 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
3987 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
3988
3989 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
3990
3991 * w32xfns.c (select_palette): Check success of RealizePalette against
3992 GDI_ERROR, not zero.
3993
3994 See ChangeLog.11 for earlier changes.
3995
3996 ;; Local Variables:
3997 ;; coding: utf-8
3998 ;; End:
3999
4000 Copyright (C) 2011 Free Software Foundation, Inc.
4001
4002 This file is part of GNU Emacs.
4003
4004 GNU Emacs is free software: you can redistribute it and/or modify
4005 it under the terms of the GNU General Public License as published by
4006 the Free Software Foundation, either version 3 of the License, or
4007 (at your option) any later version.
4008
4009 GNU Emacs is distributed in the hope that it will be useful,
4010 but WITHOUT ANY WARRANTY; without even the implied warranty of
4011 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4012 GNU General Public License for more details.
4013
4014 You should have received a copy of the GNU General Public License
4015 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.