]> code.delx.au - gnu-emacs/blob - src/ChangeLog
* lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n".
[gnu-emacs] / src / ChangeLog
1 2012-04-13 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
2
3 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n" (bug#11238).
4
5 2012-04-10 Teodor Zlatanov <tzz@lifelogs.com>
6
7 * process.c (make_process):
8 * process.h: Add integer `gnutls_handshakes_tried' member to
9 process struct.
10
11 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
12 Add convenience `GNUTLS_LOG2i' macro.
13
14 * gnutls.c (gnutls_log_function2i): Convenience log function.
15 (emacs_gnutls_read): Use new log functions,
16 `gnutls_handshakes_tried' process member, and
17 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
18 attempts per process (connection).
19
20 2012-04-09 Eli Zaretskii <eliz@gnu.org>
21
22 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
23 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
24
25 2012-04-09 Jan Djärv <jan.h.d@swipnet.se>
26
27 * nsterm.m (constrainFrameRect): Always constrain when there is only
28 one screen (Bug#10962).
29
30 2012-04-06 Eli Zaretskii <eliz@gnu.org>
31
32 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
33 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
34 about subtle differences between FETCH_CHAR* and STRING_CHAR*
35 macros related to unification of CJK characters. For the details,
36 see the discussion following the message here:
37 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
38
39 2012-04-04 Chong Yidong <cyd@gnu.org>
40
41 * keyboard.c (Vdelayed_warnings_list): Doc fix.
42
43 2012-04-01 Eli Zaretskii <eliz@gnu.org>
44
45 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
46 instead of alloca. (Bug#11138)
47
48 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
49
50 * w32menu.c (is_simple_dialog): Properly check lisp types.
51 (Bug#11141)
52
53 2012-03-31 Eli Zaretskii <eliz@gnu.org>
54
55 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
56 position we get to after a call to move_it_to fails the
57 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
58 only if we wind up in a string from display property. (Bug#11063)
59
60 * window.c (Fdelete_other_windows_internal): Invalidate the row
61 and column information about mouse highlight, so that redisplay
62 restores it after reallocating the glyph matrices. (Bug#7464)
63
64 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
65 string comes from a `display' text property, use the buffer
66 position of that property as if we actually saw that position in
67 the row's glyphs.
68 (move_it_by_lines): Remove the assertion that
69 "it->current_x == 0 && it->hpos == 0" which can be legitimately
70 violated when there's a before-string at the beginning of a line.
71 (Bug#11063)
72
73 2012-03-30 Eli Zaretskii <eliz@gnu.org>
74
75 * xdisp.c (append_space_for_newline): If the default face was
76 remapped, use the remapped face for the appended newline.
77 (extend_face_to_end_of_line): Use the remapped default face for
78 extending the face to the end of the line.
79 (display_line): Call extend_face_to_end_of_line when the default
80 face was remapped. (Bug#11068)
81
82 2012-03-29 Eli Zaretskii <eliz@gnu.org>
83
84 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
85
86 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
87
88 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
89
90 2012-03-27 Glenn Morris <rgm@gnu.org>
91
92 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
93 Doc fixes.
94
95 2012-03-26 Kenichi Handa <handa@m17n.org>
96
97 * dispextern.h (struct glyph): Fix previous change. Change the
98 bit length of glyphless.ch to 25 (Bug#11082).
99
100 2012-03-26 Chong Yidong <cyd@gnu.org>
101
102 * keyboard.c (Vselection_inhibit_update_commands): New variable.
103 (command_loop_1): Use it; inhibit selection update for
104 handle-select-window too (Bug#8996).
105
106 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
107
108 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
109
110 2012-03-25 Kenichi Handa <handa@m17n.org>
111
112 * dispextern.h (struct glyph): Change the bit length of
113 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
114
115 2012-03-24 Eli Zaretskii <eliz@gnu.org>
116
117 * s/ms-w32.h (tzname): Include time.h before redirecting to
118 _tzname. Fixes the MSVC build. (Bug#9960)
119
120 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
121
122 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
123 characters.
124
125 * xterm.c (XTread_socket): Only modify handling_signal if
126 !SYNC_INPUT. (Bug#11080)
127
128 2012-03-23 Eli Zaretskii <eliz@gnu.org>
129
130 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
131 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
132 when fetching a multibyte character consumes more bytes than
133 CHAR_BYTES returns, due to unification of CJK characters in
134 string_char. (Bug#11073)
135
136 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
137
138 * process.c (wait_reading_process_output): Handle pty disconnect
139 by refraining from sending oneself a SIGCHLD (bug#10933).
140
141 2012-03-22 Chong Yidong <cyd@gnu.org>
142
143 * dispextern.h (struct it): New member string_from_prefix_prop_p.
144
145 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
146 Mark string as coming from a prefix property.
147 (handle_face_prop): Use default face for prefix strings (Bug#4281).
148 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
149
150 2012-03-21 Chong Yidong <cyd@gnu.org>
151
152 * xfaces.c (Vface_remapping_alist): Doc fix.
153
154 2012-03-20 Eli Zaretskii <eliz@gnu.org>
155
156 * w32proc.c (Fw32_set_console_codepage)
157 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
158 Doc fixes.
159
160 2012-03-20 Chong Yidong <cyd@gnu.org>
161
162 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
163 to reflect default non-nil value of redisplay-dont-pause.
164
165 2012-03-19 Kenichi Handa <handa@m17n.org>
166
167 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
168 it fit in a valid range (Bug#11003).
169
170 2012-03-18 Eli Zaretskii <eliz@gnu.org>
171
172 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
173 that is not from display property, accept the row as a "cursor
174 row" if one of the string's character has a non-nil `cursor'
175 property. Fixes cursor positioning when there are newlines in
176 overlay strings, e.g. in icomplete.el. (Bug#11035)
177
178 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
179
180 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
181
182 2012-03-12 Chong Yidong <cyd@gnu.org>
183
184 * eval.c (inhibit_lisp_code): Rename from
185 inhibit_window_configuration_change_hook; move from window.c.
186
187 * xfns.c (unwind_create_frame_1, Fx_create_frame):
188 * window.c (run_window_configuration_change_hook)
189 (syms_of_window): Callers changed.
190
191 2012-03-11 Chong Yidong <cyd@gnu.org>
192
193 * keymap.c (Fkey_description): Doc fix (Bug#9700).
194
195 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
196
197 2012-03-10 Chong Yidong <cyd@gnu.org>
198
199 * frame.c (other_visible_frames): Don't assume the selected frame
200 is visible (Bug#10955).
201
202 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
203
204 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
205
206 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
207
208 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
209 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
210 zero (Bug#10954).
211
212 2012-03-03 Glenn Morris <rgm@gnu.org>
213
214 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
215
216 2012-03-02 Eli Zaretskii <eliz@gnu.org>
217
218 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
219 position past the first glyph_row that ends at ZV. (Bug#10902)
220 (redisplay_window, next_element_from_string): Fix typos in
221 comments.
222 (redisplay_window): Pass to move_it_vertically the margin in
223 pixels, not in screen lines.
224
225 2012-03-02 Glenn Morris <rgm@gnu.org>
226
227 * buffer.c (buffer-list-update-hook): Doc fix.
228
229 2012-02-29 Eli Zaretskii <eliz@gnu.org>
230
231 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
232 push_it before setting up the iterator for the first overlay
233 string, even if we have an empty string loaded.
234 (next_overlay_string): If there's an empty string on the iterator
235 stack, pop the stack. (Bug#10903)
236
237 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
238
239 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
240 Suggested by Stefan Monnier in
241 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
242 * alloc.c (widen_to_Lisp_Object): New static function.
243 (mark_memory): Also mark Lisp_Objects by fetching pointer words
244 and widening them to Lisp_Objects. This would work even if
245 USE_LSB_TAG is defined and wide integers are used, which might
246 happen in a future version of Emacs.
247
248 2012-02-25 Chong Yidong <cyd@gnu.org>
249
250 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
251 Doc fix.
252
253 * xselect.c (Fx_selection_exists_p): Doc fix.
254 (x_clipboard_manager_save_all): Print an informative message
255 before saving to clipboard manager.
256
257 2012-02-24 Chong Yidong <cyd@gnu.org>
258
259 * keyboard.c (process_special_events): Handle all X selection
260 requests in kbd_buffer, not just the next one (Bug#8869).
261
262 2012-02-23 Chong Yidong <cyd@gnu.org>
263
264 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
265 call when setting menu-bar-lines and tool-bar-lines parameters.
266 (unwind_create_frame_1): New helper function.
267
268 * window.c (inhibit_window_configuration_change_hook): New var.
269 (run_window_configuration_change_hook): Obey it.
270 (syms_of_window): Initialize it.
271
272 2012-02-22 Chong Yidong <cyd@gnu.org>
273
274 * xterm.c (x_draw_image_relief): Add missing type check for
275 Vtool_bar_button_margin (Bug#10743).
276
277 2012-02-21 Chong Yidong <cyd@gnu.org>
278
279 * fileio.c (Vfile_name_handler_alist): Doc fix.
280
281 * buffer.c (Fget_file_buffer): Protect against invalid file
282 handler return value.
283
284 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
285
286 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
287 when computing $valmask.
288
289 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
290 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
291 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
292 It's useless in that case, and it can cause problems on hosts
293 that allocate halves of EMACS_INT values separately.
294 Reported by Dan Horák. Diagnosed by Andreas Schwab in
295 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
296 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
297 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
298 it avoids undefined behavior on hosts where shifting right by more
299 than the word width has undefined behavior.
300
301 2012-02-19 Chong Yidong <cyd@gnu.org>
302
303 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
304 (Funhandled_file_name_directory, Ffile_name_as_directory)
305 (Fdirectory_file_name, Fexpand_file_name)
306 (Fsubstitute_in_file_name): Protect against invalid file handler
307 return values (Bug#10845).
308
309 2012-02-18 Eli Zaretskii <eliz@gnu.org>
310
311 * .gdbinit (pitx): Fix incorrect references to fields of the
312 iterator stack.
313
314 2012-02-17 Chong Yidong <cyd@gnu.org>
315
316 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
317
318 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
319
320 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
321 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
322
323 2012-02-15 Chong Yidong <cyd@gnu.org>
324
325 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
326 marked as special. Also, starting docstrings with * is obsolete.
327
328 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
329
330 * gnutls.c (emacs_gnutls_write): Fix last change.
331
332 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
333
334 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
335 send_process.
336
337 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
338
339 * keymap.c (Fsingle_key_description): Handle char ranges.
340
341 2012-02-12 Chong Yidong <cyd@gnu.org>
342
343 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
344 as that creates a dangerous corner case.
345
346 * window.c (Fdelete_window_internal): Invalidate the mouse
347 highlight (Bug#9904).
348
349 2012-02-12 Glenn Morris <rgm@gnu.org>
350
351 * xselect.c (Fx_own_selection_internal)
352 (Fx_get_selection_internal, Fx_disown_selection_internal)
353 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
354 * nsselect.m (Fx_own_selection_internal)
355 (Fx_disown_selection_internal, Fx_selection_exists_p)
356 (Fx_selection_owner_p, Fx_get_selection_internal):
357 Sync docs and argument specs with the xselect.c versions.
358
359 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
360
361 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
362
363 2012-02-11 Eli Zaretskii <eliz@gnu.org>
364
365 * w32select.c (Fx_selection_exists_p): Sync doc string and
366 argument list with xselect.c. (Bug#10783)
367
368 * w16select.c (Fx_selection_exists_p): Sync doc string and
369 argument list with xselect.c. (Bug#10783)
370
371 2012-02-10 Glenn Morris <rgm@gnu.org>
372
373 * fns.c (Fsecure_hash): Doc fix.
374
375 2012-02-09 Kenichi Handa <handa@m17n.org>
376
377 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
378
379 2012-02-07 Chong Yidong <cyd@gnu.org>
380
381 * buffer.c (Fbuffer_local_variables)
382 (buffer_lisp_local_variables): Handle unbound vars correctly;
383 don't let Qunbound leak into Lisp.
384
385 2012-02-07 Glenn Morris <rgm@gnu.org>
386
387 * image.c (Fimagemagick_types): Doc fix.
388
389 * image.c (imagemagick-render-type): Change it from a lisp object
390 to an integer. Move the doc here from the lisp manual.
391 Treat all values not equal to 0 the same.
392
393 2012-02-06 Chong Yidong <cyd@gnu.org>
394
395 * doc.c (store_function_docstring): Avoid applying docstring of
396 alias to base function (Bug#2603).
397
398 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
399
400 * .gdbinit (pp1, pv1): Remove redundant defines.
401 (pr): Use pp.
402
403 2012-02-04 Chong Yidong <cyd@gnu.org>
404
405 * nsterm.m: Declare a global (Bug#10694).
406
407 2012-02-04 Eli Zaretskii <eliz@gnu.org>
408
409 * w32.c (get_emacs_configuration_options):
410 Include --enable-checking, if specified, in the return value.
411
412 2012-02-04 Martin Rudalics <rudalics@gmx.at>
413
414 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
415 after rounding frame sizes. (Bug#9723)
416
417 2012-02-04 Eli Zaretskii <eliz@gnu.org>
418
419 * keyboard.c (adjust_point_for_property): Don't position point
420 before BEGV. (Bug#10696)
421
422 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
423
424 Handle overflow when computing char display width (Bug#9496).
425 * character.c (char_width): Return EMACS_INT, not int.
426 (char_width, c_string_width): Check for overflow when
427 computing the width; this is possible now that individual
428 characters can have unbounded width. Problem introduced
429 by merge from Emacs 23 on 2012-01-19.
430
431 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
432
433 * dbusbind.c (Fdbus_register_method): Mention the return value
434 :ignore in the docstring.
435
436 2012-02-02 Glenn Morris <rgm@gnu.org>
437
438 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
439
440 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
441 Unconditionally set to t. (Bug#10673)
442 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
443 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
444 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
445
446 2012-02-02 Kenichi Handa <handa@m17n.org>
447
448 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
449 0, do not call append_composite_glyph.
450
451 2012-02-02 Kenichi Handa <handa@m17n.org>
452
453 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
454 NULL (Bug#6988).
455 (x_produce_glyphs): If the component of a composition is a null
456 string, set it->pixel_width to 1 to avoid zero-width glyph.
457
458 2012-02-01 Eli Zaretskii <eliz@gnu.org>
459
460 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
461 first 2 arguments are identical. This makes inserting large
462 output from a subprocess an order of magnitude faster on
463 MS-Windows, where all sbrk'ed memory is always contiguous.
464
465 2012-01-31 Glenn Morris <rgm@gnu.org>
466
467 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
468 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
469 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
470
471 2012-01-29 Glenn Morris <rgm@gnu.org>
472
473 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
474
475 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
476
477 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
478
479 2012-01-28 Chong Yidong <cyd@gnu.org>
480
481 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
482
483 2012-01-26 Chong Yidong <cyd@gnu.org>
484
485 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
486
487 * search.c (Fsearch_forward, Fsearch_backward): Document negative
488 repeat counts (Bug#10507).
489
490 2012-01-26 Glenn Morris <rgm@gnu.org>
491
492 * lread.c (syms_of_lread): Doc fix.
493
494 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
495
496 * coding.c (encode_designation_at_bol): Change return value to
497 EMACS_INT.
498
499 2012-01-25 Chong Yidong <cyd@gnu.org>
500
501 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
502
503 2012-01-21 Chong Yidong <cyd@gnu.org>
504
505 * floatfns.c (Fcopysign): Make the second argument non-optional,
506 since nil is not allowed anyway.
507
508 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
509
510 * process.c (read_process_output): Use p instead of XPROCESS (proc).
511 (send_process): Likewise.
512
513 2012-01-19 Martin Rudalics <rudalics@gmx.at>
514
515 * window.c (save_window_save, Fcurrent_window_configuration)
516 (Vwindow_persistent_parameters): Do not use Qstate.
517 Rewrite doc-strings.
518
519 2012-01-19 Kenichi Handa <handa@m17n.org>
520
521 * character.c (char_width): New function.
522 (Fchar_width, c_string_width, lisp_string_width):
523 Use char_width (Bug#9496).
524
525 2012-01-16 Martin Rudalics <rudalics@gmx.at>
526
527 * window.c (Vwindow_persistent_parameters): New variable.
528 (Fset_window_configuration, save_window_save): Handle persistent
529 window parameters.
530
531 2012-01-14 Eli Zaretskii <eliz@gnu.org>
532
533 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
534 thrashing the stack of the thread. (Bug#9087)
535
536 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
537
538 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
539
540 2012-01-11 Eli Zaretskii <eliz@gnu.org>
541
542 * xdisp.c (rows_from_pos_range): Handle the case where the
543 highlight ends on a newline. (Bug#10464)
544 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
545 he end column for display of highlight that ends on a newline
546 before a R2L line.
547
548 2012-01-11 Glenn Morris <rgm@gnu.org>
549
550 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
551 from load-path also when installation-directory is nil. (Bug#10208)
552
553 2012-01-10 Glenn Morris <rgm@gnu.org>
554
555 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
556
557 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
558 Update template values to be closer to their typical values these days.
559
560 2012-01-09 Eli Zaretskii <eliz@gnu.org>
561
562 * xdisp.c (rows_from_pos_range): Accept additional argument
563 DISP_STRING, and accept any glyph in a row whose object is that
564 string as eligible for mouse highlight. Fixes mouse highlight of
565 display strings from overlays. (Bug#10464)
566
567 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
568
569 emacs: fix an auto-save permissions race condition (Bug#10400)
570 * fileio.c (auto_saving_dir_umask): New static var.
571 (Fmake_directory_internal): Use it.
572 (do_auto_save_make_dir): Set it, instead of invoking chmod after
573 creating the directory. The old code temporarily assigns
574 too-generous permissions to the directory.
575 (do_auto_save_eh): Clear it.
576 (Fdo_auto_save): Catch all errors, not just file errors, so
577 that the var is always cleared.
578
579 2012-01-07 Eli Zaretskii <eliz@gnu.org>
580
581 * search.c (scan_buffer): Pass character positions to
582 know_region_cache, not byte positions. (Bug#6540)
583
584 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
585
586 * w32.c (sys_rename): Report EXDEV when rename of a directory
587 fails because the target is on another logical disk. (Bug#10284)
588
589 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
590
591 * xterm.c (x_embed_request_focus): New function.
592
593 * xterm.h: Add prototype.
594
595 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
596
597 2012-01-05 Glenn Morris <rgm@gnu.org>
598
599 * emacs.c (emacs_copyright): Update short copyright year to 2012.
600
601 2012-01-01 Eli Zaretskii <eliz@gnu.org>
602
603 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
604 Load gnutls_transport_set_lowat only if GnuTLS version is below
605 2.11.1.
606 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
607 GnuTLS versions below 2.11.1.
608
609 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
610
611 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
612 to the doc string advising against its use for altering the way
613 windows are scrolled.
614
615 2011-12-28 Kenichi Handa <handa@m17n.org>
616
617 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
618 coding-system ASCII compatible only when it does not produce BOM
619 on encoding (Bug#10383).
620
621 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
622
623 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
624 can scroll.
625 (create_and_show_popup_menu): Always use menu_position_func for
626 Gtk3 (Bug#10361).
627
628 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
629
630 * callint.c (Fcall_interactively): Don't truncate prompt string.
631
632 2011-12-23 Eli Zaretskii <eliz@gnu.org>
633
634 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
635 property that ends at ZV, so that the bidi iteration could be
636 resumed from there (after widening). (Bug#10360)
637
638 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
639
640 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
641
642 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
643
644 * nsterm.m (x_free_frame_resources):
645 Release f->output_data.ns->miniimage.
646 (ns_index_color): Fix indentation. Do not retain
647 color_table->colors[i].
648
649 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
650 before returning.
651
652 * nsfns.m (x_set_background_color): Assign return value from
653 ns_index_color to face-background instead of NSColor*.
654 (ns_implicitly_set_icon_type): Fix indentation.
655 Change assignment in for loop to comparison.
656
657 * emacs.c (ns_pool): New variable.
658 (main): Assign ns_pool.
659 (Fkill_emacs): Call ns_release_autorelease_pool.
660
661 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
662 autorelease fdesc, release fdAttrs and tdict.
663 (ns_get_covering_families): Release charset.
664 (ns_findfonts): Release NSFontDescriptor created with new.
665 (ns_uni_to_glyphs): Fix indentation.
666 (setString): Release attrStr before assigning new value.
667
668 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
669
670 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
671 and NS_IMPL_COCOA.
672 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
673 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
674
675 2011-12-18 David Reitter <reitter@cmu.edu>
676
677 * nsterm.m (ns_term_init): Subscribe for notifications
678 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
679 to method trackingNotification in EmacsMenu.
680
681 * nsmenu.m (trackingMenu): New variable.
682 (trackingNotification): New method (from Aquamacs).
683 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
684 from Aquamacs (Bug#7030).
685
686 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
687
688 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
689 (symbol_to_nsstring): Fix indentation.
690 (ns_symbol_to_pb): New function.
691 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
692 (Fns_rotate_cut_buffers_internal): Remove.
693 (Fns_store_selection_internal): Rename from
694 Fns_store_cut_buffer_internal.
695 (ns_get_foreign_selection, Fx_own_selection_internal)
696 (Fx_disown_selection_internal, Fx_selection_exists_p)
697 (Fns_get_selection_internal, Fns_store_selection_internal):
698 Use ns_symbol_to_pb and check if return value is nil.
699 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
700 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
701 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
702 renamed to Sns_store_selection_internal.
703 (ns_handle_selection_request): Move code to Fx_own_selection_internal
704 and remove this function.
705 (ns_handle_selection_clear): Remove, never used.
706 (Fx_own_selection_internal): Move code from ns_handle_selection_request
707 here.
708
709 2011-12-17 Ken Brown <kbrown@cornell.edu>
710
711 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
712 GID is unknown (Bug#10257).
713
714 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
715
716 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
717 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
718 which caused a build failure on GNU/Linux IA-64. This problem was
719 introduced by my 2011-10-07 patch.
720
721 2011-12-15 Juri Linkov <juri@jurta.org>
722
723 * image.c (imagemagick_error): New function. (Bug#10112)
724 (imagemagick_load_image): Comment out `MagickSetResolution' call.
725 Use `imagemagick_error' where ImageMagick functions return
726 `MagickFalse'.
727 (Fimagemagick_types): Add `Fnreverse' to return the list in the
728 proper order.
729
730 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
731
732 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
733 fill background (Bug#8992).
734
735 2011-12-13 Martin Rudalics <rudalics@gmx.at>
736
737 * window.c (Vwindow_combination_resize)
738 (Vwindow_combination_limit): Use t instead of non-nil in
739 doc-strings.
740 (Vrecenter_redisplay): Add first sentence of doc-string on
741 separate line.
742 (Frecenter): Fix doc-string typo.
743
744 2011-12-11 Kenichi Handa <handa@m17n.org>
745
746 * coding.c (Funencodable_char_position): Pay attention to the
747 buffer text relocation (Bug#9389).
748
749 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
750
751 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
752 gtk_init (Bug#10100).
753
754 2011-12-10 Eli Zaretskii <eliz@gnu.org>
755
756 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
757 IT->string is nil. (Bug#10263)
758
759 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
760
761 * nsterm.h (x_free_frame_resources): Declare.
762
763 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
764 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
765
766 * nsterm.h (ns_get_defaults_value): Declare.
767
768 * nsterm.m (ns_default): Call ns_get_defaults_value.
769
770 2011-12-09 Eli Zaretskii <eliz@gnu.org>
771
772 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
773 (Bug#10170)
774
775 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
776
777 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
778 that where the value of an _OBJC_* symbol points to is in the .bss
779 section (Bug#10240).
780
781 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
782
783 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
784 after the loop to call ccl_driver at least once (Bug#8619).
785
786 2011-12-08 Kenichi Handa <handa@m17n.org>
787
788 * ftfont.c (get_adstyle_property): Fix previous change
789 (Bug#10233).
790
791 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
792
793 * w32.c (init_environment): If no_site_lisp, remove site-lisp
794 dirs from the default value of EMACSLOADPATH (bug#10208).
795
796 2011-12-07 Glenn Morris <rgm@gnu.org>
797
798 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
799 installation and source directories as well. (Bug#10208)
800
801 2011-12-06 Chong Yidong <cyd@gnu.org>
802
803 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
804
805 2011-12-06 Glenn Morris <rgm@gnu.org>
806
807 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
808 as an error, not just -1. (Bug#10217)
809
810 2011-12-05 Chong Yidong <cyd@gnu.org>
811
812 * keyboard.c (process_special_events): New function.
813 (swallow_events, Finput_pending_p): Use it (Bug#10195).
814
815 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
816
817 * coding.c (encode_designation_at_bol): Don't use uninitialized
818 local variable (Bug#9318).
819
820 2011-12-05 Kenichi Handa <handa@m17n.org>
821
822 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
823 return Qnil (Bug#8046, Bug#10193).
824
825 2011-12-05 Kenichi Handa <handa@m17n.org>
826
827 * coding.c (encode_designation_at_bol): New args charbuf_end and
828 dst. Return the number of produced bytes. Callers changed.
829 (coding_set_source): Return how many bytes coding->source was
830 relocated.
831 (coding_set_destination): Return how many bytes
832 coding->destination was relocated.
833 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
834 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
835
836 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
837
838 * coding.c (CODING_CHAR_CHARSET_P): New macro.
839 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
840 macro (Bug#9318).
841
842 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
843
844 The following changes are to fix Bug#9318.
845
846 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
847 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
848 (encode_coding_iso_2022, encode_coding_sjis)
849 (encode_coding_big5, encode_coding_charset): Use the above macros.
850
851 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
852
853 * lisp.h (process_quit_flag): Fix external declaration.
854
855 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
856
857 Don't macro-inline non-performance-critical code.
858 * eval.c (process_quit_flag): New function.
859 * lisp.h (QUIT): Use it.
860
861 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
862
863 * nsfns.m (get_geometry_from_preferences): New function.
864 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
865
866 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
867
868 * emacs.c (Qkill_emacs): Define.
869 (syms_of_emacs): Initialize it.
870 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
871 Qquit_flag to `kill-emacs' instead.
872 (quit_throw_to_read_char): Add parameter `from_signal'.
873 All callers changed. Call Fkill_emacs if requested and safe.
874 * lisp.h (QUIT): Call Fkill_emacs if requested.
875
876 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
877
878 * widget.c (update_wm_hints): Return if wmshell is null.
879 (widget_update_wm_size_hints): New function.
880
881 * widget.h (widget_update_wm_size_hints): Declare.
882
883 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
884 widget_update_wm_size_hints (Bug#10104).
885
886 2011-12-03 Eli Zaretskii <eliz@gnu.org>
887
888 * xdisp.c (handle_invisible_prop): If the invisible text ends just
889 before a newline, prepare the bidi iterator for consuming the
890 newline, and keep the current paragraph direction. (Bug#10183)
891 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
892
893 2011-12-02 Juri Linkov <juri@jurta.org>
894
895 * search.c (Fword_search_regexp): New Lisp function created from
896 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
897 (Fword_search_backward, Fword_search_forward)
898 (Fword_search_backward_lax, Fword_search_forward_lax):
899 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
900 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
901
902 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
903
904 * fileio.c (Finsert_file_contents): Move after-change-function call
905 to before the "handled:" label, since all "goto handled" appear in
906 cases where the *-change-functions have already been properly called
907 (bug#10117).
908
909 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
910
911 * keyboard.c (interrupt_signal): Don't call kill-emacs when
912 waiting for input. (Bug#10169)
913
914 2011-11-30 Eli Zaretskii <eliz@gnu.org>
915
916 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
917 verifies glyph row's hash code--we have just reallocated the
918 glyphs, so their contents can be complete garbage. (Bug#10164)
919
920 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
921
922 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
923
924 2011-11-30 Eli Zaretskii <eliz@gnu.org>
925
926 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
927 attributes are tested _before_ calling verify_row_hash, to protect
928 against GCC re-ordering of the tests. (Bug#10164)
929
930 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
931
932 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
933
934 * xterm.c (handle_one_xevent): Only set async_visible and friends
935 if net_wm_state_hidden_seen is non-zero (Bug#10002)
936 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
937 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
938
939 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
940
941 Remove GCPRO-related macros that exist only to avoid shadowing locals.
942 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
943 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
944 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
945 All uses changed to use GCPRO1 etc.
946 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
947 Revert to old implementation (i.e., before 2011-03-11).
948
949 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
950
951 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
952 of scroll runs so as to avoid assigning disabled bogus rows and
953 unnecessary graphics copy operations.
954
955 2011-11-27 Eli Zaretskii <eliz@gnu.org>
956
957 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
958 (snprintf) [_MSC_VER]: Redirect to _snprintf.
959 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
960 (malloc, free, realloc, calloc): Redirect to e_* only when
961 compiling Emacs.
962
963 * lisp.h (GCTYPEBITS): Move before first use.
964 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
965 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
966 this macro definition.
967
968 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
969 _MSC_VER.
970
971 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
972
973 * gtkutil.c (xg_create_frame_widgets):
974 Call gtk_window_set_has_resize_grip (FALSE) if that function is
975 present with Gtk+ 2.0.
976
977 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
978
979 * fileio.c (Finsert_file_contents): Undo previous change; see
980 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
981
982 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
983
984 Rename locals to avoid shadowing.
985 * fileio.c (Finsert_file_contents):
986 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
987 * process.c (wait_reading_process_output):
988 Rename inner 'proc' to 'p' to avoid shadowing.
989 Indent for consistency with usual Emacs style.
990
991 2011-11-25 Eli Zaretskii <eliz@gnu.org>
992
993 * xdisp.c (redisplay_window): If cursor row is not fully visible
994 after recentering, and scroll-conservatively is set to a large
995 number, scroll window by a few more lines to make the cursor fully
996 visible and out of scroll-margin. (Bug#10105)
997 (start_display): Don't move to the next line if the display should
998 start at a newline that is part of a display vector or an overlay
999 string. (Bug#10119)
1000
1001 2011-11-24 Juri Linkov <juri@jurta.org>
1002
1003 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1004 after the `MagickPingImage' call. (Bug#10112)
1005
1006 2011-11-23 Chong Yidong <cyd@gnu.org>
1007
1008 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1009
1010 2011-11-23 Martin Rudalics <rudalics@gmx.at>
1011
1012 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1013 making another buffer current. (Bug#10114)
1014
1015 2011-11-23 Glenn Morris <rgm@gnu.org>
1016
1017 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1018
1019 2011-11-23 Chong Yidong <cyd@gnu.org>
1020
1021 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1022 using it (Bug#5984).
1023
1024 2011-11-22 Eli Zaretskii <eliz@gnu.org>
1025
1026 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1027 and header-lines, as they don't have one computed for them.
1028 (Bug#10098)
1029
1030 * .gdbinit (prow): Make displayed values more self-explaining.
1031 Add row's hash code.
1032
1033 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1034
1035 * process.c (wait_reading_process_output): Fix asynchrounous
1036 GnuTLS socket handling on some versions of the GnuTLS library.
1037 (wait_reading_process_output): Add comment and URL.
1038
1039 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1040
1041 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1042
1043 2011-11-21 Chong Yidong <cyd@gnu.org>
1044
1045 * window.c (Fnext_window, Fprevious_window): Doc fix.
1046
1047 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1048
1049 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1050
1051 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1052
1053 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1054
1055 2011-11-20 Martin Rudalics <rudalics@gmx.at>
1056
1057 * window.c (Fset_window_combination_limit): Rename argument
1058 STATUS to LIMIT.
1059 (Vwindow_combination_limit): Remove "status" from doc-string.
1060
1061 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1062
1063 * m/ibms390.h: Remove.
1064 * m/ibms390x.h: Don't include "ibms390.h".
1065
1066 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1067
1068 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1069 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1070
1071 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
1072
1073 * casetab.c (Fset_case_table):
1074 * charset.c (Fcharset_after): Fix typos.
1075
1076 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
1077
1078 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1079 Otherwise, valgrind does not work on some platforms.
1080 Problem reported by Andreas Schwab in
1081 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1082 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1083 is set, removing the need for VIRT_ADDRESS_VARIES.
1084 (PURE_P): Use a more-efficient implementation that needs just one
1085 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1086 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1087 to 4 (xorl, subq, cmpq, setbe).
1088 * alloc.c (pure): Always extern now, since that's the
1089 VIRT_ADDR_VARIES behavior.
1090 (PURE_POINTER_P): Use a single comparison, not two, for
1091 consistency with the new puresize.h.
1092 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1093 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1094 Remove VIRT_ADDR_VARIES no longer needed.
1095
1096 2011-11-19 Eli Zaretskii <eliz@gnu.org>
1097
1098 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1099 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1100 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1101 behave as if the cursor position were at the window margin.
1102
1103 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1104 and the cursor position is out of bounds, behave as if the cursor
1105 position were at the window margin. (Bug#10075)
1106
1107 2011-11-18 Chong Yidong <cyd@gnu.org>
1108
1109 * window.c (Fwindow_combination_limit): Make first argument
1110 non-optional, since it is meaningless for live windows like the
1111 selected window.
1112
1113 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1114
1115 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1116
1117 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1118
1119 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1120 (graft_intervals_into_buffer): Simplify.
1121
1122 2011-11-18 Eli Zaretskii <eliz@gnu.org>
1123
1124 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1125 hash values of the two rows.
1126 (copy_row_except_pointers): Preserve the used[] arrays and the
1127 hash values of the two rows. (Bug#10035)
1128 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
1129
1130 * xdisp.c (row_hash): New function, body extracted from
1131 compute_line_metrics.
1132 (compute_line_metrics): Call row_hash, instead of computing the
1133 hash code inline.
1134
1135 * dispnew.c (verify_row_hash): Call row_hash for computing the
1136 hash code of a row, instead of duplicating code from xdisp.c.
1137
1138 * dispextern.h (row_hash): Add prototype.
1139
1140 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1141
1142 * frame.c (delete_frame): Don't delete the terminal when the last
1143 X frame is closed if emacs is built with GTK toolkit.
1144
1145 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
1146
1147 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1148
1149 2011-11-17 Martin Rudalics <rudalics@gmx.at>
1150
1151 * window.c (Vwindow_splits): Rename to
1152 Vwindow_combination_resize. Suggested by Juri Linkov.
1153 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1154 of Vwindow_splits.
1155
1156 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
1157
1158 * nsfns.m (Fns_font_name):
1159 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
1160
1161 2011-11-16 Martin Rudalics <rudalics@gmx.at>
1162
1163 * window.h (window): Rename slot "nest" to "combination_limit".
1164 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1165 (Fset_window_nest): Rename to Fset_window_combination_limit.
1166 (Vwindow_nest): Rename to Vwindow_combination_limit.
1167 (recombine_windows, make_parent_window, make_window)
1168 (Fsplit_window_internal, saved_window)
1169 (Fset_window_configuration, save_window_save): Rename all
1170 occurrences of window_nest to window_combination_limit.
1171
1172 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
1173
1174 * image.c (imagemagick_load_image): Fix typo.
1175
1176 2011-11-14 Eli Zaretskii <eliz@gnu.org>
1177
1178 * xdisp.c (display_line): Move the call to
1179 highlight_trailing_whitespace before the call to
1180 compute_line_metrics, since the latter needs to see the final
1181 faces of all the glyphs to compute ROW's hash value.
1182 Fixes assertion violations in row_equal_p. (Bug#10035)
1183
1184 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
1185
1186 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1187 just return (bug#10044).
1188
1189 2011-11-12 Eli Zaretskii <eliz@gnu.org>
1190
1191 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1192 with user-defined heap size. Bump the default size of the temacs
1193 heap to 27MB, to avoid memory warning when running temacs.
1194 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1195
1196 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1197 current_matrix and desired_matrix. (Bug#9990)
1198 (verify_row_hash) [XASSERTS]: New function.
1199 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1200 that the hash value of glyph rows is correct.
1201
1202 2011-11-12 Martin Rudalics <rudalics@gmx.at>
1203
1204 * window.h (window): Remove splits slot.
1205 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1206 (Fdelete_other_windows_internal, make_parent_window)
1207 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1208 (Fset_window_configuration, save_window_save): Don't deal with
1209 split status of windows.
1210 (saved_window): Remove splits slot.
1211 (Vwindow_splits): Rewrite doc-string.
1212
1213 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1214
1215 * xfns.c (unwind_create_frame):
1216 * nsfns.m (unwind_create_frame):
1217 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1218 Vframe_list (Bug#9999).
1219
1220 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1221
1222 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
1223
1224 2011-11-11 Kenichi Handa <handa@m17n.org>
1225
1226 * callproc.c (Fcall_process): Set the member dst_multibyte of
1227 process_coding.
1228
1229 2011-11-11 Johan Bockgård <bojohan@gnu.org>
1230
1231 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1232 avoid a crash (bug#9496).
1233
1234 2011-11-09 Chong Yidong <cyd@gnu.org>
1235
1236 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1237 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1238
1239 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1240
1241 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1242
1243 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1244
1245 Avoid some portability problems by eschewing 'extern inline' functions.
1246 The trivial performance wins aren't worth the portability hassles; see
1247 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1248 et seq.
1249 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1250 (window_box_width, window_box_left, window_box_left_offset)
1251 (window_box_right, window_box_right_offset): Undo previous change,
1252 by removing the "extern"s.
1253 * intervals.c (adjust_intervals_for_insertion)
1254 (adjust_intervals_for_deletion): Undo previous change,
1255 making these static again.
1256 (offset_intervals, temp_set_point_both, temp_set_point)
1257 (copy_intervals_to_string): No longer inline.
1258 * xdisp.c (window_text_bottom_y, window_box_width)
1259 (window_box_height, window_box_left_offset)
1260 (window_box_right_offset, window_box_left, window_box_right)
1261 (window_box): No longer inline.
1262
1263 2011-11-08 Chong Yidong <cyd@gnu.org>
1264
1265 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
1266 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1267 Signal an error if not a live window.
1268 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1269 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1270
1271 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
1272
1273 * lisp.h (syms_of_abbrev): Remove declaration.
1274 Reported by CHENG Gao <chenggao@royau.me>.
1275
1276 2011-11-07 Eli Zaretskii <eliz@gnu.org>
1277
1278 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1279 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1280 of temacs in GUI mode.
1281
1282 2011-11-07 Martin Rudalics <rudalics@gmx.at>
1283
1284 * window.h: Declare delete_all_child_windows instead of
1285 delete_all_subwindows.
1286 * window.c (Fwindow_nest, Fset_window_nest)
1287 (Fset_window_new_total, Fset_window_new_normal)
1288 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1289 (delete_all_subwindows): Rename to delete_all_child_windows.
1290 (Fdelete_other_windows_internal, Fset_window_configuration):
1291 Call delete_all_child_windows instead of delete_all_subwindows.
1292 * frame.c (delete_frame): Call delete_all_child_windows instead
1293 of delete_all_subwindows.
1294
1295 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1296
1297 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1298 This is also needed for porting to any host where GC_MARK_STACK is
1299 not GC_MAKE_GCPROS_NOOPS.
1300 (which_symbols): Use it.
1301
1302 2011-11-07 Kenichi Handa <handa@m17n.org>
1303
1304 * coding.c (coding_set_destination): Check coding->src_pos only
1305 when coding->src_object is a buffer (bug#9910).
1306
1307 * process.c (send_process): Set the member src_multibyte of coding
1308 to 0 (bug#9911) when sending a unibyte text.
1309
1310 * callproc.c (Fcall_process): Set the member src_multibyte of
1311 process_coding to 0 (bug#9912).
1312
1313 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1314
1315 * xmenu.c (cleanup_widget_value_tree): New function.
1316 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1317 calling free_menubar_widget_value_tree directly (Bug#9830).
1318
1319 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1320
1321 Fix some portability problems with 'inline'.
1322 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1323 (window_box_width, window_box_left, window_box_left_offset)
1324 (window_box_right, window_box_right_offset): Declare extern.
1325 Otherwise, these inline functions do not conform to C99 and
1326 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1327 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1328 * intervals.c (adjust_intervals_for_insertion)
1329 (adjust_intervals_for_deletion): Now extern, because otherwise the
1330 extern inline functions 'offset_intervals' couldn't refer to it.
1331 (static_offset_intervals): Remove.
1332 (offset_intervals): Rewrite using the old contents of
1333 static_offset_intervals. The old version didn't conform to C99
1334 because an extern inline function contained a reference to an
1335 identifier with static linkage.
1336
1337 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1338
1339 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1340 GC.
1341
1342 2011-11-06 Eli Zaretskii <eliz@gnu.org>
1343
1344 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1345 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1346 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1347 return Qleft_to_right.
1348
1349 2011-11-06 Chong Yidong <cyd@gnu.org>
1350
1351 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1352 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1353 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1354 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1355 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1356 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1357 (Fwindow_vscroll): Doc fix.
1358 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1359 argument, since it makes no sense to pass a live window and for
1360 consistency with window-child.
1361
1362 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1363
1364 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1365 support MSVC.
1366
1367 2011-11-05 Jason Rumney <jasonr@gnu.org>
1368
1369 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1370 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1371 fonts (Bug#6029).
1372 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1373 bitwise arithmetic preventing use of unicode-sip and non-truetype
1374 opentype fonts.
1375
1376 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1377
1378 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1379 "emacs"-only part.
1380
1381 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1382 initialization code to keep similarity to xfns.c after changes
1383 from 2011-11-05.
1384
1385 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1386
1387 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1388 (unwind_create_frame): New function (Bug#9943).
1389 (Fx_create_frame): Restructure code to be more similar to the one in
1390 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1391 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1392 Move terminal->reference_count++ just before making the frame official
1393 (Bug#9943).
1394
1395 * nsterm.m (x_free_frame_resources): New function.
1396 (x_destroy_window): Move code to x_free_frame_resources.
1397
1398 * xfns.c (unwind_create_frame): Fix comment.
1399 (Fx_create_frame, x_create_tip_frame):
1400 Move terminal->reference_count++ just before making the frame
1401 official. Move initialization of image_cache_refcount and
1402 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1403
1404 2011-11-05 Eli Zaretskii <eliz@gnu.org>
1405
1406 Support MSVC build with newer versions of Visual Studio.
1407 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1408 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1409 nt/gmake.defs.
1410
1411 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1412 which are not supported by MSVC.
1413 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1414 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1415 bitfields.
1416 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1417 types in bitfields.
1418 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1419
1420 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1421
1422 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
1423
1424 Support MSVC build with newer versions of Visual Studio.
1425 * w32.c: Don't include w32api.h for MSVC.
1426 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1427
1428 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1429 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1430 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1431 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1432 e_* cousins.
1433 (alloca) [_MSC_VER]: Define to _alloca.
1434
1435 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1436
1437 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1438
1439 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1440
1441 * xdisp.c (note_mouse_highlight): If either of
1442 previous/next-single-property-change returns nil, treat that as
1443 the beginning or the end of the buffer. (Bug#9955)
1444
1445 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1446
1447 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
1448 label is not null (Bug#9951).
1449 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1450 may be NULL.
1451
1452 2011-11-04 Eli Zaretskii <eliz@gnu.org>
1453
1454 * window.c (Fwindow_body_size): Mention in the doc string that the
1455 return value is in frame's canonical units. (Bug#9949)
1456
1457 2011-11-03 Eli Zaretskii <eliz@gnu.org>
1458
1459 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1460
1461 * w32fns.c (unwind_create_frame): If needed, free the glyph
1462 matrices of the partially constructed frame. (Bug#9943)
1463 * xfns.c (unwind_create_frame): Likewise.
1464
1465 2011-11-01 Eli Zaretskii <eliz@gnu.org>
1466
1467 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1468 Don't stop backward scan on the continuation glyph, even though
1469 its CHARPOS is positive.
1470 (mouse_face_from_buffer_pos, note_mouse_highlight):
1471 Rename cover_string to disp_string.
1472
1473 2011-11-01 Martin Rudalics <rudalics@gmx.at>
1474
1475 * window.c (temp_output_buffer_show): Don't use
1476 Vtemp_buffer_show_specifiers.
1477 (Vtemp_buffer_show_specifiers): Remove unused variable.
1478
1479 2011-10-30 Eli Zaretskii <eliz@gnu.org>
1480
1481 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1482 past the beginning of the current glyph matrix.
1483
1484 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
1485
1486 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1487 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1488 HAVE_GTK3 (Bug#9869).
1489
1490 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1491 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1492
1493 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1494
1495 * xterm.c: Declare x_handle_net_wm_state to return int.
1496 (handle_one_xevent): Check if we are iconified but don't have
1497 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1498 (get_current_wm_state): Return non-zero if not hidden,
1499 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1500 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1501 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1502 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1503
1504 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1505
1506 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1507 so that this new function doesn't get optimized away by a
1508 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1509
1510 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1511
1512 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1513
1514 2011-10-29 Eli Zaretskii <eliz@gnu.org>
1515
1516 Fix the `xbytecode' command.
1517 * .gdbinit (xprintbytestr): New command.
1518 (xwhichsymbols): Rename from `which'; all callers changed.
1519 (xbytecode): Print the byte-code string as well.
1520
1521 2011-10-29 Kim Storm <storm@cua.dk>
1522
1523 * alloc.c (which_symbols): New function.
1524
1525 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1526
1527 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1528 line. (Bug#9903)
1529
1530 2011-10-29 Glenn Morris <rgm@gnu.org>
1531
1532 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1533 Not clear what it was for, and it causes various bugs. (Bug#9839)
1534
1535 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1536
1537 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1538 possible random value that matches one of those tested as
1539 condition to clear the mouse face.
1540
1541 2011-10-28 Chong Yidong <cyd@gnu.org>
1542
1543 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1544
1545 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1546
1547 * window.c (make_window): Initialize phys_cursor_on_p.
1548
1549 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1550
1551 * lisp.h (struct Lisp_Symbol): Update comments.
1552
1553 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
1554
1555 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1556
1557 2011-10-28 Eli Zaretskii <eliz@gnu.org>
1558
1559 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1560 <oslsachem@gmail.com> for helping to debug this.
1561
1562 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1563 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1564 (g_b_init_get_glyph_outline_w): New static variables.
1565 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1566 (GetGlyphOutlineW_Proc): New typedefs.
1567 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
1568 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1569 New functions.
1570 (w32font_open_internal, compute_metrics):
1571 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
1572 instead of calling the "wide" APIs directly.
1573
1574 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1575
1576 * w32.h (syms_of_w32font): Add prototype.
1577
1578 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1579
1580 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1581 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1582 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1583 (Fmove_to_window_line): Doc fix.
1584
1585 2011-10-27 Chong Yidong <cyd@gnu.org>
1586
1587 * process.c (make_process): Set gnutls_state to NULL.
1588
1589 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1590 non-NULL, regardless of GNUTLS_INITSTAGE.
1591 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1592 an error. Set process slots as soon as we allocate them.
1593
1594 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1595
1596 2011-10-27 Chong Yidong <cyd@gnu.org>
1597
1598 * gnutls.c (emacs_gnutls_deinit): New function.
1599 Deallocate credentials structures as well as calling gnutls_deinit.
1600 (Fgnutls_deinit, Fgnutls_boot): Use it.
1601
1602 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1603 (deactivate_process): Call emacs_gnutls_deinit.
1604
1605 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
1606
1607 * image.c (x_create_x_image_and_pixmap):
1608 * w32.c (sys_rename, w32_delayed_load):
1609 * w32font.c (fill_in_logfont):
1610 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1611
1612 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
1613
1614 * w32fns.c (w32_default_color_map): New function,
1615 extracted from Fw32_default_color_map.
1616 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
1617
1618 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1619
1620 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1621
1622 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1623
1624 * keyboard.c (test_undefined): New function (bug#9751).
1625 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1626
1627 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1628
1629 * sysdep.c (init_sys_modes): Fix the check for the controlling
1630 terminal (Bug#6649).
1631
1632 2011-10-20 Eli Zaretskii <eliz@gnu.org>
1633
1634 * dispextern.h (struct bidi_it): New member next_en_type.
1635
1636 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1637 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1638 current character, check also for next_en_type being WEAK_EN.
1639 (bidi_resolve_weak): Don't enter the expensive loop if the current
1640 position is before next_en_pos. Record the bidi type of the first
1641 non-ET, non-BN character we find, in addition to its position.
1642 (bidi_level_of_next_char): Invalidate next_en_type when
1643 next_en_pos is over-stepped.
1644
1645 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1646
1647 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1648 * editfns.c: Rewrite current-time-zone so that it invokes
1649 the equivalent of (format-time-string "%Z") to get the time zone name.
1650 This fixes a bug when the time zone name contains characters that
1651 need converting from the system time locale to Emacs internal format.
1652 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1653 that patch fixed format-time-string to do the conversion, but
1654 I forgot to fix current-time-zone.
1655 (format_time_string): New function, containing most of
1656 what Fformat_time_string used to contain.
1657 (Fformat_time_string): Rewrite in terms of format_time_string.
1658 This doesn't change this function's behavior.
1659 (current-time-zone): Rewrite to use format_time_string.
1660 This fixes the bug reported by Michael Schierl in
1661 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1662 Jason Rumney's 2007-06-07 change worked around this bug, but
1663 didn't fix it.
1664 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1665
1666 2011-10-19 Eli Zaretskii <eliz@gnu.org>
1667
1668 * xdisp.c (start_display): If the character at POS is displayed
1669 via a display vector, reset IT->current.dpvec_index to zero.
1670 (try_window_reusing_current_matrix): If a line ends in a display
1671 vector or the next line starts in a display vector, continue
1672 redrawing the window even though the character position of
1673 start_row was reached.
1674 (Bug#9771, part 2)
1675
1676 2011-10-18 Chong Yidong <cyd@gnu.org>
1677
1678 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1679 with nobreak-char-display too.
1680
1681 2011-10-18 Eli Zaretskii <eliz@gnu.org>
1682
1683 Fix part 3 of bug#9771.
1684 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1685 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1686 non-neutral characters if the current character is a paragraph
1687 separator (a.k.a. Newline). This avoids running the same
1688 expensive loop twice, once when we consume the preceding newline
1689 and the other time when the line actually needs to be displayed.
1690 Avoid the loop when we see neutrals on the base embedding level
1691 following a character whose directionality is the same as the
1692 paragraph's. This avoids running the expensive loop when a line
1693 ends in a long sequence of neutrals, like control characters.
1694 Add assertion against STRONG_AL type. Slightly rearrange code
1695 that determines the type of a neutral given the first non-neutral
1696 that follows it.
1697 (bidi_level_of_next_char): Set next_en_pos to zero when
1698 invalidating its info.
1699
1700 2011-10-17 Eli Zaretskii <eliz@gnu.org>
1701
1702 * xdisp.c (push_display_prop): Determine whether to record string
1703 or buffer position by IT->string, not by IT->method. Allow
1704 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
1705 (move_it_vertically_backward): Don't look for character position
1706 immediately after the newline when in a continuation line.
1707 (Bug#9771, part 1)
1708
1709 2011-10-15 Martin Rudalics <rudalics@gmx.at>
1710
1711 * window.c (coordinates_in_window): Rewrite and delabelize
1712 vertical border check. (Bug#5357) (Bug#9618)
1713
1714 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1715
1716 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1717 errors in XSetWindowBorder (bug#9310).
1718
1719 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1720
1721 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1722 avoid crash when xmalloc overrun checking is enabled.
1723
1724 2011-10-13 Eli Zaretskii <eliz@gnu.org>
1725
1726 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1727 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1728 cursor motion with <left> and <right> arrow keys.
1729
1730 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1731 some callers set that themselves.
1732
1733 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1734
1735 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1736 display string and the previous row comes from the same string and
1737 is empty. (Bug#9739) (Bug#9738)
1738
1739 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1740
1741 * doc.c (get_doc_string): Encode file name (bug#9735).
1742
1743 2011-10-12 Eli Zaretskii <eliz@gnu.org>
1744
1745 * bidi.c (bidi_level_of_next_char):
1746 * xdisp.c (get_visually_first_element): Remove old incorrect
1747 comments regarding the Unicode Line Separator character.
1748
1749 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1750
1751 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1752
1753 * alloc.c (Fgc_status): Do not access beyond zombies array
1754 boundary if nzombies > MAX_ZOMBIES.
1755 * alloc.c (dump_zombies): Add missing format specifier.
1756
1757 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1758
1759 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1760 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1761
1762 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1763 Some packages use them to denote characters with modifiers.
1764
1765 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1766
1767 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1768 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1769 matching a pp-number. Rename parameter var to var1.
1770
1771 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1772
1773 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1774
1775 2011-10-08 Glenn Morris <rgm@gnu.org>
1776
1777 * callint.c (Fcall_interactively): Give a more explicit error for the
1778 'c' case with a non-character input. (Bug#8479)
1779
1780 2011-10-08 Eli Zaretskii <eliz@gnu.org>
1781
1782 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1783 lines.
1784 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1785 lines that are hscrolled on the left.
1786
1787 * dispnew.c (buffer_posn_from_coords): Account for a possible
1788 presence of header-line. (Bug#4426)
1789
1790 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1791
1792 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1793 Don't advertise functionality which we discourage or doesn't work.
1794
1795 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1796
1797 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1798 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1799 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1800 this makes Emacs dump core during garbage collection on rare
1801 occasions. sizeof is obviously inferior to offsetof here, so
1802 stick with offsetof.
1803 (GC_POINTER_ALIGNMENT): New macro.
1804 (mark_memory): Omit 3rd (offset) arg; caller changed.
1805 Don't assume EMACS_INT alignment is the same as pointer alignment.
1806
1807 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1808
1809 * keyboard.c (read_key_sequence_remapped): New var.
1810 (read_key_sequence): Compute remapping in the right buffer.
1811 (command_loop_1): Use read_key_sequence's remapping directly.
1812
1813 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1814
1815 * dired.c (file_name_completion): Don't expand file name.
1816 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1817 before checking file name handler.
1818
1819 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1820 they've been requested explicitly (bug#9591).
1821
1822 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
1823
1824 * keymap.c (Fsingle_key_description): Use make_specified_string
1825 instead of build_string to build string from push_key_description.
1826 (Bug#5193)
1827
1828 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1829
1830 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1831 This fixes a Y2038 bug on 64-bit hosts.
1832 * buffer.c (reset_buffer):
1833 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1834 (Fclear_buffer_auto_save_failure):
1835 Use 0, not -1, to represent an unset failure time, since time_t
1836 might not be signed.
1837
1838 Remove dependency on glibc malloc internals.
1839 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1840 Move back here from lisp.h, but with their new implementations.
1841 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1842 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1843 * charset.c (charset_table_init): New static var.
1844 (syms_of_charset): Use it instead of xmalloc. This removes a
1845 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1846 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1847 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1848 Move back to alloc.c.
1849 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1850 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1851
1852 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1853
1854 * nsterm.m (windowDidResize): Call x_set_window_size only when
1855 ns_in_resize is true. Otherwise set pixelwidth/height and
1856 call change_frame_size (Bug#9628).
1857
1858 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1859
1860 Port --enable-checking=all to Fedora 14 x86-64.
1861 * charset.c (syms_of_charset): Also account for glibc malloc's
1862 internal overhead when calculating the initial malloc maximum.
1863
1864 Port --enable-checking=all to Fedora 14 x86.
1865 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1866 Move to lisp.h.
1867 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1868 (overrun_check_realloc, overrun_check_free):
1869 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1870 That way, xmalloc returns a properly-aligned pointer even if
1871 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1872 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1873 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1874 into account when calculating the initial malloc maximum.
1875 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1876 Move here from alloc.c, so that charset.c can use it too.
1877 Properly align; the old code wasn't right for common 32-bit hosts
1878 when configured with --enable-checking=all.
1879 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1880 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1881
1882 2011-09-29 Eli Zaretskii <eliz@gnu.org>
1883
1884 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
1885 use EDOM.
1886
1887 2011-09-28 Eli Zaretskii <eliz@gnu.org>
1888
1889 * xdisp.c (compute_display_string_end): If there's no display
1890 string at CHARPOS, return -1.
1891
1892 * bidi.c (bidi_fetch_char): When compute_display_string_end
1893 returns a negative value, treat the character as a normal
1894 character not covered by a display string. (Bug#9624)
1895
1896 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
1897
1898 * lread.c (Fread_from_string): Fix typo in docstring.
1899
1900 2011-09-27 Eli Zaretskii <eliz@gnu.org>
1901
1902 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1903 newline, reseat the iterator instead of bidi-iterating there one
1904 character at a time. (Bug#9610)
1905 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1906 TO_CHARPOS if the bidi iterator is at base embedding level.
1907
1908 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1909
1910 * lread.c (readevalloop): Use correct code for NBSP.
1911 (read1): Likewise. (Bug#9608)
1912
1913 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
1914
1915 * dbusbind.c (Fdbus_register_signal): When service is not
1916 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1917
1918 2011-09-25 Glenn Morris <rgm@gnu.org>
1919
1920 * buffer.c (truncate-lines): Doc fix.
1921
1922 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
1923
1924 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1925 (Fset_window_next_buffers): Doc fix.
1926
1927 2011-09-24 Glenn Morris <rgm@gnu.org>
1928
1929 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1930
1931 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1932
1933 Fix minor problems found by static checking.
1934 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1935 * indent.c (Fvertical_motion): Fix == vs = typo.
1936
1937 2011-09-24 Eli Zaretskii <eliz@gnu.org>
1938
1939 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1940 Default value is now t. Doc fix.
1941
1942 * indent.c (Fvertical_motion): Compute and apply the overshoot
1943 logic when moving up, not only when moving down. Fix the
1944 confusing name and values of the it_overshoot_expected variable;
1945 logic changes accordingly. (Bug#9254) (Bug#9549)
1946
1947 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1948 CHARPOS is covered by a display string which includes newlines.
1949 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1950 is covered by a display string with embedded newlines.
1951
1952 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
1953
1954 * dbusbind.c (Fdbus_register_signal): Add match rule to
1955 Vdbus_registered_objects_table. (Bug#9581)
1956 (Fdbus_register_method, Vdbus_registered_objects_table):
1957 Fix docstring.
1958
1959 2011-09-24 Jim Meyering <meyering@redhat.com>
1960
1961 do not ignore write error for any output size
1962 The previous change was incomplete.
1963 While it makes emacs --batch detect the vast majority of stdout
1964 write failures, errors were still ignored whenever the output size is
1965 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1966 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1967 && echo FAIL: ignored write error
1968 FAIL: ignored write error
1969 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1970 && echo FAIL: ignored write error
1971 FAIL: ignored write error
1972 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1973
1974 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1975
1976 * emacs.c (Fkill_emacs): In noninteractive mode exit
1977 non-successfully if a write error occurred on stdout. (Bug#9574)
1978
1979 2011-09-21 Eli Zaretskii <eliz@gnu.org>
1980
1981 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1982 the xassert test.
1983
1984 * dispextern.h (struct it): Update the comment documenting what
1985 can it->OBJECT be.
1986
1987 2011-09-20 Eli Zaretskii <eliz@gnu.org>
1988
1989 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1990 a display string, extend search for cursor position to end of row.
1991 (find_row_edges): If the row ends in a newline from a display
1992 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1993 Handle the case of a display string with multiple newlines.
1994 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1995 non-empty line. Fixes confusing cursor motion with arrow keys at
1996 the beginning of a line that starts with whitespace.
1997
1998 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1999
2000 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2001 (bug#9493).
2002
2003 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
2004
2005 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2006 boolean (Bug#9154).
2007
2008 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2009
2010 * xdisp.c (display_line): Record maximum and minimum buffer
2011 positions even if no glyphs were produced (e.g., by a zero-width
2012 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2013 buffer positions that will be removed from the glyph row because
2014 they don't fit.
2015 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2016 column is beyond frame width: don't subtract 1 "pixel" when
2017 computing width of the stretch.
2018 (reseat_at_next_visible_line_start): Undo the change made on
2019 2011-09-17 that saved paragraph information and restored it after
2020 the call to `reseat'. (Bug#9545)
2021
2022 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2023
2024 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2025 and turn window cursor on if cleared (Bug#9415).
2026
2027 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
2028
2029 * search.c (boyer_moore): Take unibyte characters from pattern
2030 literally. (Bug#9458)
2031
2032 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2033
2034 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2035
2036 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2037
2038 Fix minor problem found by static checking.
2039 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2040 initialized, to pacify gcc -Wuninitialized.
2041
2042 * fileio.c: Report proper errno when syscall falls.
2043 (Finsert_file_contents): Save and restore errno,
2044 so that report_file_error outputs the correct diagnostic.
2045 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2046
2047 2011-09-18 Eli Zaretskii <eliz@gnu.org>
2048
2049 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2050
2051 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2052
2053 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2054 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2055
2056 2011-09-17 Eli Zaretskii <eliz@gnu.org>
2057
2058 * xdisp.c (reseat_at_next_visible_line_start): Keep information
2059 about the current paragraph and restore it after the call to reseat.
2060
2061 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2062 (bidi_find_paragraph_start): Search back for paragraph beginning
2063 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2064 (bidi_move_to_visually_next): Only trigger paragraph-related
2065 computations when the last character is a newline or at EOB, not
2066 just any NEUTRAL_B. (Bug#9470)
2067
2068 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2069 truncated lines if point is covered by a display string. (Bug#9524)
2070
2071 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2072
2073 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2074 (cons_to_x_long): New function.
2075 (lisp_data_to_selection_data): Use it. Correct the test for
2076 short-versus-long data; it was negated. Break out of vector
2077 loop, for efficiency, when a long datum is discovered.
2078
2079 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2080
2081 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2082
2083 2011-09-16 Eli Zaretskii <eliz@gnu.org>
2084
2085 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2086 GCC PR/17406) by declaring this function with external scope.
2087
2088 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2089
2090 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2091 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2092
2093 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2094
2095 * editfns.c (Fformat): Correctly handle text properties on "%%".
2096
2097 2011-09-15 Eli Zaretskii <eliz@gnu.org>
2098
2099 * xterm.c (x_draw_composite_glyph_string_foreground):
2100 * w32term.c (x_draw_composite_glyph_string_foreground):
2101 * term.c (encode_terminal_code):
2102 * composite.c (composition_update_it, get_composition_id):
2103 * xdisp.c (get_next_display_element)
2104 (fill_composite_glyph_string): Add comments about special meaning
2105 of TAB characters in a composition.
2106
2107 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2108
2109 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
2110 This occurs when processing a multibyte format.
2111 Problem reported by Wolfgang Jenker.
2112
2113 2011-09-15 Johan Bockgård <bojohan@gnu.org>
2114
2115 * xdisp.c (try_cursor_movement): Only check for exact match if
2116 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2117
2118 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2119
2120 Remove unused external symbols.
2121 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2122 * xdisp.c (calc_pixel_width_or_height): Now static.
2123 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2124 * indent.c (check_display_width):
2125 * w32term.c: Fix comment to match code.
2126 * xterm.c, xterm.h (x_catching_errors): Remove.
2127
2128 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2129
2130 * xselect.c: Use signed conversions more consistently (Bug#9498).
2131 (selection_data_to_lisp_data): Assume incoming selection data are
2132 signed integers, not unsigned. This is to be consistent with
2133 outgoing selection data, which was modified to use signed integers
2134 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2135 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2136 expects long, not unsigned long.
2137
2138 2011-09-14 Eli Zaretskii <eliz@gnu.org>
2139
2140 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2141 computation of loop end. Reported by Johan Bockgård
2142 <bojohan@gnu.org>.
2143
2144 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
2145
2146 * frame.c (Fother_visible_frames_p): Function deleted.
2147
2148 2011-09-12 Eli Zaretskii <eliz@gnu.org>
2149
2150 * indent.c (compute_motion): Process display vector front to back
2151 rather than the other way around. (Bug#2496)
2152
2153 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2154
2155 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2156
2157 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
2158
2159 * minibuf.c (Fread_from_minibuffer): Doc fix.
2160
2161 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2162
2163 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2164 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2165
2166 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2167
2168 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2169 value for non-existent files.
2170
2171 2011-09-11 Eli Zaretskii <eliz@gnu.org>
2172
2173 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2174 set its "size" to -1. This will set the modtime_size field of
2175 the corresponding buffer to -1, which is what
2176 verify-visited-file-modtime expects for files that do not exist.
2177 (Bug#9139)
2178
2179 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2180
2181 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2182 here ...
2183 * lisp.h: ... from here. push_key_description is no longer
2184 defined in keyboard.c, so its declaration should not be in
2185 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2186 logically belongs with push_key_description.
2187
2188 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2189
2190 * buffer.h: Include <sys/types.h> instead of <time.h>.
2191 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2192 Problem reported by Herbert J. Skuhra.
2193
2194 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2195
2196 * xml.c (parse_region): Make the parsing work for
2197 non-comment-starting XML files again (bug#9144).
2198
2199 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2200
2201 * image.c (gif_load): Fix calculation of bottom and right corner.
2202 (Bug#9468)
2203
2204 2011-09-10 Eli Zaretskii <eliz@gnu.org>
2205
2206 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2207 redisplay in small windows.
2208
2209 2011-09-09 Eli Zaretskii <eliz@gnu.org>
2210
2211 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2212
2213 2011-09-08 Martin Rudalics <rudalics@gmx.at>
2214
2215 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2216 Operate on live windows only.
2217
2218 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
2219
2220 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2221
2222 2011-09-07 Eli Zaretskii <eliz@gnu.org>
2223
2224 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2225 only under bidi iteration.
2226
2227 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2228
2229 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2230
2231 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2232
2233 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2234 Without this fix, the command to link temacs failed due to an
2235 undefined symbol __builtin_isnan. This is because
2236 /usr/include/iso/math_c99.h #defines isnan(x) to
2237 __builtin_isnan(x), but the bundled gcc, which identifies itself
2238 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2239 a __builtin_isnan.
2240 * floatfns.c (isnan): #undef, and then #define to a clone of
2241 what's in data.c.
2242 (Fisnan): Always define, since it's always available now.
2243 (syms_of_floatfns): Always define isnan at the Lisp level.
2244
2245 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2246
2247 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2248
2249 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2250
2251 * fileio.c: Fix bugs with large file offsets (Bug#9428).
2252 The previous code assumed that file offsets (off_t values) fit in
2253 EMACS_INT variables, which is not true on typical 32-bit hosts.
2254 The code messed up by falsely reporting buffer overflow in cases
2255 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2256 when "big" contains more than 2**29 bytes, even though this
2257 inserts just one byte and does not overflow the buffer.
2258 (Finsert_file_contents): Store file offsets as off_t
2259 values, not as EMACS_INT values. Check for overflow when
2260 converting between EMACS_INT and off_t. When checking for
2261 buffer overflow or for overlap, take the offsets into account.
2262 Don't use EMACS_INT for small values where int suffices.
2263 When checking for overlap, fix a typo: ZV was used where
2264 ZV_BYTE was intended.
2265 (Fwrite_region): Don't assume off_t fits into 'long'.
2266 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2267
2268 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
2269
2270 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2271
2272 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2273
2274 sprintf-related integer and memory overflow issues (Bug#9412).
2275
2276 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
2277 (esprintf, exprintf, evxprintf): New functions.
2278 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
2279 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
2280 (modify_event_symbol): Do not assume that the length of
2281 name_alist_or_stem is safe to alloca and fits in int.
2282 (Fexecute_extended_command): Likewise for function name and binding.
2283 (Frecursion_depth): Wrap around reliably on integer overflow.
2284 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2285 since some callers pass EMACS_INT values.
2286 (Fsingle_key_description): Don't crash if symbol name contains more
2287 than MAX_ALLOCA bytes.
2288 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2289 (get_minibuffer): Arg is now EMACS_INT, not int.
2290 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
2291 (esprintf, exprintf, evxprintf): New decls.
2292 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2293
2294 * dbusbind.c (signature_cat): New function.
2295 (xd_signature, Fdbus_register_signal):
2296 Do not overrun buffer; instead, report string overflow.
2297
2298 * dispnew.c (add_window_display_history): Don't overrun buffer.
2299 Truncate instead; this is OK since it's just a log.
2300
2301 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2302 even if the time zone offset is outlandishly large.
2303 Don't mishandle offset == INT_MIN.
2304
2305 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2306 when creating daemon; the previous buffer-overflow check was incorrect.
2307
2308 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2309 which has the guts of the old verror function.
2310
2311 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2312 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2313
2314 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2315 (font_unparse_xlfd): Don't blindly alloca long strings.
2316 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
2317 fits in int, when using sprintf. Use single snprintf to count
2318 length of string rather than counting it via multiple sprintfs;
2319 that's simpler and more reliable.
2320 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2321 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2322 sprintf, in case result does not fit in int.
2323
2324 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2325 (fontset_from_font): Print it.
2326
2327 * frame.c (tty_frame_count): Now printmax_t, not int.
2328 (make_terminal_frame, set_term_frame_name): Print it.
2329 (x_report_frame_params): In X, window IDs are unsigned long,
2330 not signed long, so print them as unsigned.
2331 (validate_x_resource_name): Check for implausibly long names,
2332 and don't assume name length fits in 'int'.
2333 (x_get_resource_string): Don't blindly alloca invocation name;
2334 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2335 not fit in int.
2336
2337 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2338 (xg_check_special_colors, xg_set_geometry):
2339 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2340
2341 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2342 Use esprintf, not sprintf, in case result does not fit in int.
2343
2344 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2345 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2346 it as a large positive number.
2347 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2348 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2349
2350 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2351 in case result does not fit in int.
2352
2353 * print.c (float_to_string): Detect width overflow more reliably.
2354 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2355 buffer overrun. Don't assume list length fits in 'int'. Treat
2356 print length of 0 as 0, not as infinity; to be consistent with other
2357 uses of print length in this function. Don't overflow print length
2358 index. Don't assume hash table size fits in 'long', or that
2359 vectorlike size fits in 'unsigned long'.
2360
2361 * process.c (make_process): Use printmax_t, not int, to format
2362 process-name gensyms.
2363
2364 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2365
2366 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2367 to avoid potential buffer overrun.
2368
2369 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2370 if X resource line is longer than 512 bytes.
2371
2372 * xfns.c (x_window): Make sprintf buffer a bit bigger
2373 to avoid potential buffer overrun.
2374
2375 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2376
2377 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2378
2379 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2380
2381 Integer overflow fixes for scrolling, etc.
2382 Without these, Emacs silently mishandles large integers sometimes.
2383 For example, "C-u 4294967297 M-x recenter" was treated as if
2384 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2385
2386 * xdisp.c (try_window_id): Check Emacs fixnum range before
2387 converting to 'int'.
2388
2389 * window.c (window_scroll_line_based, Frecenter):
2390 Check that an Emacs fixnum is in range before assigning it to 'int'.
2391 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2392 values converted from Emacs fixnums.
2393 (Frecenter): Don't wrap around a line count if it is out of 'int'
2394 range; instead, treat it as an extreme value.
2395 (Fset_window_configuration, compare_window_configurations):
2396 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2397
2398 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2399 that can exceed INT_MAX. Check that EMACS_INT value is in range
2400 before assigning it to the (possibly-narrower) index.
2401 (match_limit): Don't assume that a fixnum can fit in 'int'.
2402
2403 * print.c (print_object): Use ptrdiff_t, not int, for index that can
2404 exceed INT_MAX.
2405
2406 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
2407 (Fvertical_motion): Don't wrap around LINES values that don't fit
2408 in 'int'. Instead, treat them as extreme values. This is good
2409 enough for windows, which can't have more than INT_MAX lines anyway.
2410
2411 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2412
2413 * Require libxml/parser.h to avoid compilation warning.
2414
2415 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2416
2417 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2418 since this reportedly can destroy thread storage.
2419
2420 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
2421
2422 * syntax.c (find_defun_start): Update all cache variables if
2423 exiting early (Bug#9401).
2424
2425 2011-08-30 Eli Zaretskii <eliz@gnu.org>
2426
2427 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2428
2429 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2430 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2431 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2432
2433 * term.c (tty_append_glyph): New function.
2434 (produce_stretch_glyph): Static function and its prototype deleted.
2435
2436 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2437 Add prototypes.
2438
2439 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2440
2441 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2442 when checking :margin (Bug#9390).
2443 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
2444 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
2445 so that the name doesn't mislead. All uses changed.
2446
2447 2011-08-28 Johan Bockgård <bojohan@gnu.org>
2448
2449 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2450 set_tty_hooks.
2451
2452 2011-08-27 Eli Zaretskii <eliz@gnu.org>
2453
2454 * xdisp.c (move_it_to): Don't bail out early when reaching
2455 position beyond to_charpos, if we are scanning backwards.
2456 (move_it_vertically_backward): When DY == 0, make sure we get to
2457 the first character in the line after the newline.
2458
2459 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2460
2461 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2462 (ccl_driver): Do not generate an out-of-range pointer.
2463 (Fccl_execute_on_string): Remove unnecessary check for
2464 integer overflow, noted by Stefan Monnier in
2465 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2466 Remove a FIXME that didn't need fixing.
2467 Simplify the newly-introduced buffer reallocation code.
2468
2469 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
2470
2471 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2472
2473 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
2474
2475 Integer and memory overflow issues (Bug#9196).
2476
2477 * doc.c (get_doc_string): Rework so that
2478 get_doc_string_buffer_size is the actual buffer size, rather than
2479 being 1 less than the actual buffer size; this makes xpalloc more
2480 convenient.
2481
2482 * image.c (x_allocate_bitmap_record, cache_image):
2483 * xselect.c (Fx_register_dnd_atom):
2484 Simplify previous changes by using xpalloc.
2485
2486 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2487 since either will do and ptrdiff_t is convenient with xpalloc.
2488
2489 * charset.c (charset_table_size)
2490 (struct charset_sort_data.priority): Now ptrdiff_t.
2491 (charset_compare): Don't overflow if priorities differ greatly.
2492 (Fsort_charsets): Don't assume list length fits in int.
2493 Check for size-calculation overflow when allocating sort data.
2494 (syms_of_charset): Allocate an initial charset table that is
2495 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2496
2497 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2498
2499 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2500 The actual value is always <= INT_MAX, and leaving it unsigned made
2501 overflow checking harder.
2502
2503 * dispextern.h (struct glyph_matrix.rows_allocated)
2504 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2505 with xpalloc. The values are still always <= INT_MAX.
2506
2507 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2508
2509 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2510 (SAFE_NALLOCA): New macro.
2511
2512 * region-cache.c (struct boundary.pos, find_cache_boundary)
2513 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2514 (set_cache_region, invalidate_region_cache)
2515 (revalidate_region_cache, know_region_cache, region_cache_forward)
2516 (region_cache_backward, pp_cache):
2517 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2518 so that ptrdiff_t * can be passed to xpalloc.
2519 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2520 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2521 (pp_cache): Don't assume cache_len fits in int.
2522 * region-cache.h: Adjust extern decls to match.
2523
2524 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2525 EMACS_INT, since either will do, for xpalloc.
2526
2527 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2528 (xnmalloc, xnrealloc, xpalloc): New functions.
2529
2530 * bidi.c (bidi_shelve_header_size): New constant.
2531 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2532 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2533
2534 * bidi.c (bidi_cache_shrink):
2535 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2536 (overlay_strings):
2537 Don't update size of array until after memory allocation succeeds,
2538 because xmalloc/xrealloc may not return.
2539 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2540 now that we have proper integer overflow checking.
2541 (record_overlay_string, overlay_strings): Catch overflows when
2542 calculating size of overlay_str_buf.
2543
2544 * callproc.c (Fcall_process): Check for size overflow when
2545 calculating size of args2.
2546 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2547 Normally we prefer signed values, but sticking with ptrdiff_t would
2548 require adding more-complicated checks.
2549
2550 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2551 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2552 Redo buffer-overflow calculations to avoid integer overflow.
2553 Add a FIXME comment where memory seems to be over-allocated.
2554
2555 * character.c (Fstring): Check for size-calculation overflow.
2556
2557 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2558 unnecessary integer overflow. Check for size overflow.
2559 (encode_coding_object): Don't update size until xmalloc succeeds.
2560
2561 * composite.c (get_composition_id): Check for overflow in glyph
2562 length calculations.
2563
2564 Integer and memory overflow fixes for display code.
2565 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2566 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2567 (scrolling_window): Check for overflow in size calculations.
2568 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2569 Don't assume glyph table len fits in int.
2570 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2571 (row_table_size): Now ptrdiff_t, not int.
2572 (scrolling_window): Avoid overflow in size calculations.
2573 Don't update size until allocation succeeds.
2574 * fns.c (concat): Check for overflow in size calculations.
2575 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2576 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2577 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2578
2579 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2580 (get_doc_string): Check for size calculation overflow.
2581 Don't update size until allocation succeeds.
2582 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2583 EMACS_INT, where ptrdiff_t will do.
2584 (Fsubstitute_command_keys): Check for string overflow.
2585
2586 * editfns.c (set_time_zone_rule): Don't assume environment length
2587 fits in int.
2588 (message_length): Now ptrdiff_t, not int.
2589 (Fmessage_box): Don't update size until allocation succeeds.
2590 Don't assume message length fits in int.
2591 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2592
2593 * emacs.c (main): Do not reallocate argv, since there is a null at
2594 the end that can be overwritten, and this way there's no need to
2595 worry about size-calculation overflow.
2596 (sort_args): Check for size-calculation overflow.
2597
2598 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2599 alloc succeeds.
2600 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2601
2602 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2603 (x_set_scroll_bar_width, x_figure_window_size):
2604 Check for integer overflow.
2605 (x_set_alpha): Do not assume XINT fits in int.
2606
2607 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2608 This is for the members text_lines, text_cols, total_lines, total_cols,
2609 where the system imposes an 'int' limit.
2610
2611 * fringe.c (Fdefine_fringe_bitmap):
2612 Don't update size until alloc works.
2613
2614 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2615 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2616
2617 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2618 Check for size-calculation overflow.
2619 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2620 do, as we prefer signed integers.
2621 (id_to_widget.max_size, id_to_widget.used)
2622 (xg_store_widget_in_map, xg_remove_widget_from_map)
2623 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2624 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2625 Use and return ptrdiff_t, not int.
2626 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2627 * gtkutil.h: Change prototypes to match the above.
2628
2629 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2630 are duplicate now that they've been promoted to lisp.h.
2631 (x_allocate_bitmap_record, x_alloc_image_color)
2632 (make_image_cache, cache_image, xpm_load):
2633 Don't update size until alloc is done.
2634 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2635 (x_detect_edges):
2636 Check for size calculation overflow.
2637 (ct_colors_allocated_max): New constant.
2638 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2639 overflow.
2640
2641 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2642 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2643 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2644 Use ptrdiff_t, not int, to count maps.
2645 (read_char_minibuf_menu_prompt): Check for overflow in size
2646 calculations. Don't update size until allocation succeeds.
2647 Redo calculations to avoid overflow.
2648 * keyboard.h: Change prototypes to match the above.
2649
2650 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2651 to count maps.
2652 (current_minor_maps): Check for size calculation overflow.
2653 * keymap.h: Change prototypes to match the above.
2654
2655 * lread.c (read1, init_obarray): Don't update size until alloc done.
2656
2657 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2658 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2659
2660 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2661 Now ptrdiff_t, not int.
2662 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2663 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2664
2665 * process.c (Fnetwork_interface_list): Check for overflow
2666 in size calculation.
2667
2668 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2669
2670 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2671 overflow. Don't bother calling xmalloc when xrealloc will do.
2672
2673 * search.c (Freplace_match): Check for size calculation overflow.
2674 (Fset_match_data): Don't assume list lengths fit in 'int'.
2675
2676 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2677 for command line length. Do not attempt to address one before the
2678 beginning of an array, as that's not portable.
2679
2680 * term.c (max_frame_lines): Remove; unused.
2681 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2682 not int.
2683 (encode_terminal_code, calculate_costs): Check for size
2684 calculation overflow.
2685 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2686 table lengths and related sizes. Don't update size until alloc
2687 done. Redo calculations to avoid overflow.
2688 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2689
2690 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2691 subtracting pointers.
2692 (gobble_line): Check for overflow more carefully. Don't update size
2693 until alloc done.
2694
2695 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2696 Don't update size until alloc done.
2697 Redo size calculations to avoid overflow.
2698 Check for size calculation overflow.
2699 (main) [DEBUG]: Fix typo in invoking tparam1.
2700
2701 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2702 Use ptrdiff_t, not int, for sizes.
2703 (store_mode_line_noprop_char): Don't update size until alloc done.
2704
2705 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2706 Use ptrdiff_t, not int, for sizes.
2707 (Finternal_make_lisp_face, cache_face):
2708 Check for size calculation overflow.
2709 (cache_face): Treat size calculation overflows as if they were
2710 memory exhaustion (the usual treatment), rather than aborting.
2711
2712 * xfns.c (x_encode_text, x_set_name_internal)
2713 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2714 sizes, since they can exceed INT_MAX in size. Check for size
2715 calculation overflow.
2716
2717 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2718 (xg_select): Check for size calculation overflow.
2719 Don't update size until alloc done.
2720
2721 * xrdb.c (get_environ_db): Don't assume path length fits in int,
2722 as sprintf is limited to int lengths.
2723
2724 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2725 (X_LONG_MIN): New macros.
2726 Use them to make the following changes clearer.
2727 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2728 This change doesn't affect the value now, but it may help remind
2729 future maintainers not to raise the value too much later.
2730 (SELECTION_QUANTUM): Remove, replacing with ...
2731 (selection_quantum): ... new function, which avoids overflow.
2732 All uses changed.
2733 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2734 assumption that selection length fits in 'int'.
2735 (x_reply_selection_request, x_handle_selection_request)
2736 (x_get_window_property, receive_incremental_selection)
2737 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2738 (lisp_data_to_selection_data, clean_local_selection_data):
2739 Use ptrdiff_t, not int, to record length of selection.
2740 (x_reply_selection_request, x_get_window_property)
2741 (receive_incremental_selection, x_property_data_to_lisp):
2742 Redo calculations to avoid overflow.
2743 (x_reply_selection_request): When sending hint, ceiling it at
2744 X_LONG_MAX rather than relying on wraparound overflow to send
2745 something.
2746 (x_get_window_property, receive_incremental_selection)
2747 (lisp_data_to_selection_data, x_property_data_to_lisp):
2748 Check for size-calculation overflow.
2749 (x_get_window_property, receive_incremental_selection)
2750 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2751 Don't store size until memory allocation succeeds.
2752 (x_get_window_property): Plug memory leak on memory exhaustion.
2753 Don't double-block input; malloc is safe here. Don't assume 2**34
2754 - 4 fits in unsigned long. Add an xassert to check
2755 XGetWindowProperty overflow. Be more careful about overflow
2756 calculations, and distinguish size from memory overflow better.
2757 (receive_incremental_selection): When tracing, don't assume
2758 unsigned int is less than INT_MAX.
2759 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2760 harmful) conversions of unsigned short to int.
2761 (lisp_data_to_selection_data): Don't assume that integers
2762 in the range -65535 through -1 fit in an X unsigned short.
2763 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2764 result parameters unless successful. Rely on cons_to_unsigned
2765 to report problems with elements; the old code wasn't right anyway.
2766 (x_check_property_data): Check for int overflow; we cannot use
2767 a wider type due to X limits.
2768 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2769
2770 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
2771
2772 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2773 (x_term_init): Check for size calculation overflow.
2774 (x_color_cells): Don't store size until memory allocation succeeds.
2775 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
2776 Don't assume alloca size is less than MAX_ALLOCA.
2777 (x_term_init): Don't assume length fits in int (sprintf is limited
2778 to int size).
2779
2780 Use ptrdiff_t for composition IDs.
2781 * character.c (lisp_string_width):
2782 * composite.c (composition_table_size, n_compositions)
2783 (get_composition_id, composition_gstring_from_id):
2784 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2785 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2786 * window.c (Frecenter):
2787 Use ptrdiff_t, not int, for composition IDs.
2788 * composite.c (get_composition_id): Check for integer overflow.
2789 * composite.h: Adjust prototypes to match the above changes.
2790
2791 Use ptrdiff_t for hash table indexes.
2792 * category.c (hash_get_category_set):
2793 * ccl.c (ccl_driver):
2794 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2795 * coding.c (coding_system_charset_list, detect_coding_system):
2796 * coding.h (struct coding_system.id):
2797 * composite.c (get_composition_id, gstring_lookup_cache):
2798 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2799 * image.c (xpm_get_color_table_h):
2800 * lisp.h (hash_lookup, hash_put):
2801 * minibuf.c (Ftest_completion):
2802 Use ptrdiff_t for hash table indexes, not int (which is too
2803 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2804 32-bit --with-wide-int hosts).
2805
2806 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2807 Add a FIXME comment about memory leaks.
2808 (syms_of_charset): Don't assume xmalloc returns.
2809
2810 Don't assume that stated character widths fit in int.
2811 * character.c (Fchar_width, c_string_width, lisp_string_width):
2812 * character.h (CHAR_WIDTH):
2813 * indent.c (MULTIBYTE_BYTES_WIDTH):
2814 Use sanitize_char_width to avoid undefined and/or bad behavior
2815 with outlandish widths.
2816 * character.h (sanitize_tab_width): Rename from sanitize_width,
2817 now that we have two such functions. All uses changed.
2818 (sanitize_char_width): New inline function.
2819
2820 Don't assume that tab-width fits in int.
2821 * character.h (sanitize_width): New inline function.
2822 (SANE_TAB_WIDTH): New macro.
2823 (ASCII_CHAR_WIDTH): Use it.
2824 * indent.c (sane_tab_width): Remove. All uses replaced by
2825 SANE_TAB_WIDTH (current_buffer).
2826 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2827
2828 * fileio.c: Integer overflow issues with file modes.
2829 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2830
2831 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2832 Remove unreachable code.
2833 (read_hex, load_charset_map_from_file): Check for integer overflow.
2834
2835 * xterm.c: Don't go over XClientMessageEvent limit.
2836 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2837 (x_send_scroll_bar_event): Likewise. Check that the size does not
2838 exceed limits imposed by XClientMessageEvent, as well as the usual
2839 ptrdiff_t and size_t limits.
2840
2841 * keyboard.c: Overflow, signedness and related fixes.
2842 (make_lispy_movement): Use same integer type in forward decl
2843 that is used in the definition.
2844 (read_key_sequence, keyremap_step):
2845 Change bufsize argument back to int, undoing my 2011-03-30 change.
2846 We prefer signed types, and int is wide enough here.
2847 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2848 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2849 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2850 length, not size_t. Use ptrdiff_t for index, not int.
2851 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2852 possibility of integer overflow.
2853
2854 Overflow, signedness and related fixes for images.
2855
2856 * dispextern.h (struct it.stack[0].u.image.image_id)
2857 (struct_it.image_id, struct image.id, struct image_cache.size)
2858 (struct image_cache.used, struct image_cache.ref_count):
2859 * gtkutil.c (update_frame_tool_bar):
2860 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2861 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2862 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2863 * nsmenu.m (update_frame_tool_bar):
2864 * xdisp.c (calc_pixel_width_or_height):
2865 * xfns.c (image_cache_refcount):
2866 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2867 on typical 64-bit hosts.
2868
2869 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2870 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2871 Omit unnecessary casts to int.
2872 (parse_image_spec): Check that integers fall into 'int' range
2873 when the callers expect that.
2874 (image_ascent): Redo ascent calculation to avoid int overflow.
2875 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2876 (lookup_image): Remove unnecessary tests.
2877 (xbm_image_p): Locals are now of int, not EMACS_INT,
2878 since parse_image_check makes sure they fit into int.
2879 (png_load, gif_load, svg_load_image):
2880 Prefer int to unsigned where either will do.
2881 (tiff_handler): New function, combining the cores of the
2882 old tiff_error_handler and tiff_warning_handler.
2883 This function is rewritten to use vsnprintf and thereby avoid
2884 stack buffer overflows. It uses only the features of vsnprintf
2885 that are common to both POSIX and native Microsoft.
2886 (tiff_error_handler, tiff_warning_handler): Use it.
2887 (tiff_load, gif_load, imagemagick_load_image):
2888 Don't assume :index value fits in 'int'.
2889 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2890 (imagemagick_load_image): Check that crop parameters fit into
2891 the integer types that MagickCropImage accepts. Don't assume
2892 Vimagemagick_render_type has a nonnegative value. Don't assume
2893 size_t fits in 'long'.
2894 (gs_load): Use printmax_t to print the widest integers possible.
2895 Check for integer overflow when computing image height and width.
2896
2897 2011-08-26 Eli Zaretskii <eliz@gnu.org>
2898
2899 * xdisp.c (redisplay_window): Don't force window start if point
2900 will be invisible in the resulting window. (Bug#9324)
2901
2902 2011-08-25 Eli Zaretskii <eliz@gnu.org>
2903
2904 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2905 the display spec is of the form `(space ...)'.
2906 (handle_display_spec): Return the value returned by
2907 handle_single_display_spec, not just 1 or zero.
2908 (handle_single_display_spec): If the display spec is of the form
2909 `(space ...)', and specifies display in the text area, return 2
2910 rather than 1.
2911 (try_cursor_movement): Check for the need to scroll more
2912 accurately, and prefer exact match for point under bidi.
2913 Don't advance `row' beyond the last row of the window.
2914
2915 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2916 into disp_prop; all users changed.
2917
2918 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2919 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2920 for the text covered by the display property.
2921
2922 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
2923
2924 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2925 Change return value to nil.
2926 (Frecord_buffer): Delete unused function.
2927
2928 2011-08-24 Eli Zaretskii <eliz@gnu.org>
2929
2930 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2931 buffers, return left-to-right.
2932 (set_cursor_from_row): Consider candidate row a win if its glyph
2933 represents a newline and point is on that newline. Fixes cursor
2934 positioning on the newline at EOL of R2L text within L2R
2935 paragraph, and vice versa.
2936 (try_cursor_movement): Check continued rows, in addition to
2937 continuation rows. Fixes unwarranted scroll when point enters a
2938 continued line of R2L text within an L2R paragraph, or vice versa.
2939 (cursor_row_p): Consider the case of point being equal to
2940 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2941 from the end of a short line to the beginning of a continued line
2942 of R2L text within L2R paragraph.
2943 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2944 composed characters.
2945
2946 * bidi.c (bidi_check_type): Use xassert.
2947 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2948 members.
2949
2950 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2951
2952 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2953 a character.
2954
2955 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
2956
2957 * nsfont.m (ns_otf_to_script): Fix typo.
2958
2959 2011-08-22 Kenichi Handa <handa@m17n.org>
2960
2961 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2962 extra slot even if the purpose is char-code-property-table.
2963
2964 2011-08-23 Eli Zaretskii <eliz@gnu.org>
2965
2966 * xdisp.c (redisplay_window): When computing centering_position,
2967 account for the height of the header line. (Bug#8874)
2968
2969 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2970 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2971 candidate is selected by the mouse, and that candidate has a
2972 composed character under the mouse.
2973
2974 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2975 coordinates reported by pos-visible-in-window-p for a composed
2976 character in column zero.
2977
2978 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2979
2980 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2981
2982 2011-08-22 Eli Zaretskii <eliz@gnu.org>
2983
2984 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2985 consider it a hit if to_charpos is anywhere in the range of the
2986 composed buffer positions.
2987
2988 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
2989
2990 * image.c (gif_load): Don't assume that each subimage has the same
2991 dimensions as the base image. Handle disposal method that is
2992 "undefined" by the gif spec (Bug#9335).
2993
2994 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
2995
2996 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
2997 (Fcondition_case): Document `debug' symbol in error handler.
2998
2999 2011-08-19 Eli Zaretskii <eliz@gnu.org>
3000
3001 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3002 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3003 from an Org mode buffer to a Speedbar frame.
3004
3005 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3006 a composition, take its buffer position from IT->cmp_it.charpos.
3007 Fixes cursor positioning at the beginning of a line that begins
3008 with a composed character.
3009
3010 2011-08-18 Eli Zaretskii <eliz@gnu.org>
3011
3012 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3013 character bidirectional type, use STRONG_L instead. Fixes crashes
3014 in a buffer produced by `describe-categories'.
3015
3016 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3017 members before the level stack, so they would be saved and
3018 restored when copying iterator state. Fixes incorrect reordering
3019 around TABs covered by display properties.
3020
3021 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3022
3023 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
3024
3025 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
3026
3027 * eval.c (internal_condition_case, internal_condition_case_1)
3028 (internal_condition_case_2, internal_condition_case_n):
3029 Remove unnecessary aborts (Bug#9081).
3030
3031 2011-08-17 Eli Zaretskii <eliz@gnu.org>
3032
3033 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3034 has no `load' handler, try opening the file locally. (Bug#9311)
3035
3036 2011-08-16 Ken Brown <kbrown@cornell.edu>
3037
3038 * gmalloc.c: Expand comment.
3039
3040 2011-08-16 Eli Zaretskii <eliz@gnu.org>
3041
3042 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3043 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3044
3045 2011-08-16 Ken Brown <kbrown@cornell.edu>
3046
3047 Fix memory allocation problems in Cygwin build (Bug#9273).
3048
3049 * unexcw.c ( __malloc_initialized): Declare external variable.
3050 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3051
3052 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3053 New variables.
3054 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3055 dumped emacs.
3056 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3057 in the static heap.
3058 [CYGWIN] (special_realloc): New function.
3059 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3060 requests to realloc storage in the static heap.
3061
3062 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3063
3064 * bidi.c (bidi_initialize): Remove unused local.
3065
3066 2011-08-15 Eli Zaretskii <eliz@gnu.org>
3067
3068 * bidimirror.h:
3069 * biditype.h: Remove file.
3070 * makefile.w32-in ($(BLD)/bidi.$(O)):
3071 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
3072
3073 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3074
3075 * chartab.c: Improve commentary for the uniprop_table API.
3076
3077 * bidi.c (bidi_paragraph_init): Support zero value of
3078 bidi_ignore_explicit_marks_for_paragraph_level.
3079 (bidi_initialize): Use uniprop_table instead of including
3080 biditype.h and bidimirror.h.
3081
3082 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3083 coordinates of the iterator when restoring from ppos_it.
3084 (Bug#9296)
3085
3086 2011-08-14 Kenichi Handa <handa@m17n.org>
3087
3088 * process.c (create_process): Call setup_process_coding_systems
3089 after the pid of the process is set to -1 (Bug#8162).
3090
3091 2011-08-14 Eli Zaretskii <eliz@gnu.org>
3092
3093 * xdisp.c (move_it_in_display_line_to): Don't invoke
3094 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3095 ppos_it. Fixes vertical cursor motion when line beginning is
3096 covered by an image. (Bug#9296)
3097
3098 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3099
3100 * nsterm.h (ns_run_ascript): Declare.
3101 (NSAPP_DATA2_RUNASSCRIPT): Define.
3102
3103 * nsfns.m (as_script, as_result, as_status): New static variables.
3104 (ns_run_ascript): New function.
3105 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
3106 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3107 the event loop. Get status from as_status (Bug#7276).
3108
3109 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3110 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3111 the event loop (Bug#7276).
3112
3113 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3114
3115 * gnutls.c (QCgnutls_bootprop_priority)
3116 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3117 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3118 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3119 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3120 (QCgnutls_bootprop_verify_hostname_error)
3121 (QCgnutls_bootprop_callbacks_verify): Rename from
3122 Qgnutls_bootprop_..., all uses changed.
3123
3124 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3125 uses changed.
3126
3127 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3128
3129 * xfaces.c (Qframe_set_background_mode): Now static.
3130 * dispextern.h (Qframe_set_background_mode): Remove decl.
3131
3132 * process.c (Fnetwork_interface_info): Declare local only if needed.
3133
3134 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3135
3136 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3137 (Fnetwork_interface_list): Allocate in increments of bytes instead
3138 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3139 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3140 sockaddr.
3141 (struct ifflag_def): notrailers is smart on OSX.
3142 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3143 Get hardware address with getifaddrs if available.
3144
3145 2011-08-12 Eli Zaretskii <eliz@gnu.org>
3146
3147 * xdisp.c (iterate_out_of_display_property): xassert that
3148 IT->position is set to within IT->object's boundaries. Break from
3149 the loop as soon as EOB is reached; avoids infloops in redisplay
3150 when IT->position is set up wrongly due to some bug.
3151 Set IT->current to match the bidi iterator unconditionally.
3152 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3153 entry. Force push_it to save on the stack the current
3154 buffer/string position, to be restored by pop_it. Fix flags in
3155 the iterator structure wrt the object coming from a display
3156 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3157 properties. (Bug#9284)
3158
3159 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
3160
3161 * fontset.c (fontset_get_font_group): Add proper type checks.
3162 (Bug#9172)
3163
3164 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3165
3166 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3167 and LC_VERSION_MIN_MACOSX.
3168 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3169 (dump_it) [LC_FUNCTION_STARTS]: Use it.
3170
3171 2011-08-08 Eli Zaretskii <eliz@gnu.org>
3172
3173 * xdisp.c (forward_to_next_line_start): Allow to use the
3174 no-display-properties-and-no-overlays under bidi display.
3175 Set disp_pos in the bidi iterator to avoid searches for display
3176 properties and overlays.
3177
3178 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
3179
3180 * editfns.c (Fset_time_zone_rule): Document relationship with the
3181 setenv function.
3182
3183 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3184 the font entity extracted from the cache (Bug#8109).
3185
3186 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
3187
3188 * composite.c (autocmp_chars): Don't reset point. That is done by
3189 restore_point_unwind (Bug#5984).
3190
3191 2011-08-07 Juri Linkov <juri@jurta.org>
3192
3193 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3194 to show the arg `TIME' instead of `TIMEVAL'.
3195
3196 2011-08-06 Eli Zaretskii <eliz@gnu.org>
3197
3198 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3199 display property strides EOL and includes a newline, as in
3200 longlines-mode. (Bug#9254)
3201 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3202 word-wrap under bidirectional display. (Bug#9224)
3203
3204 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3205 is non-zero, even if the data buffer is NULL. Fixes a crash in
3206 vertical-motion with longlines-mode. (Bug#9254)
3207
3208 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3209
3210 * bidi.c <bidi_cache_total_alloc>: Now static.
3211 (bidi_initialize): Initialize bidi_cache_total_alloc.
3212
3213 * xdisp.c (display_line): Release buffer allocated for shelved bidi
3214 cache. (Bug#9221)
3215
3216 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3217 amount allocated this far in `bidi_cache_total_alloc'.
3218 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3219 non-zero, only free the data buffer without restoring the cache
3220 contents. All callers changed.
3221
3222 * dispextern.h (bidi_unshelve_cache): Update prototype.
3223
3224 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3225 (move_it_in_display_line, move_it_to)
3226 (move_it_vertically_backward, move_it_by_lines): Replace the call
3227 to xfree to an equivalent call to bidi_unshelve_cache.
3228 (move_it_in_display_line_to): Fix logic of returning
3229 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
3230
3231 2011-08-05 Eli Zaretskii <eliz@gnu.org>
3232
3233 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3234 came from a string character with a `cursor' property. (Bug#9229)
3235
3236 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3237
3238 * Makefile.in (LIB_PTHREAD): New variable.
3239 (LIBES): Add LIB_PTHREAD (Bug#9216).
3240
3241 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3242 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3243
3244 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3245
3246 * regex.c (re_iswctype): Remove some redundant boolean conversions.
3247
3248 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3249
3250 * xterm.c (x_find_topmost_parent): New function.
3251 (x_set_frame_alpha): Find topmost parent window with
3252 x_find_topmost_parent and set the property there also (bug#9181).
3253 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3254
3255 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3256
3257 * callproc.c (Fcall_process): Avoid vfork clobbering
3258 the local vars buffer, coding_systems, current_dir.
3259
3260 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3261
3262 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3263
3264 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3265
3266 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3267 so that it is not optimized away.
3268
3269 * xdisp.c (compute_display_string_pos): Remove unused local.
3270
3271 2011-08-02 Eli Zaretskii <eliz@gnu.org>
3272
3273 Fix slow cursor motion and scrolling in large buffers with
3274 selective display, like Org Mode buffers. (Bug#9218)
3275
3276 * dispextern.h (struct bidi_it): New member disp_prop_p.
3277
3278 * xdisp.c: Remove one-slot cache of display string positions.
3279 (compute_display_string_pos): Accept an additional argument
3280 DISP_PROP_P; callers changed. Scan at most 5K characters forward
3281 for a display string or property. If found, set DISP_PROP_P
3282 non-zero.
3283
3284 * bidi.c (bidi_fetch_char): Accept an additional argument
3285 DISP_PROP_P, and pass it to compute_display_string_pos.
3286 Only handle text covered by a display string if DISP_PROP_P is returned
3287 non-zero. All callers of bidi_fetch_char changed.
3288
3289 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3290
3291 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3292
3293 2010-12-03 Don March <don@ohspite.net>
3294
3295 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3296 last character M-[char] is translated to ESC [char] (bug#7541).
3297
3298 2011-08-02 Kenichi Handa <handa@m17n.org>
3299
3300 * lisp.h (uniprop_table): Extern it.
3301
3302 * chartab.c (uniprop_table): Make it non-static.
3303
3304 2011-08-01 Eli Zaretskii <eliz@gnu.org>
3305
3306 * xdisp.c (forward_to_next_line_start): Accept additional argument
3307 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3308 on the newline.
3309 (reseat_at_next_visible_line_start): Use the bidi iterator state
3310 returned by forward_to_next_line_start to restore the state of
3311 it->bidi_it after backing up to previous newline. (Bug#9212)
3312
3313 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3314
3315 * regex.c (re_comp): Protoize.
3316 (re_exec): Fix return type.
3317 (regexec): Fix type of `ret'. (Bug#9203)
3318
3319 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3320
3321 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3322 This is needed if max-image-size is a floating-point number.
3323
3324 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3325
3326 * print.c (print_object): Print empty symbol as ##.
3327
3328 * lread.c (read1): Read ## as empty symbol.
3329
3330 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3331
3332 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3333 setting frame foreground color (Bug#9175).
3334 (x_set_background_color): Likewise.
3335
3336 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3337 contents (Bug#9176).
3338 (EmacsTooltip -init): Remove bezels and add shadows to
3339 tooltip windows.
3340
3341 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3342 or scroll bar (Bug#8470).
3343
3344 * nsfont.m (nsfont_open): Remove assignment to voffset and
3345 unnecessary vars hshink, expand, hd, full_height, min_height.
3346 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3347
3348 * nsterm.h (nsfont_info): Remove voffset field.
3349
3350 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3351
3352 Implement strike-through and overline on NextStep (Bug#8863).
3353
3354 * nsfont.m (nsfont_open): Use underline position provided by font,
3355 instead of hard-coded value of 2.
3356 (nsfont_draw): Call ns_draw_text_decoration instead.
3357
3358 * nsterm.h: Add declaration for ns_draw_text_decoration.
3359
3360 * nsterm.m (ns_draw_text_decoration): New function for drawing
3361 underline, overline, and strike-through.
3362 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3363 ns_draw_text_decoration. Change treatment of cursor drawing to
3364 accommodate underlining, etc.
3365
3366 2011-07-28 Eli Zaretskii <eliz@gnu.org>
3367
3368 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3369 default.
3370
3371 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3372
3373 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3374 Without this fix, if a signal arrives just after memory fills up,
3375 'malloc' might be invoked reentrantly.
3376
3377 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3378 In other words, assume that every image size is allowed, on non-X
3379 hosts. This assumption is probably wrong, but it lets Emacs compile.
3380
3381 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3382
3383 * regex.c (re_iswctype): Convert return values to boolean.
3384
3385 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3386
3387 * xdisp.c (compute_display_string_pos): Don't use cached display
3388 string position if the buffer had its restriction changed.
3389 (Bug#9184)
3390
3391 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3392
3393 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3394
3395 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3396
3397 Integer signedness and overflow and related fixes. (Bug#9079)
3398
3399 * bidi.c: Integer size and overflow fixes.
3400 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3401 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3402 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3403 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3404 (bidi_find_other_level_edge):
3405 Use ptrdiff_t instead of EMACS_INT where either will do.
3406 This works better on 32-bit hosts configured --with-wide-int.
3407 (bidi_cache_ensure_space): Check for size-calculation overflow.
3408 Use % rather than repeated addition, for better worst-case speed.
3409 Don't set bidi_cache_size until after xrealloc returns, because it
3410 might not return.
3411 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
3412 (bidi_cache_ensure_space): Also check that the bidi cache size
3413 does not exceed that of the largest Lisp string or buffer. See Eli
3414 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
3415
3416 * alloc.c (__malloc_size_t): Remove.
3417 All uses replaced by size_t. See Andreas Schwab's note
3418 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3419
3420 * image.c: Improve checking for integer overflow.
3421 (check_image_size): Assume that f is nonnull, since
3422 it is always nonnull in practice. This is one less thing to
3423 worry about when checking for integer overflow later.
3424 (x_check_image_size): New function, which checks for integer
3425 overflow issues inside X.
3426 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3427 This removes the need for a memory_full check.
3428 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3429 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3430 (xbm_read_bitmap_data): Change locals back to 'int', since
3431 their values must fit in 'int'.
3432 (xpm_load_image, png_load, tiff_load):
3433 Invoke x_create_x_image_and_pixmap earlier,
3434 to avoid much needless work if the image is too large.
3435 (tiff_load): Treat overly large images as if
3436 x_create_x_image_and_pixmap failed, not as malloc failures.
3437 (gs_load): Use x_check_image_size.
3438
3439 * gtkutil.c: Omit integer casts.
3440 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3441 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3442
3443 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3444
3445 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3446 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3447 would wrongly return t on a 64-bit host.
3448
3449 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3450 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3451 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3452 and therefore cause GCC to emit a bogus diagnostic in some cases.
3453
3454 * image.c: Integer signedness and overflow and related fixes.
3455 This is not an exhaustive set of fixes, but it's time to
3456 record what I've got.
3457 (lookup_pixel_color, check_image_size): Remove redundant decls.
3458 (check_image_size): Don't assume that arbitrary EMACS_INT values
3459 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3460 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3461 (tiff_load, imagemagick_load_image):
3462 Check for overflow in size calculations.
3463 (x_create_x_image_and_pixmap): Remove unnecessary test for
3464 xmalloc returning NULL; that can't happen.
3465 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3466 (xpm_color_bucket): Use better integer hashing function.
3467 (xpm_cache_color): Don't possibly over-allocate memory.
3468 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3469 (gif_memory_source):
3470 Use ptrdiff_t, not int or size_t, to record sizes.
3471 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3472 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3473 either works, as we prefer signed integers.
3474 (tiff_read_from_memory, tiff_write_from_memory):
3475 Return tsize_t, not size_t, since that's what the TIFF API wants.
3476 (tiff_read_from_memory): Don't fail simply because the read would
3477 go past EOF; instead, return a short read.
3478 (tiff_load): Omit no-longer-needed casts.
3479 (Fimagemagick_types): Don't assume size fits into 'int'.
3480
3481 Improve hashing quality when configured --with-wide-int.
3482 * fns.c (hash_string): New function, taken from sxhash_string.
3483 Do not discard information about ASCII character case; this
3484 discarding is no longer needed.
3485 (sxhash-string): Use it. Change sig to match it. Caller changed.
3486 * lisp.h: Declare it.
3487 * lread.c (hash_string): Remove, since we now use fns.c's version.
3488 The fns.c version returns a wider integer if --with-wide-int is
3489 specified, so this should help the quality of the hashing a bit.
3490
3491 * emacs.c: Integer overflow minor fix.
3492 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3493 Define only if GNU_LINUX.
3494 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3495
3496 * dispnew.c: Integer signedness and overflow fixes.
3497 Remove unnecessary forward decls, that were a maintenance hassle.
3498 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3499 All uses changed.
3500 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3501 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3502 (prepare_desired_row, line_draw_cost):
3503 Use int, not unsigned, where either works.
3504 (save_current_matrix, restore_current_matrix):
3505 Use ptrdiff_t, not size_t, where either works.
3506 (init_display): Check for overflow more accurately, and without
3507 relying on undefined behavior.
3508
3509 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3510 Remove, replacing with the new symbols in lisp.h. All uses changed.
3511 * fileio.c (make_temp_name):
3512 * filelock.c (lock_file_1, lock_file):
3513 * xdisp.c (message_dolog):
3514 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3515 Use pMd etc. instead.
3516 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3517 replacing the pWIDE etc. symbols removed from editfns.c.
3518
3519 * keyboard.h (num_input_events): Now uintmax_t.
3520 This is (very slightly) less likely to mess up due to wraparound.
3521 All uses changed.
3522
3523 * buffer.c: Integer signedness fixes.
3524 (alloc_buffer_text, enlarge_buffer_text):
3525 Use ptrdiff_t rather than size_t when either will do, as we prefer
3526 signed integers.
3527
3528 * alloc.c: Integer signedness and overflow fixes.
3529 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3530 (__malloc_size_t): Default to size_t, not to int.
3531 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3532 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3533 Prefer ptrdiff_t to size_t when either would do, as we prefer
3534 signed integers.
3535 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3536 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3537 Now const. Initialize with values that are in range even if char
3538 is signed.
3539 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3540 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3541 These functions do the right thing with sizes > 2**32.
3542 (check_depth): Now ptrdiff_t, not int.
3543 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3544 Adjust to new way of storing sizes. Check for size overflow bugs
3545 in rest of code.
3546 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3547 slightly wrong anyway, as it missed one instance of
3548 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3549 (refill_memory_reserve): Omit needless cast to size_t.
3550 (mark_object_loop_halt): Mark as externally visible.
3551
3552 * xselect.c: Integer signedness and overflow fixes.
3553 (Fx_register_dnd_atom, x_handle_dnd_message):
3554 Use ptrdiff_t, not size_t, since we prefer signed.
3555 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3556 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3557 x_dnd_atoms_size and x_dnd_atoms_length.
3558
3559 * doprnt.c: Prefer signed to unsigned when either works.
3560 * eval.c (verror):
3561 * doprnt.c (doprnt):
3562 * lisp.h (doprnt):
3563 * xdisp.c (vmessage):
3564 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3565 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3566 prefer signed arithmetic to avoid comparison confusion.
3567 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3568 but is a bit tricky.
3569
3570 Assume freestanding C89 headers, string.h, stdlib.h.
3571 * data.c, doprnt.c, floatfns.c, print.c:
3572 Include float.h unconditionally.
3573 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3574 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3575 * regex.c: Likewise for stddef.h, string.h.
3576 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3577 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3578 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3579 (STDC_HEADERS): Remove obsolete defines.
3580 * sysdep.c: Include limits.h unconditionally.
3581
3582 Assume support for memcmp, memcpy, memmove, memset.
3583 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3584 * regex.c (memcmp, memcpy):
3585 Remove; we assume C89 now.
3586
3587 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3588 (__malloc_safe_bcopy): Remove; no longer needed.
3589
3590 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
3591 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3592 well either way, and we prefer signed to unsigned.
3593
3594 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3595
3596 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3597 closes the connection while we're reading (bug#9182).
3598
3599 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
3600
3601 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3602 are specified (Bug#9168).
3603
3604 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3605
3606 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3607 Found by GCC static checking and --with-wide-int on a 32-bit host.
3608
3609 2011-07-25 Eli Zaretskii <eliz@gnu.org>
3610
3611 * xdisp.c (compute_display_string_pos): Fix logic of caching
3612 previous display string position. Initialize cached_prev_pos to
3613 -1. Fixes slow-down at the beginning of a buffer.
3614
3615 2011-07-24 Eli Zaretskii <eliz@gnu.org>
3616
3617 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3618 for attrs[LFACE_FONTSET_INDEX].
3619
3620 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3621
3622 * xml.c (parse_region): Remove unused local
3623 that was recently introduced.
3624
3625 2011-07-23 Eli Zaretskii <eliz@gnu.org>
3626
3627 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3628 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3629
3630 * xdisp.c (move_it_in_display_line_to): Record the best matching
3631 position for TO_CHARPOS while scanning the line, and restore it on
3632 exit if none of the characters scanned was an exact match.
3633 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
3634 when exact match is impossible due to invisible text, and the
3635 lines are truncated.
3636
3637 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3638
3639 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3640 for OSX >= 10.7.
3641
3642 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3643
3644 Fix a significant slow-down of cursor motion with C-n, C-p,
3645 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3646 auto-repeat under bidi redisplay in fontified buffers.
3647 * xdisp.c (compute_stop_pos_backwards): New function.
3648 (next_element_from_buffer): Call compute_stop_pos_backwards to
3649 find a suitable prev_stop when we find ourselves before
3650 base_level_stop.
3651 (reseat): Don't look for prev_stop, as that could mean a very long
3652 run.
3653 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3654 <cached_disp_overlay_modiff>: Cache for last found display string
3655 position.
3656 (compute_display_string_pos): Return the cached position if asked
3657 about the same buffer in the same area of character positions, and
3658 the buffer wasn't changed since the time the display string
3659 position was cached.
3660
3661 2011-07-22 Eli Zaretskii <eliz@gnu.org>
3662
3663 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3664 is an integer, which is important for empty lines. (Bug#9149)
3665
3666 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
3667
3668 * frame.c (Fmodify_frame_parameters): In tty case, update the
3669 default face if necessary (Bug#4238).
3670
3671 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
3672
3673 * editfns.c (Fstring_to_char): No need to explain what a character
3674 is in the docstring (Bug#6576).
3675
3676 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3677
3678 * xml.c (parse_region): Make sure we always return a tree.
3679
3680 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3681
3682 * xml.c (parse_region): If a document contains only comments,
3683 return that, too.
3684
3685 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3686
3687 * xml.c (make_dom): Return comments, too.
3688
3689 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3690
3691 Port to OpenBSD.
3692 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3693 and the surrounding thread.
3694 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3695 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3696 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3697 timer goes off.
3698 * s/openbsd.h (BROKEN_SIGIO): Define.
3699 * unexelf.c (unexec) [__OpenBSD__]:
3700 Don't update the .mdebug section of the Alpha COFF symbol table.
3701
3702 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3703
3704 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3705 (bug#8460).
3706
3707 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3708
3709 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3710 This fixes some race conditions on the permissions of any newly
3711 created file.
3712
3713 * alloc.c (valid_pointer_p): Use pipe, not open.
3714 This fixes some permissions issues when debugging.
3715
3716 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3717 If fchown fails to set both uid and gid, try to set just gid,
3718 as that is sometimes allowed. Adjust the file's mode to eliminate
3719 setuid or setgid bits that are inappropriate if fchown fails.
3720
3721 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3722
3723 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3724 to compare Lisp_Objects.
3725 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3726 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3727 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3728
3729 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3730
3731 * lread.c (read_integer): Unread even EOF character.
3732 (read1): Likewise. Properly record start position of symbol.
3733
3734 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3735 symbol character follows.
3736
3737 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3738
3739 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3740 This works around a problem with the previous change to Fcopy_file.
3741 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3742 and without this change, GCC might complain about discarding
3743 fchown's return value.
3744
3745 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
3746
3747 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3748
3749 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3750
3751 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3752
3753 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3754
3755 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3756 it's used from the C level.
3757
3758 * process.c: Use the same condition for POLL_FOR_INPUT in both
3759 keyboard.c and process.c (bug#1858).
3760
3761 2011-07-09 Lawrence Mitchell <wence@gmx.li>
3762
3763 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3764 (Fgnutls_boot): Use it.
3765
3766 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3767
3768 * doc.c (Fsubstitute_command_keys): Revert last change.
3769
3770 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3771
3772 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3773 quotes the next character, and doesn't affect other longer
3774 sequences (bug#8935).
3775
3776 * lread.c (syms_of_lread): Clarify that is isn't only
3777 `eval-buffer' and `eval-defun' that's affected by
3778 `lexical-binding' (bug#8460).
3779
3780 2011-07-15 Eli Zaretskii <eliz@gnu.org>
3781
3782 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
3783 bidi redisplay when a line includes both an image and is truncated.
3784
3785 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3786
3787 Fix minor problems found by static checking.
3788 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3789 (elsz): Now a signed constant, not a size_t var. We prefer signed
3790 types to unsigned, to avoid integer comparison confusion. Without
3791 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3792 "cannot optimize loop, the loop counter may overflow", a symptom
3793 of the confusion.
3794 * indent.c (Fvertical_motion): Mark locals as initialized.
3795 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3796
3797 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3798
3799 * search.c (Fre_search_backward): Mention `case-fold-search' in
3800 all the re_search_* functions (bug#8138).
3801
3802 * keyboard.c (Fopen_dribble_file): Document when the file is
3803 closed (bug#8056).
3804
3805 2011-07-14 Eli Zaretskii <eliz@gnu.org>
3806
3807 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3808 bidi_cache_idx.
3809
3810 Support bidi reordering of display and overlay strings.
3811 * xdisp.c (compute_display_string_pos)
3812 (compute_display_string_end): Accept additional argument STRING.
3813 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3814 (reseat_to_string): Initialize bidi_it->string.s and
3815 bidi_it->string.schars.
3816 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
3817 NULL (avoids a crash in bidi_paragraph_init).
3818 Initialize itb.string.lstring.
3819 (init_iterator): Call bidi_init_it only of a valid
3820 buffer position was specified. Initialize paragraph_embedding to
3821 L2R.
3822 (reseat_to_string): Initialize the bidi iterator.
3823 (display_string): If we need to ignore text properties of
3824 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3825 original value of -1 will not work with bidi.)
3826 (compute_display_string_pos): First arg is now struct
3827 `text_pos *'; all callers changed. Support display properties on
3828 Lisp strings.
3829 (compute_display_string_end): Support display properties on Lisp
3830 strings.
3831 (init_iterator, reseat_1, reseat_to_string): Initialize the
3832 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3833 when iterating on a string not from display properties).
3834 (compute_display_string_pos, compute_display_string_end):
3835 Fix calculation of the object to scan. Fixes an error when using
3836 arrow keys.
3837 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
3838 base_level_stop; instead, set base_level_stop to BEGV.
3839 Fixes crashes in vertical-motion.
3840 (next_element_from_buffer): Improve commentary for when
3841 the iterator is before prev_stop.
3842 (init_iterator): Initialize bidi_p from the default value of
3843 bidi-display-reordering, not from buffer-local value. Use the
3844 buffer-local value only if initializing for buffer iteration.
3845 (handle_invisible_prop): Support invisible properties on strings
3846 that are being bidi-reordered.
3847 (set_iterator_to_next): Support bidi reordering of C strings and
3848 Lisp strings.
3849 (next_element_from_string): Support bidi reordering of Lisp
3850 strings.
3851 (handle_stop_backwards): Support Lisp strings as well.
3852 (display_string): Support display of R2L glyph rows.
3853 Use IT_STRING_CHARPOS when displaying from a Lisp string.
3854 (init_iterator): Don't initialize it->bidi_p for strings
3855 here.
3856 (reseat_to_string): Initialize it->bidi_p for strings here.
3857 (next_element_from_string, next_element_from_c_string)
3858 (next_element_from_buffer): Add xassert's for correspondence
3859 between IT's object being iterated and it->bidi_it.string
3860 structure.
3861 (face_before_or_after_it_pos): Support bidi iteration.
3862 (next_element_from_c_string): Handle the case of the first string
3863 character that is not the first one in the visual order.
3864 (get_visually_first_element): New function, refactored from common
3865 parts of next_element_from_buffer, next_element_from_string, and
3866 next_element_from_c_string.
3867 (tool_bar_lines_needed, redisplay_tool_bar)
3868 (display_menu_bar): Force left-to-right direction. Add a FIXME
3869 comment for making that be controlled by a user option.
3870 (push_it, pop_it): Save and restore the state of the
3871 bidi iterator. Save and restore the bidi_p flag.
3872 (pop_it): Iterate out of display property for string iteration as
3873 well.
3874 (iterate_out_of_display_property): Support iteration over strings.
3875 (handle_single_display_spec): Set up it->bidi_it for iteration
3876 over a display string, and call bidi_init_it.
3877 (handle_single_display_spec, next_overlay_string)
3878 (get_overlay_strings_1, push_display_prop): Set up the bidi
3879 iterator for displaying display or overlay strings.
3880 (forward_to_next_line_start): Don't use the shortcut if
3881 bidi-iterating.
3882 (back_to_previous_visible_line_start): If handle_display_prop
3883 pushed the iterator stack, restore the internal state of the bidi
3884 iterator by calling bidi_pop_it same number of times.
3885 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3886 and we are bidi-iterating, don't decrement the iterator position;
3887 instead, set the first_elt flag in the bidi iterator, to produce
3888 the same effect.
3889 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3890 (push_display_prop): xassert that we are iterating a buffer.
3891 (push_it, pop_it): Save and restore paragraph_embedding member.
3892 (handle_single_display_spec, next_overlay_string)
3893 (get_overlay_strings_1, reseat_1, reseat_to_string)
3894 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3895 correctly. Don't assume unibyte strings are not bidi-reordered.
3896 (compute_display_string_pos)
3897 (compute_display_string_end): Fix handling the case of C string.
3898 (push_it, pop_it): Save and restore from_disp_prop_p.
3899 (handle_single_display_spec, push_display_prop): Set the
3900 from_disp_prop_p flag.
3901 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3902 (pop_it): Call iterate_out_of_display_property only if we are
3903 popping after iteration over a string that came from a display
3904 property. Fix a typo in popping stretch info. Add an assertion
3905 for verifying that the iterator position is in sync with the bidi
3906 iterator.
3907 (handle_single_display_spec, get_overlay_strings_1)
3908 (push_display_prop): Fix initialization of paragraph direction for
3909 string when that of the parent object is not yet determined.
3910 (reseat_1): Call bidi_init_it to resync the bidi
3911 iterator with IT's position. (Bug#7616)
3912 (find_row_edges): If ROW->start.pos gives position
3913 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3914 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3915 Reset the from_disp_prop_p flag.
3916 (SAVE_IT, RESTORE_IT): New macros.
3917 (pos_visible_p, face_before_or_after_it_pos)
3918 (back_to_previous_visible_line_start)
3919 (move_it_in_display_line_to, move_it_in_display_line)
3920 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3921 (try_scrolling, redisplay_window, display_line): Use them when
3922 saving a temporary copy of the iterator and restoring it back.
3923 (back_to_previous_visible_line_start, reseat_1)
3924 (init_iterator): Empty the bidi cache "stack".
3925 (move_it_in_display_line_to): If iterator ended up at
3926 EOL, but we never saw any buffer positions smaller than
3927 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3928 motion in bidi-reordered lines.
3929 (move_it_in_display_line_to): Record prev_method and prev_pos
3930 immediately before the call to set_iterator_to_next. Fixes cursor
3931 motion in bidi-reordered lines with stretch glyphs and strings
3932 displayed in margins. (Bug#8133) (Bug#8867)
3933 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3934 TO_CHARPOS.
3935 (pos_visible_p): Support positions in bidi-reordered lines.
3936 Save and restore bidi cache.
3937
3938 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3939 (bidi_paragraph_info): Delete unused struct.
3940 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3941 (bidi_cache_start): New variable.
3942 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3943 to zero.
3944 (bidi_cache_fetch_state, bidi_cache_search)
3945 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3946 (bidi_cache_find, bidi_peek_at_next_level)
3947 (bidi_level_of_next_char, bidi_find_other_level_edge)
3948 (bidi_move_to_visually_next): Compare cache index with
3949 bidi_cache_start rather than with zero.
3950 (bidi_fetch_char): Accept new argument STRING; all callers
3951 changed. Support iteration over a string. Support strings with
3952 display properties. Support unibyte strings. Fix the type of
3953 `len' according to what STRING_CHAR_AND_LENGTH expects.
3954 (bidi_paragraph_init, bidi_resolve_explicit_1)
3955 (bidi_resolve_explicit, bidi_resolve_weak)
3956 (bidi_level_of_next_char, bidi_move_to_visually_next):
3957 Support iteration over a string.
3958 (bidi_set_sor_type, bidi_resolve_explicit_1)
3959 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3960 can now be zero (for strings); special values 0 and -1 were
3961 changed to -1 and -2, respectively.
3962 (bidi_char_at_pos): New function.
3963 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3964 Call it instead of FETCH_MULTIBYTE_CHAR.
3965 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3966 initialized to valid values.
3967 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3968 values.
3969 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3970 the test for valid cached positions. Fix the logic for looking up
3971 the sentinel state in the cache. GCPRO the Lisp string we are
3972 iterating.
3973 (bidi_push_it, bidi_pop_it): New functions.
3974 (bidi_initialize): Initialize the bidi cache start stack pointer.
3975 (bidi_cache_ensure_space): New function, refactored from part of
3976 bidi_cache_iterator_state. Don't assume the required size is just
3977 one BIDI_CACHE_CHUNK away.
3978 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3979 (bidi_count_bytes, bidi_char_at_pos): New functions.
3980 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3981 always valid if bidi_cache_idx is valid.
3982 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3983 is valid if it's going to be used.
3984 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3985 (bidi_cache_fetch_state, bidi_cache_search)
3986 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3987 (bidi_cache_iterator_state, bidi_cache_find)
3988 (bidi_find_other_level_edge, bidi_cache_start_stack):
3989 All variables related to cache indices are now EMACS_INT.
3990
3991 * dispextern.h (struct bidi_string_data): New structure.
3992 (struct bidi_it): New member `string'. Make flag members be 1-bit
3993 fields, and put them last in the struct.
3994 (compute_display_string_pos, compute_display_string_end):
3995 Update prototypes.
3996 (bidi_push_it, bidi_pop_it): Add prototypes.
3997 (struct iterator_stack_entry): New members bidi_p,
3998 paragraph_embedding, and from_disp_prop_p.
3999 (struct it): Member bidi_p is now a bit field 1 bit wide.
4000 (bidi_shelve_cache, bidi_unshelve_cache):
4001 Declare prototypes.
4002
4003 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4004 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4005 and vector-like objects.
4006
4007 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4008 cache around display iteration.
4009
4010 * window.c (Fwindow_end, window_scroll_pixel_based)
4011 (displayed_window_lines, Frecenter): Save and restore the bidi
4012 cache around display iteration.
4013
4014 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4015
4016 * editfns.c (Fdelete_region): Clarify the use of the named
4017 parameters (bug#6788).
4018
4019 2011-07-14 Martin Rudalics <rudalics@gmx.at>
4020
4021 * indent.c (Fvertical_motion): Set and restore w->pointm when
4022 saving and restoring the window's buffer (Bug#9006).
4023
4024 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4025
4026 * editfns.c (Fstring_to_char): Clarify just what is returned
4027 (bug#6576). Text by Eli Zaretskii.
4028
4029 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
4030
4031 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4032
4033 2011-07-13 Eli Zaretskii <eliz@gnu.org>
4034
4035 * buffer.c (mmap_find): Fix a typo.
4036
4037 2011-07-13 Johan Bockgård <bojohan@gnu.org>
4038
4039 Fix execution of x selection hooks.
4040 * xselect.c (Qx_lost_selection_functions)
4041 (Qx_sent_selection_functions): New vars.
4042 (syms_of_xselect): DEFSYM them.
4043 (x_handle_selection_request): Pass Qx_sent_selection_functions
4044 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4045 (x_handle_selection_clear,x_clear_frame_selections):
4046 Pass Qx_lost_selection_functions rather than
4047 Vx_lost_selection_functions to Frun_hook_with_args.
4048
4049 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4050
4051 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
4052 The old code sometimes used this field without initializing it.
4053
4054 * alloc.c (gc_sweep): Don't read past end of array.
4055 In theory, the old code could also have corrupted Emacs internals,
4056 though it'd be very unlikely.
4057
4058 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4059
4060 * character.c (Fcharacterp): Don't advertise optional ignored
4061 argument. (Bug#4026)
4062
4063 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4064
4065 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4066 key" (bug#4257).
4067
4068 * window.c (Fset_window_start): Doc fix (bug#4199).
4069 (Fset_window_hscroll): Ditto.
4070
4071 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4072
4073 Fix minor new problems caught by GCC 4.6.1.
4074 * term.c (init_tty): Remove unused local.
4075 * xsettings.c (store_monospaced_changed): Define this function only
4076 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
4077 not used otherwise.
4078
4079 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
4080
4081 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4082
4083 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4084
4085 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4086 are the mini-buffer and the echo area (bug#3320).
4087
4088 * term.c (init_tty): Remove support for supdup, c10 and perq
4089 terminals, which are no longer supported (bug#1482).
4090
4091 2011-07-10 Johan Bockgård <bojohan@gnu.org>
4092
4093 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4094
4095 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4096
4097 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4098 for non-popups (Bug#3642).
4099
4100 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4101
4102 * alloc.c (reset_malloc_hooks): Protoize.
4103 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
4104 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4105 * cm.c (losecursor): Likewise.
4106 * data.c (fmod): Likewise.
4107 * dispnew.c (swap_glyphs_in_rows): Likewise.
4108 * emacs.c (memory_warning_signal): Likewise.
4109 * floatfns.c (float_error): Likewise.
4110 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4111 (otf_open, font_otf_capability, generate_otf_features)
4112 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4113 Likewise.
4114 * image.c (pbm_read_file): Likewise.
4115 * indent.c (string_display_width): Likewise.
4116 * intervals.c (check_for_interval, search_for_interval)
4117 (inc_interval_count, count_intervals, root_interval)
4118 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4119 * lread.c (defalias): Likewise.
4120 * ralloc.c (r_alloc_check): Likewise.
4121 * regex.c (set_image_of_range_1, set_image_of_range)
4122 (regex_grow_registers): Likewise.
4123 * sysdep.c (strerror): Likewise.
4124 * termcap.c (valid_filename_p, tprint, main): Likewise.
4125 * tparam.c (main): Likewise.
4126 * unexhp9k800.c (run_time_remap, save_data_space)
4127 (update_file_ptrs, read_header, write_header, calculate_checksum)
4128 (copy_file, copy_rest, display_header): Likewise.
4129 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4130 Likewise.
4131 * xdisp.c (check_it): Likewise.
4132 * xfaces.c (register_color, unregister_color, unregister_colors):
4133 Likewise.
4134 * xfns.c (print_fontset_result): Likewise.
4135 * xrdb.c (member, fatal, main): Likewise.
4136
4137 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4138
4139 Fix minor problems found by static checking (Bug#9031).
4140 * chartab.c (char_table_set_range, map_sub_char_table):
4141 Remove unused locals.
4142 (uniprop_table): Now static.
4143 * composite.c (_work_char): Remove unused static var.
4144
4145 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
4146
4147 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4148
4149 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4150
4151 * gtkutil.c (qttip_cb): Remove code without function.
4152
4153 2011-07-09 Eli Zaretskii <eliz@gnu.org>
4154
4155 * w32.c (pthread_sigmask): New stub.
4156
4157 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
4158
4159 Use pthread_sigmask, not sigprocmask (Bug#9010).
4160 sigprocmask is portable only for single-threaded applications, and
4161 Emacs can be multi-threaded when it uses GTK.
4162 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4163 (LIBES): Use it.
4164 * callproc.c (Fcall_process):
4165 * process.c (create_process):
4166 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4167 Use pthread_sigmask, not sigprocmask.
4168
4169 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4170
4171 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4172 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4173 wrong (Bug#8591).
4174
4175 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4176
4177 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4178 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4179 (xg_hide_tooltip): Fix comment.
4180
4181 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4182 in registerServicesMenuSendTypes.
4183 (validRequestorForSendType): Don't check ns_return_types.
4184
4185 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4186 ns_return_type.
4187
4188 2011-07-08 Jason Rumney <jasonr@gnu.org>
4189
4190 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4191 SH_SHOW for hidden windows (Bug#5482).
4192
4193 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4194 frame struct members of non-existent frames (Bug#6284).
4195
4196 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4197
4198 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4199 variable firstTime not needed on OSX >= 10.6.
4200 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4201 >= 10.5. Use setKnobProportion, setDoubleValue.
4202
4203 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4204 (MAC_OS_X_VERSION_10_5): Define if not defined.
4205 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4206 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4207 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4208
4209 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4210 cString and lossyCString on OSX >= 10.4
4211
4212 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4213 sizeToFit on OSX >= 10.2.
4214
4215 * nsimage.m (allocInitFromFile): Don't use deprecated method
4216 bestRepresentationForDevice on OSX >= 10.6.
4217
4218 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4219 to avoid warning.
4220
4221 * emacs.c: Declare unexec_init_emacs_zone.
4222
4223 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4224
4225 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4226
4227 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4228 on svcsMenu (Bug#8842).
4229
4230 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4231 ns_return_types.
4232 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4233
4234 * nsterm.m (QUTF8_STRING): Declare.
4235 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4236 (validRequestorForSendType): Return type is (id).
4237 Change indexOfObjectIdenticalTo to indexOfObject.
4238 Check if we have local selection before returning self (Bug#8842).
4239 (writeSelectionToPasteboard): Put local selection into paste board
4240 if we have a local selection (Bug#8842).
4241 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4242
4243 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4244 (ns_get_local_selection): Declare.
4245
4246 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4247
4248 * keymap.c (describe_map_tree): Don't insert a double newline at
4249 the end of the buffer (bug#1169) and return whether we inserted
4250 something.
4251
4252 * callint.c (Fcall_interactively): Change "reading args" to
4253 "providing args" to try to clarify what it does (bug#1010).
4254
4255 2011-07-07 Kenichi Handa <handa@m17n.org>
4256
4257 * composite.c (composition_compute_stop_pos): Ignore a static
4258 composition starting before CHARPOS (Bug#8915).
4259
4260 * xdisp.c (handle_composition_prop): Likewise.
4261
4262 2011-07-07 Eli Zaretskii <eliz@gnu.org>
4263
4264 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4265 (Bug#9015)
4266
4267 2011-07-07 Kenichi Handa <handa@m17n.org>
4268
4269 * character.h (unicode_category_t): New enum type.
4270
4271 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4272 (Qchar_code_property_table): New variable.
4273 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4274 (UNIPROP_COMPRESSED_FORM_P): New macros.
4275 (char_table_ascii): Uncompress the compressed values.
4276 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4277 Uncompress the compressed values.
4278 (sub_char_table_ref_and_range): Likewise.
4279 (char_table_ref_and_range): Uncompress the compressed values.
4280 (sub_char_table_set): New arg is_uniprop. Callers changed.
4281 Uncompress the compressed values.
4282 (sub_char_table_set_range): Args changed. Callers changed.
4283 (char_table_set_range): Adjuted for the above change.
4284 (map_sub_char_table): Delete args default_val and parent. Add arg
4285 top. Give decoded values to a Lisp function.
4286 (map_char_table): Adjust for the above change. Give decoded
4287 values to a Lisp function. Gcpro more variables.
4288 (uniprop_table_uncompress)
4289 (uniprop_decode_value_run_length): New functions.
4290 (uniprop_decoder, uniprop_decoder_count): New variables.
4291 (uniprop_get_decoder, uniprop_encode_value_character)
4292 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4293 New functions.
4294 (uniprop_encoder, uniprop_encoder_count): New variables.
4295 (uniprop_get_encoder, uniprop_table)
4296 (Funicode_property_table_internal, Fget_unicode_property_internal)
4297 (Fput_unicode_property_internal): New functions.
4298 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4299 Sunicode_property_table_internal, Sget_unicode_property_internal,
4300 and Sput_unicode_property_internal. Defvar_lisp
4301 char-code-property-alist.
4302
4303 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
4304 Vunicode_category_table.
4305
4306 * font.c (font_range): Adjust for the change of
4307 Vunicode_category_table.
4308
4309 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4310
4311 * m/iris4d.h: Remove file, move contents ...
4312 * s/irix6-5.h: ... here.
4313
4314 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4315
4316 Remove unportable assumption about struct layout (Bug#8884).
4317 * alloc.c (mark_buffer):
4318 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4319 (clone_per_buffer_values): Don't assume that
4320 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4321 This isn't true in general, and it's particularly not true
4322 if Emacs is configured with --with-wide-int.
4323 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4324 New macros, used in the buffer.c change.
4325
4326 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4327
4328 * xsettings.c: Use both GConf and GSettings if both are available.
4329 (store_config_changed_event): Add comment.
4330 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4331 (store_tool_bar_style_changed): New functions.
4332 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
4333 (struct xsettings): Move font inside HAVE_XFT.
4334 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
4335 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
4336 Move inside HAVE_XFT.
4337 (something_changed_gsettingsCB): Rename from something_changedCB.
4338 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4339 also.
4340 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
4341 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
4342 (something_changed_gconfCB): Rename from something_changedCB.
4343 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4344 (parse_settings): Move check for font inside HAVE_XFT.
4345 (read_settings, apply_xft_settings): Add comment.
4346 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4347 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4348 call store_font_name_changed.
4349 (xft_settings_event): Add comment.
4350 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4351 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4352 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4353 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4354 (xsettings_initialize): Call init_gsettings last.
4355 (xsettings_get_system_font, xsettings_get_system_normal_font):
4356 Add comment.
4357
4358 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4359
4360 Random fixes. E.g., (random) never returned negative values.
4361 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4362 subseconds part to the entropy, as that's a bit more random.
4363 Prefer signed to unsigned, since the signedness doesn't matter and
4364 in general we prefer signed. When given a limit, use a
4365 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4366 latter isn't right if USE_2_TAGS_FOR_INTS.
4367 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4368 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4369
4370 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4371
4372 * textprop.c (text_property_stickiness):
4373 Obey Vtext_property_default_nonsticky.
4374 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4375 * w32fns.c (syms_of_w32fns):
4376 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4377
4378 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4379
4380 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4381 This is more efficient than Ffile_directory_p and avoids a minor race.
4382
4383 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4384
4385 * buffer.c (Foverlay_put): Say what the return value is
4386 (bug#7835).
4387
4388 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4389 is a directory before asking whether to use the file name
4390 (bug#7564).
4391 (barf_or_query_if_file_exists): Make the "File is a directory"
4392 error be more correct.
4393
4394 * fns.c (Frequire): Remove the mention of the .gz files, since
4395 that's installation-specific, but keep the mention of
4396 `get-load-suffixes'.
4397
4398 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4399
4400 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4401 Report string overflow if the output is too long.
4402
4403 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
4404
4405 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4406 (syms_of_gnutls): Remove duplicate DEFSYM for
4407 Qgnutls_bootprop_verify_hostname_error, an error for
4408 Qgnutls_bootprop_verify_error (which is no longer used).
4409
4410 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4411 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4412 Also (re)move comments that are misplaced or no longer relevant.
4413
4414 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4415
4416 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4417
4418 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
4419
4420 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4421 and background color parameters if they have been changed.
4422
4423 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4424
4425 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4426
4427 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4428
4429 * xsettings.c (SYSTEM_FONT): Define only when used.
4430 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4431
4432 * keymap.c (access_keymap_1): Now static.
4433
4434 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
4435
4436 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4437 leave any prefix arg for the up event (Bug#1586).
4438
4439 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4440
4441 * lread.c (syms_of_lread): Mention single symbols defined by
4442 `defvar' or `defconst' (bug#7154).
4443
4444 * fns.c (Frequire): Mention .el.gz files (bug#7314).
4445 (Frequire): Mention get-load-suffixes.
4446
4447 2011-07-02 Martin Rudalics <rudalics@gmx.at>
4448
4449 * window.h (window): Remove clone_number slot.
4450 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4451 Remove.
4452 (make_parent_window, make_window, saved_window)
4453 (Fset_window_configuration, save_window_save): Don't deal with
4454 clone numbers.
4455 * buffer.c (Qclone_number): Remove declaration.
4456 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4457
4458 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4459
4460 Add multiple inheritance to keymaps.
4461 * keymap.c (Fmake_composed_keymap): New function.
4462 (Fset_keymap_parent): Simplify.
4463 (fix_submap_inheritance): Remove.
4464 (access_keymap_1): New function extracted from access_keymap to handle
4465 embedded parents and handle lists of maps.
4466 (access_keymap): Use it.
4467 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4468 (Fcopy_keymap): Handle embedded parents.
4469 (Fcommand_remapping, define_as_prefix): Simplify.
4470 (Fkey_binding): Simplify.
4471 (syms_of_keymap): Move minibuffer-local-completion-map,
4472 minibuffer-local-filename-completion-map,
4473 minibuffer-local-must-match-map, and
4474 minibuffer-local-filename-must-match-map to Elisp.
4475 (syms_of_keymap): Defsubr make-composed-keymap.
4476 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4477 (parse_menu_item): Trivial simplification.
4478
4479 2011-07-01 Glenn Morris <rgm@gnu.org>
4480
4481 * Makefile.in (SETTINGS_LIBS): Fix typo.
4482
4483 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4484
4485 * coding.c (Fencode_coding_string): Record the last coding system
4486 used, as the function doc string says (bug#8738).
4487
4488 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4489
4490 * xsettings.c (store_monospaced_changed): Take new font as arg and
4491 check for change against current_mono_font.
4492 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4493 (emacs_settings_constructor, emacs_settings_get_property)
4494 (emacs_settings_set_property, emacs_settings_class_init)
4495 (emacs_settings_init, gsettings_obj): Remove.
4496 (something_changedCB): New function for HAVE_GSETTINGS.
4497 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4498 with value as argument.
4499 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4500 g_settings_new (Bug#8967). Do not create gsettings_obj.
4501 Remove calls to g_settings_bind. Connect something_changedCB to
4502 "changed".
4503
4504 * xgselect.c: Add defined (HAVE_GSETTINGS).
4505 (xgselect_initialize): Ditto.
4506
4507 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4508 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4509 xg_select.
4510
4511 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4512
4513 * eval.c (struct backtrace): Simplify and port the data structure.
4514 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4515 signed bit field, as this assumption is not portable and it makes
4516 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4517 "char debug_on_exit : 1" as this is not portable either; instead,
4518 use the portable "unsigned int debug_on_exit : 1". Remove unused
4519 member evalargs. Remove obsolete comments about cc bombing out.
4520
4521 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4522
4523 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
4524 Let HAVE_GSETTINGS override HAVE_GCONF.
4525 (store_monospaced_changed): New function.
4526 (EMACS_SETTINGS): A new type derived from GObject to handle
4527 GSettings notifications.
4528 (emacs_settings_constructor, emacs_settings_get_property)
4529 (emacs_settings_set_property, emacs_settings_class_init):
4530 New functions.
4531 (gsettings_client, gsettings_obj): New variables.
4532 (GSETTINGS_SCHEMA): New define.
4533 (something_changedCB): Call store_monospaced_changed.
4534 (init_gsettings): New function.
4535 (xsettings_initialize): Call init_gsettings.
4536 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4537 to NULL.
4538
4539 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
4540 GCONF_CFLAGS/LIBS.
4541
4542 2011-06-29 Martin Rudalics <rudalics@gmx.at>
4543
4544 * window.c (resize_root_window, grow_mini_window)
4545 (shrink_mini_window): Rename Qresize_root_window to
4546 Qwindow_resize_root_window and Qresize_root_window_vertically to
4547 Qwindow_resize_root_window_vertically.
4548
4549 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4550
4551 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4552
4553 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
4554
4555 * makefile.w32-in: Redesign dependencies so they reflect more
4556 clearly which files are directly included by each source file,
4557 and not through other includes.
4558
4559 2011-06-27 Martin Rudalics <rudalics@gmx.at>
4560
4561 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4562 (sort_overlays, overlay_strings): When an overlay's clone number
4563 matches the window's clone number process the overlay even if
4564 the overlay's window property doesn't match the current window.
4565
4566 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4567 (Fwindow_hchild): Rename to Fwindow_left_child.
4568 (Fwindow_next): Rename to Fwindow_next_sibling.
4569 (Fwindow_prev): Rename to Fwindow_prev_sibling.
4570 (resize_window_check): Rename to window_resize_check.
4571 (resize_window_apply): Rename to window_resize_apply.
4572 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4573 (Fdelete_other_windows_internal, resize_frame_windows)
4574 (Fsplit_window_internal, Fdelete_window_internal)
4575 (grow_mini_window, shrink_mini_window)
4576 (Fresize_mini_window_internal): Fix callers accordingly.
4577
4578 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4579
4580 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4581 (emacs_fixed_set_min_size): Remove.
4582 (emacs_fixed_new): Take frame as argument.
4583
4584 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4585 (_EmacsFixedPrivate): Remove minwidth/height.
4586 Add struct frame *f.
4587 (emacs_fixed_init): Initialize priv->f.
4588 (get_parent_class, emacs_fixed_set_min_size): Remove.
4589 (emacs_fixed_new): Set priv->f to argument.
4590 (emacs_fixed_get_preferred_width)
4591 (emacs_fixed_get_preferred_height): Use min_width/height from
4592 frames size_hint to set minimum and natural (Bug#8919).
4593 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4594 and use min_width/height from frames size_hint to set
4595 min_width/height (Bug#8919).
4596
4597 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
4598 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4599 Fix indentation.
4600
4601 2011-06-26 Eli Zaretskii <eliz@gnu.org>
4602
4603 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4604 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4605 called at ZV.
4606
4607 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
4608
4609 * process.c (wait_reading_process_output): Bypass select if
4610 waiting for a cell while ignoring keyboard input, and input is
4611 pending. Suggested by Jan Djärv (Bug#8869).
4612
4613 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4614
4615 Use gnulib's dup2 module instead of rolling our own.
4616 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4617
4618 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4619
4620 * dispnew.c (scrolling_window): Before scrolling, turn off a
4621 mouse-highlight in the window being scrolled.
4622
4623 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
4624
4625 Move DEFSYM to lisp.h and use everywhere.
4626
4627 * character.h (DEFSYM): Move declaration...
4628 * lisp.h (DEFSYM): ...here.
4629
4630 * gnutls.c:
4631 * minibuf.c:
4632 * w32menu.c:
4633 * w32proc.c:
4634 * w32select.c: Don't include character.h.
4635
4636 * alloc.c (syms_of_alloc):
4637 * buffer.c (syms_of_buffer):
4638 * bytecode.c (syms_of_bytecode):
4639 * callint.c (syms_of_callint):
4640 * casefiddle.c (syms_of_casefiddle):
4641 * casetab.c (init_casetab_once):
4642 * category.c (init_category_once, syms_of_category):
4643 * ccl.c (syms_of_ccl):
4644 * cmds.c (syms_of_cmds):
4645 * composite.c (syms_of_composite):
4646 * dbusbind.c (syms_of_dbusbind):
4647 * dired.c (syms_of_dired):
4648 * dispnew.c (syms_of_display):
4649 * doc.c (syms_of_doc):
4650 * editfns.c (syms_of_editfns):
4651 * emacs.c (syms_of_emacs):
4652 * eval.c (syms_of_eval):
4653 * fileio.c (syms_of_fileio):
4654 * fns.c (syms_of_fns):
4655 * frame.c (syms_of_frame):
4656 * fringe.c (syms_of_fringe):
4657 * insdel.c (syms_of_insdel):
4658 * keymap.c (syms_of_keymap):
4659 * lread.c (init_obarray, syms_of_lread):
4660 * macros.c (syms_of_macros):
4661 * msdos.c (syms_of_msdos):
4662 * print.c (syms_of_print):
4663 * process.c (syms_of_process):
4664 * search.c (syms_of_search):
4665 * sound.c (syms_of_sound):
4666 * syntax.c (init_syntax_once, syms_of_syntax):
4667 * terminal.c (syms_of_terminal):
4668 * textprop.c (syms_of_textprop):
4669 * undo.c (syms_of_undo):
4670 * w32.c (globals_of_w32):
4671 * window.c (syms_of_window):
4672 * xdisp.c (syms_of_xdisp):
4673 * xfaces.c (syms_of_xfaces):
4674 * xfns.c (syms_of_xfns):
4675 * xmenu.c (syms_of_xmenu):
4676 * xsettings.c (syms_of_xsettings):
4677 * xterm.c (syms_of_xterm): Use DEFSYM.
4678
4679 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4680
4681 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4682
4683 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4684
4685 Integer and buffer overflow fixes (Bug#8873).
4686
4687 * print.c (printchar, strout): Check for string overflow.
4688 (PRINTPREPARE, printchar, strout):
4689 Don't set size unless allocation succeeds.
4690
4691 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4692 for sizes. Check for string overflow more accurately.
4693 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4694
4695 * macros.c: Integer and buffer overflow fixes.
4696 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4697 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4698 Use ptrdiff_t, not int, for sizes.
4699 Don't increment bufsize until after realloc succeeds.
4700 Check for size-calculation overflow.
4701 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4702
4703 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4704
4705 * lread.c: Integer overflow fixes.
4706 (read_integer): Radix is now EMACS_INT, not int,
4707 to improve quality of diagnostics for out-of-range radices.
4708 Calculate buffer size correctly for out-of-range radices.
4709 (read1): Check for integer overflow in radices, and in
4710 read-circle numbers.
4711 (read_escape): Avoid int overflow.
4712 (Fload, openp, read_buffer_size, read1)
4713 (substitute_object_recurse, read_vector, read_list, map_obarray):
4714 Use ptrdiff_t, not int, for sizes.
4715 (read1): Use EMACS_INT, not int, for sizes.
4716 Check for size overflow.
4717
4718 * image.c (cache_image): Check for size arithmetic overflow.
4719
4720 * lread.c: Integer overflow issues.
4721 (saved_doc_string_size, saved_doc_string_length)
4722 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4723 Now ptrdiff_t, not int.
4724 (read1): Don't assume doc string length fits in int. Check for
4725 out-of-range doc string lengths.
4726 (read_list): Don't assume file position fits in int.
4727 (read_escape): Check for hex character overflow.
4728
4729 2011-06-22 Leo Liu <sdl.web@gmail.com>
4730
4731 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4732 Move to minibuffer.el.
4733
4734 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4735
4736 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
4737 The following patches are for when GLYPH_DEBUG && !XASSERT.
4738 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4739 * dispnew.c (flush_stdout):
4740 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4741 Mark as externally visible.
4742 * dispnew.c (check_window_matrix_pointers): Now static.
4743 * dispnew.c (window_to_frame_vpos):
4744 * xfns.c (unwind_create_frame):
4745 * xterm.c (x_check_font): Remove unused local.
4746 * scroll.c (CHECK_BOUNDS):
4747 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4748 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4749 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4750 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4751 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4752 Now static.
4753 (debug_method_add): Use va_list and vsprintf rather than relying
4754 on undefined behavior with wrong number of arguments.
4755 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4756 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4757 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4758 since we're not interested in debugging glyphs with old libraries.
4759 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4760 GCC 4.6.0's static checking.
4761
4762 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4763
4764 Integer overflow and signedness fixes (Bug#8873).
4765 A few related buffer overrun fixes, too.
4766
4767 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4768
4769 * dispextern.h (struct face.stipple):
4770 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4771 (x_bitmap_mask, x_allocate_bitmap_record)
4772 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4773 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4774 (x_create_bitmap_from_xpm_data):
4775 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4776 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4777 (.bitmaps_last):
4778 * xfaces.c (load_pixmap):
4779 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4780 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4781 (.bitmaps_last, struct x_output.icon_bitmap):
4782 Use ptrdiff_t, not int, for bitmap indexes.
4783 (x_allocate_bitmap_record): Check for size overflow.
4784 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4785
4786 Use ptrdiff_t, not int, for overlay counts.
4787 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4788 * editfns.c (overlays_around, get_pos_property):
4789 * textprop.c (get_char_property_and_overlay):
4790 * xdisp.c (next_overlay_change, note_mouse_highlight):
4791 * xfaces.c (face_at_buffer_position):
4792 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4793 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4794 (Fnext_overlay_change, Fprevious_overlay_change)
4795 (mouse_face_overlay_overlaps, Foverlays_in):
4796 Use ptrdiff_t, not int, for sizes.
4797 (overlays_at, overlays_in): Check for size-calculation overflow.
4798
4799 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4800
4801 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4802 (x_session_initialize): Do not assume string length fits in int.
4803
4804 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4805 This is unlikely, but can occur if DPI is outlandish.
4806
4807 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
4808 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4809
4810 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4811 * xrdb.c (magic_file_p, search_magic_path):
4812 Omit last arg SUFFIX; it was always 0. All callers changed.
4813 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4814
4815 * xfont.c (xfont_match): Avoid need for strlen.
4816
4817 * xfns.c: Don't assume strlen fits in int.
4818 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4819
4820 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4821 not unsigned long, as we prefer signed integers. All callers changed.
4822 Detect integer overflow in repeat count.
4823 (message_dolog): Don't assume print length fits in 39 bytes.
4824 (display_mode_element): Don't assume strlen fits in int.
4825
4826 * termcap.c: Don't assume sizes fit in int and never overflow.
4827 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4828 (gobble_line): Check for size-calculation overflow.
4829
4830 * minibuf.c (Fread_buffer):
4831 * lread.c (intern, intern_c_string):
4832 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4833 Don't assume string length fits in int.
4834
4835 * keyboard.c (parse_tool_bar_item):
4836 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4837
4838 * font.c: Don't assume string length fits in int.
4839 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4840 Use ptrdiff_t, not int.
4841 (font_intern_prop): Don't assume string length fits in int.
4842 Don't assume integer property fits in fixnum.
4843 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
4844
4845 * filelock.c: Fix some buffer overrun and integer overflow issues.
4846 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
4847 Reformulate so as not to need the command string.
4848 Invoke gzip -cd rather than gunzip, as it's more portable.
4849 (lock_info_type, lock_file_1, lock_file):
4850 Don't assume pid_t and time_t fit in unsigned long.
4851 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4852 (current_lock_owner): Prefer signed type for sizes.
4853 Use memcpy, not strncpy, where memcpy is what is really wanted.
4854 Don't assume (via atoi) that time_t and pid_t fit in int.
4855 Check for time_t and/or pid_t out of range, e.g., via a network share.
4856 Don't alloca where an auto var works fine.
4857
4858 * fileio.c: Fix some integer overflow issues.
4859 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4860 Don't assume string length fits in int.
4861 (directory_file_name): Don't assume string length fits in long.
4862 (make_temp_name): Don't assume pid fits in int, or that its print
4863 length is less than 20.
4864
4865 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4866
4867 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4868
4869 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4870
4871 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4872 We prefer signed integers, even for size calculations.
4873
4874 * emacs.c: Don't assume string length fits in 'int'.
4875 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4876 (main): Don't invoke strlen when not needed.
4877
4878 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4879 (XD_DEBUG_MESSAGE): Don't waste a byte.
4880
4881 * callproc.c (getenv_internal_1, getenv_internal)
4882 (Fgetenv_internal):
4883 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4884
4885 * lread.c (invalid_syntax): Omit length argument.
4886 All uses changed. This doesn't fix a bug, but it simplifies the
4887 code away from its former Hollerith-constant appearance, and it's
4888 one less 'int' to worry about when looking at integer-overflow issues.
4889 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
4890
4891 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4892 This didn't break anything, but it didn't help either.
4893 It's confusing to put a bogus integer in a place where the actual
4894 value does not matter.
4895 (LIST_END_P): Remove unused macro and its bogus comment.
4896 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
4897
4898 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4899 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4900 implementation.
4901 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4902 We prefer signed types, and the value cannot exceed the EMACS_INT
4903 range anyway (because otherwise the length would not be representable).
4904 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4905 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4906 This avoids a GCC warning when WIDE_EMACS_INT.
4907
4908 * indent.c (sane_tab_width): New function.
4909 (current_column, scan_for_column, Findent_to, position_indentation)
4910 (compute_motion): Use it. This is just for clarity.
4911 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
4912
4913 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
4914
4915 * lisp.h (lint_assume): New macro.
4916 * composite.c (composition_gstring_put_cache):
4917 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4918
4919 * editfns.c, insdel.c:
4920 Omit unnecessary forward decls, to simplify future changes.
4921
4922 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4923
4924 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4925
4926 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
4927 Use much-faster test for byte-length change.
4928 Don't assume string byte-length fits in 'int'.
4929 Check that character arg fits in 'int'.
4930 (mapcar1): Declare byte as byte, for clarity.
4931
4932 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4933
4934 * fns.c (concat): Catch string overflow earlier.
4935 Do not rely on integer wraparound.
4936
4937 * dispextern.h (struct it.overlay_strings_charpos)
4938 (struct it.selective): Now EMACS_INT, not int.
4939 * xdisp.c (forward_to_next_line_start)
4940 (back_to_previous_visible_line_start)
4941 (reseat_at_next_visible_line_start, next_element_from_buffer):
4942 Don't arbitrarily truncate the value of 'selective' to int.
4943
4944 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4945
4946 * composite.c: Don't truncate sizes to 'int'.
4947 (composition_gstring_p, composition_reseat_it)
4948 (composition_adjust_point): Use EMACS_INT, not int.
4949 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4950 not EMACS_UINT, for indexes.
4951
4952 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4953
4954 * buffer.c: Include <verify.h>.
4955 (struct sortvec.priority, struct sortstr.priority):
4956 Now EMACS_INT, not int.
4957 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
4958 (struct sortstr.size, record_overlay_string)
4959 (struct sortstrlist.size, struct sortlist.used):
4960 Don't truncate size to int.
4961 (record_overlay_string): Check for size-calculation overflow.
4962 (init_buffer_once): Check at compile-time, not run-time.
4963
4964 2011-06-22 Jim Meyering <meyering@redhat.com>
4965
4966 Don't leak an XBM-image-sized buffer
4967 * image.c (xbm_load): Free the image buffer after using it.
4968
4969 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4970
4971 Port to Sun C.
4972 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4973 that Sun C diagnosed.
4974 * fns.c (secure_hash): Fix pointer signedness issue.
4975 * intervals.c (static_offset_intervals): New function.
4976 (offset_intervals): Use it.
4977
4978 2011-06-21 Leo Liu <sdl.web@gmail.com>
4979
4980 * deps.mk (fns.o):
4981 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4982 sha512.h.
4983
4984 * fns.c (secure_hash): Rename from crypto_hash_function and change
4985 the first arg to accept symbols.
4986 (Fsecure_hash): New primitive.
4987 (syms_of_fns): New symbols.
4988
4989 2011-06-20 Deniz Dogan <deniz@dogan.se>
4990
4991 * process.c (Fset_process_buffer): Clarify return value in
4992 docstring.
4993
4994 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
4995
4996 * dispnew.c (add_window_display_history): Use BVAR.
4997
4998 * xdisp.c (debug_method_add): Use BVAR.
4999 (check_window_end, dump_glyph_matrix, dump_glyph)
5000 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5001
5002 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5003 Likewise.
5004
5005 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5006 check till after the cache is created in init_frame_faces.
5007
5008 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5009
5010 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5011
5012 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5013
5014 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5015 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5016 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5017
5018 Improve buffer-overflow checking (Bug#8873).
5019 * fileio.c (Finsert_file_contents):
5020 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5021 Remove the old (too-loose) buffer overflow checks.
5022 They weren't needed, since make_gap checks for buffer overflow.
5023 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5024 The old code merely checked for Emacs fixnum overflow, and relied
5025 on undefined (wraparound) behavior. The new code avoids undefined
5026 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5027
5028 * editfns.c (Finsert_char): Don't dump core with very negative counts.
5029 Tune. Don't use wider integers than needed. Don't use alloca.
5030 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
5031
5032 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5033
5034 * insdel.c, lisp.h (buffer_overflow): New function.
5035 (insert_from_buffer_1, replace_range, replace_range_2):
5036 * insdel.c (make_gap_larger):
5037 * editfns.c (Finsert_char):
5038 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5039
5040 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5041
5042 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5043
5044 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
5045
5046 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5047 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5048
5049 * fileio.c: Don't assume EMACS_INT fits in off_t.
5050 (emacs_lseek): New static function.
5051 (Finsert_file_contents, Fwrite_region): Use it.
5052 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5053
5054 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5055
5056 * fns.c: Don't overflow int when computing a list length.
5057 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5058 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5059 truncation on 64-bit hosts. Check for QUIT every
5060 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5061 faster and is responsive enough.
5062 (Flength): Report an error instead of overflowing an integer.
5063 (Fsafe_length): Return a float if the value is not representable
5064 as a fixnum. This shouldn't happen except in contrived situations.
5065 (Fnthcdr, Fsort): Don't assume list length fits in int.
5066 (Fcopy_sequence): Don't assume vector length fits in int.
5067
5068 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5069 (header_size, word_size): New constants.
5070 (allocate_vectorlike): Don't check size overflow here.
5071 (allocate_vector): Check it here instead, since this is the only
5072 caller of allocate_vectorlike that could cause overflow.
5073 Check that the new vector's length is representable as a fixnum.
5074
5075 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5076 The previous code was bogus. For example, next_almost_prime (32)
5077 returned 39, which is undesirable as it is a multiple of 3; and
5078 next_almost_prime (24) returned 25, which is a multiple of 5 so
5079 why was the code bothering to check for multiples of 7?
5080
5081 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5082
5083 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5084
5085 Variadic C functions now count arguments with ptrdiff_t.
5086 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5087 Back then I didn't know that the Emacs coding style prefers signed int.
5088 Also, in the meantime I found a few more instances where arguments
5089 were being counted with int, which may truncate counts on 64-bit
5090 machines, or EMACS_INT, which may be unnecessarily wide.
5091 * lisp.h (struct Lisp_Subr.function.aMANY)
5092 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5093 Arg counts are now ptrdiff_t, not size_t.
5094 All variadic functions and their callers changed accordingly.
5095 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5096 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5097 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5098 * callint.c (Fcall_interactively): Check arg count for overflow,
5099 to avoid potential buffer overrun. Use signed char, not 'int',
5100 for 'varies' array, so that we needn't bother to check its size
5101 calculation for overflow.
5102 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5103 * eval.c (apply_lambda):
5104 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5105 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5106 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5107
5108 * callint.c (Fcall_interactively): Don't use index var as event count.
5109
5110 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5111 * mem-limits.h (SIZE): Remove; no longer used.
5112
5113 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5114
5115 Remove unnecessary casts.
5116 * xterm.c (x_term_init):
5117 * xfns.c (x_set_border_pixel):
5118 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5119 These aren't needed now that we assume ANSI C.
5120
5121 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5122 It's more likely to cause problems (due to unsigned overflow)
5123 than to cure them.
5124
5125 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5126
5127 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5128
5129 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5130
5131 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5132
5133 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5134
5135 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5136
5137 GLYPH_CODE_FACE returns EMACS_INT, not int.
5138 * dispextern.h (merge_faces):
5139 * xfaces.c (merge_faces):
5140 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5141 Don't assume EMACS_INT fits in int.
5142
5143 * character.h (CHAR_VALID_P): Remove unused parameter.
5144 * fontset.c, lisp.h, xdisp.c: All uses changed.
5145
5146 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5147
5148 * fns.c (concat): Minor tuning based on overflow analysis.
5149 This doesn't fix any bugs. Use int to hold character, instead
5150 of constantly refetching from Emacs object. Use XFASTINT, not
5151 XINT, for value known to be a character. Don't bother comparing
5152 a single byte to 0400, as it's always less.
5153
5154 * floatfns.c (Fexpt):
5155 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5156
5157 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5158 for characters.
5159
5160 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5161
5162 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5163 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5164 incorrectly succeed when S was a string, because 4294967386 was
5165 truncated before it was used.
5166
5167 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5168 Otherwise, an out-of-range integer could cause undefined behavior
5169 on a 64-bit host.
5170
5171 * composite.c: Use int, not EMACS_INT, for characters.
5172 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5173 EMACS_INT, for values that are known to be in character range.
5174 This doesn't fix any bugs but is the usual style inside Emacs and
5175 may generate better code on 32-bit machines.
5176
5177 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5178 This is for reasons similar to the recent CHAR_STRING fix.
5179 * charset.c (Fencode_char): Check that character arg is actually
5180 a character. Pass an int to ENCODE_CHAR.
5181 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5182 wider than 'int', as a compile-time check to prevent future regressions
5183 in this area.
5184
5185 * character.c (char_string): Remove unnecessary casts.
5186
5187 Make sure a 64-bit char is never passed to CHAR_STRING.
5188 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5189 by silently ignoring the top 32 bits, allowing some values
5190 that were far too large to be valid characters.
5191 * character.h: Include <verify.h>.
5192 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5193 arguments are no wider than unsigned, as a compile-time check
5194 to prevent future regressions in this area.
5195 * data.c (Faset):
5196 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
5197 (Fsubst_char_in_region):
5198 * fns.c (concat):
5199 * xdisp.c (decode_mode_spec_coding):
5200 Adjust to CHAR_STRING's new requirement.
5201 * editfns.c (Finsert_char, Fsubst_char_in_region):
5202 * fns.c (concat): Check that character args are actually
5203 characters. Without this test, these functions did the wrong
5204 thing with wildly out-of-range values on 64-bit hosts.
5205
5206 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5207 These casts should not be needed on 32-bit hosts, either.
5208 * keyboard.c (read_char):
5209 * lread.c (Fload): Remove casts to unsigned.
5210
5211 * lisp.h (UNSIGNED_CMP): New macro.
5212 This fixes comparison bugs on 64-bit hosts.
5213 (ASCII_CHAR_P): Use it.
5214 * casefiddle.c (casify_object):
5215 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
5216 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5217 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5218 * dispextern.h (FACE_FROM_ID):
5219 * keyboard.c (read_char): Use UNSIGNED_CMP.
5220
5221 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5222 not to EMACS_INT, to avoid GCC warning.
5223
5224 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5225
5226 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5227 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5228 isn't needed on 32-bit machines.
5229
5230 * buffer.c (Fgenerate_new_buffer_name):
5231 Use EMACS_INT for count, not int.
5232 (advance_to_char_boundary): Return EMACS_INT, not int.
5233
5234 * data.c (Qcompiled_function): Now static.
5235
5236 * window.c (window_body_lines): Now static.
5237
5238 * image.c (gif_load): Rename local to avoid shadowing.
5239
5240 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5241 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5242 * alloc.c (make_save_value): Integer argument is now of type
5243 ptrdiff_t, not int.
5244 (mark_object): Use ptrdiff_t, not int.
5245 * lisp.h (pD): New macro.
5246 * print.c (print_object): Use it.
5247
5248 * alloc.c: Use EMACS_INT, not int, to count objects.
5249 (total_conses, total_markers, total_symbols, total_vector_size)
5250 (total_free_conses, total_free_markers, total_free_symbols)
5251 (total_free_floats, total_floats, total_free_intervals)
5252 (total_intervals, total_strings, total_free_strings):
5253 Now EMACS_INT, not int. All uses changed.
5254 (Fgarbage_collect): Compute overall total using a double, so that
5255 integer overflow is less likely to be a problem. Check for overflow
5256 when converting back to an integer.
5257 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5258 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5259 These were 'int' variables that could overflow on 64-bit hosts;
5260 they were never used, so remove them instead of repairing them.
5261 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
5262 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5263 Previously, this ceilinged at INT_MAX, but that doesn't work on
5264 64-bit machines.
5265 (allocate_pseudovector): Don't use EMACS_INT when int would do.
5266
5267 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
5268 (allocate_vectorlike): Check for ptrdiff_t overflow.
5269 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5270 when a (possibly-narrower) signed value would do just as well.
5271 We prefer using signed arithmetic, to avoid comparison confusion.
5272
5273 * alloc.c: Catch some string size overflows that we were missing.
5274 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5275 for convenience in STRING_BYTES_MAX.
5276 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5277 The definition here is exact; the one in lisp.h was approximate.
5278 (allocate_string_data): Check for string overflow. This catches
5279 some instances we weren't catching before. Also, it catches
5280 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5281 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5282 and ptrdiff_t and EMACS_INT are both 64 bits.
5283
5284 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5285 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
5286 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
5287
5288 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5289
5290 * alloc.c (Fmake_string): Check for out-of-range init.
5291
5292 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5293
5294 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5295
5296 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5297
5298 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5299 xg_get_default_scrollbar_width.
5300
5301 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5302 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5303 (style_changed_cb): Call update_theme_scrollbar_width and call
5304 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5305 all frames (Bug#8505).
5306 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5307 Call gtk_window_set_resizable if HAVE_GTK3.
5308 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5309 and height if HAVE_GTK3 (Bug#8505).
5310 (scroll_bar_width_for_theme): New variable.
5311 (update_theme_scrollbar_width): New function.
5312 (xg_get_default_scrollbar_width): Move code to
5313 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5314 (xg_initialize): Call update_theme_scrollbar_width.
5315
5316 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5317
5318 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5319
5320 2011-06-12 Martin Rudalics <rudalics@gmx.at>
5321
5322 * frame.c (make_frame): Call other_buffer_safely instead of
5323 other_buffer.
5324
5325 * window.c (temp_output_buffer_show): Call display_buffer with
5326 second argument Vtemp_buffer_show_specifiers and reset latter
5327 immediately after the call.
5328 (Vtemp_buffer_show_specifiers): New variable.
5329 (auto_window_vscroll_p, next_screen_context_lines)
5330 (Vscroll_preserve_screen_position): Remove leading asterisks from
5331 doc-strings.
5332
5333 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
5334
5335 Fix minor problems found by GCC 4.6.0 static checking.
5336 * buffer.c (Qclone_number): Remove for now, as it's unused.
5337 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5338 (record_buffer): Remove unused local.
5339 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5340 (set_frame_buffer_list): Remove; unused.
5341 * frame.h (other_visible_frames): Remove decl.
5342 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5343 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5344 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5345 if HAVE_GPM.
5346 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5347 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5348 Define only if HAVE_GPM.
5349 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5350 (update_hints_inhibit): Remove; never set. All uses removed.
5351 * widgetprv.h (emacsFrameClassRec): Remove decl.
5352 * window.c (delete_deletable_window): Now returns void, since it
5353 wasn't returning anything.
5354 (compare_window_configurations): Remove unused locals.
5355 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5356 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
5357 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5358 the same widths as pointers. This follows up on the 2011-05-06 patch.
5359 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5360 * xterm.h: Likewise.
5361 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5362
5363 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
5364
5365 * makefile.w32-in: Update dependencies.
5366 (LISP_H): Add lib/intprops.h.
5367
5368 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5369
5370 * image.c (gif_load): Add animation frame delay to the metadata.
5371 (syms_of_image): Use DEFSYM. New symbol `delay'.
5372
5373 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5374
5375 * window.c (delete_deletable_window): Re-add.
5376 (Fset_window_configuration): Rewrite to handle dead buffers and
5377 consequently deletable windows.
5378 (window_tree, Fwindow_tree): Remove. Supply functionality in
5379 window.el.
5380 (compare_window_configurations): Simplify code.
5381
5382 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5383
5384 * image.c (imagemagick_load_image): Fix type mismatch.
5385 (Fimagemagick_types): Likewise.
5386
5387 * window.h (replace_buffer_in_windows): Declare.
5388
5389 2011-06-11 Martin Rudalics <rudalics@gmx.at>
5390
5391 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5392 Qclone_number. Remove external declaration of Qdelete_window.
5393 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5394 code.
5395 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5396 Run Qbuffer_list_update_hook if allowed.
5397 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5398 buffer list implementation.
5399 (other_buffer_safely): New function.
5400 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5401 calls to replace_buffer_in_windows and
5402 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5403 if allowed.
5404 (record_buffer): Inhibit quitting and rewrite using quittable
5405 functions. Run Qbuffer_list_update_hook if allowed.
5406 (Frecord_buffer, Funrecord_buffer): New functions.
5407 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5408 Move switch-to-buffer to window.el.
5409 (bury-buffer): Move to window.el.
5410 (Vbuffer_list_update_hook): New variable.
5411
5412 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5413 section.
5414
5415 * window.h (resize_frame_windows): Move up in code.
5416 (Fwindow_frame): Remove EXFUN.
5417 (replace_buffer_in_all_windows): Remove prototype.
5418 (replace_buffer_in_windows_safely): Add prototype.
5419
5420 * window.c: Declare Qdelete_window static again. Move down
5421 declaration of select_count.
5422 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5423 (Fother_window): Move to window.el.
5424 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5425 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5426 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5427 window.el.
5428 (replace_buffer_in_windows): Implement by calling
5429 Qreplace_buffer_in_windows.
5430 (replace_buffer_in_all_windows): Remove with some functionality
5431 moved into replace_buffer_in_windows_safely.
5432 (replace_buffer_in_windows_safely): New function.
5433 (select_window_norecord, select_frame_norecord): Move in front
5434 of run_window_configuration_change_hook. Remove now obsolete
5435 declarations.
5436 (Fset_window_buffer): Rewrite doc-string.
5437 Call Qrecord_window_buffer.
5438 (keys_of_window): Move binding for other-window to window.el.
5439
5440 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
5441
5442 * dispextern.h (struct image): Replace data member, whose int_val
5443 and ptr_val fields were not used by anything, with a single
5444 lisp_val object.
5445
5446 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5447 (gif_clear_image, gif_load, imagemagick_load_image)
5448 (gs_clear_image, gs_load): Callers changed.
5449
5450 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5451
5452 * buffer.h: Include <time.h>, for time_t.
5453 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5454
5455 Fix minor problems found by static checking.
5456
5457 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5458
5459 Make identifiers static if they are not used in other modules.
5460 * data.c (Qcompiled_function, Qframe, Qvector):
5461 * image.c (QimageMagick, Qsvg):
5462 * minibuf.c (Qmetadata):
5463 * window.c (resize_window_check, resize_root_window): Now static.
5464 * window.h (resize_window_check, resize_root_window): Remove decls.
5465
5466 * window.c (window_deletion_count, delete_deletable_window):
5467 Remove; unused.
5468 (window_body_lines): Now static.
5469 (Fdelete_other_windows_internal): Mark vars as initialized.
5470 Make sure 'resize_failed' is initialized.
5471 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5472 (resize_window_apply): Remove unused local.
5473 * window.h (delete_deletable_window): Remove decl.
5474
5475 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
5476 (imagemagick_load_image): Fix pointer signedness problem by changing
5477 last arg from unsigned char * to char *. All uses changed.
5478 Also, fix a local for similar reasons.
5479 Remove unused locals. Remove locals to avoid shadowing.
5480 (fn_rsvg_handle_free): Remove; unused.
5481 (svg_load, svg_load_image): Fix pointer signedness problem.
5482 (imagemagick_load_image): Don't use garbage pointer image_wand.
5483
5484 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5485
5486 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
5487
5488 * image.c (gif_load): Fix omitted cast error introduced by
5489 2011-06-06 change.
5490
5491 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5492
5493 * window.h (resize_proportionally, orig_total_lines)
5494 (orig_top_line): Remove from window structure.
5495 (set_window_height, set_window_width, change_window_heights)
5496 (Fdelete_window): Remove prototypes.
5497 (resize_frame_windows): Remove duplicate declaration.
5498
5499 2011-06-10 Eli Zaretskii <eliz@gnu.org>
5500
5501 * window.h (resize_frame_windows, resize_window_check)
5502 (delete_deletable_window, resize_root_window)
5503 (resize_frame_windows): Declare prototypes.
5504
5505 * window.c (resize_window_apply): Make definition be "static" to
5506 match the prototype.
5507
5508 2011-06-10 Martin Rudalics <rudalics@gmx.at>
5509
5510 * window.c: Remove declarations of Qwindow_size_fixed,
5511 window_min_size_1, window_min_size_2, window_min_size,
5512 size_window, window_fixed_size_p, enlarge_window, delete_window.
5513 Remove static from declaration of Qdelete_window, it's
5514 temporarily needed by Fbury_buffer.
5515 (replace_window): Don't assign orig_top_line and
5516 orig_total_lines.
5517 (Fdelete_window, delete_window): Remove. Window deletion is
5518 handled by window.el.
5519 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5520 Replace Fdelete_window calls with calls to Qdelete_window.
5521 (Fdelete_other_windows): Remove. Deleting other windows is
5522 handled by window.el.
5523 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5524 handled in window.el.
5525 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5526 Window minimum sizes are handled in window.el.
5527 (shrink_windows, size_window, set_window_height)
5528 (set_window_width, change_window_heights, window_height)
5529 (window_width, CURBEG, CURSIZE, enlarge_window)
5530 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5531 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5532 handled in window.el.
5533 (make_dummy_parent): Rename to make_parent_window and give it a
5534 second argument horflag.
5535 (make_window): Don't set resize_proportionally any more.
5536 (Fsplit_window): Remove. Windows are split in window.el.
5537 (save_restore_action, save_restore_orig_size)
5538 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5539 Resize mini windows in window.el.
5540 (grow_mini_window, shrink_mini_window): Implement by calling
5541 Qresize_root_window_vertically, resize_window_check and
5542 resize_window_apply.
5543 (saved_window, Fset_window_configuration, save_window_save):
5544 Do not handle orig_top_line, orig_total_lines, and
5545 resize_proportionally.
5546 (window_min_height, window_min_width): Move to window.el.
5547 (keys_of_window): Move bindings for delete-other-windows,
5548 split-window, delete-window and enlarge-window to window.el.
5549
5550 * buffer.c: Temporarily extern Qdelete_window.
5551 (Fbury_buffer): Temporarily call Qdelete_window instead of
5552 Fdelete_window (Fbury_buffer will move to window.el soon).
5553
5554 * frame.c (set_menu_bar_lines_1): Remove code handling
5555 orig_top_line and orig_total_lines.
5556
5557 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5558 set_window_height but set heights directly.
5559 (change_frame_size_1): Use resize_frame_windows.
5560
5561 * xdisp.c (init_xdisp): Don't use set_window_height but set
5562 heights directly.
5563
5564 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5565 Use resize_frame_windows instead of change_window_heights and run
5566 run_window_configuration_change_hook.
5567
5568 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5569 instead of change_window_heights and run
5570 run_window_configuration_change_hook.
5571
5572 2011-06-09 Martin Rudalics <rudalics@gmx.at>
5573
5574 * window.c (replace_window): Rename second argument REPLACEMENT to
5575 NEW. New third argument SETFLAG. Rewrite.
5576 (delete_window, make_dummy_parent): Call replace_window with
5577 third argument 1.
5578 (window_list_1): Move down in code.
5579 (run_window_configuration_change_hook): Move set_buffer part
5580 before select_frame_norecord part in order to unwind correctly.
5581 Rename count1 to count.
5582 (recombine_windows, delete_deletable_window, resize_root_window)
5583 (Fdelete_other_windows_internal)
5584 (Frun_window_configuration_change_hook, make_parent_window)
5585 (resize_window_check, resize_window_apply, Fresize_window_apply)
5586 (resize_frame_windows, Fsplit_window_internal)
5587 (Fdelete_window_internal, Fresize_mini_window_internal):
5588 New functions.
5589 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5590
5591 2011-06-08 Martin Rudalics <rudalics@gmx.at>
5592
5593 * window.h (window): Add some new members to window structure -
5594 normal_lines, normal_cols, new_total, new_normal, clone_number,
5595 splits, nest, prev_buffers, next_buffers.
5596 (WINDOW_TOTAL_SIZE): Move here from window.c.
5597 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
5598
5599 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5600 Remove.
5601 (make_dummy_parent): Set new members of windows structure.
5602 (make_window): Move down in code. Handle new members of window
5603 structure.
5604 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5605 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5606 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5607 (Fset_window_prev_buffers, Fwindow_next_buffers)
5608 (Fset_window_next_buffers, Fset_window_clone_number):
5609 New functions.
5610 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5611 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5612 Doc-string fixes.
5613 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5614 Argument WINDOW can be now internal window too.
5615 (Fwindow_use_time): Move up in code.
5616 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5617 Rewrite doc-string.
5618 (Fset_window_configuration, saved_window)
5619 (Fcurrent_window_configuration, save_window_save): Handle new
5620 members of window structure.
5621 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5622 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5623 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5624 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5625 Qget_mru_window, Qresize_root_window,
5626 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5627 Qauto_buffer_name; staticpro them.
5628
5629 2011-06-07 Martin Rudalics <rudalics@gmx.at>
5630
5631 * window.c (Fwindow_total_size, Fwindow_left_column)
5632 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5633 (Fwindow_list_1): New functions.
5634 (window_box_text_cols): Replace with window_body_cols.
5635 (Fwindow_width, Fscroll_left, Fscroll_right):
5636 Use window_body_cols instead of window_box_text_cols.
5637 (delete_window, Fset_window_configuration):
5638 Call delete_all_subwindows with window as argument.
5639 (delete_all_subwindows): Take a window as argument and not a
5640 structure. Rewrite.
5641 (window_loop): Remove handling of GET_LRU_WINDOW and
5642 GET_LARGEST_WINDOW.
5643 (Fget_lru_window, Fget_largest_window): Move to window.el.
5644
5645 * window.h: Extern window_body_cols instead of
5646 window_box_text_cols. delete_all_subwindows now takes a
5647 Lisp_Object as argument.
5648
5649 * indent.c (compute_motion, Fcompute_motion):
5650 Use window_body_cols instead of window_box_text_cols.
5651
5652 * frame.c (delete_frame): Call delete_all_subwindows with root
5653 window as argument.
5654
5655 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5656
5657 * fns.c (Fputhash): Document return value.
5658
5659 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
5660
5661 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5662
5663 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5664
5665 Cons<->int and similar integer overflow fixes (Bug#8794).
5666
5667 Check for overflow when converting integer to cons and back.
5668 * charset.c (Fdefine_charset_internal, Fdecode_char):
5669 Use cons_to_unsigned to catch overflow.
5670 (Fencode_char): Use INTEGER_TO_CONS.
5671 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5672 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5673 * data.c (long_to_cons, cons_to_long): Remove.
5674 (cons_to_unsigned, cons_to_signed): New functions.
5675 These signal an error for invalid or out-of-range values.
5676 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5677 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5678 * font.c (Ffont_variation_glyphs):
5679 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5680 * lisp.h: Include <intprops.h>.
5681 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5682 (cons_to_signed, cons_to_unsigned): New decls.
5683 (long_to_cons, cons_to_long): Remove decls.
5684 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5685 (Fprimitive_undo): Use CONS_TO_INTEGER.
5686 * xfns.c (Fx_window_property): Likewise.
5687 * xselect.c: Include <limits.h>.
5688 (x_own_selection, selection_data_to_lisp_data):
5689 Use INTEGER_TO_CONS.
5690 (x_handle_selection_request, x_handle_selection_clear)
5691 (x_get_foreign_selection, Fx_disown_selection_internal)
5692 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5693 (lisp_data_to_selection_data): Use cons_to_unsigned.
5694 (x_fill_property_data): Use cons_to_signed.
5695 Report values out of range.
5696
5697 Check for buffer and string overflow more precisely.
5698 * buffer.h (BUF_BYTES_MAX): New macro.
5699 * lisp.h (STRING_BYTES_MAX): New macro.
5700 * alloc.c (Fmake_string):
5701 * character.c (string_escape_byte8):
5702 * coding.c (coding_alloc_by_realloc):
5703 * doprnt.c (doprnt):
5704 * editfns.c (Fformat):
5705 * eval.c (verror):
5706 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5707 since they may not be the same number.
5708 * editfns.c (Finsert_char):
5709 * fileio.c (Finsert_file_contents):
5710 Likewise for BUF_BYTES_MAX.
5711
5712 * image.c: Use ptrdiff_t, not int, for sizes.
5713 (slurp_file): Switch from int to ptrdiff_t.
5714 All uses changed.
5715 (slurp_file): Check that file size fits in both size_t (for
5716 malloc) and ptrdiff_t (for sanity and safety).
5717
5718 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5719 if b->modtime has its maximal value.
5720
5721 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5722
5723 Don't assume time_t can fit into int.
5724 * buffer.h (struct buffer.modtime): Now time_t, not int.
5725 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5726 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5727
5728 Minor fixes for signed vs unsigned integers.
5729 * character.h (MAYBE_UNIFY_CHAR):
5730 * charset.c (maybe_unify_char):
5731 * keyboard.c (read_char, reorder_modifiers):
5732 XINT -> XFASTINT, since the integer must be nonnegative.
5733 * ftfont.c (ftfont_spec_pattern):
5734 * keymap.c (access_keymap, silly_event_symbol_error):
5735 XUINT -> XFASTINT, since the integer must be nonnegative.
5736 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5737 since it makes no difference and we prefer signed.
5738 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5739 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5740 nonnegative.
5741
5742 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5743
5744 * window.h (Fwindow_frame): Declare.
5745
5746 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5747
5748 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5749 (SPARE_MEMORY): Always define.
5750 (LARGE_REQUEST): Remove.
5751 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5752
5753 2011-06-06 Martin Rudalics <rudalics@gmx.at>
5754
5755 * lisp.h: Move EXFUNS for Fframe_root_window,
5756 Fframe_first_window and Fset_frame_selected_window to window.h.
5757
5758 * window.h: Move EXFUNS for Fframe_root_window,
5759 Fframe_first_window and Fset_frame_selected_window here from
5760 lisp.h.
5761
5762 * frame.c (Fwindow_frame, Fframe_first_window)
5763 (Fframe_root_window, Fframe_selected_window)
5764 (Fset_frame_selected_window): Move to window.c.
5765 (Factive_minibuffer_window): Move to minibuf.c.
5766 (Fother_visible_frames_p): New function.
5767
5768 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5769
5770 * window.c (decode_window, decode_any_window): Move up in code.
5771 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5772 (inhibit_frame_unsplittable): Remove unused variable.
5773 (Fwindow_buffer): Move up and rewrite doc-string.
5774 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5775 (Fwindow_prev): New functions.
5776 (Fwindow_frame): Move here from frame.c. Accept any window as
5777 argument.
5778 (Fframe_root_window, Fframe_first_window)
5779 (Fframe_selected_window): Move here from frame.c. Accept frame
5780 or arbitrary window as argument. Update doc-strings.
5781 (Fminibuffer_window): Move up in code.
5782 (Fwindow_minibuffer_p): Move up in code and simplify.
5783 (Fset_frame_selected_window): Move here from frame.c.
5784 Marginal rewrite.
5785 (Fselected_window, select_window, Fselect_window): Move up in
5786 code. Minor doc-string fixes.
5787
5788 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5789
5790 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5791 Do not assume that spare memory exists; that assumption is valid
5792 only if SYSTEM_MALLOC.
5793 (LARGE_REQUEST): New macro, so that the issue of large requests
5794 is separated from the issue of spare memory.
5795
5796 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5797
5798 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5799 format. (Bug#8806)
5800
5801 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5802
5803 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5804 before statements.
5805
5806 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5807
5808 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5809
5810 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5811
5812 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5813 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5814
5815 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
5816
5817 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5818
5819 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
5820
5821 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5822 (x_clipboard_manager_save): Add return value.
5823 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5824 New error handlers.
5825 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5826 Obey Vx_select_enable_clipboard_manager. Catch errors in
5827 x_clipboard_manager_save (Bug#8779).
5828 (Vx_select_enable_clipboard_manager): New variable.
5829 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
5830
5831 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
5832
5833 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5834
5835 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5836
5837 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5838 in the current matrix if keep_current_p is non-zero.
5839
5840 2011-06-04 Eli Zaretskii <eliz@gnu.org>
5841
5842 * bidi.c (bidi_level_of_next_char): Fix last change.
5843
5844 2011-06-03 Eli Zaretskii <eliz@gnu.org>
5845
5846 Support bidi reordering of text covered by display properties.
5847
5848 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5849 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5850 (bidi_cache_search, bidi_cache_iterator_state)
5851 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
5852 (bidi_level_of_next_char, bidi_move_to_visually_next):
5853 Support character positions inside a run of characters covered by a
5854 display string.
5855 (bidi_paragraph_init, bidi_resolve_explicit_1)
5856 (bidi_level_of_next_char): Call bidi_fetch_char and
5857 bidi_fetch_char_advance instead of FETCH_CHAR and
5858 FETCH_CHAR_ADVANCE.
5859 (bidi_init_it): Initialize new members.
5860 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5861 definitions.
5862 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5863 instead of using explicit *_CHAR codes.
5864 (bidi_resolve_explicit, bidi_resolve_weak):
5865 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
5866 bidirectional text is supported only in multibyte buffers.
5867 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5868 it to initialize the frame_window_p member of struct bidi_it.
5869 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5870 (bidi_resolve_explicit, bidi_resolve_weak)
5871 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5872 bidi_it->nchars is non-positive.
5873 (bidi_level_of_next_char): Don't try to lookup the cache for the
5874 next/previous character if nothing is cached there yet, or if we
5875 were just reseat()'ed to a new position.
5876
5877 * xdisp.c (set_cursor_from_row): Set start and stop points
5878 according to the row's direction when priming the loop that looks
5879 for the glyph on which to display cursor.
5880 (single_display_spec_intangible_p): Function deleted.
5881 (display_prop_intangible_p): Reimplement to call
5882 handle_display_spec instead of single_display_spec_intangible_p.
5883 Accept 3 additional arguments needed by handle_display_spec.
5884 This fixes incorrect cursor motion across display property with complex
5885 values: lists, `(when COND...)' forms, etc.
5886 (single_display_spec_string_p): Support property values that are
5887 lists with the argument STRING its top-level element.
5888 (display_prop_string_p): Fix the condition for processing a
5889 property that is a list to be consistent with handle_display_spec.
5890 (handle_display_spec): New function, refactored from the
5891 last portion of handle_display_prop.
5892 (compute_display_string_pos): Accept additional argument
5893 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5894 value of a `display' property is a "replacing spec".
5895 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5896 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5897 the display property, but just return a value indicating whether
5898 the display property will replace the characters it covers.
5899 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5900 frame_window_p members of struct bidi_it.
5901 (compute_display_string_pos, compute_display_string_end):
5902 New functions.
5903 (push_it): Accept second argument POSITION, where pop_it should
5904 jump to continue iteration.
5905 (reseat_1): Initialize bidi_it.disp_pos.
5906
5907 * keyboard.c (adjust_point_for_property): Adjust the call to
5908 display_prop_intangible_p to its new signature.
5909
5910 * dispextern.h (struct bidi_it): New member frame_window_p.
5911 (bidi_init_it): Update prototypes.
5912 (display_prop_intangible_p): Update prototype.
5913 (compute_display_string_pos, compute_display_string_end):
5914 Declare prototypes.
5915 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5916 EMACS_INT.
5917
5918 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
5919
5920 Malloc failure behavior now depends on size of allocation.
5921 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5922 * lisp.h: Change signatures accordingly.
5923 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5924 All callers changed. (Bug#8762)
5925
5926 * gnutls.c: Use Emacs's memory allocators.
5927 Without this change, the gnutls library would invoke malloc etc.
5928 directly, which causes problems on non-SYNC_INPUT hosts, and which
5929 runs afoul of improving memory_full behavior. (Bug#8761)
5930 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5931 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5932 xfree instead of the default malloc, realloc, free.
5933 (Fgnutls_boot): No need to check for memory allocation failure,
5934 since xmalloc does that for us.
5935
5936 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
5937 * category.c (hash_get_category_set):
5938 * ccl.c (ccl_driver):
5939 * charset.c (Fdefine_charset_internal):
5940 * charset.h (struct charset.hash_index):
5941 * composite.c (get_composition_id, gstring_lookup_cache)
5942 (composition_gstring_put_cache):
5943 * composite.h (struct composition.hash_index):
5944 * dispextern.h (struct image.hash):
5945 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5946 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5947 (hashfn_equal, hashfn_user_defined, make_hash_table)
5948 (maybe_resize_hash_table, hash_lookup, hash_put)
5949 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5950 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5951 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5952 * image.c (make_image, search_image_cache, lookup_image)
5953 (xpm_put_color_table_h):
5954 * lisp.h (struct Lisp_Hash_Table):
5955 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
5956 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
5957 for hashes and hash indexes, instead of 'unsigned' and 'int'.
5958 * alloc.c (allocate_vectorlike):
5959 Check for overflow in vector size calculations.
5960 * ccl.c (ccl_driver):
5961 Check for overflow when converting EMACS_INT to int.
5962 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5963 need to be updated by these changes.
5964 * fns.c (make_hash_table, maybe_resize_hash_table):
5965 Check for integer overflow with large hash tables.
5966 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5967 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5968 (SXHASH_REDUCE): New macro.
5969 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5970 Use it instead of discarding useful hash info with large hash values.
5971 (sxhash_float): New function.
5972 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5973 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
5974 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5975 Rewrite to use FIXNUM_BITS, as this simplifies things.
5976 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5977 Adjust signatures to match updated version of code.
5978 (consing_since_gc): Now EMACS_INT, since a single hash table can
5979 use more than INT_MAX bytes.
5980
5981 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5982
5983 Make it possible to build with GCC-4.6+ -O2 -flto.
5984
5985 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5986
5987 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5988
5989 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5990 Call minibuffer-inactive-mode.
5991
5992 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
5993
5994 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5995 Update dependencies.
5996
5997 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5998
5999 * data.c (init_data): Remove code for UTS, this system is not
6000 supported anymore.
6001
6002 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6003
6004 Don't force ./temacs to start in terminal mode.
6005
6006 * frame.c (make_initial_frame): Initialize faces in all cases, not
6007 only when CANNOT_DUMP is defined.
6008 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6009
6010 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6011
6012 * dispnew.c (add_window_display_history): Use const for the string
6013 pointer. Remove declaration, not needed.
6014
6015 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6016
6017 Use 'inline', not 'INLINE'.
6018 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
6019 * alloc.c, fontset.c (INLINE): Remove.
6020 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6021 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6022 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6023 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6024 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6025
6026 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6027
6028 Make it possible to run ./temacs.
6029
6030 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6031 syms_of_callproc does the same thing. Remove test for
6032 "initialized", do it in the caller.
6033 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6034
6035 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6036
6037 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6038 (read_minibuf): Use get_minibuffer.
6039 (syms_of_minibuf): Use DEFSYM.
6040 (Qmetadata): New var.
6041 * data.c (Qbuffer): Don't make it static.
6042 (syms_of_data): Use DEFSYM.
6043
6044 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6045
6046 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6047 (CCL_CODE_MIN): New macro.
6048
6049 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6050
6051 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6052
6053 * eval.c (Qdebug): Now static.
6054 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6055 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6056 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6057
6058 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6059
6060 * image.c: Various fixes to ImageMagick code comments.
6061 (Fimagemagick_types): Doc fix.
6062
6063 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6064
6065 Minor fixes prompted by GCC 4.6.0 warnings.
6066
6067 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6068
6069 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6070 (x_clipboard_manager_save_all): Move extern decl to ...
6071 * xterm.h: ... here, so that it can be checked for consistency.
6072
6073 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
6074
6075 * xselect.c (x_clipboard_manager_save_frame)
6076 (x_clipboard_manager_save_all): New functions.
6077 (Fx_clipboard_manager_save): Lisp function deleted.
6078
6079 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6080 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6081
6082 * xterm.h: Update prototype.
6083
6084 2011-05-28 William Xu <william.xwl@gmail.com>
6085
6086 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6087 exiting (Bug#8239).
6088
6089 2011-05-28 Jim Meyering <meyering@redhat.com>
6090
6091 Avoid a sign-extension bug in crypto_hash_function.
6092 * fns.c (to_uchar): Define.
6093 (crypto_hash_function): Use it to convert some newly-signed
6094 variables to unsigned, to avoid sign-extension bugs. For example,
6095 without this change, (md5 "truc") would evaluate to
6096 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6097 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
6098 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
6099
6100 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6101
6102 Integer overflow fixes.
6103
6104 * dbusbind.c: Serial number integer overflow fixes.
6105 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
6106 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6107 to hold a serial number that is too large for a fixnum.
6108 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6109 Check for serial numbers out of range. Decode any serial number
6110 that was so large that it became a float. (Bug#8722)
6111
6112 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6113 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6114 Use XFASTINT rather than XUINT when numbers are nonnegative.
6115 (xd_append_arg, Fdbus_method_return_internal):
6116 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6117 arguments, check that Lisp number is nonnegative, rather than
6118 silently wrapping negative numbers around. (Bug#8722)
6119 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
6120 (Bug#8722)
6121
6122 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6123
6124 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6125
6126 ccl: Add integer overflow checks.
6127 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6128 (IN_INT_RANGE): New macros.
6129 (ccl_driver): Use them to check for integer overflow when
6130 decoding a CCL program. Many of the new checks are whether XINT (x)
6131 fits in int; it doesn't always, on 64-bit hosts. The new version
6132 doesn't catch all possible integer overflows, but it's an
6133 improvement. (Bug#8719)
6134
6135 * alloc.c (make_event_array): Use XINT, not XUINT.
6136 There's no need for unsigned here.
6137
6138 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6139 This follows up to the 2011-05-06 change that substituted uintptr_t
6140 for EMACS_INT. This case wasn't caught back then.
6141
6142 Rework Fformat to avoid integer overflow issues.
6143 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6144 now (part of C89). Include <verify.h>.
6145 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6146 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6147 (Fformat): Avoid the prepass trying to compute sizes; it was only
6148 approximate and thus did not catch overflow reliably. Instead, walk
6149 through the format just once, formatting and computing sizes as we go,
6150 checking for integer overflow at every step, and allocating a larger
6151 buffer as needed. Keep track separately whether the format is
6152 multibyte. Keep only the most-recently calculated precision, rather
6153 than them all. Record whether each argument has been converted to
6154 string. Use EMACS_INT, not int, for byte and char and arg counts.
6155 Support field widths and precisions larger than INT_MAX. Avoid
6156 sprintf's undefined behavior with conversion specifications such as %#d
6157 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6158 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6159 formatting out-of-range floating point numbers with int
6160 formats. (Bug#8668)
6161
6162 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6163
6164 * data.c: Avoid integer truncation in expressions involving floats.
6165 * data.c: Include <intprops.h>.
6166 (arith_driver): When there's an integer overflow in an expression
6167 involving floating point, convert the integers to floating point
6168 so that the resulting value does not suffer from catastrophic
6169 integer truncation. For example, on a 64-bit host (* 4
6170 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6171 Do not rely on undefined behavior after integer overflow.
6172
6173 merge count_size_as_multibyte, parse_str_to_multibyte
6174 * character.c, character.h (count_size_as_multibyte):
6175 Rename from parse_str_to_multibyte; all uses changed.
6176 Check for integer overflow.
6177 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6178 since it's now a duplicate of the other. This is more of
6179 a character than a buffer op, so better that it's in character.c.
6180 * fns.c, print.c: Adjust to above changes.
6181
6182 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6183
6184 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6185
6186 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6187
6188 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6189 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6190 (x_clipboard_manager_save): Now static.
6191 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6192
6193 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6194 (crypto_hash_function): Now static.
6195 Fix pointer signedness problems. Avoid unnecessary initializations.
6196
6197 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
6198
6199 * termhooks.h (Vselection_alist): Make it terminal-local.
6200
6201 * terminal.c (create_terminal): Initialize it.
6202
6203 * xselect.c: Support for clipboard managers.
6204 (Vselection_alist): Move to termhooks.h as terminal-local var.
6205 (LOCAL_SELECTION): New macro.
6206 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6207 (symbol_to_x_atom): Remove gratuitous arg.
6208 (x_handle_selection_request, lisp_data_to_selection_data)
6209 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
6210 (x_own_selection, x_get_local_selection, x_convert_selection):
6211 New arg, specifying work frame. Use terminal-local Vselection_alist.
6212 (some_frame_on_display): Delete unused function.
6213 (Fx_own_selection_internal, Fx_get_selection_internal)
6214 (Fx_disown_selection_internal, Fx_selection_owner_p)
6215 (Fx_selection_exists_p): New optional frame arg.
6216 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6217 (x_handle_selection_clear): Don't treat other terminals with the
6218 same keyboard specially. Use the terminal-local Vselection_alist.
6219 (x_clear_frame_selections): Use Frun_hook_with_args.
6220
6221 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6222
6223 * xterm.h: Add support for those atoms.
6224
6225 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
6226
6227 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6228 (converted_selections, conversion_fail_tag): New global variables.
6229 (x_selection_request_lisp_error): Free the above.
6230 (x_get_local_selection): Remove unnecessary code.
6231 (x_reply_selection_request): Args changed; handle arbitrary array
6232 of converted selections stored in converted_selections.
6233 Separate the XChangeProperty and SelectionNotify steps.
6234 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6235 (x_convert_selection): New function.
6236 (x_handle_selection_event): Simplify.
6237 (x_get_foreign_selection): Don't ignore incoming requests while
6238 waiting for an answer; this will fail when we implement
6239 SAVE_TARGETS, and seems unnecessary anyway.
6240 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6241 (Vx_sent_selection_functions): Doc fix.
6242
6243 2011-05-26 Leo Liu <sdl.web@gmail.com>
6244
6245 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6246
6247 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6248
6249 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6250
6251 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6252 for fringe update if it has periodic bitmap.
6253 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
6254 and fringe_bitmap_periodic_p.
6255
6256 * fringe.c (get_fringe_bitmap_data): New function.
6257 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6258 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6259 row. Mark glyph row for fringe update if periodicity changed.
6260
6261 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6262 for fringe update unless it has periodic bitmap.
6263
6264 2011-05-25 Kenichi Handa <handa@m17n.org>
6265
6266 * xdisp.c (get_next_display_element): Set correct it->face_id for
6267 a static composition.
6268
6269 2011-05-24 Leo Liu <sdl.web@gmail.com>
6270
6271 * deps.mk (fns.o):
6272 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6273
6274 * fns.c (crypto_hash_function, Fsha1): New function.
6275 (Fmd5): Use crypto_hash_function.
6276 (syms_of_fns): Add Ssha1.
6277
6278 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6279
6280 * gnutls.c: Remove unused macros.
6281 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6282 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6283 Remove macros that are defined and never used.
6284 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6285
6286 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6287
6288 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6289 (Fx_get_selection_internal): Minor cleanup.
6290 (Fx_own_selection_internal): Rename arguments for consistency with
6291 select.el.
6292
6293 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6294
6295 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6296
6297 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
6298
6299 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6300
6301 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6302
6303 * dispnew.c (scrolling_window): Don't exclude the case that the
6304 last enabled row in the desired matrix touches the bottom boundary.
6305
6306 2011-05-21 Glenn Morris <rgm@gnu.org>
6307
6308 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
6309 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6310 and add some more files.
6311
6312 2011-05-20 Eli Zaretskii <eliz@gnu.org>
6313
6314 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6315 report_file_error introduced by the change from 2011-05-07.
6316
6317 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6318
6319 * systime.h (Time): Define only if emacs is defined.
6320 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6321 where the include path doesn't have X11/X.h by default. See
6322 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6323
6324 2011-05-20 Kenichi Handa <handa@m17n.org>
6325
6326 * composite.c (find_automatic_composition): Fix previous change.
6327
6328 2011-05-20 Glenn Morris <rgm@gnu.org>
6329
6330 * lisp.mk: New file, split from Makefile.in.
6331 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6332 (shortlisp): Remove.
6333 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6334
6335 2011-05-19 Glenn Morris <rgm@gnu.org>
6336
6337 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6338 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6339 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6340 (lisp): Set the order to that of loadup.el.
6341 (shortlisp): Make it a copy of $lisp.
6342 (SOME_MACHINE_LISP): Remove.
6343 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6344 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6345
6346 2011-05-18 Kenichi Handa <handa@m17n.org>
6347
6348 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6349 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6350 (find_automatic_composition): Mostly rewrite for efficiency.
6351
6352 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
6353
6354 * makefile.w32-in: Update dependencies.
6355
6356 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6357
6358 * menu.c: Include limits.h (fixes the MS-Windows build broken by
6359 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
6360
6361 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
6362
6363 Fix some integer overflow issues, such as string length overflow.
6364
6365 * insdel.c (count_size_as_multibyte): Check for string overflow.
6366
6367 * character.c (lisp_string_width): Check for string overflow.
6368 Use EMACS_INT, not int, for string indexes and lengths; in
6369 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6370 the resulting string length overflows an EMACS_INT; instead,
6371 report a string overflow if no precision given. When checking for
6372 precision exhaustion, use a check that cannot possibly have
6373 integer overflow. (Bug#8675)
6374 * character.h (lisp_string_width): Adjust to new signature.
6375
6376 * alloc.c (string_overflow): New function.
6377 (Fmake_string): Use it. This doesn't change behavior, but saves
6378 a few bytes and will simplify future changes.
6379 * character.c (string_escape_byte8): Likewise.
6380 * lisp.h (string_overflow): New decl.
6381
6382 Fixups, following up to the user-interface timestamp change.
6383 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6384 for UI timestamps, instead of unsigned long.
6385 * msdos.c (mouse_get_pos): Likewise.
6386 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
6387 * w32gui.h (Time): Define by including "systime.h" rather than by
6388 declaring it ourselves. (Bug#8664)
6389
6390 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6391 * image.c (clear_image_cache): Likewise.
6392
6393 * term.c (term_mouse_position): Don't assume time_t wraparound.
6394
6395 Be more systematic about user-interface timestamps.
6396 Before, the code sometimes used 'Time', sometimes 'unsigned long',
6397 and sometimes 'EMACS_UINT', to represent these timestamps.
6398 This change causes it to use 'Time' uniformly, as that's what X uses.
6399 This makes the code easier to follow, and makes it easier to catch
6400 integer overflow bugs such as Bug#8664.
6401 * frame.c (Fmouse_position, Fmouse_pixel_position):
6402 Use Time, not unsigned long, for user-interface timestamps.
6403 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6404 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6405 * keyboard.h (last_event_timestamp): Likewise.
6406 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6407 * menu.h (xmenu_show): Likewise.
6408 * term.c (term_mouse_position): Likewise.
6409 * termhooks.h (struct input_event.timestamp): Likewise.
6410 (struct terminal.mouse_position_hook): Likewise.
6411 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6412 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6413 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6414 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6415 what it was before.
6416 * menu.h, termhooks.h: Include "systime.h", for Time.
6417
6418 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6419 Don't assume that the difference between two unsigned long values
6420 can fit into an integer. At this point, we know button_down_time
6421 <= event->timestamp, so the difference must be nonnegative, so
6422 there's no need to cast the result if double-click-time is
6423 nonnegative, as it should be; check that it's nonnegative, just in
6424 case. This bug is triggered when events are more than 2**31 ms
6425 apart (about 25 days). (Bug#8664)
6426
6427 * xselect.c (last_event_timestamp): Remove duplicate decl.
6428 (x_own_selection): Remove needless cast to unsigned long.
6429
6430 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6431 that always fit in int. Use a sentinel instead of a counter, to
6432 avoid a temp and to allay GCC's concerns about possible int overflow.
6433 * frame.h (struct frame): Use int for menu_bar_items_used
6434 instead of EMACS_INT, since it always fits in int.
6435
6436 * menu.c (grow_menu_items): Check for int overflow.
6437
6438 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6439
6440 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6441 Before, the code was not consistent. These values cannot exceed
6442 2**31 - 1 so there's no need to make them unsigned.
6443 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6444 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6445 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6446 as modifiers.
6447 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6448
6449 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6450 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6451 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6452 presumably because the widths might not match.
6453
6454 * window.c (size_window): Avoid needless test at loop start.
6455
6456 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6457
6458 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6459
6460 2011-05-12 Drew Adams <drew.adams@oracle.com>
6461
6462 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6463
6464 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6465
6466 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6467 `width' to `bar_area_x' and `bar_area_width', respectively.
6468 (x_scroll_run): Take account of fringe background extension.
6469
6470 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6471 Rename local vars `left' and `width' to `bar_area_x' and
6472 `bar_area_width', respectively.
6473 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6474 background extension.
6475
6476 2011-05-10 Jim Meyering <meyering@redhat.com>
6477
6478 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6479
6480 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
6481
6482 * image.c (Finit_image_library): Return t for built-in image types,
6483 like pbm and xbm. (Bug#8640)
6484
6485 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6486
6487 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6488
6489 2011-05-07 Eli Zaretskii <eliz@gnu.org>
6490
6491 * w32console.c (Fset_screen_color): Doc fix.
6492 (Fget_screen_color): New function.
6493 (syms_of_ntterm): Defsubr it.
6494
6495 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6496 unlink the temporary file if Fcall_process didn't create it in the
6497 first place.
6498 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6499 child process will be redirected to a file specified with `:file'.
6500 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6501 cue to call_process_cleanup not to close that handle.
6502
6503 2011-05-07 Ben Key <bkey76@gmail.com>
6504
6505 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6506 one of two shell specific rules, either bootstrap-temacs-CMD or
6507 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6508 to the previous implementation of the bootstrap-temacs rule.
6509 The bootstrap-temacs-CMD rule is similar to the previous
6510 implementation of the bootstrap-temacs rule except that it
6511 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6512 variable.
6513
6514 These changes, along with some changes to nt/configure.bat,
6515 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6516 earlier fix to add support for --cflags and --ldflags options
6517 that include quotes so that it works whether make uses cmd or
6518 sh as the shell.
6519
6520 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
6521
6522 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6523 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6524 is a constant.
6525 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6526 a string. Handle both cases.
6527 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6528 (Fdbus_register_method): Use Qinvalid_function.
6529
6530 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6531
6532 * makefile.w32-in: Update dependencies.
6533 (LISP_H): Add inttypes.h and stdin.h.
6534 (PROCESS_H): Add unistd.h.
6535
6536 2011-05-06 Eli Zaretskii <eliz@gnu.org>
6537
6538 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6539 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6540
6541 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
6542
6543 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6544
6545 * term.c (vfatal): Remove stray call to va_end.
6546 It's not needed and the C Standard doesn't allow it here anyway.
6547
6548 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6549 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6550
6551 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6552 bytes.
6553
6554 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6555
6556 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6557
6558 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6559
6560 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6561
6562 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6563
6564 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6565 * charset.c (Fdefine_charset_internal): Don't initialize
6566 charset.code_space[15]. The value was garbage, on hosts with
6567 32-bit int (Bug#8600).
6568
6569 * lread.c (read_integer): Be more consistent with string-to-number.
6570 Use string_to_number to do the actual conversion; this avoids
6571 rounding errors and fixes some other screwups. Without this fix,
6572 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6573 (digit_to_number): Move earlier, for benefit of read_integer.
6574 Return -1 if the digit is out of range for the base, -2 if it is
6575 not a digit in any supported base. (Bug#8602)
6576
6577 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6578
6579 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6580 to match comment at start of function. This also removes a
6581 GCC warning about overflow in a 32+64-bit port.
6582
6583 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6584
6585 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6586 Reported by Stefan Monnier in
6587 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
6588 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6589 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
6590
6591 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6592 (EMACS_UINTPTR): Likewise, with uintptr_t.
6593
6594 * lisp.h: Prefer 64-bit EMACS_INT if available.
6595 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6596 on 32-bit hosts that have 64-bit int, so that they can access
6597 large files.
6598 However, temporarily disable this change unless the temporary
6599 symbol WIDE_EMACS_INT is defined.
6600
6601 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6602
6603 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6604 This removes an assumption that EMACS_INT and long are the same
6605 width as pointers. The assumption is true for Emacs porting targets
6606 now, but we want to make other targets possible.
6607 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6608 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6609 In the rest of the code, change types of integers that hold casted
6610 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6611 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6612 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6613 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6614 No need to cast type when ORing.
6615 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6616 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6617 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6618 assume EMACS_INT is the same width as char *.
6619 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6620 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6621 Remove no-longer-needed casts.
6622 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6623 (xg_tool_bar_help_callback, xg_make_tool_item):
6624 Use EMACS_INTPTR to hold an integer
6625 that will be cast to void *; this can avoid a GCC warning
6626 if EMACS_INT is not the same width as void *.
6627 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6628 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6629 (current_message_1, set_message_1):
6630 Use a local to convert to proper width without a cast.
6631 * xmenu.c (dialog_selection_callback): Likewise.
6632
6633 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6634 Also, don't assume VALBITS / RAND_BITS is less than 5,
6635 and don't rely on undefined behavior when shifting a 1 left into
6636 the sign bit.
6637 * lisp.h (get_random): Change signature to match.
6638
6639 * lread.c (hash_string): Use size_t, not int, for hash computation.
6640 Normally we prefer signed values; but hashing is special, because
6641 it's better to use unsigned division on hash table sizes so that
6642 the remainder is nonnegative. Also, size_t is the natural width
6643 for hashing into memory. The previous code used 'int', which doesn't
6644 retain enough info to hash well into very large tables.
6645 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6646
6647 * dbusbind.c: Don't possibly lose pointer info when converting.
6648 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6649 Use XPNTR rather than XHASH, so that the high-order bits of
6650 the pointer aren't lost when converting through void *.
6651
6652 * eval.c (Fautoload): Don't double-shift a pointer.
6653
6654 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6655
6656 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
6657
6658 * gnutls.c (DEF_GNUTLS_FN):
6659 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6660
6661 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6662
6663 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6664 marker. (Bug#8610)
6665
6666 2011-05-05 Eli Zaretskii <eliz@gnu.org>
6667
6668 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6669 New version that can reserve upto 2GB of heap space.
6670
6671 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
6672
6673 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6674
6675 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6676
6677 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6678 `gnutls_certificate_set_x509_key_file'.
6679
6680 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
6681
6682 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6683 Update dependencies.
6684
6685 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6686
6687 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6688 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6689 Remove unused parameter `fildes'.
6690 * process.c (read_process_output, send_process): Don't pass it.
6691
6692 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6693
6694 Fix previous change: the library cache is defined in w32.c.
6695 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6696 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6697
6698 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
6699
6700 Implement dynamic loading of GnuTLS on Windows.
6701
6702 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6703 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6704 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6705 Declare.
6706
6707 * gnutls.c (Qgnutls_dll): Define.
6708 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6709 (gnutls_*): Declare function pointers.
6710 (init_gnutls_functions): New function to initialize function pointers.
6711 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6712 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6713 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6714 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6715 (emacs_gnutls_write, emacs_gnutls_read)
6716 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6717 (Fgnutls_available_p): New function.
6718 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6719 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6720 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6721
6722 * image.c: Include w32.h.
6723 (Vimage_type_cache): Delete.
6724 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6725 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6726 (w32_delayed_load): Move to w32.c.
6727
6728 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6729
6730 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6731 (w32_delayed_load): Move from image.c. When loading a library, record
6732 its filename in the :loaded-from property of the library id.
6733 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6734 Initialize and staticpro them.
6735 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6736
6737 * process.c: Include lisp.h before w32.h, not after.
6738 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6739 instead of gnutls_record_check_pending.
6740
6741 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6742
6743 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6744
6745 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6746 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6747 as passed in.
6748
6749 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6750
6751 * xterm.c (x_set_frame_alpha): Do not set property on anything
6752 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6753
6754 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6755
6756 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6757
6758 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
6759
6760 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6761 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6762 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6763 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6764 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6765 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6766 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6767 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6768 (Qgnutls_bootprop_callbacks_verify): Make static.
6769
6770 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6771
6772 * callproc.c: Indentation fixup.
6773
6774 * sysdep.c (wait_for_termination_1): Make static.
6775 (wait_for_termination, interruptible_wait_for_termination):
6776 Move after wait_for_termination_1.
6777
6778 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6779
6780 * sysdep.c (interruptible_wait_for_termination): New function
6781 which is like wait_for_termination, but allows keyboard
6782 interruptions.
6783
6784 * callproc.c (Fcall_process): Add (:file "file") as an option for
6785 the STDOUT buffer.
6786 (Fcall_process_region): Ditto.
6787
6788 2011-04-30 Eli Zaretskii <eliz@gnu.org>
6789
6790 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6791 rather than `XVECTOR (FOO)->size'.
6792
6793 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6794 inttypes.h, as a gnulib replacement is used if it not available in
6795 system headers.
6796
6797 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6798
6799 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6800 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6801 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6802
6803 * coding.c (coding_alloc_by_realloc): Error out if destination
6804 will grow beyond MOST_POSITIVE_FIXNUM.
6805 (decode_coding_emacs_mule): Abort if there isn't enough place in
6806 charbuf for the composition carryover bytes. Reserve an extra
6807 space for up to 2 characters produced in a loop.
6808 (decode_coding_iso_2022): Abort if there isn't enough place in
6809 charbuf for the composition carryover bytes.
6810
6811 2011-04-21 Eli Zaretskii <eliz@gnu.org>
6812
6813 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6814 aborting when %lld or %lll format is passed.
6815 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6816 %llo or %llx format is passed. (Bug#8545)
6817
6818 * window.c (window_scroll_line_based): Use a marker instead of
6819 simple variables to record original value of point. (Bug#7952)
6820
6821 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6822 produced by %s or %c overflows available buffer space. (Bug#8545)
6823
6824 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6825
6826 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
6827 (SIZE_MAX): Move defn after all includes, as they might #define it.
6828
6829 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6830
6831 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6832
6833 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6834
6835 * keyboard.c (Qdelayed_warnings_hook): Define.
6836 (command_loop_1): Run `delayed-warnings-hook'
6837 if Vdelayed_warnings_list is non-nil.
6838 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6839 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6840
6841 2011-04-28 Eli Zaretskii <eliz@gnu.org>
6842
6843 * doprnt.c (doprnt): Don't return value smaller than the buffer
6844 size if the message was truncated. (Bug#8545).
6845
6846 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
6847
6848 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6849 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6850
6851 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6852
6853 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6854
6855 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
6856
6857 * makefile.w32-in: Update dependencies.
6858
6859 2011-04-27 Eli Zaretskii <eliz@gnu.org>
6860
6861 Improve `doprnt' and its usage. (Bug#8545)
6862 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6863 `format_end'. Remove support for %l as a conversion specifier.
6864 Don't use xrealloc. Improve diagnostics when the %l size modifier
6865 is used. Update the commentary.
6866
6867 * eval.c (verror): Simplify calculation of size_t.
6868
6869 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6870 messages.
6871
6872 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6873
6874 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6875 change.
6876
6877 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6878
6879 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6880 This makes this file independent of the recent pseudovector change.
6881
6882 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
6883
6884 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6885
6886 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
6887 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
6888 Remove unused local.
6889 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
6890
6891 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
6892 GCC 4.6.0 optimizes based on type-based alias analysis.
6893 For example, if b is of type struct buffer * and v of type struct
6894 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6895 != &v->size, and therefore "v->size = 1; b->size = 2; return
6896 v->size;" must therefore return 1. This assumption is incorrect
6897 for Emacs, since it type-puns struct Lisp_Vector * with many other
6898 types. To fix this problem, this patch adds a new type struct
6899 vectorlike_header that documents the constraints on layout of vectors
6900 and pseudovectors, and helps optimizing compilers not get fooled
6901 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6902 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
6903 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6904 the size member.
6905 (XSETPVECTYPE): Rewrite in terms of new macro.
6906 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6907 This is a bit clearer, and further avoids the possibility of
6908 undesirable aliasing.
6909 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
6910 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
6911 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6912 since Lisp_Subr is a special case (no "next" field).
6913 (ASIZE): Now uses header.size rather than size.
6914 All previous uses of XVECTOR (foo)->size replaced to use this macro,
6915 to avoid the hassle of writing XVECTOR (foo)->header.size.
6916 (struct vectorlike_header): New type.
6917 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6918 object, to help avoid aliasing.
6919 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6920 (SUBRP): Likewise, since Lisp_Subr is a special case.
6921 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6922 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6923 (struct Lisp_Hash_Table): Combine first two members into a single
6924 struct vectorlike_header member. All uses of "size" and "next" members
6925 changed to be "header.size" and "header.next".
6926 * buffer.h (struct buffer): Likewise.
6927 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6928 * frame.h (struct frame): Likewise.
6929 * process.h (struct Lisp_Process): Likewise.
6930 * termhooks.h (struct terminal): Likewise.
6931 * window.c (struct save_window_data, struct saved_window): Likewise.
6932 * window.h (struct window): Likewise.
6933 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6934 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6935 * buffer.c (init_buffer_once): Likewise.
6936 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6937 special case.
6938 * process.c (Fformat_network_address): Use local var for size,
6939 for brevity.
6940
6941 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6942
6943 Make the Lisp reader and string-to-float more consistent (Bug#8525)
6944 * data.c (atof): Remove decl; no longer used or needed.
6945 (digit_to_number): Move to lread.c.
6946 (Fstring_to_number): Use new string_to_number function, to be
6947 consistent with how the Lisp reader treats infinities and NaNs.
6948 Do not assume that floating-point numbers represent EMACS_INT
6949 without losing information; this is not true on most 64-bit hosts.
6950 Avoid double-rounding errors, by insisting on integers when
6951 parsing non-base-10 numbers, as the documentation specifies.
6952 * lisp.h (string_to_number): New decl, replacing ...
6953 (isfloat_string): Remove.
6954 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
6955 (read1): Do not accept +. and -. as integers; this
6956 appears to have been a coding error. Similarly, do not accept
6957 strings like +-1e0 as floating point numbers. Do not report
6958 overflow for integer overflows unless the base is not 10 which
6959 means we have no simple and reliable way to continue.
6960 Break out the floating-point parsing into a new
6961 function string_to_number, so that Fstring_to_number parses
6962 floating point numbers consistently with the Lisp reader.
6963 (digit_to_number): Move here from data.c. Make it static inline.
6964 (E_CHAR, EXP_INT): Remove, replacing with ...
6965 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6966 (string_to_number): New function, replacing isfloat_string.
6967 This function checks for valid syntax and produces the resulting
6968 Lisp float number too. Rework it so that string-to-number
6969 no longer mishandles examples like "1.0e+". Use strtoumax,
6970 so that overflow for non-base-10 numbers is reported only when
6971 there's no portable and simple way to convert to floating point.
6972
6973 * textprop.c (set_text_properties_1): Rewrite for clarity,
6974 and to avoid GCC warning about integer overflow.
6975
6976 * intervals.h (struct interval): Use EMACS_INT for members
6977 where EMACS_UINT might cause problems. See
6978 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6979 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6980 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6981 All uses changed.
6982 (offset_intervals): Tell GCC not to worry about length overflow
6983 when negating a negative length.
6984
6985 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6986 (overrun_check_free): Likewise.
6987
6988 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6989 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6990 word size.
6991
6992 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6993 (gnutls_make_error): Rename local to avoid shadowing.
6994 (gnutls_emacs_global_deinit): ifdef out; not used.
6995 (Fgnutls_boot): Use const for pointer to readonly storage.
6996 Comment out unused local. Fix pointer signedness problems.
6997
6998 * lread.c (openp): Don't stuff size_t into an 'int'.
6999 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7000 about possible signed overflow.
7001
7002 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7003 (GDK_KEY_g): Don't define if already defined.
7004 (xg_prepare_tooltip): Avoid pointer signedness problem.
7005 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7006
7007 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7008 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7009
7010 * xfns.c (Fx_window_property): Simplify a bit,
7011 to make a bit faster and to avoid GCC 4.6.0 warning.
7012 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7013
7014 * fns.c (internal_equal): Don't assume size_t fits in int.
7015
7016 * alloc.c (compact_small_strings): Tighten assertion a little.
7017
7018 Replace pEd with more-general pI, and fix some printf arg casts.
7019 * lisp.h (pI): New macro, generalizing old pEd macro to other
7020 conversion specifiers. For example, use "...%"pI"d..." rather
7021 than "...%"pEd"...".
7022 (pEd): Remove. All uses replaced with similar uses of pI.
7023 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
7024 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7025 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7026 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7027 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7028 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7029 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7030 64-bit hosts.
7031 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7032 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7033 * print.c (safe_debug_print, print_object): Likewise.
7034 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7035 to int.
7036 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7037 avoiding the 0 flag, which is not portable.
7038 * process.c (Fmake_network_process): Use pI to avoid cast.
7039 * region-cache.c (pp_cache): Likewise.
7040 * xdisp.c (decode_mode_spec): Likewise.
7041 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7042 behavior on 64-bit hosts with printf arg.
7043 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
7044 (x_stop_queuing_selection_requests): Likewise.
7045 (x_get_window_property): Don't truncate byte count to an 'int'
7046 when tracing.
7047
7048 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7049 here, since it parses constructs like leading '-' and spaces,
7050 which are not wanted; and it overflows with large numbers.
7051 Instead, simply match F[0-9]+, which is what is wanted anyway.
7052
7053 * alloc.c: Remove unportable assumptions about struct layout.
7054 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7055 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7056 (allocate_vectorlike, make_pure_vector): Use the new macros,
7057 plus offsetof, to remove unportable assumptions about struct layout.
7058 These assumptions hold on all porting targets that I know of, but
7059 they are not guaranteed, they're easy to remove, and removing them
7060 makes further changes easier.
7061
7062 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7063 This doesn't fix a bug but makes the code clearer.
7064 (string_overrun_cookie): Now const. Use initializers that
7065 don't formally overflow signed char, to avoid warnings.
7066 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7067 can cause Emacs to crash when string overrun checking is enabled.
7068 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7069 multiple of sizeof (EMACS_INT); it need not be, if
7070 alignof(EMACS_INT) < sizeof (EMACS_INT).
7071 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
7072
7073 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
7074
7075 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7076
7077 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7078
7079 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
7080 supposed to be handshaking. (Bug#8556)
7081 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7082
7083 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
7084
7085 * lisp.h (Qdebug): List symbol.
7086 * eval.c (Qdebug): Restore global linkage.
7087 * keyboard.c (debug-on-event): New variable.
7088 (handle_user_signal): Break into debugger when debug-on-event
7089 matches the current signal symbol.
7090
7091 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7092
7093 * alloc.c (check_sblock, check_string_bytes)
7094 (check_string_free_list): Convert to standard C.
7095
7096 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7097
7098 * w32.c (emacs_gnutls_push): Fix typo.
7099
7100 2011-04-25 Eli Zaretskii <eliz@gnu.org>
7101
7102 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7103 "cast to pointer from integer of different size".
7104
7105 Improve doprnt and its use in verror. (Bug#8545)
7106 * doprnt.c (doprnt): Document the set of format control sequences
7107 supported by the function. Use SAFE_ALLOCA instead of always
7108 using `alloca'.
7109
7110 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7111 is one byte too soon. Don't use xrealloc; instead xfree and
7112 xmalloc anew.
7113
7114 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7115
7116 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7117 callbacks stage.
7118
7119 * gnutls.c: Renamed global_initialized to
7120 gnutls_global_initialized. Added internals for the
7121 :verify-hostname-error, :verify-error, and :verify-flags
7122 parameters of `gnutls-boot' and documented those parameters in the
7123 docstring. Start callback support.
7124 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7125 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7126 on error. Return error code.
7127 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7128 (emacs_gnutls_read): Likewise.
7129 (Fgnutls_boot): Return handshake error code.
7130 (emacs_gnutls_handle_error): New function.
7131 (wsaerror_to_errno): Likewise.
7132
7133 * w32.h (emacs_gnutls_pull): Add prototype.
7134 (emacs_gnutls_push): Likewise.
7135
7136 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7137 (emacs_gnutls_push): Likewise.
7138
7139 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7140
7141 * process.c (wait_reading_process_output): Check if GnuTLS
7142 buffered some data internally if no FDs are set for TLS
7143 connections.
7144
7145 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7146 (LIBS): Link to USER_LIBS.
7147 ($(BLD)/gnutls.$(0)): New target.
7148
7149 2011-04-24 Eli Zaretskii <eliz@gnu.org>
7150
7151 * xdisp.c (handle_single_display_spec): Rename the
7152 display_replaced_before_p argument into display_replaced_p, to
7153 make it consistent with the commentary. Fix typos in the
7154 commentary.
7155
7156 * textprop.c (syms_of_textprop): Remove dead code.
7157 (copy_text_properties): Delete obsolete commentary about an
7158 interface that was deleted long ago. Fix typos in the description
7159 of arguments.
7160
7161 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7162 to changes in oldXMenu/XMenu.h from 2011-04-16.
7163 <menu_help_message, prev_menu_help_message>: Constify.
7164 (IT_menu_make_room): menu->help_text is now `const char **';
7165 adjust.
7166
7167 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7168 to changes in oldXMenu/XMenu.h from 2011-04-16.
7169 (struct XMenu): Declare `help_text' `const char **'.
7170
7171 * xfaces.c <Qunspecified>: Make extern again.
7172
7173 * syntax.c: Include sys/types.h before including regex.h, as
7174 required by Posix.
7175
7176 * doc.c (get_doc_string): Improve the format passed to `error'.
7177
7178 * doprnt.c (doprnt): Improve commentary.
7179
7180 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7181
7182 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7183 them with etags.
7184
7185 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7186 changes in globals.h immediately force recompilation.
7187 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7188 $(CURDIR)/s/ms-w32.h.
7189 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
7190
7191 * character.c (Fchar_direction): Function deleted.
7192 (syms_of_character): Don't defsubr it.
7193 <char-direction-table>: Deleted.
7194
7195 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7196
7197 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7198 * doprnt.c: Include limits.h.
7199 (SIZE_MAX): New macro.
7200 (doprnt): Return a size_t value. 2nd arg is now size_t.
7201 Many local variables are now size_t instead of int or unsigned.
7202 Improve overflow protection. Support `l' modifier for integer
7203 conversions. Support %l conversion. Don't assume an EMACS_INT
7204 argument for integer conversions and for %c.
7205
7206 * lisp.h (doprnt): Restore prototype.
7207
7208 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7209 $(SRC)/character.h.
7210
7211 * Makefile.in (base_obj): Add back doprnt.o.
7212
7213 * deps.mk (doprnt.o): Add back prerequisites.
7214 (callint.o): Depend on character.h.
7215
7216 * eval.c (internal_lisp_condition_case): Include the handler
7217 representation in the error message.
7218 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7219 when breaking from the loop.
7220
7221 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7222
7223 * callint.c (Fcall_interactively): When displaying error message
7224 about invalid control letter, pass the character's codepoint, not
7225 a pointer to its multibyte form. Improve display of the character
7226 in octal and display also its hex code.
7227
7228 * character.c (char_string): Use %x to display the (unsigned)
7229 codepoint of an invalid character, to avoid displaying a bogus
7230 negative value.
7231
7232 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7233 `error', not SYMBOL_NAME itself.
7234
7235 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7236 character arguments to `error'.
7237
7238 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7239 to `error' in error message about FINAL_CHAR argument. Make sure
7240 FINAL_CHAR is a character, and use %c when it is passed as
7241 argument to `error'.
7242
7243 2011-04-23 Eli Zaretskii <eliz@gnu.org>
7244
7245 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7246
7247 * w32.c: Include <time.h>.
7248 (sys_localtime): New function.
7249
7250 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
7251
7252 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7253
7254 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
7255
7256 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
7257
7258 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7259 zombies (Bug#8467).
7260
7261 2011-04-19 Eli Zaretskii <eliz@gnu.org>
7262
7263 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7264 gl_state.e_property when gl_state.object is Qt.
7265
7266 * insdel.c (make_gap_larger): Remove limitation of buffer size
7267 to <= INT_MAX.
7268
7269 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
7270
7271 * xdisp.c (lookup_glyphless_char_display)
7272 (produce_glyphless_glyph): Handle cons cell entry in
7273 glyphless-char-display.
7274 (Vglyphless_char_display): Document it.
7275
7276 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7277 glyphless-char-display.
7278
7279 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
7280
7281 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7282
7283 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7284
7285 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7286 definition for no-X builds.
7287
7288 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
7289
7290 Static checks with GCC 4.6.0 and non-default toolkits.
7291
7292 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7293
7294 * process.c (keyboard_bit_set): Define only if SIGIO.
7295 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7296 (send_process): Repair possible setjmp clobbering.
7297
7298 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7299
7300 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7301
7302 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7303
7304 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7305 Define only if needed.
7306
7307 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7308 by pacifying GCC about it. Maybe it's time to retire it?
7309 * xfaces.c (USG, __TIMEVAL__): Likewise.
7310
7311 * dispextern.h (struct redisplay_interface): Rename param
7312 to avoid shadowing.
7313 * termhooks.h (struct terminal): Likewise.
7314 * xterm.c (xembed_send_message): Likewise.
7315
7316 * insdel.c (make_gap_smaller): Define only if
7317 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7318
7319 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7320 it.
7321
7322 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7323 so that we aren't warned about unused symbols.
7324
7325 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7326
7327 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7328
7329 * xfns.c (x_real_positions): Mark locals as initialized.
7330
7331 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7332
7333 * xterm.c: Fix problems found by static analysis with other toolkits.
7334 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
7335 (x_dispatch_event): Declare static if USE_GTK, and
7336 define if USE_GTK || USE_X_TOOLKIT.
7337 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
7338 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
7339 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7340 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
7341
7342 * xmenu.c (menu_help_callback): Pointer type fixes.
7343 Use const pointers when pointing at readonly data. Avoid pointer
7344 signedness clashes.
7345 (FALSE): Remove unused macro.
7346 (update_frame_menubar): Remove unused decl.
7347
7348 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7349
7350 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7351 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7352 (single_menu_item): Rename local to avoid shadowing.
7353
7354 * keyboard.c (make_lispy_event): Remove unused local var.
7355
7356 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7357 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7358
7359 * bitmaps: Change bitmaps from unsigned char back to the X11
7360 compatible char. Avoid the old compiler warnings about
7361 out-of-range initializers by using, for example, '\xab' rather
7362 than 0xab.
7363
7364 * xgselect.c (xgselect_initialize): Check vs interface
7365 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7366
7367 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7368
7369 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7370 to read-only memory.
7371
7372 * fns.c (vector): Remove; this old hack is no longer needed.
7373
7374 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
7375 Remove unused var.
7376 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
7377
7378 * xrdb.c (x_load_resources): Omit unused local.
7379
7380 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
7381 (x_window): Rename locals to avoid shadowing.
7382 (USG): Use the kludged USG macro, to pacify gcc.
7383
7384 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
7385 (x_term_init): Remove local to avoid shadowing.
7386
7387 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
7388
7389 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7390 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7391
7392 2011-04-16 Eli Zaretskii <eliz@gnu.org>
7393
7394 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7395
7396 Fix regex.c, syntax.c and friends for buffers > 2GB.
7397 * syntax.h (struct gl_state_s): Declare character position members
7398 EMACS_INT.
7399
7400 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7401
7402 * textprop.c (verify_interval_modification, interval_of):
7403 Declare arguments EMACS_INT.
7404
7405 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7406 EMACS_INT.
7407
7408 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7409
7410 * indent.c (Fvertical_motion): Local variable it_start is now
7411 EMACS_INT.
7412
7413 * regex.c (re_match, re_match_2, re_match_2_internal)
7414 (bcmp_translate, regcomp, regexec, print_double_string)
7415 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7416 (re_compile_pattern, re_exec): Declare arguments and local
7417 variables `size_t' and `ssize_t' and return values `regoff_t', as
7418 appropriate.
7419 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7420 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7421 <compile_stack_type>: `size' and `avail' are now `size_t'.
7422
7423 * regex.h <regoff_t>: Use ssize_t, not int.
7424 (re_search, re_search_2, re_match, re_match_2): Arguments that
7425 specify buffer/string position and length are now ssize_t and
7426 size_t. Return type is regoff_t.
7427
7428 2011-04-16 Ben Key <bkey76@gmail.com>
7429
7430 * nsfont.m: Fixed bugs in ns_get_family and
7431 ns_descriptor_to_entity that were caused by using free to
7432 deallocate memory blocks that were allocated by xmalloc (via
7433 xstrdup). This caused Emacs to crash when compiled with
7434 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7435 --enable-checking=xmallocoverrun). xfree is now used to
7436 deallocate these memory blocks.
7437
7438 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
7439
7440 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7441
7442 emacs_write: Accept and return EMACS_INT for sizes.
7443 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7444 et seq.
7445 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7446 Accept and return EMACS_INT.
7447 (emacs_gnutls_write): Return the number of bytes written on
7448 partial writes.
7449 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
7450 (emacs_read, emacs_write): Remove check for negative size, as the
7451 Emacs source code has been audited now.
7452 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7453 (emacs_read, emacs_write): Use it.
7454 * process.c (send_process): Adjust to the new signatures of
7455 emacs_write and emacs_gnutls_write. Do not attempt to store
7456 a byte offset into an 'int'; it might overflow.
7457 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
7458
7459 * sound.c: Don't assume sizes fit in 'int'.
7460 (struct sound_device.period_size, alsa_period_size):
7461 Return EMACS_INT, not int.
7462 (struct sound_device.write, vox_write, alsa_write):
7463 Accept EMACS_INT, not int.
7464 (wav_play, au_play): Use EMACS_INT to store sizes and to
7465 record read return values.
7466
7467 2011-04-15 Ben Key <bkey76@gmail.com>
7468
7469 * keyboard.c (Qundefined): Don't declare static since it is used
7470 in nsfns.m.
7471 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7472 static since they are used in nsfont.m.
7473
7474 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7475
7476 * process.c (Qprocessp): Don't declare static.
7477 * lisp.h (Qprocessp): Declare again.
7478
7479 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
7480
7481 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7482
7483 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7484
7485 Improve C-level modularity by making more things 'static'.
7486
7487 Don't publish debugger-only interfaces to other modules.
7488 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7489 (verify_bytepos, count_markers): Move decls to the only modules
7490 that need them.
7491 * region-cache.h (pp_cache): Likewise.
7492 * window.h (check_all_windows): Likewise.
7493 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7494
7495 * sysdep.c (croak): Now static, if
7496 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7497 * syssignal.h (croak): Declare only if not static.
7498
7499 * alloc.c (refill_memory_reserve): Now static if
7500 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7501 * lisp.h (refill_memory_reserve): Declare only if not static.
7502
7503 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7504 Define only if USE_LUCID.
7505
7506 * xrdb.c (x_customization_string, x_rm_string): Now static.
7507
7508 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7509 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7510
7511 * xdisp.c (draw_row_with_mouse_face): Now static.
7512 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7513
7514 * window.h (check_all_windows): Mark externally visible.
7515
7516 * window.c (window_deletion_count): Now static.
7517
7518 * undo.c: Make symbols static if they're not exported.
7519 (last_undo_buffer, last_boundary_position, pending_boundary):
7520 Now static.
7521
7522 * textprop.c (interval_insert_behind_hooks): Now static.
7523 (interval_insert_in_front_hooks): Likewise.
7524
7525 * term.c: Make symbols static if they're not exported.
7526 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7527 (max_frame_lines, tty_set_terminal_modes):
7528 (tty_reset_terminal_modes, tty_turn_off_highlight):
7529 (get_tty_terminal): Now static.
7530 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7531 * termhooks.h (term_mouse_moveto): Do not declare if
7532 HAVE_WINDOW_SYSTEM.
7533 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7534 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7535
7536 * sysdep.c: Make symbols static if they're not exported.
7537 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7538 Now static.
7539 (sigprocmask_set, full_mask): Remove; unused.
7540 (wait_debugging): Mark as visible.
7541 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7542 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7543
7544 * syntax.c (syntax_temp): Define only if !__GNUC__.
7545
7546 * sound.c (current_sound_device, current_sound): Now static.
7547
7548 * search.c (searchbufs, searchbuf_head): Now static.
7549
7550 * scroll.c (scroll_cost): Remove; unused.
7551 * dispextern.h (scroll_cost): Remove decl.
7552
7553 * region-cache.h (pp_cache): Mark as externally visible.
7554
7555 * process.c: Make symbols static if they're not exported.
7556 (process_tick, update_tick, create_process, chan_process):
7557 (Vprocess_alist, proc_buffered_char, datagram_access):
7558 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7559 (deactivate_process): Mark defn as static, as well as decl.
7560 * lisp.h (create_process): Remove decl.
7561 * process.h (chan_process, Vprocess_alist): Remove decls.
7562
7563 * print.c: Make symbols static if they're not exported.
7564 (print_depth, new_backquote_output, being_printed, print_buffer):
7565 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7566 (print_interval, print_number_index, initial_stderr_stream):
7567 Now static.
7568 * lisp.h (Fprinc): Remove decl.
7569 (debug_output_compilation_hack): Mark as externally visible.
7570
7571 * sysdep.c (croak): Move decl from here to syssignal.h.
7572 * syssignal.h (croak): Put it here, so the API can be checked when
7573 'croak' is called from dissociate_if_controlling_tty.
7574
7575 * minibuf.c: Make symbols static if they're not exported.
7576 (minibuf_save_list, choose_minibuf_frame): Now static.
7577 * lisp.h (choose_minibuf_frame): Remove decl.
7578
7579 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7580
7581 * lread.c: Make symbols static if they're not exported.
7582 (read_objects, initial_obarray, oblookup_last_bucket_number):
7583 Now static.
7584 (make_symbol): Remove; unused.
7585 * lisp.h (initial_obarray, make_symbol): Remove decls.
7586
7587 * keyboard.c: Make symbols static if they're not exported.
7588 (single_kboard, recent_keys_index, total_keys, recent_keys):
7589 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7590 (this_single_command_key_start, echoing, last_auto_save):
7591 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7592 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7593 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7594 (Vlispy_mouse_stem, double_click_count):
7595 Now static.
7596 (force_auto_save_soon): Define only if SIGDANGER.
7597 (ignore_mouse_drag_p): Now static if
7598 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7599 (print_help): Remove; unused.
7600 (stop_character, last_timer_event): Mark as externally visible.
7601 * keyboard.h (ignore_mouse_drag_p): Declare only if
7602 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7603 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7604 * lisp.h (echoing): Remove decl.
7605 (force_auto_save_soon): Declare only if SIGDANGER.
7606 * xdisp.c (redisplay_window): Simplify code, to make it more
7607 obvious that ignore_mouse_drag_p is not accessed if !defined
7608 USE_GTK && !defined HAVE_NS.
7609
7610 * intervals.c: Make symbols static if they're not exported.
7611 (merge_properties_sticky, merge_interval_right, delete_interval):
7612 Now static.
7613 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7614
7615 * insdel.c: Make symbols static if they're not exported.
7616 However, leave prepare_to_modify_buffer alone. It's never
7617 called from outside this function, but that appears to be a bug.
7618 (combine_after_change_list, combine_after_change_buffer):
7619 (adjust_after_replace, signal_before_change): Now static.
7620 (adjust_after_replace_noundo): Remove; unused.
7621 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
7622 (signal_before_change): Remove decls.
7623
7624 * indent.c (val_compute_motion, val_vmotion): Now static.
7625
7626 * image.c: Make symbols static if they're not exported.
7627 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7628 if USE_GTK.
7629 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7630 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7631
7632 * fringe.c (standard_bitmaps): Now static.
7633 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7634
7635 * frame.c: Make symbols static if they're not exported.
7636 (x_report_frame_params, make_terminal_frame): Now static.
7637 (get_frame_param): Now static, unless HAVE_NS.
7638 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7639 (x_get_resource_string): Remove; not used.
7640 * frame.h (make_terminal_frame, x_report_frame_params):
7641 (x_get_resource_string); Remove decls.
7642 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7643 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7644
7645 * font.c, fontset.c: Make symbols static if they're not exported.
7646 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7647 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7648 * font.c (font_close_object): Now static.
7649 * font.h (font_close_object): Remove.
7650 * fontset.c (FONTSET_OBJLIST): Remove.
7651 (free_realized_fontset) #if-0 the body, which does nothing.
7652 (face_suitable_for_char_p): #if-0, as it's never called.
7653 * fontset.h (face_suitable_for_char_p): Remove decl.
7654 * xfaces.c (face_at_string_position):
7655 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
7656 since 0 is always ASCII.
7657
7658 * fns.c (weak_hash_tables): Now static.
7659
7660 * fileio.c: Make symbols static if they're not exported.
7661 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7662 (Vwrite_region_annotation_buffers): Now static.
7663
7664 * eval.c: Make symbols static if they're not exported.
7665 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7666 * lisp.h (backtrace_list): Remove decl.
7667
7668 * emacs.c: Make symbols static if they're not exported.
7669 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7670 (fatal_error_code, fatal_error_signal_hook, standard_args):
7671 Now static.
7672 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7673 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7674 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7675 * lisp.h (fatal_error_signal_hook): Remove decl.
7676 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7677
7678 * editfns.c: Move a (normally-unused) function to its only use.
7679 * editfns.c, lisp.h (get_operating_system_release): Remove.
7680 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7681 worth the hassle of breaking this out.
7682
7683 * xterm.c: Make symbols static if they're not exported.
7684 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7685 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7686 (x_destroy_window, x_delete_display):
7687 Now static.
7688 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7689 (x_mouse_leave): Remove; unused.
7690 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7691 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7692 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7693 Remove decls.
7694 (x_mouse_leave): Declare only if WINDOWSNT.
7695 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7696 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7697 USE_X_TOOLKIT.
7698
7699 * ftxfont.c: Make symbols static if they're not exported.
7700 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7701 HAVE_FREETYPE.
7702 * font.h (ftxfont_driver): Likewise.
7703
7704 * xfns.c: Make symbols static if they're not exported.
7705 (x_last_font_name, x_display_info_for_name):
7706 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7707 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7708 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7709 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7710 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7711 (last_show_tip_args): Now static.
7712 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7713 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7714 (x_screen_planes): Remove; unused.
7715 * dispextern.h (x_screen_planes): Remove decl.
7716
7717 * dispnew.c: Make symbols static if they're not exported.
7718 * dispextern.h (redraw_garbaged_frames, scrolling):
7719 (increment_row_positions): Remove.
7720 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7721 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7722 Now static.
7723 (redraw_garbaged_frames): Remove; unused.
7724
7725 * xfaces.c: Make symbols static if they're not exported.
7726 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7727 Remove decls.
7728 * xterm.h (defined_color): Remove decls.
7729 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7730 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7731 (menu_face_changed_default, defined_color, free_realized_face):
7732 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7733 (ascii_face_of_lisp_face): Remove; unused.
7734
7735 * xdisp.c: Make symbols static if they're not exported.
7736 * dispextern.h (scratch_glyph_row, window_box_edges):
7737 (glyph_to_pixel_coords, set_cursor_from_row):
7738 (get_next_display_element, set_iterator_to_next):
7739 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7740 (show_mouse_face): Remove decls
7741 * frame.h (message_buf_print): Likewise.
7742 * lisp.h (pop_message, set_message, check_point_in_composition):
7743 Likewise.
7744 * xterm.h (set_vertical_scroll_bar): Likewise.
7745 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7746 (message_buf_print, scratch_glyph_row, displayed_buffer):
7747 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7748 (get_next_display_element, show_mouse_face, window_box_edges):
7749 (frame_to_window_pixel_xy, check_point_in_composition):
7750 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7751 (glyph_to_pixel_coords): Remove; unused.
7752
7753 * dired.c (file_name_completion): Now static.
7754
7755 * dbusbind.c (xd_in_read_queued_messages): Now static.
7756
7757 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7758 * data.c (circular_list_error): Remove.
7759
7760 * commands.h (last_point_position, last_point_position_buffer):
7761 (last_point_position_window): Remove decls.
7762 * keyboard.c: Make these variables static.
7763
7764 * coding.h (coding, code_convert_region, encode_coding_gap):
7765 Remove decls.
7766 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7767 (iso_code_class, detect_coding, code_convert_region): Now static.
7768 (encode_coding_gap): Remove; unused.
7769
7770 * chartab.c (chartab_chars, chartab_bits): Now static.
7771
7772 * charset.h (charset_iso_8859_1): Remove decl.
7773 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7774 Now static.
7775
7776 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7777 * ccl.c (Vccl_program_table): Now static.
7778 (check_ccl_update): Remove; unused.
7779
7780 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7781 * category.h: ... from here.
7782 * category.c (check_category_table, set_category_set): Now static.
7783
7784 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7785 * lisp.h: Remove these decls.
7786
7787 * buffer.c (buffer_count): Remove unused var.
7788
7789 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7790 so that it's not optimized away.
7791 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7792 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7793 exported only to the debugger.
7794
7795 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
7796 * atimer.h (run_all_atimers): Remove; not exported.
7797
7798 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7799 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7800 was inaccessible from Lisp.
7801 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7802 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7803
7804 alloc.c: Import and export fewer symbols, and remove unused items.
7805 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7806 is defined.
7807 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7808 it's not optimized away by whole-program optimization.
7809 (message_enable_multibyte, free_misc): Remove.
7810 (catchlist, handlerlist, mark_backtrace):
7811 Declare only if BYTE_MARK_STACK.
7812 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7813 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7814 (message_enable_multibyte): Remove decl.
7815 (free_misc, interval_free_list, float_block, float_block_index):
7816 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7817 (cons_free_list, last_marked_index):
7818 Now static.
7819 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7820 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7821 (mark_backtrace): Define only if BYTE_MARK_STACK.
7822 * xdisp.c (message_enable_multibyte): Now static.
7823
7824 Declare Lisp_Object Q* variables to be 'static' if not exported.
7825 This makes it easier for human readers (and static analyzers)
7826 to see whether these variables are used from other modules.
7827 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7828 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7829 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7830 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7831 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7832 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7833 * xmenu.c, xselect.c:
7834 Declare Q* vars static if they are not used in other modules.
7835 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7836 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7837 Remove decls of unexported vars.
7838 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7839
7840 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7841
7842 Make Emacs functions such as Fatom 'static' by default.
7843 This makes it easier for human readers (and static analyzers)
7844 to see whether these functions can be called from other modules.
7845 DEFUN now defines a static function. To make the function external
7846 so that it can be used in other C modules, use the new macro DEFUE.
7847 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7848 (Finit_image_library):
7849 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7850 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7851 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7852 Remove decls, since these functions are now static.
7853 (Funintern, Fget_internal_run_time): New decls, since these functions
7854 were already external.
7855
7856 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7857 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7858 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7859 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7860 * keyboard.c, keymap.c, lread.c:
7861 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7862 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7863 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7864 Mark functions with DEFUE instead of DEFUN,
7865 if they are used in other modules.
7866 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7867 decls for now-static functions.
7868 * buffer.h (Fdelete_overlay): Remove decl.
7869 * callproc.c (Fgetenv_internal): Mark as internal.
7870 * composite.c (Fremove_list_of_text_properties): Remove decl.
7871 (Fcomposition_get_gstring): New forward static decl.
7872 * composite.h (Fcomposite_get_gstring): Remove decl.
7873 * dired.c (Ffile_attributes): New forward static decl.
7874 * doc.c (Fdocumntation_property): New forward static decl.
7875 * eval.c (Ffetch_bytecode): New forward static decl.
7876 (Funintern): Remove extern decl; now in .h file where it belongs.
7877 * fileio.c (Fmake_symbolic_link): New forward static decl.
7878 * image.c (Finit_image_library): New forward static decl.
7879 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7880 * intervals.h (Fprevious_property_change):
7881 (Fremove_list_of_text_properties): Remove decls.
7882 * keyboard.c (Fthis_command_keys): Remove decl.
7883 (Fcommand_execute): New forward static decl.
7884 * keymap.c (Flookup_key): New forward static decl.
7885 (Fcopy_keymap): Now static.
7886 * keymap.h (Flookup_key): Remove decl.
7887 * process.c (Fget_process): New forward static decl.
7888 (Fprocess_datagram_address): Mark as internal.
7889 * syntax.c (Fsyntax_table_p): New forward static decl.
7890 (skip_chars): Remove duplicate decl.
7891 * textprop.c (Fprevious_property_change): New forward static decl.
7892 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7893 Now internal.
7894 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7895 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7896
7897 * editfns.c (Fformat): Remove unreachable code.
7898
7899 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7900
7901 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7902 change. (Bug#8496)
7903
7904 2011-04-13 Eli Zaretskii <eliz@gnu.org>
7905
7906 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7907 when at ZV. (Bug#8487)
7908
7909 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7910
7911 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7912 (Bug#8437)
7913 * keyboard.c (parse_tool_bar_item): Likewise.
7914 * sound.c (sound_cleanup, alsa_close): Likewise.
7915 * termcap.c (tgetent): Likewise.
7916 * xfns.c (x_default_font_parameter): Likewise.
7917 * xsettings.c (read_and_apply_settings): Likewise.
7918
7919 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7920 (overrun_check_free): Protoize.
7921
7922 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7923
7924 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7925 since callers should never pass a negative size.
7926 Change the signature to match that of plain 'read' and 'write'; see
7927 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7928 * lisp.h: Update prototypes of emacs_write and emacs_read.
7929
7930 2011-04-11 Eli Zaretskii <eliz@gnu.org>
7931
7932 * xdisp.c (redisplay_window): Don't try to determine the character
7933 position of the scroll margin if the window start point w->startp
7934 is outside the buffer's accessible region. (Bug#8468)
7935
7936 2011-04-10 Eli Zaretskii <eliz@gnu.org>
7937
7938 Fix write-region and its subroutines for buffers > 2GB.
7939 * fileio.c (a_write, e_write): Modify declaration of arguments and
7940 local variables to support buffers larger than 2GB.
7941 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7942
7943 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7944 argument, local variables, and return value.
7945
7946 * lisp.h: Update prototypes of emacs_write and emacs_read.
7947
7948 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7949
7950 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
7951
7952 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7953
7954 Fix more problems found by GCC 4.6.0's static checks.
7955
7956 * xdisp.c (vmessage): Use a better test for character truncation.
7957
7958 * charset.c (load_charset_map): <, not <=, for optimization,
7959 and to avoid potential problems with integer overflow.
7960 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
7961 * casetab.c (set_identity, shuffle): Likewise.
7962 * editfns.c (Fformat): Likewise.
7963 * syntax.c (skip_chars): Likewise.
7964
7965 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7966 This also lets GCC 4.6.0 generate slightly better loop code.
7967
7968 * callint.c (Fcall_interactively): <, not <=, for optimization.
7969 (Fcall_interactively): Count the number of arguments produced,
7970 not the number of arguments given. This is simpler and lets GCC
7971 4.6.0 generate slightly better code.
7972
7973 * ftfont.c: Distingish more carefully between FcChar8 and char.
7974 The previous code passed unsigned char * to a functions like
7975 strlen and xstrcasecmp that expect char *, which does not
7976 conform to the C standard.
7977 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7978 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7979 char * when the C standard requires it.
7980
7981 * keyboard.c (read_char): Remove unused var.
7982
7983 * eval.c: Port to Windows vsnprintf (Bug#8435).
7984 Include <limits.h>.
7985 (SIZE_MAX): Define if the headers do not.
7986 (verror): Do not give up if vsnprintf returns a negative count.
7987 Instead, grow the buffer. This ports to Windows vsnprintf, which
7988 does not conform to C99. Problem reported by Eli Zaretskii.
7989 Also, simplify the allocation scheme, by avoiding the need for
7990 calling realloc, and removing the ALLOCATED variable.
7991
7992 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7993
7994 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7995 But keep the doprint source code for now, as we might revamp it
7996 and use it again (Bug#8435).
7997 * lisp.h (doprnt): Remove.
7998 * Makefile.in (base_obj): Remove doprnt.o.
7999 * deps.mk (doprnt.o): Remove.
8000
8001 error: Print 32- and 64-bit integers portably (Bug#8435).
8002 Without this change, on typical 64-bit hosts error ("...%d...", N)
8003 was used to print both 32- and 64-bit integers N, which relied on
8004 undefined behavior.
8005 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
8006 * lisp.h (error, verror): Mark as printf-like functions.
8007 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8008 Report overflow in size calculations when allocating printf buffer.
8009 Do not truncate output string at its first null byte.
8010 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8011 Truncate the output at a character boundary, since vsnprintf does not
8012 do that.
8013 * charset.c (check_iso_charset_parameter): Convert internal
8014 character to string before calling 'error', since %c now has the
8015 printf meaning.
8016 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8017 overflow when computing char to be passed to 'error'. Do not
8018 pass Lisp_Object to 'error'; pass the integer instead.
8019 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8020 formatted with plain %d.
8021
8022 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8023
8024 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8025
8026 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8027
8028 * xterm.c (x_catch_errors): Remove duplicate declaration.
8029
8030 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8031
8032 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8033
8034 2011-04-10 Jim Meyering <meyering@redhat.com>
8035
8036 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8037 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8038 return ssize_t not "int", and use size_t as the buffer length.
8039 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8040 * gnutls.h: Update declarations.
8041 * process.c (read_process_output): Use ssize_t, to match.
8042 (send_process): Likewise.
8043
8044 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8045
8046 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8047
8048 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
8049
8050 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8051 Use unsigned char, to match FcChar8 type definition.
8052
8053 * xterm.c (handle_one_xevent):
8054 * xmenu.c (create_and_show_popup_menu):
8055 * xselect.c (x_decline_selection_request)
8056 (x_reply_selection_request): Avoid type-punned deref of X events.
8057
8058 2011-04-09 Eli Zaretskii <eliz@gnu.org>
8059
8060 Fix some uses of `int' instead of EMACS_INT.
8061 * search.c (string_match_1, fast_string_match)
8062 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8063 (scan_buffer, find_next_newline_no_quit)
8064 (find_before_next_newline, search_command, Freplace_match)
8065 (Fmatch_data): Make some `int' variables be EMACS_INT.
8066
8067 * xdisp.c (display_count_lines): 3rd argument and return value now
8068 EMACS_INT. All callers changed.
8069 (pint2hrstr): Last argument is now EMACS_INT.
8070
8071 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8072 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8073 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8074 (decode_coding_utf_16, decode_coding_emacs_mule)
8075 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8076 (decode_coding_ccl, decode_coding_charset)
8077 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8078 (decode_coding_iso_2022, decode_coding_emacs_mule)
8079 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8080 <char_offset, last_offset>: Declare EMACS_INT.
8081 (encode_coding_utf_8, encode_coding_utf_16)
8082 (encode_coding_emacs_mule, encode_invocation_designation)
8083 (encode_designation_at_bol, encode_coding_iso_2022)
8084 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8085 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8086 Declare EMACS_INT.
8087 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8088 (encode_invocation_designation): Last argument P_NCHARS is now
8089 EMACS_INT.
8090 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8091 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8092
8093 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8094 All users changed.
8095
8096 * ccl.c (Fccl_execute_on_string): Declare some variables
8097 EMACS_INT.
8098
8099 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
8100
8101 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8102
8103 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8104
8105 * process.c (Fformat_network_address): Doc fix.
8106
8107 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8108
8109 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
8110
8111 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
8112
8113 * keyboard.c (read_char): Call Lisp function help-form-show,
8114 instead of using internal_with_output_to_temp_buffer.
8115 (Qhelp_form_show): New var.
8116 (syms_of_keyboard): Use DEFSYM macro.
8117
8118 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8119
8120 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8121
8122 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
8123
8124 * process.c (Flist_processes): Remove to Lisp.
8125 (list_processes_1): Delete.
8126
8127 2011-04-06 Eli Zaretskii <eliz@gnu.org>
8128
8129 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8130
8131 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8132
8133 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
8134
8135 Fix more problems found by GCC 4.6.0's static checks.
8136
8137 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8138
8139 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8140
8141 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
8142
8143 * xdisp.c (vmessage): Mark as a printf-like function.
8144
8145 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8146
8147 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8148
8149 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8150 printf-like functions.
8151 (tiff_load): Add casts to remove these marks before passing them
8152 to system-supplied API.
8153
8154 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8155
8156 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8157 This avoids several warnings with gcc -Wstrict-overflow.
8158 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8159 directly, rather than having caller test rule sign. This avoids
8160 some unnecessary tests.
8161 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8162 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8163 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
8164
8165 * xfont.c (xfont_text_extents): Remove var that was set but not used.
8166 (xfont_open): Avoid unnecessary tests.
8167
8168 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8169
8170 * composite.h, composite.c (composition_gstring_put_cache):
8171 Use EMACS_INT, not int, for length.
8172
8173 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8174 breaking out part of COMPOSITION_DECODE_RULE.
8175 (COMPOSITION_DECODE_RULE): Use it.
8176 * composite.c (get_composition_id): Remove unused local vars,
8177 by using the new macro.
8178
8179 * textprop.c (set_text_properties_1): Change while to do-while,
8180 since the condition is always true at first.
8181
8182 * intervals.c (graft_intervals_into_buffer): Mark var as used.
8183 (interval_deletion_adjustment): Return unsigned value.
8184 All uses changed.
8185
8186 * process.c (list_processes_1, create_pty, read_process_output):
8187 (exec_sentinel): Remove vars that were set but not used.
8188 (create_pty): Remove unnecessary "volatile"s.
8189 (Fnetwork_interface_info): Avoid possibility of int overflow.
8190 (read_process_output): Do adaptive read buffering even if carryover.
8191 (read_process_output): Simplify nbytes computation if buffered.
8192
8193 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8194
8195 * syntax.c (scan_words): Remove var that was set but not used.
8196 (update_syntax_table): Use unsigned instead of int.
8197
8198 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
8199 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
8200 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
8201
8202 * print.c (print_error_message): Avoid int overflow.
8203
8204 * font.c (font_list_entities): Redo for clarity,
8205 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8206
8207 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
8208 (font_score): Avoid potential overflow in diff calculation.
8209
8210 * fns.c (substring_both): Remove var that is set but not used.
8211 (sxhash): Redo loop for clarity and to avoid wraparound warning.
8212
8213 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8214
8215 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8216 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8217 can always succeed if overflow has undefined behavior.
8218
8219 * search.c (boyer_moore, wordify): Remove vars set but not used.
8220 (wordify): Omit three unnecessary tests.
8221
8222 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8223 All callers changed. This avoids the need for an unused var.
8224
8225 * casefiddle.c (casify_region): Remove var that is set but not used.
8226
8227 * dired.c (file_name_completion): Remove var that is set but not used.
8228
8229 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8230
8231 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
8232 (Finsert_file_contents): Remove unnecessary code checking fd.
8233
8234 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8235 Check for integer overflow on size calculations.
8236
8237 * buffer.c (Fprevious_overlay_change): Remove var that is set
8238 but not used.
8239
8240 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8241 Remove vars that are set but not used.
8242 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
8243 (timer_check_2): Mark vars as initialized.
8244
8245 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8246
8247 * image.c (lookup_image): Remove var that is set but not used.
8248 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
8249
8250 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8251 that are set but not used.
8252
8253 * xfns.c (make_invisible_cursor): Don't return garbage
8254 if XCreateBitmapFromData fails (Bug#8410).
8255
8256 * xselect.c (x_get_local_selection, x_handle_property_notify):
8257 Remove vars that are set but not used.
8258
8259 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
8260 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
8261
8262 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8263 Remove var that is set but not used.
8264 (scroll_bar_windows_size): Now size_t, not int.
8265 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8266 Check for overflow.
8267
8268 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8269 (map_tty_color) [!defined MSDOS]: Likewise.
8270
8271 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8272
8273 * coding.c: Remove vars that are set but not used.
8274 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8275 All callers changed.
8276 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8277 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8278 (decode_coding_charset): Remove vars that are set but not used.
8279
8280 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8281 that is set but not used.
8282
8283 * print.c (print_object): Remove var that is set but not used.
8284
8285 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
8286 The gnulib version avoids calling malloc in the usual case,
8287 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8288 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8289 * filelock.c (current_lock_owner): Likewise.
8290 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8291 * sysdep.c: Include allocator.h, careadlinkat.h.
8292 (emacs_no_realloc_allocator): New static constant.
8293 (emacs_readlink): New function.
8294 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8295 ../lib/careadlinkat.h.
8296
8297 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8298
8299 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8300 first non-nil return value).
8301
8302 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8303
8304 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8305 if not defined (Bug#8403).
8306
8307 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8308
8309 * xdisp.c (display_count_lines): Remove parameter `start',
8310 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8311 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8312 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8313 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8314 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8315 and thereabouts. All callers changed.
8316 (get_per_char_metric): Remove parameter `f', unused since
8317 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8318
8319 2011-04-02 Jim Meyering <meyering@redhat.com>
8320
8321 do not dereference NULL upon failed strdup
8322 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8323 (ns_get_family): Likewise.
8324
8325 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
8326
8327 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8328
8329 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8330
8331 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8332 later (Bug#8403).
8333
8334 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8335
8336 Add lexical binding.
8337
8338 * window.c (Ftemp_output_buffer_show): New fun.
8339 (Fsave_window_excursion):
8340 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8341
8342 * lread.c (lisp_file_lexically_bound_p): New function.
8343 (Fload): Bind Qlexical_binding.
8344 (readevalloop): Remove `evalfun' arg.
8345 Bind Qinternal_interpreter_environment.
8346 (Feval_buffer): Bind Qlexical_binding.
8347 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8348 Mark as dynamic.
8349 (syms_of_lread): Declare `lexical-binding'.
8350
8351 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8352
8353 * keyboard.c (eval_dyn): New fun.
8354 (menu_item_eval_property): Use it.
8355
8356 * image.c (parse_image_spec): Use Ffunctionp.
8357
8358 * fns.c (concat, mapcar1): Accept byte-code-functions.
8359
8360 * eval.c (Fsetq): Handle lexical vars.
8361 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8362 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8363 (FletX, Flet): Obey lexical binding.
8364 (Fcommandp): Handle closures.
8365 (Feval): New `lexical' arg.
8366 (eval_sub): New function extracted from Feval. Use it almost
8367 everywhere where Feval was used. Look up vars in lexical env.
8368 Handle closures.
8369 (Ffunctionp): Move from subr.el.
8370 (Ffuncall): Handle closures.
8371 (apply_lambda): Remove `eval_flags'.
8372 (funcall_lambda): Handle closures and new byte-code-functions.
8373 (Fspecial_variable_p): New function.
8374 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8375 but without exporting it to Lisp.
8376
8377 * doc.c (Fdocumentation, store_function_docstring):
8378 * data.c (Finteractive_form): Handle closures.
8379
8380 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8381 interactive spec.
8382
8383 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8384 New byte-codes.
8385 (exec_byte_code): New function extracted from Fbyte_code to handle new
8386 calling convention for byte-code-functions. Add new byte-codes.
8387
8388 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
8389
8390 * alloc.c (Fmake_symbol): Init new `declared_special' field.
8391
8392 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8393
8394 * xdisp.c (redisplay_internal): Fix prototype.
8395
8396 2011-03-31 Eli Zaretskii <eliz@gnu.org>
8397
8398 * xdisp.c (SCROLL_LIMIT): New macro.
8399 (try_scrolling): Use it when setting scroll_limit.
8400 Limit scrolling to 100 screen lines.
8401 (redisplay_window): Even when falling back on "recentering",
8402 position point in the window according to scroll-conservatively,
8403 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8404
8405 (try_scrolling): When point is above the window, allow searching
8406 as far as scroll_max, or one screenful, to compute vertical
8407 distance from PT to the scroll margin position. This prevents
8408 try_scrolling from unnecessarily failing when
8409 scroll-conservatively is set to a value slightly larger than the
8410 window height. Clean up the case of PT below the margin at bottom
8411 of window: scroll_max can no longer be INT_MAX. When aggressive
8412 scrolling is in use, don't let point enter the opposite scroll
8413 margin as result of the scroll.
8414 (syms_of_xdisp) <scroll-conservatively>: Document the
8415 threshold of 100 lines for never-recentering scrolling.
8416
8417 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
8418
8419 * dispextern.h (move_it_by_lines):
8420 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8421 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8422 (message_log_check_duplicate): Remove parameters `prev_bol' and
8423 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8424 (redisplay_internal): Remove parameter `preserve_echo_area',
8425 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8426
8427 * indent.c (Fvertical_motion):
8428 * window.c (window_scroll_pixel_based, Frecenter):
8429 Don't pass `need_y_p' to `move_it_by_lines'.
8430
8431 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8432
8433 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8434 steal a few bits to be more compact.
8435 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8436 Remove unneeded casts.
8437
8438 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8439
8440 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8441
8442 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8443 binding" message (bug#7967).
8444
8445 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8446
8447 Fix more problems found by GCC 4.6.0's static checks.
8448
8449 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8450 Remove unused local var.
8451
8452 * editfns.c (Fmessage_box): Remove unused local var.
8453
8454 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8455 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8456 Omit unused local vars.
8457 * window.c (shrink_windows): Omit unused local var.
8458 * menu.c (digest_single_submenu): Omit unused local var.
8459 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8460 Omit unused local var.
8461
8462 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8463 Don't assume string length fits in int.
8464 (keyremap_step, read_key_sequence): Use size_t for sizes.
8465 (read_key_sequence): Don't check last_real_key_start redundantly.
8466
8467 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8468 instead of alloca (Bug#8344).
8469
8470 * eval.c (Fbacktrace): Don't assume nargs fits in int.
8471 (Fbacktrace_frame): Don't assume nframes fits in int.
8472
8473 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8474
8475 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8476 concerns.
8477
8478 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8479
8480 * cm.c (calccost): Turn while-do into do-while, for clarity.
8481
8482 * keyboard.c (syms_of_keyboard): Use the same style as later
8483 in this function when indexing through an array. This also
8484 works around GCC bug 48267.
8485
8486 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8487
8488 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8489
8490 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8491 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8492
8493 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8494 This avoids undefined behavior on integer overflow, and is a bit
8495 more convenient anyway since it is compared to a size_t variable.
8496
8497 Variadic C functions now count arguments with size_t, not int.
8498 This avoids an unnecessary limitation on 64-bit machines, which
8499 caused (substring ...) to crash on large vectors (Bug#8344).
8500 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8501 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
8502 All variadic functions and their callers changed accordingly.
8503 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8504 * data.c (arith_driver, float_arith_driver): Likewise.
8505 * editfns.c (general_insert_function): Likewise.
8506 * eval.c (struct backtrace.nargs, interactive_p)
8507 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8508 (funcall_lambda, mark_backtrace): Likewise.
8509 * fns.c (concat): Likewise.
8510 * frame.c (x_set_frame_parameters): Likewise.
8511 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8512 0 if not found, not -1. All callers changed.
8513
8514 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8515 (stack_copy_size): Now size_t, not int.
8516 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8517
8518 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8519
8520 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8521 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8522 All callers changed.
8523
8524 * lisp.h (multibyte_char_to_unibyte):
8525 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8526 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8527 * character.h (CHAR_TO_BYTE8):
8528 * cmds.c (internal_self_insert):
8529 * editfns.c (general_insert_function):
8530 * keymap.c (push_key_description):
8531 * search.c (Freplace_match):
8532 * xdisp.c (message_dolog, set_message_1): All callers changed.
8533
8534 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8535
8536 * keyboard.c (safe_run_hook_funcall): New function.
8537 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8538 don't set the hook to nil, but remove the offending function instead.
8539 (Qcommand_hook_internal): Remove, unused.
8540 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8541 Vcommand_hook_internal.
8542
8543 * eval.c (enum run_hooks_condition): Remove.
8544 (funcall_nil, funcall_not): New functions.
8545 (run_hook_with_args): Call each function through a `funcall' argument.
8546 Remove `cond' argument, now redundant.
8547 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8548 (Frun_hook_with_args_until_failure): Adjust accordingly.
8549 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8550
8551 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
8552
8553 * dispextern.h (string_buffer_position): Remove declaration.
8554
8555 * print.c (strout): Remove parameter `multibyte', unused since
8556 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8557
8558 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8559 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8560 All callers changed.
8561
8562 * w32.c (_wsa_errlist): Use braces for struct initializers.
8563
8564 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8565 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8566 All callers changed.
8567 (string_buffer_position): Likewise. Also, make static (it's never
8568 used outside xdisp.c).
8569 (cursor_row_p): Remove parameter `w', unused since
8570 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8571 (decode_mode_spec): Remove parameter `precision', introduced during
8572 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8573 All callers changed.
8574
8575 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8576
8577 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8578
8579 2011-03-27 Anders Lindgren <andlind@gmail.com>
8580
8581 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8582 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8583 (ns_update_auto_hide_menu_bar): New functions.
8584 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8585 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8586 ns_constrain_all_frames.
8587 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8588 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8589
8590 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8591
8592 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8593
8594 2011-03-27 Glenn Morris <rgm@gnu.org>
8595
8596 * syssignal.h: Replace RETSIGTYPE with void.
8597 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8598 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8599 Replace SIGTYPE with void everywhere.
8600 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8601 * s/template.h (SIGTYPE): Remove commented out definition.
8602
8603 2011-03-26 Eli Zaretskii <eliz@gnu.org>
8604
8605 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8606 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8607
8608 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
8609
8610 * w32.c (read_unc_volume): Use parameter `henum', instead of
8611 global variable `wget_enum_handle'.
8612
8613 * keymap.c (describe_vector): Remove parameters `indices' and
8614 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8615 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8616
8617 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8618
8619 * keyboard.c (timer_check): Remove parameter `do_it_now',
8620 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8621 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8622 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8623
8624 * keyboard.c (read_char):
8625 * w32menu.c (w32_menu_display_help):
8626 * xmenu.c (show_help_event, menu_help_callback):
8627 Adjust calls to `show_help_echo'.
8628
8629 * gtkutil.c (xg_maybe_add_timer):
8630 * keyboard.c (readable_events):
8631 * process.c (wait_reading_process_output):
8632 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8633
8634 * insdel.c (adjust_markers_gap_motion):
8635 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8636 (gap_left, gap_right): Don't call it.
8637
8638 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
8639
8640 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8641 incurred during fontification.
8642
8643 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8644
8645 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8646 (DEFVAR_PER_BUFFER): Don't pass it.
8647
8648 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8649 (scrolling_window): Don't pass it.
8650
8651 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
8652
8653 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8654
8655 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8656 and `suffix'.
8657 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8658 of variables specific to SELinux and computation of `encoded_absname'.
8659
8660 * image.c (XPutPixel): Remove unused variable `height'.
8661
8662 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8663
8664 * unexw32.c (get_section_info): Remove unused variable `section'.
8665
8666 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8667 (system_process_attributes): Remove unused variable `sess'.
8668 (sys_read): Remove unused variable `err'.
8669
8670 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8671 (w32_wnd_proc): Remove unused variable `isdead'.
8672 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8673 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8674 (x_create_tip_frame): Remove unused variable `tem'.
8675
8676 * w32inevt.c (w32_console_read_socket):
8677 Remove unused variable `no_events'.
8678
8679 * w32term.c (x_draw_composite_glyph_string_foreground):
8680 Remove unused variable `width'.
8681
8682 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
8683
8684 * w32term.c (x_set_glyph_string_clipping):
8685 Don't pass uninitialized region to CombineRgn.
8686
8687 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
8688
8689 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8690 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8691 (Fx_close_connection): Remove unused variable `i'.
8692
8693 * w32font.c (w32font_draw): Return number of glyphs.
8694 (w32font_open_internal): Remove unused variable `i'.
8695 (w32font_driver): Add missing initializer.
8696
8697 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8698 (fill_in_menu): Remove unused variable `items_added'.
8699
8700 * w32term.c (last_mouse_press_frame): Remove static global variable.
8701 (w32_clip_to_row): Remove unused variable `f'.
8702 (x_delete_terminal): Remove unused variable `i'.
8703
8704 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8705 (NOTHING): Remove unused static global variable.
8706 (uniscribe_check_otf): Remove unused variable `table'.
8707 (uniscribe_font_driver): Add missing initializers.
8708
8709 2011-03-23 Julien Danjou <julien@danjou.info>
8710
8711 * term.c (Fsuspend_tty, Fresume_tty):
8712 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8713 * window.c (temp_output_buffer_show):
8714 * insdel.c (signal_before_change):
8715 * frame.c (Fhandle_switch_frame):
8716 * fileio.c (Fdo_auto_save):
8717 * emacs.c (Fkill_emacs):
8718 * editfns.c (save_excursion_restore):
8719 * cmds.c (internal_self_insert):
8720 * callint.c (Fcall_interactively):
8721 * buffer.c (Fkill_all_local_variables):
8722 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8723 Use Frun_hooks.
8724 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
8725 unconditionally since it does the check itself.
8726
8727 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
8728
8729 Fix more problems found by GCC 4.5.2's static checks.
8730
8731 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8732 the first time through the loop, since we know p0 < p1 then.
8733 This also avoids a gcc -Wstrict-overflow warning.
8734
8735 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8736 leading to a memory leak, possible in functions like
8737 load_charset_map_from_file that can allocate an unbounded number
8738 of objects (Bug#8318).
8739
8740 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8741 that could (at least in theory) be that large.
8742
8743 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8744 This is less likely to overflow, and avoids undefined behavior if
8745 overflow does occur. All callers changed. Use strtoul to scan
8746 for the unsigned long integer.
8747 (pint2hrstr): Simplify and tune code slightly.
8748 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
8749
8750 * scroll.c (do_scrolling): Work around GCC bug 48228.
8751 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8752
8753 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8754 This also avoids a warning with gcc -Wstrict-overflow.
8755 (validate_x_resource_name): Simplify count usage.
8756 This also avoids a warning with gcc -Wstrict-overflow.
8757
8758 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8759 fail (Bug#8306).
8760
8761 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
8762
8763 * process.c (Fmake_network_process): Use socklen_t, not int,
8764 where POSIX says socklen_t is required in portable programs.
8765 This fixes a porting bug on hosts like 64-bit HP-UX, where
8766 socklen_t is wider than int (Bug#8277).
8767 (Fmake_network_process, server_accept_connection):
8768 (wait_reading_process_output, read_process_output):
8769 Likewise.
8770
8771 * process.c: Rename or move locals to avoid shadowing.
8772 (list_processes_1, Fmake_network_process):
8773 (read_process_output_error_handler, exec_sentinel_error_handler):
8774 Rename or move locals.
8775 (Fmake_network_process): Define label "retry_connect" only if needed.
8776 (Fnetwork_interface_info): Fix pointer signedness.
8777 (process_send_signal): Add cast to avoid pointer signedness problem.
8778 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
8779 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
8780
8781 Make tparam.h and terminfo.c consistent.
8782 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8783 Include tparam.h instead, since it declares them.
8784 * cm.h (PC): Remove extern decl; tparam.h now does this.
8785 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8786 * terminfo.c: Include tparam.h, to check interfaces.
8787 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8788 (tparam): Adjust signature to match interface in tparam.h;
8789 this removes some undefined behavior. Check that outstring and len
8790 are zero, which they always are with Emacs.
8791 * tparam.h (PC, BC, UP): New extern decls.
8792
8793 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
8794 (xftfont_open): Rename locals to avoid shadowing.
8795
8796 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
8797 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8798 (OTF_TAG_SYM): Omit macro if not needed.
8799 (ftfont_list): Remove unused local.
8800 (get_adstyle_property, ftfont_pattern_entity):
8801 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8802 Rename locals to avoid shadowing.
8803
8804 * xfont.c (xfont_list_family): Mark var as initialized.
8805
8806 * xml.c (make_dom): Now static.
8807
8808 * composite.c (composition_compute_stop_pos): Rename local to
8809 avoid shadowing.
8810 (composition_reseat_it): Remove unused locals.
8811 (find_automatic_composition, composition_adjust_point): Likewise.
8812 (composition_update_it): Mark var as initialized.
8813 (find_automatic_composition): Mark vars as initialized,
8814 with a FIXME (Bug#8290).
8815
8816 character.h: Rename locals to avoid shadowing.
8817 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8818 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8819 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8820 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8821 to avoid shadowing.
8822
8823 * textprop.c (property_change_between_p): Remove; unused.
8824
8825 * intervals.c (interval_start_pos): Now static.
8826
8827 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8828
8829 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8830 Rename locals to avoid shadowing.
8831
8832 * sound.c (wav_play, au_play, Fplay_sound_internal):
8833 Fix pointer signedness.
8834 (alsa_choose_format): Remove unused local var.
8835 (wav_play): Initialize a variable to 0, to prevent undefined
8836 behavior (Bug#8278).
8837
8838 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8839
8840 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8841
8842 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8843 clobbering (Bug#8298).
8844 * sysdep.c (sys_subshell): Likewise.
8845 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
8846
8847 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8848 This should get cleaned up, so that child_setup has the
8849 same signature on all platforms.
8850
8851 * callproc.c (call_process_cleanup): Now static.
8852 (relocate_fd): Rename locals to avoid shadowing.
8853
8854 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
8855
8856 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8857 not to be necessary, and produces flickering.
8858
8859 2011-03-20 Glenn Morris <rgm@gnu.org>
8860
8861 * config.in: Remove file.
8862
8863 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
8864
8865 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8866 are now in src/globals.h.
8867 (syms_of_minibuf): Remove spurious & from previous change.
8868
8869 2011-03-20 Leo Liu <sdl.web@gmail.com>
8870
8871 * minibuf.c (completing-read-function): New variable.
8872 (completing-read-default): Rename from completing-read.
8873 (completing-read): Call completing-read-function.
8874
8875 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8876
8877 * xfaces.c (Fx_load_color_file):
8878 Read color file from absolute filename (bug#8250).
8879
8880 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
8881
8882 * makefile.w32-in: Update dependencies.
8883
8884 2011-03-17 Eli Zaretskii <eliz@gnu.org>
8885
8886 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8887
8888 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8889
8890 Fix more problems found by GCC 4.5.2's static checks.
8891
8892 * process.c (make_serial_process_unwind, send_process_trap):
8893 (sigchld_handler): Now static.
8894
8895 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8896 That way, the code declares only the vars that it needs.
8897 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8898 * s/cygwin.h (PTY_ITERATION): Likewise.
8899 * s/darwin.h (PTY_ITERATION): Likewise.
8900 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8901
8902 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8903 * process.c (allocate_pty): Don't declare stb unless it's needed.
8904
8905 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
8906 (CONSTANTLIM): Remove; unused.
8907 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8908 Define only if needed.
8909
8910 * unexelf.c (unexec): Name an expression,
8911 to avoid gcc -Wbad-function-cast warning.
8912 Use a different way to cause a compilation error if anyone uses
8913 n rather than nn, a way that does not involve shadowing.
8914 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
8915
8916 * deps.mk (unexalpha.o): Remove; unused.
8917
8918 New file unexec.h, the (simple) interface for unexec (Bug#8267).
8919 * unexec.h: New file.
8920 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8921 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8922 Depend on unexec.h.
8923 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8924 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8925 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
8926 Change as necessary to match prototype in unexec.h.
8927
8928 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8929 shadowing.
8930 (back_comment, skip_chars): Mark vars as initialized.
8931
8932 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8933 Rename locals to avoid shadowing.
8934
8935 * lread.c (read1): Rewrite so as not to use empty "else".
8936 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
8937
8938 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8939
8940 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8941 warning when compiling print.c.
8942
8943 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8944 instead of using an uninitialized var.
8945 (font_sort_entities): Mark var as initialized.
8946
8947 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8948
8949 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8950 pointers to constants.
8951 (font_parse_fcname): Remove unused vars.
8952 (font_delete_unmatched): Now static.
8953 (font_get_spec): Remove; unused.
8954 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8955 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8956 Rename or move locals to avoid shadowing.
8957
8958 * fns.c (require_nesting_list, require_unwind): Now static.
8959 (Ffillarray): Rename locals to avoid shadowing.
8960
8961 * floatfns.c (domain_error2): Define only if needed.
8962 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
8963
8964 * alloc.c (mark_backtrace): Move decl from here ...
8965 * lisp.h: ... to here, so that it can be checked.
8966
8967 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
8968 (Fdefvar): Rewrite so as not to use empty "else".
8969 (lisp_indirect_variable): Name an expression,
8970 to avoid gcc -Wbad-function-cast warning.
8971 (Fdefvar): Rename locals to avoid shadowing.
8972
8973 * callint.c (quotify_arg, quotify_args): Now static.
8974 (Fcall_interactively): Rename locals to avoid shadowing.
8975 Use const pointer when appropriate.
8976
8977 * lisp.h (get_system_name, get_operating_system_release):
8978 Move decls here, to check interfaces.
8979 * process.c (get_operating_system_release): Move decl to lisp.h.
8980 * xrdb.c (get_system_name): Likewise.
8981 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8982 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8983 some of which prompt warnings from gcc -Wbad-function-cast.
8984 (Fformat_time_string, Fencode_time, Finsert_char):
8985 (Ftranslate_region_internal, Fformat):
8986 Rename or remove local vars to avoid shadowing.
8987 (Ftranslate_region_internal): Mark var as initialized.
8988
8989 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8990 avoid shadowing.
8991
8992 * lisp.h (eassert): Check that the argument compiles, even if
8993 ENABLE_CHECKING is not defined.
8994
8995 * data.c (Findirect_variable): Name an expression, to avoid
8996 gcc -Wbad-function-cast warning.
8997 (default_value, arithcompare, arith_driver, arith_error): Now static.
8998 (store_symval_forwarding): Rename local to avoid shadowing.
8999 (Fmake_variable_buffer_local, Fmake_local_variable):
9000 Mark variables as initialized.
9001 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
9002
9003 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
9004 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9005 Rename locals to avoid shadowing.
9006 (mark_stack): Move local variables into the #ifdef region where
9007 they're used.
9008 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9009 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9010 needed otherwise.
9011 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9012 (GC_STRING_CHARS): Remove; not used.
9013 (Fmemory_limit): Cast sbrk's returned value to char *.
9014
9015 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9016 avoids undefined behavior in theory.
9017
9018 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9019
9020 Use functions, not macros, for up- and down-casing (Bug#8254).
9021 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9022 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9023 to use the following functions instead of these macros.
9024 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9025 EMACS_INT, since callers assume the returned value fits in int.
9026 (upcase1): Likewise, for UPCASE_TABLE.
9027 (uppercasep, lowercasep, upcase): New static inline functions.
9028 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
9029 the race-condition problem in the old DOWNCASE.
9030
9031 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9032 Rename locals to avoid shadowing.
9033 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
9034 (regex_compile, re_search_2, re_match_2_internal):
9035 Remove unused local vars.
9036 (FREE_VAR): Rewrite so as not to use empty "else",
9037 which gcc can warn about.
9038 (regex_compile, re_match_2_internal): Mark locals as initialized.
9039 (RETALLOC_IF): Define only if needed.
9040 (WORDCHAR_P): Likewise. This one is never needed, but is used
9041 only in a comment talking about a compiler bug, so put inside
9042 the #if 0 of that comment.
9043 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9044 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9045 Remove; unused.
9046
9047 * search.c (boyer_moore): Rename locals to avoid shadowing.
9048 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9049 (PREV_CHAR_BOUNDARY): Likewise.
9050
9051 * search.c (simple_search): Remove unused var.
9052
9053 * dired.c (compile_pattern): Move decl from here ...
9054 * lisp.h: ... to here, so that it can be checked.
9055 (struct re_registers): New forward decl.
9056
9057 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9058
9059 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9060 All uses changed.
9061 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9062 Rename locals to avoid shadowing.
9063 (Fvertical_motion): Mark locals as initialized.
9064
9065 * casefiddle.c (casify_object, casify_region): Now static.
9066 (casify_region): Mark local as initialized.
9067
9068 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9069
9070 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9071 New macros, so that the caller can use some names other than
9072 gcpro1, gcpro2, etc.
9073 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9074 of the new macros.
9075 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9076 argument, for consistency with GCPRO2_VAR, etc: it is now the
9077 prefix of the variable, not the variable itself. All uses
9078 changed.
9079 * dired.c (directory_files_internal, file_name_completion):
9080 Rename locals to avoid shadowing.
9081
9082 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9083 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9084 dired.c's scmp function, had undefined behavior.
9085 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9086 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9087 * buffer.h: ... to here, because these macros use current_buffer,
9088 and the new implementation with inline functions needs to have
9089 current_buffer in scope now, rather than later when the macros
9090 are used.
9091 (downcase, upcase1): New static inline functions.
9092 (DOWNCASE, UPCASE1): Reimplement using these functions.
9093 This avoids undefined behavior in expressions like
9094 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9095 from race conditions in accessing the global variables
9096 case_temp1 and case_temp2.
9097 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9098 * lisp.h (case_temp1, case_temp2): Remove their decls.
9099 * character.h (ASCII_CHAR_P): Move from here ...
9100 * lisp.h: ... to here, so that the inline functions mentioned
9101 above can use them.
9102
9103 * dired.c (directory_files_internal_unwind): Now static.
9104
9105 * fileio.c (file_name_as_directory, directory_file_name):
9106 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9107 Now static.
9108 (file_name_as_directory): Use const pointers when appropriate.
9109 (Fexpand_file_name): Likewise. In particular, newdir might
9110 point at constant storage, so make it a const pointer.
9111 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
9112 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9113 signedness issues.
9114 (Fset_file_times, Finsert_file_contents, auto_save_error):
9115 Rename locals to avoid shadowing.
9116
9117 * minibuf.c (choose_minibuf_frame_1): Now static.
9118 (Ftry_completion, Fall_completions): Rename or remove locals
9119 to avoid shadowing.
9120
9121 * marker.c (bytepos_to_charpos): Remove; unused.
9122
9123 * lisp.h (verify_bytepos, count_markers): New decls,
9124 so that gcc does not warn that these functions aren't declared.
9125
9126 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9127 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
9128 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
9129 (copy_text): Remove unused local var.
9130
9131 * filelock.c (within_one_second): Now static.
9132 (lock_file_1): Rename local to avoid shadowing.
9133
9134 * buffer.c (fix_overlays_before): Mark locals as initialized.
9135 (fix_start_end_in_overlays): Likewise. This function should be
9136 simplified by using pointers-to-pointers, but that's a different
9137 matter.
9138 (switch_to_buffer_1): Now static.
9139 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9140 (report_overlay_modification): Rename locals to avoid shadowing.
9141
9142 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
9143 Fix pointer signedness issue.
9144 (sys_subshell): Mark local as volatile if checking for lint,
9145 to suppress a gcc -Wclobbered warning that does not seem to be right.
9146 (MAXPATHLEN): Define only if needed.
9147
9148 * process.c (serial_open, serial_configure): Move decls from here ...
9149 * systty.h: ... to here, so that they can be checked.
9150
9151 * fns.c (get_random, seed_random): Move extern decls from here ...
9152 * lisp.h: ... to here, so that they can be checked.
9153
9154 * sysdep.c (reset_io): Now static.
9155 (wait_for_termination_signal): Remove; unused.
9156
9157 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9158 (copy_keymap_item, append_key, push_text_char_description):
9159 Now static.
9160 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
9161 (DENSE_TABLE_SIZE): Remove; unused.
9162 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9163 (describe_map_tree):
9164 Rename locals to avoid shadowing.
9165
9166 * keyboard.c: Declare functions static if they are not used elsewhere.
9167 (echo_char, echo_dash, cmd_error, top_level_2):
9168 (poll_for_input, handle_async_input): Now static.
9169 (read_char, kbd_buffer_get_event, make_lispy_position):
9170 (make_lispy_event, make_lispy_movement, apply_modifiers):
9171 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9172 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9173 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
9174 (read_key_sequence, read_char): Mark locals as initialized.
9175 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
9176
9177 * keyboard.h (make_ctrl_char): New decl.
9178 (mark_kboards): Move decl here ...
9179 * alloc.c (mark_kboards): ... from here.
9180
9181 * lisp.h (force_auto_save_soon): New decl.
9182
9183 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
9184 (DEFINE_DUMMY_FUNCTION): New macro.
9185 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9186 Use it.
9187 (main): Add casts to avoid warnings
9188 if GCC considers string literals to be constants.
9189
9190 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9191
9192 * dbusbind.c: Pointer signedness fixes.
9193 (xd_signature, xd_append_arg, xd_initialize):
9194 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9195 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9196 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9197 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9198
9199 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9200 if GCC considers string literals to be constants.
9201 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
9202
9203 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9204
9205 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9206 (print_preprocess, print_object): New macro to fix last change.
9207
9208 * print.c (print_preprocess): Don't forget font objects.
9209
9210 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
9211
9212 * emacs.c (USAGE3): Doc fixes.
9213
9214 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9215
9216 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9217 structure.
9218
9219 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
9220
9221 * lisp.h (VWindow_system, Qfile_name_history):
9222 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9223 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9224 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9225
9226 * w32select.c: Don't #include "keyboard.h".
9227 (run_protected): Add extern declaration for waiting_for_input.
9228
9229 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9230 * w32console.c (detect_input_pending, read_input_pending)
9231 (encode_terminal_code):
9232 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9233 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9234 (w32_system_caret_y, Qfile_name_history):
9235 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9236 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9237 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9238 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9239 * w32proc.c (Qlocal, report_file_error):
9240 * w32term.c (Vwindow_system, updating_frame):
9241 * w32uniscribe.c (initialized, uniscribe_font_driver):
9242 Remove unneeded extern declarations.
9243
9244 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
9245
9246 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
9247
9248 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
9249
9250 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9251 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9252 These macros can no longer be used for assignment.
9253
9254 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9255 Assign struct members directly, instead of using BUF_BEGV etc.
9256 (record_buffer_markers, fetch_buffer_markers): New functions for
9257 recording and fetching special buffer markers.
9258 (set_buffer_internal_1, set_buffer_temp): Use them.
9259
9260 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9261
9262 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9263
9264 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9265 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9266
9267 * xdisp.c (hscroll_window_tree):
9268 (reconsider_clip_changes): Use PT instead of BUF_PT.
9269
9270 2011-03-13 Eli Zaretskii <eliz@gnu.org>
9271
9272 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9273 $(EMACS_ROOT)/lib/intprops.h.
9274
9275 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9276
9277 Fix more problems found by GCC 4.5.2's static checks.
9278
9279 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9280 to unsigned char * to avoid compiler diagnostic.
9281 (xg_free_frame_widgets): Make it clear that a local variable is
9282 needed only if USE_GTK_TOOLTIP.
9283 (gdk_window_get_screen): Make it clear that this macro is needed
9284 only if USE_GTK_TOOLTIP.
9285 (int_gtk_range_get_value): New function, which avoids a diagnostic
9286 from gcc -Wbad-function-cast.
9287 (xg_set_toolkit_scroll_bar_thumb): Use it.
9288 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9289 diagnostic from gcc -Wbad-function-cast.
9290 (get_utf8_string, xg_get_file_with_chooser):
9291 Rename locals to avoid shadowing.
9292 (create_dialog): Move locals to avoid shadowing.
9293
9294 * xgselect.c (xg_select): Remove unused var.
9295
9296 * image.c (four_corners_best): Mark locals as initialized.
9297 (gif_load): Initialize transparent_p to zero (Bug#8238).
9298 Mark another local as initialized.
9299 (my_png_error, my_error_exit): Mark with NO_RETURN.
9300
9301 * image.c (clear_image_cache): Now static.
9302 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
9303 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
9304 (x_edge_detection): Remove unnecessary cast that
9305 gcc -Wbad-function-cast diagnoses.
9306 (gif_load): Fix pointer signedness.
9307 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9308 (jpeg_load, gif_load): Rename locals to avoid shadowing.
9309
9310 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
9311
9312 Improve quality of tests for time stamp overflow.
9313 For example, without this patch (encode-time 0 0 0 1 1
9314 1152921504606846976) returns the obviously-bogus value (-948597
9315 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9316 reports time overflow. See
9317 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
9318 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9319 * editfns.c: Include limits.h and intprops.h.
9320 (TIME_T_MIN, TIME_T_MAX): New macros.
9321 (time_overflow): Move earlier, to before first use.
9322 (hi_time, lo_time): New functions, for an accurate test for
9323 out-of-range times.
9324 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9325 (Fget_internal_run_time): Don't assume time_t fits in int.
9326 (make_time): Use list2 instead of Fcons twice.
9327 (Fdecode_time): More accurate test for out-of-range times.
9328 (check_tm_member): New function.
9329 (Fencode_time): Use it, to test for out-of-range times.
9330 (lisp_time_argument): Don't rely on undefined left-shift and
9331 right-shift behavior when checking for time stamp overflow.
9332
9333 * editfns.c (time_overflow): New function, refactoring common code.
9334 (Fformat_time_string, Fdecode_time, Fencode_time):
9335 (Fcurrent_time_string): Use it.
9336
9337 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9338 * dired.c (make_time): Move to ...
9339 * editfns.c (make_time): ... here.
9340 * systime.h: Note the move.
9341
9342 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9343
9344 * fringe.c (update_window_fringes): Remove unused variables.
9345
9346 * unexmacosx.c (copy_data_segment): Also copy __got section.
9347 (Bug#8223)
9348
9349 2011-03-12 Eli Zaretskii <eliz@gnu.org>
9350
9351 * termcap.c [MSDOS]: Include "msdos.h".
9352 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9353 Constify `char *' arguments and their references according to
9354 prototypes in tparam.h.
9355
9356 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
9357
9358 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9359 Adapt all references accordingly.
9360
9361 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9362
9363 2011-03-11 Tom Tromey <tromey@redhat.com>
9364
9365 * buffer.c (syms_of_buffer): Remove obsolete comment.
9366
9367 2011-03-11 Eli Zaretskii <eliz@gnu.org>
9368
9369 * termhooks.h (encode_terminal_code): Declare prototype.
9370
9371 * msdos.c (encode_terminal_code): Don't declare prototype.
9372
9373 * term.c (encode_terminal_code): Now external again, used by
9374 w32console.c and msdos.c.
9375
9376 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9377 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
9378
9379 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
9380
9381 Fix some minor problems found by GCC 4.5.2's static checks.
9382
9383 * fringe.c (update_window_fringes): Mark locals as initialized
9384 (Bug#8227).
9385 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
9386
9387 * alloc.c (mark_fringe_data): Move decl from here ...
9388 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9389 to check its interface.
9390 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9391
9392 * fontset.c (free_realized_fontset): Now static.
9393 (Fset_fontset_font): Rename local to avoid shadowing.
9394 (fontset_font): Mark local as initialized.
9395 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
9396
9397 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9398
9399 * xselect.c (x_disown_buffer_selections): Remove; not used.
9400 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
9401 (x_own_selection, Fx_disown_selection_internal): Rename locals
9402 to avoid shadowing.
9403 (x_handle_dnd_message): Remove local to avoid shadowing.
9404
9405 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9406 so that the caller can use some name other than gcpro1.
9407 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
9408 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9409 (Fx_backspace_delete_keys_p):
9410 Use them to avoid shadowing, and rename vars to avoid shadowing.
9411 (x_decode_color, x_set_name, x_window): Now static.
9412 (Fx_create_frame): Add braces to silence GCC warning.
9413 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
9414 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9415 Remove unused locals.
9416 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9417 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9418 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9419 macros.
9420
9421 * xterm.h (x_mouse_leave): New decl.
9422
9423 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9424 Remove unused functions.
9425 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9426 (x_calc_absolute_position): Now static.
9427 (XTread_socket): Don't define label "out" unless it's used.
9428 Don't declare local "event" unless it's used.
9429 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9430 unless they are used.
9431 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9432 (x_fatal_error_signal): Remove; not used.
9433 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9434 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9435 (x_error_catcher, x_connection_closed, x_error_handler):
9436 (x_error_quitter, xembed_send_message, x_iconify_frame):
9437 (my_log_handler): Rename locals to avoid shadowing.
9438 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
9439 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
9440
9441 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9442 Rename or move locals to avoid shadowing.
9443 (tty_defined_color, merge_face_heights): Now static.
9444 (free_realized_faces_for_fontset): Remove; not used.
9445 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9446 does not deduce is never used uninitialized.
9447 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9448 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
9449
9450 * terminal.c (store_terminal_param): Now static.
9451
9452 * xmenu.c (menu_highlight_callback): Now static.
9453 (set_frame_menubar): Remove unused local.
9454 (xmenu_show): Rename parameter to avoid shadowing.
9455 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9456 since they might point to immutable storage.
9457 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9458 since it's unused otherwise.
9459
9460 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
9461 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9462 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9463 avoids a gcc -Wuninitialized diagnostic.
9464 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
9465 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9466 does not deduce are never used uninitialized.
9467
9468 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9469
9470 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
9471 * window.c (window_loop, size_window):
9472 (run_window_configuration_change_hook, enlarge_window): Likewise.
9473
9474 * window.c (display_buffer): Now static.
9475 (size_window): Mark variables that gcc -Wuninitialized
9476 does not deduce are never used uninitialized.
9477 * window.h (check_all_windows): New decl, to forestall
9478 gcc -Wmissing-prototypes diagnostic.
9479 * dispextern.h (bidi_dump_cached_states): Likewise.
9480
9481 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9482 shadowing.
9483 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
9484 Include <limits.h>.
9485 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9486 and to avoid gcc -Wuninitialized warning.
9487 (load_charset_map): Mark variables that gcc -Wuninitialized
9488 does not deduce are never used uninitialized.
9489 (load_charset): Abort instead of using uninitialized var (Bug#8229).
9490
9491 * coding.c (coding_set_source, coding_set_destination):
9492 Use "else { /* comment */ }" rather than "else /* comment */;"
9493 for clarity, and to avoid gcc -Wempty-body warning.
9494 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9495 a block, when the outer 'i' will do.
9496 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9497 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9498 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9499 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9500 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9501 Rename locals to avoid shadowing.
9502 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
9503 * coding.c (emacs_mule_char, encode_invocation_designation):
9504 Now static, since they're not used elsewhere.
9505 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
9506 (decode_coding_object, encode_coding_object, detect_coding_system):
9507 (decode_coding_emacs_mule): Mark variables that gcc
9508 -Wuninitialized does not deduce are never used uninitialized.
9509 (detect_coding_iso_2022): Initialize a local variable that might
9510 be used uninitialized. Leave a FIXME because it's not clear that
9511 this initialization is needed. (Bug#8211)
9512 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9513 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9514 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9515 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9516 Remove unused macros.
9517
9518 * category.c (hash_get_category_set): Remove unused local var.
9519 (copy_category_table): Now static, since it's not used elsewhere.
9520 * character.c (string_count_byte8): Likewise.
9521
9522 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9523 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9524
9525 * chartab.c (copy_sub_char_table): Now static, since it's not used
9526 elsewhere.
9527 (sub_char_table_ref_and_range, char_table_ref_and_range):
9528 Rename locals to avoid shadowing.
9529 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
9530
9531 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
9532 (BIDI_BOB): Remove unused macro.
9533
9534 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9535 deduce are never used uninitialized.
9536 * term.c (encode_terminal_code): Likewise.
9537
9538 * term.c (encode_terminal_code): Now static. Remove unused local.
9539
9540 * tparam.h: New file.
9541 * term.c, tparam.h: Include it.
9542 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9543 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9544 Move these decls to tparam.h, and make them agree with what
9545 is actually in tparam.c. The previous trick of using incompatible
9546 decls in different modules does not conform to the C standard.
9547 All callers of tparam changed to use tparam's actual API.
9548 * tparam.c (tparam1, tparam, tgoto):
9549 Use const pointers where appropriate.
9550
9551 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9552 * cm.h (struct cm): Likewise.
9553 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9554 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9555 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9556 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9557 (turn_on_face, init_tty): Likewise.
9558 * termchar.h (struct tty_display_info): Likewise.
9559
9560 * term.c (term_mouse_position): Rename local to avoid shadowing.
9561
9562 * alloc.c (mark_ttys): Move decl from here ...
9563 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9564
9565 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9566
9567 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9568
9569 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
9570
9571 * search.c (compile_pattern_1): Remove argument regp, unused since
9572 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9573 (compile_pattern): Don't pass it.
9574
9575 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9576
9577 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9578 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9579 for ! HAVE_GTK3.
9580 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9581
9582 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9583
9584 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9585 gdk_window_get_screen, gdk_window_get_geometry,
9586 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9587 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9588 (xg_get_pixbuf_from_pixmap): New function.
9589 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9590 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9591 Call xg_get_pixbuf_from_pixmap instead of
9592 gdk_pixbuf_get_from_drawable.
9593 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9594 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9595 (xg_check_special_colors): Use GtkStyleContext and its functions
9596 for HAVE_GTK3.
9597 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9598 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9599 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
9600 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9601 Call gtk_widget_get_preferred_size.
9602 (xg_frame_resized): gdk_window_get_geometry only takes 5
9603 parameters.
9604 (xg_win_to_widget, xg_event_is_for_menubar):
9605 Call gdk_x11_window_lookup_for_display.
9606 (xg_set_widget_bg): New function.
9607 (delete_cb): New function.
9608 (xg_create_frame_widgets): Connect delete-event to delete_cb.
9609 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
9610 (xg_set_background_color): Call xg_set_widget_bg.
9611 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9612 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9613 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9614 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9615 if ! HAVE_GTK3.
9616 (update_frame_tool_bar): Call gtk_widget_hide.
9617 (xg_initialize): Use GDK_KEY_g.
9618
9619 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9620 if ! HAVE_GTK3
9621 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9622
9623 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9624 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9625 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9626
9627 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
9628
9629 * w32xfns.c (select_palette): Check success of RealizePalette against
9630 GDI_ERROR, not zero.
9631
9632 See ChangeLog.11 for earlier changes.
9633
9634 ;; Local Variables:
9635 ;; coding: utf-8
9636 ;; End:
9637
9638 Copyright (C) 2011-2012 Free Software Foundation, Inc.
9639
9640 This file is part of GNU Emacs.
9641
9642 GNU Emacs is free software: you can redistribute it and/or modify
9643 it under the terms of the GNU General Public License as published by
9644 the Free Software Foundation, either version 3 of the License, or
9645 (at your option) any later version.
9646
9647 GNU Emacs is distributed in the hope that it will be useful,
9648 but WITHOUT ANY WARRANTY; without even the implied warranty of
9649 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9650 GNU General Public License for more details.
9651
9652 You should have received a copy of the GNU General Public License
9653 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.