1 2012-07-10 Glenn Morris <rgm@gnu.org>
3 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
4 We include usg5-4-common.h, which defines them both.
6 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
7 O_RDONLY already includes it).
9 Stop ns builds setting the EMACSLOADPATH environment variable.
10 * nsterm.m (ns_load_path): Rename from ns_init_paths.
11 Now it does not set EMACSLOADPATH, just returns the load-path string.
12 * nsterm.h: Update accordingly.
13 * lread.c [HAVE_NS]: Include nsterm.h.
14 (init_lread) [HAVE_NS]: Use ns_load_path.
15 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
17 2012-07-09 Glenn Morris <rgm@gnu.org>
19 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
20 since the included bsd-common.h does so.
22 Stop ns builds setting the EMACSPATH environment variable.
23 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
24 (ns_init_paths): Do not set EMACSPATH.
25 * nsterm.h (ns_exec_path): Add it.
26 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
29 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
31 2012-07-09 Paul Eggert <eggert@cs.ucla.edu>
33 * process.c (wait_reading_process_output): 'waitchannels' was unset
34 when read_kbd || !NILP (wait_for_cell); fix this.
36 Add GCC-style 'const' attribute to functions that can use it.
37 * character.h (char_resolve_modifier_mask):
38 * keyboard.h (make_ctrl_char):
39 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
40 (init_character_once, next_almost_prime, init_fns, init_image)
41 (flush_pending_output, init_sound):
42 * mem-limits.h (start_of_data):
43 * menu.h (finish_menu_items):
45 * emacs.c (DEFINE_DUMMY_FUNCTION):
46 Declare the dummy function with ATTRIBUTE_CONST.
47 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
48 Add decls with ATTRIBUTE_CONST.
50 Minor improvements to make_formatted_string.
51 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
52 where int is good enough, as vsprintf returns an int.
53 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
55 2012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
57 Use make_formatted_string to avoid double length calculation.
58 * lisp.h (make_formatted_string): New prototype.
59 * alloc.c (make_formatted_string): New function.
60 * buffer.c (Fgenerate_new_buffer_name): Use it.
61 * dbus.c (syms_of_dbusbind): Likewise.
62 * editfns.c (Fcurrent_time_zone): Likewise.
63 * filelock.c (get_boot_time): Likewise.
64 * frame.c (make_terminal_frame, set_term_frame_name)
65 (x_report_frame_params): Likewise.
66 * image.c (gs_load): Likewise.
67 * minibuf.c (get_minibuffer): Likewise.
68 * msdos.c (dos_set_window_size): Likewise.
69 * process.c (make_process): Likewise.
70 * xdisp.c (ensure_echo_area_buffers): Likewise.
71 * xsettings.c (apply_xft_settings): Likewise.
73 2012-07-09 Glenn Morris <rgm@gnu.org>
75 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
76 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
77 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
78 * nsterm.h (ns_etc_directory): Add it.
79 * callproc.c [HAVE_NS]: Include nsterm.h.
80 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
82 2012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
84 Move marker debugging code under MARKER_DEBUG.
85 * marker.c (MARKER_DEBUG): Move marker debugging code under
86 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
87 for bootstrap with --enable-checking (~3x slowdown reported
88 by Juanma Barranquero <lekktu@gmail.com>).
89 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
91 2012-07-08 Paul Eggert <eggert@cs.ucla.edu>
93 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
94 See <http://bugs.gnu.org/11825#29>.
96 2012-07-08 Eli Zaretskii <eliz@gnu.org>
98 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
99 has no font, use the frame's font. (Bug#11813)
100 (display_line): Add commentary about displaying truncation glyphs
102 (produce_special_glyphs): Move here from term.c.
104 * term.c (produce_special_glyphs): Move to xdisp.c.
106 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
109 2012-07-07 Andreas Schwab <schwab@linux-m68k.org>
111 * xdisp.c (display_line): Avoid warning about implicit declaration
114 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
116 * lisp.h: Remove empty conditional.
118 2012-07-07 Paul Eggert <eggert@cs.ucla.edu>
120 * lread.c (load_path_check): Now static.
122 Fix some minor --with-ns problems found by static checking.
123 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
124 (x_set_font) [!HAVE_X_WINDOWS]:
125 * image.c (xpm_load_image) [HAVE_NS]:
126 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
127 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
129 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
130 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
131 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
132 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
133 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
134 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
135 Fix pointer signedness problem.
136 * xfaces.c (FRAME_X_FONT_TABLE):
137 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
139 2012-07-07 Glenn Morris <rgm@gnu.org>
141 * lread.c (load_path_check): New function, split from init_lread.
142 (init_lread): Reorganize. Motivation:
143 If EMACSLOADPATH is set, check/warn about that rather than the
144 defaults, which we are not going to use. Hence we can remove
145 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
146 Don't warn if site-lisp directories are missing.
147 If not installed, start from a blank load-path, since
148 PATH_LOADSEARCH refers to the eventual installation directories.
150 2012-07-07 Eli Zaretskii <eliz@gnu.org>
152 Support truncation and continuation glyphs on GUI frames, when
153 fringes are disabled. (Bug#11832)
154 * xdisp.c (init_iterator): Get dimensions of truncation and
155 continuation glyphs even if on GUI frames. Adjust
156 it->last_visible_x on GUI frames when the left or right fringes,
158 (start_display, move_it_in_display_line_to): Handle the case of a
159 GUI frame without a fringe to display continuation or truncation
161 (insert_left_trunc_glyphs): Support GUI frames: make sure
162 truncation glyphs overwrite enough glyphs from the current line to
163 have sufficient space in pixels.
164 (display_line): Support truncation and continuation glyphs on GUI
165 frames. If some spare pixels are left on the line after inserting
166 the truncation glyphs, fill that space with a stretch glyph of a
167 suitably computed width.
169 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
170 produce_glyphs, to support GUI sessions.
172 2012-07-07 Paul Eggert <eggert@cs.ucla.edu>
174 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
176 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
178 Do not require float-time's arg to fit in time_t (Bug#11825).
179 This works better on hosts where time_t is unsigned, and where
180 float-time is applied to the (negative) difference between two times.
181 * editfns.c (decode_time_components): Last arg is now double *,
182 not int *, and means to store all the result as a double, without
183 worrying about whether the seconds part fits in time_t.
185 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
187 (Ffloat_time): Do not fail merely because the specified time falls
188 outside of time_t range.
190 2012-07-07 Glenn Morris <rgm@gnu.org>
192 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
193 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
194 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
196 2012-07-07 Juanma Barranquero <lekktu@gmail.com>
198 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
201 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
203 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
205 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
206 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
207 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
208 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
209 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
210 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
212 * xfont.c (compare_font_names): Redo to omit the need for casts.
214 2012-07-06 Andreas Schwab <schwab@linux-m68k.org>
216 * xfns.c (Fx_change_window_property): Doc fix.
217 * w32fns.c (Fx_change_window_property): Doc fix.
219 * w32fns.c (Fx_window_property): Accept the same arguments as the
220 X Windows version. Doc fix.
221 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
223 2012-07-06 Juanma Barranquero <lekktu@gmail.com>
224 Eli Zaretskii <eliz@gnu.org>
226 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
227 Windows-specific code from nt/config.nt moved here.
228 Obsolete settings removed.
230 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
232 * process.c: Avoid unnecessary calls to gettime.
233 (wait_reading_process_output): Don't get the time of day
234 when gobbling data immediately and not waiting, as there's no need
235 for it in that case. This removes a FIXME.
237 2012-07-06 Jan Djärv <jan.h.d@swipnet.se>
239 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
240 is defined (Bug#11768).
242 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
244 Fix marker debugging code.
245 * marker.c (byte_char_debug_check): Do not perform the check
246 if buffer is not multibyte.
247 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
248 Call byte_char_debug_check with correct arguments.
250 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
252 Compile marker debugging code only if ENABLE_CHECKING is defined.
253 * marker.c (byte_char_debug_check, count_markers):
254 Use only if ENABLE_CHECKING is defined.
255 (byte_debug_flag): Remove.
256 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
257 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
259 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
261 Avoid code repetition in marker-related functions.
262 * marker.c (attach_marker): New function.
263 (Fset_marker, set_marker_restricted, set_marker_both)
264 (set_marker_restricted_both): Use it.
265 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
266 Consistently rename charno to charpos.
267 (marker_position): Add eassert.
268 (marker_byte_position): Convert to eassert.
270 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
272 Simplify list operations in unchain_overlay and unchain_marker.
273 * buffer.c (unchain_overlay): Simplify. Add comment.
274 * marker.c (unchain_marker): Simplify. Fix comments.
276 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
278 Introduce fast path for the widely used marker operation.
279 * alloc.c (build_marker): New function.
280 * lisp.h (build_marker): New prototype.
281 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
282 * composite.c (autocmp_chars): Likewise.
283 * editfns.c (buildmark): Remove.
284 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
285 (save_restriction_save): Use build_marker.
286 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
287 * window.c (save_window_save): Likewise.
289 2012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
291 Do not use Fdelete_overlay in delete_all_overlays
292 to avoid redundant calls to unchain_overlay.
293 * buffer.c (drop_overlay): New function.
294 (delete_all_overlays, Fdelete_overlay): Use it.
295 * minibuf.c (get_minibuffer): Fix comment.
297 2012-07-06 Paul Eggert <eggert@cs.ucla.edu>
299 Port to OpenBSD 5.1 amd64.
300 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
301 This is needed for OpenBSD, and should be harmless on all BSD systems.
302 Also, include <sys/sysctl.h>, as it should be available on all
303 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
304 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
305 use p_pid member, not kp_proc.pid.
307 2012-07-06 Glenn Morris <rgm@gnu.org>
309 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
311 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
313 More xmalloc and related cleanup.
314 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
315 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
316 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
317 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
318 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
319 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
320 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
321 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
322 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
324 Omit needless casts involving void * pointers and allocation.
325 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
326 as the former is more robust if P's type is changed.
327 Prefer xzalloc to xmalloc + memset 0.
328 Simplify malloc-or-realloc to realloc.
329 Don't worry about xmalloc returning a null pointer.
330 Prefer xstrdup to xmalloc + strcpy.
331 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
333 * keyboard.c (apply_modifiers_uncached): Prefer local array to
334 alloca of a constant.
336 2012-07-05 Eli Zaretskii <eliz@gnu.org>
338 * xdisp.c (display_line): Fix horizontal pixel coordinates when
339 hscroll is larger than the line width. Fixes long and futile
340 looping inside extend_face_to_end_of_line (on a TTY) producing
341 glyphs that are not needed and thrown away.
343 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
345 * marker.c (set_marker_restricted_both): Simplify by using
348 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
350 * editfns.c (region_limit): Simplify by using clip_to_bounds.
352 2012-07-05 Jan Djärv <jan.h.d@swipnet.se>
354 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
355 not defined (Bug#11768).
356 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
357 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
358 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
359 followed by gtk_box_set_homogeneous (Bug#11768).
360 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
361 (update_theme_scrollbar_width, xg_create_scroll_bar):
362 Use gtk_scrollbar_new (Bug#11768).
363 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
364 (is_box_type): New function (Bug#11768).
365 (xg_tool_item_stale_p): Call is_box_type.
366 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
367 with default display (Bug#11768).
369 2012-07-05 Eli Zaretskii <eliz@gnu.org>
371 * xdisp.c (window_hscroll_limited): New function.
372 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
373 coordinates when window's hscroll is set to insanely large
376 2012-07-05 Juanma Barranquero <lekktu@gmail.com>
378 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
379 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
381 2012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
384 * lisp.h (xzalloc): New prototype. Omit needless casts.
385 * alloc.c (xzalloc): New function. Omit needless casts.
386 * charset.c: Omit needless casts. Convert all calls to
387 xmalloc with following memset to xzalloc.
388 * dispnew.c: Likewise.
389 * fringe.c: Likewise.
393 * w32fns.c: Likewise.
394 * w32font.c: Likewise.
395 * w32term.c: Likewise.
396 * xfaces.c: Likewise.
399 * atimer.c: Omit needless casts.
400 * buffer.c: Likewise.
401 * callproc.c: Likewise.
403 * coding.c: Likewise.
404 * composite.c: Likewise.
406 * doprnt.c: Likewise.
407 * editfns.c: Likewise.
410 * filelock.c: Likewise.
412 * gtkutil.c: Likewise.
413 * keyboard.c: Likewise.
416 * minibuf.c: Likewise.
419 * process.c: Likewise.
420 * region-cache.c: Likewise.
421 * search.c: Likewise.
422 * sysdep.c: Likewise.
423 * termcap.c: Likewise.
424 * terminal.c: Likewise.
425 * tparam.c: Likewise.
426 * w16select.c: Likewise.
428 * w32reg.c: Likewise.
429 * w32select.c: Likewise.
430 * w32uniscribe.c: Likewise.
431 * widget.c: Likewise.
435 * xselect.c: Likewise.
437 2012-07-05 Paul Eggert <eggert@cs.ucla.edu>
439 * fileio.c (time_error_value): Check the right error number.
440 Problem reported by Troels Nielsen in
441 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
443 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
445 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
446 This should be fixed in a better way; see Eli Zaretskii in
447 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
448 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
450 * fileio.c (time_error_value): Rename from special_mtime.
451 The old name's problems were noted by Eli Zaretskii in
452 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
454 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
455 This variable's comment says Emacs needs at least one GDB-visible
456 symbol of type enum pvec_type, to work around GDB problems.
457 The symbol's value doesn't matter.
459 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
460 that causes compilation to fail on pre-C99 compilers.
462 2012-07-04 Juanma Barranquero <lekktu@gmail.com>
464 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
465 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
467 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
469 * buffer.c (init_buffer_once): Fix initialization of
470 headers for buffer_defaults and buffer_local_symbols.
471 Reported by Juanma Barranquero <lekktu@gmail.com>.
473 2012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
475 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
476 * lisp.h (enum pvec_type): Use fewer bits.
477 (PSEUDOVECTOR_SIZE_BITS): New constant.
478 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
479 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
481 (PSEUDOVECTOR_TYPEP): New macro.
482 (TYPED_PSEUDOVECTORP): Use it.
483 * fns.c (internal_equal): Adapt code to extract pvectype.
484 * emacs.c (gdb_pvec_type): Update type.
485 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
486 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
487 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
488 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
489 (sweep_vectors): Use it. Use local var `total_bytes' instead of
490 abusing vector->header.next.nbytes.
491 (live_vector_p): Use PVEC_TYPE.
492 (mark_object): Adapt code to extract pvectype. Use switch.
494 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
496 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
497 Tighten new eassert a bit.
499 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
501 Fix compilation with --enable-gcc-warnings and -O1
503 * doprnt.c (doprnt): Change type of tem to int, initialize
504 to avoid compiler warning. Add eassert.
505 * search.c (simple_search): Initialize match_byte to avoid
506 compiler warning. Add eassert.
508 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
510 Avoid weird behavior with large horizontal scrolls.
511 Without this change, for example, large hscroll values would
512 mess up Emacs's display on Fedora 15 x86, presumably due to
513 overflows in int calculations in the display code.
514 Also, if buffers had long lines, Emacs would freeze.
515 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
516 (set_window_hscroll): New function, containing the old guts of
517 Fset_window_hscroll. Return the clipped value.
518 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
519 This avoids the need to check against PTRDIFF_MAX.
521 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
523 2012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
525 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
527 2012-07-04 Paul Eggert <eggert@cs.ucla.edu>
529 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
530 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
531 since GCC 4.4.6 issues a bogus warning for them.
533 Fix bugs in file timestamp newness comparisons.
534 * fileio.c (Ffile_newer_than_file_p):
535 * lread.c (Fload): Use full timestamp resolution of files,
536 not just the 1-second resolution, so that files that are only
537 slightly newer still count as newer.
538 * fileio.c (Ffile_newer_than_file_p): Don't assume file
539 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
541 2012-07-03 Paul Eggert <eggert@cs.ucla.edu>
543 * fileio.c: Improve handling of file time marker. (Bug#11852)
544 (special_mtime): New function.
545 (Finsert_file_contents, Fverify_visited_file_modtime):
546 Use it to set special mtime values consistently.
548 2012-07-03 Andreas Schwab <schwab@linux-m68k.org>
550 * fileio.c (Finsert_file_contents): Properly handle st_mtime
551 marker for non-existing file. (Bug#11852)
553 2012-07-03 Glenn Morris <rgm@gnu.org>
555 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
556 and did not make it into globals.h).
558 2012-07-03 Tom Tromey <tromey@redhat.com>
560 * window.c (Fset_window_margins, Fset_window_fringes)
561 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
562 * textprop.c (Fprevious_property_change): No longer static.
563 * syntax.c (Fsyntax_table_p): No longer static.
564 * process.c (Fget_process, Fprocess_datagram_address): No longer
566 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
567 * keyboard.c (Fcommand_execute): No longer static.
569 * insdel.c (Fcombine_after_change_execute): No longer static.
570 * image.c (Finit_image_library): No longer static.
571 * fileio.c (Fmake_symbolic_link): No longer static.
572 * eval.c (Ffetch_bytecode): No longer static.
573 * editfns.c (Fuser_full_name): No longer static.
574 * doc.c (Fdocumentation_property, Fsnarf_documentation):
576 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
578 * dired.c (Ffile_attributes): No longer static.
579 * composite.c (Fcomposition_get_gstring): No longer static.
580 * callproc.c (Fgetenv_internal): No longer static.
582 * ccl.h: Remove EXFUNs.
583 * buffer.h: Remove EXFUNs.
584 * dispextern.h: Remove EXFUNs.
585 * intervals.h: Remove EXFUNs.
586 * fontset.h: Remove EXFUN.
587 * font.h: Remove EXFUNs.
588 * dosfns.c (system_process_attributes): Remove EXFUN.
589 * keymap.h: Remove EXFUNs.
590 * lisp.h: Remove EXFUNs.
591 * w32term.h: Remove EXFUNs.
592 * window.h: Remove EXFUNs.
593 * xsettings.h: Remove EXFUN.
594 * xterm.h: Remove EXFUN.
596 2012-07-03 Glenn Morris <rgm@gnu.org>
598 * lisp.h (Frandom): Make it visible to C.
599 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
600 buffer for invisible buffers. (Bug#1229)
602 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
604 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
605 values which aren't power of 2.
606 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
607 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
610 2012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
612 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
614 * alloc.c (mark_object): Revert part of last patch to use `switch'.
616 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
618 * alloc.c (allocate_vector_block): Remove redundant
619 calls to mallopt if DOUG_LEA_MALLOC is defined.
620 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
621 avoid calls to mallopt if zero_vector is returned.
623 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
625 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
626 is enabled, avoid dereferencing NULL current_sblock if
629 2012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
631 Cleanup basic buffer management.
632 * buffer.h (struct buffer): Change layout to use generic vector
633 marking code. Fix some comments. Change type of 'clip_changed'
634 to bitfield. Remove unused #ifndef old.
635 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
636 (GET_OVERLAYS_AT): Fix indentation.
637 (for_each_per_buffer_object_at): New macro.
638 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
639 (Fbuffer_local_variables): Use it.
640 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
641 * alloc.c (allocate_buffer): Adjust to match new layout of
642 struct buffer. Fix comment.
643 (mark_overlay): New function.
644 (mark_buffer): Use it. Use mark_vectorlike to mark normal
645 Lisp area of struct buffer.
646 (mark_object): Use it. Adjust marking of misc objects
647 and related comments.
649 2012-07-02 Paul Eggert <eggert@cs.ucla.edu>
651 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
652 wrapper that is not needed because the wrapped code is a no-op (zero
653 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
654 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
656 2012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
658 * alloc.c (mark_buffer): Simplify. Remove prototype.
659 (mark_object): Add comment. Reorganize marking of vector-like
660 objects. Use CHECK_LIVE for all vector-like objects except buffers
661 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
662 redundant calls to mark_vectorlike for bool vectors.
664 2012-06-30 Glenn Morris <rgm@gnu.org>
666 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
668 * epaths.in (PATH_SITELOADSEARCH): New.
669 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
670 This is rather than relying on --enable-locallisppath elements
671 having "site-lisp" in their names. (Bug#10208#25, 11658)
673 2012-06-30 Eli Zaretskii <eliz@gnu.org>
675 * w32proc.c (sys_select): Accept and ignore one more argument.
677 * w32.c (emacs_gnutls_pull): Call select with one more argument.
679 * sysselect.h [DOS_NT]: Don't include sys/select.h.
680 (pselect) [!MS_DOS]: Redirect to sys_select.
682 * sysdep.c: Don't include dos.h and dosfns.h.
684 * process.c (sys_select):
685 * msdos.c (sys_select): Accept one more argument and ignore it.
687 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
688 adapt data types and code to that.
691 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
692 which clashes with the gnulib function of the same name.
694 2012-06-30 Andreas Schwab <schwab@linux-m68k.org>
696 * font.c (font_style_to_value, font_style_symbolic)
697 (font_prop_validate_style): Add type checks for values in
700 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
702 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
705 2012-06-29 Eli Zaretskii <eliz@gnu.org>
707 * xdisp.c (try_window_id): Undo last change.
709 * w32.c (getwd): Adjust commentary about startup_dir.
710 (init_environment): Always call sys_access, even in non-MSVC
711 builds. Don't chdir to the directory of the Emacs executable.
712 This undoes code from 1997 which was justified by the need to
713 "avoid conflicts when removing and renaming directories". But its
714 downside was that every relative file name was being interpreted
715 relative to the directory of the Emacs executable, which can never
716 be TRT. In particular, it broke sys_access when called with
718 (sys_access): Map GetLastError to errno.
720 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
722 * window.h (struct window): Change type of 'fringes_outside_margins'
723 to bitfield. Fix comment. Adjust users accordingly.
724 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
726 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
729 2012-06-29 Andreas Schwab <schwab@linux-m68k.org>
731 * gnutls.c (emacs_gnutls_handshake):
732 Add QUIT to make the loop interruptible.
734 2012-06-29 Glenn Morris <rgm@gnu.org>
736 * charset.c (init_charset): Make lack of etc/charsets fatal.
738 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
740 * editfns.c (region_limit): Fix type mismatch.
742 2012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
744 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
745 undefined. Convert from xassert to eassert.
746 * nsmenu.m: Convert from xassert to eassert.
747 * nsterm.m: Likewise.
749 2012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
751 * editfns.c (region_limit): Clip to narrowing (bug#11770).
753 2012-06-28 Paul Eggert <eggert@cs.ucla.edu>
755 Avoid integer overflow on scroll-left and scroll-right.
756 * window.c (HSCROLL_MAX): New macro.
757 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
758 overflow when requested scroll falls outside ptrdiff_t range.
760 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
762 * window.h (struct window): Change type of 'hscroll',
763 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
764 'last_modified' and 'last_overlay_modified' to EMACS_INT.
765 Adjust users accordingly.
766 * xdisp.c (try_cursor_movement): Replace type check with eassert.
767 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
768 from EMACS_INT to ptrdiff_t.
769 (make_window): Omit redundant initialization.
771 2012-06-28 Juanma Barranquero <lekktu@gmail.com>
773 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
775 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
777 * window.h (struct window): Change type of 'use_time' and
778 'sequence_number' from Lisp_Object to int.
779 * frame.c (make_frame): Adjust users accordingly.
780 * print.c (print_object): Likewise.
781 * window.c (select_window, Fwindow_use_time, make_parent_window)
782 (make_window): Likewise.
784 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
786 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
787 enabled with --enable-checking=[all,glyphs] configure option.
788 Fix GLYPH_DEBUG usage assuming that it may be undefined,
789 adjust comments accordingly.
790 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
791 undefined, adjust comments accordingly.
793 * scroll.c: Likewise.
794 * w32fns.c: Likewise.
795 * w32term.c: Likewise.
797 * xfaces.c: Likewise.
801 2012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
803 Generalize run-time debugging checks.
804 * dispextern.h (XASSERTS): Remove.
805 * fontset.c (xassert): Remove.
806 Convert from xassert to eassert.
807 * alloc.c: Convert from xassert to eassert.
809 * dispnew.c: Likewise.
811 * fringe.c: Likewise.
812 * ftfont.c: Likewise.
813 * gtkutil.c: Likewise.
815 * keyboard.c: Likewise.
817 * process.c: Likewise.
818 * scroll.c: Likewise.
821 * w32console.c: Likewise.
822 * w32fns.c: Likewise.
823 * w32term.c: Likewise.
824 * window.c: Likewise.
826 * xfaces.c: Likewise.
828 * xselect.c: Likewise.
831 2012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
833 * fns.c (maybe_resize_hash_table): Output message when growing the
836 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
838 * alloc.c (allocate_string_data): Remove dead code.
839 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
840 avoid GCC warning about unused macro.
842 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
844 * alloc.c (allocate_string): Omit intervals initialization.
845 * alloc.c (make_uninit_multibyte_string): Initialize intervals
846 as in make_pure_string and make_pure_c_string.
848 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
850 * alloc.c (allocate_string): Fix last change.
852 2012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
854 * alloc.c (allocate_string): Remove two redundant calls
855 to memset, add explicit initialization where appropriate.
857 2012-06-27 Glenn Morris <rgm@gnu.org>
859 * lisp.mk (lisp): Remove paths.elc.
861 2012-06-27 Chong Yidong <cyd@gnu.org>
863 * doc.c (Fsubstitute_command_keys): Fix punctuation.
865 2012-06-26 John Wiegley <johnw@newartisans.com>
867 * unexmacosx.c (copy_data_segment): Add two section names used
868 on Mac OS X Lion: __mod_init_func and __mod_term_func.
870 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
871 when building with Clang.
873 2012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
875 * eval.c (Fapply): Allow calling it with a single argument.
877 2012-06-26 Eli Zaretskii <eliz@gnu.org>
879 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
880 _stricmp and _strnicmp.
881 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
883 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
885 * alloc.c (allocate_window): Zero out non-Lisp part of newly
887 (allocate_process): Likewise for new process.
888 (allocate_terminal): Change to use offsetof.
889 (allocate_frame): Likewise.
890 * frame.c (make_frame): Omit redundant initialization.
891 * window.c (make_parent_window): Use memset.
892 (make_window): Omit redundant initialization.
893 * process.c (make_process): Omit redundant initialization.
894 * terminal.c (create_terminal): Likewise.
896 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
898 * term.c (delete_tty): Remove redundant call to memset.
900 2012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
902 * alloc.c: Remove build_string.
903 * lisp.h: Define build_string as static inline. This provides
904 a better opportunity to optimize away calls to strlen when the
905 function is called with compile-time constant argument.
906 * image.c (imagemagick_error): Convert to build_string.
907 * w32proc.c (sys_spawnve): Likewise.
908 * xterm.c (x_term_init): Likewise.
910 2012-06-26 Paul Eggert <eggert@cs.ucla.edu>
912 Use sprintf return value instead of invoking strlen on result.
913 In the old days this wasn't portable, since some sprintf
914 implementations returned char *. But they died out years ago and
915 Emacs already assumes sprintf returns int.
916 Similarly for float_to_string.
917 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
918 * ccl.c (ccl_driver):
919 * character.c (string_escape_byte8):
920 * data.c (Fnumber_to_string):
922 * print.c (print_object):
923 * xdisp.c (message_dolog):
924 * xfns.c (syms_of_xfns):
925 Use sprintf or float_to_string result to avoid need to call strlen.
926 * data.c (Fnumber_to_string):
927 Use make_unibyte_string, since the string must be ASCII.
928 * lisp.h, print.c (float_to_string): Now returns int length.
929 * term.c (produce_glyphless_glyph):
930 Use sprintf result rather than recomputing it.
932 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
933 * Makefile.in (ALL_CFLAGS):
934 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
935 * gmalloc.c, regex.c: Include <config.h> unconditionally.
937 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
939 * dispextern.h (xstrcasecmp): Define to library function
940 strcasecmp if available.
941 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
943 2012-06-25 Andreas Schwab <schwab@linux-m68k.org>
945 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
946 Avoid comma operator.
947 * menu.c (push_submenu_start, push_submenu_end)
948 (push_left_right_boundary, push_menu_pane): Likewise.
949 * msdos.c (dos_rawgetc): Likewise.
951 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
953 * xfns.c (xic_create_fontsetname): Remove redundant calls
956 2012-06-25 Paul Eggert <eggert@cs.ucla.edu>
958 * gtkutil.c (get_utf8_string): Remove redundant assignment.
959 sprintf already null-terminates its output.
961 * xfns.c (x_window): Remove redundant cast.
963 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
965 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
966 `const char *' to `char *' to avoid compiler warning.
968 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
970 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
971 instead of truncating it to 63 (admittedly a generous limit).
973 * process.c: Fix spelling and caps in comments.
975 2012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
977 * emacs.c (setpgrp): Remove definition, unused.
978 * sysdep.c (setpgrp): Remove definition, not used in this file.
980 2012-06-24 Juanma Barranquero <lekktu@gmail.com>
982 * makefile.w32-in: Update dependencies.
984 2012-06-24 Eli Zaretskii <eliz@gnu.org>
986 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
987 (SYSTIME_H): Add nt/inc/sys/time.h.
989 * systime.h [WINDOWSNT]: Include sys/time.h.
991 * s/ms-w32.h (struct timespec): Definition moved from
992 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
994 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
996 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
997 * buffer.h (buffer_slot_type_mismatch):
998 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
999 * eval.c (unwind_to_catch):
1000 * image.c (my_png_error, my_error_exit):
1001 * keyboard.c (quit_throw_to_read_char, user_error)
1002 (Fexit_recursive_edit, Fabort_recursive_edit):
1003 * lisp.h (die, args_out_of_range, args_out_of_range_3)
1004 (wrong_type_argument, buffer_overflow, __executable_start)
1005 (memory_full, buffer_memory_full, string_overflow, Fthrow)
1006 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
1007 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
1009 (child_setup) [!DOS_NT]:
1010 * lread.c (end_of_file_error, invalid_syntax):
1011 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
1012 * puresize.h (pure_write_error):
1013 * search.c (matcher_overflow):
1014 * sound.c (sound_perror, alsa_sound_perror):
1015 * sysdep.c, syssignal.h (croak):
1016 * term.c (maybe_fatal, vfatal):
1017 * textprop.c (text_read_only):
1018 * undo.c (user_error):
1019 * unexmacosx.c (unexec_error):
1020 * xterm.c (x_ins_del_lines, x_delete_glyphs):
1021 Use _Noreturn rather than NO_RETURN.
1022 No need for separate decl merely because of _Noreturn.
1023 * sound.c (sound_warning, parse_sound):
1024 Remove unnecessary forward decls.
1026 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
1028 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
1029 * lisp.h (WAIT_READING_MAX): New macro.
1030 * dispnew.c (Fsleep_for, sit_for):
1031 * keyboard.c (kbd_buffer_get_event):
1032 * process.c (Faccept_process_output):
1033 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
1034 This improves on the previous patch, which introduced a bug
1035 when time_t is unsigned and as wide as intmax_t.
1036 See <http://bugs.gnu.org/9000#51>.
1038 2012-06-23 Eli Zaretskii <eliz@gnu.org>
1040 * dispnew.c (sit_for, Fsleep_for):
1041 * keyboard.c (kbd_buffer_get_event):
1042 * process.c (Faccept_process_output): Avoid compiler warnings when
1043 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
1045 2012-06-23 Juanma Barranquero <lekktu@gmail.com>
1047 * makefile.w32-in: Update dependencies.
1049 * w32.c (ltime): Add return type and declare static.
1050 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
1052 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1054 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
1055 Privately reported by Herbert J. Skuhra.
1056 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
1058 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
1059 not make_lisp_timeval, when the argument is of type EMACS_TIME.
1061 2012-06-23 Eli Zaretskii <eliz@gnu.org>
1063 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
1064 last argument of make_unibyte_string.
1066 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
1067 language ID in the event parameters.
1069 * w32term.c (w32_read_socket): Put the new keyboard codepage into
1070 event.code, not the obscure "character set ID".
1072 2012-06-23 Chong Yidong <cyd@gnu.org>
1074 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
1076 2012-06-23 Eli Zaretskii <eliz@gnu.org>
1078 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
1079 * w32.c (fdutimens): New function.
1081 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
1083 * s/ms-w32.h (pselect): Redirect to sys_select.
1085 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
1087 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
1088 in the logic of incrementing and decrementing the value of
1089 use_relocatable_buffers.
1091 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1093 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
1094 Privately reported by Herbert J. Skuhra.
1095 [__FreeBSD__]: Remove "*/" typo after "#include".
1096 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
1097 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
1098 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
1099 Don't assume EMACS_TIME and struct timeval are the same type.
1101 2012-06-22 Paul Eggert <eggert@cs.ucla.edu>
1103 Support higher-resolution time stamps (Bug#9000).
1104 The time stamps are only nanosecond-resolution at the C level,
1105 since that's the best that any real-world system supports now.
1106 But they are picosecond-resolution at the Lisp level, as that's
1107 easy, and leaves room for future OS improvements.
1109 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
1112 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
1113 Don't get current time unless it's needed.
1115 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
1116 now provides it if it's absent.
1117 (start_atimer): Port to higher-res time stamps.
1118 Check for time stamp overflow. Don't get current time more
1119 often than is needed.
1121 * buffer.h (struct buffer): Buffer modtime now has high resolution.
1122 Include systime.h, not time.h.
1123 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
1125 * dired.c: Include stat-time.h.
1126 (Ffile-attributes): File times now have higher resolution.
1128 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
1129 (struct image): Timestamp now has higher resolution.
1131 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
1132 has at least microseconds now. All uses removed.
1133 (update_frame, update_single_window, update_window, update_frame_1)
1134 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
1136 * editfns.c (time_overflow): Now extern.
1137 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
1138 (float-time, Fformat_time_string, Fcurrent_time_string)
1139 (Fcurrent_time_zone): Accept and generate higher-resolution
1141 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
1142 (decode_time_components, lisp_seconds_argument): New functions.
1143 (make_time): Now static.
1144 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
1145 Report an error if the time is invalid, rather than having the caller
1148 * fileio.c: Include <stat-time.h>
1149 (Fcopy_file): Copy higher-resolution time stamps.
1150 Prefer to set the time stamp via a file descriptor if that works.
1151 (Fset_file_times, Finsert_file_contents, Fwrite_region)
1152 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
1153 (Fvisited_file_modtime, Fset_visited_file_modtime):
1154 Support higher-resolution time stamps.
1156 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
1158 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
1160 * image.c (prepare_image_for_display, clear_image_cache)
1161 (lookup_image): Port to higer-resolution time stamps.
1163 * keyboard.c (start_polling, bind_polling_period):
1164 Check for time stamp overflow.
1165 (read_char, kbd_buffer_get_event, timer_start_idle)
1166 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
1167 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
1168 Port to higher-resolution time stamps. Do not assume time_t is signed.
1169 (decode_timer): New function. Timers are now vectors of length 9,
1170 not 8, to accommodate the picosecond component.
1171 (timer_check_2): Use it.
1173 * nsterm.m (select_timeout, timeval_subtract): Remove.
1174 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
1175 as they're a bit more accurate and handle overflow better.
1176 (ns_select): Change prototype to be compatible with pselect.
1177 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
1178 * nsterm.h (ns_select): Adjust prototype.
1180 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
1181 us-resolution time stamps.
1182 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
1184 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
1186 * lisp.h (time_overflow): New decl.
1187 (wait_reading_process_output): First arg is now intmax_t, not int,
1188 to accommodate larger waits.
1190 * process.h (struct Lisp_Process.read_output_delay):
1191 Now counts nanoseconds, not microseconds.
1192 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
1194 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
1195 (wait_reading_process_output):
1196 Port to ns-resolution time stamps.
1197 (Faccept_process_output, wait_reading_process_output):
1198 Check for time stamp overflow. Do not assume time_t is signed.
1199 (select_wrapper): Remove; we now use pselect.
1200 (Fprocess_attributes): Now generates ns-resolution time stamps.
1202 * sysdep.c: Include utimens.h. Don't include utime.h
1203 or worry about struct utimbuf; gnulib does that for us now.
1204 (gettimeofday): Remove; gnulib provides a substitute.
1205 (make_timeval): New function.
1206 (set_file_times): Now sets ns-resolution time stamps.
1207 New arg FD; all uses changed.
1208 (time_from_jiffies, ltime_from_jiffies, get_up_time)
1209 (system_process_attributes):
1210 Now returns ns-resolution time stamp. All uses changed.
1211 Check for time stamp overflow.
1213 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
1214 provides a substitute now.
1216 * systime.h: Include timespec.h rather than sys/time.h and time.h,
1217 since it guarantees struct timespec.
1218 (EMACS_TIME): Now struct timespec, so that we can support
1219 ns-resolution time stamps.
1220 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
1221 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
1222 (EMACS_USECS): Remove.
1223 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
1224 so multiply the arg by 1000 before storing it.
1225 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
1227 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
1228 Port to ns-resolution time stamps.
1229 (EMACS_TIME_NEG_P): Remove; replaced by....
1230 (EMACS_TIME_SIGN): New macro.
1231 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
1232 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
1233 (set_file_times, make_time, lisp_time_argument): Adjust signature.
1234 (make_timeval, make_lisp_time, decode_time_components): New decls.
1235 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
1236 that it mishandled time_t overflow. You can't compare by subtracting!
1237 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
1238 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
1240 * term.c: Include <sys/time.h>.
1241 (timeval_to_Time): New function, for proper overflow wraparound.
1242 (term_mouse_position, term_mouse_click): Use it.
1244 * undo.c (record_first_change): Support higher-resolution time stamps
1246 (Fprimitive_undo): Use them when restoring time stamps.
1248 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
1249 (w32_get_internal_run_time):
1250 Port to higher-resolution Emacs time stamps.
1251 (ltime): Now accepts single 64-bit integer, as that's more convenient
1254 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
1256 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
1257 for compatibility with pselect. Support ns-resolution time stamps.
1259 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
1261 * xselect.c (wait_for_property_change, x_get_foreign_selection):
1262 Check for time stamp overflow, and support ns-resolution time stamps.
1264 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
1265 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
1266 (timeval_subtract): Remove; no longer needed.
1267 (XTflash, XTring_bell, x_wait_for_event):
1268 Port to ns-resolution time stamps. Don't assume time_t is signed.
1270 2012-06-22 Chong Yidong <cyd@gnu.org>
1272 * xdisp.c (x_consider_frame_title): Revert last change.
1274 2012-06-22 Eli Zaretskii <eliz@gnu.org>
1276 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
1277 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
1278 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
1279 staticidx goes up to 1597 out of 1600 = 0x640.)
1281 2012-06-20 Paul Eggert <eggert@cs.ucla.edu>
1283 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
1284 Otherwise, the umask might be mistakenly 0 while handling input signals.
1286 2012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
1288 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
1290 2012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
1292 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
1293 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
1294 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
1295 access to `contents' member of Lisp_Vector objects with AREF and ASET
1298 2012-06-19 Chong Yidong <cyd@gnu.org>
1300 * frame.c (delete_frame): When selecting a frame on a different
1301 text terminal, do not alter the terminal's top-frame.
1303 * xdisp.c (format_mode_line_unwind_data): Record the target
1304 frame's selected window and its terminal's top-frame.
1305 (unwind_format_mode_line): Restore them.
1306 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
1308 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
1309 since tty frames can be explicitly named.
1310 (prepare_menu_bars): Likewise.
1312 * term.c (Ftty_top_frame): New function.
1314 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1316 Port byte-code-meter to modern targets.
1317 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
1318 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
1319 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
1320 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
1321 (METER_1, METER_2): Simplify.
1323 2012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
1325 * data.c (Fdefalias): Return `symbol' (bug#11686).
1327 2012-06-18 Martin Rudalics <rudalics@gmx.at>
1329 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1330 gets killed during executing of this function (Bug#11665).
1331 Try to always return Qt when the buffer has been actually killed.
1332 (Vkill_buffer_query_functions): In doc-string say that functions
1333 run by this hook should not change the current buffer.
1335 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1337 Fix recently-introduced process.c problems found by static checking.
1338 * process.c (write_queue_push, write_queue_pop, send_process):
1339 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
1340 (write_queue_pop): Fix pointer signedness problem.
1341 (send_process): Remove unused local.
1343 2012-06-17 Chong Yidong <cyd@gnu.org>
1345 * xdisp.c (redisplay_internal): No need to redisplay terminal
1346 frames that are not on top.
1348 2012-06-17 Troels Nielsen <bn.troels@gmail.com>
1350 * process.c (make_process): Initialize write_queue.
1351 (write_queue_push, write_queue_pop): New functions.
1352 (send_process): Use them to maintain correct ordering of process
1355 2012-06-17 Paul Eggert <eggert@cs.ucla.edu>
1357 * lisp.h (eassert): Assume C89 or later.
1358 This removes the need for CHECK.
1359 (CHECK): Remove. Its comments about always evaluating its
1360 argument were confusing, as 'eassert' typically does not evaluate
1363 * coding.c (produce_chars): Use ptrdiff_t, not int.
1365 * xterm.c (x_draw_underwave): Check for integer overflow.
1366 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
1368 2012-06-17 Jan Djärv <jan.h.d@swipnet.se>
1370 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
1371 referenced (Bug#11583).
1373 2012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
1375 Implement wave-style variant of underlining.
1376 * dispextern.h (face_underline_type): New enum.
1377 (face): Add field for underline type.
1378 * nsterm.m (ns_draw_underwave): New function.
1379 (ns_draw_text_decoration): Use it.
1380 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
1382 (x_draw_glyph_string): Use them.
1383 * xfaces.c (Qline, Qwave): New Lisp objects.
1384 (check_lface_attrs, merge_face_ref)
1385 (Finternal_set_lisp_face_attribute, realize_x_face):
1386 Handle wave-style underline face attributes.
1387 * xterm.c (x_draw_underwave): New function.
1388 (x_draw_glyph_string): Use it.
1390 2012-06-16 Juanma Barranquero <lekktu@gmail.com>
1392 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
1393 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
1394 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
1395 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
1396 ($(BLD)/w32select.$(O)): Update dependencies.
1398 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1400 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
1401 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
1402 * character.c (_fetch_multibyte_char_p): Remove.
1403 * alloc.c: Include "character.h" before "buffer.h".
1405 * buffer.c: Likewise.
1406 * bytecode.c: Likewise.
1407 * callint.c: Likewise.
1408 * callproc.c: Likewise.
1409 * casefiddle.c: Likewise.
1410 * casetab.c: Likewise.
1411 * category.c: Likewise.
1413 * coding.c: Likewise.
1414 * composite.c: Likewise.
1415 * dired.c: Likewise.
1416 * dispnew.c: Likewise.
1418 * dosfns.c: Likewise.
1419 * editfns.c: Likewise.
1420 * emacs.c: Likewise.
1421 * fileio.c: Likewise.
1422 * filelock.c: Likewise.
1424 * fontset.c: Likewise.
1425 * fringe.c: Likewise.
1426 * indent.c: Likewise.
1427 * insdel.c: Likewise.
1428 * intervals.c: Likewise.
1429 * keyboard.c: Likewise.
1430 * keymap.c: Likewise.
1431 * lread.c: Likewise.
1432 * macros.c: Likewise.
1433 * marker.c: Likewise.
1434 * minibuf.c: Likewise.
1435 * nsfns.m: Likewise.
1436 * nsmenu.m: Likewise.
1437 * print.c: Likewise.
1438 * process.c: Likewise.
1439 * regex.c: Likewise.
1440 * region-cache.c: Likewise.
1441 * search.c: Likewise.
1442 * syntax.c: Likewise.
1444 * textprop.c: Likewise.
1446 * unexsol.c: Likewise.
1447 * w16select.c: Likewise.
1448 * w32fns.c: Likewise.
1449 * w32menu.c: Likewise.
1450 * window.c: Likewise.
1451 * xdisp.c: Likewise.
1453 * xmenu.c: Likewise.
1455 * xselect.c: Likewise.
1457 2012-06-16 Eli Zaretskii <eliz@gnu.org>
1459 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
1460 If all the glyphs of the glyph row came from strings, and we have no
1461 cursor positioning clues, put the cursor on the first glyph of the
1463 (handle_face_prop): Use chunk-relative overlay string index when
1464 indexing into it->string_overlays array. (Bug#11653)
1465 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
1466 the rightmost. (Bug#11720)
1468 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1470 * category.h (CHAR_HAS_CATEGORY): Define as inline.
1471 (CATEGORY_MEMBER): Enforce 1/0 value.
1472 * category.c (_temp_category_set): Remove.
1474 2012-06-16 Eli Zaretskii <eliz@gnu.org>
1476 * window.c (Fdelete_other_windows_internal)
1477 (Fdelete_window_internal): Don't access frame's mouse highlight
1478 info of the initial frame. (Bug#11677)
1480 2012-06-14 Paul Eggert <eggert@cs.ucla.edu>
1482 * .gdbinit (xgetint): Fix recently-introduced paren typo.
1483 Assume USE_2_TAGS_FOR_INTS.
1484 (xreload): Adjust $tagmask width to match recent lisp.h change.
1486 Simplify lisp.h in minor ways that should not affect code.
1487 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
1488 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
1489 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
1490 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
1491 (INTTYPEBITS): New macro, for clarity.
1492 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1493 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
1494 Simplify now that USE_LSB_TAG is always defined.
1495 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
1496 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
1498 2012-06-13 Juanma Barranquero <lekktu@gmail.com>
1500 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
1502 2012-06-13 Glenn Morris <rgm@gnu.org>
1504 * s/bsd-common.h (BSD4_3):
1505 * s/usg5-4-common.h (USG5_4): No longer define; unused.
1507 2012-06-13 Andreas Schwab <schwab@linux-m68k.org>
1509 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
1512 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
1514 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
1515 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1516 * alloc.c (widen_to_Lisp_Object): Remove.
1517 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
1518 * frame.c (delete_frame): Remove outdated comment.
1519 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
1520 USE_LISP_UNION_TYPE.
1521 (Fw32_unregister_hot_key): Likewise.
1522 (Fw32_toggle_lock_key): Likewise.
1523 * w32menu.c (add_menu_item): Likewise.
1524 (w32_menu_display_help): Use XIL instead of checking
1525 USE_LISP_UNION_TYPE.
1526 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
1527 (init_heap): Likewise.
1528 * w32term.c (w32_read_socket): Update comment.
1530 2012-06-13 Glenn Morris <rgm@gnu.org>
1532 * s/usg5-4-common.h, src/s/unixware.h:
1533 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
1535 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
1537 2012-06-13 Paul Eggert <eggert@cs.ucla.edu>
1539 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
1540 * alloc.c (make_number) [!defined make_number]:
1541 Remove, as lisp.h always defines this now.
1542 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
1543 (roundup_size): Verify that it is a power of 2.
1544 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
1545 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
1546 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
1547 -DUSE_LSB_TAG=0, to override the automatically-selected default.
1548 USE_LSB_TAG now is always defined to be either 0 or 1.
1550 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
1551 code works fine either way, and efficiency is not a concern here,
1552 as the union type is for debugging, not for production.
1553 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
1554 Use an inline function on all platforms when using the union type,
1555 since this is simpler and 'static inline' can be used portably
1557 (LISP_INITIALLY_ZERO): New macro.
1558 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
1559 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
1561 2012-06-12 Glenn Morris <rgm@gnu.org>
1563 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
1565 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
1567 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
1568 Move BROKEN_SIGIO to configure.
1570 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
1571 Move NO_TERMIO to configure.
1573 2012-06-12 Chong Yidong <cyd@gnu.org>
1575 * image.c (imagemagick_load_image): Use MagickFlattenImage if
1576 MagickMergeImageLayers is undefined. Use pixel pusher loop if
1577 MagickExportImagePixels is undefined.
1579 2012-06-12 Paul Eggert <eggert@cs.ucla.edu>
1581 * image.c (imagemagick_load_image): Remove unused label.
1583 2012-06-11 Glenn Morris <rgm@gnu.org>
1585 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1586 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
1587 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
1588 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
1590 2012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
1592 * alloc.c (make_byte_code): New function.
1593 (Fmake_byte_code): Use it. Don't purify here.
1594 * lread.c (read1): Use it as well to avoid extra allocation.
1596 2012-06-11 Chong Yidong <cyd@gnu.org>
1598 * image.c (imagemagick_load_image): Implement transparency.
1600 2012-06-10 Andreas Schwab <schwab@linux-m68k.org>
1602 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
1603 account for preceding backslashes. (Bug#11663)
1605 2012-06-09 Chong Yidong <cyd@gnu.org>
1607 * term.c: Support italics in capable terminals (Bug#9652).
1608 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
1609 (turn_on_face): Output using TS_enter_italic_mode if available.
1610 Don't handle unused blinking and alt-charset cases.
1611 (turn_off_face): Handle italic case; discard unused tty_blinking_p
1612 and tty_alt_charset_p cases.
1613 (tty_capable_p, init_tty): Support italics.
1615 * termchar.h (struct tty_display_info): Add field for italics.
1616 Remove unused blink field.
1618 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
1621 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
1622 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
1623 tty_alt_charset_p. Add tty_italic_p.
1625 2012-06-09 Michael Albinus <michael.albinus@gmx.de>
1627 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
1628 dbus_type_is_basic if available.
1629 (xd_extract_signed, xd_extract_unsigned): Rename from
1630 extract_signed and extract_unsigned, respectively. Adapt callers.
1632 2012-06-09 Chong Yidong <cyd@gnu.org>
1634 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
1636 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
1639 2012-06-08 Paul Eggert <eggert@cs.ucla.edu>
1641 * xdisp.c (vmessage): Treat frame message as multibyte.
1642 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
1643 would generate the diagnostic "Making \302\247 buffer-local while
1646 2012-06-08 Eli Zaretskii <eliz@gnu.org>
1648 * dispnew.c (showing_window_margins_p): Undo last change, which
1649 was done due to an inadvertent commit.
1650 (adjust_frame_glyphs_for_frame_redisplay): Do call
1651 showing_window_margins_p.
1653 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1655 * eval.c (Fmake_var_non_special): New primitive.
1656 (syms_of_eval): Defsubr it.
1657 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
1659 2012-06-08 Juanma Barranquero <lekktu@gmail.com>
1661 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
1662 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
1664 2012-06-08 Eli Zaretskii <eliz@gnu.org>
1666 * alloc.c (allocate_vectorlike): Fix last change.
1668 2012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
1670 Block-based vector allocation of small vectors.
1671 * lisp.h (struct vectorlike_header): New field `nbytes',
1672 adjust comment accordingly.
1673 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
1674 to denote vector blocks. Adjust users (live_vector_p,
1675 mark_maybe_pointer, valid_lisp_object_p) accordingly.
1676 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
1677 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
1678 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
1679 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
1680 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
1681 (roundup_size): New constant.
1682 (struct vector_block): New data type.
1683 (vector_blocks, vector_free_lists, zero_vector): New variables.
1684 (all_vectors): Rename to `large_vectors'.
1685 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
1686 (sweep_vectors): New functions.
1687 (allocate_vectorlike): Return `zero_vector' as the only vector of
1688 0 items. Allocate new vector from block if vector size is less than
1689 or equal to VBLOCK_BYTES_MAX.
1690 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
1691 (init_alloc_once): Add call to init_vectors.
1693 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1695 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
1697 2012-06-07 Paul Eggert <eggert@cs.ucla.edu>
1699 * doprnt.c (doprnt): Truncate multibyte char correctly.
1700 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
1701 would mishandle a string argument "Xc" if X was a multibyte
1702 character of length 2: it would truncate after X's first byte
1703 rather than including all of X.
1705 2012-06-06 Chong Yidong <cyd@gnu.org>
1707 * buffer.c (word_wrap): Doc fix.
1709 2012-06-04 Paul Eggert <eggert@cs.ucla.edu>
1711 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
1713 2012-06-03 Glenn Morris <rgm@gnu.org>
1715 * xdisp.c (tool-bar-style): Doc fix.
1717 2012-06-03 Ulrich Müller <ulm@gentoo.org>
1719 * Makefile.in (PAXCTL): Define.
1720 (temacs$(EXEEXT)): Disable memory randomization for the temacs
1721 binary via PaX flags if the paxctl utility is available.
1722 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
1723 Restore PaX flags to their default. (Bug#11398)
1725 2012-06-03 Chong Yidong <cyd@gnu.org>
1727 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
1730 2012-06-03 Chong Yidong <cyd@gnu.org>
1732 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
1733 (note_mode_line_or_margin_highlight): If there is no help echo,
1734 use mode-line-default-help-echo. Handle the case where the mouse
1735 position is past the end of the mode line string.
1737 * buffer.c (buffer_local_value_1): New function, split from
1738 Fbuffer_local_value; can return Qunbound.
1739 (Fbuffer_local_value): Use it.
1740 (Vmode_line_format): Docstring tweaks.
1742 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1744 * sysdep.c (system_process_attributes): Improve comment.
1746 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
1748 * keyboard.c: Export real-this-command to Elisp.
1749 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
1750 and DEFVAR it. Update all users.
1752 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1754 * minibuf.c (Fassoc_string): Remove duplicate declaration.
1756 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
1757 Convert pctcpu and pctmem to Lisp float properly.
1758 Let the compiler fold better, as 100.0/0x8000 is exact.
1760 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
1762 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
1765 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
1767 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
1769 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
1771 For a 'struct window', replace some Lisp_Object fields to
1772 bitfields where appropriate, remove unused fields.
1773 * window.h (struct window): Remove unused 'last_mark_x' and
1774 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
1775 change it's type from Lisp_Object to bitfield.
1776 Change type of 'force_start', 'optional_new_start',
1777 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
1778 fields from Lisp_Object to bitfield. Adjust users accordingly.
1780 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1782 Pacify gcc -Wdouble-precision when using Xaw.
1783 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
1784 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
1785 Use 'float' consistently, rather than 'float' in most places
1786 and 'double' in a couple of places.
1788 2012-05-31 Eli Zaretskii <eliz@gnu.org>
1790 * xdisp.c (handle_stop): Detect whether we have overlay strings
1791 loaded by testing it->current.overlay_string_index to be
1792 non-negative, instead of checking whether n_overlay_strings is
1793 positive. (Bug#11587)
1795 2012-05-31 Chong Yidong <cyd@gnu.org>
1797 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
1799 * doc.c (Fsubstitute_command_keys): Doc fix.
1801 2012-05-31 Eli Zaretskii <eliz@gnu.org>
1803 * search.c (search_buffer): Remove calls to
1804 r_alloc_inhibit_buffer_relocation, as it is now called by
1805 maybe_unify_char, which was the cause of relocation of buffer text
1808 2012-05-31 Eli Zaretskii <eliz@gnu.org>
1810 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
1811 for the duration of call to load_charset, to avoid problems with
1812 callers of maybe_unify_char that access buffer text through C
1815 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
1816 decrement the inhibition flag, instead of just setting or
1819 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1821 Remove obsolete '#define static' cruft.
1822 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
1823 This #undef was "temporary" in 2000; it is no longer needed
1824 now that '#define static' has gone away.
1825 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
1826 (gray_bitmap_bits): Remove; no longer needed.
1827 All uses replaced with definiens.
1828 * xterm.c: Include "bitmaps/gray.xbm".
1830 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1832 Clean up __executable_start, monstartup when --enable-profiling.
1833 The following changes affect the code only when profiling.
1834 * dispnew.c (__executable_start): Rename from safe_bcopy.
1835 Define only on platforms that need it.
1836 * emacs.c: Include <sys/gmon.h> when profiling.
1837 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
1838 (__executable_start): Remove decl, since lisp.h does it now.
1839 (safe_bcopy): Remove decl; no longer has that name.
1840 (main): Coalesce #if into single bit of code, for simplicity.
1841 Cast pointers to uintptr_t, since standard libraries want integers
1843 * lisp.h (__executable_start): New decl.
1845 2012-05-31 Glenn Morris <rgm@gnu.org>
1847 * image.c (Fimagemagick_types): Doc fix.
1849 2012-05-30 Jim Meyering <meyering@redhat.com>
1851 * callproc.c (Fcall_process_region): Include directory component
1852 in mkstemp error message (Bug#11586).
1854 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1856 * alloc.c, lisp.h (make_pure_vector): Now static.
1858 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
1860 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
1861 Move to byte-run.el.
1862 (Fautoload): Do the hash-doc more carefully.
1863 * data.c (Fdefalias): Purify definition, except for keymaps.
1864 (Qdefun): Move from eval.c.
1865 * lisp.h (Qdefun): Remove.
1866 * lread.c (read1): Tiny simplification.
1868 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
1870 Do not create empty overlays with the evaporate property (Bug#9642).
1871 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
1872 Bug#9642, but explicitly check that the buffer the overlay would
1873 be moved to is live and rearrange lines to make sure that errors
1874 will not put the overlay in an inconsistent state.
1875 (Fdelete_overlay): Cosmetics.
1877 2012-05-28 Eli Zaretskii <eliz@gnu.org>
1879 * w32term.c (my_bring_window_to_top): New function.
1880 (x_raise_frame): Use handle returned by DeferWindowPos, which
1881 could be different from the original one.
1882 Call my_bring_window_to_top instead of my_set_foreground_window.
1885 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
1886 by calling BringWindowToTop.
1888 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
1889 (WM_EMACS_END): Increase by one.
1891 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
1893 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
1894 This avoids undefined behavior that might cause the eassert
1895 to not catch an out-of-range value.
1897 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
1899 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
1900 Update dependencies.
1902 2012-05-27 Eli Zaretskii <eliz@gnu.org>
1904 * bidi.c (bidi_mirror_char): Fix last change.
1906 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
1908 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
1909 when referring to sectname field in printf format.
1911 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
1913 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
1914 Only r_alloc_inhibit_buffer_relocation needed to be added;
1915 the others were already declared.
1917 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
1918 before checking whether it's out of range. Put the check inside
1920 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
1922 2012-05-27 Ken Brown <kbrown@cornell.edu>
1924 * callproc.c (Fcall_process): Restore a line that was accidentally
1925 commented out in the 2011-02-13 change (bug#11547).
1927 2012-05-27 Eli Zaretskii <eliz@gnu.org>
1929 * lisp.h [REL_ALLOC]: Add prototypes for external functions
1930 defined on ralloc.c.
1932 * buffer.c [REL_ALLOC]: Remove prototypes of
1933 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
1934 they are now on lisp.h.
1936 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
1938 * search.c (search_buffer): Use it to inhibit relocation of buffer
1939 text while re_search_2 is doing its job, because re_search_2 is
1940 passed C pointers to buffer text. (Bug#11519)
1942 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
1945 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
1946 state after an additional call to move_it_in_display_line_to, keep
1947 the values of it->max_ascent and it->max_descent found for the
1949 (pos_visible_p): Revert the comparison against bottom_y to what it
1950 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
1953 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1955 Fix coding-related core dumps with gcc -ftrapv.
1956 The code was computing A - B, where A and B are pointers, and B is
1957 random garbage. This can lead to core dumps on platforms that
1958 have special pointer registers, and it also leads to core dumps on
1959 x86-64 when compiled with gcc -ftrapv. The fix is to compute
1960 A - B only when B is initialized properly.
1961 * coding.c (coding_set_source, coding_set_destination): Return void.
1962 (coding_change_source, coding_change_destinations): New functions,
1963 with the old behaviors of coding_set_source and coding_set_destination.
1964 All callers that need an offset changed to use these new functions.
1966 2012-05-26 Glenn Morris <rgm@gnu.org>
1968 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
1970 2012-05-26 Eli Zaretskii <eliz@gnu.org>
1972 Extend mouse support on W32 text-mode console.
1973 * xdisp.c (draw_row_with_mouse_face):
1974 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
1976 * w32console.c: Include window.h.
1977 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
1979 (initialize_w32_display): Initialize mouse-highlight data.
1981 * w32inevt.c: Include termchar.h and window.h.
1982 (do_mouse_event): Support mouse-autoselect-window. When the mouse
1983 moves, call note_mouse_highlight. If help_echo changed, call
1984 gen_help_event to produce help-echo message in the echo area.
1985 Call clear_mouse_face if mouse_face_hidden is set in the mouse
1988 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1990 * lread.c (read1): Simplify slightly to avoid an overflow warning
1991 with GCC 4.7.0 on x86-64.
1993 2012-05-26 Eli Zaretskii <eliz@gnu.org>
1995 * bidi.c (bidi_mirror_char): Revert last change: an int is
1996 definitely wide enough here.
1998 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
2000 Fix integer width and related bugs (Bug#9874).
2001 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
2002 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
2003 (string_bytes, check_sblock, allocate_string_data):
2004 (compact_small_strings, Fmake_bool_vector, make_string)
2005 (make_unibyte_string, make_multibyte_string)
2006 (make_string_from_bytes, make_specified_string)
2007 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
2008 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
2010 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2011 (allocate_pseudovector):
2012 Use int, not EMACS_INT, where int is wide enough.
2013 (inhibit_garbage_collection, Fgarbage_collect):
2014 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2015 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
2016 int might not be wide enough.
2017 (bidi_cache_search, bidi_cache_find, bidi_init_it)
2018 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
2019 (bidi_at_paragraph_end, bidi_find_paragraph_start)
2020 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
2021 (bidi_level_of_next_char, bidi_move_to_visually_next):
2022 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2023 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
2024 (Fkill_buffer, Fset_buffer_major_mode)
2025 (advance_to_char_boundary, Fbuffer_swap_text)
2026 (Fset_buffer_multibyte, overlays_at, overlays_in)
2027 (overlay_touches_p, struct sortvec, record_overlay_string)
2028 (overlay_strings, recenter_overlay_lists)
2029 (adjust_overlays_for_insert, adjust_overlays_for_delete)
2030 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
2031 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
2032 (Foverlay_recenter, last_overlay_modification_hooks_used)
2033 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
2034 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2035 (validate_region): Omit unnecessary test for b <= e,
2036 since that's guaranteed by the previous test.
2037 (adjust_overlays_for_delete): Avoid pos + length overflow.
2038 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
2039 (report_overlay_modification):
2040 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2041 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
2042 Omit pointer cast, which isn't needed anyway, and doesn't work
2043 after the EMACS_INT -> ptrdiff_t change.
2044 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
2045 * buffer.h: Adjust decls to match defn changes elsewhere.
2046 (struct buffer_text, struct buffer):
2047 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2048 Use EMACS_INT, not int, where int might not be wide enough.
2049 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
2050 not int, to avoid needless 32-bit limit on 64-bit hosts.
2051 (exec_byte_code): Use tighter memory-full test, one that checks
2052 for alloca overflow. Don't compute the address of the object just
2053 before an array, as that's not portable. Use EMACS_INT, not
2054 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
2055 * callint.c (Fcall_interactively):
2056 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2057 * callproc.c (call_process_kill, Fcall_process):
2058 Don't assume pid_t fits into an Emacs fixnum.
2059 (call_process_cleanup, Fcall_process, child_setup):
2060 Don't assume pid_t fits into int.
2061 (call_process_cleanup, Fcall_process, delete_temp_file)
2062 (Fcall_process_region):
2063 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2064 (Fcall_process): Simplify handling of volatile integers.
2065 Use int, not EMACS_INT, where int will do.
2066 * casefiddle.c (casify_object, casify_region, operate_on_word)
2067 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
2068 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2069 (casify_object): Avoid integer overflow when overallocating buffer.
2070 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
2071 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
2072 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
2073 * category.h (CATEGORYP): Don't assume arg is nonnegative.
2074 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
2075 integers are now checked earlier. All uses replaced with XINT.
2077 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2078 For CCL_MapSingle, check that content and value are in int range.
2079 (ccl_driver, Fregister_code_conversion_map):
2080 Check that Vcode_version_map_vector is a vector.
2081 (resolve_symbol_ccl_program): Check that vector header is in range.
2082 Always copy the vector, so that we can check its contents reliably
2083 now rather than having to recheck each instruction as it's being
2084 executed. Check that vector words fit in 'int'.
2085 (ccl_get_compiled_code, Fregister_ccl_program)
2086 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
2087 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
2088 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
2089 contents are in range.
2090 (Fccl_execute_on_string): Check that status is in range.
2091 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
2092 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
2093 Accept and return EMACS_INT, not int, because callers can pass values
2095 (c_string_width, strwidth, lisp_string_width, chars_in_text)
2096 (multibyte_chars_in_text, parse_str_as_multibyte)
2097 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
2098 (str_as_unibyte, str_to_unibyte, string_count_byte8)
2099 (string_escape_byte8, Fget_byte):
2100 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2101 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
2102 avoid mishandling large integers.
2103 * character.h: Adjust decls to match defn changes elsewhere.
2104 * charset.c (load_charset_map_from_file, find_charsets_in_text)
2105 (Ffind_charset_region):
2106 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2107 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
2108 (load_charset_map_from_vector, Fdefine_charset_internal):
2109 Don't assume fixnum fits in int.
2110 (load_charset_map_from_vector, Fmap_charset_chars):
2111 Remove now-unnecessary CHECK_NATNUMs.
2112 (Fdefine_charset_internal): Check ranges here, more carefully.
2113 Don't rely on undefined behavior with signed left shift overflow.
2114 Don't assume unsigned int fits into fixnum, or that fixnum fits
2115 into unsigned int. Don't require max_code to be a valid fixnum;
2116 that's not true for gb10830 4-byte on a 32-bit host. Allow
2117 invalid_code to be a cons, for the same reason. Require code_offset
2118 to be a character. Avoid int overflow if max_char is close
2120 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
2121 this is intended anyway and avoids some undefined behavior.
2122 (load_charset_map): Pass unsigned, not int, as 2nd arg of
2123 INDEX_TO_CODE_POINT, as that's what it expects.
2124 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
2125 * charset.h (DECODE_CHAR): Return int, not unsigned;
2126 this is what was intended anyway, and it avoids undefined behavior.
2127 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
2128 integer-overflow issues.
2129 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
2130 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
2131 where the argument is EMACS_INT, and this behavior is not intended.
2132 * chartab.c (Fmake_char_table, Fset_char_table_range)
2133 (uniprop_get_decoder, uniprop_get_encoder):
2134 Don't assume fixnum fits in int.
2135 * cmds.c (move_point): New function, that does the gist of
2136 Fforward_char and Fbackward_char, but does so while checking
2137 for integer overflow more accurately.
2138 (Fforward_char, Fbackward_char): Use it.
2139 (Fforward_line, Fend_of_line, internal_self_insert)
2140 (internal_self_insert):
2141 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2142 Fix a FIXME, by checking for integer overflow when calculating
2143 target_clm and actual_clm.
2144 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
2145 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
2146 (ASSURE_DESTINATION, coding_alloc_by_realloc)
2147 (coding_alloc_by_making_gap, alloc_destination)
2148 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
2149 (encode_coding_utf_16, detect_coding_emacs_mule)
2150 (decode_coding_emacs_mule, encode_coding_emacs_mule)
2151 (detect_coding_iso_2022, decode_coding_iso_2022)
2152 (encode_invocation_designation, encode_designation_at_bol)
2153 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2154 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
2155 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
2156 (encode_coding_ccl, encode_coding_raw_text)
2157 (detect_coding_charset, decode_coding_charset)
2158 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
2159 (produce_composition, produce_charset, produce_annotation)
2160 (decode_coding, handle_composition_annotation)
2161 (handle_charset_annotation, consume_chars, decode_coding_gap)
2162 (decode_coding_object, encode_coding_object, detect_coding_system)
2163 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
2164 (code_convert_region, code_convert_string)
2165 (Fdefine_coding_system_internal)
2166 (coding_set_source, coding_set_destination):
2167 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2168 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
2169 (Fdefine_coding_system_internal):
2170 Don't assume fixnums fit in int.
2171 (decode_coding_gap, decode_coding_object, encode_coding_object)
2172 (Fread_coding_system, Fdetect_coding_region)
2173 (Funencodable_char_position, Fcheck_coding_systems_region)
2174 (get_translation, handle_composition_annotation, consume_chars):
2175 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2176 (consume_chars): Rewrite to not calculate an address outside buffer.
2177 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
2178 Don't access memory outside of the args array.
2179 (Fdefine_coding_system_internal): Check for charset-id overflow.
2180 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
2181 result of ENCODE_CHAR.
2182 * coding.h: Adjust decls to match defn changes elsewhere.
2183 (struct coding_system):
2184 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2185 * composite.c (get_composition_id, find_composition)
2186 (run_composition_function, update_compositions)
2187 (compose_text, composition_gstring_put_cache)
2188 (composition_gstring_p, composition_gstring_width)
2189 (fill_gstring_header, fill_gstring_body, autocmp_chars)
2190 (composition_compute_stop_pos, composition_reseat_it)
2191 (composition_update_it, struct position_record)
2192 (find_automatic_composition, composition_adjust_point)
2193 (Fcomposition_get_gstring, Ffind_composition_internal):
2194 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2195 (update_compositions):
2196 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2197 * composite.h: Adjust decls to match defn changes elsewhere.
2198 (struct composition):
2199 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2200 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
2201 Do not attempt to compute the address of the object just before a
2202 buffer; this is not portable.
2204 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2205 (Faset): Use int, not EMACS_INT, where int is wide enough.
2206 (Fstring_to_number): Don't assume fixnums fit in int.
2207 (Frem): Don't assume arg is nonnegative.
2208 * dbusbind.c (xd_append_arg): Check for integers out of range.
2209 (Fdbus_call_method): Don't overflow the timeout int.
2210 (extract_signed, extract_unsigned): New functions.
2211 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
2212 (xd_get_connection_references): Return ptrdiff_t, not int.
2214 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
2215 (xd_read_message_1):
2216 Use int, not unsigned, where the dbus API uses int.
2217 (Fdbus_message_internal): Don't overflow mtype.
2218 (syms_of_dbusbind): Allocate right-sized buffer for integers.
2219 * dired.c (directory_files_internal, file_name_completion, scmp)
2220 (file_name_completion_stat):
2221 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2222 (file_name_completion): Don't overflow matchcount.
2223 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
2224 * dispextern.h: Adjust decls to match defn changes elsewhere.
2225 (struct text_pos, struct glyph, struct bidi_saved_info)
2226 (struct bidi_string_data, struct bidi_it, struct composition_it)
2228 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2229 (struct display_pos, struct composition_it, struct it):
2230 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2231 * dispnew.c (increment_matrix_positions)
2232 (increment_row_positions, mode_line_string)
2233 (marginal_area_string):
2234 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2235 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
2236 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2237 (duration_to_sec_usec): New function, to check for overflow better.
2238 (Fsleep_for, sit_for): Use it.
2239 * doc.c (get_doc_string, store_function_docstring):
2240 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2241 (get_doc_string, Fsnarf_documentation):
2242 Use int, not EMACS_INT, where int is wide enough.
2244 Use SAFE_ALLOCA, not alloca.
2245 Check for overflow when converting EMACS_INT to off_t.
2246 * doprnt.c (doprnt):
2247 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2248 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
2249 Don't assume uid_t fits into fixnum.
2250 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
2251 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
2252 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
2253 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
2254 (general_insert_function)
2255 (Finsert_char, make_buffer_string, make_buffer_string_both)
2256 (update_buffer_properties, Fbuffer_substring)
2257 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
2258 (Fsubst_char_in_region, check_translation)
2259 (Ftranslate_region_internal, save_restriction_restore, Fformat)
2260 (transpose_markers, Ftranspose_regions):
2261 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2262 (clip_to_bounds): Move to lisp.h as an inline function).
2263 (Fconstrain_to_field): Don't assume integers are nonnegative.
2264 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
2265 (Fsubst_char_in_region, Fsave_restriction):
2266 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2267 (Femacs_pid): Don't assume pid_t fits into fixnum.
2268 (lo_time): Use int, not EMACS_INT, when int suffices.
2269 (lisp_time_argument): Check for usec out of range.
2270 (Fencode_time): Don't assume fixnum fits in int.
2271 (Fuser_login_name, Fuser_full_name): Signal an error
2272 if a uid argument is out of range, rather than relying on
2274 (Fformat_time_string): Remove now-unnecessary check.
2275 lisp_time_argument checks for out-of-range usec now.
2276 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
2277 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
2278 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
2279 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
2280 (init_cmdargs, Fdump_emacs):
2281 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2282 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
2283 the bottom (typically) 32 bits of the fixnum.
2284 * eval.c (specpdl_size, call_debugger):
2285 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2286 (when_entered_debugger, Fbacktrace_debug):
2287 Don't assume fixnum can fit in int.
2288 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
2289 the object just before a buffer; this is not portable.
2290 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
2291 (grow_specpdl, unbind_to):
2292 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2293 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
2294 (grow_specpdl): Simplify allocation by using xpalloc.
2295 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
2296 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
2297 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
2298 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2299 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
2301 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2302 (Fcopy_file, non_regular_nbytes, read_non_regular)
2303 (Finsert_file_contents):
2304 Use int, not EMACS_INT, where int is wide enough.
2305 (READ_BUF_SIZE): Verify that it fits in int.
2306 (Finsert_file_contents): Check that counts are in proper range,
2307 rather than assuming fixnums fit into ptrdiff_t etc.
2308 Don't assume fixnums fit into int.
2309 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
2310 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
2311 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
2312 (string_char_to_byte, string_byte_to_char)
2313 (string_make_multibyte, string_to_multibyte)
2314 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
2315 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
2316 (substring_both, Fdelete, internal_equal, Ffillarray)
2317 (Fclear_string, mapcar1)
2318 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
2319 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
2320 (larger_vector, make_hash_table, maybe_resize_hash_table)
2321 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
2322 (Fmaphash, secure_hash):
2323 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2324 (concat): Check for string index and length overflow.
2325 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
2327 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2328 (larger_vector): New API (vec, incr_min, size_max) replaces old
2329 one (vec, new_size, init). This catches size overflow.
2330 INIT was removed because it was always Qnil.
2331 All callers changed.
2332 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
2333 the upper bound on a hash table index size.
2334 (make_hash_table, maybe_resize_hash_table): Use it.
2335 (secure_hash): Computer start_byte and end_byte only after
2336 they're known to be in ptrdiff_t range.
2337 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
2338 (Ffont_get_glyphs, Ffont_at):
2339 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2340 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
2341 (Flist_fonts, Fopen_font):
2342 Don't assume fixnum can fit in int.
2343 (check_gstring): Don't assume index can fit in int.
2344 (font_match_p): Check that fixnum is a character, not a nonnegative
2345 fixnum, since the later code needs to stuff it into an int.
2346 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
2347 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
2348 conversion overflow issues.
2349 (Fopen_font): Check for integer out of range.
2350 (Ffont_get_glyphs): Don't assume index can fit in int.
2351 * font.h: Adjust decls to match defn changes elsewhere.
2352 * fontset.c (reorder_font_vector): Redo score calculation to avoid
2354 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
2355 printmax_t, where ptrdiff_t is wide enough.
2356 (Finternal_char_font):
2357 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2358 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
2359 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
2360 (Fset_frame_position, x_set_frame_parameters)
2361 (x_set_line_spacing, x_set_border_width)
2362 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
2363 Check that fixnums are in proper range for system types.
2364 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
2365 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2366 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
2367 Use SAFE_ALLOCA_LISP, not alloca.
2368 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
2369 intptr_t is wide enough.
2370 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
2371 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
2372 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
2373 Check for fixnum out of range.
2374 * ftfont.c (ftfont_list): Don't assume index fits in int.
2375 Check that fixnums are in proper range for system types.
2376 (ftfont_shape_by_flt):
2377 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2378 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2379 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2380 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
2381 Check that fixnums are in proper range for system types.
2382 * gnutls.h: Adjust decls to match defn changes elsewhere.
2383 * gtkutil.c (xg_dialog_run):
2384 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2385 (update_frame_tool_bar):
2386 Check that fixnums are in proper range for system types.
2387 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
2388 (lookup_image): Check that fixnums are in range for system types.
2389 * indent.c (last_known_column, last_known_column_point):
2390 (current_column_bol_cache):
2391 (skip_invisible, current_column, check_display_width):
2392 (check_display_width, scan_for_column, current_column_1)
2393 (Findent_to, Fcurrent_indentation, position_indentation)
2394 (indented_beyond_p, Fmove_to_column, compute_motion):
2395 (Fcompute_motion, Fvertical_motion):
2396 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2397 (last_known_column_modified): Use EMACS_INT, not int.
2398 (check_display_width):
2400 Check that fixnums and floats are in proper range for system types.
2401 (compute_motion): Don't assume index or fixnum fits in int.
2402 (compute_motion, Fcompute_motion):
2403 Use int, not EMACS_INT, when it is wide enough.
2404 (vmotion): Omit local var start_hpos that is always 0; that way
2405 we don't need to worry about overflow in expressions involving it.
2406 * indent.h: Adjust decls to match defn changes elsewhere.
2408 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2409 Use int, not EMACS_INT, where int is wide enough.
2410 Remove unused members ovstring_chars_done and tab_offset;
2412 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
2413 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
2414 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
2415 (make_gap, copy_text, insert, insert_and_inherit)
2416 (insert_before_markers, insert_before_markers_and_inherit)
2417 (insert_1, count_combining_before, count_combining_after)
2418 (insert_1_both, insert_from_string)
2419 (insert_from_string_before_markers, insert_from_string_1)
2420 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
2421 (adjust_after_replace, adjust_after_insert, replace_range)
2422 (replace_range_2, del_range, del_range_1, del_range_byte)
2423 (del_range_both, del_range_2, modify_region)
2424 (prepare_to_modify_buffer, signal_before_change)
2425 (signal_after_change, Fcombine_after_change_execute):
2426 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2427 * intervals.c (traverse_intervals, rotate_right, rotate_left)
2428 (balance_an_interval, split_interval_right, split_interval_left)
2429 (find_interval, next_interval, update_interval)
2430 (adjust_intervals_for_insertion, delete_node, delete_interval)
2431 (interval_deletion_adjustment, adjust_intervals_for_deletion)
2432 (static_offset_intervals, offset_intervals)
2433 (merge_interval_right, merge_interval_left, make_new_interval)
2434 (graft_intervals_into_buffer, temp_set_point_both)
2435 (temp_set_point, set_point, adjust_for_invis_intang)
2436 (set_point_both, move_if_not_intangible, get_property_and_range)
2437 (get_local_map, copy_intervals, copy_intervals_to_string)
2438 (compare_string_intervals, set_intervals_multibyte_1):
2439 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2440 * intervals.h: Adjust decls to match defn changes elsewhere.
2442 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2443 * keyboard.c (this_command_key_count, this_single_command_key_start)
2444 (before_command_key_count, before_command_echo_length, echo_now)
2445 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
2446 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
2447 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
2448 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
2449 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2450 (last_non_minibuf_size, last_point_position, echo_truncate)
2451 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
2452 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
2453 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
2454 (stuff_buffered_input):
2455 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2456 (last_auto_save, command_loop_1, read_char):
2457 Use EMACS_INT, not int, to avoid integer overflow.
2458 (record_char): Avoid overflow in total_keys computation.
2459 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
2460 * keyboard.h: Adjust decls to match defn changes elsewhere.
2461 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
2462 (Fkey_description, Fdescribe_vector, Flookup_key):
2463 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2464 (click_position): New function, to check that positions are in range.
2465 (Fcurrent_active_maps):
2467 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2468 (Faccessible_keymaps, Fkey_description):
2469 (preferred_sequence_p):
2470 Don't assume fixnum can fit into int.
2471 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
2472 Check for integer overflow in size calculations.
2473 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
2474 avoid mishandling large integers.
2475 * lisp.h: Adjust decls to match defn changes elsewhere.
2476 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
2477 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
2478 (struct Lisp_Marker):
2479 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2480 (clip_to_bounds): Now an inline function, moved here from editfns.c.
2481 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
2482 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
2483 All callers changed.
2484 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
2485 Assume the arg has valid form, since it always does.
2486 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
2487 unsigned integer system type.
2488 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
2489 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
2490 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2491 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
2492 (duration_to_sec_usec): New decl.
2493 * lread.c (read_from_string_index, read_from_string_index_byte)
2494 (read_from_string_limit, readchar, unreadchar, openp)
2495 (read_internal_start, read1, oblookup):
2496 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2497 (Fload, readevalloop, Feval_buffer, Feval_region):
2498 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2499 (openp): Check for out-of-range argument to 'access'.
2500 (read1): Use int, not EMACS_INT, where int is wide enough.
2501 Don't assume fixnum fits into int.
2502 Fix off-by-one error that can read outside a buffer.
2503 (read_filtered_event): Use duration_to_sec_usec
2504 to do proper overflow checking on durations.
2505 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
2506 in size calculation.
2507 (Fexecute_kbd_macro):
2508 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2509 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
2510 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
2511 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
2512 (set_marker_both, set_marker_restricted_both, marker_position)
2513 (marker_byte_position, Fbuffer_has_markers_at):
2514 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2515 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
2516 * menu.c (ensure_menu_items): Rename from grow_menu_items.
2517 It now merely ensures that the menu is large enough, without
2518 necessarily growing it, as this avoids some integer overflow issues.
2519 All callers changed.
2520 (keymap_panes, parse_single_submenu, Fx_popup_menu):
2521 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2522 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
2523 Use SAFE_ALLOCA_LISP, not alloca.
2524 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
2525 to EMACS_INT. Check that fixnums are in proper range for system types.
2526 * minibuf.c (minibuf_prompt_width, string_to_object)
2527 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
2528 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
2529 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2530 (get_minibuffer, read_minibuf_unwind):
2531 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2532 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
2533 this simplifies overflow checking. All callers changed.
2534 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
2536 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2537 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
2538 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
2539 Check that fixnums are in proper range for system types.
2540 (Fx_create_frame, Fx_show_tip):
2541 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2542 * nsfont.m (ns_findfonts, nsfont_list_family):
2543 Don't assume fixnum fits in long.
2544 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
2545 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2546 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
2548 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
2549 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2550 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
2551 (PRINTDECLARE, PRINTPREPARE):
2552 (strout, print_string):
2553 (print, print_preprocess, print_check_string_charset_prop)
2555 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2557 (temp_output_buffer_setup, Fprin1_to_string, print_object):
2558 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2559 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
2560 (printchar, strout): Use xpalloc to catch size calculation overflow.
2561 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
2562 (print_error_message): Use SAFE_ALLOCA, not alloca.
2563 (print_object): Use int, not EMACS_INT, where int is wide enough.
2564 (print_depth, new_backquote_output, print_number_index):
2565 Use ptrdiff_t, not int, where int might not be wide enough.
2566 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
2567 (Fset_process_window_size, Fformat_network_address)
2568 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
2570 Check that fixnums are in proper range for system types.
2571 (Fsignal_process): Simplify by avoiding a goto.
2572 Check for process-ids out of pid_t range rather than relying on
2574 (process_tick, update_tick): Use EMACS_INT, not int.
2575 (Fformat_network_address, read_process_output, send_process)
2576 (Fprocess_send_region, status_notify):
2577 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2578 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
2579 (wait_reading_process_output, read_process_output, exec_sentinel):
2580 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2581 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
2582 (Faccept_process_output): Use duration_to_sec_usec to do proper
2583 overflow checking on durations.
2584 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
2585 Don't assume pid_t fits in int.
2586 * process.h (struct Lisp_Process): Members tick and update_tick
2587 are now of type EMACS_INT, not int.
2588 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
2589 configured --with-wide-int.
2590 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
2591 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
2592 * search.c (looking_at_1, string_match_1):
2593 (fast_string_match, fast_c_string_match_ignore_case)
2594 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
2595 (scan_newline, find_before_next_newline, search_command)
2596 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
2597 (set_search_regs, wordify):
2600 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2601 (string_match_1, search_buffer, set_search_regs):
2603 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2604 (wordify): Check for overflow in size calculation.
2605 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
2606 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
2607 Check that fixnums are in proper range for system types.
2608 * sound.c (struct sound_device)
2609 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
2610 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2611 (Fplay_sound_internal):
2612 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2613 * syntax.c (struct lisp_parse_state, find_start_modiff)
2614 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
2615 (Fparse_partial_sexp):
2616 Don't assume fixnums can fit in int.
2617 (struct lisp_parse_state, find_start_pos, find_start_value)
2618 (find_start_value_byte, find_start_begv)
2619 (update_syntax_table, char_quoted, dec_bytepos)
2620 (find_defun_start, prev_char_comend_first, back_comment):
2621 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
2622 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
2623 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2624 (Finternal_describe_syntax_value): Check that match_lisp is a
2625 character, not an integer, since the code stuffs it into int.
2626 (scan_words, scan_sexps_forward):
2627 Check that fixnums are in proper range for system types.
2629 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2630 (scan_sexps_forward):
2631 Use CHARACTERP, not INTEGERP, since the value must fit into int.
2632 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
2633 * syntax.h: Adjust decls to match defn changes elsewhere.
2634 (struct gl_state_s):
2635 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2636 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
2637 MOST_POSITIVE_FIXNUM.
2638 * sysdep.c (wait_for_termination_1, wait_for_termination)
2639 (interruptible_wait_for_termination, mkdir):
2640 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
2641 (emacs_read, emacs_write):
2642 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2643 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
2644 and double all fit in int.
2645 * term.c (set_tty_color_mode):
2646 Check that fixnums are in proper range for system types.
2647 * termhooks.h (struct input_event):
2648 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2649 * textprop.c (validate_interval_range, interval_of)
2650 (Fadd_text_properties, set_text_properties_1)
2651 (Fremove_text_properties, Fremove_list_of_text_properties)
2652 (Ftext_property_any, Ftext_property_not_all)
2653 (copy_text_properties, text_property_list, extend_property_ranges)
2654 (verify_interval_modification):
2655 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2656 (Fnext_single_char_property_change)
2657 (Fprevious_single_char_property_change):
2658 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2659 (copy_text_properties):
2660 Check for integer overflow in index calculation.
2661 * undo.c (last_boundary_position, record_point, record_insert)
2662 (record_delete, record_marker_adjustment, record_change)
2663 (record_property_change):
2664 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2665 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
2666 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2667 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2668 (Fx_hide_tip, Fx_file_dialog):
2669 * w32menu.c (set_frame_menubar):
2670 Use ptrdiff_t, not int, for consistency with rest of code.
2671 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
2672 (select_window, Fdelete_other_windows_internal)
2673 (window_scroll_pixel_based, window_scroll_line_based)
2674 (Frecenter, Fset_window_configuration):
2675 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2676 (Fset_window_hscroll, run_window_configuration_change_hook)
2677 (set_window_buffer, temp_output_buffer_show, scroll_command)
2678 (Fscroll_other_window, Frecenter):
2679 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2680 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
2681 Don't assume fixnum fits in int.
2682 (Fset_window_scroll_bars):
2683 Check that fixnums are in proper range for system types.
2684 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
2685 (string_pos, c_string_pos, number_of_chars, init_iterator)
2686 (in_ellipses_for_invisible_text_p, init_from_display_pos)
2687 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
2688 (compute_display_string_end, handle_face_prop)
2689 (face_before_or_after_it_pos, handle_invisible_prop)
2690 (handle_display_prop, handle_display_spec, handle_single_display_spec)
2691 (display_prop_intangible_p, string_buffer_position_lim)
2692 (string_buffer_position, handle_composition_prop, load_overlay_strings)
2693 (get_overlay_strings_1, get_overlay_strings)
2694 (iterate_out_of_display_property, forward_to_next_line_start)
2695 (back_to_previous_visible_line_start, reseat, reseat_to_string)
2696 (get_next_display_element, set_iterator_to_next)
2697 (get_visually_first_element, compute_stop_pos_backwards)
2698 (handle_stop_backwards, next_element_from_buffer)
2699 (move_it_in_display_line_to, move_it_in_display_line)
2700 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2701 (add_to_log, message_dolog, message_log_check_duplicate)
2702 (message2, message2_nolog, message3, message3_nolog
2703 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
2704 (current_message_1, truncate_echo_area, truncate_message_1)
2705 (set_message, set_message_1, store_mode_line_noprop)
2706 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
2707 (text_outside_line_unchanged_p, check_point_in_composition)
2708 (reconsider_clip_changes)
2709 (redisplay_internal, set_cursor_from_row, try_scrolling)
2710 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
2711 (redisplay_window, find_last_unchanged_at_beg_row)
2712 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
2713 (trailing_whitespace_p, find_row_edges, display_line)
2714 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
2715 (display_mode_element, store_mode_line_string)
2716 (pint2str, pint2hrstr, decode_mode_spec)
2717 (display_count_lines, display_string, draw_glyphs)
2718 (x_produce_glyphs, x_insert_glyphs)
2719 (rows_from_pos_range, mouse_face_from_buffer_pos)
2720 (fast_find_string_pos, mouse_face_from_string_pos)
2721 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2722 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2723 (safe_call, init_from_display_pos, handle_fontified_prop)
2724 (handle_single_display_spec, load_overlay_strings)
2725 (with_echo_area_buffer, setup_echo_area_for_printing)
2726 (display_echo_area, echo_area_display)
2727 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
2728 (update_tool_bar, hscroll_window_tree, redisplay_internal)
2729 (redisplay_window, dump_glyph_row, display_mode_line)
2730 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
2731 (handle_display_spec, display_prop_string_p):
2732 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2733 (handle_single_display_spec, build_desired_tool_bar_string)
2734 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
2735 (get_specified_cursor_type):
2736 Check that fixnums are in proper range for system types.
2737 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
2738 (Flookup_image_map):
2739 Don't assume fixnums fit in int.
2740 (compare_overlay_entries):
2741 Avoid mishandling comparisons due to subtraction overflow.
2742 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
2743 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
2744 (handle_tool_bar_click):
2745 Use int, not unsigned, since we prefer signed and the signedness
2746 doesn't matter here.
2747 (get_next_display_element, next_element_from_display_vector):
2748 Use int, not EMACS_INT, when int is wide enough.
2749 (start_hourglass): Use duration_to_sec_usec to do proper
2750 overflow checking on durations.
2751 * xfaces.c (Fbitmap_spec_p):
2752 Check that fixnums are in proper range for system types.
2753 (compare_fonts_by_sort_order):
2754 Avoid mishandling comparisons due to subtraction overflow.
2755 (Fx_family_fonts, realize_basic_faces):
2756 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2758 Don't assume fixnum fits in int.
2759 Use SAFE_ALLOCA_LISP, not alloca.
2760 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
2761 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
2762 (face_at_buffer_position, face_for_overlay_string)
2763 (face_at_string_position):
2764 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2765 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
2766 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
2768 Check that fixnums are in proper range for system types.
2769 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2770 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
2771 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2772 (Fx_change_window_property): Don't assume fixnums fit in int.
2773 * xfont.c (xfont_chars_supported):
2774 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2775 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
2776 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
2777 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2778 * xml.c (parse_region):
2779 * xrdb.c (magic_file_p):
2780 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2781 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
2782 (x_get_local_selection, x_reply_selection_request)
2783 (x_handle_selection_request, wait_for_property_change):
2784 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2785 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
2786 short is wide enough.
2787 (x_send_client_event): Don't assume fixnum fits in int.
2788 * xterm.c (x_x_to_emacs_modifiers):
2789 Don't assume EMACS_INT overflows nicely into int.
2790 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
2792 (handle_one_xevent): NATNUMP can eval its arg twice.
2793 (x_connection_closed):
2794 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2795 * xterm.h: Adjust decls to match defn changes elsewhere.
2796 (struct scroll_bar): Use struct vectorlike_header
2797 rather than rolling our own approximation.
2798 (SCROLL_BAR_VEC_SIZE): Remove; not used.
2800 2012-05-25 Glenn Morris <rgm@gnu.org>
2802 * lisp.mk (lisp): Update for more files being compiled now.
2804 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
2806 * lread.c: Remove `read_pure' which makes no difference.
2807 (read_pure): Remove var.
2808 (unreadpure): Remove function.
2809 (readevalloop): Don't call read_list with -1 flag.
2810 (read1, read_vector): Don't test read_pure any more.
2811 (read_list): Simplify.
2813 * fileio.c, character.h: Minor style tweaks.
2815 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
2817 * window.h (clip_changed): Remove useless declaration.
2819 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
2821 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
2822 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
2824 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
2827 This directory predates autoconf and is no longer needed nowadays.
2828 Move its few remaining bits of functionality to where they're needed.
2829 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
2830 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
2831 * m/template.h: Remove.
2832 * Makefile.in (M_FILE): Remove. All uses removed.
2833 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
2834 * lisp.h (USE_LSB_TAG):
2835 * mem-limits.h (EXCEEDS_LISP_PTR):
2836 Use VAL_MAX, not VALBITS, in #if.
2837 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
2838 (EMACS_UINT): Define unconditionally now.
2839 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
2840 (BITS_PER_EMACS_INT): New constants, replacing
2841 what used to be in config.h, but not useful in #if.
2842 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
2843 define them any more.
2844 (VAL_MAX): New macro.
2846 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
2847 BITS_PER_EMACS_INT, in #if.
2848 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
2849 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
2850 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
2851 * s/ms-w32.h (DATA_START):
2852 Move here from removed file m/intel386.h.
2853 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
2854 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
2856 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
2858 Assume C89 or later.
2859 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
2860 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
2862 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
2863 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
2864 * textprop.c, tparam.c (NULL): Remove.
2865 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
2866 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
2867 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
2868 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
2869 * xterm.c (input_signal_count): Assume volatile works.
2871 2012-05-21 Ken Brown <kbrown@cornell.edu>
2873 * xgselect.c (xg_select): Fix first argument in call to 'select'
2876 2012-05-20 Ken Brown <kbrown@cornell.edu>
2878 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
2879 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
2881 2012-05-19 Ken Brown <kbrown@cornell.edu>
2883 * xfns.c (x_in_use): Remove `static' qualifier.
2884 * xterm.h (x_in_use): Declare.
2885 * xgselect.c: Include xterm.h.
2886 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
2887 and `display_arg' (bug#9754).
2889 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
2891 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
2893 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
2894 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
2896 2012-05-18 Eli Zaretskii <eliz@gnu.org>
2898 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
2900 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
2901 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
2903 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
2904 reference to image_cache->refcount.
2905 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
2907 2012-05-17 Juri Linkov <juri@jurta.org>
2909 * search.c (Fword_search_regexp, Fword_search_backward)
2910 (Fword_search_forward, Fword_search_backward_lax)
2911 (Fword_search_forward_lax): Move functions to isearch.el
2912 (bug#10145, bug#11381).
2914 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
2916 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
2918 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
2920 * lread.c (init_obarray): Declare Qt and Qnil as special.
2922 2012-05-14 Glenn Morris <rgm@gnu.org>
2924 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
2925 Put "libexec" before "bin", for the sake of init_callproc_1.
2927 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2929 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
2931 * unexaix.c: Port to more-recent AIX compilers.
2932 (report_error, report_error_1, make_hdr, copy_sym)
2933 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
2934 Make arguments const char *, not char *, to avoid violations of C
2935 standard and to fix some AIX warnings reported by Gilles Pion.
2937 2012-05-14 Eli Zaretskii <eliz@gnu.org>
2939 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
2940 already have overlays loaded.
2941 (handle_single_display_spec): Before returning without displaying
2942 fringe bitmap, synchronize the bidi iterator with the main display
2943 iterator, by calling iterate_out_of_display_property.
2944 (iterate_out_of_display_property): Detect buffer iteration by
2945 testing that it->string is a Lisp string.
2946 (get_next_display_element): When the current object is exhausted,
2947 and there's something on it->stack, call set_iterator_to_next to
2948 proceed with what's on the stack, instead of returning zero.
2949 (set_iterator_to_next): If called at the end of a Lisp string,
2950 proceed to consider_string_end without incrementing string
2951 position. Don't increment display vector index past the end of
2952 the display vector. (Bug#11417)
2953 (pos_visible_p): Don't report a position visible when move_it_to
2954 stopped at the last line of window, which happens to be scanned
2955 backwards by the bidi iteration. (Bug#11464)
2957 2012-05-14 Eli Zaretskii <eliz@gnu.org>
2959 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
2960 and right-margin display specs even if the spec is invalid or we
2961 are on a TTY, and thus unable to display on the fringes.
2962 That's because the text with the property will not be displayed anyway,
2963 so we need to signal to the caller that this is a "replacing"
2964 display spec. This fixes display when the spec is invalid or we
2967 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2969 * unexaix.c (make_hdr): Fix typo in prototype.
2970 This bug broke the build on AIX. Problem reported by Gilles Pion.
2972 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
2974 * keyboard.c (kbd_buffer_get_event): Read special events also in
2975 batch mode. (Bug#11415)
2977 2012-05-12 Glenn Morris <rgm@gnu.org>
2979 * ns.mk: Update for ns_appbindir no longer having trailing "/".
2981 2012-05-12 Eli Zaretskii <eliz@gnu.org>
2983 * lisp.mk (lisp): Add newcomment.elc.
2985 2012-05-12 Glenn Morris <rgm@gnu.org>
2987 * Makefile.in (MKDIR_P): New, set by configure.
2988 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
2990 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
2992 Remove unused function hourglass_started.
2993 * dispextern.h (hourglass_started):
2994 * w32fns.c (hourglass_started):
2995 * xdisp.c (hourglass_started): Remove.
2997 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
2999 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
3000 Update dependencies.
3002 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
3004 * xgselect.c (xg_select): Put maxfds+1 into a var.
3005 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
3007 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
3009 2012-05-10 Dave Abrahams <dave@boostpro.com>
3011 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
3012 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
3014 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
3016 * dbusbind.c (xd_registered_buses): New internal Lisp object.
3017 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
3018 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
3019 Initialize xd_registered_buses.
3021 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
3023 Untag more efficiently if USE_LSB_TAG.
3024 This is based on a proposal by YAMAMOTO Mitsuharu in
3025 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
3026 For an admittedly artificial (nth 8000 longlist) benchmark on
3027 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
3028 Emacs's overall text size by 1%.
3029 * lisp.h (XUNTAG): New macro.
3030 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
3031 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
3032 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
3033 * eval.c (Fautoload):
3034 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
3035 * frame.h (XFRAME): Use XUNTAG.
3037 Port recent dbusbind.c changes to 32-bit --with-wide-int.
3038 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
3039 Remove unportable assumptions about print widths of types like
3041 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
3042 intptr_t when converting between pointer and integer, to avoid GCC
3043 warnings about wrong width.
3045 2012-05-09 Eli Zaretskii <eliz@gnu.org>
3047 * w32proc.c (new_child): Force Windows to reserve only 64KB of
3048 stack for each reader_thread, instead of defaulting to 8MB
3049 determined by the linker. This avoids failures in creating
3050 subprocesses on Windows 7, see the discussion in this thread:
3051 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
3053 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
3055 Fix up display of the *Minibuf-0* buffer in the mini window.
3056 * keyboard.c (read_char): Don't clear the echo area if there's no
3058 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
3059 contents of *Minibuf-0*) if there's no message displayed in its stead.
3061 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
3063 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
3066 2012-05-06 Chong Yidong <cyd@gnu.org>
3068 * lisp.mk (lisp): Update.
3070 2012-05-05 Jim Meyering <meyering@redhat.com>
3072 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
3074 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3076 * data.c (PUT_ERROR): New macro.
3077 (syms_of_data): Use it. Add new error type `user-error'.
3078 * undo.c (user_error): New function.
3079 (Fprimitive_undo): Use it.
3080 * print.c (print_error_message): Adjust print style for `user-error'.
3081 * keyboard.c (user_error): New function.
3082 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
3084 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
3086 Do not limit current-time-string to years 1000..9999.
3087 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
3088 (Fcurrent_time_string): Support any year that is supported by the
3089 underlying localtime representation. Don't use asctime, as it
3090 has undefined behavior for years outside the range -999..9999.
3092 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
3094 Fix race conditions involving setenv, gmtime, localtime, asctime.
3095 Without this fix, interrupts could mess up code that uses these
3096 nonreentrant functions, since setting TZ invalidates existing
3097 tm_zone or tzname values, and since most of these functions return
3098 pointers to static storage.
3099 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
3100 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
3101 Grow the critical sections to include not just invoking
3102 localtime/gmtime, but also accessing these functions' results
3103 including their tm_zone values if any, and any related TZ setting.
3104 (format_time_string): Last arg is now struct tm *, not struct tm **,
3105 so that the struct tm is saved in the critical section.
3106 All callers changed. Simplify allocation of initial buffer, partly
3107 motivated by the fact that memory allocation needs to be outside
3108 the critical section.
3110 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
3112 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
3113 with RESET_INTERVAL.
3115 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3116 Remove duplicated buffer name initialization.
3118 2012-05-02 Jim Meyering <jim@meyering.net>
3120 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
3122 * xfns.c (x_window): Use xstrdup (Bug#11375).
3124 2012-05-02 Eli Zaretskii <eliz@gnu.org>
3126 * xdisp.c (pos_visible_p): If already at a newline from the
3127 display string before the 'while' loop, don't walk back the glyphs
3128 from it3.glyph_row. Solves assertion violation when the display
3129 string begins with a newline (egg.el). (Bug#11367)
3131 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
3133 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
3136 2012-05-01 Glenn Morris <rgm@gnu.org>
3138 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
3139 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
3140 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
3141 All were removed before 23.1.
3143 * dispnew.c: Remove HAVE_LIBNCURSES test;
3144 it is always true on relevant platforms.
3146 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
3147 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
3149 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
3151 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
3153 * .gdbinit (xpr): Remove checks for no longer existing misc types.
3154 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
3157 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
3159 Do not avoid creating empty evaporating overlays (Bug#9642).
3160 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
3161 That is, do not delete an evaporating overlay if it becomes
3162 empty after its bounds are adjusted to fit within its buffer.
3163 This fix caused other problems, and I'm reverting it until we get
3164 to the bottom of them.
3166 2012-04-27 Chong Yidong <cyd@gnu.org>
3168 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
3170 2012-04-27 Eli Zaretskii <eliz@gnu.org>
3172 * xdisp.c (pos_visible_p): If the window start position is beyond
3173 ZV, start the display from buffer beginning. Prevents assertion
3174 violation in init_iterator when the minibuffer window is scrolled
3177 * window.c (window_scroll_pixel_based): Likewise.
3179 2012-04-27 Chong Yidong <cyd@gnu.org>
3181 * keymap.c (where_is_internal): Doc fix (Bug#10872).
3183 2012-04-27 Glenn Morris <rgm@gnu.org>
3185 * fileio.c (Fcopy_file, Fset_file_selinux_context):
3186 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
3188 2012-04-27 Eli Zaretskii <eliz@gnu.org>
3190 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
3191 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
3193 2012-04-26 Eli Zaretskii <eliz@gnu.org>
3195 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
3196 display element, check also the underlying string or buffer
3197 character. (Bug#11341)
3199 * w32menu.c: Include w32heap.h.
3200 (add_menu_item): If the call to AppendMenuW (via
3201 unicode_append_menu) fails, disable Unicode menus only if we are
3202 running on Windows 9X/Me.
3204 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
3206 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
3207 (xgetint): Add missing shift for LSB tags.
3209 2012-04-24 Martin Rudalics <rudalics@gmx.at>
3211 * keyboard.c (read_char): Don't wipe echo area for select window
3212 events: These might get delayed via `mouse-autoselect-window'
3215 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
3217 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
3218 manipulation of :loaded-from data.
3220 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
3222 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
3223 now a cons (bug#11311).
3225 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
3227 Do not create empty overlays with the evaporate property (Bug#9642).
3228 * buffer.c (Fmove_overlay): Delete an evaporating overlay
3229 if it becomes empty after its bounds are adjusted to fit within
3230 its buffer. Without this fix, in a nonempty buffer (let ((o
3231 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
3232 yields an empty overlay that has the evaporate property, which is
3233 not supposed to happen.
3235 Fix minor GTK3 problems found by static checking.
3236 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3237 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3238 (struct _EmacsFixedClass, emacs_fixed_get_type):
3239 Move decls here from emacsgtkfixed.h, since they needn't be public.
3240 (emacs_fixed_get_type): Now static.
3241 (emacs_fixed_class_init): Omit unused local.
3242 (emacs_fixed_child_type): Remove; unused.
3243 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3244 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3245 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
3246 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
3247 (EMACS_FIXED_GET_CLASS): Remove; unused.
3248 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
3250 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
3251 Problem reported by Juanma Barranquero for Windows -Wunused-function.
3253 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3255 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
3256 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
3257 (__malloc_size_t, __malloc_ptrdiff_t):
3258 Remove. All uses removed, replaced by the definiens if needed,
3259 since we can assume C89 or better now.
3260 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
3261 (protect_malloc_state, align, get_contiguous_space)
3262 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
3263 (malloc_atfork_handler_child, malloc_enable_thread)
3264 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
3265 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
3266 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
3267 (special_realloc, _realloc_internal_nolock, _realloc_internal)
3268 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
3269 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
3270 Define using prototypes, not old style.
3271 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
3272 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
3273 (align): Don't assume that signed integer overflow wraps around.
3274 Omit unused local var.
3275 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
3276 (_free_internal_nolock, memalign, mallochook, reallochook):
3277 Omit no-longer-needed casts.
3278 (valloc): Use getpagesize, not __getpagesize.
3279 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
3280 (struct hdr): The 'magic' member is now size_t, not unsigned long.
3282 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
3284 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
3286 Move functions from C to Lisp. Make non-blocking method calls
3287 the default. Implement further D-Bus standard interfaces.
3289 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
3290 (QCdbus_request_name_allow_replacement)
3291 (QCdbus_request_name_replace_existing)
3292 (QCdbus_request_name_do_not_queue)
3293 (QCdbus_request_name_reply_primary_owner)
3294 (QCdbus_request_name_reply_in_queue)
3295 (QCdbus_request_name_reply_exists)
3296 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
3297 (QCdbus_registered_serial, QCdbus_registered_method)
3298 (QCdbus_registered_signal): New Lisp objects.
3299 (XD_DEBUG_MESSAGE): Use sizeof.
3300 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
3301 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
3302 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
3303 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
3304 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
3305 (xd_signature, xd_append_arg): Allow float for integer types.
3306 (xd_get_connection_references): New function.
3307 (xd_get_connection_address): Rename from xd_initialize.
3308 Return cached address.
3309 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
3310 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
3312 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
3313 Return number of refcounts.
3314 (Fdbus_get_unique_name): Make stronger parameter check.
3315 (Fdbus_message_internal): New defun.
3316 (Fdbus_call_method, Fdbus_call_method_asynchronously)
3317 (Fdbus_method_return_internal, Fdbus_method_error_internal)
3318 (Fdbus_send_signal, Fdbus_register_service)
3319 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
3320 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
3321 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
3322 (Vdbus_compiled_version, Vdbus_runtime_version)
3323 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
3324 (Vdbus_message_type_method_return, Vdbus_message_type_error)
3325 (Vdbus_message_type_signal): New defvars.
3326 (Vdbus_registered_buses, Vdbus_registered_objects_table):
3329 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3331 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
3332 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
3333 Do not assume ptrdiff_t is the same width as 'int'.
3335 * alloc.c: Handle unusual debugging option combinations.
3336 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
3337 since the two debugging options are incompatible.
3338 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
3340 (mem_init, mem_insert, mem_insert_fixup):
3341 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
3342 (NEED_MEM_INSERT): Remove; no longer needed.
3344 2012-04-22 Leo Liu <sdl.web@gmail.com>
3346 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
3348 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3350 * sysdep.c [__FreeBSD__]: Minor cleanups.
3351 (list_system_processes, system_process_attributes) [__FreeBSD__]:
3352 Use Emacs indenting style more consistently. Avoid some casts.
3353 Use 'double' consistently rather than mixing 'float' and 'double'.
3355 2012-04-21 Eduard Wiebe <usenet@pusto.de>
3357 * sysdep.c (list_system_processes, system_process_attributes):
3358 Add implementation for FreeBSD (Bug#5243).
3360 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
3362 * lisp.mk (lisp): Update.
3364 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
3366 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
3367 It is never used otherwise.
3369 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
3371 * print.c (print_preprocess): Only check print_depth if print-circle
3373 (print_object): Check for cycles even when print-circle is nil and
3374 print-gensym is t, but only check print_depth if print-circle is nil.
3376 2012-04-20 Chong Yidong <cyd@gnu.org>
3378 * process.c (wait_reading_process_output): If EIO occurs on a pty,
3379 set the status to "failed" and ensure that sentinel is run.
3381 2012-04-20 Glenn Morris <rgm@gnu.org>
3383 * process.c (Fset_process_inherit_coding_system_flag)
3384 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
3385 (Fmake_network_process, Fmake_serial_process): Doc fix.
3387 2012-04-20 Eli Zaretskii <eliz@gnu.org>
3389 * xdisp.c (string_buffer_position_lim): Limit starting position to
3391 (set_cursor_from_row): If called for a mode-line or header-line
3392 row, return zero immediately.
3393 (try_cursor_movement): If inside continuation line, don't back up
3394 farther than the first row after the header line, if any.
3395 Don't consider the header-line row as "partially visible", even if
3396 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
3398 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
3400 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
3403 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
3404 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
3406 configure: new option --enable-gcc-warnings (Bug#11207)
3407 * Makefile.in (C_WARNINGS_SWITCH): Remove.
3408 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
3409 (ALL_CFLAGS): Use new macros rather than old.
3410 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
3411 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
3412 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
3413 -Wunused-result, -Wunused-variable. This should go away once
3414 the Emacs and Gnulib regex code is merged.
3415 (xmalloc, xrealloc): Now static.
3417 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
3419 * dired.c (Fsystem_groups): Remove unused local.
3421 2012-04-17 Glenn Morris <rgm@gnu.org>
3423 * dired.c (Fsystem_users): Doc fix.
3425 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
3427 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
3428 (syms_of_dired): Add them.
3430 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
3432 Fix minor alloc.c problems found by static checking.
3433 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
3434 New extern decls, to avoid calling undeclared functions.
3435 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
3436 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
3437 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
3438 (NEED_MEM_INSERT): New macro.
3439 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
3440 Remove one incorrect comment and fix another.
3442 Fix minor ralloc.c problems found by static checking.
3443 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3444 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
3445 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
3446 (r_alloc_sbrk): Now static.
3448 Improve ralloc.c interface checking.
3449 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3450 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
3451 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
3452 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
3453 [REL_ALLOC]: ... to here, to check interface.
3454 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
3455 Remove decls. This fixes an "It stinks!".
3457 * alloc.c (which_symbols): Fix alignment issue / type clash.
3459 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
3461 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
3462 (struct Lisp_Misc_Any): Likewise.
3463 (struct Lisp_Free): Likewise.
3464 * alloc.c (union aligned_Lisp_Symbol): Define.
3465 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
3466 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
3467 (union aligned_Lisp_Misc): Define.
3468 (MARKER_BLOCK_SIZE, struct marker_block): Use union
3469 aligned_Lisp_Misc instead of union Lisp_Misc.
3470 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
3472 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
3474 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
3475 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
3476 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
3477 * s/netbsd.h, s/sol2-6.h:
3478 Remove definition of GC_MARK_STACK, since the default now works.
3479 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
3480 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
3481 no longer the default.
3482 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
3484 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
3486 * lread.c (lisp_file_lexically_bound_p):
3487 Fix hang at ";-*-\n" (bug#11238).
3489 2012-04-14 Eli Zaretskii <eliz@gnu.org>
3491 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
3492 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
3494 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
3496 * nsterm.m (constrainFrameRect): Always constrain when there is only
3497 one screen (Bug#10962).
3499 2012-04-13 Ken Brown <kbrown@cornell.edu>
3501 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
3503 2012-04-13 Reuben Thomas <rrt@sc3d.org>
3505 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
3507 2012-04-11 Daniel Colascione <dancol@dancol.org>
3509 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
3510 against is gone. It's better to use vfork now so that when Cygwin
3511 gains a new, working vfork, we use it automatically (bug#10398).
3513 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3515 * window.c (save_window_save): Obey window-point-insertion-type.
3517 2012-04-11 Glenn Morris <rgm@gnu.org>
3519 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
3521 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3523 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
3525 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
3527 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
3528 (force_quit_count): New var.
3529 (handle_interrupt): Use it.
3531 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
3533 * w32.c (w32_delayed_load): Record the full path of the library
3534 being loaded (bug#10424).
3536 2012-04-09 Glenn Morris <rgm@gnu.org>
3538 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
3539 not just in the obarray, before snarfing them. (Bug#11036)
3541 * Makefile.in ($(leimdir)/leim-list.el):
3542 Pass EMACS rather than BUILT_EMACS.
3544 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
3546 * process.c (make_process):
3547 * process.h: Add integer `gnutls_handshakes_tried' member to
3550 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
3551 Add convenience `GNUTLS_LOG2i' macro.
3553 * gnutls.c (gnutls_log_function2i): Convenience log function.
3554 (emacs_gnutls_read): Use new log functions,
3555 `gnutls_handshakes_tried' process member, and
3556 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
3557 attempts per process (connection).
3559 2012-04-09 Chong Yidong <cyd@gnu.org>
3561 * eval.c (Fuser_variable_p, user_variable_p_eh)
3562 (lisp_indirect_variable): Functions deleted.
3563 (Fdefvar): Caller changed.
3565 * callint.c (Finteractive, Fcall_interactively):
3566 * minibuf.c (Fread_variable): Callers changed.
3568 2012-04-09 Eli Zaretskii <eliz@gnu.org>
3570 * xdisp.c (set_cursor_from_row): If the display string appears in
3571 the buffer at position that is closer to point than the position
3572 after the display string, display the cursor on the first glyph of
3573 the display string. Fixes cursor display when a 'display' text
3574 property immediately follows invisible text. (Bug#11094)
3576 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
3578 composite.c: use 'double' consistently
3579 * composite.c (get_composition_id): Use 'double' consistently
3580 instead of converting 'float' to 'double' and vice versa; this is
3581 easier to understand and avoids a GCC warning.
3583 2012-04-09 Glenn Morris <rgm@gnu.org>
3585 * Makefile.in: Generate leim-list with bootstrap-emacs, in
3586 preparation for dumping it with emacs. (Bug#4789)
3587 (leimdir): New variable.
3588 ($(leimdir)/leim-list.el): New rule.
3589 (emacs$(EXEEXT)): Depend on leim-list.el.
3591 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
3592 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
3593 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
3595 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
3597 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
3600 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
3602 * xml.c (init_libxml2_functions) [WINDOWSNT]:
3603 Remove unused local variable.
3605 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3607 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
3608 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
3609 (mark_memory): Mark Lisp_Objects only if pointers might hide in
3610 objects, as mark_maybe_pointer will catch them otherwise.
3611 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
3612 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
3614 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3616 Fix typo that broke non-Windows builds.
3617 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
3619 2012-04-07 Eli Zaretskii <eliz@gnu.org>
3621 Support building on MS-Windows with libxml2.
3623 * makefile.w32-in (OBJ2): Add xml.$(O).
3624 (GLOBAL_SOURCES): Add xml.c.
3625 ($(BLD)/xml.$(O)): New dependency list.
3627 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
3628 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
3629 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
3630 [!WINDOWSNT]: New macros.
3631 (init_libxml2_functions, libxml2_loaded_p): New functions.
3632 (parse_region): Call fn_xmlCheckVersion instead of using the macro
3633 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
3634 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
3635 Calls xmlCleanupParser only if libxml2 was loaded (or statically
3637 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
3638 Call init_libxml2_functions before calling libxml2 functions.
3639 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
3641 * emacs.c: Don't include libxml/parser.h.
3642 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
3643 xmlCleanupParser directly.
3645 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
3647 2012-04-07 Eli Zaretskii <eliz@gnu.org>
3649 * indent.c (Fvertical_motion): If there is a display string at
3650 point, use it.vpos to compute how many lines to backtrack after
3651 move_it_to point. (Bug#11133)
3653 2012-04-06 Eli Zaretskii <eliz@gnu.org>
3655 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
3656 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
3657 about subtle differences between FETCH_CHAR* and STRING_CHAR*
3658 macros related to unification of CJK characters. For the details,
3659 see the discussion following the message here:
3660 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
3662 2012-04-04 Chong Yidong <cyd@gnu.org>
3664 * keyboard.c (Vdelayed_warnings_list): Doc fix.
3666 2012-04-01 Eli Zaretskii <eliz@gnu.org>
3668 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
3669 instead of alloca. (Bug#11138)
3671 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
3673 * w32menu.c (is_simple_dialog): Properly check lisp types.
3676 2012-03-31 Eli Zaretskii <eliz@gnu.org>
3678 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
3679 position we get to after a call to move_it_to fails the
3680 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
3681 only if we wind up in a string from display property. (Bug#11063)
3683 * window.c (Fdelete_other_windows_internal): Invalidate the row
3684 and column information about mouse highlight, so that redisplay
3685 restores it after reallocating the glyph matrices. (Bug#7464)
3687 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
3688 string comes from a `display' text property, use the buffer
3689 position of that property as if we actually saw that position in
3691 (move_it_by_lines): Remove the assertion that
3692 "it->current_x == 0 && it->hpos == 0" which can be legitimately
3693 violated when there's a before-string at the beginning of a line.
3696 2012-03-30 Eli Zaretskii <eliz@gnu.org>
3698 * xdisp.c (append_space_for_newline): If the default face was
3699 remapped, use the remapped face for the appended newline.
3700 (extend_face_to_end_of_line): Use the remapped default face for
3701 extending the face to the end of the line.
3702 (display_line): Call extend_face_to_end_of_line when the default
3703 face was remapped. (Bug#11068)
3705 2012-03-29 Eli Zaretskii <eliz@gnu.org>
3707 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
3709 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3711 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
3713 2012-03-27 Glenn Morris <rgm@gnu.org>
3715 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
3718 2012-03-26 Kenichi Handa <handa@m17n.org>
3720 * dispextern.h (struct glyph): Fix previous change. Change the
3721 bit length of glyphless.ch to 25 (Bug#11082).
3723 2012-03-26 Chong Yidong <cyd@gnu.org>
3725 * keyboard.c (Vselection_inhibit_update_commands): New variable.
3726 (command_loop_1): Use it; inhibit selection update for
3727 handle-select-window too (Bug#8996).
3729 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
3731 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
3733 2012-03-25 Kenichi Handa <handa@m17n.org>
3735 * dispextern.h (struct glyph): Change the bit length of
3736 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
3738 2012-03-24 Eli Zaretskii <eliz@gnu.org>
3740 * s/ms-w32.h (tzname): Include time.h before redirecting to
3741 _tzname. Fixes the MSVC build. (Bug#9960)
3743 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
3745 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
3748 * xterm.c (XTread_socket): Only modify handling_signal if
3749 !SYNC_INPUT. (Bug#11080)
3751 2012-03-23 Eli Zaretskii <eliz@gnu.org>
3753 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
3754 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
3755 when fetching a multibyte character consumes more bytes than
3756 CHAR_BYTES returns, due to unification of CJK characters in
3757 string_char. (Bug#11073)
3759 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
3761 * process.c (wait_reading_process_output): Handle pty disconnect
3762 by refraining from sending oneself a SIGCHLD (bug#10933).
3764 2012-03-22 Chong Yidong <cyd@gnu.org>
3766 * dispextern.h (struct it): New member string_from_prefix_prop_p.
3768 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
3769 Mark string as coming from a prefix property.
3770 (handle_face_prop): Use default face for prefix strings (Bug#4281).
3771 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
3773 2012-03-21 Chong Yidong <cyd@gnu.org>
3775 * xfaces.c (Vface_remapping_alist): Doc fix.
3777 2012-03-20 Eli Zaretskii <eliz@gnu.org>
3779 * w32proc.c (Fw32_set_console_codepage)
3780 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
3783 2012-03-20 Chong Yidong <cyd@gnu.org>
3785 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
3786 to reflect default non-nil value of redisplay-dont-pause.
3788 2012-03-19 Kenichi Handa <handa@m17n.org>
3790 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
3791 it fit in a valid range (Bug#11003).
3793 2012-03-18 Eli Zaretskii <eliz@gnu.org>
3795 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
3796 that is not from display property, accept the row as a "cursor
3797 row" if one of the string's character has a non-nil `cursor'
3798 property. Fixes cursor positioning when there are newlines in
3799 overlay strings, e.g. in icomplete.el. (Bug#11035)
3801 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
3803 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
3805 2012-03-12 Chong Yidong <cyd@gnu.org>
3807 * eval.c (inhibit_lisp_code): Rename from
3808 inhibit_window_configuration_change_hook; move from window.c.
3810 * xfns.c (unwind_create_frame_1, Fx_create_frame):
3811 * window.c (run_window_configuration_change_hook)
3812 (syms_of_window): Callers changed.
3814 2012-03-11 Chong Yidong <cyd@gnu.org>
3816 * keymap.c (Fkey_description): Doc fix (Bug#9700).
3818 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
3820 2012-03-10 Chong Yidong <cyd@gnu.org>
3822 * frame.c (other_visible_frames): Don't assume the selected frame
3823 is visible (Bug#10955).
3825 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
3827 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
3829 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
3831 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
3832 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
3835 2012-03-03 Glenn Morris <rgm@gnu.org>
3837 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
3839 2012-03-02 Eli Zaretskii <eliz@gnu.org>
3841 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
3842 position past the first glyph_row that ends at ZV. (Bug#10902)
3843 (redisplay_window, next_element_from_string): Fix typos in
3845 (redisplay_window): Pass to move_it_vertically the margin in
3846 pixels, not in screen lines.
3848 2012-03-02 Glenn Morris <rgm@gnu.org>
3850 * buffer.c (buffer-list-update-hook): Doc fix.
3852 2012-02-29 Eli Zaretskii <eliz@gnu.org>
3854 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
3855 push_it before setting up the iterator for the first overlay
3856 string, even if we have an empty string loaded.
3857 (next_overlay_string): If there's an empty string on the iterator
3858 stack, pop the stack. (Bug#10903)
3860 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
3862 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
3863 Suggested by Stefan Monnier in
3864 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
3865 * alloc.c (widen_to_Lisp_Object): New static function.
3866 (mark_memory): Also mark Lisp_Objects by fetching pointer words
3867 and widening them to Lisp_Objects. This would work even if
3868 USE_LSB_TAG is defined and wide integers are used, which might
3869 happen in a future version of Emacs.
3871 2012-02-25 Chong Yidong <cyd@gnu.org>
3873 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
3876 * xselect.c (Fx_selection_exists_p): Doc fix.
3877 (x_clipboard_manager_save_all): Print an informative message
3878 before saving to clipboard manager.
3880 2012-02-24 Chong Yidong <cyd@gnu.org>
3882 * keyboard.c (process_special_events): Handle all X selection
3883 requests in kbd_buffer, not just the next one (Bug#8869).
3885 2012-02-23 Chong Yidong <cyd@gnu.org>
3887 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
3888 call when setting menu-bar-lines and tool-bar-lines parameters.
3889 (unwind_create_frame_1): New helper function.
3891 * window.c (inhibit_window_configuration_change_hook): New var.
3892 (run_window_configuration_change_hook): Obey it.
3893 (syms_of_window): Initialize it.
3895 2012-02-22 Chong Yidong <cyd@gnu.org>
3897 * xterm.c (x_draw_image_relief): Add missing type check for
3898 Vtool_bar_button_margin (Bug#10743).
3900 2012-02-21 Chong Yidong <cyd@gnu.org>
3902 * fileio.c (Vfile_name_handler_alist): Doc fix.
3904 * buffer.c (Fget_file_buffer): Protect against invalid file
3905 handler return value.
3907 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
3909 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
3910 when computing $valmask.
3912 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
3913 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
3914 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
3915 It's useless in that case, and it can cause problems on hosts
3916 that allocate halves of EMACS_INT values separately.
3917 Reported by Dan Horák. Diagnosed by Andreas Schwab in
3918 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
3919 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
3920 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
3921 it avoids undefined behavior on hosts where shifting right by more
3922 than the word width has undefined behavior.
3924 2012-02-19 Chong Yidong <cyd@gnu.org>
3926 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
3927 (Funhandled_file_name_directory, Ffile_name_as_directory)
3928 (Fdirectory_file_name, Fexpand_file_name)
3929 (Fsubstitute_in_file_name): Protect against invalid file handler
3930 return values (Bug#10845).
3932 2012-02-18 Eli Zaretskii <eliz@gnu.org>
3934 * .gdbinit (pitx): Fix incorrect references to fields of the
3937 2012-02-17 Chong Yidong <cyd@gnu.org>
3939 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
3941 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
3943 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
3944 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
3946 2012-02-15 Chong Yidong <cyd@gnu.org>
3948 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
3949 marked as special. Also, starting docstrings with * is obsolete.
3951 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
3953 * gnutls.c (emacs_gnutls_write): Fix last change.
3955 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
3957 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
3960 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
3962 * keymap.c (Fsingle_key_description): Handle char ranges.
3964 2012-02-12 Chong Yidong <cyd@gnu.org>
3966 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
3967 as that creates a dangerous corner case.
3969 * window.c (Fdelete_window_internal): Invalidate the mouse
3970 highlight (Bug#9904).
3972 2012-02-12 Glenn Morris <rgm@gnu.org>
3974 * xselect.c (Fx_own_selection_internal)
3975 (Fx_get_selection_internal, Fx_disown_selection_internal)
3976 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
3977 * nsselect.m (Fx_own_selection_internal)
3978 (Fx_disown_selection_internal, Fx_selection_exists_p)
3979 (Fx_selection_owner_p, Fx_get_selection_internal):
3980 Sync docs and argument specs with the xselect.c versions.
3982 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
3984 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
3986 2012-02-11 Eli Zaretskii <eliz@gnu.org>
3988 * w32select.c (Fx_selection_exists_p): Sync doc string and
3989 argument list with xselect.c. (Bug#10783)
3991 * w16select.c (Fx_selection_exists_p): Sync doc string and
3992 argument list with xselect.c. (Bug#10783)
3994 2012-02-10 Glenn Morris <rgm@gnu.org>
3996 * fns.c (Fsecure_hash): Doc fix.
3998 2012-02-09 Kenichi Handa <handa@m17n.org>
4000 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
4002 2012-02-07 Chong Yidong <cyd@gnu.org>
4004 * buffer.c (Fbuffer_local_variables)
4005 (buffer_lisp_local_variables): Handle unbound vars correctly;
4006 don't let Qunbound leak into Lisp.
4008 2012-02-07 Glenn Morris <rgm@gnu.org>
4010 * image.c (Fimagemagick_types): Doc fix.
4012 * image.c (imagemagick-render-type): Change it from a lisp object
4013 to an integer. Move the doc here from the lisp manual.
4014 Treat all values not equal to 0 the same.
4016 2012-02-06 Chong Yidong <cyd@gnu.org>
4018 * doc.c (store_function_docstring): Avoid applying docstring of
4019 alias to base function (Bug#2603).
4021 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
4023 * .gdbinit (pp1, pv1): Remove redundant defines.
4026 2012-02-04 Chong Yidong <cyd@gnu.org>
4028 * nsterm.m: Declare a global (Bug#10694).
4030 2012-02-04 Eli Zaretskii <eliz@gnu.org>
4032 * w32.c (get_emacs_configuration_options):
4033 Include --enable-checking, if specified, in the return value.
4035 2012-02-04 Martin Rudalics <rudalics@gmx.at>
4037 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
4038 after rounding frame sizes. (Bug#9723)
4040 2012-02-04 Eli Zaretskii <eliz@gnu.org>
4042 * keyboard.c (adjust_point_for_property): Don't position point
4043 before BEGV. (Bug#10696)
4045 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
4047 Handle overflow when computing char display width (Bug#9496).
4048 * character.c (char_width): Return EMACS_INT, not int.
4049 (char_width, c_string_width): Check for overflow when
4050 computing the width; this is possible now that individual
4051 characters can have unbounded width. Problem introduced
4052 by merge from Emacs 23 on 2012-01-19.
4054 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
4056 * dbusbind.c (Fdbus_register_method): Mention the return value
4057 :ignore in the docstring.
4059 2012-02-02 Glenn Morris <rgm@gnu.org>
4061 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
4063 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4064 Unconditionally set to t. (Bug#10673)
4065 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4066 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4067 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
4069 2012-02-02 Kenichi Handa <handa@m17n.org>
4071 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
4072 0, do not call append_composite_glyph.
4074 2012-02-02 Kenichi Handa <handa@m17n.org>
4076 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
4078 (x_produce_glyphs): If the component of a composition is a null
4079 string, set it->pixel_width to 1 to avoid zero-width glyph.
4081 2012-02-01 Eli Zaretskii <eliz@gnu.org>
4083 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
4084 first 2 arguments are identical. This makes inserting large
4085 output from a subprocess an order of magnitude faster on
4086 MS-Windows, where all sbrk'ed memory is always contiguous.
4088 2012-01-31 Glenn Morris <rgm@gnu.org>
4090 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4091 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4092 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
4094 2012-01-29 Glenn Morris <rgm@gnu.org>
4096 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
4098 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
4100 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
4102 2012-01-28 Chong Yidong <cyd@gnu.org>
4104 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
4106 2012-01-26 Chong Yidong <cyd@gnu.org>
4108 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
4110 * search.c (Fsearch_forward, Fsearch_backward): Document negative
4111 repeat counts (Bug#10507).
4113 2012-01-26 Glenn Morris <rgm@gnu.org>
4115 * lread.c (syms_of_lread): Doc fix.
4117 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
4119 * coding.c (encode_designation_at_bol): Change return value to
4122 2012-01-25 Chong Yidong <cyd@gnu.org>
4124 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
4126 2012-01-21 Chong Yidong <cyd@gnu.org>
4128 * floatfns.c (Fcopysign): Make the second argument non-optional,
4129 since nil is not allowed anyway.
4131 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
4133 * process.c (read_process_output): Use p instead of XPROCESS (proc).
4134 (send_process): Likewise.
4136 2012-01-19 Martin Rudalics <rudalics@gmx.at>
4138 * window.c (save_window_save, Fcurrent_window_configuration)
4139 (Vwindow_persistent_parameters): Do not use Qstate.
4140 Rewrite doc-strings.
4142 2012-01-19 Kenichi Handa <handa@m17n.org>
4144 * character.c (char_width): New function.
4145 (Fchar_width, c_string_width, lisp_string_width):
4146 Use char_width (Bug#9496).
4148 2012-01-16 Martin Rudalics <rudalics@gmx.at>
4150 * window.c (Vwindow_persistent_parameters): New variable.
4151 (Fset_window_configuration, save_window_save): Handle persistent
4154 2012-01-14 Eli Zaretskii <eliz@gnu.org>
4156 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
4157 thrashing the stack of the thread. (Bug#9087)
4159 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
4161 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
4163 2012-01-11 Eli Zaretskii <eliz@gnu.org>
4165 * xdisp.c (rows_from_pos_range): Handle the case where the
4166 highlight ends on a newline. (Bug#10464)
4167 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
4168 he end column for display of highlight that ends on a newline
4171 2012-01-11 Glenn Morris <rgm@gnu.org>
4173 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
4174 from load-path also when installation-directory is nil. (Bug#10208)
4176 2012-01-10 Glenn Morris <rgm@gnu.org>
4178 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
4180 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
4181 Update template values to be closer to their typical values these days.
4183 2012-01-09 Eli Zaretskii <eliz@gnu.org>
4185 * xdisp.c (rows_from_pos_range): Accept additional argument
4186 DISP_STRING, and accept any glyph in a row whose object is that
4187 string as eligible for mouse highlight. Fixes mouse highlight of
4188 display strings from overlays. (Bug#10464)
4190 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
4192 emacs: fix an auto-save permissions race condition (Bug#10400)
4193 * fileio.c (auto_saving_dir_umask): New static var.
4194 (Fmake_directory_internal): Use it.
4195 (do_auto_save_make_dir): Set it, instead of invoking chmod after
4196 creating the directory. The old code temporarily assigns
4197 too-generous permissions to the directory.
4198 (do_auto_save_eh): Clear it.
4199 (Fdo_auto_save): Catch all errors, not just file errors, so
4200 that the var is always cleared.
4202 2012-01-07 Eli Zaretskii <eliz@gnu.org>
4204 * search.c (scan_buffer): Pass character positions to
4205 know_region_cache, not byte positions. (Bug#6540)
4207 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
4209 * w32.c (sys_rename): Report EXDEV when rename of a directory
4210 fails because the target is on another logical disk. (Bug#10284)
4212 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
4214 * xterm.c (x_embed_request_focus): New function.
4216 * xterm.h: Add prototype.
4218 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
4220 2012-01-05 Glenn Morris <rgm@gnu.org>
4222 * emacs.c (emacs_copyright): Update short copyright year to 2012.
4224 2012-01-01 Eli Zaretskii <eliz@gnu.org>
4226 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
4227 Load gnutls_transport_set_lowat only if GnuTLS version is below
4229 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
4230 GnuTLS versions below 2.11.1.
4232 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
4234 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
4235 to the doc string advising against its use for altering the way
4236 windows are scrolled.
4238 2011-12-28 Kenichi Handa <handa@m17n.org>
4240 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
4241 coding-system ASCII compatible only when it does not produce BOM
4242 on encoding (Bug#10383).
4244 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
4246 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
4248 (create_and_show_popup_menu): Always use menu_position_func for
4251 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
4253 * callint.c (Fcall_interactively): Don't truncate prompt string.
4255 2011-12-23 Eli Zaretskii <eliz@gnu.org>
4257 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
4258 property that ends at ZV, so that the bidi iteration could be
4259 resumed from there (after widening). (Bug#10360)
4261 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
4263 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
4265 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
4267 * nsterm.m (x_free_frame_resources):
4268 Release f->output_data.ns->miniimage.
4269 (ns_index_color): Fix indentation. Do not retain
4270 color_table->colors[i].
4272 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
4275 * nsfns.m (x_set_background_color): Assign return value from
4276 ns_index_color to face-background instead of NSColor*.
4277 (ns_implicitly_set_icon_type): Fix indentation.
4278 Change assignment in for loop to comparison.
4280 * emacs.c (ns_pool): New variable.
4281 (main): Assign ns_pool.
4282 (Fkill_emacs): Call ns_release_autorelease_pool.
4284 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
4285 autorelease fdesc, release fdAttrs and tdict.
4286 (ns_get_covering_families): Release charset.
4287 (ns_findfonts): Release NSFontDescriptor created with new.
4288 (ns_uni_to_glyphs): Fix indentation.
4289 (setString): Release attrStr before assigning new value.
4291 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4293 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
4295 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
4296 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
4298 2011-12-18 David Reitter <reitter@cmu.edu>
4300 * nsterm.m (ns_term_init): Subscribe for notifications
4301 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
4302 to method trackingNotification in EmacsMenu.
4304 * nsmenu.m (trackingMenu): New variable.
4305 (trackingNotification): New method (from Aquamacs).
4306 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
4307 from Aquamacs (Bug#7030).
4309 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4311 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
4312 (symbol_to_nsstring): Fix indentation.
4313 (ns_symbol_to_pb): New function.
4314 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
4315 (Fns_rotate_cut_buffers_internal): Remove.
4316 (Fns_store_selection_internal): Rename from
4317 Fns_store_cut_buffer_internal.
4318 (ns_get_foreign_selection, Fx_own_selection_internal)
4319 (Fx_disown_selection_internal, Fx_selection_exists_p)
4320 (Fns_get_selection_internal, Fns_store_selection_internal):
4321 Use ns_symbol_to_pb and check if return value is nil.
4322 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
4323 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
4324 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
4325 renamed to Sns_store_selection_internal.
4326 (ns_handle_selection_request): Move code to Fx_own_selection_internal
4327 and remove this function.
4328 (ns_handle_selection_clear): Remove, never used.
4329 (Fx_own_selection_internal): Move code from ns_handle_selection_request
4332 2011-12-17 Ken Brown <kbrown@cornell.edu>
4334 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
4335 GID is unknown (Bug#10257).
4337 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
4339 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
4340 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
4341 which caused a build failure on GNU/Linux IA-64. This problem was
4342 introduced by my 2011-10-07 patch.
4344 2011-12-15 Juri Linkov <juri@jurta.org>
4346 * image.c (imagemagick_error): New function. (Bug#10112)
4347 (imagemagick_load_image): Comment out `MagickSetResolution' call.
4348 Use `imagemagick_error' where ImageMagick functions return
4350 (Fimagemagick_types): Add `Fnreverse' to return the list in the
4353 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4355 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
4356 fill background (Bug#8992).
4358 2011-12-13 Martin Rudalics <rudalics@gmx.at>
4360 * window.c (Vwindow_combination_resize)
4361 (Vwindow_combination_limit): Use t instead of non-nil in
4363 (Vrecenter_redisplay): Add first sentence of doc-string on
4365 (Frecenter): Fix doc-string typo.
4367 2011-12-11 Kenichi Handa <handa@m17n.org>
4369 * coding.c (Funencodable_char_position): Pay attention to the
4370 buffer text relocation (Bug#9389).
4372 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4374 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
4375 gtk_init (Bug#10100).
4377 2011-12-10 Eli Zaretskii <eliz@gnu.org>
4379 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
4380 IT->string is nil. (Bug#10263)
4382 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4384 * nsterm.h (x_free_frame_resources): Declare.
4386 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
4387 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
4389 * nsterm.h (ns_get_defaults_value): Declare.
4391 * nsterm.m (ns_default): Call ns_get_defaults_value.
4393 2011-12-09 Eli Zaretskii <eliz@gnu.org>
4395 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
4398 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4400 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
4401 that where the value of an _OBJC_* symbol points to is in the .bss
4402 section (Bug#10240).
4404 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4406 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
4407 after the loop to call ccl_driver at least once (Bug#8619).
4409 2011-12-08 Kenichi Handa <handa@m17n.org>
4411 * ftfont.c (get_adstyle_property): Fix previous change
4414 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
4416 * w32.c (init_environment): If no_site_lisp, remove site-lisp
4417 dirs from the default value of EMACSLOADPATH (bug#10208).
4419 2011-12-07 Glenn Morris <rgm@gnu.org>
4421 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
4422 installation and source directories as well. (Bug#10208)
4424 2011-12-06 Chong Yidong <cyd@gnu.org>
4426 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
4428 2011-12-06 Glenn Morris <rgm@gnu.org>
4430 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
4431 as an error, not just -1. (Bug#10217)
4433 2011-12-05 Chong Yidong <cyd@gnu.org>
4435 * keyboard.c (process_special_events): New function.
4436 (swallow_events, Finput_pending_p): Use it (Bug#10195).
4438 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
4440 * coding.c (encode_designation_at_bol): Don't use uninitialized
4441 local variable (Bug#9318).
4443 2011-12-05 Kenichi Handa <handa@m17n.org>
4445 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
4446 return Qnil (Bug#8046, Bug#10193).
4448 2011-12-05 Kenichi Handa <handa@m17n.org>
4450 * coding.c (encode_designation_at_bol): New args charbuf_end and
4451 dst. Return the number of produced bytes. Callers changed.
4452 (coding_set_source): Return how many bytes coding->source was
4454 (coding_set_destination): Return how many bytes
4455 coding->destination was relocated.
4456 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
4457 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
4459 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4461 * coding.c (CODING_CHAR_CHARSET_P): New macro.
4462 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
4465 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
4467 The following changes are to fix Bug#9318.
4469 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
4470 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
4471 (encode_coding_iso_2022, encode_coding_sjis)
4472 (encode_coding_big5, encode_coding_charset): Use the above macros.
4474 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
4476 * lisp.h (process_quit_flag): Fix external declaration.
4478 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
4480 Don't macro-inline non-performance-critical code.
4481 * eval.c (process_quit_flag): New function.
4482 * lisp.h (QUIT): Use it.
4484 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
4486 * nsfns.m (get_geometry_from_preferences): New function.
4487 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
4489 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
4491 * emacs.c (Qkill_emacs): Define.
4492 (syms_of_emacs): Initialize it.
4493 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
4494 Qquit_flag to `kill-emacs' instead.
4495 (quit_throw_to_read_char): Add parameter `from_signal'.
4496 All callers changed. Call Fkill_emacs if requested and safe.
4497 * lisp.h (QUIT): Call Fkill_emacs if requested.
4499 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
4501 * widget.c (update_wm_hints): Return if wmshell is null.
4502 (widget_update_wm_size_hints): New function.
4504 * widget.h (widget_update_wm_size_hints): Declare.
4506 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
4507 widget_update_wm_size_hints (Bug#10104).
4509 2011-12-03 Eli Zaretskii <eliz@gnu.org>
4511 * xdisp.c (handle_invisible_prop): If the invisible text ends just
4512 before a newline, prepare the bidi iterator for consuming the
4513 newline, and keep the current paragraph direction. (Bug#10183)
4514 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
4516 2011-12-02 Juri Linkov <juri@jurta.org>
4518 * search.c (Fword_search_regexp): New Lisp function created from
4519 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
4520 (Fword_search_backward, Fword_search_forward)
4521 (Fword_search_backward_lax, Fword_search_forward_lax):
4522 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
4523 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
4525 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
4527 * fileio.c (Finsert_file_contents): Move after-change-function call
4528 to before the "handled:" label, since all "goto handled" appear in
4529 cases where the *-change-functions have already been properly called
4532 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
4534 * keyboard.c (interrupt_signal): Don't call kill-emacs when
4535 waiting for input. (Bug#10169)
4537 2011-11-30 Eli Zaretskii <eliz@gnu.org>
4539 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
4540 verifies glyph row's hash code--we have just reallocated the
4541 glyphs, so their contents can be complete garbage. (Bug#10164)
4543 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
4545 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
4547 2011-11-30 Eli Zaretskii <eliz@gnu.org>
4549 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
4550 attributes are tested _before_ calling verify_row_hash, to protect
4551 against GCC re-ordering of the tests. (Bug#10164)
4553 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
4555 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
4557 * xterm.c (handle_one_xevent): Only set async_visible and friends
4558 if net_wm_state_hidden_seen is non-zero (Bug#10002)
4559 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
4560 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
4562 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
4564 Remove GCPRO-related macros that exist only to avoid shadowing locals.
4565 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
4566 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
4567 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4568 All uses changed to use GCPRO1 etc.
4569 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
4570 Revert to old implementation (i.e., before 2011-03-11).
4572 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4574 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
4575 of scroll runs so as to avoid assigning disabled bogus rows and
4576 unnecessary graphics copy operations.
4578 2011-11-27 Eli Zaretskii <eliz@gnu.org>
4580 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
4581 (snprintf) [_MSC_VER]: Redirect to _snprintf.
4582 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
4583 (malloc, free, realloc, calloc): Redirect to e_* only when
4586 * lisp.h (GCTYPEBITS): Move before first use.
4587 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
4588 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
4589 this macro definition.
4591 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
4594 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
4596 * gtkutil.c (xg_create_frame_widgets):
4597 Call gtk_window_set_has_resize_grip (FALSE) if that function is
4598 present with Gtk+ 2.0.
4600 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4602 * fileio.c (Finsert_file_contents): Undo previous change; see
4603 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4605 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4607 Rename locals to avoid shadowing.
4608 * fileio.c (Finsert_file_contents):
4609 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
4610 * process.c (wait_reading_process_output):
4611 Rename inner 'proc' to 'p' to avoid shadowing.
4612 Indent for consistency with usual Emacs style.
4614 2011-11-25 Eli Zaretskii <eliz@gnu.org>
4616 * xdisp.c (redisplay_window): If cursor row is not fully visible
4617 after recentering, and scroll-conservatively is set to a large
4618 number, scroll window by a few more lines to make the cursor fully
4619 visible and out of scroll-margin. (Bug#10105)
4620 (start_display): Don't move to the next line if the display should
4621 start at a newline that is part of a display vector or an overlay
4624 2011-11-24 Juri Linkov <juri@jurta.org>
4626 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
4627 after the `MagickPingImage' call. (Bug#10112)
4629 2011-11-23 Chong Yidong <cyd@gnu.org>
4631 * window.c (Fcoordinates_in_window_p): Accept only live windows.
4633 2011-11-23 Martin Rudalics <rudalics@gmx.at>
4635 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
4636 making another buffer current. (Bug#10114)
4638 2011-11-23 Glenn Morris <rgm@gnu.org>
4640 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
4642 2011-11-23 Chong Yidong <cyd@gnu.org>
4644 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
4645 using it (Bug#5984).
4647 2011-11-22 Eli Zaretskii <eliz@gnu.org>
4649 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
4650 and header-lines, as they don't have one computed for them.
4653 * .gdbinit (prow): Make displayed values more self-explaining.
4654 Add row's hash code.
4656 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
4658 * process.c (wait_reading_process_output): Fix asynchrounous
4659 GnuTLS socket handling on some versions of the GnuTLS library.
4660 (wait_reading_process_output): Add comment and URL.
4662 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
4664 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
4666 2011-11-21 Chong Yidong <cyd@gnu.org>
4668 * window.c (Fnext_window, Fprevious_window): Doc fix.
4670 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4672 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
4674 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
4676 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
4678 2011-11-20 Martin Rudalics <rudalics@gmx.at>
4680 * window.c (Fset_window_combination_limit): Rename argument
4682 (Vwindow_combination_limit): Remove "status" from doc-string.
4684 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
4686 * m/ibms390.h: Remove.
4687 * m/ibms390x.h: Don't include "ibms390.h".
4689 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4691 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
4692 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
4694 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
4696 * casetab.c (Fset_case_table):
4697 * charset.c (Fcharset_after): Fix typos.
4699 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
4701 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
4702 Otherwise, valgrind does not work on some platforms.
4703 Problem reported by Andreas Schwab in
4704 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
4705 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
4706 is set, removing the need for VIRT_ADDRESS_VARIES.
4707 (PURE_P): Use a more-efficient implementation that needs just one
4708 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
4709 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
4710 to 4 (xorl, subq, cmpq, setbe).
4711 * alloc.c (pure): Always extern now, since that's the
4712 VIRT_ADDR_VARIES behavior.
4713 (PURE_POINTER_P): Use a single comparison, not two, for
4714 consistency with the new puresize.h.
4715 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
4716 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
4717 Remove VIRT_ADDR_VARIES no longer needed.
4719 2011-11-19 Eli Zaretskii <eliz@gnu.org>
4721 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
4722 (erase_phys_cursor, update_window_cursor, show_mouse_face)
4723 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
4724 behave as if the cursor position were at the window margin.
4726 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
4727 and the cursor position is out of bounds, behave as if the cursor
4728 position were at the window margin. (Bug#10075)
4730 2011-11-18 Chong Yidong <cyd@gnu.org>
4732 * window.c (Fwindow_combination_limit): Make first argument
4733 non-optional, since it is meaningless for live windows like the
4736 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
4738 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
4740 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
4742 * intervals.c: Fix grafting over the whole buffer (bug#10071).
4743 (graft_intervals_into_buffer): Simplify.
4745 2011-11-18 Eli Zaretskii <eliz@gnu.org>
4747 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
4748 hash values of the two rows.
4749 (copy_row_except_pointers): Preserve the used[] arrays and the
4750 hash values of the two rows. (Bug#10035)
4751 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
4753 * xdisp.c (row_hash): New function, body extracted from
4754 compute_line_metrics.
4755 (compute_line_metrics): Call row_hash, instead of computing the
4758 * dispnew.c (verify_row_hash): Call row_hash for computing the
4759 hash code of a row, instead of duplicating code from xdisp.c.
4761 * dispextern.h (row_hash): Add prototype.
4763 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
4765 * frame.c (delete_frame): Don't delete the terminal when the last
4766 X frame is closed if emacs is built with GTK toolkit.
4768 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
4770 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
4772 2011-11-17 Martin Rudalics <rudalics@gmx.at>
4774 * window.c (Vwindow_splits): Rename to
4775 Vwindow_combination_resize. Suggested by Juri Linkov.
4776 (Fsplit_window_internal): Use Vwindow_combination_resize instead
4779 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
4781 * nsfns.m (Fns_font_name):
4782 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
4784 2011-11-16 Martin Rudalics <rudalics@gmx.at>
4786 * window.h (window): Rename slot "nest" to "combination_limit".
4787 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
4788 (Fset_window_nest): Rename to Fset_window_combination_limit.
4789 (Vwindow_nest): Rename to Vwindow_combination_limit.
4790 (recombine_windows, make_parent_window, make_window)
4791 (Fsplit_window_internal, saved_window)
4792 (Fset_window_configuration, save_window_save): Rename all
4793 occurrences of window_nest to window_combination_limit.
4795 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
4797 * image.c (imagemagick_load_image): Fix typo.
4799 2011-11-14 Eli Zaretskii <eliz@gnu.org>
4801 * xdisp.c (display_line): Move the call to
4802 highlight_trailing_whitespace before the call to
4803 compute_line_metrics, since the latter needs to see the final
4804 faces of all the glyphs to compute ROW's hash value.
4805 Fixes assertion violations in row_equal_p. (Bug#10035)
4807 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
4809 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
4810 just return (bug#10044).
4812 2011-11-12 Eli Zaretskii <eliz@gnu.org>
4814 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
4815 with user-defined heap size. Bump the default size of the temacs
4816 heap to 27MB, to avoid memory warning when running temacs.
4817 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
4819 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
4820 current_matrix and desired_matrix. (Bug#9990)
4821 (verify_row_hash) [XASSERTS]: New function.
4822 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
4823 that the hash value of glyph rows is correct.
4825 2011-11-12 Martin Rudalics <rudalics@gmx.at>
4827 * window.h (window): Remove splits slot.
4828 * window.c (Fwindow_splits, Fset_window_splits): Remove.
4829 (Fdelete_other_windows_internal, make_parent_window)
4830 (make_window, Fsplit_window_internal, Fdelete_window_internal)
4831 (Fset_window_configuration, save_window_save): Don't deal with
4832 split status of windows.
4833 (saved_window): Remove splits slot.
4834 (Vwindow_splits): Rewrite doc-string.
4836 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
4838 * xfns.c (unwind_create_frame):
4839 * nsfns.m (unwind_create_frame):
4840 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
4841 Vframe_list (Bug#9999).
4843 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
4845 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
4847 2011-11-11 Kenichi Handa <handa@m17n.org>
4849 * callproc.c (Fcall_process): Set the member dst_multibyte of
4852 2011-11-11 Johan Bockgård <bojohan@gnu.org>
4854 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
4855 avoid a crash (bug#9496).
4857 2011-11-09 Chong Yidong <cyd@gnu.org>
4859 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
4860 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
4862 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4864 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
4866 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4868 Avoid some portability problems by eschewing 'extern inline' functions.
4869 The trivial performance wins aren't worth the portability hassles; see
4870 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
4872 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4873 (window_box_width, window_box_left, window_box_left_offset)
4874 (window_box_right, window_box_right_offset): Undo previous change,
4875 by removing the "extern"s.
4876 * intervals.c (adjust_intervals_for_insertion)
4877 (adjust_intervals_for_deletion): Undo previous change,
4878 making these static again.
4879 (offset_intervals, temp_set_point_both, temp_set_point)
4880 (copy_intervals_to_string): No longer inline.
4881 * xdisp.c (window_text_bottom_y, window_box_width)
4882 (window_box_height, window_box_left_offset)
4883 (window_box_right_offset, window_box_left, window_box_right)
4884 (window_box): No longer inline.
4886 2011-11-08 Chong Yidong <cyd@gnu.org>
4888 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
4889 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
4890 Signal an error if not a live window.
4891 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
4892 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
4894 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
4896 * lisp.h (syms_of_abbrev): Remove declaration.
4897 Reported by CHENG Gao <chenggao@royau.me>.
4899 2011-11-07 Eli Zaretskii <eliz@gnu.org>
4901 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
4902 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
4903 of temacs in GUI mode.
4905 2011-11-07 Martin Rudalics <rudalics@gmx.at>
4907 * window.h: Declare delete_all_child_windows instead of
4908 delete_all_subwindows.
4909 * window.c (Fwindow_nest, Fset_window_nest)
4910 (Fset_window_new_total, Fset_window_new_normal)
4911 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
4912 (delete_all_subwindows): Rename to delete_all_child_windows.
4913 (Fdelete_other_windows_internal, Fset_window_configuration):
4914 Call delete_all_child_windows instead of delete_all_subwindows.
4915 * frame.c (delete_frame): Call delete_all_child_windows instead
4916 of delete_all_subwindows.
4918 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
4920 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
4921 This is also needed for porting to any host where GC_MARK_STACK is
4922 not GC_MAKE_GCPROS_NOOPS.
4923 (which_symbols): Use it.
4925 2011-11-07 Kenichi Handa <handa@m17n.org>
4927 * coding.c (coding_set_destination): Check coding->src_pos only
4928 when coding->src_object is a buffer (bug#9910).
4930 * process.c (send_process): Set the member src_multibyte of coding
4931 to 0 (bug#9911) when sending a unibyte text.
4933 * callproc.c (Fcall_process): Set the member src_multibyte of
4934 process_coding to 0 (bug#9912).
4936 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4938 * xmenu.c (cleanup_widget_value_tree): New function.
4939 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
4940 calling free_menubar_widget_value_tree directly (Bug#9830).
4942 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
4944 Fix some portability problems with 'inline'.
4945 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4946 (window_box_width, window_box_left, window_box_left_offset)
4947 (window_box_right, window_box_right_offset): Declare extern.
4948 Otherwise, these inline functions do not conform to C99 and
4949 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
4950 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
4951 * intervals.c (adjust_intervals_for_insertion)
4952 (adjust_intervals_for_deletion): Now extern, because otherwise the
4953 extern inline functions 'offset_intervals' couldn't refer to it.
4954 (static_offset_intervals): Remove.
4955 (offset_intervals): Rewrite using the old contents of
4956 static_offset_intervals. The old version didn't conform to C99
4957 because an extern inline function contained a reference to an
4958 identifier with static linkage.
4960 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
4962 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
4965 2011-11-06 Eli Zaretskii <eliz@gnu.org>
4967 * xdisp.c (init_iterator, reseat_to_string): Don't set the
4968 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
4969 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
4970 return Qleft_to_right.
4972 2011-11-06 Chong Yidong <cyd@gnu.org>
4974 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
4975 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
4976 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
4977 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
4978 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
4979 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
4980 (Fwindow_vscroll): Doc fix.
4981 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
4982 argument, since it makes no sense to pass a live window and for
4983 consistency with window-child.
4985 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
4987 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
4990 2011-11-05 Jason Rumney <jasonr@gnu.org>
4992 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
4993 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
4995 (add_font_entity_to_list): Fix logic errors in mixed boolean and
4996 bitwise arithmetic preventing use of unicode-sip and non-truetype
4999 2011-11-05 Eli Zaretskii <eliz@gnu.org>
5001 * s/ms-w32.h (fstat, stat, utime): Move redirections to
5004 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
5005 initialization code to keep similarity to xfns.c after changes
5008 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
5010 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
5011 (unwind_create_frame): New function (Bug#9943).
5012 (Fx_create_frame): Restructure code to be more similar to the one in
5013 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
5014 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
5015 Move terminal->reference_count++ just before making the frame official
5018 * nsterm.m (x_free_frame_resources): New function.
5019 (x_destroy_window): Move code to x_free_frame_resources.
5021 * xfns.c (unwind_create_frame): Fix comment.
5022 (Fx_create_frame, x_create_tip_frame):
5023 Move terminal->reference_count++ just before making the frame
5024 official. Move initialization of image_cache_refcount and
5025 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
5027 2011-11-05 Eli Zaretskii <eliz@gnu.org>
5029 Support MSVC build with newer versions of Visual Studio.
5030 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
5031 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
5034 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
5035 which are not supported by MSVC.
5036 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
5037 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
5039 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
5041 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
5043 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
5045 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
5047 Support MSVC build with newer versions of Visual Studio.
5048 * w32.c: Don't include w32api.h for MSVC.
5049 (init_environment) [_MSC_VER]: Call sys_access, not _access.
5051 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
5052 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
5053 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
5054 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
5056 (alloca) [_MSC_VER]: Define to _alloca.
5058 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
5060 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
5062 2011-11-04 Eli Zaretskii <eliz@gnu.org>
5064 * xdisp.c (note_mouse_highlight): If either of
5065 previous/next-single-property-change returns nil, treat that as
5066 the beginning or the end of the buffer. (Bug#9955)
5068 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
5070 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
5071 label is not null (Bug#9951).
5072 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
5075 2011-11-04 Eli Zaretskii <eliz@gnu.org>
5077 * window.c (Fwindow_body_size): Mention in the doc string that the
5078 return value is in frame's canonical units. (Bug#9949)
5080 2011-11-03 Eli Zaretskii <eliz@gnu.org>
5082 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
5084 * w32fns.c (unwind_create_frame): If needed, free the glyph
5085 matrices of the partially constructed frame. (Bug#9943)
5086 * xfns.c (unwind_create_frame): Likewise.
5088 2011-11-01 Eli Zaretskii <eliz@gnu.org>
5090 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
5091 Don't stop backward scan on the continuation glyph, even though
5092 its CHARPOS is positive.
5093 (mouse_face_from_buffer_pos, note_mouse_highlight):
5094 Rename cover_string to disp_string.
5096 2011-11-01 Martin Rudalics <rudalics@gmx.at>
5098 * window.c (temp_output_buffer_show): Don't use
5099 Vtemp_buffer_show_specifiers.
5100 (Vtemp_buffer_show_specifiers): Remove unused variable.
5102 2011-10-30 Eli Zaretskii <eliz@gnu.org>
5104 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
5105 past the beginning of the current glyph matrix.
5107 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
5109 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
5110 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
5111 HAVE_GTK3 (Bug#9869).
5113 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
5114 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
5116 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
5118 * xterm.c: Declare x_handle_net_wm_state to return int.
5119 (handle_one_xevent): Check if we are iconified but don't have
5120 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
5121 (get_current_wm_state): Return non-zero if not hidden,
5122 check for _NET_WM_STATE_HIDDEN (Bug#9893).
5123 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
5124 (x_handle_net_wm_state): Return what get_current_wm_state returns.
5125 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
5127 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
5129 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
5130 so that this new function doesn't get optimized away by a
5131 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
5133 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5135 * frame.h (MOUSE_HL_INFO): Remove excess parens.
5137 2011-10-29 Eli Zaretskii <eliz@gnu.org>
5139 Fix the `xbytecode' command.
5140 * .gdbinit (xprintbytestr): New command.
5141 (xwhichsymbols): Rename from `which'; all callers changed.
5142 (xbytecode): Print the byte-code string as well.
5144 2011-10-29 Kim Storm <storm@cua.dk>
5146 * alloc.c (which_symbols): New function.
5148 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5150 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
5153 2011-10-29 Glenn Morris <rgm@gnu.org>
5155 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
5156 Not clear what it was for, and it causes various bugs. (Bug#9839)
5158 2011-10-28 Eli Zaretskii <eliz@gnu.org>
5160 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
5161 possible random value that matches one of those tested as
5162 condition to clear the mouse face.
5164 2011-10-28 Chong Yidong <cyd@gnu.org>
5166 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
5168 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
5170 * window.c (make_window): Initialize phys_cursor_on_p.
5172 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
5174 * lisp.h (struct Lisp_Symbol): Update comments.
5176 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
5178 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
5180 2011-10-28 Eli Zaretskii <eliz@gnu.org>
5182 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
5183 <oslsachem@gmail.com> for helping to debug this.
5185 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
5186 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
5187 (g_b_init_get_glyph_outline_w): New static variables.
5188 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
5189 (GetGlyphOutlineW_Proc): New typedefs.
5190 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
5191 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
5193 (w32font_open_internal, compute_metrics):
5194 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
5195 instead of calling the "wide" APIs directly.
5197 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
5199 * w32.h (syms_of_w32font): Add prototype.
5201 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
5203 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
5204 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
5205 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
5206 (Fmove_to_window_line): Doc fix.
5208 2011-10-27 Chong Yidong <cyd@gnu.org>
5210 * process.c (make_process): Set gnutls_state to NULL.
5212 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
5213 non-NULL, regardless of GNUTLS_INITSTAGE.
5214 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
5215 an error. Set process slots as soon as we allocate them.
5217 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
5219 2011-10-27 Chong Yidong <cyd@gnu.org>
5221 * gnutls.c (emacs_gnutls_deinit): New function.
5222 Deallocate credentials structures as well as calling gnutls_deinit.
5223 (Fgnutls_deinit, Fgnutls_boot): Use it.
5225 * process.c (make_process): Initialize GnuTLS credentials to NULL.
5226 (deactivate_process): Call emacs_gnutls_deinit.
5228 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
5230 * image.c (x_create_x_image_and_pixmap):
5231 * w32.c (sys_rename, w32_delayed_load):
5232 * w32font.c (fill_in_logfont):
5233 * w32reg.c (x_get_string_resource): Silence compiler warnings.
5235 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
5237 * w32fns.c (w32_default_color_map): New function,
5238 extracted from Fw32_default_color_map.
5239 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5241 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
5243 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
5245 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
5247 * keyboard.c (test_undefined): New function (bug#9751).
5248 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
5250 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
5252 * sysdep.c (init_sys_modes): Fix the check for the controlling
5253 terminal (Bug#6649).
5255 2011-10-20 Eli Zaretskii <eliz@gnu.org>
5257 * dispextern.h (struct bidi_it): New member next_en_type.
5259 * bidi.c (bidi_line_init): Initialize the next_en_type member.
5260 (bidi_resolve_explicit_1): When next_en_pos is valid for the
5261 current character, check also for next_en_type being WEAK_EN.
5262 (bidi_resolve_weak): Don't enter the expensive loop if the current
5263 position is before next_en_pos. Record the bidi type of the first
5264 non-ET, non-BN character we find, in addition to its position.
5265 (bidi_level_of_next_char): Invalidate next_en_type when
5266 next_en_pos is over-stepped.
5268 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
5270 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
5271 * editfns.c: Rewrite current-time-zone so that it invokes
5272 the equivalent of (format-time-string "%Z") to get the time zone name.
5273 This fixes a bug when the time zone name contains characters that
5274 need converting from the system time locale to Emacs internal format.
5275 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
5276 that patch fixed format-time-string to do the conversion, but
5277 I forgot to fix current-time-zone.
5278 (format_time_string): New function, containing most of
5279 what Fformat_time_string used to contain.
5280 (Fformat_time_string): Rewrite in terms of format_time_string.
5281 This doesn't change this function's behavior.
5282 (current-time-zone): Rewrite to use format_time_string.
5283 This fixes the bug reported by Michael Schierl in
5284 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
5285 Jason Rumney's 2007-06-07 change worked around this bug, but
5287 * systime.h (tzname, timezone): Remove no-longer-used declarations.
5289 2011-10-19 Eli Zaretskii <eliz@gnu.org>
5291 * xdisp.c (start_display): If the character at POS is displayed
5292 via a display vector, reset IT->current.dpvec_index to zero.
5293 (try_window_reusing_current_matrix): If a line ends in a display
5294 vector or the next line starts in a display vector, continue
5295 redrawing the window even though the character position of
5296 start_row was reached.
5299 2011-10-18 Chong Yidong <cyd@gnu.org>
5301 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
5302 with nobreak-char-display too.
5304 2011-10-18 Eli Zaretskii <eliz@gnu.org>
5306 Fix part 3 of bug#9771.
5307 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
5308 (bidi_resolve_neutral): Don't enter the expensive loop looking for
5309 non-neutral characters if the current character is a paragraph
5310 separator (a.k.a. Newline). This avoids running the same
5311 expensive loop twice, once when we consume the preceding newline
5312 and the other time when the line actually needs to be displayed.
5313 Avoid the loop when we see neutrals on the base embedding level
5314 following a character whose directionality is the same as the
5315 paragraph's. This avoids running the expensive loop when a line
5316 ends in a long sequence of neutrals, like control characters.
5317 Add assertion against STRONG_AL type. Slightly rearrange code
5318 that determines the type of a neutral given the first non-neutral
5320 (bidi_level_of_next_char): Set next_en_pos to zero when
5321 invalidating its info.
5323 2011-10-17 Eli Zaretskii <eliz@gnu.org>
5325 * xdisp.c (push_display_prop): Determine whether to record string
5326 or buffer position by IT->string, not by IT->method. Allow
5327 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
5328 (move_it_vertically_backward): Don't look for character position
5329 immediately after the newline when in a continuation line.
5332 2011-10-15 Martin Rudalics <rudalics@gmx.at>
5334 * window.c (coordinates_in_window): Rewrite and delabelize
5335 vertical border check. (Bug#5357) (Bug#9618)
5337 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
5339 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
5340 errors in XSetWindowBorder (bug#9310).
5342 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
5344 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
5345 avoid crash when xmalloc overrun checking is enabled.
5347 2011-10-13 Eli Zaretskii <eliz@gnu.org>
5349 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
5350 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
5351 cursor motion with <left> and <right> arrow keys.
5353 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
5354 some callers set that themselves.
5356 2011-10-12 Eli Zaretskii <eliz@gnu.org>
5358 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
5359 display string and the previous row comes from the same string and
5360 is empty. (Bug#9739) (Bug#9738)
5362 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
5364 * doc.c (get_doc_string): Encode file name (bug#9735).
5366 2011-10-12 Eli Zaretskii <eliz@gnu.org>
5368 * bidi.c (bidi_level_of_next_char):
5369 * xdisp.c (get_visually_first_element): Remove old incorrect
5370 comments regarding the Unicode Line Separator character.
5372 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
5374 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
5376 * alloc.c (Fgc_status): Do not access beyond zombies array
5377 boundary if nzombies > MAX_ZOMBIES.
5378 * alloc.c (dump_zombies): Add missing format specifier.
5380 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
5382 * xdisp.c (set_cursor_from_row): Simplify conditionals,
5383 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
5385 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
5386 Some packages use them to denote characters with modifiers.
5388 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
5390 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
5391 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
5392 matching a pp-number. Rename parameter var to var1.
5394 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
5396 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
5398 2011-10-08 Glenn Morris <rgm@gnu.org>
5400 * callint.c (Fcall_interactively): Give a more explicit error for the
5401 'c' case with a non-character input. (Bug#8479)
5403 2011-10-08 Eli Zaretskii <eliz@gnu.org>
5405 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
5407 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
5408 lines that are hscrolled on the left.
5410 * dispnew.c (buffer_posn_from_coords): Account for a possible
5411 presence of header-line. (Bug#4426)
5413 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
5415 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
5416 Don't advertise functionality which we discourage or doesn't work.
5418 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
5420 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
5421 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
5422 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
5423 this makes Emacs dump core during garbage collection on rare
5424 occasions. sizeof is obviously inferior to offsetof here, so
5425 stick with offsetof.
5426 (GC_POINTER_ALIGNMENT): New macro.
5427 (mark_memory): Omit 3rd (offset) arg; caller changed.
5428 Don't assume EMACS_INT alignment is the same as pointer alignment.
5430 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
5432 * keyboard.c (read_key_sequence_remapped): New var.
5433 (read_key_sequence): Compute remapping in the right buffer.
5434 (command_loop_1): Use read_key_sequence's remapping directly.
5436 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
5438 * dired.c (file_name_completion): Don't expand file name.
5439 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
5440 before checking file name handler.
5442 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
5443 they've been requested explicitly (bug#9591).
5445 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
5447 * keymap.c (Fsingle_key_description): Use make_specified_string
5448 instead of build_string to build string from push_key_description.
5451 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5453 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
5454 This fixes a Y2038 bug on 64-bit hosts.
5455 * buffer.c (reset_buffer):
5456 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
5457 (Fclear_buffer_auto_save_failure):
5458 Use 0, not -1, to represent an unset failure time, since time_t
5459 might not be signed.
5461 Remove dependency on glibc malloc internals.
5462 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5463 Move back here from lisp.h, but with their new implementations.
5464 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5465 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
5466 * charset.c (charset_table_init): New static var.
5467 (syms_of_charset): Use it instead of xmalloc. This removes a
5468 dependency on glibc malloc internals. See Eli Zaretskii's comment in
5469 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
5470 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5471 Move back to alloc.c.
5472 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5473 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
5475 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
5477 * nsterm.m (windowDidResize): Call x_set_window_size only when
5478 ns_in_resize is true. Otherwise set pixelwidth/height and
5479 call change_frame_size (Bug#9628).
5481 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5483 Port --enable-checking=all to Fedora 14 x86-64.
5484 * charset.c (syms_of_charset): Also account for glibc malloc's
5485 internal overhead when calculating the initial malloc maximum.
5487 Port --enable-checking=all to Fedora 14 x86.
5488 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5490 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
5491 (overrun_check_realloc, overrun_check_free):
5492 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
5493 That way, xmalloc returns a properly-aligned pointer even if
5494 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
5495 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
5496 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
5497 into account when calculating the initial malloc maximum.
5498 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5499 Move here from alloc.c, so that charset.c can use it too.
5500 Properly align; the old code wasn't right for common 32-bit hosts
5501 when configured with --enable-checking=all.
5502 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5503 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
5505 2011-09-29 Eli Zaretskii <eliz@gnu.org>
5507 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
5510 2011-09-28 Eli Zaretskii <eliz@gnu.org>
5512 * xdisp.c (compute_display_string_end): If there's no display
5513 string at CHARPOS, return -1.
5515 * bidi.c (bidi_fetch_char): When compute_display_string_end
5516 returns a negative value, treat the character as a normal
5517 character not covered by a display string. (Bug#9624)
5519 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
5521 * lread.c (Fread_from_string): Fix typo in docstring.
5523 2011-09-27 Eli Zaretskii <eliz@gnu.org>
5525 * xdisp.c (handle_invisible_prop): If invisible text ends on a
5526 newline, reseat the iterator instead of bidi-iterating there one
5527 character at a time. (Bug#9610)
5528 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
5529 TO_CHARPOS if the bidi iterator is at base embedding level.
5531 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
5533 * lread.c (readevalloop): Use correct code for NBSP.
5534 (read1): Likewise. (Bug#9608)
5536 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
5538 * dbusbind.c (Fdbus_register_signal): When service is not
5539 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
5541 2011-09-25 Glenn Morris <rgm@gnu.org>
5543 * buffer.c (truncate-lines): Doc fix.
5545 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
5547 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
5548 (Fset_window_next_buffers): Doc fix.
5550 2011-09-24 Glenn Morris <rgm@gnu.org>
5552 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
5554 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
5556 Fix minor problems found by static checking.
5557 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
5558 * indent.c (Fvertical_motion): Fix == vs = typo.
5560 2011-09-24 Eli Zaretskii <eliz@gnu.org>
5562 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
5563 Default value is now t. Doc fix.
5565 * indent.c (Fvertical_motion): Compute and apply the overshoot
5566 logic when moving up, not only when moving down. Fix the
5567 confusing name and values of the it_overshoot_expected variable;
5568 logic changes accordingly. (Bug#9254) (Bug#9549)
5570 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
5571 CHARPOS is covered by a display string which includes newlines.
5572 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
5573 is covered by a display string with embedded newlines.
5575 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
5577 * dbusbind.c (Fdbus_register_signal): Add match rule to
5578 Vdbus_registered_objects_table. (Bug#9581)
5579 (Fdbus_register_method, Vdbus_registered_objects_table):
5582 2011-09-24 Jim Meyering <meyering@redhat.com>
5584 do not ignore write error for any output size
5585 The previous change was incomplete.
5586 While it makes emacs --batch detect the vast majority of stdout
5587 write failures, errors were still ignored whenever the output size is
5588 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
5589 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
5590 && echo FAIL: ignored write error
5591 FAIL: ignored write error
5592 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
5593 && echo FAIL: ignored write error
5594 FAIL: ignored write error
5595 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
5597 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
5599 * emacs.c (Fkill_emacs): In noninteractive mode exit
5600 non-successfully if a write error occurred on stdout. (Bug#9574)
5602 2011-09-21 Eli Zaretskii <eliz@gnu.org>
5604 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
5607 * dispextern.h (struct it): Update the comment documenting what
5610 2011-09-20 Eli Zaretskii <eliz@gnu.org>
5612 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
5613 a display string, extend search for cursor position to end of row.
5614 (find_row_edges): If the row ends in a newline from a display
5615 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
5616 Handle the case of a display string with multiple newlines.
5617 (Fcurrent_bidi_paragraph_direction): Fix search for previous
5618 non-empty line. Fixes confusing cursor motion with arrow keys at
5619 the beginning of a line that starts with whitespace.
5621 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5623 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
5626 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
5628 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
5631 2011-09-18 Eli Zaretskii <eliz@gnu.org>
5633 * xdisp.c (display_line): Record maximum and minimum buffer
5634 positions even if no glyphs were produced (e.g., by a zero-width
5635 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
5636 buffer positions that will be removed from the glyph row because
5638 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
5639 column is beyond frame width: don't subtract 1 "pixel" when
5640 computing width of the stretch.
5641 (reseat_at_next_visible_line_start): Undo the change made on
5642 2011-09-17 that saved paragraph information and restored it after
5643 the call to `reseat'. (Bug#9545)
5645 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5647 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
5648 and turn window cursor on if cleared (Bug#9415).
5650 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
5652 * search.c (boyer_moore): Take unibyte characters from pattern
5653 literally. (Bug#9458)
5655 2011-09-18 Eli Zaretskii <eliz@gnu.org>
5657 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
5659 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
5661 Fix minor problem found by static checking.
5662 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
5663 initialized, to pacify gcc -Wuninitialized.
5665 * fileio.c: Report proper errno when syscall falls.
5666 (Finsert_file_contents): Save and restore errno,
5667 so that report_file_error outputs the correct diagnostic.
5668 (Fwrite_region) [CLASH_DETECTION]: Likewise.
5670 2011-09-18 Eli Zaretskii <eliz@gnu.org>
5672 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
5674 2011-09-17 Eli Zaretskii <eliz@gnu.org>
5676 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
5677 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
5679 2011-09-17 Eli Zaretskii <eliz@gnu.org>
5681 * xdisp.c (reseat_at_next_visible_line_start): Keep information
5682 about the current paragraph and restore it after the call to reseat.
5684 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
5685 (bidi_find_paragraph_start): Search back for paragraph beginning
5686 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
5687 (bidi_move_to_visually_next): Only trigger paragraph-related
5688 computations when the last character is a newline or at EOB, not
5689 just any NEUTRAL_B. (Bug#9470)
5691 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
5692 truncated lines if point is covered by a display string. (Bug#9524)
5694 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
5696 * xselect.c: Relax test for outgoing X longs (Bug#9498).
5697 (cons_to_x_long): New function.
5698 (lisp_data_to_selection_data): Use it. Correct the test for
5699 short-versus-long data; it was negated. Break out of vector
5700 loop, for efficiency, when a long datum is discovered.
5702 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
5704 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
5706 2011-09-16 Eli Zaretskii <eliz@gnu.org>
5708 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
5709 GCC PR/17406) by declaring this function with external scope.
5711 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5713 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
5714 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
5716 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
5718 * editfns.c (Fformat): Correctly handle text properties on "%%".
5720 2011-09-15 Eli Zaretskii <eliz@gnu.org>
5722 * xterm.c (x_draw_composite_glyph_string_foreground):
5723 * w32term.c (x_draw_composite_glyph_string_foreground):
5724 * term.c (encode_terminal_code):
5725 * composite.c (composition_update_it, get_composition_id):
5726 * xdisp.c (get_next_display_element)
5727 (fill_composite_glyph_string): Add comments about special meaning
5728 of TAB characters in a composition.
5730 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5732 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
5733 This occurs when processing a multibyte format.
5734 Problem reported by Wolfgang Jenker.
5736 2011-09-15 Johan Bockgård <bojohan@gnu.org>
5738 * xdisp.c (try_cursor_movement): Only check for exact match if
5739 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
5741 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5743 Remove unused external symbols.
5744 * dispextern.h (calc_pixel_width_or_height): Remove decl.
5745 * xdisp.c (calc_pixel_width_or_height): Now static.
5746 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
5747 * indent.c (check_display_width):
5748 * w32term.c: Fix comment to match code.
5749 * xterm.c, xterm.h (x_catching_errors): Remove.
5751 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5753 * xselect.c: Use signed conversions more consistently (Bug#9498).
5754 (selection_data_to_lisp_data): Assume incoming selection data are
5755 signed integers, not unsigned. This is to be consistent with
5756 outgoing selection data, which was modified to use signed integers
5757 in as part of the fix to Bug#9196 in response to Jan D.'s comment
5758 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
5759 expects long, not unsigned long.
5761 2011-09-14 Eli Zaretskii <eliz@gnu.org>
5763 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
5764 computation of loop end. Reported by Johan Bockgård
5767 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
5769 * frame.c (Fother_visible_frames_p): Function deleted.
5771 2011-09-12 Eli Zaretskii <eliz@gnu.org>
5773 * indent.c (compute_motion): Process display vector front to back
5774 rather than the other way around. (Bug#2496)
5776 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
5778 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
5780 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
5782 * minibuf.c (Fread_from_minibuffer): Doc fix.
5784 2011-09-11 Eli Zaretskii <eliz@gnu.org>
5786 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
5787 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
5789 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5791 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
5792 value for non-existent files.
5794 2011-09-11 Eli Zaretskii <eliz@gnu.org>
5796 * fileio.c (Finsert_file_contents): If the file cannot be opened,
5797 set its "size" to -1. This will set the modtime_size field of
5798 the corresponding buffer to -1, which is what
5799 verify-visited-file-modtime expects for files that do not exist.
5802 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
5804 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
5806 * lisp.h: ... from here. push_key_description is no longer
5807 defined in keyboard.c, so its declaration should not be in
5808 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
5809 logically belongs with push_key_description.
5811 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
5813 * buffer.h: Include <sys/types.h> instead of <time.h>.
5814 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
5815 Problem reported by Herbert J. Skuhra.
5817 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
5819 * xml.c (parse_region): Make the parsing work for
5820 non-comment-starting XML files again (bug#9144).
5822 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
5824 * image.c (gif_load): Fix calculation of bottom and right corner.
5827 2011-09-10 Eli Zaretskii <eliz@gnu.org>
5829 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
5830 redisplay in small windows.
5832 2011-09-09 Eli Zaretskii <eliz@gnu.org>
5834 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
5836 2011-09-08 Martin Rudalics <rudalics@gmx.at>
5838 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
5839 Operate on live windows only.
5841 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
5843 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
5845 2011-09-07 Eli Zaretskii <eliz@gnu.org>
5847 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
5848 only under bidi iteration.
5850 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
5852 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
5854 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5856 isnan: Fix porting problem to Solaris 10 with bundled gcc.
5857 Without this fix, the command to link temacs failed due to an
5858 undefined symbol __builtin_isnan. This is because
5859 /usr/include/iso/math_c99.h #defines isnan(x) to
5860 __builtin_isnan(x), but the bundled gcc, which identifies itself
5861 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
5863 * floatfns.c (isnan): #undef, and then #define to a clone of
5865 (Fisnan): Always define, since it's always available now.
5866 (syms_of_floatfns): Always define isnan at the Lisp level.
5868 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5870 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
5872 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5874 * fileio.c: Fix bugs with large file offsets (Bug#9428).
5875 The previous code assumed that file offsets (off_t values) fit in
5876 EMACS_INT variables, which is not true on typical 32-bit hosts.
5877 The code messed up by falsely reporting buffer overflow in cases
5878 such as (insert-file-contents "big" nil 1 2) into an empty buffer
5879 when "big" contains more than 2**29 bytes, even though this
5880 inserts just one byte and does not overflow the buffer.
5881 (Finsert_file_contents): Store file offsets as off_t
5882 values, not as EMACS_INT values. Check for overflow when
5883 converting between EMACS_INT and off_t. When checking for
5884 buffer overflow or for overlap, take the offsets into account.
5885 Don't use EMACS_INT for small values where int suffices.
5886 When checking for overlap, fix a typo: ZV was used where
5887 ZV_BYTE was intended.
5888 (Fwrite_region): Don't assume off_t fits into 'long'.
5889 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
5891 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
5893 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
5895 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5897 sprintf-related integer and memory overflow issues (Bug#9412).
5899 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
5900 (esprintf, exprintf, evxprintf): New functions.
5901 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
5902 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
5903 (modify_event_symbol): Do not assume that the length of
5904 name_alist_or_stem is safe to alloca and fits in int.
5905 (Fexecute_extended_command): Likewise for function name and binding.
5906 (Frecursion_depth): Wrap around reliably on integer overflow.
5907 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
5908 since some callers pass EMACS_INT values.
5909 (Fsingle_key_description): Don't crash if symbol name contains more
5910 than MAX_ALLOCA bytes.
5911 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
5912 (get_minibuffer): Arg is now EMACS_INT, not int.
5913 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
5914 (esprintf, exprintf, evxprintf): New decls.
5915 * window.h (command_loop_level, minibuf_level): Reflect API changes.
5917 * dbusbind.c (signature_cat): New function.
5918 (xd_signature, Fdbus_register_signal):
5919 Do not overrun buffer; instead, report string overflow.
5921 * dispnew.c (add_window_display_history): Don't overrun buffer.
5922 Truncate instead; this is OK since it's just a log.
5924 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
5925 even if the time zone offset is outlandishly large.
5926 Don't mishandle offset == INT_MIN.
5928 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
5929 when creating daemon; the previous buffer-overflow check was incorrect.
5931 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
5932 which has the guts of the old verror function.
5934 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
5935 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
5937 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
5938 (font_unparse_xlfd): Don't blindly alloca long strings.
5939 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
5940 fits in int, when using sprintf. Use single snprintf to count
5941 length of string rather than counting it via multiple sprintfs;
5942 that's simpler and more reliable.
5943 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
5944 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
5945 sprintf, in case result does not fit in int.
5947 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
5948 (fontset_from_font): Print it.
5950 * frame.c (tty_frame_count): Now printmax_t, not int.
5951 (make_terminal_frame, set_term_frame_name): Print it.
5952 (x_report_frame_params): In X, window IDs are unsigned long,
5953 not signed long, so print them as unsigned.
5954 (validate_x_resource_name): Check for implausibly long names,
5955 and don't assume name length fits in 'int'.
5956 (x_get_resource_string): Don't blindly alloca invocation name;
5957 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
5960 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
5961 (xg_check_special_colors, xg_set_geometry):
5962 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
5964 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
5965 Use esprintf, not sprintf, in case result does not fit in int.
5967 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5968 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
5969 it as a large positive number.
5970 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
5971 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5973 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
5974 in case result does not fit in int.
5976 * print.c (float_to_string): Detect width overflow more reliably.
5977 (print_object): Make sprintf buffer a bit bigger, to avoid potential
5978 buffer overrun. Don't assume list length fits in 'int'. Treat
5979 print length of 0 as 0, not as infinity; to be consistent with other
5980 uses of print length in this function. Don't overflow print length
5981 index. Don't assume hash table size fits in 'long', or that
5982 vectorlike size fits in 'unsigned long'.
5984 * process.c (make_process): Use printmax_t, not int, to format
5985 process-name gensyms.
5987 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
5989 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
5990 to avoid potential buffer overrun.
5992 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
5993 if X resource line is longer than 512 bytes.
5995 * xfns.c (x_window): Make sprintf buffer a bit bigger
5996 to avoid potential buffer overrun.
5998 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
6000 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
6002 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
6004 Integer overflow fixes for scrolling, etc.
6005 Without these, Emacs silently mishandles large integers sometimes.
6006 For example, "C-u 4294967297 M-x recenter" was treated as if
6007 it were "C-u 1 M-x recenter" on a typical 64-bit host.
6009 * xdisp.c (try_window_id): Check Emacs fixnum range before
6010 converting to 'int'.
6012 * window.c (window_scroll_line_based, Frecenter):
6013 Check that an Emacs fixnum is in range before assigning it to 'int'.
6014 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
6015 values converted from Emacs fixnums.
6016 (Frecenter): Don't wrap around a line count if it is out of 'int'
6017 range; instead, treat it as an extreme value.
6018 (Fset_window_configuration, compare_window_configurations):
6019 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
6021 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
6022 that can exceed INT_MAX. Check that EMACS_INT value is in range
6023 before assigning it to the (possibly-narrower) index.
6024 (match_limit): Don't assume that a fixnum can fit in 'int'.
6026 * print.c (print_object): Use ptrdiff_t, not int, for index that can
6029 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
6030 (Fvertical_motion): Don't wrap around LINES values that don't fit
6031 in 'int'. Instead, treat them as extreme values. This is good
6032 enough for windows, which can't have more than INT_MAX lines anyway.
6034 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6036 * Require libxml/parser.h to avoid compilation warning.
6038 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
6040 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
6041 since this reportedly can destroy thread storage.
6043 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
6045 * syntax.c (find_defun_start): Update all cache variables if
6046 exiting early (Bug#9401).
6048 2011-08-30 Eli Zaretskii <eliz@gnu.org>
6050 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
6052 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
6053 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
6054 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
6056 * term.c (tty_append_glyph): New function.
6057 (produce_stretch_glyph): Static function and its prototype deleted.
6059 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
6062 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
6064 * image.c (parse_image_spec): Check for nonnegative, not for positive,
6065 when checking :margin (Bug#9390).
6066 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
6067 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
6068 so that the name doesn't mislead. All uses changed.
6070 2011-08-28 Johan Bockgård <bojohan@gnu.org>
6072 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
6075 2011-08-27 Eli Zaretskii <eliz@gnu.org>
6077 * xdisp.c (move_it_to): Don't bail out early when reaching
6078 position beyond to_charpos, if we are scanning backwards.
6079 (move_it_vertically_backward): When DY == 0, make sure we get to
6080 the first character in the line after the newline.
6082 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
6084 * ccl.c: Improve and simplify overflow checking (Bug#9196).
6085 (ccl_driver): Do not generate an out-of-range pointer.
6086 (Fccl_execute_on_string): Remove unnecessary check for
6087 integer overflow, noted by Stefan Monnier in
6088 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
6089 Remove a FIXME that didn't need fixing.
6090 Simplify the newly-introduced buffer reallocation code.
6092 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
6094 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
6096 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
6098 Integer and memory overflow issues (Bug#9196).
6100 * doc.c (get_doc_string): Rework so that
6101 get_doc_string_buffer_size is the actual buffer size, rather than
6102 being 1 less than the actual buffer size; this makes xpalloc more
6105 * image.c (x_allocate_bitmap_record, cache_image):
6106 * xselect.c (Fx_register_dnd_atom):
6107 Simplify previous changes by using xpalloc.
6109 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
6110 since either will do and ptrdiff_t is convenient with xpalloc.
6112 * charset.c (charset_table_size)
6113 (struct charset_sort_data.priority): Now ptrdiff_t.
6114 (charset_compare): Don't overflow if priorities differ greatly.
6115 (Fsort_charsets): Don't assume list length fits in int.
6116 Check for size-calculation overflow when allocating sort data.
6117 (syms_of_charset): Allocate an initial charset table that is
6118 just under 64 KiB, to avoid problems with glibc malloc and mmap.
6120 * cmds.c (internal_self_insert): Check for size-calculation overflow.
6122 * composite.h (struct composition.glyph_len): Now int, not unsigned.
6123 The actual value is always <= INT_MAX, and leaving it unsigned made
6124 overflow checking harder.
6126 * dispextern.h (struct glyph_matrix.rows_allocated)
6127 (struct face_cache.size): Now ptrdiff_t, for convenience in use
6128 with xpalloc. The values are still always <= INT_MAX.
6130 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
6132 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
6133 (SAFE_NALLOCA): New macro.
6135 * region-cache.c (struct boundary.pos, find_cache_boundary)
6136 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
6137 (set_cache_region, invalidate_region_cache)
6138 (revalidate_region_cache, know_region_cache, region_cache_forward)
6139 (region_cache_backward, pp_cache):
6140 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
6141 so that ptrdiff_t * can be passed to xpalloc.
6142 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
6143 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
6144 (pp_cache): Don't assume cache_len fits in int.
6145 * region-cache.h: Adjust extern decls to match.
6147 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
6148 EMACS_INT, since either will do, for xpalloc.
6150 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
6151 (xnmalloc, xnrealloc, xpalloc): New functions.
6153 * bidi.c (bidi_shelve_header_size): New constant.
6154 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
6155 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
6157 * bidi.c (bidi_cache_shrink):
6158 * buffer.c (overlays_at, overlays_in, record_overlay_string)
6160 Don't update size of array until after memory allocation succeeds,
6161 because xmalloc/xrealloc may not return.
6162 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
6163 now that we have proper integer overflow checking.
6164 (record_overlay_string, overlay_strings): Catch overflows when
6165 calculating size of overlay_str_buf.
6167 * callproc.c (Fcall_process): Check for size overflow when
6168 calculating size of args2.
6169 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
6170 Normally we prefer signed values, but sticking with ptrdiff_t would
6171 require adding more-complicated checks.
6173 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
6174 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
6175 Redo buffer-overflow calculations to avoid integer overflow.
6176 Add a FIXME comment where memory seems to be over-allocated.
6178 * character.c (Fstring): Check for size-calculation overflow.
6180 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
6181 unnecessary integer overflow. Check for size overflow.
6182 (encode_coding_object): Don't update size until xmalloc succeeds.
6184 * composite.c (get_composition_id): Check for overflow in glyph
6185 length calculations.
6187 Integer and memory overflow fixes for display code.
6188 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
6189 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
6190 (scrolling_window): Check for overflow in size calculations.
6191 (line_draw_cost, realloc_glyph_pool, add_row_entry):
6192 Don't assume glyph table len fits in int.
6193 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
6194 (row_table_size): Now ptrdiff_t, not int.
6195 (scrolling_window): Avoid overflow in size calculations.
6196 Don't update size until allocation succeeds.
6197 * fns.c (concat): Check for overflow in size calculations.
6198 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
6199 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6200 (NEXT_ALMOST_PRIME_LIMIT): New constant.
6202 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
6203 (get_doc_string): Check for size calculation overflow.
6204 Don't update size until allocation succeeds.
6205 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
6206 EMACS_INT, where ptrdiff_t will do.
6207 (Fsubstitute_command_keys): Check for string overflow.
6209 * editfns.c (set_time_zone_rule): Don't assume environment length
6211 (message_length): Now ptrdiff_t, not int.
6212 (Fmessage_box): Don't update size until allocation succeeds.
6213 Don't assume message length fits in int.
6214 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
6216 * emacs.c (main): Do not reallocate argv, since there is a null at
6217 the end that can be overwritten, and this way there's no need to
6218 worry about size-calculation overflow.
6219 (sort_args): Check for size-calculation overflow.
6221 * eval.c (init_eval_once, grow_specpdl): Don't update size until
6223 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
6225 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
6226 (x_set_scroll_bar_width, x_figure_window_size):
6227 Check for integer overflow.
6228 (x_set_alpha): Do not assume XINT fits in int.
6230 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
6231 This is for the members text_lines, text_cols, total_lines, total_cols,
6232 where the system imposes an 'int' limit.
6234 * fringe.c (Fdefine_fringe_bitmap):
6235 Don't update size until alloc works.
6237 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
6238 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
6240 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
6241 Check for size-calculation overflow.
6242 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
6243 do, as we prefer signed integers.
6244 (id_to_widget.max_size, id_to_widget.used)
6245 (xg_store_widget_in_map, xg_remove_widget_from_map)
6246 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
6247 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
6248 Use and return ptrdiff_t, not int.
6249 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
6250 * gtkutil.h: Change prototypes to match the above.
6252 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
6253 are duplicate now that they've been promoted to lisp.h.
6254 (x_allocate_bitmap_record, x_alloc_image_color)
6255 (make_image_cache, cache_image, xpm_load):
6256 Don't update size until alloc is done.
6257 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
6259 Check for size calculation overflow.
6260 (ct_colors_allocated_max): New constant.
6261 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
6264 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
6265 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
6266 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
6267 Use ptrdiff_t, not int, to count maps.
6268 (read_char_minibuf_menu_prompt): Check for overflow in size
6269 calculations. Don't update size until allocation succeeds.
6270 Redo calculations to avoid overflow.
6271 * keyboard.h: Change prototypes to match the above.
6273 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
6275 (current_minor_maps): Check for size calculation overflow.
6276 * keymap.h: Change prototypes to match the above.
6278 * lread.c (read1, init_obarray): Don't update size until alloc done.
6280 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
6281 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
6283 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
6284 Now ptrdiff_t, not int.
6285 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
6286 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
6288 * process.c (Fnetwork_interface_list): Check for overflow
6289 in size calculation.
6291 * region-cache.c (move_cache_gap): Check for size calculation overflow.
6293 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
6294 overflow. Don't bother calling xmalloc when xrealloc will do.
6296 * search.c (Freplace_match): Check for size calculation overflow.
6297 (Fset_match_data): Don't assume list lengths fit in 'int'.
6299 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
6300 for command line length. Do not attempt to address one before the
6301 beginning of an array, as that's not portable.
6303 * term.c (max_frame_lines): Remove; unused.
6304 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
6306 (encode_terminal_code, calculate_costs): Check for size
6307 calculation overflow.
6308 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
6309 table lengths and related sizes. Don't update size until alloc
6310 done. Redo calculations to avoid overflow.
6311 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
6313 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
6314 subtracting pointers.
6315 (gobble_line): Check for overflow more carefully. Don't update size
6318 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
6319 Don't update size until alloc done.
6320 Redo size calculations to avoid overflow.
6321 Check for size calculation overflow.
6322 (main) [DEBUG]: Fix typo in invoking tparam1.
6324 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
6325 Use ptrdiff_t, not int, for sizes.
6326 (store_mode_line_noprop_char): Don't update size until alloc done.
6328 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
6329 Use ptrdiff_t, not int, for sizes.
6330 (Finternal_make_lisp_face, cache_face):
6331 Check for size calculation overflow.
6332 (cache_face): Treat size calculation overflows as if they were
6333 memory exhaustion (the usual treatment), rather than aborting.
6335 * xfns.c (x_encode_text, x_set_name_internal)
6336 (Fx_change_window_property): Use ptrdiff_t, not int, to count
6337 sizes, since they can exceed INT_MAX in size. Check for size
6338 calculation overflow.
6340 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
6341 (xg_select): Check for size calculation overflow.
6342 Don't update size until alloc done.
6344 * xrdb.c (get_environ_db): Don't assume path length fits in int,
6345 as sprintf is limited to int lengths.
6347 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
6348 (X_LONG_MIN): New macros.
6349 Use them to make the following changes clearer.
6350 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
6351 This change doesn't affect the value now, but it may help remind
6352 future maintainers not to raise the value too much later.
6353 (SELECTION_QUANTUM): Remove, replacing with ...
6354 (selection_quantum): ... new function, which avoids overflow.
6356 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
6357 assumption that selection length fits in 'int'.
6358 (x_reply_selection_request, x_handle_selection_request)
6359 (x_get_window_property, receive_incremental_selection)
6360 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
6361 (lisp_data_to_selection_data, clean_local_selection_data):
6362 Use ptrdiff_t, not int, to record length of selection.
6363 (x_reply_selection_request, x_get_window_property)
6364 (receive_incremental_selection, x_property_data_to_lisp):
6365 Redo calculations to avoid overflow.
6366 (x_reply_selection_request): When sending hint, ceiling it at
6367 X_LONG_MAX rather than relying on wraparound overflow to send
6369 (x_get_window_property, receive_incremental_selection)
6370 (lisp_data_to_selection_data, x_property_data_to_lisp):
6371 Check for size-calculation overflow.
6372 (x_get_window_property, receive_incremental_selection)
6373 (lisp_data_to_selection_data, Fx_register_dnd_atom):
6374 Don't store size until memory allocation succeeds.
6375 (x_get_window_property): Plug memory leak on memory exhaustion.
6376 Don't double-block input; malloc is safe here. Don't assume 2**34
6377 - 4 fits in unsigned long. Add an xassert to check
6378 XGetWindowProperty overflow. Be more careful about overflow
6379 calculations, and distinguish size from memory overflow better.
6380 (receive_incremental_selection): When tracing, don't assume
6381 unsigned int is less than INT_MAX.
6382 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
6383 harmful) conversions of unsigned short to int.
6384 (lisp_data_to_selection_data): Don't assume that integers
6385 in the range -65535 through -1 fit in an X unsigned short.
6386 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
6387 result parameters unless successful. Rely on cons_to_unsigned
6388 to report problems with elements; the old code wasn't right anyway.
6389 (x_check_property_data): Check for int overflow; we cannot use
6390 a wider type due to X limits.
6391 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
6393 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
6395 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
6396 (x_term_init): Check for size calculation overflow.
6397 (x_color_cells): Don't store size until memory allocation succeeds.
6398 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
6399 Don't assume alloca size is less than MAX_ALLOCA.
6400 (x_term_init): Don't assume length fits in int (sprintf is limited
6403 Use ptrdiff_t for composition IDs.
6404 * character.c (lisp_string_width):
6405 * composite.c (composition_table_size, n_compositions)
6406 (get_composition_id, composition_gstring_from_id):
6407 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
6408 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
6409 * window.c (Frecenter):
6410 Use ptrdiff_t, not int, for composition IDs.
6411 * composite.c (get_composition_id): Check for integer overflow.
6412 * composite.h: Adjust prototypes to match the above changes.
6414 Use ptrdiff_t for hash table indexes.
6415 * category.c (hash_get_category_set):
6416 * ccl.c (ccl_driver):
6417 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
6418 * coding.c (coding_system_charset_list, detect_coding_system):
6419 * coding.h (struct coding_system.id):
6420 * composite.c (get_composition_id, gstring_lookup_cache):
6421 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
6422 * image.c (xpm_get_color_table_h):
6423 * lisp.h (hash_lookup, hash_put):
6424 * minibuf.c (Ftest_completion):
6425 Use ptrdiff_t for hash table indexes, not int (which is too
6426 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
6427 32-bit --with-wide-int hosts).
6429 * charset.c (Fdefine_charset_internal): Check for integer overflow.
6430 Add a FIXME comment about memory leaks.
6431 (syms_of_charset): Don't assume xmalloc returns.
6433 Don't assume that stated character widths fit in int.
6434 * character.c (Fchar_width, c_string_width, lisp_string_width):
6435 * character.h (CHAR_WIDTH):
6436 * indent.c (MULTIBYTE_BYTES_WIDTH):
6437 Use sanitize_char_width to avoid undefined and/or bad behavior
6438 with outlandish widths.
6439 * character.h (sanitize_tab_width): Rename from sanitize_width,
6440 now that we have two such functions. All uses changed.
6441 (sanitize_char_width): New inline function.
6443 Don't assume that tab-width fits in int.
6444 * character.h (sanitize_width): New inline function.
6445 (SANE_TAB_WIDTH): New macro.
6446 (ASCII_CHAR_WIDTH): Use it.
6447 * indent.c (sane_tab_width): Remove. All uses replaced by
6448 SANE_TAB_WIDTH (current_buffer).
6449 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
6451 * fileio.c: Integer overflow issues with file modes.
6452 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
6454 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
6455 Remove unreachable code.
6456 (read_hex, load_charset_map_from_file): Check for integer overflow.
6458 * xterm.c: Don't go over XClientMessageEvent limit.
6459 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
6460 (x_send_scroll_bar_event): Likewise. Check that the size does not
6461 exceed limits imposed by XClientMessageEvent, as well as the usual
6462 ptrdiff_t and size_t limits.
6464 * keyboard.c: Overflow, signedness and related fixes.
6465 (make_lispy_movement): Use same integer type in forward decl
6466 that is used in the definition.
6467 (read_key_sequence, keyremap_step):
6468 Change bufsize argument back to int, undoing my 2011-03-30 change.
6469 We prefer signed types, and int is wide enough here.
6470 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
6471 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
6472 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
6473 length, not size_t. Use ptrdiff_t for index, not int.
6474 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
6475 possibility of integer overflow.
6477 Overflow, signedness and related fixes for images.
6479 * dispextern.h (struct it.stack[0].u.image.image_id)
6480 (struct_it.image_id, struct image.id, struct image_cache.size)
6481 (struct image_cache.used, struct image_cache.ref_count):
6482 * gtkutil.c (update_frame_tool_bar):
6483 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
6484 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
6485 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
6486 * nsmenu.m (update_frame_tool_bar):
6487 * xdisp.c (calc_pixel_width_or_height):
6488 * xfns.c (image_cache_refcount):
6489 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
6490 on typical 64-bit hosts.
6492 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6493 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
6494 Omit unnecessary casts to int.
6495 (parse_image_spec): Check that integers fall into 'int' range
6496 when the callers expect that.
6497 (image_ascent): Redo ascent calculation to avoid int overflow.
6498 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
6499 (lookup_image): Remove unnecessary tests.
6500 (xbm_image_p): Locals are now of int, not EMACS_INT,
6501 since parse_image_check makes sure they fit into int.
6502 (png_load, gif_load, svg_load_image):
6503 Prefer int to unsigned where either will do.
6504 (tiff_handler): New function, combining the cores of the
6505 old tiff_error_handler and tiff_warning_handler.
6506 This function is rewritten to use vsnprintf and thereby avoid
6507 stack buffer overflows. It uses only the features of vsnprintf
6508 that are common to both POSIX and native Microsoft.
6509 (tiff_error_handler, tiff_warning_handler): Use it.
6510 (tiff_load, gif_load, imagemagick_load_image):
6511 Don't assume :index value fits in 'int'.
6512 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
6513 (imagemagick_load_image): Check that crop parameters fit into
6514 the integer types that MagickCropImage accepts. Don't assume
6515 Vimagemagick_render_type has a nonnegative value. Don't assume
6516 size_t fits in 'long'.
6517 (gs_load): Use printmax_t to print the widest integers possible.
6518 Check for integer overflow when computing image height and width.
6520 2011-08-26 Eli Zaretskii <eliz@gnu.org>
6522 * xdisp.c (redisplay_window): Don't force window start if point
6523 will be invisible in the resulting window. (Bug#9324)
6525 2011-08-25 Eli Zaretskii <eliz@gnu.org>
6527 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
6528 the display spec is of the form `(space ...)'.
6529 (handle_display_spec): Return the value returned by
6530 handle_single_display_spec, not just 1 or zero.
6531 (handle_single_display_spec): If the display spec is of the form
6532 `(space ...)', and specifies display in the text area, return 2
6534 (try_cursor_movement): Check for the need to scroll more
6535 accurately, and prefer exact match for point under bidi.
6536 Don't advance `row' beyond the last row of the window.
6538 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
6539 into disp_prop; all users changed.
6541 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
6542 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
6543 for the text covered by the display property.
6545 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
6547 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
6548 Change return value to nil.
6549 (Frecord_buffer): Delete unused function.
6551 2011-08-24 Eli Zaretskii <eliz@gnu.org>
6553 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
6554 buffers, return left-to-right.
6555 (set_cursor_from_row): Consider candidate row a win if its glyph
6556 represents a newline and point is on that newline. Fixes cursor
6557 positioning on the newline at EOL of R2L text within L2R
6558 paragraph, and vice versa.
6559 (try_cursor_movement): Check continued rows, in addition to
6560 continuation rows. Fixes unwarranted scroll when point enters a
6561 continued line of R2L text within an L2R paragraph, or vice versa.
6562 (cursor_row_p): Consider the case of point being equal to
6563 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
6564 from the end of a short line to the beginning of a continued line
6565 of R2L text within L2R paragraph.
6566 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
6567 composed characters.
6569 * bidi.c (bidi_check_type): Use xassert.
6570 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
6573 2011-08-23 Eli Zaretskii <eliz@gnu.org>
6575 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
6578 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
6580 * nsfont.m (ns_otf_to_script): Fix typo.
6582 2011-08-22 Kenichi Handa <handa@m17n.org>
6584 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
6585 extra slot even if the purpose is char-code-property-table.
6587 2011-08-23 Eli Zaretskii <eliz@gnu.org>
6589 * xdisp.c (redisplay_window): When computing centering_position,
6590 account for the height of the header line. (Bug#8874)
6592 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
6593 instead of CHAR_TO_BYTE. Fixes a crash when a completion
6594 candidate is selected by the mouse, and that candidate has a
6595 composed character under the mouse.
6597 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
6598 coordinates reported by pos-visible-in-window-p for a composed
6599 character in column zero.
6601 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
6603 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
6605 2011-08-22 Eli Zaretskii <eliz@gnu.org>
6607 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
6608 consider it a hit if to_charpos is anywhere in the range of the
6609 composed buffer positions.
6611 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
6613 * image.c (gif_load): Don't assume that each subimage has the same
6614 dimensions as the base image. Handle disposal method that is
6615 "undefined" by the gif spec (Bug#9335).
6617 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
6619 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
6620 (Fcondition_case): Document `debug' symbol in error handler.
6622 2011-08-19 Eli Zaretskii <eliz@gnu.org>
6624 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
6625 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
6626 from an Org mode buffer to a Speedbar frame.
6628 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
6629 a composition, take its buffer position from IT->cmp_it.charpos.
6630 Fixes cursor positioning at the beginning of a line that begins
6631 with a composed character.
6633 2011-08-18 Eli Zaretskii <eliz@gnu.org>
6635 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
6636 character bidirectional type, use STRONG_L instead. Fixes crashes
6637 in a buffer produced by `describe-categories'.
6639 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
6640 members before the level stack, so they would be saved and
6641 restored when copying iterator state. Fixes incorrect reordering
6642 around TABs covered by display properties.
6644 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
6646 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
6648 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
6650 * eval.c (internal_condition_case, internal_condition_case_1)
6651 (internal_condition_case_2, internal_condition_case_n):
6652 Remove unnecessary aborts (Bug#9081).
6654 2011-08-17 Eli Zaretskii <eliz@gnu.org>
6656 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
6657 has no `load' handler, try opening the file locally. (Bug#9311)
6659 2011-08-16 Ken Brown <kbrown@cornell.edu>
6661 * gmalloc.c: Expand comment.
6663 2011-08-16 Eli Zaretskii <eliz@gnu.org>
6665 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
6666 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
6668 2011-08-16 Ken Brown <kbrown@cornell.edu>
6670 Fix memory allocation problems in Cygwin build (Bug#9273).
6672 * unexcw.c ( __malloc_initialized): Declare external variable.
6673 (fixup_executable): Force the dumped emacs to reinitialize malloc.
6675 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
6677 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
6679 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
6681 [CYGWIN] (special_realloc): New function.
6682 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
6683 requests to realloc storage in the static heap.
6685 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
6687 * bidi.c (bidi_initialize): Remove unused local.
6689 2011-08-15 Eli Zaretskii <eliz@gnu.org>
6692 * biditype.h: Remove file.
6693 * makefile.w32-in ($(BLD)/bidi.$(O)):
6694 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
6696 * dispextern.h: Fix a typo in the comment to bidi_type_t.
6698 * chartab.c: Improve commentary for the uniprop_table API.
6700 * bidi.c (bidi_paragraph_init): Support zero value of
6701 bidi_ignore_explicit_marks_for_paragraph_level.
6702 (bidi_initialize): Use uniprop_table instead of including
6703 biditype.h and bidimirror.h.
6705 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
6706 coordinates of the iterator when restoring from ppos_it.
6709 2011-08-14 Kenichi Handa <handa@m17n.org>
6711 * process.c (create_process): Call setup_process_coding_systems
6712 after the pid of the process is set to -1 (Bug#8162).
6714 2011-08-14 Eli Zaretskii <eliz@gnu.org>
6716 * xdisp.c (move_it_in_display_line_to): Don't invoke
6717 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
6718 ppos_it. Fixes vertical cursor motion when line beginning is
6719 covered by an image. (Bug#9296)
6721 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
6723 * nsterm.h (ns_run_ascript): Declare.
6724 (NSAPP_DATA2_RUNASSCRIPT): Define.
6726 * nsfns.m (as_script, as_result, as_status): New static variables.
6727 (ns_run_ascript): New function.
6728 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
6729 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
6730 the event loop. Get status from as_status (Bug#7276).
6732 * nsterm.m (sendEvent): If event is NSApplicationDefined and
6733 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
6734 the event loop (Bug#7276).
6736 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
6738 * gnutls.c (QCgnutls_bootprop_priority)
6739 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
6740 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
6741 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
6742 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
6743 (QCgnutls_bootprop_verify_hostname_error)
6744 (QCgnutls_bootprop_callbacks_verify): Rename from
6745 Qgnutls_bootprop_..., all uses changed.
6747 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
6750 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
6752 * xfaces.c (Qframe_set_background_mode): Now static.
6753 * dispextern.h (Qframe_set_background_mode): Remove decl.
6755 * process.c (Fnetwork_interface_info): Declare local only if needed.
6757 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
6759 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
6760 (Fnetwork_interface_list): Allocate in increments of bytes instead
6761 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
6762 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
6764 (struct ifflag_def): notrailers is smart on OSX.
6765 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
6766 Get hardware address with getifaddrs if available.
6768 2011-08-12 Eli Zaretskii <eliz@gnu.org>
6770 * xdisp.c (iterate_out_of_display_property): xassert that
6771 IT->position is set to within IT->object's boundaries. Break from
6772 the loop as soon as EOB is reached; avoids infloops in redisplay
6773 when IT->position is set up wrongly due to some bug.
6774 Set IT->current to match the bidi iterator unconditionally.
6775 (push_display_prop): Allow GET_FROM_STRING as IT->method on
6776 entry. Force push_it to save on the stack the current
6777 buffer/string position, to be restored by pop_it. Fix flags in
6778 the iterator structure wrt the object coming from a display
6779 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
6780 properties. (Bug#9284)
6782 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
6784 * fontset.c (fontset_get_font_group): Add proper type checks.
6787 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6789 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
6790 and LC_VERSION_MIN_MACOSX.
6791 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
6792 (dump_it) [LC_FUNCTION_STARTS]: Use it.
6794 2011-08-08 Eli Zaretskii <eliz@gnu.org>
6796 * xdisp.c (forward_to_next_line_start): Allow to use the
6797 no-display-properties-and-no-overlays under bidi display.
6798 Set disp_pos in the bidi iterator to avoid searches for display
6799 properties and overlays.
6801 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
6803 * editfns.c (Fset_time_zone_rule): Document relationship with the
6806 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
6807 the font entity extracted from the cache (Bug#8109).
6809 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
6811 * composite.c (autocmp_chars): Don't reset point. That is done by
6812 restore_point_unwind (Bug#5984).
6814 2011-08-07 Juri Linkov <juri@jurta.org>
6816 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
6817 to show the arg `TIME' instead of `TIMEVAL'.
6819 2011-08-06 Eli Zaretskii <eliz@gnu.org>
6821 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
6822 display property strides EOL and includes a newline, as in
6823 longlines-mode. (Bug#9254)
6824 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
6825 word-wrap under bidirectional display. (Bug#9224)
6827 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
6828 is non-zero, even if the data buffer is NULL. Fixes a crash in
6829 vertical-motion with longlines-mode. (Bug#9254)
6831 2011-08-05 Eli Zaretskii <eliz@gnu.org>
6833 * bidi.c <bidi_cache_total_alloc>: Now static.
6834 (bidi_initialize): Initialize bidi_cache_total_alloc.
6836 * xdisp.c (display_line): Release buffer allocated for shelved bidi
6839 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
6840 amount allocated this far in `bidi_cache_total_alloc'.
6841 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
6842 non-zero, only free the data buffer without restoring the cache
6843 contents. All callers changed.
6845 * dispextern.h (bidi_unshelve_cache): Update prototype.
6847 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
6848 (move_it_in_display_line, move_it_to)
6849 (move_it_vertically_backward, move_it_by_lines): Replace the call
6850 to xfree to an equivalent call to bidi_unshelve_cache.
6851 (move_it_in_display_line_to): Fix logic of returning
6852 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
6854 2011-08-05 Eli Zaretskii <eliz@gnu.org>
6856 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
6857 came from a string character with a `cursor' property. (Bug#9229)
6859 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6861 * Makefile.in (LIB_PTHREAD): New variable.
6862 (LIBES): Add LIB_PTHREAD (Bug#9216).
6864 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
6865 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
6867 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
6869 * regex.c (re_iswctype): Remove some redundant boolean conversions.
6871 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6873 * xterm.c (x_find_topmost_parent): New function.
6874 (x_set_frame_alpha): Find topmost parent window with
6875 x_find_topmost_parent and set the property there also (bug#9181).
6876 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
6878 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
6880 * callproc.c (Fcall_process): Avoid vfork clobbering
6881 the local vars buffer, coding_systems, current_dir.
6883 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
6885 * keymap.c (Fmake_composed_keymap): Move to subr.el.
6887 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
6889 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
6890 so that it is not optimized away.
6892 * xdisp.c (compute_display_string_pos): Remove unused local.
6894 2011-08-02 Eli Zaretskii <eliz@gnu.org>
6896 Fix slow cursor motion and scrolling in large buffers with
6897 selective display, like Org Mode buffers. (Bug#9218)
6899 * dispextern.h (struct bidi_it): New member disp_prop_p.
6901 * xdisp.c: Remove one-slot cache of display string positions.
6902 (compute_display_string_pos): Accept an additional argument
6903 DISP_PROP_P; callers changed. Scan at most 5K characters forward
6904 for a display string or property. If found, set DISP_PROP_P
6907 * bidi.c (bidi_fetch_char): Accept an additional argument
6908 DISP_PROP_P, and pass it to compute_display_string_pos.
6909 Only handle text covered by a display string if DISP_PROP_P is returned
6910 non-zero. All callers of bidi_fetch_char changed.
6912 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
6914 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
6916 2010-12-03 Don March <don@ohspite.net>
6918 * keymap.c (Fdefine_key): Fix non-prefix key error message when
6919 last character M-[char] is translated to ESC [char] (bug#7541).
6921 2011-08-02 Kenichi Handa <handa@m17n.org>
6923 * lisp.h (uniprop_table): Extern it.
6925 * chartab.c (uniprop_table): Make it non-static.
6927 2011-08-01 Eli Zaretskii <eliz@gnu.org>
6929 * xdisp.c (forward_to_next_line_start): Accept additional argument
6930 BIDI_IT_PREV, and store into it the state of the bidi iterator had
6932 (reseat_at_next_visible_line_start): Use the bidi iterator state
6933 returned by forward_to_next_line_start to restore the state of
6934 it->bidi_it after backing up to previous newline. (Bug#9212)
6936 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
6938 * regex.c (re_comp): Protoize.
6939 (re_exec): Fix return type.
6940 (regexec): Fix type of `ret'. (Bug#9203)
6942 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6944 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
6945 This is needed if max-image-size is a floating-point number.
6947 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6949 * print.c (print_object): Print empty symbol as ##.
6951 * lread.c (read1): Read ## as empty symbol.
6953 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6955 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
6956 setting frame foreground color (Bug#9175).
6957 (x_set_background_color): Likewise.
6959 * nsmenu.m (-setText): Size tooltip dimensions precisely to
6960 contents (Bug#9176).
6961 (EmacsTooltip -init): Remove bezels and add shadows to
6964 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
6965 or scroll bar (Bug#8470).
6967 * nsfont.m (nsfont_open): Remove assignment to voffset and
6968 unnecessary vars hshink, expand, hd, full_height, min_height.
6969 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
6971 * nsterm.h (nsfont_info): Remove voffset field.
6973 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6975 Implement strike-through and overline on NextStep (Bug#8863).
6977 * nsfont.m (nsfont_open): Use underline position provided by font,
6978 instead of hard-coded value of 2.
6979 (nsfont_draw): Call ns_draw_text_decoration instead.
6981 * nsterm.h: Add declaration for ns_draw_text_decoration.
6983 * nsterm.m (ns_draw_text_decoration): New function for drawing
6984 underline, overline, and strike-through.
6985 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
6986 ns_draw_text_decoration. Change treatment of cursor drawing to
6987 accommodate underlining, etc.
6989 2011-07-28 Eli Zaretskii <eliz@gnu.org>
6991 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
6994 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6996 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
6997 Without this fix, if a signal arrives just after memory fills up,
6998 'malloc' might be invoked reentrantly.
7000 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
7001 In other words, assume that every image size is allowed, on non-X
7002 hosts. This assumption is probably wrong, but it lets Emacs compile.
7004 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
7006 * regex.c (re_iswctype): Convert return values to boolean.
7008 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
7010 * xdisp.c (compute_display_string_pos): Don't use cached display
7011 string position if the buffer had its restriction changed.
7014 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7016 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
7018 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
7020 Integer signedness and overflow and related fixes. (Bug#9079)
7022 * bidi.c: Integer size and overflow fixes.
7023 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
7024 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
7025 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7026 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
7027 (bidi_find_other_level_edge):
7028 Use ptrdiff_t instead of EMACS_INT where either will do.
7029 This works better on 32-bit hosts configured --with-wide-int.
7030 (bidi_cache_ensure_space): Check for size-calculation overflow.
7031 Use % rather than repeated addition, for better worst-case speed.
7032 Don't set bidi_cache_size until after xrealloc returns, because it
7034 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
7035 (bidi_cache_ensure_space): Also check that the bidi cache size
7036 does not exceed that of the largest Lisp string or buffer. See Eli
7037 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
7039 * alloc.c (__malloc_size_t): Remove.
7040 All uses replaced by size_t. See Andreas Schwab's note
7041 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
7043 * image.c: Improve checking for integer overflow.
7044 (check_image_size): Assume that f is nonnull, since
7045 it is always nonnull in practice. This is one less thing to
7046 worry about when checking for integer overflow later.
7047 (x_check_image_size): New function, which checks for integer
7048 overflow issues inside X.
7049 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
7050 This removes the need for a memory_full check.
7051 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
7052 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
7053 (xbm_read_bitmap_data): Change locals back to 'int', since
7054 their values must fit in 'int'.
7055 (xpm_load_image, png_load, tiff_load):
7056 Invoke x_create_x_image_and_pixmap earlier,
7057 to avoid much needless work if the image is too large.
7058 (tiff_load): Treat overly large images as if
7059 x_create_x_image_and_pixmap failed, not as malloc failures.
7060 (gs_load): Use x_check_image_size.
7062 * gtkutil.c: Omit integer casts.
7063 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
7064 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
7066 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
7068 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
7069 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
7070 would wrongly return t on a 64-bit host.
7072 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
7073 The plain *_OVERFLOW macros run afoul of GCC bug 49705
7074 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
7075 and therefore cause GCC to emit a bogus diagnostic in some cases.
7077 * image.c: Integer signedness and overflow and related fixes.
7078 This is not an exhaustive set of fixes, but it's time to
7079 record what I've got.
7080 (lookup_pixel_color, check_image_size): Remove redundant decls.
7081 (check_image_size): Don't assume that arbitrary EMACS_INT values
7082 fit in 'int', or that arbitrary 'double' values fit in 'int'.
7083 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
7084 (tiff_load, imagemagick_load_image):
7085 Check for overflow in size calculations.
7086 (x_create_x_image_and_pixmap): Remove unnecessary test for
7087 xmalloc returning NULL; that can't happen.
7088 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
7089 (xpm_color_bucket): Use better integer hashing function.
7090 (xpm_cache_color): Don't possibly over-allocate memory.
7091 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
7092 (gif_memory_source):
7093 Use ptrdiff_t, not int or size_t, to record sizes.
7094 (png_load): Don't assume values greater than 2**31 fit in 'int'.
7095 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
7096 either works, as we prefer signed integers.
7097 (tiff_read_from_memory, tiff_write_from_memory):
7098 Return tsize_t, not size_t, since that's what the TIFF API wants.
7099 (tiff_read_from_memory): Don't fail simply because the read would
7100 go past EOF; instead, return a short read.
7101 (tiff_load): Omit no-longer-needed casts.
7102 (Fimagemagick_types): Don't assume size fits into 'int'.
7104 Improve hashing quality when configured --with-wide-int.
7105 * fns.c (hash_string): New function, taken from sxhash_string.
7106 Do not discard information about ASCII character case; this
7107 discarding is no longer needed.
7108 (sxhash-string): Use it. Change sig to match it. Caller changed.
7109 * lisp.h: Declare it.
7110 * lread.c (hash_string): Remove, since we now use fns.c's version.
7111 The fns.c version returns a wider integer if --with-wide-int is
7112 specified, so this should help the quality of the hashing a bit.
7114 * emacs.c: Integer overflow minor fix.
7115 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
7116 Define only if GNU_LINUX.
7117 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
7119 * dispnew.c: Integer signedness and overflow fixes.
7120 Remove unnecessary forward decls, that were a maintenance hassle.
7121 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
7123 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
7124 (scrolling_window): Use ptrdiff_t, not int, for byte count.
7125 (prepare_desired_row, line_draw_cost):
7126 Use int, not unsigned, where either works.
7127 (save_current_matrix, restore_current_matrix):
7128 Use ptrdiff_t, not size_t, where either works.
7129 (init_display): Check for overflow more accurately, and without
7130 relying on undefined behavior.
7132 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
7133 Remove, replacing with the new symbols in lisp.h. All uses changed.
7134 * fileio.c (make_temp_name):
7135 * filelock.c (lock_file_1, lock_file):
7136 * xdisp.c (message_dolog):
7137 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
7138 Use pMd etc. instead.
7139 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
7140 replacing the pWIDE etc. symbols removed from editfns.c.
7142 * keyboard.h (num_input_events): Now uintmax_t.
7143 This is (very slightly) less likely to mess up due to wraparound.
7146 * buffer.c: Integer signedness fixes.
7147 (alloc_buffer_text, enlarge_buffer_text):
7148 Use ptrdiff_t rather than size_t when either will do, as we prefer
7151 * alloc.c: Integer signedness and overflow fixes.
7152 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
7153 (__malloc_size_t): Default to size_t, not to int.
7154 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
7155 (Fgarbage_collect, mark_object_loop_halt, mark_object):
7156 Prefer ptrdiff_t to size_t when either would do, as we prefer
7158 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
7159 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
7160 Now const. Initialize with values that are in range even if char
7162 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
7163 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
7164 These functions do the right thing with sizes > 2**32.
7165 (check_depth): Now ptrdiff_t, not int.
7166 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
7167 Adjust to new way of storing sizes. Check for size overflow bugs
7169 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
7170 slightly wrong anyway, as it missed one instance of
7171 XMALLOC_OVERRUN_CHECK_OVERHEAD.
7172 (refill_memory_reserve): Omit needless cast to size_t.
7173 (mark_object_loop_halt): Mark as externally visible.
7175 * xselect.c: Integer signedness and overflow fixes.
7176 (Fx_register_dnd_atom, x_handle_dnd_message):
7177 Use ptrdiff_t, not size_t, since we prefer signed.
7178 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
7179 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
7180 x_dnd_atoms_size and x_dnd_atoms_length.
7182 * doprnt.c: Prefer signed to unsigned when either works.
7184 * doprnt.c (doprnt):
7186 * xdisp.c (vmessage):
7187 Use ptrdiff_t, not size_t, when using or implementing doprnt,
7188 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
7189 prefer signed arithmetic to avoid comparison confusion.
7190 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
7191 but is a bit tricky.
7193 Assume freestanding C89 headers, string.h, stdlib.h.
7194 * data.c, doprnt.c, floatfns.c, print.c:
7195 Include float.h unconditionally.
7196 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
7197 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
7198 * regex.c: Likewise for stddef.h, string.h.
7199 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
7200 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
7201 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
7202 (STDC_HEADERS): Remove obsolete defines.
7203 * sysdep.c: Include limits.h unconditionally.
7205 Assume support for memcmp, memcpy, memmove, memset.
7206 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
7207 * regex.c (memcmp, memcpy):
7208 Remove; we assume C89 now.
7210 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
7211 (__malloc_safe_bcopy): Remove; no longer needed.
7213 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
7214 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
7215 well either way, and we prefer signed to unsigned.
7217 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
7219 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
7220 closes the connection while we're reading (bug#9182).
7222 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
7224 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
7225 are specified (Bug#9168).
7227 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
7229 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
7230 Found by GCC static checking and --with-wide-int on a 32-bit host.
7232 2011-07-25 Eli Zaretskii <eliz@gnu.org>
7234 * xdisp.c (compute_display_string_pos): Fix logic of caching
7235 previous display string position. Initialize cached_prev_pos to
7236 -1. Fixes slow-down at the beginning of a buffer.
7238 2011-07-24 Eli Zaretskii <eliz@gnu.org>
7240 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
7241 for attrs[LFACE_FONTSET_INDEX].
7243 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
7245 * xml.c (parse_region): Remove unused local
7246 that was recently introduced.
7248 2011-07-23 Eli Zaretskii <eliz@gnu.org>
7250 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
7251 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
7253 * xdisp.c (move_it_in_display_line_to): Record the best matching
7254 position for TO_CHARPOS while scanning the line, and restore it on
7255 exit if none of the characters scanned was an exact match.
7256 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
7257 when exact match is impossible due to invisible text, and the
7258 lines are truncated.
7260 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
7262 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
7265 2011-07-22 Eli Zaretskii <eliz@gnu.org>
7267 Fix a significant slow-down of cursor motion with C-n, C-p,
7268 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
7269 auto-repeat under bidi redisplay in fontified buffers.
7270 * xdisp.c (compute_stop_pos_backwards): New function.
7271 (next_element_from_buffer): Call compute_stop_pos_backwards to
7272 find a suitable prev_stop when we find ourselves before
7274 (reseat): Don't look for prev_stop, as that could mean a very long
7276 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
7277 <cached_disp_overlay_modiff>: Cache for last found display string
7279 (compute_display_string_pos): Return the cached position if asked
7280 about the same buffer in the same area of character positions, and
7281 the buffer wasn't changed since the time the display string
7282 position was cached.
7284 2011-07-22 Eli Zaretskii <eliz@gnu.org>
7286 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
7287 is an integer, which is important for empty lines. (Bug#9149)
7289 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
7291 * frame.c (Fmodify_frame_parameters): In tty case, update the
7292 default face if necessary (Bug#4238).
7294 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
7296 * editfns.c (Fstring_to_char): No need to explain what a character
7297 is in the docstring (Bug#6576).
7299 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7301 * xml.c (parse_region): Make sure we always return a tree.
7303 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
7305 * xml.c (parse_region): If a document contains only comments,
7308 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7310 * xml.c (make_dom): Return comments, too.
7312 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
7315 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
7316 and the surrounding thread.
7317 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
7318 rather than fgets, and retry after EINTR. Otherwise, 'emacs
7319 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
7321 * s/openbsd.h (BROKEN_SIGIO): Define.
7322 * unexelf.c (unexec) [__OpenBSD__]:
7323 Don't update the .mdebug section of the Alpha COFF symbol table.
7325 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7327 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
7330 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
7332 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
7333 This fixes some race conditions on the permissions of any newly
7336 * alloc.c (valid_pointer_p): Use pipe, not open.
7337 This fixes some permissions issues when debugging.
7339 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
7340 If fchown fails to set both uid and gid, try to set just gid,
7341 as that is sometimes allowed. Adjust the file's mode to eliminate
7342 setuid or setgid bits that are inappropriate if fchown fails.
7344 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
7346 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
7347 to compare Lisp_Objects.
7348 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
7349 global_gnutls_log_level, don't mistake it for a Lisp_Object.
7350 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
7352 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
7354 * lread.c (read_integer): Unread even EOF character.
7355 (read1): Likewise. Properly record start position of symbol.
7357 * lread.c (read1): Read `#:' as empty uninterned symbol if no
7358 symbol character follows.
7360 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
7362 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
7363 This works around a problem with the previous change to Fcopy_file.
7364 Recent glibc declares fchown with __attribute__((warn_unused_result)),
7365 and without this change, GCC might complain about discarding
7366 fchown's return value.
7368 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
7370 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
7372 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
7374 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
7376 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
7378 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
7379 it's used from the C level.
7381 * process.c: Use the same condition for POLL_FOR_INPUT in both
7382 keyboard.c and process.c (bug#1858).
7384 2011-07-09 Lawrence Mitchell <wence@gmx.li>
7386 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
7387 (Fgnutls_boot): Use it.
7389 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
7391 * doc.c (Fsubstitute_command_keys): Revert last change.
7393 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
7395 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
7396 quotes the next character, and doesn't affect other longer
7397 sequences (bug#8935).
7399 * lread.c (syms_of_lread): Clarify that is isn't only
7400 `eval-buffer' and `eval-defun' that's affected by
7401 `lexical-binding' (bug#8460).
7403 2011-07-15 Eli Zaretskii <eliz@gnu.org>
7405 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
7406 bidi redisplay when a line includes both an image and is truncated.
7408 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
7410 Fix minor problems found by static checking.
7411 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
7412 (elsz): Now a signed constant, not a size_t var. We prefer signed
7413 types to unsigned, to avoid integer comparison confusion. Without
7414 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
7415 "cannot optimize loop, the loop counter may overflow", a symptom
7417 * indent.c (Fvertical_motion): Mark locals as initialized.
7418 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
7420 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7422 * search.c (Fre_search_backward): Mention `case-fold-search' in
7423 all the re_search_* functions (bug#8138).
7425 * keyboard.c (Fopen_dribble_file): Document when the file is
7428 2011-07-14 Eli Zaretskii <eliz@gnu.org>
7430 * bidi.c (bidi_dump_cached_states): Fix format of displaying
7433 Support bidi reordering of display and overlay strings.
7434 * xdisp.c (compute_display_string_pos)
7435 (compute_display_string_end): Accept additional argument STRING.
7436 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
7437 (reseat_to_string): Initialize bidi_it->string.s and
7438 bidi_it->string.schars.
7439 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
7440 NULL (avoids a crash in bidi_paragraph_init).
7441 Initialize itb.string.lstring.
7442 (init_iterator): Call bidi_init_it only of a valid
7443 buffer position was specified. Initialize paragraph_embedding to
7445 (reseat_to_string): Initialize the bidi iterator.
7446 (display_string): If we need to ignore text properties of
7447 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
7448 original value of -1 will not work with bidi.)
7449 (compute_display_string_pos): First arg is now struct
7450 `text_pos *'; all callers changed. Support display properties on
7452 (compute_display_string_end): Support display properties on Lisp
7454 (init_iterator, reseat_1, reseat_to_string): Initialize the
7455 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
7456 when iterating on a string not from display properties).
7457 (compute_display_string_pos, compute_display_string_end):
7458 Fix calculation of the object to scan. Fixes an error when using
7460 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
7461 base_level_stop; instead, set base_level_stop to BEGV.
7462 Fixes crashes in vertical-motion.
7463 (next_element_from_buffer): Improve commentary for when
7464 the iterator is before prev_stop.
7465 (init_iterator): Initialize bidi_p from the default value of
7466 bidi-display-reordering, not from buffer-local value. Use the
7467 buffer-local value only if initializing for buffer iteration.
7468 (handle_invisible_prop): Support invisible properties on strings
7469 that are being bidi-reordered.
7470 (set_iterator_to_next): Support bidi reordering of C strings and
7472 (next_element_from_string): Support bidi reordering of Lisp
7474 (handle_stop_backwards): Support Lisp strings as well.
7475 (display_string): Support display of R2L glyph rows.
7476 Use IT_STRING_CHARPOS when displaying from a Lisp string.
7477 (init_iterator): Don't initialize it->bidi_p for strings
7479 (reseat_to_string): Initialize it->bidi_p for strings here.
7480 (next_element_from_string, next_element_from_c_string)
7481 (next_element_from_buffer): Add xassert's for correspondence
7482 between IT's object being iterated and it->bidi_it.string
7484 (face_before_or_after_it_pos): Support bidi iteration.
7485 (next_element_from_c_string): Handle the case of the first string
7486 character that is not the first one in the visual order.
7487 (get_visually_first_element): New function, refactored from common
7488 parts of next_element_from_buffer, next_element_from_string, and
7489 next_element_from_c_string.
7490 (tool_bar_lines_needed, redisplay_tool_bar)
7491 (display_menu_bar): Force left-to-right direction. Add a FIXME
7492 comment for making that be controlled by a user option.
7493 (push_it, pop_it): Save and restore the state of the
7494 bidi iterator. Save and restore the bidi_p flag.
7495 (pop_it): Iterate out of display property for string iteration as
7497 (iterate_out_of_display_property): Support iteration over strings.
7498 (handle_single_display_spec): Set up it->bidi_it for iteration
7499 over a display string, and call bidi_init_it.
7500 (handle_single_display_spec, next_overlay_string)
7501 (get_overlay_strings_1, push_display_prop): Set up the bidi
7502 iterator for displaying display or overlay strings.
7503 (forward_to_next_line_start): Don't use the shortcut if
7505 (back_to_previous_visible_line_start): If handle_display_prop
7506 pushed the iterator stack, restore the internal state of the bidi
7507 iterator by calling bidi_pop_it same number of times.
7508 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
7509 and we are bidi-iterating, don't decrement the iterator position;
7510 instead, set the first_elt flag in the bidi iterator, to produce
7512 (reseat_1): Remove redundant setting of string_from_display_prop_p.
7513 (push_display_prop): xassert that we are iterating a buffer.
7514 (push_it, pop_it): Save and restore paragraph_embedding member.
7515 (handle_single_display_spec, next_overlay_string)
7516 (get_overlay_strings_1, reseat_1, reseat_to_string)
7517 (push_display_prop): Set up the `unibyte' member of bidi_it.string
7518 correctly. Don't assume unibyte strings are not bidi-reordered.
7519 (compute_display_string_pos)
7520 (compute_display_string_end): Fix handling the case of C string.
7521 (push_it, pop_it): Save and restore from_disp_prop_p.
7522 (handle_single_display_spec, push_display_prop): Set the
7523 from_disp_prop_p flag.
7524 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
7525 (pop_it): Call iterate_out_of_display_property only if we are
7526 popping after iteration over a string that came from a display
7527 property. Fix a typo in popping stretch info. Add an assertion
7528 for verifying that the iterator position is in sync with the bidi
7530 (handle_single_display_spec, get_overlay_strings_1)
7531 (push_display_prop): Fix initialization of paragraph direction for
7532 string when that of the parent object is not yet determined.
7533 (reseat_1): Call bidi_init_it to resync the bidi
7534 iterator with IT's position. (Bug#7616)
7535 (find_row_edges): If ROW->start.pos gives position
7536 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
7537 (handle_stop, back_to_previous_visible_line_start, reseat_1):
7538 Reset the from_disp_prop_p flag.
7539 (SAVE_IT, RESTORE_IT): New macros.
7540 (pos_visible_p, face_before_or_after_it_pos)
7541 (back_to_previous_visible_line_start)
7542 (move_it_in_display_line_to, move_it_in_display_line)
7543 (move_it_to, move_it_vertically_backward, move_it_by_lines)
7544 (try_scrolling, redisplay_window, display_line): Use them when
7545 saving a temporary copy of the iterator and restoring it back.
7546 (back_to_previous_visible_line_start, reseat_1)
7547 (init_iterator): Empty the bidi cache "stack".
7548 (move_it_in_display_line_to): If iterator ended up at
7549 EOL, but we never saw any buffer positions smaller than
7550 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
7551 motion in bidi-reordered lines.
7552 (move_it_in_display_line_to): Record prev_method and prev_pos
7553 immediately before the call to set_iterator_to_next. Fixes cursor
7554 motion in bidi-reordered lines with stretch glyphs and strings
7555 displayed in margins. (Bug#8133) (Bug#8867)
7556 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
7558 (pos_visible_p): Support positions in bidi-reordered lines.
7559 Save and restore bidi cache.
7561 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
7562 (bidi_paragraph_info): Delete unused struct.
7563 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
7564 (bidi_cache_start): New variable.
7565 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
7567 (bidi_cache_fetch_state, bidi_cache_search)
7568 (bidi_cache_find_level_change, bidi_cache_iterator_state)
7569 (bidi_cache_find, bidi_peek_at_next_level)
7570 (bidi_level_of_next_char, bidi_find_other_level_edge)
7571 (bidi_move_to_visually_next): Compare cache index with
7572 bidi_cache_start rather than with zero.
7573 (bidi_fetch_char): Accept new argument STRING; all callers
7574 changed. Support iteration over a string. Support strings with
7575 display properties. Support unibyte strings. Fix the type of
7576 `len' according to what STRING_CHAR_AND_LENGTH expects.
7577 (bidi_paragraph_init, bidi_resolve_explicit_1)
7578 (bidi_resolve_explicit, bidi_resolve_weak)
7579 (bidi_level_of_next_char, bidi_move_to_visually_next):
7580 Support iteration over a string.
7581 (bidi_set_sor_type, bidi_resolve_explicit_1)
7582 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
7583 can now be zero (for strings); special values 0 and -1 were
7584 changed to -1 and -2, respectively.
7585 (bidi_char_at_pos): New function.
7586 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
7587 Call it instead of FETCH_MULTIBYTE_CHAR.
7588 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
7589 initialized to valid values.
7590 (bidi_init_it): Don't initialize charpos and bytepos with invalid
7592 (bidi_level_of_next_char): Allow the sentinel "position" to pass
7593 the test for valid cached positions. Fix the logic for looking up
7594 the sentinel state in the cache. GCPRO the Lisp string we are
7596 (bidi_push_it, bidi_pop_it): New functions.
7597 (bidi_initialize): Initialize the bidi cache start stack pointer.
7598 (bidi_cache_ensure_space): New function, refactored from part of
7599 bidi_cache_iterator_state. Don't assume the required size is just
7600 one BIDI_CACHE_CHUNK away.
7601 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
7602 (bidi_count_bytes, bidi_char_at_pos): New functions.
7603 (bidi_cache_search): Don't assume bidi_cache_last_idx is
7604 always valid if bidi_cache_idx is valid.
7605 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
7606 is valid if it's going to be used.
7607 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
7608 (bidi_cache_fetch_state, bidi_cache_search)
7609 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7610 (bidi_cache_iterator_state, bidi_cache_find)
7611 (bidi_find_other_level_edge, bidi_cache_start_stack):
7612 All variables related to cache indices are now EMACS_INT.
7614 * dispextern.h (struct bidi_string_data): New structure.
7615 (struct bidi_it): New member `string'. Make flag members be 1-bit
7616 fields, and put them last in the struct.
7617 (compute_display_string_pos, compute_display_string_end):
7619 (bidi_push_it, bidi_pop_it): Add prototypes.
7620 (struct iterator_stack_entry): New members bidi_p,
7621 paragraph_embedding, and from_disp_prop_p.
7622 (struct it): Member bidi_p is now a bit field 1 bit wide.
7623 (bidi_shelve_cache, bidi_unshelve_cache):
7626 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
7627 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
7628 and vector-like objects.
7630 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
7631 cache around display iteration.
7633 * window.c (Fwindow_end, window_scroll_pixel_based)
7634 (displayed_window_lines, Frecenter): Save and restore the bidi
7635 cache around display iteration.
7637 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7639 * editfns.c (Fdelete_region): Clarify the use of the named
7640 parameters (bug#6788).
7642 2011-07-14 Martin Rudalics <rudalics@gmx.at>
7644 * indent.c (Fvertical_motion): Set and restore w->pointm when
7645 saving and restoring the window's buffer (Bug#9006).
7647 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
7649 * editfns.c (Fstring_to_char): Clarify just what is returned
7650 (bug#6576). Text by Eli Zaretskii.
7652 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
7654 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
7656 2011-07-13 Eli Zaretskii <eliz@gnu.org>
7658 * buffer.c (mmap_find): Fix a typo.
7660 2011-07-13 Johan Bockgård <bojohan@gnu.org>
7662 Fix execution of x selection hooks.
7663 * xselect.c (Qx_lost_selection_functions)
7664 (Qx_sent_selection_functions): New vars.
7665 (syms_of_xselect): DEFSYM them.
7666 (x_handle_selection_request): Pass Qx_sent_selection_functions
7667 rather than Vx_sent_selection_functions to Frun_hook_with_args.
7668 (x_handle_selection_clear,x_clear_frame_selections):
7669 Pass Qx_lost_selection_functions rather than
7670 Vx_lost_selection_functions to Frun_hook_with_args.
7672 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
7674 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
7675 The old code sometimes used this field without initializing it.
7677 * alloc.c (gc_sweep): Don't read past end of array.
7678 In theory, the old code could also have corrupted Emacs internals,
7679 though it'd be very unlikely.
7681 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
7683 * character.c (Fcharacterp): Don't advertise optional ignored
7684 argument. (Bug#4026)
7686 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
7688 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
7691 * window.c (Fset_window_start): Doc fix (bug#4199).
7692 (Fset_window_hscroll): Ditto.
7694 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
7696 Fix minor new problems caught by GCC 4.6.1.
7697 * term.c (init_tty): Remove unused local.
7698 * xsettings.c (store_monospaced_changed): Define this function only
7699 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
7702 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
7704 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
7706 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7708 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
7709 are the mini-buffer and the echo area (bug#3320).
7711 * term.c (init_tty): Remove support for supdup, c10 and perq
7712 terminals, which are no longer supported (bug#1482).
7714 2011-07-10 Johan Bockgård <bojohan@gnu.org>
7716 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
7718 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
7720 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
7721 for non-popups (Bug#3642).
7723 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
7725 * alloc.c (reset_malloc_hooks): Protoize.
7726 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
7727 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
7728 * cm.c (losecursor): Likewise.
7729 * data.c (fmod): Likewise.
7730 * dispnew.c (swap_glyphs_in_rows): Likewise.
7731 * emacs.c (memory_warning_signal): Likewise.
7732 * floatfns.c (float_error): Likewise.
7733 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
7734 (otf_open, font_otf_capability, generate_otf_features)
7735 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
7737 * image.c (pbm_read_file): Likewise.
7738 * indent.c (string_display_width): Likewise.
7739 * intervals.c (check_for_interval, search_for_interval)
7740 (inc_interval_count, count_intervals, root_interval)
7741 (adjust_intervals_for_insertion, make_new_interval): Likewise.
7742 * lread.c (defalias): Likewise.
7743 * ralloc.c (r_alloc_check): Likewise.
7744 * regex.c (set_image_of_range_1, set_image_of_range)
7745 (regex_grow_registers): Likewise.
7746 * sysdep.c (strerror): Likewise.
7747 * termcap.c (valid_filename_p, tprint, main): Likewise.
7748 * tparam.c (main): Likewise.
7749 * unexhp9k800.c (run_time_remap, save_data_space)
7750 (update_file_ptrs, read_header, write_header, calculate_checksum)
7751 (copy_file, copy_rest, display_header): Likewise.
7752 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
7754 * xdisp.c (check_it): Likewise.
7755 * xfaces.c (register_color, unregister_color, unregister_colors):
7757 * xfns.c (print_fontset_result): Likewise.
7758 * xrdb.c (member, fatal, main): Likewise.
7760 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
7762 Fix minor problems found by static checking (Bug#9031).
7763 * chartab.c (char_table_set_range, map_sub_char_table):
7764 Remove unused locals.
7765 (uniprop_table): Now static.
7766 * composite.c (_work_char): Remove unused static var.
7768 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
7770 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
7772 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
7774 * gtkutil.c (qttip_cb): Remove code without function.
7776 2011-07-09 Eli Zaretskii <eliz@gnu.org>
7778 * w32.c (pthread_sigmask): New stub.
7780 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
7782 Use pthread_sigmask, not sigprocmask (Bug#9010).
7783 sigprocmask is portable only for single-threaded applications, and
7784 Emacs can be multi-threaded when it uses GTK.
7785 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
7787 * callproc.c (Fcall_process):
7788 * process.c (create_process):
7789 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
7790 Use pthread_sigmask, not sigprocmask.
7792 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7794 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
7795 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
7798 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7800 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
7801 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
7802 (xg_hide_tooltip): Fix comment.
7804 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
7805 in registerServicesMenuSendTypes.
7806 (validRequestorForSendType): Don't check ns_return_types.
7808 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
7811 2011-07-08 Jason Rumney <jasonr@gnu.org>
7813 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
7814 SH_SHOW for hidden windows (Bug#5482).
7816 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
7817 frame struct members of non-existent frames (Bug#6284).
7819 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7821 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
7822 variable firstTime not needed on OSX >= 10.6.
7823 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
7824 >= 10.5. Use setKnobProportion, setDoubleValue.
7826 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
7827 (MAC_OS_X_VERSION_10_5): Define if not defined.
7828 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
7829 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
7830 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
7832 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
7833 cString and lossyCString on OSX >= 10.4.
7835 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
7836 sizeToFit on OSX >= 10.2.
7838 * nsimage.m (allocInitFromFile): Don't use deprecated method
7839 bestRepresentationForDevice on OSX >= 10.6.
7841 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
7844 * emacs.c: Declare unexec_init_emacs_zone.
7846 * nsgui.h: Fix compiler warning about gnulib redefining verify.
7848 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
7850 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
7851 on svcsMenu (Bug#8842).
7853 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
7855 (Fns_list_services): Just return Qnil on 10.6, code not working there.
7857 * nsterm.m (QUTF8_STRING): Declare.
7858 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
7859 (validRequestorForSendType): Return type is (id).
7860 Change indexOfObjectIdenticalTo to indexOfObject.
7861 Check if we have local selection before returning self (Bug#8842).
7862 (writeSelectionToPasteboard): Put local selection into paste board
7863 if we have a local selection (Bug#8842).
7864 (syms_of_nsterm): DEFSYM QUTF8_STRING.
7866 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
7867 (ns_get_local_selection): Declare.
7869 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
7871 * keymap.c (describe_map_tree): Don't insert a double newline at
7872 the end of the buffer (bug#1169) and return whether we inserted
7875 * callint.c (Fcall_interactively): Change "reading args" to
7876 "providing args" to try to clarify what it does (bug#1010).
7878 2011-07-07 Kenichi Handa <handa@m17n.org>
7880 * composite.c (composition_compute_stop_pos): Ignore a static
7881 composition starting before CHARPOS (Bug#8915).
7883 * xdisp.c (handle_composition_prop): Likewise.
7885 2011-07-07 Eli Zaretskii <eliz@gnu.org>
7887 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
7890 2011-07-07 Kenichi Handa <handa@m17n.org>
7892 * character.h (unicode_category_t): New enum type.
7894 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
7895 (Qchar_code_property_table): New variable.
7896 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
7897 (UNIPROP_COMPRESSED_FORM_P): New macros.
7898 (char_table_ascii): Uncompress the compressed values.
7899 (sub_char_table_ref): New arg is_uniprop. Callers changed.
7900 Uncompress the compressed values.
7901 (sub_char_table_ref_and_range): Likewise.
7902 (char_table_ref_and_range): Uncompress the compressed values.
7903 (sub_char_table_set): New arg is_uniprop. Callers changed.
7904 Uncompress the compressed values.
7905 (sub_char_table_set_range): Args changed. Callers changed.
7906 (char_table_set_range): Adjuted for the above change.
7907 (map_sub_char_table): Delete args default_val and parent. Add arg
7908 top. Give decoded values to a Lisp function.
7909 (map_char_table): Adjust for the above change. Give decoded
7910 values to a Lisp function. Gcpro more variables.
7911 (uniprop_table_uncompress)
7912 (uniprop_decode_value_run_length): New functions.
7913 (uniprop_decoder, uniprop_decoder_count): New variables.
7914 (uniprop_get_decoder, uniprop_encode_value_character)
7915 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
7917 (uniprop_encoder, uniprop_encoder_count): New variables.
7918 (uniprop_get_encoder, uniprop_table)
7919 (Funicode_property_table_internal, Fget_unicode_property_internal)
7920 (Fput_unicode_property_internal): New functions.
7921 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
7922 Sunicode_property_table_internal, Sget_unicode_property_internal,
7923 and Sput_unicode_property_internal. Defvar_lisp
7924 char-code-property-alist.
7926 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
7927 Vunicode_category_table.
7929 * font.c (font_range): Adjust for the change of
7930 Vunicode_category_table.
7932 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
7934 * m/iris4d.h: Remove file, move contents ...
7935 * s/irix6-5.h: ... here.
7937 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
7939 Remove unportable assumption about struct layout (Bug#8884).
7940 * alloc.c (mark_buffer):
7941 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
7942 (clone_per_buffer_values): Don't assume that
7943 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
7944 This isn't true in general, and it's particularly not true
7945 if Emacs is configured with --with-wide-int.
7946 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
7947 New macros, used in the buffer.c change.
7949 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
7951 * xsettings.c: Use both GConf and GSettings if both are available.
7952 (store_config_changed_event): Add comment.
7953 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
7954 (store_tool_bar_style_changed): New functions.
7955 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
7956 (struct xsettings): Move font inside HAVE_XFT.
7957 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
7958 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
7959 Move inside HAVE_XFT.
7960 (something_changed_gsettingsCB): Rename from something_changedCB.
7961 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
7963 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
7964 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
7965 (something_changed_gconfCB): Rename from something_changedCB.
7966 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
7967 (parse_settings): Move check for font inside HAVE_XFT.
7968 (read_settings, apply_xft_settings): Add comment.
7969 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
7970 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
7971 call store_font_name_changed.
7972 (xft_settings_event): Add comment.
7973 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
7974 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
7975 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
7976 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
7977 (xsettings_initialize): Call init_gsettings last.
7978 (xsettings_get_system_font, xsettings_get_system_normal_font):
7981 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
7983 Random fixes. E.g., (random) never returned negative values.
7984 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
7985 subseconds part to the entropy, as that's a bit more random.
7986 Prefer signed to unsigned, since the signedness doesn't matter and
7987 in general we prefer signed. When given a limit, use a
7988 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
7989 latter isn't right if USE_2_TAGS_FOR_INTS.
7990 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
7991 not 0..VALMASK. Don't discard "excess" bits that random () returns.
7993 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
7995 * textprop.c (text_property_stickiness):
7996 Obey Vtext_property_default_nonsticky.
7997 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
7998 * w32fns.c (syms_of_w32fns):
7999 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
8001 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8003 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
8004 This is more efficient than Ffile_directory_p and avoids a minor race.
8006 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
8008 * buffer.c (Foverlay_put): Say what the return value is
8011 * fileio.c (barf_or_query_if_file_exists): Check first if the file
8012 is a directory before asking whether to use the file name
8014 (barf_or_query_if_file_exists): Make the "File is a directory"
8015 error be more correct.
8017 * fns.c (Frequire): Remove the mention of the .gz files, since
8018 that's installation-specific, but keep the mention of
8019 `get-load-suffixes'.
8021 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
8023 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
8024 Report string overflow if the output is too long.
8026 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
8028 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
8029 (syms_of_gnutls): Remove duplicate DEFSYM for
8030 Qgnutls_bootprop_verify_hostname_error, an error for
8031 Qgnutls_bootprop_verify_error (which is no longer used).
8033 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
8034 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
8035 Also (re)move comments that are misplaced or no longer relevant.
8037 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8039 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
8041 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
8043 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
8044 and background color parameters if they have been changed.
8046 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8048 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
8050 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
8052 * xsettings.c (SYSTEM_FONT): Define only when used.
8053 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
8055 * keymap.c (access_keymap_1): Now static.
8057 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
8059 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
8060 leave any prefix arg for the up event (Bug#1586).
8062 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
8064 * lread.c (syms_of_lread): Mention single symbols defined by
8065 `defvar' or `defconst' (bug#7154).
8067 * fns.c (Frequire): Mention .el.gz files (bug#7314).
8068 (Frequire): Mention get-load-suffixes.
8070 2011-07-02 Martin Rudalics <rudalics@gmx.at>
8072 * window.h (window): Remove clone_number slot.
8073 * window.c (Fwindow_clone_number, Fset_window_clone_number):
8075 (make_parent_window, make_window, saved_window)
8076 (Fset_window_configuration, save_window_save): Don't deal with
8078 * buffer.c (Qclone_number): Remove declaration.
8079 (sort_overlays, overlay_strings): Don't deal with clone numbers.
8081 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
8083 Add multiple inheritance to keymaps.
8084 * keymap.c (Fmake_composed_keymap): New function.
8085 (Fset_keymap_parent): Simplify.
8086 (fix_submap_inheritance): Remove.
8087 (access_keymap_1): New function extracted from access_keymap to handle
8088 embedded parents and handle lists of maps.
8089 (access_keymap): Use it.
8090 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
8091 (Fcopy_keymap): Handle embedded parents.
8092 (Fcommand_remapping, define_as_prefix): Simplify.
8093 (Fkey_binding): Simplify.
8094 (syms_of_keymap): Move minibuffer-local-completion-map,
8095 minibuffer-local-filename-completion-map,
8096 minibuffer-local-must-match-map, and
8097 minibuffer-local-filename-must-match-map to Elisp.
8098 (syms_of_keymap): Defsubr make-composed-keymap.
8099 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
8100 (parse_menu_item): Trivial simplification.
8102 2011-07-01 Glenn Morris <rgm@gnu.org>
8104 * Makefile.in (SETTINGS_LIBS): Fix typo.
8106 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
8108 * coding.c (Fencode_coding_string): Record the last coding system
8109 used, as the function doc string says (bug#8738).
8111 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
8113 * xsettings.c (store_monospaced_changed): Take new font as arg and
8114 check for change against current_mono_font.
8115 (EMACS_TYPE_SETTINGS): Remove this and related defines.
8116 (emacs_settings_constructor, emacs_settings_get_property)
8117 (emacs_settings_set_property, emacs_settings_class_init)
8118 (emacs_settings_init, gsettings_obj): Remove.
8119 (something_changedCB): New function for HAVE_GSETTINGS.
8120 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
8121 with value as argument.
8122 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
8123 g_settings_new (Bug#8967). Do not create gsettings_obj.
8124 Remove calls to g_settings_bind. Connect something_changedCB to
8127 * xgselect.c: Add defined (HAVE_GSETTINGS).
8128 (xgselect_initialize): Ditto.
8130 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
8131 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
8134 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
8136 * eval.c (struct backtrace): Simplify and port the data structure.
8137 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
8138 signed bit field, as this assumption is not portable and it makes
8139 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
8140 "char debug_on_exit : 1" as this is not portable either; instead,
8141 use the portable "unsigned int debug_on_exit : 1". Remove unused
8142 member evalargs. Remove obsolete comments about cc bombing out.
8144 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
8146 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
8147 Let HAVE_GSETTINGS override HAVE_GCONF.
8148 (store_monospaced_changed): New function.
8149 (EMACS_SETTINGS): A new type derived from GObject to handle
8150 GSettings notifications.
8151 (emacs_settings_constructor, emacs_settings_get_property)
8152 (emacs_settings_set_property, emacs_settings_class_init):
8154 (gsettings_client, gsettings_obj): New variables.
8155 (GSETTINGS_SCHEMA): New define.
8156 (something_changedCB): Call store_monospaced_changed.
8157 (init_gsettings): New function.
8158 (xsettings_initialize): Call init_gsettings.
8159 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
8162 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
8165 2011-06-29 Martin Rudalics <rudalics@gmx.at>
8167 * window.c (resize_root_window, grow_mini_window)
8168 (shrink_mini_window): Rename Qresize_root_window to
8169 Qwindow_resize_root_window and Qresize_root_window_vertically to
8170 Qwindow_resize_root_window_vertically.
8172 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
8174 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
8176 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
8178 * makefile.w32-in: Redesign dependencies so they reflect more
8179 clearly which files are directly included by each source file,
8180 and not through other includes.
8182 2011-06-27 Martin Rudalics <rudalics@gmx.at>
8184 * buffer.c (Qclone_number): Declare static and DEFSYM it.
8185 (sort_overlays, overlay_strings): When an overlay's clone number
8186 matches the window's clone number process the overlay even if
8187 the overlay's window property doesn't match the current window.
8189 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
8190 (Fwindow_hchild): Rename to Fwindow_left_child.
8191 (Fwindow_next): Rename to Fwindow_next_sibling.
8192 (Fwindow_prev): Rename to Fwindow_prev_sibling.
8193 (resize_window_check): Rename to window_resize_check.
8194 (resize_window_apply): Rename to window_resize_apply.
8195 (Fresize_window_apply): Rename to Fwindow_resize_apply.
8196 (Fdelete_other_windows_internal, resize_frame_windows)
8197 (Fsplit_window_internal, Fdelete_window_internal)
8198 (grow_mini_window, shrink_mini_window)
8199 (Fresize_mini_window_internal): Fix callers accordingly.
8201 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
8203 * emacsgtkfixed.h: State that this is only used with Gtk+3.
8204 (emacs_fixed_set_min_size): Remove.
8205 (emacs_fixed_new): Take frame as argument.
8207 * emacsgtkfixed.c: State that this is only used with Gtk+3.
8208 (_EmacsFixedPrivate): Remove minwidth/height.
8209 Add struct frame *f.
8210 (emacs_fixed_init): Initialize priv->f.
8211 (get_parent_class, emacs_fixed_set_min_size): Remove.
8212 (emacs_fixed_new): Set priv->f to argument.
8213 (emacs_fixed_get_preferred_width)
8214 (emacs_fixed_get_preferred_height): Use min_width/height from
8215 frames size_hint to set minimum and natural (Bug#8919).
8216 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
8217 and use min_width/height from frames size_hint to set
8218 min_width/height (Bug#8919).
8220 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
8221 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
8224 2011-06-26 Eli Zaretskii <eliz@gnu.org>
8226 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
8227 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
8230 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
8232 * process.c (wait_reading_process_output): Bypass select if
8233 waiting for a cell while ignoring keyboard input, and input is
8234 pending. Suggested by Jan Djärv (Bug#8869).
8236 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
8238 Use gnulib's dup2 module instead of rolling our own.
8239 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
8241 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8243 * dispnew.c (scrolling_window): Before scrolling, turn off a
8244 mouse-highlight in the window being scrolled.
8246 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
8248 Move DEFSYM to lisp.h and use everywhere.
8250 * character.h (DEFSYM): Move declaration...
8251 * lisp.h (DEFSYM): ...here.
8257 * w32select.c: Don't include character.h.
8259 * alloc.c (syms_of_alloc):
8260 * buffer.c (syms_of_buffer):
8261 * bytecode.c (syms_of_bytecode):
8262 * callint.c (syms_of_callint):
8263 * casefiddle.c (syms_of_casefiddle):
8264 * casetab.c (init_casetab_once):
8265 * category.c (init_category_once, syms_of_category):
8266 * ccl.c (syms_of_ccl):
8267 * cmds.c (syms_of_cmds):
8268 * composite.c (syms_of_composite):
8269 * dbusbind.c (syms_of_dbusbind):
8270 * dired.c (syms_of_dired):
8271 * dispnew.c (syms_of_display):
8272 * doc.c (syms_of_doc):
8273 * editfns.c (syms_of_editfns):
8274 * emacs.c (syms_of_emacs):
8275 * eval.c (syms_of_eval):
8276 * fileio.c (syms_of_fileio):
8277 * fns.c (syms_of_fns):
8278 * frame.c (syms_of_frame):
8279 * fringe.c (syms_of_fringe):
8280 * insdel.c (syms_of_insdel):
8281 * keymap.c (syms_of_keymap):
8282 * lread.c (init_obarray, syms_of_lread):
8283 * macros.c (syms_of_macros):
8284 * msdos.c (syms_of_msdos):
8285 * print.c (syms_of_print):
8286 * process.c (syms_of_process):
8287 * search.c (syms_of_search):
8288 * sound.c (syms_of_sound):
8289 * syntax.c (init_syntax_once, syms_of_syntax):
8290 * terminal.c (syms_of_terminal):
8291 * textprop.c (syms_of_textprop):
8292 * undo.c (syms_of_undo):
8293 * w32.c (globals_of_w32):
8294 * window.c (syms_of_window):
8295 * xdisp.c (syms_of_xdisp):
8296 * xfaces.c (syms_of_xfaces):
8297 * xfns.c (syms_of_xfns):
8298 * xmenu.c (syms_of_xmenu):
8299 * xsettings.c (syms_of_xsettings):
8300 * xterm.c (syms_of_xterm): Use DEFSYM.
8302 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
8304 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
8306 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
8308 Integer and buffer overflow fixes (Bug#8873).
8310 * print.c (printchar, strout): Check for string overflow.
8311 (PRINTPREPARE, printchar, strout):
8312 Don't set size unless allocation succeeds.
8314 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
8315 for sizes. Check for string overflow more accurately.
8316 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
8318 * macros.c: Integer and buffer overflow fixes.
8319 * keyboard.h (struct keyboard.kbd_macro_bufsize):
8320 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
8321 Use ptrdiff_t, not int, for sizes.
8322 Don't increment bufsize until after realloc succeeds.
8323 Check for size-calculation overflow.
8324 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
8326 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
8328 * lread.c: Integer overflow fixes.
8329 (read_integer): Radix is now EMACS_INT, not int,
8330 to improve quality of diagnostics for out-of-range radices.
8331 Calculate buffer size correctly for out-of-range radices.
8332 (read1): Check for integer overflow in radices, and in
8333 read-circle numbers.
8334 (read_escape): Avoid int overflow.
8335 (Fload, openp, read_buffer_size, read1)
8336 (substitute_object_recurse, read_vector, read_list, map_obarray):
8337 Use ptrdiff_t, not int, for sizes.
8338 (read1): Use EMACS_INT, not int, for sizes.
8339 Check for size overflow.
8341 * image.c (cache_image): Check for size arithmetic overflow.
8343 * lread.c: Integer overflow issues.
8344 (saved_doc_string_size, saved_doc_string_length)
8345 (prev_saved_doc_string_size, prev_saved_doc_string_length):
8346 Now ptrdiff_t, not int.
8347 (read1): Don't assume doc string length fits in int. Check for
8348 out-of-range doc string lengths.
8349 (read_list): Don't assume file position fits in int.
8350 (read_escape): Check for hex character overflow.
8352 2011-06-22 Leo Liu <sdl.web@gmail.com>
8354 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
8355 Move to minibuffer.el.
8357 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8359 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
8360 The following patches are for when GLYPH_DEBUG && !XASSERT.
8361 * dispextern.h (trace_redisplay_p, dump_glyph_string):
8362 * dispnew.c (flush_stdout):
8363 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
8364 Mark as externally visible.
8365 * dispnew.c (check_window_matrix_pointers): Now static.
8366 * dispnew.c (window_to_frame_vpos):
8367 * xfns.c (unwind_create_frame):
8368 * xterm.c (x_check_font): Remove unused local.
8369 * scroll.c (CHECK_BOUNDS):
8370 * xfaces.c (cache_fache): Rename local to avoid shadowing.
8371 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
8372 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
8373 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
8374 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
8376 (debug_method_add): Use va_list and vsprintf rather than relying
8377 on undefined behavior with wrong number of arguments.
8378 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
8379 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
8380 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
8381 since we're not interested in debugging glyphs with old libraries.
8382 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
8383 GCC 4.6.0's static checking.
8385 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8387 Integer overflow and signedness fixes (Bug#8873).
8388 A few related buffer overrun fixes, too.
8390 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
8392 * dispextern.h (struct face.stipple):
8393 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
8394 (x_bitmap_mask, x_allocate_bitmap_record)
8395 (x_create_bitmap_from_data, x_create_bitmap_from_file)
8396 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
8397 (x_create_bitmap_from_xpm_data):
8398 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
8399 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
8401 * xfaces.c (load_pixmap):
8402 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
8403 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
8404 (.bitmaps_last, struct x_output.icon_bitmap):
8405 Use ptrdiff_t, not int, for bitmap indexes.
8406 (x_allocate_bitmap_record): Check for size overflow.
8407 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
8409 Use ptrdiff_t, not int, for overlay counts.
8410 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
8411 * editfns.c (overlays_around, get_pos_property):
8412 * textprop.c (get_char_property_and_overlay):
8413 * xdisp.c (next_overlay_change, note_mouse_highlight):
8414 * xfaces.c (face_at_buffer_position):
8415 * buffer.c (OVERLAY_COUNT_MAX): New macro.
8416 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
8417 (Fnext_overlay_change, Fprevious_overlay_change)
8418 (mouse_face_overlay_overlaps, Foverlays_in):
8419 Use ptrdiff_t, not int, for sizes.
8420 (overlays_at, overlays_in): Check for size-calculation overflow.
8422 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
8424 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
8425 (x_session_initialize): Do not assume string length fits in int.
8427 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
8428 This is unlikely, but can occur if DPI is outlandish.
8430 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
8431 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
8433 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
8434 * xrdb.c (magic_file_p, search_magic_path):
8435 Omit last arg SUFFIX; it was always 0. All callers changed.
8436 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
8438 * xfont.c (xfont_match): Avoid need for strlen.
8440 * xfns.c: Don't assume strlen fits in int.
8441 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
8443 * xdisp.c (message_log_check_duplicate): Return intmax_t,
8444 not unsigned long, as we prefer signed integers. All callers changed.
8445 Detect integer overflow in repeat count.
8446 (message_dolog): Don't assume print length fits in 39 bytes.
8447 (display_mode_element): Don't assume strlen fits in int.
8449 * termcap.c: Don't assume sizes fit in int and never overflow.
8450 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
8451 (gobble_line): Check for size-calculation overflow.
8453 * minibuf.c (Fread_buffer):
8454 * lread.c (intern, intern_c_string):
8455 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
8456 Don't assume string length fits in int.
8458 * keyboard.c (parse_tool_bar_item):
8459 * gtkutil.c (style_changed_cb): Avoid need for strlen.
8461 * font.c: Don't assume string length fits in int.
8462 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
8463 Use ptrdiff_t, not int.
8464 (font_intern_prop): Don't assume string length fits in int.
8465 Don't assume integer property fits in fixnum.
8466 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
8468 * filelock.c: Fix some buffer overrun and integer overflow issues.
8469 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
8470 Reformulate so as not to need the command string.
8471 Invoke gzip -cd rather than gunzip, as it's more portable.
8472 (lock_info_type, lock_file_1, lock_file):
8473 Don't assume pid_t and time_t fit in unsigned long.
8474 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
8475 (current_lock_owner): Prefer signed type for sizes.
8476 Use memcpy, not strncpy, where memcpy is what is really wanted.
8477 Don't assume (via atoi) that time_t and pid_t fit in int.
8478 Check for time_t and/or pid_t out of range, e.g., via a network share.
8479 Don't alloca where an auto var works fine.
8481 * fileio.c: Fix some integer overflow issues.
8482 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
8483 Don't assume string length fits in int.
8484 (directory_file_name): Don't assume string length fits in long.
8485 (make_temp_name): Don't assume pid fits in int, or that its print
8486 length is less than 20.
8488 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
8490 * coding.c (make_subsidiaries): Don't assume string length fits in int.
8492 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
8494 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
8495 We prefer signed integers, even for size calculations.
8497 * emacs.c: Don't assume string length fits in 'int'.
8498 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
8499 (main): Don't invoke strlen when not needed.
8501 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
8502 (XD_DEBUG_MESSAGE): Don't waste a byte.
8504 * callproc.c (getenv_internal_1, getenv_internal)
8506 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
8508 * lread.c (invalid_syntax): Omit length argument.
8509 All uses changed. This doesn't fix a bug, but it simplifies the
8510 code away from its former Hollerith-constant appearance, and it's
8511 one less 'int' to worry about when looking at integer-overflow issues.
8512 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
8514 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
8515 This didn't break anything, but it didn't help either.
8516 It's confusing to put a bogus integer in a place where the actual
8517 value does not matter.
8518 (LIST_END_P): Remove unused macro and its bogus comment.
8519 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
8521 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
8522 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
8524 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
8525 We prefer signed types, and the value cannot exceed the EMACS_INT
8526 range anyway (because otherwise the length would not be representable).
8527 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
8528 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
8529 This avoids a GCC warning when WIDE_EMACS_INT.
8531 * indent.c (sane_tab_width): New function.
8532 (current_column, scan_for_column, Findent_to, position_indentation)
8533 (compute_motion): Use it. This is just for clarity.
8534 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
8536 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
8538 * lisp.h (lint_assume): New macro.
8539 * composite.c (composition_gstring_put_cache):
8540 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
8542 * editfns.c, insdel.c:
8543 Omit unnecessary forward decls, to simplify future changes.
8545 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
8547 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
8549 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
8550 Use much-faster test for byte-length change.
8551 Don't assume string byte-length fits in 'int'.
8552 Check that character arg fits in 'int'.
8553 (mapcar1): Declare byte as byte, for clarity.
8555 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
8557 * fns.c (concat): Catch string overflow earlier.
8558 Do not rely on integer wraparound.
8560 * dispextern.h (struct it.overlay_strings_charpos)
8561 (struct it.selective): Now EMACS_INT, not int.
8562 * xdisp.c (forward_to_next_line_start)
8563 (back_to_previous_visible_line_start)
8564 (reseat_at_next_visible_line_start, next_element_from_buffer):
8565 Don't arbitrarily truncate the value of 'selective' to int.
8567 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
8569 * composite.c: Don't truncate sizes to 'int'.
8570 (composition_gstring_p, composition_reseat_it)
8571 (composition_adjust_point): Use EMACS_INT, not int.
8572 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
8573 not EMACS_UINT, for indexes.
8575 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
8577 * buffer.c: Include <verify.h>.
8578 (struct sortvec.priority, struct sortstr.priority):
8579 Now EMACS_INT, not int.
8580 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
8581 (struct sortstr.size, record_overlay_string)
8582 (struct sortstrlist.size, struct sortlist.used):
8583 Don't truncate size to int.
8584 (record_overlay_string): Check for size-calculation overflow.
8585 (init_buffer_once): Check at compile-time, not run-time.
8587 2011-06-22 Jim Meyering <meyering@redhat.com>
8589 Don't leak an XBM-image-sized buffer
8590 * image.c (xbm_load): Free the image buffer after using it.
8592 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
8595 * composite.c (find_automatic_composition): Omit needless 'return 0;'
8596 that Sun C diagnosed.
8597 * fns.c (secure_hash): Fix pointer signedness issue.
8598 * intervals.c (static_offset_intervals): New function.
8599 (offset_intervals): Use it.
8601 2011-06-21 Leo Liu <sdl.web@gmail.com>
8604 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
8607 * fns.c (secure_hash): Rename from crypto_hash_function and change
8608 the first arg to accept symbols.
8609 (Fsecure_hash): New primitive.
8610 (syms_of_fns): New symbols.
8612 2011-06-20 Deniz Dogan <deniz@dogan.se>
8614 * process.c (Fset_process_buffer): Clarify return value in
8617 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
8619 * dispnew.c (add_window_display_history): Use BVAR.
8621 * xdisp.c (debug_method_add): Use BVAR.
8622 (check_window_end, dump_glyph_matrix, dump_glyph)
8623 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
8625 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
8628 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
8629 check till after the cache is created in init_frame_faces.
8631 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
8633 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
8635 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
8637 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
8638 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
8639 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
8641 Improve buffer-overflow checking (Bug#8873).
8642 * fileio.c (Finsert_file_contents):
8643 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
8644 Remove the old (too-loose) buffer overflow checks.
8645 They weren't needed, since make_gap checks for buffer overflow.
8646 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
8647 The old code merely checked for Emacs fixnum overflow, and relied
8648 on undefined (wraparound) behavior. The new code avoids undefined
8649 behavior, and also checks for ptrdiff_t and/or size_t overflow.
8651 * editfns.c (Finsert_char): Don't dump core with very negative counts.
8652 Tune. Don't use wider integers than needed. Don't use alloca.
8653 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
8655 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
8657 * insdel.c, lisp.h (buffer_overflow): New function.
8658 (insert_from_buffer_1, replace_range, replace_range_2):
8659 * insdel.c (make_gap_larger):
8660 * editfns.c (Finsert_char):
8661 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
8663 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
8665 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
8667 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
8669 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
8670 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
8672 * fileio.c: Don't assume EMACS_INT fits in off_t.
8673 (emacs_lseek): New static function.
8674 (Finsert_file_contents, Fwrite_region): Use it.
8675 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
8677 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
8679 * fns.c: Don't overflow int when computing a list length.
8680 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
8681 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
8682 truncation on 64-bit hosts. Check for QUIT every
8683 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
8684 faster and is responsive enough.
8685 (Flength): Report an error instead of overflowing an integer.
8686 (Fsafe_length): Return a float if the value is not representable
8687 as a fixnum. This shouldn't happen except in contrived situations.
8688 (Fnthcdr, Fsort): Don't assume list length fits in int.
8689 (Fcopy_sequence): Don't assume vector length fits in int.
8691 * alloc.c: Check that resized vectors' lengths fit in fixnums.
8692 (header_size, word_size): New constants.
8693 (allocate_vectorlike): Don't check size overflow here.
8694 (allocate_vector): Check it here instead, since this is the only
8695 caller of allocate_vectorlike that could cause overflow.
8696 Check that the new vector's length is representable as a fixnum.
8698 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
8699 The previous code was bogus. For example, next_almost_prime (32)
8700 returned 39, which is undesirable as it is a multiple of 3; and
8701 next_almost_prime (24) returned 25, which is a multiple of 5 so
8702 why was the code bothering to check for multiples of 7?
8704 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
8706 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
8708 Variadic C functions now count arguments with ptrdiff_t.
8709 This partly undoes my 2011-03-30 change, which replaced int with size_t.
8710 Back then I didn't know that the Emacs coding style prefers signed int.
8711 Also, in the meantime I found a few more instances where arguments
8712 were being counted with int, which may truncate counts on 64-bit
8713 machines, or EMACS_INT, which may be unnecessarily wide.
8714 * lisp.h (struct Lisp_Subr.function.aMANY)
8715 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
8716 Arg counts are now ptrdiff_t, not size_t.
8717 All variadic functions and their callers changed accordingly.
8718 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
8719 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
8720 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
8721 * callint.c (Fcall_interactively): Check arg count for overflow,
8722 to avoid potential buffer overrun. Use signed char, not 'int',
8723 for 'varies' array, so that we needn't bother to check its size
8724 calculation for overflow.
8725 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
8726 * eval.c (apply_lambda):
8727 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
8728 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
8729 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
8731 * callint.c (Fcall_interactively): Don't use index var as event count.
8733 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
8734 * mem-limits.h (SIZE): Remove; no longer used.
8736 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
8738 Remove unnecessary casts.
8739 * xterm.c (x_term_init):
8740 * xfns.c (x_set_border_pixel):
8741 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
8742 These aren't needed now that we assume ANSI C.
8744 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
8745 It's more likely to cause problems (due to unsigned overflow)
8748 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
8750 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
8752 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
8754 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
8756 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
8758 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
8760 GLYPH_CODE_FACE returns EMACS_INT, not int.
8761 * dispextern.h (merge_faces):
8762 * xfaces.c (merge_faces):
8763 * xdisp.c (get_next_display_element, next_element_from_display_vector):
8764 Don't assume EMACS_INT fits in int.
8766 * character.h (CHAR_VALID_P): Remove unused parameter.
8767 * fontset.c, lisp.h, xdisp.c: All uses changed.
8769 * editfns.c (Ftranslate_region_internal): Omit redundant test.
8771 * fns.c (concat): Minor tuning based on overflow analysis.
8772 This doesn't fix any bugs. Use int to hold character, instead
8773 of constantly refetching from Emacs object. Use XFASTINT, not
8774 XINT, for value known to be a character. Don't bother comparing
8775 a single byte to 0400, as it's always less.
8777 * floatfns.c (Fexpt):
8778 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
8780 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
8783 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
8785 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
8786 Without this fix, on a 64-bit host (aset S 0 4294967386) would
8787 incorrectly succeed when S was a string, because 4294967386 was
8788 truncated before it was used.
8790 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
8791 Otherwise, an out-of-range integer could cause undefined behavior
8794 * composite.c: Use int, not EMACS_INT, for characters.
8795 (fill_gstring_body, composition_compute_stop_pos): Use int, not
8796 EMACS_INT, for values that are known to be in character range.
8797 This doesn't fix any bugs but is the usual style inside Emacs and
8798 may generate better code on 32-bit machines.
8800 Make sure a 64-bit char is never passed to ENCODE_CHAR.
8801 This is for reasons similar to the recent CHAR_STRING fix.
8802 * charset.c (Fencode_char): Check that character arg is actually
8803 a character. Pass an int to ENCODE_CHAR.
8804 * charset.h (ENCODE_CHAR): Verify that the character argument is no
8805 wider than 'int', as a compile-time check to prevent future regressions
8808 * character.c (char_string): Remove unnecessary casts.
8810 Make sure a 64-bit char is never passed to CHAR_STRING.
8811 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
8812 by silently ignoring the top 32 bits, allowing some values
8813 that were far too large to be valid characters.
8814 * character.h: Include <verify.h>.
8815 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
8816 arguments are no wider than unsigned, as a compile-time check
8817 to prevent future regressions in this area.
8819 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
8820 (Fsubst_char_in_region):
8822 * xdisp.c (decode_mode_spec_coding):
8823 Adjust to CHAR_STRING's new requirement.
8824 * editfns.c (Finsert_char, Fsubst_char_in_region):
8825 * fns.c (concat): Check that character args are actually
8826 characters. Without this test, these functions did the wrong
8827 thing with wildly out-of-range values on 64-bit hosts.
8829 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
8830 These casts should not be needed on 32-bit hosts, either.
8831 * keyboard.c (read_char):
8832 * lread.c (Fload): Remove casts to unsigned.
8834 * lisp.h (UNSIGNED_CMP): New macro.
8835 This fixes comparison bugs on 64-bit hosts.
8836 (ASCII_CHAR_P): Use it.
8837 * casefiddle.c (casify_object):
8838 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
8839 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
8840 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
8841 * dispextern.h (FACE_FROM_ID):
8842 * keyboard.c (read_char): Use UNSIGNED_CMP.
8844 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
8845 not to EMACS_INT, to avoid GCC warning.
8847 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
8849 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
8850 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
8851 isn't needed on 32-bit machines.
8853 * buffer.c (Fgenerate_new_buffer_name):
8854 Use EMACS_INT for count, not int.
8855 (advance_to_char_boundary): Return EMACS_INT, not int.
8857 * data.c (Qcompiled_function): Now static.
8859 * window.c (window_body_lines): Now static.
8861 * image.c (gif_load): Rename local to avoid shadowing.
8863 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
8864 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
8865 * alloc.c (make_save_value): Integer argument is now of type
8867 (mark_object): Use ptrdiff_t, not int.
8868 * lisp.h (pD): New macro.
8869 * print.c (print_object): Use it.
8871 * alloc.c: Use EMACS_INT, not int, to count objects.
8872 (total_conses, total_markers, total_symbols, total_vector_size)
8873 (total_free_conses, total_free_markers, total_free_symbols)
8874 (total_free_floats, total_floats, total_free_intervals)
8875 (total_intervals, total_strings, total_free_strings):
8876 Now EMACS_INT, not int. All uses changed.
8877 (Fgarbage_collect): Compute overall total using a double, so that
8878 integer overflow is less likely to be a problem. Check for overflow
8879 when converting back to an integer.
8880 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
8881 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
8882 These were 'int' variables that could overflow on 64-bit hosts;
8883 they were never used, so remove them instead of repairing them.
8884 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
8885 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
8886 Previously, this ceilinged at INT_MAX, but that doesn't work on
8888 (allocate_pseudovector): Don't use EMACS_INT when int would do.
8890 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
8891 (allocate_vectorlike): Check for ptrdiff_t overflow.
8892 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
8893 when a (possibly-narrower) signed value would do just as well.
8894 We prefer using signed arithmetic, to avoid comparison confusion.
8896 * alloc.c: Catch some string size overflows that we were missing.
8897 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
8898 for convenience in STRING_BYTES_MAX.
8899 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
8900 The definition here is exact; the one in lisp.h was approximate.
8901 (allocate_string_data): Check for string overflow. This catches
8902 some instances we weren't catching before. Also, it catches
8903 size_t overflow on (unusual) hosts where SIZE_MAX <= min
8904 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
8905 and ptrdiff_t and EMACS_INT are both 64 bits.
8907 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
8908 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
8909 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
8911 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
8913 * alloc.c (Fmake_string): Check for out-of-range init.
8915 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
8917 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
8919 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
8921 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
8922 xg_get_default_scrollbar_width.
8924 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
8925 (int_gtk_range_get_value): Move to the scroll bar part of the file.
8926 (style_changed_cb): Call update_theme_scrollbar_width and call
8927 x_set_scroll_bar_default_width and xg_frame_set_char_size for
8928 all frames (Bug#8505).
8929 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
8930 Call gtk_window_set_resizable if HAVE_GTK3.
8931 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
8932 and height if HAVE_GTK3 (Bug#8505).
8933 (scroll_bar_width_for_theme): New variable.
8934 (update_theme_scrollbar_width): New function.
8935 (xg_get_default_scrollbar_width): Move code to
8936 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
8937 (xg_initialize): Call update_theme_scrollbar_width.
8939 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
8941 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
8943 2011-06-12 Martin Rudalics <rudalics@gmx.at>
8945 * frame.c (make_frame): Call other_buffer_safely instead of
8948 * window.c (temp_output_buffer_show): Call display_buffer with
8949 second argument Vtemp_buffer_show_specifiers and reset latter
8950 immediately after the call.
8951 (Vtemp_buffer_show_specifiers): New variable.
8952 (auto_window_vscroll_p, next_screen_context_lines)
8953 (Vscroll_preserve_screen_position): Remove leading asterisks from
8956 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
8958 Fix minor problems found by GCC 4.6.0 static checking.
8959 * buffer.c (Qclone_number): Remove for now, as it's unused.
8960 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
8961 (record_buffer): Remove unused local.
8962 * frame.c (other_visible_frames, frame_buffer_list): Now static.
8963 (set_frame_buffer_list): Remove; unused.
8964 * frame.h (other_visible_frames): Remove decl.
8965 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
8966 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
8967 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
8969 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
8970 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
8971 Define only if HAVE_GPM.
8972 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
8973 (update_hints_inhibit): Remove; never set. All uses removed.
8974 * widgetprv.h (emacsFrameClassRec): Remove decl.
8975 * window.c (delete_deletable_window): Now returns void, since it
8976 wasn't returning anything.
8977 (compare_window_configurations): Remove unused locals.
8978 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
8979 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
8980 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
8981 the same widths as pointers. This follows up on the 2011-05-06 patch.
8982 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
8983 * xterm.h: Likewise.
8984 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
8986 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
8988 * makefile.w32-in: Update dependencies.
8989 (LISP_H): Add lib/intprops.h.
8991 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
8993 * image.c (gif_load): Add animation frame delay to the metadata.
8994 (syms_of_image): Use DEFSYM. New symbol `delay'.
8996 2011-06-11 Martin Rudalics <rudalics@gmx.at>
8998 * window.c (delete_deletable_window): Re-add.
8999 (Fset_window_configuration): Rewrite to handle dead buffers and
9000 consequently deletable windows.
9001 (window_tree, Fwindow_tree): Remove. Supply functionality in
9003 (compare_window_configurations): Simplify code.
9005 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
9007 * image.c (imagemagick_load_image): Fix type mismatch.
9008 (Fimagemagick_types): Likewise.
9010 * window.h (replace_buffer_in_windows): Declare.
9012 2011-06-11 Martin Rudalics <rudalics@gmx.at>
9014 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
9015 Qclone_number. Remove external declaration of Qdelete_window.
9016 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
9018 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
9019 Run Qbuffer_list_update_hook if allowed.
9020 (Fother_buffer): Rewrite doc-string. Major rewrite for new
9021 buffer list implementation.
9022 (other_buffer_safely): New function.
9023 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
9024 calls to replace_buffer_in_windows and
9025 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
9027 (record_buffer): Inhibit quitting and rewrite using quittable
9028 functions. Run Qbuffer_list_update_hook if allowed.
9029 (Frecord_buffer, Funrecord_buffer): New functions.
9030 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
9031 Move switch-to-buffer to window.el.
9032 (bury-buffer): Move to window.el.
9033 (Vbuffer_list_update_hook): New variable.
9035 * lisp.h (other_buffer_safely): Add prototype in buffer.c
9038 * window.h (resize_frame_windows): Move up in code.
9039 (Fwindow_frame): Remove EXFUN.
9040 (replace_buffer_in_all_windows): Remove prototype.
9041 (replace_buffer_in_windows_safely): Add prototype.
9043 * window.c: Declare Qdelete_window static again. Move down
9044 declaration of select_count.
9045 (Fnext_window, Fprevious_window): Rewrite doc-strings.
9046 (Fother_window): Move to window.el.
9047 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
9048 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
9049 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
9051 (replace_buffer_in_windows): Implement by calling
9052 Qreplace_buffer_in_windows.
9053 (replace_buffer_in_all_windows): Remove with some functionality
9054 moved into replace_buffer_in_windows_safely.
9055 (replace_buffer_in_windows_safely): New function.
9056 (select_window_norecord, select_frame_norecord): Move in front
9057 of run_window_configuration_change_hook. Remove now obsolete
9059 (Fset_window_buffer): Rewrite doc-string.
9060 Call Qrecord_window_buffer.
9061 (keys_of_window): Move binding for other-window to window.el.
9063 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
9065 * dispextern.h (struct image): Replace data member, whose int_val
9066 and ptr_val fields were not used by anything, with a single
9069 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
9070 (gif_clear_image, gif_load, imagemagick_load_image)
9071 (gs_clear_image, gs_load): Callers changed.
9073 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
9075 * buffer.h: Include <time.h>, for time_t.
9076 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
9078 Fix minor problems found by static checking.
9080 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
9082 Make identifiers static if they are not used in other modules.
9083 * data.c (Qcompiled_function, Qframe, Qvector):
9084 * image.c (QimageMagick, Qsvg):
9085 * minibuf.c (Qmetadata):
9086 * window.c (resize_window_check, resize_root_window): Now static.
9087 * window.h (resize_window_check, resize_root_window): Remove decls.
9089 * window.c (window_deletion_count, delete_deletable_window):
9091 (window_body_lines): Now static.
9092 (Fdelete_other_windows_internal): Mark vars as initialized.
9093 Make sure 'resize_failed' is initialized.
9094 (run_window_configuration_change_hook): Rename local to avoid shadowing.
9095 (resize_window_apply): Remove unused local.
9096 * window.h (delete_deletable_window): Remove decl.
9098 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
9099 (imagemagick_load_image): Fix pointer signedness problem by changing
9100 last arg from unsigned char * to char *. All uses changed.
9101 Also, fix a local for similar reasons.
9102 Remove unused locals. Remove locals to avoid shadowing.
9103 (fn_rsvg_handle_free): Remove; unused.
9104 (svg_load, svg_load_image): Fix pointer signedness problem.
9105 (imagemagick_load_image): Don't use garbage pointer image_wand.
9107 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
9109 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
9111 * image.c (gif_load): Fix omitted cast error introduced by
9114 2011-06-10 Martin Rudalics <rudalics@gmx.at>
9116 * window.h (resize_proportionally, orig_total_lines)
9117 (orig_top_line): Remove from window structure.
9118 (set_window_height, set_window_width, change_window_heights)
9119 (Fdelete_window): Remove prototypes.
9120 (resize_frame_windows): Remove duplicate declaration.
9122 2011-06-10 Eli Zaretskii <eliz@gnu.org>
9124 * window.h (resize_frame_windows, resize_window_check)
9125 (delete_deletable_window, resize_root_window)
9126 (resize_frame_windows): Declare prototypes.
9128 * window.c (resize_window_apply): Make definition be "static" to
9129 match the prototype.
9131 2011-06-10 Martin Rudalics <rudalics@gmx.at>
9133 * window.c: Remove declarations of Qwindow_size_fixed,
9134 window_min_size_1, window_min_size_2, window_min_size,
9135 size_window, window_fixed_size_p, enlarge_window, delete_window.
9136 Remove static from declaration of Qdelete_window, it's
9137 temporarily needed by Fbury_buffer.
9138 (replace_window): Don't assign orig_top_line and
9140 (Fdelete_window, delete_window): Remove. Window deletion is
9141 handled by window.el.
9142 (window_loop): Remove DELETE_OTHER_WINDOWS case.
9143 Replace Fdelete_window calls with calls to Qdelete_window.
9144 (Fdelete_other_windows): Remove. Deleting other windows is
9145 handled by window.el.
9146 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
9147 handled in window.el.
9148 (window_min_size_2, window_min_size_1, window_min_size): Remove.
9149 Window minimum sizes are handled in window.el.
9150 (shrink_windows, size_window, set_window_height)
9151 (set_window_width, change_window_heights, window_height)
9152 (window_width, CURBEG, CURSIZE, enlarge_window)
9153 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
9154 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
9155 handled in window.el.
9156 (make_dummy_parent): Rename to make_parent_window and give it a
9157 second argument horflag.
9158 (make_window): Don't set resize_proportionally any more.
9159 (Fsplit_window): Remove. Windows are split in window.el.
9160 (save_restore_action, save_restore_orig_size)
9161 (shrink_window_lowest_first, save_restore_orig_size): Remove.
9162 Resize mini windows in window.el.
9163 (grow_mini_window, shrink_mini_window): Implement by calling
9164 Qresize_root_window_vertically, resize_window_check and
9165 resize_window_apply.
9166 (saved_window, Fset_window_configuration, save_window_save):
9167 Do not handle orig_top_line, orig_total_lines, and
9168 resize_proportionally.
9169 (window_min_height, window_min_width): Move to window.el.
9170 (keys_of_window): Move bindings for delete-other-windows,
9171 split-window, delete-window and enlarge-window to window.el.
9173 * buffer.c: Temporarily extern Qdelete_window.
9174 (Fbury_buffer): Temporarily call Qdelete_window instead of
9175 Fdelete_window (Fbury_buffer will move to window.el soon).
9177 * frame.c (set_menu_bar_lines_1): Remove code handling
9178 orig_top_line and orig_total_lines.
9180 * dispnew.c (adjust_frame_glyphs_initially): Don't use
9181 set_window_height but set heights directly.
9182 (change_frame_size_1): Use resize_frame_windows.
9184 * xdisp.c (init_xdisp): Don't use set_window_height but set
9187 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
9188 Use resize_frame_windows instead of change_window_heights and run
9189 run_window_configuration_change_hook.
9191 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
9192 instead of change_window_heights and run
9193 run_window_configuration_change_hook.
9195 2011-06-09 Martin Rudalics <rudalics@gmx.at>
9197 * window.c (replace_window): Rename second argument REPLACEMENT to
9198 NEW. New third argument SETFLAG. Rewrite.
9199 (delete_window, make_dummy_parent): Call replace_window with
9201 (window_list_1): Move down in code.
9202 (run_window_configuration_change_hook): Move set_buffer part
9203 before select_frame_norecord part in order to unwind correctly.
9204 Rename count1 to count.
9205 (recombine_windows, delete_deletable_window, resize_root_window)
9206 (Fdelete_other_windows_internal)
9207 (Frun_window_configuration_change_hook, make_parent_window)
9208 (resize_window_check, resize_window_apply, Fresize_window_apply)
9209 (resize_frame_windows, Fsplit_window_internal)
9210 (Fdelete_window_internal, Fresize_mini_window_internal):
9212 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
9214 2011-06-08 Martin Rudalics <rudalics@gmx.at>
9216 * window.h (window): Add some new members to window structure -
9217 normal_lines, normal_cols, new_total, new_normal, clone_number,
9218 splits, nest, prev_buffers, next_buffers.
9219 (WINDOW_TOTAL_SIZE): Move here from window.c.
9220 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
9222 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
9224 (make_dummy_parent): Set new members of windows structure.
9225 (make_window): Move down in code. Handle new members of window
9227 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
9228 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
9229 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
9230 (Fset_window_prev_buffers, Fwindow_next_buffers)
9231 (Fset_window_next_buffers, Fset_window_clone_number):
9233 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
9234 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
9236 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
9237 Argument WINDOW can be now internal window too.
9238 (Fwindow_use_time): Move up in code.
9239 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
9241 (Fset_window_configuration, saved_window)
9242 (Fcurrent_window_configuration, save_window_save): Handle new
9243 members of window structure.
9244 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
9245 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
9246 (syms_of_window): New Lisp objects Qrecord_window_buffer,
9247 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
9248 Qget_mru_window, Qresize_root_window,
9249 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
9250 Qauto_buffer_name; staticpro them.
9252 2011-06-07 Martin Rudalics <rudalics@gmx.at>
9254 * window.c (Fwindow_total_size, Fwindow_left_column)
9255 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
9256 (Fwindow_list_1): New functions.
9257 (window_box_text_cols): Replace with window_body_cols.
9258 (Fwindow_width, Fscroll_left, Fscroll_right):
9259 Use window_body_cols instead of window_box_text_cols.
9260 (delete_window, Fset_window_configuration):
9261 Call delete_all_subwindows with window as argument.
9262 (delete_all_subwindows): Take a window as argument and not a
9264 (window_loop): Remove handling of GET_LRU_WINDOW and
9266 (Fget_lru_window, Fget_largest_window): Move to window.el.
9268 * window.h: Extern window_body_cols instead of
9269 window_box_text_cols. delete_all_subwindows now takes a
9270 Lisp_Object as argument.
9272 * indent.c (compute_motion, Fcompute_motion):
9273 Use window_body_cols instead of window_box_text_cols.
9275 * frame.c (delete_frame): Call delete_all_subwindows with root
9278 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
9280 * fns.c (Fputhash): Document return value.
9282 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
9284 * image.c (gif_load): Implement gif89a spec "no disposal" method.
9286 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9288 Cons<->int and similar integer overflow fixes (Bug#8794).
9290 Check for overflow when converting integer to cons and back.
9291 * charset.c (Fdefine_charset_internal, Fdecode_char):
9292 Use cons_to_unsigned to catch overflow.
9293 (Fencode_char): Use INTEGER_TO_CONS.
9294 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
9295 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
9296 * data.c (long_to_cons, cons_to_long): Remove.
9297 (cons_to_unsigned, cons_to_signed): New functions.
9298 These signal an error for invalid or out-of-range values.
9299 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
9300 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
9301 * font.c (Ffont_variation_glyphs):
9302 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
9303 * lisp.h: Include <intprops.h>.
9304 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
9305 (cons_to_signed, cons_to_unsigned): New decls.
9306 (long_to_cons, cons_to_long): Remove decls.
9307 * undo.c (record_first_change): Use INTEGER_TO_CONS.
9308 (Fprimitive_undo): Use CONS_TO_INTEGER.
9309 * xfns.c (Fx_window_property): Likewise.
9310 * xselect.c: Include <limits.h>.
9311 (x_own_selection, selection_data_to_lisp_data):
9312 Use INTEGER_TO_CONS.
9313 (x_handle_selection_request, x_handle_selection_clear)
9314 (x_get_foreign_selection, Fx_disown_selection_internal)
9315 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
9316 (lisp_data_to_selection_data): Use cons_to_unsigned.
9317 (x_fill_property_data): Use cons_to_signed.
9318 Report values out of range.
9320 Check for buffer and string overflow more precisely.
9321 * buffer.h (BUF_BYTES_MAX): New macro.
9322 * lisp.h (STRING_BYTES_MAX): New macro.
9323 * alloc.c (Fmake_string):
9324 * character.c (string_escape_byte8):
9325 * coding.c (coding_alloc_by_realloc):
9326 * doprnt.c (doprnt):
9327 * editfns.c (Fformat):
9329 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
9330 since they may not be the same number.
9331 * editfns.c (Finsert_char):
9332 * fileio.c (Finsert_file_contents):
9333 Likewise for BUF_BYTES_MAX.
9335 * image.c: Use ptrdiff_t, not int, for sizes.
9336 (slurp_file): Switch from int to ptrdiff_t.
9338 (slurp_file): Check that file size fits in both size_t (for
9339 malloc) and ptrdiff_t (for sanity and safety).
9341 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
9342 if b->modtime has its maximal value.
9344 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
9346 Don't assume time_t can fit into int.
9347 * buffer.h (struct buffer.modtime): Now time_t, not int.
9348 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
9349 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
9351 Minor fixes for signed vs unsigned integers.
9352 * character.h (MAYBE_UNIFY_CHAR):
9353 * charset.c (maybe_unify_char):
9354 * keyboard.c (read_char, reorder_modifiers):
9355 XINT -> XFASTINT, since the integer must be nonnegative.
9356 * ftfont.c (ftfont_spec_pattern):
9357 * keymap.c (access_keymap, silly_event_symbol_error):
9358 XUINT -> XFASTINT, since the integer must be nonnegative.
9359 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
9360 since it makes no difference and we prefer signed.
9361 * keyboard.c (record_char): Use XUINT when all the neighbors do.
9362 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
9365 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
9367 * window.h (Fwindow_frame): Declare.
9369 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9371 * alloc.c: Simplify handling of large-request failures (Bug#8800).
9372 (SPARE_MEMORY): Always define.
9373 (LARGE_REQUEST): Remove.
9374 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
9376 2011-06-06 Martin Rudalics <rudalics@gmx.at>
9378 * lisp.h: Move EXFUNS for Fframe_root_window,
9379 Fframe_first_window and Fset_frame_selected_window to window.h.
9381 * window.h: Move EXFUNS for Fframe_root_window,
9382 Fframe_first_window and Fset_frame_selected_window here from
9385 * frame.c (Fwindow_frame, Fframe_first_window)
9386 (Fframe_root_window, Fframe_selected_window)
9387 (Fset_frame_selected_window): Move to window.c.
9388 (Factive_minibuffer_window): Move to minibuf.c.
9389 (Fother_visible_frames_p): New function.
9391 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
9393 * window.c (decode_window, decode_any_window): Move up in code.
9394 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
9395 (inhibit_frame_unsplittable): Remove unused variable.
9396 (Fwindow_buffer): Move up and rewrite doc-string.
9397 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
9398 (Fwindow_prev): New functions.
9399 (Fwindow_frame): Move here from frame.c. Accept any window as
9401 (Fframe_root_window, Fframe_first_window)
9402 (Fframe_selected_window): Move here from frame.c. Accept frame
9403 or arbitrary window as argument. Update doc-strings.
9404 (Fminibuffer_window): Move up in code.
9405 (Fwindow_minibuffer_p): Move up in code and simplify.
9406 (Fset_frame_selected_window): Move here from frame.c.
9408 (Fselected_window, select_window, Fselect_window): Move up in
9409 code. Minor doc-string fixes.
9411 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9413 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
9414 Do not assume that spare memory exists; that assumption is valid
9415 only if SYSTEM_MALLOC.
9416 (LARGE_REQUEST): New macro, so that the issue of large requests
9417 is separated from the issue of spare memory.
9419 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
9421 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
9424 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
9426 * xfns.c (x_set_scroll_bar_default_width): Move declarations
9429 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
9431 * gtkutil.c (xg_get_default_scrollbar_width): New function.
9433 * gtkutil.h: Declare xg_get_default_scrollbar_width.
9435 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
9436 min width by calling x_set_scroll_bar_default_width (Bug#8505).
9438 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
9440 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
9442 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
9444 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
9445 (x_clipboard_manager_save): Add return value.
9446 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
9448 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
9449 Obey Vx_select_enable_clipboard_manager. Catch errors in
9450 x_clipboard_manager_save (Bug#8779).
9451 (Vx_select_enable_clipboard_manager): New variable.
9452 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
9454 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
9456 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
9458 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9460 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
9461 in the current matrix if keep_current_p is non-zero.
9463 2011-06-04 Eli Zaretskii <eliz@gnu.org>
9465 * bidi.c (bidi_level_of_next_char): Fix last change.
9467 2011-06-03 Eli Zaretskii <eliz@gnu.org>
9469 Support bidi reordering of text covered by display properties.
9471 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
9472 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
9473 (bidi_cache_search, bidi_cache_iterator_state)
9474 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
9475 (bidi_level_of_next_char, bidi_move_to_visually_next):
9476 Support character positions inside a run of characters covered by a
9478 (bidi_paragraph_init, bidi_resolve_explicit_1)
9479 (bidi_level_of_next_char): Call bidi_fetch_char and
9480 bidi_fetch_char_advance instead of FETCH_CHAR and
9482 (bidi_init_it): Initialize new members.
9483 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
9485 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
9486 instead of using explicit *_CHAR codes.
9487 (bidi_resolve_explicit, bidi_resolve_weak):
9488 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
9489 bidirectional text is supported only in multibyte buffers.
9490 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
9491 it to initialize the frame_window_p member of struct bidi_it.
9492 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
9493 (bidi_resolve_explicit, bidi_resolve_weak)
9494 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
9495 bidi_it->nchars is non-positive.
9496 (bidi_level_of_next_char): Don't try to lookup the cache for the
9497 next/previous character if nothing is cached there yet, or if we
9498 were just reseat()'ed to a new position.
9500 * xdisp.c (set_cursor_from_row): Set start and stop points
9501 according to the row's direction when priming the loop that looks
9502 for the glyph on which to display cursor.
9503 (single_display_spec_intangible_p): Function deleted.
9504 (display_prop_intangible_p): Reimplement to call
9505 handle_display_spec instead of single_display_spec_intangible_p.
9506 Accept 3 additional arguments needed by handle_display_spec.
9507 This fixes incorrect cursor motion across display property with complex
9508 values: lists, `(when COND...)' forms, etc.
9509 (single_display_spec_string_p): Support property values that are
9510 lists with the argument STRING its top-level element.
9511 (display_prop_string_p): Fix the condition for processing a
9512 property that is a list to be consistent with handle_display_spec.
9513 (handle_display_spec): New function, refactored from the
9514 last portion of handle_display_prop.
9515 (compute_display_string_pos): Accept additional argument
9516 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
9517 value of a `display' property is a "replacing spec".
9518 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
9519 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
9520 the display property, but just return a value indicating whether
9521 the display property will replace the characters it covers.
9522 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
9523 frame_window_p members of struct bidi_it.
9524 (compute_display_string_pos, compute_display_string_end):
9526 (push_it): Accept second argument POSITION, where pop_it should
9527 jump to continue iteration.
9528 (reseat_1): Initialize bidi_it.disp_pos.
9530 * keyboard.c (adjust_point_for_property): Adjust the call to
9531 display_prop_intangible_p to its new signature.
9533 * dispextern.h (struct bidi_it): New member frame_window_p.
9534 (bidi_init_it): Update prototypes.
9535 (display_prop_intangible_p): Update prototype.
9536 (compute_display_string_pos, compute_display_string_end):
9538 (struct bidi_it): New members nchars and disp_pos. ch_len is now
9541 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
9543 Malloc failure behavior now depends on size of allocation.
9544 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
9545 * lisp.h: Change signatures accordingly.
9546 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
9547 All callers changed. (Bug#8762)
9549 * gnutls.c: Use Emacs's memory allocators.
9550 Without this change, the gnutls library would invoke malloc etc.
9551 directly, which causes problems on non-SYNC_INPUT hosts, and which
9552 runs afoul of improving memory_full behavior. (Bug#8761)
9553 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
9554 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
9555 xfree instead of the default malloc, realloc, free.
9556 (Fgnutls_boot): No need to check for memory allocation failure,
9557 since xmalloc does that for us.
9559 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
9560 * category.c (hash_get_category_set):
9561 * ccl.c (ccl_driver):
9562 * charset.c (Fdefine_charset_internal):
9563 * charset.h (struct charset.hash_index):
9564 * composite.c (get_composition_id, gstring_lookup_cache)
9565 (composition_gstring_put_cache):
9566 * composite.h (struct composition.hash_index):
9567 * dispextern.h (struct image.hash):
9568 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
9569 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
9570 (hashfn_equal, hashfn_user_defined, make_hash_table)
9571 (maybe_resize_hash_table, hash_lookup, hash_put)
9572 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
9573 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
9574 (Fsxhash, Fgethash, Fputhash, Fmaphash):
9575 * image.c (make_image, search_image_cache, lookup_image)
9576 (xpm_put_color_table_h):
9577 * lisp.h (struct Lisp_Hash_Table):
9578 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
9579 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
9580 for hashes and hash indexes, instead of 'unsigned' and 'int'.
9581 * alloc.c (allocate_vectorlike):
9582 Check for overflow in vector size calculations.
9583 * ccl.c (ccl_driver):
9584 Check for overflow when converting EMACS_INT to int.
9585 * fns.c, image.c: Remove unnecessary static decls that would otherwise
9586 need to be updated by these changes.
9587 * fns.c (make_hash_table, maybe_resize_hash_table):
9588 Check for integer overflow with large hash tables.
9589 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
9590 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
9591 (SXHASH_REDUCE): New macro.
9592 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
9593 Use it instead of discarding useful hash info with large hash values.
9594 (sxhash_float): New function.
9595 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
9596 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
9597 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
9598 Rewrite to use FIXNUM_BITS, as this simplifies things.
9599 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
9600 Adjust signatures to match updated version of code.
9601 (consing_since_gc): Now EMACS_INT, since a single hash table can
9602 use more than INT_MAX bytes.
9604 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
9606 Make it possible to build with GCC-4.6+ -O2 -flto.
9608 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
9610 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
9612 * minibuf.c (get_minibuffer, read_minibuf_unwind):
9613 Call minibuffer-inactive-mode.
9615 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
9617 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
9618 Update dependencies.
9620 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9622 * data.c (init_data): Remove code for UTS, this system is not
9625 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9627 Don't force ./temacs to start in terminal mode.
9629 * frame.c (make_initial_frame): Initialize faces in all cases, not
9630 only when CANNOT_DUMP is defined.
9631 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
9633 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9635 * dispnew.c (add_window_display_history): Use const for the string
9636 pointer. Remove declaration, not needed.
9638 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9640 Use 'inline', not 'INLINE'.
9641 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
9642 * alloc.c, fontset.c (INLINE): Remove.
9643 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
9644 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
9645 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
9646 * gmalloc.c (register_heapinfo): Use inline unconditionally.
9647 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
9649 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9651 Make it possible to run ./temacs.
9653 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
9654 syms_of_callproc does the same thing. Remove test for
9655 "initialized", do it in the caller.
9656 * emacs.c (main): Avoid calling set_initial_environment when dumping.
9658 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
9660 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
9661 (read_minibuf): Use get_minibuffer.
9662 (syms_of_minibuf): Use DEFSYM.
9663 (Qmetadata): New var.
9664 * data.c (Qbuffer): Don't make it static.
9665 (syms_of_data): Use DEFSYM.
9667 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9669 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
9670 (CCL_CODE_MIN): New macro.
9672 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
9674 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
9676 * eval.c (Qdebug): Now static.
9677 * lisp.h (Qdebug): Remove decl. This reverts a part of the
9678 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
9679 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
9681 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
9683 * image.c: Various fixes to ImageMagick code comments.
9684 (Fimagemagick_types): Doc fix.
9686 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
9688 Minor fixes prompted by GCC 4.6.0 warnings.
9690 * xselect.c (converted_selections, conversion_fail_tag): Now static.
9692 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
9693 (x_clipboard_manager_save_all): Move extern decl to ...
9694 * xterm.h: ... here, so that it can be checked for consistency.
9696 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
9698 * xselect.c (x_clipboard_manager_save_frame)
9699 (x_clipboard_manager_save_all): New functions.
9700 (Fx_clipboard_manager_save): Lisp function deleted.
9702 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
9703 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
9705 * xterm.h: Update prototype.
9707 2011-05-28 William Xu <william.xwl@gmail.com>
9709 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
9712 2011-05-28 Jim Meyering <meyering@redhat.com>
9714 Avoid a sign-extension bug in crypto_hash_function.
9715 * fns.c (to_uchar): Define.
9716 (crypto_hash_function): Use it to convert some newly-signed
9717 variables to unsigned, to avoid sign-extension bugs. For example,
9718 without this change, (md5 "truc") would evaluate to
9719 45723a2aff78ff4fff7fff1114760e62 rather than the expected
9720 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
9721 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
9723 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9725 Integer overflow fixes.
9727 * dbusbind.c: Serial number integer overflow fixes.
9728 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
9729 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
9730 to hold a serial number that is too large for a fixnum.
9731 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9732 Check for serial numbers out of range. Decode any serial number
9733 that was so large that it became a float. (Bug#8722)
9735 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
9736 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9737 Use XFASTINT rather than XUINT when numbers are nonnegative.
9738 (xd_append_arg, Fdbus_method_return_internal):
9739 (Fdbus_method_error_internal): Likewise. Also, for unsigned
9740 arguments, check that Lisp number is nonnegative, rather than
9741 silently wrapping negative numbers around. (Bug#8722)
9742 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
9745 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
9747 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
9749 ccl: Add integer overflow checks.
9750 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
9751 (IN_INT_RANGE): New macros.
9752 (ccl_driver): Use them to check for integer overflow when
9753 decoding a CCL program. Many of the new checks are whether XINT (x)
9754 fits in int; it doesn't always, on 64-bit hosts. The new version
9755 doesn't catch all possible integer overflows, but it's an
9756 improvement. (Bug#8719)
9758 * alloc.c (make_event_array): Use XINT, not XUINT.
9759 There's no need for unsigned here.
9761 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
9762 This follows up to the 2011-05-06 change that substituted uintptr_t
9763 for EMACS_INT. This case wasn't caught back then.
9765 Rework Fformat to avoid integer overflow issues.
9766 * editfns.c: Include <float.h> unconditionally, as it's everywhere
9767 now (part of C89). Include <verify.h>.
9768 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
9769 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
9770 (Fformat): Avoid the prepass trying to compute sizes; it was only
9771 approximate and thus did not catch overflow reliably. Instead, walk
9772 through the format just once, formatting and computing sizes as we go,
9773 checking for integer overflow at every step, and allocating a larger
9774 buffer as needed. Keep track separately whether the format is
9775 multibyte. Keep only the most-recently calculated precision, rather
9776 than them all. Record whether each argument has been converted to
9777 string. Use EMACS_INT, not int, for byte and char and arg counts.
9778 Support field widths and precisions larger than INT_MAX. Avoid
9779 sprintf's undefined behavior with conversion specifications such as %#d
9780 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
9781 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
9782 formatting out-of-range floating point numbers with int
9785 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
9787 * data.c: Avoid integer truncation in expressions involving floats.
9788 * data.c: Include <intprops.h>.
9789 (arith_driver): When there's an integer overflow in an expression
9790 involving floating point, convert the integers to floating point
9791 so that the resulting value does not suffer from catastrophic
9792 integer truncation. For example, on a 64-bit host (* 4
9793 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
9794 Do not rely on undefined behavior after integer overflow.
9796 merge count_size_as_multibyte, parse_str_to_multibyte
9797 * character.c, character.h (count_size_as_multibyte):
9798 Rename from parse_str_to_multibyte; all uses changed.
9799 Check for integer overflow.
9800 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
9801 since it's now a duplicate of the other. This is more of
9802 a character than a buffer op, so better that it's in character.c.
9803 * fns.c, print.c: Adjust to above changes.
9805 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
9807 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
9809 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9811 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9812 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
9813 (x_clipboard_manager_save): Now static.
9814 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
9816 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9817 (crypto_hash_function): Now static.
9818 Fix pointer signedness problems. Avoid unnecessary initializations.
9820 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
9822 * termhooks.h (Vselection_alist): Make it terminal-local.
9824 * terminal.c (create_terminal): Initialize it.
9826 * xselect.c: Support for clipboard managers.
9827 (Vselection_alist): Move to termhooks.h as terminal-local var.
9828 (LOCAL_SELECTION): New macro.
9829 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
9830 (symbol_to_x_atom): Remove gratuitous arg.
9831 (x_handle_selection_request, lisp_data_to_selection_data)
9832 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
9833 (x_own_selection, x_get_local_selection, x_convert_selection):
9834 New arg, specifying work frame. Use terminal-local Vselection_alist.
9835 (some_frame_on_display): Delete unused function.
9836 (Fx_own_selection_internal, Fx_get_selection_internal)
9837 (Fx_disown_selection_internal, Fx_selection_owner_p)
9838 (Fx_selection_exists_p): New optional frame arg.
9839 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
9840 (x_handle_selection_clear): Don't treat other terminals with the
9841 same keyboard specially. Use the terminal-local Vselection_alist.
9842 (x_clear_frame_selections): Use Frun_hook_with_args.
9844 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
9846 * xterm.h: Add support for those atoms.
9848 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
9850 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
9851 (converted_selections, conversion_fail_tag): New global variables.
9852 (x_selection_request_lisp_error): Free the above.
9853 (x_get_local_selection): Remove unnecessary code.
9854 (x_reply_selection_request): Args changed; handle arbitrary array
9855 of converted selections stored in converted_selections.
9856 Separate the XChangeProperty and SelectionNotify steps.
9857 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
9858 (x_convert_selection): New function.
9859 (x_handle_selection_event): Simplify.
9860 (x_get_foreign_selection): Don't ignore incoming requests while
9861 waiting for an answer; this will fail when we implement
9862 SAVE_TARGETS, and seems unnecessary anyway.
9863 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
9864 (Vx_sent_selection_functions): Doc fix.
9866 2011-05-26 Leo Liu <sdl.web@gmail.com>
9868 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
9870 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9872 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
9874 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
9875 for fringe update if it has periodic bitmap.
9876 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
9877 and fringe_bitmap_periodic_p.
9879 * fringe.c (get_fringe_bitmap_data): New function.
9880 (draw_fringe_bitmap_1, update_window_fringes): Use it.
9881 (update_window_fringes): Record periodicity of fringe bitmap in glyph
9882 row. Mark glyph row for fringe update if periodicity changed.
9884 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
9885 for fringe update unless it has periodic bitmap.
9887 2011-05-25 Kenichi Handa <handa@m17n.org>
9889 * xdisp.c (get_next_display_element): Set correct it->face_id for
9890 a static composition.
9892 2011-05-24 Leo Liu <sdl.web@gmail.com>
9895 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
9897 * fns.c (crypto_hash_function, Fsha1): New function.
9898 (Fmd5): Use crypto_hash_function.
9899 (syms_of_fns): Add Ssha1.
9901 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9903 * gnutls.c: Remove unused macros.
9904 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
9905 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
9906 Remove macros that are defined and never used.
9907 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
9909 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
9911 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
9912 (Fx_get_selection_internal): Minor cleanup.
9913 (Fx_own_selection_internal): Rename arguments for consistency with
9916 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9918 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
9920 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
9922 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
9924 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9926 * dispnew.c (scrolling_window): Don't exclude the case that the
9927 last enabled row in the desired matrix touches the bottom boundary.
9929 2011-05-21 Glenn Morris <rgm@gnu.org>
9931 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
9932 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
9933 and add some more files.
9935 2011-05-20 Eli Zaretskii <eliz@gnu.org>
9937 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
9938 report_file_error introduced by the change from 2011-05-07.
9940 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
9942 * systime.h (Time): Define only if emacs is defined.
9943 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
9944 where the include path doesn't have X11/X.h by default. See
9945 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
9947 2011-05-20 Kenichi Handa <handa@m17n.org>
9949 * composite.c (find_automatic_composition): Fix previous change.
9951 2011-05-20 Glenn Morris <rgm@gnu.org>
9953 * lisp.mk: New file, split from Makefile.in.
9954 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
9955 (shortlisp): Remove.
9956 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
9958 2011-05-19 Glenn Morris <rgm@gnu.org>
9960 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
9961 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
9962 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
9963 (lisp): Set the order to that of loadup.el.
9964 (shortlisp): Make it a copy of $lisp.
9965 (SOME_MACHINE_LISP): Remove.
9966 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
9967 Use just $shortlisp, not $SOME_MACHINE_LISP too.
9969 2011-05-18 Kenichi Handa <handa@m17n.org>
9971 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
9972 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
9973 (find_automatic_composition): Mostly rewrite for efficiency.
9975 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
9977 * makefile.w32-in: Update dependencies.
9979 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
9981 * menu.c: Include limits.h (fixes the MS-Windows build broken by
9982 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
9984 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
9986 Fix some integer overflow issues, such as string length overflow.
9988 * insdel.c (count_size_as_multibyte): Check for string overflow.
9990 * character.c (lisp_string_width): Check for string overflow.
9991 Use EMACS_INT, not int, for string indexes and lengths; in
9992 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
9993 the resulting string length overflows an EMACS_INT; instead,
9994 report a string overflow if no precision given. When checking for
9995 precision exhaustion, use a check that cannot possibly have
9996 integer overflow. (Bug#8675)
9997 * character.h (lisp_string_width): Adjust to new signature.
9999 * alloc.c (string_overflow): New function.
10000 (Fmake_string): Use it. This doesn't change behavior, but saves
10001 a few bytes and will simplify future changes.
10002 * character.c (string_escape_byte8): Likewise.
10003 * lisp.h (string_overflow): New decl.
10005 Fixups, following up to the user-interface timestamp change.
10006 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
10007 for UI timestamps, instead of unsigned long.
10008 * msdos.c (mouse_get_pos): Likewise.
10009 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
10010 * w32gui.h (Time): Define by including "systime.h" rather than by
10011 declaring it ourselves. (Bug#8664)
10013 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
10014 * image.c (clear_image_cache): Likewise.
10016 * term.c (term_mouse_position): Don't assume time_t wraparound.
10018 Be more systematic about user-interface timestamps.
10019 Before, the code sometimes used 'Time', sometimes 'unsigned long',
10020 and sometimes 'EMACS_UINT', to represent these timestamps.
10021 This change causes it to use 'Time' uniformly, as that's what X uses.
10022 This makes the code easier to follow, and makes it easier to catch
10023 integer overflow bugs such as Bug#8664.
10024 * frame.c (Fmouse_position, Fmouse_pixel_position):
10025 Use Time, not unsigned long, for user-interface timestamps.
10026 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
10027 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
10028 * keyboard.h (last_event_timestamp): Likewise.
10029 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
10030 * menu.h (xmenu_show): Likewise.
10031 * term.c (term_mouse_position): Likewise.
10032 * termhooks.h (struct input_event.timestamp): Likewise.
10033 (struct terminal.mouse_position_hook): Likewise.
10034 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
10035 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
10036 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
10037 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
10038 what it was before.
10039 * menu.h, termhooks.h: Include "systime.h", for Time.
10041 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
10042 Don't assume that the difference between two unsigned long values
10043 can fit into an integer. At this point, we know button_down_time
10044 <= event->timestamp, so the difference must be nonnegative, so
10045 there's no need to cast the result if double-click-time is
10046 nonnegative, as it should be; check that it's nonnegative, just in
10047 case. This bug is triggered when events are more than 2**31 ms
10048 apart (about 25 days). (Bug#8664)
10050 * xselect.c (last_event_timestamp): Remove duplicate decl.
10051 (x_own_selection): Remove needless cast to unsigned long.
10053 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
10054 that always fit in int. Use a sentinel instead of a counter, to
10055 avoid a temp and to allay GCC's concerns about possible int overflow.
10056 * frame.h (struct frame): Use int for menu_bar_items_used
10057 instead of EMACS_INT, since it always fits in int.
10059 * menu.c (grow_menu_items): Check for int overflow.
10061 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
10063 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
10064 Before, the code was not consistent. These values cannot exceed
10065 2**31 - 1 so there's no need to make them unsigned.
10066 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
10067 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
10068 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
10070 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
10072 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
10073 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
10074 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
10075 presumably because the widths might not match.
10077 * window.c (size_window): Avoid needless test at loop start.
10079 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
10081 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
10083 2011-05-12 Drew Adams <drew.adams@oracle.com>
10085 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
10087 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10089 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
10090 `width' to `bar_area_x' and `bar_area_width', respectively.
10091 (x_scroll_run): Take account of fringe background extension.
10093 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
10094 Rename local vars `left' and `width' to `bar_area_x' and
10095 `bar_area_width', respectively.
10096 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
10097 background extension.
10099 2011-05-10 Jim Meyering <meyering@redhat.com>
10101 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
10103 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
10105 * image.c (Finit_image_library): Return t for built-in image types,
10106 like pbm and xbm. (Bug#8640)
10108 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
10110 * w32menu.c (set_frame_menubar): Fix submenu allocation.
10112 2011-05-07 Eli Zaretskii <eliz@gnu.org>
10114 * w32console.c (Fset_screen_color): Doc fix.
10115 (Fget_screen_color): New function.
10116 (syms_of_ntterm): Defsubr it.
10118 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
10119 unlink the temporary file if Fcall_process didn't create it in the
10121 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
10122 child process will be redirected to a file specified with `:file'.
10123 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
10124 cue to call_process_cleanup not to close that handle.
10126 2011-05-07 Ben Key <bkey76@gmail.com>
10128 * makefile.w32-in: The bootstrap-temacs rule now makes use of
10129 one of two shell specific rules, either bootstrap-temacs-CMD or
10130 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
10131 to the previous implementation of the bootstrap-temacs rule.
10132 The bootstrap-temacs-CMD rule is similar to the previous
10133 implementation of the bootstrap-temacs rule except that it
10134 makes use of the ESC_CFLAGS variable instead of the CFLAGS
10137 These changes, along with some changes to nt/configure.bat,
10138 nt/gmake.defs, and nt/nmake.defs, are required to extend my
10139 earlier fix to add support for --cflags and --ldflags options
10140 that include quotes so that it works whether make uses cmd or
10143 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
10145 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
10146 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
10148 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
10149 a string. Handle both cases.
10150 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
10151 (Fdbus_register_method): Use Qinvalid_function.
10153 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
10155 * makefile.w32-in: Update dependencies.
10156 (LISP_H): Add inttypes.h and stdin.h.
10157 (PROCESS_H): Add unistd.h.
10159 2011-05-06 Eli Zaretskii <eliz@gnu.org>
10161 * lread.c: Include limits.h (fixes the MS-Windows build broken by
10162 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
10164 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
10166 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
10168 * term.c (vfatal): Remove stray call to va_end.
10169 It's not needed and the C Standard doesn't allow it here anyway.
10171 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
10172 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
10174 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
10177 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
10179 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
10181 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
10183 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
10185 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
10187 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
10188 * charset.c (Fdefine_charset_internal): Don't initialize
10189 charset.code_space[15]. The value was garbage, on hosts with
10190 32-bit int (Bug#8600).
10192 * lread.c (read_integer): Be more consistent with string-to-number.
10193 Use string_to_number to do the actual conversion; this avoids
10194 rounding errors and fixes some other screwups. Without this fix,
10195 for example, #x1fffffffffffffff was misread as -2305843009213693952.
10196 (digit_to_number): Move earlier, for benefit of read_integer.
10197 Return -1 if the digit is out of range for the base, -2 if it is
10198 not a digit in any supported base. (Bug#8602)
10200 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
10202 * dispnew.c (scrolling_window): Return 1 if we scrolled,
10203 to match comment at start of function. This also removes a
10204 GCC warning about overflow in a 32+64-bit port.
10206 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
10208 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
10209 Reported by Stefan Monnier in
10210 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
10211 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10212 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
10214 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
10215 (EMACS_UINTPTR): Likewise, with uintptr_t.
10217 * lisp.h: Prefer 64-bit EMACS_INT if available.
10218 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
10219 on 32-bit hosts that have 64-bit int, so that they can access
10221 However, temporarily disable this change unless the temporary
10222 symbol WIDE_EMACS_INT is defined.
10224 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
10226 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
10227 This removes an assumption that EMACS_INT and long are the same
10228 width as pointers. The assumption is true for Emacs porting targets
10229 now, but we want to make other targets possible.
10230 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
10231 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
10232 In the rest of the code, change types of integers that hold casted
10233 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
10234 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
10235 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
10236 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
10237 No need to cast type when ORing.
10238 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
10239 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
10240 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
10241 assume EMACS_INT is the same width as char *.
10242 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
10243 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
10244 Remove no-longer-needed casts.
10245 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
10246 (xg_tool_bar_help_callback, xg_make_tool_item):
10247 Use EMACS_INTPTR to hold an integer
10248 that will be cast to void *; this can avoid a GCC warning
10249 if EMACS_INT is not the same width as void *.
10250 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
10251 * xdisp.c (display_echo_area_1, resize_mini_window_1):
10252 (current_message_1, set_message_1):
10253 Use a local to convert to proper width without a cast.
10254 * xmenu.c (dialog_selection_callback): Likewise.
10256 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
10257 Also, don't assume VALBITS / RAND_BITS is less than 5,
10258 and don't rely on undefined behavior when shifting a 1 left into
10260 * lisp.h (get_random): Change signature to match.
10262 * lread.c (hash_string): Use size_t, not int, for hash computation.
10263 Normally we prefer signed values; but hashing is special, because
10264 it's better to use unsigned division on hash table sizes so that
10265 the remainder is nonnegative. Also, size_t is the natural width
10266 for hashing into memory. The previous code used 'int', which doesn't
10267 retain enough info to hash well into very large tables.
10268 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
10270 * dbusbind.c: Don't possibly lose pointer info when converting.
10271 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10272 Use XPNTR rather than XHASH, so that the high-order bits of
10273 the pointer aren't lost when converting through void *.
10275 * eval.c (Fautoload): Don't double-shift a pointer.
10277 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
10279 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
10281 * gnutls.c (DEF_GNUTLS_FN):
10282 * image.c (DEF_IMGLIB_FN): Make function pointers static.
10284 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
10286 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
10289 2011-05-05 Eli Zaretskii <eliz@gnu.org>
10291 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
10292 New version that can reserve upto 2GB of heap space.
10294 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
10296 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
10298 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
10300 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
10301 `gnutls_certificate_set_x509_key_file'.
10303 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
10305 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
10306 Update dependencies.
10308 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
10310 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
10311 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
10312 Remove unused parameter `fildes'.
10313 * process.c (read_process_output, send_process): Don't pass it.
10315 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
10317 Fix previous change: the library cache is defined in w32.c.
10318 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
10319 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
10321 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
10323 Implement dynamic loading of GnuTLS on Windows.
10325 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
10326 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
10327 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10330 * gnutls.c (Qgnutls_dll): Define.
10331 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
10332 (gnutls_*): Declare function pointers.
10333 (init_gnutls_functions): New function to initialize function pointers.
10334 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
10335 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
10336 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10337 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
10338 (emacs_gnutls_write, emacs_gnutls_read)
10339 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
10340 (Fgnutls_available_p): New function.
10341 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
10342 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
10343 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
10345 * image.c: Include w32.h.
10346 (Vimage_type_cache): Delete.
10347 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
10348 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
10349 (w32_delayed_load): Move to w32.c.
10351 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
10353 * w32.c (QCloaded_from, Vlibrary_cache): Define.
10354 (w32_delayed_load): Move from image.c. When loading a library, record
10355 its filename in the :loaded-from property of the library id.
10356 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
10357 Initialize and staticpro them.
10358 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
10360 * process.c: Include lisp.h before w32.h, not after.
10361 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
10362 instead of gnutls_record_check_pending.
10364 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
10366 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
10368 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
10369 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
10372 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
10374 * xterm.c (x_set_frame_alpha): Do not set property on anything
10375 else than FRAME_X_OUTER_WINDOW (Bug#8608).
10377 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
10379 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
10381 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
10383 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
10384 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
10385 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
10386 (gnutls_global_initialized, Qgnutls_bootprop_priority)
10387 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
10388 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
10389 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
10390 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
10391 (Qgnutls_bootprop_callbacks_verify): Make static.
10393 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
10395 * callproc.c: Indentation fixup.
10397 * sysdep.c (wait_for_termination_1): Make static.
10398 (wait_for_termination, interruptible_wait_for_termination):
10399 Move after wait_for_termination_1.
10401 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
10403 * sysdep.c (interruptible_wait_for_termination): New function
10404 which is like wait_for_termination, but allows keyboard
10407 * callproc.c (Fcall_process): Add (:file "file") as an option for
10409 (Fcall_process_region): Ditto.
10411 2011-04-30 Eli Zaretskii <eliz@gnu.org>
10413 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
10414 rather than `XVECTOR (FOO)->size'.
10416 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
10417 inttypes.h, as a gnulib replacement is used if it not available in
10420 2011-04-21 Eli Zaretskii <eliz@gnu.org>
10422 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
10423 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
10424 of MOST_POSITIVE_FIXNUM. (Bug#8528)
10426 * coding.c (coding_alloc_by_realloc): Error out if destination
10427 will grow beyond MOST_POSITIVE_FIXNUM.
10428 (decode_coding_emacs_mule): Abort if there isn't enough place in
10429 charbuf for the composition carryover bytes. Reserve an extra
10430 space for up to 2 characters produced in a loop.
10431 (decode_coding_iso_2022): Abort if there isn't enough place in
10432 charbuf for the composition carryover bytes.
10434 2011-04-21 Eli Zaretskii <eliz@gnu.org>
10436 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
10437 aborting when %lld or %lll format is passed.
10438 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
10439 %llo or %llx format is passed. (Bug#8545)
10441 * window.c (window_scroll_line_based): Use a marker instead of
10442 simple variables to record original value of point. (Bug#7952)
10444 * doprnt.c (doprnt): Fix the case where a multibyte sequence
10445 produced by %s or %c overflows available buffer space. (Bug#8545)
10447 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
10449 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
10450 (SIZE_MAX): Move defn after all includes, as they might #define it.
10452 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
10454 * w32.c (init_environment): Warn about defaulting HOME to C:\.
10456 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
10458 * keyboard.c (Qdelayed_warnings_hook): Define.
10459 (command_loop_1): Run `delayed-warnings-hook'
10460 if Vdelayed_warnings_list is non-nil.
10461 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
10462 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
10464 2011-04-28 Eli Zaretskii <eliz@gnu.org>
10466 * doprnt.c (doprnt): Don't return value smaller than the buffer
10467 size if the message was truncated. (Bug#8545).
10469 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
10471 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
10472 (Fx_window_property): #if-0 the whole functions, not just the bodies.
10474 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10476 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
10478 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
10480 * makefile.w32-in: Update dependencies.
10482 2011-04-27 Eli Zaretskii <eliz@gnu.org>
10484 Improve `doprnt' and its usage. (Bug#8545)
10485 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
10486 `format_end'. Remove support for %l as a conversion specifier.
10487 Don't use xrealloc. Improve diagnostics when the %l size modifier
10488 is used. Update the commentary.
10490 * eval.c (verror): Simplify calculation of size_t.
10492 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
10495 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
10497 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
10500 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10502 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
10503 This makes this file independent of the recent pseudovector change.
10505 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
10507 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
10509 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
10510 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
10511 Remove unused local.
10512 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
10514 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
10515 GCC 4.6.0 optimizes based on type-based alias analysis.
10516 For example, if b is of type struct buffer * and v of type struct
10517 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
10518 != &v->size, and therefore "v->size = 1; b->size = 2; return
10519 v->size;" must therefore return 1. This assumption is incorrect
10520 for Emacs, since it type-puns struct Lisp_Vector * with many other
10521 types. To fix this problem, this patch adds a new type struct
10522 vectorlike_header that documents the constraints on layout of vectors
10523 and pseudovectors, and helps optimizing compilers not get fooled
10524 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
10525 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
10526 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
10528 (XSETPVECTYPE): Rewrite in terms of new macro.
10529 (XSETPVECTYPESIZE): New macro, specifying both type and size.
10530 This is a bit clearer, and further avoids the possibility of
10531 undesirable aliasing.
10532 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
10533 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
10534 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
10535 since Lisp_Subr is a special case (no "next" field).
10536 (ASIZE): Now uses header.size rather than size.
10537 All previous uses of XVECTOR (foo)->size replaced to use this macro,
10538 to avoid the hassle of writing XVECTOR (foo)->header.size.
10539 (struct vectorlike_header): New type.
10540 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
10541 object, to help avoid aliasing.
10542 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
10543 (SUBRP): Likewise, since Lisp_Subr is a special case.
10544 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
10545 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
10546 (struct Lisp_Hash_Table): Combine first two members into a single
10547 struct vectorlike_header member. All uses of "size" and "next" members
10548 changed to be "header.size" and "header.next".
10549 * buffer.h (struct buffer): Likewise.
10550 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
10551 * frame.h (struct frame): Likewise.
10552 * process.h (struct Lisp_Process): Likewise.
10553 * termhooks.h (struct terminal): Likewise.
10554 * window.c (struct save_window_data, struct saved_window): Likewise.
10555 * window.h (struct window): Likewise.
10556 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
10557 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
10558 * buffer.c (init_buffer_once): Likewise.
10559 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
10561 * process.c (Fformat_network_address): Use local var for size,
10564 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
10566 Make the Lisp reader and string-to-float more consistent (Bug#8525)
10567 * data.c (atof): Remove decl; no longer used or needed.
10568 (digit_to_number): Move to lread.c.
10569 (Fstring_to_number): Use new string_to_number function, to be
10570 consistent with how the Lisp reader treats infinities and NaNs.
10571 Do not assume that floating-point numbers represent EMACS_INT
10572 without losing information; this is not true on most 64-bit hosts.
10573 Avoid double-rounding errors, by insisting on integers when
10574 parsing non-base-10 numbers, as the documentation specifies.
10575 * lisp.h (string_to_number): New decl, replacing ...
10576 (isfloat_string): Remove.
10577 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
10578 (read1): Do not accept +. and -. as integers; this
10579 appears to have been a coding error. Similarly, do not accept
10580 strings like +-1e0 as floating point numbers. Do not report
10581 overflow for integer overflows unless the base is not 10 which
10582 means we have no simple and reliable way to continue.
10583 Break out the floating-point parsing into a new
10584 function string_to_number, so that Fstring_to_number parses
10585 floating point numbers consistently with the Lisp reader.
10586 (digit_to_number): Move here from data.c. Make it static inline.
10587 (E_CHAR, EXP_INT): Remove, replacing with ...
10588 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
10589 (string_to_number): New function, replacing isfloat_string.
10590 This function checks for valid syntax and produces the resulting
10591 Lisp float number too. Rework it so that string-to-number
10592 no longer mishandles examples like "1.0e+". Use strtoumax,
10593 so that overflow for non-base-10 numbers is reported only when
10594 there's no portable and simple way to convert to floating point.
10596 * textprop.c (set_text_properties_1): Rewrite for clarity,
10597 and to avoid GCC warning about integer overflow.
10599 * intervals.h (struct interval): Use EMACS_INT for members
10600 where EMACS_UINT might cause problems. See
10601 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
10602 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
10603 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
10605 (offset_intervals): Tell GCC not to worry about length overflow
10606 when negating a negative length.
10608 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
10609 (overrun_check_free): Likewise.
10611 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
10612 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
10615 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10616 (gnutls_make_error): Rename local to avoid shadowing.
10617 (gnutls_emacs_global_deinit): ifdef out; not used.
10618 (Fgnutls_boot): Use const for pointer to readonly storage.
10619 Comment out unused local. Fix pointer signedness problems.
10621 * lread.c (openp): Don't stuff size_t into an 'int'.
10622 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
10623 about possible signed overflow.
10625 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10626 (GDK_KEY_g): Don't define if already defined.
10627 (xg_prepare_tooltip): Avoid pointer signedness problem.
10628 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
10630 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
10631 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
10633 * xfns.c (Fx_window_property): Simplify a bit,
10634 to make a bit faster and to avoid GCC 4.6.0 warning.
10635 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
10637 * fns.c (internal_equal): Don't assume size_t fits in int.
10639 * alloc.c (compact_small_strings): Tighten assertion a little.
10641 Replace pEd with more-general pI, and fix some printf arg casts.
10642 * lisp.h (pI): New macro, generalizing old pEd macro to other
10643 conversion specifiers. For example, use "...%"pI"d..." rather
10644 than "...%"pEd"...".
10645 (pEd): Remove. All uses replaced with similar uses of pI.
10646 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
10647 * alloc.c (check_pure_size): Don't overflow by converting size to int.
10648 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
10649 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
10650 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
10651 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
10652 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
10654 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
10655 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
10656 * print.c (safe_debug_print, print_object): Likewise.
10657 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
10659 Use pI instead of if-then-else-abort. Use %p to avoid casts,
10660 avoiding the 0 flag, which is not portable.
10661 * process.c (Fmake_network_process): Use pI to avoid cast.
10662 * region-cache.c (pp_cache): Likewise.
10663 * xdisp.c (decode_mode_spec): Likewise.
10664 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
10665 behavior on 64-bit hosts with printf arg.
10666 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
10667 (x_stop_queuing_selection_requests): Likewise.
10668 (x_get_window_property): Don't truncate byte count to an 'int'
10671 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
10672 here, since it parses constructs like leading '-' and spaces,
10673 which are not wanted; and it overflows with large numbers.
10674 Instead, simply match F[0-9]+, which is what is wanted anyway.
10676 * alloc.c: Remove unportable assumptions about struct layout.
10677 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
10678 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
10679 (allocate_vectorlike, make_pure_vector): Use the new macros,
10680 plus offsetof, to remove unportable assumptions about struct layout.
10681 These assumptions hold on all porting targets that I know of, but
10682 they are not guaranteed, they're easy to remove, and removing them
10683 makes further changes easier.
10685 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
10686 This doesn't fix a bug but makes the code clearer.
10687 (string_overrun_cookie): Now const. Use initializers that
10688 don't formally overflow signed char, to avoid warnings.
10689 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
10690 can cause Emacs to crash when string overrun checking is enabled.
10691 (allocate_buffer): Don't assume sizeof (struct buffer) is a
10692 multiple of sizeof (EMACS_INT); it need not be, if
10693 alignof(EMACS_INT) < sizeof (EMACS_INT).
10694 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
10696 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
10698 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
10700 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
10702 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
10703 supposed to be handshaking. (Bug#8556)
10704 Reported by Paul Eggert <eggert@cs.ucla.edu>.
10706 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
10708 * lisp.h (Qdebug): List symbol.
10709 * eval.c (Qdebug): Restore global linkage.
10710 * keyboard.c (debug-on-event): New variable.
10711 (handle_user_signal): Break into debugger when debug-on-event
10712 matches the current signal symbol.
10714 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
10716 * alloc.c (check_sblock, check_string_bytes)
10717 (check_string_free_list): Convert to standard C.
10719 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
10721 * w32.c (emacs_gnutls_push): Fix typo.
10723 2011-04-25 Eli Zaretskii <eliz@gnu.org>
10725 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
10726 "cast to pointer from integer of different size".
10728 Improve doprnt and its use in verror. (Bug#8545)
10729 * doprnt.c (doprnt): Document the set of format control sequences
10730 supported by the function. Use SAFE_ALLOCA instead of always
10733 * eval.c (verror): Don't limit the buffer size at size_max-1, that
10734 is one byte too soon. Don't use xrealloc; instead xfree and
10737 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
10739 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
10742 * gnutls.c: Renamed global_initialized to
10743 gnutls_global_initialized. Added internals for the
10744 :verify-hostname-error, :verify-error, and :verify-flags
10745 parameters of `gnutls-boot' and documented those parameters in the
10746 docstring. Start callback support.
10747 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
10748 unless a fatal error occurred. Call gnutls_alert_send_appropriate
10749 on error. Return error code.
10750 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
10751 (emacs_gnutls_read): Likewise.
10752 (Fgnutls_boot): Return handshake error code.
10753 (emacs_gnutls_handle_error): New function.
10754 (wsaerror_to_errno): Likewise.
10756 * w32.h (emacs_gnutls_pull): Add prototype.
10757 (emacs_gnutls_push): Likewise.
10759 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
10760 (emacs_gnutls_push): Likewise.
10762 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
10764 * process.c (wait_reading_process_output): Check if GnuTLS
10765 buffered some data internally if no FDs are set for TLS
10768 * makefile.w32-in (OBJ2): Add gnutls.$(O).
10769 (LIBS): Link to USER_LIBS.
10770 ($(BLD)/gnutls.$(0)): New target.
10772 2011-04-24 Eli Zaretskii <eliz@gnu.org>
10774 * xdisp.c (handle_single_display_spec): Rename the
10775 display_replaced_before_p argument into display_replaced_p, to
10776 make it consistent with the commentary. Fix typos in the
10779 * textprop.c (syms_of_textprop): Remove dead code.
10780 (copy_text_properties): Delete obsolete commentary about an
10781 interface that was deleted long ago. Fix typos in the description
10784 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
10785 to changes in oldXMenu/XMenu.h from 2011-04-16.
10786 <menu_help_message, prev_menu_help_message>: Constify.
10787 (IT_menu_make_room): menu->help_text is now `const char **';
10790 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
10791 to changes in oldXMenu/XMenu.h from 2011-04-16.
10792 (struct XMenu): Declare `help_text' `const char **'.
10794 * xfaces.c <Qunspecified>: Make extern again.
10796 * syntax.c: Include sys/types.h before including regex.h, as
10799 * doc.c (get_doc_string): Improve the format passed to `error'.
10801 * doprnt.c (doprnt): Improve commentary.
10803 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
10805 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
10808 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
10809 changes in globals.h immediately force recompilation.
10810 (TAGS): Depend on $(CURDIR)/m/intel386.h and
10811 $(CURDIR)/s/ms-w32.h.
10812 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
10814 * character.c (Fchar_direction): Function deleted.
10815 (syms_of_character): Don't defsubr it.
10816 <char-direction-table>: Deleted.
10818 2011-04-23 Eli Zaretskii <eliz@gnu.org>
10820 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
10821 * doprnt.c: Include limits.h.
10822 (SIZE_MAX): New macro.
10823 (doprnt): Return a size_t value. 2nd arg is now size_t.
10824 Many local variables are now size_t instead of int or unsigned.
10825 Improve overflow protection. Support `l' modifier for integer
10826 conversions. Support %l conversion. Don't assume an EMACS_INT
10827 argument for integer conversions and for %c.
10829 * lisp.h (doprnt): Restore prototype.
10831 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
10832 $(SRC)/character.h.
10834 * Makefile.in (base_obj): Add back doprnt.o.
10836 * deps.mk (doprnt.o): Add back prerequisites.
10837 (callint.o): Depend on character.h.
10839 * eval.c (internal_lisp_condition_case): Include the handler
10840 representation in the error message.
10841 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
10842 when breaking from the loop.
10844 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
10846 * callint.c (Fcall_interactively): When displaying error message
10847 about invalid control letter, pass the character's codepoint, not
10848 a pointer to its multibyte form. Improve display of the character
10849 in octal and display also its hex code.
10851 * character.c (char_string): Use %x to display the (unsigned)
10852 codepoint of an invalid character, to avoid displaying a bogus
10855 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
10856 `error', not SYMBOL_NAME itself.
10858 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
10859 character arguments to `error'.
10861 * charset.c (check_iso_charset_parameter): Fix incorrect argument
10862 to `error' in error message about FINAL_CHAR argument. Make sure
10863 FINAL_CHAR is a character, and use %c when it is passed as
10864 argument to `error'.
10866 2011-04-23 Eli Zaretskii <eliz@gnu.org>
10868 * s/ms-w32.h (localtime): Redirect to sys_localtime.
10870 * w32.c: Include <time.h>.
10871 (sys_localtime): New function.
10873 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
10875 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
10877 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
10879 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
10881 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
10882 zombies (Bug#8467).
10884 2011-04-19 Eli Zaretskii <eliz@gnu.org>
10886 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
10887 gl_state.e_property when gl_state.object is Qt.
10889 * insdel.c (make_gap_larger): Remove limitation of buffer size
10892 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
10894 * xdisp.c (lookup_glyphless_char_display)
10895 (produce_glyphless_glyph): Handle cons cell entry in
10896 glyphless-char-display.
10897 (Vglyphless_char_display): Document it.
10899 * term.c (produce_glyphless_glyph): Handle cons cell entry in
10900 glyphless-char-display.
10902 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
10904 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
10906 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
10908 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
10909 definition for no-X builds.
10911 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
10913 Static checks with GCC 4.6.0 and non-default toolkits.
10915 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
10917 * process.c (keyboard_bit_set): Define only if SIGIO.
10918 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
10919 (send_process): Repair possible setjmp clobbering.
10921 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
10923 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
10925 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
10927 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
10928 Define only if needed.
10930 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
10931 by pacifying GCC about it. Maybe it's time to retire it?
10932 * xfaces.c (USG, __TIMEVAL__): Likewise.
10934 * dispextern.h (struct redisplay_interface): Rename param
10935 to avoid shadowing.
10936 * termhooks.h (struct terminal): Likewise.
10937 * xterm.c (xembed_send_message): Likewise.
10939 * insdel.c (make_gap_smaller): Define only if
10940 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
10942 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
10945 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
10946 so that we aren't warned about unused symbols.
10948 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
10950 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
10952 * xfns.c (x_real_positions): Mark locals as initialized.
10954 * xmenu.c (xmenu_show): Don't use uninitialized vars.
10956 * xterm.c: Fix problems found by static analysis with other toolkits.
10957 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
10958 (x_dispatch_event): Declare static if USE_GTK, and
10959 define if USE_GTK || USE_X_TOOLKIT.
10960 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
10961 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
10962 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
10963 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
10965 * xmenu.c (menu_help_callback): Pointer type fixes.
10966 Use const pointers when pointing at readonly data. Avoid pointer
10967 signedness clashes.
10968 (FALSE): Remove unused macro.
10969 (update_frame_menubar): Remove unused decl.
10971 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
10973 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
10974 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
10975 (single_menu_item): Rename local to avoid shadowing.
10977 * keyboard.c (make_lispy_event): Remove unused local var.
10979 * frame.c, frame.h (x_get_resource_string): Bring this back, but
10980 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
10982 * bitmaps: Change bitmaps from unsigned char back to the X11
10983 compatible char. Avoid the old compiler warnings about
10984 out-of-range initializers by using, for example, '\xab' rather
10987 * xgselect.c (xgselect_initialize): Check vs interface
10988 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
10990 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
10992 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
10993 to read-only memory.
10995 * fns.c (vector): Remove; this old hack is no longer needed.
10997 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
10999 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
11001 * xrdb.c (x_load_resources): Omit unused local.
11003 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
11004 (x_window): Rename locals to avoid shadowing.
11005 (USG): Use the kludged USG macro, to pacify gcc.
11007 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
11008 (x_term_init): Remove local to avoid shadowing.
11010 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
11012 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
11013 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
11015 2011-04-16 Eli Zaretskii <eliz@gnu.org>
11017 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
11019 Fix regex.c, syntax.c and friends for buffers > 2GB.
11020 * syntax.h (struct gl_state_s): Declare character position members
11023 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
11025 * textprop.c (verify_interval_modification, interval_of):
11026 Declare arguments EMACS_INT.
11028 * intervals.c (adjust_intervals_for_insertion): Declare arguments
11031 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
11033 * indent.c (Fvertical_motion): Local variable it_start is now
11036 * regex.c (re_match, re_match_2, re_match_2_internal)
11037 (bcmp_translate, regcomp, regexec, print_double_string)
11038 (group_in_compile_stack, re_search, re_search_2, regex_compile)
11039 (re_compile_pattern, re_exec): Declare arguments and local
11040 variables `size_t' and `ssize_t' and return values `regoff_t', as
11042 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
11043 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
11044 <compile_stack_type>: `size' and `avail' are now `size_t'.
11046 * regex.h <regoff_t>: Use ssize_t, not int.
11047 (re_search, re_search_2, re_match, re_match_2): Arguments that
11048 specify buffer/string position and length are now ssize_t and
11049 size_t. Return type is regoff_t.
11051 2011-04-16 Ben Key <bkey76@gmail.com>
11053 * nsfont.m: Fixed bugs in ns_get_family and
11054 ns_descriptor_to_entity that were caused by using free to
11055 deallocate memory blocks that were allocated by xmalloc (via
11056 xstrdup). This caused Emacs to crash when compiled with
11057 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
11058 --enable-checking=xmallocoverrun). xfree is now used to
11059 deallocate these memory blocks.
11061 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
11063 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
11065 emacs_write: Accept and return EMACS_INT for sizes.
11066 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
11068 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
11069 Accept and return EMACS_INT.
11070 (emacs_gnutls_write): Return the number of bytes written on
11072 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
11073 (emacs_read, emacs_write): Remove check for negative size, as the
11074 Emacs source code has been audited now.
11075 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
11076 (emacs_read, emacs_write): Use it.
11077 * process.c (send_process): Adjust to the new signatures of
11078 emacs_write and emacs_gnutls_write. Do not attempt to store
11079 a byte offset into an 'int'; it might overflow.
11080 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
11082 * sound.c: Don't assume sizes fit in 'int'.
11083 (struct sound_device.period_size, alsa_period_size):
11084 Return EMACS_INT, not int.
11085 (struct sound_device.write, vox_write, alsa_write):
11086 Accept EMACS_INT, not int.
11087 (wav_play, au_play): Use EMACS_INT to store sizes and to
11088 record read return values.
11090 2011-04-15 Ben Key <bkey76@gmail.com>
11092 * keyboard.c (Qundefined): Don't declare static since it is used
11094 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
11095 static since they are used in nsfont.m.
11097 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
11099 * process.c (Qprocessp): Don't declare static.
11100 * lisp.h (Qprocessp): Declare again.
11102 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
11104 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
11106 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
11108 Improve C-level modularity by making more things 'static'.
11110 Don't publish debugger-only interfaces to other modules.
11111 * lisp.h (safe_debug_print, debug_output_compilation_hack):
11112 (verify_bytepos, count_markers): Move decls to the only modules
11114 * region-cache.h (pp_cache): Likewise.
11115 * window.h (check_all_windows): Likewise.
11116 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
11118 * sysdep.c (croak): Now static, if
11119 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
11120 * syssignal.h (croak): Declare only if not static.
11122 * alloc.c (refill_memory_reserve): Now static if
11123 !defined REL_ALLOC || defined SYSTEM_MALLOC.
11124 * lisp.h (refill_memory_reserve): Declare only if not static.
11126 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
11127 Define only if USE_LUCID.
11129 * xrdb.c (x_customization_string, x_rm_string): Now static.
11131 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
11132 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
11134 * xdisp.c (draw_row_with_mouse_face): Now static.
11135 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
11137 * window.h (check_all_windows): Mark externally visible.
11139 * window.c (window_deletion_count): Now static.
11141 * undo.c: Make symbols static if they're not exported.
11142 (last_undo_buffer, last_boundary_position, pending_boundary):
11145 * textprop.c (interval_insert_behind_hooks): Now static.
11146 (interval_insert_in_front_hooks): Likewise.
11148 * term.c: Make symbols static if they're not exported.
11149 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
11150 (max_frame_lines, tty_set_terminal_modes):
11151 (tty_reset_terminal_modes, tty_turn_off_highlight):
11152 (get_tty_terminal): Now static.
11153 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
11154 * termhooks.h (term_mouse_moveto): Do not declare if
11155 HAVE_WINDOW_SYSTEM.
11156 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
11157 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
11159 * sysdep.c: Make symbols static if they're not exported.
11160 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
11162 (sigprocmask_set, full_mask): Remove; unused.
11163 (wait_debugging): Mark as visible.
11164 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
11165 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
11167 * syntax.c (syntax_temp): Define only if !__GNUC__.
11169 * sound.c (current_sound_device, current_sound): Now static.
11171 * search.c (searchbufs, searchbuf_head): Now static.
11173 * scroll.c (scroll_cost): Remove; unused.
11174 * dispextern.h (scroll_cost): Remove decl.
11176 * region-cache.h (pp_cache): Mark as externally visible.
11178 * process.c: Make symbols static if they're not exported.
11179 (process_tick, update_tick, create_process, chan_process):
11180 (Vprocess_alist, proc_buffered_char, datagram_access):
11181 (fd_callback_data, send_process_frame, process_sent_to): Now static.
11182 (deactivate_process): Mark defn as static, as well as decl.
11183 * lisp.h (create_process): Remove decl.
11184 * process.h (chan_process, Vprocess_alist): Remove decls.
11186 * print.c: Make symbols static if they're not exported.
11187 (print_depth, new_backquote_output, being_printed, print_buffer):
11188 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
11189 (print_interval, print_number_index, initial_stderr_stream):
11191 * lisp.h (Fprinc): Remove decl.
11192 (debug_output_compilation_hack): Mark as externally visible.
11194 * sysdep.c (croak): Move decl from here to syssignal.h.
11195 * syssignal.h (croak): Put it here, so the API can be checked when
11196 'croak' is called from dissociate_if_controlling_tty.
11198 * minibuf.c: Make symbols static if they're not exported.
11199 (minibuf_save_list, choose_minibuf_frame): Now static.
11200 * lisp.h (choose_minibuf_frame): Remove decl.
11202 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
11204 * lread.c: Make symbols static if they're not exported.
11205 (read_objects, initial_obarray, oblookup_last_bucket_number):
11207 (make_symbol): Remove; unused.
11208 * lisp.h (initial_obarray, make_symbol): Remove decls.
11210 * keyboard.c: Make symbols static if they're not exported.
11211 (single_kboard, recent_keys_index, total_keys, recent_keys):
11212 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
11213 (this_single_command_key_start, echoing, last_auto_save):
11214 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
11215 (command_loop, echo_now, keyboard_init_hook, help_char_p):
11216 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
11217 (Vlispy_mouse_stem, double_click_count):
11219 (force_auto_save_soon): Define only if SIGDANGER.
11220 (ignore_mouse_drag_p): Now static if
11221 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
11222 (print_help): Remove; unused.
11223 (stop_character, last_timer_event): Mark as externally visible.
11224 * keyboard.h (ignore_mouse_drag_p): Declare only if
11225 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
11226 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
11227 * lisp.h (echoing): Remove decl.
11228 (force_auto_save_soon): Declare only if SIGDANGER.
11229 * xdisp.c (redisplay_window): Simplify code, to make it more
11230 obvious that ignore_mouse_drag_p is not accessed if !defined
11231 USE_GTK && !defined HAVE_NS.
11233 * intervals.c: Make symbols static if they're not exported.
11234 (merge_properties_sticky, merge_interval_right, delete_interval):
11236 * intervals.h (merge_interval_right, delete_interval): Remove decls.
11238 * insdel.c: Make symbols static if they're not exported.
11239 However, leave prepare_to_modify_buffer alone. It's never
11240 called from outside this function, but that appears to be a bug.
11241 (combine_after_change_list, combine_after_change_buffer):
11242 (adjust_after_replace, signal_before_change): Now static.
11243 (adjust_after_replace_noundo): Remove; unused.
11244 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
11245 (signal_before_change): Remove decls.
11247 * indent.c (val_compute_motion, val_vmotion): Now static.
11249 * image.c: Make symbols static if they're not exported.
11250 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
11252 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
11253 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
11255 * fringe.c (standard_bitmaps): Now static.
11256 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
11258 * frame.c: Make symbols static if they're not exported.
11259 (x_report_frame_params, make_terminal_frame): Now static.
11260 (get_frame_param): Now static, unless HAVE_NS.
11261 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
11262 (x_get_resource_string): Remove; not used.
11263 * frame.h (make_terminal_frame, x_report_frame_params):
11264 (x_get_resource_string); Remove decls.
11265 (x_fullscreen_adjust): Declare only if WINDOWSNT.
11266 * lisp.h (get_frame_param): Declare only if HAVE_NS.
11268 * font.c, fontset.c: Make symbols static if they're not exported.
11269 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
11270 (FACE_SUITABLE_FOR_CHAR_P): Use it.
11271 * font.c (font_close_object): Now static.
11272 * font.h (font_close_object): Remove.
11273 * fontset.c (FONTSET_OBJLIST): Remove.
11274 (free_realized_fontset) #if-0 the body, which does nothing.
11275 (face_suitable_for_char_p): #if-0, as it's never called.
11276 * fontset.h (face_suitable_for_char_p): Remove decl.
11277 * xfaces.c (face_at_string_position):
11278 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
11279 since 0 is always ASCII.
11281 * fns.c (weak_hash_tables): Now static.
11283 * fileio.c: Make symbols static if they're not exported.
11284 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
11285 (Vwrite_region_annotation_buffers): Now static.
11287 * eval.c: Make symbols static if they're not exported.
11288 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
11289 * lisp.h (backtrace_list): Remove decl.
11291 * emacs.c: Make symbols static if they're not exported.
11292 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
11293 (fatal_error_code, fatal_error_signal_hook, standard_args):
11295 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
11296 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
11297 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
11298 * lisp.h (fatal_error_signal_hook): Remove decl.
11299 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
11301 * editfns.c: Move a (normally-unused) function to its only use.
11302 * editfns.c, lisp.h (get_operating_system_release): Remove.
11303 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
11304 worth the hassle of breaking this out.
11306 * xterm.c: Make symbols static if they're not exported.
11307 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
11308 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
11309 (x_destroy_window, x_delete_display):
11311 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
11312 (x_mouse_leave): Remove; unused.
11313 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
11314 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
11315 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
11317 (x_mouse_leave): Declare only if WINDOWSNT.
11318 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
11319 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
11322 * ftxfont.c: Make symbols static if they're not exported.
11323 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
11325 * font.h (ftxfont_driver): Likewise.
11327 * xfns.c: Make symbols static if they're not exported.
11328 (x_last_font_name, x_display_info_for_name):
11329 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
11330 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
11331 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
11332 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
11333 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
11334 (last_show_tip_args): Now static.
11335 (xic_defaut_fontset, xic_create_fontsetname): Define only if
11336 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
11337 (x_screen_planes): Remove; unused.
11338 * dispextern.h (x_screen_planes): Remove decl.
11340 * dispnew.c: Make symbols static if they're not exported.
11341 * dispextern.h (redraw_garbaged_frames, scrolling):
11342 (increment_row_positions): Remove.
11343 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
11344 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
11346 (redraw_garbaged_frames): Remove; unused.
11348 * xfaces.c: Make symbols static if they're not exported.
11349 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
11351 * xterm.h (defined_color): Remove decls.
11352 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
11353 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
11354 (menu_face_changed_default, defined_color, free_realized_face):
11355 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
11356 (ascii_face_of_lisp_face): Remove; unused.
11358 * xdisp.c: Make symbols static if they're not exported.
11359 * dispextern.h (scratch_glyph_row, window_box_edges):
11360 (glyph_to_pixel_coords, set_cursor_from_row):
11361 (get_next_display_element, set_iterator_to_next):
11362 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
11363 (show_mouse_face): Remove decls
11364 * frame.h (message_buf_print): Likewise.
11365 * lisp.h (pop_message, set_message, check_point_in_composition):
11367 * xterm.h (set_vertical_scroll_bar): Likewise.
11368 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
11369 (message_buf_print, scratch_glyph_row, displayed_buffer):
11370 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
11371 (get_next_display_element, show_mouse_face, window_box_edges):
11372 (frame_to_window_pixel_xy, check_point_in_composition):
11373 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
11374 (glyph_to_pixel_coords): Remove; unused.
11376 * dired.c (file_name_completion): Now static.
11378 * dbusbind.c (xd_in_read_queued_messages): Now static.
11380 * lisp.h (circular_list_error, FOREACH): Remove; unused.
11381 * data.c (circular_list_error): Remove.
11383 * commands.h (last_point_position, last_point_position_buffer):
11384 (last_point_position_window): Remove decls.
11385 * keyboard.c: Make these variables static.
11387 * coding.h (coding, code_convert_region, encode_coding_gap):
11389 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
11390 (iso_code_class, detect_coding, code_convert_region): Now static.
11391 (encode_coding_gap): Remove; unused.
11393 * chartab.c (chartab_chars, chartab_bits): Now static.
11395 * charset.h (charset_iso_8859_1): Remove decl.
11396 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
11399 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
11400 * ccl.c (Vccl_program_table): Now static.
11401 (check_ccl_update): Remove; unused.
11403 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
11404 * category.h: ... from here.
11405 * category.c (check_category_table, set_category_set): Now static.
11407 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
11408 * lisp.h: Remove these decls.
11410 * buffer.c (buffer_count): Remove unused var.
11412 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
11413 so that it's not optimized away.
11414 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
11415 * dispextern.h (bidi_dump_cached_states): Remove, since it's
11416 exported only to the debugger.
11418 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
11419 * atimer.h (run_all_atimers): Remove; not exported.
11421 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
11422 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
11423 was inaccessible from Lisp.
11424 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
11425 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
11427 alloc.c: Import and export fewer symbols, and remove unused items.
11428 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
11430 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
11431 it's not optimized away by whole-program optimization.
11432 (message_enable_multibyte, free_misc): Remove.
11433 (catchlist, handlerlist, mark_backtrace):
11434 Declare only if BYTE_MARK_STACK.
11435 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
11436 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
11437 (message_enable_multibyte): Remove decl.
11438 (free_misc, interval_free_list, float_block, float_block_index):
11439 (n_float_blocks, float_free_list, cons_block, cons_block_index):
11440 (cons_free_list, last_marked_index):
11442 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
11443 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
11444 (mark_backtrace): Define only if BYTE_MARK_STACK.
11445 * xdisp.c (message_enable_multibyte): Now static.
11447 Declare Lisp_Object Q* variables to be 'static' if not exported.
11448 This makes it easier for human readers (and static analyzers)
11449 to see whether these variables are used from other modules.
11450 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
11451 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
11452 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
11453 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
11454 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
11455 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
11456 * xmenu.c, xselect.c:
11457 Declare Q* vars static if they are not used in other modules.
11458 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
11459 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
11460 Remove decls of unexported vars.
11461 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
11463 * lisp.h (DEFINE_FUNC): Make sname 'static'.
11465 Make Emacs functions such as Fatom 'static' by default.
11466 This makes it easier for human readers (and static analyzers)
11467 to see whether these functions can be called from other modules.
11468 DEFUN now defines a static function. To make the function external
11469 so that it can be used in other C modules, use the new macro DEFUE.
11470 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
11471 (Finit_image_library):
11472 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
11473 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
11474 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
11475 Remove decls, since these functions are now static.
11476 (Funintern, Fget_internal_run_time): New decls, since these functions
11477 were already external.
11479 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
11480 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
11481 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
11482 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
11483 * keyboard.c, keymap.c, lread.c:
11484 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
11485 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
11486 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
11487 Mark functions with DEFUE instead of DEFUN,
11488 if they are used in other modules.
11489 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
11490 decls for now-static functions.
11491 * buffer.h (Fdelete_overlay): Remove decl.
11492 * callproc.c (Fgetenv_internal): Mark as internal.
11493 * composite.c (Fremove_list_of_text_properties): Remove decl.
11494 (Fcomposition_get_gstring): New forward static decl.
11495 * composite.h (Fcomposite_get_gstring): Remove decl.
11496 * dired.c (Ffile_attributes): New forward static decl.
11497 * doc.c (Fdocumntation_property): New forward static decl.
11498 * eval.c (Ffetch_bytecode): New forward static decl.
11499 (Funintern): Remove extern decl; now in .h file where it belongs.
11500 * fileio.c (Fmake_symbolic_link): New forward static decl.
11501 * image.c (Finit_image_library): New forward static decl.
11502 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
11503 * intervals.h (Fprevious_property_change):
11504 (Fremove_list_of_text_properties): Remove decls.
11505 * keyboard.c (Fthis_command_keys): Remove decl.
11506 (Fcommand_execute): New forward static decl.
11507 * keymap.c (Flookup_key): New forward static decl.
11508 (Fcopy_keymap): Now static.
11509 * keymap.h (Flookup_key): Remove decl.
11510 * process.c (Fget_process): New forward static decl.
11511 (Fprocess_datagram_address): Mark as internal.
11512 * syntax.c (Fsyntax_table_p): New forward static decl.
11513 (skip_chars): Remove duplicate decl.
11514 * textprop.c (Fprevious_property_change): New forward static decl.
11515 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
11517 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
11518 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
11520 * editfns.c (Fformat): Remove unreachable code.
11522 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
11524 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
11527 2011-04-13 Eli Zaretskii <eliz@gnu.org>
11529 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
11530 when at ZV. (Bug#8487)
11532 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
11534 * charset.c (Fclear_charset_maps): Use xfree instead of free.
11536 * keyboard.c (parse_tool_bar_item): Likewise.
11537 * sound.c (sound_cleanup, alsa_close): Likewise.
11538 * termcap.c (tgetent): Likewise.
11539 * xfns.c (x_default_font_parameter): Likewise.
11540 * xsettings.c (read_and_apply_settings): Likewise.
11542 * alloc.c (overrun_check_malloc, overrun_check_realloc)
11543 (overrun_check_free): Protoize.
11545 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
11547 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
11548 since callers should never pass a negative size.
11549 Change the signature to match that of plain 'read' and 'write'; see
11550 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
11551 * lisp.h: Update prototypes of emacs_write and emacs_read.
11553 2011-04-11 Eli Zaretskii <eliz@gnu.org>
11555 * xdisp.c (redisplay_window): Don't try to determine the character
11556 position of the scroll margin if the window start point w->startp
11557 is outside the buffer's accessible region. (Bug#8468)
11559 2011-04-10 Eli Zaretskii <eliz@gnu.org>
11561 Fix write-region and its subroutines for buffers > 2GB.
11562 * fileio.c (a_write, e_write): Modify declaration of arguments and
11563 local variables to support buffers larger than 2GB.
11564 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
11566 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
11567 argument, local variables, and return value.
11569 * lisp.h: Update prototypes of emacs_write and emacs_read.
11571 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
11573 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
11575 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
11577 Fix more problems found by GCC 4.6.0's static checks.
11579 * xdisp.c (vmessage): Use a better test for character truncation.
11581 * charset.c (load_charset_map): <, not <=, for optimization,
11582 and to avoid potential problems with integer overflow.
11583 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
11584 * casetab.c (set_identity, shuffle): Likewise.
11585 * editfns.c (Fformat): Likewise.
11586 * syntax.c (skip_chars): Likewise.
11588 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
11589 This also lets GCC 4.6.0 generate slightly better loop code.
11591 * callint.c (Fcall_interactively): <, not <=, for optimization.
11592 (Fcall_interactively): Count the number of arguments produced,
11593 not the number of arguments given. This is simpler and lets GCC
11594 4.6.0 generate slightly better code.
11596 * ftfont.c: Distingish more carefully between FcChar8 and char.
11597 The previous code passed unsigned char * to a functions like
11598 strlen and xstrcasecmp that expect char *, which does not
11599 conform to the C standard.
11600 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
11601 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
11602 char * when the C standard requires it.
11604 * keyboard.c (read_char): Remove unused var.
11606 * eval.c: Port to Windows vsnprintf (Bug#8435).
11607 Include <limits.h>.
11608 (SIZE_MAX): Define if the headers do not.
11609 (verror): Do not give up if vsnprintf returns a negative count.
11610 Instead, grow the buffer. This ports to Windows vsnprintf, which
11611 does not conform to C99. Problem reported by Eli Zaretskii.
11612 Also, simplify the allocation scheme, by avoiding the need for
11613 calling realloc, and removing the ALLOCATED variable.
11615 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
11617 Remove invocations of doprnt, as Emacs now uses vsnprintf.
11618 But keep the doprint source code for now, as we might revamp it
11619 and use it again (Bug#8435).
11620 * lisp.h (doprnt): Remove.
11621 * Makefile.in (base_obj): Remove doprnt.o.
11622 * deps.mk (doprnt.o): Remove.
11624 error: Print 32- and 64-bit integers portably (Bug#8435).
11625 Without this change, on typical 64-bit hosts error ("...%d...", N)
11626 was used to print both 32- and 64-bit integers N, which relied on
11627 undefined behavior.
11628 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
11629 * lisp.h (error, verror): Mark as printf-like functions.
11630 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
11631 Report overflow in size calculations when allocating printf buffer.
11632 Do not truncate output string at its first null byte.
11633 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
11634 Truncate the output at a character boundary, since vsnprintf does not
11636 * charset.c (check_iso_charset_parameter): Convert internal
11637 character to string before calling 'error', since %c now has the
11639 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
11640 overflow when computing char to be passed to 'error'. Do not
11641 pass Lisp_Object to 'error'; pass the integer instead.
11642 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
11643 formatted with plain %d.
11645 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
11647 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
11649 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
11651 * xterm.c (x_catch_errors): Remove duplicate declaration.
11653 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
11655 * xdisp.c, lisp.h (message_nolog): Remove; unused.
11657 2011-04-10 Jim Meyering <meyering@redhat.com>
11659 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
11660 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
11661 return ssize_t not "int", and use size_t as the buffer length.
11662 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
11663 * gnutls.h: Update declarations.
11664 * process.c (read_process_output): Use ssize_t, to match.
11665 (send_process): Likewise.
11667 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
11669 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
11671 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
11673 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
11674 Use unsigned char, to match FcChar8 type definition.
11676 * xterm.c (handle_one_xevent):
11677 * xmenu.c (create_and_show_popup_menu):
11678 * xselect.c (x_decline_selection_request)
11679 (x_reply_selection_request): Avoid type-punned deref of X events.
11681 2011-04-09 Eli Zaretskii <eliz@gnu.org>
11683 Fix some uses of `int' instead of EMACS_INT.
11684 * search.c (string_match_1, fast_string_match)
11685 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
11686 (scan_buffer, find_next_newline_no_quit)
11687 (find_before_next_newline, search_command, Freplace_match)
11688 (Fmatch_data): Make some `int' variables be EMACS_INT.
11690 * xdisp.c (display_count_lines): 3rd argument and return value now
11691 EMACS_INT. All callers changed.
11692 (pint2hrstr): Last argument is now EMACS_INT.
11694 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
11695 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
11696 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
11697 (decode_coding_utf_16, decode_coding_emacs_mule)
11698 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
11699 (decode_coding_ccl, decode_coding_charset)
11700 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
11701 (decode_coding_iso_2022, decode_coding_emacs_mule)
11702 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
11703 <char_offset, last_offset>: Declare EMACS_INT.
11704 (encode_coding_utf_8, encode_coding_utf_16)
11705 (encode_coding_emacs_mule, encode_invocation_designation)
11706 (encode_designation_at_bol, encode_coding_iso_2022)
11707 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
11708 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
11710 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
11711 (encode_invocation_designation): Last argument P_NCHARS is now
11713 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
11714 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
11716 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
11719 * ccl.c (Fccl_execute_on_string): Declare some variables
11722 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
11724 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
11726 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
11728 * process.c (Fformat_network_address): Doc fix.
11730 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
11732 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
11734 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
11736 * keyboard.c (read_char): Call Lisp function help-form-show,
11737 instead of using internal_with_output_to_temp_buffer.
11738 (Qhelp_form_show): New var.
11739 (syms_of_keyboard): Use DEFSYM macro.
11741 * print.c (internal_with_output_to_temp_buffer): Function deleted.
11743 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
11745 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
11747 * process.c (Flist_processes): Remove to Lisp.
11748 (list_processes_1): Delete.
11750 2011-04-06 Eli Zaretskii <eliz@gnu.org>
11752 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
11754 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
11756 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
11758 Fix more problems found by GCC 4.6.0's static checks.
11760 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
11762 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
11764 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
11766 * xdisp.c (vmessage): Mark as a printf-like function.
11768 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
11770 * sound.c (sound_warning): Don't crash if arg contains a printf format.
11772 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
11773 printf-like functions.
11774 (tiff_load): Add casts to remove these marks before passing them
11775 to system-supplied API.
11777 * eval.c (Fsignal): Remove excess argument to 'fatal'.
11779 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
11780 This avoids several warnings with gcc -Wstrict-overflow.
11781 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
11782 directly, rather than having caller test rule sign. This avoids
11783 some unnecessary tests.
11784 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
11785 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
11786 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
11788 * xfont.c (xfont_text_extents): Remove var that was set but not used.
11789 (xfont_open): Avoid unnecessary tests.
11791 * composite.c (composition_gstring_put_cache): Use unsigned integer.
11793 * composite.h, composite.c (composition_gstring_put_cache):
11794 Use EMACS_INT, not int, for length.
11796 * composite.h (COMPOSITION_DECODE_REFS): New macro,
11797 breaking out part of COMPOSITION_DECODE_RULE.
11798 (COMPOSITION_DECODE_RULE): Use it.
11799 * composite.c (get_composition_id): Remove unused local vars,
11800 by using the new macro.
11802 * textprop.c (set_text_properties_1): Change while to do-while,
11803 since the condition is always true at first.
11805 * intervals.c (graft_intervals_into_buffer): Mark var as used.
11806 (interval_deletion_adjustment): Return unsigned value.
11809 * process.c (list_processes_1, create_pty, read_process_output):
11810 (exec_sentinel): Remove vars that were set but not used.
11811 (create_pty): Remove unnecessary "volatile"s.
11812 (Fnetwork_interface_info): Avoid possibility of int overflow.
11813 (read_process_output): Do adaptive read buffering even if carryover.
11814 (read_process_output): Simplify nbytes computation if buffered.
11816 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
11818 * syntax.c (scan_words): Remove var that was set but not used.
11819 (update_syntax_table): Use unsigned instead of int.
11821 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
11822 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
11823 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
11825 * print.c (print_error_message): Avoid int overflow.
11827 * font.c (font_list_entities): Redo for clarity,
11828 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
11830 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
11831 (font_score): Avoid potential overflow in diff calculation.
11833 * fns.c (substring_both): Remove var that is set but not used.
11834 (sxhash): Redo loop for clarity and to avoid wraparound warning.
11836 * eval.c (funcall_lambda): Rename local to avoid shadowing.
11838 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
11839 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
11840 can always succeed if overflow has undefined behavior.
11842 * search.c (boyer_moore, wordify): Remove vars set but not used.
11843 (wordify): Omit three unnecessary tests.
11845 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
11846 All callers changed. This avoids the need for an unused var.
11848 * casefiddle.c (casify_region): Remove var that is set but not used.
11850 * dired.c (file_name_completion): Remove var that is set but not used.
11852 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
11854 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
11855 (Finsert_file_contents): Remove unnecessary code checking fd.
11857 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
11858 Check for integer overflow on size calculations.
11860 * buffer.c (Fprevious_overlay_change): Remove var that is set
11863 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
11864 Remove vars that are set but not used.
11865 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
11866 (timer_check_2): Mark vars as initialized.
11868 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
11870 * image.c (lookup_image): Remove var that is set but not used.
11871 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
11873 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
11874 that are set but not used.
11876 * xfns.c (make_invisible_cursor): Don't return garbage
11877 if XCreateBitmapFromData fails (Bug#8410).
11879 * xselect.c (x_get_local_selection, x_handle_property_notify):
11880 Remove vars that are set but not used.
11882 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
11883 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
11885 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
11886 Remove var that is set but not used.
11887 (scroll_bar_windows_size): Now size_t, not int.
11888 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
11889 Check for overflow.
11891 * xfaces.c (realize_named_face): Remove vars that are set but not used.
11892 (map_tty_color) [!defined MSDOS]: Likewise.
11894 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
11896 * coding.c: Remove vars that are set but not used.
11897 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
11898 All callers changed.
11899 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
11900 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
11901 (decode_coding_charset): Remove vars that are set but not used.
11903 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
11904 that is set but not used.
11906 * print.c (print_object): Remove var that is set but not used.
11908 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
11909 The gnulib version avoids calling malloc in the usual case,
11910 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
11911 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
11912 * filelock.c (current_lock_owner): Likewise.
11913 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
11914 * sysdep.c: Include allocator.h, careadlinkat.h.
11915 (emacs_no_realloc_allocator): New static constant.
11916 (emacs_readlink): New function.
11917 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
11918 ../lib/careadlinkat.h.
11920 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
11922 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
11923 first non-nil return value).
11925 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
11927 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
11928 if not defined (Bug#8403).
11930 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
11932 * xdisp.c (display_count_lines): Remove parameter `start',
11933 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11934 (get_char_face_and_encoding): Remove parameter `multibyte_p',
11935 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11936 (fill_stretch_glyph_string): Remove parameters `row' and `area',
11937 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
11938 and thereabouts. All callers changed.
11939 (get_per_char_metric): Remove parameter `f', unused since
11940 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11942 2011-04-02 Jim Meyering <meyering@redhat.com>
11944 do not dereference NULL upon failed strdup
11945 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
11946 (ns_get_family): Likewise.
11948 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
11950 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
11952 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
11954 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
11957 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
11959 Add lexical binding.
11961 * window.c (Ftemp_output_buffer_show): New fun.
11962 (Fsave_window_excursion):
11963 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
11965 * lread.c (lisp_file_lexically_bound_p): New function.
11966 (Fload): Bind Qlexical_binding.
11967 (readevalloop): Remove `evalfun' arg.
11968 Bind Qinternal_interpreter_environment.
11969 (Feval_buffer): Bind Qlexical_binding.
11970 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
11972 (syms_of_lread): Declare `lexical-binding'.
11974 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
11976 * keyboard.c (eval_dyn): New fun.
11977 (menu_item_eval_property): Use it.
11979 * image.c (parse_image_spec): Use Ffunctionp.
11981 * fns.c (concat, mapcar1): Accept byte-code-functions.
11983 * eval.c (Fsetq): Handle lexical vars.
11984 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
11985 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
11986 (FletX, Flet): Obey lexical binding.
11987 (Fcommandp): Handle closures.
11988 (Feval): New `lexical' arg.
11989 (eval_sub): New function extracted from Feval. Use it almost
11990 everywhere where Feval was used. Look up vars in lexical env.
11992 (Ffunctionp): Move from subr.el.
11993 (Ffuncall): Handle closures.
11994 (apply_lambda): Remove `eval_flags'.
11995 (funcall_lambda): Handle closures and new byte-code-functions.
11996 (Fspecial_variable_p): New function.
11997 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
11998 but without exporting it to Lisp.
12000 * doc.c (Fdocumentation, store_function_docstring):
12001 * data.c (Finteractive_form): Handle closures.
12003 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
12006 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
12008 (exec_byte_code): New function extracted from Fbyte_code to handle new
12009 calling convention for byte-code-functions. Add new byte-codes.
12011 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
12013 * alloc.c (Fmake_symbol): Init new `declared_special' field.
12015 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
12017 * xdisp.c (redisplay_internal): Fix prototype.
12019 2011-03-31 Eli Zaretskii <eliz@gnu.org>
12021 * xdisp.c (SCROLL_LIMIT): New macro.
12022 (try_scrolling): Use it when setting scroll_limit.
12023 Limit scrolling to 100 screen lines.
12024 (redisplay_window): Even when falling back on "recentering",
12025 position point in the window according to scroll-conservatively,
12026 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
12028 (try_scrolling): When point is above the window, allow searching
12029 as far as scroll_max, or one screenful, to compute vertical
12030 distance from PT to the scroll margin position. This prevents
12031 try_scrolling from unnecessarily failing when
12032 scroll-conservatively is set to a value slightly larger than the
12033 window height. Clean up the case of PT below the margin at bottom
12034 of window: scroll_max can no longer be INT_MAX. When aggressive
12035 scrolling is in use, don't let point enter the opposite scroll
12036 margin as result of the scroll.
12037 (syms_of_xdisp) <scroll-conservatively>: Document the
12038 threshold of 100 lines for never-recentering scrolling.
12040 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
12042 * dispextern.h (move_it_by_lines):
12043 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
12044 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
12045 (message_log_check_duplicate): Remove parameters `prev_bol' and
12046 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12047 (redisplay_internal): Remove parameter `preserve_echo_area',
12048 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
12050 * indent.c (Fvertical_motion):
12051 * window.c (window_scroll_pixel_based, Frecenter):
12052 Don't pass `need_y_p' to `move_it_by_lines'.
12054 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
12056 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
12057 steal a few bits to be more compact.
12058 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
12059 Remove unneeded casts.
12061 * bytecode.c (Fbyte_code): CAR and CDR can GC.
12063 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
12065 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
12066 binding" message (bug#7967).
12068 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
12070 Fix more problems found by GCC 4.6.0's static checks.
12072 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
12073 Remove unused local var.
12075 * editfns.c (Fmessage_box): Remove unused local var.
12077 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
12078 (note_mode_line_or_margin_highlight, note_mouse_highlight):
12079 Omit unused local vars.
12080 * window.c (shrink_windows): Omit unused local var.
12081 * menu.c (digest_single_submenu): Omit unused local var.
12082 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
12083 Omit unused local var.
12085 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
12086 Don't assume string length fits in int.
12087 (keyremap_step, read_key_sequence): Use size_t for sizes.
12088 (read_key_sequence): Don't check last_real_key_start redundantly.
12090 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
12091 instead of alloca (Bug#8344).
12093 * eval.c (Fbacktrace): Don't assume nargs fits in int.
12094 (Fbacktrace_frame): Don't assume nframes fits in int.
12096 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
12098 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
12101 * term.c (produce_glyphless_glyph): Remove unnecessary test.
12103 * cm.c (calccost): Turn while-do into do-while, for clarity.
12105 * keyboard.c (syms_of_keyboard): Use the same style as later
12106 in this function when indexing through an array. This also
12107 works around GCC bug 48267.
12109 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
12111 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
12113 * chartab.c (sub_char_table_ref_and_range): Redo for slight
12114 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
12116 * keyboard.c, keyboard.h (num_input_events): Now size_t.
12117 This avoids undefined behavior on integer overflow, and is a bit
12118 more convenient anyway since it is compared to a size_t variable.
12120 Variadic C functions now count arguments with size_t, not int.
12121 This avoids an unnecessary limitation on 64-bit machines, which
12122 caused (substring ...) to crash on large vectors (Bug#8344).
12123 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
12124 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
12125 All variadic functions and their callers changed accordingly.
12126 (struct gcpro.nvars): Now size_t, not int. All uses changed.
12127 * data.c (arith_driver, float_arith_driver): Likewise.
12128 * editfns.c (general_insert_function): Likewise.
12129 * eval.c (struct backtrace.nargs, interactive_p)
12130 (internal_condition_case_n, run_hook_with_args, apply_lambda)
12131 (funcall_lambda, mark_backtrace): Likewise.
12132 * fns.c (concat): Likewise.
12133 * frame.c (x_set_frame_parameters): Likewise.
12134 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
12135 0 if not found, not -1. All callers changed.
12137 * alloc.c (garbage_collect): Don't assume stack size fits in int.
12138 (stack_copy_size): Now size_t, not int.
12139 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
12141 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
12143 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
12144 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12145 All callers changed.
12147 * lisp.h (multibyte_char_to_unibyte):
12148 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
12149 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12150 * character.h (CHAR_TO_BYTE8):
12151 * cmds.c (internal_self_insert):
12152 * editfns.c (general_insert_function):
12153 * keymap.c (push_key_description):
12154 * search.c (Freplace_match):
12155 * xdisp.c (message_dolog, set_message_1): All callers changed.
12157 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
12159 * keyboard.c (safe_run_hook_funcall): New function.
12160 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
12161 don't set the hook to nil, but remove the offending function instead.
12162 (Qcommand_hook_internal): Remove, unused.
12163 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
12164 Vcommand_hook_internal.
12166 * eval.c (enum run_hooks_condition): Remove.
12167 (funcall_nil, funcall_not): New functions.
12168 (run_hook_with_args): Call each function through a `funcall' argument.
12169 Remove `cond' argument, now redundant.
12170 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
12171 (Frun_hook_with_args_until_failure): Adjust accordingly.
12172 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
12174 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
12176 * dispextern.h (string_buffer_position): Remove declaration.
12178 * print.c (strout): Remove parameter `multibyte', unused since
12179 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
12181 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
12182 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
12183 All callers changed.
12185 * w32.c (_wsa_errlist): Use braces for struct initializers.
12187 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
12188 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
12189 All callers changed.
12190 (string_buffer_position): Likewise. Also, make static (it's never
12191 used outside xdisp.c).
12192 (cursor_row_p): Remove parameter `w', unused since
12193 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
12194 (decode_mode_spec): Remove parameter `precision', introduced during
12195 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
12196 All callers changed.
12198 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12200 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
12202 2011-03-27 Anders Lindgren <andlind@gmail.com>
12204 * nsterm.m (ns_menu_bar_is_hidden): New variable.
12205 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
12206 (ns_update_auto_hide_menu_bar): New functions.
12207 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
12208 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
12209 ns_constrain_all_frames.
12210 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
12211 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
12213 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12215 * nsmenu.m (runDialogAt): Remove argument to timer_check.
12217 2011-03-27 Glenn Morris <rgm@gnu.org>
12219 * syssignal.h: Replace RETSIGTYPE with void.
12220 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
12221 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
12222 Replace SIGTYPE with void everywhere.
12223 * s/usg5-4-common.h (SIGTYPE): Remove definition.
12224 * s/template.h (SIGTYPE): Remove commented out definition.
12226 2011-03-26 Eli Zaretskii <eliz@gnu.org>
12228 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
12229 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
12231 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
12233 * w32.c (read_unc_volume): Use parameter `henum', instead of
12234 global variable `wget_enum_handle'.
12236 * keymap.c (describe_vector): Remove parameters `indices' and
12237 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
12238 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
12240 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
12242 * keyboard.c (timer_check): Remove parameter `do_it_now',
12243 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
12244 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
12245 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
12247 * keyboard.c (read_char):
12248 * w32menu.c (w32_menu_display_help):
12249 * xmenu.c (show_help_event, menu_help_callback):
12250 Adjust calls to `show_help_echo'.
12252 * gtkutil.c (xg_maybe_add_timer):
12253 * keyboard.c (readable_events):
12254 * process.c (wait_reading_process_output):
12255 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
12257 * insdel.c (adjust_markers_gap_motion):
12258 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
12259 (gap_left, gap_right): Don't call it.
12261 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
12263 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
12264 incurred during fontification.
12266 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
12268 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
12269 (DEFVAR_PER_BUFFER): Don't pass it.
12271 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
12272 (scrolling_window): Don't pass it.
12274 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
12276 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
12278 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
12280 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
12281 of variables specific to SELinux and computation of `encoded_absname'.
12283 * image.c (XPutPixel): Remove unused variable `height'.
12285 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
12287 * unexw32.c (get_section_info): Remove unused variable `section'.
12289 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
12290 (system_process_attributes): Remove unused variable `sess'.
12291 (sys_read): Remove unused variable `err'.
12293 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
12294 (w32_wnd_proc): Remove unused variable `isdead'.
12295 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
12296 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
12297 (x_create_tip_frame): Remove unused variable `tem'.
12299 * w32inevt.c (w32_console_read_socket):
12300 Remove unused variable `no_events'.
12302 * w32term.c (x_draw_composite_glyph_string_foreground):
12303 Remove unused variable `width'.
12305 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
12307 * w32term.c (x_set_glyph_string_clipping):
12308 Don't pass uninitialized region to CombineRgn.
12310 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
12312 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
12313 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
12314 (Fx_close_connection): Remove unused variable `i'.
12316 * w32font.c (w32font_draw): Return number of glyphs.
12317 (w32font_open_internal): Remove unused variable `i'.
12318 (w32font_driver): Add missing initializer.
12320 * w32menu.c (utf8to16): Remove unused variable `utf16'.
12321 (fill_in_menu): Remove unused variable `items_added'.
12323 * w32term.c (last_mouse_press_frame): Remove static global variable.
12324 (w32_clip_to_row): Remove unused variable `f'.
12325 (x_delete_terminal): Remove unused variable `i'.
12327 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
12328 (NOTHING): Remove unused static global variable.
12329 (uniscribe_check_otf): Remove unused variable `table'.
12330 (uniscribe_font_driver): Add missing initializers.
12332 2011-03-23 Julien Danjou <julien@danjou.info>
12334 * term.c (Fsuspend_tty, Fresume_tty):
12335 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
12336 * window.c (temp_output_buffer_show):
12337 * insdel.c (signal_before_change):
12338 * frame.c (Fhandle_switch_frame):
12339 * fileio.c (Fdo_auto_save):
12340 * emacs.c (Fkill_emacs):
12341 * editfns.c (save_excursion_restore):
12342 * cmds.c (internal_self_insert):
12343 * callint.c (Fcall_interactively):
12344 * buffer.c (Fkill_all_local_variables):
12345 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
12347 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
12348 unconditionally since it does the check itself.
12350 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
12352 Fix more problems found by GCC 4.5.2's static checks.
12354 * coding.c (encode_coding_raw_text): Avoid unnecessary test
12355 the first time through the loop, since we know p0 < p1 then.
12356 This also avoids a gcc -Wstrict-overflow warning.
12358 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
12359 leading to a memory leak, possible in functions like
12360 load_charset_map_from_file that can allocate an unbounded number
12361 of objects (Bug#8318).
12363 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
12364 that could (at least in theory) be that large.
12366 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
12367 This is less likely to overflow, and avoids undefined behavior if
12368 overflow does occur. All callers changed. Use strtoul to scan
12369 for the unsigned long integer.
12370 (pint2hrstr): Simplify and tune code slightly.
12371 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
12373 * scroll.c (do_scrolling): Work around GCC bug 48228.
12374 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
12376 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
12377 This also avoids a warning with gcc -Wstrict-overflow.
12378 (validate_x_resource_name): Simplify count usage.
12379 This also avoids a warning with gcc -Wstrict-overflow.
12381 * fileio.c (Fcopy_file): Report error if fchown or fchmod
12384 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
12386 * process.c (Fmake_network_process): Use socklen_t, not int,
12387 where POSIX says socklen_t is required in portable programs.
12388 This fixes a porting bug on hosts like 64-bit HP-UX, where
12389 socklen_t is wider than int (Bug#8277).
12390 (Fmake_network_process, server_accept_connection):
12391 (wait_reading_process_output, read_process_output):
12394 * process.c: Rename or move locals to avoid shadowing.
12395 (list_processes_1, Fmake_network_process):
12396 (read_process_output_error_handler, exec_sentinel_error_handler):
12397 Rename or move locals.
12398 (Fmake_network_process): Define label "retry_connect" only if needed.
12399 (Fnetwork_interface_info): Fix pointer signedness.
12400 (process_send_signal): Add cast to avoid pointer signedness problem.
12401 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
12402 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
12404 Make tparam.h and terminfo.c consistent.
12405 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
12406 Include tparam.h instead, since it declares them.
12407 * cm.h (PC): Remove extern decl; tparam.h now does this.
12408 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
12409 * terminfo.c: Include tparam.h, to check interfaces.
12410 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
12411 (tparam): Adjust signature to match interface in tparam.h;
12412 this removes some undefined behavior. Check that outstring and len
12413 are zero, which they always are with Emacs.
12414 * tparam.h (PC, BC, UP): New extern decls.
12416 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
12417 (xftfont_open): Rename locals to avoid shadowing.
12419 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
12420 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
12421 (OTF_TAG_SYM): Omit macro if not needed.
12422 (ftfont_list): Remove unused local.
12423 (get_adstyle_property, ftfont_pattern_entity):
12424 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
12425 Rename locals to avoid shadowing.
12427 * xfont.c (xfont_list_family): Mark var as initialized.
12429 * xml.c (make_dom): Now static.
12431 * composite.c (composition_compute_stop_pos): Rename local to
12433 (composition_reseat_it): Remove unused locals.
12434 (find_automatic_composition, composition_adjust_point): Likewise.
12435 (composition_update_it): Mark var as initialized.
12436 (find_automatic_composition): Mark vars as initialized,
12437 with a FIXME (Bug#8290).
12439 character.h: Rename locals to avoid shadowing.
12440 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
12441 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
12442 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
12443 (BUF_DEC_POS): Be more systematic about renaming local temporaries
12444 to avoid shadowing.
12446 * textprop.c (property_change_between_p): Remove; unused.
12448 * intervals.c (interval_start_pos): Now static.
12450 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
12452 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
12453 Rename locals to avoid shadowing.
12455 * sound.c (wav_play, au_play, Fplay_sound_internal):
12456 Fix pointer signedness.
12457 (alsa_choose_format): Remove unused local var.
12458 (wav_play): Initialize a variable to 0, to prevent undefined
12459 behavior (Bug#8278).
12461 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
12463 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
12465 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
12466 clobbering (Bug#8298).
12467 * sysdep.c (sys_subshell): Likewise.
12468 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
12470 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
12471 This should get cleaned up, so that child_setup has the
12472 same signature on all platforms.
12474 * callproc.c (call_process_cleanup): Now static.
12475 (relocate_fd): Rename locals to avoid shadowing.
12477 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
12479 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
12480 not to be necessary, and produces flickering.
12482 2011-03-20 Glenn Morris <rgm@gnu.org>
12484 * config.in: Remove file.
12486 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
12488 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
12489 are now in src/globals.h.
12490 (syms_of_minibuf): Remove spurious & from previous change.
12492 2011-03-20 Leo Liu <sdl.web@gmail.com>
12494 * minibuf.c (completing-read-function): New variable.
12495 (completing-read-default): Rename from completing-read.
12496 (completing-read): Call completing-read-function.
12498 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
12500 * xfaces.c (Fx_load_color_file):
12501 Read color file from absolute filename (bug#8250).
12503 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
12505 * makefile.w32-in: Update dependencies.
12507 2011-03-17 Eli Zaretskii <eliz@gnu.org>
12509 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
12511 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
12513 Fix more problems found by GCC 4.5.2's static checks.
12515 * process.c (make_serial_process_unwind, send_process_trap):
12516 (sigchld_handler): Now static.
12518 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
12519 That way, the code declares only the vars that it needs.
12520 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
12521 * s/cygwin.h (PTY_ITERATION): Likewise.
12522 * s/darwin.h (PTY_ITERATION): Likewise.
12523 * s/gnu-linux.h (PTY_ITERATION): Likewise.
12525 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
12526 * process.c (allocate_pty): Don't declare stb unless it's needed.
12528 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
12529 (CONSTANTLIM): Remove; unused.
12530 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
12531 Define only if needed.
12533 * unexelf.c (unexec): Name an expression,
12534 to avoid gcc -Wbad-function-cast warning.
12535 Use a different way to cause a compilation error if anyone uses
12536 n rather than nn, a way that does not involve shadowing.
12537 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
12539 * deps.mk (unexalpha.o): Remove; unused.
12541 New file unexec.h, the (simple) interface for unexec (Bug#8267).
12542 * unexec.h: New file.
12543 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
12544 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
12545 Depend on unexec.h.
12546 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
12547 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
12548 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
12549 Change as necessary to match prototype in unexec.h.
12551 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
12553 (back_comment, skip_chars): Mark vars as initialized.
12555 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
12556 Rename locals to avoid shadowing.
12558 * lread.c (read1): Rewrite so as not to use empty "else".
12559 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
12561 * print.c (Fredirect_debugging_output): Fix pointer signedess.
12563 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
12564 warning when compiling print.c.
12566 * font.c (font_unparse_fcname): Abort in an "impossible" situation
12567 instead of using an uninitialized var.
12568 (font_sort_entities): Mark var as initialized.
12570 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
12572 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
12573 pointers to constants.
12574 (font_parse_fcname): Remove unused vars.
12575 (font_delete_unmatched): Now static.
12576 (font_get_spec): Remove; unused.
12577 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
12578 (font_update_drivers, Ffont_get_glyphs, font_add_log):
12579 Rename or move locals to avoid shadowing.
12581 * fns.c (require_nesting_list, require_unwind): Now static.
12582 (Ffillarray): Rename locals to avoid shadowing.
12584 * floatfns.c (domain_error2): Define only if needed.
12585 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
12587 * alloc.c (mark_backtrace): Move decl from here ...
12588 * lisp.h: ... to here, so that it can be checked.
12590 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
12591 (Fdefvar): Rewrite so as not to use empty "else".
12592 (lisp_indirect_variable): Name an expression,
12593 to avoid gcc -Wbad-function-cast warning.
12594 (Fdefvar): Rename locals to avoid shadowing.
12596 * callint.c (quotify_arg, quotify_args): Now static.
12597 (Fcall_interactively): Rename locals to avoid shadowing.
12598 Use const pointer when appropriate.
12600 * lisp.h (get_system_name, get_operating_system_release):
12601 Move decls here, to check interfaces.
12602 * process.c (get_operating_system_release): Move decl to lisp.h.
12603 * xrdb.c (get_system_name): Likewise.
12604 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
12605 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
12606 some of which prompt warnings from gcc -Wbad-function-cast.
12607 (Fformat_time_string, Fencode_time, Finsert_char):
12608 (Ftranslate_region_internal, Fformat):
12609 Rename or remove local vars to avoid shadowing.
12610 (Ftranslate_region_internal): Mark var as initialized.
12612 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
12615 * lisp.h (eassert): Check that the argument compiles, even if
12616 ENABLE_CHECKING is not defined.
12618 * data.c (Findirect_variable): Name an expression, to avoid
12619 gcc -Wbad-function-cast warning.
12620 (default_value, arithcompare, arith_driver, arith_error): Now static.
12621 (store_symval_forwarding): Rename local to avoid shadowing.
12622 (Fmake_variable_buffer_local, Fmake_local_variable):
12623 Mark variables as initialized.
12624 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
12626 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
12627 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
12628 Rename locals to avoid shadowing.
12629 (mark_stack): Move local variables into the #ifdef region where
12631 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
12632 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
12634 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
12635 (GC_STRING_CHARS): Remove; not used.
12636 (Fmemory_limit): Cast sbrk's returned value to char *.
12638 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
12639 avoids undefined behavior in theory.
12641 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
12643 Use functions, not macros, for up- and down-casing (Bug#8254).
12644 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12645 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
12646 to use the following functions instead of these macros.
12647 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
12648 EMACS_INT, since callers assume the returned value fits in int.
12649 (upcase1): Likewise, for UPCASE_TABLE.
12650 (uppercasep, lowercasep, upcase): New static inline functions.
12651 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
12652 the race-condition problem in the old DOWNCASE.
12654 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
12655 Rename locals to avoid shadowing.
12656 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
12657 (regex_compile, re_search_2, re_match_2_internal):
12658 Remove unused local vars.
12659 (FREE_VAR): Rewrite so as not to use empty "else",
12660 which gcc can warn about.
12661 (regex_compile, re_match_2_internal): Mark locals as initialized.
12662 (RETALLOC_IF): Define only if needed.
12663 (WORDCHAR_P): Likewise. This one is never needed, but is used
12664 only in a comment talking about a compiler bug, so put inside
12665 the #if 0 of that comment.
12666 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
12667 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
12670 * search.c (boyer_moore): Rename locals to avoid shadowing.
12671 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
12672 (PREV_CHAR_BOUNDARY): Likewise.
12674 * search.c (simple_search): Remove unused var.
12676 * dired.c (compile_pattern): Move decl from here ...
12677 * lisp.h: ... to here, so that it can be checked.
12678 (struct re_registers): New forward decl.
12680 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
12682 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
12684 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
12685 Rename locals to avoid shadowing.
12686 (Fvertical_motion): Mark locals as initialized.
12688 * casefiddle.c (casify_object, casify_region): Now static.
12689 (casify_region): Mark local as initialized.
12691 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
12693 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
12694 New macros, so that the caller can use some names other than
12695 gcpro1, gcpro2, etc.
12696 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
12698 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
12699 argument, for consistency with GCPRO2_VAR, etc: it is now the
12700 prefix of the variable, not the variable itself. All uses
12702 * dired.c (directory_files_internal, file_name_completion):
12703 Rename locals to avoid shadowing.
12705 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
12706 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
12707 dired.c's scmp function, had undefined behavior.
12708 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12709 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
12710 * buffer.h: ... to here, because these macros use current_buffer,
12711 and the new implementation with inline functions needs to have
12712 current_buffer in scope now, rather than later when the macros
12714 (downcase, upcase1): New static inline functions.
12715 (DOWNCASE, UPCASE1): Reimplement using these functions.
12716 This avoids undefined behavior in expressions like
12717 DOWNCASE (x) == DOWNCASE (y), which previously suffered
12718 from race conditions in accessing the global variables
12719 case_temp1 and case_temp2.
12720 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
12721 * lisp.h (case_temp1, case_temp2): Remove their decls.
12722 * character.h (ASCII_CHAR_P): Move from here ...
12723 * lisp.h: ... to here, so that the inline functions mentioned
12724 above can use them.
12726 * dired.c (directory_files_internal_unwind): Now static.
12728 * fileio.c (file_name_as_directory, directory_file_name):
12729 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
12731 (file_name_as_directory): Use const pointers when appropriate.
12732 (Fexpand_file_name): Likewise. In particular, newdir might
12733 point at constant storage, so make it a const pointer.
12734 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
12735 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
12737 (Fset_file_times, Finsert_file_contents, auto_save_error):
12738 Rename locals to avoid shadowing.
12740 * minibuf.c (choose_minibuf_frame_1): Now static.
12741 (Ftry_completion, Fall_completions): Rename or remove locals
12742 to avoid shadowing.
12744 * marker.c (bytepos_to_charpos): Remove; unused.
12746 * lisp.h (verify_bytepos, count_markers): New decls,
12747 so that gcc does not warn that these functions aren't declared.
12749 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
12750 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
12751 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
12752 (copy_text): Remove unused local var.
12754 * filelock.c (within_one_second): Now static.
12755 (lock_file_1): Rename local to avoid shadowing.
12757 * buffer.c (fix_overlays_before): Mark locals as initialized.
12758 (fix_start_end_in_overlays): Likewise. This function should be
12759 simplified by using pointers-to-pointers, but that's a different
12761 (switch_to_buffer_1): Now static.
12762 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
12763 (report_overlay_modification): Rename locals to avoid shadowing.
12765 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
12766 Fix pointer signedness issue.
12767 (sys_subshell): Mark local as volatile if checking for lint,
12768 to suppress a gcc -Wclobbered warning that does not seem to be right.
12769 (MAXPATHLEN): Define only if needed.
12771 * process.c (serial_open, serial_configure): Move decls from here ...
12772 * systty.h: ... to here, so that they can be checked.
12774 * fns.c (get_random, seed_random): Move extern decls from here ...
12775 * lisp.h: ... to here, so that they can be checked.
12777 * sysdep.c (reset_io): Now static.
12778 (wait_for_termination_signal): Remove; unused.
12780 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
12781 (copy_keymap_item, append_key, push_text_char_description):
12783 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
12784 (DENSE_TABLE_SIZE): Remove; unused.
12785 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
12786 (describe_map_tree):
12787 Rename locals to avoid shadowing.
12789 * keyboard.c: Declare functions static if they are not used elsewhere.
12790 (echo_char, echo_dash, cmd_error, top_level_2):
12791 (poll_for_input, handle_async_input): Now static.
12792 (read_char, kbd_buffer_get_event, make_lispy_position):
12793 (make_lispy_event, make_lispy_movement, apply_modifiers):
12794 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
12795 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
12796 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
12797 (read_key_sequence, read_char): Mark locals as initialized.
12798 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
12800 * keyboard.h (make_ctrl_char): New decl.
12801 (mark_kboards): Move decl here ...
12802 * alloc.c (mark_kboards): ... from here.
12804 * lisp.h (force_auto_save_soon): New decl.
12806 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
12807 (DEFINE_DUMMY_FUNCTION): New macro.
12808 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
12810 (main): Add casts to avoid warnings
12811 if GCC considers string literals to be constants.
12813 * lisp.h (fatal_error_signal): Add decl, since it's exported.
12815 * dbusbind.c: Pointer signedness fixes.
12816 (xd_signature, xd_append_arg, xd_initialize):
12817 (Fdbus_call_method, Fdbus_call_method_asynchronously):
12818 (Fdbus_method_return_internal, Fdbus_method_error_internal):
12819 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
12820 (Fdbus_register_signal): Use SSDATA when the context wants char *.
12822 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
12823 if GCC considers string literals to be constants.
12824 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
12826 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
12828 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
12829 (print_preprocess, print_object): New macro to fix last change.
12831 * print.c (print_preprocess): Don't forget font objects.
12833 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
12835 * emacs.c (USAGE3): Doc fixes.
12837 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
12839 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
12842 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
12844 * lisp.h (VWindow_system, Qfile_name_history):
12845 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
12846 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
12847 (w32_system_caret_x, w32_system_caret_y): Declare extern.
12849 * w32select.c: Don't #include "keyboard.h".
12850 (run_protected): Add extern declaration for waiting_for_input.
12852 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
12853 * w32console.c (detect_input_pending, read_input_pending)
12854 (encode_terminal_code):
12855 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
12856 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
12857 (w32_system_caret_y, Qfile_name_history):
12858 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
12859 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
12860 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
12861 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
12862 * w32proc.c (Qlocal, report_file_error):
12863 * w32term.c (Vwindow_system, updating_frame):
12864 * w32uniscribe.c (initialized, uniscribe_font_driver):
12865 Remove unneeded extern declarations.
12867 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
12869 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
12871 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
12873 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
12874 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
12875 These macros can no longer be used for assignment.
12877 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
12878 Assign struct members directly, instead of using BUF_BEGV etc.
12879 (record_buffer_markers, fetch_buffer_markers): New functions for
12880 recording and fetching special buffer markers.
12881 (set_buffer_internal_1, set_buffer_temp): Use them.
12883 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
12885 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
12887 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
12888 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
12890 * xdisp.c (hscroll_window_tree):
12891 (reconsider_clip_changes): Use PT instead of BUF_PT.
12893 2011-03-13 Eli Zaretskii <eliz@gnu.org>
12895 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
12896 $(EMACS_ROOT)/lib/intprops.h.
12898 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
12900 Fix more problems found by GCC 4.5.2's static checks.
12902 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
12903 to unsigned char * to avoid compiler diagnostic.
12904 (xg_free_frame_widgets): Make it clear that a local variable is
12905 needed only if USE_GTK_TOOLTIP.
12906 (gdk_window_get_screen): Make it clear that this macro is needed
12907 only if USE_GTK_TOOLTIP.
12908 (int_gtk_range_get_value): New function, which avoids a diagnostic
12909 from gcc -Wbad-function-cast.
12910 (xg_set_toolkit_scroll_bar_thumb): Use it.
12911 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
12912 diagnostic from gcc -Wbad-function-cast.
12913 (get_utf8_string, xg_get_file_with_chooser):
12914 Rename locals to avoid shadowing.
12915 (create_dialog): Move locals to avoid shadowing.
12917 * xgselect.c (xg_select): Remove unused var.
12919 * image.c (four_corners_best): Mark locals as initialized.
12920 (gif_load): Initialize transparent_p to zero (Bug#8238).
12921 Mark another local as initialized.
12922 (my_png_error, my_error_exit): Mark with NO_RETURN.
12924 * image.c (clear_image_cache): Now static.
12925 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
12926 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
12927 (x_edge_detection): Remove unnecessary cast that
12928 gcc -Wbad-function-cast diagnoses.
12929 (gif_load): Fix pointer signedness.
12930 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
12931 (jpeg_load, gif_load): Rename locals to avoid shadowing.
12933 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
12935 Improve quality of tests for time stamp overflow.
12936 For example, without this patch (encode-time 0 0 0 1 1
12937 1152921504606846976) returns the obviously-bogus value (-948597
12938 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
12939 reports time overflow. See
12940 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
12941 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
12942 * editfns.c: Include limits.h and intprops.h.
12943 (TIME_T_MIN, TIME_T_MAX): New macros.
12944 (time_overflow): Move earlier, to before first use.
12945 (hi_time, lo_time): New functions, for an accurate test for
12946 out-of-range times.
12947 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
12948 (Fget_internal_run_time): Don't assume time_t fits in int.
12949 (make_time): Use list2 instead of Fcons twice.
12950 (Fdecode_time): More accurate test for out-of-range times.
12951 (check_tm_member): New function.
12952 (Fencode_time): Use it, to test for out-of-range times.
12953 (lisp_time_argument): Don't rely on undefined left-shift and
12954 right-shift behavior when checking for time stamp overflow.
12956 * editfns.c (time_overflow): New function, refactoring common code.
12957 (Fformat_time_string, Fdecode_time, Fencode_time):
12958 (Fcurrent_time_string): Use it.
12960 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
12961 * dired.c (make_time): Move to ...
12962 * editfns.c (make_time): ... here.
12963 * systime.h: Note the move.
12965 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
12967 * fringe.c (update_window_fringes): Remove unused variables.
12969 * unexmacosx.c (copy_data_segment): Also copy __got section.
12972 2011-03-12 Eli Zaretskii <eliz@gnu.org>
12974 * termcap.c [MSDOS]: Include "msdos.h".
12975 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
12976 Constify `char *' arguments and their references according to
12977 prototypes in tparam.h.
12979 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
12981 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
12982 Adapt all references accordingly.
12984 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
12986 2011-03-11 Tom Tromey <tromey@redhat.com>
12988 * buffer.c (syms_of_buffer): Remove obsolete comment.
12990 2011-03-11 Eli Zaretskii <eliz@gnu.org>
12992 * termhooks.h (encode_terminal_code): Declare prototype.
12994 * msdos.c (encode_terminal_code): Don't declare prototype.
12996 * term.c (encode_terminal_code): Now external again, used by
12997 w32console.c and msdos.c.
12999 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
13000 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
13002 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
13004 Fix some minor problems found by GCC 4.5.2's static checks.
13006 * fringe.c (update_window_fringes): Mark locals as initialized
13008 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
13010 * alloc.c (mark_fringe_data): Move decl from here ...
13011 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
13012 to check its interface.
13013 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
13015 * fontset.c (free_realized_fontset): Now static.
13016 (Fset_fontset_font): Rename local to avoid shadowing.
13017 (fontset_font): Mark local as initialized.
13018 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
13020 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
13022 * xselect.c (x_disown_buffer_selections): Remove; not used.
13023 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
13024 (x_own_selection, Fx_disown_selection_internal): Rename locals
13025 to avoid shadowing.
13026 (x_handle_dnd_message): Remove local to avoid shadowing.
13028 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
13029 so that the caller can use some name other than gcpro1.
13030 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
13031 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13032 (Fx_backspace_delete_keys_p):
13033 Use them to avoid shadowing, and rename vars to avoid shadowing.
13034 (x_decode_color, x_set_name, x_window): Now static.
13035 (Fx_create_frame): Add braces to silence GCC warning.
13036 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
13037 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
13038 Remove unused locals.
13039 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13040 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
13041 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
13044 * xterm.h (x_mouse_leave): New decl.
13046 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
13047 Remove unused functions.
13048 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
13049 (x_calc_absolute_position): Now static.
13050 (XTread_socket): Don't define label "out" unless it's used.
13051 Don't declare local "event" unless it's used.
13052 (x_iconify_frame, x_free_frame_resources): Don't declare locals
13053 unless they are used.
13054 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
13055 (x_fatal_error_signal): Remove; not used.
13056 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
13057 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
13058 (x_error_catcher, x_connection_closed, x_error_handler):
13059 (x_error_quitter, xembed_send_message, x_iconify_frame):
13060 (my_log_handler): Rename locals to avoid shadowing.
13061 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
13062 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
13064 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
13065 Rename or move locals to avoid shadowing.
13066 (tty_defined_color, merge_face_heights): Now static.
13067 (free_realized_faces_for_fontset): Remove; not used.
13068 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
13069 does not deduce is never used uninitialized.
13070 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
13071 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
13073 * terminal.c (store_terminal_param): Now static.
13075 * xmenu.c (menu_highlight_callback): Now static.
13076 (set_frame_menubar): Remove unused local.
13077 (xmenu_show): Rename parameter to avoid shadowing.
13078 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
13079 since they might point to immutable storage.
13080 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
13081 since it's unused otherwise.
13083 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
13084 Add a FIXME, since the code still doesn't look right. (Bug#8215)
13085 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
13086 avoids a gcc -Wuninitialized diagnostic.
13087 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
13088 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
13089 does not deduce are never used uninitialized.
13091 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
13093 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
13094 * window.c (window_loop, size_window):
13095 (run_window_configuration_change_hook, enlarge_window): Likewise.
13097 * window.c (display_buffer): Now static.
13098 (size_window): Mark variables that gcc -Wuninitialized
13099 does not deduce are never used uninitialized.
13100 * window.h (check_all_windows): New decl, to forestall
13101 gcc -Wmissing-prototypes diagnostic.
13102 * dispextern.h (bidi_dump_cached_states): Likewise.
13104 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
13106 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
13107 Include <limits.h>.
13108 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
13109 and to avoid gcc -Wuninitialized warning.
13110 (load_charset_map): Mark variables that gcc -Wuninitialized
13111 does not deduce are never used uninitialized.
13112 (load_charset): Abort instead of using uninitialized var (Bug#8229).
13114 * coding.c (coding_set_source, coding_set_destination):
13115 Use "else { /* comment */ }" rather than "else /* comment */;"
13116 for clarity, and to avoid gcc -Wempty-body warning.
13117 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
13118 a block, when the outer 'i' will do.
13119 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
13120 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
13121 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
13122 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
13123 (Fdecode_sjis_char, Fdefine_coding_system_internal):
13124 Rename locals to avoid shadowing.
13125 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
13126 * coding.c (emacs_mule_char, encode_invocation_designation):
13127 Now static, since they're not used elsewhere.
13128 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
13129 (decode_coding_object, encode_coding_object, detect_coding_system):
13130 (decode_coding_emacs_mule): Mark variables that gcc
13131 -Wuninitialized does not deduce are never used uninitialized.
13132 (detect_coding_iso_2022): Initialize a local variable that might
13133 be used uninitialized. Leave a FIXME because it's not clear that
13134 this initialization is needed. (Bug#8211)
13135 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
13136 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
13137 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
13138 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
13139 Remove unused macros.
13141 * category.c (hash_get_category_set): Remove unused local var.
13142 (copy_category_table): Now static, since it's not used elsewhere.
13143 * character.c (string_count_byte8): Likewise.
13145 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
13146 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
13148 * chartab.c (copy_sub_char_table): Now static, since it's not used
13150 (sub_char_table_ref_and_range, char_table_ref_and_range):
13151 Rename locals to avoid shadowing.
13152 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
13154 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
13155 (BIDI_BOB): Remove unused macro.
13157 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
13158 deduce are never used uninitialized.
13159 * term.c (encode_terminal_code): Likewise.
13161 * term.c (encode_terminal_code): Now static. Remove unused local.
13163 * tparam.h: New file.
13164 * term.c, tparam.h: Include it.
13165 * deps.mk (term.o, tparam.o): Depend on tparam.h.
13166 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
13167 Move these decls to tparam.h, and make them agree with what
13168 is actually in tparam.c. The previous trick of using incompatible
13169 decls in different modules does not conform to the C standard.
13170 All callers of tparam changed to use tparam's actual API.
13171 * tparam.c (tparam1, tparam, tgoto):
13172 Use const pointers where appropriate.
13174 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
13175 * cm.h (struct cm): Likewise.
13176 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
13177 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
13178 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
13179 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
13180 (turn_on_face, init_tty): Likewise.
13181 * termchar.h (struct tty_display_info): Likewise.
13183 * term.c (term_mouse_position): Rename local to avoid shadowing.
13185 * alloc.c (mark_ttys): Move decl from here ...
13186 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
13188 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
13190 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
13192 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
13194 * search.c (compile_pattern_1): Remove argument regp, unused since
13195 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
13196 (compile_pattern): Don't pass it.
13198 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
13200 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
13201 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
13203 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
13205 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
13207 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
13208 gdk_window_get_screen, gdk_window_get_geometry,
13209 gdk_x11_window_lookup_for_display and GDK_KEY_g.
13210 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
13211 (xg_get_pixbuf_from_pixmap): New function.
13212 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
13213 to Pixmap, take frame as parameter, remove GdkColormap parameter.
13214 Call xg_get_pixbuf_from_pixmap instead of
13215 gdk_pixbuf_get_from_drawable.
13216 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
13217 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
13218 (xg_check_special_colors): Use GtkStyleContext and its functions
13220 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
13221 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
13222 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
13223 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
13224 Call gtk_widget_get_preferred_size.
13225 (xg_frame_resized): gdk_window_get_geometry only takes 5
13227 (xg_win_to_widget, xg_event_is_for_menubar):
13228 Call gdk_x11_window_lookup_for_display.
13229 (xg_set_widget_bg): New function.
13230 (delete_cb): New function.
13231 (xg_create_frame_widgets): Connect delete-event to delete_cb.
13232 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
13233 (xg_set_background_color): Call xg_set_widget_bg.
13234 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
13235 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
13236 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
13237 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
13239 (update_frame_tool_bar): Call gtk_widget_hide.
13240 (xg_initialize): Use GDK_KEY_g.
13242 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
13244 (x_session_initialize): Call gdk_x11_set_sm_client_id.
13246 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
13247 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
13248 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
13250 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
13252 * w32xfns.c (select_palette): Check success of RealizePalette against
13253 GDI_ERROR, not zero.
13255 See ChangeLog.11 for earlier changes.
13257 ;; Local Variables:
13261 Copyright (C) 2011-2012 Free Software Foundation, Inc.
13263 This file is part of GNU Emacs.
13265 GNU Emacs is free software: you can redistribute it and/or modify
13266 it under the terms of the GNU General Public License as published by
13267 the Free Software Foundation, either version 3 of the License, or
13268 (at your option) any later version.
13270 GNU Emacs is distributed in the hope that it will be useful,
13271 but WITHOUT ANY WARRANTY; without even the implied warranty of
13272 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13273 GNU General Public License for more details.
13275 You should have received a copy of the GNU General Public License
13276 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.