1 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
3 * xfns.c (xic_create_fontsetname): Remove redundant calls
6 2012-06-25 Paul Eggert <eggert@cs.ucla.edu>
8 * gtkutil.c (get_utf8_string): Remove redundant assignment.
9 sprintf already null-terminates its output.
11 * xfns.c (x_window): Remove redundant cast.
13 2012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
15 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
16 `const char *' to `char *' to avoid compiler warning.
18 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
20 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
21 instead of truncating it to 63 (admittedly a generous limit).
23 * process.c: Fix spelling and caps in comments.
25 2012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
27 * emacs.c (setpgrp): Remove definition, unused.
28 * sysdep.c (setpgrp): Remove definition, not used in this file.
30 2012-06-24 Juanma Barranquero <lekktu@gmail.com>
32 * makefile.w32-in: Update dependencies.
34 2012-06-24 Eli Zaretskii <eliz@gnu.org>
36 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
37 (SYSTIME_H): Add nt/inc/sys/time.h.
39 * systime.h [WINDOWSNT]: Include sys/time.h.
41 * s/ms-w32.h (struct timespec): Definition moved from
42 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
44 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
46 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
47 * buffer.h (buffer_slot_type_mismatch):
48 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
49 * eval.c (unwind_to_catch):
50 * image.c (my_png_error, my_error_exit):
51 * keyboard.c (quit_throw_to_read_char, user_error)
52 (Fexit_recursive_edit, Fabort_recursive_edit):
53 * lisp.h (die, args_out_of_range, args_out_of_range_3)
54 (wrong_type_argument, buffer_overflow, __executable_start)
55 (memory_full, buffer_memory_full, string_overflow, Fthrow)
56 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
57 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
59 (child_setup) [!DOS_NT]:
60 * lread.c (end_of_file_error, invalid_syntax):
61 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
62 * puresize.h (pure_write_error):
63 * search.c (matcher_overflow):
64 * sound.c (sound_perror, alsa_sound_perror):
65 * sysdep.c, syssignal.h (croak):
66 * term.c (maybe_fatal, vfatal):
67 * textprop.c (text_read_only):
68 * undo.c (user_error):
69 * unexmacosx.c (unexec_error):
70 * xterm.c (x_ins_del_lines, x_delete_glyphs):
71 Use _Noreturn rather than NO_RETURN.
72 No need for separate decl merely because of _Noreturn.
73 * sound.c (sound_warning, parse_sound):
74 Remove unnecessary forward decls.
76 2012-06-24 Paul Eggert <eggert@cs.ucla.edu>
78 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
79 * lisp.h (WAIT_READING_MAX): New macro.
80 * dispnew.c (Fsleep_for, sit_for):
81 * keyboard.c (kbd_buffer_get_event):
82 * process.c (Faccept_process_output):
83 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
84 This improves on the previous patch, which introduced a bug
85 when time_t is unsigned and as wide as intmax_t.
86 See <http://bugs.gnu.org/9000#51>.
88 2012-06-23 Eli Zaretskii <eliz@gnu.org>
90 * dispnew.c (sit_for, Fsleep_for):
91 * keyboard.c (kbd_buffer_get_event):
92 * process.c (Faccept_process_output): Avoid compiler warnings when
93 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
95 2012-06-23 Juanma Barranquero <lekktu@gmail.com>
97 * makefile.w32-in: Update dependencies.
99 * w32.c (ltime): Add return type and declare static.
100 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
102 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
104 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
105 Privately reported by Herbert J. Skuhra.
106 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
108 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
109 not make_lisp_timeval, when the argument is of type EMACS_TIME.
111 2012-06-23 Eli Zaretskii <eliz@gnu.org>
113 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
114 last argument of make_unibyte_string.
116 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
117 language ID in the event parameters.
119 * w32term.c (w32_read_socket): Put the new keyboard codepage into
120 event.code, not the obscure "character set ID".
122 2012-06-23 Chong Yidong <cyd@gnu.org>
124 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
126 2012-06-23 Eli Zaretskii <eliz@gnu.org>
128 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
129 * w32.c (fdutimens): New function.
131 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
133 * s/ms-w32.h (pselect): Redirect to sys_select.
135 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
137 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
138 in the logic of incrementing and decrementing the value of
139 use_relocatable_buffers.
141 2012-06-23 Paul Eggert <eggert@cs.ucla.edu>
143 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
144 Privately reported by Herbert J. Skuhra.
145 [__FreeBSD__]: Remove "*/" typo after "#include".
146 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
147 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
148 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
149 Don't assume EMACS_TIME and struct timeval are the same type.
151 2012-06-22 Paul Eggert <eggert@cs.ucla.edu>
153 Support higher-resolution time stamps (Bug#9000).
154 The time stamps are only nanosecond-resolution at the C level,
155 since that's the best that any real-world system supports now.
156 But they are picosecond-resolution at the Lisp level, as that's
157 easy, and leaves room for future OS improvements.
159 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
162 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
163 Don't get current time unless it's needed.
165 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
166 now provides it if it's absent.
167 (start_atimer): Port to higher-res time stamps.
168 Check for time stamp overflow. Don't get current time more
169 often than is needed.
171 * buffer.h (struct buffer): Buffer modtime now has high resolution.
172 Include systime.h, not time.h.
173 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
175 * dired.c: Include stat-time.h.
176 (Ffile-attributes): File times now have higher resolution.
178 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
179 (struct image): Timestamp now has higher resolution.
181 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
182 has at least microseconds now. All uses removed.
183 (update_frame, update_single_window, update_window, update_frame_1)
184 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
186 * editfns.c (time_overflow): Now extern.
187 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
188 (float-time, Fformat_time_string, Fcurrent_time_string)
189 (Fcurrent_time_zone): Accept and generate higher-resolution
191 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
192 (decode_time_components, lisp_seconds_argument): New functions.
193 (make_time): Now static.
194 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
195 Report an error if the time is invalid, rather than having the caller
198 * fileio.c: Include <stat-time.h>
199 (Fcopy_file): Copy higher-resolution time stamps.
200 Prefer to set the time stamp via a file descriptor if that works.
201 (Fset_file_times, Finsert_file_contents, Fwrite_region)
202 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
203 (Fvisited_file_modtime, Fset_visited_file_modtime):
204 Support higher-resolution time stamps.
206 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
208 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
210 * image.c (prepare_image_for_display, clear_image_cache)
211 (lookup_image): Port to higer-resolution time stamps.
213 * keyboard.c (start_polling, bind_polling_period):
214 Check for time stamp overflow.
215 (read_char, kbd_buffer_get_event, timer_start_idle)
216 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
217 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
218 Port to higher-resolution time stamps. Do not assume time_t is signed.
219 (decode_timer): New function. Timers are now vectors of length 9,
220 not 8, to accommodate the picosecond component.
221 (timer_check_2): Use it.
223 * nsterm.m (select_timeout, timeval_subtract): Remove.
224 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
225 as they're a bit more accurate and handle overflow better.
226 (ns_select): Change prototype to be compatible with pselect.
227 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
228 * nsterm.h (ns_select): Adjust prototype.
230 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
231 us-resolution time stamps.
232 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
234 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
236 * lisp.h (time_overflow): New decl.
237 (wait_reading_process_output): First arg is now intmax_t, not int,
238 to accommodate larger waits.
240 * process.h (struct Lisp_Process.read_output_delay):
241 Now counts nanoseconds, not microseconds.
242 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
244 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
245 (wait_reading_process_output):
246 Port to ns-resolution time stamps.
247 (Faccept_process_output, wait_reading_process_output):
248 Check for time stamp overflow. Do not assume time_t is signed.
249 (select_wrapper): Remove; we now use pselect.
250 (Fprocess_attributes): Now generates ns-resolution time stamps.
252 * sysdep.c: Include utimens.h. Don't include utime.h
253 or worry about struct utimbuf; gnulib does that for us now.
254 (gettimeofday): Remove; gnulib provides a substitute.
255 (make_timeval): New function.
256 (set_file_times): Now sets ns-resolution time stamps.
257 New arg FD; all uses changed.
258 (time_from_jiffies, ltime_from_jiffies, get_up_time)
259 (system_process_attributes):
260 Now returns ns-resolution time stamp. All uses changed.
261 Check for time stamp overflow.
263 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
264 provides a substitute now.
266 * systime.h: Include timespec.h rather than sys/time.h and time.h,
267 since it guarantees struct timespec.
268 (EMACS_TIME): Now struct timespec, so that we can support
269 ns-resolution time stamps.
270 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
271 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
272 (EMACS_USECS): Remove.
273 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
274 so multiply the arg by 1000 before storing it.
275 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
277 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
278 Port to ns-resolution time stamps.
279 (EMACS_TIME_NEG_P): Remove; replaced by....
280 (EMACS_TIME_SIGN): New macro.
281 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
282 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
283 (set_file_times, make_time, lisp_time_argument): Adjust signature.
284 (make_timeval, make_lisp_time, decode_time_components): New decls.
285 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
286 that it mishandled time_t overflow. You can't compare by subtracting!
287 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
288 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
290 * term.c: Include <sys/time.h>.
291 (timeval_to_Time): New function, for proper overflow wraparound.
292 (term_mouse_position, term_mouse_click): Use it.
294 * undo.c (record_first_change): Support higher-resolution time stamps
296 (Fprimitive_undo): Use them when restoring time stamps.
298 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
299 (w32_get_internal_run_time):
300 Port to higher-resolution Emacs time stamps.
301 (ltime): Now accepts single 64-bit integer, as that's more convenient
304 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
306 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
307 for compatibility with pselect. Support ns-resolution time stamps.
309 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
311 * xselect.c (wait_for_property_change, x_get_foreign_selection):
312 Check for time stamp overflow, and support ns-resolution time stamps.
314 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
315 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
316 (timeval_subtract): Remove; no longer needed.
317 (XTflash, XTring_bell, x_wait_for_event):
318 Port to ns-resolution time stamps. Don't assume time_t is signed.
320 2012-06-22 Chong Yidong <cyd@gnu.org>
322 * xdisp.c (x_consider_frame_title): Revert last change.
324 2012-06-22 Eli Zaretskii <eliz@gnu.org>
326 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
327 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
328 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
329 staticidx goes up to 1597 out of 1600 = 0x640.)
331 2012-06-20 Paul Eggert <eggert@cs.ucla.edu>
333 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
334 Otherwise, the umask might be mistakenly 0 while handling input signals.
336 2012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
338 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
340 2012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
342 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
343 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
344 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
345 access to `contents' member of Lisp_Vector objects with AREF and ASET
348 2012-06-19 Chong Yidong <cyd@gnu.org>
350 * frame.c (delete_frame): When selecting a frame on a different
351 text terminal, do not alter the terminal's top-frame.
353 * xdisp.c (format_mode_line_unwind_data): Record the target
354 frame's selected window and its terminal's top-frame.
355 (unwind_format_mode_line): Restore them.
356 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
358 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
359 since tty frames can be explicitly named.
360 (prepare_menu_bars): Likewise.
362 * term.c (Ftty_top_frame): New function.
364 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
366 Port byte-code-meter to modern targets.
367 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
368 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
369 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
370 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
371 (METER_1, METER_2): Simplify.
373 2012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
375 * data.c (Fdefalias): Return `symbol' (bug#11686).
377 2012-06-18 Martin Rudalics <rudalics@gmx.at>
379 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
380 gets killed during executing of this function (Bug#11665).
381 Try to always return Qt when the buffer has been actually killed.
382 (Vkill_buffer_query_functions): In doc-string say that functions
383 run by this hook should not change the current buffer.
385 2012-06-18 Paul Eggert <eggert@cs.ucla.edu>
387 Fix recently-introduced process.c problems found by static checking.
388 * process.c (write_queue_push, write_queue_pop, send_process):
389 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
390 (write_queue_pop): Fix pointer signedness problem.
391 (send_process): Remove unused local.
393 2012-06-17 Chong Yidong <cyd@gnu.org>
395 * xdisp.c (redisplay_internal): No need to redisplay terminal
396 frames that are not on top.
398 2012-06-17 Troels Nielsen <bn.troels@gmail.com>
400 * process.c (make_process): Initialize write_queue.
401 (write_queue_push, write_queue_pop): New functions.
402 (send_process): Use them to maintain correct ordering of process
405 2012-06-17 Paul Eggert <eggert@cs.ucla.edu>
407 * lisp.h (eassert): Assume C89 or later.
408 This removes the need for CHECK.
409 (CHECK): Remove. Its comments about always evaluating its
410 argument were confusing, as 'eassert' typically does not evaluate
413 * coding.c (produce_chars): Use ptrdiff_t, not int.
415 * xterm.c (x_draw_underwave): Check for integer overflow.
416 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
418 2012-06-17 Jan Djärv <jan.h.d@swipnet.se>
420 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
421 referenced (Bug#11583).
423 2012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
425 Implement wave-style variant of underlining.
426 * dispextern.h (face_underline_type): New enum.
427 (face): Add field for underline type.
428 * nsterm.m (ns_draw_underwave): New function.
429 (ns_draw_text_decoration): Use it.
430 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
432 (x_draw_glyph_string): Use them.
433 * xfaces.c (Qline, Qwave): New Lisp objects.
434 (check_lface_attrs, merge_face_ref)
435 (Finternal_set_lisp_face_attribute, realize_x_face):
436 Handle wave-style underline face attributes.
437 * xterm.c (x_draw_underwave): New function.
438 (x_draw_glyph_string): Use it.
440 2012-06-16 Juanma Barranquero <lekktu@gmail.com>
442 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
443 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
444 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
445 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
446 ($(BLD)/w32select.$(O)): Update dependencies.
448 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
450 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
451 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
452 * character.c (_fetch_multibyte_char_p): Remove.
453 * alloc.c: Include "character.h" before "buffer.h".
455 * buffer.c: Likewise.
456 * bytecode.c: Likewise.
457 * callint.c: Likewise.
458 * callproc.c: Likewise.
459 * casefiddle.c: Likewise.
460 * casetab.c: Likewise.
461 * category.c: Likewise.
463 * coding.c: Likewise.
464 * composite.c: Likewise.
466 * dispnew.c: Likewise.
468 * dosfns.c: Likewise.
469 * editfns.c: Likewise.
471 * fileio.c: Likewise.
472 * filelock.c: Likewise.
474 * fontset.c: Likewise.
475 * fringe.c: Likewise.
476 * indent.c: Likewise.
477 * insdel.c: Likewise.
478 * intervals.c: Likewise.
479 * keyboard.c: Likewise.
480 * keymap.c: Likewise.
482 * macros.c: Likewise.
483 * marker.c: Likewise.
484 * minibuf.c: Likewise.
486 * nsmenu.m: Likewise.
488 * process.c: Likewise.
490 * region-cache.c: Likewise.
491 * search.c: Likewise.
492 * syntax.c: Likewise.
494 * textprop.c: Likewise.
496 * unexsol.c: Likewise.
497 * w16select.c: Likewise.
498 * w32fns.c: Likewise.
499 * w32menu.c: Likewise.
500 * window.c: Likewise.
505 * xselect.c: Likewise.
507 2012-06-16 Eli Zaretskii <eliz@gnu.org>
509 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
510 If all the glyphs of the glyph row came from strings, and we have no
511 cursor positioning clues, put the cursor on the first glyph of the
513 (handle_face_prop): Use chunk-relative overlay string index when
514 indexing into it->string_overlays array. (Bug#11653)
515 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
516 the rightmost. (Bug#11720)
518 2012-06-16 Andreas Schwab <schwab@linux-m68k.org>
520 * category.h (CHAR_HAS_CATEGORY): Define as inline.
521 (CATEGORY_MEMBER): Enforce 1/0 value.
522 * category.c (_temp_category_set): Remove.
524 2012-06-16 Eli Zaretskii <eliz@gnu.org>
526 * window.c (Fdelete_other_windows_internal)
527 (Fdelete_window_internal): Don't access frame's mouse highlight
528 info of the initial frame. (Bug#11677)
530 2012-06-14 Paul Eggert <eggert@cs.ucla.edu>
532 * .gdbinit (xgetint): Fix recently-introduced paren typo.
533 Assume USE_2_TAGS_FOR_INTS.
534 (xreload): Adjust $tagmask width to match recent lisp.h change.
536 Simplify lisp.h in minor ways that should not affect code.
537 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
538 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
539 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
540 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
541 (INTTYPEBITS): New macro, for clarity.
542 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
543 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
544 Simplify now that USE_LSB_TAG is always defined.
545 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
546 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
548 2012-06-13 Juanma Barranquero <lekktu@gmail.com>
550 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
552 2012-06-13 Glenn Morris <rgm@gnu.org>
554 * s/bsd-common.h (BSD4_3):
555 * s/usg5-4-common.h (USG5_4): No longer define; unused.
557 2012-06-13 Andreas Schwab <schwab@linux-m68k.org>
559 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
562 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
564 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
565 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
566 * alloc.c (widen_to_Lisp_Object): Remove.
567 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
568 * frame.c (delete_frame): Remove outdated comment.
569 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
571 (Fw32_unregister_hot_key): Likewise.
572 (Fw32_toggle_lock_key): Likewise.
573 * w32menu.c (add_menu_item): Likewise.
574 (w32_menu_display_help): Use XIL instead of checking
576 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
577 (init_heap): Likewise.
578 * w32term.c (w32_read_socket): Update comment.
580 2012-06-13 Glenn Morris <rgm@gnu.org>
582 * s/usg5-4-common.h, src/s/unixware.h:
583 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
585 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
587 2012-06-13 Paul Eggert <eggert@cs.ucla.edu>
589 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
590 * alloc.c (make_number) [!defined make_number]:
591 Remove, as lisp.h always defines this now.
592 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
593 (roundup_size): Verify that it is a power of 2.
594 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
595 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
596 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
597 -DUSE_LSB_TAG=0, to override the automatically-selected default.
598 USE_LSB_TAG now is always defined to be either 0 or 1.
600 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
601 code works fine either way, and efficiency is not a concern here,
602 as the union type is for debugging, not for production.
603 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
604 Use an inline function on all platforms when using the union type,
605 since this is simpler and 'static inline' can be used portably
607 (LISP_INITIALLY_ZERO): New macro.
608 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
609 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
611 2012-06-12 Glenn Morris <rgm@gnu.org>
613 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
615 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
617 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
618 Move BROKEN_SIGIO to configure.
620 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
621 Move NO_TERMIO to configure.
623 2012-06-12 Chong Yidong <cyd@gnu.org>
625 * image.c (imagemagick_load_image): Use MagickFlattenImage if
626 MagickMergeImageLayers is undefined. Use pixel pusher loop if
627 MagickExportImagePixels is undefined.
629 2012-06-12 Paul Eggert <eggert@cs.ucla.edu>
631 * image.c (imagemagick_load_image): Remove unused label.
633 2012-06-11 Glenn Morris <rgm@gnu.org>
635 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
636 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
637 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
638 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
640 2012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
642 * alloc.c (make_byte_code): New function.
643 (Fmake_byte_code): Use it. Don't purify here.
644 * lread.c (read1): Use it as well to avoid extra allocation.
646 2012-06-11 Chong Yidong <cyd@gnu.org>
648 * image.c (imagemagick_load_image): Implement transparency.
650 2012-06-10 Andreas Schwab <schwab@linux-m68k.org>
652 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
653 account for preceding backslashes. (Bug#11663)
655 2012-06-09 Chong Yidong <cyd@gnu.org>
657 * term.c: Support italics in capable terminals (Bug#9652).
658 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
659 (turn_on_face): Output using TS_enter_italic_mode if available.
660 Don't handle unused blinking and alt-charset cases.
661 (turn_off_face): Handle italic case; discard unused tty_blinking_p
662 and tty_alt_charset_p cases.
663 (tty_capable_p, init_tty): Support italics.
665 * termchar.h (struct tty_display_info): Add field for italics.
666 Remove unused blink field.
668 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
671 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
672 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
673 tty_alt_charset_p. Add tty_italic_p.
675 2012-06-09 Michael Albinus <michael.albinus@gmx.de>
677 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
678 dbus_type_is_basic if available.
679 (xd_extract_signed, xd_extract_unsigned): Rename from
680 extract_signed and extract_unsigned, respectively. Adapt callers.
682 2012-06-09 Chong Yidong <cyd@gnu.org>
684 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
686 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
689 2012-06-08 Paul Eggert <eggert@cs.ucla.edu>
691 * xdisp.c (vmessage): Treat frame message as multibyte.
692 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
693 would generate the diagnostic "Making \302\247 buffer-local while
696 2012-06-08 Eli Zaretskii <eliz@gnu.org>
698 * dispnew.c (showing_window_margins_p): Undo last change, which
699 was done due to an inadvertent commit.
700 (adjust_frame_glyphs_for_frame_redisplay): Do call
701 showing_window_margins_p.
703 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
705 * eval.c (Fmake_var_non_special): New primitive.
706 (syms_of_eval): Defsubr it.
707 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
709 2012-06-08 Juanma Barranquero <lekktu@gmail.com>
711 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
712 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
714 2012-06-08 Eli Zaretskii <eliz@gnu.org>
716 * alloc.c (allocate_vectorlike): Fix last change.
718 2012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
720 Block-based vector allocation of small vectors.
721 * lisp.h (struct vectorlike_header): New field `nbytes',
722 adjust comment accordingly.
723 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
724 to denote vector blocks. Adjust users (live_vector_p,
725 mark_maybe_pointer, valid_lisp_object_p) accordingly.
726 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
727 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
728 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
729 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
730 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
731 (roundup_size): New constant.
732 (struct vector_block): New data type.
733 (vector_blocks, vector_free_lists, zero_vector): New variables.
734 (all_vectors): Rename to `large_vectors'.
735 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
736 (sweep_vectors): New functions.
737 (allocate_vectorlike): Return `zero_vector' as the only vector of
738 0 items. Allocate new vector from block if vector size is less than
739 or equal to VBLOCK_BYTES_MAX.
740 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
741 (init_alloc_once): Add call to init_vectors.
743 2012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
745 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
747 2012-06-07 Paul Eggert <eggert@cs.ucla.edu>
749 * doprnt.c (doprnt): Truncate multibyte char correctly.
750 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
751 would mishandle a string argument "Xc" if X was a multibyte
752 character of length 2: it would truncate after X's first byte
753 rather than including all of X.
755 2012-06-06 Chong Yidong <cyd@gnu.org>
757 * buffer.c (word_wrap): Doc fix.
759 2012-06-04 Paul Eggert <eggert@cs.ucla.edu>
761 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
763 2012-06-03 Glenn Morris <rgm@gnu.org>
765 * xdisp.c (tool-bar-style): Doc fix.
767 2012-06-03 Ulrich Müller <ulm@gentoo.org>
769 * Makefile.in (PAXCTL): Define.
770 (temacs$(EXEEXT)): Disable memory randomization for the temacs
771 binary via PaX flags if the paxctl utility is available.
772 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
773 Restore PaX flags to their default. (Bug#11398)
775 2012-06-03 Chong Yidong <cyd@gnu.org>
777 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
780 2012-06-03 Chong Yidong <cyd@gnu.org>
782 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
783 (note_mode_line_or_margin_highlight): If there is no help echo,
784 use mode-line-default-help-echo. Handle the case where the mouse
785 position is past the end of the mode line string.
787 * buffer.c (buffer_local_value_1): New function, split from
788 Fbuffer_local_value; can return Qunbound.
789 (Fbuffer_local_value): Use it.
790 (Vmode_line_format): Docstring tweaks.
792 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
794 * sysdep.c (system_process_attributes): Improve comment.
796 2012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
798 * keyboard.c: Export real-this-command to Elisp.
799 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
800 and DEFVAR it. Update all users.
802 2012-06-02 Paul Eggert <eggert@cs.ucla.edu>
804 * minibuf.c (Fassoc_string): Remove duplicate declaration.
806 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
807 Convert pctcpu and pctmem to Lisp float properly.
808 Let the compiler fold better, as 100.0/0x8000 is exact.
810 2012-06-02 Andreas Schwab <schwab@linux-m68k.org>
812 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
815 2012-06-01 Paul Eggert <eggert@cs.ucla.edu>
817 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
819 2012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
821 For a 'struct window', replace some Lisp_Object fields to
822 bitfields where appropriate, remove unused fields.
823 * window.h (struct window): Remove unused 'last_mark_x' and
824 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
825 change it's type from Lisp_Object to bitfield.
826 Change type of 'force_start', 'optional_new_start',
827 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
828 fields from Lisp_Object to bitfield. Adjust users accordingly.
830 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
832 Pacify gcc -Wdouble-precision when using Xaw.
833 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
834 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
835 Use 'float' consistently, rather than 'float' in most places
836 and 'double' in a couple of places.
838 2012-05-31 Eli Zaretskii <eliz@gnu.org>
840 * xdisp.c (handle_stop): Detect whether we have overlay strings
841 loaded by testing it->current.overlay_string_index to be
842 non-negative, instead of checking whether n_overlay_strings is
843 positive. (Bug#11587)
845 2012-05-31 Chong Yidong <cyd@gnu.org>
847 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
849 * doc.c (Fsubstitute_command_keys): Doc fix.
851 2012-05-31 Eli Zaretskii <eliz@gnu.org>
853 * search.c (search_buffer): Remove calls to
854 r_alloc_inhibit_buffer_relocation, as it is now called by
855 maybe_unify_char, which was the cause of relocation of buffer text
858 2012-05-31 Eli Zaretskii <eliz@gnu.org>
860 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
861 for the duration of call to load_charset, to avoid problems with
862 callers of maybe_unify_char that access buffer text through C
865 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
866 decrement the inhibition flag, instead of just setting or
869 2012-05-31 Paul Eggert <eggert@cs.ucla.edu>
871 Remove obsolete '#define static' cruft.
872 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
873 This #undef was "temporary" in 2000; it is no longer needed
874 now that '#define static' has gone away.
875 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
876 (gray_bitmap_bits): Remove; no longer needed.
877 All uses replaced with definiens.
878 * xterm.c: Include "bitmaps/gray.xbm".
880 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
882 Clean up __executable_start, monstartup when --enable-profiling.
883 The following changes affect the code only when profiling.
884 * dispnew.c (__executable_start): Rename from safe_bcopy.
885 Define only on platforms that need it.
886 * emacs.c: Include <sys/gmon.h> when profiling.
887 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
888 (__executable_start): Remove decl, since lisp.h does it now.
889 (safe_bcopy): Remove decl; no longer has that name.
890 (main): Coalesce #if into single bit of code, for simplicity.
891 Cast pointers to uintptr_t, since standard libraries want integers
893 * lisp.h (__executable_start): New decl.
895 2012-05-31 Glenn Morris <rgm@gnu.org>
897 * image.c (Fimagemagick_types): Doc fix.
899 2012-05-30 Jim Meyering <meyering@redhat.com>
901 * callproc.c (Fcall_process_region): Include directory component
902 in mkstemp error message (Bug#11586).
904 2012-05-30 Paul Eggert <eggert@cs.ucla.edu>
906 * alloc.c, lisp.h (make_pure_vector): Now static.
908 2012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
910 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
912 (Fautoload): Do the hash-doc more carefully.
913 * data.c (Fdefalias): Purify definition, except for keymaps.
914 (Qdefun): Move from eval.c.
915 * lisp.h (Qdefun): Remove.
916 * lread.c (read1): Tiny simplification.
918 2012-05-29 Troels Nielsen <bn.troels@gmail.com>
920 Do not create empty overlays with the evaporate property (Bug#9642).
921 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
922 Bug#9642, but explicitly check that the buffer the overlay would
923 be moved to is live and rearrange lines to make sure that errors
924 will not put the overlay in an inconsistent state.
925 (Fdelete_overlay): Cosmetics.
927 2012-05-28 Eli Zaretskii <eliz@gnu.org>
929 * w32term.c (my_bring_window_to_top): New function.
930 (x_raise_frame): Use handle returned by DeferWindowPos, which
931 could be different from the original one.
932 Call my_bring_window_to_top instead of my_set_foreground_window.
935 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
936 by calling BringWindowToTop.
938 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
939 (WM_EMACS_END): Increase by one.
941 2012-05-28 Paul Eggert <eggert@cs.ucla.edu>
943 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
944 This avoids undefined behavior that might cause the eassert
945 to not catch an out-of-range value.
947 2012-05-28 Juanma Barranquero <lekktu@gmail.com>
949 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
952 2012-05-27 Eli Zaretskii <eliz@gnu.org>
954 * bidi.c (bidi_mirror_char): Fix last change.
956 2012-05-27 Andreas Schwab <schwab@linux-m68k.org>
958 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
959 when referring to sectname field in printf format.
961 2012-05-27 Paul Eggert <eggert@cs.ucla.edu>
963 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
964 Only r_alloc_inhibit_buffer_relocation needed to be added;
965 the others were already declared.
967 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
968 before checking whether it's out of range. Put the check inside
970 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
972 2012-05-27 Ken Brown <kbrown@cornell.edu>
974 * callproc.c (Fcall_process): Restore a line that was accidentally
975 commented out in the 2011-02-13 change (bug#11547).
977 2012-05-27 Eli Zaretskii <eliz@gnu.org>
979 * lisp.h [REL_ALLOC]: Add prototypes for external functions
982 * buffer.c [REL_ALLOC]: Remove prototypes of
983 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
984 they are now on lisp.h.
986 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
988 * search.c (search_buffer): Use it to inhibit relocation of buffer
989 text while re_search_2 is doing its job, because re_search_2 is
990 passed C pointers to buffer text. (Bug#11519)
992 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
995 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
996 state after an additional call to move_it_in_display_line_to, keep
997 the values of it->max_ascent and it->max_descent found for the
999 (pos_visible_p): Revert the comparison against bottom_y to what it
1000 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
1003 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1005 Fix coding-related core dumps with gcc -ftrapv.
1006 The code was computing A - B, where A and B are pointers, and B is
1007 random garbage. This can lead to core dumps on platforms that
1008 have special pointer registers, and it also leads to core dumps on
1009 x86-64 when compiled with gcc -ftrapv. The fix is to compute
1010 A - B only when B is initialized properly.
1011 * coding.c (coding_set_source, coding_set_destination): Return void.
1012 (coding_change_source, coding_change_destinations): New functions,
1013 with the old behaviors of coding_set_source and coding_set_destination.
1014 All callers that need an offset changed to use these new functions.
1016 2012-05-26 Glenn Morris <rgm@gnu.org>
1018 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
1020 2012-05-26 Eli Zaretskii <eliz@gnu.org>
1022 Extend mouse support on W32 text-mode console.
1023 * xdisp.c (draw_row_with_mouse_face):
1024 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
1026 * w32console.c: Include window.h.
1027 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
1029 (initialize_w32_display): Initialize mouse-highlight data.
1031 * w32inevt.c: Include termchar.h and window.h.
1032 (do_mouse_event): Support mouse-autoselect-window. When the mouse
1033 moves, call note_mouse_highlight. If help_echo changed, call
1034 gen_help_event to produce help-echo message in the echo area.
1035 Call clear_mouse_face if mouse_face_hidden is set in the mouse
1038 2012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1040 * lread.c (read1): Simplify slightly to avoid an overflow warning
1041 with GCC 4.7.0 on x86-64.
1043 2012-05-26 Eli Zaretskii <eliz@gnu.org>
1045 * bidi.c (bidi_mirror_char): Revert last change: an int is
1046 definitely wide enough here.
1048 2012-05-25 Paul Eggert <eggert@cs.ucla.edu>
1050 Fix integer width and related bugs (Bug#9874).
1051 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
1052 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
1053 (string_bytes, check_sblock, allocate_string_data):
1054 (compact_small_strings, Fmake_bool_vector, make_string)
1055 (make_unibyte_string, make_multibyte_string)
1056 (make_string_from_bytes, make_specified_string)
1057 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
1058 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
1060 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1061 (allocate_pseudovector):
1062 Use int, not EMACS_INT, where int is wide enough.
1063 (inhibit_garbage_collection, Fgarbage_collect):
1064 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1065 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
1066 int might not be wide enough.
1067 (bidi_cache_search, bidi_cache_find, bidi_init_it)
1068 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
1069 (bidi_at_paragraph_end, bidi_find_paragraph_start)
1070 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1071 (bidi_level_of_next_char, bidi_move_to_visually_next):
1072 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1073 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
1074 (Fkill_buffer, Fset_buffer_major_mode)
1075 (advance_to_char_boundary, Fbuffer_swap_text)
1076 (Fset_buffer_multibyte, overlays_at, overlays_in)
1077 (overlay_touches_p, struct sortvec, record_overlay_string)
1078 (overlay_strings, recenter_overlay_lists)
1079 (adjust_overlays_for_insert, adjust_overlays_for_delete)
1080 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
1081 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
1082 (Foverlay_recenter, last_overlay_modification_hooks_used)
1083 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
1084 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1085 (validate_region): Omit unnecessary test for b <= e,
1086 since that's guaranteed by the previous test.
1087 (adjust_overlays_for_delete): Avoid pos + length overflow.
1088 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
1089 (report_overlay_modification):
1090 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1091 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
1092 Omit pointer cast, which isn't needed anyway, and doesn't work
1093 after the EMACS_INT -> ptrdiff_t change.
1094 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
1095 * buffer.h: Adjust decls to match defn changes elsewhere.
1096 (struct buffer_text, struct buffer):
1097 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1098 Use EMACS_INT, not int, where int might not be wide enough.
1099 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
1100 not int, to avoid needless 32-bit limit on 64-bit hosts.
1101 (exec_byte_code): Use tighter memory-full test, one that checks
1102 for alloca overflow. Don't compute the address of the object just
1103 before an array, as that's not portable. Use EMACS_INT, not
1104 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
1105 * callint.c (Fcall_interactively):
1106 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1107 * callproc.c (call_process_kill, Fcall_process):
1108 Don't assume pid_t fits into an Emacs fixnum.
1109 (call_process_cleanup, Fcall_process, child_setup):
1110 Don't assume pid_t fits into int.
1111 (call_process_cleanup, Fcall_process, delete_temp_file)
1112 (Fcall_process_region):
1113 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1114 (Fcall_process): Simplify handling of volatile integers.
1115 Use int, not EMACS_INT, where int will do.
1116 * casefiddle.c (casify_object, casify_region, operate_on_word)
1117 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
1118 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1119 (casify_object): Avoid integer overflow when overallocating buffer.
1120 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
1121 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
1122 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
1123 * category.h (CATEGORYP): Don't assume arg is nonnegative.
1124 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
1125 integers are now checked earlier. All uses replaced with XINT.
1127 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1128 For CCL_MapSingle, check that content and value are in int range.
1129 (ccl_driver, Fregister_code_conversion_map):
1130 Check that Vcode_version_map_vector is a vector.
1131 (resolve_symbol_ccl_program): Check that vector header is in range.
1132 Always copy the vector, so that we can check its contents reliably
1133 now rather than having to recheck each instruction as it's being
1134 executed. Check that vector words fit in 'int'.
1135 (ccl_get_compiled_code, Fregister_ccl_program)
1136 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
1137 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
1138 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
1139 contents are in range.
1140 (Fccl_execute_on_string): Check that status is in range.
1141 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
1142 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
1143 Accept and return EMACS_INT, not int, because callers can pass values
1145 (c_string_width, strwidth, lisp_string_width, chars_in_text)
1146 (multibyte_chars_in_text, parse_str_as_multibyte)
1147 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
1148 (str_as_unibyte, str_to_unibyte, string_count_byte8)
1149 (string_escape_byte8, Fget_byte):
1150 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1151 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
1152 avoid mishandling large integers.
1153 * character.h: Adjust decls to match defn changes elsewhere.
1154 * charset.c (load_charset_map_from_file, find_charsets_in_text)
1155 (Ffind_charset_region):
1156 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1157 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
1158 (load_charset_map_from_vector, Fdefine_charset_internal):
1159 Don't assume fixnum fits in int.
1160 (load_charset_map_from_vector, Fmap_charset_chars):
1161 Remove now-unnecessary CHECK_NATNUMs.
1162 (Fdefine_charset_internal): Check ranges here, more carefully.
1163 Don't rely on undefined behavior with signed left shift overflow.
1164 Don't assume unsigned int fits into fixnum, or that fixnum fits
1165 into unsigned int. Don't require max_code to be a valid fixnum;
1166 that's not true for gb10830 4-byte on a 32-bit host. Allow
1167 invalid_code to be a cons, for the same reason. Require code_offset
1168 to be a character. Avoid int overflow if max_char is close
1170 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
1171 this is intended anyway and avoids some undefined behavior.
1172 (load_charset_map): Pass unsigned, not int, as 2nd arg of
1173 INDEX_TO_CODE_POINT, as that's what it expects.
1174 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
1175 * charset.h (DECODE_CHAR): Return int, not unsigned;
1176 this is what was intended anyway, and it avoids undefined behavior.
1177 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
1178 integer-overflow issues.
1179 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
1180 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
1181 where the argument is EMACS_INT, and this behavior is not intended.
1182 * chartab.c (Fmake_char_table, Fset_char_table_range)
1183 (uniprop_get_decoder, uniprop_get_encoder):
1184 Don't assume fixnum fits in int.
1185 * cmds.c (move_point): New function, that does the gist of
1186 Fforward_char and Fbackward_char, but does so while checking
1187 for integer overflow more accurately.
1188 (Fforward_char, Fbackward_char): Use it.
1189 (Fforward_line, Fend_of_line, internal_self_insert)
1190 (internal_self_insert):
1191 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1192 Fix a FIXME, by checking for integer overflow when calculating
1193 target_clm and actual_clm.
1194 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
1195 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
1196 (ASSURE_DESTINATION, coding_alloc_by_realloc)
1197 (coding_alloc_by_making_gap, alloc_destination)
1198 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
1199 (encode_coding_utf_16, detect_coding_emacs_mule)
1200 (decode_coding_emacs_mule, encode_coding_emacs_mule)
1201 (detect_coding_iso_2022, decode_coding_iso_2022)
1202 (encode_invocation_designation, encode_designation_at_bol)
1203 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1204 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
1205 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
1206 (encode_coding_ccl, encode_coding_raw_text)
1207 (detect_coding_charset, decode_coding_charset)
1208 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
1209 (produce_composition, produce_charset, produce_annotation)
1210 (decode_coding, handle_composition_annotation)
1211 (handle_charset_annotation, consume_chars, decode_coding_gap)
1212 (decode_coding_object, encode_coding_object, detect_coding_system)
1213 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
1214 (code_convert_region, code_convert_string)
1215 (Fdefine_coding_system_internal)
1216 (coding_set_source, coding_set_destination):
1217 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1218 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
1219 (Fdefine_coding_system_internal):
1220 Don't assume fixnums fit in int.
1221 (decode_coding_gap, decode_coding_object, encode_coding_object)
1222 (Fread_coding_system, Fdetect_coding_region)
1223 (Funencodable_char_position, Fcheck_coding_systems_region)
1224 (get_translation, handle_composition_annotation, consume_chars):
1225 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1226 (consume_chars): Rewrite to not calculate an address outside buffer.
1227 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
1228 Don't access memory outside of the args array.
1229 (Fdefine_coding_system_internal): Check for charset-id overflow.
1230 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
1231 result of ENCODE_CHAR.
1232 * coding.h: Adjust decls to match defn changes elsewhere.
1233 (struct coding_system):
1234 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1235 * composite.c (get_composition_id, find_composition)
1236 (run_composition_function, update_compositions)
1237 (compose_text, composition_gstring_put_cache)
1238 (composition_gstring_p, composition_gstring_width)
1239 (fill_gstring_header, fill_gstring_body, autocmp_chars)
1240 (composition_compute_stop_pos, composition_reseat_it)
1241 (composition_update_it, struct position_record)
1242 (find_automatic_composition, composition_adjust_point)
1243 (Fcomposition_get_gstring, Ffind_composition_internal):
1244 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1245 (update_compositions):
1246 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1247 * composite.h: Adjust decls to match defn changes elsewhere.
1248 (struct composition):
1249 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1250 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
1251 Do not attempt to compute the address of the object just before a
1252 buffer; this is not portable.
1254 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1255 (Faset): Use int, not EMACS_INT, where int is wide enough.
1256 (Fstring_to_number): Don't assume fixnums fit in int.
1257 (Frem): Don't assume arg is nonnegative.
1258 * dbusbind.c (xd_append_arg): Check for integers out of range.
1259 (Fdbus_call_method): Don't overflow the timeout int.
1260 (extract_signed, extract_unsigned): New functions.
1261 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
1262 (xd_get_connection_references): Return ptrdiff_t, not int.
1264 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
1265 (xd_read_message_1):
1266 Use int, not unsigned, where the dbus API uses int.
1267 (Fdbus_message_internal): Don't overflow mtype.
1268 (syms_of_dbusbind): Allocate right-sized buffer for integers.
1269 * dired.c (directory_files_internal, file_name_completion, scmp)
1270 (file_name_completion_stat):
1271 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1272 (file_name_completion): Don't overflow matchcount.
1273 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
1274 * dispextern.h: Adjust decls to match defn changes elsewhere.
1275 (struct text_pos, struct glyph, struct bidi_saved_info)
1276 (struct bidi_string_data, struct bidi_it, struct composition_it)
1278 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1279 (struct display_pos, struct composition_it, struct it):
1280 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1281 * dispnew.c (increment_matrix_positions)
1282 (increment_row_positions, mode_line_string)
1283 (marginal_area_string):
1284 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1285 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
1286 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1287 (duration_to_sec_usec): New function, to check for overflow better.
1288 (Fsleep_for, sit_for): Use it.
1289 * doc.c (get_doc_string, store_function_docstring):
1290 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1291 (get_doc_string, Fsnarf_documentation):
1292 Use int, not EMACS_INT, where int is wide enough.
1294 Use SAFE_ALLOCA, not alloca.
1295 Check for overflow when converting EMACS_INT to off_t.
1296 * doprnt.c (doprnt):
1297 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1298 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
1299 Don't assume uid_t fits into fixnum.
1300 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
1301 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
1302 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
1303 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
1304 (general_insert_function)
1305 (Finsert_char, make_buffer_string, make_buffer_string_both)
1306 (update_buffer_properties, Fbuffer_substring)
1307 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
1308 (Fsubst_char_in_region, check_translation)
1309 (Ftranslate_region_internal, save_restriction_restore, Fformat)
1310 (transpose_markers, Ftranspose_regions):
1311 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1312 (clip_to_bounds): Move to lisp.h as an inline function).
1313 (Fconstrain_to_field): Don't assume integers are nonnegative.
1314 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
1315 (Fsubst_char_in_region, Fsave_restriction):
1316 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1317 (Femacs_pid): Don't assume pid_t fits into fixnum.
1318 (lo_time): Use int, not EMACS_INT, when int suffices.
1319 (lisp_time_argument): Check for usec out of range.
1320 (Fencode_time): Don't assume fixnum fits in int.
1321 (Fuser_login_name, Fuser_full_name): Signal an error
1322 if a uid argument is out of range, rather than relying on
1324 (Fformat_time_string): Remove now-unnecessary check.
1325 lisp_time_argument checks for out-of-range usec now.
1326 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
1327 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
1328 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
1329 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
1330 (init_cmdargs, Fdump_emacs):
1331 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1332 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
1333 the bottom (typically) 32 bits of the fixnum.
1334 * eval.c (specpdl_size, call_debugger):
1335 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1336 (when_entered_debugger, Fbacktrace_debug):
1337 Don't assume fixnum can fit in int.
1338 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
1339 the object just before a buffer; this is not portable.
1340 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
1341 (grow_specpdl, unbind_to):
1342 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1343 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
1344 (grow_specpdl): Simplify allocation by using xpalloc.
1345 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
1346 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
1347 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
1348 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1349 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
1351 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1352 (Fcopy_file, non_regular_nbytes, read_non_regular)
1353 (Finsert_file_contents):
1354 Use int, not EMACS_INT, where int is wide enough.
1355 (READ_BUF_SIZE): Verify that it fits in int.
1356 (Finsert_file_contents): Check that counts are in proper range,
1357 rather than assuming fixnums fit into ptrdiff_t etc.
1358 Don't assume fixnums fit into int.
1359 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
1360 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
1361 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
1362 (string_char_to_byte, string_byte_to_char)
1363 (string_make_multibyte, string_to_multibyte)
1364 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
1365 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
1366 (substring_both, Fdelete, internal_equal, Ffillarray)
1367 (Fclear_string, mapcar1)
1368 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
1369 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
1370 (larger_vector, make_hash_table, maybe_resize_hash_table)
1371 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
1372 (Fmaphash, secure_hash):
1373 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1374 (concat): Check for string index and length overflow.
1375 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
1377 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1378 (larger_vector): New API (vec, incr_min, size_max) replaces old
1379 one (vec, new_size, init). This catches size overflow.
1380 INIT was removed because it was always Qnil.
1381 All callers changed.
1382 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
1383 the upper bound on a hash table index size.
1384 (make_hash_table, maybe_resize_hash_table): Use it.
1385 (secure_hash): Computer start_byte and end_byte only after
1386 they're known to be in ptrdiff_t range.
1387 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
1388 (Ffont_get_glyphs, Ffont_at):
1389 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1390 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
1391 (Flist_fonts, Fopen_font):
1392 Don't assume fixnum can fit in int.
1393 (check_gstring): Don't assume index can fit in int.
1394 (font_match_p): Check that fixnum is a character, not a nonnegative
1395 fixnum, since the later code needs to stuff it into an int.
1396 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
1397 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
1398 conversion overflow issues.
1399 (Fopen_font): Check for integer out of range.
1400 (Ffont_get_glyphs): Don't assume index can fit in int.
1401 * font.h: Adjust decls to match defn changes elsewhere.
1402 * fontset.c (reorder_font_vector): Redo score calculation to avoid
1404 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
1405 printmax_t, where ptrdiff_t is wide enough.
1406 (Finternal_char_font):
1407 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1408 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
1409 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
1410 (Fset_frame_position, x_set_frame_parameters)
1411 (x_set_line_spacing, x_set_border_width)
1412 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
1413 Check that fixnums are in proper range for system types.
1414 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
1415 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1416 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
1417 Use SAFE_ALLOCA_LISP, not alloca.
1418 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
1419 intptr_t is wide enough.
1420 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
1421 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
1422 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
1423 Check for fixnum out of range.
1424 * ftfont.c (ftfont_list): Don't assume index fits in int.
1425 Check that fixnums are in proper range for system types.
1426 (ftfont_shape_by_flt):
1427 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1428 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1429 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1430 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
1431 Check that fixnums are in proper range for system types.
1432 * gnutls.h: Adjust decls to match defn changes elsewhere.
1433 * gtkutil.c (xg_dialog_run):
1434 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1435 (update_frame_tool_bar):
1436 Check that fixnums are in proper range for system types.
1437 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
1438 (lookup_image): Check that fixnums are in range for system types.
1439 * indent.c (last_known_column, last_known_column_point):
1440 (current_column_bol_cache):
1441 (skip_invisible, current_column, check_display_width):
1442 (check_display_width, scan_for_column, current_column_1)
1443 (Findent_to, Fcurrent_indentation, position_indentation)
1444 (indented_beyond_p, Fmove_to_column, compute_motion):
1445 (Fcompute_motion, Fvertical_motion):
1446 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1447 (last_known_column_modified): Use EMACS_INT, not int.
1448 (check_display_width):
1450 Check that fixnums and floats are in proper range for system types.
1451 (compute_motion): Don't assume index or fixnum fits in int.
1452 (compute_motion, Fcompute_motion):
1453 Use int, not EMACS_INT, when it is wide enough.
1454 (vmotion): Omit local var start_hpos that is always 0; that way
1455 we don't need to worry about overflow in expressions involving it.
1456 * indent.h: Adjust decls to match defn changes elsewhere.
1458 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1459 Use int, not EMACS_INT, where int is wide enough.
1460 Remove unused members ovstring_chars_done and tab_offset;
1462 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
1463 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
1464 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
1465 (make_gap, copy_text, insert, insert_and_inherit)
1466 (insert_before_markers, insert_before_markers_and_inherit)
1467 (insert_1, count_combining_before, count_combining_after)
1468 (insert_1_both, insert_from_string)
1469 (insert_from_string_before_markers, insert_from_string_1)
1470 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
1471 (adjust_after_replace, adjust_after_insert, replace_range)
1472 (replace_range_2, del_range, del_range_1, del_range_byte)
1473 (del_range_both, del_range_2, modify_region)
1474 (prepare_to_modify_buffer, signal_before_change)
1475 (signal_after_change, Fcombine_after_change_execute):
1476 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1477 * intervals.c (traverse_intervals, rotate_right, rotate_left)
1478 (balance_an_interval, split_interval_right, split_interval_left)
1479 (find_interval, next_interval, update_interval)
1480 (adjust_intervals_for_insertion, delete_node, delete_interval)
1481 (interval_deletion_adjustment, adjust_intervals_for_deletion)
1482 (static_offset_intervals, offset_intervals)
1483 (merge_interval_right, merge_interval_left, make_new_interval)
1484 (graft_intervals_into_buffer, temp_set_point_both)
1485 (temp_set_point, set_point, adjust_for_invis_intang)
1486 (set_point_both, move_if_not_intangible, get_property_and_range)
1487 (get_local_map, copy_intervals, copy_intervals_to_string)
1488 (compare_string_intervals, set_intervals_multibyte_1):
1489 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1490 * intervals.h: Adjust decls to match defn changes elsewhere.
1492 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1493 * keyboard.c (this_command_key_count, this_single_command_key_start)
1494 (before_command_key_count, before_command_echo_length, echo_now)
1495 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
1496 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
1497 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
1498 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
1499 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1500 (last_non_minibuf_size, last_point_position, echo_truncate)
1501 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
1502 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
1503 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
1504 (stuff_buffered_input):
1505 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1506 (last_auto_save, command_loop_1, read_char):
1507 Use EMACS_INT, not int, to avoid integer overflow.
1508 (record_char): Avoid overflow in total_keys computation.
1509 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
1510 * keyboard.h: Adjust decls to match defn changes elsewhere.
1511 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
1512 (Fkey_description, Fdescribe_vector, Flookup_key):
1513 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1514 (click_position): New function, to check that positions are in range.
1515 (Fcurrent_active_maps):
1517 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1518 (Faccessible_keymaps, Fkey_description):
1519 (preferred_sequence_p):
1520 Don't assume fixnum can fit into int.
1521 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
1522 Check for integer overflow in size calculations.
1523 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
1524 avoid mishandling large integers.
1525 * lisp.h: Adjust decls to match defn changes elsewhere.
1526 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
1527 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
1528 (struct Lisp_Marker):
1529 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1530 (clip_to_bounds): Now an inline function, moved here from editfns.c.
1531 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
1532 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
1533 All callers changed.
1534 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
1535 Assume the arg has valid form, since it always does.
1536 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
1537 unsigned integer system type.
1538 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
1539 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
1540 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1541 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
1542 (duration_to_sec_usec): New decl.
1543 * lread.c (read_from_string_index, read_from_string_index_byte)
1544 (read_from_string_limit, readchar, unreadchar, openp)
1545 (read_internal_start, read1, oblookup):
1546 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1547 (Fload, readevalloop, Feval_buffer, Feval_region):
1548 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1549 (openp): Check for out-of-range argument to 'access'.
1550 (read1): Use int, not EMACS_INT, where int is wide enough.
1551 Don't assume fixnum fits into int.
1552 Fix off-by-one error that can read outside a buffer.
1553 (read_filtered_event): Use duration_to_sec_usec
1554 to do proper overflow checking on durations.
1555 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
1556 in size calculation.
1557 (Fexecute_kbd_macro):
1558 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1559 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
1560 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
1561 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
1562 (set_marker_both, set_marker_restricted_both, marker_position)
1563 (marker_byte_position, Fbuffer_has_markers_at):
1564 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1565 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
1566 * menu.c (ensure_menu_items): Rename from grow_menu_items.
1567 It now merely ensures that the menu is large enough, without
1568 necessarily growing it, as this avoids some integer overflow issues.
1569 All callers changed.
1570 (keymap_panes, parse_single_submenu, Fx_popup_menu):
1571 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1572 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
1573 Use SAFE_ALLOCA_LISP, not alloca.
1574 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
1575 to EMACS_INT. Check that fixnums are in proper range for system types.
1576 * minibuf.c (minibuf_prompt_width, string_to_object)
1577 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
1578 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
1579 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1580 (get_minibuffer, read_minibuf_unwind):
1581 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1582 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
1583 this simplifies overflow checking. All callers changed.
1584 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
1586 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1587 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
1588 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
1589 Check that fixnums are in proper range for system types.
1590 (Fx_create_frame, Fx_show_tip):
1591 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1592 * nsfont.m (ns_findfonts, nsfont_list_family):
1593 Don't assume fixnum fits in long.
1594 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
1595 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1596 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
1598 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
1599 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1600 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
1601 (PRINTDECLARE, PRINTPREPARE):
1602 (strout, print_string):
1603 (print, print_preprocess, print_check_string_charset_prop)
1605 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1607 (temp_output_buffer_setup, Fprin1_to_string, print_object):
1608 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1609 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
1610 (printchar, strout): Use xpalloc to catch size calculation overflow.
1611 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
1612 (print_error_message): Use SAFE_ALLOCA, not alloca.
1613 (print_object): Use int, not EMACS_INT, where int is wide enough.
1614 (print_depth, new_backquote_output, print_number_index):
1615 Use ptrdiff_t, not int, where int might not be wide enough.
1616 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
1617 (Fset_process_window_size, Fformat_network_address)
1618 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
1620 Check that fixnums are in proper range for system types.
1621 (Fsignal_process): Simplify by avoiding a goto.
1622 Check for process-ids out of pid_t range rather than relying on
1624 (process_tick, update_tick): Use EMACS_INT, not int.
1625 (Fformat_network_address, read_process_output, send_process)
1626 (Fprocess_send_region, status_notify):
1627 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1628 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
1629 (wait_reading_process_output, read_process_output, exec_sentinel):
1630 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1631 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
1632 (Faccept_process_output): Use duration_to_sec_usec to do proper
1633 overflow checking on durations.
1634 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
1635 Don't assume pid_t fits in int.
1636 * process.h (struct Lisp_Process): Members tick and update_tick
1637 are now of type EMACS_INT, not int.
1638 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
1639 configured --with-wide-int.
1640 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
1641 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
1642 * search.c (looking_at_1, string_match_1):
1643 (fast_string_match, fast_c_string_match_ignore_case)
1644 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
1645 (scan_newline, find_before_next_newline, search_command)
1646 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
1647 (set_search_regs, wordify):
1650 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1651 (string_match_1, search_buffer, set_search_regs):
1653 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1654 (wordify): Check for overflow in size calculation.
1655 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
1656 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
1657 Check that fixnums are in proper range for system types.
1658 * sound.c (struct sound_device)
1659 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
1660 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1661 (Fplay_sound_internal):
1662 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1663 * syntax.c (struct lisp_parse_state, find_start_modiff)
1664 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
1665 (Fparse_partial_sexp):
1666 Don't assume fixnums can fit in int.
1667 (struct lisp_parse_state, find_start_pos, find_start_value)
1668 (find_start_value_byte, find_start_begv)
1669 (update_syntax_table, char_quoted, dec_bytepos)
1670 (find_defun_start, prev_char_comend_first, back_comment):
1671 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
1672 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
1673 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1674 (Finternal_describe_syntax_value): Check that match_lisp is a
1675 character, not an integer, since the code stuffs it into int.
1676 (scan_words, scan_sexps_forward):
1677 Check that fixnums are in proper range for system types.
1679 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1680 (scan_sexps_forward):
1681 Use CHARACTERP, not INTEGERP, since the value must fit into int.
1682 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
1683 * syntax.h: Adjust decls to match defn changes elsewhere.
1684 (struct gl_state_s):
1685 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1686 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
1687 MOST_POSITIVE_FIXNUM.
1688 * sysdep.c (wait_for_termination_1, wait_for_termination)
1689 (interruptible_wait_for_termination, mkdir):
1690 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
1691 (emacs_read, emacs_write):
1692 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1693 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
1694 and double all fit in int.
1695 * term.c (set_tty_color_mode):
1696 Check that fixnums are in proper range for system types.
1697 * termhooks.h (struct input_event):
1698 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1699 * textprop.c (validate_interval_range, interval_of)
1700 (Fadd_text_properties, set_text_properties_1)
1701 (Fremove_text_properties, Fremove_list_of_text_properties)
1702 (Ftext_property_any, Ftext_property_not_all)
1703 (copy_text_properties, text_property_list, extend_property_ranges)
1704 (verify_interval_modification):
1705 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1706 (Fnext_single_char_property_change)
1707 (Fprevious_single_char_property_change):
1708 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1709 (copy_text_properties):
1710 Check for integer overflow in index calculation.
1711 * undo.c (last_boundary_position, record_point, record_insert)
1712 (record_delete, record_marker_adjustment, record_change)
1713 (record_property_change):
1714 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1715 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
1716 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1717 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1718 (Fx_hide_tip, Fx_file_dialog):
1719 * w32menu.c (set_frame_menubar):
1720 Use ptrdiff_t, not int, for consistency with rest of code.
1721 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
1722 (select_window, Fdelete_other_windows_internal)
1723 (window_scroll_pixel_based, window_scroll_line_based)
1724 (Frecenter, Fset_window_configuration):
1725 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1726 (Fset_window_hscroll, run_window_configuration_change_hook)
1727 (set_window_buffer, temp_output_buffer_show, scroll_command)
1728 (Fscroll_other_window, Frecenter):
1729 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1730 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
1731 Don't assume fixnum fits in int.
1732 (Fset_window_scroll_bars):
1733 Check that fixnums are in proper range for system types.
1734 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
1735 (string_pos, c_string_pos, number_of_chars, init_iterator)
1736 (in_ellipses_for_invisible_text_p, init_from_display_pos)
1737 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
1738 (compute_display_string_end, handle_face_prop)
1739 (face_before_or_after_it_pos, handle_invisible_prop)
1740 (handle_display_prop, handle_display_spec, handle_single_display_spec)
1741 (display_prop_intangible_p, string_buffer_position_lim)
1742 (string_buffer_position, handle_composition_prop, load_overlay_strings)
1743 (get_overlay_strings_1, get_overlay_strings)
1744 (iterate_out_of_display_property, forward_to_next_line_start)
1745 (back_to_previous_visible_line_start, reseat, reseat_to_string)
1746 (get_next_display_element, set_iterator_to_next)
1747 (get_visually_first_element, compute_stop_pos_backwards)
1748 (handle_stop_backwards, next_element_from_buffer)
1749 (move_it_in_display_line_to, move_it_in_display_line)
1750 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1751 (add_to_log, message_dolog, message_log_check_duplicate)
1752 (message2, message2_nolog, message3, message3_nolog
1753 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
1754 (current_message_1, truncate_echo_area, truncate_message_1)
1755 (set_message, set_message_1, store_mode_line_noprop)
1756 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
1757 (text_outside_line_unchanged_p, check_point_in_composition)
1758 (reconsider_clip_changes)
1759 (redisplay_internal, set_cursor_from_row, try_scrolling)
1760 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
1761 (redisplay_window, find_last_unchanged_at_beg_row)
1762 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
1763 (trailing_whitespace_p, find_row_edges, display_line)
1764 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
1765 (display_mode_element, store_mode_line_string)
1766 (pint2str, pint2hrstr, decode_mode_spec)
1767 (display_count_lines, display_string, draw_glyphs)
1768 (x_produce_glyphs, x_insert_glyphs)
1769 (rows_from_pos_range, mouse_face_from_buffer_pos)
1770 (fast_find_string_pos, mouse_face_from_string_pos)
1771 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1772 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1773 (safe_call, init_from_display_pos, handle_fontified_prop)
1774 (handle_single_display_spec, load_overlay_strings)
1775 (with_echo_area_buffer, setup_echo_area_for_printing)
1776 (display_echo_area, echo_area_display)
1777 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
1778 (update_tool_bar, hscroll_window_tree, redisplay_internal)
1779 (redisplay_window, dump_glyph_row, display_mode_line)
1780 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
1781 (handle_display_spec, display_prop_string_p):
1782 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1783 (handle_single_display_spec, build_desired_tool_bar_string)
1784 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
1785 (get_specified_cursor_type):
1786 Check that fixnums are in proper range for system types.
1787 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
1788 (Flookup_image_map):
1789 Don't assume fixnums fit in int.
1790 (compare_overlay_entries):
1791 Avoid mishandling comparisons due to subtraction overflow.
1792 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
1793 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
1794 (handle_tool_bar_click):
1795 Use int, not unsigned, since we prefer signed and the signedness
1796 doesn't matter here.
1797 (get_next_display_element, next_element_from_display_vector):
1798 Use int, not EMACS_INT, when int is wide enough.
1799 (start_hourglass): Use duration_to_sec_usec to do proper
1800 overflow checking on durations.
1801 * xfaces.c (Fbitmap_spec_p):
1802 Check that fixnums are in proper range for system types.
1803 (compare_fonts_by_sort_order):
1804 Avoid mishandling comparisons due to subtraction overflow.
1805 (Fx_family_fonts, realize_basic_faces):
1806 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1808 Don't assume fixnum fits in int.
1809 Use SAFE_ALLOCA_LISP, not alloca.
1810 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
1811 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
1812 (face_at_buffer_position, face_for_overlay_string)
1813 (face_at_string_position):
1814 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1815 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
1816 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
1818 Check that fixnums are in proper range for system types.
1819 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1820 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
1821 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1822 (Fx_change_window_property): Don't assume fixnums fit in int.
1823 * xfont.c (xfont_chars_supported):
1824 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1825 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
1826 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
1827 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1828 * xml.c (parse_region):
1829 * xrdb.c (magic_file_p):
1830 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1831 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
1832 (x_get_local_selection, x_reply_selection_request)
1833 (x_handle_selection_request, wait_for_property_change):
1834 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1835 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
1836 short is wide enough.
1837 (x_send_client_event): Don't assume fixnum fits in int.
1838 * xterm.c (x_x_to_emacs_modifiers):
1839 Don't assume EMACS_INT overflows nicely into int.
1840 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
1842 (handle_one_xevent): NATNUMP can eval its arg twice.
1843 (x_connection_closed):
1844 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1845 * xterm.h: Adjust decls to match defn changes elsewhere.
1846 (struct scroll_bar): Use struct vectorlike_header
1847 rather than rolling our own approximation.
1848 (SCROLL_BAR_VEC_SIZE): Remove; not used.
1850 2012-05-25 Glenn Morris <rgm@gnu.org>
1852 * lisp.mk (lisp): Update for more files being compiled now.
1854 2012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
1856 * lread.c: Remove `read_pure' which makes no difference.
1857 (read_pure): Remove var.
1858 (unreadpure): Remove function.
1859 (readevalloop): Don't call read_list with -1 flag.
1860 (read1, read_vector): Don't test read_pure any more.
1861 (read_list): Simplify.
1863 * fileio.c, character.h: Minor style tweaks.
1865 2012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
1867 * window.h (clip_changed): Remove useless declaration.
1869 2012-05-22 Juanma Barranquero <lekktu@gmail.com>
1871 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
1872 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
1874 2012-05-22 Paul Eggert <eggert@cs.ucla.edu>
1877 This directory predates autoconf and is no longer needed nowadays.
1878 Move its few remaining bits of functionality to where they're needed.
1879 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
1880 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
1881 * m/template.h: Remove.
1882 * Makefile.in (M_FILE): Remove. All uses removed.
1883 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
1884 * lisp.h (USE_LSB_TAG):
1885 * mem-limits.h (EXCEEDS_LISP_PTR):
1886 Use VAL_MAX, not VALBITS, in #if.
1887 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
1888 (EMACS_UINT): Define unconditionally now.
1889 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
1890 (BITS_PER_EMACS_INT): New constants, replacing
1891 what used to be in config.h, but not useful in #if.
1892 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
1893 define them any more.
1894 (VAL_MAX): New macro.
1896 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
1897 BITS_PER_EMACS_INT, in #if.
1898 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
1899 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
1900 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
1901 * s/ms-w32.h (DATA_START):
1902 Move here from removed file m/intel386.h.
1903 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
1904 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
1906 2012-05-21 Paul Eggert <eggert@cs.ucla.edu>
1908 Assume C89 or later.
1909 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
1910 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
1912 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
1913 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
1914 * textprop.c, tparam.c (NULL): Remove.
1915 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
1916 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
1917 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
1918 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
1919 * xterm.c (input_signal_count): Assume volatile works.
1921 2012-05-21 Ken Brown <kbrown@cornell.edu>
1923 * xgselect.c (xg_select): Fix first argument in call to 'select'
1926 2012-05-20 Ken Brown <kbrown@cornell.edu>
1928 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
1929 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1931 2012-05-19 Ken Brown <kbrown@cornell.edu>
1933 * xfns.c (x_in_use): Remove `static' qualifier.
1934 * xterm.h (x_in_use): Declare.
1935 * xgselect.c: Include xterm.h.
1936 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
1937 and `display_arg' (bug#9754).
1939 2012-05-19 Paul Eggert <eggert@cs.ucla.edu>
1941 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
1943 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
1944 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
1946 2012-05-18 Eli Zaretskii <eliz@gnu.org>
1948 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
1950 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
1951 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
1953 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
1954 reference to image_cache->refcount.
1955 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
1957 2012-05-17 Juri Linkov <juri@jurta.org>
1959 * search.c (Fword_search_regexp, Fword_search_backward)
1960 (Fword_search_forward, Fword_search_backward_lax)
1961 (Fword_search_forward_lax): Move functions to isearch.el
1962 (bug#10145, bug#11381).
1964 2012-05-16 Paul Eggert <eggert@cs.ucla.edu>
1966 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
1968 2012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
1970 * lread.c (init_obarray): Declare Qt and Qnil as special.
1972 2012-05-14 Glenn Morris <rgm@gnu.org>
1974 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
1975 Put "libexec" before "bin", for the sake of init_callproc_1.
1977 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1979 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
1981 * unexaix.c: Port to more-recent AIX compilers.
1982 (report_error, report_error_1, make_hdr, copy_sym)
1983 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
1984 Make arguments const char *, not char *, to avoid violations of C
1985 standard and to fix some AIX warnings reported by Gilles Pion.
1987 2012-05-14 Eli Zaretskii <eliz@gnu.org>
1989 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
1990 already have overlays loaded.
1991 (handle_single_display_spec): Before returning without displaying
1992 fringe bitmap, synchronize the bidi iterator with the main display
1993 iterator, by calling iterate_out_of_display_property.
1994 (iterate_out_of_display_property): Detect buffer iteration by
1995 testing that it->string is a Lisp string.
1996 (get_next_display_element): When the current object is exhausted,
1997 and there's something on it->stack, call set_iterator_to_next to
1998 proceed with what's on the stack, instead of returning zero.
1999 (set_iterator_to_next): If called at the end of a Lisp string,
2000 proceed to consider_string_end without incrementing string
2001 position. Don't increment display vector index past the end of
2002 the display vector. (Bug#11417)
2003 (pos_visible_p): Don't report a position visible when move_it_to
2004 stopped at the last line of window, which happens to be scanned
2005 backwards by the bidi iteration. (Bug#11464)
2007 2012-05-14 Eli Zaretskii <eliz@gnu.org>
2009 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
2010 and right-margin display specs even if the spec is invalid or we
2011 are on a TTY, and thus unable to display on the fringes.
2012 That's because the text with the property will not be displayed anyway,
2013 so we need to signal to the caller that this is a "replacing"
2014 display spec. This fixes display when the spec is invalid or we
2017 2012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2019 * unexaix.c (make_hdr): Fix typo in prototype.
2020 This bug broke the build on AIX. Problem reported by Gilles Pion.
2022 2012-05-14 Michael Albinus <michael.albinus@gmx.de>
2024 * keyboard.c (kbd_buffer_get_event): Read special events also in
2025 batch mode. (Bug#11415)
2027 2012-05-12 Glenn Morris <rgm@gnu.org>
2029 * ns.mk: Update for ns_appbindir no longer having trailing "/".
2031 2012-05-12 Eli Zaretskii <eliz@gnu.org>
2033 * lisp.mk (lisp): Add newcomment.elc.
2035 2012-05-12 Glenn Morris <rgm@gnu.org>
2037 * Makefile.in (MKDIR_P): New, set by configure.
2038 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
2040 2012-05-11 Paul Eggert <eggert@cs.ucla.edu>
2042 Remove unused function hourglass_started.
2043 * dispextern.h (hourglass_started):
2044 * w32fns.c (hourglass_started):
2045 * xdisp.c (hourglass_started): Remove.
2047 2012-05-10 Juanma Barranquero <lekktu@gmail.com>
2049 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
2050 Update dependencies.
2052 2012-05-10 Paul Eggert <eggert@cs.ucla.edu>
2054 * xgselect.c (xg_select): Put maxfds+1 into a var.
2055 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
2057 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
2059 2012-05-10 Dave Abrahams <dave@boostpro.com>
2061 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
2062 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
2064 2012-05-09 Michael Albinus <michael.albinus@gmx.de>
2066 * dbusbind.c (xd_registered_buses): New internal Lisp object.
2067 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
2068 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
2069 Initialize xd_registered_buses.
2071 2012-05-09 Paul Eggert <eggert@cs.ucla.edu>
2073 Untag more efficiently if USE_LSB_TAG.
2074 This is based on a proposal by YAMAMOTO Mitsuharu in
2075 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
2076 For an admittedly artificial (nth 8000 longlist) benchmark on
2077 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
2078 Emacs's overall text size by 1%.
2079 * lisp.h (XUNTAG): New macro.
2080 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
2081 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
2082 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
2083 * eval.c (Fautoload):
2084 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
2085 * frame.h (XFRAME): Use XUNTAG.
2087 Port recent dbusbind.c changes to 32-bit --with-wide-int.
2088 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
2089 Remove unportable assumptions about print widths of types like
2091 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
2092 intptr_t when converting between pointer and integer, to avoid GCC
2093 warnings about wrong width.
2095 2012-05-09 Eli Zaretskii <eliz@gnu.org>
2097 * w32proc.c (new_child): Force Windows to reserve only 64KB of
2098 stack for each reader_thread, instead of defaulting to 8MB
2099 determined by the linker. This avoids failures in creating
2100 subprocesses on Windows 7, see the discussion in this thread:
2101 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
2103 2012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
2105 Fix up display of the *Minibuf-0* buffer in the mini window.
2106 * keyboard.c (read_char): Don't clear the echo area if there's no
2108 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2109 contents of *Minibuf-0*) if there's no message displayed in its stead.
2111 2012-05-07 Michael Albinus <michael.albinus@gmx.de>
2113 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
2116 2012-05-06 Chong Yidong <cyd@gnu.org>
2118 * lisp.mk (lisp): Update.
2120 2012-05-05 Jim Meyering <meyering@redhat.com>
2122 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
2124 2012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
2126 * data.c (PUT_ERROR): New macro.
2127 (syms_of_data): Use it. Add new error type `user-error'.
2128 * undo.c (user_error): New function.
2129 (Fprimitive_undo): Use it.
2130 * print.c (print_error_message): Adjust print style for `user-error'.
2131 * keyboard.c (user_error): New function.
2132 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
2134 2012-05-03 Paul Eggert <eggert@cs.ucla.edu>
2136 Do not limit current-time-string to years 1000..9999.
2137 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
2138 (Fcurrent_time_string): Support any year that is supported by the
2139 underlying localtime representation. Don't use asctime, as it
2140 has undefined behavior for years outside the range -999..9999.
2142 2012-05-02 Paul Eggert <eggert@cs.ucla.edu>
2144 Fix race conditions involving setenv, gmtime, localtime, asctime.
2145 Without this fix, interrupts could mess up code that uses these
2146 nonreentrant functions, since setting TZ invalidates existing
2147 tm_zone or tzname values, and since most of these functions return
2148 pointers to static storage.
2149 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
2150 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
2151 Grow the critical sections to include not just invoking
2152 localtime/gmtime, but also accessing these functions' results
2153 including their tm_zone values if any, and any related TZ setting.
2154 (format_time_string): Last arg is now struct tm *, not struct tm **,
2155 so that the struct tm is saved in the critical section.
2156 All callers changed. Simplify allocation of initial buffer, partly
2157 motivated by the fact that memory allocation needs to be outside
2158 the critical section.
2160 2012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
2162 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
2163 with RESET_INTERVAL.
2165 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2166 Remove duplicated buffer name initialization.
2168 2012-05-02 Jim Meyering <jim@meyering.net>
2170 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
2172 * xfns.c (x_window): Use xstrdup (Bug#11375).
2174 2012-05-02 Eli Zaretskii <eliz@gnu.org>
2176 * xdisp.c (pos_visible_p): If already at a newline from the
2177 display string before the 'while' loop, don't walk back the glyphs
2178 from it3.glyph_row. Solves assertion violation when the display
2179 string begins with a newline (egg.el). (Bug#11367)
2181 2012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
2183 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
2186 2012-05-01 Glenn Morris <rgm@gnu.org>
2188 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
2189 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
2190 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
2191 All were removed before 23.1.
2193 * dispnew.c: Remove HAVE_LIBNCURSES test;
2194 it is always true on relevant platforms.
2196 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
2197 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
2199 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
2201 2012-04-30 Andreas Schwab <schwab@linux-m68k.org>
2203 * .gdbinit (xpr): Remove checks for no longer existing misc types.
2204 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
2207 2012-04-28 Paul Eggert <eggert@cs.ucla.edu>
2209 Do not avoid creating empty evaporating overlays (Bug#9642).
2210 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
2211 That is, do not delete an evaporating overlay if it becomes
2212 empty after its bounds are adjusted to fit within its buffer.
2213 This fix caused other problems, and I'm reverting it until we get
2214 to the bottom of them.
2216 2012-04-27 Chong Yidong <cyd@gnu.org>
2218 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
2220 2012-04-27 Eli Zaretskii <eliz@gnu.org>
2222 * xdisp.c (pos_visible_p): If the window start position is beyond
2223 ZV, start the display from buffer beginning. Prevents assertion
2224 violation in init_iterator when the minibuffer window is scrolled
2227 * window.c (window_scroll_pixel_based): Likewise.
2229 2012-04-27 Chong Yidong <cyd@gnu.org>
2231 * keymap.c (where_is_internal): Doc fix (Bug#10872).
2233 2012-04-27 Glenn Morris <rgm@gnu.org>
2235 * fileio.c (Fcopy_file, Fset_file_selinux_context):
2236 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
2238 2012-04-27 Eli Zaretskii <eliz@gnu.org>
2240 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
2241 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
2243 2012-04-26 Eli Zaretskii <eliz@gnu.org>
2245 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
2246 display element, check also the underlying string or buffer
2247 character. (Bug#11341)
2249 * w32menu.c: Include w32heap.h.
2250 (add_menu_item): If the call to AppendMenuW (via
2251 unicode_append_menu) fails, disable Unicode menus only if we are
2252 running on Windows 9X/Me.
2254 2012-04-24 Andreas Schwab <schwab@linux-m68k.org>
2256 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
2257 (xgetint): Add missing shift for LSB tags.
2259 2012-04-24 Martin Rudalics <rudalics@gmx.at>
2261 * keyboard.c (read_char): Don't wipe echo area for select window
2262 events: These might get delayed via `mouse-autoselect-window'
2265 2012-04-24 Juanma Barranquero <lekktu@gmail.com>
2267 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
2268 manipulation of :loaded-from data.
2270 2012-04-23 Juanma Barranquero <lekktu@gmail.com>
2272 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
2273 now a cons (bug#11311).
2275 2012-04-23 Paul Eggert <eggert@cs.ucla.edu>
2277 Do not create empty overlays with the evaporate property (Bug#9642).
2278 * buffer.c (Fmove_overlay): Delete an evaporating overlay
2279 if it becomes empty after its bounds are adjusted to fit within
2280 its buffer. Without this fix, in a nonempty buffer (let ((o
2281 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
2282 yields an empty overlay that has the evaporate property, which is
2283 not supposed to happen.
2285 Fix minor GTK3 problems found by static checking.
2286 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2287 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2288 (struct _EmacsFixedClass, emacs_fixed_get_type):
2289 Move decls here from emacsgtkfixed.h, since they needn't be public.
2290 (emacs_fixed_get_type): Now static.
2291 (emacs_fixed_class_init): Omit unused local.
2292 (emacs_fixed_child_type): Remove; unused.
2293 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2294 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2295 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
2296 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
2297 (EMACS_FIXED_GET_CLASS): Remove; unused.
2298 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
2300 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
2301 Problem reported by Juanma Barranquero for Windows -Wunused-function.
2303 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2305 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
2306 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
2307 (__malloc_size_t, __malloc_ptrdiff_t):
2308 Remove. All uses removed, replaced by the definiens if needed,
2309 since we can assume C89 or better now.
2310 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
2311 (protect_malloc_state, align, get_contiguous_space)
2312 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
2313 (malloc_atfork_handler_child, malloc_enable_thread)
2314 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
2315 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
2316 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
2317 (special_realloc, _realloc_internal_nolock, _realloc_internal)
2318 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
2319 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
2320 Define using prototypes, not old style.
2321 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
2322 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
2323 (align): Don't assume that signed integer overflow wraps around.
2324 Omit unused local var.
2325 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
2326 (_free_internal_nolock, memalign, mallochook, reallochook):
2327 Omit no-longer-needed casts.
2328 (valloc): Use getpagesize, not __getpagesize.
2329 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
2330 (struct hdr): The 'magic' member is now size_t, not unsigned long.
2332 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
2334 2012-04-22 Michael Albinus <michael.albinus@gmx.de>
2336 Move functions from C to Lisp. Make non-blocking method calls
2337 the default. Implement further D-Bus standard interfaces.
2339 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
2340 (QCdbus_request_name_allow_replacement)
2341 (QCdbus_request_name_replace_existing)
2342 (QCdbus_request_name_do_not_queue)
2343 (QCdbus_request_name_reply_primary_owner)
2344 (QCdbus_request_name_reply_in_queue)
2345 (QCdbus_request_name_reply_exists)
2346 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
2347 (QCdbus_registered_serial, QCdbus_registered_method)
2348 (QCdbus_registered_signal): New Lisp objects.
2349 (XD_DEBUG_MESSAGE): Use sizeof.
2350 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
2351 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
2352 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
2353 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
2354 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
2355 (xd_signature, xd_append_arg): Allow float for integer types.
2356 (xd_get_connection_references): New function.
2357 (xd_get_connection_address): Rename from xd_initialize.
2358 Return cached address.
2359 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
2360 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
2362 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
2363 Return number of refcounts.
2364 (Fdbus_get_unique_name): Make stronger parameter check.
2365 (Fdbus_message_internal): New defun.
2366 (Fdbus_call_method, Fdbus_call_method_asynchronously)
2367 (Fdbus_method_return_internal, Fdbus_method_error_internal)
2368 (Fdbus_send_signal, Fdbus_register_service)
2369 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
2370 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
2371 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
2372 (Vdbus_compiled_version, Vdbus_runtime_version)
2373 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
2374 (Vdbus_message_type_method_return, Vdbus_message_type_error)
2375 (Vdbus_message_type_signal): New defvars.
2376 (Vdbus_registered_buses, Vdbus_registered_objects_table):
2379 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2381 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
2382 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
2383 Do not assume ptrdiff_t is the same width as 'int'.
2385 * alloc.c: Handle unusual debugging option combinations.
2386 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
2387 since the two debugging options are incompatible.
2388 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
2390 (mem_init, mem_insert, mem_insert_fixup):
2391 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
2392 (NEED_MEM_INSERT): Remove; no longer needed.
2394 2012-04-22 Leo Liu <sdl.web@gmail.com>
2396 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
2398 2012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2400 * sysdep.c [__FreeBSD__]: Minor cleanups.
2401 (list_system_processes, system_process_attributes) [__FreeBSD__]:
2402 Use Emacs indenting style more consistently. Avoid some casts.
2403 Use 'double' consistently rather than mixing 'float' and 'double'.
2405 2012-04-21 Eduard Wiebe <usenet@pusto.de>
2407 * sysdep.c (list_system_processes, system_process_attributes):
2408 Add implementation for FreeBSD (Bug#5243).
2410 2012-04-21 Andreas Schwab <schwab@linux-m68k.org>
2412 * lisp.mk (lisp): Update.
2414 2012-04-20 Paul Eggert <eggert@cs.ucla.edu>
2416 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
2417 It is never used otherwise.
2419 2012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
2421 * print.c (print_preprocess): Only check print_depth if print-circle
2423 (print_object): Check for cycles even when print-circle is nil and
2424 print-gensym is t, but only check print_depth if print-circle is nil.
2426 2012-04-20 Chong Yidong <cyd@gnu.org>
2428 * process.c (wait_reading_process_output): If EIO occurs on a pty,
2429 set the status to "failed" and ensure that sentinel is run.
2431 2012-04-20 Glenn Morris <rgm@gnu.org>
2433 * process.c (Fset_process_inherit_coding_system_flag)
2434 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
2435 (Fmake_network_process, Fmake_serial_process): Doc fix.
2437 2012-04-20 Eli Zaretskii <eliz@gnu.org>
2439 * xdisp.c (string_buffer_position_lim): Limit starting position to
2441 (set_cursor_from_row): If called for a mode-line or header-line
2442 row, return zero immediately.
2443 (try_cursor_movement): If inside continuation line, don't back up
2444 farther than the first row after the header line, if any.
2445 Don't consider the header-line row as "partially visible", even if
2446 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
2448 2012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
2450 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
2453 2012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
2454 2012-04-18 Paul Eggert <eggert@cs.ucla.edu>
2456 configure: new option --enable-gcc-warnings (Bug#11207)
2457 * Makefile.in (C_WARNINGS_SWITCH): Remove.
2458 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
2459 (ALL_CFLAGS): Use new macros rather than old.
2460 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
2461 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
2462 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
2463 -Wunused-result, -Wunused-variable. This should go away once
2464 the Emacs and Gnulib regex code is merged.
2465 (xmalloc, xrealloc): Now static.
2467 2012-04-17 Paul Eggert <eggert@cs.ucla.edu>
2469 * dired.c (Fsystem_groups): Remove unused local.
2471 2012-04-17 Glenn Morris <rgm@gnu.org>
2473 * dired.c (Fsystem_users): Doc fix.
2475 2012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
2477 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
2478 (syms_of_dired): Add them.
2480 2012-04-16 Paul Eggert <eggert@cs.ucla.edu>
2482 Fix minor alloc.c problems found by static checking.
2483 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
2484 New extern decls, to avoid calling undeclared functions.
2485 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
2486 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
2487 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
2488 (NEED_MEM_INSERT): New macro.
2489 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
2490 Remove one incorrect comment and fix another.
2492 Fix minor ralloc.c problems found by static checking.
2493 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2494 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
2495 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
2496 (r_alloc_sbrk): Now static.
2498 Improve ralloc.c interface checking.
2499 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2500 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
2501 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
2502 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
2503 [REL_ALLOC]: ... to here, to check interface.
2504 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
2505 Remove decls. This fixes an "It stinks!".
2507 * alloc.c (which_symbols): Fix alignment issue / type clash.
2509 2012-04-15 Andreas Schwab <schwab@linux-m68k.org>
2511 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
2512 (struct Lisp_Misc_Any): Likewise.
2513 (struct Lisp_Free): Likewise.
2514 * alloc.c (union aligned_Lisp_Symbol): Define.
2515 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
2516 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
2517 (union aligned_Lisp_Misc): Define.
2518 (MARKER_BLOCK_SIZE, struct marker_block): Use union
2519 aligned_Lisp_Misc instead of union Lisp_Misc.
2520 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
2522 2012-04-14 Paul Eggert <eggert@cs.ucla.edu>
2524 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
2525 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
2526 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
2527 * s/netbsd.h, s/sol2-6.h:
2528 Remove definition of GC_MARK_STACK, since the default now works.
2529 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
2530 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
2531 no longer the default.
2532 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
2534 2012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
2536 * lread.c (lisp_file_lexically_bound_p):
2537 Fix hang at ";-*-\n" (bug#11238).
2539 2012-04-14 Eli Zaretskii <eliz@gnu.org>
2541 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
2542 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
2544 2012-04-14 Jan Djärv <jan.h.d@swipnet.se>
2546 * nsterm.m (constrainFrameRect): Always constrain when there is only
2547 one screen (Bug#10962).
2549 2012-04-13 Ken Brown <kbrown@cornell.edu>
2551 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
2553 2012-04-13 Reuben Thomas <rrt@sc3d.org>
2555 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
2557 2012-04-11 Daniel Colascione <dancol@dancol.org>
2559 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
2560 against is gone. It's better to use vfork now so that when Cygwin
2561 gains a new, working vfork, we use it automatically (bug#10398).
2563 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2565 * window.c (save_window_save): Obey window-point-insertion-type.
2567 2012-04-11 Glenn Morris <rgm@gnu.org>
2569 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
2571 2012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2573 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
2575 2012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
2577 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
2578 (force_quit_count): New var.
2579 (handle_interrupt): Use it.
2581 2012-04-10 Juanma Barranquero <lekktu@gmail.com>
2583 * w32.c (w32_delayed_load): Record the full path of the library
2584 being loaded (bug#10424).
2586 2012-04-09 Glenn Morris <rgm@gnu.org>
2588 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
2589 not just in the obarray, before snarfing them. (Bug#11036)
2591 * Makefile.in ($(leimdir)/leim-list.el):
2592 Pass EMACS rather than BUILT_EMACS.
2594 2012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
2596 * process.c (make_process):
2597 * process.h: Add integer `gnutls_handshakes_tried' member to
2600 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
2601 Add convenience `GNUTLS_LOG2i' macro.
2603 * gnutls.c (gnutls_log_function2i): Convenience log function.
2604 (emacs_gnutls_read): Use new log functions,
2605 `gnutls_handshakes_tried' process member, and
2606 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
2607 attempts per process (connection).
2609 2012-04-09 Chong Yidong <cyd@gnu.org>
2611 * eval.c (Fuser_variable_p, user_variable_p_eh)
2612 (lisp_indirect_variable): Functions deleted.
2613 (Fdefvar): Caller changed.
2615 * callint.c (Finteractive, Fcall_interactively):
2616 * minibuf.c (Fread_variable): Callers changed.
2618 2012-04-09 Eli Zaretskii <eliz@gnu.org>
2620 * xdisp.c (set_cursor_from_row): If the display string appears in
2621 the buffer at position that is closer to point than the position
2622 after the display string, display the cursor on the first glyph of
2623 the display string. Fixes cursor display when a 'display' text
2624 property immediately follows invisible text. (Bug#11094)
2626 2012-04-09 Paul Eggert <eggert@cs.ucla.edu>
2628 composite.c: use 'double' consistently
2629 * composite.c (get_composition_id): Use 'double' consistently
2630 instead of converting 'float' to 'double' and vice versa; this is
2631 easier to understand and avoids a GCC warning.
2633 2012-04-09 Glenn Morris <rgm@gnu.org>
2635 * Makefile.in: Generate leim-list with bootstrap-emacs, in
2636 preparation for dumping it with emacs. (Bug#4789)
2637 (leimdir): New variable.
2638 ($(leimdir)/leim-list.el): New rule.
2639 (emacs$(EXEEXT)): Depend on leim-list.el.
2641 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
2642 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
2643 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
2645 2012-04-08 Andreas Schwab <schwab@linux-m68k.org>
2647 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
2650 2012-04-07 Juanma Barranquero <lekktu@gmail.com>
2652 * xml.c (init_libxml2_functions) [WINDOWSNT]:
2653 Remove unused local variable.
2655 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2657 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
2658 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
2659 (mark_memory): Mark Lisp_Objects only if pointers might hide in
2660 objects, as mark_maybe_pointer will catch them otherwise.
2661 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
2662 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
2664 2012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2666 Fix typo that broke non-Windows builds.
2667 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
2669 2012-04-07 Eli Zaretskii <eliz@gnu.org>
2671 Support building on MS-Windows with libxml2.
2673 * makefile.w32-in (OBJ2): Add xml.$(O).
2674 (GLOBAL_SOURCES): Add xml.c.
2675 ($(BLD)/xml.$(O)): New dependency list.
2677 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
2678 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
2679 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
2680 [!WINDOWSNT]: New macros.
2681 (init_libxml2_functions, libxml2_loaded_p): New functions.
2682 (parse_region): Call fn_xmlCheckVersion instead of using the macro
2683 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
2684 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
2685 Calls xmlCleanupParser only if libxml2 was loaded (or statically
2687 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
2688 Call init_libxml2_functions before calling libxml2 functions.
2689 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
2691 * emacs.c: Don't include libxml/parser.h.
2692 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
2693 xmlCleanupParser directly.
2695 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
2697 2012-04-07 Eli Zaretskii <eliz@gnu.org>
2699 * indent.c (Fvertical_motion): If there is a display string at
2700 point, use it.vpos to compute how many lines to backtrack after
2701 move_it_to point. (Bug#11133)
2703 2012-04-06 Eli Zaretskii <eliz@gnu.org>
2705 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
2706 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
2707 about subtle differences between FETCH_CHAR* and STRING_CHAR*
2708 macros related to unification of CJK characters. For the details,
2709 see the discussion following the message here:
2710 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
2712 2012-04-04 Chong Yidong <cyd@gnu.org>
2714 * keyboard.c (Vdelayed_warnings_list): Doc fix.
2716 2012-04-01 Eli Zaretskii <eliz@gnu.org>
2718 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
2719 instead of alloca. (Bug#11138)
2721 2012-04-01 Andreas Schwab <schwab@linux-m68k.org>
2723 * w32menu.c (is_simple_dialog): Properly check lisp types.
2726 2012-03-31 Eli Zaretskii <eliz@gnu.org>
2728 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
2729 position we get to after a call to move_it_to fails the
2730 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
2731 only if we wind up in a string from display property. (Bug#11063)
2733 * window.c (Fdelete_other_windows_internal): Invalidate the row
2734 and column information about mouse highlight, so that redisplay
2735 restores it after reallocating the glyph matrices. (Bug#7464)
2737 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
2738 string comes from a `display' text property, use the buffer
2739 position of that property as if we actually saw that position in
2741 (move_it_by_lines): Remove the assertion that
2742 "it->current_x == 0 && it->hpos == 0" which can be legitimately
2743 violated when there's a before-string at the beginning of a line.
2746 2012-03-30 Eli Zaretskii <eliz@gnu.org>
2748 * xdisp.c (append_space_for_newline): If the default face was
2749 remapped, use the remapped face for the appended newline.
2750 (extend_face_to_end_of_line): Use the remapped default face for
2751 extending the face to the end of the line.
2752 (display_line): Call extend_face_to_end_of_line when the default
2753 face was remapped. (Bug#11068)
2755 2012-03-29 Eli Zaretskii <eliz@gnu.org>
2757 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
2759 2012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2761 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
2763 2012-03-27 Glenn Morris <rgm@gnu.org>
2765 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
2768 2012-03-26 Kenichi Handa <handa@m17n.org>
2770 * dispextern.h (struct glyph): Fix previous change. Change the
2771 bit length of glyphless.ch to 25 (Bug#11082).
2773 2012-03-26 Chong Yidong <cyd@gnu.org>
2775 * keyboard.c (Vselection_inhibit_update_commands): New variable.
2776 (command_loop_1): Use it; inhibit selection update for
2777 handle-select-window too (Bug#8996).
2779 2012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
2781 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
2783 2012-03-25 Kenichi Handa <handa@m17n.org>
2785 * dispextern.h (struct glyph): Change the bit length of
2786 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
2788 2012-03-24 Eli Zaretskii <eliz@gnu.org>
2790 * s/ms-w32.h (tzname): Include time.h before redirecting to
2791 _tzname. Fixes the MSVC build. (Bug#9960)
2793 2012-03-24 Andreas Schwab <schwab@linux-m68k.org>
2795 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
2798 * xterm.c (XTread_socket): Only modify handling_signal if
2799 !SYNC_INPUT. (Bug#11080)
2801 2012-03-23 Eli Zaretskii <eliz@gnu.org>
2803 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
2804 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
2805 when fetching a multibyte character consumes more bytes than
2806 CHAR_BYTES returns, due to unification of CJK characters in
2807 string_char. (Bug#11073)
2809 2012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
2811 * process.c (wait_reading_process_output): Handle pty disconnect
2812 by refraining from sending oneself a SIGCHLD (bug#10933).
2814 2012-03-22 Chong Yidong <cyd@gnu.org>
2816 * dispextern.h (struct it): New member string_from_prefix_prop_p.
2818 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
2819 Mark string as coming from a prefix property.
2820 (handle_face_prop): Use default face for prefix strings (Bug#4281).
2821 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
2823 2012-03-21 Chong Yidong <cyd@gnu.org>
2825 * xfaces.c (Vface_remapping_alist): Doc fix.
2827 2012-03-20 Eli Zaretskii <eliz@gnu.org>
2829 * w32proc.c (Fw32_set_console_codepage)
2830 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
2833 2012-03-20 Chong Yidong <cyd@gnu.org>
2835 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
2836 to reflect default non-nil value of redisplay-dont-pause.
2838 2012-03-19 Kenichi Handa <handa@m17n.org>
2840 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
2841 it fit in a valid range (Bug#11003).
2843 2012-03-18 Eli Zaretskii <eliz@gnu.org>
2845 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
2846 that is not from display property, accept the row as a "cursor
2847 row" if one of the string's character has a non-nil `cursor'
2848 property. Fixes cursor positioning when there are newlines in
2849 overlay strings, e.g. in icomplete.el. (Bug#11035)
2851 2012-03-12 Paul Eggert <eggert@cs.ucla.edu>
2853 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
2855 2012-03-12 Chong Yidong <cyd@gnu.org>
2857 * eval.c (inhibit_lisp_code): Rename from
2858 inhibit_window_configuration_change_hook; move from window.c.
2860 * xfns.c (unwind_create_frame_1, Fx_create_frame):
2861 * window.c (run_window_configuration_change_hook)
2862 (syms_of_window): Callers changed.
2864 2012-03-11 Chong Yidong <cyd@gnu.org>
2866 * keymap.c (Fkey_description): Doc fix (Bug#9700).
2868 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
2870 2012-03-10 Chong Yidong <cyd@gnu.org>
2872 * frame.c (other_visible_frames): Don't assume the selected frame
2873 is visible (Bug#10955).
2875 2012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
2877 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
2879 2012-03-08 Jan Djärv <jan.h.d@swipnet.se>
2881 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
2882 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
2885 2012-03-03 Glenn Morris <rgm@gnu.org>
2887 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
2889 2012-03-02 Eli Zaretskii <eliz@gnu.org>
2891 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
2892 position past the first glyph_row that ends at ZV. (Bug#10902)
2893 (redisplay_window, next_element_from_string): Fix typos in
2895 (redisplay_window): Pass to move_it_vertically the margin in
2896 pixels, not in screen lines.
2898 2012-03-02 Glenn Morris <rgm@gnu.org>
2900 * buffer.c (buffer-list-update-hook): Doc fix.
2902 2012-02-29 Eli Zaretskii <eliz@gnu.org>
2904 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
2905 push_it before setting up the iterator for the first overlay
2906 string, even if we have an empty string loaded.
2907 (next_overlay_string): If there's an empty string on the iterator
2908 stack, pop the stack. (Bug#10903)
2910 2012-02-25 Paul Eggert <eggert@cs.ucla.edu>
2912 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
2913 Suggested by Stefan Monnier in
2914 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
2915 * alloc.c (widen_to_Lisp_Object): New static function.
2916 (mark_memory): Also mark Lisp_Objects by fetching pointer words
2917 and widening them to Lisp_Objects. This would work even if
2918 USE_LSB_TAG is defined and wide integers are used, which might
2919 happen in a future version of Emacs.
2921 2012-02-25 Chong Yidong <cyd@gnu.org>
2923 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
2926 * xselect.c (Fx_selection_exists_p): Doc fix.
2927 (x_clipboard_manager_save_all): Print an informative message
2928 before saving to clipboard manager.
2930 2012-02-24 Chong Yidong <cyd@gnu.org>
2932 * keyboard.c (process_special_events): Handle all X selection
2933 requests in kbd_buffer, not just the next one (Bug#8869).
2935 2012-02-23 Chong Yidong <cyd@gnu.org>
2937 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
2938 call when setting menu-bar-lines and tool-bar-lines parameters.
2939 (unwind_create_frame_1): New helper function.
2941 * window.c (inhibit_window_configuration_change_hook): New var.
2942 (run_window_configuration_change_hook): Obey it.
2943 (syms_of_window): Initialize it.
2945 2012-02-22 Chong Yidong <cyd@gnu.org>
2947 * xterm.c (x_draw_image_relief): Add missing type check for
2948 Vtool_bar_button_margin (Bug#10743).
2950 2012-02-21 Chong Yidong <cyd@gnu.org>
2952 * fileio.c (Vfile_name_handler_alist): Doc fix.
2954 * buffer.c (Fget_file_buffer): Protect against invalid file
2955 handler return value.
2957 2012-02-20 Paul Eggert <eggert@cs.ucla.edu>
2959 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
2960 when computing $valmask.
2962 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
2963 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
2964 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
2965 It's useless in that case, and it can cause problems on hosts
2966 that allocate halves of EMACS_INT values separately.
2967 Reported by Dan Horák. Diagnosed by Andreas Schwab in
2968 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
2969 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
2970 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
2971 it avoids undefined behavior on hosts where shifting right by more
2972 than the word width has undefined behavior.
2974 2012-02-19 Chong Yidong <cyd@gnu.org>
2976 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
2977 (Funhandled_file_name_directory, Ffile_name_as_directory)
2978 (Fdirectory_file_name, Fexpand_file_name)
2979 (Fsubstitute_in_file_name): Protect against invalid file handler
2980 return values (Bug#10845).
2982 2012-02-18 Eli Zaretskii <eliz@gnu.org>
2984 * .gdbinit (pitx): Fix incorrect references to fields of the
2987 2012-02-17 Chong Yidong <cyd@gnu.org>
2989 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
2991 2012-02-15 Paul Eggert <eggert@cs.ucla.edu>
2993 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
2994 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
2996 2012-02-15 Chong Yidong <cyd@gnu.org>
2998 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
2999 marked as special. Also, starting docstrings with * is obsolete.
3001 2012-02-13 Andreas Schwab <schwab@linux-m68k.org>
3003 * gnutls.c (emacs_gnutls_write): Fix last change.
3005 2012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
3007 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
3010 2012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
3012 * keymap.c (Fsingle_key_description): Handle char ranges.
3014 2012-02-12 Chong Yidong <cyd@gnu.org>
3016 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
3017 as that creates a dangerous corner case.
3019 * window.c (Fdelete_window_internal): Invalidate the mouse
3020 highlight (Bug#9904).
3022 2012-02-12 Glenn Morris <rgm@gnu.org>
3024 * xselect.c (Fx_own_selection_internal)
3025 (Fx_get_selection_internal, Fx_disown_selection_internal)
3026 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
3027 * nsselect.m (Fx_own_selection_internal)
3028 (Fx_disown_selection_internal, Fx_selection_exists_p)
3029 (Fx_selection_owner_p, Fx_get_selection_internal):
3030 Sync docs and argument specs with the xselect.c versions.
3032 2012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
3034 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
3036 2012-02-11 Eli Zaretskii <eliz@gnu.org>
3038 * w32select.c (Fx_selection_exists_p): Sync doc string and
3039 argument list with xselect.c. (Bug#10783)
3041 * w16select.c (Fx_selection_exists_p): Sync doc string and
3042 argument list with xselect.c. (Bug#10783)
3044 2012-02-10 Glenn Morris <rgm@gnu.org>
3046 * fns.c (Fsecure_hash): Doc fix.
3048 2012-02-09 Kenichi Handa <handa@m17n.org>
3050 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
3052 2012-02-07 Chong Yidong <cyd@gnu.org>
3054 * buffer.c (Fbuffer_local_variables)
3055 (buffer_lisp_local_variables): Handle unbound vars correctly;
3056 don't let Qunbound leak into Lisp.
3058 2012-02-07 Glenn Morris <rgm@gnu.org>
3060 * image.c (Fimagemagick_types): Doc fix.
3062 * image.c (imagemagick-render-type): Change it from a lisp object
3063 to an integer. Move the doc here from the lisp manual.
3064 Treat all values not equal to 0 the same.
3066 2012-02-06 Chong Yidong <cyd@gnu.org>
3068 * doc.c (store_function_docstring): Avoid applying docstring of
3069 alias to base function (Bug#2603).
3071 2012-02-04 Andreas Schwab <schwab@linux-m68k.org>
3073 * .gdbinit (pp1, pv1): Remove redundant defines.
3076 2012-02-04 Chong Yidong <cyd@gnu.org>
3078 * nsterm.m: Declare a global (Bug#10694).
3080 2012-02-04 Eli Zaretskii <eliz@gnu.org>
3082 * w32.c (get_emacs_configuration_options):
3083 Include --enable-checking, if specified, in the return value.
3085 2012-02-04 Martin Rudalics <rudalics@gmx.at>
3087 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
3088 after rounding frame sizes. (Bug#9723)
3090 2012-02-04 Eli Zaretskii <eliz@gnu.org>
3092 * keyboard.c (adjust_point_for_property): Don't position point
3093 before BEGV. (Bug#10696)
3095 2012-02-03 Paul Eggert <eggert@cs.ucla.edu>
3097 Handle overflow when computing char display width (Bug#9496).
3098 * character.c (char_width): Return EMACS_INT, not int.
3099 (char_width, c_string_width): Check for overflow when
3100 computing the width; this is possible now that individual
3101 characters can have unbounded width. Problem introduced
3102 by merge from Emacs 23 on 2012-01-19.
3104 2012-02-02 Michael Albinus <michael.albinus@gmx.de>
3106 * dbusbind.c (Fdbus_register_method): Mention the return value
3107 :ignore in the docstring.
3109 2012-02-02 Glenn Morris <rgm@gnu.org>
3111 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
3113 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3114 Unconditionally set to t. (Bug#10673)
3115 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3116 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
3117 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
3119 2012-02-02 Kenichi Handa <handa@m17n.org>
3121 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
3122 0, do not call append_composite_glyph.
3124 2012-02-02 Kenichi Handa <handa@m17n.org>
3126 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
3128 (x_produce_glyphs): If the component of a composition is a null
3129 string, set it->pixel_width to 1 to avoid zero-width glyph.
3131 2012-02-01 Eli Zaretskii <eliz@gnu.org>
3133 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
3134 first 2 arguments are identical. This makes inserting large
3135 output from a subprocess an order of magnitude faster on
3136 MS-Windows, where all sbrk'ed memory is always contiguous.
3138 2012-01-31 Glenn Morris <rgm@gnu.org>
3140 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3141 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
3142 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
3144 2012-01-29 Glenn Morris <rgm@gnu.org>
3146 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
3148 2012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
3150 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
3152 2012-01-28 Chong Yidong <cyd@gnu.org>
3154 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
3156 2012-01-26 Chong Yidong <cyd@gnu.org>
3158 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
3160 * search.c (Fsearch_forward, Fsearch_backward): Document negative
3161 repeat counts (Bug#10507).
3163 2012-01-26 Glenn Morris <rgm@gnu.org>
3165 * lread.c (syms_of_lread): Doc fix.
3167 2012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
3169 * coding.c (encode_designation_at_bol): Change return value to
3172 2012-01-25 Chong Yidong <cyd@gnu.org>
3174 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
3176 2012-01-21 Chong Yidong <cyd@gnu.org>
3178 * floatfns.c (Fcopysign): Make the second argument non-optional,
3179 since nil is not allowed anyway.
3181 2012-01-21 Andreas Schwab <schwab@linux-m68k.org>
3183 * process.c (read_process_output): Use p instead of XPROCESS (proc).
3184 (send_process): Likewise.
3186 2012-01-19 Martin Rudalics <rudalics@gmx.at>
3188 * window.c (save_window_save, Fcurrent_window_configuration)
3189 (Vwindow_persistent_parameters): Do not use Qstate.
3190 Rewrite doc-strings.
3192 2012-01-19 Kenichi Handa <handa@m17n.org>
3194 * character.c (char_width): New function.
3195 (Fchar_width, c_string_width, lisp_string_width):
3196 Use char_width (Bug#9496).
3198 2012-01-16 Martin Rudalics <rudalics@gmx.at>
3200 * window.c (Vwindow_persistent_parameters): New variable.
3201 (Fset_window_configuration, save_window_save): Handle persistent
3204 2012-01-14 Eli Zaretskii <eliz@gnu.org>
3206 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
3207 thrashing the stack of the thread. (Bug#9087)
3209 2012-01-12 Paul Eggert <eggert@cs.ucla.edu>
3211 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
3213 2012-01-11 Eli Zaretskii <eliz@gnu.org>
3215 * xdisp.c (rows_from_pos_range): Handle the case where the
3216 highlight ends on a newline. (Bug#10464)
3217 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
3218 he end column for display of highlight that ends on a newline
3221 2012-01-11 Glenn Morris <rgm@gnu.org>
3223 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
3224 from load-path also when installation-directory is nil. (Bug#10208)
3226 2012-01-10 Glenn Morris <rgm@gnu.org>
3228 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
3230 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
3231 Update template values to be closer to their typical values these days.
3233 2012-01-09 Eli Zaretskii <eliz@gnu.org>
3235 * xdisp.c (rows_from_pos_range): Accept additional argument
3236 DISP_STRING, and accept any glyph in a row whose object is that
3237 string as eligible for mouse highlight. Fixes mouse highlight of
3238 display strings from overlays. (Bug#10464)
3240 2012-01-07 Paul Eggert <eggert@cs.ucla.edu>
3242 emacs: fix an auto-save permissions race condition (Bug#10400)
3243 * fileio.c (auto_saving_dir_umask): New static var.
3244 (Fmake_directory_internal): Use it.
3245 (do_auto_save_make_dir): Set it, instead of invoking chmod after
3246 creating the directory. The old code temporarily assigns
3247 too-generous permissions to the directory.
3248 (do_auto_save_eh): Clear it.
3249 (Fdo_auto_save): Catch all errors, not just file errors, so
3250 that the var is always cleared.
3252 2012-01-07 Eli Zaretskii <eliz@gnu.org>
3254 * search.c (scan_buffer): Pass character positions to
3255 know_region_cache, not byte positions. (Bug#6540)
3257 2012-01-07 LynX <_LynX@bk.ru> (tiny change)
3259 * w32.c (sys_rename): Report EXDEV when rename of a directory
3260 fails because the target is on another logical disk. (Bug#10284)
3262 2012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
3264 * xterm.c (x_embed_request_focus): New function.
3266 * xterm.h: Add prototype.
3268 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
3270 2012-01-05 Glenn Morris <rgm@gnu.org>
3272 * emacs.c (emacs_copyright): Update short copyright year to 2012.
3274 2012-01-01 Eli Zaretskii <eliz@gnu.org>
3276 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
3277 Load gnutls_transport_set_lowat only if GnuTLS version is below
3279 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
3280 GnuTLS versions below 2.11.1.
3282 2011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
3284 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
3285 to the doc string advising against its use for altering the way
3286 windows are scrolled.
3288 2011-12-28 Kenichi Handa <handa@m17n.org>
3290 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
3291 coding-system ASCII compatible only when it does not produce BOM
3292 on encoding (Bug#10383).
3294 2011-12-26 Jan Djärv <jan.h.d@swipnet.se>
3296 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
3298 (create_and_show_popup_menu): Always use menu_position_func for
3301 2011-12-24 Andreas Schwab <schwab@linux-m68k.org>
3303 * callint.c (Fcall_interactively): Don't truncate prompt string.
3305 2011-12-23 Eli Zaretskii <eliz@gnu.org>
3307 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
3308 property that ends at ZV, so that the bidi iteration could be
3309 resumed from there (after widening). (Bug#10360)
3311 2011-12-22 Jan Djärv <jan.h.d@swipnet.se>
3313 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
3315 2011-12-21 Jan Djärv <jan.h.d@swipnet.se>
3317 * nsterm.m (x_free_frame_resources):
3318 Release f->output_data.ns->miniimage.
3319 (ns_index_color): Fix indentation. Do not retain
3320 color_table->colors[i].
3322 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
3325 * nsfns.m (x_set_background_color): Assign return value from
3326 ns_index_color to face-background instead of NSColor*.
3327 (ns_implicitly_set_icon_type): Fix indentation.
3328 Change assignment in for loop to comparison.
3330 * emacs.c (ns_pool): New variable.
3331 (main): Assign ns_pool.
3332 (Fkill_emacs): Call ns_release_autorelease_pool.
3334 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
3335 autorelease fdesc, release fdAttrs and tdict.
3336 (ns_get_covering_families): Release charset.
3337 (ns_findfonts): Release NSFontDescriptor created with new.
3338 (ns_uni_to_glyphs): Fix indentation.
3339 (setString): Release attrStr before assigning new value.
3341 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
3343 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
3345 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
3346 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
3348 2011-12-18 David Reitter <reitter@cmu.edu>
3350 * nsterm.m (ns_term_init): Subscribe for notifications
3351 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
3352 to method trackingNotification in EmacsMenu.
3354 * nsmenu.m (trackingMenu): New variable.
3355 (trackingNotification): New method (from Aquamacs).
3356 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3357 from Aquamacs (Bug#7030).
3359 2011-12-18 Jan Djärv <jan.h.d@swipnet.se>
3361 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
3362 (symbol_to_nsstring): Fix indentation.
3363 (ns_symbol_to_pb): New function.
3364 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
3365 (Fns_rotate_cut_buffers_internal): Remove.
3366 (Fns_store_selection_internal): Rename from
3367 Fns_store_cut_buffer_internal.
3368 (ns_get_foreign_selection, Fx_own_selection_internal)
3369 (Fx_disown_selection_internal, Fx_selection_exists_p)
3370 (Fns_get_selection_internal, Fns_store_selection_internal):
3371 Use ns_symbol_to_pb and check if return value is nil.
3372 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
3373 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
3374 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
3375 renamed to Sns_store_selection_internal.
3376 (ns_handle_selection_request): Move code to Fx_own_selection_internal
3377 and remove this function.
3378 (ns_handle_selection_clear): Remove, never used.
3379 (Fx_own_selection_internal): Move code from ns_handle_selection_request
3382 2011-12-17 Ken Brown <kbrown@cornell.edu>
3384 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
3385 GID is unknown (Bug#10257).
3387 2011-12-17 Paul Eggert <eggert@cs.ucla.edu>
3389 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
3390 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
3391 which caused a build failure on GNU/Linux IA-64. This problem was
3392 introduced by my 2011-10-07 patch.
3394 2011-12-15 Juri Linkov <juri@jurta.org>
3396 * image.c (imagemagick_error): New function. (Bug#10112)
3397 (imagemagick_load_image): Comment out `MagickSetResolution' call.
3398 Use `imagemagick_error' where ImageMagick functions return
3400 (Fimagemagick_types): Add `Fnreverse' to return the list in the
3403 2011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3405 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
3406 fill background (Bug#8992).
3408 2011-12-13 Martin Rudalics <rudalics@gmx.at>
3410 * window.c (Vwindow_combination_resize)
3411 (Vwindow_combination_limit): Use t instead of non-nil in
3413 (Vrecenter_redisplay): Add first sentence of doc-string on
3415 (Frecenter): Fix doc-string typo.
3417 2011-12-11 Kenichi Handa <handa@m17n.org>
3419 * coding.c (Funencodable_char_position): Pay attention to the
3420 buffer text relocation (Bug#9389).
3422 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
3424 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
3425 gtk_init (Bug#10100).
3427 2011-12-10 Eli Zaretskii <eliz@gnu.org>
3429 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
3430 IT->string is nil. (Bug#10263)
3432 2011-12-10 Jan Djärv <jan.h.d@swipnet.se>
3434 * nsterm.h (x_free_frame_resources): Declare.
3436 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
3437 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
3439 * nsterm.h (ns_get_defaults_value): Declare.
3441 * nsterm.m (ns_default): Call ns_get_defaults_value.
3443 2011-12-09 Eli Zaretskii <eliz@gnu.org>
3445 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
3448 2011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3450 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
3451 that where the value of an _OBJC_* symbol points to is in the .bss
3452 section (Bug#10240).
3454 2011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3456 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
3457 after the loop to call ccl_driver at least once (Bug#8619).
3459 2011-12-08 Kenichi Handa <handa@m17n.org>
3461 * ftfont.c (get_adstyle_property): Fix previous change
3464 2011-12-07 Juanma Barranquero <lekktu@gmail.com>
3466 * w32.c (init_environment): If no_site_lisp, remove site-lisp
3467 dirs from the default value of EMACSLOADPATH (bug#10208).
3469 2011-12-07 Glenn Morris <rgm@gnu.org>
3471 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
3472 installation and source directories as well. (Bug#10208)
3474 2011-12-06 Chong Yidong <cyd@gnu.org>
3476 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
3478 2011-12-06 Glenn Morris <rgm@gnu.org>
3480 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
3481 as an error, not just -1. (Bug#10217)
3483 2011-12-05 Chong Yidong <cyd@gnu.org>
3485 * keyboard.c (process_special_events): New function.
3486 (swallow_events, Finput_pending_p): Use it (Bug#10195).
3488 2011-12-05 Paul Eggert <eggert@cs.ucla.edu>
3490 * coding.c (encode_designation_at_bol): Don't use uninitialized
3491 local variable (Bug#9318).
3493 2011-12-05 Kenichi Handa <handa@m17n.org>
3495 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
3496 return Qnil (Bug#8046, Bug#10193).
3498 2011-12-05 Kenichi Handa <handa@m17n.org>
3500 * coding.c (encode_designation_at_bol): New args charbuf_end and
3501 dst. Return the number of produced bytes. Callers changed.
3502 (coding_set_source): Return how many bytes coding->source was
3504 (coding_set_destination): Return how many bytes
3505 coding->destination was relocated.
3506 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
3507 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
3509 2011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3511 * coding.c (CODING_CHAR_CHARSET_P): New macro.
3512 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
3515 2011-12-05 Andreas Schwab <schwab@linux-m68k.org>
3517 The following changes are to fix Bug#9318.
3519 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
3520 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
3521 (encode_coding_iso_2022, encode_coding_sjis)
3522 (encode_coding_big5, encode_coding_charset): Use the above macros.
3524 2011-12-05 Juanma Barranquero <lekktu@gmail.com>
3526 * lisp.h (process_quit_flag): Fix external declaration.
3528 2011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
3530 Don't macro-inline non-performance-critical code.
3531 * eval.c (process_quit_flag): New function.
3532 * lisp.h (QUIT): Use it.
3534 2011-12-04 Jan Djärv <jan.h.d@swipnet.se>
3536 * nsfns.m (get_geometry_from_preferences): New function.
3537 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
3539 2011-12-04 Andreas Schwab <schwab@linux-m68k.org>
3541 * emacs.c (Qkill_emacs): Define.
3542 (syms_of_emacs): Initialize it.
3543 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
3544 Qquit_flag to `kill-emacs' instead.
3545 (quit_throw_to_read_char): Add parameter `from_signal'.
3546 All callers changed. Call Fkill_emacs if requested and safe.
3547 * lisp.h (QUIT): Call Fkill_emacs if requested.
3549 2011-12-03 Jan Djärv <jan.h.d@swipnet.se>
3551 * widget.c (update_wm_hints): Return if wmshell is null.
3552 (widget_update_wm_size_hints): New function.
3554 * widget.h (widget_update_wm_size_hints): Declare.
3556 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
3557 widget_update_wm_size_hints (Bug#10104).
3559 2011-12-03 Eli Zaretskii <eliz@gnu.org>
3561 * xdisp.c (handle_invisible_prop): If the invisible text ends just
3562 before a newline, prepare the bidi iterator for consuming the
3563 newline, and keep the current paragraph direction. (Bug#10183)
3564 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
3566 2011-12-02 Juri Linkov <juri@jurta.org>
3568 * search.c (Fword_search_regexp): New Lisp function created from
3569 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
3570 (Fword_search_backward, Fword_search_forward)
3571 (Fword_search_backward_lax, Fword_search_forward_lax):
3572 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
3573 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
3575 2011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
3577 * fileio.c (Finsert_file_contents): Move after-change-function call
3578 to before the "handled:" label, since all "goto handled" appear in
3579 cases where the *-change-functions have already been properly called
3582 2011-12-01 Andreas Schwab <schwab@linux-m68k.org>
3584 * keyboard.c (interrupt_signal): Don't call kill-emacs when
3585 waiting for input. (Bug#10169)
3587 2011-11-30 Eli Zaretskii <eliz@gnu.org>
3589 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
3590 verifies glyph row's hash code--we have just reallocated the
3591 glyphs, so their contents can be complete garbage. (Bug#10164)
3593 2011-11-30 Juanma Barranquero <lekktu@gmail.com>
3595 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
3597 2011-11-30 Eli Zaretskii <eliz@gnu.org>
3599 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
3600 attributes are tested _before_ calling verify_row_hash, to protect
3601 against GCC re-ordering of the tests. (Bug#10164)
3603 2011-11-29 Jan Djärv <jan.h.d@swipnet.se>
3605 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
3607 * xterm.c (handle_one_xevent): Only set async_visible and friends
3608 if net_wm_state_hidden_seen is non-zero (Bug#10002)
3609 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
3610 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
3612 2011-11-28 Paul Eggert <eggert@cs.ucla.edu>
3614 Remove GCPRO-related macros that exist only to avoid shadowing locals.
3615 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
3616 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
3617 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3618 All uses changed to use GCPRO1 etc.
3619 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
3620 Revert to old implementation (i.e., before 2011-03-11).
3622 2011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3624 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
3625 of scroll runs so as to avoid assigning disabled bogus rows and
3626 unnecessary graphics copy operations.
3628 2011-11-27 Eli Zaretskii <eliz@gnu.org>
3630 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
3631 (snprintf) [_MSC_VER]: Redirect to _snprintf.
3632 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
3633 (malloc, free, realloc, calloc): Redirect to e_* only when
3636 * lisp.h (GCTYPEBITS): Move before first use.
3637 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
3638 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
3639 this macro definition.
3641 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
3644 2011-11-27 Jan Djärv <jan.h.d@swipnet.se>
3646 * gtkutil.c (xg_create_frame_widgets):
3647 Call gtk_window_set_has_resize_grip (FALSE) if that function is
3648 present with Gtk+ 2.0.
3650 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3652 * fileio.c (Finsert_file_contents): Undo previous change; see
3653 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3655 2011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3657 Rename locals to avoid shadowing.
3658 * fileio.c (Finsert_file_contents):
3659 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
3660 * process.c (wait_reading_process_output):
3661 Rename inner 'proc' to 'p' to avoid shadowing.
3662 Indent for consistency with usual Emacs style.
3664 2011-11-25 Eli Zaretskii <eliz@gnu.org>
3666 * xdisp.c (redisplay_window): If cursor row is not fully visible
3667 after recentering, and scroll-conservatively is set to a large
3668 number, scroll window by a few more lines to make the cursor fully
3669 visible and out of scroll-margin. (Bug#10105)
3670 (start_display): Don't move to the next line if the display should
3671 start at a newline that is part of a display vector or an overlay
3674 2011-11-24 Juri Linkov <juri@jurta.org>
3676 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
3677 after the `MagickPingImage' call. (Bug#10112)
3679 2011-11-23 Chong Yidong <cyd@gnu.org>
3681 * window.c (Fcoordinates_in_window_p): Accept only live windows.
3683 2011-11-23 Martin Rudalics <rudalics@gmx.at>
3685 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
3686 making another buffer current. (Bug#10114)
3688 2011-11-23 Glenn Morris <rgm@gnu.org>
3690 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
3692 2011-11-23 Chong Yidong <cyd@gnu.org>
3694 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
3695 using it (Bug#5984).
3697 2011-11-22 Eli Zaretskii <eliz@gnu.org>
3699 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
3700 and header-lines, as they don't have one computed for them.
3703 * .gdbinit (prow): Make displayed values more self-explaining.
3704 Add row's hash code.
3706 2011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
3708 * process.c (wait_reading_process_output): Fix asynchrounous
3709 GnuTLS socket handling on some versions of the GnuTLS library.
3710 (wait_reading_process_output): Add comment and URL.
3712 2011-11-21 Jan Djärv <jan.h.d@swipnet.se>
3714 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
3716 2011-11-21 Chong Yidong <cyd@gnu.org>
3718 * window.c (Fnext_window, Fprevious_window): Doc fix.
3720 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3722 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
3724 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
3726 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
3728 2011-11-20 Martin Rudalics <rudalics@gmx.at>
3730 * window.c (Fset_window_combination_limit): Rename argument
3732 (Vwindow_combination_limit): Remove "status" from doc-string.
3734 2011-11-20 Andreas Schwab <schwab@linux-m68k.org>
3736 * m/ibms390.h: Remove.
3737 * m/ibms390x.h: Don't include "ibms390.h".
3739 2011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3741 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
3742 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
3744 2011-11-20 Juanma Barranquero <lekktu@gmail.com>
3746 * casetab.c (Fset_case_table):
3747 * charset.c (Fcharset_after): Fix typos.
3749 2011-11-20 Paul Eggert <eggert@cs.ucla.edu>
3751 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
3752 Otherwise, valgrind does not work on some platforms.
3753 Problem reported by Andreas Schwab in
3754 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
3755 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
3756 is set, removing the need for VIRT_ADDRESS_VARIES.
3757 (PURE_P): Use a more-efficient implementation that needs just one
3758 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
3759 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
3760 to 4 (xorl, subq, cmpq, setbe).
3761 * alloc.c (pure): Always extern now, since that's the
3762 VIRT_ADDR_VARIES behavior.
3763 (PURE_POINTER_P): Use a single comparison, not two, for
3764 consistency with the new puresize.h.
3765 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
3766 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
3767 Remove VIRT_ADDR_VARIES no longer needed.
3769 2011-11-19 Eli Zaretskii <eliz@gnu.org>
3771 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
3772 (erase_phys_cursor, update_window_cursor, show_mouse_face)
3773 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
3774 behave as if the cursor position were at the window margin.
3776 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
3777 and the cursor position is out of bounds, behave as if the cursor
3778 position were at the window margin. (Bug#10075)
3780 2011-11-18 Chong Yidong <cyd@gnu.org>
3782 * window.c (Fwindow_combination_limit): Make first argument
3783 non-optional, since it is meaningless for live windows like the
3786 2011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
3788 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
3790 2011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
3792 * intervals.c: Fix grafting over the whole buffer (bug#10071).
3793 (graft_intervals_into_buffer): Simplify.
3795 2011-11-18 Eli Zaretskii <eliz@gnu.org>
3797 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
3798 hash values of the two rows.
3799 (copy_row_except_pointers): Preserve the used[] arrays and the
3800 hash values of the two rows. (Bug#10035)
3801 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
3803 * xdisp.c (row_hash): New function, body extracted from
3804 compute_line_metrics.
3805 (compute_line_metrics): Call row_hash, instead of computing the
3808 * dispnew.c (verify_row_hash): Call row_hash for computing the
3809 hash code of a row, instead of duplicating code from xdisp.c.
3811 * dispextern.h (row_hash): Add prototype.
3813 2011-11-18 Tassilo Horn <tassilo@member.fsf.org>
3815 * frame.c (delete_frame): Don't delete the terminal when the last
3816 X frame is closed if emacs is built with GTK toolkit.
3818 2011-11-17 Juanma Barranquero <lekktu@gmail.com>
3820 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
3822 2011-11-17 Martin Rudalics <rudalics@gmx.at>
3824 * window.c (Vwindow_splits): Rename to
3825 Vwindow_combination_resize. Suggested by Juri Linkov.
3826 (Fsplit_window_internal): Use Vwindow_combination_resize instead
3829 2011-11-16 Juanma Barranquero <lekktu@gmail.com>
3831 * nsfns.m (Fns_font_name):
3832 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
3834 2011-11-16 Martin Rudalics <rudalics@gmx.at>
3836 * window.h (window): Rename slot "nest" to "combination_limit".
3837 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
3838 (Fset_window_nest): Rename to Fset_window_combination_limit.
3839 (Vwindow_nest): Rename to Vwindow_combination_limit.
3840 (recombine_windows, make_parent_window, make_window)
3841 (Fsplit_window_internal, saved_window)
3842 (Fset_window_configuration, save_window_save): Rename all
3843 occurrences of window_nest to window_combination_limit.
3845 2011-11-15 Juanma Barranquero <lekktu@gmail.com>
3847 * image.c (imagemagick_load_image): Fix typo.
3849 2011-11-14 Eli Zaretskii <eliz@gnu.org>
3851 * xdisp.c (display_line): Move the call to
3852 highlight_trailing_whitespace before the call to
3853 compute_line_metrics, since the latter needs to see the final
3854 faces of all the glyphs to compute ROW's hash value.
3855 Fixes assertion violations in row_equal_p. (Bug#10035)
3857 2011-11-14 Juanma Barranquero <lekktu@gmail.com>
3859 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
3860 just return (bug#10044).
3862 2011-11-12 Eli Zaretskii <eliz@gnu.org>
3864 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
3865 with user-defined heap size. Bump the default size of the temacs
3866 heap to 27MB, to avoid memory warning when running temacs.
3867 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
3869 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
3870 current_matrix and desired_matrix. (Bug#9990)
3871 (verify_row_hash) [XASSERTS]: New function.
3872 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
3873 that the hash value of glyph rows is correct.
3875 2011-11-12 Martin Rudalics <rudalics@gmx.at>
3877 * window.h (window): Remove splits slot.
3878 * window.c (Fwindow_splits, Fset_window_splits): Remove.
3879 (Fdelete_other_windows_internal, make_parent_window)
3880 (make_window, Fsplit_window_internal, Fdelete_window_internal)
3881 (Fset_window_configuration, save_window_save): Don't deal with
3882 split status of windows.
3883 (saved_window): Remove splits slot.
3884 (Vwindow_splits): Rewrite doc-string.
3886 2011-11-11 Jan Djärv <jan.h.d@swipnet.se>
3888 * xfns.c (unwind_create_frame):
3889 * nsfns.m (unwind_create_frame):
3890 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
3891 Vframe_list (Bug#9999).
3893 2011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
3895 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
3897 2011-11-11 Kenichi Handa <handa@m17n.org>
3899 * callproc.c (Fcall_process): Set the member dst_multibyte of
3902 2011-11-11 Johan Bockgård <bojohan@gnu.org>
3904 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
3905 avoid a crash (bug#9496).
3907 2011-11-09 Chong Yidong <cyd@gnu.org>
3909 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
3910 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
3912 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3914 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
3916 2011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3918 Avoid some portability problems by eschewing 'extern inline' functions.
3919 The trivial performance wins aren't worth the portability hassles; see
3920 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
3922 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3923 (window_box_width, window_box_left, window_box_left_offset)
3924 (window_box_right, window_box_right_offset): Undo previous change,
3925 by removing the "extern"s.
3926 * intervals.c (adjust_intervals_for_insertion)
3927 (adjust_intervals_for_deletion): Undo previous change,
3928 making these static again.
3929 (offset_intervals, temp_set_point_both, temp_set_point)
3930 (copy_intervals_to_string): No longer inline.
3931 * xdisp.c (window_text_bottom_y, window_box_width)
3932 (window_box_height, window_box_left_offset)
3933 (window_box_right_offset, window_box_left, window_box_right)
3934 (window_box): No longer inline.
3936 2011-11-08 Chong Yidong <cyd@gnu.org>
3938 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
3939 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
3940 Signal an error if not a live window.
3941 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
3942 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
3944 2011-11-07 Juanma Barranquero <lekktu@gmail.com>
3946 * lisp.h (syms_of_abbrev): Remove declaration.
3947 Reported by CHENG Gao <chenggao@royau.me>.
3949 2011-11-07 Eli Zaretskii <eliz@gnu.org>
3951 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
3952 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
3953 of temacs in GUI mode.
3955 2011-11-07 Martin Rudalics <rudalics@gmx.at>
3957 * window.h: Declare delete_all_child_windows instead of
3958 delete_all_subwindows.
3959 * window.c (Fwindow_nest, Fset_window_nest)
3960 (Fset_window_new_total, Fset_window_new_normal)
3961 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
3962 (delete_all_subwindows): Rename to delete_all_child_windows.
3963 (Fdelete_other_windows_internal, Fset_window_configuration):
3964 Call delete_all_child_windows instead of delete_all_subwindows.
3965 * frame.c (delete_frame): Call delete_all_child_windows instead
3966 of delete_all_subwindows.
3968 2011-11-07 Paul Eggert <eggert@cs.ucla.edu>
3970 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
3971 This is also needed for porting to any host where GC_MARK_STACK is
3972 not GC_MAKE_GCPROS_NOOPS.
3973 (which_symbols): Use it.
3975 2011-11-07 Kenichi Handa <handa@m17n.org>
3977 * coding.c (coding_set_destination): Check coding->src_pos only
3978 when coding->src_object is a buffer (bug#9910).
3980 * process.c (send_process): Set the member src_multibyte of coding
3981 to 0 (bug#9911) when sending a unibyte text.
3983 * callproc.c (Fcall_process): Set the member src_multibyte of
3984 process_coding to 0 (bug#9912).
3986 2011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3988 * xmenu.c (cleanup_widget_value_tree): New function.
3989 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
3990 calling free_menubar_widget_value_tree directly (Bug#9830).
3992 2011-11-06 Paul Eggert <eggert@cs.ucla.edu>
3994 Fix some portability problems with 'inline'.
3995 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3996 (window_box_width, window_box_left, window_box_left_offset)
3997 (window_box_right, window_box_right_offset): Declare extern.
3998 Otherwise, these inline functions do not conform to C99 and
3999 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
4000 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
4001 * intervals.c (adjust_intervals_for_insertion)
4002 (adjust_intervals_for_deletion): Now extern, because otherwise the
4003 extern inline functions 'offset_intervals' couldn't refer to it.
4004 (static_offset_intervals): Remove.
4005 (offset_intervals): Rewrite using the old contents of
4006 static_offset_intervals. The old version didn't conform to C99
4007 because an extern inline function contained a reference to an
4008 identifier with static linkage.
4010 2011-11-06 Andreas Schwab <schwab@linux-m68k.org>
4012 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
4015 2011-11-06 Eli Zaretskii <eliz@gnu.org>
4017 * xdisp.c (init_iterator, reseat_to_string): Don't set the
4018 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
4019 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
4020 return Qleft_to_right.
4022 2011-11-06 Chong Yidong <cyd@gnu.org>
4024 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
4025 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
4026 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
4027 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
4028 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
4029 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
4030 (Fwindow_vscroll): Doc fix.
4031 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
4032 argument, since it makes no sense to pass a live window and for
4033 consistency with window-child.
4035 2011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
4037 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
4040 2011-11-05 Jason Rumney <jasonr@gnu.org>
4042 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
4043 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
4045 (add_font_entity_to_list): Fix logic errors in mixed boolean and
4046 bitwise arithmetic preventing use of unicode-sip and non-truetype
4049 2011-11-05 Eli Zaretskii <eliz@gnu.org>
4051 * s/ms-w32.h (fstat, stat, utime): Move redirections to
4054 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
4055 initialization code to keep similarity to xfns.c after changes
4058 2011-11-05 Jan Djärv <jan.h.d@swipnet.se>
4060 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
4061 (unwind_create_frame): New function (Bug#9943).
4062 (Fx_create_frame): Restructure code to be more similar to the one in
4063 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
4064 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
4065 Move terminal->reference_count++ just before making the frame official
4068 * nsterm.m (x_free_frame_resources): New function.
4069 (x_destroy_window): Move code to x_free_frame_resources.
4071 * xfns.c (unwind_create_frame): Fix comment.
4072 (Fx_create_frame, x_create_tip_frame):
4073 Move terminal->reference_count++ just before making the frame
4074 official. Move initialization of image_cache_refcount and
4075 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
4077 2011-11-05 Eli Zaretskii <eliz@gnu.org>
4079 Support MSVC build with newer versions of Visual Studio.
4080 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
4081 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
4084 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
4085 which are not supported by MSVC.
4086 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
4087 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
4089 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
4091 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
4093 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
4095 2011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
4097 Support MSVC build with newer versions of Visual Studio.
4098 * w32.c: Don't include w32api.h for MSVC.
4099 (init_environment) [_MSC_VER]: Call sys_access, not _access.
4101 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
4102 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
4103 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
4104 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
4106 (alloca) [_MSC_VER]: Define to _alloca.
4108 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
4110 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
4112 2011-11-04 Eli Zaretskii <eliz@gnu.org>
4114 * xdisp.c (note_mouse_highlight): If either of
4115 previous/next-single-property-change returns nil, treat that as
4116 the beginning or the end of the buffer. (Bug#9955)
4118 2011-11-04 Jan Djärv <jan.h.d@swipnet.se>
4120 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
4121 label is not null (Bug#9951).
4122 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
4125 2011-11-04 Eli Zaretskii <eliz@gnu.org>
4127 * window.c (Fwindow_body_size): Mention in the doc string that the
4128 return value is in frame's canonical units. (Bug#9949)
4130 2011-11-03 Eli Zaretskii <eliz@gnu.org>
4132 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
4134 * w32fns.c (unwind_create_frame): If needed, free the glyph
4135 matrices of the partially constructed frame. (Bug#9943)
4136 * xfns.c (unwind_create_frame): Likewise.
4138 2011-11-01 Eli Zaretskii <eliz@gnu.org>
4140 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
4141 Don't stop backward scan on the continuation glyph, even though
4142 its CHARPOS is positive.
4143 (mouse_face_from_buffer_pos, note_mouse_highlight):
4144 Rename cover_string to disp_string.
4146 2011-11-01 Martin Rudalics <rudalics@gmx.at>
4148 * window.c (temp_output_buffer_show): Don't use
4149 Vtemp_buffer_show_specifiers.
4150 (Vtemp_buffer_show_specifiers): Remove unused variable.
4152 2011-10-30 Eli Zaretskii <eliz@gnu.org>
4154 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
4155 past the beginning of the current glyph matrix.
4157 2011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
4159 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
4160 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
4161 HAVE_GTK3 (Bug#9869).
4163 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
4164 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
4166 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
4168 * xterm.c: Declare x_handle_net_wm_state to return int.
4169 (handle_one_xevent): Check if we are iconified but don't have
4170 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
4171 (get_current_wm_state): Return non-zero if not hidden,
4172 check for _NET_WM_STATE_HIDDEN (Bug#9893).
4173 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
4174 (x_handle_net_wm_state): Return what get_current_wm_state returns.
4175 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
4177 2011-10-29 Paul Eggert <eggert@cs.ucla.edu>
4179 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
4180 so that this new function doesn't get optimized away by a
4181 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
4183 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4185 * frame.h (MOUSE_HL_INFO): Remove excess parens.
4187 2011-10-29 Eli Zaretskii <eliz@gnu.org>
4189 Fix the `xbytecode' command.
4190 * .gdbinit (xprintbytestr): New command.
4191 (xwhichsymbols): Rename from `which'; all callers changed.
4192 (xbytecode): Print the byte-code string as well.
4194 2011-10-29 Kim Storm <storm@cua.dk>
4196 * alloc.c (which_symbols): New function.
4198 2011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4200 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
4203 2011-10-29 Glenn Morris <rgm@gnu.org>
4205 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
4206 Not clear what it was for, and it causes various bugs. (Bug#9839)
4208 2011-10-28 Eli Zaretskii <eliz@gnu.org>
4210 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
4211 possible random value that matches one of those tested as
4212 condition to clear the mouse face.
4214 2011-10-28 Chong Yidong <cyd@gnu.org>
4216 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
4218 2011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
4220 * window.c (make_window): Initialize phys_cursor_on_p.
4222 2011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
4224 * lisp.h (struct Lisp_Symbol): Update comments.
4226 2011-10-28 Juanma Barranquero <lekktu@gmail.com>
4228 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
4230 2011-10-28 Eli Zaretskii <eliz@gnu.org>
4232 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
4233 <oslsachem@gmail.com> for helping to debug this.
4235 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
4236 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
4237 (g_b_init_get_glyph_outline_w): New static variables.
4238 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
4239 (GetGlyphOutlineW_Proc): New typedefs.
4240 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
4241 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
4243 (w32font_open_internal, compute_metrics):
4244 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
4245 instead of calling the "wide" APIs directly.
4247 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
4249 * w32.h (syms_of_w32font): Add prototype.
4251 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
4253 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
4254 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
4255 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
4256 (Fmove_to_window_line): Doc fix.
4258 2011-10-27 Chong Yidong <cyd@gnu.org>
4260 * process.c (make_process): Set gnutls_state to NULL.
4262 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
4263 non-NULL, regardless of GNUTLS_INITSTAGE.
4264 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
4265 an error. Set process slots as soon as we allocate them.
4267 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
4269 2011-10-27 Chong Yidong <cyd@gnu.org>
4271 * gnutls.c (emacs_gnutls_deinit): New function.
4272 Deallocate credentials structures as well as calling gnutls_deinit.
4273 (Fgnutls_deinit, Fgnutls_boot): Use it.
4275 * process.c (make_process): Initialize GnuTLS credentials to NULL.
4276 (deactivate_process): Call emacs_gnutls_deinit.
4278 2011-10-27 Juanma Barranquero <lekktu@gmail.com>
4280 * image.c (x_create_x_image_and_pixmap):
4281 * w32.c (sys_rename, w32_delayed_load):
4282 * w32font.c (fill_in_logfont):
4283 * w32reg.c (x_get_string_resource): Silence compiler warnings.
4285 2011-10-26 Juanma Barranquero <lekktu@gmail.com>
4287 * w32fns.c (w32_default_color_map): New function,
4288 extracted from Fw32_default_color_map.
4289 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
4291 2011-10-25 Paul Eggert <eggert@cs.ucla.edu>
4293 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
4295 2011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
4297 * keyboard.c (test_undefined): New function (bug#9751).
4298 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
4300 2011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
4302 * sysdep.c (init_sys_modes): Fix the check for the controlling
4303 terminal (Bug#6649).
4305 2011-10-20 Eli Zaretskii <eliz@gnu.org>
4307 * dispextern.h (struct bidi_it): New member next_en_type.
4309 * bidi.c (bidi_line_init): Initialize the next_en_type member.
4310 (bidi_resolve_explicit_1): When next_en_pos is valid for the
4311 current character, check also for next_en_type being WEAK_EN.
4312 (bidi_resolve_weak): Don't enter the expensive loop if the current
4313 position is before next_en_pos. Record the bidi type of the first
4314 non-ET, non-BN character we find, in addition to its position.
4315 (bidi_level_of_next_char): Invalidate next_en_type when
4316 next_en_pos is over-stepped.
4318 2011-10-20 Paul Eggert <eggert@cs.ucla.edu>
4320 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
4321 * editfns.c: Rewrite current-time-zone so that it invokes
4322 the equivalent of (format-time-string "%Z") to get the time zone name.
4323 This fixes a bug when the time zone name contains characters that
4324 need converting from the system time locale to Emacs internal format.
4325 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
4326 that patch fixed format-time-string to do the conversion, but
4327 I forgot to fix current-time-zone.
4328 (format_time_string): New function, containing most of
4329 what Fformat_time_string used to contain.
4330 (Fformat_time_string): Rewrite in terms of format_time_string.
4331 This doesn't change this function's behavior.
4332 (current-time-zone): Rewrite to use format_time_string.
4333 This fixes the bug reported by Michael Schierl in
4334 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
4335 Jason Rumney's 2007-06-07 change worked around this bug, but
4337 * systime.h (tzname, timezone): Remove no-longer-used declarations.
4339 2011-10-19 Eli Zaretskii <eliz@gnu.org>
4341 * xdisp.c (start_display): If the character at POS is displayed
4342 via a display vector, reset IT->current.dpvec_index to zero.
4343 (try_window_reusing_current_matrix): If a line ends in a display
4344 vector or the next line starts in a display vector, continue
4345 redrawing the window even though the character position of
4346 start_row was reached.
4349 2011-10-18 Chong Yidong <cyd@gnu.org>
4351 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
4352 with nobreak-char-display too.
4354 2011-10-18 Eli Zaretskii <eliz@gnu.org>
4356 Fix part 3 of bug#9771.
4357 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
4358 (bidi_resolve_neutral): Don't enter the expensive loop looking for
4359 non-neutral characters if the current character is a paragraph
4360 separator (a.k.a. Newline). This avoids running the same
4361 expensive loop twice, once when we consume the preceding newline
4362 and the other time when the line actually needs to be displayed.
4363 Avoid the loop when we see neutrals on the base embedding level
4364 following a character whose directionality is the same as the
4365 paragraph's. This avoids running the expensive loop when a line
4366 ends in a long sequence of neutrals, like control characters.
4367 Add assertion against STRONG_AL type. Slightly rearrange code
4368 that determines the type of a neutral given the first non-neutral
4370 (bidi_level_of_next_char): Set next_en_pos to zero when
4371 invalidating its info.
4373 2011-10-17 Eli Zaretskii <eliz@gnu.org>
4375 * xdisp.c (push_display_prop): Determine whether to record string
4376 or buffer position by IT->string, not by IT->method. Allow
4377 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
4378 (move_it_vertically_backward): Don't look for character position
4379 immediately after the newline when in a continuation line.
4382 2011-10-15 Martin Rudalics <rudalics@gmx.at>
4384 * window.c (coordinates_in_window): Rewrite and delabelize
4385 vertical border check. (Bug#5357) (Bug#9618)
4387 2011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
4389 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
4390 errors in XSetWindowBorder (bug#9310).
4392 2011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
4394 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
4395 avoid crash when xmalloc overrun checking is enabled.
4397 2011-10-13 Eli Zaretskii <eliz@gnu.org>
4399 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
4400 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
4401 cursor motion with <left> and <right> arrow keys.
4403 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
4404 some callers set that themselves.
4406 2011-10-12 Eli Zaretskii <eliz@gnu.org>
4408 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
4409 display string and the previous row comes from the same string and
4410 is empty. (Bug#9739) (Bug#9738)
4412 2011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
4414 * doc.c (get_doc_string): Encode file name (bug#9735).
4416 2011-10-12 Eli Zaretskii <eliz@gnu.org>
4418 * bidi.c (bidi_level_of_next_char):
4419 * xdisp.c (get_visually_first_element): Remove old incorrect
4420 comments regarding the Unicode Line Separator character.
4422 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
4424 2011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
4426 * alloc.c (Fgc_status): Do not access beyond zombies array
4427 boundary if nzombies > MAX_ZOMBIES.
4428 * alloc.c (dump_zombies): Add missing format specifier.
4430 2011-10-12 Paul Eggert <eggert@cs.ucla.edu>
4432 * xdisp.c (set_cursor_from_row): Simplify conditionals,
4433 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
4435 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
4436 Some packages use them to denote characters with modifiers.
4438 2011-10-11 Andreas Schwab <schwab@linux-m68k.org>
4440 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
4441 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
4442 matching a pp-number. Rename parameter var to var1.
4444 2011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
4446 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
4448 2011-10-08 Glenn Morris <rgm@gnu.org>
4450 * callint.c (Fcall_interactively): Give a more explicit error for the
4451 'c' case with a non-character input. (Bug#8479)
4453 2011-10-08 Eli Zaretskii <eliz@gnu.org>
4455 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
4457 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
4458 lines that are hscrolled on the left.
4460 * dispnew.c (buffer_posn_from_coords): Account for a possible
4461 presence of header-line. (Bug#4426)
4463 2011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
4465 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
4466 Don't advertise functionality which we discourage or doesn't work.
4468 2011-10-07 Paul Eggert <eggert@cs.ucla.edu>
4470 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
4471 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
4472 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
4473 this makes Emacs dump core during garbage collection on rare
4474 occasions. sizeof is obviously inferior to offsetof here, so
4475 stick with offsetof.
4476 (GC_POINTER_ALIGNMENT): New macro.
4477 (mark_memory): Omit 3rd (offset) arg; caller changed.
4478 Don't assume EMACS_INT alignment is the same as pointer alignment.
4480 2011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
4482 * keyboard.c (read_key_sequence_remapped): New var.
4483 (read_key_sequence): Compute remapping in the right buffer.
4484 (command_loop_1): Use read_key_sequence's remapping directly.
4486 2011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
4488 * dired.c (file_name_completion): Don't expand file name.
4489 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
4490 before checking file name handler.
4492 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
4493 they've been requested explicitly (bug#9591).
4495 2011-10-01 Andreas Schwab <schwab@linux-m68k.org>
4497 * keymap.c (Fsingle_key_description): Use make_specified_string
4498 instead of build_string to build string from push_key_description.
4501 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4503 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
4504 This fixes a Y2038 bug on 64-bit hosts.
4505 * buffer.c (reset_buffer):
4506 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
4507 (Fclear_buffer_auto_save_failure):
4508 Use 0, not -1, to represent an unset failure time, since time_t
4509 might not be signed.
4511 Remove dependency on glibc malloc internals.
4512 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4513 Move back here from lisp.h, but with their new implementations.
4514 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4515 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
4516 * charset.c (charset_table_init): New static var.
4517 (syms_of_charset): Use it instead of xmalloc. This removes a
4518 dependency on glibc malloc internals. See Eli Zaretskii's comment in
4519 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
4520 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4521 Move back to alloc.c.
4522 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4523 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
4525 2011-09-30 Jan Djärv <jan.h.d@swipnet.se>
4527 * nsterm.m (windowDidResize): Call x_set_window_size only when
4528 ns_in_resize is true. Otherwise set pixelwidth/height and
4529 call change_frame_size (Bug#9628).
4531 2011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4533 Port --enable-checking=all to Fedora 14 x86-64.
4534 * charset.c (syms_of_charset): Also account for glibc malloc's
4535 internal overhead when calculating the initial malloc maximum.
4537 Port --enable-checking=all to Fedora 14 x86.
4538 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4540 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
4541 (overrun_check_realloc, overrun_check_free):
4542 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
4543 That way, xmalloc returns a properly-aligned pointer even if
4544 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
4545 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
4546 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
4547 into account when calculating the initial malloc maximum.
4548 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4549 Move here from alloc.c, so that charset.c can use it too.
4550 Properly align; the old code wasn't right for common 32-bit hosts
4551 when configured with --enable-checking=all.
4552 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4553 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
4555 2011-09-29 Eli Zaretskii <eliz@gnu.org>
4557 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
4560 2011-09-28 Eli Zaretskii <eliz@gnu.org>
4562 * xdisp.c (compute_display_string_end): If there's no display
4563 string at CHARPOS, return -1.
4565 * bidi.c (bidi_fetch_char): When compute_display_string_end
4566 returns a negative value, treat the character as a normal
4567 character not covered by a display string. (Bug#9624)
4569 2011-09-28 Juanma Barranquero <lekktu@gmail.com>
4571 * lread.c (Fread_from_string): Fix typo in docstring.
4573 2011-09-27 Eli Zaretskii <eliz@gnu.org>
4575 * xdisp.c (handle_invisible_prop): If invisible text ends on a
4576 newline, reseat the iterator instead of bidi-iterating there one
4577 character at a time. (Bug#9610)
4578 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
4579 TO_CHARPOS if the bidi iterator is at base embedding level.
4581 2011-09-27 Andreas Schwab <schwab@linux-m68k.org>
4583 * lread.c (readevalloop): Use correct code for NBSP.
4584 (read1): Likewise. (Bug#9608)
4586 2011-09-25 Michael Albinus <michael.albinus@gmx.de>
4588 * dbusbind.c (Fdbus_register_signal): When service is not
4589 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
4591 2011-09-25 Glenn Morris <rgm@gnu.org>
4593 * buffer.c (truncate-lines): Doc fix.
4595 2011-09-24 Chong Yidong <cyd@stupidchicken.com>
4597 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
4598 (Fset_window_next_buffers): Doc fix.
4600 2011-09-24 Glenn Morris <rgm@gnu.org>
4602 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
4604 2011-09-24 Paul Eggert <eggert@cs.ucla.edu>
4606 Fix minor problems found by static checking.
4607 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
4608 * indent.c (Fvertical_motion): Fix == vs = typo.
4610 2011-09-24 Eli Zaretskii <eliz@gnu.org>
4612 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
4613 Default value is now t. Doc fix.
4615 * indent.c (Fvertical_motion): Compute and apply the overshoot
4616 logic when moving up, not only when moving down. Fix the
4617 confusing name and values of the it_overshoot_expected variable;
4618 logic changes accordingly. (Bug#9254) (Bug#9549)
4620 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
4621 CHARPOS is covered by a display string which includes newlines.
4622 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
4623 is covered by a display string with embedded newlines.
4625 2011-09-24 Michael Albinus <michael.albinus@gmx.de>
4627 * dbusbind.c (Fdbus_register_signal): Add match rule to
4628 Vdbus_registered_objects_table. (Bug#9581)
4629 (Fdbus_register_method, Vdbus_registered_objects_table):
4632 2011-09-24 Jim Meyering <meyering@redhat.com>
4634 do not ignore write error for any output size
4635 The previous change was incomplete.
4636 While it makes emacs --batch detect the vast majority of stdout
4637 write failures, errors were still ignored whenever the output size is
4638 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
4639 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
4640 && echo FAIL: ignored write error
4641 FAIL: ignored write error
4642 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
4643 && echo FAIL: ignored write error
4644 FAIL: ignored write error
4645 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
4647 2011-09-23 Andreas Schwab <schwab@linux-m68k.org>
4649 * emacs.c (Fkill_emacs): In noninteractive mode exit
4650 non-successfully if a write error occurred on stdout. (Bug#9574)
4652 2011-09-21 Eli Zaretskii <eliz@gnu.org>
4654 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
4657 * dispextern.h (struct it): Update the comment documenting what
4660 2011-09-20 Eli Zaretskii <eliz@gnu.org>
4662 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
4663 a display string, extend search for cursor position to end of row.
4664 (find_row_edges): If the row ends in a newline from a display
4665 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
4666 Handle the case of a display string with multiple newlines.
4667 (Fcurrent_bidi_paragraph_direction): Fix search for previous
4668 non-empty line. Fixes confusing cursor motion with arrow keys at
4669 the beginning of a line that starts with whitespace.
4671 2011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4673 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
4676 2011-09-18 Chong Yidong <cyd@stupidchicken.com>
4678 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
4681 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4683 * xdisp.c (display_line): Record maximum and minimum buffer
4684 positions even if no glyphs were produced (e.g., by a zero-width
4685 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
4686 buffer positions that will be removed from the glyph row because
4688 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
4689 column is beyond frame width: don't subtract 1 "pixel" when
4690 computing width of the stretch.
4691 (reseat_at_next_visible_line_start): Undo the change made on
4692 2011-09-17 that saved paragraph information and restored it after
4693 the call to `reseat'. (Bug#9545)
4695 2011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4697 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
4698 and turn window cursor on if cleared (Bug#9415).
4700 2011-09-18 Andreas Schwab <schwab@linux-m68k.org>
4702 * search.c (boyer_moore): Take unibyte characters from pattern
4703 literally. (Bug#9458)
4705 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4707 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
4709 2011-09-18 Paul Eggert <eggert@cs.ucla.edu>
4711 Fix minor problem found by static checking.
4712 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
4713 initialized, to pacify gcc -Wuninitialized.
4715 * fileio.c: Report proper errno when syscall falls.
4716 (Finsert_file_contents): Save and restore errno,
4717 so that report_file_error outputs the correct diagnostic.
4718 (Fwrite_region) [CLASH_DETECTION]: Likewise.
4720 2011-09-18 Eli Zaretskii <eliz@gnu.org>
4722 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
4724 2011-09-17 Eli Zaretskii <eliz@gnu.org>
4726 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
4727 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
4729 2011-09-17 Eli Zaretskii <eliz@gnu.org>
4731 * xdisp.c (reseat_at_next_visible_line_start): Keep information
4732 about the current paragraph and restore it after the call to reseat.
4734 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
4735 (bidi_find_paragraph_start): Search back for paragraph beginning
4736 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
4737 (bidi_move_to_visually_next): Only trigger paragraph-related
4738 computations when the last character is a newline or at EOB, not
4739 just any NEUTRAL_B. (Bug#9470)
4741 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
4742 truncated lines if point is covered by a display string. (Bug#9524)
4744 2011-09-16 Paul Eggert <eggert@cs.ucla.edu>
4746 * xselect.c: Relax test for outgoing X longs (Bug#9498).
4747 (cons_to_x_long): New function.
4748 (lisp_data_to_selection_data): Use it. Correct the test for
4749 short-versus-long data; it was negated. Break out of vector
4750 loop, for efficiency, when a long datum is discovered.
4752 2011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
4754 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
4756 2011-09-16 Eli Zaretskii <eliz@gnu.org>
4758 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
4759 GCC PR/17406) by declaring this function with external scope.
4761 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4763 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
4764 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
4766 2011-09-15 Andreas Schwab <schwab@linux-m68k.org>
4768 * editfns.c (Fformat): Correctly handle text properties on "%%".
4770 2011-09-15 Eli Zaretskii <eliz@gnu.org>
4772 * xterm.c (x_draw_composite_glyph_string_foreground):
4773 * w32term.c (x_draw_composite_glyph_string_foreground):
4774 * term.c (encode_terminal_code):
4775 * composite.c (composition_update_it, get_composition_id):
4776 * xdisp.c (get_next_display_element)
4777 (fill_composite_glyph_string): Add comments about special meaning
4778 of TAB characters in a composition.
4780 2011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4782 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4783 This occurs when processing a multibyte format.
4784 Problem reported by Wolfgang Jenker.
4786 2011-09-15 Johan Bockgård <bojohan@gnu.org>
4788 * xdisp.c (try_cursor_movement): Only check for exact match if
4789 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
4791 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4793 Remove unused external symbols.
4794 * dispextern.h (calc_pixel_width_or_height): Remove decl.
4795 * xdisp.c (calc_pixel_width_or_height): Now static.
4796 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
4797 * indent.c (check_display_width):
4798 * w32term.c: Fix comment to match code.
4799 * xterm.c, xterm.h (x_catching_errors): Remove.
4801 2011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4803 * xselect.c: Use signed conversions more consistently (Bug#9498).
4804 (selection_data_to_lisp_data): Assume incoming selection data are
4805 signed integers, not unsigned. This is to be consistent with
4806 outgoing selection data, which was modified to use signed integers
4807 in as part of the fix to Bug#9196 in response to Jan D.'s comment
4808 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
4809 expects long, not unsigned long.
4811 2011-09-14 Eli Zaretskii <eliz@gnu.org>
4813 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
4814 computation of loop end. Reported by Johan Bockgård
4817 2011-09-13 Chong Yidong <cyd@stupidchicken.com>
4819 * frame.c (Fother_visible_frames_p): Function deleted.
4821 2011-09-12 Eli Zaretskii <eliz@gnu.org>
4823 * indent.c (compute_motion): Process display vector front to back
4824 rather than the other way around. (Bug#2496)
4826 2011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
4828 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
4830 2011-09-11 Chong Yidong <cyd@stupidchicken.com>
4832 * minibuf.c (Fread_from_minibuffer): Doc fix.
4834 2011-09-11 Eli Zaretskii <eliz@gnu.org>
4836 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
4837 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
4839 2011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4841 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
4842 value for non-existent files.
4844 2011-09-11 Eli Zaretskii <eliz@gnu.org>
4846 * fileio.c (Finsert_file_contents): If the file cannot be opened,
4847 set its "size" to -1. This will set the modtime_size field of
4848 the corresponding buffer to -1, which is what
4849 verify-visited-file-modtime expects for files that do not exist.
4852 2011-09-11 Paul Eggert <eggert@cs.ucla.edu>
4854 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
4856 * lisp.h: ... from here. push_key_description is no longer
4857 defined in keyboard.c, so its declaration should not be in
4858 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
4859 logically belongs with push_key_description.
4861 2011-09-10 Paul Eggert <eggert@cs.ucla.edu>
4863 * buffer.h: Include <sys/types.h> instead of <time.h>.
4864 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
4865 Problem reported by Herbert J. Skuhra.
4867 2011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
4869 * xml.c (parse_region): Make the parsing work for
4870 non-comment-starting XML files again (bug#9144).
4872 2011-09-10 Andreas Schwab <schwab@linux-m68k.org>
4874 * image.c (gif_load): Fix calculation of bottom and right corner.
4877 2011-09-10 Eli Zaretskii <eliz@gnu.org>
4879 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
4880 redisplay in small windows.
4882 2011-09-09 Eli Zaretskii <eliz@gnu.org>
4884 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
4886 2011-09-08 Martin Rudalics <rudalics@gmx.at>
4888 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
4889 Operate on live windows only.
4891 2011-09-08 Juanma Barranquero <lekktu@gmail.com>
4893 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
4895 2011-09-07 Eli Zaretskii <eliz@gnu.org>
4897 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
4898 only under bidi iteration.
4900 2011-09-07 Jan Djärv <jan.h.d@swipnet.se>
4902 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
4904 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4906 isnan: Fix porting problem to Solaris 10 with bundled gcc.
4907 Without this fix, the command to link temacs failed due to an
4908 undefined symbol __builtin_isnan. This is because
4909 /usr/include/iso/math_c99.h #defines isnan(x) to
4910 __builtin_isnan(x), but the bundled gcc, which identifies itself
4911 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
4913 * floatfns.c (isnan): #undef, and then #define to a clone of
4915 (Fisnan): Always define, since it's always available now.
4916 (syms_of_floatfns): Always define isnan at the Lisp level.
4918 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4920 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
4922 2011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4924 * fileio.c: Fix bugs with large file offsets (Bug#9428).
4925 The previous code assumed that file offsets (off_t values) fit in
4926 EMACS_INT variables, which is not true on typical 32-bit hosts.
4927 The code messed up by falsely reporting buffer overflow in cases
4928 such as (insert-file-contents "big" nil 1 2) into an empty buffer
4929 when "big" contains more than 2**29 bytes, even though this
4930 inserts just one byte and does not overflow the buffer.
4931 (Finsert_file_contents): Store file offsets as off_t
4932 values, not as EMACS_INT values. Check for overflow when
4933 converting between EMACS_INT and off_t. When checking for
4934 buffer overflow or for overlap, take the offsets into account.
4935 Don't use EMACS_INT for small values where int suffices.
4936 When checking for overlap, fix a typo: ZV was used where
4937 ZV_BYTE was intended.
4938 (Fwrite_region): Don't assume off_t fits into 'long'.
4939 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
4941 2011-09-05 Michael Albinus <michael.albinus@gmx.de>
4943 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
4945 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4947 sprintf-related integer and memory overflow issues (Bug#9412).
4949 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
4950 (esprintf, exprintf, evxprintf): New functions.
4951 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
4952 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
4953 (modify_event_symbol): Do not assume that the length of
4954 name_alist_or_stem is safe to alloca and fits in int.
4955 (Fexecute_extended_command): Likewise for function name and binding.
4956 (Frecursion_depth): Wrap around reliably on integer overflow.
4957 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
4958 since some callers pass EMACS_INT values.
4959 (Fsingle_key_description): Don't crash if symbol name contains more
4960 than MAX_ALLOCA bytes.
4961 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
4962 (get_minibuffer): Arg is now EMACS_INT, not int.
4963 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
4964 (esprintf, exprintf, evxprintf): New decls.
4965 * window.h (command_loop_level, minibuf_level): Reflect API changes.
4967 * dbusbind.c (signature_cat): New function.
4968 (xd_signature, Fdbus_register_signal):
4969 Do not overrun buffer; instead, report string overflow.
4971 * dispnew.c (add_window_display_history): Don't overrun buffer.
4972 Truncate instead; this is OK since it's just a log.
4974 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
4975 even if the time zone offset is outlandishly large.
4976 Don't mishandle offset == INT_MIN.
4978 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
4979 when creating daemon; the previous buffer-overflow check was incorrect.
4981 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
4982 which has the guts of the old verror function.
4984 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
4985 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
4987 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
4988 (font_unparse_xlfd): Don't blindly alloca long strings.
4989 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
4990 fits in int, when using sprintf. Use single snprintf to count
4991 length of string rather than counting it via multiple sprintfs;
4992 that's simpler and more reliable.
4993 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
4994 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
4995 sprintf, in case result does not fit in int.
4997 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
4998 (fontset_from_font): Print it.
5000 * frame.c (tty_frame_count): Now printmax_t, not int.
5001 (make_terminal_frame, set_term_frame_name): Print it.
5002 (x_report_frame_params): In X, window IDs are unsigned long,
5003 not signed long, so print them as unsigned.
5004 (validate_x_resource_name): Check for implausibly long names,
5005 and don't assume name length fits in 'int'.
5006 (x_get_resource_string): Don't blindly alloca invocation name;
5007 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
5010 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
5011 (xg_check_special_colors, xg_set_geometry):
5012 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
5014 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
5015 Use esprintf, not sprintf, in case result does not fit in int.
5017 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5018 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
5019 it as a large positive number.
5020 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
5021 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5023 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
5024 in case result does not fit in int.
5026 * print.c (float_to_string): Detect width overflow more reliably.
5027 (print_object): Make sprintf buffer a bit bigger, to avoid potential
5028 buffer overrun. Don't assume list length fits in 'int'. Treat
5029 print length of 0 as 0, not as infinity; to be consistent with other
5030 uses of print length in this function. Don't overflow print length
5031 index. Don't assume hash table size fits in 'long', or that
5032 vectorlike size fits in 'unsigned long'.
5034 * process.c (make_process): Use printmax_t, not int, to format
5035 process-name gensyms.
5037 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
5039 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
5040 to avoid potential buffer overrun.
5042 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
5043 if X resource line is longer than 512 bytes.
5045 * xfns.c (x_window): Make sprintf buffer a bit bigger
5046 to avoid potential buffer overrun.
5048 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
5050 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
5052 2011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5054 Integer overflow fixes for scrolling, etc.
5055 Without these, Emacs silently mishandles large integers sometimes.
5056 For example, "C-u 4294967297 M-x recenter" was treated as if
5057 it were "C-u 1 M-x recenter" on a typical 64-bit host.
5059 * xdisp.c (try_window_id): Check Emacs fixnum range before
5060 converting to 'int'.
5062 * window.c (window_scroll_line_based, Frecenter):
5063 Check that an Emacs fixnum is in range before assigning it to 'int'.
5064 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
5065 values converted from Emacs fixnums.
5066 (Frecenter): Don't wrap around a line count if it is out of 'int'
5067 range; instead, treat it as an extreme value.
5068 (Fset_window_configuration, compare_window_configurations):
5069 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
5071 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
5072 that can exceed INT_MAX. Check that EMACS_INT value is in range
5073 before assigning it to the (possibly-narrower) index.
5074 (match_limit): Don't assume that a fixnum can fit in 'int'.
5076 * print.c (print_object): Use ptrdiff_t, not int, for index that can
5079 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
5080 (Fvertical_motion): Don't wrap around LINES values that don't fit
5081 in 'int'. Instead, treat them as extreme values. This is good
5082 enough for windows, which can't have more than INT_MAX lines anyway.
5084 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5086 * Require libxml/parser.h to avoid compilation warning.
5088 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
5090 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
5091 since this reportedly can destroy thread storage.
5093 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
5095 * syntax.c (find_defun_start): Update all cache variables if
5096 exiting early (Bug#9401).
5098 2011-08-30 Eli Zaretskii <eliz@gnu.org>
5100 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
5102 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
5103 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
5104 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
5106 * term.c (tty_append_glyph): New function.
5107 (produce_stretch_glyph): Static function and its prototype deleted.
5109 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
5112 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
5114 * image.c (parse_image_spec): Check for nonnegative, not for positive,
5115 when checking :margin (Bug#9390).
5116 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
5117 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
5118 so that the name doesn't mislead. All uses changed.
5120 2011-08-28 Johan Bockgård <bojohan@gnu.org>
5122 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
5125 2011-08-27 Eli Zaretskii <eliz@gnu.org>
5127 * xdisp.c (move_it_to): Don't bail out early when reaching
5128 position beyond to_charpos, if we are scanning backwards.
5129 (move_it_vertically_backward): When DY == 0, make sure we get to
5130 the first character in the line after the newline.
5132 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
5134 * ccl.c: Improve and simplify overflow checking (Bug#9196).
5135 (ccl_driver): Do not generate an out-of-range pointer.
5136 (Fccl_execute_on_string): Remove unnecessary check for
5137 integer overflow, noted by Stefan Monnier in
5138 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
5139 Remove a FIXME that didn't need fixing.
5140 Simplify the newly-introduced buffer reallocation code.
5142 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
5144 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
5146 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
5148 Integer and memory overflow issues (Bug#9196).
5150 * doc.c (get_doc_string): Rework so that
5151 get_doc_string_buffer_size is the actual buffer size, rather than
5152 being 1 less than the actual buffer size; this makes xpalloc more
5155 * image.c (x_allocate_bitmap_record, cache_image):
5156 * xselect.c (Fx_register_dnd_atom):
5157 Simplify previous changes by using xpalloc.
5159 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
5160 since either will do and ptrdiff_t is convenient with xpalloc.
5162 * charset.c (charset_table_size)
5163 (struct charset_sort_data.priority): Now ptrdiff_t.
5164 (charset_compare): Don't overflow if priorities differ greatly.
5165 (Fsort_charsets): Don't assume list length fits in int.
5166 Check for size-calculation overflow when allocating sort data.
5167 (syms_of_charset): Allocate an initial charset table that is
5168 just under 64 KiB, to avoid problems with glibc malloc and mmap.
5170 * cmds.c (internal_self_insert): Check for size-calculation overflow.
5172 * composite.h (struct composition.glyph_len): Now int, not unsigned.
5173 The actual value is always <= INT_MAX, and leaving it unsigned made
5174 overflow checking harder.
5176 * dispextern.h (struct glyph_matrix.rows_allocated)
5177 (struct face_cache.size): Now ptrdiff_t, for convenience in use
5178 with xpalloc. The values are still always <= INT_MAX.
5180 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
5182 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
5183 (SAFE_NALLOCA): New macro.
5185 * region-cache.c (struct boundary.pos, find_cache_boundary)
5186 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
5187 (set_cache_region, invalidate_region_cache)
5188 (revalidate_region_cache, know_region_cache, region_cache_forward)
5189 (region_cache_backward, pp_cache):
5190 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
5191 so that ptrdiff_t * can be passed to xpalloc.
5192 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
5193 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
5194 (pp_cache): Don't assume cache_len fits in int.
5195 * region-cache.h: Adjust extern decls to match.
5197 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
5198 EMACS_INT, since either will do, for xpalloc.
5200 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
5201 (xnmalloc, xnrealloc, xpalloc): New functions.
5203 * bidi.c (bidi_shelve_header_size): New constant.
5204 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
5205 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
5207 * bidi.c (bidi_cache_shrink):
5208 * buffer.c (overlays_at, overlays_in, record_overlay_string)
5210 Don't update size of array until after memory allocation succeeds,
5211 because xmalloc/xrealloc may not return.
5212 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
5213 now that we have proper integer overflow checking.
5214 (record_overlay_string, overlay_strings): Catch overflows when
5215 calculating size of overlay_str_buf.
5217 * callproc.c (Fcall_process): Check for size overflow when
5218 calculating size of args2.
5219 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
5220 Normally we prefer signed values, but sticking with ptrdiff_t would
5221 require adding more-complicated checks.
5223 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
5224 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
5225 Redo buffer-overflow calculations to avoid integer overflow.
5226 Add a FIXME comment where memory seems to be over-allocated.
5228 * character.c (Fstring): Check for size-calculation overflow.
5230 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
5231 unnecessary integer overflow. Check for size overflow.
5232 (encode_coding_object): Don't update size until xmalloc succeeds.
5234 * composite.c (get_composition_id): Check for overflow in glyph
5235 length calculations.
5237 Integer and memory overflow fixes for display code.
5238 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
5239 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
5240 (scrolling_window): Check for overflow in size calculations.
5241 (line_draw_cost, realloc_glyph_pool, add_row_entry):
5242 Don't assume glyph table len fits in int.
5243 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
5244 (row_table_size): Now ptrdiff_t, not int.
5245 (scrolling_window): Avoid overflow in size calculations.
5246 Don't update size until allocation succeeds.
5247 * fns.c (concat): Check for overflow in size calculations.
5248 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
5249 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5250 (NEXT_ALMOST_PRIME_LIMIT): New constant.
5252 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
5253 (get_doc_string): Check for size calculation overflow.
5254 Don't update size until allocation succeeds.
5255 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
5256 EMACS_INT, where ptrdiff_t will do.
5257 (Fsubstitute_command_keys): Check for string overflow.
5259 * editfns.c (set_time_zone_rule): Don't assume environment length
5261 (message_length): Now ptrdiff_t, not int.
5262 (Fmessage_box): Don't update size until allocation succeeds.
5263 Don't assume message length fits in int.
5264 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
5266 * emacs.c (main): Do not reallocate argv, since there is a null at
5267 the end that can be overwritten, and this way there's no need to
5268 worry about size-calculation overflow.
5269 (sort_args): Check for size-calculation overflow.
5271 * eval.c (init_eval_once, grow_specpdl): Don't update size until
5273 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
5275 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
5276 (x_set_scroll_bar_width, x_figure_window_size):
5277 Check for integer overflow.
5278 (x_set_alpha): Do not assume XINT fits in int.
5280 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
5281 This is for the members text_lines, text_cols, total_lines, total_cols,
5282 where the system imposes an 'int' limit.
5284 * fringe.c (Fdefine_fringe_bitmap):
5285 Don't update size until alloc works.
5287 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
5288 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
5290 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
5291 Check for size-calculation overflow.
5292 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
5293 do, as we prefer signed integers.
5294 (id_to_widget.max_size, id_to_widget.used)
5295 (xg_store_widget_in_map, xg_remove_widget_from_map)
5296 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
5297 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
5298 Use and return ptrdiff_t, not int.
5299 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
5300 * gtkutil.h: Change prototypes to match the above.
5302 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
5303 are duplicate now that they've been promoted to lisp.h.
5304 (x_allocate_bitmap_record, x_alloc_image_color)
5305 (make_image_cache, cache_image, xpm_load):
5306 Don't update size until alloc is done.
5307 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
5309 Check for size calculation overflow.
5310 (ct_colors_allocated_max): New constant.
5311 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
5314 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
5315 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
5316 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
5317 Use ptrdiff_t, not int, to count maps.
5318 (read_char_minibuf_menu_prompt): Check for overflow in size
5319 calculations. Don't update size until allocation succeeds.
5320 Redo calculations to avoid overflow.
5321 * keyboard.h: Change prototypes to match the above.
5323 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
5325 (current_minor_maps): Check for size calculation overflow.
5326 * keymap.h: Change prototypes to match the above.
5328 * lread.c (read1, init_obarray): Don't update size until alloc done.
5330 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
5331 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
5333 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
5334 Now ptrdiff_t, not int.
5335 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
5336 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
5338 * process.c (Fnetwork_interface_list): Check for overflow
5339 in size calculation.
5341 * region-cache.c (move_cache_gap): Check for size calculation overflow.
5343 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
5344 overflow. Don't bother calling xmalloc when xrealloc will do.
5346 * search.c (Freplace_match): Check for size calculation overflow.
5347 (Fset_match_data): Don't assume list lengths fit in 'int'.
5349 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
5350 for command line length. Do not attempt to address one before the
5351 beginning of an array, as that's not portable.
5353 * term.c (max_frame_lines): Remove; unused.
5354 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
5356 (encode_terminal_code, calculate_costs): Check for size
5357 calculation overflow.
5358 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
5359 table lengths and related sizes. Don't update size until alloc
5360 done. Redo calculations to avoid overflow.
5361 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
5363 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
5364 subtracting pointers.
5365 (gobble_line): Check for overflow more carefully. Don't update size
5368 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
5369 Don't update size until alloc done.
5370 Redo size calculations to avoid overflow.
5371 Check for size calculation overflow.
5372 (main) [DEBUG]: Fix typo in invoking tparam1.
5374 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
5375 Use ptrdiff_t, not int, for sizes.
5376 (store_mode_line_noprop_char): Don't update size until alloc done.
5378 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
5379 Use ptrdiff_t, not int, for sizes.
5380 (Finternal_make_lisp_face, cache_face):
5381 Check for size calculation overflow.
5382 (cache_face): Treat size calculation overflows as if they were
5383 memory exhaustion (the usual treatment), rather than aborting.
5385 * xfns.c (x_encode_text, x_set_name_internal)
5386 (Fx_change_window_property): Use ptrdiff_t, not int, to count
5387 sizes, since they can exceed INT_MAX in size. Check for size
5388 calculation overflow.
5390 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
5391 (xg_select): Check for size calculation overflow.
5392 Don't update size until alloc done.
5394 * xrdb.c (get_environ_db): Don't assume path length fits in int,
5395 as sprintf is limited to int lengths.
5397 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
5398 (X_LONG_MIN): New macros.
5399 Use them to make the following changes clearer.
5400 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
5401 This change doesn't affect the value now, but it may help remind
5402 future maintainers not to raise the value too much later.
5403 (SELECTION_QUANTUM): Remove, replacing with ...
5404 (selection_quantum): ... new function, which avoids overflow.
5406 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
5407 assumption that selection length fits in 'int'.
5408 (x_reply_selection_request, x_handle_selection_request)
5409 (x_get_window_property, receive_incremental_selection)
5410 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
5411 (lisp_data_to_selection_data, clean_local_selection_data):
5412 Use ptrdiff_t, not int, to record length of selection.
5413 (x_reply_selection_request, x_get_window_property)
5414 (receive_incremental_selection, x_property_data_to_lisp):
5415 Redo calculations to avoid overflow.
5416 (x_reply_selection_request): When sending hint, ceiling it at
5417 X_LONG_MAX rather than relying on wraparound overflow to send
5419 (x_get_window_property, receive_incremental_selection)
5420 (lisp_data_to_selection_data, x_property_data_to_lisp):
5421 Check for size-calculation overflow.
5422 (x_get_window_property, receive_incremental_selection)
5423 (lisp_data_to_selection_data, Fx_register_dnd_atom):
5424 Don't store size until memory allocation succeeds.
5425 (x_get_window_property): Plug memory leak on memory exhaustion.
5426 Don't double-block input; malloc is safe here. Don't assume 2**34
5427 - 4 fits in unsigned long. Add an xassert to check
5428 XGetWindowProperty overflow. Be more careful about overflow
5429 calculations, and distinguish size from memory overflow better.
5430 (receive_incremental_selection): When tracing, don't assume
5431 unsigned int is less than INT_MAX.
5432 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
5433 harmful) conversions of unsigned short to int.
5434 (lisp_data_to_selection_data): Don't assume that integers
5435 in the range -65535 through -1 fit in an X unsigned short.
5436 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
5437 result parameters unless successful. Rely on cons_to_unsigned
5438 to report problems with elements; the old code wasn't right anyway.
5439 (x_check_property_data): Check for int overflow; we cannot use
5440 a wider type due to X limits.
5441 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
5443 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
5445 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
5446 (x_term_init): Check for size calculation overflow.
5447 (x_color_cells): Don't store size until memory allocation succeeds.
5448 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
5449 Don't assume alloca size is less than MAX_ALLOCA.
5450 (x_term_init): Don't assume length fits in int (sprintf is limited
5453 Use ptrdiff_t for composition IDs.
5454 * character.c (lisp_string_width):
5455 * composite.c (composition_table_size, n_compositions)
5456 (get_composition_id, composition_gstring_from_id):
5457 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
5458 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
5459 * window.c (Frecenter):
5460 Use ptrdiff_t, not int, for composition IDs.
5461 * composite.c (get_composition_id): Check for integer overflow.
5462 * composite.h: Adjust prototypes to match the above changes.
5464 Use ptrdiff_t for hash table indexes.
5465 * category.c (hash_get_category_set):
5466 * ccl.c (ccl_driver):
5467 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
5468 * coding.c (coding_system_charset_list, detect_coding_system):
5469 * coding.h (struct coding_system.id):
5470 * composite.c (get_composition_id, gstring_lookup_cache):
5471 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
5472 * image.c (xpm_get_color_table_h):
5473 * lisp.h (hash_lookup, hash_put):
5474 * minibuf.c (Ftest_completion):
5475 Use ptrdiff_t for hash table indexes, not int (which is too
5476 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
5477 32-bit --with-wide-int hosts).
5479 * charset.c (Fdefine_charset_internal): Check for integer overflow.
5480 Add a FIXME comment about memory leaks.
5481 (syms_of_charset): Don't assume xmalloc returns.
5483 Don't assume that stated character widths fit in int.
5484 * character.c (Fchar_width, c_string_width, lisp_string_width):
5485 * character.h (CHAR_WIDTH):
5486 * indent.c (MULTIBYTE_BYTES_WIDTH):
5487 Use sanitize_char_width to avoid undefined and/or bad behavior
5488 with outlandish widths.
5489 * character.h (sanitize_tab_width): Rename from sanitize_width,
5490 now that we have two such functions. All uses changed.
5491 (sanitize_char_width): New inline function.
5493 Don't assume that tab-width fits in int.
5494 * character.h (sanitize_width): New inline function.
5495 (SANE_TAB_WIDTH): New macro.
5496 (ASCII_CHAR_WIDTH): Use it.
5497 * indent.c (sane_tab_width): Remove. All uses replaced by
5498 SANE_TAB_WIDTH (current_buffer).
5499 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
5501 * fileio.c: Integer overflow issues with file modes.
5502 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
5504 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
5505 Remove unreachable code.
5506 (read_hex, load_charset_map_from_file): Check for integer overflow.
5508 * xterm.c: Don't go over XClientMessageEvent limit.
5509 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
5510 (x_send_scroll_bar_event): Likewise. Check that the size does not
5511 exceed limits imposed by XClientMessageEvent, as well as the usual
5512 ptrdiff_t and size_t limits.
5514 * keyboard.c: Overflow, signedness and related fixes.
5515 (make_lispy_movement): Use same integer type in forward decl
5516 that is used in the definition.
5517 (read_key_sequence, keyremap_step):
5518 Change bufsize argument back to int, undoing my 2011-03-30 change.
5519 We prefer signed types, and int is wide enough here.
5520 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
5521 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
5522 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
5523 length, not size_t. Use ptrdiff_t for index, not int.
5524 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
5525 possibility of integer overflow.
5527 Overflow, signedness and related fixes for images.
5529 * dispextern.h (struct it.stack[0].u.image.image_id)
5530 (struct_it.image_id, struct image.id, struct image_cache.size)
5531 (struct image_cache.used, struct image_cache.ref_count):
5532 * gtkutil.c (update_frame_tool_bar):
5533 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
5534 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
5535 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
5536 * nsmenu.m (update_frame_tool_bar):
5537 * xdisp.c (calc_pixel_width_or_height):
5538 * xfns.c (image_cache_refcount):
5539 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
5540 on typical 64-bit hosts.
5542 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5543 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
5544 Omit unnecessary casts to int.
5545 (parse_image_spec): Check that integers fall into 'int' range
5546 when the callers expect that.
5547 (image_ascent): Redo ascent calculation to avoid int overflow.
5548 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
5549 (lookup_image): Remove unnecessary tests.
5550 (xbm_image_p): Locals are now of int, not EMACS_INT,
5551 since parse_image_check makes sure they fit into int.
5552 (png_load, gif_load, svg_load_image):
5553 Prefer int to unsigned where either will do.
5554 (tiff_handler): New function, combining the cores of the
5555 old tiff_error_handler and tiff_warning_handler.
5556 This function is rewritten to use vsnprintf and thereby avoid
5557 stack buffer overflows. It uses only the features of vsnprintf
5558 that are common to both POSIX and native Microsoft.
5559 (tiff_error_handler, tiff_warning_handler): Use it.
5560 (tiff_load, gif_load, imagemagick_load_image):
5561 Don't assume :index value fits in 'int'.
5562 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
5563 (imagemagick_load_image): Check that crop parameters fit into
5564 the integer types that MagickCropImage accepts. Don't assume
5565 Vimagemagick_render_type has a nonnegative value. Don't assume
5566 size_t fits in 'long'.
5567 (gs_load): Use printmax_t to print the widest integers possible.
5568 Check for integer overflow when computing image height and width.
5570 2011-08-26 Eli Zaretskii <eliz@gnu.org>
5572 * xdisp.c (redisplay_window): Don't force window start if point
5573 will be invisible in the resulting window. (Bug#9324)
5575 2011-08-25 Eli Zaretskii <eliz@gnu.org>
5577 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
5578 the display spec is of the form `(space ...)'.
5579 (handle_display_spec): Return the value returned by
5580 handle_single_display_spec, not just 1 or zero.
5581 (handle_single_display_spec): If the display spec is of the form
5582 `(space ...)', and specifies display in the text area, return 2
5584 (try_cursor_movement): Check for the need to scroll more
5585 accurately, and prefer exact match for point under bidi.
5586 Don't advance `row' beyond the last row of the window.
5588 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
5589 into disp_prop; all users changed.
5591 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
5592 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
5593 for the text covered by the display property.
5595 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
5597 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
5598 Change return value to nil.
5599 (Frecord_buffer): Delete unused function.
5601 2011-08-24 Eli Zaretskii <eliz@gnu.org>
5603 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
5604 buffers, return left-to-right.
5605 (set_cursor_from_row): Consider candidate row a win if its glyph
5606 represents a newline and point is on that newline. Fixes cursor
5607 positioning on the newline at EOL of R2L text within L2R
5608 paragraph, and vice versa.
5609 (try_cursor_movement): Check continued rows, in addition to
5610 continuation rows. Fixes unwarranted scroll when point enters a
5611 continued line of R2L text within an L2R paragraph, or vice versa.
5612 (cursor_row_p): Consider the case of point being equal to
5613 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
5614 from the end of a short line to the beginning of a continued line
5615 of R2L text within L2R paragraph.
5616 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
5617 composed characters.
5619 * bidi.c (bidi_check_type): Use xassert.
5620 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
5623 2011-08-23 Eli Zaretskii <eliz@gnu.org>
5625 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
5628 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
5630 * nsfont.m (ns_otf_to_script): Fix typo.
5632 2011-08-22 Kenichi Handa <handa@m17n.org>
5634 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
5635 extra slot even if the purpose is char-code-property-table.
5637 2011-08-23 Eli Zaretskii <eliz@gnu.org>
5639 * xdisp.c (redisplay_window): When computing centering_position,
5640 account for the height of the header line. (Bug#8874)
5642 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
5643 instead of CHAR_TO_BYTE. Fixes a crash when a completion
5644 candidate is selected by the mouse, and that candidate has a
5645 composed character under the mouse.
5647 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
5648 coordinates reported by pos-visible-in-window-p for a composed
5649 character in column zero.
5651 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
5653 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
5655 2011-08-22 Eli Zaretskii <eliz@gnu.org>
5657 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
5658 consider it a hit if to_charpos is anywhere in the range of the
5659 composed buffer positions.
5661 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
5663 * image.c (gif_load): Don't assume that each subimage has the same
5664 dimensions as the base image. Handle disposal method that is
5665 "undefined" by the gif spec (Bug#9335).
5667 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
5669 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
5670 (Fcondition_case): Document `debug' symbol in error handler.
5672 2011-08-19 Eli Zaretskii <eliz@gnu.org>
5674 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
5675 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
5676 from an Org mode buffer to a Speedbar frame.
5678 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
5679 a composition, take its buffer position from IT->cmp_it.charpos.
5680 Fixes cursor positioning at the beginning of a line that begins
5681 with a composed character.
5683 2011-08-18 Eli Zaretskii <eliz@gnu.org>
5685 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
5686 character bidirectional type, use STRONG_L instead. Fixes crashes
5687 in a buffer produced by `describe-categories'.
5689 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
5690 members before the level stack, so they would be saved and
5691 restored when copying iterator state. Fixes incorrect reordering
5692 around TABs covered by display properties.
5694 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
5696 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
5698 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
5700 * eval.c (internal_condition_case, internal_condition_case_1)
5701 (internal_condition_case_2, internal_condition_case_n):
5702 Remove unnecessary aborts (Bug#9081).
5704 2011-08-17 Eli Zaretskii <eliz@gnu.org>
5706 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
5707 has no `load' handler, try opening the file locally. (Bug#9311)
5709 2011-08-16 Ken Brown <kbrown@cornell.edu>
5711 * gmalloc.c: Expand comment.
5713 2011-08-16 Eli Zaretskii <eliz@gnu.org>
5715 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
5716 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
5718 2011-08-16 Ken Brown <kbrown@cornell.edu>
5720 Fix memory allocation problems in Cygwin build (Bug#9273).
5722 * unexcw.c ( __malloc_initialized): Declare external variable.
5723 (fixup_executable): Force the dumped emacs to reinitialize malloc.
5725 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
5727 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
5729 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
5731 [CYGWIN] (special_realloc): New function.
5732 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
5733 requests to realloc storage in the static heap.
5735 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
5737 * bidi.c (bidi_initialize): Remove unused local.
5739 2011-08-15 Eli Zaretskii <eliz@gnu.org>
5742 * biditype.h: Remove file.
5743 * makefile.w32-in ($(BLD)/bidi.$(O)):
5744 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
5746 * dispextern.h: Fix a typo in the comment to bidi_type_t.
5748 * chartab.c: Improve commentary for the uniprop_table API.
5750 * bidi.c (bidi_paragraph_init): Support zero value of
5751 bidi_ignore_explicit_marks_for_paragraph_level.
5752 (bidi_initialize): Use uniprop_table instead of including
5753 biditype.h and bidimirror.h.
5755 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
5756 coordinates of the iterator when restoring from ppos_it.
5759 2011-08-14 Kenichi Handa <handa@m17n.org>
5761 * process.c (create_process): Call setup_process_coding_systems
5762 after the pid of the process is set to -1 (Bug#8162).
5764 2011-08-14 Eli Zaretskii <eliz@gnu.org>
5766 * xdisp.c (move_it_in_display_line_to): Don't invoke
5767 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
5768 ppos_it. Fixes vertical cursor motion when line beginning is
5769 covered by an image. (Bug#9296)
5771 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
5773 * nsterm.h (ns_run_ascript): Declare.
5774 (NSAPP_DATA2_RUNASSCRIPT): Define.
5776 * nsfns.m (as_script, as_result, as_status): New static variables.
5777 (ns_run_ascript): New function.
5778 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
5779 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
5780 the event loop. Get status from as_status (Bug#7276).
5782 * nsterm.m (sendEvent): If event is NSApplicationDefined and
5783 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
5784 the event loop (Bug#7276).
5786 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
5788 * gnutls.c (QCgnutls_bootprop_priority)
5789 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
5790 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
5791 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
5792 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
5793 (QCgnutls_bootprop_verify_hostname_error)
5794 (QCgnutls_bootprop_callbacks_verify): Rename from
5795 Qgnutls_bootprop_..., all uses changed.
5797 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
5800 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
5802 * xfaces.c (Qframe_set_background_mode): Now static.
5803 * dispextern.h (Qframe_set_background_mode): Remove decl.
5805 * process.c (Fnetwork_interface_info): Declare local only if needed.
5807 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
5809 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
5810 (Fnetwork_interface_list): Allocate in increments of bytes instead
5811 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
5812 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
5814 (struct ifflag_def): notrailers is smart on OSX.
5815 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
5816 Get hardware address with getifaddrs if available.
5818 2011-08-12 Eli Zaretskii <eliz@gnu.org>
5820 * xdisp.c (iterate_out_of_display_property): xassert that
5821 IT->position is set to within IT->object's boundaries. Break from
5822 the loop as soon as EOB is reached; avoids infloops in redisplay
5823 when IT->position is set up wrongly due to some bug.
5824 Set IT->current to match the bidi iterator unconditionally.
5825 (push_display_prop): Allow GET_FROM_STRING as IT->method on
5826 entry. Force push_it to save on the stack the current
5827 buffer/string position, to be restored by pop_it. Fix flags in
5828 the iterator structure wrt the object coming from a display
5829 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
5830 properties. (Bug#9284)
5832 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
5834 * fontset.c (fontset_get_font_group): Add proper type checks.
5837 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5839 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
5840 and LC_VERSION_MIN_MACOSX.
5841 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
5842 (dump_it) [LC_FUNCTION_STARTS]: Use it.
5844 2011-08-08 Eli Zaretskii <eliz@gnu.org>
5846 * xdisp.c (forward_to_next_line_start): Allow to use the
5847 no-display-properties-and-no-overlays under bidi display.
5848 Set disp_pos in the bidi iterator to avoid searches for display
5849 properties and overlays.
5851 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
5853 * editfns.c (Fset_time_zone_rule): Document relationship with the
5856 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
5857 the font entity extracted from the cache (Bug#8109).
5859 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
5861 * composite.c (autocmp_chars): Don't reset point. That is done by
5862 restore_point_unwind (Bug#5984).
5864 2011-08-07 Juri Linkov <juri@jurta.org>
5866 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
5867 to show the arg `TIME' instead of `TIMEVAL'.
5869 2011-08-06 Eli Zaretskii <eliz@gnu.org>
5871 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
5872 display property strides EOL and includes a newline, as in
5873 longlines-mode. (Bug#9254)
5874 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
5875 word-wrap under bidirectional display. (Bug#9224)
5877 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
5878 is non-zero, even if the data buffer is NULL. Fixes a crash in
5879 vertical-motion with longlines-mode. (Bug#9254)
5881 2011-08-05 Eli Zaretskii <eliz@gnu.org>
5883 * bidi.c <bidi_cache_total_alloc>: Now static.
5884 (bidi_initialize): Initialize bidi_cache_total_alloc.
5886 * xdisp.c (display_line): Release buffer allocated for shelved bidi
5889 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
5890 amount allocated this far in `bidi_cache_total_alloc'.
5891 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
5892 non-zero, only free the data buffer without restoring the cache
5893 contents. All callers changed.
5895 * dispextern.h (bidi_unshelve_cache): Update prototype.
5897 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
5898 (move_it_in_display_line, move_it_to)
5899 (move_it_vertically_backward, move_it_by_lines): Replace the call
5900 to xfree to an equivalent call to bidi_unshelve_cache.
5901 (move_it_in_display_line_to): Fix logic of returning
5902 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
5904 2011-08-05 Eli Zaretskii <eliz@gnu.org>
5906 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
5907 came from a string character with a `cursor' property. (Bug#9229)
5909 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5911 * Makefile.in (LIB_PTHREAD): New variable.
5912 (LIBES): Add LIB_PTHREAD (Bug#9216).
5914 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
5915 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
5917 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
5919 * regex.c (re_iswctype): Remove some redundant boolean conversions.
5921 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5923 * xterm.c (x_find_topmost_parent): New function.
5924 (x_set_frame_alpha): Find topmost parent window with
5925 x_find_topmost_parent and set the property there also (bug#9181).
5926 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
5928 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
5930 * callproc.c (Fcall_process): Avoid vfork clobbering
5931 the local vars buffer, coding_systems, current_dir.
5933 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
5935 * keymap.c (Fmake_composed_keymap): Move to subr.el.
5937 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
5939 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
5940 so that it is not optimized away.
5942 * xdisp.c (compute_display_string_pos): Remove unused local.
5944 2011-08-02 Eli Zaretskii <eliz@gnu.org>
5946 Fix slow cursor motion and scrolling in large buffers with
5947 selective display, like Org Mode buffers. (Bug#9218)
5949 * dispextern.h (struct bidi_it): New member disp_prop_p.
5951 * xdisp.c: Remove one-slot cache of display string positions.
5952 (compute_display_string_pos): Accept an additional argument
5953 DISP_PROP_P; callers changed. Scan at most 5K characters forward
5954 for a display string or property. If found, set DISP_PROP_P
5957 * bidi.c (bidi_fetch_char): Accept an additional argument
5958 DISP_PROP_P, and pass it to compute_display_string_pos.
5959 Only handle text covered by a display string if DISP_PROP_P is returned
5960 non-zero. All callers of bidi_fetch_char changed.
5962 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
5964 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
5966 2010-12-03 Don March <don@ohspite.net>
5968 * keymap.c (Fdefine_key): Fix non-prefix key error message when
5969 last character M-[char] is translated to ESC [char] (bug#7541).
5971 2011-08-02 Kenichi Handa <handa@m17n.org>
5973 * lisp.h (uniprop_table): Extern it.
5975 * chartab.c (uniprop_table): Make it non-static.
5977 2011-08-01 Eli Zaretskii <eliz@gnu.org>
5979 * xdisp.c (forward_to_next_line_start): Accept additional argument
5980 BIDI_IT_PREV, and store into it the state of the bidi iterator had
5982 (reseat_at_next_visible_line_start): Use the bidi iterator state
5983 returned by forward_to_next_line_start to restore the state of
5984 it->bidi_it after backing up to previous newline. (Bug#9212)
5986 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
5988 * regex.c (re_comp): Protoize.
5989 (re_exec): Fix return type.
5990 (regexec): Fix type of `ret'. (Bug#9203)
5992 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5994 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
5995 This is needed if max-image-size is a floating-point number.
5997 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5999 * print.c (print_object): Print empty symbol as ##.
6001 * lread.c (read1): Read ## as empty symbol.
6003 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6005 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
6006 setting frame foreground color (Bug#9175).
6007 (x_set_background_color): Likewise.
6009 * nsmenu.m (-setText): Size tooltip dimensions precisely to
6010 contents (Bug#9176).
6011 (EmacsTooltip -init): Remove bezels and add shadows to
6014 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
6015 or scroll bar (Bug#8470).
6017 * nsfont.m (nsfont_open): Remove assignment to voffset and
6018 unnecessary vars hshink, expand, hd, full_height, min_height.
6019 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
6021 * nsterm.h (nsfont_info): Remove voffset field.
6023 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6025 Implement strike-through and overline on NextStep (Bug#8863).
6027 * nsfont.m (nsfont_open): Use underline position provided by font,
6028 instead of hard-coded value of 2.
6029 (nsfont_draw): Call ns_draw_text_decoration instead.
6031 * nsterm.h: Add declaration for ns_draw_text_decoration.
6033 * nsterm.m (ns_draw_text_decoration): New function for drawing
6034 underline, overline, and strike-through.
6035 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
6036 ns_draw_text_decoration. Change treatment of cursor drawing to
6037 accommodate underlining, etc.
6039 2011-07-28 Eli Zaretskii <eliz@gnu.org>
6041 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
6044 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6046 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
6047 Without this fix, if a signal arrives just after memory fills up,
6048 'malloc' might be invoked reentrantly.
6050 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
6051 In other words, assume that every image size is allowed, on non-X
6052 hosts. This assumption is probably wrong, but it lets Emacs compile.
6054 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6056 * regex.c (re_iswctype): Convert return values to boolean.
6058 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
6060 * xdisp.c (compute_display_string_pos): Don't use cached display
6061 string position if the buffer had its restriction changed.
6064 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6066 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6068 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6070 Integer signedness and overflow and related fixes. (Bug#9079)
6072 * bidi.c: Integer size and overflow fixes.
6073 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
6074 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
6075 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6076 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
6077 (bidi_find_other_level_edge):
6078 Use ptrdiff_t instead of EMACS_INT where either will do.
6079 This works better on 32-bit hosts configured --with-wide-int.
6080 (bidi_cache_ensure_space): Check for size-calculation overflow.
6081 Use % rather than repeated addition, for better worst-case speed.
6082 Don't set bidi_cache_size until after xrealloc returns, because it
6084 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
6085 (bidi_cache_ensure_space): Also check that the bidi cache size
6086 does not exceed that of the largest Lisp string or buffer. See Eli
6087 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
6089 * alloc.c (__malloc_size_t): Remove.
6090 All uses replaced by size_t. See Andreas Schwab's note
6091 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
6093 * image.c: Improve checking for integer overflow.
6094 (check_image_size): Assume that f is nonnull, since
6095 it is always nonnull in practice. This is one less thing to
6096 worry about when checking for integer overflow later.
6097 (x_check_image_size): New function, which checks for integer
6098 overflow issues inside X.
6099 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
6100 This removes the need for a memory_full check.
6101 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
6102 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
6103 (xbm_read_bitmap_data): Change locals back to 'int', since
6104 their values must fit in 'int'.
6105 (xpm_load_image, png_load, tiff_load):
6106 Invoke x_create_x_image_and_pixmap earlier,
6107 to avoid much needless work if the image is too large.
6108 (tiff_load): Treat overly large images as if
6109 x_create_x_image_and_pixmap failed, not as malloc failures.
6110 (gs_load): Use x_check_image_size.
6112 * gtkutil.c: Omit integer casts.
6113 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
6114 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
6116 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
6118 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
6119 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
6120 would wrongly return t on a 64-bit host.
6122 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
6123 The plain *_OVERFLOW macros run afoul of GCC bug 49705
6124 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
6125 and therefore cause GCC to emit a bogus diagnostic in some cases.
6127 * image.c: Integer signedness and overflow and related fixes.
6128 This is not an exhaustive set of fixes, but it's time to
6129 record what I've got.
6130 (lookup_pixel_color, check_image_size): Remove redundant decls.
6131 (check_image_size): Don't assume that arbitrary EMACS_INT values
6132 fit in 'int', or that arbitrary 'double' values fit in 'int'.
6133 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
6134 (tiff_load, imagemagick_load_image):
6135 Check for overflow in size calculations.
6136 (x_create_x_image_and_pixmap): Remove unnecessary test for
6137 xmalloc returning NULL; that can't happen.
6138 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
6139 (xpm_color_bucket): Use better integer hashing function.
6140 (xpm_cache_color): Don't possibly over-allocate memory.
6141 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
6142 (gif_memory_source):
6143 Use ptrdiff_t, not int or size_t, to record sizes.
6144 (png_load): Don't assume values greater than 2**31 fit in 'int'.
6145 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
6146 either works, as we prefer signed integers.
6147 (tiff_read_from_memory, tiff_write_from_memory):
6148 Return tsize_t, not size_t, since that's what the TIFF API wants.
6149 (tiff_read_from_memory): Don't fail simply because the read would
6150 go past EOF; instead, return a short read.
6151 (tiff_load): Omit no-longer-needed casts.
6152 (Fimagemagick_types): Don't assume size fits into 'int'.
6154 Improve hashing quality when configured --with-wide-int.
6155 * fns.c (hash_string): New function, taken from sxhash_string.
6156 Do not discard information about ASCII character case; this
6157 discarding is no longer needed.
6158 (sxhash-string): Use it. Change sig to match it. Caller changed.
6159 * lisp.h: Declare it.
6160 * lread.c (hash_string): Remove, since we now use fns.c's version.
6161 The fns.c version returns a wider integer if --with-wide-int is
6162 specified, so this should help the quality of the hashing a bit.
6164 * emacs.c: Integer overflow minor fix.
6165 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
6166 Define only if GNU_LINUX.
6167 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
6169 * dispnew.c: Integer signedness and overflow fixes.
6170 Remove unnecessary forward decls, that were a maintenance hassle.
6171 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
6173 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
6174 (scrolling_window): Use ptrdiff_t, not int, for byte count.
6175 (prepare_desired_row, line_draw_cost):
6176 Use int, not unsigned, where either works.
6177 (save_current_matrix, restore_current_matrix):
6178 Use ptrdiff_t, not size_t, where either works.
6179 (init_display): Check for overflow more accurately, and without
6180 relying on undefined behavior.
6182 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
6183 Remove, replacing with the new symbols in lisp.h. All uses changed.
6184 * fileio.c (make_temp_name):
6185 * filelock.c (lock_file_1, lock_file):
6186 * xdisp.c (message_dolog):
6187 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
6188 Use pMd etc. instead.
6189 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
6190 replacing the pWIDE etc. symbols removed from editfns.c.
6192 * keyboard.h (num_input_events): Now uintmax_t.
6193 This is (very slightly) less likely to mess up due to wraparound.
6196 * buffer.c: Integer signedness fixes.
6197 (alloc_buffer_text, enlarge_buffer_text):
6198 Use ptrdiff_t rather than size_t when either will do, as we prefer
6201 * alloc.c: Integer signedness and overflow fixes.
6202 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
6203 (__malloc_size_t): Default to size_t, not to int.
6204 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
6205 (Fgarbage_collect, mark_object_loop_halt, mark_object):
6206 Prefer ptrdiff_t to size_t when either would do, as we prefer
6208 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
6209 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
6210 Now const. Initialize with values that are in range even if char
6212 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
6213 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
6214 These functions do the right thing with sizes > 2**32.
6215 (check_depth): Now ptrdiff_t, not int.
6216 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
6217 Adjust to new way of storing sizes. Check for size overflow bugs
6219 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
6220 slightly wrong anyway, as it missed one instance of
6221 XMALLOC_OVERRUN_CHECK_OVERHEAD.
6222 (refill_memory_reserve): Omit needless cast to size_t.
6223 (mark_object_loop_halt): Mark as externally visible.
6225 * xselect.c: Integer signedness and overflow fixes.
6226 (Fx_register_dnd_atom, x_handle_dnd_message):
6227 Use ptrdiff_t, not size_t, since we prefer signed.
6228 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
6229 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
6230 x_dnd_atoms_size and x_dnd_atoms_length.
6232 * doprnt.c: Prefer signed to unsigned when either works.
6234 * doprnt.c (doprnt):
6236 * xdisp.c (vmessage):
6237 Use ptrdiff_t, not size_t, when using or implementing doprnt,
6238 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
6239 prefer signed arithmetic to avoid comparison confusion.
6240 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
6241 but is a bit tricky.
6243 Assume freestanding C89 headers, string.h, stdlib.h.
6244 * data.c, doprnt.c, floatfns.c, print.c:
6245 Include float.h unconditionally.
6246 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
6247 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
6248 * regex.c: Likewise for stddef.h, string.h.
6249 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
6250 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
6251 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
6252 (STDC_HEADERS): Remove obsolete defines.
6253 * sysdep.c: Include limits.h unconditionally.
6255 Assume support for memcmp, memcpy, memmove, memset.
6256 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
6257 * regex.c (memcmp, memcpy):
6258 Remove; we assume C89 now.
6260 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
6261 (__malloc_safe_bcopy): Remove; no longer needed.
6263 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6264 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
6265 well either way, and we prefer signed to unsigned.
6267 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
6269 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
6270 closes the connection while we're reading (bug#9182).
6272 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
6274 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
6275 are specified (Bug#9168).
6277 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
6279 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
6280 Found by GCC static checking and --with-wide-int on a 32-bit host.
6282 2011-07-25 Eli Zaretskii <eliz@gnu.org>
6284 * xdisp.c (compute_display_string_pos): Fix logic of caching
6285 previous display string position. Initialize cached_prev_pos to
6286 -1. Fixes slow-down at the beginning of a buffer.
6288 2011-07-24 Eli Zaretskii <eliz@gnu.org>
6290 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
6291 for attrs[LFACE_FONTSET_INDEX].
6293 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
6295 * xml.c (parse_region): Remove unused local
6296 that was recently introduced.
6298 2011-07-23 Eli Zaretskii <eliz@gnu.org>
6300 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
6301 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
6303 * xdisp.c (move_it_in_display_line_to): Record the best matching
6304 position for TO_CHARPOS while scanning the line, and restore it on
6305 exit if none of the characters scanned was an exact match.
6306 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
6307 when exact match is impossible due to invisible text, and the
6308 lines are truncated.
6310 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
6312 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
6315 2011-07-22 Eli Zaretskii <eliz@gnu.org>
6317 Fix a significant slow-down of cursor motion with C-n, C-p,
6318 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
6319 auto-repeat under bidi redisplay in fontified buffers.
6320 * xdisp.c (compute_stop_pos_backwards): New function.
6321 (next_element_from_buffer): Call compute_stop_pos_backwards to
6322 find a suitable prev_stop when we find ourselves before
6324 (reseat): Don't look for prev_stop, as that could mean a very long
6326 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
6327 <cached_disp_overlay_modiff>: Cache for last found display string
6329 (compute_display_string_pos): Return the cached position if asked
6330 about the same buffer in the same area of character positions, and
6331 the buffer wasn't changed since the time the display string
6332 position was cached.
6334 2011-07-22 Eli Zaretskii <eliz@gnu.org>
6336 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
6337 is an integer, which is important for empty lines. (Bug#9149)
6339 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
6341 * frame.c (Fmodify_frame_parameters): In tty case, update the
6342 default face if necessary (Bug#4238).
6344 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
6346 * editfns.c (Fstring_to_char): No need to explain what a character
6347 is in the docstring (Bug#6576).
6349 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6351 * xml.c (parse_region): Make sure we always return a tree.
6353 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
6355 * xml.c (parse_region): If a document contains only comments,
6358 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6360 * xml.c (make_dom): Return comments, too.
6362 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
6365 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
6366 and the surrounding thread.
6367 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
6368 rather than fgets, and retry after EINTR. Otherwise, 'emacs
6369 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
6371 * s/openbsd.h (BROKEN_SIGIO): Define.
6372 * unexelf.c (unexec) [__OpenBSD__]:
6373 Don't update the .mdebug section of the Alpha COFF symbol table.
6375 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6377 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
6380 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
6382 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
6383 This fixes some race conditions on the permissions of any newly
6386 * alloc.c (valid_pointer_p): Use pipe, not open.
6387 This fixes some permissions issues when debugging.
6389 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
6390 If fchown fails to set both uid and gid, try to set just gid,
6391 as that is sometimes allowed. Adjust the file's mode to eliminate
6392 setuid or setgid bits that are inappropriate if fchown fails.
6394 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
6396 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
6397 to compare Lisp_Objects.
6398 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
6399 global_gnutls_log_level, don't mistake it for a Lisp_Object.
6400 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
6402 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
6404 * lread.c (read_integer): Unread even EOF character.
6405 (read1): Likewise. Properly record start position of symbol.
6407 * lread.c (read1): Read `#:' as empty uninterned symbol if no
6408 symbol character follows.
6410 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
6412 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
6413 This works around a problem with the previous change to Fcopy_file.
6414 Recent glibc declares fchown with __attribute__((warn_unused_result)),
6415 and without this change, GCC might complain about discarding
6416 fchown's return value.
6418 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
6420 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
6422 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
6424 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
6426 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
6428 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
6429 it's used from the C level.
6431 * process.c: Use the same condition for POLL_FOR_INPUT in both
6432 keyboard.c and process.c (bug#1858).
6434 2011-07-09 Lawrence Mitchell <wence@gmx.li>
6436 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
6437 (Fgnutls_boot): Use it.
6439 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
6441 * doc.c (Fsubstitute_command_keys): Revert last change.
6443 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
6445 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
6446 quotes the next character, and doesn't affect other longer
6447 sequences (bug#8935).
6449 * lread.c (syms_of_lread): Clarify that is isn't only
6450 `eval-buffer' and `eval-defun' that's affected by
6451 `lexical-binding' (bug#8460).
6453 2011-07-15 Eli Zaretskii <eliz@gnu.org>
6455 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6456 bidi redisplay when a line includes both an image and is truncated.
6458 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
6460 Fix minor problems found by static checking.
6461 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
6462 (elsz): Now a signed constant, not a size_t var. We prefer signed
6463 types to unsigned, to avoid integer comparison confusion. Without
6464 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
6465 "cannot optimize loop, the loop counter may overflow", a symptom
6467 * indent.c (Fvertical_motion): Mark locals as initialized.
6468 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
6470 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6472 * search.c (Fre_search_backward): Mention `case-fold-search' in
6473 all the re_search_* functions (bug#8138).
6475 * keyboard.c (Fopen_dribble_file): Document when the file is
6478 2011-07-14 Eli Zaretskii <eliz@gnu.org>
6480 * bidi.c (bidi_dump_cached_states): Fix format of displaying
6483 Support bidi reordering of display and overlay strings.
6484 * xdisp.c (compute_display_string_pos)
6485 (compute_display_string_end): Accept additional argument STRING.
6486 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
6487 (reseat_to_string): Initialize bidi_it->string.s and
6488 bidi_it->string.schars.
6489 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
6490 NULL (avoids a crash in bidi_paragraph_init).
6491 Initialize itb.string.lstring.
6492 (init_iterator): Call bidi_init_it only of a valid
6493 buffer position was specified. Initialize paragraph_embedding to
6495 (reseat_to_string): Initialize the bidi iterator.
6496 (display_string): If we need to ignore text properties of
6497 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
6498 original value of -1 will not work with bidi.)
6499 (compute_display_string_pos): First arg is now struct
6500 `text_pos *'; all callers changed. Support display properties on
6502 (compute_display_string_end): Support display properties on Lisp
6504 (init_iterator, reseat_1, reseat_to_string): Initialize the
6505 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
6506 when iterating on a string not from display properties).
6507 (compute_display_string_pos, compute_display_string_end):
6508 Fix calculation of the object to scan. Fixes an error when using
6510 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
6511 base_level_stop; instead, set base_level_stop to BEGV.
6512 Fixes crashes in vertical-motion.
6513 (next_element_from_buffer): Improve commentary for when
6514 the iterator is before prev_stop.
6515 (init_iterator): Initialize bidi_p from the default value of
6516 bidi-display-reordering, not from buffer-local value. Use the
6517 buffer-local value only if initializing for buffer iteration.
6518 (handle_invisible_prop): Support invisible properties on strings
6519 that are being bidi-reordered.
6520 (set_iterator_to_next): Support bidi reordering of C strings and
6522 (next_element_from_string): Support bidi reordering of Lisp
6524 (handle_stop_backwards): Support Lisp strings as well.
6525 (display_string): Support display of R2L glyph rows.
6526 Use IT_STRING_CHARPOS when displaying from a Lisp string.
6527 (init_iterator): Don't initialize it->bidi_p for strings
6529 (reseat_to_string): Initialize it->bidi_p for strings here.
6530 (next_element_from_string, next_element_from_c_string)
6531 (next_element_from_buffer): Add xassert's for correspondence
6532 between IT's object being iterated and it->bidi_it.string
6534 (face_before_or_after_it_pos): Support bidi iteration.
6535 (next_element_from_c_string): Handle the case of the first string
6536 character that is not the first one in the visual order.
6537 (get_visually_first_element): New function, refactored from common
6538 parts of next_element_from_buffer, next_element_from_string, and
6539 next_element_from_c_string.
6540 (tool_bar_lines_needed, redisplay_tool_bar)
6541 (display_menu_bar): Force left-to-right direction. Add a FIXME
6542 comment for making that be controlled by a user option.
6543 (push_it, pop_it): Save and restore the state of the
6544 bidi iterator. Save and restore the bidi_p flag.
6545 (pop_it): Iterate out of display property for string iteration as
6547 (iterate_out_of_display_property): Support iteration over strings.
6548 (handle_single_display_spec): Set up it->bidi_it for iteration
6549 over a display string, and call bidi_init_it.
6550 (handle_single_display_spec, next_overlay_string)
6551 (get_overlay_strings_1, push_display_prop): Set up the bidi
6552 iterator for displaying display or overlay strings.
6553 (forward_to_next_line_start): Don't use the shortcut if
6555 (back_to_previous_visible_line_start): If handle_display_prop
6556 pushed the iterator stack, restore the internal state of the bidi
6557 iterator by calling bidi_pop_it same number of times.
6558 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
6559 and we are bidi-iterating, don't decrement the iterator position;
6560 instead, set the first_elt flag in the bidi iterator, to produce
6562 (reseat_1): Remove redundant setting of string_from_display_prop_p.
6563 (push_display_prop): xassert that we are iterating a buffer.
6564 (push_it, pop_it): Save and restore paragraph_embedding member.
6565 (handle_single_display_spec, next_overlay_string)
6566 (get_overlay_strings_1, reseat_1, reseat_to_string)
6567 (push_display_prop): Set up the `unibyte' member of bidi_it.string
6568 correctly. Don't assume unibyte strings are not bidi-reordered.
6569 (compute_display_string_pos)
6570 (compute_display_string_end): Fix handling the case of C string.
6571 (push_it, pop_it): Save and restore from_disp_prop_p.
6572 (handle_single_display_spec, push_display_prop): Set the
6573 from_disp_prop_p flag.
6574 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
6575 (pop_it): Call iterate_out_of_display_property only if we are
6576 popping after iteration over a string that came from a display
6577 property. Fix a typo in popping stretch info. Add an assertion
6578 for verifying that the iterator position is in sync with the bidi
6580 (handle_single_display_spec, get_overlay_strings_1)
6581 (push_display_prop): Fix initialization of paragraph direction for
6582 string when that of the parent object is not yet determined.
6583 (reseat_1): Call bidi_init_it to resync the bidi
6584 iterator with IT's position. (Bug#7616)
6585 (find_row_edges): If ROW->start.pos gives position
6586 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
6587 (handle_stop, back_to_previous_visible_line_start, reseat_1):
6588 Reset the from_disp_prop_p flag.
6589 (SAVE_IT, RESTORE_IT): New macros.
6590 (pos_visible_p, face_before_or_after_it_pos)
6591 (back_to_previous_visible_line_start)
6592 (move_it_in_display_line_to, move_it_in_display_line)
6593 (move_it_to, move_it_vertically_backward, move_it_by_lines)
6594 (try_scrolling, redisplay_window, display_line): Use them when
6595 saving a temporary copy of the iterator and restoring it back.
6596 (back_to_previous_visible_line_start, reseat_1)
6597 (init_iterator): Empty the bidi cache "stack".
6598 (move_it_in_display_line_to): If iterator ended up at
6599 EOL, but we never saw any buffer positions smaller than
6600 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
6601 motion in bidi-reordered lines.
6602 (move_it_in_display_line_to): Record prev_method and prev_pos
6603 immediately before the call to set_iterator_to_next. Fixes cursor
6604 motion in bidi-reordered lines with stretch glyphs and strings
6605 displayed in margins. (Bug#8133) (Bug#8867)
6606 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
6608 (pos_visible_p): Support positions in bidi-reordered lines.
6609 Save and restore bidi cache.
6611 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
6612 (bidi_paragraph_info): Delete unused struct.
6613 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
6614 (bidi_cache_start): New variable.
6615 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
6617 (bidi_cache_fetch_state, bidi_cache_search)
6618 (bidi_cache_find_level_change, bidi_cache_iterator_state)
6619 (bidi_cache_find, bidi_peek_at_next_level)
6620 (bidi_level_of_next_char, bidi_find_other_level_edge)
6621 (bidi_move_to_visually_next): Compare cache index with
6622 bidi_cache_start rather than with zero.
6623 (bidi_fetch_char): Accept new argument STRING; all callers
6624 changed. Support iteration over a string. Support strings with
6625 display properties. Support unibyte strings. Fix the type of
6626 `len' according to what STRING_CHAR_AND_LENGTH expects.
6627 (bidi_paragraph_init, bidi_resolve_explicit_1)
6628 (bidi_resolve_explicit, bidi_resolve_weak)
6629 (bidi_level_of_next_char, bidi_move_to_visually_next):
6630 Support iteration over a string.
6631 (bidi_set_sor_type, bidi_resolve_explicit_1)
6632 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
6633 can now be zero (for strings); special values 0 and -1 were
6634 changed to -1 and -2, respectively.
6635 (bidi_char_at_pos): New function.
6636 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
6637 Call it instead of FETCH_MULTIBYTE_CHAR.
6638 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
6639 initialized to valid values.
6640 (bidi_init_it): Don't initialize charpos and bytepos with invalid
6642 (bidi_level_of_next_char): Allow the sentinel "position" to pass
6643 the test for valid cached positions. Fix the logic for looking up
6644 the sentinel state in the cache. GCPRO the Lisp string we are
6646 (bidi_push_it, bidi_pop_it): New functions.
6647 (bidi_initialize): Initialize the bidi cache start stack pointer.
6648 (bidi_cache_ensure_space): New function, refactored from part of
6649 bidi_cache_iterator_state. Don't assume the required size is just
6650 one BIDI_CACHE_CHUNK away.
6651 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
6652 (bidi_count_bytes, bidi_char_at_pos): New functions.
6653 (bidi_cache_search): Don't assume bidi_cache_last_idx is
6654 always valid if bidi_cache_idx is valid.
6655 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
6656 is valid if it's going to be used.
6657 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
6658 (bidi_cache_fetch_state, bidi_cache_search)
6659 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6660 (bidi_cache_iterator_state, bidi_cache_find)
6661 (bidi_find_other_level_edge, bidi_cache_start_stack):
6662 All variables related to cache indices are now EMACS_INT.
6664 * dispextern.h (struct bidi_string_data): New structure.
6665 (struct bidi_it): New member `string'. Make flag members be 1-bit
6666 fields, and put them last in the struct.
6667 (compute_display_string_pos, compute_display_string_end):
6669 (bidi_push_it, bidi_pop_it): Add prototypes.
6670 (struct iterator_stack_entry): New members bidi_p,
6671 paragraph_embedding, and from_disp_prop_p.
6672 (struct it): Member bidi_p is now a bit field 1 bit wide.
6673 (bidi_shelve_cache, bidi_unshelve_cache):
6676 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
6677 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
6678 and vector-like objects.
6680 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
6681 cache around display iteration.
6683 * window.c (Fwindow_end, window_scroll_pixel_based)
6684 (displayed_window_lines, Frecenter): Save and restore the bidi
6685 cache around display iteration.
6687 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6689 * editfns.c (Fdelete_region): Clarify the use of the named
6690 parameters (bug#6788).
6692 2011-07-14 Martin Rudalics <rudalics@gmx.at>
6694 * indent.c (Fvertical_motion): Set and restore w->pointm when
6695 saving and restoring the window's buffer (Bug#9006).
6697 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
6699 * editfns.c (Fstring_to_char): Clarify just what is returned
6700 (bug#6576). Text by Eli Zaretskii.
6702 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
6704 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
6706 2011-07-13 Eli Zaretskii <eliz@gnu.org>
6708 * buffer.c (mmap_find): Fix a typo.
6710 2011-07-13 Johan Bockgård <bojohan@gnu.org>
6712 Fix execution of x selection hooks.
6713 * xselect.c (Qx_lost_selection_functions)
6714 (Qx_sent_selection_functions): New vars.
6715 (syms_of_xselect): DEFSYM them.
6716 (x_handle_selection_request): Pass Qx_sent_selection_functions
6717 rather than Vx_sent_selection_functions to Frun_hook_with_args.
6718 (x_handle_selection_clear,x_clear_frame_selections):
6719 Pass Qx_lost_selection_functions rather than
6720 Vx_lost_selection_functions to Frun_hook_with_args.
6722 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
6724 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
6725 The old code sometimes used this field without initializing it.
6727 * alloc.c (gc_sweep): Don't read past end of array.
6728 In theory, the old code could also have corrupted Emacs internals,
6729 though it'd be very unlikely.
6731 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
6733 * character.c (Fcharacterp): Don't advertise optional ignored
6734 argument. (Bug#4026)
6736 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
6738 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
6741 * window.c (Fset_window_start): Doc fix (bug#4199).
6742 (Fset_window_hscroll): Ditto.
6744 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
6746 Fix minor new problems caught by GCC 4.6.1.
6747 * term.c (init_tty): Remove unused local.
6748 * xsettings.c (store_monospaced_changed): Define this function only
6749 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
6752 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
6754 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
6756 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6758 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
6759 are the mini-buffer and the echo area (bug#3320).
6761 * term.c (init_tty): Remove support for supdup, c10 and perq
6762 terminals, which are no longer supported (bug#1482).
6764 2011-07-10 Johan Bockgård <bojohan@gnu.org>
6766 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
6768 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
6770 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
6771 for non-popups (Bug#3642).
6773 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
6775 * alloc.c (reset_malloc_hooks): Protoize.
6776 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
6777 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
6778 * cm.c (losecursor): Likewise.
6779 * data.c (fmod): Likewise.
6780 * dispnew.c (swap_glyphs_in_rows): Likewise.
6781 * emacs.c (memory_warning_signal): Likewise.
6782 * floatfns.c (float_error): Likewise.
6783 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
6784 (otf_open, font_otf_capability, generate_otf_features)
6785 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
6787 * image.c (pbm_read_file): Likewise.
6788 * indent.c (string_display_width): Likewise.
6789 * intervals.c (check_for_interval, search_for_interval)
6790 (inc_interval_count, count_intervals, root_interval)
6791 (adjust_intervals_for_insertion, make_new_interval): Likewise.
6792 * lread.c (defalias): Likewise.
6793 * ralloc.c (r_alloc_check): Likewise.
6794 * regex.c (set_image_of_range_1, set_image_of_range)
6795 (regex_grow_registers): Likewise.
6796 * sysdep.c (strerror): Likewise.
6797 * termcap.c (valid_filename_p, tprint, main): Likewise.
6798 * tparam.c (main): Likewise.
6799 * unexhp9k800.c (run_time_remap, save_data_space)
6800 (update_file_ptrs, read_header, write_header, calculate_checksum)
6801 (copy_file, copy_rest, display_header): Likewise.
6802 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
6804 * xdisp.c (check_it): Likewise.
6805 * xfaces.c (register_color, unregister_color, unregister_colors):
6807 * xfns.c (print_fontset_result): Likewise.
6808 * xrdb.c (member, fatal, main): Likewise.
6810 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
6812 Fix minor problems found by static checking (Bug#9031).
6813 * chartab.c (char_table_set_range, map_sub_char_table):
6814 Remove unused locals.
6815 (uniprop_table): Now static.
6816 * composite.c (_work_char): Remove unused static var.
6818 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
6820 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
6822 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
6824 * gtkutil.c (qttip_cb): Remove code without function.
6826 2011-07-09 Eli Zaretskii <eliz@gnu.org>
6828 * w32.c (pthread_sigmask): New stub.
6830 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
6832 Use pthread_sigmask, not sigprocmask (Bug#9010).
6833 sigprocmask is portable only for single-threaded applications, and
6834 Emacs can be multi-threaded when it uses GTK.
6835 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
6837 * callproc.c (Fcall_process):
6838 * process.c (create_process):
6839 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
6840 Use pthread_sigmask, not sigprocmask.
6842 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6844 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
6845 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
6848 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6850 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
6851 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
6852 (xg_hide_tooltip): Fix comment.
6854 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
6855 in registerServicesMenuSendTypes.
6856 (validRequestorForSendType): Don't check ns_return_types.
6858 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
6861 2011-07-08 Jason Rumney <jasonr@gnu.org>
6863 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
6864 SH_SHOW for hidden windows (Bug#5482).
6866 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
6867 frame struct members of non-existent frames (Bug#6284).
6869 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6871 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
6872 variable firstTime not needed on OSX >= 10.6.
6873 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
6874 >= 10.5. Use setKnobProportion, setDoubleValue.
6876 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
6877 (MAC_OS_X_VERSION_10_5): Define if not defined.
6878 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
6879 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
6880 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
6882 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
6883 cString and lossyCString on OSX >= 10.4
6885 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
6886 sizeToFit on OSX >= 10.2.
6888 * nsimage.m (allocInitFromFile): Don't use deprecated method
6889 bestRepresentationForDevice on OSX >= 10.6.
6891 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
6894 * emacs.c: Declare unexec_init_emacs_zone.
6896 * nsgui.h: Fix compiler warning about gnulib redefining verify.
6898 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
6900 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
6901 on svcsMenu (Bug#8842).
6903 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
6905 (Fns_list_services): Just return Qnil on 10.6, code not working there.
6907 * nsterm.m (QUTF8_STRING): Declare.
6908 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
6909 (validRequestorForSendType): Return type is (id).
6910 Change indexOfObjectIdenticalTo to indexOfObject.
6911 Check if we have local selection before returning self (Bug#8842).
6912 (writeSelectionToPasteboard): Put local selection into paste board
6913 if we have a local selection (Bug#8842).
6914 (syms_of_nsterm): DEFSYM QUTF8_STRING.
6916 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
6917 (ns_get_local_selection): Declare.
6919 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
6921 * keymap.c (describe_map_tree): Don't insert a double newline at
6922 the end of the buffer (bug#1169) and return whether we inserted
6925 * callint.c (Fcall_interactively): Change "reading args" to
6926 "providing args" to try to clarify what it does (bug#1010).
6928 2011-07-07 Kenichi Handa <handa@m17n.org>
6930 * composite.c (composition_compute_stop_pos): Ignore a static
6931 composition starting before CHARPOS (Bug#8915).
6933 * xdisp.c (handle_composition_prop): Likewise.
6935 2011-07-07 Eli Zaretskii <eliz@gnu.org>
6937 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
6940 2011-07-07 Kenichi Handa <handa@m17n.org>
6942 * character.h (unicode_category_t): New enum type.
6944 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
6945 (Qchar_code_property_table): New variable.
6946 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
6947 (UNIPROP_COMPRESSED_FORM_P): New macros.
6948 (char_table_ascii): Uncompress the compressed values.
6949 (sub_char_table_ref): New arg is_uniprop. Callers changed.
6950 Uncompress the compressed values.
6951 (sub_char_table_ref_and_range): Likewise.
6952 (char_table_ref_and_range): Uncompress the compressed values.
6953 (sub_char_table_set): New arg is_uniprop. Callers changed.
6954 Uncompress the compressed values.
6955 (sub_char_table_set_range): Args changed. Callers changed.
6956 (char_table_set_range): Adjuted for the above change.
6957 (map_sub_char_table): Delete args default_val and parent. Add arg
6958 top. Give decoded values to a Lisp function.
6959 (map_char_table): Adjust for the above change. Give decoded
6960 values to a Lisp function. Gcpro more variables.
6961 (uniprop_table_uncompress)
6962 (uniprop_decode_value_run_length): New functions.
6963 (uniprop_decoder, uniprop_decoder_count): New variables.
6964 (uniprop_get_decoder, uniprop_encode_value_character)
6965 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
6967 (uniprop_encoder, uniprop_encoder_count): New variables.
6968 (uniprop_get_encoder, uniprop_table)
6969 (Funicode_property_table_internal, Fget_unicode_property_internal)
6970 (Fput_unicode_property_internal): New functions.
6971 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
6972 Sunicode_property_table_internal, Sget_unicode_property_internal,
6973 and Sput_unicode_property_internal. Defvar_lisp
6974 char-code-property-alist.
6976 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
6977 Vunicode_category_table.
6979 * font.c (font_range): Adjust for the change of
6980 Vunicode_category_table.
6982 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
6984 * m/iris4d.h: Remove file, move contents ...
6985 * s/irix6-5.h: ... here.
6987 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
6989 Remove unportable assumption about struct layout (Bug#8884).
6990 * alloc.c (mark_buffer):
6991 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
6992 (clone_per_buffer_values): Don't assume that
6993 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
6994 This isn't true in general, and it's particularly not true
6995 if Emacs is configured with --with-wide-int.
6996 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
6997 New macros, used in the buffer.c change.
6999 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
7001 * xsettings.c: Use both GConf and GSettings if both are available.
7002 (store_config_changed_event): Add comment.
7003 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
7004 (store_tool_bar_style_changed): New functions.
7005 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
7006 (struct xsettings): Move font inside HAVE_XFT.
7007 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
7008 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
7009 Move inside HAVE_XFT.
7010 (something_changed_gsettingsCB): Rename from something_changedCB.
7011 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
7013 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
7014 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
7015 (something_changed_gconfCB): Rename from something_changedCB.
7016 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
7017 (parse_settings): Move check for font inside HAVE_XFT.
7018 (read_settings, apply_xft_settings): Add comment.
7019 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
7020 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
7021 call store_font_name_changed.
7022 (xft_settings_event): Add comment.
7023 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
7024 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
7025 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
7026 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
7027 (xsettings_initialize): Call init_gsettings last.
7028 (xsettings_get_system_font, xsettings_get_system_normal_font):
7031 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
7033 Random fixes. E.g., (random) never returned negative values.
7034 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
7035 subseconds part to the entropy, as that's a bit more random.
7036 Prefer signed to unsigned, since the signedness doesn't matter and
7037 in general we prefer signed. When given a limit, use a
7038 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
7039 latter isn't right if USE_2_TAGS_FOR_INTS.
7040 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
7041 not 0..VALMASK. Don't discard "excess" bits that random () returns.
7043 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
7045 * textprop.c (text_property_stickiness):
7046 Obey Vtext_property_default_nonsticky.
7047 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
7048 * w32fns.c (syms_of_w32fns):
7049 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
7051 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7053 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
7054 This is more efficient than Ffile_directory_p and avoids a minor race.
7056 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
7058 * buffer.c (Foverlay_put): Say what the return value is
7061 * fileio.c (barf_or_query_if_file_exists): Check first if the file
7062 is a directory before asking whether to use the file name
7064 (barf_or_query_if_file_exists): Make the "File is a directory"
7065 error be more correct.
7067 * fns.c (Frequire): Remove the mention of the .gz files, since
7068 that's installation-specific, but keep the mention of
7069 `get-load-suffixes'.
7071 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7073 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
7074 Report string overflow if the output is too long.
7076 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
7078 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
7079 (syms_of_gnutls): Remove duplicate DEFSYM for
7080 Qgnutls_bootprop_verify_hostname_error, an error for
7081 Qgnutls_bootprop_verify_error (which is no longer used).
7083 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
7084 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
7085 Also (re)move comments that are misplaced or no longer relevant.
7087 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7089 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
7091 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
7093 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
7094 and background color parameters if they have been changed.
7096 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7098 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
7100 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
7102 * xsettings.c (SYSTEM_FONT): Define only when used.
7103 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
7105 * keymap.c (access_keymap_1): Now static.
7107 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
7109 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
7110 leave any prefix arg for the up event (Bug#1586).
7112 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
7114 * lread.c (syms_of_lread): Mention single symbols defined by
7115 `defvar' or `defconst' (bug#7154).
7117 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7118 (Frequire): Mention get-load-suffixes.
7120 2011-07-02 Martin Rudalics <rudalics@gmx.at>
7122 * window.h (window): Remove clone_number slot.
7123 * window.c (Fwindow_clone_number, Fset_window_clone_number):
7125 (make_parent_window, make_window, saved_window)
7126 (Fset_window_configuration, save_window_save): Don't deal with
7128 * buffer.c (Qclone_number): Remove declaration.
7129 (sort_overlays, overlay_strings): Don't deal with clone numbers.
7131 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
7133 Add multiple inheritance to keymaps.
7134 * keymap.c (Fmake_composed_keymap): New function.
7135 (Fset_keymap_parent): Simplify.
7136 (fix_submap_inheritance): Remove.
7137 (access_keymap_1): New function extracted from access_keymap to handle
7138 embedded parents and handle lists of maps.
7139 (access_keymap): Use it.
7140 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
7141 (Fcopy_keymap): Handle embedded parents.
7142 (Fcommand_remapping, define_as_prefix): Simplify.
7143 (Fkey_binding): Simplify.
7144 (syms_of_keymap): Move minibuffer-local-completion-map,
7145 minibuffer-local-filename-completion-map,
7146 minibuffer-local-must-match-map, and
7147 minibuffer-local-filename-must-match-map to Elisp.
7148 (syms_of_keymap): Defsubr make-composed-keymap.
7149 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
7150 (parse_menu_item): Trivial simplification.
7152 2011-07-01 Glenn Morris <rgm@gnu.org>
7154 * Makefile.in (SETTINGS_LIBS): Fix typo.
7156 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
7158 * coding.c (Fencode_coding_string): Record the last coding system
7159 used, as the function doc string says (bug#8738).
7161 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
7163 * xsettings.c (store_monospaced_changed): Take new font as arg and
7164 check for change against current_mono_font.
7165 (EMACS_TYPE_SETTINGS): Remove this and related defines.
7166 (emacs_settings_constructor, emacs_settings_get_property)
7167 (emacs_settings_set_property, emacs_settings_class_init)
7168 (emacs_settings_init, gsettings_obj): Remove.
7169 (something_changedCB): New function for HAVE_GSETTINGS.
7170 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
7171 with value as argument.
7172 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
7173 g_settings_new (Bug#8967). Do not create gsettings_obj.
7174 Remove calls to g_settings_bind. Connect something_changedCB to
7177 * xgselect.c: Add defined (HAVE_GSETTINGS).
7178 (xgselect_initialize): Ditto.
7180 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
7181 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
7184 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
7186 * eval.c (struct backtrace): Simplify and port the data structure.
7187 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
7188 signed bit field, as this assumption is not portable and it makes
7189 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
7190 "char debug_on_exit : 1" as this is not portable either; instead,
7191 use the portable "unsigned int debug_on_exit : 1". Remove unused
7192 member evalargs. Remove obsolete comments about cc bombing out.
7194 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
7196 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
7197 Let HAVE_GSETTINGS override HAVE_GCONF.
7198 (store_monospaced_changed): New function.
7199 (EMACS_SETTINGS): A new type derived from GObject to handle
7200 GSettings notifications.
7201 (emacs_settings_constructor, emacs_settings_get_property)
7202 (emacs_settings_set_property, emacs_settings_class_init):
7204 (gsettings_client, gsettings_obj): New variables.
7205 (GSETTINGS_SCHEMA): New define.
7206 (something_changedCB): Call store_monospaced_changed.
7207 (init_gsettings): New function.
7208 (xsettings_initialize): Call init_gsettings.
7209 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
7212 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
7215 2011-06-29 Martin Rudalics <rudalics@gmx.at>
7217 * window.c (resize_root_window, grow_mini_window)
7218 (shrink_mini_window): Rename Qresize_root_window to
7219 Qwindow_resize_root_window and Qresize_root_window_vertically to
7220 Qwindow_resize_root_window_vertically.
7222 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
7224 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
7226 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
7228 * makefile.w32-in: Redesign dependencies so they reflect more
7229 clearly which files are directly included by each source file,
7230 and not through other includes.
7232 2011-06-27 Martin Rudalics <rudalics@gmx.at>
7234 * buffer.c (Qclone_number): Declare static and DEFSYM it.
7235 (sort_overlays, overlay_strings): When an overlay's clone number
7236 matches the window's clone number process the overlay even if
7237 the overlay's window property doesn't match the current window.
7239 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
7240 (Fwindow_hchild): Rename to Fwindow_left_child.
7241 (Fwindow_next): Rename to Fwindow_next_sibling.
7242 (Fwindow_prev): Rename to Fwindow_prev_sibling.
7243 (resize_window_check): Rename to window_resize_check.
7244 (resize_window_apply): Rename to window_resize_apply.
7245 (Fresize_window_apply): Rename to Fwindow_resize_apply.
7246 (Fdelete_other_windows_internal, resize_frame_windows)
7247 (Fsplit_window_internal, Fdelete_window_internal)
7248 (grow_mini_window, shrink_mini_window)
7249 (Fresize_mini_window_internal): Fix callers accordingly.
7251 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
7253 * emacsgtkfixed.h: State that this is only used with Gtk+3.
7254 (emacs_fixed_set_min_size): Remove.
7255 (emacs_fixed_new): Take frame as argument.
7257 * emacsgtkfixed.c: State that this is only used with Gtk+3.
7258 (_EmacsFixedPrivate): Remove minwidth/height.
7259 Add struct frame *f.
7260 (emacs_fixed_init): Initialize priv->f.
7261 (get_parent_class, emacs_fixed_set_min_size): Remove.
7262 (emacs_fixed_new): Set priv->f to argument.
7263 (emacs_fixed_get_preferred_width)
7264 (emacs_fixed_get_preferred_height): Use min_width/height from
7265 frames size_hint to set minimum and natural (Bug#8919).
7266 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
7267 and use min_width/height from frames size_hint to set
7268 min_width/height (Bug#8919).
7270 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
7271 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
7274 2011-06-26 Eli Zaretskii <eliz@gnu.org>
7276 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
7277 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
7280 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
7282 * process.c (wait_reading_process_output): Bypass select if
7283 waiting for a cell while ignoring keyboard input, and input is
7284 pending. Suggested by Jan Djärv (Bug#8869).
7286 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
7288 Use gnulib's dup2 module instead of rolling our own.
7289 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
7291 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7293 * dispnew.c (scrolling_window): Before scrolling, turn off a
7294 mouse-highlight in the window being scrolled.
7296 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
7298 Move DEFSYM to lisp.h and use everywhere.
7300 * character.h (DEFSYM): Move declaration...
7301 * lisp.h (DEFSYM): ...here.
7307 * w32select.c: Don't include character.h.
7309 * alloc.c (syms_of_alloc):
7310 * buffer.c (syms_of_buffer):
7311 * bytecode.c (syms_of_bytecode):
7312 * callint.c (syms_of_callint):
7313 * casefiddle.c (syms_of_casefiddle):
7314 * casetab.c (init_casetab_once):
7315 * category.c (init_category_once, syms_of_category):
7316 * ccl.c (syms_of_ccl):
7317 * cmds.c (syms_of_cmds):
7318 * composite.c (syms_of_composite):
7319 * dbusbind.c (syms_of_dbusbind):
7320 * dired.c (syms_of_dired):
7321 * dispnew.c (syms_of_display):
7322 * doc.c (syms_of_doc):
7323 * editfns.c (syms_of_editfns):
7324 * emacs.c (syms_of_emacs):
7325 * eval.c (syms_of_eval):
7326 * fileio.c (syms_of_fileio):
7327 * fns.c (syms_of_fns):
7328 * frame.c (syms_of_frame):
7329 * fringe.c (syms_of_fringe):
7330 * insdel.c (syms_of_insdel):
7331 * keymap.c (syms_of_keymap):
7332 * lread.c (init_obarray, syms_of_lread):
7333 * macros.c (syms_of_macros):
7334 * msdos.c (syms_of_msdos):
7335 * print.c (syms_of_print):
7336 * process.c (syms_of_process):
7337 * search.c (syms_of_search):
7338 * sound.c (syms_of_sound):
7339 * syntax.c (init_syntax_once, syms_of_syntax):
7340 * terminal.c (syms_of_terminal):
7341 * textprop.c (syms_of_textprop):
7342 * undo.c (syms_of_undo):
7343 * w32.c (globals_of_w32):
7344 * window.c (syms_of_window):
7345 * xdisp.c (syms_of_xdisp):
7346 * xfaces.c (syms_of_xfaces):
7347 * xfns.c (syms_of_xfns):
7348 * xmenu.c (syms_of_xmenu):
7349 * xsettings.c (syms_of_xsettings):
7350 * xterm.c (syms_of_xterm): Use DEFSYM.
7352 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
7354 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
7356 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
7358 Integer and buffer overflow fixes (Bug#8873).
7360 * print.c (printchar, strout): Check for string overflow.
7361 (PRINTPREPARE, printchar, strout):
7362 Don't set size unless allocation succeeds.
7364 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
7365 for sizes. Check for string overflow more accurately.
7366 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
7368 * macros.c: Integer and buffer overflow fixes.
7369 * keyboard.h (struct keyboard.kbd_macro_bufsize):
7370 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
7371 Use ptrdiff_t, not int, for sizes.
7372 Don't increment bufsize until after realloc succeeds.
7373 Check for size-calculation overflow.
7374 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
7376 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
7378 * lread.c: Integer overflow fixes.
7379 (read_integer): Radix is now EMACS_INT, not int,
7380 to improve quality of diagnostics for out-of-range radices.
7381 Calculate buffer size correctly for out-of-range radices.
7382 (read1): Check for integer overflow in radices, and in
7383 read-circle numbers.
7384 (read_escape): Avoid int overflow.
7385 (Fload, openp, read_buffer_size, read1)
7386 (substitute_object_recurse, read_vector, read_list, map_obarray):
7387 Use ptrdiff_t, not int, for sizes.
7388 (read1): Use EMACS_INT, not int, for sizes.
7389 Check for size overflow.
7391 * image.c (cache_image): Check for size arithmetic overflow.
7393 * lread.c: Integer overflow issues.
7394 (saved_doc_string_size, saved_doc_string_length)
7395 (prev_saved_doc_string_size, prev_saved_doc_string_length):
7396 Now ptrdiff_t, not int.
7397 (read1): Don't assume doc string length fits in int. Check for
7398 out-of-range doc string lengths.
7399 (read_list): Don't assume file position fits in int.
7400 (read_escape): Check for hex character overflow.
7402 2011-06-22 Leo Liu <sdl.web@gmail.com>
7404 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
7405 Move to minibuffer.el.
7407 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7409 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
7410 The following patches are for when GLYPH_DEBUG && !XASSERT.
7411 * dispextern.h (trace_redisplay_p, dump_glyph_string):
7412 * dispnew.c (flush_stdout):
7413 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
7414 Mark as externally visible.
7415 * dispnew.c (check_window_matrix_pointers): Now static.
7416 * dispnew.c (window_to_frame_vpos):
7417 * xfns.c (unwind_create_frame):
7418 * xterm.c (x_check_font): Remove unused local.
7419 * scroll.c (CHECK_BOUNDS):
7420 * xfaces.c (cache_fache): Rename local to avoid shadowing.
7421 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
7422 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
7423 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
7424 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
7426 (debug_method_add): Use va_list and vsprintf rather than relying
7427 on undefined behavior with wrong number of arguments.
7428 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
7429 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
7430 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
7431 since we're not interested in debugging glyphs with old libraries.
7432 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
7433 GCC 4.6.0's static checking.
7435 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7437 Integer overflow and signedness fixes (Bug#8873).
7438 A few related buffer overrun fixes, too.
7440 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
7442 * dispextern.h (struct face.stipple):
7443 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
7444 (x_bitmap_mask, x_allocate_bitmap_record)
7445 (x_create_bitmap_from_data, x_create_bitmap_from_file)
7446 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
7447 (x_create_bitmap_from_xpm_data):
7448 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
7449 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
7451 * xfaces.c (load_pixmap):
7452 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
7453 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
7454 (.bitmaps_last, struct x_output.icon_bitmap):
7455 Use ptrdiff_t, not int, for bitmap indexes.
7456 (x_allocate_bitmap_record): Check for size overflow.
7457 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
7459 Use ptrdiff_t, not int, for overlay counts.
7460 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
7461 * editfns.c (overlays_around, get_pos_property):
7462 * textprop.c (get_char_property_and_overlay):
7463 * xdisp.c (next_overlay_change, note_mouse_highlight):
7464 * xfaces.c (face_at_buffer_position):
7465 * buffer.c (OVERLAY_COUNT_MAX): New macro.
7466 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
7467 (Fnext_overlay_change, Fprevious_overlay_change)
7468 (mouse_face_overlay_overlaps, Foverlays_in):
7469 Use ptrdiff_t, not int, for sizes.
7470 (overlays_at, overlays_in): Check for size-calculation overflow.
7472 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
7474 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
7475 (x_session_initialize): Do not assume string length fits in int.
7477 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
7478 This is unlikely, but can occur if DPI is outlandish.
7480 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
7481 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
7483 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
7484 * xrdb.c (magic_file_p, search_magic_path):
7485 Omit last arg SUFFIX; it was always 0. All callers changed.
7486 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
7488 * xfont.c (xfont_match): Avoid need for strlen.
7490 * xfns.c: Don't assume strlen fits in int.
7491 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
7493 * xdisp.c (message_log_check_duplicate): Return intmax_t,
7494 not unsigned long, as we prefer signed integers. All callers changed.
7495 Detect integer overflow in repeat count.
7496 (message_dolog): Don't assume print length fits in 39 bytes.
7497 (display_mode_element): Don't assume strlen fits in int.
7499 * termcap.c: Don't assume sizes fit in int and never overflow.
7500 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
7501 (gobble_line): Check for size-calculation overflow.
7503 * minibuf.c (Fread_buffer):
7504 * lread.c (intern, intern_c_string):
7505 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
7506 Don't assume string length fits in int.
7508 * keyboard.c (parse_tool_bar_item):
7509 * gtkutil.c (style_changed_cb): Avoid need for strlen.
7511 * font.c: Don't assume string length fits in int.
7512 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
7513 Use ptrdiff_t, not int.
7514 (font_intern_prop): Don't assume string length fits in int.
7515 Don't assume integer property fits in fixnum.
7516 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
7518 * filelock.c: Fix some buffer overrun and integer overflow issues.
7519 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
7520 Reformulate so as not to need the command string.
7521 Invoke gzip -cd rather than gunzip, as it's more portable.
7522 (lock_info_type, lock_file_1, lock_file):
7523 Don't assume pid_t and time_t fit in unsigned long.
7524 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
7525 (current_lock_owner): Prefer signed type for sizes.
7526 Use memcpy, not strncpy, where memcpy is what is really wanted.
7527 Don't assume (via atoi) that time_t and pid_t fit in int.
7528 Check for time_t and/or pid_t out of range, e.g., via a network share.
7529 Don't alloca where an auto var works fine.
7531 * fileio.c: Fix some integer overflow issues.
7532 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
7533 Don't assume string length fits in int.
7534 (directory_file_name): Don't assume string length fits in long.
7535 (make_temp_name): Don't assume pid fits in int, or that its print
7536 length is less than 20.
7538 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
7540 * coding.c (make_subsidiaries): Don't assume string length fits in int.
7542 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
7544 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
7545 We prefer signed integers, even for size calculations.
7547 * emacs.c: Don't assume string length fits in 'int'.
7548 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
7549 (main): Don't invoke strlen when not needed.
7551 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
7552 (XD_DEBUG_MESSAGE): Don't waste a byte.
7554 * callproc.c (getenv_internal_1, getenv_internal)
7556 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
7558 * lread.c (invalid_syntax): Omit length argument.
7559 All uses changed. This doesn't fix a bug, but it simplifies the
7560 code away from its former Hollerith-constant appearance, and it's
7561 one less 'int' to worry about when looking at integer-overflow issues.
7562 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
7564 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
7565 This didn't break anything, but it didn't help either.
7566 It's confusing to put a bogus integer in a place where the actual
7567 value does not matter.
7568 (LIST_END_P): Remove unused macro and its bogus comment.
7569 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
7571 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
7572 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
7574 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
7575 We prefer signed types, and the value cannot exceed the EMACS_INT
7576 range anyway (because otherwise the length would not be representable).
7577 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
7578 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
7579 This avoids a GCC warning when WIDE_EMACS_INT.
7581 * indent.c (sane_tab_width): New function.
7582 (current_column, scan_for_column, Findent_to, position_indentation)
7583 (compute_motion): Use it. This is just for clarity.
7584 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
7586 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
7588 * lisp.h (lint_assume): New macro.
7589 * composite.c (composition_gstring_put_cache):
7590 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
7592 * editfns.c, insdel.c:
7593 Omit unnecessary forward decls, to simplify future changes.
7595 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
7597 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
7599 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
7600 Use much-faster test for byte-length change.
7601 Don't assume string byte-length fits in 'int'.
7602 Check that character arg fits in 'int'.
7603 (mapcar1): Declare byte as byte, for clarity.
7605 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
7607 * fns.c (concat): Catch string overflow earlier.
7608 Do not rely on integer wraparound.
7610 * dispextern.h (struct it.overlay_strings_charpos)
7611 (struct it.selective): Now EMACS_INT, not int.
7612 * xdisp.c (forward_to_next_line_start)
7613 (back_to_previous_visible_line_start)
7614 (reseat_at_next_visible_line_start, next_element_from_buffer):
7615 Don't arbitrarily truncate the value of 'selective' to int.
7617 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
7619 * composite.c: Don't truncate sizes to 'int'.
7620 (composition_gstring_p, composition_reseat_it)
7621 (composition_adjust_point): Use EMACS_INT, not int.
7622 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
7623 not EMACS_UINT, for indexes.
7625 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
7627 * buffer.c: Include <verify.h>.
7628 (struct sortvec.priority, struct sortstr.priority):
7629 Now EMACS_INT, not int.
7630 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
7631 (struct sortstr.size, record_overlay_string)
7632 (struct sortstrlist.size, struct sortlist.used):
7633 Don't truncate size to int.
7634 (record_overlay_string): Check for size-calculation overflow.
7635 (init_buffer_once): Check at compile-time, not run-time.
7637 2011-06-22 Jim Meyering <meyering@redhat.com>
7639 Don't leak an XBM-image-sized buffer
7640 * image.c (xbm_load): Free the image buffer after using it.
7642 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
7645 * composite.c (find_automatic_composition): Omit needless 'return 0;'
7646 that Sun C diagnosed.
7647 * fns.c (secure_hash): Fix pointer signedness issue.
7648 * intervals.c (static_offset_intervals): New function.
7649 (offset_intervals): Use it.
7651 2011-06-21 Leo Liu <sdl.web@gmail.com>
7654 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
7657 * fns.c (secure_hash): Rename from crypto_hash_function and change
7658 the first arg to accept symbols.
7659 (Fsecure_hash): New primitive.
7660 (syms_of_fns): New symbols.
7662 2011-06-20 Deniz Dogan <deniz@dogan.se>
7664 * process.c (Fset_process_buffer): Clarify return value in
7667 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
7669 * dispnew.c (add_window_display_history): Use BVAR.
7671 * xdisp.c (debug_method_add): Use BVAR.
7672 (check_window_end, dump_glyph_matrix, dump_glyph)
7673 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
7675 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
7678 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
7679 check till after the cache is created in init_frame_faces.
7681 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
7683 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
7685 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
7687 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
7688 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
7689 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
7691 Improve buffer-overflow checking (Bug#8873).
7692 * fileio.c (Finsert_file_contents):
7693 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
7694 Remove the old (too-loose) buffer overflow checks.
7695 They weren't needed, since make_gap checks for buffer overflow.
7696 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
7697 The old code merely checked for Emacs fixnum overflow, and relied
7698 on undefined (wraparound) behavior. The new code avoids undefined
7699 behavior, and also checks for ptrdiff_t and/or size_t overflow.
7701 * editfns.c (Finsert_char): Don't dump core with very negative counts.
7702 Tune. Don't use wider integers than needed. Don't use alloca.
7703 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
7705 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
7707 * insdel.c, lisp.h (buffer_overflow): New function.
7708 (insert_from_buffer_1, replace_range, replace_range_2):
7709 * insdel.c (make_gap_larger):
7710 * editfns.c (Finsert_char):
7711 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
7713 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
7715 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
7717 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
7719 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
7720 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
7722 * fileio.c: Don't assume EMACS_INT fits in off_t.
7723 (emacs_lseek): New static function.
7724 (Finsert_file_contents, Fwrite_region): Use it.
7725 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
7727 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
7729 * fns.c: Don't overflow int when computing a list length.
7730 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
7731 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
7732 truncation on 64-bit hosts. Check for QUIT every
7733 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
7734 faster and is responsive enough.
7735 (Flength): Report an error instead of overflowing an integer.
7736 (Fsafe_length): Return a float if the value is not representable
7737 as a fixnum. This shouldn't happen except in contrived situations.
7738 (Fnthcdr, Fsort): Don't assume list length fits in int.
7739 (Fcopy_sequence): Don't assume vector length fits in int.
7741 * alloc.c: Check that resized vectors' lengths fit in fixnums.
7742 (header_size, word_size): New constants.
7743 (allocate_vectorlike): Don't check size overflow here.
7744 (allocate_vector): Check it here instead, since this is the only
7745 caller of allocate_vectorlike that could cause overflow.
7746 Check that the new vector's length is representable as a fixnum.
7748 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
7749 The previous code was bogus. For example, next_almost_prime (32)
7750 returned 39, which is undesirable as it is a multiple of 3; and
7751 next_almost_prime (24) returned 25, which is a multiple of 5 so
7752 why was the code bothering to check for multiples of 7?
7754 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
7756 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
7758 Variadic C functions now count arguments with ptrdiff_t.
7759 This partly undoes my 2011-03-30 change, which replaced int with size_t.
7760 Back then I didn't know that the Emacs coding style prefers signed int.
7761 Also, in the meantime I found a few more instances where arguments
7762 were being counted with int, which may truncate counts on 64-bit
7763 machines, or EMACS_INT, which may be unnecessarily wide.
7764 * lisp.h (struct Lisp_Subr.function.aMANY)
7765 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
7766 Arg counts are now ptrdiff_t, not size_t.
7767 All variadic functions and their callers changed accordingly.
7768 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
7769 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
7770 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
7771 * callint.c (Fcall_interactively): Check arg count for overflow,
7772 to avoid potential buffer overrun. Use signed char, not 'int',
7773 for 'varies' array, so that we needn't bother to check its size
7774 calculation for overflow.
7775 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
7776 * eval.c (apply_lambda):
7777 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
7778 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
7779 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
7781 * callint.c (Fcall_interactively): Don't use index var as event count.
7783 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
7784 * mem-limits.h (SIZE): Remove; no longer used.
7786 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
7788 Remove unnecessary casts.
7789 * xterm.c (x_term_init):
7790 * xfns.c (x_set_border_pixel):
7791 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
7792 These aren't needed now that we assume ANSI C.
7794 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
7795 It's more likely to cause problems (due to unsigned overflow)
7798 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
7800 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
7802 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
7804 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
7806 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
7808 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
7810 GLYPH_CODE_FACE returns EMACS_INT, not int.
7811 * dispextern.h (merge_faces):
7812 * xfaces.c (merge_faces):
7813 * xdisp.c (get_next_display_element, next_element_from_display_vector):
7814 Don't assume EMACS_INT fits in int.
7816 * character.h (CHAR_VALID_P): Remove unused parameter.
7817 * fontset.c, lisp.h, xdisp.c: All uses changed.
7819 * editfns.c (Ftranslate_region_internal): Omit redundant test.
7821 * fns.c (concat): Minor tuning based on overflow analysis.
7822 This doesn't fix any bugs. Use int to hold character, instead
7823 of constantly refetching from Emacs object. Use XFASTINT, not
7824 XINT, for value known to be a character. Don't bother comparing
7825 a single byte to 0400, as it's always less.
7827 * floatfns.c (Fexpt):
7828 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
7830 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
7833 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
7835 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
7836 Without this fix, on a 64-bit host (aset S 0 4294967386) would
7837 incorrectly succeed when S was a string, because 4294967386 was
7838 truncated before it was used.
7840 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
7841 Otherwise, an out-of-range integer could cause undefined behavior
7844 * composite.c: Use int, not EMACS_INT, for characters.
7845 (fill_gstring_body, composition_compute_stop_pos): Use int, not
7846 EMACS_INT, for values that are known to be in character range.
7847 This doesn't fix any bugs but is the usual style inside Emacs and
7848 may generate better code on 32-bit machines.
7850 Make sure a 64-bit char is never passed to ENCODE_CHAR.
7851 This is for reasons similar to the recent CHAR_STRING fix.
7852 * charset.c (Fencode_char): Check that character arg is actually
7853 a character. Pass an int to ENCODE_CHAR.
7854 * charset.h (ENCODE_CHAR): Verify that the character argument is no
7855 wider than 'int', as a compile-time check to prevent future regressions
7858 * character.c (char_string): Remove unnecessary casts.
7860 Make sure a 64-bit char is never passed to CHAR_STRING.
7861 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
7862 by silently ignoring the top 32 bits, allowing some values
7863 that were far too large to be valid characters.
7864 * character.h: Include <verify.h>.
7865 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
7866 arguments are no wider than unsigned, as a compile-time check
7867 to prevent future regressions in this area.
7869 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
7870 (Fsubst_char_in_region):
7872 * xdisp.c (decode_mode_spec_coding):
7873 Adjust to CHAR_STRING's new requirement.
7874 * editfns.c (Finsert_char, Fsubst_char_in_region):
7875 * fns.c (concat): Check that character args are actually
7876 characters. Without this test, these functions did the wrong
7877 thing with wildly out-of-range values on 64-bit hosts.
7879 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
7880 These casts should not be needed on 32-bit hosts, either.
7881 * keyboard.c (read_char):
7882 * lread.c (Fload): Remove casts to unsigned.
7884 * lisp.h (UNSIGNED_CMP): New macro.
7885 This fixes comparison bugs on 64-bit hosts.
7886 (ASCII_CHAR_P): Use it.
7887 * casefiddle.c (casify_object):
7888 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
7889 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
7890 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
7891 * dispextern.h (FACE_FROM_ID):
7892 * keyboard.c (read_char): Use UNSIGNED_CMP.
7894 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
7895 not to EMACS_INT, to avoid GCC warning.
7897 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
7899 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
7900 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
7901 isn't needed on 32-bit machines.
7903 * buffer.c (Fgenerate_new_buffer_name):
7904 Use EMACS_INT for count, not int.
7905 (advance_to_char_boundary): Return EMACS_INT, not int.
7907 * data.c (Qcompiled_function): Now static.
7909 * window.c (window_body_lines): Now static.
7911 * image.c (gif_load): Rename local to avoid shadowing.
7913 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
7914 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
7915 * alloc.c (make_save_value): Integer argument is now of type
7917 (mark_object): Use ptrdiff_t, not int.
7918 * lisp.h (pD): New macro.
7919 * print.c (print_object): Use it.
7921 * alloc.c: Use EMACS_INT, not int, to count objects.
7922 (total_conses, total_markers, total_symbols, total_vector_size)
7923 (total_free_conses, total_free_markers, total_free_symbols)
7924 (total_free_floats, total_floats, total_free_intervals)
7925 (total_intervals, total_strings, total_free_strings):
7926 Now EMACS_INT, not int. All uses changed.
7927 (Fgarbage_collect): Compute overall total using a double, so that
7928 integer overflow is less likely to be a problem. Check for overflow
7929 when converting back to an integer.
7930 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
7931 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
7932 These were 'int' variables that could overflow on 64-bit hosts;
7933 they were never used, so remove them instead of repairing them.
7934 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
7935 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
7936 Previously, this ceilinged at INT_MAX, but that doesn't work on
7938 (allocate_pseudovector): Don't use EMACS_INT when int would do.
7940 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
7941 (allocate_vectorlike): Check for ptrdiff_t overflow.
7942 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
7943 when a (possibly-narrower) signed value would do just as well.
7944 We prefer using signed arithmetic, to avoid comparison confusion.
7946 * alloc.c: Catch some string size overflows that we were missing.
7947 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
7948 for convenience in STRING_BYTES_MAX.
7949 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
7950 The definition here is exact; the one in lisp.h was approximate.
7951 (allocate_string_data): Check for string overflow. This catches
7952 some instances we weren't catching before. Also, it catches
7953 size_t overflow on (unusual) hosts where SIZE_MAX <= min
7954 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
7955 and ptrdiff_t and EMACS_INT are both 64 bits.
7957 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
7958 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
7959 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
7961 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
7963 * alloc.c (Fmake_string): Check for out-of-range init.
7965 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
7967 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
7969 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
7971 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
7972 xg_get_default_scrollbar_width.
7974 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
7975 (int_gtk_range_get_value): Move to the scroll bar part of the file.
7976 (style_changed_cb): Call update_theme_scrollbar_width and call
7977 x_set_scroll_bar_default_width and xg_frame_set_char_size for
7978 all frames (Bug#8505).
7979 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
7980 Call gtk_window_set_resizable if HAVE_GTK3.
7981 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
7982 and height if HAVE_GTK3 (Bug#8505).
7983 (scroll_bar_width_for_theme): New variable.
7984 (update_theme_scrollbar_width): New function.
7985 (xg_get_default_scrollbar_width): Move code to
7986 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
7987 (xg_initialize): Call update_theme_scrollbar_width.
7989 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
7991 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
7993 2011-06-12 Martin Rudalics <rudalics@gmx.at>
7995 * frame.c (make_frame): Call other_buffer_safely instead of
7998 * window.c (temp_output_buffer_show): Call display_buffer with
7999 second argument Vtemp_buffer_show_specifiers and reset latter
8000 immediately after the call.
8001 (Vtemp_buffer_show_specifiers): New variable.
8002 (auto_window_vscroll_p, next_screen_context_lines)
8003 (Vscroll_preserve_screen_position): Remove leading asterisks from
8006 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
8008 Fix minor problems found by GCC 4.6.0 static checking.
8009 * buffer.c (Qclone_number): Remove for now, as it's unused.
8010 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
8011 (record_buffer): Remove unused local.
8012 * frame.c (other_visible_frames, frame_buffer_list): Now static.
8013 (set_frame_buffer_list): Remove; unused.
8014 * frame.h (other_visible_frames): Remove decl.
8015 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
8016 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
8017 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
8019 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
8020 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
8021 Define only if HAVE_GPM.
8022 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
8023 (update_hints_inhibit): Remove; never set. All uses removed.
8024 * widgetprv.h (emacsFrameClassRec): Remove decl.
8025 * window.c (delete_deletable_window): Now returns void, since it
8026 wasn't returning anything.
8027 (compare_window_configurations): Remove unused locals.
8028 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
8029 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
8030 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
8031 the same widths as pointers. This follows up on the 2011-05-06 patch.
8032 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
8033 * xterm.h: Likewise.
8034 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
8036 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
8038 * makefile.w32-in: Update dependencies.
8039 (LISP_H): Add lib/intprops.h.
8041 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
8043 * image.c (gif_load): Add animation frame delay to the metadata.
8044 (syms_of_image): Use DEFSYM. New symbol `delay'.
8046 2011-06-11 Martin Rudalics <rudalics@gmx.at>
8048 * window.c (delete_deletable_window): Re-add.
8049 (Fset_window_configuration): Rewrite to handle dead buffers and
8050 consequently deletable windows.
8051 (window_tree, Fwindow_tree): Remove. Supply functionality in
8053 (compare_window_configurations): Simplify code.
8055 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
8057 * image.c (imagemagick_load_image): Fix type mismatch.
8058 (Fimagemagick_types): Likewise.
8060 * window.h (replace_buffer_in_windows): Declare.
8062 2011-06-11 Martin Rudalics <rudalics@gmx.at>
8064 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
8065 Qclone_number. Remove external declaration of Qdelete_window.
8066 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
8068 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
8069 Run Qbuffer_list_update_hook if allowed.
8070 (Fother_buffer): Rewrite doc-string. Major rewrite for new
8071 buffer list implementation.
8072 (other_buffer_safely): New function.
8073 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
8074 calls to replace_buffer_in_windows and
8075 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
8077 (record_buffer): Inhibit quitting and rewrite using quittable
8078 functions. Run Qbuffer_list_update_hook if allowed.
8079 (Frecord_buffer, Funrecord_buffer): New functions.
8080 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
8081 Move switch-to-buffer to window.el.
8082 (bury-buffer): Move to window.el.
8083 (Vbuffer_list_update_hook): New variable.
8085 * lisp.h (other_buffer_safely): Add prototype in buffer.c
8088 * window.h (resize_frame_windows): Move up in code.
8089 (Fwindow_frame): Remove EXFUN.
8090 (replace_buffer_in_all_windows): Remove prototype.
8091 (replace_buffer_in_windows_safely): Add prototype.
8093 * window.c: Declare Qdelete_window static again. Move down
8094 declaration of select_count.
8095 (Fnext_window, Fprevious_window): Rewrite doc-strings.
8096 (Fother_window): Move to window.el.
8097 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
8098 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
8099 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
8101 (replace_buffer_in_windows): Implement by calling
8102 Qreplace_buffer_in_windows.
8103 (replace_buffer_in_all_windows): Remove with some functionality
8104 moved into replace_buffer_in_windows_safely.
8105 (replace_buffer_in_windows_safely): New function.
8106 (select_window_norecord, select_frame_norecord): Move in front
8107 of run_window_configuration_change_hook. Remove now obsolete
8109 (Fset_window_buffer): Rewrite doc-string.
8110 Call Qrecord_window_buffer.
8111 (keys_of_window): Move binding for other-window to window.el.
8113 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
8115 * dispextern.h (struct image): Replace data member, whose int_val
8116 and ptr_val fields were not used by anything, with a single
8119 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
8120 (gif_clear_image, gif_load, imagemagick_load_image)
8121 (gs_clear_image, gs_load): Callers changed.
8123 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
8125 * buffer.h: Include <time.h>, for time_t.
8126 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
8128 Fix minor problems found by static checking.
8130 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
8132 Make identifiers static if they are not used in other modules.
8133 * data.c (Qcompiled_function, Qframe, Qvector):
8134 * image.c (QimageMagick, Qsvg):
8135 * minibuf.c (Qmetadata):
8136 * window.c (resize_window_check, resize_root_window): Now static.
8137 * window.h (resize_window_check, resize_root_window): Remove decls.
8139 * window.c (window_deletion_count, delete_deletable_window):
8141 (window_body_lines): Now static.
8142 (Fdelete_other_windows_internal): Mark vars as initialized.
8143 Make sure 'resize_failed' is initialized.
8144 (run_window_configuration_change_hook): Rename local to avoid shadowing.
8145 (resize_window_apply): Remove unused local.
8146 * window.h (delete_deletable_window): Remove decl.
8148 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
8149 (imagemagick_load_image): Fix pointer signedness problem by changing
8150 last arg from unsigned char * to char *. All uses changed.
8151 Also, fix a local for similar reasons.
8152 Remove unused locals. Remove locals to avoid shadowing.
8153 (fn_rsvg_handle_free): Remove; unused.
8154 (svg_load, svg_load_image): Fix pointer signedness problem.
8155 (imagemagick_load_image): Don't use garbage pointer image_wand.
8157 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
8159 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
8161 * image.c (gif_load): Fix omitted cast error introduced by
8164 2011-06-10 Martin Rudalics <rudalics@gmx.at>
8166 * window.h (resize_proportionally, orig_total_lines)
8167 (orig_top_line): Remove from window structure.
8168 (set_window_height, set_window_width, change_window_heights)
8169 (Fdelete_window): Remove prototypes.
8170 (resize_frame_windows): Remove duplicate declaration.
8172 2011-06-10 Eli Zaretskii <eliz@gnu.org>
8174 * window.h (resize_frame_windows, resize_window_check)
8175 (delete_deletable_window, resize_root_window)
8176 (resize_frame_windows): Declare prototypes.
8178 * window.c (resize_window_apply): Make definition be "static" to
8179 match the prototype.
8181 2011-06-10 Martin Rudalics <rudalics@gmx.at>
8183 * window.c: Remove declarations of Qwindow_size_fixed,
8184 window_min_size_1, window_min_size_2, window_min_size,
8185 size_window, window_fixed_size_p, enlarge_window, delete_window.
8186 Remove static from declaration of Qdelete_window, it's
8187 temporarily needed by Fbury_buffer.
8188 (replace_window): Don't assign orig_top_line and
8190 (Fdelete_window, delete_window): Remove. Window deletion is
8191 handled by window.el.
8192 (window_loop): Remove DELETE_OTHER_WINDOWS case.
8193 Replace Fdelete_window calls with calls to Qdelete_window.
8194 (Fdelete_other_windows): Remove. Deleting other windows is
8195 handled by window.el.
8196 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
8197 handled in window.el.
8198 (window_min_size_2, window_min_size_1, window_min_size): Remove.
8199 Window minimum sizes are handled in window.el.
8200 (shrink_windows, size_window, set_window_height)
8201 (set_window_width, change_window_heights, window_height)
8202 (window_width, CURBEG, CURSIZE, enlarge_window)
8203 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
8204 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
8205 handled in window.el.
8206 (make_dummy_parent): Rename to make_parent_window and give it a
8207 second argument horflag.
8208 (make_window): Don't set resize_proportionally any more.
8209 (Fsplit_window): Remove. Windows are split in window.el.
8210 (save_restore_action, save_restore_orig_size)
8211 (shrink_window_lowest_first, save_restore_orig_size): Remove.
8212 Resize mini windows in window.el.
8213 (grow_mini_window, shrink_mini_window): Implement by calling
8214 Qresize_root_window_vertically, resize_window_check and
8215 resize_window_apply.
8216 (saved_window, Fset_window_configuration, save_window_save):
8217 Do not handle orig_top_line, orig_total_lines, and
8218 resize_proportionally.
8219 (window_min_height, window_min_width): Move to window.el.
8220 (keys_of_window): Move bindings for delete-other-windows,
8221 split-window, delete-window and enlarge-window to window.el.
8223 * buffer.c: Temporarily extern Qdelete_window.
8224 (Fbury_buffer): Temporarily call Qdelete_window instead of
8225 Fdelete_window (Fbury_buffer will move to window.el soon).
8227 * frame.c (set_menu_bar_lines_1): Remove code handling
8228 orig_top_line and orig_total_lines.
8230 * dispnew.c (adjust_frame_glyphs_initially): Don't use
8231 set_window_height but set heights directly.
8232 (change_frame_size_1): Use resize_frame_windows.
8234 * xdisp.c (init_xdisp): Don't use set_window_height but set
8237 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
8238 Use resize_frame_windows instead of change_window_heights and run
8239 run_window_configuration_change_hook.
8241 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
8242 instead of change_window_heights and run
8243 run_window_configuration_change_hook.
8245 2011-06-09 Martin Rudalics <rudalics@gmx.at>
8247 * window.c (replace_window): Rename second argument REPLACEMENT to
8248 NEW. New third argument SETFLAG. Rewrite.
8249 (delete_window, make_dummy_parent): Call replace_window with
8251 (window_list_1): Move down in code.
8252 (run_window_configuration_change_hook): Move set_buffer part
8253 before select_frame_norecord part in order to unwind correctly.
8254 Rename count1 to count.
8255 (recombine_windows, delete_deletable_window, resize_root_window)
8256 (Fdelete_other_windows_internal)
8257 (Frun_window_configuration_change_hook, make_parent_window)
8258 (resize_window_check, resize_window_apply, Fresize_window_apply)
8259 (resize_frame_windows, Fsplit_window_internal)
8260 (Fdelete_window_internal, Fresize_mini_window_internal):
8262 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
8264 2011-06-08 Martin Rudalics <rudalics@gmx.at>
8266 * window.h (window): Add some new members to window structure -
8267 normal_lines, normal_cols, new_total, new_normal, clone_number,
8268 splits, nest, prev_buffers, next_buffers.
8269 (WINDOW_TOTAL_SIZE): Move here from window.c.
8270 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
8272 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
8274 (make_dummy_parent): Set new members of windows structure.
8275 (make_window): Move down in code. Handle new members of window
8277 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
8278 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
8279 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
8280 (Fset_window_prev_buffers, Fwindow_next_buffers)
8281 (Fset_window_next_buffers, Fset_window_clone_number):
8283 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
8284 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
8286 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
8287 Argument WINDOW can be now internal window too.
8288 (Fwindow_use_time): Move up in code.
8289 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
8291 (Fset_window_configuration, saved_window)
8292 (Fcurrent_window_configuration, save_window_save): Handle new
8293 members of window structure.
8294 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
8295 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
8296 (syms_of_window): New Lisp objects Qrecord_window_buffer,
8297 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
8298 Qget_mru_window, Qresize_root_window,
8299 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
8300 Qauto_buffer_name; staticpro them.
8302 2011-06-07 Martin Rudalics <rudalics@gmx.at>
8304 * window.c (Fwindow_total_size, Fwindow_left_column)
8305 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
8306 (Fwindow_list_1): New functions.
8307 (window_box_text_cols): Replace with window_body_cols.
8308 (Fwindow_width, Fscroll_left, Fscroll_right):
8309 Use window_body_cols instead of window_box_text_cols.
8310 (delete_window, Fset_window_configuration):
8311 Call delete_all_subwindows with window as argument.
8312 (delete_all_subwindows): Take a window as argument and not a
8314 (window_loop): Remove handling of GET_LRU_WINDOW and
8316 (Fget_lru_window, Fget_largest_window): Move to window.el.
8318 * window.h: Extern window_body_cols instead of
8319 window_box_text_cols. delete_all_subwindows now takes a
8320 Lisp_Object as argument.
8322 * indent.c (compute_motion, Fcompute_motion):
8323 Use window_body_cols instead of window_box_text_cols.
8325 * frame.c (delete_frame): Call delete_all_subwindows with root
8328 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
8330 * fns.c (Fputhash): Document return value.
8332 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
8334 * image.c (gif_load): Implement gif89a spec "no disposal" method.
8336 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8338 Cons<->int and similar integer overflow fixes (Bug#8794).
8340 Check for overflow when converting integer to cons and back.
8341 * charset.c (Fdefine_charset_internal, Fdecode_char):
8342 Use cons_to_unsigned to catch overflow.
8343 (Fencode_char): Use INTEGER_TO_CONS.
8344 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
8345 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
8346 * data.c (long_to_cons, cons_to_long): Remove.
8347 (cons_to_unsigned, cons_to_signed): New functions.
8348 These signal an error for invalid or out-of-range values.
8349 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
8350 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
8351 * font.c (Ffont_variation_glyphs):
8352 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
8353 * lisp.h: Include <intprops.h>.
8354 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
8355 (cons_to_signed, cons_to_unsigned): New decls.
8356 (long_to_cons, cons_to_long): Remove decls.
8357 * undo.c (record_first_change): Use INTEGER_TO_CONS.
8358 (Fprimitive_undo): Use CONS_TO_INTEGER.
8359 * xfns.c (Fx_window_property): Likewise.
8360 * xselect.c: Include <limits.h>.
8361 (x_own_selection, selection_data_to_lisp_data):
8362 Use INTEGER_TO_CONS.
8363 (x_handle_selection_request, x_handle_selection_clear)
8364 (x_get_foreign_selection, Fx_disown_selection_internal)
8365 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
8366 (lisp_data_to_selection_data): Use cons_to_unsigned.
8367 (x_fill_property_data): Use cons_to_signed.
8368 Report values out of range.
8370 Check for buffer and string overflow more precisely.
8371 * buffer.h (BUF_BYTES_MAX): New macro.
8372 * lisp.h (STRING_BYTES_MAX): New macro.
8373 * alloc.c (Fmake_string):
8374 * character.c (string_escape_byte8):
8375 * coding.c (coding_alloc_by_realloc):
8376 * doprnt.c (doprnt):
8377 * editfns.c (Fformat):
8379 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
8380 since they may not be the same number.
8381 * editfns.c (Finsert_char):
8382 * fileio.c (Finsert_file_contents):
8383 Likewise for BUF_BYTES_MAX.
8385 * image.c: Use ptrdiff_t, not int, for sizes.
8386 (slurp_file): Switch from int to ptrdiff_t.
8388 (slurp_file): Check that file size fits in both size_t (for
8389 malloc) and ptrdiff_t (for sanity and safety).
8391 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
8392 if b->modtime has its maximal value.
8394 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
8396 Don't assume time_t can fit into int.
8397 * buffer.h (struct buffer.modtime): Now time_t, not int.
8398 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
8399 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
8401 Minor fixes for signed vs unsigned integers.
8402 * character.h (MAYBE_UNIFY_CHAR):
8403 * charset.c (maybe_unify_char):
8404 * keyboard.c (read_char, reorder_modifiers):
8405 XINT -> XFASTINT, since the integer must be nonnegative.
8406 * ftfont.c (ftfont_spec_pattern):
8407 * keymap.c (access_keymap, silly_event_symbol_error):
8408 XUINT -> XFASTINT, since the integer must be nonnegative.
8409 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
8410 since it makes no difference and we prefer signed.
8411 * keyboard.c (record_char): Use XUINT when all the neighbors do.
8412 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
8415 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
8417 * window.h (Fwindow_frame): Declare.
8419 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8421 * alloc.c: Simplify handling of large-request failures (Bug#8800).
8422 (SPARE_MEMORY): Always define.
8423 (LARGE_REQUEST): Remove.
8424 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
8426 2011-06-06 Martin Rudalics <rudalics@gmx.at>
8428 * lisp.h: Move EXFUNS for Fframe_root_window,
8429 Fframe_first_window and Fset_frame_selected_window to window.h.
8431 * window.h: Move EXFUNS for Fframe_root_window,
8432 Fframe_first_window and Fset_frame_selected_window here from
8435 * frame.c (Fwindow_frame, Fframe_first_window)
8436 (Fframe_root_window, Fframe_selected_window)
8437 (Fset_frame_selected_window): Move to window.c.
8438 (Factive_minibuffer_window): Move to minibuf.c.
8439 (Fother_visible_frames_p): New function.
8441 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
8443 * window.c (decode_window, decode_any_window): Move up in code.
8444 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
8445 (inhibit_frame_unsplittable): Remove unused variable.
8446 (Fwindow_buffer): Move up and rewrite doc-string.
8447 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
8448 (Fwindow_prev): New functions.
8449 (Fwindow_frame): Move here from frame.c. Accept any window as
8451 (Fframe_root_window, Fframe_first_window)
8452 (Fframe_selected_window): Move here from frame.c. Accept frame
8453 or arbitrary window as argument. Update doc-strings.
8454 (Fminibuffer_window): Move up in code.
8455 (Fwindow_minibuffer_p): Move up in code and simplify.
8456 (Fset_frame_selected_window): Move here from frame.c.
8458 (Fselected_window, select_window, Fselect_window): Move up in
8459 code. Minor doc-string fixes.
8461 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8463 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
8464 Do not assume that spare memory exists; that assumption is valid
8465 only if SYSTEM_MALLOC.
8466 (LARGE_REQUEST): New macro, so that the issue of large requests
8467 is separated from the issue of spare memory.
8469 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
8471 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
8474 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
8476 * xfns.c (x_set_scroll_bar_default_width): Move declarations
8479 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
8481 * gtkutil.c (xg_get_default_scrollbar_width): New function.
8483 * gtkutil.h: Declare xg_get_default_scrollbar_width.
8485 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
8486 min width by calling x_set_scroll_bar_default_width (Bug#8505).
8488 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
8490 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
8492 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
8494 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
8495 (x_clipboard_manager_save): Add return value.
8496 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
8498 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
8499 Obey Vx_select_enable_clipboard_manager. Catch errors in
8500 x_clipboard_manager_save (Bug#8779).
8501 (Vx_select_enable_clipboard_manager): New variable.
8502 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
8504 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8506 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
8508 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8510 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
8511 in the current matrix if keep_current_p is non-zero.
8513 2011-06-04 Eli Zaretskii <eliz@gnu.org>
8515 * bidi.c (bidi_level_of_next_char): Fix last change.
8517 2011-06-03 Eli Zaretskii <eliz@gnu.org>
8519 Support bidi reordering of text covered by display properties.
8521 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
8522 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
8523 (bidi_cache_search, bidi_cache_iterator_state)
8524 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
8525 (bidi_level_of_next_char, bidi_move_to_visually_next):
8526 Support character positions inside a run of characters covered by a
8528 (bidi_paragraph_init, bidi_resolve_explicit_1)
8529 (bidi_level_of_next_char): Call bidi_fetch_char and
8530 bidi_fetch_char_advance instead of FETCH_CHAR and
8532 (bidi_init_it): Initialize new members.
8533 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
8535 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
8536 instead of using explicit *_CHAR codes.
8537 (bidi_resolve_explicit, bidi_resolve_weak):
8538 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
8539 bidirectional text is supported only in multibyte buffers.
8540 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
8541 it to initialize the frame_window_p member of struct bidi_it.
8542 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
8543 (bidi_resolve_explicit, bidi_resolve_weak)
8544 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
8545 bidi_it->nchars is non-positive.
8546 (bidi_level_of_next_char): Don't try to lookup the cache for the
8547 next/previous character if nothing is cached there yet, or if we
8548 were just reseat()'ed to a new position.
8550 * xdisp.c (set_cursor_from_row): Set start and stop points
8551 according to the row's direction when priming the loop that looks
8552 for the glyph on which to display cursor.
8553 (single_display_spec_intangible_p): Function deleted.
8554 (display_prop_intangible_p): Reimplement to call
8555 handle_display_spec instead of single_display_spec_intangible_p.
8556 Accept 3 additional arguments needed by handle_display_spec.
8557 This fixes incorrect cursor motion across display property with complex
8558 values: lists, `(when COND...)' forms, etc.
8559 (single_display_spec_string_p): Support property values that are
8560 lists with the argument STRING its top-level element.
8561 (display_prop_string_p): Fix the condition for processing a
8562 property that is a list to be consistent with handle_display_spec.
8563 (handle_display_spec): New function, refactored from the
8564 last portion of handle_display_prop.
8565 (compute_display_string_pos): Accept additional argument
8566 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
8567 value of a `display' property is a "replacing spec".
8568 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
8569 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
8570 the display property, but just return a value indicating whether
8571 the display property will replace the characters it covers.
8572 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
8573 frame_window_p members of struct bidi_it.
8574 (compute_display_string_pos, compute_display_string_end):
8576 (push_it): Accept second argument POSITION, where pop_it should
8577 jump to continue iteration.
8578 (reseat_1): Initialize bidi_it.disp_pos.
8580 * keyboard.c (adjust_point_for_property): Adjust the call to
8581 display_prop_intangible_p to its new signature.
8583 * dispextern.h (struct bidi_it): New member frame_window_p.
8584 (bidi_init_it): Update prototypes.
8585 (display_prop_intangible_p): Update prototype.
8586 (compute_display_string_pos, compute_display_string_end):
8588 (struct bidi_it): New members nchars and disp_pos. ch_len is now
8591 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
8593 Malloc failure behavior now depends on size of allocation.
8594 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
8595 * lisp.h: Change signatures accordingly.
8596 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
8597 All callers changed. (Bug#8762)
8599 * gnutls.c: Use Emacs's memory allocators.
8600 Without this change, the gnutls library would invoke malloc etc.
8601 directly, which causes problems on non-SYNC_INPUT hosts, and which
8602 runs afoul of improving memory_full behavior. (Bug#8761)
8603 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
8604 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
8605 xfree instead of the default malloc, realloc, free.
8606 (Fgnutls_boot): No need to check for memory allocation failure,
8607 since xmalloc does that for us.
8609 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
8610 * category.c (hash_get_category_set):
8611 * ccl.c (ccl_driver):
8612 * charset.c (Fdefine_charset_internal):
8613 * charset.h (struct charset.hash_index):
8614 * composite.c (get_composition_id, gstring_lookup_cache)
8615 (composition_gstring_put_cache):
8616 * composite.h (struct composition.hash_index):
8617 * dispextern.h (struct image.hash):
8618 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
8619 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
8620 (hashfn_equal, hashfn_user_defined, make_hash_table)
8621 (maybe_resize_hash_table, hash_lookup, hash_put)
8622 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
8623 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
8624 (Fsxhash, Fgethash, Fputhash, Fmaphash):
8625 * image.c (make_image, search_image_cache, lookup_image)
8626 (xpm_put_color_table_h):
8627 * lisp.h (struct Lisp_Hash_Table):
8628 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
8629 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
8630 for hashes and hash indexes, instead of 'unsigned' and 'int'.
8631 * alloc.c (allocate_vectorlike):
8632 Check for overflow in vector size calculations.
8633 * ccl.c (ccl_driver):
8634 Check for overflow when converting EMACS_INT to int.
8635 * fns.c, image.c: Remove unnecessary static decls that would otherwise
8636 need to be updated by these changes.
8637 * fns.c (make_hash_table, maybe_resize_hash_table):
8638 Check for integer overflow with large hash tables.
8639 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
8640 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
8641 (SXHASH_REDUCE): New macro.
8642 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
8643 Use it instead of discarding useful hash info with large hash values.
8644 (sxhash_float): New function.
8645 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
8646 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
8647 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
8648 Rewrite to use FIXNUM_BITS, as this simplifies things.
8649 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
8650 Adjust signatures to match updated version of code.
8651 (consing_since_gc): Now EMACS_INT, since a single hash table can
8652 use more than INT_MAX bytes.
8654 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
8656 Make it possible to build with GCC-4.6+ -O2 -flto.
8658 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
8660 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
8662 * minibuf.c (get_minibuffer, read_minibuf_unwind):
8663 Call minibuffer-inactive-mode.
8665 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
8667 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
8668 Update dependencies.
8670 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8672 * data.c (init_data): Remove code for UTS, this system is not
8675 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8677 Don't force ./temacs to start in terminal mode.
8679 * frame.c (make_initial_frame): Initialize faces in all cases, not
8680 only when CANNOT_DUMP is defined.
8681 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
8683 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8685 * dispnew.c (add_window_display_history): Use const for the string
8686 pointer. Remove declaration, not needed.
8688 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8690 Use 'inline', not 'INLINE'.
8691 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
8692 * alloc.c, fontset.c (INLINE): Remove.
8693 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
8694 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
8695 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
8696 * gmalloc.c (register_heapinfo): Use inline unconditionally.
8697 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
8699 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8701 Make it possible to run ./temacs.
8703 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
8704 syms_of_callproc does the same thing. Remove test for
8705 "initialized", do it in the caller.
8706 * emacs.c (main): Avoid calling set_initial_environment when dumping.
8708 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
8710 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
8711 (read_minibuf): Use get_minibuffer.
8712 (syms_of_minibuf): Use DEFSYM.
8713 (Qmetadata): New var.
8714 * data.c (Qbuffer): Don't make it static.
8715 (syms_of_data): Use DEFSYM.
8717 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8719 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
8720 (CCL_CODE_MIN): New macro.
8722 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
8724 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
8726 * eval.c (Qdebug): Now static.
8727 * lisp.h (Qdebug): Remove decl. This reverts a part of the
8728 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
8729 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
8731 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
8733 * image.c: Various fixes to ImageMagick code comments.
8734 (Fimagemagick_types): Doc fix.
8736 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
8738 Minor fixes prompted by GCC 4.6.0 warnings.
8740 * xselect.c (converted_selections, conversion_fail_tag): Now static.
8742 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
8743 (x_clipboard_manager_save_all): Move extern decl to ...
8744 * xterm.h: ... here, so that it can be checked for consistency.
8746 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
8748 * xselect.c (x_clipboard_manager_save_frame)
8749 (x_clipboard_manager_save_all): New functions.
8750 (Fx_clipboard_manager_save): Lisp function deleted.
8752 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
8753 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
8755 * xterm.h: Update prototype.
8757 2011-05-28 William Xu <william.xwl@gmail.com>
8759 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
8762 2011-05-28 Jim Meyering <meyering@redhat.com>
8764 Avoid a sign-extension bug in crypto_hash_function.
8765 * fns.c (to_uchar): Define.
8766 (crypto_hash_function): Use it to convert some newly-signed
8767 variables to unsigned, to avoid sign-extension bugs. For example,
8768 without this change, (md5 "truc") would evaluate to
8769 45723a2aff78ff4fff7fff1114760e62 rather than the expected
8770 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
8771 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
8773 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8775 Integer overflow fixes.
8777 * dbusbind.c: Serial number integer overflow fixes.
8778 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
8779 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
8780 to hold a serial number that is too large for a fixnum.
8781 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8782 Check for serial numbers out of range. Decode any serial number
8783 that was so large that it became a float. (Bug#8722)
8785 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
8786 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8787 Use XFASTINT rather than XUINT when numbers are nonnegative.
8788 (xd_append_arg, Fdbus_method_return_internal):
8789 (Fdbus_method_error_internal): Likewise. Also, for unsigned
8790 arguments, check that Lisp number is nonnegative, rather than
8791 silently wrapping negative numbers around. (Bug#8722)
8792 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
8795 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
8797 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
8799 ccl: Add integer overflow checks.
8800 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
8801 (IN_INT_RANGE): New macros.
8802 (ccl_driver): Use them to check for integer overflow when
8803 decoding a CCL program. Many of the new checks are whether XINT (x)
8804 fits in int; it doesn't always, on 64-bit hosts. The new version
8805 doesn't catch all possible integer overflows, but it's an
8806 improvement. (Bug#8719)
8808 * alloc.c (make_event_array): Use XINT, not XUINT.
8809 There's no need for unsigned here.
8811 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
8812 This follows up to the 2011-05-06 change that substituted uintptr_t
8813 for EMACS_INT. This case wasn't caught back then.
8815 Rework Fformat to avoid integer overflow issues.
8816 * editfns.c: Include <float.h> unconditionally, as it's everywhere
8817 now (part of C89). Include <verify.h>.
8818 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
8819 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
8820 (Fformat): Avoid the prepass trying to compute sizes; it was only
8821 approximate and thus did not catch overflow reliably. Instead, walk
8822 through the format just once, formatting and computing sizes as we go,
8823 checking for integer overflow at every step, and allocating a larger
8824 buffer as needed. Keep track separately whether the format is
8825 multibyte. Keep only the most-recently calculated precision, rather
8826 than them all. Record whether each argument has been converted to
8827 string. Use EMACS_INT, not int, for byte and char and arg counts.
8828 Support field widths and precisions larger than INT_MAX. Avoid
8829 sprintf's undefined behavior with conversion specifications such as %#d
8830 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
8831 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
8832 formatting out-of-range floating point numbers with int
8835 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
8837 * data.c: Avoid integer truncation in expressions involving floats.
8838 * data.c: Include <intprops.h>.
8839 (arith_driver): When there's an integer overflow in an expression
8840 involving floating point, convert the integers to floating point
8841 so that the resulting value does not suffer from catastrophic
8842 integer truncation. For example, on a 64-bit host (* 4
8843 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
8844 Do not rely on undefined behavior after integer overflow.
8846 merge count_size_as_multibyte, parse_str_to_multibyte
8847 * character.c, character.h (count_size_as_multibyte):
8848 Rename from parse_str_to_multibyte; all uses changed.
8849 Check for integer overflow.
8850 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
8851 since it's now a duplicate of the other. This is more of
8852 a character than a buffer op, so better that it's in character.c.
8853 * fns.c, print.c: Adjust to above changes.
8855 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
8857 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
8859 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8861 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8862 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
8863 (x_clipboard_manager_save): Now static.
8864 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
8866 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8867 (crypto_hash_function): Now static.
8868 Fix pointer signedness problems. Avoid unnecessary initializations.
8870 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
8872 * termhooks.h (Vselection_alist): Make it terminal-local.
8874 * terminal.c (create_terminal): Initialize it.
8876 * xselect.c: Support for clipboard managers.
8877 (Vselection_alist): Move to termhooks.h as terminal-local var.
8878 (LOCAL_SELECTION): New macro.
8879 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
8880 (symbol_to_x_atom): Remove gratuitous arg.
8881 (x_handle_selection_request, lisp_data_to_selection_data)
8882 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
8883 (x_own_selection, x_get_local_selection, x_convert_selection):
8884 New arg, specifying work frame. Use terminal-local Vselection_alist.
8885 (some_frame_on_display): Delete unused function.
8886 (Fx_own_selection_internal, Fx_get_selection_internal)
8887 (Fx_disown_selection_internal, Fx_selection_owner_p)
8888 (Fx_selection_exists_p): New optional frame arg.
8889 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
8890 (x_handle_selection_clear): Don't treat other terminals with the
8891 same keyboard specially. Use the terminal-local Vselection_alist.
8892 (x_clear_frame_selections): Use Frun_hook_with_args.
8894 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
8896 * xterm.h: Add support for those atoms.
8898 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
8900 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
8901 (converted_selections, conversion_fail_tag): New global variables.
8902 (x_selection_request_lisp_error): Free the above.
8903 (x_get_local_selection): Remove unnecessary code.
8904 (x_reply_selection_request): Args changed; handle arbitrary array
8905 of converted selections stored in converted_selections.
8906 Separate the XChangeProperty and SelectionNotify steps.
8907 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
8908 (x_convert_selection): New function.
8909 (x_handle_selection_event): Simplify.
8910 (x_get_foreign_selection): Don't ignore incoming requests while
8911 waiting for an answer; this will fail when we implement
8912 SAVE_TARGETS, and seems unnecessary anyway.
8913 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
8914 (Vx_sent_selection_functions): Doc fix.
8916 2011-05-26 Leo Liu <sdl.web@gmail.com>
8918 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
8920 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8922 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
8924 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
8925 for fringe update if it has periodic bitmap.
8926 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
8927 and fringe_bitmap_periodic_p.
8929 * fringe.c (get_fringe_bitmap_data): New function.
8930 (draw_fringe_bitmap_1, update_window_fringes): Use it.
8931 (update_window_fringes): Record periodicity of fringe bitmap in glyph
8932 row. Mark glyph row for fringe update if periodicity changed.
8934 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
8935 for fringe update unless it has periodic bitmap.
8937 2011-05-25 Kenichi Handa <handa@m17n.org>
8939 * xdisp.c (get_next_display_element): Set correct it->face_id for
8940 a static composition.
8942 2011-05-24 Leo Liu <sdl.web@gmail.com>
8945 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
8947 * fns.c (crypto_hash_function, Fsha1): New function.
8948 (Fmd5): Use crypto_hash_function.
8949 (syms_of_fns): Add Ssha1.
8951 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8953 * gnutls.c: Remove unused macros.
8954 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
8955 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
8956 Remove macros that are defined and never used.
8957 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
8959 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
8961 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
8962 (Fx_get_selection_internal): Minor cleanup.
8963 (Fx_own_selection_internal): Rename arguments for consistency with
8966 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8968 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
8970 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
8972 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
8974 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8976 * dispnew.c (scrolling_window): Don't exclude the case that the
8977 last enabled row in the desired matrix touches the bottom boundary.
8979 2011-05-21 Glenn Morris <rgm@gnu.org>
8981 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
8982 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
8983 and add some more files.
8985 2011-05-20 Eli Zaretskii <eliz@gnu.org>
8987 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
8988 report_file_error introduced by the change from 2011-05-07.
8990 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
8992 * systime.h (Time): Define only if emacs is defined.
8993 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
8994 where the include path doesn't have X11/X.h by default. See
8995 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
8997 2011-05-20 Kenichi Handa <handa@m17n.org>
8999 * composite.c (find_automatic_composition): Fix previous change.
9001 2011-05-20 Glenn Morris <rgm@gnu.org>
9003 * lisp.mk: New file, split from Makefile.in.
9004 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
9005 (shortlisp): Remove.
9006 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
9008 2011-05-19 Glenn Morris <rgm@gnu.org>
9010 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
9011 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
9012 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
9013 (lisp): Set the order to that of loadup.el.
9014 (shortlisp): Make it a copy of $lisp.
9015 (SOME_MACHINE_LISP): Remove.
9016 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
9017 Use just $shortlisp, not $SOME_MACHINE_LISP too.
9019 2011-05-18 Kenichi Handa <handa@m17n.org>
9021 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
9022 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
9023 (find_automatic_composition): Mostly rewrite for efficiency.
9025 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
9027 * makefile.w32-in: Update dependencies.
9029 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
9031 * menu.c: Include limits.h (fixes the MS-Windows build broken by
9032 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
9034 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
9036 Fix some integer overflow issues, such as string length overflow.
9038 * insdel.c (count_size_as_multibyte): Check for string overflow.
9040 * character.c (lisp_string_width): Check for string overflow.
9041 Use EMACS_INT, not int, for string indexes and lengths; in
9042 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
9043 the resulting string length overflows an EMACS_INT; instead,
9044 report a string overflow if no precision given. When checking for
9045 precision exhaustion, use a check that cannot possibly have
9046 integer overflow. (Bug#8675)
9047 * character.h (lisp_string_width): Adjust to new signature.
9049 * alloc.c (string_overflow): New function.
9050 (Fmake_string): Use it. This doesn't change behavior, but saves
9051 a few bytes and will simplify future changes.
9052 * character.c (string_escape_byte8): Likewise.
9053 * lisp.h (string_overflow): New decl.
9055 Fixups, following up to the user-interface timestamp change.
9056 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
9057 for UI timestamps, instead of unsigned long.
9058 * msdos.c (mouse_get_pos): Likewise.
9059 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
9060 * w32gui.h (Time): Define by including "systime.h" rather than by
9061 declaring it ourselves. (Bug#8664)
9063 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
9064 * image.c (clear_image_cache): Likewise.
9066 * term.c (term_mouse_position): Don't assume time_t wraparound.
9068 Be more systematic about user-interface timestamps.
9069 Before, the code sometimes used 'Time', sometimes 'unsigned long',
9070 and sometimes 'EMACS_UINT', to represent these timestamps.
9071 This change causes it to use 'Time' uniformly, as that's what X uses.
9072 This makes the code easier to follow, and makes it easier to catch
9073 integer overflow bugs such as Bug#8664.
9074 * frame.c (Fmouse_position, Fmouse_pixel_position):
9075 Use Time, not unsigned long, for user-interface timestamps.
9076 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
9077 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
9078 * keyboard.h (last_event_timestamp): Likewise.
9079 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
9080 * menu.h (xmenu_show): Likewise.
9081 * term.c (term_mouse_position): Likewise.
9082 * termhooks.h (struct input_event.timestamp): Likewise.
9083 (struct terminal.mouse_position_hook): Likewise.
9084 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
9085 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
9086 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
9087 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
9089 * menu.h, termhooks.h: Include "systime.h", for Time.
9091 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
9092 Don't assume that the difference between two unsigned long values
9093 can fit into an integer. At this point, we know button_down_time
9094 <= event->timestamp, so the difference must be nonnegative, so
9095 there's no need to cast the result if double-click-time is
9096 nonnegative, as it should be; check that it's nonnegative, just in
9097 case. This bug is triggered when events are more than 2**31 ms
9098 apart (about 25 days). (Bug#8664)
9100 * xselect.c (last_event_timestamp): Remove duplicate decl.
9101 (x_own_selection): Remove needless cast to unsigned long.
9103 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
9104 that always fit in int. Use a sentinel instead of a counter, to
9105 avoid a temp and to allay GCC's concerns about possible int overflow.
9106 * frame.h (struct frame): Use int for menu_bar_items_used
9107 instead of EMACS_INT, since it always fits in int.
9109 * menu.c (grow_menu_items): Check for int overflow.
9111 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
9113 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
9114 Before, the code was not consistent. These values cannot exceed
9115 2**31 - 1 so there's no need to make them unsigned.
9116 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
9117 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
9118 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
9120 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
9122 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
9123 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
9124 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
9125 presumably because the widths might not match.
9127 * window.c (size_window): Avoid needless test at loop start.
9129 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
9131 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
9133 2011-05-12 Drew Adams <drew.adams@oracle.com>
9135 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
9137 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9139 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
9140 `width' to `bar_area_x' and `bar_area_width', respectively.
9141 (x_scroll_run): Take account of fringe background extension.
9143 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
9144 Rename local vars `left' and `width' to `bar_area_x' and
9145 `bar_area_width', respectively.
9146 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
9147 background extension.
9149 2011-05-10 Jim Meyering <meyering@redhat.com>
9151 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
9153 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
9155 * image.c (Finit_image_library): Return t for built-in image types,
9156 like pbm and xbm. (Bug#8640)
9158 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
9160 * w32menu.c (set_frame_menubar): Fix submenu allocation.
9162 2011-05-07 Eli Zaretskii <eliz@gnu.org>
9164 * w32console.c (Fset_screen_color): Doc fix.
9165 (Fget_screen_color): New function.
9166 (syms_of_ntterm): Defsubr it.
9168 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
9169 unlink the temporary file if Fcall_process didn't create it in the
9171 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
9172 child process will be redirected to a file specified with `:file'.
9173 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
9174 cue to call_process_cleanup not to close that handle.
9176 2011-05-07 Ben Key <bkey76@gmail.com>
9178 * makefile.w32-in: The bootstrap-temacs rule now makes use of
9179 one of two shell specific rules, either bootstrap-temacs-CMD or
9180 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
9181 to the previous implementation of the bootstrap-temacs rule.
9182 The bootstrap-temacs-CMD rule is similar to the previous
9183 implementation of the bootstrap-temacs rule except that it
9184 makes use of the ESC_CFLAGS variable instead of the CFLAGS
9187 These changes, along with some changes to nt/configure.bat,
9188 nt/gmake.defs, and nt/nmake.defs, are required to extend my
9189 earlier fix to add support for --cflags and --ldflags options
9190 that include quotes so that it works whether make uses cmd or
9193 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
9195 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
9196 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
9198 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
9199 a string. Handle both cases.
9200 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
9201 (Fdbus_register_method): Use Qinvalid_function.
9203 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
9205 * makefile.w32-in: Update dependencies.
9206 (LISP_H): Add inttypes.h and stdin.h.
9207 (PROCESS_H): Add unistd.h.
9209 2011-05-06 Eli Zaretskii <eliz@gnu.org>
9211 * lread.c: Include limits.h (fixes the MS-Windows build broken by
9212 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
9214 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
9216 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
9218 * term.c (vfatal): Remove stray call to va_end.
9219 It's not needed and the C Standard doesn't allow it here anyway.
9221 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
9222 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
9224 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
9227 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
9229 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
9231 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
9233 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
9235 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
9237 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
9238 * charset.c (Fdefine_charset_internal): Don't initialize
9239 charset.code_space[15]. The value was garbage, on hosts with
9240 32-bit int (Bug#8600).
9242 * lread.c (read_integer): Be more consistent with string-to-number.
9243 Use string_to_number to do the actual conversion; this avoids
9244 rounding errors and fixes some other screwups. Without this fix,
9245 for example, #x1fffffffffffffff was misread as -2305843009213693952.
9246 (digit_to_number): Move earlier, for benefit of read_integer.
9247 Return -1 if the digit is out of range for the base, -2 if it is
9248 not a digit in any supported base. (Bug#8602)
9250 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
9252 * dispnew.c (scrolling_window): Return 1 if we scrolled,
9253 to match comment at start of function. This also removes a
9254 GCC warning about overflow in a 32+64-bit port.
9256 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
9258 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
9259 Reported by Stefan Monnier in
9260 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
9261 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9262 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
9264 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
9265 (EMACS_UINTPTR): Likewise, with uintptr_t.
9267 * lisp.h: Prefer 64-bit EMACS_INT if available.
9268 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
9269 on 32-bit hosts that have 64-bit int, so that they can access
9271 However, temporarily disable this change unless the temporary
9272 symbol WIDE_EMACS_INT is defined.
9274 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
9276 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
9277 This removes an assumption that EMACS_INT and long are the same
9278 width as pointers. The assumption is true for Emacs porting targets
9279 now, but we want to make other targets possible.
9280 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
9281 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
9282 In the rest of the code, change types of integers that hold casted
9283 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
9284 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
9285 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
9286 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
9287 No need to cast type when ORing.
9288 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
9289 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
9290 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
9291 assume EMACS_INT is the same width as char *.
9292 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
9293 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
9294 Remove no-longer-needed casts.
9295 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
9296 (xg_tool_bar_help_callback, xg_make_tool_item):
9297 Use EMACS_INTPTR to hold an integer
9298 that will be cast to void *; this can avoid a GCC warning
9299 if EMACS_INT is not the same width as void *.
9300 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
9301 * xdisp.c (display_echo_area_1, resize_mini_window_1):
9302 (current_message_1, set_message_1):
9303 Use a local to convert to proper width without a cast.
9304 * xmenu.c (dialog_selection_callback): Likewise.
9306 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
9307 Also, don't assume VALBITS / RAND_BITS is less than 5,
9308 and don't rely on undefined behavior when shifting a 1 left into
9310 * lisp.h (get_random): Change signature to match.
9312 * lread.c (hash_string): Use size_t, not int, for hash computation.
9313 Normally we prefer signed values; but hashing is special, because
9314 it's better to use unsigned division on hash table sizes so that
9315 the remainder is nonnegative. Also, size_t is the natural width
9316 for hashing into memory. The previous code used 'int', which doesn't
9317 retain enough info to hash well into very large tables.
9318 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
9320 * dbusbind.c: Don't possibly lose pointer info when converting.
9321 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9322 Use XPNTR rather than XHASH, so that the high-order bits of
9323 the pointer aren't lost when converting through void *.
9325 * eval.c (Fautoload): Don't double-shift a pointer.
9327 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
9329 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
9331 * gnutls.c (DEF_GNUTLS_FN):
9332 * image.c (DEF_IMGLIB_FN): Make function pointers static.
9334 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
9336 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
9339 2011-05-05 Eli Zaretskii <eliz@gnu.org>
9341 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
9342 New version that can reserve upto 2GB of heap space.
9344 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
9346 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
9348 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
9350 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
9351 `gnutls_certificate_set_x509_key_file'.
9353 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
9355 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
9356 Update dependencies.
9358 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
9360 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
9361 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
9362 Remove unused parameter `fildes'.
9363 * process.c (read_process_output, send_process): Don't pass it.
9365 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
9367 Fix previous change: the library cache is defined in w32.c.
9368 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
9369 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
9371 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
9373 Implement dynamic loading of GnuTLS on Windows.
9375 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
9376 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
9377 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9380 * gnutls.c (Qgnutls_dll): Define.
9381 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
9382 (gnutls_*): Declare function pointers.
9383 (init_gnutls_functions): New function to initialize function pointers.
9384 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
9385 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
9386 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9387 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
9388 (emacs_gnutls_write, emacs_gnutls_read)
9389 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
9390 (Fgnutls_available_p): New function.
9391 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
9392 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
9393 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
9395 * image.c: Include w32.h.
9396 (Vimage_type_cache): Delete.
9397 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
9398 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
9399 (w32_delayed_load): Move to w32.c.
9401 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
9403 * w32.c (QCloaded_from, Vlibrary_cache): Define.
9404 (w32_delayed_load): Move from image.c. When loading a library, record
9405 its filename in the :loaded-from property of the library id.
9406 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
9407 Initialize and staticpro them.
9408 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
9410 * process.c: Include lisp.h before w32.h, not after.
9411 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
9412 instead of gnutls_record_check_pending.
9414 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
9416 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
9418 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
9419 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
9422 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
9424 * xterm.c (x_set_frame_alpha): Do not set property on anything
9425 else than FRAME_X_OUTER_WINDOW (Bug#8608).
9427 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
9429 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
9431 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
9433 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
9434 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
9435 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
9436 (gnutls_global_initialized, Qgnutls_bootprop_priority)
9437 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
9438 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
9439 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
9440 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
9441 (Qgnutls_bootprop_callbacks_verify): Make static.
9443 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
9445 * callproc.c: Indentation fixup.
9447 * sysdep.c (wait_for_termination_1): Make static.
9448 (wait_for_termination, interruptible_wait_for_termination):
9449 Move after wait_for_termination_1.
9451 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
9453 * sysdep.c (interruptible_wait_for_termination): New function
9454 which is like wait_for_termination, but allows keyboard
9457 * callproc.c (Fcall_process): Add (:file "file") as an option for
9459 (Fcall_process_region): Ditto.
9461 2011-04-30 Eli Zaretskii <eliz@gnu.org>
9463 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
9464 rather than `XVECTOR (FOO)->size'.
9466 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
9467 inttypes.h, as a gnulib replacement is used if it not available in
9470 2011-04-21 Eli Zaretskii <eliz@gnu.org>
9472 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
9473 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
9474 of MOST_POSITIVE_FIXNUM. (Bug#8528)
9476 * coding.c (coding_alloc_by_realloc): Error out if destination
9477 will grow beyond MOST_POSITIVE_FIXNUM.
9478 (decode_coding_emacs_mule): Abort if there isn't enough place in
9479 charbuf for the composition carryover bytes. Reserve an extra
9480 space for up to 2 characters produced in a loop.
9481 (decode_coding_iso_2022): Abort if there isn't enough place in
9482 charbuf for the composition carryover bytes.
9484 2011-04-21 Eli Zaretskii <eliz@gnu.org>
9486 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
9487 aborting when %lld or %lll format is passed.
9488 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
9489 %llo or %llx format is passed. (Bug#8545)
9491 * window.c (window_scroll_line_based): Use a marker instead of
9492 simple variables to record original value of point. (Bug#7952)
9494 * doprnt.c (doprnt): Fix the case where a multibyte sequence
9495 produced by %s or %c overflows available buffer space. (Bug#8545)
9497 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
9499 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
9500 (SIZE_MAX): Move defn after all includes, as they might #define it.
9502 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
9504 * w32.c (init_environment): Warn about defaulting HOME to C:\.
9506 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
9508 * keyboard.c (Qdelayed_warnings_hook): Define.
9509 (command_loop_1): Run `delayed-warnings-hook'
9510 if Vdelayed_warnings_list is non-nil.
9511 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
9512 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
9514 2011-04-28 Eli Zaretskii <eliz@gnu.org>
9516 * doprnt.c (doprnt): Don't return value smaller than the buffer
9517 size if the message was truncated. (Bug#8545).
9519 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
9521 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
9522 (Fx_window_property): #if-0 the whole functions, not just the bodies.
9524 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9526 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
9528 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
9530 * makefile.w32-in: Update dependencies.
9532 2011-04-27 Eli Zaretskii <eliz@gnu.org>
9534 Improve `doprnt' and its usage. (Bug#8545)
9535 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
9536 `format_end'. Remove support for %l as a conversion specifier.
9537 Don't use xrealloc. Improve diagnostics when the %l size modifier
9538 is used. Update the commentary.
9540 * eval.c (verror): Simplify calculation of size_t.
9542 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
9545 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
9547 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
9550 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9552 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
9553 This makes this file independent of the recent pseudovector change.
9555 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
9557 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
9559 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
9560 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
9561 Remove unused local.
9562 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
9564 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
9565 GCC 4.6.0 optimizes based on type-based alias analysis.
9566 For example, if b is of type struct buffer * and v of type struct
9567 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
9568 != &v->size, and therefore "v->size = 1; b->size = 2; return
9569 v->size;" must therefore return 1. This assumption is incorrect
9570 for Emacs, since it type-puns struct Lisp_Vector * with many other
9571 types. To fix this problem, this patch adds a new type struct
9572 vectorlike_header that documents the constraints on layout of vectors
9573 and pseudovectors, and helps optimizing compilers not get fooled
9574 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
9575 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
9576 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
9578 (XSETPVECTYPE): Rewrite in terms of new macro.
9579 (XSETPVECTYPESIZE): New macro, specifying both type and size.
9580 This is a bit clearer, and further avoids the possibility of
9581 undesirable aliasing.
9582 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
9583 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
9584 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
9585 since Lisp_Subr is a special case (no "next" field).
9586 (ASIZE): Now uses header.size rather than size.
9587 All previous uses of XVECTOR (foo)->size replaced to use this macro,
9588 to avoid the hassle of writing XVECTOR (foo)->header.size.
9589 (struct vectorlike_header): New type.
9590 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
9591 object, to help avoid aliasing.
9592 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
9593 (SUBRP): Likewise, since Lisp_Subr is a special case.
9594 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
9595 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
9596 (struct Lisp_Hash_Table): Combine first two members into a single
9597 struct vectorlike_header member. All uses of "size" and "next" members
9598 changed to be "header.size" and "header.next".
9599 * buffer.h (struct buffer): Likewise.
9600 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
9601 * frame.h (struct frame): Likewise.
9602 * process.h (struct Lisp_Process): Likewise.
9603 * termhooks.h (struct terminal): Likewise.
9604 * window.c (struct save_window_data, struct saved_window): Likewise.
9605 * window.h (struct window): Likewise.
9606 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
9607 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
9608 * buffer.c (init_buffer_once): Likewise.
9609 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
9611 * process.c (Fformat_network_address): Use local var for size,
9614 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
9616 Make the Lisp reader and string-to-float more consistent (Bug#8525)
9617 * data.c (atof): Remove decl; no longer used or needed.
9618 (digit_to_number): Move to lread.c.
9619 (Fstring_to_number): Use new string_to_number function, to be
9620 consistent with how the Lisp reader treats infinities and NaNs.
9621 Do not assume that floating-point numbers represent EMACS_INT
9622 without losing information; this is not true on most 64-bit hosts.
9623 Avoid double-rounding errors, by insisting on integers when
9624 parsing non-base-10 numbers, as the documentation specifies.
9625 * lisp.h (string_to_number): New decl, replacing ...
9626 (isfloat_string): Remove.
9627 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
9628 (read1): Do not accept +. and -. as integers; this
9629 appears to have been a coding error. Similarly, do not accept
9630 strings like +-1e0 as floating point numbers. Do not report
9631 overflow for integer overflows unless the base is not 10 which
9632 means we have no simple and reliable way to continue.
9633 Break out the floating-point parsing into a new
9634 function string_to_number, so that Fstring_to_number parses
9635 floating point numbers consistently with the Lisp reader.
9636 (digit_to_number): Move here from data.c. Make it static inline.
9637 (E_CHAR, EXP_INT): Remove, replacing with ...
9638 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
9639 (string_to_number): New function, replacing isfloat_string.
9640 This function checks for valid syntax and produces the resulting
9641 Lisp float number too. Rework it so that string-to-number
9642 no longer mishandles examples like "1.0e+". Use strtoumax,
9643 so that overflow for non-base-10 numbers is reported only when
9644 there's no portable and simple way to convert to floating point.
9646 * textprop.c (set_text_properties_1): Rewrite for clarity,
9647 and to avoid GCC warning about integer overflow.
9649 * intervals.h (struct interval): Use EMACS_INT for members
9650 where EMACS_UINT might cause problems. See
9651 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
9652 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
9653 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
9655 (offset_intervals): Tell GCC not to worry about length overflow
9656 when negating a negative length.
9658 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
9659 (overrun_check_free): Likewise.
9661 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
9662 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
9665 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9666 (gnutls_make_error): Rename local to avoid shadowing.
9667 (gnutls_emacs_global_deinit): ifdef out; not used.
9668 (Fgnutls_boot): Use const for pointer to readonly storage.
9669 Comment out unused local. Fix pointer signedness problems.
9671 * lread.c (openp): Don't stuff size_t into an 'int'.
9672 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
9673 about possible signed overflow.
9675 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9676 (GDK_KEY_g): Don't define if already defined.
9677 (xg_prepare_tooltip): Avoid pointer signedness problem.
9678 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
9680 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
9681 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
9683 * xfns.c (Fx_window_property): Simplify a bit,
9684 to make a bit faster and to avoid GCC 4.6.0 warning.
9685 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
9687 * fns.c (internal_equal): Don't assume size_t fits in int.
9689 * alloc.c (compact_small_strings): Tighten assertion a little.
9691 Replace pEd with more-general pI, and fix some printf arg casts.
9692 * lisp.h (pI): New macro, generalizing old pEd macro to other
9693 conversion specifiers. For example, use "...%"pI"d..." rather
9694 than "...%"pEd"...".
9695 (pEd): Remove. All uses replaced with similar uses of pI.
9696 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
9697 * alloc.c (check_pure_size): Don't overflow by converting size to int.
9698 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
9699 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
9700 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
9701 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
9702 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
9704 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
9705 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
9706 * print.c (safe_debug_print, print_object): Likewise.
9707 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
9709 Use pI instead of if-then-else-abort. Use %p to avoid casts,
9710 avoiding the 0 flag, which is not portable.
9711 * process.c (Fmake_network_process): Use pI to avoid cast.
9712 * region-cache.c (pp_cache): Likewise.
9713 * xdisp.c (decode_mode_spec): Likewise.
9714 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
9715 behavior on 64-bit hosts with printf arg.
9716 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
9717 (x_stop_queuing_selection_requests): Likewise.
9718 (x_get_window_property): Don't truncate byte count to an 'int'
9721 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
9722 here, since it parses constructs like leading '-' and spaces,
9723 which are not wanted; and it overflows with large numbers.
9724 Instead, simply match F[0-9]+, which is what is wanted anyway.
9726 * alloc.c: Remove unportable assumptions about struct layout.
9727 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
9728 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
9729 (allocate_vectorlike, make_pure_vector): Use the new macros,
9730 plus offsetof, to remove unportable assumptions about struct layout.
9731 These assumptions hold on all porting targets that I know of, but
9732 they are not guaranteed, they're easy to remove, and removing them
9733 makes further changes easier.
9735 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
9736 This doesn't fix a bug but makes the code clearer.
9737 (string_overrun_cookie): Now const. Use initializers that
9738 don't formally overflow signed char, to avoid warnings.
9739 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
9740 can cause Emacs to crash when string overrun checking is enabled.
9741 (allocate_buffer): Don't assume sizeof (struct buffer) is a
9742 multiple of sizeof (EMACS_INT); it need not be, if
9743 alignof(EMACS_INT) < sizeof (EMACS_INT).
9744 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
9746 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
9748 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
9750 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
9752 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
9753 supposed to be handshaking. (Bug#8556)
9754 Reported by Paul Eggert <eggert@cs.ucla.edu>.
9756 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
9758 * lisp.h (Qdebug): List symbol.
9759 * eval.c (Qdebug): Restore global linkage.
9760 * keyboard.c (debug-on-event): New variable.
9761 (handle_user_signal): Break into debugger when debug-on-event
9762 matches the current signal symbol.
9764 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
9766 * alloc.c (check_sblock, check_string_bytes)
9767 (check_string_free_list): Convert to standard C.
9769 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
9771 * w32.c (emacs_gnutls_push): Fix typo.
9773 2011-04-25 Eli Zaretskii <eliz@gnu.org>
9775 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
9776 "cast to pointer from integer of different size".
9778 Improve doprnt and its use in verror. (Bug#8545)
9779 * doprnt.c (doprnt): Document the set of format control sequences
9780 supported by the function. Use SAFE_ALLOCA instead of always
9783 * eval.c (verror): Don't limit the buffer size at size_max-1, that
9784 is one byte too soon. Don't use xrealloc; instead xfree and
9787 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
9789 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
9792 * gnutls.c: Renamed global_initialized to
9793 gnutls_global_initialized. Added internals for the
9794 :verify-hostname-error, :verify-error, and :verify-flags
9795 parameters of `gnutls-boot' and documented those parameters in the
9796 docstring. Start callback support.
9797 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
9798 unless a fatal error occurred. Call gnutls_alert_send_appropriate
9799 on error. Return error code.
9800 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
9801 (emacs_gnutls_read): Likewise.
9802 (Fgnutls_boot): Return handshake error code.
9803 (emacs_gnutls_handle_error): New function.
9804 (wsaerror_to_errno): Likewise.
9806 * w32.h (emacs_gnutls_pull): Add prototype.
9807 (emacs_gnutls_push): Likewise.
9809 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
9810 (emacs_gnutls_push): Likewise.
9812 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
9814 * process.c (wait_reading_process_output): Check if GnuTLS
9815 buffered some data internally if no FDs are set for TLS
9818 * makefile.w32-in (OBJ2): Add gnutls.$(O).
9819 (LIBS): Link to USER_LIBS.
9820 ($(BLD)/gnutls.$(0)): New target.
9822 2011-04-24 Eli Zaretskii <eliz@gnu.org>
9824 * xdisp.c (handle_single_display_spec): Rename the
9825 display_replaced_before_p argument into display_replaced_p, to
9826 make it consistent with the commentary. Fix typos in the
9829 * textprop.c (syms_of_textprop): Remove dead code.
9830 (copy_text_properties): Delete obsolete commentary about an
9831 interface that was deleted long ago. Fix typos in the description
9834 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
9835 to changes in oldXMenu/XMenu.h from 2011-04-16.
9836 <menu_help_message, prev_menu_help_message>: Constify.
9837 (IT_menu_make_room): menu->help_text is now `const char **';
9840 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
9841 to changes in oldXMenu/XMenu.h from 2011-04-16.
9842 (struct XMenu): Declare `help_text' `const char **'.
9844 * xfaces.c <Qunspecified>: Make extern again.
9846 * syntax.c: Include sys/types.h before including regex.h, as
9849 * doc.c (get_doc_string): Improve the format passed to `error'.
9851 * doprnt.c (doprnt): Improve commentary.
9853 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
9855 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
9858 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
9859 changes in globals.h immediately force recompilation.
9860 (TAGS): Depend on $(CURDIR)/m/intel386.h and
9861 $(CURDIR)/s/ms-w32.h.
9862 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
9864 * character.c (Fchar_direction): Function deleted.
9865 (syms_of_character): Don't defsubr it.
9866 <char-direction-table>: Deleted.
9868 2011-04-23 Eli Zaretskii <eliz@gnu.org>
9870 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
9871 * doprnt.c: Include limits.h.
9872 (SIZE_MAX): New macro.
9873 (doprnt): Return a size_t value. 2nd arg is now size_t.
9874 Many local variables are now size_t instead of int or unsigned.
9875 Improve overflow protection. Support `l' modifier for integer
9876 conversions. Support %l conversion. Don't assume an EMACS_INT
9877 argument for integer conversions and for %c.
9879 * lisp.h (doprnt): Restore prototype.
9881 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
9884 * Makefile.in (base_obj): Add back doprnt.o.
9886 * deps.mk (doprnt.o): Add back prerequisites.
9887 (callint.o): Depend on character.h.
9889 * eval.c (internal_lisp_condition_case): Include the handler
9890 representation in the error message.
9891 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
9892 when breaking from the loop.
9894 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
9896 * callint.c (Fcall_interactively): When displaying error message
9897 about invalid control letter, pass the character's codepoint, not
9898 a pointer to its multibyte form. Improve display of the character
9899 in octal and display also its hex code.
9901 * character.c (char_string): Use %x to display the (unsigned)
9902 codepoint of an invalid character, to avoid displaying a bogus
9905 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
9906 `error', not SYMBOL_NAME itself.
9908 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
9909 character arguments to `error'.
9911 * charset.c (check_iso_charset_parameter): Fix incorrect argument
9912 to `error' in error message about FINAL_CHAR argument. Make sure
9913 FINAL_CHAR is a character, and use %c when it is passed as
9914 argument to `error'.
9916 2011-04-23 Eli Zaretskii <eliz@gnu.org>
9918 * s/ms-w32.h (localtime): Redirect to sys_localtime.
9920 * w32.c: Include <time.h>.
9921 (sys_localtime): New function.
9923 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
9925 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
9927 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
9929 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
9931 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
9934 2011-04-19 Eli Zaretskii <eliz@gnu.org>
9936 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
9937 gl_state.e_property when gl_state.object is Qt.
9939 * insdel.c (make_gap_larger): Remove limitation of buffer size
9942 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
9944 * xdisp.c (lookup_glyphless_char_display)
9945 (produce_glyphless_glyph): Handle cons cell entry in
9946 glyphless-char-display.
9947 (Vglyphless_char_display): Document it.
9949 * term.c (produce_glyphless_glyph): Handle cons cell entry in
9950 glyphless-char-display.
9952 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
9954 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
9956 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
9958 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
9959 definition for no-X builds.
9961 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
9963 Static checks with GCC 4.6.0 and non-default toolkits.
9965 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
9967 * process.c (keyboard_bit_set): Define only if SIGIO.
9968 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
9969 (send_process): Repair possible setjmp clobbering.
9971 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
9973 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
9975 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
9977 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
9978 Define only if needed.
9980 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
9981 by pacifying GCC about it. Maybe it's time to retire it?
9982 * xfaces.c (USG, __TIMEVAL__): Likewise.
9984 * dispextern.h (struct redisplay_interface): Rename param
9986 * termhooks.h (struct terminal): Likewise.
9987 * xterm.c (xembed_send_message): Likewise.
9989 * insdel.c (make_gap_smaller): Define only if
9990 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
9992 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
9995 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
9996 so that we aren't warned about unused symbols.
9998 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
10000 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
10002 * xfns.c (x_real_positions): Mark locals as initialized.
10004 * xmenu.c (xmenu_show): Don't use uninitialized vars.
10006 * xterm.c: Fix problems found by static analysis with other toolkits.
10007 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
10008 (x_dispatch_event): Declare static if USE_GTK, and
10009 define if USE_GTK || USE_X_TOOLKIT.
10010 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
10011 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
10012 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
10013 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
10015 * xmenu.c (menu_help_callback): Pointer type fixes.
10016 Use const pointers when pointing at readonly data. Avoid pointer
10017 signedness clashes.
10018 (FALSE): Remove unused macro.
10019 (update_frame_menubar): Remove unused decl.
10021 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
10023 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
10024 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
10025 (single_menu_item): Rename local to avoid shadowing.
10027 * keyboard.c (make_lispy_event): Remove unused local var.
10029 * frame.c, frame.h (x_get_resource_string): Bring this back, but
10030 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
10032 * bitmaps: Change bitmaps from unsigned char back to the X11
10033 compatible char. Avoid the old compiler warnings about
10034 out-of-range initializers by using, for example, '\xab' rather
10037 * xgselect.c (xgselect_initialize): Check vs interface
10038 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
10040 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
10042 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
10043 to read-only memory.
10045 * fns.c (vector): Remove; this old hack is no longer needed.
10047 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
10049 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
10051 * xrdb.c (x_load_resources): Omit unused local.
10053 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
10054 (x_window): Rename locals to avoid shadowing.
10055 (USG): Use the kludged USG macro, to pacify gcc.
10057 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
10058 (x_term_init): Remove local to avoid shadowing.
10060 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
10062 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
10063 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
10065 2011-04-16 Eli Zaretskii <eliz@gnu.org>
10067 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
10069 Fix regex.c, syntax.c and friends for buffers > 2GB.
10070 * syntax.h (struct gl_state_s): Declare character position members
10073 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
10075 * textprop.c (verify_interval_modification, interval_of):
10076 Declare arguments EMACS_INT.
10078 * intervals.c (adjust_intervals_for_insertion): Declare arguments
10081 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
10083 * indent.c (Fvertical_motion): Local variable it_start is now
10086 * regex.c (re_match, re_match_2, re_match_2_internal)
10087 (bcmp_translate, regcomp, regexec, print_double_string)
10088 (group_in_compile_stack, re_search, re_search_2, regex_compile)
10089 (re_compile_pattern, re_exec): Declare arguments and local
10090 variables `size_t' and `ssize_t' and return values `regoff_t', as
10092 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
10093 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
10094 <compile_stack_type>: `size' and `avail' are now `size_t'.
10096 * regex.h <regoff_t>: Use ssize_t, not int.
10097 (re_search, re_search_2, re_match, re_match_2): Arguments that
10098 specify buffer/string position and length are now ssize_t and
10099 size_t. Return type is regoff_t.
10101 2011-04-16 Ben Key <bkey76@gmail.com>
10103 * nsfont.m: Fixed bugs in ns_get_family and
10104 ns_descriptor_to_entity that were caused by using free to
10105 deallocate memory blocks that were allocated by xmalloc (via
10106 xstrdup). This caused Emacs to crash when compiled with
10107 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
10108 --enable-checking=xmallocoverrun). xfree is now used to
10109 deallocate these memory blocks.
10111 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
10113 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
10115 emacs_write: Accept and return EMACS_INT for sizes.
10116 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
10118 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
10119 Accept and return EMACS_INT.
10120 (emacs_gnutls_write): Return the number of bytes written on
10122 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
10123 (emacs_read, emacs_write): Remove check for negative size, as the
10124 Emacs source code has been audited now.
10125 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
10126 (emacs_read, emacs_write): Use it.
10127 * process.c (send_process): Adjust to the new signatures of
10128 emacs_write and emacs_gnutls_write. Do not attempt to store
10129 a byte offset into an 'int'; it might overflow.
10130 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
10132 * sound.c: Don't assume sizes fit in 'int'.
10133 (struct sound_device.period_size, alsa_period_size):
10134 Return EMACS_INT, not int.
10135 (struct sound_device.write, vox_write, alsa_write):
10136 Accept EMACS_INT, not int.
10137 (wav_play, au_play): Use EMACS_INT to store sizes and to
10138 record read return values.
10140 2011-04-15 Ben Key <bkey76@gmail.com>
10142 * keyboard.c (Qundefined): Don't declare static since it is used
10144 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
10145 static since they are used in nsfont.m.
10147 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
10149 * process.c (Qprocessp): Don't declare static.
10150 * lisp.h (Qprocessp): Declare again.
10152 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
10154 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
10156 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
10158 Improve C-level modularity by making more things 'static'.
10160 Don't publish debugger-only interfaces to other modules.
10161 * lisp.h (safe_debug_print, debug_output_compilation_hack):
10162 (verify_bytepos, count_markers): Move decls to the only modules
10164 * region-cache.h (pp_cache): Likewise.
10165 * window.h (check_all_windows): Likewise.
10166 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
10168 * sysdep.c (croak): Now static, if
10169 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
10170 * syssignal.h (croak): Declare only if not static.
10172 * alloc.c (refill_memory_reserve): Now static if
10173 !defined REL_ALLOC || defined SYSTEM_MALLOC.
10174 * lisp.h (refill_memory_reserve): Declare only if not static.
10176 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
10177 Define only if USE_LUCID.
10179 * xrdb.c (x_customization_string, x_rm_string): Now static.
10181 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
10182 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
10184 * xdisp.c (draw_row_with_mouse_face): Now static.
10185 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
10187 * window.h (check_all_windows): Mark externally visible.
10189 * window.c (window_deletion_count): Now static.
10191 * undo.c: Make symbols static if they're not exported.
10192 (last_undo_buffer, last_boundary_position, pending_boundary):
10195 * textprop.c (interval_insert_behind_hooks): Now static.
10196 (interval_insert_in_front_hooks): Likewise.
10198 * term.c: Make symbols static if they're not exported.
10199 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
10200 (max_frame_lines, tty_set_terminal_modes):
10201 (tty_reset_terminal_modes, tty_turn_off_highlight):
10202 (get_tty_terminal): Now static.
10203 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
10204 * termhooks.h (term_mouse_moveto): Do not declare if
10205 HAVE_WINDOW_SYSTEM.
10206 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
10207 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
10209 * sysdep.c: Make symbols static if they're not exported.
10210 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
10212 (sigprocmask_set, full_mask): Remove; unused.
10213 (wait_debugging): Mark as visible.
10214 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
10215 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
10217 * syntax.c (syntax_temp): Define only if !__GNUC__.
10219 * sound.c (current_sound_device, current_sound): Now static.
10221 * search.c (searchbufs, searchbuf_head): Now static.
10223 * scroll.c (scroll_cost): Remove; unused.
10224 * dispextern.h (scroll_cost): Remove decl.
10226 * region-cache.h (pp_cache): Mark as externally visible.
10228 * process.c: Make symbols static if they're not exported.
10229 (process_tick, update_tick, create_process, chan_process):
10230 (Vprocess_alist, proc_buffered_char, datagram_access):
10231 (fd_callback_data, send_process_frame, process_sent_to): Now static.
10232 (deactivate_process): Mark defn as static, as well as decl.
10233 * lisp.h (create_process): Remove decl.
10234 * process.h (chan_process, Vprocess_alist): Remove decls.
10236 * print.c: Make symbols static if they're not exported.
10237 (print_depth, new_backquote_output, being_printed, print_buffer):
10238 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
10239 (print_interval, print_number_index, initial_stderr_stream):
10241 * lisp.h (Fprinc): Remove decl.
10242 (debug_output_compilation_hack): Mark as externally visible.
10244 * sysdep.c (croak): Move decl from here to syssignal.h.
10245 * syssignal.h (croak): Put it here, so the API can be checked when
10246 'croak' is called from dissociate_if_controlling_tty.
10248 * minibuf.c: Make symbols static if they're not exported.
10249 (minibuf_save_list, choose_minibuf_frame): Now static.
10250 * lisp.h (choose_minibuf_frame): Remove decl.
10252 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
10254 * lread.c: Make symbols static if they're not exported.
10255 (read_objects, initial_obarray, oblookup_last_bucket_number):
10257 (make_symbol): Remove; unused.
10258 * lisp.h (initial_obarray, make_symbol): Remove decls.
10260 * keyboard.c: Make symbols static if they're not exported.
10261 (single_kboard, recent_keys_index, total_keys, recent_keys):
10262 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
10263 (this_single_command_key_start, echoing, last_auto_save):
10264 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
10265 (command_loop, echo_now, keyboard_init_hook, help_char_p):
10266 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
10267 (Vlispy_mouse_stem, double_click_count):
10269 (force_auto_save_soon): Define only if SIGDANGER.
10270 (ignore_mouse_drag_p): Now static if
10271 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
10272 (print_help): Remove; unused.
10273 (stop_character, last_timer_event): Mark as externally visible.
10274 * keyboard.h (ignore_mouse_drag_p): Declare only if
10275 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
10276 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
10277 * lisp.h (echoing): Remove decl.
10278 (force_auto_save_soon): Declare only if SIGDANGER.
10279 * xdisp.c (redisplay_window): Simplify code, to make it more
10280 obvious that ignore_mouse_drag_p is not accessed if !defined
10281 USE_GTK && !defined HAVE_NS.
10283 * intervals.c: Make symbols static if they're not exported.
10284 (merge_properties_sticky, merge_interval_right, delete_interval):
10286 * intervals.h (merge_interval_right, delete_interval): Remove decls.
10288 * insdel.c: Make symbols static if they're not exported.
10289 However, leave prepare_to_modify_buffer alone. It's never
10290 called from outside this function, but that appears to be a bug.
10291 (combine_after_change_list, combine_after_change_buffer):
10292 (adjust_after_replace, signal_before_change): Now static.
10293 (adjust_after_replace_noundo): Remove; unused.
10294 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
10295 (signal_before_change): Remove decls.
10297 * indent.c (val_compute_motion, val_vmotion): Now static.
10299 * image.c: Make symbols static if they're not exported.
10300 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
10302 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
10303 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
10305 * fringe.c (standard_bitmaps): Now static.
10306 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
10308 * frame.c: Make symbols static if they're not exported.
10309 (x_report_frame_params, make_terminal_frame): Now static.
10310 (get_frame_param): Now static, unless HAVE_NS.
10311 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
10312 (x_get_resource_string): Remove; not used.
10313 * frame.h (make_terminal_frame, x_report_frame_params):
10314 (x_get_resource_string); Remove decls.
10315 (x_fullscreen_adjust): Declare only if WINDOWSNT.
10316 * lisp.h (get_frame_param): Declare only if HAVE_NS.
10318 * font.c, fontset.c: Make symbols static if they're not exported.
10319 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
10320 (FACE_SUITABLE_FOR_CHAR_P): Use it.
10321 * font.c (font_close_object): Now static.
10322 * font.h (font_close_object): Remove.
10323 * fontset.c (FONTSET_OBJLIST): Remove.
10324 (free_realized_fontset) #if-0 the body, which does nothing.
10325 (face_suitable_for_char_p): #if-0, as it's never called.
10326 * fontset.h (face_suitable_for_char_p): Remove decl.
10327 * xfaces.c (face_at_string_position):
10328 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
10329 since 0 is always ASCII.
10331 * fns.c (weak_hash_tables): Now static.
10333 * fileio.c: Make symbols static if they're not exported.
10334 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
10335 (Vwrite_region_annotation_buffers): Now static.
10337 * eval.c: Make symbols static if they're not exported.
10338 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
10339 * lisp.h (backtrace_list): Remove decl.
10341 * emacs.c: Make symbols static if they're not exported.
10342 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
10343 (fatal_error_code, fatal_error_signal_hook, standard_args):
10345 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
10346 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
10347 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
10348 * lisp.h (fatal_error_signal_hook): Remove decl.
10349 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
10351 * editfns.c: Move a (normally-unused) function to its only use.
10352 * editfns.c, lisp.h (get_operating_system_release): Remove.
10353 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
10354 worth the hassle of breaking this out.
10356 * xterm.c: Make symbols static if they're not exported.
10357 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
10358 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
10359 (x_destroy_window, x_delete_display):
10361 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
10362 (x_mouse_leave): Remove; unused.
10363 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
10364 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
10365 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
10367 (x_mouse_leave): Declare only if WINDOWSNT.
10368 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
10369 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
10372 * ftxfont.c: Make symbols static if they're not exported.
10373 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
10375 * font.h (ftxfont_driver): Likewise.
10377 * xfns.c: Make symbols static if they're not exported.
10378 (x_last_font_name, x_display_info_for_name):
10379 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
10380 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
10381 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
10382 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
10383 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
10384 (last_show_tip_args): Now static.
10385 (xic_defaut_fontset, xic_create_fontsetname): Define only if
10386 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
10387 (x_screen_planes): Remove; unused.
10388 * dispextern.h (x_screen_planes): Remove decl.
10390 * dispnew.c: Make symbols static if they're not exported.
10391 * dispextern.h (redraw_garbaged_frames, scrolling):
10392 (increment_row_positions): Remove.
10393 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
10394 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
10396 (redraw_garbaged_frames): Remove; unused.
10398 * xfaces.c: Make symbols static if they're not exported.
10399 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
10401 * xterm.h (defined_color): Remove decls.
10402 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
10403 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
10404 (menu_face_changed_default, defined_color, free_realized_face):
10405 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
10406 (ascii_face_of_lisp_face): Remove; unused.
10408 * xdisp.c: Make symbols static if they're not exported.
10409 * dispextern.h (scratch_glyph_row, window_box_edges):
10410 (glyph_to_pixel_coords, set_cursor_from_row):
10411 (get_next_display_element, set_iterator_to_next):
10412 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
10413 (show_mouse_face): Remove decls
10414 * frame.h (message_buf_print): Likewise.
10415 * lisp.h (pop_message, set_message, check_point_in_composition):
10417 * xterm.h (set_vertical_scroll_bar): Likewise.
10418 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
10419 (message_buf_print, scratch_glyph_row, displayed_buffer):
10420 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
10421 (get_next_display_element, show_mouse_face, window_box_edges):
10422 (frame_to_window_pixel_xy, check_point_in_composition):
10423 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
10424 (glyph_to_pixel_coords): Remove; unused.
10426 * dired.c (file_name_completion): Now static.
10428 * dbusbind.c (xd_in_read_queued_messages): Now static.
10430 * lisp.h (circular_list_error, FOREACH): Remove; unused.
10431 * data.c (circular_list_error): Remove.
10433 * commands.h (last_point_position, last_point_position_buffer):
10434 (last_point_position_window): Remove decls.
10435 * keyboard.c: Make these variables static.
10437 * coding.h (coding, code_convert_region, encode_coding_gap):
10439 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
10440 (iso_code_class, detect_coding, code_convert_region): Now static.
10441 (encode_coding_gap): Remove; unused.
10443 * chartab.c (chartab_chars, chartab_bits): Now static.
10445 * charset.h (charset_iso_8859_1): Remove decl.
10446 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
10449 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
10450 * ccl.c (Vccl_program_table): Now static.
10451 (check_ccl_update): Remove; unused.
10453 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
10454 * category.h: ... from here.
10455 * category.c (check_category_table, set_category_set): Now static.
10457 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
10458 * lisp.h: Remove these decls.
10460 * buffer.c (buffer_count): Remove unused var.
10462 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
10463 so that it's not optimized away.
10464 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
10465 * dispextern.h (bidi_dump_cached_states): Remove, since it's
10466 exported only to the debugger.
10468 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
10469 * atimer.h (run_all_atimers): Remove; not exported.
10471 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
10472 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
10473 was inaccessible from Lisp.
10474 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
10475 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
10477 alloc.c: Import and export fewer symbols, and remove unused items.
10478 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
10480 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
10481 it's not optimized away by whole-program optimization.
10482 (message_enable_multibyte, free_misc): Remove.
10483 (catchlist, handlerlist, mark_backtrace):
10484 Declare only if BYTE_MARK_STACK.
10485 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
10486 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
10487 (message_enable_multibyte): Remove decl.
10488 (free_misc, interval_free_list, float_block, float_block_index):
10489 (n_float_blocks, float_free_list, cons_block, cons_block_index):
10490 (cons_free_list, last_marked_index):
10492 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
10493 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
10494 (mark_backtrace): Define only if BYTE_MARK_STACK.
10495 * xdisp.c (message_enable_multibyte): Now static.
10497 Declare Lisp_Object Q* variables to be 'static' if not exported.
10498 This makes it easier for human readers (and static analyzers)
10499 to see whether these variables are used from other modules.
10500 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
10501 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
10502 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
10503 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
10504 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
10505 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
10506 * xmenu.c, xselect.c:
10507 Declare Q* vars static if they are not used in other modules.
10508 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
10509 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
10510 Remove decls of unexported vars.
10511 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
10513 * lisp.h (DEFINE_FUNC): Make sname 'static'.
10515 Make Emacs functions such as Fatom 'static' by default.
10516 This makes it easier for human readers (and static analyzers)
10517 to see whether these functions can be called from other modules.
10518 DEFUN now defines a static function. To make the function external
10519 so that it can be used in other C modules, use the new macro DEFUE.
10520 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
10521 (Finit_image_library):
10522 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
10523 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
10524 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
10525 Remove decls, since these functions are now static.
10526 (Funintern, Fget_internal_run_time): New decls, since these functions
10527 were already external.
10529 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
10530 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
10531 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
10532 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
10533 * keyboard.c, keymap.c, lread.c:
10534 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
10535 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
10536 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
10537 Mark functions with DEFUE instead of DEFUN,
10538 if they are used in other modules.
10539 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
10540 decls for now-static functions.
10541 * buffer.h (Fdelete_overlay): Remove decl.
10542 * callproc.c (Fgetenv_internal): Mark as internal.
10543 * composite.c (Fremove_list_of_text_properties): Remove decl.
10544 (Fcomposition_get_gstring): New forward static decl.
10545 * composite.h (Fcomposite_get_gstring): Remove decl.
10546 * dired.c (Ffile_attributes): New forward static decl.
10547 * doc.c (Fdocumntation_property): New forward static decl.
10548 * eval.c (Ffetch_bytecode): New forward static decl.
10549 (Funintern): Remove extern decl; now in .h file where it belongs.
10550 * fileio.c (Fmake_symbolic_link): New forward static decl.
10551 * image.c (Finit_image_library): New forward static decl.
10552 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
10553 * intervals.h (Fprevious_property_change):
10554 (Fremove_list_of_text_properties): Remove decls.
10555 * keyboard.c (Fthis_command_keys): Remove decl.
10556 (Fcommand_execute): New forward static decl.
10557 * keymap.c (Flookup_key): New forward static decl.
10558 (Fcopy_keymap): Now static.
10559 * keymap.h (Flookup_key): Remove decl.
10560 * process.c (Fget_process): New forward static decl.
10561 (Fprocess_datagram_address): Mark as internal.
10562 * syntax.c (Fsyntax_table_p): New forward static decl.
10563 (skip_chars): Remove duplicate decl.
10564 * textprop.c (Fprevious_property_change): New forward static decl.
10565 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
10567 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
10568 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
10570 * editfns.c (Fformat): Remove unreachable code.
10572 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
10574 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
10577 2011-04-13 Eli Zaretskii <eliz@gnu.org>
10579 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
10580 when at ZV. (Bug#8487)
10582 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
10584 * charset.c (Fclear_charset_maps): Use xfree instead of free.
10586 * keyboard.c (parse_tool_bar_item): Likewise.
10587 * sound.c (sound_cleanup, alsa_close): Likewise.
10588 * termcap.c (tgetent): Likewise.
10589 * xfns.c (x_default_font_parameter): Likewise.
10590 * xsettings.c (read_and_apply_settings): Likewise.
10592 * alloc.c (overrun_check_malloc, overrun_check_realloc)
10593 (overrun_check_free): Protoize.
10595 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
10597 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
10598 since callers should never pass a negative size.
10599 Change the signature to match that of plain 'read' and 'write'; see
10600 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
10601 * lisp.h: Update prototypes of emacs_write and emacs_read.
10603 2011-04-11 Eli Zaretskii <eliz@gnu.org>
10605 * xdisp.c (redisplay_window): Don't try to determine the character
10606 position of the scroll margin if the window start point w->startp
10607 is outside the buffer's accessible region. (Bug#8468)
10609 2011-04-10 Eli Zaretskii <eliz@gnu.org>
10611 Fix write-region and its subroutines for buffers > 2GB.
10612 * fileio.c (a_write, e_write): Modify declaration of arguments and
10613 local variables to support buffers larger than 2GB.
10614 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
10616 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
10617 argument, local variables, and return value.
10619 * lisp.h: Update prototypes of emacs_write and emacs_read.
10621 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
10623 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
10625 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
10627 Fix more problems found by GCC 4.6.0's static checks.
10629 * xdisp.c (vmessage): Use a better test for character truncation.
10631 * charset.c (load_charset_map): <, not <=, for optimization,
10632 and to avoid potential problems with integer overflow.
10633 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
10634 * casetab.c (set_identity, shuffle): Likewise.
10635 * editfns.c (Fformat): Likewise.
10636 * syntax.c (skip_chars): Likewise.
10638 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
10639 This also lets GCC 4.6.0 generate slightly better loop code.
10641 * callint.c (Fcall_interactively): <, not <=, for optimization.
10642 (Fcall_interactively): Count the number of arguments produced,
10643 not the number of arguments given. This is simpler and lets GCC
10644 4.6.0 generate slightly better code.
10646 * ftfont.c: Distingish more carefully between FcChar8 and char.
10647 The previous code passed unsigned char * to a functions like
10648 strlen and xstrcasecmp that expect char *, which does not
10649 conform to the C standard.
10650 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
10651 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
10652 char * when the C standard requires it.
10654 * keyboard.c (read_char): Remove unused var.
10656 * eval.c: Port to Windows vsnprintf (Bug#8435).
10657 Include <limits.h>.
10658 (SIZE_MAX): Define if the headers do not.
10659 (verror): Do not give up if vsnprintf returns a negative count.
10660 Instead, grow the buffer. This ports to Windows vsnprintf, which
10661 does not conform to C99. Problem reported by Eli Zaretskii.
10662 Also, simplify the allocation scheme, by avoiding the need for
10663 calling realloc, and removing the ALLOCATED variable.
10665 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
10667 Remove invocations of doprnt, as Emacs now uses vsnprintf.
10668 But keep the doprint source code for now, as we might revamp it
10669 and use it again (Bug#8435).
10670 * lisp.h (doprnt): Remove.
10671 * Makefile.in (base_obj): Remove doprnt.o.
10672 * deps.mk (doprnt.o): Remove.
10674 error: Print 32- and 64-bit integers portably (Bug#8435).
10675 Without this change, on typical 64-bit hosts error ("...%d...", N)
10676 was used to print both 32- and 64-bit integers N, which relied on
10677 undefined behavior.
10678 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
10679 * lisp.h (error, verror): Mark as printf-like functions.
10680 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
10681 Report overflow in size calculations when allocating printf buffer.
10682 Do not truncate output string at its first null byte.
10683 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
10684 Truncate the output at a character boundary, since vsnprintf does not
10686 * charset.c (check_iso_charset_parameter): Convert internal
10687 character to string before calling 'error', since %c now has the
10689 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
10690 overflow when computing char to be passed to 'error'. Do not
10691 pass Lisp_Object to 'error'; pass the integer instead.
10692 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
10693 formatted with plain %d.
10695 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
10697 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
10699 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
10701 * xterm.c (x_catch_errors): Remove duplicate declaration.
10703 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
10705 * xdisp.c, lisp.h (message_nolog): Remove; unused.
10707 2011-04-10 Jim Meyering <meyering@redhat.com>
10709 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
10710 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
10711 return ssize_t not "int", and use size_t as the buffer length.
10712 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
10713 * gnutls.h: Update declarations.
10714 * process.c (read_process_output): Use ssize_t, to match.
10715 (send_process): Likewise.
10717 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
10719 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
10721 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
10723 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
10724 Use unsigned char, to match FcChar8 type definition.
10726 * xterm.c (handle_one_xevent):
10727 * xmenu.c (create_and_show_popup_menu):
10728 * xselect.c (x_decline_selection_request)
10729 (x_reply_selection_request): Avoid type-punned deref of X events.
10731 2011-04-09 Eli Zaretskii <eliz@gnu.org>
10733 Fix some uses of `int' instead of EMACS_INT.
10734 * search.c (string_match_1, fast_string_match)
10735 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
10736 (scan_buffer, find_next_newline_no_quit)
10737 (find_before_next_newline, search_command, Freplace_match)
10738 (Fmatch_data): Make some `int' variables be EMACS_INT.
10740 * xdisp.c (display_count_lines): 3rd argument and return value now
10741 EMACS_INT. All callers changed.
10742 (pint2hrstr): Last argument is now EMACS_INT.
10744 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
10745 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
10746 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
10747 (decode_coding_utf_16, decode_coding_emacs_mule)
10748 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
10749 (decode_coding_ccl, decode_coding_charset)
10750 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
10751 (decode_coding_iso_2022, decode_coding_emacs_mule)
10752 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
10753 <char_offset, last_offset>: Declare EMACS_INT.
10754 (encode_coding_utf_8, encode_coding_utf_16)
10755 (encode_coding_emacs_mule, encode_invocation_designation)
10756 (encode_designation_at_bol, encode_coding_iso_2022)
10757 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
10758 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
10760 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
10761 (encode_invocation_designation): Last argument P_NCHARS is now
10763 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
10764 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
10766 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
10769 * ccl.c (Fccl_execute_on_string): Declare some variables
10772 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
10774 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
10776 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
10778 * process.c (Fformat_network_address): Doc fix.
10780 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
10782 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
10784 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
10786 * keyboard.c (read_char): Call Lisp function help-form-show,
10787 instead of using internal_with_output_to_temp_buffer.
10788 (Qhelp_form_show): New var.
10789 (syms_of_keyboard): Use DEFSYM macro.
10791 * print.c (internal_with_output_to_temp_buffer): Function deleted.
10793 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
10795 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
10797 * process.c (Flist_processes): Remove to Lisp.
10798 (list_processes_1): Delete.
10800 2011-04-06 Eli Zaretskii <eliz@gnu.org>
10802 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
10804 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
10806 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
10808 Fix more problems found by GCC 4.6.0's static checks.
10810 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
10812 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
10814 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
10816 * xdisp.c (vmessage): Mark as a printf-like function.
10818 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
10820 * sound.c (sound_warning): Don't crash if arg contains a printf format.
10822 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
10823 printf-like functions.
10824 (tiff_load): Add casts to remove these marks before passing them
10825 to system-supplied API.
10827 * eval.c (Fsignal): Remove excess argument to 'fatal'.
10829 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
10830 This avoids several warnings with gcc -Wstrict-overflow.
10831 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
10832 directly, rather than having caller test rule sign. This avoids
10833 some unnecessary tests.
10834 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
10835 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
10836 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
10838 * xfont.c (xfont_text_extents): Remove var that was set but not used.
10839 (xfont_open): Avoid unnecessary tests.
10841 * composite.c (composition_gstring_put_cache): Use unsigned integer.
10843 * composite.h, composite.c (composition_gstring_put_cache):
10844 Use EMACS_INT, not int, for length.
10846 * composite.h (COMPOSITION_DECODE_REFS): New macro,
10847 breaking out part of COMPOSITION_DECODE_RULE.
10848 (COMPOSITION_DECODE_RULE): Use it.
10849 * composite.c (get_composition_id): Remove unused local vars,
10850 by using the new macro.
10852 * textprop.c (set_text_properties_1): Change while to do-while,
10853 since the condition is always true at first.
10855 * intervals.c (graft_intervals_into_buffer): Mark var as used.
10856 (interval_deletion_adjustment): Return unsigned value.
10859 * process.c (list_processes_1, create_pty, read_process_output):
10860 (exec_sentinel): Remove vars that were set but not used.
10861 (create_pty): Remove unnecessary "volatile"s.
10862 (Fnetwork_interface_info): Avoid possibility of int overflow.
10863 (read_process_output): Do adaptive read buffering even if carryover.
10864 (read_process_output): Simplify nbytes computation if buffered.
10866 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
10868 * syntax.c (scan_words): Remove var that was set but not used.
10869 (update_syntax_table): Use unsigned instead of int.
10871 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
10872 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
10873 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
10875 * print.c (print_error_message): Avoid int overflow.
10877 * font.c (font_list_entities): Redo for clarity,
10878 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
10880 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
10881 (font_score): Avoid potential overflow in diff calculation.
10883 * fns.c (substring_both): Remove var that is set but not used.
10884 (sxhash): Redo loop for clarity and to avoid wraparound warning.
10886 * eval.c (funcall_lambda): Rename local to avoid shadowing.
10888 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
10889 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
10890 can always succeed if overflow has undefined behavior.
10892 * search.c (boyer_moore, wordify): Remove vars set but not used.
10893 (wordify): Omit three unnecessary tests.
10895 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
10896 All callers changed. This avoids the need for an unused var.
10898 * casefiddle.c (casify_region): Remove var that is set but not used.
10900 * dired.c (file_name_completion): Remove var that is set but not used.
10902 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
10904 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
10905 (Finsert_file_contents): Remove unnecessary code checking fd.
10907 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
10908 Check for integer overflow on size calculations.
10910 * buffer.c (Fprevious_overlay_change): Remove var that is set
10913 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
10914 Remove vars that are set but not used.
10915 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
10916 (timer_check_2): Mark vars as initialized.
10918 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
10920 * image.c (lookup_image): Remove var that is set but not used.
10921 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
10923 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
10924 that are set but not used.
10926 * xfns.c (make_invisible_cursor): Don't return garbage
10927 if XCreateBitmapFromData fails (Bug#8410).
10929 * xselect.c (x_get_local_selection, x_handle_property_notify):
10930 Remove vars that are set but not used.
10932 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
10933 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
10935 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
10936 Remove var that is set but not used.
10937 (scroll_bar_windows_size): Now size_t, not int.
10938 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
10939 Check for overflow.
10941 * xfaces.c (realize_named_face): Remove vars that are set but not used.
10942 (map_tty_color) [!defined MSDOS]: Likewise.
10944 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
10946 * coding.c: Remove vars that are set but not used.
10947 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
10948 All callers changed.
10949 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
10950 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
10951 (decode_coding_charset): Remove vars that are set but not used.
10953 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
10954 that is set but not used.
10956 * print.c (print_object): Remove var that is set but not used.
10958 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
10959 The gnulib version avoids calling malloc in the usual case,
10960 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
10961 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
10962 * filelock.c (current_lock_owner): Likewise.
10963 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
10964 * sysdep.c: Include allocator.h, careadlinkat.h.
10965 (emacs_no_realloc_allocator): New static constant.
10966 (emacs_readlink): New function.
10967 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
10968 ../lib/careadlinkat.h.
10970 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
10972 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
10973 first non-nil return value).
10975 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
10977 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
10978 if not defined (Bug#8403).
10980 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
10982 * xdisp.c (display_count_lines): Remove parameter `start',
10983 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10984 (get_char_face_and_encoding): Remove parameter `multibyte_p',
10985 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10986 (fill_stretch_glyph_string): Remove parameters `row' and `area',
10987 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
10988 and thereabouts. All callers changed.
10989 (get_per_char_metric): Remove parameter `f', unused since
10990 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10992 2011-04-02 Jim Meyering <meyering@redhat.com>
10994 do not dereference NULL upon failed strdup
10995 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
10996 (ns_get_family): Likewise.
10998 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
11000 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
11002 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
11004 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
11007 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
11009 Add lexical binding.
11011 * window.c (Ftemp_output_buffer_show): New fun.
11012 (Fsave_window_excursion):
11013 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
11015 * lread.c (lisp_file_lexically_bound_p): New function.
11016 (Fload): Bind Qlexical_binding.
11017 (readevalloop): Remove `evalfun' arg.
11018 Bind Qinternal_interpreter_environment.
11019 (Feval_buffer): Bind Qlexical_binding.
11020 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
11022 (syms_of_lread): Declare `lexical-binding'.
11024 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
11026 * keyboard.c (eval_dyn): New fun.
11027 (menu_item_eval_property): Use it.
11029 * image.c (parse_image_spec): Use Ffunctionp.
11031 * fns.c (concat, mapcar1): Accept byte-code-functions.
11033 * eval.c (Fsetq): Handle lexical vars.
11034 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
11035 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
11036 (FletX, Flet): Obey lexical binding.
11037 (Fcommandp): Handle closures.
11038 (Feval): New `lexical' arg.
11039 (eval_sub): New function extracted from Feval. Use it almost
11040 everywhere where Feval was used. Look up vars in lexical env.
11042 (Ffunctionp): Move from subr.el.
11043 (Ffuncall): Handle closures.
11044 (apply_lambda): Remove `eval_flags'.
11045 (funcall_lambda): Handle closures and new byte-code-functions.
11046 (Fspecial_variable_p): New function.
11047 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
11048 but without exporting it to Lisp.
11050 * doc.c (Fdocumentation, store_function_docstring):
11051 * data.c (Finteractive_form): Handle closures.
11053 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
11056 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
11058 (exec_byte_code): New function extracted from Fbyte_code to handle new
11059 calling convention for byte-code-functions. Add new byte-codes.
11061 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
11063 * alloc.c (Fmake_symbol): Init new `declared_special' field.
11065 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
11067 * xdisp.c (redisplay_internal): Fix prototype.
11069 2011-03-31 Eli Zaretskii <eliz@gnu.org>
11071 * xdisp.c (SCROLL_LIMIT): New macro.
11072 (try_scrolling): Use it when setting scroll_limit.
11073 Limit scrolling to 100 screen lines.
11074 (redisplay_window): Even when falling back on "recentering",
11075 position point in the window according to scroll-conservatively,
11076 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
11078 (try_scrolling): When point is above the window, allow searching
11079 as far as scroll_max, or one screenful, to compute vertical
11080 distance from PT to the scroll margin position. This prevents
11081 try_scrolling from unnecessarily failing when
11082 scroll-conservatively is set to a value slightly larger than the
11083 window height. Clean up the case of PT below the margin at bottom
11084 of window: scroll_max can no longer be INT_MAX. When aggressive
11085 scrolling is in use, don't let point enter the opposite scroll
11086 margin as result of the scroll.
11087 (syms_of_xdisp) <scroll-conservatively>: Document the
11088 threshold of 100 lines for never-recentering scrolling.
11090 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
11092 * dispextern.h (move_it_by_lines):
11093 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
11094 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
11095 (message_log_check_duplicate): Remove parameters `prev_bol' and
11096 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11097 (redisplay_internal): Remove parameter `preserve_echo_area',
11098 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
11100 * indent.c (Fvertical_motion):
11101 * window.c (window_scroll_pixel_based, Frecenter):
11102 Don't pass `need_y_p' to `move_it_by_lines'.
11104 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
11106 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
11107 steal a few bits to be more compact.
11108 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
11109 Remove unneeded casts.
11111 * bytecode.c (Fbyte_code): CAR and CDR can GC.
11113 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
11115 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
11116 binding" message (bug#7967).
11118 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
11120 Fix more problems found by GCC 4.6.0's static checks.
11122 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
11123 Remove unused local var.
11125 * editfns.c (Fmessage_box): Remove unused local var.
11127 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
11128 (note_mode_line_or_margin_highlight, note_mouse_highlight):
11129 Omit unused local vars.
11130 * window.c (shrink_windows): Omit unused local var.
11131 * menu.c (digest_single_submenu): Omit unused local var.
11132 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
11133 Omit unused local var.
11135 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
11136 Don't assume string length fits in int.
11137 (keyremap_step, read_key_sequence): Use size_t for sizes.
11138 (read_key_sequence): Don't check last_real_key_start redundantly.
11140 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
11141 instead of alloca (Bug#8344).
11143 * eval.c (Fbacktrace): Don't assume nargs fits in int.
11144 (Fbacktrace_frame): Don't assume nframes fits in int.
11146 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
11148 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
11151 * term.c (produce_glyphless_glyph): Remove unnecessary test.
11153 * cm.c (calccost): Turn while-do into do-while, for clarity.
11155 * keyboard.c (syms_of_keyboard): Use the same style as later
11156 in this function when indexing through an array. This also
11157 works around GCC bug 48267.
11159 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
11161 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
11163 * chartab.c (sub_char_table_ref_and_range): Redo for slight
11164 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
11166 * keyboard.c, keyboard.h (num_input_events): Now size_t.
11167 This avoids undefined behavior on integer overflow, and is a bit
11168 more convenient anyway since it is compared to a size_t variable.
11170 Variadic C functions now count arguments with size_t, not int.
11171 This avoids an unnecessary limitation on 64-bit machines, which
11172 caused (substring ...) to crash on large vectors (Bug#8344).
11173 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
11174 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
11175 All variadic functions and their callers changed accordingly.
11176 (struct gcpro.nvars): Now size_t, not int. All uses changed.
11177 * data.c (arith_driver, float_arith_driver): Likewise.
11178 * editfns.c (general_insert_function): Likewise.
11179 * eval.c (struct backtrace.nargs, interactive_p)
11180 (internal_condition_case_n, run_hook_with_args, apply_lambda)
11181 (funcall_lambda, mark_backtrace): Likewise.
11182 * fns.c (concat): Likewise.
11183 * frame.c (x_set_frame_parameters): Likewise.
11184 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
11185 0 if not found, not -1. All callers changed.
11187 * alloc.c (garbage_collect): Don't assume stack size fits in int.
11188 (stack_copy_size): Now size_t, not int.
11189 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
11191 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
11193 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
11194 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11195 All callers changed.
11197 * lisp.h (multibyte_char_to_unibyte):
11198 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
11199 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11200 * character.h (CHAR_TO_BYTE8):
11201 * cmds.c (internal_self_insert):
11202 * editfns.c (general_insert_function):
11203 * keymap.c (push_key_description):
11204 * search.c (Freplace_match):
11205 * xdisp.c (message_dolog, set_message_1): All callers changed.
11207 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
11209 * keyboard.c (safe_run_hook_funcall): New function.
11210 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
11211 don't set the hook to nil, but remove the offending function instead.
11212 (Qcommand_hook_internal): Remove, unused.
11213 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
11214 Vcommand_hook_internal.
11216 * eval.c (enum run_hooks_condition): Remove.
11217 (funcall_nil, funcall_not): New functions.
11218 (run_hook_with_args): Call each function through a `funcall' argument.
11219 Remove `cond' argument, now redundant.
11220 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
11221 (Frun_hook_with_args_until_failure): Adjust accordingly.
11222 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
11224 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
11226 * dispextern.h (string_buffer_position): Remove declaration.
11228 * print.c (strout): Remove parameter `multibyte', unused since
11229 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
11231 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
11232 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
11233 All callers changed.
11235 * w32.c (_wsa_errlist): Use braces for struct initializers.
11237 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
11238 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
11239 All callers changed.
11240 (string_buffer_position): Likewise. Also, make static (it's never
11241 used outside xdisp.c).
11242 (cursor_row_p): Remove parameter `w', unused since
11243 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
11244 (decode_mode_spec): Remove parameter `precision', introduced during
11245 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
11246 All callers changed.
11248 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11250 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
11252 2011-03-27 Anders Lindgren <andlind@gmail.com>
11254 * nsterm.m (ns_menu_bar_is_hidden): New variable.
11255 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
11256 (ns_update_auto_hide_menu_bar): New functions.
11257 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
11258 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
11259 ns_constrain_all_frames.
11260 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
11261 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
11263 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11265 * nsmenu.m (runDialogAt): Remove argument to timer_check.
11267 2011-03-27 Glenn Morris <rgm@gnu.org>
11269 * syssignal.h: Replace RETSIGTYPE with void.
11270 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
11271 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
11272 Replace SIGTYPE with void everywhere.
11273 * s/usg5-4-common.h (SIGTYPE): Remove definition.
11274 * s/template.h (SIGTYPE): Remove commented out definition.
11276 2011-03-26 Eli Zaretskii <eliz@gnu.org>
11278 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
11279 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
11281 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
11283 * w32.c (read_unc_volume): Use parameter `henum', instead of
11284 global variable `wget_enum_handle'.
11286 * keymap.c (describe_vector): Remove parameters `indices' and
11287 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
11288 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
11290 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
11292 * keyboard.c (timer_check): Remove parameter `do_it_now',
11293 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
11294 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
11295 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
11297 * keyboard.c (read_char):
11298 * w32menu.c (w32_menu_display_help):
11299 * xmenu.c (show_help_event, menu_help_callback):
11300 Adjust calls to `show_help_echo'.
11302 * gtkutil.c (xg_maybe_add_timer):
11303 * keyboard.c (readable_events):
11304 * process.c (wait_reading_process_output):
11305 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
11307 * insdel.c (adjust_markers_gap_motion):
11308 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
11309 (gap_left, gap_right): Don't call it.
11311 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
11313 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
11314 incurred during fontification.
11316 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
11318 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
11319 (DEFVAR_PER_BUFFER): Don't pass it.
11321 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
11322 (scrolling_window): Don't pass it.
11324 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
11326 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
11328 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
11330 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
11331 of variables specific to SELinux and computation of `encoded_absname'.
11333 * image.c (XPutPixel): Remove unused variable `height'.
11335 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
11337 * unexw32.c (get_section_info): Remove unused variable `section'.
11339 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
11340 (system_process_attributes): Remove unused variable `sess'.
11341 (sys_read): Remove unused variable `err'.
11343 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
11344 (w32_wnd_proc): Remove unused variable `isdead'.
11345 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
11346 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
11347 (x_create_tip_frame): Remove unused variable `tem'.
11349 * w32inevt.c (w32_console_read_socket):
11350 Remove unused variable `no_events'.
11352 * w32term.c (x_draw_composite_glyph_string_foreground):
11353 Remove unused variable `width'.
11355 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
11357 * w32term.c (x_set_glyph_string_clipping):
11358 Don't pass uninitialized region to CombineRgn.
11360 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
11362 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
11363 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
11364 (Fx_close_connection): Remove unused variable `i'.
11366 * w32font.c (w32font_draw): Return number of glyphs.
11367 (w32font_open_internal): Remove unused variable `i'.
11368 (w32font_driver): Add missing initializer.
11370 * w32menu.c (utf8to16): Remove unused variable `utf16'.
11371 (fill_in_menu): Remove unused variable `items_added'.
11373 * w32term.c (last_mouse_press_frame): Remove static global variable.
11374 (w32_clip_to_row): Remove unused variable `f'.
11375 (x_delete_terminal): Remove unused variable `i'.
11377 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
11378 (NOTHING): Remove unused static global variable.
11379 (uniscribe_check_otf): Remove unused variable `table'.
11380 (uniscribe_font_driver): Add missing initializers.
11382 2011-03-23 Julien Danjou <julien@danjou.info>
11384 * term.c (Fsuspend_tty, Fresume_tty):
11385 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
11386 * window.c (temp_output_buffer_show):
11387 * insdel.c (signal_before_change):
11388 * frame.c (Fhandle_switch_frame):
11389 * fileio.c (Fdo_auto_save):
11390 * emacs.c (Fkill_emacs):
11391 * editfns.c (save_excursion_restore):
11392 * cmds.c (internal_self_insert):
11393 * callint.c (Fcall_interactively):
11394 * buffer.c (Fkill_all_local_variables):
11395 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
11397 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
11398 unconditionally since it does the check itself.
11400 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
11402 Fix more problems found by GCC 4.5.2's static checks.
11404 * coding.c (encode_coding_raw_text): Avoid unnecessary test
11405 the first time through the loop, since we know p0 < p1 then.
11406 This also avoids a gcc -Wstrict-overflow warning.
11408 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
11409 leading to a memory leak, possible in functions like
11410 load_charset_map_from_file that can allocate an unbounded number
11411 of objects (Bug#8318).
11413 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
11414 that could (at least in theory) be that large.
11416 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
11417 This is less likely to overflow, and avoids undefined behavior if
11418 overflow does occur. All callers changed. Use strtoul to scan
11419 for the unsigned long integer.
11420 (pint2hrstr): Simplify and tune code slightly.
11421 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
11423 * scroll.c (do_scrolling): Work around GCC bug 48228.
11424 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
11426 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
11427 This also avoids a warning with gcc -Wstrict-overflow.
11428 (validate_x_resource_name): Simplify count usage.
11429 This also avoids a warning with gcc -Wstrict-overflow.
11431 * fileio.c (Fcopy_file): Report error if fchown or fchmod
11434 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
11436 * process.c (Fmake_network_process): Use socklen_t, not int,
11437 where POSIX says socklen_t is required in portable programs.
11438 This fixes a porting bug on hosts like 64-bit HP-UX, where
11439 socklen_t is wider than int (Bug#8277).
11440 (Fmake_network_process, server_accept_connection):
11441 (wait_reading_process_output, read_process_output):
11444 * process.c: Rename or move locals to avoid shadowing.
11445 (list_processes_1, Fmake_network_process):
11446 (read_process_output_error_handler, exec_sentinel_error_handler):
11447 Rename or move locals.
11448 (Fmake_network_process): Define label "retry_connect" only if needed.
11449 (Fnetwork_interface_info): Fix pointer signedness.
11450 (process_send_signal): Add cast to avoid pointer signedness problem.
11451 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
11452 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
11454 Make tparam.h and terminfo.c consistent.
11455 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
11456 Include tparam.h instead, since it declares them.
11457 * cm.h (PC): Remove extern decl; tparam.h now does this.
11458 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
11459 * terminfo.c: Include tparam.h, to check interfaces.
11460 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
11461 (tparam): Adjust signature to match interface in tparam.h;
11462 this removes some undefined behavior. Check that outstring and len
11463 are zero, which they always are with Emacs.
11464 * tparam.h (PC, BC, UP): New extern decls.
11466 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
11467 (xftfont_open): Rename locals to avoid shadowing.
11469 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
11470 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
11471 (OTF_TAG_SYM): Omit macro if not needed.
11472 (ftfont_list): Remove unused local.
11473 (get_adstyle_property, ftfont_pattern_entity):
11474 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
11475 Rename locals to avoid shadowing.
11477 * xfont.c (xfont_list_family): Mark var as initialized.
11479 * xml.c (make_dom): Now static.
11481 * composite.c (composition_compute_stop_pos): Rename local to
11483 (composition_reseat_it): Remove unused locals.
11484 (find_automatic_composition, composition_adjust_point): Likewise.
11485 (composition_update_it): Mark var as initialized.
11486 (find_automatic_composition): Mark vars as initialized,
11487 with a FIXME (Bug#8290).
11489 character.h: Rename locals to avoid shadowing.
11490 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
11491 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
11492 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
11493 (BUF_DEC_POS): Be more systematic about renaming local temporaries
11494 to avoid shadowing.
11496 * textprop.c (property_change_between_p): Remove; unused.
11498 * intervals.c (interval_start_pos): Now static.
11500 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
11502 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
11503 Rename locals to avoid shadowing.
11505 * sound.c (wav_play, au_play, Fplay_sound_internal):
11506 Fix pointer signedness.
11507 (alsa_choose_format): Remove unused local var.
11508 (wav_play): Initialize a variable to 0, to prevent undefined
11509 behavior (Bug#8278).
11511 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
11513 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
11515 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
11516 clobbering (Bug#8298).
11517 * sysdep.c (sys_subshell): Likewise.
11518 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
11520 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
11521 This should get cleaned up, so that child_setup has the
11522 same signature on all platforms.
11524 * callproc.c (call_process_cleanup): Now static.
11525 (relocate_fd): Rename locals to avoid shadowing.
11527 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
11529 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
11530 not to be necessary, and produces flickering.
11532 2011-03-20 Glenn Morris <rgm@gnu.org>
11534 * config.in: Remove file.
11536 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
11538 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
11539 are now in src/globals.h.
11540 (syms_of_minibuf): Remove spurious & from previous change.
11542 2011-03-20 Leo Liu <sdl.web@gmail.com>
11544 * minibuf.c (completing-read-function): New variable.
11545 (completing-read-default): Rename from completing-read.
11546 (completing-read): Call completing-read-function.
11548 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
11550 * xfaces.c (Fx_load_color_file):
11551 Read color file from absolute filename (bug#8250).
11553 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
11555 * makefile.w32-in: Update dependencies.
11557 2011-03-17 Eli Zaretskii <eliz@gnu.org>
11559 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
11561 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
11563 Fix more problems found by GCC 4.5.2's static checks.
11565 * process.c (make_serial_process_unwind, send_process_trap):
11566 (sigchld_handler): Now static.
11568 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
11569 That way, the code declares only the vars that it needs.
11570 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
11571 * s/cygwin.h (PTY_ITERATION): Likewise.
11572 * s/darwin.h (PTY_ITERATION): Likewise.
11573 * s/gnu-linux.h (PTY_ITERATION): Likewise.
11575 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
11576 * process.c (allocate_pty): Don't declare stb unless it's needed.
11578 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
11579 (CONSTANTLIM): Remove; unused.
11580 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
11581 Define only if needed.
11583 * unexelf.c (unexec): Name an expression,
11584 to avoid gcc -Wbad-function-cast warning.
11585 Use a different way to cause a compilation error if anyone uses
11586 n rather than nn, a way that does not involve shadowing.
11587 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
11589 * deps.mk (unexalpha.o): Remove; unused.
11591 New file unexec.h, the (simple) interface for unexec (Bug#8267).
11592 * unexec.h: New file.
11593 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
11594 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
11595 Depend on unexec.h.
11596 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
11597 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
11598 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
11599 Change as necessary to match prototype in unexec.h.
11601 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
11603 (back_comment, skip_chars): Mark vars as initialized.
11605 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
11606 Rename locals to avoid shadowing.
11608 * lread.c (read1): Rewrite so as not to use empty "else".
11609 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
11611 * print.c (Fredirect_debugging_output): Fix pointer signedess.
11613 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
11614 warning when compiling print.c.
11616 * font.c (font_unparse_fcname): Abort in an "impossible" situation
11617 instead of using an uninitialized var.
11618 (font_sort_entities): Mark var as initialized.
11620 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
11622 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
11623 pointers to constants.
11624 (font_parse_fcname): Remove unused vars.
11625 (font_delete_unmatched): Now static.
11626 (font_get_spec): Remove; unused.
11627 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
11628 (font_update_drivers, Ffont_get_glyphs, font_add_log):
11629 Rename or move locals to avoid shadowing.
11631 * fns.c (require_nesting_list, require_unwind): Now static.
11632 (Ffillarray): Rename locals to avoid shadowing.
11634 * floatfns.c (domain_error2): Define only if needed.
11635 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
11637 * alloc.c (mark_backtrace): Move decl from here ...
11638 * lisp.h: ... to here, so that it can be checked.
11640 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
11641 (Fdefvar): Rewrite so as not to use empty "else".
11642 (lisp_indirect_variable): Name an expression,
11643 to avoid gcc -Wbad-function-cast warning.
11644 (Fdefvar): Rename locals to avoid shadowing.
11646 * callint.c (quotify_arg, quotify_args): Now static.
11647 (Fcall_interactively): Rename locals to avoid shadowing.
11648 Use const pointer when appropriate.
11650 * lisp.h (get_system_name, get_operating_system_release):
11651 Move decls here, to check interfaces.
11652 * process.c (get_operating_system_release): Move decl to lisp.h.
11653 * xrdb.c (get_system_name): Likewise.
11654 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
11655 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
11656 some of which prompt warnings from gcc -Wbad-function-cast.
11657 (Fformat_time_string, Fencode_time, Finsert_char):
11658 (Ftranslate_region_internal, Fformat):
11659 Rename or remove local vars to avoid shadowing.
11660 (Ftranslate_region_internal): Mark var as initialized.
11662 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
11665 * lisp.h (eassert): Check that the argument compiles, even if
11666 ENABLE_CHECKING is not defined.
11668 * data.c (Findirect_variable): Name an expression, to avoid
11669 gcc -Wbad-function-cast warning.
11670 (default_value, arithcompare, arith_driver, arith_error): Now static.
11671 (store_symval_forwarding): Rename local to avoid shadowing.
11672 (Fmake_variable_buffer_local, Fmake_local_variable):
11673 Mark variables as initialized.
11674 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
11676 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
11677 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
11678 Rename locals to avoid shadowing.
11679 (mark_stack): Move local variables into the #ifdef region where
11681 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
11682 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
11684 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
11685 (GC_STRING_CHARS): Remove; not used.
11686 (Fmemory_limit): Cast sbrk's returned value to char *.
11688 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
11689 avoids undefined behavior in theory.
11691 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
11693 Use functions, not macros, for up- and down-casing (Bug#8254).
11694 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11695 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
11696 to use the following functions instead of these macros.
11697 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
11698 EMACS_INT, since callers assume the returned value fits in int.
11699 (upcase1): Likewise, for UPCASE_TABLE.
11700 (uppercasep, lowercasep, upcase): New static inline functions.
11701 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
11702 the race-condition problem in the old DOWNCASE.
11704 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
11705 Rename locals to avoid shadowing.
11706 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
11707 (regex_compile, re_search_2, re_match_2_internal):
11708 Remove unused local vars.
11709 (FREE_VAR): Rewrite so as not to use empty "else",
11710 which gcc can warn about.
11711 (regex_compile, re_match_2_internal): Mark locals as initialized.
11712 (RETALLOC_IF): Define only if needed.
11713 (WORDCHAR_P): Likewise. This one is never needed, but is used
11714 only in a comment talking about a compiler bug, so put inside
11715 the #if 0 of that comment.
11716 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
11717 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
11720 * search.c (boyer_moore): Rename locals to avoid shadowing.
11721 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
11722 (PREV_CHAR_BOUNDARY): Likewise.
11724 * search.c (simple_search): Remove unused var.
11726 * dired.c (compile_pattern): Move decl from here ...
11727 * lisp.h: ... to here, so that it can be checked.
11728 (struct re_registers): New forward decl.
11730 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
11732 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
11734 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
11735 Rename locals to avoid shadowing.
11736 (Fvertical_motion): Mark locals as initialized.
11738 * casefiddle.c (casify_object, casify_region): Now static.
11739 (casify_region): Mark local as initialized.
11741 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
11743 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
11744 New macros, so that the caller can use some names other than
11745 gcpro1, gcpro2, etc.
11746 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
11748 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
11749 argument, for consistency with GCPRO2_VAR, etc: it is now the
11750 prefix of the variable, not the variable itself. All uses
11752 * dired.c (directory_files_internal, file_name_completion):
11753 Rename locals to avoid shadowing.
11755 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
11756 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
11757 dired.c's scmp function, had undefined behavior.
11758 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11759 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
11760 * buffer.h: ... to here, because these macros use current_buffer,
11761 and the new implementation with inline functions needs to have
11762 current_buffer in scope now, rather than later when the macros
11764 (downcase, upcase1): New static inline functions.
11765 (DOWNCASE, UPCASE1): Reimplement using these functions.
11766 This avoids undefined behavior in expressions like
11767 DOWNCASE (x) == DOWNCASE (y), which previously suffered
11768 from race conditions in accessing the global variables
11769 case_temp1 and case_temp2.
11770 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
11771 * lisp.h (case_temp1, case_temp2): Remove their decls.
11772 * character.h (ASCII_CHAR_P): Move from here ...
11773 * lisp.h: ... to here, so that the inline functions mentioned
11774 above can use them.
11776 * dired.c (directory_files_internal_unwind): Now static.
11778 * fileio.c (file_name_as_directory, directory_file_name):
11779 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
11781 (file_name_as_directory): Use const pointers when appropriate.
11782 (Fexpand_file_name): Likewise. In particular, newdir might
11783 point at constant storage, so make it a const pointer.
11784 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
11785 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
11787 (Fset_file_times, Finsert_file_contents, auto_save_error):
11788 Rename locals to avoid shadowing.
11790 * minibuf.c (choose_minibuf_frame_1): Now static.
11791 (Ftry_completion, Fall_completions): Rename or remove locals
11792 to avoid shadowing.
11794 * marker.c (bytepos_to_charpos): Remove; unused.
11796 * lisp.h (verify_bytepos, count_markers): New decls,
11797 so that gcc does not warn that these functions aren't declared.
11799 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
11800 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
11801 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
11802 (copy_text): Remove unused local var.
11804 * filelock.c (within_one_second): Now static.
11805 (lock_file_1): Rename local to avoid shadowing.
11807 * buffer.c (fix_overlays_before): Mark locals as initialized.
11808 (fix_start_end_in_overlays): Likewise. This function should be
11809 simplified by using pointers-to-pointers, but that's a different
11811 (switch_to_buffer_1): Now static.
11812 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
11813 (report_overlay_modification): Rename locals to avoid shadowing.
11815 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
11816 Fix pointer signedness issue.
11817 (sys_subshell): Mark local as volatile if checking for lint,
11818 to suppress a gcc -Wclobbered warning that does not seem to be right.
11819 (MAXPATHLEN): Define only if needed.
11821 * process.c (serial_open, serial_configure): Move decls from here ...
11822 * systty.h: ... to here, so that they can be checked.
11824 * fns.c (get_random, seed_random): Move extern decls from here ...
11825 * lisp.h: ... to here, so that they can be checked.
11827 * sysdep.c (reset_io): Now static.
11828 (wait_for_termination_signal): Remove; unused.
11830 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
11831 (copy_keymap_item, append_key, push_text_char_description):
11833 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
11834 (DENSE_TABLE_SIZE): Remove; unused.
11835 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
11836 (describe_map_tree):
11837 Rename locals to avoid shadowing.
11839 * keyboard.c: Declare functions static if they are not used elsewhere.
11840 (echo_char, echo_dash, cmd_error, top_level_2):
11841 (poll_for_input, handle_async_input): Now static.
11842 (read_char, kbd_buffer_get_event, make_lispy_position):
11843 (make_lispy_event, make_lispy_movement, apply_modifiers):
11844 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
11845 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
11846 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
11847 (read_key_sequence, read_char): Mark locals as initialized.
11848 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
11850 * keyboard.h (make_ctrl_char): New decl.
11851 (mark_kboards): Move decl here ...
11852 * alloc.c (mark_kboards): ... from here.
11854 * lisp.h (force_auto_save_soon): New decl.
11856 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
11857 (DEFINE_DUMMY_FUNCTION): New macro.
11858 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
11860 (main): Add casts to avoid warnings
11861 if GCC considers string literals to be constants.
11863 * lisp.h (fatal_error_signal): Add decl, since it's exported.
11865 * dbusbind.c: Pointer signedness fixes.
11866 (xd_signature, xd_append_arg, xd_initialize):
11867 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11868 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11869 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
11870 (Fdbus_register_signal): Use SSDATA when the context wants char *.
11872 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
11873 if GCC considers string literals to be constants.
11874 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
11876 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
11878 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
11879 (print_preprocess, print_object): New macro to fix last change.
11881 * print.c (print_preprocess): Don't forget font objects.
11883 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
11885 * emacs.c (USAGE3): Doc fixes.
11887 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
11889 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
11892 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
11894 * lisp.h (VWindow_system, Qfile_name_history):
11895 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
11896 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
11897 (w32_system_caret_x, w32_system_caret_y): Declare extern.
11899 * w32select.c: Don't #include "keyboard.h".
11900 (run_protected): Add extern declaration for waiting_for_input.
11902 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
11903 * w32console.c (detect_input_pending, read_input_pending)
11904 (encode_terminal_code):
11905 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
11906 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
11907 (w32_system_caret_y, Qfile_name_history):
11908 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
11909 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
11910 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
11911 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
11912 * w32proc.c (Qlocal, report_file_error):
11913 * w32term.c (Vwindow_system, updating_frame):
11914 * w32uniscribe.c (initialized, uniscribe_font_driver):
11915 Remove unneeded extern declarations.
11917 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
11919 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
11921 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
11923 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
11924 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
11925 These macros can no longer be used for assignment.
11927 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
11928 Assign struct members directly, instead of using BUF_BEGV etc.
11929 (record_buffer_markers, fetch_buffer_markers): New functions for
11930 recording and fetching special buffer markers.
11931 (set_buffer_internal_1, set_buffer_temp): Use them.
11933 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
11935 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
11937 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
11938 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
11940 * xdisp.c (hscroll_window_tree):
11941 (reconsider_clip_changes): Use PT instead of BUF_PT.
11943 2011-03-13 Eli Zaretskii <eliz@gnu.org>
11945 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
11946 $(EMACS_ROOT)/lib/intprops.h.
11948 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
11950 Fix more problems found by GCC 4.5.2's static checks.
11952 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
11953 to unsigned char * to avoid compiler diagnostic.
11954 (xg_free_frame_widgets): Make it clear that a local variable is
11955 needed only if USE_GTK_TOOLTIP.
11956 (gdk_window_get_screen): Make it clear that this macro is needed
11957 only if USE_GTK_TOOLTIP.
11958 (int_gtk_range_get_value): New function, which avoids a diagnostic
11959 from gcc -Wbad-function-cast.
11960 (xg_set_toolkit_scroll_bar_thumb): Use it.
11961 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
11962 diagnostic from gcc -Wbad-function-cast.
11963 (get_utf8_string, xg_get_file_with_chooser):
11964 Rename locals to avoid shadowing.
11965 (create_dialog): Move locals to avoid shadowing.
11967 * xgselect.c (xg_select): Remove unused var.
11969 * image.c (four_corners_best): Mark locals as initialized.
11970 (gif_load): Initialize transparent_p to zero (Bug#8238).
11971 Mark another local as initialized.
11972 (my_png_error, my_error_exit): Mark with NO_RETURN.
11974 * image.c (clear_image_cache): Now static.
11975 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
11976 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
11977 (x_edge_detection): Remove unnecessary cast that
11978 gcc -Wbad-function-cast diagnoses.
11979 (gif_load): Fix pointer signedness.
11980 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
11981 (jpeg_load, gif_load): Rename locals to avoid shadowing.
11983 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
11985 Improve quality of tests for time stamp overflow.
11986 For example, without this patch (encode-time 0 0 0 1 1
11987 1152921504606846976) returns the obviously-bogus value (-948597
11988 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
11989 reports time overflow. See
11990 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
11991 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
11992 * editfns.c: Include limits.h and intprops.h.
11993 (TIME_T_MIN, TIME_T_MAX): New macros.
11994 (time_overflow): Move earlier, to before first use.
11995 (hi_time, lo_time): New functions, for an accurate test for
11996 out-of-range times.
11997 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
11998 (Fget_internal_run_time): Don't assume time_t fits in int.
11999 (make_time): Use list2 instead of Fcons twice.
12000 (Fdecode_time): More accurate test for out-of-range times.
12001 (check_tm_member): New function.
12002 (Fencode_time): Use it, to test for out-of-range times.
12003 (lisp_time_argument): Don't rely on undefined left-shift and
12004 right-shift behavior when checking for time stamp overflow.
12006 * editfns.c (time_overflow): New function, refactoring common code.
12007 (Fformat_time_string, Fdecode_time, Fencode_time):
12008 (Fcurrent_time_string): Use it.
12010 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
12011 * dired.c (make_time): Move to ...
12012 * editfns.c (make_time): ... here.
12013 * systime.h: Note the move.
12015 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
12017 * fringe.c (update_window_fringes): Remove unused variables.
12019 * unexmacosx.c (copy_data_segment): Also copy __got section.
12022 2011-03-12 Eli Zaretskii <eliz@gnu.org>
12024 * termcap.c [MSDOS]: Include "msdos.h".
12025 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
12026 Constify `char *' arguments and their references according to
12027 prototypes in tparam.h.
12029 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
12031 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
12032 Adapt all references accordingly.
12034 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
12036 2011-03-11 Tom Tromey <tromey@redhat.com>
12038 * buffer.c (syms_of_buffer): Remove obsolete comment.
12040 2011-03-11 Eli Zaretskii <eliz@gnu.org>
12042 * termhooks.h (encode_terminal_code): Declare prototype.
12044 * msdos.c (encode_terminal_code): Don't declare prototype.
12046 * term.c (encode_terminal_code): Now external again, used by
12047 w32console.c and msdos.c.
12049 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
12050 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
12052 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
12054 Fix some minor problems found by GCC 4.5.2's static checks.
12056 * fringe.c (update_window_fringes): Mark locals as initialized
12058 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
12060 * alloc.c (mark_fringe_data): Move decl from here ...
12061 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
12062 to check its interface.
12063 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
12065 * fontset.c (free_realized_fontset): Now static.
12066 (Fset_fontset_font): Rename local to avoid shadowing.
12067 (fontset_font): Mark local as initialized.
12068 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
12070 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
12072 * xselect.c (x_disown_buffer_selections): Remove; not used.
12073 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
12074 (x_own_selection, Fx_disown_selection_internal): Rename locals
12075 to avoid shadowing.
12076 (x_handle_dnd_message): Remove local to avoid shadowing.
12078 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
12079 so that the caller can use some name other than gcpro1.
12080 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
12081 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12082 (Fx_backspace_delete_keys_p):
12083 Use them to avoid shadowing, and rename vars to avoid shadowing.
12084 (x_decode_color, x_set_name, x_window): Now static.
12085 (Fx_create_frame): Add braces to silence GCC warning.
12086 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
12087 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
12088 Remove unused locals.
12089 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12090 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
12091 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
12094 * xterm.h (x_mouse_leave): New decl.
12096 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
12097 Remove unused functions.
12098 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
12099 (x_calc_absolute_position): Now static.
12100 (XTread_socket): Don't define label "out" unless it's used.
12101 Don't declare local "event" unless it's used.
12102 (x_iconify_frame, x_free_frame_resources): Don't declare locals
12103 unless they are used.
12104 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
12105 (x_fatal_error_signal): Remove; not used.
12106 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
12107 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
12108 (x_error_catcher, x_connection_closed, x_error_handler):
12109 (x_error_quitter, xembed_send_message, x_iconify_frame):
12110 (my_log_handler): Rename locals to avoid shadowing.
12111 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
12112 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
12114 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
12115 Rename or move locals to avoid shadowing.
12116 (tty_defined_color, merge_face_heights): Now static.
12117 (free_realized_faces_for_fontset): Remove; not used.
12118 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
12119 does not deduce is never used uninitialized.
12120 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
12121 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
12123 * terminal.c (store_terminal_param): Now static.
12125 * xmenu.c (menu_highlight_callback): Now static.
12126 (set_frame_menubar): Remove unused local.
12127 (xmenu_show): Rename parameter to avoid shadowing.
12128 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
12129 since they might point to immutable storage.
12130 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
12131 since it's unused otherwise.
12133 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
12134 Add a FIXME, since the code still doesn't look right. (Bug#8215)
12135 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
12136 avoids a gcc -Wuninitialized diagnostic.
12137 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
12138 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
12139 does not deduce are never used uninitialized.
12141 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
12143 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
12144 * window.c (window_loop, size_window):
12145 (run_window_configuration_change_hook, enlarge_window): Likewise.
12147 * window.c (display_buffer): Now static.
12148 (size_window): Mark variables that gcc -Wuninitialized
12149 does not deduce are never used uninitialized.
12150 * window.h (check_all_windows): New decl, to forestall
12151 gcc -Wmissing-prototypes diagnostic.
12152 * dispextern.h (bidi_dump_cached_states): Likewise.
12154 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
12156 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
12157 Include <limits.h>.
12158 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
12159 and to avoid gcc -Wuninitialized warning.
12160 (load_charset_map): Mark variables that gcc -Wuninitialized
12161 does not deduce are never used uninitialized.
12162 (load_charset): Abort instead of using uninitialized var (Bug#8229).
12164 * coding.c (coding_set_source, coding_set_destination):
12165 Use "else { /* comment */ }" rather than "else /* comment */;"
12166 for clarity, and to avoid gcc -Wempty-body warning.
12167 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
12168 a block, when the outer 'i' will do.
12169 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
12170 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
12171 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
12172 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
12173 (Fdecode_sjis_char, Fdefine_coding_system_internal):
12174 Rename locals to avoid shadowing.
12175 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
12176 * coding.c (emacs_mule_char, encode_invocation_designation):
12177 Now static, since they're not used elsewhere.
12178 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
12179 (decode_coding_object, encode_coding_object, detect_coding_system):
12180 (decode_coding_emacs_mule): Mark variables that gcc
12181 -Wuninitialized does not deduce are never used uninitialized.
12182 (detect_coding_iso_2022): Initialize a local variable that might
12183 be used uninitialized. Leave a FIXME because it's not clear that
12184 this initialization is needed. (Bug#8211)
12185 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
12186 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
12187 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
12188 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
12189 Remove unused macros.
12191 * category.c (hash_get_category_set): Remove unused local var.
12192 (copy_category_table): Now static, since it's not used elsewhere.
12193 * character.c (string_count_byte8): Likewise.
12195 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
12196 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
12198 * chartab.c (copy_sub_char_table): Now static, since it's not used
12200 (sub_char_table_ref_and_range, char_table_ref_and_range):
12201 Rename locals to avoid shadowing.
12202 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
12204 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
12205 (BIDI_BOB): Remove unused macro.
12207 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
12208 deduce are never used uninitialized.
12209 * term.c (encode_terminal_code): Likewise.
12211 * term.c (encode_terminal_code): Now static. Remove unused local.
12213 * tparam.h: New file.
12214 * term.c, tparam.h: Include it.
12215 * deps.mk (term.o, tparam.o): Depend on tparam.h.
12216 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
12217 Move these decls to tparam.h, and make them agree with what
12218 is actually in tparam.c. The previous trick of using incompatible
12219 decls in different modules does not conform to the C standard.
12220 All callers of tparam changed to use tparam's actual API.
12221 * tparam.c (tparam1, tparam, tgoto):
12222 Use const pointers where appropriate.
12224 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
12225 * cm.h (struct cm): Likewise.
12226 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
12227 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
12228 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
12229 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
12230 (turn_on_face, init_tty): Likewise.
12231 * termchar.h (struct tty_display_info): Likewise.
12233 * term.c (term_mouse_position): Rename local to avoid shadowing.
12235 * alloc.c (mark_ttys): Move decl from here ...
12236 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
12238 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
12240 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
12242 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
12244 * search.c (compile_pattern_1): Remove argument regp, unused since
12245 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
12246 (compile_pattern): Don't pass it.
12248 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
12250 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
12251 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
12253 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
12255 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
12257 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
12258 gdk_window_get_screen, gdk_window_get_geometry,
12259 gdk_x11_window_lookup_for_display and GDK_KEY_g.
12260 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
12261 (xg_get_pixbuf_from_pixmap): New function.
12262 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
12263 to Pixmap, take frame as parameter, remove GdkColormap parameter.
12264 Call xg_get_pixbuf_from_pixmap instead of
12265 gdk_pixbuf_get_from_drawable.
12266 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
12267 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
12268 (xg_check_special_colors): Use GtkStyleContext and its functions
12270 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
12271 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
12272 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
12273 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
12274 Call gtk_widget_get_preferred_size.
12275 (xg_frame_resized): gdk_window_get_geometry only takes 5
12277 (xg_win_to_widget, xg_event_is_for_menubar):
12278 Call gdk_x11_window_lookup_for_display.
12279 (xg_set_widget_bg): New function.
12280 (delete_cb): New function.
12281 (xg_create_frame_widgets): Connect delete-event to delete_cb.
12282 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
12283 (xg_set_background_color): Call xg_set_widget_bg.
12284 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
12285 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
12286 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
12287 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
12289 (update_frame_tool_bar): Call gtk_widget_hide.
12290 (xg_initialize): Use GDK_KEY_g.
12292 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
12294 (x_session_initialize): Call gdk_x11_set_sm_client_id.
12296 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
12297 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
12298 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
12300 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
12302 * w32xfns.c (select_palette): Check success of RealizePalette against
12303 GDI_ERROR, not zero.
12305 See ChangeLog.11 for earlier changes.
12307 ;; Local Variables:
12311 Copyright (C) 2011-2012 Free Software Foundation, Inc.
12313 This file is part of GNU Emacs.
12315 GNU Emacs is free software: you can redistribute it and/or modify
12316 it under the terms of the GNU General Public License as published by
12317 the Free Software Foundation, either version 3 of the License, or
12318 (at your option) any later version.
12320 GNU Emacs is distributed in the hope that it will be useful,
12321 but WITHOUT ANY WARRANTY; without even the implied warranty of
12322 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12323 GNU General Public License for more details.
12325 You should have received a copy of the GNU General Public License
12326 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.