]> code.delx.au - gnu-emacs/blob - src/ChangeLog
Merge from trunk.
[gnu-emacs] / src / ChangeLog
1 2011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2
3 * Require libxml/parser.h to avoid compilation warning.
4
5 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
6
7 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
8 since this reportedly can destroy thread storage.
9
10 2011-08-30 Chong Yidong <cyd@stupidchicken.com>
11
12 * syntax.c (find_defun_start): Update all cache variables if
13 exiting early (Bug#9401).
14
15 2011-08-30 Eli Zaretskii <eliz@gnu.org>
16
17 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
18
19 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
20 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
21 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
22
23 * term.c (tty_append_glyph): New function.
24 (produce_stretch_glyph): Static function and its prototype deleted.
25
26 * dispextern.h (produce_stretch_glyph, tty_append_glyph): Add
27 prototypes.
28
29 2011-08-29 Paul Eggert <eggert@cs.ucla.edu>
30
31 * image.c (parse_image_spec): Check for nonnegative, not for positive,
32 when checking :margin (Bug#9390).
33 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
34 Renamed from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
35 so that the name doesn't mislead. All uses changed.
36
37 2011-08-28 Johan Bockgård <bojohan@gnu.org>
38
39 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
40 set_tty_hooks.
41
42 2011-08-27 Eli Zaretskii <eliz@gnu.org>
43
44 * xdisp.c (move_it_to): Don't bail out early when reaching
45 position beyond to_charpos, if we are scanning backwards.
46 (move_it_vertically_backward): When DY == 0, make sure we get to
47 the first character in the line after the newline.
48
49 2011-08-27 Paul Eggert <eggert@cs.ucla.edu>
50
51 * ccl.c: Improve and simplify overflow checking (Bug#9196).
52 (ccl_driver): Do not generate an out-of-range pointer.
53 (Fccl_execute_on_string): Remove unnecessary check for
54 integer overflow, noted by Stefan Monnier in
55 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
56 Remove a FIXME that didn't need fixing.
57 Simplify the newly-introduced buffer reallocation code.
58
59 2011-08-27 Juanma Barranquero <lekktu@gmail.com>
60
61 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
62
63 2011-08-26 Paul Eggert <eggert@cs.ucla.edu>
64
65 Integer and memory overflow issues (Bug#9196).
66
67 * doc.c (get_doc_string): Rework so that
68 get_doc_string_buffer_size is the actual buffer size, rather than
69 being 1 less than the actual buffer size; this makes xpalloc more
70 convenient.
71
72 * image.c (x_allocate_bitmap_record, cache_image):
73 * xselect.c (Fx_register_dnd_atom):
74 Simplify previous changes by using xpalloc.
75
76 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
77 since either will do and ptrdiff_t is convenient with xpalloc.
78
79 * charset.c (charset_table_size)
80 (struct charset_sort_data.priority): Now ptrdiff_t.
81 (charset_compare): Don't overflow if priorities differ greatly.
82 (Fsort_charsets): Don't assume list length fits in int.
83 Check for size-calculation overflow when allocating sort data.
84 (syms_of_charset): Allocate an initial charset table that is
85 just under 64 KiB, to avoid problems with glibc malloc and mmap.
86
87 * cmds.c (internal_self_insert): Check for size-calculation overflow.
88
89 * composite.h (struct composition.glyph_len): Now int, not unsigned.
90 The actual value is always <= INT_MAX, and leaving it unsigned made
91 overflow checking harder.
92
93 * dispextern.h (struct glyph_matrix.rows_allocated)
94 (struct face_cache.size): Now ptrdiff_t, for convenience in use
95 with xpalloc. The values are still always <= INT_MAX.
96
97 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
98
99 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
100 (SAFE_NALLOCA): New macro.
101
102 * region-cache.c (struct boundary.pos, find_cache_boundary)
103 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
104 (set_cache_region, invalidate_region_cache)
105 (revalidate_region_cache, know_region_cache, region_cache_forward)
106 (region_cache_backward, pp_cache):
107 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
108 so that ptrdiff_t * can be passed to xpalloc.
109 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
110 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
111 (pp_cache): Don't assume cache_len fits in int.
112 * region-cache.h: Adjust extern decls to match.
113
114 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
115 EMACS_INT, since either will do, for xpalloc.
116
117 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
118 (xnmalloc, xnrealloc, xpalloc): New functions.
119
120 * bidi.c (bidi_shelve_header_size): New constant.
121 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
122 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
123
124 * bidi.c (bidi_cache_shrink):
125 * buffer.c (overlays_at, overlays_in, record_overlay_string)
126 (overlay_strings):
127 Don't update size of array until after memory allocation succeeds,
128 because xmalloc/xrealloc may not return.
129 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
130 now that we have proper integer overflow checking.
131 (record_overlay_string, overlay_strings): Catch overflows when
132 calculating size of overlay_str_buf.
133
134 * callproc.c (Fcall_process): Check for size overflow when
135 calculating size of args2.
136 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
137 Normally we prefer signed values, but sticking with ptrdiff_t would
138 require adding more-complicated checks.
139
140 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
141 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
142 Redo buffer-overflow calculations to avoid integer overflow.
143 Add a FIXME comment where memory seems to be over-allocated.
144
145 * character.c (Fstring): Check for size-calculation overflow.
146
147 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
148 unnecessary integer overflow. Check for size overflow.
149 (encode_coding_object): Don't update size until xmalloc succeeds.
150
151 * composite.c (get_composition_id): Check for overflow in glyph
152 length calculations.
153
154 Integer and memory overflow fixes for display code.
155 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
156 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
157 (scrolling_window): Check for overflow in size calculations.
158 (line_draw_cost, realloc_glyph_pool, add_row_entry):
159 Don't assume glyph table len fits in int.
160 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
161 (row_table_size): Now ptrdiff_t, not int.
162 (scrolling_window): Avoid overflow in size calculations.
163 Don't update size until allocation succeeds.
164 * fns.c (concat): Check for overflow in size calculations.
165 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
166 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
167 (NEXT_ALMOST_PRIME_LIMIT): New constant.
168
169 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
170 (get_doc_string): Check for size calculation overflow.
171 Don't update size until allocation succeeds.
172 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
173 EMACS_INT, where ptrdiff_t will do.
174 (Fsubstitute_command_keys): Check for string overflow.
175
176 * editfns.c (set_time_zone_rule): Don't assume environment length
177 fits in int.
178 (message_length): Now ptrdiff_t, not int.
179 (Fmessage_box): Don't update size until allocation succeeds.
180 Don't assume message length fits in int.
181 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
182
183 * emacs.c (main): Do not reallocate argv, since there is a null at
184 the end that can be overwritten, and this way there's no need to
185 worry about size-calculation overflow.
186 (sort_args): Check for size-calculation overflow.
187
188 * eval.c (init_eval_once, grow_specpdl): Don't update size until
189 alloc succeeds.
190 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
191
192 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
193 (x_set_scroll_bar_width, x_figure_window_size):
194 Check for integer overflow.
195 (x_set_alpha): Do not assume XINT fits in int.
196
197 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
198 This is for the members text_lines, text_cols, total_lines, total_cols,
199 where the system imposes an 'int' limit.
200
201 * fringe.c (Fdefine_fringe_bitmap):
202 Don't update size until alloc works.
203
204 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
205 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
206
207 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
208 Check for size-calculation overflow.
209 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
210 do, as we prefer signed integers.
211 (id_to_widget.max_size, id_to_widget.used)
212 (xg_store_widget_in_map, xg_remove_widget_from_map)
213 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
214 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
215 Use and return ptrdiff_t, not int.
216 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
217 * gtkutil.h: Change prototypes to match the above.
218
219 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
220 are duplicate now that they've been promoted to lisp.h.
221 (x_allocate_bitmap_record, x_alloc_image_color)
222 (make_image_cache, cache_image, xpm_load):
223 Don't update size until alloc is done.
224 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
225 (x_detect_edges):
226 Check for size calculation overflow.
227 (ct_colors_allocated_max): New constant.
228 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
229 overflow.
230
231 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
232 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
233 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
234 Use ptrdiff_t, not int, to count maps.
235 (read_char_minibuf_menu_prompt): Check for overflow in size
236 calculations. Don't update size until allocation succeeds. Redo
237 calculations to avoid overflow.
238 * keyboard.h: Change prototypes to match the above.
239
240 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
241 to count maps.
242 (current_minor_maps): Check for size calculation overflow.
243 * keymap.h: Change prototypes to match the above.
244
245 * lread.c (read1, init_obarray): Don't update size until alloc done.
246
247 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
248 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
249
250 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
251 Now ptrdiff_t, not int.
252 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
253 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
254
255 * process.c (Fnetwork_interface_list): Check for overflow
256 in size calculation.
257
258 * region-cache.c (move_cache_gap): Check for size calculation overflow.
259
260 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
261 overflow. Don't bother calling xmalloc when xrealloc will do.
262
263 * search.c (Freplace_match): Check for size calculation overflow.
264 (Fset_match_data): Don't assume list lengths fit in 'int'.
265
266 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
267 for command line length. Do not attempt to address one before the
268 beginning of an array, as that's not portable.
269
270 * term.c (max_frame_lines): Remove; unused.
271 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
272 not int.
273 (encode_terminal_code, calculate_costs): Check for size
274 calculation overflow.
275 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
276 table lengths and related sizes. Don't update size until alloc
277 done. Redo calculations to avoid overflow.
278 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
279
280 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
281 subtracting pointers.
282 (gobble_line): Check for overflow more carefully. Don't update size
283 until alloc done.
284
285 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
286 Don't update size until alloc done.
287 Redo size calculations to avoid overflow.
288 Check for size calculation overflow.
289 (main) [DEBUG]: Fix typo in invoking tparam1.
290
291 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
292 Use ptrdiff_t, not int, for sizes.
293 (store_mode_line_noprop_char): Don't update size until alloc done.
294
295 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
296 Use ptrdiff_t, not int, for sizes.
297 (Finternal_make_lisp_face, cache_face):
298 Check for size calculation overflow.
299 (cache_face): Treat size calculation overflows as if they were
300 memory exhaustion (the usual treatment), rather than aborting.
301
302 * xfns.c (x_encode_text, x_set_name_internal)
303 (Fx_change_window_property): Use ptrdiff_t, not int, to count
304 sizes, since they can exceed INT_MAX in size. Check for size
305 calculation overflow.
306
307 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
308 (xg_select): Check for size calculation overflow.
309 Don't update size until alloc done.
310
311 * xrdb.c (get_environ_db): Don't assume path length fits in int,
312 as sprintf is limited to int lengths.
313
314 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
315 (X_LONG_MIN): New macros.
316 Use them to make the following changes clearer.
317 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
318 This change doesn't affect the value now, but it may help remind
319 future maintainers not to raise the value too much later.
320 (SELECTION_QUANTUM): Remove, replacing with ...
321 (selection_quantum): ... new function, which avoids overflow.
322 All uses changed.
323 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
324 assumption that selection length fits in 'int'.
325 (x_reply_selection_request, x_handle_selection_request)
326 (x_get_window_property, receive_incremental_selection)
327 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
328 (lisp_data_to_selection_data, clean_local_selection_data):
329 Use ptrdiff_t, not int, to record length of selection.
330 (x_reply_selection_request, x_get_window_property)
331 (receive_incremental_selection, x_property_data_to_lisp):
332 Redo calculations to avoid overflow.
333 (x_reply_selection_request): When sending hint, ceiling it at
334 X_LONG_MAX rather than relying on wraparound overflow to send
335 something.
336 (x_get_window_property, receive_incremental_selection)
337 (lisp_data_to_selection_data, x_property_data_to_lisp):
338 Check for size-calculation overflow.
339 (x_get_window_property, receive_incremental_selection)
340 (lisp_data_to_selection_data, Fx_register_dnd_atom):
341 Don't store size until memory allocation succeeds.
342 (x_get_window_property): Plug memory leak on memory exhaustion.
343 Don't double-block input; malloc is safe here. Don't assume 2**34
344 - 4 fits in unsigned long. Add an xassert to check
345 XGetWindowProperty overflow. Be more careful about overflow
346 calculations, and distinguish size from memory overflow better.
347 (receive_incremental_selection): When tracing, don't assume
348 unsigned int is less than INT_MAX.
349 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
350 harmful) conversions of unsigned short to int.
351 (lisp_data_to_selection_data): Don't assume that integers
352 in the range -65535 through -1 fit in an X unsigned short.
353 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
354 result parameters unless successful. Rely on cons_to_unsigned
355 to report problems with elements; the old code wasn't right anyway.
356 (x_check_property_data): Check for int overflow; we cannot use
357 a wider type due to X limits.
358 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
359
360 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
361
362 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
363 (x_term_init): Check for size calculation overflow.
364 (x_color_cells): Don't store size until memory allocation succeeds.
365 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
366 Don't assume alloca size is less than MAX_ALLOCA.
367 (x_term_init): Don't assume length fits in int (sprintf is limited
368 to int size).
369
370 Use ptrdiff_t for composition IDs.
371 * character.c (lisp_string_width):
372 * composite.c (composition_table_size, n_compositions)
373 (get_composition_id, composition_gstring_from_id):
374 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
375 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
376 * window.c (Frecenter):
377 Use ptrdiff_t, not int, for composition IDs.
378 * composite.c (get_composition_id): Check for integer overflow.
379 * composite.h: Adjust prototypes to match the above changes.
380
381 Use ptrdiff_t for hash table indexes.
382 * category.c (hash_get_category_set):
383 * ccl.c (ccl_driver):
384 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
385 * coding.c (coding_system_charset_list, detect_coding_system):
386 * coding.h (struct coding_system.id):
387 * composite.c (get_composition_id, gstring_lookup_cache):
388 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
389 * image.c (xpm_get_color_table_h):
390 * lisp.h (hash_lookup, hash_put):
391 * minibuf.c (Ftest_completion):
392 Use ptrdiff_t for hash table indexes, not int (which is too
393 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
394 32-bit --with-wide-int hosts).
395
396 * charset.c (Fdefine_charset_internal): Check for integer overflow.
397 Add a FIXME comment about memory leaks.
398 (syms_of_charset): Don't assume xmalloc returns.
399
400 Don't assume that stated character widths fit in int.
401 * character.c (Fchar_width, c_string_width, lisp_string_width):
402 * character.h (CHAR_WIDTH):
403 * indent.c (MULTIBYTE_BYTES_WIDTH):
404 Use sanitize_char_width to avoid undefined and/or bad behavior
405 with outlandish widths.
406 * character.h (sanitize_tab_width): Renamed from sanitize_width,
407 now that we have two such functions. All uses changed.
408 (sanitize_char_width): New inline function.
409
410 Don't assume that tab-width fits in int.
411 * character.h (sanitize_width): New inline function.
412 (SANE_TAB_WIDTH): New macro.
413 (ASCII_CHAR_WIDTH): Use it.
414 * indent.c (sane_tab_width): Remove. All uses replaced by
415 SANE_TAB_WIDTH (current_buffer).
416 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
417
418 * fileio.c: Integer overflow issues with file modes.
419 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
420
421 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
422 Remove unreachable code.
423 (read_hex, load_charset_map_from_file): Check for integer overflow.
424
425 * xterm.c: don't go over XClientMessageEvent limit
426 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
427 (x_send_scroll_bar_event): Likewise. Check that the size does not
428 exceed limits imposed by XClientMessageEvent, as well as the usual
429 ptrdiff_t and size_t limits.
430
431 * keyboard.c: Overflow, signedness and related fixes.
432 (make_lispy_movement): Use same integer type in forward decl
433 that is used in the definition.
434 (read_key_sequence, keyremap_step):
435 Change bufsize argument back to int, undoing my 2011-03-30 change.
436 We prefer signed types, and int is wide enough here.
437 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
438 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
439 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
440 length, not size_t. Use ptrdiff_t for index, not int.
441 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
442 possibility of integer overflow.
443
444 Overflow, signedness and related fixes for images.
445
446 * dispextern.h (struct it.stack[0].u.image.image_id)
447 (struct_it.image_id, struct image.id, struct image_cache.size)
448 (struct image_cache.used, struct image_cache.ref_count):
449 * gtkutil.c (update_frame_tool_bar):
450 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
451 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
452 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
453 * nsmenu.m (update_frame_tool_bar):
454 * xdisp.c (calc_pixel_width_or_height):
455 * xfns.c (image_cache_refcount):
456 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
457 on typical 64-bit hosts.
458
459 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
460 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
461 Omit unnecessary casts to int.
462 (parse_image_spec): Check that integers fall into 'int' range
463 when the callers expect that.
464 (image_ascent): Redo ascent calculation to avoid int overflow.
465 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
466 (lookup_image): Remove unnecessary tests.
467 (xbm_image_p): Locals are now of int, not EMACS_INT,
468 since parse_image_check makes sure they fit into int.
469 (png_load, gif_load, svg_load_image):
470 Prefer int to unsigned where either will do.
471 (tiff_handler): New function, combining the cores of the
472 old tiff_error_handler and tiff_warning_handler. This
473 function is rewritten to use vsnprintf and thereby avoid
474 stack buffer overflows. It uses only the features of vsnprintf
475 that are common to both POSIX and native Microsoft.
476 (tiff_error_handler, tiff_warning_handler): Use it.
477 (tiff_load, gif_load, imagemagick_load_image):
478 Don't assume :index value fits in 'int'.
479 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
480 (imagemagick_load_image): Check that crop parameters fit into
481 the integer types that MagickCropImage accepts. Don't assume
482 Vimagemagick_render_type has a nonnegative value. Don't assume
483 size_t fits in 'long'.
484 (gs_load): Use printmax_t to print the widest integers possible.
485 Check for integer overflow when computing image height and width.
486
487 2011-08-26 Eli Zaretskii <eliz@gnu.org>
488
489 * xdisp.c (redisplay_window): Don't force window start if point
490 will be invisible in the resulting window. (Bug#9324)
491
492 2011-08-25 Eli Zaretskii <eliz@gnu.org>
493
494 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
495 the display spec is of the form `(space ...)'.
496 (handle_display_spec): Return the value returned by
497 handle_single_display_spec, not just 1 or zero.
498 (handle_single_display_spec): If the display spec is of the form
499 `(space ...)', and specifies display in the text area, return 2
500 rather than 1.
501 (try_cursor_movement): Check for the need to scroll more
502 accurately, and prefer exact match for point under bidi. Don't
503 advance `row' beyond the last row of the window.
504
505 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
506 into disp_prop; all users changed.
507
508 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
509 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
510 for the text covered by the display property.
511
512 2011-08-25 Chong Yidong <cyd@stupidchicken.com>
513
514 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
515 Change return value to nil.
516 (Frecord_buffer): Delete unused function.
517
518 2011-08-24 Eli Zaretskii <eliz@gnu.org>
519
520 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
521 buffers, return left-to-right.
522 (set_cursor_from_row): Consider candidate row a win if its glyph
523 represents a newline and point is on that newline. Fixes cursor
524 positioning on the newline at EOL of R2L text within L2R
525 paragraph, and vice versa.
526 (try_cursor_movement): Check continued rows, in addition to
527 continuation rows. Fixes unwarranted scroll when point enters a
528 continued line of R2L text within an L2R paragraph, or vice versa.
529 (cursor_row_p): Consider the case of point being equal to
530 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
531 from the end of a short line to the beginning of a continued line
532 of R2L text within L2R paragraph.
533 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
534 composed characters.
535
536 * bidi.c (bidi_check_type): Use xassert.
537 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
538 members.
539
540 2011-08-23 Eli Zaretskii <eliz@gnu.org>
541
542 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
543 a character.
544
545 2011-08-23 Chong Yidong <cyd@stupidchicken.com>
546
547 * nsfont.m (ns_otf_to_script): Fix typo.
548
549 2011-08-22 Kenichi Handa <handa@m17n.org>
550
551 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
552 extra slot even if the purpose is char-code-property-table.
553
554 2011-08-23 Eli Zaretskii <eliz@gnu.org>
555
556 * xdisp.c (redisplay_window): When computing centering_position,
557 account for the height of the header line. (Bug#8874)
558
559 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
560 instead of CHAR_TO_BYTE. Fixes a crash when a completion
561 candidate is selected by the mouse, and that candidate has a
562 composed character under the mouse.
563
564 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
565 coordinates reported by pos-visible-in-window-p for a composed
566 character in column zero.
567
568 2011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
569
570 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
571
572 2011-08-22 Eli Zaretskii <eliz@gnu.org>
573
574 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
575 consider it a hit if to_charpos is anywhere in the range of the
576 composed buffer positions.
577
578 2011-08-22 Chong Yidong <cyd@stupidchicken.com>
579
580 * image.c (gif_load): Don't assume that each subimage has the same
581 dimensions as the base image. Handle disposal method that is
582 "undefined" by the gif spec (Bug#9335).
583
584 2011-08-20 Chong Yidong <cyd@stupidchicken.com>
585
586 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
587 (Fcondition_case): Document `debug' symbol in error handler.
588
589 2011-08-19 Eli Zaretskii <eliz@gnu.org>
590
591 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
592 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
593 from an Org mode buffer to a Speedbar frame.
594
595 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
596 a composition, take its buffer position from IT->cmp_it.charpos.
597 Fixes cursor positioning at the beginning of a line that begins
598 with a composed character.
599
600 2011-08-18 Eli Zaretskii <eliz@gnu.org>
601
602 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
603 character bidirectional type, use STRONG_L instead. Fixes crashes
604 in a buffer produced by `describe-categories'.
605
606 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
607 members before the level stack, so they would be saved and
608 restored when copying iterator state. Fixes incorrect reordering
609 around TABs covered by display properties.
610
611 2011-08-18 Andreas Schwab <schwab@linux-m68k.org>
612
613 * process.c (Fnetwork_interface_list): Correctly determine buffer
614 size.
615
616 2011-08-17 Chong Yidong <cyd@stupidchicken.com>
617
618 * eval.c (internal_condition_case, internal_condition_case_1)
619 (internal_condition_case_2, internal_condition_case_n):
620 Remove unnecessary aborts (Bug#9081).
621
622 2011-08-17 Eli Zaretskii <eliz@gnu.org>
623
624 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
625 has no `load' handler, try opening the file locally. (Bug#9311)
626
627 2011-08-16 Ken Brown <kbrown@cornell.edu>
628
629 * gmalloc.c: Expand comment.
630
631 2011-08-16 Eli Zaretskii <eliz@gnu.org>
632
633 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
634 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
635
636 2011-08-16 Ken Brown <kbrown@cornell.edu>
637
638 Fix memory allocation problems in Cygwin build (Bug#9273).
639
640 * unexcw.c ( __malloc_initialized): Declare external variable.
641 (fixup_executable): Force the dumped emacs to reinitialize malloc.
642
643 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
644 New variables.
645 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
646 dumped emacs.
647 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
648 in the static heap.
649 [CYGWIN] (special_realloc): New function.
650 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
651 requests to realloc storage in the static heap.
652
653 2011-08-15 Paul Eggert <eggert@cs.ucla.edu>
654
655 * bidi.c (bidi_initialize): Remove unused local.
656
657 2011-08-15 Eli Zaretskii <eliz@gnu.org>
658
659 * biditype.h: File removed.
660
661 * bidimirror.h: File removed.
662
663 * deps.mk (bidi.o): Remove biditype.h and
664 bidimirror.h.
665
666 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
667 bidimirror.h.
668
669 * dispextern.h: Fix a typo in the comment to bidi_type_t.
670
671 * chartab.c: Improve commentary for the uniprop_table API.
672
673 * bidi.c (bidi_paragraph_init): Support zero value of
674 bidi_ignore_explicit_marks_for_paragraph_level.
675 (bidi_initialize): Use uniprop_table instead of including
676 biditype.h and bidimirror.h.
677
678 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
679 coordinates of the iterator when restoring from ppos_it.
680 (Bug#9296)
681
682 2011-08-14 Kenichi Handa <handa@m17n.org>
683
684 * process.c (create_process): Call setup_process_coding_systems
685 after the pid of the process is set to -1 (Bug#8162).
686
687 2011-08-14 Eli Zaretskii <eliz@gnu.org>
688
689 * xdisp.c (move_it_in_display_line_to): Don't invoke
690 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
691 ppos_it. Fixes vertical cursor motion when line beginning is
692 covered by an image. (Bug#9296)
693
694 2011-08-14 Jan Djärv <jan.h.d@swipnet.se>
695
696 * nsterm.h (ns_run_ascript): Declare.
697 (NSAPP_DATA2_RUNASSCRIPT): Define.
698
699 * nsfns.m (as_script, as_result, as_status): New static variables.
700 (ns_run_ascript): New function.
701 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
702 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
703 the event loop. Get status from as_status (Bug#7276).
704
705 * nsterm.m (sendEvent): If event is NSApplicationDefined and
706 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
707 the event loop (Bug#7276).
708
709 2011-08-14 Andreas Schwab <schwab@linux-m68k.org>
710
711 * gnutls.c (QCgnutls_bootprop_priority)
712 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
713 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
714 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
715 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
716 (QCgnutls_bootprop_verify_hostname_error)
717 (QCgnutls_bootprop_callbacks_verify): Rename from
718 Qgnutls_bootprop_..., all uses changed.
719
720 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
721 uses changed.
722
723 2011-08-14 Paul Eggert <eggert@cs.ucla.edu>
724
725 * xfaces.c (Qframe_set_background_mode): Now static.
726 * dispextern.h (Qframe_set_background_mode): Remove decl.
727
728 * process.c (Fnetwork_interface_info): Declare local only if needed.
729
730 2011-08-13 Jan Djärv <jan.h.d@swipnet.se>
731
732 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
733 (Fnetwork_interface_list): Allocate in increments of bytes instead
734 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
735 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
736 sockaddr.
737 (struct ifflag_def): notrailers is smart on OSX.
738 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
739 Get hardware address with getifaddrs if available.
740
741 2011-08-12 Eli Zaretskii <eliz@gnu.org>
742
743 * xdisp.c (iterate_out_of_display_property): xassert that
744 IT->position is set to within IT->object's boundaries. Break from
745 the loop as soon as EOB is reached; avoids infloops in redisplay
746 when IT->position is set up wrongly due to some bug.
747 Set IT->current to match the bidi iterator unconditionally.
748 (push_display_prop): Allow GET_FROM_STRING as IT->method on
749 entry. Force push_it to save on the stack the current
750 buffer/string position, to be restored by pop_it. Fix flags in
751 the iterator structure wrt the object coming from a display
752 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
753 properties. (Bug#9284)
754
755 2011-08-09 Andreas Schwab <schwab@linux-m68k.org>
756
757 * fontset.c (fontset_get_font_group): Add proper type checks.
758 (Bug#9172)
759
760 2011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
761
762 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
763 and LC_VERSION_MIN_MACOSX.
764 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
765 (dump_it) [LC_FUNCTION_STARTS]: Use it.
766
767 2011-08-08 Eli Zaretskii <eliz@gnu.org>
768
769 * xdisp.c (forward_to_next_line_start): Allow to use the
770 no-display-properties-and-no-overlays under bidi display.
771 Set disp_pos in the bidi iterator to avoid searches for display
772 properties and overlays.
773
774 2011-08-08 Chong Yidong <cyd@stupidchicken.com>
775
776 * editfns.c (Fset_time_zone_rule): Document relationship with the
777 setenv function.
778
779 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
780 the font entity extracted from the cache (Bug#8109).
781
782 2011-08-07 Chong Yidong <cyd@stupidchicken.com>
783
784 * composite.c (autocmp_chars): Don't reset point. That is done by
785 restore_point_unwind (Bug#5984).
786
787 2011-08-07 Juri Linkov <juri@jurta.org>
788
789 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
790 to show the arg `TIME' instead of `TIMEVAL'.
791
792 2011-08-06 Eli Zaretskii <eliz@gnu.org>
793
794 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
795 display property strides EOL and includes a newline, as in
796 longlines-mode. (Bug#9254)
797 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
798 word-wrap under bidirectional display. (Bug#9224)
799
800 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
801 is non-zero, even if the data buffer is NULL. Fixes a crash in
802 vertical-motion with longlines-mode. (Bug#9254)
803
804 2011-08-05 Eli Zaretskii <eliz@gnu.org>
805
806 * bidi.c <bidi_cache_total_alloc>: Now static.
807 (bidi_initialize): Initialize bidi_cache_total_alloc.
808
809 * xdisp.c (display_line): Release buffer allocated for shelved bidi
810 cache. (Bug#9221)
811
812 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
813 amount allocated this far in `bidi_cache_total_alloc'.
814 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
815 non-zero, only free the data buffer without restoring the cache
816 contents. All callers changed.
817
818 * dispextern.h (bidi_unshelve_cache): Update prototype.
819
820 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
821 (move_it_in_display_line, move_it_to)
822 (move_it_vertically_backward, move_it_by_lines): Replace the call
823 to xfree to an equivalent call to bidi_unshelve_cache.
824 (move_it_in_display_line_to): Fix logic of returning
825 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
826
827 2011-08-05 Eli Zaretskii <eliz@gnu.org>
828
829 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
830 came from a string character with a `cursor' property. (Bug#9229)
831
832 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
833
834 * Makefile.in (LIB_PTHREAD): New variable.
835 (LIBES): Add LIB_PTHREAD (Bug#9216).
836
837 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
838 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
839
840 2011-08-04 Andreas Schwab <schwab@linux-m68k.org>
841
842 * regex.c (re_iswctype): Remove some redundant boolean
843 conversions.
844
845 2011-08-04 Jan Djärv <jan.h.d@swipnet.se>
846
847 * xterm.c (x_find_topmost_parent): New function.
848 (x_set_frame_alpha): Find topmost parent window with
849 x_find_topmost_parent and set the property there also (bug#9181).
850 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
851
852 2011-08-04 Paul Eggert <eggert@cs.ucla.edu>
853
854 * callproc.c (Fcall_process): Avoid vfork clobbering
855 the local vars buffer, coding_systems, current_dir.
856
857 2011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
858
859 * keymap.c (Fmake_composed_keymap): Move to subr.el.
860
861 2011-08-03 Paul Eggert <eggert@cs.ucla.edu>
862
863 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
864 so that it is not optimized away.
865
866 * xdisp.c (compute_display_string_pos): Remove unused local.
867
868 2011-08-02 Eli Zaretskii <eliz@gnu.org>
869
870 Fix slow cursor motion and scrolling in large buffers with
871 selective display, like Org Mode buffers. (Bug#9218)
872
873 * dispextern.h (struct bidi_it): New member disp_prop_p.
874
875 * xdisp.c: Remove one-slot cache of display string positions.
876 (compute_display_string_pos): Accept an additional argument
877 DISP_PROP_P; callers changed. Scan at most 5K characters forward
878 for a display string or property. If found, set DISP_PROP_P
879 non-zero.
880
881 * bidi.c (bidi_fetch_char): Accept an additional argument
882 DISP_PROP_P, and pass it to compute_display_string_pos.
883 Only handle text covered by a display string if DISP_PROP_P is returned
884 non-zero. All callers of bidi_fetch_char changed.
885
886 2011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
887
888 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
889
890 2010-12-03 Don March <don@ohspite.net>
891
892 * keymap.c (Fdefine_key): Fix non-prefix key error message when
893 last character M-[char] is translated to ESC [char] (bug#7541).
894
895 2011-08-02 Kenichi Handa <handa@m17n.org>
896
897 * lisp.h (uniprop_table): Extern it.
898
899 * chartab.c (uniprop_table): Make it non-static.
900
901 2011-08-01 Eli Zaretskii <eliz@gnu.org>
902
903 * xdisp.c (forward_to_next_line_start): Accept additional argument
904 BIDI_IT_PREV, and store into it the state of the bidi iterator had
905 on the newline.
906 (reseat_at_next_visible_line_start): Use the bidi iterator state
907 returned by forward_to_next_line_start to restore the state of
908 it->bidi_it after backing up to previous newline. (Bug#9212)
909
910 2011-07-30 Andreas Schwab <schwab@linux-m68k.org>
911
912 * regex.c (re_comp): Protoize.
913 (re_exec): Fix return type.
914 (regexec): Fix type of `ret'. (Bug#9203)
915
916 2011-07-29 Paul Eggert <eggert@cs.ucla.edu>
917
918 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
919
920 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
921
922 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
923 This is needed if max-image-size is a floating-point number.
924
925 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
926
927 * print.c (print_object): Print empty symbol as ##.
928
929 * lread.c (read1): Read ## as empty symbol.
930
931 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
932
933 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
934 setting frame foreground color (Bug#9175).
935 (x_set_background_color): Likewise.
936
937 * nsmenu.m (-setText): Size tooltip dimensions precisely to
938 contents (Bug#9176).
939 (EmacsTooltip -init): Remove bezels and add shadows to
940 tooltip windows.
941
942 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
943 or scroll bar (Bug#8470).
944
945 * nsfont.m (nsfont_open): Remove assignment to voffset and
946 unnecessary vars hshink, expand, hd, full_height, min_height.
947 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
948
949 * nsterm.h (nsfont_info): Remove voffset field.
950
951 2011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
952
953 Implement strike-through and overline on NextStep (Bug#8863).
954
955 * nsfont.m (nsfont_open): Use underline position provided by font,
956 instead of hard-coded value of 2.
957 (nsfont_draw): Call ns_draw_text_decoration instead.
958
959 * nsterm.h: Add declaration for ns_draw_text_decoration.
960
961 * nsterm.m (ns_draw_text_decoration): New function for drawing
962 underline, overline, and strike-through.
963 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
964 ns_draw_text_decoration. Change treatment of cursor drawing to
965 accomodate underlining, etc.
966
967 2011-07-28 Eli Zaretskii <eliz@gnu.org>
968
969 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
970 default.
971
972 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
973
974 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
975 Without this fix, if a signal arrives just after memory fills up,
976 'malloc' might be invoked reentrantly.
977
978 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
979 In other words, assume that every image size is allowed, on non-X
980 hosts. This assumption is probably wrong, but it lets Emacs compile.
981
982 2011-07-28 Andreas Schwab <schwab@linux-m68k.org>
983
984 * regex.c (re_iswctype): Convert return values to boolean.
985
986 2011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
987
988 * xdisp.c (compute_display_string_pos): Don't use cached display
989 string position if the buffer had its restriction changed.
990 (Bug#9184)
991
992 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
993
994 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
995
996 2011-07-28 Paul Eggert <eggert@cs.ucla.edu>
997
998 Integer signedness and overflow and related fixes. (Bug#9079)
999
1000 * bidi.c: Integer size and overflow fixes.
1001 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1002 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1003 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1004 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1005 (bidi_find_other_level_edge):
1006 Use ptrdiff_t instead of EMACS_INT where either will do.
1007 This works better on 32-bit hosts configured --with-wide-int.
1008 (bidi_cache_ensure_space): Check for size-calculation overflow.
1009 Use % rather than repeated addition, for better worst-case speed.
1010 Don't set bidi_cache_size until after xrealloc returns, because it
1011 might not return.
1012 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
1013 (bidi_cache_ensure_space): Also check that the bidi cache size
1014 does not exceed that of the largest Lisp string or buffer. See Eli
1015 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
1016
1017 * alloc.c (__malloc_size_t): Remove.
1018 All uses replaced by size_t. See Andreas Schwab's note
1019 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1020
1021 * image.c: Improve checking for integer overflow.
1022 (check_image_size): Assume that f is nonnull, since
1023 it is always nonnull in practice. This is one less thing to
1024 worry about when checking for integer overflow later.
1025 (x_check_image_size): New function, which checks for integer
1026 overflow issues inside X.
1027 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1028 This removes the need for a memory_full check.
1029 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1030 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1031 (xbm_read_bitmap_data): Change locals back to 'int', since
1032 their values must fit in 'int'.
1033 (xpm_load_image, png_load, tiff_load):
1034 Invoke x_create_x_image_and_pixmap earlier,
1035 to avoid much needless work if the image is too large.
1036 (tiff_load): Treat overly large images as if
1037 x_create_x_image_and_pixmap failed, not as malloc failures.
1038 (gs_load): Use x_check_image_size.
1039
1040 * gtkutil.c: Omit integer casts.
1041 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1042 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1043
1044 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1045
1046 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1047 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1048 would wrongly return t on a 64-bit host.
1049
1050 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1051 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1052 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1053 and therefore cause GCC to emit a bogus diagnostic in some cases.
1054
1055 * image.c: Integer signedness and overflow and related fixes.
1056 This is not an exhaustive set of fixes, but it's time to
1057 record what I've got.
1058 (lookup_pixel_color, check_image_size): Remove redundant decls.
1059 (check_image_size): Don't assume that arbitrary EMACS_INT values
1060 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1061 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1062 (tiff_load, imagemagick_load_image):
1063 Check for overflow in size calculations.
1064 (x_create_x_image_and_pixmap): Remove unnecessary test for
1065 xmalloc returning NULL; that can't happen.
1066 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1067 (xpm_color_bucket): Use better integer hashing function.
1068 (xpm_cache_color): Don't possibly over-allocate memory.
1069 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1070 (gif_memory_source):
1071 Use ptrdiff_t, not int or size_t, to record sizes.
1072 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1073 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1074 either works, as we prefer signed integers.
1075 (tiff_read_from_memory, tiff_write_from_memory):
1076 Return tsize_t, not size_t, since that's what the TIFF API wants.
1077 (tiff_read_from_memory): Don't fail simply because the read would
1078 go past EOF; instead, return a short read.
1079 (tiff_load): Omit no-longer-needed casts.
1080 (Fimagemagick_types): Don't assume size fits into 'int'.
1081
1082 Improve hashing quality when configured --with-wide-int.
1083 * fns.c (hash_string): New function, taken from sxhash_string.
1084 Do not discard information about ASCII character case; this
1085 discarding is no longer needed.
1086 (sxhash-string): Use it. Change sig to match it. Caller changed.
1087 * lisp.h: Declare it.
1088 * lread.c (hash_string): Remove, since we now use fns.c's version.
1089 The fns.c version returns a wider integer if --with-wide-int is
1090 specified, so this should help the quality of the hashing a bit.
1091
1092 * emacs.c: Integer overflow minor fix.
1093 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1094 Define only if GNU_LINUX.
1095 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1096
1097 * dispnew.c: Integer signedness and overflow fixes.
1098 Remove unnecessary forward decls, that were a maintenance hassle.
1099 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1100 All uses changed.
1101 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1102 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1103 (prepare_desired_row, line_draw_cost):
1104 Use int, not unsigned, where either works.
1105 (save_current_matrix, restore_current_matrix):
1106 Use ptrdiff_t, not size_t, where either works.
1107 (init_display): Check for overflow more accurately, and without
1108 relying on undefined behavior.
1109
1110 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1111 Remove, replacing with the new symbols in lisp.h. All uses changed.
1112 * fileio.c (make_temp_name):
1113 * filelock.c (lock_file_1, lock_file):
1114 * xdisp.c (message_dolog):
1115 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1116 Use pMd etc. instead.
1117 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1118 replacing the pWIDE etc. symbols removed from editfns.c.
1119
1120 * keyboard.h (num_input_events): Now uintmax_t.
1121 This is (very slightly) less likely to mess up due to wraparound.
1122 All uses changed.
1123
1124 * buffer.c: Integer signedness fixes.
1125 (alloc_buffer_text, enlarge_buffer_text):
1126 Use ptrdiff_t rather than size_t when either will do, as we prefer
1127 signed integers.
1128
1129 * alloc.c: Integer signedness and overflow fixes.
1130 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1131 (__malloc_size_t): Default to size_t, not to int.
1132 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1133 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1134 Prefer ptrdiff_t to size_t when either would do, as we prefer
1135 signed integers.
1136 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1137 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1138 Now const. Initialize with values that are in range even if char
1139 is signed.
1140 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1141 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1142 These functions do the right thing with sizes > 2**32.
1143 (check_depth): Now ptrdiff_t, not int.
1144 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1145 Adjust to new way of storing sizes. Check for size overflow bugs
1146 in rest of code.
1147 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1148 slightly wrong anyway, as it missed one instance of
1149 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1150 (refill_memory_reserve): Omit needless cast to size_t.
1151 (mark_object_loop_halt): Mark as externally visible.
1152
1153 * xselect.c: Integer signedness and overflow fixes.
1154 (Fx_register_dnd_atom, x_handle_dnd_message):
1155 Use ptrdiff_t, not size_t, since we prefer signed.
1156 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1157 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1158 x_dnd_atoms_size and x_dnd_atoms_length.
1159
1160 * doprnt.c: Prefer signed to unsigned when either works.
1161 * eval.c (verror):
1162 * doprnt.c (doprnt):
1163 * lisp.h (doprnt):
1164 * xdisp.c (vmessage):
1165 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1166 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1167 prefer signed arithmetic to avoid comparison confusion.
1168 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1169 but is a bit tricky.
1170
1171 Assume freestanding C89 headers, string.h, stdlib.h.
1172 * data.c, doprnt.c, floatfns.c, print.c:
1173 Include float.h unconditionally.
1174 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1175 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1176 * regex.c: Likewise for stddef.h, string.h.
1177 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1178 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1179 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1180 (STDC_HEADERS): Remove obsolete defines.
1181 * sysdep.c: Include limits.h unconditionally.
1182
1183 Assume support for memcmp, memcpy, memmove, memset.
1184 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1185 * regex.c (memcmp, memcpy):
1186 Remove; we assume C89 now.
1187
1188 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1189 (__malloc_safe_bcopy): Remove; no longer needed.
1190
1191 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
1192 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1193 well either way, and we prefer signed to unsigned.
1194
1195 2011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1196
1197 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1198 closes the connection while we're reading (bug#9182).
1199
1200 2011-07-25 Jan Djärv <jan.h.d@swipnet.se>
1201
1202 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1203 are specified (Bug#9168).
1204
1205 2011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1206
1207 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1208 Found by GCC static checking and --with-wide-int on a 32-bit host.
1209
1210 2011-07-25 Eli Zaretskii <eliz@gnu.org>
1211
1212 * xdisp.c (compute_display_string_pos): Fix logic of caching
1213 previous display string position. Initialize cached_prev_pos to
1214 -1. Fixes slow-down at the beginning of a buffer.
1215
1216 2011-07-24 Eli Zaretskii <eliz@gnu.org>
1217
1218 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1219 for attrs[LFACE_FONTSET_INDEX].
1220
1221 2011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1222
1223 * xml.c (parse_region): Remove unused local
1224 that was recently introduced.
1225
1226 2011-07-23 Eli Zaretskii <eliz@gnu.org>
1227
1228 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1229 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1230
1231 * xdisp.c (move_it_in_display_line_to): Record the best matching
1232 position for TO_CHARPOS while scanning the line, and restore it on
1233 exit if none of the characters scanned was an exact match.
1234 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
1235 when exact match is impossible due to invisible text, and the
1236 lines are truncated.
1237
1238 2011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1239
1240 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1241 for OSX >= 10.7.
1242
1243 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1244
1245 Fix a significant slow-down of cursor motion with C-n, C-p,
1246 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1247 auto-repeat under bidi redisplay in fontified buffers.
1248 * xdisp.c (compute_stop_pos_backwards): New function.
1249 (next_element_from_buffer): Call compute_stop_pos_backwards to
1250 find a suitable prev_stop when we find ourselves before
1251 base_level_stop.
1252 (reseat): Don't look for prev_stop, as that could mean a very long
1253 run.
1254 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1255 <cached_disp_overlay_modiff>: Cache for last found display string
1256 position.
1257 (compute_display_string_pos): Return the cached position if asked
1258 about the same buffer in the same area of character positions, and
1259 the buffer wasn't changed since the time the display string
1260 position was cached.
1261
1262 2011-07-22 Eli Zaretskii <eliz@gnu.org>
1263
1264 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1265 is an integer, which is important for empty lines. (Bug#9149)
1266
1267 2011-07-22 Chong Yidong <cyd@stupidchicken.com>
1268
1269 * frame.c (Fmodify_frame_parameters): In tty case, update the
1270 default face if necessary (Bug#4238).
1271
1272 2011-07-21 Chong Yidong <cyd@stupidchicken.com>
1273
1274 * editfns.c (Fstring_to_char): No need to explain what a character
1275 is in the docstring (Bug#6576).
1276
1277 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1278
1279 * xml.c (parse_region): Make sure we always return a tree.
1280
1281 2011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1282
1283 * xml.c (parse_region): If a document contains only comments,
1284 return that, too.
1285
1286 2011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1287
1288 * xml.c (make_dom): Return comments, too.
1289
1290 2011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1291
1292 Port to OpenBSD.
1293 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1294 and the surrounding thread.
1295 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1296 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1297 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1298 timer goes off.
1299 * s/openbsd.h (BROKEN_SIGIO): Define.
1300 * unexelf.c (unexec) [__OpenBSD__]:
1301 Don't update the .mdebug section of the Alpha COFF symbol table.
1302
1303 2011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1304
1305 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1306 (bug#8460).
1307
1308 2011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1309
1310 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1311 This fixes some race conditions on the permissions of any newly
1312 created file.
1313
1314 * alloc.c (valid_pointer_p): Use pipe, not open.
1315 This fixes some permissions issues when debugging.
1316
1317 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1318 If fchown fails to set both uid and gid, try to set just gid,
1319 as that is sometimes allowed. Adjust the file's mode to eliminate
1320 setuid or setgid bits that are inappropriate if fchown fails.
1321
1322 2011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1323
1324 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1325 to compare Lisp_Objects.
1326 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1327 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1328 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1329
1330 2011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1331
1332 * lread.c (read_integer): Unread even EOF character.
1333 (read1): Likewise. Properly record start position of symbol.
1334
1335 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1336 symbol character follows.
1337
1338 2011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1339
1340 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1341 This works around a problem with the previous change to Fcopy_file.
1342 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1343 and without this change, GCC might complain about discarding
1344 fchown's return value.
1345
1346 2011-07-16 Juanma Barranquero <lekktu@gmail.com>
1347
1348 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1349
1350 2011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1351
1352 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1353
1354 2011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1355
1356 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1357 it's used from the C level.
1358
1359 * process.c: Use the same condition for POLL_FOR_INPUT in both
1360 keyboard.c and process.c (bug#1858).
1361
1362 2011-07-09 Lawrence Mitchell <wence@gmx.li>
1363
1364 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1365 (Fgnutls_boot): Use it.
1366
1367 2011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1368
1369 * doc.c (Fsubstitute_command_keys): Revert last change.
1370
1371 2011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1372
1373 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1374 quotes the next character, and doesn't affect other longer
1375 sequences (bug#8935).
1376
1377 * lread.c (syms_of_lread): Clarify that is isn't only
1378 `eval-buffer' and `eval-defun' that's affected by
1379 `lexical-binding' (bug#8460).
1380
1381 2011-07-15 Eli Zaretskii <eliz@gnu.org>
1382
1383 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1384 bidi redisplay when a line includes both an image and is
1385 truncated.
1386
1387 2011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1388
1389 Fix minor problems found by static checking.
1390 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1391 (elsz): Now a signed constant, not a size_t var. We prefer signed
1392 types to unsigned, to avoid integer comparison confusion. Without
1393 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1394 "cannot optimize loop, the loop counter may overflow", a symptom
1395 of the confusion.
1396 * indent.c (Fvertical_motion): Mark locals as initialized.
1397 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1398
1399 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1400
1401 * search.c (Fre_search_backward): Mention `case-fold-search' in
1402 all the re_search_* functions (bug#8138).
1403
1404 * keyboard.c (Fopen_dribble_file): Document when the file is
1405 closed (bug#8056).
1406
1407 2011-07-14 Eli Zaretskii <eliz@gnu.org>
1408
1409 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1410 bidi_cache_idx.
1411
1412 Support bidi reordering of display and overlay strings.
1413 * xdisp.c (compute_display_string_pos)
1414 (compute_display_string_end): Accept additional argument STRING.
1415 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1416 (reseat_to_string): Initialize bidi_it->string.s and
1417 bidi_it->string.schars.
1418 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
1419 NULL (avoids a crash in bidi_paragraph_init).
1420 Initialize itb.string.lstring.
1421 (init_iterator): Call bidi_init_it only of a valid
1422 buffer position was specified. Initialize paragraph_embedding to
1423 L2R.
1424 (reseat_to_string): Initialize the bidi iterator.
1425 (display_string): If we need to ignore text properties of
1426 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1427 original value of -1 will not work with bidi.)
1428 (compute_display_string_pos): First arg is now struct
1429 `text_pos *'; all callers changed. Support display properties on
1430 Lisp strings.
1431 (compute_display_string_end): Support display properties on Lisp
1432 strings.
1433 (init_iterator, reseat_1, reseat_to_string): Initialize the
1434 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
1435 when iterating on a string not from display properties).
1436 (compute_display_string_pos, compute_display_string_end):
1437 Fix calculation of the object to scan. Fixes an error when using
1438 arrow keys.
1439 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
1440 base_level_stop; instead, set base_level_stop to BEGV.
1441 Fixes crashes in vertical-motion.
1442 (next_element_from_buffer): Improve commentary for when
1443 the iterator is before prev_stop.
1444 (init_iterator): Initialize bidi_p from the default value of
1445 bidi-display-reordering, not from buffer-local value. Use the
1446 buffer-local value only if initializing for buffer iteration.
1447 (handle_invisible_prop): Support invisible properties on strings
1448 that are being bidi-reordered.
1449 (set_iterator_to_next): Support bidi reordering of C strings and
1450 Lisp strings.
1451 (next_element_from_string): Support bidi reordering of Lisp
1452 strings.
1453 (handle_stop_backwards): Support Lisp strings as well.
1454 (display_string): Support display of R2L glyph rows.
1455 Use IT_STRING_CHARPOS when displaying from a Lisp string.
1456 (init_iterator): Don't initialize it->bidi_p for strings
1457 here.
1458 (reseat_to_string): Initialize it->bidi_p for strings here.
1459 (next_element_from_string, next_element_from_c_string)
1460 (next_element_from_buffer): Add xassert's for correspondence
1461 between IT's object being iterated and it->bidi_it.string
1462 structure.
1463 (face_before_or_after_it_pos): Support bidi iteration.
1464 (next_element_from_c_string): Handle the case of the first string
1465 character that is not the first one in the visual order.
1466 (get_visually_first_element): New function, refactored from common
1467 parts of next_element_from_buffer, next_element_from_string, and
1468 next_element_from_c_string.
1469 (tool_bar_lines_needed, redisplay_tool_bar)
1470 (display_menu_bar): Force left-to-right direction. Add a FIXME
1471 comment for making that be controlled by a user option.
1472 (push_it, pop_it): Save and restore the state of the
1473 bidi iterator. Save and restore the bidi_p flag.
1474 (pop_it): Iterate out of display property for string iteration as
1475 well.
1476 (iterate_out_of_display_property): Support iteration over strings.
1477 (handle_single_display_spec): Set up it->bidi_it for iteration
1478 over a display string, and call bidi_init_it.
1479 (handle_single_display_spec, next_overlay_string)
1480 (get_overlay_strings_1, push_display_prop): Set up the bidi
1481 iterator for displaying display or overlay strings.
1482 (forward_to_next_line_start): Don't use the shortcut if
1483 bidi-iterating.
1484 (back_to_previous_visible_line_start): If handle_display_prop
1485 pushed the iterator stack, restore the internal state of the bidi
1486 iterator by calling bidi_pop_it same number of times.
1487 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
1488 and we are bidi-iterating, don't decrement the iterator position;
1489 instead, set the first_elt flag in the bidi iterator, to produce
1490 the same effect.
1491 (reseat_1): Remove redundant setting of string_from_display_prop_p.
1492 (push_display_prop): xassert that we are iterating a buffer.
1493 (push_it, pop_it): Save and restore paragraph_embedding member.
1494 (handle_single_display_spec, next_overlay_string)
1495 (get_overlay_strings_1, reseat_1, reseat_to_string)
1496 (push_display_prop): Set up the `unibyte' member of bidi_it.string
1497 correctly. Don't assume unibyte strings are not bidi-reordered.
1498 (compute_display_string_pos)
1499 (compute_display_string_end): Fix handling the case of C string.
1500 (push_it, pop_it): Save and restore from_disp_prop_p.
1501 (handle_single_display_spec, push_display_prop): Set the
1502 from_disp_prop_p flag.
1503 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
1504 (pop_it): Call iterate_out_of_display_property only if we are
1505 popping after iteration over a string that came from a display
1506 property. Fix a typo in popping stretch info. Add an assertion
1507 for verifying that the iterator position is in sync with the bidi
1508 iterator.
1509 (handle_single_display_spec, get_overlay_strings_1)
1510 (push_display_prop): Fix initialization of paragraph direction for
1511 string when that of the parent object is not yet determined.
1512 (reseat_1): Call bidi_init_it to resync the bidi
1513 iterator with IT's position. (Bug#7616)
1514 (find_row_edges): If ROW->start.pos gives position
1515 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
1516 (handle_stop, back_to_previous_visible_line_start, reseat_1):
1517 Reset the from_disp_prop_p flag.
1518 (SAVE_IT, RESTORE_IT): New macros.
1519 (pos_visible_p, face_before_or_after_it_pos)
1520 (back_to_previous_visible_line_start)
1521 (move_it_in_display_line_to, move_it_in_display_line)
1522 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1523 (try_scrolling, redisplay_window, display_line): Use them when
1524 saving a temporary copy of the iterator and restoring it back.
1525 (back_to_previous_visible_line_start, reseat_1)
1526 (init_iterator): Empty the bidi cache "stack".
1527 (move_it_in_display_line_to): If iterator ended up at
1528 EOL, but we never saw any buffer positions smaller than
1529 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
1530 motion in bidi-reordered lines.
1531 (move_it_in_display_line_to): Record prev_method and prev_pos
1532 immediately before the call to set_iterator_to_next. Fixes cursor
1533 motion in bidi-reordered lines with stretch glyphs and strings
1534 displayed in margins. (Bug#8133) (Bug#8867)
1535 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
1536 TO_CHARPOS.
1537 (pos_visible_p): Support positions in bidi-reordered lines.
1538 Save and restore bidi cache.
1539
1540 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
1541 (bidi_paragraph_info): Delete unused struct.
1542 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
1543 (bidi_cache_start): New variable.
1544 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
1545 to zero.
1546 (bidi_cache_fetch_state, bidi_cache_search)
1547 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1548 (bidi_cache_find, bidi_peek_at_next_level)
1549 (bidi_level_of_next_char, bidi_find_other_level_edge)
1550 (bidi_move_to_visually_next): Compare cache index with
1551 bidi_cache_start rather than with zero.
1552 (bidi_fetch_char): Accept new argument STRING; all callers
1553 changed. Support iteration over a string. Support strings with
1554 display properties. Support unibyte strings. Fix the type of
1555 `len' according to what STRING_CHAR_AND_LENGTH expects.
1556 (bidi_paragraph_init, bidi_resolve_explicit_1)
1557 (bidi_resolve_explicit, bidi_resolve_weak)
1558 (bidi_level_of_next_char, bidi_move_to_visually_next):
1559 Support iteration over a string.
1560 (bidi_set_sor_type, bidi_resolve_explicit_1)
1561 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
1562 can now be zero (for strings); special values 0 and -1 were
1563 changed to -1 and -2, respectively.
1564 (bidi_char_at_pos): New function.
1565 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
1566 Call it instead of FETCH_MULTIBYTE_CHAR.
1567 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
1568 initialized to valid values.
1569 (bidi_init_it): Don't initialize charpos and bytepos with invalid
1570 values.
1571 (bidi_level_of_next_char): Allow the sentinel "position" to pass
1572 the test for valid cached positions. Fix the logic for looking up
1573 the sentinel state in the cache. GCPRO the Lisp string we are
1574 iterating.
1575 (bidi_push_it, bidi_pop_it): New functions.
1576 (bidi_initialize): Initialize the bidi cache start stack pointer.
1577 (bidi_cache_ensure_space): New function, refactored from part of
1578 bidi_cache_iterator_state. Don't assume the required size is just
1579 one BIDI_CACHE_CHUNK away.
1580 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
1581 (bidi_count_bytes, bidi_char_at_pos): New functions.
1582 (bidi_cache_search): Don't assume bidi_cache_last_idx is
1583 always valid if bidi_cache_idx is valid.
1584 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
1585 is valid if it's going to be used.
1586 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
1587 (bidi_cache_fetch_state, bidi_cache_search)
1588 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1589 (bidi_cache_iterator_state, bidi_cache_find)
1590 (bidi_find_other_level_edge, bidi_cache_start_stack):
1591 All variables related to cache indices are now EMACS_INT.
1592
1593 * dispextern.h (struct bidi_string_data): New structure.
1594 (struct bidi_it): New member `string'. Make flag members be 1-bit
1595 fields, and put them last in the struct.
1596 (compute_display_string_pos, compute_display_string_end):
1597 Update prototypes.
1598 (bidi_push_it, bidi_pop_it): Add prototypes.
1599 (struct iterator_stack_entry): New members bidi_p,
1600 paragraph_embedding, and from_disp_prop_p.
1601 (struct it): Member bidi_p is now a bit field 1 bit wide.
1602 (bidi_shelve_cache, bidi_unshelve_cache):
1603 Declare prototypes.
1604
1605 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
1606 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
1607 and vector-like objects.
1608
1609 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
1610 cache around display iteration.
1611
1612 * window.c (Fwindow_end, window_scroll_pixel_based)
1613 (displayed_window_lines, Frecenter): Save and restore the bidi
1614 cache around display iteration.
1615
1616 2011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1617
1618 * editfns.c (Fdelete_region): Clarify the use of the named
1619 parameters (bug#6788).
1620
1621 2011-07-14 Martin Rudalics <rudalics@gmx.at>
1622
1623 * indent.c (Fvertical_motion): Set and restore w->pointm when
1624 saving and restoring the window's buffer (Bug#9006).
1625
1626 2011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1627
1628 * editfns.c (Fstring_to_char): Clarify just what is returned
1629 (bug#6576). Text by Eli Zaretskii.
1630
1631 2011-07-13 Juanma Barranquero <lekktu@gmail.com>
1632
1633 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
1634
1635 2011-07-13 Eli Zaretskii <eliz@gnu.org>
1636
1637 * buffer.c (mmap_find): Fix a typo.
1638
1639 2011-07-13 Johan Bockgård <bojohan@gnu.org>
1640
1641 Fix execution of x selection hooks.
1642 * xselect.c (Qx_lost_selection_functions)
1643 (Qx_sent_selection_functions): New vars.
1644 (syms_of_xselect): DEFSYM them.
1645 (x_handle_selection_request): Pass Qx_sent_selection_functions
1646 rather than Vx_sent_selection_functions to Frun_hook_with_args.
1647 (x_handle_selection_clear,x_clear_frame_selections):
1648 Pass Qx_lost_selection_functions rather than
1649 Vx_lost_selection_functions to Frun_hook_with_args.
1650
1651 2011-07-13 Paul Eggert <eggert@cs.ucla.edu>
1652
1653 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
1654 The old code sometimes used this field without initializing it.
1655
1656 * alloc.c (gc_sweep): Don't read past end of array.
1657 In theory, the old code could also have corrupted Emacs internals,
1658 though it'd be very unlikely.
1659
1660 2011-07-12 Andreas Schwab <schwab@linux-m68k.org>
1661
1662 * character.c (Fcharacterp): Don't advertise optional ignored
1663 argument. (Bug#4026)
1664
1665 2011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
1666
1667 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
1668 key" (bug#4257).
1669
1670 * window.c (Fset_window_start): Doc fix (bug#4199).
1671 (Fset_window_hscroll): Ditto.
1672
1673 2011-07-12 Paul Eggert <eggert@cs.ucla.edu>
1674
1675 Fix minor new problems caught by GCC 4.6.1.
1676 * term.c (init_tty): Remove unused local.
1677 * xsettings.c (store_monospaced_changed): Define this function only
1678 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
1679 not used otherwise.
1680
1681 2011-07-12 Chong Yidong <cyd@stupidchicken.com>
1682
1683 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
1684
1685 2011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1686
1687 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
1688 are the mini-buffer and the echo area (bug#3320).
1689
1690 * term.c (init_tty): Remove support for supdup, c10 and perq
1691 terminals, which are no longer supported (bug#1482).
1692
1693 2011-07-10 Johan Bockgård <bojohan@gnu.org>
1694
1695 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
1696
1697 2011-07-10 Jan Djärv <jan.h.d@swipnet.se>
1698
1699 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
1700 for non-popups (Bug#3642).
1701
1702 2011-07-10 Andreas Schwab <schwab@linux-m68k.org>
1703
1704 * alloc.c (reset_malloc_hooks): Protoize.
1705 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
1706 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
1707 * cm.c (losecursor): Likewise.
1708 * data.c (fmod): Likewise.
1709 * dispnew.c (swap_glyphs_in_rows): Likewise.
1710 * emacs.c (memory_warning_signal): Likewise.
1711 * floatfns.c (float_error): Likewise.
1712 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
1713 (otf_open, font_otf_capability, generate_otf_features)
1714 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
1715 Likewise.
1716 * image.c (pbm_read_file): Likewise.
1717 * indent.c (string_display_width): Likewise.
1718 * intervals.c (check_for_interval, search_for_interval)
1719 (inc_interval_count, count_intervals, root_interval)
1720 (adjust_intervals_for_insertion, make_new_interval): Likewise.
1721 * lread.c (defalias): Likewise.
1722 * ralloc.c (r_alloc_check): Likewise.
1723 * regex.c (set_image_of_range_1, set_image_of_range)
1724 (regex_grow_registers): Likewise.
1725 * sysdep.c (strerror): Likewise.
1726 * termcap.c (valid_filename_p, tprint, main): Likewise.
1727 * tparam.c (main): Likewise.
1728 * unexhp9k800.c (run_time_remap, save_data_space)
1729 (update_file_ptrs, read_header, write_header, calculate_checksum)
1730 (copy_file, copy_rest, display_header): Likewise.
1731 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
1732 Likewise.
1733 * xdisp.c (check_it): Likewise.
1734 * xfaces.c (register_color, unregister_color, unregister_colors):
1735 Likewise.
1736 * xfns.c (print_fontset_result): Likewise.
1737 * xrdb.c (member, fatal, main): Likewise.
1738
1739 2011-07-10 Paul Eggert <eggert@cs.ucla.edu>
1740
1741 Fix minor problems found by static checking (Bug#9031).
1742 * chartab.c (char_table_set_range, map_sub_char_table):
1743 Remove unused locals.
1744 (uniprop_table): Now static.
1745 * composite.c (_work_char): Remove unused static var.
1746
1747 2011-07-09 Juanma Barranquero <lekktu@gmail.com>
1748
1749 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
1750
1751 2011-07-09 Jan Djärv <jan.h.d@swipnet.se>
1752
1753 * gtkutil.c (qttip_cb): Remove code without function.
1754
1755 2011-07-09 Eli Zaretskii <eliz@gnu.org>
1756
1757 * w32.c (pthread_sigmask): New stub.
1758
1759 2011-07-08 Paul Eggert <eggert@cs.ucla.edu>
1760
1761 Use pthread_sigmask, not sigprocmask (Bug#9010).
1762 sigprocmask is portable only for single-threaded applications, and
1763 Emacs can be multi-threaded when it uses GTK.
1764 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
1765 (LIBES): Use it.
1766 * callproc.c (Fcall_process):
1767 * process.c (create_process):
1768 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
1769 Use pthread_sigmask, not sigprocmask.
1770
1771 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1772
1773 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
1774 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
1775 wrong (Bug#8591).
1776
1777 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1778
1779 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
1780 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
1781 (xg_hide_tooltip): Fix comment.
1782
1783 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
1784 in registerServicesMenuSendTypes.
1785 (validRequestorForSendType): Don't check ns_return_types.
1786
1787 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
1788 ns_return_type.
1789
1790 2011-07-08 Jason Rumney <jasonr@gnu.org>
1791
1792 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
1793 frame struct members of non-existent frames (Bug#6284).
1794
1795 2011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1796
1797 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
1798 variable firstTime not needed on OSX >= 10.6.
1799 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
1800 >= 10.5. Use setKnobProportion, setDoubleValue.
1801
1802 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
1803 (MAC_OS_X_VERSION_10_5): Define if not defined.
1804 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
1805 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
1806 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
1807
1808 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
1809 cString and lossyCString on OSX >= 10.4
1810
1811 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
1812 sizeToFit on OSX >= 10.2.
1813
1814 * nsimage.m (allocInitFromFile): Don't use deprecated method
1815 bestRepresentationForDevice on OSX >= 10.6.
1816
1817 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
1818 to avoid warning.
1819
1820 * emacs.c: Declare unexec_init_emacs_zone.
1821
1822 * nsgui.h: Fix compiler warning about gnulib redefining verify.
1823
1824 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
1825
1826 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
1827 on svcsMenu (Bug#8842).
1828
1829 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
1830 ns_return_types.
1831 (Fns_list_services): Just return Qnil on 10.6, code not working there.
1832
1833 * nsterm.m (QUTF8_STRING): Declare.
1834 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
1835 (validRequestorForSendType): Return type is (id).
1836 Change indexOfObjectIdenticalTo to indexOfObject.
1837 Check if we have local selection before returning self (Bug#8842).
1838 (writeSelectionToPasteboard): Put local selection into paste board
1839 if we have a local selection (Bug#8842).
1840 (syms_of_nsterm): DEFSYM QUTF8_STRING.
1841
1842 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
1843 (ns_get_local_selection): Declare.
1844
1845 2011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
1846
1847 * keymap.c (describe_map_tree): Don't insert a double newline at
1848 the end of the buffer (bug#1169) and return whether we inserted
1849 something.
1850
1851 * callint.c (Fcall_interactively): Change "reading args" to
1852 "providing args" to try to clarify what it does (bug#1010).
1853
1854 2011-07-07 Kenichi Handa <handa@m17n.org>
1855
1856 * composite.c (composition_compute_stop_pos): Ignore a static
1857 composition starting before CHARPOS (Bug#8915).
1858
1859 * xdisp.c (handle_composition_prop): Likewise.
1860
1861 2011-07-07 Eli Zaretskii <eliz@gnu.org>
1862
1863 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1864 (Bug#9015)
1865
1866 2011-07-07 Kenichi Handa <handa@m17n.org>
1867
1868 * character.h (unicode_category_t): New enum type.
1869
1870 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1871 (Qchar_code_property_table): New variable.
1872 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1873 (UNIPROP_COMPRESSED_FORM_P): New macros.
1874 (char_table_ascii): Uncompress the compressed values.
1875 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1876 Uncompress the compressed values.
1877 (sub_char_table_ref_and_range): Likewise.
1878 (char_table_ref_and_range): Uncompress the compressed values.
1879 (sub_char_table_set): New arg is_uniprop. Callers changed.
1880 Uncompress the compressed values.
1881 (sub_char_table_set_range): Args changed. Callers changed.
1882 (char_table_set_range): Adjuted for the above change.
1883 (map_sub_char_table): Delete args default_val and parent. Add arg
1884 top. Give decoded values to a Lisp function.
1885 (map_char_table): Adjust for the above change. Give decoded
1886 values to a Lisp function. Gcpro more variables.
1887 (uniprop_table_uncompress)
1888 (uniprop_decode_value_run_length): New functions.
1889 (uniprop_decoder, uniprop_decoder_count): New variables.
1890 (uniprop_get_decoder, uniprop_encode_value_character)
1891 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1892 New functions.
1893 (uniprop_encoder, uniprop_encoder_count): New variables.
1894 (uniprop_get_encoder, uniprop_table)
1895 (Funicode_property_table_internal, Fget_unicode_property_internal)
1896 (Fput_unicode_property_internal): New functions.
1897 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1898 Sunicode_property_table_internal, Sget_unicode_property_internal,
1899 and Sput_unicode_property_internal. Defvar_lisp
1900 char-code-property-alist.
1901
1902 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
1903 Vunicode_category_table.
1904
1905 * font.c (font_range): Adjust for the change of
1906 Vunicode_category_table.
1907
1908 2011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1909
1910 * m/iris4d.h: Remove file, move contents ...
1911 * s/irix6-5.h: ... here.
1912
1913 2011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1914
1915 Remove unportable assumption about struct layout (Bug#8884).
1916 * alloc.c (mark_buffer):
1917 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1918 (clone_per_buffer_values): Don't assume that
1919 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1920 This isn't true in general, and it's particularly not true
1921 if Emacs is configured with --with-wide-int.
1922 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1923 New macros, used in the buffer.c change.
1924
1925 2011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1926
1927 * xsettings.c: Use both GConf and GSettings if both are available.
1928 (store_config_changed_event): Add comment.
1929 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1930 (store_tool_bar_style_changed): New functions.
1931 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1932 (struct xsettings): Move font inside HAVE_XFT.
1933 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
1934 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
1935 Move inside HAVE_XFT.
1936 (something_changed_gsettingsCB): Rename from something_changedCB.
1937 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1938 also.
1939 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
1940 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1941 (something_changed_gconfCB): Rename from something_changedCB.
1942 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1943 (parse_settings): Move check for font inside HAVE_XFT.
1944 (read_settings, apply_xft_settings): Add comment.
1945 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1946 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1947 call store_font_name_changed.
1948 (xft_settings_event): Add comment.
1949 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1950 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1951 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1952 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1953 (xsettings_initialize): Call init_gsettings last.
1954 (xsettings_get_system_font, xsettings_get_system_normal_font):
1955 Add comment.
1956
1957 2011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1958
1959 Random fixes. E.g., (random) never returned negative values.
1960 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1961 subseconds part to the entropy, as that's a bit more random.
1962 Prefer signed to unsigned, since the signedness doesn't matter and
1963 in general we prefer signed. When given a limit, use a
1964 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1965 latter isn't right if USE_2_TAGS_FOR_INTS.
1966 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1967 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1968
1969 2011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1970
1971 * textprop.c (text_property_stickiness):
1972 Obey Vtext_property_default_nonsticky.
1973 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1974 * w32fns.c (syms_of_w32fns):
1975 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1976
1977 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1978
1979 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1980 This is more efficient than Ffile_directory_p and avoids a minor race.
1981
1982 2011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1983
1984 * buffer.c (Foverlay_put): Say what the return value is
1985 (bug#7835).
1986
1987 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1988 is a directory before asking whether to use the file name
1989 (bug#7564).
1990 (barf_or_query_if_file_exists): Make the "File is a directory"
1991 error be more correct.
1992
1993 * fns.c (Frequire): Remove the mention of the .gz files, since
1994 that's installation-specific, but keep the mention of
1995 `get-load-suffixes'.
1996
1997 2011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1998
1999 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2000 Report string overflow if the output is too long.
2001
2002 2011-07-04 Juanma Barranquero <lekktu@gmail.com>
2003
2004 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2005 (syms_of_gnutls): Remove duplicate DEFSYM for
2006 Qgnutls_bootprop_verify_hostname_error, an error for
2007 Qgnutls_bootprop_verify_error (which is no longer used).
2008
2009 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2010 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2011 Also (re)move comments that are misplaced or no longer relevant.
2012
2013 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2014
2015 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2016
2017 2011-07-03 Chong Yidong <cyd@stupidchicken.com>
2018
2019 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2020 and background color parameters if they have been changed.
2021
2022 2011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2023
2024 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2025
2026 2011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2027
2028 * xsettings.c (SYSTEM_FONT): Define only when used.
2029 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2030
2031 * keymap.c (access_keymap_1): Now static.
2032
2033 2011-07-02 Chong Yidong <cyd@stupidchicken.com>
2034
2035 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2036 leave any prefix arg for the up event (Bug#1586).
2037
2038 2011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2039
2040 * lread.c (syms_of_lread): Mention single symbols defined by
2041 `defvar' or `defconst' (bug#7154).
2042
2043 * fns.c (Frequire): Mention .el.gz files (bug#7314).
2044 (Frequire): Mention get-load-suffixes.
2045
2046 2011-07-02 Martin Rudalics <rudalics@gmx.at>
2047
2048 * window.h (window): Remove clone_number slot.
2049 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2050 Remove.
2051 (make_parent_window, make_window, saved_window)
2052 (Fset_window_configuration, save_window_save): Don't deal with
2053 clone numbers.
2054 * buffer.c (Qclone_number): Remove declaration.
2055 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2056
2057 2011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2058
2059 Add multiple inheritance to keymaps.
2060 * keymap.c (Fmake_composed_keymap): New function.
2061 (Fset_keymap_parent): Simplify.
2062 (fix_submap_inheritance): Remove.
2063 (access_keymap_1): New function extracted from access_keymap to handle
2064 embedded parents and handle lists of maps.
2065 (access_keymap): Use it.
2066 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2067 (Fcopy_keymap): Handle embedded parents.
2068 (Fcommand_remapping, define_as_prefix): Simplify.
2069 (Fkey_binding): Simplify.
2070 (syms_of_keymap): Move minibuffer-local-completion-map,
2071 minibuffer-local-filename-completion-map,
2072 minibuffer-local-must-match-map, and
2073 minibuffer-local-filename-must-match-map to Elisp.
2074 (syms_of_keymap): Defsubr make-composed-keymap.
2075 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2076 (parse_menu_item): Trivial simplification.
2077
2078 2011-07-01 Glenn Morris <rgm@gnu.org>
2079
2080 * Makefile.in (SETTINGS_LIBS): Fix typo.
2081
2082 2011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2083
2084 * coding.c (Fencode_coding_string): Record the last coding system
2085 used, as the function doc string says (bug#8738).
2086
2087 2011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2088
2089 * xsettings.c (store_monospaced_changed): Take new font as arg and
2090 check for change against current_mono_font.
2091 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2092 (emacs_settings_constructor, emacs_settings_get_property)
2093 (emacs_settings_set_property, emacs_settings_class_init)
2094 (emacs_settings_init, gsettings_obj): Remove.
2095 (something_changedCB): New function for HAVE_GSETTINGS.
2096 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2097 with value as argument.
2098 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2099 g_settings_new (Bug#8967). Do not create gsettings_obj.
2100 Remove calls to g_settings_bind. Connect something_changedCB to
2101 "changed".
2102
2103 * xgselect.c: Add defined (HAVE_GSETTINGS).
2104 (xgselect_initialize): Ditto.
2105
2106 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2107 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2108 xg_select.
2109
2110 2011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2111
2112 * eval.c (struct backtrace): Simplify and port the data structure.
2113 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2114 signed bit field, as this assumption is not portable and it makes
2115 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2116 "char debug_on_exit : 1" as this is not portable either; instead,
2117 use the portable "unsigned int debug_on_exit : 1". Remove unused
2118 member evalargs. Remove obsolete comments about cc bombing out.
2119
2120 2011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2121
2122 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
2123 Let HAVE_GSETTINGS override HAVE_GCONF.
2124 (store_monospaced_changed): New function.
2125 (EMACS_SETTINGS): A new type derived from GObject to handle
2126 GSettings notifications.
2127 (emacs_settings_constructor, emacs_settings_get_property)
2128 (emacs_settings_set_property, emacs_settings_class_init):
2129 New functions.
2130 (gsettings_client, gsettings_obj): New variables.
2131 (GSETTINGS_SCHEMA): New define.
2132 (something_changedCB): Call store_monospaced_changed.
2133 (init_gsettings): New function.
2134 (xsettings_initialize): Call init_gsettings.
2135 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2136 to NULL.
2137
2138 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
2139 GCONF_CFLAGS/LIBS.
2140
2141 2011-06-29 Martin Rudalics <rudalics@gmx.at>
2142
2143 * window.c (resize_root_window, grow_mini_window)
2144 (shrink_mini_window): Rename Qresize_root_window to
2145 Qwindow_resize_root_window and Qresize_root_window_vertically to
2146 Qwindow_resize_root_window_vertically.
2147
2148 2011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2149
2150 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2151
2152 2011-06-27 Juanma Barranquero <lekktu@gmail.com>
2153
2154 * makefile.w32-in: Redesign dependencies so they reflect more
2155 clearly which files are directly included by each source file,
2156 and not through other includes.
2157
2158 2011-06-27 Martin Rudalics <rudalics@gmx.at>
2159
2160 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2161 (sort_overlays, overlay_strings): When an overlay's clone number
2162 matches the window's clone number process the overlay even if
2163 the overlay's window property doesn't match the current window.
2164
2165 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2166 (Fwindow_hchild): Rename to Fwindow_left_child.
2167 (Fwindow_next): Rename to Fwindow_next_sibling.
2168 (Fwindow_prev): Rename to Fwindow_prev_sibling.
2169 (resize_window_check): Rename to window_resize_check.
2170 (resize_window_apply): Rename to window_resize_apply.
2171 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2172 (Fdelete_other_windows_internal, resize_frame_windows)
2173 (Fsplit_window_internal, Fdelete_window_internal)
2174 (grow_mini_window, shrink_mini_window)
2175 (Fresize_mini_window_internal): Fix callers accordingly.
2176
2177 2011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2178
2179 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2180 (emacs_fixed_set_min_size): Remove.
2181 (emacs_fixed_new): Take frame as argument.
2182
2183 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2184 (_EmacsFixedPrivate): Remove minwidth/height.
2185 Add struct frame *f.
2186 (emacs_fixed_init): Initialize priv->f.
2187 (get_parent_class, emacs_fixed_set_min_size): Remove.
2188 (emacs_fixed_new): Set priv->f to argument.
2189 (emacs_fixed_get_preferred_width)
2190 (emacs_fixed_get_preferred_height): Use min_width/height from
2191 frames size_hint to set minimum and natural (Bug#8919).
2192 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2193 and use min_width/height from frames size_hint to set
2194 min_width/height (Bug#8919).
2195
2196 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
2197 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2198 Fix indentation.
2199
2200 2011-06-26 Eli Zaretskii <eliz@gnu.org>
2201
2202 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2203 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2204 called at ZV.
2205
2206 2011-06-26 Chong Yidong <cyd@stupidchicken.com>
2207
2208 * process.c (wait_reading_process_output): Bypass select if
2209 waiting for a cell while ignoring keyboard input, and input is
2210 pending. Suggested by Jan Djärv (Bug#8869).
2211
2212 2011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2213
2214 Use gnulib's dup2 module instead of rolling our own.
2215 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2216
2217 2011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2218
2219 * dispnew.c (scrolling_window): Before scrolling, turn off a
2220 mouse-highlight in the window being scrolled.
2221
2222 2011-06-24 Juanma Barranquero <lekktu@gmail.com>
2223
2224 Move DEFSYM to lisp.h and use everywhere.
2225
2226 * character.h (DEFSYM): Move declaration...
2227 * lisp.h (DEFSYM): ...here.
2228
2229 * gnutls.c:
2230 * minibuf.c:
2231 * w32menu.c:
2232 * w32proc.c:
2233 * w32select.c: Don't include character.h.
2234
2235 * alloc.c (syms_of_alloc):
2236 * buffer.c (syms_of_buffer):
2237 * bytecode.c (syms_of_bytecode):
2238 * callint.c (syms_of_callint):
2239 * casefiddle.c (syms_of_casefiddle):
2240 * casetab.c (init_casetab_once):
2241 * category.c (init_category_once, syms_of_category):
2242 * ccl.c (syms_of_ccl):
2243 * cmds.c (syms_of_cmds):
2244 * composite.c (syms_of_composite):
2245 * dbusbind.c (syms_of_dbusbind):
2246 * dired.c (syms_of_dired):
2247 * dispnew.c (syms_of_display):
2248 * doc.c (syms_of_doc):
2249 * editfns.c (syms_of_editfns):
2250 * emacs.c (syms_of_emacs):
2251 * eval.c (syms_of_eval):
2252 * fileio.c (syms_of_fileio):
2253 * fns.c (syms_of_fns):
2254 * frame.c (syms_of_frame):
2255 * fringe.c (syms_of_fringe):
2256 * insdel.c (syms_of_insdel):
2257 * keymap.c (syms_of_keymap):
2258 * lread.c (init_obarray, syms_of_lread):
2259 * macros.c (syms_of_macros):
2260 * msdos.c (syms_of_msdos):
2261 * print.c (syms_of_print):
2262 * process.c (syms_of_process):
2263 * search.c (syms_of_search):
2264 * sound.c (syms_of_sound):
2265 * syntax.c (init_syntax_once, syms_of_syntax):
2266 * terminal.c (syms_of_terminal):
2267 * textprop.c (syms_of_textprop):
2268 * undo.c (syms_of_undo):
2269 * w32.c (globals_of_w32):
2270 * window.c (syms_of_window):
2271 * xdisp.c (syms_of_xdisp):
2272 * xfaces.c (syms_of_xfaces):
2273 * xfns.c (syms_of_xfns):
2274 * xmenu.c (syms_of_xmenu):
2275 * xsettings.c (syms_of_xsettings):
2276 * xterm.c (syms_of_xterm): Use DEFSYM.
2277
2278 2011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2279
2280 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
2281
2282 2011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2283
2284 Integer and buffer overflow fixes (Bug#8873).
2285
2286 * print.c (printchar, strout): Check for string overflow.
2287 (PRINTPREPARE, printchar, strout):
2288 Don't set size unless allocation succeeds.
2289
2290 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2291 for sizes. Check for string overflow more accurately.
2292 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2293
2294 * macros.c: Integer and buffer overflow fixes.
2295 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2296 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2297 Use ptrdiff_t, not int, for sizes.
2298 Don't increment bufsize until after realloc succeeds.
2299 Check for size-calculation overflow.
2300 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2301
2302 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2303
2304 * lread.c: Integer overflow fixes.
2305 (read_integer): Radix is now EMACS_INT, not int,
2306 to improve quality of diagnostics for out-of-range radices.
2307 Calculate buffer size correctly for out-of-range radices.
2308 (read1): Check for integer overflow in radices, and in
2309 read-circle numbers.
2310 (read_escape): Avoid int overflow.
2311 (Fload, openp, read_buffer_size, read1)
2312 (substitute_object_recurse, read_vector, read_list, map_obarray):
2313 Use ptrdiff_t, not int, for sizes.
2314 (read1): Use EMACS_INT, not int, for sizes.
2315 Check for size overflow.
2316
2317 * image.c (cache_image): Check for size arithmetic overflow.
2318
2319 * lread.c: Integer overflow issues.
2320 (saved_doc_string_size, saved_doc_string_length)
2321 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2322 Now ptrdiff_t, not int.
2323 (read1): Don't assume doc string length fits in int. Check for
2324 out-of-range doc string lengths.
2325 (read_list): Don't assume file position fits in int.
2326 (read_escape): Check for hex character overflow.
2327
2328 2011-06-22 Leo Liu <sdl.web@gmail.com>
2329
2330 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2331 Move to minibuffer.el.
2332
2333 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2334
2335 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
2336 The following patches are for when GLYPH_DEBUG && !XASSERT.
2337 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2338 * dispnew.c (flush_stdout):
2339 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2340 Mark as externally visible.
2341 * dispnew.c (check_window_matrix_pointers): Now static.
2342 * dispnew.c (window_to_frame_vpos):
2343 * xfns.c (unwind_create_frame):
2344 * xterm.c (x_check_font): Remove unused local.
2345 * scroll.c (CHECK_BOUNDS):
2346 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2347 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2348 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2349 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2350 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2351 Now static.
2352 (debug_method_add): Use va_list and vsprintf rather than relying
2353 on undefined behavior with wrong number of arguments.
2354 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2355 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2356 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2357 since we're not interested in debugging glyphs with old libraries.
2358 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2359 GCC 4.6.0's static checking.
2360
2361 2011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2362
2363 Integer overflow and signedness fixes (Bug#8873).
2364 A few related buffer overrun fixes, too.
2365
2366 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2367
2368 * dispextern.h (struct face.stipple):
2369 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2370 (x_bitmap_mask, x_allocate_bitmap_record)
2371 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2372 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2373 (x_create_bitmap_from_xpm_data):
2374 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2375 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2376 (.bitmaps_last):
2377 * xfaces.c (load_pixmap):
2378 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2379 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2380 (.bitmaps_last, struct x_output.icon_bitmap):
2381 Use ptrdiff_t, not int, for bitmap indexes.
2382 (x_allocate_bitmap_record): Check for size overflow.
2383 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2384
2385 Use ptrdiff_t, not int, for overlay counts.
2386 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2387 * editfns.c (overlays_around, get_pos_property):
2388 * textprop.c (get_char_property_and_overlay):
2389 * xdisp.c (next_overlay_change, note_mouse_highlight):
2390 * xfaces.c (face_at_buffer_position):
2391 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2392 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2393 (Fnext_overlay_change, Fprevious_overlay_change)
2394 (mouse_face_overlay_overlaps, Foverlays_in):
2395 Use ptrdiff_t, not int, for sizes.
2396 (overlays_at, overlays_in): Check for size-calculation overflow.
2397
2398 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2399
2400 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2401 (x_session_initialize): Do not assume string length fits in int.
2402
2403 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2404 This is unlikely, but can occur if DPI is outlandish.
2405
2406 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
2407 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2408
2409 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2410 * xrdb.c (magic_file_p, search_magic_path):
2411 Omit last arg SUFFIX; it was always 0. All callers changed.
2412 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2413
2414 * xfont.c (xfont_match): Avoid need for strlen.
2415
2416 * xfns.c: Don't assume strlen fits in int.
2417 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2418
2419 * xdisp.c (message_log_check_duplicate): Return intmax_t,
2420 not unsigned long, as we prefer signed integers. All callers changed.
2421 Detect integer overflow in repeat count.
2422 (message_dolog): Don't assume print length fits in 39 bytes.
2423 (display_mode_element): Don't assume strlen fits in int.
2424
2425 * termcap.c: Don't assume sizes fit in int and never overflow.
2426 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2427 (gobble_line): Check for size-calculation overflow.
2428
2429 * minibuf.c (Fread_buffer):
2430 * lread.c (intern, intern_c_string):
2431 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
2432 Don't assume string length fits in int.
2433
2434 * keyboard.c (parse_tool_bar_item):
2435 * gtkutil.c (style_changed_cb): Avoid need for strlen.
2436
2437 * font.c: Don't assume string length fits in int.
2438 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
2439 Use ptrdiff_t, not int.
2440 (font_intern_prop): Don't assume string length fits in int.
2441 Don't assume integer property fits in fixnum.
2442 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
2443
2444 * filelock.c: Fix some buffer overrun and integer overflow issues.
2445 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
2446 Reformulate so as not to need the command string.
2447 Invoke gzip -cd rather than gunzip, as it's more portable.
2448 (lock_info_type, lock_file_1, lock_file):
2449 Don't assume pid_t and time_t fit in unsigned long.
2450 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
2451 (current_lock_owner): Prefer signed type for sizes.
2452 Use memcpy, not strncpy, where memcpy is what is really wanted.
2453 Don't assume (via atoi) that time_t and pid_t fit in int.
2454 Check for time_t and/or pid_t out of range, e.g., via a network share.
2455 Don't alloca where an auto var works fine.
2456
2457 * fileio.c: Fix some integer overflow issues.
2458 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
2459 Don't assume string length fits in int.
2460 (directory_file_name): Don't assume string length fits in long.
2461 (make_temp_name): Don't assume pid fits in int, or that its print
2462 length is less than 20.
2463
2464 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
2465
2466 * coding.c (make_subsidiaries): Don't assume string length fits in int.
2467
2468 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
2469
2470 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
2471 We prefer signed integers, even for size calculations.
2472
2473 * emacs.c: Don't assume string length fits in 'int'.
2474 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
2475 (main): Don't invoke strlen when not needed.
2476
2477 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
2478 (XD_DEBUG_MESSAGE): Don't waste a byte.
2479
2480 * callproc.c (getenv_internal_1, getenv_internal)
2481 (Fgetenv_internal):
2482 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
2483
2484 * lread.c (invalid_syntax): Omit length argument.
2485 All uses changed. This doesn't fix a bug, but it simplifies the
2486 code away from its former Hollerith-constant appearance, and it's
2487 one less 'int' to worry about when looking at integer-overflow issues.
2488 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
2489
2490 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
2491 This didn't break anything, but it didn't help either.
2492 It's confusing to put a bogus integer in a place where the actual
2493 value does not matter.
2494 (LIST_END_P): Remove unused macro and its bogus comment.
2495 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
2496
2497 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
2498 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
2499 implementation.
2500 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
2501 We prefer signed types, and the value cannot exceed the EMACS_INT
2502 range anyway (because otherwise the length would not be representable).
2503 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
2504 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
2505 This avoids a GCC warning when WIDE_EMACS_INT.
2506
2507 * indent.c (sane_tab_width): New function.
2508 (current_column, scan_for_column, Findent_to, position_indentation)
2509 (compute_motion): Use it. This is just for clarity.
2510 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
2511
2512 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
2513
2514 * lisp.h (lint_assume): New macro.
2515 * composite.c (composition_gstring_put_cache):
2516 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
2517
2518 * editfns.c, insdel.c:
2519 Omit unnecessary forward decls, to simplify future changes.
2520
2521 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
2522
2523 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
2524
2525 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
2526 Use much-faster test for byte-length change.
2527 Don't assume string byte-length fits in 'int'.
2528 Check that character arg fits in 'int'.
2529 (mapcar1): Declare byte as byte, for clarity.
2530
2531 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
2532
2533 * fns.c (concat): Catch string overflow earlier.
2534 Do not rely on integer wraparound.
2535
2536 * dispextern.h (struct it.overlay_strings_charpos)
2537 (struct it.selective): Now EMACS_INT, not int.
2538 * xdisp.c (forward_to_next_line_start)
2539 (back_to_previous_visible_line_start)
2540 (reseat_at_next_visible_line_start, next_element_from_buffer):
2541 Don't arbitrarily truncate the value of 'selective' to int.
2542
2543 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
2544
2545 * composite.c: Don't truncate sizes to 'int'.
2546 (composition_gstring_p, composition_reseat_it)
2547 (composition_adjust_point): Use EMACS_INT, not int.
2548 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
2549 not EMACS_UINT, for indexes.
2550
2551 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
2552
2553 * buffer.c: Include <verify.h>.
2554 (struct sortvec.priority, struct sortstr.priority):
2555 Now EMACS_INT, not int.
2556 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
2557 (struct sortstr.size, record_overlay_string)
2558 (struct sortstrlist.size, struct sortlist.used):
2559 Don't truncate size to int.
2560 (record_overlay_string): Check for size-calculation overflow.
2561 (init_buffer_once): Check at compile-time, not run-time.
2562
2563 2011-06-22 Jim Meyering <meyering@redhat.com>
2564
2565 Don't leak an XBM-image-sized buffer
2566 * image.c (xbm_load): Free the image buffer after using it.
2567
2568 2011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2569
2570 Port to Sun C.
2571 * composite.c (find_automatic_composition): Omit needless 'return 0;'
2572 that Sun C diagnosed.
2573 * fns.c (secure_hash): Fix pointer signedness issue.
2574 * intervals.c (static_offset_intervals): New function.
2575 (offset_intervals): Use it.
2576
2577 2011-06-21 Leo Liu <sdl.web@gmail.com>
2578
2579 * deps.mk (fns.o):
2580 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
2581 sha512.h.
2582
2583 * fns.c (secure_hash): Rename from crypto_hash_function and change
2584 the first arg to accept symbols.
2585 (Fsecure_hash): New primitive.
2586 (syms_of_fns): New symbols.
2587
2588 2011-06-20 Deniz Dogan <deniz@dogan.se>
2589
2590 * process.c (Fset_process_buffer): Clarify return value in
2591 docstring.
2592
2593 2011-06-18 Chong Yidong <cyd@stupidchicken.com>
2594
2595 * dispnew.c (add_window_display_history): Use BVAR.
2596
2597 * xdisp.c (debug_method_add): Use BVAR.
2598 (check_window_end, dump_glyph_matrix, dump_glyph)
2599 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
2600
2601 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
2602 Likewise.
2603
2604 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
2605 check till after the cache is created in init_frame_faces.
2606
2607 2011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
2608
2609 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
2610
2611 2011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2612
2613 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
2614 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
2615 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
2616
2617 Improve buffer-overflow checking (Bug#8873).
2618 * fileio.c (Finsert_file_contents):
2619 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
2620 Remove the old (too-loose) buffer overflow checks.
2621 They weren't needed, since make_gap checks for buffer overflow.
2622 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
2623 The old code merely checked for Emacs fixnum overflow, and relied
2624 on undefined (wraparound) behavior. The new code avoids undefined
2625 behavior, and also checks for ptrdiff_t and/or size_t overflow.
2626
2627 * editfns.c (Finsert_char): Don't dump core with very negative counts.
2628 Tune. Don't use wider integers than needed. Don't use alloca.
2629 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2630
2631 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
2632
2633 * insdel.c, lisp.h (buffer_overflow): New function.
2634 (insert_from_buffer_1, replace_range, replace_range_2):
2635 * insdel.c (make_gap_larger):
2636 * editfns.c (Finsert_char):
2637 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
2638
2639 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
2640
2641 2011-06-15 Paul Eggert <eggert@cs.ucla.edu>
2642
2643 Integer overflow and signedness fixes (Bug#8873).
2644
2645 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
2646 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
2647
2648 * fileio.c: Don't assume EMACS_INT fits in off_t.
2649 (emacs_lseek): New static function.
2650 (Finsert_file_contents, Fwrite_region): Use it.
2651 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
2652
2653 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
2654
2655 * fns.c: Don't overflow int when computing a list length.
2656 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
2657 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
2658 truncation on 64-bit hosts. Check for QUIT every
2659 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
2660 faster and is responsive enough.
2661 (Flength): Report an error instead of overflowing an integer.
2662 (Fsafe_length): Return a float if the value is not representable
2663 as a fixnum. This shouldn't happen except in contrived situations.
2664 (Fnthcdr, Fsort): Don't assume list length fits in int.
2665 (Fcopy_sequence): Don't assume vector length fits in int.
2666
2667 * alloc.c: Check that resized vectors' lengths fit in fixnums.
2668 (header_size, word_size): New constants.
2669 (allocate_vectorlike): Don't check size overflow here.
2670 (allocate_vector): Check it here instead, since this is the only
2671 caller of allocate_vectorlike that could cause overflow.
2672 Check that the new vector's length is representable as a fixnum.
2673
2674 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
2675 The previous code was bogus. For example, next_almost_prime (32)
2676 returned 39, which is undesirable as it is a multiple of 3; and
2677 next_almost_prime (24) returned 25, which is a multiple of 5 so
2678 why was the code bothering to check for multiples of 7?
2679
2680 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
2681
2682 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
2683
2684 Variadic C functions now count arguments with ptrdiff_t.
2685 This partly undoes my 2011-03-30 change, which replaced int with size_t.
2686 Back then I didn't know that the Emacs coding style prefers signed int.
2687 Also, in the meantime I found a few more instances where arguments
2688 were being counted with int, which may truncate counts on 64-bit
2689 machines, or EMACS_INT, which may be unnecessarily wide.
2690 * lisp.h (struct Lisp_Subr.function.aMANY)
2691 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
2692 Arg counts are now ptrdiff_t, not size_t.
2693 All variadic functions and their callers changed accordingly.
2694 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
2695 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
2696 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
2697 * callint.c (Fcall_interactively): Check arg count for overflow,
2698 to avoid potential buffer overrun. Use signed char, not 'int',
2699 for 'varies' array, so that we needn't bother to check its size
2700 calculation for overflow.
2701 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
2702 * eval.c (apply_lambda):
2703 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
2704 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
2705 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
2706
2707 * callint.c (Fcall_interactively): Don't use index var as event count.
2708
2709 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
2710 * mem-limits.h (SIZE): Remove; no longer used.
2711
2712 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
2713
2714 Remove unnecessary casts.
2715 * xterm.c (x_term_init):
2716 * xfns.c (x_set_border_pixel):
2717 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
2718 These aren't needed now that we assume ANSI C.
2719
2720 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
2721 It's more likely to cause problems (due to unsigned overflow)
2722 than to cure them.
2723
2724 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
2725
2726 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
2727
2728 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
2729
2730 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
2731
2732 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
2733
2734 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
2735
2736 GLYPH_CODE_FACE returns EMACS_INT, not int.
2737 * dispextern.h (merge_faces):
2738 * xfaces.c (merge_faces):
2739 * xdisp.c (get_next_display_element, next_element_from_display_vector):
2740 Don't assume EMACS_INT fits in int.
2741
2742 * character.h (CHAR_VALID_P): Remove unused parameter.
2743 * fontset.c, lisp.h, xdisp.c: All uses changed.
2744
2745 * editfns.c (Ftranslate_region_internal): Omit redundant test.
2746
2747 * fns.c (concat): Minor tuning based on overflow analysis.
2748 This doesn't fix any bugs. Use int to hold character, instead
2749 of constantly refetching from Emacs object. Use XFASTINT, not
2750 XINT, for value known to be a character. Don't bother comparing
2751 a single byte to 0400, as it's always less.
2752
2753 * floatfns.c (Fexpt):
2754 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
2755
2756 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
2757 for characters.
2758
2759 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
2760
2761 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
2762 Without this fix, on a 64-bit host (aset S 0 4294967386) would
2763 incorrectly succeed when S was a string, because 4294967386 was
2764 truncated before it was used.
2765
2766 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
2767 Otherwise, an out-of-range integer could cause undefined behavior
2768 on a 64-bit host.
2769
2770 * composite.c: Use int, not EMACS_INT, for characters.
2771 (fill_gstring_body, composition_compute_stop_pos): Use int, not
2772 EMACS_INT, for values that are known to be in character range.
2773 This doesn't fix any bugs but is the usual style inside Emacs and
2774 may generate better code on 32-bit machines.
2775
2776 Make sure a 64-bit char is never passed to ENCODE_CHAR.
2777 This is for reasons similar to the recent CHAR_STRING fix.
2778 * charset.c (Fencode_char): Check that character arg is actually
2779 a character. Pass an int to ENCODE_CHAR.
2780 * charset.h (ENCODE_CHAR): Verify that the character argument is no
2781 wider than 'int', as a compile-time check to prevent future regressions
2782 in this area.
2783
2784 * character.c (char_string): Remove unnecessary casts.
2785
2786 Make sure a 64-bit char is never passed to CHAR_STRING.
2787 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
2788 by silently ignoring the top 32 bits, allowing some values
2789 that were far too large to be valid characters.
2790 * character.h: Include <verify.h>.
2791 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
2792 arguments are no wider than unsigned, as a compile-time check
2793 to prevent future regressions in this area.
2794 * data.c (Faset):
2795 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
2796 (Fsubst_char_in_region):
2797 * fns.c (concat):
2798 * xdisp.c (decode_mode_spec_coding):
2799 Adjust to CHAR_STRING's new requirement.
2800 * editfns.c (Finsert_char, Fsubst_char_in_region):
2801 * fns.c (concat): Check that character args are actually
2802 characters. Without this test, these functions did the wrong
2803 thing with wildly out-of-range values on 64-bit hosts.
2804
2805 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
2806 These casts should not be needed on 32-bit hosts, either.
2807 * keyboard.c (read_char):
2808 * lread.c (Fload): Remove casts to unsigned.
2809
2810 * lisp.h (UNSIGNED_CMP): New macro.
2811 This fixes comparison bugs on 64-bit hosts.
2812 (ASCII_CHAR_P): Use it.
2813 * casefiddle.c (casify_object):
2814 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
2815 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
2816 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
2817 * dispextern.h (FACE_FROM_ID):
2818 * keyboard.c (read_char): Use UNSIGNED_CMP.
2819
2820 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
2821 not to EMACS_INT, to avoid GCC warning.
2822
2823 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
2824
2825 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
2826 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
2827 isn't needed on 32-bit machines.
2828
2829 * buffer.c (Fgenerate_new_buffer_name):
2830 Use EMACS_INT for count, not int.
2831 (advance_to_char_boundary): Return EMACS_INT, not int.
2832
2833 * data.c (Qcompiled_function): Now static.
2834
2835 * window.c (window_body_lines): Now static.
2836
2837 * image.c (gif_load): Rename local to avoid shadowing.
2838
2839 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
2840 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
2841 * alloc.c (make_save_value): Integer argument is now of type
2842 ptrdiff_t, not int.
2843 (mark_object): Use ptrdiff_t, not int.
2844 * lisp.h (pD): New macro.
2845 * print.c (print_object): Use it.
2846
2847 * alloc.c: Use EMACS_INT, not int, to count objects.
2848 (total_conses, total_markers, total_symbols, total_vector_size)
2849 (total_free_conses, total_free_markers, total_free_symbols)
2850 (total_free_floats, total_floats, total_free_intervals)
2851 (total_intervals, total_strings, total_free_strings):
2852 Now EMACS_INT, not int. All uses changed.
2853 (Fgarbage_collect): Compute overall total using a double, so that
2854 integer overflow is less likely to be a problem. Check for overflow
2855 when converting back to an integer.
2856 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
2857 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
2858 These were 'int' variables that could overflow on 64-bit hosts;
2859 they were never used, so remove them instead of repairing them.
2860 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
2861 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
2862 Previously, this ceilinged at INT_MAX, but that doesn't work on
2863 64-bit machines.
2864 (allocate_pseudovector): Don't use EMACS_INT when int would do.
2865
2866 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
2867 (allocate_vectorlike): Check for ptrdiff_t overflow.
2868 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2869 when a (possibly-narrower) signed value would do just as well.
2870 We prefer using signed arithmetic, to avoid comparison confusion.
2871
2872 * alloc.c: Catch some string size overflows that we were missing.
2873 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2874 for convenience in STRING_BYTES_MAX.
2875 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2876 The definition here is exact; the one in lisp.h was approximate.
2877 (allocate_string_data): Check for string overflow. This catches
2878 some instances we weren't catching before. Also, it catches
2879 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2880 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2881 and ptrdiff_t and EMACS_INT are both 64 bits.
2882
2883 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2884 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
2885 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
2886
2887 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2888
2889 * alloc.c (Fmake_string): Check for out-of-range init.
2890
2891 2011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2892
2893 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2894
2895 2011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2896
2897 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2898 xg_get_default_scrollbar_width.
2899
2900 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2901 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2902 (style_changed_cb): Call update_theme_scrollbar_width and call
2903 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2904 all frames (Bug#8505).
2905 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2906 Call gtk_window_set_resizable if HAVE_GTK3.
2907 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2908 and height if HAVE_GTK3 (Bug#8505).
2909 (scroll_bar_width_for_theme): New variable.
2910 (update_theme_scrollbar_width): New function.
2911 (xg_get_default_scrollbar_width): Move code to
2912 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2913 (xg_initialize): Call update_theme_scrollbar_width.
2914
2915 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2916
2917 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2918
2919 2011-06-12 Martin Rudalics <rudalics@gmx.at>
2920
2921 * frame.c (make_frame): Call other_buffer_safely instead of
2922 other_buffer.
2923
2924 * window.c (temp_output_buffer_show): Call display_buffer with
2925 second argument Vtemp_buffer_show_specifiers and reset latter
2926 immediately after the call.
2927 (Vtemp_buffer_show_specifiers): New variable.
2928 (auto_window_vscroll_p, next_screen_context_lines)
2929 (Vscroll_preserve_screen_position): Remove leading asterisks from
2930 doc-strings.
2931
2932 2011-06-12 Paul Eggert <eggert@cs.ucla.edu>
2933
2934 Fix minor problems found by GCC 4.6.0 static checking.
2935 * buffer.c (Qclone_number): Remove for now, as it's unused.
2936 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2937 (record_buffer): Remove unused local.
2938 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2939 (set_frame_buffer_list): Remove; unused.
2940 * frame.h (other_visible_frames): Remove decl.
2941 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2942 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2943 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2944 if HAVE_GPM.
2945 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2946 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2947 Define only if HAVE_GPM.
2948 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2949 (update_hints_inhibit): Remove; never set. All uses removed.
2950 * widgetprv.h (emacsFrameClassRec): Remove decl.
2951 * window.c (delete_deletable_window): Now returns void, since it
2952 wasn't returning anything.
2953 (compare_window_configurations): Remove unused locals.
2954 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2955 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
2956 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2957 the same widths as pointers. This follows up on the 2011-05-06 patch.
2958 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2959 * xterm.h: Likewise.
2960 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2961
2962 2011-06-12 Juanma Barranquero <lekktu@gmail.com>
2963
2964 * makefile.w32-in: Update dependencies.
2965 (LISP_H): Add lib/intprops.h.
2966
2967 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2968
2969 * image.c (gif_load): Add animation frame delay to the metadata.
2970 (syms_of_image): Use DEFSYM. New symbol `delay'.
2971
2972 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2973
2974 * window.c (delete_deletable_window): Re-add.
2975 (Fset_window_configuration): Rewrite to handle dead buffers and
2976 consequently deletable windows.
2977 (window_tree, Fwindow_tree): Remove. Supply functionality in
2978 window.el.
2979 (compare_window_configurations): Simplify code.
2980
2981 2011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2982
2983 * image.c (imagemagick_load_image): Fix type mismatch.
2984 (Fimagemagick_types): Likewise.
2985
2986 * window.h (replace_buffer_in_windows): Declare.
2987
2988 2011-06-11 Martin Rudalics <rudalics@gmx.at>
2989
2990 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2991 Qclone_number. Remove external declaration of Qdelete_window.
2992 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2993 code.
2994 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
2995 Run Qbuffer_list_update_hook if allowed.
2996 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2997 buffer list implementation.
2998 (other_buffer_safely): New function.
2999 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3000 calls to replace_buffer_in_windows and
3001 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3002 if allowed.
3003 (record_buffer): Inhibit quitting and rewrite using quittable
3004 functions. Run Qbuffer_list_update_hook if allowed.
3005 (Frecord_buffer, Funrecord_buffer): New functions.
3006 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3007 Move switch-to-buffer to window.el.
3008 (bury-buffer): Move to window.el.
3009 (Vbuffer_list_update_hook): New variable.
3010
3011 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3012 section.
3013
3014 * window.h (resize_frame_windows): Move up in code.
3015 (Fwindow_frame): Remove EXFUN.
3016 (replace_buffer_in_all_windows): Remove prototype.
3017 (replace_buffer_in_windows_safely): Add prototype.
3018
3019 * window.c: Declare Qdelete_window static again. Move down
3020 declaration of select_count.
3021 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3022 (Fother_window): Move to window.el.
3023 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3024 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3025 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3026 window.el.
3027 (replace_buffer_in_windows): Implement by calling
3028 Qreplace_buffer_in_windows.
3029 (replace_buffer_in_all_windows): Remove with some functionality
3030 moved into replace_buffer_in_windows_safely.
3031 (replace_buffer_in_windows_safely): New function.
3032 (select_window_norecord, select_frame_norecord): Move in front
3033 of run_window_configuration_change_hook. Remove now obsolete
3034 declarations.
3035 (Fset_window_buffer): Rewrite doc-string.
3036 Call Qrecord_window_buffer.
3037 (keys_of_window): Move binding for other-window to window.el.
3038
3039 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
3040
3041 * dispextern.h (struct image): Replace data member, whose int_val
3042 and ptr_val fields were not used by anything, with a single
3043 lisp_val object.
3044
3045 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3046 (gif_clear_image, gif_load, imagemagick_load_image)
3047 (gs_clear_image, gs_load): Callers changed.
3048
3049 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3050
3051 * buffer.h: Include <time.h>, for time_t.
3052 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3053
3054 Fix minor problems found by static checking.
3055
3056 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3057
3058 Make identifiers static if they are not used in other modules.
3059 * data.c (Qcompiled_function, Qframe, Qvector):
3060 * image.c (QimageMagick, Qsvg):
3061 * minibuf.c (Qmetadata):
3062 * window.c (resize_window_check, resize_root_window): Now static.
3063 * window.h (resize_window_check, resize_root_window): Remove decls.
3064
3065 * window.c (window_deletion_count, delete_deletable_window):
3066 Remove; unused.
3067 (window_body_lines): Now static.
3068 (Fdelete_other_windows_internal): Mark vars as initialized.
3069 Make sure 'resize_failed' is initialized.
3070 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3071 (resize_window_apply): Remove unused local.
3072 * window.h (delete_deletable_window): Remove decl.
3073
3074 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
3075 (imagemagick_load_image): Fix pointer signedness problem by changing
3076 last arg from unsigned char * to char *. All uses changed.
3077 Also, fix a local for similar reasons.
3078 Remove unused locals. Remove locals to avoid shadowing.
3079 (fn_rsvg_handle_free): Remove; unused.
3080 (svg_load, svg_load_image): Fix pointer signedness problem.
3081 (imagemagick_load_image): Don't use garbage pointer image_wand.
3082
3083 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3084
3085 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
3086
3087 * image.c (gif_load): Fix omitted cast error introduced by
3088 2011-06-06 change.
3089
3090 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3091
3092 * window.h (resize_proportionally, orig_total_lines)
3093 (orig_top_line): Remove from window structure.
3094 (set_window_height, set_window_width, change_window_heights)
3095 (Fdelete_window): Remove prototypes.
3096 (resize_frame_windows): Remove duplicate declaration.
3097
3098 2011-06-10 Eli Zaretskii <eliz@gnu.org>
3099
3100 * window.h (resize_frame_windows, resize_window_check)
3101 (delete_deletable_window, resize_root_window)
3102 (resize_frame_windows): Declare prototypes.
3103
3104 * window.c (resize_window_apply): Make definition be "static" to
3105 match the prototype.
3106
3107 2011-06-10 Martin Rudalics <rudalics@gmx.at>
3108
3109 * window.c: Remove declarations of Qwindow_size_fixed,
3110 window_min_size_1, window_min_size_2, window_min_size,
3111 size_window, window_fixed_size_p, enlarge_window, delete_window.
3112 Remove static from declaration of Qdelete_window, it's
3113 temporarily needed by Fbury_buffer.
3114 (replace_window): Don't assign orig_top_line and
3115 orig_total_lines.
3116 (Fdelete_window, delete_window): Remove. Window deletion is
3117 handled by window.el.
3118 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3119 Replace Fdelete_window calls with calls to Qdelete_window.
3120 (Fdelete_other_windows): Remove. Deleting other windows is
3121 handled by window.el.
3122 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3123 handled in window.el.
3124 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3125 Window minimum sizes are handled in window.el.
3126 (shrink_windows, size_window, set_window_height)
3127 (set_window_width, change_window_heights, window_height)
3128 (window_width, CURBEG, CURSIZE, enlarge_window)
3129 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3130 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3131 handled in window.el.
3132 (make_dummy_parent): Rename to make_parent_window and give it a
3133 second argument horflag.
3134 (make_window): Don't set resize_proportionally any more.
3135 (Fsplit_window): Remove. Windows are split in window.el.
3136 (save_restore_action, save_restore_orig_size)
3137 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3138 Resize mini windows in window.el.
3139 (grow_mini_window, shrink_mini_window): Implement by calling
3140 Qresize_root_window_vertically, resize_window_check and
3141 resize_window_apply.
3142 (saved_window, Fset_window_configuration, save_window_save):
3143 Do not handle orig_top_line, orig_total_lines, and
3144 resize_proportionally.
3145 (window_min_height, window_min_width): Move to window.el.
3146 (keys_of_window): Move bindings for delete-other-windows,
3147 split-window, delete-window and enlarge-window to window.el.
3148
3149 * buffer.c: Temporarily extern Qdelete_window.
3150 (Fbury_buffer): Temporarily call Qdelete_window instead of
3151 Fdelete_window (Fbury_buffer will move to window.el soon).
3152
3153 * frame.c (set_menu_bar_lines_1): Remove code handling
3154 orig_top_line and orig_total_lines.
3155
3156 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3157 set_window_height but set heights directly.
3158 (change_frame_size_1): Use resize_frame_windows.
3159
3160 * xdisp.c (init_xdisp): Don't use set_window_height but set
3161 heights directly.
3162
3163 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3164 Use resize_frame_windows instead of change_window_heights and run
3165 run_window_configuration_change_hook.
3166
3167 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3168 instead of change_window_heights and run
3169 run_window_configuration_change_hook.
3170
3171 2011-06-09 Martin Rudalics <rudalics@gmx.at>
3172
3173 * window.c (replace_window): Rename second argument REPLACEMENT to
3174 NEW. New third argument SETFLAG. Rewrite.
3175 (delete_window, make_dummy_parent): Call replace_window with
3176 third argument 1.
3177 (window_list_1): Move down in code.
3178 (run_window_configuration_change_hook): Move set_buffer part
3179 before select_frame_norecord part in order to unwind correctly.
3180 Rename count1 to count.
3181 (recombine_windows, delete_deletable_window, resize_root_window)
3182 (Fdelete_other_windows_internal)
3183 (Frun_window_configuration_change_hook, make_parent_window)
3184 (resize_window_check, resize_window_apply, Fresize_window_apply)
3185 (resize_frame_windows, Fsplit_window_internal)
3186 (Fdelete_window_internal, Fresize_mini_window_internal):
3187 New functions.
3188 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3189
3190 2011-06-08 Martin Rudalics <rudalics@gmx.at>
3191
3192 * window.h (window): Add some new members to window structure -
3193 normal_lines, normal_cols, new_total, new_normal, clone_number,
3194 splits, nest, prev_buffers, next_buffers.
3195 (WINDOW_TOTAL_SIZE): Move here from window.c.
3196 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
3197
3198 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3199 Remove.
3200 (make_dummy_parent): Set new members of windows structure.
3201 (make_window): Move down in code. Handle new members of window
3202 structure.
3203 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3204 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3205 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3206 (Fset_window_prev_buffers, Fwindow_next_buffers)
3207 (Fset_window_next_buffers, Fset_window_clone_number):
3208 New functions.
3209 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3210 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3211 Doc-string fixes.
3212 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3213 Argument WINDOW can be now internal window too.
3214 (Fwindow_use_time): Move up in code.
3215 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3216 Rewrite doc-string.
3217 (Fset_window_configuration, saved_window)
3218 (Fcurrent_window_configuration, save_window_save): Handle new
3219 members of window structure.
3220 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3221 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3222 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3223 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3224 Qget_mru_window, Qresize_root_window,
3225 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3226 Qauto_buffer_name; staticpro them.
3227
3228 2011-06-07 Martin Rudalics <rudalics@gmx.at>
3229
3230 * window.c (Fwindow_total_size, Fwindow_left_column)
3231 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3232 (Fwindow_list_1): New functions.
3233 (window_box_text_cols): Replace with window_body_cols.
3234 (Fwindow_width, Fscroll_left, Fscroll_right):
3235 Use window_body_cols instead of window_box_text_cols.
3236 (delete_window, Fset_window_configuration):
3237 Call delete_all_subwindows with window as argument.
3238 (delete_all_subwindows): Take a window as argument and not a
3239 structure. Rewrite.
3240 (window_loop): Remove handling of GET_LRU_WINDOW and
3241 GET_LARGEST_WINDOW.
3242 (Fget_lru_window, Fget_largest_window): Move to window.el.
3243
3244 * window.h: Extern window_body_cols instead of
3245 window_box_text_cols. delete_all_subwindows now takes a
3246 Lisp_Object as argument.
3247
3248 * indent.c (compute_motion, Fcompute_motion):
3249 Use window_body_cols instead of window_box_text_cols.
3250
3251 * frame.c (delete_frame): Call delete_all_subwindows with root
3252 window as argument.
3253
3254 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3255
3256 * fns.c (Fputhash): Document return value.
3257
3258 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
3259
3260 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3261
3262 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3263
3264 Cons<->int and similar integer overflow fixes (Bug#8794).
3265
3266 Check for overflow when converting integer to cons and back.
3267 * charset.c (Fdefine_charset_internal, Fdecode_char):
3268 Use cons_to_unsigned to catch overflow.
3269 (Fencode_char): Use INTEGER_TO_CONS.
3270 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3271 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3272 * data.c (long_to_cons, cons_to_long): Remove.
3273 (cons_to_unsigned, cons_to_signed): New functions.
3274 These signal an error for invalid or out-of-range values.
3275 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3276 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3277 * font.c (Ffont_variation_glyphs):
3278 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3279 * lisp.h: Include <intprops.h>.
3280 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3281 (cons_to_signed, cons_to_unsigned): New decls.
3282 (long_to_cons, cons_to_long): Remove decls.
3283 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3284 (Fprimitive_undo): Use CONS_TO_INTEGER.
3285 * xfns.c (Fx_window_property): Likewise.
3286 * xselect.c: Include <limits.h>.
3287 (x_own_selection, selection_data_to_lisp_data):
3288 Use INTEGER_TO_CONS.
3289 (x_handle_selection_request, x_handle_selection_clear)
3290 (x_get_foreign_selection, Fx_disown_selection_internal)
3291 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3292 (lisp_data_to_selection_data): Use cons_to_unsigned.
3293 (x_fill_property_data): Use cons_to_signed.
3294 Report values out of range.
3295
3296 Check for buffer and string overflow more precisely.
3297 * buffer.h (BUF_BYTES_MAX): New macro.
3298 * lisp.h (STRING_BYTES_MAX): New macro.
3299 * alloc.c (Fmake_string):
3300 * character.c (string_escape_byte8):
3301 * coding.c (coding_alloc_by_realloc):
3302 * doprnt.c (doprnt):
3303 * editfns.c (Fformat):
3304 * eval.c (verror):
3305 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3306 since they may not be the same number.
3307 * editfns.c (Finsert_char):
3308 * fileio.c (Finsert_file_contents):
3309 Likewise for BUF_BYTES_MAX.
3310
3311 * image.c: Use ptrdiff_t, not int, for sizes.
3312 (slurp_file): Switch from int to ptrdiff_t.
3313 All uses changed.
3314 (slurp_file): Check that file size fits in both size_t (for
3315 malloc) and ptrdiff_t (for sanity and safety).
3316
3317 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3318 if b->modtime has its maximal value.
3319
3320 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3321
3322 Don't assume time_t can fit into int.
3323 * buffer.h (struct buffer.modtime): Now time_t, not int.
3324 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3325 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3326
3327 Minor fixes for signed vs unsigned integers.
3328 * character.h (MAYBE_UNIFY_CHAR):
3329 * charset.c (maybe_unify_char):
3330 * keyboard.c (read_char, reorder_modifiers):
3331 XINT -> XFASTINT, since the integer must be nonnegative.
3332 * ftfont.c (ftfont_spec_pattern):
3333 * keymap.c (access_keymap, silly_event_symbol_error):
3334 XUINT -> XFASTINT, since the integer must be nonnegative.
3335 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3336 since it makes no difference and we prefer signed.
3337 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3338 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3339 nonnegative.
3340
3341 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3342
3343 * window.h (Fwindow_frame): Declare.
3344
3345 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3346
3347 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3348 (SPARE_MEMORY): Always define.
3349 (LARGE_REQUEST): Remove.
3350 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3351
3352 2011-06-06 Martin Rudalics <rudalics@gmx.at>
3353
3354 * lisp.h: Move EXFUNS for Fframe_root_window,
3355 Fframe_first_window and Fset_frame_selected_window to window.h.
3356
3357 * window.h: Move EXFUNS for Fframe_root_window,
3358 Fframe_first_window and Fset_frame_selected_window here from
3359 lisp.h.
3360
3361 * frame.c (Fwindow_frame, Fframe_first_window)
3362 (Fframe_root_window, Fframe_selected_window)
3363 (Fset_frame_selected_window): Move to window.c.
3364 (Factive_minibuffer_window): Move to minibuf.c.
3365 (Fother_visible_frames_p): New function.
3366
3367 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3368
3369 * window.c (decode_window, decode_any_window): Move up in code.
3370 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3371 (inhibit_frame_unsplittable): Remove unused variable.
3372 (Fwindow_buffer): Move up and rewrite doc-string.
3373 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3374 (Fwindow_prev): New functions.
3375 (Fwindow_frame): Move here from frame.c. Accept any window as
3376 argument.
3377 (Fframe_root_window, Fframe_first_window)
3378 (Fframe_selected_window): Move here from frame.c. Accept frame
3379 or arbitrary window as argument. Update doc-strings.
3380 (Fminibuffer_window): Move up in code.
3381 (Fwindow_minibuffer_p): Move up in code and simplify.
3382 (Fset_frame_selected_window): Move here from frame.c.
3383 Marginal rewrite.
3384 (Fselected_window, select_window, Fselect_window): Move up in
3385 code. Minor doc-string fixes.
3386
3387 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3388
3389 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3390 Do not assume that spare memory exists; that assumption is valid
3391 only if SYSTEM_MALLOC.
3392 (LARGE_REQUEST): New macro, so that the issue of large requests
3393 is separated from the issue of spare memory.
3394
3395 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3396
3397 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3398 format. (Bug#8806)
3399
3400 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3401
3402 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3403 before statements.
3404
3405 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3406
3407 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3408
3409 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3410
3411 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3412 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3413
3414 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
3415
3416 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3417
3418 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
3419
3420 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
3421 (x_clipboard_manager_save): Add return value.
3422 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
3423 New error handlers.
3424 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3425 Obey Vx_select_enable_clipboard_manager. Catch errors in
3426 x_clipboard_manager_save (Bug#8779).
3427 (Vx_select_enable_clipboard_manager): New variable.
3428 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
3429
3430 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
3431
3432 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
3433
3434 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3435
3436 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
3437 in the current matrix if keep_current_p is non-zero.
3438
3439 2011-06-04 Eli Zaretskii <eliz@gnu.org>
3440
3441 * bidi.c (bidi_level_of_next_char): Fix last change.
3442
3443 2011-06-03 Eli Zaretskii <eliz@gnu.org>
3444
3445 Support bidi reordering of text covered by display properties.
3446
3447 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
3448 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
3449 (bidi_cache_search, bidi_cache_iterator_state)
3450 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3451 (bidi_level_of_next_char, bidi_move_to_visually_next):
3452 Support character positions inside a run of characters covered by a
3453 display string.
3454 (bidi_paragraph_init, bidi_resolve_explicit_1)
3455 (bidi_level_of_next_char): Call bidi_fetch_char and
3456 bidi_fetch_char_advance instead of FETCH_CHAR and
3457 FETCH_CHAR_ADVANCE.
3458 (bidi_init_it): Initialize new members.
3459 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
3460 definitions.
3461 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
3462 instead of using explicit *_CHAR codes.
3463 (bidi_resolve_explicit, bidi_resolve_weak):
3464 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
3465 bidirectional text is supported only in multibyte buffers.
3466 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
3467 it to initialize the frame_window_p member of struct bidi_it.
3468 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
3469 (bidi_resolve_explicit, bidi_resolve_weak)
3470 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
3471 bidi_it->nchars is non-positive.
3472 (bidi_level_of_next_char): Don't try to lookup the cache for the
3473 next/previous character if nothing is cached there yet, or if we
3474 were just reseat()'ed to a new position.
3475
3476 * xdisp.c (set_cursor_from_row): Set start and stop points
3477 according to the row's direction when priming the loop that looks
3478 for the glyph on which to display cursor.
3479 (single_display_spec_intangible_p): Function deleted.
3480 (display_prop_intangible_p): Reimplement to call
3481 handle_display_spec instead of single_display_spec_intangible_p.
3482 Accept 3 additional arguments needed by handle_display_spec.
3483 This fixes incorrect cursor motion across display property with complex
3484 values: lists, `(when COND...)' forms, etc.
3485 (single_display_spec_string_p): Support property values that are
3486 lists with the argument STRING its top-level element.
3487 (display_prop_string_p): Fix the condition for processing a
3488 property that is a list to be consistent with handle_display_spec.
3489 (handle_display_spec): New function, refactored from the
3490 last portion of handle_display_prop.
3491 (compute_display_string_pos): Accept additional argument
3492 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
3493 value of a `display' property is a "replacing spec".
3494 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
3495 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
3496 the display property, but just return a value indicating whether
3497 the display property will replace the characters it covers.
3498 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
3499 frame_window_p members of struct bidi_it.
3500 (compute_display_string_pos, compute_display_string_end):
3501 New functions.
3502 (push_it): Accept second argument POSITION, where pop_it should
3503 jump to continue iteration.
3504 (reseat_1): Initialize bidi_it.disp_pos.
3505
3506 * keyboard.c (adjust_point_for_property): Adjust the call to
3507 display_prop_intangible_p to its new signature.
3508
3509 * dispextern.h (struct bidi_it): New member frame_window_p.
3510 (bidi_init_it): Update prototypes.
3511 (display_prop_intangible_p): Update prototype.
3512 (compute_display_string_pos, compute_display_string_end):
3513 Declare prototypes.
3514 (struct bidi_it): New members nchars and disp_pos. ch_len is now
3515 EMACS_INT.
3516
3517 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
3518
3519 Malloc failure behavior now depends on size of allocation.
3520 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
3521 * lisp.h: Change signatures accordingly.
3522 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
3523 All callers changed. (Bug#8762)
3524
3525 * gnutls.c: Use Emacs's memory allocators.
3526 Without this change, the gnutls library would invoke malloc etc.
3527 directly, which causes problems on non-SYNC_INPUT hosts, and which
3528 runs afoul of improving memory_full behavior. (Bug#8761)
3529 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
3530 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
3531 xfree instead of the default malloc, realloc, free.
3532 (Fgnutls_boot): No need to check for memory allocation failure,
3533 since xmalloc does that for us.
3534
3535 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3536 * category.c (hash_get_category_set):
3537 * ccl.c (ccl_driver):
3538 * charset.c (Fdefine_charset_internal):
3539 * charset.h (struct charset.hash_index):
3540 * composite.c (get_composition_id, gstring_lookup_cache)
3541 (composition_gstring_put_cache):
3542 * composite.h (struct composition.hash_index):
3543 * dispextern.h (struct image.hash):
3544 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
3545 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
3546 (hashfn_equal, hashfn_user_defined, make_hash_table)
3547 (maybe_resize_hash_table, hash_lookup, hash_put)
3548 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
3549 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
3550 (Fsxhash, Fgethash, Fputhash, Fmaphash):
3551 * image.c (make_image, search_image_cache, lookup_image)
3552 (xpm_put_color_table_h):
3553 * lisp.h (struct Lisp_Hash_Table):
3554 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3555 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3556 for hashes and hash indexes, instead of 'unsigned' and 'int'.
3557 * alloc.c (allocate_vectorlike):
3558 Check for overflow in vector size calculations.
3559 * ccl.c (ccl_driver):
3560 Check for overflow when converting EMACS_INT to int.
3561 * fns.c, image.c: Remove unnecessary static decls that would otherwise
3562 need to be updated by these changes.
3563 * fns.c (make_hash_table, maybe_resize_hash_table):
3564 Check for integer overflow with large hash tables.
3565 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
3566 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
3567 (SXHASH_REDUCE): New macro.
3568 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
3569 Use it instead of discarding useful hash info with large hash values.
3570 (sxhash_float): New function.
3571 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
3572 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
3573 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
3574 Rewrite to use FIXNUM_BITS, as this simplifies things.
3575 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
3576 Adjust signatures to match updated version of code.
3577 (consing_since_gc): Now EMACS_INT, since a single hash table can
3578 use more than INT_MAX bytes.
3579
3580 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
3581
3582 Make it possible to build with GCC-4.6+ -O2 -flto.
3583
3584 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
3585
3586 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
3587
3588 * minibuf.c (get_minibuffer, read_minibuf_unwind):
3589 Call minibuffer-inactive-mode.
3590
3591 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
3592
3593 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
3594 Update dependencies.
3595
3596 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3597
3598 * data.c (init_data): Remove code for UTS, this system is not
3599 supported anymore.
3600
3601 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3602
3603 Don't force ./temacs to start in terminal mode.
3604
3605 * frame.c (make_initial_frame): Initialize faces in all cases, not
3606 only when CANNOT_DUMP is defined.
3607 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
3608
3609 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3610
3611 * dispnew.c (add_window_display_history): Use const for the string
3612 pointer. Remove declaration, not needed.
3613
3614 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3615
3616 Use 'inline', not 'INLINE'.
3617 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
3618 * alloc.c, fontset.c (INLINE): Remove.
3619 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
3620 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
3621 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
3622 * gmalloc.c (register_heapinfo): Use inline unconditionally.
3623 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
3624
3625 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3626
3627 Make it possible to run ./temacs.
3628
3629 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
3630 syms_of_callproc does the same thing. Remove test for
3631 "initialized", do it in the caller.
3632 * emacs.c (main): Avoid calling set_initial_environment when dumping.
3633
3634 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
3635
3636 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
3637 (read_minibuf): Use get_minibuffer.
3638 (syms_of_minibuf): Use DEFSYM.
3639 (Qmetadata): New var.
3640 * data.c (Qbuffer): Don't make it static.
3641 (syms_of_data): Use DEFSYM.
3642
3643 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3644
3645 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
3646 (CCL_CODE_MIN): New macro.
3647
3648 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
3649
3650 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
3651
3652 * eval.c (Qdebug): Now static.
3653 * lisp.h (Qdebug): Remove decl. This reverts a part of the
3654 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
3655 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
3656
3657 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3658
3659 * image.c: Various fixes to ImageMagick code comments.
3660 (Fimagemagick_types): Doc fix.
3661
3662 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
3663
3664 Minor fixes prompted by GCC 4.6.0 warnings.
3665
3666 * xselect.c (converted_selections, conversion_fail_tag): Now static.
3667
3668 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
3669 (x_clipboard_manager_save_all): Move extern decl to ...
3670 * xterm.h: ... here, so that it can be checked for consistency.
3671
3672 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
3673
3674 * xselect.c (x_clipboard_manager_save_frame)
3675 (x_clipboard_manager_save_all): New functions.
3676 (Fx_clipboard_manager_save): Lisp function deleted.
3677
3678 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
3679 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
3680
3681 * xterm.h: Update prototype.
3682
3683 2011-05-28 William Xu <william.xwl@gmail.com>
3684
3685 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
3686 exiting (Bug#8239).
3687
3688 2011-05-28 Jim Meyering <meyering@redhat.com>
3689
3690 Avoid a sign-extension bug in crypto_hash_function.
3691 * fns.c (to_uchar): Define.
3692 (crypto_hash_function): Use it to convert some newly-signed
3693 variables to unsigned, to avoid sign-extension bugs. For example,
3694 without this change, (md5 "truc") would evaluate to
3695 45723a2aff78ff4fff7fff1114760e62 rather than the expected
3696 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
3697 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3698
3699 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3700
3701 Integer overflow fixes.
3702
3703 * dbusbind.c: Serial number integer overflow fixes.
3704 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
3705 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
3706 to hold a serial number that is too large for a fixnum.
3707 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3708 Check for serial numbers out of range. Decode any serial number
3709 that was so large that it became a float. (Bug#8722)
3710
3711 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
3712 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3713 Use XFASTINT rather than XUINT when numbers are nonnegative.
3714 (xd_append_arg, Fdbus_method_return_internal):
3715 (Fdbus_method_error_internal): Likewise. Also, for unsigned
3716 arguments, check that Lisp number is nonnegative, rather than
3717 silently wrapping negative numbers around. (Bug#8722)
3718 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
3719 (Bug#8722)
3720
3721 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
3722
3723 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
3724
3725 ccl: add integer overflow checks
3726 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
3727 (IN_INT_RANGE): New macros.
3728 (ccl_driver): Use them to check for integer overflow when
3729 decoding a CCL program. Many of the new checks are whether XINT (x)
3730 fits in int; it doesn't always, on 64-bit hosts. The new version
3731 doesn't catch all possible integer overflows, but it's an
3732 improvement. (Bug#8719)
3733
3734 * alloc.c (make_event_array): Use XINT, not XUINT.
3735 There's no need for unsigned here.
3736
3737 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
3738 This follows up to the 2011-05-06 change that substituted uintptr_t
3739 for EMACS_INT. This case wasn't caught back then.
3740
3741 Rework Fformat to avoid integer overflow issues.
3742 * editfns.c: Include <float.h> unconditionally, as it's everywhere
3743 now (part of C89). Include <verify.h>.
3744 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
3745 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
3746 (Fformat): Avoid the prepass trying to compute sizes; it was only
3747 approximate and thus did not catch overflow reliably. Instead, walk
3748 through the format just once, formatting and computing sizes as we go,
3749 checking for integer overflow at every step, and allocating a larger
3750 buffer as needed. Keep track separately whether the format is
3751 multibyte. Keep only the most-recently calculated precision, rather
3752 than them all. Record whether each argument has been converted to
3753 string. Use EMACS_INT, not int, for byte and char and arg counts.
3754 Support field widths and precisions larger than INT_MAX. Avoid
3755 sprintf's undefined behavior with conversion specifications such as %#d
3756 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
3757 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
3758 formatting out-of-range floating point numbers with int
3759 formats. (Bug#8668)
3760
3761 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
3762
3763 * data.c: Avoid integer truncation in expressions involving floats.
3764 * data.c: Include <intprops.h>.
3765 (arith_driver): When there's an integer overflow in an expression
3766 involving floating point, convert the integers to floating point
3767 so that the resulting value does not suffer from catastrophic
3768 integer truncation. For example, on a 64-bit host (* 4
3769 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
3770 Do not rely on undefined behavior after integer overflow.
3771
3772 merge count_size_as_multibyte, parse_str_to_multibyte
3773 * character.c, character.h (count_size_as_multibyte):
3774 Rename from parse_str_to_multibyte; all uses changed.
3775 Check for integer overflow.
3776 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
3777 since it's now a duplicate of the other. This is more of
3778 a character than a buffer op, so better that it's in character.c.
3779 * fns.c, print.c: Adjust to above changes.
3780
3781 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
3782
3783 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
3784
3785 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3786
3787 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3788 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
3789 (x_clipboard_manager_save): Now static.
3790 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
3791
3792 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3793 (crypto_hash_function): Now static.
3794 Fix pointer signedness problems. Avoid unnecessary initializations.
3795
3796 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
3797
3798 * termhooks.h (Vselection_alist): Make it terminal-local.
3799
3800 * terminal.c (create_terminal): Initialize it.
3801
3802 * xselect.c: Support for clipboard managers.
3803 (Vselection_alist): Move to termhooks.h as terminal-local var.
3804 (LOCAL_SELECTION): New macro.
3805 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
3806 (symbol_to_x_atom): Remove gratuitous arg.
3807 (x_handle_selection_request, lisp_data_to_selection_data)
3808 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
3809 (x_own_selection, x_get_local_selection, x_convert_selection):
3810 New arg, specifying work frame. Use terminal-local Vselection_alist.
3811 (some_frame_on_display): Delete unused function.
3812 (Fx_own_selection_internal, Fx_get_selection_internal)
3813 (Fx_disown_selection_internal, Fx_selection_owner_p)
3814 (Fx_selection_exists_p): New optional frame arg.
3815 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
3816 (x_handle_selection_clear): Don't treat other terminals with the
3817 same keyboard specially. Use the terminal-local Vselection_alist.
3818 (x_clear_frame_selections): Use Frun_hook_with_args.
3819
3820 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
3821
3822 * xterm.h: Add support for those atoms.
3823
3824 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
3825
3826 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
3827 (converted_selections, conversion_fail_tag): New global variables.
3828 (x_selection_request_lisp_error): Free the above.
3829 (x_get_local_selection): Remove unnecessary code.
3830 (x_reply_selection_request): Args changed; handle arbitrary array
3831 of converted selections stored in converted_selections.
3832 Separate the XChangeProperty and SelectionNotify steps.
3833 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
3834 (x_convert_selection): New function.
3835 (x_handle_selection_event): Simplify.
3836 (x_get_foreign_selection): Don't ignore incoming requests while
3837 waiting for an answer; this will fail when we implement
3838 SAVE_TARGETS, and seems unnecessary anyway.
3839 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
3840 (Vx_sent_selection_functions): Doc fix.
3841
3842 2011-05-26 Leo Liu <sdl.web@gmail.com>
3843
3844 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
3845
3846 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3847
3848 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
3849
3850 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
3851 for fringe update if it has periodic bitmap.
3852 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
3853 and fringe_bitmap_periodic_p.
3854
3855 * fringe.c (get_fringe_bitmap_data): New function.
3856 (draw_fringe_bitmap_1, update_window_fringes): Use it.
3857 (update_window_fringes): Record periodicity of fringe bitmap in glyph
3858 row. Mark glyph row for fringe update if periodicity changed.
3859
3860 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
3861 for fringe update unless it has periodic bitmap.
3862
3863 2011-05-25 Kenichi Handa <handa@m17n.org>
3864
3865 * xdisp.c (get_next_display_element): Set correct it->face_id for
3866 a static composition.
3867
3868 2011-05-24 Leo Liu <sdl.web@gmail.com>
3869
3870 * deps.mk (fns.o):
3871 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3872
3873 * fns.c (crypto_hash_function, Fsha1): New function.
3874 (Fmd5): Use crypto_hash_function.
3875 (syms_of_fns): Add Ssha1.
3876
3877 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3878
3879 * gnutls.c: Remove unused macros.
3880 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3881 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3882 Remove macros that are defined and never used.
3883 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3884
3885 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3886
3887 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3888 (Fx_get_selection_internal): Minor cleanup.
3889 (Fx_own_selection_internal): Rename arguments for consistency with
3890 select.el.
3891
3892 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3893
3894 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3895
3896 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
3897
3898 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3899
3900 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3901
3902 * dispnew.c (scrolling_window): Don't exclude the case that the
3903 last enabled row in the desired matrix touches the bottom boundary.
3904
3905 2011-05-21 Glenn Morris <rgm@gnu.org>
3906
3907 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
3908 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3909 and add some more files.
3910
3911 2011-05-20 Eli Zaretskii <eliz@gnu.org>
3912
3913 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3914 report_file_error introduced by the change from 2011-05-07.
3915
3916 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3917
3918 * systime.h (Time): Define only if emacs is defined.
3919 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3920 where the include path doesn't have X11/X.h by default. See
3921 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3922
3923 2011-05-20 Kenichi Handa <handa@m17n.org>
3924
3925 * composite.c (find_automatic_composition): Fix previous change.
3926
3927 2011-05-20 Glenn Morris <rgm@gnu.org>
3928
3929 * lisp.mk: New file, split from Makefile.in.
3930 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3931 (shortlisp): Remove.
3932 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3933
3934 2011-05-19 Glenn Morris <rgm@gnu.org>
3935
3936 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3937 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3938 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3939 (lisp): Set the order to that of loadup.el.
3940 (shortlisp): Make it a copy of $lisp.
3941 (SOME_MACHINE_LISP): Remove.
3942 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3943 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3944
3945 2011-05-18 Kenichi Handa <handa@m17n.org>
3946
3947 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3948 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3949 (find_automatic_composition): Mostly rewrite for efficiency.
3950
3951 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
3952
3953 * makefile.w32-in: Update dependencies.
3954
3955 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3956
3957 * menu.c: Include limits.h (fixes the MS-Windows build broken by
3958 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
3959
3960 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
3961
3962 Fix some integer overflow issues, such as string length overflow.
3963
3964 * insdel.c (count_size_as_multibyte): Check for string overflow.
3965
3966 * character.c (lisp_string_width): Check for string overflow.
3967 Use EMACS_INT, not int, for string indexes and lengths; in
3968 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3969 the resulting string length overflows an EMACS_INT; instead,
3970 report a string overflow if no precision given. When checking for
3971 precision exhaustion, use a check that cannot possibly have
3972 integer overflow. (Bug#8675)
3973 * character.h (lisp_string_width): Adjust to new signature.
3974
3975 * alloc.c (string_overflow): New function.
3976 (Fmake_string): Use it. This doesn't change behavior, but saves
3977 a few bytes and will simplify future changes.
3978 * character.c (string_escape_byte8): Likewise.
3979 * lisp.h (string_overflow): New decl.
3980
3981 Fixups, following up to the user-interface timestamp change.
3982 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3983 for UI timestamps, instead of unsigned long.
3984 * msdos.c (mouse_get_pos): Likewise.
3985 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
3986 * w32gui.h (Time): Define by including "systime.h" rather than by
3987 declaring it ourselves. (Bug#8664)
3988
3989 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3990 * image.c (clear_image_cache): Likewise.
3991
3992 * term.c (term_mouse_position): Don't assume time_t wraparound.
3993
3994 Be more systematic about user-interface timestamps.
3995 Before, the code sometimes used 'Time', sometimes 'unsigned long',
3996 and sometimes 'EMACS_UINT', to represent these timestamps.
3997 This change causes it to use 'Time' uniformly, as that's what X uses.
3998 This makes the code easier to follow, and makes it easier to catch
3999 integer overflow bugs such as Bug#8664.
4000 * frame.c (Fmouse_position, Fmouse_pixel_position):
4001 Use Time, not unsigned long, for user-interface timestamps.
4002 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4003 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4004 * keyboard.h (last_event_timestamp): Likewise.
4005 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4006 * menu.h (xmenu_show): Likewise.
4007 * term.c (term_mouse_position): Likewise.
4008 * termhooks.h (struct input_event.timestamp): Likewise.
4009 (struct terminal.mouse_position_hook): Likewise.
4010 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4011 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4012 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4013 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4014 what it was before.
4015 * menu.h, termhooks.h: Include "systime.h", for Time.
4016
4017 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4018 Don't assume that the difference between two unsigned long values
4019 can fit into an integer. At this point, we know button_down_time
4020 <= event->timestamp, so the difference must be nonnegative, so
4021 there's no need to cast the result if double-click-time is
4022 nonnegative, as it should be; check that it's nonnegative, just in
4023 case. This bug is triggered when events are more than 2**31 ms
4024 apart (about 25 days). (Bug#8664)
4025
4026 * xselect.c (last_event_timestamp): Remove duplicate decl.
4027 (x_own_selection): Remove needless cast to unsigned long.
4028
4029 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4030 that always fit in int. Use a sentinel instead of a counter, to
4031 avoid a temp and to allay GCC's concerns about possible int overflow.
4032 * frame.h (struct frame): Use int for menu_bar_items_used
4033 instead of EMACS_INT, since it always fits in int.
4034
4035 * menu.c (grow_menu_items): Check for int overflow.
4036
4037 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4038
4039 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4040 Before, the code was not consistent. These values cannot exceed
4041 2**31 - 1 so there's no need to make them unsigned.
4042 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4043 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4044 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4045 as modifiers.
4046 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4047
4048 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4049 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4050 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4051 presumably because the widths might not match.
4052
4053 * window.c (size_window): Avoid needless test at loop start.
4054
4055 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4056
4057 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4058
4059 2011-05-12 Drew Adams <drew.adams@oracle.com>
4060
4061 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4062
4063 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4064
4065 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4066 `width' to `bar_area_x' and `bar_area_width', respectively.
4067 (x_scroll_run): Take account of fringe background extension.
4068
4069 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4070 Rename local vars `left' and `width' to `bar_area_x' and
4071 `bar_area_width', respectively.
4072 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4073 background extension.
4074
4075 2011-05-10 Jim Meyering <meyering@redhat.com>
4076
4077 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4078
4079 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
4080
4081 * image.c (Finit_image_library): Return t for built-in image types,
4082 like pbm and xbm. (Bug#8640)
4083
4084 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4085
4086 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4087
4088 2011-05-07 Eli Zaretskii <eliz@gnu.org>
4089
4090 * w32console.c (Fset_screen_color): Doc fix.
4091 (Fget_screen_color): New function.
4092 (syms_of_ntterm): Defsubr it.
4093
4094 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4095 unlink the temporary file if Fcall_process didn't create it in the
4096 first place.
4097 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4098 child process will be redirected to a file specified with `:file'.
4099 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4100 cue to call_process_cleanup not to close that handle.
4101
4102 2011-05-07 Ben Key <bkey76@gmail.com>
4103
4104 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4105 one of two shell specific rules, either bootstrap-temacs-CMD or
4106 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4107 to the previous implementation of the bootstrap-temacs rule.
4108 The bootstrap-temacs-CMD rule is similar to the previous
4109 implementation of the bootstrap-temacs rule except that it
4110 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4111 variable.
4112
4113 These changes, along with some changes to nt/configure.bat,
4114 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4115 earlier fix to add support for --cflags and --ldflags options
4116 that include quotes so that it works whether make uses cmd or
4117 sh as the shell.
4118
4119 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
4120
4121 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4122 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4123 is a constant.
4124 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4125 a string. Handle both cases.
4126 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4127 (Fdbus_register_method): Use Qinvalid_function.
4128
4129 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4130
4131 * makefile.w32-in: Update dependencies.
4132 (LISP_H): Add inttypes.h and stdin.h.
4133 (PROCESS_H): Add unistd.h.
4134
4135 2011-05-06 Eli Zaretskii <eliz@gnu.org>
4136
4137 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4138 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4139
4140 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
4141
4142 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4143
4144 * term.c (vfatal): Remove stray call to va_end.
4145 It's not needed and the C Standard doesn't allow it here anyway.
4146
4147 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4148 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4149
4150 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4151 bytes.
4152
4153 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4154
4155 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4156
4157 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4158
4159 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4160
4161 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4162
4163 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4164 * charset.c (Fdefine_charset_internal): Don't initialize
4165 charset.code_space[15]. The value was garbage, on hosts with
4166 32-bit int (Bug#8600).
4167
4168 * lread.c (read_integer): Be more consistent with string-to-number.
4169 Use string_to_number to do the actual conversion; this avoids
4170 rounding errors and fixes some other screwups. Without this fix,
4171 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4172 (digit_to_number): Move earlier, for benefit of read_integer.
4173 Return -1 if the digit is out of range for the base, -2 if it is
4174 not a digit in any supported base. (Bug#8602)
4175
4176 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4177
4178 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4179 to match comment at start of function. This also removes a
4180 GCC warning about overflow in a 32+64-bit port.
4181
4182 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4183
4184 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4185 Reported by Stefan Monnier in
4186 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
4187 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4188 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
4189
4190 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4191 (EMACS_UINTPTR): Likewise, with uintptr_t.
4192
4193 * lisp.h: Prefer 64-bit EMACS_INT if available.
4194 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4195 on 32-bit hosts that have 64-bit int, so that they can access
4196 large files.
4197 However, temporarily disable this change unless the temporary
4198 symbol WIDE_EMACS_INT is defined.
4199
4200 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4201
4202 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4203 This removes an assumption that EMACS_INT and long are the same
4204 width as pointers. The assumption is true for Emacs porting targets
4205 now, but we want to make other targets possible.
4206 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4207 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4208 In the rest of the code, change types of integers that hold casted
4209 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4210 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4211 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4212 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4213 No need to cast type when ORing.
4214 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4215 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4216 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4217 assume EMACS_INT is the same width as char *.
4218 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4219 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4220 Remove no-longer-needed casts.
4221 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4222 (xg_tool_bar_help_callback, xg_make_tool_item):
4223 Use EMACS_INTPTR to hold an integer
4224 that will be cast to void *; this can avoid a GCC warning
4225 if EMACS_INT is not the same width as void *.
4226 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4227 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4228 (current_message_1, set_message_1):
4229 Use a local to convert to proper width without a cast.
4230 * xmenu.c (dialog_selection_callback): Likewise.
4231
4232 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4233 Also, don't assume VALBITS / RAND_BITS is less than 5,
4234 and don't rely on undefined behavior when shifting a 1 left into
4235 the sign bit.
4236 * lisp.h (get_random): Change signature to match.
4237
4238 * lread.c (hash_string): Use size_t, not int, for hash computation.
4239 Normally we prefer signed values; but hashing is special, because
4240 it's better to use unsigned division on hash table sizes so that
4241 the remainder is nonnegative. Also, size_t is the natural width
4242 for hashing into memory. The previous code used 'int', which doesn't
4243 retain enough info to hash well into very large tables.
4244 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4245
4246 * dbusbind.c: Don't possibly lose pointer info when converting.
4247 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4248 Use XPNTR rather than XHASH, so that the high-order bits of
4249 the pointer aren't lost when converting through void *.
4250
4251 * eval.c (Fautoload): Don't double-shift a pointer.
4252
4253 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4254
4255 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
4256
4257 * gnutls.c (DEF_GNUTLS_FN):
4258 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4259
4260 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4261
4262 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4263 marker. (Bug#8610)
4264
4265 2011-05-05 Eli Zaretskii <eliz@gnu.org>
4266
4267 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4268 New version that can reserve upto 2GB of heap space.
4269
4270 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
4271
4272 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4273
4274 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4275
4276 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4277 `gnutls_certificate_set_x509_key_file'.
4278
4279 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
4280
4281 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4282 Update dependencies.
4283
4284 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4285
4286 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4287 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4288 Remove unused parameter `fildes'.
4289 * process.c (read_process_output, send_process): Don't pass it.
4290
4291 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4292
4293 Fix previous change: the library cache is defined in w32.c.
4294 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4295 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4296
4297 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
4298
4299 Implement dynamic loading of GnuTLS on Windows.
4300
4301 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4302 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4303 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4304 Declare.
4305
4306 * gnutls.c (Qgnutls_dll): Define.
4307 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4308 (gnutls_*): Declare function pointers.
4309 (init_gnutls_functions): New function to initialize function pointers.
4310 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4311 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4312 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4313 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4314 (emacs_gnutls_write, emacs_gnutls_read)
4315 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4316 (Fgnutls_available_p): New function.
4317 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4318 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4319 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4320
4321 * image.c: Include w32.h.
4322 (Vimage_type_cache): Delete.
4323 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4324 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4325 (w32_delayed_load): Move to w32.c.
4326
4327 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4328
4329 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4330 (w32_delayed_load): Move from image.c. When loading a library, record
4331 its filename in the :loaded-from property of the library id.
4332 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4333 Initialize and staticpro them.
4334 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4335
4336 * process.c: Include lisp.h before w32.h, not after.
4337 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4338 instead of gnutls_record_check_pending.
4339
4340 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4341
4342 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4343
4344 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4345 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4346 as passed in.
4347
4348 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4349
4350 * xterm.c (x_set_frame_alpha): Do not set property on anything
4351 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4352
4353 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4354
4355 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4356
4357 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
4358
4359 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4360 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4361 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4362 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4363 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4364 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4365 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4366 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4367 (Qgnutls_bootprop_callbacks_verify): Make static.
4368
4369 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4370
4371 * callproc.c: Indentation fixup.
4372
4373 * sysdep.c (wait_for_termination_1): Make static.
4374 (wait_for_termination, interruptible_wait_for_termination):
4375 Move after wait_for_termination_1.
4376
4377 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4378
4379 * sysdep.c (interruptible_wait_for_termination): New function
4380 which is like wait_for_termination, but allows keyboard
4381 interruptions.
4382
4383 * callproc.c (Fcall_process): Add (:file "file") as an option for
4384 the STDOUT buffer.
4385 (Fcall_process_region): Ditto.
4386
4387 2011-04-30 Eli Zaretskii <eliz@gnu.org>
4388
4389 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4390 rather than `XVECTOR (FOO)->size'.
4391
4392 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4393 inttypes.h, as a gnulib replacement is used if it not available in
4394 system headers.
4395
4396 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4397
4398 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4399 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4400 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4401
4402 * coding.c (coding_alloc_by_realloc): Error out if destination
4403 will grow beyond MOST_POSITIVE_FIXNUM.
4404 (decode_coding_emacs_mule): Abort if there isn't enough place in
4405 charbuf for the composition carryover bytes. Reserve an extra
4406 space for up to 2 characters produced in a loop.
4407 (decode_coding_iso_2022): Abort if there isn't enough place in
4408 charbuf for the composition carryover bytes.
4409
4410 2011-04-21 Eli Zaretskii <eliz@gnu.org>
4411
4412 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4413 aborting when %lld or %lll format is passed.
4414 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4415 %llo or %llx format is passed. (Bug#8545)
4416
4417 * window.c (window_scroll_line_based): Use a marker instead of
4418 simple variables to record original value of point. (Bug#7952)
4419
4420 * doprnt.c (doprnt): Fix the case where a multibyte sequence
4421 produced by %s or %c overflows available buffer space. (Bug#8545)
4422
4423 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
4424
4425 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
4426 (SIZE_MAX): Move defn after all includes, as they might #define it.
4427
4428 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4429
4430 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4431
4432 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4433
4434 * keyboard.c (Qdelayed_warnings_hook): Define.
4435 (command_loop_1): Run `delayed-warnings-hook'
4436 if Vdelayed_warnings_list is non-nil.
4437 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
4438 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
4439
4440 2011-04-28 Eli Zaretskii <eliz@gnu.org>
4441
4442 * doprnt.c (doprnt): Don't return value smaller than the buffer
4443 size if the message was truncated. (Bug#8545).
4444
4445 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
4446
4447 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
4448 (Fx_window_property): #if-0 the whole functions, not just the bodies.
4449
4450 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4451
4452 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
4453
4454 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
4455
4456 * makefile.w32-in: Update dependencies.
4457
4458 2011-04-27 Eli Zaretskii <eliz@gnu.org>
4459
4460 Improve `doprnt' and its usage. (Bug#8545)
4461 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
4462 `format_end'. Remove support for %l as a conversion specifier.
4463 Don't use xrealloc. Improve diagnostics when the %l size modifier
4464 is used. Update the commentary.
4465
4466 * eval.c (verror): Simplify calculation of size_t.
4467
4468 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
4469 messages.
4470
4471 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
4472
4473 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
4474 change.
4475
4476 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4477
4478 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
4479 This makes this file independent of the recent pseudovector change.
4480
4481 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
4482
4483 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
4484
4485 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
4486 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
4487 Remove unused local.
4488 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
4489
4490 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
4491 GCC 4.6.0 optimizes based on type-based alias analysis.
4492 For example, if b is of type struct buffer * and v of type struct
4493 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
4494 != &v->size, and therefore "v->size = 1; b->size = 2; return
4495 v->size;" must therefore return 1. This assumption is incorrect
4496 for Emacs, since it type-puns struct Lisp_Vector * with many other
4497 types. To fix this problem, this patch adds a new type struct
4498 vectorlike_header that documents the constraints on layout of vectors
4499 and pseudovectors, and helps optimizing compilers not get fooled
4500 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
4501 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
4502 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
4503 the size member.
4504 (XSETPVECTYPE): Rewrite in terms of new macro.
4505 (XSETPVECTYPESIZE): New macro, specifying both type and size.
4506 This is a bit clearer, and further avoids the possibility of
4507 undesirable aliasing.
4508 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
4509 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
4510 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
4511 since Lisp_Subr is a special case (no "next" field).
4512 (ASIZE): Now uses header.size rather than size.
4513 All previous uses of XVECTOR (foo)->size replaced to use this macro,
4514 to avoid the hassle of writing XVECTOR (foo)->header.size.
4515 (struct vectorlike_header): New type.
4516 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
4517 object, to help avoid aliasing.
4518 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
4519 (SUBRP): Likewise, since Lisp_Subr is a special case.
4520 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
4521 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
4522 (struct Lisp_Hash_Table): Combine first two members into a single
4523 struct vectorlike_header member. All uses of "size" and "next" members
4524 changed to be "header.size" and "header.next".
4525 * buffer.h (struct buffer): Likewise.
4526 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
4527 * frame.h (struct frame): Likewise.
4528 * process.h (struct Lisp_Process): Likewise.
4529 * termhooks.h (struct terminal): Likewise.
4530 * window.c (struct save_window_data, struct saved_window): Likewise.
4531 * window.h (struct window): Likewise.
4532 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
4533 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
4534 * buffer.c (init_buffer_once): Likewise.
4535 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
4536 special case.
4537 * process.c (Fformat_network_address): Use local var for size,
4538 for brevity.
4539
4540 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
4541
4542 Make the Lisp reader and string-to-float more consistent (Bug#8525)
4543 * data.c (atof): Remove decl; no longer used or needed.
4544 (digit_to_number): Move to lread.c.
4545 (Fstring_to_number): Use new string_to_number function, to be
4546 consistent with how the Lisp reader treats infinities and NaNs.
4547 Do not assume that floating-point numbers represent EMACS_INT
4548 without losing information; this is not true on most 64-bit hosts.
4549 Avoid double-rounding errors, by insisting on integers when
4550 parsing non-base-10 numbers, as the documentation specifies.
4551 * lisp.h (string_to_number): New decl, replacing ...
4552 (isfloat_string): Remove.
4553 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
4554 (read1): Do not accept +. and -. as integers; this
4555 appears to have been a coding error. Similarly, do not accept
4556 strings like +-1e0 as floating point numbers. Do not report
4557 overflow for integer overflows unless the base is not 10 which
4558 means we have no simple and reliable way to continue.
4559 Break out the floating-point parsing into a new
4560 function string_to_number, so that Fstring_to_number parses
4561 floating point numbers consistently with the Lisp reader.
4562 (digit_to_number): Move here from data.c. Make it static inline.
4563 (E_CHAR, EXP_INT): Remove, replacing with ...
4564 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
4565 (string_to_number): New function, replacing isfloat_string.
4566 This function checks for valid syntax and produces the resulting
4567 Lisp float number too. Rework it so that string-to-number
4568 no longer mishandles examples like "1.0e+". Use strtoumax,
4569 so that overflow for non-base-10 numbers is reported only when
4570 there's no portable and simple way to convert to floating point.
4571
4572 * textprop.c (set_text_properties_1): Rewrite for clarity,
4573 and to avoid GCC warning about integer overflow.
4574
4575 * intervals.h (struct interval): Use EMACS_INT for members
4576 where EMACS_UINT might cause problems. See
4577 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
4578 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
4579 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
4580 All uses changed.
4581 (offset_intervals): Tell GCC not to worry about length overflow
4582 when negating a negative length.
4583
4584 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
4585 (overrun_check_free): Likewise.
4586
4587 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
4588 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
4589 word size.
4590
4591 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4592 (gnutls_make_error): Rename local to avoid shadowing.
4593 (gnutls_emacs_global_deinit): ifdef out; not used.
4594 (Fgnutls_boot): Use const for pointer to readonly storage.
4595 Comment out unused local. Fix pointer signedness problems.
4596
4597 * lread.c (openp): Don't stuff size_t into an 'int'.
4598 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
4599 about possible signed overflow.
4600
4601 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4602 (GDK_KEY_g): Don't define if already defined.
4603 (xg_prepare_tooltip): Avoid pointer signedness problem.
4604 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
4605
4606 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
4607 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
4608
4609 * xfns.c (Fx_window_property): Simplify a bit,
4610 to make a bit faster and to avoid GCC 4.6.0 warning.
4611 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
4612
4613 * fns.c (internal_equal): Don't assume size_t fits in int.
4614
4615 * alloc.c (compact_small_strings): Tighten assertion a little.
4616
4617 Replace pEd with more-general pI, and fix some printf arg casts.
4618 * lisp.h (pI): New macro, generalizing old pEd macro to other
4619 conversion specifiers. For example, use "...%"pI"d..." rather
4620 than "...%"pEd"...".
4621 (pEd): Remove. All uses replaced with similar uses of pI.
4622 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
4623 * alloc.c (check_pure_size): Don't overflow by converting size to int.
4624 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
4625 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
4626 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
4627 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
4628 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
4629 64-bit hosts.
4630 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
4631 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
4632 * print.c (safe_debug_print, print_object): Likewise.
4633 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
4634 to int.
4635 Use pI instead of if-then-else-abort. Use %p to avoid casts,
4636 avoiding the 0 flag, which is not portable.
4637 * process.c (Fmake_network_process): Use pI to avoid cast.
4638 * region-cache.c (pp_cache): Likewise.
4639 * xdisp.c (decode_mode_spec): Likewise.
4640 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
4641 behavior on 64-bit hosts with printf arg.
4642 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
4643 (x_stop_queuing_selection_requests): Likewise.
4644 (x_get_window_property): Don't truncate byte count to an 'int'
4645 when tracing.
4646
4647 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
4648 here, since it parses constructs like leading '-' and spaces,
4649 which are not wanted; and it overflows with large numbers.
4650 Instead, simply match F[0-9]+, which is what is wanted anyway.
4651
4652 * alloc.c: Remove unportable assumptions about struct layout.
4653 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
4654 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
4655 (allocate_vectorlike, make_pure_vector): Use the new macros,
4656 plus offsetof, to remove unportable assumptions about struct layout.
4657 These assumptions hold on all porting targets that I know of, but
4658 they are not guaranteed, they're easy to remove, and removing them
4659 makes further changes easier.
4660
4661 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
4662 This doesn't fix a bug but makes the code clearer.
4663 (string_overrun_cookie): Now const. Use initializers that
4664 don't formally overflow signed char, to avoid warnings.
4665 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
4666 can cause Emacs to crash when string overrun checking is enabled.
4667 (allocate_buffer): Don't assume sizeof (struct buffer) is a
4668 multiple of sizeof (EMACS_INT); it need not be, if
4669 alignof(EMACS_INT) < sizeof (EMACS_INT).
4670 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
4671
4672 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
4673
4674 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
4675
4676 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
4677
4678 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
4679 supposed to be handshaking. (Bug#8556)
4680 Reported by Paul Eggert <eggert@cs.ucla.edu>.
4681
4682 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
4683
4684 * lisp.h (Qdebug): List symbol.
4685 * eval.c (Qdebug): Restore global linkage.
4686 * keyboard.c (debug-on-event): New variable.
4687 (handle_user_signal): Break into debugger when debug-on-event
4688 matches the current signal symbol.
4689
4690 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
4691
4692 * alloc.c (check_sblock, check_string_bytes)
4693 (check_string_free_list): Convert to standard C.
4694
4695 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
4696
4697 * w32.c (emacs_gnutls_push): Fix typo.
4698
4699 2011-04-25 Eli Zaretskii <eliz@gnu.org>
4700
4701 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
4702 "cast to pointer from integer of different size".
4703
4704 Improve doprnt and its use in verror. (Bug#8545)
4705 * doprnt.c (doprnt): Document the set of format control sequences
4706 supported by the function. Use SAFE_ALLOCA instead of always
4707 using `alloca'.
4708
4709 * eval.c (verror): Don't limit the buffer size at size_max-1, that
4710 is one byte too soon. Don't use xrealloc; instead xfree and
4711 xmalloc anew.
4712
4713 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
4714
4715 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
4716 callbacks stage.
4717
4718 * gnutls.c: Renamed global_initialized to
4719 gnutls_global_initialized. Added internals for the
4720 :verify-hostname-error, :verify-error, and :verify-flags
4721 parameters of `gnutls-boot' and documented those parameters in the
4722 docstring. Start callback support.
4723 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
4724 unless a fatal error occurred. Call gnutls_alert_send_appropriate
4725 on error. Return error code.
4726 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
4727 (emacs_gnutls_read): Likewise.
4728 (Fgnutls_boot): Return handshake error code.
4729 (emacs_gnutls_handle_error): New function.
4730 (wsaerror_to_errno): Likewise.
4731
4732 * w32.h (emacs_gnutls_pull): Add prototype.
4733 (emacs_gnutls_push): Likewise.
4734
4735 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
4736 (emacs_gnutls_push): Likewise.
4737
4738 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
4739
4740 * process.c (wait_reading_process_output): Check if GnuTLS
4741 buffered some data internally if no FDs are set for TLS
4742 connections.
4743
4744 * makefile.w32-in (OBJ2): Add gnutls.$(O).
4745 (LIBS): Link to USER_LIBS.
4746 ($(BLD)/gnutls.$(0)): New target.
4747
4748 2011-04-24 Eli Zaretskii <eliz@gnu.org>
4749
4750 * xdisp.c (handle_single_display_spec): Rename the
4751 display_replaced_before_p argument into display_replaced_p, to
4752 make it consistent with the commentary. Fix typos in the
4753 commentary.
4754
4755 * textprop.c (syms_of_textprop): Remove dead code.
4756 (copy_text_properties): Delete obsolete commentary about an
4757 interface that was deleted long ago. Fix typos in the description
4758 of arguments.
4759
4760 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
4761 to changes in oldXMenu/XMenu.h from 2011-04-16.
4762 <menu_help_message, prev_menu_help_message>: Constify.
4763 (IT_menu_make_room): menu->help_text is now `const char **';
4764 adjust.
4765
4766 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
4767 to changes in oldXMenu/XMenu.h from 2011-04-16.
4768 (struct XMenu): Declare `help_text' `const char **'.
4769
4770 * xfaces.c <Qunspecified>: Make extern again.
4771
4772 * syntax.c: Include sys/types.h before including regex.h, as
4773 required by Posix.
4774
4775 * doc.c (get_doc_string): Improve the format passed to `error'.
4776
4777 * doprnt.c (doprnt): Improve commentary.
4778
4779 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
4780
4781 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
4782 them with etags.
4783
4784 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
4785 changes in globals.h immediately force recompilation.
4786 (TAGS): Depend on $(CURDIR)/m/intel386.h and
4787 $(CURDIR)/s/ms-w32.h.
4788 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
4789
4790 * character.c (Fchar_direction): Function deleted.
4791 (syms_of_character): Don't defsubr it.
4792 <char-direction-table>: Deleted.
4793
4794 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4795
4796 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
4797 * doprnt.c: Include limits.h.
4798 (SIZE_MAX): New macro.
4799 (doprnt): Return a size_t value. 2nd arg is now size_t.
4800 Many local variables are now size_t instead of int or unsigned.
4801 Improve overflow protection. Support `l' modifier for integer
4802 conversions. Support %l conversion. Don't assume an EMACS_INT
4803 argument for integer conversions and for %c.
4804
4805 * lisp.h (doprnt): Restore prototype.
4806
4807 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
4808 $(SRC)/character.h.
4809
4810 * Makefile.in (base_obj): Add back doprnt.o.
4811
4812 * deps.mk (doprnt.o): Add back prerequisites.
4813 (callint.o): Depend on character.h.
4814
4815 * eval.c (internal_lisp_condition_case): Include the handler
4816 representation in the error message.
4817 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
4818 when breaking from the loop.
4819
4820 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
4821
4822 * callint.c (Fcall_interactively): When displaying error message
4823 about invalid control letter, pass the character's codepoint, not
4824 a pointer to its multibyte form. Improve display of the character
4825 in octal and display also its hex code.
4826
4827 * character.c (char_string): Use %x to display the (unsigned)
4828 codepoint of an invalid character, to avoid displaying a bogus
4829 negative value.
4830
4831 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
4832 `error', not SYMBOL_NAME itself.
4833
4834 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
4835 character arguments to `error'.
4836
4837 * charset.c (check_iso_charset_parameter): Fix incorrect argument
4838 to `error' in error message about FINAL_CHAR argument. Make sure
4839 FINAL_CHAR is a character, and use %c when it is passed as
4840 argument to `error'.
4841
4842 2011-04-23 Eli Zaretskii <eliz@gnu.org>
4843
4844 * s/ms-w32.h (localtime): Redirect to sys_localtime.
4845
4846 * w32.c: Include <time.h>.
4847 (sys_localtime): New function.
4848
4849 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
4850
4851 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
4852
4853 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
4854
4855 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
4856
4857 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
4858 zombies (Bug#8467).
4859
4860 2011-04-19 Eli Zaretskii <eliz@gnu.org>
4861
4862 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4863 gl_state.e_property when gl_state.object is Qt.
4864
4865 * insdel.c (make_gap_larger): Remove limitation of buffer size
4866 to <= INT_MAX.
4867
4868 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
4869
4870 * xdisp.c (lookup_glyphless_char_display)
4871 (produce_glyphless_glyph): Handle cons cell entry in
4872 glyphless-char-display.
4873 (Vglyphless_char_display): Document it.
4874
4875 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4876 glyphless-char-display.
4877
4878 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
4879
4880 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4881
4882 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4883
4884 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4885 definition for no-X builds.
4886
4887 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
4888
4889 Static checks with GCC 4.6.0 and non-default toolkits.
4890
4891 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4892
4893 * process.c (keyboard_bit_set): Define only if SIGIO.
4894 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4895 (send_process): Repair possible setjmp clobbering.
4896
4897 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4898
4899 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4900
4901 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4902
4903 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4904 Define only if needed.
4905
4906 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4907 by pacifying GCC about it. Maybe it's time to retire it?
4908 * xfaces.c (USG, __TIMEVAL__): Likewise.
4909
4910 * dispextern.h (struct redisplay_interface): Rename param
4911 to avoid shadowing.
4912 * termhooks.h (struct terminal): Likewise.
4913 * xterm.c (xembed_send_message): Likewise.
4914
4915 * insdel.c (make_gap_smaller): Define only if
4916 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4917
4918 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4919 it.
4920
4921 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4922 so that we aren't warned about unused symbols.
4923
4924 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4925
4926 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
4927
4928 * xfns.c (x_real_positions): Mark locals as initialized.
4929
4930 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4931
4932 * xterm.c: Fix problems found by static analysis with other toolkits.
4933 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
4934 (x_dispatch_event): Declare static if USE_GTK, and
4935 define if USE_GTK || USE_X_TOOLKIT.
4936 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
4937 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
4938 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4939 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
4940
4941 * xmenu.c (menu_help_callback): Pointer type fixes.
4942 Use const pointers when pointing at readonly data. Avoid pointer
4943 signedness clashes.
4944 (FALSE): Remove unused macro.
4945 (update_frame_menubar): Remove unused decl.
4946
4947 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4948
4949 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4950 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4951 (single_menu_item): Rename local to avoid shadowing.
4952
4953 * keyboard.c (make_lispy_event): Remove unused local var.
4954
4955 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4956 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4957
4958 * bitmaps: Change bitmaps from unsigned char back to the X11
4959 compatible char. Avoid the old compiler warnings about
4960 out-of-range initializers by using, for example, '\xab' rather
4961 than 0xab.
4962
4963 * xgselect.c (xgselect_initialize): Check vs interface
4964 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4965
4966 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4967
4968 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4969 to read-only memory.
4970
4971 * fns.c (vector): Remove; this old hack is no longer needed.
4972
4973 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
4974 Remove unused var.
4975 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
4976
4977 * xrdb.c (x_load_resources): Omit unused local.
4978
4979 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
4980 (x_window): Rename locals to avoid shadowing.
4981 (USG): Use the kludged USG macro, to pacify gcc.
4982
4983 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
4984 (x_term_init): Remove local to avoid shadowing.
4985
4986 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4987
4988 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4989 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4990
4991 2011-04-16 Eli Zaretskii <eliz@gnu.org>
4992
4993 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4994
4995 Fix regex.c, syntax.c and friends for buffers > 2GB.
4996 * syntax.h (struct gl_state_s): Declare character position members
4997 EMACS_INT.
4998
4999 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5000
5001 * textprop.c (verify_interval_modification, interval_of):
5002 Declare arguments EMACS_INT.
5003
5004 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5005 EMACS_INT.
5006
5007 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5008
5009 * indent.c (Fvertical_motion): Local variable it_start is now
5010 EMACS_INT.
5011
5012 * regex.c (re_match, re_match_2, re_match_2_internal)
5013 (bcmp_translate, regcomp, regexec, print_double_string)
5014 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5015 (re_compile_pattern, re_exec): Declare arguments and local
5016 variables `size_t' and `ssize_t' and return values `regoff_t', as
5017 appropriate.
5018 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5019 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5020 <compile_stack_type>: `size' and `avail' are now `size_t'.
5021
5022 * regex.h <regoff_t>: Use ssize_t, not int.
5023 (re_search, re_search_2, re_match, re_match_2): Arguments that
5024 specify buffer/string position and length are now ssize_t and
5025 size_t. Return type is regoff_t.
5026
5027 2011-04-16 Ben Key <bkey76@gmail.com>
5028
5029 * nsfont.m: Fixed bugs in ns_get_family and
5030 ns_descriptor_to_entity that were caused by using free to
5031 deallocate memory blocks that were allocated by xmalloc (via
5032 xstrdup). This caused Emacs to crash when compiled with
5033 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5034 --enable-checking=xmallocoverrun). xfree is now used to
5035 deallocate these memory blocks.
5036
5037 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
5038
5039 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5040
5041 emacs_write: Accept and return EMACS_INT for sizes.
5042 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5043 et seq.
5044 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5045 Accept and return EMACS_INT.
5046 (emacs_gnutls_write): Return the number of bytes written on
5047 partial writes.
5048 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
5049 (emacs_read, emacs_write): Remove check for negative size, as the
5050 Emacs source code has been audited now.
5051 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5052 (emacs_read, emacs_write): Use it.
5053 * process.c (send_process): Adjust to the new signatures of
5054 emacs_write and emacs_gnutls_write. Do not attempt to store
5055 a byte offset into an 'int'; it might overflow.
5056 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
5057
5058 * sound.c: Don't assume sizes fit in 'int'.
5059 (struct sound_device.period_size, alsa_period_size):
5060 Return EMACS_INT, not int.
5061 (struct sound_device.write, vox_write, alsa_write):
5062 Accept EMACS_INT, not int.
5063 (wav_play, au_play): Use EMACS_INT to store sizes and to
5064 record read return values.
5065
5066 2011-04-15 Ben Key <bkey76@gmail.com>
5067
5068 * keyboard.c (Qundefined): Don't declare static since it is used
5069 in nsfns.m.
5070 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5071 static since they are used in nsfont.m.
5072
5073 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5074
5075 * process.c (Qprocessp): Don't declare static.
5076 * lisp.h (Qprocessp): Declare again.
5077
5078 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
5079
5080 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5081
5082 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5083
5084 Improve C-level modularity by making more things 'static'.
5085
5086 Don't publish debugger-only interfaces to other modules.
5087 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5088 (verify_bytepos, count_markers): Move decls to the only modules
5089 that need them.
5090 * region-cache.h (pp_cache): Likewise.
5091 * window.h (check_all_windows): Likewise.
5092 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5093
5094 * sysdep.c (croak): Now static, if
5095 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5096 * syssignal.h (croak): Declare only if not static.
5097
5098 * alloc.c (refill_memory_reserve): Now static if
5099 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5100 * lisp.h (refill_memory_reserve): Declare only if not static.
5101
5102 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5103 Define only if USE_LUCID.
5104
5105 * xrdb.c (x_customization_string, x_rm_string): Now static.
5106
5107 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5108 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5109
5110 * xdisp.c (draw_row_with_mouse_face): Now static.
5111 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5112
5113 * window.h (check_all_windows): Mark externally visible.
5114
5115 * window.c (window_deletion_count): Now static.
5116
5117 * undo.c: Make symbols static if they're not exported.
5118 (last_undo_buffer, last_boundary_position, pending_boundary):
5119 Now static.
5120
5121 * textprop.c (interval_insert_behind_hooks): Now static.
5122 (interval_insert_in_front_hooks): Likewise.
5123
5124 * term.c: Make symbols static if they're not exported.
5125 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5126 (max_frame_lines, tty_set_terminal_modes):
5127 (tty_reset_terminal_modes, tty_turn_off_highlight):
5128 (get_tty_terminal): Now static.
5129 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5130 * termhooks.h (term_mouse_moveto): Do not declare if
5131 HAVE_WINDOW_SYSTEM.
5132 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5133 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5134
5135 * sysdep.c: Make symbols static if they're not exported.
5136 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5137 Now static.
5138 (sigprocmask_set, full_mask): Remove; unused.
5139 (wait_debugging): Mark as visible.
5140 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5141 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5142
5143 * syntax.c (syntax_temp): Define only if !__GNUC__.
5144
5145 * sound.c (current_sound_device, current_sound): Now static.
5146
5147 * search.c (searchbufs, searchbuf_head): Now static.
5148
5149 * scroll.c (scroll_cost): Remove; unused.
5150 * dispextern.h (scroll_cost): Remove decl.
5151
5152 * region-cache.h (pp_cache): Mark as externally visible.
5153
5154 * process.c: Make symbols static if they're not exported.
5155 (process_tick, update_tick, create_process, chan_process):
5156 (Vprocess_alist, proc_buffered_char, datagram_access):
5157 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5158 (deactivate_process): Mark defn as static, as well as decl.
5159 * lisp.h (create_process): Remove decl.
5160 * process.h (chan_process, Vprocess_alist): Remove decls.
5161
5162 * print.c: Make symbols static if they're not exported.
5163 (print_depth, new_backquote_output, being_printed, print_buffer):
5164 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5165 (print_interval, print_number_index, initial_stderr_stream):
5166 Now static.
5167 * lisp.h (Fprinc): Remove decl.
5168 (debug_output_compilation_hack): Mark as externally visible.
5169
5170 * sysdep.c (croak): Move decl from here to syssignal.h.
5171 * syssignal.h (croak): Put it here, so the API can be checked when
5172 'croak' is called from dissociate_if_controlling_tty.
5173
5174 * minibuf.c: Make symbols static if they're not exported.
5175 (minibuf_save_list, choose_minibuf_frame): Now static.
5176 * lisp.h (choose_minibuf_frame): Remove decl.
5177
5178 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5179
5180 * lread.c: Make symbols static if they're not exported.
5181 (read_objects, initial_obarray, oblookup_last_bucket_number):
5182 Now static.
5183 (make_symbol): Remove; unused.
5184 * lisp.h (initial_obarray, make_symbol): Remove decls.
5185
5186 * keyboard.c: Make symbols static if they're not exported.
5187 (single_kboard, recent_keys_index, total_keys, recent_keys):
5188 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5189 (this_single_command_key_start, echoing, last_auto_save):
5190 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5191 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5192 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5193 (Vlispy_mouse_stem, double_click_count):
5194 Now static.
5195 (force_auto_save_soon): Define only if SIGDANGER.
5196 (ignore_mouse_drag_p): Now static if
5197 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5198 (print_help): Remove; unused.
5199 (stop_character, last_timer_event): Mark as externally visible.
5200 * keyboard.h (ignore_mouse_drag_p): Declare only if
5201 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5202 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5203 * lisp.h (echoing): Remove decl.
5204 (force_auto_save_soon): Declare only if SIGDANGER.
5205 * xdisp.c (redisplay_window): Simplify code, to make it more
5206 obvious that ignore_mouse_drag_p is not accessed if !defined
5207 USE_GTK && !defined HAVE_NS.
5208
5209 * intervals.c: Make symbols static if they're not exported.
5210 (merge_properties_sticky, merge_interval_right, delete_interval):
5211 Now static.
5212 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5213
5214 * insdel.c: Make symbols static if they're not exported.
5215 However, leave prepare_to_modify_buffer alone. It's never
5216 called from outside this function, but that appears to be a bug.
5217 (combine_after_change_list, combine_after_change_buffer):
5218 (adjust_after_replace, signal_before_change): Now static.
5219 (adjust_after_replace_noundo): Remove; unused.
5220 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
5221 (signal_before_change): Remove decls.
5222
5223 * indent.c (val_compute_motion, val_vmotion): Now static.
5224
5225 * image.c: Make symbols static if they're not exported.
5226 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5227 if USE_GTK.
5228 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5229 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5230
5231 * fringe.c (standard_bitmaps): Now static.
5232 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5233
5234 * frame.c: Make symbols static if they're not exported.
5235 (x_report_frame_params, make_terminal_frame): Now static.
5236 (get_frame_param): Now static, unless HAVE_NS.
5237 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5238 (x_get_resource_string): Remove; not used.
5239 * frame.h (make_terminal_frame, x_report_frame_params):
5240 (x_get_resource_string); Remove decls.
5241 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5242 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5243
5244 * font.c, fontset.c: Make symbols static if they're not exported.
5245 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5246 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5247 * font.c (font_close_object): Now static.
5248 * font.h (font_close_object): Remove.
5249 * fontset.c (FONTSET_OBJLIST): Remove.
5250 (free_realized_fontset) #if-0 the body, which does nothing.
5251 (face_suitable_for_char_p): #if-0, as it's never called.
5252 * fontset.h (face_suitable_for_char_p): Remove decl.
5253 * xfaces.c (face_at_string_position):
5254 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
5255 since 0 is always ASCII.
5256
5257 * fns.c (weak_hash_tables): Now static.
5258
5259 * fileio.c: Make symbols static if they're not exported.
5260 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5261 (Vwrite_region_annotation_buffers): Now static.
5262
5263 * eval.c: Make symbols static if they're not exported.
5264 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5265 * lisp.h (backtrace_list): Remove decl.
5266
5267 * emacs.c: Make symbols static if they're not exported.
5268 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5269 (fatal_error_code, fatal_error_signal_hook, standard_args):
5270 Now static.
5271 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5272 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5273 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5274 * lisp.h (fatal_error_signal_hook): Remove decl.
5275 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5276
5277 * editfns.c: Move a (normally-unused) function to its only use.
5278 * editfns.c, lisp.h (get_operating_system_release): Remove.
5279 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5280 worth the hassle of breaking this out.
5281
5282 * xterm.c: Make symbols static if they're not exported.
5283 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5284 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5285 (x_destroy_window, x_delete_display):
5286 Now static.
5287 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5288 (x_mouse_leave): Remove; unused.
5289 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5290 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5291 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5292 Remove decls.
5293 (x_mouse_leave): Declare only if WINDOWSNT.
5294 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5295 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5296 USE_X_TOOLKIT.
5297
5298 * ftxfont.c: Make symbols static if they're not exported.
5299 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5300 HAVE_FREETYPE.
5301 * font.h (ftxfont_driver): Likewise.
5302
5303 * xfns.c: Make symbols static if they're not exported.
5304 (x_last_font_name, x_display_info_for_name):
5305 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5306 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5307 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5308 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5309 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5310 (last_show_tip_args): Now static.
5311 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5312 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5313 (x_screen_planes): Remove; unused.
5314 * dispextern.h (x_screen_planes): Remove decl.
5315
5316 * dispnew.c: Make symbols static if they're not exported.
5317 * dispextern.h (redraw_garbaged_frames, scrolling):
5318 (increment_row_positions): Remove.
5319 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5320 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5321 Now static.
5322 (redraw_garbaged_frames): Remove; unused.
5323
5324 * xfaces.c: Make symbols static if they're not exported.
5325 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5326 Remove decls.
5327 * xterm.h (defined_color): Remove decls.
5328 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5329 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5330 (menu_face_changed_default, defined_color, free_realized_face):
5331 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5332 (ascii_face_of_lisp_face): Remove; unused.
5333
5334 * xdisp.c: Make symbols static if they're not exported.
5335 * dispextern.h (scratch_glyph_row, window_box_edges):
5336 (glyph_to_pixel_coords, set_cursor_from_row):
5337 (get_next_display_element, set_iterator_to_next):
5338 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5339 (show_mouse_face): Remove decls
5340 * frame.h (message_buf_print): Likewise.
5341 * lisp.h (pop_message, set_message, check_point_in_composition):
5342 Likewise.
5343 * xterm.h (set_vertical_scroll_bar): Likewise.
5344 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5345 (message_buf_print, scratch_glyph_row, displayed_buffer):
5346 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5347 (get_next_display_element, show_mouse_face, window_box_edges):
5348 (frame_to_window_pixel_xy, check_point_in_composition):
5349 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5350 (glyph_to_pixel_coords): Remove; unused.
5351
5352 * dired.c (file_name_completion): Now static.
5353
5354 * dbusbind.c (xd_in_read_queued_messages): Now static.
5355
5356 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5357 * data.c (circular_list_error): Remove.
5358
5359 * commands.h (last_point_position, last_point_position_buffer):
5360 (last_point_position_window): Remove decls.
5361 * keyboard.c: Make these variables static.
5362
5363 * coding.h (coding, code_convert_region, encode_coding_gap):
5364 Remove decls.
5365 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5366 (iso_code_class, detect_coding, code_convert_region): Now static.
5367 (encode_coding_gap): Remove; unused.
5368
5369 * chartab.c (chartab_chars, chartab_bits): Now static.
5370
5371 * charset.h (charset_iso_8859_1): Remove decl.
5372 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5373 Now static.
5374
5375 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5376 * ccl.c (Vccl_program_table): Now static.
5377 (check_ccl_update): Remove; unused.
5378
5379 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5380 * category.h: ... from here.
5381 * category.c (check_category_table, set_category_set): Now static.
5382
5383 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5384 * lisp.h: Remove these decls.
5385
5386 * buffer.c (buffer_count): Remove unused var.
5387
5388 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5389 so that it's not optimized away.
5390 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5391 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5392 exported only to the debugger.
5393
5394 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
5395 * atimer.h (run_all_atimers): Remove; not exported.
5396
5397 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5398 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5399 was inaccessible from Lisp.
5400 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5401 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5402
5403 alloc.c: Import and export fewer symbols, and remove unused items.
5404 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5405 is defined.
5406 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5407 it's not optimized away by whole-program optimization.
5408 (message_enable_multibyte, free_misc): Remove.
5409 (catchlist, handlerlist, mark_backtrace):
5410 Declare only if BYTE_MARK_STACK.
5411 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5412 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5413 (message_enable_multibyte): Remove decl.
5414 (free_misc, interval_free_list, float_block, float_block_index):
5415 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5416 (cons_free_list, last_marked_index):
5417 Now static.
5418 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5419 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
5420 (mark_backtrace): Define only if BYTE_MARK_STACK.
5421 * xdisp.c (message_enable_multibyte): Now static.
5422
5423 Declare Lisp_Object Q* variables to be 'static' if not exported.
5424 This makes it easier for human readers (and static analyzers)
5425 to see whether these variables are used from other modules.
5426 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5427 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
5428 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
5429 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
5430 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
5431 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
5432 * xmenu.c, xselect.c:
5433 Declare Q* vars static if they are not used in other modules.
5434 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
5435 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
5436 Remove decls of unexported vars.
5437 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
5438
5439 * lisp.h (DEFINE_FUNC): Make sname 'static'.
5440
5441 Make Emacs functions such as Fatom 'static' by default.
5442 This makes it easier for human readers (and static analyzers)
5443 to see whether these functions can be called from other modules.
5444 DEFUN now defines a static function. To make the function external
5445 so that it can be used in other C modules, use the new macro DEFUE.
5446 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
5447 (Finit_image_library):
5448 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
5449 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
5450 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
5451 Remove decls, since these functions are now static.
5452 (Funintern, Fget_internal_run_time): New decls, since these functions
5453 were already external.
5454
5455 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
5456 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
5457 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
5458 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
5459 * keyboard.c, keymap.c, lread.c:
5460 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
5461 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
5462 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
5463 Mark functions with DEFUE instead of DEFUN,
5464 if they are used in other modules.
5465 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
5466 decls for now-static functions.
5467 * buffer.h (Fdelete_overlay): Remove decl.
5468 * callproc.c (Fgetenv_internal): Mark as internal.
5469 * composite.c (Fremove_list_of_text_properties): Remove decl.
5470 (Fcomposition_get_gstring): New forward static decl.
5471 * composite.h (Fcomposite_get_gstring): Remove decl.
5472 * dired.c (Ffile_attributes): New forward static decl.
5473 * doc.c (Fdocumntation_property): New forward static decl.
5474 * eval.c (Ffetch_bytecode): New forward static decl.
5475 (Funintern): Remove extern decl; now in .h file where it belongs.
5476 * fileio.c (Fmake_symbolic_link): New forward static decl.
5477 * image.c (Finit_image_library): New forward static decl.
5478 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
5479 * intervals.h (Fprevious_property_change):
5480 (Fremove_list_of_text_properties): Remove decls.
5481 * keyboard.c (Fthis_command_keys): Remove decl.
5482 (Fcommand_execute): New forward static decl.
5483 * keymap.c (Flookup_key): New forward static decl.
5484 (Fcopy_keymap): Now static.
5485 * keymap.h (Flookup_key): Remove decl.
5486 * process.c (Fget_process): New forward static decl.
5487 (Fprocess_datagram_address): Mark as internal.
5488 * syntax.c (Fsyntax_table_p): New forward static decl.
5489 (skip_chars): Remove duplicate decl.
5490 * textprop.c (Fprevious_property_change): New forward static decl.
5491 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
5492 Now internal.
5493 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
5494 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
5495
5496 * editfns.c (Fformat): Remove unreachable code.
5497
5498 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
5499
5500 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
5501 change. (Bug#8496)
5502
5503 2011-04-13 Eli Zaretskii <eliz@gnu.org>
5504
5505 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
5506 when at ZV. (Bug#8487)
5507
5508 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
5509
5510 * charset.c (Fclear_charset_maps): Use xfree instead of free.
5511 (Bug#8437)
5512 * keyboard.c (parse_tool_bar_item): Likewise.
5513 * sound.c (sound_cleanup, alsa_close): Likewise.
5514 * termcap.c (tgetent): Likewise.
5515 * xfns.c (x_default_font_parameter): Likewise.
5516 * xsettings.c (read_and_apply_settings): Likewise.
5517
5518 * alloc.c (overrun_check_malloc, overrun_check_realloc)
5519 (overrun_check_free): Protoize.
5520
5521 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
5522
5523 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
5524 since callers should never pass a negative size.
5525 Change the signature to match that of plain 'read' and 'write'; see
5526 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
5527 * lisp.h: Update prototypes of emacs_write and emacs_read.
5528
5529 2011-04-11 Eli Zaretskii <eliz@gnu.org>
5530
5531 * xdisp.c (redisplay_window): Don't try to determine the character
5532 position of the scroll margin if the window start point w->startp
5533 is outside the buffer's accessible region. (Bug#8468)
5534
5535 2011-04-10 Eli Zaretskii <eliz@gnu.org>
5536
5537 Fix write-region and its subroutines for buffers > 2GB.
5538 * fileio.c (a_write, e_write): Modify declaration of arguments and
5539 local variables to support buffers larger than 2GB.
5540 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
5541
5542 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
5543 argument, local variables, and return value.
5544
5545 * lisp.h: Update prototypes of emacs_write and emacs_read.
5546
5547 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
5548
5549 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
5550
5551 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
5552
5553 Fix more problems found by GCC 4.6.0's static checks.
5554
5555 * xdisp.c (vmessage): Use a better test for character truncation.
5556
5557 * charset.c (load_charset_map): <, not <=, for optimization,
5558 and to avoid potential problems with integer overflow.
5559 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
5560 * casetab.c (set_identity, shuffle): Likewise.
5561 * editfns.c (Fformat): Likewise.
5562 * syntax.c (skip_chars): Likewise.
5563
5564 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
5565 This also lets GCC 4.6.0 generate slightly better loop code.
5566
5567 * callint.c (Fcall_interactively): <, not <=, for optimization.
5568 (Fcall_interactively): Count the number of arguments produced,
5569 not the number of arguments given. This is simpler and lets GCC
5570 4.6.0 generate slightly better code.
5571
5572 * ftfont.c: Distingish more carefully between FcChar8 and char.
5573 The previous code passed unsigned char * to a functions like
5574 strlen and xstrcasecmp that expect char *, which does not
5575 conform to the C standard.
5576 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
5577 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
5578 char * when the C standard requires it.
5579
5580 * keyboard.c (read_char): Remove unused var.
5581
5582 * eval.c: Port to Windows vsnprintf (Bug#8435).
5583 Include <limits.h>.
5584 (SIZE_MAX): Define if the headers do not.
5585 (verror): Do not give up if vsnprintf returns a negative count.
5586 Instead, grow the buffer. This ports to Windows vsnprintf, which
5587 does not conform to C99. Problem reported by Eli Zaretskii.
5588 Also, simplify the allocation scheme, by avoiding the need for
5589 calling realloc, and removing the ALLOCATED variable.
5590
5591 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
5592
5593 Remove invocations of doprnt, as Emacs now uses vsnprintf.
5594 But keep the doprint source code for now, as we might revamp it
5595 and use it again (Bug#8435).
5596 * lisp.h (doprnt): Remove.
5597 * Makefile.in (base_obj): Remove doprnt.o.
5598 * deps.mk (doprnt.o): Remove.
5599
5600 error: Print 32- and 64-bit integers portably (Bug#8435).
5601 Without this change, on typical 64-bit hosts error ("...%d...", N)
5602 was used to print both 32- and 64-bit integers N, which relied on
5603 undefined behavior.
5604 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
5605 New macro.
5606 * lisp.h (error, verror): Mark as printf-like functions.
5607 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
5608 Report overflow in size calculations when allocating printf buffer.
5609 Do not truncate output string at its first null byte.
5610 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
5611 Truncate the output at a character boundary, since vsnprintf does not
5612 do that.
5613 * charset.c (check_iso_charset_parameter): Convert internal
5614 character to string before calling 'error', since %c now has the
5615 printf meaning.
5616 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
5617 overflow when computing char to be passed to 'error'. Do not
5618 pass Lisp_Object to 'error'; pass the integer instead.
5619 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
5620 formatted with plain %d.
5621
5622 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
5623
5624 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
5625
5626 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
5627
5628 * xterm.c (x_catch_errors): Remove duplicate declaration.
5629
5630 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
5631
5632 * xdisp.c, lisp.h (message_nolog): Remove; unused.
5633
5634 2011-04-10 Jim Meyering <meyering@redhat.com>
5635
5636 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
5637 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
5638 return ssize_t not "int", and use size_t as the buffer length.
5639 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
5640 * gnutls.h: Update declarations.
5641 * process.c (read_process_output): Use ssize_t, to match.
5642 (send_process): Likewise.
5643
5644 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5645
5646 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
5647
5648 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
5649
5650 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
5651 Use unsigned char, to match FcChar8 type definition.
5652
5653 * xterm.c (handle_one_xevent):
5654 * xmenu.c (create_and_show_popup_menu):
5655 * xselect.c (x_decline_selection_request)
5656 (x_reply_selection_request): Avoid type-punned deref of X events.
5657
5658 2011-04-09 Eli Zaretskii <eliz@gnu.org>
5659
5660 Fix some uses of `int' instead of EMACS_INT.
5661 * search.c (string_match_1, fast_string_match)
5662 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
5663 (scan_buffer, find_next_newline_no_quit)
5664 (find_before_next_newline, search_command, Freplace_match)
5665 (Fmatch_data): Make some `int' variables be EMACS_INT.
5666
5667 * xdisp.c (display_count_lines): 3rd argument and return value now
5668 EMACS_INT. All callers changed.
5669 (pint2hrstr): Last argument is now EMACS_INT.
5670
5671 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
5672 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
5673 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
5674 (decode_coding_utf_16, decode_coding_emacs_mule)
5675 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
5676 (decode_coding_ccl, decode_coding_charset)
5677 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
5678 (decode_coding_iso_2022, decode_coding_emacs_mule)
5679 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
5680 <char_offset, last_offset>: Declare EMACS_INT.
5681 (encode_coding_utf_8, encode_coding_utf_16)
5682 (encode_coding_emacs_mule, encode_invocation_designation)
5683 (encode_designation_at_bol, encode_coding_iso_2022)
5684 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
5685 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
5686 Declare EMACS_INT.
5687 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
5688 (encode_invocation_designation): Last argument P_NCHARS is now
5689 EMACS_INT.
5690 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
5691 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
5692
5693 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
5694 All users changed.
5695
5696 * ccl.c (Fccl_execute_on_string): Declare some variables
5697 EMACS_INT.
5698
5699 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
5700
5701 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
5702
5703 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
5704
5705 * process.c (Fformat_network_address): Doc fix.
5706
5707 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
5708
5709 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
5710
5711 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
5712
5713 * keyboard.c (read_char): Call Lisp function help-form-show,
5714 instead of using internal_with_output_to_temp_buffer.
5715 (Qhelp_form_show): New var.
5716 (syms_of_keyboard): Use DEFSYM macro.
5717
5718 * print.c (internal_with_output_to_temp_buffer): Function deleted.
5719
5720 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
5721
5722 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
5723
5724 * process.c (Flist_processes): Remove to Lisp.
5725 (list_processes_1): Delete.
5726
5727 2011-04-06 Eli Zaretskii <eliz@gnu.org>
5728
5729 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
5730
5731 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
5732
5733 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
5734
5735 Fix more problems found by GCC 4.6.0's static checks.
5736
5737 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
5738
5739 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
5740
5741 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
5742
5743 * xdisp.c (vmessage): Mark as a printf-like function.
5744
5745 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
5746
5747 * sound.c (sound_warning): Don't crash if arg contains a printf format.
5748
5749 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
5750 printf-like functions.
5751 (tiff_load): Add casts to remove these marks before passing them
5752 to system-supplied API.
5753
5754 * eval.c (Fsignal): Remove excess argument to 'fatal'.
5755
5756 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
5757 This avoids several warnings with gcc -Wstrict-overflow.
5758 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
5759 directly, rather than having caller test rule sign. This avoids
5760 some unnecessary tests.
5761 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
5762 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
5763 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
5764
5765 * xfont.c (xfont_text_extents): Remove var that was set but not used.
5766 (xfont_open): Avoid unnecessary tests.
5767
5768 * composite.c (composition_gstring_put_cache): Use unsigned integer.
5769
5770 * composite.h, composite.c (composition_gstring_put_cache):
5771 Use EMACS_INT, not int, for length.
5772
5773 * composite.h (COMPOSITION_DECODE_REFS): New macro,
5774 breaking out part of COMPOSITION_DECODE_RULE.
5775 (COMPOSITION_DECODE_RULE): Use it.
5776 * composite.c (get_composition_id): Remove unused local vars,
5777 by using the new macro.
5778
5779 * textprop.c (set_text_properties_1): Change while to do-while,
5780 since the condition is always true at first.
5781
5782 * intervals.c (graft_intervals_into_buffer): Mark var as used.
5783 (interval_deletion_adjustment): Return unsigned value.
5784 All uses changed.
5785
5786 * process.c (list_processes_1, create_pty, read_process_output):
5787 (exec_sentinel): Remove vars that were set but not used.
5788 (create_pty): Remove unnecessary "volatile"s.
5789 (Fnetwork_interface_info): Avoid possibility of int overflow.
5790 (read_process_output): Do adaptive read buffering even if carryover.
5791 (read_process_output): Simplify nbytes computation if buffered.
5792
5793 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
5794
5795 * syntax.c (scan_words): Remove var that was set but not used.
5796 (update_syntax_table): Use unsigned instead of int.
5797
5798 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
5799 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
5800 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
5801
5802 * print.c (print_error_message): Avoid int overflow.
5803
5804 * font.c (font_list_entities): Redo for clarity,
5805 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
5806
5807 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
5808 (font_score): Avoid potential overflow in diff calculation.
5809
5810 * fns.c (substring_both): Remove var that is set but not used.
5811 (sxhash): Redo loop for clarity and to avoid wraparound warning.
5812
5813 * eval.c (funcall_lambda): Rename local to avoid shadowing.
5814
5815 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
5816 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
5817 can always succeed if overflow has undefined behavior.
5818
5819 * search.c (boyer_moore, wordify): Remove vars set but not used.
5820 (wordify): Omit three unnecessary tests.
5821
5822 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
5823 All callers changed. This avoids the need for an unused var.
5824
5825 * casefiddle.c (casify_region): Remove var that is set but not used.
5826
5827 * dired.c (file_name_completion): Remove var that is set but not used.
5828
5829 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
5830
5831 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
5832 (Finsert_file_contents): Remove unnecessary code checking fd.
5833
5834 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
5835 Check for integer overflow on size calculations.
5836
5837 * buffer.c (Fprevious_overlay_change): Remove var that is set
5838 but not used.
5839
5840 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
5841 Remove vars that are set but not used.
5842 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
5843 (timer_check_2): Mark vars as initialized.
5844
5845 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
5846
5847 * image.c (lookup_image): Remove var that is set but not used.
5848 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
5849
5850 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
5851 that are set but not used.
5852
5853 * xfns.c (make_invisible_cursor): Don't return garbage
5854 if XCreateBitmapFromData fails (Bug#8410).
5855
5856 * xselect.c (x_get_local_selection, x_handle_property_notify):
5857 Remove vars that are set but not used.
5858
5859 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
5860 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
5861
5862 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5863 Remove var that is set but not used.
5864 (scroll_bar_windows_size): Now size_t, not int.
5865 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5866 Check for overflow.
5867
5868 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5869 (map_tty_color) [!defined MSDOS]: Likewise.
5870
5871 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5872
5873 * coding.c: Remove vars that are set but not used.
5874 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5875 All callers changed.
5876 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5877 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5878 (decode_coding_charset): Remove vars that are set but not used.
5879
5880 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5881 that is set but not used.
5882
5883 * print.c (print_object): Remove var that is set but not used.
5884
5885 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
5886 The gnulib version avoids calling malloc in the usual case,
5887 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5888 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5889 * filelock.c (current_lock_owner): Likewise.
5890 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5891 * sysdep.c: Include allocator.h, careadlinkat.h.
5892 (emacs_no_realloc_allocator): New static constant.
5893 (emacs_readlink): New function.
5894 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5895 ../lib/careadlinkat.h.
5896
5897 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5898
5899 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5900 first non-nil return value).
5901
5902 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5903
5904 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5905 if not defined (Bug#8403).
5906
5907 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5908
5909 * xdisp.c (display_count_lines): Remove parameter `start',
5910 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5911 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5912 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5913 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5914 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5915 and thereabouts. All callers changed.
5916 (get_per_char_metric): Remove parameter `f', unused since
5917 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5918
5919 2011-04-02 Jim Meyering <meyering@redhat.com>
5920
5921 do not dereference NULL upon failed strdup
5922 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5923 (ns_get_family): Likewise.
5924
5925 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
5926
5927 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5928
5929 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5930
5931 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5932 later (Bug#8403).
5933
5934 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5935
5936 Add lexical binding.
5937
5938 * window.c (Ftemp_output_buffer_show): New fun.
5939 (Fsave_window_excursion):
5940 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5941
5942 * lread.c (lisp_file_lexically_bound_p): New function.
5943 (Fload): Bind Qlexical_binding.
5944 (readevalloop): Remove `evalfun' arg.
5945 Bind Qinternal_interpreter_environment.
5946 (Feval_buffer): Bind Qlexical_binding.
5947 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5948 Mark as dynamic.
5949 (syms_of_lread): Declare `lexical-binding'.
5950
5951 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5952
5953 * keyboard.c (eval_dyn): New fun.
5954 (menu_item_eval_property): Use it.
5955
5956 * image.c (parse_image_spec): Use Ffunctionp.
5957
5958 * fns.c (concat, mapcar1): Accept byte-code-functions.
5959
5960 * eval.c (Fsetq): Handle lexical vars.
5961 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5962 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5963 (FletX, Flet): Obey lexical binding.
5964 (Fcommandp): Handle closures.
5965 (Feval): New `lexical' arg.
5966 (eval_sub): New function extracted from Feval. Use it almost
5967 everywhere where Feval was used. Look up vars in lexical env.
5968 Handle closures.
5969 (Ffunctionp): Move from subr.el.
5970 (Ffuncall): Handle closures.
5971 (apply_lambda): Remove `eval_flags'.
5972 (funcall_lambda): Handle closures and new byte-code-functions.
5973 (Fspecial_variable_p): New function.
5974 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5975 but without exporting it to Lisp.
5976
5977 * doc.c (Fdocumentation, store_function_docstring):
5978 * data.c (Finteractive_form): Handle closures.
5979
5980 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5981 interactive spec.
5982
5983 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5984 New byte-codes.
5985 (exec_byte_code): New function extracted from Fbyte_code to handle new
5986 calling convention for byte-code-functions. Add new byte-codes.
5987
5988 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
5989
5990 * alloc.c (Fmake_symbol): Init new `declared_special' field.
5991
5992 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
5993
5994 * xdisp.c (redisplay_internal): Fix prototype.
5995
5996 2011-03-31 Eli Zaretskii <eliz@gnu.org>
5997
5998 * xdisp.c (SCROLL_LIMIT): New macro.
5999 (try_scrolling): Use it when setting scroll_limit.
6000 Limit scrolling to 100 screen lines.
6001 (redisplay_window): Even when falling back on "recentering",
6002 position point in the window according to scroll-conservatively,
6003 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6004
6005 (try_scrolling): When point is above the window, allow searching
6006 as far as scroll_max, or one screenful, to compute vertical
6007 distance from PT to the scroll margin position. This prevents
6008 try_scrolling from unnecessarily failing when
6009 scroll-conservatively is set to a value slightly larger than the
6010 window height. Clean up the case of PT below the margin at bottom
6011 of window: scroll_max can no longer be INT_MAX. When aggressive
6012 scrolling is in use, don't let point enter the opposite scroll
6013 margin as result of the scroll.
6014 (syms_of_xdisp) <scroll-conservatively>: Document the
6015 threshold of 100 lines for never-recentering scrolling.
6016
6017 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
6018
6019 * dispextern.h (move_it_by_lines):
6020 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6021 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6022 (message_log_check_duplicate): Remove parameters `prev_bol' and
6023 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6024 (redisplay_internal): Remove parameter `preserve_echo_area',
6025 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6026
6027 * indent.c (Fvertical_motion):
6028 * window.c (window_scroll_pixel_based, Frecenter):
6029 Don't pass `need_y_p' to `move_it_by_lines'.
6030
6031 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6032
6033 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6034 steal a few bits to be more compact.
6035 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6036 Remove unneeded casts.
6037
6038 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6039
6040 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6041
6042 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6043 binding" message (bug#7967).
6044
6045 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6046
6047 Fix more problems found by GCC 4.6.0's static checks.
6048
6049 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6050 Remove unused local var.
6051
6052 * editfns.c (Fmessage_box): Remove unused local var.
6053
6054 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6055 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6056 Omit unused local vars.
6057 * window.c (shrink_windows): Omit unused local var.
6058 * menu.c (digest_single_submenu): Omit unused local var.
6059 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6060 Omit unused local var.
6061
6062 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6063 Don't assume string length fits in int.
6064 (keyremap_step, read_key_sequence): Use size_t for sizes.
6065 (read_key_sequence): Don't check last_real_key_start redundantly.
6066
6067 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6068 instead of alloca (Bug#8344).
6069
6070 * eval.c (Fbacktrace): Don't assume nargs fits in int.
6071 (Fbacktrace_frame): Don't assume nframes fits in int.
6072
6073 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6074
6075 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6076 concerns.
6077
6078 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6079
6080 * cm.c (calccost): Turn while-do into do-while, for clarity.
6081
6082 * keyboard.c (syms_of_keyboard): Use the same style as later
6083 in this function when indexing through an array. This also
6084 works around GCC bug 48267.
6085
6086 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6087
6088 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6089
6090 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6091 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6092
6093 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6094 This avoids undefined behavior on integer overflow, and is a bit
6095 more convenient anyway since it is compared to a size_t variable.
6096
6097 Variadic C functions now count arguments with size_t, not int.
6098 This avoids an unnecessary limitation on 64-bit machines, which
6099 caused (substring ...) to crash on large vectors (Bug#8344).
6100 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6101 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
6102 All variadic functions and their callers changed accordingly.
6103 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6104 * data.c (arith_driver, float_arith_driver): Likewise.
6105 * editfns.c (general_insert_function): Likewise.
6106 * eval.c (struct backtrace.nargs, interactive_p)
6107 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6108 (funcall_lambda, mark_backtrace): Likewise.
6109 * fns.c (concat): Likewise.
6110 * frame.c (x_set_frame_parameters): Likewise.
6111 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6112 0 if not found, not -1. All callers changed.
6113
6114 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6115 (stack_copy_size): Now size_t, not int.
6116 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6117
6118 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6119
6120 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6121 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6122 All callers changed.
6123
6124 * lisp.h (multibyte_char_to_unibyte):
6125 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6126 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6127 * character.h (CHAR_TO_BYTE8):
6128 * cmds.c (internal_self_insert):
6129 * editfns.c (general_insert_function):
6130 * keymap.c (push_key_description):
6131 * search.c (Freplace_match):
6132 * xdisp.c (message_dolog, set_message_1): All callers changed.
6133
6134 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6135
6136 * keyboard.c (safe_run_hook_funcall): New function.
6137 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6138 don't set the hook to nil, but remove the offending function instead.
6139 (Qcommand_hook_internal): Remove, unused.
6140 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6141 Vcommand_hook_internal.
6142
6143 * eval.c (enum run_hooks_condition): Remove.
6144 (funcall_nil, funcall_not): New functions.
6145 (run_hook_with_args): Call each function through a `funcall' argument.
6146 Remove `cond' argument, now redundant.
6147 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6148 (Frun_hook_with_args_until_failure): Adjust accordingly.
6149 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6150
6151 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
6152
6153 * dispextern.h (string_buffer_position): Remove declaration.
6154
6155 * print.c (strout): Remove parameter `multibyte', unused since
6156 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6157
6158 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6159 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6160 All callers changed.
6161
6162 * w32.c (_wsa_errlist): Use braces for struct initializers.
6163
6164 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6165 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6166 All callers changed.
6167 (string_buffer_position): Likewise. Also, make static (it's never
6168 used outside xdisp.c).
6169 (cursor_row_p): Remove parameter `w', unused since
6170 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6171 (decode_mode_spec): Remove parameter `precision', introduced during
6172 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6173 All callers changed.
6174
6175 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6176
6177 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6178
6179 2011-03-27 Anders Lindgren <andlind@gmail.com>
6180
6181 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6182 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6183 (ns_update_auto_hide_menu_bar): New functions.
6184 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6185 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6186 ns_constrain_all_frames.
6187 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6188 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6189
6190 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6191
6192 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6193
6194 2011-03-27 Glenn Morris <rgm@gnu.org>
6195
6196 * syssignal.h: Replace RETSIGTYPE with void.
6197 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6198 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6199 Replace SIGTYPE with void everywhere.
6200 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6201 * s/template.h (SIGTYPE): Remove commented out definition.
6202
6203 2011-03-26 Eli Zaretskii <eliz@gnu.org>
6204
6205 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6206 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6207
6208 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
6209
6210 * w32.c (read_unc_volume): Use parameter `henum', instead of
6211 global variable `wget_enum_handle'.
6212
6213 * keymap.c (describe_vector): Remove parameters `indices' and
6214 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6215 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6216
6217 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6218
6219 * keyboard.c (timer_check): Remove parameter `do_it_now',
6220 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6221 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6222 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6223
6224 * keyboard.c (read_char):
6225 * w32menu.c (w32_menu_display_help):
6226 * xmenu.c (show_help_event, menu_help_callback):
6227 Adjust calls to `show_help_echo'.
6228
6229 * gtkutil.c (xg_maybe_add_timer):
6230 * keyboard.c (readable_events):
6231 * process.c (wait_reading_process_output):
6232 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6233
6234 * insdel.c (adjust_markers_gap_motion):
6235 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6236 (gap_left, gap_right): Don't call it.
6237
6238 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
6239
6240 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6241 incurred during fontification.
6242
6243 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6244
6245 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6246 (DEFVAR_PER_BUFFER): Don't pass it.
6247
6248 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6249 (scrolling_window): Don't pass it.
6250
6251 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
6252
6253 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6254
6255 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6256 and `suffix'.
6257 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6258 of variables specific to SELinux and computation of `encoded_absname'.
6259
6260 * image.c (XPutPixel): Remove unused variable `height'.
6261
6262 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6263
6264 * unexw32.c (get_section_info): Remove unused variable `section'.
6265
6266 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6267 (system_process_attributes): Remove unused variable `sess'.
6268 (sys_read): Remove unused variable `err'.
6269
6270 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6271 (w32_wnd_proc): Remove unused variable `isdead'.
6272 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6273 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6274 (x_create_tip_frame): Remove unused variable `tem'.
6275
6276 * w32inevt.c (w32_console_read_socket):
6277 Remove unused variable `no_events'.
6278
6279 * w32term.c (x_draw_composite_glyph_string_foreground):
6280 Remove unused variable `width'.
6281
6282 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
6283
6284 * w32term.c (x_set_glyph_string_clipping):
6285 Don't pass uninitialized region to CombineRgn.
6286
6287 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
6288
6289 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6290 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6291 (Fx_close_connection): Remove unused variable `i'.
6292
6293 * w32font.c (w32font_draw): Return number of glyphs.
6294 (w32font_open_internal): Remove unused variable `i'.
6295 (w32font_driver): Add missing initializer.
6296
6297 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6298 (fill_in_menu): Remove unused variable `items_added'.
6299
6300 * w32term.c (last_mouse_press_frame): Remove static global variable.
6301 (w32_clip_to_row): Remove unused variable `f'.
6302 (x_delete_terminal): Remove unused variable `i'.
6303
6304 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6305 (NOTHING): Remove unused static global variable.
6306 (uniscribe_check_otf): Remove unused variable `table'.
6307 (uniscribe_font_driver): Add missing initializers.
6308
6309 2011-03-23 Julien Danjou <julien@danjou.info>
6310
6311 * term.c (Fsuspend_tty, Fresume_tty):
6312 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6313 * window.c (temp_output_buffer_show):
6314 * insdel.c (signal_before_change):
6315 * frame.c (Fhandle_switch_frame):
6316 * fileio.c (Fdo_auto_save):
6317 * emacs.c (Fkill_emacs):
6318 * editfns.c (save_excursion_restore):
6319 * cmds.c (internal_self_insert):
6320 * callint.c (Fcall_interactively):
6321 * buffer.c (Fkill_all_local_variables):
6322 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6323 Use Frun_hooks.
6324 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
6325 unconditionnaly since it does the check itself.
6326
6327 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
6328
6329 Fix more problems found by GCC 4.5.2's static checks.
6330
6331 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6332 the first time through the loop, since we know p0 < p1 then.
6333 This also avoids a gcc -Wstrict-overflow warning.
6334
6335 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6336 leading to a memory leak, possible in functions like
6337 load_charset_map_from_file that can allocate an unbounded number
6338 of objects (Bug#8318).
6339
6340 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6341 that could (at least in theory) be that large.
6342
6343 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6344 This is less likely to overflow, and avoids undefined behavior if
6345 overflow does occur. All callers changed. Use strtoul to scan
6346 for the unsigned long integer.
6347 (pint2hrstr): Simplify and tune code slightly.
6348 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
6349
6350 * scroll.c (do_scrolling): Work around GCC bug 48228.
6351 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6352
6353 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6354 This also avoids a warning with gcc -Wstrict-overflow.
6355 (validate_x_resource_name): Simplify count usage.
6356 This also avoids a warning with gcc -Wstrict-overflow.
6357
6358 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6359 fail (Bug#8306).
6360
6361 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
6362
6363 * process.c (Fmake_network_process): Use socklen_t, not int,
6364 where POSIX says socklen_t is required in portable programs.
6365 This fixes a porting bug on hosts like 64-bit HP-UX, where
6366 socklen_t is wider than int (Bug#8277).
6367 (Fmake_network_process, server_accept_connection):
6368 (wait_reading_process_output, read_process_output):
6369 Likewise.
6370
6371 * process.c: Rename or move locals to avoid shadowing.
6372 (list_processes_1, Fmake_network_process):
6373 (read_process_output_error_handler, exec_sentinel_error_handler):
6374 Rename or move locals.
6375 (Fmake_network_process): Define label "retry_connect" only if needed.
6376 (Fnetwork_interface_info): Fix pointer signedness.
6377 (process_send_signal): Add cast to avoid pointer signedness problem.
6378 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
6379 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
6380
6381 Make tparam.h and terminfo.c consistent.
6382 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6383 Include tparam.h instead, since it declares them.
6384 * cm.h (PC): Remove extern decl; tparam.h now does this.
6385 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6386 * terminfo.c: Include tparam.h, to check interfaces.
6387 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6388 (tparam): Adjust signature to match interface in tparam.h;
6389 this removes some undefined behavior. Check that outstring and len
6390 are zero, which they always are with Emacs.
6391 * tparam.h (PC, BC, UP): New extern decls.
6392
6393 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
6394 (xftfont_open): Rename locals to avoid shadowing.
6395
6396 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
6397 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6398 (OTF_TAG_SYM): Omit macro if not needed.
6399 (ftfont_list): Remove unused local.
6400 (get_adstyle_property, ftfont_pattern_entity):
6401 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6402 Rename locals to avoid shadowing.
6403
6404 * xfont.c (xfont_list_family): Mark var as initialized.
6405
6406 * xml.c (make_dom): Now static.
6407
6408 * composite.c (composition_compute_stop_pos): Rename local to
6409 avoid shadowing.
6410 (composition_reseat_it): Remove unused locals.
6411 (find_automatic_composition, composition_adjust_point): Likewise.
6412 (composition_update_it): Mark var as initialized.
6413 (find_automatic_composition): Mark vars as initialized,
6414 with a FIXME (Bug#8290).
6415
6416 character.h: Rename locals to avoid shadowing.
6417 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6418 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6419 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
6420 (BUF_DEC_POS): Be more systematic about renaming local temporaries
6421 to avoid shadowing.
6422
6423 * textprop.c (property_change_between_p): Remove; unused.
6424
6425 * intervals.c (interval_start_pos): Now static.
6426
6427 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
6428
6429 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
6430 Rename locals to avoid shadowing.
6431
6432 * sound.c (wav_play, au_play, Fplay_sound_internal):
6433 Fix pointer signedness.
6434 (alsa_choose_format): Remove unused local var.
6435 (wav_play): Initialize a variable to 0, to prevent undefined
6436 behavior (Bug#8278).
6437
6438 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
6439
6440 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
6441
6442 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
6443 clobbering (Bug#8298).
6444 * sysdep.c (sys_subshell): Likewise.
6445 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
6446
6447 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
6448 This should get cleaned up, so that child_setup has the
6449 same signature on all platforms.
6450
6451 * callproc.c (call_process_cleanup): Now static.
6452 (relocate_fd): Rename locals to avoid shadowing.
6453
6454 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
6455
6456 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
6457 not to be necessary, and produces flickering.
6458
6459 2011-03-20 Glenn Morris <rgm@gnu.org>
6460
6461 * config.in: Remove file.
6462
6463 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
6464
6465 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
6466 are now in src/globals.h.
6467 (syms_of_minibuf): Remove spurious & from previous change.
6468
6469 2011-03-20 Leo <sdl.web@gmail.com>
6470
6471 * minibuf.c (completing-read-function): New variable.
6472 (completing-read-default): Rename from completing-read.
6473 (completing-read): Call completing-read-function.
6474
6475 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6476
6477 * xfaces.c (Fx_load_color_file):
6478 Read color file from absolute filename (bug#8250).
6479
6480 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
6481
6482 * makefile.w32-in: Update dependencies.
6483
6484 2011-03-17 Eli Zaretskii <eliz@gnu.org>
6485
6486 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
6487
6488 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
6489
6490 Fix more problems found by GCC 4.5.2's static checks.
6491
6492 * process.c (make_serial_process_unwind, send_process_trap):
6493 (sigchld_handler): Now static.
6494
6495 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
6496 That way, the code declares only the vars that it needs.
6497 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
6498 * s/cygwin.h (PTY_ITERATION): Likewise.
6499 * s/darwin.h (PTY_ITERATION): Likewise.
6500 * s/gnu-linux.h (PTY_ITERATION): Likewise.
6501
6502 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
6503 * process.c (allocate_pty): Don't declare stb unless it's needed.
6504
6505 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
6506 (CONSTANTLIM): Remove; unused.
6507 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
6508 Define only if needed.
6509
6510 * unexelf.c (unexec): Name an expression,
6511 to avoid gcc -Wbad-function-cast warning.
6512 Use a different way to cause a compilation error if anyone uses
6513 n rather than nn, a way that does not involve shadowing.
6514 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
6515
6516 * deps.mk (unexalpha.o): Remove; unused.
6517
6518 New file unexec.h, the (simple) interface for unexec (Bug#8267).
6519 * unexec.h: New file.
6520 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
6521 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
6522 Depend on unexec.h.
6523 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
6524 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
6525 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
6526 Change as necessary to match prototype in unexec.h.
6527
6528 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
6529 shadowing.
6530 (back_comment, skip_chars): Mark vars as initialized.
6531
6532 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
6533 Rename locals to avoid shadowing.
6534
6535 * lread.c (read1): Rewrite so as not to use empty "else".
6536 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
6537
6538 * print.c (Fredirect_debugging_output): Fix pointer signedess.
6539
6540 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
6541 warning when compiling print.c.
6542
6543 * font.c (font_unparse_fcname): Abort in an "impossible" situation
6544 instead of using an uninitialized var.
6545 (font_sort_entities): Mark var as initialized.
6546
6547 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
6548
6549 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
6550 pointers to constants.
6551 (font_parse_fcname): Remove unused vars.
6552 (font_delete_unmatched): Now static.
6553 (font_get_spec): Remove; unused.
6554 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
6555 (font_update_drivers, Ffont_get_glyphs, font_add_log):
6556 Rename or move locals to avoid shadowing.
6557
6558 * fns.c (require_nesting_list, require_unwind): Now static.
6559 (Ffillarray): Rename locals to avoid shadowing.
6560
6561 * floatfns.c (domain_error2): Define only if needed.
6562 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
6563
6564 * alloc.c (mark_backtrace): Move decl from here ...
6565 * lisp.h: ... to here, so that it can be checked.
6566
6567 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
6568 (Fdefvar): Rewrite so as not to use empty "else".
6569 (lisp_indirect_variable): Name an expression,
6570 to avoid gcc -Wbad-function-cast warning.
6571 (Fdefvar): Rename locals to avoid shadowing.
6572
6573 * callint.c (quotify_arg, quotify_args): Now static.
6574 (Fcall_interactively): Rename locals to avoid shadowing.
6575 Use const pointer when appropriate.
6576
6577 * lisp.h (get_system_name, get_operating_system_release):
6578 Move decls here, to check interfaces.
6579 * process.c (get_operating_system_release): Move decl to lisp.h.
6580 * xrdb.c (get_system_name): Likewise.
6581 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
6582 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
6583 some of which prompt warnings from gcc -Wbad-function-cast.
6584 (Fformat_time_string, Fencode_time, Finsert_char):
6585 (Ftranslate_region_internal, Fformat):
6586 Rename or remove local vars to avoid shadowing.
6587 (Ftranslate_region_internal): Mark var as initialized.
6588
6589 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
6590 avoid shadowing.
6591
6592 * lisp.h (eassert): Check that the argument compiles, even if
6593 ENABLE_CHECKING is not defined.
6594
6595 * data.c (Findirect_variable): Name an expression, to avoid
6596 gcc -Wbad-function-cast warning.
6597 (default_value, arithcompare, arith_driver, arith_error): Now static.
6598 (store_symval_forwarding): Rename local to avoid shadowing.
6599 (Fmake_variable_buffer_local, Fmake_local_variable):
6600 Mark variables as initialized.
6601 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
6602
6603 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
6604 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
6605 Rename locals to avoid shadowing.
6606 (mark_stack): Move local variables into the #ifdef region where
6607 they're used.
6608 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
6609 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
6610 needed otherwise.
6611 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
6612 (GC_STRING_CHARS): Remove; not used.
6613 (Fmemory_limit): Cast sbrk's returned value to char *.
6614
6615 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
6616 avoids undefined behavior in theory.
6617
6618 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
6619
6620 Use functions, not macros, for up- and down-casing (Bug#8254).
6621 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6622 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
6623 to use the following functions instead of these macros.
6624 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
6625 EMACS_INT, since callers assume the returned value fits in int.
6626 (upcase1): Likewise, for UPCASE_TABLE.
6627 (uppercasep, lowercasep, upcase): New static inline functions.
6628 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
6629 the race-condition problem in the old DOWNCASE.
6630
6631 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
6632 Rename locals to avoid shadowing.
6633 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
6634 (regex_compile, re_search_2, re_match_2_internal):
6635 Remove unused local vars.
6636 (FREE_VAR): Rewrite so as not to use empty "else",
6637 which gcc can warn about.
6638 (regex_compile, re_match_2_internal): Mark locals as initialized.
6639 (RETALLOC_IF): Define only if needed.
6640 (WORDCHAR_P): Likewise. This one is never needed, but is used
6641 only in a comment talking about a compiler bug, so put inside
6642 the #if 0 of that comment.
6643 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
6644 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
6645 Remove; unused.
6646
6647 * search.c (boyer_moore): Rename locals to avoid shadowing.
6648 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
6649 (PREV_CHAR_BOUNDARY): Likewise.
6650
6651 * search.c (simple_search): Remove unused var.
6652
6653 * dired.c (compile_pattern): Move decl from here ...
6654 * lisp.h: ... to here, so that it can be checked.
6655 (struct re_registers): New forward decl.
6656
6657 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
6658
6659 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
6660 All uses changed.
6661 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
6662 Rename locals to avoid shadowing.
6663 (Fvertical_motion): Mark locals as initialized.
6664
6665 * casefiddle.c (casify_object, casify_region): Now static.
6666 (casify_region): Mark local as initialized.
6667
6668 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
6669
6670 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
6671 New macros, so that the caller can use some names other than
6672 gcpro1, gcpro2, etc.
6673 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
6674 of the new macros.
6675 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
6676 argument, for consistency with GCPRO2_VAR, etc: it is now the
6677 prefix of the variable, not the variable itself. All uses
6678 changed.
6679 * dired.c (directory_files_internal, file_name_completion):
6680 Rename locals to avoid shadowing.
6681
6682 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
6683 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
6684 dired.c's scmp function, had undefined behavior.
6685 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6686 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
6687 * buffer.h: ... to here, because these macros use current_buffer,
6688 and the new implementation with inline functions needs to have
6689 current_buffer in scope now, rather than later when the macros
6690 are used.
6691 (downcase, upcase1): New static inline functions.
6692 (DOWNCASE, UPCASE1): Reimplement using these functions.
6693 This avoids undefined behavior in expressions like
6694 DOWNCASE (x) == DOWNCASE (y), which previously suffered
6695 from race conditions in accessing the global variables
6696 case_temp1 and case_temp2.
6697 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
6698 * lisp.h (case_temp1, case_temp2): Remove their decls.
6699 * character.h (ASCII_CHAR_P): Move from here ...
6700 * lisp.h: ... to here, so that the inline functions mentioned
6701 above can use them.
6702
6703 * dired.c (directory_files_internal_unwind): Now static.
6704
6705 * fileio.c (file_name_as_directory, directory_file_name):
6706 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
6707 Now static.
6708 (file_name_as_directory): Use const pointers when appropriate.
6709 (Fexpand_file_name): Likewise. In particular, newdir might
6710 point at constant storage, so make it a const pointer.
6711 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
6712 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
6713 signedness issues.
6714 (Fset_file_times, Finsert_file_contents, auto_save_error):
6715 Rename locals to avoid shadowing.
6716
6717 * minibuf.c (choose_minibuf_frame_1): Now static.
6718 (Ftry_completion, Fall_completions): Rename or remove locals
6719 to avoid shadowing.
6720
6721 * marker.c (bytepos_to_charpos): Remove; unused.
6722
6723 * lisp.h (verify_bytepos, count_markers): New decls,
6724 so that gcc does not warn that these functions aren't declared.
6725
6726 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
6727 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
6728 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
6729 (copy_text): Remove unused local var.
6730
6731 * filelock.c (within_one_second): Now static.
6732 (lock_file_1): Rename local to avoid shadowing.
6733
6734 * buffer.c (fix_overlays_before): Mark locals as initialized.
6735 (fix_start_end_in_overlays): Likewise. This function should be
6736 simplified by using pointers-to-pointers, but that's a different
6737 matter.
6738 (switch_to_buffer_1): Now static.
6739 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
6740 (report_overlay_modification): Rename locals to avoid shadowing.
6741
6742 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
6743 Fix pointer signedness issue.
6744 (sys_subshell): Mark local as volatile if checking for lint,
6745 to suppress a gcc -Wclobbered warning that does not seem to be right.
6746 (MAXPATHLEN): Define only if needed.
6747
6748 * process.c (serial_open, serial_configure): Move decls from here ...
6749 * systty.h: ... to here, so that they can be checked.
6750
6751 * fns.c (get_random, seed_random): Move extern decls from here ...
6752 * lisp.h: ... to here, so that they can be checked.
6753
6754 * sysdep.c (reset_io): Now static.
6755 (wait_for_termination_signal): Remove; unused.
6756
6757 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
6758 (copy_keymap_item, append_key, push_text_char_description):
6759 Now static.
6760 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
6761 (DENSE_TABLE_SIZE): Remove; unused.
6762 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
6763 (describe_map_tree):
6764 Rename locals to avoid shadowing.
6765
6766 * keyboard.c: Declare functions static if they are not used elsewhere.
6767 (echo_char, echo_dash, cmd_error, top_level_2):
6768 (poll_for_input, handle_async_input): Now static.
6769 (read_char, kbd_buffer_get_event, make_lispy_position):
6770 (make_lispy_event, make_lispy_movement, apply_modifiers):
6771 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
6772 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
6773 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
6774 (read_key_sequence, read_char): Mark locals as initialized.
6775 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
6776
6777 * keyboard.h (make_ctrl_char): New decl.
6778 (mark_kboards): Move decl here ...
6779 * alloc.c (mark_kboards): ... from here.
6780
6781 * lisp.h (force_auto_save_soon): New decl.
6782
6783 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
6784 (DEFINE_DUMMY_FUNCTION): New macro.
6785 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
6786 Use it.
6787 (main): Add casts to avoid warnings
6788 if GCC considers string literals to be constants.
6789
6790 * lisp.h (fatal_error_signal): Add decl, since it's exported.
6791
6792 * dbusbind.c: Pointer signedness fixes.
6793 (xd_signature, xd_append_arg, xd_initialize):
6794 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6795 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6796 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
6797 (Fdbus_register_signal): Use SSDATA when the context wants char *.
6798
6799 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
6800 if GCC considers string literals to be constants.
6801 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
6802
6803 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
6804
6805 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
6806 (print_preprocess, print_object): New macro to fix last change.
6807
6808 * print.c (print_preprocess): Don't forget font objects.
6809
6810 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
6811
6812 * emacs.c (USAGE3): Doc fixes.
6813
6814 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
6815
6816 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
6817 structure.
6818
6819 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
6820
6821 * lisp.h (VWindow_system, Qfile_name_history):
6822 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
6823 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
6824 (w32_system_caret_x, w32_system_caret_y): Declare extern.
6825
6826 * w32select.c: Don't #include "keyboard.h".
6827 (run_protected): Add extern declaration for waiting_for_input.
6828
6829 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
6830 * w32console.c (detect_input_pending, read_input_pending)
6831 (encode_terminal_code):
6832 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
6833 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
6834 (w32_system_caret_y, Qfile_name_history):
6835 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
6836 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
6837 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
6838 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
6839 * w32proc.c (Qlocal, report_file_error):
6840 * w32term.c (Vwindow_system, updating_frame):
6841 * w32uniscribe.c (initialized, uniscribe_font_driver):
6842 Remove unneeded extern declarations.
6843
6844 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
6845
6846 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
6847
6848 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
6849
6850 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
6851 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
6852 These macros can no longer be used for assignment.
6853
6854 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6855 Assign struct members directly, instead of using BUF_BEGV etc.
6856 (record_buffer_markers, fetch_buffer_markers): New functions for
6857 recording and fetching special buffer markers.
6858 (set_buffer_internal_1, set_buffer_temp): Use them.
6859
6860 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
6861
6862 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6863
6864 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6865 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6866
6867 * xdisp.c (hscroll_window_tree):
6868 (reconsider_clip_changes): Use PT instead of BUF_PT.
6869
6870 2011-03-13 Eli Zaretskii <eliz@gnu.org>
6871
6872 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6873 $(EMACS_ROOT)/lib/intprops.h.
6874
6875 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6876
6877 Fix more problems found by GCC 4.5.2's static checks.
6878
6879 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6880 to unsigned char * to avoid compiler diagnostic.
6881 (xg_free_frame_widgets): Make it clear that a local variable is
6882 needed only if USE_GTK_TOOLTIP.
6883 (gdk_window_get_screen): Make it clear that this macro is needed
6884 only if USE_GTK_TOOLTIP.
6885 (int_gtk_range_get_value): New function, which avoids a diagnostic
6886 from gcc -Wbad-function-cast.
6887 (xg_set_toolkit_scroll_bar_thumb): Use it.
6888 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6889 diagnostic from gcc -Wbad-function-cast.
6890 (get_utf8_string, xg_get_file_with_chooser):
6891 Rename locals to avoid shadowing.
6892 (create_dialog): Move locals to avoid shadowing.
6893
6894 * xgselect.c (xg_select): Remove unused var.
6895
6896 * image.c (four_corners_best): Mark locals as initialized.
6897 (gif_load): Initialize transparent_p to zero (Bug#8238).
6898 Mark another local as initialized.
6899 (my_png_error, my_error_exit): Mark with NO_RETURN.
6900
6901 * image.c (clear_image_cache): Now static.
6902 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
6903 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
6904 (x_edge_detection): Remove unnecessary cast that
6905 gcc -Wbad-function-cast diagnoses.
6906 (gif_load): Fix pointer signedness.
6907 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6908 (jpeg_load, gif_load): Rename locals to avoid shadowing.
6909
6910 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
6911
6912 Improve quality of tests for time stamp overflow.
6913 For example, without this patch (encode-time 0 0 0 1 1
6914 1152921504606846976) returns the obviously-bogus value (-948597
6915 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6916 reports time overflow. See
6917 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
6918 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6919 * editfns.c: Include limits.h and intprops.h.
6920 (TIME_T_MIN, TIME_T_MAX): New macros.
6921 (time_overflow): Move earlier, to before first use.
6922 (hi_time, lo_time): New functions, for an accurate test for
6923 out-of-range times.
6924 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6925 (Fget_internal_run_time): Don't assume time_t fits in int.
6926 (make_time): Use list2 instead of Fcons twice.
6927 (Fdecode_time): More accurate test for out-of-range times.
6928 (check_tm_member): New function.
6929 (Fencode_time): Use it, to test for out-of-range times.
6930 (lisp_time_argument): Don't rely on undefined left-shift and
6931 right-shift behavior when checking for time stamp overflow.
6932
6933 * editfns.c (time_overflow): New function, refactoring common code.
6934 (Fformat_time_string, Fdecode_time, Fencode_time):
6935 (Fcurrent_time_string): Use it.
6936
6937 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6938 * dired.c (make_time): Move to ...
6939 * editfns.c (make_time): ... here.
6940 * systime.h: Note the move.
6941
6942 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6943
6944 * fringe.c (update_window_fringes): Remove unused variables.
6945
6946 * unexmacosx.c (copy_data_segment): Also copy __got section.
6947 (Bug#8223)
6948
6949 2011-03-12 Eli Zaretskii <eliz@gnu.org>
6950
6951 * termcap.c [MSDOS]: Include "msdos.h".
6952 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6953 Constify `char *' arguments and their references according to
6954 prototypes in tparam.h.
6955
6956 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
6957
6958 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6959 Adapt all references accordingly.
6960
6961 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6962
6963 2011-03-11 Tom Tromey <tromey@redhat.com>
6964
6965 * buffer.c (syms_of_buffer): Remove obsolete comment.
6966
6967 2011-03-11 Eli Zaretskii <eliz@gnu.org>
6968
6969 * termhooks.h (encode_terminal_code): Declare prototype.
6970
6971 * msdos.c (encode_terminal_code): Don't declare prototype.
6972
6973 * term.c (encode_terminal_code): Now external again, used by
6974 w32console.c and msdos.c.
6975
6976 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6977 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
6978
6979 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
6980
6981 Fix some minor problems found by GCC 4.5.2's static checks.
6982
6983 * fringe.c (update_window_fringes): Mark locals as initialized
6984 (Bug#8227).
6985 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
6986
6987 * alloc.c (mark_fringe_data): Move decl from here ...
6988 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6989 to check its interface.
6990 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6991
6992 * fontset.c (free_realized_fontset): Now static.
6993 (Fset_fontset_font): Rename local to avoid shadowing.
6994 (fontset_font): Mark local as initialized.
6995 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
6996
6997 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6998
6999 * xselect.c (x_disown_buffer_selections): Remove; not used.
7000 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
7001 (x_own_selection, Fx_disown_selection_internal): Rename locals
7002 to avoid shadowing.
7003 (x_handle_dnd_message): Remove local to avoid shadowing.
7004
7005 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7006 so that the caller can use some name other than gcpro1.
7007 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
7008 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7009 (Fx_backspace_delete_keys_p):
7010 Use them to avoid shadowing, and rename vars to avoid shadowing.
7011 (x_decode_color, x_set_name, x_window): Now static.
7012 (Fx_create_frame): Add braces to silence GCC warning.
7013 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
7014 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7015 Remove unused locals.
7016 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7017 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7018 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7019 macros.
7020
7021 * xterm.h (x_mouse_leave): New decl.
7022
7023 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7024 Remove unused functions.
7025 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7026 (x_calc_absolute_position): Now static.
7027 (XTread_socket): Don't define label "out" unless it's used.
7028 Don't declare local "event" unless it's used.
7029 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7030 unless they are used.
7031 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7032 (x_fatal_error_signal): Remove; not used.
7033 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7034 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7035 (x_error_catcher, x_connection_closed, x_error_handler):
7036 (x_error_quitter, xembed_send_message, x_iconify_frame):
7037 (my_log_handler): Rename locals to avoid shadowing.
7038 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
7039 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
7040
7041 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7042 Rename or move locals to avoid shadowing.
7043 (tty_defined_color, merge_face_heights): Now static.
7044 (free_realized_faces_for_fontset): Remove; not used.
7045 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7046 does not deduce is never used uninitialized.
7047 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7048 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
7049
7050 * terminal.c (store_terminal_param): Now static.
7051
7052 * xmenu.c (menu_highlight_callback): Now static.
7053 (set_frame_menubar): Remove unused local.
7054 (xmenu_show): Rename parameter to avoid shadowing.
7055 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7056 since they might point to immutable storage.
7057 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7058 since it's unused otherwise.
7059
7060 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
7061 Add a FIXME, since the code still doesn't look right. (Bug#8215)
7062 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7063 avoids a gcc -Wuninitialized diagnostic.
7064 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
7065 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7066 does not deduce are never used uninitialized.
7067
7068 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7069
7070 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
7071 * window.c (window_loop, size_window):
7072 (run_window_configuration_change_hook, enlarge_window): Likewise.
7073
7074 * window.c (display_buffer): Now static.
7075 (size_window): Mark variables that gcc -Wuninitialized
7076 does not deduce are never used uninitialized.
7077 * window.h (check_all_windows): New decl, to forestall
7078 gcc -Wmissing-prototypes diagnostic.
7079 * dispextern.h (bidi_dump_cached_states): Likewise.
7080
7081 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7082 shadowing.
7083 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
7084 Include <limits.h>.
7085 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7086 and to avoid gcc -Wuninitialized warning.
7087 (load_charset_map): Mark variables that gcc -Wuninitialized
7088 does not deduce are never used uninitialized.
7089 (load_charset): Abort instead of using uninitialized var (Bug#8229).
7090
7091 * coding.c (coding_set_source, coding_set_destination):
7092 Use "else { /* comment */ }" rather than "else /* comment */;"
7093 for clarity, and to avoid gcc -Wempty-body warning.
7094 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7095 a block, when the outer 'i' will do.
7096 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7097 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7098 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7099 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7100 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7101 Rename locals to avoid shadowing.
7102 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
7103 * coding.c (emacs_mule_char, encode_invocation_designation):
7104 Now static, since they're not used elsewhere.
7105 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
7106 (decode_coding_object, encode_coding_object, detect_coding_system):
7107 (decode_coding_emacs_mule): Mark variables that gcc
7108 -Wuninitialized does not deduce are never used uninitialized.
7109 (detect_coding_iso_2022): Initialize a local variable that might
7110 be used uninitialized. Leave a FIXME because it's not clear that
7111 this initialization is needed. (Bug#8211)
7112 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7113 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7114 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7115 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7116 Remove unused macros.
7117
7118 * category.c (hash_get_category_set): Remove unused local var.
7119 (copy_category_table): Now static, since it's not used elsewhere.
7120 * character.c (string_count_byte8): Likewise.
7121
7122 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7123 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7124
7125 * chartab.c (copy_sub_char_table): Now static, since it's not used
7126 elsewhere.
7127 (sub_char_table_ref_and_range, char_table_ref_and_range):
7128 Rename locals to avoid shadowing.
7129 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
7130
7131 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
7132 (BIDI_BOB): Remove unused macro.
7133
7134 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7135 deduce are never used uninitialized.
7136 * term.c (encode_terminal_code): Likewise.
7137
7138 * term.c (encode_terminal_code): Now static. Remove unused local.
7139
7140 * tparam.h: New file.
7141 * term.c, tparam.h: Include it.
7142 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7143 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7144 Move these decls to tparam.h, and make them agree with what
7145 is actually in tparam.c. The previous trick of using incompatible
7146 decls in different modules does not conform to the C standard.
7147 All callers of tparam changed to use tparam's actual API.
7148 * tparam.c (tparam1, tparam, tgoto):
7149 Use const pointers where appropriate.
7150
7151 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7152 * cm.h (struct cm): Likewise.
7153 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7154 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7155 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7156 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7157 (turn_on_face, init_tty): Likewise.
7158 * termchar.h (struct tty_display_info): Likewise.
7159
7160 * term.c (term_mouse_position): Rename local to avoid shadowing.
7161
7162 * alloc.c (mark_ttys): Move decl from here ...
7163 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7164
7165 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7166
7167 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7168
7169 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
7170
7171 * search.c (compile_pattern_1): Remove argument regp, unused since
7172 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7173 (compile_pattern): Don't pass it.
7174
7175 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7176
7177 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7178 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7179 for ! HAVE_GTK3.
7180 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7181
7182 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7183
7184 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7185 gdk_window_get_screen, gdk_window_get_geometry,
7186 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7187 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7188 (xg_get_pixbuf_from_pixmap): New function.
7189 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7190 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7191 Call xg_get_pixbuf_from_pixmap instead of
7192 gdk_pixbuf_get_from_drawable.
7193 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7194 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7195 (xg_check_special_colors): Use GtkStyleContext and its functions
7196 for HAVE_GTK3.
7197 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7198 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7199 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
7200 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7201 Call gtk_widget_get_preferred_size.
7202 (xg_frame_resized): gdk_window_get_geometry only takes 5
7203 parameters.
7204 (xg_win_to_widget, xg_event_is_for_menubar):
7205 Call gdk_x11_window_lookup_for_display.
7206 (xg_set_widget_bg): New function.
7207 (delete_cb): New function.
7208 (xg_create_frame_widgets): Connect delete-event to delete_cb.
7209 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7210 (xg_set_background_color): Call xg_set_widget_bg.
7211 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7212 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7213 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7214 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7215 if ! HAVE_GTK3.
7216 (update_frame_tool_bar): Call gtk_widget_hide.
7217 (xg_initialize): Use GDK_KEY_g.
7218
7219 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7220 if ! HAVE_GTK3
7221 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7222
7223 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7224 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7225 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7226
7227 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
7228
7229 * w32xfns.c (select_palette): Check success of RealizePalette against
7230 GDI_ERROR, not zero.
7231
7232 See ChangeLog.11 for earlier changes.
7233
7234 ;; Local Variables:
7235 ;; coding: utf-8
7236 ;; End:
7237
7238 Copyright (C) 2011 Free Software Foundation, Inc.
7239
7240 This file is part of GNU Emacs.
7241
7242 GNU Emacs is free software: you can redistribute it and/or modify
7243 it under the terms of the GNU General Public License as published by
7244 the Free Software Foundation, either version 3 of the License, or
7245 (at your option) any later version.
7246
7247 GNU Emacs is distributed in the hope that it will be useful,
7248 but WITHOUT ANY WARRANTY; without even the implied warranty of
7249 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7250 GNU General Public License for more details.
7251
7252 You should have received a copy of the GNU General Public License
7253 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.