]> code.delx.au - gnu-emacs/blob - src/ChangeLog
Cruft removal in struct image.
[gnu-emacs] / src / ChangeLog
1 2011-06-11 Chong Yidong <cyd@stupidchicken.com>
2
3 * dispextern.h (struct image): Replace data member, whose int_val
4 and ptr_val fields were not used by anything, with a single
5 lisp_val object.
6
7 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
8 (gif_clear_image, gif_load, imagemagick_load_image)
9 (gs_clear_image, gs_load): Callers changed.
10
11 2011-06-10 Paul Eggert <eggert@cs.ucla.edu>
12
13 * buffer.h: Include <time.h>, for time_t.
14 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
15
16 Fix minor problems found by static checking.
17
18 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
19
20 Make identifiers static if they are not used in other modules.
21 * data.c (Qcompiled_function, Qframe, Qvector):
22 * image.c (QimageMagick, Qsvg):
23 * minibuf.c (Qmetadata):
24 * window.c (resize_window_check, resize_root_window): Now static.
25 * window.h (resize_window_check, resize_root_window): Remove decls.
26
27 * window.c (window_deletion_count, delete_deletable_window):
28 Remove; unused.
29 (window_body_lines): Now static.
30 (Fdelete_other_windows_internal): Mark vars as initialized.
31 Make sure 'resize_failed' is initialized.
32 (run_window_configuration_change_hook): Rename local to avoid shadowing.
33 (resize_window_apply): Remove unused local.
34 * window.h (delete_deletable_window): Remove decl.
35
36 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
37 (imagemagick_load_image): Fix pointer signedness problem by changing
38 last arg from unsigned char * to char *. All uses changed.
39 Also, fix a local for similar reasons.
40 Remove unused locals. Remove locals to avoid shadowing.
41 (fn_rsvg_handle_free): Remove; unused.
42 (svg_load, svg_load_image): Fix pointer signedness problem.
43 (imagemagick_load_image): Don't use garbage pointer image_wand.
44
45 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
46
47 2011-06-10 Chong Yidong <cyd@stupidchicken.com>
48
49 * image.c (gif_load): Fix omitted cast error introduced by
50 2011-06-06 change.
51
52 2011-06-10 Martin Rudalics <rudalics@gmx.at>
53
54 * window.h (resize_proportionally, orig_total_lines)
55 (orig_top_line): Remove from window structure.
56 (set_window_height, set_window_width, change_window_heights)
57 (Fdelete_window): Remove prototypes.
58 (resize_frame_windows): Remove duplicate declaration.
59
60 2011-06-10 Eli Zaretskii <eliz@gnu.org>
61
62 * window.h (resize_frame_windows, resize_window_check)
63 (delete_deletable_window, resize_root_window)
64 (resize_frame_windows): Declare prototypes.
65
66 * window.c (resize_window_apply): Make definition be "static" to
67 match the prototype.
68
69 2011-06-10 Martin Rudalics <rudalics@gmx.at>
70
71 * window.c: Remove declarations of Qwindow_size_fixed,
72 window_min_size_1, window_min_size_2, window_min_size,
73 size_window, window_fixed_size_p, enlarge_window, delete_window.
74 Remove static from declaration of Qdelete_window, it's
75 temporarily needed by Fbury_buffer.
76 (replace_window): Don't assign orig_top_line and
77 orig_total_lines.
78 (Fdelete_window, delete_window): Remove. Window deletion is
79 handled by window.el.
80 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
81 Fdelete_window calls with calls to Qdelete_window.
82 (Fdelete_other_windows): Remove. Deleting other windows is
83 handled by window.el.
84 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
85 handled in window.el.
86 (window_min_size_2, window_min_size_1, window_min_size): Remove.
87 Window minimum sizes are handled in window.el.
88 (shrink_windows, size_window, set_window_height)
89 (set_window_width, change_window_heights, window_height)
90 (window_width, CURBEG, CURSIZE, enlarge_window)
91 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
92 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
93 handled in window.el.
94 (make_dummy_parent): Rename to make_parent_window and give it a
95 second argument horflag.
96 (make_window): Don't set resize_proportionally any more.
97 (Fsplit_window): Remove. Windows are split in window.el.
98 (save_restore_action, save_restore_orig_size)
99 (shrink_window_lowest_first, save_restore_orig_size): Remove.
100 Resize mini windows in window.el.
101 (grow_mini_window, shrink_mini_window): Implement by calling
102 Qresize_root_window_vertically, resize_window_check and
103 resize_window_apply.
104 (saved_window, Fset_window_configuration, save_window_save): Do
105 not handle orig_top_line, orig_total_lines, and
106 resize_proportionally.
107 (window_min_height, window_min_width): Move to window.el.
108 (keys_of_window): Move bindings for delete-other-windows,
109 split-window, delete-window and enlarge-window to window.el.
110
111 * buffer.c: Temporarily extern Qdelete_window.
112 (Fbury_buffer): Temporarily call Qdelete_window instead of
113 Fdelete_window (Fbury_buffer will move to window.el soon).
114
115 * frame.c (set_menu_bar_lines_1): Remove code handling
116 orig_top_line and orig_total_lines.
117
118 * dispnew.c (adjust_frame_glyphs_initially): Don't use
119 set_window_height but set heights directly.
120 (change_frame_size_1): Use resize_frame_windows.
121
122 * xdisp.c (init_xdisp): Don't use set_window_height but set
123 heights directly.
124
125 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
126 resize_frame_windows instead of change_window_heights and run
127 run_window_configuration_change_hook.
128
129 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
130 instead of change_window_heights and run
131 run_window_configuration_change_hook.
132
133 2011-06-09 Martin Rudalics <rudalics@gmx.at>
134
135 * window.c (replace_window): Rename second argument REPLACEMENT to
136 NEW. New third argument SETFLAG. Rewrite.
137 (delete_window, make_dummy_parent): Call replace_window with
138 third argument 1.
139 (window_list_1): Move down in code.
140 (run_window_configuration_change_hook): Move set_buffer part
141 before select_frame_norecord part in order to unwind correctly.
142 Rename count1 to count.
143 (recombine_windows, delete_deletable_window, resize_root_window)
144 (Fdelete_other_windows_internal)
145 (Frun_window_configuration_change_hook, make_parent_window)
146 (resize_window_check, resize_window_apply, Fresize_window_apply)
147 (resize_frame_windows, Fsplit_window_internal)
148 (Fdelete_window_internal, Fresize_mini_window_internal): New
149 functions.
150 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
151
152 2011-06-08 Martin Rudalics <rudalics@gmx.at>
153
154 * window.h (window): Add some new members to window structure -
155 normal_lines, normal_cols, new_total, new_normal, clone_number,
156 splits, nest, prev_buffers, next_buffers.
157 (WINDOW_TOTAL_SIZE): Move here from window.c.
158 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
159
160 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
161 Remove.
162 (make_dummy_parent): Set new members of windows structure.
163 (make_window): Move down in code. Handle new members of window
164 structure.
165 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
166 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
167 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
168 (Fset_window_prev_buffers, Fwindow_next_buffers)
169 (Fset_window_next_buffers, Fset_window_clone_number): New
170 functions.
171 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
172 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
173 Doc-string fixes.
174 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
175 Argument WINDOW can be now internal window too.
176 (Fwindow_use_time): Move up in code.
177 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
178 Rewrite doc-string.
179 (Fset_window_configuration, saved_window)
180 (Fcurrent_window_configuration, save_window_save): Handle new
181 members of window structure.
182 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
183 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
184 (syms_of_window): New Lisp objects Qrecord_window_buffer,
185 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
186 Qget_mru_window, Qresize_root_window,
187 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
188 Qauto_buffer_name; staticpro them.
189
190 2011-06-07 Martin Rudalics <rudalics@gmx.at>
191
192 * window.c (Fwindow_total_size, Fwindow_left_column)
193 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
194 (Fwindow_list_1): New functions.
195 (window_box_text_cols): Replace with window_body_cols.
196 (Fwindow_width, Fscroll_left, Fscroll_right): Use
197 window_body_cols instead of window_box_text_cols.
198 (delete_window, Fset_window_configuration): Call
199 delete_all_subwindows with window as argument.
200 (delete_all_subwindows): Take a window as argument and not a
201 structure. Rewrite.
202 (window_loop): Remove handling of GET_LRU_WINDOW and
203 GET_LARGEST_WINDOW.
204 (Fget_lru_window, Fget_largest_window): Move to window.el.
205
206 * window.h: Extern window_body_cols instead of
207 window_box_text_cols. delete_all_subwindows now takes a
208 Lisp_Object as argument.
209
210 * indent.c (compute_motion, Fcompute_motion): Use
211 window_body_cols instead of window_box_text_cols.
212
213 * frame.c (delete_frame): Call delete_all_subwindows with root
214 window as argument.
215
216 2011-06-07 Daniel Colascione <dan.colascione@gmail.com>
217
218 * fns.c (Fputhash): Document return value.
219
220 2011-06-06 Chong Yidong <cyd@stupidchicken.com>
221
222 * image.c (gif_load): Implement gif89a spec "no disposal" method.
223
224 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
225
226 Cons<->int and similar integer overflow fixes (Bug#8794).
227
228 Check for overflow when converting integer to cons and back.
229 * charset.c (Fdefine_charset_internal, Fdecode_char):
230 Use cons_to_unsigned to catch overflow.
231 (Fencode_char): Use INTEGER_TO_CONS.
232 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
233 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
234 * data.c (long_to_cons, cons_to_long): Remove.
235 (cons_to_unsigned, cons_to_signed): New functions.
236 These signal an error for invalid or out-of-range values.
237 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
238 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
239 * font.c (Ffont_variation_glyphs):
240 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
241 * lisp.h: Include <intprops.h>.
242 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
243 (cons_to_signed, cons_to_unsigned): New decls.
244 (long_to_cons, cons_to_long): Remove decls.
245 * undo.c (record_first_change): Use INTEGER_TO_CONS.
246 (Fprimitive_undo): Use CONS_TO_INTEGER.
247 * xfns.c (Fx_window_property): Likewise.
248 * xselect.c: Include <limits.h>.
249 (x_own_selection, selection_data_to_lisp_data):
250 Use INTEGER_TO_CONS.
251 (x_handle_selection_request, x_handle_selection_clear)
252 (x_get_foreign_selection, Fx_disown_selection_internal)
253 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
254 (lisp_data_to_selection_data): Use cons_to_unsigned.
255 (x_fill_property_data): Use cons_to_signed.
256 Report values out of range.
257
258 Check for buffer and string overflow more precisely.
259 * buffer.h (BUF_BYTES_MAX): New macro.
260 * lisp.h (STRING_BYTES_MAX): New macro.
261 * alloc.c (Fmake_string):
262 * character.c (string_escape_byte8):
263 * coding.c (coding_alloc_by_realloc):
264 * doprnt.c (doprnt):
265 * editfns.c (Fformat):
266 * eval.c (verror):
267 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
268 since they may not be the same number.
269 * editfns.c (Finsert_char):
270 * fileio.c (Finsert_file_contents):
271 Likewise for BUF_BYTES_MAX.
272
273 * image.c: Use ptrdiff_t, not int, for sizes.
274 (slurp_file): Switch from int to ptrdiff_t.
275 All uses changed.
276 (slurp_file): Check that file size fits in both size_t (for
277 malloc) and ptrdiff_t (for sanity and safety).
278
279 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
280 if b->modtime has its maximal value.
281
282 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
283
284 Don't assume time_t can fit into int.
285 * buffer.h (struct buffer.modtime): Now time_t, not int.
286 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
287 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
288
289 Minor fixes for signed vs unsigned integers.
290 * character.h (MAYBE_UNIFY_CHAR):
291 * charset.c (maybe_unify_char):
292 * keyboard.c (read_char, reorder_modifiers):
293 XINT -> XFASTINT, since the integer must be nonnegative.
294 * ftfont.c (ftfont_spec_pattern):
295 * keymap.c (access_keymap, silly_event_symbol_error):
296 XUINT -> XFASTINT, since the integer must be nonnegative.
297 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
298 since it makes no difference and we prefer signed.
299 * keyboard.c (record_char): Use XUINT when all the neighbors do.
300 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
301 nonnegative.
302
303 2011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
304
305 * window.h (Fwindow_frame): Declare.
306
307 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
308
309 * alloc.c: Simplify handling of large-request failures (Bug#8800).
310 (SPARE_MEMORY): Always define.
311 (LARGE_REQUEST): Remove.
312 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
313
314 2011-06-06 Martin Rudalics <rudalics@gmx.at>
315
316 * lisp.h: Move EXFUNS for Fframe_root_window,
317 Fframe_first_window and Fset_frame_selected_window to window.h.
318
319 * window.h: Move EXFUNS for Fframe_root_window,
320 Fframe_first_window and Fset_frame_selected_window here from
321 lisp.h.
322
323 * frame.c (Fwindow_frame, Fframe_first_window)
324 (Fframe_root_window, Fframe_selected_window)
325 (Fset_frame_selected_window): Move to window.c.
326 (Factive_minibuffer_window): Move to minibuf.c.
327 (Fother_visible_frames_p): New function.
328
329 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
330
331 * window.c (decode_window, decode_any_window): Move up in code.
332 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
333 (inhibit_frame_unsplittable): Remove unused variable.
334 (Fwindow_buffer): Move up and rewrite doc-string.
335 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
336 (Fwindow_prev): New functions.
337 (Fwindow_frame): Move here from frame.c. Accept any window as
338 argument.
339 (Fframe_root_window, Fframe_first_window)
340 (Fframe_selected_window): Move here from frame.c. Accept frame
341 or arbitrary window as argument. Update doc-strings.
342 (Fminibuffer_window): Move up in code.
343 (Fwindow_minibuffer_p): Move up in code and simplify.
344 (Fset_frame_selected_window): Move here from frame.c.
345 Marginal rewrite.
346 (Fselected_window, select_window, Fselect_window): Move up in
347 code. Minor doc-string fixes.
348
349 2011-06-06 Paul Eggert <eggert@cs.ucla.edu>
350
351 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
352 Do not assume that spare memory exists; that assumption is valid
353 only if SYSTEM_MALLOC.
354 (LARGE_REQUEST): New macro, so that the issue of large requests
355 is separated from the issue of spare memory.
356
357 2011-06-05 Andreas Schwab <schwab@linux-m68k.org>
358
359 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
360 format. (Bug#8806)
361
362 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
363
364 * xfns.c (x_set_scroll_bar_default_width): Move declarations
365 before statements.
366
367 2011-06-05 Jan Djärv <jan.h.d@swipnet.se>
368
369 * gtkutil.c (xg_get_default_scrollbar_width): New function.
370
371 * gtkutil.h: Declare xg_get_default_scrollbar_width.
372
373 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
374 min width by calling x_set_scroll_bar_default_width (Bug#8505).
375
376 2011-06-05 Juanma Barranquero <lekktu@gmail.com>
377
378 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
379
380 2011-06-04 Chong Yidong <cyd@stupidchicken.com>
381
382 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
383 (x_clipboard_manager_save): Add return value.
384 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
385 New error handlers.
386 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
387 Obey Vx_select_enable_clipboard_manager. Catch errors in
388 x_clipboard_manager_save (Bug#8779).
389 (Vx_select_enable_clipboard_manager): New variable.
390 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
391
392 2011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
393
394 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
395
396 2011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
397
398 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
399 in the current matrix if keep_current_p is non-zero.
400
401 2011-06-04 Eli Zaretskii <eliz@gnu.org>
402
403 * bidi.c (bidi_level_of_next_char): Fix last change.
404
405 2011-06-03 Eli Zaretskii <eliz@gnu.org>
406
407 Support bidi reordering of text covered by display properties.
408
409 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
410 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
411 (bidi_cache_search, bidi_cache_iterator_state)
412 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
413 (bidi_level_of_next_char, bidi_move_to_visually_next):
414 Support character positions inside a run of characters covered by a
415 display string.
416 (bidi_paragraph_init, bidi_resolve_explicit_1)
417 (bidi_level_of_next_char): Call bidi_fetch_char and
418 bidi_fetch_char_advance instead of FETCH_CHAR and
419 FETCH_CHAR_ADVANCE.
420 (bidi_init_it): Initialize new members.
421 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
422 definitions.
423 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
424 instead of using explicit *_CHAR codes.
425 (bidi_resolve_explicit, bidi_resolve_weak):
426 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
427 bidirectional text is supported only in multibyte buffers.
428 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
429 it to initialize the frame_window_p member of struct bidi_it.
430 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
431 (bidi_resolve_explicit, bidi_resolve_weak)
432 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
433 bidi_it->nchars is non-positive.
434 (bidi_level_of_next_char): Don't try to lookup the cache for the
435 next/previous character if nothing is cached there yet, or if we
436 were just reseat()'ed to a new position.
437
438 * xdisp.c (set_cursor_from_row): Set start and stop points
439 according to the row's direction when priming the loop that looks
440 for the glyph on which to display cursor.
441 (single_display_spec_intangible_p): Function deleted.
442 (display_prop_intangible_p): Reimplement to call
443 handle_display_spec instead of single_display_spec_intangible_p.
444 Accept 3 additional arguments needed by handle_display_spec.
445 This fixes incorrect cursor motion across display property with complex
446 values: lists, `(when COND...)' forms, etc.
447 (single_display_spec_string_p): Support property values that are
448 lists with the argument STRING its top-level element.
449 (display_prop_string_p): Fix the condition for processing a
450 property that is a list to be consistent with handle_display_spec.
451 (handle_display_spec): New function, refactored from the
452 last portion of handle_display_prop.
453 (compute_display_string_pos): Accept additional argument
454 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
455 value of a `display' property is a "replacing spec".
456 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
457 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
458 the display property, but just return a value indicating whether
459 the display property will replace the characters it covers.
460 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
461 frame_window_p members of struct bidi_it.
462 (compute_display_string_pos, compute_display_string_end):
463 New functions.
464 (push_it): Accept second argument POSITION, where pop_it should
465 jump to continue iteration.
466 (reseat_1): Initialize bidi_it.disp_pos.
467
468 * keyboard.c (adjust_point_for_property): Adjust the call to
469 display_prop_intangible_p to its new signature.
470
471 * dispextern.h (struct bidi_it): New member frame_window_p.
472 (bidi_init_it): Update prototypes.
473 (display_prop_intangible_p): Update prototype.
474 (compute_display_string_pos, compute_display_string_end):
475 Declare prototypes.
476 (struct bidi_it): New members nchars and disp_pos. ch_len is now
477 EMACS_INT.
478
479 2011-06-02 Paul Eggert <eggert@cs.ucla.edu>
480
481 Malloc failure behavior now depends on size of allocation.
482 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
483 * lisp.h: Change signatures accordingly.
484 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
485 All callers changed. (Bug#8762)
486
487 * gnutls.c: Use Emacs's memory allocators.
488 Without this change, the gnutls library would invoke malloc etc.
489 directly, which causes problems on non-SYNC_INPUT hosts, and which
490 runs afoul of improving memory_full behavior. (Bug#8761)
491 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
492 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
493 xfree instead of the default malloc, realloc, free.
494 (Fgnutls_boot): No need to check for memory allocation failure,
495 since xmalloc does that for us.
496
497 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
498 * category.c (hash_get_category_set):
499 * ccl.c (ccl_driver):
500 * charset.c (Fdefine_charset_internal):
501 * charset.h (struct charset.hash_index):
502 * composite.c (get_composition_id, gstring_lookup_cache)
503 (composition_gstring_put_cache):
504 * composite.h (struct composition.hash_index):
505 * dispextern.h (struct image.hash):
506 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
507 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
508 (hashfn_equal, hashfn_user_defined, make_hash_table)
509 (maybe_resize_hash_table, hash_lookup, hash_put)
510 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
511 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
512 (Fsxhash, Fgethash, Fputhash, Fmaphash):
513 * image.c (make_image, search_image_cache, lookup_image)
514 (xpm_put_color_table_h):
515 * lisp.h (struct Lisp_Hash_Table):
516 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
517 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
518 for hashes and hash indexes, instead of 'unsigned' and 'int'.
519 * alloc.c (allocate_vectorlike):
520 Check for overflow in vector size calculations.
521 * ccl.c (ccl_driver):
522 Check for overflow when converting EMACS_INT to int.
523 * fns.c, image.c: Remove unnecessary static decls that would otherwise
524 need to be updated by these changes.
525 * fns.c (make_hash_table, maybe_resize_hash_table):
526 Check for integer overflow with large hash tables.
527 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
528 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
529 (SXHASH_REDUCE): New macro.
530 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
531 Use it instead of discarding useful hash info with large hash values.
532 (sxhash_float): New function.
533 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
534 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
535 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
536 Rewrite to use FIXNUM_BITS, as this simplifies things.
537 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
538 Adjust signatures to match updated version of code.
539 (consing_since_gc): Now EMACS_INT, since a single hash table can
540 use more than INT_MAX bytes.
541
542 2011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
543
544 Make it possible to build with GCC-4.6+ -O2 -flto.
545
546 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
547
548 2011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
549
550 * minibuf.c (get_minibuffer, read_minibuf_unwind):
551 Call minibuffer-inactive-mode.
552
553 2011-05-31 Juanma Barranquero <lekktu@gmail.com>
554
555 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
556 Update dependencies.
557
558 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
559
560 * data.c (init_data): Remove code for UTS, this system is not
561 supported anymore.
562
563 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
564
565 Don't force ./temacs to start in terminal mode.
566
567 * frame.c (make_initial_frame): Initialize faces in all cases, not
568 only when CANNOT_DUMP is defined.
569 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
570
571 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
572
573 * dispnew.c (add_window_display_history): Use const for the string
574 pointer. Remove declaration, not needed.
575
576 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
577
578 Use 'inline', not 'INLINE'.
579 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
580 * alloc.c, fontset.c (INLINE): Remove.
581 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
582 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
583 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
584 * gmalloc.c (register_heapinfo): Use inline unconditionally.
585 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
586
587 2011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
588
589 Make it possible to run ./temacs.
590
591 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
592 syms_of_callproc does the same thing. Remove test for
593 "initialized", do it in the caller.
594 * emacs.c (main): Avoid calling set_initial_environment when dumping.
595
596 2011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
597
598 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
599 (read_minibuf): Use get_minibuffer.
600 (syms_of_minibuf): Use DEFSYM.
601 (Qmetadata): New var.
602 * data.c (Qbuffer): Don't make it static.
603 (syms_of_data): Use DEFSYM.
604
605 2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
606
607 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
608 (CCL_CODE_MIN): New macro.
609
610 2011-05-30 Paul Eggert <eggert@cs.ucla.edu>
611
612 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
613
614 * eval.c (Qdebug): Now static.
615 * lisp.h (Qdebug): Remove decl. This reverts a part of the
616 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
617 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
618
619 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
620
621 * image.c: Various fixes to ImageMagick code comments.
622 (Fimagemagick_types): Doc fix.
623
624 2011-05-29 Paul Eggert <eggert@cs.ucla.edu>
625
626 Minor fixes prompted by GCC 4.6.0 warnings.
627
628 * xselect.c (converted_selections, conversion_fail_tag): Now static.
629
630 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
631 (x_clipboard_manager_save_all): Move extern decl to ...
632 * xterm.h: ... here, so that it can be checked for consistency.
633
634 2011-05-29 Chong Yidong <cyd@stupidchicken.com>
635
636 * xselect.c (x_clipboard_manager_save_frame)
637 (x_clipboard_manager_save_all): New functions.
638 (Fx_clipboard_manager_save): Lisp function deleted.
639
640 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
641 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
642
643 * xterm.h: Update prototype.
644
645 2011-05-28 William Xu <william.xwl@gmail.com>
646
647 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
648 exiting (Bug#8239).
649
650 2011-05-28 Jim Meyering <meyering@redhat.com>
651
652 Avoid a sign-extension bug in crypto_hash_function.
653 * fns.c (to_uchar): Define.
654 (crypto_hash_function): Use it to convert some newly-signed
655 variables to unsigned, to avoid sign-extension bugs. For example,
656 without this change, (md5 "truc") would evaluate to
657 45723a2aff78ff4fff7fff1114760e62 rather than the expected
658 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
659 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
660
661 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
662
663 Integer overflow fixes.
664
665 * dbusbind.c: Serial number integer overflow fixes.
666 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
667 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
668 to hold a serial number that is too large for a fixnum.
669 (Fdbus_method_return_internal, Fdbus_method_error_internal):
670 Check for serial numbers out of range. Decode any serial number
671 that was so large that it became a float. (Bug#8722)
672
673 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
674 (Fdbus_call_method, Fdbus_call_method_asynchronously):
675 Use XFASTINT rather than XUINT when numbers are nonnegative.
676 (xd_append_arg, Fdbus_method_return_internal):
677 (Fdbus_method_error_internal): Likewise. Also, for unsigned
678 arguments, check that Lisp number is nonnegative, rather than
679 silently wrapping negative numbers around. (Bug#8722)
680 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
681 (Bug#8722)
682
683 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
684
685 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
686
687 ccl: add integer overflow checks
688 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
689 (IN_INT_RANGE): New macros.
690 (ccl_driver): Use them to check for integer overflow when
691 decoding a CCL program. Many of the new checks are whether XINT (x)
692 fits in int; it doesn't always, on 64-bit hosts. The new version
693 doesn't catch all possible integer overflows, but it's an
694 improvement. (Bug#8719)
695
696 * alloc.c (make_event_array): Use XINT, not XUINT.
697 There's no need for unsigned here.
698
699 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
700 This follows up to the 2011-05-06 change that substituted uintptr_t
701 for EMACS_INT. This case wasn't caught back then.
702
703 Rework Fformat to avoid integer overflow issues.
704 * editfns.c: Include <float.h> unconditionally, as it's everywhere
705 now (part of C89). Include <verify.h>.
706 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
707 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
708 (Fformat): Avoid the prepass trying to compute sizes; it was only
709 approximate and thus did not catch overflow reliably. Instead, walk
710 through the format just once, formatting and computing sizes as we go,
711 checking for integer overflow at every step, and allocating a larger
712 buffer as needed. Keep track separately whether the format is
713 multibyte. Keep only the most-recently calculated precision, rather
714 than them all. Record whether each argument has been converted to
715 string. Use EMACS_INT, not int, for byte and char and arg counts.
716 Support field widths and precisions larger than INT_MAX. Avoid
717 sprintf's undefined behavior with conversion specifications such as %#d
718 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
719 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
720 formatting out-of-range floating point numbers with int
721 formats. (Bug#8668)
722
723 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
724
725 * data.c: Avoid integer truncation in expressions involving floats.
726 * data.c: Include <intprops.h>.
727 (arith_driver): When there's an integer overflow in an expression
728 involving floating point, convert the integers to floating point
729 so that the resulting value does not suffer from catastrophic
730 integer truncation. For example, on a 64-bit host (* 4
731 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
732 Do not rely on undefined behavior after integer overflow.
733
734 merge count_size_as_multibyte, parse_str_to_multibyte
735 * character.c, character.h (count_size_as_multibyte):
736 Rename from parse_str_to_multibyte; all uses changed.
737 Check for integer overflow.
738 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
739 since it's now a duplicate of the other. This is more of
740 a character than a buffer op, so better that it's in character.c.
741 * fns.c, print.c: Adjust to above changes.
742
743 2011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
744
745 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
746
747 2011-05-27 Paul Eggert <eggert@cs.ucla.edu>
748
749 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
750 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
751 (x_clipboard_manager_save): Now static.
752 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
753
754 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
755 (crypto_hash_function): Now static.
756 Fix pointer signedness problems. Avoid unnecessary initializations.
757
758 2011-05-27 Chong Yidong <cyd@stupidchicken.com>
759
760 * termhooks.h (Vselection_alist): Make it terminal-local.
761
762 * terminal.c (create_terminal): Initialize it.
763
764 * xselect.c: Support for clipboard managers.
765 (Vselection_alist): Move to termhooks.h as terminal-local var.
766 (LOCAL_SELECTION): New macro.
767 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
768 (symbol_to_x_atom): Remove gratuitous arg.
769 (x_handle_selection_request, lisp_data_to_selection_data)
770 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
771 (x_own_selection, x_get_local_selection, x_convert_selection):
772 New arg, specifying work frame. Use terminal-local Vselection_alist.
773 (some_frame_on_display): Delete unused function.
774 (Fx_own_selection_internal, Fx_get_selection_internal)
775 (Fx_disown_selection_internal, Fx_selection_owner_p)
776 (Fx_selection_exists_p): New optional frame arg.
777 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
778 (x_handle_selection_clear): Don't treat other terminals with the
779 same keyboard specially. Use the terminal-local Vselection_alist.
780 (x_clear_frame_selections): Use Frun_hook_with_args.
781
782 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
783
784 * xterm.h: Add support for those atoms.
785
786 2011-05-26 Chong Yidong <cyd@stupidchicken.com>
787
788 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
789 (converted_selections, conversion_fail_tag): New global variables.
790 (x_selection_request_lisp_error): Free the above.
791 (x_get_local_selection): Remove unnecessary code.
792 (x_reply_selection_request): Args changed; handle arbitrary array
793 of converted selections stored in converted_selections.
794 Separate the XChangeProperty and SelectionNotify steps.
795 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
796 (x_convert_selection): New function.
797 (x_handle_selection_event): Simplify.
798 (x_get_foreign_selection): Don't ignore incoming requests while
799 waiting for an answer; this will fail when we implement
800 SAVE_TARGETS, and seems unnecessary anyway.
801 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
802 (Vx_sent_selection_functions): Doc fix.
803
804 2011-05-26 Leo Liu <sdl.web@gmail.com>
805
806 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
807
808 2011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
809
810 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
811
812 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
813 for fringe update if it has periodic bitmap.
814 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
815 and fringe_bitmap_periodic_p.
816
817 * fringe.c (get_fringe_bitmap_data): New function.
818 (draw_fringe_bitmap_1, update_window_fringes): Use it.
819 (update_window_fringes): Record periodicity of fringe bitmap in glyph
820 row. Mark glyph row for fringe update if periodicity changed.
821
822 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
823 for fringe update unless it has periodic bitmap.
824
825 2011-05-25 Kenichi Handa <handa@m17n.org>
826
827 * xdisp.c (get_next_display_element): Set correct it->face_id for
828 a static composition.
829
830 2011-05-24 Leo Liu <sdl.web@gmail.com>
831
832 * deps.mk (fns.o):
833 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
834
835 * fns.c (crypto_hash_function, Fsha1): New function.
836 (Fmd5): Use crypto_hash_function.
837 (syms_of_fns): Add Ssha1.
838
839 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
840
841 * gnutls.c: Remove unused macros.
842 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
843 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
844 Remove macros that are defined and never used.
845 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
846
847 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
848
849 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
850 (Fx_get_selection_internal): Minor cleanup.
851 (Fx_own_selection_internal): Rename arguments for consistency with
852 select.el.
853
854 2011-05-22 Paul Eggert <eggert@cs.ucla.edu>
855
856 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
857
858 2011-05-22 Chong Yidong <cyd@stupidchicken.com>
859
860 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
861
862 2011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
863
864 * dispnew.c (scrolling_window): Don't exclude the case that the
865 last enabled row in the desired matrix touches the bottom boundary.
866
867 2011-05-21 Glenn Morris <rgm@gnu.org>
868
869 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
870 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
871 and add some more files.
872
873 2011-05-20 Eli Zaretskii <eliz@gnu.org>
874
875 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
876 report_file_error introduced by the change from 2011-05-07.
877
878 2011-05-20 Paul Eggert <eggert@cs.ucla.edu>
879
880 * systime.h (Time): Define only if emacs is defined.
881 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
882 where the include path doesn't have X11/X.h by default. See
883 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
884
885 2011-05-20 Kenichi Handa <handa@m17n.org>
886
887 * composite.c (find_automatic_composition): Fix previous change.
888
889 2011-05-20 Glenn Morris <rgm@gnu.org>
890
891 * lisp.mk: New file, split from Makefile.in.
892 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
893 (shortlisp): Remove.
894 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
895
896 2011-05-19 Glenn Morris <rgm@gnu.org>
897
898 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
899 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
900 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
901 (lisp): Set the order to that of loadup.el.
902 (shortlisp): Make it a copy of $lisp.
903 (SOME_MACHINE_LISP): Remove.
904 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
905 Use just $shortlisp, not $SOME_MACHINE_LISP too.
906
907 2011-05-18 Kenichi Handa <handa@m17n.org>
908
909 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
910 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
911 (find_automatic_composition): Mostly rewrite for efficiency.
912
913 2011-05-18 Juanma Barranquero <lekktu@gmail.com>
914
915 * makefile.w32-in: Update dependencies.
916
917 2011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
918
919 * menu.c: Include limits.h (fixes the MS-Windows build broken by
920 revision 104625).
921
922 2011-05-18 Paul Eggert <eggert@cs.ucla.edu>
923
924 Fix some integer overflow issues, such as string length overflow.
925
926 * insdel.c (count_size_as_multibyte): Check for string overflow.
927
928 * character.c (lisp_string_width): Check for string overflow.
929 Use EMACS_INT, not int, for string indexes and lengths; in
930 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
931 the resulting string length overflows an EMACS_INT; instead,
932 report a string overflow if no precision given. When checking for
933 precision exhaustion, use a check that cannot possibly have
934 integer overflow. (Bug#8675)
935 * character.h (lisp_string_width): Adjust to new signature.
936
937 * alloc.c (string_overflow): New function.
938 (Fmake_string): Use it. This doesn't change behavior, but saves
939 a few bytes and will simplify future changes.
940 * character.c (string_escape_byte8): Likewise.
941 * lisp.h (string_overflow): New decl.
942
943 Fixups, following up to the user-interface timestamp change.
944 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
945 for UI timestamps, instead of unsigned long.
946 * msdos.c (mouse_get_pos): Likewise.
947 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
948 * w32gui.h (Time): Define by including "systime.h" rather than by
949 declaring it ourselves. (Bug#8664)
950
951 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
952 * image.c (clear_image_cache): Likewise.
953
954 * term.c (term_mouse_position): Don't assume time_t wraparound.
955
956 Be more systematic about user-interface timestamps.
957 Before, the code sometimes used 'Time', sometimes 'unsigned long',
958 and sometimes 'EMACS_UINT', to represent these timestamps.
959 This change causes it to use 'Time' uniformly, as that's what X uses.
960 This makes the code easier to follow, and makes it easier to catch
961 integer overflow bugs such as Bug#8664.
962 * frame.c (Fmouse_position, Fmouse_pixel_position):
963 Use Time, not unsigned long, for user-interface timestamps.
964 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
965 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
966 * keyboard.h (last_event_timestamp): Likewise.
967 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
968 * menu.h (xmenu_show): Likewise.
969 * term.c (term_mouse_position): Likewise.
970 * termhooks.h (struct input_event.timestamp): Likewise.
971 (struct terminal.mouse_position_hook): Likewise.
972 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
973 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
974 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
975 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
976 what it was before.
977 * menu.h, termhooks.h: Include "systime.h", for Time.
978
979 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
980 Don't assume that the difference between two unsigned long values
981 can fit into an integer. At this point, we know button_down_time
982 <= event->timestamp, so the difference must be nonnegative, so
983 there's no need to cast the result if double-click-time is
984 nonnegative, as it should be; check that it's nonnegative, just in
985 case. This bug is triggered when events are more than 2**31 ms
986 apart (about 25 days). (Bug#8664)
987
988 * xselect.c (last_event_timestamp): Remove duplicate decl.
989 (x_own_selection): Remove needless cast to unsigned long.
990
991 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
992 that always fit in int. Use a sentinel instead of a counter, to
993 avoid a temp and to allay GCC's concerns about possible int overflow.
994 * frame.h (struct frame): Use int for menu_bar_items_used
995 instead of EMACS_INT, since it always fits in int.
996
997 * menu.c (grow_menu_items): Check for int overflow.
998
999 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1000
1001 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1002 Before, the code was not consistent. These values cannot exceed
1003 2**31 - 1 so there's no need to make them unsigned.
1004 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1005 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1006 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1007 as modifiers.
1008 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1009
1010 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1011 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1012 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1013 presumably because the widths might not match.
1014
1015 * window.c (size_window): Avoid needless test at loop start.
1016
1017 2011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1018
1019 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1020
1021 2011-05-12 Drew Adams <drew.adams@oracle.com>
1022
1023 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1024
1025 2011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1026
1027 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1028 `width' to `bar_area_x' and `bar_area_width', respectively.
1029 (x_scroll_run): Take account of fringe background extension.
1030
1031 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1032 Rename local vars `left' and `width' to `bar_area_x' and
1033 `bar_area_width', respectively.
1034 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1035 background extension.
1036
1037 2011-05-10 Jim Meyering <meyering@redhat.com>
1038
1039 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1040
1041 2011-05-10 Juanma Barranquero <lekktu@gmail.com>
1042
1043 * image.c (Finit_image_library): Return t for built-in image types,
1044 like pbm and xbm. (Bug#8640)
1045
1046 2011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1047
1048 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1049
1050 2011-05-07 Eli Zaretskii <eliz@gnu.org>
1051
1052 * w32console.c (Fset_screen_color): Doc fix.
1053 (Fget_screen_color): New function.
1054 (syms_of_ntterm): Defsubr it.
1055
1056 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1057 unlink the temporary file if Fcall_process didn't create it in the
1058 first place.
1059 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1060 child process will be redirected to a file specified with `:file'.
1061 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1062 cue to call_process_cleanup not to close that handle.
1063
1064 2011-05-07 Ben Key <bkey76@gmail.com>
1065
1066 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1067 one of two shell specific rules, either bootstrap-temacs-CMD or
1068 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1069 to the previous implementation of the bootstrap-temacs rule.
1070 The bootstrap-temacs-CMD rule is similar to the previous
1071 implementation of the bootstrap-temacs rule except that it
1072 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1073 variable.
1074
1075 These changes, along with some changes to nt/configure.bat,
1076 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1077 earlier fix to add support for --cflags and --ldflags options
1078 that include quotes so that it works whether make uses cmd or
1079 sh as the shell.
1080
1081 2011-05-06 Michael Albinus <michael.albinus@gmx.de>
1082
1083 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1084 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1085 is a constant.
1086 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1087 a string. Handle both cases.
1088 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1089 (Fdbus_register_method): Use Qinvalid_function.
1090
1091 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1092
1093 * makefile.w32-in: Update dependencies.
1094 (LISP_H): Add inttypes.h and stdin.h.
1095 (PROCESS_H): Add unistd.h.
1096
1097 2011-05-06 Eli Zaretskii <eliz@gnu.org>
1098
1099 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1100 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1101
1102 2011-05-06 Paul Eggert <eggert@cs.ucla.edu>
1103
1104 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1105
1106 * term.c (vfatal): Remove stray call to va_end.
1107 It's not needed and the C Standard doesn't allow it here anyway.
1108
1109 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1110 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1111
1112 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1113 bytes.
1114
1115 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1116
1117 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1118
1119 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1120
1121 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1122
1123 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1124
1125 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1126 * charset.c (Fdefine_charset_internal): Don't initialize
1127 charset.code_space[15]. The value was garbage, on hosts with
1128 32-bit int (Bug#8600).
1129
1130 * lread.c (read_integer): Be more consistent with string-to-number.
1131 Use string_to_number to do the actual conversion; this avoids
1132 rounding errors and fixes some other screwups. Without this fix,
1133 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1134 (digit_to_number): Move earlier, for benefit of read_integer.
1135 Return -1 if the digit is out of range for the base, -2 if it is
1136 not a digit in any supported base. (Bug#8602)
1137
1138 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1139
1140 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1141 to match comment at start of function. This also removes a
1142 GCC warning about overflow in a 32+64-bit port.
1143
1144 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1145
1146 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1147 Reported by Stefan Monnier in
1148 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
1149 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1150 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
1151
1152 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1153 (EMACS_UINTPTR): Likewise, with uintptr_t.
1154
1155 * lisp.h: Prefer 64-bit EMACS_INT if available.
1156 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1157 on 32-bit hosts that have 64-bit int, so that they can access
1158 large files.
1159 However, temporarily disable this change unless the temporary
1160 symbol WIDE_EMACS_INT is defined.
1161
1162 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1163
1164 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1165 This removes an assumption that EMACS_INT and long are the same
1166 width as pointers. The assumption is true for Emacs porting targets
1167 now, but we want to make other targets possible.
1168 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1169 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1170 In the rest of the code, change types of integers that hold casted
1171 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1172 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1173 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1174 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1175 No need to cast type when ORing.
1176 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1177 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1178 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1179 assume EMACS_INT is the same width as char *.
1180 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1181 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1182 Remove no-longer-needed casts.
1183 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1184 (xg_tool_bar_help_callback, xg_make_tool_item):
1185 Use EMACS_INTPTR to hold an integer
1186 that will be cast to void *; this can avoid a GCC warning
1187 if EMACS_INT is not the same width as void *.
1188 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1189 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1190 (current_message_1, set_message_1):
1191 Use a local to convert to proper width without a cast.
1192 * xmenu.c (dialog_selection_callback): Likewise.
1193
1194 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1195 Also, don't assume VALBITS / RAND_BITS is less than 5,
1196 and don't rely on undefined behavior when shifting a 1 left into
1197 the sign bit.
1198 * lisp.h (get_random): Change signature to match.
1199
1200 * lread.c (hash_string): Use size_t, not int, for hash computation.
1201 Normally we prefer signed values; but hashing is special, because
1202 it's better to use unsigned division on hash table sizes so that
1203 the remainder is nonnegative. Also, size_t is the natural width
1204 for hashing into memory. The previous code used 'int', which doesn't
1205 retain enough info to hash well into very large tables.
1206 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1207
1208 * dbusbind.c: Don't possibly lose pointer info when converting.
1209 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1210 Use XPNTR rather than XHASH, so that the high-order bits of
1211 the pointer aren't lost when converting through void *.
1212
1213 * eval.c (Fautoload): Don't double-shift a pointer.
1214
1215 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1216
1217 2011-05-06 Juanma Barranquero <lekktu@gmail.com>
1218
1219 * gnutls.c (DEF_GNUTLS_FN):
1220 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1221
1222 2011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1223
1224 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1225 marker. (Bug#8610)
1226
1227 2011-05-05 Eli Zaretskii <eliz@gnu.org>
1228
1229 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1230 New version that can reserve upto 2GB of heap space.
1231
1232 2011-05-05 Chong Yidong <cyd@stupidchicken.com>
1233
1234 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1235
1236 2011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1237
1238 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1239 `gnutls_certificate_set_x509_key_file'.
1240
1241 2011-05-05 Juanma Barranquero <lekktu@gmail.com>
1242
1243 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1244 Update dependencies.
1245
1246 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1247
1248 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1249 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1250 Remove unused parameter `fildes'.
1251 * process.c (read_process_output, send_process): Don't pass it.
1252
1253 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1254
1255 Fix previous change: the library cache is defined in w32.c.
1256 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1257 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1258
1259 2011-05-04 Juanma Barranquero <lekktu@gmail.com>
1260
1261 Implement dynamic loading of GnuTLS on Windows.
1262
1263 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1264 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1265 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1266 Declare.
1267
1268 * gnutls.c (Qgnutls_dll): Define.
1269 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1270 (gnutls_*): Declare function pointers.
1271 (init_gnutls_functions): New function to initialize function pointers.
1272 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1273 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1274 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1275 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1276 (emacs_gnutls_write, emacs_gnutls_read)
1277 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1278 (Fgnutls_available_p): New function.
1279 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1280 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1281 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1282
1283 * image.c: Include w32.h.
1284 (Vimage_type_cache): Delete.
1285 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1286 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1287 (w32_delayed_load): Move to w32.c.
1288
1289 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1290
1291 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1292 (w32_delayed_load): Move from image.c. When loading a library, record
1293 its filename in the :loaded-from property of the library id.
1294 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1295 Initialize and staticpro them.
1296 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1297
1298 * process.c: Include lisp.h before w32.h, not after.
1299 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1300 instead of gnutls_record_check_pending.
1301
1302 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1303
1304 2011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1305
1306 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1307 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1308 as passed in.
1309
1310 2011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1311
1312 * xterm.c (x_set_frame_alpha): Do not set property on anything
1313 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1314
1315 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1316
1317 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1318
1319 2011-05-02 Juanma Barranquero <lekktu@gmail.com>
1320
1321 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1322 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1323 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1324 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1325 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1326 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1327 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1328 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1329 (Qgnutls_bootprop_callbacks_verify): Make static.
1330
1331 2011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1332
1333 * callproc.c: Indentation fixup.
1334
1335 * sysdep.c (wait_for_termination_1): Make static.
1336 (wait_for_termination, interruptible_wait_for_termination):
1337 Move after wait_for_termination_1.
1338
1339 2011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1340
1341 * sysdep.c (interruptible_wait_for_termination): New function
1342 which is like wait_for_termination, but allows keyboard
1343 interruptions.
1344
1345 * callproc.c (Fcall_process): Add (:file "file") as an option for
1346 the STDOUT buffer.
1347 (Fcall_process_region): Ditto.
1348
1349 2011-04-30 Eli Zaretskii <eliz@gnu.org>
1350
1351 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1352 rather than `XVECTOR (FOO)->size'.
1353
1354 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1355 inttypes.h, as a gnulib replacement is used if it not available in
1356 system headers.
1357
1358 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1359
1360 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1361 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1362 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1363
1364 * coding.c (coding_alloc_by_realloc): Error out if destination
1365 will grow beyond MOST_POSITIVE_FIXNUM.
1366 (decode_coding_emacs_mule): Abort if there isn't enough place in
1367 charbuf for the composition carryover bytes. Reserve an extra
1368 space for up to 2 characters produced in a loop.
1369 (decode_coding_iso_2022): Abort if there isn't enough place in
1370 charbuf for the composition carryover bytes.
1371
1372 2011-04-21 Eli Zaretskii <eliz@gnu.org>
1373
1374 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1375 aborting when %lld or %lll format is passed.
1376 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1377 %llo or %llx format is passed. (Bug#8545)
1378
1379 * window.c (window_scroll_line_based): Use a marker instead of
1380 simple variables to record original value of point. (Bug#7952)
1381
1382 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1383 produced by %s or %c overflows available buffer space. (Bug#8545)
1384
1385 2011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1386
1387 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
1388 (SIZE_MAX): Move defn after all includes, as they might #define it.
1389
1390 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1391
1392 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1393
1394 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1395
1396 * keyboard.c (Qdelayed_warnings_hook): Define.
1397 (command_loop_1): Run `delayed-warnings-hook'
1398 if Vdelayed_warnings_list is non-nil.
1399 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1400 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1401
1402 2011-04-28 Eli Zaretskii <eliz@gnu.org>
1403
1404 * doprnt.c (doprnt): Don't return value smaller than the buffer
1405 size if the message was truncated. (Bug#8545).
1406
1407 2011-04-28 Juanma Barranquero <lekktu@gmail.com>
1408
1409 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1410 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1411
1412 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1413
1414 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1415
1416 2011-04-27 Juanma Barranquero <lekktu@gmail.com>
1417
1418 * makefile.w32-in: Update dependencies.
1419
1420 2011-04-27 Eli Zaretskii <eliz@gnu.org>
1421
1422 Improve `doprnt' and its usage. (Bug#8545)
1423 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1424 `format_end'. Remove support for %l as a conversion specifier.
1425 Don't use xrealloc. Improve diagnostics when the %l size modifier
1426 is used. Update the commentary.
1427
1428 * eval.c (verror): Simplify calculation of size_t.
1429
1430 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1431 messages.
1432
1433 2011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1434
1435 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1436 change.
1437
1438 2011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1439
1440 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1441 This makes this file independent of the recent pseudovector change.
1442
1443 2011-04-26 Paul Eggert <eggert@cs.ucla.edu>
1444
1445 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1446
1447 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
1448 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
1449 Remove unused local.
1450 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
1451
1452 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
1453 GCC 4.6.0 optimizes based on type-based alias analysis.
1454 For example, if b is of type struct buffer * and v of type struct
1455 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1456 != &v->size, and therefore "v->size = 1; b->size = 2; return
1457 v->size;" must therefore return 1. This assumption is incorrect
1458 for Emacs, since it type-puns struct Lisp_Vector * with many other
1459 types. To fix this problem, this patch adds a new type struct
1460 vectorlike_header that documents the constraints on layout of vectors
1461 and pseudovectors, and helps optimizing compilers not get fooled
1462 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1463 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
1464 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1465 the size member.
1466 (XSETPVECTYPE): Rewrite in terms of new macro.
1467 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1468 This is a bit clearer, and further avoids the possibility of
1469 undesirable aliasing.
1470 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
1471 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
1472 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1473 since Lisp_Subr is a special case (no "next" field).
1474 (ASIZE): Now uses header.size rather than size.
1475 All previous uses of XVECTOR (foo)->size replaced to use this macro,
1476 to avoid the hassle of writing XVECTOR (foo)->header.size.
1477 (struct vectorlike_header): New type.
1478 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1479 object, to help avoid aliasing.
1480 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1481 (SUBRP): Likewise, since Lisp_Subr is a special case.
1482 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1483 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1484 (struct Lisp_Hash_Table): Combine first two members into a single
1485 struct vectorlike_header member. All uses of "size" and "next" members
1486 changed to be "header.size" and "header.next".
1487 * buffer.h (struct buffer): Likewise.
1488 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1489 * frame.h (struct frame): Likewise.
1490 * process.h (struct Lisp_Process): Likewise.
1491 * termhooks.h (struct terminal): Likewise.
1492 * window.c (struct save_window_data, struct saved_window): Likewise.
1493 * window.h (struct window): Likewise.
1494 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1495 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1496 * buffer.c (init_buffer_once): Likewise.
1497 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1498 special case.
1499 * process.c (Fformat_network_address): Use local var for size,
1500 for brevity.
1501
1502 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1503
1504 Make the Lisp reader and string-to-float more consistent (Bug#8525)
1505 * data.c (atof): Remove decl; no longer used or needed.
1506 (digit_to_number): Move to lread.c.
1507 (Fstring_to_number): Use new string_to_number function, to be
1508 consistent with how the Lisp reader treats infinities and NaNs.
1509 Do not assume that floating-point numbers represent EMACS_INT
1510 without losing information; this is not true on most 64-bit hosts.
1511 Avoid double-rounding errors, by insisting on integers when
1512 parsing non-base-10 numbers, as the documentation specifies.
1513 * lisp.h (string_to_number): New decl, replacing ...
1514 (isfloat_string): Remove.
1515 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
1516 (read1): Do not accept +. and -. as integers; this
1517 appears to have been a coding error. Similarly, do not accept
1518 strings like +-1e0 as floating point numbers. Do not report
1519 overflow for integer overflows unless the base is not 10 which
1520 means we have no simple and reliable way to continue.
1521 Break out the floating-point parsing into a new
1522 function string_to_number, so that Fstring_to_number parses
1523 floating point numbers consistently with the Lisp reader.
1524 (digit_to_number): Move here from data.c. Make it static inline.
1525 (E_CHAR, EXP_INT): Remove, replacing with ...
1526 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1527 (string_to_number): New function, replacing isfloat_string.
1528 This function checks for valid syntax and produces the resulting
1529 Lisp float number too. Rework it so that string-to-number
1530 no longer mishandles examples like "1.0e+". Use strtoumax,
1531 so that overflow for non-base-10 numbers is reported only when
1532 there's no portable and simple way to convert to floating point.
1533
1534 * textprop.c (set_text_properties_1): Rewrite for clarity,
1535 and to avoid GCC warning about integer overflow.
1536
1537 * intervals.h (struct interval): Use EMACS_INT for members
1538 where EMACS_UINT might cause problems. See
1539 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
1540 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
1541 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
1542 All uses changed.
1543 (offset_intervals): Tell GCC not to worry about length overflow
1544 when negating a negative length.
1545
1546 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
1547 (overrun_check_free): Likewise.
1548
1549 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
1550 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
1551 word size.
1552
1553 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1554 (gnutls_make_error): Rename local to avoid shadowing.
1555 (gnutls_emacs_global_deinit): ifdef out; not used.
1556 (Fgnutls_boot): Use const for pointer to readonly storage.
1557 Comment out unused local. Fix pointer signedness problems.
1558
1559 * lread.c (openp): Don't stuff size_t into an 'int'.
1560 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
1561 about possible signed overflow.
1562
1563 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1564 (GDK_KEY_g): Don't define if already defined.
1565 (xg_prepare_tooltip): Avoid pointer signedness problem.
1566 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
1567
1568 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
1569 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
1570
1571 * xfns.c (Fx_window_property): Simplify a bit,
1572 to make a bit faster and to avoid GCC 4.6.0 warning.
1573 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
1574
1575 * fns.c (internal_equal): Don't assume size_t fits in int.
1576
1577 * alloc.c (compact_small_strings): Tighten assertion a little.
1578
1579 Replace pEd with more-general pI, and fix some printf arg casts.
1580 * lisp.h (pI): New macro, generalizing old pEd macro to other
1581 conversion specifiers. For example, use "...%"pI"d..." rather
1582 than "...%"pEd"...".
1583 (pEd): Remove. All uses replaced with similar uses of pI.
1584 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
1585 * alloc.c (check_pure_size): Don't overflow by converting size to int.
1586 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
1587 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
1588 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
1589 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
1590 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
1591 64-bit hosts.
1592 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
1593 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
1594 * print.c (safe_debug_print, print_object): Likewise.
1595 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
1596 to int.
1597 Use pI instead of if-then-else-abort. Use %p to avoid casts,
1598 avoiding the 0 flag, which is not portable.
1599 * process.c (Fmake_network_process): Use pI to avoid cast.
1600 * region-cache.c (pp_cache): Likewise.
1601 * xdisp.c (decode_mode_spec): Likewise.
1602 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
1603 behavior on 64-bit hosts with printf arg.
1604 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
1605 (x_stop_queuing_selection_requests): Likewise.
1606 (x_get_window_property): Don't truncate byte count to an 'int'
1607 when tracing.
1608
1609 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
1610 here, since it parses constructs like leading '-' and spaces,
1611 which are not wanted; and it overflows with large numbers.
1612 Instead, simply match F[0-9]+, which is what is wanted anyway.
1613
1614 * alloc.c: Remove unportable assumptions about struct layout.
1615 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
1616 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
1617 (allocate_vectorlike, make_pure_vector): Use the new macros,
1618 plus offsetof, to remove unportable assumptions about struct layout.
1619 These assumptions hold on all porting targets that I know of, but
1620 they are not guaranteed, they're easy to remove, and removing them
1621 makes further changes easier.
1622
1623 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
1624 This doesn't fix a bug but makes the code clearer.
1625 (string_overrun_cookie): Now const. Use initializers that
1626 don't formally overflow signed char, to avoid warnings.
1627 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
1628 can cause Emacs to crash when string overrun checking is enabled.
1629 (allocate_buffer): Don't assume sizeof (struct buffer) is a
1630 multiple of sizeof (EMACS_INT); it need not be, if
1631 alignof(EMACS_INT) < sizeof (EMACS_INT).
1632 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
1633
1634 2011-04-26 Juanma Barranquero <lekktu@gmail.com>
1635
1636 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1637
1638 2011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1639
1640 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
1641 supposed to be handshaking. (Bug#8556)
1642 Reported by Paul Eggert <eggert@cs.ucla.edu>.
1643
1644 2011-04-26 Daniel Colascione <dan.colascione@gmail.com>
1645
1646 * lisp.h (Qdebug): List symbol.
1647 * eval.c (Qdebug): Restore global linkage.
1648 * keyboard.c (debug-on-event): New variable.
1649 (handle_user_signal): Break into debugger when debug-on-event
1650 matches the current signal symbol.
1651
1652 2011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
1653
1654 * alloc.c (check_sblock, check_string_bytes)
1655 (check_string_free_list): Convert to standard C.
1656
1657 2011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
1658
1659 * w32.c (emacs_gnutls_push): Fix typo.
1660
1661 2011-04-25 Eli Zaretskii <eliz@gnu.org>
1662
1663 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
1664 "cast to pointer from integer of different size".
1665
1666 Improve doprnt and its use in verror. (Bug#8545)
1667 * doprnt.c (doprnt): Document the set of format control sequences
1668 supported by the function. Use SAFE_ALLOCA instead of always
1669 using `alloca'.
1670
1671 * eval.c (verror): Don't limit the buffer size at size_max-1, that
1672 is one byte too soon. Don't use xrealloc; instead xfree and
1673 xmalloc anew.
1674
1675 2011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
1676
1677 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
1678 callbacks stage.
1679
1680 * gnutls.c: Renamed global_initialized to
1681 gnutls_global_initialized. Added internals for the
1682 :verify-hostname-error, :verify-error, and :verify-flags
1683 parameters of `gnutls-boot' and documented those parameters in the
1684 docstring. Start callback support.
1685 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
1686 unless a fatal error occured. Call gnutls_alert_send_appropriate
1687 on error. Return error code.
1688 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
1689 (emacs_gnutls_read): Likewise.
1690 (Fgnutls_boot): Return handshake error code.
1691 (emacs_gnutls_handle_error): New function.
1692 (wsaerror_to_errno): Likewise.
1693
1694 * w32.h (emacs_gnutls_pull): Add prototype.
1695 (emacs_gnutls_push): Likewise.
1696
1697 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
1698 (emacs_gnutls_push): Likewise.
1699
1700 2011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
1701
1702 * process.c (wait_reading_process_output): Check if GnuTLS
1703 buffered some data internally if no FDs are set for TLS
1704 connections.
1705
1706 * makefile.w32-in (OBJ2): Add gnutls.$(O).
1707 (LIBS): Link to USER_LIBS.
1708 ($(BLD)/gnutls.$(0)): New target.
1709
1710 2011-04-24 Eli Zaretskii <eliz@gnu.org>
1711
1712 * xdisp.c (handle_single_display_spec): Rename the
1713 display_replaced_before_p argument into display_replaced_p, to
1714 make it consistent with the commentary. Fix typos in the
1715 commentary.
1716
1717 * textprop.c (syms_of_textprop): Remove dead code.
1718 (copy_text_properties): Delete obsolete commentary about an
1719 interface that was deleted long ago. Fix typos in the description
1720 of arguments.
1721
1722 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
1723 to changes in oldXMenu/XMenu.h from 2011-04-16.
1724 <menu_help_message, prev_menu_help_message>: Constify.
1725 (IT_menu_make_room): menu->help_text is now `const char **';
1726 adjust.
1727
1728 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
1729 to changes in oldXMenu/XMenu.h from 2011-04-16.
1730 (struct XMenu): Declare `help_text' `const char **'.
1731
1732 * xfaces.c <Qunspecified>: Make extern again.
1733
1734 * syntax.c: Include sys/types.h before including regex.h, as
1735 required by Posix.
1736
1737 * doc.c (get_doc_string): Improve the format passed to `error'.
1738
1739 * doprnt.c (doprnt): Improve commentary.
1740
1741 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
1742
1743 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
1744 them with etags.
1745
1746 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
1747 changes in globals.h immediately force recompilation.
1748 (TAGS): Depend on $(CURDIR)/m/intel386.h and
1749 $(CURDIR)/s/ms-w32.h.
1750 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
1751
1752 * character.c (Fchar_direction): Function deleted.
1753 (syms_of_character): Don't defsubr it.
1754 <char-direction-table>: Deleted.
1755
1756 2011-04-23 Eli Zaretskii <eliz@gnu.org>
1757
1758 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
1759 * doprnt.c: Include limits.h.
1760 (SIZE_MAX): New macro.
1761 (doprnt): Return a size_t value. 2nd arg is now size_t.
1762 Many local variables are now size_t instead of int or unsigned.
1763 Improve overflow protection. Support `l' modifier for integer
1764 conversions. Support %l conversion. Don't assume an EMACS_INT
1765 argument for integer conversions and for %c.
1766
1767 * lisp.h (doprnt): Restore prototype.
1768
1769 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
1770 $(SRC)/character.h.
1771
1772 * Makefile.in (base_obj): Add back doprnt.o.
1773
1774 * deps.mk (doprnt.o): Add back prerequisites.
1775 (callint.o): Depend on character.h.
1776
1777 * eval.c (internal_lisp_condition_case): Include the handler
1778 representation in the error message.
1779 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1780 when breaking from the loop.
1781
1782 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1783
1784 * callint.c (Fcall_interactively): When displaying error message
1785 about invalid control letter, pass the character's codepoint, not
1786 a pointer to its multibyte form. Improve display of the character
1787 in octal and display also its hex code.
1788
1789 * character.c (char_string): Use %x to display the (unsigned)
1790 codepoint of an invalid character, to avoid displaying a bogus
1791 negative value.
1792
1793 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1794 `error', not SYMBOL_NAME itself.
1795
1796 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1797 character arguments to `error'.
1798
1799 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1800 to `error' in error message about FINAL_CHAR argument. Make sure
1801 FINAL_CHAR is a character, and use %c when it is passed as
1802 argument to `error'.
1803
1804 2011-04-23 Eli Zaretskii <eliz@gnu.org>
1805
1806 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1807
1808 * w32.c: Include <time.h>.
1809 (sys_localtime): New function.
1810
1811 2011-04-23 Chong Yidong <cyd@stupidchicken.com>
1812
1813 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1814
1815 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
1816
1817 2011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
1818
1819 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1820 zombies (Bug#8467).
1821
1822 2011-04-19 Eli Zaretskii <eliz@gnu.org>
1823
1824 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1825 gl_state.e_property when gl_state.object is Qt.
1826
1827 * insdel.c (make_gap_larger): Remove limitation of buffer size
1828 to <= INT_MAX.
1829
1830 2011-04-18 Chong Yidong <cyd@stupidchicken.com>
1831
1832 * xdisp.c (lookup_glyphless_char_display)
1833 (produce_glyphless_glyph): Handle cons cell entry in
1834 glyphless-char-display.
1835 (Vglyphless_char_display): Document it.
1836
1837 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1838 glyphless-char-display.
1839
1840 2011-04-17 Chong Yidong <cyd@stupidchicken.com>
1841
1842 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
1843
1844 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1845
1846 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
1847 definition for no-X builds.
1848
1849 2011-04-16 Paul Eggert <eggert@cs.ucla.edu>
1850
1851 Static checks with GCC 4.6.0 and non-default toolkits.
1852
1853 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1854
1855 * process.c (keyboard_bit_set): Define only if SIGIO.
1856 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
1857 (send_process): Repair possible setjmp clobbering.
1858
1859 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
1860
1861 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1862
1863 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
1864
1865 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
1866 Define only if needed.
1867
1868 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
1869 by pacifying GCC about it. Maybe it's time to retire it?
1870 * xfaces.c (USG, __TIMEVAL__): Likewise.
1871
1872 * dispextern.h (struct redisplay_interface): Rename param
1873 to avoid shadowing.
1874 * termhooks.h (struct terminal): Likewise.
1875 * xterm.c (xembed_send_message): Likewise.
1876
1877 * insdel.c (make_gap_smaller): Define only if
1878 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
1879
1880 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
1881 it.
1882
1883 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
1884 so that we aren't warned about unused symbols.
1885
1886 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
1887
1888 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
1889
1890 * xfns.c (x_real_positions): Mark locals as initialized.
1891
1892 * xmenu.c (xmenu_show): Don't use uninitialized vars.
1893
1894 * xterm.c: Fix problems found by static analysis with other toolkits.
1895 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
1896 (x_dispatch_event): Declare static if USE_GTK, and
1897 define if USE_GTK || USE_X_TOOLKIT.
1898 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
1899 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
1900 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
1901 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
1902
1903 * xmenu.c (menu_help_callback): Pointer type fixes.
1904 Use const pointers when pointing at readonly data. Avoid pointer
1905 signedness clashes.
1906 (FALSE): Remove unused macro.
1907 (update_frame_menubar): Remove unused decl.
1908
1909 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
1910
1911 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
1912 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
1913 (single_menu_item): Rename local to avoid shadowing.
1914
1915 * keyboard.c (make_lispy_event): Remove unused local var.
1916
1917 * frame.c, frame.h (x_get_resource_string): Bring this back, but
1918 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
1919
1920 * bitmaps: Change bitmaps from unsigned char back to the X11
1921 compatible char. Avoid the old compiler warnings about
1922 out-of-range initializers by using, for example, '\xab' rather
1923 than 0xab.
1924
1925 * xgselect.c (xgselect_initialize): Check vs interface
1926 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
1927
1928 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
1929
1930 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
1931 to read-only memory.
1932
1933 * fns.c (vector): Remove; this old hack is no longer needed.
1934
1935 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
1936 Remove unused var.
1937 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
1938
1939 * xrdb.c (x_load_resources): Omit unused local.
1940
1941 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
1942 (x_window): Rename locals to avoid shadowing.
1943 (USG): Use the kludged USG macro, to pacify gcc.
1944
1945 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
1946 (x_term_init): Remove local to avoid shadowing.
1947
1948 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
1949
1950 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
1951 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
1952
1953 2011-04-16 Eli Zaretskii <eliz@gnu.org>
1954
1955 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
1956
1957 Fix regex.c, syntax.c and friends for buffers > 2GB.
1958 * syntax.h (struct gl_state_s): Declare character position members
1959 EMACS_INT.
1960
1961 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
1962
1963 * textprop.c (verify_interval_modification, interval_of):
1964 Declare arguments EMACS_INT.
1965
1966 * intervals.c (adjust_intervals_for_insertion): Declare arguments
1967 EMACS_INT.
1968
1969 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
1970
1971 * indent.c (Fvertical_motion): Local variable it_start is now
1972 EMACS_INT.
1973
1974 * regex.c (re_match, re_match_2, re_match_2_internal)
1975 (bcmp_translate, regcomp, regexec, print_double_string)
1976 (group_in_compile_stack, re_search, re_search_2, regex_compile)
1977 (re_compile_pattern, re_exec): Declare arguments and local
1978 variables `size_t' and `ssize_t' and return values `regoff_t', as
1979 appropriate.
1980 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
1981 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
1982 <compile_stack_type>: `size' and `avail' are now `size_t'.
1983
1984 * regex.h <regoff_t>: Use ssize_t, not int.
1985 (re_search, re_search_2, re_match, re_match_2): Arguments that
1986 specify buffer/string position and length are now ssize_t and
1987 size_t. Return type is regoff_t.
1988
1989 2011-04-16 Ben Key <bkey76@gmail.com>
1990
1991 * nsfont.m: Fixed bugs in ns_get_family and
1992 ns_descriptor_to_entity that were caused by using free to
1993 deallocate memory blocks that were allocated by xmalloc (via
1994 xstrdup). This caused Emacs to crash when compiled with
1995 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
1996 --enable-checking=xmallocoverrun). xfree is now used to
1997 deallocate these memory blocks.
1998
1999 2011-04-15 Paul Eggert <eggert@cs.ucla.edu>
2000
2001 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2002
2003 emacs_write: Accept and return EMACS_INT for sizes.
2004 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2005 et seq.
2006 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2007 Accept and return EMACS_INT.
2008 (emacs_gnutls_write): Return the number of bytes written on
2009 partial writes.
2010 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
2011 (emacs_read, emacs_write): Remove check for negative size, as the
2012 Emacs source code has been audited now.
2013 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2014 (emacs_read, emacs_write): Use it.
2015 * process.c (send_process): Adjust to the new signatures of
2016 emacs_write and emacs_gnutls_write. Do not attempt to store
2017 a byte offset into an 'int'; it might overflow.
2018 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
2019
2020 * sound.c: Don't assume sizes fit in 'int'.
2021 (struct sound_device.period_size, alsa_period_size):
2022 Return EMACS_INT, not int.
2023 (struct sound_device.write, vox_write, alsa_write):
2024 Accept EMACS_INT, not int.
2025 (wav_play, au_play): Use EMACS_INT to store sizes and to
2026 record read return values.
2027
2028 2011-04-15 Ben Key <bkey76@gmail.com>
2029
2030 * keyboard.c (Qundefined): Don't declare static since it is used
2031 in nsfns.m.
2032 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2033 static since they are used in nsfont.m.
2034
2035 2011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2036
2037 * process.c (Qprocessp): Don't declare static.
2038 * lisp.h (Qprocessp): Declare again.
2039
2040 2011-04-15 Juanma Barranquero <lekktu@gmail.com>
2041
2042 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2043
2044 2011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2045
2046 Improve C-level modularity by making more things 'static'.
2047
2048 Don't publish debugger-only interfaces to other modules.
2049 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2050 (verify_bytepos, count_markers): Move decls to the only modules
2051 that need them.
2052 * region-cache.h (pp_cache): Likewise.
2053 * window.h (check_all_windows): Likewise.
2054 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2055
2056 * sysdep.c (croak): Now static, if
2057 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2058 * syssignal.h (croak): Declare only if not static.
2059
2060 * alloc.c (refill_memory_reserve): Now static if
2061 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2062 * lisp.h (refill_memory_reserve): Declare only if not static.
2063
2064 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2065 Define only if USE_LUCID.
2066
2067 * xrdb.c (x_customization_string, x_rm_string): Now static.
2068
2069 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2070 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2071
2072 * xdisp.c (draw_row_with_mouse_face): Now static.
2073 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2074
2075 * window.h (check_all_windows): Mark externally visible.
2076
2077 * window.c (window_deletion_count): Now static.
2078
2079 * undo.c: Make symbols static if they're not exported.
2080 (last_undo_buffer, last_boundary_position, pending_boundary):
2081 Now static.
2082
2083 * textprop.c (interval_insert_behind_hooks): Now static.
2084 (interval_insert_in_front_hooks): Likewise.
2085
2086 * term.c: Make symbols static if they're not exported.
2087 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2088 (max_frame_lines, tty_set_terminal_modes):
2089 (tty_reset_terminal_modes, tty_turn_off_highlight):
2090 (get_tty_terminal): Now static.
2091 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2092 * termhooks.h (term_mouse_moveto): Do not declare if
2093 HAVE_WINDOW_SYSTEM.
2094 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2095 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2096
2097 * sysdep.c: Make symbols static if they're not exported.
2098 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2099 Now static.
2100 (sigprocmask_set, full_mask): Remove; unused.
2101 (wait_debugging): Mark as visible.
2102 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2103 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2104
2105 * syntax.c (syntax_temp): Define only if !__GNUC__.
2106
2107 * sound.c (current_sound_device, current_sound): Now static.
2108
2109 * search.c (searchbufs, searchbuf_head): Now static.
2110
2111 * scroll.c (scroll_cost): Remove; unused.
2112 * dispextern.h (scroll_cost): Remove decl.
2113
2114 * region-cache.h (pp_cache): Mark as externally visible.
2115
2116 * process.c: Make symbols static if they're not exported.
2117 (process_tick, update_tick, create_process, chan_process):
2118 (Vprocess_alist, proc_buffered_char, datagram_access):
2119 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2120 (deactivate_process): Mark defn as static, as well as decl.
2121 * lisp.h (create_process): Remove decl.
2122 * process.h (chan_process, Vprocess_alist): Remove decls.
2123
2124 * print.c: Make symbols static if they're not exported.
2125 (print_depth, new_backquote_output, being_printed, print_buffer):
2126 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2127 (print_interval, print_number_index, initial_stderr_stream):
2128 Now static.
2129 * lisp.h (Fprinc): Remove decl.
2130 (debug_output_compilation_hack): Mark as externally visible.
2131
2132 * sysdep.c (croak): Move decl from here to syssignal.h.
2133 * syssignal.h (croak): Put it here, so the API can be checked when
2134 'croak' is called from dissociate_if_controlling_tty.
2135
2136 * minibuf.c: Make symbols static if they're not exported.
2137 (minibuf_save_list, choose_minibuf_frame): Now static.
2138 * lisp.h (choose_minibuf_frame): Remove decl.
2139
2140 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2141
2142 * lread.c: Make symbols static if they're not exported.
2143 (read_objects, initial_obarray, oblookup_last_bucket_number):
2144 Now static.
2145 (make_symbol): Remove; unused.
2146 * lisp.h (initial_obarray, make_symbol): Remove decls.
2147
2148 * keyboard.c: Make symbols static if they're not exported.
2149 (single_kboard, recent_keys_index, total_keys, recent_keys):
2150 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2151 (this_single_command_key_start, echoing, last_auto_save):
2152 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2153 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2154 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2155 (Vlispy_mouse_stem, double_click_count):
2156 Now static.
2157 (force_auto_save_soon): Define only if SIGDANGER.
2158 (ignore_mouse_drag_p): Now static if
2159 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2160 (print_help): Remove; unused.
2161 (stop_character, last_timer_event): Mark as externally visible.
2162 * keyboard.h (ignore_mouse_drag_p): Declare only if
2163 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2164 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2165 * lisp.h (echoing): Remove decl.
2166 (force_auto_save_soon): Declare only if SIGDANGER.
2167 * xdisp.c (redisplay_window): Simplify code, to make it more
2168 obvious that ignore_mouse_drag_p is not accessed if !defined
2169 USE_GTK && !defined HAVE_NS.
2170
2171 * intervals.c: Make symbols static if they're not exported.
2172 (merge_properties_sticky, merge_interval_right, delete_interval):
2173 Now static.
2174 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2175
2176 * insdel.c: Make symbols static if they're not exported.
2177 However, leave prepare_to_modify_buffer alone. It's never
2178 called from outside this function, but that appears to be a bug.
2179 (combine_after_change_list, combine_after_change_buffer):
2180 (adjust_after_replace, signal_before_change): Now static.
2181 (adjust_after_replace_noundo): Remove; unused.
2182 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
2183 (signal_before_change): Remove decls.
2184
2185 * indent.c (val_compute_motion, val_vmotion): Now static.
2186
2187 * image.c: Make symbols static if they're not exported.
2188 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2189 if USE_GTK.
2190 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2191 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2192
2193 * fringe.c (standard_bitmaps): Now static.
2194 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2195
2196 * frame.c: Make symbols static if they're not exported.
2197 (x_report_frame_params, make_terminal_frame): Now static.
2198 (get_frame_param): Now static, unless HAVE_NS.
2199 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2200 (x_get_resource_string): Remove; not used.
2201 * frame.h (make_terminal_frame, x_report_frame_params):
2202 (x_get_resource_string); Remove decls.
2203 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2204 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2205
2206 * font.c, fontset.c: Make symbols static if they're not exported.
2207 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2208 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2209 * font.c (font_close_object): Now static.
2210 * font.h (font_close_object): Remove.
2211 * fontset.c (FONTSET_OBJLIST): Remove.
2212 (free_realized_fontset) #if-0 the body, which does nothing.
2213 (face_suitable_for_char_p): #if-0, as it's never called.
2214 * fontset.h (face_suitable_for_char_p): Remove decl.
2215 * xfaces.c (face_at_string_position):
2216 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
2217 since 0 is always ASCII.
2218
2219 * fns.c (weak_hash_tables): Now static.
2220
2221 * fileio.c: Make symbols static if they're not exported.
2222 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2223 (Vwrite_region_annotation_buffers): Now static.
2224
2225 * eval.c: Make symbols static if they're not exported.
2226 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2227 * lisp.h (backtrace_list): Remove decl.
2228
2229 * emacs.c: Make symbols static if they're not exported.
2230 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2231 (fatal_error_code, fatal_error_signal_hook, standard_args):
2232 Now static.
2233 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2234 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2235 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2236 * lisp.h (fatal_error_signal_hook): Remove decl.
2237 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2238
2239 * editfns.c: Move a (normally-unused) function to its only use.
2240 * editfns.c, lisp.h (get_operating_system_release): Remove.
2241 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2242 worth the hassle of breaking this out.
2243
2244 * xterm.c: Make symbols static if they're not exported.
2245 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2246 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2247 (x_destroy_window, x_delete_display):
2248 Now static.
2249 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2250 (x_mouse_leave): Remove; unused.
2251 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2252 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2253 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2254 Remove decls.
2255 (x_mouse_leave): Declare only if WINDOWSNT.
2256 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2257 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2258 USE_X_TOOLKIT.
2259
2260 * ftxfont.c: Make symbols static if they're not exported.
2261 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2262 HAVE_FREETYPE.
2263 * font.h (ftxfont_driver): Likewise.
2264
2265 * xfns.c: Make symbols static if they're not exported.
2266 (x_last_font_name, x_display_info_for_name):
2267 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2268 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2269 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2270 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2271 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2272 (last_show_tip_args): Now static.
2273 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2274 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2275 (x_screen_planes): Remove; unused.
2276 * dispextern.h (x_screen_planes): Remove decl.
2277
2278 * dispnew.c: Make symbols static if they're not exported.
2279 * dispextern.h (redraw_garbaged_frames, scrolling):
2280 (increment_row_positions): Remove.
2281 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2282 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2283 Now static.
2284 (redraw_garbaged_frames): Remove; unused.
2285
2286 * xfaces.c: Make symbols static if they're not exported.
2287 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2288 Remove decls.
2289 * xterm.h (defined_color): Remove decls.
2290 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2291 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2292 (menu_face_changed_default, defined_color, free_realized_face):
2293 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2294 (ascii_face_of_lisp_face): Remove; unused.
2295
2296 * xdisp.c: Make symbols static if they're not exported.
2297 * dispextern.h (scratch_glyph_row, window_box_edges):
2298 (glyph_to_pixel_coords, set_cursor_from_row):
2299 (get_next_display_element, set_iterator_to_next):
2300 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2301 (show_mouse_face): Remove decls
2302 * frame.h (message_buf_print): Likewise.
2303 * lisp.h (pop_message, set_message, check_point_in_composition):
2304 Likewise.
2305 * xterm.h (set_vertical_scroll_bar): Likewise.
2306 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2307 (message_buf_print, scratch_glyph_row, displayed_buffer):
2308 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2309 (get_next_display_element, show_mouse_face, window_box_edges):
2310 (frame_to_window_pixel_xy, check_point_in_composition):
2311 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2312 (glyph_to_pixel_coords): Remove; unused.
2313
2314 * dired.c (file_name_completion): Now static.
2315
2316 * dbusbind.c (xd_in_read_queued_messages): Now static.
2317
2318 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2319 * data.c (circular_list_error): Remove.
2320
2321 * commands.h (last_point_position, last_point_position_buffer):
2322 (last_point_position_window): Remove decls.
2323 * keyboard.c: Make these variables static.
2324
2325 * coding.h (coding, code_convert_region, encode_coding_gap):
2326 Remove decls.
2327 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2328 (iso_code_class, detect_coding, code_convert_region): Now static.
2329 (encode_coding_gap): Remove; unused.
2330
2331 * chartab.c (chartab_chars, chartab_bits): Now static.
2332
2333 * charset.h (charset_iso_8859_1): Remove decl.
2334 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2335 Now static.
2336
2337 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2338 * ccl.c (Vccl_program_table): Now static.
2339 (check_ccl_update): Remove; unused.
2340
2341 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2342 * category.h: ... from here.
2343 * category.c (check_category_table, set_category_set): Now static.
2344
2345 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2346 * lisp.h: Remove these decls.
2347
2348 * buffer.c (buffer_count): Remove unused var.
2349
2350 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2351 so that it's not optimized away.
2352 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2353 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2354 exported only to the debugger.
2355
2356 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
2357 * atimer.h (run_all_atimers): Remove; not exported.
2358
2359 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2360 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2361 was inaccessible from Lisp.
2362 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2363 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2364
2365 alloc.c: Import and export fewer symbols, and remove unused items.
2366 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2367 is defined.
2368 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2369 it's not optimized away by whole-program optimization.
2370 (message_enable_multibyte, free_misc): Remove.
2371 (catchlist, handlerlist, mark_backtrace):
2372 Declare only if BYTE_MARK_STACK.
2373 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2374 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2375 (message_enable_multibyte): Remove decl.
2376 (free_misc, interval_free_list, float_block, float_block_index):
2377 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2378 (cons_free_list, last_marked_index):
2379 Now static.
2380 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2381 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2382 (mark_backtrace): Define only if BYTE_MARK_STACK.
2383 * xdisp.c (message_enable_multibyte): Now static.
2384
2385 Declare Lisp_Object Q* variables to be 'static' if not exported.
2386 This makes it easier for human readers (and static analyzers)
2387 to see whether these variables are used from other modules.
2388 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2389 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2390 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2391 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2392 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2393 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2394 * xmenu.c, xselect.c:
2395 Declare Q* vars static if they are not used in other modules.
2396 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2397 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2398 Remove decls of unexported vars.
2399 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2400
2401 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2402
2403 Make Emacs functions such as Fatom 'static' by default.
2404 This makes it easier for human readers (and static analyzers)
2405 to see whether these functions can be called from other modules.
2406 DEFUN now defines a static function. To make the function external
2407 so that it can be used in other C modules, use the new macro DEFUE.
2408 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2409 (Finit_image_library):
2410 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2411 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2412 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2413 Remove decls, since these functions are now static.
2414 (Funintern, Fget_internal_run_time): New decls, since these functions
2415 were already external.
2416
2417 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2418 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2419 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2420 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2421 * keyboard.c, keymap.c, lread.c:
2422 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2423 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2424 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2425 Mark functions with DEFUE instead of DEFUN,
2426 if they are used in other modules.
2427 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2428 decls for now-static functions.
2429 * buffer.h (Fdelete_overlay): Remove decl.
2430 * callproc.c (Fgetenv_internal): Mark as internal.
2431 * composite.c (Fremove_list_of_text_properties): Remove decl.
2432 (Fcomposition_get_gstring): New forward static decl.
2433 * composite.h (Fcomposite_get_gstring): Remove decl.
2434 * dired.c (Ffile_attributes): New forward static decl.
2435 * doc.c (Fdocumntation_property): New forward static decl.
2436 * eval.c (Ffetch_bytecode): New forward static decl.
2437 (Funintern): Remove extern decl; now in .h file where it belongs.
2438 * fileio.c (Fmake_symbolic_link): New forward static decl.
2439 * image.c (Finit_image_library): New forward static decl.
2440 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2441 * intervals.h (Fprevious_property_change):
2442 (Fremove_list_of_text_properties): Remove decls.
2443 * keyboard.c (Fthis_command_keys): Remove decl.
2444 (Fcommand_execute): New forward static decl.
2445 * keymap.c (Flookup_key): New forward static decl.
2446 (Fcopy_keymap): Now static.
2447 * keymap.h (Flookup_key): Remove decl.
2448 * process.c (Fget_process): New forward static decl.
2449 (Fprocess_datagram_address): Mark as internal.
2450 * syntax.c (Fsyntax_table_p): New forward static decl.
2451 (skip_chars): Remove duplicate decl.
2452 * textprop.c (Fprevious_property_change): New forward static decl.
2453 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2454 Now internal.
2455 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2456 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2457
2458 * editfns.c (Fformat): Remove unreachable code.
2459
2460 2011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2461
2462 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2463 change. (Bug#8496)
2464
2465 2011-04-13 Eli Zaretskii <eliz@gnu.org>
2466
2467 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2468 when at ZV. (Bug#8487)
2469
2470 2011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2471
2472 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2473 (Bug#8437)
2474 * keyboard.c (parse_tool_bar_item): Likewise.
2475 * sound.c (sound_cleanup, alsa_close): Likewise.
2476 * termcap.c (tgetent): Likewise.
2477 * xfns.c (x_default_font_parameter): Likewise.
2478 * xsettings.c (read_and_apply_settings): Likewise.
2479
2480 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2481 (overrun_check_free): Protoize.
2482
2483 2011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2484
2485 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2486 since callers should never pass a negative size.
2487 Change the signature to match that of plain 'read' and 'write'; see
2488 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2489 * lisp.h: Update prototypes of emacs_write and emacs_read.
2490
2491 2011-04-11 Eli Zaretskii <eliz@gnu.org>
2492
2493 * xdisp.c (redisplay_window): Don't try to determine the character
2494 position of the scroll margin if the window start point w->startp
2495 is outside the buffer's accessible region. (Bug#8468)
2496
2497 2011-04-10 Eli Zaretskii <eliz@gnu.org>
2498
2499 Fix write-region and its subroutines for buffers > 2GB.
2500 * fileio.c (a_write, e_write): Modify declaration of arguments and
2501 local variables to support buffers larger than 2GB.
2502 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2503
2504 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2505 argument, local variables, and return value.
2506
2507 * lisp.h: Update prototypes of emacs_write and emacs_read.
2508
2509 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2510
2511 2011-04-10 Paul Eggert <eggert@cs.ucla.edu>
2512
2513 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2514
2515 Fix more problems found by GCC 4.6.0's static checks.
2516
2517 * xdisp.c (vmessage): Use a better test for character truncation.
2518
2519 * charset.c (load_charset_map): <, not <=, for optimization,
2520 and to avoid potential problems with integer overflow.
2521 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
2522 * casetab.c (set_identity, shuffle): Likewise.
2523 * editfns.c (Fformat): Likewise.
2524 * syntax.c (skip_chars): Likewise.
2525
2526 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2527 This also lets GCC 4.6.0 generate slightly better loop code.
2528
2529 * callint.c (Fcall_interactively): <, not <=, for optimization.
2530 (Fcall_interactively): Count the number of arguments produced,
2531 not the number of arguments given. This is simpler and lets GCC
2532 4.6.0 generate slightly better code.
2533
2534 * ftfont.c: Distingish more carefully between FcChar8 and char.
2535 The previous code passed unsigned char * to a functions like
2536 strlen and xstrcasecmp that expect char *, which does not
2537 conform to the C standard.
2538 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
2539 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
2540 char * when the C standard requires it.
2541
2542 * keyboard.c (read_char): Remove unused var.
2543
2544 * eval.c: Port to Windows vsnprintf (Bug#8435).
2545 Include <limits.h>.
2546 (SIZE_MAX): Define if the headers do not.
2547 (verror): Do not give up if vsnprintf returns a negative count.
2548 Instead, grow the buffer. This ports to Windows vsnprintf, which
2549 does not conform to C99. Problem reported by Eli Zaretskii.
2550 Also, simplify the allocation scheme, by avoiding the need for
2551 calling realloc, and removing the ALLOCATED variable.
2552
2553 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
2554
2555 Remove invocations of doprnt, as Emacs now uses vsnprintf.
2556 But keep the doprint source code for now, as we might revamp it
2557 and use it again (Bug#8435).
2558 * lisp.h (doprnt): Remove.
2559 * Makefile.in (base_obj): Remove doprnt.o.
2560 * deps.mk (doprnt.o): Remove.
2561
2562 error: Print 32- and 64-bit integers portably (Bug#8435).
2563 Without this change, on typical 64-bit hosts error ("...%d...", N)
2564 was used to print both 32- and 64-bit integers N, which relied on
2565 undefined behavior.
2566 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
2567 New macro.
2568 * lisp.h (error, verror): Mark as printf-like functions.
2569 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
2570 Report overflow in size calculations when allocating printf buffer.
2571 Do not truncate output string at its first null byte.
2572 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
2573 Truncate the output at a character boundary, since vsnprintf does not
2574 do that.
2575 * charset.c (check_iso_charset_parameter): Convert internal
2576 character to string before calling 'error', since %c now has the
2577 printf meaning.
2578 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
2579 overflow when computing char to be passed to 'error'. Do not
2580 pass Lisp_Object to 'error'; pass the integer instead.
2581 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
2582 formatted with plain %d.
2583
2584 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
2585
2586 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
2587
2588 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
2589
2590 * xterm.c (x_catch_errors): Remove duplicate declaration.
2591
2592 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
2593
2594 * xdisp.c, lisp.h (message_nolog): Remove; unused.
2595
2596 2011-04-10 Jim Meyering <meyering@redhat.com>
2597
2598 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
2599 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
2600 return ssize_t not "int", and use size_t as the buffer length.
2601 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
2602 * gnutls.h: Update declarations.
2603 * process.c (read_process_output): Use ssize_t, to match.
2604 (send_process): Likewise.
2605
2606 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
2607
2608 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
2609
2610 2011-04-09 Chong Yidong <cyd@stupidchicken.com>
2611
2612 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
2613 Use unsigned char, to match FcChar8 type definition.
2614
2615 * xterm.c (handle_one_xevent):
2616 * xmenu.c (create_and_show_popup_menu):
2617 * xselect.c (x_decline_selection_request)
2618 (x_reply_selection_request): Avoid type-punned deref of X events.
2619
2620 2011-04-09 Eli Zaretskii <eliz@gnu.org>
2621
2622 Fix some uses of `int' instead of EMACS_INT.
2623 * search.c (string_match_1, fast_string_match)
2624 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
2625 (scan_buffer, find_next_newline_no_quit)
2626 (find_before_next_newline, search_command, Freplace_match)
2627 (Fmatch_data): Make some `int' variables be EMACS_INT.
2628
2629 * xdisp.c (display_count_lines): 3rd argument and return value now
2630 EMACS_INT. All callers changed.
2631 (pint2hrstr): Last argument is now EMACS_INT.
2632
2633 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2634 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2635 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2636 (decode_coding_utf_16, decode_coding_emacs_mule)
2637 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2638 (decode_coding_ccl, decode_coding_charset)
2639 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
2640 (decode_coding_iso_2022, decode_coding_emacs_mule)
2641 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
2642 <char_offset, last_offset>: Declare EMACS_INT.
2643 (encode_coding_utf_8, encode_coding_utf_16)
2644 (encode_coding_emacs_mule, encode_invocation_designation)
2645 (encode_designation_at_bol, encode_coding_iso_2022)
2646 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
2647 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
2648 Declare EMACS_INT.
2649 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
2650 (encode_invocation_designation): Last argument P_NCHARS is now
2651 EMACS_INT.
2652 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
2653 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
2654
2655 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
2656 All users changed.
2657
2658 * ccl.c (Fccl_execute_on_string): Declare some variables
2659 EMACS_INT.
2660
2661 2011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
2662
2663 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
2664
2665 2011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
2666
2667 * process.c (Fformat_network_address): Doc fix.
2668
2669 2011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
2670
2671 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
2672
2673 2011-04-08 Chong Yidong <cyd@stupidchicken.com>
2674
2675 * keyboard.c (read_char): Call Lisp function help-form-show,
2676 instead of using internal_with_output_to_temp_buffer.
2677 (Qhelp_form_show): New var.
2678 (syms_of_keyboard): Use DEFSYM macro.
2679
2680 * print.c (internal_with_output_to_temp_buffer): Function deleted.
2681
2682 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
2683
2684 2011-04-06 Chong Yidong <cyd@stupidchicken.com>
2685
2686 * process.c (Flist_processes): Remove to Lisp.
2687 (list_processes_1): Delete.
2688
2689 2011-04-06 Eli Zaretskii <eliz@gnu.org>
2690
2691 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
2692
2693 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
2694
2695 2011-04-06 Paul Eggert <eggert@cs.ucla.edu>
2696
2697 Fix more problems found by GCC 4.6.0's static checks.
2698
2699 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
2700
2701 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
2702
2703 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
2704
2705 * xdisp.c (vmessage): Mark as a printf-like function.
2706
2707 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
2708
2709 * sound.c (sound_warning): Don't crash if arg contains a printf format.
2710
2711 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
2712 printf-like functions.
2713 (tiff_load): Add casts to remove these marks before passing them
2714 to system-supplied API.
2715
2716 * eval.c (Fsignal): Remove excess argument to 'fatal'.
2717
2718 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
2719 This avoids several warnings with gcc -Wstrict-overflow.
2720 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
2721 directly, rather than having caller test rule sign. This avoids
2722 some unnecessary tests.
2723 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
2724 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
2725 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
2726
2727 * xfont.c (xfont_text_extents): Remove var that was set but not used.
2728 (xfont_open): Avoid unnecessary tests.
2729
2730 * composite.c (composition_gstring_put_cache): Use unsigned integer.
2731
2732 * composite.h, composite.c (composition_gstring_put_cache):
2733 Use EMACS_INT, not int, for length.
2734
2735 * composite.h (COMPOSITION_DECODE_REFS): New macro,
2736 breaking out part of COMPOSITION_DECODE_RULE.
2737 (COMPOSITION_DECODE_RULE): Use it.
2738 * composite.c (get_composition_id): Remove unused local vars,
2739 by using the new macro.
2740
2741 * textprop.c (set_text_properties_1): Change while to do-while,
2742 since the condition is always true at first.
2743
2744 * intervals.c (graft_intervals_into_buffer): Mark var as used.
2745 (interval_deletion_adjustment): Return unsigned value.
2746 All uses changed.
2747
2748 * process.c (list_processes_1, create_pty, read_process_output):
2749 (exec_sentinel): Remove vars that were set but not used.
2750 (create_pty): Remove unnecessary "volatile"s.
2751 (Fnetwork_interface_info): Avoid possibility of int overflow.
2752 (read_process_output): Do adaptive read buffering even if carryover.
2753 (read_process_output): Simplify nbytes computation if buffered.
2754
2755 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
2756
2757 * syntax.c (scan_words): Remove var that was set but not used.
2758 (update_syntax_table): Use unsigned instead of int.
2759
2760 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
2761 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
2762 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
2763
2764 * print.c (print_error_message): Avoid int overflow.
2765
2766 * font.c (font_list_entities): Redo for clarity,
2767 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
2768
2769 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
2770 (font_score): Avoid potential overflow in diff calculation.
2771
2772 * fns.c (substring_both): Remove var that is set but not used.
2773 (sxhash): Redo loop for clarity and to avoid wraparound warning.
2774
2775 * eval.c (funcall_lambda): Rename local to avoid shadowing.
2776
2777 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2778 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2779 can always succeed if overflow has undefined behavior.
2780
2781 * search.c (boyer_moore, wordify): Remove vars set but not used.
2782 (wordify): Omit three unnecessary tests.
2783
2784 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2785 All callers changed. This avoids the need for an unused var.
2786
2787 * casefiddle.c (casify_region): Remove var that is set but not used.
2788
2789 * dired.c (file_name_completion): Remove var that is set but not used.
2790
2791 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2792
2793 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
2794 (Finsert_file_contents): Remove unnecessary code checking fd.
2795
2796 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2797 Check for integer overflow on size calculations.
2798
2799 * buffer.c (Fprevious_overlay_change): Remove var that is set
2800 but not used.
2801
2802 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2803 Remove vars that are set but not used.
2804 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
2805 (timer_check_2): Mark vars as initialized.
2806
2807 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2808
2809 * image.c (lookup_image): Remove var that is set but not used.
2810 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
2811
2812 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2813 that are set but not used.
2814
2815 * xfns.c (make_invisible_cursor): Don't return garbage
2816 if XCreateBitmapFromData fails (Bug#8410).
2817
2818 * xselect.c (x_get_local_selection, x_handle_property_notify):
2819 Remove vars that are set but not used.
2820
2821 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
2822 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
2823
2824 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2825 Remove var that is set but not used.
2826 (scroll_bar_windows_size): Now size_t, not int.
2827 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2828 Check for overflow.
2829
2830 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2831 (map_tty_color) [!defined MSDOS]: Likewise.
2832
2833 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2834
2835 * coding.c: Remove vars that are set but not used.
2836 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2837 All callers changed.
2838 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2839 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
2840 (decode_coding_charset): Remove vars that are set but not used.
2841
2842 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
2843 that is set but not used.
2844
2845 * print.c (print_object): Remove var that is set but not used.
2846
2847 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
2848 The gnulib version avoids calling malloc in the usual case,
2849 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2850 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
2851 * filelock.c (current_lock_owner): Likewise.
2852 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2853 * sysdep.c: Include allocator.h, careadlinkat.h.
2854 (emacs_no_realloc_allocator): New static constant.
2855 (emacs_readlink): New function.
2856 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
2857 ../lib/careadlinkat.h.
2858
2859 2011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
2860
2861 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2862 first non-nil return value).
2863
2864 2011-04-03 Jan Djärv <jan.h.d@swipnet.se>
2865
2866 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
2867 if not defined (Bug#8403).
2868
2869 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
2870
2871 * xdisp.c (display_count_lines): Remove parameter `start',
2872 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2873 (get_char_face_and_encoding): Remove parameter `multibyte_p',
2874 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2875 (fill_stretch_glyph_string): Remove parameters `row' and `area',
2876 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
2877 and thereabouts. All callers changed.
2878 (get_per_char_metric): Remove parameter `f', unused since
2879 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2880
2881 2011-04-02 Jim Meyering <meyering@redhat.com>
2882
2883 do not dereference NULL upon failed strdup
2884 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
2885 (ns_get_family): Likewise.
2886
2887 2011-04-02 Juanma Barranquero <lekktu@gmail.com>
2888
2889 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
2890
2891 2011-04-02 Jan Djärv <jan.h.d@swipnet.se>
2892
2893 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
2894 later (Bug#8403).
2895
2896 2011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
2897
2898 Add lexical binding.
2899
2900 * window.c (Ftemp_output_buffer_show): New fun.
2901 (Fsave_window_excursion):
2902 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
2903
2904 * lread.c (lisp_file_lexically_bound_p): New function.
2905 (Fload): Bind Qlexical_binding.
2906 (readevalloop): Remove `evalfun' arg.
2907 Bind Qinternal_interpreter_environment.
2908 (Feval_buffer): Bind Qlexical_binding.
2909 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
2910 Mark as dynamic.
2911 (syms_of_lread): Declare `lexical-binding'.
2912
2913 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
2914
2915 * keyboard.c (eval_dyn): New fun.
2916 (menu_item_eval_property): Use it.
2917
2918 * image.c (parse_image_spec): Use Ffunctionp.
2919
2920 * fns.c (concat, mapcar1): Accept byte-code-functions.
2921
2922 * eval.c (Fsetq): Handle lexical vars.
2923 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
2924 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
2925 (FletX, Flet): Obey lexical binding.
2926 (Fcommandp): Handle closures.
2927 (Feval): New `lexical' arg.
2928 (eval_sub): New function extracted from Feval. Use it almost
2929 everywhere where Feval was used. Look up vars in lexical env.
2930 Handle closures.
2931 (Ffunctionp): Move from subr.el.
2932 (Ffuncall): Handle closures.
2933 (apply_lambda): Remove `eval_flags'.
2934 (funcall_lambda): Handle closures and new byte-code-functions.
2935 (Fspecial_variable_p): New function.
2936 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
2937 but without exporting it to Lisp.
2938
2939 * doc.c (Fdocumentation, store_function_docstring):
2940 * data.c (Finteractive_form): Handle closures.
2941
2942 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
2943 interactive spec.
2944
2945 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
2946 New byte-codes.
2947 (exec_byte_code): New function extracted from Fbyte_code to handle new
2948 calling convention for byte-code-functions. Add new byte-codes.
2949
2950 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
2951
2952 * alloc.c (Fmake_symbol): Init new `declared_special' field.
2953
2954 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
2955
2956 * xdisp.c (redisplay_internal): Fix prototype.
2957
2958 2011-03-31 Eli Zaretskii <eliz@gnu.org>
2959
2960 * xdisp.c (SCROLL_LIMIT): New macro.
2961 (try_scrolling): Use it when setting scroll_limit.
2962 Limit scrolling to 100 screen lines.
2963 (redisplay_window): Even when falling back on "recentering",
2964 position point in the window according to scroll-conservatively,
2965 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
2966
2967 (try_scrolling): When point is above the window, allow searching
2968 as far as scroll_max, or one screenful, to compute vertical
2969 distance from PT to the scroll margin position. This prevents
2970 try_scrolling from unnecessarily failing when
2971 scroll-conservatively is set to a value slightly larger than the
2972 window height. Clean up the case of PT below the margin at bottom
2973 of window: scroll_max can no longer be INT_MAX. When aggressive
2974 scrolling is in use, don't let point enter the opposite scroll
2975 margin as result of the scroll.
2976 (syms_of_xdisp) <scroll-conservatively>: Document the
2977 threshold of 100 lines for never-recentering scrolling.
2978
2979 2011-03-31 Juanma Barranquero <lekktu@gmail.com>
2980
2981 * dispextern.h (move_it_by_lines):
2982 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
2983 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
2984 (message_log_check_duplicate): Remove parameters `prev_bol' and
2985 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2986 (redisplay_internal): Remove parameter `preserve_echo_area',
2987 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
2988
2989 * indent.c (Fvertical_motion):
2990 * window.c (window_scroll_pixel_based, Frecenter):
2991 Don't pass `need_y_p' to `move_it_by_lines'.
2992
2993 2011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
2994
2995 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
2996 steal a few bits to be more compact.
2997 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
2998 Remove unneeded casts.
2999
3000 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3001
3002 2011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3003
3004 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3005 binding" message (bug#7967).
3006
3007 2011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3008
3009 Fix more problems found by GCC 4.6.0's static checks.
3010
3011 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3012 Remove unused local var.
3013
3014 * editfns.c (Fmessage_box): Remove unused local var.
3015
3016 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3017 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3018 Omit unused local vars.
3019 * window.c (shrink_windows): Omit unused local var.
3020 * menu.c (digest_single_submenu): Omit unused local var.
3021 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3022 Omit unused local var.
3023
3024 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3025 Don't assume string length fits in int.
3026 (keyremap_step, read_key_sequence): Use size_t for sizes.
3027 (read_key_sequence): Don't check last_real_key_start redundantly.
3028
3029 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3030 instead of alloca (Bug#8344).
3031
3032 * eval.c (Fbacktrace): Don't assume nargs fits in int.
3033 (Fbacktrace_frame): Don't assume nframes fits in int.
3034
3035 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3036
3037 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3038 concerns.
3039
3040 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3041
3042 * cm.c (calccost): Turn while-do into do-while, for clarity.
3043
3044 * keyboard.c (syms_of_keyboard): Use the same style as later
3045 in this function when indexing through an array. This also
3046 works around GCC bug 48267.
3047
3048 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3049
3050 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3051
3052 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3053 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3054
3055 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3056 This avoids undefined behavior on integer overflow, and is a bit
3057 more convenient anyway since it is compared to a size_t variable.
3058
3059 Variadic C functions now count arguments with size_t, not int.
3060 This avoids an unnecessary limitation on 64-bit machines, which
3061 caused (substring ...) to crash on large vectors (Bug#8344).
3062 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3063 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
3064 All variadic functions and their callers changed accordingly.
3065 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3066 * data.c (arith_driver, float_arith_driver): Likewise.
3067 * editfns.c (general_insert_function): Likewise.
3068 * eval.c (struct backtrace.nargs, interactive_p)
3069 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3070 (funcall_lambda, mark_backtrace): Likewise.
3071 * fns.c (concat): Likewise.
3072 * frame.c (x_set_frame_parameters): Likewise.
3073 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3074 0 if not found, not -1. All callers changed.
3075
3076 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3077 (stack_copy_size): Now size_t, not int.
3078 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3079
3080 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3081
3082 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3083 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3084 All callers changed.
3085
3086 * lisp.h (multibyte_char_to_unibyte):
3087 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3088 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3089 * character.h (CHAR_TO_BYTE8):
3090 * cmds.c (internal_self_insert):
3091 * editfns.c (general_insert_function):
3092 * keymap.c (push_key_description):
3093 * search.c (Freplace_match):
3094 * xdisp.c (message_dolog, set_message_1): All callers changed.
3095
3096 2011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3097
3098 * keyboard.c (safe_run_hook_funcall): New function.
3099 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3100 don't set the hook to nil, but remove the offending function instead.
3101 (Qcommand_hook_internal): Remove, unused.
3102 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3103 Vcommand_hook_internal.
3104
3105 * eval.c (enum run_hooks_condition): Remove.
3106 (funcall_nil, funcall_not): New functions.
3107 (run_hook_with_args): Call each function through a `funcall' argument.
3108 Remove `cond' argument, now redundant.
3109 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3110 (Frun_hook_with_args_until_failure): Adjust accordingly.
3111 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3112
3113 2011-03-28 Juanma Barranquero <lekktu@gmail.com>
3114
3115 * dispextern.h (string_buffer_position): Remove declaration.
3116
3117 * print.c (strout): Remove parameter `multibyte', unused since
3118 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3119
3120 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3121 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3122 All callers changed.
3123
3124 * w32.c (_wsa_errlist): Use braces for struct initializers.
3125
3126 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3127 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3128 All callers changed.
3129 (string_buffer_position): Likewise. Also, make static (it's never
3130 used outside xdisp.c).
3131 (cursor_row_p): Remove parameter `w', unused since
3132 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3133 (decode_mode_spec): Remove parameter `precision', introduced during
3134 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3135 All callers changed.
3136
3137 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3138
3139 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3140
3141 2011-03-27 Anders Lindgren <andlind@gmail.com>
3142
3143 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3144 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3145 (ns_update_auto_hide_menu_bar): New functions.
3146 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3147 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3148 ns_constrain_all_frames.
3149 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3150 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3151
3152 2011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3153
3154 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3155
3156 2011-03-27 Glenn Morris <rgm@gnu.org>
3157
3158 * syssignal.h: Replace RETSIGTYPE with void.
3159 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3160 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3161 Replace SIGTYPE with void everywhere.
3162 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3163 * s/template.h (SIGTYPE): Remove commented out definition.
3164
3165 2011-03-26 Eli Zaretskii <eliz@gnu.org>
3166
3167 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3168 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3169
3170 2011-03-26 Juanma Barranquero <lekktu@gmail.com>
3171
3172 * w32.c (read_unc_volume): Use parameter `henum', instead of
3173 global variable `wget_enum_handle'.
3174
3175 * keymap.c (describe_vector): Remove parameters `indices' and
3176 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3177 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3178
3179 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3180
3181 * keyboard.c (timer_check): Remove parameter `do_it_now',
3182 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3183 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3184 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3185
3186 * keyboard.c (read_char):
3187 * w32menu.c (w32_menu_display_help):
3188 * xmenu.c (show_help_event, menu_help_callback):
3189 Adjust calls to `show_help_echo'.
3190
3191 * gtkutil.c (xg_maybe_add_timer):
3192 * keyboard.c (readable_events):
3193 * process.c (wait_reading_process_output):
3194 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3195
3196 * insdel.c (adjust_markers_gap_motion):
3197 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3198 (gap_left, gap_right): Don't call it.
3199
3200 2011-03-25 Chong Yidong <cyd@stupidchicken.com>
3201
3202 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3203 incurred during fontification.
3204
3205 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3206
3207 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3208 (DEFVAR_PER_BUFFER): Don't pass it.
3209
3210 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3211 (scrolling_window): Don't pass it.
3212
3213 2011-03-25 Juanma Barranquero <lekktu@gmail.com>
3214
3215 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3216
3217 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3218 and `suffix'.
3219 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3220 of variables specific to SELinux and computation of `encoded_absname'.
3221
3222 * image.c (XPutPixel): Remove unused variable `height'.
3223
3224 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3225
3226 * unexw32.c (get_section_info): Remove unused variable `section'.
3227
3228 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3229 (system_process_attributes): Remove unused variable `sess'.
3230 (sys_read): Remove unused variable `err'.
3231
3232 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3233 (w32_wnd_proc): Remove unused variable `isdead'.
3234 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3235 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3236 (x_create_tip_frame): Remove unused variable `tem'.
3237
3238 * w32inevt.c (w32_console_read_socket):
3239 Remove unused variable `no_events'.
3240
3241 * w32term.c (x_draw_composite_glyph_string_foreground):
3242 Remove unused variable `width'.
3243
3244 2011-03-24 Juanma Barranquero <lekktu@gmail.com>
3245
3246 * w32term.c (x_set_glyph_string_clipping):
3247 Don't pass uninitialized region to CombineRgn.
3248
3249 2011-03-23 Juanma Barranquero <lekktu@gmail.com>
3250
3251 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3252 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3253 (Fx_close_connection): Remove unused variable `i'.
3254
3255 * w32font.c (w32font_draw): Return number of glyphs.
3256 (w32font_open_internal): Remove unused variable `i'.
3257 (w32font_driver): Add missing initializer.
3258
3259 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3260 (fill_in_menu): Remove unused variable `items_added'.
3261
3262 * w32term.c (last_mouse_press_frame): Remove static global variable.
3263 (w32_clip_to_row): Remove unused variable `f'.
3264 (x_delete_terminal): Remove unused variable `i'.
3265
3266 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3267 (NOTHING): Remove unused static global variable.
3268 (uniscribe_check_otf): Remove unused variable `table'.
3269 (uniscribe_font_driver): Add missing initializers.
3270
3271 2011-03-23 Julien Danjou <julien@danjou.info>
3272
3273 * term.c (Fsuspend_tty, Fresume_tty):
3274 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3275 * window.c (temp_output_buffer_show):
3276 * insdel.c (signal_before_change):
3277 * frame.c (Fhandle_switch_frame):
3278 * fileio.c (Fdo_auto_save):
3279 * emacs.c (Fkill_emacs):
3280 * editfns.c (save_excursion_restore):
3281 * cmds.c (internal_self_insert):
3282 * callint.c (Fcall_interactively):
3283 * buffer.c (Fkill_all_local_variables):
3284 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3285 Use Frun_hooks.
3286 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
3287 unconditionnaly since it does the check itself.
3288
3289 2011-03-23 Paul Eggert <eggert@cs.ucla.edu>
3290
3291 Fix more problems found by GCC 4.5.2's static checks.
3292
3293 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3294 the first time through the loop, since we know p0 < p1 then.
3295 This also avoids a gcc -Wstrict-overflow warning.
3296
3297 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3298 leading to a memory leak, possible in functions like
3299 load_charset_map_from_file that can allocate an unbounded number
3300 of objects (Bug#8318).
3301
3302 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3303 that could (at least in theory) be that large.
3304
3305 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3306 This is less likely to overflow, and avoids undefined behavior if
3307 overflow does occur. All callers changed. Use strtoul to scan
3308 for the unsigned long integer.
3309 (pint2hrstr): Simplify and tune code slightly.
3310 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
3311
3312 * scroll.c (do_scrolling): Work around GCC bug 48228.
3313 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3314
3315 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3316 This also avoids a warning with gcc -Wstrict-overflow.
3317 (validate_x_resource_name): Simplify count usage.
3318 This also avoids a warning with gcc -Wstrict-overflow.
3319
3320 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3321 fail (Bug#8306).
3322
3323 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
3324
3325 * process.c (Fmake_network_process): Use socklen_t, not int,
3326 where POSIX says socklen_t is required in portable programs.
3327 This fixes a porting bug on hosts like 64-bit HP-UX, where
3328 socklen_t is wider than int (Bug#8277).
3329 (Fmake_network_process, server_accept_connection):
3330 (wait_reading_process_output, read_process_output):
3331 Likewise.
3332
3333 * process.c: Rename or move locals to avoid shadowing.
3334 (list_processes_1, Fmake_network_process):
3335 (read_process_output_error_handler, exec_sentinel_error_handler):
3336 Rename or move locals.
3337 (Fmake_network_process): Define label "retry_connect" only if needed.
3338 (Fnetwork_interface_info): Fix pointer signedness.
3339 (process_send_signal): Add cast to avoid pointer signedness problem.
3340 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
3341 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
3342
3343 Make tparam.h and terminfo.c consistent.
3344 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3345 Include tparam.h instead, since it declares them.
3346 * cm.h (PC): Remove extern decl; tparam.h now does this.
3347 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3348 * terminfo.c: Include tparam.h, to check interfaces.
3349 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3350 (tparam): Adjust signature to match interface in tparam.h;
3351 this removes some undefined behavior. Check that outstring and len
3352 are zero, which they always are with Emacs.
3353 * tparam.h (PC, BC, UP): New extern decls.
3354
3355 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
3356 (xftfont_open): Rename locals to avoid shadowing.
3357
3358 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
3359 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3360 (OTF_TAG_SYM): Omit macro if not needed.
3361 (ftfont_list): Remove unused local.
3362 (get_adstyle_property, ftfont_pattern_entity):
3363 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3364 Rename locals to avoid shadowing.
3365
3366 * xfont.c (xfont_list_family): Mark var as initialized.
3367
3368 * xml.c (make_dom): Now static.
3369
3370 * composite.c (composition_compute_stop_pos): Rename local to
3371 avoid shadowing.
3372 (composition_reseat_it): Remove unused locals.
3373 (find_automatic_composition, composition_adjust_point): Likewise.
3374 (composition_update_it): Mark var as initialized.
3375 (find_automatic_composition): Mark vars as initialized,
3376 with a FIXME (Bug#8290).
3377
3378 character.h: Rename locals to avoid shadowing.
3379 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3380 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3381 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3382 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3383 to avoid shadowing.
3384
3385 * textprop.c (property_change_between_p): Remove; unused.
3386
3387 * intervals.c (interval_start_pos): Now static.
3388
3389 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3390
3391 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3392 Rename locals to avoid shadowing.
3393
3394 * sound.c (wav_play, au_play, Fplay_sound_internal):
3395 Fix pointer signedness.
3396 (alsa_choose_format): Remove unused local var.
3397 (wav_play): Initialize a variable to 0, to prevent undefined
3398 behavior (Bug#8278).
3399
3400 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3401
3402 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3403
3404 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3405 clobbering (Bug#8298).
3406 * sysdep.c (sys_subshell): Likewise.
3407 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
3408
3409 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3410 This should get cleaned up, so that child_setup has the
3411 same signature on all platforms.
3412
3413 * callproc.c (call_process_cleanup): Now static.
3414 (relocate_fd): Rename locals to avoid shadowing.
3415
3416 2011-03-22 Chong Yidong <cyd@stupidchicken.com>
3417
3418 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3419 not to be necessary, and produces flickering.
3420
3421 2011-03-20 Glenn Morris <rgm@gnu.org>
3422
3423 * config.in: Remove file.
3424
3425 2011-03-20 Juanma Barranquero <lekktu@gmail.com>
3426
3427 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3428 are now in src/globals.h.
3429 (syms_of_minibuf): Remove spurious & from previous change.
3430
3431 2011-03-20 Leo <sdl.web@gmail.com>
3432
3433 * minibuf.c (completing-read-function): New variable.
3434 (completing-read-default): Rename from completing-read.
3435 (completing-read): Call completing-read-function.
3436
3437 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3438
3439 * xfaces.c (Fx_load_color_file):
3440 Read color file from absolute filename (bug#8250).
3441
3442 2011-03-19 Juanma Barranquero <lekktu@gmail.com>
3443
3444 * makefile.w32-in: Update dependencies.
3445
3446 2011-03-17 Eli Zaretskii <eliz@gnu.org>
3447
3448 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3449
3450 2011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3451
3452 Fix more problems found by GCC 4.5.2's static checks.
3453
3454 * process.c (make_serial_process_unwind, send_process_trap):
3455 (sigchld_handler): Now static.
3456
3457 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3458 That way, the code declares only the vars that it needs.
3459 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3460 * s/cygwin.h (PTY_ITERATION): Likewise.
3461 * s/darwin.h (PTY_ITERATION): Likewise.
3462 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3463
3464 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3465 * process.c (allocate_pty): Don't declare stb unless it's needed.
3466
3467 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
3468 (CONSTANTLIM): Remove; unused.
3469 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3470 Define only if needed.
3471
3472 * unexelf.c (unexec): Name an expression,
3473 to avoid gcc -Wbad-function-cast warning.
3474 Use a different way to cause a compilation error if anyone uses
3475 n rather than nn, a way that does not involve shadowing.
3476 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
3477
3478 * deps.mk (unexalpha.o): Remove; unused.
3479
3480 New file unexec.h, the (simple) interface for unexec (Bug#8267).
3481 * unexec.h: New file.
3482 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3483 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3484 Depend on unexec.h.
3485 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3486 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3487 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
3488 Change as necessary to match prototype in unexec.h.
3489
3490 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3491 shadowing.
3492 (back_comment, skip_chars): Mark vars as initialized.
3493
3494 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3495 Rename locals to avoid shadowing.
3496
3497 * lread.c (read1): Rewrite so as not to use empty "else".
3498 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
3499
3500 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3501
3502 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3503 warning when compiling print.c.
3504
3505 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3506 instead of using an uninitialized var.
3507 (font_sort_entities): Mark var as initialized.
3508
3509 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3510
3511 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3512 pointers to constants.
3513 (font_parse_fcname): Remove unused vars.
3514 (font_delete_unmatched): Now static.
3515 (font_get_spec): Remove; unused.
3516 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3517 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3518 Rename or move locals to avoid shadowing.
3519
3520 * fns.c (require_nesting_list, require_unwind): Now static.
3521 (Ffillarray): Rename locals to avoid shadowing.
3522
3523 * floatfns.c (domain_error2): Define only if needed.
3524 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
3525
3526 * alloc.c (mark_backtrace): Move decl from here ...
3527 * lisp.h: ... to here, so that it can be checked.
3528
3529 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
3530 (Fdefvar): Rewrite so as not to use empty "else".
3531 (lisp_indirect_variable): Name an expression,
3532 to avoid gcc -Wbad-function-cast warning.
3533 (Fdefvar): Rename locals to avoid shadowing.
3534
3535 * callint.c (quotify_arg, quotify_args): Now static.
3536 (Fcall_interactively): Rename locals to avoid shadowing.
3537 Use const pointer when appropriate.
3538
3539 * lisp.h (get_system_name, get_operating_system_release):
3540 Move decls here, to check interfaces.
3541 * process.c (get_operating_system_release): Move decl to lisp.h.
3542 * xrdb.c (get_system_name): Likewise.
3543 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
3544 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
3545 some of which prompt warnings from gcc -Wbad-function-cast.
3546 (Fformat_time_string, Fencode_time, Finsert_char):
3547 (Ftranslate_region_internal, Fformat):
3548 Rename or remove local vars to avoid shadowing.
3549 (Ftranslate_region_internal): Mark var as initialized.
3550
3551 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
3552 avoid shadowing.
3553
3554 * lisp.h (eassert): Check that the argument compiles, even if
3555 ENABLE_CHECKING is not defined.
3556
3557 * data.c (Findirect_variable): Name an expression, to avoid
3558 gcc -Wbad-function-cast warning.
3559 (default_value, arithcompare, arith_driver, arith_error): Now static.
3560 (store_symval_forwarding): Rename local to avoid shadowing.
3561 (Fmake_variable_buffer_local, Fmake_local_variable):
3562 Mark variables as initialized.
3563 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
3564
3565 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
3566 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
3567 Rename locals to avoid shadowing.
3568 (mark_stack): Move local variables into the #ifdef region where
3569 they're used.
3570 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
3571 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
3572 needed otherwise.
3573 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
3574 (GC_STRING_CHARS): Remove; not used.
3575 (Fmemory_limit): Cast sbrk's returned value to char *.
3576
3577 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
3578 avoids undefined behavior in theory.
3579
3580 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
3581
3582 Use functions, not macros, for up- and down-casing (Bug#8254).
3583 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3584 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
3585 to use the following functions instead of these macros.
3586 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
3587 EMACS_INT, since callers assume the returned value fits in int.
3588 (upcase1): Likewise, for UPCASE_TABLE.
3589 (uppercasep, lowercasep, upcase): New static inline functions.
3590 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
3591 the race-condition problem in the old DOWNCASE.
3592
3593 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
3594 Rename locals to avoid shadowing.
3595 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
3596 (regex_compile, re_search_2, re_match_2_internal):
3597 Remove unused local vars.
3598 (FREE_VAR): Rewrite so as not to use empty "else",
3599 which gcc can warn about.
3600 (regex_compile, re_match_2_internal): Mark locals as initialized.
3601 (RETALLOC_IF): Define only if needed.
3602 (WORDCHAR_P): Likewise. This one is never needed, but is used
3603 only in a comment talking about a compiler bug, so put inside
3604 the #if 0 of that comment.
3605 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
3606 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
3607 Remove; unused.
3608
3609 * search.c (boyer_moore): Rename locals to avoid shadowing.
3610 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
3611 (PREV_CHAR_BOUNDARY): Likewise.
3612
3613 * search.c (simple_search): Remove unused var.
3614
3615 * dired.c (compile_pattern): Move decl from here ...
3616 * lisp.h: ... to here, so that it can be checked.
3617 (struct re_registers): New forward decl.
3618
3619 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
3620
3621 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
3622 All uses changed.
3623 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
3624 Rename locals to avoid shadowing.
3625 (Fvertical_motion): Mark locals as initialized.
3626
3627 * casefiddle.c (casify_object, casify_region): Now static.
3628 (casify_region): Mark local as initialized.
3629
3630 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
3631
3632 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3633 New macros, so that the caller can use some names other than
3634 gcpro1, gcpro2, etc.
3635 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3636 of the new macros.
3637 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3638 argument, for consistency with GCPRO2_VAR, etc: it is now the
3639 prefix of the variable, not the variable itself. All uses
3640 changed.
3641 * dired.c (directory_files_internal, file_name_completion):
3642 Rename locals to avoid shadowing.
3643
3644 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
3645 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
3646 dired.c's scmp function, had undefined behavior.
3647 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3648 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
3649 * buffer.h: ... to here, because these macros use current_buffer,
3650 and the new implementation with inline functions needs to have
3651 current_buffer in scope now, rather than later when the macros
3652 are used.
3653 (downcase, upcase1): New static inline functions.
3654 (DOWNCASE, UPCASE1): Reimplement using these functions.
3655 This avoids undefined behavior in expressions like
3656 DOWNCASE (x) == DOWNCASE (y), which previously suffered
3657 from race conditions in accessing the global variables
3658 case_temp1 and case_temp2.
3659 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
3660 * lisp.h (case_temp1, case_temp2): Remove their decls.
3661 * character.h (ASCII_CHAR_P): Move from here ...
3662 * lisp.h: ... to here, so that the inline functions mentioned
3663 above can use them.
3664
3665 * dired.c (directory_files_internal_unwind): Now static.
3666
3667 * fileio.c (file_name_as_directory, directory_file_name):
3668 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
3669 Now static.
3670 (file_name_as_directory): Use const pointers when appropriate.
3671 (Fexpand_file_name): Likewise. In particular, newdir might
3672 point at constant storage, so make it a const pointer.
3673 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
3674 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
3675 signedness issues.
3676 (Fset_file_times, Finsert_file_contents, auto_save_error):
3677 Rename locals to avoid shadowing.
3678
3679 * minibuf.c (choose_minibuf_frame_1): Now static.
3680 (Ftry_completion, Fall_completions): Rename or remove locals
3681 to avoid shadowing.
3682
3683 * marker.c (bytepos_to_charpos): Remove; unused.
3684
3685 * lisp.h (verify_bytepos, count_markers): New decls,
3686 so that gcc does not warn that these functions aren't declared.
3687
3688 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
3689 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
3690 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
3691 (copy_text): Remove unused local var.
3692
3693 * filelock.c (within_one_second): Now static.
3694 (lock_file_1): Rename local to avoid shadowing.
3695
3696 * buffer.c (fix_overlays_before): Mark locals as initialized.
3697 (fix_start_end_in_overlays): Likewise. This function should be
3698 simplified by using pointers-to-pointers, but that's a different
3699 matter.
3700 (switch_to_buffer_1): Now static.
3701 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
3702 (report_overlay_modification): Rename locals to avoid shadowing.
3703
3704 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
3705 Fix pointer signedness issue.
3706 (sys_subshell): Mark local as volatile if checking for lint,
3707 to suppress a gcc -Wclobbered warning that does not seem to be right.
3708 (MAXPATHLEN): Define only if needed.
3709
3710 * process.c (serial_open, serial_configure): Move decls from here ...
3711 * systty.h: ... to here, so that they can be checked.
3712
3713 * fns.c (get_random, seed_random): Move extern decls from here ...
3714 * lisp.h: ... to here, so that they can be checked.
3715
3716 * sysdep.c (reset_io): Now static.
3717 (wait_for_termination_signal): Remove; unused.
3718
3719 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
3720 (copy_keymap_item, append_key, push_text_char_description):
3721 Now static.
3722 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
3723 (DENSE_TABLE_SIZE): Remove; unused.
3724 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
3725 (describe_map_tree):
3726 Rename locals to avoid shadowing.
3727
3728 * keyboard.c: Declare functions static if they are not used elsewhere.
3729 (echo_char, echo_dash, cmd_error, top_level_2):
3730 (poll_for_input, handle_async_input): Now static.
3731 (read_char, kbd_buffer_get_event, make_lispy_position):
3732 (make_lispy_event, make_lispy_movement, apply_modifiers):
3733 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
3734 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
3735 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
3736 (read_key_sequence, read_char): Mark locals as initialized.
3737 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
3738
3739 * keyboard.h (make_ctrl_char): New decl.
3740 (mark_kboards): Move decl here ...
3741 * alloc.c (mark_kboards): ... from here.
3742
3743 * lisp.h (force_auto_save_soon): New decl.
3744
3745 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
3746 (DEFINE_DUMMY_FUNCTION): New macro.
3747 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
3748 Use it.
3749 (main): Add casts to avoid warnings
3750 if GCC considers string literals to be constants.
3751
3752 * lisp.h (fatal_error_signal): Add decl, since it's exported.
3753
3754 * dbusbind.c: Pointer signedness fixes.
3755 (xd_signature, xd_append_arg, xd_initialize):
3756 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3757 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3758 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
3759 (Fdbus_register_signal): Use SSDATA when the context wants char *.
3760
3761 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
3762 if GCC considers string literals to be constants.
3763 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
3764
3765 2011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
3766
3767 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
3768 (print_preprocess, print_object): New macro to fix last change.
3769
3770 * print.c (print_preprocess): Don't forget font objects.
3771
3772 2011-03-16 Juanma Barranquero <lekktu@gmail.com>
3773
3774 * emacs.c (USAGE3): Doc fixes.
3775
3776 2011-03-15 Andreas Schwab <schwab@linux-m68k.org>
3777
3778 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3779 structure.
3780
3781 2011-03-14 Juanma Barranquero <lekktu@gmail.com>
3782
3783 * lisp.h (VWindow_system, Qfile_name_history):
3784 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3785 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3786 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3787
3788 * w32select.c: Don't #include "keyboard.h".
3789 (run_protected): Add extern declaration for waiting_for_input.
3790
3791 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3792 * w32console.c (detect_input_pending, read_input_pending)
3793 (encode_terminal_code):
3794 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3795 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3796 (w32_system_caret_y, Qfile_name_history):
3797 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3798 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3799 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3800 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3801 * w32proc.c (Qlocal, report_file_error):
3802 * w32term.c (Vwindow_system, updating_frame):
3803 * w32uniscribe.c (initialized, uniscribe_font_driver):
3804 Remove unneeded extern declarations.
3805
3806 2011-03-14 Chong Yidong <cyd@stupidchicken.com>
3807
3808 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
3809
3810 2011-03-13 Chong Yidong <cyd@stupidchicken.com>
3811
3812 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3813 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3814 These macros can no longer be used for assignment.
3815
3816 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3817 Assign struct members directly, instead of using BUF_BEGV etc.
3818 (record_buffer_markers, fetch_buffer_markers): New functions for
3819 recording and fetching special buffer markers.
3820 (set_buffer_internal_1, set_buffer_temp): Use them.
3821
3822 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3823
3824 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3825
3826 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3827 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3828
3829 * xdisp.c (hscroll_window_tree):
3830 (reconsider_clip_changes): Use PT instead of BUF_PT.
3831
3832 2011-03-13 Eli Zaretskii <eliz@gnu.org>
3833
3834 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3835 $(EMACS_ROOT)/lib/intprops.h.
3836
3837 2011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3838
3839 Fix more problems found by GCC 4.5.2's static checks.
3840
3841 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
3842 to unsigned char * to avoid compiler diagnostic.
3843 (xg_free_frame_widgets): Make it clear that a local variable is
3844 needed only if USE_GTK_TOOLTIP.
3845 (gdk_window_get_screen): Make it clear that this macro is needed
3846 only if USE_GTK_TOOLTIP.
3847 (int_gtk_range_get_value): New function, which avoids a diagnostic
3848 from gcc -Wbad-function-cast.
3849 (xg_set_toolkit_scroll_bar_thumb): Use it.
3850 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
3851 diagnostic from gcc -Wbad-function-cast.
3852 (get_utf8_string, xg_get_file_with_chooser):
3853 Rename locals to avoid shadowing.
3854 (create_dialog): Move locals to avoid shadowing.
3855
3856 * xgselect.c (xg_select): Remove unused var.
3857
3858 * image.c (four_corners_best): Mark locals as initialized.
3859 (gif_load): Initialize transparent_p to zero (Bug#8238).
3860 Mark another local as initialized.
3861 (my_png_error, my_error_exit): Mark with NO_RETURN.
3862
3863 * image.c (clear_image_cache): Now static.
3864 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
3865 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
3866 (x_edge_detection): Remove unnecessary cast that
3867 gcc -Wbad-function-cast diagnoses.
3868 (gif_load): Fix pointer signedness.
3869 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
3870 (jpeg_load, gif_load): Rename locals to avoid shadowing.
3871
3872 2011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3873
3874 Improve quality of tests for time stamp overflow.
3875 For example, without this patch (encode-time 0 0 0 1 1
3876 1152921504606846976) returns the obviously-bogus value (-948597
3877 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
3878 reports time overflow. See
3879 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
3880 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
3881 * editfns.c: Include limits.h and intprops.h.
3882 (TIME_T_MIN, TIME_T_MAX): New macros.
3883 (time_overflow): Move earlier, to before first use.
3884 (hi_time, lo_time): New functions, for an accurate test for
3885 out-of-range times.
3886 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
3887 (Fget_internal_run_time): Don't assume time_t fits in int.
3888 (make_time): Use list2 instead of Fcons twice.
3889 (Fdecode_time): More accurate test for out-of-range times.
3890 (check_tm_member): New function.
3891 (Fencode_time): Use it, to test for out-of-range times.
3892 (lisp_time_argument): Don't rely on undefined left-shift and
3893 right-shift behavior when checking for time stamp overflow.
3894
3895 * editfns.c (time_overflow): New function, refactoring common code.
3896 (Fformat_time_string, Fdecode_time, Fencode_time):
3897 (Fcurrent_time_string): Use it.
3898
3899 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
3900 * dired.c (make_time): Move to ...
3901 * editfns.c (make_time): ... here.
3902 * systime.h: Note the move.
3903
3904 2011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3905
3906 * fringe.c (update_window_fringes): Remove unused variables.
3907
3908 * unexmacosx.c (copy_data_segment): Also copy __got section.
3909 (Bug#8223)
3910
3911 2011-03-12 Eli Zaretskii <eliz@gnu.org>
3912
3913 * termcap.c [MSDOS]: Include "msdos.h".
3914 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
3915 Constify `char *' arguments and their references according to
3916 prototypes in tparam.h.
3917
3918 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
3919
3920 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
3921 Adapt all references accordingly.
3922
3923 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
3924
3925 2011-03-11 Tom Tromey <tromey@redhat.com>
3926
3927 * buffer.c (syms_of_buffer): Remove obsolete comment.
3928
3929 2011-03-11 Eli Zaretskii <eliz@gnu.org>
3930
3931 * termhooks.h (encode_terminal_code): Declare prototype.
3932
3933 * msdos.c (encode_terminal_code): Don't declare prototype.
3934
3935 * term.c (encode_terminal_code): Now external again, used by
3936 w32console.c and msdos.c.
3937
3938 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
3939 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
3940
3941 2011-03-11 Paul Eggert <eggert@cs.ucla.edu>
3942
3943 Fix some minor problems found by GCC 4.5.2's static checks.
3944
3945 * fringe.c (update_window_fringes): Mark locals as initialized
3946 (Bug#8227).
3947 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
3948
3949 * alloc.c (mark_fringe_data): Move decl from here ...
3950 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
3951 to check its interface.
3952 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
3953
3954 * fontset.c (free_realized_fontset): Now static.
3955 (Fset_fontset_font): Rename local to avoid shadowing.
3956 (fontset_font): Mark local as initialized.
3957 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
3958
3959 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
3960
3961 * xselect.c (x_disown_buffer_selections): Remove; not used.
3962 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
3963 (x_own_selection, Fx_disown_selection_internal): Rename locals
3964 to avoid shadowing.
3965 (x_handle_dnd_message): Remove local to avoid shadowing.
3966
3967 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
3968 so that the caller can use some name other than gcpro1.
3969 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
3970 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3971 (Fx_backspace_delete_keys_p):
3972 Use them to avoid shadowing, and rename vars to avoid shadowing.
3973 (x_decode_color, x_set_name, x_window): Now static.
3974 (Fx_create_frame): Add braces to silence GCC warning.
3975 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
3976 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
3977 Remove unused locals.
3978 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
3979 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
3980 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
3981 macros.
3982
3983 * xterm.h (x_mouse_leave): New decl.
3984
3985 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
3986 Remove unused functions.
3987 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
3988 (x_calc_absolute_position): Now static.
3989 (XTread_socket): Don't define label "out" unless it's used.
3990 Don't declare local "event" unless it's used.
3991 (x_iconify_frame, x_free_frame_resources): Don't declare locals
3992 unless they are used.
3993 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
3994 (x_fatal_error_signal): Remove; not used.
3995 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
3996 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
3997 (x_error_catcher, x_connection_closed, x_error_handler):
3998 (x_error_quitter, xembed_send_message, x_iconify_frame):
3999 (my_log_handler): Rename locals to avoid shadowing.
4000 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
4001 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
4002
4003 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4004 Rename or move locals to avoid shadowing.
4005 (tty_defined_color, merge_face_heights): Now static.
4006 (free_realized_faces_for_fontset): Remove; not used.
4007 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4008 does not deduce is never used uninitialized.
4009 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4010 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
4011
4012 * terminal.c (store_terminal_param): Now static.
4013
4014 * xmenu.c (menu_highlight_callback): Now static.
4015 (set_frame_menubar): Remove unused local.
4016 (xmenu_show): Rename parameter to avoid shadowing.
4017 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4018 since they might point to immutable storage.
4019 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4020 since it's unused otherwise.
4021
4022 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
4023 Add a FIXME, since the code still doesn't look right. (Bug#8215)
4024 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4025 avoids a gcc -Wuninitialized diagnostic.
4026 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
4027 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4028 does not deduce are never used uninitialized.
4029
4030 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4031
4032 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4033 * window.c (window_loop, size_window):
4034 (run_window_configuration_change_hook, enlarge_window): Likewise.
4035
4036 * window.c (display_buffer): Now static.
4037 (size_window): Mark variables that gcc -Wuninitialized
4038 does not deduce are never used uninitialized.
4039 * window.h (check_all_windows): New decl, to forestall
4040 gcc -Wmissing-prototypes diagnostic.
4041 * dispextern.h (bidi_dump_cached_states): Likewise.
4042
4043 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4044 shadowing.
4045 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
4046 Include <limits.h>.
4047 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4048 and to avoid gcc -Wuninitialized warning.
4049 (load_charset_map): Mark variables that gcc -Wuninitialized
4050 does not deduce are never used uninitialized.
4051 (load_charset): Abort instead of using uninitialized var (Bug#8229).
4052
4053 * coding.c (coding_set_source, coding_set_destination):
4054 Use "else { /* comment */ }" rather than "else /* comment */;"
4055 for clarity, and to avoid gcc -Wempty-body warning.
4056 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4057 a block, when the outer 'i' will do.
4058 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4059 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4060 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4061 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4062 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4063 Rename locals to avoid shadowing.
4064 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
4065 * coding.c (emacs_mule_char, encode_invocation_designation):
4066 Now static, since they're not used elsewhere.
4067 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
4068 (decode_coding_object, encode_coding_object, detect_coding_system):
4069 (decode_coding_emacs_mule): Mark variables that gcc
4070 -Wuninitialized does not deduce are never used uninitialized.
4071 (detect_coding_iso_2022): Initialize a local variable that might
4072 be used uninitialized. Leave a FIXME because it's not clear that
4073 this initialization is needed. (Bug#8211)
4074 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4075 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4076 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4077 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4078 Remove unused macros.
4079
4080 * category.c (hash_get_category_set): Remove unused local var.
4081 (copy_category_table): Now static, since it's not used elsewhere.
4082 * character.c (string_count_byte8): Likewise.
4083
4084 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4085 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4086
4087 * chartab.c (copy_sub_char_table): Now static, since it's not used
4088 elsewhere.
4089 (sub_char_table_ref_and_range, char_table_ref_and_range):
4090 Rename locals to avoid shadowing.
4091 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
4092
4093 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
4094 (BIDI_BOB): Remove unused macro.
4095
4096 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4097 deduce are never used uninitialized.
4098 * term.c (encode_terminal_code): Likewise.
4099
4100 * term.c (encode_terminal_code): Now static. Remove unused local.
4101
4102 * tparam.h: New file.
4103 * term.c, tparam.h: Include it.
4104 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4105 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4106 Move these decls to tparam.h, and make them agree with what
4107 is actually in tparam.c. The previous trick of using incompatible
4108 decls in different modules does not conform to the C standard.
4109 All callers of tparam changed to use tparam's actual API.
4110 * tparam.c (tparam1, tparam, tgoto):
4111 Use const pointers where appropriate.
4112
4113 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4114 * cm.h (struct cm): Likewise.
4115 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4116 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4117 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4118 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4119 (turn_on_face, init_tty): Likewise.
4120 * termchar.h (struct tty_display_info): Likewise.
4121
4122 * term.c (term_mouse_position): Rename local to avoid shadowing.
4123
4124 * alloc.c (mark_ttys): Move decl from here ...
4125 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4126
4127 2011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4128
4129 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4130
4131 2011-03-09 Juanma Barranquero <lekktu@gmail.com>
4132
4133 * search.c (compile_pattern_1): Remove argument regp, unused since
4134 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4135 (compile_pattern): Don't pass it.
4136
4137 2011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4138
4139 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4140 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4141 for ! HAVE_GTK3.
4142 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4143
4144 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4145
4146 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4147 gdk_window_get_screen, gdk_window_get_geometry,
4148 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4149 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4150 (xg_get_pixbuf_from_pixmap): New function.
4151 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4152 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4153 Call xg_get_pixbuf_from_pixmap instead of
4154 gdk_pixbuf_get_from_drawable.
4155 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4156 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4157 (xg_check_special_colors): Use GtkStyleContext and its functions
4158 for HAVE_GTK3.
4159 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4160 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4161 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
4162 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4163 Call gtk_widget_get_preferred_size.
4164 (xg_frame_resized): gdk_window_get_geometry only takes 5
4165 parameters.
4166 (xg_win_to_widget, xg_event_is_for_menubar):
4167 Call gdk_x11_window_lookup_for_display.
4168 (xg_set_widget_bg): New function.
4169 (delete_cb): New function.
4170 (xg_create_frame_widgets): Connect delete-event to delete_cb.
4171 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4172 (xg_set_background_color): Call xg_set_widget_bg.
4173 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4174 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4175 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4176 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4177 if ! HAVE_GTK3.
4178 (update_frame_tool_bar): Call gtk_widget_hide.
4179 (xg_initialize): Use GDK_KEY_g.
4180
4181 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4182 if ! HAVE_GTK3
4183 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4184
4185 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4186 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4187 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4188
4189 2011-03-08 Juanma Barranquero <lekktu@gmail.com>
4190
4191 * w32xfns.c (select_palette): Check success of RealizePalette against
4192 GDI_ERROR, not zero.
4193
4194 See ChangeLog.11 for earlier changes.
4195
4196 ;; Local Variables:
4197 ;; coding: utf-8
4198 ;; End:
4199
4200 Copyright (C) 2011 Free Software Foundation, Inc.
4201
4202 This file is part of GNU Emacs.
4203
4204 GNU Emacs is free software: you can redistribute it and/or modify
4205 it under the terms of the GNU General Public License as published by
4206 the Free Software Foundation, either version 3 of the License, or
4207 (at your option) any later version.
4208
4209 GNU Emacs is distributed in the hope that it will be useful,
4210 but WITHOUT ANY WARRANTY; without even the implied warranty of
4211 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4212 GNU General Public License for more details.
4213
4214 You should have received a copy of the GNU General Public License
4215 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.